{"action":"closed","number":171,"pull_request":{"url":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls/171","id":43806221,"html_url":"https://github.com/sphereio/sphere-sunrise/pull/171","diff_url":"https://github.com/sphereio/sphere-sunrise/pull/171.diff","patch_url":"https://github.com/sphereio/sphere-sunrise/pull/171.patch","issue_url":"https://api.github.com/repos/sphereio/sphere-sunrise/issues/171","number":171,"state":"closed","locked":false,"title":"Facet classes applied","user":{"login":"lauraluiz","id":1917621,"avatar_url":"https://avatars.githubusercontent.com/u/1917621?v=3","gravatar_id":"","url":"https://api.github.com/users/lauraluiz","html_url":"https://github.com/lauraluiz","followers_url":"https://api.github.com/users/lauraluiz/followers","following_url":"https://api.github.com/users/lauraluiz/following{/other_user}","gists_url":"https://api.github.com/users/lauraluiz/gists{/gist_id}","starred_url":"https://api.github.com/users/lauraluiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lauraluiz/subscriptions","organizations_url":"https://api.github.com/users/lauraluiz/orgs","repos_url":"https://api.github.com/users/lauraluiz/repos","events_url":"https://api.github.com/users/lauraluiz/events{/privacy}","received_events_url":"https://api.github.com/users/lauraluiz/received_events","type":"User","site_admin":false},"body":"@schleichardt @butenkor please review.\r\n\r\nIt's the continuation from the previous Facet PR. Before it was just the classes with no real application. Now they are used to display the facets in the POP, so they underwent some big changes.\r\nAs now they are working, they are also fully tested and documented.\r\n\r\nSome considerations:\r\n\r\n- To avoid making the PR longer, the `ProductOverviewPageController` is not optimized. Also, it needs some bigger picture to extract properly the methods, that's why I simply put everything in there. Later, along with the `ProductDetailPageController`, it will be improved.\r\n\r\n- Colors and sizes need some more work, like getting the enum values from the Product Type to display it properly (i.e. show the correct localized name, in the case of colors). That will be the work of a future PR.\r\n\r\n- I have overridden the `filters-sidebar.hbs` template because the implementation in `sunrise-design` is not generic enough. Once I merge the PR I will apply this changes to `sunrise-design` as it also need some CSS/JS modification (which are wrote down in `main.css`).","created_at":"2015-08-31T20:27:50Z","updated_at":"2015-09-02T12:58:31Z","closed_at":"2015-09-02T12:58:31Z","merged_at":null,"merge_commit_sha":null,"assignee":{"login":"schleichardt","id":1320833,"avatar_url":"https://avatars.githubusercontent.com/u/1320833?v=3","gravatar_id":"","url":"https://api.github.com/users/schleichardt","html_url":"https://github.com/schleichardt","followers_url":"https://api.github.com/users/schleichardt/followers","following_url":"https://api.github.com/users/schleichardt/following{/other_user}","gists_url":"https://api.github.com/users/schleichardt/gists{/gist_id}","starred_url":"https://api.github.com/users/schleichardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schleichardt/subscriptions","organizations_url":"https://api.github.com/users/schleichardt/orgs","repos_url":"https://api.github.com/users/schleichardt/repos","events_url":"https://api.github.com/users/schleichardt/events{/privacy}","received_events_url":"https://api.github.com/users/schleichardt/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/sphereio/sphere-sunrise/milestones/4","html_url":"https://github.com/sphereio/sphere-sunrise/milestones/0.1.0","labels_url":"https://api.github.com/repos/sphereio/sphere-sunrise/milestones/4/labels","id":1190521,"number":4,"title":"0.1.0","description":"","creator":{"login":"schleichardt","id":1320833,"avatar_url":"https://avatars.githubusercontent.com/u/1320833?v=3","gravatar_id":"","url":"https://api.github.com/users/schleichardt","html_url":"https://github.com/schleichardt","followers_url":"https://api.github.com/users/schleichardt/followers","following_url":"https://api.github.com/users/schleichardt/following{/other_user}","gists_url":"https://api.github.com/users/schleichardt/gists{/gist_id}","starred_url":"https://api.github.com/users/schleichardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schleichardt/subscriptions","organizations_url":"https://api.github.com/users/schleichardt/orgs","repos_url":"https://api.github.com/users/schleichardt/repos","events_url":"https://api.github.com/users/schleichardt/events{/privacy}","received_events_url":"https://api.github.com/users/schleichardt/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":20,"state":"open","created_at":"2015-07-02T12:38:25Z","updated_at":"2015-09-02T12:58:31Z","due_on":"2015-08-04T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls/171/commits","review_comments_url":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls/171/comments","review_comment_url":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sphereio/sphere-sunrise/issues/171/comments","statuses_url":"https://api.github.com/repos/sphereio/sphere-sunrise/statuses/d84c134eb767aee23c1335e1fd1a157f6049e4b2","head":{"label":"sphereio:pop-filters-#134","ref":"pop-filters-#134","sha":"d84c134eb767aee23c1335e1fd1a157f6049e4b2","user":{"login":"sphereio","id":4119130,"avatar_url":"https://avatars.githubusercontent.com/u/4119130?v=3","gravatar_id":"","url":"https://api.github.com/users/sphereio","html_url":"https://github.com/sphereio","followers_url":"https://api.github.com/users/sphereio/followers","following_url":"https://api.github.com/users/sphereio/following{/other_user}","gists_url":"https://api.github.com/users/sphereio/gists{/gist_id}","starred_url":"https://api.github.com/users/sphereio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphereio/subscriptions","organizations_url":"https://api.github.com/users/sphereio/orgs","repos_url":"https://api.github.com/users/sphereio/repos","events_url":"https://api.github.com/users/sphereio/events{/privacy}","received_events_url":"https://api.github.com/users/sphereio/received_events","type":"Organization","site_admin":false},"repo":{"id":20036001,"name":"sphere-sunrise","full_name":"sphereio/sphere-sunrise","owner":{"login":"sphereio","id":4119130,"avatar_url":"https://avatars.githubusercontent.com/u/4119130?v=3","gravatar_id":"","url":"https://api.github.com/users/sphereio","html_url":"https://github.com/sphereio","followers_url":"https://api.github.com/users/sphereio/followers","following_url":"https://api.github.com/users/sphereio/following{/other_user}","gists_url":"https://api.github.com/users/sphereio/gists{/gist_id}","starred_url":"https://api.github.com/users/sphereio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphereio/subscriptions","organizations_url":"https://api.github.com/users/sphereio/orgs","repos_url":"https://api.github.com/users/sphereio/repos","events_url":"https://api.github.com/users/sphereio/events{/privacy}","received_events_url":"https://api.github.com/users/sphereio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sphereio/sphere-sunrise","description":"The next generation SPHERE.IO demo shop template","fork":false,"url":"https://api.github.com/repos/sphereio/sphere-sunrise","forks_url":"https://api.github.com/repos/sphereio/sphere-sunrise/forks","keys_url":"https://api.github.com/repos/sphereio/sphere-sunrise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sphereio/sphere-sunrise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sphereio/sphere-sunrise/teams","hooks_url":"https://api.github.com/repos/sphereio/sphere-sunrise/hooks","issue_events_url":"https://api.github.com/repos/sphereio/sphere-sunrise/issues/events{/number}","events_url":"https://api.github.com/repos/sphereio/sphere-sunrise/events","assignees_url":"https://api.github.com/repos/sphereio/sphere-sunrise/assignees{/user}","branches_url":"https://api.github.com/repos/sphereio/sphere-sunrise/branches{/branch}","tags_url":"https://api.github.com/repos/sphereio/sphere-sunrise/tags","blobs_url":"https://api.github.com/repos/sphereio/sphere-sunrise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sphereio/sphere-sunrise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sphereio/sphere-sunrise/git/refs{/sha}","trees_url":"https://api.github.com/repos/sphereio/sphere-sunrise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sphereio/sphere-sunrise/statuses/{sha}","languages_url":"https://api.github.com/repos/sphereio/sphere-sunrise/languages","stargazers_url":"https://api.github.com/repos/sphereio/sphere-sunrise/stargazers","contributors_url":"https://api.github.com/repos/sphereio/sphere-sunrise/contributors","subscribers_url":"https://api.github.com/repos/sphereio/sphere-sunrise/subscribers","subscription_url":"https://api.github.com/repos/sphereio/sphere-sunrise/subscription","commits_url":"https://api.github.com/repos/sphereio/sphere-sunrise/commits{/sha}","git_commits_url":"https://api.github.com/repos/sphereio/sphere-sunrise/git/commits{/sha}","comments_url":"https://api.github.com/repos/sphereio/sphere-sunrise/comments{/number}","issue_comment_url":"https://api.github.com/repos/sphereio/sphere-sunrise/issues/comments{/number}","contents_url":"https://api.github.com/repos/sphereio/sphere-sunrise/contents/{+path}","compare_url":"https://api.github.com/repos/sphereio/sphere-sunrise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sphereio/sphere-sunrise/merges","archive_url":"https://api.github.com/repos/sphereio/sphere-sunrise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sphereio/sphere-sunrise/downloads","issues_url":"https://api.github.com/repos/sphereio/sphere-sunrise/issues{/number}","pulls_url":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls{/number}","milestones_url":"https://api.github.com/repos/sphereio/sphere-sunrise/milestones{/number}","notifications_url":"https://api.github.com/repos/sphereio/sphere-sunrise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sphereio/sphere-sunrise/labels{/name}","releases_url":"https://api.github.com/repos/sphereio/sphere-sunrise/releases{/id}","created_at":"2014-05-21T20:20:52Z","updated_at":"2015-08-09T21:51:31Z","pushed_at":"2015-09-02T12:58:06Z","git_url":"git://github.com/sphereio/sphere-sunrise.git","ssh_url":"git@github.com:sphereio/sphere-sunrise.git","clone_url":"https://github.com/sphereio/sphere-sunrise.git","svn_url":"https://github.com/sphereio/sphere-sunrise","homepage":"https://sunrise.sphere.io","size":8625,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":67,"forks":1,"open_issues":67,"watchers":6,"default_branch":"master"}},"base":{"label":"sphereio:master","ref":"master","sha":"1c9a59365a981ce364d077d52533799d74565945","user":{"login":"sphereio","id":4119130,"avatar_url":"https://avatars.githubusercontent.com/u/4119130?v=3","gravatar_id":"","url":"https://api.github.com/users/sphereio","html_url":"https://github.com/sphereio","followers_url":"https://api.github.com/users/sphereio/followers","following_url":"https://api.github.com/users/sphereio/following{/other_user}","gists_url":"https://api.github.com/users/sphereio/gists{/gist_id}","starred_url":"https://api.github.com/users/sphereio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphereio/subscriptions","organizations_url":"https://api.github.com/users/sphereio/orgs","repos_url":"https://api.github.com/users/sphereio/repos","events_url":"https://api.github.com/users/sphereio/events{/privacy}","received_events_url":"https://api.github.com/users/sphereio/received_events","type":"Organization","site_admin":false},"repo":{"id":20036001,"name":"sphere-sunrise","full_name":"sphereio/sphere-sunrise","owner":{"login":"sphereio","id":4119130,"avatar_url":"https://avatars.githubusercontent.com/u/4119130?v=3","gravatar_id":"","url":"https://api.github.com/users/sphereio","html_url":"https://github.com/sphereio","followers_url":"https://api.github.com/users/sphereio/followers","following_url":"https://api.github.com/users/sphereio/following{/other_user}","gists_url":"https://api.github.com/users/sphereio/gists{/gist_id}","starred_url":"https://api.github.com/users/sphereio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphereio/subscriptions","organizations_url":"https://api.github.com/users/sphereio/orgs","repos_url":"https://api.github.com/users/sphereio/repos","events_url":"https://api.github.com/users/sphereio/events{/privacy}","received_events_url":"https://api.github.com/users/sphereio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sphereio/sphere-sunrise","description":"The next generation SPHERE.IO demo shop template","fork":false,"url":"https://api.github.com/repos/sphereio/sphere-sunrise","forks_url":"https://api.github.com/repos/sphereio/sphere-sunrise/forks","keys_url":"https://api.github.com/repos/sphereio/sphere-sunrise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sphereio/sphere-sunrise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sphereio/sphere-sunrise/teams","hooks_url":"https://api.github.com/repos/sphereio/sphere-sunrise/hooks","issue_events_url":"https://api.github.com/repos/sphereio/sphere-sunrise/issues/events{/number}","events_url":"https://api.github.com/repos/sphereio/sphere-sunrise/events","assignees_url":"https://api.github.com/repos/sphereio/sphere-sunrise/assignees{/user}","branches_url":"https://api.github.com/repos/sphereio/sphere-sunrise/branches{/branch}","tags_url":"https://api.github.com/repos/sphereio/sphere-sunrise/tags","blobs_url":"https://api.github.com/repos/sphereio/sphere-sunrise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sphereio/sphere-sunrise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sphereio/sphere-sunrise/git/refs{/sha}","trees_url":"https://api.github.com/repos/sphereio/sphere-sunrise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sphereio/sphere-sunrise/statuses/{sha}","languages_url":"https://api.github.com/repos/sphereio/sphere-sunrise/languages","stargazers_url":"https://api.github.com/repos/sphereio/sphere-sunrise/stargazers","contributors_url":"https://api.github.com/repos/sphereio/sphere-sunrise/contributors","subscribers_url":"https://api.github.com/repos/sphereio/sphere-sunrise/subscribers","subscription_url":"https://api.github.com/repos/sphereio/sphere-sunrise/subscription","commits_url":"https://api.github.com/repos/sphereio/sphere-sunrise/commits{/sha}","git_commits_url":"https://api.github.com/repos/sphereio/sphere-sunrise/git/commits{/sha}","comments_url":"https://api.github.com/repos/sphereio/sphere-sunrise/comments{/number}","issue_comment_url":"https://api.github.com/repos/sphereio/sphere-sunrise/issues/comments{/number}","contents_url":"https://api.github.com/repos/sphereio/sphere-sunrise/contents/{+path}","compare_url":"https://api.github.com/repos/sphereio/sphere-sunrise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sphereio/sphere-sunrise/merges","archive_url":"https://api.github.com/repos/sphereio/sphere-sunrise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sphereio/sphere-sunrise/downloads","issues_url":"https://api.github.com/repos/sphereio/sphere-sunrise/issues{/number}","pulls_url":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls{/number}","milestones_url":"https://api.github.com/repos/sphereio/sphere-sunrise/milestones{/number}","notifications_url":"https://api.github.com/repos/sphereio/sphere-sunrise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sphereio/sphere-sunrise/labels{/name}","releases_url":"https://api.github.com/repos/sphereio/sphere-sunrise/releases{/id}","created_at":"2014-05-21T20:20:52Z","updated_at":"2015-08-09T21:51:31Z","pushed_at":"2015-09-02T12:58:06Z","git_url":"git://github.com/sphereio/sphere-sunrise.git","ssh_url":"git@github.com:sphereio/sphere-sunrise.git","clone_url":"https://github.com/sphereio/sphere-sunrise.git","svn_url":"https://github.com/sphereio/sphere-sunrise","homepage":"https://sunrise.sphere.io","size":8625,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":67,"forks":1,"open_issues":67,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls/171"},"html":{"href":"https://github.com/sphereio/sphere-sunrise/pull/171"},"issue":{"href":"https://api.github.com/repos/sphereio/sphere-sunrise/issues/171"},"comments":{"href":"https://api.github.com/repos/sphereio/sphere-sunrise/issues/171/comments"},"review_comments":{"href":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls/171/comments"},"review_comment":{"href":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls/171/commits"},"statuses":{"href":"https://api.github.com/repos/sphereio/sphere-sunrise/statuses/d84c134eb767aee23c1335e1fd1a157f6049e4b2"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":0,"review_comments":24,"commits":2,"additions":2,"deletions":0,"changed_files":1}}