{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/amo-validator/pulls/comments/35008217","id":35008217,"diff_hunk":"@@ -2901,9 +2915,34 @@ def munge_filename(name):\n                         \"the `%s` preference branch\" % branch)))\n         for branch, reason in BANNED_PREF_BRANCHES))\n \n-STRING_REGEXPS += PREF_REGEXPS\n+# For tests in literal strings, add help text suggesting passing the\n+# preference directly to reference getter functions.\n+PREF_STRING_HELP = (\n+    \"If you are reading, but not writing, this preference, please consider \"\n+    \"passing a string literal directly to `Preferences.get()` or \"\n+    \"`nsIPrefBranch.get*Pref`.\")\n+\n+\n+def maybe_tuple(value):\n+    if isinstance(value, tuple):\n+        return value\n+    return (value,)","path":"validator/testcases/regex.py","position":79,"original_position":79,"commit_id":"13baaa86d1728d7c5fdc3c2568ca1167bb5d3651","original_commit_id":"13baaa86d1728d7c5fdc3c2568ca1167bb5d3651","user":{"login":"magopian","id":167767,"avatar_url":"https://avatars.githubusercontent.com/u/167767?v=3","gravatar_id":"","url":"https://api.github.com/users/magopian","html_url":"https://github.com/magopian","followers_url":"https://api.github.com/users/magopian/followers","following_url":"https://api.github.com/users/magopian/following{/other_user}","gists_url":"https://api.github.com/users/magopian/gists{/gist_id}","starred_url":"https://api.github.com/users/magopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magopian/subscriptions","organizations_url":"https://api.github.com/users/magopian/orgs","repos_url":"https://api.github.com/users/magopian/repos","events_url":"https://api.github.com/users/magopian/events{/privacy}","received_events_url":"https://api.github.com/users/magopian/received_events","type":"User","site_admin":false},"body":"I disagree on this very topic, but I guess it's a matter of taste ;)","created_at":"2015-07-20T15:37:22Z","updated_at":"2015-07-20T15:37:22Z","html_url":"https://github.com/mozilla/amo-validator/pull/305#discussion_r35008217","pull_request_url":"https://api.github.com/repos/mozilla/amo-validator/pulls/305","_links":{"self":{"href":"https://api.github.com/repos/mozilla/amo-validator/pulls/comments/35008217"},"html":{"href":"https://github.com/mozilla/amo-validator/pull/305#discussion_r35008217"},"pull_request":{"href":"https://api.github.com/repos/mozilla/amo-validator/pulls/305"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/amo-validator/pulls/305","id":40321283,"html_url":"https://github.com/mozilla/amo-validator/pull/305","diff_url":"https://github.com/mozilla/amo-validator/pull/305.diff","patch_url":"https://github.com/mozilla/amo-validator/pull/305.patch","issue_url":"https://api.github.com/repos/mozilla/amo-validator/issues/305","number":305,"state":"open","locked":false,"title":"Bug 1183399: Add suggestions for addressing each validator message with a signing severity.","user":{"login":"kmaglione","id":125842,"avatar_url":"https://avatars.githubusercontent.com/u/125842?v=3","gravatar_id":"","url":"https://api.github.com/users/kmaglione","html_url":"https://github.com/kmaglione","followers_url":"https://api.github.com/users/kmaglione/followers","following_url":"https://api.github.com/users/kmaglione/following{/other_user}","gists_url":"https://api.github.com/users/kmaglione/gists{/gist_id}","starred_url":"https://api.github.com/users/kmaglione/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmaglione/subscriptions","organizations_url":"https://api.github.com/users/kmaglione/orgs","repos_url":"https://api.github.com/users/kmaglione/repos","events_url":"https://api.github.com/users/kmaglione/events{/privacy}","received_events_url":"https://api.github.com/users/kmaglione/received_events","type":"User","site_admin":false},"body":"These should be all of the validator-side changes. Olympia changes will be required to display the messages, but they won't cause any trouble on the Olympia side in the mean time.","created_at":"2015-07-20T03:14:25Z","updated_at":"2015-07-20T15:37:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d950e0f57ee03a1256535a8ac3494a2c2051b98","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/amo-validator/pulls/305/commits","review_comments_url":"https://api.github.com/repos/mozilla/amo-validator/pulls/305/comments","review_comment_url":"https://api.github.com/repos/mozilla/amo-validator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/amo-validator/issues/305/comments","statuses_url":"https://api.github.com/repos/mozilla/amo-validator/statuses/13baaa86d1728d7c5fdc3c2568ca1167bb5d3651","head":{"label":"kmaglione:signing-help","ref":"signing-help","sha":"13baaa86d1728d7c5fdc3c2568ca1167bb5d3651","user":{"login":"kmaglione","id":125842,"avatar_url":"https://avatars.githubusercontent.com/u/125842?v=3","gravatar_id":"","url":"https://api.github.com/users/kmaglione","html_url":"https://github.com/kmaglione","followers_url":"https://api.github.com/users/kmaglione/followers","following_url":"https://api.github.com/users/kmaglione/following{/other_user}","gists_url":"https://api.github.com/users/kmaglione/gists{/gist_id}","starred_url":"https://api.github.com/users/kmaglione/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmaglione/subscriptions","organizations_url":"https://api.github.com/users/kmaglione/orgs","repos_url":"https://api.github.com/users/kmaglione/repos","events_url":"https://api.github.com/users/kmaglione/events{/privacy}","received_events_url":"https://api.github.com/users/kmaglione/received_events","type":"User","site_admin":false},"repo":{"id":1508852,"name":"amo-validator","full_name":"kmaglione/amo-validator","owner":{"login":"kmaglione","id":125842,"avatar_url":"https://avatars.githubusercontent.com/u/125842?v=3","gravatar_id":"","url":"https://api.github.com/users/kmaglione","html_url":"https://github.com/kmaglione","followers_url":"https://api.github.com/users/kmaglione/followers","following_url":"https://api.github.com/users/kmaglione/following{/other_user}","gists_url":"https://api.github.com/users/kmaglione/gists{/gist_id}","starred_url":"https://api.github.com/users/kmaglione/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmaglione/subscriptions","organizations_url":"https://api.github.com/users/kmaglione/orgs","repos_url":"https://api.github.com/users/kmaglione/repos","events_url":"https://api.github.com/users/kmaglione/events{/privacy}","received_events_url":"https://api.github.com/users/kmaglione/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kmaglione/amo-validator","description":"Validator for addons.mozilla.org","fork":true,"url":"https://api.github.com/repos/kmaglione/amo-validator","forks_url":"https://api.github.com/repos/kmaglione/amo-validator/forks","keys_url":"https://api.github.com/repos/kmaglione/amo-validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kmaglione/amo-validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kmaglione/amo-validator/teams","hooks_url":"https://api.github.com/repos/kmaglione/amo-validator/hooks","issue_events_url":"https://api.github.com/repos/kmaglione/amo-validator/issues/events{/number}","events_url":"https://api.github.com/repos/kmaglione/amo-validator/events","assignees_url":"https://api.github.com/repos/kmaglione/amo-validator/assignees{/user}","branches_url":"https://api.github.com/repos/kmaglione/amo-validator/branches{/branch}","tags_url":"https://api.github.com/repos/kmaglione/amo-validator/tags","blobs_url":"https://api.github.com/repos/kmaglione/amo-validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kmaglione/amo-validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kmaglione/amo-validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/kmaglione/amo-validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kmaglione/amo-validator/statuses/{sha}","languages_url":"https://api.github.com/repos/kmaglione/amo-validator/languages","stargazers_url":"https://api.github.com/repos/kmaglione/amo-validator/stargazers","contributors_url":"https://api.github.com/repos/kmaglione/amo-validator/contributors","subscribers_url":"https://api.github.com/repos/kmaglione/amo-validator/subscribers","subscription_url":"https://api.github.com/repos/kmaglione/amo-validator/subscription","commits_url":"https://api.github.com/repos/kmaglione/amo-validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/kmaglione/amo-validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/kmaglione/amo-validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/kmaglione/amo-validator/issues/comments{/number}","contents_url":"https://api.github.com/repos/kmaglione/amo-validator/contents/{+path}","compare_url":"https://api.github.com/repos/kmaglione/amo-validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kmaglione/amo-validator/merges","archive_url":"https://api.github.com/repos/kmaglione/amo-validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kmaglione/amo-validator/downloads","issues_url":"https://api.github.com/repos/kmaglione/amo-validator/issues{/number}","pulls_url":"https://api.github.com/repos/kmaglione/amo-validator/pulls{/number}","milestones_url":"https://api.github.com/repos/kmaglione/amo-validator/milestones{/number}","notifications_url":"https://api.github.com/repos/kmaglione/amo-validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kmaglione/amo-validator/labels{/name}","releases_url":"https://api.github.com/repos/kmaglione/amo-validator/releases{/id}","created_at":"2011-03-21T22:22:40Z","updated_at":"2014-08-09T22:13:54Z","pushed_at":"2015-07-20T04:50:21Z","git_url":"git://github.com/kmaglione/amo-validator.git","ssh_url":"git@github.com:kmaglione/amo-validator.git","clone_url":"https://github.com/kmaglione/amo-validator.git","svn_url":"https://github.com/kmaglione/amo-validator","homepage":"","size":17417,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"efc65256edfe14d80a3ec37decadc7020b02149e","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1441734,"name":"amo-validator","full_name":"mozilla/amo-validator","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/amo-validator","description":"Validator for addons.mozilla.org","fork":false,"url":"https://api.github.com/repos/mozilla/amo-validator","forks_url":"https://api.github.com/repos/mozilla/amo-validator/forks","keys_url":"https://api.github.com/repos/mozilla/amo-validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/amo-validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/amo-validator/teams","hooks_url":"https://api.github.com/repos/mozilla/amo-validator/hooks","issue_events_url":"https://api.github.com/repos/mozilla/amo-validator/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/amo-validator/events","assignees_url":"https://api.github.com/repos/mozilla/amo-validator/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/amo-validator/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/amo-validator/tags","blobs_url":"https://api.github.com/repos/mozilla/amo-validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/amo-validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/amo-validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/amo-validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/amo-validator/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/amo-validator/languages","stargazers_url":"https://api.github.com/repos/mozilla/amo-validator/stargazers","contributors_url":"https://api.github.com/repos/mozilla/amo-validator/contributors","subscribers_url":"https://api.github.com/repos/mozilla/amo-validator/subscribers","subscription_url":"https://api.github.com/repos/mozilla/amo-validator/subscription","commits_url":"https://api.github.com/repos/mozilla/amo-validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/amo-validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/amo-validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/amo-validator/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/amo-validator/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/amo-validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/amo-validator/merges","archive_url":"https://api.github.com/repos/mozilla/amo-validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/amo-validator/downloads","issues_url":"https://api.github.com/repos/mozilla/amo-validator/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/amo-validator/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/amo-validator/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/amo-validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/amo-validator/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/amo-validator/releases{/id}","created_at":"2011-03-05T00:24:22Z","updated_at":"2015-07-03T06:53:52Z","pushed_at":"2015-07-20T04:50:21Z","git_url":"git://github.com/mozilla/amo-validator.git","ssh_url":"git@github.com:mozilla/amo-validator.git","clone_url":"https://github.com/mozilla/amo-validator.git","svn_url":"https://github.com/mozilla/amo-validator","homepage":"","size":385882,"stargazers_count":41,"watchers_count":41,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":3,"forks":42,"open_issues":3,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/amo-validator/pulls/305"},"html":{"href":"https://github.com/mozilla/amo-validator/pull/305"},"issue":{"href":"https://api.github.com/repos/mozilla/amo-validator/issues/305"},"comments":{"href":"https://api.github.com/repos/mozilla/amo-validator/issues/305/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/amo-validator/pulls/305/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/amo-validator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/amo-validator/pulls/305/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/amo-validator/statuses/13baaa86d1728d7c5fdc3c2568ca1167bb5d3651"}}}}