{"action":"opened","number":258,"pull_request":{"url":"https://api.github.com/repos/linq2db/linq2db/pulls/258","id":45169760,"html_url":"https://github.com/linq2db/linq2db/pull/258","diff_url":"https://github.com/linq2db/linq2db/pull/258.diff","patch_url":"https://github.com/linq2db/linq2db/pull/258.patch","issue_url":"https://api.github.com/repos/linq2db/linq2db/issues/258","number":258,"state":"open","locked":false,"title":"Fixed problem with generic filter predicates","user":{"login":"rechkalov","id":1055095,"avatar_url":"https://avatars.githubusercontent.com/u/1055095?v=3","gravatar_id":"","url":"https://api.github.com/users/rechkalov","html_url":"https://github.com/rechkalov","followers_url":"https://api.github.com/users/rechkalov/followers","following_url":"https://api.github.com/users/rechkalov/following{/other_user}","gists_url":"https://api.github.com/users/rechkalov/gists{/gist_id}","starred_url":"https://api.github.com/users/rechkalov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rechkalov/subscriptions","organizations_url":"https://api.github.com/users/rechkalov/orgs","repos_url":"https://api.github.com/users/rechkalov/repos","events_url":"https://api.github.com/users/rechkalov/events{/privacy}","received_events_url":"https://api.github.com/users/rechkalov/received_events","type":"User","site_admin":false},"body":"Hi! We have a problem with some complex queries. I think that the cause in line \r\n```\r\nif (me.Member == binding.Member)\r\n```\r\n\r\nWhen compared \"me.Member\" and \"binding.Member\" the first one can be interface preperty that is implemented by type with the second one. In this case comparision gives us \"false\" and then exception raised, but I think that it is possible to proceed.\r\n\r\nSimplest solution is to replace \"me.Member == binding.Member\" with \"me.Member.Name == binding.Member.Name\", but it is not good idea, so I used InterfaceMapping to determine if property is interface implementation.\r\n\r\nWithout this fix test \"WhenPredicateFactoryIsNotGeneric\" passes, but \"WhenPredicateFactoryIsGeneric\" fails. With it both tests pass.","created_at":"2015-09-16T13:17:20Z","updated_at":"2015-09-16T13:17:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1aac0a200f8078a4bcfd508e327414a8ce6113e8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/linq2db/linq2db/pulls/258/commits","review_comments_url":"https://api.github.com/repos/linq2db/linq2db/pulls/258/comments","review_comment_url":"https://api.github.com/repos/linq2db/linq2db/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linq2db/linq2db/issues/258/comments","statuses_url":"https://api.github.com/repos/linq2db/linq2db/statuses/869986ba9893fc13324530840b7e8c2bed5334a9","head":{"label":"rechkalov:master","ref":"master","sha":"869986ba9893fc13324530840b7e8c2bed5334a9","user":{"login":"rechkalov","id":1055095,"avatar_url":"https://avatars.githubusercontent.com/u/1055095?v=3","gravatar_id":"","url":"https://api.github.com/users/rechkalov","html_url":"https://github.com/rechkalov","followers_url":"https://api.github.com/users/rechkalov/followers","following_url":"https://api.github.com/users/rechkalov/following{/other_user}","gists_url":"https://api.github.com/users/rechkalov/gists{/gist_id}","starred_url":"https://api.github.com/users/rechkalov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rechkalov/subscriptions","organizations_url":"https://api.github.com/users/rechkalov/orgs","repos_url":"https://api.github.com/users/rechkalov/repos","events_url":"https://api.github.com/users/rechkalov/events{/privacy}","received_events_url":"https://api.github.com/users/rechkalov/received_events","type":"User","site_admin":false},"repo":{"id":36651869,"name":"linq2db","full_name":"rechkalov/linq2db","owner":{"login":"rechkalov","id":1055095,"avatar_url":"https://avatars.githubusercontent.com/u/1055095?v=3","gravatar_id":"","url":"https://api.github.com/users/rechkalov","html_url":"https://github.com/rechkalov","followers_url":"https://api.github.com/users/rechkalov/followers","following_url":"https://api.github.com/users/rechkalov/following{/other_user}","gists_url":"https://api.github.com/users/rechkalov/gists{/gist_id}","starred_url":"https://api.github.com/users/rechkalov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rechkalov/subscriptions","organizations_url":"https://api.github.com/users/rechkalov/orgs","repos_url":"https://api.github.com/users/rechkalov/repos","events_url":"https://api.github.com/users/rechkalov/events{/privacy}","received_events_url":"https://api.github.com/users/rechkalov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rechkalov/linq2db","description":"Linq to database provider.","fork":true,"url":"https://api.github.com/repos/rechkalov/linq2db","forks_url":"https://api.github.com/repos/rechkalov/linq2db/forks","keys_url":"https://api.github.com/repos/rechkalov/linq2db/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rechkalov/linq2db/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rechkalov/linq2db/teams","hooks_url":"https://api.github.com/repos/rechkalov/linq2db/hooks","issue_events_url":"https://api.github.com/repos/rechkalov/linq2db/issues/events{/number}","events_url":"https://api.github.com/repos/rechkalov/linq2db/events","assignees_url":"https://api.github.com/repos/rechkalov/linq2db/assignees{/user}","branches_url":"https://api.github.com/repos/rechkalov/linq2db/branches{/branch}","tags_url":"https://api.github.com/repos/rechkalov/linq2db/tags","blobs_url":"https://api.github.com/repos/rechkalov/linq2db/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rechkalov/linq2db/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rechkalov/linq2db/git/refs{/sha}","trees_url":"https://api.github.com/repos/rechkalov/linq2db/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rechkalov/linq2db/statuses/{sha}","languages_url":"https://api.github.com/repos/rechkalov/linq2db/languages","stargazers_url":"https://api.github.com/repos/rechkalov/linq2db/stargazers","contributors_url":"https://api.github.com/repos/rechkalov/linq2db/contributors","subscribers_url":"https://api.github.com/repos/rechkalov/linq2db/subscribers","subscription_url":"https://api.github.com/repos/rechkalov/linq2db/subscription","commits_url":"https://api.github.com/repos/rechkalov/linq2db/commits{/sha}","git_commits_url":"https://api.github.com/repos/rechkalov/linq2db/git/commits{/sha}","comments_url":"https://api.github.com/repos/rechkalov/linq2db/comments{/number}","issue_comment_url":"https://api.github.com/repos/rechkalov/linq2db/issues/comments{/number}","contents_url":"https://api.github.com/repos/rechkalov/linq2db/contents/{+path}","compare_url":"https://api.github.com/repos/rechkalov/linq2db/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rechkalov/linq2db/merges","archive_url":"https://api.github.com/repos/rechkalov/linq2db/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rechkalov/linq2db/downloads","issues_url":"https://api.github.com/repos/rechkalov/linq2db/issues{/number}","pulls_url":"https://api.github.com/repos/rechkalov/linq2db/pulls{/number}","milestones_url":"https://api.github.com/repos/rechkalov/linq2db/milestones{/number}","notifications_url":"https://api.github.com/repos/rechkalov/linq2db/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rechkalov/linq2db/labels{/name}","releases_url":"https://api.github.com/repos/rechkalov/linq2db/releases{/id}","created_at":"2015-06-01T09:49:31Z","updated_at":"2015-06-01T09:49:33Z","pushed_at":"2015-09-16T12:33:10Z","git_url":"git://github.com/rechkalov/linq2db.git","ssh_url":"git@github.com:rechkalov/linq2db.git","clone_url":"https://github.com/rechkalov/linq2db.git","svn_url":"https://github.com/rechkalov/linq2db","homepage":"","size":162775,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linq2db:master","ref":"master","sha":"e2acc8e7ef39efe8179954f8d80fc0f561c066d7","user":{"login":"linq2db","id":865669,"avatar_url":"https://avatars.githubusercontent.com/u/865669?v=3","gravatar_id":"","url":"https://api.github.com/users/linq2db","html_url":"https://github.com/linq2db","followers_url":"https://api.github.com/users/linq2db/followers","following_url":"https://api.github.com/users/linq2db/following{/other_user}","gists_url":"https://api.github.com/users/linq2db/gists{/gist_id}","starred_url":"https://api.github.com/users/linq2db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linq2db/subscriptions","organizations_url":"https://api.github.com/users/linq2db/orgs","repos_url":"https://api.github.com/users/linq2db/repos","events_url":"https://api.github.com/users/linq2db/events{/privacy}","received_events_url":"https://api.github.com/users/linq2db/received_events","type":"Organization","site_admin":false},"repo":{"id":1916228,"name":"linq2db","full_name":"linq2db/linq2db","owner":{"login":"linq2db","id":865669,"avatar_url":"https://avatars.githubusercontent.com/u/865669?v=3","gravatar_id":"","url":"https://api.github.com/users/linq2db","html_url":"https://github.com/linq2db","followers_url":"https://api.github.com/users/linq2db/followers","following_url":"https://api.github.com/users/linq2db/following{/other_user}","gists_url":"https://api.github.com/users/linq2db/gists{/gist_id}","starred_url":"https://api.github.com/users/linq2db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linq2db/subscriptions","organizations_url":"https://api.github.com/users/linq2db/orgs","repos_url":"https://api.github.com/users/linq2db/repos","events_url":"https://api.github.com/users/linq2db/events{/privacy}","received_events_url":"https://api.github.com/users/linq2db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linq2db/linq2db","description":"Linq to database provider.","fork":false,"url":"https://api.github.com/repos/linq2db/linq2db","forks_url":"https://api.github.com/repos/linq2db/linq2db/forks","keys_url":"https://api.github.com/repos/linq2db/linq2db/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linq2db/linq2db/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linq2db/linq2db/teams","hooks_url":"https://api.github.com/repos/linq2db/linq2db/hooks","issue_events_url":"https://api.github.com/repos/linq2db/linq2db/issues/events{/number}","events_url":"https://api.github.com/repos/linq2db/linq2db/events","assignees_url":"https://api.github.com/repos/linq2db/linq2db/assignees{/user}","branches_url":"https://api.github.com/repos/linq2db/linq2db/branches{/branch}","tags_url":"https://api.github.com/repos/linq2db/linq2db/tags","blobs_url":"https://api.github.com/repos/linq2db/linq2db/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linq2db/linq2db/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linq2db/linq2db/git/refs{/sha}","trees_url":"https://api.github.com/repos/linq2db/linq2db/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linq2db/linq2db/statuses/{sha}","languages_url":"https://api.github.com/repos/linq2db/linq2db/languages","stargazers_url":"https://api.github.com/repos/linq2db/linq2db/stargazers","contributors_url":"https://api.github.com/repos/linq2db/linq2db/contributors","subscribers_url":"https://api.github.com/repos/linq2db/linq2db/subscribers","subscription_url":"https://api.github.com/repos/linq2db/linq2db/subscription","commits_url":"https://api.github.com/repos/linq2db/linq2db/commits{/sha}","git_commits_url":"https://api.github.com/repos/linq2db/linq2db/git/commits{/sha}","comments_url":"https://api.github.com/repos/linq2db/linq2db/comments{/number}","issue_comment_url":"https://api.github.com/repos/linq2db/linq2db/issues/comments{/number}","contents_url":"https://api.github.com/repos/linq2db/linq2db/contents/{+path}","compare_url":"https://api.github.com/repos/linq2db/linq2db/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linq2db/linq2db/merges","archive_url":"https://api.github.com/repos/linq2db/linq2db/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linq2db/linq2db/downloads","issues_url":"https://api.github.com/repos/linq2db/linq2db/issues{/number}","pulls_url":"https://api.github.com/repos/linq2db/linq2db/pulls{/number}","milestones_url":"https://api.github.com/repos/linq2db/linq2db/milestones{/number}","notifications_url":"https://api.github.com/repos/linq2db/linq2db/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linq2db/linq2db/labels{/name}","releases_url":"https://api.github.com/repos/linq2db/linq2db/releases{/id}","created_at":"2011-06-18T16:24:37Z","updated_at":"2015-09-16T01:49:06Z","pushed_at":"2015-09-16T13:17:20Z","git_url":"git://github.com/linq2db/linq2db.git","ssh_url":"git@github.com:linq2db/linq2db.git","clone_url":"https://github.com/linq2db/linq2db.git","svn_url":"https://github.com/linq2db/linq2db","homepage":"","size":180340,"stargazers_count":278,"watchers_count":278,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":86,"mirror_url":null,"open_issues_count":53,"forks":86,"open_issues":53,"watchers":278,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linq2db/linq2db/pulls/258"},"html":{"href":"https://github.com/linq2db/linq2db/pull/258"},"issue":{"href":"https://api.github.com/repos/linq2db/linq2db/issues/258"},"comments":{"href":"https://api.github.com/repos/linq2db/linq2db/issues/258/comments"},"review_comments":{"href":"https://api.github.com/repos/linq2db/linq2db/pulls/258/comments"},"review_comment":{"href":"https://api.github.com/repos/linq2db/linq2db/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linq2db/linq2db/pulls/258/commits"},"statuses":{"href":"https://api.github.com/repos/linq2db/linq2db/statuses/869986ba9893fc13324530840b7e8c2bed5334a9"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":100,"deletions":0,"changed_files":3}}