{"action":"created","issue":{"url":"https://api.github.com/repos/espruino/Espruino/issues/634","labels_url":"https://api.github.com/repos/espruino/Espruino/issues/634/labels{/name}","comments_url":"https://api.github.com/repos/espruino/Espruino/issues/634/comments","events_url":"https://api.github.com/repos/espruino/Espruino/issues/634/events","html_url":"https://github.com/espruino/Espruino/issues/634","id":110579377,"number":634,"title":"Unable to build Espruino on Windows ... common.py","user":{"login":"nkolban","id":3421732,"avatar_url":"https://avatars.githubusercontent.com/u/3421732?v=3","gravatar_id":"","url":"https://api.github.com/users/nkolban","html_url":"https://github.com/nkolban","followers_url":"https://api.github.com/users/nkolban/followers","following_url":"https://api.github.com/users/nkolban/following{/other_user}","gists_url":"https://api.github.com/users/nkolban/gists{/gist_id}","starred_url":"https://api.github.com/users/nkolban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkolban/subscriptions","organizations_url":"https://api.github.com/users/nkolban/orgs","repos_url":"https://api.github.com/users/nkolban/repos","events_url":"https://api.github.com/users/nkolban/events{/privacy}","received_events_url":"https://api.github.com/users/nkolban/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"nkolban","id":3421732,"avatar_url":"https://avatars.githubusercontent.com/u/3421732?v=3","gravatar_id":"","url":"https://api.github.com/users/nkolban","html_url":"https://github.com/nkolban","followers_url":"https://api.github.com/users/nkolban/followers","following_url":"https://api.github.com/users/nkolban/following{/other_user}","gists_url":"https://api.github.com/users/nkolban/gists{/gist_id}","starred_url":"https://api.github.com/users/nkolban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkolban/subscriptions","organizations_url":"https://api.github.com/users/nkolban/orgs","repos_url":"https://api.github.com/users/nkolban/repos","events_url":"https://api.github.com/users/nkolban/events{/privacy}","received_events_url":"https://api.github.com/users/nkolban/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2015-10-09T03:04:14Z","updated_at":"2015-10-09T13:36:02Z","closed_at":null,"body":"When running the build system on Windows, we get a build time error.   This is not new and has been present for all my history of builds but I was able to comment out the \"code\" that was failing and ran with it commented out as a hack.  Obviously, the hack was never committed.  This issue asks for a proper investigation of the situation and examination of what might be done to resolve the issue.  During a build, we fail with the following error:\r\n\r\n```\r\n22:01:00 **** Build of configuration Debug for project EspruinoMaster ****\r\n\"C:\\\\MinGW\\\\bin\\\\mingw32-make\" clean \r\nTraceback (most recent call last):\r\n  File \"scripts/get_board_info.py\", line 40, in <module>\r\n    print(eval(sys.argv[2]));\r\n  File \"<string>\", line 1, in <module>\r\n  File \"C:\\Users\\IBM_ADMIN\\git\\Espruino\\scripts\\common.py\", line 349, in get_board_binary_name\r\n    return board.info[\"binary_name\"].replace(\"%v\", get_version());\r\n  File \"C:\\Users\\IBM_ADMIN\\git\\Espruino\\scripts\\common.py\", line 320, in get_version\r\n    commits_since_release = subprocess.check_output('git log --oneline '+latest_release+'..HEAD | wc -l', shell=True).strip()\r\nTypeError: Can't convert 'bytes' object to str implicitly\r\nMakefile:623: *** Unable to work out binary name (PROJ_NAME).  Stop.\r\n\r\n22:01:01 Build Finished (took 1s.179ms)\r\n```"},"comment":{"url":"https://api.github.com/repos/espruino/Espruino/issues/comments/146873136","html_url":"https://github.com/espruino/Espruino/issues/634#issuecomment-146873136","issue_url":"https://api.github.com/repos/espruino/Espruino/issues/634","id":146873136,"user":{"login":"gfwilliams","id":754445,"avatar_url":"https://avatars.githubusercontent.com/u/754445?v=3","gravatar_id":"","url":"https://api.github.com/users/gfwilliams","html_url":"https://github.com/gfwilliams","followers_url":"https://api.github.com/users/gfwilliams/followers","following_url":"https://api.github.com/users/gfwilliams/following{/other_user}","gists_url":"https://api.github.com/users/gfwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/gfwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfwilliams/subscriptions","organizations_url":"https://api.github.com/users/gfwilliams/orgs","repos_url":"https://api.github.com/users/gfwilliams/repos","events_url":"https://api.github.com/users/gfwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/gfwilliams/received_events","type":"User","site_admin":false},"created_at":"2015-10-09T13:36:02Z","updated_at":"2015-10-09T13:36:02Z","body":"If you look at the diff above, it's because I put the `decode` bit into `commits_since_release`, so rather than duplicating it, it only happens once.\r\n\r\nDoes it not work now then?"}}