{"action":"created","comment":{"url":"https://api.github.com/repos/twitter/elephant-bird/pulls/comments/29289025","id":29289025,"diff_hunk":"@@ -0,0 +1,32 @@\n+package com.twitter.elephantbird.mapreduce.input;\n+\n+import com.twitter.elephantbird.mapreduce.io.GenericWritable;\n+import com.twitter.elephantbird.mapreduce.io.BinaryConverter;\n+import com.twitter.elephantbird.util.TypeRef;\n+\n+import org.slf4j.Logger;\n+import org.slf4j.LoggerFactory;\n+\n+import java.io.IOException;\n+import java.io.InputStream;\n+\n+import com.google.protobuf.ByteString;\n+\n+import com.twitter.elephantbird.mapreduce.input.MapredInputFormatCompatible;\n+import com.twitter.elephantbird.mapreduce.io.BinaryBlockReader;\n+import com.twitter.elephantbird.util.TypeRef;\n+\n+import org.slf4j.Logger;\n+\n+public class LzoGenericBlockRecordReader<M>\n+    extends LzoBinaryBlockRecordReader<M, GenericWritable<M>> {\n+\n+  private static final Logger LOG = LoggerFactory.getLogger(LzoGenericBlockRecordReader.class);\n+\n+  public LzoGenericBlockRecordReader(TypeRef<M> typeRef, BinaryConverter<M> binaryConverter) {\n+    super(typeRef,\n+      new BinaryBlockReader(null, binaryConverter),\n+      new GenericWritable<M>(binaryConverter));\n+    LOG.info(\"LzoGenericBlockRecordReader, type args are \" + typeRef.getRawClass());","path":"core/src/main/java/com/twitter/elephantbird/mapreduce/input/LzoGenericBlockRecordReader.java","position":30,"original_position":30,"commit_id":"7cec322c4f5c17a973c774338f350dfd8d7fdc05","original_commit_id":"7cec322c4f5c17a973c774338f350dfd8d7fdc05","user":{"login":"ianoc","id":446652,"avatar_url":"https://avatars.githubusercontent.com/u/446652?v=3","gravatar_id":"","url":"https://api.github.com/users/ianoc","html_url":"https://github.com/ianoc","followers_url":"https://api.github.com/users/ianoc/followers","following_url":"https://api.github.com/users/ianoc/following{/other_user}","gists_url":"https://api.github.com/users/ianoc/gists{/gist_id}","starred_url":"https://api.github.com/users/ianoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianoc/subscriptions","organizations_url":"https://api.github.com/users/ianoc/orgs","repos_url":"https://api.github.com/users/ianoc/repos","events_url":"https://api.github.com/users/ianoc/events{/privacy}","received_events_url":"https://api.github.com/users/ianoc/received_events","type":"User","site_admin":false},"body":"kill","created_at":"2015-04-28T21:10:41Z","updated_at":"2015-04-28T21:10:41Z","html_url":"https://github.com/twitter/elephant-bird/pull/439#discussion_r29289025","pull_request_url":"https://api.github.com/repos/twitter/elephant-bird/pulls/439","_links":{"self":{"href":"https://api.github.com/repos/twitter/elephant-bird/pulls/comments/29289025"},"html":{"href":"https://github.com/twitter/elephant-bird/pull/439#discussion_r29289025"},"pull_request":{"href":"https://api.github.com/repos/twitter/elephant-bird/pulls/439"}}},"pull_request":{"url":"https://api.github.com/repos/twitter/elephant-bird/pulls/439","id":33788601,"html_url":"https://github.com/twitter/elephant-bird/pull/439","diff_url":"https://github.com/twitter/elephant-bird/pull/439.diff","patch_url":"https://github.com/twitter/elephant-bird/pull/439.patch","issue_url":"https://api.github.com/repos/twitter/elephant-bird/issues/439","number":439,"state":"open","locked":false,"title":"Adds generic block record readers","user":{"login":"rubanm","id":2401144,"avatar_url":"https://avatars.githubusercontent.com/u/2401144?v=3","gravatar_id":"","url":"https://api.github.com/users/rubanm","html_url":"https://github.com/rubanm","followers_url":"https://api.github.com/users/rubanm/followers","following_url":"https://api.github.com/users/rubanm/following{/other_user}","gists_url":"https://api.github.com/users/rubanm/gists{/gist_id}","starred_url":"https://api.github.com/users/rubanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubanm/subscriptions","organizations_url":"https://api.github.com/users/rubanm/orgs","repos_url":"https://api.github.com/users/rubanm/repos","events_url":"https://api.github.com/users/rubanm/events{/privacy}","received_events_url":"https://api.github.com/users/rubanm/received_events","type":"User","site_admin":false},"body":"This resurrects @ianoc's branch that adds generic block record reader, which uses the provided `BinaryConverter` to deserialize data.\r\n\r\nAlso moved some common code to a new `LzoBlockRecordReader` class.\r\n\r\nWill create scalding PR to add `LzoGenericScheme` once this is merged.","created_at":"2015-04-21T18:17:17Z","updated_at":"2015-04-28T21:10:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ed813097cfab878a1016ec2372aca6c375f13f0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twitter/elephant-bird/pulls/439/commits","review_comments_url":"https://api.github.com/repos/twitter/elephant-bird/pulls/439/comments","review_comment_url":"https://api.github.com/repos/twitter/elephant-bird/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twitter/elephant-bird/issues/439/comments","statuses_url":"https://api.github.com/repos/twitter/elephant-bird/statuses/7cec322c4f5c17a973c774338f350dfd8d7fdc05","head":{"label":"rubanm:rubanm/generic_inputformat","ref":"rubanm/generic_inputformat","sha":"7cec322c4f5c17a973c774338f350dfd8d7fdc05","user":{"login":"rubanm","id":2401144,"avatar_url":"https://avatars.githubusercontent.com/u/2401144?v=3","gravatar_id":"","url":"https://api.github.com/users/rubanm","html_url":"https://github.com/rubanm","followers_url":"https://api.github.com/users/rubanm/followers","following_url":"https://api.github.com/users/rubanm/following{/other_user}","gists_url":"https://api.github.com/users/rubanm/gists{/gist_id}","starred_url":"https://api.github.com/users/rubanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubanm/subscriptions","organizations_url":"https://api.github.com/users/rubanm/orgs","repos_url":"https://api.github.com/users/rubanm/repos","events_url":"https://api.github.com/users/rubanm/events{/privacy}","received_events_url":"https://api.github.com/users/rubanm/received_events","type":"User","site_admin":false},"repo":{"id":33958739,"name":"elephant-bird","full_name":"rubanm/elephant-bird","owner":{"login":"rubanm","id":2401144,"avatar_url":"https://avatars.githubusercontent.com/u/2401144?v=3","gravatar_id":"","url":"https://api.github.com/users/rubanm","html_url":"https://github.com/rubanm","followers_url":"https://api.github.com/users/rubanm/followers","following_url":"https://api.github.com/users/rubanm/following{/other_user}","gists_url":"https://api.github.com/users/rubanm/gists{/gist_id}","starred_url":"https://api.github.com/users/rubanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubanm/subscriptions","organizations_url":"https://api.github.com/users/rubanm/orgs","repos_url":"https://api.github.com/users/rubanm/repos","events_url":"https://api.github.com/users/rubanm/events{/privacy}","received_events_url":"https://api.github.com/users/rubanm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rubanm/elephant-bird","description":"Twitter's collection of LZO and Protocol Buffer-related Hadoop, Pig, Hive, and HBase code.","fork":true,"url":"https://api.github.com/repos/rubanm/elephant-bird","forks_url":"https://api.github.com/repos/rubanm/elephant-bird/forks","keys_url":"https://api.github.com/repos/rubanm/elephant-bird/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubanm/elephant-bird/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubanm/elephant-bird/teams","hooks_url":"https://api.github.com/repos/rubanm/elephant-bird/hooks","issue_events_url":"https://api.github.com/repos/rubanm/elephant-bird/issues/events{/number}","events_url":"https://api.github.com/repos/rubanm/elephant-bird/events","assignees_url":"https://api.github.com/repos/rubanm/elephant-bird/assignees{/user}","branches_url":"https://api.github.com/repos/rubanm/elephant-bird/branches{/branch}","tags_url":"https://api.github.com/repos/rubanm/elephant-bird/tags","blobs_url":"https://api.github.com/repos/rubanm/elephant-bird/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubanm/elephant-bird/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubanm/elephant-bird/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubanm/elephant-bird/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubanm/elephant-bird/statuses/{sha}","languages_url":"https://api.github.com/repos/rubanm/elephant-bird/languages","stargazers_url":"https://api.github.com/repos/rubanm/elephant-bird/stargazers","contributors_url":"https://api.github.com/repos/rubanm/elephant-bird/contributors","subscribers_url":"https://api.github.com/repos/rubanm/elephant-bird/subscribers","subscription_url":"https://api.github.com/repos/rubanm/elephant-bird/subscription","commits_url":"https://api.github.com/repos/rubanm/elephant-bird/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubanm/elephant-bird/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubanm/elephant-bird/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubanm/elephant-bird/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubanm/elephant-bird/contents/{+path}","compare_url":"https://api.github.com/repos/rubanm/elephant-bird/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubanm/elephant-bird/merges","archive_url":"https://api.github.com/repos/rubanm/elephant-bird/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubanm/elephant-bird/downloads","issues_url":"https://api.github.com/repos/rubanm/elephant-bird/issues{/number}","pulls_url":"https://api.github.com/repos/rubanm/elephant-bird/pulls{/number}","milestones_url":"https://api.github.com/repos/rubanm/elephant-bird/milestones{/number}","notifications_url":"https://api.github.com/repos/rubanm/elephant-bird/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubanm/elephant-bird/labels{/name}","releases_url":"https://api.github.com/repos/rubanm/elephant-bird/releases{/id}","created_at":"2015-04-14T21:46:03Z","updated_at":"2015-04-14T21:46:05Z","pushed_at":"2015-04-28T00:14:30Z","git_url":"git://github.com/rubanm/elephant-bird.git","ssh_url":"git@github.com:rubanm/elephant-bird.git","clone_url":"https://github.com/rubanm/elephant-bird.git","svn_url":"https://github.com/rubanm/elephant-bird","homepage":"","size":62264,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twitter:master","ref":"master","sha":"1efa52d912ad35fbdf6d60f3d45a6801ec722063","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":578435,"name":"elephant-bird","full_name":"twitter/elephant-bird","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/elephant-bird","description":"Twitter's collection of LZO and Protocol Buffer-related Hadoop, Pig, Hive, and HBase code.","fork":false,"url":"https://api.github.com/repos/twitter/elephant-bird","forks_url":"https://api.github.com/repos/twitter/elephant-bird/forks","keys_url":"https://api.github.com/repos/twitter/elephant-bird/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/elephant-bird/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/elephant-bird/teams","hooks_url":"https://api.github.com/repos/twitter/elephant-bird/hooks","issue_events_url":"https://api.github.com/repos/twitter/elephant-bird/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/elephant-bird/events","assignees_url":"https://api.github.com/repos/twitter/elephant-bird/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/elephant-bird/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/elephant-bird/tags","blobs_url":"https://api.github.com/repos/twitter/elephant-bird/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/elephant-bird/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/elephant-bird/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/elephant-bird/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/elephant-bird/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/elephant-bird/languages","stargazers_url":"https://api.github.com/repos/twitter/elephant-bird/stargazers","contributors_url":"https://api.github.com/repos/twitter/elephant-bird/contributors","subscribers_url":"https://api.github.com/repos/twitter/elephant-bird/subscribers","subscription_url":"https://api.github.com/repos/twitter/elephant-bird/subscription","commits_url":"https://api.github.com/repos/twitter/elephant-bird/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/elephant-bird/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/elephant-bird/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/elephant-bird/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter/elephant-bird/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/elephant-bird/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/elephant-bird/merges","archive_url":"https://api.github.com/repos/twitter/elephant-bird/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/elephant-bird/downloads","issues_url":"https://api.github.com/repos/twitter/elephant-bird/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/elephant-bird/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/elephant-bird/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/elephant-bird/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/elephant-bird/labels{/name}","releases_url":"https://api.github.com/repos/twitter/elephant-bird/releases{/id}","created_at":"2010-03-25T01:49:40Z","updated_at":"2015-04-27T08:32:06Z","pushed_at":"2015-04-28T00:14:30Z","git_url":"git://github.com/twitter/elephant-bird.git","ssh_url":"git@github.com:twitter/elephant-bird.git","clone_url":"https://github.com/twitter/elephant-bird.git","svn_url":"https://github.com/twitter/elephant-bird","homepage":"","size":67039,"stargazers_count":841,"watchers_count":841,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":300,"mirror_url":null,"open_issues_count":65,"forks":300,"open_issues":65,"watchers":841,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/elephant-bird/pulls/439"},"html":{"href":"https://github.com/twitter/elephant-bird/pull/439"},"issue":{"href":"https://api.github.com/repos/twitter/elephant-bird/issues/439"},"comments":{"href":"https://api.github.com/repos/twitter/elephant-bird/issues/439/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/elephant-bird/pulls/439/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/elephant-bird/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twitter/elephant-bird/pulls/439/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/elephant-bird/statuses/7cec322c4f5c17a973c774338f350dfd8d7fdc05"}}}}