{"action":"closed","number":655,"pull_request":{"url":"https://api.github.com/repos/cinder/Cinder/pulls/655","id":27374324,"html_url":"https://github.com/cinder/Cinder/pull/655","diff_url":"https://github.com/cinder/Cinder/pull/655.diff","patch_url":"https://github.com/cinder/Cinder/pull/655.patch","issue_url":"https://api.github.com/repos/cinder/Cinder/issues/655","number":655,"state":"closed","locked":false,"title":"LoggerFile: Create the file only if/when needed.","user":{"login":"simongeilfus","id":241098,"avatar_url":"https://avatars.githubusercontent.com/u/241098?v=3","gravatar_id":"","url":"https://api.github.com/users/simongeilfus","html_url":"https://github.com/simongeilfus","followers_url":"https://api.github.com/users/simongeilfus/followers","following_url":"https://api.github.com/users/simongeilfus/following{/other_user}","gists_url":"https://api.github.com/users/simongeilfus/gists{/gist_id}","starred_url":"https://api.github.com/users/simongeilfus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simongeilfus/subscriptions","organizations_url":"https://api.github.com/users/simongeilfus/orgs","repos_url":"https://api.github.com/users/simongeilfus/repos","events_url":"https://api.github.com/users/simongeilfus/events{/privacy}","received_events_url":"https://api.github.com/users/simongeilfus/received_events","type":"User","site_admin":false},"body":"Two lines modification to address the “issue” explained here:\r\nhttps://forum.libcinder.org/topic/using-the-new-log-feature-in-glnext#23\r\n286000002245021\r\n\r\nThanks to std::ofstream::is_open, it is easy to check whether the file has already been created or not (http://www.cplusplus.com/reference/fstream/ofstream/is_open/).","created_at":"2015-01-14T19:06:09Z","updated_at":"2015-01-14T21:10:19Z","closed_at":"2015-01-14T21:10:19Z","merged_at":"2015-01-14T21:10:19Z","merge_commit_sha":"6bd8d6b49048b5f8d81e7bd3642869f16139b742","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cinder/Cinder/pulls/655/commits","review_comments_url":"https://api.github.com/repos/cinder/Cinder/pulls/655/comments","review_comment_url":"https://api.github.com/repos/cinder/Cinder/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cinder/Cinder/issues/655/comments","statuses_url":"https://api.github.com/repos/cinder/Cinder/statuses/2a07ca61f9c518cb12af9b498721fc3f03f6b5e1","head":{"label":"simongeilfus:glNext-FileLogger","ref":"glNext-FileLogger","sha":"2a07ca61f9c518cb12af9b498721fc3f03f6b5e1","user":{"login":"simongeilfus","id":241098,"avatar_url":"https://avatars.githubusercontent.com/u/241098?v=3","gravatar_id":"","url":"https://api.github.com/users/simongeilfus","html_url":"https://github.com/simongeilfus","followers_url":"https://api.github.com/users/simongeilfus/followers","following_url":"https://api.github.com/users/simongeilfus/following{/other_user}","gists_url":"https://api.github.com/users/simongeilfus/gists{/gist_id}","starred_url":"https://api.github.com/users/simongeilfus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simongeilfus/subscriptions","organizations_url":"https://api.github.com/users/simongeilfus/orgs","repos_url":"https://api.github.com/users/simongeilfus/repos","events_url":"https://api.github.com/users/simongeilfus/events{/privacy}","received_events_url":"https://api.github.com/users/simongeilfus/received_events","type":"User","site_admin":false},"repo":{"id":3045238,"name":"Cinder","full_name":"simongeilfus/Cinder","owner":{"login":"simongeilfus","id":241098,"avatar_url":"https://avatars.githubusercontent.com/u/241098?v=3","gravatar_id":"","url":"https://api.github.com/users/simongeilfus","html_url":"https://github.com/simongeilfus","followers_url":"https://api.github.com/users/simongeilfus/followers","following_url":"https://api.github.com/users/simongeilfus/following{/other_user}","gists_url":"https://api.github.com/users/simongeilfus/gists{/gist_id}","starred_url":"https://api.github.com/users/simongeilfus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simongeilfus/subscriptions","organizations_url":"https://api.github.com/users/simongeilfus/orgs","repos_url":"https://api.github.com/users/simongeilfus/repos","events_url":"https://api.github.com/users/simongeilfus/events{/privacy}","received_events_url":"https://api.github.com/users/simongeilfus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/simongeilfus/Cinder","description":"Cinder is a community-developed, free and open source library for professional-quality creative coding in C++.","fork":true,"url":"https://api.github.com/repos/simongeilfus/Cinder","forks_url":"https://api.github.com/repos/simongeilfus/Cinder/forks","keys_url":"https://api.github.com/repos/simongeilfus/Cinder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simongeilfus/Cinder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simongeilfus/Cinder/teams","hooks_url":"https://api.github.com/repos/simongeilfus/Cinder/hooks","issue_events_url":"https://api.github.com/repos/simongeilfus/Cinder/issues/events{/number}","events_url":"https://api.github.com/repos/simongeilfus/Cinder/events","assignees_url":"https://api.github.com/repos/simongeilfus/Cinder/assignees{/user}","branches_url":"https://api.github.com/repos/simongeilfus/Cinder/branches{/branch}","tags_url":"https://api.github.com/repos/simongeilfus/Cinder/tags","blobs_url":"https://api.github.com/repos/simongeilfus/Cinder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simongeilfus/Cinder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simongeilfus/Cinder/git/refs{/sha}","trees_url":"https://api.github.com/repos/simongeilfus/Cinder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simongeilfus/Cinder/statuses/{sha}","languages_url":"https://api.github.com/repos/simongeilfus/Cinder/languages","stargazers_url":"https://api.github.com/repos/simongeilfus/Cinder/stargazers","contributors_url":"https://api.github.com/repos/simongeilfus/Cinder/contributors","subscribers_url":"https://api.github.com/repos/simongeilfus/Cinder/subscribers","subscription_url":"https://api.github.com/repos/simongeilfus/Cinder/subscription","commits_url":"https://api.github.com/repos/simongeilfus/Cinder/commits{/sha}","git_commits_url":"https://api.github.com/repos/simongeilfus/Cinder/git/commits{/sha}","comments_url":"https://api.github.com/repos/simongeilfus/Cinder/comments{/number}","issue_comment_url":"https://api.github.com/repos/simongeilfus/Cinder/issues/comments/{number}","contents_url":"https://api.github.com/repos/simongeilfus/Cinder/contents/{+path}","compare_url":"https://api.github.com/repos/simongeilfus/Cinder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simongeilfus/Cinder/merges","archive_url":"https://api.github.com/repos/simongeilfus/Cinder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simongeilfus/Cinder/downloads","issues_url":"https://api.github.com/repos/simongeilfus/Cinder/issues{/number}","pulls_url":"https://api.github.com/repos/simongeilfus/Cinder/pulls{/number}","milestones_url":"https://api.github.com/repos/simongeilfus/Cinder/milestones{/number}","notifications_url":"https://api.github.com/repos/simongeilfus/Cinder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simongeilfus/Cinder/labels{/name}","releases_url":"https://api.github.com/repos/simongeilfus/Cinder/releases{/id}","created_at":"2011-12-24T16:14:06Z","updated_at":"2014-09-06T07:02:09Z","pushed_at":"2015-01-14T19:04:06Z","git_url":"git://github.com/simongeilfus/Cinder.git","ssh_url":"git@github.com:simongeilfus/Cinder.git","clone_url":"https://github.com/simongeilfus/Cinder.git","svn_url":"https://github.com/simongeilfus/Cinder","homepage":"http://libcinder.org","size":212337,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"cinder:glNext","ref":"glNext","sha":"5fcc8d54de5584b6dbb528ef0bccd391f827350c","user":{"login":"cinder","id":154586,"avatar_url":"https://avatars.githubusercontent.com/u/154586?v=3","gravatar_id":"","url":"https://api.github.com/users/cinder","html_url":"https://github.com/cinder","followers_url":"https://api.github.com/users/cinder/followers","following_url":"https://api.github.com/users/cinder/following{/other_user}","gists_url":"https://api.github.com/users/cinder/gists{/gist_id}","starred_url":"https://api.github.com/users/cinder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cinder/subscriptions","organizations_url":"https://api.github.com/users/cinder/orgs","repos_url":"https://api.github.com/users/cinder/repos","events_url":"https://api.github.com/users/cinder/events{/privacy}","received_events_url":"https://api.github.com/users/cinder/received_events","type":"User","site_admin":false},"repo":{"id":622127,"name":"Cinder","full_name":"cinder/Cinder","owner":{"login":"cinder","id":154586,"avatar_url":"https://avatars.githubusercontent.com/u/154586?v=3","gravatar_id":"","url":"https://api.github.com/users/cinder","html_url":"https://github.com/cinder","followers_url":"https://api.github.com/users/cinder/followers","following_url":"https://api.github.com/users/cinder/following{/other_user}","gists_url":"https://api.github.com/users/cinder/gists{/gist_id}","starred_url":"https://api.github.com/users/cinder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cinder/subscriptions","organizations_url":"https://api.github.com/users/cinder/orgs","repos_url":"https://api.github.com/users/cinder/repos","events_url":"https://api.github.com/users/cinder/events{/privacy}","received_events_url":"https://api.github.com/users/cinder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cinder/Cinder","description":"Cinder is a community-developed, free and open source library for professional-quality creative coding in C++.","fork":false,"url":"https://api.github.com/repos/cinder/Cinder","forks_url":"https://api.github.com/repos/cinder/Cinder/forks","keys_url":"https://api.github.com/repos/cinder/Cinder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cinder/Cinder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cinder/Cinder/teams","hooks_url":"https://api.github.com/repos/cinder/Cinder/hooks","issue_events_url":"https://api.github.com/repos/cinder/Cinder/issues/events{/number}","events_url":"https://api.github.com/repos/cinder/Cinder/events","assignees_url":"https://api.github.com/repos/cinder/Cinder/assignees{/user}","branches_url":"https://api.github.com/repos/cinder/Cinder/branches{/branch}","tags_url":"https://api.github.com/repos/cinder/Cinder/tags","blobs_url":"https://api.github.com/repos/cinder/Cinder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cinder/Cinder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cinder/Cinder/git/refs{/sha}","trees_url":"https://api.github.com/repos/cinder/Cinder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cinder/Cinder/statuses/{sha}","languages_url":"https://api.github.com/repos/cinder/Cinder/languages","stargazers_url":"https://api.github.com/repos/cinder/Cinder/stargazers","contributors_url":"https://api.github.com/repos/cinder/Cinder/contributors","subscribers_url":"https://api.github.com/repos/cinder/Cinder/subscribers","subscription_url":"https://api.github.com/repos/cinder/Cinder/subscription","commits_url":"https://api.github.com/repos/cinder/Cinder/commits{/sha}","git_commits_url":"https://api.github.com/repos/cinder/Cinder/git/commits{/sha}","comments_url":"https://api.github.com/repos/cinder/Cinder/comments{/number}","issue_comment_url":"https://api.github.com/repos/cinder/Cinder/issues/comments/{number}","contents_url":"https://api.github.com/repos/cinder/Cinder/contents/{+path}","compare_url":"https://api.github.com/repos/cinder/Cinder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cinder/Cinder/merges","archive_url":"https://api.github.com/repos/cinder/Cinder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cinder/Cinder/downloads","issues_url":"https://api.github.com/repos/cinder/Cinder/issues{/number}","pulls_url":"https://api.github.com/repos/cinder/Cinder/pulls{/number}","milestones_url":"https://api.github.com/repos/cinder/Cinder/milestones{/number}","notifications_url":"https://api.github.com/repos/cinder/Cinder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cinder/Cinder/labels{/name}","releases_url":"https://api.github.com/repos/cinder/Cinder/releases{/id}","created_at":"2010-04-21T19:03:10Z","updated_at":"2015-01-13T19:29:23Z","pushed_at":"2015-01-14T21:10:19Z","git_url":"git://github.com/cinder/Cinder.git","ssh_url":"git@github.com:cinder/Cinder.git","clone_url":"https://github.com/cinder/Cinder.git","svn_url":"https://github.com/cinder/Cinder","homepage":"http://libcinder.org","size":311771,"stargazers_count":1871,"watchers_count":1871,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":438,"mirror_url":null,"open_issues_count":123,"forks":438,"open_issues":123,"watchers":1871,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cinder/Cinder/pulls/655"},"html":{"href":"https://github.com/cinder/Cinder/pull/655"},"issue":{"href":"https://api.github.com/repos/cinder/Cinder/issues/655"},"comments":{"href":"https://api.github.com/repos/cinder/Cinder/issues/655/comments"},"review_comments":{"href":"https://api.github.com/repos/cinder/Cinder/pulls/655/comments"},"review_comment":{"href":"https://api.github.com/repos/cinder/Cinder/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cinder/Cinder/pulls/655/commits"},"statuses":{"href":"https://api.github.com/repos/cinder/Cinder/statuses/2a07ca61f9c518cb12af9b498721fc3f03f6b5e1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"richardeakin","id":5132127,"avatar_url":"https://avatars.githubusercontent.com/u/5132127?v=3","gravatar_id":"","url":"https://api.github.com/users/richardeakin","html_url":"https://github.com/richardeakin","followers_url":"https://api.github.com/users/richardeakin/followers","following_url":"https://api.github.com/users/richardeakin/following{/other_user}","gists_url":"https://api.github.com/users/richardeakin/gists{/gist_id}","starred_url":"https://api.github.com/users/richardeakin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardeakin/subscriptions","organizations_url":"https://api.github.com/users/richardeakin/orgs","repos_url":"https://api.github.com/users/richardeakin/repos","events_url":"https://api.github.com/users/richardeakin/events{/privacy}","received_events_url":"https://api.github.com/users/richardeakin/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":5,"deletions":3,"changed_files":1}}