{"action":"created","comment":{"url":"https://api.github.com/repos/Morlic-fo/freeorion/pulls/comments/46894043","id":46894043,"diff_hunk":"@@ -77,8 +77,12 @@\n MISSING_REQUIREMENT_MULTIPLIER = -1000\n INVALID_DESIGN_RATING = -999  # this needs to be negative but greater than MISSING_REQUIREMENT_MULTIPLIER\n \n+\n+WITH_UPKEEP = 'with upkeep'\n+WITHOUT_UPKEEP = 'without outkeep'","path":"default/AI/ShipDesignAI.py","position":15,"original_position":15,"commit_id":"3ee42c263f6eeb93ee87da803b25f32bc17efc5b","original_commit_id":"3ee42c263f6eeb93ee87da803b25f32bc17efc5b","user":{"login":"Morlic-fo","id":11706951,"avatar_url":"https://avatars.githubusercontent.com/u/11706951?v=3","gravatar_id":"","url":"https://api.github.com/users/Morlic-fo","html_url":"https://github.com/Morlic-fo","followers_url":"https://api.github.com/users/Morlic-fo/followers","following_url":"https://api.github.com/users/Morlic-fo/following{/other_user}","gists_url":"https://api.github.com/users/Morlic-fo/gists{/gist_id}","starred_url":"https://api.github.com/users/Morlic-fo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Morlic-fo/subscriptions","organizations_url":"https://api.github.com/users/Morlic-fo/orgs","repos_url":"https://api.github.com/users/Morlic-fo/repos","events_url":"https://api.github.com/users/Morlic-fo/events{/privacy}","received_events_url":"https://api.github.com/users/Morlic-fo/received_events","type":"User","site_admin":false},"body":"Spelling. Also \"(not) considering fleet upkeep\" is more true to the meaning I think.","created_at":"2015-12-07T23:22:01Z","updated_at":"2015-12-07T23:22:01Z","html_url":"https://github.com/Morlic-fo/freeorion/pull/4#discussion_r46894043","pull_request_url":"https://api.github.com/repos/Morlic-fo/freeorion/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/Morlic-fo/freeorion/pulls/comments/46894043"},"html":{"href":"https://github.com/Morlic-fo/freeorion/pull/4#discussion_r46894043"},"pull_request":{"href":"https://api.github.com/repos/Morlic-fo/freeorion/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/Morlic-fo/freeorion/pulls/4","id":52915815,"html_url":"https://github.com/Morlic-fo/freeorion/pull/4","diff_url":"https://github.com/Morlic-fo/freeorion/pull/4.diff","patch_url":"https://github.com/Morlic-fo/freeorion/pull/4.patch","issue_url":"https://api.github.com/repos/Morlic-fo/freeorion/issues/4","number":4,"state":"open","locked":false,"title":"Use constant","user":{"login":"Cjkjvfnby","id":171597,"avatar_url":"https://avatars.githubusercontent.com/u/171597?v=3","gravatar_id":"","url":"https://api.github.com/users/Cjkjvfnby","html_url":"https://github.com/Cjkjvfnby","followers_url":"https://api.github.com/users/Cjkjvfnby/followers","following_url":"https://api.github.com/users/Cjkjvfnby/following{/other_user}","gists_url":"https://api.github.com/users/Cjkjvfnby/gists{/gist_id}","starred_url":"https://api.github.com/users/Cjkjvfnby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cjkjvfnby/subscriptions","organizations_url":"https://api.github.com/users/Cjkjvfnby/orgs","repos_url":"https://api.github.com/users/Cjkjvfnby/repos","events_url":"https://api.github.com/users/Cjkjvfnby/events{/privacy}","received_events_url":"https://api.github.com/users/Cjkjvfnby/received_events","type":"User","site_admin":false},"body":"It is based on previous PR\r\n\r\nI replace True - False to string constants. This make cache more readable.","created_at":"2015-12-07T23:14:36Z","updated_at":"2015-12-07T23:22:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"662ed297197153141c69e842f8388530b5a85c35","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Morlic-fo/freeorion/pulls/4/commits","review_comments_url":"https://api.github.com/repos/Morlic-fo/freeorion/pulls/4/comments","review_comment_url":"https://api.github.com/repos/Morlic-fo/freeorion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Morlic-fo/freeorion/issues/4/comments","statuses_url":"https://api.github.com/repos/Morlic-fo/freeorion/statuses/3ee42c263f6eeb93ee87da803b25f32bc17efc5b","head":{"label":"Cjkjvfnby:use-constant","ref":"use-constant","sha":"3ee42c263f6eeb93ee87da803b25f32bc17efc5b","user":{"login":"Cjkjvfnby","id":171597,"avatar_url":"https://avatars.githubusercontent.com/u/171597?v=3","gravatar_id":"","url":"https://api.github.com/users/Cjkjvfnby","html_url":"https://github.com/Cjkjvfnby","followers_url":"https://api.github.com/users/Cjkjvfnby/followers","following_url":"https://api.github.com/users/Cjkjvfnby/following{/other_user}","gists_url":"https://api.github.com/users/Cjkjvfnby/gists{/gist_id}","starred_url":"https://api.github.com/users/Cjkjvfnby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cjkjvfnby/subscriptions","organizations_url":"https://api.github.com/users/Cjkjvfnby/orgs","repos_url":"https://api.github.com/users/Cjkjvfnby/repos","events_url":"https://api.github.com/users/Cjkjvfnby/events{/privacy}","received_events_url":"https://api.github.com/users/Cjkjvfnby/received_events","type":"User","site_admin":false},"repo":{"id":33086708,"name":"freeorion","full_name":"Cjkjvfnby/freeorion","owner":{"login":"Cjkjvfnby","id":171597,"avatar_url":"https://avatars.githubusercontent.com/u/171597?v=3","gravatar_id":"","url":"https://api.github.com/users/Cjkjvfnby","html_url":"https://github.com/Cjkjvfnby","followers_url":"https://api.github.com/users/Cjkjvfnby/followers","following_url":"https://api.github.com/users/Cjkjvfnby/following{/other_user}","gists_url":"https://api.github.com/users/Cjkjvfnby/gists{/gist_id}","starred_url":"https://api.github.com/users/Cjkjvfnby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cjkjvfnby/subscriptions","organizations_url":"https://api.github.com/users/Cjkjvfnby/orgs","repos_url":"https://api.github.com/users/Cjkjvfnby/repos","events_url":"https://api.github.com/users/Cjkjvfnby/events{/privacy}","received_events_url":"https://api.github.com/users/Cjkjvfnby/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Cjkjvfnby/freeorion","description":"Source code repository of the FreeOrion project.","fork":true,"url":"https://api.github.com/repos/Cjkjvfnby/freeorion","forks_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/forks","keys_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/teams","hooks_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/hooks","issue_events_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/issues/events{/number}","events_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/events","assignees_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/assignees{/user}","branches_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/branches{/branch}","tags_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/tags","blobs_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/statuses/{sha}","languages_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/languages","stargazers_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/stargazers","contributors_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/contributors","subscribers_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/subscribers","subscription_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/subscription","commits_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/contents/{+path}","compare_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/merges","archive_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/downloads","issues_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/issues{/number}","pulls_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/pulls{/number}","milestones_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/milestones{/number}","notifications_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/labels{/name}","releases_url":"https://api.github.com/repos/Cjkjvfnby/freeorion/releases{/id}","created_at":"2015-03-29T19:50:14Z","updated_at":"2015-05-07T06:27:46Z","pushed_at":"2015-12-07T23:12:31Z","git_url":"git://github.com/Cjkjvfnby/freeorion.git","ssh_url":"git@github.com:Cjkjvfnby/freeorion.git","clone_url":"https://github.com/Cjkjvfnby/freeorion.git","svn_url":"https://github.com/Cjkjvfnby/freeorion","homepage":"http://www.freeorion.org/","size":500911,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"Morlic-fo:AI-ShipDesignTechParsing","ref":"AI-ShipDesignTechParsing","sha":"8ffb30d1dad410bd622cca8e8dfdab3544102648","user":{"login":"Morlic-fo","id":11706951,"avatar_url":"https://avatars.githubusercontent.com/u/11706951?v=3","gravatar_id":"","url":"https://api.github.com/users/Morlic-fo","html_url":"https://github.com/Morlic-fo","followers_url":"https://api.github.com/users/Morlic-fo/followers","following_url":"https://api.github.com/users/Morlic-fo/following{/other_user}","gists_url":"https://api.github.com/users/Morlic-fo/gists{/gist_id}","starred_url":"https://api.github.com/users/Morlic-fo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Morlic-fo/subscriptions","organizations_url":"https://api.github.com/users/Morlic-fo/orgs","repos_url":"https://api.github.com/users/Morlic-fo/repos","events_url":"https://api.github.com/users/Morlic-fo/events{/privacy}","received_events_url":"https://api.github.com/users/Morlic-fo/received_events","type":"User","site_admin":false},"repo":{"id":33083305,"name":"freeorion","full_name":"Morlic-fo/freeorion","owner":{"login":"Morlic-fo","id":11706951,"avatar_url":"https://avatars.githubusercontent.com/u/11706951?v=3","gravatar_id":"","url":"https://api.github.com/users/Morlic-fo","html_url":"https://github.com/Morlic-fo","followers_url":"https://api.github.com/users/Morlic-fo/followers","following_url":"https://api.github.com/users/Morlic-fo/following{/other_user}","gists_url":"https://api.github.com/users/Morlic-fo/gists{/gist_id}","starred_url":"https://api.github.com/users/Morlic-fo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Morlic-fo/subscriptions","organizations_url":"https://api.github.com/users/Morlic-fo/orgs","repos_url":"https://api.github.com/users/Morlic-fo/repos","events_url":"https://api.github.com/users/Morlic-fo/events{/privacy}","received_events_url":"https://api.github.com/users/Morlic-fo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Morlic-fo/freeorion","description":"Source code repository of the FreeOrion project.","fork":true,"url":"https://api.github.com/repos/Morlic-fo/freeorion","forks_url":"https://api.github.com/repos/Morlic-fo/freeorion/forks","keys_url":"https://api.github.com/repos/Morlic-fo/freeorion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Morlic-fo/freeorion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Morlic-fo/freeorion/teams","hooks_url":"https://api.github.com/repos/Morlic-fo/freeorion/hooks","issue_events_url":"https://api.github.com/repos/Morlic-fo/freeorion/issues/events{/number}","events_url":"https://api.github.com/repos/Morlic-fo/freeorion/events","assignees_url":"https://api.github.com/repos/Morlic-fo/freeorion/assignees{/user}","branches_url":"https://api.github.com/repos/Morlic-fo/freeorion/branches{/branch}","tags_url":"https://api.github.com/repos/Morlic-fo/freeorion/tags","blobs_url":"https://api.github.com/repos/Morlic-fo/freeorion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Morlic-fo/freeorion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Morlic-fo/freeorion/git/refs{/sha}","trees_url":"https://api.github.com/repos/Morlic-fo/freeorion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Morlic-fo/freeorion/statuses/{sha}","languages_url":"https://api.github.com/repos/Morlic-fo/freeorion/languages","stargazers_url":"https://api.github.com/repos/Morlic-fo/freeorion/stargazers","contributors_url":"https://api.github.com/repos/Morlic-fo/freeorion/contributors","subscribers_url":"https://api.github.com/repos/Morlic-fo/freeorion/subscribers","subscription_url":"https://api.github.com/repos/Morlic-fo/freeorion/subscription","commits_url":"https://api.github.com/repos/Morlic-fo/freeorion/commits{/sha}","git_commits_url":"https://api.github.com/repos/Morlic-fo/freeorion/git/commits{/sha}","comments_url":"https://api.github.com/repos/Morlic-fo/freeorion/comments{/number}","issue_comment_url":"https://api.github.com/repos/Morlic-fo/freeorion/issues/comments{/number}","contents_url":"https://api.github.com/repos/Morlic-fo/freeorion/contents/{+path}","compare_url":"https://api.github.com/repos/Morlic-fo/freeorion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Morlic-fo/freeorion/merges","archive_url":"https://api.github.com/repos/Morlic-fo/freeorion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Morlic-fo/freeorion/downloads","issues_url":"https://api.github.com/repos/Morlic-fo/freeorion/issues{/number}","pulls_url":"https://api.github.com/repos/Morlic-fo/freeorion/pulls{/number}","milestones_url":"https://api.github.com/repos/Morlic-fo/freeorion/milestones{/number}","notifications_url":"https://api.github.com/repos/Morlic-fo/freeorion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Morlic-fo/freeorion/labels{/name}","releases_url":"https://api.github.com/repos/Morlic-fo/freeorion/releases{/id}","created_at":"2015-03-29T18:09:38Z","updated_at":"2015-04-28T19:03:01Z","pushed_at":"2015-12-07T23:19:31Z","git_url":"git://github.com/Morlic-fo/freeorion.git","ssh_url":"git@github.com:Morlic-fo/freeorion.git","clone_url":"https://github.com/Morlic-fo/freeorion.git","svn_url":"https://github.com/Morlic-fo/freeorion","homepage":"http://www.freeorion.org/","size":497943,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Morlic-fo/freeorion/pulls/4"},"html":{"href":"https://github.com/Morlic-fo/freeorion/pull/4"},"issue":{"href":"https://api.github.com/repos/Morlic-fo/freeorion/issues/4"},"comments":{"href":"https://api.github.com/repos/Morlic-fo/freeorion/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/Morlic-fo/freeorion/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/Morlic-fo/freeorion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Morlic-fo/freeorion/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/Morlic-fo/freeorion/statuses/3ee42c263f6eeb93ee87da803b25f32bc17efc5b"}}}}