{"action":"created","issue":{"url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1145","labels_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1145/labels{/name}","comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1145/comments","events_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1145/events","html_url":"https://github.com/KhronosGroup/WebGL/pull/1145","id":99379713,"number":1145,"title":"fix the error in attrib-location-length-limit.html","user":{"login":"Richard-Yunchao","id":11435653,"avatar_url":"https://avatars.githubusercontent.com/u/11435653?v=3","gravatar_id":"","url":"https://api.github.com/users/Richard-Yunchao","html_url":"https://github.com/Richard-Yunchao","followers_url":"https://api.github.com/users/Richard-Yunchao/followers","following_url":"https://api.github.com/users/Richard-Yunchao/following{/other_user}","gists_url":"https://api.github.com/users/Richard-Yunchao/gists{/gist_id}","starred_url":"https://api.github.com/users/Richard-Yunchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Richard-Yunchao/subscriptions","organizations_url":"https://api.github.com/users/Richard-Yunchao/orgs","repos_url":"https://api.github.com/users/Richard-Yunchao/repos","events_url":"https://api.github.com/users/Richard-Yunchao/events{/privacy}","received_events_url":"https://api.github.com/users/Richard-Yunchao/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-08-06T07:53:31Z","updated_at":"2015-08-08T02:36:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1145","html_url":"https://github.com/KhronosGroup/WebGL/pull/1145","diff_url":"https://github.com/KhronosGroup/WebGL/pull/1145.diff","patch_url":"https://github.com/KhronosGroup/WebGL/pull/1145.patch"},"body":"According to WebGL 2 spec: WebGL 1.0 supports tokens up to 256 characters in length. WebGL 2.0 follows The OpenGL ES Shading Language, Version 3.00 and allows tokens up to 1024 characters in length for both ESSL 1 and ESSL 3 shaders. \r\n\r\nSo attrib-location-length-limit.html failed because the max identifier length is not 256 in WebGL 2. \r\n\r\nHowever, both conformance and conformance2 have specific test cases for identifier length, see shader-with-256-character-identifier.html, shader-with-256-character-identifier.html in conformance/, and shader-with-1024-character-identifier,frag.html and shader-with-1025-character-identifier,frag.html in conformance2/. and attrib-location-length-limit.html is used to test bindAttribLocation and getAttribLocation, so I removed the part that tests identifier max length. \r\n\r\nPTAL when you have time. Thanks."},"comment":{"url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/comments/128887464","html_url":"https://github.com/KhronosGroup/WebGL/pull/1145#issuecomment-128887464","issue_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1145","id":128887464,"user":{"login":"kenrussell","id":1149904,"avatar_url":"https://avatars.githubusercontent.com/u/1149904?v=3","gravatar_id":"","url":"https://api.github.com/users/kenrussell","html_url":"https://github.com/kenrussell","followers_url":"https://api.github.com/users/kenrussell/followers","following_url":"https://api.github.com/users/kenrussell/following{/other_user}","gists_url":"https://api.github.com/users/kenrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/kenrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenrussell/subscriptions","organizations_url":"https://api.github.com/users/kenrussell/orgs","repos_url":"https://api.github.com/users/kenrussell/repos","events_url":"https://api.github.com/users/kenrussell/events{/privacy}","received_events_url":"https://api.github.com/users/kenrussell/received_events","type":"User","site_admin":false},"created_at":"2015-08-08T02:36:01Z","updated_at":"2015-08-08T02:36:01Z","body":"Thanks, this looks better. LGTM. Could you please fix up the merge conflicts and address the one comment in the new test? Thanks.\r\n"}}