{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/14495","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/14495/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/14495/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/14495/events","html_url":"https://github.com/mantidproject/mantid/pull/14495","id":117609643,"number":14495,"title":"ReflectometryReductionOneAuto has issues with multi-period transmission workspaces","user":{"login":"MattKing06","id":13132124,"avatar_url":"https://avatars.githubusercontent.com/u/13132124?v=3","gravatar_id":"","url":"https://api.github.com/users/MattKing06","html_url":"https://github.com/MattKing06","followers_url":"https://api.github.com/users/MattKing06/followers","following_url":"https://api.github.com/users/MattKing06/following{/other_user}","gists_url":"https://api.github.com/users/MattKing06/gists{/gist_id}","starred_url":"https://api.github.com/users/MattKing06/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattKing06/subscriptions","organizations_url":"https://api.github.com/users/MattKing06/orgs","repos_url":"https://api.github.com/users/MattKing06/repos","events_url":"https://api.github.com/users/MattKing06/events{/privacy}","received_events_url":"https://api.github.com/users/MattKing06/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Reflectometry","name":"Component: Reflectometry","color":"009800"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/State:%20In%20Progress","name":"State: In Progress","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"OwenArnold","id":1109536,"avatar_url":"https://avatars.githubusercontent.com/u/1109536?v=3","gravatar_id":"","url":"https://api.github.com/users/OwenArnold","html_url":"https://github.com/OwenArnold","followers_url":"https://api.github.com/users/OwenArnold/followers","following_url":"https://api.github.com/users/OwenArnold/following{/other_user}","gists_url":"https://api.github.com/users/OwenArnold/gists{/gist_id}","starred_url":"https://api.github.com/users/OwenArnold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OwenArnold/subscriptions","organizations_url":"https://api.github.com/users/OwenArnold/orgs","repos_url":"https://api.github.com/users/OwenArnold/repos","events_url":"https://api.github.com/users/OwenArnold/events{/privacy}","received_events_url":"https://api.github.com/users/OwenArnold/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/4","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.6","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/4/labels","id":1106937,"number":4,"title":"Release 3.6","description":"","creator":{"login":"peterfpeterson","id":404003,"avatar_url":"https://avatars.githubusercontent.com/u/404003?v=3","gravatar_id":"","url":"https://api.github.com/users/peterfpeterson","html_url":"https://github.com/peterfpeterson","followers_url":"https://api.github.com/users/peterfpeterson/followers","following_url":"https://api.github.com/users/peterfpeterson/following{/other_user}","gists_url":"https://api.github.com/users/peterfpeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/peterfpeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterfpeterson/subscriptions","organizations_url":"https://api.github.com/users/peterfpeterson/orgs","repos_url":"https://api.github.com/users/peterfpeterson/repos","events_url":"https://api.github.com/users/peterfpeterson/events{/privacy}","received_events_url":"https://api.github.com/users/peterfpeterson/received_events","type":"User","site_admin":false},"open_issues":570,"closed_issues":662,"state":"open","created_at":"2015-05-12T15:36:23Z","updated_at":"2015-11-24T13:10:49Z","due_on":"2016-01-30T05:00:00Z","closed_at":null},"comments":3,"created_at":"2015-11-18T15:22:32Z","updated_at":"2015-11-24T13:17:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/14495","html_url":"https://github.com/mantidproject/mantid/pull/14495","diff_url":"https://github.com/mantidproject/mantid/pull/14495.diff","patch_url":"https://github.com/mantidproject/mantid/pull/14495.patch"},"body":"It doesn't make sense for the transmission workspaces in ReflectometryReductionAutoOne to be multi-period. Now, when processing the group workspaces, ReflectometryReductionAutoOne will sum over the transmission workspaces in the group and use the sum as the transmission workspace.\r\n\r\nA change has also been made so that the `CorrectionAlgorithm` is set to `None` when re-running the ReflectometryReduction again after PolarizationCorrection has been performed.\r\n\r\n\r\n**To Test:** //todo\r\n**Release Notes:**: //todo\r\nFixes #14488"},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/159263938","html_url":"https://github.com/mantidproject/mantid/pull/14495#issuecomment-159263938","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/14495","id":159263938,"user":{"login":"OwenArnold","id":1109536,"avatar_url":"https://avatars.githubusercontent.com/u/1109536?v=3","gravatar_id":"","url":"https://api.github.com/users/OwenArnold","html_url":"https://github.com/OwenArnold","followers_url":"https://api.github.com/users/OwenArnold/followers","following_url":"https://api.github.com/users/OwenArnold/following{/other_user}","gists_url":"https://api.github.com/users/OwenArnold/gists{/gist_id}","starred_url":"https://api.github.com/users/OwenArnold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OwenArnold/subscriptions","organizations_url":"https://api.github.com/users/OwenArnold/orgs","repos_url":"https://api.github.com/users/OwenArnold/repos","events_url":"https://api.github.com/users/OwenArnold/events{/privacy}","received_events_url":"https://api.github.com/users/OwenArnold/received_events","type":"User","site_admin":false},"created_at":"2015-11-24T13:17:51Z","updated_at":"2015-11-24T13:17:51Z","body":"1. Running your System test. I don't see where the summation of the transmission group is happening in the history. I should see that plus has been called 4 times, but I don't see it for some reason.\r\n\r\n2. If I sum the group by myself I can reliably get mantid to crash here `Mantid::Algorithms::ReflectometryReductionOneAuto::processGroups()`. You can use the following to reproduce it.\r\n\r\n```python\r\n\r\n#pylint: disable=no-init,invalid-name,line-too-long\r\n\r\n\"\"\"\r\nThis system test verifies that OFFSPEC data is processed correctly\r\nby ReflectometryReductionAutoOne with PolarizationCorrection performed\r\nas part of the workflow.\r\n\"\"\"\r\n\r\nfrom mantid.simpleapi import *\r\n\r\nclass OFFSPECReflRedOneAutoPolarizationCorrection(object):\r\n    def runTest(self):\r\n        inputWorkspace = Load(\"OFFSPEC00033767.nxs\")\r\n        transmissionGroup = Load(\"OFFSPEC00033772.nxs\")\r\n        #set up our transmission workspace\r\n        transWorkspace = CreateTransmissionWorkspaceAuto(transmissionGroup,\r\n                                                         AnalysisMode=\"MultiDetectorAnalysis\",\r\n                                                         ProcessingInstructions=\"110-120\",\r\n                                                         WavelengthMin=2.0,\r\n                                                         WavelengthMax=12.0)\r\n                                                         \r\n        sum = transWorkspace[0] + transWorkspace[1] + transWorkspace[2] + transWorkspace[3]                                                 \r\n        # set up our efficiency constants\r\n        CRho=[1]\r\n        CAlpha=[1]\r\n        CAp=[1]\r\n        CPp=[1]\r\n        #run reflectometryReductionOneAuto\r\n        __, _IvsLam_polCorr,__ = ReflectometryReductionOneAuto(inputWorkspace, AnalysisMode=\"MultiDetectorAnalysis\",\r\n                                                              ProcessingInstructions=\"110-120\",\r\n                                                              FirstTransmissionRun=sum,\r\n                                                              ThetaIn=\"1.2\",WavelengthMin=2.0,\r\n                                                              WavelengthMax=12.0,CorrectionAlgorithm='None',\r\n                                                              PolarizationAnalysis='PA',\r\n                                                              CPp=CPp,CAp=CAp,CRho=CRho,CAlpha=CAlpha)\r\n        return True\r\n\r\n    def validate(self):\r\n        return (\"_IvsLam_polCorr\", \"OFFSPECReflRedOneAutoPolarizationCorrection_good.nxs\")\r\n\r\n    def requiredFiles(self):\r\n        return [\"OFFSPEC00033767.nxs\",\r\n                \"OFFSPEC00033772.nxs\",\r\n                \"OFFSPECReflRedOneAutoPolarizationCorrection_good.nxs\"]\r\n                \r\n                \r\nOFFSPECReflRedOneAutoPolarizationCorrection().runTest()\r\n```\r\n"}}