{"action":"created","issue":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/2502","labels_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/2502/labels{/name}","comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/2502/comments","events_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/2502/events","html_url":"https://github.com/FreeRDP/FreeRDP/pull/2502","id":64741836,"number":2502,"title":"stream: Stream_Ensure*Capacity: change return type","user":{"login":"bmiklautz","id":195793,"avatar_url":"https://avatars.githubusercontent.com/u/195793?v=3","gravatar_id":"","url":"https://api.github.com/users/bmiklautz","html_url":"https://github.com/bmiklautz","followers_url":"https://api.github.com/users/bmiklautz/followers","following_url":"https://api.github.com/users/bmiklautz/following{/other_user}","gists_url":"https://api.github.com/users/bmiklautz/gists{/gist_id}","starred_url":"https://api.github.com/users/bmiklautz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmiklautz/subscriptions","organizations_url":"https://api.github.com/users/bmiklautz/orgs","repos_url":"https://api.github.com/users/bmiklautz/repos","events_url":"https://api.github.com/users/bmiklautz/events{/privacy}","received_events_url":"https://api.github.com/users/bmiklautz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-03-27T11:18:35Z","updated_at":"2015-03-28T08:22:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2502","html_url":"https://github.com/FreeRDP/FreeRDP/pull/2502","diff_url":"https://github.com/FreeRDP/FreeRDP/pull/2502.diff","patch_url":"https://github.com/FreeRDP/FreeRDP/pull/2502.patch"},"body":"Change the return type of Stream_Ensure*Capacity from void to BOOL to be\r\nable to detect realloc problems easily. Otherwise the only way to detect\r\nthis was to check if the capacity after the call was >= the required\r\nsize.\r\nIn case Stream_Ensure*Capacity fails the old memory is still available\r\nand need to freed outside.\r\n\r\nThis commit also adds checks to most calls of Stream_Ensure*Capacity to\r\ncheck if the call was successful."},"comment":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/comments/87189812","html_url":"https://github.com/FreeRDP/FreeRDP/pull/2502#issuecomment-87189812","issue_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/2502","id":87189812,"user":{"login":"freerdp-bot","id":3977138,"avatar_url":"https://avatars.githubusercontent.com/u/3977138?v=3","gravatar_id":"","url":"https://api.github.com/users/freerdp-bot","html_url":"https://github.com/freerdp-bot","followers_url":"https://api.github.com/users/freerdp-bot/followers","following_url":"https://api.github.com/users/freerdp-bot/following{/other_user}","gists_url":"https://api.github.com/users/freerdp-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/freerdp-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freerdp-bot/subscriptions","organizations_url":"https://api.github.com/users/freerdp-bot/orgs","repos_url":"https://api.github.com/users/freerdp-bot/repos","events_url":"https://api.github.com/users/freerdp-bot/events{/privacy}","received_events_url":"https://api.github.com/users/freerdp-bot/received_events","type":"User","site_admin":false},"created_at":"2015-03-28T08:22:38Z","updated_at":"2015-03-28T08:22:38Z","body":"\nRefer to this link for build results (access rights to CI server needed): \nhttps://ci.freerdp.com//job/PullRequestTester/172/\nTest PASSed."}}