{"action":"created","issue":{"url":"https://api.github.com/repos/atom/node-oniguruma/issues/26","labels_url":"https://api.github.com/repos/atom/node-oniguruma/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/atom/node-oniguruma/issues/26/comments","events_url":"https://api.github.com/repos/atom/node-oniguruma/issues/26/events","html_url":"https://github.com/atom/node-oniguruma/pull/26","id":60499471,"number":26,"title":"Update oniguruma, dependencies and improve building for windows","user":{"login":"Ingramz","id":1017132,"avatar_url":"https://avatars.githubusercontent.com/u/1017132?v=3","gravatar_id":"","url":"https://api.github.com/users/Ingramz","html_url":"https://github.com/Ingramz","followers_url":"https://api.github.com/users/Ingramz/followers","following_url":"https://api.github.com/users/Ingramz/following{/other_user}","gists_url":"https://api.github.com/users/Ingramz/gists{/gist_id}","starred_url":"https://api.github.com/users/Ingramz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ingramz/subscriptions","organizations_url":"https://api.github.com/users/Ingramz/orgs","repos_url":"https://api.github.com/users/Ingramz/repos","events_url":"https://api.github.com/users/Ingramz/events{/privacy}","received_events_url":"https://api.github.com/users/Ingramz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-10T13:32:49Z","updated_at":"2015-03-23T06:51:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/atom/node-oniguruma/pulls/26","html_url":"https://github.com/atom/node-oniguruma/pull/26","diff_url":"https://github.com/atom/node-oniguruma/pull/26.diff","patch_url":"https://github.com/atom/node-oniguruma/pull/26.patch"},"body":"Installing the package did not go that well under windows, so I looked into it.\r\n\r\nHere's all what I did.\r\n\r\n1. Fixed compile warning for isblank as it is defined to take an integer elsewhere. ```..\\deps\\onig\\enc\\mktable.c(265): warning C4028: formal parameter 1 different from declaration```\r\n\r\n2. Updated all dependencies to latest versions\r\n    My guess is that it's OK to use the latest nan from npm, but I couldn't verify it.\r\n    The most important change is update of grunt-coffeelint, which did not install properly under windows. (relied on ```[ -e filename ]``` command-line syntax).\r\n\r\n3. Fixed indentation for files in src folder, because updated cpplint started complaining.\r\n\r\n4. Updated Oniguruma to version 5.9.6\r\n\r\n5. Added ```/EHsc``` option for MSVC to suppress C4530 warnings.\r\n    It could be that ```/EHa``` or ```/EHs``` are better options, but nothing seemed to break, for now.\r\n\r\n6. Reordered the inclusion of ```nan.h``` in ```src/onig-scanner.h``` in order to fix  ```windows.h``` inclusion issues caused by Oniguruma update\r\n\r\n7. Added coffeelint as a dev dependency to fix npm peer dependency warning.\r\n\r\n8. Fixed C4133 warning caused by Oniguruma update. Seems like they missed this upstream.\r\n\r\n9. Removed certain warning suppressions for windows that did not occur during build. If these are known to occur on earlier msvs versions, then this could be reverted.\r\n\r\nTested with Windows 8.1 (VS 2013 community), Ubuntu 14.10 and OS X 10.10.2, all running node 0.12.0."},"comment":{"url":"https://api.github.com/repos/atom/node-oniguruma/issues/comments/84843792","html_url":"https://github.com/atom/node-oniguruma/pull/26#issuecomment-84843792","issue_url":"https://api.github.com/repos/atom/node-oniguruma/issues/26","id":84843792,"user":{"login":"zcbenz","id":639601,"avatar_url":"https://avatars.githubusercontent.com/u/639601?v=3","gravatar_id":"","url":"https://api.github.com/users/zcbenz","html_url":"https://github.com/zcbenz","followers_url":"https://api.github.com/users/zcbenz/followers","following_url":"https://api.github.com/users/zcbenz/following{/other_user}","gists_url":"https://api.github.com/users/zcbenz/gists{/gist_id}","starred_url":"https://api.github.com/users/zcbenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcbenz/subscriptions","organizations_url":"https://api.github.com/users/zcbenz/orgs","repos_url":"https://api.github.com/users/zcbenz/repos","events_url":"https://api.github.com/users/zcbenz/events{/privacy}","received_events_url":"https://api.github.com/users/zcbenz/received_events","type":"User","site_admin":true},"created_at":"2015-03-23T06:51:55Z","updated_at":"2015-03-23T06:51:55Z","body":"@Ingramz Sorry for the late rely, this PR looks good to me, can you rebase it on (or merge) the master branch? After that I'll merge this PR, thanks!"}}