{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments/38701809","id":38701809,"diff_hunk":"@@ -64,3 +66,40 @@ def AllowPort(self, vm, from_port, to_port=None, protocol='tcp'):\n \n     def DisallowAllPorts(self):\n         pass\n+\n+\n+class OpenStackPublicNetwork(object):\n+\n+    def __init__(self, pool):\n+        self.__nclient = utils.NovaClient()\n+        self.__floating_ip_lock = threading.Lock()\n+        self.pool = pool\n+\n+    def allocate(self):\n+        with self.__floating_ip_lock:\n+            return self.__nclient.floating_ips.create(pool=self.pool)\n+\n+    def release(self, floating_ip):\n+        f_id = floating_ip.id\n+        if self.__nclient.floating_ips.get(f_id).fixed_ip:","path":"perfkitbenchmarker/openstack/os_network.py","position":28,"original_position":28,"commit_id":"5c2580ff0eb39dac7318fd30bee87b829b665d60","original_commit_id":"5c2580ff0eb39dac7318fd30bee87b829b665d60","user":{"login":"skschneider","id":11166925,"avatar_url":"https://avatars.githubusercontent.com/u/11166925?v=3","gravatar_id":"","url":"https://api.github.com/users/skschneider","html_url":"https://github.com/skschneider","followers_url":"https://api.github.com/users/skschneider/followers","following_url":"https://api.github.com/users/skschneider/following{/other_user}","gists_url":"https://api.github.com/users/skschneider/gists{/gist_id}","starred_url":"https://api.github.com/users/skschneider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skschneider/subscriptions","organizations_url":"https://api.github.com/users/skschneider/orgs","repos_url":"https://api.github.com/users/skschneider/repos","events_url":"https://api.github.com/users/skschneider/events{/privacy}","received_events_url":"https://api.github.com/users/skschneider/received_events","type":"User","site_admin":false},"body":"I can't find NovaClient.floating_ips. Is there another file in your branch that should be in this PR?","created_at":"2015-09-03T22:02:28Z","updated_at":"2015-09-03T22:02:28Z","html_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/438#discussion_r38701809","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/438","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments/38701809"},"html":{"href":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/438#discussion_r38701809"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/438"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/438","id":43487449,"html_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/438","diff_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/438.diff","patch_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/438.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/438","number":438,"state":"open","locked":false,"title":"move management of public IPs in OpenStack to dedicated class","user":{"login":"kivio","id":1194156,"avatar_url":"https://avatars.githubusercontent.com/u/1194156?v=3","gravatar_id":"","url":"https://api.github.com/users/kivio","html_url":"https://github.com/kivio","followers_url":"https://api.github.com/users/kivio/followers","following_url":"https://api.github.com/users/kivio/following{/other_user}","gists_url":"https://api.github.com/users/kivio/gists{/gist_id}","starred_url":"https://api.github.com/users/kivio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kivio/subscriptions","organizations_url":"https://api.github.com/users/kivio/orgs","repos_url":"https://api.github.com/users/kivio/repos","events_url":"https://api.github.com/users/kivio/events{/privacy}","received_events_url":"https://api.github.com/users/kivio/received_events","type":"User","site_admin":false},"body":"move code of public IP management to one place.","created_at":"2015-08-27T07:36:55Z","updated_at":"2015-09-03T22:02:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e66a981f55af4c4c5c399811f565ad65e3ca2d2f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/438/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/438/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/438/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/statuses/5c2580ff0eb39dac7318fd30bee87b829b665d60","head":{"label":"kivio:floating_ip_manager","ref":"floating_ip_manager","sha":"5c2580ff0eb39dac7318fd30bee87b829b665d60","user":{"login":"kivio","id":1194156,"avatar_url":"https://avatars.githubusercontent.com/u/1194156?v=3","gravatar_id":"","url":"https://api.github.com/users/kivio","html_url":"https://github.com/kivio","followers_url":"https://api.github.com/users/kivio/followers","following_url":"https://api.github.com/users/kivio/following{/other_user}","gists_url":"https://api.github.com/users/kivio/gists{/gist_id}","starred_url":"https://api.github.com/users/kivio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kivio/subscriptions","organizations_url":"https://api.github.com/users/kivio/orgs","repos_url":"https://api.github.com/users/kivio/repos","events_url":"https://api.github.com/users/kivio/events{/privacy}","received_events_url":"https://api.github.com/users/kivio/received_events","type":"User","site_admin":false},"repo":{"id":32446603,"name":"PerfKitBenchmarker","full_name":"kivio/PerfKitBenchmarker","owner":{"login":"kivio","id":1194156,"avatar_url":"https://avatars.githubusercontent.com/u/1194156?v=3","gravatar_id":"","url":"https://api.github.com/users/kivio","html_url":"https://github.com/kivio","followers_url":"https://api.github.com/users/kivio/followers","following_url":"https://api.github.com/users/kivio/following{/other_user}","gists_url":"https://api.github.com/users/kivio/gists{/gist_id}","starred_url":"https://api.github.com/users/kivio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kivio/subscriptions","organizations_url":"https://api.github.com/users/kivio/orgs","repos_url":"https://api.github.com/users/kivio/repos","events_url":"https://api.github.com/users/kivio/events{/privacy}","received_events_url":"https://api.github.com/users/kivio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kivio/PerfKitBenchmarker","description":"Perfkit Benchmarker contains set of benchmarks to measure and compare cloud offerings. The benchmarks are not tuned (i.e. use defaults) to reflect what most users will see. PerfKit Benchmarker is licensed under the Apache 2 license terms. Please make sure to read, understand and agree to the terms of the LICENSE and CONTRIBUTING files before proceeding.","fork":true,"url":"https://api.github.com/repos/kivio/PerfKitBenchmarker","forks_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/forks","keys_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/teams","hooks_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/hooks","issue_events_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/issues/events{/number}","events_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/events","assignees_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/assignees{/user}","branches_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/branches{/branch}","tags_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/tags","blobs_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/git/refs{/sha}","trees_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/statuses/{sha}","languages_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/languages","stargazers_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/stargazers","contributors_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/contributors","subscribers_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/subscribers","subscription_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/subscription","commits_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/commits{/sha}","git_commits_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/git/commits{/sha}","comments_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/comments{/number}","issue_comment_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/issues/comments{/number}","contents_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/contents/{+path}","compare_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/merges","archive_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/downloads","issues_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/issues{/number}","pulls_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/pulls{/number}","milestones_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/milestones{/number}","notifications_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/labels{/name}","releases_url":"https://api.github.com/repos/kivio/PerfKitBenchmarker/releases{/id}","created_at":"2015-03-18T08:24:43Z","updated_at":"2015-03-18T08:24:44Z","pushed_at":"2015-09-03T20:33:00Z","git_url":"git://github.com/kivio/PerfKitBenchmarker.git","ssh_url":"git@github.com:kivio/PerfKitBenchmarker.git","clone_url":"https://github.com/kivio/PerfKitBenchmarker.git","svn_url":"https://github.com/kivio/PerfKitBenchmarker","homepage":"","size":2683,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"cfb13c603331828462828359b53d21c5e268b072","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":21950910,"name":"PerfKitBenchmarker","full_name":"GoogleCloudPlatform/PerfKitBenchmarker","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker","description":"Perfkit Benchmarker contains set of benchmarks to measure and compare cloud offerings. The benchmarks are not tuned (i.e. use defaults) to reflect what most users will see. PerfKit Benchmarker is licensed under the Apache 2 license terms. Please make sure to read, understand and agree to the terms of the LICENSE and CONTRIBUTING files before proceeding.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/releases{/id}","created_at":"2014-07-17T17:23:26Z","updated_at":"2015-09-02T19:37:52Z","pushed_at":"2015-09-03T20:06:05Z","git_url":"git://github.com/GoogleCloudPlatform/PerfKitBenchmarker.git","ssh_url":"git@github.com:GoogleCloudPlatform/PerfKitBenchmarker.git","clone_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker.git","svn_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker","homepage":"","size":84621,"stargazers_count":476,"watchers_count":476,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":75,"mirror_url":null,"open_issues_count":93,"forks":75,"open_issues":93,"watchers":476,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/438"},"html":{"href":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/438"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/438"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/438/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/438/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/438/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/statuses/5c2580ff0eb39dac7318fd30bee87b829b665d60"}}}}