{"action":"closed","number":43,"pull_request":{"url":"https://api.github.com/repos/jkitchin/jasp/pulls/43","id":32177229,"html_url":"https://github.com/jkitchin/jasp/pull/43","diff_url":"https://github.com/jkitchin/jasp/pull/43.diff","patch_url":"https://github.com/jkitchin/jasp/pull/43.patch","issue_url":"https://api.github.com/repos/jkitchin/jasp/issues/43","number":43,"state":"closed","locked":false,"title":"add try/except in get_dipole_moment to catch empty/missing CHG file","user":{"login":"prtkm","id":2263899,"avatar_url":"https://avatars.githubusercontent.com/u/2263899?v=3","gravatar_id":"","url":"https://api.github.com/users/prtkm","html_url":"https://github.com/prtkm","followers_url":"https://api.github.com/users/prtkm/followers","following_url":"https://api.github.com/users/prtkm/following{/other_user}","gists_url":"https://api.github.com/users/prtkm/gists{/gist_id}","starred_url":"https://api.github.com/users/prtkm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prtkm/subscriptions","organizations_url":"https://api.github.com/users/prtkm/orgs","repos_url":"https://api.github.com/users/prtkm/repos","events_url":"https://api.github.com/users/prtkm/events{/privacy}","received_events_url":"https://api.github.com/users/prtkm/received_events","type":"User","site_admin":false},"body":"Hi John,\r\n\r\nI added some code to catch errors in get_dipole_moment to get it to work with view in when,\r\n1. it is called outside the context manager, and the CHG file is not present. \r\n2. it is called inside the context manager, but the CHG file is empty because lcharg is False\r\n\r\nPrateek","created_at":"2015-03-29T06:14:59Z","updated_at":"2015-03-30T00:42:29Z","closed_at":"2015-03-30T00:42:29Z","merged_at":"2015-03-30T00:42:29Z","merge_commit_sha":"b8f4ecb2fa79ed74452730b123c664e782adaa2f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jkitchin/jasp/pulls/43/commits","review_comments_url":"https://api.github.com/repos/jkitchin/jasp/pulls/43/comments","review_comment_url":"https://api.github.com/repos/jkitchin/jasp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jkitchin/jasp/issues/43/comments","statuses_url":"https://api.github.com/repos/jkitchin/jasp/statuses/f915fbb3146ba9bd4c9f1d92bba62b2247500be1","head":{"label":"prtkm:upstream","ref":"upstream","sha":"f915fbb3146ba9bd4c9f1d92bba62b2247500be1","user":{"login":"prtkm","id":2263899,"avatar_url":"https://avatars.githubusercontent.com/u/2263899?v=3","gravatar_id":"","url":"https://api.github.com/users/prtkm","html_url":"https://github.com/prtkm","followers_url":"https://api.github.com/users/prtkm/followers","following_url":"https://api.github.com/users/prtkm/following{/other_user}","gists_url":"https://api.github.com/users/prtkm/gists{/gist_id}","starred_url":"https://api.github.com/users/prtkm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prtkm/subscriptions","organizations_url":"https://api.github.com/users/prtkm/orgs","repos_url":"https://api.github.com/users/prtkm/repos","events_url":"https://api.github.com/users/prtkm/events{/privacy}","received_events_url":"https://api.github.com/users/prtkm/received_events","type":"User","site_admin":false},"repo":{"id":23120955,"name":"jasp","full_name":"prtkm/jasp","owner":{"login":"prtkm","id":2263899,"avatar_url":"https://avatars.githubusercontent.com/u/2263899?v=3","gravatar_id":"","url":"https://api.github.com/users/prtkm","html_url":"https://github.com/prtkm","followers_url":"https://api.github.com/users/prtkm/followers","following_url":"https://api.github.com/users/prtkm/following{/other_user}","gists_url":"https://api.github.com/users/prtkm/gists{/gist_id}","starred_url":"https://api.github.com/users/prtkm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prtkm/subscriptions","organizations_url":"https://api.github.com/users/prtkm/orgs","repos_url":"https://api.github.com/users/prtkm/repos","events_url":"https://api.github.com/users/prtkm/events{/privacy}","received_events_url":"https://api.github.com/users/prtkm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/prtkm/jasp","description":"python enhancements of ase.calculators.vasp","fork":true,"url":"https://api.github.com/repos/prtkm/jasp","forks_url":"https://api.github.com/repos/prtkm/jasp/forks","keys_url":"https://api.github.com/repos/prtkm/jasp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prtkm/jasp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prtkm/jasp/teams","hooks_url":"https://api.github.com/repos/prtkm/jasp/hooks","issue_events_url":"https://api.github.com/repos/prtkm/jasp/issues/events{/number}","events_url":"https://api.github.com/repos/prtkm/jasp/events","assignees_url":"https://api.github.com/repos/prtkm/jasp/assignees{/user}","branches_url":"https://api.github.com/repos/prtkm/jasp/branches{/branch}","tags_url":"https://api.github.com/repos/prtkm/jasp/tags","blobs_url":"https://api.github.com/repos/prtkm/jasp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prtkm/jasp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prtkm/jasp/git/refs{/sha}","trees_url":"https://api.github.com/repos/prtkm/jasp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prtkm/jasp/statuses/{sha}","languages_url":"https://api.github.com/repos/prtkm/jasp/languages","stargazers_url":"https://api.github.com/repos/prtkm/jasp/stargazers","contributors_url":"https://api.github.com/repos/prtkm/jasp/contributors","subscribers_url":"https://api.github.com/repos/prtkm/jasp/subscribers","subscription_url":"https://api.github.com/repos/prtkm/jasp/subscription","commits_url":"https://api.github.com/repos/prtkm/jasp/commits{/sha}","git_commits_url":"https://api.github.com/repos/prtkm/jasp/git/commits{/sha}","comments_url":"https://api.github.com/repos/prtkm/jasp/comments{/number}","issue_comment_url":"https://api.github.com/repos/prtkm/jasp/issues/comments{/number}","contents_url":"https://api.github.com/repos/prtkm/jasp/contents/{+path}","compare_url":"https://api.github.com/repos/prtkm/jasp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prtkm/jasp/merges","archive_url":"https://api.github.com/repos/prtkm/jasp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prtkm/jasp/downloads","issues_url":"https://api.github.com/repos/prtkm/jasp/issues{/number}","pulls_url":"https://api.github.com/repos/prtkm/jasp/pulls{/number}","milestones_url":"https://api.github.com/repos/prtkm/jasp/milestones{/number}","notifications_url":"https://api.github.com/repos/prtkm/jasp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prtkm/jasp/labels{/name}","releases_url":"https://api.github.com/repos/prtkm/jasp/releases{/id}","created_at":"2014-08-19T18:23:10Z","updated_at":"2015-03-29T06:07:01Z","pushed_at":"2015-03-29T06:11:03Z","git_url":"git://github.com/prtkm/jasp.git","ssh_url":"git@github.com:prtkm/jasp.git","clone_url":"https://github.com/prtkm/jasp.git","svn_url":"https://github.com/prtkm/jasp","homepage":null,"size":9230,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jkitchin:master","ref":"master","sha":"a7c9a8e80545f3d99e9163bf3dc5e0c7add16918","user":{"login":"jkitchin","id":1610070,"avatar_url":"https://avatars.githubusercontent.com/u/1610070?v=3","gravatar_id":"","url":"https://api.github.com/users/jkitchin","html_url":"https://github.com/jkitchin","followers_url":"https://api.github.com/users/jkitchin/followers","following_url":"https://api.github.com/users/jkitchin/following{/other_user}","gists_url":"https://api.github.com/users/jkitchin/gists{/gist_id}","starred_url":"https://api.github.com/users/jkitchin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkitchin/subscriptions","organizations_url":"https://api.github.com/users/jkitchin/orgs","repos_url":"https://api.github.com/users/jkitchin/repos","events_url":"https://api.github.com/users/jkitchin/events{/privacy}","received_events_url":"https://api.github.com/users/jkitchin/received_events","type":"User","site_admin":false},"repo":{"id":5934183,"name":"jasp","full_name":"jkitchin/jasp","owner":{"login":"jkitchin","id":1610070,"avatar_url":"https://avatars.githubusercontent.com/u/1610070?v=3","gravatar_id":"","url":"https://api.github.com/users/jkitchin","html_url":"https://github.com/jkitchin","followers_url":"https://api.github.com/users/jkitchin/followers","following_url":"https://api.github.com/users/jkitchin/following{/other_user}","gists_url":"https://api.github.com/users/jkitchin/gists{/gist_id}","starred_url":"https://api.github.com/users/jkitchin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkitchin/subscriptions","organizations_url":"https://api.github.com/users/jkitchin/orgs","repos_url":"https://api.github.com/users/jkitchin/repos","events_url":"https://api.github.com/users/jkitchin/events{/privacy}","received_events_url":"https://api.github.com/users/jkitchin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jkitchin/jasp","description":"python enhancements of ase.calculators.vasp","fork":false,"url":"https://api.github.com/repos/jkitchin/jasp","forks_url":"https://api.github.com/repos/jkitchin/jasp/forks","keys_url":"https://api.github.com/repos/jkitchin/jasp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jkitchin/jasp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jkitchin/jasp/teams","hooks_url":"https://api.github.com/repos/jkitchin/jasp/hooks","issue_events_url":"https://api.github.com/repos/jkitchin/jasp/issues/events{/number}","events_url":"https://api.github.com/repos/jkitchin/jasp/events","assignees_url":"https://api.github.com/repos/jkitchin/jasp/assignees{/user}","branches_url":"https://api.github.com/repos/jkitchin/jasp/branches{/branch}","tags_url":"https://api.github.com/repos/jkitchin/jasp/tags","blobs_url":"https://api.github.com/repos/jkitchin/jasp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jkitchin/jasp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jkitchin/jasp/git/refs{/sha}","trees_url":"https://api.github.com/repos/jkitchin/jasp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jkitchin/jasp/statuses/{sha}","languages_url":"https://api.github.com/repos/jkitchin/jasp/languages","stargazers_url":"https://api.github.com/repos/jkitchin/jasp/stargazers","contributors_url":"https://api.github.com/repos/jkitchin/jasp/contributors","subscribers_url":"https://api.github.com/repos/jkitchin/jasp/subscribers","subscription_url":"https://api.github.com/repos/jkitchin/jasp/subscription","commits_url":"https://api.github.com/repos/jkitchin/jasp/commits{/sha}","git_commits_url":"https://api.github.com/repos/jkitchin/jasp/git/commits{/sha}","comments_url":"https://api.github.com/repos/jkitchin/jasp/comments{/number}","issue_comment_url":"https://api.github.com/repos/jkitchin/jasp/issues/comments{/number}","contents_url":"https://api.github.com/repos/jkitchin/jasp/contents/{+path}","compare_url":"https://api.github.com/repos/jkitchin/jasp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jkitchin/jasp/merges","archive_url":"https://api.github.com/repos/jkitchin/jasp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jkitchin/jasp/downloads","issues_url":"https://api.github.com/repos/jkitchin/jasp/issues{/number}","pulls_url":"https://api.github.com/repos/jkitchin/jasp/pulls{/number}","milestones_url":"https://api.github.com/repos/jkitchin/jasp/milestones{/number}","notifications_url":"https://api.github.com/repos/jkitchin/jasp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jkitchin/jasp/labels{/name}","releases_url":"https://api.github.com/repos/jkitchin/jasp/releases{/id}","created_at":"2012-09-24T12:33:41Z","updated_at":"2015-03-26T13:59:51Z","pushed_at":"2015-03-30T00:42:29Z","git_url":"git://github.com/jkitchin/jasp.git","ssh_url":"git@github.com:jkitchin/jasp.git","clone_url":"https://github.com/jkitchin/jasp.git","svn_url":"https://github.com/jkitchin/jasp","homepage":null,"size":9574,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":7,"forks":8,"open_issues":7,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jkitchin/jasp/pulls/43"},"html":{"href":"https://github.com/jkitchin/jasp/pull/43"},"issue":{"href":"https://api.github.com/repos/jkitchin/jasp/issues/43"},"comments":{"href":"https://api.github.com/repos/jkitchin/jasp/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/jkitchin/jasp/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/jkitchin/jasp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jkitchin/jasp/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/jkitchin/jasp/statuses/f915fbb3146ba9bd4c9f1d92bba62b2247500be1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jkitchin","id":1610070,"avatar_url":"https://avatars.githubusercontent.com/u/1610070?v=3","gravatar_id":"","url":"https://api.github.com/users/jkitchin","html_url":"https://github.com/jkitchin","followers_url":"https://api.github.com/users/jkitchin/followers","following_url":"https://api.github.com/users/jkitchin/following{/other_user}","gists_url":"https://api.github.com/users/jkitchin/gists{/gist_id}","starred_url":"https://api.github.com/users/jkitchin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkitchin/subscriptions","organizations_url":"https://api.github.com/users/jkitchin/orgs","repos_url":"https://api.github.com/users/jkitchin/repos","events_url":"https://api.github.com/users/jkitchin/events{/privacy}","received_events_url":"https://api.github.com/users/jkitchin/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":9,"deletions":2,"changed_files":1}}