{"action":"created","comment":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments/25787686","id":25787686,"diff_hunk":"@@ -78,6 +78,12 @@ bool AstPrintDocs::enterFnSym(FnSymbol* node) {\n \n \n bool AstPrintDocs::enterModSym(ModuleSymbol* node) {\n+  // If a module is not supposed to be documented, do not traverse into it (and\n+  // skip the documentation).\n+  if (node->hasFlag(FLAG_NO_DOC)) {\n+      return false;\n+  }\n+","path":"compiler/AST/AstPrintDocs.cpp","position":9,"original_position":9,"commit_id":"c915be61c07e799934e33625e8180fbbed275620","original_commit_id":"c915be61c07e799934e33625e8180fbbed275620","user":{"login":"lydia-duncan","id":2454710,"avatar_url":"https://avatars.githubusercontent.com/u/2454710?v=3","gravatar_id":"","url":"https://api.github.com/users/lydia-duncan","html_url":"https://github.com/lydia-duncan","followers_url":"https://api.github.com/users/lydia-duncan/followers","following_url":"https://api.github.com/users/lydia-duncan/following{/other_user}","gists_url":"https://api.github.com/users/lydia-duncan/gists{/gist_id}","starred_url":"https://api.github.com/users/lydia-duncan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lydia-duncan/subscriptions","organizations_url":"https://api.github.com/users/lydia-duncan/orgs","repos_url":"https://api.github.com/users/lydia-duncan/repos","events_url":"https://api.github.com/users/lydia-duncan/events{/privacy}","received_events_url":"https://api.github.com/users/lydia-duncan/received_events","type":"User","site_admin":false},"body":"Is it still useful for node->printDocs to do this same check?  I'd remove it from there, otherwise.","created_at":"2015-03-04T16:22:18Z","updated_at":"2015-03-04T16:22:18Z","html_url":"https://github.com/chapel-lang/chapel/pull/1451#discussion_r25787686","pull_request_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/1451","_links":{"self":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments/25787686"},"html":{"href":"https://github.com/chapel-lang/chapel/pull/1451#discussion_r25787686"},"pull_request":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/1451"}}},"pull_request":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/1451","id":30427678,"html_url":"https://github.com/chapel-lang/chapel/pull/1451","diff_url":"https://github.com/chapel-lang/chapel/pull/1451.diff","patch_url":"https://github.com/chapel-lang/chapel/pull/1451.patch","issue_url":"https://api.github.com/repos/chapel-lang/chapel/issues/1451","number":1451,"state":"open","locked":false,"title":"Update AstPrintDocs visitor to correctly handle \"no doc\" pragmas on submodules.","user":{"login":"thomasvandoren","id":530981,"avatar_url":"https://avatars.githubusercontent.com/u/530981?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasvandoren","html_url":"https://github.com/thomasvandoren","followers_url":"https://api.github.com/users/thomasvandoren/followers","following_url":"https://api.github.com/users/thomasvandoren/following{/other_user}","gists_url":"https://api.github.com/users/thomasvandoren/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasvandoren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasvandoren/subscriptions","organizations_url":"https://api.github.com/users/thomasvandoren/orgs","repos_url":"https://api.github.com/users/thomasvandoren/repos","events_url":"https://api.github.com/users/thomasvandoren/events{/privacy}","received_events_url":"https://api.github.com/users/thomasvandoren/received_events","type":"User","site_admin":false},"body":"Previously, the \"no doc\" pragma was ignored when traversing submodules. The\r\nmodule documentation would not be produced (correcty), but traversal would not\r\nstop so anything inside the submodule would be documented (incorrect).\r\n\r\nUpdate the visitor to check if the module has the \"no doc\" pragma, and, if so,\r\nstop the AST traversal and avoid documenting the submodule.\r\n\r\nUpdate existing no doc test to exercise this issue, and the fix.","created_at":"2015-03-04T00:33:32Z","updated_at":"2015-03-04T16:22:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9692282216c64cbb7ba9ee8c019c9b4a2f190faf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/1451/commits","review_comments_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/1451/comments","review_comment_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/issues/1451/comments","statuses_url":"https://api.github.com/repos/chapel-lang/chapel/statuses/c915be61c07e799934e33625e8180fbbed275620","head":{"label":"thomasvandoren:fix-mod-no-doc","ref":"fix-mod-no-doc","sha":"c915be61c07e799934e33625e8180fbbed275620","user":{"login":"thomasvandoren","id":530981,"avatar_url":"https://avatars.githubusercontent.com/u/530981?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasvandoren","html_url":"https://github.com/thomasvandoren","followers_url":"https://api.github.com/users/thomasvandoren/followers","following_url":"https://api.github.com/users/thomasvandoren/following{/other_user}","gists_url":"https://api.github.com/users/thomasvandoren/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasvandoren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasvandoren/subscriptions","organizations_url":"https://api.github.com/users/thomasvandoren/orgs","repos_url":"https://api.github.com/users/thomasvandoren/repos","events_url":"https://api.github.com/users/thomasvandoren/events{/privacy}","received_events_url":"https://api.github.com/users/thomasvandoren/received_events","type":"User","site_admin":false},"repo":{"id":21669387,"name":"chapel","full_name":"thomasvandoren/chapel","owner":{"login":"thomasvandoren","id":530981,"avatar_url":"https://avatars.githubusercontent.com/u/530981?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasvandoren","html_url":"https://github.com/thomasvandoren","followers_url":"https://api.github.com/users/thomasvandoren/followers","following_url":"https://api.github.com/users/thomasvandoren/following{/other_user}","gists_url":"https://api.github.com/users/thomasvandoren/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasvandoren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasvandoren/subscriptions","organizations_url":"https://api.github.com/users/thomasvandoren/orgs","repos_url":"https://api.github.com/users/thomasvandoren/repos","events_url":"https://api.github.com/users/thomasvandoren/events{/privacy}","received_events_url":"https://api.github.com/users/thomasvandoren/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thomasvandoren/chapel","description":"a Productive Parallel Programming Language","fork":true,"url":"https://api.github.com/repos/thomasvandoren/chapel","forks_url":"https://api.github.com/repos/thomasvandoren/chapel/forks","keys_url":"https://api.github.com/repos/thomasvandoren/chapel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thomasvandoren/chapel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thomasvandoren/chapel/teams","hooks_url":"https://api.github.com/repos/thomasvandoren/chapel/hooks","issue_events_url":"https://api.github.com/repos/thomasvandoren/chapel/issues/events{/number}","events_url":"https://api.github.com/repos/thomasvandoren/chapel/events","assignees_url":"https://api.github.com/repos/thomasvandoren/chapel/assignees{/user}","branches_url":"https://api.github.com/repos/thomasvandoren/chapel/branches{/branch}","tags_url":"https://api.github.com/repos/thomasvandoren/chapel/tags","blobs_url":"https://api.github.com/repos/thomasvandoren/chapel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thomasvandoren/chapel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thomasvandoren/chapel/git/refs{/sha}","trees_url":"https://api.github.com/repos/thomasvandoren/chapel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thomasvandoren/chapel/statuses/{sha}","languages_url":"https://api.github.com/repos/thomasvandoren/chapel/languages","stargazers_url":"https://api.github.com/repos/thomasvandoren/chapel/stargazers","contributors_url":"https://api.github.com/repos/thomasvandoren/chapel/contributors","subscribers_url":"https://api.github.com/repos/thomasvandoren/chapel/subscribers","subscription_url":"https://api.github.com/repos/thomasvandoren/chapel/subscription","commits_url":"https://api.github.com/repos/thomasvandoren/chapel/commits{/sha}","git_commits_url":"https://api.github.com/repos/thomasvandoren/chapel/git/commits{/sha}","comments_url":"https://api.github.com/repos/thomasvandoren/chapel/comments{/number}","issue_comment_url":"https://api.github.com/repos/thomasvandoren/chapel/issues/comments{/number}","contents_url":"https://api.github.com/repos/thomasvandoren/chapel/contents/{+path}","compare_url":"https://api.github.com/repos/thomasvandoren/chapel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thomasvandoren/chapel/merges","archive_url":"https://api.github.com/repos/thomasvandoren/chapel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thomasvandoren/chapel/downloads","issues_url":"https://api.github.com/repos/thomasvandoren/chapel/issues{/number}","pulls_url":"https://api.github.com/repos/thomasvandoren/chapel/pulls{/number}","milestones_url":"https://api.github.com/repos/thomasvandoren/chapel/milestones{/number}","notifications_url":"https://api.github.com/repos/thomasvandoren/chapel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thomasvandoren/chapel/labels{/name}","releases_url":"https://api.github.com/repos/thomasvandoren/chapel/releases{/id}","created_at":"2014-07-09T21:14:48Z","updated_at":"2015-02-15T23:22:21Z","pushed_at":"2015-03-04T01:34:56Z","git_url":"git://github.com/thomasvandoren/chapel.git","ssh_url":"git@github.com:thomasvandoren/chapel.git","clone_url":"https://github.com/thomasvandoren/chapel.git","svn_url":"https://github.com/thomasvandoren/chapel","homepage":"http://chapel.cray.com/","size":274873,"stargazers_count":1,"watchers_count":1,"language":"Chapel","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"chapel-lang:master","ref":"master","sha":"36c934997a7a5097036edab0b5388defb0a53a53","user":{"login":"chapel-lang","id":7597261,"avatar_url":"https://avatars.githubusercontent.com/u/7597261?v=3","gravatar_id":"","url":"https://api.github.com/users/chapel-lang","html_url":"https://github.com/chapel-lang","followers_url":"https://api.github.com/users/chapel-lang/followers","following_url":"https://api.github.com/users/chapel-lang/following{/other_user}","gists_url":"https://api.github.com/users/chapel-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/chapel-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapel-lang/subscriptions","organizations_url":"https://api.github.com/users/chapel-lang/orgs","repos_url":"https://api.github.com/users/chapel-lang/repos","events_url":"https://api.github.com/users/chapel-lang/events{/privacy}","received_events_url":"https://api.github.com/users/chapel-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":21663285,"name":"chapel","full_name":"chapel-lang/chapel","owner":{"login":"chapel-lang","id":7597261,"avatar_url":"https://avatars.githubusercontent.com/u/7597261?v=3","gravatar_id":"","url":"https://api.github.com/users/chapel-lang","html_url":"https://github.com/chapel-lang","followers_url":"https://api.github.com/users/chapel-lang/followers","following_url":"https://api.github.com/users/chapel-lang/following{/other_user}","gists_url":"https://api.github.com/users/chapel-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/chapel-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapel-lang/subscriptions","organizations_url":"https://api.github.com/users/chapel-lang/orgs","repos_url":"https://api.github.com/users/chapel-lang/repos","events_url":"https://api.github.com/users/chapel-lang/events{/privacy}","received_events_url":"https://api.github.com/users/chapel-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chapel-lang/chapel","description":"a Productive Parallel Programming Language","fork":false,"url":"https://api.github.com/repos/chapel-lang/chapel","forks_url":"https://api.github.com/repos/chapel-lang/chapel/forks","keys_url":"https://api.github.com/repos/chapel-lang/chapel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chapel-lang/chapel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chapel-lang/chapel/teams","hooks_url":"https://api.github.com/repos/chapel-lang/chapel/hooks","issue_events_url":"https://api.github.com/repos/chapel-lang/chapel/issues/events{/number}","events_url":"https://api.github.com/repos/chapel-lang/chapel/events","assignees_url":"https://api.github.com/repos/chapel-lang/chapel/assignees{/user}","branches_url":"https://api.github.com/repos/chapel-lang/chapel/branches{/branch}","tags_url":"https://api.github.com/repos/chapel-lang/chapel/tags","blobs_url":"https://api.github.com/repos/chapel-lang/chapel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chapel-lang/chapel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chapel-lang/chapel/git/refs{/sha}","trees_url":"https://api.github.com/repos/chapel-lang/chapel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chapel-lang/chapel/statuses/{sha}","languages_url":"https://api.github.com/repos/chapel-lang/chapel/languages","stargazers_url":"https://api.github.com/repos/chapel-lang/chapel/stargazers","contributors_url":"https://api.github.com/repos/chapel-lang/chapel/contributors","subscribers_url":"https://api.github.com/repos/chapel-lang/chapel/subscribers","subscription_url":"https://api.github.com/repos/chapel-lang/chapel/subscription","commits_url":"https://api.github.com/repos/chapel-lang/chapel/commits{/sha}","git_commits_url":"https://api.github.com/repos/chapel-lang/chapel/git/commits{/sha}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/comments{/number}","issue_comment_url":"https://api.github.com/repos/chapel-lang/chapel/issues/comments{/number}","contents_url":"https://api.github.com/repos/chapel-lang/chapel/contents/{+path}","compare_url":"https://api.github.com/repos/chapel-lang/chapel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chapel-lang/chapel/merges","archive_url":"https://api.github.com/repos/chapel-lang/chapel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chapel-lang/chapel/downloads","issues_url":"https://api.github.com/repos/chapel-lang/chapel/issues{/number}","pulls_url":"https://api.github.com/repos/chapel-lang/chapel/pulls{/number}","milestones_url":"https://api.github.com/repos/chapel-lang/chapel/milestones{/number}","notifications_url":"https://api.github.com/repos/chapel-lang/chapel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chapel-lang/chapel/labels{/name}","releases_url":"https://api.github.com/repos/chapel-lang/chapel/releases{/id}","created_at":"2014-07-09T18:15:54Z","updated_at":"2015-03-04T14:42:50Z","pushed_at":"2015-03-04T14:42:50Z","git_url":"git://github.com/chapel-lang/chapel.git","ssh_url":"git@github.com:chapel-lang/chapel.git","clone_url":"https://github.com/chapel-lang/chapel.git","svn_url":"https://github.com/chapel-lang/chapel","homepage":"http://chapel.cray.com/","size":338620,"stargazers_count":72,"watchers_count":72,"language":"Chapel","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":8,"forks":39,"open_issues":8,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/1451"},"html":{"href":"https://github.com/chapel-lang/chapel/pull/1451"},"issue":{"href":"https://api.github.com/repos/chapel-lang/chapel/issues/1451"},"comments":{"href":"https://api.github.com/repos/chapel-lang/chapel/issues/1451/comments"},"review_comments":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/1451/comments"},"review_comment":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/1451/commits"},"statuses":{"href":"https://api.github.com/repos/chapel-lang/chapel/statuses/c915be61c07e799934e33625e8180fbbed275620"}}}}