{"action":"created","issue":{"url":"https://api.github.com/repos/untamed0/witcher3map/issues/53","labels_url":"https://api.github.com/repos/untamed0/witcher3map/issues/53/labels{/name}","comments_url":"https://api.github.com/repos/untamed0/witcher3map/issues/53/comments","events_url":"https://api.github.com/repos/untamed0/witcher3map/issues/53/events","html_url":"https://github.com/untamed0/witcher3map/pull/53","id":112483711,"number":53,"title":"Reworked witcher3map to use node","user":{"login":"mcarver","id":124755,"avatar_url":"https://avatars.githubusercontent.com/u/124755?v=3","gravatar_id":"","url":"https://api.github.com/users/mcarver","html_url":"https://github.com/mcarver","followers_url":"https://api.github.com/users/mcarver/followers","following_url":"https://api.github.com/users/mcarver/following{/other_user}","gists_url":"https://api.github.com/users/mcarver/gists{/gist_id}","starred_url":"https://api.github.com/users/mcarver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcarver/subscriptions","organizations_url":"https://api.github.com/users/mcarver/orgs","repos_url":"https://api.github.com/users/mcarver/repos","events_url":"https://api.github.com/users/mcarver/events{/privacy}","received_events_url":"https://api.github.com/users/mcarver/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-10-20T23:52:27Z","updated_at":"2015-10-21T22:56:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/untamed0/witcher3map/pulls/53","html_url":"https://github.com/untamed0/witcher3map/pull/53","diff_url":"https://github.com/untamed0/witcher3map/pull/53.diff","patch_url":"https://github.com/untamed0/witcher3map/pull/53.patch"},"body":"@untamed0,\r\n\r\nI reworked the entire witcher3map project to use node and npm for a build process.  You may want to check this out first and let me know what you think before merging.  There should be enough information in the README to get it working.  The witcher3map files would be outputted to the `dist/` folder if you don't want to use the express webserver I have packaged in the project.\r\n\r\nSome notable functionality:\r\n\r\n* uses npm to produce the actual project files (script, html, css)\r\n* runs jshint to reduce javascript errors\r\n* runs csslint to reduce css errors\r\n* runs htmllint to reduce html errors\r\n* concatenates vendor scripts (leaflet, nicescroll, i18next, etc) into a vendor.bundle.js so all vendor scripts only require 1 http request.\r\n* minifies css\r\n* `watch` targets to rebuild project everytime a file changes.\r\n* generates a sitemap using coords in the mapdata files.\r\n\r\nI know this is a pretty significant change so let me know your thoughts."},"comment":{"url":"https://api.github.com/repos/untamed0/witcher3map/issues/comments/150047589","html_url":"https://github.com/untamed0/witcher3map/pull/53#issuecomment-150047589","issue_url":"https://api.github.com/repos/untamed0/witcher3map/issues/53","id":150047589,"user":{"login":"untamed0","id":2314186,"avatar_url":"https://avatars.githubusercontent.com/u/2314186?v=3","gravatar_id":"","url":"https://api.github.com/users/untamed0","html_url":"https://github.com/untamed0","followers_url":"https://api.github.com/users/untamed0/followers","following_url":"https://api.github.com/users/untamed0/following{/other_user}","gists_url":"https://api.github.com/users/untamed0/gists{/gist_id}","starred_url":"https://api.github.com/users/untamed0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/untamed0/subscriptions","organizations_url":"https://api.github.com/users/untamed0/orgs","repos_url":"https://api.github.com/users/untamed0/repos","events_url":"https://api.github.com/users/untamed0/events{/privacy}","received_events_url":"https://api.github.com/users/untamed0/received_events","type":"User","site_admin":false},"created_at":"2015-10-21T22:56:53Z","updated_at":"2015-10-21T22:56:53Z","body":"Nice work, however I'd like to hear others thoughts on this, as it adds a barrier to those unfamiliar with node who wish to contribute, and also people who just want to use the map locally in their browser who maybe have no experience at all with CLI.\r\n\r\nPerhaps if we were to release the dist folder that would negate my latter concern? What are your thoughts?\r\n\r\nAlso what do you think about incorporating [JSCS](http://jscs.info/) in the build process?"}}