{"action":"created","comment":{"url":"https://api.github.com/repos/basho/yokozuna/pulls/comments/24717485","id":24717485,"diff_hunk":"@@ -460,3 +463,131 @@ is_owner_or_future_owner(P, Node, Ring) ->\n -spec is_service_up(atom(), node()) -> boolean().\n is_service_up(Service, Node) ->\n     lists:member(Service, riak_core_node_watcher:services(Node)).\n+\n+%% @private\n+%%\n+%% @doc Check if object has 2.0 CRDT datatype entry or property for\n+%%      strong consistency.\n+-spec is_datatype_or_consistent(obj()) -> boolean().\n+is_datatype_or_consistent(Obj) ->\n+    case riak_kv_crdt:value(Obj) of","path":"src/yz_kv.erl","position":52,"original_position":52,"commit_id":"f9e58835221ca28ede30a31ab49cb539848faf6c","original_commit_id":"f9e58835221ca28ede30a31ab49cb539848faf6c","user":{"login":"zeeshanlakhani","id":202820,"avatar_url":"https://avatars.githubusercontent.com/u/202820?v=3","gravatar_id":"","url":"https://api.github.com/users/zeeshanlakhani","html_url":"https://github.com/zeeshanlakhani","followers_url":"https://api.github.com/users/zeeshanlakhani/followers","following_url":"https://api.github.com/users/zeeshanlakhani/following{/other_user}","gists_url":"https://api.github.com/users/zeeshanlakhani/gists{/gist_id}","starred_url":"https://api.github.com/users/zeeshanlakhani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeeshanlakhani/subscriptions","organizations_url":"https://api.github.com/users/zeeshanlakhani/orgs","repos_url":"https://api.github.com/users/zeeshanlakhani/repos","events_url":"https://api.github.com/users/zeeshanlakhani/events{/privacy}","received_events_url":"https://api.github.com/users/zeeshanlakhani/received_events","type":"User","site_admin":false},"body":"Makes sense. Will do. \n\nZeeshan Lakhani\nprogrammer | \nsoftware engineer at @basho | \norg. member/founder of @papers_we_love |\ntwitter => @zeeshanlakhani\n\n> On Feb 14, 2015, at 3:50 PM, Sean Cribbs <notifications@github.com> wrote:\n> \n> In src/yz_kv.erl:\n> \n> > @@ -460,3 +463,131 @@ is_owner_or_future_owner(P, Node, Ring) ->\n> >  -spec is_service_up(atom(), node()) -> boolean().\n> >  is_service_up(Service, Node) ->\n> >      lists:member(Service, riak_core_node_watcher:services(Node)).\n> > +\n> > +%% @private\n> > +%%\n> > +%% @doc Check if object has 2.0 CRDT datatype entry or property for\n> > +%%      strong consistency.\n> > +-spec is_datatype_or_consistent(obj()) -> boolean().\n> > +is_datatype_or_consistent(Obj) ->\n> > +    case riak_kv_crdt:value(Obj) of\n> Similar to the is_strongly_consistent/1 below, you could check the bucket properties only to determine if it's a CRDT. Calling riak_kv_crdt:value/1 will perform a deserialization of the value, which is extra work if you are not intending to use the result.\n> \n> —\n> Reply to this email directly or view it on GitHub.\n> \n","created_at":"2015-02-14T21:27:42Z","updated_at":"2015-02-14T21:27:42Z","html_url":"https://github.com/basho/yokozuna/pull/452#discussion_r24717485","pull_request_url":"https://api.github.com/repos/basho/yokozuna/pulls/452","_links":{"self":{"href":"https://api.github.com/repos/basho/yokozuna/pulls/comments/24717485"},"html":{"href":"https://github.com/basho/yokozuna/pull/452#discussion_r24717485"},"pull_request":{"href":"https://api.github.com/repos/basho/yokozuna/pulls/452"}}},"pull_request":{"url":"https://api.github.com/repos/basho/yokozuna/pulls/452","id":29311136,"html_url":"https://github.com/basho/yokozuna/pull/452","diff_url":"https://github.com/basho/yokozuna/pull/452.diff","patch_url":"https://github.com/basho/yokozuna/pull/452.patch","issue_url":"https://api.github.com/repos/basho/yokozuna/issues/452","number":452,"state":"open","locked":false,"title":"Perf/zl/remove unnecessary delete to solr idx when crdt or sc","user":{"login":"zeeshanlakhani","id":202820,"avatar_url":"https://avatars.githubusercontent.com/u/202820?v=3","gravatar_id":"","url":"https://api.github.com/users/zeeshanlakhani","html_url":"https://github.com/zeeshanlakhani","followers_url":"https://api.github.com/users/zeeshanlakhani/followers","following_url":"https://api.github.com/users/zeeshanlakhani/following{/other_user}","gists_url":"https://api.github.com/users/zeeshanlakhani/gists{/gist_id}","starred_url":"https://api.github.com/users/zeeshanlakhani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeeshanlakhani/subscriptions","organizations_url":"https://api.github.com/users/zeeshanlakhani/orgs","repos_url":"https://api.github.com/users/zeeshanlakhani/repos","events_url":"https://api.github.com/users/zeeshanlakhani/events{/privacy}","received_events_url":"https://api.github.com/users/zeeshanlakhani/received_events","type":"User","site_admin":false},"body":"Fixes https://bashoeng.atlassian.net/browse/RIAK-1504. \r\n\r\nImproves performance by avoiding an extra delete operation to remove siblings through Solr on the put path when riak datatypes or strong consistency is used. Initial patch/issue was discovered by @drewkerrigan, https://github.com/basho-labs/yokozuna_perf_patch.","created_at":"2015-02-14T00:37:46Z","updated_at":"2015-02-14T21:27:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a2579c1c05bd6c0b4e35f7b65a0126898b6cdc8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/basho/yokozuna/pulls/452/commits","review_comments_url":"https://api.github.com/repos/basho/yokozuna/pulls/452/comments","review_comment_url":"https://api.github.com/repos/basho/yokozuna/pulls/comments/{number}","comments_url":"https://api.github.com/repos/basho/yokozuna/issues/452/comments","statuses_url":"https://api.github.com/repos/basho/yokozuna/statuses/f9e58835221ca28ede30a31ab49cb539848faf6c","head":{"label":"basho:perf/zl/remove-unnecessary-delete-to-solr-idx-when-crdt-or-sc","ref":"perf/zl/remove-unnecessary-delete-to-solr-idx-when-crdt-or-sc","sha":"f9e58835221ca28ede30a31ab49cb539848faf6c","user":{"login":"basho","id":176293,"avatar_url":"https://avatars.githubusercontent.com/u/176293?v=3","gravatar_id":"","url":"https://api.github.com/users/basho","html_url":"https://github.com/basho","followers_url":"https://api.github.com/users/basho/followers","following_url":"https://api.github.com/users/basho/following{/other_user}","gists_url":"https://api.github.com/users/basho/gists{/gist_id}","starred_url":"https://api.github.com/users/basho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho/subscriptions","organizations_url":"https://api.github.com/users/basho/orgs","repos_url":"https://api.github.com/users/basho/repos","events_url":"https://api.github.com/users/basho/events{/privacy}","received_events_url":"https://api.github.com/users/basho/received_events","type":"Organization","site_admin":false},"repo":{"id":4709255,"name":"yokozuna","full_name":"basho/yokozuna","owner":{"login":"basho","id":176293,"avatar_url":"https://avatars.githubusercontent.com/u/176293?v=3","gravatar_id":"","url":"https://api.github.com/users/basho","html_url":"https://github.com/basho","followers_url":"https://api.github.com/users/basho/followers","following_url":"https://api.github.com/users/basho/following{/other_user}","gists_url":"https://api.github.com/users/basho/gists{/gist_id}","starred_url":"https://api.github.com/users/basho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho/subscriptions","organizations_url":"https://api.github.com/users/basho/orgs","repos_url":"https://api.github.com/users/basho/repos","events_url":"https://api.github.com/users/basho/events{/privacy}","received_events_url":"https://api.github.com/users/basho/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/basho/yokozuna","description":"Riak + Solr","fork":false,"url":"https://api.github.com/repos/basho/yokozuna","forks_url":"https://api.github.com/repos/basho/yokozuna/forks","keys_url":"https://api.github.com/repos/basho/yokozuna/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basho/yokozuna/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basho/yokozuna/teams","hooks_url":"https://api.github.com/repos/basho/yokozuna/hooks","issue_events_url":"https://api.github.com/repos/basho/yokozuna/issues/events{/number}","events_url":"https://api.github.com/repos/basho/yokozuna/events","assignees_url":"https://api.github.com/repos/basho/yokozuna/assignees{/user}","branches_url":"https://api.github.com/repos/basho/yokozuna/branches{/branch}","tags_url":"https://api.github.com/repos/basho/yokozuna/tags","blobs_url":"https://api.github.com/repos/basho/yokozuna/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basho/yokozuna/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basho/yokozuna/git/refs{/sha}","trees_url":"https://api.github.com/repos/basho/yokozuna/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basho/yokozuna/statuses/{sha}","languages_url":"https://api.github.com/repos/basho/yokozuna/languages","stargazers_url":"https://api.github.com/repos/basho/yokozuna/stargazers","contributors_url":"https://api.github.com/repos/basho/yokozuna/contributors","subscribers_url":"https://api.github.com/repos/basho/yokozuna/subscribers","subscription_url":"https://api.github.com/repos/basho/yokozuna/subscription","commits_url":"https://api.github.com/repos/basho/yokozuna/commits{/sha}","git_commits_url":"https://api.github.com/repos/basho/yokozuna/git/commits{/sha}","comments_url":"https://api.github.com/repos/basho/yokozuna/comments{/number}","issue_comment_url":"https://api.github.com/repos/basho/yokozuna/issues/comments/{number}","contents_url":"https://api.github.com/repos/basho/yokozuna/contents/{+path}","compare_url":"https://api.github.com/repos/basho/yokozuna/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basho/yokozuna/merges","archive_url":"https://api.github.com/repos/basho/yokozuna/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basho/yokozuna/downloads","issues_url":"https://api.github.com/repos/basho/yokozuna/issues{/number}","pulls_url":"https://api.github.com/repos/basho/yokozuna/pulls{/number}","milestones_url":"https://api.github.com/repos/basho/yokozuna/milestones{/number}","notifications_url":"https://api.github.com/repos/basho/yokozuna/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basho/yokozuna/labels{/name}","releases_url":"https://api.github.com/repos/basho/yokozuna/releases{/id}","created_at":"2012-06-19T04:02:24Z","updated_at":"2015-02-10T15:39:13Z","pushed_at":"2015-02-14T00:25:35Z","git_url":"git://github.com/basho/yokozuna.git","ssh_url":"git@github.com:basho/yokozuna.git","clone_url":"https://github.com/basho/yokozuna.git","svn_url":"https://github.com/basho/yokozuna","homepage":"","size":7007,"stargazers_count":190,"watchers_count":190,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":55,"forks":35,"open_issues":55,"watchers":190,"default_branch":"develop"}},"base":{"label":"basho:develop","ref":"develop","sha":"40d2f82434afffc2078e0b247ce0d70c452168b3","user":{"login":"basho","id":176293,"avatar_url":"https://avatars.githubusercontent.com/u/176293?v=3","gravatar_id":"","url":"https://api.github.com/users/basho","html_url":"https://github.com/basho","followers_url":"https://api.github.com/users/basho/followers","following_url":"https://api.github.com/users/basho/following{/other_user}","gists_url":"https://api.github.com/users/basho/gists{/gist_id}","starred_url":"https://api.github.com/users/basho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho/subscriptions","organizations_url":"https://api.github.com/users/basho/orgs","repos_url":"https://api.github.com/users/basho/repos","events_url":"https://api.github.com/users/basho/events{/privacy}","received_events_url":"https://api.github.com/users/basho/received_events","type":"Organization","site_admin":false},"repo":{"id":4709255,"name":"yokozuna","full_name":"basho/yokozuna","owner":{"login":"basho","id":176293,"avatar_url":"https://avatars.githubusercontent.com/u/176293?v=3","gravatar_id":"","url":"https://api.github.com/users/basho","html_url":"https://github.com/basho","followers_url":"https://api.github.com/users/basho/followers","following_url":"https://api.github.com/users/basho/following{/other_user}","gists_url":"https://api.github.com/users/basho/gists{/gist_id}","starred_url":"https://api.github.com/users/basho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho/subscriptions","organizations_url":"https://api.github.com/users/basho/orgs","repos_url":"https://api.github.com/users/basho/repos","events_url":"https://api.github.com/users/basho/events{/privacy}","received_events_url":"https://api.github.com/users/basho/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/basho/yokozuna","description":"Riak + Solr","fork":false,"url":"https://api.github.com/repos/basho/yokozuna","forks_url":"https://api.github.com/repos/basho/yokozuna/forks","keys_url":"https://api.github.com/repos/basho/yokozuna/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basho/yokozuna/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basho/yokozuna/teams","hooks_url":"https://api.github.com/repos/basho/yokozuna/hooks","issue_events_url":"https://api.github.com/repos/basho/yokozuna/issues/events{/number}","events_url":"https://api.github.com/repos/basho/yokozuna/events","assignees_url":"https://api.github.com/repos/basho/yokozuna/assignees{/user}","branches_url":"https://api.github.com/repos/basho/yokozuna/branches{/branch}","tags_url":"https://api.github.com/repos/basho/yokozuna/tags","blobs_url":"https://api.github.com/repos/basho/yokozuna/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basho/yokozuna/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basho/yokozuna/git/refs{/sha}","trees_url":"https://api.github.com/repos/basho/yokozuna/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basho/yokozuna/statuses/{sha}","languages_url":"https://api.github.com/repos/basho/yokozuna/languages","stargazers_url":"https://api.github.com/repos/basho/yokozuna/stargazers","contributors_url":"https://api.github.com/repos/basho/yokozuna/contributors","subscribers_url":"https://api.github.com/repos/basho/yokozuna/subscribers","subscription_url":"https://api.github.com/repos/basho/yokozuna/subscription","commits_url":"https://api.github.com/repos/basho/yokozuna/commits{/sha}","git_commits_url":"https://api.github.com/repos/basho/yokozuna/git/commits{/sha}","comments_url":"https://api.github.com/repos/basho/yokozuna/comments{/number}","issue_comment_url":"https://api.github.com/repos/basho/yokozuna/issues/comments/{number}","contents_url":"https://api.github.com/repos/basho/yokozuna/contents/{+path}","compare_url":"https://api.github.com/repos/basho/yokozuna/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basho/yokozuna/merges","archive_url":"https://api.github.com/repos/basho/yokozuna/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basho/yokozuna/downloads","issues_url":"https://api.github.com/repos/basho/yokozuna/issues{/number}","pulls_url":"https://api.github.com/repos/basho/yokozuna/pulls{/number}","milestones_url":"https://api.github.com/repos/basho/yokozuna/milestones{/number}","notifications_url":"https://api.github.com/repos/basho/yokozuna/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basho/yokozuna/labels{/name}","releases_url":"https://api.github.com/repos/basho/yokozuna/releases{/id}","created_at":"2012-06-19T04:02:24Z","updated_at":"2015-02-10T15:39:13Z","pushed_at":"2015-02-14T00:25:35Z","git_url":"git://github.com/basho/yokozuna.git","ssh_url":"git@github.com:basho/yokozuna.git","clone_url":"https://github.com/basho/yokozuna.git","svn_url":"https://github.com/basho/yokozuna","homepage":"","size":7007,"stargazers_count":190,"watchers_count":190,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":55,"forks":35,"open_issues":55,"watchers":190,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/basho/yokozuna/pulls/452"},"html":{"href":"https://github.com/basho/yokozuna/pull/452"},"issue":{"href":"https://api.github.com/repos/basho/yokozuna/issues/452"},"comments":{"href":"https://api.github.com/repos/basho/yokozuna/issues/452/comments"},"review_comments":{"href":"https://api.github.com/repos/basho/yokozuna/pulls/452/comments"},"review_comment":{"href":"https://api.github.com/repos/basho/yokozuna/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/basho/yokozuna/pulls/452/commits"},"statuses":{"href":"https://api.github.com/repos/basho/yokozuna/statuses/f9e58835221ca28ede30a31ab49cb539848faf6c"}}}}