{"action":"created","comment":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/36075485","id":36075485,"diff_hunk":"@@ -51,7 +51,8 @@ struct FreeFormulaImpl : public T_ParamClass\n      */\n     HDINLINE float_X operator()(const DataSpace<simDim>& totalCellOffset)\n     {\n-        const floatD_64 cellSize_SI( precisionCast<float_64>(cellSize) * UNIT_LENGTH );\n+        const float_64 unitLength = UNIT_LENGTH; // workaround to use UNIT_LENGTH on device ","path":"src/picongpu/include/particles/gasProfiles/FreeFormulaImpl.hpp","position":5,"original_position":5,"commit_id":"46b475684f10dc27383d1b2baf16d38370f680c2","original_commit_id":"46b475684f10dc27383d1b2baf16d38370f680c2","user":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"body":"one thing is, that it generally uses the constructor instead of an \"=\" which is an assignment. an other point is, if you look at the lines above and below, than a patch should generally fit the style of the surrounding code (a patch should not be visible after it is applied).","created_at":"2015-08-03T11:12:35Z","updated_at":"2015-08-03T11:12:35Z","html_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/988#discussion_r36075485","pull_request_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/988","_links":{"self":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/36075485"},"html":{"href":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/988#discussion_r36075485"},"pull_request":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/988"}}},"pull_request":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/988","id":41321670,"html_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/988","diff_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/988.diff","patch_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/988.patch","issue_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/988","number":988,"state":"open","locked":false,"title":"fix gas free formular remaining errors ","user":{"login":"PrometheusPi","id":5121158,"avatar_url":"https://avatars.githubusercontent.com/u/5121158?v=3","gravatar_id":"","url":"https://api.github.com/users/PrometheusPi","html_url":"https://github.com/PrometheusPi","followers_url":"https://api.github.com/users/PrometheusPi/followers","following_url":"https://api.github.com/users/PrometheusPi/following{/other_user}","gists_url":"https://api.github.com/users/PrometheusPi/gists{/gist_id}","starred_url":"https://api.github.com/users/PrometheusPi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrometheusPi/subscriptions","organizations_url":"https://api.github.com/users/PrometheusPi/orgs","repos_url":"https://api.github.com/users/PrometheusPi/repos","events_url":"https://api.github.com/users/PrometheusPi/events{/privacy}","received_events_url":"https://api.github.com/users/PrometheusPi/received_events","type":"User","site_admin":false},"body":"This fixes a remnant template I oversaw in #976 :flushed: and an additional error caused by a nvcc bug while using const variables on the device.\r\n\r\n@ComputationalRadiationPhysics/picongpu-maintainers \r\nAs discussed offline with @ax3l, we need to add a test for free formular in the examples to verify the GasFreeFormular with the compile test.","created_at":"2015-07-31T09:22:26Z","updated_at":"2015-08-03T11:12:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a97d27b5a3b1d5b715d47d9752dfff39f6a2620a","assignee":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones/2","html_url":"https://github.com/ComputationalRadiationPhysics/picongpu/milestones/Open%20Beta","labels_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones/2/labels","id":395839,"number":2,"title":"Open Beta","description":"Tasks to complete until the release of our open beta (version 0.1)\r\n\r\nThe [beta](https://en.wikipedia.org/wiki/Software_release_life_cycle#Beta) release shall be useful for *physicist* that used a Particle-in-Cell code *before*. Experience with *compiling libraries from source* and a *good Linux knowledge* is required for the initial installation.\r\n","creator":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"open_issues":106,"closed_issues":804,"state":"open","created_at":"2013-08-06T16:38:57Z","updated_at":"2015-08-03T11:05:12Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/988/commits","review_comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/988/comments","review_comment_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/988/comments","statuses_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/46b475684f10dc27383d1b2baf16d38370f680c2","head":{"label":"PrometheusPi:fix-GasFreeFormular2","ref":"fix-GasFreeFormular2","sha":"46b475684f10dc27383d1b2baf16d38370f680c2","user":{"login":"PrometheusPi","id":5121158,"avatar_url":"https://avatars.githubusercontent.com/u/5121158?v=3","gravatar_id":"","url":"https://api.github.com/users/PrometheusPi","html_url":"https://github.com/PrometheusPi","followers_url":"https://api.github.com/users/PrometheusPi/followers","following_url":"https://api.github.com/users/PrometheusPi/following{/other_user}","gists_url":"https://api.github.com/users/PrometheusPi/gists{/gist_id}","starred_url":"https://api.github.com/users/PrometheusPi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrometheusPi/subscriptions","organizations_url":"https://api.github.com/users/PrometheusPi/orgs","repos_url":"https://api.github.com/users/PrometheusPi/repos","events_url":"https://api.github.com/users/PrometheusPi/events{/privacy}","received_events_url":"https://api.github.com/users/PrometheusPi/received_events","type":"User","site_admin":false},"repo":{"id":12809053,"name":"picongpu","full_name":"PrometheusPi/picongpu","owner":{"login":"PrometheusPi","id":5121158,"avatar_url":"https://avatars.githubusercontent.com/u/5121158?v=3","gravatar_id":"","url":"https://api.github.com/users/PrometheusPi","html_url":"https://github.com/PrometheusPi","followers_url":"https://api.github.com/users/PrometheusPi/followers","following_url":"https://api.github.com/users/PrometheusPi/following{/other_user}","gists_url":"https://api.github.com/users/PrometheusPi/gists{/gist_id}","starred_url":"https://api.github.com/users/PrometheusPi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrometheusPi/subscriptions","organizations_url":"https://api.github.com/users/PrometheusPi/orgs","repos_url":"https://api.github.com/users/PrometheusPi/repos","events_url":"https://api.github.com/users/PrometheusPi/events{/privacy}","received_events_url":"https://api.github.com/users/PrometheusPi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PrometheusPi/picongpu","description":"PIConGPU - A particle-in-cell code for GPGPUs","fork":true,"url":"https://api.github.com/repos/PrometheusPi/picongpu","forks_url":"https://api.github.com/repos/PrometheusPi/picongpu/forks","keys_url":"https://api.github.com/repos/PrometheusPi/picongpu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrometheusPi/picongpu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrometheusPi/picongpu/teams","hooks_url":"https://api.github.com/repos/PrometheusPi/picongpu/hooks","issue_events_url":"https://api.github.com/repos/PrometheusPi/picongpu/issues/events{/number}","events_url":"https://api.github.com/repos/PrometheusPi/picongpu/events","assignees_url":"https://api.github.com/repos/PrometheusPi/picongpu/assignees{/user}","branches_url":"https://api.github.com/repos/PrometheusPi/picongpu/branches{/branch}","tags_url":"https://api.github.com/repos/PrometheusPi/picongpu/tags","blobs_url":"https://api.github.com/repos/PrometheusPi/picongpu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrometheusPi/picongpu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrometheusPi/picongpu/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrometheusPi/picongpu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrometheusPi/picongpu/statuses/{sha}","languages_url":"https://api.github.com/repos/PrometheusPi/picongpu/languages","stargazers_url":"https://api.github.com/repos/PrometheusPi/picongpu/stargazers","contributors_url":"https://api.github.com/repos/PrometheusPi/picongpu/contributors","subscribers_url":"https://api.github.com/repos/PrometheusPi/picongpu/subscribers","subscription_url":"https://api.github.com/repos/PrometheusPi/picongpu/subscription","commits_url":"https://api.github.com/repos/PrometheusPi/picongpu/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrometheusPi/picongpu/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrometheusPi/picongpu/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrometheusPi/picongpu/issues/comments{/number}","contents_url":"https://api.github.com/repos/PrometheusPi/picongpu/contents/{+path}","compare_url":"https://api.github.com/repos/PrometheusPi/picongpu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrometheusPi/picongpu/merges","archive_url":"https://api.github.com/repos/PrometheusPi/picongpu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrometheusPi/picongpu/downloads","issues_url":"https://api.github.com/repos/PrometheusPi/picongpu/issues{/number}","pulls_url":"https://api.github.com/repos/PrometheusPi/picongpu/pulls{/number}","milestones_url":"https://api.github.com/repos/PrometheusPi/picongpu/milestones{/number}","notifications_url":"https://api.github.com/repos/PrometheusPi/picongpu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrometheusPi/picongpu/labels{/name}","releases_url":"https://api.github.com/repos/PrometheusPi/picongpu/releases{/id}","created_at":"2013-09-13T12:32:47Z","updated_at":"2015-06-02T12:02:47Z","pushed_at":"2015-07-31T09:14:46Z","git_url":"git://github.com/PrometheusPi/picongpu.git","ssh_url":"git@github.com:PrometheusPi/picongpu.git","clone_url":"https://github.com/PrometheusPi/picongpu.git","svn_url":"https://github.com/PrometheusPi/picongpu","homepage":"http://picongpu.hzdr.de","size":10302,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ComputationalRadiationPhysics:dev","ref":"dev","sha":"a966e9330e0dec00ee957f2c6226d2ee84d34a7f","user":{"login":"ComputationalRadiationPhysics","id":5120388,"avatar_url":"https://avatars.githubusercontent.com/u/5120388?v=3","gravatar_id":"","url":"https://api.github.com/users/ComputationalRadiationPhysics","html_url":"https://github.com/ComputationalRadiationPhysics","followers_url":"https://api.github.com/users/ComputationalRadiationPhysics/followers","following_url":"https://api.github.com/users/ComputationalRadiationPhysics/following{/other_user}","gists_url":"https://api.github.com/users/ComputationalRadiationPhysics/gists{/gist_id}","starred_url":"https://api.github.com/users/ComputationalRadiationPhysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ComputationalRadiationPhysics/subscriptions","organizations_url":"https://api.github.com/users/ComputationalRadiationPhysics/orgs","repos_url":"https://api.github.com/users/ComputationalRadiationPhysics/repos","events_url":"https://api.github.com/users/ComputationalRadiationPhysics/events{/privacy}","received_events_url":"https://api.github.com/users/ComputationalRadiationPhysics/received_events","type":"Organization","site_admin":false},"repo":{"id":11764461,"name":"picongpu","full_name":"ComputationalRadiationPhysics/picongpu","owner":{"login":"ComputationalRadiationPhysics","id":5120388,"avatar_url":"https://avatars.githubusercontent.com/u/5120388?v=3","gravatar_id":"","url":"https://api.github.com/users/ComputationalRadiationPhysics","html_url":"https://github.com/ComputationalRadiationPhysics","followers_url":"https://api.github.com/users/ComputationalRadiationPhysics/followers","following_url":"https://api.github.com/users/ComputationalRadiationPhysics/following{/other_user}","gists_url":"https://api.github.com/users/ComputationalRadiationPhysics/gists{/gist_id}","starred_url":"https://api.github.com/users/ComputationalRadiationPhysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ComputationalRadiationPhysics/subscriptions","organizations_url":"https://api.github.com/users/ComputationalRadiationPhysics/orgs","repos_url":"https://api.github.com/users/ComputationalRadiationPhysics/repos","events_url":"https://api.github.com/users/ComputationalRadiationPhysics/events{/privacy}","received_events_url":"https://api.github.com/users/ComputationalRadiationPhysics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ComputationalRadiationPhysics/picongpu","description":"PIConGPU - A particle-in-cell code for GPGPUs","fork":false,"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu","forks_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/forks","keys_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/teams","hooks_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/hooks","issue_events_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/events{/number}","events_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/events","assignees_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/assignees{/user}","branches_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/branches{/branch}","tags_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/tags","blobs_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/refs{/sha}","trees_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/{sha}","languages_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/languages","stargazers_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/stargazers","contributors_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/contributors","subscribers_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/subscribers","subscription_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/subscription","commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/commits{/sha}","git_commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/commits{/sha}","comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/comments{/number}","issue_comment_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/comments{/number}","contents_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/contents/{+path}","compare_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/merges","archive_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/downloads","issues_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues{/number}","pulls_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls{/number}","milestones_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones{/number}","notifications_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/labels{/name}","releases_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/releases{/id}","created_at":"2013-07-30T12:28:20Z","updated_at":"2015-07-30T04:57:28Z","pushed_at":"2015-08-03T11:12:33Z","git_url":"git://github.com/ComputationalRadiationPhysics/picongpu.git","ssh_url":"git@github.com:ComputationalRadiationPhysics/picongpu.git","clone_url":"https://github.com/ComputationalRadiationPhysics/picongpu.git","svn_url":"https://github.com/ComputationalRadiationPhysics/picongpu","homepage":"http://picongpu.hzdr.de","size":16337,"stargazers_count":120,"watchers_count":120,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":159,"forks":66,"open_issues":159,"watchers":120,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/988"},"html":{"href":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/988"},"issue":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/988"},"comments":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/988/comments"},"review_comments":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/988/comments"},"review_comment":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/988/commits"},"statuses":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/46b475684f10dc27383d1b2baf16d38370f680c2"}}}}