{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/12888","labels_url":"https://api.github.com/repos/owncloud/core/issues/12888/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/12888/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/12888/events","html_url":"https://github.com/owncloud/core/issues/12888","id":52151591,"number":12888,"title":"Remove incognito mode","user":{"login":"LukasReschke","id":878997,"avatar_url":"https://avatars.githubusercontent.com/u/878997?v=3","gravatar_id":"","url":"https://api.github.com/users/LukasReschke","html_url":"https://github.com/LukasReschke","followers_url":"https://api.github.com/users/LukasReschke/followers","following_url":"https://api.github.com/users/LukasReschke/following{/other_user}","gists_url":"https://api.github.com/users/LukasReschke/gists{/gist_id}","starred_url":"https://api.github.com/users/LukasReschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukasReschke/subscriptions","organizations_url":"https://api.github.com/users/LukasReschke/orgs","repos_url":"https://api.github.com/users/LukasReschke/repos","events_url":"https://api.github.com/users/LukasReschke/events{/privacy}","received_events_url":"https://api.github.com/users/LukasReschke/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/owncloud/core/labels/dev:ocp","name":"dev:ocp","color":"FF9966"},{"url":"https://api.github.com/repos/owncloud/core/labels/technical%20debt","name":"technical debt","color":"FFFF00"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/37","html_url":"https://github.com/owncloud/core/milestones/8.2-current","labels_url":"https://api.github.com/repos/owncloud/core/milestones/37/labels","id":993629,"number":37,"title":"8.2-current","description":"","creator":{"login":"craigpg","id":160667,"avatar_url":"https://avatars.githubusercontent.com/u/160667?v=3","gravatar_id":"","url":"https://api.github.com/users/craigpg","html_url":"https://github.com/craigpg","followers_url":"https://api.github.com/users/craigpg/followers","following_url":"https://api.github.com/users/craigpg/following{/other_user}","gists_url":"https://api.github.com/users/craigpg/gists{/gist_id}","starred_url":"https://api.github.com/users/craigpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigpg/subscriptions","organizations_url":"https://api.github.com/users/craigpg/orgs","repos_url":"https://api.github.com/users/craigpg/repos","events_url":"https://api.github.com/users/craigpg/events{/privacy}","received_events_url":"https://api.github.com/users/craigpg/received_events","type":"User","site_admin":false},"open_issues":299,"closed_issues":866,"state":"open","created_at":"2015-02-24T16:19:37Z","updated_at":"2015-09-22T13:48:36Z","due_on":"2015-10-20T04:00:00Z","closed_at":null},"comments":30,"created_at":"2014-12-16T18:50:31Z","updated_at":"2015-09-22T13:50:49Z","closed_at":null,"body":"The incognito mode has been introduced with https://github.com/owncloud/core/pull/6003 apparently for https://github.com/owncloud/core/pull/5976 to fix encryption for public shares.\r\n\r\nThe mode is implemented using a singleton and complete static in the legacy class `OC_User`. A better solution would be to implement encryption differently instead of relying of some pretty obscure and undocumented functionality. Nobody I asked even understood what this is for, if the function cannot be removed then we should at least migrate it to `IUserSession` and document properly what this function is even for. \r\n\r\n@schiesbn Can you confirm? - If so I'd try to come up with a PR that solves this problem otherwise."},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/142294919","html_url":"https://github.com/owncloud/core/issues/12888#issuecomment-142294919","issue_url":"https://api.github.com/repos/owncloud/core/issues/12888","id":142294919,"user":{"login":"karlitschek","id":867445,"avatar_url":"https://avatars.githubusercontent.com/u/867445?v=3","gravatar_id":"","url":"https://api.github.com/users/karlitschek","html_url":"https://github.com/karlitschek","followers_url":"https://api.github.com/users/karlitschek/followers","following_url":"https://api.github.com/users/karlitschek/following{/other_user}","gists_url":"https://api.github.com/users/karlitschek/gists{/gist_id}","starred_url":"https://api.github.com/users/karlitschek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karlitschek/subscriptions","organizations_url":"https://api.github.com/users/karlitschek/orgs","repos_url":"https://api.github.com/users/karlitschek/repos","events_url":"https://api.github.com/users/karlitschek/events{/privacy}","received_events_url":"https://api.github.com/users/karlitschek/received_events","type":"User","site_admin":false},"created_at":"2015-09-22T13:50:49Z","updated_at":"2015-09-22T13:50:49Z","body":"What doesn't work? Which sharing behavior is broken? "}}