{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaLang/julia/issues/8781","labels_url":"https://api.github.com/repos/JuliaLang/julia/issues/8781/labels{/name}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/8781/comments","events_url":"https://api.github.com/repos/JuliaLang/julia/issues/8781/events","html_url":"https://github.com/JuliaLang/julia/pull/8781","id":46599649,"number":8781,"title":"WIP: Code coverage reports for base","user":{"login":"ninjin","id":354934,"avatar_url":"https://avatars.githubusercontent.com/u/354934?v=3","gravatar_id":"","url":"https://api.github.com/users/ninjin","html_url":"https://github.com/ninjin","followers_url":"https://api.github.com/users/ninjin/followers","following_url":"https://api.github.com/users/ninjin/following{/other_user}","gists_url":"https://api.github.com/users/ninjin/gists{/gist_id}","starred_url":"https://api.github.com/users/ninjin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninjin/subscriptions","organizations_url":"https://api.github.com/users/ninjin/orgs","repos_url":"https://api.github.com/users/ninjin/repos","events_url":"https://api.github.com/users/ninjin/events{/privacy}","received_events_url":"https://api.github.com/users/ninjin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":19,"created_at":"2014-10-23T08:22:04Z","updated_at":"2015-02-04T20:16:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/8781","html_url":"https://github.com/JuliaLang/julia/pull/8781","diff_url":"https://github.com/JuliaLang/julia/pull/8781.diff","patch_url":"https://github.com/JuliaLang/julia/pull/8781.patch"},"body":"A long time ago I noticed [a comment by simonster about code coverage in base](https://github.com/JuliaLang/julia/issues/7095#issuecomment-44986625) and finally took a stab at it.  Little did I know that I ended up with almost exactly [what timholy hacked together several moons ago](https://github.com/JuliaLang/julia/commit/15c9ef3b5a4ddcce91b64d2464b9de9ff9c1d517).\r\n\r\nI put the coverage as a separate entry in the build matrix on Travis and explicitly allow for it to fail in order not to slow down the Travis reports.  As a consequence of this we will only run coverage on Linux, but I suspect that this does not matter.\r\n\r\nHowever, there are several issues to consider before merging something like this (thus the WIP).\r\n\r\n1. Do we really want Coveralls notifications for all pull requests?\r\n2. Is the current quality of the coverage reports good enough?\r\n\r\nFor 1., if it is not possible to disable them on the Coveralls dashboard I can tuck the coverage code and Coveralls submission as optional make targets that can be run upon request rather than on Travis.  As for 2., I hope that someone else has more insights into exactly what the current shortcomings of the coverage code is.\r\n\r\nAnother note on the WIP status, I am yet to fire off the script onto Travis and may push to this branch shortly if I messed something up."},"comment":{"url":"https://api.github.com/repos/JuliaLang/julia/issues/comments/72930112","html_url":"https://github.com/JuliaLang/julia/pull/8781#issuecomment-72930112","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/8781","id":72930112,"user":{"login":"hayd","id":1931852,"avatar_url":"https://avatars.githubusercontent.com/u/1931852?v=3","gravatar_id":"","url":"https://api.github.com/users/hayd","html_url":"https://github.com/hayd","followers_url":"https://api.github.com/users/hayd/followers","following_url":"https://api.github.com/users/hayd/following{/other_user}","gists_url":"https://api.github.com/users/hayd/gists{/gist_id}","starred_url":"https://api.github.com/users/hayd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hayd/subscriptions","organizations_url":"https://api.github.com/users/hayd/orgs","repos_url":"https://api.github.com/users/hayd/repos","events_url":"https://api.github.com/users/hayd/events{/privacy}","received_events_url":"https://api.github.com/users/hayd/received_events","type":"User","site_admin":false},"created_at":"2015-02-04T20:16:01Z","updated_at":"2015-02-04T20:16:01Z","body":"Having the badge on the README would be nice (I can never get these to work):\r\n \r\n[![Coverage Status](https://coveralls.io/repos/timholy/julia/badge.svg)](https://coveralls.io/r/timholy/julia)\r\n\r\n(but perhaps you want to wait til it's \"more respectable\" :p)"}}