{"action":"created","comment":{"url":"https://api.github.com/repos/cfengine/core/pulls/comments/40411823","id":40411823,"diff_hunk":"@@ -201,7 +201,7 @@ PromiseResult VerifyPackagesPromise(EvalContext *ctx, const Promise *pp)\n             break;\n         case PACKAGE_PROMISE_TYPE_OLD:\n             Log(LOG_LEVEL_VERBOSE,\n-                \"Using old package promise. Please note that this will be obsolete in 3.8\");\n+                \"Using old package promise. Please note that the old implementation is considered obsolete as of 3.8. The old implementation will continue to work, but forward development will be directed toward the new implementation.\");","path":"cf-agent/verify_packages.c","position":5,"original_position":5,"commit_id":"bf76b2c5624259f044c2b75eaf42dcbea8ac8e88","original_commit_id":"bf76b2c5624259f044c2b75eaf42dcbea8ac8e88","user":{"login":"kacfengine","id":4037094,"avatar_url":"https://avatars.githubusercontent.com/u/4037094?v=3","gravatar_id":"","url":"https://api.github.com/users/kacfengine","html_url":"https://github.com/kacfengine","followers_url":"https://api.github.com/users/kacfengine/followers","following_url":"https://api.github.com/users/kacfengine/following{/other_user}","gists_url":"https://api.github.com/users/kacfengine/gists{/gist_id}","starred_url":"https://api.github.com/users/kacfengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kacfengine/subscriptions","organizations_url":"https://api.github.com/users/kacfengine/orgs","repos_url":"https://api.github.com/users/kacfengine/repos","events_url":"https://api.github.com/users/kacfengine/events{/privacy}","received_events_url":"https://api.github.com/users/kacfengine/received_events","type":"User","site_admin":false},"body":"OTOH, the number of unsupported package managers by the new package promise does make a convincing case to keep it around a bit longer. Maybe disregard my comment for now. We should make it clear once we have a deprecation path though.","created_at":"2015-09-25T09:05:58Z","updated_at":"2015-09-25T09:05:58Z","html_url":"https://github.com/cfengine/core/pull/2330#discussion_r40411823","pull_request_url":"https://api.github.com/repos/cfengine/core/pulls/2330","_links":{"self":{"href":"https://api.github.com/repos/cfengine/core/pulls/comments/40411823"},"html":{"href":"https://github.com/cfengine/core/pull/2330#discussion_r40411823"},"pull_request":{"href":"https://api.github.com/repos/cfengine/core/pulls/2330"}}},"pull_request":{"url":"https://api.github.com/repos/cfengine/core/pulls/2330","id":45927550,"html_url":"https://github.com/cfengine/core/pull/2330","diff_url":"https://github.com/cfengine/core/pull/2330.diff","patch_url":"https://github.com/cfengine/core/pull/2330.patch","issue_url":"https://api.github.com/repos/cfengine/core/issues/2330","number":2330,"state":"open","locked":false,"title":"Change: Soften obsoletion message for old package promises","user":{"login":"nickanderson","id":202896,"avatar_url":"https://avatars.githubusercontent.com/u/202896?v=3","gravatar_id":"","url":"https://api.github.com/users/nickanderson","html_url":"https://github.com/nickanderson","followers_url":"https://api.github.com/users/nickanderson/followers","following_url":"https://api.github.com/users/nickanderson/following{/other_user}","gists_url":"https://api.github.com/users/nickanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/nickanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickanderson/subscriptions","organizations_url":"https://api.github.com/users/nickanderson/orgs","repos_url":"https://api.github.com/users/nickanderson/repos","events_url":"https://api.github.com/users/nickanderson/events{/privacy}","received_events_url":"https://api.github.com/users/nickanderson/received_events","type":"User","site_admin":false},"body":"Ref: https://dev.cfengine.com/issues/7603","created_at":"2015-09-24T17:48:56Z","updated_at":"2015-09-25T09:05:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5aefdfd3bcc2b73886abc9052afbba5529705b3","assignee":{"login":"kacfengine","id":4037094,"avatar_url":"https://avatars.githubusercontent.com/u/4037094?v=3","gravatar_id":"","url":"https://api.github.com/users/kacfengine","html_url":"https://github.com/kacfengine","followers_url":"https://api.github.com/users/kacfengine/followers","following_url":"https://api.github.com/users/kacfengine/following{/other_user}","gists_url":"https://api.github.com/users/kacfengine/gists{/gist_id}","starred_url":"https://api.github.com/users/kacfengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kacfengine/subscriptions","organizations_url":"https://api.github.com/users/kacfengine/orgs","repos_url":"https://api.github.com/users/kacfengine/repos","events_url":"https://api.github.com/users/kacfengine/events{/privacy}","received_events_url":"https://api.github.com/users/kacfengine/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/cfengine/core/pulls/2330/commits","review_comments_url":"https://api.github.com/repos/cfengine/core/pulls/2330/comments","review_comment_url":"https://api.github.com/repos/cfengine/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cfengine/core/issues/2330/comments","statuses_url":"https://api.github.com/repos/cfengine/core/statuses/bf76b2c5624259f044c2b75eaf42dcbea8ac8e88","head":{"label":"nickanderson:redmine/7603","ref":"redmine/7603","sha":"bf76b2c5624259f044c2b75eaf42dcbea8ac8e88","user":{"login":"nickanderson","id":202896,"avatar_url":"https://avatars.githubusercontent.com/u/202896?v=3","gravatar_id":"","url":"https://api.github.com/users/nickanderson","html_url":"https://github.com/nickanderson","followers_url":"https://api.github.com/users/nickanderson/followers","following_url":"https://api.github.com/users/nickanderson/following{/other_user}","gists_url":"https://api.github.com/users/nickanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/nickanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickanderson/subscriptions","organizations_url":"https://api.github.com/users/nickanderson/orgs","repos_url":"https://api.github.com/users/nickanderson/repos","events_url":"https://api.github.com/users/nickanderson/events{/privacy}","received_events_url":"https://api.github.com/users/nickanderson/received_events","type":"User","site_admin":false},"repo":{"id":5087189,"name":"core","full_name":"nickanderson/core","owner":{"login":"nickanderson","id":202896,"avatar_url":"https://avatars.githubusercontent.com/u/202896?v=3","gravatar_id":"","url":"https://api.github.com/users/nickanderson","html_url":"https://github.com/nickanderson","followers_url":"https://api.github.com/users/nickanderson/followers","following_url":"https://api.github.com/users/nickanderson/following{/other_user}","gists_url":"https://api.github.com/users/nickanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/nickanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickanderson/subscriptions","organizations_url":"https://api.github.com/users/nickanderson/orgs","repos_url":"https://api.github.com/users/nickanderson/repos","events_url":"https://api.github.com/users/nickanderson/events{/privacy}","received_events_url":"https://api.github.com/users/nickanderson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nickanderson/core","description":"CFEngine Community","fork":true,"url":"https://api.github.com/repos/nickanderson/core","forks_url":"https://api.github.com/repos/nickanderson/core/forks","keys_url":"https://api.github.com/repos/nickanderson/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nickanderson/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nickanderson/core/teams","hooks_url":"https://api.github.com/repos/nickanderson/core/hooks","issue_events_url":"https://api.github.com/repos/nickanderson/core/issues/events{/number}","events_url":"https://api.github.com/repos/nickanderson/core/events","assignees_url":"https://api.github.com/repos/nickanderson/core/assignees{/user}","branches_url":"https://api.github.com/repos/nickanderson/core/branches{/branch}","tags_url":"https://api.github.com/repos/nickanderson/core/tags","blobs_url":"https://api.github.com/repos/nickanderson/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nickanderson/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nickanderson/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/nickanderson/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nickanderson/core/statuses/{sha}","languages_url":"https://api.github.com/repos/nickanderson/core/languages","stargazers_url":"https://api.github.com/repos/nickanderson/core/stargazers","contributors_url":"https://api.github.com/repos/nickanderson/core/contributors","subscribers_url":"https://api.github.com/repos/nickanderson/core/subscribers","subscription_url":"https://api.github.com/repos/nickanderson/core/subscription","commits_url":"https://api.github.com/repos/nickanderson/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/nickanderson/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/nickanderson/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/nickanderson/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/nickanderson/core/contents/{+path}","compare_url":"https://api.github.com/repos/nickanderson/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nickanderson/core/merges","archive_url":"https://api.github.com/repos/nickanderson/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nickanderson/core/downloads","issues_url":"https://api.github.com/repos/nickanderson/core/issues{/number}","pulls_url":"https://api.github.com/repos/nickanderson/core/pulls{/number}","milestones_url":"https://api.github.com/repos/nickanderson/core/milestones{/number}","notifications_url":"https://api.github.com/repos/nickanderson/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nickanderson/core/labels{/name}","releases_url":"https://api.github.com/repos/nickanderson/core/releases{/id}","created_at":"2012-07-17T19:52:12Z","updated_at":"2015-07-02T20:34:12Z","pushed_at":"2015-09-24T17:48:41Z","git_url":"git://github.com/nickanderson/core.git","ssh_url":"git@github.com:nickanderson/core.git","clone_url":"https://github.com/nickanderson/core.git","svn_url":"https://github.com/nickanderson/core","homepage":"https://cfengine.com/community/","size":53577,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"cfengine:master","ref":"master","sha":"1004a6f9a0781614ed3682397e26a7de09c3d404","user":{"login":"cfengine","id":1239823,"avatar_url":"https://avatars.githubusercontent.com/u/1239823?v=3","gravatar_id":"","url":"https://api.github.com/users/cfengine","html_url":"https://github.com/cfengine","followers_url":"https://api.github.com/users/cfengine/followers","following_url":"https://api.github.com/users/cfengine/following{/other_user}","gists_url":"https://api.github.com/users/cfengine/gists{/gist_id}","starred_url":"https://api.github.com/users/cfengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfengine/subscriptions","organizations_url":"https://api.github.com/users/cfengine/orgs","repos_url":"https://api.github.com/users/cfengine/repos","events_url":"https://api.github.com/users/cfengine/events{/privacy}","received_events_url":"https://api.github.com/users/cfengine/received_events","type":"Organization","site_admin":false},"repo":{"id":3543548,"name":"core","full_name":"cfengine/core","owner":{"login":"cfengine","id":1239823,"avatar_url":"https://avatars.githubusercontent.com/u/1239823?v=3","gravatar_id":"","url":"https://api.github.com/users/cfengine","html_url":"https://github.com/cfengine","followers_url":"https://api.github.com/users/cfengine/followers","following_url":"https://api.github.com/users/cfengine/following{/other_user}","gists_url":"https://api.github.com/users/cfengine/gists{/gist_id}","starred_url":"https://api.github.com/users/cfengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfengine/subscriptions","organizations_url":"https://api.github.com/users/cfengine/orgs","repos_url":"https://api.github.com/users/cfengine/repos","events_url":"https://api.github.com/users/cfengine/events{/privacy}","received_events_url":"https://api.github.com/users/cfengine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfengine/core","description":"CFEngine Community","fork":false,"url":"https://api.github.com/repos/cfengine/core","forks_url":"https://api.github.com/repos/cfengine/core/forks","keys_url":"https://api.github.com/repos/cfengine/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfengine/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfengine/core/teams","hooks_url":"https://api.github.com/repos/cfengine/core/hooks","issue_events_url":"https://api.github.com/repos/cfengine/core/issues/events{/number}","events_url":"https://api.github.com/repos/cfengine/core/events","assignees_url":"https://api.github.com/repos/cfengine/core/assignees{/user}","branches_url":"https://api.github.com/repos/cfengine/core/branches{/branch}","tags_url":"https://api.github.com/repos/cfengine/core/tags","blobs_url":"https://api.github.com/repos/cfengine/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfengine/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfengine/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfengine/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfengine/core/statuses/{sha}","languages_url":"https://api.github.com/repos/cfengine/core/languages","stargazers_url":"https://api.github.com/repos/cfengine/core/stargazers","contributors_url":"https://api.github.com/repos/cfengine/core/contributors","subscribers_url":"https://api.github.com/repos/cfengine/core/subscribers","subscription_url":"https://api.github.com/repos/cfengine/core/subscription","commits_url":"https://api.github.com/repos/cfengine/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfengine/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfengine/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfengine/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfengine/core/contents/{+path}","compare_url":"https://api.github.com/repos/cfengine/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfengine/core/merges","archive_url":"https://api.github.com/repos/cfengine/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfengine/core/downloads","issues_url":"https://api.github.com/repos/cfengine/core/issues{/number}","pulls_url":"https://api.github.com/repos/cfengine/core/pulls{/number}","milestones_url":"https://api.github.com/repos/cfengine/core/milestones{/number}","notifications_url":"https://api.github.com/repos/cfengine/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfengine/core/labels{/name}","releases_url":"https://api.github.com/repos/cfengine/core/releases{/id}","created_at":"2012-02-25T09:19:05Z","updated_at":"2015-08-25T18:57:22Z","pushed_at":"2015-09-24T17:48:56Z","git_url":"git://github.com/cfengine/core.git","ssh_url":"git@github.com:cfengine/core.git","clone_url":"https://github.com/cfengine/core.git","svn_url":"https://github.com/cfengine/core","homepage":"https://cfengine.com/community/","size":106513,"stargazers_count":224,"watchers_count":224,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":136,"mirror_url":null,"open_issues_count":24,"forks":136,"open_issues":24,"watchers":224,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cfengine/core/pulls/2330"},"html":{"href":"https://github.com/cfengine/core/pull/2330"},"issue":{"href":"https://api.github.com/repos/cfengine/core/issues/2330"},"comments":{"href":"https://api.github.com/repos/cfengine/core/issues/2330/comments"},"review_comments":{"href":"https://api.github.com/repos/cfengine/core/pulls/2330/comments"},"review_comment":{"href":"https://api.github.com/repos/cfengine/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cfengine/core/pulls/2330/commits"},"statuses":{"href":"https://api.github.com/repos/cfengine/core/statuses/bf76b2c5624259f044c2b75eaf42dcbea8ac8e88"}}}}