{"action":"reopened","number":46,"pull_request":{"url":"https://api.github.com/repos/datacenter/acitoolkit/pulls/46","id":31775537,"html_url":"https://github.com/datacenter/acitoolkit/pull/46","diff_url":"https://github.com/datacenter/acitoolkit/pull/46.diff","patch_url":"https://github.com/datacenter/acitoolkit/pull/46.patch","issue_url":"https://api.github.com/repos/datacenter/acitoolkit/issues/46","number":46,"state":"open","locked":false,"title":"Make acitoolkit compatible with Python3.x","user":{"login":"luismartingarcia","id":7959204,"avatar_url":"https://avatars.githubusercontent.com/u/7959204?v=3","gravatar_id":"","url":"https://api.github.com/users/luismartingarcia","html_url":"https://github.com/luismartingarcia","followers_url":"https://api.github.com/users/luismartingarcia/followers","following_url":"https://api.github.com/users/luismartingarcia/following{/other_user}","gists_url":"https://api.github.com/users/luismartingarcia/gists{/gist_id}","starred_url":"https://api.github.com/users/luismartingarcia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luismartingarcia/subscriptions","organizations_url":"https://api.github.com/users/luismartingarcia/orgs","repos_url":"https://api.github.com/users/luismartingarcia/repos","events_url":"https://api.github.com/users/luismartingarcia/events{/privacy}","received_events_url":"https://api.github.com/users/luismartingarcia/received_events","type":"User","site_admin":false},"body":"Hi guys, \r\n\r\nThis is Luis Martin (lumarti2[a.t.]cisco.com), from Cisco Advanced Services EMEAR. I've been hacking the acitoolkit to make it work on Python3.x while maintaining compatibility with 2.7. Would you be up to merge these changes to make the toolkit version-independent?\r\n\r\nCHANGELOG: \r\n- Modified the source files to do explicit relative imports (since Python3.x does no longer support implicit imports of files in the same package). \r\n\r\n- Refactored Interface-related classes so they live in their own source file (aciinterface.py), eliminating the need to create a circular dependency between acitoolkit.py and aciphysobject.py. The way it is written now prevents Python3.x from performing the imports successfully.\r\n\r\n- Fixed all the print statements to include parenthesis (since print is now a function, not a keyword).\r\n\r\nNote that all the existing tests under /tests pass just fine. I haven't added any new tests, since I'm not introducing any functionality here.\r\n\r\nPlease let me know if you need me to improve any portions of the code. Thanks and best regards,\r\n\r\nLuis.","created_at":"2015-03-23T21:24:00Z","updated_at":"2015-03-23T22:50:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/datacenter/acitoolkit/pulls/46/commits","review_comments_url":"https://api.github.com/repos/datacenter/acitoolkit/pulls/46/comments","review_comment_url":"https://api.github.com/repos/datacenter/acitoolkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/datacenter/acitoolkit/issues/46/comments","statuses_url":"https://api.github.com/repos/datacenter/acitoolkit/statuses/9bab1f00b767ccc817ed2d807d433f0ce434a04f","head":{"label":"luismartingarcia:master","ref":"master","sha":"9bab1f00b767ccc817ed2d807d433f0ce434a04f","user":{"login":"luismartingarcia","id":7959204,"avatar_url":"https://avatars.githubusercontent.com/u/7959204?v=3","gravatar_id":"","url":"https://api.github.com/users/luismartingarcia","html_url":"https://github.com/luismartingarcia","followers_url":"https://api.github.com/users/luismartingarcia/followers","following_url":"https://api.github.com/users/luismartingarcia/following{/other_user}","gists_url":"https://api.github.com/users/luismartingarcia/gists{/gist_id}","starred_url":"https://api.github.com/users/luismartingarcia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luismartingarcia/subscriptions","organizations_url":"https://api.github.com/users/luismartingarcia/orgs","repos_url":"https://api.github.com/users/luismartingarcia/repos","events_url":"https://api.github.com/users/luismartingarcia/events{/privacy}","received_events_url":"https://api.github.com/users/luismartingarcia/received_events","type":"User","site_admin":false},"repo":{"id":32744298,"name":"acitoolkit","full_name":"luismartingarcia/acitoolkit","owner":{"login":"luismartingarcia","id":7959204,"avatar_url":"https://avatars.githubusercontent.com/u/7959204?v=3","gravatar_id":"","url":"https://api.github.com/users/luismartingarcia","html_url":"https://github.com/luismartingarcia","followers_url":"https://api.github.com/users/luismartingarcia/followers","following_url":"https://api.github.com/users/luismartingarcia/following{/other_user}","gists_url":"https://api.github.com/users/luismartingarcia/gists{/gist_id}","starred_url":"https://api.github.com/users/luismartingarcia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luismartingarcia/subscriptions","organizations_url":"https://api.github.com/users/luismartingarcia/orgs","repos_url":"https://api.github.com/users/luismartingarcia/repos","events_url":"https://api.github.com/users/luismartingarcia/events{/privacy}","received_events_url":"https://api.github.com/users/luismartingarcia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/luismartingarcia/acitoolkit","description":"A basic toolkit for accessing the Cisco APIC","fork":true,"url":"https://api.github.com/repos/luismartingarcia/acitoolkit","forks_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/forks","keys_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/teams","hooks_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/hooks","issue_events_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/issues/events{/number}","events_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/events","assignees_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/assignees{/user}","branches_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/branches{/branch}","tags_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/tags","blobs_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/languages","stargazers_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/stargazers","contributors_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/contributors","subscribers_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/subscribers","subscription_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/subscription","commits_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/contents/{+path}","compare_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/merges","archive_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/downloads","issues_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/issues{/number}","pulls_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/labels{/name}","releases_url":"https://api.github.com/repos/luismartingarcia/acitoolkit/releases{/id}","created_at":"2015-03-23T16:26:37Z","updated_at":"2015-03-23T22:50:01Z","pushed_at":"2015-03-23T22:50:01Z","git_url":"git://github.com/luismartingarcia/acitoolkit.git","ssh_url":"git@github.com:luismartingarcia/acitoolkit.git","clone_url":"https://github.com/luismartingarcia/acitoolkit.git","svn_url":"https://github.com/luismartingarcia/acitoolkit","homepage":"","size":9873,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"datacenter:master","ref":"master","sha":"f86a38e41db222dcd3e8807be53f7d70a111ceca","user":{"login":"datacenter","id":1562619,"avatar_url":"https://avatars.githubusercontent.com/u/1562619?v=3","gravatar_id":"","url":"https://api.github.com/users/datacenter","html_url":"https://github.com/datacenter","followers_url":"https://api.github.com/users/datacenter/followers","following_url":"https://api.github.com/users/datacenter/following{/other_user}","gists_url":"https://api.github.com/users/datacenter/gists{/gist_id}","starred_url":"https://api.github.com/users/datacenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datacenter/subscriptions","organizations_url":"https://api.github.com/users/datacenter/orgs","repos_url":"https://api.github.com/users/datacenter/repos","events_url":"https://api.github.com/users/datacenter/events{/privacy}","received_events_url":"https://api.github.com/users/datacenter/received_events","type":"Organization","site_admin":false},"repo":{"id":22358528,"name":"acitoolkit","full_name":"datacenter/acitoolkit","owner":{"login":"datacenter","id":1562619,"avatar_url":"https://avatars.githubusercontent.com/u/1562619?v=3","gravatar_id":"","url":"https://api.github.com/users/datacenter","html_url":"https://github.com/datacenter","followers_url":"https://api.github.com/users/datacenter/followers","following_url":"https://api.github.com/users/datacenter/following{/other_user}","gists_url":"https://api.github.com/users/datacenter/gists{/gist_id}","starred_url":"https://api.github.com/users/datacenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datacenter/subscriptions","organizations_url":"https://api.github.com/users/datacenter/orgs","repos_url":"https://api.github.com/users/datacenter/repos","events_url":"https://api.github.com/users/datacenter/events{/privacy}","received_events_url":"https://api.github.com/users/datacenter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/datacenter/acitoolkit","description":"A basic toolkit for accessing the Cisco APIC","fork":false,"url":"https://api.github.com/repos/datacenter/acitoolkit","forks_url":"https://api.github.com/repos/datacenter/acitoolkit/forks","keys_url":"https://api.github.com/repos/datacenter/acitoolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datacenter/acitoolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datacenter/acitoolkit/teams","hooks_url":"https://api.github.com/repos/datacenter/acitoolkit/hooks","issue_events_url":"https://api.github.com/repos/datacenter/acitoolkit/issues/events{/number}","events_url":"https://api.github.com/repos/datacenter/acitoolkit/events","assignees_url":"https://api.github.com/repos/datacenter/acitoolkit/assignees{/user}","branches_url":"https://api.github.com/repos/datacenter/acitoolkit/branches{/branch}","tags_url":"https://api.github.com/repos/datacenter/acitoolkit/tags","blobs_url":"https://api.github.com/repos/datacenter/acitoolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datacenter/acitoolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datacenter/acitoolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/datacenter/acitoolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datacenter/acitoolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/datacenter/acitoolkit/languages","stargazers_url":"https://api.github.com/repos/datacenter/acitoolkit/stargazers","contributors_url":"https://api.github.com/repos/datacenter/acitoolkit/contributors","subscribers_url":"https://api.github.com/repos/datacenter/acitoolkit/subscribers","subscription_url":"https://api.github.com/repos/datacenter/acitoolkit/subscription","commits_url":"https://api.github.com/repos/datacenter/acitoolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/datacenter/acitoolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/datacenter/acitoolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/datacenter/acitoolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/datacenter/acitoolkit/contents/{+path}","compare_url":"https://api.github.com/repos/datacenter/acitoolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datacenter/acitoolkit/merges","archive_url":"https://api.github.com/repos/datacenter/acitoolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datacenter/acitoolkit/downloads","issues_url":"https://api.github.com/repos/datacenter/acitoolkit/issues{/number}","pulls_url":"https://api.github.com/repos/datacenter/acitoolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/datacenter/acitoolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/datacenter/acitoolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datacenter/acitoolkit/labels{/name}","releases_url":"https://api.github.com/repos/datacenter/acitoolkit/releases{/id}","created_at":"2014-07-28T21:27:49Z","updated_at":"2015-03-23T17:59:12Z","pushed_at":"2015-03-23T22:50:02Z","git_url":"git://github.com/datacenter/acitoolkit.git","ssh_url":"git@github.com:datacenter/acitoolkit.git","clone_url":"https://github.com/datacenter/acitoolkit.git","svn_url":"https://github.com/datacenter/acitoolkit","homepage":"","size":9873,"stargazers_count":44,"watchers_count":44,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":29,"mirror_url":null,"open_issues_count":18,"forks":29,"open_issues":18,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/datacenter/acitoolkit/pulls/46"},"html":{"href":"https://github.com/datacenter/acitoolkit/pull/46"},"issue":{"href":"https://api.github.com/repos/datacenter/acitoolkit/issues/46"},"comments":{"href":"https://api.github.com/repos/datacenter/acitoolkit/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/datacenter/acitoolkit/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/datacenter/acitoolkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/datacenter/acitoolkit/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/datacenter/acitoolkit/statuses/9bab1f00b767ccc817ed2d807d433f0ce434a04f"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":902,"deletions":908,"changed_files":27}}