{"action":"created","comment":{"url":"https://api.github.com/repos/privly/privly-applications/pulls/comments/31347423","id":31347423,"diff_hunk":"@@ -10,6 +10,7 @@ class TestNew < Test::Unit::TestCase\n   def setup\n     page.driver.browser.get(@@privly_test_set[0][:url])\n     login(@@privly_test_set[0][:content_server])\n+    page.driver.browser.manage.timeouts.implicit_wait = 3","path":"test/selenium/specs/tc_new.rb","position":4,"original_position":4,"commit_id":"63e24d03f8aa09e598c215f340461991485ee080","original_commit_id":"63e24d03f8aa09e598c215f340461991485ee080","user":{"login":"sammyshj","id":4390022,"avatar_url":"https://avatars.githubusercontent.com/u/4390022?v=3","gravatar_id":"","url":"https://api.github.com/users/sammyshj","html_url":"https://github.com/sammyshj","followers_url":"https://api.github.com/users/sammyshj/followers","following_url":"https://api.github.com/users/sammyshj/following{/other_user}","gists_url":"https://api.github.com/users/sammyshj/gists{/gist_id}","starred_url":"https://api.github.com/users/sammyshj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sammyshj/subscriptions","organizations_url":"https://api.github.com/users/sammyshj/orgs","repos_url":"https://api.github.com/users/sammyshj/repos","events_url":"https://api.github.com/users/sammyshj/events{/privacy}","received_events_url":"https://api.github.com/users/sammyshj/received_events","type":"User","site_admin":false},"body":"It is better to have an implicit wait to avoid NoSuchElementError but, the tests pass successfully even without having the implicit_wait.\r\nShould this line be removed then?","created_at":"2015-05-29T17:47:07Z","updated_at":"2015-05-29T17:47:07Z","html_url":"https://github.com/privly/privly-applications/pull/257#discussion_r31347423","pull_request_url":"https://api.github.com/repos/privly/privly-applications/pulls/257","_links":{"self":{"href":"https://api.github.com/repos/privly/privly-applications/pulls/comments/31347423"},"html":{"href":"https://github.com/privly/privly-applications/pull/257#discussion_r31347423"},"pull_request":{"href":"https://api.github.com/repos/privly/privly-applications/pulls/257"}}},"pull_request":{"url":"https://api.github.com/repos/privly/privly-applications/pulls/257","id":36363407,"html_url":"https://github.com/privly/privly-applications/pull/257","diff_url":"https://github.com/privly/privly-applications/pull/257.diff","patch_url":"https://github.com/privly/privly-applications/pull/257.patch","issue_url":"https://api.github.com/repos/privly/privly-applications/issues/257","number":257,"state":"open","locked":false,"title":"Added safari_web for selenium tests","user":{"login":"sammyshj","id":4390022,"avatar_url":"https://avatars.githubusercontent.com/u/4390022?v=3","gravatar_id":"","url":"https://api.github.com/users/sammyshj","html_url":"https://github.com/sammyshj","followers_url":"https://api.github.com/users/sammyshj/followers","following_url":"https://api.github.com/users/sammyshj/following{/other_user}","gists_url":"https://api.github.com/users/sammyshj/gists{/gist_id}","starred_url":"https://api.github.com/users/sammyshj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sammyshj/subscriptions","organizations_url":"https://api.github.com/users/sammyshj/orgs","repos_url":"https://api.github.com/users/sammyshj/repos","events_url":"https://api.github.com/users/sammyshj/events{/privacy}","received_events_url":"https://api.github.com/users/sammyshj/received_events","type":"User","site_admin":false},"body":"Adds safari_web for selenium tests. This way we can run the selenium tests that already run on Chrome and Firefox to run on Safari too.","created_at":"2015-05-28T00:56:59Z","updated_at":"2015-05-29T17:47:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a225d8d8073e7237d340e14b57e70838be80231e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/privly/privly-applications/pulls/257/commits","review_comments_url":"https://api.github.com/repos/privly/privly-applications/pulls/257/comments","review_comment_url":"https://api.github.com/repos/privly/privly-applications/pulls/comments{/number}","comments_url":"https://api.github.com/repos/privly/privly-applications/issues/257/comments","statuses_url":"https://api.github.com/repos/privly/privly-applications/statuses/63e24d03f8aa09e598c215f340461991485ee080","head":{"label":"sammyshj:updateselenium","ref":"updateselenium","sha":"63e24d03f8aa09e598c215f340461991485ee080","user":{"login":"sammyshj","id":4390022,"avatar_url":"https://avatars.githubusercontent.com/u/4390022?v=3","gravatar_id":"","url":"https://api.github.com/users/sammyshj","html_url":"https://github.com/sammyshj","followers_url":"https://api.github.com/users/sammyshj/followers","following_url":"https://api.github.com/users/sammyshj/following{/other_user}","gists_url":"https://api.github.com/users/sammyshj/gists{/gist_id}","starred_url":"https://api.github.com/users/sammyshj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sammyshj/subscriptions","organizations_url":"https://api.github.com/users/sammyshj/orgs","repos_url":"https://api.github.com/users/sammyshj/repos","events_url":"https://api.github.com/users/sammyshj/events{/privacy}","received_events_url":"https://api.github.com/users/sammyshj/received_events","type":"User","site_admin":false},"repo":{"id":31703455,"name":"privly-applications","full_name":"sammyshj/privly-applications","owner":{"login":"sammyshj","id":4390022,"avatar_url":"https://avatars.githubusercontent.com/u/4390022?v=3","gravatar_id":"","url":"https://api.github.com/users/sammyshj","html_url":"https://github.com/sammyshj","followers_url":"https://api.github.com/users/sammyshj/followers","following_url":"https://api.github.com/users/sammyshj/following{/other_user}","gists_url":"https://api.github.com/users/sammyshj/gists{/gist_id}","starred_url":"https://api.github.com/users/sammyshj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sammyshj/subscriptions","organizations_url":"https://api.github.com/users/sammyshj/orgs","repos_url":"https://api.github.com/users/sammyshj/repos","events_url":"https://api.github.com/users/sammyshj/events{/privacy}","received_events_url":"https://api.github.com/users/sammyshj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sammyshj/privly-applications","description":"The central repository for Privly Injectable Applications.","fork":true,"url":"https://api.github.com/repos/sammyshj/privly-applications","forks_url":"https://api.github.com/repos/sammyshj/privly-applications/forks","keys_url":"https://api.github.com/repos/sammyshj/privly-applications/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sammyshj/privly-applications/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sammyshj/privly-applications/teams","hooks_url":"https://api.github.com/repos/sammyshj/privly-applications/hooks","issue_events_url":"https://api.github.com/repos/sammyshj/privly-applications/issues/events{/number}","events_url":"https://api.github.com/repos/sammyshj/privly-applications/events","assignees_url":"https://api.github.com/repos/sammyshj/privly-applications/assignees{/user}","branches_url":"https://api.github.com/repos/sammyshj/privly-applications/branches{/branch}","tags_url":"https://api.github.com/repos/sammyshj/privly-applications/tags","blobs_url":"https://api.github.com/repos/sammyshj/privly-applications/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sammyshj/privly-applications/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sammyshj/privly-applications/git/refs{/sha}","trees_url":"https://api.github.com/repos/sammyshj/privly-applications/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sammyshj/privly-applications/statuses/{sha}","languages_url":"https://api.github.com/repos/sammyshj/privly-applications/languages","stargazers_url":"https://api.github.com/repos/sammyshj/privly-applications/stargazers","contributors_url":"https://api.github.com/repos/sammyshj/privly-applications/contributors","subscribers_url":"https://api.github.com/repos/sammyshj/privly-applications/subscribers","subscription_url":"https://api.github.com/repos/sammyshj/privly-applications/subscription","commits_url":"https://api.github.com/repos/sammyshj/privly-applications/commits{/sha}","git_commits_url":"https://api.github.com/repos/sammyshj/privly-applications/git/commits{/sha}","comments_url":"https://api.github.com/repos/sammyshj/privly-applications/comments{/number}","issue_comment_url":"https://api.github.com/repos/sammyshj/privly-applications/issues/comments{/number}","contents_url":"https://api.github.com/repos/sammyshj/privly-applications/contents/{+path}","compare_url":"https://api.github.com/repos/sammyshj/privly-applications/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sammyshj/privly-applications/merges","archive_url":"https://api.github.com/repos/sammyshj/privly-applications/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sammyshj/privly-applications/downloads","issues_url":"https://api.github.com/repos/sammyshj/privly-applications/issues{/number}","pulls_url":"https://api.github.com/repos/sammyshj/privly-applications/pulls{/number}","milestones_url":"https://api.github.com/repos/sammyshj/privly-applications/milestones{/number}","notifications_url":"https://api.github.com/repos/sammyshj/privly-applications/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sammyshj/privly-applications/labels{/name}","releases_url":"https://api.github.com/repos/sammyshj/privly-applications/releases{/id}","created_at":"2015-03-05T08:25:41Z","updated_at":"2015-03-05T08:25:42Z","pushed_at":"2015-05-29T05:34:34Z","git_url":"git://github.com/sammyshj/privly-applications.git","ssh_url":"git@github.com:sammyshj/privly-applications.git","clone_url":"https://github.com/sammyshj/privly-applications.git","svn_url":"https://github.com/sammyshj/privly-applications","homepage":null,"size":6993,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"privly:develop","ref":"develop","sha":"00b4c59051f1b34da4eef3843aef1f1ea352607c","user":{"login":"privly","id":1761186,"avatar_url":"https://avatars.githubusercontent.com/u/1761186?v=3","gravatar_id":"","url":"https://api.github.com/users/privly","html_url":"https://github.com/privly","followers_url":"https://api.github.com/users/privly/followers","following_url":"https://api.github.com/users/privly/following{/other_user}","gists_url":"https://api.github.com/users/privly/gists{/gist_id}","starred_url":"https://api.github.com/users/privly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/privly/subscriptions","organizations_url":"https://api.github.com/users/privly/orgs","repos_url":"https://api.github.com/users/privly/repos","events_url":"https://api.github.com/users/privly/events{/privacy}","received_events_url":"https://api.github.com/users/privly/received_events","type":"Organization","site_admin":false},"repo":{"id":9557677,"name":"privly-applications","full_name":"privly/privly-applications","owner":{"login":"privly","id":1761186,"avatar_url":"https://avatars.githubusercontent.com/u/1761186?v=3","gravatar_id":"","url":"https://api.github.com/users/privly","html_url":"https://github.com/privly","followers_url":"https://api.github.com/users/privly/followers","following_url":"https://api.github.com/users/privly/following{/other_user}","gists_url":"https://api.github.com/users/privly/gists{/gist_id}","starred_url":"https://api.github.com/users/privly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/privly/subscriptions","organizations_url":"https://api.github.com/users/privly/orgs","repos_url":"https://api.github.com/users/privly/repos","events_url":"https://api.github.com/users/privly/events{/privacy}","received_events_url":"https://api.github.com/users/privly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/privly/privly-applications","description":"The central repository for Privly Injectable Applications.","fork":false,"url":"https://api.github.com/repos/privly/privly-applications","forks_url":"https://api.github.com/repos/privly/privly-applications/forks","keys_url":"https://api.github.com/repos/privly/privly-applications/keys{/key_id}","collaborators_url":"https://api.github.com/repos/privly/privly-applications/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/privly/privly-applications/teams","hooks_url":"https://api.github.com/repos/privly/privly-applications/hooks","issue_events_url":"https://api.github.com/repos/privly/privly-applications/issues/events{/number}","events_url":"https://api.github.com/repos/privly/privly-applications/events","assignees_url":"https://api.github.com/repos/privly/privly-applications/assignees{/user}","branches_url":"https://api.github.com/repos/privly/privly-applications/branches{/branch}","tags_url":"https://api.github.com/repos/privly/privly-applications/tags","blobs_url":"https://api.github.com/repos/privly/privly-applications/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/privly/privly-applications/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/privly/privly-applications/git/refs{/sha}","trees_url":"https://api.github.com/repos/privly/privly-applications/git/trees{/sha}","statuses_url":"https://api.github.com/repos/privly/privly-applications/statuses/{sha}","languages_url":"https://api.github.com/repos/privly/privly-applications/languages","stargazers_url":"https://api.github.com/repos/privly/privly-applications/stargazers","contributors_url":"https://api.github.com/repos/privly/privly-applications/contributors","subscribers_url":"https://api.github.com/repos/privly/privly-applications/subscribers","subscription_url":"https://api.github.com/repos/privly/privly-applications/subscription","commits_url":"https://api.github.com/repos/privly/privly-applications/commits{/sha}","git_commits_url":"https://api.github.com/repos/privly/privly-applications/git/commits{/sha}","comments_url":"https://api.github.com/repos/privly/privly-applications/comments{/number}","issue_comment_url":"https://api.github.com/repos/privly/privly-applications/issues/comments{/number}","contents_url":"https://api.github.com/repos/privly/privly-applications/contents/{+path}","compare_url":"https://api.github.com/repos/privly/privly-applications/compare/{base}...{head}","merges_url":"https://api.github.com/repos/privly/privly-applications/merges","archive_url":"https://api.github.com/repos/privly/privly-applications/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/privly/privly-applications/downloads","issues_url":"https://api.github.com/repos/privly/privly-applications/issues{/number}","pulls_url":"https://api.github.com/repos/privly/privly-applications/pulls{/number}","milestones_url":"https://api.github.com/repos/privly/privly-applications/milestones{/number}","notifications_url":"https://api.github.com/repos/privly/privly-applications/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/privly/privly-applications/labels{/name}","releases_url":"https://api.github.com/repos/privly/privly-applications/releases{/id}","created_at":"2013-04-20T01:37:17Z","updated_at":"2015-05-04T00:09:45Z","pushed_at":"2015-05-29T05:34:35Z","git_url":"git://github.com/privly/privly-applications.git","ssh_url":"git@github.com:privly/privly-applications.git","clone_url":"https://github.com/privly/privly-applications.git","svn_url":"https://github.com/privly/privly-applications","homepage":null,"size":10095,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":31,"forks":46,"open_issues":31,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/privly/privly-applications/pulls/257"},"html":{"href":"https://github.com/privly/privly-applications/pull/257"},"issue":{"href":"https://api.github.com/repos/privly/privly-applications/issues/257"},"comments":{"href":"https://api.github.com/repos/privly/privly-applications/issues/257/comments"},"review_comments":{"href":"https://api.github.com/repos/privly/privly-applications/pulls/257/comments"},"review_comment":{"href":"https://api.github.com/repos/privly/privly-applications/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/privly/privly-applications/pulls/257/commits"},"statuses":{"href":"https://api.github.com/repos/privly/privly-applications/statuses/63e24d03f8aa09e598c215f340461991485ee080"}}}}