{"action":"created","issue":{"url":"https://api.github.com/repos/guardian/membership-frontend/issues/417","labels_url":"https://api.github.com/repos/guardian/membership-frontend/issues/417/labels{/name}","comments_url":"https://api.github.com/repos/guardian/membership-frontend/issues/417/comments","events_url":"https://api.github.com/repos/guardian/membership-frontend/issues/417/events","html_url":"https://github.com/guardian/membership-frontend/pull/417","id":64775216,"number":417,"title":"Move shared links & videos out of application.conf","user":{"login":"davidrapson","id":123386,"avatar_url":"https://avatars.githubusercontent.com/u/123386?v=3","gravatar_id":"","url":"https://api.github.com/users/davidrapson","html_url":"https://github.com/davidrapson","followers_url":"https://api.github.com/users/davidrapson/followers","following_url":"https://api.github.com/users/davidrapson/following{/other_user}","gists_url":"https://api.github.com/users/davidrapson/gists{/gist_id}","starred_url":"https://api.github.com/users/davidrapson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidrapson/subscriptions","organizations_url":"https://api.github.com/users/davidrapson/orgs","repos_url":"https://api.github.com/users/davidrapson/repos","events_url":"https://api.github.com/users/davidrapson/events{/privacy}","received_events_url":"https://api.github.com/users/davidrapson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-27T14:36:48Z","updated_at":"2015-03-27T14:38:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/guardian/membership-frontend/pulls/417","html_url":"https://github.com/guardian/membership-frontend/pull/417","diff_url":"https://github.com/guardian/membership-frontend/pull/417.diff","patch_url":"https://github.com/guardian/membership-frontend/pull/417.patch"},"body":"After discussion with @rtyley this PR moves static links and video URLs out of `application.conf` and converts them to constants in new standalone config objects. This approach feels cleaner as these links don't change between environments, and now only one file needs to be updated to add new links instead of two.\r\n\r\nPlanning on doing the same with the email addresses, but will do that in another PR."},"comment":{"url":"https://api.github.com/repos/guardian/membership-frontend/issues/comments/86961171","html_url":"https://github.com/guardian/membership-frontend/pull/417#issuecomment-86961171","issue_url":"https://api.github.com/repos/guardian/membership-frontend/issues/417","id":86961171,"user":{"login":"rtyley","id":52038,"avatar_url":"https://avatars.githubusercontent.com/u/52038?v=3","gravatar_id":"","url":"https://api.github.com/users/rtyley","html_url":"https://github.com/rtyley","followers_url":"https://api.github.com/users/rtyley/followers","following_url":"https://api.github.com/users/rtyley/following{/other_user}","gists_url":"https://api.github.com/users/rtyley/gists{/gist_id}","starred_url":"https://api.github.com/users/rtyley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtyley/subscriptions","organizations_url":"https://api.github.com/users/rtyley/orgs","repos_url":"https://api.github.com/users/rtyley/repos","events_url":"https://api.github.com/users/rtyley/events{/privacy}","received_events_url":"https://api.github.com/users/rtyley/received_events","type":"User","site_admin":false},"created_at":"2015-03-27T14:38:03Z","updated_at":"2015-03-27T14:38:03Z","body":":+1:\r\n\r\n`Links` is a bit generic, but I think it'll do for now, until we get so many links that some kind of sub-grouping becomes obvious."}}