{"action":"created","comment":{"url":"https://api.github.com/repos/RackHD/on-tasks/pulls/comments/43819786","id":43819786,"diff_hunk":"@@ -89,4 +90,147 @@ describe('OBM Service', function() {\n             });\n         });\n     });\n+\n+    describe('Check invalid obm service', function() {\n+        var waterline;\n+\n+        before('check invalid obm service before', function() {\n+            waterline = helper.injector.get('Services.Waterline');\n+            waterline.skus.findOne = sinon.stub();","path":"spec/lib/services/obm-service-spec.js","position":20,"original_position":20,"commit_id":"345aec502f30252bdd3139407469236ab52aef15","original_commit_id":"345aec502f30252bdd3139407469236ab52aef15","user":{"login":"benbp","id":1020379,"avatar_url":"https://avatars.githubusercontent.com/u/1020379?v=3","gravatar_id":"","url":"https://api.github.com/users/benbp","html_url":"https://github.com/benbp","followers_url":"https://api.github.com/users/benbp/followers","following_url":"https://api.github.com/users/benbp/following{/other_user}","gists_url":"https://api.github.com/users/benbp/gists{/gist_id}","starred_url":"https://api.github.com/users/benbp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbp/subscriptions","organizations_url":"https://api.github.com/users/benbp/orgs","repos_url":"https://api.github.com/users/benbp/repos","events_url":"https://api.github.com/users/benbp/events{/privacy}","received_events_url":"https://api.github.com/users/benbp/received_events","type":"User","site_admin":false},"body":"Does this not fail without doing `sinon.stub().resolves` ? I would expect calling `.then` on it to not work otherwise.","created_at":"2015-11-03T22:57:01Z","updated_at":"2015-11-03T22:57:01Z","html_url":"https://github.com/RackHD/on-tasks/pull/55#discussion_r43819786","pull_request_url":"https://api.github.com/repos/RackHD/on-tasks/pulls/55","_links":{"self":{"href":"https://api.github.com/repos/RackHD/on-tasks/pulls/comments/43819786"},"html":{"href":"https://github.com/RackHD/on-tasks/pull/55#discussion_r43819786"},"pull_request":{"href":"https://api.github.com/repos/RackHD/on-tasks/pulls/55"}}},"pull_request":{"url":"https://api.github.com/repos/RackHD/on-tasks/pulls/55","id":48960243,"html_url":"https://github.com/RackHD/on-tasks/pull/55","diff_url":"https://github.com/RackHD/on-tasks/pull/55.diff","patch_url":"https://github.com/RackHD/on-tasks/pull/55.patch","issue_url":"https://api.github.com/repos/RackHD/on-tasks/issues/55","number":55,"state":"open","locked":false,"title":"Added checking whether some obm setting is valid for node","user":{"login":"iceiilin","id":10793130,"avatar_url":"https://avatars.githubusercontent.com/u/10793130?v=3","gravatar_id":"","url":"https://api.github.com/users/iceiilin","html_url":"https://github.com/iceiilin","followers_url":"https://api.github.com/users/iceiilin/followers","following_url":"https://api.github.com/users/iceiilin/following{/other_user}","gists_url":"https://api.github.com/users/iceiilin/gists{/gist_id}","starred_url":"https://api.github.com/users/iceiilin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iceiilin/subscriptions","organizations_url":"https://api.github.com/users/iceiilin/orgs","repos_url":"https://api.github.com/users/iceiilin/repos","events_url":"https://api.github.com/users/iceiilin/events{/privacy}","received_events_url":"https://api.github.com/users/iceiilin/received_events","type":"User","site_admin":false},"body":"Check whether current node support a specific obm setting.\r\nAlso add retries in Panduit obm settings to cover vPDU's slow response.\r\n\r\nhttps://hwjiraprd01.corp.emc.com/browse/MAG-222\r\n\r\nrelated PRs\r\nhttps://github.com/RackHD/on-http/pull/28\r\nhttps://github.com/RackHD/on-core/pull/22","created_at":"2015-10-28T03:12:56Z","updated_at":"2015-11-03T22:57:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c821c6f5ad30beff344faf920455e2a37c18481","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RackHD/on-tasks/pulls/55/commits","review_comments_url":"https://api.github.com/repos/RackHD/on-tasks/pulls/55/comments","review_comment_url":"https://api.github.com/repos/RackHD/on-tasks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RackHD/on-tasks/issues/55/comments","statuses_url":"https://api.github.com/repos/RackHD/on-tasks/statuses/345aec502f30252bdd3139407469236ab52aef15","head":{"label":"iceiilin:feature/MAG-222-pdu-obm","ref":"feature/MAG-222-pdu-obm","sha":"345aec502f30252bdd3139407469236ab52aef15","user":{"login":"iceiilin","id":10793130,"avatar_url":"https://avatars.githubusercontent.com/u/10793130?v=3","gravatar_id":"","url":"https://api.github.com/users/iceiilin","html_url":"https://github.com/iceiilin","followers_url":"https://api.github.com/users/iceiilin/followers","following_url":"https://api.github.com/users/iceiilin/following{/other_user}","gists_url":"https://api.github.com/users/iceiilin/gists{/gist_id}","starred_url":"https://api.github.com/users/iceiilin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iceiilin/subscriptions","organizations_url":"https://api.github.com/users/iceiilin/orgs","repos_url":"https://api.github.com/users/iceiilin/repos","events_url":"https://api.github.com/users/iceiilin/events{/privacy}","received_events_url":"https://api.github.com/users/iceiilin/received_events","type":"User","site_admin":false},"repo":{"id":42645517,"name":"on-tasks","full_name":"iceiilin/on-tasks","owner":{"login":"iceiilin","id":10793130,"avatar_url":"https://avatars.githubusercontent.com/u/10793130?v=3","gravatar_id":"","url":"https://api.github.com/users/iceiilin","html_url":"https://github.com/iceiilin","followers_url":"https://api.github.com/users/iceiilin/followers","following_url":"https://api.github.com/users/iceiilin/following{/other_user}","gists_url":"https://api.github.com/users/iceiilin/gists{/gist_id}","starred_url":"https://api.github.com/users/iceiilin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iceiilin/subscriptions","organizations_url":"https://api.github.com/users/iceiilin/orgs","repos_url":"https://api.github.com/users/iceiilin/repos","events_url":"https://api.github.com/users/iceiilin/events{/privacy}","received_events_url":"https://api.github.com/users/iceiilin/received_events","type":"User","site_admin":false},"private":true,"html_url":"https://github.com/iceiilin/on-tasks","description":"","fork":false,"url":"https://api.github.com/repos/iceiilin/on-tasks","forks_url":"https://api.github.com/repos/iceiilin/on-tasks/forks","keys_url":"https://api.github.com/repos/iceiilin/on-tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iceiilin/on-tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iceiilin/on-tasks/teams","hooks_url":"https://api.github.com/repos/iceiilin/on-tasks/hooks","issue_events_url":"https://api.github.com/repos/iceiilin/on-tasks/issues/events{/number}","events_url":"https://api.github.com/repos/iceiilin/on-tasks/events","assignees_url":"https://api.github.com/repos/iceiilin/on-tasks/assignees{/user}","branches_url":"https://api.github.com/repos/iceiilin/on-tasks/branches{/branch}","tags_url":"https://api.github.com/repos/iceiilin/on-tasks/tags","blobs_url":"https://api.github.com/repos/iceiilin/on-tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iceiilin/on-tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iceiilin/on-tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/iceiilin/on-tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iceiilin/on-tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/iceiilin/on-tasks/languages","stargazers_url":"https://api.github.com/repos/iceiilin/on-tasks/stargazers","contributors_url":"https://api.github.com/repos/iceiilin/on-tasks/contributors","subscribers_url":"https://api.github.com/repos/iceiilin/on-tasks/subscribers","subscription_url":"https://api.github.com/repos/iceiilin/on-tasks/subscription","commits_url":"https://api.github.com/repos/iceiilin/on-tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/iceiilin/on-tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/iceiilin/on-tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/iceiilin/on-tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/iceiilin/on-tasks/contents/{+path}","compare_url":"https://api.github.com/repos/iceiilin/on-tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iceiilin/on-tasks/merges","archive_url":"https://api.github.com/repos/iceiilin/on-tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iceiilin/on-tasks/downloads","issues_url":"https://api.github.com/repos/iceiilin/on-tasks/issues{/number}","pulls_url":"https://api.github.com/repos/iceiilin/on-tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/iceiilin/on-tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/iceiilin/on-tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iceiilin/on-tasks/labels{/name}","releases_url":"https://api.github.com/repos/iceiilin/on-tasks/releases{/id}","created_at":"2015-09-17T08:49:47Z","updated_at":"2015-11-02T22:55:52Z","pushed_at":"2015-11-02T10:52:06Z","git_url":"git://github.com/iceiilin/on-tasks.git","ssh_url":"git@github.com:iceiilin/on-tasks.git","clone_url":"https://github.com/iceiilin/on-tasks.git","svn_url":"https://github.com/iceiilin/on-tasks","homepage":null,"size":930,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RackHD:master","ref":"master","sha":"11015f9aa2d23de76f046aee9a8c2807d7f36d5d","user":{"login":"RackHD","id":13982662,"avatar_url":"https://avatars.githubusercontent.com/u/13982662?v=3","gravatar_id":"","url":"https://api.github.com/users/RackHD","html_url":"https://github.com/RackHD","followers_url":"https://api.github.com/users/RackHD/followers","following_url":"https://api.github.com/users/RackHD/following{/other_user}","gists_url":"https://api.github.com/users/RackHD/gists{/gist_id}","starred_url":"https://api.github.com/users/RackHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackHD/subscriptions","organizations_url":"https://api.github.com/users/RackHD/orgs","repos_url":"https://api.github.com/users/RackHD/repos","events_url":"https://api.github.com/users/RackHD/events{/privacy}","received_events_url":"https://api.github.com/users/RackHD/received_events","type":"Organization","site_admin":false},"repo":{"id":41690099,"name":"on-tasks","full_name":"RackHD/on-tasks","owner":{"login":"RackHD","id":13982662,"avatar_url":"https://avatars.githubusercontent.com/u/13982662?v=3","gravatar_id":"","url":"https://api.github.com/users/RackHD","html_url":"https://github.com/RackHD","followers_url":"https://api.github.com/users/RackHD/followers","following_url":"https://api.github.com/users/RackHD/following{/other_user}","gists_url":"https://api.github.com/users/RackHD/gists{/gist_id}","starred_url":"https://api.github.com/users/RackHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackHD/subscriptions","organizations_url":"https://api.github.com/users/RackHD/orgs","repos_url":"https://api.github.com/users/RackHD/repos","events_url":"https://api.github.com/users/RackHD/events{/privacy}","received_events_url":"https://api.github.com/users/RackHD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RackHD/on-tasks","description":"","fork":false,"url":"https://api.github.com/repos/RackHD/on-tasks","forks_url":"https://api.github.com/repos/RackHD/on-tasks/forks","keys_url":"https://api.github.com/repos/RackHD/on-tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RackHD/on-tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RackHD/on-tasks/teams","hooks_url":"https://api.github.com/repos/RackHD/on-tasks/hooks","issue_events_url":"https://api.github.com/repos/RackHD/on-tasks/issues/events{/number}","events_url":"https://api.github.com/repos/RackHD/on-tasks/events","assignees_url":"https://api.github.com/repos/RackHD/on-tasks/assignees{/user}","branches_url":"https://api.github.com/repos/RackHD/on-tasks/branches{/branch}","tags_url":"https://api.github.com/repos/RackHD/on-tasks/tags","blobs_url":"https://api.github.com/repos/RackHD/on-tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RackHD/on-tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RackHD/on-tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/RackHD/on-tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RackHD/on-tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/RackHD/on-tasks/languages","stargazers_url":"https://api.github.com/repos/RackHD/on-tasks/stargazers","contributors_url":"https://api.github.com/repos/RackHD/on-tasks/contributors","subscribers_url":"https://api.github.com/repos/RackHD/on-tasks/subscribers","subscription_url":"https://api.github.com/repos/RackHD/on-tasks/subscription","commits_url":"https://api.github.com/repos/RackHD/on-tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/RackHD/on-tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/RackHD/on-tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/RackHD/on-tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/RackHD/on-tasks/contents/{+path}","compare_url":"https://api.github.com/repos/RackHD/on-tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RackHD/on-tasks/merges","archive_url":"https://api.github.com/repos/RackHD/on-tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RackHD/on-tasks/downloads","issues_url":"https://api.github.com/repos/RackHD/on-tasks/issues{/number}","pulls_url":"https://api.github.com/repos/RackHD/on-tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/RackHD/on-tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/RackHD/on-tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RackHD/on-tasks/labels{/name}","releases_url":"https://api.github.com/repos/RackHD/on-tasks/releases{/id}","created_at":"2015-08-31T17:29:32Z","updated_at":"2015-11-02T22:55:44Z","pushed_at":"2015-11-03T01:24:04Z","git_url":"git://github.com/RackHD/on-tasks.git","ssh_url":"git@github.com:RackHD/on-tasks.git","clone_url":"https://github.com/RackHD/on-tasks.git","svn_url":"https://github.com/RackHD/on-tasks","homepage":null,"size":1883,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RackHD/on-tasks/pulls/55"},"html":{"href":"https://github.com/RackHD/on-tasks/pull/55"},"issue":{"href":"https://api.github.com/repos/RackHD/on-tasks/issues/55"},"comments":{"href":"https://api.github.com/repos/RackHD/on-tasks/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/RackHD/on-tasks/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/RackHD/on-tasks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RackHD/on-tasks/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/RackHD/on-tasks/statuses/345aec502f30252bdd3139407469236ab52aef15"}}}}