{"action":"created","comment":{"url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments/42217157","id":42217157,"diff_hunk":"@@ -89,21 +89,29 @@ def with_translation(translation)\n \n end\n \n-ENV['RAILS_ENV'] = 'test'\n-ENV['RAILS_ROOT'] = File.expand_path(\"../rails/rails-#{ENV['RAILS']}\", __FILE__)\n-\n-# Create the test app if it doesn't exists\n-unless File.exists?(ENV['RAILS_ROOT'])\n-  system 'rake setup'\n-end\n-\n require 'rails'\n require 'active_record'\n require 'active_admin'\n require 'devise'\n-ActiveAdmin.application.load_paths = [ENV['RAILS_ROOT'] + \"/app/admin\"]\n \n-require ENV['RAILS_ROOT'] + '/config/environment'\n+# NOTE: Safe to use fuzzy rails version here?  Or does it need to be exact?\n+#       Fuzzy *should* be OK.\n+fuzzy_rails_version = \"#{Rails::VERSION::MAJOR}.#{Rails::VERSION::MINOR}.x\"\n+ENV[\"RAILS_ENV\"] = \"test\"\n+ENV[\"RAILS_ROOT\"] = File.expand_path(\"../rails/ruby-#{RUBY_VERSION}-rails-#{fuzzy_rails_version}\", __FILE__)\n+puts \"[rails_helper.rb] Rails Root: #{ENV[\"RAILS_ROOT\"]}\"\n+\n+# Create the test app if it doesn't exists\n+unless File.exists?(ENV[\"RAILS_ROOT\"])\n+  puts \"[rails_helper.rb] BUNDLE_GEMFILE='gemfiles/Gemfile.rails-#{fuzzy_rails_version}' bundle exec rake setup\"\n+  system %[BUNDLE_GEMFILE='gemfiles/Gemfile.rails-#{fuzzy_rails_version}' bundle exec rake setup]\n+else\n+  puts \"already setup #{ENV[\"RAILS_ROOT\"]}\"","path":"spec/rails_helper.rb","position":31,"original_position":31,"commit_id":"cdbc5ad6bb799ddd3c6a581c54ce74c767b5eedc","original_commit_id":"cdbc5ad6bb799ddd3c6a581c54ce74c767b5eedc","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Prefer single-quoted strings inside interpolations.","created_at":"2015-10-16T07:55:26Z","updated_at":"2015-10-16T07:55:26Z","html_url":"https://github.com/activeadmin/activeadmin/pull/4161#discussion_r42217157","pull_request_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/4161","_links":{"self":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments/42217157"},"html":{"href":"https://github.com/activeadmin/activeadmin/pull/4161#discussion_r42217157"},"pull_request":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/4161"}}},"pull_request":{"url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/4161","id":47880524,"html_url":"https://github.com/activeadmin/activeadmin/pull/4161","diff_url":"https://github.com/activeadmin/activeadmin/pull/4161.diff","patch_url":"https://github.com/activeadmin/activeadmin/pull/4161.patch","issue_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/4161","number":4161,"state":"open","locked":false,"title":"Wholesale Test Infrastructure Upgrade","user":{"login":"pboling","id":19505,"avatar_url":"https://avatars.githubusercontent.com/u/19505?v=3","gravatar_id":"","url":"https://api.github.com/users/pboling","html_url":"https://github.com/pboling","followers_url":"https://api.github.com/users/pboling/followers","following_url":"https://api.github.com/users/pboling/following{/other_user}","gists_url":"https://api.github.com/users/pboling/gists{/gist_id}","starred_url":"https://api.github.com/users/pboling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pboling/subscriptions","organizations_url":"https://api.github.com/users/pboling/orgs","repos_url":"https://api.github.com/users/pboling/repos","events_url":"https://api.github.com/users/pboling/events{/privacy}","received_events_url":"https://api.github.com/users/pboling/received_events","type":"User","site_admin":false},"body":"I promise I will make a better commit message.  Want to see what Travis does with all these changes while I sleep.  I am getting the same five failures on every Ruby against every version of Rails.\r\n\r\nI upgraded to latest Rubies and latest Rails patches, along with updating to latest patch level of many gems.  I haven't looked into the 5 failures at all, but some upgrade is causing them I think.","created_at":"2015-10-16T07:55:20Z","updated_at":"2015-10-16T07:55:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"085a13b1e4e372d1b2a2ee34f0da286e301c7dc7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/4161/commits","review_comments_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/4161/comments","review_comment_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/4161/comments","statuses_url":"https://api.github.com/repos/activeadmin/activeadmin/statuses/cdbc5ad6bb799ddd3c6a581c54ce74c767b5eedc","head":{"label":"pboling:3715-travis-upgrades","ref":"3715-travis-upgrades","sha":"cdbc5ad6bb799ddd3c6a581c54ce74c767b5eedc","user":{"login":"pboling","id":19505,"avatar_url":"https://avatars.githubusercontent.com/u/19505?v=3","gravatar_id":"","url":"https://api.github.com/users/pboling","html_url":"https://github.com/pboling","followers_url":"https://api.github.com/users/pboling/followers","following_url":"https://api.github.com/users/pboling/following{/other_user}","gists_url":"https://api.github.com/users/pboling/gists{/gist_id}","starred_url":"https://api.github.com/users/pboling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pboling/subscriptions","organizations_url":"https://api.github.com/users/pboling/orgs","repos_url":"https://api.github.com/users/pboling/repos","events_url":"https://api.github.com/users/pboling/events{/privacy}","received_events_url":"https://api.github.com/users/pboling/received_events","type":"User","site_admin":false},"repo":{"id":44028934,"name":"activeadmin","full_name":"pboling/activeadmin","owner":{"login":"pboling","id":19505,"avatar_url":"https://avatars.githubusercontent.com/u/19505?v=3","gravatar_id":"","url":"https://api.github.com/users/pboling","html_url":"https://github.com/pboling","followers_url":"https://api.github.com/users/pboling/followers","following_url":"https://api.github.com/users/pboling/following{/other_user}","gists_url":"https://api.github.com/users/pboling/gists{/gist_id}","starred_url":"https://api.github.com/users/pboling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pboling/subscriptions","organizations_url":"https://api.github.com/users/pboling/orgs","repos_url":"https://api.github.com/users/pboling/repos","events_url":"https://api.github.com/users/pboling/events{/privacy}","received_events_url":"https://api.github.com/users/pboling/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pboling/activeadmin","description":"The administration framework for Ruby on Rails applications.","fork":true,"url":"https://api.github.com/repos/pboling/activeadmin","forks_url":"https://api.github.com/repos/pboling/activeadmin/forks","keys_url":"https://api.github.com/repos/pboling/activeadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pboling/activeadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pboling/activeadmin/teams","hooks_url":"https://api.github.com/repos/pboling/activeadmin/hooks","issue_events_url":"https://api.github.com/repos/pboling/activeadmin/issues/events{/number}","events_url":"https://api.github.com/repos/pboling/activeadmin/events","assignees_url":"https://api.github.com/repos/pboling/activeadmin/assignees{/user}","branches_url":"https://api.github.com/repos/pboling/activeadmin/branches{/branch}","tags_url":"https://api.github.com/repos/pboling/activeadmin/tags","blobs_url":"https://api.github.com/repos/pboling/activeadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pboling/activeadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pboling/activeadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/pboling/activeadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pboling/activeadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/pboling/activeadmin/languages","stargazers_url":"https://api.github.com/repos/pboling/activeadmin/stargazers","contributors_url":"https://api.github.com/repos/pboling/activeadmin/contributors","subscribers_url":"https://api.github.com/repos/pboling/activeadmin/subscribers","subscription_url":"https://api.github.com/repos/pboling/activeadmin/subscription","commits_url":"https://api.github.com/repos/pboling/activeadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/pboling/activeadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/pboling/activeadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/pboling/activeadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/pboling/activeadmin/contents/{+path}","compare_url":"https://api.github.com/repos/pboling/activeadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pboling/activeadmin/merges","archive_url":"https://api.github.com/repos/pboling/activeadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pboling/activeadmin/downloads","issues_url":"https://api.github.com/repos/pboling/activeadmin/issues{/number}","pulls_url":"https://api.github.com/repos/pboling/activeadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/pboling/activeadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/pboling/activeadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pboling/activeadmin/labels{/name}","releases_url":"https://api.github.com/repos/pboling/activeadmin/releases{/id}","created_at":"2015-10-10T21:25:52Z","updated_at":"2015-10-10T21:25:55Z","pushed_at":"2015-10-16T07:51:59Z","git_url":"git://github.com/pboling/activeadmin.git","ssh_url":"git@github.com:pboling/activeadmin.git","clone_url":"https://github.com/pboling/activeadmin.git","svn_url":"https://github.com/pboling/activeadmin","homepage":"activeadmin.info","size":19401,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"activeadmin:master","ref":"master","sha":"a3fca244b0cbaa6139931952ba2c72dda58e05b1","user":{"login":"activeadmin","id":814570,"avatar_url":"https://avatars.githubusercontent.com/u/814570?v=3","gravatar_id":"","url":"https://api.github.com/users/activeadmin","html_url":"https://github.com/activeadmin","followers_url":"https://api.github.com/users/activeadmin/followers","following_url":"https://api.github.com/users/activeadmin/following{/other_user}","gists_url":"https://api.github.com/users/activeadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/activeadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activeadmin/subscriptions","organizations_url":"https://api.github.com/users/activeadmin/orgs","repos_url":"https://api.github.com/users/activeadmin/repos","events_url":"https://api.github.com/users/activeadmin/events{/privacy}","received_events_url":"https://api.github.com/users/activeadmin/received_events","type":"Organization","site_admin":false},"repo":{"id":611921,"name":"activeadmin","full_name":"activeadmin/activeadmin","owner":{"login":"activeadmin","id":814570,"avatar_url":"https://avatars.githubusercontent.com/u/814570?v=3","gravatar_id":"","url":"https://api.github.com/users/activeadmin","html_url":"https://github.com/activeadmin","followers_url":"https://api.github.com/users/activeadmin/followers","following_url":"https://api.github.com/users/activeadmin/following{/other_user}","gists_url":"https://api.github.com/users/activeadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/activeadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activeadmin/subscriptions","organizations_url":"https://api.github.com/users/activeadmin/orgs","repos_url":"https://api.github.com/users/activeadmin/repos","events_url":"https://api.github.com/users/activeadmin/events{/privacy}","received_events_url":"https://api.github.com/users/activeadmin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/activeadmin/activeadmin","description":"The administration framework for Ruby on Rails applications.","fork":false,"url":"https://api.github.com/repos/activeadmin/activeadmin","forks_url":"https://api.github.com/repos/activeadmin/activeadmin/forks","keys_url":"https://api.github.com/repos/activeadmin/activeadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/activeadmin/activeadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/activeadmin/activeadmin/teams","hooks_url":"https://api.github.com/repos/activeadmin/activeadmin/hooks","issue_events_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/events{/number}","events_url":"https://api.github.com/repos/activeadmin/activeadmin/events","assignees_url":"https://api.github.com/repos/activeadmin/activeadmin/assignees{/user}","branches_url":"https://api.github.com/repos/activeadmin/activeadmin/branches{/branch}","tags_url":"https://api.github.com/repos/activeadmin/activeadmin/tags","blobs_url":"https://api.github.com/repos/activeadmin/activeadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/activeadmin/activeadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/activeadmin/activeadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/activeadmin/activeadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/activeadmin/activeadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/activeadmin/activeadmin/languages","stargazers_url":"https://api.github.com/repos/activeadmin/activeadmin/stargazers","contributors_url":"https://api.github.com/repos/activeadmin/activeadmin/contributors","subscribers_url":"https://api.github.com/repos/activeadmin/activeadmin/subscribers","subscription_url":"https://api.github.com/repos/activeadmin/activeadmin/subscription","commits_url":"https://api.github.com/repos/activeadmin/activeadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/activeadmin/activeadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/activeadmin/activeadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/activeadmin/activeadmin/contents/{+path}","compare_url":"https://api.github.com/repos/activeadmin/activeadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/activeadmin/activeadmin/merges","archive_url":"https://api.github.com/repos/activeadmin/activeadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/activeadmin/activeadmin/downloads","issues_url":"https://api.github.com/repos/activeadmin/activeadmin/issues{/number}","pulls_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/activeadmin/activeadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/activeadmin/activeadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/activeadmin/activeadmin/labels{/name}","releases_url":"https://api.github.com/repos/activeadmin/activeadmin/releases{/id}","created_at":"2010-04-15T14:26:03Z","updated_at":"2015-10-16T07:53:52Z","pushed_at":"2015-10-16T07:55:20Z","git_url":"git://github.com/activeadmin/activeadmin.git","ssh_url":"git@github.com:activeadmin/activeadmin.git","clone_url":"https://github.com/activeadmin/activeadmin.git","svn_url":"https://github.com/activeadmin/activeadmin","homepage":"activeadmin.info","size":19401,"stargazers_count":6269,"watchers_count":6269,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2235,"mirror_url":null,"open_issues_count":221,"forks":2235,"open_issues":221,"watchers":6269,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/4161"},"html":{"href":"https://github.com/activeadmin/activeadmin/pull/4161"},"issue":{"href":"https://api.github.com/repos/activeadmin/activeadmin/issues/4161"},"comments":{"href":"https://api.github.com/repos/activeadmin/activeadmin/issues/4161/comments"},"review_comments":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/4161/comments"},"review_comment":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/4161/commits"},"statuses":{"href":"https://api.github.com/repos/activeadmin/activeadmin/statuses/cdbc5ad6bb799ddd3c6a581c54ce74c767b5eedc"}}}}