{"action":"closed","number":356,"pull_request":{"url":"https://api.github.com/repos/Qucs/qucs/pulls/356","id":45071695,"html_url":"https://github.com/Qucs/qucs/pull/356","diff_url":"https://github.com/Qucs/qucs/pull/356.diff","patch_url":"https://github.com/Qucs/qucs/pull/356.patch","issue_url":"https://api.github.com/repos/Qucs/qucs/issues/356","number":356,"state":"closed","locked":false,"title":"Circular waveguide component","user":{"login":"andresmmera","id":13180689,"avatar_url":"https://avatars.githubusercontent.com/u/13180689?v=3","gravatar_id":"","url":"https://api.github.com/users/andresmmera","html_url":"https://github.com/andresmmera","followers_url":"https://api.github.com/users/andresmmera/followers","following_url":"https://api.github.com/users/andresmmera/following{/other_user}","gists_url":"https://api.github.com/users/andresmmera/gists{/gist_id}","starred_url":"https://api.github.com/users/andresmmera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresmmera/subscriptions","organizations_url":"https://api.github.com/users/andresmmera/orgs","repos_url":"https://api.github.com/users/andresmmera/repos","events_url":"https://api.github.com/users/andresmmera/events{/privacy}","received_events_url":"https://api.github.com/users/andresmmera/received_events","type":"User","site_admin":false},"body":"This is a component for modelling the TE11 mode of a circular waveguide. The code is very similar to the rectangular waveguide model.\r\n\r\nIn order to check it works, [here](https://dl.dropboxusercontent.com/u/21294824/CircularWG.sch) is attached a schematic with a S-parameter simulation. The results seem to be coherent with [this Octave script](https://dl.dropboxusercontent.com/u/21294824/CWG.m), which implements the theoretical equations given by the theory.\r\n\r\nQucs schematic:\r\n![screenshot from 2015-09-15 18 18 46](https://cloud.githubusercontent.com/assets/13180689/9882725/747f45a8-5bd6-11e5-810a-553790a2ac0d.png)\r\n\r\nQucs results:\r\n![screenshot from 2015-09-15 18 19 42](https://cloud.githubusercontent.com/assets/13180689/9882732/7dab6a94-5bd6-11e5-8493-d3c170e30623.png)\r\n\r\nS11 (Script)\r\n![s11](https://cloud.githubusercontent.com/assets/13180689/9882739/89409d0c-5bd6-11e5-8ab7-691b6c9b6c12.png)\r\n\r\nS21 (Script)\r\n![s21](https://cloud.githubusercontent.com/assets/13180689/9882753/93c84d10-5bd6-11e5-8a04-ef75474a3b15.png)\r\n","created_at":"2015-09-15T16:30:58Z","updated_at":"2015-09-19T09:10:42Z","closed_at":"2015-09-19T09:10:42Z","merged_at":null,"merge_commit_sha":"9a2820f2135e65405f372233cba6a70e97a56615","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Qucs/qucs/pulls/356/commits","review_comments_url":"https://api.github.com/repos/Qucs/qucs/pulls/356/comments","review_comment_url":"https://api.github.com/repos/Qucs/qucs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Qucs/qucs/issues/356/comments","statuses_url":"https://api.github.com/repos/Qucs/qucs/statuses/a02d431da06d7021381a7bf6504a1528422d93a2","head":{"label":"andresmmera:CircWGComponent","ref":"CircWGComponent","sha":"a02d431da06d7021381a7bf6504a1528422d93a2","user":{"login":"andresmmera","id":13180689,"avatar_url":"https://avatars.githubusercontent.com/u/13180689?v=3","gravatar_id":"","url":"https://api.github.com/users/andresmmera","html_url":"https://github.com/andresmmera","followers_url":"https://api.github.com/users/andresmmera/followers","following_url":"https://api.github.com/users/andresmmera/following{/other_user}","gists_url":"https://api.github.com/users/andresmmera/gists{/gist_id}","starred_url":"https://api.github.com/users/andresmmera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresmmera/subscriptions","organizations_url":"https://api.github.com/users/andresmmera/orgs","repos_url":"https://api.github.com/users/andresmmera/repos","events_url":"https://api.github.com/users/andresmmera/events{/privacy}","received_events_url":"https://api.github.com/users/andresmmera/received_events","type":"User","site_admin":false},"repo":{"id":39032254,"name":"qucs","full_name":"andresmmera/qucs","owner":{"login":"andresmmera","id":13180689,"avatar_url":"https://avatars.githubusercontent.com/u/13180689?v=3","gravatar_id":"","url":"https://api.github.com/users/andresmmera","html_url":"https://github.com/andresmmera","followers_url":"https://api.github.com/users/andresmmera/followers","following_url":"https://api.github.com/users/andresmmera/following{/other_user}","gists_url":"https://api.github.com/users/andresmmera/gists{/gist_id}","starred_url":"https://api.github.com/users/andresmmera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresmmera/subscriptions","organizations_url":"https://api.github.com/users/andresmmera/orgs","repos_url":"https://api.github.com/users/andresmmera/repos","events_url":"https://api.github.com/users/andresmmera/events{/privacy}","received_events_url":"https://api.github.com/users/andresmmera/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andresmmera/qucs","description":"Qucs Project official mirror","fork":true,"url":"https://api.github.com/repos/andresmmera/qucs","forks_url":"https://api.github.com/repos/andresmmera/qucs/forks","keys_url":"https://api.github.com/repos/andresmmera/qucs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andresmmera/qucs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andresmmera/qucs/teams","hooks_url":"https://api.github.com/repos/andresmmera/qucs/hooks","issue_events_url":"https://api.github.com/repos/andresmmera/qucs/issues/events{/number}","events_url":"https://api.github.com/repos/andresmmera/qucs/events","assignees_url":"https://api.github.com/repos/andresmmera/qucs/assignees{/user}","branches_url":"https://api.github.com/repos/andresmmera/qucs/branches{/branch}","tags_url":"https://api.github.com/repos/andresmmera/qucs/tags","blobs_url":"https://api.github.com/repos/andresmmera/qucs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andresmmera/qucs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andresmmera/qucs/git/refs{/sha}","trees_url":"https://api.github.com/repos/andresmmera/qucs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andresmmera/qucs/statuses/{sha}","languages_url":"https://api.github.com/repos/andresmmera/qucs/languages","stargazers_url":"https://api.github.com/repos/andresmmera/qucs/stargazers","contributors_url":"https://api.github.com/repos/andresmmera/qucs/contributors","subscribers_url":"https://api.github.com/repos/andresmmera/qucs/subscribers","subscription_url":"https://api.github.com/repos/andresmmera/qucs/subscription","commits_url":"https://api.github.com/repos/andresmmera/qucs/commits{/sha}","git_commits_url":"https://api.github.com/repos/andresmmera/qucs/git/commits{/sha}","comments_url":"https://api.github.com/repos/andresmmera/qucs/comments{/number}","issue_comment_url":"https://api.github.com/repos/andresmmera/qucs/issues/comments{/number}","contents_url":"https://api.github.com/repos/andresmmera/qucs/contents/{+path}","compare_url":"https://api.github.com/repos/andresmmera/qucs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andresmmera/qucs/merges","archive_url":"https://api.github.com/repos/andresmmera/qucs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andresmmera/qucs/downloads","issues_url":"https://api.github.com/repos/andresmmera/qucs/issues{/number}","pulls_url":"https://api.github.com/repos/andresmmera/qucs/pulls{/number}","milestones_url":"https://api.github.com/repos/andresmmera/qucs/milestones{/number}","notifications_url":"https://api.github.com/repos/andresmmera/qucs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andresmmera/qucs/labels{/name}","releases_url":"https://api.github.com/repos/andresmmera/qucs/releases{/id}","created_at":"2015-07-13T19:17:01Z","updated_at":"2015-07-13T19:17:08Z","pushed_at":"2015-09-17T22:31:34Z","git_url":"git://github.com/andresmmera/qucs.git","ssh_url":"git@github.com:andresmmera/qucs.git","clone_url":"https://github.com/andresmmera/qucs.git","svn_url":"https://github.com/andresmmera/qucs","homepage":"http://qucs.sourceforge.net/","size":58564,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Qucs:master","ref":"master","sha":"7832080795c35e2a3504c7d7d83892988815ad61","user":{"login":"Qucs","id":5776398,"avatar_url":"https://avatars.githubusercontent.com/u/5776398?v=3","gravatar_id":"","url":"https://api.github.com/users/Qucs","html_url":"https://github.com/Qucs","followers_url":"https://api.github.com/users/Qucs/followers","following_url":"https://api.github.com/users/Qucs/following{/other_user}","gists_url":"https://api.github.com/users/Qucs/gists{/gist_id}","starred_url":"https://api.github.com/users/Qucs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qucs/subscriptions","organizations_url":"https://api.github.com/users/Qucs/orgs","repos_url":"https://api.github.com/users/Qucs/repos","events_url":"https://api.github.com/users/Qucs/events{/privacy}","received_events_url":"https://api.github.com/users/Qucs/received_events","type":"Organization","site_admin":false},"repo":{"id":16213441,"name":"qucs","full_name":"Qucs/qucs","owner":{"login":"Qucs","id":5776398,"avatar_url":"https://avatars.githubusercontent.com/u/5776398?v=3","gravatar_id":"","url":"https://api.github.com/users/Qucs","html_url":"https://github.com/Qucs","followers_url":"https://api.github.com/users/Qucs/followers","following_url":"https://api.github.com/users/Qucs/following{/other_user}","gists_url":"https://api.github.com/users/Qucs/gists{/gist_id}","starred_url":"https://api.github.com/users/Qucs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qucs/subscriptions","organizations_url":"https://api.github.com/users/Qucs/orgs","repos_url":"https://api.github.com/users/Qucs/repos","events_url":"https://api.github.com/users/Qucs/events{/privacy}","received_events_url":"https://api.github.com/users/Qucs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Qucs/qucs","description":"Qucs Project official mirror","fork":false,"url":"https://api.github.com/repos/Qucs/qucs","forks_url":"https://api.github.com/repos/Qucs/qucs/forks","keys_url":"https://api.github.com/repos/Qucs/qucs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Qucs/qucs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Qucs/qucs/teams","hooks_url":"https://api.github.com/repos/Qucs/qucs/hooks","issue_events_url":"https://api.github.com/repos/Qucs/qucs/issues/events{/number}","events_url":"https://api.github.com/repos/Qucs/qucs/events","assignees_url":"https://api.github.com/repos/Qucs/qucs/assignees{/user}","branches_url":"https://api.github.com/repos/Qucs/qucs/branches{/branch}","tags_url":"https://api.github.com/repos/Qucs/qucs/tags","blobs_url":"https://api.github.com/repos/Qucs/qucs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Qucs/qucs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Qucs/qucs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Qucs/qucs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Qucs/qucs/statuses/{sha}","languages_url":"https://api.github.com/repos/Qucs/qucs/languages","stargazers_url":"https://api.github.com/repos/Qucs/qucs/stargazers","contributors_url":"https://api.github.com/repos/Qucs/qucs/contributors","subscribers_url":"https://api.github.com/repos/Qucs/qucs/subscribers","subscription_url":"https://api.github.com/repos/Qucs/qucs/subscription","commits_url":"https://api.github.com/repos/Qucs/qucs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Qucs/qucs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Qucs/qucs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Qucs/qucs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Qucs/qucs/contents/{+path}","compare_url":"https://api.github.com/repos/Qucs/qucs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Qucs/qucs/merges","archive_url":"https://api.github.com/repos/Qucs/qucs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Qucs/qucs/downloads","issues_url":"https://api.github.com/repos/Qucs/qucs/issues{/number}","pulls_url":"https://api.github.com/repos/Qucs/qucs/pulls{/number}","milestones_url":"https://api.github.com/repos/Qucs/qucs/milestones{/number}","notifications_url":"https://api.github.com/repos/Qucs/qucs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Qucs/qucs/labels{/name}","releases_url":"https://api.github.com/repos/Qucs/qucs/releases{/id}","created_at":"2014-01-24T18:48:36Z","updated_at":"2015-09-18T15:27:01Z","pushed_at":"2015-09-19T09:09:38Z","git_url":"git://github.com/Qucs/qucs.git","ssh_url":"git@github.com:Qucs/qucs.git","clone_url":"https://github.com/Qucs/qucs.git","svn_url":"https://github.com/Qucs/qucs","homepage":"http://qucs.sourceforge.net/","size":71322,"stargazers_count":140,"watchers_count":140,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":82,"forks":32,"open_issues":82,"watchers":140,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Qucs/qucs/pulls/356"},"html":{"href":"https://github.com/Qucs/qucs/pull/356"},"issue":{"href":"https://api.github.com/repos/Qucs/qucs/issues/356"},"comments":{"href":"https://api.github.com/repos/Qucs/qucs/issues/356/comments"},"review_comments":{"href":"https://api.github.com/repos/Qucs/qucs/pulls/356/comments"},"review_comment":{"href":"https://api.github.com/repos/Qucs/qucs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Qucs/qucs/pulls/356/commits"},"statuses":{"href":"https://api.github.com/repos/Qucs/qucs/statuses/a02d431da06d7021381a7bf6504a1528422d93a2"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":9,"review_comments":4,"commits":5,"additions":490,"deletions":4,"changed_files":15}}