{"action":"created","issue":{"url":"https://api.github.com/repos/jboss-reddeer/reddeer/issues/909","labels_url":"https://api.github.com/repos/jboss-reddeer/reddeer/issues/909/labels{/name}","comments_url":"https://api.github.com/repos/jboss-reddeer/reddeer/issues/909/comments","events_url":"https://api.github.com/repos/jboss-reddeer/reddeer/issues/909/events","html_url":"https://github.com/jboss-reddeer/reddeer/pull/909","id":51951888,"number":909,"title":"ljelinko_Requirements should cleanup after themselves","user":{"login":"rawagner","id":2078045,"avatar_url":"https://avatars.githubusercontent.com/u/2078045?v=3","gravatar_id":"","url":"https://api.github.com/users/rawagner","html_url":"https://github.com/rawagner","followers_url":"https://api.github.com/users/rawagner/followers","following_url":"https://api.github.com/users/rawagner/following{/other_user}","gists_url":"https://api.github.com/users/rawagner/gists{/gist_id}","starred_url":"https://api.github.com/users/rawagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rawagner/subscriptions","organizations_url":"https://api.github.com/users/rawagner/orgs","repos_url":"https://api.github.com/users/rawagner/repos","events_url":"https://api.github.com/users/rawagner/events{/privacy}","received_events_url":"https://api.github.com/users/rawagner/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jboss-reddeer/reddeer/labels/blocker","name":"blocker","color":"444444"},{"url":"https://api.github.com/repos/jboss-reddeer/reddeer/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":{"login":"rawagner","id":2078045,"avatar_url":"https://avatars.githubusercontent.com/u/2078045?v=3","gravatar_id":"","url":"https://api.github.com/users/rawagner","html_url":"https://github.com/rawagner","followers_url":"https://api.github.com/users/rawagner/followers","following_url":"https://api.github.com/users/rawagner/following{/other_user}","gists_url":"https://api.github.com/users/rawagner/gists{/gist_id}","starred_url":"https://api.github.com/users/rawagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rawagner/subscriptions","organizations_url":"https://api.github.com/users/rawagner/orgs","repos_url":"https://api.github.com/users/rawagner/repos","events_url":"https://api.github.com/users/rawagner/events{/privacy}","received_events_url":"https://api.github.com/users/rawagner/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/jboss-reddeer/reddeer/milestones/13","html_url":"https://github.com/jboss-reddeer/reddeer/milestones/0.7.0","labels_url":"https://api.github.com/repos/jboss-reddeer/reddeer/milestones/13/labels","id":778067,"number":13,"title":"0.7.0","description":"","creator":{"login":"jpeterka","id":998784,"avatar_url":"https://avatars.githubusercontent.com/u/998784?v=3","gravatar_id":"","url":"https://api.github.com/users/jpeterka","html_url":"https://github.com/jpeterka","followers_url":"https://api.github.com/users/jpeterka/followers","following_url":"https://api.github.com/users/jpeterka/following{/other_user}","gists_url":"https://api.github.com/users/jpeterka/gists{/gist_id}","starred_url":"https://api.github.com/users/jpeterka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpeterka/subscriptions","organizations_url":"https://api.github.com/users/jpeterka/orgs","repos_url":"https://api.github.com/users/jpeterka/repos","events_url":"https://api.github.com/users/jpeterka/events{/privacy}","received_events_url":"https://api.github.com/users/jpeterka/received_events","type":"User","site_admin":false},"open_issues":71,"closed_issues":130,"state":"open","created_at":"2014-09-04T07:57:52Z","updated_at":"2015-03-09T12:22:17Z","due_on":"2015-02-25T08:00:00Z","closed_at":null},"comments":2,"created_at":"2014-12-15T06:03:10Z","updated_at":"2015-03-09T13:01:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jboss-reddeer/reddeer/pulls/909","html_url":"https://github.com/jboss-reddeer/reddeer/pull/909","diff_url":"https://github.com/jboss-reddeer/reddeer/pull/909.diff","patch_url":"https://github.com/jboss-reddeer/reddeer/pull/909.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/jboss-reddeer/reddeer/issues/comments/77848624","html_url":"https://github.com/jboss-reddeer/reddeer/pull/909#issuecomment-77848624","issue_url":"https://api.github.com/repos/jboss-reddeer/reddeer/issues/909","id":77848624,"user":{"login":"ljelinkova","id":2078072,"avatar_url":"https://avatars.githubusercontent.com/u/2078072?v=3","gravatar_id":"","url":"https://api.github.com/users/ljelinkova","html_url":"https://github.com/ljelinkova","followers_url":"https://api.github.com/users/ljelinkova/followers","following_url":"https://api.github.com/users/ljelinkova/following{/other_user}","gists_url":"https://api.github.com/users/ljelinkova/gists{/gist_id}","starred_url":"https://api.github.com/users/ljelinkova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljelinkova/subscriptions","organizations_url":"https://api.github.com/users/ljelinkova/orgs","repos_url":"https://api.github.com/users/ljelinkova/repos","events_url":"https://api.github.com/users/ljelinkova/events{/privacy}","received_events_url":"https://api.github.com/users/ljelinkova/received_events","type":"User","site_admin":false},"created_at":"2015-03-09T13:01:08Z","updated_at":"2015-03-09T13:01:08Z","body":"- please add comments to public classes and methods\r\n- I think that requirements should be cleaned up after afterClass methods\r\n```\r\n    @Override\r\n    public void evaluate() throws Throwable {\r\n        requirements.cleanUp();\r\n        statement.evaluate();\r\n    }\r\n```\r\n- there is test suite `RequirementsTestSequenceSuite` testing the proper order of requirements fullfilling, @Before, @BeforeClass etc. methods, it should be extended also for cleanup method\r\n- in `ServerRequirement.cleanup()` I do not think you should have `lastServerConfiguration != null` in the condition\r\n- you should extend tests for `ServerRequirement` to test the cleanup behavior"}}