{"action":"created","comment":{"url":"https://api.github.com/repos/twitter/commons/pulls/comments/40162169","id":40162169,"diff_hunk":"@@ -103,7 +103,7 @@ def _add_auth_params(self, username, password):\n     urllib2.install_opener(opener)\n \n   def get_url(self, rb_id):\n-    return '%s/r/%s' % (self.url, rb_id)\n+    return '%sr/%s' % (self.url, rb_id)","path":"src/python/twitter/common/reviewboard/reviewboard.py","position":null,"original_position":5,"commit_id":"aeab1846d70589e5dfd3105f6b9aff01e9e1390f","original_commit_id":"177f797daf923a948da8f93e89e657e58b3a564a","user":{"login":"landism","id":7453991,"avatar_url":"https://avatars.githubusercontent.com/u/7453991?v=3","gravatar_id":"","url":"https://api.github.com/users/landism","html_url":"https://github.com/landism","followers_url":"https://api.github.com/users/landism/followers","following_url":"https://api.github.com/users/landism/following{/other_user}","gists_url":"https://api.github.com/users/landism/gists{/gist_id}","starred_url":"https://api.github.com/users/landism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/landism/subscriptions","organizations_url":"https://api.github.com/users/landism/orgs","repos_url":"https://api.github.com/users/landism/repos","events_url":"https://api.github.com/users/landism/events{/privacy}","received_events_url":"https://api.github.com/users/landism/received_events","type":"User","site_admin":false},"body":"I've changed it to use urljoin, which will produce the correct result regardless of whether self.url has a '/'.","created_at":"2015-09-23T00:41:12Z","updated_at":"2015-09-23T00:41:12Z","html_url":"https://github.com/twitter/commons/pull/412#discussion_r40162169","pull_request_url":"https://api.github.com/repos/twitter/commons/pulls/412","_links":{"self":{"href":"https://api.github.com/repos/twitter/commons/pulls/comments/40162169"},"html":{"href":"https://github.com/twitter/commons/pull/412#discussion_r40162169"},"pull_request":{"href":"https://api.github.com/repos/twitter/commons/pulls/412"}}},"pull_request":{"url":"https://api.github.com/repos/twitter/commons/pulls/412","id":45729948,"html_url":"https://github.com/twitter/commons/pull/412","diff_url":"https://github.com/twitter/commons/pull/412.diff","patch_url":"https://github.com/twitter/commons/pull/412.patch","issue_url":"https://api.github.com/repos/twitter/commons/issues/412","number":412,"state":"open","locked":false,"title":"eliminate double slash in reviewboard urls","user":{"login":"landism","id":7453991,"avatar_url":"https://avatars.githubusercontent.com/u/7453991?v=3","gravatar_id":"","url":"https://api.github.com/users/landism","html_url":"https://github.com/landism","followers_url":"https://api.github.com/users/landism/followers","following_url":"https://api.github.com/users/landism/following{/other_user}","gists_url":"https://api.github.com/users/landism/gists{/gist_id}","starred_url":"https://api.github.com/users/landism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/landism/subscriptions","organizations_url":"https://api.github.com/users/landism/orgs","repos_url":"https://api.github.com/users/landism/repos","events_url":"https://api.github.com/users/landism/events{/privacy}","received_events_url":"https://api.github.com/users/landism/received_events","type":"User","site_admin":false},"body":"`__init__` adds a '/' to the end of `url` if it doesn't have one (https://github.com/twitter/commons/blob/master/src/python/twitter/common/reviewboard/reviewboard.py#L79-L80), which causes `get_url` to return strings like reviewboard.twitter.biz//r/123456","created_at":"2015-09-22T23:29:17Z","updated_at":"2015-09-23T00:41:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e082771ba922f27469e922d934c4a6511a8fa8f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twitter/commons/pulls/412/commits","review_comments_url":"https://api.github.com/repos/twitter/commons/pulls/412/comments","review_comment_url":"https://api.github.com/repos/twitter/commons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twitter/commons/issues/412/comments","statuses_url":"https://api.github.com/repos/twitter/commons/statuses/aeab1846d70589e5dfd3105f6b9aff01e9e1390f","head":{"label":"landism:master","ref":"master","sha":"aeab1846d70589e5dfd3105f6b9aff01e9e1390f","user":{"login":"landism","id":7453991,"avatar_url":"https://avatars.githubusercontent.com/u/7453991?v=3","gravatar_id":"","url":"https://api.github.com/users/landism","html_url":"https://github.com/landism","followers_url":"https://api.github.com/users/landism/followers","following_url":"https://api.github.com/users/landism/following{/other_user}","gists_url":"https://api.github.com/users/landism/gists{/gist_id}","starred_url":"https://api.github.com/users/landism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/landism/subscriptions","organizations_url":"https://api.github.com/users/landism/orgs","repos_url":"https://api.github.com/users/landism/repos","events_url":"https://api.github.com/users/landism/events{/privacy}","received_events_url":"https://api.github.com/users/landism/received_events","type":"User","site_admin":false},"repo":{"id":19328971,"name":"commons","full_name":"landism/commons","owner":{"login":"landism","id":7453991,"avatar_url":"https://avatars.githubusercontent.com/u/7453991?v=3","gravatar_id":"","url":"https://api.github.com/users/landism","html_url":"https://github.com/landism","followers_url":"https://api.github.com/users/landism/followers","following_url":"https://api.github.com/users/landism/following{/other_user}","gists_url":"https://api.github.com/users/landism/gists{/gist_id}","starred_url":"https://api.github.com/users/landism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/landism/subscriptions","organizations_url":"https://api.github.com/users/landism/orgs","repos_url":"https://api.github.com/users/landism/repos","events_url":"https://api.github.com/users/landism/events{/privacy}","received_events_url":"https://api.github.com/users/landism/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/landism/commons","description":"Twitter common libraries for python and the JVM","fork":true,"url":"https://api.github.com/repos/landism/commons","forks_url":"https://api.github.com/repos/landism/commons/forks","keys_url":"https://api.github.com/repos/landism/commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/landism/commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/landism/commons/teams","hooks_url":"https://api.github.com/repos/landism/commons/hooks","issue_events_url":"https://api.github.com/repos/landism/commons/issues/events{/number}","events_url":"https://api.github.com/repos/landism/commons/events","assignees_url":"https://api.github.com/repos/landism/commons/assignees{/user}","branches_url":"https://api.github.com/repos/landism/commons/branches{/branch}","tags_url":"https://api.github.com/repos/landism/commons/tags","blobs_url":"https://api.github.com/repos/landism/commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/landism/commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/landism/commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/landism/commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/landism/commons/statuses/{sha}","languages_url":"https://api.github.com/repos/landism/commons/languages","stargazers_url":"https://api.github.com/repos/landism/commons/stargazers","contributors_url":"https://api.github.com/repos/landism/commons/contributors","subscribers_url":"https://api.github.com/repos/landism/commons/subscribers","subscription_url":"https://api.github.com/repos/landism/commons/subscription","commits_url":"https://api.github.com/repos/landism/commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/landism/commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/landism/commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/landism/commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/landism/commons/contents/{+path}","compare_url":"https://api.github.com/repos/landism/commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/landism/commons/merges","archive_url":"https://api.github.com/repos/landism/commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/landism/commons/downloads","issues_url":"https://api.github.com/repos/landism/commons/issues{/number}","pulls_url":"https://api.github.com/repos/landism/commons/pulls{/number}","milestones_url":"https://api.github.com/repos/landism/commons/milestones{/number}","notifications_url":"https://api.github.com/repos/landism/commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/landism/commons/labels{/name}","releases_url":"https://api.github.com/repos/landism/commons/releases{/id}","created_at":"2014-04-30T22:13:47Z","updated_at":"2015-09-22T23:26:09Z","pushed_at":"2015-09-23T00:33:50Z","git_url":"git://github.com/landism/commons.git","ssh_url":"git@github.com:landism/commons.git","clone_url":"https://github.com/landism/commons.git","svn_url":"https://github.com/landism/commons","homepage":"http://twitter.github.com/commons","size":114968,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"twitter:master","ref":"master","sha":"d4454f233914d0a7586da8c5d07575d8b63124fe","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":1424005,"name":"commons","full_name":"twitter/commons","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/commons","description":"Twitter common libraries for python and the JVM","fork":false,"url":"https://api.github.com/repos/twitter/commons","forks_url":"https://api.github.com/repos/twitter/commons/forks","keys_url":"https://api.github.com/repos/twitter/commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/commons/teams","hooks_url":"https://api.github.com/repos/twitter/commons/hooks","issue_events_url":"https://api.github.com/repos/twitter/commons/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/commons/events","assignees_url":"https://api.github.com/repos/twitter/commons/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/commons/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/commons/tags","blobs_url":"https://api.github.com/repos/twitter/commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/commons/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/commons/languages","stargazers_url":"https://api.github.com/repos/twitter/commons/stargazers","contributors_url":"https://api.github.com/repos/twitter/commons/contributors","subscribers_url":"https://api.github.com/repos/twitter/commons/subscribers","subscription_url":"https://api.github.com/repos/twitter/commons/subscription","commits_url":"https://api.github.com/repos/twitter/commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter/commons/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/commons/merges","archive_url":"https://api.github.com/repos/twitter/commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/commons/downloads","issues_url":"https://api.github.com/repos/twitter/commons/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/commons/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/commons/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/commons/labels{/name}","releases_url":"https://api.github.com/repos/twitter/commons/releases{/id}","created_at":"2011-03-01T00:10:02Z","updated_at":"2015-09-21T08:27:02Z","pushed_at":"2015-09-23T00:30:12Z","git_url":"git://github.com/twitter/commons.git","ssh_url":"git@github.com:twitter/commons.git","clone_url":"https://github.com/twitter/commons.git","svn_url":"https://github.com/twitter/commons","homepage":"http://twitter.github.com/commons","size":122042,"stargazers_count":999,"watchers_count":999,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":256,"mirror_url":null,"open_issues_count":89,"forks":256,"open_issues":89,"watchers":999,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/commons/pulls/412"},"html":{"href":"https://github.com/twitter/commons/pull/412"},"issue":{"href":"https://api.github.com/repos/twitter/commons/issues/412"},"comments":{"href":"https://api.github.com/repos/twitter/commons/issues/412/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/commons/pulls/412/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/commons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twitter/commons/pulls/412/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/commons/statuses/aeab1846d70589e5dfd3105f6b9aff01e9e1390f"}}}}