{"action":"created","issue":{"url":"https://api.github.com/repos/andreasvc/cplay/issues/6","labels_url":"https://api.github.com/repos/andreasvc/cplay/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/andreasvc/cplay/issues/6/comments","events_url":"https://api.github.com/repos/andreasvc/cplay/issues/6/events","html_url":"https://github.com/andreasvc/cplay/issues/6","id":63208557,"number":6,"title":"improved cooperation with cplay-ng","user":{"login":"xi","id":202576,"avatar_url":"https://avatars.githubusercontent.com/u/202576?v=3","gravatar_id":"","url":"https://api.github.com/users/xi","html_url":"https://github.com/xi","followers_url":"https://api.github.com/users/xi/followers","following_url":"https://api.github.com/users/xi/following{/other_user}","gists_url":"https://api.github.com/users/xi/gists{/gist_id}","starred_url":"https://api.github.com/users/xi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xi/subscriptions","organizations_url":"https://api.github.com/users/xi/orgs","repos_url":"https://api.github.com/users/xi/repos","events_url":"https://api.github.com/users/xi/events{/privacy}","received_events_url":"https://api.github.com/users/xi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-20T10:56:46Z","updated_at":"2015-03-21T19:02:36Z","closed_at":null,"body":"I am maintaining a fork of a cplay at https://github.com/xi/cplay-ng. I try to track what you do and port your changes to my fork and I noticed that you also ported some of my changes to your fork. We also did similar refactoring and both worked on python3 compatibility.\r\n\r\nUnfortuantly, our forks have diverged nevertheless. It is not simple to cherry-pick a commit from one repo to the other. So I would like to smooth out some of the discrepancies in order to ease collaboration .\r\n\r\nI did not yet have a detailed look at the code but there are some obvious problems:\r\n\r\n-  We use different coding styles and linters. You use pylint in a [Makefile](https://github.com/andreasvc/cplay/blob/master/Makefile). I use pyflakes with config in [setup.cfg](https://github.com/xi/cplay-ng/blob/master/setup.cfg).\r\n\r\n-  We use different formats for the README file. You use markdown. I use reStructureText because that is used on PyPI.\r\n\r\n-  I wrapped cplay in a python package, so I had to move `cplay` to `cplay/cplay.py` . That is probably the diversion that causes the most trouble.\r\n\r\nWhen these discrepancies have been resolved we could go on and look at the python code itself. For now I would like to get you feedback on (1) if you think we should do something to improve code portability between our projects and (2) what you think about the three issues described above. I would happily adjust my code or create pull request to yours."},"comment":{"url":"https://api.github.com/repos/andreasvc/cplay/issues/comments/84423536","html_url":"https://github.com/andreasvc/cplay/issues/6#issuecomment-84423536","issue_url":"https://api.github.com/repos/andreasvc/cplay/issues/6","id":84423536,"user":{"login":"xi","id":202576,"avatar_url":"https://avatars.githubusercontent.com/u/202576?v=3","gravatar_id":"","url":"https://api.github.com/users/xi","html_url":"https://github.com/xi","followers_url":"https://api.github.com/users/xi/followers","following_url":"https://api.github.com/users/xi/following{/other_user}","gists_url":"https://api.github.com/users/xi/gists{/gist_id}","starred_url":"https://api.github.com/users/xi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xi/subscriptions","organizations_url":"https://api.github.com/users/xi/orgs","repos_url":"https://api.github.com/users/xi/repos","events_url":"https://api.github.com/users/xi/events{/privacy}","received_events_url":"https://api.github.com/users/xi/received_events","type":"User","site_admin":false},"created_at":"2015-03-21T19:02:36Z","updated_at":"2015-03-21T19:02:36Z","body":"Thanks for your feedback!\r\n\r\n> It seems that pylint is more advanced than pyflakes, so I think pylint is preferable\r\n\r\nI have to correct myself, I actually use [flake8](https://pypi.python.org/pypi/flake8/2.4.0) which combines pyflakes and pep8.\r\n\r\nI have no problem with using pylint. But it seems to be very strict. When I ran `make lint` in your repo it showed quite some warnings. Do you have additional config somewhere or do you simply ignore the warnings?\r\n\r\n> Above all, I'd like to keep cplay simple and avoid feature creep\r\n\r\nI agree completely.\r\n"}}