{"action":"created","issue":{"url":"https://api.github.com/repos/Parsely/pykafka/issues/324","labels_url":"https://api.github.com/repos/Parsely/pykafka/issues/324/labels{/name}","comments_url":"https://api.github.com/repos/Parsely/pykafka/issues/324/comments","events_url":"https://api.github.com/repos/Parsely/pykafka/issues/324/events","html_url":"https://github.com/Parsely/pykafka/pull/324","id":114162852,"number":324,"title":"rebalance callbacks","user":{"login":"emmett9001","id":723615,"avatar_url":"https://avatars.githubusercontent.com/u/723615?v=3","gravatar_id":"","url":"https://api.github.com/users/emmett9001","html_url":"https://github.com/emmett9001","followers_url":"https://api.github.com/users/emmett9001/followers","following_url":"https://api.github.com/users/emmett9001/following{/other_user}","gists_url":"https://api.github.com/users/emmett9001/gists{/gist_id}","starred_url":"https://api.github.com/users/emmett9001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmett9001/subscriptions","organizations_url":"https://api.github.com/users/emmett9001/orgs","repos_url":"https://api.github.com/users/emmett9001/repos","events_url":"https://api.github.com/users/emmett9001/events{/privacy}","received_events_url":"https://api.github.com/users/emmett9001/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Parsely/pykafka/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/Parsely/pykafka/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"yungchin","id":780001,"avatar_url":"https://avatars.githubusercontent.com/u/780001?v=3","gravatar_id":"","url":"https://api.github.com/users/yungchin","html_url":"https://github.com/yungchin","followers_url":"https://api.github.com/users/yungchin/followers","following_url":"https://api.github.com/users/yungchin/following{/other_user}","gists_url":"https://api.github.com/users/yungchin/gists{/gist_id}","starred_url":"https://api.github.com/users/yungchin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yungchin/subscriptions","organizations_url":"https://api.github.com/users/yungchin/orgs","repos_url":"https://api.github.com/users/yungchin/repos","events_url":"https://api.github.com/users/yungchin/events{/privacy}","received_events_url":"https://api.github.com/users/yungchin/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/Parsely/pykafka/milestones/7","html_url":"https://github.com/Parsely/pykafka/milestones/2.1.0","labels_url":"https://api.github.com/repos/Parsely/pykafka/milestones/7/labels","id":1330012,"number":7,"title":"2.1.0","description":"","creator":{"login":"emmett9001","id":723615,"avatar_url":"https://avatars.githubusercontent.com/u/723615?v=3","gravatar_id":"","url":"https://api.github.com/users/emmett9001","html_url":"https://github.com/emmett9001","followers_url":"https://api.github.com/users/emmett9001/followers","following_url":"https://api.github.com/users/emmett9001/following{/other_user}","gists_url":"https://api.github.com/users/emmett9001/gists{/gist_id}","starred_url":"https://api.github.com/users/emmett9001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmett9001/subscriptions","organizations_url":"https://api.github.com/users/emmett9001/orgs","repos_url":"https://api.github.com/users/emmett9001/repos","events_url":"https://api.github.com/users/emmett9001/events{/privacy}","received_events_url":"https://api.github.com/users/emmett9001/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":4,"state":"open","created_at":"2015-09-29T21:46:21Z","updated_at":"2015-11-19T18:06:10Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2015-10-29T22:44:16Z","updated_at":"2015-11-19T19:48:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Parsely/pykafka/pulls/324","html_url":"https://github.com/Parsely/pykafka/pull/324","diff_url":"https://github.com/Parsely/pykafka/pull/324.diff","patch_url":"https://github.com/Parsely/pykafka/pull/324.patch"},"body":"This pull request adds callback notification hooks to the rebalance process. It's related to #288."},"comment":{"url":"https://api.github.com/repos/Parsely/pykafka/issues/comments/158174161","html_url":"https://github.com/Parsely/pykafka/pull/324#issuecomment-158174161","issue_url":"https://api.github.com/repos/Parsely/pykafka/issues/324","id":158174161,"user":{"login":"emmett9001","id":723615,"avatar_url":"https://avatars.githubusercontent.com/u/723615?v=3","gravatar_id":"","url":"https://api.github.com/users/emmett9001","html_url":"https://github.com/emmett9001","followers_url":"https://api.github.com/users/emmett9001/followers","following_url":"https://api.github.com/users/emmett9001/following{/other_user}","gists_url":"https://api.github.com/users/emmett9001/gists{/gist_id}","starred_url":"https://api.github.com/users/emmett9001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmett9001/subscriptions","organizations_url":"https://api.github.com/users/emmett9001/orgs","repos_url":"https://api.github.com/users/emmett9001/repos","events_url":"https://api.github.com/users/emmett9001/events{/privacy}","received_events_url":"https://api.github.com/users/emmett9001/received_events","type":"User","site_admin":false},"created_at":"2015-11-19T19:48:04Z","updated_at":"2015-11-19T19:48:04Z","body":"@yungchin I've implemented something comparable to the JVM consumer's interface, and I think it's ready for master. One possible difference that I don't actually think is a big deal is the fact that both of these callbacks are triggered after the rebalance is completed. Given that they're both still inside of the rebalance lock, we maintain the guarantee that consumption will not start until the callbacks return. Let me know what you think, and feel free to merge if you like."}}