{"action":"created","comment":{"url":"https://api.github.com/repos/jquery/qunit/pulls/comments/29057685","id":29057685,"diff_hunk":"@@ -659,19 +665,31 @@ QUnit.log(function( details ) {\n \t\t\t\"</pre></td></tr>\";\n \n \t\tif ( actual !== expected ) {\n+\n \t\t\tmessage += \"<tr class='test-actual'><th>Result: </th><td><pre>\" +\n-\t\t\t\tactual + \"</pre></td></tr>\" +\n-\t\t\t\t\"<tr class='test-diff'><th>Diff: </th><td><pre>\" +\n-\t\t\t\tQUnit.diff( expected, actual ) + \"</pre></td></tr>\";\n-\t\t} else {\n-\t\t\tif ( expected.indexOf( \"[object Array]\" ) !== -1 ||\n-\t\t\t\t\texpected.indexOf( \"[object Object]\" ) !== -1 ) {\n-\t\t\t\tmessage += \"<tr class='test-message'><th>Message: </th><td>\" +\n-\t\t\t\t\t\"Diff suppressed as the depth of object is more than current max depth (\" +\n-\t\t\t\t\tQUnit.config.maxDepth + \").<p>Hint: Use <code>QUnit.dump.maxDepth</code> to \" +\n-\t\t\t\t\t\" run with a higher max depth or <a href='\" + setUrl({ maxDepth: -1 }) + \"'>\" +\n-\t\t\t\t\t\"Rerun</a> without max depth.</p></td></tr>\";\n+\t\t\t\tactual + \"</pre></td></tr>\";\n+\n+\t\t\t// Don't show diff if actual or expected are booleans\n+\t\t\tif ( !( /^(true|false)$/.test( actual ) ) &&\n+\t\t\t\t\t!( /^(true|false)$/.test( expected ) ) ) {\n+\t\t\t\tdiff = QUnit.diff( expected, actual );\n+\t\t\t\tshowDiff = stripHtml( diff ).length !==\n+\t\t\t\t\tstripHtml( expected ).length +\n+\t\t\t\t\tstripHtml( actual ).length;\n+\t\t\t}\n+\n+\t\t\t// Don't show diff if expected and actual are totally different\n+\t\t\tif ( showDiff ) {\n+\t\t\t\tmessage += \"<tr class='test-diff'><th>Diff: </th><td><pre>\" +\n+\t\t\t\t\tdiff + \"</pre></td></tr>\";\n \t\t\t}\n+\t\t} else if ( expected.indexOf( \"[object Array]\" ) !== -1 ||\n+\t\t\t\texpected.indexOf( \"[object Object]\" ) !== -1 ) {\n+\t\t\tmessage += \"<tr class='test-message'><th>Message: </th><td>\" +\n+\t\t\t\t\"Diff suppressed as the depth of object is more than current max depth (\" +\n+\t\t\t\tQUnit.config.maxDepth + \").<p>Hint: Use <code>QUnit.dump.maxDepth</code> to \" +","path":"reporter/html.js","position":54,"original_position":54,"commit_id":"2093e461d55fe03f18726a2eec471834be719155","original_commit_id":"2093e461d55fe03f18726a2eec471834be719155","user":{"login":"shivamdixit","id":3061095,"avatar_url":"https://avatars.githubusercontent.com/u/3061095?v=3","gravatar_id":"","url":"https://api.github.com/users/shivamdixit","html_url":"https://github.com/shivamdixit","followers_url":"https://api.github.com/users/shivamdixit/followers","following_url":"https://api.github.com/users/shivamdixit/following{/other_user}","gists_url":"https://api.github.com/users/shivamdixit/gists{/gist_id}","starred_url":"https://api.github.com/users/shivamdixit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivamdixit/subscriptions","organizations_url":"https://api.github.com/users/shivamdixit/orgs","repos_url":"https://api.github.com/users/shivamdixit/repos","events_url":"https://api.github.com/users/shivamdixit/events{/privacy}","received_events_url":"https://api.github.com/users/shivamdixit/received_events","type":"User","site_admin":false},"body":"I just tried to change it to `QUnit.config.maxDepth` but strangely it din't work, whereas using `QUnit.dump.maxDepth` works fine. I guess this is happening because `dump.maxDepth` is initialized with default `config.maxDepth` in file `dump.js` and then the value of `config.maxDepth` is changed. Hence I got a message which looks like:\r\n\r\n```\r\nDiff suppressed as the depth of object is more than current max depth (infinity)\r\n```\r\nHowever specifying `maxDepth` in GET parameters works fine because if parameters are present, the value of `config.maxDepth` is updated in file `core.js` before initialization in `dump.js`.","created_at":"2015-04-24T15:22:02Z","updated_at":"2015-04-24T15:22:02Z","html_url":"https://github.com/jquery/qunit/pull/802#discussion_r29057685","pull_request_url":"https://api.github.com/repos/jquery/qunit/pulls/802","_links":{"self":{"href":"https://api.github.com/repos/jquery/qunit/pulls/comments/29057685"},"html":{"href":"https://github.com/jquery/qunit/pull/802#discussion_r29057685"},"pull_request":{"href":"https://api.github.com/repos/jquery/qunit/pulls/802"}}},"pull_request":{"url":"https://api.github.com/repos/jquery/qunit/pulls/802","id":32136004,"html_url":"https://github.com/jquery/qunit/pull/802","diff_url":"https://github.com/jquery/qunit/pull/802.diff","patch_url":"https://github.com/jquery/qunit/pull/802.patch","issue_url":"https://api.github.com/repos/jquery/qunit/issues/802","number":802,"state":"open","locked":false,"title":"Show diff only when it helps","user":{"login":"shivamdixit","id":3061095,"avatar_url":"https://avatars.githubusercontent.com/u/3061095?v=3","gravatar_id":"","url":"https://api.github.com/users/shivamdixit","html_url":"https://github.com/shivamdixit","followers_url":"https://api.github.com/users/shivamdixit/followers","following_url":"https://api.github.com/users/shivamdixit/following{/other_user}","gists_url":"https://api.github.com/users/shivamdixit/gists{/gist_id}","starred_url":"https://api.github.com/users/shivamdixit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivamdixit/subscriptions","organizations_url":"https://api.github.com/users/shivamdixit/orgs","repos_url":"https://api.github.com/users/shivamdixit/repos","events_url":"https://api.github.com/users/shivamdixit/events{/privacy}","received_events_url":"https://api.github.com/users/shivamdixit/received_events","type":"User","site_admin":false},"body":"Follow up of #786 ","created_at":"2015-03-27T19:06:17Z","updated_at":"2015-04-24T15:22:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e37ae36da7a7f13029bd9560885f31353b2ce188","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jquery/qunit/pulls/802/commits","review_comments_url":"https://api.github.com/repos/jquery/qunit/pulls/802/comments","review_comment_url":"https://api.github.com/repos/jquery/qunit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jquery/qunit/issues/802/comments","statuses_url":"https://api.github.com/repos/jquery/qunit/statuses/2093e461d55fe03f18726a2eec471834be719155","head":{"label":"leobalter:shivamdixit-335-show-diff-only-when-it-helps","ref":"shivamdixit-335-show-diff-only-when-it-helps","sha":"2093e461d55fe03f18726a2eec471834be719155","user":{"login":"leobalter","id":301201,"avatar_url":"https://avatars.githubusercontent.com/u/301201?v=3","gravatar_id":"","url":"https://api.github.com/users/leobalter","html_url":"https://github.com/leobalter","followers_url":"https://api.github.com/users/leobalter/followers","following_url":"https://api.github.com/users/leobalter/following{/other_user}","gists_url":"https://api.github.com/users/leobalter/gists{/gist_id}","starred_url":"https://api.github.com/users/leobalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leobalter/subscriptions","organizations_url":"https://api.github.com/users/leobalter/orgs","repos_url":"https://api.github.com/users/leobalter/repos","events_url":"https://api.github.com/users/leobalter/events{/privacy}","received_events_url":"https://api.github.com/users/leobalter/received_events","type":"User","site_admin":false},"repo":{"id":15093934,"name":"qunit","full_name":"leobalter/qunit","owner":{"login":"leobalter","id":301201,"avatar_url":"https://avatars.githubusercontent.com/u/301201?v=3","gravatar_id":"","url":"https://api.github.com/users/leobalter","html_url":"https://github.com/leobalter","followers_url":"https://api.github.com/users/leobalter/followers","following_url":"https://api.github.com/users/leobalter/following{/other_user}","gists_url":"https://api.github.com/users/leobalter/gists{/gist_id}","starred_url":"https://api.github.com/users/leobalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leobalter/subscriptions","organizations_url":"https://api.github.com/users/leobalter/orgs","repos_url":"https://api.github.com/users/leobalter/repos","events_url":"https://api.github.com/users/leobalter/events{/privacy}","received_events_url":"https://api.github.com/users/leobalter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leobalter/qunit","description":"An easy-to-use JavaScript Unit Testing framework.","fork":true,"url":"https://api.github.com/repos/leobalter/qunit","forks_url":"https://api.github.com/repos/leobalter/qunit/forks","keys_url":"https://api.github.com/repos/leobalter/qunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leobalter/qunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leobalter/qunit/teams","hooks_url":"https://api.github.com/repos/leobalter/qunit/hooks","issue_events_url":"https://api.github.com/repos/leobalter/qunit/issues/events{/number}","events_url":"https://api.github.com/repos/leobalter/qunit/events","assignees_url":"https://api.github.com/repos/leobalter/qunit/assignees{/user}","branches_url":"https://api.github.com/repos/leobalter/qunit/branches{/branch}","tags_url":"https://api.github.com/repos/leobalter/qunit/tags","blobs_url":"https://api.github.com/repos/leobalter/qunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leobalter/qunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leobalter/qunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/leobalter/qunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leobalter/qunit/statuses/{sha}","languages_url":"https://api.github.com/repos/leobalter/qunit/languages","stargazers_url":"https://api.github.com/repos/leobalter/qunit/stargazers","contributors_url":"https://api.github.com/repos/leobalter/qunit/contributors","subscribers_url":"https://api.github.com/repos/leobalter/qunit/subscribers","subscription_url":"https://api.github.com/repos/leobalter/qunit/subscription","commits_url":"https://api.github.com/repos/leobalter/qunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/leobalter/qunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/leobalter/qunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/leobalter/qunit/issues/comments{/number}","contents_url":"https://api.github.com/repos/leobalter/qunit/contents/{+path}","compare_url":"https://api.github.com/repos/leobalter/qunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leobalter/qunit/merges","archive_url":"https://api.github.com/repos/leobalter/qunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leobalter/qunit/downloads","issues_url":"https://api.github.com/repos/leobalter/qunit/issues{/number}","pulls_url":"https://api.github.com/repos/leobalter/qunit/pulls{/number}","milestones_url":"https://api.github.com/repos/leobalter/qunit/milestones{/number}","notifications_url":"https://api.github.com/repos/leobalter/qunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leobalter/qunit/labels{/name}","releases_url":"https://api.github.com/repos/leobalter/qunit/releases{/id}","created_at":"2013-12-11T00:34:30Z","updated_at":"2015-04-14T15:26:48Z","pushed_at":"2015-04-22T19:10:38Z","git_url":"git://github.com/leobalter/qunit.git","ssh_url":"git@github.com:leobalter/qunit.git","clone_url":"https://github.com/leobalter/qunit.git","svn_url":"https://github.com/leobalter/qunit","homepage":"http://qunitjs.com","size":2449,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jquery:master","ref":"master","sha":"111654bf36e524168e9a49cccc8ccf5c3f44fe9b","user":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"repo":{"id":259691,"name":"qunit","full_name":"jquery/qunit","owner":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jquery/qunit","description":"An easy-to-use JavaScript Unit Testing framework.","fork":false,"url":"https://api.github.com/repos/jquery/qunit","forks_url":"https://api.github.com/repos/jquery/qunit/forks","keys_url":"https://api.github.com/repos/jquery/qunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jquery/qunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jquery/qunit/teams","hooks_url":"https://api.github.com/repos/jquery/qunit/hooks","issue_events_url":"https://api.github.com/repos/jquery/qunit/issues/events{/number}","events_url":"https://api.github.com/repos/jquery/qunit/events","assignees_url":"https://api.github.com/repos/jquery/qunit/assignees{/user}","branches_url":"https://api.github.com/repos/jquery/qunit/branches{/branch}","tags_url":"https://api.github.com/repos/jquery/qunit/tags","blobs_url":"https://api.github.com/repos/jquery/qunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jquery/qunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jquery/qunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/jquery/qunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jquery/qunit/statuses/{sha}","languages_url":"https://api.github.com/repos/jquery/qunit/languages","stargazers_url":"https://api.github.com/repos/jquery/qunit/stargazers","contributors_url":"https://api.github.com/repos/jquery/qunit/contributors","subscribers_url":"https://api.github.com/repos/jquery/qunit/subscribers","subscription_url":"https://api.github.com/repos/jquery/qunit/subscription","commits_url":"https://api.github.com/repos/jquery/qunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/jquery/qunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/jquery/qunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/jquery/qunit/issues/comments{/number}","contents_url":"https://api.github.com/repos/jquery/qunit/contents/{+path}","compare_url":"https://api.github.com/repos/jquery/qunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jquery/qunit/merges","archive_url":"https://api.github.com/repos/jquery/qunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jquery/qunit/downloads","issues_url":"https://api.github.com/repos/jquery/qunit/issues{/number}","pulls_url":"https://api.github.com/repos/jquery/qunit/pulls{/number}","milestones_url":"https://api.github.com/repos/jquery/qunit/milestones{/number}","notifications_url":"https://api.github.com/repos/jquery/qunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jquery/qunit/labels{/name}","releases_url":"https://api.github.com/repos/jquery/qunit/releases{/id}","created_at":"2009-07-24T16:26:23Z","updated_at":"2015-04-24T12:03:50Z","pushed_at":"2015-04-24T13:38:28Z","git_url":"git://github.com/jquery/qunit.git","ssh_url":"git@github.com:jquery/qunit.git","clone_url":"https://github.com/jquery/qunit.git","svn_url":"https://github.com/jquery/qunit","homepage":"http://qunitjs.com","size":5685,"stargazers_count":3152,"watchers_count":3152,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":644,"mirror_url":null,"open_issues_count":62,"forks":644,"open_issues":62,"watchers":3152,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jquery/qunit/pulls/802"},"html":{"href":"https://github.com/jquery/qunit/pull/802"},"issue":{"href":"https://api.github.com/repos/jquery/qunit/issues/802"},"comments":{"href":"https://api.github.com/repos/jquery/qunit/issues/802/comments"},"review_comments":{"href":"https://api.github.com/repos/jquery/qunit/pulls/802/comments"},"review_comment":{"href":"https://api.github.com/repos/jquery/qunit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jquery/qunit/pulls/802/commits"},"statuses":{"href":"https://api.github.com/repos/jquery/qunit/statuses/2093e461d55fe03f18726a2eec471834be719155"}}}}