{"action":"closed","number":201,"pull_request":{"url":"https://api.github.com/repos/newrelic/node-newrelic/pulls/201","id":44941385,"html_url":"https://github.com/newrelic/node-newrelic/pull/201","diff_url":"https://github.com/newrelic/node-newrelic/pull/201.diff","patch_url":"https://github.com/newrelic/node-newrelic/pull/201.patch","issue_url":"https://api.github.com/repos/newrelic/node-newrelic/issues/201","number":201,"state":"closed","locked":false,"title":"Avoid logging NaN when Express version is not detected","user":{"login":"tregagnon","id":188748,"avatar_url":"https://avatars.githubusercontent.com/u/188748?v=3","gravatar_id":"","url":"https://api.github.com/users/tregagnon","html_url":"https://github.com/tregagnon","followers_url":"https://api.github.com/users/tregagnon/followers","following_url":"https://api.github.com/users/tregagnon/following{/other_user}","gists_url":"https://api.github.com/users/tregagnon/gists{/gist_id}","starred_url":"https://api.github.com/users/tregagnon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tregagnon/subscriptions","organizations_url":"https://api.github.com/users/tregagnon/orgs","repos_url":"https://api.github.com/users/tregagnon/repos","events_url":"https://api.github.com/users/tregagnon/events{/privacy}","received_events_url":"https://api.github.com/users/tregagnon/received_events","type":"User","site_admin":false},"body":"We are debugging the Express instrumentation inside our app, and we are seeing this logged message: \r\n> Unrecognized version NaN of Express detected; not instrumenting\r\n\r\nThis PR avoids writing NaN in the message, by outputting the detected version as a String.\r\n\r\nIn the instrumentation code, the Express version is handled as a String.","created_at":"2015-09-14T15:07:07Z","updated_at":"2015-10-16T00:13:23Z","closed_at":"2015-10-16T00:13:23Z","merged_at":null,"merge_commit_sha":"23d76981afee1709b2298c59960e9d3d95fedf95","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/newrelic/node-newrelic/pulls/201/commits","review_comments_url":"https://api.github.com/repos/newrelic/node-newrelic/pulls/201/comments","review_comment_url":"https://api.github.com/repos/newrelic/node-newrelic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/newrelic/node-newrelic/issues/201/comments","statuses_url":"https://api.github.com/repos/newrelic/node-newrelic/statuses/2912abc111304f1a1c657a1777f743950f4a15c1","head":{"label":"tregagnon:avoid-express-version-logger-nan","ref":"avoid-express-version-logger-nan","sha":"2912abc111304f1a1c657a1777f743950f4a15c1","user":{"login":"tregagnon","id":188748,"avatar_url":"https://avatars.githubusercontent.com/u/188748?v=3","gravatar_id":"","url":"https://api.github.com/users/tregagnon","html_url":"https://github.com/tregagnon","followers_url":"https://api.github.com/users/tregagnon/followers","following_url":"https://api.github.com/users/tregagnon/following{/other_user}","gists_url":"https://api.github.com/users/tregagnon/gists{/gist_id}","starred_url":"https://api.github.com/users/tregagnon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tregagnon/subscriptions","organizations_url":"https://api.github.com/users/tregagnon/orgs","repos_url":"https://api.github.com/users/tregagnon/repos","events_url":"https://api.github.com/users/tregagnon/events{/privacy}","received_events_url":"https://api.github.com/users/tregagnon/received_events","type":"User","site_admin":false},"repo":{"id":42454853,"name":"node-newrelic","full_name":"tregagnon/node-newrelic","owner":{"login":"tregagnon","id":188748,"avatar_url":"https://avatars.githubusercontent.com/u/188748?v=3","gravatar_id":"","url":"https://api.github.com/users/tregagnon","html_url":"https://github.com/tregagnon","followers_url":"https://api.github.com/users/tregagnon/followers","following_url":"https://api.github.com/users/tregagnon/following{/other_user}","gists_url":"https://api.github.com/users/tregagnon/gists{/gist_id}","starred_url":"https://api.github.com/users/tregagnon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tregagnon/subscriptions","organizations_url":"https://api.github.com/users/tregagnon/orgs","repos_url":"https://api.github.com/users/tregagnon/repos","events_url":"https://api.github.com/users/tregagnon/events{/privacy}","received_events_url":"https://api.github.com/users/tregagnon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tregagnon/node-newrelic","description":"New Relic Node.js agent code base. Developers are welcome to create pull requests here, please see our contributing guidelines. For New Relic technical support, please go to http://support.newrelic.com.","fork":true,"url":"https://api.github.com/repos/tregagnon/node-newrelic","forks_url":"https://api.github.com/repos/tregagnon/node-newrelic/forks","keys_url":"https://api.github.com/repos/tregagnon/node-newrelic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tregagnon/node-newrelic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tregagnon/node-newrelic/teams","hooks_url":"https://api.github.com/repos/tregagnon/node-newrelic/hooks","issue_events_url":"https://api.github.com/repos/tregagnon/node-newrelic/issues/events{/number}","events_url":"https://api.github.com/repos/tregagnon/node-newrelic/events","assignees_url":"https://api.github.com/repos/tregagnon/node-newrelic/assignees{/user}","branches_url":"https://api.github.com/repos/tregagnon/node-newrelic/branches{/branch}","tags_url":"https://api.github.com/repos/tregagnon/node-newrelic/tags","blobs_url":"https://api.github.com/repos/tregagnon/node-newrelic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tregagnon/node-newrelic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tregagnon/node-newrelic/git/refs{/sha}","trees_url":"https://api.github.com/repos/tregagnon/node-newrelic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tregagnon/node-newrelic/statuses/{sha}","languages_url":"https://api.github.com/repos/tregagnon/node-newrelic/languages","stargazers_url":"https://api.github.com/repos/tregagnon/node-newrelic/stargazers","contributors_url":"https://api.github.com/repos/tregagnon/node-newrelic/contributors","subscribers_url":"https://api.github.com/repos/tregagnon/node-newrelic/subscribers","subscription_url":"https://api.github.com/repos/tregagnon/node-newrelic/subscription","commits_url":"https://api.github.com/repos/tregagnon/node-newrelic/commits{/sha}","git_commits_url":"https://api.github.com/repos/tregagnon/node-newrelic/git/commits{/sha}","comments_url":"https://api.github.com/repos/tregagnon/node-newrelic/comments{/number}","issue_comment_url":"https://api.github.com/repos/tregagnon/node-newrelic/issues/comments{/number}","contents_url":"https://api.github.com/repos/tregagnon/node-newrelic/contents/{+path}","compare_url":"https://api.github.com/repos/tregagnon/node-newrelic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tregagnon/node-newrelic/merges","archive_url":"https://api.github.com/repos/tregagnon/node-newrelic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tregagnon/node-newrelic/downloads","issues_url":"https://api.github.com/repos/tregagnon/node-newrelic/issues{/number}","pulls_url":"https://api.github.com/repos/tregagnon/node-newrelic/pulls{/number}","milestones_url":"https://api.github.com/repos/tregagnon/node-newrelic/milestones{/number}","notifications_url":"https://api.github.com/repos/tregagnon/node-newrelic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tregagnon/node-newrelic/labels{/name}","releases_url":"https://api.github.com/repos/tregagnon/node-newrelic/releases{/id}","created_at":"2015-09-14T14:46:40Z","updated_at":"2015-09-14T14:46:41Z","pushed_at":"2015-09-14T14:58:27Z","git_url":"git://github.com/tregagnon/node-newrelic.git","ssh_url":"git@github.com:tregagnon/node-newrelic.git","clone_url":"https://github.com/tregagnon/node-newrelic.git","svn_url":"https://github.com/tregagnon/node-newrelic","homepage":"","size":5161,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"newrelic:master","ref":"master","sha":"9d5943047760ed93be51f48dc21e6e9c777254c1","user":{"login":"newrelic","id":31739,"avatar_url":"https://avatars.githubusercontent.com/u/31739?v=3","gravatar_id":"","url":"https://api.github.com/users/newrelic","html_url":"https://github.com/newrelic","followers_url":"https://api.github.com/users/newrelic/followers","following_url":"https://api.github.com/users/newrelic/following{/other_user}","gists_url":"https://api.github.com/users/newrelic/gists{/gist_id}","starred_url":"https://api.github.com/users/newrelic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newrelic/subscriptions","organizations_url":"https://api.github.com/users/newrelic/orgs","repos_url":"https://api.github.com/users/newrelic/repos","events_url":"https://api.github.com/users/newrelic/events{/privacy}","received_events_url":"https://api.github.com/users/newrelic/received_events","type":"Organization","site_admin":false},"repo":{"id":7431305,"name":"node-newrelic","full_name":"newrelic/node-newrelic","owner":{"login":"newrelic","id":31739,"avatar_url":"https://avatars.githubusercontent.com/u/31739?v=3","gravatar_id":"","url":"https://api.github.com/users/newrelic","html_url":"https://github.com/newrelic","followers_url":"https://api.github.com/users/newrelic/followers","following_url":"https://api.github.com/users/newrelic/following{/other_user}","gists_url":"https://api.github.com/users/newrelic/gists{/gist_id}","starred_url":"https://api.github.com/users/newrelic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newrelic/subscriptions","organizations_url":"https://api.github.com/users/newrelic/orgs","repos_url":"https://api.github.com/users/newrelic/repos","events_url":"https://api.github.com/users/newrelic/events{/privacy}","received_events_url":"https://api.github.com/users/newrelic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/newrelic/node-newrelic","description":"New Relic Node.js agent code base. Developers are welcome to create pull requests here, please see our contributing guidelines. For New Relic technical support, please go to http://support.newrelic.com.","fork":false,"url":"https://api.github.com/repos/newrelic/node-newrelic","forks_url":"https://api.github.com/repos/newrelic/node-newrelic/forks","keys_url":"https://api.github.com/repos/newrelic/node-newrelic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/newrelic/node-newrelic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/newrelic/node-newrelic/teams","hooks_url":"https://api.github.com/repos/newrelic/node-newrelic/hooks","issue_events_url":"https://api.github.com/repos/newrelic/node-newrelic/issues/events{/number}","events_url":"https://api.github.com/repos/newrelic/node-newrelic/events","assignees_url":"https://api.github.com/repos/newrelic/node-newrelic/assignees{/user}","branches_url":"https://api.github.com/repos/newrelic/node-newrelic/branches{/branch}","tags_url":"https://api.github.com/repos/newrelic/node-newrelic/tags","blobs_url":"https://api.github.com/repos/newrelic/node-newrelic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/newrelic/node-newrelic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/newrelic/node-newrelic/git/refs{/sha}","trees_url":"https://api.github.com/repos/newrelic/node-newrelic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/newrelic/node-newrelic/statuses/{sha}","languages_url":"https://api.github.com/repos/newrelic/node-newrelic/languages","stargazers_url":"https://api.github.com/repos/newrelic/node-newrelic/stargazers","contributors_url":"https://api.github.com/repos/newrelic/node-newrelic/contributors","subscribers_url":"https://api.github.com/repos/newrelic/node-newrelic/subscribers","subscription_url":"https://api.github.com/repos/newrelic/node-newrelic/subscription","commits_url":"https://api.github.com/repos/newrelic/node-newrelic/commits{/sha}","git_commits_url":"https://api.github.com/repos/newrelic/node-newrelic/git/commits{/sha}","comments_url":"https://api.github.com/repos/newrelic/node-newrelic/comments{/number}","issue_comment_url":"https://api.github.com/repos/newrelic/node-newrelic/issues/comments{/number}","contents_url":"https://api.github.com/repos/newrelic/node-newrelic/contents/{+path}","compare_url":"https://api.github.com/repos/newrelic/node-newrelic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/newrelic/node-newrelic/merges","archive_url":"https://api.github.com/repos/newrelic/node-newrelic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/newrelic/node-newrelic/downloads","issues_url":"https://api.github.com/repos/newrelic/node-newrelic/issues{/number}","pulls_url":"https://api.github.com/repos/newrelic/node-newrelic/pulls{/number}","milestones_url":"https://api.github.com/repos/newrelic/node-newrelic/milestones{/number}","notifications_url":"https://api.github.com/repos/newrelic/node-newrelic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/newrelic/node-newrelic/labels{/name}","releases_url":"https://api.github.com/repos/newrelic/node-newrelic/releases{/id}","created_at":"2013-01-03T22:19:32Z","updated_at":"2015-10-15T02:46:04Z","pushed_at":"2015-10-14T21:06:10Z","git_url":"git://github.com/newrelic/node-newrelic.git","ssh_url":"git@github.com:newrelic/node-newrelic.git","clone_url":"https://github.com/newrelic/node-newrelic.git","svn_url":"https://github.com/newrelic/node-newrelic","homepage":"","size":6097,"stargazers_count":400,"watchers_count":400,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":138,"mirror_url":null,"open_issues_count":6,"forks":138,"open_issues":6,"watchers":400,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/newrelic/node-newrelic/pulls/201"},"html":{"href":"https://github.com/newrelic/node-newrelic/pull/201"},"issue":{"href":"https://api.github.com/repos/newrelic/node-newrelic/issues/201"},"comments":{"href":"https://api.github.com/repos/newrelic/node-newrelic/issues/201/comments"},"review_comments":{"href":"https://api.github.com/repos/newrelic/node-newrelic/pulls/201/comments"},"review_comment":{"href":"https://api.github.com/repos/newrelic/node-newrelic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/newrelic/node-newrelic/pulls/201/commits"},"statuses":{"href":"https://api.github.com/repos/newrelic/node-newrelic/statuses/2912abc111304f1a1c657a1777f743950f4a15c1"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}