{"action":"created","comment":{"url":"https://api.github.com/repos/calagator/calagator/pulls/comments/27439086","id":27439086,"diff_hunk":"@@ -11,7 +11,9 @@\n \n ############################################################## */\n \n-@import 'datepicker';\n+/*\n+ *= reuqire jquery-ui/datepicker","path":"app/assets/stylesheets/calagator/forms.scss","position":6,"original_position":6,"commit_id":"9f7a1da9834f46cc8db26cef50d57bd59c864cd3","original_commit_id":"9f7a1da9834f46cc8db26cef50d57bd59c864cd3","user":{"login":"botandrose","id":17391,"avatar_url":"https://avatars.githubusercontent.com/u/17391?v=3","gravatar_id":"","url":"https://api.github.com/users/botandrose","html_url":"https://github.com/botandrose","followers_url":"https://api.github.com/users/botandrose/followers","following_url":"https://api.github.com/users/botandrose/following{/other_user}","gists_url":"https://api.github.com/users/botandrose/gists{/gist_id}","starred_url":"https://api.github.com/users/botandrose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/botandrose/subscriptions","organizations_url":"https://api.github.com/users/botandrose/orgs","repos_url":"https://api.github.com/users/botandrose/repos","events_url":"https://api.github.com/users/botandrose/events{/privacy}","received_events_url":"https://api.github.com/users/botandrose/received_events","type":"User","site_admin":false},"body":"Good catch on the typo! Too bad the tests can't catch it. :/\r\n\r\nThe limitation with the sprockets require syntax is that each sass file is evaluated in its own isolated context, so any sass variables defined don't propagate. However, that doesn't apply here, so I think this syntax is okay.\r\n\r\nThat said, it's simpler to not know or care about that limitation and simply use import everywhere. So I think that's a valid case for a future PR.","created_at":"2015-03-30T22:42:02Z","updated_at":"2015-03-30T22:42:02Z","html_url":"https://github.com/calagator/calagator/pull/351#discussion_r27439086","pull_request_url":"https://api.github.com/repos/calagator/calagator/pulls/351","_links":{"self":{"href":"https://api.github.com/repos/calagator/calagator/pulls/comments/27439086"},"html":{"href":"https://github.com/calagator/calagator/pull/351#discussion_r27439086"},"pull_request":{"href":"https://api.github.com/repos/calagator/calagator/pulls/351"}}},"pull_request":{"url":"https://api.github.com/repos/calagator/calagator/pulls/351","id":32268349,"html_url":"https://github.com/calagator/calagator/pull/351","diff_url":"https://github.com/calagator/calagator/pull/351.diff","patch_url":"https://github.com/calagator/calagator/pull/351.patch","issue_url":"https://api.github.com/repos/calagator/calagator/issues/351","number":351,"state":"open","locked":false,"title":"Support Rails 3.2 and Rails 4.0","user":{"login":"botandrose","id":17391,"avatar_url":"https://avatars.githubusercontent.com/u/17391?v=3","gravatar_id":"","url":"https://api.github.com/users/botandrose","html_url":"https://github.com/botandrose","followers_url":"https://api.github.com/users/botandrose/followers","following_url":"https://api.github.com/users/botandrose/following{/other_user}","gists_url":"https://api.github.com/users/botandrose/gists{/gist_id}","starred_url":"https://api.github.com/users/botandrose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/botandrose/subscriptions","organizations_url":"https://api.github.com/users/botandrose/orgs","repos_url":"https://api.github.com/users/botandrose/repos","events_url":"https://api.github.com/users/botandrose/events{/privacy}","received_events_url":"https://api.github.com/users/botandrose/received_events","type":"User","site_admin":false},"body":"Got something working here... with a lot of deprecation warnings when running under 4.0. We may need to drop 3.2 support in order to support 4.1+, due to 4.1 removing a lot of those deprecated APIs.","created_at":"2015-03-30T21:15:48Z","updated_at":"2015-03-30T22:42:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a76251465a9eabae41a51e75251d982df454279","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/calagator/calagator/pulls/351/commits","review_comments_url":"https://api.github.com/repos/calagator/calagator/pulls/351/comments","review_comment_url":"https://api.github.com/repos/calagator/calagator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/calagator/calagator/issues/351/comments","statuses_url":"https://api.github.com/repos/calagator/calagator/statuses/9f7a1da9834f46cc8db26cef50d57bd59c864cd3","head":{"label":"botandrose:rails4","ref":"rails4","sha":"9f7a1da9834f46cc8db26cef50d57bd59c864cd3","user":{"login":"botandrose","id":17391,"avatar_url":"https://avatars.githubusercontent.com/u/17391?v=3","gravatar_id":"","url":"https://api.github.com/users/botandrose","html_url":"https://github.com/botandrose","followers_url":"https://api.github.com/users/botandrose/followers","following_url":"https://api.github.com/users/botandrose/following{/other_user}","gists_url":"https://api.github.com/users/botandrose/gists{/gist_id}","starred_url":"https://api.github.com/users/botandrose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/botandrose/subscriptions","organizations_url":"https://api.github.com/users/botandrose/orgs","repos_url":"https://api.github.com/users/botandrose/repos","events_url":"https://api.github.com/users/botandrose/events{/privacy}","received_events_url":"https://api.github.com/users/botandrose/received_events","type":"User","site_admin":false},"repo":{"id":21151805,"name":"calagator","full_name":"botandrose/calagator","owner":{"login":"botandrose","id":17391,"avatar_url":"https://avatars.githubusercontent.com/u/17391?v=3","gravatar_id":"","url":"https://api.github.com/users/botandrose","html_url":"https://github.com/botandrose","followers_url":"https://api.github.com/users/botandrose/followers","following_url":"https://api.github.com/users/botandrose/following{/other_user}","gists_url":"https://api.github.com/users/botandrose/gists{/gist_id}","starred_url":"https://api.github.com/users/botandrose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/botandrose/subscriptions","organizations_url":"https://api.github.com/users/botandrose/orgs","repos_url":"https://api.github.com/users/botandrose/repos","events_url":"https://api.github.com/users/botandrose/events{/privacy}","received_events_url":"https://api.github.com/users/botandrose/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/botandrose/calagator","description":"An event aggregator based in Portland, OR","fork":true,"url":"https://api.github.com/repos/botandrose/calagator","forks_url":"https://api.github.com/repos/botandrose/calagator/forks","keys_url":"https://api.github.com/repos/botandrose/calagator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/botandrose/calagator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/botandrose/calagator/teams","hooks_url":"https://api.github.com/repos/botandrose/calagator/hooks","issue_events_url":"https://api.github.com/repos/botandrose/calagator/issues/events{/number}","events_url":"https://api.github.com/repos/botandrose/calagator/events","assignees_url":"https://api.github.com/repos/botandrose/calagator/assignees{/user}","branches_url":"https://api.github.com/repos/botandrose/calagator/branches{/branch}","tags_url":"https://api.github.com/repos/botandrose/calagator/tags","blobs_url":"https://api.github.com/repos/botandrose/calagator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/botandrose/calagator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/botandrose/calagator/git/refs{/sha}","trees_url":"https://api.github.com/repos/botandrose/calagator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/botandrose/calagator/statuses/{sha}","languages_url":"https://api.github.com/repos/botandrose/calagator/languages","stargazers_url":"https://api.github.com/repos/botandrose/calagator/stargazers","contributors_url":"https://api.github.com/repos/botandrose/calagator/contributors","subscribers_url":"https://api.github.com/repos/botandrose/calagator/subscribers","subscription_url":"https://api.github.com/repos/botandrose/calagator/subscription","commits_url":"https://api.github.com/repos/botandrose/calagator/commits{/sha}","git_commits_url":"https://api.github.com/repos/botandrose/calagator/git/commits{/sha}","comments_url":"https://api.github.com/repos/botandrose/calagator/comments{/number}","issue_comment_url":"https://api.github.com/repos/botandrose/calagator/issues/comments{/number}","contents_url":"https://api.github.com/repos/botandrose/calagator/contents/{+path}","compare_url":"https://api.github.com/repos/botandrose/calagator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/botandrose/calagator/merges","archive_url":"https://api.github.com/repos/botandrose/calagator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/botandrose/calagator/downloads","issues_url":"https://api.github.com/repos/botandrose/calagator/issues{/number}","pulls_url":"https://api.github.com/repos/botandrose/calagator/pulls{/number}","milestones_url":"https://api.github.com/repos/botandrose/calagator/milestones{/number}","notifications_url":"https://api.github.com/repos/botandrose/calagator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/botandrose/calagator/labels{/name}","releases_url":"https://api.github.com/repos/botandrose/calagator/releases{/id}","created_at":"2014-06-24T04:14:29Z","updated_at":"2015-02-07T18:44:04Z","pushed_at":"2015-03-30T21:45:34Z","git_url":"git://github.com/botandrose/calagator.git","ssh_url":"git@github.com:botandrose/calagator.git","clone_url":"https://github.com/botandrose/calagator.git","svn_url":"https://github.com/botandrose/calagator","homepage":"http://calagator.org","size":16691,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"calagator:master","ref":"master","sha":"c212156c4fd5632f4583c25129200ec2bf49c8e2","user":{"login":"calagator","id":45116,"avatar_url":"https://avatars.githubusercontent.com/u/45116?v=3","gravatar_id":"","url":"https://api.github.com/users/calagator","html_url":"https://github.com/calagator","followers_url":"https://api.github.com/users/calagator/followers","following_url":"https://api.github.com/users/calagator/following{/other_user}","gists_url":"https://api.github.com/users/calagator/gists{/gist_id}","starred_url":"https://api.github.com/users/calagator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calagator/subscriptions","organizations_url":"https://api.github.com/users/calagator/orgs","repos_url":"https://api.github.com/users/calagator/repos","events_url":"https://api.github.com/users/calagator/events{/privacy}","received_events_url":"https://api.github.com/users/calagator/received_events","type":"Organization","site_admin":false},"repo":{"id":104937,"name":"calagator","full_name":"calagator/calagator","owner":{"login":"calagator","id":45116,"avatar_url":"https://avatars.githubusercontent.com/u/45116?v=3","gravatar_id":"","url":"https://api.github.com/users/calagator","html_url":"https://github.com/calagator","followers_url":"https://api.github.com/users/calagator/followers","following_url":"https://api.github.com/users/calagator/following{/other_user}","gists_url":"https://api.github.com/users/calagator/gists{/gist_id}","starred_url":"https://api.github.com/users/calagator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calagator/subscriptions","organizations_url":"https://api.github.com/users/calagator/orgs","repos_url":"https://api.github.com/users/calagator/repos","events_url":"https://api.github.com/users/calagator/events{/privacy}","received_events_url":"https://api.github.com/users/calagator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/calagator/calagator","description":"An event aggregator based in Portland, OR","fork":false,"url":"https://api.github.com/repos/calagator/calagator","forks_url":"https://api.github.com/repos/calagator/calagator/forks","keys_url":"https://api.github.com/repos/calagator/calagator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/calagator/calagator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/calagator/calagator/teams","hooks_url":"https://api.github.com/repos/calagator/calagator/hooks","issue_events_url":"https://api.github.com/repos/calagator/calagator/issues/events{/number}","events_url":"https://api.github.com/repos/calagator/calagator/events","assignees_url":"https://api.github.com/repos/calagator/calagator/assignees{/user}","branches_url":"https://api.github.com/repos/calagator/calagator/branches{/branch}","tags_url":"https://api.github.com/repos/calagator/calagator/tags","blobs_url":"https://api.github.com/repos/calagator/calagator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/calagator/calagator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/calagator/calagator/git/refs{/sha}","trees_url":"https://api.github.com/repos/calagator/calagator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/calagator/calagator/statuses/{sha}","languages_url":"https://api.github.com/repos/calagator/calagator/languages","stargazers_url":"https://api.github.com/repos/calagator/calagator/stargazers","contributors_url":"https://api.github.com/repos/calagator/calagator/contributors","subscribers_url":"https://api.github.com/repos/calagator/calagator/subscribers","subscription_url":"https://api.github.com/repos/calagator/calagator/subscription","commits_url":"https://api.github.com/repos/calagator/calagator/commits{/sha}","git_commits_url":"https://api.github.com/repos/calagator/calagator/git/commits{/sha}","comments_url":"https://api.github.com/repos/calagator/calagator/comments{/number}","issue_comment_url":"https://api.github.com/repos/calagator/calagator/issues/comments{/number}","contents_url":"https://api.github.com/repos/calagator/calagator/contents/{+path}","compare_url":"https://api.github.com/repos/calagator/calagator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/calagator/calagator/merges","archive_url":"https://api.github.com/repos/calagator/calagator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/calagator/calagator/downloads","issues_url":"https://api.github.com/repos/calagator/calagator/issues{/number}","pulls_url":"https://api.github.com/repos/calagator/calagator/pulls{/number}","milestones_url":"https://api.github.com/repos/calagator/calagator/milestones{/number}","notifications_url":"https://api.github.com/repos/calagator/calagator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/calagator/calagator/labels{/name}","releases_url":"https://api.github.com/repos/calagator/calagator/releases{/id}","created_at":"2009-01-11T01:08:17Z","updated_at":"2015-03-30T22:08:14Z","pushed_at":"2015-03-30T21:45:34Z","git_url":"git://github.com/calagator/calagator.git","ssh_url":"git@github.com:calagator/calagator.git","clone_url":"https://github.com/calagator/calagator.git","svn_url":"https://github.com/calagator/calagator","homepage":"http://calagator.org","size":20174,"stargazers_count":240,"watchers_count":240,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":177,"mirror_url":null,"open_issues_count":49,"forks":177,"open_issues":49,"watchers":240,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/calagator/calagator/pulls/351"},"html":{"href":"https://github.com/calagator/calagator/pull/351"},"issue":{"href":"https://api.github.com/repos/calagator/calagator/issues/351"},"comments":{"href":"https://api.github.com/repos/calagator/calagator/issues/351/comments"},"review_comments":{"href":"https://api.github.com/repos/calagator/calagator/pulls/351/comments"},"review_comment":{"href":"https://api.github.com/repos/calagator/calagator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/calagator/calagator/pulls/351/commits"},"statuses":{"href":"https://api.github.com/repos/calagator/calagator/statuses/9f7a1da9834f46cc8db26cef50d57bd59c864cd3"}}}}