{"action":"created","comment":{"url":"https://api.github.com/repos/girder/girder/pulls/comments/43160303","id":43160303,"diff_hunk":"@@ -116,7 +116,8 @@ def girder_install(self, component):\n             'girder-version.json',\n             'conf/girder.dist.cfg',\n             'mail_templates/*.mako',\n-            'mail_templates/**/*.mako'","path":"setup.py","position":4,"original_position":4,"commit_id":"be745c0b9092a648ac2238f404d85b8ef5a74511","original_commit_id":"be745c0b9092a648ac2238f404d85b8ef5a74511","user":{"login":"zachmullen","id":555959,"avatar_url":"https://avatars.githubusercontent.com/u/555959?v=3","gravatar_id":"","url":"https://api.github.com/users/zachmullen","html_url":"https://github.com/zachmullen","followers_url":"https://api.github.com/users/zachmullen/followers","following_url":"https://api.github.com/users/zachmullen/following{/other_user}","gists_url":"https://api.github.com/users/zachmullen/gists{/gist_id}","starred_url":"https://api.github.com/users/zachmullen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachmullen/subscriptions","organizations_url":"https://api.github.com/users/zachmullen/orgs","repos_url":"https://api.github.com/users/zachmullen/repos","events_url":"https://api.github.com/users/zachmullen/events{/privacy}","received_events_url":"https://api.github.com/users/zachmullen/received_events","type":"User","site_admin":false},"body":"That's if they remember to do so. Our test suite runs in a git clone environment, not the packaged environment, so it would be easy for someone to forget, and then we'd hear about it at deploy time when someone with a pip-installed server is seeing 500 exceptions when their server tries to send out emails.\r\n\r\nBasically, the cost of having this line in there as protection against that future possibility is worth it to me. The cost is one extra line of code, the benefit is avoiding this possible headache in the future. I'm happy to document that we allow mail templates in subdirectories, so that it's an officially supported thing rather than just something we happen to support.","created_at":"2015-10-27T17:57:11Z","updated_at":"2015-10-27T17:57:11Z","html_url":"https://github.com/girder/girder/pull/1036#discussion_r43160303","pull_request_url":"https://api.github.com/repos/girder/girder/pulls/1036","_links":{"self":{"href":"https://api.github.com/repos/girder/girder/pulls/comments/43160303"},"html":{"href":"https://github.com/girder/girder/pull/1036#discussion_r43160303"},"pull_request":{"href":"https://api.github.com/repos/girder/girder/pulls/1036"}}},"pull_request":{"url":"https://api.github.com/repos/girder/girder/pulls/1036","id":48665832,"html_url":"https://github.com/girder/girder/pull/1036","diff_url":"https://github.com/girder/girder/pull/1036.diff","patch_url":"https://github.com/girder/girder/pull/1036.patch","issue_url":"https://api.github.com/repos/girder/girder/issues/1036","number":1036,"state":"open","locked":false,"title":"Improvements to templated endpoints","user":{"login":"brianhelba","id":1282879,"avatar_url":"https://avatars.githubusercontent.com/u/1282879?v=3","gravatar_id":"","url":"https://api.github.com/users/brianhelba","html_url":"https://github.com/brianhelba","followers_url":"https://api.github.com/users/brianhelba/followers","following_url":"https://api.github.com/users/brianhelba/following{/other_user}","gists_url":"https://api.github.com/users/brianhelba/gists{/gist_id}","starred_url":"https://api.github.com/users/brianhelba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianhelba/subscriptions","organizations_url":"https://api.github.com/users/brianhelba/orgs","repos_url":"https://api.github.com/users/brianhelba/repos","events_url":"https://api.github.com/users/brianhelba/events{/privacy}","received_events_url":"https://api.github.com/users/brianhelba/received_events","type":"User","site_admin":false},"body":"* Use the more appropriate PACKAGE_DIR constant in some places \r\n* Remove unused package_data directory in setup.py\r\n * The \"mail_templates\" directory is single-level, and does not contain any subdirectories.\r\n*  Move Webroot and Description (Swagger root) templates to separate files\r\n * This will make future maintenance of these files easier, as they are no longer string literals constrained by Python style restrictions.\r\n * Since the new implementation stores the HTML string as an instance variable, instead of a class variable, it is possible to instantiate multiple Webroots with different templates in the same Girder instance.\r\n * This also slightly changes whitespace in the HTML template files, to improve their style once they are actually sent to a client.\r\n* Move template serving endpoint code to a common class\r\n * This reduces code duplication and makes it easier to add additional templated endpoints in the future.","created_at":"2015-10-24T21:36:47Z","updated_at":"2015-10-27T17:57:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76c6a22754f7493c8261e1f9567307f0610b305f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/girder/girder/pulls/1036/commits","review_comments_url":"https://api.github.com/repos/girder/girder/pulls/1036/comments","review_comment_url":"https://api.github.com/repos/girder/girder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/girder/girder/issues/1036/comments","statuses_url":"https://api.github.com/repos/girder/girder/statuses/be745c0b9092a648ac2238f404d85b8ef5a74511","head":{"label":"girder:html-files","ref":"html-files","sha":"be745c0b9092a648ac2238f404d85b8ef5a74511","user":{"login":"girder","id":5150517,"avatar_url":"https://avatars.githubusercontent.com/u/5150517?v=3","gravatar_id":"","url":"https://api.github.com/users/girder","html_url":"https://github.com/girder","followers_url":"https://api.github.com/users/girder/followers","following_url":"https://api.github.com/users/girder/following{/other_user}","gists_url":"https://api.github.com/users/girder/gists{/gist_id}","starred_url":"https://api.github.com/users/girder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girder/subscriptions","organizations_url":"https://api.github.com/users/girder/orgs","repos_url":"https://api.github.com/users/girder/repos","events_url":"https://api.github.com/users/girder/events{/privacy}","received_events_url":"https://api.github.com/users/girder/received_events","type":"Organization","site_admin":false},"repo":{"id":11854950,"name":"girder","full_name":"girder/girder","owner":{"login":"girder","id":5150517,"avatar_url":"https://avatars.githubusercontent.com/u/5150517?v=3","gravatar_id":"","url":"https://api.github.com/users/girder","html_url":"https://github.com/girder","followers_url":"https://api.github.com/users/girder/followers","following_url":"https://api.github.com/users/girder/following{/other_user}","gists_url":"https://api.github.com/users/girder/gists{/gist_id}","starred_url":"https://api.github.com/users/girder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girder/subscriptions","organizations_url":"https://api.github.com/users/girder/orgs","repos_url":"https://api.github.com/users/girder/repos","events_url":"https://api.github.com/users/girder/events{/privacy}","received_events_url":"https://api.github.com/users/girder/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/girder/girder","description":"A data management platform for the web","fork":false,"url":"https://api.github.com/repos/girder/girder","forks_url":"https://api.github.com/repos/girder/girder/forks","keys_url":"https://api.github.com/repos/girder/girder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/girder/girder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/girder/girder/teams","hooks_url":"https://api.github.com/repos/girder/girder/hooks","issue_events_url":"https://api.github.com/repos/girder/girder/issues/events{/number}","events_url":"https://api.github.com/repos/girder/girder/events","assignees_url":"https://api.github.com/repos/girder/girder/assignees{/user}","branches_url":"https://api.github.com/repos/girder/girder/branches{/branch}","tags_url":"https://api.github.com/repos/girder/girder/tags","blobs_url":"https://api.github.com/repos/girder/girder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/girder/girder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/girder/girder/git/refs{/sha}","trees_url":"https://api.github.com/repos/girder/girder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/girder/girder/statuses/{sha}","languages_url":"https://api.github.com/repos/girder/girder/languages","stargazers_url":"https://api.github.com/repos/girder/girder/stargazers","contributors_url":"https://api.github.com/repos/girder/girder/contributors","subscribers_url":"https://api.github.com/repos/girder/girder/subscribers","subscription_url":"https://api.github.com/repos/girder/girder/subscription","commits_url":"https://api.github.com/repos/girder/girder/commits{/sha}","git_commits_url":"https://api.github.com/repos/girder/girder/git/commits{/sha}","comments_url":"https://api.github.com/repos/girder/girder/comments{/number}","issue_comment_url":"https://api.github.com/repos/girder/girder/issues/comments{/number}","contents_url":"https://api.github.com/repos/girder/girder/contents/{+path}","compare_url":"https://api.github.com/repos/girder/girder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/girder/girder/merges","archive_url":"https://api.github.com/repos/girder/girder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/girder/girder/downloads","issues_url":"https://api.github.com/repos/girder/girder/issues{/number}","pulls_url":"https://api.github.com/repos/girder/girder/pulls{/number}","milestones_url":"https://api.github.com/repos/girder/girder/milestones{/number}","notifications_url":"https://api.github.com/repos/girder/girder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/girder/girder/labels{/name}","releases_url":"https://api.github.com/repos/girder/girder/releases{/id}","created_at":"2013-08-02T23:55:54Z","updated_at":"2015-10-05T17:21:47Z","pushed_at":"2015-10-27T15:21:11Z","git_url":"git://github.com/girder/girder.git","ssh_url":"git@github.com:girder/girder.git","clone_url":"https://github.com/girder/girder.git","svn_url":"https://github.com/girder/girder","homepage":"http://girder.readthedocs.org","size":12912,"stargazers_count":33,"watchers_count":33,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":124,"forks":33,"open_issues":124,"watchers":33,"default_branch":"master"}},"base":{"label":"girder:master","ref":"master","sha":"fa7811c4e81e3a21d7808b274f28c44ef8fcef8e","user":{"login":"girder","id":5150517,"avatar_url":"https://avatars.githubusercontent.com/u/5150517?v=3","gravatar_id":"","url":"https://api.github.com/users/girder","html_url":"https://github.com/girder","followers_url":"https://api.github.com/users/girder/followers","following_url":"https://api.github.com/users/girder/following{/other_user}","gists_url":"https://api.github.com/users/girder/gists{/gist_id}","starred_url":"https://api.github.com/users/girder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girder/subscriptions","organizations_url":"https://api.github.com/users/girder/orgs","repos_url":"https://api.github.com/users/girder/repos","events_url":"https://api.github.com/users/girder/events{/privacy}","received_events_url":"https://api.github.com/users/girder/received_events","type":"Organization","site_admin":false},"repo":{"id":11854950,"name":"girder","full_name":"girder/girder","owner":{"login":"girder","id":5150517,"avatar_url":"https://avatars.githubusercontent.com/u/5150517?v=3","gravatar_id":"","url":"https://api.github.com/users/girder","html_url":"https://github.com/girder","followers_url":"https://api.github.com/users/girder/followers","following_url":"https://api.github.com/users/girder/following{/other_user}","gists_url":"https://api.github.com/users/girder/gists{/gist_id}","starred_url":"https://api.github.com/users/girder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girder/subscriptions","organizations_url":"https://api.github.com/users/girder/orgs","repos_url":"https://api.github.com/users/girder/repos","events_url":"https://api.github.com/users/girder/events{/privacy}","received_events_url":"https://api.github.com/users/girder/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/girder/girder","description":"A data management platform for the web","fork":false,"url":"https://api.github.com/repos/girder/girder","forks_url":"https://api.github.com/repos/girder/girder/forks","keys_url":"https://api.github.com/repos/girder/girder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/girder/girder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/girder/girder/teams","hooks_url":"https://api.github.com/repos/girder/girder/hooks","issue_events_url":"https://api.github.com/repos/girder/girder/issues/events{/number}","events_url":"https://api.github.com/repos/girder/girder/events","assignees_url":"https://api.github.com/repos/girder/girder/assignees{/user}","branches_url":"https://api.github.com/repos/girder/girder/branches{/branch}","tags_url":"https://api.github.com/repos/girder/girder/tags","blobs_url":"https://api.github.com/repos/girder/girder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/girder/girder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/girder/girder/git/refs{/sha}","trees_url":"https://api.github.com/repos/girder/girder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/girder/girder/statuses/{sha}","languages_url":"https://api.github.com/repos/girder/girder/languages","stargazers_url":"https://api.github.com/repos/girder/girder/stargazers","contributors_url":"https://api.github.com/repos/girder/girder/contributors","subscribers_url":"https://api.github.com/repos/girder/girder/subscribers","subscription_url":"https://api.github.com/repos/girder/girder/subscription","commits_url":"https://api.github.com/repos/girder/girder/commits{/sha}","git_commits_url":"https://api.github.com/repos/girder/girder/git/commits{/sha}","comments_url":"https://api.github.com/repos/girder/girder/comments{/number}","issue_comment_url":"https://api.github.com/repos/girder/girder/issues/comments{/number}","contents_url":"https://api.github.com/repos/girder/girder/contents/{+path}","compare_url":"https://api.github.com/repos/girder/girder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/girder/girder/merges","archive_url":"https://api.github.com/repos/girder/girder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/girder/girder/downloads","issues_url":"https://api.github.com/repos/girder/girder/issues{/number}","pulls_url":"https://api.github.com/repos/girder/girder/pulls{/number}","milestones_url":"https://api.github.com/repos/girder/girder/milestones{/number}","notifications_url":"https://api.github.com/repos/girder/girder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/girder/girder/labels{/name}","releases_url":"https://api.github.com/repos/girder/girder/releases{/id}","created_at":"2013-08-02T23:55:54Z","updated_at":"2015-10-05T17:21:47Z","pushed_at":"2015-10-27T15:21:11Z","git_url":"git://github.com/girder/girder.git","ssh_url":"git@github.com:girder/girder.git","clone_url":"https://github.com/girder/girder.git","svn_url":"https://github.com/girder/girder","homepage":"http://girder.readthedocs.org","size":12912,"stargazers_count":33,"watchers_count":33,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":124,"forks":33,"open_issues":124,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/girder/girder/pulls/1036"},"html":{"href":"https://github.com/girder/girder/pull/1036"},"issue":{"href":"https://api.github.com/repos/girder/girder/issues/1036"},"comments":{"href":"https://api.github.com/repos/girder/girder/issues/1036/comments"},"review_comments":{"href":"https://api.github.com/repos/girder/girder/pulls/1036/comments"},"review_comment":{"href":"https://api.github.com/repos/girder/girder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/girder/girder/pulls/1036/commits"},"statuses":{"href":"https://api.github.com/repos/girder/girder/statuses/be745c0b9092a648ac2238f404d85b8ef5a74511"}}}}