{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/41548605","id":41548605,"diff_hunk":"@@ -118,6 +124,11 @@ func (o *createClusterOptions) modifyCluster(existingCluster clientcmdapi.Cluste\n \tif o.server.Provided() {\n \t\tmodifiedCluster.Server = o.server.Value()\n \t}\n+\tif o.preferredGroupVersions.Provided() {\n+\t\tfmt.Printf(\"preferred versions provided: o.preferredGroupVersions = %#v, o.preferredGroupVersions.Value() = %v\\n\", o.preferredGroupVersions, o.preferredGroupVersions.Value())","path":"pkg/kubectl/cmd/config/create_cluster.go","position":null,"original_position":58,"commit_id":"09a47bcf7833a2b73b88b5e05bb1053f0ff3065a","original_commit_id":"81ecf168c921851132d8f8abe57939d130ae0aaf","user":{"login":"JanetKuo","id":4876867,"avatar_url":"https://avatars.githubusercontent.com/u/4876867?v=3","gravatar_id":"","url":"https://api.github.com/users/JanetKuo","html_url":"https://github.com/JanetKuo","followers_url":"https://api.github.com/users/JanetKuo/followers","following_url":"https://api.github.com/users/JanetKuo/following{/other_user}","gists_url":"https://api.github.com/users/JanetKuo/gists{/gist_id}","starred_url":"https://api.github.com/users/JanetKuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JanetKuo/subscriptions","organizations_url":"https://api.github.com/users/JanetKuo/orgs","repos_url":"https://api.github.com/users/JanetKuo/repos","events_url":"https://api.github.com/users/JanetKuo/events{/privacy}","received_events_url":"https://api.github.com/users/JanetKuo/received_events","type":"User","site_admin":false},"body":"Yes. Removed now. ","created_at":"2015-10-08T18:19:38Z","updated_at":"2015-10-08T18:19:38Z","html_url":"https://github.com/kubernetes/kubernetes/pull/14383#discussion_r41548605","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14383","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/41548605"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/14383#discussion_r41548605"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14383"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14383","id":45723704,"html_url":"https://github.com/kubernetes/kubernetes/pull/14383","diff_url":"https://github.com/kubernetes/kubernetes/pull/14383.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/14383.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14383","number":14383,"state":"open","locked":false,"title":"Replace api-version field with preferred-versions in kubeconfig file","user":{"login":"JanetKuo","id":4876867,"avatar_url":"https://avatars.githubusercontent.com/u/4876867?v=3","gravatar_id":"","url":"https://api.github.com/users/JanetKuo","html_url":"https://github.com/JanetKuo","followers_url":"https://api.github.com/users/JanetKuo/followers","following_url":"https://api.github.com/users/JanetKuo/following{/other_user}","gists_url":"https://api.github.com/users/JanetKuo/gists{/gist_id}","starred_url":"https://api.github.com/users/JanetKuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JanetKuo/subscriptions","organizations_url":"https://api.github.com/users/JanetKuo/orgs","repos_url":"https://api.github.com/users/JanetKuo/repos","events_url":"https://api.github.com/users/JanetKuo/events{/privacy}","received_events_url":"https://api.github.com/users/JanetKuo/received_events","type":"User","site_admin":false},"body":"Fixes #14318. \r\n\r\n- Deprecated `api-version` field, and replace it with `preferred-versions` field (defined in pkg/client/unversioned/clientcmd/api/#Cluster.PreferredGroupVersions, type `[]string`)\r\n- Users may specify preferred versions in kubeconfig file (`preferred-versions`) or using kubectl flag (`--preferred-versions`) \r\n- sample usage: \r\n  - kubectl: `--preferred-versions=group1/version1 --preferred-versions=group2/version2` or `--preferred-versions=group1/version1,group2/version2`\r\n  - kubeconfig: \r\n  ```\r\n  preferred-versions:\r\n  - group1/version1\r\n  - group2/version2\r\n  ```\r\n\r\ncc @lavalamp ","created_at":"2015-09-22T22:10:10Z","updated_at":"2015-10-08T18:19:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b83dd500d846c29249c57aadb70df9c81074c71e","assignee":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14383/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14383/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14383/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/09a47bcf7833a2b73b88b5e05bb1053f0ff3065a","head":{"label":"JanetKuo:deprecate-apiversion-kubeconfig","ref":"deprecate-apiversion-kubeconfig","sha":"09a47bcf7833a2b73b88b5e05bb1053f0ff3065a","user":{"login":"JanetKuo","id":4876867,"avatar_url":"https://avatars.githubusercontent.com/u/4876867?v=3","gravatar_id":"","url":"https://api.github.com/users/JanetKuo","html_url":"https://github.com/JanetKuo","followers_url":"https://api.github.com/users/JanetKuo/followers","following_url":"https://api.github.com/users/JanetKuo/following{/other_user}","gists_url":"https://api.github.com/users/JanetKuo/gists{/gist_id}","starred_url":"https://api.github.com/users/JanetKuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JanetKuo/subscriptions","organizations_url":"https://api.github.com/users/JanetKuo/orgs","repos_url":"https://api.github.com/users/JanetKuo/repos","events_url":"https://api.github.com/users/JanetKuo/events{/privacy}","received_events_url":"https://api.github.com/users/JanetKuo/received_events","type":"User","site_admin":false},"repo":{"id":37748937,"name":"kubernetes","full_name":"JanetKuo/kubernetes","owner":{"login":"JanetKuo","id":4876867,"avatar_url":"https://avatars.githubusercontent.com/u/4876867?v=3","gravatar_id":"","url":"https://api.github.com/users/JanetKuo","html_url":"https://github.com/JanetKuo","followers_url":"https://api.github.com/users/JanetKuo/followers","following_url":"https://api.github.com/users/JanetKuo/following{/other_user}","gists_url":"https://api.github.com/users/JanetKuo/gists{/gist_id}","starred_url":"https://api.github.com/users/JanetKuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JanetKuo/subscriptions","organizations_url":"https://api.github.com/users/JanetKuo/orgs","repos_url":"https://api.github.com/users/JanetKuo/repos","events_url":"https://api.github.com/users/JanetKuo/events{/privacy}","received_events_url":"https://api.github.com/users/JanetKuo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JanetKuo/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/JanetKuo/kubernetes","forks_url":"https://api.github.com/repos/JanetKuo/kubernetes/forks","keys_url":"https://api.github.com/repos/JanetKuo/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JanetKuo/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JanetKuo/kubernetes/teams","hooks_url":"https://api.github.com/repos/JanetKuo/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/JanetKuo/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/JanetKuo/kubernetes/events","assignees_url":"https://api.github.com/repos/JanetKuo/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/JanetKuo/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/JanetKuo/kubernetes/tags","blobs_url":"https://api.github.com/repos/JanetKuo/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JanetKuo/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JanetKuo/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/JanetKuo/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JanetKuo/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/JanetKuo/kubernetes/languages","stargazers_url":"https://api.github.com/repos/JanetKuo/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/JanetKuo/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/JanetKuo/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/JanetKuo/kubernetes/subscription","commits_url":"https://api.github.com/repos/JanetKuo/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/JanetKuo/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/JanetKuo/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/JanetKuo/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/JanetKuo/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/JanetKuo/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JanetKuo/kubernetes/merges","archive_url":"https://api.github.com/repos/JanetKuo/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JanetKuo/kubernetes/downloads","issues_url":"https://api.github.com/repos/JanetKuo/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/JanetKuo/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/JanetKuo/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/JanetKuo/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JanetKuo/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/JanetKuo/kubernetes/releases{/id}","created_at":"2015-06-19T22:29:18Z","updated_at":"2015-06-19T22:29:25Z","pushed_at":"2015-10-08T18:18:56Z","git_url":"git://github.com/JanetKuo/kubernetes.git","ssh_url":"git@github.com:JanetKuo/kubernetes.git","clone_url":"https://github.com/JanetKuo/kubernetes.git","svn_url":"https://github.com/JanetKuo/kubernetes","homepage":"http://kubernetes.io","size":113883,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"8982776b5447942bc7090abdd0fa4e24cbf0745c","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-10-08T14:48:21Z","pushed_at":"2015-10-08T18:18:57Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":450627,"stargazers_count":10602,"watchers_count":10602,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2668,"mirror_url":null,"open_issues_count":2012,"forks":2668,"open_issues":2012,"watchers":10602,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14383"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/14383"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/14383"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/14383/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14383/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14383/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/09a47bcf7833a2b73b88b5e05bb1053f0ff3065a"}}}}