{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/41335754","id":41335754,"diff_hunk":"@@ -20,10 +20,12 @@\n # When creating new tests for Spark SQL Hive, the HADOOP_CLASSPATH must contain the hive jars so\n # that we can run Hive to generate the golden answer.  This is not required for normal development\n # or testing.\n-for i in \"$HIVE_HOME\"/lib/*\n-do HADOOP_CLASSPATH=\"$HADOOP_CLASSPATH:$i\"\n-done\n-export HADOOP_CLASSPATH\n+if [ \"$HIVE_HOME\" ]; then","path":"build/sbt","position":8,"original_position":8,"commit_id":"37c02b09063c474b55d68ed8307c31c8f1dde179","original_commit_id":"37c02b09063c474b55d68ed8307c31c8f1dde179","user":{"login":"kevincox","id":494012,"avatar_url":"https://avatars.githubusercontent.com/u/494012?v=3","gravatar_id":"","url":"https://api.github.com/users/kevincox","html_url":"https://github.com/kevincox","followers_url":"https://api.github.com/users/kevincox/followers","following_url":"https://api.github.com/users/kevincox/following{/other_user}","gists_url":"https://api.github.com/users/kevincox/gists{/gist_id}","starred_url":"https://api.github.com/users/kevincox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevincox/subscriptions","organizations_url":"https://api.github.com/users/kevincox/orgs","repos_url":"https://api.github.com/users/kevincox/repos","events_url":"https://api.github.com/users/kevincox/events{/privacy}","received_events_url":"https://api.github.com/users/kevincox/received_events","type":"User","site_admin":false},"body":"I think I'm good here because it is in quotes so it will always be an argument. However there is actually a problem if there is a leading `-` in the variable so I will update to prevent that.","created_at":"2015-10-06T23:25:35Z","updated_at":"2015-10-06T23:25:35Z","html_url":"https://github.com/apache/spark/pull/8994#discussion_r41335754","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/8994","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/41335754"},"html":{"href":"https://github.com/apache/spark/pull/8994#discussion_r41335754"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/8994"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/8994","id":46924803,"html_url":"https://github.com/apache/spark/pull/8994","diff_url":"https://github.com/apache/spark/pull/8994.diff","patch_url":"https://github.com/apache/spark/pull/8994.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/8994","number":8994,"state":"open","locked":false,"title":"[SPARK-10952] Only add hive to classpath if HIVE_HOME is set.","user":{"login":"kevincox","id":494012,"avatar_url":"https://avatars.githubusercontent.com/u/494012?v=3","gravatar_id":"","url":"https://api.github.com/users/kevincox","html_url":"https://github.com/kevincox","followers_url":"https://api.github.com/users/kevincox/followers","following_url":"https://api.github.com/users/kevincox/following{/other_user}","gists_url":"https://api.github.com/users/kevincox/gists{/gist_id}","starred_url":"https://api.github.com/users/kevincox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevincox/subscriptions","organizations_url":"https://api.github.com/users/kevincox/orgs","repos_url":"https://api.github.com/users/kevincox/repos","events_url":"https://api.github.com/users/kevincox/events{/privacy}","received_events_url":"https://api.github.com/users/kevincox/received_events","type":"User","site_admin":false},"body":"Currently if it isn't set it scans `/lib/*` and adds every dir to the\r\nclasspath which makes the env too large and every command called\r\nafterwords fails.","created_at":"2015-10-06T16:20:45Z","updated_at":"2015-10-06T23:25:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fdd9f4b512ab7b66e3359228f76c593ac64122a6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/8994/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/8994/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/8994/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/37c02b09063c474b55d68ed8307c31c8f1dde179","head":{"label":"kevincox:kevincox-only-add-hive-to-classpath-if-var-is-set","ref":"kevincox-only-add-hive-to-classpath-if-var-is-set","sha":"37c02b09063c474b55d68ed8307c31c8f1dde179","user":{"login":"kevincox","id":494012,"avatar_url":"https://avatars.githubusercontent.com/u/494012?v=3","gravatar_id":"","url":"https://api.github.com/users/kevincox","html_url":"https://github.com/kevincox","followers_url":"https://api.github.com/users/kevincox/followers","following_url":"https://api.github.com/users/kevincox/following{/other_user}","gists_url":"https://api.github.com/users/kevincox/gists{/gist_id}","starred_url":"https://api.github.com/users/kevincox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevincox/subscriptions","organizations_url":"https://api.github.com/users/kevincox/orgs","repos_url":"https://api.github.com/users/kevincox/repos","events_url":"https://api.github.com/users/kevincox/events{/privacy}","received_events_url":"https://api.github.com/users/kevincox/received_events","type":"User","site_admin":false},"repo":{"id":43370972,"name":"spark","full_name":"kevincox/spark","owner":{"login":"kevincox","id":494012,"avatar_url":"https://avatars.githubusercontent.com/u/494012?v=3","gravatar_id":"","url":"https://api.github.com/users/kevincox","html_url":"https://github.com/kevincox","followers_url":"https://api.github.com/users/kevincox/followers","following_url":"https://api.github.com/users/kevincox/following{/other_user}","gists_url":"https://api.github.com/users/kevincox/gists{/gist_id}","starred_url":"https://api.github.com/users/kevincox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevincox/subscriptions","organizations_url":"https://api.github.com/users/kevincox/orgs","repos_url":"https://api.github.com/users/kevincox/repos","events_url":"https://api.github.com/users/kevincox/events{/privacy}","received_events_url":"https://api.github.com/users/kevincox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kevincox/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/kevincox/spark","forks_url":"https://api.github.com/repos/kevincox/spark/forks","keys_url":"https://api.github.com/repos/kevincox/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kevincox/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kevincox/spark/teams","hooks_url":"https://api.github.com/repos/kevincox/spark/hooks","issue_events_url":"https://api.github.com/repos/kevincox/spark/issues/events{/number}","events_url":"https://api.github.com/repos/kevincox/spark/events","assignees_url":"https://api.github.com/repos/kevincox/spark/assignees{/user}","branches_url":"https://api.github.com/repos/kevincox/spark/branches{/branch}","tags_url":"https://api.github.com/repos/kevincox/spark/tags","blobs_url":"https://api.github.com/repos/kevincox/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kevincox/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kevincox/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/kevincox/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kevincox/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/kevincox/spark/languages","stargazers_url":"https://api.github.com/repos/kevincox/spark/stargazers","contributors_url":"https://api.github.com/repos/kevincox/spark/contributors","subscribers_url":"https://api.github.com/repos/kevincox/spark/subscribers","subscription_url":"https://api.github.com/repos/kevincox/spark/subscription","commits_url":"https://api.github.com/repos/kevincox/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/kevincox/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/kevincox/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/kevincox/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/kevincox/spark/contents/{+path}","compare_url":"https://api.github.com/repos/kevincox/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kevincox/spark/merges","archive_url":"https://api.github.com/repos/kevincox/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kevincox/spark/downloads","issues_url":"https://api.github.com/repos/kevincox/spark/issues{/number}","pulls_url":"https://api.github.com/repos/kevincox/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/kevincox/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/kevincox/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kevincox/spark/labels{/name}","releases_url":"https://api.github.com/repos/kevincox/spark/releases{/id}","created_at":"2015-09-29T14:01:26Z","updated_at":"2015-09-29T14:01:58Z","pushed_at":"2015-10-06T16:19:35Z","git_url":"git://github.com/kevincox/spark.git","ssh_url":"git@github.com:kevincox/spark.git","clone_url":"https://github.com/kevincox/spark.git","svn_url":"https://github.com/kevincox/spark","homepage":null,"size":126507,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"27ecfe61f07c8413a7b8b9fbdf36ed99cf05227d","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-10-06T22:33:15Z","pushed_at":"2015-10-06T23:19:52Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1628185,"stargazers_count":5679,"watchers_count":5679,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5250,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":358,"forks":5250,"open_issues":358,"watchers":5679,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/8994"},"html":{"href":"https://github.com/apache/spark/pull/8994"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/8994"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/8994/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/8994/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/8994/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/37c02b09063c474b55d68ed8307c31c8f1dde179"}}}}