{"action":"created","issue":{"url":"https://api.github.com/repos/hydroshare/hydroshare/issues/593","labels_url":"https://api.github.com/repos/hydroshare/hydroshare/issues/593/labels{/name}","comments_url":"https://api.github.com/repos/hydroshare/hydroshare/issues/593/comments","events_url":"https://api.github.com/repos/hydroshare/hydroshare/issues/593/events","html_url":"https://github.com/hydroshare/hydroshare/pull/593","id":104326285,"number":593,"title":"fixed issue [#592]","user":{"login":"hyi","id":476302,"avatar_url":"https://avatars.githubusercontent.com/u/476302?v=3","gravatar_id":"","url":"https://api.github.com/users/hyi","html_url":"https://github.com/hyi","followers_url":"https://api.github.com/users/hyi/followers","following_url":"https://api.github.com/users/hyi/following{/other_user}","gists_url":"https://api.github.com/users/hyi/gists{/gist_id}","starred_url":"https://api.github.com/users/hyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyi/subscriptions","organizations_url":"https://api.github.com/users/hyi/orgs","repos_url":"https://api.github.com/users/hyi/repos","events_url":"https://api.github.com/users/hyi/events{/privacy}","received_events_url":"https://api.github.com/users/hyi/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/hydroshare/hydroshare/labels/Code%20Review%20-%20Review%20Me%20Please!","name":"Code Review - Review Me Please!","color":"207de5"}],"state":"open","locked":false,"assignee":{"login":"mjstealey","id":5332509,"avatar_url":"https://avatars.githubusercontent.com/u/5332509?v=3","gravatar_id":"","url":"https://api.github.com/users/mjstealey","html_url":"https://github.com/mjstealey","followers_url":"https://api.github.com/users/mjstealey/followers","following_url":"https://api.github.com/users/mjstealey/following{/other_user}","gists_url":"https://api.github.com/users/mjstealey/gists{/gist_id}","starred_url":"https://api.github.com/users/mjstealey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjstealey/subscriptions","organizations_url":"https://api.github.com/users/mjstealey/orgs","repos_url":"https://api.github.com/users/mjstealey/repos","events_url":"https://api.github.com/users/mjstealey/events{/privacy}","received_events_url":"https://api.github.com/users/mjstealey/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/hydroshare/hydroshare/milestones/15","html_url":"https://github.com/hydroshare/hydroshare/milestones/1.5.3%20-%20pre%20Refactor%20/%20pre%20Access%20Control","labels_url":"https://api.github.com/repos/hydroshare/hydroshare/milestones/15/labels","id":1282923,"number":15,"title":"1.5.3 - pre Refactor / pre Access Control","description":"Catch the master branch up to develop prior to bring in the new refactor and access control code","creator":{"login":"mjstealey","id":5332509,"avatar_url":"https://avatars.githubusercontent.com/u/5332509?v=3","gravatar_id":"","url":"https://api.github.com/users/mjstealey","html_url":"https://github.com/mjstealey","followers_url":"https://api.github.com/users/mjstealey/followers","following_url":"https://api.github.com/users/mjstealey/following{/other_user}","gists_url":"https://api.github.com/users/mjstealey/gists{/gist_id}","starred_url":"https://api.github.com/users/mjstealey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjstealey/subscriptions","organizations_url":"https://api.github.com/users/mjstealey/orgs","repos_url":"https://api.github.com/users/mjstealey/repos","events_url":"https://api.github.com/users/mjstealey/events{/privacy}","received_events_url":"https://api.github.com/users/mjstealey/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":4,"state":"open","created_at":"2015-08-31T22:11:53Z","updated_at":"2015-09-01T18:23:28Z","due_on":"2015-09-03T04:00:00Z","closed_at":null},"comments":1,"created_at":"2015-09-01T18:23:28Z","updated_at":"2015-09-01T18:31:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hydroshare/hydroshare/pulls/593","html_url":"https://github.com/hydroshare/hydroshare/pull/593","diff_url":"https://github.com/hydroshare/hydroshare/pull/593.diff","patch_url":"https://github.com/hydroshare/hydroshare/pull/593.patch"},"body":"Replaced strftime() with isoformat() as @ironfroggy suggested to fix metadata update failure when the selected year is less than 1900. As a result, the start date and end date of the temporal coverage have the string representation format of YYYY-MM-DD as specified in ISO 8601 which is returned from isoformat() as opposed to the previous format of MM/DD/YYYY. I think this should be fine. With this fix, users can select year before 1900 and successfully save changes with metadata updated successfully. \r\n@ironfroggy @pkdash Could you review the code and raise issues if any? "},"comment":{"url":"https://api.github.com/repos/hydroshare/hydroshare/issues/comments/136821421","html_url":"https://github.com/hydroshare/hydroshare/pull/593#issuecomment-136821421","issue_url":"https://api.github.com/repos/hydroshare/hydroshare/issues/593","id":136821421,"user":{"login":"horsburgh","id":3485902,"avatar_url":"https://avatars.githubusercontent.com/u/3485902?v=3","gravatar_id":"","url":"https://api.github.com/users/horsburgh","html_url":"https://github.com/horsburgh","followers_url":"https://api.github.com/users/horsburgh/followers","following_url":"https://api.github.com/users/horsburgh/following{/other_user}","gists_url":"https://api.github.com/users/horsburgh/gists{/gist_id}","starred_url":"https://api.github.com/users/horsburgh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/horsburgh/subscriptions","organizations_url":"https://api.github.com/users/horsburgh/orgs","repos_url":"https://api.github.com/users/horsburgh/repos","events_url":"https://api.github.com/users/horsburgh/events{/privacy}","received_events_url":"https://api.github.com/users/horsburgh/received_events","type":"User","site_admin":false},"created_at":"2015-09-01T18:31:56Z","updated_at":"2015-09-01T18:31:56Z","body":"@hyi - will this change also allow us to type a date into the coverage element that has hours, minutes, and seconds?  I ask because for time series resources, they may begin at a particular time on a day.  One could just select the day on which they start, but it is more correct to select the date/time of the first observation.  \r\n\r\nWhen I was testing creation of a time series resource the other night I noticed that the validation on the date fields would only allow me to enter a day - I couldn't enter a time.\r\n"}}