{"action":"created","comment":{"url":"https://api.github.com/repos/piwik/piwik/pulls/comments/34414523","id":34414523,"diff_hunk":"@@ -323,6 +323,10 @@ private static function forceReloadAuthUsingTokenAuth($tokenAuth)\n \n     private static function shouldReloadAuthUsingTokenAuth($request)\n     {\n+        if (is_null($request)) {","path":"core/API/Request.php","position":4,"original_position":4,"commit_id":"7c99419e8ec0b5a3acc076a17eb8fc37ac87d285","original_commit_id":"7c99419e8ec0b5a3acc076a17eb8fc37ac87d285","user":{"login":"sgiehl","id":1579355,"avatar_url":"https://avatars.githubusercontent.com/u/1579355?v=3","gravatar_id":"","url":"https://api.github.com/users/sgiehl","html_url":"https://github.com/sgiehl","followers_url":"https://api.github.com/users/sgiehl/followers","following_url":"https://api.github.com/users/sgiehl/following{/other_user}","gists_url":"https://api.github.com/users/sgiehl/gists{/gist_id}","starred_url":"https://api.github.com/users/sgiehl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgiehl/subscriptions","organizations_url":"https://api.github.com/users/sgiehl/orgs","repos_url":"https://api.github.com/users/sgiehl/repos","events_url":"https://api.github.com/users/sgiehl/events{/privacy}","received_events_url":"https://api.github.com/users/sgiehl/received_events","type":"User","site_admin":false},"body":"Problem is, that ```$request``` is ```null```. So the Auth was never reloaded.\r\nI had searched for a better solution. But I didn't find another without changing the current logic.\r\nThere seems to be no way to determine whether a parameter is set in the request but empty. ```Common::getRequestVar()``` returns the default (or throws exception) if the parameter is missing or empty. Imho returning the empty value would be correct here, but I guess that might break other stuff in piwik to change that behavior.","created_at":"2015-07-11T17:10:27Z","updated_at":"2015-07-11T17:10:27Z","html_url":"https://github.com/piwik/piwik/pull/8330#discussion_r34414523","pull_request_url":"https://api.github.com/repos/piwik/piwik/pulls/8330","_links":{"self":{"href":"https://api.github.com/repos/piwik/piwik/pulls/comments/34414523"},"html":{"href":"https://github.com/piwik/piwik/pull/8330#discussion_r34414523"},"pull_request":{"href":"https://api.github.com/repos/piwik/piwik/pulls/8330"}}},"pull_request":{"url":"https://api.github.com/repos/piwik/piwik/pulls/8330","id":39747980,"html_url":"https://github.com/piwik/piwik/pull/8330","diff_url":"https://github.com/piwik/piwik/pull/8330.diff","patch_url":"https://github.com/piwik/piwik/pull/8330.patch","issue_url":"https://api.github.com/repos/piwik/piwik/issues/8330","number":8330,"state":"open","locked":false,"title":"Fixes regression for not working embedded widgets","user":{"login":"sgiehl","id":1579355,"avatar_url":"https://avatars.githubusercontent.com/u/1579355?v=3","gravatar_id":"","url":"https://api.github.com/users/sgiehl","html_url":"https://github.com/sgiehl","followers_url":"https://api.github.com/users/sgiehl/followers","following_url":"https://api.github.com/users/sgiehl/following{/other_user}","gists_url":"https://api.github.com/users/sgiehl/gists{/gist_id}","starred_url":"https://api.github.com/users/sgiehl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgiehl/subscriptions","organizations_url":"https://api.github.com/users/sgiehl/orgs","repos_url":"https://api.github.com/users/sgiehl/repos","events_url":"https://api.github.com/users/sgiehl/events{/privacy}","received_events_url":"https://api.github.com/users/sgiehl/received_events","type":"User","site_admin":false},"body":"fixes #8321","created_at":"2015-07-11T16:04:59Z","updated_at":"2015-07-11T17:10:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30b091bb38dcdcb8e57659445b84904554f1994a","assignee":null,"milestone":{"url":"https://api.github.com/repos/piwik/piwik/milestones/83","html_url":"https://github.com/piwik/piwik/milestones/2.14.1","labels_url":"https://api.github.com/repos/piwik/piwik/milestones/83/labels","id":1166048,"number":83,"title":"2.14.1","description":"","creator":{"login":"mattab","id":466765,"avatar_url":"https://avatars.githubusercontent.com/u/466765?v=3","gravatar_id":"","url":"https://api.github.com/users/mattab","html_url":"https://github.com/mattab","followers_url":"https://api.github.com/users/mattab/followers","following_url":"https://api.github.com/users/mattab/following{/other_user}","gists_url":"https://api.github.com/users/mattab/gists{/gist_id}","starred_url":"https://api.github.com/users/mattab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattab/subscriptions","organizations_url":"https://api.github.com/users/mattab/orgs","repos_url":"https://api.github.com/users/mattab/repos","events_url":"https://api.github.com/users/mattab/events{/privacy}","received_events_url":"https://api.github.com/users/mattab/received_events","type":"User","site_admin":false},"open_issues":29,"closed_issues":9,"state":"open","created_at":"2015-06-16T02:42:44Z","updated_at":"2015-07-11T16:04:59Z","due_on":"2015-07-22T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/piwik/piwik/pulls/8330/commits","review_comments_url":"https://api.github.com/repos/piwik/piwik/pulls/8330/comments","review_comment_url":"https://api.github.com/repos/piwik/piwik/pulls/comments{/number}","comments_url":"https://api.github.com/repos/piwik/piwik/issues/8330/comments","statuses_url":"https://api.github.com/repos/piwik/piwik/statuses/7c99419e8ec0b5a3acc076a17eb8fc37ac87d285","head":{"label":"piwik:8321_embedded_widgets","ref":"8321_embedded_widgets","sha":"7c99419e8ec0b5a3acc076a17eb8fc37ac87d285","user":{"login":"piwik","id":698038,"avatar_url":"https://avatars.githubusercontent.com/u/698038?v=3","gravatar_id":"","url":"https://api.github.com/users/piwik","html_url":"https://github.com/piwik","followers_url":"https://api.github.com/users/piwik/followers","following_url":"https://api.github.com/users/piwik/following{/other_user}","gists_url":"https://api.github.com/users/piwik/gists{/gist_id}","starred_url":"https://api.github.com/users/piwik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piwik/subscriptions","organizations_url":"https://api.github.com/users/piwik/orgs","repos_url":"https://api.github.com/users/piwik/repos","events_url":"https://api.github.com/users/piwik/events{/privacy}","received_events_url":"https://api.github.com/users/piwik/received_events","type":"Organization","site_admin":false},"repo":{"id":1548202,"name":"piwik","full_name":"piwik/piwik","owner":{"login":"piwik","id":698038,"avatar_url":"https://avatars.githubusercontent.com/u/698038?v=3","gravatar_id":"","url":"https://api.github.com/users/piwik","html_url":"https://github.com/piwik","followers_url":"https://api.github.com/users/piwik/followers","following_url":"https://api.github.com/users/piwik/following{/other_user}","gists_url":"https://api.github.com/users/piwik/gists{/gist_id}","starred_url":"https://api.github.com/users/piwik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piwik/subscriptions","organizations_url":"https://api.github.com/users/piwik/orgs","repos_url":"https://api.github.com/users/piwik/repos","events_url":"https://api.github.com/users/piwik/events{/privacy}","received_events_url":"https://api.github.com/users/piwik/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/piwik/piwik","description":"Liberating Web Analytics. Star us on Github? +1. Piwik is the leading open alternative to Google Analytics that gives you full control over your data. Piwik lets you easily collect data from websites, apps & IoT and visualise this data and extract insights. Privacy is built-in. We love Pull Requests! ","fork":false,"url":"https://api.github.com/repos/piwik/piwik","forks_url":"https://api.github.com/repos/piwik/piwik/forks","keys_url":"https://api.github.com/repos/piwik/piwik/keys{/key_id}","collaborators_url":"https://api.github.com/repos/piwik/piwik/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/piwik/piwik/teams","hooks_url":"https://api.github.com/repos/piwik/piwik/hooks","issue_events_url":"https://api.github.com/repos/piwik/piwik/issues/events{/number}","events_url":"https://api.github.com/repos/piwik/piwik/events","assignees_url":"https://api.github.com/repos/piwik/piwik/assignees{/user}","branches_url":"https://api.github.com/repos/piwik/piwik/branches{/branch}","tags_url":"https://api.github.com/repos/piwik/piwik/tags","blobs_url":"https://api.github.com/repos/piwik/piwik/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/piwik/piwik/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/piwik/piwik/git/refs{/sha}","trees_url":"https://api.github.com/repos/piwik/piwik/git/trees{/sha}","statuses_url":"https://api.github.com/repos/piwik/piwik/statuses/{sha}","languages_url":"https://api.github.com/repos/piwik/piwik/languages","stargazers_url":"https://api.github.com/repos/piwik/piwik/stargazers","contributors_url":"https://api.github.com/repos/piwik/piwik/contributors","subscribers_url":"https://api.github.com/repos/piwik/piwik/subscribers","subscription_url":"https://api.github.com/repos/piwik/piwik/subscription","commits_url":"https://api.github.com/repos/piwik/piwik/commits{/sha}","git_commits_url":"https://api.github.com/repos/piwik/piwik/git/commits{/sha}","comments_url":"https://api.github.com/repos/piwik/piwik/comments{/number}","issue_comment_url":"https://api.github.com/repos/piwik/piwik/issues/comments{/number}","contents_url":"https://api.github.com/repos/piwik/piwik/contents/{+path}","compare_url":"https://api.github.com/repos/piwik/piwik/compare/{base}...{head}","merges_url":"https://api.github.com/repos/piwik/piwik/merges","archive_url":"https://api.github.com/repos/piwik/piwik/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/piwik/piwik/downloads","issues_url":"https://api.github.com/repos/piwik/piwik/issues{/number}","pulls_url":"https://api.github.com/repos/piwik/piwik/pulls{/number}","milestones_url":"https://api.github.com/repos/piwik/piwik/milestones{/number}","notifications_url":"https://api.github.com/repos/piwik/piwik/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/piwik/piwik/labels{/name}","releases_url":"https://api.github.com/repos/piwik/piwik/releases{/id}","created_at":"2011-03-30T21:18:17Z","updated_at":"2015-07-11T12:32:07Z","pushed_at":"2015-07-11T17:02:56Z","git_url":"git://github.com/piwik/piwik.git","ssh_url":"git@github.com:piwik/piwik.git","clone_url":"https://github.com/piwik/piwik.git","svn_url":"https://github.com/piwik/piwik","homepage":"http://piwik.org/","size":337312,"stargazers_count":4112,"watchers_count":4112,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":761,"mirror_url":null,"open_issues_count":1112,"forks":761,"open_issues":1112,"watchers":4112,"default_branch":"master"}},"base":{"label":"piwik:master","ref":"master","sha":"ef015e3ffd25f6d53e745bc5dea374332d550964","user":{"login":"piwik","id":698038,"avatar_url":"https://avatars.githubusercontent.com/u/698038?v=3","gravatar_id":"","url":"https://api.github.com/users/piwik","html_url":"https://github.com/piwik","followers_url":"https://api.github.com/users/piwik/followers","following_url":"https://api.github.com/users/piwik/following{/other_user}","gists_url":"https://api.github.com/users/piwik/gists{/gist_id}","starred_url":"https://api.github.com/users/piwik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piwik/subscriptions","organizations_url":"https://api.github.com/users/piwik/orgs","repos_url":"https://api.github.com/users/piwik/repos","events_url":"https://api.github.com/users/piwik/events{/privacy}","received_events_url":"https://api.github.com/users/piwik/received_events","type":"Organization","site_admin":false},"repo":{"id":1548202,"name":"piwik","full_name":"piwik/piwik","owner":{"login":"piwik","id":698038,"avatar_url":"https://avatars.githubusercontent.com/u/698038?v=3","gravatar_id":"","url":"https://api.github.com/users/piwik","html_url":"https://github.com/piwik","followers_url":"https://api.github.com/users/piwik/followers","following_url":"https://api.github.com/users/piwik/following{/other_user}","gists_url":"https://api.github.com/users/piwik/gists{/gist_id}","starred_url":"https://api.github.com/users/piwik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piwik/subscriptions","organizations_url":"https://api.github.com/users/piwik/orgs","repos_url":"https://api.github.com/users/piwik/repos","events_url":"https://api.github.com/users/piwik/events{/privacy}","received_events_url":"https://api.github.com/users/piwik/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/piwik/piwik","description":"Liberating Web Analytics. Star us on Github? +1. Piwik is the leading open alternative to Google Analytics that gives you full control over your data. Piwik lets you easily collect data from websites, apps & IoT and visualise this data and extract insights. Privacy is built-in. We love Pull Requests! ","fork":false,"url":"https://api.github.com/repos/piwik/piwik","forks_url":"https://api.github.com/repos/piwik/piwik/forks","keys_url":"https://api.github.com/repos/piwik/piwik/keys{/key_id}","collaborators_url":"https://api.github.com/repos/piwik/piwik/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/piwik/piwik/teams","hooks_url":"https://api.github.com/repos/piwik/piwik/hooks","issue_events_url":"https://api.github.com/repos/piwik/piwik/issues/events{/number}","events_url":"https://api.github.com/repos/piwik/piwik/events","assignees_url":"https://api.github.com/repos/piwik/piwik/assignees{/user}","branches_url":"https://api.github.com/repos/piwik/piwik/branches{/branch}","tags_url":"https://api.github.com/repos/piwik/piwik/tags","blobs_url":"https://api.github.com/repos/piwik/piwik/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/piwik/piwik/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/piwik/piwik/git/refs{/sha}","trees_url":"https://api.github.com/repos/piwik/piwik/git/trees{/sha}","statuses_url":"https://api.github.com/repos/piwik/piwik/statuses/{sha}","languages_url":"https://api.github.com/repos/piwik/piwik/languages","stargazers_url":"https://api.github.com/repos/piwik/piwik/stargazers","contributors_url":"https://api.github.com/repos/piwik/piwik/contributors","subscribers_url":"https://api.github.com/repos/piwik/piwik/subscribers","subscription_url":"https://api.github.com/repos/piwik/piwik/subscription","commits_url":"https://api.github.com/repos/piwik/piwik/commits{/sha}","git_commits_url":"https://api.github.com/repos/piwik/piwik/git/commits{/sha}","comments_url":"https://api.github.com/repos/piwik/piwik/comments{/number}","issue_comment_url":"https://api.github.com/repos/piwik/piwik/issues/comments{/number}","contents_url":"https://api.github.com/repos/piwik/piwik/contents/{+path}","compare_url":"https://api.github.com/repos/piwik/piwik/compare/{base}...{head}","merges_url":"https://api.github.com/repos/piwik/piwik/merges","archive_url":"https://api.github.com/repos/piwik/piwik/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/piwik/piwik/downloads","issues_url":"https://api.github.com/repos/piwik/piwik/issues{/number}","pulls_url":"https://api.github.com/repos/piwik/piwik/pulls{/number}","milestones_url":"https://api.github.com/repos/piwik/piwik/milestones{/number}","notifications_url":"https://api.github.com/repos/piwik/piwik/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/piwik/piwik/labels{/name}","releases_url":"https://api.github.com/repos/piwik/piwik/releases{/id}","created_at":"2011-03-30T21:18:17Z","updated_at":"2015-07-11T12:32:07Z","pushed_at":"2015-07-11T17:02:56Z","git_url":"git://github.com/piwik/piwik.git","ssh_url":"git@github.com:piwik/piwik.git","clone_url":"https://github.com/piwik/piwik.git","svn_url":"https://github.com/piwik/piwik","homepage":"http://piwik.org/","size":337312,"stargazers_count":4112,"watchers_count":4112,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":761,"mirror_url":null,"open_issues_count":1112,"forks":761,"open_issues":1112,"watchers":4112,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/piwik/piwik/pulls/8330"},"html":{"href":"https://github.com/piwik/piwik/pull/8330"},"issue":{"href":"https://api.github.com/repos/piwik/piwik/issues/8330"},"comments":{"href":"https://api.github.com/repos/piwik/piwik/issues/8330/comments"},"review_comments":{"href":"https://api.github.com/repos/piwik/piwik/pulls/8330/comments"},"review_comment":{"href":"https://api.github.com/repos/piwik/piwik/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/piwik/piwik/pulls/8330/commits"},"statuses":{"href":"https://api.github.com/repos/piwik/piwik/statuses/7c99419e8ec0b5a3acc076a17eb8fc37ac87d285"}}}}