{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/42920087","id":42920087,"diff_hunk":"@@ -198,10 +187,9 @@\n     boolean isAvailable( long timeout );","path":"community/kernel/src/main/java/org/neo4j/graphdb/GraphDatabaseService.java","position":34,"original_position":34,"commit_id":"996bfddd3d5339929eabc9289da8d6b0290fe3a5","original_commit_id":"996bfddd3d5339929eabc9289da8d6b0290fe3a5","user":{"login":"thobe","id":104385,"avatar_url":"https://avatars.githubusercontent.com/u/104385?v=3","gravatar_id":"","url":"https://api.github.com/users/thobe","html_url":"https://github.com/thobe","followers_url":"https://api.github.com/users/thobe/followers","following_url":"https://api.github.com/users/thobe/following{/other_user}","gists_url":"https://api.github.com/users/thobe/gists{/gist_id}","starred_url":"https://api.github.com/users/thobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thobe/subscriptions","organizations_url":"https://api.github.com/users/thobe/orgs","repos_url":"https://api.github.com/users/thobe/repos","events_url":"https://api.github.com/users/thobe/events{/privacy}","received_events_url":"https://api.github.com/users/thobe/received_events","type":"User","site_admin":false},"body":"Should this method perhaps also be deprecated?","created_at":"2015-10-23T22:13:19Z","updated_at":"2015-10-23T22:13:19Z","html_url":"https://github.com/neo4j/neo4j/pull/5718#discussion_r42920087","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/5718","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/42920087"},"html":{"href":"https://github.com/neo4j/neo4j/pull/5718#discussion_r42920087"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/5718"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/5718","id":48592611,"html_url":"https://github.com/neo4j/neo4j/pull/5718","diff_url":"https://github.com/neo4j/neo4j/pull/5718.diff","patch_url":"https://github.com/neo4j/neo4j/pull/5718.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/5718","number":5718,"state":"open","locked":false,"title":"Introduce simplified builders for GraphDatabase","user":{"login":"cleishm","id":79651,"avatar_url":"https://avatars.githubusercontent.com/u/79651?v=3","gravatar_id":"","url":"https://api.github.com/users/cleishm","html_url":"https://github.com/cleishm","followers_url":"https://api.github.com/users/cleishm/followers","following_url":"https://api.github.com/users/cleishm/following{/other_user}","gists_url":"https://api.github.com/users/cleishm/gists{/gist_id}","starred_url":"https://api.github.com/users/cleishm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cleishm/subscriptions","organizations_url":"https://api.github.com/users/cleishm/orgs","repos_url":"https://api.github.com/users/cleishm/repos","events_url":"https://api.github.com/users/cleishm/events{/privacy}","received_events_url":"https://api.github.com/users/cleishm/received_events","type":"User","site_admin":false},"body":"\r\n* **This is a 3.0 based version of #4674, which was deferred until the 3.0 work could be started**\r\n\r\nIncludes:\r\n\r\nclass | description\r\n-------|-------\r\n`org.neo4j.embedded.GraphDatabase` | An interface for a Neo4j Graph Database that holds additional methods necessary for managing the database instance itself, in addition to the graph API methods inherited from `GraphDatabaseService`. Construction of such a class is done via static constructor methods `#open(File)` and `#build()`.\r\n`org.neo4j.embedded.TestGraphDatabase` | An extension to the `GraphDatabase` interface, providing methods useful for internal testing. Static constructor methods for test databases include regular and ephemeral versions `#open(File)`, `#openEphemeral()`, `#build()` and `#buildEphemeral()`.\r\n`org.neo4j.embedded.HighAvailabilityGraphDatabase` | An interface for a Neo4j High Availability graph database, extending `GraphDatabase`, and including methods relevant to managing and monitoring an enterprise HA instance. Static constructor methods for HighAvailabilityGraphDatabases include configuration directives relevant to enterprise HA instances.\r\n`org.neo4j.embedded.HighAvailabilityTestGraphDatabase` | An extension to the `HighAvailabilityGraphDatabase` interface, providing methods useful for internal testing.\r\n\r\nFor common use, the static `#open(...)` method provides a convenient way to start an embedded graph database. I.e.:\r\n\r\n```\r\n    GraphDatabase db = GraphDatabase.open( new File(\"/var/graph.db\") );\r\n``` \r\n\r\nThe static `#build()` constructor methods return a builder that uses a fluent, programatic construction for injecting dependencies. I.e.:\r\n\r\n```\r\n    GraphDatabase db = GraphDatabase.build()\r\n            .withLogProvider( customLogProvider )\r\n            .open( new File(\"/var/graph.db\") );\r\n```\r\n\r\nNotes:\r\n* Also opens the way to leverage Rickard's improvements breaking up `InternalAbstractGraphDatabase` by providing full dependency injection of all configuration and components (like shared page caches) into the graph database at construction, and skipping the use of `Config` or requiring overriding of internal methods in order to do injection.\r\n\r\nWritten with input from @lutovich and @thobe.","created_at":"2015-10-23T15:17:16Z","updated_at":"2015-10-23T22:13:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"458ebb0623715fa9f4dfd1a296a9906e29e883c9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/5718/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/5718/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/5718/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/996bfddd3d5339929eabc9289da8d6b0290fe3a5","head":{"label":"cleishm:3.0-graphdb-builders","ref":"3.0-graphdb-builders","sha":"996bfddd3d5339929eabc9289da8d6b0290fe3a5","user":{"login":"cleishm","id":79651,"avatar_url":"https://avatars.githubusercontent.com/u/79651?v=3","gravatar_id":"","url":"https://api.github.com/users/cleishm","html_url":"https://github.com/cleishm","followers_url":"https://api.github.com/users/cleishm/followers","following_url":"https://api.github.com/users/cleishm/following{/other_user}","gists_url":"https://api.github.com/users/cleishm/gists{/gist_id}","starred_url":"https://api.github.com/users/cleishm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cleishm/subscriptions","organizations_url":"https://api.github.com/users/cleishm/orgs","repos_url":"https://api.github.com/users/cleishm/repos","events_url":"https://api.github.com/users/cleishm/events{/privacy}","received_events_url":"https://api.github.com/users/cleishm/received_events","type":"User","site_admin":false},"repo":{"id":7042869,"name":"neo4j","full_name":"cleishm/neo4j","owner":{"login":"cleishm","id":79651,"avatar_url":"https://avatars.githubusercontent.com/u/79651?v=3","gravatar_id":"","url":"https://api.github.com/users/cleishm","html_url":"https://github.com/cleishm","followers_url":"https://api.github.com/users/cleishm/followers","following_url":"https://api.github.com/users/cleishm/following{/other_user}","gists_url":"https://api.github.com/users/cleishm/gists{/gist_id}","starred_url":"https://api.github.com/users/cleishm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cleishm/subscriptions","organizations_url":"https://api.github.com/users/cleishm/orgs","repos_url":"https://api.github.com/users/cleishm/repos","events_url":"https://api.github.com/users/cleishm/events{/privacy}","received_events_url":"https://api.github.com/users/cleishm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cleishm/neo4j","description":"","fork":true,"url":"https://api.github.com/repos/cleishm/neo4j","forks_url":"https://api.github.com/repos/cleishm/neo4j/forks","keys_url":"https://api.github.com/repos/cleishm/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cleishm/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cleishm/neo4j/teams","hooks_url":"https://api.github.com/repos/cleishm/neo4j/hooks","issue_events_url":"https://api.github.com/repos/cleishm/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/cleishm/neo4j/events","assignees_url":"https://api.github.com/repos/cleishm/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/cleishm/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/cleishm/neo4j/tags","blobs_url":"https://api.github.com/repos/cleishm/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cleishm/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cleishm/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/cleishm/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cleishm/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/cleishm/neo4j/languages","stargazers_url":"https://api.github.com/repos/cleishm/neo4j/stargazers","contributors_url":"https://api.github.com/repos/cleishm/neo4j/contributors","subscribers_url":"https://api.github.com/repos/cleishm/neo4j/subscribers","subscription_url":"https://api.github.com/repos/cleishm/neo4j/subscription","commits_url":"https://api.github.com/repos/cleishm/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/cleishm/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/cleishm/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/cleishm/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/cleishm/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/cleishm/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cleishm/neo4j/merges","archive_url":"https://api.github.com/repos/cleishm/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cleishm/neo4j/downloads","issues_url":"https://api.github.com/repos/cleishm/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/cleishm/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/cleishm/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/cleishm/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cleishm/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/cleishm/neo4j/releases{/id}","created_at":"2012-12-06T20:59:16Z","updated_at":"2015-04-30T18:16:35Z","pushed_at":"2015-10-23T21:29:45Z","git_url":"git://github.com/cleishm/neo4j.git","ssh_url":"git@github.com:cleishm/neo4j.git","clone_url":"https://github.com/cleishm/neo4j.git","svn_url":"https://github.com/cleishm/neo4j","homepage":"http://neo4j.org","size":210748,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.3"}},"base":{"label":"neo4j:3.0","ref":"3.0","sha":"3ee697c7267c4f0ab99c3e74458ecb51f835de72","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","created_at":"2012-11-12T08:46:15Z","updated_at":"2015-10-23T22:08:46Z","pushed_at":"2015-10-23T21:29:46Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":553682,"stargazers_count":2053,"watchers_count":2053,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":771,"mirror_url":null,"open_issues_count":511,"forks":771,"open_issues":511,"watchers":2053,"default_branch":"3.0"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/5718"},"html":{"href":"https://github.com/neo4j/neo4j/pull/5718"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/5718"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/5718/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/5718/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/5718/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/996bfddd3d5339929eabc9289da8d6b0290fe3a5"}}}}