{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/32169712","id":32169712,"diff_hunk":"@@ -23,7 +23,8 @@ define(function (require) {\n         };\n \n         $scope.tooltip = function (column) {\n-          if (!sortableField(column)) return ''; else return 'Sort by ' + shortDotsFilter(column);\n+          if (!sortableField(column)) return '';","path":"src/kibana/components/doc_table/components/table_header.js","position":5,"original_position":5,"commit_id":"48b139ec6b03f3916555a8e2ba37240d56cb0377","original_commit_id":"48b139ec6b03f3916555a8e2ba37240d56cb0377","user":{"login":"spalger","id":1329312,"avatar_url":"https://avatars.githubusercontent.com/u/1329312?v=3","gravatar_id":"","url":"https://api.github.com/users/spalger","html_url":"https://github.com/spalger","followers_url":"https://api.github.com/users/spalger/followers","following_url":"https://api.github.com/users/spalger/following{/other_user}","gists_url":"https://api.github.com/users/spalger/gists{/gist_id}","starred_url":"https://api.github.com/users/spalger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalger/subscriptions","organizations_url":"https://api.github.com/users/spalger/orgs","repos_url":"https://api.github.com/users/spalger/repos","events_url":"https://api.github.com/users/spalger/events{/privacy}","received_events_url":"https://api.github.com/users/spalger/received_events","type":"User","site_admin":false},"body":":heart: ","created_at":"2015-06-10T21:38:20Z","updated_at":"2015-06-10T21:38:20Z","html_url":"https://github.com/elastic/kibana/pull/3571#discussion_r32169712","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/3571","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/32169712"},"html":{"href":"https://github.com/elastic/kibana/pull/3571#discussion_r32169712"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/3571"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/3571","id":33004984,"html_url":"https://github.com/elastic/kibana/pull/3571","diff_url":"https://github.com/elastic/kibana/pull/3571.diff","patch_url":"https://github.com/elastic/kibana/pull/3571.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/3571","number":3571,"state":"open","locked":false,"title":"Allow sorting by scripted fields","user":{"login":"w33ble","id":404731,"avatar_url":"https://avatars.githubusercontent.com/u/404731?v=3","gravatar_id":"","url":"https://api.github.com/users/w33ble","html_url":"https://github.com/w33ble","followers_url":"https://api.github.com/users/w33ble/followers","following_url":"https://api.github.com/users/w33ble/following{/other_user}","gists_url":"https://api.github.com/users/w33ble/gists{/gist_id}","starred_url":"https://api.github.com/users/w33ble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w33ble/subscriptions","organizations_url":"https://api.github.com/users/w33ble/orgs","repos_url":"https://api.github.com/users/w33ble/repos","events_url":"https://api.github.com/users/w33ble/events{/privacy}","received_events_url":"https://api.github.com/users/w33ble/received_events","type":"User","site_admin":false},"body":"Closes #3228\r\n\r\nIf a field is a scripted field, and is of a type that can be sorted, it can now be used to sort data via [script based sorting](http://www.elastic.co/guide/en/elasticsearch/reference/current/search-request-sort.html#_script_based_sorting)\r\n\r\n- Handle script based sorting\r\n- Allow sorting by scripted fields (if `type.sortable == true`)\r\n","created_at":"2015-04-09T23:04:15Z","updated_at":"2015-06-10T21:38:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"38f737fc7562ea23613986d1b9d038fe6ef01ad4","assignee":{"login":"spalger","id":1329312,"avatar_url":"https://avatars.githubusercontent.com/u/1329312?v=3","gravatar_id":"","url":"https://api.github.com/users/spalger","html_url":"https://github.com/spalger","followers_url":"https://api.github.com/users/spalger/followers","following_url":"https://api.github.com/users/spalger/following{/other_user}","gists_url":"https://api.github.com/users/spalger/gists{/gist_id}","starred_url":"https://api.github.com/users/spalger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalger/subscriptions","organizations_url":"https://api.github.com/users/spalger/orgs","repos_url":"https://api.github.com/users/spalger/repos","events_url":"https://api.github.com/users/spalger/events{/privacy}","received_events_url":"https://api.github.com/users/spalger/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/3571/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/3571/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/3571/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/48b139ec6b03f3916555a8e2ba37240d56cb0377","head":{"label":"w33ble:sort-by-scripted","ref":"sort-by-scripted","sha":"48b139ec6b03f3916555a8e2ba37240d56cb0377","user":{"login":"w33ble","id":404731,"avatar_url":"https://avatars.githubusercontent.com/u/404731?v=3","gravatar_id":"","url":"https://api.github.com/users/w33ble","html_url":"https://github.com/w33ble","followers_url":"https://api.github.com/users/w33ble/followers","following_url":"https://api.github.com/users/w33ble/following{/other_user}","gists_url":"https://api.github.com/users/w33ble/gists{/gist_id}","starred_url":"https://api.github.com/users/w33ble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w33ble/subscriptions","organizations_url":"https://api.github.com/users/w33ble/orgs","repos_url":"https://api.github.com/users/w33ble/repos","events_url":"https://api.github.com/users/w33ble/events{/privacy}","received_events_url":"https://api.github.com/users/w33ble/received_events","type":"User","site_admin":false},"repo":{"id":21840088,"name":"kibana","full_name":"w33ble/kibana","owner":{"login":"w33ble","id":404731,"avatar_url":"https://avatars.githubusercontent.com/u/404731?v=3","gravatar_id":"","url":"https://api.github.com/users/w33ble","html_url":"https://github.com/w33ble","followers_url":"https://api.github.com/users/w33ble/followers","following_url":"https://api.github.com/users/w33ble/following{/other_user}","gists_url":"https://api.github.com/users/w33ble/gists{/gist_id}","starred_url":"https://api.github.com/users/w33ble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w33ble/subscriptions","organizations_url":"https://api.github.com/users/w33ble/orgs","repos_url":"https://api.github.com/users/w33ble/repos","events_url":"https://api.github.com/users/w33ble/events{/privacy}","received_events_url":"https://api.github.com/users/w33ble/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/w33ble/kibana","description":"Kibana","fork":true,"url":"https://api.github.com/repos/w33ble/kibana","forks_url":"https://api.github.com/repos/w33ble/kibana/forks","keys_url":"https://api.github.com/repos/w33ble/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w33ble/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w33ble/kibana/teams","hooks_url":"https://api.github.com/repos/w33ble/kibana/hooks","issue_events_url":"https://api.github.com/repos/w33ble/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/w33ble/kibana/events","assignees_url":"https://api.github.com/repos/w33ble/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/w33ble/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/w33ble/kibana/tags","blobs_url":"https://api.github.com/repos/w33ble/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w33ble/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w33ble/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/w33ble/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w33ble/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/w33ble/kibana/languages","stargazers_url":"https://api.github.com/repos/w33ble/kibana/stargazers","contributors_url":"https://api.github.com/repos/w33ble/kibana/contributors","subscribers_url":"https://api.github.com/repos/w33ble/kibana/subscribers","subscription_url":"https://api.github.com/repos/w33ble/kibana/subscription","commits_url":"https://api.github.com/repos/w33ble/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/w33ble/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/w33ble/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/w33ble/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/w33ble/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/w33ble/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w33ble/kibana/merges","archive_url":"https://api.github.com/repos/w33ble/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w33ble/kibana/downloads","issues_url":"https://api.github.com/repos/w33ble/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/w33ble/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/w33ble/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/w33ble/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w33ble/kibana/labels{/name}","releases_url":"https://api.github.com/repos/w33ble/kibana/releases{/id}","created_at":"2014-07-14T23:59:39Z","updated_at":"2015-05-08T18:17:10Z","pushed_at":"2015-06-10T21:12:52Z","git_url":"git://github.com/w33ble/kibana.git","ssh_url":"git@github.com:w33ble/kibana.git","clone_url":"https://github.com/w33ble/kibana.git","svn_url":"https://github.com/w33ble/kibana","homepage":"http://www.elasticsearch.org/overview/kibana/","size":57736,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"db338e79e0c7a6a40305d9982f9428e53ac9559f","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":"Kibana","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","created_at":"2013-01-26T04:00:59Z","updated_at":"2015-06-10T20:00:17Z","pushed_at":"2015-06-10T21:14:42Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":90574,"stargazers_count":3676,"watchers_count":3676,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1353,"mirror_url":null,"open_issues_count":540,"forks":1353,"open_issues":540,"watchers":3676,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/3571"},"html":{"href":"https://github.com/elastic/kibana/pull/3571"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/3571"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/3571/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/3571/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/3571/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/48b139ec6b03f3916555a8e2ba37240d56cb0377"}}}}