{"action":"closed","number":9,"pull_request":{"url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/pulls/9","id":40471414,"html_url":"https://github.com/PatWie/CppNumericalSolvers/pull/9","diff_url":"https://github.com/PatWie/CppNumericalSolvers/pull/9.diff","patch_url":"https://github.com/PatWie/CppNumericalSolvers/pull/9.patch","issue_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/issues/9","number":9,"state":"closed","locked":false,"title":"Removed min/max macros to prevent header include problems with LLVM.","user":{"login":"spinicist","id":11050744,"avatar_url":"https://avatars.githubusercontent.com/u/11050744?v=3","gravatar_id":"","url":"https://api.github.com/users/spinicist","html_url":"https://github.com/spinicist","followers_url":"https://api.github.com/users/spinicist/followers","following_url":"https://api.github.com/users/spinicist/following{/other_user}","gists_url":"https://api.github.com/users/spinicist/gists{/gist_id}","starred_url":"https://api.github.com/users/spinicist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinicist/subscriptions","organizations_url":"https://api.github.com/users/spinicist/orgs","repos_url":"https://api.github.com/users/spinicist/repos","events_url":"https://api.github.com/users/spinicist/events{/privacy}","received_events_url":"https://api.github.com/users/spinicist/received_events","type":"User","site_admin":false},"body":"Hello,\r\nI am trying your LBFGS solver in my application. I had similar problems to this bug in Eigen: https://bitbucket.org/eigen/eigen/pull-request/81/fix-for-warning-on-macro-definitions-of/diff\r\n\r\nThe best way I found of fixing it was to remove the macros and use the std::min and std::max functions.\r\n\r\nThanks,\r\nToby","created_at":"2015-07-21T15:38:05Z","updated_at":"2015-07-22T07:34:15Z","closed_at":"2015-07-22T07:34:14Z","merged_at":"2015-07-22T07:34:14Z","merge_commit_sha":"27514819f5528644ae56b28f301a6e8e277116dc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/pulls/9/commits","review_comments_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/pulls/9/comments","review_comment_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/issues/9/comments","statuses_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/statuses/9b71e6677acf7b9bbe83c3f9c36d6e3bc5df5655","head":{"label":"spinicist:master","ref":"master","sha":"9b71e6677acf7b9bbe83c3f9c36d6e3bc5df5655","user":{"login":"spinicist","id":11050744,"avatar_url":"https://avatars.githubusercontent.com/u/11050744?v=3","gravatar_id":"","url":"https://api.github.com/users/spinicist","html_url":"https://github.com/spinicist","followers_url":"https://api.github.com/users/spinicist/followers","following_url":"https://api.github.com/users/spinicist/following{/other_user}","gists_url":"https://api.github.com/users/spinicist/gists{/gist_id}","starred_url":"https://api.github.com/users/spinicist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinicist/subscriptions","organizations_url":"https://api.github.com/users/spinicist/orgs","repos_url":"https://api.github.com/users/spinicist/repos","events_url":"https://api.github.com/users/spinicist/events{/privacy}","received_events_url":"https://api.github.com/users/spinicist/received_events","type":"User","site_admin":false},"repo":{"id":39454144,"name":"CppNumericalSolvers","full_name":"spinicist/CppNumericalSolvers","owner":{"login":"spinicist","id":11050744,"avatar_url":"https://avatars.githubusercontent.com/u/11050744?v=3","gravatar_id":"","url":"https://api.github.com/users/spinicist","html_url":"https://github.com/spinicist","followers_url":"https://api.github.com/users/spinicist/followers","following_url":"https://api.github.com/users/spinicist/following{/other_user}","gists_url":"https://api.github.com/users/spinicist/gists{/gist_id}","starred_url":"https://api.github.com/users/spinicist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinicist/subscriptions","organizations_url":"https://api.github.com/users/spinicist/orgs","repos_url":"https://api.github.com/users/spinicist/repos","events_url":"https://api.github.com/users/spinicist/events{/privacy}","received_events_url":"https://api.github.com/users/spinicist/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spinicist/CppNumericalSolvers","description":"L-BFGS-B implementation in C++11 using Eigen ","fork":true,"url":"https://api.github.com/repos/spinicist/CppNumericalSolvers","forks_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/forks","keys_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/teams","hooks_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/hooks","issue_events_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/issues/events{/number}","events_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/events","assignees_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/assignees{/user}","branches_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/branches{/branch}","tags_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/tags","blobs_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/statuses/{sha}","languages_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/languages","stargazers_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/stargazers","contributors_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/contributors","subscribers_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/subscribers","subscription_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/subscription","commits_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/contents/{+path}","compare_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/merges","archive_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/downloads","issues_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/issues{/number}","pulls_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/pulls{/number}","milestones_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/milestones{/number}","notifications_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/labels{/name}","releases_url":"https://api.github.com/repos/spinicist/CppNumericalSolvers/releases{/id}","created_at":"2015-07-21T15:36:13Z","updated_at":"2015-07-21T15:36:13Z","pushed_at":"2015-07-21T15:36:24Z","git_url":"git://github.com/spinicist/CppNumericalSolvers.git","ssh_url":"git@github.com:spinicist/CppNumericalSolvers.git","clone_url":"https://github.com/spinicist/CppNumericalSolvers.git","svn_url":"https://github.com/spinicist/CppNumericalSolvers","homepage":"","size":146,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PatWie:master","ref":"master","sha":"7cd1c639beca82fc2f3bcdc89db7326ea48d2c85","user":{"login":"PatWie","id":6756603,"avatar_url":"https://avatars.githubusercontent.com/u/6756603?v=3","gravatar_id":"","url":"https://api.github.com/users/PatWie","html_url":"https://github.com/PatWie","followers_url":"https://api.github.com/users/PatWie/followers","following_url":"https://api.github.com/users/PatWie/following{/other_user}","gists_url":"https://api.github.com/users/PatWie/gists{/gist_id}","starred_url":"https://api.github.com/users/PatWie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PatWie/subscriptions","organizations_url":"https://api.github.com/users/PatWie/orgs","repos_url":"https://api.github.com/users/PatWie/repos","events_url":"https://api.github.com/users/PatWie/events{/privacy}","received_events_url":"https://api.github.com/users/PatWie/received_events","type":"User","site_admin":false},"repo":{"id":20298959,"name":"CppNumericalSolvers","full_name":"PatWie/CppNumericalSolvers","owner":{"login":"PatWie","id":6756603,"avatar_url":"https://avatars.githubusercontent.com/u/6756603?v=3","gravatar_id":"","url":"https://api.github.com/users/PatWie","html_url":"https://github.com/PatWie","followers_url":"https://api.github.com/users/PatWie/followers","following_url":"https://api.github.com/users/PatWie/following{/other_user}","gists_url":"https://api.github.com/users/PatWie/gists{/gist_id}","starred_url":"https://api.github.com/users/PatWie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PatWie/subscriptions","organizations_url":"https://api.github.com/users/PatWie/orgs","repos_url":"https://api.github.com/users/PatWie/repos","events_url":"https://api.github.com/users/PatWie/events{/privacy}","received_events_url":"https://api.github.com/users/PatWie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PatWie/CppNumericalSolvers","description":"L-BFGS-B implementation in C++11 using Eigen ","fork":false,"url":"https://api.github.com/repos/PatWie/CppNumericalSolvers","forks_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/forks","keys_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/teams","hooks_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/hooks","issue_events_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/issues/events{/number}","events_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/events","assignees_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/assignees{/user}","branches_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/branches{/branch}","tags_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/tags","blobs_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/git/refs{/sha}","trees_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/statuses/{sha}","languages_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/languages","stargazers_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/stargazers","contributors_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/contributors","subscribers_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/subscribers","subscription_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/subscription","commits_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/commits{/sha}","git_commits_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/git/commits{/sha}","comments_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/comments{/number}","issue_comment_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/issues/comments{/number}","contents_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/contents/{+path}","compare_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/merges","archive_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/downloads","issues_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/issues{/number}","pulls_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/pulls{/number}","milestones_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/milestones{/number}","notifications_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/labels{/name}","releases_url":"https://api.github.com/repos/PatWie/CppNumericalSolvers/releases{/id}","created_at":"2014-05-29T15:45:13Z","updated_at":"2015-07-20T07:01:27Z","pushed_at":"2015-07-22T07:34:14Z","git_url":"git://github.com/PatWie/CppNumericalSolvers.git","ssh_url":"git@github.com:PatWie/CppNumericalSolvers.git","clone_url":"https://github.com/PatWie/CppNumericalSolvers.git","svn_url":"https://github.com/PatWie/CppNumericalSolvers","homepage":"","size":341,"stargazers_count":28,"watchers_count":28,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":2,"forks":13,"open_issues":2,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PatWie/CppNumericalSolvers/pulls/9"},"html":{"href":"https://github.com/PatWie/CppNumericalSolvers/pull/9"},"issue":{"href":"https://api.github.com/repos/PatWie/CppNumericalSolvers/issues/9"},"comments":{"href":"https://api.github.com/repos/PatWie/CppNumericalSolvers/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/PatWie/CppNumericalSolvers/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/PatWie/CppNumericalSolvers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PatWie/CppNumericalSolvers/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/PatWie/CppNumericalSolvers/statuses/9b71e6677acf7b9bbe83c3f9c36d6e3bc5df5655"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"PatWie","id":6756603,"avatar_url":"https://avatars.githubusercontent.com/u/6756603?v=3","gravatar_id":"","url":"https://api.github.com/users/PatWie","html_url":"https://github.com/PatWie","followers_url":"https://api.github.com/users/PatWie/followers","following_url":"https://api.github.com/users/PatWie/following{/other_user}","gists_url":"https://api.github.com/users/PatWie/gists{/gist_id}","starred_url":"https://api.github.com/users/PatWie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PatWie/subscriptions","organizations_url":"https://api.github.com/users/PatWie/orgs","repos_url":"https://api.github.com/users/PatWie/repos","events_url":"https://api.github.com/users/PatWie/events{/privacy}","received_events_url":"https://api.github.com/users/PatWie/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":8,"deletions":4,"changed_files":3}}