{"action":"closed","number":171,"pull_request":{"url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/pulls/171","id":31294041,"html_url":"https://github.com/davidjbradshaw/iframe-resizer/pull/171","diff_url":"https://github.com/davidjbradshaw/iframe-resizer/pull/171.diff","patch_url":"https://github.com/davidjbradshaw/iframe-resizer/pull/171.patch","issue_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/issues/171","number":171,"state":"closed","locked":false,"title":"Modified `close` to always trigger change","user":{"login":"ReedD","id":4931683,"avatar_url":"https://avatars.githubusercontent.com/u/4931683?v=3","gravatar_id":"","url":"https://api.github.com/users/ReedD","html_url":"https://github.com/ReedD","followers_url":"https://api.github.com/users/ReedD/followers","following_url":"https://api.github.com/users/ReedD/following{/other_user}","gists_url":"https://api.github.com/users/ReedD/gists{/gist_id}","starred_url":"https://api.github.com/users/ReedD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReedD/subscriptions","organizations_url":"https://api.github.com/users/ReedD/orgs","repos_url":"https://api.github.com/users/ReedD/repos","events_url":"https://api.github.com/users/ReedD/events{/privacy}","received_events_url":"https://api.github.com/users/ReedD/received_events","type":"User","site_admin":false},"body":"On line [577](https://github.com/davidjbradshaw/iframe-resizer/blob/master/src/iframeResizer.contentWindow.js#L577) `isSizeChangeDetected()` is called and returns `false` which I believe is the reason the event never propagates to the parent window. I simply modified the `close` event to send `Infinity` rather than 0. ","created_at":"2015-03-16T23:15:49Z","updated_at":"2015-03-17T07:58:41Z","closed_at":"2015-03-17T07:58:41Z","merged_at":"2015-03-17T07:58:41Z","merge_commit_sha":"bfba520ad0cad96ed508b2dedb649f79652faf77","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/pulls/171/commits","review_comments_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/pulls/171/comments","review_comment_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/issues/171/comments","statuses_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/statuses/6e1c963032f94f36da0ba3af22c130ed71883f7c","head":{"label":"ReedD:feature/close-fix","ref":"feature/close-fix","sha":"6e1c963032f94f36da0ba3af22c130ed71883f7c","user":{"login":"ReedD","id":4931683,"avatar_url":"https://avatars.githubusercontent.com/u/4931683?v=3","gravatar_id":"","url":"https://api.github.com/users/ReedD","html_url":"https://github.com/ReedD","followers_url":"https://api.github.com/users/ReedD/followers","following_url":"https://api.github.com/users/ReedD/following{/other_user}","gists_url":"https://api.github.com/users/ReedD/gists{/gist_id}","starred_url":"https://api.github.com/users/ReedD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReedD/subscriptions","organizations_url":"https://api.github.com/users/ReedD/orgs","repos_url":"https://api.github.com/users/ReedD/repos","events_url":"https://api.github.com/users/ReedD/events{/privacy}","received_events_url":"https://api.github.com/users/ReedD/received_events","type":"User","site_admin":false},"repo":{"id":32357767,"name":"iframe-resizer","full_name":"ReedD/iframe-resizer","owner":{"login":"ReedD","id":4931683,"avatar_url":"https://avatars.githubusercontent.com/u/4931683?v=3","gravatar_id":"","url":"https://api.github.com/users/ReedD","html_url":"https://github.com/ReedD","followers_url":"https://api.github.com/users/ReedD/followers","following_url":"https://api.github.com/users/ReedD/following{/other_user}","gists_url":"https://api.github.com/users/ReedD/gists{/gist_id}","starred_url":"https://api.github.com/users/ReedD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReedD/subscriptions","organizations_url":"https://api.github.com/users/ReedD/orgs","repos_url":"https://api.github.com/users/ReedD/repos","events_url":"https://api.github.com/users/ReedD/events{/privacy}","received_events_url":"https://api.github.com/users/ReedD/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ReedD/iframe-resizer","description":"Keep same and cross domain iFrames sized to their content with support for window/content resizing, in page links, nesting and multiple iFrames. (Dependency free, IE8+)","fork":true,"url":"https://api.github.com/repos/ReedD/iframe-resizer","forks_url":"https://api.github.com/repos/ReedD/iframe-resizer/forks","keys_url":"https://api.github.com/repos/ReedD/iframe-resizer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReedD/iframe-resizer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReedD/iframe-resizer/teams","hooks_url":"https://api.github.com/repos/ReedD/iframe-resizer/hooks","issue_events_url":"https://api.github.com/repos/ReedD/iframe-resizer/issues/events{/number}","events_url":"https://api.github.com/repos/ReedD/iframe-resizer/events","assignees_url":"https://api.github.com/repos/ReedD/iframe-resizer/assignees{/user}","branches_url":"https://api.github.com/repos/ReedD/iframe-resizer/branches{/branch}","tags_url":"https://api.github.com/repos/ReedD/iframe-resizer/tags","blobs_url":"https://api.github.com/repos/ReedD/iframe-resizer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReedD/iframe-resizer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReedD/iframe-resizer/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReedD/iframe-resizer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReedD/iframe-resizer/statuses/{sha}","languages_url":"https://api.github.com/repos/ReedD/iframe-resizer/languages","stargazers_url":"https://api.github.com/repos/ReedD/iframe-resizer/stargazers","contributors_url":"https://api.github.com/repos/ReedD/iframe-resizer/contributors","subscribers_url":"https://api.github.com/repos/ReedD/iframe-resizer/subscribers","subscription_url":"https://api.github.com/repos/ReedD/iframe-resizer/subscription","commits_url":"https://api.github.com/repos/ReedD/iframe-resizer/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReedD/iframe-resizer/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReedD/iframe-resizer/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReedD/iframe-resizer/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReedD/iframe-resizer/contents/{+path}","compare_url":"https://api.github.com/repos/ReedD/iframe-resizer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReedD/iframe-resizer/merges","archive_url":"https://api.github.com/repos/ReedD/iframe-resizer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReedD/iframe-resizer/downloads","issues_url":"https://api.github.com/repos/ReedD/iframe-resizer/issues{/number}","pulls_url":"https://api.github.com/repos/ReedD/iframe-resizer/pulls{/number}","milestones_url":"https://api.github.com/repos/ReedD/iframe-resizer/milestones{/number}","notifications_url":"https://api.github.com/repos/ReedD/iframe-resizer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReedD/iframe-resizer/labels{/name}","releases_url":"https://api.github.com/repos/ReedD/iframe-resizer/releases{/id}","created_at":"2015-03-16T22:51:59Z","updated_at":"2015-03-16T22:52:00Z","pushed_at":"2015-03-16T23:12:47Z","git_url":"git://github.com/ReedD/iframe-resizer.git","ssh_url":"git@github.com:ReedD/iframe-resizer.git","clone_url":"https://github.com/ReedD/iframe-resizer.git","svn_url":"https://github.com/ReedD/iframe-resizer","homepage":"http://davidjbradshaw.github.io/iframe-resizer/","size":3238,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"davidjbradshaw:master","ref":"master","sha":"ede823b1995f3a97ac1edd82c95568d734c6066b","user":{"login":"davidjbradshaw","id":591634,"avatar_url":"https://avatars.githubusercontent.com/u/591634?v=3","gravatar_id":"","url":"https://api.github.com/users/davidjbradshaw","html_url":"https://github.com/davidjbradshaw","followers_url":"https://api.github.com/users/davidjbradshaw/followers","following_url":"https://api.github.com/users/davidjbradshaw/following{/other_user}","gists_url":"https://api.github.com/users/davidjbradshaw/gists{/gist_id}","starred_url":"https://api.github.com/users/davidjbradshaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidjbradshaw/subscriptions","organizations_url":"https://api.github.com/users/davidjbradshaw/orgs","repos_url":"https://api.github.com/users/davidjbradshaw/repos","events_url":"https://api.github.com/users/davidjbradshaw/events{/privacy}","received_events_url":"https://api.github.com/users/davidjbradshaw/received_events","type":"User","site_admin":false},"repo":{"id":10696042,"name":"iframe-resizer","full_name":"davidjbradshaw/iframe-resizer","owner":{"login":"davidjbradshaw","id":591634,"avatar_url":"https://avatars.githubusercontent.com/u/591634?v=3","gravatar_id":"","url":"https://api.github.com/users/davidjbradshaw","html_url":"https://github.com/davidjbradshaw","followers_url":"https://api.github.com/users/davidjbradshaw/followers","following_url":"https://api.github.com/users/davidjbradshaw/following{/other_user}","gists_url":"https://api.github.com/users/davidjbradshaw/gists{/gist_id}","starred_url":"https://api.github.com/users/davidjbradshaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidjbradshaw/subscriptions","organizations_url":"https://api.github.com/users/davidjbradshaw/orgs","repos_url":"https://api.github.com/users/davidjbradshaw/repos","events_url":"https://api.github.com/users/davidjbradshaw/events{/privacy}","received_events_url":"https://api.github.com/users/davidjbradshaw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidjbradshaw/iframe-resizer","description":"Keep same and cross domain iFrames sized to their content with support for window/content resizing, in page links, nesting and multiple iFrames. (Dependency free, IE8+)","fork":false,"url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer","forks_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/forks","keys_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/teams","hooks_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/hooks","issue_events_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/issues/events{/number}","events_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/events","assignees_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/assignees{/user}","branches_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/branches{/branch}","tags_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/tags","blobs_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/statuses/{sha}","languages_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/languages","stargazers_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/stargazers","contributors_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/contributors","subscribers_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/subscribers","subscription_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/subscription","commits_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/contents/{+path}","compare_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/merges","archive_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/downloads","issues_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/issues{/number}","pulls_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/pulls{/number}","milestones_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/milestones{/number}","notifications_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/labels{/name}","releases_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/releases{/id}","created_at":"2013-06-14T19:18:32Z","updated_at":"2015-03-17T04:48:57Z","pushed_at":"2015-03-17T07:58:41Z","git_url":"git://github.com/davidjbradshaw/iframe-resizer.git","ssh_url":"git@github.com:davidjbradshaw/iframe-resizer.git","clone_url":"https://github.com/davidjbradshaw/iframe-resizer.git","svn_url":"https://github.com/davidjbradshaw/iframe-resizer","homepage":"http://davidjbradshaw.github.io/iframe-resizer/","size":3238,"stargazers_count":920,"watchers_count":920,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":136,"mirror_url":null,"open_issues_count":8,"forks":136,"open_issues":8,"watchers":920,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/pulls/171"},"html":{"href":"https://github.com/davidjbradshaw/iframe-resizer/pull/171"},"issue":{"href":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/issues/171"},"comments":{"href":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/issues/171/comments"},"review_comments":{"href":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/pulls/171/comments"},"review_comment":{"href":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/pulls/171/commits"},"statuses":{"href":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/statuses/6e1c963032f94f36da0ba3af22c130ed71883f7c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"davidjbradshaw","id":591634,"avatar_url":"https://avatars.githubusercontent.com/u/591634?v=3","gravatar_id":"","url":"https://api.github.com/users/davidjbradshaw","html_url":"https://github.com/davidjbradshaw","followers_url":"https://api.github.com/users/davidjbradshaw/followers","following_url":"https://api.github.com/users/davidjbradshaw/following{/other_user}","gists_url":"https://api.github.com/users/davidjbradshaw/gists{/gist_id}","starred_url":"https://api.github.com/users/davidjbradshaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidjbradshaw/subscriptions","organizations_url":"https://api.github.com/users/davidjbradshaw/orgs","repos_url":"https://api.github.com/users/davidjbradshaw/repos","events_url":"https://api.github.com/users/davidjbradshaw/events{/privacy}","received_events_url":"https://api.github.com/users/davidjbradshaw/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"commits":1,"additions":1,"deletions":1,"changed_files":1}}