{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/31198145","id":31198145,"diff_hunk":"@@ -77,7 +77,7 @@ type Transport struct {\n // RoundTrip implements the http.RoundTripper interface\n func (t *Transport) RoundTrip(req *http.Request) (*http.Response, error) {\n \t// Add reverse proxy headers.\n-\treq.Header.Set(\"X-Forwarded-Uri\", t.PathPrepend+req.URL.Path)\n+\treq.Header.Set(\"X-Forwarded-Uri\", path.Join(t.PathPrepend, req.URL.Path))","path":"pkg/util/proxy/transport.go","position":5,"original_position":5,"commit_id":"82167f193069b21ce47395bcbc7a9288b9489054","original_commit_id":"82167f193069b21ce47395bcbc7a9288b9489054","user":{"login":"csrwng","id":5834976,"avatar_url":"https://avatars.githubusercontent.com/u/5834976?v=3","gravatar_id":"","url":"https://api.github.com/users/csrwng","html_url":"https://github.com/csrwng","followers_url":"https://api.github.com/users/csrwng/followers","following_url":"https://api.github.com/users/csrwng/following{/other_user}","gists_url":"https://api.github.com/users/csrwng/gists{/gist_id}","starred_url":"https://api.github.com/users/csrwng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csrwng/subscriptions","organizations_url":"https://api.github.com/users/csrwng/orgs","repos_url":"https://api.github.com/users/csrwng/repos","events_url":"https://api.github.com/users/csrwng/events{/privacy}","received_events_url":"https://api.github.com/users/csrwng/received_events","type":"User","site_admin":false},"body":"no... the intent was to remove double slashes in the path. I'll fix it.","created_at":"2015-05-28T02:03:50Z","updated_at":"2015-05-28T02:03:50Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/8886#discussion_r31198145","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8886","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/31198145"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/8886#discussion_r31198145"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8886"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8886","id":36349501,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/8886","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/8886.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/8886.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/8886","number":8886,"state":"open","locked":false,"title":"Fix proxying of URLs that end in \"/\" in the pod proxy subresource","user":{"login":"csrwng","id":5834976,"avatar_url":"https://avatars.githubusercontent.com/u/5834976?v=3","gravatar_id":"","url":"https://api.github.com/users/csrwng","html_url":"https://github.com/csrwng","followers_url":"https://api.github.com/users/csrwng/followers","following_url":"https://api.github.com/users/csrwng/following{/other_user}","gists_url":"https://api.github.com/users/csrwng/gists{/gist_id}","starred_url":"https://api.github.com/users/csrwng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csrwng/subscriptions","organizations_url":"https://api.github.com/users/csrwng/orgs","repos_url":"https://api.github.com/users/csrwng/repos","events_url":"https://api.github.com/users/csrwng/events{/privacy}","received_events_url":"https://api.github.com/users/csrwng/received_events","type":"User","site_admin":false},"body":"Also handles proxying of URLs that have an empty path and don't end in a slash \"/\" by redirecting to the same location with a slash appended.","created_at":"2015-05-27T21:15:20Z","updated_at":"2015-05-28T02:03:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63104f8a13f38d4a5f315f10032629b4c8ba8324","assignee":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=3","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8886/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8886/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/8886/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/82167f193069b21ce47395bcbc7a9288b9489054","head":{"label":"csrwng:fix_proxy_url_slash","ref":"fix_proxy_url_slash","sha":"82167f193069b21ce47395bcbc7a9288b9489054","user":{"login":"csrwng","id":5834976,"avatar_url":"https://avatars.githubusercontent.com/u/5834976?v=3","gravatar_id":"","url":"https://api.github.com/users/csrwng","html_url":"https://github.com/csrwng","followers_url":"https://api.github.com/users/csrwng/followers","following_url":"https://api.github.com/users/csrwng/following{/other_user}","gists_url":"https://api.github.com/users/csrwng/gists{/gist_id}","starred_url":"https://api.github.com/users/csrwng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csrwng/subscriptions","organizations_url":"https://api.github.com/users/csrwng/orgs","repos_url":"https://api.github.com/users/csrwng/repos","events_url":"https://api.github.com/users/csrwng/events{/privacy}","received_events_url":"https://api.github.com/users/csrwng/received_events","type":"User","site_admin":false},"repo":{"id":21752113,"name":"kubernetes","full_name":"csrwng/kubernetes","owner":{"login":"csrwng","id":5834976,"avatar_url":"https://avatars.githubusercontent.com/u/5834976?v=3","gravatar_id":"","url":"https://api.github.com/users/csrwng","html_url":"https://github.com/csrwng","followers_url":"https://api.github.com/users/csrwng/followers","following_url":"https://api.github.com/users/csrwng/following{/other_user}","gists_url":"https://api.github.com/users/csrwng/gists{/gist_id}","starred_url":"https://api.github.com/users/csrwng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csrwng/subscriptions","organizations_url":"https://api.github.com/users/csrwng/orgs","repos_url":"https://api.github.com/users/csrwng/repos","events_url":"https://api.github.com/users/csrwng/events{/privacy}","received_events_url":"https://api.github.com/users/csrwng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/csrwng/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/csrwng/kubernetes","forks_url":"https://api.github.com/repos/csrwng/kubernetes/forks","keys_url":"https://api.github.com/repos/csrwng/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/csrwng/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/csrwng/kubernetes/teams","hooks_url":"https://api.github.com/repos/csrwng/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/csrwng/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/csrwng/kubernetes/events","assignees_url":"https://api.github.com/repos/csrwng/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/csrwng/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/csrwng/kubernetes/tags","blobs_url":"https://api.github.com/repos/csrwng/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/csrwng/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/csrwng/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/csrwng/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/csrwng/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/csrwng/kubernetes/languages","stargazers_url":"https://api.github.com/repos/csrwng/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/csrwng/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/csrwng/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/csrwng/kubernetes/subscription","commits_url":"https://api.github.com/repos/csrwng/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/csrwng/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/csrwng/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/csrwng/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/csrwng/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/csrwng/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/csrwng/kubernetes/merges","archive_url":"https://api.github.com/repos/csrwng/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/csrwng/kubernetes/downloads","issues_url":"https://api.github.com/repos/csrwng/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/csrwng/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/csrwng/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/csrwng/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/csrwng/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/csrwng/kubernetes/releases{/id}","created_at":"2014-07-11T21:33:52Z","updated_at":"2015-05-08T17:30:45Z","pushed_at":"2015-05-27T21:42:34Z","git_url":"git://github.com/csrwng/kubernetes.git","ssh_url":"git@github.com:csrwng/kubernetes.git","clone_url":"https://github.com/csrwng/kubernetes.git","svn_url":"https://github.com/csrwng/kubernetes","homepage":null,"size":58944,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"851f6b754241c01f30c43cddd2f9ca8c7c3f42f5","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-05-28T01:56:04Z","pushed_at":"2015-05-28T01:52:26Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":295015,"stargazers_count":7948,"watchers_count":7948,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1660,"mirror_url":null,"open_issues_count":1247,"forks":1660,"open_issues":1247,"watchers":7948,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8886"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/8886"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/8886"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/8886/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8886/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8886/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/82167f193069b21ce47395bcbc7a9288b9489054"}}}}