{"action":"closed","number":7,"pull_request":{"url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/pulls/7","id":43002273,"html_url":"https://github.com/MatiasFito/hexacta-fighter/pull/7","diff_url":"https://github.com/MatiasFito/hexacta-fighter/pull/7.diff","patch_url":"https://github.com/MatiasFito/hexacta-fighter/pull/7.patch","issue_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/issues/7","number":7,"state":"closed","locked":false,"title":"Refactor iteracion 1","user":{"login":"MatiasFito","id":7430004,"avatar_url":"https://avatars.githubusercontent.com/u/7430004?v=3","gravatar_id":"","url":"https://api.github.com/users/MatiasFito","html_url":"https://github.com/MatiasFito","followers_url":"https://api.github.com/users/MatiasFito/followers","following_url":"https://api.github.com/users/MatiasFito/following{/other_user}","gists_url":"https://api.github.com/users/MatiasFito/gists{/gist_id}","starred_url":"https://api.github.com/users/MatiasFito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatiasFito/subscriptions","organizations_url":"https://api.github.com/users/MatiasFito/orgs","repos_url":"https://api.github.com/users/MatiasFito/repos","events_url":"https://api.github.com/users/MatiasFito/events{/privacy}","received_events_url":"https://api.github.com/users/MatiasFito/received_events","type":"User","site_admin":false},"body":"* Ataque y defensa de la clase arma ahora son Integer para reflejar correctamente su valor.\r\n* Los constructores por defecto con todo en \"null\" que no se usaban fueron eliminados.\r\n* Los personajes que participan en una batalla no forman parte de sus atributos por lo tanto no estan en el constructor, esto facilitará que varios personajes puedan luchar en una batalla con X características que si serán propias de ella. El método que inicia la lucha es batalla.pelear(atacante, defensor)\r\n* Se desacopló la lógica de calcular el valor de los atributos calculados del personaje (ataque y defensa por ahora) creando la interfaz Atributo y los distintos atributos implementan su \"Estrategia\" de como calcularse.\r\n* Se desacopló la creacíon de los personajes al crear la clase PersonajeBuilder que garantiza la creación de objetos completos y facilita crear personajes, además si la forma en que se crean los personajes variase, solo hace falta modificarla en el PersonajeBuilder una vez y tendría efecto en toda la aplicación. Se adaptó el \"main\" para que utilice la nueva clase.","created_at":"2015-08-21T04:00:42Z","updated_at":"2015-08-21T04:01:04Z","closed_at":"2015-08-21T04:01:04Z","merged_at":"2015-08-21T04:01:04Z","merge_commit_sha":"68958b28dda2ad68d50488f17fb8cf239b2e8abc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/pulls/7/commits","review_comments_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/pulls/7/comments","review_comment_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/issues/7/comments","statuses_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/statuses/aefe6f082d4e93f4b319818477dd506e48c55d0b","head":{"label":"MatiasFito:refactor-iteracion-1","ref":"refactor-iteracion-1","sha":"aefe6f082d4e93f4b319818477dd506e48c55d0b","user":{"login":"MatiasFito","id":7430004,"avatar_url":"https://avatars.githubusercontent.com/u/7430004?v=3","gravatar_id":"","url":"https://api.github.com/users/MatiasFito","html_url":"https://github.com/MatiasFito","followers_url":"https://api.github.com/users/MatiasFito/followers","following_url":"https://api.github.com/users/MatiasFito/following{/other_user}","gists_url":"https://api.github.com/users/MatiasFito/gists{/gist_id}","starred_url":"https://api.github.com/users/MatiasFito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatiasFito/subscriptions","organizations_url":"https://api.github.com/users/MatiasFito/orgs","repos_url":"https://api.github.com/users/MatiasFito/repos","events_url":"https://api.github.com/users/MatiasFito/events{/privacy}","received_events_url":"https://api.github.com/users/MatiasFito/received_events","type":"User","site_admin":false},"repo":{"id":40764748,"name":"hexacta-fighter","full_name":"MatiasFito/hexacta-fighter","owner":{"login":"MatiasFito","id":7430004,"avatar_url":"https://avatars.githubusercontent.com/u/7430004?v=3","gravatar_id":"","url":"https://api.github.com/users/MatiasFito","html_url":"https://github.com/MatiasFito","followers_url":"https://api.github.com/users/MatiasFito/followers","following_url":"https://api.github.com/users/MatiasFito/following{/other_user}","gists_url":"https://api.github.com/users/MatiasFito/gists{/gist_id}","starred_url":"https://api.github.com/users/MatiasFito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatiasFito/subscriptions","organizations_url":"https://api.github.com/users/MatiasFito/orgs","repos_url":"https://api.github.com/users/MatiasFito/repos","events_url":"https://api.github.com/users/MatiasFito/events{/privacy}","received_events_url":"https://api.github.com/users/MatiasFito/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MatiasFito/hexacta-fighter","description":"Juego de peleas conceptual, para practicar modelado iterativo de objetos.","fork":false,"url":"https://api.github.com/repos/MatiasFito/hexacta-fighter","forks_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/forks","keys_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/teams","hooks_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/hooks","issue_events_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/issues/events{/number}","events_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/events","assignees_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/assignees{/user}","branches_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/branches{/branch}","tags_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/tags","blobs_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/git/refs{/sha}","trees_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/statuses/{sha}","languages_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/languages","stargazers_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/stargazers","contributors_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/contributors","subscribers_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/subscribers","subscription_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/subscription","commits_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/commits{/sha}","git_commits_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/git/commits{/sha}","comments_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/comments{/number}","issue_comment_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/issues/comments{/number}","contents_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/contents/{+path}","compare_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/merges","archive_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/downloads","issues_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/issues{/number}","pulls_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/pulls{/number}","milestones_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/milestones{/number}","notifications_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/labels{/name}","releases_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/releases{/id}","created_at":"2015-08-15T14:37:11Z","updated_at":"2015-08-16T20:38:05Z","pushed_at":"2015-08-21T04:01:04Z","git_url":"git://github.com/MatiasFito/hexacta-fighter.git","ssh_url":"git@github.com:MatiasFito/hexacta-fighter.git","clone_url":"https://github.com/MatiasFito/hexacta-fighter.git","svn_url":"https://github.com/MatiasFito/hexacta-fighter","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MatiasFito:master","ref":"master","sha":"a9adf4b8d941b0a51084992746d9d24e3ddf11b7","user":{"login":"MatiasFito","id":7430004,"avatar_url":"https://avatars.githubusercontent.com/u/7430004?v=3","gravatar_id":"","url":"https://api.github.com/users/MatiasFito","html_url":"https://github.com/MatiasFito","followers_url":"https://api.github.com/users/MatiasFito/followers","following_url":"https://api.github.com/users/MatiasFito/following{/other_user}","gists_url":"https://api.github.com/users/MatiasFito/gists{/gist_id}","starred_url":"https://api.github.com/users/MatiasFito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatiasFito/subscriptions","organizations_url":"https://api.github.com/users/MatiasFito/orgs","repos_url":"https://api.github.com/users/MatiasFito/repos","events_url":"https://api.github.com/users/MatiasFito/events{/privacy}","received_events_url":"https://api.github.com/users/MatiasFito/received_events","type":"User","site_admin":false},"repo":{"id":40764748,"name":"hexacta-fighter","full_name":"MatiasFito/hexacta-fighter","owner":{"login":"MatiasFito","id":7430004,"avatar_url":"https://avatars.githubusercontent.com/u/7430004?v=3","gravatar_id":"","url":"https://api.github.com/users/MatiasFito","html_url":"https://github.com/MatiasFito","followers_url":"https://api.github.com/users/MatiasFito/followers","following_url":"https://api.github.com/users/MatiasFito/following{/other_user}","gists_url":"https://api.github.com/users/MatiasFito/gists{/gist_id}","starred_url":"https://api.github.com/users/MatiasFito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatiasFito/subscriptions","organizations_url":"https://api.github.com/users/MatiasFito/orgs","repos_url":"https://api.github.com/users/MatiasFito/repos","events_url":"https://api.github.com/users/MatiasFito/events{/privacy}","received_events_url":"https://api.github.com/users/MatiasFito/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MatiasFito/hexacta-fighter","description":"Juego de peleas conceptual, para practicar modelado iterativo de objetos.","fork":false,"url":"https://api.github.com/repos/MatiasFito/hexacta-fighter","forks_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/forks","keys_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/teams","hooks_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/hooks","issue_events_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/issues/events{/number}","events_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/events","assignees_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/assignees{/user}","branches_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/branches{/branch}","tags_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/tags","blobs_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/git/refs{/sha}","trees_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/statuses/{sha}","languages_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/languages","stargazers_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/stargazers","contributors_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/contributors","subscribers_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/subscribers","subscription_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/subscription","commits_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/commits{/sha}","git_commits_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/git/commits{/sha}","comments_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/comments{/number}","issue_comment_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/issues/comments{/number}","contents_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/contents/{+path}","compare_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/merges","archive_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/downloads","issues_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/issues{/number}","pulls_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/pulls{/number}","milestones_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/milestones{/number}","notifications_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/labels{/name}","releases_url":"https://api.github.com/repos/MatiasFito/hexacta-fighter/releases{/id}","created_at":"2015-08-15T14:37:11Z","updated_at":"2015-08-16T20:38:05Z","pushed_at":"2015-08-21T04:01:04Z","git_url":"git://github.com/MatiasFito/hexacta-fighter.git","ssh_url":"git@github.com:MatiasFito/hexacta-fighter.git","clone_url":"https://github.com/MatiasFito/hexacta-fighter.git","svn_url":"https://github.com/MatiasFito/hexacta-fighter","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MatiasFito/hexacta-fighter/pulls/7"},"html":{"href":"https://github.com/MatiasFito/hexacta-fighter/pull/7"},"issue":{"href":"https://api.github.com/repos/MatiasFito/hexacta-fighter/issues/7"},"comments":{"href":"https://api.github.com/repos/MatiasFito/hexacta-fighter/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/MatiasFito/hexacta-fighter/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/MatiasFito/hexacta-fighter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MatiasFito/hexacta-fighter/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/MatiasFito/hexacta-fighter/statuses/aefe6f082d4e93f4b319818477dd506e48c55d0b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"MatiasFito","id":7430004,"avatar_url":"https://avatars.githubusercontent.com/u/7430004?v=3","gravatar_id":"","url":"https://api.github.com/users/MatiasFito","html_url":"https://github.com/MatiasFito","followers_url":"https://api.github.com/users/MatiasFito/followers","following_url":"https://api.github.com/users/MatiasFito/following{/other_user}","gists_url":"https://api.github.com/users/MatiasFito/gists{/gist_id}","starred_url":"https://api.github.com/users/MatiasFito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatiasFito/subscriptions","organizations_url":"https://api.github.com/users/MatiasFito/orgs","repos_url":"https://api.github.com/users/MatiasFito/repos","events_url":"https://api.github.com/users/MatiasFito/events{/privacy}","received_events_url":"https://api.github.com/users/MatiasFito/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":4,"additions":175,"deletions":111,"changed_files":10}}