{"action":"created","issue":{"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-environment/issues/6","labels_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-environment/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-environment/issues/6/comments","events_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-environment/issues/6/events","html_url":"https://github.com/logstash-plugins/logstash-filter-environment/pull/6","id":110684957,"number":6,"title":"Filters cannot use `type` to filter events","user":{"login":"ph","id":640,"avatar_url":"https://avatars.githubusercontent.com/u/640?v=3","gravatar_id":"","url":"https://api.github.com/users/ph","html_url":"https://github.com/ph","followers_url":"https://api.github.com/users/ph/followers","following_url":"https://api.github.com/users/ph/following{/other_user}","gists_url":"https://api.github.com/users/ph/gists{/gist_id}","starred_url":"https://api.github.com/users/ph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ph/subscriptions","organizations_url":"https://api.github.com/users/ph/orgs","repos_url":"https://api.github.com/users/ph/repos","events_url":"https://api.github.com/users/ph/events{/privacy}","received_events_url":"https://api.github.com/users/ph/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-environment/labels/breaking-compatibility","name":"breaking-compatibility","color":"eb6420"},{"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-environment/labels/bug","name":"bug","color":"e11d21"}],"state":"closed","locked":false,"assignee":{"login":"purbon","id":68540,"avatar_url":"https://avatars.githubusercontent.com/u/68540?v=3","gravatar_id":"","url":"https://api.github.com/users/purbon","html_url":"https://github.com/purbon","followers_url":"https://api.github.com/users/purbon/followers","following_url":"https://api.github.com/users/purbon/following{/other_user}","gists_url":"https://api.github.com/users/purbon/gists{/gist_id}","starred_url":"https://api.github.com/users/purbon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purbon/subscriptions","organizations_url":"https://api.github.com/users/purbon/orgs","repos_url":"https://api.github.com/users/purbon/repos","events_url":"https://api.github.com/users/purbon/events{/privacy}","received_events_url":"https://api.github.com/users/purbon/received_events","type":"User","site_admin":false},"milestone":null,"comments":8,"created_at":"2015-10-09T15:45:58Z","updated_at":"2015-10-13T21:47:38Z","closed_at":"2015-10-13T21:47:38Z","pull_request":{"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-environment/pulls/6","html_url":"https://github.com/logstash-plugins/logstash-filter-environment/pull/6","diff_url":"https://github.com/logstash-plugins/logstash-filter-environment/pull/6.diff","patch_url":"https://github.com/logstash-plugins/logstash-filter-environment/pull/6.patch"},"body":"Since we are removing the `filter?` method in the base class,\r\nusers will need to to update their configuration and use conditionals\r\ninstead of the `type` option.\r\n\r\nExample:\r\n```\r\nfilter {\r\n  environment {\r\n    type => \"foo\"\r\n    add_metadata_from_env => [ \"newfield\", \"MY_ENV_VAR\" ]\r\n  }\r\n}\r\n```\r\n\r\nBecome\r\n```\r\nfilter {\r\n  if [type] == \"foo\" {\r\n    environment {\r\n      type => \"foo\"\r\n      add_metadata_from_env => [ \"newfield\", \"MY_ENV_VAR\" ]\r\n    }\r\n  }\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-environment/issues/comments/147863496","html_url":"https://github.com/logstash-plugins/logstash-filter-environment/pull/6#issuecomment-147863496","issue_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-environment/issues/6","id":147863496,"user":{"login":"elasticsearch-bot","id":9386276,"avatar_url":"https://avatars.githubusercontent.com/u/9386276?v=3","gravatar_id":"","url":"https://api.github.com/users/elasticsearch-bot","html_url":"https://github.com/elasticsearch-bot","followers_url":"https://api.github.com/users/elasticsearch-bot/followers","following_url":"https://api.github.com/users/elasticsearch-bot/following{/other_user}","gists_url":"https://api.github.com/users/elasticsearch-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticsearch-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticsearch-bot/subscriptions","organizations_url":"https://api.github.com/users/elasticsearch-bot/orgs","repos_url":"https://api.github.com/users/elasticsearch-bot/repos","events_url":"https://api.github.com/users/elasticsearch-bot/events{/privacy}","received_events_url":"https://api.github.com/users/elasticsearch-bot/received_events","type":"User","site_admin":false},"created_at":"2015-10-13T21:47:38Z","updated_at":"2015-10-13T21:47:38Z","body":"Merged sucessfully into master!"}}