{"action":"closed","number":592,"pull_request":{"url":"https://api.github.com/repos/brian-team/brian2/pulls/592","id":49965657,"html_url":"https://github.com/brian-team/brian2/pull/592","diff_url":"https://github.com/brian-team/brian2/pull/592.diff","patch_url":"https://github.com/brian-team/brian2/pull/592.patch","issue_url":"https://api.github.com/repos/brian-team/brian2/issues/592","number":592,"state":"closed","locked":false,"title":"[MRG] Use compiler settings for maximal speed by default","user":{"login":"mstimberg","id":1381982,"avatar_url":"https://avatars.githubusercontent.com/u/1381982?v=3","gravatar_id":"","url":"https://api.github.com/users/mstimberg","html_url":"https://github.com/mstimberg","followers_url":"https://api.github.com/users/mstimberg/followers","following_url":"https://api.github.com/users/mstimberg/following{/other_user}","gists_url":"https://api.github.com/users/mstimberg/gists{/gist_id}","starred_url":"https://api.github.com/users/mstimberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstimberg/subscriptions","organizations_url":"https://api.github.com/users/mstimberg/orgs","repos_url":"https://api.github.com/users/mstimberg/repos","events_url":"https://api.github.com/users/mstimberg/events{/privacy}","received_events_url":"https://api.github.com/users/mstimberg/received_events","type":"User","site_admin":false},"body":"I just enabled the fast compilation options in this branch, testing on Linux did not show any test failures but we don't yet have the results from appveyor. If there's no problem, then it seems we do not actually have to change anything (apart from the documentation). I included an auto-detection of the arch flag for Windows in the same way it was done in standalone when you specified `native=True`. This makes the latter obsolete, do you think this is important enough to have as a specific keyword argument to build instead of having it set simply via the compiler options? I think users will build for their own machine in 99% of the cases and if not, they probably have to set some compiler/linker settings anyway, no?","created_at":"2015-11-06T15:22:36Z","updated_at":"2015-11-10T11:36:50Z","closed_at":"2015-11-10T11:36:50Z","merged_at":"2015-11-10T11:36:50Z","merge_commit_sha":"e43274ebbf9529c46b9f84a7d71a136b88d08439","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/brian-team/brian2/pulls/592/commits","review_comments_url":"https://api.github.com/repos/brian-team/brian2/pulls/592/comments","review_comment_url":"https://api.github.com/repos/brian-team/brian2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brian-team/brian2/issues/592/comments","statuses_url":"https://api.github.com/repos/brian-team/brian2/statuses/02ed214883160523a1fb03e411a936f08909c0f1","head":{"label":"brian-team:fast_math_by_default","ref":"fast_math_by_default","sha":"02ed214883160523a1fb03e411a936f08909c0f1","user":{"login":"brian-team","id":2292949,"avatar_url":"https://avatars.githubusercontent.com/u/2292949?v=3","gravatar_id":"","url":"https://api.github.com/users/brian-team","html_url":"https://github.com/brian-team","followers_url":"https://api.github.com/users/brian-team/followers","following_url":"https://api.github.com/users/brian-team/following{/other_user}","gists_url":"https://api.github.com/users/brian-team/gists{/gist_id}","starred_url":"https://api.github.com/users/brian-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brian-team/subscriptions","organizations_url":"https://api.github.com/users/brian-team/orgs","repos_url":"https://api.github.com/users/brian-team/repos","events_url":"https://api.github.com/users/brian-team/events{/privacy}","received_events_url":"https://api.github.com/users/brian-team/received_events","type":"Organization","site_admin":false},"repo":{"id":6884056,"name":"brian2","full_name":"brian-team/brian2","owner":{"login":"brian-team","id":2292949,"avatar_url":"https://avatars.githubusercontent.com/u/2292949?v=3","gravatar_id":"","url":"https://api.github.com/users/brian-team","html_url":"https://github.com/brian-team","followers_url":"https://api.github.com/users/brian-team/followers","following_url":"https://api.github.com/users/brian-team/following{/other_user}","gists_url":"https://api.github.com/users/brian-team/gists{/gist_id}","starred_url":"https://api.github.com/users/brian-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brian-team/subscriptions","organizations_url":"https://api.github.com/users/brian-team/orgs","repos_url":"https://api.github.com/users/brian-team/repos","events_url":"https://api.github.com/users/brian-team/events{/privacy}","received_events_url":"https://api.github.com/users/brian-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brian-team/brian2","description":"Brian2 is an improved and partly rewritten version of Brian, the spiking neural network simulator (see http://briansimulator.org). It is currently in a beta state, ready for testing.","fork":false,"url":"https://api.github.com/repos/brian-team/brian2","forks_url":"https://api.github.com/repos/brian-team/brian2/forks","keys_url":"https://api.github.com/repos/brian-team/brian2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brian-team/brian2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brian-team/brian2/teams","hooks_url":"https://api.github.com/repos/brian-team/brian2/hooks","issue_events_url":"https://api.github.com/repos/brian-team/brian2/issues/events{/number}","events_url":"https://api.github.com/repos/brian-team/brian2/events","assignees_url":"https://api.github.com/repos/brian-team/brian2/assignees{/user}","branches_url":"https://api.github.com/repos/brian-team/brian2/branches{/branch}","tags_url":"https://api.github.com/repos/brian-team/brian2/tags","blobs_url":"https://api.github.com/repos/brian-team/brian2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brian-team/brian2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brian-team/brian2/git/refs{/sha}","trees_url":"https://api.github.com/repos/brian-team/brian2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brian-team/brian2/statuses/{sha}","languages_url":"https://api.github.com/repos/brian-team/brian2/languages","stargazers_url":"https://api.github.com/repos/brian-team/brian2/stargazers","contributors_url":"https://api.github.com/repos/brian-team/brian2/contributors","subscribers_url":"https://api.github.com/repos/brian-team/brian2/subscribers","subscription_url":"https://api.github.com/repos/brian-team/brian2/subscription","commits_url":"https://api.github.com/repos/brian-team/brian2/commits{/sha}","git_commits_url":"https://api.github.com/repos/brian-team/brian2/git/commits{/sha}","comments_url":"https://api.github.com/repos/brian-team/brian2/comments{/number}","issue_comment_url":"https://api.github.com/repos/brian-team/brian2/issues/comments{/number}","contents_url":"https://api.github.com/repos/brian-team/brian2/contents/{+path}","compare_url":"https://api.github.com/repos/brian-team/brian2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brian-team/brian2/merges","archive_url":"https://api.github.com/repos/brian-team/brian2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brian-team/brian2/downloads","issues_url":"https://api.github.com/repos/brian-team/brian2/issues{/number}","pulls_url":"https://api.github.com/repos/brian-team/brian2/pulls{/number}","milestones_url":"https://api.github.com/repos/brian-team/brian2/milestones{/number}","notifications_url":"https://api.github.com/repos/brian-team/brian2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brian-team/brian2/labels{/name}","releases_url":"https://api.github.com/repos/brian-team/brian2/releases{/id}","created_at":"2012-11-27T13:46:43Z","updated_at":"2015-11-05T10:46:17Z","pushed_at":"2015-11-10T11:36:50Z","git_url":"git://github.com/brian-team/brian2.git","ssh_url":"git@github.com:brian-team/brian2.git","clone_url":"https://github.com/brian-team/brian2.git","svn_url":"https://github.com/brian-team/brian2","homepage":"","size":15036,"stargazers_count":54,"watchers_count":54,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":113,"forks":20,"open_issues":113,"watchers":54,"default_branch":"master"}},"base":{"label":"brian-team:master","ref":"master","sha":"dde39d8c57de1802a1efdaf2ffe784a0baee5617","user":{"login":"brian-team","id":2292949,"avatar_url":"https://avatars.githubusercontent.com/u/2292949?v=3","gravatar_id":"","url":"https://api.github.com/users/brian-team","html_url":"https://github.com/brian-team","followers_url":"https://api.github.com/users/brian-team/followers","following_url":"https://api.github.com/users/brian-team/following{/other_user}","gists_url":"https://api.github.com/users/brian-team/gists{/gist_id}","starred_url":"https://api.github.com/users/brian-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brian-team/subscriptions","organizations_url":"https://api.github.com/users/brian-team/orgs","repos_url":"https://api.github.com/users/brian-team/repos","events_url":"https://api.github.com/users/brian-team/events{/privacy}","received_events_url":"https://api.github.com/users/brian-team/received_events","type":"Organization","site_admin":false},"repo":{"id":6884056,"name":"brian2","full_name":"brian-team/brian2","owner":{"login":"brian-team","id":2292949,"avatar_url":"https://avatars.githubusercontent.com/u/2292949?v=3","gravatar_id":"","url":"https://api.github.com/users/brian-team","html_url":"https://github.com/brian-team","followers_url":"https://api.github.com/users/brian-team/followers","following_url":"https://api.github.com/users/brian-team/following{/other_user}","gists_url":"https://api.github.com/users/brian-team/gists{/gist_id}","starred_url":"https://api.github.com/users/brian-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brian-team/subscriptions","organizations_url":"https://api.github.com/users/brian-team/orgs","repos_url":"https://api.github.com/users/brian-team/repos","events_url":"https://api.github.com/users/brian-team/events{/privacy}","received_events_url":"https://api.github.com/users/brian-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brian-team/brian2","description":"Brian2 is an improved and partly rewritten version of Brian, the spiking neural network simulator (see http://briansimulator.org). It is currently in a beta state, ready for testing.","fork":false,"url":"https://api.github.com/repos/brian-team/brian2","forks_url":"https://api.github.com/repos/brian-team/brian2/forks","keys_url":"https://api.github.com/repos/brian-team/brian2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brian-team/brian2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brian-team/brian2/teams","hooks_url":"https://api.github.com/repos/brian-team/brian2/hooks","issue_events_url":"https://api.github.com/repos/brian-team/brian2/issues/events{/number}","events_url":"https://api.github.com/repos/brian-team/brian2/events","assignees_url":"https://api.github.com/repos/brian-team/brian2/assignees{/user}","branches_url":"https://api.github.com/repos/brian-team/brian2/branches{/branch}","tags_url":"https://api.github.com/repos/brian-team/brian2/tags","blobs_url":"https://api.github.com/repos/brian-team/brian2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brian-team/brian2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brian-team/brian2/git/refs{/sha}","trees_url":"https://api.github.com/repos/brian-team/brian2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brian-team/brian2/statuses/{sha}","languages_url":"https://api.github.com/repos/brian-team/brian2/languages","stargazers_url":"https://api.github.com/repos/brian-team/brian2/stargazers","contributors_url":"https://api.github.com/repos/brian-team/brian2/contributors","subscribers_url":"https://api.github.com/repos/brian-team/brian2/subscribers","subscription_url":"https://api.github.com/repos/brian-team/brian2/subscription","commits_url":"https://api.github.com/repos/brian-team/brian2/commits{/sha}","git_commits_url":"https://api.github.com/repos/brian-team/brian2/git/commits{/sha}","comments_url":"https://api.github.com/repos/brian-team/brian2/comments{/number}","issue_comment_url":"https://api.github.com/repos/brian-team/brian2/issues/comments{/number}","contents_url":"https://api.github.com/repos/brian-team/brian2/contents/{+path}","compare_url":"https://api.github.com/repos/brian-team/brian2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brian-team/brian2/merges","archive_url":"https://api.github.com/repos/brian-team/brian2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brian-team/brian2/downloads","issues_url":"https://api.github.com/repos/brian-team/brian2/issues{/number}","pulls_url":"https://api.github.com/repos/brian-team/brian2/pulls{/number}","milestones_url":"https://api.github.com/repos/brian-team/brian2/milestones{/number}","notifications_url":"https://api.github.com/repos/brian-team/brian2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brian-team/brian2/labels{/name}","releases_url":"https://api.github.com/repos/brian-team/brian2/releases{/id}","created_at":"2012-11-27T13:46:43Z","updated_at":"2015-11-05T10:46:17Z","pushed_at":"2015-11-10T11:36:50Z","git_url":"git://github.com/brian-team/brian2.git","ssh_url":"git@github.com:brian-team/brian2.git","clone_url":"https://github.com/brian-team/brian2.git","svn_url":"https://github.com/brian-team/brian2","homepage":"","size":15036,"stargazers_count":54,"watchers_count":54,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":113,"forks":20,"open_issues":113,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brian-team/brian2/pulls/592"},"html":{"href":"https://github.com/brian-team/brian2/pull/592"},"issue":{"href":"https://api.github.com/repos/brian-team/brian2/issues/592"},"comments":{"href":"https://api.github.com/repos/brian-team/brian2/issues/592/comments"},"review_comments":{"href":"https://api.github.com/repos/brian-team/brian2/pulls/592/comments"},"review_comment":{"href":"https://api.github.com/repos/brian-team/brian2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brian-team/brian2/pulls/592/commits"},"statuses":{"href":"https://api.github.com/repos/brian-team/brian2/statuses/02ed214883160523a1fb03e411a936f08909c0f1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"thesamovar","id":2903870,"avatar_url":"https://avatars.githubusercontent.com/u/2903870?v=3","gravatar_id":"","url":"https://api.github.com/users/thesamovar","html_url":"https://github.com/thesamovar","followers_url":"https://api.github.com/users/thesamovar/followers","following_url":"https://api.github.com/users/thesamovar/following{/other_user}","gists_url":"https://api.github.com/users/thesamovar/gists{/gist_id}","starred_url":"https://api.github.com/users/thesamovar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thesamovar/subscriptions","organizations_url":"https://api.github.com/users/thesamovar/orgs","repos_url":"https://api.github.com/users/thesamovar/repos","events_url":"https://api.github.com/users/thesamovar/events{/privacy}","received_events_url":"https://api.github.com/users/thesamovar/received_events","type":"User","site_admin":false},"comments":7,"review_comments":0,"commits":9,"additions":62,"deletions":82,"changed_files":9}}