{"action":"created","comment":{"url":"https://api.github.com/repos/wuub/rxv/pulls/comments/46123276","id":46123276,"diff_hunk":"@@ -62,7 +62,10 @@ def discover(timeout=1.5):\n def rxv_details(location):\n     \"\"\"Looks under given UPNP url, and checks if Yamaha amplituner lives there\n        returns RxvDetails if yes, None otherwise\"\"\"\n-    xml = ET.XML(requests.get(location).content)\n+    try:\n+        xml = ET.XML(requests.get(location).content)\n+    except:","path":"rxv/ssdp.py","position":7,"original_position":7,"commit_id":"b49efe24aad391e70f4b75bcb0d574a9f13c5551","original_commit_id":"b49efe24aad391e70f4b75bcb0d574a9f13c5551","user":{"login":"wuub","id":588857,"avatar_url":"https://avatars.githubusercontent.com/u/588857?v=3","gravatar_id":"","url":"https://api.github.com/users/wuub","html_url":"https://github.com/wuub","followers_url":"https://api.github.com/users/wuub/followers","following_url":"https://api.github.com/users/wuub/following{/other_user}","gists_url":"https://api.github.com/users/wuub/gists{/gist_id}","starred_url":"https://api.github.com/users/wuub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wuub/subscriptions","organizations_url":"https://api.github.com/users/wuub/orgs","repos_url":"https://api.github.com/users/wuub/repos","events_url":"https://api.github.com/users/wuub/events{/privacy}","received_events_url":"https://api.github.com/users/wuub/received_events","type":"User","site_admin":false},"body":"Can we catch a more specific exception here? ","created_at":"2015-11-30T09:47:57Z","updated_at":"2015-11-30T09:47:57Z","html_url":"https://github.com/wuub/rxv/pull/11#discussion_r46123276","pull_request_url":"https://api.github.com/repos/wuub/rxv/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/wuub/rxv/pulls/comments/46123276"},"html":{"href":"https://github.com/wuub/rxv/pull/11#discussion_r46123276"},"pull_request":{"href":"https://api.github.com/repos/wuub/rxv/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/wuub/rxv/pulls/11","id":52087812,"html_url":"https://github.com/wuub/rxv/pull/11","diff_url":"https://github.com/wuub/rxv/pull/11.diff","patch_url":"https://github.com/wuub/rxv/pull/11.patch","issue_url":"https://api.github.com/repos/wuub/rxv/issues/11","number":11,"state":"open","locked":false,"title":"Skip location if details could not be retrieved","user":{"login":"jtai","id":696036,"avatar_url":"https://avatars.githubusercontent.com/u/696036?v=3","gravatar_id":"","url":"https://api.github.com/users/jtai","html_url":"https://github.com/jtai","followers_url":"https://api.github.com/users/jtai/followers","following_url":"https://api.github.com/users/jtai/following{/other_user}","gists_url":"https://api.github.com/users/jtai/gists{/gist_id}","starred_url":"https://api.github.com/users/jtai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtai/subscriptions","organizations_url":"https://api.github.com/users/jtai/orgs","repos_url":"https://api.github.com/users/jtai/repos","events_url":"https://api.github.com/users/jtai/events{/privacy}","received_events_url":"https://api.github.com/users/jtai/received_events","type":"User","site_admin":false},"body":"I have a device on my network that responds to the initial discover but closes the connection when we try to grab the rxv details. \r\n\r\n@wuub ","created_at":"2015-11-30T05:55:29Z","updated_at":"2015-11-30T09:47:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd11337d66081c8ceb25d962e12cace75704877f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wuub/rxv/pulls/11/commits","review_comments_url":"https://api.github.com/repos/wuub/rxv/pulls/11/comments","review_comment_url":"https://api.github.com/repos/wuub/rxv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wuub/rxv/issues/11/comments","statuses_url":"https://api.github.com/repos/wuub/rxv/statuses/b49efe24aad391e70f4b75bcb0d574a9f13c5551","head":{"label":"jtai:ssdp-skip-errors","ref":"ssdp-skip-errors","sha":"b49efe24aad391e70f4b75bcb0d574a9f13c5551","user":{"login":"jtai","id":696036,"avatar_url":"https://avatars.githubusercontent.com/u/696036?v=3","gravatar_id":"","url":"https://api.github.com/users/jtai","html_url":"https://github.com/jtai","followers_url":"https://api.github.com/users/jtai/followers","following_url":"https://api.github.com/users/jtai/following{/other_user}","gists_url":"https://api.github.com/users/jtai/gists{/gist_id}","starred_url":"https://api.github.com/users/jtai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtai/subscriptions","organizations_url":"https://api.github.com/users/jtai/orgs","repos_url":"https://api.github.com/users/jtai/repos","events_url":"https://api.github.com/users/jtai/events{/privacy}","received_events_url":"https://api.github.com/users/jtai/received_events","type":"User","site_admin":false},"repo":{"id":47097911,"name":"rxv","full_name":"jtai/rxv","owner":{"login":"jtai","id":696036,"avatar_url":"https://avatars.githubusercontent.com/u/696036?v=3","gravatar_id":"","url":"https://api.github.com/users/jtai","html_url":"https://github.com/jtai","followers_url":"https://api.github.com/users/jtai/followers","following_url":"https://api.github.com/users/jtai/following{/other_user}","gists_url":"https://api.github.com/users/jtai/gists{/gist_id}","starred_url":"https://api.github.com/users/jtai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtai/subscriptions","organizations_url":"https://api.github.com/users/jtai/orgs","repos_url":"https://api.github.com/users/jtai/repos","events_url":"https://api.github.com/users/jtai/events{/privacy}","received_events_url":"https://api.github.com/users/jtai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jtai/rxv","description":"Automation Library for Yamaha RX-V473, RX-V573, RX-V673, RX-V773 receivers","fork":true,"url":"https://api.github.com/repos/jtai/rxv","forks_url":"https://api.github.com/repos/jtai/rxv/forks","keys_url":"https://api.github.com/repos/jtai/rxv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jtai/rxv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jtai/rxv/teams","hooks_url":"https://api.github.com/repos/jtai/rxv/hooks","issue_events_url":"https://api.github.com/repos/jtai/rxv/issues/events{/number}","events_url":"https://api.github.com/repos/jtai/rxv/events","assignees_url":"https://api.github.com/repos/jtai/rxv/assignees{/user}","branches_url":"https://api.github.com/repos/jtai/rxv/branches{/branch}","tags_url":"https://api.github.com/repos/jtai/rxv/tags","blobs_url":"https://api.github.com/repos/jtai/rxv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jtai/rxv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jtai/rxv/git/refs{/sha}","trees_url":"https://api.github.com/repos/jtai/rxv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jtai/rxv/statuses/{sha}","languages_url":"https://api.github.com/repos/jtai/rxv/languages","stargazers_url":"https://api.github.com/repos/jtai/rxv/stargazers","contributors_url":"https://api.github.com/repos/jtai/rxv/contributors","subscribers_url":"https://api.github.com/repos/jtai/rxv/subscribers","subscription_url":"https://api.github.com/repos/jtai/rxv/subscription","commits_url":"https://api.github.com/repos/jtai/rxv/commits{/sha}","git_commits_url":"https://api.github.com/repos/jtai/rxv/git/commits{/sha}","comments_url":"https://api.github.com/repos/jtai/rxv/comments{/number}","issue_comment_url":"https://api.github.com/repos/jtai/rxv/issues/comments{/number}","contents_url":"https://api.github.com/repos/jtai/rxv/contents/{+path}","compare_url":"https://api.github.com/repos/jtai/rxv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jtai/rxv/merges","archive_url":"https://api.github.com/repos/jtai/rxv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jtai/rxv/downloads","issues_url":"https://api.github.com/repos/jtai/rxv/issues{/number}","pulls_url":"https://api.github.com/repos/jtai/rxv/pulls{/number}","milestones_url":"https://api.github.com/repos/jtai/rxv/milestones{/number}","notifications_url":"https://api.github.com/repos/jtai/rxv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jtai/rxv/labels{/name}","releases_url":"https://api.github.com/repos/jtai/rxv/releases{/id}","created_at":"2015-11-30T05:48:04Z","updated_at":"2015-11-30T05:48:04Z","pushed_at":"2015-11-30T06:00:08Z","git_url":"git://github.com/jtai/rxv.git","ssh_url":"git@github.com:jtai/rxv.git","clone_url":"https://github.com/jtai/rxv.git","svn_url":"https://github.com/jtai/rxv","homepage":"","size":33,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wuub:master","ref":"master","sha":"c47e7ed0602bac91805e60ad0dc669eff811178a","user":{"login":"wuub","id":588857,"avatar_url":"https://avatars.githubusercontent.com/u/588857?v=3","gravatar_id":"","url":"https://api.github.com/users/wuub","html_url":"https://github.com/wuub","followers_url":"https://api.github.com/users/wuub/followers","following_url":"https://api.github.com/users/wuub/following{/other_user}","gists_url":"https://api.github.com/users/wuub/gists{/gist_id}","starred_url":"https://api.github.com/users/wuub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wuub/subscriptions","organizations_url":"https://api.github.com/users/wuub/orgs","repos_url":"https://api.github.com/users/wuub/repos","events_url":"https://api.github.com/users/wuub/events{/privacy}","received_events_url":"https://api.github.com/users/wuub/received_events","type":"User","site_admin":false},"repo":{"id":7470121,"name":"rxv","full_name":"wuub/rxv","owner":{"login":"wuub","id":588857,"avatar_url":"https://avatars.githubusercontent.com/u/588857?v=3","gravatar_id":"","url":"https://api.github.com/users/wuub","html_url":"https://github.com/wuub","followers_url":"https://api.github.com/users/wuub/followers","following_url":"https://api.github.com/users/wuub/following{/other_user}","gists_url":"https://api.github.com/users/wuub/gists{/gist_id}","starred_url":"https://api.github.com/users/wuub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wuub/subscriptions","organizations_url":"https://api.github.com/users/wuub/orgs","repos_url":"https://api.github.com/users/wuub/repos","events_url":"https://api.github.com/users/wuub/events{/privacy}","received_events_url":"https://api.github.com/users/wuub/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wuub/rxv","description":"Automation Library for Yamaha RX-V473, RX-V573, RX-V673, RX-V773 receivers","fork":false,"url":"https://api.github.com/repos/wuub/rxv","forks_url":"https://api.github.com/repos/wuub/rxv/forks","keys_url":"https://api.github.com/repos/wuub/rxv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wuub/rxv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wuub/rxv/teams","hooks_url":"https://api.github.com/repos/wuub/rxv/hooks","issue_events_url":"https://api.github.com/repos/wuub/rxv/issues/events{/number}","events_url":"https://api.github.com/repos/wuub/rxv/events","assignees_url":"https://api.github.com/repos/wuub/rxv/assignees{/user}","branches_url":"https://api.github.com/repos/wuub/rxv/branches{/branch}","tags_url":"https://api.github.com/repos/wuub/rxv/tags","blobs_url":"https://api.github.com/repos/wuub/rxv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wuub/rxv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wuub/rxv/git/refs{/sha}","trees_url":"https://api.github.com/repos/wuub/rxv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wuub/rxv/statuses/{sha}","languages_url":"https://api.github.com/repos/wuub/rxv/languages","stargazers_url":"https://api.github.com/repos/wuub/rxv/stargazers","contributors_url":"https://api.github.com/repos/wuub/rxv/contributors","subscribers_url":"https://api.github.com/repos/wuub/rxv/subscribers","subscription_url":"https://api.github.com/repos/wuub/rxv/subscription","commits_url":"https://api.github.com/repos/wuub/rxv/commits{/sha}","git_commits_url":"https://api.github.com/repos/wuub/rxv/git/commits{/sha}","comments_url":"https://api.github.com/repos/wuub/rxv/comments{/number}","issue_comment_url":"https://api.github.com/repos/wuub/rxv/issues/comments{/number}","contents_url":"https://api.github.com/repos/wuub/rxv/contents/{+path}","compare_url":"https://api.github.com/repos/wuub/rxv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wuub/rxv/merges","archive_url":"https://api.github.com/repos/wuub/rxv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wuub/rxv/downloads","issues_url":"https://api.github.com/repos/wuub/rxv/issues{/number}","pulls_url":"https://api.github.com/repos/wuub/rxv/pulls{/number}","milestones_url":"https://api.github.com/repos/wuub/rxv/milestones{/number}","notifications_url":"https://api.github.com/repos/wuub/rxv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wuub/rxv/labels{/name}","releases_url":"https://api.github.com/repos/wuub/rxv/releases{/id}","created_at":"2013-01-06T17:05:48Z","updated_at":"2015-11-29T22:32:08Z","pushed_at":"2015-11-30T05:57:42Z","git_url":"git://github.com/wuub/rxv.git","ssh_url":"git@github.com:wuub/rxv.git","clone_url":"https://github.com/wuub/rxv.git","svn_url":"https://github.com/wuub/rxv","homepage":"","size":265,"stargazers_count":30,"watchers_count":30,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":3,"forks":6,"open_issues":3,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wuub/rxv/pulls/11"},"html":{"href":"https://github.com/wuub/rxv/pull/11"},"issue":{"href":"https://api.github.com/repos/wuub/rxv/issues/11"},"comments":{"href":"https://api.github.com/repos/wuub/rxv/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/wuub/rxv/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/wuub/rxv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wuub/rxv/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/wuub/rxv/statuses/b49efe24aad391e70f4b75bcb0d574a9f13c5551"}}}}