{"action":"created","issue":{"url":"https://api.github.com/repos/youtube/vitess/issues/1254","labels_url":"https://api.github.com/repos/youtube/vitess/issues/1254/labels{/name}","comments_url":"https://api.github.com/repos/youtube/vitess/issues/1254/comments","events_url":"https://api.github.com/repos/youtube/vitess/issues/1254/events","html_url":"https://github.com/youtube/vitess/pull/1254","id":113123395,"number":1254,"title":"misc: Fail precommits if GOPATH is not set.","user":{"login":"michael-berlin","id":3919251,"avatar_url":"https://avatars.githubusercontent.com/u/3919251?v=3","gravatar_id":"","url":"https://api.github.com/users/michael-berlin","html_url":"https://github.com/michael-berlin","followers_url":"https://api.github.com/users/michael-berlin/followers","following_url":"https://api.github.com/users/michael-berlin/following{/other_user}","gists_url":"https://api.github.com/users/michael-berlin/gists{/gist_id}","starred_url":"https://api.github.com/users/michael-berlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michael-berlin/subscriptions","organizations_url":"https://api.github.com/users/michael-berlin/orgs","repos_url":"https://api.github.com/users/michael-berlin/repos","events_url":"https://api.github.com/users/michael-berlin/events{/privacy}","received_events_url":"https://api.github.com/users/michael-berlin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-24T00:50:09Z","updated_at":"2015-10-24T01:34:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/youtube/vitess/pulls/1254","html_url":"https://github.com/youtube/vitess/pull/1254","diff_url":"https://github.com/youtube/vitess/pull/1254.diff","patch_url":"https://github.com/youtube/vitess/pull/1254.patch"},"body":"Some precommits (go vet, golint) require a working Go environment\r\nbecause they not only look at the file under inspection itself, but they\r\nalso try to load the imported packages.\r\n\r\nUnfortunately, they don't fail if they cannot load the imports. Instead,\r\nyou see subsequent errors due to the missing imports.\r\n\r\nFor example:\r\n\r\nGo vet error: \"composite literal uses unkeyed fields\"\r\n\r\nThis occurs when we use a struct initializer\r\nwithout keyed fields where the struct is defined in another Go package.\r\nIn that case, the tools cannot find out how many/which fields the struct\r\nhas and if it's actually okay to use unkeyed fields because we specify\r\nall fields."},"comment":{"url":"https://api.github.com/repos/youtube/vitess/issues/comments/150733318","html_url":"https://github.com/youtube/vitess/pull/1254#issuecomment-150733318","issue_url":"https://api.github.com/repos/youtube/vitess/issues/1254","id":150733318,"user":{"login":"enisoc","id":6733629,"avatar_url":"https://avatars.githubusercontent.com/u/6733629?v=3","gravatar_id":"","url":"https://api.github.com/users/enisoc","html_url":"https://github.com/enisoc","followers_url":"https://api.github.com/users/enisoc/followers","following_url":"https://api.github.com/users/enisoc/following{/other_user}","gists_url":"https://api.github.com/users/enisoc/gists{/gist_id}","starred_url":"https://api.github.com/users/enisoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enisoc/subscriptions","organizations_url":"https://api.github.com/users/enisoc/orgs","repos_url":"https://api.github.com/users/enisoc/repos","events_url":"https://api.github.com/users/enisoc/events{/privacy}","received_events_url":"https://api.github.com/users/enisoc/received_events","type":"User","site_admin":false},"created_at":"2015-10-24T01:34:23Z","updated_at":"2015-10-24T01:34:23Z","body":"LGTM"}}