{"action":"opened","number":2714,"pull_request":{"url":"https://api.github.com/repos/mruby/mruby/pulls/2714","id":28003640,"html_url":"https://github.com/mruby/mruby/pull/2714","diff_url":"https://github.com/mruby/mruby/pull/2714.diff","patch_url":"https://github.com/mruby/mruby/pull/2714.patch","issue_url":"https://api.github.com/repos/mruby/mruby/issues/2714","number":2714,"state":"open","locked":false,"title":"Use setter macro instead of directly setting values","user":{"login":"xxuejie","id":340446,"avatar_url":"https://avatars.githubusercontent.com/u/340446?v=3","gravatar_id":"","url":"https://api.github.com/users/xxuejie","html_url":"https://github.com/xxuejie","followers_url":"https://api.github.com/users/xxuejie/followers","following_url":"https://api.github.com/users/xxuejie/following{/other_user}","gists_url":"https://api.github.com/users/xxuejie/gists{/gist_id}","starred_url":"https://api.github.com/users/xxuejie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xxuejie/subscriptions","organizations_url":"https://api.github.com/users/xxuejie/orgs","repos_url":"https://api.github.com/users/xxuejie/repos","events_url":"https://api.github.com/users/xxuejie/events{/privacy}","received_events_url":"https://api.github.com/users/xxuejie/received_events","type":"User","site_admin":false},"body":"Right now everything works, there's no critical needs to adopt this.\r\n\r\nHowever, I just think I might be better to use setter macro instead of directly setting the variables, since we already have the macros :)","created_at":"2015-01-26T02:56:45Z","updated_at":"2015-01-26T02:56:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mruby/mruby/pulls/2714/commits","review_comments_url":"https://api.github.com/repos/mruby/mruby/pulls/2714/comments","review_comment_url":"https://api.github.com/repos/mruby/mruby/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mruby/mruby/issues/2714/comments","statuses_url":"https://api.github.com/repos/mruby/mruby/statuses/d63e45a0147e88ab30aaa385e9d128b60b09138d","head":{"label":"xxuejie:use-setter-macro-when-necessary","ref":"use-setter-macro-when-necessary","sha":"d63e45a0147e88ab30aaa385e9d128b60b09138d","user":{"login":"xxuejie","id":340446,"avatar_url":"https://avatars.githubusercontent.com/u/340446?v=3","gravatar_id":"","url":"https://api.github.com/users/xxuejie","html_url":"https://github.com/xxuejie","followers_url":"https://api.github.com/users/xxuejie/followers","following_url":"https://api.github.com/users/xxuejie/following{/other_user}","gists_url":"https://api.github.com/users/xxuejie/gists{/gist_id}","starred_url":"https://api.github.com/users/xxuejie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xxuejie/subscriptions","organizations_url":"https://api.github.com/users/xxuejie/orgs","repos_url":"https://api.github.com/users/xxuejie/repos","events_url":"https://api.github.com/users/xxuejie/events{/privacy}","received_events_url":"https://api.github.com/users/xxuejie/received_events","type":"User","site_admin":false},"repo":{"id":7206666,"name":"mruby","full_name":"xxuejie/mruby","owner":{"login":"xxuejie","id":340446,"avatar_url":"https://avatars.githubusercontent.com/u/340446?v=3","gravatar_id":"","url":"https://api.github.com/users/xxuejie","html_url":"https://github.com/xxuejie","followers_url":"https://api.github.com/users/xxuejie/followers","following_url":"https://api.github.com/users/xxuejie/following{/other_user}","gists_url":"https://api.github.com/users/xxuejie/gists{/gist_id}","starred_url":"https://api.github.com/users/xxuejie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xxuejie/subscriptions","organizations_url":"https://api.github.com/users/xxuejie/orgs","repos_url":"https://api.github.com/users/xxuejie/repos","events_url":"https://api.github.com/users/xxuejie/events{/privacy}","received_events_url":"https://api.github.com/users/xxuejie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xxuejie/mruby","description":"Lightweight Ruby","fork":true,"url":"https://api.github.com/repos/xxuejie/mruby","forks_url":"https://api.github.com/repos/xxuejie/mruby/forks","keys_url":"https://api.github.com/repos/xxuejie/mruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xxuejie/mruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xxuejie/mruby/teams","hooks_url":"https://api.github.com/repos/xxuejie/mruby/hooks","issue_events_url":"https://api.github.com/repos/xxuejie/mruby/issues/events{/number}","events_url":"https://api.github.com/repos/xxuejie/mruby/events","assignees_url":"https://api.github.com/repos/xxuejie/mruby/assignees{/user}","branches_url":"https://api.github.com/repos/xxuejie/mruby/branches{/branch}","tags_url":"https://api.github.com/repos/xxuejie/mruby/tags","blobs_url":"https://api.github.com/repos/xxuejie/mruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xxuejie/mruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xxuejie/mruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/xxuejie/mruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xxuejie/mruby/statuses/{sha}","languages_url":"https://api.github.com/repos/xxuejie/mruby/languages","stargazers_url":"https://api.github.com/repos/xxuejie/mruby/stargazers","contributors_url":"https://api.github.com/repos/xxuejie/mruby/contributors","subscribers_url":"https://api.github.com/repos/xxuejie/mruby/subscribers","subscription_url":"https://api.github.com/repos/xxuejie/mruby/subscription","commits_url":"https://api.github.com/repos/xxuejie/mruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/xxuejie/mruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/xxuejie/mruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/xxuejie/mruby/issues/comments/{number}","contents_url":"https://api.github.com/repos/xxuejie/mruby/contents/{+path}","compare_url":"https://api.github.com/repos/xxuejie/mruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xxuejie/mruby/merges","archive_url":"https://api.github.com/repos/xxuejie/mruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xxuejie/mruby/downloads","issues_url":"https://api.github.com/repos/xxuejie/mruby/issues{/number}","pulls_url":"https://api.github.com/repos/xxuejie/mruby/pulls{/number}","milestones_url":"https://api.github.com/repos/xxuejie/mruby/milestones{/number}","notifications_url":"https://api.github.com/repos/xxuejie/mruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xxuejie/mruby/labels{/name}","releases_url":"https://api.github.com/repos/xxuejie/mruby/releases{/id}","created_at":"2012-12-17T15:05:11Z","updated_at":"2014-03-03T12:22:12Z","pushed_at":"2015-01-26T02:52:47Z","git_url":"git://github.com/xxuejie/mruby.git","ssh_url":"git@github.com:xxuejie/mruby.git","clone_url":"https://github.com/xxuejie/mruby.git","svn_url":"https://github.com/xxuejie/mruby","homepage":null,"size":5536,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mruby:master","ref":"master","sha":"23e69edd2db9a8676dd8a7dbcade48b28e0a7e34","user":{"login":"mruby","id":1796512,"avatar_url":"https://avatars.githubusercontent.com/u/1796512?v=3","gravatar_id":"","url":"https://api.github.com/users/mruby","html_url":"https://github.com/mruby","followers_url":"https://api.github.com/users/mruby/followers","following_url":"https://api.github.com/users/mruby/following{/other_user}","gists_url":"https://api.github.com/users/mruby/gists{/gist_id}","starred_url":"https://api.github.com/users/mruby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mruby/subscriptions","organizations_url":"https://api.github.com/users/mruby/orgs","repos_url":"https://api.github.com/users/mruby/repos","events_url":"https://api.github.com/users/mruby/events{/privacy}","received_events_url":"https://api.github.com/users/mruby/received_events","type":"Organization","site_admin":false},"repo":{"id":4073516,"name":"mruby","full_name":"mruby/mruby","owner":{"login":"mruby","id":1796512,"avatar_url":"https://avatars.githubusercontent.com/u/1796512?v=3","gravatar_id":"","url":"https://api.github.com/users/mruby","html_url":"https://github.com/mruby","followers_url":"https://api.github.com/users/mruby/followers","following_url":"https://api.github.com/users/mruby/following{/other_user}","gists_url":"https://api.github.com/users/mruby/gists{/gist_id}","starred_url":"https://api.github.com/users/mruby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mruby/subscriptions","organizations_url":"https://api.github.com/users/mruby/orgs","repos_url":"https://api.github.com/users/mruby/repos","events_url":"https://api.github.com/users/mruby/events{/privacy}","received_events_url":"https://api.github.com/users/mruby/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mruby/mruby","description":"Lightweight Ruby","fork":false,"url":"https://api.github.com/repos/mruby/mruby","forks_url":"https://api.github.com/repos/mruby/mruby/forks","keys_url":"https://api.github.com/repos/mruby/mruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mruby/mruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mruby/mruby/teams","hooks_url":"https://api.github.com/repos/mruby/mruby/hooks","issue_events_url":"https://api.github.com/repos/mruby/mruby/issues/events{/number}","events_url":"https://api.github.com/repos/mruby/mruby/events","assignees_url":"https://api.github.com/repos/mruby/mruby/assignees{/user}","branches_url":"https://api.github.com/repos/mruby/mruby/branches{/branch}","tags_url":"https://api.github.com/repos/mruby/mruby/tags","blobs_url":"https://api.github.com/repos/mruby/mruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mruby/mruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mruby/mruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/mruby/mruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mruby/mruby/statuses/{sha}","languages_url":"https://api.github.com/repos/mruby/mruby/languages","stargazers_url":"https://api.github.com/repos/mruby/mruby/stargazers","contributors_url":"https://api.github.com/repos/mruby/mruby/contributors","subscribers_url":"https://api.github.com/repos/mruby/mruby/subscribers","subscription_url":"https://api.github.com/repos/mruby/mruby/subscription","commits_url":"https://api.github.com/repos/mruby/mruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/mruby/mruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/mruby/mruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/mruby/mruby/issues/comments/{number}","contents_url":"https://api.github.com/repos/mruby/mruby/contents/{+path}","compare_url":"https://api.github.com/repos/mruby/mruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mruby/mruby/merges","archive_url":"https://api.github.com/repos/mruby/mruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mruby/mruby/downloads","issues_url":"https://api.github.com/repos/mruby/mruby/issues{/number}","pulls_url":"https://api.github.com/repos/mruby/mruby/pulls{/number}","milestones_url":"https://api.github.com/repos/mruby/mruby/milestones{/number}","notifications_url":"https://api.github.com/repos/mruby/mruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mruby/mruby/labels{/name}","releases_url":"https://api.github.com/repos/mruby/mruby/releases{/id}","created_at":"2012-04-19T09:11:15Z","updated_at":"2015-01-25T18:35:15Z","pushed_at":"2015-01-25T10:48:02Z","git_url":"git://github.com/mruby/mruby.git","ssh_url":"git@github.com:mruby/mruby.git","clone_url":"https://github.com/mruby/mruby.git","svn_url":"https://github.com/mruby/mruby","homepage":null,"size":19944,"stargazers_count":2940,"watchers_count":2940,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":441,"mirror_url":null,"open_issues_count":124,"forks":441,"open_issues":124,"watchers":2940,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mruby/mruby/pulls/2714"},"html":{"href":"https://github.com/mruby/mruby/pull/2714"},"issue":{"href":"https://api.github.com/repos/mruby/mruby/issues/2714"},"comments":{"href":"https://api.github.com/repos/mruby/mruby/issues/2714/comments"},"review_comments":{"href":"https://api.github.com/repos/mruby/mruby/pulls/2714/comments"},"review_comment":{"href":"https://api.github.com/repos/mruby/mruby/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mruby/mruby/pulls/2714/commits"},"statuses":{"href":"https://api.github.com/repos/mruby/mruby/statuses/d63e45a0147e88ab30aaa385e9d128b60b09138d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}