{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/42431815","id":42431815,"diff_hunk":"@@ -28,7 +28,11 @@ def setup_network(self, split=False):\n \n     def run_test(self):\n         print \"Mining blocks...\"\n-        feeTolerance = Decimal(0.00000002) #if the fee's positive delta is higher than this value tests will fail, neg. delta always fail the tests\n+\n+        min_relay_tx_fee = self.nodes[0].getnetworkinfo()['relayfee']\n+        # if the fee's positive delta is higher than this value tests will fail, neg. delta always fail the tests","path":"qa/rpc-tests/fundrawtransaction.py","position":7,"original_position":7,"commit_id":"6ce66fd255cb2b0cec8a42e400bb0015df4610e6","original_commit_id":"6ce66fd255cb2b0cec8a42e400bb0015df4610e6","user":{"login":"TheBlueMatt","id":649246,"avatar_url":"https://avatars.githubusercontent.com/u/649246?v=3","gravatar_id":"","url":"https://api.github.com/users/TheBlueMatt","html_url":"https://github.com/TheBlueMatt","followers_url":"https://api.github.com/users/TheBlueMatt/followers","following_url":"https://api.github.com/users/TheBlueMatt/following{/other_user}","gists_url":"https://api.github.com/users/TheBlueMatt/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBlueMatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBlueMatt/subscriptions","organizations_url":"https://api.github.com/users/TheBlueMatt/orgs","repos_url":"https://api.github.com/users/TheBlueMatt/repos","events_url":"https://api.github.com/users/TheBlueMatt/events{/privacy}","received_events_url":"https://api.github.com/users/TheBlueMatt/received_events","type":"User","site_admin":false},"body":"Can you update this comment to explain why this is picked (signatures may or may not take an extra byte or two, but never be smaller)","created_at":"2015-10-19T22:01:42Z","updated_at":"2015-10-19T22:01:42Z","html_url":"https://github.com/bitcoin/bitcoin/pull/6827#discussion_r42431815","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6827","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/42431815"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/6827#discussion_r42431815"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6827"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6827","id":47647138,"html_url":"https://github.com/bitcoin/bitcoin/pull/6827","diff_url":"https://github.com/bitcoin/bitcoin/pull/6827.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/6827.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6827","number":6827,"state":"open","locked":false,"title":"[rpc-tests] Check return code","user":{"login":"MarcoFalke","id":6399679,"avatar_url":"https://avatars.githubusercontent.com/u/6399679?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcoFalke","html_url":"https://github.com/MarcoFalke","followers_url":"https://api.github.com/users/MarcoFalke/followers","following_url":"https://api.github.com/users/MarcoFalke/following{/other_user}","gists_url":"https://api.github.com/users/MarcoFalke/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoFalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoFalke/subscriptions","organizations_url":"https://api.github.com/users/MarcoFalke/orgs","repos_url":"https://api.github.com/users/MarcoFalke/repos","events_url":"https://api.github.com/users/MarcoFalke/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoFalke/received_events","type":"User","site_admin":false},"body":"This fixes #6826. \r\n\r\n\r\n\r\nIf this PR indeed fixes the issue, travis **should fail** and imo the PR should be merged nonetheless.\r\n\r\n----\r\n**Update:**\r\nThe original commit was  027ca44 with the corresponding [failing travis build](https://travis-ci.org/bitcoin/bitcoin/builds/85308560). Due to requests I force pushed a rebase onto #6828.\r\n\r\n(This closes  #6828)","created_at":"2015-10-14T11:29:33Z","updated_at":"2015-10-19T22:01:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a1182e555846e47b5caa8177576b1ca7c2f084f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6827/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6827/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6827/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/6ce66fd255cb2b0cec8a42e400bb0015df4610e6","head":{"label":"MarcoFalke:MarcoFalke-2015-rpcTestsReturnCode","ref":"MarcoFalke-2015-rpcTestsReturnCode","sha":"6ce66fd255cb2b0cec8a42e400bb0015df4610e6","user":{"login":"MarcoFalke","id":6399679,"avatar_url":"https://avatars.githubusercontent.com/u/6399679?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcoFalke","html_url":"https://github.com/MarcoFalke","followers_url":"https://api.github.com/users/MarcoFalke/followers","following_url":"https://api.github.com/users/MarcoFalke/following{/other_user}","gists_url":"https://api.github.com/users/MarcoFalke/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoFalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoFalke/subscriptions","organizations_url":"https://api.github.com/users/MarcoFalke/orgs","repos_url":"https://api.github.com/users/MarcoFalke/repos","events_url":"https://api.github.com/users/MarcoFalke/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoFalke/received_events","type":"User","site_admin":false},"repo":{"id":40046254,"name":"bitcoin","full_name":"MarcoFalke/bitcoin","owner":{"login":"MarcoFalke","id":6399679,"avatar_url":"https://avatars.githubusercontent.com/u/6399679?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcoFalke","html_url":"https://github.com/MarcoFalke","followers_url":"https://api.github.com/users/MarcoFalke/followers","following_url":"https://api.github.com/users/MarcoFalke/following{/other_user}","gists_url":"https://api.github.com/users/MarcoFalke/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoFalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoFalke/subscriptions","organizations_url":"https://api.github.com/users/MarcoFalke/orgs","repos_url":"https://api.github.com/users/MarcoFalke/repos","events_url":"https://api.github.com/users/MarcoFalke/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoFalke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MarcoFalke/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/MarcoFalke/bitcoin","forks_url":"https://api.github.com/repos/MarcoFalke/bitcoin/forks","keys_url":"https://api.github.com/repos/MarcoFalke/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarcoFalke/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarcoFalke/bitcoin/teams","hooks_url":"https://api.github.com/repos/MarcoFalke/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/MarcoFalke/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/MarcoFalke/bitcoin/events","assignees_url":"https://api.github.com/repos/MarcoFalke/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/MarcoFalke/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/MarcoFalke/bitcoin/tags","blobs_url":"https://api.github.com/repos/MarcoFalke/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarcoFalke/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarcoFalke/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarcoFalke/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarcoFalke/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/MarcoFalke/bitcoin/languages","stargazers_url":"https://api.github.com/repos/MarcoFalke/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/MarcoFalke/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/MarcoFalke/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/MarcoFalke/bitcoin/subscription","commits_url":"https://api.github.com/repos/MarcoFalke/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarcoFalke/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarcoFalke/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarcoFalke/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarcoFalke/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/MarcoFalke/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarcoFalke/bitcoin/merges","archive_url":"https://api.github.com/repos/MarcoFalke/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarcoFalke/bitcoin/downloads","issues_url":"https://api.github.com/repos/MarcoFalke/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/MarcoFalke/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/MarcoFalke/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/MarcoFalke/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarcoFalke/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/MarcoFalke/bitcoin/releases{/id}","created_at":"2015-08-01T12:42:47Z","updated_at":"2015-09-13T21:36:54Z","pushed_at":"2015-10-19T12:19:32Z","git_url":"git://github.com/MarcoFalke/bitcoin.git","ssh_url":"git@github.com:MarcoFalke/bitcoin.git","clone_url":"https://github.com/MarcoFalke/bitcoin.git","svn_url":"https://github.com/MarcoFalke/bitcoin","homepage":"https://bitcoin.org/en/download","size":58517,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"d78a880900c15c7a28ae81e6632090f25fea7fce","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","created_at":"2010-12-19T15:16:43Z","updated_at":"2015-10-19T21:13:04Z","pushed_at":"2015-10-19T21:11:29Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":138163,"stargazers_count":7652,"watchers_count":7652,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5280,"mirror_url":null,"open_issues_count":466,"forks":5280,"open_issues":466,"watchers":7652,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6827"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/6827"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/6827"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/6827/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6827/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6827/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/6ce66fd255cb2b0cec8a42e400bb0015df4610e6"}}}}