{"push_id":754650801,"size":20,"distinct_size":20,"ref":"refs/heads/master","head":"8fa214bfa5cc0d46a3e34f4c09bb7635132b0b04","before":"605638243aa6d3db8784f54a4687a850646f6f54","commits":[{"sha":"2fcc02321f0f56760cfdbd67a29917e4f0ba278b","author":{"email":"7b3d0e2c9a74a06318ba26c0ad360cbb48a6df2d@biblibre.com","name":"Alex Arnaud"},"message":"Bug 13663: Fix permissions in upload-file.pl and upload-file-progress.pl\n\nTest plan:\nVerify that the circulate_remaining_permissions perm is enough to upload\n.koc file.\n\nSigned-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/2fcc02321f0f56760cfdbd67a29917e4f0ba278b"},{"sha":"fb17640c032f0ba0d6594076a71b8b37fda8b373","author":{"email":"9c63353c47a26f7c02997d843a893f11a96dbc23@gmail.com","name":"Indranil Das Gupta"},"message":"Bug 13663: (followup) fixes tab char QA test fails\n\nFixes the tab char qa test suite fails in the following files:\n\n1/ tools/upload-file-progress.pl\n2/ tools/upload-file.pl\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\nAmended patch: tidy whitespaces\nSigned-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/fb17640c032f0ba0d6594076a71b8b37fda8b373"},{"sha":"d873ed3b5d97f825c52dc53c2f72bd5a1ef03647","author":{"email":"98ad2d2c224dda85649070032fede119fea3ef02@bsz-bw.de","name":"Ulrich Kleiber"},"message":"Bug 14534: Stop overdue_notices.pl from issuing the warning: Use of uninitialized value $borrowernumber\n\nSigned-off-by: Chris Cormack <chrisc@catalyst.net.nz>\n\nTo test:\n\n1/ Run the overdue_notices.pl script (don't do this on production\nobviously :))\n2/ Notice the warns\n3/ Apply patch\n4/ Run again\n5/ Notice no warns, but notices are still generated ok\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/d873ed3b5d97f825c52dc53c2f72bd5a1ef03647"},{"sha":"2def11d678c3f15b63de3f4980cf9c59b40ff718","author":{"email":"3c13fda751d60318296deb2d23acbb9b34b79c24@biblibre.com","name":"Julian Maurice"},"message":"Bug 6874: Attach files to bibliographic records\n\nNew cataloging plugin upload.pl and new system preference 'uploadPath'.\n\nupload.pl provide a way to upload files on the server and store a link\n(url) to it in MARC\nuploadPath is the absolute path on the server where the files will be\nstored. It's possible to have a hierarchy of directories under this path\nand the plugin will allow to choose in which directory to store the\nfile.\nStored value in MARC subfield looks like this:\n<OPACBaseURL>/cgi-bin/koha/opac-retrieve-file.pl?id=<SHA-1 of the file>\nSo both 'uploadPath' and 'OPACBaseURL' sysprefs have to be set for this\nplugin to work correctly\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>\nSigned-off-by: Paul Poulain <paul.poulain@biblibre.com>\nSigned-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>\nSigned-off-by: Mark Tompsett <mtompset@hotmail.com>\n\nSigned-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\nSlightly amended/simplified the patch during QA: The changes to\nGetMarcUrls are not really needed, and would have needed some\nattention. Another link text can be supplied by the plugin too.\n\nThis also reduces the need for changes in basket.pl,\nMARCdetail.pl, detail.pl, opac-basket.pl and opac-detail.pl.\nSigned-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>\n\nEdit: more meaninfull commit subject","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/2def11d678c3f15b63de3f4980cf9c59b40ff718"},{"sha":"bfe568018637afad544f38b538ef9f6d9aad068f","author":{"email":"eedb72edbb44448b1f14f12416a76acfd5e52f95@biblibre.com","name":"Paul Poulain"},"message":"Bug 6874: QA follow-up\n\nSquash of the following commits:\n  return with explicit undef removed\n  Follow-up for PBP fixes\n  follow-up fix POD syntax\n  follow-up jquery has moved\n\nSigned-off-by: Paul Poulain <paul.poulain@biblibre.com>\nSigned-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>\nSigned-off-by: Mark Tompsett <mtompset@hotmail.com>\nSigned-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\nAmended: removed POD changes in Biblio.pm while rebasing.\nSigned-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/bfe568018637afad544f38b538ef9f6d9aad068f"},{"sha":"209faec18305eb570bda377c1db03425cd53f087","author":{"email":"3c13fda751d60318296deb2d23acbb9b34b79c24@biblibre.com","name":"Julian Maurice"},"message":"Bug 6874: Add unit tests for C4::UploadedFiles\n\nAdd unit tests for C4::UploadedFiles and move a variable\ndeclaration at subroutine level instead of file level.\nAdd dependency to Test::CGI::Multipart\n\nStill works, and the newly-provided unit tests have good test\ncoverage:\nC4/UploadedFiles.pm 90.7    65.0    66.7    100.0   100.0    0.2    86.4\n\nSigned-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>\nSigned-off-by: Mark Tompsett <mtompset@hotmail.com>\nSigned-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/209faec18305eb570bda377c1db03425cd53f087"},{"sha":"9f0546f003b7729da63ec2b8e0df05ab7ec0bff0","author":{"email":"3c13fda751d60318296deb2d23acbb9b34b79c24@biblibre.com","name":"Julian Maurice"},"message":"Bug 6874: Move uploadPath syspref to koha-conf.xml\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>\nSigned-off-by: Mark Tompsett <mtompset@hotmail.com>\nSigned-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/9f0546f003b7729da63ec2b8e0df05ab7ec0bff0"},{"sha":"094092b111b022bf6c6d27a50083e1aa826e4ca2","author":{"email":"3c25b01657254677d3e1a8fd1f0742c5d489bd39@bywatersolutions.com","name":"Kyle M Hall"},"message":"Bug 6874: (QA followup) Attach files to bibliographic records\n\n* Renames uploadPath to upload_path to follow the standard naming\n  conventions in koha-conf which use underscores rather than camel case\n* Remove reference to intranet-tmpl and replace with [% interface %]\n  required to pass qa\n\nSigned-off-by: Mark Tompsett <mtompset@hotmail.com>\nSigned-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/094092b111b022bf6c6d27a50083e1aa826e4ca2"},{"sha":"79168c011bb32439f487832231e7dac8335b669c","author":{"email":"3c13fda751d60318296deb2d23acbb9b34b79c24@biblibre.com","name":"Julian Maurice"},"message":"Bug 6874: Force user to select a directory\n\nThis patch adds a javascript and a server-side checks\n\nTest plan:\n1/ Choose a file, leave the radios not selected and submit\n2/ You have a javascript alert which prevents form to be submitted\n3/ Disable javascript and repeat step 1\n4/ Form is submitted but form is redisplayed with an error message\ntelling you to choose a directory.\n\nSigned-off-by: Mark Tompsett <mtompset@hotmail.com>\nSigned-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/79168c011bb32439f487832231e7dac8335b669c"},{"sha":"64079ccaa3284f9bf12945aad082e22c1fe4d90d","author":{"email":"7d245ca6ec1e53cd78dd694ff544fed078fda499@hotmail.com","name":"Mark Tompsett"},"message":"Bug 6874: kohastructure.sql, jquery.js, refocus, and more\n\nTwo problems were discovered while doing a fresh install\nof Koha. These problems in the kohastructure.sql file are\naddressed with this patch.\n\nClicking the plug-in icon should cause the popup window\nto refocus.  This adds the refocus code to the upload.pl file.\n\nThe path to the jquery.js script was wrong in the\nupload_delete_file.tt file. Changed [% themelang %] to\n[% interface %].\n\nIf a user clones 856$u after uploading a file, deletes the file,\nand then clicks the plugin icon on the first 856$u, this will go\nimmediately to the upload screen with an informative error\nmessage.\n\nAfter some validation was added, it was extended to include\nother cases. This serves to patch 6874 to a state where sign\noff should be possible.\n\nSigned-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/64079ccaa3284f9bf12945aad082e22c1fe4d90d"},{"sha":"98ccd548ee4affcd1516584b34c7ae45a2761155","author":{"email":"7d245ca6ec1e53cd78dd694ff544fed078fda499@hotmail.com","name":"Mark Tompsett"},"message":"Bug 6874: License Text Update\n\nThis updates the license text for\n- C4/UploadedFiles.pm\n- cataloguing/value_builder/upload.pl\n- opac/opac-retrieve-file.pl\nto GPL v3 as per the\nhttp://wiki.koha-community.org/wiki/Coding_Guidelines#Licence\ntext.\n\nTEST PLAN\n---------\n1) Don't apply this patch as part of 6874.\n2) Run the koha qa test tool.\n   -- It will FAIL for those three file.\n3) Apply this patch\n4) Run the koha qa test tool.\n   -- License problem is corrected, no FAILs.\n\nSigned-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/98ccd548ee4affcd1516584b34c7ae45a2761155"},{"sha":"a6408148bac38b8ed782e944c7ad68dc8882df2a","author":{"email":"7d245ca6ec1e53cd78dd694ff544fed078fda499@hotmail.com","name":"Mark Tompsett"},"message":"Bug 6874: Clean up file URL generation\n\nThis adds a dependency on bug 5010, in that the protocol is\nassumed in the OpacBaseURL system preference. It also adds\nimproved error handling.\n\nSigned-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/a6408148bac38b8ed782e944c7ad68dc8882df2a"},{"sha":"b36f4674a0ba2f4b6e76481dec2905494a3e2b78","author":{"email":"7d245ca6ec1e53cd78dd694ff544fed078fda499@hotmail.com","name":"Mark Tompsett"},"message":"Bug 6874: id based on contents, filename, and directory.\n\nThis patch corrects the inability to upload the same file to a\ndifferent directory, or even a renamed file to the same\ndirectory. By including the filename and directory as part of\nthe $id SHA generation, only identical files in the same\ndirectory with the same file name will generate the same $id.\n\nSigned-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/b36f4674a0ba2f4b6e76481dec2905494a3e2b78"},{"sha":"b113318bb203d71845f6127f63b88247639537d7","author":{"email":"7d245ca6ec1e53cd78dd694ff544fed078fda499@hotmail.com","name":"Mark Tompsett"},"message":"Bug 6874: Catch warnings for clean tests.\n\nI hate noisy tests, so I cleaned them up.\n\nMEGA TEST PLAN\n--------------\ngit checkout -b bug_6874 origin/master\ngit bz apply 6874\n-- yes, it should all apply smoothly.\nI intentionally restored an old backup from a couple months ago to force the upgrade.\nstaff client:\n-- upgrade\n-- login\nKoha administration\nMARC Bibliographic framework\nMARC structure (for BKS)\nSearch for 856\nSubfields\nEdit (for u)\nOther options\nPlugin: upload.pl\nSave changes\nSearch the catalog tab\n{choose a word, any word. I used fancy, because I knew we had a cookbook}\nclick first link\nEdit\nEdit record\n8 (that's the tab name)\nclick the name for 856\nscroll down to u and click the plugin icon\n-- Correctly got a configuration error message.\n\nAt a command prompt:\nvi ~/koha-dev/etc/koha-conf.xml\n/enable_plug\n-- add in:\n<upload_path>{appropriate path. I used /home/mtompset/uploads}</upload_path>\n:wq\nmkdir {appropriate path used}\n-- I even added some subdirectories\nsudo chown -R -v www-data.www-data {appropriate path used}\n\nBack in staff client:\nclick the plugin icon again\n-- this time an upload screen pops up\nclick the 'Upload file' button\n-- message about no file or destination\nbrowse for a file, select one\nclick the 'Upload file' button\n-- message about no destination\nclick the 'Cancel' button\nclick the plugin icon\nclick a destination radio button\nclick the 'Upload file' button\n-- message about no file\nbrowse for a file, select one\nclick the 'Upload file' button\n-- message about success\nclick the 'close' button.\n-- the text box has been filled in with a nice URL\nclick the plugin icon\nclick cancel\nclick the plugin icon\nclick delete\n-- the test box should be blanked, and a success message given\nclick Close\n-- reupload a file properly\nclick the plugin icon\nclick delete\nclick upload file\nbrowse for a file, select a destination, click upload file\nclick close on success message\nclick 'Clone this subfield'\nclick the second plugin icon\nclick delete\nclick close\nclick the first plugin icon\n-- Nice error message about a URL which points to nothing.\nclick cancel\nIn the second 856$u type in a URL (eg. www.google.com)\nclick the second plugin icon\n-- this jumps immediately to the upload screen, but does not give an error message, because the URL does not have opac-retrieve-file in it.\nclick save (we need to save the bibliographic record)\n\nIn OPAC:\nsearch for the same word (I used fancy)\nfind the entry you just updated with links\nclick the two links. The dangling entry should give you a 500 error, and the other link should work just fine.\nget back to the detail page\n\nIn staff client:\nedit\nedit record\n8\nchange the 856$u to a valid file in the first link.\nsave\n\nIn OPAC:\nrefresh the detail page, and click the first link again\nthis time it should get downloaded nicely.\n\nFrom a command line:\nprove -v t/db_dependent/UploadedFiles.t\nperldoc C4::Biblio\nperldoc C4::UploadedFiles\n\nOne more round of tests tomorrow, and this should be ready. :)\n\nSigned-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>\n\nTested on top of 5010\n\nFollowed mostly mega test plan, seems to work :)\nCan upload, delete, modify, etc\nTest runs Ok\nNo koha-qa errors\n\nI view this as valuable addition, dangling since 2011!\nAs with 5010, I consider this can be pushed (for 3.22)\nand we can fix anything wrong later.\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/b113318bb203d71845f6127f63b88247639537d7"},{"sha":"d7cdb6e15eb5488554e030a98f028d9e874f9b8b","author":{"email":"a4ed5d8b9e88a5c4401757374b1604745a5e46b6@rijksmuseum.nl","name":"Marcel de Rooy"},"message":"Bug 6874: [QA Follow-up] Adjustments for opac-retrieve\n\nAdds httpheaders sub to UploadedFiles; this will be extended on a new\nreport. (Idea is to add configurable headers for file extensions.)\nTrivial unit test added.\nSmall cosmetic changes to opac-retrieve-file.\n\nTest plan:\nRun test UploadedFiles.t\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/d7cdb6e15eb5488554e030a98f028d9e874f9b8b"},{"sha":"7f797b3244c4252fedcdd046d3c659843347a197","author":{"email":"a4ed5d8b9e88a5c4401757374b1604745a5e46b6@rijksmuseum.nl","name":"Marcel de Rooy"},"message":"Bug 6874: [QA Follow-up] Last adjustments for future developments\n\nThis patch does:\n\n[1] Some trivial template changes. Modified some comments (POD lines).\n[2] Converted plugin to new style.\n[3] Table updates: renames id to hashvalue, adds a autoincrement id,\n    adds filesize, timestamp, owner and category.\n    RM: This db rev is in a separate sql file in atomicupdate.\n[4] Code references to computed hash renamed to hashvalue instead of id.\n[5] Removed some code pertaining to exposing upload dir structure. The user\n    now may choose a category; the uploader takes care of storage.\n    The list of upload categories is now taken from authorised values; this\n    might become a separate table in the future. (If there are none,\n    the upload process creates one default fallback.)\n    We can add e.g. permissions later, subdir structure, etc. (So dir will\n    not necessarily be category anymore.)\n\nTest plan:\n[1] Run the db revision.\n[2] Upload new file. Check the record in the table. Delete it again; check.\n[3] Run t/db../UploadedFiles.t.\n[4] Run t/db../FrameworkPlugins.t -incl cataloguing/value_builder/upload.pl\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/7f797b3244c4252fedcdd046d3c659843347a197"},{"sha":"cef2dd180f9770e3b2f8d28c8357fab8851bf1c2","author":{"email":"63ac9f6777fb741d62c33cd73a438a8ce82c7d4a@theke.io","name":"Tomas Cohen Arazi"},"message":"Bug 6874: (QA followup) Warnings in about page\n\nThis patch introduces checks on the about.pl page so the user is warned\nfor a deficient configuration.\n\nSigned-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/cef2dd180f9770e3b2f8d28c8357fab8851bf1c2"},{"sha":"7fe69d8e5d09cadbdd26ffd563852ecb497c544a","author":{"email":"63ac9f6777fb741d62c33cd73a438a8ce82c7d4a@unc.edu.ar","name":"Tomas Cohen Arazi"},"message":"Bug 6874: (QA followup) upload_path missing in koha-conf.xml.in\n\nSigned-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/7fe69d8e5d09cadbdd26ffd563852ecb497c544a"},{"sha":"03ae8f70c23c0ba5e07e6aa6fdb3c65dafec946e","author":{"email":"63ac9f6777fb741d62c33cd73a438a8ce82c7d4a@theke.io","name":"Tomas Cohen Arazi"},"message":"Bug 6874: (RM followup) DBIx updates\n\nSigned-off-by: Tomas Cohen Arazi <tomascohen@theke.io>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/03ae8f70c23c0ba5e07e6aa6fdb3c65dafec946e"},{"sha":"8fa214bfa5cc0d46a3e34f4c09bb7635132b0b04","author":{"email":"63ac9f6777fb741d62c33cd73a438a8ce82c7d4a@theke.io","name":"Tomás Cohen Arazi"},"message":"Bug 6874: DBRev 3.21.00.017\n\nSigned-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/8fa214bfa5cc0d46a3e34f4c09bb7635132b0b04"}]}