{"action":"created","comment":{"url":"https://api.github.com/repos/Financial-Times/n-third-party-code/pulls/comments/46697832","id":46697832,"diff_hunk":"@@ -1 +1,37 @@\n This is the 'tag manager' for Next. It's to be used to house all third party scripts.\n+\n+## Background\n+\n+ft.com has an elgalitarian means of adding JavaScript to the web page.\n+\n+This causes problems for web page performance, technical support, and managing overall coherance of the product.\n+\n+This project is a stab at centralising our third-party code to give everyone more oversight about what's being added to ft.com.\n+\n+## Ground rules\n+\n+Anyone (in the world) can make a PR to this project.\n+\n+Successful requests will be reviewed and merged in to the FT code base.\n+\n+### Management\n+\n+- Each script MUST have an expiring [feature flag](https://github.com/Financial-Times/next-flags-api) to allow it to be toggled on and off.\n+- You MUST scope the loading of the tag to collect the minimally useful data set. _Eg, scope the script to a geographic region, individual URL, group of users, or use sampling techniques._\n+- You MUST document what the tag does and its impact on performance, network etc. in the pull request.","path":"README.md","position":21,"original_position":21,"commit_id":"c6e433456846644a36f3ab1832ce00bd886455be","original_commit_id":"c6e433456846644a36f3ab1832ce00bd886455be","user":{"login":"wheresrhys","id":447559,"avatar_url":"https://avatars.githubusercontent.com/u/447559?v=3","gravatar_id":"","url":"https://api.github.com/users/wheresrhys","html_url":"https://github.com/wheresrhys","followers_url":"https://api.github.com/users/wheresrhys/followers","following_url":"https://api.github.com/users/wheresrhys/following{/other_user}","gists_url":"https://api.github.com/users/wheresrhys/gists{/gist_id}","starred_url":"https://api.github.com/users/wheresrhys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wheresrhys/subscriptions","organizations_url":"https://api.github.com/users/wheresrhys/orgs","repos_url":"https://api.github.com/users/wheresrhys/repos","events_url":"https://api.github.com/users/wheresrhys/events{/privacy}","received_events_url":"https://api.github.com/users/wheresrhys/received_events","type":"User","site_admin":false},"body":"And in a comment in the code?","created_at":"2015-12-04T16:08:10Z","updated_at":"2015-12-04T16:08:10Z","html_url":"https://github.com/Financial-Times/n-third-party-code/pull/28#discussion_r46697832","pull_request_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/n-third-party-code/pulls/comments/46697832"},"html":{"href":"https://github.com/Financial-Times/n-third-party-code/pull/28#discussion_r46697832"},"pull_request":{"href":"https://api.github.com/repos/Financial-Times/n-third-party-code/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/Financial-Times/n-third-party-code/pulls/28","id":52554861,"html_url":"https://github.com/Financial-Times/n-third-party-code/pull/28","diff_url":"https://github.com/Financial-Times/n-third-party-code/pull/28.diff","patch_url":"https://github.com/Financial-Times/n-third-party-code/pull/28.patch","issue_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/issues/28","number":28,"state":"open","locked":false,"title":"Ground rules","user":{"login":"commuterjoy","id":84996,"avatar_url":"https://avatars.githubusercontent.com/u/84996?v=3","gravatar_id":"","url":"https://api.github.com/users/commuterjoy","html_url":"https://github.com/commuterjoy","followers_url":"https://api.github.com/users/commuterjoy/followers","following_url":"https://api.github.com/users/commuterjoy/following{/other_user}","gists_url":"https://api.github.com/users/commuterjoy/gists{/gist_id}","starred_url":"https://api.github.com/users/commuterjoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commuterjoy/subscriptions","organizations_url":"https://api.github.com/users/commuterjoy/orgs","repos_url":"https://api.github.com/users/commuterjoy/repos","events_url":"https://api.github.com/users/commuterjoy/events{/privacy}","received_events_url":"https://api.github.com/users/commuterjoy/received_events","type":"User","site_admin":false},"body":"/cc @richard-still-ft @phamann @matthew-andrews @wheresrhys @tom-parker ","created_at":"2015-12-03T16:11:28Z","updated_at":"2015-12-04T16:08:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f75fb7832269cd237af4a4eecd4b3d6dd46fb252","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/pulls/28/commits","review_comments_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/pulls/28/comments","review_comment_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/issues/28/comments","statuses_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/statuses/c6e433456846644a36f3ab1832ce00bd886455be","head":{"label":"Financial-Times:ground-rules","ref":"ground-rules","sha":"c6e433456846644a36f3ab1832ce00bd886455be","user":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":39908348,"name":"n-third-party-code","full_name":"Financial-Times/n-third-party-code","owner":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Financial-Times/n-third-party-code","description":"Load and manage third-party code across next.ft.com","fork":false,"url":"https://api.github.com/repos/Financial-Times/n-third-party-code","forks_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/forks","keys_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/teams","hooks_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/events","assignees_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/tags","blobs_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/subscription","commits_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/merges","archive_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/downloads","issues_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/releases{/id}","created_at":"2015-07-29T18:02:29Z","updated_at":"2015-09-22T10:41:21Z","pushed_at":"2015-12-04T11:34:46Z","git_url":"git://github.com/Financial-Times/n-third-party-code.git","ssh_url":"git@github.com:Financial-Times/n-third-party-code.git","clone_url":"https://github.com/Financial-Times/n-third-party-code.git","svn_url":"https://github.com/Financial-Times/n-third-party-code","homepage":"https://next.ft.com","size":64,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":13,"forks":0,"open_issues":13,"watchers":0,"default_branch":"master"}},"base":{"label":"Financial-Times:master","ref":"master","sha":"6c51a984d79a09863b4d20d60d1032545d74b899","user":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":39908348,"name":"n-third-party-code","full_name":"Financial-Times/n-third-party-code","owner":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Financial-Times/n-third-party-code","description":"Load and manage third-party code across next.ft.com","fork":false,"url":"https://api.github.com/repos/Financial-Times/n-third-party-code","forks_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/forks","keys_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/teams","hooks_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/events","assignees_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/tags","blobs_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/subscription","commits_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/merges","archive_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/downloads","issues_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/n-third-party-code/releases{/id}","created_at":"2015-07-29T18:02:29Z","updated_at":"2015-09-22T10:41:21Z","pushed_at":"2015-12-04T11:34:46Z","git_url":"git://github.com/Financial-Times/n-third-party-code.git","ssh_url":"git@github.com:Financial-Times/n-third-party-code.git","clone_url":"https://github.com/Financial-Times/n-third-party-code.git","svn_url":"https://github.com/Financial-Times/n-third-party-code","homepage":"https://next.ft.com","size":64,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":13,"forks":0,"open_issues":13,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/n-third-party-code/pulls/28"},"html":{"href":"https://github.com/Financial-Times/n-third-party-code/pull/28"},"issue":{"href":"https://api.github.com/repos/Financial-Times/n-third-party-code/issues/28"},"comments":{"href":"https://api.github.com/repos/Financial-Times/n-third-party-code/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/Financial-Times/n-third-party-code/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/Financial-Times/n-third-party-code/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Financial-Times/n-third-party-code/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/Financial-Times/n-third-party-code/statuses/c6e433456846644a36f3ab1832ce00bd886455be"}}}}