{"action":"created","issue":{"url":"https://api.github.com/repos/kenwheeler/slick/issues/83","labels_url":"https://api.github.com/repos/kenwheeler/slick/issues/83/labels{/name}","comments_url":"https://api.github.com/repos/kenwheeler/slick/issues/83/comments","events_url":"https://api.github.com/repos/kenwheeler/slick/issues/83/events","html_url":"https://github.com/kenwheeler/slick/issues/83","id":30842873,"number":83,"title":"auto height property?","user":{"login":"flomic","id":3209858,"avatar_url":"https://avatars.githubusercontent.com/u/3209858?v=3","gravatar_id":"","url":"https://api.github.com/users/flomic","html_url":"https://github.com/flomic","followers_url":"https://api.github.com/users/flomic/followers","following_url":"https://api.github.com/users/flomic/following{/other_user}","gists_url":"https://api.github.com/users/flomic/gists{/gist_id}","starred_url":"https://api.github.com/users/flomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flomic/subscriptions","organizations_url":"https://api.github.com/users/flomic/orgs","repos_url":"https://api.github.com/users/flomic/repos","events_url":"https://api.github.com/users/flomic/events{/privacy}","received_events_url":"https://api.github.com/users/flomic/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kenwheeler/slick/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2014-04-04T08:41:14Z","updated_at":"2015-12-08T23:40:53Z","closed_at":"2014-04-10T01:58:21Z","body":"Is there already a possibility to set a auto height property? Currently the carousel has the height of the tallest element."},"comment":{"url":"https://api.github.com/repos/kenwheeler/slick/issues/comments/163057972","html_url":"https://github.com/kenwheeler/slick/issues/83#issuecomment-163057972","issue_url":"https://api.github.com/repos/kenwheeler/slick/issues/83","id":163057972,"user":{"login":"andreyvolokitin","id":466394,"avatar_url":"https://avatars.githubusercontent.com/u/466394?v=3","gravatar_id":"","url":"https://api.github.com/users/andreyvolokitin","html_url":"https://github.com/andreyvolokitin","followers_url":"https://api.github.com/users/andreyvolokitin/followers","following_url":"https://api.github.com/users/andreyvolokitin/following{/other_user}","gists_url":"https://api.github.com/users/andreyvolokitin/gists{/gist_id}","starred_url":"https://api.github.com/users/andreyvolokitin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreyvolokitin/subscriptions","organizations_url":"https://api.github.com/users/andreyvolokitin/orgs","repos_url":"https://api.github.com/users/andreyvolokitin/repos","events_url":"https://api.github.com/users/andreyvolokitin/events{/privacy}","received_events_url":"https://api.github.com/users/andreyvolokitin/received_events","type":"User","site_admin":false},"created_at":"2015-12-08T23:40:53Z","updated_at":"2015-12-08T23:40:53Z","body":"> It fucks with responsive. If you set a height on it, it stutters the scaling because you need to reset the height as the window scales.\r\n> - kenwheeler\r\n\r\nAs I see it - individual items inside container may stay perfectly responsive without set height, it is only container that adapt its height to the tallest visible item. So I can not see how it can impact responsiveness.\r\n\r\n> It is SHITTY ass UX. If the slider height jumps 200px, the user is chasing the controls around.\r\n> - kenwheeler\r\n\r\nThis is not necessary the case. Controls can be styled as needed - i.e. they can use positioning in pixels instead of vertical centering, so they will just stay in place when height is changed.\r\n\t\r\n> It is bad for performance. You are pushing elements down the page, causing not only repaint, but reflow, on a massive scale.\r\n> - kenwheeler\r\n\r\nEverything could be bad for performance when misused. Autoheight can be used in strict narrow scenarios when it will not impact significantly anything performance-wise. If we set it on every 100 of carousels on the page while each of them is autoplaying then definitely yes this is bad. But if we put autoheight on the single element (where it could actually be needed, despite of all critisism - there are valid usecases for autoheight), then I do not see anything really bad.\r\n\r\n\r\nWhat I am trying to say - if autoheight will be implemented it does not mean that it should and would be used everywhere, but it could actually be very handy and quite appropriate in very specific cases."}}