{"action":"opened","number":1404,"pull_request":{"url":"https://api.github.com/repos/phoenixframework/phoenix/pulls/1404","id":53496474,"html_url":"https://github.com/phoenixframework/phoenix/pull/1404","diff_url":"https://github.com/phoenixframework/phoenix/pull/1404.diff","patch_url":"https://github.com/phoenixframework/phoenix/pull/1404.patch","issue_url":"https://api.github.com/repos/phoenixframework/phoenix/issues/1404","number":1404,"state":"open","locked":false,"title":"Properly handle ephemeral ports in endpoint config","user":{"login":"Kavec","id":640427,"avatar_url":"https://avatars.githubusercontent.com/u/640427?v=3","gravatar_id":"","url":"https://api.github.com/users/Kavec","html_url":"https://github.com/Kavec","followers_url":"https://api.github.com/users/Kavec/followers","following_url":"https://api.github.com/users/Kavec/following{/other_user}","gists_url":"https://api.github.com/users/Kavec/gists{/gist_id}","starred_url":"https://api.github.com/users/Kavec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kavec/subscriptions","organizations_url":"https://api.github.com/users/Kavec/orgs","repos_url":"https://api.github.com/users/Kavec/repos","events_url":"https://api.github.com/users/Kavec/events{/privacy}","received_events_url":"https://api.github.com/users/Kavec/received_events","type":"User","site_admin":false},"body":"Wound up implementing a fix for #1314. Since @chrismccord wanted it exposed at the plug level, I'll be sending a pull request over that way momentarily. In order to keep the change low-impact, though, I also implemented the direct call to Ranch if the new functionality I'm sending to Plug is unavailable.\r\n\r\nOverall, this is a deeper change than the cosmetic logging I originally was complaining about, so please let me know if/where further changes are needed and I'll be glad to make them. In particular, I'm unsure if modifying the integration tests like I have is the best policy-- finding where the tests should actually go was the most difficult part here-- and there may be some knock-on wartiness from coaxing the Endpoint.url call to return the active listening port.\r\n\r\nThanks a ton to @dm1try for doing the initial legwork and pointing us in the right direction!","created_at":"2015-12-13T09:46:56Z","updated_at":"2015-12-13T09:46:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b750256e8dbe877be1489ce9ef21cab417fbc189","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/phoenixframework/phoenix/pulls/1404/commits","review_comments_url":"https://api.github.com/repos/phoenixframework/phoenix/pulls/1404/comments","review_comment_url":"https://api.github.com/repos/phoenixframework/phoenix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phoenixframework/phoenix/issues/1404/comments","statuses_url":"https://api.github.com/repos/phoenixframework/phoenix/statuses/f53d875ca3f89dae94c0e6555aca8a74c1ef1176","head":{"label":"Kavec:1314-ephemeral-ports","ref":"1314-ephemeral-ports","sha":"f53d875ca3f89dae94c0e6555aca8a74c1ef1176","user":{"login":"Kavec","id":640427,"avatar_url":"https://avatars.githubusercontent.com/u/640427?v=3","gravatar_id":"","url":"https://api.github.com/users/Kavec","html_url":"https://github.com/Kavec","followers_url":"https://api.github.com/users/Kavec/followers","following_url":"https://api.github.com/users/Kavec/following{/other_user}","gists_url":"https://api.github.com/users/Kavec/gists{/gist_id}","starred_url":"https://api.github.com/users/Kavec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kavec/subscriptions","organizations_url":"https://api.github.com/users/Kavec/orgs","repos_url":"https://api.github.com/users/Kavec/repos","events_url":"https://api.github.com/users/Kavec/events{/privacy}","received_events_url":"https://api.github.com/users/Kavec/received_events","type":"User","site_admin":false},"repo":{"id":47904752,"name":"phoenix","full_name":"Kavec/phoenix","owner":{"login":"Kavec","id":640427,"avatar_url":"https://avatars.githubusercontent.com/u/640427?v=3","gravatar_id":"","url":"https://api.github.com/users/Kavec","html_url":"https://github.com/Kavec","followers_url":"https://api.github.com/users/Kavec/followers","following_url":"https://api.github.com/users/Kavec/following{/other_user}","gists_url":"https://api.github.com/users/Kavec/gists{/gist_id}","starred_url":"https://api.github.com/users/Kavec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kavec/subscriptions","organizations_url":"https://api.github.com/users/Kavec/orgs","repos_url":"https://api.github.com/users/Kavec/repos","events_url":"https://api.github.com/users/Kavec/events{/privacy}","received_events_url":"https://api.github.com/users/Kavec/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Kavec/phoenix","description":"Productive. Reliable. Fast.","fork":true,"url":"https://api.github.com/repos/Kavec/phoenix","forks_url":"https://api.github.com/repos/Kavec/phoenix/forks","keys_url":"https://api.github.com/repos/Kavec/phoenix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kavec/phoenix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kavec/phoenix/teams","hooks_url":"https://api.github.com/repos/Kavec/phoenix/hooks","issue_events_url":"https://api.github.com/repos/Kavec/phoenix/issues/events{/number}","events_url":"https://api.github.com/repos/Kavec/phoenix/events","assignees_url":"https://api.github.com/repos/Kavec/phoenix/assignees{/user}","branches_url":"https://api.github.com/repos/Kavec/phoenix/branches{/branch}","tags_url":"https://api.github.com/repos/Kavec/phoenix/tags","blobs_url":"https://api.github.com/repos/Kavec/phoenix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kavec/phoenix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kavec/phoenix/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kavec/phoenix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kavec/phoenix/statuses/{sha}","languages_url":"https://api.github.com/repos/Kavec/phoenix/languages","stargazers_url":"https://api.github.com/repos/Kavec/phoenix/stargazers","contributors_url":"https://api.github.com/repos/Kavec/phoenix/contributors","subscribers_url":"https://api.github.com/repos/Kavec/phoenix/subscribers","subscription_url":"https://api.github.com/repos/Kavec/phoenix/subscription","commits_url":"https://api.github.com/repos/Kavec/phoenix/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kavec/phoenix/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kavec/phoenix/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kavec/phoenix/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kavec/phoenix/contents/{+path}","compare_url":"https://api.github.com/repos/Kavec/phoenix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kavec/phoenix/merges","archive_url":"https://api.github.com/repos/Kavec/phoenix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kavec/phoenix/downloads","issues_url":"https://api.github.com/repos/Kavec/phoenix/issues{/number}","pulls_url":"https://api.github.com/repos/Kavec/phoenix/pulls{/number}","milestones_url":"https://api.github.com/repos/Kavec/phoenix/milestones{/number}","notifications_url":"https://api.github.com/repos/Kavec/phoenix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kavec/phoenix/labels{/name}","releases_url":"https://api.github.com/repos/Kavec/phoenix/releases{/id}","created_at":"2015-12-13T03:41:31Z","updated_at":"2015-12-13T03:41:32Z","pushed_at":"2015-12-13T09:34:02Z","git_url":"git://github.com/Kavec/phoenix.git","ssh_url":"git@github.com:Kavec/phoenix.git","clone_url":"https://github.com/Kavec/phoenix.git","svn_url":"https://github.com/Kavec/phoenix","homepage":"http://www.phoenixframework.org","size":4145,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"phoenixframework:master","ref":"master","sha":"0703c008b259d246d47669e6df3a52b4869187c7","user":{"login":"phoenixframework","id":6510388,"avatar_url":"https://avatars.githubusercontent.com/u/6510388?v=3","gravatar_id":"","url":"https://api.github.com/users/phoenixframework","html_url":"https://github.com/phoenixframework","followers_url":"https://api.github.com/users/phoenixframework/followers","following_url":"https://api.github.com/users/phoenixframework/following{/other_user}","gists_url":"https://api.github.com/users/phoenixframework/gists{/gist_id}","starred_url":"https://api.github.com/users/phoenixframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phoenixframework/subscriptions","organizations_url":"https://api.github.com/users/phoenixframework/orgs","repos_url":"https://api.github.com/users/phoenixframework/repos","events_url":"https://api.github.com/users/phoenixframework/events{/privacy}","received_events_url":"https://api.github.com/users/phoenixframework/received_events","type":"Organization","site_admin":false},"repo":{"id":16072585,"name":"phoenix","full_name":"phoenixframework/phoenix","owner":{"login":"phoenixframework","id":6510388,"avatar_url":"https://avatars.githubusercontent.com/u/6510388?v=3","gravatar_id":"","url":"https://api.github.com/users/phoenixframework","html_url":"https://github.com/phoenixframework","followers_url":"https://api.github.com/users/phoenixframework/followers","following_url":"https://api.github.com/users/phoenixframework/following{/other_user}","gists_url":"https://api.github.com/users/phoenixframework/gists{/gist_id}","starred_url":"https://api.github.com/users/phoenixframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phoenixframework/subscriptions","organizations_url":"https://api.github.com/users/phoenixframework/orgs","repos_url":"https://api.github.com/users/phoenixframework/repos","events_url":"https://api.github.com/users/phoenixframework/events{/privacy}","received_events_url":"https://api.github.com/users/phoenixframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phoenixframework/phoenix","description":"Productive. Reliable. Fast.","fork":false,"url":"https://api.github.com/repos/phoenixframework/phoenix","forks_url":"https://api.github.com/repos/phoenixframework/phoenix/forks","keys_url":"https://api.github.com/repos/phoenixframework/phoenix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phoenixframework/phoenix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phoenixframework/phoenix/teams","hooks_url":"https://api.github.com/repos/phoenixframework/phoenix/hooks","issue_events_url":"https://api.github.com/repos/phoenixframework/phoenix/issues/events{/number}","events_url":"https://api.github.com/repos/phoenixframework/phoenix/events","assignees_url":"https://api.github.com/repos/phoenixframework/phoenix/assignees{/user}","branches_url":"https://api.github.com/repos/phoenixframework/phoenix/branches{/branch}","tags_url":"https://api.github.com/repos/phoenixframework/phoenix/tags","blobs_url":"https://api.github.com/repos/phoenixframework/phoenix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phoenixframework/phoenix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phoenixframework/phoenix/git/refs{/sha}","trees_url":"https://api.github.com/repos/phoenixframework/phoenix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phoenixframework/phoenix/statuses/{sha}","languages_url":"https://api.github.com/repos/phoenixframework/phoenix/languages","stargazers_url":"https://api.github.com/repos/phoenixframework/phoenix/stargazers","contributors_url":"https://api.github.com/repos/phoenixframework/phoenix/contributors","subscribers_url":"https://api.github.com/repos/phoenixframework/phoenix/subscribers","subscription_url":"https://api.github.com/repos/phoenixframework/phoenix/subscription","commits_url":"https://api.github.com/repos/phoenixframework/phoenix/commits{/sha}","git_commits_url":"https://api.github.com/repos/phoenixframework/phoenix/git/commits{/sha}","comments_url":"https://api.github.com/repos/phoenixframework/phoenix/comments{/number}","issue_comment_url":"https://api.github.com/repos/phoenixframework/phoenix/issues/comments{/number}","contents_url":"https://api.github.com/repos/phoenixframework/phoenix/contents/{+path}","compare_url":"https://api.github.com/repos/phoenixframework/phoenix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phoenixframework/phoenix/merges","archive_url":"https://api.github.com/repos/phoenixframework/phoenix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phoenixframework/phoenix/downloads","issues_url":"https://api.github.com/repos/phoenixframework/phoenix/issues{/number}","pulls_url":"https://api.github.com/repos/phoenixframework/phoenix/pulls{/number}","milestones_url":"https://api.github.com/repos/phoenixframework/phoenix/milestones{/number}","notifications_url":"https://api.github.com/repos/phoenixframework/phoenix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phoenixframework/phoenix/labels{/name}","releases_url":"https://api.github.com/repos/phoenixframework/phoenix/releases{/id}","created_at":"2014-01-20T14:14:11Z","updated_at":"2015-12-13T08:24:38Z","pushed_at":"2015-12-13T09:46:57Z","git_url":"git://github.com/phoenixframework/phoenix.git","ssh_url":"git@github.com:phoenixframework/phoenix.git","clone_url":"https://github.com/phoenixframework/phoenix.git","svn_url":"https://github.com/phoenixframework/phoenix","homepage":"http://www.phoenixframework.org","size":4636,"stargazers_count":4795,"watchers_count":4795,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":526,"mirror_url":null,"open_issues_count":7,"forks":526,"open_issues":7,"watchers":4795,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phoenixframework/phoenix/pulls/1404"},"html":{"href":"https://github.com/phoenixframework/phoenix/pull/1404"},"issue":{"href":"https://api.github.com/repos/phoenixframework/phoenix/issues/1404"},"comments":{"href":"https://api.github.com/repos/phoenixframework/phoenix/issues/1404/comments"},"review_comments":{"href":"https://api.github.com/repos/phoenixframework/phoenix/pulls/1404/comments"},"review_comment":{"href":"https://api.github.com/repos/phoenixframework/phoenix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phoenixframework/phoenix/pulls/1404/commits"},"statuses":{"href":"https://api.github.com/repos/phoenixframework/phoenix/statuses/f53d875ca3f89dae94c0e6555aca8a74c1ef1176"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":49,"deletions":23,"changed_files":3}}