{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/7904","labels_url":"https://api.github.com/repos/apache/spark/issues/7904/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/7904/comments","events_url":"https://api.github.com/repos/apache/spark/issues/7904/events","html_url":"https://github.com/apache/spark/pull/7904","id":98839362,"number":7904,"title":"[SPARK-7165] [WIP] [SQL] Use sort merge join for outer join ","user":{"login":"JoshRosen","id":50748,"avatar_url":"https://avatars.githubusercontent.com/u/50748?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshRosen","html_url":"https://github.com/JoshRosen","followers_url":"https://api.github.com/users/JoshRosen/followers","following_url":"https://api.github.com/users/JoshRosen/following{/other_user}","gists_url":"https://api.github.com/users/JoshRosen/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshRosen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshRosen/subscriptions","organizations_url":"https://api.github.com/users/JoshRosen/orgs","repos_url":"https://api.github.com/users/JoshRosen/repos","events_url":"https://api.github.com/users/JoshRosen/events{/privacy}","received_events_url":"https://api.github.com/users/JoshRosen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":18,"created_at":"2015-08-03T21:11:20Z","updated_at":"2015-08-05T00:18:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/7904","html_url":"https://github.com/apache/spark/pull/7904","diff_url":"https://github.com/apache/spark/pull/7904.diff","patch_url":"https://github.com/apache/spark/pull/7904.patch"},"body":"**Description is WIP**\r\n\r\nThis patch adds a new `SortMergeOuterJoin` operator that performs outer joins (left, right, and full) using sort merge join.\r\n\r\nKey changes:\r\n\r\n- Rename `HashOuterJoin` to `OuterJoin`, since it's now extended by `ShuffledHashOuterJoin`.\r\n\r\nAlong the way, I also performed a couple pieces of minor cleanup in code that I was modifying anyways:\r\n\r\n- Rewrite the comment at the top of `HashJoin` to better explain the precedence for choosing join operators.\r\n- Update `JoinSuite` to use `SqlTestUtils.withConf` for changing SQLConf settings.\r\n- Remove an inefficient use of `JavaConversions` in `ShuffledHashOuterJoin` (see https://issues.apache.org/jira/browse/SPARK-9613 for a broader discussion of why `JavaConversions` is bad and should be banned).\r\n\r\nI'm opening this patch now to run with Jenkins; there are a number of TODOs from earlier versions of this patch that still need to be investigated / resolved:\r\n\r\n- [ ] Address comment related to `boundCondition`: https://github.com/apache/spark/pull/5717#discussion_r32891269\r\n- [ ] Address other bound condition comment: https://github.com/apache/spark/pull/5717#discussion-diff-32891298\r\n- [ ] Differentiate between safe and unsafe versions via toString() or by using a different operator.\r\n- [ ] Use the new Unsafe joiner.\r\n\r\nThis patch incorporates several ideas from @adrian-wang's patch, #5717.\r\n\r\nCloses #5717.\r\n\r\n<!-- Reviewable:start -->\r\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/apache/spark/7904)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/127801984","html_url":"https://github.com/apache/spark/pull/7904#issuecomment-127801984","issue_url":"https://api.github.com/repos/apache/spark/issues/7904","id":127801984,"user":{"login":"AmplabJenkins","id":4031291,"avatar_url":"https://avatars.githubusercontent.com/u/4031291?v=3","gravatar_id":"","url":"https://api.github.com/users/AmplabJenkins","html_url":"https://github.com/AmplabJenkins","followers_url":"https://api.github.com/users/AmplabJenkins/followers","following_url":"https://api.github.com/users/AmplabJenkins/following{/other_user}","gists_url":"https://api.github.com/users/AmplabJenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/AmplabJenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmplabJenkins/subscriptions","organizations_url":"https://api.github.com/users/AmplabJenkins/orgs","repos_url":"https://api.github.com/users/AmplabJenkins/repos","events_url":"https://api.github.com/users/AmplabJenkins/events{/privacy}","received_events_url":"https://api.github.com/users/AmplabJenkins/received_events","type":"User","site_admin":false},"created_at":"2015-08-05T00:18:25Z","updated_at":"2015-08-05T00:18:25Z","body":"Merged build finished. Test FAILed."}}