{"action":"created","issue":{"url":"https://api.github.com/repos/tryshoppe/shoppe/issues/206","labels_url":"https://api.github.com/repos/tryshoppe/shoppe/issues/206/labels{/name}","comments_url":"https://api.github.com/repos/tryshoppe/shoppe/issues/206/comments","events_url":"https://api.github.com/repos/tryshoppe/shoppe/issues/206/events","html_url":"https://github.com/tryshoppe/shoppe/issues/206","id":85461371,"number":206,"title":"Docu \"Working with Shoppe baskets\"","user":{"login":"erikpaperik","id":7869061,"avatar_url":"https://avatars.githubusercontent.com/u/7869061?v=3","gravatar_id":"","url":"https://api.github.com/users/erikpaperik","html_url":"https://github.com/erikpaperik","followers_url":"https://api.github.com/users/erikpaperik/followers","following_url":"https://api.github.com/users/erikpaperik/following{/other_user}","gists_url":"https://api.github.com/users/erikpaperik/gists{/gist_id}","starred_url":"https://api.github.com/users/erikpaperik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikpaperik/subscriptions","organizations_url":"https://api.github.com/users/erikpaperik/orgs","repos_url":"https://api.github.com/users/erikpaperik/repos","events_url":"https://api.github.com/users/erikpaperik/events{/privacy}","received_events_url":"https://api.github.com/users/erikpaperik/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-06-05T07:26:56Z","updated_at":"2015-06-05T08:18:58Z","closed_at":null,"body":"This [guide](http://tryshoppe.com/docs/tutorials/baskets) explains that the relationship between customer and order for implementing a basket should be established by using the ```ip_address```.\r\n\r\nThat means that two customers behind a proxy would share the same basket right?!\r\n\r\nMaybe it's better to use a unique session id for this purpose."},"comment":{"url":"https://api.github.com/repos/tryshoppe/shoppe/issues/comments/109200523","html_url":"https://github.com/tryshoppe/shoppe/issues/206#issuecomment-109200523","issue_url":"https://api.github.com/repos/tryshoppe/shoppe/issues/206","id":109200523,"user":{"login":"erikpaperik","id":7869061,"avatar_url":"https://avatars.githubusercontent.com/u/7869061?v=3","gravatar_id":"","url":"https://api.github.com/users/erikpaperik","html_url":"https://github.com/erikpaperik","followers_url":"https://api.github.com/users/erikpaperik/followers","following_url":"https://api.github.com/users/erikpaperik/following{/other_user}","gists_url":"https://api.github.com/users/erikpaperik/gists{/gist_id}","starred_url":"https://api.github.com/users/erikpaperik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikpaperik/subscriptions","organizations_url":"https://api.github.com/users/erikpaperik/orgs","repos_url":"https://api.github.com/users/erikpaperik/repos","events_url":"https://api.github.com/users/erikpaperik/events{/privacy}","received_events_url":"https://api.github.com/users/erikpaperik/received_events","type":"User","site_admin":false},"created_at":"2015-06-05T08:18:58Z","updated_at":"2015-06-05T08:18:58Z","body":"You are right. The ```:order_id``` is stored in the users session (```session[:order_id] = order.id```).\r\n\r\nImagine the following scenario:\r\n* Person A and person B are behind the same proxy\r\n* Person A visits the shop and adds an item to the basket -> This action creates an order with ```ip_address``` as reference to customer and stores ```:order_id``` in the users session\r\n* Person B visits the shop and gets the basket of person A, because the share the same ip address\r\n"}}