{"action":"created","comment":{"url":"https://api.github.com/repos/pnambiarsf/scrooge/pulls/comments/40740453","id":40740453,"diff_hunk":"@@ -64,7 +64,7 @@ object Scrooge extends Build {\n     version := libVersion,\n     organization := \"com.twitter\",\n     crossScalaVersions := Seq(\"2.10.5\" , \"2.11.7\"),\n-    scalaVersion := \"2.10.5\",\n+    scalaVersion := \"2.11.7\",","path":"project/Build.scala","position":5,"original_position":5,"commit_id":"e9da8a0448dee30462842651e02f0f8e22e2c5d8","original_commit_id":"e9da8a0448dee30462842651e02f0f8e22e2c5d8","user":{"login":"b-hoyt","id":1485647,"avatar_url":"https://avatars.githubusercontent.com/u/1485647?v=3","gravatar_id":"","url":"https://api.github.com/users/b-hoyt","html_url":"https://github.com/b-hoyt","followers_url":"https://api.github.com/users/b-hoyt/followers","following_url":"https://api.github.com/users/b-hoyt/following{/other_user}","gists_url":"https://api.github.com/users/b-hoyt/gists{/gist_id}","starred_url":"https://api.github.com/users/b-hoyt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b-hoyt/subscriptions","organizations_url":"https://api.github.com/users/b-hoyt/orgs","repos_url":"https://api.github.com/users/b-hoyt/repos","events_url":"https://api.github.com/users/b-hoyt/events{/privacy}","received_events_url":"https://api.github.com/users/b-hoyt/received_events","type":"User","site_admin":false},"body":"General curiousity: why did you have to change scalaVersion? The line above, crossScalaVersions makes me think this is anticipated, but I'm also thinking from the perspective of Twitter guys accepting a pull request down the road.","created_at":"2015-09-29T22:43:38Z","updated_at":"2015-09-29T22:43:38Z","html_url":"https://github.com/pnambiarsf/scrooge/pull/1#discussion_r40740453","pull_request_url":"https://api.github.com/repos/pnambiarsf/scrooge/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/pnambiarsf/scrooge/pulls/comments/40740453"},"html":{"href":"https://github.com/pnambiarsf/scrooge/pull/1#discussion_r40740453"},"pull_request":{"href":"https://api.github.com/repos/pnambiarsf/scrooge/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/pnambiarsf/scrooge/pulls/1","id":46323805,"html_url":"https://github.com/pnambiarsf/scrooge/pull/1","diff_url":"https://github.com/pnambiarsf/scrooge/pull/1.diff","patch_url":"https://github.com/pnambiarsf/scrooge/pull/1.patch","issue_url":"https://api.github.com/repos/pnambiarsf/scrooge/issues/1","number":1,"state":"open","locked":false,"title":"Return CompletableFuture instead of Future","user":{"login":"pnambiarsf","id":9439354,"avatar_url":"https://avatars.githubusercontent.com/u/9439354?v=3","gravatar_id":"","url":"https://api.github.com/users/pnambiarsf","html_url":"https://github.com/pnambiarsf","followers_url":"https://api.github.com/users/pnambiarsf/followers","following_url":"https://api.github.com/users/pnambiarsf/following{/other_user}","gists_url":"https://api.github.com/users/pnambiarsf/gists{/gist_id}","starred_url":"https://api.github.com/users/pnambiarsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnambiarsf/subscriptions","organizations_url":"https://api.github.com/users/pnambiarsf/orgs","repos_url":"https://api.github.com/users/pnambiarsf/repos","events_url":"https://api.github.com/users/pnambiarsf/events{/privacy}","received_events_url":"https://api.github.com/users/pnambiarsf/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-29T19:55:04Z","updated_at":"2015-09-29T22:43:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fcaaa253cedf8d77886b302f14ef4897e245ba42","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pnambiarsf/scrooge/pulls/1/commits","review_comments_url":"https://api.github.com/repos/pnambiarsf/scrooge/pulls/1/comments","review_comment_url":"https://api.github.com/repos/pnambiarsf/scrooge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pnambiarsf/scrooge/issues/1/comments","statuses_url":"https://api.github.com/repos/pnambiarsf/scrooge/statuses/e9da8a0448dee30462842651e02f0f8e22e2c5d8","head":{"label":"pnambiarsf:pnambiar/CF","ref":"pnambiar/CF","sha":"e9da8a0448dee30462842651e02f0f8e22e2c5d8","user":{"login":"pnambiarsf","id":9439354,"avatar_url":"https://avatars.githubusercontent.com/u/9439354?v=3","gravatar_id":"","url":"https://api.github.com/users/pnambiarsf","html_url":"https://github.com/pnambiarsf","followers_url":"https://api.github.com/users/pnambiarsf/followers","following_url":"https://api.github.com/users/pnambiarsf/following{/other_user}","gists_url":"https://api.github.com/users/pnambiarsf/gists{/gist_id}","starred_url":"https://api.github.com/users/pnambiarsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnambiarsf/subscriptions","organizations_url":"https://api.github.com/users/pnambiarsf/orgs","repos_url":"https://api.github.com/users/pnambiarsf/repos","events_url":"https://api.github.com/users/pnambiarsf/events{/privacy}","received_events_url":"https://api.github.com/users/pnambiarsf/received_events","type":"User","site_admin":false},"repo":{"id":43146646,"name":"scrooge","full_name":"pnambiarsf/scrooge","owner":{"login":"pnambiarsf","id":9439354,"avatar_url":"https://avatars.githubusercontent.com/u/9439354?v=3","gravatar_id":"","url":"https://api.github.com/users/pnambiarsf","html_url":"https://github.com/pnambiarsf","followers_url":"https://api.github.com/users/pnambiarsf/followers","following_url":"https://api.github.com/users/pnambiarsf/following{/other_user}","gists_url":"https://api.github.com/users/pnambiarsf/gists{/gist_id}","starred_url":"https://api.github.com/users/pnambiarsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnambiarsf/subscriptions","organizations_url":"https://api.github.com/users/pnambiarsf/orgs","repos_url":"https://api.github.com/users/pnambiarsf/repos","events_url":"https://api.github.com/users/pnambiarsf/events{/privacy}","received_events_url":"https://api.github.com/users/pnambiarsf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pnambiarsf/scrooge","description":"A Thrift parser/generator","fork":true,"url":"https://api.github.com/repos/pnambiarsf/scrooge","forks_url":"https://api.github.com/repos/pnambiarsf/scrooge/forks","keys_url":"https://api.github.com/repos/pnambiarsf/scrooge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pnambiarsf/scrooge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pnambiarsf/scrooge/teams","hooks_url":"https://api.github.com/repos/pnambiarsf/scrooge/hooks","issue_events_url":"https://api.github.com/repos/pnambiarsf/scrooge/issues/events{/number}","events_url":"https://api.github.com/repos/pnambiarsf/scrooge/events","assignees_url":"https://api.github.com/repos/pnambiarsf/scrooge/assignees{/user}","branches_url":"https://api.github.com/repos/pnambiarsf/scrooge/branches{/branch}","tags_url":"https://api.github.com/repos/pnambiarsf/scrooge/tags","blobs_url":"https://api.github.com/repos/pnambiarsf/scrooge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pnambiarsf/scrooge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pnambiarsf/scrooge/git/refs{/sha}","trees_url":"https://api.github.com/repos/pnambiarsf/scrooge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pnambiarsf/scrooge/statuses/{sha}","languages_url":"https://api.github.com/repos/pnambiarsf/scrooge/languages","stargazers_url":"https://api.github.com/repos/pnambiarsf/scrooge/stargazers","contributors_url":"https://api.github.com/repos/pnambiarsf/scrooge/contributors","subscribers_url":"https://api.github.com/repos/pnambiarsf/scrooge/subscribers","subscription_url":"https://api.github.com/repos/pnambiarsf/scrooge/subscription","commits_url":"https://api.github.com/repos/pnambiarsf/scrooge/commits{/sha}","git_commits_url":"https://api.github.com/repos/pnambiarsf/scrooge/git/commits{/sha}","comments_url":"https://api.github.com/repos/pnambiarsf/scrooge/comments{/number}","issue_comment_url":"https://api.github.com/repos/pnambiarsf/scrooge/issues/comments{/number}","contents_url":"https://api.github.com/repos/pnambiarsf/scrooge/contents/{+path}","compare_url":"https://api.github.com/repos/pnambiarsf/scrooge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pnambiarsf/scrooge/merges","archive_url":"https://api.github.com/repos/pnambiarsf/scrooge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pnambiarsf/scrooge/downloads","issues_url":"https://api.github.com/repos/pnambiarsf/scrooge/issues{/number}","pulls_url":"https://api.github.com/repos/pnambiarsf/scrooge/pulls{/number}","milestones_url":"https://api.github.com/repos/pnambiarsf/scrooge/milestones{/number}","notifications_url":"https://api.github.com/repos/pnambiarsf/scrooge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pnambiarsf/scrooge/labels{/name}","releases_url":"https://api.github.com/repos/pnambiarsf/scrooge/releases{/id}","created_at":"2015-09-25T14:00:21Z","updated_at":"2015-09-25T14:00:23Z","pushed_at":"2015-09-29T19:55:05Z","git_url":"git://github.com/pnambiarsf/scrooge.git","ssh_url":"git@github.com:pnambiarsf/scrooge.git","clone_url":"https://github.com/pnambiarsf/scrooge.git","svn_url":"https://github.com/pnambiarsf/scrooge","homepage":"http://twitter.github.io/scrooge/","size":19151,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"pnambiarsf:develop","ref":"develop","sha":"5b9018d0d3667b13154400c95f32c383d9f0733a","user":{"login":"pnambiarsf","id":9439354,"avatar_url":"https://avatars.githubusercontent.com/u/9439354?v=3","gravatar_id":"","url":"https://api.github.com/users/pnambiarsf","html_url":"https://github.com/pnambiarsf","followers_url":"https://api.github.com/users/pnambiarsf/followers","following_url":"https://api.github.com/users/pnambiarsf/following{/other_user}","gists_url":"https://api.github.com/users/pnambiarsf/gists{/gist_id}","starred_url":"https://api.github.com/users/pnambiarsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnambiarsf/subscriptions","organizations_url":"https://api.github.com/users/pnambiarsf/orgs","repos_url":"https://api.github.com/users/pnambiarsf/repos","events_url":"https://api.github.com/users/pnambiarsf/events{/privacy}","received_events_url":"https://api.github.com/users/pnambiarsf/received_events","type":"User","site_admin":false},"repo":{"id":43146646,"name":"scrooge","full_name":"pnambiarsf/scrooge","owner":{"login":"pnambiarsf","id":9439354,"avatar_url":"https://avatars.githubusercontent.com/u/9439354?v=3","gravatar_id":"","url":"https://api.github.com/users/pnambiarsf","html_url":"https://github.com/pnambiarsf","followers_url":"https://api.github.com/users/pnambiarsf/followers","following_url":"https://api.github.com/users/pnambiarsf/following{/other_user}","gists_url":"https://api.github.com/users/pnambiarsf/gists{/gist_id}","starred_url":"https://api.github.com/users/pnambiarsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnambiarsf/subscriptions","organizations_url":"https://api.github.com/users/pnambiarsf/orgs","repos_url":"https://api.github.com/users/pnambiarsf/repos","events_url":"https://api.github.com/users/pnambiarsf/events{/privacy}","received_events_url":"https://api.github.com/users/pnambiarsf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pnambiarsf/scrooge","description":"A Thrift parser/generator","fork":true,"url":"https://api.github.com/repos/pnambiarsf/scrooge","forks_url":"https://api.github.com/repos/pnambiarsf/scrooge/forks","keys_url":"https://api.github.com/repos/pnambiarsf/scrooge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pnambiarsf/scrooge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pnambiarsf/scrooge/teams","hooks_url":"https://api.github.com/repos/pnambiarsf/scrooge/hooks","issue_events_url":"https://api.github.com/repos/pnambiarsf/scrooge/issues/events{/number}","events_url":"https://api.github.com/repos/pnambiarsf/scrooge/events","assignees_url":"https://api.github.com/repos/pnambiarsf/scrooge/assignees{/user}","branches_url":"https://api.github.com/repos/pnambiarsf/scrooge/branches{/branch}","tags_url":"https://api.github.com/repos/pnambiarsf/scrooge/tags","blobs_url":"https://api.github.com/repos/pnambiarsf/scrooge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pnambiarsf/scrooge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pnambiarsf/scrooge/git/refs{/sha}","trees_url":"https://api.github.com/repos/pnambiarsf/scrooge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pnambiarsf/scrooge/statuses/{sha}","languages_url":"https://api.github.com/repos/pnambiarsf/scrooge/languages","stargazers_url":"https://api.github.com/repos/pnambiarsf/scrooge/stargazers","contributors_url":"https://api.github.com/repos/pnambiarsf/scrooge/contributors","subscribers_url":"https://api.github.com/repos/pnambiarsf/scrooge/subscribers","subscription_url":"https://api.github.com/repos/pnambiarsf/scrooge/subscription","commits_url":"https://api.github.com/repos/pnambiarsf/scrooge/commits{/sha}","git_commits_url":"https://api.github.com/repos/pnambiarsf/scrooge/git/commits{/sha}","comments_url":"https://api.github.com/repos/pnambiarsf/scrooge/comments{/number}","issue_comment_url":"https://api.github.com/repos/pnambiarsf/scrooge/issues/comments{/number}","contents_url":"https://api.github.com/repos/pnambiarsf/scrooge/contents/{+path}","compare_url":"https://api.github.com/repos/pnambiarsf/scrooge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pnambiarsf/scrooge/merges","archive_url":"https://api.github.com/repos/pnambiarsf/scrooge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pnambiarsf/scrooge/downloads","issues_url":"https://api.github.com/repos/pnambiarsf/scrooge/issues{/number}","pulls_url":"https://api.github.com/repos/pnambiarsf/scrooge/pulls{/number}","milestones_url":"https://api.github.com/repos/pnambiarsf/scrooge/milestones{/number}","notifications_url":"https://api.github.com/repos/pnambiarsf/scrooge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pnambiarsf/scrooge/labels{/name}","releases_url":"https://api.github.com/repos/pnambiarsf/scrooge/releases{/id}","created_at":"2015-09-25T14:00:21Z","updated_at":"2015-09-25T14:00:23Z","pushed_at":"2015-09-29T19:55:05Z","git_url":"git://github.com/pnambiarsf/scrooge.git","ssh_url":"git@github.com:pnambiarsf/scrooge.git","clone_url":"https://github.com/pnambiarsf/scrooge.git","svn_url":"https://github.com/pnambiarsf/scrooge","homepage":"http://twitter.github.io/scrooge/","size":19151,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/pnambiarsf/scrooge/pulls/1"},"html":{"href":"https://github.com/pnambiarsf/scrooge/pull/1"},"issue":{"href":"https://api.github.com/repos/pnambiarsf/scrooge/issues/1"},"comments":{"href":"https://api.github.com/repos/pnambiarsf/scrooge/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/pnambiarsf/scrooge/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/pnambiarsf/scrooge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pnambiarsf/scrooge/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/pnambiarsf/scrooge/statuses/e9da8a0448dee30462842651e02f0f8e22e2c5d8"}}}}