{"action":"created","comment":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/44329943","id":44329943,"diff_hunk":"@@ -1,49 +1,48 @@\n # Killer facts about triangles AWW YEAH\n class Triangle\n-\tattr_accessor :side1,:side2,:side3\n+\tattr_accessor :side_1, :side_2, :side_3\n \n-\tdef initialize(side1,side2,side3)\n-\t\t@side1,@side2,@side3 = side1,side2,side3\n+\tdef initialize(side_1, side_2, side_3)\n+\t\t@side_1 = side_1\n+\t\t@side_2 = side_2\n+\t\t@side_3 = side_3\n \tend\n \n-\tdef equilateral()\n-\t\treturn side1 == side2 && side2 == side3\n+\tdef equilateral?\n+\t\t(side_1 == side_2) && (side_2 == side_3)\n \tend\n \n-\tdef isosceles()\n-\t\treturn [side1,side2,side3].uniq.length == 2\n+\tdef isosceles?\n+\t\t[side_1, side_2, side_3].uniq.length == 2\n \tend\n \n-\tdef scalene()\n-\t\tunless ! (equilateral || isosceles)\n+\tdef scalene?\n+\t\treturn true unless (equilateral? || isosceles?)\n \t    false\n-\t  else\n-\t    true\n-\t  end\n \tend\n \n \tdef recite_facts\n-\t\tputs 'This triangle is equilateral!' if equilateral\n-\t\tputs 'This triangle is isosceles! Also, that word is hard to type.' if isosceles \n-\t\tputs 'This triangle is scalene and mathematically boring.' if scalene \n+\t\tputs 'This triangle is equilateral!' if equilateral?\n+\t\tputs 'This triangle is isosceles! Also, that word is hard to type.' if isosceles? \n+\t\tputs 'This triangle is scalene and mathematically boring.' if scalene?\n \n-\t\tangles = self.calculate_angles(side1,side2,side3)\n+\t\tangles = self.calculate_angles(side_1, side_2, side_3)\n \t\tputs 'The angles of this triangle are ' + angles.join(',')\n \n \t\tputs 'This triangle is also a right triangle!' if angles.include? 90\n \t\tputs ''\n \tend\n \n-\tdef calculate_angles(a,b,c)\n-\t\tangleA = radians_to_degrees(Math.acos((b**2 + c**2 - a**2) / (2.0 * b * c)))\n-\t\tangleB = radians_to_degrees(Math.acos((a**2 + c**2 - b**2) / (2.0 * a * c)))\n-\t\tangleC = radians_to_degrees(Math.acos((a**2 + b**2 - c**2) / (2.0 * a * b)))\n+\tdef calculate_angles(side_1, side_2, side_3)\n+\t\tangle_A = radians_to_degrees(Math.acos((side_2**2 + side_3**2 - side_1**2) / (2.0 * side_2 * side_3)))\n+\t\tangle_B = radians_to_degrees(Math.acos((side_1**2 + side_3**2 - side_2**2) / (2.0 * side_1 * side_3)))\n+\t\tangle_C = radians_to_degrees(Math.acos((side_1**2 + side_2**2 - side_3**2) / (2.0 * side_1 * side_2)))\n \n-\t\treturn [angleA, angleB, angleC]\n+\t\t[angle_A, angle_B, angle_C]","path":"triangle_facts/triangle_facts.rb","position":62,"original_position":62,"commit_id":"30e6f59002e5df97129d932251ecb7dfdb25ab38","original_commit_id":"30e6f59002e5df97129d932251ecb7dfdb25ab38","user":{"login":"zsyed1","id":8593056,"avatar_url":"https://avatars.githubusercontent.com/u/8593056?v=3","gravatar_id":"","url":"https://api.github.com/users/zsyed1","html_url":"https://github.com/zsyed1","followers_url":"https://api.github.com/users/zsyed1/followers","following_url":"https://api.github.com/users/zsyed1/following{/other_user}","gists_url":"https://api.github.com/users/zsyed1/gists{/gist_id}","starred_url":"https://api.github.com/users/zsyed1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zsyed1/subscriptions","organizations_url":"https://api.github.com/users/zsyed1/orgs","repos_url":"https://api.github.com/users/zsyed1/repos","events_url":"https://api.github.com/users/zsyed1/events{/privacy}","received_events_url":"https://api.github.com/users/zsyed1/received_events","type":"User","site_admin":false},"body":"Lines 37 - 39 are too repetitive. Create a single method:\r\n```\r\ndef included_angle(a, b, c)\r\n  angle = Math.acos((a**2 + b**2 - c**2) / (2.0 * a * b))\r\n  radians_to_degrees(angle)\r\nend\r\n```\r\n\r\nThen invoke this method three times in `angles`:\r\n```\r\ndef angles\r\n  [included_angle(a, b, c),\r\n   included_angle(a, c, b),\r\n   included_angle(b, c, a)]\r\nend\r\n```","created_at":"2015-11-09T20:54:35Z","updated_at":"2015-11-09T20:54:35Z","html_url":"https://github.com/jmmastey/level_up_exercises/pull/1047#discussion_r44329943","pull_request_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/1047","_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/44329943"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/1047#discussion_r44329943"},"pull_request":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/1047"}}},"pull_request":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/1047","id":50153654,"html_url":"https://github.com/jmmastey/level_up_exercises/pull/1047","diff_url":"https://github.com/jmmastey/level_up_exercises/pull/1047.diff","patch_url":"https://github.com/jmmastey/level_up_exercises/pull/1047.patch","issue_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/1047","number":1047,"state":"open","locked":false,"title":"Refactor and fix violations of the ruby style guide","user":{"login":"cstavitsky","id":12092849,"avatar_url":"https://avatars.githubusercontent.com/u/12092849?v=3","gravatar_id":"","url":"https://api.github.com/users/cstavitsky","html_url":"https://github.com/cstavitsky","followers_url":"https://api.github.com/users/cstavitsky/followers","following_url":"https://api.github.com/users/cstavitsky/following{/other_user}","gists_url":"https://api.github.com/users/cstavitsky/gists{/gist_id}","starred_url":"https://api.github.com/users/cstavitsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cstavitsky/subscriptions","organizations_url":"https://api.github.com/users/cstavitsky/orgs","repos_url":"https://api.github.com/users/cstavitsky/repos","events_url":"https://api.github.com/users/cstavitsky/events{/privacy}","received_events_url":"https://api.github.com/users/cstavitsky/received_events","type":"User","site_admin":false},"body":"Was unsure about the recite_facts method from line 24 to 34, would be interested to know if you think this method should be broken up at all.","created_at":"2015-11-09T17:44:28Z","updated_at":"2015-11-09T20:54:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c6401737c432f1e528fc992acf349ef9811a429","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/1047/commits","review_comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/1047/comments","review_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/1047/comments","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/30e6f59002e5df97129d932251ecb7dfdb25ab38","head":{"label":"cstavitsky:ruby-style-guide","ref":"ruby-style-guide","sha":"30e6f59002e5df97129d932251ecb7dfdb25ab38","user":{"login":"cstavitsky","id":12092849,"avatar_url":"https://avatars.githubusercontent.com/u/12092849?v=3","gravatar_id":"","url":"https://api.github.com/users/cstavitsky","html_url":"https://github.com/cstavitsky","followers_url":"https://api.github.com/users/cstavitsky/followers","following_url":"https://api.github.com/users/cstavitsky/following{/other_user}","gists_url":"https://api.github.com/users/cstavitsky/gists{/gist_id}","starred_url":"https://api.github.com/users/cstavitsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cstavitsky/subscriptions","organizations_url":"https://api.github.com/users/cstavitsky/orgs","repos_url":"https://api.github.com/users/cstavitsky/repos","events_url":"https://api.github.com/users/cstavitsky/events{/privacy}","received_events_url":"https://api.github.com/users/cstavitsky/received_events","type":"User","site_admin":false},"repo":{"id":45553538,"name":"level_up_exercises","full_name":"cstavitsky/level_up_exercises","owner":{"login":"cstavitsky","id":12092849,"avatar_url":"https://avatars.githubusercontent.com/u/12092849?v=3","gravatar_id":"","url":"https://api.github.com/users/cstavitsky","html_url":"https://github.com/cstavitsky","followers_url":"https://api.github.com/users/cstavitsky/followers","following_url":"https://api.github.com/users/cstavitsky/following{/other_user}","gists_url":"https://api.github.com/users/cstavitsky/gists{/gist_id}","starred_url":"https://api.github.com/users/cstavitsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cstavitsky/subscriptions","organizations_url":"https://api.github.com/users/cstavitsky/orgs","repos_url":"https://api.github.com/users/cstavitsky/repos","events_url":"https://api.github.com/users/cstavitsky/events{/privacy}","received_events_url":"https://api.github.com/users/cstavitsky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cstavitsky/level_up_exercises","description":"A series of code-related assignments to challenge starting engineers","fork":true,"url":"https://api.github.com/repos/cstavitsky/level_up_exercises","forks_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/forks","keys_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/events","assignees_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/issues/comments{/number}","contents_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/merges","archive_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/cstavitsky/level_up_exercises/releases{/id}","created_at":"2015-11-04T16:55:13Z","updated_at":"2015-11-04T16:55:14Z","pushed_at":"2015-11-09T17:51:19Z","git_url":"git://github.com/cstavitsky/level_up_exercises.git","ssh_url":"git@github.com:cstavitsky/level_up_exercises.git","clone_url":"https://github.com/cstavitsky/level_up_exercises.git","svn_url":"https://github.com/cstavitsky/level_up_exercises","homepage":"https://leveluprails.com","size":223483,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jmmastey:master","ref":"master","sha":"ee878bc2c9a3337ffa3372654f508733dd2f66c1","user":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"repo":{"id":20705648,"name":"level_up_exercises","full_name":"jmmastey/level_up_exercises","owner":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmmastey/level_up_exercises","description":"A series of code-related assignments to challenge starting engineers","fork":false,"url":"https://api.github.com/repos/jmmastey/level_up_exercises","forks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/forks","keys_url":"https://api.github.com/repos/jmmastey/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmmastey/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmmastey/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/events","assignees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/jmmastey/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/jmmastey/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/jmmastey/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmmastey/level_up_exercises/merges","archive_url":"https://api.github.com/repos/jmmastey/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmmastey/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/jmmastey/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/jmmastey/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmmastey/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/jmmastey/level_up_exercises/releases{/id}","created_at":"2014-06-10T23:42:24Z","updated_at":"2015-11-05T01:28:26Z","pushed_at":"2015-11-09T17:52:44Z","git_url":"git://github.com/jmmastey/level_up_exercises.git","ssh_url":"git@github.com:jmmastey/level_up_exercises.git","clone_url":"https://github.com/jmmastey/level_up_exercises.git","svn_url":"https://github.com/jmmastey/level_up_exercises","homepage":"https://leveluprails.com","size":223483,"stargazers_count":31,"watchers_count":31,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":152,"mirror_url":null,"open_issues_count":4,"forks":152,"open_issues":4,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/1047"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/1047"},"issue":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/1047"},"comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/1047/comments"},"review_comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/1047/comments"},"review_comment":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/1047/commits"},"statuses":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/30e6f59002e5df97129d932251ecb7dfdb25ab38"}}}}