{"action":"opened","number":3927,"pull_request":{"url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3927","id":34596627,"html_url":"https://github.com/activeadmin/activeadmin/pull/3927","diff_url":"https://github.com/activeadmin/activeadmin/pull/3927.diff","patch_url":"https://github.com/activeadmin/activeadmin/pull/3927.patch","issue_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/3927","number":3927,"state":"open","locked":false,"title":"Allow ApplicationController and helpers to reload in development environment","user":{"login":"jvaill","id":424704,"avatar_url":"https://avatars.githubusercontent.com/u/424704?v=3","gravatar_id":"","url":"https://api.github.com/users/jvaill","html_url":"https://github.com/jvaill","followers_url":"https://api.github.com/users/jvaill/followers","following_url":"https://api.github.com/users/jvaill/following{/other_user}","gists_url":"https://api.github.com/users/jvaill/gists{/gist_id}","starred_url":"https://api.github.com/users/jvaill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvaill/subscriptions","organizations_url":"https://api.github.com/users/jvaill/orgs","repos_url":"https://api.github.com/users/jvaill/repos","events_url":"https://api.github.com/users/jvaill/events{/privacy}","received_events_url":"https://api.github.com/users/jvaill/received_events","type":"User","site_admin":false},"body":"This fixes https://github.com/activeadmin/activeadmin/issues/697.\r\n\r\nThe problem is that `PageController` and its ancestors (up until `::InheritedResources::Base`) don't reload by default and thus don't end up inheriting from future changes made to `ApplicationController`. It turns out that autoloading a class with `ActiveSupport::Autoload` does nothing to hook into Rails' reloading mechanism.\r\n\r\nThis PR moves the controllers to `app/controllers/` which allows Rails to take over its autoloading, and then its reloading.\r\n\r\nA good way to test this is with @timoschilling's minimal test case:\r\nhttps://github.com/activeadmin/activeadmin_helper_reload_bug\r\n\r\n:tada: ","created_at":"2015-05-03T05:28:19Z","updated_at":"2015-05-03T05:28:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3927/commits","review_comments_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3927/comments","review_comment_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/3927/comments","statuses_url":"https://api.github.com/repos/activeadmin/activeadmin/statuses/ebf34851f03372441c08ba2c7ae45142d61f0e05","head":{"label":"jvaill:fix-reloading-helpers","ref":"fix-reloading-helpers","sha":"ebf34851f03372441c08ba2c7ae45142d61f0e05","user":{"login":"jvaill","id":424704,"avatar_url":"https://avatars.githubusercontent.com/u/424704?v=3","gravatar_id":"","url":"https://api.github.com/users/jvaill","html_url":"https://github.com/jvaill","followers_url":"https://api.github.com/users/jvaill/followers","following_url":"https://api.github.com/users/jvaill/following{/other_user}","gists_url":"https://api.github.com/users/jvaill/gists{/gist_id}","starred_url":"https://api.github.com/users/jvaill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvaill/subscriptions","organizations_url":"https://api.github.com/users/jvaill/orgs","repos_url":"https://api.github.com/users/jvaill/repos","events_url":"https://api.github.com/users/jvaill/events{/privacy}","received_events_url":"https://api.github.com/users/jvaill/received_events","type":"User","site_admin":false},"repo":{"id":34972872,"name":"activeadmin","full_name":"jvaill/activeadmin","owner":{"login":"jvaill","id":424704,"avatar_url":"https://avatars.githubusercontent.com/u/424704?v=3","gravatar_id":"","url":"https://api.github.com/users/jvaill","html_url":"https://github.com/jvaill","followers_url":"https://api.github.com/users/jvaill/followers","following_url":"https://api.github.com/users/jvaill/following{/other_user}","gists_url":"https://api.github.com/users/jvaill/gists{/gist_id}","starred_url":"https://api.github.com/users/jvaill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvaill/subscriptions","organizations_url":"https://api.github.com/users/jvaill/orgs","repos_url":"https://api.github.com/users/jvaill/repos","events_url":"https://api.github.com/users/jvaill/events{/privacy}","received_events_url":"https://api.github.com/users/jvaill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jvaill/activeadmin","description":"The administration framework for Ruby on Rails applications.","fork":true,"url":"https://api.github.com/repos/jvaill/activeadmin","forks_url":"https://api.github.com/repos/jvaill/activeadmin/forks","keys_url":"https://api.github.com/repos/jvaill/activeadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jvaill/activeadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jvaill/activeadmin/teams","hooks_url":"https://api.github.com/repos/jvaill/activeadmin/hooks","issue_events_url":"https://api.github.com/repos/jvaill/activeadmin/issues/events{/number}","events_url":"https://api.github.com/repos/jvaill/activeadmin/events","assignees_url":"https://api.github.com/repos/jvaill/activeadmin/assignees{/user}","branches_url":"https://api.github.com/repos/jvaill/activeadmin/branches{/branch}","tags_url":"https://api.github.com/repos/jvaill/activeadmin/tags","blobs_url":"https://api.github.com/repos/jvaill/activeadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jvaill/activeadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jvaill/activeadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jvaill/activeadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jvaill/activeadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/jvaill/activeadmin/languages","stargazers_url":"https://api.github.com/repos/jvaill/activeadmin/stargazers","contributors_url":"https://api.github.com/repos/jvaill/activeadmin/contributors","subscribers_url":"https://api.github.com/repos/jvaill/activeadmin/subscribers","subscription_url":"https://api.github.com/repos/jvaill/activeadmin/subscription","commits_url":"https://api.github.com/repos/jvaill/activeadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jvaill/activeadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jvaill/activeadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jvaill/activeadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jvaill/activeadmin/contents/{+path}","compare_url":"https://api.github.com/repos/jvaill/activeadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jvaill/activeadmin/merges","archive_url":"https://api.github.com/repos/jvaill/activeadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jvaill/activeadmin/downloads","issues_url":"https://api.github.com/repos/jvaill/activeadmin/issues{/number}","pulls_url":"https://api.github.com/repos/jvaill/activeadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/jvaill/activeadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/jvaill/activeadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jvaill/activeadmin/labels{/name}","releases_url":"https://api.github.com/repos/jvaill/activeadmin/releases{/id}","created_at":"2015-05-03T03:49:15Z","updated_at":"2015-05-03T03:49:17Z","pushed_at":"2015-05-03T05:02:36Z","git_url":"git://github.com/jvaill/activeadmin.git","ssh_url":"git@github.com:jvaill/activeadmin.git","clone_url":"https://github.com/jvaill/activeadmin.git","svn_url":"https://github.com/jvaill/activeadmin","homepage":"activeadmin.info","size":18320,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"activeadmin:master","ref":"master","sha":"4baf474177fb6c4e2638d103dfb28c576b3084df","user":{"login":"activeadmin","id":814570,"avatar_url":"https://avatars.githubusercontent.com/u/814570?v=3","gravatar_id":"","url":"https://api.github.com/users/activeadmin","html_url":"https://github.com/activeadmin","followers_url":"https://api.github.com/users/activeadmin/followers","following_url":"https://api.github.com/users/activeadmin/following{/other_user}","gists_url":"https://api.github.com/users/activeadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/activeadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activeadmin/subscriptions","organizations_url":"https://api.github.com/users/activeadmin/orgs","repos_url":"https://api.github.com/users/activeadmin/repos","events_url":"https://api.github.com/users/activeadmin/events{/privacy}","received_events_url":"https://api.github.com/users/activeadmin/received_events","type":"Organization","site_admin":false},"repo":{"id":611921,"name":"activeadmin","full_name":"activeadmin/activeadmin","owner":{"login":"activeadmin","id":814570,"avatar_url":"https://avatars.githubusercontent.com/u/814570?v=3","gravatar_id":"","url":"https://api.github.com/users/activeadmin","html_url":"https://github.com/activeadmin","followers_url":"https://api.github.com/users/activeadmin/followers","following_url":"https://api.github.com/users/activeadmin/following{/other_user}","gists_url":"https://api.github.com/users/activeadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/activeadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activeadmin/subscriptions","organizations_url":"https://api.github.com/users/activeadmin/orgs","repos_url":"https://api.github.com/users/activeadmin/repos","events_url":"https://api.github.com/users/activeadmin/events{/privacy}","received_events_url":"https://api.github.com/users/activeadmin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/activeadmin/activeadmin","description":"The administration framework for Ruby on Rails applications.","fork":false,"url":"https://api.github.com/repos/activeadmin/activeadmin","forks_url":"https://api.github.com/repos/activeadmin/activeadmin/forks","keys_url":"https://api.github.com/repos/activeadmin/activeadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/activeadmin/activeadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/activeadmin/activeadmin/teams","hooks_url":"https://api.github.com/repos/activeadmin/activeadmin/hooks","issue_events_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/events{/number}","events_url":"https://api.github.com/repos/activeadmin/activeadmin/events","assignees_url":"https://api.github.com/repos/activeadmin/activeadmin/assignees{/user}","branches_url":"https://api.github.com/repos/activeadmin/activeadmin/branches{/branch}","tags_url":"https://api.github.com/repos/activeadmin/activeadmin/tags","blobs_url":"https://api.github.com/repos/activeadmin/activeadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/activeadmin/activeadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/activeadmin/activeadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/activeadmin/activeadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/activeadmin/activeadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/activeadmin/activeadmin/languages","stargazers_url":"https://api.github.com/repos/activeadmin/activeadmin/stargazers","contributors_url":"https://api.github.com/repos/activeadmin/activeadmin/contributors","subscribers_url":"https://api.github.com/repos/activeadmin/activeadmin/subscribers","subscription_url":"https://api.github.com/repos/activeadmin/activeadmin/subscription","commits_url":"https://api.github.com/repos/activeadmin/activeadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/activeadmin/activeadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/activeadmin/activeadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/activeadmin/activeadmin/contents/{+path}","compare_url":"https://api.github.com/repos/activeadmin/activeadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/activeadmin/activeadmin/merges","archive_url":"https://api.github.com/repos/activeadmin/activeadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/activeadmin/activeadmin/downloads","issues_url":"https://api.github.com/repos/activeadmin/activeadmin/issues{/number}","pulls_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/activeadmin/activeadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/activeadmin/activeadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/activeadmin/activeadmin/labels{/name}","releases_url":"https://api.github.com/repos/activeadmin/activeadmin/releases{/id}","created_at":"2010-04-15T14:26:03Z","updated_at":"2015-05-03T00:34:48Z","pushed_at":"2015-05-01T20:38:46Z","git_url":"git://github.com/activeadmin/activeadmin.git","ssh_url":"git@github.com:activeadmin/activeadmin.git","clone_url":"https://github.com/activeadmin/activeadmin.git","svn_url":"https://github.com/activeadmin/activeadmin","homepage":"activeadmin.info","size":18320,"stargazers_count":5888,"watchers_count":5888,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2089,"mirror_url":null,"open_issues_count":188,"forks":2089,"open_issues":188,"watchers":5888,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3927"},"html":{"href":"https://github.com/activeadmin/activeadmin/pull/3927"},"issue":{"href":"https://api.github.com/repos/activeadmin/activeadmin/issues/3927"},"comments":{"href":"https://api.github.com/repos/activeadmin/activeadmin/issues/3927/comments"},"review_comments":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3927/comments"},"review_comment":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3927/commits"},"statuses":{"href":"https://api.github.com/repos/activeadmin/activeadmin/statuses/ebf34851f03372441c08ba2c7ae45142d61f0e05"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":19,"deletions":40,"changed_files":14}}