{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/data/pulls/comments/39186315","id":39186315,"diff_hunk":"@@ -254,22 +253,58 @@ test(\"Using store#findRecord on existing record reloads it\", function() {\n         }\n       }\n     });\n-    car = store.peekRecord('car', 1);\n   });\n \n   ajaxResponse({\n     cars: [{\n       id: 1,\n-      make: 'BMCW',\n-      model: 'Mini'\n+      make: 'BMC',\n+      model: 'Princess'\n+    }]\n+  });\n+\n+  run(function() {\n+    store.findRecord('car', 1).then(function(car) {\n+      equal(car.get('model'), 'Mini', 'cached car record is returned');\n+    });\n+  });\n+\n+  run(function() {\n+    let car = store.peekRecord('car', 1);\n+    equal(car.get('model'), 'Princess', 'car record was reloaded');\n+  });\n+});\n+\n+test(\"store#findRecord { reload: true } ignores cached record and reloads record from server\", function() {","path":"packages/ember-data/tests/integration/store-test.js","position":75,"original_position":75,"commit_id":"b337f57aabdd0e6e79203c61e6f45f3187ebbedc","original_commit_id":"b337f57aabdd0e6e79203c61e6f45f3187ebbedc","user":{"login":"bmac","id":54056,"avatar_url":"https://avatars.githubusercontent.com/u/54056?v=3","gravatar_id":"","url":"https://api.github.com/users/bmac","html_url":"https://github.com/bmac","followers_url":"https://api.github.com/users/bmac/followers","following_url":"https://api.github.com/users/bmac/following{/other_user}","gists_url":"https://api.github.com/users/bmac/gists{/gist_id}","starred_url":"https://api.github.com/users/bmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmac/subscriptions","organizations_url":"https://api.github.com/users/bmac/orgs","repos_url":"https://api.github.com/users/bmac/repos","events_url":"https://api.github.com/users/bmac/events{/privacy}","received_events_url":"https://api.github.com/users/bmac/received_events","type":"User","site_admin":false},"body":"@HeroicEric in this test could you also assert that `shouldReloadRecord` is never called when `{ reload: true }` is passed into findRecord?","created_at":"2015-09-10T17:15:14Z","updated_at":"2015-09-10T17:15:14Z","html_url":"https://github.com/emberjs/data/pull/3746#discussion_r39186315","pull_request_url":"https://api.github.com/repos/emberjs/data/pulls/3746","_links":{"self":{"href":"https://api.github.com/repos/emberjs/data/pulls/comments/39186315"},"html":{"href":"https://github.com/emberjs/data/pull/3746#discussion_r39186315"},"pull_request":{"href":"https://api.github.com/repos/emberjs/data/pulls/3746"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/data/pulls/3746","id":44620613,"html_url":"https://github.com/emberjs/data/pull/3746","diff_url":"https://github.com/emberjs/data/pull/3746.diff","patch_url":"https://github.com/emberjs/data/pull/3746.patch","issue_url":"https://api.github.com/repos/emberjs/data/issues/3746","number":3746,"state":"open","locked":false,"title":"Improve test coverage for store#findRecord()","user":{"login":"HeroicEric","id":602204,"avatar_url":"https://avatars.githubusercontent.com/u/602204?v=3","gravatar_id":"","url":"https://api.github.com/users/HeroicEric","html_url":"https://github.com/HeroicEric","followers_url":"https://api.github.com/users/HeroicEric/followers","following_url":"https://api.github.com/users/HeroicEric/following{/other_user}","gists_url":"https://api.github.com/users/HeroicEric/gists{/gist_id}","starred_url":"https://api.github.com/users/HeroicEric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeroicEric/subscriptions","organizations_url":"https://api.github.com/users/HeroicEric/orgs","repos_url":"https://api.github.com/users/HeroicEric/repos","events_url":"https://api.github.com/users/HeroicEric/events{/privacy}","received_events_url":"https://api.github.com/users/HeroicEric/received_events","type":"User","site_admin":false},"body":"Started working on fixing https://github.com/emberjs/data/issues/3704 by trying to write a failing test but was not able to reproduce the issue.\r\n\r\nAm I missing something?","created_at":"2015-09-10T01:56:20Z","updated_at":"2015-09-10T17:15:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4deac18624ba623babbdc76f6c2a95b94e0aaf1d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/data/pulls/3746/commits","review_comments_url":"https://api.github.com/repos/emberjs/data/pulls/3746/comments","review_comment_url":"https://api.github.com/repos/emberjs/data/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/data/issues/3746/comments","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/b337f57aabdd0e6e79203c61e6f45f3187ebbedc","head":{"label":"HeroicEric:improve-tests-for-store-find-record","ref":"improve-tests-for-store-find-record","sha":"b337f57aabdd0e6e79203c61e6f45f3187ebbedc","user":{"login":"HeroicEric","id":602204,"avatar_url":"https://avatars.githubusercontent.com/u/602204?v=3","gravatar_id":"","url":"https://api.github.com/users/HeroicEric","html_url":"https://github.com/HeroicEric","followers_url":"https://api.github.com/users/HeroicEric/followers","following_url":"https://api.github.com/users/HeroicEric/following{/other_user}","gists_url":"https://api.github.com/users/HeroicEric/gists{/gist_id}","starred_url":"https://api.github.com/users/HeroicEric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeroicEric/subscriptions","organizations_url":"https://api.github.com/users/HeroicEric/orgs","repos_url":"https://api.github.com/users/HeroicEric/repos","events_url":"https://api.github.com/users/HeroicEric/events{/privacy}","received_events_url":"https://api.github.com/users/HeroicEric/received_events","type":"User","site_admin":false},"repo":{"id":33514111,"name":"data","full_name":"HeroicEric/data","owner":{"login":"HeroicEric","id":602204,"avatar_url":"https://avatars.githubusercontent.com/u/602204?v=3","gravatar_id":"","url":"https://api.github.com/users/HeroicEric","html_url":"https://github.com/HeroicEric","followers_url":"https://api.github.com/users/HeroicEric/followers","following_url":"https://api.github.com/users/HeroicEric/following{/other_user}","gists_url":"https://api.github.com/users/HeroicEric/gists{/gist_id}","starred_url":"https://api.github.com/users/HeroicEric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeroicEric/subscriptions","organizations_url":"https://api.github.com/users/HeroicEric/orgs","repos_url":"https://api.github.com/users/HeroicEric/repos","events_url":"https://api.github.com/users/HeroicEric/events{/privacy}","received_events_url":"https://api.github.com/users/HeroicEric/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HeroicEric/data","description":"A data persistence library for Ember.js.","fork":true,"url":"https://api.github.com/repos/HeroicEric/data","forks_url":"https://api.github.com/repos/HeroicEric/data/forks","keys_url":"https://api.github.com/repos/HeroicEric/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HeroicEric/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HeroicEric/data/teams","hooks_url":"https://api.github.com/repos/HeroicEric/data/hooks","issue_events_url":"https://api.github.com/repos/HeroicEric/data/issues/events{/number}","events_url":"https://api.github.com/repos/HeroicEric/data/events","assignees_url":"https://api.github.com/repos/HeroicEric/data/assignees{/user}","branches_url":"https://api.github.com/repos/HeroicEric/data/branches{/branch}","tags_url":"https://api.github.com/repos/HeroicEric/data/tags","blobs_url":"https://api.github.com/repos/HeroicEric/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HeroicEric/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HeroicEric/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/HeroicEric/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HeroicEric/data/statuses/{sha}","languages_url":"https://api.github.com/repos/HeroicEric/data/languages","stargazers_url":"https://api.github.com/repos/HeroicEric/data/stargazers","contributors_url":"https://api.github.com/repos/HeroicEric/data/contributors","subscribers_url":"https://api.github.com/repos/HeroicEric/data/subscribers","subscription_url":"https://api.github.com/repos/HeroicEric/data/subscription","commits_url":"https://api.github.com/repos/HeroicEric/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/HeroicEric/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/HeroicEric/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/HeroicEric/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/HeroicEric/data/contents/{+path}","compare_url":"https://api.github.com/repos/HeroicEric/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HeroicEric/data/merges","archive_url":"https://api.github.com/repos/HeroicEric/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HeroicEric/data/downloads","issues_url":"https://api.github.com/repos/HeroicEric/data/issues{/number}","pulls_url":"https://api.github.com/repos/HeroicEric/data/pulls{/number}","milestones_url":"https://api.github.com/repos/HeroicEric/data/milestones{/number}","notifications_url":"https://api.github.com/repos/HeroicEric/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HeroicEric/data/labels{/name}","releases_url":"https://api.github.com/repos/HeroicEric/data/releases{/id}","created_at":"2015-04-07T00:59:19Z","updated_at":"2015-04-07T00:59:21Z","pushed_at":"2015-09-10T01:54:10Z","git_url":"git://github.com/HeroicEric/data.git","ssh_url":"git@github.com:HeroicEric/data.git","clone_url":"https://github.com/HeroicEric/data.git","svn_url":"https://github.com/HeroicEric/data","homepage":"","size":9957,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"61d7f42b040ad67bf855207f5b6ba37eeff8096d","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":3016562,"name":"data","full_name":"emberjs/data","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/data","description":"A data persistence library for Ember.js.","fork":false,"url":"https://api.github.com/repos/emberjs/data","forks_url":"https://api.github.com/repos/emberjs/data/forks","keys_url":"https://api.github.com/repos/emberjs/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/data/teams","hooks_url":"https://api.github.com/repos/emberjs/data/hooks","issue_events_url":"https://api.github.com/repos/emberjs/data/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/data/events","assignees_url":"https://api.github.com/repos/emberjs/data/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/data/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/data/tags","blobs_url":"https://api.github.com/repos/emberjs/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/data/languages","stargazers_url":"https://api.github.com/repos/emberjs/data/stargazers","contributors_url":"https://api.github.com/repos/emberjs/data/contributors","subscribers_url":"https://api.github.com/repos/emberjs/data/subscribers","subscription_url":"https://api.github.com/repos/emberjs/data/subscription","commits_url":"https://api.github.com/repos/emberjs/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/data/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/data/merges","archive_url":"https://api.github.com/repos/emberjs/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/data/downloads","issues_url":"https://api.github.com/repos/emberjs/data/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/data/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/data/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/data/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/data/releases{/id}","created_at":"2011-12-20T01:50:40Z","updated_at":"2015-09-10T11:31:17Z","pushed_at":"2015-09-10T17:11:24Z","git_url":"git://github.com/emberjs/data.git","ssh_url":"git@github.com:emberjs/data.git","clone_url":"https://github.com/emberjs/data.git","svn_url":"https://github.com/emberjs/data","homepage":"","size":29887,"stargazers_count":2512,"watchers_count":2512,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":975,"mirror_url":null,"open_issues_count":287,"forks":975,"open_issues":287,"watchers":2512,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/data/pulls/3746"},"html":{"href":"https://github.com/emberjs/data/pull/3746"},"issue":{"href":"https://api.github.com/repos/emberjs/data/issues/3746"},"comments":{"href":"https://api.github.com/repos/emberjs/data/issues/3746/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/data/pulls/3746/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/data/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/data/pulls/3746/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/data/statuses/b337f57aabdd0e6e79203c61e6f45f3187ebbedc"}}}}