{"comment":{"url":"https://api.github.com/repos/machtfit/django-emarsys/comments/12440877","html_url":"https://github.com/machtfit/django-emarsys/commit/f91723ccf68e8cfea067144d7a530165d3543318#commitcomment-12440877","id":12440877,"user":{"login":"or","id":6608430,"avatar_url":"https://avatars.githubusercontent.com/u/6608430?v=3","gravatar_id":"","url":"https://api.github.com/users/or","html_url":"https://github.com/or","followers_url":"https://api.github.com/users/or/followers","following_url":"https://api.github.com/users/or/following{/other_user}","gists_url":"https://api.github.com/users/or/gists{/gist_id}","starred_url":"https://api.github.com/users/or/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/or/subscriptions","organizations_url":"https://api.github.com/users/or/orgs","repos_url":"https://api.github.com/users/or/repos","events_url":"https://api.github.com/users/or/events{/privacy}","received_events_url":"https://api.github.com/users/or/received_events","type":"User","site_admin":false},"position":103,"line":115,"path":"tests/configuration_tests.py","commit_id":"f91723ccf68e8cfea067144d7a530165d3543318","created_at":"2015-07-30T10:50:24Z","updated_at":"2015-07-30T10:50:24Z","body":"(Let's comment on the big diff of the PR instead. Can't respond without going into the commit otherwise.)\r\n\r\nYeah, I was unsure about the replication of the code there, but it's not entirely trivial and I want to make sure `validate_configuration()` is called correctly. It also makes sure `validate_settings()` is called at least once in tests.\r\n\r\nFuture changes to `validate_settings()` could break this test and in that case it's worth a second look at the change, I think the test is justified.\r\n\r\nWith currently 7 tests the question of test running time and maintenance is a non-issue. Let's err on the side of having a few tests too many instead of missing them."}}