{"action":"created","issue":{"url":"https://api.github.com/repos/SirCmpwn/sway/issues/112","labels_url":"https://api.github.com/repos/SirCmpwn/sway/issues/112/labels{/name}","comments_url":"https://api.github.com/repos/SirCmpwn/sway/issues/112/comments","events_url":"https://api.github.com/repos/SirCmpwn/sway/issues/112/events","html_url":"https://github.com/SirCmpwn/sway/pull/112","id":102431311,"number":112,"title":"bugfixes, renames, and other things.","user":{"login":"taiyu-len","id":8948829,"avatar_url":"https://avatars.githubusercontent.com/u/8948829?v=3","gravatar_id":"","url":"https://api.github.com/users/taiyu-len","html_url":"https://github.com/taiyu-len","followers_url":"https://api.github.com/users/taiyu-len/followers","following_url":"https://api.github.com/users/taiyu-len/following{/other_user}","gists_url":"https://api.github.com/users/taiyu-len/gists{/gist_id}","starred_url":"https://api.github.com/users/taiyu-len/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taiyu-len/subscriptions","organizations_url":"https://api.github.com/users/taiyu-len/orgs","repos_url":"https://api.github.com/users/taiyu-len/repos","events_url":"https://api.github.com/users/taiyu-len/events{/privacy}","received_events_url":"https://api.github.com/users/taiyu-len/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-08-21T17:50:52Z","updated_at":"2015-08-21T19:17:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SirCmpwn/sway/pulls/112","html_url":"https://github.com/SirCmpwn/sway/pull/112","diff_url":"https://github.com/SirCmpwn/sway/pull/112.diff","patch_url":"https://github.com/SirCmpwn/sway/pull/112.patch"},"body":"first the few bugfixes, the same ones i fixed in my view_ordering pr.\r\nsplithv on floating windows, set_focused behavior for fullscreen windows.\r\n\r\nnext change is `active_workspace` -> `swayc_active_workspace()` function and other related functions such as `swayc_active_workspace_for(view)` `swayc_active_output()`\r\nsince active workspace should always be `root->focused->focused` its better to use that instead of updating active_workspace all the time.\r\n\r\nalso some name changes. `swayc_by_test()` replaces `find_container`, `sway_by_handle()` replaces `get_swayc_for_handle`\r\n\r\nreplaced the fullscreen checking with `swayc_is_fullscreen(view)` \r\n\r\nas for the window resizing with rightclick, i made it check for floating_modifier, and behave the same for resizing floating windows (no rightclick when resizing)\r\n\r\nwe could probably add a resizing_modifier or something, "},"comment":{"url":"https://api.github.com/repos/SirCmpwn/sway/issues/comments/133535458","html_url":"https://github.com/SirCmpwn/sway/pull/112#issuecomment-133535458","issue_url":"https://api.github.com/repos/SirCmpwn/sway/issues/112","id":133535458,"user":{"login":"SirCmpwn","id":1310872,"avatar_url":"https://avatars.githubusercontent.com/u/1310872?v=3","gravatar_id":"","url":"https://api.github.com/users/SirCmpwn","html_url":"https://github.com/SirCmpwn","followers_url":"https://api.github.com/users/SirCmpwn/followers","following_url":"https://api.github.com/users/SirCmpwn/following{/other_user}","gists_url":"https://api.github.com/users/SirCmpwn/gists{/gist_id}","starred_url":"https://api.github.com/users/SirCmpwn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SirCmpwn/subscriptions","organizations_url":"https://api.github.com/users/SirCmpwn/orgs","repos_url":"https://api.github.com/users/SirCmpwn/repos","events_url":"https://api.github.com/users/SirCmpwn/events{/privacy}","received_events_url":"https://api.github.com/users/SirCmpwn/received_events","type":"User","site_admin":false},"created_at":"2015-08-21T19:17:36Z","updated_at":"2015-08-21T19:17:36Z","body":"Tested this with one output, gets a :+1: from me until I get home and test with several outputs and without x (still at work, can't give this too much of my attention)."}}