{"action":"created","comment":{"url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments/38810986","id":38810986,"diff_hunk":"@@ -1,19 +1,31 @@\n require 'rails_helper'\n \n describe ActiveAdmin::Filters::Humanized do\n-  let(:param) { ['category_id_eq', '1'] }\n-\n-  subject { ActiveAdmin::Filters::Humanized.new(param) }\n-\n   describe '#value' do\n-    it 'should equal query string parameter' do\n+    it 'should equal query string parameter if not an Array' do\n+      param = ['category_id_eq', '1']\n+      subject = ActiveAdmin::Filters::Humanized.new(param)\n       expect(subject.value).to eq('1')\n     end\n+\n+    it 'should equal query string parameters separated by commas if an Array' do\n+      param = ['category_id_eq', ['1', '2']]\n+      subject = ActiveAdmin::Filters::Humanized.new(param)\n+      expect(subject.value).to eq(\"1, 2\")\n+    end\n+\n+    it 'should remove nil values before joining equal query string parameters separated by commas if an Array' do\n+      param = ['category_id_eq', ['1', nil, '2']]","path":"spec/unit/filters/humanized_spec.rb","position":23,"original_position":23,"commit_id":"d11c7e432e2ab45718e01cd6737a7028e5730791","original_commit_id":"d11c7e432e2ab45718e01cd6737a7028e5730791","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.","created_at":"2015-09-05T14:05:49Z","updated_at":"2015-09-05T14:05:49Z","html_url":"https://github.com/activeadmin/activeadmin/pull/4114#discussion_r38810986","pull_request_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/4114","_links":{"self":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments/38810986"},"html":{"href":"https://github.com/activeadmin/activeadmin/pull/4114#discussion_r38810986"},"pull_request":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/4114"}}},"pull_request":{"url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/4114","id":44283482,"html_url":"https://github.com/activeadmin/activeadmin/pull/4114","diff_url":"https://github.com/activeadmin/activeadmin/pull/4114.diff","patch_url":"https://github.com/activeadmin/activeadmin/pull/4114.patch","issue_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/4114","number":4114,"state":"open","locked":false,"title":"If the search result value is an array, then show the comma-separated…","user":{"login":"vraravam","id":69629,"avatar_url":"https://avatars.githubusercontent.com/u/69629?v=3","gravatar_id":"","url":"https://api.github.com/users/vraravam","html_url":"https://github.com/vraravam","followers_url":"https://api.github.com/users/vraravam/followers","following_url":"https://api.github.com/users/vraravam/following{/other_user}","gists_url":"https://api.github.com/users/vraravam/gists{/gist_id}","starred_url":"https://api.github.com/users/vraravam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vraravam/subscriptions","organizations_url":"https://api.github.com/users/vraravam/orgs","repos_url":"https://api.github.com/users/vraravam/repos","events_url":"https://api.github.com/users/vraravam/events{/privacy}","received_events_url":"https://api.github.com/users/vraravam/received_events","type":"User","site_admin":false},"body":"… entries in the search results section.","created_at":"2015-09-05T14:05:46Z","updated_at":"2015-09-05T14:05:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e13a9b0257790f30132bd08fbec904aea0328841","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/4114/commits","review_comments_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/4114/comments","review_comment_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/4114/comments","statuses_url":"https://api.github.com/repos/activeadmin/activeadmin/statuses/d11c7e432e2ab45718e01cd6737a7028e5730791","head":{"label":"thoughtworks:search-filters-multiple-values","ref":"search-filters-multiple-values","sha":"d11c7e432e2ab45718e01cd6737a7028e5730791","user":{"login":"thoughtworks","id":18878,"avatar_url":"https://avatars.githubusercontent.com/u/18878?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtworks","html_url":"https://github.com/thoughtworks","followers_url":"https://api.github.com/users/thoughtworks/followers","following_url":"https://api.github.com/users/thoughtworks/following{/other_user}","gists_url":"https://api.github.com/users/thoughtworks/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtworks/subscriptions","organizations_url":"https://api.github.com/users/thoughtworks/orgs","repos_url":"https://api.github.com/users/thoughtworks/repos","events_url":"https://api.github.com/users/thoughtworks/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtworks/received_events","type":"Organization","site_admin":false},"repo":{"id":41957628,"name":"activeadmin","full_name":"thoughtworks/activeadmin","owner":{"login":"thoughtworks","id":18878,"avatar_url":"https://avatars.githubusercontent.com/u/18878?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtworks","html_url":"https://github.com/thoughtworks","followers_url":"https://api.github.com/users/thoughtworks/followers","following_url":"https://api.github.com/users/thoughtworks/following{/other_user}","gists_url":"https://api.github.com/users/thoughtworks/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtworks/subscriptions","organizations_url":"https://api.github.com/users/thoughtworks/orgs","repos_url":"https://api.github.com/users/thoughtworks/repos","events_url":"https://api.github.com/users/thoughtworks/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtworks/activeadmin","description":"The administration framework for Ruby on Rails applications.","fork":true,"url":"https://api.github.com/repos/thoughtworks/activeadmin","forks_url":"https://api.github.com/repos/thoughtworks/activeadmin/forks","keys_url":"https://api.github.com/repos/thoughtworks/activeadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtworks/activeadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtworks/activeadmin/teams","hooks_url":"https://api.github.com/repos/thoughtworks/activeadmin/hooks","issue_events_url":"https://api.github.com/repos/thoughtworks/activeadmin/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtworks/activeadmin/events","assignees_url":"https://api.github.com/repos/thoughtworks/activeadmin/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtworks/activeadmin/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtworks/activeadmin/tags","blobs_url":"https://api.github.com/repos/thoughtworks/activeadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtworks/activeadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtworks/activeadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtworks/activeadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtworks/activeadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtworks/activeadmin/languages","stargazers_url":"https://api.github.com/repos/thoughtworks/activeadmin/stargazers","contributors_url":"https://api.github.com/repos/thoughtworks/activeadmin/contributors","subscribers_url":"https://api.github.com/repos/thoughtworks/activeadmin/subscribers","subscription_url":"https://api.github.com/repos/thoughtworks/activeadmin/subscription","commits_url":"https://api.github.com/repos/thoughtworks/activeadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtworks/activeadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtworks/activeadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtworks/activeadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/thoughtworks/activeadmin/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtworks/activeadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtworks/activeadmin/merges","archive_url":"https://api.github.com/repos/thoughtworks/activeadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtworks/activeadmin/downloads","issues_url":"https://api.github.com/repos/thoughtworks/activeadmin/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtworks/activeadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtworks/activeadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtworks/activeadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtworks/activeadmin/labels{/name}","releases_url":"https://api.github.com/repos/thoughtworks/activeadmin/releases{/id}","created_at":"2015-09-05T10:49:45Z","updated_at":"2015-09-05T10:49:47Z","pushed_at":"2015-09-05T14:05:31Z","git_url":"git://github.com/thoughtworks/activeadmin.git","ssh_url":"git@github.com:thoughtworks/activeadmin.git","clone_url":"https://github.com/thoughtworks/activeadmin.git","svn_url":"https://github.com/thoughtworks/activeadmin","homepage":"activeadmin.info","size":19637,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"activeadmin:master","ref":"master","sha":"a5a53c3f2b8fdfd2605575b62b158318f7651f46","user":{"login":"activeadmin","id":814570,"avatar_url":"https://avatars.githubusercontent.com/u/814570?v=3","gravatar_id":"","url":"https://api.github.com/users/activeadmin","html_url":"https://github.com/activeadmin","followers_url":"https://api.github.com/users/activeadmin/followers","following_url":"https://api.github.com/users/activeadmin/following{/other_user}","gists_url":"https://api.github.com/users/activeadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/activeadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activeadmin/subscriptions","organizations_url":"https://api.github.com/users/activeadmin/orgs","repos_url":"https://api.github.com/users/activeadmin/repos","events_url":"https://api.github.com/users/activeadmin/events{/privacy}","received_events_url":"https://api.github.com/users/activeadmin/received_events","type":"Organization","site_admin":false},"repo":{"id":611921,"name":"activeadmin","full_name":"activeadmin/activeadmin","owner":{"login":"activeadmin","id":814570,"avatar_url":"https://avatars.githubusercontent.com/u/814570?v=3","gravatar_id":"","url":"https://api.github.com/users/activeadmin","html_url":"https://github.com/activeadmin","followers_url":"https://api.github.com/users/activeadmin/followers","following_url":"https://api.github.com/users/activeadmin/following{/other_user}","gists_url":"https://api.github.com/users/activeadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/activeadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activeadmin/subscriptions","organizations_url":"https://api.github.com/users/activeadmin/orgs","repos_url":"https://api.github.com/users/activeadmin/repos","events_url":"https://api.github.com/users/activeadmin/events{/privacy}","received_events_url":"https://api.github.com/users/activeadmin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/activeadmin/activeadmin","description":"The administration framework for Ruby on Rails applications.","fork":false,"url":"https://api.github.com/repos/activeadmin/activeadmin","forks_url":"https://api.github.com/repos/activeadmin/activeadmin/forks","keys_url":"https://api.github.com/repos/activeadmin/activeadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/activeadmin/activeadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/activeadmin/activeadmin/teams","hooks_url":"https://api.github.com/repos/activeadmin/activeadmin/hooks","issue_events_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/events{/number}","events_url":"https://api.github.com/repos/activeadmin/activeadmin/events","assignees_url":"https://api.github.com/repos/activeadmin/activeadmin/assignees{/user}","branches_url":"https://api.github.com/repos/activeadmin/activeadmin/branches{/branch}","tags_url":"https://api.github.com/repos/activeadmin/activeadmin/tags","blobs_url":"https://api.github.com/repos/activeadmin/activeadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/activeadmin/activeadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/activeadmin/activeadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/activeadmin/activeadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/activeadmin/activeadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/activeadmin/activeadmin/languages","stargazers_url":"https://api.github.com/repos/activeadmin/activeadmin/stargazers","contributors_url":"https://api.github.com/repos/activeadmin/activeadmin/contributors","subscribers_url":"https://api.github.com/repos/activeadmin/activeadmin/subscribers","subscription_url":"https://api.github.com/repos/activeadmin/activeadmin/subscription","commits_url":"https://api.github.com/repos/activeadmin/activeadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/activeadmin/activeadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/activeadmin/activeadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/activeadmin/activeadmin/contents/{+path}","compare_url":"https://api.github.com/repos/activeadmin/activeadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/activeadmin/activeadmin/merges","archive_url":"https://api.github.com/repos/activeadmin/activeadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/activeadmin/activeadmin/downloads","issues_url":"https://api.github.com/repos/activeadmin/activeadmin/issues{/number}","pulls_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/activeadmin/activeadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/activeadmin/activeadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/activeadmin/activeadmin/labels{/name}","releases_url":"https://api.github.com/repos/activeadmin/activeadmin/releases{/id}","created_at":"2010-04-15T14:26:03Z","updated_at":"2015-09-03T15:27:50Z","pushed_at":"2015-09-05T14:05:47Z","git_url":"git://github.com/activeadmin/activeadmin.git","ssh_url":"git@github.com:activeadmin/activeadmin.git","clone_url":"https://github.com/activeadmin/activeadmin.git","svn_url":"https://github.com/activeadmin/activeadmin","homepage":"activeadmin.info","size":19637,"stargazers_count":6172,"watchers_count":6172,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2208,"mirror_url":null,"open_issues_count":221,"forks":2208,"open_issues":221,"watchers":6172,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/4114"},"html":{"href":"https://github.com/activeadmin/activeadmin/pull/4114"},"issue":{"href":"https://api.github.com/repos/activeadmin/activeadmin/issues/4114"},"comments":{"href":"https://api.github.com/repos/activeadmin/activeadmin/issues/4114/comments"},"review_comments":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/4114/comments"},"review_comment":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/4114/commits"},"statuses":{"href":"https://api.github.com/repos/activeadmin/activeadmin/statuses/d11c7e432e2ab45718e01cd6737a7028e5730791"}}}}