{"action":"opened","number":4780,"pull_request":{"url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/4780","id":49182137,"html_url":"https://github.com/angular-ui/bootstrap/pull/4780","diff_url":"https://github.com/angular-ui/bootstrap/pull/4780.diff","patch_url":"https://github.com/angular-ui/bootstrap/pull/4780.patch","issue_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/4780","number":4780,"state":"open","locked":false,"title":"test(position): add more tests","user":{"login":"Foxandxss","id":1087957,"avatar_url":"https://avatars.githubusercontent.com/u/1087957?v=3","gravatar_id":"","url":"https://api.github.com/users/Foxandxss","html_url":"https://github.com/Foxandxss","followers_url":"https://api.github.com/users/Foxandxss/followers","following_url":"https://api.github.com/users/Foxandxss/following{/other_user}","gists_url":"https://api.github.com/users/Foxandxss/gists{/gist_id}","starred_url":"https://api.github.com/users/Foxandxss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Foxandxss/subscriptions","organizations_url":"https://api.github.com/users/Foxandxss/orgs","repos_url":"https://api.github.com/users/Foxandxss/repos","events_url":"https://api.github.com/users/Foxandxss/events{/privacy}","received_events_url":"https://api.github.com/users/Foxandxss/received_events","type":"User","site_admin":false},"body":"Sadly not enough. For the `offset` ones I would love to test how it applies window's offsets, but mocking window is a real pain, it starts breaking other tests and you need to mock lot of it.\r\n\r\nWould be good if jasmine were able to spy on variables returning a different value, but not possible.","created_at":"2015-10-29T18:40:07Z","updated_at":"2015-10-29T18:40:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/4780/commits","review_comments_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/4780/comments","review_comment_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/4780/comments","statuses_url":"https://api.github.com/repos/angular-ui/bootstrap/statuses/17ada5585e1e5f0f8c27d19ceb38c5954ad56b98","head":{"label":"Foxandxss:test/position","ref":"test/position","sha":"17ada5585e1e5f0f8c27d19ceb38c5954ad56b98","user":{"login":"Foxandxss","id":1087957,"avatar_url":"https://avatars.githubusercontent.com/u/1087957?v=3","gravatar_id":"","url":"https://api.github.com/users/Foxandxss","html_url":"https://github.com/Foxandxss","followers_url":"https://api.github.com/users/Foxandxss/followers","following_url":"https://api.github.com/users/Foxandxss/following{/other_user}","gists_url":"https://api.github.com/users/Foxandxss/gists{/gist_id}","starred_url":"https://api.github.com/users/Foxandxss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Foxandxss/subscriptions","organizations_url":"https://api.github.com/users/Foxandxss/orgs","repos_url":"https://api.github.com/users/Foxandxss/repos","events_url":"https://api.github.com/users/Foxandxss/events{/privacy}","received_events_url":"https://api.github.com/users/Foxandxss/received_events","type":"User","site_admin":false},"repo":{"id":15526704,"name":"bootstrap","full_name":"Foxandxss/bootstrap","owner":{"login":"Foxandxss","id":1087957,"avatar_url":"https://avatars.githubusercontent.com/u/1087957?v=3","gravatar_id":"","url":"https://api.github.com/users/Foxandxss","html_url":"https://github.com/Foxandxss","followers_url":"https://api.github.com/users/Foxandxss/followers","following_url":"https://api.github.com/users/Foxandxss/following{/other_user}","gists_url":"https://api.github.com/users/Foxandxss/gists{/gist_id}","starred_url":"https://api.github.com/users/Foxandxss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Foxandxss/subscriptions","organizations_url":"https://api.github.com/users/Foxandxss/orgs","repos_url":"https://api.github.com/users/Foxandxss/repos","events_url":"https://api.github.com/users/Foxandxss/events{/privacy}","received_events_url":"https://api.github.com/users/Foxandxss/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Foxandxss/bootstrap","description":"Native AngularJS (Angular) directives for Twitter's Bootstrap. Small footprint (5kB gzipped!), no 3rd party JS dependencies (jQuery, bootstrap JS) required!","fork":true,"url":"https://api.github.com/repos/Foxandxss/bootstrap","forks_url":"https://api.github.com/repos/Foxandxss/bootstrap/forks","keys_url":"https://api.github.com/repos/Foxandxss/bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Foxandxss/bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Foxandxss/bootstrap/teams","hooks_url":"https://api.github.com/repos/Foxandxss/bootstrap/hooks","issue_events_url":"https://api.github.com/repos/Foxandxss/bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/Foxandxss/bootstrap/events","assignees_url":"https://api.github.com/repos/Foxandxss/bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/Foxandxss/bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/Foxandxss/bootstrap/tags","blobs_url":"https://api.github.com/repos/Foxandxss/bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Foxandxss/bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Foxandxss/bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/Foxandxss/bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Foxandxss/bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/Foxandxss/bootstrap/languages","stargazers_url":"https://api.github.com/repos/Foxandxss/bootstrap/stargazers","contributors_url":"https://api.github.com/repos/Foxandxss/bootstrap/contributors","subscribers_url":"https://api.github.com/repos/Foxandxss/bootstrap/subscribers","subscription_url":"https://api.github.com/repos/Foxandxss/bootstrap/subscription","commits_url":"https://api.github.com/repos/Foxandxss/bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/Foxandxss/bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/Foxandxss/bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/Foxandxss/bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/Foxandxss/bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/Foxandxss/bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Foxandxss/bootstrap/merges","archive_url":"https://api.github.com/repos/Foxandxss/bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Foxandxss/bootstrap/downloads","issues_url":"https://api.github.com/repos/Foxandxss/bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/Foxandxss/bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/Foxandxss/bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/Foxandxss/bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Foxandxss/bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/Foxandxss/bootstrap/releases{/id}","created_at":"2013-12-30T11:43:00Z","updated_at":"2015-04-02T14:27:31Z","pushed_at":"2015-10-29T18:38:01Z","git_url":"git://github.com/Foxandxss/bootstrap.git","ssh_url":"git@github.com:Foxandxss/bootstrap.git","clone_url":"https://github.com/Foxandxss/bootstrap.git","svn_url":"https://github.com/Foxandxss/bootstrap","homepage":"http://angular-ui.github.io/bootstrap/","size":5408,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular-ui:master","ref":"master","sha":"09ad740434d27daa59781cb40eda859e94d094e6","user":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":6094683,"name":"bootstrap","full_name":"angular-ui/bootstrap","owner":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular-ui/bootstrap","description":"Native AngularJS (Angular) directives for Bootstrap. Smaller footprint (20kB gzipped), no 3rd party JS dependencies (jQuery, bootstrap JS) required. Please read the README.md file before submitting an issue!","fork":false,"url":"https://api.github.com/repos/angular-ui/bootstrap","forks_url":"https://api.github.com/repos/angular-ui/bootstrap/forks","keys_url":"https://api.github.com/repos/angular-ui/bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular-ui/bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular-ui/bootstrap/teams","hooks_url":"https://api.github.com/repos/angular-ui/bootstrap/hooks","issue_events_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/angular-ui/bootstrap/events","assignees_url":"https://api.github.com/repos/angular-ui/bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/angular-ui/bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/angular-ui/bootstrap/tags","blobs_url":"https://api.github.com/repos/angular-ui/bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular-ui/bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular-ui/bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular-ui/bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular-ui/bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/angular-ui/bootstrap/languages","stargazers_url":"https://api.github.com/repos/angular-ui/bootstrap/stargazers","contributors_url":"https://api.github.com/repos/angular-ui/bootstrap/contributors","subscribers_url":"https://api.github.com/repos/angular-ui/bootstrap/subscribers","subscription_url":"https://api.github.com/repos/angular-ui/bootstrap/subscription","commits_url":"https://api.github.com/repos/angular-ui/bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular-ui/bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular-ui/bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular-ui/bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/angular-ui/bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular-ui/bootstrap/merges","archive_url":"https://api.github.com/repos/angular-ui/bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular-ui/bootstrap/downloads","issues_url":"https://api.github.com/repos/angular-ui/bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/angular-ui/bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/angular-ui/bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular-ui/bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/angular-ui/bootstrap/releases{/id}","created_at":"2012-10-05T18:27:01Z","updated_at":"2015-10-29T16:11:42Z","pushed_at":"2015-10-29T16:09:43Z","git_url":"git://github.com/angular-ui/bootstrap.git","ssh_url":"git@github.com:angular-ui/bootstrap.git","clone_url":"https://github.com/angular-ui/bootstrap.git","svn_url":"https://github.com/angular-ui/bootstrap","homepage":"http://angular-ui.github.io/bootstrap/","size":28115,"stargazers_count":10590,"watchers_count":10590,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5509,"mirror_url":null,"open_issues_count":242,"forks":5509,"open_issues":242,"watchers":10590,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/4780"},"html":{"href":"https://github.com/angular-ui/bootstrap/pull/4780"},"issue":{"href":"https://api.github.com/repos/angular-ui/bootstrap/issues/4780"},"comments":{"href":"https://api.github.com/repos/angular-ui/bootstrap/issues/4780/comments"},"review_comments":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/4780/comments"},"review_comment":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/4780/commits"},"statuses":{"href":"https://api.github.com/repos/angular-ui/bootstrap/statuses/17ada5585e1e5f0f8c27d19ceb38c5954ad56b98"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":165,"deletions":0,"changed_files":1}}