{"action":"created","issue":{"url":"https://api.github.com/repos/sqlboy/fileseq/issues/25","labels_url":"https://api.github.com/repos/sqlboy/fileseq/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/sqlboy/fileseq/issues/25/comments","events_url":"https://api.github.com/repos/sqlboy/fileseq/issues/25/events","html_url":"https://github.com/sqlboy/fileseq/issues/25","id":69743199,"number":25,"title":"findSequencesOnDisk() now breaks with non-sequence files mixed in same directory","user":{"login":"justinfx","id":282566,"avatar_url":"https://avatars.githubusercontent.com/u/282566?v=3","gravatar_id":"","url":"https://api.github.com/users/justinfx","html_url":"https://github.com/justinfx","followers_url":"https://api.github.com/users/justinfx/followers","following_url":"https://api.github.com/users/justinfx/following{/other_user}","gists_url":"https://api.github.com/users/justinfx/gists{/gist_id}","starred_url":"https://api.github.com/users/justinfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinfx/subscriptions","organizations_url":"https://api.github.com/users/justinfx/orgs","repos_url":"https://api.github.com/users/justinfx/repos","events_url":"https://api.github.com/users/justinfx/events{/privacy}","received_events_url":"https://api.github.com/users/justinfx/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/sqlboy/fileseq/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-04-21T04:49:46Z","updated_at":"2015-04-21T22:05:14Z","closed_at":null,"body":"Reported by @matthewkapfhammer \r\n\r\nReproduction:\r\n\r\n```\r\ntest/\r\n    file.json\r\n    seq.0001.ext\r\n    seq.0002.ext\r\n```\r\n\r\n```python\r\n$ fileseq.findSequencesOnDisk(\"test\")\r\nValueError: invalid literal for int() with base 10: ''\r\n```\r\n\r\nThe problem is that because the DISK_RE pattern was recently updated, and there aren't adequate tests for `findSequencesOnDisk`, an unchecked frames list containing an empty string is being returned and tries to get converted into an int. Need to skip these cases in the loop.\r\n"},"comment":{"url":"https://api.github.com/repos/sqlboy/fileseq/issues/comments/94956681","html_url":"https://github.com/sqlboy/fileseq/issues/25#issuecomment-94956681","issue_url":"https://api.github.com/repos/sqlboy/fileseq/issues/25","id":94956681,"user":{"login":"michaelmovies","id":640167,"avatar_url":"https://avatars.githubusercontent.com/u/640167?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelmovies","html_url":"https://github.com/michaelmovies","followers_url":"https://api.github.com/users/michaelmovies/followers","following_url":"https://api.github.com/users/michaelmovies/following{/other_user}","gists_url":"https://api.github.com/users/michaelmovies/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelmovies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelmovies/subscriptions","organizations_url":"https://api.github.com/users/michaelmovies/orgs","repos_url":"https://api.github.com/users/michaelmovies/repos","events_url":"https://api.github.com/users/michaelmovies/events{/privacy}","received_events_url":"https://api.github.com/users/michaelmovies/received_events","type":"User","site_admin":false},"created_at":"2015-04-21T22:05:14Z","updated_at":"2015-04-21T22:05:14Z","body":"@justinfx I've rebased from yours and added some new tests to show the issue, plus committed my fix back into my branch.\r\n\r\nThe main change is to fix an issue that caused findSequencesOnDisk to fail with a ValueError if a name had mixed dashes and numbers (ie /file4-4.exr).  That's existed since at least 0.5.1.\r\n\r\n[current diff](https://github.com/sqlboy/fileseq/compare/find_sequences_issue_25_justinfx...find_sequences_issue_25?diff=unified&name=find_sequences_issue_25)"}}