{"action":"created","comment":{"url":"https://api.github.com/repos/django/django/pulls/comments/35528869","id":35528869,"diff_hunk":"@@ -108,15 +108,21 @@ def __init__(self, language):\n         self.__to_language = to_language(language)\n         self.__locale = to_locale(language)\n \n+        # Gets the list of additional domain names to search for.\n+        # By default the only (and unremovable) one is 'django'.\n+        domains = ['django']\n+        if settings.LOCALE_FILENAMES:\n+            domains += settings.LOCALE_FILENAMES","path":"django/utils/translation/trans_real.py","position":8,"original_position":8,"commit_id":"f4b2aa00370ec77f4d2032ed4ba9f608a82ce906","original_commit_id":"f4b2aa00370ec77f4d2032ed4ba9f608a82ce906","user":{"login":"charettes","id":9293,"avatar_url":"https://avatars.githubusercontent.com/u/9293?v=3","gravatar_id":"","url":"https://api.github.com/users/charettes","html_url":"https://github.com/charettes","followers_url":"https://api.github.com/users/charettes/followers","following_url":"https://api.github.com/users/charettes/following{/other_user}","gists_url":"https://api.github.com/users/charettes/gists{/gist_id}","starred_url":"https://api.github.com/users/charettes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charettes/subscriptions","organizations_url":"https://api.github.com/users/charettes/orgs","repos_url":"https://api.github.com/users/charettes/repos","events_url":"https://api.github.com/users/charettes/events{/privacy}","received_events_url":"https://api.github.com/users/charettes/received_events","type":"User","site_admin":false},"body":"Since `LOCALE_FILENAMES` defaults to an empty list I'd suggest you make `domains` unconditional append it to `['django']`. ","created_at":"2015-07-27T12:11:24Z","updated_at":"2015-07-27T12:11:24Z","html_url":"https://github.com/django/django/pull/5053#discussion_r35528869","pull_request_url":"https://api.github.com/repos/django/django/pulls/5053","_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/comments/35528869"},"html":{"href":"https://github.com/django/django/pull/5053#discussion_r35528869"},"pull_request":{"href":"https://api.github.com/repos/django/django/pulls/5053"}}},"pull_request":{"url":"https://api.github.com/repos/django/django/pulls/5053","id":40896327,"html_url":"https://github.com/django/django/pull/5053","diff_url":"https://github.com/django/django/pull/5053.diff","patch_url":"https://github.com/django/django/pull/5053.patch","issue_url":"https://api.github.com/repos/django/django/issues/5053","number":5053,"state":"open","locked":false,"title":"Fixed #6376 -- Allowed usage of custom gettext domains","user":{"login":"LiquidPL","id":991831,"avatar_url":"https://avatars.githubusercontent.com/u/991831?v=3","gravatar_id":"","url":"https://api.github.com/users/LiquidPL","html_url":"https://github.com/LiquidPL","followers_url":"https://api.github.com/users/LiquidPL/followers","following_url":"https://api.github.com/users/LiquidPL/following{/other_user}","gists_url":"https://api.github.com/users/LiquidPL/gists{/gist_id}","starred_url":"https://api.github.com/users/LiquidPL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiquidPL/subscriptions","organizations_url":"https://api.github.com/users/LiquidPL/orgs","repos_url":"https://api.github.com/users/LiquidPL/repos","events_url":"https://api.github.com/users/LiquidPL/events{/privacy}","received_events_url":"https://api.github.com/users/LiquidPL/received_events","type":"User","site_admin":false},"body":"Trac ticket: [6376](https://code.djangoproject.com/ticket/6376)\r\n\r\nThe locale loading system was written in such a way it only loaded locale files\r\nwith names 'django'. Modified the process, so the developers can now provide\r\nadditional locale filenames using settings.LOCALE_FILENAMES. Updated documentation\r\nto reflect the added changes.","created_at":"2015-07-27T12:05:47Z","updated_at":"2015-07-27T12:11:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f68592ca5d68dc9bf9c97b80338657306635c8e6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/django/django/pulls/5053/commits","review_comments_url":"https://api.github.com/repos/django/django/pulls/5053/comments","review_comment_url":"https://api.github.com/repos/django/django/pulls/comments{/number}","comments_url":"https://api.github.com/repos/django/django/issues/5053/comments","statuses_url":"https://api.github.com/repos/django/django/statuses/f4b2aa00370ec77f4d2032ed4ba9f608a82ce906","head":{"label":"LiquidPL:ticket_6376","ref":"ticket_6376","sha":"f4b2aa00370ec77f4d2032ed4ba9f608a82ce906","user":{"login":"LiquidPL","id":991831,"avatar_url":"https://avatars.githubusercontent.com/u/991831?v=3","gravatar_id":"","url":"https://api.github.com/users/LiquidPL","html_url":"https://github.com/LiquidPL","followers_url":"https://api.github.com/users/LiquidPL/followers","following_url":"https://api.github.com/users/LiquidPL/following{/other_user}","gists_url":"https://api.github.com/users/LiquidPL/gists{/gist_id}","starred_url":"https://api.github.com/users/LiquidPL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiquidPL/subscriptions","organizations_url":"https://api.github.com/users/LiquidPL/orgs","repos_url":"https://api.github.com/users/LiquidPL/repos","events_url":"https://api.github.com/users/LiquidPL/events{/privacy}","received_events_url":"https://api.github.com/users/LiquidPL/received_events","type":"User","site_admin":false},"repo":{"id":39685628,"name":"django","full_name":"LiquidPL/django","owner":{"login":"LiquidPL","id":991831,"avatar_url":"https://avatars.githubusercontent.com/u/991831?v=3","gravatar_id":"","url":"https://api.github.com/users/LiquidPL","html_url":"https://github.com/LiquidPL","followers_url":"https://api.github.com/users/LiquidPL/followers","following_url":"https://api.github.com/users/LiquidPL/following{/other_user}","gists_url":"https://api.github.com/users/LiquidPL/gists{/gist_id}","starred_url":"https://api.github.com/users/LiquidPL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiquidPL/subscriptions","organizations_url":"https://api.github.com/users/LiquidPL/orgs","repos_url":"https://api.github.com/users/LiquidPL/repos","events_url":"https://api.github.com/users/LiquidPL/events{/privacy}","received_events_url":"https://api.github.com/users/LiquidPL/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LiquidPL/django","description":"The Web framework for perfectionists with deadlines.","fork":true,"url":"https://api.github.com/repos/LiquidPL/django","forks_url":"https://api.github.com/repos/LiquidPL/django/forks","keys_url":"https://api.github.com/repos/LiquidPL/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LiquidPL/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LiquidPL/django/teams","hooks_url":"https://api.github.com/repos/LiquidPL/django/hooks","issue_events_url":"https://api.github.com/repos/LiquidPL/django/issues/events{/number}","events_url":"https://api.github.com/repos/LiquidPL/django/events","assignees_url":"https://api.github.com/repos/LiquidPL/django/assignees{/user}","branches_url":"https://api.github.com/repos/LiquidPL/django/branches{/branch}","tags_url":"https://api.github.com/repos/LiquidPL/django/tags","blobs_url":"https://api.github.com/repos/LiquidPL/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LiquidPL/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LiquidPL/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/LiquidPL/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LiquidPL/django/statuses/{sha}","languages_url":"https://api.github.com/repos/LiquidPL/django/languages","stargazers_url":"https://api.github.com/repos/LiquidPL/django/stargazers","contributors_url":"https://api.github.com/repos/LiquidPL/django/contributors","subscribers_url":"https://api.github.com/repos/LiquidPL/django/subscribers","subscription_url":"https://api.github.com/repos/LiquidPL/django/subscription","commits_url":"https://api.github.com/repos/LiquidPL/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/LiquidPL/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/LiquidPL/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/LiquidPL/django/issues/comments{/number}","contents_url":"https://api.github.com/repos/LiquidPL/django/contents/{+path}","compare_url":"https://api.github.com/repos/LiquidPL/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LiquidPL/django/merges","archive_url":"https://api.github.com/repos/LiquidPL/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LiquidPL/django/downloads","issues_url":"https://api.github.com/repos/LiquidPL/django/issues{/number}","pulls_url":"https://api.github.com/repos/LiquidPL/django/pulls{/number}","milestones_url":"https://api.github.com/repos/LiquidPL/django/milestones{/number}","notifications_url":"https://api.github.com/repos/LiquidPL/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LiquidPL/django/labels{/name}","releases_url":"https://api.github.com/repos/LiquidPL/django/releases{/id}","created_at":"2015-07-25T13:09:18Z","updated_at":"2015-07-25T13:09:33Z","pushed_at":"2015-07-27T11:53:33Z","git_url":"git://github.com/LiquidPL/django.git","ssh_url":"git@github.com:LiquidPL/django.git","clone_url":"https://github.com/LiquidPL/django.git","svn_url":"https://github.com/LiquidPL/django","homepage":"https://www.djangoproject.com/","size":141939,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"django:master","ref":"master","sha":"6024fd5dc2022f3724ea6440c319440d457a7366","user":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"repo":{"id":4164482,"name":"django","full_name":"django/django","owner":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/django/django","description":"The Web framework for perfectionists with deadlines.","fork":false,"url":"https://api.github.com/repos/django/django","forks_url":"https://api.github.com/repos/django/django/forks","keys_url":"https://api.github.com/repos/django/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/django/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/django/django/teams","hooks_url":"https://api.github.com/repos/django/django/hooks","issue_events_url":"https://api.github.com/repos/django/django/issues/events{/number}","events_url":"https://api.github.com/repos/django/django/events","assignees_url":"https://api.github.com/repos/django/django/assignees{/user}","branches_url":"https://api.github.com/repos/django/django/branches{/branch}","tags_url":"https://api.github.com/repos/django/django/tags","blobs_url":"https://api.github.com/repos/django/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/django/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/django/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/django/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/django/django/statuses/{sha}","languages_url":"https://api.github.com/repos/django/django/languages","stargazers_url":"https://api.github.com/repos/django/django/stargazers","contributors_url":"https://api.github.com/repos/django/django/contributors","subscribers_url":"https://api.github.com/repos/django/django/subscribers","subscription_url":"https://api.github.com/repos/django/django/subscription","commits_url":"https://api.github.com/repos/django/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/django/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/django/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/django/django/issues/comments{/number}","contents_url":"https://api.github.com/repos/django/django/contents/{+path}","compare_url":"https://api.github.com/repos/django/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/django/django/merges","archive_url":"https://api.github.com/repos/django/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/django/django/downloads","issues_url":"https://api.github.com/repos/django/django/issues{/number}","pulls_url":"https://api.github.com/repos/django/django/pulls{/number}","milestones_url":"https://api.github.com/repos/django/django/milestones{/number}","notifications_url":"https://api.github.com/repos/django/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/django/django/labels{/name}","releases_url":"https://api.github.com/repos/django/django/releases{/id}","created_at":"2012-04-28T02:47:18Z","updated_at":"2015-07-27T11:08:34Z","pushed_at":"2015-07-27T12:05:48Z","git_url":"git://github.com/django/django.git","ssh_url":"git@github.com:django/django.git","clone_url":"https://github.com/django/django.git","svn_url":"https://github.com/django/django","homepage":"https://www.djangoproject.com/","size":304009,"stargazers_count":15283,"watchers_count":15283,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6115,"mirror_url":null,"open_issues_count":79,"forks":6115,"open_issues":79,"watchers":15283,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/5053"},"html":{"href":"https://github.com/django/django/pull/5053"},"issue":{"href":"https://api.github.com/repos/django/django/issues/5053"},"comments":{"href":"https://api.github.com/repos/django/django/issues/5053/comments"},"review_comments":{"href":"https://api.github.com/repos/django/django/pulls/5053/comments"},"review_comment":{"href":"https://api.github.com/repos/django/django/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/django/django/pulls/5053/commits"},"statuses":{"href":"https://api.github.com/repos/django/django/statuses/f4b2aa00370ec77f4d2032ed4ba9f608a82ce906"}}}}