{"action":"created","issue":{"url":"https://api.github.com/repos/urho3d/Urho3D/issues/936","labels_url":"https://api.github.com/repos/urho3d/Urho3D/issues/936/labels{/name}","comments_url":"https://api.github.com/repos/urho3d/Urho3D/issues/936/comments","events_url":"https://api.github.com/repos/urho3d/Urho3D/issues/936/events","html_url":"https://github.com/urho3d/Urho3D/pull/936","id":110714415,"number":936,"title":"approx_quat_slerp","user":{"login":"juj","id":225351,"avatar_url":"https://avatars.githubusercontent.com/u/225351?v=3","gravatar_id":"","url":"https://api.github.com/users/juj","html_url":"https://github.com/juj","followers_url":"https://api.github.com/users/juj/followers","following_url":"https://api.github.com/users/juj/following{/other_user}","gists_url":"https://api.github.com/users/juj/gists{/gist_id}","starred_url":"https://api.github.com/users/juj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juj/subscriptions","organizations_url":"https://api.github.com/users/juj/orgs","repos_url":"https://api.github.com/users/juj/repos","events_url":"https://api.github.com/users/juj/events{/privacy}","received_events_url":"https://api.github.com/users/juj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-10-09T18:36:30Z","updated_at":"2015-10-09T20:39:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/urho3d/Urho3D/pulls/936","html_url":"https://github.com/urho3d/Urho3D/pull/936","diff_url":"https://github.com/urho3d/Urho3D/pull/936.diff","patch_url":"https://github.com/urho3d/Urho3D/pull/936.patch"},"body":"Optimize Quaternion::Slerp() to remove the costly trigonometric functions and replace them by approximations instead. The approximations have been profiled to generate a maximum interpolation error of 0.38 degrees (see test Quat_Slerp_precision in MathGeoLib). In native 64bit Windows 8.1 VS2015 builds, testing in 06_SkeletalAnimation sample with 2000 Jacks, the time taken in Quaternion::Slerp() is reduced by -17.4%, and in Emscripten build of the same sample running in Firefox 41, the time taken by Quaternion::Slerp() is reduced by -44.7%. Closes #914."},"comment":{"url":"https://api.github.com/repos/urho3d/Urho3D/issues/comments/146981063","html_url":"https://github.com/urho3d/Urho3D/pull/936#issuecomment-146981063","issue_url":"https://api.github.com/repos/urho3d/Urho3D/issues/936","id":146981063,"user":{"login":"juj","id":225351,"avatar_url":"https://avatars.githubusercontent.com/u/225351?v=3","gravatar_id":"","url":"https://api.github.com/users/juj","html_url":"https://github.com/juj","followers_url":"https://api.github.com/users/juj/followers","following_url":"https://api.github.com/users/juj/following{/other_user}","gists_url":"https://api.github.com/users/juj/gists{/gist_id}","starred_url":"https://api.github.com/users/juj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juj/subscriptions","organizations_url":"https://api.github.com/users/juj/orgs","repos_url":"https://api.github.com/users/juj/repos","events_url":"https://api.github.com/users/juj/events{/privacy}","received_events_url":"https://api.github.com/users/juj/received_events","type":"User","site_admin":false},"created_at":"2015-10-09T20:39:57Z","updated_at":"2015-10-09T20:39:57Z","body":"Yeah, that sounds good. I was pondering whether to do this Emscripten only, since the performance impact is most in Emscripten side, but then thought to propose it unconditionally for determinism across platforms."}}