{"action":"created","comment":{"url":"https://api.github.com/repos/korsakow/korsakow-editor/pulls/comments/27356697","id":27356697,"diff_hunk":"@@ -158,31 +159,53 @@ public void run() {\n \t\t    }\r\n \t\t});\r\n \t\t\r\n+\t\ttry {\r\n+\t\t\tUIUtil.runUITaskNowThrow(new UIUtil.RunnableThrow() {\r\n+\t\t\t\tpublic void run() throws Throwable {\r\n+\t\t\t\t\tFile publicPluginsDir = PluginHelper.ensurePluginsDir();\r\n+\t\t\t\t\tgetLogger().info(\"Loading plugins from ...\" + publicPluginsDir.getPath());\r\n+\t\r\n+\t\t\t\t\tPluginManager pluginManager = PluginManagerFactory.createPluginManager();\r\n \r\n-\t\tUIUtil.runUITaskNowThrow(new UIUtil.RunnableThrow() {\r\n-\t\t\tpublic void run() throws Throwable {\r\n-\t\t\t\tFile pluginDir = PluginHelper.ensurePluginsDir();\r\n-\t\t\t\tgetLogger().info(\"Loading plugins from ...\" + pluginDir.getPath());\r\n-\r\n-\t\t\t\tPluginManager pluginManager = PluginManagerFactory.createPluginManager();\r\n-\t\t\t\tif (pluginDir.listFiles() != null) {\r\n-\t\t\t\t\tfor (File child : pluginDir.listFiles()) {\r\n-\t\t\t\t\t\tif (child.isFile()) {\r\n-\t\t\t\t\t\t\tgetLogger().info(String.format(\"Found possible plugin at: %s\", child.getPath()));\r\n-\t\t\t\t\t\t\tpluginManager.addPluginsFrom(child.toURI());\r\n+\t\t\t\t\ttry {\r\n+\t\t\t\t\t\tFile privatePluginsDir = ResourceManager.getResourceFile(\"plugins\");\r\n+\t\t\t\t\t\t\t\t\r\n+\t\t\t\t\t\tif (privatePluginsDir.listFiles() != null) {\r\n+\t\t\t\t\t\t\tfor (File child : privatePluginsDir.listFiles()) {\r\n+\t\t\t\t\t\t\t\tif (child.isFile()) {\r\n+\t\t\t\t\t\t\t\t\tgetLogger().info(String.format(\"Found possible plugin at: %s\", child.getPath()));\r\n+\t\t\t\t\t\t\t\t\tpluginManager.addPluginsFrom(child.toURI());\r\n+\t\t\t\t\t\t\t\t}\r\n+\t\t\t\t\t\t\t}\r\n \t\t\t\t\t\t}\r\n+\t\t\t\t\t} catch (Exception e) {\r\n+\t\t\t\t\t\tgetLogger().error(\"\", e);\r\n+\t\t\t\t\t}\r\n+\t\t\t\t\t\r\n+\t\t\t\t\ttry {\r\n+\t\t\t\t\t\tif (publicPluginsDir.listFiles() != null) {\r\n+\t\t\t\t\t\t\tfor (File child : publicPluginsDir.listFiles()) {\r\n+\t\t\t\t\t\t\t\tif (child.isFile()) {\r\n+\t\t\t\t\t\t\t\t\tgetLogger().info(String.format(\"Found possible plugin at: %s\", child.getPath()));\r\n+\t\t\t\t\t\t\t\t\tpluginManager.addPluginsFrom(child.toURI());\r\n+\t\t\t\t\t\t\t\t}\r\n+\t\t\t\t\t\t\t}\r\n+\t\t\t\t\t\t} \r\n+\t\t\t\t\t} catch(Exception e) {\r\n+\t\t\t\t\t\tgetLogger().error(\"\", e);\r\n+\t\t\t\t\t}\r\n+\t\t\t\t\t\r\n+\t\t\t\t\tPluginManagerUtil pluginUtil = new PluginManagerUtil(pluginManager);\r\n+\t\t\t\t\t\r\n+\t\t\t\t\tfor (KorsakowPlugin plugin : pluginUtil.getPlugins(KorsakowPlugin.class)) {\r\n+\t\t\t\t\t\tgetLogger().info(String.format(\"Installing Plugin: %s\", plugin.getName()));\r\n+\t\t\t\t\t\tPluginRegistry.get().register(plugin);\r\n \t\t\t\t\t}\r\n \t\t\t\t}\r\n-\t\t\t\t\r\n-\t\t\t\tPluginManagerUtil pluginUtil = new PluginManagerUtil(pluginManager);\r\n-\t\t\t\t\r\n-\t\t\t\tfor (ExportPlugin plugin : pluginUtil.getPlugins(ExportPlugin.class)) {\r\n-\t\t\t\t\tgetLogger().info(String.format(\"Installing Export Plugin: %s\", plugin.getName()));\r\n-\t\t\t\t\tPluginRegistry.get().register(plugin);\r\n-\t\t\t\t}\r\n-\t\t\t\t\r\n-\t\t\t}\r\n-\t\t});\r\n+\t\t\t});\r","path":"main/src/org/korsakow/ide/Main.java","position":86,"original_position":86,"commit_id":"4abf8bb1d0e188fdb29398c184cee0c522ddade2","original_commit_id":"4abf8bb1d0e188fdb29398c184cee0c522ddade2","user":{"login":"dreisch","id":4554651,"avatar_url":"https://avatars.githubusercontent.com/u/4554651?v=3","gravatar_id":"","url":"https://api.github.com/users/dreisch","html_url":"https://github.com/dreisch","followers_url":"https://api.github.com/users/dreisch/followers","following_url":"https://api.github.com/users/dreisch/following{/other_user}","gists_url":"https://api.github.com/users/dreisch/gists{/gist_id}","starred_url":"https://api.github.com/users/dreisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dreisch/subscriptions","organizations_url":"https://api.github.com/users/dreisch/orgs","repos_url":"https://api.github.com/users/dreisch/repos","events_url":"https://api.github.com/users/dreisch/events{/privacy}","received_events_url":"https://api.github.com/users/dreisch/received_events","type":"User","site_admin":false},"body":"This makes sense, plugins shouldn't prevent the app from running","created_at":"2015-03-29T17:38:27Z","updated_at":"2015-03-29T17:38:27Z","html_url":"https://github.com/korsakow/korsakow-editor/pull/55#discussion_r27356697","pull_request_url":"https://api.github.com/repos/korsakow/korsakow-editor/pulls/55","_links":{"self":{"href":"https://api.github.com/repos/korsakow/korsakow-editor/pulls/comments/27356697"},"html":{"href":"https://github.com/korsakow/korsakow-editor/pull/55#discussion_r27356697"},"pull_request":{"href":"https://api.github.com/repos/korsakow/korsakow-editor/pulls/55"}}},"pull_request":{"url":"https://api.github.com/repos/korsakow/korsakow-editor/pulls/55","id":30582895,"html_url":"https://github.com/korsakow/korsakow-editor/pull/55","diff_url":"https://github.com/korsakow/korsakow-editor/pull/55.diff","patch_url":"https://github.com/korsakow/korsakow-editor/pull/55.patch","issue_url":"https://api.github.com/repos/korsakow/korsakow-editor/issues/55","number":55,"state":"open","locked":false,"title":"Unified master","user":{"login":"phyrworks","id":1141270,"avatar_url":"https://avatars.githubusercontent.com/u/1141270?v=3","gravatar_id":"","url":"https://api.github.com/users/phyrworks","html_url":"https://github.com/phyrworks","followers_url":"https://api.github.com/users/phyrworks/followers","following_url":"https://api.github.com/users/phyrworks/following{/other_user}","gists_url":"https://api.github.com/users/phyrworks/gists{/gist_id}","starred_url":"https://api.github.com/users/phyrworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phyrworks/subscriptions","organizations_url":"https://api.github.com/users/phyrworks/orgs","repos_url":"https://api.github.com/users/phyrworks/repos","events_url":"https://api.github.com/users/phyrworks/events{/privacy}","received_events_url":"https://api.github.com/users/phyrworks/received_events","type":"User","site_admin":false},"body":"The \"Grand Unification\" version of the standard Korsakow IDE.","created_at":"2015-03-05T18:33:50Z","updated_at":"2015-03-29T17:38:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/korsakow/korsakow-editor/pulls/55/commits","review_comments_url":"https://api.github.com/repos/korsakow/korsakow-editor/pulls/55/comments","review_comment_url":"https://api.github.com/repos/korsakow/korsakow-editor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/korsakow/korsakow-editor/issues/55/comments","statuses_url":"https://api.github.com/repos/korsakow/korsakow-editor/statuses/4abf8bb1d0e188fdb29398c184cee0c522ddade2","head":{"label":"phyrworks:UnifiedMaster","ref":"UnifiedMaster","sha":"4abf8bb1d0e188fdb29398c184cee0c522ddade2","user":{"login":"phyrworks","id":1141270,"avatar_url":"https://avatars.githubusercontent.com/u/1141270?v=3","gravatar_id":"","url":"https://api.github.com/users/phyrworks","html_url":"https://github.com/phyrworks","followers_url":"https://api.github.com/users/phyrworks/followers","following_url":"https://api.github.com/users/phyrworks/following{/other_user}","gists_url":"https://api.github.com/users/phyrworks/gists{/gist_id}","starred_url":"https://api.github.com/users/phyrworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phyrworks/subscriptions","organizations_url":"https://api.github.com/users/phyrworks/orgs","repos_url":"https://api.github.com/users/phyrworks/repos","events_url":"https://api.github.com/users/phyrworks/events{/privacy}","received_events_url":"https://api.github.com/users/phyrworks/received_events","type":"User","site_admin":false},"repo":{"id":24160328,"name":"korsakow-editor","full_name":"phyrworks/korsakow-editor","owner":{"login":"phyrworks","id":1141270,"avatar_url":"https://avatars.githubusercontent.com/u/1141270?v=3","gravatar_id":"","url":"https://api.github.com/users/phyrworks","html_url":"https://github.com/phyrworks","followers_url":"https://api.github.com/users/phyrworks/followers","following_url":"https://api.github.com/users/phyrworks/following{/other_user}","gists_url":"https://api.github.com/users/phyrworks/gists{/gist_id}","starred_url":"https://api.github.com/users/phyrworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phyrworks/subscriptions","organizations_url":"https://api.github.com/users/phyrworks/orgs","repos_url":"https://api.github.com/users/phyrworks/repos","events_url":"https://api.github.com/users/phyrworks/events{/privacy}","received_events_url":"https://api.github.com/users/phyrworks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phyrworks/korsakow-editor","description":"","fork":true,"url":"https://api.github.com/repos/phyrworks/korsakow-editor","forks_url":"https://api.github.com/repos/phyrworks/korsakow-editor/forks","keys_url":"https://api.github.com/repos/phyrworks/korsakow-editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phyrworks/korsakow-editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phyrworks/korsakow-editor/teams","hooks_url":"https://api.github.com/repos/phyrworks/korsakow-editor/hooks","issue_events_url":"https://api.github.com/repos/phyrworks/korsakow-editor/issues/events{/number}","events_url":"https://api.github.com/repos/phyrworks/korsakow-editor/events","assignees_url":"https://api.github.com/repos/phyrworks/korsakow-editor/assignees{/user}","branches_url":"https://api.github.com/repos/phyrworks/korsakow-editor/branches{/branch}","tags_url":"https://api.github.com/repos/phyrworks/korsakow-editor/tags","blobs_url":"https://api.github.com/repos/phyrworks/korsakow-editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phyrworks/korsakow-editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phyrworks/korsakow-editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/phyrworks/korsakow-editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phyrworks/korsakow-editor/statuses/{sha}","languages_url":"https://api.github.com/repos/phyrworks/korsakow-editor/languages","stargazers_url":"https://api.github.com/repos/phyrworks/korsakow-editor/stargazers","contributors_url":"https://api.github.com/repos/phyrworks/korsakow-editor/contributors","subscribers_url":"https://api.github.com/repos/phyrworks/korsakow-editor/subscribers","subscription_url":"https://api.github.com/repos/phyrworks/korsakow-editor/subscription","commits_url":"https://api.github.com/repos/phyrworks/korsakow-editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/phyrworks/korsakow-editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/phyrworks/korsakow-editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/phyrworks/korsakow-editor/issues/comments{/number}","contents_url":"https://api.github.com/repos/phyrworks/korsakow-editor/contents/{+path}","compare_url":"https://api.github.com/repos/phyrworks/korsakow-editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phyrworks/korsakow-editor/merges","archive_url":"https://api.github.com/repos/phyrworks/korsakow-editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phyrworks/korsakow-editor/downloads","issues_url":"https://api.github.com/repos/phyrworks/korsakow-editor/issues{/number}","pulls_url":"https://api.github.com/repos/phyrworks/korsakow-editor/pulls{/number}","milestones_url":"https://api.github.com/repos/phyrworks/korsakow-editor/milestones{/number}","notifications_url":"https://api.github.com/repos/phyrworks/korsakow-editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phyrworks/korsakow-editor/labels{/name}","releases_url":"https://api.github.com/repos/phyrworks/korsakow-editor/releases{/id}","created_at":"2014-09-17T20:03:00Z","updated_at":"2015-03-03T17:01:37Z","pushed_at":"2015-03-05T18:32:28Z","git_url":"git://github.com/phyrworks/korsakow-editor.git","ssh_url":"git@github.com:phyrworks/korsakow-editor.git","clone_url":"https://github.com/phyrworks/korsakow-editor.git","svn_url":"https://github.com/phyrworks/korsakow-editor","homepage":null,"size":38368,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"korsakow:master","ref":"master","sha":"6825f7d8d04fa979c19b12c2fc1e2d40a42a84f4","user":{"login":"korsakow","id":4732909,"avatar_url":"https://avatars.githubusercontent.com/u/4732909?v=3","gravatar_id":"","url":"https://api.github.com/users/korsakow","html_url":"https://github.com/korsakow","followers_url":"https://api.github.com/users/korsakow/followers","following_url":"https://api.github.com/users/korsakow/following{/other_user}","gists_url":"https://api.github.com/users/korsakow/gists{/gist_id}","starred_url":"https://api.github.com/users/korsakow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/korsakow/subscriptions","organizations_url":"https://api.github.com/users/korsakow/orgs","repos_url":"https://api.github.com/users/korsakow/repos","events_url":"https://api.github.com/users/korsakow/events{/privacy}","received_events_url":"https://api.github.com/users/korsakow/received_events","type":"Organization","site_admin":false},"repo":{"id":10722674,"name":"korsakow-editor","full_name":"korsakow/korsakow-editor","owner":{"login":"korsakow","id":4732909,"avatar_url":"https://avatars.githubusercontent.com/u/4732909?v=3","gravatar_id":"","url":"https://api.github.com/users/korsakow","html_url":"https://github.com/korsakow","followers_url":"https://api.github.com/users/korsakow/followers","following_url":"https://api.github.com/users/korsakow/following{/other_user}","gists_url":"https://api.github.com/users/korsakow/gists{/gist_id}","starred_url":"https://api.github.com/users/korsakow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/korsakow/subscriptions","organizations_url":"https://api.github.com/users/korsakow/orgs","repos_url":"https://api.github.com/users/korsakow/repos","events_url":"https://api.github.com/users/korsakow/events{/privacy}","received_events_url":"https://api.github.com/users/korsakow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/korsakow/korsakow-editor","description":"","fork":false,"url":"https://api.github.com/repos/korsakow/korsakow-editor","forks_url":"https://api.github.com/repos/korsakow/korsakow-editor/forks","keys_url":"https://api.github.com/repos/korsakow/korsakow-editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/korsakow/korsakow-editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/korsakow/korsakow-editor/teams","hooks_url":"https://api.github.com/repos/korsakow/korsakow-editor/hooks","issue_events_url":"https://api.github.com/repos/korsakow/korsakow-editor/issues/events{/number}","events_url":"https://api.github.com/repos/korsakow/korsakow-editor/events","assignees_url":"https://api.github.com/repos/korsakow/korsakow-editor/assignees{/user}","branches_url":"https://api.github.com/repos/korsakow/korsakow-editor/branches{/branch}","tags_url":"https://api.github.com/repos/korsakow/korsakow-editor/tags","blobs_url":"https://api.github.com/repos/korsakow/korsakow-editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/korsakow/korsakow-editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/korsakow/korsakow-editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/korsakow/korsakow-editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/korsakow/korsakow-editor/statuses/{sha}","languages_url":"https://api.github.com/repos/korsakow/korsakow-editor/languages","stargazers_url":"https://api.github.com/repos/korsakow/korsakow-editor/stargazers","contributors_url":"https://api.github.com/repos/korsakow/korsakow-editor/contributors","subscribers_url":"https://api.github.com/repos/korsakow/korsakow-editor/subscribers","subscription_url":"https://api.github.com/repos/korsakow/korsakow-editor/subscription","commits_url":"https://api.github.com/repos/korsakow/korsakow-editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/korsakow/korsakow-editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/korsakow/korsakow-editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/korsakow/korsakow-editor/issues/comments{/number}","contents_url":"https://api.github.com/repos/korsakow/korsakow-editor/contents/{+path}","compare_url":"https://api.github.com/repos/korsakow/korsakow-editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/korsakow/korsakow-editor/merges","archive_url":"https://api.github.com/repos/korsakow/korsakow-editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/korsakow/korsakow-editor/downloads","issues_url":"https://api.github.com/repos/korsakow/korsakow-editor/issues{/number}","pulls_url":"https://api.github.com/repos/korsakow/korsakow-editor/pulls{/number}","milestones_url":"https://api.github.com/repos/korsakow/korsakow-editor/milestones{/number}","notifications_url":"https://api.github.com/repos/korsakow/korsakow-editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/korsakow/korsakow-editor/labels{/name}","releases_url":"https://api.github.com/repos/korsakow/korsakow-editor/releases{/id}","created_at":"2013-06-16T16:44:38Z","updated_at":"2015-02-04T01:10:33Z","pushed_at":"2015-02-04T01:10:32Z","git_url":"git://github.com/korsakow/korsakow-editor.git","ssh_url":"git@github.com:korsakow/korsakow-editor.git","clone_url":"https://github.com/korsakow/korsakow-editor.git","svn_url":"https://github.com/korsakow/korsakow-editor","homepage":null,"size":40503,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":7,"forks":8,"open_issues":7,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/korsakow/korsakow-editor/pulls/55"},"html":{"href":"https://github.com/korsakow/korsakow-editor/pull/55"},"issue":{"href":"https://api.github.com/repos/korsakow/korsakow-editor/issues/55"},"comments":{"href":"https://api.github.com/repos/korsakow/korsakow-editor/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/korsakow/korsakow-editor/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/korsakow/korsakow-editor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/korsakow/korsakow-editor/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/korsakow/korsakow-editor/statuses/4abf8bb1d0e188fdb29398c184cee0c522ddade2"}}}}