{"action":"created","issue":{"url":"https://api.github.com/repos/learningequality/ka-lite/issues/2905","labels_url":"https://api.github.com/repos/learningequality/ka-lite/issues/2905/labels{/name}","comments_url":"https://api.github.com/repos/learningequality/ka-lite/issues/2905/comments","events_url":"https://api.github.com/repos/learningequality/ka-lite/issues/2905/events","html_url":"https://github.com/learningequality/ka-lite/pull/2905","id":55692130,"number":2905,"title":"Khan exercise i18n","user":{"login":"rtibbles","id":1680573,"avatar_url":"https://avatars.githubusercontent.com/u/1680573?v=3","gravatar_id":"","url":"https://api.github.com/users/rtibbles","html_url":"https://github.com/rtibbles","followers_url":"https://api.github.com/users/rtibbles/followers","following_url":"https://api.github.com/users/rtibbles/following{/other_user}","gists_url":"https://api.github.com/users/rtibbles/gists{/gist_id}","starred_url":"https://api.github.com/users/rtibbles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtibbles/subscriptions","organizations_url":"https://api.github.com/users/rtibbles/orgs","repos_url":"https://api.github.com/users/rtibbles/repos","events_url":"https://api.github.com/users/rtibbles/events{/privacy}","received_events_url":"https://api.github.com/users/rtibbles/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/learningequality/ka-lite/labels/has%20PR","name":"has PR","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"aronasorman","id":191955,"avatar_url":"https://avatars.githubusercontent.com/u/191955?v=3","gravatar_id":"","url":"https://api.github.com/users/aronasorman","html_url":"https://github.com/aronasorman","followers_url":"https://api.github.com/users/aronasorman/followers","following_url":"https://api.github.com/users/aronasorman/following{/other_user}","gists_url":"https://api.github.com/users/aronasorman/gists{/gist_id}","starred_url":"https://api.github.com/users/aronasorman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aronasorman/subscriptions","organizations_url":"https://api.github.com/users/aronasorman/orgs","repos_url":"https://api.github.com/users/aronasorman/repos","events_url":"https://api.github.com/users/aronasorman/events{/privacy}","received_events_url":"https://api.github.com/users/aronasorman/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/learningequality/ka-lite/milestones/46","labels_url":"https://api.github.com/repos/learningequality/ka-lite/milestones/46/labels","id":934164,"number":46,"title":"0.13.x bugfixes","description":"","creator":{"login":"aronasorman","id":191955,"avatar_url":"https://avatars.githubusercontent.com/u/191955?v=3","gravatar_id":"","url":"https://api.github.com/users/aronasorman","html_url":"https://github.com/aronasorman","followers_url":"https://api.github.com/users/aronasorman/followers","following_url":"https://api.github.com/users/aronasorman/following{/other_user}","gists_url":"https://api.github.com/users/aronasorman/gists{/gist_id}","starred_url":"https://api.github.com/users/aronasorman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aronasorman/subscriptions","organizations_url":"https://api.github.com/users/aronasorman/orgs","repos_url":"https://api.github.com/users/aronasorman/repos","events_url":"https://api.github.com/users/aronasorman/events{/privacy}","received_events_url":"https://api.github.com/users/aronasorman/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":3,"state":"open","created_at":"2015-01-13T21:42:39Z","updated_at":"2015-01-29T17:17:12Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2015-01-27T23:38:12Z","updated_at":"2015-01-29T22:39:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/learningequality/ka-lite/pulls/2905","html_url":"https://github.com/learningequality/ka-lite/pull/2905","diff_url":"https://github.com/learningequality/ka-lite/pull/2905.diff","patch_url":"https://github.com/learningequality/ka-lite/pull/2905.patch"},"body":"Fixes #2904, and other i18n fixes.\r\n\r\nSummary of changes:\r\n* Moves unpack location of translated khan-exercises templates\r\n* Makes client side code actually look for translated template\r\n* Generates a unique topic_tree for each language\r\n* Translates coach report topic titles\r\n* Translates exercise titles and descriptions for client side display\r\n* Translates topic tree for video download screen\r\n\r\nThis is not quite ready to merge, as I have some questions about approach, @aronasorman:\r\nIs it efficient to be storing a separate topic tree in memory for each language?\r\n\r\nIf so, it would seem sensible to also do the translation for content_cache and exercise_cache inside get_content_cache and get_exercise_cache, so that whenever they are referenced elsewhere (such as in coach reports) they can also have translated data used on the client side (which does not currently happen)."},"comment":{"url":"https://api.github.com/repos/learningequality/ka-lite/issues/comments/72119022","html_url":"https://github.com/learningequality/ka-lite/pull/2905#issuecomment-72119022","issue_url":"https://api.github.com/repos/learningequality/ka-lite/issues/2905","id":72119022,"user":{"login":"rtibbles","id":1680573,"avatar_url":"https://avatars.githubusercontent.com/u/1680573?v=3","gravatar_id":"","url":"https://api.github.com/users/rtibbles","html_url":"https://github.com/rtibbles","followers_url":"https://api.github.com/users/rtibbles/followers","following_url":"https://api.github.com/users/rtibbles/following{/other_user}","gists_url":"https://api.github.com/users/rtibbles/gists{/gist_id}","starred_url":"https://api.github.com/users/rtibbles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtibbles/subscriptions","organizations_url":"https://api.github.com/users/rtibbles/orgs","repos_url":"https://api.github.com/users/rtibbles/repos","events_url":"https://api.github.com/users/rtibbles/events{/privacy}","received_events_url":"https://api.github.com/users/rtibbles/received_events","type":"User","site_admin":false},"created_at":"2015-01-29T22:39:17Z","updated_at":"2015-01-29T22:39:17Z","body":"Items that should now be translated:\r\nKhan-exercises exercise templates\r\nSidebar topic data\r\nExercise metadata\r\nVideo/Content metadata"}}