{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/6391","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/6391/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/6391/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/6391/events","html_url":"https://github.com/joomla/joomla-cms/pull/6391","id":60663494,"number":6391,"title":"Converted generatecss to use oyejorge/less.php","user":{"login":"nonumber","id":744259,"avatar_url":"https://avatars.githubusercontent.com/u/744259?v=3","gravatar_id":"","url":"https://api.github.com/users/nonumber","html_url":"https://github.com/nonumber","followers_url":"https://api.github.com/users/nonumber/followers","following_url":"https://api.github.com/users/nonumber/following{/other_user}","gists_url":"https://api.github.com/users/nonumber/gists{/gist_id}","starred_url":"https://api.github.com/users/nonumber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nonumber/subscriptions","organizations_url":"https://api.github.com/users/nonumber/orgs","repos_url":"https://api.github.com/users/nonumber/repos","events_url":"https://api.github.com/users/nonumber/events{/privacy}","received_events_url":"https://api.github.com/users/nonumber/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-03-11T14:08:27Z","updated_at":"2015-03-14T11:00:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/6391","html_url":"https://github.com/joomla/joomla-cms/pull/6391","diff_url":"https://github.com/joomla/joomla-cms/pull/6391.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/6391.patch"},"body":"This adds the oyejorge/less.php (https://github.com/oyejorge/less.php) to Joomla and uses that in the generatecss.php.\r\n\r\n### oyejorge vs leafo \r\nIn my view the oyejorge LESS compiler does a better job at compiling LESS than the current leafo one.\r\n\r\nSome things oyejorge does better:\r\n- Comments are added in the right place (leafo adds all comments from included files at the top)\r\n- Better handling of with calculations (percentages).\r\n- Better handling of order of declarations.\r\n- Keeps (adds) saces after comma's in rgb() and other function values (as it should be)\r\n\r\nExample of output of the 2 (without colour compression):\r\nleafo:\r\n```\r\n color: #fff;\r\n text-shadow: 0 -1px 0 rgba(0,0,0,0.25);\r\n```\r\noyejorge:\r\n```\r\n  color: #ffffff;\r\n  text-shadow: 0 -1px 0 rgba(0, 0, 0, 0.25);\r\n```\r\n\r\n### CSS minification\r\nThis PR also adds minification of the css files in the list in the generatecss.php.\r\n\r\nOnce this PR is ok'ed and merged, I can do the PRs to include the .min.css files in the templates and ather areas instead of the normal .css files."},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/80324510","html_url":"https://github.com/joomla/joomla-cms/pull/6391#issuecomment-80324510","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/6391","id":80324510,"user":{"login":"nonumber","id":744259,"avatar_url":"https://avatars.githubusercontent.com/u/744259?v=3","gravatar_id":"","url":"https://api.github.com/users/nonumber","html_url":"https://github.com/nonumber","followers_url":"https://api.github.com/users/nonumber/followers","following_url":"https://api.github.com/users/nonumber/following{/other_user}","gists_url":"https://api.github.com/users/nonumber/gists{/gist_id}","starred_url":"https://api.github.com/users/nonumber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nonumber/subscriptions","organizations_url":"https://api.github.com/users/nonumber/orgs","repos_url":"https://api.github.com/users/nonumber/repos","events_url":"https://api.github.com/users/nonumber/events{/privacy}","received_events_url":"https://api.github.com/users/nonumber/received_events","type":"User","site_admin":false},"created_at":"2015-03-14T11:00:40Z","updated_at":"2015-03-14T11:00:40Z","body":"How do we go about the fact that Bootstrap is licenced under Apache License v2.0 too?"}}