{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/mig/issues/160","labels_url":"https://api.github.com/repos/mozilla/mig/issues/160/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/mig/issues/160/comments","events_url":"https://api.github.com/repos/mozilla/mig/issues/160/events","html_url":"https://github.com/mozilla/mig/pull/160","id":123502138,"number":160,"title":"[minor] Decompress files before content inspect, aims to fix #108","user":{"login":"therealkbhat","id":7105012,"avatar_url":"https://avatars.githubusercontent.com/u/7105012?v=3","gravatar_id":"","url":"https://api.github.com/users/therealkbhat","html_url":"https://github.com/therealkbhat","followers_url":"https://api.github.com/users/therealkbhat/followers","following_url":"https://api.github.com/users/therealkbhat/following{/other_user}","gists_url":"https://api.github.com/users/therealkbhat/gists{/gist_id}","starred_url":"https://api.github.com/users/therealkbhat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/therealkbhat/subscriptions","organizations_url":"https://api.github.com/users/therealkbhat/orgs","repos_url":"https://api.github.com/users/therealkbhat/repos","events_url":"https://api.github.com/users/therealkbhat/events{/privacy}","received_events_url":"https://api.github.com/users/therealkbhat/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-12-22T15:32:37Z","updated_at":"2015-12-28T13:17:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/mig/pulls/160","html_url":"https://github.com/mozilla/mig/pull/160","diff_url":"https://github.com/mozilla/mig/pull/160.diff","patch_url":"https://github.com/mozilla/mig/pull/160.patch"},"body":"Work in progress.\r\n\r\n`decompressFile` returns a file descriptor which gets passed to `checkContent` and `checkHash` from `evaluateFile`. Note that I haven't removed `file string` from those calls; it seemed less invasive to pass both the string as well as the file descriptor, especially since the string is used extensively in calls to `debugprint` and `storematch`.\r\n\r\nDoes leaving the fd open across multiple function calls (`checkContent`, all the `checkHash`s) lead to any problems?\r\n\r\nI haven't gotten to tests or doc changes yet; thought I'd get feedback on this approach first. I also still need to look at dealing with multiple files in a single zip."},"comment":{"url":"https://api.github.com/repos/mozilla/mig/issues/comments/167566650","html_url":"https://github.com/mozilla/mig/pull/160#issuecomment-167566650","issue_url":"https://api.github.com/repos/mozilla/mig/issues/160","id":167566650,"user":{"login":"therealkbhat","id":7105012,"avatar_url":"https://avatars.githubusercontent.com/u/7105012?v=3","gravatar_id":"","url":"https://api.github.com/users/therealkbhat","html_url":"https://github.com/therealkbhat","followers_url":"https://api.github.com/users/therealkbhat/followers","following_url":"https://api.github.com/users/therealkbhat/following{/other_user}","gists_url":"https://api.github.com/users/therealkbhat/gists{/gist_id}","starred_url":"https://api.github.com/users/therealkbhat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/therealkbhat/subscriptions","organizations_url":"https://api.github.com/users/therealkbhat/orgs","repos_url":"https://api.github.com/users/therealkbhat/repos","events_url":"https://api.github.com/users/therealkbhat/events{/privacy}","received_events_url":"https://api.github.com/users/therealkbhat/received_events","type":"User","site_admin":false},"created_at":"2015-12-28T13:17:01Z","updated_at":"2015-12-28T13:17:01Z","body":"Can we assume that multiple files would normally be put in a tar structure before gzipping? gzip itself doesn't know anything about the file structure that it's compressing.\r\n\r\nWhat do you think should be the next step here?"}}