{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/25354570","id":25354570,"diff_hunk":"@@ -566,7 +566,9 @@\n       // All the children of this element are absolutely positioned and then\n       // transformed, so manually set a height for the convenience of\n       // embedders.\n-      this.element.style.height = this.layout.offsetY + 'px';\n+      var padding =","path":"shared/elements/gaia_grid/js/grid_view.js","position":25,"original_position":25,"commit_id":"358e91655398141ded463cefe547667a4f84717e","original_commit_id":"358e91655398141ded463cefe547667a4f84717e","user":{"login":"Cwiiis","id":668518,"avatar_url":"https://avatars.githubusercontent.com/u/668518?v=3","gravatar_id":"","url":"https://api.github.com/users/Cwiiis","html_url":"https://github.com/Cwiiis","followers_url":"https://api.github.com/users/Cwiiis/followers","following_url":"https://api.github.com/users/Cwiiis/following{/other_user}","gists_url":"https://api.github.com/users/Cwiiis/gists{/gist_id}","starred_url":"https://api.github.com/users/Cwiiis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cwiiis/subscriptions","organizations_url":"https://api.github.com/users/Cwiiis/orgs","repos_url":"https://api.github.com/users/Cwiiis/repos","events_url":"https://api.github.com/users/Cwiiis/events{/privacy}","received_events_url":"https://api.github.com/users/Cwiiis/received_events","type":"User","site_admin":false},"body":"We explicitly size the element, getBoundingClientRect would just return whatever height we last set (we could unset and re-set it, but then it'd just return the min-height + padding, which isn't what we want). This will reliably return the style's padding-bottom... I don't really like it, but short of introducing an explicit bottom-padding function to GaiaGrid, I'm not sure the best way of going about this :(","created_at":"2015-02-25T16:34:44Z","updated_at":"2015-02-25T16:34:44Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/27245#discussion_r25354570","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27245","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/25354570"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/27245#discussion_r25354570"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27245"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27245","id":27030908,"html_url":"https://github.com/mozilla-b2g/gaia/pull/27245","diff_url":"https://github.com/mozilla-b2g/gaia/pull/27245.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/27245.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/27245","number":27245,"state":"open","locked":false,"title":"Bug 1118006 - Make the long-press delay shorter in edit mode. r=","user":{"login":"Cwiiis","id":668518,"avatar_url":"https://avatars.githubusercontent.com/u/668518?v=3","gravatar_id":"","url":"https://api.github.com/users/Cwiiis","html_url":"https://github.com/Cwiiis","followers_url":"https://api.github.com/users/Cwiiis/followers","following_url":"https://api.github.com/users/Cwiiis/following{/other_user}","gists_url":"https://api.github.com/users/Cwiiis/gists{/gist_id}","starred_url":"https://api.github.com/users/Cwiiis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cwiiis/subscriptions","organizations_url":"https://api.github.com/users/Cwiiis/orgs","repos_url":"https://api.github.com/users/Cwiiis/repos","events_url":"https://api.github.com/users/Cwiiis/events{/privacy}","received_events_url":"https://api.github.com/users/Cwiiis/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-01-08T14:20:16Z","updated_at":"2015-02-25T16:34:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c49f58b5b2bef4afddca2a08ba00a199a6c5f91a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27245/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27245/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/27245/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/358e91655398141ded463cefe547667a4f84717e","head":{"label":"Cwiiis:bug1118006-shorter-edit-mode-longpress","ref":"bug1118006-shorter-edit-mode-longpress","sha":"358e91655398141ded463cefe547667a4f84717e","user":{"login":"Cwiiis","id":668518,"avatar_url":"https://avatars.githubusercontent.com/u/668518?v=3","gravatar_id":"","url":"https://api.github.com/users/Cwiiis","html_url":"https://github.com/Cwiiis","followers_url":"https://api.github.com/users/Cwiiis/followers","following_url":"https://api.github.com/users/Cwiiis/following{/other_user}","gists_url":"https://api.github.com/users/Cwiiis/gists{/gist_id}","starred_url":"https://api.github.com/users/Cwiiis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cwiiis/subscriptions","organizations_url":"https://api.github.com/users/Cwiiis/orgs","repos_url":"https://api.github.com/users/Cwiiis/repos","events_url":"https://api.github.com/users/Cwiiis/events{/privacy}","received_events_url":"https://api.github.com/users/Cwiiis/received_events","type":"User","site_admin":false},"repo":{"id":20401491,"name":"gaia","full_name":"Cwiiis/gaia","owner":{"login":"Cwiiis","id":668518,"avatar_url":"https://avatars.githubusercontent.com/u/668518?v=3","gravatar_id":"","url":"https://api.github.com/users/Cwiiis","html_url":"https://github.com/Cwiiis","followers_url":"https://api.github.com/users/Cwiiis/followers","following_url":"https://api.github.com/users/Cwiiis/following{/other_user}","gists_url":"https://api.github.com/users/Cwiiis/gists{/gist_id}","starred_url":"https://api.github.com/users/Cwiiis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cwiiis/subscriptions","organizations_url":"https://api.github.com/users/Cwiiis/orgs","repos_url":"https://api.github.com/users/Cwiiis/repos","events_url":"https://api.github.com/users/Cwiiis/events{/privacy}","received_events_url":"https://api.github.com/users/Cwiiis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Cwiiis/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","fork":true,"url":"https://api.github.com/repos/Cwiiis/gaia","forks_url":"https://api.github.com/repos/Cwiiis/gaia/forks","keys_url":"https://api.github.com/repos/Cwiiis/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cwiiis/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cwiiis/gaia/teams","hooks_url":"https://api.github.com/repos/Cwiiis/gaia/hooks","issue_events_url":"https://api.github.com/repos/Cwiiis/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/Cwiiis/gaia/events","assignees_url":"https://api.github.com/repos/Cwiiis/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/Cwiiis/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/Cwiiis/gaia/tags","blobs_url":"https://api.github.com/repos/Cwiiis/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cwiiis/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cwiiis/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cwiiis/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cwiiis/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/Cwiiis/gaia/languages","stargazers_url":"https://api.github.com/repos/Cwiiis/gaia/stargazers","contributors_url":"https://api.github.com/repos/Cwiiis/gaia/contributors","subscribers_url":"https://api.github.com/repos/Cwiiis/gaia/subscribers","subscription_url":"https://api.github.com/repos/Cwiiis/gaia/subscription","commits_url":"https://api.github.com/repos/Cwiiis/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cwiiis/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cwiiis/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cwiiis/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cwiiis/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/Cwiiis/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cwiiis/gaia/merges","archive_url":"https://api.github.com/repos/Cwiiis/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cwiiis/gaia/downloads","issues_url":"https://api.github.com/repos/Cwiiis/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/Cwiiis/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/Cwiiis/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/Cwiiis/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cwiiis/gaia/labels{/name}","releases_url":"https://api.github.com/repos/Cwiiis/gaia/releases{/id}","created_at":"2014-06-02T11:19:38Z","updated_at":"2015-02-20T15:47:03Z","pushed_at":"2015-02-25T14:01:26Z","git_url":"git://github.com/Cwiiis/gaia.git","ssh_url":"git@github.com:Cwiiis/gaia.git","clone_url":"https://github.com/Cwiiis/gaia.git","svn_url":"https://github.com/Cwiiis/gaia","homepage":"https://wiki.mozilla.org/B2G","size":890396,"stargazers_count":0,"watchers_count":0,"language":"XML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"b1d5b21f6748f97925f60ab63b446db9230a1533","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2015-02-25T16:31:18Z","pushed_at":"2015-02-25T16:31:17Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1430898,"stargazers_count":1876,"watchers_count":1876,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2233,"mirror_url":null,"open_issues_count":909,"forks":2233,"open_issues":909,"watchers":1876,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27245"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/27245"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/27245"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/27245/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27245/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27245/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/358e91655398141ded463cefe547667a4f84717e"}}}}