{"action":"created","comment":{"url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/pulls/comments/31625487","id":31625487,"diff_hunk":"@@ -89,19 +88,20 @@ class Driver\n   void setEncoderCPR(uint16_t encoder_cpr);\n   void setGearRatio(float gear_ratio);\n   void setMode(uint8_t mode);\n-  void setMode(uint8_t mode, float p, float i, float d);\n-  void setGains(float p, float i, float d);\n+  void setMode(uint8_t mode, double p, double i, double d);\n+  void setGains(double p, double i, double d);","path":"puma_motor_driver/include/puma_motor_driver/driver.h","position":51,"original_position":51,"commit_id":"ca7921a01b8ef262dbd3a36b8fa1bec819e48423","original_commit_id":"ca7921a01b8ef262dbd3a36b8fa1bec819e48423","user":{"login":"mikepurvis","id":944666,"avatar_url":"https://avatars.githubusercontent.com/u/944666?v=3","gravatar_id":"","url":"https://api.github.com/users/mikepurvis","html_url":"https://github.com/mikepurvis","followers_url":"https://api.github.com/users/mikepurvis/followers","following_url":"https://api.github.com/users/mikepurvis/following{/other_user}","gists_url":"https://api.github.com/users/mikepurvis/gists{/gist_id}","starred_url":"https://api.github.com/users/mikepurvis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikepurvis/subscriptions","organizations_url":"https://api.github.com/users/mikepurvis/orgs","repos_url":"https://api.github.com/users/mikepurvis/repos","events_url":"https://api.github.com/users/mikepurvis/events{/privacy}","received_events_url":"https://api.github.com/users/mikepurvis/received_events","type":"User","site_admin":false},"body":"Redundant?","created_at":"2015-06-03T14:06:09Z","updated_at":"2015-06-03T14:06:09Z","html_url":"https://github.com/clearpathrobotics/puma_motor_driver/pull/3#discussion_r31625487","pull_request_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/pulls/comments/31625487"},"html":{"href":"https://github.com/clearpathrobotics/puma_motor_driver/pull/3#discussion_r31625487"},"pull_request":{"href":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/pulls/3","id":36835606,"html_url":"https://github.com/clearpathrobotics/puma_motor_driver/pull/3","diff_url":"https://github.com/clearpathrobotics/puma_motor_driver/pull/3.diff","patch_url":"https://github.com/clearpathrobotics/puma_motor_driver/pull/3.patch","issue_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/issues/3","number":3,"state":"open","locked":false,"title":"Many improvements","user":{"login":"tonybaltovski","id":2964763,"avatar_url":"https://avatars.githubusercontent.com/u/2964763?v=3","gravatar_id":"","url":"https://api.github.com/users/tonybaltovski","html_url":"https://github.com/tonybaltovski","followers_url":"https://api.github.com/users/tonybaltovski/followers","following_url":"https://api.github.com/users/tonybaltovski/following{/other_user}","gists_url":"https://api.github.com/users/tonybaltovski/gists{/gist_id}","starred_url":"https://api.github.com/users/tonybaltovski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonybaltovski/subscriptions","organizations_url":"https://api.github.com/users/tonybaltovski/orgs","repos_url":"https://api.github.com/users/tonybaltovski/repos","events_url":"https://api.github.com/users/tonybaltovski/events{/privacy}","received_events_url":"https://api.github.com/users/tonybaltovski/received_events","type":"User","site_admin":false},"body":"- Added timestamps.\r\n- Added set-point of corresponding mode to feedback message.\r\n- Improved feedback requests.\r\n- Improved start-up time.\r\n- Added ROS parameters.","created_at":"2015-06-03T14:03:22Z","updated_at":"2015-06-03T14:06:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"167e2880dc2fe17c265449e6da284c34bf18ea9e","assignee":{"login":"mikepurvis","id":944666,"avatar_url":"https://avatars.githubusercontent.com/u/944666?v=3","gravatar_id":"","url":"https://api.github.com/users/mikepurvis","html_url":"https://github.com/mikepurvis","followers_url":"https://api.github.com/users/mikepurvis/followers","following_url":"https://api.github.com/users/mikepurvis/following{/other_user}","gists_url":"https://api.github.com/users/mikepurvis/gists{/gist_id}","starred_url":"https://api.github.com/users/mikepurvis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikepurvis/subscriptions","organizations_url":"https://api.github.com/users/mikepurvis/orgs","repos_url":"https://api.github.com/users/mikepurvis/repos","events_url":"https://api.github.com/users/mikepurvis/events{/privacy}","received_events_url":"https://api.github.com/users/mikepurvis/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/pulls/3/commits","review_comments_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/pulls/3/comments","review_comment_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/issues/3/comments","statuses_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/statuses/ca7921a01b8ef262dbd3a36b8fa1bec819e48423","head":{"label":"clearpathrobotics:devel","ref":"devel","sha":"ca7921a01b8ef262dbd3a36b8fa1bec819e48423","user":{"login":"clearpathrobotics","id":1552891,"avatar_url":"https://avatars.githubusercontent.com/u/1552891?v=3","gravatar_id":"","url":"https://api.github.com/users/clearpathrobotics","html_url":"https://github.com/clearpathrobotics","followers_url":"https://api.github.com/users/clearpathrobotics/followers","following_url":"https://api.github.com/users/clearpathrobotics/following{/other_user}","gists_url":"https://api.github.com/users/clearpathrobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/clearpathrobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearpathrobotics/subscriptions","organizations_url":"https://api.github.com/users/clearpathrobotics/orgs","repos_url":"https://api.github.com/users/clearpathrobotics/repos","events_url":"https://api.github.com/users/clearpathrobotics/events{/privacy}","received_events_url":"https://api.github.com/users/clearpathrobotics/received_events","type":"Organization","site_admin":false},"repo":{"id":30726850,"name":"puma_motor_driver","full_name":"clearpathrobotics/puma_motor_driver","owner":{"login":"clearpathrobotics","id":1552891,"avatar_url":"https://avatars.githubusercontent.com/u/1552891?v=3","gravatar_id":"","url":"https://api.github.com/users/clearpathrobotics","html_url":"https://github.com/clearpathrobotics","followers_url":"https://api.github.com/users/clearpathrobotics/followers","following_url":"https://api.github.com/users/clearpathrobotics/following{/other_user}","gists_url":"https://api.github.com/users/clearpathrobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/clearpathrobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearpathrobotics/subscriptions","organizations_url":"https://api.github.com/users/clearpathrobotics/orgs","repos_url":"https://api.github.com/users/clearpathrobotics/repos","events_url":"https://api.github.com/users/clearpathrobotics/events{/privacy}","received_events_url":"https://api.github.com/users/clearpathrobotics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clearpathrobotics/puma_motor_driver","description":"","fork":false,"url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver","forks_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/forks","keys_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/teams","hooks_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/hooks","issue_events_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/issues/events{/number}","events_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/events","assignees_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/assignees{/user}","branches_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/branches{/branch}","tags_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/tags","blobs_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/statuses/{sha}","languages_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/languages","stargazers_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/stargazers","contributors_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/contributors","subscribers_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/subscribers","subscription_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/subscription","commits_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/contents/{+path}","compare_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/merges","archive_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/downloads","issues_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/issues{/number}","pulls_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/pulls{/number}","milestones_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/milestones{/number}","notifications_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/labels{/name}","releases_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/releases{/id}","created_at":"2015-02-12T22:14:23Z","updated_at":"2015-04-30T20:10:00Z","pushed_at":"2015-06-03T14:03:22Z","git_url":"git://github.com/clearpathrobotics/puma_motor_driver.git","ssh_url":"git@github.com:clearpathrobotics/puma_motor_driver.git","clone_url":"https://github.com/clearpathrobotics/puma_motor_driver.git","svn_url":"https://github.com/clearpathrobotics/puma_motor_driver","homepage":null,"size":259,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"clearpathrobotics:master","ref":"master","sha":"dc2b0318f0a17e08115bce2796919acaec725084","user":{"login":"clearpathrobotics","id":1552891,"avatar_url":"https://avatars.githubusercontent.com/u/1552891?v=3","gravatar_id":"","url":"https://api.github.com/users/clearpathrobotics","html_url":"https://github.com/clearpathrobotics","followers_url":"https://api.github.com/users/clearpathrobotics/followers","following_url":"https://api.github.com/users/clearpathrobotics/following{/other_user}","gists_url":"https://api.github.com/users/clearpathrobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/clearpathrobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearpathrobotics/subscriptions","organizations_url":"https://api.github.com/users/clearpathrobotics/orgs","repos_url":"https://api.github.com/users/clearpathrobotics/repos","events_url":"https://api.github.com/users/clearpathrobotics/events{/privacy}","received_events_url":"https://api.github.com/users/clearpathrobotics/received_events","type":"Organization","site_admin":false},"repo":{"id":30726850,"name":"puma_motor_driver","full_name":"clearpathrobotics/puma_motor_driver","owner":{"login":"clearpathrobotics","id":1552891,"avatar_url":"https://avatars.githubusercontent.com/u/1552891?v=3","gravatar_id":"","url":"https://api.github.com/users/clearpathrobotics","html_url":"https://github.com/clearpathrobotics","followers_url":"https://api.github.com/users/clearpathrobotics/followers","following_url":"https://api.github.com/users/clearpathrobotics/following{/other_user}","gists_url":"https://api.github.com/users/clearpathrobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/clearpathrobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearpathrobotics/subscriptions","organizations_url":"https://api.github.com/users/clearpathrobotics/orgs","repos_url":"https://api.github.com/users/clearpathrobotics/repos","events_url":"https://api.github.com/users/clearpathrobotics/events{/privacy}","received_events_url":"https://api.github.com/users/clearpathrobotics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clearpathrobotics/puma_motor_driver","description":"","fork":false,"url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver","forks_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/forks","keys_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/teams","hooks_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/hooks","issue_events_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/issues/events{/number}","events_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/events","assignees_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/assignees{/user}","branches_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/branches{/branch}","tags_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/tags","blobs_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/statuses/{sha}","languages_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/languages","stargazers_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/stargazers","contributors_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/contributors","subscribers_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/subscribers","subscription_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/subscription","commits_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/contents/{+path}","compare_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/merges","archive_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/downloads","issues_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/issues{/number}","pulls_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/pulls{/number}","milestones_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/milestones{/number}","notifications_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/labels{/name}","releases_url":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/releases{/id}","created_at":"2015-02-12T22:14:23Z","updated_at":"2015-04-30T20:10:00Z","pushed_at":"2015-06-03T14:03:22Z","git_url":"git://github.com/clearpathrobotics/puma_motor_driver.git","ssh_url":"git@github.com:clearpathrobotics/puma_motor_driver.git","clone_url":"https://github.com/clearpathrobotics/puma_motor_driver.git","svn_url":"https://github.com/clearpathrobotics/puma_motor_driver","homepage":null,"size":259,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/pulls/3"},"html":{"href":"https://github.com/clearpathrobotics/puma_motor_driver/pull/3"},"issue":{"href":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/issues/3"},"comments":{"href":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/clearpathrobotics/puma_motor_driver/statuses/ca7921a01b8ef262dbd3a36b8fa1bec819e48423"}}}}