{"action":"created","comment":{"url":"https://api.github.com/repos/openssl/openssl/pulls/comments/42729663","id":42729663,"diff_hunk":"@@ -139,7 +139,7 @@ static void scryptROMix(unsigned char *B, uint64_t r, uint64_t N,\n         *pV = *pB++;\n         *pV |= *pB++ << 8;\n         *pV |= *pB++ << 16;\n-        *pV |= *pB++ << 24;\n+        *pV |= (uint32_t)*pB++ << 24;","path":"crypto/evp/scrypt.c","position":5,"original_position":5,"commit_id":"109492b185ebd67c1dd9ecab77e0e6e363bafd6e","original_commit_id":"109492b185ebd67c1dd9ecab77e0e6e363bafd6e","user":{"login":"dot-asm","id":9038069,"avatar_url":"https://avatars.githubusercontent.com/u/9038069?v=3","gravatar_id":"","url":"https://api.github.com/users/dot-asm","html_url":"https://github.com/dot-asm","followers_url":"https://api.github.com/users/dot-asm/followers","following_url":"https://api.github.com/users/dot-asm/following{/other_user}","gists_url":"https://api.github.com/users/dot-asm/gists{/gist_id}","starred_url":"https://api.github.com/users/dot-asm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dot-asm/subscriptions","organizations_url":"https://api.github.com/users/dot-asm/orgs","repos_url":"https://api.github.com/users/dot-asm/repos","events_url":"https://api.github.com/users/dot-asm/events{/privacy}","received_events_url":"https://api.github.com/users/dot-asm/received_events","type":"User","site_admin":false},"body":"As for \"two's complement\". You have to read it in context. Original \"it doesn't *seem* to affect\" is nothing else but empirical statement, i.e. based on experimental observation. Then it's modified to \"it doesn't affect the result on any of the supported platforms\", i.e. no \"seem\", but reference to \"supported platforms\". This is also nothing else but empirical statement, just stronger one. Note that quotes' placement was not a coincidence, because \"all of them are two's complement\" is not actually integral part of the statement, but suggested explanation for how come statement is supported by experimental observations. In other words, I'm not suggesting to make unsafe assumptions, only try to explain how it worked so far.\r\n","created_at":"2015-10-22T09:55:19Z","updated_at":"2015-10-22T09:55:19Z","html_url":"https://github.com/openssl/openssl/pull/445#discussion_r42729663","pull_request_url":"https://api.github.com/repos/openssl/openssl/pulls/445","_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments/42729663"},"html":{"href":"https://github.com/openssl/openssl/pull/445#discussion_r42729663"},"pull_request":{"href":"https://api.github.com/repos/openssl/openssl/pulls/445"}}},"pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/445","id":48069138,"html_url":"https://github.com/openssl/openssl/pull/445","diff_url":"https://github.com/openssl/openssl/pull/445.diff","patch_url":"https://github.com/openssl/openssl/pull/445.patch","issue_url":"https://api.github.com/repos/openssl/openssl/issues/445","number":445,"state":"open","locked":false,"title":"Undefined behavior sanitizer","user":{"login":"ghedo","id":117643,"avatar_url":"https://avatars.githubusercontent.com/u/117643?v=3","gravatar_id":"","url":"https://api.github.com/users/ghedo","html_url":"https://github.com/ghedo","followers_url":"https://api.github.com/users/ghedo/followers","following_url":"https://api.github.com/users/ghedo/following{/other_user}","gists_url":"https://api.github.com/users/ghedo/gists{/gist_id}","starred_url":"https://api.github.com/users/ghedo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghedo/subscriptions","organizations_url":"https://api.github.com/users/ghedo/orgs","repos_url":"https://api.github.com/users/ghedo/repos","events_url":"https://api.github.com/users/ghedo/events{/privacy}","received_events_url":"https://api.github.com/users/ghedo/received_events","type":"User","site_admin":false},"body":"/cc @dot-asm ","created_at":"2015-10-19T13:09:31Z","updated_at":"2015-10-22T09:55:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d4c427c0f7d6fe804c84ca48e6b450c1a269a0a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openssl/openssl/pulls/445/commits","review_comments_url":"https://api.github.com/repos/openssl/openssl/pulls/445/comments","review_comment_url":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/445/comments","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/109492b185ebd67c1dd9ecab77e0e6e363bafd6e","head":{"label":"ghedo:ubsan","ref":"ubsan","sha":"109492b185ebd67c1dd9ecab77e0e6e363bafd6e","user":{"login":"ghedo","id":117643,"avatar_url":"https://avatars.githubusercontent.com/u/117643?v=3","gravatar_id":"","url":"https://api.github.com/users/ghedo","html_url":"https://github.com/ghedo","followers_url":"https://api.github.com/users/ghedo/followers","following_url":"https://api.github.com/users/ghedo/following{/other_user}","gists_url":"https://api.github.com/users/ghedo/gists{/gist_id}","starred_url":"https://api.github.com/users/ghedo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghedo/subscriptions","organizations_url":"https://api.github.com/users/ghedo/orgs","repos_url":"https://api.github.com/users/ghedo/repos","events_url":"https://api.github.com/users/ghedo/events{/privacy}","received_events_url":"https://api.github.com/users/ghedo/received_events","type":"User","site_admin":false},"repo":{"id":40092243,"name":"openssl","full_name":"ghedo/openssl","owner":{"login":"ghedo","id":117643,"avatar_url":"https://avatars.githubusercontent.com/u/117643?v=3","gravatar_id":"","url":"https://api.github.com/users/ghedo","html_url":"https://github.com/ghedo","followers_url":"https://api.github.com/users/ghedo/followers","following_url":"https://api.github.com/users/ghedo/following{/other_user}","gists_url":"https://api.github.com/users/ghedo/gists{/gist_id}","starred_url":"https://api.github.com/users/ghedo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghedo/subscriptions","organizations_url":"https://api.github.com/users/ghedo/orgs","repos_url":"https://api.github.com/users/ghedo/repos","events_url":"https://api.github.com/users/ghedo/events{/privacy}","received_events_url":"https://api.github.com/users/ghedo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ghedo/openssl","description":"","fork":true,"url":"https://api.github.com/repos/ghedo/openssl","forks_url":"https://api.github.com/repos/ghedo/openssl/forks","keys_url":"https://api.github.com/repos/ghedo/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ghedo/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ghedo/openssl/teams","hooks_url":"https://api.github.com/repos/ghedo/openssl/hooks","issue_events_url":"https://api.github.com/repos/ghedo/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/ghedo/openssl/events","assignees_url":"https://api.github.com/repos/ghedo/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/ghedo/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/ghedo/openssl/tags","blobs_url":"https://api.github.com/repos/ghedo/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ghedo/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ghedo/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/ghedo/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ghedo/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/ghedo/openssl/languages","stargazers_url":"https://api.github.com/repos/ghedo/openssl/stargazers","contributors_url":"https://api.github.com/repos/ghedo/openssl/contributors","subscribers_url":"https://api.github.com/repos/ghedo/openssl/subscribers","subscription_url":"https://api.github.com/repos/ghedo/openssl/subscription","commits_url":"https://api.github.com/repos/ghedo/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/ghedo/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/ghedo/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/ghedo/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/ghedo/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/ghedo/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ghedo/openssl/merges","archive_url":"https://api.github.com/repos/ghedo/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ghedo/openssl/downloads","issues_url":"https://api.github.com/repos/ghedo/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/ghedo/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/ghedo/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/ghedo/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ghedo/openssl/labels{/name}","releases_url":"https://api.github.com/repos/ghedo/openssl/releases{/id}","created_at":"2015-08-02T20:43:48Z","updated_at":"2015-08-21T11:07:19Z","pushed_at":"2015-10-19T13:08:32Z","git_url":"git://github.com/ghedo/openssl.git","ssh_url":"git@github.com:ghedo/openssl.git","clone_url":"https://github.com/ghedo/openssl.git","svn_url":"https://github.com/ghedo/openssl","homepage":null,"size":69903,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openssl:master","ref":"master","sha":"788d72ba021fdd29f6b3e573adc313d97f7d224d","user":{"login":"openssl","id":3279138,"avatar_url":"https://avatars.githubusercontent.com/u/3279138?v=3","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"repo":{"id":7634677,"name":"openssl","full_name":"openssl/openssl","owner":{"login":"openssl","id":3279138,"avatar_url":"https://avatars.githubusercontent.com/u/3279138?v=3","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openssl/openssl","description":"","fork":false,"url":"https://api.github.com/repos/openssl/openssl","forks_url":"https://api.github.com/repos/openssl/openssl/forks","keys_url":"https://api.github.com/repos/openssl/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openssl/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openssl/openssl/teams","hooks_url":"https://api.github.com/repos/openssl/openssl/hooks","issue_events_url":"https://api.github.com/repos/openssl/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/openssl/openssl/events","assignees_url":"https://api.github.com/repos/openssl/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/openssl/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/openssl/openssl/tags","blobs_url":"https://api.github.com/repos/openssl/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openssl/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openssl/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/openssl/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/openssl/openssl/languages","stargazers_url":"https://api.github.com/repos/openssl/openssl/stargazers","contributors_url":"https://api.github.com/repos/openssl/openssl/contributors","subscribers_url":"https://api.github.com/repos/openssl/openssl/subscribers","subscription_url":"https://api.github.com/repos/openssl/openssl/subscription","commits_url":"https://api.github.com/repos/openssl/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/openssl/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/openssl/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/openssl/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/openssl/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/openssl/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openssl/openssl/merges","archive_url":"https://api.github.com/repos/openssl/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openssl/openssl/downloads","issues_url":"https://api.github.com/repos/openssl/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/openssl/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/openssl/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/openssl/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openssl/openssl/labels{/name}","releases_url":"https://api.github.com/repos/openssl/openssl/releases{/id}","created_at":"2013-01-15T22:34:48Z","updated_at":"2015-10-22T09:27:24Z","pushed_at":"2015-10-21T22:05:57Z","git_url":"git://github.com/openssl/openssl.git","ssh_url":"git@github.com:openssl/openssl.git","clone_url":"https://github.com/openssl/openssl.git","svn_url":"https://github.com/openssl/openssl","homepage":null,"size":105193,"stargazers_count":1530,"watchers_count":1530,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":938,"mirror_url":null,"open_issues_count":140,"forks":938,"open_issues":140,"watchers":1530,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/445"},"html":{"href":"https://github.com/openssl/openssl/pull/445"},"issue":{"href":"https://api.github.com/repos/openssl/openssl/issues/445"},"comments":{"href":"https://api.github.com/repos/openssl/openssl/issues/445/comments"},"review_comments":{"href":"https://api.github.com/repos/openssl/openssl/pulls/445/comments"},"review_comment":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openssl/openssl/pulls/445/commits"},"statuses":{"href":"https://api.github.com/repos/openssl/openssl/statuses/109492b185ebd67c1dd9ecab77e0e6e363bafd6e"}}}}