{"action":"closed","number":471,"pull_request":{"url":"https://api.github.com/repos/azukiapp/azk/pulls/471","id":38152764,"html_url":"https://github.com/azukiapp/azk/pull/471","diff_url":"https://github.com/azukiapp/azk/pull/471.diff","patch_url":"https://github.com/azukiapp/azk/pull/471.patch","issue_url":"https://api.github.com/repos/azukiapp/azk/issues/471","number":471,"state":"closed","locked":false,"title":"[Manifest] short wait","user":{"login":"saitodisse","id":155953,"avatar_url":"https://avatars.githubusercontent.com/u/155953?v=3","gravatar_id":"","url":"https://api.github.com/users/saitodisse","html_url":"https://github.com/saitodisse","followers_url":"https://api.github.com/users/saitodisse/followers","following_url":"https://api.github.com/users/saitodisse/following{/other_user}","gists_url":"https://api.github.com/users/saitodisse/gists{/gist_id}","starred_url":"https://api.github.com/users/saitodisse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saitodisse/subscriptions","organizations_url":"https://api.github.com/users/saitodisse/orgs","repos_url":"https://api.github.com/users/saitodisse/repos","events_url":"https://api.github.com/users/saitodisse/events{/privacy}","received_events_url":"https://api.github.com/users/saitodisse/received_events","type":"User","site_admin":false},"body":"- [x] [short wait] add wait option tests to validate\r\n- [x] [short wait] wait can accept a positive number\r\n- [x] [short wait] created several tests to check a valid wait option\r\n![image](https://cloud.githubusercontent.com/assets/155953/8264184/8bd0999e-16b9-11e5-9b09-fcfce82832f6.png)\r\n- [x] [short wait] wait uses `retry` package create a list of intermediary timeouts\r\n- [x] [short wait] wait accepts a simple number\r\n- [x] [short wait] use bluebird `request().timeout(20)`\r\n- [x] [short wait] change `waitService` on `utils/net`\r\n![image](https://cloud.githubusercontent.com/assets/155953/8342519/0693fa6c-1aa3-11e5-975c-8e83866adb43.png)\r\n- [x] [short wait] fix rejection on `waitService` to show a good message\r\n```js\r\n    .timeout(opts.timeout)\r\n    .catch(function () {\r\n      return promiseResolve(false);\r\n    });\r\n```\r\n- [x] [short wait] fix timeout message to show total timeout\r\n- [x] [short wait] update docs again\r\n\r\n#### valid:\r\n\r\n```js\r\nwait: 20,\r\n\r\n// will be deprecated\r\nwait: { retry: 10, timeout: 1000 },\r\nwait: { retry: 1, timeout: 0 },\r\n```\r\n\r\n#### invalid:\r\n\r\n```js\r\n// not accepting negative values\r\nwait: { retry: -1, timeout: 1000 },\r\nwait: { retry: 1, timeout: -20 },\r\nwait: -20,\r\n\r\n// does not accept strings here, only numbers\r\nwait: { retry: \"1\", timeout: 1000 },\r\nwait: { retry: 1, timeout: \"20\" },\r\nwait: \"20\",\r\n```\r\nThis closes #148 ","created_at":"2015-06-19T22:12:42Z","updated_at":"2015-07-21T23:08:58Z","closed_at":"2015-07-21T23:08:58Z","merged_at":"2015-07-21T23:08:58Z","merge_commit_sha":"1e473760c40fecf5cfe480db1b363250428e3bb4","assignee":{"login":"saitodisse","id":155953,"avatar_url":"https://avatars.githubusercontent.com/u/155953?v=3","gravatar_id":"","url":"https://api.github.com/users/saitodisse","html_url":"https://github.com/saitodisse","followers_url":"https://api.github.com/users/saitodisse/followers","following_url":"https://api.github.com/users/saitodisse/following{/other_user}","gists_url":"https://api.github.com/users/saitodisse/gists{/gist_id}","starred_url":"https://api.github.com/users/saitodisse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saitodisse/subscriptions","organizations_url":"https://api.github.com/users/saitodisse/orgs","repos_url":"https://api.github.com/users/saitodisse/repos","events_url":"https://api.github.com/users/saitodisse/events{/privacy}","received_events_url":"https://api.github.com/users/saitodisse/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/azukiapp/azk/milestones/18","html_url":"https://github.com/azukiapp/azk/milestones/v0.15.0","labels_url":"https://api.github.com/repos/azukiapp/azk/milestones/18/labels","id":1141506,"number":18,"title":"v0.15.0","description":"","creator":{"login":"nuxlli","id":8738,"avatar_url":"https://avatars.githubusercontent.com/u/8738?v=3","gravatar_id":"","url":"https://api.github.com/users/nuxlli","html_url":"https://github.com/nuxlli","followers_url":"https://api.github.com/users/nuxlli/followers","following_url":"https://api.github.com/users/nuxlli/following{/other_user}","gists_url":"https://api.github.com/users/nuxlli/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxlli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxlli/subscriptions","organizations_url":"https://api.github.com/users/nuxlli/orgs","repos_url":"https://api.github.com/users/nuxlli/repos","events_url":"https://api.github.com/users/nuxlli/events{/privacy}","received_events_url":"https://api.github.com/users/nuxlli/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":9,"state":"open","created_at":"2015-05-31T02:20:40Z","updated_at":"2015-07-21T23:08:58Z","due_on":"2015-07-01T03:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/azukiapp/azk/pulls/471/commits","review_comments_url":"https://api.github.com/repos/azukiapp/azk/pulls/471/comments","review_comment_url":"https://api.github.com/repos/azukiapp/azk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/azukiapp/azk/issues/471/comments","statuses_url":"https://api.github.com/repos/azukiapp/azk/statuses/e9158d448dc1af1c82d44696f3b54cc0f8c9b2b9","head":{"label":"saitodisse:feature/short-wait","ref":"feature/short-wait","sha":"e9158d448dc1af1c82d44696f3b54cc0f8c9b2b9","user":{"login":"saitodisse","id":155953,"avatar_url":"https://avatars.githubusercontent.com/u/155953?v=3","gravatar_id":"","url":"https://api.github.com/users/saitodisse","html_url":"https://github.com/saitodisse","followers_url":"https://api.github.com/users/saitodisse/followers","following_url":"https://api.github.com/users/saitodisse/following{/other_user}","gists_url":"https://api.github.com/users/saitodisse/gists{/gist_id}","starred_url":"https://api.github.com/users/saitodisse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saitodisse/subscriptions","organizations_url":"https://api.github.com/users/saitodisse/orgs","repos_url":"https://api.github.com/users/saitodisse/repos","events_url":"https://api.github.com/users/saitodisse/events{/privacy}","received_events_url":"https://api.github.com/users/saitodisse/received_events","type":"User","site_admin":false},"repo":{"id":22665685,"name":"azk","full_name":"saitodisse/azk","owner":{"login":"saitodisse","id":155953,"avatar_url":"https://avatars.githubusercontent.com/u/155953?v=3","gravatar_id":"","url":"https://api.github.com/users/saitodisse","html_url":"https://github.com/saitodisse","followers_url":"https://api.github.com/users/saitodisse/followers","following_url":"https://api.github.com/users/saitodisse/following{/other_user}","gists_url":"https://api.github.com/users/saitodisse/gists{/gist_id}","starred_url":"https://api.github.com/users/saitodisse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saitodisse/subscriptions","organizations_url":"https://api.github.com/users/saitodisse/orgs","repos_url":"https://api.github.com/users/saitodisse/repos","events_url":"https://api.github.com/users/saitodisse/events{/privacy}","received_events_url":"https://api.github.com/users/saitodisse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saitodisse/azk","description":"Automated installation and configuration of development environments","fork":true,"url":"https://api.github.com/repos/saitodisse/azk","forks_url":"https://api.github.com/repos/saitodisse/azk/forks","keys_url":"https://api.github.com/repos/saitodisse/azk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saitodisse/azk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saitodisse/azk/teams","hooks_url":"https://api.github.com/repos/saitodisse/azk/hooks","issue_events_url":"https://api.github.com/repos/saitodisse/azk/issues/events{/number}","events_url":"https://api.github.com/repos/saitodisse/azk/events","assignees_url":"https://api.github.com/repos/saitodisse/azk/assignees{/user}","branches_url":"https://api.github.com/repos/saitodisse/azk/branches{/branch}","tags_url":"https://api.github.com/repos/saitodisse/azk/tags","blobs_url":"https://api.github.com/repos/saitodisse/azk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saitodisse/azk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saitodisse/azk/git/refs{/sha}","trees_url":"https://api.github.com/repos/saitodisse/azk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saitodisse/azk/statuses/{sha}","languages_url":"https://api.github.com/repos/saitodisse/azk/languages","stargazers_url":"https://api.github.com/repos/saitodisse/azk/stargazers","contributors_url":"https://api.github.com/repos/saitodisse/azk/contributors","subscribers_url":"https://api.github.com/repos/saitodisse/azk/subscribers","subscription_url":"https://api.github.com/repos/saitodisse/azk/subscription","commits_url":"https://api.github.com/repos/saitodisse/azk/commits{/sha}","git_commits_url":"https://api.github.com/repos/saitodisse/azk/git/commits{/sha}","comments_url":"https://api.github.com/repos/saitodisse/azk/comments{/number}","issue_comment_url":"https://api.github.com/repos/saitodisse/azk/issues/comments{/number}","contents_url":"https://api.github.com/repos/saitodisse/azk/contents/{+path}","compare_url":"https://api.github.com/repos/saitodisse/azk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saitodisse/azk/merges","archive_url":"https://api.github.com/repos/saitodisse/azk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saitodisse/azk/downloads","issues_url":"https://api.github.com/repos/saitodisse/azk/issues{/number}","pulls_url":"https://api.github.com/repos/saitodisse/azk/pulls{/number}","milestones_url":"https://api.github.com/repos/saitodisse/azk/milestones{/number}","notifications_url":"https://api.github.com/repos/saitodisse/azk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saitodisse/azk/labels{/name}","releases_url":"https://api.github.com/repos/saitodisse/azk/releases{/id}","created_at":"2014-08-06T01:38:40Z","updated_at":"2015-05-07T22:11:11Z","pushed_at":"2015-07-21T22:25:05Z","git_url":"git://github.com/saitodisse/azk.git","ssh_url":"git@github.com:saitodisse/azk.git","clone_url":"https://github.com/saitodisse/azk.git","svn_url":"https://github.com/saitodisse/azk","homepage":"http://azk.io","size":10854,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"azukiapp:master","ref":"master","sha":"5a908fa4525ce676bd5c5d11324c1e1b6ed4d141","user":{"login":"azukiapp","id":2593357,"avatar_url":"https://avatars.githubusercontent.com/u/2593357?v=3","gravatar_id":"","url":"https://api.github.com/users/azukiapp","html_url":"https://github.com/azukiapp","followers_url":"https://api.github.com/users/azukiapp/followers","following_url":"https://api.github.com/users/azukiapp/following{/other_user}","gists_url":"https://api.github.com/users/azukiapp/gists{/gist_id}","starred_url":"https://api.github.com/users/azukiapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azukiapp/subscriptions","organizations_url":"https://api.github.com/users/azukiapp/orgs","repos_url":"https://api.github.com/users/azukiapp/repos","events_url":"https://api.github.com/users/azukiapp/events{/privacy}","received_events_url":"https://api.github.com/users/azukiapp/received_events","type":"Organization","site_admin":false},"repo":{"id":13003799,"name":"azk","full_name":"azukiapp/azk","owner":{"login":"azukiapp","id":2593357,"avatar_url":"https://avatars.githubusercontent.com/u/2593357?v=3","gravatar_id":"","url":"https://api.github.com/users/azukiapp","html_url":"https://github.com/azukiapp","followers_url":"https://api.github.com/users/azukiapp/followers","following_url":"https://api.github.com/users/azukiapp/following{/other_user}","gists_url":"https://api.github.com/users/azukiapp/gists{/gist_id}","starred_url":"https://api.github.com/users/azukiapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azukiapp/subscriptions","organizations_url":"https://api.github.com/users/azukiapp/orgs","repos_url":"https://api.github.com/users/azukiapp/repos","events_url":"https://api.github.com/users/azukiapp/events{/privacy}","received_events_url":"https://api.github.com/users/azukiapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/azukiapp/azk","description":"azk is a development environment orchestration tool. Run any app environment, completely isolated, in just a few minutes.","fork":false,"url":"https://api.github.com/repos/azukiapp/azk","forks_url":"https://api.github.com/repos/azukiapp/azk/forks","keys_url":"https://api.github.com/repos/azukiapp/azk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/azukiapp/azk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/azukiapp/azk/teams","hooks_url":"https://api.github.com/repos/azukiapp/azk/hooks","issue_events_url":"https://api.github.com/repos/azukiapp/azk/issues/events{/number}","events_url":"https://api.github.com/repos/azukiapp/azk/events","assignees_url":"https://api.github.com/repos/azukiapp/azk/assignees{/user}","branches_url":"https://api.github.com/repos/azukiapp/azk/branches{/branch}","tags_url":"https://api.github.com/repos/azukiapp/azk/tags","blobs_url":"https://api.github.com/repos/azukiapp/azk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/azukiapp/azk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/azukiapp/azk/git/refs{/sha}","trees_url":"https://api.github.com/repos/azukiapp/azk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/azukiapp/azk/statuses/{sha}","languages_url":"https://api.github.com/repos/azukiapp/azk/languages","stargazers_url":"https://api.github.com/repos/azukiapp/azk/stargazers","contributors_url":"https://api.github.com/repos/azukiapp/azk/contributors","subscribers_url":"https://api.github.com/repos/azukiapp/azk/subscribers","subscription_url":"https://api.github.com/repos/azukiapp/azk/subscription","commits_url":"https://api.github.com/repos/azukiapp/azk/commits{/sha}","git_commits_url":"https://api.github.com/repos/azukiapp/azk/git/commits{/sha}","comments_url":"https://api.github.com/repos/azukiapp/azk/comments{/number}","issue_comment_url":"https://api.github.com/repos/azukiapp/azk/issues/comments{/number}","contents_url":"https://api.github.com/repos/azukiapp/azk/contents/{+path}","compare_url":"https://api.github.com/repos/azukiapp/azk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/azukiapp/azk/merges","archive_url":"https://api.github.com/repos/azukiapp/azk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/azukiapp/azk/downloads","issues_url":"https://api.github.com/repos/azukiapp/azk/issues{/number}","pulls_url":"https://api.github.com/repos/azukiapp/azk/pulls{/number}","milestones_url":"https://api.github.com/repos/azukiapp/azk/milestones{/number}","notifications_url":"https://api.github.com/repos/azukiapp/azk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/azukiapp/azk/labels{/name}","releases_url":"https://api.github.com/repos/azukiapp/azk/releases{/id}","created_at":"2013-09-21T23:02:55Z","updated_at":"2015-07-20T02:31:31Z","pushed_at":"2015-07-21T23:08:58Z","git_url":"git://github.com/azukiapp/azk.git","ssh_url":"git@github.com:azukiapp/azk.git","clone_url":"https://github.com/azukiapp/azk.git","svn_url":"https://github.com/azukiapp/azk","homepage":"http://azk.io","size":13662,"stargazers_count":291,"watchers_count":291,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":53,"forks":30,"open_issues":53,"watchers":291,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/azukiapp/azk/pulls/471"},"html":{"href":"https://github.com/azukiapp/azk/pull/471"},"issue":{"href":"https://api.github.com/repos/azukiapp/azk/issues/471"},"comments":{"href":"https://api.github.com/repos/azukiapp/azk/issues/471/comments"},"review_comments":{"href":"https://api.github.com/repos/azukiapp/azk/pulls/471/comments"},"review_comment":{"href":"https://api.github.com/repos/azukiapp/azk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/azukiapp/azk/pulls/471/commits"},"statuses":{"href":"https://api.github.com/repos/azukiapp/azk/statuses/e9158d448dc1af1c82d44696f3b54cc0f8c9b2b9"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"nuxlli","id":8738,"avatar_url":"https://avatars.githubusercontent.com/u/8738?v=3","gravatar_id":"","url":"https://api.github.com/users/nuxlli","html_url":"https://github.com/nuxlli","followers_url":"https://api.github.com/users/nuxlli/followers","following_url":"https://api.github.com/users/nuxlli/following{/other_user}","gists_url":"https://api.github.com/users/nuxlli/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxlli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxlli/subscriptions","organizations_url":"https://api.github.com/users/nuxlli/orgs","repos_url":"https://api.github.com/users/nuxlli/repos","events_url":"https://api.github.com/users/nuxlli/events{/privacy}","received_events_url":"https://api.github.com/users/nuxlli/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":11,"additions":1054,"deletions":766,"changed_files":23}}