{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/29641168","id":29641168,"diff_hunk":"@@ -632,11 +638,13 @@ class ShuffleSplit(BaseShuffleSplit):\n     n_iter : int (default 10)\n         Number of re-shuffling & splitting iterations.\n \n-    test_size : float (default 0.1), int, or None\n+    test_size : float (default 0.1), int, or None,","path":"sklearn/cross_validation.py","position":38,"original_position":38,"commit_id":"dc94a90df7e54ba97aaa1e95c5e6922f757b0fe6","original_commit_id":"dc94a90df7e54ba97aaa1e95c5e6922f757b0fe6","user":{"login":"SnakeHunt2012","id":2970920,"avatar_url":"https://avatars.githubusercontent.com/u/2970920?v=3","gravatar_id":"","url":"https://api.github.com/users/SnakeHunt2012","html_url":"https://github.com/SnakeHunt2012","followers_url":"https://api.github.com/users/SnakeHunt2012/followers","following_url":"https://api.github.com/users/SnakeHunt2012/following{/other_user}","gists_url":"https://api.github.com/users/SnakeHunt2012/gists{/gist_id}","starred_url":"https://api.github.com/users/SnakeHunt2012/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnakeHunt2012/subscriptions","organizations_url":"https://api.github.com/users/SnakeHunt2012/orgs","repos_url":"https://api.github.com/users/SnakeHunt2012/repos","events_url":"https://api.github.com/users/SnakeHunt2012/events{/privacy}","received_events_url":"https://api.github.com/users/SnakeHunt2012/received_events","type":"User","site_admin":false},"body":"Of course, I'll fix that.","created_at":"2015-05-05T02:45:25Z","updated_at":"2015-05-05T02:45:25Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/4621#discussion_r29641168","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4621","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/29641168"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/4621#discussion_r29641168"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4621"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4621","id":33619653,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/4621","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/4621.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/4621.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4621","number":4621,"state":"open","locked":false,"title":"Fix Bug ##4618","user":{"login":"SnakeHunt2012","id":2970920,"avatar_url":"https://avatars.githubusercontent.com/u/2970920?v=3","gravatar_id":"","url":"https://api.github.com/users/SnakeHunt2012","html_url":"https://github.com/SnakeHunt2012","followers_url":"https://api.github.com/users/SnakeHunt2012/followers","following_url":"https://api.github.com/users/SnakeHunt2012/following{/other_user}","gists_url":"https://api.github.com/users/SnakeHunt2012/gists{/gist_id}","starred_url":"https://api.github.com/users/SnakeHunt2012/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnakeHunt2012/subscriptions","organizations_url":"https://api.github.com/users/SnakeHunt2012/orgs","repos_url":"https://api.github.com/users/SnakeHunt2012/repos","events_url":"https://api.github.com/users/SnakeHunt2012/events{/privacy}","received_events_url":"https://api.github.com/users/SnakeHunt2012/received_events","type":"User","site_admin":false},"body":"cross_validation.ShuffleSplit setting train_size without setting test_size, the sum of train_size and test_size is not equal to 1. Now the sum of them is 0.1(default value of test_size) + train_size.\r\n\r\nWhen setting test_size without setting train_size, the train_size is autocomputed by 1 - test_size, so we hope when setting train_size, the test_size is autocomputed by 1 - train_size as well, not defualt value 0.1.\r\n\r\nhttps://github.com/scikit-learn/scikit-learn/issues/4618","created_at":"2015-04-19T14:28:58Z","updated_at":"2015-05-05T02:45:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be3f94c7a3e0a6d806e5843733b81664a3b1e776","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4621/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4621/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4621/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/dc94a90df7e54ba97aaa1e95c5e6922f757b0fe6","head":{"label":"SnakeHunt2012:fix-bug-#4618","ref":"fix-bug-#4618","sha":"dc94a90df7e54ba97aaa1e95c5e6922f757b0fe6","user":{"login":"SnakeHunt2012","id":2970920,"avatar_url":"https://avatars.githubusercontent.com/u/2970920?v=3","gravatar_id":"","url":"https://api.github.com/users/SnakeHunt2012","html_url":"https://github.com/SnakeHunt2012","followers_url":"https://api.github.com/users/SnakeHunt2012/followers","following_url":"https://api.github.com/users/SnakeHunt2012/following{/other_user}","gists_url":"https://api.github.com/users/SnakeHunt2012/gists{/gist_id}","starred_url":"https://api.github.com/users/SnakeHunt2012/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnakeHunt2012/subscriptions","organizations_url":"https://api.github.com/users/SnakeHunt2012/orgs","repos_url":"https://api.github.com/users/SnakeHunt2012/repos","events_url":"https://api.github.com/users/SnakeHunt2012/events{/privacy}","received_events_url":"https://api.github.com/users/SnakeHunt2012/received_events","type":"User","site_admin":false},"repo":{"id":34190406,"name":"scikit-learn","full_name":"SnakeHunt2012/scikit-learn","owner":{"login":"SnakeHunt2012","id":2970920,"avatar_url":"https://avatars.githubusercontent.com/u/2970920?v=3","gravatar_id":"","url":"https://api.github.com/users/SnakeHunt2012","html_url":"https://github.com/SnakeHunt2012","followers_url":"https://api.github.com/users/SnakeHunt2012/followers","following_url":"https://api.github.com/users/SnakeHunt2012/following{/other_user}","gists_url":"https://api.github.com/users/SnakeHunt2012/gists{/gist_id}","starred_url":"https://api.github.com/users/SnakeHunt2012/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnakeHunt2012/subscriptions","organizations_url":"https://api.github.com/users/SnakeHunt2012/orgs","repos_url":"https://api.github.com/users/SnakeHunt2012/repos","events_url":"https://api.github.com/users/SnakeHunt2012/events{/privacy}","received_events_url":"https://api.github.com/users/SnakeHunt2012/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SnakeHunt2012/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn","forks_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/forks","keys_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/teams","hooks_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/events","assignees_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/tags","blobs_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/subscription","commits_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/merges","archive_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/downloads","issues_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/SnakeHunt2012/scikit-learn/releases{/id}","created_at":"2015-04-19T02:19:06Z","updated_at":"2015-04-19T02:19:12Z","pushed_at":"2015-05-02T17:32:19Z","git_url":"git://github.com/SnakeHunt2012/scikit-learn.git","ssh_url":"git@github.com:SnakeHunt2012/scikit-learn.git","clone_url":"https://github.com/SnakeHunt2012/scikit-learn.git","svn_url":"https://github.com/SnakeHunt2012/scikit-learn","homepage":"http://scikit-learn.org","size":60941,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"6d5328b4655057d093040b1d1a41ac1656f55930","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","created_at":"2010-08-17T09:43:38Z","updated_at":"2015-05-05T01:34:27Z","pushed_at":"2015-05-05T01:34:57Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":123346,"stargazers_count":5896,"watchers_count":5896,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3517,"mirror_url":null,"open_issues_count":646,"forks":3517,"open_issues":646,"watchers":5896,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4621"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/4621"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4621"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4621/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4621/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4621/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/dc94a90df7e54ba97aaa1e95c5e6922f757b0fe6"}}}}