{"action":"created","issue":{"url":"https://api.github.com/repos/scp-fs2open/fs2open.github.com/issues/384","labels_url":"https://api.github.com/repos/scp-fs2open/fs2open.github.com/issues/384/labels{/name}","comments_url":"https://api.github.com/repos/scp-fs2open/fs2open.github.com/issues/384/comments","events_url":"https://api.github.com/repos/scp-fs2open/fs2open.github.com/issues/384/events","html_url":"https://github.com/scp-fs2open/fs2open.github.com/pull/384","id":113144491,"number":384,"title":"Better handling for mc_info","user":{"login":"The-E","id":280879,"avatar_url":"https://avatars.githubusercontent.com/u/280879?v=3","gravatar_id":"","url":"https://api.github.com/users/The-E","html_url":"https://github.com/The-E","followers_url":"https://api.github.com/users/The-E/followers","following_url":"https://api.github.com/users/The-E/following{/other_user}","gists_url":"https://api.github.com/users/The-E/gists{/gist_id}","starred_url":"https://api.github.com/users/The-E/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-E/subscriptions","organizations_url":"https://api.github.com/users/The-E/orgs","repos_url":"https://api.github.com/users/The-E/repos","events_url":"https://api.github.com/users/The-E/events{/privacy}","received_events_url":"https://api.github.com/users/The-E/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-10-24T08:01:34Z","updated_at":"2015-10-28T08:19:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scp-fs2open/fs2open.github.com/pulls/384","html_url":"https://github.com/scp-fs2open/fs2open.github.com/pull/384","diff_url":"https://github.com/scp-fs2open/fs2open.github.com/pull/384.diff","patch_url":"https://github.com/scp-fs2open/fs2open.github.com/pull/384.patch"},"body":"Discovered while testing unrelated things, there are conditions (notably in shipfx_eye_in_shadow) where a mc_info struct is being declared, but not initialized properly. Given that this sort of two-step thing is a really bad thing, and given that using memset to initialize everything to -1 is even worse, we should have a proper constructor for this struct that fills it with safe values."},"comment":{"url":"https://api.github.com/repos/scp-fs2open/fs2open.github.com/issues/comments/151760342","html_url":"https://github.com/scp-fs2open/fs2open.github.com/pull/384#issuecomment-151760342","issue_url":"https://api.github.com/repos/scp-fs2open/fs2open.github.com/issues/384","id":151760342,"user":{"login":"The-E","id":280879,"avatar_url":"https://avatars.githubusercontent.com/u/280879?v=3","gravatar_id":"","url":"https://api.github.com/users/The-E","html_url":"https://github.com/The-E","followers_url":"https://api.github.com/users/The-E/followers","following_url":"https://api.github.com/users/The-E/following{/other_user}","gists_url":"https://api.github.com/users/The-E/gists{/gist_id}","starred_url":"https://api.github.com/users/The-E/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-E/subscriptions","organizations_url":"https://api.github.com/users/The-E/orgs","repos_url":"https://api.github.com/users/The-E/repos","events_url":"https://api.github.com/users/The-E/events{/privacy}","received_events_url":"https://api.github.com/users/The-E/received_events","type":"User","site_admin":false},"created_at":"2015-10-28T08:19:01Z","updated_at":"2015-10-28T08:19:01Z","body":"On second thought, let's not do that if it causes everything to fall over like that."}}