{"action":"closed","number":5,"pull_request":{"url":"https://api.github.com/repos/OTRS/TimeAccounting/pulls/5","id":41581351,"html_url":"https://github.com/OTRS/TimeAccounting/pull/5","diff_url":"https://github.com/OTRS/TimeAccounting/pull/5.diff","patch_url":"https://github.com/OTRS/TimeAccounting/pull/5.patch","issue_url":"https://api.github.com/repos/OTRS/TimeAccounting/issues/5","number":5,"state":"closed","locked":false,"title":"Master - TimeAccounting port to OM","user":{"login":"s7design","id":6348760,"avatar_url":"https://avatars.githubusercontent.com/u/6348760?v=3","gravatar_id":"","url":"https://api.github.com/users/s7design","html_url":"https://github.com/s7design","followers_url":"https://api.github.com/users/s7design/followers","following_url":"https://api.github.com/users/s7design/following{/other_user}","gists_url":"https://api.github.com/users/s7design/gists{/gist_id}","starred_url":"https://api.github.com/users/s7design/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s7design/subscriptions","organizations_url":"https://api.github.com/users/s7design/orgs","repos_url":"https://api.github.com/users/s7design/repos","events_url":"https://api.github.com/users/s7design/events{/privacy}","received_events_url":"https://api.github.com/users/s7design/received_events","type":"User","site_admin":false},"body":"Hi @carlosfrodriguez \r\n\r\nHere is ported TimeAccounting to OM. \r\n\r\nWe also change the following tings:\r\n\r\n* in TimeAccounting.xml year is changed to 2015 TimeAccounting::DefaultUserDateStart and TimeAccounting::DefaultUserDateStart. Is it ok?\r\n* update to modern input fields. We have problem with jquery-combobox.js. After adding Morenize class and deleting Autocompletion: [% Data.EnableAutocompletion | html %] from AgentTimeAccountingEdit.tt, these specific select box fields work fine. I think that TimeAccounting.Agent.EditTimeRecords should be cleaned up because some Init function for dropdown is not needed anymore. \r\nWe had to change _ProjectList function in AgentTimeAccountingEdit.pm. Modern select box works different then the previous one. All projects are displayed two times.\r\n![screen shot 2015-08-04 at 3 40 43 pm](https://cloud.githubusercontent.com/assets/6348760/9064084/2f6cefaa-3acb-11e5-954b-b88c1c9246bc.png)\r\n\r\n* we fixed filters in AgentTimeAccountingSetting.tt like it is solved in the Framework\r\n\r\nThere is one more issue with width of input fields in Widget action. Dropdown fields in sidebar is wider than the other ones.\r\n![screen shot 2015-08-04 at 4 08 40 pm](https://cloud.githubusercontent.com/assets/6348760/9064162/8fbc407c-3acb-11e5-801d-78a2b29189e0.png)\r\n\r\nThe same in Admin Customer screens:\r\n![screen shot 2015-08-04 at 4 06 43 pm](https://cloud.githubusercontent.com/assets/6348760/9064181/9e0d841a-3acb-11e5-8438-71044a2a9d4e.png)\r\n\r\nI will be able to solve this for the Framework, and automatically it will be solved here. \r\n\r\nI know that there are many changes in the one PR, but only with all of these changes, TimeAccounting master is able to work properly now.\r\nIf you have any suggestion how we can help you maybe with splitting in more PRs or with additional improvement please let me know.\r\n\r\nRegards\r\nZoran \r\n\r\n\r\n","created_at":"2015-08-04T15:16:43Z","updated_at":"2015-08-05T18:30:14Z","closed_at":"2015-08-05T18:30:14Z","merged_at":null,"merge_commit_sha":"a136bac5447c4c5b62eeb857a67d9ea9c41a8e6f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OTRS/TimeAccounting/pulls/5/commits","review_comments_url":"https://api.github.com/repos/OTRS/TimeAccounting/pulls/5/comments","review_comment_url":"https://api.github.com/repos/OTRS/TimeAccounting/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OTRS/TimeAccounting/issues/5/comments","statuses_url":"https://api.github.com/repos/OTRS/TimeAccounting/statuses/99ed4bbe1b161ca135cab31f8a7991011b5bddc5","head":{"label":"s7design:master_port_OM","ref":"master_port_OM","sha":"99ed4bbe1b161ca135cab31f8a7991011b5bddc5","user":{"login":"s7design","id":6348760,"avatar_url":"https://avatars.githubusercontent.com/u/6348760?v=3","gravatar_id":"","url":"https://api.github.com/users/s7design","html_url":"https://github.com/s7design","followers_url":"https://api.github.com/users/s7design/followers","following_url":"https://api.github.com/users/s7design/following{/other_user}","gists_url":"https://api.github.com/users/s7design/gists{/gist_id}","starred_url":"https://api.github.com/users/s7design/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s7design/subscriptions","organizations_url":"https://api.github.com/users/s7design/orgs","repos_url":"https://api.github.com/users/s7design/repos","events_url":"https://api.github.com/users/s7design/events{/privacy}","received_events_url":"https://api.github.com/users/s7design/received_events","type":"User","site_admin":false},"repo":{"id":40123567,"name":"TimeAccounting","full_name":"s7design/TimeAccounting","owner":{"login":"s7design","id":6348760,"avatar_url":"https://avatars.githubusercontent.com/u/6348760?v=3","gravatar_id":"","url":"https://api.github.com/users/s7design","html_url":"https://github.com/s7design","followers_url":"https://api.github.com/users/s7design/followers","following_url":"https://api.github.com/users/s7design/following{/other_user}","gists_url":"https://api.github.com/users/s7design/gists{/gist_id}","starred_url":"https://api.github.com/users/s7design/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s7design/subscriptions","organizations_url":"https://api.github.com/users/s7design/orgs","repos_url":"https://api.github.com/users/s7design/repos","events_url":"https://api.github.com/users/s7design/events{/privacy}","received_events_url":"https://api.github.com/users/s7design/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/s7design/TimeAccounting","description":"A time accounting application to account time on projects.","fork":true,"url":"https://api.github.com/repos/s7design/TimeAccounting","forks_url":"https://api.github.com/repos/s7design/TimeAccounting/forks","keys_url":"https://api.github.com/repos/s7design/TimeAccounting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/s7design/TimeAccounting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/s7design/TimeAccounting/teams","hooks_url":"https://api.github.com/repos/s7design/TimeAccounting/hooks","issue_events_url":"https://api.github.com/repos/s7design/TimeAccounting/issues/events{/number}","events_url":"https://api.github.com/repos/s7design/TimeAccounting/events","assignees_url":"https://api.github.com/repos/s7design/TimeAccounting/assignees{/user}","branches_url":"https://api.github.com/repos/s7design/TimeAccounting/branches{/branch}","tags_url":"https://api.github.com/repos/s7design/TimeAccounting/tags","blobs_url":"https://api.github.com/repos/s7design/TimeAccounting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/s7design/TimeAccounting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/s7design/TimeAccounting/git/refs{/sha}","trees_url":"https://api.github.com/repos/s7design/TimeAccounting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/s7design/TimeAccounting/statuses/{sha}","languages_url":"https://api.github.com/repos/s7design/TimeAccounting/languages","stargazers_url":"https://api.github.com/repos/s7design/TimeAccounting/stargazers","contributors_url":"https://api.github.com/repos/s7design/TimeAccounting/contributors","subscribers_url":"https://api.github.com/repos/s7design/TimeAccounting/subscribers","subscription_url":"https://api.github.com/repos/s7design/TimeAccounting/subscription","commits_url":"https://api.github.com/repos/s7design/TimeAccounting/commits{/sha}","git_commits_url":"https://api.github.com/repos/s7design/TimeAccounting/git/commits{/sha}","comments_url":"https://api.github.com/repos/s7design/TimeAccounting/comments{/number}","issue_comment_url":"https://api.github.com/repos/s7design/TimeAccounting/issues/comments{/number}","contents_url":"https://api.github.com/repos/s7design/TimeAccounting/contents/{+path}","compare_url":"https://api.github.com/repos/s7design/TimeAccounting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/s7design/TimeAccounting/merges","archive_url":"https://api.github.com/repos/s7design/TimeAccounting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/s7design/TimeAccounting/downloads","issues_url":"https://api.github.com/repos/s7design/TimeAccounting/issues{/number}","pulls_url":"https://api.github.com/repos/s7design/TimeAccounting/pulls{/number}","milestones_url":"https://api.github.com/repos/s7design/TimeAccounting/milestones{/number}","notifications_url":"https://api.github.com/repos/s7design/TimeAccounting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/s7design/TimeAccounting/labels{/name}","releases_url":"https://api.github.com/repos/s7design/TimeAccounting/releases{/id}","created_at":"2015-08-03T12:30:07Z","updated_at":"2015-08-03T12:30:07Z","pushed_at":"2015-08-05T15:27:50Z","git_url":"git://github.com/s7design/TimeAccounting.git","ssh_url":"git@github.com:s7design/TimeAccounting.git","clone_url":"https://github.com/s7design/TimeAccounting.git","svn_url":"https://github.com/s7design/TimeAccounting","homepage":null,"size":1645,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OTRS:master","ref":"master","sha":"799a677c49932fe2e8608f76130fda785e92988e","user":{"login":"OTRS","id":3065906,"avatar_url":"https://avatars.githubusercontent.com/u/3065906?v=3","gravatar_id":"","url":"https://api.github.com/users/OTRS","html_url":"https://github.com/OTRS","followers_url":"https://api.github.com/users/OTRS/followers","following_url":"https://api.github.com/users/OTRS/following{/other_user}","gists_url":"https://api.github.com/users/OTRS/gists{/gist_id}","starred_url":"https://api.github.com/users/OTRS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OTRS/subscriptions","organizations_url":"https://api.github.com/users/OTRS/orgs","repos_url":"https://api.github.com/users/OTRS/repos","events_url":"https://api.github.com/users/OTRS/events{/privacy}","received_events_url":"https://api.github.com/users/OTRS/received_events","type":"Organization","site_admin":false},"repo":{"id":11345144,"name":"TimeAccounting","full_name":"OTRS/TimeAccounting","owner":{"login":"OTRS","id":3065906,"avatar_url":"https://avatars.githubusercontent.com/u/3065906?v=3","gravatar_id":"","url":"https://api.github.com/users/OTRS","html_url":"https://github.com/OTRS","followers_url":"https://api.github.com/users/OTRS/followers","following_url":"https://api.github.com/users/OTRS/following{/other_user}","gists_url":"https://api.github.com/users/OTRS/gists{/gist_id}","starred_url":"https://api.github.com/users/OTRS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OTRS/subscriptions","organizations_url":"https://api.github.com/users/OTRS/orgs","repos_url":"https://api.github.com/users/OTRS/repos","events_url":"https://api.github.com/users/OTRS/events{/privacy}","received_events_url":"https://api.github.com/users/OTRS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OTRS/TimeAccounting","description":"A time accounting application to account time on projects.","fork":false,"url":"https://api.github.com/repos/OTRS/TimeAccounting","forks_url":"https://api.github.com/repos/OTRS/TimeAccounting/forks","keys_url":"https://api.github.com/repos/OTRS/TimeAccounting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OTRS/TimeAccounting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OTRS/TimeAccounting/teams","hooks_url":"https://api.github.com/repos/OTRS/TimeAccounting/hooks","issue_events_url":"https://api.github.com/repos/OTRS/TimeAccounting/issues/events{/number}","events_url":"https://api.github.com/repos/OTRS/TimeAccounting/events","assignees_url":"https://api.github.com/repos/OTRS/TimeAccounting/assignees{/user}","branches_url":"https://api.github.com/repos/OTRS/TimeAccounting/branches{/branch}","tags_url":"https://api.github.com/repos/OTRS/TimeAccounting/tags","blobs_url":"https://api.github.com/repos/OTRS/TimeAccounting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OTRS/TimeAccounting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OTRS/TimeAccounting/git/refs{/sha}","trees_url":"https://api.github.com/repos/OTRS/TimeAccounting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OTRS/TimeAccounting/statuses/{sha}","languages_url":"https://api.github.com/repos/OTRS/TimeAccounting/languages","stargazers_url":"https://api.github.com/repos/OTRS/TimeAccounting/stargazers","contributors_url":"https://api.github.com/repos/OTRS/TimeAccounting/contributors","subscribers_url":"https://api.github.com/repos/OTRS/TimeAccounting/subscribers","subscription_url":"https://api.github.com/repos/OTRS/TimeAccounting/subscription","commits_url":"https://api.github.com/repos/OTRS/TimeAccounting/commits{/sha}","git_commits_url":"https://api.github.com/repos/OTRS/TimeAccounting/git/commits{/sha}","comments_url":"https://api.github.com/repos/OTRS/TimeAccounting/comments{/number}","issue_comment_url":"https://api.github.com/repos/OTRS/TimeAccounting/issues/comments{/number}","contents_url":"https://api.github.com/repos/OTRS/TimeAccounting/contents/{+path}","compare_url":"https://api.github.com/repos/OTRS/TimeAccounting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OTRS/TimeAccounting/merges","archive_url":"https://api.github.com/repos/OTRS/TimeAccounting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OTRS/TimeAccounting/downloads","issues_url":"https://api.github.com/repos/OTRS/TimeAccounting/issues{/number}","pulls_url":"https://api.github.com/repos/OTRS/TimeAccounting/pulls{/number}","milestones_url":"https://api.github.com/repos/OTRS/TimeAccounting/milestones{/number}","notifications_url":"https://api.github.com/repos/OTRS/TimeAccounting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OTRS/TimeAccounting/labels{/name}","releases_url":"https://api.github.com/repos/OTRS/TimeAccounting/releases{/id}","created_at":"2013-07-11T15:13:09Z","updated_at":"2015-01-01T19:15:20Z","pushed_at":"2015-08-05T18:27:48Z","git_url":"git://github.com/OTRS/TimeAccounting.git","ssh_url":"git@github.com:OTRS/TimeAccounting.git","clone_url":"https://github.com/OTRS/TimeAccounting.git","svn_url":"https://github.com/OTRS/TimeAccounting","homepage":null,"size":2403,"stargazers_count":3,"watchers_count":3,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OTRS/TimeAccounting/pulls/5"},"html":{"href":"https://github.com/OTRS/TimeAccounting/pull/5"},"issue":{"href":"https://api.github.com/repos/OTRS/TimeAccounting/issues/5"},"comments":{"href":"https://api.github.com/repos/OTRS/TimeAccounting/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/OTRS/TimeAccounting/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/OTRS/TimeAccounting/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OTRS/TimeAccounting/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/OTRS/TimeAccounting/statuses/99ed4bbe1b161ca135cab31f8a7991011b5bddc5"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":3,"review_comments":2,"commits":1,"additions":599,"deletions":560,"changed_files":18}}