{"action":"created","comment":{"url":"https://api.github.com/repos/slamdata/quasar/pulls/comments/39643733","id":39643733,"diff_hunk":"@@ -214,7 +221,7 @@ object WorkflowBuilder {\n   implicit def WorkflowBuilderEqualF = new EqualF[WorkflowBuilderF] {\n     def equal[A](v1: WorkflowBuilderF[A], v2: WorkflowBuilderF[A])(implicit A: Equal[A]) = (v1, v2) match {\n       case (CollectionBuilderF(g1, b1, s1), CollectionBuilderF(g2, b2, s2)) =>\n-        g1 == g2 && b1 == b2 && s1 === s2\n+        g1 == g2 && b1 == b2 && s1 == s2","path":"core/src/main/scala/slamdata/engine/physical/mongodb/workflowbuilder.scala","position":42,"original_position":42,"commit_id":"afe302bb8a6e48f8d65693ab56b54798475d202c","original_commit_id":"afe302bb8a6e48f8d65693ab56b54798475d202c","user":{"login":"sellout","id":33031,"avatar_url":"https://avatars.githubusercontent.com/u/33031?v=3","gravatar_id":"","url":"https://api.github.com/users/sellout","html_url":"https://github.com/sellout","followers_url":"https://api.github.com/users/sellout/followers","following_url":"https://api.github.com/users/sellout/following{/other_user}","gists_url":"https://api.github.com/users/sellout/gists{/gist_id}","starred_url":"https://api.github.com/users/sellout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sellout/subscriptions","organizations_url":"https://api.github.com/users/sellout/orgs","repos_url":"https://api.github.com/users/sellout/repos","events_url":"https://api.github.com/users/sellout/events{/privacy}","received_events_url":"https://api.github.com/users/sellout/received_events","type":"User","site_admin":false},"body":"And … `Equal[A]` found a place in WFB where we were comparing a `BsonField` to a `String`. Thanks, heterogeneous equality!","created_at":"2015-09-16T15:22:33Z","updated_at":"2015-09-16T15:22:33Z","html_url":"https://github.com/slamdata/quasar/pull/920#discussion_r39643733","pull_request_url":"https://api.github.com/repos/slamdata/quasar/pulls/920","_links":{"self":{"href":"https://api.github.com/repos/slamdata/quasar/pulls/comments/39643733"},"html":{"href":"https://github.com/slamdata/quasar/pull/920#discussion_r39643733"},"pull_request":{"href":"https://api.github.com/repos/slamdata/quasar/pulls/920"}}},"pull_request":{"url":"https://api.github.com/repos/slamdata/quasar/pulls/920","id":44895764,"html_url":"https://github.com/slamdata/quasar/pull/920","diff_url":"https://github.com/slamdata/quasar/pull/920.diff","patch_url":"https://github.com/slamdata/quasar/pull/920.patch","issue_url":"https://api.github.com/repos/slamdata/quasar/issues/920","number":920,"state":"open","locked":false,"title":"`distinct` without `Workflow`.","user":{"login":"sellout","id":33031,"avatar_url":"https://avatars.githubusercontent.com/u/33031?v=3","gravatar_id":"","url":"https://api.github.com/users/sellout","html_url":"https://github.com/sellout","followers_url":"https://api.github.com/users/sellout/followers","following_url":"https://api.github.com/users/sellout/following{/other_user}","gists_url":"https://api.github.com/users/sellout/gists{/gist_id}","starred_url":"https://api.github.com/users/sellout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sellout/subscriptions","organizations_url":"https://api.github.com/users/sellout/orgs","repos_url":"https://api.github.com/users/sellout/repos","events_url":"https://api.github.com/users/sellout/events{/privacy}","received_events_url":"https://api.github.com/users/sellout/received_events","type":"User","site_admin":false},"body":"SD-949 #done\r\n\r\nThis reimplements `distinctBy` (and adds `distinct`) without converting\r\nto `Workflow`. It also fixes some test cases that I _think_ should\r\nalready have been working, but were overlooked when #283 was fixed.\r\n\r\nMost significantly, the required replacing `DocVar` with `Base` for rewriting.\r\n\r\n`Base` is a richer abstraction that allows us to distinguish between an\r\nentire document (IE, DocVar.ROOT) and a subset of a document (which was\r\nnot distinguished from ROOT previously).\r\n\r\nThis required various other fixes to work properly:\r\n\r\n* add a NEL `apply` to `BsonField`,\r\n* render BSON as JS rather than `repr`,\r\n* move all of the `ExprBuilder` coalescing from `expr` to `normalize`,\r\n* extract `findKeys` from `distinct`,\r\n* move a couple `merge` cases that we preventing splices from unifying\r\n  properly,\r\n* use `apoM` instead of `topDownTransformM` in `normalize` (this prevents\r\n  double-processing (and thus failure) in the case when a substitution\r\n  contains a projection itself),\r\n* add `anaM` and `apoM` recursion schemes,\r\n* convert `Schema` elements from `String` to `BsonField.Name`,\r\n* eliminate an unused `fold1Builders` call, and\r\n* propagate the correct `Schema` from `GroupBuilder`s.","created_at":"2015-09-14T06:09:08Z","updated_at":"2015-09-16T15:22:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5705b1e339d8f3aa8fb6a1729c6aa9296a0a1cbb","assignee":{"login":"jedesah","id":1780116,"avatar_url":"https://avatars.githubusercontent.com/u/1780116?v=3","gravatar_id":"","url":"https://api.github.com/users/jedesah","html_url":"https://github.com/jedesah","followers_url":"https://api.github.com/users/jedesah/followers","following_url":"https://api.github.com/users/jedesah/following{/other_user}","gists_url":"https://api.github.com/users/jedesah/gists{/gist_id}","starred_url":"https://api.github.com/users/jedesah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedesah/subscriptions","organizations_url":"https://api.github.com/users/jedesah/orgs","repos_url":"https://api.github.com/users/jedesah/repos","events_url":"https://api.github.com/users/jedesah/events{/privacy}","received_events_url":"https://api.github.com/users/jedesah/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/slamdata/quasar/pulls/920/commits","review_comments_url":"https://api.github.com/repos/slamdata/quasar/pulls/920/comments","review_comment_url":"https://api.github.com/repos/slamdata/quasar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/slamdata/quasar/issues/920/comments","statuses_url":"https://api.github.com/repos/slamdata/quasar/statuses/afe302bb8a6e48f8d65693ab56b54798475d202c","head":{"label":"sellout:ready/simplify-distinct","ref":"ready/simplify-distinct","sha":"afe302bb8a6e48f8d65693ab56b54798475d202c","user":{"login":"sellout","id":33031,"avatar_url":"https://avatars.githubusercontent.com/u/33031?v=3","gravatar_id":"","url":"https://api.github.com/users/sellout","html_url":"https://github.com/sellout","followers_url":"https://api.github.com/users/sellout/followers","following_url":"https://api.github.com/users/sellout/following{/other_user}","gists_url":"https://api.github.com/users/sellout/gists{/gist_id}","starred_url":"https://api.github.com/users/sellout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sellout/subscriptions","organizations_url":"https://api.github.com/users/sellout/orgs","repos_url":"https://api.github.com/users/sellout/repos","events_url":"https://api.github.com/users/sellout/events{/privacy}","received_events_url":"https://api.github.com/users/sellout/received_events","type":"User","site_admin":false},"repo":{"id":21178230,"name":"slamengine","full_name":"sellout/slamengine","owner":{"login":"sellout","id":33031,"avatar_url":"https://avatars.githubusercontent.com/u/33031?v=3","gravatar_id":"","url":"https://api.github.com/users/sellout","html_url":"https://github.com/sellout","followers_url":"https://api.github.com/users/sellout/followers","following_url":"https://api.github.com/users/sellout/following{/other_user}","gists_url":"https://api.github.com/users/sellout/gists{/gist_id}","starred_url":"https://api.github.com/users/sellout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sellout/subscriptions","organizations_url":"https://api.github.com/users/sellout/orgs","repos_url":"https://api.github.com/users/sellout/repos","events_url":"https://api.github.com/users/sellout/events{/privacy}","received_events_url":"https://api.github.com/users/sellout/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sellout/slamengine","description":"The engine for SlamData","fork":true,"url":"https://api.github.com/repos/sellout/slamengine","forks_url":"https://api.github.com/repos/sellout/slamengine/forks","keys_url":"https://api.github.com/repos/sellout/slamengine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sellout/slamengine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sellout/slamengine/teams","hooks_url":"https://api.github.com/repos/sellout/slamengine/hooks","issue_events_url":"https://api.github.com/repos/sellout/slamengine/issues/events{/number}","events_url":"https://api.github.com/repos/sellout/slamengine/events","assignees_url":"https://api.github.com/repos/sellout/slamengine/assignees{/user}","branches_url":"https://api.github.com/repos/sellout/slamengine/branches{/branch}","tags_url":"https://api.github.com/repos/sellout/slamengine/tags","blobs_url":"https://api.github.com/repos/sellout/slamengine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sellout/slamengine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sellout/slamengine/git/refs{/sha}","trees_url":"https://api.github.com/repos/sellout/slamengine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sellout/slamengine/statuses/{sha}","languages_url":"https://api.github.com/repos/sellout/slamengine/languages","stargazers_url":"https://api.github.com/repos/sellout/slamengine/stargazers","contributors_url":"https://api.github.com/repos/sellout/slamengine/contributors","subscribers_url":"https://api.github.com/repos/sellout/slamengine/subscribers","subscription_url":"https://api.github.com/repos/sellout/slamengine/subscription","commits_url":"https://api.github.com/repos/sellout/slamengine/commits{/sha}","git_commits_url":"https://api.github.com/repos/sellout/slamengine/git/commits{/sha}","comments_url":"https://api.github.com/repos/sellout/slamengine/comments{/number}","issue_comment_url":"https://api.github.com/repos/sellout/slamengine/issues/comments{/number}","contents_url":"https://api.github.com/repos/sellout/slamengine/contents/{+path}","compare_url":"https://api.github.com/repos/sellout/slamengine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sellout/slamengine/merges","archive_url":"https://api.github.com/repos/sellout/slamengine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sellout/slamengine/downloads","issues_url":"https://api.github.com/repos/sellout/slamengine/issues{/number}","pulls_url":"https://api.github.com/repos/sellout/slamengine/pulls{/number}","milestones_url":"https://api.github.com/repos/sellout/slamengine/milestones{/number}","notifications_url":"https://api.github.com/repos/sellout/slamengine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sellout/slamengine/labels{/name}","releases_url":"https://api.github.com/repos/sellout/slamengine/releases{/id}","created_at":"2014-06-24T19:38:07Z","updated_at":"2014-09-08T15:39:05Z","pushed_at":"2015-09-15T04:21:57Z","git_url":"git://github.com/sellout/slamengine.git","ssh_url":"git@github.com:sellout/slamengine.git","clone_url":"https://github.com/sellout/slamengine.git","svn_url":"https://github.com/sellout/slamengine","homepage":null,"size":8813,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CHECK-UPSTREAM-REPO"}},"base":{"label":"slamdata:master","ref":"master","sha":"8c243e59071c11b58d679709a8de3949ea7f274b","user":{"login":"slamdata","id":5385602,"avatar_url":"https://avatars.githubusercontent.com/u/5385602?v=3","gravatar_id":"","url":"https://api.github.com/users/slamdata","html_url":"https://github.com/slamdata","followers_url":"https://api.github.com/users/slamdata/followers","following_url":"https://api.github.com/users/slamdata/following{/other_user}","gists_url":"https://api.github.com/users/slamdata/gists{/gist_id}","starred_url":"https://api.github.com/users/slamdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slamdata/subscriptions","organizations_url":"https://api.github.com/users/slamdata/orgs","repos_url":"https://api.github.com/users/slamdata/repos","events_url":"https://api.github.com/users/slamdata/events{/privacy}","received_events_url":"https://api.github.com/users/slamdata/received_events","type":"Organization","site_admin":false},"repo":{"id":16515058,"name":"quasar","full_name":"slamdata/quasar","owner":{"login":"slamdata","id":5385602,"avatar_url":"https://avatars.githubusercontent.com/u/5385602?v=3","gravatar_id":"","url":"https://api.github.com/users/slamdata","html_url":"https://github.com/slamdata","followers_url":"https://api.github.com/users/slamdata/followers","following_url":"https://api.github.com/users/slamdata/following{/other_user}","gists_url":"https://api.github.com/users/slamdata/gists{/gist_id}","starred_url":"https://api.github.com/users/slamdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slamdata/subscriptions","organizations_url":"https://api.github.com/users/slamdata/orgs","repos_url":"https://api.github.com/users/slamdata/repos","events_url":"https://api.github.com/users/slamdata/events{/privacy}","received_events_url":"https://api.github.com/users/slamdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slamdata/quasar","description":"A NoSQL analytics engine that embraces post-relational analytics and pushes computation to the data.","fork":false,"url":"https://api.github.com/repos/slamdata/quasar","forks_url":"https://api.github.com/repos/slamdata/quasar/forks","keys_url":"https://api.github.com/repos/slamdata/quasar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slamdata/quasar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slamdata/quasar/teams","hooks_url":"https://api.github.com/repos/slamdata/quasar/hooks","issue_events_url":"https://api.github.com/repos/slamdata/quasar/issues/events{/number}","events_url":"https://api.github.com/repos/slamdata/quasar/events","assignees_url":"https://api.github.com/repos/slamdata/quasar/assignees{/user}","branches_url":"https://api.github.com/repos/slamdata/quasar/branches{/branch}","tags_url":"https://api.github.com/repos/slamdata/quasar/tags","blobs_url":"https://api.github.com/repos/slamdata/quasar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slamdata/quasar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slamdata/quasar/git/refs{/sha}","trees_url":"https://api.github.com/repos/slamdata/quasar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slamdata/quasar/statuses/{sha}","languages_url":"https://api.github.com/repos/slamdata/quasar/languages","stargazers_url":"https://api.github.com/repos/slamdata/quasar/stargazers","contributors_url":"https://api.github.com/repos/slamdata/quasar/contributors","subscribers_url":"https://api.github.com/repos/slamdata/quasar/subscribers","subscription_url":"https://api.github.com/repos/slamdata/quasar/subscription","commits_url":"https://api.github.com/repos/slamdata/quasar/commits{/sha}","git_commits_url":"https://api.github.com/repos/slamdata/quasar/git/commits{/sha}","comments_url":"https://api.github.com/repos/slamdata/quasar/comments{/number}","issue_comment_url":"https://api.github.com/repos/slamdata/quasar/issues/comments{/number}","contents_url":"https://api.github.com/repos/slamdata/quasar/contents/{+path}","compare_url":"https://api.github.com/repos/slamdata/quasar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slamdata/quasar/merges","archive_url":"https://api.github.com/repos/slamdata/quasar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slamdata/quasar/downloads","issues_url":"https://api.github.com/repos/slamdata/quasar/issues{/number}","pulls_url":"https://api.github.com/repos/slamdata/quasar/pulls{/number}","milestones_url":"https://api.github.com/repos/slamdata/quasar/milestones{/number}","notifications_url":"https://api.github.com/repos/slamdata/quasar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slamdata/quasar/labels{/name}","releases_url":"https://api.github.com/repos/slamdata/quasar/releases{/id}","created_at":"2014-02-04T15:01:27Z","updated_at":"2015-09-15T16:03:33Z","pushed_at":"2015-09-16T00:27:48Z","git_url":"git://github.com/slamdata/quasar.git","ssh_url":"git@github.com:slamdata/quasar.git","clone_url":"https://github.com/slamdata/quasar.git","svn_url":"https://github.com/slamdata/quasar","homepage":"","size":10764,"stargazers_count":142,"watchers_count":142,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":163,"forks":36,"open_issues":163,"watchers":142,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/slamdata/quasar/pulls/920"},"html":{"href":"https://github.com/slamdata/quasar/pull/920"},"issue":{"href":"https://api.github.com/repos/slamdata/quasar/issues/920"},"comments":{"href":"https://api.github.com/repos/slamdata/quasar/issues/920/comments"},"review_comments":{"href":"https://api.github.com/repos/slamdata/quasar/pulls/920/comments"},"review_comment":{"href":"https://api.github.com/repos/slamdata/quasar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/slamdata/quasar/pulls/920/commits"},"statuses":{"href":"https://api.github.com/repos/slamdata/quasar/statuses/afe302bb8a6e48f8d65693ab56b54798475d202c"}}}}