{"action":"created","comment":{"url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/pulls/comments/33241549","id":33241549,"diff_hunk":"@@ -18,10 +18,14 @@ LoadPlugin df\n       Device \"{{ device }}\"\n {%- endfor %}\n {%- if collectd_settings.plugins.df.MountPoint is defined and collectd_settings.plugins.df.MountPoint %}\n-      MountPoint \"{{ collectd_settings.plugins.df.MountPoint }}\"\n+    {%- for mountpoint in collectd_settings.plugins.df.MountPoints %}\n+      MountPoint \"{{ mountpoint }}\"\n+    {%- endfor %}\n {%- endif %}\n {%- if collectd_settings.plugins.df.FSType is defined and collectd_settings.plugins.df.FSType %}\n-      FSType \"{{ collectd_settings.plugins.df.FSType }}\"\n+    {%- for fstype in collectd_settings.plugins.df.FSTypes %}","path":"collectd/files/df.conf","position":11,"original_position":11,"commit_id":"15f0c454290c1578b75420f849dac499a075d80c","original_commit_id":"15f0c454290c1578b75420f849dac499a075d80c","user":{"login":"genuss","id":3119969,"avatar_url":"https://avatars.githubusercontent.com/u/3119969?v=3","gravatar_id":"","url":"https://api.github.com/users/genuss","html_url":"https://github.com/genuss","followers_url":"https://api.github.com/users/genuss/followers","following_url":"https://api.github.com/users/genuss/following{/other_user}","gists_url":"https://api.github.com/users/genuss/gists{/gist_id}","starred_url":"https://api.github.com/users/genuss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genuss/subscriptions","organizations_url":"https://api.github.com/users/genuss/orgs","repos_url":"https://api.github.com/users/genuss/repos","events_url":"https://api.github.com/users/genuss/events{/privacy}","received_events_url":"https://api.github.com/users/genuss/received_events","type":"User","site_admin":false},"body":"Same here!","created_at":"2015-06-25T10:34:53Z","updated_at":"2015-06-25T10:34:53Z","html_url":"https://github.com/saltstack-formulas/collectd-formula/pull/43#discussion_r33241549","pull_request_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/pulls/43","_links":{"self":{"href":"https://api.github.com/repos/saltstack-formulas/collectd-formula/pulls/comments/33241549"},"html":{"href":"https://github.com/saltstack-formulas/collectd-formula/pull/43#discussion_r33241549"},"pull_request":{"href":"https://api.github.com/repos/saltstack-formulas/collectd-formula/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/pulls/43","id":38481220,"html_url":"https://github.com/saltstack-formulas/collectd-formula/pull/43","diff_url":"https://github.com/saltstack-formulas/collectd-formula/pull/43.diff","patch_url":"https://github.com/saltstack-formulas/collectd-formula/pull/43.patch","issue_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/issues/43","number":43,"state":"closed","locked":false,"title":"'FSType' and 'Mountpoint' should be multivalue in the df config","user":{"login":"colekowalski","id":320670,"avatar_url":"https://avatars.githubusercontent.com/u/320670?v=3","gravatar_id":"","url":"https://api.github.com/users/colekowalski","html_url":"https://github.com/colekowalski","followers_url":"https://api.github.com/users/colekowalski/followers","following_url":"https://api.github.com/users/colekowalski/following{/other_user}","gists_url":"https://api.github.com/users/colekowalski/gists{/gist_id}","starred_url":"https://api.github.com/users/colekowalski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colekowalski/subscriptions","organizations_url":"https://api.github.com/users/colekowalski/orgs","repos_url":"https://api.github.com/users/colekowalski/repos","events_url":"https://api.github.com/users/colekowalski/events{/privacy}","received_events_url":"https://api.github.com/users/colekowalski/received_events","type":"User","site_admin":false},"body":"This change allows multiple values to be specified for both the FSType and Mountpoint parameters. \r\n\r\nI pluralized the items in the pillar to more clearly indicate that it is a multivalue list, and to keep the field consistent with 'Devices' which already accepted multiple values. Unfortunately this may break existing pillar configurations.","created_at":"2015-06-24T20:01:10Z","updated_at":"2015-06-25T10:34:53Z","closed_at":"2015-06-24T20:02:20Z","merged_at":"2015-06-24T20:02:20Z","merge_commit_sha":"d96d5c55ed09c06069daee6ca58e43cfe3ca715e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/pulls/43/commits","review_comments_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/pulls/43/comments","review_comment_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/issues/43/comments","statuses_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/statuses/15f0c454290c1578b75420f849dac499a075d80c","head":{"label":"colekowalski:df-multivalue","ref":"df-multivalue","sha":"15f0c454290c1578b75420f849dac499a075d80c","user":{"login":"colekowalski","id":320670,"avatar_url":"https://avatars.githubusercontent.com/u/320670?v=3","gravatar_id":"","url":"https://api.github.com/users/colekowalski","html_url":"https://github.com/colekowalski","followers_url":"https://api.github.com/users/colekowalski/followers","following_url":"https://api.github.com/users/colekowalski/following{/other_user}","gists_url":"https://api.github.com/users/colekowalski/gists{/gist_id}","starred_url":"https://api.github.com/users/colekowalski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colekowalski/subscriptions","organizations_url":"https://api.github.com/users/colekowalski/orgs","repos_url":"https://api.github.com/users/colekowalski/repos","events_url":"https://api.github.com/users/colekowalski/events{/privacy}","received_events_url":"https://api.github.com/users/colekowalski/received_events","type":"User","site_admin":false},"repo":{"id":38006595,"name":"collectd-formula","full_name":"colekowalski/collectd-formula","owner":{"login":"colekowalski","id":320670,"avatar_url":"https://avatars.githubusercontent.com/u/320670?v=3","gravatar_id":"","url":"https://api.github.com/users/colekowalski","html_url":"https://github.com/colekowalski","followers_url":"https://api.github.com/users/colekowalski/followers","following_url":"https://api.github.com/users/colekowalski/following{/other_user}","gists_url":"https://api.github.com/users/colekowalski/gists{/gist_id}","starred_url":"https://api.github.com/users/colekowalski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colekowalski/subscriptions","organizations_url":"https://api.github.com/users/colekowalski/orgs","repos_url":"https://api.github.com/users/colekowalski/repos","events_url":"https://api.github.com/users/colekowalski/events{/privacy}","received_events_url":"https://api.github.com/users/colekowalski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/colekowalski/collectd-formula","description":null,"fork":true,"url":"https://api.github.com/repos/colekowalski/collectd-formula","forks_url":"https://api.github.com/repos/colekowalski/collectd-formula/forks","keys_url":"https://api.github.com/repos/colekowalski/collectd-formula/keys{/key_id}","collaborators_url":"https://api.github.com/repos/colekowalski/collectd-formula/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/colekowalski/collectd-formula/teams","hooks_url":"https://api.github.com/repos/colekowalski/collectd-formula/hooks","issue_events_url":"https://api.github.com/repos/colekowalski/collectd-formula/issues/events{/number}","events_url":"https://api.github.com/repos/colekowalski/collectd-formula/events","assignees_url":"https://api.github.com/repos/colekowalski/collectd-formula/assignees{/user}","branches_url":"https://api.github.com/repos/colekowalski/collectd-formula/branches{/branch}","tags_url":"https://api.github.com/repos/colekowalski/collectd-formula/tags","blobs_url":"https://api.github.com/repos/colekowalski/collectd-formula/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/colekowalski/collectd-formula/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/colekowalski/collectd-formula/git/refs{/sha}","trees_url":"https://api.github.com/repos/colekowalski/collectd-formula/git/trees{/sha}","statuses_url":"https://api.github.com/repos/colekowalski/collectd-formula/statuses/{sha}","languages_url":"https://api.github.com/repos/colekowalski/collectd-formula/languages","stargazers_url":"https://api.github.com/repos/colekowalski/collectd-formula/stargazers","contributors_url":"https://api.github.com/repos/colekowalski/collectd-formula/contributors","subscribers_url":"https://api.github.com/repos/colekowalski/collectd-formula/subscribers","subscription_url":"https://api.github.com/repos/colekowalski/collectd-formula/subscription","commits_url":"https://api.github.com/repos/colekowalski/collectd-formula/commits{/sha}","git_commits_url":"https://api.github.com/repos/colekowalski/collectd-formula/git/commits{/sha}","comments_url":"https://api.github.com/repos/colekowalski/collectd-formula/comments{/number}","issue_comment_url":"https://api.github.com/repos/colekowalski/collectd-formula/issues/comments{/number}","contents_url":"https://api.github.com/repos/colekowalski/collectd-formula/contents/{+path}","compare_url":"https://api.github.com/repos/colekowalski/collectd-formula/compare/{base}...{head}","merges_url":"https://api.github.com/repos/colekowalski/collectd-formula/merges","archive_url":"https://api.github.com/repos/colekowalski/collectd-formula/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/colekowalski/collectd-formula/downloads","issues_url":"https://api.github.com/repos/colekowalski/collectd-formula/issues{/number}","pulls_url":"https://api.github.com/repos/colekowalski/collectd-formula/pulls{/number}","milestones_url":"https://api.github.com/repos/colekowalski/collectd-formula/milestones{/number}","notifications_url":"https://api.github.com/repos/colekowalski/collectd-formula/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/colekowalski/collectd-formula/labels{/name}","releases_url":"https://api.github.com/repos/colekowalski/collectd-formula/releases{/id}","created_at":"2015-06-24T19:35:01Z","updated_at":"2015-06-24T19:35:02Z","pushed_at":"2015-06-24T20:41:19Z","git_url":"git://github.com/colekowalski/collectd-formula.git","ssh_url":"git@github.com:colekowalski/collectd-formula.git","clone_url":"https://github.com/colekowalski/collectd-formula.git","svn_url":"https://github.com/colekowalski/collectd-formula","homepage":"http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html","size":160,"stargazers_count":0,"watchers_count":0,"language":"SaltStack","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"saltstack-formulas:master","ref":"master","sha":"8305e08babc3b3ea6cdf7e8d5b0753366ad180e1","user":{"login":"saltstack-formulas","id":4683350,"avatar_url":"https://avatars.githubusercontent.com/u/4683350?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack-formulas","html_url":"https://github.com/saltstack-formulas","followers_url":"https://api.github.com/users/saltstack-formulas/followers","following_url":"https://api.github.com/users/saltstack-formulas/following{/other_user}","gists_url":"https://api.github.com/users/saltstack-formulas/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack-formulas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack-formulas/subscriptions","organizations_url":"https://api.github.com/users/saltstack-formulas/orgs","repos_url":"https://api.github.com/users/saltstack-formulas/repos","events_url":"https://api.github.com/users/saltstack-formulas/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack-formulas/received_events","type":"Organization","site_admin":false},"repo":{"id":23077805,"name":"collectd-formula","full_name":"saltstack-formulas/collectd-formula","owner":{"login":"saltstack-formulas","id":4683350,"avatar_url":"https://avatars.githubusercontent.com/u/4683350?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack-formulas","html_url":"https://github.com/saltstack-formulas","followers_url":"https://api.github.com/users/saltstack-formulas/followers","following_url":"https://api.github.com/users/saltstack-formulas/following{/other_user}","gists_url":"https://api.github.com/users/saltstack-formulas/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack-formulas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack-formulas/subscriptions","organizations_url":"https://api.github.com/users/saltstack-formulas/orgs","repos_url":"https://api.github.com/users/saltstack-formulas/repos","events_url":"https://api.github.com/users/saltstack-formulas/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack-formulas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack-formulas/collectd-formula","description":null,"fork":false,"url":"https://api.github.com/repos/saltstack-formulas/collectd-formula","forks_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/forks","keys_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/teams","hooks_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/hooks","issue_events_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/events","assignees_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/tags","blobs_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/languages","stargazers_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/stargazers","contributors_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/contributors","subscribers_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/subscribers","subscription_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/subscription","commits_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/merges","archive_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/downloads","issues_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/labels{/name}","releases_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/releases{/id}","created_at":"2014-08-18T16:09:47Z","updated_at":"2015-06-03T10:31:42Z","pushed_at":"2015-06-24T20:39:54Z","git_url":"git://github.com/saltstack-formulas/collectd-formula.git","ssh_url":"git@github.com:saltstack-formulas/collectd-formula.git","clone_url":"https://github.com/saltstack-formulas/collectd-formula.git","svn_url":"https://github.com/saltstack-formulas/collectd-formula","homepage":"http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html","size":442,"stargazers_count":7,"watchers_count":7,"language":"SaltStack","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":5,"forks":22,"open_issues":5,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack-formulas/collectd-formula/pulls/43"},"html":{"href":"https://github.com/saltstack-formulas/collectd-formula/pull/43"},"issue":{"href":"https://api.github.com/repos/saltstack-formulas/collectd-formula/issues/43"},"comments":{"href":"https://api.github.com/repos/saltstack-formulas/collectd-formula/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack-formulas/collectd-formula/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack-formulas/collectd-formula/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack-formulas/collectd-formula/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack-formulas/collectd-formula/statuses/15f0c454290c1578b75420f849dac499a075d80c"}}}}