{"action":"created","comment":{"url":"https://api.github.com/repos/biocore/qiita/pulls/comments/24844682","id":24844682,"diff_hunk":"@@ -212,14 +175,26 @@ def render(self, prep, study_id, is_editable, ena_terms,\n         preprocessing_status = prep.preprocessing_status\n \n         if raw_data.filetype in ('SFF', 'FASTA'):\n-            preprocess_form = Preprocess454ParametersForm()\n+            all_params = Preprocessed454Params.get_all_parameters()\n         elif raw_data.filetype == 'FASTQ':\n-            preprocess_form = PreprocessIlluminaParametersForm()\n+            all_params = PreprocessIlluminaParametersForm.get_all_parameters()\n         else:\n             raise ValueError(\"Don't know what to do but this exception will \"\n                              \"never actually get shown anywhere because why \"\n                              \"would you want to see tracebacks?\")\n \n+        preprocess_options = []\n+        for param in all_params:\n+            text = []\n+            for k, v in viewitems(param):\n+                if k in ('preprocessed_params_id', 'param_set_name'):","path":"qiita_pet/uimodules/raw_data_tab.py","position":73,"original_position":73,"commit_id":"8f4773bad54be2b6eab30f1a0cd477bd206cbd50","original_commit_id":"8f4773bad54be2b6eab30f1a0cd477bd206cbd50","user":{"login":"ElDeveloper","id":375307,"avatar_url":"https://avatars.githubusercontent.com/u/375307?v=3","gravatar_id":"","url":"https://api.github.com/users/ElDeveloper","html_url":"https://github.com/ElDeveloper","followers_url":"https://api.github.com/users/ElDeveloper/followers","following_url":"https://api.github.com/users/ElDeveloper/following{/other_user}","gists_url":"https://api.github.com/users/ElDeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/ElDeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElDeveloper/subscriptions","organizations_url":"https://api.github.com/users/ElDeveloper/orgs","repos_url":"https://api.github.com/users/ElDeveloper/repos","events_url":"https://api.github.com/users/ElDeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/ElDeveloper/received_events","type":"User","site_admin":false},"body":"God dammit :L\n\nOn (Feb-17-15|11:19), Daniel McDonald wrote:\n> >          else:\n> >              raise ValueError(\"Don't know what to do but this exception will \"\n> >                               \"never actually get shown anywhere because why \"\n> >                               \"would you want to see tracebacks?\")\n> >  \n> > +        preprocess_options = []\n> > +        for param in all_params:\n> > +            text = []\n> > +            for k, v in viewitems(param):\n> > +                if k in ('preprocessed_params_id', 'param_set_name'):\n> \n> For that size, a `set` would more likely increase overhead\n> \n> ---\n> Reply to this email directly or view it on GitHub:\n> https://github.com/biocore/qiita/pull/859/files#r24844551\n","created_at":"2015-02-17T19:21:18Z","updated_at":"2015-02-17T19:21:18Z","html_url":"https://github.com/biocore/qiita/pull/859#discussion_r24844682","pull_request_url":"https://api.github.com/repos/biocore/qiita/pulls/859","_links":{"self":{"href":"https://api.github.com/repos/biocore/qiita/pulls/comments/24844682"},"html":{"href":"https://github.com/biocore/qiita/pull/859#discussion_r24844682"},"pull_request":{"href":"https://api.github.com/repos/biocore/qiita/pulls/859"}}},"pull_request":{"url":"https://api.github.com/repos/biocore/qiita/pulls/859","id":29468424,"html_url":"https://github.com/biocore/qiita/pull/859","diff_url":"https://github.com/biocore/qiita/pull/859.diff","patch_url":"https://github.com/biocore/qiita/pull/859.patch","issue_url":"https://api.github.com/repos/biocore/qiita/issues/859","number":859,"state":"open","locked":false,"title":"Adding easy preprocessing parameters","user":{"login":"antgonza","id":2014559,"avatar_url":"https://avatars.githubusercontent.com/u/2014559?v=3","gravatar_id":"","url":"https://api.github.com/users/antgonza","html_url":"https://github.com/antgonza","followers_url":"https://api.github.com/users/antgonza/followers","following_url":"https://api.github.com/users/antgonza/following{/other_user}","gists_url":"https://api.github.com/users/antgonza/gists{/gist_id}","starred_url":"https://api.github.com/users/antgonza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antgonza/subscriptions","organizations_url":"https://api.github.com/users/antgonza/orgs","repos_url":"https://api.github.com/users/antgonza/repos","events_url":"https://api.github.com/users/antgonza/events{/privacy}","received_events_url":"https://api.github.com/users/antgonza/received_events","type":"User","site_admin":false},"body":"A collaborator under a deadline (thus, quick reviews will be greatly appreciated) asked me to allow for other preprocessing parameters (change the size of the barcode) but realized that doing this was gonna be a pain as we needed to change both the GUI and the database.\r\n\r\nThis PR allows to single add a new preprocessing in the DB and the GUI will recognize it. Currently only works for preprocess data but after chatting with @josenavas I realized that we can do the same for processing, which I will do after seeing what people think.","created_at":"2015-02-17T19:07:38Z","updated_at":"2015-02-17T19:21:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ca8bada4d854cc075341d44e70f0b9951434b57","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/biocore/qiita/pulls/859/commits","review_comments_url":"https://api.github.com/repos/biocore/qiita/pulls/859/comments","review_comment_url":"https://api.github.com/repos/biocore/qiita/pulls/comments/{number}","comments_url":"https://api.github.com/repos/biocore/qiita/issues/859/comments","statuses_url":"https://api.github.com/repos/biocore/qiita/statuses/8f4773bad54be2b6eab30f1a0cd477bd206cbd50","head":{"label":"antgonza:adding-easy-preprocessing-parameters","ref":"adding-easy-preprocessing-parameters","sha":"8f4773bad54be2b6eab30f1a0cd477bd206cbd50","user":{"login":"antgonza","id":2014559,"avatar_url":"https://avatars.githubusercontent.com/u/2014559?v=3","gravatar_id":"","url":"https://api.github.com/users/antgonza","html_url":"https://github.com/antgonza","followers_url":"https://api.github.com/users/antgonza/followers","following_url":"https://api.github.com/users/antgonza/following{/other_user}","gists_url":"https://api.github.com/users/antgonza/gists{/gist_id}","starred_url":"https://api.github.com/users/antgonza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antgonza/subscriptions","organizations_url":"https://api.github.com/users/antgonza/orgs","repos_url":"https://api.github.com/users/antgonza/repos","events_url":"https://api.github.com/users/antgonza/events{/privacy}","received_events_url":"https://api.github.com/users/antgonza/received_events","type":"User","site_admin":false},"repo":{"id":16964638,"name":"qiita","full_name":"antgonza/qiita","owner":{"login":"antgonza","id":2014559,"avatar_url":"https://avatars.githubusercontent.com/u/2014559?v=3","gravatar_id":"","url":"https://api.github.com/users/antgonza","html_url":"https://github.com/antgonza","followers_url":"https://api.github.com/users/antgonza/followers","following_url":"https://api.github.com/users/antgonza/following{/other_user}","gists_url":"https://api.github.com/users/antgonza/gists{/gist_id}","starred_url":"https://api.github.com/users/antgonza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antgonza/subscriptions","organizations_url":"https://api.github.com/users/antgonza/orgs","repos_url":"https://api.github.com/users/antgonza/repos","events_url":"https://api.github.com/users/antgonza/events{/privacy}","received_events_url":"https://api.github.com/users/antgonza/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/antgonza/qiita","description":"Qiita - A QIIME databasing effort","fork":true,"url":"https://api.github.com/repos/antgonza/qiita","forks_url":"https://api.github.com/repos/antgonza/qiita/forks","keys_url":"https://api.github.com/repos/antgonza/qiita/keys{/key_id}","collaborators_url":"https://api.github.com/repos/antgonza/qiita/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/antgonza/qiita/teams","hooks_url":"https://api.github.com/repos/antgonza/qiita/hooks","issue_events_url":"https://api.github.com/repos/antgonza/qiita/issues/events{/number}","events_url":"https://api.github.com/repos/antgonza/qiita/events","assignees_url":"https://api.github.com/repos/antgonza/qiita/assignees{/user}","branches_url":"https://api.github.com/repos/antgonza/qiita/branches{/branch}","tags_url":"https://api.github.com/repos/antgonza/qiita/tags","blobs_url":"https://api.github.com/repos/antgonza/qiita/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/antgonza/qiita/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/antgonza/qiita/git/refs{/sha}","trees_url":"https://api.github.com/repos/antgonza/qiita/git/trees{/sha}","statuses_url":"https://api.github.com/repos/antgonza/qiita/statuses/{sha}","languages_url":"https://api.github.com/repos/antgonza/qiita/languages","stargazers_url":"https://api.github.com/repos/antgonza/qiita/stargazers","contributors_url":"https://api.github.com/repos/antgonza/qiita/contributors","subscribers_url":"https://api.github.com/repos/antgonza/qiita/subscribers","subscription_url":"https://api.github.com/repos/antgonza/qiita/subscription","commits_url":"https://api.github.com/repos/antgonza/qiita/commits{/sha}","git_commits_url":"https://api.github.com/repos/antgonza/qiita/git/commits{/sha}","comments_url":"https://api.github.com/repos/antgonza/qiita/comments{/number}","issue_comment_url":"https://api.github.com/repos/antgonza/qiita/issues/comments/{number}","contents_url":"https://api.github.com/repos/antgonza/qiita/contents/{+path}","compare_url":"https://api.github.com/repos/antgonza/qiita/compare/{base}...{head}","merges_url":"https://api.github.com/repos/antgonza/qiita/merges","archive_url":"https://api.github.com/repos/antgonza/qiita/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/antgonza/qiita/downloads","issues_url":"https://api.github.com/repos/antgonza/qiita/issues{/number}","pulls_url":"https://api.github.com/repos/antgonza/qiita/pulls{/number}","milestones_url":"https://api.github.com/repos/antgonza/qiita/milestones{/number}","notifications_url":"https://api.github.com/repos/antgonza/qiita/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/antgonza/qiita/labels{/name}","releases_url":"https://api.github.com/repos/antgonza/qiita/releases{/id}","created_at":"2014-02-18T21:38:48Z","updated_at":"2015-02-16T17:31:01Z","pushed_at":"2015-02-17T18:54:17Z","git_url":"git://github.com/antgonza/qiita.git","ssh_url":"git@github.com:antgonza/qiita.git","clone_url":"https://github.com/antgonza/qiita.git","svn_url":"https://github.com/antgonza/qiita","homepage":"","size":115100,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"biocore:master","ref":"master","sha":"d3984140ab3db185920f473710da53c2587aee49","user":{"login":"biocore","id":6241857,"avatar_url":"https://avatars.githubusercontent.com/u/6241857?v=3","gravatar_id":"","url":"https://api.github.com/users/biocore","html_url":"https://github.com/biocore","followers_url":"https://api.github.com/users/biocore/followers","following_url":"https://api.github.com/users/biocore/following{/other_user}","gists_url":"https://api.github.com/users/biocore/gists{/gist_id}","starred_url":"https://api.github.com/users/biocore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biocore/subscriptions","organizations_url":"https://api.github.com/users/biocore/orgs","repos_url":"https://api.github.com/users/biocore/repos","events_url":"https://api.github.com/users/biocore/events{/privacy}","received_events_url":"https://api.github.com/users/biocore/received_events","type":"Organization","site_admin":false},"repo":{"id":13131245,"name":"qiita","full_name":"biocore/qiita","owner":{"login":"biocore","id":6241857,"avatar_url":"https://avatars.githubusercontent.com/u/6241857?v=3","gravatar_id":"","url":"https://api.github.com/users/biocore","html_url":"https://github.com/biocore","followers_url":"https://api.github.com/users/biocore/followers","following_url":"https://api.github.com/users/biocore/following{/other_user}","gists_url":"https://api.github.com/users/biocore/gists{/gist_id}","starred_url":"https://api.github.com/users/biocore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biocore/subscriptions","organizations_url":"https://api.github.com/users/biocore/orgs","repos_url":"https://api.github.com/users/biocore/repos","events_url":"https://api.github.com/users/biocore/events{/privacy}","received_events_url":"https://api.github.com/users/biocore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/biocore/qiita","description":"Qiita - A QIIME databasing effort","fork":false,"url":"https://api.github.com/repos/biocore/qiita","forks_url":"https://api.github.com/repos/biocore/qiita/forks","keys_url":"https://api.github.com/repos/biocore/qiita/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biocore/qiita/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biocore/qiita/teams","hooks_url":"https://api.github.com/repos/biocore/qiita/hooks","issue_events_url":"https://api.github.com/repos/biocore/qiita/issues/events{/number}","events_url":"https://api.github.com/repos/biocore/qiita/events","assignees_url":"https://api.github.com/repos/biocore/qiita/assignees{/user}","branches_url":"https://api.github.com/repos/biocore/qiita/branches{/branch}","tags_url":"https://api.github.com/repos/biocore/qiita/tags","blobs_url":"https://api.github.com/repos/biocore/qiita/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biocore/qiita/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biocore/qiita/git/refs{/sha}","trees_url":"https://api.github.com/repos/biocore/qiita/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biocore/qiita/statuses/{sha}","languages_url":"https://api.github.com/repos/biocore/qiita/languages","stargazers_url":"https://api.github.com/repos/biocore/qiita/stargazers","contributors_url":"https://api.github.com/repos/biocore/qiita/contributors","subscribers_url":"https://api.github.com/repos/biocore/qiita/subscribers","subscription_url":"https://api.github.com/repos/biocore/qiita/subscription","commits_url":"https://api.github.com/repos/biocore/qiita/commits{/sha}","git_commits_url":"https://api.github.com/repos/biocore/qiita/git/commits{/sha}","comments_url":"https://api.github.com/repos/biocore/qiita/comments{/number}","issue_comment_url":"https://api.github.com/repos/biocore/qiita/issues/comments/{number}","contents_url":"https://api.github.com/repos/biocore/qiita/contents/{+path}","compare_url":"https://api.github.com/repos/biocore/qiita/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biocore/qiita/merges","archive_url":"https://api.github.com/repos/biocore/qiita/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biocore/qiita/downloads","issues_url":"https://api.github.com/repos/biocore/qiita/issues{/number}","pulls_url":"https://api.github.com/repos/biocore/qiita/pulls{/number}","milestones_url":"https://api.github.com/repos/biocore/qiita/milestones{/number}","notifications_url":"https://api.github.com/repos/biocore/qiita/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biocore/qiita/labels{/name}","releases_url":"https://api.github.com/repos/biocore/qiita/releases{/id}","created_at":"2013-09-26T18:50:43Z","updated_at":"2015-02-15T04:07:10Z","pushed_at":"2015-02-15T04:07:10Z","git_url":"git://github.com/biocore/qiita.git","ssh_url":"git@github.com:biocore/qiita.git","clone_url":"https://github.com/biocore/qiita.git","svn_url":"https://github.com/biocore/qiita","homepage":"","size":118095,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":184,"forks":13,"open_issues":184,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/biocore/qiita/pulls/859"},"html":{"href":"https://github.com/biocore/qiita/pull/859"},"issue":{"href":"https://api.github.com/repos/biocore/qiita/issues/859"},"comments":{"href":"https://api.github.com/repos/biocore/qiita/issues/859/comments"},"review_comments":{"href":"https://api.github.com/repos/biocore/qiita/pulls/859/comments"},"review_comment":{"href":"https://api.github.com/repos/biocore/qiita/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/biocore/qiita/pulls/859/commits"},"statuses":{"href":"https://api.github.com/repos/biocore/qiita/statuses/8f4773bad54be2b6eab30f1a0cd477bd206cbd50"}}}}