{"action":"closed","number":89,"pull_request":{"url":"https://api.github.com/repos/InfraArcana/ia/pulls/89","id":41409798,"html_url":"https://github.com/InfraArcana/ia/pull/89","diff_url":"https://github.com/InfraArcana/ia/pull/89.diff","patch_url":"https://github.com/InfraArcana/ia/pull/89.patch","issue_url":"https://api.github.com/repos/InfraArcana/ia/issues/89","number":89,"state":"closed","locked":false,"title":"Fixed error where properties are not removed when armor is destroyed.","user":{"login":"esranzarnath","id":13473644,"avatar_url":"https://avatars.githubusercontent.com/u/13473644?v=3","gravatar_id":"","url":"https://api.github.com/users/esranzarnath","html_url":"https://github.com/esranzarnath","followers_url":"https://api.github.com/users/esranzarnath/followers","following_url":"https://api.github.com/users/esranzarnath/following{/other_user}","gists_url":"https://api.github.com/users/esranzarnath/gists{/gist_id}","starred_url":"https://api.github.com/users/esranzarnath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esranzarnath/subscriptions","organizations_url":"https://api.github.com/users/esranzarnath/orgs","repos_url":"https://api.github.com/users/esranzarnath/repos","events_url":"https://api.github.com/users/esranzarnath/events{/privacy}","received_events_url":"https://api.github.com/users/esranzarnath/received_events","type":"User","site_admin":false},"body":"Not the best solution, but an useable solution. My preferred solution would be to change it so items (or just armor) knows who its owner is, and the removal of properties on destruction could be handled by the destructor.","created_at":"2015-08-01T23:49:25Z","updated_at":"2015-08-02T10:13:51Z","closed_at":"2015-08-02T10:13:51Z","merged_at":null,"merge_commit_sha":"fa4576902a99f5a8124c888ec8ceb321a9f647db","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/InfraArcana/ia/pulls/89/commits","review_comments_url":"https://api.github.com/repos/InfraArcana/ia/pulls/89/comments","review_comment_url":"https://api.github.com/repos/InfraArcana/ia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/InfraArcana/ia/issues/89/comments","statuses_url":"https://api.github.com/repos/InfraArcana/ia/statuses/12258f40dd906d30af7339082352b8f7d03743e5","head":{"label":"esranzarnath:develop","ref":"develop","sha":"12258f40dd906d30af7339082352b8f7d03743e5","user":{"login":"esranzarnath","id":13473644,"avatar_url":"https://avatars.githubusercontent.com/u/13473644?v=3","gravatar_id":"","url":"https://api.github.com/users/esranzarnath","html_url":"https://github.com/esranzarnath","followers_url":"https://api.github.com/users/esranzarnath/followers","following_url":"https://api.github.com/users/esranzarnath/following{/other_user}","gists_url":"https://api.github.com/users/esranzarnath/gists{/gist_id}","starred_url":"https://api.github.com/users/esranzarnath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esranzarnath/subscriptions","organizations_url":"https://api.github.com/users/esranzarnath/orgs","repos_url":"https://api.github.com/users/esranzarnath/repos","events_url":"https://api.github.com/users/esranzarnath/events{/privacy}","received_events_url":"https://api.github.com/users/esranzarnath/received_events","type":"User","site_admin":false},"repo":{"id":40062804,"name":"ia","full_name":"esranzarnath/ia","owner":{"login":"esranzarnath","id":13473644,"avatar_url":"https://avatars.githubusercontent.com/u/13473644?v=3","gravatar_id":"","url":"https://api.github.com/users/esranzarnath","html_url":"https://github.com/esranzarnath","followers_url":"https://api.github.com/users/esranzarnath/followers","following_url":"https://api.github.com/users/esranzarnath/following{/other_user}","gists_url":"https://api.github.com/users/esranzarnath/gists{/gist_id}","starred_url":"https://api.github.com/users/esranzarnath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esranzarnath/subscriptions","organizations_url":"https://api.github.com/users/esranzarnath/orgs","repos_url":"https://api.github.com/users/esranzarnath/repos","events_url":"https://api.github.com/users/esranzarnath/events{/privacy}","received_events_url":"https://api.github.com/users/esranzarnath/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/esranzarnath/ia","description":"","fork":true,"url":"https://api.github.com/repos/esranzarnath/ia","forks_url":"https://api.github.com/repos/esranzarnath/ia/forks","keys_url":"https://api.github.com/repos/esranzarnath/ia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/esranzarnath/ia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/esranzarnath/ia/teams","hooks_url":"https://api.github.com/repos/esranzarnath/ia/hooks","issue_events_url":"https://api.github.com/repos/esranzarnath/ia/issues/events{/number}","events_url":"https://api.github.com/repos/esranzarnath/ia/events","assignees_url":"https://api.github.com/repos/esranzarnath/ia/assignees{/user}","branches_url":"https://api.github.com/repos/esranzarnath/ia/branches{/branch}","tags_url":"https://api.github.com/repos/esranzarnath/ia/tags","blobs_url":"https://api.github.com/repos/esranzarnath/ia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/esranzarnath/ia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/esranzarnath/ia/git/refs{/sha}","trees_url":"https://api.github.com/repos/esranzarnath/ia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/esranzarnath/ia/statuses/{sha}","languages_url":"https://api.github.com/repos/esranzarnath/ia/languages","stargazers_url":"https://api.github.com/repos/esranzarnath/ia/stargazers","contributors_url":"https://api.github.com/repos/esranzarnath/ia/contributors","subscribers_url":"https://api.github.com/repos/esranzarnath/ia/subscribers","subscription_url":"https://api.github.com/repos/esranzarnath/ia/subscription","commits_url":"https://api.github.com/repos/esranzarnath/ia/commits{/sha}","git_commits_url":"https://api.github.com/repos/esranzarnath/ia/git/commits{/sha}","comments_url":"https://api.github.com/repos/esranzarnath/ia/comments{/number}","issue_comment_url":"https://api.github.com/repos/esranzarnath/ia/issues/comments{/number}","contents_url":"https://api.github.com/repos/esranzarnath/ia/contents/{+path}","compare_url":"https://api.github.com/repos/esranzarnath/ia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/esranzarnath/ia/merges","archive_url":"https://api.github.com/repos/esranzarnath/ia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/esranzarnath/ia/downloads","issues_url":"https://api.github.com/repos/esranzarnath/ia/issues{/number}","pulls_url":"https://api.github.com/repos/esranzarnath/ia/pulls{/number}","milestones_url":"https://api.github.com/repos/esranzarnath/ia/milestones{/number}","notifications_url":"https://api.github.com/repos/esranzarnath/ia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/esranzarnath/ia/labels{/name}","releases_url":"https://api.github.com/repos/esranzarnath/ia/releases{/id}","created_at":"2015-08-01T23:21:21Z","updated_at":"2015-08-01T23:21:24Z","pushed_at":"2015-08-01T23:42:44Z","git_url":"git://github.com/esranzarnath/ia.git","ssh_url":"git@github.com:esranzarnath/ia.git","clone_url":"https://github.com/esranzarnath/ia.git","svn_url":"https://github.com/esranzarnath/ia","homepage":"https://sites.google.com/site/infraarcana","size":71963,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"InfraArcana:develop","ref":"develop","sha":"2f98ddb04a363054dae9795045204900002efb1c","user":{"login":"InfraArcana","id":1785363,"avatar_url":"https://avatars.githubusercontent.com/u/1785363?v=3","gravatar_id":"","url":"https://api.github.com/users/InfraArcana","html_url":"https://github.com/InfraArcana","followers_url":"https://api.github.com/users/InfraArcana/followers","following_url":"https://api.github.com/users/InfraArcana/following{/other_user}","gists_url":"https://api.github.com/users/InfraArcana/gists{/gist_id}","starred_url":"https://api.github.com/users/InfraArcana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/InfraArcana/subscriptions","organizations_url":"https://api.github.com/users/InfraArcana/orgs","repos_url":"https://api.github.com/users/InfraArcana/repos","events_url":"https://api.github.com/users/InfraArcana/events{/privacy}","received_events_url":"https://api.github.com/users/InfraArcana/received_events","type":"User","site_admin":false},"repo":{"id":4527955,"name":"ia","full_name":"InfraArcana/ia","owner":{"login":"InfraArcana","id":1785363,"avatar_url":"https://avatars.githubusercontent.com/u/1785363?v=3","gravatar_id":"","url":"https://api.github.com/users/InfraArcana","html_url":"https://github.com/InfraArcana","followers_url":"https://api.github.com/users/InfraArcana/followers","following_url":"https://api.github.com/users/InfraArcana/following{/other_user}","gists_url":"https://api.github.com/users/InfraArcana/gists{/gist_id}","starred_url":"https://api.github.com/users/InfraArcana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/InfraArcana/subscriptions","organizations_url":"https://api.github.com/users/InfraArcana/orgs","repos_url":"https://api.github.com/users/InfraArcana/repos","events_url":"https://api.github.com/users/InfraArcana/events{/privacy}","received_events_url":"https://api.github.com/users/InfraArcana/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/InfraArcana/ia","description":"","fork":false,"url":"https://api.github.com/repos/InfraArcana/ia","forks_url":"https://api.github.com/repos/InfraArcana/ia/forks","keys_url":"https://api.github.com/repos/InfraArcana/ia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/InfraArcana/ia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/InfraArcana/ia/teams","hooks_url":"https://api.github.com/repos/InfraArcana/ia/hooks","issue_events_url":"https://api.github.com/repos/InfraArcana/ia/issues/events{/number}","events_url":"https://api.github.com/repos/InfraArcana/ia/events","assignees_url":"https://api.github.com/repos/InfraArcana/ia/assignees{/user}","branches_url":"https://api.github.com/repos/InfraArcana/ia/branches{/branch}","tags_url":"https://api.github.com/repos/InfraArcana/ia/tags","blobs_url":"https://api.github.com/repos/InfraArcana/ia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/InfraArcana/ia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/InfraArcana/ia/git/refs{/sha}","trees_url":"https://api.github.com/repos/InfraArcana/ia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/InfraArcana/ia/statuses/{sha}","languages_url":"https://api.github.com/repos/InfraArcana/ia/languages","stargazers_url":"https://api.github.com/repos/InfraArcana/ia/stargazers","contributors_url":"https://api.github.com/repos/InfraArcana/ia/contributors","subscribers_url":"https://api.github.com/repos/InfraArcana/ia/subscribers","subscription_url":"https://api.github.com/repos/InfraArcana/ia/subscription","commits_url":"https://api.github.com/repos/InfraArcana/ia/commits{/sha}","git_commits_url":"https://api.github.com/repos/InfraArcana/ia/git/commits{/sha}","comments_url":"https://api.github.com/repos/InfraArcana/ia/comments{/number}","issue_comment_url":"https://api.github.com/repos/InfraArcana/ia/issues/comments{/number}","contents_url":"https://api.github.com/repos/InfraArcana/ia/contents/{+path}","compare_url":"https://api.github.com/repos/InfraArcana/ia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/InfraArcana/ia/merges","archive_url":"https://api.github.com/repos/InfraArcana/ia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/InfraArcana/ia/downloads","issues_url":"https://api.github.com/repos/InfraArcana/ia/issues{/number}","pulls_url":"https://api.github.com/repos/InfraArcana/ia/pulls{/number}","milestones_url":"https://api.github.com/repos/InfraArcana/ia/milestones{/number}","notifications_url":"https://api.github.com/repos/InfraArcana/ia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/InfraArcana/ia/labels{/name}","releases_url":"https://api.github.com/repos/InfraArcana/ia/releases{/id}","created_at":"2012-06-02T08:38:38Z","updated_at":"2015-08-01T16:24:36Z","pushed_at":"2015-08-01T23:49:27Z","git_url":"git://github.com/InfraArcana/ia.git","ssh_url":"git@github.com:InfraArcana/ia.git","clone_url":"https://github.com/InfraArcana/ia.git","svn_url":"https://github.com/InfraArcana/ia","homepage":"https://sites.google.com/site/infraarcana","size":71963,"stargazers_count":57,"watchers_count":57,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":12,"forks":9,"open_issues":12,"watchers":57,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/InfraArcana/ia/pulls/89"},"html":{"href":"https://github.com/InfraArcana/ia/pull/89"},"issue":{"href":"https://api.github.com/repos/InfraArcana/ia/issues/89"},"comments":{"href":"https://api.github.com/repos/InfraArcana/ia/issues/89/comments"},"review_comments":{"href":"https://api.github.com/repos/InfraArcana/ia/pulls/89/comments"},"review_comment":{"href":"https://api.github.com/repos/InfraArcana/ia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/InfraArcana/ia/pulls/89/commits"},"statuses":{"href":"https://api.github.com/repos/InfraArcana/ia/statuses/12258f40dd906d30af7339082352b8f7d03743e5"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":6,"deletions":1,"changed_files":2}}