{"action":"created","issue":{"url":"https://api.github.com/repos/project64/project64/issues/783","labels_url":"https://api.github.com/repos/project64/project64/issues/783/labels{/name}","comments_url":"https://api.github.com/repos/project64/project64/issues/783/comments","events_url":"https://api.github.com/repos/project64/project64/issues/783/events","html_url":"https://github.com/project64/project64/pull/783","id":118808070,"number":783,"title":"Upgrade wxWidgets to version 3.0.2 [THIRD IS THE CHARM]","user":{"login":"JunielKatarn","id":4507319,"avatar_url":"https://avatars.githubusercontent.com/u/4507319?v=3","gravatar_id":"","url":"https://api.github.com/users/JunielKatarn","html_url":"https://github.com/JunielKatarn","followers_url":"https://api.github.com/users/JunielKatarn/followers","following_url":"https://api.github.com/users/JunielKatarn/following{/other_user}","gists_url":"https://api.github.com/users/JunielKatarn/gists{/gist_id}","starred_url":"https://api.github.com/users/JunielKatarn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JunielKatarn/subscriptions","organizations_url":"https://api.github.com/users/JunielKatarn/orgs","repos_url":"https://api.github.com/users/JunielKatarn/repos","events_url":"https://api.github.com/users/JunielKatarn/events{/privacy}","received_events_url":"https://api.github.com/users/JunielKatarn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-11-25T10:43:23Z","updated_at":"2015-11-25T22:14:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/project64/project64/pulls/783","html_url":"https://github.com/project64/project64/pull/783","diff_url":"https://github.com/project64/project64/pull/783.diff","patch_url":"https://github.com/project64/project64/pull/783.patch"},"body":"Found the issue with previous attempts. Somehow, I managed to leave the `WIN32_MEAN_AND_LEAN` untouched in VS2008 props files submitted to this branch. My local changes did remove it, and that's why only I got successful builds before.\r\n3579400a41af58d3d671261eb5a3a2cd9960d24f does the trick.\r\nPlease note, leaving it out does not affect the rest of the projects.\r\n\r\n@project64: On the previous PR #780, you didn't want to touch that flag. While this might be valid for the previous wxWidgets code base (2.8), it breaks the upgraded one (3.0).\r\nMoreover, if you look at wxWidgets 3.0.2 and their VS makefiles (all versions), none of them set the flag. Removing it is the final step to get this change to work for good.\r\n\r\nSteps to test (I took them myself, of course)\r\n1. Checkout or download this branch (wx_3.0)\r\n2. Open whichever version of Visual Studio suits you (preferably 2008, which is the controversial one).\r\n3. Build from within the IDE (F7, SHIFT+CTRL+B, RIGHT-CLICK+Build, or whatever method...)\r\n\r\nI buit and ran VS2008, 2010, 2013 and 2015. The Glide64 GUI works correctly.\r\n\r\n@Frank-74, this time it will build fine in VS2008, I swear :angel:"},"comment":{"url":"https://api.github.com/repos/project64/project64/issues/comments/159743535","html_url":"https://github.com/project64/project64/pull/783#issuecomment-159743535","issue_url":"https://api.github.com/repos/project64/project64/issues/783","id":159743535,"user":{"login":"project64","id":4994272,"avatar_url":"https://avatars.githubusercontent.com/u/4994272?v=3","gravatar_id":"","url":"https://api.github.com/users/project64","html_url":"https://github.com/project64","followers_url":"https://api.github.com/users/project64/followers","following_url":"https://api.github.com/users/project64/following{/other_user}","gists_url":"https://api.github.com/users/project64/gists{/gist_id}","starred_url":"https://api.github.com/users/project64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/project64/subscriptions","organizations_url":"https://api.github.com/users/project64/orgs","repos_url":"https://api.github.com/users/project64/repos","events_url":"https://api.github.com/users/project64/events{/privacy}","received_events_url":"https://api.github.com/users/project64/received_events","type":"User","site_admin":false},"created_at":"2015-11-25T22:14:06Z","updated_at":"2015-11-25T22:14:06Z","body":"https://support.microsoft.com/en-us/kb/166474\r\n\r\nTo speed the build process, Visual C++ and the Windows Headers provide the following new define WIN32_LEAN_AND_MEAN You can use them to reduce the size of the Win32 header files. \r\n\r\nSo it should not necessarily effect the the file size, more the build time."}}