{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls/comments/46457646","id":46457646,"diff_hunk":"@@ -7,45 +7,13 @@\n  *  of patent rights can be found in the PATENTS file in the same directory.\n  */\n \n-var ERROR_EXPIRY = 10000;\n-\n-var atc_status = {\n-  OFFLINE: 0,\n-  ACTIVE: 1,\n-  INACTIVE: 2,\n-  OUTDATED: 3,\n-};\n-\n-\n-var NOTIFICATION_TYPES = {\n-  \"error\": \"danger\",\n-  \"info\": \"info\",\n-  \"warn\": \"warning\",\n-  \"success\": \"success\",\n-};\n-\n-\n-var NotificationPanel = React.createClass({\n-  render: function () {\n-    if (this.props.notifications.length == 0) {\n-      return (\n-        <i>No notifications.</i>\n-      );\n-    }\n-    return this.props.notifications.map(function(item, idx, arr) {\n-      var timeout = Math.floor((item.expire_at - new Date().getTime()) / 1000)\n-      var cls = \"alert alert-\" + (NOTIFICATION_TYPES[item.type] || item.type);\n-      return (\n-        <div className={cls} role=\"alert\">\n-          <div className=\"row\">\n-            <div className=\"col-md-11\">{item.message}</div>\n-            <div className=\"col-md-1\">{timeout}</div>\n-          </div>\n-        </div>\n-      );\n-    });\n-  },\n-});","path":"src/react/jsx/atc.js","position":42,"original_position":42,"commit_id":"569698428facf4600553814c724e92d6b936b888","original_commit_id":"569698428facf4600553814c724e92d6b936b888","user":{"login":"zfjagann","id":794008,"avatar_url":"https://avatars.githubusercontent.com/u/794008?v=3","gravatar_id":"","url":"https://api.github.com/users/zfjagann","html_url":"https://github.com/zfjagann","followers_url":"https://api.github.com/users/zfjagann/followers","following_url":"https://api.github.com/users/zfjagann/following{/other_user}","gists_url":"https://api.github.com/users/zfjagann/gists{/gist_id}","starred_url":"https://api.github.com/users/zfjagann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfjagann/subscriptions","organizations_url":"https://api.github.com/users/zfjagann/orgs","repos_url":"https://api.github.com/users/zfjagann/repos","events_url":"https://api.github.com/users/zfjagann/events{/privacy}","received_events_url":"https://api.github.com/users/zfjagann/received_events","type":"User","site_admin":false},"body":"YES! Dead code is dead!","created_at":"2015-12-02T18:57:41Z","updated_at":"2015-12-02T18:57:41Z","html_url":"https://github.com/facebook/augmented-traffic-control/pull/196#discussion_r46457646","pull_request_url":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls/196","_links":{"self":{"href":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls/comments/46457646"},"html":{"href":"https://github.com/facebook/augmented-traffic-control/pull/196#discussion_r46457646"},"pull_request":{"href":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls/196"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls/196","id":51884589,"html_url":"https://github.com/facebook/augmented-traffic-control/pull/196","diff_url":"https://github.com/facebook/augmented-traffic-control/pull/196.diff","patch_url":"https://github.com/facebook/augmented-traffic-control/pull/196.patch","issue_url":"https://api.github.com/repos/facebook/augmented-traffic-control/issues/196","number":196,"state":"open","locked":false,"title":"decouple index.htm from the javascript and move away from JSXTransformer","user":{"login":"chantra","id":24572,"avatar_url":"https://avatars.githubusercontent.com/u/24572?v=3","gravatar_id":"","url":"https://api.github.com/users/chantra","html_url":"https://github.com/chantra","followers_url":"https://api.github.com/users/chantra/followers","following_url":"https://api.github.com/users/chantra/following{/other_user}","gists_url":"https://api.github.com/users/chantra/gists{/gist_id}","starred_url":"https://api.github.com/users/chantra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chantra/subscriptions","organizations_url":"https://api.github.com/users/chantra/orgs","repos_url":"https://api.github.com/users/chantra/repos","events_url":"https://api.github.com/users/chantra/events{/privacy}","received_events_url":"https://api.github.com/users/chantra/received_events","type":"User","site_admin":false},"body":"Still WIP but making a PR for visibility.\r\n\r\nThe individual commits explain the rationales. As part of this diff, I need to get the toolchain for thjs in a better state but this is a good start, that should also allow us to easily ship a atc-react module.","created_at":"2015-11-26T08:38:37Z","updated_at":"2015-12-02T18:57:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d0a656c7985c9e20eca1234fd8dee9d39e6fde1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls/196/commits","review_comments_url":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls/196/comments","review_comment_url":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/augmented-traffic-control/issues/196/comments","statuses_url":"https://api.github.com/repos/facebook/augmented-traffic-control/statuses/569698428facf4600553814c724e92d6b936b888","head":{"label":"chantra:decouple_index_js","ref":"decouple_index_js","sha":"569698428facf4600553814c724e92d6b936b888","user":{"login":"chantra","id":24572,"avatar_url":"https://avatars.githubusercontent.com/u/24572?v=3","gravatar_id":"","url":"https://api.github.com/users/chantra","html_url":"https://github.com/chantra","followers_url":"https://api.github.com/users/chantra/followers","following_url":"https://api.github.com/users/chantra/following{/other_user}","gists_url":"https://api.github.com/users/chantra/gists{/gist_id}","starred_url":"https://api.github.com/users/chantra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chantra/subscriptions","organizations_url":"https://api.github.com/users/chantra/orgs","repos_url":"https://api.github.com/users/chantra/repos","events_url":"https://api.github.com/users/chantra/events{/privacy}","received_events_url":"https://api.github.com/users/chantra/received_events","type":"User","site_admin":false},"repo":{"id":32833075,"name":"augmented-traffic-control","full_name":"chantra/augmented-traffic-control","owner":{"login":"chantra","id":24572,"avatar_url":"https://avatars.githubusercontent.com/u/24572?v=3","gravatar_id":"","url":"https://api.github.com/users/chantra","html_url":"https://github.com/chantra","followers_url":"https://api.github.com/users/chantra/followers","following_url":"https://api.github.com/users/chantra/following{/other_user}","gists_url":"https://api.github.com/users/chantra/gists{/gist_id}","starred_url":"https://api.github.com/users/chantra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chantra/subscriptions","organizations_url":"https://api.github.com/users/chantra/orgs","repos_url":"https://api.github.com/users/chantra/repos","events_url":"https://api.github.com/users/chantra/events{/privacy}","received_events_url":"https://api.github.com/users/chantra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chantra/augmented-traffic-control","description":"Augmented Traffic Control: A tool to simulate network conditions","fork":true,"url":"https://api.github.com/repos/chantra/augmented-traffic-control","forks_url":"https://api.github.com/repos/chantra/augmented-traffic-control/forks","keys_url":"https://api.github.com/repos/chantra/augmented-traffic-control/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chantra/augmented-traffic-control/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chantra/augmented-traffic-control/teams","hooks_url":"https://api.github.com/repos/chantra/augmented-traffic-control/hooks","issue_events_url":"https://api.github.com/repos/chantra/augmented-traffic-control/issues/events{/number}","events_url":"https://api.github.com/repos/chantra/augmented-traffic-control/events","assignees_url":"https://api.github.com/repos/chantra/augmented-traffic-control/assignees{/user}","branches_url":"https://api.github.com/repos/chantra/augmented-traffic-control/branches{/branch}","tags_url":"https://api.github.com/repos/chantra/augmented-traffic-control/tags","blobs_url":"https://api.github.com/repos/chantra/augmented-traffic-control/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chantra/augmented-traffic-control/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chantra/augmented-traffic-control/git/refs{/sha}","trees_url":"https://api.github.com/repos/chantra/augmented-traffic-control/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chantra/augmented-traffic-control/statuses/{sha}","languages_url":"https://api.github.com/repos/chantra/augmented-traffic-control/languages","stargazers_url":"https://api.github.com/repos/chantra/augmented-traffic-control/stargazers","contributors_url":"https://api.github.com/repos/chantra/augmented-traffic-control/contributors","subscribers_url":"https://api.github.com/repos/chantra/augmented-traffic-control/subscribers","subscription_url":"https://api.github.com/repos/chantra/augmented-traffic-control/subscription","commits_url":"https://api.github.com/repos/chantra/augmented-traffic-control/commits{/sha}","git_commits_url":"https://api.github.com/repos/chantra/augmented-traffic-control/git/commits{/sha}","comments_url":"https://api.github.com/repos/chantra/augmented-traffic-control/comments{/number}","issue_comment_url":"https://api.github.com/repos/chantra/augmented-traffic-control/issues/comments{/number}","contents_url":"https://api.github.com/repos/chantra/augmented-traffic-control/contents/{+path}","compare_url":"https://api.github.com/repos/chantra/augmented-traffic-control/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chantra/augmented-traffic-control/merges","archive_url":"https://api.github.com/repos/chantra/augmented-traffic-control/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chantra/augmented-traffic-control/downloads","issues_url":"https://api.github.com/repos/chantra/augmented-traffic-control/issues{/number}","pulls_url":"https://api.github.com/repos/chantra/augmented-traffic-control/pulls{/number}","milestones_url":"https://api.github.com/repos/chantra/augmented-traffic-control/milestones{/number}","notifications_url":"https://api.github.com/repos/chantra/augmented-traffic-control/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chantra/augmented-traffic-control/labels{/name}","releases_url":"https://api.github.com/repos/chantra/augmented-traffic-control/releases{/id}","created_at":"2015-03-25T00:25:24Z","updated_at":"2015-03-30T19:21:44Z","pushed_at":"2015-12-02T18:41:00Z","git_url":"git://github.com/chantra/augmented-traffic-control.git","ssh_url":"git@github.com:chantra/augmented-traffic-control.git","clone_url":"https://github.com/chantra/augmented-traffic-control.git","svn_url":"https://github.com/chantra/augmented-traffic-control","homepage":"https://facebook.github.io/augmented-traffic-control","size":10257,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:golang","ref":"golang","sha":"b0250526024e20df643df7573b65407b970cfceb","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":17996971,"name":"augmented-traffic-control","full_name":"facebook/augmented-traffic-control","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/augmented-traffic-control","description":"Augmented Traffic Control: A tool to simulate network conditions","fork":false,"url":"https://api.github.com/repos/facebook/augmented-traffic-control","forks_url":"https://api.github.com/repos/facebook/augmented-traffic-control/forks","keys_url":"https://api.github.com/repos/facebook/augmented-traffic-control/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/augmented-traffic-control/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/augmented-traffic-control/teams","hooks_url":"https://api.github.com/repos/facebook/augmented-traffic-control/hooks","issue_events_url":"https://api.github.com/repos/facebook/augmented-traffic-control/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/augmented-traffic-control/events","assignees_url":"https://api.github.com/repos/facebook/augmented-traffic-control/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/augmented-traffic-control/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/augmented-traffic-control/tags","blobs_url":"https://api.github.com/repos/facebook/augmented-traffic-control/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/augmented-traffic-control/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/augmented-traffic-control/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/augmented-traffic-control/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/augmented-traffic-control/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/augmented-traffic-control/languages","stargazers_url":"https://api.github.com/repos/facebook/augmented-traffic-control/stargazers","contributors_url":"https://api.github.com/repos/facebook/augmented-traffic-control/contributors","subscribers_url":"https://api.github.com/repos/facebook/augmented-traffic-control/subscribers","subscription_url":"https://api.github.com/repos/facebook/augmented-traffic-control/subscription","commits_url":"https://api.github.com/repos/facebook/augmented-traffic-control/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/augmented-traffic-control/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/augmented-traffic-control/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/augmented-traffic-control/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/augmented-traffic-control/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/augmented-traffic-control/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/augmented-traffic-control/merges","archive_url":"https://api.github.com/repos/facebook/augmented-traffic-control/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/augmented-traffic-control/downloads","issues_url":"https://api.github.com/repos/facebook/augmented-traffic-control/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/augmented-traffic-control/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/augmented-traffic-control/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/augmented-traffic-control/labels{/name}","releases_url":"https://api.github.com/repos/facebook/augmented-traffic-control/releases{/id}","created_at":"2014-03-21T22:58:17Z","updated_at":"2015-12-02T10:37:59Z","pushed_at":"2015-12-02T18:41:01Z","git_url":"git://github.com/facebook/augmented-traffic-control.git","ssh_url":"git@github.com:facebook/augmented-traffic-control.git","clone_url":"https://github.com/facebook/augmented-traffic-control.git","svn_url":"https://github.com/facebook/augmented-traffic-control","homepage":"https://facebook.github.io/augmented-traffic-control","size":10411,"stargazers_count":2629,"watchers_count":2629,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":362,"mirror_url":null,"open_issues_count":17,"forks":362,"open_issues":17,"watchers":2629,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls/196"},"html":{"href":"https://github.com/facebook/augmented-traffic-control/pull/196"},"issue":{"href":"https://api.github.com/repos/facebook/augmented-traffic-control/issues/196"},"comments":{"href":"https://api.github.com/repos/facebook/augmented-traffic-control/issues/196/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls/196/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls/196/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/augmented-traffic-control/statuses/569698428facf4600553814c724e92d6b936b888"}}}}