{"comment":{"url":"https://api.github.com/repos/endlessm/eos-event-recorder-daemon/comments/11415752","html_url":"https://github.com/endlessm/eos-event-recorder-daemon/commit/872b2cecd03ef6bf07f915fb20b0b38d02f079a2#commitcomment-11415752","id":11415752,"user":{"login":"Kurt-von-Laven","id":974910,"avatar_url":"https://avatars.githubusercontent.com/u/974910?v=3","gravatar_id":"","url":"https://api.github.com/users/Kurt-von-Laven","html_url":"https://github.com/Kurt-von-Laven","followers_url":"https://api.github.com/users/Kurt-von-Laven/followers","following_url":"https://api.github.com/users/Kurt-von-Laven/following{/other_user}","gists_url":"https://api.github.com/users/Kurt-von-Laven/gists{/gist_id}","starred_url":"https://api.github.com/users/Kurt-von-Laven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kurt-von-Laven/subscriptions","organizations_url":"https://api.github.com/users/Kurt-von-Laven/orgs","repos_url":"https://api.github.com/users/Kurt-von-Laven/repos","events_url":"https://api.github.com/users/Kurt-von-Laven/events{/privacy}","received_events_url":"https://api.github.com/users/Kurt-von-Laven/received_events","type":"User","site_admin":false},"position":38,"line":251,"path":"daemon/emer-daemon.c","commit_id":"872b2cecd03ef6bf07f915fb20b0b38d02f079a2","created_at":"2015-05-28T20:51:42Z","updated_at":"2015-05-28T20:51:42Z","body":"My understanding of what's going on here is that we want to make sure that the event ID variant doesn't get leaked. We could do the ref sink and unref in each of `emer_daemon_record_singular_event`, `emer_daemon_record_aggregate_event`, and `emer_daemon_record_event_sequence` or consolidate that here. I see it as a tradeoff between duplication and keeping the reference counting at the more \"correct\" layer of abstraction.\r\n\r\nIn general, please feel free to comment on pre-existing issues for me. I usually prefer just fixing stuff while it's loaded into my brain to tracking it and coming back to it once I've forgotten what was going on (or leaving stuff messy and potentially tripping on it once I've forgotten what was going on)."}}