{"action":"created","issue":{"url":"https://api.github.com/repos/greenplum-db/gpdb/issues/54","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/54/labels{/name}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/54/comments","events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/54/events","html_url":"https://github.com/greenplum-db/gpdb/pull/54","id":115434984,"number":54,"title":"Fix brackets missing issue while describe views having ordered-set aggregates","user":{"login":"pengzhout","id":14901939,"avatar_url":"https://avatars.githubusercontent.com/u/14901939?v=3","gravatar_id":"","url":"https://api.github.com/users/pengzhout","html_url":"https://github.com/pengzhout","followers_url":"https://api.github.com/users/pengzhout/followers","following_url":"https://api.github.com/users/pengzhout/following{/other_user}","gists_url":"https://api.github.com/users/pengzhout/gists{/gist_id}","starred_url":"https://api.github.com/users/pengzhout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pengzhout/subscriptions","organizations_url":"https://api.github.com/users/pengzhout/orgs","repos_url":"https://api.github.com/users/pengzhout/repos","events_url":"https://api.github.com/users/pengzhout/events{/privacy}","received_events_url":"https://api.github.com/users/pengzhout/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-11-06T05:16:34Z","updated_at":"2015-11-06T05:58:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/54","html_url":"https://github.com/greenplum-db/gpdb/pull/54","diff_url":"https://github.com/greenplum-db/gpdb/pull/54.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/54.patch"},"body":"After creating view that contain ordered-set (WITHIN GROUP) aggregates, \\d+ or pg_dump can not get the correct definition of the view back, the brackets around the ORDER BY clause disappear.\r\n\r\nView definition is stored in pg_rewrite in the form of parsetree, get_rule_expr() parses the T_Percentile node back to query string format, it should append the brackets around ORDER BY clause."},"comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments/154310169","html_url":"https://github.com/greenplum-db/gpdb/pull/54#issuecomment-154310169","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/54","id":154310169,"user":{"login":"yydzero","id":512403,"avatar_url":"https://avatars.githubusercontent.com/u/512403?v=3","gravatar_id":"","url":"https://api.github.com/users/yydzero","html_url":"https://github.com/yydzero","followers_url":"https://api.github.com/users/yydzero/followers","following_url":"https://api.github.com/users/yydzero/following{/other_user}","gists_url":"https://api.github.com/users/yydzero/gists{/gist_id}","starred_url":"https://api.github.com/users/yydzero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yydzero/subscriptions","organizations_url":"https://api.github.com/users/yydzero/orgs","repos_url":"https://api.github.com/users/yydzero/repos","events_url":"https://api.github.com/users/yydzero/events{/privacy}","received_events_url":"https://api.github.com/users/yydzero/received_events","type":"User","site_admin":false},"created_at":"2015-11-06T05:58:44Z","updated_at":"2015-11-06T05:58:44Z","body":"Thanks Ashwin!\n\nOn Fri, Nov 6, 2015 at 1:55 PM, Ashwin Agrawal <notifications@github.com>\nwrote:\n\n> As Pivotal employees should make your membership to GPDB organization\n> public.\n> Steps here:\n> <\n>\n> https://help.github.com/articles/publicizing-or-concealing-organization-membership/\n> >\n> That way it will detect that we are already covered under corporate CLA.\n>\n>\n> On Thu, Nov 5, 2015 at 9:48 PM, Yandong Yao <notifications@github.com>\n> wrote:\n>\n> > For Pivotal employees, do we still need this? Or we could just ignore it?\n> >\n> > On Fri, Nov 6, 2015 at 1:16 PM, gpdbdreddbot <notifications@github.com>\n> > wrote:\n> >\n> > > Hello pengzhout!\n> > >\n> > > Thanks for submitting this pull request!\n> > >\n> > > All pull request authors must have a Contributor License Agreement\n> (CLA)\n> > > on-file with us. Please sign the appropriate CLA (individual\n> > > <http://greenplum.org/contributor_agreements/GPDB_Pivotal_ICLA.pdf> or\n> > > corporate\n> > > <http://greenplum.org/contributor_agreements/GPDB_Pivotal_CCLA.pdf>).\n> > >\n> > > When sending signed CLA please provide your github username in case of\n> > > individual CLA or the list of github usernames that can make pull\n> > requests\n> > > on behalf of your organization.\n> > >\n> > > If you are confident that you're covered under a Corporate CLA, please\n> > > make sure you've publicized your membership in the appropriate Github\n> > Org,\n> > > per these instructions\n> > > <\n> >\n> https://help.github.com/articles/publicizing-or-concealing-organization-membership/\n> > >\n> > > .\n> > >\n> > > —\n> > > Reply to this email directly or view it on GitHub\n> > > <https://github.com/greenplum-db/gpdb/pull/54#issuecomment-154288086>.\n> > >\n> >\n> >\n> >\n> > --\n> > Best Regards,\n> > Yandong\n> >\n> > —\n> > Reply to this email directly or view it on GitHub\n> > <https://github.com/greenplum-db/gpdb/pull/54#issuecomment-154303011>.\n>\n> >\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/greenplum-db/gpdb/pull/54#issuecomment-154308211>.\n>\n\n\n\n-- \nBest Regards,\nYandong\n"}}