{"action":"created","comment":{"url":"https://api.github.com/repos/apache/parquet-mr/pulls/comments/40382476","id":40382476,"diff_hunk":"@@ -445,6 +600,26 @@ public FieldEnumConverter(List<TProtocol> events, ThriftField field) {\n       }\n     }\n \n+     @Override\n+     protected ParquetProtocol decodeFromDictionary(Dictionary d, int i) {\n+       Binary value = d.decodeToBinary(i);\n+       final Integer id = enumLookup.get(value);","path":"parquet-thrift/src/main/java/org/apache/parquet/thrift/ThriftRecordConverter.java","position":370,"original_position":370,"commit_id":"02b756d4d26133cbdd65da0f7330306e32eb429f","original_commit_id":"02b756d4d26133cbdd65da0f7330306e32eb429f","user":{"login":"isnotinvain","id":372969,"avatar_url":"https://avatars.githubusercontent.com/u/372969?v=3","gravatar_id":"","url":"https://api.github.com/users/isnotinvain","html_url":"https://github.com/isnotinvain","followers_url":"https://api.github.com/users/isnotinvain/followers","following_url":"https://api.github.com/users/isnotinvain/following{/other_user}","gists_url":"https://api.github.com/users/isnotinvain/gists{/gist_id}","starred_url":"https://api.github.com/users/isnotinvain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isnotinvain/subscriptions","organizations_url":"https://api.github.com/users/isnotinvain/orgs","repos_url":"https://api.github.com/users/isnotinvain/repos","events_url":"https://api.github.com/users/isnotinvain/events{/privacy}","received_events_url":"https://api.github.com/users/isnotinvain/received_events","type":"User","site_admin":false},"body":"Sorry, I don't understand. Which part could be de-duplicated? ","created_at":"2015-09-24T22:43:24Z","updated_at":"2015-09-24T22:43:24Z","html_url":"https://github.com/apache/parquet-mr/pull/268#discussion_r40382476","pull_request_url":"https://api.github.com/repos/apache/parquet-mr/pulls/268","_links":{"self":{"href":"https://api.github.com/repos/apache/parquet-mr/pulls/comments/40382476"},"html":{"href":"https://github.com/apache/parquet-mr/pull/268#discussion_r40382476"},"pull_request":{"href":"https://api.github.com/repos/apache/parquet-mr/pulls/268"}}},"pull_request":{"url":"https://api.github.com/repos/apache/parquet-mr/pulls/268","id":44087849,"html_url":"https://github.com/apache/parquet-mr/pull/268","diff_url":"https://github.com/apache/parquet-mr/pull/268.diff","patch_url":"https://github.com/apache/parquet-mr/pull/268.patch","issue_url":"https://api.github.com/repos/apache/parquet-mr/issues/268","number":268,"state":"open","locked":false,"title":"PARQUET-368: Add dictionary support to parquet-thrift","user":{"login":"isnotinvain","id":372969,"avatar_url":"https://avatars.githubusercontent.com/u/372969?v=3","gravatar_id":"","url":"https://api.github.com/users/isnotinvain","html_url":"https://github.com/isnotinvain","followers_url":"https://api.github.com/users/isnotinvain/followers","following_url":"https://api.github.com/users/isnotinvain/following{/other_user}","gists_url":"https://api.github.com/users/isnotinvain/gists{/gist_id}","starred_url":"https://api.github.com/users/isnotinvain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isnotinvain/subscriptions","organizations_url":"https://api.github.com/users/isnotinvain/orgs","repos_url":"https://api.github.com/users/isnotinvain/repos","events_url":"https://api.github.com/users/isnotinvain/events{/privacy}","received_events_url":"https://api.github.com/users/isnotinvain/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-03T09:54:01Z","updated_at":"2015-09-24T22:43:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d16d4bc9b66e4d6ab6094040d2de337e191e073d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/parquet-mr/pulls/268/commits","review_comments_url":"https://api.github.com/repos/apache/parquet-mr/pulls/268/comments","review_comment_url":"https://api.github.com/repos/apache/parquet-mr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/parquet-mr/issues/268/comments","statuses_url":"https://api.github.com/repos/apache/parquet-mr/statuses/02b756d4d26133cbdd65da0f7330306e32eb429f","head":{"label":"isnotinvain:alexlevenson/dictionary-encoding-thrift","ref":"alexlevenson/dictionary-encoding-thrift","sha":"02b756d4d26133cbdd65da0f7330306e32eb429f","user":{"login":"isnotinvain","id":372969,"avatar_url":"https://avatars.githubusercontent.com/u/372969?v=3","gravatar_id":"","url":"https://api.github.com/users/isnotinvain","html_url":"https://github.com/isnotinvain","followers_url":"https://api.github.com/users/isnotinvain/followers","following_url":"https://api.github.com/users/isnotinvain/following{/other_user}","gists_url":"https://api.github.com/users/isnotinvain/gists{/gist_id}","starred_url":"https://api.github.com/users/isnotinvain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isnotinvain/subscriptions","organizations_url":"https://api.github.com/users/isnotinvain/orgs","repos_url":"https://api.github.com/users/isnotinvain/repos","events_url":"https://api.github.com/users/isnotinvain/events{/privacy}","received_events_url":"https://api.github.com/users/isnotinvain/received_events","type":"User","site_admin":false},"repo":{"id":21011791,"name":"incubator-parquet-mr","full_name":"isnotinvain/incubator-parquet-mr","owner":{"login":"isnotinvain","id":372969,"avatar_url":"https://avatars.githubusercontent.com/u/372969?v=3","gravatar_id":"","url":"https://api.github.com/users/isnotinvain","html_url":"https://github.com/isnotinvain","followers_url":"https://api.github.com/users/isnotinvain/followers","following_url":"https://api.github.com/users/isnotinvain/following{/other_user}","gists_url":"https://api.github.com/users/isnotinvain/gists{/gist_id}","starred_url":"https://api.github.com/users/isnotinvain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isnotinvain/subscriptions","organizations_url":"https://api.github.com/users/isnotinvain/orgs","repos_url":"https://api.github.com/users/isnotinvain/repos","events_url":"https://api.github.com/users/isnotinvain/events{/privacy}","received_events_url":"https://api.github.com/users/isnotinvain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/isnotinvain/incubator-parquet-mr","description":"Mirror of Apache Parquet","fork":true,"url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr","forks_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/forks","keys_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/teams","hooks_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/hooks","issue_events_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/issues/events{/number}","events_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/events","assignees_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/assignees{/user}","branches_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/branches{/branch}","tags_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/tags","blobs_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/git/refs{/sha}","trees_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/statuses/{sha}","languages_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/languages","stargazers_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/stargazers","contributors_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/contributors","subscribers_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/subscribers","subscription_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/subscription","commits_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/commits{/sha}","git_commits_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/git/commits{/sha}","comments_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/comments{/number}","issue_comment_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/issues/comments{/number}","contents_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/contents/{+path}","compare_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/merges","archive_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/downloads","issues_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/issues{/number}","pulls_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/pulls{/number}","milestones_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/milestones{/number}","notifications_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/labels{/name}","releases_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/releases{/id}","created_at":"2014-06-19T18:55:45Z","updated_at":"2015-05-06T01:59:59Z","pushed_at":"2015-09-24T21:58:26Z","git_url":"git://github.com/isnotinvain/incubator-parquet-mr.git","ssh_url":"git@github.com:isnotinvain/incubator-parquet-mr.git","clone_url":"https://github.com/isnotinvain/incubator-parquet-mr.git","svn_url":"https://github.com/isnotinvain/incubator-parquet-mr","homepage":null,"size":14285,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"04f524d5ad91b1cdda66dfde4089f2f83f4528aa","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20675636,"name":"parquet-mr","full_name":"apache/parquet-mr","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/parquet-mr","description":"Mirror of Apache Parquet","fork":false,"url":"https://api.github.com/repos/apache/parquet-mr","forks_url":"https://api.github.com/repos/apache/parquet-mr/forks","keys_url":"https://api.github.com/repos/apache/parquet-mr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/parquet-mr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/parquet-mr/teams","hooks_url":"https://api.github.com/repos/apache/parquet-mr/hooks","issue_events_url":"https://api.github.com/repos/apache/parquet-mr/issues/events{/number}","events_url":"https://api.github.com/repos/apache/parquet-mr/events","assignees_url":"https://api.github.com/repos/apache/parquet-mr/assignees{/user}","branches_url":"https://api.github.com/repos/apache/parquet-mr/branches{/branch}","tags_url":"https://api.github.com/repos/apache/parquet-mr/tags","blobs_url":"https://api.github.com/repos/apache/parquet-mr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/parquet-mr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/parquet-mr/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/parquet-mr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/parquet-mr/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/parquet-mr/languages","stargazers_url":"https://api.github.com/repos/apache/parquet-mr/stargazers","contributors_url":"https://api.github.com/repos/apache/parquet-mr/contributors","subscribers_url":"https://api.github.com/repos/apache/parquet-mr/subscribers","subscription_url":"https://api.github.com/repos/apache/parquet-mr/subscription","commits_url":"https://api.github.com/repos/apache/parquet-mr/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/parquet-mr/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/parquet-mr/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/parquet-mr/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/parquet-mr/contents/{+path}","compare_url":"https://api.github.com/repos/apache/parquet-mr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/parquet-mr/merges","archive_url":"https://api.github.com/repos/apache/parquet-mr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/parquet-mr/downloads","issues_url":"https://api.github.com/repos/apache/parquet-mr/issues{/number}","pulls_url":"https://api.github.com/repos/apache/parquet-mr/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/parquet-mr/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/parquet-mr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/parquet-mr/labels{/name}","releases_url":"https://api.github.com/repos/apache/parquet-mr/releases{/id}","created_at":"2014-06-10T07:00:07Z","updated_at":"2015-09-23T16:48:50Z","pushed_at":"2015-09-24T21:58:26Z","git_url":"git://github.com/apache/parquet-mr.git","ssh_url":"git@github.com:apache/parquet-mr.git","clone_url":"https://github.com/apache/parquet-mr.git","svn_url":"https://github.com/apache/parquet-mr","homepage":null,"size":89351,"stargazers_count":140,"watchers_count":140,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":157,"mirror_url":"git://git.apache.org/incubator-parquet-mr.git","open_issues_count":54,"forks":157,"open_issues":54,"watchers":140,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/parquet-mr/pulls/268"},"html":{"href":"https://github.com/apache/parquet-mr/pull/268"},"issue":{"href":"https://api.github.com/repos/apache/parquet-mr/issues/268"},"comments":{"href":"https://api.github.com/repos/apache/parquet-mr/issues/268/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/parquet-mr/pulls/268/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/parquet-mr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/parquet-mr/pulls/268/commits"},"statuses":{"href":"https://api.github.com/repos/apache/parquet-mr/statuses/02b756d4d26133cbdd65da0f7330306e32eb429f"}}}}