{"action":"opened","number":366,"pull_request":{"url":"https://api.github.com/repos/syncany/syncany/pulls/366","id":28430530,"html_url":"https://github.com/syncany/syncany/pull/366","diff_url":"https://github.com/syncany/syncany/pull/366.diff","patch_url":"https://github.com/syncany/syncany/pull/366.patch","issue_url":"https://api.github.com/repos/syncany/syncany/issues/366","number":366,"state":"open","locked":false,"title":"Subfolder based TransferManagers","user":{"login":"cr0","id":854965,"avatar_url":"https://avatars.githubusercontent.com/u/854965?v=3","gravatar_id":"","url":"https://api.github.com/users/cr0","html_url":"https://github.com/cr0","followers_url":"https://api.github.com/users/cr0/followers","following_url":"https://api.github.com/users/cr0/following{/other_user}","gists_url":"https://api.github.com/users/cr0/gists{/gist_id}","starred_url":"https://api.github.com/users/cr0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cr0/subscriptions","organizations_url":"https://api.github.com/users/cr0/orgs","repos_url":"https://api.github.com/users/cr0/repos","events_url":"https://api.github.com/users/cr0/events{/privacy}","received_events_url":"https://api.github.com/users/cr0/received_events","type":"User","site_admin":false},"body":"As discussed in #361 and #353 some repos require us to breakdown many files into different subfolders. Hence, I started to provide a subfolder based TM which handles this stuff (based on @pimotte's idea).\r\n\r\nSo if a plugin wants to take advantage of this approach, its TransferManager has to implement Folderable. This signalises Syncany to wrap the plugin's TransferManager in a FolderAwareTransferManager which handles the subfoldering stuff based on properties provided by a plugin (a plugin dev can choose if he either wants to use hard coded properties or lets a user choose them).\r\n\r\nThe TransferManager has to take care of the listing and cleanup stuff (like the removal of empty directories), though. I think this is too plugin specific.\r\n\r\nExample usage is shown in this [syncany-plugin-dropbox branch](https://github.com/syncany/syncany-plugin-dropbox/tree/feature/folderizable).\r\n\r\nI already tested it for a short time but I'd really appreciate if someone could also check if it works as expected.\r\n\r\n**Request for review**\r\n\r\ncloses #365","created_at":"2015-02-01T12:37:51Z","updated_at":"2015-02-01T12:37:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/syncany/syncany/pulls/366/commits","review_comments_url":"https://api.github.com/repos/syncany/syncany/pulls/366/comments","review_comment_url":"https://api.github.com/repos/syncany/syncany/pulls/comments/{number}","comments_url":"https://api.github.com/repos/syncany/syncany/issues/366/comments","statuses_url":"https://api.github.com/repos/syncany/syncany/statuses/92cffb8bcaaffb3ab6575efbf210867be7a03597","head":{"label":"syncany:feature/folderizable","ref":"feature/folderizable","sha":"92cffb8bcaaffb3ab6575efbf210867be7a03597","user":{"login":"syncany","id":5913247,"avatar_url":"https://avatars.githubusercontent.com/u/5913247?v=3","gravatar_id":"","url":"https://api.github.com/users/syncany","html_url":"https://github.com/syncany","followers_url":"https://api.github.com/users/syncany/followers","following_url":"https://api.github.com/users/syncany/following{/other_user}","gists_url":"https://api.github.com/users/syncany/gists{/gist_id}","starred_url":"https://api.github.com/users/syncany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syncany/subscriptions","organizations_url":"https://api.github.com/users/syncany/orgs","repos_url":"https://api.github.com/users/syncany/repos","events_url":"https://api.github.com/users/syncany/events{/privacy}","received_events_url":"https://api.github.com/users/syncany/received_events","type":"Organization","site_admin":false},"repo":{"id":13392416,"name":"syncany","full_name":"syncany/syncany","owner":{"login":"syncany","id":5913247,"avatar_url":"https://avatars.githubusercontent.com/u/5913247?v=3","gravatar_id":"","url":"https://api.github.com/users/syncany","html_url":"https://github.com/syncany","followers_url":"https://api.github.com/users/syncany/followers","following_url":"https://api.github.com/users/syncany/following{/other_user}","gists_url":"https://api.github.com/users/syncany/gists{/gist_id}","starred_url":"https://api.github.com/users/syncany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syncany/subscriptions","organizations_url":"https://api.github.com/users/syncany/orgs","repos_url":"https://api.github.com/users/syncany/repos","events_url":"https://api.github.com/users/syncany/events{/privacy}","received_events_url":"https://api.github.com/users/syncany/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/syncany/syncany","description":"Syncany is a cloud storage and filesharing application with a focus on security and abstraction of storage.","fork":false,"url":"https://api.github.com/repos/syncany/syncany","forks_url":"https://api.github.com/repos/syncany/syncany/forks","keys_url":"https://api.github.com/repos/syncany/syncany/keys{/key_id}","collaborators_url":"https://api.github.com/repos/syncany/syncany/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/syncany/syncany/teams","hooks_url":"https://api.github.com/repos/syncany/syncany/hooks","issue_events_url":"https://api.github.com/repos/syncany/syncany/issues/events{/number}","events_url":"https://api.github.com/repos/syncany/syncany/events","assignees_url":"https://api.github.com/repos/syncany/syncany/assignees{/user}","branches_url":"https://api.github.com/repos/syncany/syncany/branches{/branch}","tags_url":"https://api.github.com/repos/syncany/syncany/tags","blobs_url":"https://api.github.com/repos/syncany/syncany/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/syncany/syncany/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/syncany/syncany/git/refs{/sha}","trees_url":"https://api.github.com/repos/syncany/syncany/git/trees{/sha}","statuses_url":"https://api.github.com/repos/syncany/syncany/statuses/{sha}","languages_url":"https://api.github.com/repos/syncany/syncany/languages","stargazers_url":"https://api.github.com/repos/syncany/syncany/stargazers","contributors_url":"https://api.github.com/repos/syncany/syncany/contributors","subscribers_url":"https://api.github.com/repos/syncany/syncany/subscribers","subscription_url":"https://api.github.com/repos/syncany/syncany/subscription","commits_url":"https://api.github.com/repos/syncany/syncany/commits{/sha}","git_commits_url":"https://api.github.com/repos/syncany/syncany/git/commits{/sha}","comments_url":"https://api.github.com/repos/syncany/syncany/comments{/number}","issue_comment_url":"https://api.github.com/repos/syncany/syncany/issues/comments/{number}","contents_url":"https://api.github.com/repos/syncany/syncany/contents/{+path}","compare_url":"https://api.github.com/repos/syncany/syncany/compare/{base}...{head}","merges_url":"https://api.github.com/repos/syncany/syncany/merges","archive_url":"https://api.github.com/repos/syncany/syncany/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/syncany/syncany/downloads","issues_url":"https://api.github.com/repos/syncany/syncany/issues{/number}","pulls_url":"https://api.github.com/repos/syncany/syncany/pulls{/number}","milestones_url":"https://api.github.com/repos/syncany/syncany/milestones{/number}","notifications_url":"https://api.github.com/repos/syncany/syncany/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/syncany/syncany/labels{/name}","releases_url":"https://api.github.com/repos/syncany/syncany/releases{/id}","created_at":"2013-10-07T18:46:09Z","updated_at":"2015-02-01T00:50:38Z","pushed_at":"2015-02-01T11:52:07Z","git_url":"git://github.com/syncany/syncany.git","ssh_url":"git@github.com:syncany/syncany.git","clone_url":"https://github.com/syncany/syncany.git","svn_url":"https://github.com/syncany/syncany","homepage":"https://www.syncany.org","size":27259,"stargazers_count":601,"watchers_count":601,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"open_issues_count":54,"forks":71,"open_issues":54,"watchers":601,"default_branch":"develop"}},"base":{"label":"syncany:develop","ref":"develop","sha":"572925c0318f1ca99860cbbdb8d828b5b01114a5","user":{"login":"syncany","id":5913247,"avatar_url":"https://avatars.githubusercontent.com/u/5913247?v=3","gravatar_id":"","url":"https://api.github.com/users/syncany","html_url":"https://github.com/syncany","followers_url":"https://api.github.com/users/syncany/followers","following_url":"https://api.github.com/users/syncany/following{/other_user}","gists_url":"https://api.github.com/users/syncany/gists{/gist_id}","starred_url":"https://api.github.com/users/syncany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syncany/subscriptions","organizations_url":"https://api.github.com/users/syncany/orgs","repos_url":"https://api.github.com/users/syncany/repos","events_url":"https://api.github.com/users/syncany/events{/privacy}","received_events_url":"https://api.github.com/users/syncany/received_events","type":"Organization","site_admin":false},"repo":{"id":13392416,"name":"syncany","full_name":"syncany/syncany","owner":{"login":"syncany","id":5913247,"avatar_url":"https://avatars.githubusercontent.com/u/5913247?v=3","gravatar_id":"","url":"https://api.github.com/users/syncany","html_url":"https://github.com/syncany","followers_url":"https://api.github.com/users/syncany/followers","following_url":"https://api.github.com/users/syncany/following{/other_user}","gists_url":"https://api.github.com/users/syncany/gists{/gist_id}","starred_url":"https://api.github.com/users/syncany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syncany/subscriptions","organizations_url":"https://api.github.com/users/syncany/orgs","repos_url":"https://api.github.com/users/syncany/repos","events_url":"https://api.github.com/users/syncany/events{/privacy}","received_events_url":"https://api.github.com/users/syncany/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/syncany/syncany","description":"Syncany is a cloud storage and filesharing application with a focus on security and abstraction of storage.","fork":false,"url":"https://api.github.com/repos/syncany/syncany","forks_url":"https://api.github.com/repos/syncany/syncany/forks","keys_url":"https://api.github.com/repos/syncany/syncany/keys{/key_id}","collaborators_url":"https://api.github.com/repos/syncany/syncany/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/syncany/syncany/teams","hooks_url":"https://api.github.com/repos/syncany/syncany/hooks","issue_events_url":"https://api.github.com/repos/syncany/syncany/issues/events{/number}","events_url":"https://api.github.com/repos/syncany/syncany/events","assignees_url":"https://api.github.com/repos/syncany/syncany/assignees{/user}","branches_url":"https://api.github.com/repos/syncany/syncany/branches{/branch}","tags_url":"https://api.github.com/repos/syncany/syncany/tags","blobs_url":"https://api.github.com/repos/syncany/syncany/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/syncany/syncany/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/syncany/syncany/git/refs{/sha}","trees_url":"https://api.github.com/repos/syncany/syncany/git/trees{/sha}","statuses_url":"https://api.github.com/repos/syncany/syncany/statuses/{sha}","languages_url":"https://api.github.com/repos/syncany/syncany/languages","stargazers_url":"https://api.github.com/repos/syncany/syncany/stargazers","contributors_url":"https://api.github.com/repos/syncany/syncany/contributors","subscribers_url":"https://api.github.com/repos/syncany/syncany/subscribers","subscription_url":"https://api.github.com/repos/syncany/syncany/subscription","commits_url":"https://api.github.com/repos/syncany/syncany/commits{/sha}","git_commits_url":"https://api.github.com/repos/syncany/syncany/git/commits{/sha}","comments_url":"https://api.github.com/repos/syncany/syncany/comments{/number}","issue_comment_url":"https://api.github.com/repos/syncany/syncany/issues/comments/{number}","contents_url":"https://api.github.com/repos/syncany/syncany/contents/{+path}","compare_url":"https://api.github.com/repos/syncany/syncany/compare/{base}...{head}","merges_url":"https://api.github.com/repos/syncany/syncany/merges","archive_url":"https://api.github.com/repos/syncany/syncany/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/syncany/syncany/downloads","issues_url":"https://api.github.com/repos/syncany/syncany/issues{/number}","pulls_url":"https://api.github.com/repos/syncany/syncany/pulls{/number}","milestones_url":"https://api.github.com/repos/syncany/syncany/milestones{/number}","notifications_url":"https://api.github.com/repos/syncany/syncany/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/syncany/syncany/labels{/name}","releases_url":"https://api.github.com/repos/syncany/syncany/releases{/id}","created_at":"2013-10-07T18:46:09Z","updated_at":"2015-02-01T00:50:38Z","pushed_at":"2015-02-01T11:52:07Z","git_url":"git://github.com/syncany/syncany.git","ssh_url":"git@github.com:syncany/syncany.git","clone_url":"https://github.com/syncany/syncany.git","svn_url":"https://github.com/syncany/syncany","homepage":"https://www.syncany.org","size":27259,"stargazers_count":601,"watchers_count":601,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"open_issues_count":54,"forks":71,"open_issues":54,"watchers":601,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/syncany/syncany/pulls/366"},"html":{"href":"https://github.com/syncany/syncany/pull/366"},"issue":{"href":"https://api.github.com/repos/syncany/syncany/issues/366"},"comments":{"href":"https://api.github.com/repos/syncany/syncany/issues/366/comments"},"review_comments":{"href":"https://api.github.com/repos/syncany/syncany/pulls/366/comments"},"review_comment":{"href":"https://api.github.com/repos/syncany/syncany/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/syncany/syncany/pulls/366/commits"},"statuses":{"href":"https://api.github.com/repos/syncany/syncany/statuses/92cffb8bcaaffb3ab6575efbf210867be7a03597"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":7,"additions":365,"deletions":68,"changed_files":12}}