{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/26766","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/26766/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/26766/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/26766/events","html_url":"https://github.com/rust-lang/rust/pull/26766","id":92981489,"number":26766,"title":"Add missed unix filetypes (block/char devices, fifos and sockets)","user":{"login":"jespino","id":290303,"avatar_url":"https://avatars.githubusercontent.com/u/290303?v=3","gravatar_id":"","url":"https://api.github.com/users/jespino","html_url":"https://github.com/jespino","followers_url":"https://api.github.com/users/jespino/followers","following_url":"https://api.github.com/users/jespino/following{/other_user}","gists_url":"https://api.github.com/users/jespino/gists{/gist_id}","starred_url":"https://api.github.com/users/jespino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jespino/subscriptions","organizations_url":"https://api.github.com/users/jespino/orgs","repos_url":"https://api.github.com/users/jespino/repos","events_url":"https://api.github.com/users/jespino/events{/privacy}","received_events_url":"https://api.github.com/users/jespino/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2015-07-04T07:04:09Z","updated_at":"2015-07-05T08:52:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/26766","html_url":"https://github.com/rust-lang/rust/pull/26766","diff_url":"https://github.com/rust-lang/rust/pull/26766.diff","patch_url":"https://github.com/rust-lang/rust/pull/26766.patch"},"body":"I find that isn't supported on the current API and I think is necesary.\r\n\r\nIt is my first PR to rust (I'm not a rust expert and I'm not sure if this is the better way to propose this thinks), of course any suggestion of change will be welcome.\r\n\r\nI'm almost sure that in windows aren't supported this filetypes, then, i put in the api of win::fs the functions with a fixed false in the response, I hope this is correct."},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/118596636","html_url":"https://github.com/rust-lang/rust/pull/26766#issuecomment-118596636","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/26766","id":118596636,"user":{"login":"jespino","id":290303,"avatar_url":"https://avatars.githubusercontent.com/u/290303?v=3","gravatar_id":"","url":"https://api.github.com/users/jespino","html_url":"https://github.com/jespino","followers_url":"https://api.github.com/users/jespino/followers","following_url":"https://api.github.com/users/jespino/following{/other_user}","gists_url":"https://api.github.com/users/jespino/gists{/gist_id}","starred_url":"https://api.github.com/users/jespino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jespino/subscriptions","organizations_url":"https://api.github.com/users/jespino/orgs","repos_url":"https://api.github.com/users/jespino/repos","events_url":"https://api.github.com/users/jespino/events{/privacy}","received_events_url":"https://api.github.com/users/jespino/received_events","type":"User","site_admin":false},"created_at":"2015-07-05T08:52:35Z","updated_at":"2015-07-05T08:52:35Z","body":"I've added a proposal for the windows device file type, but I'm not sure if this is the correct appoach, because my windows knowledge is very limited. I don't know if the windows devices are char devices or block devices, then I  have written it to returns true for is_char_device and for is_block_device when is a windows device (this may be wrong, anybody with knowledge about windows that can review this?)"}}