{"action":"opened","issue":{"url":"https://api.github.com/repos/JordyMoos/JMTradingHouseSnapshot/issues/1","labels_url":"https://api.github.com/repos/JordyMoos/JMTradingHouseSnapshot/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/JordyMoos/JMTradingHouseSnapshot/issues/1/comments","events_url":"https://api.github.com/repos/JordyMoos/JMTradingHouseSnapshot/issues/1/events","html_url":"https://github.com/JordyMoos/JMTradingHouseSnapshot/issues/1","id":54267300,"number":1,"title":"canContinueScanning could be simplified","user":{"login":"marcusklaas","id":1255413,"avatar_url":"https://avatars.githubusercontent.com/u/1255413?v=3","gravatar_id":"","url":"https://api.github.com/users/marcusklaas","html_url":"https://github.com/marcusklaas","followers_url":"https://api.github.com/users/marcusklaas/followers","following_url":"https://api.github.com/users/marcusklaas/following{/other_user}","gists_url":"https://api.github.com/users/marcusklaas/gists{/gist_id}","starred_url":"https://api.github.com/users/marcusklaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcusklaas/subscriptions","organizations_url":"https://api.github.com/users/marcusklaas/orgs","repos_url":"https://api.github.com/users/marcusklaas/repos","events_url":"https://api.github.com/users/marcusklaas/events{/privacy}","received_events_url":"https://api.github.com/users/marcusklaas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-01-14T00:09:18Z","updated_at":"2015-01-14T00:09:18Z","closed_at":null,"body":"I have browsed through your code, and it looks very good! The comments make it very clear what's going on, even without lua experience. The readme is nice as well.\r\n\r\nThe only suggestion I have is an extremely trivial one: the logic in `canContinueScanning` could be simplified to `return TraidingHouse.isOpen and Scanner.isScanning`. This makes its behaviour a bit more evident in my view. We've talked about this in the past and I remember you weren't convinced 100% so feel free to ignore me (again!) :-P"}}