{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/44674986","id":44674986,"diff_hunk":"@@ -66,19 +67,19 @@ func (s *router) getEvents(ctx context.Context, w http.ResponseWriter, r *http.R\n \tif err := httputils.ParseForm(r); err != nil {\n \t\treturn err\n \t}\n-\tsince, err := httputils.Int64ValueOrDefault(r, \"since\", -1)\n+\tsince, sincen, err := timeutils.ParseTimestamps(r.Form.Get(\"since\"), -1)\n \tif err != nil {\n \t\treturn err\n \t}\n-\tuntil, err := httputils.Int64ValueOrDefault(r, \"until\", -1)\n+\tuntil, untiln, err := timeutils.ParseTimestamps(r.Form.Get(\"until\"), -1)","path":"api/server/router/local/info.go","position":18,"original_position":18,"commit_id":"4c048625b04a1c40c6c18164c4655240c751de3c","original_commit_id":"4c048625b04a1c40c6c18164c4655240c751de3c","user":{"login":"mikebrow","id":12767641,"avatar_url":"https://avatars.githubusercontent.com/u/12767641?v=3","gravatar_id":"","url":"https://api.github.com/users/mikebrow","html_url":"https://github.com/mikebrow","followers_url":"https://api.github.com/users/mikebrow/followers","following_url":"https://api.github.com/users/mikebrow/following{/other_user}","gists_url":"https://api.github.com/users/mikebrow/gists{/gist_id}","starred_url":"https://api.github.com/users/mikebrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikebrow/subscriptions","organizations_url":"https://api.github.com/users/mikebrow/orgs","repos_url":"https://api.github.com/users/mikebrow/repos","events_url":"https://api.github.com/users/mikebrow/events{/privacy}","received_events_url":"https://api.github.com/users/mikebrow/received_events","type":"User","site_admin":false},"body":"will do","created_at":"2015-11-12T16:03:20Z","updated_at":"2015-11-12T16:03:20Z","html_url":"https://github.com/docker/docker/pull/17495#discussion_r44674986","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/17495","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/44674986"},"html":{"href":"https://github.com/docker/docker/pull/17495#discussion_r44674986"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/17495"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/17495","id":49177051,"html_url":"https://github.com/docker/docker/pull/17495","diff_url":"https://github.com/docker/docker/pull/17495.diff","patch_url":"https://github.com/docker/docker/pull/17495.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/17495","number":17495,"state":"open","locked":false,"title":"modifying docker --since and --until to support nanoseconds and time …","user":{"login":"mikebrow","id":12767641,"avatar_url":"https://avatars.githubusercontent.com/u/12767641?v=3","gravatar_id":"","url":"https://api.github.com/users/mikebrow","html_url":"https://github.com/mikebrow","followers_url":"https://api.github.com/users/mikebrow/followers","following_url":"https://api.github.com/users/mikebrow/following{/other_user}","gists_url":"https://api.github.com/users/mikebrow/gists{/gist_id}","starred_url":"https://api.github.com/users/mikebrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikebrow/subscriptions","organizations_url":"https://api.github.com/users/mikebrow/orgs","repos_url":"https://api.github.com/users/mikebrow/repos","events_url":"https://api.github.com/users/mikebrow/events{/privacy}","received_events_url":"https://api.github.com/users/mikebrow/received_events","type":"User","site_admin":false},"body":"Added \".nanoseconds\" to since variable in json that is being passed between client and server for docker log -t --since command, and docker events --since and --until; refactored the code; added a new function for parsing the json received unix timestamp; added additional supported timestamp formats for the command line; and updated the docs to reflect the changes; added enough unit testcases to get to 100% coverage on the two apis in the timeutils package\r\n\r\nFix #16396\r\nFix #16395 \r\nRebases PR #16688\r\n\r\nSigned-off-by: Mike Brown <brownwm@us.ibm.com>","created_at":"2015-10-29T18:00:57Z","updated_at":"2015-11-12T16:03:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"418732cdcfcd57ba1382d134be5a23cc9739832d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/17495/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/17495/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/17495/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/4c048625b04a1c40c6c18164c4655240c751de3c","head":{"label":"mikebrow:docker-tz-and-nanosecond-updates","ref":"docker-tz-and-nanosecond-updates","sha":"4c048625b04a1c40c6c18164c4655240c751de3c","user":{"login":"mikebrow","id":12767641,"avatar_url":"https://avatars.githubusercontent.com/u/12767641?v=3","gravatar_id":"","url":"https://api.github.com/users/mikebrow","html_url":"https://github.com/mikebrow","followers_url":"https://api.github.com/users/mikebrow/followers","following_url":"https://api.github.com/users/mikebrow/following{/other_user}","gists_url":"https://api.github.com/users/mikebrow/gists{/gist_id}","starred_url":"https://api.github.com/users/mikebrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikebrow/subscriptions","organizations_url":"https://api.github.com/users/mikebrow/orgs","repos_url":"https://api.github.com/users/mikebrow/repos","events_url":"https://api.github.com/users/mikebrow/events{/privacy}","received_events_url":"https://api.github.com/users/mikebrow/received_events","type":"User","site_admin":false},"repo":{"id":41167503,"name":"docker","full_name":"mikebrow/docker","owner":{"login":"mikebrow","id":12767641,"avatar_url":"https://avatars.githubusercontent.com/u/12767641?v=3","gravatar_id":"","url":"https://api.github.com/users/mikebrow","html_url":"https://github.com/mikebrow","followers_url":"https://api.github.com/users/mikebrow/followers","following_url":"https://api.github.com/users/mikebrow/following{/other_user}","gists_url":"https://api.github.com/users/mikebrow/gists{/gist_id}","starred_url":"https://api.github.com/users/mikebrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikebrow/subscriptions","organizations_url":"https://api.github.com/users/mikebrow/orgs","repos_url":"https://api.github.com/users/mikebrow/repos","events_url":"https://api.github.com/users/mikebrow/events{/privacy}","received_events_url":"https://api.github.com/users/mikebrow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikebrow/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/mikebrow/docker","forks_url":"https://api.github.com/repos/mikebrow/docker/forks","keys_url":"https://api.github.com/repos/mikebrow/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikebrow/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikebrow/docker/teams","hooks_url":"https://api.github.com/repos/mikebrow/docker/hooks","issue_events_url":"https://api.github.com/repos/mikebrow/docker/issues/events{/number}","events_url":"https://api.github.com/repos/mikebrow/docker/events","assignees_url":"https://api.github.com/repos/mikebrow/docker/assignees{/user}","branches_url":"https://api.github.com/repos/mikebrow/docker/branches{/branch}","tags_url":"https://api.github.com/repos/mikebrow/docker/tags","blobs_url":"https://api.github.com/repos/mikebrow/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikebrow/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikebrow/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikebrow/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikebrow/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/mikebrow/docker/languages","stargazers_url":"https://api.github.com/repos/mikebrow/docker/stargazers","contributors_url":"https://api.github.com/repos/mikebrow/docker/contributors","subscribers_url":"https://api.github.com/repos/mikebrow/docker/subscribers","subscription_url":"https://api.github.com/repos/mikebrow/docker/subscription","commits_url":"https://api.github.com/repos/mikebrow/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikebrow/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikebrow/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikebrow/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikebrow/docker/contents/{+path}","compare_url":"https://api.github.com/repos/mikebrow/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikebrow/docker/merges","archive_url":"https://api.github.com/repos/mikebrow/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikebrow/docker/downloads","issues_url":"https://api.github.com/repos/mikebrow/docker/issues{/number}","pulls_url":"https://api.github.com/repos/mikebrow/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/mikebrow/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/mikebrow/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikebrow/docker/labels{/name}","releases_url":"https://api.github.com/repos/mikebrow/docker/releases{/id}","created_at":"2015-08-21T17:03:58Z","updated_at":"2015-08-21T17:04:06Z","pushed_at":"2015-11-05T15:43:07Z","git_url":"git://github.com/mikebrow/docker.git","ssh_url":"git@github.com:mikebrow/docker.git","clone_url":"https://github.com/mikebrow/docker.git","svn_url":"https://github.com/mikebrow/docker","homepage":"http://www.docker.com","size":74005,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"8d62f243c725c6eba43ca59ef17407e43004a238","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-11-12T15:07:14Z","pushed_at":"2015-11-12T15:56:34Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":285834,"stargazers_count":26149,"watchers_count":26149,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7008,"mirror_url":null,"open_issues_count":1208,"forks":7008,"open_issues":1208,"watchers":26149,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/17495"},"html":{"href":"https://github.com/docker/docker/pull/17495"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/17495"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/17495/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/17495/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/17495/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/4c048625b04a1c40c6c18164c4655240c751de3c"}}}}