{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/33554612","id":33554612,"diff_hunk":"@@ -150,7 +150,13 @@ void CPVRManager::OnSettingChanged(const CSetting *setting)\n     return;\n \n   const std::string &settingId = setting->GetId();\n-  if (settingId == \"pvrmanager.enabled\")\n+  if (settingId == \"pvrmanager.backendchannelorder\" || settingId == \"pvrmanager.usebackendchannelnumbers\")\n+  {\n+    // delegate call to the underlying groups\n+    g_PVRChannelGroups->Get(true)->OnSettingChanged(setting);","path":"xbmc/pvr/PVRManager.cpp","position":8,"original_position":8,"commit_id":"4f4feb0dcfa8252654cb9a76717d85908f7d83f7","original_commit_id":"4f4feb0dcfa8252654cb9a76717d85908f7d83f7","user":{"login":"opdenkamp","id":441806,"avatar_url":"https://avatars.githubusercontent.com/u/441806?v=3","gravatar_id":"","url":"https://api.github.com/users/opdenkamp","html_url":"https://github.com/opdenkamp","followers_url":"https://api.github.com/users/opdenkamp/followers","following_url":"https://api.github.com/users/opdenkamp/following{/other_user}","gists_url":"https://api.github.com/users/opdenkamp/gists{/gist_id}","starred_url":"https://api.github.com/users/opdenkamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opdenkamp/subscriptions","organizations_url":"https://api.github.com/users/opdenkamp/orgs","repos_url":"https://api.github.com/users/opdenkamp/repos","events_url":"https://api.github.com/users/opdenkamp/events{/privacy}","received_events_url":"https://api.github.com/users/opdenkamp/received_events","type":"User","site_admin":false},"body":"why don't you register the callback directly in `CPVRChannelGroup` instead of pvrmanager -> groups -> group?","created_at":"2015-06-30T09:22:40Z","updated_at":"2015-06-30T09:22:40Z","html_url":"https://github.com/xbmc/xbmc/pull/7368#discussion_r33554612","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/7368","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/33554612"},"html":{"href":"https://github.com/xbmc/xbmc/pull/7368#discussion_r33554612"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7368"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/7368","id":38855107,"html_url":"https://github.com/xbmc/xbmc/pull/7368","diff_url":"https://github.com/xbmc/xbmc/pull/7368.diff","patch_url":"https://github.com/xbmc/xbmc/pull/7368.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/7368","number":7368,"state":"open","locked":false,"title":"[pvr] fix CPVRChannelGroup::OnSettingChanged won't get called","user":{"login":"xhaggi","id":1878991,"avatar_url":"https://avatars.githubusercontent.com/u/1878991?v=3","gravatar_id":"","url":"https://api.github.com/users/xhaggi","html_url":"https://github.com/xhaggi","followers_url":"https://api.github.com/users/xhaggi/followers","following_url":"https://api.github.com/users/xhaggi/following{/other_user}","gists_url":"https://api.github.com/users/xhaggi/gists{/gist_id}","starred_url":"https://api.github.com/users/xhaggi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xhaggi/subscriptions","organizations_url":"https://api.github.com/users/xhaggi/orgs","repos_url":"https://api.github.com/users/xhaggi/repos","events_url":"https://api.github.com/users/xhaggi/events{/privacy}","received_events_url":"https://api.github.com/users/xhaggi/received_events","type":"User","site_admin":false},"body":"As pointed out by @Jalle19 the settings callback method `CPVRChannelGroup::OnSettingChanged` won't get called because the class not registered in `CSettings` as a callback listener. The reason for that is `CPVRChannelGroup` is not a singleton and we need to register each instance of `CPVRChannelGroup` as a callback listener to work properly.\r\n\r\nThis will fixes the issue by delegation the call from `CPVRManager::OnSettingChanged` to the radio and tv channel groups instances `CPVRChannelGroups::OnSettingChanged` and from there to each group instances `CPVRChannelGroup::OnSettingChanged`.","created_at":"2015-06-30T08:51:48Z","updated_at":"2015-06-30T09:22:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43ae725f44ed5aaf1db51b6236fe9169b84e5f11","assignee":null,"milestone":{"url":"https://api.github.com/repos/xbmc/xbmc/milestones/62","html_url":"https://github.com/xbmc/xbmc/milestones/Isengard%2015.0-rc1","labels_url":"https://api.github.com/repos/xbmc/xbmc/milestones/62/labels","id":1101492,"number":62,"title":"Isengard 15.0-rc1","description":"","creator":{"login":"MartijnKaijser","id":907436,"avatar_url":"https://avatars.githubusercontent.com/u/907436?v=3","gravatar_id":"","url":"https://api.github.com/users/MartijnKaijser","html_url":"https://github.com/MartijnKaijser","followers_url":"https://api.github.com/users/MartijnKaijser/followers","following_url":"https://api.github.com/users/MartijnKaijser/following{/other_user}","gists_url":"https://api.github.com/users/MartijnKaijser/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnKaijser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnKaijser/subscriptions","organizations_url":"https://api.github.com/users/MartijnKaijser/orgs","repos_url":"https://api.github.com/users/MartijnKaijser/repos","events_url":"https://api.github.com/users/MartijnKaijser/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnKaijser/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":71,"state":"open","created_at":"2015-05-08T07:50:40Z","updated_at":"2015-06-30T08:52:03Z","due_on":"2015-06-27T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/7368/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/7368/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/7368/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/4f4feb0dcfa8252654cb9a76717d85908f7d83f7","head":{"label":"xhaggi:pvr-fix-channelgroup-onsettingchanged","ref":"pvr-fix-channelgroup-onsettingchanged","sha":"4f4feb0dcfa8252654cb9a76717d85908f7d83f7","user":{"login":"xhaggi","id":1878991,"avatar_url":"https://avatars.githubusercontent.com/u/1878991?v=3","gravatar_id":"","url":"https://api.github.com/users/xhaggi","html_url":"https://github.com/xhaggi","followers_url":"https://api.github.com/users/xhaggi/followers","following_url":"https://api.github.com/users/xhaggi/following{/other_user}","gists_url":"https://api.github.com/users/xhaggi/gists{/gist_id}","starred_url":"https://api.github.com/users/xhaggi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xhaggi/subscriptions","organizations_url":"https://api.github.com/users/xhaggi/orgs","repos_url":"https://api.github.com/users/xhaggi/repos","events_url":"https://api.github.com/users/xhaggi/events{/privacy}","received_events_url":"https://api.github.com/users/xhaggi/received_events","type":"User","site_admin":false},"repo":{"id":5698705,"name":"xbmc","full_name":"xhaggi/xbmc","owner":{"login":"xhaggi","id":1878991,"avatar_url":"https://avatars.githubusercontent.com/u/1878991?v=3","gravatar_id":"","url":"https://api.github.com/users/xhaggi","html_url":"https://github.com/xhaggi","followers_url":"https://api.github.com/users/xhaggi/followers","following_url":"https://api.github.com/users/xhaggi/following{/other_user}","gists_url":"https://api.github.com/users/xhaggi/gists{/gist_id}","starred_url":"https://api.github.com/users/xhaggi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xhaggi/subscriptions","organizations_url":"https://api.github.com/users/xhaggi/orgs","repos_url":"https://api.github.com/users/xhaggi/repos","events_url":"https://api.github.com/users/xhaggi/events{/privacy}","received_events_url":"https://api.github.com/users/xhaggi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xhaggi/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/xhaggi/xbmc","forks_url":"https://api.github.com/repos/xhaggi/xbmc/forks","keys_url":"https://api.github.com/repos/xhaggi/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xhaggi/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xhaggi/xbmc/teams","hooks_url":"https://api.github.com/repos/xhaggi/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xhaggi/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xhaggi/xbmc/events","assignees_url":"https://api.github.com/repos/xhaggi/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xhaggi/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xhaggi/xbmc/tags","blobs_url":"https://api.github.com/repos/xhaggi/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xhaggi/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xhaggi/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xhaggi/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xhaggi/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xhaggi/xbmc/languages","stargazers_url":"https://api.github.com/repos/xhaggi/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xhaggi/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xhaggi/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xhaggi/xbmc/subscription","commits_url":"https://api.github.com/repos/xhaggi/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xhaggi/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xhaggi/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xhaggi/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xhaggi/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xhaggi/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xhaggi/xbmc/merges","archive_url":"https://api.github.com/repos/xhaggi/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xhaggi/xbmc/downloads","issues_url":"https://api.github.com/repos/xhaggi/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xhaggi/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xhaggi/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xhaggi/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xhaggi/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xhaggi/xbmc/releases{/id}","created_at":"2012-09-06T07:06:44Z","updated_at":"2015-04-20T10:44:49Z","pushed_at":"2015-06-30T08:44:34Z","git_url":"git://github.com/xhaggi/xbmc.git","ssh_url":"git@github.com:xhaggi/xbmc.git","clone_url":"https://github.com/xhaggi/xbmc.git","svn_url":"https://github.com/xhaggi/xbmc","homepage":"http://xbmc.org","size":514504,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"9fb30126738c317815d38450ae97b318ea045fbc","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","created_at":"2011-01-03T21:18:51Z","updated_at":"2015-06-30T00:02:29Z","pushed_at":"2015-06-30T08:51:48Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1854571,"stargazers_count":3979,"watchers_count":3979,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2897,"mirror_url":null,"open_issues_count":249,"forks":2897,"open_issues":249,"watchers":3979,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7368"},"html":{"href":"https://github.com/xbmc/xbmc/pull/7368"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/7368"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/7368/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7368/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7368/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/4f4feb0dcfa8252654cb9a76717d85908f7d83f7"}}}}