{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/hhvm/issues/4648","labels_url":"https://api.github.com/repos/facebook/hhvm/issues/4648/labels{/name}","comments_url":"https://api.github.com/repos/facebook/hhvm/issues/4648/comments","events_url":"https://api.github.com/repos/facebook/hhvm/issues/4648/events","html_url":"https://github.com/facebook/hhvm/pull/4648","id":54320100,"number":4648,"title":"Remove $ENV config from FindMySQL.cmake","user":{"login":"jrobeson","id":56908,"avatar_url":"https://avatars.githubusercontent.com/u/56908?v=3","gravatar_id":"","url":"https://api.github.com/users/jrobeson","html_url":"https://github.com/jrobeson","followers_url":"https://api.github.com/users/jrobeson/followers","following_url":"https://api.github.com/users/jrobeson/following{/other_user}","gists_url":"https://api.github.com/users/jrobeson/gists{/gist_id}","starred_url":"https://api.github.com/users/jrobeson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrobeson/subscriptions","organizations_url":"https://api.github.com/users/jrobeson/orgs","repos_url":"https://api.github.com/users/jrobeson/repos","events_url":"https://api.github.com/users/jrobeson/events{/privacy}","received_events_url":"https://api.github.com/users/jrobeson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-14T13:10:18Z","updated_at":"2015-01-14T13:14:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/hhvm/pulls/4648","html_url":"https://github.com/facebook/hhvm/pull/4648","diff_url":"https://github.com/facebook/hhvm/pull/4648.diff","patch_url":"https://github.com/facebook/hhvm/pull/4648.patch"},"body":"These are seemingly superflous, considering that you can\r\nstill configure which library and include directory to use\r\nwith cmake -D parameters.\r\n\r\nI was figuring out why\r\n\r\n # cmake .\r\n\r\n show showing me:\r\n\r\n  -- MySQL Include dir: /usr/include/mysql  library dir: /lib/mysql\r\n\r\nwhen it should have been:\r\n\r\n  -- MySQL Include dir: /usr/include/mysql  library dir: /usr/lib64/mysqlh\r\n\r\n\r\nFor some reason that i don't comprehend, this particular line was causing the problem:\r\n\r\n$ENV{MYSQL_DIR}/lib/mysql\r\n\r\n\r\nI didn't touch the windows section because such variables may or may not still be useful there, I don't know enough about windows stuff to be able to tell.\r\n\r\nIf you think they should be removed too, then i will add that to this PR also."},"comment":{"url":"https://api.github.com/repos/facebook/hhvm/issues/comments/69913883","html_url":"https://github.com/facebook/hhvm/pull/4648#issuecomment-69913883","issue_url":"https://api.github.com/repos/facebook/hhvm/issues/4648","id":69913883,"user":{"login":"facebook-github-bot","id":6422482,"avatar_url":"https://avatars.githubusercontent.com/u/6422482?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook-github-bot","html_url":"https://github.com/facebook-github-bot","followers_url":"https://api.github.com/users/facebook-github-bot/followers","following_url":"https://api.github.com/users/facebook-github-bot/following{/other_user}","gists_url":"https://api.github.com/users/facebook-github-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook-github-bot/subscriptions","organizations_url":"https://api.github.com/users/facebook-github-bot/orgs","repos_url":"https://api.github.com/users/facebook-github-bot/repos","events_url":"https://api.github.com/users/facebook-github-bot/events{/privacy}","received_events_url":"https://api.github.com/users/facebook-github-bot/received_events","type":"User","site_admin":false},"created_at":"2015-01-14T13:14:09Z","updated_at":"2015-01-14T13:14:09Z","body":"This pull request has been imported into Phabricator, and discussion and review of the diff will take place at https://reviews.facebook.net/D31509"}}