{"push_id":738645379,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"57787ac81444938a876f185cdd73875c8f53e208","before":"f4ee22be03bb8318b1e0f00e116be231ba12fdef","commits":[{"sha":"57787ac81444938a876f185cdd73875c8f53e208","author":{"email":"1fa2ef4755a9226cb9a0a4840bd89b158ac71391@openssl.org","name":"Matt Caswell"},"message":"Remove support for SSL3_FLAGS_DELAY_CLIENT_FINISHED\n\nThis flag was not set anywhere within the codebase (only read). It could\nonly be set by an app reaching directly into s->s3->flags and setting it\ndirectly. However that method became impossible when libssl was opaquified.\n\nEven in 1.0.2/1.0.1 if an app set the flag directly it is only relevant to\nssl3_connect(), which calls SSL_clear() during initialisation that clears\nany flag settings. Therefore it could take effect if the app set the flag\nafter the handshake has started but before it completed. It seems quite\nunlikely that any apps really do this (especially as it is completely\nundocumented).\n\nThe purpose of the flag is suppress flushing of the write bio on the client\nside at the end of the handshake after the client has written the Finished\nmessage whilst resuming a session. This enables the client to send\napplication data as part of the same flight as the Finished message.\n\nThis flag also controls the setting of a second flag SSL3_FLAGS_POP_BUFFER.\nThere is an interesting comment in the code about this second flag in the\nimplementation of ssl3_write:\n\n\t/* This is an experimental flag that sends the\n\t * last handshake message in the same packet as the first\n\t * use data - used to see if it helps the TCP protocol during\n\t * session-id reuse */\n\nIt seems the experiment did not work because as far as I can tell nothing\nis using this code. The above comment has been in the code since SSLeay.\n\nThis commit removes support for SSL3_FLAGS_DELAY_CLIENT_FINISHED, as well\nas the associated SSL3_FLAGS_POP_BUFFER.\n\nReviewed-by: Rich Salz <rsalz@openssl.org>","distinct":true,"url":"https://api.github.com/repos/rhuijben/openssl/commits/57787ac81444938a876f185cdd73875c8f53e208"}]}