{"action":"created","issue":{"url":"https://api.github.com/repos/textpattern/textpacks/issues/133","labels_url":"https://api.github.com/repos/textpattern/textpacks/issues/133/labels{/name}","comments_url":"https://api.github.com/repos/textpattern/textpacks/issues/133/comments","events_url":"https://api.github.com/repos/textpattern/textpacks/issues/133/events","html_url":"https://github.com/textpattern/textpacks/issues/133","id":115759109,"number":133,"title":"New strings: password alterations/strength","user":{"login":"Bloke","id":21252,"avatar_url":"https://avatars.githubusercontent.com/u/21252?v=3","gravatar_id":"","url":"https://api.github.com/users/Bloke","html_url":"https://github.com/Bloke","followers_url":"https://api.github.com/users/Bloke/followers","following_url":"https://api.github.com/users/Bloke/following{/other_user}","gists_url":"https://api.github.com/users/Bloke/gists{/gist_id}","starred_url":"https://api.github.com/users/Bloke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bloke/subscriptions","organizations_url":"https://api.github.com/users/Bloke/orgs","repos_url":"https://api.github.com/users/Bloke/repos","events_url":"https://api.github.com/users/Bloke/events{/privacy}","received_events_url":"https://api.github.com/users/Bloke/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/textpattern/textpacks/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/textpattern/textpacks/milestones/1","html_url":"https://github.com/textpattern/textpacks/milestones/4.6","labels_url":"https://api.github.com/repos/textpattern/textpacks/milestones/1/labels","id":1353015,"number":1,"title":"4.6","description":"","creator":{"login":"philwareham","id":413665,"avatar_url":"https://avatars.githubusercontent.com/u/413665?v=3","gravatar_id":"","url":"https://api.github.com/users/philwareham","html_url":"https://github.com/philwareham","followers_url":"https://api.github.com/users/philwareham/followers","following_url":"https://api.github.com/users/philwareham/following{/other_user}","gists_url":"https://api.github.com/users/philwareham/gists{/gist_id}","starred_url":"https://api.github.com/users/philwareham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philwareham/subscriptions","organizations_url":"https://api.github.com/users/philwareham/orgs","repos_url":"https://api.github.com/users/philwareham/repos","events_url":"https://api.github.com/users/philwareham/events{/privacy}","received_events_url":"https://api.github.com/users/philwareham/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2015-10-13T11:29:25Z","updated_at":"2015-11-08T20:50:54Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2015-11-08T20:50:54Z","updated_at":"2015-11-09T10:21:50Z","closed_at":null,"body":"Bunch of new strings (sorry). This is just a placeholder issue right now, as the string names may alter in the next few days based on feedback from @philwareham on the password strength meter. But tentatively we have, in English:\r\n\r\n* `password_strength` : \"Strength:\"\r\n* `password_poor` : \"poor\"\r\n* `password_weak` : \"weak\"\r\n* `password_medium` : \"medium\"\r\n* `password_strong` : \"strong\"\r\n* `password_strongest` : \"strongest\"\r\n\r\nAnd the following one goes in the body of the email sent to the user when their password has been changed via the new screen:\r\n\r\n* `password_change_confirmation` : \"Your password has been changed. If you did not authorize this change then please contact your Textpattern administrator.\"\r\n\r\n(or something along those lines... maybe? Dunno how much detail to include here. But essentially it follows directly on from the `password_reset_confirmation` email, so should be in the same stylistic vein. It replaces the 'mail it to me' plaintext message).\r\n\r\nI'm not sure on the names of the password strength levels yet. If we're going with 'poor', 'weak', and 'medium', maybe we should use 'password_good' and 'password_excellent' instead?\r\n\r\nAlso, `password_strength` is currently a separate entity with no replacement for the value. That's fine up to a point but it introduces a possible localisation issue as it could do with a space at the end of the string so it renders:\r\n\r\n    Strength: poor\r\n\r\nSpaces at the end of `gTxt()` strings are likely to get swallowed if strings are trimmed. The other alternative is to put the space in manually (in code) but that's not very RTL friendly. A third option is to add a parameter so the `password_strength` definition is:\r\n\r\n    Strength: {strength}\r\n\r\nBut since each of the possible strengths need localisation too, that means yucky code that has a `gTxt()` inside a `gTxt()`. Not the end of the world, granted.\r\n\r\nFinally, we could ditch `password_strength` entirely and just go with the five strengths and repeat the prefix:\r\n\r\n* `password_poor` : \"Strength: poor\"\r\n* `password_weak` : \"Strength: weak\"\r\n* `password_medium` : \"Strength: medium\"\r\n* ...\r\n\r\nNot very DRY. But save a string, save the world.\r\n\r\nAny advice / improvements appreciated."},"comment":{"url":"https://api.github.com/repos/textpattern/textpacks/issues/comments/155021599","html_url":"https://github.com/textpattern/textpacks/issues/133#issuecomment-155021599","issue_url":"https://api.github.com/repos/textpattern/textpacks/issues/133","id":155021599,"user":{"login":"philwareham","id":413665,"avatar_url":"https://avatars.githubusercontent.com/u/413665?v=3","gravatar_id":"","url":"https://api.github.com/users/philwareham","html_url":"https://github.com/philwareham","followers_url":"https://api.github.com/users/philwareham/followers","following_url":"https://api.github.com/users/philwareham/following{/other_user}","gists_url":"https://api.github.com/users/philwareham/gists{/gist_id}","starred_url":"https://api.github.com/users/philwareham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philwareham/subscriptions","organizations_url":"https://api.github.com/users/philwareham/orgs","repos_url":"https://api.github.com/users/philwareham/repos","events_url":"https://api.github.com/users/philwareham/events{/privacy}","received_events_url":"https://api.github.com/users/philwareham/received_events","type":"User","site_admin":false},"created_at":"2015-11-09T10:21:50Z","updated_at":"2015-11-09T10:21:50Z","body":"Google uses:\r\n\r\nToo short (although that is not really accurate) - 'Poor' would be better for us to use\r\nWeak\r\nFair\r\nGood\r\nStrong"}}