{"action":"created","comment":{"url":"https://api.github.com/repos/falconry/falcon/pulls/comments/42900968","id":42900968,"diff_hunk":"@@ -1028,6 +1059,22 @@ def _parse_form_urlencoded(self):\n \n             self._params.update(extra_params)\n \n+    def _parse_rfc_forwarded(self):\n+        \"\"\"rfc 7239\"\"\"\n+        addr = []\n+        for forwarded in self.env['HTTP_FORWARDED'].split(','):\n+            for param in forwarded.split(';'):\n+                param = param.strip().split('=', 1)\n+                if len(param) == 1:\n+                    continue\n+                key, val = param\n+                if key.lower() not in ('for', 'by'):","path":"falcon/request.py","position":74,"original_position":74,"commit_id":"0f53bc62cd084efde52bfa60a5d531d46349072b","original_commit_id":"0f53bc62cd084efde52bfa60a5d531d46349072b","user":{"login":"philiptzou","id":809865,"avatar_url":"https://avatars.githubusercontent.com/u/809865?v=3","gravatar_id":"","url":"https://api.github.com/users/philiptzou","html_url":"https://github.com/philiptzou","followers_url":"https://api.github.com/users/philiptzou/followers","following_url":"https://api.github.com/users/philiptzou/following{/other_user}","gists_url":"https://api.github.com/users/philiptzou/gists{/gist_id}","starred_url":"https://api.github.com/users/philiptzou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philiptzou/subscriptions","organizations_url":"https://api.github.com/users/philiptzou/orgs","repos_url":"https://api.github.com/users/philiptzou/repos","events_url":"https://api.github.com/users/philiptzou/events{/privacy}","received_events_url":"https://api.github.com/users/philiptzou/received_events","type":"User","site_admin":false},"body":"Good point, will do the modification (only return \"for\" parameters) with the `unquote_string`.","created_at":"2015-10-23T18:52:38Z","updated_at":"2015-10-23T18:52:38Z","html_url":"https://github.com/falconry/falcon/pull/599#discussion_r42900968","pull_request_url":"https://api.github.com/repos/falconry/falcon/pulls/599","_links":{"self":{"href":"https://api.github.com/repos/falconry/falcon/pulls/comments/42900968"},"html":{"href":"https://github.com/falconry/falcon/pull/599#discussion_r42900968"},"pull_request":{"href":"https://api.github.com/repos/falconry/falcon/pulls/599"}}},"pull_request":{"url":"https://api.github.com/repos/falconry/falcon/pulls/599","id":44594322,"html_url":"https://github.com/falconry/falcon/pull/599","diff_url":"https://github.com/falconry/falcon/pull/599.diff","patch_url":"https://github.com/falconry/falcon/pull/599.patch","issue_url":"https://api.github.com/repos/falconry/falcon/issues/599","number":599,"state":"open","locked":false,"title":"Add `access_route` and `remote_addr` to Request object","user":{"login":"philiptzou","id":809865,"avatar_url":"https://avatars.githubusercontent.com/u/809865?v=3","gravatar_id":"","url":"https://api.github.com/users/philiptzou","html_url":"https://github.com/philiptzou","followers_url":"https://api.github.com/users/philiptzou/followers","following_url":"https://api.github.com/users/philiptzou/following{/other_user}","gists_url":"https://api.github.com/users/philiptzou/gists{/gist_id}","starred_url":"https://api.github.com/users/philiptzou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philiptzou/subscriptions","organizations_url":"https://api.github.com/users/philiptzou/orgs","repos_url":"https://api.github.com/users/philiptzou/repos","events_url":"https://api.github.com/users/philiptzou/events{/privacy}","received_events_url":"https://api.github.com/users/philiptzou/received_events","type":"User","site_admin":false},"body":"which is similar to Werkzeug but more powerful\r\n\r\nSupported:\r\n\r\n1. fetch from \"Forwarded\" header (defined by RFC7239)\r\n2. fetch from \"X-Forwarded-For\" header\r\n3. fetch from \"X-Read-IP\" header\r\n4. fetch from wsgi \"REMOTE_ADDR\" header\r\n\r\nRelated to #539 and #598","created_at":"2015-09-09T20:10:14Z","updated_at":"2015-10-23T18:52:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b200e7624b76a2a152e045a4eaeab3d4ea81ac3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/falconry/falcon/pulls/599/commits","review_comments_url":"https://api.github.com/repos/falconry/falcon/pulls/599/comments","review_comment_url":"https://api.github.com/repos/falconry/falcon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/falconry/falcon/issues/599/comments","statuses_url":"https://api.github.com/repos/falconry/falcon/statuses/0f53bc62cd084efde52bfa60a5d531d46349072b","head":{"label":"philiptzou:pull-request-access-route","ref":"pull-request-access-route","sha":"0f53bc62cd084efde52bfa60a5d531d46349072b","user":{"login":"philiptzou","id":809865,"avatar_url":"https://avatars.githubusercontent.com/u/809865?v=3","gravatar_id":"","url":"https://api.github.com/users/philiptzou","html_url":"https://github.com/philiptzou","followers_url":"https://api.github.com/users/philiptzou/followers","following_url":"https://api.github.com/users/philiptzou/following{/other_user}","gists_url":"https://api.github.com/users/philiptzou/gists{/gist_id}","starred_url":"https://api.github.com/users/philiptzou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philiptzou/subscriptions","organizations_url":"https://api.github.com/users/philiptzou/orgs","repos_url":"https://api.github.com/users/philiptzou/repos","events_url":"https://api.github.com/users/philiptzou/events{/privacy}","received_events_url":"https://api.github.com/users/philiptzou/received_events","type":"User","site_admin":false},"repo":{"id":41977987,"name":"falcon","full_name":"philiptzou/falcon","owner":{"login":"philiptzou","id":809865,"avatar_url":"https://avatars.githubusercontent.com/u/809865?v=3","gravatar_id":"","url":"https://api.github.com/users/philiptzou","html_url":"https://github.com/philiptzou","followers_url":"https://api.github.com/users/philiptzou/followers","following_url":"https://api.github.com/users/philiptzou/following{/other_user}","gists_url":"https://api.github.com/users/philiptzou/gists{/gist_id}","starred_url":"https://api.github.com/users/philiptzou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philiptzou/subscriptions","organizations_url":"https://api.github.com/users/philiptzou/orgs","repos_url":"https://api.github.com/users/philiptzou/repos","events_url":"https://api.github.com/users/philiptzou/events{/privacy}","received_events_url":"https://api.github.com/users/philiptzou/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/philiptzou/falcon","description":"Falcon is a high-performance Python framework for building cloud APIs, smart proxies, and app backends.","fork":true,"url":"https://api.github.com/repos/philiptzou/falcon","forks_url":"https://api.github.com/repos/philiptzou/falcon/forks","keys_url":"https://api.github.com/repos/philiptzou/falcon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/philiptzou/falcon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/philiptzou/falcon/teams","hooks_url":"https://api.github.com/repos/philiptzou/falcon/hooks","issue_events_url":"https://api.github.com/repos/philiptzou/falcon/issues/events{/number}","events_url":"https://api.github.com/repos/philiptzou/falcon/events","assignees_url":"https://api.github.com/repos/philiptzou/falcon/assignees{/user}","branches_url":"https://api.github.com/repos/philiptzou/falcon/branches{/branch}","tags_url":"https://api.github.com/repos/philiptzou/falcon/tags","blobs_url":"https://api.github.com/repos/philiptzou/falcon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/philiptzou/falcon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/philiptzou/falcon/git/refs{/sha}","trees_url":"https://api.github.com/repos/philiptzou/falcon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/philiptzou/falcon/statuses/{sha}","languages_url":"https://api.github.com/repos/philiptzou/falcon/languages","stargazers_url":"https://api.github.com/repos/philiptzou/falcon/stargazers","contributors_url":"https://api.github.com/repos/philiptzou/falcon/contributors","subscribers_url":"https://api.github.com/repos/philiptzou/falcon/subscribers","subscription_url":"https://api.github.com/repos/philiptzou/falcon/subscription","commits_url":"https://api.github.com/repos/philiptzou/falcon/commits{/sha}","git_commits_url":"https://api.github.com/repos/philiptzou/falcon/git/commits{/sha}","comments_url":"https://api.github.com/repos/philiptzou/falcon/comments{/number}","issue_comment_url":"https://api.github.com/repos/philiptzou/falcon/issues/comments{/number}","contents_url":"https://api.github.com/repos/philiptzou/falcon/contents/{+path}","compare_url":"https://api.github.com/repos/philiptzou/falcon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/philiptzou/falcon/merges","archive_url":"https://api.github.com/repos/philiptzou/falcon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/philiptzou/falcon/downloads","issues_url":"https://api.github.com/repos/philiptzou/falcon/issues{/number}","pulls_url":"https://api.github.com/repos/philiptzou/falcon/pulls{/number}","milestones_url":"https://api.github.com/repos/philiptzou/falcon/milestones{/number}","notifications_url":"https://api.github.com/repos/philiptzou/falcon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/philiptzou/falcon/labels{/name}","releases_url":"https://api.github.com/repos/philiptzou/falcon/releases{/id}","created_at":"2015-09-05T22:40:07Z","updated_at":"2015-09-05T22:40:07Z","pushed_at":"2015-10-18T21:09:52Z","git_url":"git://github.com/philiptzou/falcon.git","ssh_url":"git@github.com:philiptzou/falcon.git","clone_url":"https://github.com/philiptzou/falcon.git","svn_url":"https://github.com/philiptzou/falcon","homepage":"http://falconframework.org","size":12103,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"falconry:master","ref":"master","sha":"3431ac326141894b689a39e83ef87cd1e4f557bc","user":{"login":"falconry","id":11353642,"avatar_url":"https://avatars.githubusercontent.com/u/11353642?v=3","gravatar_id":"","url":"https://api.github.com/users/falconry","html_url":"https://github.com/falconry","followers_url":"https://api.github.com/users/falconry/followers","following_url":"https://api.github.com/users/falconry/following{/other_user}","gists_url":"https://api.github.com/users/falconry/gists{/gist_id}","starred_url":"https://api.github.com/users/falconry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/falconry/subscriptions","organizations_url":"https://api.github.com/users/falconry/orgs","repos_url":"https://api.github.com/users/falconry/repos","events_url":"https://api.github.com/users/falconry/events{/privacy}","received_events_url":"https://api.github.com/users/falconry/received_events","type":"Organization","site_admin":false},"repo":{"id":7040500,"name":"falcon","full_name":"falconry/falcon","owner":{"login":"falconry","id":11353642,"avatar_url":"https://avatars.githubusercontent.com/u/11353642?v=3","gravatar_id":"","url":"https://api.github.com/users/falconry","html_url":"https://github.com/falconry","followers_url":"https://api.github.com/users/falconry/followers","following_url":"https://api.github.com/users/falconry/following{/other_user}","gists_url":"https://api.github.com/users/falconry/gists{/gist_id}","starred_url":"https://api.github.com/users/falconry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/falconry/subscriptions","organizations_url":"https://api.github.com/users/falconry/orgs","repos_url":"https://api.github.com/users/falconry/repos","events_url":"https://api.github.com/users/falconry/events{/privacy}","received_events_url":"https://api.github.com/users/falconry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/falconry/falcon","description":"Falcon is a high-performance Python framework for building cloud APIs, smart proxies, and app backends.","fork":false,"url":"https://api.github.com/repos/falconry/falcon","forks_url":"https://api.github.com/repos/falconry/falcon/forks","keys_url":"https://api.github.com/repos/falconry/falcon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/falconry/falcon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/falconry/falcon/teams","hooks_url":"https://api.github.com/repos/falconry/falcon/hooks","issue_events_url":"https://api.github.com/repos/falconry/falcon/issues/events{/number}","events_url":"https://api.github.com/repos/falconry/falcon/events","assignees_url":"https://api.github.com/repos/falconry/falcon/assignees{/user}","branches_url":"https://api.github.com/repos/falconry/falcon/branches{/branch}","tags_url":"https://api.github.com/repos/falconry/falcon/tags","blobs_url":"https://api.github.com/repos/falconry/falcon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/falconry/falcon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/falconry/falcon/git/refs{/sha}","trees_url":"https://api.github.com/repos/falconry/falcon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/falconry/falcon/statuses/{sha}","languages_url":"https://api.github.com/repos/falconry/falcon/languages","stargazers_url":"https://api.github.com/repos/falconry/falcon/stargazers","contributors_url":"https://api.github.com/repos/falconry/falcon/contributors","subscribers_url":"https://api.github.com/repos/falconry/falcon/subscribers","subscription_url":"https://api.github.com/repos/falconry/falcon/subscription","commits_url":"https://api.github.com/repos/falconry/falcon/commits{/sha}","git_commits_url":"https://api.github.com/repos/falconry/falcon/git/commits{/sha}","comments_url":"https://api.github.com/repos/falconry/falcon/comments{/number}","issue_comment_url":"https://api.github.com/repos/falconry/falcon/issues/comments{/number}","contents_url":"https://api.github.com/repos/falconry/falcon/contents/{+path}","compare_url":"https://api.github.com/repos/falconry/falcon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/falconry/falcon/merges","archive_url":"https://api.github.com/repos/falconry/falcon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/falconry/falcon/downloads","issues_url":"https://api.github.com/repos/falconry/falcon/issues{/number}","pulls_url":"https://api.github.com/repos/falconry/falcon/pulls{/number}","milestones_url":"https://api.github.com/repos/falconry/falcon/milestones{/number}","notifications_url":"https://api.github.com/repos/falconry/falcon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/falconry/falcon/labels{/name}","releases_url":"https://api.github.com/repos/falconry/falcon/releases{/id}","created_at":"2012-12-06T18:17:51Z","updated_at":"2015-10-23T17:50:47Z","pushed_at":"2015-10-19T20:22:54Z","git_url":"git://github.com/falconry/falcon.git","ssh_url":"git@github.com:falconry/falcon.git","clone_url":"https://github.com/falconry/falcon.git","svn_url":"https://github.com/falconry/falcon","homepage":"http://falconframework.org","size":15679,"stargazers_count":2209,"watchers_count":2209,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":256,"mirror_url":null,"open_issues_count":196,"forks":256,"open_issues":196,"watchers":2209,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/falconry/falcon/pulls/599"},"html":{"href":"https://github.com/falconry/falcon/pull/599"},"issue":{"href":"https://api.github.com/repos/falconry/falcon/issues/599"},"comments":{"href":"https://api.github.com/repos/falconry/falcon/issues/599/comments"},"review_comments":{"href":"https://api.github.com/repos/falconry/falcon/pulls/599/comments"},"review_comment":{"href":"https://api.github.com/repos/falconry/falcon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/falconry/falcon/pulls/599/commits"},"statuses":{"href":"https://api.github.com/repos/falconry/falcon/statuses/0f53bc62cd084efde52bfa60a5d531d46349072b"}}}}