{"action":"created","issue":{"url":"https://api.github.com/repos/markmfredrickson/optmatch/issues/81","labels_url":"https://api.github.com/repos/markmfredrickson/optmatch/issues/81/labels{/name}","comments_url":"https://api.github.com/repos/markmfredrickson/optmatch/issues/81/comments","events_url":"https://api.github.com/repos/markmfredrickson/optmatch/issues/81/events","html_url":"https://github.com/markmfredrickson/optmatch/issues/81","id":35428531,"number":81,"title":"Binary operations over ISMs","user":{"login":"markmfredrickson","id":98178,"avatar_url":"https://avatars.githubusercontent.com/u/98178?v=3","gravatar_id":"","url":"https://api.github.com/users/markmfredrickson","html_url":"https://github.com/markmfredrickson","followers_url":"https://api.github.com/users/markmfredrickson/followers","following_url":"https://api.github.com/users/markmfredrickson/following{/other_user}","gists_url":"https://api.github.com/users/markmfredrickson/gists{/gist_id}","starred_url":"https://api.github.com/users/markmfredrickson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markmfredrickson/subscriptions","organizations_url":"https://api.github.com/users/markmfredrickson/orgs","repos_url":"https://api.github.com/users/markmfredrickson/repos","events_url":"https://api.github.com/users/markmfredrickson/events{/privacy}","received_events_url":"https://api.github.com/users/markmfredrickson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"nullsatz","id":2879874,"avatar_url":"https://avatars.githubusercontent.com/u/2879874?v=3","gravatar_id":"","url":"https://api.github.com/users/nullsatz","html_url":"https://github.com/nullsatz","followers_url":"https://api.github.com/users/nullsatz/followers","following_url":"https://api.github.com/users/nullsatz/following{/other_user}","gists_url":"https://api.github.com/users/nullsatz/gists{/gist_id}","starred_url":"https://api.github.com/users/nullsatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nullsatz/subscriptions","organizations_url":"https://api.github.com/users/nullsatz/orgs","repos_url":"https://api.github.com/users/nullsatz/repos","events_url":"https://api.github.com/users/nullsatz/events{/privacy}","received_events_url":"https://api.github.com/users/nullsatz/received_events","type":"User","site_admin":false},"milestone":null,"comments":7,"created_at":"2014-06-10T21:39:33Z","updated_at":"2015-03-08T19:46:56Z","closed_at":null,"body":"Right now we implement the `Arith` group of operations for ISMs and vectors. It would be good to also implement the comparison and logic groups for both. The convention in the `Arith` operations is that the ISM is treated as if it were a column-major ordered dense matrix (where order is given by the `rownames` slot). This logic could get factored out into a helper function and then reused for arbitrary binary operations, such as comparisons and logical operations."},"comment":{"url":"https://api.github.com/repos/markmfredrickson/optmatch/issues/comments/77770177","html_url":"https://github.com/markmfredrickson/optmatch/issues/81#issuecomment-77770177","issue_url":"https://api.github.com/repos/markmfredrickson/optmatch/issues/81","id":77770177,"user":{"login":"nullsatz","id":2879874,"avatar_url":"https://avatars.githubusercontent.com/u/2879874?v=3","gravatar_id":"","url":"https://api.github.com/users/nullsatz","html_url":"https://github.com/nullsatz","followers_url":"https://api.github.com/users/nullsatz/followers","following_url":"https://api.github.com/users/nullsatz/following{/other_user}","gists_url":"https://api.github.com/users/nullsatz/gists{/gist_id}","starred_url":"https://api.github.com/users/nullsatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nullsatz/subscriptions","organizations_url":"https://api.github.com/users/nullsatz/orgs","repos_url":"https://api.github.com/users/nullsatz/repos","events_url":"https://api.github.com/users/nullsatz/events{/privacy}","received_events_url":"https://api.github.com/users/nullsatz/received_events","type":"User","site_admin":false},"created_at":"2015-03-08T19:46:56Z","updated_at":"2015-03-08T19:46:56Z","body":"We may need to add something to our makevars for clang. I'll try to check\nit out early this week.\nOn Mar 8, 2015 3:37 PM, \"Ben\" <notifications@github.com> wrote:\n\n> At the moment I can't get the issue81 branch to compile on my mac.\n>\n> $ make test\n> <...>\n> usr/bin/clang++ -I/opt/local/Library/Frameworks/R.framework/Resources/include -DNDEBUG  -I/opt/local/include -I\"/Users/bbh/Library/R/3.1/library/Rcpp/include\"   -fPIC  -pipe -Os -arch x86_64 -stdlib=libstdc++  -c ism.cc -o ism.o\n> In file included from ism.cc:1:\n> In file included from ./ism.h:2:\n> In file included from /Users/bbh/Library/R/3.1/library/Rcpp/include/Rcpp.h:27:\n> In file included from /Users/bbh/Library/R/3.1/library/Rcpp/include/RcppCommon.h:61:\n> In file included from /usr/include/c++/4.2.1/iterator:69:\n> In file included from /usr/include/c++/4.2.1/ostream:44:\n> In file included from /usr/include/c++/4.2.1/ios:49:\n> In file included from /usr/include/c++/4.2.1/bits/basic_ios.h:43:\n> In file included from /usr/include/c++/4.2.1/bits/locale_facets.h:1538:\n> /usr/include/c++/4.2.1/bits/codecvt.h:217:35: error: too many arguments provided\n>       to function-like macro invocation\n>       length(state_type& __state, const extern_type* __from,\n>                                   ^\n> /opt/local/Library/Frameworks/R.framework/Resources/include/Rinternals.h:1138:9: note:\n>       macro 'length' defined here\n> #define length(x)               Rf_length(x)\n>         ^\n> In file included from ism.cc:1:\n> In file included from ./ism.h:2:\n> In file included from /Users/bbh/Library/R/3.1/library/Rcpp/include/Rcpp.h:27:\n> In file included from /Users/bbh/Library/R/3.1/library/Rcpp/include/RcppCommon.h:61:\n> In file included from /usr/include/c++/4.2.1/iterator:69:\n> In file included from /usr/include/c++/4.2.1/ostream:44:\n> In file included from /usr/include/c++/4.2.1/ios:49:\n> In file included from /usr/include/c++/4.2.1/bits/basic_ios.h:43:\n> In file included from /usr/include/c++/4.2.1/bits/locale_facets.h:1538:\n> /usr/include/c++/4.2.1/bits/codecvt.h:217:13: error: expected ';' at end of\n>       declaration list\n>       length(state_type& __state, const extern_type* __from,\n>             ^\n> 2 errors generated.\n> make[1]: *** [ism.o] Error 1\n>\n> This against commit 383c780\n> <https://github.com/markmfredrickson/optmatch/commit/383c7808500df3c248fa7ef3e19d3ef7bfa35e2b>,\n> and on a system as follows.\n>\n> R version 3.1.1 (2014-07-10)\n> Platform: x86_64-apple-darwin12.5.0 (64-bit)\n>\n> locale:\n> [1] C\n>\n> Help/advice?\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/markmfredrickson/optmatch/issues/81#issuecomment-77769701>\n> .\n>\n"}}