{"action":"closed","issue":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/24268","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/24268/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/24268/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/24268/events","html_url":"https://github.com/dart-lang/sdk/issues/24268","id":104433138,"number":24268,"title":"Layout test failure in inspector/evaluate-in-console","user":{"login":"whesse","id":4905639,"avatar_url":"https://avatars.githubusercontent.com/u/4905639?v=3","gravatar_id":"","url":"https://api.github.com/users/whesse","html_url":"https://github.com/whesse","followers_url":"https://api.github.com/users/whesse/followers","following_url":"https://api.github.com/users/whesse/following{/other_user}","gists_url":"https://api.github.com/users/whesse/gists{/gist_id}","starred_url":"https://api.github.com/users/whesse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whesse/subscriptions","organizations_url":"https://api.github.com/users/whesse/orgs","repos_url":"https://api.github.com/users/whesse/repos","events_url":"https://api.github.com/users/whesse/events{/privacy}","received_events_url":"https://api.github.com/users/whesse/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dart-lang/sdk/labels/Area-Dartium","name":"Area-Dartium","color":"ededed"},{"url":"https://api.github.com/repos/dart-lang/sdk/labels/Priority-Medium","name":"Priority-Medium","color":"ededed"},{"url":"https://api.github.com/repos/dart-lang/sdk/labels/Type-Defect","name":"Type-Defect","color":"ededed"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-02T09:06:38Z","updated_at":"2015-09-02T19:20:01Z","closed_at":"2015-09-02T19:20:01Z","body":"A recent change to the VM makes the webkit layout test dart/inspector/evaluate-in-console fail.\r\nFor some reason, the class of the receiver in a thrown exception has changed from 'Test' to '`K2'.\r\nAlso, there is an \"Observatory listening\" message that is unexpected.\r\n\r\nIt looks like it is the change https://codereview.chromium.org//1322043002 that has caused this error.\r\n\r\nThe status file for these tests is at http://src.chromium.org/blink/branches/dart/2171_3/dartium/LayoutTests/TestExpectations\r\n\r\nA new status line would have to be added at the top of the file, this would have to be committed (I think that this SVN repository is still writable - the main chromium branches became read-only a year ago), and the new revision needs to be set as \"dartium_webkit_revision\" in tools/deps/dartium.deps/DEPS.\r\n\r\n\r\nThe text diff between the expected and actual results is:\r\n--- /mnt/data/b/build/slave/dartium-lucid64-inc-be/build/src/webkit/Release/layout-test-results/dart/inspector/evaluate-in-console-expected.txt\r\n+++ /mnt/data/b/build/slave/dartium-lucid64-inc-be/build/src/webkit/Release/layout-test-results/dart/inspector/evaluate-in-console-actual.txt\r\n@@ -1,3 +1,5 @@\r\n+Observatory listening on http://127.0.0.1:42624\r\n+CONSOLE INFO: Observatory listening at http://127.0.0.1:48570/\r\n CONSOLE MESSAGE: Hello Instance of 'Window'\r\n CONSOLE MESSAGE: foo\r\n \r\n@@ -12,10 +14,10 @@\r\n test.foo = 3 = 3\r\n test.foo = 3\r\n test.somePropertyThatDoesntExist = Uncaught Unhandled exception:\r\n-Class 'Test' has no instance getter 'somePropertyThatDoesntExist'.\r\n+Class '` K2' has no instance getter 'somePropertyThatDoesntExist'.\r\n \r\n NoSuchMethodError: method not found: 'somePropertyThatDoesntExist'\r\n-Receiver: Instance of 'Test'\r\n+Receiver: Instance of '` K2'\r\n Arguments: []\r\n #0      Object._noSuchMethod (DART_CORE_LIBRARY_SOURCE_LOCATION)\r\n #1      Object.noSuchMethod (DART_CORE_LIBRARY_SOURCE_LOCATION)\r\n@@ -23,10 +25,10 @@\r\n #3      handleMessage (FILE_SOURCE_LOCATION/evaluate-in-console.dart:13:5)\r\n test.toString() = \"<Test instance with instanceField = new value>\"\r\n test.toString(1) = Uncaught Unhandled exception:\r\n-Class 'Test' has no instance method 'toString' with matching arguments.\r\n+Class '` K2' has no instance method 'toString' with matching arguments.\r\n \r\n NoSuchMethodError: incorrect number of arguments passed to method named 'toString'\r\n-Receiver: Instance of 'Test'\r\n+Receiver: Instance of '` K2'\r\n Tried calling: toString(1)\r\n Found: toString()\r\n #0      Object._noSuchMethod (DART_CORE_LIBRARY_SOURCE_LOCATION)"}}