{"action":"created","issue":{"url":"https://api.github.com/repos/pulibrary/lcsort/issues/1","labels_url":"https://api.github.com/repos/pulibrary/lcsort/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/pulibrary/lcsort/issues/1/comments","events_url":"https://api.github.com/repos/pulibrary/lcsort/issues/1/events","html_url":"https://github.com/pulibrary/lcsort/issues/1","id":82112258,"number":1,"title":"too strict?","user":{"login":"jrochkind","id":149304,"avatar_url":"https://avatars.githubusercontent.com/u/149304?v=3","gravatar_id":"","url":"https://api.github.com/users/jrochkind","html_url":"https://github.com/jrochkind","followers_url":"https://api.github.com/users/jrochkind/followers","following_url":"https://api.github.com/users/jrochkind/following{/other_user}","gists_url":"https://api.github.com/users/jrochkind/gists{/gist_id}","starred_url":"https://api.github.com/users/jrochkind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrochkind/subscriptions","organizations_url":"https://api.github.com/users/jrochkind/orgs","repos_url":"https://api.github.com/users/jrochkind/repos","events_url":"https://api.github.com/users/jrochkind/events{/privacy}","received_events_url":"https://api.github.com/users/jrochkind/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-05-28T20:32:15Z","updated_at":"2015-05-29T15:29:09Z","closed_at":null,"body":"I'm finding this code is refusing certain LC call numbers as invalid, that I'm pretty sure are valid. \r\n\r\nI think one class where it does this is where the initial class number has a decimal part. LC call numbers usually start like \"TL 780\".  But sometimes the number has a decimal, like \"TL 780.5\".  If I understand it right. This second example, where the number has a \".5\" on the end, is rejected by this normalizer. \r\n\r\nI'm still trying to wrap my head around exactly what is and isn't valid, and what the numbers mean as far as sort order.  And I'm still evaluating different code to begin with for LC sort normalization, including this one -- I might port something ndushay has from Java instead, not sure. \r\n\r\nBut if I decide this one is my best bet, are you interested in pull requests to make it stop rejecting things that are or should be valid, to make it a bit more flexible? \r\n\r\nThere are some other things in this gem that work a bit differently then I'd like -- I don't see the `:wellform` option as being useful. If `:wellform => true` were just the only way it worked, you could still get the behavior you want with simply `Lcsort.normalize(call_str) || call_str.upcase`.  If what you want is an upcased version of call number for calls that can't be normalized, you can do that yourself, it doesn't need to be baked into Lcsort.normalize, which can just return nil. Unless I'm missing something? "},"comment":{"url":"https://api.github.com/repos/pulibrary/lcsort/issues/comments/106845854","html_url":"https://github.com/pulibrary/lcsort/issues/1#issuecomment-106845854","issue_url":"https://api.github.com/repos/pulibrary/lcsort/issues/1","id":106845854,"user":{"login":"jrochkind","id":149304,"avatar_url":"https://avatars.githubusercontent.com/u/149304?v=3","gravatar_id":"","url":"https://api.github.com/users/jrochkind","html_url":"https://github.com/jrochkind","followers_url":"https://api.github.com/users/jrochkind/followers","following_url":"https://api.github.com/users/jrochkind/following{/other_user}","gists_url":"https://api.github.com/users/jrochkind/gists{/gist_id}","starred_url":"https://api.github.com/users/jrochkind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrochkind/subscriptions","organizations_url":"https://api.github.com/users/jrochkind/orgs","repos_url":"https://api.github.com/users/jrochkind/repos","events_url":"https://api.github.com/users/jrochkind/events{/privacy}","received_events_url":"https://api.github.com/users/jrochkind/received_events","type":"User","site_admin":false},"created_at":"2015-05-29T15:29:09Z","updated_at":"2015-05-29T15:29:09Z","body":"And yet another regex example, in Perl, to look at.\r\n\r\nhttps://metacpan.org/pod/Library::CallNumber::LC\r\n\r\nBill Dueber says that's an evolution of the last best regex based approach he worked on. "}}