{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/8060","labels_url":"https://api.github.com/repos/apache/spark/issues/8060/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/8060/comments","events_url":"https://api.github.com/repos/apache/spark/issues/8060/events","html_url":"https://github.com/apache/spark/pull/8060","id":99878048,"number":8060,"title":"[SPARK-9646][SQL]Add metrics for all join and aggregate operators","user":{"login":"zsxwing","id":1000778,"avatar_url":"https://avatars.githubusercontent.com/u/1000778?v=3","gravatar_id":"","url":"https://api.github.com/users/zsxwing","html_url":"https://github.com/zsxwing","followers_url":"https://api.github.com/users/zsxwing/followers","following_url":"https://api.github.com/users/zsxwing/following{/other_user}","gists_url":"https://api.github.com/users/zsxwing/gists{/gist_id}","starred_url":"https://api.github.com/users/zsxwing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zsxwing/subscriptions","organizations_url":"https://api.github.com/users/zsxwing/orgs","repos_url":"https://api.github.com/users/zsxwing/repos","events_url":"https://api.github.com/users/zsxwing/events{/privacy}","received_events_url":"https://api.github.com/users/zsxwing/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":36,"created_at":"2015-08-09T09:12:45Z","updated_at":"2015-08-11T16:15:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/8060","html_url":"https://github.com/apache/spark/pull/8060","diff_url":"https://github.com/apache/spark/pull/8060.diff","patch_url":"https://github.com/apache/spark/pull/8060.patch"},"body":"This PR added metrics for all join and aggregate operators. However, I found the metrics may be confusing in the following two case:\r\n1. The iterator is not totally consumed and the metric values will be less.\r\n2. Recreating the iterators will make metric values look bigger than the size of the input source, such as `CartesianProduct`."},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/129952149","html_url":"https://github.com/apache/spark/pull/8060#issuecomment-129952149","issue_url":"https://api.github.com/repos/apache/spark/issues/8060","id":129952149,"user":{"login":"yhuai","id":2072857,"avatar_url":"https://avatars.githubusercontent.com/u/2072857?v=3","gravatar_id":"","url":"https://api.github.com/users/yhuai","html_url":"https://github.com/yhuai","followers_url":"https://api.github.com/users/yhuai/followers","following_url":"https://api.github.com/users/yhuai/following{/other_user}","gists_url":"https://api.github.com/users/yhuai/gists{/gist_id}","starred_url":"https://api.github.com/users/yhuai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yhuai/subscriptions","organizations_url":"https://api.github.com/users/yhuai/orgs","repos_url":"https://api.github.com/users/yhuai/repos","events_url":"https://api.github.com/users/yhuai/events{/privacy}","received_events_url":"https://api.github.com/users/yhuai/received_events","type":"User","site_admin":false},"created_at":"2015-08-11T16:15:43Z","updated_at":"2015-08-11T16:15:43Z","body":"Aggregation related changes look good. \r\n\r\nbtw, how is the overhead of it?\r\n\r\nAlso, since this one has lots of changes and may easily get conflicted with master. Let's get it in as soon as possible."}}