{"action":"created","comment":{"url":"https://api.github.com/repos/timsly/carrierwave-serializable/pulls/comments/34783020","id":34783020,"diff_hunk":"@@ -6,7 +6,11 @@ module CarrierWave\n   module ActiveRecord\n     module Serializable\n       def serialized_uploaders\n-        @serialized_uploaders ||= {}\n+        @serialized_uploaders ||= if (superclass != ::ActiveRecord::Base) && superclass.respond_to?(:serialized_uploaders)","path":"lib/carrierwave-serializable/orm/activerecord.rb","position":null,"original_position":5,"commit_id":"10e16d775cc62c617bf77b2667734b4d05060cb6","original_commit_id":"06ae57bdf77ae891b7ece959dbf8ea076c183781","user":{"login":"benhutton","id":61645,"avatar_url":"https://avatars.githubusercontent.com/u/61645?v=3","gravatar_id":"","url":"https://api.github.com/users/benhutton","html_url":"https://github.com/benhutton","followers_url":"https://api.github.com/users/benhutton/followers","following_url":"https://api.github.com/users/benhutton/following{/other_user}","gists_url":"https://api.github.com/users/benhutton/gists{/gist_id}","starred_url":"https://api.github.com/users/benhutton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benhutton/subscriptions","organizations_url":"https://api.github.com/users/benhutton/orgs","repos_url":"https://api.github.com/users/benhutton/repos","events_url":"https://api.github.com/users/benhutton/events{/privacy}","received_events_url":"https://api.github.com/users/benhutton/received_events","type":"User","site_admin":false},"body":"@timsly okay, take another look","created_at":"2015-07-16T12:50:36Z","updated_at":"2015-07-16T12:50:36Z","html_url":"https://github.com/timsly/carrierwave-serializable/pull/15#discussion_r34783020","pull_request_url":"https://api.github.com/repos/timsly/carrierwave-serializable/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/timsly/carrierwave-serializable/pulls/comments/34783020"},"html":{"href":"https://github.com/timsly/carrierwave-serializable/pull/15#discussion_r34783020"},"pull_request":{"href":"https://api.github.com/repos/timsly/carrierwave-serializable/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/timsly/carrierwave-serializable/pulls/15","id":40066836,"html_url":"https://github.com/timsly/carrierwave-serializable/pull/15","diff_url":"https://github.com/timsly/carrierwave-serializable/pull/15.diff","patch_url":"https://github.com/timsly/carrierwave-serializable/pull/15.patch","issue_url":"https://api.github.com/repos/timsly/carrierwave-serializable/issues/15","number":15,"state":"open","locked":false,"title":"Read from superclass","user":{"login":"benhutton","id":61645,"avatar_url":"https://avatars.githubusercontent.com/u/61645?v=3","gravatar_id":"","url":"https://api.github.com/users/benhutton","html_url":"https://github.com/benhutton","followers_url":"https://api.github.com/users/benhutton/followers","following_url":"https://api.github.com/users/benhutton/following{/other_user}","gists_url":"https://api.github.com/users/benhutton/gists{/gist_id}","starred_url":"https://api.github.com/users/benhutton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benhutton/subscriptions","organizations_url":"https://api.github.com/users/benhutton/orgs","repos_url":"https://api.github.com/users/benhutton/repos","events_url":"https://api.github.com/users/benhutton/events{/privacy}","received_events_url":"https://api.github.com/users/benhutton/received_events","type":"User","site_admin":false},"body":"This makes carrierwave-serializable work with STI\r\n\r\nIt is a combination of @Krule's code from https://github.com/timsly/carrierwave-serializable/pull/11 and a fix of my own.\r\n\r\nWithout this, when I place a `mount_uploader` call in the parent class in an STI setup, the uploader is not made available on the child classes.\r\n\r\n(Note that this includes my code from https://github.com/timsly/carrierwave-serializable/pull/14 as I can't get anything working without it.)","created_at":"2015-07-15T20:37:54Z","updated_at":"2015-07-16T12:50:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"870e18745296bc7da84848a019d1db08ef916ea0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/timsly/carrierwave-serializable/pulls/15/commits","review_comments_url":"https://api.github.com/repos/timsly/carrierwave-serializable/pulls/15/comments","review_comment_url":"https://api.github.com/repos/timsly/carrierwave-serializable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/timsly/carrierwave-serializable/issues/15/comments","statuses_url":"https://api.github.com/repos/timsly/carrierwave-serializable/statuses/10e16d775cc62c617bf77b2667734b4d05060cb6","head":{"label":"benhutton:feature/read-from-superclass","ref":"feature/read-from-superclass","sha":"10e16d775cc62c617bf77b2667734b4d05060cb6","user":{"login":"benhutton","id":61645,"avatar_url":"https://avatars.githubusercontent.com/u/61645?v=3","gravatar_id":"","url":"https://api.github.com/users/benhutton","html_url":"https://github.com/benhutton","followers_url":"https://api.github.com/users/benhutton/followers","following_url":"https://api.github.com/users/benhutton/following{/other_user}","gists_url":"https://api.github.com/users/benhutton/gists{/gist_id}","starred_url":"https://api.github.com/users/benhutton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benhutton/subscriptions","organizations_url":"https://api.github.com/users/benhutton/orgs","repos_url":"https://api.github.com/users/benhutton/repos","events_url":"https://api.github.com/users/benhutton/events{/privacy}","received_events_url":"https://api.github.com/users/benhutton/received_events","type":"User","site_admin":false},"repo":{"id":28636004,"name":"carrierwave-serializable","full_name":"benhutton/carrierwave-serializable","owner":{"login":"benhutton","id":61645,"avatar_url":"https://avatars.githubusercontent.com/u/61645?v=3","gravatar_id":"","url":"https://api.github.com/users/benhutton","html_url":"https://github.com/benhutton","followers_url":"https://api.github.com/users/benhutton/followers","following_url":"https://api.github.com/users/benhutton/following{/other_user}","gists_url":"https://api.github.com/users/benhutton/gists{/gist_id}","starred_url":"https://api.github.com/users/benhutton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benhutton/subscriptions","organizations_url":"https://api.github.com/users/benhutton/orgs","repos_url":"https://api.github.com/users/benhutton/repos","events_url":"https://api.github.com/users/benhutton/events{/privacy}","received_events_url":"https://api.github.com/users/benhutton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benhutton/carrierwave-serializable","description":"Carrierwave plugin that store uploader to serialized field","fork":true,"url":"https://api.github.com/repos/benhutton/carrierwave-serializable","forks_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/forks","keys_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/teams","hooks_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/hooks","issue_events_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/issues/events{/number}","events_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/events","assignees_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/assignees{/user}","branches_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/branches{/branch}","tags_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/tags","blobs_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/git/refs{/sha}","trees_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/statuses/{sha}","languages_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/languages","stargazers_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/stargazers","contributors_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/contributors","subscribers_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/subscribers","subscription_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/subscription","commits_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/commits{/sha}","git_commits_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/git/commits{/sha}","comments_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/comments{/number}","issue_comment_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/issues/comments{/number}","contents_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/contents/{+path}","compare_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/merges","archive_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/downloads","issues_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/issues{/number}","pulls_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/pulls{/number}","milestones_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/milestones{/number}","notifications_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/labels{/name}","releases_url":"https://api.github.com/repos/benhutton/carrierwave-serializable/releases{/id}","created_at":"2014-12-30T15:42:48Z","updated_at":"2014-12-30T15:42:48Z","pushed_at":"2015-07-16T12:49:45Z","git_url":"git://github.com/benhutton/carrierwave-serializable.git","ssh_url":"git@github.com:benhutton/carrierwave-serializable.git","clone_url":"https://github.com/benhutton/carrierwave-serializable.git","svn_url":"https://github.com/benhutton/carrierwave-serializable","homepage":null,"size":118,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"timsly:master","ref":"master","sha":"f8404113e14682890a5227fb7c655ac95def0dec","user":{"login":"timsly","id":471335,"avatar_url":"https://avatars.githubusercontent.com/u/471335?v=3","gravatar_id":"","url":"https://api.github.com/users/timsly","html_url":"https://github.com/timsly","followers_url":"https://api.github.com/users/timsly/followers","following_url":"https://api.github.com/users/timsly/following{/other_user}","gists_url":"https://api.github.com/users/timsly/gists{/gist_id}","starred_url":"https://api.github.com/users/timsly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timsly/subscriptions","organizations_url":"https://api.github.com/users/timsly/orgs","repos_url":"https://api.github.com/users/timsly/repos","events_url":"https://api.github.com/users/timsly/events{/privacy}","received_events_url":"https://api.github.com/users/timsly/received_events","type":"User","site_admin":false},"repo":{"id":8264927,"name":"carrierwave-serializable","full_name":"timsly/carrierwave-serializable","owner":{"login":"timsly","id":471335,"avatar_url":"https://avatars.githubusercontent.com/u/471335?v=3","gravatar_id":"","url":"https://api.github.com/users/timsly","html_url":"https://github.com/timsly","followers_url":"https://api.github.com/users/timsly/followers","following_url":"https://api.github.com/users/timsly/following{/other_user}","gists_url":"https://api.github.com/users/timsly/gists{/gist_id}","starred_url":"https://api.github.com/users/timsly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timsly/subscriptions","organizations_url":"https://api.github.com/users/timsly/orgs","repos_url":"https://api.github.com/users/timsly/repos","events_url":"https://api.github.com/users/timsly/events{/privacy}","received_events_url":"https://api.github.com/users/timsly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timsly/carrierwave-serializable","description":"Carrierwave plugin that store uploader to serialized field","fork":false,"url":"https://api.github.com/repos/timsly/carrierwave-serializable","forks_url":"https://api.github.com/repos/timsly/carrierwave-serializable/forks","keys_url":"https://api.github.com/repos/timsly/carrierwave-serializable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timsly/carrierwave-serializable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timsly/carrierwave-serializable/teams","hooks_url":"https://api.github.com/repos/timsly/carrierwave-serializable/hooks","issue_events_url":"https://api.github.com/repos/timsly/carrierwave-serializable/issues/events{/number}","events_url":"https://api.github.com/repos/timsly/carrierwave-serializable/events","assignees_url":"https://api.github.com/repos/timsly/carrierwave-serializable/assignees{/user}","branches_url":"https://api.github.com/repos/timsly/carrierwave-serializable/branches{/branch}","tags_url":"https://api.github.com/repos/timsly/carrierwave-serializable/tags","blobs_url":"https://api.github.com/repos/timsly/carrierwave-serializable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timsly/carrierwave-serializable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timsly/carrierwave-serializable/git/refs{/sha}","trees_url":"https://api.github.com/repos/timsly/carrierwave-serializable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timsly/carrierwave-serializable/statuses/{sha}","languages_url":"https://api.github.com/repos/timsly/carrierwave-serializable/languages","stargazers_url":"https://api.github.com/repos/timsly/carrierwave-serializable/stargazers","contributors_url":"https://api.github.com/repos/timsly/carrierwave-serializable/contributors","subscribers_url":"https://api.github.com/repos/timsly/carrierwave-serializable/subscribers","subscription_url":"https://api.github.com/repos/timsly/carrierwave-serializable/subscription","commits_url":"https://api.github.com/repos/timsly/carrierwave-serializable/commits{/sha}","git_commits_url":"https://api.github.com/repos/timsly/carrierwave-serializable/git/commits{/sha}","comments_url":"https://api.github.com/repos/timsly/carrierwave-serializable/comments{/number}","issue_comment_url":"https://api.github.com/repos/timsly/carrierwave-serializable/issues/comments{/number}","contents_url":"https://api.github.com/repos/timsly/carrierwave-serializable/contents/{+path}","compare_url":"https://api.github.com/repos/timsly/carrierwave-serializable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timsly/carrierwave-serializable/merges","archive_url":"https://api.github.com/repos/timsly/carrierwave-serializable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timsly/carrierwave-serializable/downloads","issues_url":"https://api.github.com/repos/timsly/carrierwave-serializable/issues{/number}","pulls_url":"https://api.github.com/repos/timsly/carrierwave-serializable/pulls{/number}","milestones_url":"https://api.github.com/repos/timsly/carrierwave-serializable/milestones{/number}","notifications_url":"https://api.github.com/repos/timsly/carrierwave-serializable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timsly/carrierwave-serializable/labels{/name}","releases_url":"https://api.github.com/repos/timsly/carrierwave-serializable/releases{/id}","created_at":"2013-02-18T08:57:38Z","updated_at":"2015-06-11T17:14:00Z","pushed_at":"2015-07-16T12:49:45Z","git_url":"git://github.com/timsly/carrierwave-serializable.git","ssh_url":"git@github.com:timsly/carrierwave-serializable.git","clone_url":"https://github.com/timsly/carrierwave-serializable.git","svn_url":"https://github.com/timsly/carrierwave-serializable","homepage":null,"size":262,"stargazers_count":21,"watchers_count":21,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":1,"forks":18,"open_issues":1,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/timsly/carrierwave-serializable/pulls/15"},"html":{"href":"https://github.com/timsly/carrierwave-serializable/pull/15"},"issue":{"href":"https://api.github.com/repos/timsly/carrierwave-serializable/issues/15"},"comments":{"href":"https://api.github.com/repos/timsly/carrierwave-serializable/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/timsly/carrierwave-serializable/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/timsly/carrierwave-serializable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/timsly/carrierwave-serializable/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/timsly/carrierwave-serializable/statuses/10e16d775cc62c617bf77b2667734b4d05060cb6"}}}}