{"action":"created","comment":{"url":"https://api.github.com/repos/dumbmatter/basketball-gm/pulls/comments/35258487","id":35258487,"diff_hunk":"@@ -7,12 +7,16 @@ define([\"dao\", \"globals\", \"lib/underscore\"], function (dao, g, _) {\n \n     /**\n      * Assess the payroll and apply minimum and luxury taxes.\n+     * Distribute half of the collected luxury taxes to teams under the salary cap.\n      *\n      * @memberOf core.finances\n      * @return {Promise}\n      */\n     function assessPayrollMinLuxury(tx) {\n         tx = dao.tx([\"players\", \"releasedPlayers\", \"teams\"], \"readwrite\", tx);\n+        var collectedTax, amount, distribute;\n+        collectedTax = 0;\n+        distribute = 0;","path":"js/core/finances.js","position":13,"original_position":13,"commit_id":"ad9ef4933f778fb8e553bc1dcaec35710ca1584f","original_commit_id":"ad9ef4933f778fb8e553bc1dcaec35710ca1584f","user":{"login":"dumbmatter","id":828632,"avatar_url":"https://avatars.githubusercontent.com/u/828632?v=3","gravatar_id":"","url":"https://api.github.com/users/dumbmatter","html_url":"https://github.com/dumbmatter","followers_url":"https://api.github.com/users/dumbmatter/followers","following_url":"https://api.github.com/users/dumbmatter/following{/other_user}","gists_url":"https://api.github.com/users/dumbmatter/gists{/gist_id}","starred_url":"https://api.github.com/users/dumbmatter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dumbmatter/subscriptions","organizations_url":"https://api.github.com/users/dumbmatter/orgs","repos_url":"https://api.github.com/users/dumbmatter/repos","events_url":"https://api.github.com/users/dumbmatter/events{/privacy}","received_events_url":"https://api.github.com/users/dumbmatter/received_events","type":"User","site_admin":false},"body":"Delete this line, it doesn't do anything.","created_at":"2015-07-22T20:18:23Z","updated_at":"2015-07-22T20:18:23Z","html_url":"https://github.com/dumbmatter/basketball-gm/pull/98#discussion_r35258487","pull_request_url":"https://api.github.com/repos/dumbmatter/basketball-gm/pulls/98","_links":{"self":{"href":"https://api.github.com/repos/dumbmatter/basketball-gm/pulls/comments/35258487"},"html":{"href":"https://github.com/dumbmatter/basketball-gm/pull/98#discussion_r35258487"},"pull_request":{"href":"https://api.github.com/repos/dumbmatter/basketball-gm/pulls/98"}}},"pull_request":{"url":"https://api.github.com/repos/dumbmatter/basketball-gm/pulls/98","id":40309501,"html_url":"https://github.com/dumbmatter/basketball-gm/pull/98","diff_url":"https://github.com/dumbmatter/basketball-gm/pull/98.diff","patch_url":"https://github.com/dumbmatter/basketball-gm/pull/98.patch","issue_url":"https://api.github.com/repos/dumbmatter/basketball-gm/issues/98","number":98,"state":"open","locked":false,"title":"Implemented luxury tax sharing","user":{"login":"jericksanjuan","id":6973763,"avatar_url":"https://avatars.githubusercontent.com/u/6973763?v=3","gravatar_id":"","url":"https://api.github.com/users/jericksanjuan","html_url":"https://github.com/jericksanjuan","followers_url":"https://api.github.com/users/jericksanjuan/followers","following_url":"https://api.github.com/users/jericksanjuan/following{/other_user}","gists_url":"https://api.github.com/users/jericksanjuan/gists{/gist_id}","starred_url":"https://api.github.com/users/jericksanjuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jericksanjuan/subscriptions","organizations_url":"https://api.github.com/users/jericksanjuan/orgs","repos_url":"https://api.github.com/users/jericksanjuan/repos","events_url":"https://api.github.com/users/jericksanjuan/events{/privacy}","received_events_url":"https://api.github.com/users/jericksanjuan/received_events","type":"User","site_admin":false},"body":"Added luxuryTaxShare field to teams->seasons->revenues.\r\nHalf of the collected tax is distributed to teams under the salary cap.\r\nAlso added this to team finance display.\r\n\r\nThis change would increase the database version to 17.","created_at":"2015-07-19T14:53:54Z","updated_at":"2015-07-22T20:18:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"33fde86d9cb90cb052cf3052e3952f853e64ef36","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dumbmatter/basketball-gm/pulls/98/commits","review_comments_url":"https://api.github.com/repos/dumbmatter/basketball-gm/pulls/98/comments","review_comment_url":"https://api.github.com/repos/dumbmatter/basketball-gm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dumbmatter/basketball-gm/issues/98/comments","statuses_url":"https://api.github.com/repos/dumbmatter/basketball-gm/statuses/ad9ef4933f778fb8e553bc1dcaec35710ca1584f","head":{"label":"jericksanjuan:luxury_tax_sharing","ref":"luxury_tax_sharing","sha":"ad9ef4933f778fb8e553bc1dcaec35710ca1584f","user":{"login":"jericksanjuan","id":6973763,"avatar_url":"https://avatars.githubusercontent.com/u/6973763?v=3","gravatar_id":"","url":"https://api.github.com/users/jericksanjuan","html_url":"https://github.com/jericksanjuan","followers_url":"https://api.github.com/users/jericksanjuan/followers","following_url":"https://api.github.com/users/jericksanjuan/following{/other_user}","gists_url":"https://api.github.com/users/jericksanjuan/gists{/gist_id}","starred_url":"https://api.github.com/users/jericksanjuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jericksanjuan/subscriptions","organizations_url":"https://api.github.com/users/jericksanjuan/orgs","repos_url":"https://api.github.com/users/jericksanjuan/repos","events_url":"https://api.github.com/users/jericksanjuan/events{/privacy}","received_events_url":"https://api.github.com/users/jericksanjuan/received_events","type":"User","site_admin":false},"repo":{"id":37994160,"name":"basketball-gm","full_name":"jericksanjuan/basketball-gm","owner":{"login":"jericksanjuan","id":6973763,"avatar_url":"https://avatars.githubusercontent.com/u/6973763?v=3","gravatar_id":"","url":"https://api.github.com/users/jericksanjuan","html_url":"https://github.com/jericksanjuan","followers_url":"https://api.github.com/users/jericksanjuan/followers","following_url":"https://api.github.com/users/jericksanjuan/following{/other_user}","gists_url":"https://api.github.com/users/jericksanjuan/gists{/gist_id}","starred_url":"https://api.github.com/users/jericksanjuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jericksanjuan/subscriptions","organizations_url":"https://api.github.com/users/jericksanjuan/orgs","repos_url":"https://api.github.com/users/jericksanjuan/repos","events_url":"https://api.github.com/users/jericksanjuan/events{/privacy}","received_events_url":"https://api.github.com/users/jericksanjuan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jericksanjuan/basketball-gm","description":"A single-player basketball simulation game. Make trades, set rosters, draft players, and try to build the next dynasty, all from within your web browser. The game is implemented entirely in client-side JavaScript, backed by IndexedDB.","fork":true,"url":"https://api.github.com/repos/jericksanjuan/basketball-gm","forks_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/forks","keys_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/teams","hooks_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/hooks","issue_events_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/issues/events{/number}","events_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/events","assignees_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/assignees{/user}","branches_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/branches{/branch}","tags_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/tags","blobs_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/git/refs{/sha}","trees_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/statuses/{sha}","languages_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/languages","stargazers_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/stargazers","contributors_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/contributors","subscribers_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/subscribers","subscription_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/subscription","commits_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/commits{/sha}","git_commits_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/git/commits{/sha}","comments_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/comments{/number}","issue_comment_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/issues/comments{/number}","contents_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/contents/{+path}","compare_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/merges","archive_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/downloads","issues_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/issues{/number}","pulls_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/pulls{/number}","milestones_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/milestones{/number}","notifications_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/labels{/name}","releases_url":"https://api.github.com/repos/jericksanjuan/basketball-gm/releases{/id}","created_at":"2015-06-24T15:44:28Z","updated_at":"2015-06-24T15:44:30Z","pushed_at":"2015-07-22T13:01:19Z","git_url":"git://github.com/jericksanjuan/basketball-gm.git","ssh_url":"git@github.com:jericksanjuan/basketball-gm.git","clone_url":"https://github.com/jericksanjuan/basketball-gm.git","svn_url":"https://github.com/jericksanjuan/basketball-gm","homepage":"http://basketball-gm.com/","size":47710,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dumbmatter:master","ref":"master","sha":"998f77ed8246f5acbc317f5f3aee7eb03cfc426f","user":{"login":"dumbmatter","id":828632,"avatar_url":"https://avatars.githubusercontent.com/u/828632?v=3","gravatar_id":"","url":"https://api.github.com/users/dumbmatter","html_url":"https://github.com/dumbmatter","followers_url":"https://api.github.com/users/dumbmatter/followers","following_url":"https://api.github.com/users/dumbmatter/following{/other_user}","gists_url":"https://api.github.com/users/dumbmatter/gists{/gist_id}","starred_url":"https://api.github.com/users/dumbmatter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dumbmatter/subscriptions","organizations_url":"https://api.github.com/users/dumbmatter/orgs","repos_url":"https://api.github.com/users/dumbmatter/repos","events_url":"https://api.github.com/users/dumbmatter/events{/privacy}","received_events_url":"https://api.github.com/users/dumbmatter/received_events","type":"User","site_admin":false},"repo":{"id":1845258,"name":"basketball-gm","full_name":"dumbmatter/basketball-gm","owner":{"login":"dumbmatter","id":828632,"avatar_url":"https://avatars.githubusercontent.com/u/828632?v=3","gravatar_id":"","url":"https://api.github.com/users/dumbmatter","html_url":"https://github.com/dumbmatter","followers_url":"https://api.github.com/users/dumbmatter/followers","following_url":"https://api.github.com/users/dumbmatter/following{/other_user}","gists_url":"https://api.github.com/users/dumbmatter/gists{/gist_id}","starred_url":"https://api.github.com/users/dumbmatter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dumbmatter/subscriptions","organizations_url":"https://api.github.com/users/dumbmatter/orgs","repos_url":"https://api.github.com/users/dumbmatter/repos","events_url":"https://api.github.com/users/dumbmatter/events{/privacy}","received_events_url":"https://api.github.com/users/dumbmatter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dumbmatter/basketball-gm","description":"A single-player basketball simulation game. Make trades, set rosters, draft players, and try to build the next dynasty, all from within your web browser. The game is implemented entirely in client-side JavaScript, backed by IndexedDB.","fork":false,"url":"https://api.github.com/repos/dumbmatter/basketball-gm","forks_url":"https://api.github.com/repos/dumbmatter/basketball-gm/forks","keys_url":"https://api.github.com/repos/dumbmatter/basketball-gm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dumbmatter/basketball-gm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dumbmatter/basketball-gm/teams","hooks_url":"https://api.github.com/repos/dumbmatter/basketball-gm/hooks","issue_events_url":"https://api.github.com/repos/dumbmatter/basketball-gm/issues/events{/number}","events_url":"https://api.github.com/repos/dumbmatter/basketball-gm/events","assignees_url":"https://api.github.com/repos/dumbmatter/basketball-gm/assignees{/user}","branches_url":"https://api.github.com/repos/dumbmatter/basketball-gm/branches{/branch}","tags_url":"https://api.github.com/repos/dumbmatter/basketball-gm/tags","blobs_url":"https://api.github.com/repos/dumbmatter/basketball-gm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dumbmatter/basketball-gm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dumbmatter/basketball-gm/git/refs{/sha}","trees_url":"https://api.github.com/repos/dumbmatter/basketball-gm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dumbmatter/basketball-gm/statuses/{sha}","languages_url":"https://api.github.com/repos/dumbmatter/basketball-gm/languages","stargazers_url":"https://api.github.com/repos/dumbmatter/basketball-gm/stargazers","contributors_url":"https://api.github.com/repos/dumbmatter/basketball-gm/contributors","subscribers_url":"https://api.github.com/repos/dumbmatter/basketball-gm/subscribers","subscription_url":"https://api.github.com/repos/dumbmatter/basketball-gm/subscription","commits_url":"https://api.github.com/repos/dumbmatter/basketball-gm/commits{/sha}","git_commits_url":"https://api.github.com/repos/dumbmatter/basketball-gm/git/commits{/sha}","comments_url":"https://api.github.com/repos/dumbmatter/basketball-gm/comments{/number}","issue_comment_url":"https://api.github.com/repos/dumbmatter/basketball-gm/issues/comments{/number}","contents_url":"https://api.github.com/repos/dumbmatter/basketball-gm/contents/{+path}","compare_url":"https://api.github.com/repos/dumbmatter/basketball-gm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dumbmatter/basketball-gm/merges","archive_url":"https://api.github.com/repos/dumbmatter/basketball-gm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dumbmatter/basketball-gm/downloads","issues_url":"https://api.github.com/repos/dumbmatter/basketball-gm/issues{/number}","pulls_url":"https://api.github.com/repos/dumbmatter/basketball-gm/pulls{/number}","milestones_url":"https://api.github.com/repos/dumbmatter/basketball-gm/milestones{/number}","notifications_url":"https://api.github.com/repos/dumbmatter/basketball-gm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dumbmatter/basketball-gm/labels{/name}","releases_url":"https://api.github.com/repos/dumbmatter/basketball-gm/releases{/id}","created_at":"2011-06-04T00:56:18Z","updated_at":"2015-07-14T09:39:15Z","pushed_at":"2015-07-19T16:51:33Z","git_url":"git://github.com/dumbmatter/basketball-gm.git","ssh_url":"git@github.com:dumbmatter/basketball-gm.git","clone_url":"https://github.com/dumbmatter/basketball-gm.git","svn_url":"https://github.com/dumbmatter/basketball-gm","homepage":"http://basketball-gm.com/","size":49132,"stargazers_count":69,"watchers_count":69,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":21,"forks":40,"open_issues":21,"watchers":69,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dumbmatter/basketball-gm/pulls/98"},"html":{"href":"https://github.com/dumbmatter/basketball-gm/pull/98"},"issue":{"href":"https://api.github.com/repos/dumbmatter/basketball-gm/issues/98"},"comments":{"href":"https://api.github.com/repos/dumbmatter/basketball-gm/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/dumbmatter/basketball-gm/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/dumbmatter/basketball-gm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dumbmatter/basketball-gm/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/dumbmatter/basketball-gm/statuses/ad9ef4933f778fb8e553bc1dcaec35710ca1584f"}}}}