{"action":"created","comment":{"url":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/comments/44724848","id":44724848,"diff_hunk":"@@ -54,14 +104,17 @@ def numpy_median(image, iterations=10):\n     # verify correctness\n     from_cython = py_median_3x3(input_image, 2, 5)\n     from_numpy = numpy_median(input_image, 2)\n-    assert np.all(from_cython == from_numpy)\n+    # assert np.all(from_cython == from_numpy)\n \n-    with Timer() as t:\n-        new_image = py_median_3x3(input_image, 10, 8)\n+    # @x: test different number of threads\n+    for num_threads in [1, 2, 4]:\n+        with Timer() as t:\n+            new_image = py_median_3x3(input_image, 10, num_threads)\n+        print(\"{0} seconds for 10 filter passes with {1} threads.\".format(t.interval, num_threads))\n \n     pylab.figure()\n     pylab.imshow(new_image[1200:1800, 3000:3500])\n     pylab.title('after - zoom')\n \n-    print(\"{} seconds for 10 filter passes.\".format(t.interval))\n+    # print(\"{} seconds for 10 filter passes.\".format(t.interval))","path":"HW2/P4/driver.py","position":94,"original_position":94,"commit_id":"0c86e23e063c9668b97ae6318acd4ead00cb6164","original_commit_id":"0c86e23e063c9668b97ae6318acd4ead00cb6164","user":{"login":"LeonhardFS","id":14127465,"avatar_url":"https://avatars.githubusercontent.com/u/14127465?v=3","gravatar_id":"","url":"https://api.github.com/users/LeonhardFS","html_url":"https://github.com/LeonhardFS","followers_url":"https://api.github.com/users/LeonhardFS/followers","following_url":"https://api.github.com/users/LeonhardFS/following{/other_user}","gists_url":"https://api.github.com/users/LeonhardFS/gists{/gist_id}","starred_url":"https://api.github.com/users/LeonhardFS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeonhardFS/subscriptions","organizations_url":"https://api.github.com/users/LeonhardFS/orgs","repos_url":"https://api.github.com/users/LeonhardFS/repos","events_url":"https://api.github.com/users/LeonhardFS/events{/privacy}","received_events_url":"https://api.github.com/users/LeonhardFS/received_events","type":"User","site_admin":false},"body":"nice work :+1: ","created_at":"2015-11-12T22:30:34Z","updated_at":"2015-11-12T22:30:34Z","html_url":"https://github.com/harvard-cs205/cs205-homework/pull/303#discussion_r44724848","pull_request_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/303","_links":{"self":{"href":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/comments/44724848"},"html":{"href":"https://github.com/harvard-cs205/cs205-homework/pull/303#discussion_r44724848"},"pull_request":{"href":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/303"}}},"pull_request":{"url":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/303","id":49512715,"html_url":"https://github.com/harvard-cs205/cs205-homework/pull/303","diff_url":"https://github.com/harvard-cs205/cs205-homework/pull/303.diff","patch_url":"https://github.com/harvard-cs205/cs205-homework/pull/303.patch","issue_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/issues/303","number":303,"state":"open","locked":false,"title":"finished","user":{"login":"xchang4","id":11063622,"avatar_url":"https://avatars.githubusercontent.com/u/11063622?v=3","gravatar_id":"","url":"https://api.github.com/users/xchang4","html_url":"https://github.com/xchang4","followers_url":"https://api.github.com/users/xchang4/followers","following_url":"https://api.github.com/users/xchang4/following{/other_user}","gists_url":"https://api.github.com/users/xchang4/gists{/gist_id}","starred_url":"https://api.github.com/users/xchang4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xchang4/subscriptions","organizations_url":"https://api.github.com/users/xchang4/orgs","repos_url":"https://api.github.com/users/xchang4/repos","events_url":"https://api.github.com/users/xchang4/events{/privacy}","received_events_url":"https://api.github.com/users/xchang4/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-11-03T02:13:16Z","updated_at":"2015-11-12T22:30:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97a62cc4ad9f3d91f1444ad18f8d3733bcc22cbb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/303/commits","review_comments_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/303/comments","review_comment_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/issues/303/comments","statuses_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/statuses/0c86e23e063c9668b97ae6318acd4ead00cb6164","head":{"label":"xchang4:HW2","ref":"HW2","sha":"0c86e23e063c9668b97ae6318acd4ead00cb6164","user":{"login":"xchang4","id":11063622,"avatar_url":"https://avatars.githubusercontent.com/u/11063622?v=3","gravatar_id":"","url":"https://api.github.com/users/xchang4","html_url":"https://github.com/xchang4","followers_url":"https://api.github.com/users/xchang4/followers","following_url":"https://api.github.com/users/xchang4/following{/other_user}","gists_url":"https://api.github.com/users/xchang4/gists{/gist_id}","starred_url":"https://api.github.com/users/xchang4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xchang4/subscriptions","organizations_url":"https://api.github.com/users/xchang4/orgs","repos_url":"https://api.github.com/users/xchang4/repos","events_url":"https://api.github.com/users/xchang4/events{/privacy}","received_events_url":"https://api.github.com/users/xchang4/received_events","type":"User","site_admin":false},"repo":{"id":42024644,"name":"cs205-homework","full_name":"xchang4/cs205-homework","owner":{"login":"xchang4","id":11063622,"avatar_url":"https://avatars.githubusercontent.com/u/11063622?v=3","gravatar_id":"","url":"https://api.github.com/users/xchang4","html_url":"https://github.com/xchang4","followers_url":"https://api.github.com/users/xchang4/followers","following_url":"https://api.github.com/users/xchang4/following{/other_user}","gists_url":"https://api.github.com/users/xchang4/gists{/gist_id}","starred_url":"https://api.github.com/users/xchang4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xchang4/subscriptions","organizations_url":"https://api.github.com/users/xchang4/orgs","repos_url":"https://api.github.com/users/xchang4/repos","events_url":"https://api.github.com/users/xchang4/events{/privacy}","received_events_url":"https://api.github.com/users/xchang4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xchang4/cs205-homework","description":"","fork":true,"url":"https://api.github.com/repos/xchang4/cs205-homework","forks_url":"https://api.github.com/repos/xchang4/cs205-homework/forks","keys_url":"https://api.github.com/repos/xchang4/cs205-homework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xchang4/cs205-homework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xchang4/cs205-homework/teams","hooks_url":"https://api.github.com/repos/xchang4/cs205-homework/hooks","issue_events_url":"https://api.github.com/repos/xchang4/cs205-homework/issues/events{/number}","events_url":"https://api.github.com/repos/xchang4/cs205-homework/events","assignees_url":"https://api.github.com/repos/xchang4/cs205-homework/assignees{/user}","branches_url":"https://api.github.com/repos/xchang4/cs205-homework/branches{/branch}","tags_url":"https://api.github.com/repos/xchang4/cs205-homework/tags","blobs_url":"https://api.github.com/repos/xchang4/cs205-homework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xchang4/cs205-homework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xchang4/cs205-homework/git/refs{/sha}","trees_url":"https://api.github.com/repos/xchang4/cs205-homework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xchang4/cs205-homework/statuses/{sha}","languages_url":"https://api.github.com/repos/xchang4/cs205-homework/languages","stargazers_url":"https://api.github.com/repos/xchang4/cs205-homework/stargazers","contributors_url":"https://api.github.com/repos/xchang4/cs205-homework/contributors","subscribers_url":"https://api.github.com/repos/xchang4/cs205-homework/subscribers","subscription_url":"https://api.github.com/repos/xchang4/cs205-homework/subscription","commits_url":"https://api.github.com/repos/xchang4/cs205-homework/commits{/sha}","git_commits_url":"https://api.github.com/repos/xchang4/cs205-homework/git/commits{/sha}","comments_url":"https://api.github.com/repos/xchang4/cs205-homework/comments{/number}","issue_comment_url":"https://api.github.com/repos/xchang4/cs205-homework/issues/comments{/number}","contents_url":"https://api.github.com/repos/xchang4/cs205-homework/contents/{+path}","compare_url":"https://api.github.com/repos/xchang4/cs205-homework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xchang4/cs205-homework/merges","archive_url":"https://api.github.com/repos/xchang4/cs205-homework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xchang4/cs205-homework/downloads","issues_url":"https://api.github.com/repos/xchang4/cs205-homework/issues{/number}","pulls_url":"https://api.github.com/repos/xchang4/cs205-homework/pulls{/number}","milestones_url":"https://api.github.com/repos/xchang4/cs205-homework/milestones{/number}","notifications_url":"https://api.github.com/repos/xchang4/cs205-homework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xchang4/cs205-homework/labels{/name}","releases_url":"https://api.github.com/repos/xchang4/cs205-homework/releases{/id}","created_at":"2015-09-07T01:12:26Z","updated_at":"2015-09-07T01:12:26Z","pushed_at":"2015-11-03T02:10:55Z","git_url":"git://github.com/xchang4/cs205-homework.git","ssh_url":"git@github.com:xchang4/cs205-homework.git","clone_url":"https://github.com/xchang4/cs205-homework.git","svn_url":"https://github.com/xchang4/cs205-homework","homepage":null,"size":244,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"harvard-cs205:master","ref":"master","sha":"1b927f966d67a90215a9c462410f6ef57ff5d171","user":{"login":"harvard-cs205","id":13456002,"avatar_url":"https://avatars.githubusercontent.com/u/13456002?v=3","gravatar_id":"","url":"https://api.github.com/users/harvard-cs205","html_url":"https://github.com/harvard-cs205","followers_url":"https://api.github.com/users/harvard-cs205/followers","following_url":"https://api.github.com/users/harvard-cs205/following{/other_user}","gists_url":"https://api.github.com/users/harvard-cs205/gists{/gist_id}","starred_url":"https://api.github.com/users/harvard-cs205/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harvard-cs205/subscriptions","organizations_url":"https://api.github.com/users/harvard-cs205/orgs","repos_url":"https://api.github.com/users/harvard-cs205/repos","events_url":"https://api.github.com/users/harvard-cs205/events{/privacy}","received_events_url":"https://api.github.com/users/harvard-cs205/received_events","type":"Organization","site_admin":false},"repo":{"id":40614104,"name":"cs205-homework","full_name":"harvard-cs205/cs205-homework","owner":{"login":"harvard-cs205","id":13456002,"avatar_url":"https://avatars.githubusercontent.com/u/13456002?v=3","gravatar_id":"","url":"https://api.github.com/users/harvard-cs205","html_url":"https://github.com/harvard-cs205","followers_url":"https://api.github.com/users/harvard-cs205/followers","following_url":"https://api.github.com/users/harvard-cs205/following{/other_user}","gists_url":"https://api.github.com/users/harvard-cs205/gists{/gist_id}","starred_url":"https://api.github.com/users/harvard-cs205/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harvard-cs205/subscriptions","organizations_url":"https://api.github.com/users/harvard-cs205/orgs","repos_url":"https://api.github.com/users/harvard-cs205/repos","events_url":"https://api.github.com/users/harvard-cs205/events{/privacy}","received_events_url":"https://api.github.com/users/harvard-cs205/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/harvard-cs205/cs205-homework","description":"","fork":false,"url":"https://api.github.com/repos/harvard-cs205/cs205-homework","forks_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/forks","keys_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/teams","hooks_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/hooks","issue_events_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/issues/events{/number}","events_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/events","assignees_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/assignees{/user}","branches_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/branches{/branch}","tags_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/tags","blobs_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/git/refs{/sha}","trees_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/statuses/{sha}","languages_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/languages","stargazers_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/stargazers","contributors_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/contributors","subscribers_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/subscribers","subscription_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/subscription","commits_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/commits{/sha}","git_commits_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/git/commits{/sha}","comments_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/comments{/number}","issue_comment_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/issues/comments{/number}","contents_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/contents/{+path}","compare_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/merges","archive_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/downloads","issues_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/issues{/number}","pulls_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls{/number}","milestones_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/milestones{/number}","notifications_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/labels{/name}","releases_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/releases{/id}","created_at":"2015-08-12T17:18:15Z","updated_at":"2015-10-21T19:21:28Z","pushed_at":"2015-11-12T15:02:55Z","git_url":"git://github.com/harvard-cs205/cs205-homework.git","ssh_url":"git@github.com:harvard-cs205/cs205-homework.git","clone_url":"https://github.com/harvard-cs205/cs205-homework.git","svn_url":"https://github.com/harvard-cs205/cs205-homework","homepage":null,"size":162893,"stargazers_count":5,"watchers_count":5,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":99,"mirror_url":null,"open_issues_count":348,"forks":99,"open_issues":348,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/303"},"html":{"href":"https://github.com/harvard-cs205/cs205-homework/pull/303"},"issue":{"href":"https://api.github.com/repos/harvard-cs205/cs205-homework/issues/303"},"comments":{"href":"https://api.github.com/repos/harvard-cs205/cs205-homework/issues/303/comments"},"review_comments":{"href":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/303/comments"},"review_comment":{"href":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/303/commits"},"statuses":{"href":"https://api.github.com/repos/harvard-cs205/cs205-homework/statuses/0c86e23e063c9668b97ae6318acd4ead00cb6164"}}}}