{"action":"created","comment":{"url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/pulls/comments/28157903","id":28157903,"diff_hunk":"@@ -0,0 +1,44 @@\n+(function(){\n+    'use strict';\n+    describe('*******TODO*******', function(){\n+\n+        var gameModel;\n+\n+        beforeEach(function(){\n+            module('tombola.noughtAndCrosses.services');\n+            inject(function($injector){\n+                gameModel = $injector.get('gameModel')\n+            });\n+        });\n+\n+        it('Checks if a new game has been created',function(){\n+            expect(gameModel.gameboard).to.equal('000000000');\n+        });\n+\n+        it('player1 and player2 are set to human upon beginning a new game',function(){\n+            expect(gameModel.player1).to.equal('human');\n+            expect(gameModel.player2).to.equal('human');\n+        });\n+\n+        it('nextPlayerType function cycles through the different player types',function(){\n+            expect(gameModel.nextPlayerType()).to.equal('human');","path":"unit-tests/game-model-tests.js","position":24,"original_position":24,"commit_id":"f065e1ef8e6e84532188187bf5e5bd2e022d78b5","original_commit_id":"f065e1ef8e6e84532188187bf5e5bd2e022d78b5","user":{"login":"keithbarrow","id":8112111,"avatar_url":"https://avatars.githubusercontent.com/u/8112111?v=3","gravatar_id":"","url":"https://api.github.com/users/keithbarrow","html_url":"https://github.com/keithbarrow","followers_url":"https://api.github.com/users/keithbarrow/followers","following_url":"https://api.github.com/users/keithbarrow/following{/other_user}","gists_url":"https://api.github.com/users/keithbarrow/gists{/gist_id}","starred_url":"https://api.github.com/users/keithbarrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keithbarrow/subscriptions","organizations_url":"https://api.github.com/users/keithbarrow/orgs","repos_url":"https://api.github.com/users/keithbarrow/repos","events_url":"https://api.github.com/users/keithbarrow/events{/privacy}","received_events_url":"https://api.github.com/users/keithbarrow/received_events","type":"User","site_admin":false},"body":"If the game model starts as Human, and you cycle shouldn't you end up with something else?\r\nWhich player are you cycling 1 or 2? \r\nIf it isn't obvious from the test something is wrong - I suspect this method is internal to the game model & you should be testing something *like* gameModel.nextPlayer1Type() and similar methods for player 2. Additionally cycling one player isn't a full test  - better to keep moving to next until you are back where you started.","created_at":"2015-04-10T16:12:03Z","updated_at":"2015-04-10T16:12:03Z","html_url":"https://github.com/LewisGardner25/NoughtsAndCrosses/pull/17#discussion_r28157903","pull_request_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/pulls/comments/28157903"},"html":{"href":"https://github.com/LewisGardner25/NoughtsAndCrosses/pull/17#discussion_r28157903"},"pull_request":{"href":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/pulls/17","id":32960471,"html_url":"https://github.com/LewisGardner25/NoughtsAndCrosses/pull/17","diff_url":"https://github.com/LewisGardner25/NoughtsAndCrosses/pull/17.diff","patch_url":"https://github.com/LewisGardner25/NoughtsAndCrosses/pull/17.patch","issue_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/issues/17","number":17,"state":"open","locked":false,"title":"Unit testing gamemodel","user":{"login":"LewisGardner25","id":8625478,"avatar_url":"https://avatars.githubusercontent.com/u/8625478?v=3","gravatar_id":"","url":"https://api.github.com/users/LewisGardner25","html_url":"https://github.com/LewisGardner25","followers_url":"https://api.github.com/users/LewisGardner25/followers","following_url":"https://api.github.com/users/LewisGardner25/following{/other_user}","gists_url":"https://api.github.com/users/LewisGardner25/gists{/gist_id}","starred_url":"https://api.github.com/users/LewisGardner25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LewisGardner25/subscriptions","organizations_url":"https://api.github.com/users/LewisGardner25/orgs","repos_url":"https://api.github.com/users/LewisGardner25/repos","events_url":"https://api.github.com/users/LewisGardner25/events{/privacy}","received_events_url":"https://api.github.com/users/LewisGardner25/received_events","type":"User","site_admin":false},"body":"game model tests done","created_at":"2015-04-09T14:26:14Z","updated_at":"2015-04-10T16:12:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8807f11e71c6057febb4b1d9bec511563fdf438d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/pulls/17/commits","review_comments_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/pulls/17/comments","review_comment_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/issues/17/comments","statuses_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/statuses/f065e1ef8e6e84532188187bf5e5bd2e022d78b5","head":{"label":"LewisGardner25:unit-testing-gamemodel","ref":"unit-testing-gamemodel","sha":"f065e1ef8e6e84532188187bf5e5bd2e022d78b5","user":{"login":"LewisGardner25","id":8625478,"avatar_url":"https://avatars.githubusercontent.com/u/8625478?v=3","gravatar_id":"","url":"https://api.github.com/users/LewisGardner25","html_url":"https://github.com/LewisGardner25","followers_url":"https://api.github.com/users/LewisGardner25/followers","following_url":"https://api.github.com/users/LewisGardner25/following{/other_user}","gists_url":"https://api.github.com/users/LewisGardner25/gists{/gist_id}","starred_url":"https://api.github.com/users/LewisGardner25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LewisGardner25/subscriptions","organizations_url":"https://api.github.com/users/LewisGardner25/orgs","repos_url":"https://api.github.com/users/LewisGardner25/repos","events_url":"https://api.github.com/users/LewisGardner25/events{/privacy}","received_events_url":"https://api.github.com/users/LewisGardner25/received_events","type":"User","site_admin":false},"repo":{"id":27479248,"name":"NoughtsAndCrosses","full_name":"LewisGardner25/NoughtsAndCrosses","owner":{"login":"LewisGardner25","id":8625478,"avatar_url":"https://avatars.githubusercontent.com/u/8625478?v=3","gravatar_id":"","url":"https://api.github.com/users/LewisGardner25","html_url":"https://github.com/LewisGardner25","followers_url":"https://api.github.com/users/LewisGardner25/followers","following_url":"https://api.github.com/users/LewisGardner25/following{/other_user}","gists_url":"https://api.github.com/users/LewisGardner25/gists{/gist_id}","starred_url":"https://api.github.com/users/LewisGardner25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LewisGardner25/subscriptions","organizations_url":"https://api.github.com/users/LewisGardner25/orgs","repos_url":"https://api.github.com/users/LewisGardner25/repos","events_url":"https://api.github.com/users/LewisGardner25/events{/privacy}","received_events_url":"https://api.github.com/users/LewisGardner25/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LewisGardner25/NoughtsAndCrosses","description":"Noughts and Crosses Game","fork":false,"url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses","forks_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/forks","keys_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/teams","hooks_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/hooks","issue_events_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/issues/events{/number}","events_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/events","assignees_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/assignees{/user}","branches_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/branches{/branch}","tags_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/tags","blobs_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/git/refs{/sha}","trees_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/statuses/{sha}","languages_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/languages","stargazers_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/stargazers","contributors_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/contributors","subscribers_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/subscribers","subscription_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/subscription","commits_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/commits{/sha}","git_commits_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/git/commits{/sha}","comments_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/comments{/number}","issue_comment_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/issues/comments{/number}","contents_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/contents/{+path}","compare_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/merges","archive_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/downloads","issues_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/issues{/number}","pulls_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/pulls{/number}","milestones_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/milestones{/number}","notifications_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/labels{/name}","releases_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/releases{/id}","created_at":"2014-12-03T09:24:00Z","updated_at":"2015-03-12T14:32:11Z","pushed_at":"2015-04-09T14:26:14Z","git_url":"git://github.com/LewisGardner25/NoughtsAndCrosses.git","ssh_url":"git@github.com:LewisGardner25/NoughtsAndCrosses.git","clone_url":"https://github.com/LewisGardner25/NoughtsAndCrosses.git","svn_url":"https://github.com/LewisGardner25/NoughtsAndCrosses","homepage":null,"size":17000,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"LewisGardner25:master","ref":"master","sha":"a94b125e1c198e56194e31a52d25770f0834974d","user":{"login":"LewisGardner25","id":8625478,"avatar_url":"https://avatars.githubusercontent.com/u/8625478?v=3","gravatar_id":"","url":"https://api.github.com/users/LewisGardner25","html_url":"https://github.com/LewisGardner25","followers_url":"https://api.github.com/users/LewisGardner25/followers","following_url":"https://api.github.com/users/LewisGardner25/following{/other_user}","gists_url":"https://api.github.com/users/LewisGardner25/gists{/gist_id}","starred_url":"https://api.github.com/users/LewisGardner25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LewisGardner25/subscriptions","organizations_url":"https://api.github.com/users/LewisGardner25/orgs","repos_url":"https://api.github.com/users/LewisGardner25/repos","events_url":"https://api.github.com/users/LewisGardner25/events{/privacy}","received_events_url":"https://api.github.com/users/LewisGardner25/received_events","type":"User","site_admin":false},"repo":{"id":27479248,"name":"NoughtsAndCrosses","full_name":"LewisGardner25/NoughtsAndCrosses","owner":{"login":"LewisGardner25","id":8625478,"avatar_url":"https://avatars.githubusercontent.com/u/8625478?v=3","gravatar_id":"","url":"https://api.github.com/users/LewisGardner25","html_url":"https://github.com/LewisGardner25","followers_url":"https://api.github.com/users/LewisGardner25/followers","following_url":"https://api.github.com/users/LewisGardner25/following{/other_user}","gists_url":"https://api.github.com/users/LewisGardner25/gists{/gist_id}","starred_url":"https://api.github.com/users/LewisGardner25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LewisGardner25/subscriptions","organizations_url":"https://api.github.com/users/LewisGardner25/orgs","repos_url":"https://api.github.com/users/LewisGardner25/repos","events_url":"https://api.github.com/users/LewisGardner25/events{/privacy}","received_events_url":"https://api.github.com/users/LewisGardner25/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LewisGardner25/NoughtsAndCrosses","description":"Noughts and Crosses Game","fork":false,"url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses","forks_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/forks","keys_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/teams","hooks_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/hooks","issue_events_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/issues/events{/number}","events_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/events","assignees_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/assignees{/user}","branches_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/branches{/branch}","tags_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/tags","blobs_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/git/refs{/sha}","trees_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/statuses/{sha}","languages_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/languages","stargazers_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/stargazers","contributors_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/contributors","subscribers_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/subscribers","subscription_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/subscription","commits_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/commits{/sha}","git_commits_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/git/commits{/sha}","comments_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/comments{/number}","issue_comment_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/issues/comments{/number}","contents_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/contents/{+path}","compare_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/merges","archive_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/downloads","issues_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/issues{/number}","pulls_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/pulls{/number}","milestones_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/milestones{/number}","notifications_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/labels{/name}","releases_url":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/releases{/id}","created_at":"2014-12-03T09:24:00Z","updated_at":"2015-03-12T14:32:11Z","pushed_at":"2015-04-09T14:26:14Z","git_url":"git://github.com/LewisGardner25/NoughtsAndCrosses.git","ssh_url":"git@github.com:LewisGardner25/NoughtsAndCrosses.git","clone_url":"https://github.com/LewisGardner25/NoughtsAndCrosses.git","svn_url":"https://github.com/LewisGardner25/NoughtsAndCrosses","homepage":null,"size":17000,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/pulls/17"},"html":{"href":"https://github.com/LewisGardner25/NoughtsAndCrosses/pull/17"},"issue":{"href":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/issues/17"},"comments":{"href":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/LewisGardner25/NoughtsAndCrosses/statuses/f065e1ef8e6e84532188187bf5e5bd2e022d78b5"}}}}