{"action":"closed","number":5,"pull_request":{"url":"https://api.github.com/repos/Tribex/LDRParser/pulls/5","id":34613834,"html_url":"https://github.com/Tribex/LDRParser/pull/5","diff_url":"https://github.com/Tribex/LDRParser/pull/5.diff","patch_url":"https://github.com/Tribex/LDRParser/pull/5.patch","issue_url":"https://api.github.com/repos/Tribex/LDRParser/issues/5","number":5,"state":"closed","locked":false,"title":"Improve LDRParser#findFile method","user":{"login":"le717","id":3382464,"avatar_url":"https://avatars.githubusercontent.com/u/3382464?v=3","gravatar_id":"","url":"https://api.github.com/users/le717","html_url":"https://github.com/le717","followers_url":"https://api.github.com/users/le717/followers","following_url":"https://api.github.com/users/le717/following{/other_user}","gists_url":"https://api.github.com/users/le717/gists{/gist_id}","starred_url":"https://api.github.com/users/le717/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/le717/subscriptions","organizations_url":"https://api.github.com/users/le717/orgs","repos_url":"https://api.github.com/users/le717/repos","events_url":"https://api.github.com/users/le717/events{/privacy}","received_events_url":"https://api.github.com/users/le717/received_events","type":"User","site_admin":false},"body":"This improves the `findFile()` method in a few ways\r\n\r\n* Use `os.path.join()` for constructing paths\r\n* Store the paths in an list and loop over each path in it when finding the part\r\n* Correct search order (the order [I have here](https://github.com/le717/LDR-Importer/blob/be29cf1711906a37fdaeb2b34424e3cf46cb8803/import_ldraw.py#L1110-L1152) is correct, as an LDraw dev helped align it to spec)\r\n* Search the `models` and `Unofficial/p` folder too\r\n\r\nThis does not tackle the new high/low res folders (`48` and `8`, respectively), nor does it cover the LSynth parts. The former should be added ASAP (I can add them in this PR if you wish), but the latter is in no hurry (probably open an issue or something as a reminder).","created_at":"2015-05-04T03:26:04Z","updated_at":"2015-05-04T22:23:36Z","closed_at":"2015-05-04T22:23:36Z","merged_at":"2015-05-04T22:23:36Z","merge_commit_sha":"d0190fdd0c720e45981187cc3b4d326d696b4bb2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Tribex/LDRParser/pulls/5/commits","review_comments_url":"https://api.github.com/repos/Tribex/LDRParser/pulls/5/comments","review_comment_url":"https://api.github.com/repos/Tribex/LDRParser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Tribex/LDRParser/issues/5/comments","statuses_url":"https://api.github.com/repos/Tribex/LDRParser/statuses/632637acef4193b1e7dbed663470ca33550a43a3","head":{"label":"le717:better-findFile","ref":"better-findFile","sha":"632637acef4193b1e7dbed663470ca33550a43a3","user":{"login":"le717","id":3382464,"avatar_url":"https://avatars.githubusercontent.com/u/3382464?v=3","gravatar_id":"","url":"https://api.github.com/users/le717","html_url":"https://github.com/le717","followers_url":"https://api.github.com/users/le717/followers","following_url":"https://api.github.com/users/le717/following{/other_user}","gists_url":"https://api.github.com/users/le717/gists{/gist_id}","starred_url":"https://api.github.com/users/le717/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/le717/subscriptions","organizations_url":"https://api.github.com/users/le717/orgs","repos_url":"https://api.github.com/users/le717/repos","events_url":"https://api.github.com/users/le717/events{/privacy}","received_events_url":"https://api.github.com/users/le717/received_events","type":"User","site_admin":false},"repo":{"id":35000402,"name":"LDRParser","full_name":"le717/LDRParser","owner":{"login":"le717","id":3382464,"avatar_url":"https://avatars.githubusercontent.com/u/3382464?v=3","gravatar_id":"","url":"https://api.github.com/users/le717","html_url":"https://github.com/le717","followers_url":"https://api.github.com/users/le717/followers","following_url":"https://api.github.com/users/le717/following{/other_user}","gists_url":"https://api.github.com/users/le717/gists{/gist_id}","starred_url":"https://api.github.com/users/le717/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/le717/subscriptions","organizations_url":"https://api.github.com/users/le717/orgs","repos_url":"https://api.github.com/users/le717/repos","events_url":"https://api.github.com/users/le717/events{/privacy}","received_events_url":"https://api.github.com/users/le717/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/le717/LDRParser","description":"A recursive parser written in Python for LDR (LDraw) files to combine them into one, easily converted and rendered file. Supports both Python Dictionaries and JSON.","fork":true,"url":"https://api.github.com/repos/le717/LDRParser","forks_url":"https://api.github.com/repos/le717/LDRParser/forks","keys_url":"https://api.github.com/repos/le717/LDRParser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/le717/LDRParser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/le717/LDRParser/teams","hooks_url":"https://api.github.com/repos/le717/LDRParser/hooks","issue_events_url":"https://api.github.com/repos/le717/LDRParser/issues/events{/number}","events_url":"https://api.github.com/repos/le717/LDRParser/events","assignees_url":"https://api.github.com/repos/le717/LDRParser/assignees{/user}","branches_url":"https://api.github.com/repos/le717/LDRParser/branches{/branch}","tags_url":"https://api.github.com/repos/le717/LDRParser/tags","blobs_url":"https://api.github.com/repos/le717/LDRParser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/le717/LDRParser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/le717/LDRParser/git/refs{/sha}","trees_url":"https://api.github.com/repos/le717/LDRParser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/le717/LDRParser/statuses/{sha}","languages_url":"https://api.github.com/repos/le717/LDRParser/languages","stargazers_url":"https://api.github.com/repos/le717/LDRParser/stargazers","contributors_url":"https://api.github.com/repos/le717/LDRParser/contributors","subscribers_url":"https://api.github.com/repos/le717/LDRParser/subscribers","subscription_url":"https://api.github.com/repos/le717/LDRParser/subscription","commits_url":"https://api.github.com/repos/le717/LDRParser/commits{/sha}","git_commits_url":"https://api.github.com/repos/le717/LDRParser/git/commits{/sha}","comments_url":"https://api.github.com/repos/le717/LDRParser/comments{/number}","issue_comment_url":"https://api.github.com/repos/le717/LDRParser/issues/comments{/number}","contents_url":"https://api.github.com/repos/le717/LDRParser/contents/{+path}","compare_url":"https://api.github.com/repos/le717/LDRParser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/le717/LDRParser/merges","archive_url":"https://api.github.com/repos/le717/LDRParser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/le717/LDRParser/downloads","issues_url":"https://api.github.com/repos/le717/LDRParser/issues{/number}","pulls_url":"https://api.github.com/repos/le717/LDRParser/pulls{/number}","milestones_url":"https://api.github.com/repos/le717/LDRParser/milestones{/number}","notifications_url":"https://api.github.com/repos/le717/LDRParser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/le717/LDRParser/labels{/name}","releases_url":"https://api.github.com/repos/le717/LDRParser/releases{/id}","created_at":"2015-05-03T20:52:56Z","updated_at":"2015-05-04T18:34:19Z","pushed_at":"2015-05-04T18:34:19Z","git_url":"git://github.com/le717/LDRParser.git","ssh_url":"git@github.com:le717/LDRParser.git","clone_url":"https://github.com/le717/LDRParser.git","svn_url":"https://github.com/le717/LDRParser","homepage":null,"size":84,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Tribex:master","ref":"master","sha":"75fe43b21795d8b6bd6ce963d5f33d49a0bbf603","user":{"login":"Tribex","id":5861371,"avatar_url":"https://avatars.githubusercontent.com/u/5861371?v=3","gravatar_id":"","url":"https://api.github.com/users/Tribex","html_url":"https://github.com/Tribex","followers_url":"https://api.github.com/users/Tribex/followers","following_url":"https://api.github.com/users/Tribex/following{/other_user}","gists_url":"https://api.github.com/users/Tribex/gists{/gist_id}","starred_url":"https://api.github.com/users/Tribex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tribex/subscriptions","organizations_url":"https://api.github.com/users/Tribex/orgs","repos_url":"https://api.github.com/users/Tribex/repos","events_url":"https://api.github.com/users/Tribex/events{/privacy}","received_events_url":"https://api.github.com/users/Tribex/received_events","type":"User","site_admin":false},"repo":{"id":32989797,"name":"LDRParser","full_name":"Tribex/LDRParser","owner":{"login":"Tribex","id":5861371,"avatar_url":"https://avatars.githubusercontent.com/u/5861371?v=3","gravatar_id":"","url":"https://api.github.com/users/Tribex","html_url":"https://github.com/Tribex","followers_url":"https://api.github.com/users/Tribex/followers","following_url":"https://api.github.com/users/Tribex/following{/other_user}","gists_url":"https://api.github.com/users/Tribex/gists{/gist_id}","starred_url":"https://api.github.com/users/Tribex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tribex/subscriptions","organizations_url":"https://api.github.com/users/Tribex/orgs","repos_url":"https://api.github.com/users/Tribex/repos","events_url":"https://api.github.com/users/Tribex/events{/privacy}","received_events_url":"https://api.github.com/users/Tribex/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Tribex/LDRParser","description":"A recursive parser written in Python for LDR (LDraw) files to combine them into one, easily converted and rendered file. Supports both Python Dictionaries and JSON.","fork":false,"url":"https://api.github.com/repos/Tribex/LDRParser","forks_url":"https://api.github.com/repos/Tribex/LDRParser/forks","keys_url":"https://api.github.com/repos/Tribex/LDRParser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tribex/LDRParser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tribex/LDRParser/teams","hooks_url":"https://api.github.com/repos/Tribex/LDRParser/hooks","issue_events_url":"https://api.github.com/repos/Tribex/LDRParser/issues/events{/number}","events_url":"https://api.github.com/repos/Tribex/LDRParser/events","assignees_url":"https://api.github.com/repos/Tribex/LDRParser/assignees{/user}","branches_url":"https://api.github.com/repos/Tribex/LDRParser/branches{/branch}","tags_url":"https://api.github.com/repos/Tribex/LDRParser/tags","blobs_url":"https://api.github.com/repos/Tribex/LDRParser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tribex/LDRParser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tribex/LDRParser/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tribex/LDRParser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tribex/LDRParser/statuses/{sha}","languages_url":"https://api.github.com/repos/Tribex/LDRParser/languages","stargazers_url":"https://api.github.com/repos/Tribex/LDRParser/stargazers","contributors_url":"https://api.github.com/repos/Tribex/LDRParser/contributors","subscribers_url":"https://api.github.com/repos/Tribex/LDRParser/subscribers","subscription_url":"https://api.github.com/repos/Tribex/LDRParser/subscription","commits_url":"https://api.github.com/repos/Tribex/LDRParser/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tribex/LDRParser/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tribex/LDRParser/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tribex/LDRParser/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tribex/LDRParser/contents/{+path}","compare_url":"https://api.github.com/repos/Tribex/LDRParser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tribex/LDRParser/merges","archive_url":"https://api.github.com/repos/Tribex/LDRParser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tribex/LDRParser/downloads","issues_url":"https://api.github.com/repos/Tribex/LDRParser/issues{/number}","pulls_url":"https://api.github.com/repos/Tribex/LDRParser/pulls{/number}","milestones_url":"https://api.github.com/repos/Tribex/LDRParser/milestones{/number}","notifications_url":"https://api.github.com/repos/Tribex/LDRParser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tribex/LDRParser/labels{/name}","releases_url":"https://api.github.com/repos/Tribex/LDRParser/releases{/id}","created_at":"2015-03-27T14:11:25Z","updated_at":"2015-05-04T04:09:07Z","pushed_at":"2015-05-04T22:23:36Z","git_url":"git://github.com/Tribex/LDRParser.git","ssh_url":"git@github.com:Tribex/LDRParser.git","clone_url":"https://github.com/Tribex/LDRParser.git","svn_url":"https://github.com/Tribex/LDRParser","homepage":null,"size":124,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Tribex/LDRParser/pulls/5"},"html":{"href":"https://github.com/Tribex/LDRParser/pull/5"},"issue":{"href":"https://api.github.com/repos/Tribex/LDRParser/issues/5"},"comments":{"href":"https://api.github.com/repos/Tribex/LDRParser/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/Tribex/LDRParser/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/Tribex/LDRParser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Tribex/LDRParser/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/Tribex/LDRParser/statuses/632637acef4193b1e7dbed663470ca33550a43a3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Tribex","id":5861371,"avatar_url":"https://avatars.githubusercontent.com/u/5861371?v=3","gravatar_id":"","url":"https://api.github.com/users/Tribex","html_url":"https://github.com/Tribex","followers_url":"https://api.github.com/users/Tribex/followers","following_url":"https://api.github.com/users/Tribex/following{/other_user}","gists_url":"https://api.github.com/users/Tribex/gists{/gist_id}","starred_url":"https://api.github.com/users/Tribex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tribex/subscriptions","organizations_url":"https://api.github.com/users/Tribex/orgs","repos_url":"https://api.github.com/users/Tribex/repos","events_url":"https://api.github.com/users/Tribex/events{/privacy}","received_events_url":"https://api.github.com/users/Tribex/received_events","type":"User","site_admin":false},"comments":3,"review_comments":2,"commits":2,"additions":32,"deletions":25,"changed_files":2}}