{"action":"closed","number":13528,"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/13528","id":27706472,"html_url":"https://github.com/owncloud/core/pull/13528","diff_url":"https://github.com/owncloud/core/pull/13528.diff","patch_url":"https://github.com/owncloud/core/pull/13528.patch","issue_url":"https://api.github.com/repos/owncloud/core/issues/13528","number":13528,"state":"closed","locked":false,"title":"Added confirm delete of single file and selected files","user":{"login":"ShamimIslam","id":3057742,"avatar_url":"https://avatars.githubusercontent.com/u/3057742?v=3","gravatar_id":"","url":"https://api.github.com/users/ShamimIslam","html_url":"https://github.com/ShamimIslam","followers_url":"https://api.github.com/users/ShamimIslam/followers","following_url":"https://api.github.com/users/ShamimIslam/following{/other_user}","gists_url":"https://api.github.com/users/ShamimIslam/gists{/gist_id}","starred_url":"https://api.github.com/users/ShamimIslam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShamimIslam/subscriptions","organizations_url":"https://api.github.com/users/ShamimIslam/orgs","repos_url":"https://api.github.com/users/ShamimIslam/repos","events_url":"https://api.github.com/users/ShamimIslam/events{/privacy}","received_events_url":"https://api.github.com/users/ShamimIslam/received_events","type":"User","site_admin":false},"body":"Implements proper delete confirm using OwnCloud tools. Required for large-scale file/users use. Delete icon is next to scroll elevator and is subject to accidental clicking (click on user menu, click on elevator). Delete loses sharing attributes. Restore does not restore sharing. Better to prevent the problem than to create an undo for a simple problem. Alternatively, this option can be turned into configurable feature. Best option would be a double push like the Apple Store \"buy\" or the Amazon music buy - first click primes the action. Second click creates the action. Primed action times out after 5s or some timeout. This is the simple fix. This topic has been discussed a number of times, but the \"undo\" does not resolve the problems that the \"automatic delete\" creates. Until the \"undo\" works correctly, this is the correct solution.\r\n\r\nThis contribution is MIT licensed.","created_at":"2015-01-20T19:50:36Z","updated_at":"2015-05-15T07:58:43Z","closed_at":"2015-05-15T07:58:43Z","merged_at":null,"merge_commit_sha":"7dc8d54458976dbc7545226042424b16064e1976","assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/37","html_url":"https://github.com/owncloud/core/milestones/8.2-next","labels_url":"https://api.github.com/repos/owncloud/core/milestones/37/labels","id":993629,"number":37,"title":"8.2-next","description":"","creator":{"login":"craigpg","id":160667,"avatar_url":"https://avatars.githubusercontent.com/u/160667?v=3","gravatar_id":"","url":"https://api.github.com/users/craigpg","html_url":"https://github.com/craigpg","followers_url":"https://api.github.com/users/craigpg/followers","following_url":"https://api.github.com/users/craigpg/following{/other_user}","gists_url":"https://api.github.com/users/craigpg/gists{/gist_id}","starred_url":"https://api.github.com/users/craigpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigpg/subscriptions","organizations_url":"https://api.github.com/users/craigpg/orgs","repos_url":"https://api.github.com/users/craigpg/repos","events_url":"https://api.github.com/users/craigpg/events{/privacy}","received_events_url":"https://api.github.com/users/craigpg/received_events","type":"User","site_admin":false},"open_issues":449,"closed_issues":4,"state":"open","created_at":"2015-02-24T16:19:37Z","updated_at":"2015-05-15T07:58:43Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/owncloud/core/pulls/13528/commits","review_comments_url":"https://api.github.com/repos/owncloud/core/pulls/13528/comments","review_comment_url":"https://api.github.com/repos/owncloud/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/core/issues/13528/comments","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/1786f9ef202ca9aaf6fbe9af8cf5c6179fb0dc8c","head":{"label":"ShamimIslam:master","ref":"master","sha":"1786f9ef202ca9aaf6fbe9af8cf5c6179fb0dc8c","user":{"login":"ShamimIslam","id":3057742,"avatar_url":"https://avatars.githubusercontent.com/u/3057742?v=3","gravatar_id":"","url":"https://api.github.com/users/ShamimIslam","html_url":"https://github.com/ShamimIslam","followers_url":"https://api.github.com/users/ShamimIslam/followers","following_url":"https://api.github.com/users/ShamimIslam/following{/other_user}","gists_url":"https://api.github.com/users/ShamimIslam/gists{/gist_id}","starred_url":"https://api.github.com/users/ShamimIslam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShamimIslam/subscriptions","organizations_url":"https://api.github.com/users/ShamimIslam/orgs","repos_url":"https://api.github.com/users/ShamimIslam/repos","events_url":"https://api.github.com/users/ShamimIslam/events{/privacy}","received_events_url":"https://api.github.com/users/ShamimIslam/received_events","type":"User","site_admin":false},"repo":{"id":29548301,"name":"core","full_name":"ShamimIslam/core","owner":{"login":"ShamimIslam","id":3057742,"avatar_url":"https://avatars.githubusercontent.com/u/3057742?v=3","gravatar_id":"","url":"https://api.github.com/users/ShamimIslam","html_url":"https://github.com/ShamimIslam","followers_url":"https://api.github.com/users/ShamimIslam/followers","following_url":"https://api.github.com/users/ShamimIslam/following{/other_user}","gists_url":"https://api.github.com/users/ShamimIslam/gists{/gist_id}","starred_url":"https://api.github.com/users/ShamimIslam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShamimIslam/subscriptions","organizations_url":"https://api.github.com/users/ShamimIslam/orgs","repos_url":"https://api.github.com/users/ShamimIslam/repos","events_url":"https://api.github.com/users/ShamimIslam/events{/privacy}","received_events_url":"https://api.github.com/users/ShamimIslam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ShamimIslam/core","description":"The ownCloud core","fork":true,"url":"https://api.github.com/repos/ShamimIslam/core","forks_url":"https://api.github.com/repos/ShamimIslam/core/forks","keys_url":"https://api.github.com/repos/ShamimIslam/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ShamimIslam/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ShamimIslam/core/teams","hooks_url":"https://api.github.com/repos/ShamimIslam/core/hooks","issue_events_url":"https://api.github.com/repos/ShamimIslam/core/issues/events{/number}","events_url":"https://api.github.com/repos/ShamimIslam/core/events","assignees_url":"https://api.github.com/repos/ShamimIslam/core/assignees{/user}","branches_url":"https://api.github.com/repos/ShamimIslam/core/branches{/branch}","tags_url":"https://api.github.com/repos/ShamimIslam/core/tags","blobs_url":"https://api.github.com/repos/ShamimIslam/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ShamimIslam/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ShamimIslam/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ShamimIslam/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ShamimIslam/core/statuses/{sha}","languages_url":"https://api.github.com/repos/ShamimIslam/core/languages","stargazers_url":"https://api.github.com/repos/ShamimIslam/core/stargazers","contributors_url":"https://api.github.com/repos/ShamimIslam/core/contributors","subscribers_url":"https://api.github.com/repos/ShamimIslam/core/subscribers","subscription_url":"https://api.github.com/repos/ShamimIslam/core/subscription","commits_url":"https://api.github.com/repos/ShamimIslam/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ShamimIslam/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ShamimIslam/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ShamimIslam/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ShamimIslam/core/contents/{+path}","compare_url":"https://api.github.com/repos/ShamimIslam/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ShamimIslam/core/merges","archive_url":"https://api.github.com/repos/ShamimIslam/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ShamimIslam/core/downloads","issues_url":"https://api.github.com/repos/ShamimIslam/core/issues{/number}","pulls_url":"https://api.github.com/repos/ShamimIslam/core/pulls{/number}","milestones_url":"https://api.github.com/repos/ShamimIslam/core/milestones{/number}","notifications_url":"https://api.github.com/repos/ShamimIslam/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ShamimIslam/core/labels{/name}","releases_url":"https://api.github.com/repos/ShamimIslam/core/releases{/id}","created_at":"2015-01-20T19:40:29Z","updated_at":"2015-02-25T23:56:11Z","pushed_at":"2015-02-25T23:56:11Z","git_url":"git://github.com/ShamimIslam/core.git","ssh_url":"git@github.com:ShamimIslam/core.git","clone_url":"https://github.com/ShamimIslam/core.git","svn_url":"https://github.com/ShamimIslam/core","homepage":null,"size":159071,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"cdf82909b8225a885fbf92b78208fb1fe258853e","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":5550552,"name":"core","full_name":"owncloud/core","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/core","description":"The ownCloud core","fork":false,"url":"https://api.github.com/repos/owncloud/core","forks_url":"https://api.github.com/repos/owncloud/core/forks","keys_url":"https://api.github.com/repos/owncloud/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/core/teams","hooks_url":"https://api.github.com/repos/owncloud/core/hooks","issue_events_url":"https://api.github.com/repos/owncloud/core/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/core/events","assignees_url":"https://api.github.com/repos/owncloud/core/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/core/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/core/tags","blobs_url":"https://api.github.com/repos/owncloud/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/core/languages","stargazers_url":"https://api.github.com/repos/owncloud/core/stargazers","contributors_url":"https://api.github.com/repos/owncloud/core/contributors","subscribers_url":"https://api.github.com/repos/owncloud/core/subscribers","subscription_url":"https://api.github.com/repos/owncloud/core/subscription","commits_url":"https://api.github.com/repos/owncloud/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/core/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/core/merges","archive_url":"https://api.github.com/repos/owncloud/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/core/downloads","issues_url":"https://api.github.com/repos/owncloud/core/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/core/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/core/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/core/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/core/releases{/id}","created_at":"2012-08-25T10:32:48Z","updated_at":"2015-05-15T06:58:22Z","pushed_at":"2015-05-15T07:17:22Z","git_url":"git://github.com/owncloud/core.git","ssh_url":"git@github.com:owncloud/core.git","clone_url":"https://github.com/owncloud/core.git","svn_url":"https://github.com/owncloud/core","homepage":"https://owncloud.org/","size":1037744,"stargazers_count":3310,"watchers_count":3310,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1059,"mirror_url":null,"open_issues_count":1848,"forks":1059,"open_issues":1848,"watchers":3310,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/13528"},"html":{"href":"https://github.com/owncloud/core/pull/13528"},"issue":{"href":"https://api.github.com/repos/owncloud/core/issues/13528"},"comments":{"href":"https://api.github.com/repos/owncloud/core/issues/13528/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/core/pulls/13528/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/core/pulls/13528/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/core/statuses/1786f9ef202ca9aaf6fbe9af8cf5c6179fb0dc8c"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":38,"review_comments":0,"commits":4,"additions":22,"deletions":1,"changed_files":2}}