{"comment":{"url":"https://api.github.com/repos/iemejia/edx-downloader/comments/11303139","html_url":"https://github.com/iemejia/edx-downloader/commit/c6909beac9be1402769189794df374edf65acfc9#commitcomment-11303139","id":11303139,"user":{"login":"rbrito","id":212145,"avatar_url":"https://avatars.githubusercontent.com/u/212145?v=3","gravatar_id":"","url":"https://api.github.com/users/rbrito","html_url":"https://github.com/rbrito","followers_url":"https://api.github.com/users/rbrito/followers","following_url":"https://api.github.com/users/rbrito/following{/other_user}","gists_url":"https://api.github.com/users/rbrito/gists{/gist_id}","starred_url":"https://api.github.com/users/rbrito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbrito/subscriptions","organizations_url":"https://api.github.com/users/rbrito/orgs","repos_url":"https://api.github.com/users/rbrito/repos","events_url":"https://api.github.com/users/rbrito/events{/privacy}","received_events_url":"https://api.github.com/users/rbrito/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"c6909beac9be1402769189794df374edf65acfc9","created_at":"2015-05-21T10:53:42Z","updated_at":"2015-05-21T10:53:42Z","body":"This is a good idea, but I'm not sure about the implementation. The hardcoded values seem a bit too fragile.\r\n\r\nI still stand by my approach of parsing URLs (either passed by the user or grabbed from the pages) as I implemented in https://github.com/rbrito/edx-dl/blob/master/edx_dl/edx_dl.py#L117-L157.\r\n\r\nThis \"normalization\" may be extra, unnecessary work, but it may save us from platforms that are constantly changing. And sites are generally constantly changing.\r\n\r\nI guess that I can extract/refactor that code as a function and send it as a pull request to this project, so that we can use it for our own purposes.\r\n\r\nPlease, comment on my proposal."}}