{"action":"created","comment":{"url":"https://api.github.com/repos/contao/core-bundle/pulls/comments/29648944","id":29648944,"diff_hunk":"@@ -0,0 +1,74 @@\n+<?php\n+\n+/**\n+ * This file is part of Contao.\n+ *\n+ * Copyright (c) 2005-2015 Leo Feyer\n+ *\n+ * @license LGPL-3.0+\n+ */\n+\n+\n+namespace Contao\\CoreBundle\\Legacy\\Framework;","path":"src/Legacy/Framework/Initializer.php","position":null,"original_position":12,"commit_id":"adb6aa8666aa983d1429afe7525e8f32ac1999e1","original_commit_id":"fc35cf493cb4461a7ccb4fa4e152bf0a4f20e482","user":{"login":"Toflar","id":481937,"avatar_url":"https://avatars.githubusercontent.com/u/481937?v=3","gravatar_id":"","url":"https://api.github.com/users/Toflar","html_url":"https://github.com/Toflar","followers_url":"https://api.github.com/users/Toflar/followers","following_url":"https://api.github.com/users/Toflar/following{/other_user}","gists_url":"https://api.github.com/users/Toflar/gists{/gist_id}","starred_url":"https://api.github.com/users/Toflar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Toflar/subscriptions","organizations_url":"https://api.github.com/users/Toflar/orgs","repos_url":"https://api.github.com/users/Toflar/repos","events_url":"https://api.github.com/users/Toflar/events{/privacy}","received_events_url":"https://api.github.com/users/Toflar/received_events","type":"User","site_admin":false},"body":"To me and @aschempp, yes :) But we'll see at the call tomorrow, thx for the changes! :)","created_at":"2015-05-05T07:51:45Z","updated_at":"2015-05-05T07:51:45Z","html_url":"https://github.com/contao/core-bundle/pull/234#discussion_r29648944","pull_request_url":"https://api.github.com/repos/contao/core-bundle/pulls/234","_links":{"self":{"href":"https://api.github.com/repos/contao/core-bundle/pulls/comments/29648944"},"html":{"href":"https://github.com/contao/core-bundle/pull/234#discussion_r29648944"},"pull_request":{"href":"https://api.github.com/repos/contao/core-bundle/pulls/234"}}},"pull_request":{"url":"https://api.github.com/repos/contao/core-bundle/pulls/234","id":34057821,"html_url":"https://github.com/contao/core-bundle/pull/234","diff_url":"https://github.com/contao/core-bundle/pull/234.diff","patch_url":"https://github.com/contao/core-bundle/pull/234.patch","issue_url":"https://api.github.com/repos/contao/core-bundle/issues/234","number":234,"state":"open","locked":false,"title":"[RFC] Split InitializeSystemListener","user":{"login":"dtomasi","id":1616726,"avatar_url":"https://avatars.githubusercontent.com/u/1616726?v=3","gravatar_id":"","url":"https://api.github.com/users/dtomasi","html_url":"https://github.com/dtomasi","followers_url":"https://api.github.com/users/dtomasi/followers","following_url":"https://api.github.com/users/dtomasi/following{/other_user}","gists_url":"https://api.github.com/users/dtomasi/gists{/gist_id}","starred_url":"https://api.github.com/users/dtomasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtomasi/subscriptions","organizations_url":"https://api.github.com/users/dtomasi/orgs","repos_url":"https://api.github.com/users/dtomasi/repos","events_url":"https://api.github.com/users/dtomasi/events{/privacy}","received_events_url":"https://api.github.com/users/dtomasi/received_events","type":"User","site_admin":false},"body":"see: #192 \r\n\r\nThings that are done:\r\n\r\n- splitted `IntitializeSystemListener` in 8 decoupled listeners\r\n- Listeners in `Contao\\CoreBundle\\EventListener\\Framework` are registered by a `CompilerPass` see: https://github.com/ContaoBlackForest/core-bundle/blob/feature/split-initialize-system-listener/src/ContaoCoreBundle.php#L64\r\n- `InitializeSystemListenerTest` is rewritten to test `contao.framework.boot`-Event is dispatched and how often this happens.\r\n- Some tests for listeners in `Contao\\CoreBundle\\EventListener\\Framework` are already coded\r\n\r\nThings that need to be done:\r\n\r\n- Write tests for all listeners in `Contao\\CoreBundle\\EventListener\\Framework`\r\n- Write a test-setup that loads all required services and parameters to load the framework. This is needed for other Tests like `AddToSearchIndexListenerTest`.\r\n\r\nThings that need to be discussed:\r\n\r\n- basic structure\r\n- naming of listeners\r\n- should the listeners bei separated from listeners in `listeners.yml`? maybe `listeners_framework.yml` ? \r\n- should we also create a `contao.framework.terminate` and `contao.framework.exception`- Event ?\r\n\r\nWhat are your opinions ?","created_at":"2015-04-24T15:16:39Z","updated_at":"2015-05-05T07:51:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86789a9349350eb40c9e15f8f174af1514613394","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/contao/core-bundle/pulls/234/commits","review_comments_url":"https://api.github.com/repos/contao/core-bundle/pulls/234/comments","review_comment_url":"https://api.github.com/repos/contao/core-bundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/contao/core-bundle/issues/234/comments","statuses_url":"https://api.github.com/repos/contao/core-bundle/statuses/adb6aa8666aa983d1429afe7525e8f32ac1999e1","head":{"label":"ContaoBlackForest:feature/split-initialize-system-listener","ref":"feature/split-initialize-system-listener","sha":"adb6aa8666aa983d1429afe7525e8f32ac1999e1","user":{"login":"ContaoBlackForest","id":10738142,"avatar_url":"https://avatars.githubusercontent.com/u/10738142?v=3","gravatar_id":"","url":"https://api.github.com/users/ContaoBlackForest","html_url":"https://github.com/ContaoBlackForest","followers_url":"https://api.github.com/users/ContaoBlackForest/followers","following_url":"https://api.github.com/users/ContaoBlackForest/following{/other_user}","gists_url":"https://api.github.com/users/ContaoBlackForest/gists{/gist_id}","starred_url":"https://api.github.com/users/ContaoBlackForest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ContaoBlackForest/subscriptions","organizations_url":"https://api.github.com/users/ContaoBlackForest/orgs","repos_url":"https://api.github.com/users/ContaoBlackForest/repos","events_url":"https://api.github.com/users/ContaoBlackForest/events{/privacy}","received_events_url":"https://api.github.com/users/ContaoBlackForest/received_events","type":"Organization","site_admin":false},"repo":{"id":34377538,"name":"core-bundle","full_name":"ContaoBlackForest/core-bundle","owner":{"login":"ContaoBlackForest","id":10738142,"avatar_url":"https://avatars.githubusercontent.com/u/10738142?v=3","gravatar_id":"","url":"https://api.github.com/users/ContaoBlackForest","html_url":"https://github.com/ContaoBlackForest","followers_url":"https://api.github.com/users/ContaoBlackForest/followers","following_url":"https://api.github.com/users/ContaoBlackForest/following{/other_user}","gists_url":"https://api.github.com/users/ContaoBlackForest/gists{/gist_id}","starred_url":"https://api.github.com/users/ContaoBlackForest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ContaoBlackForest/subscriptions","organizations_url":"https://api.github.com/users/ContaoBlackForest/orgs","repos_url":"https://api.github.com/users/ContaoBlackForest/repos","events_url":"https://api.github.com/users/ContaoBlackForest/events{/privacy}","received_events_url":"https://api.github.com/users/ContaoBlackForest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ContaoBlackForest/core-bundle","description":"Contao 4 core bundle","fork":true,"url":"https://api.github.com/repos/ContaoBlackForest/core-bundle","forks_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/forks","keys_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/teams","hooks_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/hooks","issue_events_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/events","assignees_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/tags","blobs_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/languages","stargazers_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/stargazers","contributors_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/contributors","subscribers_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/subscribers","subscription_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/subscription","commits_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/merges","archive_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/downloads","issues_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/labels{/name}","releases_url":"https://api.github.com/repos/ContaoBlackForest/core-bundle/releases{/id}","created_at":"2015-04-22T08:09:21Z","updated_at":"2015-05-01T11:43:40Z","pushed_at":"2015-05-05T05:42:23Z","git_url":"git://github.com/ContaoBlackForest/core-bundle.git","ssh_url":"git@github.com:ContaoBlackForest/core-bundle.git","clone_url":"https://github.com/ContaoBlackForest/core-bundle.git","svn_url":"https://github.com/ContaoBlackForest/core-bundle","homepage":"","size":22704,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"contao:develop","ref":"develop","sha":"125608ad5247de40a9f17dd87cecb116096a65dc","user":{"login":"contao","id":1206136,"avatar_url":"https://avatars.githubusercontent.com/u/1206136?v=3","gravatar_id":"","url":"https://api.github.com/users/contao","html_url":"https://github.com/contao","followers_url":"https://api.github.com/users/contao/followers","following_url":"https://api.github.com/users/contao/following{/other_user}","gists_url":"https://api.github.com/users/contao/gists{/gist_id}","starred_url":"https://api.github.com/users/contao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contao/subscriptions","organizations_url":"https://api.github.com/users/contao/orgs","repos_url":"https://api.github.com/users/contao/repos","events_url":"https://api.github.com/users/contao/events{/privacy}","received_events_url":"https://api.github.com/users/contao/received_events","type":"Organization","site_admin":false},"repo":{"id":20519851,"name":"core-bundle","full_name":"contao/core-bundle","owner":{"login":"contao","id":1206136,"avatar_url":"https://avatars.githubusercontent.com/u/1206136?v=3","gravatar_id":"","url":"https://api.github.com/users/contao","html_url":"https://github.com/contao","followers_url":"https://api.github.com/users/contao/followers","following_url":"https://api.github.com/users/contao/following{/other_user}","gists_url":"https://api.github.com/users/contao/gists{/gist_id}","starred_url":"https://api.github.com/users/contao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contao/subscriptions","organizations_url":"https://api.github.com/users/contao/orgs","repos_url":"https://api.github.com/users/contao/repos","events_url":"https://api.github.com/users/contao/events{/privacy}","received_events_url":"https://api.github.com/users/contao/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/contao/core-bundle","description":"Contao 4 core bundle","fork":false,"url":"https://api.github.com/repos/contao/core-bundle","forks_url":"https://api.github.com/repos/contao/core-bundle/forks","keys_url":"https://api.github.com/repos/contao/core-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/contao/core-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/contao/core-bundle/teams","hooks_url":"https://api.github.com/repos/contao/core-bundle/hooks","issue_events_url":"https://api.github.com/repos/contao/core-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/contao/core-bundle/events","assignees_url":"https://api.github.com/repos/contao/core-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/contao/core-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/contao/core-bundle/tags","blobs_url":"https://api.github.com/repos/contao/core-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/contao/core-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/contao/core-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/contao/core-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/contao/core-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/contao/core-bundle/languages","stargazers_url":"https://api.github.com/repos/contao/core-bundle/stargazers","contributors_url":"https://api.github.com/repos/contao/core-bundle/contributors","subscribers_url":"https://api.github.com/repos/contao/core-bundle/subscribers","subscription_url":"https://api.github.com/repos/contao/core-bundle/subscription","commits_url":"https://api.github.com/repos/contao/core-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/contao/core-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/contao/core-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/contao/core-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/contao/core-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/contao/core-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/contao/core-bundle/merges","archive_url":"https://api.github.com/repos/contao/core-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/contao/core-bundle/downloads","issues_url":"https://api.github.com/repos/contao/core-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/contao/core-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/contao/core-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/contao/core-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/contao/core-bundle/labels{/name}","releases_url":"https://api.github.com/repos/contao/core-bundle/releases{/id}","created_at":"2014-06-05T09:45:55Z","updated_at":"2015-05-04T18:19:09Z","pushed_at":"2015-05-05T05:42:23Z","git_url":"git://github.com/contao/core-bundle.git","ssh_url":"git@github.com:contao/core-bundle.git","clone_url":"https://github.com/contao/core-bundle.git","svn_url":"https://github.com/contao/core-bundle","homepage":"","size":28469,"stargazers_count":7,"watchers_count":7,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":24,"forks":10,"open_issues":24,"watchers":7,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/contao/core-bundle/pulls/234"},"html":{"href":"https://github.com/contao/core-bundle/pull/234"},"issue":{"href":"https://api.github.com/repos/contao/core-bundle/issues/234"},"comments":{"href":"https://api.github.com/repos/contao/core-bundle/issues/234/comments"},"review_comments":{"href":"https://api.github.com/repos/contao/core-bundle/pulls/234/comments"},"review_comment":{"href":"https://api.github.com/repos/contao/core-bundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/contao/core-bundle/pulls/234/commits"},"statuses":{"href":"https://api.github.com/repos/contao/core-bundle/statuses/adb6aa8666aa983d1429afe7525e8f32ac1999e1"}}}}