{"action":"created","comment":{"url":"https://api.github.com/repos/ska-sa/corr2/pulls/comments/34036428","id":34036428,"diff_hunk":"@@ -34,18 +36,16 @@ def feng_initialise(corr):\n \n     # set up the cores\n     feng_port = int(corr.configd['fengine']['10gbe_port'])\n-    macprefix = corr.configd['fengine']['10gbe_macprefix']\n-    macbase = int(corr.configd['fengine']['10gbe_macbase'])\n+    start_mac = int(Mac(corr.configd['fengine']['10gbe_start_mac']))\n     # Set up shared board info\n     boards_info = {}\n     board_id = 0\n     for f in corr.fhosts:\n         macs = []\n-        ips = []\n+        # ips = [] #  not used","path":"src/fxcorrelator_fengops.py","position":22,"original_position":22,"commit_id":"4961221b60cc7f14aa78d4b5b431cde377951b00","original_commit_id":"4961221b60cc7f14aa78d4b5b431cde377951b00","user":{"login":"brickZA","id":630432,"avatar_url":"https://avatars.githubusercontent.com/u/630432?v=3","gravatar_id":"","url":"https://api.github.com/users/brickZA","html_url":"https://github.com/brickZA","followers_url":"https://api.github.com/users/brickZA/followers","following_url":"https://api.github.com/users/brickZA/following{/other_user}","gists_url":"https://api.github.com/users/brickZA/gists{/gist_id}","starred_url":"https://api.github.com/users/brickZA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brickZA/subscriptions","organizations_url":"https://api.github.com/users/brickZA/orgs","repos_url":"https://api.github.com/users/brickZA/repos","events_url":"https://api.github.com/users/brickZA/events{/privacy}","received_events_url":"https://api.github.com/users/brickZA/received_events","type":"User","site_admin":false},"body":"Just remove it then, no need to keep the comment around","created_at":"2015-07-07T13:04:30Z","updated_at":"2015-07-07T13:04:30Z","html_url":"https://github.com/ska-sa/corr2/pull/40#discussion_r34036428","pull_request_url":"https://api.github.com/repos/ska-sa/corr2/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/ska-sa/corr2/pulls/comments/34036428"},"html":{"href":"https://github.com/ska-sa/corr2/pull/40#discussion_r34036428"},"pull_request":{"href":"https://api.github.com/repos/ska-sa/corr2/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/ska-sa/corr2/pulls/40","id":39366915,"html_url":"https://github.com/ska-sa/corr2/pull/40","diff_url":"https://github.com/ska-sa/corr2/pull/40.diff","patch_url":"https://github.com/ska-sa/corr2/pull/40.patch","issue_url":"https://api.github.com/repos/ska-sa/corr2/issues/40","number":40,"state":"open","locked":false,"title":"Changed  string prefixes used for mac and ip addresses to integers","user":{"login":"pinsleepe","id":2271659,"avatar_url":"https://avatars.githubusercontent.com/u/2271659?v=3","gravatar_id":"","url":"https://api.github.com/users/pinsleepe","html_url":"https://github.com/pinsleepe","followers_url":"https://api.github.com/users/pinsleepe/followers","following_url":"https://api.github.com/users/pinsleepe/following{/other_user}","gists_url":"https://api.github.com/users/pinsleepe/gists{/gist_id}","starred_url":"https://api.github.com/users/pinsleepe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinsleepe/subscriptions","organizations_url":"https://api.github.com/users/pinsleepe/orgs","repos_url":"https://api.github.com/users/pinsleepe/repos","events_url":"https://api.github.com/users/pinsleepe/events{/privacy}","received_events_url":"https://api.github.com/users/pinsleepe/received_events","type":"User","site_admin":false},"body":"@paulprozesky \r\n@brickZA ","created_at":"2015-07-07T12:58:28Z","updated_at":"2015-07-07T13:04:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ska-sa/corr2/pulls/40/commits","review_comments_url":"https://api.github.com/repos/ska-sa/corr2/pulls/40/comments","review_comment_url":"https://api.github.com/repos/ska-sa/corr2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ska-sa/corr2/issues/40/comments","statuses_url":"https://api.github.com/repos/ska-sa/corr2/statuses/4961221b60cc7f14aa78d4b5b431cde377951b00","head":{"label":"ska-sa:ip_mac_ints","ref":"ip_mac_ints","sha":"4961221b60cc7f14aa78d4b5b431cde377951b00","user":{"login":"ska-sa","id":1210238,"avatar_url":"https://avatars.githubusercontent.com/u/1210238?v=3","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"repo":{"id":16940616,"name":"corr2","full_name":"ska-sa/corr2","owner":{"login":"ska-sa","id":1210238,"avatar_url":"https://avatars.githubusercontent.com/u/1210238?v=3","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ska-sa/corr2","description":"","fork":false,"url":"https://api.github.com/repos/ska-sa/corr2","forks_url":"https://api.github.com/repos/ska-sa/corr2/forks","keys_url":"https://api.github.com/repos/ska-sa/corr2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ska-sa/corr2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ska-sa/corr2/teams","hooks_url":"https://api.github.com/repos/ska-sa/corr2/hooks","issue_events_url":"https://api.github.com/repos/ska-sa/corr2/issues/events{/number}","events_url":"https://api.github.com/repos/ska-sa/corr2/events","assignees_url":"https://api.github.com/repos/ska-sa/corr2/assignees{/user}","branches_url":"https://api.github.com/repos/ska-sa/corr2/branches{/branch}","tags_url":"https://api.github.com/repos/ska-sa/corr2/tags","blobs_url":"https://api.github.com/repos/ska-sa/corr2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ska-sa/corr2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ska-sa/corr2/git/refs{/sha}","trees_url":"https://api.github.com/repos/ska-sa/corr2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ska-sa/corr2/statuses/{sha}","languages_url":"https://api.github.com/repos/ska-sa/corr2/languages","stargazers_url":"https://api.github.com/repos/ska-sa/corr2/stargazers","contributors_url":"https://api.github.com/repos/ska-sa/corr2/contributors","subscribers_url":"https://api.github.com/repos/ska-sa/corr2/subscribers","subscription_url":"https://api.github.com/repos/ska-sa/corr2/subscription","commits_url":"https://api.github.com/repos/ska-sa/corr2/commits{/sha}","git_commits_url":"https://api.github.com/repos/ska-sa/corr2/git/commits{/sha}","comments_url":"https://api.github.com/repos/ska-sa/corr2/comments{/number}","issue_comment_url":"https://api.github.com/repos/ska-sa/corr2/issues/comments{/number}","contents_url":"https://api.github.com/repos/ska-sa/corr2/contents/{+path}","compare_url":"https://api.github.com/repos/ska-sa/corr2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ska-sa/corr2/merges","archive_url":"https://api.github.com/repos/ska-sa/corr2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ska-sa/corr2/downloads","issues_url":"https://api.github.com/repos/ska-sa/corr2/issues{/number}","pulls_url":"https://api.github.com/repos/ska-sa/corr2/pulls{/number}","milestones_url":"https://api.github.com/repos/ska-sa/corr2/milestones{/number}","notifications_url":"https://api.github.com/repos/ska-sa/corr2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ska-sa/corr2/labels{/name}","releases_url":"https://api.github.com/repos/ska-sa/corr2/releases{/id}","created_at":"2014-02-18T07:30:28Z","updated_at":"2015-07-07T12:29:07Z","pushed_at":"2015-07-07T12:58:29Z","git_url":"git://github.com/ska-sa/corr2.git","ssh_url":"git@github.com:ska-sa/corr2.git","clone_url":"https://github.com/ska-sa/corr2.git","svn_url":"https://github.com/ska-sa/corr2","homepage":null,"size":2089,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"ska-sa:devel","ref":"devel","sha":"4c5c0a4698a42941bb09c3f19f30771bd853ccaf","user":{"login":"ska-sa","id":1210238,"avatar_url":"https://avatars.githubusercontent.com/u/1210238?v=3","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"repo":{"id":16940616,"name":"corr2","full_name":"ska-sa/corr2","owner":{"login":"ska-sa","id":1210238,"avatar_url":"https://avatars.githubusercontent.com/u/1210238?v=3","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ska-sa/corr2","description":"","fork":false,"url":"https://api.github.com/repos/ska-sa/corr2","forks_url":"https://api.github.com/repos/ska-sa/corr2/forks","keys_url":"https://api.github.com/repos/ska-sa/corr2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ska-sa/corr2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ska-sa/corr2/teams","hooks_url":"https://api.github.com/repos/ska-sa/corr2/hooks","issue_events_url":"https://api.github.com/repos/ska-sa/corr2/issues/events{/number}","events_url":"https://api.github.com/repos/ska-sa/corr2/events","assignees_url":"https://api.github.com/repos/ska-sa/corr2/assignees{/user}","branches_url":"https://api.github.com/repos/ska-sa/corr2/branches{/branch}","tags_url":"https://api.github.com/repos/ska-sa/corr2/tags","blobs_url":"https://api.github.com/repos/ska-sa/corr2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ska-sa/corr2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ska-sa/corr2/git/refs{/sha}","trees_url":"https://api.github.com/repos/ska-sa/corr2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ska-sa/corr2/statuses/{sha}","languages_url":"https://api.github.com/repos/ska-sa/corr2/languages","stargazers_url":"https://api.github.com/repos/ska-sa/corr2/stargazers","contributors_url":"https://api.github.com/repos/ska-sa/corr2/contributors","subscribers_url":"https://api.github.com/repos/ska-sa/corr2/subscribers","subscription_url":"https://api.github.com/repos/ska-sa/corr2/subscription","commits_url":"https://api.github.com/repos/ska-sa/corr2/commits{/sha}","git_commits_url":"https://api.github.com/repos/ska-sa/corr2/git/commits{/sha}","comments_url":"https://api.github.com/repos/ska-sa/corr2/comments{/number}","issue_comment_url":"https://api.github.com/repos/ska-sa/corr2/issues/comments{/number}","contents_url":"https://api.github.com/repos/ska-sa/corr2/contents/{+path}","compare_url":"https://api.github.com/repos/ska-sa/corr2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ska-sa/corr2/merges","archive_url":"https://api.github.com/repos/ska-sa/corr2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ska-sa/corr2/downloads","issues_url":"https://api.github.com/repos/ska-sa/corr2/issues{/number}","pulls_url":"https://api.github.com/repos/ska-sa/corr2/pulls{/number}","milestones_url":"https://api.github.com/repos/ska-sa/corr2/milestones{/number}","notifications_url":"https://api.github.com/repos/ska-sa/corr2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ska-sa/corr2/labels{/name}","releases_url":"https://api.github.com/repos/ska-sa/corr2/releases{/id}","created_at":"2014-02-18T07:30:28Z","updated_at":"2015-07-07T12:29:07Z","pushed_at":"2015-07-07T12:58:29Z","git_url":"git://github.com/ska-sa/corr2.git","ssh_url":"git@github.com:ska-sa/corr2.git","clone_url":"https://github.com/ska-sa/corr2.git","svn_url":"https://github.com/ska-sa/corr2","homepage":null,"size":2089,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ska-sa/corr2/pulls/40"},"html":{"href":"https://github.com/ska-sa/corr2/pull/40"},"issue":{"href":"https://api.github.com/repos/ska-sa/corr2/issues/40"},"comments":{"href":"https://api.github.com/repos/ska-sa/corr2/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/ska-sa/corr2/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/ska-sa/corr2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ska-sa/corr2/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/ska-sa/corr2/statuses/4961221b60cc7f14aa78d4b5b431cde377951b00"}}}}