{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/30504201","id":30504201,"diff_hunk":"@@ -0,0 +1,166 @@\n+(function (undefined) {\n+    'use strict';\n+    describe('VideoPlayer Events plugin', function () {\n+        var state, oldOTBD;\n+\n+        beforeEach(function () {\n+            oldOTBD = window.onTouchBasedDevice;\n+            window.onTouchBasedDevice = jasmine\n+                .createSpy('onTouchBasedDevice')\n+                .andReturn(null);\n+\n+            jasmine.stubRequests();\n+            state = jasmine.initializePlayer();\n+            spyOn(Logger, 'log');\n+            spyOn(state.videoEventsPlugin, 'getCurrentTime').andReturn(10);\n+        });\n+\n+        afterEach(function () {\n+            $('source').remove();\n+            window.onTouchBasedDevice = oldOTBD;\n+            state.storage.clear();\n+            if (state.videoPlayer) {\n+                state.videoPlayer.destroy();\n+            }\n+        });\n+\n+        it('can emit \"load_video\" event', function () {\n+            state.el.trigger('ready');\n+            expect(Logger.log).toHaveBeenCalledWith('load_video', {\n+                id: 'id',\n+                code: 'html5'\n+            });\n+        });\n+\n+        it('can emit \"play_video\" event', function () {\n+            state.el.trigger('play');\n+            expect(Logger.log).toHaveBeenCalledWith('play_video', {\n+                id: 'id',\n+                code: 'html5',\n+                currentTime: 10\n+            });\n+        });\n+\n+        it('can emit \"pause_video\" event', function () {\n+            state.el.trigger('pause');\n+            expect(Logger.log).toHaveBeenCalledWith('pause_video', {\n+                id: 'id',\n+                code: 'html5',\n+                currentTime: 10\n+            });\n+        });\n+\n+        it('can emit \"speed_change_video\" event', function () {\n+            state.el.trigger('speedchange', ['2.0', '1.0']);\n+            expect(Logger.log).toHaveBeenCalledWith('speed_change_video', {\n+                id: 'id',\n+                code: 'html5',\n+                current_time: 10,\n+                old_speed: '1.0',\n+                new_speed: '2.0'\n+            });\n+        });\n+\n+        it('can emit \"seek_video\" event', function () {\n+            state.el.trigger('seek', [1, 0, 'any']);\n+            expect(Logger.log).toHaveBeenCalledWith('seek_video', {\n+                id: 'id',\n+                code: 'html5',\n+                old_time: 0,\n+                new_time: 1,\n+                type: 'any'\n+            });\n+        });\n+\n+        it('can emit \"stop_video\" event', function () {\n+            state.el.trigger('ended');\n+            expect(Logger.log).toHaveBeenCalledWith('stop_video', {\n+                id: 'id',\n+                code: 'html5',\n+                currentTime: 10\n+            });\n+\n+            Logger.log.reset();\n+            state.el.trigger('stop');\n+            expect(Logger.log).toHaveBeenCalledWith('stop_video', {\n+                id: 'id',\n+                code: 'html5',\n+                currentTime: 10\n+            });\n+        });\n+\n+        it('can emit \"skip_video\" event', function () {\n+            state.el.trigger('skip', [false]);\n+            expect(Logger.log).toHaveBeenCalledWith('skip_video', {\n+                id: 'id',\n+                code: 'html5',\n+                currentTime: 10\n+            });","path":"common/lib/xmodule/xmodule/js/spec/video/video_events_plugin_spec.js","position":98,"original_position":98,"commit_id":"c76b4b1d9a8f0ef3e028f34aa8aa642b4501b6d8","original_commit_id":"4e998d5862fa66865f99ca11d983105ab20cd304","user":{"login":"lamagnifica","id":6392274,"avatar_url":"https://avatars.githubusercontent.com/u/6392274?v=3","gravatar_id":"","url":"https://api.github.com/users/lamagnifica","html_url":"https://github.com/lamagnifica","followers_url":"https://api.github.com/users/lamagnifica/followers","following_url":"https://api.github.com/users/lamagnifica/following{/other_user}","gists_url":"https://api.github.com/users/lamagnifica/gists{/gist_id}","starred_url":"https://api.github.com/users/lamagnifica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamagnifica/subscriptions","organizations_url":"https://api.github.com/users/lamagnifica/orgs","repos_url":"https://api.github.com/users/lamagnifica/repos","events_url":"https://api.github.com/users/lamagnifica/events{/privacy}","received_events_url":"https://api.github.com/users/lamagnifica/received_events","type":"User","site_admin":false},"body":"I notice that the ``name`` field is not present. FYI @mulby \r\n","created_at":"2015-05-18T12:55:28Z","updated_at":"2015-05-18T12:55:28Z","html_url":"https://github.com/edx/edx-platform/pull/7825#discussion_r30504201","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/7825","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/30504201"},"html":{"href":"https://github.com/edx/edx-platform/pull/7825#discussion_r30504201"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/7825"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/7825","id":34253983,"html_url":"https://github.com/edx/edx-platform/pull/7825","diff_url":"https://github.com/edx/edx-platform/pull/7825.diff","patch_url":"https://github.com/edx/edx-platform/pull/7825.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/7825","number":7825,"state":"open","locked":false,"title":"Alex/video bumper","user":{"login":"auraz","id":67241,"avatar_url":"https://avatars.githubusercontent.com/u/67241?v=3","gravatar_id":"","url":"https://api.github.com/users/auraz","html_url":"https://github.com/auraz","followers_url":"https://api.github.com/users/auraz/followers","following_url":"https://api.github.com/users/auraz/following{/other_user}","gists_url":"https://api.github.com/users/auraz/gists{/gist_id}","starred_url":"https://api.github.com/users/auraz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auraz/subscriptions","organizations_url":"https://api.github.com/users/auraz/orgs","repos_url":"https://api.github.com/users/auraz/repos","events_url":"https://api.github.com/users/auraz/events{/privacy}","received_events_url":"https://api.github.com/users/auraz/received_events","type":"User","site_admin":false},"body":"Add video bumper functionality to video player.\r\n\r\nTo enable, set ENABLE_VIDEO_BUMPER flag to True in settings, and add to course Advanced Settings following dict:\r\n```\r\n{\r\n\"transcripts\": {\r\n\"en\": \"b7xgknqkQk8.srt\"\r\n},\r\n\"video_id\": \"edx_video_id_that_you_have_for_html5_mp4_or_webm_video\"\r\n}\r\n```\r\n\r\nVideo bumper is deployed to sandbox: http://auraz.m.sandbox.edx.org/courses/edX/DemoX/Demo_Course/, bumper section\r\n\r\nTo reviewers:\r\nhttps://docs.google.com/document/d/1rfBSRAghZMvVx7PRcfoolCzFVhQp_DkVfDv2RwBLa9Y/edit\r\nhttps://docs.google.com/document/d/1InHXOZRVRfgIsg5GSwIlOespO_dDdO0WijvVorjo28o/edit?disco=AAAAANmJMZ8\r\n\r\nCoverage: 82%\r\n\r\n\r\n\r\n\r\n","created_at":"2015-04-28T10:45:14Z","updated_at":"2015-05-18T12:55:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9cc4700099b47b4789c3df0c22ac7c7470036e0e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/7825/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/7825/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/7825/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/c76b4b1d9a8f0ef3e028f34aa8aa642b4501b6d8","head":{"label":"edx:alex/video_bumper","ref":"alex/video_bumper","sha":"c76b4b1d9a8f0ef3e028f34aa8aa642b4501b6d8","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"Open edX, the edX platform that powers http://edx.org","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2015-05-17T23:57:27Z","pushed_at":"2015-05-18T12:22:52Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://openedx.org/","size":1936499,"stargazers_count":1926,"watchers_count":1926,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1099,"mirror_url":null,"open_issues_count":164,"forks":1099,"open_issues":164,"watchers":1926,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"269432ae3408cc51d4a82a519737fd0a343d6e39","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"Open edX, the edX platform that powers http://edx.org","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2015-05-17T23:57:27Z","pushed_at":"2015-05-18T12:22:52Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://openedx.org/","size":1936499,"stargazers_count":1926,"watchers_count":1926,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1099,"mirror_url":null,"open_issues_count":164,"forks":1099,"open_issues":164,"watchers":1926,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/7825"},"html":{"href":"https://github.com/edx/edx-platform/pull/7825"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/7825"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/7825/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/7825/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/7825/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/c76b4b1d9a8f0ef3e028f34aa8aa642b4501b6d8"}}}}