{"action":"closed","number":12403,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/12403","id":41912373,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/12403","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/12403.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/12403.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/12403","number":12403,"state":"closed","locked":false,"title":"consolidate cloudproviders into a single import","user":{"login":"stensonb","id":933389,"avatar_url":"https://avatars.githubusercontent.com/u/933389?v=3","gravatar_id":"","url":"https://api.github.com/users/stensonb","html_url":"https://github.com/stensonb","followers_url":"https://api.github.com/users/stensonb/followers","following_url":"https://api.github.com/users/stensonb/following{/other_user}","gists_url":"https://api.github.com/users/stensonb/gists{/gist_id}","starred_url":"https://api.github.com/users/stensonb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stensonb/subscriptions","organizations_url":"https://api.github.com/users/stensonb/orgs","repos_url":"https://api.github.com/users/stensonb/repos","events_url":"https://api.github.com/users/stensonb/events{/privacy}","received_events_url":"https://api.github.com/users/stensonb/received_events","type":"User","site_admin":false},"body":"While attempting to develop a new cloud provider plugin, I noticed each command (kube-apiserver, kubelet, kube-controller-manager) has all the plugins listed in their respective imports...\r\n\r\nIt seems like a mess to have to update three places for all/any new cloud provider...so, I've created a \"providers\" package, which contains ALL the plugins...and now each command (listed above), simply references the \"providers\" package.\r\n\r\n(this is the fixed version of this PR: https://github.com/GoogleCloudPlatform/kubernetes/pull/12368)","created_at":"2015-08-07T17:02:23Z","updated_at":"2015-08-12T05:30:06Z","closed_at":"2015-08-12T05:30:06Z","merged_at":null,"merge_commit_sha":"ee1525385210a33b696f2bd0d3846376d163f6d5","assignee":{"login":"erictune","id":8105590,"avatar_url":"https://avatars.githubusercontent.com/u/8105590?v=3","gravatar_id":"","url":"https://api.github.com/users/erictune","html_url":"https://github.com/erictune","followers_url":"https://api.github.com/users/erictune/followers","following_url":"https://api.github.com/users/erictune/following{/other_user}","gists_url":"https://api.github.com/users/erictune/gists{/gist_id}","starred_url":"https://api.github.com/users/erictune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erictune/subscriptions","organizations_url":"https://api.github.com/users/erictune/orgs","repos_url":"https://api.github.com/users/erictune/repos","events_url":"https://api.github.com/users/erictune/events{/privacy}","received_events_url":"https://api.github.com/users/erictune/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/12403/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/12403/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/12403/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/5a9b36b703a4ef0d8226e4c5aced771029ba4567","head":{"label":"stensonb:consolidate-cloudprovider-imports","ref":"consolidate-cloudprovider-imports","sha":"5a9b36b703a4ef0d8226e4c5aced771029ba4567","user":{"login":"stensonb","id":933389,"avatar_url":"https://avatars.githubusercontent.com/u/933389?v=3","gravatar_id":"","url":"https://api.github.com/users/stensonb","html_url":"https://github.com/stensonb","followers_url":"https://api.github.com/users/stensonb/followers","following_url":"https://api.github.com/users/stensonb/following{/other_user}","gists_url":"https://api.github.com/users/stensonb/gists{/gist_id}","starred_url":"https://api.github.com/users/stensonb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stensonb/subscriptions","organizations_url":"https://api.github.com/users/stensonb/orgs","repos_url":"https://api.github.com/users/stensonb/repos","events_url":"https://api.github.com/users/stensonb/events{/privacy}","received_events_url":"https://api.github.com/users/stensonb/received_events","type":"User","site_admin":false},"repo":{"id":39803330,"name":"kubernetes","full_name":"stensonb/kubernetes","owner":{"login":"stensonb","id":933389,"avatar_url":"https://avatars.githubusercontent.com/u/933389?v=3","gravatar_id":"","url":"https://api.github.com/users/stensonb","html_url":"https://github.com/stensonb","followers_url":"https://api.github.com/users/stensonb/followers","following_url":"https://api.github.com/users/stensonb/following{/other_user}","gists_url":"https://api.github.com/users/stensonb/gists{/gist_id}","starred_url":"https://api.github.com/users/stensonb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stensonb/subscriptions","organizations_url":"https://api.github.com/users/stensonb/orgs","repos_url":"https://api.github.com/users/stensonb/repos","events_url":"https://api.github.com/users/stensonb/events{/privacy}","received_events_url":"https://api.github.com/users/stensonb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stensonb/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/stensonb/kubernetes","forks_url":"https://api.github.com/repos/stensonb/kubernetes/forks","keys_url":"https://api.github.com/repos/stensonb/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stensonb/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stensonb/kubernetes/teams","hooks_url":"https://api.github.com/repos/stensonb/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/stensonb/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/stensonb/kubernetes/events","assignees_url":"https://api.github.com/repos/stensonb/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/stensonb/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/stensonb/kubernetes/tags","blobs_url":"https://api.github.com/repos/stensonb/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stensonb/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stensonb/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/stensonb/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stensonb/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/stensonb/kubernetes/languages","stargazers_url":"https://api.github.com/repos/stensonb/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/stensonb/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/stensonb/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/stensonb/kubernetes/subscription","commits_url":"https://api.github.com/repos/stensonb/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/stensonb/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/stensonb/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/stensonb/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/stensonb/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/stensonb/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stensonb/kubernetes/merges","archive_url":"https://api.github.com/repos/stensonb/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stensonb/kubernetes/downloads","issues_url":"https://api.github.com/repos/stensonb/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/stensonb/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/stensonb/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/stensonb/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stensonb/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/stensonb/kubernetes/releases{/id}","created_at":"2015-07-27T23:43:17Z","updated_at":"2015-07-27T23:43:24Z","pushed_at":"2015-08-12T05:30:05Z","git_url":"git://github.com/stensonb/kubernetes.git","ssh_url":"git@github.com:stensonb/kubernetes.git","clone_url":"https://github.com/stensonb/kubernetes.git","svn_url":"https://github.com/stensonb/kubernetes","homepage":"http://kubernetes.io","size":100232,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"5a9b36b703a4ef0d8226e4c5aced771029ba4567","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-08-12T05:23:17Z","pushed_at":"2015-08-12T05:30:07Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":349300,"stargazers_count":9645,"watchers_count":9645,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2307,"mirror_url":null,"open_issues_count":1732,"forks":2307,"open_issues":1732,"watchers":9645,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/12403"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/12403"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/12403"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/12403/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/12403/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/12403/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/5a9b36b703a4ef0d8226e4c5aced771029ba4567"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":9,"review_comments":0,"commits":0,"additions":0,"deletions":0,"changed_files":0}}