{"action":"created","issue":{"url":"https://api.github.com/repos/pcbsd/lumina/issues/56","labels_url":"https://api.github.com/repos/pcbsd/lumina/issues/56/labels{/name}","comments_url":"https://api.github.com/repos/pcbsd/lumina/issues/56/comments","events_url":"https://api.github.com/repos/pcbsd/lumina/issues/56/events","html_url":"https://github.com/pcbsd/lumina/issues/56","id":58505894,"number":56,"title":"new feature: would it be possible do select/change the icons on the desktopview plugin","user":{"login":"william-os4y","id":31986,"avatar_url":"https://avatars.githubusercontent.com/u/31986?v=3","gravatar_id":"","url":"https://api.github.com/users/william-os4y","html_url":"https://github.com/william-os4y","followers_url":"https://api.github.com/users/william-os4y/followers","following_url":"https://api.github.com/users/william-os4y/following{/other_user}","gists_url":"https://api.github.com/users/william-os4y/gists{/gist_id}","starred_url":"https://api.github.com/users/william-os4y/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/william-os4y/subscriptions","organizations_url":"https://api.github.com/users/william-os4y/orgs","repos_url":"https://api.github.com/users/william-os4y/repos","events_url":"https://api.github.com/users/william-os4y/events{/privacy}","received_events_url":"https://api.github.com/users/william-os4y/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":22,"created_at":"2015-02-22T15:20:03Z","updated_at":"2015-04-14T16:38:37Z","closed_at":"2015-02-23T15:56:59Z","body":"In fact, I'm using often couple of shell scripts . So I've placed them in ~/Desktop and I double click on them when needed. \r\nTo better identify them, I would have the possibility to assing different icon to each of them. \r\nDoes this is a feature I've missed somewhere ?\r\n\r\nThanks\r\n"},"comment":{"url":"https://api.github.com/repos/pcbsd/lumina/issues/comments/92966186","html_url":"https://github.com/pcbsd/lumina/issues/56#issuecomment-92966186","issue_url":"https://api.github.com/repos/pcbsd/lumina/issues/56","id":92966186,"user":{"login":"beanpole135","id":4172864,"avatar_url":"https://avatars.githubusercontent.com/u/4172864?v=3","gravatar_id":"","url":"https://api.github.com/users/beanpole135","html_url":"https://github.com/beanpole135","followers_url":"https://api.github.com/users/beanpole135/followers","following_url":"https://api.github.com/users/beanpole135/following{/other_user}","gists_url":"https://api.github.com/users/beanpole135/gists{/gist_id}","starred_url":"https://api.github.com/users/beanpole135/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beanpole135/subscriptions","organizations_url":"https://api.github.com/users/beanpole135/orgs","repos_url":"https://api.github.com/users/beanpole135/repos","events_url":"https://api.github.com/users/beanpole135/events{/privacy}","received_events_url":"https://api.github.com/users/beanpole135/received_events","type":"User","site_admin":false},"created_at":"2015-04-14T16:38:37Z","updated_at":"2015-04-14T16:38:37Z","body":"Ok, I was actually able to make some time sooner than I thought, and I only have a couple recommendations. These are both minor and you could send in a pull request to include it in the main Lumina repo whenever you feel ready.\r\n\r\n1) dialog.cpp -> line 121\r\nInstead of QPixmap(DF.icon), use LXDG::findIcon(DF.icon,\"\") since the icon listed does *not* necessary have a full/relative path included in the file. The LXDE routine should parse it out and handle all those other cases - finding the icon on the system if possible.\r\n\r\n2) dialog.cpp ->lines 140 and 142\r\nThe \"~\" abbreviation is a shell shortcut for the user's home dir and does not work in C++/Qt. You should use QDir::homePath() instead.\r\n\r\nOverall, it is looking really good! Thanks for working on it!"}}