{"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/37550979","id":37550979,"diff_hunk":"@@ -341,17 +341,14 @@ class CSharedSpillableRowSet : public CSpillableStreamBase, implements IInterfac\n     }\n     IRowStream *createRowStream()\n     {\n+        CRowsLockBlock block(*this);","path":"thorlcr/thorutil/thmem.cpp","position":19,"original_position":19,"commit_id":"ec387356f91714e6516fd2a1125ad156304497f5","original_commit_id":"ec387356f91714e6516fd2a1125ad156304497f5","user":{"login":"jakesmith","id":902700,"avatar_url":"https://avatars.githubusercontent.com/u/902700?v=3","gravatar_id":"","url":"https://api.github.com/users/jakesmith","html_url":"https://github.com/jakesmith","followers_url":"https://api.github.com/users/jakesmith/followers","following_url":"https://api.github.com/users/jakesmith/following{/other_user}","gists_url":"https://api.github.com/users/jakesmith/gists{/gist_id}","starred_url":"https://api.github.com/users/jakesmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakesmith/subscriptions","organizations_url":"https://api.github.com/users/jakesmith/orgs","repos_url":"https://api.github.com/users/jakesmith/repos","events_url":"https://api.github.com/users/jakesmith/events{/privacy}","received_events_url":"https://api.github.com/users/jakesmith/received_events","type":"User","site_admin":false},"body":"@richardkchapman - this is the significant change/fix.\r\nIt is moving the row lock into method scope, out from the block that it used to be in.\r\nThereby it ensures that it is blocked or locked at the time CStream is constructed (and registerWriteCallback is called)","created_at":"2015-08-20T16:30:58Z","updated_at":"2015-08-20T16:30:58Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7709#discussion_r37550979","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7709","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/37550979"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/7709#discussion_r37550979"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7709"}}},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7709","id":42949548,"html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7709","diff_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7709.diff","patch_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7709.patch","issue_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7709","number":7709,"state":"open","locked":false,"title":"HPCC-10495 Fix race condition on shaed spilling stream.","user":{"login":"jakesmith","id":902700,"avatar_url":"https://avatars.githubusercontent.com/u/902700?v=3","gravatar_id":"","url":"https://api.github.com/users/jakesmith","html_url":"https://github.com/jakesmith","followers_url":"https://api.github.com/users/jakesmith/followers","following_url":"https://api.github.com/users/jakesmith/following{/other_user}","gists_url":"https://api.github.com/users/jakesmith/gists{/gist_id}","starred_url":"https://api.github.com/users/jakesmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakesmith/subscriptions","organizations_url":"https://api.github.com/users/jakesmith/orgs","repos_url":"https://api.github.com/users/jakesmith/repos","events_url":"https://api.github.com/users/jakesmith/events{/privacy}","received_events_url":"https://api.github.com/users/jakesmith/received_events","type":"User","site_admin":false},"body":"There was a small window, where a shared stream is requested\r\nand it has yet not spilled, if during the creation of the stream\r\nit spills, the stream will not have registered its callback and\r\nwill not have been told it's relative position in the spill file.\r\nThen when the stream is read an assertion is hit.\r\n\r\nSigned-off-by: Jake Smith <jake.smith@lexisnexis.com>","created_at":"2015-08-20T16:26:14Z","updated_at":"2015-08-20T16:30:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"564626d23dcb9ad56498f6323c6071ef72c3c59f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7709/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7709/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7709/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/ec387356f91714e6516fd2a1125ad156304497f5","head":{"label":"jakesmith:hpcc-14095","ref":"hpcc-14095","sha":"ec387356f91714e6516fd2a1125ad156304497f5","user":{"login":"jakesmith","id":902700,"avatar_url":"https://avatars.githubusercontent.com/u/902700?v=3","gravatar_id":"","url":"https://api.github.com/users/jakesmith","html_url":"https://github.com/jakesmith","followers_url":"https://api.github.com/users/jakesmith/followers","following_url":"https://api.github.com/users/jakesmith/following{/other_user}","gists_url":"https://api.github.com/users/jakesmith/gists{/gist_id}","starred_url":"https://api.github.com/users/jakesmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakesmith/subscriptions","organizations_url":"https://api.github.com/users/jakesmith/orgs","repos_url":"https://api.github.com/users/jakesmith/repos","events_url":"https://api.github.com/users/jakesmith/events{/privacy}","received_events_url":"https://api.github.com/users/jakesmith/received_events","type":"User","site_admin":false},"repo":{"id":2041370,"name":"HPCC-Platform","full_name":"jakesmith/HPCC-Platform","owner":{"login":"jakesmith","id":902700,"avatar_url":"https://avatars.githubusercontent.com/u/902700?v=3","gravatar_id":"","url":"https://api.github.com/users/jakesmith","html_url":"https://github.com/jakesmith","followers_url":"https://api.github.com/users/jakesmith/followers","following_url":"https://api.github.com/users/jakesmith/following{/other_user}","gists_url":"https://api.github.com/users/jakesmith/gists{/gist_id}","starred_url":"https://api.github.com/users/jakesmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakesmith/subscriptions","organizations_url":"https://api.github.com/users/jakesmith/orgs","repos_url":"https://api.github.com/users/jakesmith/repos","events_url":"https://api.github.com/users/jakesmith/events{/privacy}","received_events_url":"https://api.github.com/users/jakesmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jakesmith/HPCC-Platform","description":"HPCC Systems big data solution, community edition","fork":true,"url":"https://api.github.com/repos/jakesmith/HPCC-Platform","forks_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/jakesmith/HPCC-Platform/releases{/id}","created_at":"2011-07-13T10:47:52Z","updated_at":"2014-09-16T18:05:11Z","pushed_at":"2015-08-20T16:24:12Z","git_url":"git://github.com/jakesmith/HPCC-Platform.git","ssh_url":"git@github.com:jakesmith/HPCC-Platform.git","clone_url":"https://github.com/jakesmith/HPCC-Platform.git","svn_url":"https://github.com/jakesmith/HPCC-Platform","homepage":"www.hpccsystems.com","size":158091,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":1,"default_branch":"master"}},"base":{"label":"hpcc-systems:candidate-5.2.8","ref":"candidate-5.2.8","sha":"fd0be2442b9252dc9969c75041fc4356b3124410","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":2030681,"name":"HPCC-Platform","full_name":"hpcc-systems/HPCC-Platform","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/HPCC-Platform","description":"IMPORTANT - Issue tracking has been migrated to JIRA - use your github ID and password reset mechanism to log in","fork":false,"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform","forks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/releases{/id}","created_at":"2011-07-11T14:29:51Z","updated_at":"2015-08-18T14:32:08Z","pushed_at":"2015-08-20T16:26:15Z","git_url":"git://github.com/hpcc-systems/HPCC-Platform.git","ssh_url":"git@github.com:hpcc-systems/HPCC-Platform.git","clone_url":"https://github.com/hpcc-systems/HPCC-Platform.git","svn_url":"https://github.com/hpcc-systems/HPCC-Platform","homepage":"track.hpccsystems.com","size":341389,"stargazers_count":253,"watchers_count":253,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":119,"mirror_url":null,"open_issues_count":422,"forks":119,"open_issues":422,"watchers":253,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7709"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/7709"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7709"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7709/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7709/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7709/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/ec387356f91714e6516fd2a1125ad156304497f5"}}}}