{"action":"created","issue":{"url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/2253","labels_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/2253/labels{/name}","comments_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/2253/comments","events_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/2253/events","html_url":"https://github.com/concrete5/concrete5-5.7.0/pull/2253","id":68612194,"number":2253,"title":"Ensure maps blocks have a unique identity","user":{"login":"JohntheFish","id":1260106,"avatar_url":"https://avatars.githubusercontent.com/u/1260106?v=3","gravatar_id":"","url":"https://api.github.com/users/JohntheFish","html_url":"https://github.com/JohntheFish","followers_url":"https://api.github.com/users/JohntheFish/followers","following_url":"https://api.github.com/users/JohntheFish/following{/other_user}","gists_url":"https://api.github.com/users/JohntheFish/gists{/gist_id}","starred_url":"https://api.github.com/users/JohntheFish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohntheFish/subscriptions","organizations_url":"https://api.github.com/users/JohntheFish/orgs","repos_url":"https://api.github.com/users/JohntheFish/repos","events_url":"https://api.github.com/users/JohntheFish/events{/privacy}","received_events_url":"https://api.github.com/users/JohntheFish/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-15T08:25:24Z","updated_at":"2015-04-16T03:32:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/pulls/2253","html_url":"https://github.com/concrete5/concrete5-5.7.0/pull/2253","diff_url":"https://github.com/concrete5/concrete5-5.7.0/pull/2253.diff","patch_url":"https://github.com/concrete5/concrete5-5.7.0/pull/2253.patch"},"body":"I was having issues with maps blocks not having a unique id and hence duplicate blocks failing to render. I started by using proxy block id's, but that continued to give duplicate id's if a map was in a stack pulled more than once.\r\n\r\nThis solution just makes sure the id's really are unique. It could still fail if the view of a stack is cached and used in more than one place on a page.\r\n\r\nA better solution would be a complete refactoring of the way maps blocks create and interact with their JavaScript to avoid dependence on a block ID."},"comment":{"url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/comments/93628890","html_url":"https://github.com/concrete5/concrete5-5.7.0/pull/2253#issuecomment-93628890","issue_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/2253","id":93628890,"user":{"login":"aembler","id":527809,"avatar_url":"https://avatars.githubusercontent.com/u/527809?v=3","gravatar_id":"","url":"https://api.github.com/users/aembler","html_url":"https://github.com/aembler","followers_url":"https://api.github.com/users/aembler/followers","following_url":"https://api.github.com/users/aembler/following{/other_user}","gists_url":"https://api.github.com/users/aembler/gists{/gist_id}","starred_url":"https://api.github.com/users/aembler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aembler/subscriptions","organizations_url":"https://api.github.com/users/aembler/orgs","repos_url":"https://api.github.com/users/aembler/repos","events_url":"https://api.github.com/users/aembler/events{/privacy}","received_events_url":"https://api.github.com/users/aembler/received_events","type":"User","site_admin":false},"created_at":"2015-04-16T03:32:36Z","updated_at":"2015-04-16T03:32:36Z","body":"Hmm for some reason this won't cleanly merge any longer.\r\n\r\nI would think that we ought to just use <?=Core::make('helper/validation/identifier')->getString(18)?> as our identifier. That'll be guaranteed to be unique even if they're used in stacks, etc... The identifier doesn't have to have anything to do with the google map per se. "}}