{"action":"created","comment":{"url":"https://api.github.com/repos/genome/genome/pulls/comments/23688114","id":23688114,"diff_hunk":"@@ -405,6 +406,7 @@ sub vcf_result_params {\n         aligned_reads_sample => $aligned_reads_sample,\n         ($control_aligned_reads_sample? (control_aligned_reads_sample => $control_aligned_reads_sample) : ()),\n \n+        #users => $users, #Needed if get() inside get_vcf_result becomes get_with_lock()","path":"lib/perl/Genome/Model/Tools/DetectVariants2/Result/DetectionBase.pm","position":12,"original_position":12,"commit_id":"09c3faa17a42f8d972b4a292692498671950a44c","original_commit_id":"66baec9a0ed0d0872765bdc62c0bbfde37dedacb","user":{"login":"tmooney","id":187262,"avatar_url":"https://avatars.githubusercontent.com/u/187262?v=3","gravatar_id":"","url":"https://api.github.com/users/tmooney","html_url":"https://github.com/tmooney","followers_url":"https://api.github.com/users/tmooney/followers","following_url":"https://api.github.com/users/tmooney/following{/other_user}","gists_url":"https://api.github.com/users/tmooney/gists{/gist_id}","starred_url":"https://api.github.com/users/tmooney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmooney/subscriptions","organizations_url":"https://api.github.com/users/tmooney/orgs","repos_url":"https://api.github.com/users/tmooney/repos","events_url":"https://api.github.com/users/tmooney/events{/privacy}","received_events_url":"https://api.github.com/users/tmooney/received_events","type":"User","site_admin":false},"body":"If someone tries to change it to `get_with_lock()` tests will break with an error from `Params::Validate`.  I could leave this comment out--it is a bit silly to add commented-out code.","created_at":"2015-01-28T14:02:19Z","updated_at":"2015-01-28T14:02:19Z","html_url":"https://github.com/genome/genome/pull/429#discussion_r23688114","pull_request_url":"https://api.github.com/repos/genome/genome/pulls/429","_links":{"self":{"href":"https://api.github.com/repos/genome/genome/pulls/comments/23688114"},"html":{"href":"https://github.com/genome/genome/pull/429#discussion_r23688114"},"pull_request":{"href":"https://api.github.com/repos/genome/genome/pulls/429"}}},"pull_request":{"url":"https://api.github.com/repos/genome/genome/pulls/429","id":27868099,"html_url":"https://github.com/genome/genome/pull/429","diff_url":"https://github.com/genome/genome/pull/429.diff","patch_url":"https://github.com/genome/genome/pull/429.patch","issue_url":"https://api.github.com/repos/genome/genome/issues/429","number":429,"state":"open","locked":false,"title":"Require a \"Sponsor\" and \"Requestor\" when getting or creating a SoftwareResult","user":{"login":"tmooney","id":187262,"avatar_url":"https://avatars.githubusercontent.com/u/187262?v=3","gravatar_id":"","url":"https://api.github.com/users/tmooney","html_url":"https://github.com/tmooney","followers_url":"https://api.github.com/users/tmooney/followers","following_url":"https://api.github.com/users/tmooney/following{/other_user}","gists_url":"https://api.github.com/users/tmooney/gists{/gist_id}","starred_url":"https://api.github.com/users/tmooney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmooney/subscriptions","organizations_url":"https://api.github.com/users/tmooney/orgs","repos_url":"https://api.github.com/users/tmooney/repos","events_url":"https://api.github.com/users/tmooney/events{/privacy}","received_events_url":"https://api.github.com/users/tmooney/received_events","type":"User","site_admin":false},"body":"When a SoftwareResult is found via `get_with_lock` or `get_or_create`, two specific users must be supplied: a `sponsor` and a `requestor`.  The `sponsor` is the entity accountable for resource usage for the result.  (There may be multiple sponsors for a result if it used by multiple projects.)  The `requestor` is the entity with processing underway that needed the result.\r\n\r\n```perl\r\nusers => {\r\n  sponsor => ,#either a Genome::Config::AnalysisProject or a Genome::Sys::User object\r\n  requestor => ,#either a Genome::Model::Build or a Genome::Process object\r\n  ... #additional label => user mappings as desired\r\n}\r\n```\r\n\r\nThis will create two `Genome::SoftwareResult::User` objects for the SoftwareResult, one with the label `sponsor` and one with either `shortcut` or `created` depending on if this was the requestor that originally created the result.  (Note that a requestor may end up as both if a subsequent step fetches a result that the same build earlier created.)\r\n\r\nAdditional users can be set at creation time by supplying additional labels and user objects in the hash.","created_at":"2015-01-22T19:02:24Z","updated_at":"2015-01-28T14:02:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1537332dc07ccf68509ad146579c129481a3d708","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/genome/genome/pulls/429/commits","review_comments_url":"https://api.github.com/repos/genome/genome/pulls/429/comments","review_comment_url":"https://api.github.com/repos/genome/genome/pulls/comments/{number}","comments_url":"https://api.github.com/repos/genome/genome/issues/429/comments","statuses_url":"https://api.github.com/repos/genome/genome/statuses/09c3faa17a42f8d972b4a292692498671950a44c","head":{"label":"acoffman:require_sponsors_for_sr","ref":"require_sponsors_for_sr","sha":"09c3faa17a42f8d972b4a292692498671950a44c","user":{"login":"acoffman","id":13370,"avatar_url":"https://avatars.githubusercontent.com/u/13370?v=3","gravatar_id":"","url":"https://api.github.com/users/acoffman","html_url":"https://github.com/acoffman","followers_url":"https://api.github.com/users/acoffman/followers","following_url":"https://api.github.com/users/acoffman/following{/other_user}","gists_url":"https://api.github.com/users/acoffman/gists{/gist_id}","starred_url":"https://api.github.com/users/acoffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acoffman/subscriptions","organizations_url":"https://api.github.com/users/acoffman/orgs","repos_url":"https://api.github.com/users/acoffman/repos","events_url":"https://api.github.com/users/acoffman/events{/privacy}","received_events_url":"https://api.github.com/users/acoffman/received_events","type":"User","site_admin":false},"repo":{"id":23666268,"name":"genome","full_name":"acoffman/genome","owner":{"login":"acoffman","id":13370,"avatar_url":"https://avatars.githubusercontent.com/u/13370?v=3","gravatar_id":"","url":"https://api.github.com/users/acoffman","html_url":"https://github.com/acoffman","followers_url":"https://api.github.com/users/acoffman/followers","following_url":"https://api.github.com/users/acoffman/following{/other_user}","gists_url":"https://api.github.com/users/acoffman/gists{/gist_id}","starred_url":"https://api.github.com/users/acoffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acoffman/subscriptions","organizations_url":"https://api.github.com/users/acoffman/orgs","repos_url":"https://api.github.com/users/acoffman/repos","events_url":"https://api.github.com/users/acoffman/events{/privacy}","received_events_url":"https://api.github.com/users/acoffman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/acoffman/genome","description":"","fork":true,"url":"https://api.github.com/repos/acoffman/genome","forks_url":"https://api.github.com/repos/acoffman/genome/forks","keys_url":"https://api.github.com/repos/acoffman/genome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acoffman/genome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acoffman/genome/teams","hooks_url":"https://api.github.com/repos/acoffman/genome/hooks","issue_events_url":"https://api.github.com/repos/acoffman/genome/issues/events{/number}","events_url":"https://api.github.com/repos/acoffman/genome/events","assignees_url":"https://api.github.com/repos/acoffman/genome/assignees{/user}","branches_url":"https://api.github.com/repos/acoffman/genome/branches{/branch}","tags_url":"https://api.github.com/repos/acoffman/genome/tags","blobs_url":"https://api.github.com/repos/acoffman/genome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acoffman/genome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acoffman/genome/git/refs{/sha}","trees_url":"https://api.github.com/repos/acoffman/genome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acoffman/genome/statuses/{sha}","languages_url":"https://api.github.com/repos/acoffman/genome/languages","stargazers_url":"https://api.github.com/repos/acoffman/genome/stargazers","contributors_url":"https://api.github.com/repos/acoffman/genome/contributors","subscribers_url":"https://api.github.com/repos/acoffman/genome/subscribers","subscription_url":"https://api.github.com/repos/acoffman/genome/subscription","commits_url":"https://api.github.com/repos/acoffman/genome/commits{/sha}","git_commits_url":"https://api.github.com/repos/acoffman/genome/git/commits{/sha}","comments_url":"https://api.github.com/repos/acoffman/genome/comments{/number}","issue_comment_url":"https://api.github.com/repos/acoffman/genome/issues/comments/{number}","contents_url":"https://api.github.com/repos/acoffman/genome/contents/{+path}","compare_url":"https://api.github.com/repos/acoffman/genome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acoffman/genome/merges","archive_url":"https://api.github.com/repos/acoffman/genome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acoffman/genome/downloads","issues_url":"https://api.github.com/repos/acoffman/genome/issues{/number}","pulls_url":"https://api.github.com/repos/acoffman/genome/pulls{/number}","milestones_url":"https://api.github.com/repos/acoffman/genome/milestones{/number}","notifications_url":"https://api.github.com/repos/acoffman/genome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acoffman/genome/labels{/name}","releases_url":"https://api.github.com/repos/acoffman/genome/releases{/id}","created_at":"2014-09-04T14:41:51Z","updated_at":"2015-01-16T16:28:08Z","pushed_at":"2015-01-28T13:57:16Z","git_url":"git://github.com/acoffman/genome.git","ssh_url":"git@github.com:acoffman/genome.git","clone_url":"https://github.com/acoffman/genome.git","svn_url":"https://github.com/acoffman/genome","homepage":"","size":110567,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"genome:master","ref":"master","sha":"fcb7058fe1aa98d03997d5600cb694d94ea7e95f","user":{"login":"genome","id":318108,"avatar_url":"https://avatars.githubusercontent.com/u/318108?v=3","gravatar_id":"","url":"https://api.github.com/users/genome","html_url":"https://github.com/genome","followers_url":"https://api.github.com/users/genome/followers","following_url":"https://api.github.com/users/genome/following{/other_user}","gists_url":"https://api.github.com/users/genome/gists{/gist_id}","starred_url":"https://api.github.com/users/genome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genome/subscriptions","organizations_url":"https://api.github.com/users/genome/orgs","repos_url":"https://api.github.com/users/genome/repos","events_url":"https://api.github.com/users/genome/events{/privacy}","received_events_url":"https://api.github.com/users/genome/received_events","type":"Organization","site_admin":false},"repo":{"id":23442737,"name":"genome","full_name":"genome/genome","owner":{"login":"genome","id":318108,"avatar_url":"https://avatars.githubusercontent.com/u/318108?v=3","gravatar_id":"","url":"https://api.github.com/users/genome","html_url":"https://github.com/genome","followers_url":"https://api.github.com/users/genome/followers","following_url":"https://api.github.com/users/genome/following{/other_user}","gists_url":"https://api.github.com/users/genome/gists{/gist_id}","starred_url":"https://api.github.com/users/genome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genome/subscriptions","organizations_url":"https://api.github.com/users/genome/orgs","repos_url":"https://api.github.com/users/genome/repos","events_url":"https://api.github.com/users/genome/events{/privacy}","received_events_url":"https://api.github.com/users/genome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/genome/genome","description":"Core modules used by the GMS","fork":false,"url":"https://api.github.com/repos/genome/genome","forks_url":"https://api.github.com/repos/genome/genome/forks","keys_url":"https://api.github.com/repos/genome/genome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/genome/genome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/genome/genome/teams","hooks_url":"https://api.github.com/repos/genome/genome/hooks","issue_events_url":"https://api.github.com/repos/genome/genome/issues/events{/number}","events_url":"https://api.github.com/repos/genome/genome/events","assignees_url":"https://api.github.com/repos/genome/genome/assignees{/user}","branches_url":"https://api.github.com/repos/genome/genome/branches{/branch}","tags_url":"https://api.github.com/repos/genome/genome/tags","blobs_url":"https://api.github.com/repos/genome/genome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/genome/genome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/genome/genome/git/refs{/sha}","trees_url":"https://api.github.com/repos/genome/genome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/genome/genome/statuses/{sha}","languages_url":"https://api.github.com/repos/genome/genome/languages","stargazers_url":"https://api.github.com/repos/genome/genome/stargazers","contributors_url":"https://api.github.com/repos/genome/genome/contributors","subscribers_url":"https://api.github.com/repos/genome/genome/subscribers","subscription_url":"https://api.github.com/repos/genome/genome/subscription","commits_url":"https://api.github.com/repos/genome/genome/commits{/sha}","git_commits_url":"https://api.github.com/repos/genome/genome/git/commits{/sha}","comments_url":"https://api.github.com/repos/genome/genome/comments{/number}","issue_comment_url":"https://api.github.com/repos/genome/genome/issues/comments/{number}","contents_url":"https://api.github.com/repos/genome/genome/contents/{+path}","compare_url":"https://api.github.com/repos/genome/genome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/genome/genome/merges","archive_url":"https://api.github.com/repos/genome/genome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/genome/genome/downloads","issues_url":"https://api.github.com/repos/genome/genome/issues{/number}","pulls_url":"https://api.github.com/repos/genome/genome/pulls{/number}","milestones_url":"https://api.github.com/repos/genome/genome/milestones{/number}","notifications_url":"https://api.github.com/repos/genome/genome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/genome/genome/labels{/name}","releases_url":"https://api.github.com/repos/genome/genome/releases{/id}","created_at":"2014-08-28T20:59:19Z","updated_at":"2015-01-28T13:16:22Z","pushed_at":"2015-01-28T13:16:21Z","git_url":"git://github.com/genome/genome.git","ssh_url":"git@github.com:genome/genome.git","clone_url":"https://github.com/genome/genome.git","svn_url":"https://github.com/genome/genome","homepage":"","size":119182,"stargazers_count":4,"watchers_count":4,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":8,"forks":32,"open_issues":8,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/genome/genome/pulls/429"},"html":{"href":"https://github.com/genome/genome/pull/429"},"issue":{"href":"https://api.github.com/repos/genome/genome/issues/429"},"comments":{"href":"https://api.github.com/repos/genome/genome/issues/429/comments"},"review_comments":{"href":"https://api.github.com/repos/genome/genome/pulls/429/comments"},"review_comment":{"href":"https://api.github.com/repos/genome/genome/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/genome/genome/pulls/429/commits"},"statuses":{"href":"https://api.github.com/repos/genome/genome/statuses/09c3faa17a42f8d972b4a292692498671950a44c"}}}}