{"action":"created","comment":{"url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments/40026704","id":40026704,"diff_hunk":"@@ -46,9 +46,6 @@ class NewWebUserRegistrationForm(DomainRegistrationForm):\n     \"\"\"\n     Form for a brand new user, before they've created a domain or done anything on CommCare HQ.\n     \"\"\"\n-    full_name = forms.CharField(label=_('Full Name'),","path":"corehq/apps/registration/forms.py","position":4,"original_position":4,"commit_id":"6c2756f8fc551711f2b1ee9b4fa572848b460ec1","original_commit_id":"5dfae35f5dde7228966da73f4409069617e79a9a","user":{"login":"amsagoff","id":439164,"avatar_url":"https://avatars.githubusercontent.com/u/439164?v=3","gravatar_id":"","url":"https://api.github.com/users/amsagoff","html_url":"https://github.com/amsagoff","followers_url":"https://api.github.com/users/amsagoff/followers","following_url":"https://api.github.com/users/amsagoff/following{/other_user}","gists_url":"https://api.github.com/users/amsagoff/gists{/gist_id}","starred_url":"https://api.github.com/users/amsagoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amsagoff/subscriptions","organizations_url":"https://api.github.com/users/amsagoff/orgs","repos_url":"https://api.github.com/users/amsagoff/repos","events_url":"https://api.github.com/users/amsagoff/events{/privacy}","received_events_url":"https://api.github.com/users/amsagoff/received_events","type":"User","site_admin":false},"body":"Update: we need to put first name and last name back in there, as optional\nfields. Jenny, happy to give context over voice, but basically hubspot has\nsome compelling evidence that having names helps significantly with\nmarketing campaigns.\n\nOn Mon, Sep 14, 2015 at 4:02 PM, Amelia Sagoff <asagoff@dimagi.com> wrote:\n\n> hey - this is now stalling on some objections from marketing - we may need\n> to put firstname/lastname back in there. Will update you when this thread\n> is resolved (hopefully soon)\n>\n> On Thu, Sep 10, 2015 at 10:29 AM, Jonathan Emord <notifications@github.com\n> > wrote:\n>\n>> In corehq/apps/registration/forms.py\n>> <https://github.com/dimagi/commcare-hq/pull/8202#discussion_r39166190>:\n>>\n>> > @@ -46,9 +46,6 @@ class NewWebUserRegistrationForm(DomainRegistrationForm):\n>> >      \"\"\"\n>> >      Form for a brand new user, before they've created a domain or done anything on CommCare HQ.\n>> >      \"\"\"\n>> > -    full_name = forms.CharField(label=_('Full Name'),\n>>\n>> Ha. I recently used full_name for interrupt\n>> https://github.com/dimagi/commcare-hq/pull/8109/files\n>>\n>> Just realizing now that keeping the username kwarg was probably not the\n>> most clear idea\n>>\n>> —\n>> Reply to this email directly or view it on GitHub\n>> <https://github.com/dimagi/commcare-hq/pull/8202/files#r39166190>.\n>>\n>\n>\n","created_at":"2015-09-21T21:12:55Z","updated_at":"2015-09-21T21:12:55Z","html_url":"https://github.com/dimagi/commcare-hq/pull/8202#discussion_r40026704","pull_request_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/8202","_links":{"self":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments/40026704"},"html":{"href":"https://github.com/dimagi/commcare-hq/pull/8202#discussion_r40026704"},"pull_request":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/8202"}}},"pull_request":{"url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/8202","id":44609246,"html_url":"https://github.com/dimagi/commcare-hq/pull/8202","diff_url":"https://github.com/dimagi/commcare-hq/pull/8202.diff","patch_url":"https://github.com/dimagi/commcare-hq/pull/8202.patch","issue_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/8202","number":8202,"state":"open","locked":false,"title":"Update signup","user":{"login":"orangejenny","id":1486591,"avatar_url":"https://avatars.githubusercontent.com/u/1486591?v=3","gravatar_id":"","url":"https://api.github.com/users/orangejenny","html_url":"https://github.com/orangejenny","followers_url":"https://api.github.com/users/orangejenny/followers","following_url":"https://api.github.com/users/orangejenny/following{/other_user}","gists_url":"https://api.github.com/users/orangejenny/gists{/gist_id}","starred_url":"https://api.github.com/users/orangejenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orangejenny/subscriptions","organizations_url":"https://api.github.com/users/orangejenny/orgs","repos_url":"https://api.github.com/users/orangejenny/repos","events_url":"https://api.github.com/users/orangejenny/events{/privacy}","received_events_url":"https://api.github.com/users/orangejenny/received_events","type":"User","site_admin":false},"body":"http://manage.dimagi.com/default.asp?181122\r\n\r\nOld account creation page:\r\n![screen shot 2015-09-09 at 6 12 34 pm](https://cloud.githubusercontent.com/assets/1486591/9775961/a2c7e9e2-5721-11e5-9f0f-976abfe124f6.png)\r\n\r\nNew account creation page:\r\n![screen shot 2015-09-09 at 6 12 02 pm](https://cloud.githubusercontent.com/assets/1486591/9775972/adbf7964-5721-11e5-9b21-8acc4e74b9c0.png)\r\n\r\nOld invitation acceptance page:\r\n![screen shot 2015-09-09 at 6 16 13 pm](https://cloud.githubusercontent.com/assets/1486591/9775979/b8609218-5721-11e5-8460-e6e079f42b54.png)\r\n\r\nNew invitation acceptance page:\r\n![screen shot 2015-09-09 at 6 22 11 pm](https://cloud.githubusercontent.com/assets/1486591/9775982/c0f174a6-5721-11e5-9712-735076dbe158.png)\r\n\r\nAsking for quick sanity QA, as a bug in account creation would be hard for end users to report.\r\n\r\ncc @dimagi/product \r\n\r\n@emord / @kaapstorm ","created_at":"2015-09-09T22:38:39Z","updated_at":"2015-09-21T21:12:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28396e443d4651146aaa823f2bc16ae52aeacad4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/8202/commits","review_comments_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/8202/comments","review_comment_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/8202/comments","statuses_url":"https://api.github.com/repos/dimagi/commcare-hq/statuses/6c2756f8fc551711f2b1ee9b4fa572848b460ec1","head":{"label":"dimagi:update-signup","ref":"update-signup","sha":"6c2756f8fc551711f2b1ee9b4fa572848b460ec1","user":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":247278,"name":"commcare-hq","full_name":"dimagi/commcare-hq","owner":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dimagi/commcare-hq","description":"A server-side tool to help manage community health workers, written in Django","fork":false,"url":"https://api.github.com/repos/dimagi/commcare-hq","forks_url":"https://api.github.com/repos/dimagi/commcare-hq/forks","keys_url":"https://api.github.com/repos/dimagi/commcare-hq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/commcare-hq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/commcare-hq/teams","hooks_url":"https://api.github.com/repos/dimagi/commcare-hq/hooks","issue_events_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/commcare-hq/events","assignees_url":"https://api.github.com/repos/dimagi/commcare-hq/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/commcare-hq/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/commcare-hq/tags","blobs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/commcare-hq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/commcare-hq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/commcare-hq/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/commcare-hq/languages","stargazers_url":"https://api.github.com/repos/dimagi/commcare-hq/stargazers","contributors_url":"https://api.github.com/repos/dimagi/commcare-hq/contributors","subscribers_url":"https://api.github.com/repos/dimagi/commcare-hq/subscribers","subscription_url":"https://api.github.com/repos/dimagi/commcare-hq/subscription","commits_url":"https://api.github.com/repos/dimagi/commcare-hq/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/commcare-hq/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/commcare-hq/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimagi/commcare-hq/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/commcare-hq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/commcare-hq/merges","archive_url":"https://api.github.com/repos/dimagi/commcare-hq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/commcare-hq/downloads","issues_url":"https://api.github.com/repos/dimagi/commcare-hq/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/commcare-hq/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/commcare-hq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/commcare-hq/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/commcare-hq/releases{/id}","created_at":"2009-07-09T17:00:07Z","updated_at":"2015-09-03T14:30:33Z","pushed_at":"2015-09-21T20:16:08Z","git_url":"git://github.com/dimagi/commcare-hq.git","ssh_url":"git@github.com:dimagi/commcare-hq.git","clone_url":"https://github.com/dimagi/commcare-hq.git","svn_url":"https://github.com/dimagi/commcare-hq","homepage":"http://www.commcarehq.org","size":411842,"stargazers_count":50,"watchers_count":50,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":61,"mirror_url":null,"open_issues_count":49,"forks":61,"open_issues":49,"watchers":50,"default_branch":"master"}},"base":{"label":"dimagi:master","ref":"master","sha":"d562208ae6f6e44f8b8e899d018a9d65016b0a6c","user":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":247278,"name":"commcare-hq","full_name":"dimagi/commcare-hq","owner":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dimagi/commcare-hq","description":"A server-side tool to help manage community health workers, written in Django","fork":false,"url":"https://api.github.com/repos/dimagi/commcare-hq","forks_url":"https://api.github.com/repos/dimagi/commcare-hq/forks","keys_url":"https://api.github.com/repos/dimagi/commcare-hq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/commcare-hq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/commcare-hq/teams","hooks_url":"https://api.github.com/repos/dimagi/commcare-hq/hooks","issue_events_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/commcare-hq/events","assignees_url":"https://api.github.com/repos/dimagi/commcare-hq/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/commcare-hq/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/commcare-hq/tags","blobs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/commcare-hq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/commcare-hq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/commcare-hq/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/commcare-hq/languages","stargazers_url":"https://api.github.com/repos/dimagi/commcare-hq/stargazers","contributors_url":"https://api.github.com/repos/dimagi/commcare-hq/contributors","subscribers_url":"https://api.github.com/repos/dimagi/commcare-hq/subscribers","subscription_url":"https://api.github.com/repos/dimagi/commcare-hq/subscription","commits_url":"https://api.github.com/repos/dimagi/commcare-hq/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/commcare-hq/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/commcare-hq/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimagi/commcare-hq/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/commcare-hq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/commcare-hq/merges","archive_url":"https://api.github.com/repos/dimagi/commcare-hq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/commcare-hq/downloads","issues_url":"https://api.github.com/repos/dimagi/commcare-hq/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/commcare-hq/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/commcare-hq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/commcare-hq/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/commcare-hq/releases{/id}","created_at":"2009-07-09T17:00:07Z","updated_at":"2015-09-03T14:30:33Z","pushed_at":"2015-09-21T20:16:08Z","git_url":"git://github.com/dimagi/commcare-hq.git","ssh_url":"git@github.com:dimagi/commcare-hq.git","clone_url":"https://github.com/dimagi/commcare-hq.git","svn_url":"https://github.com/dimagi/commcare-hq","homepage":"http://www.commcarehq.org","size":411842,"stargazers_count":50,"watchers_count":50,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":61,"mirror_url":null,"open_issues_count":49,"forks":61,"open_issues":49,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/8202"},"html":{"href":"https://github.com/dimagi/commcare-hq/pull/8202"},"issue":{"href":"https://api.github.com/repos/dimagi/commcare-hq/issues/8202"},"comments":{"href":"https://api.github.com/repos/dimagi/commcare-hq/issues/8202/comments"},"review_comments":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/8202/comments"},"review_comment":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/8202/commits"},"statuses":{"href":"https://api.github.com/repos/dimagi/commcare-hq/statuses/6c2756f8fc551711f2b1ee9b4fa572848b460ec1"}}}}