{"action":"created","issue":{"url":"https://api.github.com/repos/spacewalkproject/spacewalk/issues/219","labels_url":"https://api.github.com/repos/spacewalkproject/spacewalk/issues/219/labels{/name}","comments_url":"https://api.github.com/repos/spacewalkproject/spacewalk/issues/219/comments","events_url":"https://api.github.com/repos/spacewalkproject/spacewalk/issues/219/events","html_url":"https://github.com/spacewalkproject/spacewalk/pull/219","id":57731883,"number":219,"title":"Remove more monitoring","user":{"login":"mcalmer","id":1038917,"avatar_url":"https://avatars.githubusercontent.com/u/1038917?v=3","gravatar_id":"","url":"https://api.github.com/users/mcalmer","html_url":"https://github.com/mcalmer","followers_url":"https://api.github.com/users/mcalmer/followers","following_url":"https://api.github.com/users/mcalmer/following{/other_user}","gists_url":"https://api.github.com/users/mcalmer/gists{/gist_id}","starred_url":"https://api.github.com/users/mcalmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcalmer/subscriptions","organizations_url":"https://api.github.com/users/mcalmer/orgs","repos_url":"https://api.github.com/users/mcalmer/repos","events_url":"https://api.github.com/users/mcalmer/events{/privacy}","received_events_url":"https://api.github.com/users/mcalmer/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"sdherr","id":775480,"avatar_url":"https://avatars.githubusercontent.com/u/775480?v=3","gravatar_id":"","url":"https://api.github.com/users/sdherr","html_url":"https://github.com/sdherr","followers_url":"https://api.github.com/users/sdherr/followers","following_url":"https://api.github.com/users/sdherr/following{/other_user}","gists_url":"https://api.github.com/users/sdherr/gists{/gist_id}","starred_url":"https://api.github.com/users/sdherr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdherr/subscriptions","organizations_url":"https://api.github.com/users/sdherr/orgs","repos_url":"https://api.github.com/users/sdherr/repos","events_url":"https://api.github.com/users/sdherr/events{/privacy}","received_events_url":"https://api.github.com/users/sdherr/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-02-15T14:25:53Z","updated_at":"2015-02-16T16:15:53Z","closed_at":"2015-02-16T16:15:53Z","pull_request":{"url":"https://api.github.com/repos/spacewalkproject/spacewalk/pulls/219","html_url":"https://github.com/spacewalkproject/spacewalk/pull/219","diff_url":"https://github.com/spacewalkproject/spacewalk/pull/219.diff","patch_url":"https://github.com/spacewalkproject/spacewalk/pull/219.patch"},"body":"remove more monitoring from spacewalk.\r\n\r\n- config files\r\n- setup \r\n- proxy\r\n- etc.\r\n\r\nThere are still references in:\r\n\r\n* selinux/spacewalk-monitoring-selinux/\r\n\r\n* schema/spacewalk/common/data/rhn_config_parameter.sql\r\n  Can this table be dropped?\r\n\r\n* schema/spacewalk/common/data/rhn_config_macro.sql\r\n  Can this table be dropped?\r\n\r\n* java MonitoringConfigFactory.java\r\n\r\n* java ConfigMacro.java\r\n\r\n@sdherr: please review."},"comment":{"url":"https://api.github.com/repos/spacewalkproject/spacewalk/issues/comments/74532677","html_url":"https://github.com/spacewalkproject/spacewalk/pull/219#issuecomment-74532677","issue_url":"https://api.github.com/repos/spacewalkproject/spacewalk/issues/219","id":74532677,"user":{"login":"sdherr","id":775480,"avatar_url":"https://avatars.githubusercontent.com/u/775480?v=3","gravatar_id":"","url":"https://api.github.com/users/sdherr","html_url":"https://github.com/sdherr","followers_url":"https://api.github.com/users/sdherr/followers","following_url":"https://api.github.com/users/sdherr/following{/other_user}","gists_url":"https://api.github.com/users/sdherr/gists{/gist_id}","starred_url":"https://api.github.com/users/sdherr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdherr/subscriptions","organizations_url":"https://api.github.com/users/sdherr/orgs","repos_url":"https://api.github.com/users/sdherr/repos","events_url":"https://api.github.com/users/sdherr/events{/privacy}","received_events_url":"https://api.github.com/users/sdherr/received_events","type":"User","site_admin":false},"created_at":"2015-02-16T16:15:53Z","updated_at":"2015-02-16T16:15:53Z","body":"The submitted changes look reasonable, committing as 315e8f988ccb6835dcfa06920499245801c6d56b to 59b9f40b27ee5a26305984ff20d66f49cffa2c80. Thanks!\r\n\r\nThe monitoring selinux package is probably not needed any more, but I'd have to look it over carefully to be certain of that. The reason the other classes / tables are still around is that there are one or two things that are sill supported that required them. For example the ConfigureSatelliteCommand (used for /rhn/admin/config/GeneralConfig.do) depends on ConfigMacro and MonitoringConfigFactory, and the hbm mappings for ConfigMacro include those tables. I didn't want to break things during the giant monitoring removal, so I left all that stuff in. However a more careful investigation / refactoring may reveal that it's really not necessary any more."}}