{"action":"closed","number":102,"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/102","id":46946472,"html_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/102","diff_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/102.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/102.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/102","number":102,"state":"closed","locked":false,"title":"Do not shut down Admin on test completion","user":{"login":"pperalta","id":394956,"avatar_url":"https://avatars.githubusercontent.com/u/394956?v=3","gravatar_id":"","url":"https://api.github.com/users/pperalta","html_url":"https://github.com/pperalta","followers_url":"https://api.github.com/users/pperalta/followers","following_url":"https://api.github.com/users/pperalta/following{/other_user}","gists_url":"https://api.github.com/users/pperalta/gists{/gist_id}","starred_url":"https://api.github.com/users/pperalta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pperalta/subscriptions","organizations_url":"https://api.github.com/users/pperalta/orgs","repos_url":"https://api.github.com/users/pperalta/repos","events_url":"https://api.github.com/users/pperalta/events{/privacy}","received_events_url":"https://api.github.com/users/pperalta/received_events","type":"User","site_admin":false},"body":"The shell tests have the option of shutting down the Admin server after test execution. This change makes the default setting `false` because shutting down the admin inside of the test may lead to the following test failure:\r\n\r\n```\r\n[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.17:test (default-test)\r\non project spring-cloud-dataflow-shell: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.17:test failed: The forked VM terminated without properly saying goodbye. VM crash or\r\nSystem.exit called?\r\n```\r\nThis failure occurred with the following environment:\r\n```\r\n$ mvn --version\r\nApache Maven 3.3.3 (7994120775791599e205a5524ec3e0dfe41d4a06;\r\n2015-04-22T07:57:37-04:00)\r\nMaven home: /usr/local/Cellar/maven/3.3.3/libexec\r\nJava version: 1.8.0_60, vendor: Oracle Corporation\r\nJava home: /Library/Java/JavaVirtualMachines/jdk1.8.0_60.jdk/Contents/Home/jre\r\nDefault locale: en_US, platform encoding: UTF-8\r\nOS name: \"mac os x\", version: \"10.10.5\", arch: \"x86_64\", family: \"mac\"\r\n```","created_at":"2015-10-06T19:27:55Z","updated_at":"2015-10-06T22:06:16Z","closed_at":"2015-10-06T22:06:16Z","merged_at":null,"merge_commit_sha":"6ecc792f158f5ebeadc46092cbbfc5d57800b7a4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/102/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/102/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/102/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/statuses/ebd0806c723c62bf53557cc9bc0c20e1fbdb6040","head":{"label":"pperalta:shell-test-shutdown","ref":"shell-test-shutdown","sha":"ebd0806c723c62bf53557cc9bc0c20e1fbdb6040","user":{"login":"pperalta","id":394956,"avatar_url":"https://avatars.githubusercontent.com/u/394956?v=3","gravatar_id":"","url":"https://api.github.com/users/pperalta","html_url":"https://github.com/pperalta","followers_url":"https://api.github.com/users/pperalta/followers","following_url":"https://api.github.com/users/pperalta/following{/other_user}","gists_url":"https://api.github.com/users/pperalta/gists{/gist_id}","starred_url":"https://api.github.com/users/pperalta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pperalta/subscriptions","organizations_url":"https://api.github.com/users/pperalta/orgs","repos_url":"https://api.github.com/users/pperalta/repos","events_url":"https://api.github.com/users/pperalta/events{/privacy}","received_events_url":"https://api.github.com/users/pperalta/received_events","type":"User","site_admin":false},"repo":{"id":39509430,"name":"spring-cloud-dataflow","full_name":"pperalta/spring-cloud-dataflow","owner":{"login":"pperalta","id":394956,"avatar_url":"https://avatars.githubusercontent.com/u/394956?v=3","gravatar_id":"","url":"https://api.github.com/users/pperalta","html_url":"https://github.com/pperalta","followers_url":"https://api.github.com/users/pperalta/followers","following_url":"https://api.github.com/users/pperalta/following{/other_user}","gists_url":"https://api.github.com/users/pperalta/gists{/gist_id}","starred_url":"https://api.github.com/users/pperalta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pperalta/subscriptions","organizations_url":"https://api.github.com/users/pperalta/orgs","repos_url":"https://api.github.com/users/pperalta/repos","events_url":"https://api.github.com/users/pperalta/events{/privacy}","received_events_url":"https://api.github.com/users/pperalta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pperalta/spring-cloud-dataflow","description":"","fork":true,"url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow","forks_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/forks","keys_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/teams","hooks_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/hooks","issue_events_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/issues/events{/number}","events_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/events","assignees_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/assignees{/user}","branches_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/branches{/branch}","tags_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/tags","blobs_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/statuses/{sha}","languages_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/languages","stargazers_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/stargazers","contributors_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/contributors","subscribers_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/subscribers","subscription_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/subscription","commits_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/contents/{+path}","compare_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/merges","archive_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/downloads","issues_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/issues{/number}","pulls_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/pulls{/number}","milestones_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/milestones{/number}","notifications_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/labels{/name}","releases_url":"https://api.github.com/repos/pperalta/spring-cloud-dataflow/releases{/id}","created_at":"2015-07-22T14:02:13Z","updated_at":"2015-09-08T17:27:51Z","pushed_at":"2015-10-06T19:39:37Z","git_url":"git://github.com/pperalta/spring-cloud-dataflow.git","ssh_url":"git@github.com:pperalta/spring-cloud-dataflow.git","clone_url":"https://github.com/pperalta/spring-cloud-dataflow.git","svn_url":"https://github.com/pperalta/spring-cloud-dataflow","homepage":null,"size":1030,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"c74086e19541863d1dd2d3a8efa7a84ecc9cf5ae","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":39469487,"name":"spring-cloud-dataflow","full_name":"spring-cloud/spring-cloud-dataflow","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-dataflow","description":"","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/releases{/id}","created_at":"2015-07-21T20:56:11Z","updated_at":"2015-10-06T00:00:08Z","pushed_at":"2015-10-06T22:05:51Z","git_url":"git://github.com/spring-cloud/spring-cloud-dataflow.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-dataflow.git","clone_url":"https://github.com/spring-cloud/spring-cloud-dataflow.git","svn_url":"https://github.com/spring-cloud/spring-cloud-dataflow","homepage":null,"size":2476,"stargazers_count":17,"watchers_count":17,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":3,"forks":19,"open_issues":3,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/102"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/102"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/102"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/102/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/102/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/102/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/statuses/ebd0806c723c62bf53557cc9bc0c20e1fbdb6040"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}