{"action":"created","comment":{"url":"https://api.github.com/repos/dib-lab/khmer/pulls/comments/32377526","id":32377526,"diff_hunk":"@@ -1,3 +1,23 @@\n+2015-06-12  Titus Brown  <titus@idyll.org>\n+\n+   * khmer/__init__.py: pass IOError through extract_countinghash_info and\n+   extract_hashbits_info so that file-does-not-exist errors are correctly\n+   reported; fixed FP rate reporting.\n+   * khmer/khmer_args.py: removed environment variable override for hash size\n+   defaults; added -M/--max_memory_usage, and functions create_nodegraph()\n+   and create_countgraph().\n+   * khmer/kfile.py: fixed check_space_for_hashtable to depend on args obj.\n+   * tests/test_script_arguments.py: updated tests.\n+   * scripts/{abundance-dist-single.py,count-overlap.py,do-partition.py,\n+   filter-abund-single.py,find-knots.py,load-into-counting.py,\n+   make-initial-stoptags.py,normalize-by-median.py,trim-low-abund.py,\n+   sandbox/{collect-reads.py,saturate-by-median.py}: replaced\n+   counting hash/hashbits creation with new khmer_args create* functions.\n+   * oxli/build_graph.py,sandbox/{sweep-files.py,sweep-reads.py},\n+   scripts/{count-overlap.py,do-partition.py,},khmer/khmer_args.py:\n+   changed hashtype over to 'nodegraph' and 'bitgraph' in call to","path":"ChangeLog","position":18,"original_position":18,"commit_id":"b9b61a8870cc63c0aa92670f3b2860e7d44f7f76","original_commit_id":"b9b61a8870cc63c0aa92670f3b2860e7d44f7f76","user":{"login":"mr-c","id":1330696,"avatar_url":"https://avatars.githubusercontent.com/u/1330696?v=3","gravatar_id":"","url":"https://api.github.com/users/mr-c","html_url":"https://github.com/mr-c","followers_url":"https://api.github.com/users/mr-c/followers","following_url":"https://api.github.com/users/mr-c/following{/other_user}","gists_url":"https://api.github.com/users/mr-c/gists{/gist_id}","starred_url":"https://api.github.com/users/mr-c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mr-c/subscriptions","organizations_url":"https://api.github.com/users/mr-c/orgs","repos_url":"https://api.github.com/users/mr-c/repos","events_url":"https://api.github.com/users/mr-c/events{/privacy}","received_events_url":"https://api.github.com/users/mr-c/received_events","type":"User","site_admin":false},"body":"s/bitgraph/countgraph/","created_at":"2015-06-14T08:23:25Z","updated_at":"2015-06-14T08:23:25Z","html_url":"https://github.com/dib-lab/khmer/pull/1050#discussion_r32377526","pull_request_url":"https://api.github.com/repos/dib-lab/khmer/pulls/1050","_links":{"self":{"href":"https://api.github.com/repos/dib-lab/khmer/pulls/comments/32377526"},"html":{"href":"https://github.com/dib-lab/khmer/pull/1050#discussion_r32377526"},"pull_request":{"href":"https://api.github.com/repos/dib-lab/khmer/pulls/1050"}}},"pull_request":{"url":"https://api.github.com/repos/dib-lab/khmer/pulls/1050","id":36581490,"html_url":"https://github.com/dib-lab/khmer/pull/1050","diff_url":"https://github.com/dib-lab/khmer/pull/1050.diff","patch_url":"https://github.com/dib-lab/khmer/pull/1050.patch","issue_url":"https://api.github.com/repos/dib-lab/khmer/issues/1050","number":1050,"state":"open","locked":false,"title":"Add --max-memory-usage argument, and associated khmer_args refactoring.","user":{"login":"ctb","id":51016,"avatar_url":"https://avatars.githubusercontent.com/u/51016?v=3","gravatar_id":"","url":"https://api.github.com/users/ctb","html_url":"https://github.com/ctb","followers_url":"https://api.github.com/users/ctb/followers","following_url":"https://api.github.com/users/ctb/following{/other_user}","gists_url":"https://api.github.com/users/ctb/gists{/gist_id}","starred_url":"https://api.github.com/users/ctb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctb/subscriptions","organizations_url":"https://api.github.com/users/ctb/orgs","repos_url":"https://api.github.com/users/ctb/repos","events_url":"https://api.github.com/users/ctb/events{/privacy}","received_events_url":"https://api.github.com/users/ctb/received_events","type":"User","site_admin":false},"body":"- [x] add `-M/--max-memory-usage` parameter in khmer_args.py (try 2 to address https://github.com/dib-lab/khmer/issues/732#issuecomment-70554583; try 1 is #744)\r\n- [x] start salting in nodegraph and countgraph terminology at Python level, as convenient (ref #872)\r\n- [x] fix up all of the scripts to use `create_nodegraph/create_countgraph` functions from khmer_args.py\r\n- [ ] add unit tests for create_nodegraph and create_countgraph\r\n- [ ] add tests for -M parameter in scripts/\r\n- [x] change `check_space_for_hashtable` to use 'args' rather than 'min_tablesize'\r\n- [x] then, run test_scripts after renaming the min_tablesize parameter to see what else we need to change\r\n- [ ] update docs\r\n- [ ] update whatsnew for 2.0\r\n","created_at":"2015-05-31T12:36:11Z","updated_at":"2015-06-14T08:23:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25b5cac269d33312f42f27c429f49fa8f8189808","assignee":null,"milestone":{"url":"https://api.github.com/repos/dib-lab/khmer/milestones/11","html_url":"https://github.com/dib-lab/khmer/milestones/2.0","labels_url":"https://api.github.com/repos/dib-lab/khmer/milestones/11/labels","id":695846,"number":11,"title":"2.0","description":"Issues that will break the API/file format and so must wait until 2.0.\r\n","creator":{"login":"ctb","id":51016,"avatar_url":"https://avatars.githubusercontent.com/u/51016?v=3","gravatar_id":"","url":"https://api.github.com/users/ctb","html_url":"https://github.com/ctb","followers_url":"https://api.github.com/users/ctb/followers","following_url":"https://api.github.com/users/ctb/following{/other_user}","gists_url":"https://api.github.com/users/ctb/gists{/gist_id}","starred_url":"https://api.github.com/users/ctb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctb/subscriptions","organizations_url":"https://api.github.com/users/ctb/orgs","repos_url":"https://api.github.com/users/ctb/repos","events_url":"https://api.github.com/users/ctb/events{/privacy}","received_events_url":"https://api.github.com/users/ctb/received_events","type":"User","site_admin":false},"open_issues":25,"closed_issues":13,"state":"open","created_at":"2014-06-19T14:06:19Z","updated_at":"2015-06-13T19:31:17Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dib-lab/khmer/pulls/1050/commits","review_comments_url":"https://api.github.com/repos/dib-lab/khmer/pulls/1050/comments","review_comment_url":"https://api.github.com/repos/dib-lab/khmer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dib-lab/khmer/issues/1050/comments","statuses_url":"https://api.github.com/repos/dib-lab/khmer/statuses/b9b61a8870cc63c0aa92670f3b2860e7d44f7f76","head":{"label":"dib-lab:update/memory-args2","ref":"update/memory-args2","sha":"b9b61a8870cc63c0aa92670f3b2860e7d44f7f76","user":{"login":"dib-lab","id":1740697,"avatar_url":"https://avatars.githubusercontent.com/u/1740697?v=3","gravatar_id":"","url":"https://api.github.com/users/dib-lab","html_url":"https://github.com/dib-lab","followers_url":"https://api.github.com/users/dib-lab/followers","following_url":"https://api.github.com/users/dib-lab/following{/other_user}","gists_url":"https://api.github.com/users/dib-lab/gists{/gist_id}","starred_url":"https://api.github.com/users/dib-lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dib-lab/subscriptions","organizations_url":"https://api.github.com/users/dib-lab/orgs","repos_url":"https://api.github.com/users/dib-lab/repos","events_url":"https://api.github.com/users/dib-lab/events{/privacy}","received_events_url":"https://api.github.com/users/dib-lab/received_events","type":"Organization","site_admin":false},"repo":{"id":4331833,"name":"khmer","full_name":"dib-lab/khmer","owner":{"login":"dib-lab","id":1740697,"avatar_url":"https://avatars.githubusercontent.com/u/1740697?v=3","gravatar_id":"","url":"https://api.github.com/users/dib-lab","html_url":"https://github.com/dib-lab","followers_url":"https://api.github.com/users/dib-lab/followers","following_url":"https://api.github.com/users/dib-lab/following{/other_user}","gists_url":"https://api.github.com/users/dib-lab/gists{/gist_id}","starred_url":"https://api.github.com/users/dib-lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dib-lab/subscriptions","organizations_url":"https://api.github.com/users/dib-lab/orgs","repos_url":"https://api.github.com/users/dib-lab/repos","events_url":"https://api.github.com/users/dib-lab/events{/privacy}","received_events_url":"https://api.github.com/users/dib-lab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dib-lab/khmer","description":"In-memory nucleotide sequence k-mer counting, filtering, graph traversal and more","fork":false,"url":"https://api.github.com/repos/dib-lab/khmer","forks_url":"https://api.github.com/repos/dib-lab/khmer/forks","keys_url":"https://api.github.com/repos/dib-lab/khmer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dib-lab/khmer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dib-lab/khmer/teams","hooks_url":"https://api.github.com/repos/dib-lab/khmer/hooks","issue_events_url":"https://api.github.com/repos/dib-lab/khmer/issues/events{/number}","events_url":"https://api.github.com/repos/dib-lab/khmer/events","assignees_url":"https://api.github.com/repos/dib-lab/khmer/assignees{/user}","branches_url":"https://api.github.com/repos/dib-lab/khmer/branches{/branch}","tags_url":"https://api.github.com/repos/dib-lab/khmer/tags","blobs_url":"https://api.github.com/repos/dib-lab/khmer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dib-lab/khmer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dib-lab/khmer/git/refs{/sha}","trees_url":"https://api.github.com/repos/dib-lab/khmer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dib-lab/khmer/statuses/{sha}","languages_url":"https://api.github.com/repos/dib-lab/khmer/languages","stargazers_url":"https://api.github.com/repos/dib-lab/khmer/stargazers","contributors_url":"https://api.github.com/repos/dib-lab/khmer/contributors","subscribers_url":"https://api.github.com/repos/dib-lab/khmer/subscribers","subscription_url":"https://api.github.com/repos/dib-lab/khmer/subscription","commits_url":"https://api.github.com/repos/dib-lab/khmer/commits{/sha}","git_commits_url":"https://api.github.com/repos/dib-lab/khmer/git/commits{/sha}","comments_url":"https://api.github.com/repos/dib-lab/khmer/comments{/number}","issue_comment_url":"https://api.github.com/repos/dib-lab/khmer/issues/comments{/number}","contents_url":"https://api.github.com/repos/dib-lab/khmer/contents/{+path}","compare_url":"https://api.github.com/repos/dib-lab/khmer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dib-lab/khmer/merges","archive_url":"https://api.github.com/repos/dib-lab/khmer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dib-lab/khmer/downloads","issues_url":"https://api.github.com/repos/dib-lab/khmer/issues{/number}","pulls_url":"https://api.github.com/repos/dib-lab/khmer/pulls{/number}","milestones_url":"https://api.github.com/repos/dib-lab/khmer/milestones{/number}","notifications_url":"https://api.github.com/repos/dib-lab/khmer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dib-lab/khmer/labels{/name}","releases_url":"https://api.github.com/repos/dib-lab/khmer/releases{/id}","created_at":"2012-05-15T03:52:53Z","updated_at":"2015-06-10T14:25:55Z","pushed_at":"2015-06-14T06:46:11Z","git_url":"git://github.com/dib-lab/khmer.git","ssh_url":"git@github.com:dib-lab/khmer.git","clone_url":"https://github.com/dib-lab/khmer.git","svn_url":"https://github.com/dib-lab/khmer","homepage":"http://khmer.readthedocs.org/","size":164080,"stargazers_count":236,"watchers_count":236,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":194,"mirror_url":null,"open_issues_count":262,"forks":194,"open_issues":262,"watchers":236,"default_branch":"master"}},"base":{"label":"dib-lab:master","ref":"master","sha":"e8e7d0304099b278b770d6e12cc1576eba53f961","user":{"login":"dib-lab","id":1740697,"avatar_url":"https://avatars.githubusercontent.com/u/1740697?v=3","gravatar_id":"","url":"https://api.github.com/users/dib-lab","html_url":"https://github.com/dib-lab","followers_url":"https://api.github.com/users/dib-lab/followers","following_url":"https://api.github.com/users/dib-lab/following{/other_user}","gists_url":"https://api.github.com/users/dib-lab/gists{/gist_id}","starred_url":"https://api.github.com/users/dib-lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dib-lab/subscriptions","organizations_url":"https://api.github.com/users/dib-lab/orgs","repos_url":"https://api.github.com/users/dib-lab/repos","events_url":"https://api.github.com/users/dib-lab/events{/privacy}","received_events_url":"https://api.github.com/users/dib-lab/received_events","type":"Organization","site_admin":false},"repo":{"id":4331833,"name":"khmer","full_name":"dib-lab/khmer","owner":{"login":"dib-lab","id":1740697,"avatar_url":"https://avatars.githubusercontent.com/u/1740697?v=3","gravatar_id":"","url":"https://api.github.com/users/dib-lab","html_url":"https://github.com/dib-lab","followers_url":"https://api.github.com/users/dib-lab/followers","following_url":"https://api.github.com/users/dib-lab/following{/other_user}","gists_url":"https://api.github.com/users/dib-lab/gists{/gist_id}","starred_url":"https://api.github.com/users/dib-lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dib-lab/subscriptions","organizations_url":"https://api.github.com/users/dib-lab/orgs","repos_url":"https://api.github.com/users/dib-lab/repos","events_url":"https://api.github.com/users/dib-lab/events{/privacy}","received_events_url":"https://api.github.com/users/dib-lab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dib-lab/khmer","description":"In-memory nucleotide sequence k-mer counting, filtering, graph traversal and more","fork":false,"url":"https://api.github.com/repos/dib-lab/khmer","forks_url":"https://api.github.com/repos/dib-lab/khmer/forks","keys_url":"https://api.github.com/repos/dib-lab/khmer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dib-lab/khmer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dib-lab/khmer/teams","hooks_url":"https://api.github.com/repos/dib-lab/khmer/hooks","issue_events_url":"https://api.github.com/repos/dib-lab/khmer/issues/events{/number}","events_url":"https://api.github.com/repos/dib-lab/khmer/events","assignees_url":"https://api.github.com/repos/dib-lab/khmer/assignees{/user}","branches_url":"https://api.github.com/repos/dib-lab/khmer/branches{/branch}","tags_url":"https://api.github.com/repos/dib-lab/khmer/tags","blobs_url":"https://api.github.com/repos/dib-lab/khmer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dib-lab/khmer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dib-lab/khmer/git/refs{/sha}","trees_url":"https://api.github.com/repos/dib-lab/khmer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dib-lab/khmer/statuses/{sha}","languages_url":"https://api.github.com/repos/dib-lab/khmer/languages","stargazers_url":"https://api.github.com/repos/dib-lab/khmer/stargazers","contributors_url":"https://api.github.com/repos/dib-lab/khmer/contributors","subscribers_url":"https://api.github.com/repos/dib-lab/khmer/subscribers","subscription_url":"https://api.github.com/repos/dib-lab/khmer/subscription","commits_url":"https://api.github.com/repos/dib-lab/khmer/commits{/sha}","git_commits_url":"https://api.github.com/repos/dib-lab/khmer/git/commits{/sha}","comments_url":"https://api.github.com/repos/dib-lab/khmer/comments{/number}","issue_comment_url":"https://api.github.com/repos/dib-lab/khmer/issues/comments{/number}","contents_url":"https://api.github.com/repos/dib-lab/khmer/contents/{+path}","compare_url":"https://api.github.com/repos/dib-lab/khmer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dib-lab/khmer/merges","archive_url":"https://api.github.com/repos/dib-lab/khmer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dib-lab/khmer/downloads","issues_url":"https://api.github.com/repos/dib-lab/khmer/issues{/number}","pulls_url":"https://api.github.com/repos/dib-lab/khmer/pulls{/number}","milestones_url":"https://api.github.com/repos/dib-lab/khmer/milestones{/number}","notifications_url":"https://api.github.com/repos/dib-lab/khmer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dib-lab/khmer/labels{/name}","releases_url":"https://api.github.com/repos/dib-lab/khmer/releases{/id}","created_at":"2012-05-15T03:52:53Z","updated_at":"2015-06-10T14:25:55Z","pushed_at":"2015-06-14T06:46:11Z","git_url":"git://github.com/dib-lab/khmer.git","ssh_url":"git@github.com:dib-lab/khmer.git","clone_url":"https://github.com/dib-lab/khmer.git","svn_url":"https://github.com/dib-lab/khmer","homepage":"http://khmer.readthedocs.org/","size":164080,"stargazers_count":236,"watchers_count":236,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":194,"mirror_url":null,"open_issues_count":262,"forks":194,"open_issues":262,"watchers":236,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dib-lab/khmer/pulls/1050"},"html":{"href":"https://github.com/dib-lab/khmer/pull/1050"},"issue":{"href":"https://api.github.com/repos/dib-lab/khmer/issues/1050"},"comments":{"href":"https://api.github.com/repos/dib-lab/khmer/issues/1050/comments"},"review_comments":{"href":"https://api.github.com/repos/dib-lab/khmer/pulls/1050/comments"},"review_comment":{"href":"https://api.github.com/repos/dib-lab/khmer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dib-lab/khmer/pulls/1050/commits"},"statuses":{"href":"https://api.github.com/repos/dib-lab/khmer/statuses/b9b61a8870cc63c0aa92670f3b2860e7d44f7f76"}}}}