{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/43480392","id":43480392,"diff_hunk":"@@ -225,7 +226,63 @@ marionette('Message notification tests', function() {\n \n       openNotification();\n \n-      assertMessagesIsInCorrectState();\n+      assertMessagesIsInCorrectStateFromMessage(smsMessage);\n+    });\n+  });\n+\n+  suite('Display a conversation from a notification', function() {\n+    var messagesStorage;\n+    var thread1, thread2;\n+\n+    setup(function() {\n+      thread1 = ThreadGenerator.generate({\n+        numberOfMessages: 50,\n+        participants: ['999']\n+      });\n+      thread2 = ThreadGenerator.generate({\n+        numberOfMessages: 50,\n+        participants: ['888']\n+      });\n+\n+      messagesStorage = [ thread1, thread2 ];\n+    });\n+\n+    test('Clicking a notification while a conversation is loading', function() {\n+      messagesApp.launch();\n+      storage.setMessagesStorage(messagesStorage);\n+      // Set empty contacts store.\n+      storage.setContactsStorage();\n+\n+      var inbox = new InboxView(client);\n+      var conversation = inbox.goToConversation(\n+        thread1.id, { shouldWait: false }\n+      );\n+\n+      // Receive 'notification' system message and fill up the storage.\n+      messagesApp.sendSystemMessage('notification', {\n+        clicked: true,\n+        data: { threadId: thread2.id, id: thread2.messages[0].id }\n+      });\n+\n+      conversation.accessors.waitToAppear();\n+      var thread2Ids = thread2.messages.map(\n+        function(message) { return message.id; }\n+      );\n+\n+      // Our testing strategy is:\n+      // 1. Wait that all messages are rendered for thread2.\n+      thread2Ids.forEach(function(messageId) {","path":"apps/sms/test/marionette/notification_test.js","position":145,"original_position":145,"commit_id":"4c6fc224bfabbe652c78c901f8506ae5d2728568","original_commit_id":"4c6fc224bfabbe652c78c901f8506ae5d2728568","user":{"login":"azasypkin","id":1713708,"avatar_url":"https://avatars.githubusercontent.com/u/1713708?v=3","gravatar_id":"","url":"https://api.github.com/users/azasypkin","html_url":"https://github.com/azasypkin","followers_url":"https://api.github.com/users/azasypkin/followers","following_url":"https://api.github.com/users/azasypkin/following{/other_user}","gists_url":"https://api.github.com/users/azasypkin/gists{/gist_id}","starred_url":"https://api.github.com/users/azasypkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azasypkin/subscriptions","organizations_url":"https://api.github.com/users/azasypkin/orgs","repos_url":"https://api.github.com/users/azasypkin/repos","events_url":"https://api.github.com/users/azasypkin/events{/privacy}","received_events_url":"https://api.github.com/users/azasypkin/received_events","type":"User","site_admin":false},"body":"Ah yeah, it waits for the default timeout and fails if it can't find, likely was thinking about ```findElements```, sorry, please ignore ```Looks like findMessage doesn't guarantee that message is rendered already so it can return null```, but I can't recall why I added null check there :/","created_at":"2015-10-30T08:23:57Z","updated_at":"2015-10-30T08:23:57Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/32839#discussion_r43480392","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32839","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/43480392"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/32839#discussion_r43480392"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32839"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32839","id":49114079,"html_url":"https://github.com/mozilla-b2g/gaia/pull/32839","diff_url":"https://github.com/mozilla-b2g/gaia/pull/32839.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/32839.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/32839","number":32839,"state":"open","locked":false,"title":"Bug 1218374 - Properly stop the conversation rendering when entering …","user":{"login":"julienw","id":454175,"avatar_url":"https://avatars.githubusercontent.com/u/454175?v=3","gravatar_id":"","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"body":"…another conversation r=azasypkin","created_at":"2015-10-29T09:17:10Z","updated_at":"2015-10-30T08:23:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b225f47529b3cd83ed246f6b80cdcf7effe923f5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32839/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32839/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/32839/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/4c6fc224bfabbe652c78c901f8506ae5d2728568","head":{"label":"julienw:fix-stop-rendering-notifications","ref":"fix-stop-rendering-notifications","sha":"4c6fc224bfabbe652c78c901f8506ae5d2728568","user":{"login":"julienw","id":454175,"avatar_url":"https://avatars.githubusercontent.com/u/454175?v=3","gravatar_id":"","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"repo":{"id":6565987,"name":"gaia","full_name":"julienw/gaia","owner":{"login":"julienw","id":454175,"avatar_url":"https://avatars.githubusercontent.com/u/454175?v=3","gravatar_id":"","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/julienw/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project","fork":true,"url":"https://api.github.com/repos/julienw/gaia","forks_url":"https://api.github.com/repos/julienw/gaia/forks","keys_url":"https://api.github.com/repos/julienw/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/julienw/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/julienw/gaia/teams","hooks_url":"https://api.github.com/repos/julienw/gaia/hooks","issue_events_url":"https://api.github.com/repos/julienw/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/julienw/gaia/events","assignees_url":"https://api.github.com/repos/julienw/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/julienw/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/julienw/gaia/tags","blobs_url":"https://api.github.com/repos/julienw/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/julienw/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/julienw/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/julienw/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/julienw/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/julienw/gaia/languages","stargazers_url":"https://api.github.com/repos/julienw/gaia/stargazers","contributors_url":"https://api.github.com/repos/julienw/gaia/contributors","subscribers_url":"https://api.github.com/repos/julienw/gaia/subscribers","subscription_url":"https://api.github.com/repos/julienw/gaia/subscription","commits_url":"https://api.github.com/repos/julienw/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/julienw/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/julienw/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/julienw/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/julienw/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/julienw/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/julienw/gaia/merges","archive_url":"https://api.github.com/repos/julienw/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/julienw/gaia/downloads","issues_url":"https://api.github.com/repos/julienw/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/julienw/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/julienw/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/julienw/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/julienw/gaia/labels{/name}","releases_url":"https://api.github.com/repos/julienw/gaia/releases{/id}","created_at":"2012-11-06T17:18:15Z","updated_at":"2015-08-07T15:12:52Z","pushed_at":"2015-10-29T21:47:41Z","git_url":"git://github.com/julienw/gaia.git","ssh_url":"git@github.com:julienw/gaia.git","clone_url":"https://github.com/julienw/gaia.git","svn_url":"https://github.com/julienw/gaia","homepage":"https://wiki.mozilla.org/B2G","size":974019,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"94a98a3ca59e67da5f99c77c4fef31a54de3e6e3","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2015-10-30T02:19:35Z","pushed_at":"2015-10-30T08:22:49Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1682696,"stargazers_count":1993,"watchers_count":1993,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2504,"mirror_url":null,"open_issues_count":1247,"forks":2504,"open_issues":1247,"watchers":1993,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32839"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/32839"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/32839"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/32839/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32839/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32839/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/4c6fc224bfabbe652c78c901f8506ae5d2728568"}}}}