{"action":"created","comment":{"url":"https://api.github.com/repos/SyncFree/antidote/pulls/comments/30335591","id":30335591,"diff_hunk":"@@ -28,7 +28,7 @@\n \n -export([init/1]).\n \n--define(NUM, 100).\n+-define(NUM, 1).","path":"src/clocksi_static_tx_coord_sup.erl","position":5,"original_position":5,"commit_id":"3c666ed59e92f77fb6f3c2c68974f168468b1b59","original_commit_id":"3c666ed59e92f77fb6f3c2c68974f168468b1b59","user":{"login":"marsleezm","id":1566490,"avatar_url":"https://avatars.githubusercontent.com/u/1566490?v=3","gravatar_id":"","url":"https://api.github.com/users/marsleezm","html_url":"https://github.com/marsleezm","followers_url":"https://api.github.com/users/marsleezm/followers","following_url":"https://api.github.com/users/marsleezm/following{/other_user}","gists_url":"https://api.github.com/users/marsleezm/gists{/gist_id}","starred_url":"https://api.github.com/users/marsleezm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marsleezm/subscriptions","organizations_url":"https://api.github.com/users/marsleezm/orgs","repos_url":"https://api.github.com/users/marsleezm/repos","events_url":"https://api.github.com/users/marsleezm/events{/privacy}","received_events_url":"https://api.github.com/users/marsleezm/received_events","type":"User","site_admin":false},"body":"For my machine, having one supervisor gives higher throughput than having 100 supervisors (3600 compared with 2800). Maybe the multiple supervisor setting will give more throughput on machines with more cores, but our targeting benchmark machine will only have two cores, so I think it is more appropriate to use just 1 here.","created_at":"2015-05-14T16:22:59Z","updated_at":"2015-05-14T16:22:59Z","html_url":"https://github.com/SyncFree/antidote/pull/110#discussion_r30335591","pull_request_url":"https://api.github.com/repos/SyncFree/antidote/pulls/110","_links":{"self":{"href":"https://api.github.com/repos/SyncFree/antidote/pulls/comments/30335591"},"html":{"href":"https://github.com/SyncFree/antidote/pull/110#discussion_r30335591"},"pull_request":{"href":"https://api.github.com/repos/SyncFree/antidote/pulls/110"}}},"pull_request":{"url":"https://api.github.com/repos/SyncFree/antidote/pulls/110","id":35386734,"html_url":"https://github.com/SyncFree/antidote/pull/110","diff_url":"https://github.com/SyncFree/antidote/pull/110.diff","patch_url":"https://github.com/SyncFree/antidote/pull/110.patch","issue_url":"https://api.github.com/repos/SyncFree/antidote/issues/110","number":110,"state":"open","locked":false,"title":"Standalone static_tx_coord_fsm","user":{"login":"marsleezm","id":1566490,"avatar_url":"https://avatars.githubusercontent.com/u/1566490?v=3","gravatar_id":"","url":"https://api.github.com/users/marsleezm","html_url":"https://github.com/marsleezm","followers_url":"https://api.github.com/users/marsleezm/followers","following_url":"https://api.github.com/users/marsleezm/following{/other_user}","gists_url":"https://api.github.com/users/marsleezm/gists{/gist_id}","starred_url":"https://api.github.com/users/marsleezm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marsleezm/subscriptions","organizations_url":"https://api.github.com/users/marsleezm/orgs","repos_url":"https://api.github.com/users/marsleezm/repos","events_url":"https://api.github.com/users/marsleezm/events{/privacy}","received_events_url":"https://api.github.com/users/marsleezm/received_events","type":"User","site_admin":false},"body":"In the previous implementation, the operations of a transaction will firstly go to static_tx_coord_fsm and then be handled by interactive_tx_coord_fsm. This was designed for code reuse. However it is actually a performance bottleneck due to the cost of spawning extra fsm and communication cost between static and interactive fsm.\r\nIn this branch I integrated code from interactive_tx_coord_fsm to  static_tx_coord_fsm, so a static transaction is handled by static_tx_coord_fsm directly.\r\nThis has considerable performance improvement:\r\nThroughput of append increases from about 3100 op/s to 3600 op/s.\r\nMedium latency of append decreases from 6.3 ms to 5.6 ms.","created_at":"2015-05-14T01:25:29Z","updated_at":"2015-05-14T16:22:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f1265ed1e5ce7267a5916d404e91826cbe9e54c","assignee":{"login":"cmeiklejohn","id":44939,"avatar_url":"https://avatars.githubusercontent.com/u/44939?v=3","gravatar_id":"","url":"https://api.github.com/users/cmeiklejohn","html_url":"https://github.com/cmeiklejohn","followers_url":"https://api.github.com/users/cmeiklejohn/followers","following_url":"https://api.github.com/users/cmeiklejohn/following{/other_user}","gists_url":"https://api.github.com/users/cmeiklejohn/gists{/gist_id}","starred_url":"https://api.github.com/users/cmeiklejohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmeiklejohn/subscriptions","organizations_url":"https://api.github.com/users/cmeiklejohn/orgs","repos_url":"https://api.github.com/users/cmeiklejohn/repos","events_url":"https://api.github.com/users/cmeiklejohn/events{/privacy}","received_events_url":"https://api.github.com/users/cmeiklejohn/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/SyncFree/antidote/pulls/110/commits","review_comments_url":"https://api.github.com/repos/SyncFree/antidote/pulls/110/comments","review_comment_url":"https://api.github.com/repos/SyncFree/antidote/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SyncFree/antidote/issues/110/comments","statuses_url":"https://api.github.com/repos/SyncFree/antidote/statuses/3c666ed59e92f77fb6f3c2c68974f168468b1b59","head":{"label":"SyncFree:static_coord","ref":"static_coord","sha":"3c666ed59e92f77fb6f3c2c68974f168468b1b59","user":{"login":"SyncFree","id":6201424,"avatar_url":"https://avatars.githubusercontent.com/u/6201424?v=3","gravatar_id":"","url":"https://api.github.com/users/SyncFree","html_url":"https://github.com/SyncFree","followers_url":"https://api.github.com/users/SyncFree/followers","following_url":"https://api.github.com/users/SyncFree/following{/other_user}","gists_url":"https://api.github.com/users/SyncFree/gists{/gist_id}","starred_url":"https://api.github.com/users/SyncFree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SyncFree/subscriptions","organizations_url":"https://api.github.com/users/SyncFree/orgs","repos_url":"https://api.github.com/users/SyncFree/repos","events_url":"https://api.github.com/users/SyncFree/events{/privacy}","received_events_url":"https://api.github.com/users/SyncFree/received_events","type":"Organization","site_admin":false},"repo":{"id":17826843,"name":"antidote","full_name":"SyncFree/antidote","owner":{"login":"SyncFree","id":6201424,"avatar_url":"https://avatars.githubusercontent.com/u/6201424?v=3","gravatar_id":"","url":"https://api.github.com/users/SyncFree","html_url":"https://github.com/SyncFree","followers_url":"https://api.github.com/users/SyncFree/followers","following_url":"https://api.github.com/users/SyncFree/following{/other_user}","gists_url":"https://api.github.com/users/SyncFree/gists{/gist_id}","starred_url":"https://api.github.com/users/SyncFree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SyncFree/subscriptions","organizations_url":"https://api.github.com/users/SyncFree/orgs","repos_url":"https://api.github.com/users/SyncFree/repos","events_url":"https://api.github.com/users/SyncFree/events{/privacy}","received_events_url":"https://api.github.com/users/SyncFree/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SyncFree/antidote","description":"SyncFree Reference Platform","fork":false,"url":"https://api.github.com/repos/SyncFree/antidote","forks_url":"https://api.github.com/repos/SyncFree/antidote/forks","keys_url":"https://api.github.com/repos/SyncFree/antidote/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SyncFree/antidote/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SyncFree/antidote/teams","hooks_url":"https://api.github.com/repos/SyncFree/antidote/hooks","issue_events_url":"https://api.github.com/repos/SyncFree/antidote/issues/events{/number}","events_url":"https://api.github.com/repos/SyncFree/antidote/events","assignees_url":"https://api.github.com/repos/SyncFree/antidote/assignees{/user}","branches_url":"https://api.github.com/repos/SyncFree/antidote/branches{/branch}","tags_url":"https://api.github.com/repos/SyncFree/antidote/tags","blobs_url":"https://api.github.com/repos/SyncFree/antidote/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SyncFree/antidote/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SyncFree/antidote/git/refs{/sha}","trees_url":"https://api.github.com/repos/SyncFree/antidote/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SyncFree/antidote/statuses/{sha}","languages_url":"https://api.github.com/repos/SyncFree/antidote/languages","stargazers_url":"https://api.github.com/repos/SyncFree/antidote/stargazers","contributors_url":"https://api.github.com/repos/SyncFree/antidote/contributors","subscribers_url":"https://api.github.com/repos/SyncFree/antidote/subscribers","subscription_url":"https://api.github.com/repos/SyncFree/antidote/subscription","commits_url":"https://api.github.com/repos/SyncFree/antidote/commits{/sha}","git_commits_url":"https://api.github.com/repos/SyncFree/antidote/git/commits{/sha}","comments_url":"https://api.github.com/repos/SyncFree/antidote/comments{/number}","issue_comment_url":"https://api.github.com/repos/SyncFree/antidote/issues/comments{/number}","contents_url":"https://api.github.com/repos/SyncFree/antidote/contents/{+path}","compare_url":"https://api.github.com/repos/SyncFree/antidote/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SyncFree/antidote/merges","archive_url":"https://api.github.com/repos/SyncFree/antidote/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SyncFree/antidote/downloads","issues_url":"https://api.github.com/repos/SyncFree/antidote/issues{/number}","pulls_url":"https://api.github.com/repos/SyncFree/antidote/pulls{/number}","milestones_url":"https://api.github.com/repos/SyncFree/antidote/milestones{/number}","notifications_url":"https://api.github.com/repos/SyncFree/antidote/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SyncFree/antidote/labels{/name}","releases_url":"https://api.github.com/repos/SyncFree/antidote/releases{/id}","created_at":"2014-03-17T12:15:01Z","updated_at":"2015-05-12T17:32:46Z","pushed_at":"2015-05-14T10:48:36Z","git_url":"git://github.com/SyncFree/antidote.git","ssh_url":"git@github.com:SyncFree/antidote.git","clone_url":"https://github.com/SyncFree/antidote.git","svn_url":"https://github.com/SyncFree/antidote","homepage":"http://syncfree.lip6.fr","size":4894,"stargazers_count":24,"watchers_count":24,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":20,"forks":1,"open_issues":20,"watchers":24,"default_branch":"master"}},"base":{"label":"SyncFree:evaluation","ref":"evaluation","sha":"10c268e6b9a4d5fe2e4616dea212fe9ad9680b2d","user":{"login":"SyncFree","id":6201424,"avatar_url":"https://avatars.githubusercontent.com/u/6201424?v=3","gravatar_id":"","url":"https://api.github.com/users/SyncFree","html_url":"https://github.com/SyncFree","followers_url":"https://api.github.com/users/SyncFree/followers","following_url":"https://api.github.com/users/SyncFree/following{/other_user}","gists_url":"https://api.github.com/users/SyncFree/gists{/gist_id}","starred_url":"https://api.github.com/users/SyncFree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SyncFree/subscriptions","organizations_url":"https://api.github.com/users/SyncFree/orgs","repos_url":"https://api.github.com/users/SyncFree/repos","events_url":"https://api.github.com/users/SyncFree/events{/privacy}","received_events_url":"https://api.github.com/users/SyncFree/received_events","type":"Organization","site_admin":false},"repo":{"id":17826843,"name":"antidote","full_name":"SyncFree/antidote","owner":{"login":"SyncFree","id":6201424,"avatar_url":"https://avatars.githubusercontent.com/u/6201424?v=3","gravatar_id":"","url":"https://api.github.com/users/SyncFree","html_url":"https://github.com/SyncFree","followers_url":"https://api.github.com/users/SyncFree/followers","following_url":"https://api.github.com/users/SyncFree/following{/other_user}","gists_url":"https://api.github.com/users/SyncFree/gists{/gist_id}","starred_url":"https://api.github.com/users/SyncFree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SyncFree/subscriptions","organizations_url":"https://api.github.com/users/SyncFree/orgs","repos_url":"https://api.github.com/users/SyncFree/repos","events_url":"https://api.github.com/users/SyncFree/events{/privacy}","received_events_url":"https://api.github.com/users/SyncFree/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SyncFree/antidote","description":"SyncFree Reference Platform","fork":false,"url":"https://api.github.com/repos/SyncFree/antidote","forks_url":"https://api.github.com/repos/SyncFree/antidote/forks","keys_url":"https://api.github.com/repos/SyncFree/antidote/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SyncFree/antidote/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SyncFree/antidote/teams","hooks_url":"https://api.github.com/repos/SyncFree/antidote/hooks","issue_events_url":"https://api.github.com/repos/SyncFree/antidote/issues/events{/number}","events_url":"https://api.github.com/repos/SyncFree/antidote/events","assignees_url":"https://api.github.com/repos/SyncFree/antidote/assignees{/user}","branches_url":"https://api.github.com/repos/SyncFree/antidote/branches{/branch}","tags_url":"https://api.github.com/repos/SyncFree/antidote/tags","blobs_url":"https://api.github.com/repos/SyncFree/antidote/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SyncFree/antidote/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SyncFree/antidote/git/refs{/sha}","trees_url":"https://api.github.com/repos/SyncFree/antidote/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SyncFree/antidote/statuses/{sha}","languages_url":"https://api.github.com/repos/SyncFree/antidote/languages","stargazers_url":"https://api.github.com/repos/SyncFree/antidote/stargazers","contributors_url":"https://api.github.com/repos/SyncFree/antidote/contributors","subscribers_url":"https://api.github.com/repos/SyncFree/antidote/subscribers","subscription_url":"https://api.github.com/repos/SyncFree/antidote/subscription","commits_url":"https://api.github.com/repos/SyncFree/antidote/commits{/sha}","git_commits_url":"https://api.github.com/repos/SyncFree/antidote/git/commits{/sha}","comments_url":"https://api.github.com/repos/SyncFree/antidote/comments{/number}","issue_comment_url":"https://api.github.com/repos/SyncFree/antidote/issues/comments{/number}","contents_url":"https://api.github.com/repos/SyncFree/antidote/contents/{+path}","compare_url":"https://api.github.com/repos/SyncFree/antidote/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SyncFree/antidote/merges","archive_url":"https://api.github.com/repos/SyncFree/antidote/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SyncFree/antidote/downloads","issues_url":"https://api.github.com/repos/SyncFree/antidote/issues{/number}","pulls_url":"https://api.github.com/repos/SyncFree/antidote/pulls{/number}","milestones_url":"https://api.github.com/repos/SyncFree/antidote/milestones{/number}","notifications_url":"https://api.github.com/repos/SyncFree/antidote/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SyncFree/antidote/labels{/name}","releases_url":"https://api.github.com/repos/SyncFree/antidote/releases{/id}","created_at":"2014-03-17T12:15:01Z","updated_at":"2015-05-12T17:32:46Z","pushed_at":"2015-05-14T10:48:36Z","git_url":"git://github.com/SyncFree/antidote.git","ssh_url":"git@github.com:SyncFree/antidote.git","clone_url":"https://github.com/SyncFree/antidote.git","svn_url":"https://github.com/SyncFree/antidote","homepage":"http://syncfree.lip6.fr","size":4894,"stargazers_count":24,"watchers_count":24,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":20,"forks":1,"open_issues":20,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SyncFree/antidote/pulls/110"},"html":{"href":"https://github.com/SyncFree/antidote/pull/110"},"issue":{"href":"https://api.github.com/repos/SyncFree/antidote/issues/110"},"comments":{"href":"https://api.github.com/repos/SyncFree/antidote/issues/110/comments"},"review_comments":{"href":"https://api.github.com/repos/SyncFree/antidote/pulls/110/comments"},"review_comment":{"href":"https://api.github.com/repos/SyncFree/antidote/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SyncFree/antidote/pulls/110/commits"},"statuses":{"href":"https://api.github.com/repos/SyncFree/antidote/statuses/3c666ed59e92f77fb6f3c2c68974f168468b1b59"}}}}