{"action":"created","issue":{"url":"https://api.github.com/repos/vtsuperdarn/davitpy/issues/149","labels_url":"https://api.github.com/repos/vtsuperdarn/davitpy/issues/149/labels{/name}","comments_url":"https://api.github.com/repos/vtsuperdarn/davitpy/issues/149/comments","events_url":"https://api.github.com/repos/vtsuperdarn/davitpy/issues/149/events","html_url":"https://github.com/vtsuperdarn/davitpy/pull/149","id":107105969,"number":149,"title":"RTI Plotting Refactoring","user":{"login":"asreimer","id":4604819,"avatar_url":"https://avatars.githubusercontent.com/u/4604819?v=3","gravatar_id":"","url":"https://api.github.com/users/asreimer","html_url":"https://github.com/asreimer","followers_url":"https://api.github.com/users/asreimer/followers","following_url":"https://api.github.com/users/asreimer/following{/other_user}","gists_url":"https://api.github.com/users/asreimer/gists{/gist_id}","starred_url":"https://api.github.com/users/asreimer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asreimer/subscriptions","organizations_url":"https://api.github.com/users/asreimer/orgs","repos_url":"https://api.github.com/users/asreimer/repos","events_url":"https://api.github.com/users/asreimer/events{/privacy}","received_events_url":"https://api.github.com/users/asreimer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-09-18T00:17:08Z","updated_at":"2015-09-18T20:24:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vtsuperdarn/davitpy/pulls/149","html_url":"https://github.com/vtsuperdarn/davitpy/pull/149","diff_url":"https://github.com/vtsuperdarn/davitpy/pull/149.diff","patch_url":"https://github.com/vtsuperdarn/davitpy/pull/149.patch"},"body":"This pull request fixes a few issues with the RTI plotting and also refactors the code into a more modular form. The refactoring allows one to make custom RTI plots much more easily than could be done in the past. \r\n\r\nOne major issue that has been fixed is the x-axis labeling. Time is now properly displayed and formatted according to whether the data crosses changes in date or multiple days.\r\n\r\nSome variable names have been updated, but to prevent this from breaking anyone's existing code I've added a deprecation warning and a temporary wrapper. Specifically, `plotRti` is being deprecated in favour of `plot_rti`.\r\n\r\nTo test this code run the following 3 commands and compare your figures with mine:\r\n\r\n1) `f = pydarn.plotting.plotRti(datetime(2012,11,26,15),'kod',eTime=datetime(2012,11,27,2),channel='all',params=['velocity','velocity_error'],coords='mag')`\r\n\r\nyou should see a deprecation warning too!\r\n\r\n2) `f = pydarn.plotting.plot_rti(datetime(2012,11,25),'kod',eTime=datetime(2012,11,27),channel='all',params=['velocity','velocity_error'],coords='gate')`\r\n\r\n3) `f = pydarn.plotting.plotRti(datetime(2012,11,25),'kod',eTime=datetime(2012,11,25,15),channel='all',params=['power'],coords='geo')`\r\n\r\n1)\r\n![figure_1](https://cloud.githubusercontent.com/assets/4604819/9949239/0f7911dc-5d68-11e5-94fa-d5bbaa7411e3.png)\r\n2) \r\n![figure_2](https://cloud.githubusercontent.com/assets/4604819/9949240/0f7a14d8-5d68-11e5-8543-bfc25d046b97.png)\r\n3)\r\n![figure_3](https://cloud.githubusercontent.com/assets/4604819/9949241/0f7b8142-5d68-11e5-9234-987ac6725a0a.png)\r\n"},"comment":{"url":"https://api.github.com/repos/vtsuperdarn/davitpy/issues/comments/141557817","html_url":"https://github.com/vtsuperdarn/davitpy/pull/149#issuecomment-141557817","issue_url":"https://api.github.com/repos/vtsuperdarn/davitpy/issues/149","id":141557817,"user":{"login":"asreimer","id":4604819,"avatar_url":"https://avatars.githubusercontent.com/u/4604819?v=3","gravatar_id":"","url":"https://api.github.com/users/asreimer","html_url":"https://github.com/asreimer","followers_url":"https://api.github.com/users/asreimer/followers","following_url":"https://api.github.com/users/asreimer/following{/other_user}","gists_url":"https://api.github.com/users/asreimer/gists{/gist_id}","starred_url":"https://api.github.com/users/asreimer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asreimer/subscriptions","organizations_url":"https://api.github.com/users/asreimer/orgs","repos_url":"https://api.github.com/users/asreimer/repos","events_url":"https://api.github.com/users/asreimer/events{/privacy}","received_events_url":"https://api.github.com/users/asreimer/received_events","type":"User","site_admin":false},"created_at":"2015-09-18T20:24:44Z","updated_at":"2015-09-18T20:24:44Z","body":"Hey @MuhammadVT \r\n\r\nThe bug you found is not a bug, however, the asserts could be clearer. I've added an assert that makes sure that scales is input they way it needs to be, but provides a clear error message if it isn't.\r\n\r\nI have modified the formatting for the yaxis on the RTI panels. Should be better now!"}}