{"action":"created","comment":{"url":"https://api.github.com/repos/PowerShell/xNetworking/pulls/comments/31184296","id":31184296,"diff_hunk":"@@ -0,0 +1,15 @@\n+Remove-Module -Name MSFT_xFirewall -Force -ErrorAction SilentlyContinue\n+Import-Module -Name $PSScriptRoot\\..\\DSCResources\\MSFT_xFirewall -Force -DisableNameChecking\n+\n+if (! (Get-Module xDSCResourceDesigner))\n+{\n+    Import-Module -Name xDSCResourceDesigner -ErrorAction SilentlyContinue\n+}\n+\n+Describe 'Schema Validation for MSFT_xFirewall' {\n+    Copy-Item -Path ((get-item .).parent.FullName) -Destination $(Join-Path -Path $env:ProgramFiles -ChildPath 'WindowsPowerShell\\Modules\\') -Force -Recurse\n+    $result = Test-xDscResource MSFT_xFirewall","path":"Tests/MSFT_xFirewall.Tests.ps1","position":11,"original_position":11,"commit_id":"b1ee7d5610e9efe5f9f4ff38a8b613501c4da28c","original_commit_id":"b1ee7d5610e9efe5f9f4ff38a8b613501c4da28c","user":{"login":"TravisEz13","id":10873629,"avatar_url":"https://avatars.githubusercontent.com/u/10873629?v=3","gravatar_id":"","url":"https://api.github.com/users/TravisEz13","html_url":"https://github.com/TravisEz13","followers_url":"https://api.github.com/users/TravisEz13/followers","following_url":"https://api.github.com/users/TravisEz13/following{/other_user}","gists_url":"https://api.github.com/users/TravisEz13/gists{/gist_id}","starred_url":"https://api.github.com/users/TravisEz13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TravisEz13/subscriptions","organizations_url":"https://api.github.com/users/TravisEz13/orgs","repos_url":"https://api.github.com/users/TravisEz13/repos","events_url":"https://api.github.com/users/TravisEz13/events{/privacy}","received_events_url":"https://api.github.com/users/TravisEz13/received_events","type":"User","site_admin":false},"body":"Suggestion: It's better to run what you are testing in side the it","created_at":"2015-05-27T21:46:53Z","updated_at":"2015-05-27T21:46:53Z","html_url":"https://github.com/PowerShell/xNetworking/pull/4#discussion_r31184296","pull_request_url":"https://api.github.com/repos/PowerShell/xNetworking/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/PowerShell/xNetworking/pulls/comments/31184296"},"html":{"href":"https://github.com/PowerShell/xNetworking/pull/4#discussion_r31184296"},"pull_request":{"href":"https://api.github.com/repos/PowerShell/xNetworking/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/PowerShell/xNetworking/pulls/4","id":36058431,"html_url":"https://github.com/PowerShell/xNetworking/pull/4","diff_url":"https://github.com/PowerShell/xNetworking/pull/4.diff","patch_url":"https://github.com/PowerShell/xNetworking/pull/4.patch","issue_url":"https://api.github.com/repos/PowerShell/xNetworking/issues/4","number":4,"state":"open","locked":false,"title":"xNetworking Validation fixes","user":{"login":"tysonjhayes","id":651851,"avatar_url":"https://avatars.githubusercontent.com/u/651851?v=3","gravatar_id":"","url":"https://api.github.com/users/tysonjhayes","html_url":"https://github.com/tysonjhayes","followers_url":"https://api.github.com/users/tysonjhayes/followers","following_url":"https://api.github.com/users/tysonjhayes/following{/other_user}","gists_url":"https://api.github.com/users/tysonjhayes/gists{/gist_id}","starred_url":"https://api.github.com/users/tysonjhayes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tysonjhayes/subscriptions","organizations_url":"https://api.github.com/users/tysonjhayes/orgs","repos_url":"https://api.github.com/users/tysonjhayes/repos","events_url":"https://api.github.com/users/tysonjhayes/events{/privacy}","received_events_url":"https://api.github.com/users/tysonjhayes/received_events","type":"User","site_admin":false},"body":"Right now xNetworking resource does not pass the Test-xDSCResource function. This is an attempt to correct this as the validateset for an array will blow up when you attempt to apply it.\r\n\r\nI've made a big assumption that we can import xDSCResourceDesigner for the Pester tests as I have no desire to re-write the funciton just to test this. :+1: ","created_at":"2015-05-22T18:47:09Z","updated_at":"2015-05-27T21:46:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4f41d3135f826758c3dccc7947cca79902a1804","assignee":{"login":"TravisEz13","id":10873629,"avatar_url":"https://avatars.githubusercontent.com/u/10873629?v=3","gravatar_id":"","url":"https://api.github.com/users/TravisEz13","html_url":"https://github.com/TravisEz13","followers_url":"https://api.github.com/users/TravisEz13/followers","following_url":"https://api.github.com/users/TravisEz13/following{/other_user}","gists_url":"https://api.github.com/users/TravisEz13/gists{/gist_id}","starred_url":"https://api.github.com/users/TravisEz13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TravisEz13/subscriptions","organizations_url":"https://api.github.com/users/TravisEz13/orgs","repos_url":"https://api.github.com/users/TravisEz13/repos","events_url":"https://api.github.com/users/TravisEz13/events{/privacy}","received_events_url":"https://api.github.com/users/TravisEz13/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/PowerShell/xNetworking/pulls/4/commits","review_comments_url":"https://api.github.com/repos/PowerShell/xNetworking/pulls/4/comments","review_comment_url":"https://api.github.com/repos/PowerShell/xNetworking/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PowerShell/xNetworking/issues/4/comments","statuses_url":"https://api.github.com/repos/PowerShell/xNetworking/statuses/b1ee7d5610e9efe5f9f4ff38a8b613501c4da28c","head":{"label":"tysonjhayes:validation-fixes","ref":"validation-fixes","sha":"b1ee7d5610e9efe5f9f4ff38a8b613501c4da28c","user":{"login":"tysonjhayes","id":651851,"avatar_url":"https://avatars.githubusercontent.com/u/651851?v=3","gravatar_id":"","url":"https://api.github.com/users/tysonjhayes","html_url":"https://github.com/tysonjhayes","followers_url":"https://api.github.com/users/tysonjhayes/followers","following_url":"https://api.github.com/users/tysonjhayes/following{/other_user}","gists_url":"https://api.github.com/users/tysonjhayes/gists{/gist_id}","starred_url":"https://api.github.com/users/tysonjhayes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tysonjhayes/subscriptions","organizations_url":"https://api.github.com/users/tysonjhayes/orgs","repos_url":"https://api.github.com/users/tysonjhayes/repos","events_url":"https://api.github.com/users/tysonjhayes/events{/privacy}","received_events_url":"https://api.github.com/users/tysonjhayes/received_events","type":"User","site_admin":false},"repo":{"id":36088772,"name":"xNetworking","full_name":"tysonjhayes/xNetworking","owner":{"login":"tysonjhayes","id":651851,"avatar_url":"https://avatars.githubusercontent.com/u/651851?v=3","gravatar_id":"","url":"https://api.github.com/users/tysonjhayes","html_url":"https://github.com/tysonjhayes","followers_url":"https://api.github.com/users/tysonjhayes/followers","following_url":"https://api.github.com/users/tysonjhayes/following{/other_user}","gists_url":"https://api.github.com/users/tysonjhayes/gists{/gist_id}","starred_url":"https://api.github.com/users/tysonjhayes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tysonjhayes/subscriptions","organizations_url":"https://api.github.com/users/tysonjhayes/orgs","repos_url":"https://api.github.com/users/tysonjhayes/repos","events_url":"https://api.github.com/users/tysonjhayes/events{/privacy}","received_events_url":"https://api.github.com/users/tysonjhayes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tysonjhayes/xNetworking","description":null,"fork":true,"url":"https://api.github.com/repos/tysonjhayes/xNetworking","forks_url":"https://api.github.com/repos/tysonjhayes/xNetworking/forks","keys_url":"https://api.github.com/repos/tysonjhayes/xNetworking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tysonjhayes/xNetworking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tysonjhayes/xNetworking/teams","hooks_url":"https://api.github.com/repos/tysonjhayes/xNetworking/hooks","issue_events_url":"https://api.github.com/repos/tysonjhayes/xNetworking/issues/events{/number}","events_url":"https://api.github.com/repos/tysonjhayes/xNetworking/events","assignees_url":"https://api.github.com/repos/tysonjhayes/xNetworking/assignees{/user}","branches_url":"https://api.github.com/repos/tysonjhayes/xNetworking/branches{/branch}","tags_url":"https://api.github.com/repos/tysonjhayes/xNetworking/tags","blobs_url":"https://api.github.com/repos/tysonjhayes/xNetworking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tysonjhayes/xNetworking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tysonjhayes/xNetworking/git/refs{/sha}","trees_url":"https://api.github.com/repos/tysonjhayes/xNetworking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tysonjhayes/xNetworking/statuses/{sha}","languages_url":"https://api.github.com/repos/tysonjhayes/xNetworking/languages","stargazers_url":"https://api.github.com/repos/tysonjhayes/xNetworking/stargazers","contributors_url":"https://api.github.com/repos/tysonjhayes/xNetworking/contributors","subscribers_url":"https://api.github.com/repos/tysonjhayes/xNetworking/subscribers","subscription_url":"https://api.github.com/repos/tysonjhayes/xNetworking/subscription","commits_url":"https://api.github.com/repos/tysonjhayes/xNetworking/commits{/sha}","git_commits_url":"https://api.github.com/repos/tysonjhayes/xNetworking/git/commits{/sha}","comments_url":"https://api.github.com/repos/tysonjhayes/xNetworking/comments{/number}","issue_comment_url":"https://api.github.com/repos/tysonjhayes/xNetworking/issues/comments{/number}","contents_url":"https://api.github.com/repos/tysonjhayes/xNetworking/contents/{+path}","compare_url":"https://api.github.com/repos/tysonjhayes/xNetworking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tysonjhayes/xNetworking/merges","archive_url":"https://api.github.com/repos/tysonjhayes/xNetworking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tysonjhayes/xNetworking/downloads","issues_url":"https://api.github.com/repos/tysonjhayes/xNetworking/issues{/number}","pulls_url":"https://api.github.com/repos/tysonjhayes/xNetworking/pulls{/number}","milestones_url":"https://api.github.com/repos/tysonjhayes/xNetworking/milestones{/number}","notifications_url":"https://api.github.com/repos/tysonjhayes/xNetworking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tysonjhayes/xNetworking/labels{/name}","releases_url":"https://api.github.com/repos/tysonjhayes/xNetworking/releases{/id}","created_at":"2015-05-22T18:31:19Z","updated_at":"2015-05-22T18:31:19Z","pushed_at":"2015-05-27T18:08:38Z","git_url":"git://github.com/tysonjhayes/xNetworking.git","ssh_url":"git@github.com:tysonjhayes/xNetworking.git","clone_url":"https://github.com/tysonjhayes/xNetworking.git","svn_url":"https://github.com/tysonjhayes/xNetworking","homepage":null,"size":107,"stargazers_count":0,"watchers_count":0,"language":"PowerShell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PowerShell:dev","ref":"dev","sha":"5112ee4dc894993bdb10834588dd45e657e9f6ef","user":{"login":"PowerShell","id":11524380,"avatar_url":"https://avatars.githubusercontent.com/u/11524380?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"repo":{"id":34022240,"name":"xNetworking","full_name":"PowerShell/xNetworking","owner":{"login":"PowerShell","id":11524380,"avatar_url":"https://avatars.githubusercontent.com/u/11524380?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PowerShell/xNetworking","description":null,"fork":false,"url":"https://api.github.com/repos/PowerShell/xNetworking","forks_url":"https://api.github.com/repos/PowerShell/xNetworking/forks","keys_url":"https://api.github.com/repos/PowerShell/xNetworking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PowerShell/xNetworking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PowerShell/xNetworking/teams","hooks_url":"https://api.github.com/repos/PowerShell/xNetworking/hooks","issue_events_url":"https://api.github.com/repos/PowerShell/xNetworking/issues/events{/number}","events_url":"https://api.github.com/repos/PowerShell/xNetworking/events","assignees_url":"https://api.github.com/repos/PowerShell/xNetworking/assignees{/user}","branches_url":"https://api.github.com/repos/PowerShell/xNetworking/branches{/branch}","tags_url":"https://api.github.com/repos/PowerShell/xNetworking/tags","blobs_url":"https://api.github.com/repos/PowerShell/xNetworking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PowerShell/xNetworking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PowerShell/xNetworking/git/refs{/sha}","trees_url":"https://api.github.com/repos/PowerShell/xNetworking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PowerShell/xNetworking/statuses/{sha}","languages_url":"https://api.github.com/repos/PowerShell/xNetworking/languages","stargazers_url":"https://api.github.com/repos/PowerShell/xNetworking/stargazers","contributors_url":"https://api.github.com/repos/PowerShell/xNetworking/contributors","subscribers_url":"https://api.github.com/repos/PowerShell/xNetworking/subscribers","subscription_url":"https://api.github.com/repos/PowerShell/xNetworking/subscription","commits_url":"https://api.github.com/repos/PowerShell/xNetworking/commits{/sha}","git_commits_url":"https://api.github.com/repos/PowerShell/xNetworking/git/commits{/sha}","comments_url":"https://api.github.com/repos/PowerShell/xNetworking/comments{/number}","issue_comment_url":"https://api.github.com/repos/PowerShell/xNetworking/issues/comments{/number}","contents_url":"https://api.github.com/repos/PowerShell/xNetworking/contents/{+path}","compare_url":"https://api.github.com/repos/PowerShell/xNetworking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PowerShell/xNetworking/merges","archive_url":"https://api.github.com/repos/PowerShell/xNetworking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PowerShell/xNetworking/downloads","issues_url":"https://api.github.com/repos/PowerShell/xNetworking/issues{/number}","pulls_url":"https://api.github.com/repos/PowerShell/xNetworking/pulls{/number}","milestones_url":"https://api.github.com/repos/PowerShell/xNetworking/milestones{/number}","notifications_url":"https://api.github.com/repos/PowerShell/xNetworking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PowerShell/xNetworking/labels{/name}","releases_url":"https://api.github.com/repos/PowerShell/xNetworking/releases{/id}","created_at":"2015-04-15T22:43:02Z","updated_at":"2015-04-23T22:52:20Z","pushed_at":"2015-05-27T18:08:39Z","git_url":"git://github.com/PowerShell/xNetworking.git","ssh_url":"git@github.com:PowerShell/xNetworking.git","clone_url":"https://github.com/PowerShell/xNetworking.git","svn_url":"https://github.com/PowerShell/xNetworking","homepage":null,"size":215,"stargazers_count":0,"watchers_count":0,"language":"PowerShell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PowerShell/xNetworking/pulls/4"},"html":{"href":"https://github.com/PowerShell/xNetworking/pull/4"},"issue":{"href":"https://api.github.com/repos/PowerShell/xNetworking/issues/4"},"comments":{"href":"https://api.github.com/repos/PowerShell/xNetworking/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/PowerShell/xNetworking/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/PowerShell/xNetworking/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PowerShell/xNetworking/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/PowerShell/xNetworking/statuses/b1ee7d5610e9efe5f9f4ff38a8b613501c4da28c"}}}}