{"action":"closed","number":21,"pull_request":{"url":"https://api.github.com/repos/alliedmodders/metamod-source/pulls/21","id":45975561,"html_url":"https://github.com/alliedmodders/metamod-source/pull/21","diff_url":"https://github.com/alliedmodders/metamod-source/pull/21.diff","patch_url":"https://github.com/alliedmodders/metamod-source/pull/21.patch","issue_url":"https://api.github.com/repos/alliedmodders/metamod-source/issues/21","number":21,"state":"closed","locked":false,"title":"Fix testvphooks.","user":{"login":"dvander","id":865306,"avatar_url":"https://avatars.githubusercontent.com/u/865306?v=3","gravatar_id":"","url":"https://api.github.com/users/dvander","html_url":"https://github.com/dvander","followers_url":"https://api.github.com/users/dvander/followers","following_url":"https://api.github.com/users/dvander/following{/other_user}","gists_url":"https://api.github.com/users/dvander/gists{/gist_id}","starred_url":"https://api.github.com/users/dvander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvander/subscriptions","organizations_url":"https://api.github.com/users/dvander/orgs","repos_url":"https://api.github.com/users/dvander/repos","events_url":"https://api.github.com/users/dvander/events{/privacy}","received_events_url":"https://api.github.com/users/dvander/received_events","type":"User","site_admin":false},"body":"It looks like clang has some kind of weird analysis that takes away a virtual function call, having deduced that it is always safe to bypass it. That's true here, which is a bad sign for SourceHook - but for the purposes of testing, we can defeat the analysis by introducing fake uncertainty (I used `time(NULL) != 0` here).\r\n\r\nI say \"weird\" because, this analysis should apply to at least one more variable in this function (`p_d2i1`), but for some reason it doesn't. Whatever.","created_at":"2015-09-25T04:08:30Z","updated_at":"2015-09-25T04:38:42Z","closed_at":"2015-09-25T04:38:42Z","merged_at":"2015-09-25T04:38:42Z","merge_commit_sha":"3bd5957597734a80af5ca9ec9f1a9fc42b32378b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alliedmodders/metamod-source/pulls/21/commits","review_comments_url":"https://api.github.com/repos/alliedmodders/metamod-source/pulls/21/comments","review_comment_url":"https://api.github.com/repos/alliedmodders/metamod-source/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alliedmodders/metamod-source/issues/21/comments","statuses_url":"https://api.github.com/repos/alliedmodders/metamod-source/statuses/219cd7203fa7985ee751750030c6b62c90112f1c","head":{"label":"alliedmodders:fix-vphook-test","ref":"fix-vphook-test","sha":"219cd7203fa7985ee751750030c6b62c90112f1c","user":{"login":"alliedmodders","id":6601917,"avatar_url":"https://avatars.githubusercontent.com/u/6601917?v=3","gravatar_id":"","url":"https://api.github.com/users/alliedmodders","html_url":"https://github.com/alliedmodders","followers_url":"https://api.github.com/users/alliedmodders/followers","following_url":"https://api.github.com/users/alliedmodders/following{/other_user}","gists_url":"https://api.github.com/users/alliedmodders/gists{/gist_id}","starred_url":"https://api.github.com/users/alliedmodders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alliedmodders/subscriptions","organizations_url":"https://api.github.com/users/alliedmodders/orgs","repos_url":"https://api.github.com/users/alliedmodders/repos","events_url":"https://api.github.com/users/alliedmodders/events{/privacy}","received_events_url":"https://api.github.com/users/alliedmodders/received_events","type":"Organization","site_admin":false},"repo":{"id":20146565,"name":"metamod-source","full_name":"alliedmodders/metamod-source","owner":{"login":"alliedmodders","id":6601917,"avatar_url":"https://avatars.githubusercontent.com/u/6601917?v=3","gravatar_id":"","url":"https://api.github.com/users/alliedmodders","html_url":"https://github.com/alliedmodders","followers_url":"https://api.github.com/users/alliedmodders/followers","following_url":"https://api.github.com/users/alliedmodders/following{/other_user}","gists_url":"https://api.github.com/users/alliedmodders/gists{/gist_id}","starred_url":"https://api.github.com/users/alliedmodders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alliedmodders/subscriptions","organizations_url":"https://api.github.com/users/alliedmodders/orgs","repos_url":"https://api.github.com/users/alliedmodders/repos","events_url":"https://api.github.com/users/alliedmodders/events{/privacy}","received_events_url":"https://api.github.com/users/alliedmodders/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alliedmodders/metamod-source","description":"Metamod:Source - C++ Plugin Environment and Detour Library for the Source Engine","fork":false,"url":"https://api.github.com/repos/alliedmodders/metamod-source","forks_url":"https://api.github.com/repos/alliedmodders/metamod-source/forks","keys_url":"https://api.github.com/repos/alliedmodders/metamod-source/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alliedmodders/metamod-source/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alliedmodders/metamod-source/teams","hooks_url":"https://api.github.com/repos/alliedmodders/metamod-source/hooks","issue_events_url":"https://api.github.com/repos/alliedmodders/metamod-source/issues/events{/number}","events_url":"https://api.github.com/repos/alliedmodders/metamod-source/events","assignees_url":"https://api.github.com/repos/alliedmodders/metamod-source/assignees{/user}","branches_url":"https://api.github.com/repos/alliedmodders/metamod-source/branches{/branch}","tags_url":"https://api.github.com/repos/alliedmodders/metamod-source/tags","blobs_url":"https://api.github.com/repos/alliedmodders/metamod-source/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alliedmodders/metamod-source/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alliedmodders/metamod-source/git/refs{/sha}","trees_url":"https://api.github.com/repos/alliedmodders/metamod-source/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alliedmodders/metamod-source/statuses/{sha}","languages_url":"https://api.github.com/repos/alliedmodders/metamod-source/languages","stargazers_url":"https://api.github.com/repos/alliedmodders/metamod-source/stargazers","contributors_url":"https://api.github.com/repos/alliedmodders/metamod-source/contributors","subscribers_url":"https://api.github.com/repos/alliedmodders/metamod-source/subscribers","subscription_url":"https://api.github.com/repos/alliedmodders/metamod-source/subscription","commits_url":"https://api.github.com/repos/alliedmodders/metamod-source/commits{/sha}","git_commits_url":"https://api.github.com/repos/alliedmodders/metamod-source/git/commits{/sha}","comments_url":"https://api.github.com/repos/alliedmodders/metamod-source/comments{/number}","issue_comment_url":"https://api.github.com/repos/alliedmodders/metamod-source/issues/comments{/number}","contents_url":"https://api.github.com/repos/alliedmodders/metamod-source/contents/{+path}","compare_url":"https://api.github.com/repos/alliedmodders/metamod-source/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alliedmodders/metamod-source/merges","archive_url":"https://api.github.com/repos/alliedmodders/metamod-source/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alliedmodders/metamod-source/downloads","issues_url":"https://api.github.com/repos/alliedmodders/metamod-source/issues{/number}","pulls_url":"https://api.github.com/repos/alliedmodders/metamod-source/pulls{/number}","milestones_url":"https://api.github.com/repos/alliedmodders/metamod-source/milestones{/number}","notifications_url":"https://api.github.com/repos/alliedmodders/metamod-source/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alliedmodders/metamod-source/labels{/name}","releases_url":"https://api.github.com/repos/alliedmodders/metamod-source/releases{/id}","created_at":"2014-05-25T04:30:31Z","updated_at":"2015-09-12T23:47:43Z","pushed_at":"2015-09-25T04:38:42Z","git_url":"git://github.com/alliedmodders/metamod-source.git","ssh_url":"git@github.com:alliedmodders/metamod-source.git","clone_url":"https://github.com/alliedmodders/metamod-source.git","svn_url":"https://github.com/alliedmodders/metamod-source","homepage":"http://www.metamodsource.net/","size":15184,"stargazers_count":49,"watchers_count":49,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":1,"forks":11,"open_issues":1,"watchers":49,"default_branch":"master"}},"base":{"label":"alliedmodders:master","ref":"master","sha":"93022964625597b12814b6d303f13a19b9039e04","user":{"login":"alliedmodders","id":6601917,"avatar_url":"https://avatars.githubusercontent.com/u/6601917?v=3","gravatar_id":"","url":"https://api.github.com/users/alliedmodders","html_url":"https://github.com/alliedmodders","followers_url":"https://api.github.com/users/alliedmodders/followers","following_url":"https://api.github.com/users/alliedmodders/following{/other_user}","gists_url":"https://api.github.com/users/alliedmodders/gists{/gist_id}","starred_url":"https://api.github.com/users/alliedmodders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alliedmodders/subscriptions","organizations_url":"https://api.github.com/users/alliedmodders/orgs","repos_url":"https://api.github.com/users/alliedmodders/repos","events_url":"https://api.github.com/users/alliedmodders/events{/privacy}","received_events_url":"https://api.github.com/users/alliedmodders/received_events","type":"Organization","site_admin":false},"repo":{"id":20146565,"name":"metamod-source","full_name":"alliedmodders/metamod-source","owner":{"login":"alliedmodders","id":6601917,"avatar_url":"https://avatars.githubusercontent.com/u/6601917?v=3","gravatar_id":"","url":"https://api.github.com/users/alliedmodders","html_url":"https://github.com/alliedmodders","followers_url":"https://api.github.com/users/alliedmodders/followers","following_url":"https://api.github.com/users/alliedmodders/following{/other_user}","gists_url":"https://api.github.com/users/alliedmodders/gists{/gist_id}","starred_url":"https://api.github.com/users/alliedmodders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alliedmodders/subscriptions","organizations_url":"https://api.github.com/users/alliedmodders/orgs","repos_url":"https://api.github.com/users/alliedmodders/repos","events_url":"https://api.github.com/users/alliedmodders/events{/privacy}","received_events_url":"https://api.github.com/users/alliedmodders/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alliedmodders/metamod-source","description":"Metamod:Source - C++ Plugin Environment and Detour Library for the Source Engine","fork":false,"url":"https://api.github.com/repos/alliedmodders/metamod-source","forks_url":"https://api.github.com/repos/alliedmodders/metamod-source/forks","keys_url":"https://api.github.com/repos/alliedmodders/metamod-source/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alliedmodders/metamod-source/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alliedmodders/metamod-source/teams","hooks_url":"https://api.github.com/repos/alliedmodders/metamod-source/hooks","issue_events_url":"https://api.github.com/repos/alliedmodders/metamod-source/issues/events{/number}","events_url":"https://api.github.com/repos/alliedmodders/metamod-source/events","assignees_url":"https://api.github.com/repos/alliedmodders/metamod-source/assignees{/user}","branches_url":"https://api.github.com/repos/alliedmodders/metamod-source/branches{/branch}","tags_url":"https://api.github.com/repos/alliedmodders/metamod-source/tags","blobs_url":"https://api.github.com/repos/alliedmodders/metamod-source/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alliedmodders/metamod-source/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alliedmodders/metamod-source/git/refs{/sha}","trees_url":"https://api.github.com/repos/alliedmodders/metamod-source/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alliedmodders/metamod-source/statuses/{sha}","languages_url":"https://api.github.com/repos/alliedmodders/metamod-source/languages","stargazers_url":"https://api.github.com/repos/alliedmodders/metamod-source/stargazers","contributors_url":"https://api.github.com/repos/alliedmodders/metamod-source/contributors","subscribers_url":"https://api.github.com/repos/alliedmodders/metamod-source/subscribers","subscription_url":"https://api.github.com/repos/alliedmodders/metamod-source/subscription","commits_url":"https://api.github.com/repos/alliedmodders/metamod-source/commits{/sha}","git_commits_url":"https://api.github.com/repos/alliedmodders/metamod-source/git/commits{/sha}","comments_url":"https://api.github.com/repos/alliedmodders/metamod-source/comments{/number}","issue_comment_url":"https://api.github.com/repos/alliedmodders/metamod-source/issues/comments{/number}","contents_url":"https://api.github.com/repos/alliedmodders/metamod-source/contents/{+path}","compare_url":"https://api.github.com/repos/alliedmodders/metamod-source/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alliedmodders/metamod-source/merges","archive_url":"https://api.github.com/repos/alliedmodders/metamod-source/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alliedmodders/metamod-source/downloads","issues_url":"https://api.github.com/repos/alliedmodders/metamod-source/issues{/number}","pulls_url":"https://api.github.com/repos/alliedmodders/metamod-source/pulls{/number}","milestones_url":"https://api.github.com/repos/alliedmodders/metamod-source/milestones{/number}","notifications_url":"https://api.github.com/repos/alliedmodders/metamod-source/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alliedmodders/metamod-source/labels{/name}","releases_url":"https://api.github.com/repos/alliedmodders/metamod-source/releases{/id}","created_at":"2014-05-25T04:30:31Z","updated_at":"2015-09-12T23:47:43Z","pushed_at":"2015-09-25T04:38:42Z","git_url":"git://github.com/alliedmodders/metamod-source.git","ssh_url":"git@github.com:alliedmodders/metamod-source.git","clone_url":"https://github.com/alliedmodders/metamod-source.git","svn_url":"https://github.com/alliedmodders/metamod-source","homepage":"http://www.metamodsource.net/","size":15184,"stargazers_count":49,"watchers_count":49,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":1,"forks":11,"open_issues":1,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alliedmodders/metamod-source/pulls/21"},"html":{"href":"https://github.com/alliedmodders/metamod-source/pull/21"},"issue":{"href":"https://api.github.com/repos/alliedmodders/metamod-source/issues/21"},"comments":{"href":"https://api.github.com/repos/alliedmodders/metamod-source/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/alliedmodders/metamod-source/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/alliedmodders/metamod-source/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alliedmodders/metamod-source/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/alliedmodders/metamod-source/statuses/219cd7203fa7985ee751750030c6b62c90112f1c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dvander","id":865306,"avatar_url":"https://avatars.githubusercontent.com/u/865306?v=3","gravatar_id":"","url":"https://api.github.com/users/dvander","html_url":"https://github.com/dvander","followers_url":"https://api.github.com/users/dvander/followers","following_url":"https://api.github.com/users/dvander/following{/other_user}","gists_url":"https://api.github.com/users/dvander/gists{/gist_id}","starred_url":"https://api.github.com/users/dvander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvander/subscriptions","organizations_url":"https://api.github.com/users/dvander/orgs","repos_url":"https://api.github.com/users/dvander/repos","events_url":"https://api.github.com/users/dvander/events{/privacy}","received_events_url":"https://api.github.com/users/dvander/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":33,"deletions":7,"changed_files":3}}