{"action":"created","comment":{"url":"https://api.github.com/repos/patientslikeme/es_dump_restore/pulls/comments/33666465","id":33666465,"diff_hunk":"@@ -6,8 +6,11 @@\n \n module EsDumpRestore\n   class App < Thor\n-    \n-    option :noprogressbar, :type => :boolean # switch for showing progress bar\n+    class_option :progressbar,\n+      type: :boolean,","path":"lib/es_dump_restore/app.rb","position":7,"original_position":7,"commit_id":"478251f5655515d98939ebef2044c928f0116dd0","original_commit_id":"478251f5655515d98939ebef2044c928f0116dd0","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Align the parameters of a method call if they span more than one line.","created_at":"2015-07-01T10:30:33Z","updated_at":"2015-07-01T10:30:33Z","html_url":"https://github.com/patientslikeme/es_dump_restore/pull/17#discussion_r33666465","pull_request_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/patientslikeme/es_dump_restore/pulls/comments/33666465"},"html":{"href":"https://github.com/patientslikeme/es_dump_restore/pull/17#discussion_r33666465"},"pull_request":{"href":"https://api.github.com/repos/patientslikeme/es_dump_restore/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/patientslikeme/es_dump_restore/pulls/17","id":38964885,"html_url":"https://github.com/patientslikeme/es_dump_restore/pull/17","diff_url":"https://github.com/patientslikeme/es_dump_restore/pull/17.diff","patch_url":"https://github.com/patientslikeme/es_dump_restore/pull/17.patch","issue_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/issues/17","number":17,"state":"open","locked":false,"title":"Improve progressbar options","user":{"login":"alext","id":5560,"avatar_url":"https://avatars.githubusercontent.com/u/5560?v=3","gravatar_id":"","url":"https://api.github.com/users/alext","html_url":"https://github.com/alext","followers_url":"https://api.github.com/users/alext/followers","following_url":"https://api.github.com/users/alext/following{/other_user}","gists_url":"https://api.github.com/users/alext/gists{/gist_id}","starred_url":"https://api.github.com/users/alext/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alext/subscriptions","organizations_url":"https://api.github.com/users/alext/orgs","repos_url":"https://api.github.com/users/alext/repos","events_url":"https://api.github.com/users/alext/events{/privacy}","received_events_url":"https://api.github.com/users/alext/received_events","type":"User","site_admin":false},"body":"This was previously defined as an option that only applied to the dump\r\naction. Changing this to a `class_option` makes it available to all\r\nactions.\r\n\r\nThis also inverts the sense of it because Thor automatically adds a\r\n`--no-progressbar` option.  Previously it was adding a `--no-noprogressbar`\r\noption, which is a little confusing with the double-negative.\r\n\r\nThis updates the default value for the option is to be set based on whether\r\nSTDERR is a TTY or not, which is usually what's wanted.\r\n\r\nThe help output is now:\r\n```\r\n$ bundle exec es_dump_restore --help\r\nCommands:\r\n  es_dump_restore dump URL INDEX_NAME FILENAME                      # Creates a dumpfile bas...\r\n  es_dump_restore dump_type URL INDEX_NAME TYPE FILENAME            # Creates a dumpfile bas...\r\n  es_dump_restore help [COMMAND]                                    # Describe available com...\r\n  es_dump_restore restore URL INDEX_NAME FILENAME                   # Restores a dumpfile in...\r\n  es_dump_restore restore_alias URL ALIAS_NAME INDEX_NAME FILENAME  # Restores a dumpfile in...\r\n\r\nOptions:\r\n  [--progressbar], [--no-progressbar]  # Whether to show the progress bar.  Defaults to true if STDERR is a TTY, false otherwise.\r\n                                       # Default: true\r\n```\r\n\r\n**Note:** This is technically a breaking change because it removes the old `--noprogressbar` option for the dump action.  It should be possible to leave that in place, and have it work alongside the new option at the cost of maintaining that code path.  I'm happy to add that in if its something you think is worth it.","created_at":"2015-07-01T09:46:41Z","updated_at":"2015-07-01T10:30:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a372829fc822a3144dcf38bc4890925b2af98292","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/pulls/17/commits","review_comments_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/pulls/17/comments","review_comment_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/issues/17/comments","statuses_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/statuses/478251f5655515d98939ebef2044c928f0116dd0","head":{"label":"alext:improve_options","ref":"improve_options","sha":"478251f5655515d98939ebef2044c928f0116dd0","user":{"login":"alext","id":5560,"avatar_url":"https://avatars.githubusercontent.com/u/5560?v=3","gravatar_id":"","url":"https://api.github.com/users/alext","html_url":"https://github.com/alext","followers_url":"https://api.github.com/users/alext/followers","following_url":"https://api.github.com/users/alext/following{/other_user}","gists_url":"https://api.github.com/users/alext/gists{/gist_id}","starred_url":"https://api.github.com/users/alext/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alext/subscriptions","organizations_url":"https://api.github.com/users/alext/orgs","repos_url":"https://api.github.com/users/alext/repos","events_url":"https://api.github.com/users/alext/events{/privacy}","received_events_url":"https://api.github.com/users/alext/received_events","type":"User","site_admin":false},"repo":{"id":31655476,"name":"es_dump_restore","full_name":"alext/es_dump_restore","owner":{"login":"alext","id":5560,"avatar_url":"https://avatars.githubusercontent.com/u/5560?v=3","gravatar_id":"","url":"https://api.github.com/users/alext","html_url":"https://github.com/alext","followers_url":"https://api.github.com/users/alext/followers","following_url":"https://api.github.com/users/alext/following{/other_user}","gists_url":"https://api.github.com/users/alext/gists{/gist_id}","starred_url":"https://api.github.com/users/alext/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alext/subscriptions","organizations_url":"https://api.github.com/users/alext/orgs","repos_url":"https://api.github.com/users/alext/repos","events_url":"https://api.github.com/users/alext/events{/privacy}","received_events_url":"https://api.github.com/users/alext/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alext/es_dump_restore","description":"","fork":true,"url":"https://api.github.com/repos/alext/es_dump_restore","forks_url":"https://api.github.com/repos/alext/es_dump_restore/forks","keys_url":"https://api.github.com/repos/alext/es_dump_restore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alext/es_dump_restore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alext/es_dump_restore/teams","hooks_url":"https://api.github.com/repos/alext/es_dump_restore/hooks","issue_events_url":"https://api.github.com/repos/alext/es_dump_restore/issues/events{/number}","events_url":"https://api.github.com/repos/alext/es_dump_restore/events","assignees_url":"https://api.github.com/repos/alext/es_dump_restore/assignees{/user}","branches_url":"https://api.github.com/repos/alext/es_dump_restore/branches{/branch}","tags_url":"https://api.github.com/repos/alext/es_dump_restore/tags","blobs_url":"https://api.github.com/repos/alext/es_dump_restore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alext/es_dump_restore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alext/es_dump_restore/git/refs{/sha}","trees_url":"https://api.github.com/repos/alext/es_dump_restore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alext/es_dump_restore/statuses/{sha}","languages_url":"https://api.github.com/repos/alext/es_dump_restore/languages","stargazers_url":"https://api.github.com/repos/alext/es_dump_restore/stargazers","contributors_url":"https://api.github.com/repos/alext/es_dump_restore/contributors","subscribers_url":"https://api.github.com/repos/alext/es_dump_restore/subscribers","subscription_url":"https://api.github.com/repos/alext/es_dump_restore/subscription","commits_url":"https://api.github.com/repos/alext/es_dump_restore/commits{/sha}","git_commits_url":"https://api.github.com/repos/alext/es_dump_restore/git/commits{/sha}","comments_url":"https://api.github.com/repos/alext/es_dump_restore/comments{/number}","issue_comment_url":"https://api.github.com/repos/alext/es_dump_restore/issues/comments{/number}","contents_url":"https://api.github.com/repos/alext/es_dump_restore/contents/{+path}","compare_url":"https://api.github.com/repos/alext/es_dump_restore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alext/es_dump_restore/merges","archive_url":"https://api.github.com/repos/alext/es_dump_restore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alext/es_dump_restore/downloads","issues_url":"https://api.github.com/repos/alext/es_dump_restore/issues{/number}","pulls_url":"https://api.github.com/repos/alext/es_dump_restore/pulls{/number}","milestones_url":"https://api.github.com/repos/alext/es_dump_restore/milestones{/number}","notifications_url":"https://api.github.com/repos/alext/es_dump_restore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alext/es_dump_restore/labels{/name}","releases_url":"https://api.github.com/repos/alext/es_dump_restore/releases{/id}","created_at":"2015-03-04T12:17:14Z","updated_at":"2015-03-04T12:17:15Z","pushed_at":"2015-07-01T10:30:29Z","git_url":"git://github.com/alext/es_dump_restore.git","ssh_url":"git@github.com:alext/es_dump_restore.git","clone_url":"https://github.com/alext/es_dump_restore.git","svn_url":"https://github.com/alext/es_dump_restore","homepage":null,"size":95,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"patientslikeme:master","ref":"master","sha":"2a5bfe5f096dfc3f1745f11e81c47b307576ec4a","user":{"login":"patientslikeme","id":23326,"avatar_url":"https://avatars.githubusercontent.com/u/23326?v=3","gravatar_id":"","url":"https://api.github.com/users/patientslikeme","html_url":"https://github.com/patientslikeme","followers_url":"https://api.github.com/users/patientslikeme/followers","following_url":"https://api.github.com/users/patientslikeme/following{/other_user}","gists_url":"https://api.github.com/users/patientslikeme/gists{/gist_id}","starred_url":"https://api.github.com/users/patientslikeme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patientslikeme/subscriptions","organizations_url":"https://api.github.com/users/patientslikeme/orgs","repos_url":"https://api.github.com/users/patientslikeme/repos","events_url":"https://api.github.com/users/patientslikeme/events{/privacy}","received_events_url":"https://api.github.com/users/patientslikeme/received_events","type":"Organization","site_admin":false},"repo":{"id":5542314,"name":"es_dump_restore","full_name":"patientslikeme/es_dump_restore","owner":{"login":"patientslikeme","id":23326,"avatar_url":"https://avatars.githubusercontent.com/u/23326?v=3","gravatar_id":"","url":"https://api.github.com/users/patientslikeme","html_url":"https://github.com/patientslikeme","followers_url":"https://api.github.com/users/patientslikeme/followers","following_url":"https://api.github.com/users/patientslikeme/following{/other_user}","gists_url":"https://api.github.com/users/patientslikeme/gists{/gist_id}","starred_url":"https://api.github.com/users/patientslikeme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patientslikeme/subscriptions","organizations_url":"https://api.github.com/users/patientslikeme/orgs","repos_url":"https://api.github.com/users/patientslikeme/repos","events_url":"https://api.github.com/users/patientslikeme/events{/privacy}","received_events_url":"https://api.github.com/users/patientslikeme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/patientslikeme/es_dump_restore","description":"Saves and restores ElasticSearch index contents using a compressed file format","fork":false,"url":"https://api.github.com/repos/patientslikeme/es_dump_restore","forks_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/forks","keys_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/teams","hooks_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/hooks","issue_events_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/issues/events{/number}","events_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/events","assignees_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/assignees{/user}","branches_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/branches{/branch}","tags_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/tags","blobs_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/git/refs{/sha}","trees_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/statuses/{sha}","languages_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/languages","stargazers_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/stargazers","contributors_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/contributors","subscribers_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/subscribers","subscription_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/subscription","commits_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/commits{/sha}","git_commits_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/git/commits{/sha}","comments_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/comments{/number}","issue_comment_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/issues/comments{/number}","contents_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/contents/{+path}","compare_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/merges","archive_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/downloads","issues_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/issues{/number}","pulls_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/pulls{/number}","milestones_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/milestones{/number}","notifications_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/labels{/name}","releases_url":"https://api.github.com/repos/patientslikeme/es_dump_restore/releases{/id}","created_at":"2012-08-24T15:38:33Z","updated_at":"2015-06-24T13:48:26Z","pushed_at":"2015-07-01T10:30:30Z","git_url":"git://github.com/patientslikeme/es_dump_restore.git","ssh_url":"git@github.com:patientslikeme/es_dump_restore.git","clone_url":"https://github.com/patientslikeme/es_dump_restore.git","svn_url":"https://github.com/patientslikeme/es_dump_restore","homepage":"","size":286,"stargazers_count":21,"watchers_count":21,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":1,"forks":19,"open_issues":1,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/patientslikeme/es_dump_restore/pulls/17"},"html":{"href":"https://github.com/patientslikeme/es_dump_restore/pull/17"},"issue":{"href":"https://api.github.com/repos/patientslikeme/es_dump_restore/issues/17"},"comments":{"href":"https://api.github.com/repos/patientslikeme/es_dump_restore/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/patientslikeme/es_dump_restore/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/patientslikeme/es_dump_restore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/patientslikeme/es_dump_restore/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/patientslikeme/es_dump_restore/statuses/478251f5655515d98939ebef2044c928f0116dd0"}}}}