{"action":"created","issue":{"url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/9607","labels_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/9607/labels{/name}","comments_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/9607/comments","events_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/9607/events","html_url":"https://github.com/elasticsearch/elasticsearch/pull/9607","id":56969753,"number":9607,"title":"Mapping update task back references already closed index shard","user":{"login":"s1monw","id":973334,"avatar_url":"https://avatars.githubusercontent.com/u/973334?v=3","gravatar_id":"","url":"https://api.github.com/users/s1monw","html_url":"https://github.com/s1monw","followers_url":"https://api.github.com/users/s1monw/followers","following_url":"https://api.github.com/users/s1monw/following{/other_user}","gists_url":"https://api.github.com/users/s1monw/gists{/gist_id}","starred_url":"https://api.github.com/users/s1monw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s1monw/subscriptions","organizations_url":"https://api.github.com/users/s1monw/orgs","repos_url":"https://api.github.com/users/s1monw/repos","events_url":"https://api.github.com/users/s1monw/events{/privacy}","received_events_url":"https://api.github.com/users/s1monw/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/elasticsearch/elasticsearch/labels/bug","name":"bug","color":"9e2c2c"},{"url":"https://api.github.com/repos/elasticsearch/elasticsearch/labels/review","name":"review","color":"0052cc"},{"url":"https://api.github.com/repos/elasticsearch/elasticsearch/labels/v1.3.8","name":"v1.3.8","color":"dddddd"},{"url":"https://api.github.com/repos/elasticsearch/elasticsearch/labels/v1.4.3","name":"v1.4.3","color":"dddddd"},{"url":"https://api.github.com/repos/elasticsearch/elasticsearch/labels/v1.5.0","name":"v1.5.0","color":"dddddd"},{"url":"https://api.github.com/repos/elasticsearch/elasticsearch/labels/v2.0.0","name":"v2.0.0","color":"dddddd"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-02-08T21:58:03Z","updated_at":"2015-02-09T08:16:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elasticsearch/elasticsearch/pulls/9607","html_url":"https://github.com/elasticsearch/elasticsearch/pull/9607","diff_url":"https://github.com/elasticsearch/elasticsearch/pull/9607.diff","patch_url":"https://github.com/elasticsearch/elasticsearch/pull/9607.patch"},"body":"In the ShardRecoveryHandler we issue cluster update tasks to update the\r\nmapping. The annonymous inner class backreferences the ShardRecoveryHandler\r\nwhich holds a potentially large IndexShard object (which references buffers & caches etc)\r\nIf the queue of update tasks piles up and recoveries get cancled and/or shards are closed\r\nthe ShardRecoveryHandler can't be GCed. This commit moves the update task into a static\r\ninner class to allos the GC to do its job."},"comment":{"url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/comments/73471523","html_url":"https://github.com/elasticsearch/elasticsearch/pull/9607#issuecomment-73471523","issue_url":"https://api.github.com/repos/elasticsearch/elasticsearch/issues/9607","id":73471523,"user":{"login":"bleskes","id":1006375,"avatar_url":"https://avatars.githubusercontent.com/u/1006375?v=3","gravatar_id":"","url":"https://api.github.com/users/bleskes","html_url":"https://github.com/bleskes","followers_url":"https://api.github.com/users/bleskes/followers","following_url":"https://api.github.com/users/bleskes/following{/other_user}","gists_url":"https://api.github.com/users/bleskes/gists{/gist_id}","starred_url":"https://api.github.com/users/bleskes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bleskes/subscriptions","organizations_url":"https://api.github.com/users/bleskes/orgs","repos_url":"https://api.github.com/users/bleskes/repos","events_url":"https://api.github.com/users/bleskes/events{/privacy}","received_events_url":"https://api.github.com/users/bleskes/received_events","type":"User","site_admin":false},"created_at":"2015-02-09T08:16:40Z","updated_at":"2015-02-09T08:16:40Z","body":"LGTM as well. Good catch."}}