{"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/documentation/pulls/comments/26228085","id":26228085,"diff_hunk":"@@ -11,10 +11,61 @@ General\n * Fixes go directly to master, nevertheless they need to be tested thoroughly\n * New features are always developed in a branch and only merged to master once they are fully done\n * Software should work. Only put features into master when they are complete. It's better to not have a feature instead of having one that works poorly.\n-* When you are finished, use the merge request function on Github. The other developers will look at it and give you feedback. You can also post your merge request to the mailing list to let people know. See `the code review page for more information <../bugtracker/codereviews.html>`_\n+* When you are finished, use the merge request function on Github to create a pull request. The other developers will look at it and give you feedback. You can signify that your PR is ready for review by adding the label \"5 - ready for review\" to it. You can also post your merge request to the mailing list to let people know. See `the code review page for more information <../bugtracker/codereviews.html>`_\n * Decisions are made by consensus. We strive for making the best technical decisions and as nobody can know everything, we collaborate. That means a first negative comment might not be the final word, neither is positive feedback an immediate GO. ownCloud is built out of modular pieces (apps) and maintainers have a strong influence. In case of disagreement we consult other seasoned contributors.\n * We need a signed contributor agreement from you to commit into the core repository (apps don't need that). All the information is in our `Contributor agreement FAQ <http://owncloud.org/contribute/agreement/>`_.\n \n+Labels\n+------\n+We assign labels to issues and pull requests to make it easy to find them and to signal what needs to be done. The most important labels and their meaning:\n+* #bug - this issue is a bug\n+* #enhancement - this issue is a feature request/idea for improvement of ownCloud\n+* #design - this needs help from the design team or is a design-related issue/pull request\n+* #sharing - this issue or PR is related to sharing\n+* #technical debt - this issue or PR is about `technical debt <http://en.wikipedia.org/wiki/Technical_debt>`_\n+* #sev1-critical #sev2-high #sev3-medium #sev4-low signify how important the bug is. Data loss gets sev1, XXXX\n+* #Junior Job - these are issues which are relatively easy to solve and ideal for people who want to learn how to code in ownCloud\n+* Tags showing the state of the issue or PR, numbered 1-6:\n+ * #1 - Backlog - this issue has to be tackled but isn't planned in yet\n+ * #2 - Triaging - this issue has to be `triaged <../bugtracker/triaging.html>`_","path":"developer_manual/general/codingguidelines.rst","position":24,"original_position":21,"commit_id":"43f59218075e9af2d293b5ede87e0f45d09c6edb","original_commit_id":"cacba7fa2064c3906a5d1fe14aa1490557320846","user":{"login":"jospoortvliet","id":551757,"avatar_url":"https://avatars.githubusercontent.com/u/551757?v=3","gravatar_id":"","url":"https://api.github.com/users/jospoortvliet","html_url":"https://github.com/jospoortvliet","followers_url":"https://api.github.com/users/jospoortvliet/followers","following_url":"https://api.github.com/users/jospoortvliet/following{/other_user}","gists_url":"https://api.github.com/users/jospoortvliet/gists{/gist_id}","starred_url":"https://api.github.com/users/jospoortvliet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jospoortvliet/subscriptions","organizations_url":"https://api.github.com/users/jospoortvliet/orgs","repos_url":"https://api.github.com/users/jospoortvliet/repos","events_url":"https://api.github.com/users/jospoortvliet/events{/privacy}","received_events_url":"https://api.github.com/users/jospoortvliet/received_events","type":"User","site_admin":false},"body":"That makes sense, then, keep em both.","created_at":"2015-03-11T16:23:43Z","updated_at":"2015-03-11T16:23:43Z","html_url":"https://github.com/owncloud/documentation/pull/704#discussion_r26228085","pull_request_url":"https://api.github.com/repos/owncloud/documentation/pulls/704","_links":{"self":{"href":"https://api.github.com/repos/owncloud/documentation/pulls/comments/26228085"},"html":{"href":"https://github.com/owncloud/documentation/pull/704#discussion_r26228085"},"pull_request":{"href":"https://api.github.com/repos/owncloud/documentation/pulls/704"}}},"pull_request":{"url":"https://api.github.com/repos/owncloud/documentation/pulls/704","id":25968589,"html_url":"https://github.com/owncloud/documentation/pull/704","diff_url":"https://github.com/owncloud/documentation/pull/704.diff","patch_url":"https://github.com/owncloud/documentation/pull/704.patch","issue_url":"https://api.github.com/repos/owncloud/documentation/issues/704","number":704,"state":"open","locked":false,"title":"Labels","user":{"login":"jospoortvliet","id":551757,"avatar_url":"https://avatars.githubusercontent.com/u/551757?v=3","gravatar_id":"","url":"https://api.github.com/users/jospoortvliet","html_url":"https://github.com/jospoortvliet","followers_url":"https://api.github.com/users/jospoortvliet/followers","following_url":"https://api.github.com/users/jospoortvliet/following{/other_user}","gists_url":"https://api.github.com/users/jospoortvliet/gists{/gist_id}","starred_url":"https://api.github.com/users/jospoortvliet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jospoortvliet/subscriptions","organizations_url":"https://api.github.com/users/jospoortvliet/orgs","repos_url":"https://api.github.com/users/jospoortvliet/repos","events_url":"https://api.github.com/users/jospoortvliet/events{/privacy}","received_events_url":"https://api.github.com/users/jospoortvliet/received_events","type":"User","site_admin":false},"body":"Time to explain the labels properly ;-)\r\n\r\nThis needs review and comments - half the labels is unclear and I bet half of those can and should be removed.\r\n\r\nAlso, I didn't add all the \"v7.x\" and \"7.0-current\" labels yet. What do they mean?\r\n\r\n@karlitschek @MorrisJobke ","created_at":"2014-12-12T11:52:58Z","updated_at":"2015-03-11T16:23:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e3b495a43b3e16445b94d401e06dc5ad6ac847a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/owncloud/documentation/pulls/704/commits","review_comments_url":"https://api.github.com/repos/owncloud/documentation/pulls/704/comments","review_comment_url":"https://api.github.com/repos/owncloud/documentation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/documentation/issues/704/comments","statuses_url":"https://api.github.com/repos/owncloud/documentation/statuses/43f59218075e9af2d293b5ede87e0f45d09c6edb","head":{"label":"owncloud:labels","ref":"labels","sha":"43f59218075e9af2d293b5ede87e0f45d09c6edb","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":6405172,"name":"documentation","full_name":"owncloud/documentation","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/documentation","description":"Documentation and manual","fork":false,"url":"https://api.github.com/repos/owncloud/documentation","forks_url":"https://api.github.com/repos/owncloud/documentation/forks","keys_url":"https://api.github.com/repos/owncloud/documentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/documentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/documentation/teams","hooks_url":"https://api.github.com/repos/owncloud/documentation/hooks","issue_events_url":"https://api.github.com/repos/owncloud/documentation/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/documentation/events","assignees_url":"https://api.github.com/repos/owncloud/documentation/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/documentation/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/documentation/tags","blobs_url":"https://api.github.com/repos/owncloud/documentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/documentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/documentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/documentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/documentation/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/documentation/languages","stargazers_url":"https://api.github.com/repos/owncloud/documentation/stargazers","contributors_url":"https://api.github.com/repos/owncloud/documentation/contributors","subscribers_url":"https://api.github.com/repos/owncloud/documentation/subscribers","subscription_url":"https://api.github.com/repos/owncloud/documentation/subscription","commits_url":"https://api.github.com/repos/owncloud/documentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/documentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/documentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/documentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/documentation/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/documentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/documentation/merges","archive_url":"https://api.github.com/repos/owncloud/documentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/documentation/downloads","issues_url":"https://api.github.com/repos/owncloud/documentation/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/documentation/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/documentation/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/documentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/documentation/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/documentation/releases{/id}","created_at":"2012-10-26T14:36:00Z","updated_at":"2015-03-10T20:17:03Z","pushed_at":"2015-03-11T16:17:58Z","git_url":"git://github.com/owncloud/documentation.git","ssh_url":"git@github.com:owncloud/documentation.git","clone_url":"https://github.com/owncloud/documentation.git","svn_url":"https://github.com/owncloud/documentation","homepage":null,"size":39688,"stargazers_count":84,"watchers_count":84,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":134,"mirror_url":null,"open_issues_count":85,"forks":134,"open_issues":85,"watchers":84,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"a20eccfecec7ffc28f68152ae0cfebed42347b5f","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":6405172,"name":"documentation","full_name":"owncloud/documentation","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/documentation","description":"Documentation and manual","fork":false,"url":"https://api.github.com/repos/owncloud/documentation","forks_url":"https://api.github.com/repos/owncloud/documentation/forks","keys_url":"https://api.github.com/repos/owncloud/documentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/documentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/documentation/teams","hooks_url":"https://api.github.com/repos/owncloud/documentation/hooks","issue_events_url":"https://api.github.com/repos/owncloud/documentation/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/documentation/events","assignees_url":"https://api.github.com/repos/owncloud/documentation/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/documentation/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/documentation/tags","blobs_url":"https://api.github.com/repos/owncloud/documentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/documentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/documentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/documentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/documentation/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/documentation/languages","stargazers_url":"https://api.github.com/repos/owncloud/documentation/stargazers","contributors_url":"https://api.github.com/repos/owncloud/documentation/contributors","subscribers_url":"https://api.github.com/repos/owncloud/documentation/subscribers","subscription_url":"https://api.github.com/repos/owncloud/documentation/subscription","commits_url":"https://api.github.com/repos/owncloud/documentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/documentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/documentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/documentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/documentation/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/documentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/documentation/merges","archive_url":"https://api.github.com/repos/owncloud/documentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/documentation/downloads","issues_url":"https://api.github.com/repos/owncloud/documentation/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/documentation/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/documentation/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/documentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/documentation/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/documentation/releases{/id}","created_at":"2012-10-26T14:36:00Z","updated_at":"2015-03-10T20:17:03Z","pushed_at":"2015-03-11T16:17:58Z","git_url":"git://github.com/owncloud/documentation.git","ssh_url":"git@github.com:owncloud/documentation.git","clone_url":"https://github.com/owncloud/documentation.git","svn_url":"https://github.com/owncloud/documentation","homepage":null,"size":39688,"stargazers_count":84,"watchers_count":84,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":134,"mirror_url":null,"open_issues_count":85,"forks":134,"open_issues":85,"watchers":84,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/documentation/pulls/704"},"html":{"href":"https://github.com/owncloud/documentation/pull/704"},"issue":{"href":"https://api.github.com/repos/owncloud/documentation/issues/704"},"comments":{"href":"https://api.github.com/repos/owncloud/documentation/issues/704/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/documentation/pulls/704/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/documentation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/documentation/pulls/704/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/documentation/statuses/43f59218075e9af2d293b5ede87e0f45d09c6edb"}}}}