{"action":"created","comment":{"url":"https://api.github.com/repos/openstax/tutor-server/pulls/comments/27527844","id":27527844,"diff_hunk":"@@ -1,30 +0,0 @@\n-require 'rails_helper'\n-\n-RSpec.describe Tasking, :type => :model do\n-  it { is_expected.to belong_to(:taskee) }\n-  it { is_expected.to belong_to(:task).counter_cache(true) }\n-  it { is_expected.to belong_to(:user) }\n-\n-  it { is_expected.to validate_presence_of(:taskee) }\n-  it { is_expected.to validate_presence_of(:task) }\n-  it { is_expected.to validate_presence_of(:user) }\n-\n-  it \"requires taskee and user to be unique for the task\" do\n-    tasking = FactoryGirl.create(:tasking)\n-    expect(tasking).to be_valid\n-\n-    expect(FactoryGirl.build(:tasking, task: tasking.task,\n-                             taskee: tasking.taskee)).to_not be_valid\n-\n-    expect(FactoryGirl.build(:tasking, task: tasking.task,\n-                             user: tasking.user)).to_not be_valid\n-  end\n-\n-  it \"requires user to match taskee\" do\n-    expect(FactoryGirl.build(:tasking)).to be_valid\n-\n-    expect(FactoryGirl.build(:tasking,\n-                             user: FactoryGirl.create(:user))).to_not be_valid\n-  end\n-end\n-","path":"spec/models/tasking_spec.rb","position":30,"original_position":30,"commit_id":"1a375967a1401e7eb12389d2bd4d455f8197e79d","original_commit_id":"1a375967a1401e7eb12389d2bd4d455f8197e79d","user":{"login":"nathanstitt","id":79566,"avatar_url":"https://avatars.githubusercontent.com/u/79566?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanstitt","html_url":"https://github.com/nathanstitt","followers_url":"https://api.github.com/users/nathanstitt/followers","following_url":"https://api.github.com/users/nathanstitt/following{/other_user}","gists_url":"https://api.github.com/users/nathanstitt/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanstitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanstitt/subscriptions","organizations_url":"https://api.github.com/users/nathanstitt/orgs","repos_url":"https://api.github.com/users/nathanstitt/repos","events_url":"https://api.github.com/users/nathanstitt/events{/privacy}","received_events_url":"https://api.github.com/users/nathanstitt/received_events","type":"User","site_admin":false},"body":"Did you remove these specs?  I don't see where they were re-named but I'm probably just missing them.  I don't really see much point in testing that the associations are working though so maybe it does make sense to remove them","created_at":"2015-03-31T22:02:02Z","updated_at":"2015-03-31T22:02:02Z","html_url":"https://github.com/openstax/tutor-server/pull/145#discussion_r27527844","pull_request_url":"https://api.github.com/repos/openstax/tutor-server/pulls/145","_links":{"self":{"href":"https://api.github.com/repos/openstax/tutor-server/pulls/comments/27527844"},"html":{"href":"https://github.com/openstax/tutor-server/pull/145#discussion_r27527844"},"pull_request":{"href":"https://api.github.com/repos/openstax/tutor-server/pulls/145"}}},"pull_request":{"url":"https://api.github.com/repos/openstax/tutor-server/pulls/145","id":32299535,"html_url":"https://github.com/openstax/tutor-server/pull/145","diff_url":"https://github.com/openstax/tutor-server/pull/145.diff","patch_url":"https://github.com/openstax/tutor-server/pull/145.patch","issue_url":"https://api.github.com/repos/openstax/tutor-server/issues/145","number":145,"state":"open","locked":false,"title":"WIP Move tasks into a subsystem","user":{"login":"jpslav","id":1001691,"avatar_url":"https://avatars.githubusercontent.com/u/1001691?v=3","gravatar_id":"","url":"https://api.github.com/users/jpslav","html_url":"https://github.com/jpslav","followers_url":"https://api.github.com/users/jpslav/followers","following_url":"https://api.github.com/users/jpslav/following{/other_user}","gists_url":"https://api.github.com/users/jpslav/gists{/gist_id}","starred_url":"https://api.github.com/users/jpslav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpslav/subscriptions","organizations_url":"https://api.github.com/users/jpslav/orgs","repos_url":"https://api.github.com/users/jpslav/repos","events_url":"https://api.github.com/users/jpslav/events{/privacy}","received_events_url":"https://api.github.com/users/jpslav/received_events","type":"User","site_admin":false},"body":"This PR moves Task-related models into a \"tasks\" subsystem.\r\n\r\n* `app/models` is now empty!\r\n* All taskings are now assigned to roles; you can no longer assign straight to a user; instead you can get a user's default\r\n  role from the `Role` subsystem.\r\n* We'll still need to do some refactorings after this, e.g.:\r\n  * deciding where exactly `Entity::Models::Task` should be used vs `Tasks::Models::Task`\r\n  * collapsing all domain-ish routines into `app/domain`\r\n  * figuring out how OK we are with controllers and representers knowing a lot about `Tasks::Models` and taking action as needed\r\n","created_at":"2015-03-31T08:14:03Z","updated_at":"2015-03-31T22:02:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e37e8c083a7511ef02b0655fcd98cb43051ba14","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openstax/tutor-server/pulls/145/commits","review_comments_url":"https://api.github.com/repos/openstax/tutor-server/pulls/145/comments","review_comment_url":"https://api.github.com/repos/openstax/tutor-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openstax/tutor-server/issues/145/comments","statuses_url":"https://api.github.com/repos/openstax/tutor-server/statuses/1a375967a1401e7eb12389d2bd4d455f8197e79d","head":{"label":"openstax:move-tasks","ref":"move-tasks","sha":"1a375967a1401e7eb12389d2bd4d455f8197e79d","user":{"login":"openstax","id":3805549,"avatar_url":"https://avatars.githubusercontent.com/u/3805549?v=3","gravatar_id":"","url":"https://api.github.com/users/openstax","html_url":"https://github.com/openstax","followers_url":"https://api.github.com/users/openstax/followers","following_url":"https://api.github.com/users/openstax/following{/other_user}","gists_url":"https://api.github.com/users/openstax/gists{/gist_id}","starred_url":"https://api.github.com/users/openstax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstax/subscriptions","organizations_url":"https://api.github.com/users/openstax/orgs","repos_url":"https://api.github.com/users/openstax/repos","events_url":"https://api.github.com/users/openstax/events{/privacy}","received_events_url":"https://api.github.com/users/openstax/received_events","type":"Organization","site_admin":false},"repo":{"id":24337612,"name":"tutor-server","full_name":"openstax/tutor-server","owner":{"login":"openstax","id":3805549,"avatar_url":"https://avatars.githubusercontent.com/u/3805549?v=3","gravatar_id":"","url":"https://api.github.com/users/openstax","html_url":"https://github.com/openstax","followers_url":"https://api.github.com/users/openstax/followers","following_url":"https://api.github.com/users/openstax/following{/other_user}","gists_url":"https://api.github.com/users/openstax/gists{/gist_id}","starred_url":"https://api.github.com/users/openstax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstax/subscriptions","organizations_url":"https://api.github.com/users/openstax/orgs","repos_url":"https://api.github.com/users/openstax/repos","events_url":"https://api.github.com/users/openstax/events{/privacy}","received_events_url":"https://api.github.com/users/openstax/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openstax/tutor-server","description":"OpenStax Tutor 3.0 Backend","fork":false,"url":"https://api.github.com/repos/openstax/tutor-server","forks_url":"https://api.github.com/repos/openstax/tutor-server/forks","keys_url":"https://api.github.com/repos/openstax/tutor-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openstax/tutor-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openstax/tutor-server/teams","hooks_url":"https://api.github.com/repos/openstax/tutor-server/hooks","issue_events_url":"https://api.github.com/repos/openstax/tutor-server/issues/events{/number}","events_url":"https://api.github.com/repos/openstax/tutor-server/events","assignees_url":"https://api.github.com/repos/openstax/tutor-server/assignees{/user}","branches_url":"https://api.github.com/repos/openstax/tutor-server/branches{/branch}","tags_url":"https://api.github.com/repos/openstax/tutor-server/tags","blobs_url":"https://api.github.com/repos/openstax/tutor-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openstax/tutor-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openstax/tutor-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/openstax/tutor-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openstax/tutor-server/statuses/{sha}","languages_url":"https://api.github.com/repos/openstax/tutor-server/languages","stargazers_url":"https://api.github.com/repos/openstax/tutor-server/stargazers","contributors_url":"https://api.github.com/repos/openstax/tutor-server/contributors","subscribers_url":"https://api.github.com/repos/openstax/tutor-server/subscribers","subscription_url":"https://api.github.com/repos/openstax/tutor-server/subscription","commits_url":"https://api.github.com/repos/openstax/tutor-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/openstax/tutor-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/openstax/tutor-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/openstax/tutor-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/openstax/tutor-server/contents/{+path}","compare_url":"https://api.github.com/repos/openstax/tutor-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openstax/tutor-server/merges","archive_url":"https://api.github.com/repos/openstax/tutor-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openstax/tutor-server/downloads","issues_url":"https://api.github.com/repos/openstax/tutor-server/issues{/number}","pulls_url":"https://api.github.com/repos/openstax/tutor-server/pulls{/number}","milestones_url":"https://api.github.com/repos/openstax/tutor-server/milestones{/number}","notifications_url":"https://api.github.com/repos/openstax/tutor-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openstax/tutor-server/labels{/name}","releases_url":"https://api.github.com/repos/openstax/tutor-server/releases{/id}","created_at":"2014-09-22T17:10:29Z","updated_at":"2015-03-31T17:28:58Z","pushed_at":"2015-03-31T21:15:15Z","git_url":"git://github.com/openstax/tutor-server.git","ssh_url":"git@github.com:openstax/tutor-server.git","clone_url":"https://github.com/openstax/tutor-server.git","svn_url":"https://github.com/openstax/tutor-server","homepage":"","size":10840,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":16,"forks":4,"open_issues":16,"watchers":1,"default_branch":"master"}},"base":{"label":"openstax:master","ref":"master","sha":"77c52f86c32b2252a75ca49e50c308a162861bf7","user":{"login":"openstax","id":3805549,"avatar_url":"https://avatars.githubusercontent.com/u/3805549?v=3","gravatar_id":"","url":"https://api.github.com/users/openstax","html_url":"https://github.com/openstax","followers_url":"https://api.github.com/users/openstax/followers","following_url":"https://api.github.com/users/openstax/following{/other_user}","gists_url":"https://api.github.com/users/openstax/gists{/gist_id}","starred_url":"https://api.github.com/users/openstax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstax/subscriptions","organizations_url":"https://api.github.com/users/openstax/orgs","repos_url":"https://api.github.com/users/openstax/repos","events_url":"https://api.github.com/users/openstax/events{/privacy}","received_events_url":"https://api.github.com/users/openstax/received_events","type":"Organization","site_admin":false},"repo":{"id":24337612,"name":"tutor-server","full_name":"openstax/tutor-server","owner":{"login":"openstax","id":3805549,"avatar_url":"https://avatars.githubusercontent.com/u/3805549?v=3","gravatar_id":"","url":"https://api.github.com/users/openstax","html_url":"https://github.com/openstax","followers_url":"https://api.github.com/users/openstax/followers","following_url":"https://api.github.com/users/openstax/following{/other_user}","gists_url":"https://api.github.com/users/openstax/gists{/gist_id}","starred_url":"https://api.github.com/users/openstax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstax/subscriptions","organizations_url":"https://api.github.com/users/openstax/orgs","repos_url":"https://api.github.com/users/openstax/repos","events_url":"https://api.github.com/users/openstax/events{/privacy}","received_events_url":"https://api.github.com/users/openstax/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openstax/tutor-server","description":"OpenStax Tutor 3.0 Backend","fork":false,"url":"https://api.github.com/repos/openstax/tutor-server","forks_url":"https://api.github.com/repos/openstax/tutor-server/forks","keys_url":"https://api.github.com/repos/openstax/tutor-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openstax/tutor-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openstax/tutor-server/teams","hooks_url":"https://api.github.com/repos/openstax/tutor-server/hooks","issue_events_url":"https://api.github.com/repos/openstax/tutor-server/issues/events{/number}","events_url":"https://api.github.com/repos/openstax/tutor-server/events","assignees_url":"https://api.github.com/repos/openstax/tutor-server/assignees{/user}","branches_url":"https://api.github.com/repos/openstax/tutor-server/branches{/branch}","tags_url":"https://api.github.com/repos/openstax/tutor-server/tags","blobs_url":"https://api.github.com/repos/openstax/tutor-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openstax/tutor-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openstax/tutor-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/openstax/tutor-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openstax/tutor-server/statuses/{sha}","languages_url":"https://api.github.com/repos/openstax/tutor-server/languages","stargazers_url":"https://api.github.com/repos/openstax/tutor-server/stargazers","contributors_url":"https://api.github.com/repos/openstax/tutor-server/contributors","subscribers_url":"https://api.github.com/repos/openstax/tutor-server/subscribers","subscription_url":"https://api.github.com/repos/openstax/tutor-server/subscription","commits_url":"https://api.github.com/repos/openstax/tutor-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/openstax/tutor-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/openstax/tutor-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/openstax/tutor-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/openstax/tutor-server/contents/{+path}","compare_url":"https://api.github.com/repos/openstax/tutor-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openstax/tutor-server/merges","archive_url":"https://api.github.com/repos/openstax/tutor-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openstax/tutor-server/downloads","issues_url":"https://api.github.com/repos/openstax/tutor-server/issues{/number}","pulls_url":"https://api.github.com/repos/openstax/tutor-server/pulls{/number}","milestones_url":"https://api.github.com/repos/openstax/tutor-server/milestones{/number}","notifications_url":"https://api.github.com/repos/openstax/tutor-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openstax/tutor-server/labels{/name}","releases_url":"https://api.github.com/repos/openstax/tutor-server/releases{/id}","created_at":"2014-09-22T17:10:29Z","updated_at":"2015-03-31T17:28:58Z","pushed_at":"2015-03-31T21:15:15Z","git_url":"git://github.com/openstax/tutor-server.git","ssh_url":"git@github.com:openstax/tutor-server.git","clone_url":"https://github.com/openstax/tutor-server.git","svn_url":"https://github.com/openstax/tutor-server","homepage":"","size":10840,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":16,"forks":4,"open_issues":16,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openstax/tutor-server/pulls/145"},"html":{"href":"https://github.com/openstax/tutor-server/pull/145"},"issue":{"href":"https://api.github.com/repos/openstax/tutor-server/issues/145"},"comments":{"href":"https://api.github.com/repos/openstax/tutor-server/issues/145/comments"},"review_comments":{"href":"https://api.github.com/repos/openstax/tutor-server/pulls/145/comments"},"review_comment":{"href":"https://api.github.com/repos/openstax/tutor-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openstax/tutor-server/pulls/145/commits"},"statuses":{"href":"https://api.github.com/repos/openstax/tutor-server/statuses/1a375967a1401e7eb12389d2bd4d455f8197e79d"}}}}