{"action":"created","issue":{"url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/632","labels_url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/632/labels{/name}","comments_url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/632/comments","events_url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/632/events","html_url":"https://github.com/Smoothieware/Smoothieware/pull/632","id":59332028,"number":632,"title":"Add option to oversample thermistor ADC values.","user":{"login":"PetteriAimonen","id":922265,"avatar_url":"https://avatars.githubusercontent.com/u/922265?v=3","gravatar_id":"","url":"https://api.github.com/users/PetteriAimonen","html_url":"https://github.com/PetteriAimonen","followers_url":"https://api.github.com/users/PetteriAimonen/followers","following_url":"https://api.github.com/users/PetteriAimonen/following{/other_user}","gists_url":"https://api.github.com/users/PetteriAimonen/gists{/gist_id}","starred_url":"https://api.github.com/users/PetteriAimonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PetteriAimonen/subscriptions","organizations_url":"https://api.github.com/users/PetteriAimonen/orgs","repos_url":"https://api.github.com/users/PetteriAimonen/repos","events_url":"https://api.github.com/users/PetteriAimonen/events{/privacy}","received_events_url":"https://api.github.com/users/PetteriAimonen/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-02-28T08:10:37Z","updated_at":"2015-03-09T20:42:36Z","closed_at":"2015-03-09T20:26:28Z","pull_request":{"url":"https://api.github.com/repos/Smoothieware/Smoothieware/pulls/632","html_url":"https://github.com/Smoothieware/Smoothieware/pull/632","diff_url":"https://github.com/Smoothieware/Smoothieware/pull/632.diff","patch_url":"https://github.com/Smoothieware/Smoothieware/pull/632.patch"},"body":"This improves the stability of PID control by reducing the effect of quantization\r\non the operation of the D term.\r\n\r\nPull request #564 rebased against newest edge.\r\nSee previous pull request for result graphs from both me and @minad, both of which show large improvement in stability.\r\n\r\nI see no reason not to include this as an option. It is off by default and only takes 8 bytes ram per thermistor, no other overhead when disabled."},"comment":{"url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/comments/77937862","html_url":"https://github.com/Smoothieware/Smoothieware/pull/632#issuecomment-77937862","issue_url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/632","id":77937862,"user":{"login":"arthurwolf","id":108821,"avatar_url":"https://avatars.githubusercontent.com/u/108821?v=3","gravatar_id":"","url":"https://api.github.com/users/arthurwolf","html_url":"https://github.com/arthurwolf","followers_url":"https://api.github.com/users/arthurwolf/followers","following_url":"https://api.github.com/users/arthurwolf/following{/other_user}","gists_url":"https://api.github.com/users/arthurwolf/gists{/gist_id}","starred_url":"https://api.github.com/users/arthurwolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthurwolf/subscriptions","organizations_url":"https://api.github.com/users/arthurwolf/orgs","repos_url":"https://api.github.com/users/arthurwolf/repos","events_url":"https://api.github.com/users/arthurwolf/events{/privacy}","received_events_url":"https://api.github.com/users/arthurwolf/received_events","type":"User","site_admin":false},"created_at":"2015-03-09T20:42:36Z","updated_at":"2015-03-09T20:42:36Z","body":"I know @minad is going to ask so I'll just answer with a bit more detail right away :)\r\n\r\nIn the same way we currently tend to reject modifications to the step generation code because a big refactor of it is on-going, this is not accepted mostly because a much better way to do the same thing has already been described and is planned to be added."}}