{"action":"created","issue":{"url":"https://api.github.com/repos/jupyter/notebook/issues/232","labels_url":"https://api.github.com/repos/jupyter/notebook/issues/232/labels{/name}","comments_url":"https://api.github.com/repos/jupyter/notebook/issues/232/comments","events_url":"https://api.github.com/repos/jupyter/notebook/issues/232/events","html_url":"https://github.com/jupyter/notebook/pull/232","id":97221208,"number":232,"title":"Modify the check_call invocation to fix break on Windows","user":{"login":"justacec","id":5904886,"avatar_url":"https://avatars.githubusercontent.com/u/5904886?v=3","gravatar_id":"","url":"https://api.github.com/users/justacec","html_url":"https://github.com/justacec","followers_url":"https://api.github.com/users/justacec/followers","following_url":"https://api.github.com/users/justacec/following{/other_user}","gists_url":"https://api.github.com/users/justacec/gists{/gist_id}","starred_url":"https://api.github.com/users/justacec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justacec/subscriptions","organizations_url":"https://api.github.com/users/justacec/orgs","repos_url":"https://api.github.com/users/justacec/repos","events_url":"https://api.github.com/users/justacec/events{/privacy}","received_events_url":"https://api.github.com/users/justacec/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-07-25T12:06:25Z","updated_at":"2015-07-25T18:40:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jupyter/notebook/pulls/232","html_url":"https://github.com/jupyter/notebook/pull/232","diff_url":"https://github.com/jupyter/notebook/pull/232.diff","patch_url":"https://github.com/jupyter/notebook/pull/232.patch"},"body":"When I attempted to install the development version of notebook on my Windows 7 machine, I received the following error:\r\n\r\n    >> python setup.py build\r\n\r\n    running build\r\n    running build_py\r\n    running jsversion\r\n    running css\r\n    running jsdeps\r\n    installing build dependencies with npm\r\n    npm install\r\n    rebuilding js and css failed (not a problem)\r\n    [WinError 2] The system cannot find the file specified\r\n    checking package data\r\n    Traceback (most recent call last):\r\n      File \"setup.py\", line 190, in <module>\r\n        main()\r\n      File \"setup.py\", line 187, in main\r\n        setup(**setup_args)\r\n      File \"C:\\Anaconda3\\lib\\distutils\\core.py\", line 148, in setup\r\n        dist.run_commands()\r\n      File \"C:\\Anaconda3\\lib\\distutils\\dist.py\", line 955, in run_commands\r\n        self.run_command(cmd)\r\n      File \"C:\\Anaconda3\\lib\\distutils\\dist.py\", line 974, in run_command\r\n        cmd_obj.run()\r\n      File \"C:\\Anaconda3\\lib\\distutils\\command\\build.py\", line 126, in run\r\n        self.run_command(cmd_name)\r\n      File \"C:\\Anaconda3\\lib\\distutils\\cmd.py\", line 313, in run_command\r\n        self.distribution.run_command(command)\r\n      File \"C:\\Anaconda3\\lib\\distutils\\dist.py\", line 974, in run_command\r\n        cmd_obj.run()\r\n      File \"C:\\Users\\jclutter\\Source\\Python\\IPython\\t\\notebook\\setupbase.py\", line 508, in run\r\n        command.run(self)\r\n      File \"C:\\Users\\jclutter\\Source\\Python\\IPython\\t\\notebook\\setupbase.py\", line 199, in run\r\n        check_package_data(self.package_data)\r\n      File \"C:\\Users\\jclutter\\Source\\Python\\IPython\\t\\notebook\\setupbase.py\", line 189, in check_package_data\r\n        assert os.path.exists(path), \"Missing package data: %s\" % path\r\n    AssertionError: Missing package data: notebook\\static\\auth\\js\\main.min.js\r\n\r\nAlthough the bottom error highlights a missing `main.min.js`, this is a red herring.  The real issue is at the top, `[WinError 2] The system cannot find the specified`.\r\n\r\nAfter some investigation, I found that the `bower` program was not being execute.  This led to an investigation of the run command.  I was unable to execute commands from the python shell unless I added the `shell = True` parameter to the `check_call` invocation.  I made this change here and was able to perform the installation of Jupyter/notebook.  \r\n\r\nDocumentation for the `subprocess` module implies that there could be security issues when using `shell = True`."},"comment":{"url":"https://api.github.com/repos/jupyter/notebook/issues/comments/124871331","html_url":"https://github.com/jupyter/notebook/pull/232#issuecomment-124871331","issue_url":"https://api.github.com/repos/jupyter/notebook/issues/232","id":124871331,"user":{"login":"justacec","id":5904886,"avatar_url":"https://avatars.githubusercontent.com/u/5904886?v=3","gravatar_id":"","url":"https://api.github.com/users/justacec","html_url":"https://github.com/justacec","followers_url":"https://api.github.com/users/justacec/followers","following_url":"https://api.github.com/users/justacec/following{/other_user}","gists_url":"https://api.github.com/users/justacec/gists{/gist_id}","starred_url":"https://api.github.com/users/justacec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justacec/subscriptions","organizations_url":"https://api.github.com/users/justacec/orgs","repos_url":"https://api.github.com/users/justacec/repos","events_url":"https://api.github.com/users/justacec/events{/privacy}","received_events_url":"https://api.github.com/users/justacec/received_events","type":"User","site_admin":false},"created_at":"2015-07-25T18:40:23Z","updated_at":"2015-07-25T18:40:23Z","body":"Could be.  I am still not very good with Python and am learning.  I have noticed other strange issues with the install.  For instance, the installed scripts to launch Jupyter are all bash style scripts and do not support windows.  I am not sure how to fix that right now.  I can start jupyter-notebook but then after that I think there will be issues when and if the system tries to execute the nconvert module for export...  I am still playing around here."}}