{"action":"created","issue":{"url":"https://api.github.com/repos/doctrine/cache/issues/89","labels_url":"https://api.github.com/repos/doctrine/cache/issues/89/labels{/name}","comments_url":"https://api.github.com/repos/doctrine/cache/issues/89/comments","events_url":"https://api.github.com/repos/doctrine/cache/issues/89/events","html_url":"https://github.com/doctrine/cache/pull/89","id":105600623,"number":89,"title":"Fix RedisCache::fetchMultiple if keys array is empty","user":{"login":"Pouix","id":7051455,"avatar_url":"https://avatars.githubusercontent.com/u/7051455?v=3","gravatar_id":"","url":"https://api.github.com/users/Pouix","html_url":"https://github.com/Pouix","followers_url":"https://api.github.com/users/Pouix/followers","following_url":"https://api.github.com/users/Pouix/following{/other_user}","gists_url":"https://api.github.com/users/Pouix/gists{/gist_id}","starred_url":"https://api.github.com/users/Pouix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pouix/subscriptions","organizations_url":"https://api.github.com/users/Pouix/orgs","repos_url":"https://api.github.com/users/Pouix/repos","events_url":"https://api.github.com/users/Pouix/events{/privacy}","received_events_url":"https://api.github.com/users/Pouix/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-09T13:50:34Z","updated_at":"2015-09-10T12:22:46Z","closed_at":"2015-09-10T12:22:46Z","pull_request":{"url":"https://api.github.com/repos/doctrine/cache/pulls/89","html_url":"https://github.com/doctrine/cache/pull/89","diff_url":"https://github.com/doctrine/cache/pull/89.diff","patch_url":"https://github.com/doctrine/cache/pull/89.patch"},"body":"If provided with an empty array, Redis mget returns false and array_combine expects parameter 2 to be array.\r\nTherefore we need to check if $keys is empty and return an empty array."},"comment":{"url":"https://api.github.com/repos/doctrine/cache/issues/comments/139218327","html_url":"https://github.com/doctrine/cache/pull/89#issuecomment-139218327","issue_url":"https://api.github.com/repos/doctrine/cache/issues/89","id":139218327,"user":{"login":"Pouix","id":7051455,"avatar_url":"https://avatars.githubusercontent.com/u/7051455?v=3","gravatar_id":"","url":"https://api.github.com/users/Pouix","html_url":"https://github.com/Pouix","followers_url":"https://api.github.com/users/Pouix/followers","following_url":"https://api.github.com/users/Pouix/following{/other_user}","gists_url":"https://api.github.com/users/Pouix/gists{/gist_id}","starred_url":"https://api.github.com/users/Pouix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pouix/subscriptions","organizations_url":"https://api.github.com/users/Pouix/orgs","repos_url":"https://api.github.com/users/Pouix/repos","events_url":"https://api.github.com/users/Pouix/events{/privacy}","received_events_url":"https://api.github.com/users/Pouix/received_events","type":"User","site_admin":false},"created_at":"2015-09-10T12:22:46Z","updated_at":"2015-09-10T12:22:46Z","body":"With the small test I added on RedisCache, another matter shows up:\r\nif the array $keys is empty, CacheProvider::fetchMultiple cashes because both parameters of array_combine should have at least 1 element (PHP 5.3).\r\n\r\nSo I removed my fix on RedisCache::fetchMultiple and put it into CacheProvider::fetchMultiple.\r\nBy doing so, both CacheProvider::fetchMultiple on PHP 5.3 and RedisCache::fetchMultiple on higher PHP version are fixed.\r\n\r\nI close this PR and open a new one => https://github.com/doctrine/cache/pull/90"}}