{"action":"closed","number":723,"pull_request":{"url":"https://api.github.com/repos/pulp/pulp_rpm/pulls/723","id":47188703,"html_url":"https://github.com/pulp/pulp_rpm/pull/723","diff_url":"https://github.com/pulp/pulp_rpm/pull/723.diff","patch_url":"https://github.com/pulp/pulp_rpm/pull/723.patch","issue_url":"https://api.github.com/repos/pulp/pulp_rpm/issues/723","number":723,"state":"closed","locked":false,"title":"patch an internal function that is not tested","user":{"login":"asmacdo","id":1028657,"avatar_url":"https://avatars.githubusercontent.com/u/1028657?v=3","gravatar_id":"","url":"https://api.github.com/users/asmacdo","html_url":"https://github.com/asmacdo","followers_url":"https://api.github.com/users/asmacdo/followers","following_url":"https://api.github.com/users/asmacdo/following{/other_user}","gists_url":"https://api.github.com/users/asmacdo/gists{/gist_id}","starred_url":"https://api.github.com/users/asmacdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asmacdo/subscriptions","organizations_url":"https://api.github.com/users/asmacdo/orgs","repos_url":"https://api.github.com/users/asmacdo/repos","events_url":"https://api.github.com/users/asmacdo/events{/privacy}","received_events_url":"https://api.github.com/users/asmacdo/received_events","type":"User","site_admin":false},"body":"This change in pulp caused two unit tests to break in pulp_rpm:\r\nhttps://github.com/pulp/pulp/pull/2037/files#diff-8613e089ba042e02761c8527b3c58905L221\r\n\r\nIn these tests using the old path, `types_db.type_definition(type_id)` returned `None`, which would cause problems except that there are no units, and iteration below never happened. This is fixed by mocking the whole function since it wasn't really being tested anyway.","created_at":"2015-10-08T18:28:26Z","updated_at":"2015-10-08T20:03:37Z","closed_at":"2015-10-08T20:03:37Z","merged_at":"2015-10-08T20:03:37Z","merge_commit_sha":"5a6ae42cafab534e6e1d8d682ed8d4710fe24edf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pulp/pulp_rpm/pulls/723/commits","review_comments_url":"https://api.github.com/repos/pulp/pulp_rpm/pulls/723/comments","review_comment_url":"https://api.github.com/repos/pulp/pulp_rpm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pulp/pulp_rpm/issues/723/comments","statuses_url":"https://api.github.com/repos/pulp/pulp_rpm/statuses/ab6c9ef833595f49ac88d3749245a36e65f7e19e","head":{"label":"pulp:fix-2-tests","ref":"fix-2-tests","sha":"ab6c9ef833595f49ac88d3749245a36e65f7e19e","user":{"login":"pulp","id":2103606,"avatar_url":"https://avatars.githubusercontent.com/u/2103606?v=3","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"repo":{"id":6106345,"name":"pulp_rpm","full_name":"pulp/pulp_rpm","owner":{"login":"pulp","id":2103606,"avatar_url":"https://avatars.githubusercontent.com/u/2103606?v=3","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pulp/pulp_rpm","description":"RPM support for Pulp Platform","fork":false,"url":"https://api.github.com/repos/pulp/pulp_rpm","forks_url":"https://api.github.com/repos/pulp/pulp_rpm/forks","keys_url":"https://api.github.com/repos/pulp/pulp_rpm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pulp/pulp_rpm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pulp/pulp_rpm/teams","hooks_url":"https://api.github.com/repos/pulp/pulp_rpm/hooks","issue_events_url":"https://api.github.com/repos/pulp/pulp_rpm/issues/events{/number}","events_url":"https://api.github.com/repos/pulp/pulp_rpm/events","assignees_url":"https://api.github.com/repos/pulp/pulp_rpm/assignees{/user}","branches_url":"https://api.github.com/repos/pulp/pulp_rpm/branches{/branch}","tags_url":"https://api.github.com/repos/pulp/pulp_rpm/tags","blobs_url":"https://api.github.com/repos/pulp/pulp_rpm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pulp/pulp_rpm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pulp/pulp_rpm/git/refs{/sha}","trees_url":"https://api.github.com/repos/pulp/pulp_rpm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pulp/pulp_rpm/statuses/{sha}","languages_url":"https://api.github.com/repos/pulp/pulp_rpm/languages","stargazers_url":"https://api.github.com/repos/pulp/pulp_rpm/stargazers","contributors_url":"https://api.github.com/repos/pulp/pulp_rpm/contributors","subscribers_url":"https://api.github.com/repos/pulp/pulp_rpm/subscribers","subscription_url":"https://api.github.com/repos/pulp/pulp_rpm/subscription","commits_url":"https://api.github.com/repos/pulp/pulp_rpm/commits{/sha}","git_commits_url":"https://api.github.com/repos/pulp/pulp_rpm/git/commits{/sha}","comments_url":"https://api.github.com/repos/pulp/pulp_rpm/comments{/number}","issue_comment_url":"https://api.github.com/repos/pulp/pulp_rpm/issues/comments{/number}","contents_url":"https://api.github.com/repos/pulp/pulp_rpm/contents/{+path}","compare_url":"https://api.github.com/repos/pulp/pulp_rpm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pulp/pulp_rpm/merges","archive_url":"https://api.github.com/repos/pulp/pulp_rpm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pulp/pulp_rpm/downloads","issues_url":"https://api.github.com/repos/pulp/pulp_rpm/issues{/number}","pulls_url":"https://api.github.com/repos/pulp/pulp_rpm/pulls{/number}","milestones_url":"https://api.github.com/repos/pulp/pulp_rpm/milestones{/number}","notifications_url":"https://api.github.com/repos/pulp/pulp_rpm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pulp/pulp_rpm/labels{/name}","releases_url":"https://api.github.com/repos/pulp/pulp_rpm/releases{/id}","created_at":"2012-10-06T20:06:16Z","updated_at":"2015-09-13T23:53:17Z","pushed_at":"2015-10-08T20:03:37Z","git_url":"git://github.com/pulp/pulp_rpm.git","ssh_url":"git@github.com:pulp/pulp_rpm.git","clone_url":"https://github.com/pulp/pulp_rpm.git","svn_url":"https://github.com/pulp/pulp_rpm","homepage":null,"size":49248,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":6,"forks":43,"open_issues":6,"watchers":10,"default_branch":"master"}},"base":{"label":"pulp:master","ref":"master","sha":"162e51f63fbf4aa788ada243ed3d57e51cb7ff28","user":{"login":"pulp","id":2103606,"avatar_url":"https://avatars.githubusercontent.com/u/2103606?v=3","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"repo":{"id":6106345,"name":"pulp_rpm","full_name":"pulp/pulp_rpm","owner":{"login":"pulp","id":2103606,"avatar_url":"https://avatars.githubusercontent.com/u/2103606?v=3","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pulp/pulp_rpm","description":"RPM support for Pulp Platform","fork":false,"url":"https://api.github.com/repos/pulp/pulp_rpm","forks_url":"https://api.github.com/repos/pulp/pulp_rpm/forks","keys_url":"https://api.github.com/repos/pulp/pulp_rpm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pulp/pulp_rpm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pulp/pulp_rpm/teams","hooks_url":"https://api.github.com/repos/pulp/pulp_rpm/hooks","issue_events_url":"https://api.github.com/repos/pulp/pulp_rpm/issues/events{/number}","events_url":"https://api.github.com/repos/pulp/pulp_rpm/events","assignees_url":"https://api.github.com/repos/pulp/pulp_rpm/assignees{/user}","branches_url":"https://api.github.com/repos/pulp/pulp_rpm/branches{/branch}","tags_url":"https://api.github.com/repos/pulp/pulp_rpm/tags","blobs_url":"https://api.github.com/repos/pulp/pulp_rpm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pulp/pulp_rpm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pulp/pulp_rpm/git/refs{/sha}","trees_url":"https://api.github.com/repos/pulp/pulp_rpm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pulp/pulp_rpm/statuses/{sha}","languages_url":"https://api.github.com/repos/pulp/pulp_rpm/languages","stargazers_url":"https://api.github.com/repos/pulp/pulp_rpm/stargazers","contributors_url":"https://api.github.com/repos/pulp/pulp_rpm/contributors","subscribers_url":"https://api.github.com/repos/pulp/pulp_rpm/subscribers","subscription_url":"https://api.github.com/repos/pulp/pulp_rpm/subscription","commits_url":"https://api.github.com/repos/pulp/pulp_rpm/commits{/sha}","git_commits_url":"https://api.github.com/repos/pulp/pulp_rpm/git/commits{/sha}","comments_url":"https://api.github.com/repos/pulp/pulp_rpm/comments{/number}","issue_comment_url":"https://api.github.com/repos/pulp/pulp_rpm/issues/comments{/number}","contents_url":"https://api.github.com/repos/pulp/pulp_rpm/contents/{+path}","compare_url":"https://api.github.com/repos/pulp/pulp_rpm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pulp/pulp_rpm/merges","archive_url":"https://api.github.com/repos/pulp/pulp_rpm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pulp/pulp_rpm/downloads","issues_url":"https://api.github.com/repos/pulp/pulp_rpm/issues{/number}","pulls_url":"https://api.github.com/repos/pulp/pulp_rpm/pulls{/number}","milestones_url":"https://api.github.com/repos/pulp/pulp_rpm/milestones{/number}","notifications_url":"https://api.github.com/repos/pulp/pulp_rpm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pulp/pulp_rpm/labels{/name}","releases_url":"https://api.github.com/repos/pulp/pulp_rpm/releases{/id}","created_at":"2012-10-06T20:06:16Z","updated_at":"2015-09-13T23:53:17Z","pushed_at":"2015-10-08T20:03:37Z","git_url":"git://github.com/pulp/pulp_rpm.git","ssh_url":"git@github.com:pulp/pulp_rpm.git","clone_url":"https://github.com/pulp/pulp_rpm.git","svn_url":"https://github.com/pulp/pulp_rpm","homepage":null,"size":49248,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":6,"forks":43,"open_issues":6,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pulp/pulp_rpm/pulls/723"},"html":{"href":"https://github.com/pulp/pulp_rpm/pull/723"},"issue":{"href":"https://api.github.com/repos/pulp/pulp_rpm/issues/723"},"comments":{"href":"https://api.github.com/repos/pulp/pulp_rpm/issues/723/comments"},"review_comments":{"href":"https://api.github.com/repos/pulp/pulp_rpm/pulls/723/comments"},"review_comment":{"href":"https://api.github.com/repos/pulp/pulp_rpm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pulp/pulp_rpm/pulls/723/commits"},"statuses":{"href":"https://api.github.com/repos/pulp/pulp_rpm/statuses/ab6c9ef833595f49ac88d3749245a36e65f7e19e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"asmacdo","id":1028657,"avatar_url":"https://avatars.githubusercontent.com/u/1028657?v=3","gravatar_id":"","url":"https://api.github.com/users/asmacdo","html_url":"https://github.com/asmacdo","followers_url":"https://api.github.com/users/asmacdo/followers","following_url":"https://api.github.com/users/asmacdo/following{/other_user}","gists_url":"https://api.github.com/users/asmacdo/gists{/gist_id}","starred_url":"https://api.github.com/users/asmacdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asmacdo/subscriptions","organizations_url":"https://api.github.com/users/asmacdo/orgs","repos_url":"https://api.github.com/users/asmacdo/repos","events_url":"https://api.github.com/users/asmacdo/events{/privacy}","received_events_url":"https://api.github.com/users/asmacdo/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":4,"deletions":2,"changed_files":1}}