{"action":"created","issue":{"url":"https://api.github.com/repos/HiSPARC/sapphire/issues/67","labels_url":"https://api.github.com/repos/HiSPARC/sapphire/issues/67/labels{/name}","comments_url":"https://api.github.com/repos/HiSPARC/sapphire/issues/67/comments","events_url":"https://api.github.com/repos/HiSPARC/sapphire/issues/67/events","html_url":"https://github.com/HiSPARC/sapphire/issues/67","id":84491671,"number":67,"title":"esd module assigns wrong 'event_ids'","user":{"login":"153957","id":1433682,"avatar_url":"https://avatars.githubusercontent.com/u/1433682?v=3","gravatar_id":"","url":"https://api.github.com/users/153957","html_url":"https://github.com/153957","followers_url":"https://api.github.com/users/153957/followers","following_url":"https://api.github.com/users/153957/following{/other_user}","gists_url":"https://api.github.com/users/153957/gists{/gist_id}","starred_url":"https://api.github.com/users/153957/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/153957/subscriptions","organizations_url":"https://api.github.com/users/153957/orgs","repos_url":"https://api.github.com/users/153957/repos","events_url":"https://api.github.com/users/153957/events{/privacy}","received_events_url":"https://api.github.com/users/153957/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-06-03T10:50:25Z","updated_at":"2015-06-03T12:35:59Z","closed_at":"2015-06-03T12:35:59Z","body":"All event_ids currently become 0, instead of the row number. This is because of the changes in 892456b766408b1837113235ecccdcad3f5ebfc0\r\nIf a `table.flush()` is added after the `row.append()` it works correctly again.\r\nBut check the performance first, perhaps we should just check the existing length at start and the manually increment/enumerate from there. Or normalize the event_ids afterwards like in [`process_events`](https://github.com/HiSPARC/sapphire/blob/master/sapphire/analysis/process_events.py#L229)"},"comment":{"url":"https://api.github.com/repos/HiSPARC/sapphire/issues/comments/108373923","html_url":"https://github.com/HiSPARC/sapphire/issues/67#issuecomment-108373923","issue_url":"https://api.github.com/repos/HiSPARC/sapphire/issues/67","id":108373923,"user":{"login":"153957","id":1433682,"avatar_url":"https://avatars.githubusercontent.com/u/1433682?v=3","gravatar_id":"","url":"https://api.github.com/users/153957","html_url":"https://github.com/153957","followers_url":"https://api.github.com/users/153957/followers","following_url":"https://api.github.com/users/153957/following{/other_user}","gists_url":"https://api.github.com/users/153957/gists{/gist_id}","starred_url":"https://api.github.com/users/153957/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/153957/subscriptions","organizations_url":"https://api.github.com/users/153957/orgs","repos_url":"https://api.github.com/users/153957/repos","events_url":"https://api.github.com/users/153957/events{/privacy}","received_events_url":"https://api.github.com/users/153957/received_events","type":"User","site_admin":false},"created_at":"2015-06-03T12:35:59Z","updated_at":"2015-06-03T12:35:59Z","body":"Fixed in 1580c44, unfortunately this negates the performance gains..\r\nSelf incrementing the ids should also work, but requires some extra care to properly implement for downloading coincidences.."}}