{"action":"created","issue":{"url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/843","labels_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/843/labels{/name}","comments_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/843/comments","events_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/843/events","html_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/843","id":113920066,"number":843,"title":"add ftrl early stopping","user":{"login":"zachmayer","id":581590,"avatar_url":"https://avatars.githubusercontent.com/u/581590?v=3","gravatar_id":"","url":"https://api.github.com/users/zachmayer","html_url":"https://github.com/zachmayer","followers_url":"https://api.github.com/users/zachmayer/followers","following_url":"https://api.github.com/users/zachmayer/following{/other_user}","gists_url":"https://api.github.com/users/zachmayer/gists{/gist_id}","starred_url":"https://api.github.com/users/zachmayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachmayer/subscriptions","organizations_url":"https://api.github.com/users/zachmayer/orgs","repos_url":"https://api.github.com/users/zachmayer/repos","events_url":"https://api.github.com/users/zachmayer/events{/privacy}","received_events_url":"https://api.github.com/users/zachmayer/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-10-28T20:55:45Z","updated_at":"2015-10-29T00:58:06Z","closed_at":"2015-10-29T00:07:19Z","pull_request":{"url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/843","html_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/843","diff_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/843.diff","patch_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/843.patch"},"body":"Test pass for me locally and the `--early_stopping` flag for `--ftrl` seems to work, but this is the first piece of C++ code I've ~~written~~ copy/pasted in 15 years, so review carefully:\r\n![image](https://cloud.githubusercontent.com/assets/581590/10802709/b5ed32b8-7d94-11e5-891a-06dbe65efc9d.png)\r\n"},"comment":{"url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/comments/152043679","html_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/843#issuecomment-152043679","issue_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/843","id":152043679,"user":{"login":"JohnLangford","id":79590,"avatar_url":"https://avatars.githubusercontent.com/u/79590?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnLangford","html_url":"https://github.com/JohnLangford","followers_url":"https://api.github.com/users/JohnLangford/followers","following_url":"https://api.github.com/users/JohnLangford/following{/other_user}","gists_url":"https://api.github.com/users/JohnLangford/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnLangford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnLangford/subscriptions","organizations_url":"https://api.github.com/users/JohnLangford/orgs","repos_url":"https://api.github.com/users/JohnLangford/repos","events_url":"https://api.github.com/users/JohnLangford/events{/privacy}","received_events_url":"https://api.github.com/users/JohnLangford/received_events","type":"User","site_admin":false},"created_at":"2015-10-29T00:58:06Z","updated_at":"2015-10-29T00:58:06Z","body":"If there was a directory of tests and people had meaningful names for \ntests, perhaps that would work better?\n\nHistorically, the window of collisions is not so short because I often \nam busy for several days before I can deal with pull requests.\n\n-John\n\nOn 10/28/2015 08:53 PM, Ariel Faigon wrote:\n>\n> As a good practice, I always |git pull jl master| before pushing any \n> of my own changes. This way I catch conflicts locally rather than \n> having someone else hit them. Even then there could be a short window \n> of possible collision. That's why git merging is there.\n>\n> We could place tests as separate files in a test-data dir, instead of \n> in the RunTests script, but this may not avoid people trying to create \n> the same \"test.099\" file with different contents... Unless I \n> misunderstand the problem and perceived solution.\n>\n> —\n> Reply to this email directly or view it on GitHub \n> <https://github.com/JohnLangford/vowpal_wabbit/pull/843#issuecomment-152043197>.\n>\n\n"}}