{"action":"created","comment":{"url":"https://api.github.com/repos/Katello/katello/pulls/comments/22958725","id":22958725,"diff_hunk":"@@ -108,7 +100,34 @@ chmod +x %{buildroot}%{homedir}/script/*\n # install man page\n install -m 644 man/katello-service.8 %{buildroot}/%{_mandir}/man8\n \n-%post\n+%clean\n+rm -rf %{buildroot}\n+\n+%files \n+\n+# ------ Common ------------------\n+\n+%package common\n+BuildArch:  noarch\n+Summary:    Common runtime components of %{name}\n+\n+# service-wait dependency\n+Requires:       wget\n+Requires:       curl\n+Requires:       %{?scl_prefix}rubygem-katello\n+Requires:       %{name}-installer\n+Requires:       rubygem-hammer_cli \n+Requires:       rubygem-hammer_cli_foreman\n+Requires:       rubygem-hammer_cli_katello\n+Requires:       rubygem-hammer_cli_import\n+Requires:       gutterball","path":"deploy/katello.spec","position":55,"original_position":55,"commit_id":"51be7c8cd03cf8f45719762392f90bc95527418a","original_commit_id":"51be7c8cd03cf8f45719762392f90bc95527418a","user":{"login":"ehelms","id":293363,"avatar_url":"https://avatars.githubusercontent.com/u/293363?v=3","gravatar_id":"","url":"https://api.github.com/users/ehelms","html_url":"https://github.com/ehelms","followers_url":"https://api.github.com/users/ehelms/followers","following_url":"https://api.github.com/users/ehelms/following{/other_user}","gists_url":"https://api.github.com/users/ehelms/gists{/gist_id}","starred_url":"https://api.github.com/users/ehelms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehelms/subscriptions","organizations_url":"https://api.github.com/users/ehelms/orgs","repos_url":"https://api.github.com/users/ehelms/repos","events_url":"https://api.github.com/users/ehelms/events{/privacy}","received_events_url":"https://api.github.com/users/ehelms/received_events","type":"User","site_admin":false},"body":"Shouldn't the foreman_gutterball gem handle this dependency for us?","created_at":"2015-01-14T18:42:02Z","updated_at":"2015-01-14T18:42:02Z","html_url":"https://github.com/Katello/katello/pull/4923#discussion_r22958725","pull_request_url":"https://api.github.com/repos/Katello/katello/pulls/4923","_links":{"self":{"href":"https://api.github.com/repos/Katello/katello/pulls/comments/22958725"},"html":{"href":"https://github.com/Katello/katello/pull/4923#discussion_r22958725"},"pull_request":{"href":"https://api.github.com/repos/Katello/katello/pulls/4923"}}},"pull_request":{"url":"https://api.github.com/repos/Katello/katello/pulls/4923","id":27311790,"html_url":"https://github.com/Katello/katello/pull/4923","diff_url":"https://github.com/Katello/katello/pull/4923.diff","patch_url":"https://github.com/Katello/katello/pull/4923.patch","issue_url":"https://api.github.com/repos/Katello/katello/issues/4923","number":4923,"state":"open","locked":false,"title":"refs #8213 - split out katello package into modular sub-packages","user":{"login":"mccun934","id":206457,"avatar_url":"https://avatars.githubusercontent.com/u/206457?v=3","gravatar_id":"","url":"https://api.github.com/users/mccun934","html_url":"https://github.com/mccun934","followers_url":"https://api.github.com/users/mccun934/followers","following_url":"https://api.github.com/users/mccun934/following{/other_user}","gists_url":"https://api.github.com/users/mccun934/gists{/gist_id}","starred_url":"https://api.github.com/users/mccun934/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mccun934/subscriptions","organizations_url":"https://api.github.com/users/mccun934/orgs","repos_url":"https://api.github.com/users/mccun934/repos","events_url":"https://api.github.com/users/mccun934/events{/privacy}","received_events_url":"https://api.github.com/users/mccun934/received_events","type":"User","site_admin":false},"body":"Splits katello's meta-package into a -common and -sam package so we can install without Foreman's provisioning plugins which aren't needed in the SAM use case","created_at":"2015-01-13T22:42:27Z","updated_at":"2015-01-14T18:42:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9e9a2caec666483ebdb8d3c96c440c2cbb4e18e","assignee":{"login":"ehelms","id":293363,"avatar_url":"https://avatars.githubusercontent.com/u/293363?v=3","gravatar_id":"","url":"https://api.github.com/users/ehelms","html_url":"https://github.com/ehelms","followers_url":"https://api.github.com/users/ehelms/followers","following_url":"https://api.github.com/users/ehelms/following{/other_user}","gists_url":"https://api.github.com/users/ehelms/gists{/gist_id}","starred_url":"https://api.github.com/users/ehelms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehelms/subscriptions","organizations_url":"https://api.github.com/users/ehelms/orgs","repos_url":"https://api.github.com/users/ehelms/repos","events_url":"https://api.github.com/users/ehelms/events{/privacy}","received_events_url":"https://api.github.com/users/ehelms/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Katello/katello/pulls/4923/commits","review_comments_url":"https://api.github.com/repos/Katello/katello/pulls/4923/comments","review_comment_url":"https://api.github.com/repos/Katello/katello/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Katello/katello/issues/4923/comments","statuses_url":"https://api.github.com/repos/Katello/katello/statuses/51be7c8cd03cf8f45719762392f90bc95527418a","head":{"label":"mccun934:20150109-1447","ref":"20150109-1447","sha":"51be7c8cd03cf8f45719762392f90bc95527418a","user":{"login":"mccun934","id":206457,"avatar_url":"https://avatars.githubusercontent.com/u/206457?v=3","gravatar_id":"","url":"https://api.github.com/users/mccun934","html_url":"https://github.com/mccun934","followers_url":"https://api.github.com/users/mccun934/followers","following_url":"https://api.github.com/users/mccun934/following{/other_user}","gists_url":"https://api.github.com/users/mccun934/gists{/gist_id}","starred_url":"https://api.github.com/users/mccun934/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mccun934/subscriptions","organizations_url":"https://api.github.com/users/mccun934/orgs","repos_url":"https://api.github.com/users/mccun934/repos","events_url":"https://api.github.com/users/mccun934/events{/privacy}","received_events_url":"https://api.github.com/users/mccun934/received_events","type":"User","site_admin":false},"repo":{"id":5972947,"name":"katello","full_name":"mccun934/katello","owner":{"login":"mccun934","id":206457,"avatar_url":"https://avatars.githubusercontent.com/u/206457?v=3","gravatar_id":"","url":"https://api.github.com/users/mccun934","html_url":"https://github.com/mccun934","followers_url":"https://api.github.com/users/mccun934/followers","following_url":"https://api.github.com/users/mccun934/following{/other_user}","gists_url":"https://api.github.com/users/mccun934/gists{/gist_id}","starred_url":"https://api.github.com/users/mccun934/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mccun934/subscriptions","organizations_url":"https://api.github.com/users/mccun934/orgs","repos_url":"https://api.github.com/users/mccun934/repos","events_url":"https://api.github.com/users/mccun934/events{/privacy}","received_events_url":"https://api.github.com/users/mccun934/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mccun934/katello","description":"Katello integrates open source systems management tools into a single solution for controlling the lifecycle of your machines.","fork":true,"url":"https://api.github.com/repos/mccun934/katello","forks_url":"https://api.github.com/repos/mccun934/katello/forks","keys_url":"https://api.github.com/repos/mccun934/katello/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mccun934/katello/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mccun934/katello/teams","hooks_url":"https://api.github.com/repos/mccun934/katello/hooks","issue_events_url":"https://api.github.com/repos/mccun934/katello/issues/events{/number}","events_url":"https://api.github.com/repos/mccun934/katello/events","assignees_url":"https://api.github.com/repos/mccun934/katello/assignees{/user}","branches_url":"https://api.github.com/repos/mccun934/katello/branches{/branch}","tags_url":"https://api.github.com/repos/mccun934/katello/tags","blobs_url":"https://api.github.com/repos/mccun934/katello/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mccun934/katello/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mccun934/katello/git/refs{/sha}","trees_url":"https://api.github.com/repos/mccun934/katello/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mccun934/katello/statuses/{sha}","languages_url":"https://api.github.com/repos/mccun934/katello/languages","stargazers_url":"https://api.github.com/repos/mccun934/katello/stargazers","contributors_url":"https://api.github.com/repos/mccun934/katello/contributors","subscribers_url":"https://api.github.com/repos/mccun934/katello/subscribers","subscription_url":"https://api.github.com/repos/mccun934/katello/subscription","commits_url":"https://api.github.com/repos/mccun934/katello/commits{/sha}","git_commits_url":"https://api.github.com/repos/mccun934/katello/git/commits{/sha}","comments_url":"https://api.github.com/repos/mccun934/katello/comments{/number}","issue_comment_url":"https://api.github.com/repos/mccun934/katello/issues/comments/{number}","contents_url":"https://api.github.com/repos/mccun934/katello/contents/{+path}","compare_url":"https://api.github.com/repos/mccun934/katello/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mccun934/katello/merges","archive_url":"https://api.github.com/repos/mccun934/katello/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mccun934/katello/downloads","issues_url":"https://api.github.com/repos/mccun934/katello/issues{/number}","pulls_url":"https://api.github.com/repos/mccun934/katello/pulls{/number}","milestones_url":"https://api.github.com/repos/mccun934/katello/milestones{/number}","notifications_url":"https://api.github.com/repos/mccun934/katello/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mccun934/katello/labels{/name}","releases_url":"https://api.github.com/repos/mccun934/katello/releases{/id}","created_at":"2012-09-26T21:37:17Z","updated_at":"2015-01-09T22:16:03Z","pushed_at":"2015-01-14T17:57:50Z","git_url":"git://github.com/mccun934/katello.git","ssh_url":"git@github.com:mccun934/katello.git","clone_url":"https://github.com/mccun934/katello.git","svn_url":"https://github.com/mccun934/katello","homepage":"katello.org","size":71455,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Katello:master","ref":"master","sha":"be1c61cc47b6d61fc1e124d4123f34eb370b3222","user":{"login":"Katello","id":1316386,"avatar_url":"https://avatars.githubusercontent.com/u/1316386?v=3","gravatar_id":"","url":"https://api.github.com/users/Katello","html_url":"https://github.com/Katello","followers_url":"https://api.github.com/users/Katello/followers","following_url":"https://api.github.com/users/Katello/following{/other_user}","gists_url":"https://api.github.com/users/Katello/gists{/gist_id}","starred_url":"https://api.github.com/users/Katello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katello/subscriptions","organizations_url":"https://api.github.com/users/Katello/orgs","repos_url":"https://api.github.com/users/Katello/repos","events_url":"https://api.github.com/users/Katello/events{/privacy}","received_events_url":"https://api.github.com/users/Katello/received_events","type":"Organization","site_admin":false},"repo":{"id":4007018,"name":"katello","full_name":"Katello/katello","owner":{"login":"Katello","id":1316386,"avatar_url":"https://avatars.githubusercontent.com/u/1316386?v=3","gravatar_id":"","url":"https://api.github.com/users/Katello","html_url":"https://github.com/Katello","followers_url":"https://api.github.com/users/Katello/followers","following_url":"https://api.github.com/users/Katello/following{/other_user}","gists_url":"https://api.github.com/users/Katello/gists{/gist_id}","starred_url":"https://api.github.com/users/Katello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katello/subscriptions","organizations_url":"https://api.github.com/users/Katello/orgs","repos_url":"https://api.github.com/users/Katello/repos","events_url":"https://api.github.com/users/Katello/events{/privacy}","received_events_url":"https://api.github.com/users/Katello/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Katello/katello","description":"Katello integrates open source systems management tools into a single solution for controlling the lifecycle of your machines.","fork":false,"url":"https://api.github.com/repos/Katello/katello","forks_url":"https://api.github.com/repos/Katello/katello/forks","keys_url":"https://api.github.com/repos/Katello/katello/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Katello/katello/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Katello/katello/teams","hooks_url":"https://api.github.com/repos/Katello/katello/hooks","issue_events_url":"https://api.github.com/repos/Katello/katello/issues/events{/number}","events_url":"https://api.github.com/repos/Katello/katello/events","assignees_url":"https://api.github.com/repos/Katello/katello/assignees{/user}","branches_url":"https://api.github.com/repos/Katello/katello/branches{/branch}","tags_url":"https://api.github.com/repos/Katello/katello/tags","blobs_url":"https://api.github.com/repos/Katello/katello/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Katello/katello/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Katello/katello/git/refs{/sha}","trees_url":"https://api.github.com/repos/Katello/katello/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Katello/katello/statuses/{sha}","languages_url":"https://api.github.com/repos/Katello/katello/languages","stargazers_url":"https://api.github.com/repos/Katello/katello/stargazers","contributors_url":"https://api.github.com/repos/Katello/katello/contributors","subscribers_url":"https://api.github.com/repos/Katello/katello/subscribers","subscription_url":"https://api.github.com/repos/Katello/katello/subscription","commits_url":"https://api.github.com/repos/Katello/katello/commits{/sha}","git_commits_url":"https://api.github.com/repos/Katello/katello/git/commits{/sha}","comments_url":"https://api.github.com/repos/Katello/katello/comments{/number}","issue_comment_url":"https://api.github.com/repos/Katello/katello/issues/comments/{number}","contents_url":"https://api.github.com/repos/Katello/katello/contents/{+path}","compare_url":"https://api.github.com/repos/Katello/katello/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Katello/katello/merges","archive_url":"https://api.github.com/repos/Katello/katello/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Katello/katello/downloads","issues_url":"https://api.github.com/repos/Katello/katello/issues{/number}","pulls_url":"https://api.github.com/repos/Katello/katello/pulls{/number}","milestones_url":"https://api.github.com/repos/Katello/katello/milestones{/number}","notifications_url":"https://api.github.com/repos/Katello/katello/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Katello/katello/labels{/name}","releases_url":"https://api.github.com/repos/Katello/katello/releases{/id}","created_at":"2012-04-12T16:59:08Z","updated_at":"2015-01-14T15:20:03Z","pushed_at":"2015-01-14T15:20:03Z","git_url":"git://github.com/Katello/katello.git","ssh_url":"git@github.com:Katello/katello.git","clone_url":"https://github.com/Katello/katello.git","svn_url":"https://github.com/Katello/katello","homepage":"katello.org","size":226965,"stargazers_count":147,"watchers_count":147,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":99,"mirror_url":null,"open_issues_count":106,"forks":99,"open_issues":106,"watchers":147,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Katello/katello/pulls/4923"},"html":{"href":"https://github.com/Katello/katello/pull/4923"},"issue":{"href":"https://api.github.com/repos/Katello/katello/issues/4923"},"comments":{"href":"https://api.github.com/repos/Katello/katello/issues/4923/comments"},"review_comments":{"href":"https://api.github.com/repos/Katello/katello/pulls/4923/comments"},"review_comment":{"href":"https://api.github.com/repos/Katello/katello/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Katello/katello/pulls/4923/commits"},"statuses":{"href":"https://api.github.com/repos/Katello/katello/statuses/51be7c8cd03cf8f45719762392f90bc95527418a"}}}}