{"action":"created","comment":{"url":"https://api.github.com/repos/ReactiveX/RxJava/pulls/comments/26464396","id":26464396,"diff_hunk":"@@ -109,7 +109,7 @@ public void onNext(T v) {\n                         };\n                         // register this Subscription (and unsubscribe previous if exists) \n                         serialSubscription.set(subscriber);\n-                        o.unsafeSubscribe(subscriber);\n+                        o.subscribe(subscriber);","path":"src/main/java/rx/internal/operators/OperatorRetryWithPredicate.java","position":5,"original_position":5,"commit_id":"21569f9c4501da1452c518cbbf961d02bdb077cf","original_commit_id":"21569f9c4501da1452c518cbbf961d02bdb077cf","user":{"login":"akarnokd","id":1269832,"avatar_url":"https://avatars.githubusercontent.com/u/1269832?v=3","gravatar_id":"","url":"https://api.github.com/users/akarnokd","html_url":"https://github.com/akarnokd","followers_url":"https://api.github.com/users/akarnokd/followers","following_url":"https://api.github.com/users/akarnokd/following{/other_user}","gists_url":"https://api.github.com/users/akarnokd/gists{/gist_id}","starred_url":"https://api.github.com/users/akarnokd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akarnokd/subscriptions","organizations_url":"https://api.github.com/users/akarnokd/orgs","repos_url":"https://api.github.com/users/akarnokd/repos","events_url":"https://api.github.com/users/akarnokd/events{/privacy}","received_events_url":"https://api.github.com/users/akarnokd/received_events","type":"User","site_admin":false},"body":"Instead of this, I'd add a done flag to the inner Subscriber to ignore any subsequent events; should be more lightweight.","created_at":"2015-03-16T07:43:14Z","updated_at":"2015-03-16T07:43:14Z","html_url":"https://github.com/ReactiveX/RxJava/pull/2827#discussion_r26464396","pull_request_url":"https://api.github.com/repos/ReactiveX/RxJava/pulls/2827","_links":{"self":{"href":"https://api.github.com/repos/ReactiveX/RxJava/pulls/comments/26464396"},"html":{"href":"https://github.com/ReactiveX/RxJava/pull/2827#discussion_r26464396"},"pull_request":{"href":"https://api.github.com/repos/ReactiveX/RxJava/pulls/2827"}}},"pull_request":{"url":"https://api.github.com/repos/ReactiveX/RxJava/pulls/2827","id":31207519,"html_url":"https://github.com/ReactiveX/RxJava/pull/2827","diff_url":"https://github.com/ReactiveX/RxJava/pull/2827.diff","patch_url":"https://github.com/ReactiveX/RxJava/pull/2827.patch","issue_url":"https://api.github.com/repos/ReactiveX/RxJava/issues/2827","number":2827,"state":"open","locked":false,"title":"The retry with predicate wasn't behaving correctly when it used unsafeSubscribe","user":{"login":"abersnaze","id":406038,"avatar_url":"https://avatars.githubusercontent.com/u/406038?v=3","gravatar_id":"","url":"https://api.github.com/users/abersnaze","html_url":"https://github.com/abersnaze","followers_url":"https://api.github.com/users/abersnaze/followers","following_url":"https://api.github.com/users/abersnaze/following{/other_user}","gists_url":"https://api.github.com/users/abersnaze/gists{/gist_id}","starred_url":"https://api.github.com/users/abersnaze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abersnaze/subscriptions","organizations_url":"https://api.github.com/users/abersnaze/orgs","repos_url":"https://api.github.com/users/abersnaze/repos","events_url":"https://api.github.com/users/abersnaze/events{/privacy}","received_events_url":"https://api.github.com/users/abersnaze/received_events","type":"User","site_admin":false},"body":"For #2826\r\nThe `ScalarSynchronousObservable` and `OperatorRetryWithPredicate` both assume that everyone else obey the rules so they don't have to.  Bad things happen when they are used together.","created_at":"2015-03-15T21:19:49Z","updated_at":"2015-03-16T07:43:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"521ac74cdd388e2e074a8b9d87cd0ef1f6c2f7d5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ReactiveX/RxJava/pulls/2827/commits","review_comments_url":"https://api.github.com/repos/ReactiveX/RxJava/pulls/2827/comments","review_comment_url":"https://api.github.com/repos/ReactiveX/RxJava/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactiveX/RxJava/issues/2827/comments","statuses_url":"https://api.github.com/repos/ReactiveX/RxJava/statuses/21569f9c4501da1452c518cbbf961d02bdb077cf","head":{"label":"abersnaze:retry-safe-subscriber","ref":"retry-safe-subscriber","sha":"21569f9c4501da1452c518cbbf961d02bdb077cf","user":{"login":"abersnaze","id":406038,"avatar_url":"https://avatars.githubusercontent.com/u/406038?v=3","gravatar_id":"","url":"https://api.github.com/users/abersnaze","html_url":"https://github.com/abersnaze","followers_url":"https://api.github.com/users/abersnaze/followers","following_url":"https://api.github.com/users/abersnaze/following{/other_user}","gists_url":"https://api.github.com/users/abersnaze/gists{/gist_id}","starred_url":"https://api.github.com/users/abersnaze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abersnaze/subscriptions","organizations_url":"https://api.github.com/users/abersnaze/orgs","repos_url":"https://api.github.com/users/abersnaze/repos","events_url":"https://api.github.com/users/abersnaze/events{/privacy}","received_events_url":"https://api.github.com/users/abersnaze/received_events","type":"User","site_admin":false},"repo":{"id":7616124,"name":"RxJava","full_name":"abersnaze/RxJava","owner":{"login":"abersnaze","id":406038,"avatar_url":"https://avatars.githubusercontent.com/u/406038?v=3","gravatar_id":"","url":"https://api.github.com/users/abersnaze","html_url":"https://github.com/abersnaze","followers_url":"https://api.github.com/users/abersnaze/followers","following_url":"https://api.github.com/users/abersnaze/following{/other_user}","gists_url":"https://api.github.com/users/abersnaze/gists{/gist_id}","starred_url":"https://api.github.com/users/abersnaze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abersnaze/subscriptions","organizations_url":"https://api.github.com/users/abersnaze/orgs","repos_url":"https://api.github.com/users/abersnaze/repos","events_url":"https://api.github.com/users/abersnaze/events{/privacy}","received_events_url":"https://api.github.com/users/abersnaze/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abersnaze/RxJava","description":"","fork":true,"url":"https://api.github.com/repos/abersnaze/RxJava","forks_url":"https://api.github.com/repos/abersnaze/RxJava/forks","keys_url":"https://api.github.com/repos/abersnaze/RxJava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abersnaze/RxJava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abersnaze/RxJava/teams","hooks_url":"https://api.github.com/repos/abersnaze/RxJava/hooks","issue_events_url":"https://api.github.com/repos/abersnaze/RxJava/issues/events{/number}","events_url":"https://api.github.com/repos/abersnaze/RxJava/events","assignees_url":"https://api.github.com/repos/abersnaze/RxJava/assignees{/user}","branches_url":"https://api.github.com/repos/abersnaze/RxJava/branches{/branch}","tags_url":"https://api.github.com/repos/abersnaze/RxJava/tags","blobs_url":"https://api.github.com/repos/abersnaze/RxJava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abersnaze/RxJava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abersnaze/RxJava/git/refs{/sha}","trees_url":"https://api.github.com/repos/abersnaze/RxJava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abersnaze/RxJava/statuses/{sha}","languages_url":"https://api.github.com/repos/abersnaze/RxJava/languages","stargazers_url":"https://api.github.com/repos/abersnaze/RxJava/stargazers","contributors_url":"https://api.github.com/repos/abersnaze/RxJava/contributors","subscribers_url":"https://api.github.com/repos/abersnaze/RxJava/subscribers","subscription_url":"https://api.github.com/repos/abersnaze/RxJava/subscription","commits_url":"https://api.github.com/repos/abersnaze/RxJava/commits{/sha}","git_commits_url":"https://api.github.com/repos/abersnaze/RxJava/git/commits{/sha}","comments_url":"https://api.github.com/repos/abersnaze/RxJava/comments{/number}","issue_comment_url":"https://api.github.com/repos/abersnaze/RxJava/issues/comments{/number}","contents_url":"https://api.github.com/repos/abersnaze/RxJava/contents/{+path}","compare_url":"https://api.github.com/repos/abersnaze/RxJava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abersnaze/RxJava/merges","archive_url":"https://api.github.com/repos/abersnaze/RxJava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abersnaze/RxJava/downloads","issues_url":"https://api.github.com/repos/abersnaze/RxJava/issues{/number}","pulls_url":"https://api.github.com/repos/abersnaze/RxJava/pulls{/number}","milestones_url":"https://api.github.com/repos/abersnaze/RxJava/milestones{/number}","notifications_url":"https://api.github.com/repos/abersnaze/RxJava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abersnaze/RxJava/labels{/name}","releases_url":"https://api.github.com/repos/abersnaze/RxJava/releases{/id}","created_at":"2013-01-15T01:05:07Z","updated_at":"2014-06-30T17:51:06Z","pushed_at":"2015-03-15T21:14:52Z","git_url":"git://github.com/abersnaze/RxJava.git","ssh_url":"git@github.com:abersnaze/RxJava.git","clone_url":"https://github.com/abersnaze/RxJava.git","svn_url":"https://github.com/abersnaze/RxJava","homepage":null,"size":17377,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ReactiveX:1.x","ref":"1.x","sha":"c4f611be52c249ee0d8526299f959d3660423a3f","user":{"login":"ReactiveX","id":6407041,"avatar_url":"https://avatars.githubusercontent.com/u/6407041?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"repo":{"id":7508411,"name":"RxJava","full_name":"ReactiveX/RxJava","owner":{"login":"ReactiveX","id":6407041,"avatar_url":"https://avatars.githubusercontent.com/u/6407041?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactiveX/RxJava","description":"RxJava – Reactive Extensions for the JVM – a library for composing asynchronous and event-based programs using observable sequences for the Java VM.","fork":false,"url":"https://api.github.com/repos/ReactiveX/RxJava","forks_url":"https://api.github.com/repos/ReactiveX/RxJava/forks","keys_url":"https://api.github.com/repos/ReactiveX/RxJava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactiveX/RxJava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactiveX/RxJava/teams","hooks_url":"https://api.github.com/repos/ReactiveX/RxJava/hooks","issue_events_url":"https://api.github.com/repos/ReactiveX/RxJava/issues/events{/number}","events_url":"https://api.github.com/repos/ReactiveX/RxJava/events","assignees_url":"https://api.github.com/repos/ReactiveX/RxJava/assignees{/user}","branches_url":"https://api.github.com/repos/ReactiveX/RxJava/branches{/branch}","tags_url":"https://api.github.com/repos/ReactiveX/RxJava/tags","blobs_url":"https://api.github.com/repos/ReactiveX/RxJava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactiveX/RxJava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactiveX/RxJava/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactiveX/RxJava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactiveX/RxJava/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactiveX/RxJava/languages","stargazers_url":"https://api.github.com/repos/ReactiveX/RxJava/stargazers","contributors_url":"https://api.github.com/repos/ReactiveX/RxJava/contributors","subscribers_url":"https://api.github.com/repos/ReactiveX/RxJava/subscribers","subscription_url":"https://api.github.com/repos/ReactiveX/RxJava/subscription","commits_url":"https://api.github.com/repos/ReactiveX/RxJava/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactiveX/RxJava/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactiveX/RxJava/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactiveX/RxJava/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactiveX/RxJava/contents/{+path}","compare_url":"https://api.github.com/repos/ReactiveX/RxJava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactiveX/RxJava/merges","archive_url":"https://api.github.com/repos/ReactiveX/RxJava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactiveX/RxJava/downloads","issues_url":"https://api.github.com/repos/ReactiveX/RxJava/issues{/number}","pulls_url":"https://api.github.com/repos/ReactiveX/RxJava/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactiveX/RxJava/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactiveX/RxJava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactiveX/RxJava/labels{/name}","releases_url":"https://api.github.com/repos/ReactiveX/RxJava/releases{/id}","created_at":"2013-01-08T20:11:48Z","updated_at":"2015-03-16T07:01:25Z","pushed_at":"2015-03-12T09:41:37Z","git_url":"git://github.com/ReactiveX/RxJava.git","ssh_url":"git@github.com:ReactiveX/RxJava.git","clone_url":"https://github.com/ReactiveX/RxJava.git","svn_url":"https://github.com/ReactiveX/RxJava","homepage":"","size":388679,"stargazers_count":4787,"watchers_count":4787,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":694,"mirror_url":null,"open_issues_count":110,"forks":694,"open_issues":110,"watchers":4787,"default_branch":"1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactiveX/RxJava/pulls/2827"},"html":{"href":"https://github.com/ReactiveX/RxJava/pull/2827"},"issue":{"href":"https://api.github.com/repos/ReactiveX/RxJava/issues/2827"},"comments":{"href":"https://api.github.com/repos/ReactiveX/RxJava/issues/2827/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactiveX/RxJava/pulls/2827/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactiveX/RxJava/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactiveX/RxJava/pulls/2827/commits"},"statuses":{"href":"https://api.github.com/repos/ReactiveX/RxJava/statuses/21569f9c4501da1452c518cbbf961d02bdb077cf"}}}}