{"action":"created","comment":{"url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/comments/24415914","id":24415914,"diff_hunk":"@@ -50,15 +50,26 @@ object ProposalIo {\n   def writeToXml(p: Proposal): Node =\n     XML.loadString(writeToString(p)) // there is probably a more direct route ...\n \n-  //private def tryLatin1(f: File)\n-\n   private def toProposal(r: ConversionResult): ProposalConversion = ProposalConversion(r.transformed, r.from, r.changes, toProposal(unmarshaller.unmarshal(new StringReader(r.root.toString))))\n \n-  def readAndConvert(s: String):Validation[Either[Exception, NonEmptyList[String]], ProposalConversion] = try {\n-      UpConverter.upConvert(XML.loadString(s)).fold(Right(_).fail, toProposal(_).success)\n+  // Not all UFT-8 characters are valid in XML, strip them if needed\n+  // Reference http://www.w3.org/TR/2000/REC-xml-20001006#NT-Char\n+  private def stripNonValidXMLCharacters(in: String) = in.filter {\n+    case c if c == 0x9                      => true","path":"bundle/edu.gemini.model.p1/src/main/scala/edu/gemini/model/p1/immutable/ProposalIo.scala","position":13,"original_position":13,"commit_id":"de666953673186e5e7c3e687d9f2bdd748c46189","original_commit_id":"de666953673186e5e7c3e687d9f2bdd748c46189","user":{"login":"sraaphorst","id":8795653,"avatar_url":"https://avatars.githubusercontent.com/u/8795653?v=3","gravatar_id":"","url":"https://api.github.com/users/sraaphorst","html_url":"https://github.com/sraaphorst","followers_url":"https://api.github.com/users/sraaphorst/followers","following_url":"https://api.github.com/users/sraaphorst/following{/other_user}","gists_url":"https://api.github.com/users/sraaphorst/gists{/gist_id}","starred_url":"https://api.github.com/users/sraaphorst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sraaphorst/subscriptions","organizations_url":"https://api.github.com/users/sraaphorst/orgs","repos_url":"https://api.github.com/users/sraaphorst/repos","events_url":"https://api.github.com/users/sraaphorst/events{/privacy}","received_events_url":"https://api.github.com/users/sraaphorst/received_events","type":"User","site_admin":false},"body":"I'm not sure why these single cases have the form:\r\n`case c if c == 0x9 => true`\r\nWouldn't it be simpler to do:\r\n`case 0x9 => true`?\r\n\r\n(Or even: `case c if c in List(0x9, 0xA, 0xD) => true` and just combine them?)","created_at":"2015-02-10T14:41:40Z","updated_at":"2015-02-10T14:41:40Z","html_url":"https://github.com/gemini-hlsw/ocs/pull/243#discussion_r24415914","pull_request_url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/243","_links":{"self":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/comments/24415914"},"html":{"href":"https://github.com/gemini-hlsw/ocs/pull/243#discussion_r24415914"},"pull_request":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/243"}}},"pull_request":{"url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/243","id":29011369,"html_url":"https://github.com/gemini-hlsw/ocs/pull/243","diff_url":"https://github.com/gemini-hlsw/ocs/pull/243.diff","patch_url":"https://github.com/gemini-hlsw/ocs/pull/243.patch","issue_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/243","number":243,"state":"open","locked":false,"title":"REL-2030: Invalid character causes proposal to be rejected","user":{"login":"cquiroz","id":3615303,"avatar_url":"https://avatars.githubusercontent.com/u/3615303?v=3","gravatar_id":"","url":"https://api.github.com/users/cquiroz","html_url":"https://github.com/cquiroz","followers_url":"https://api.github.com/users/cquiroz/followers","following_url":"https://api.github.com/users/cquiroz/following{/other_user}","gists_url":"https://api.github.com/users/cquiroz/gists{/gist_id}","starred_url":"https://api.github.com/users/cquiroz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cquiroz/subscriptions","organizations_url":"https://api.github.com/users/cquiroz/orgs","repos_url":"https://api.github.com/users/cquiroz/repos","events_url":"https://api.github.com/users/cquiroz/events{/privacy}","received_events_url":"https://api.github.com/users/cquiroz/received_events","type":"User","site_admin":false},"body":"Quick PR, sometimes people edit their proposals by hand and break the XML, this PR takes care of filtering out non valid xml files","created_at":"2015-02-10T14:35:35Z","updated_at":"2015-02-10T14:41:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"126de6f46dbb1640ef4e2e1668fd4f71c7a278d2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/243/commits","review_comments_url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/243/comments","review_comment_url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/243/comments","statuses_url":"https://api.github.com/repos/gemini-hlsw/ocs/statuses/de666953673186e5e7c3e687d9f2bdd748c46189","head":{"label":"cquiroz:feature/REL-2030","ref":"feature/REL-2030","sha":"de666953673186e5e7c3e687d9f2bdd748c46189","user":{"login":"cquiroz","id":3615303,"avatar_url":"https://avatars.githubusercontent.com/u/3615303?v=3","gravatar_id":"","url":"https://api.github.com/users/cquiroz","html_url":"https://github.com/cquiroz","followers_url":"https://api.github.com/users/cquiroz/followers","following_url":"https://api.github.com/users/cquiroz/following{/other_user}","gists_url":"https://api.github.com/users/cquiroz/gists{/gist_id}","starred_url":"https://api.github.com/users/cquiroz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cquiroz/subscriptions","organizations_url":"https://api.github.com/users/cquiroz/orgs","repos_url":"https://api.github.com/users/cquiroz/repos","events_url":"https://api.github.com/users/cquiroz/events{/privacy}","received_events_url":"https://api.github.com/users/cquiroz/received_events","type":"User","site_admin":false},"repo":{"id":23979014,"name":"ocs","full_name":"cquiroz/ocs","owner":{"login":"cquiroz","id":3615303,"avatar_url":"https://avatars.githubusercontent.com/u/3615303?v=3","gravatar_id":"","url":"https://api.github.com/users/cquiroz","html_url":"https://github.com/cquiroz","followers_url":"https://api.github.com/users/cquiroz/followers","following_url":"https://api.github.com/users/cquiroz/following{/other_user}","gists_url":"https://api.github.com/users/cquiroz/gists{/gist_id}","starred_url":"https://api.github.com/users/cquiroz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cquiroz/subscriptions","organizations_url":"https://api.github.com/users/cquiroz/orgs","repos_url":"https://api.github.com/users/cquiroz/repos","events_url":"https://api.github.com/users/cquiroz/events{/privacy}","received_events_url":"https://api.github.com/users/cquiroz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cquiroz/ocs","description":"","fork":true,"url":"https://api.github.com/repos/cquiroz/ocs","forks_url":"https://api.github.com/repos/cquiroz/ocs/forks","keys_url":"https://api.github.com/repos/cquiroz/ocs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cquiroz/ocs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cquiroz/ocs/teams","hooks_url":"https://api.github.com/repos/cquiroz/ocs/hooks","issue_events_url":"https://api.github.com/repos/cquiroz/ocs/issues/events{/number}","events_url":"https://api.github.com/repos/cquiroz/ocs/events","assignees_url":"https://api.github.com/repos/cquiroz/ocs/assignees{/user}","branches_url":"https://api.github.com/repos/cquiroz/ocs/branches{/branch}","tags_url":"https://api.github.com/repos/cquiroz/ocs/tags","blobs_url":"https://api.github.com/repos/cquiroz/ocs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cquiroz/ocs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cquiroz/ocs/git/refs{/sha}","trees_url":"https://api.github.com/repos/cquiroz/ocs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cquiroz/ocs/statuses/{sha}","languages_url":"https://api.github.com/repos/cquiroz/ocs/languages","stargazers_url":"https://api.github.com/repos/cquiroz/ocs/stargazers","contributors_url":"https://api.github.com/repos/cquiroz/ocs/contributors","subscribers_url":"https://api.github.com/repos/cquiroz/ocs/subscribers","subscription_url":"https://api.github.com/repos/cquiroz/ocs/subscription","commits_url":"https://api.github.com/repos/cquiroz/ocs/commits{/sha}","git_commits_url":"https://api.github.com/repos/cquiroz/ocs/git/commits{/sha}","comments_url":"https://api.github.com/repos/cquiroz/ocs/comments{/number}","issue_comment_url":"https://api.github.com/repos/cquiroz/ocs/issues/comments/{number}","contents_url":"https://api.github.com/repos/cquiroz/ocs/contents/{+path}","compare_url":"https://api.github.com/repos/cquiroz/ocs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cquiroz/ocs/merges","archive_url":"https://api.github.com/repos/cquiroz/ocs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cquiroz/ocs/downloads","issues_url":"https://api.github.com/repos/cquiroz/ocs/issues{/number}","pulls_url":"https://api.github.com/repos/cquiroz/ocs/pulls{/number}","milestones_url":"https://api.github.com/repos/cquiroz/ocs/milestones{/number}","notifications_url":"https://api.github.com/repos/cquiroz/ocs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cquiroz/ocs/labels{/name}","releases_url":"https://api.github.com/repos/cquiroz/ocs/releases{/id}","created_at":"2014-09-12T22:30:57Z","updated_at":"2015-02-09T14:03:41Z","pushed_at":"2015-02-10T14:31:33Z","git_url":"git://github.com/cquiroz/ocs.git","ssh_url":"git@github.com:cquiroz/ocs.git","clone_url":"https://github.com/cquiroz/ocs.git","svn_url":"https://github.com/cquiroz/ocs","homepage":null,"size":257045,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"gemini-hlsw:develop","ref":"develop","sha":"d40216e55b42c683b836f2ca74b409a8e2e2bdd4","user":{"login":"gemini-hlsw","id":8593735,"avatar_url":"https://avatars.githubusercontent.com/u/8593735?v=3","gravatar_id":"","url":"https://api.github.com/users/gemini-hlsw","html_url":"https://github.com/gemini-hlsw","followers_url":"https://api.github.com/users/gemini-hlsw/followers","following_url":"https://api.github.com/users/gemini-hlsw/following{/other_user}","gists_url":"https://api.github.com/users/gemini-hlsw/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-hlsw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-hlsw/subscriptions","organizations_url":"https://api.github.com/users/gemini-hlsw/orgs","repos_url":"https://api.github.com/users/gemini-hlsw/repos","events_url":"https://api.github.com/users/gemini-hlsw/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-hlsw/received_events","type":"Organization","site_admin":false},"repo":{"id":23963494,"name":"ocs","full_name":"gemini-hlsw/ocs","owner":{"login":"gemini-hlsw","id":8593735,"avatar_url":"https://avatars.githubusercontent.com/u/8593735?v=3","gravatar_id":"","url":"https://api.github.com/users/gemini-hlsw","html_url":"https://github.com/gemini-hlsw","followers_url":"https://api.github.com/users/gemini-hlsw/followers","following_url":"https://api.github.com/users/gemini-hlsw/following{/other_user}","gists_url":"https://api.github.com/users/gemini-hlsw/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-hlsw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-hlsw/subscriptions","organizations_url":"https://api.github.com/users/gemini-hlsw/orgs","repos_url":"https://api.github.com/users/gemini-hlsw/repos","events_url":"https://api.github.com/users/gemini-hlsw/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-hlsw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gemini-hlsw/ocs","description":"Observatory Control Software","fork":false,"url":"https://api.github.com/repos/gemini-hlsw/ocs","forks_url":"https://api.github.com/repos/gemini-hlsw/ocs/forks","keys_url":"https://api.github.com/repos/gemini-hlsw/ocs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gemini-hlsw/ocs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gemini-hlsw/ocs/teams","hooks_url":"https://api.github.com/repos/gemini-hlsw/ocs/hooks","issue_events_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/events{/number}","events_url":"https://api.github.com/repos/gemini-hlsw/ocs/events","assignees_url":"https://api.github.com/repos/gemini-hlsw/ocs/assignees{/user}","branches_url":"https://api.github.com/repos/gemini-hlsw/ocs/branches{/branch}","tags_url":"https://api.github.com/repos/gemini-hlsw/ocs/tags","blobs_url":"https://api.github.com/repos/gemini-hlsw/ocs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gemini-hlsw/ocs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gemini-hlsw/ocs/git/refs{/sha}","trees_url":"https://api.github.com/repos/gemini-hlsw/ocs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gemini-hlsw/ocs/statuses/{sha}","languages_url":"https://api.github.com/repos/gemini-hlsw/ocs/languages","stargazers_url":"https://api.github.com/repos/gemini-hlsw/ocs/stargazers","contributors_url":"https://api.github.com/repos/gemini-hlsw/ocs/contributors","subscribers_url":"https://api.github.com/repos/gemini-hlsw/ocs/subscribers","subscription_url":"https://api.github.com/repos/gemini-hlsw/ocs/subscription","commits_url":"https://api.github.com/repos/gemini-hlsw/ocs/commits{/sha}","git_commits_url":"https://api.github.com/repos/gemini-hlsw/ocs/git/commits{/sha}","comments_url":"https://api.github.com/repos/gemini-hlsw/ocs/comments{/number}","issue_comment_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/comments/{number}","contents_url":"https://api.github.com/repos/gemini-hlsw/ocs/contents/{+path}","compare_url":"https://api.github.com/repos/gemini-hlsw/ocs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gemini-hlsw/ocs/merges","archive_url":"https://api.github.com/repos/gemini-hlsw/ocs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gemini-hlsw/ocs/downloads","issues_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues{/number}","pulls_url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls{/number}","milestones_url":"https://api.github.com/repos/gemini-hlsw/ocs/milestones{/number}","notifications_url":"https://api.github.com/repos/gemini-hlsw/ocs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gemini-hlsw/ocs/labels{/name}","releases_url":"https://api.github.com/repos/gemini-hlsw/ocs/releases{/id}","created_at":"2014-09-12T14:20:23Z","updated_at":"2015-02-09T14:01:02Z","pushed_at":"2015-02-09T18:58:36Z","git_url":"git://github.com/gemini-hlsw/ocs.git","ssh_url":"git@github.com:gemini-hlsw/ocs.git","clone_url":"https://github.com/gemini-hlsw/ocs.git","svn_url":"https://github.com/gemini-hlsw/ocs","homepage":"","size":262582,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":3,"forks":8,"open_issues":3,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/243"},"html":{"href":"https://github.com/gemini-hlsw/ocs/pull/243"},"issue":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/issues/243"},"comments":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/issues/243/comments"},"review_comments":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/243/comments"},"review_comment":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/243/commits"},"statuses":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/statuses/de666953673186e5e7c3e687d9f2bdd748c46189"}}}}