{"action":"closed","number":577,"pull_request":{"url":"https://api.github.com/repos/grails/grails-core/pulls/577","id":31184077,"html_url":"https://github.com/grails/grails-core/pull/577","diff_url":"https://github.com/grails/grails-core/pull/577.diff","patch_url":"https://github.com/grails/grails-core/pull/577.patch","issue_url":"https://api.github.com/repos/grails/grails-core/issues/577","number":577,"state":"closed","locked":false,"title":"Fix AtomRenderer which fails to flush response.","user":{"login":"apbleonard","id":686560,"avatar_url":"https://avatars.githubusercontent.com/u/686560?v=3","gravatar_id":"","url":"https://api.github.com/users/apbleonard","html_url":"https://github.com/apbleonard","followers_url":"https://api.github.com/users/apbleonard/followers","following_url":"https://api.github.com/users/apbleonard/following{/other_user}","gists_url":"https://api.github.com/users/apbleonard/gists{/gist_id}","starred_url":"https://api.github.com/users/apbleonard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apbleonard/subscriptions","organizations_url":"https://api.github.com/users/apbleonard/orgs","repos_url":"https://api.github.com/users/apbleonard/repos","events_url":"https://api.github.com/users/apbleonard/events{/privacy}","received_events_url":"https://api.github.com/users/apbleonard/received_events","type":"User","site_admin":false},"body":"Problem: Atom rendering is broken. Because it never flushes the response (like HalJsonRenderer does) grails defaults to searching for the appropriate GSP / JSP pages which it can't find, and throws a 500 error saying so.\r\n\r\nSteps to replicate:\r\n* grails create-app myapp\r\n* do following as per http://grails.github.io/grails-doc/latest/guide/webServices.html#atom\r\n** Add domain class with title, lastUpdated and dateCreated properties annotated with @Resource(uri='/foo',formats=['atom','json'])\r\n** Add AtomRenderer and AtomCollectionRenderer into resources.groovy\r\n* grails run-app\r\n* create a resource e.g. curl -i -X POST -H 'Accept:application/json; Content-type: application/json' -d '{ \"title\":\"...\", \"lastUpdated\":\"...\", \"dateCreated\":\"...\" }' http://localhost:8080/myapp/foo\r\n* response is 201 created, with header 'Location: http://localhost:8080/myapp/foo/1\r\n* lookup the resource in atom e.g. curl -i -X POST -H 'Accept:application/json; Content-type: application/json' -d '{ \"title\":\"...\", \"lastUpdated\":\"...\", \"dateCreated\":\"...\" }' http://localhost:8080/myapp/foo/1\r\n* response 500 error reporting exception (paraphrased) \"cannot find view.jsp\"\r\n\r\nSolution: make AtomRenderer flush the response.\r\n\r\nHope I'm doing this PR right - first time on github. Will open a JIRA also?","created_at":"2015-03-14T14:23:20Z","updated_at":"2015-03-15T21:47:57Z","closed_at":"2015-03-15T21:47:57Z","merged_at":"2015-03-15T21:47:57Z","merge_commit_sha":"74ed521328d893d3ed45d64f6fd9ec816c8bc601","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/grails/grails-core/pulls/577/commits","review_comments_url":"https://api.github.com/repos/grails/grails-core/pulls/577/comments","review_comment_url":"https://api.github.com/repos/grails/grails-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grails/grails-core/issues/577/comments","statuses_url":"https://api.github.com/repos/grails/grails-core/statuses/54f348057eb107ae1b66dfa3933711440800d02b","head":{"label":"apbleonard:apbleonard-fix-atom-rest-flush","ref":"apbleonard-fix-atom-rest-flush","sha":"54f348057eb107ae1b66dfa3933711440800d02b","user":{"login":"apbleonard","id":686560,"avatar_url":"https://avatars.githubusercontent.com/u/686560?v=3","gravatar_id":"","url":"https://api.github.com/users/apbleonard","html_url":"https://github.com/apbleonard","followers_url":"https://api.github.com/users/apbleonard/followers","following_url":"https://api.github.com/users/apbleonard/following{/other_user}","gists_url":"https://api.github.com/users/apbleonard/gists{/gist_id}","starred_url":"https://api.github.com/users/apbleonard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apbleonard/subscriptions","organizations_url":"https://api.github.com/users/apbleonard/orgs","repos_url":"https://api.github.com/users/apbleonard/repos","events_url":"https://api.github.com/users/apbleonard/events{/privacy}","received_events_url":"https://api.github.com/users/apbleonard/received_events","type":"User","site_admin":false},"repo":{"id":32214109,"name":"grails-core","full_name":"apbleonard/grails-core","owner":{"login":"apbleonard","id":686560,"avatar_url":"https://avatars.githubusercontent.com/u/686560?v=3","gravatar_id":"","url":"https://api.github.com/users/apbleonard","html_url":"https://github.com/apbleonard","followers_url":"https://api.github.com/users/apbleonard/followers","following_url":"https://api.github.com/users/apbleonard/following{/other_user}","gists_url":"https://api.github.com/users/apbleonard/gists{/gist_id}","starred_url":"https://api.github.com/users/apbleonard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apbleonard/subscriptions","organizations_url":"https://api.github.com/users/apbleonard/orgs","repos_url":"https://api.github.com/users/apbleonard/repos","events_url":"https://api.github.com/users/apbleonard/events{/privacy}","received_events_url":"https://api.github.com/users/apbleonard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apbleonard/grails-core","description":"The Grails Web Application Framework","fork":true,"url":"https://api.github.com/repos/apbleonard/grails-core","forks_url":"https://api.github.com/repos/apbleonard/grails-core/forks","keys_url":"https://api.github.com/repos/apbleonard/grails-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apbleonard/grails-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apbleonard/grails-core/teams","hooks_url":"https://api.github.com/repos/apbleonard/grails-core/hooks","issue_events_url":"https://api.github.com/repos/apbleonard/grails-core/issues/events{/number}","events_url":"https://api.github.com/repos/apbleonard/grails-core/events","assignees_url":"https://api.github.com/repos/apbleonard/grails-core/assignees{/user}","branches_url":"https://api.github.com/repos/apbleonard/grails-core/branches{/branch}","tags_url":"https://api.github.com/repos/apbleonard/grails-core/tags","blobs_url":"https://api.github.com/repos/apbleonard/grails-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apbleonard/grails-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apbleonard/grails-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/apbleonard/grails-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apbleonard/grails-core/statuses/{sha}","languages_url":"https://api.github.com/repos/apbleonard/grails-core/languages","stargazers_url":"https://api.github.com/repos/apbleonard/grails-core/stargazers","contributors_url":"https://api.github.com/repos/apbleonard/grails-core/contributors","subscribers_url":"https://api.github.com/repos/apbleonard/grails-core/subscribers","subscription_url":"https://api.github.com/repos/apbleonard/grails-core/subscription","commits_url":"https://api.github.com/repos/apbleonard/grails-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/apbleonard/grails-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/apbleonard/grails-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/apbleonard/grails-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/apbleonard/grails-core/contents/{+path}","compare_url":"https://api.github.com/repos/apbleonard/grails-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apbleonard/grails-core/merges","archive_url":"https://api.github.com/repos/apbleonard/grails-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apbleonard/grails-core/downloads","issues_url":"https://api.github.com/repos/apbleonard/grails-core/issues{/number}","pulls_url":"https://api.github.com/repos/apbleonard/grails-core/pulls{/number}","milestones_url":"https://api.github.com/repos/apbleonard/grails-core/milestones{/number}","notifications_url":"https://api.github.com/repos/apbleonard/grails-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apbleonard/grails-core/labels{/name}","releases_url":"https://api.github.com/repos/apbleonard/grails-core/releases{/id}","created_at":"2015-03-14T13:47:36Z","updated_at":"2015-03-14T13:47:42Z","pushed_at":"2015-03-14T14:14:01Z","git_url":"git://github.com/apbleonard/grails-core.git","ssh_url":"git@github.com:apbleonard/grails-core.git","clone_url":"https://github.com/apbleonard/grails-core.git","svn_url":"https://github.com/apbleonard/grails-core","homepage":"http://grails.org","size":413765,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"grails:master","ref":"master","sha":"6e96e7cdbc91da8c4bd03f6257ebf4cb83d23216","user":{"login":"grails","id":64546,"avatar_url":"https://avatars.githubusercontent.com/u/64546?v=3","gravatar_id":"","url":"https://api.github.com/users/grails","html_url":"https://github.com/grails","followers_url":"https://api.github.com/users/grails/followers","following_url":"https://api.github.com/users/grails/following{/other_user}","gists_url":"https://api.github.com/users/grails/gists{/gist_id}","starred_url":"https://api.github.com/users/grails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grails/subscriptions","organizations_url":"https://api.github.com/users/grails/orgs","repos_url":"https://api.github.com/users/grails/repos","events_url":"https://api.github.com/users/grails/events{/privacy}","received_events_url":"https://api.github.com/users/grails/received_events","type":"Organization","site_admin":false},"repo":{"id":512295,"name":"grails-core","full_name":"grails/grails-core","owner":{"login":"grails","id":64546,"avatar_url":"https://avatars.githubusercontent.com/u/64546?v=3","gravatar_id":"","url":"https://api.github.com/users/grails","html_url":"https://github.com/grails","followers_url":"https://api.github.com/users/grails/followers","following_url":"https://api.github.com/users/grails/following{/other_user}","gists_url":"https://api.github.com/users/grails/gists{/gist_id}","starred_url":"https://api.github.com/users/grails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grails/subscriptions","organizations_url":"https://api.github.com/users/grails/orgs","repos_url":"https://api.github.com/users/grails/repos","events_url":"https://api.github.com/users/grails/events{/privacy}","received_events_url":"https://api.github.com/users/grails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grails/grails-core","description":"The Grails Web Application Framework","fork":false,"url":"https://api.github.com/repos/grails/grails-core","forks_url":"https://api.github.com/repos/grails/grails-core/forks","keys_url":"https://api.github.com/repos/grails/grails-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grails/grails-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grails/grails-core/teams","hooks_url":"https://api.github.com/repos/grails/grails-core/hooks","issue_events_url":"https://api.github.com/repos/grails/grails-core/issues/events{/number}","events_url":"https://api.github.com/repos/grails/grails-core/events","assignees_url":"https://api.github.com/repos/grails/grails-core/assignees{/user}","branches_url":"https://api.github.com/repos/grails/grails-core/branches{/branch}","tags_url":"https://api.github.com/repos/grails/grails-core/tags","blobs_url":"https://api.github.com/repos/grails/grails-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grails/grails-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grails/grails-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/grails/grails-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grails/grails-core/statuses/{sha}","languages_url":"https://api.github.com/repos/grails/grails-core/languages","stargazers_url":"https://api.github.com/repos/grails/grails-core/stargazers","contributors_url":"https://api.github.com/repos/grails/grails-core/contributors","subscribers_url":"https://api.github.com/repos/grails/grails-core/subscribers","subscription_url":"https://api.github.com/repos/grails/grails-core/subscription","commits_url":"https://api.github.com/repos/grails/grails-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/grails/grails-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/grails/grails-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/grails/grails-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/grails/grails-core/contents/{+path}","compare_url":"https://api.github.com/repos/grails/grails-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grails/grails-core/merges","archive_url":"https://api.github.com/repos/grails/grails-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grails/grails-core/downloads","issues_url":"https://api.github.com/repos/grails/grails-core/issues{/number}","pulls_url":"https://api.github.com/repos/grails/grails-core/pulls{/number}","milestones_url":"https://api.github.com/repos/grails/grails-core/milestones{/number}","notifications_url":"https://api.github.com/repos/grails/grails-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grails/grails-core/labels{/name}","releases_url":"https://api.github.com/repos/grails/grails-core/releases{/id}","created_at":"2010-02-10T23:57:57Z","updated_at":"2015-03-14T22:45:25Z","pushed_at":"2015-03-15T21:47:57Z","git_url":"git://github.com/grails/grails-core.git","ssh_url":"git@github.com:grails/grails-core.git","clone_url":"https://github.com/grails/grails-core.git","svn_url":"https://github.com/grails/grails-core","homepage":"http://grails.org","size":413765,"stargazers_count":1216,"watchers_count":1216,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":592,"mirror_url":null,"open_issues_count":11,"forks":592,"open_issues":11,"watchers":1216,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grails/grails-core/pulls/577"},"html":{"href":"https://github.com/grails/grails-core/pull/577"},"issue":{"href":"https://api.github.com/repos/grails/grails-core/issues/577"},"comments":{"href":"https://api.github.com/repos/grails/grails-core/issues/577/comments"},"review_comments":{"href":"https://api.github.com/repos/grails/grails-core/pulls/577/comments"},"review_comment":{"href":"https://api.github.com/repos/grails/grails-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grails/grails-core/pulls/577/commits"},"statuses":{"href":"https://api.github.com/repos/grails/grails-core/statuses/54f348057eb107ae1b66dfa3933711440800d02b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"graemerocher","id":66626,"avatar_url":"https://avatars.githubusercontent.com/u/66626?v=3","gravatar_id":"","url":"https://api.github.com/users/graemerocher","html_url":"https://github.com/graemerocher","followers_url":"https://api.github.com/users/graemerocher/followers","following_url":"https://api.github.com/users/graemerocher/following{/other_user}","gists_url":"https://api.github.com/users/graemerocher/gists{/gist_id}","starred_url":"https://api.github.com/users/graemerocher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graemerocher/subscriptions","organizations_url":"https://api.github.com/users/graemerocher/orgs","repos_url":"https://api.github.com/users/graemerocher/repos","events_url":"https://api.github.com/users/graemerocher/events{/privacy}","received_events_url":"https://api.github.com/users/graemerocher/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":0,"changed_files":1}}