{"action":"created","issue":{"url":"https://api.github.com/repos/pac4j/pac4j/issues/150","labels_url":"https://api.github.com/repos/pac4j/pac4j/issues/150/labels{/name}","comments_url":"https://api.github.com/repos/pac4j/pac4j/issues/150/comments","events_url":"https://api.github.com/repos/pac4j/pac4j/issues/150/events","html_url":"https://github.com/pac4j/pac4j/issues/150","id":73098858,"number":150,"title":"PR #141 broke Google2Client","user":{"login":"YogoGit","id":12058007,"avatar_url":"https://avatars.githubusercontent.com/u/12058007?v=3","gravatar_id":"","url":"https://api.github.com/users/YogoGit","html_url":"https://github.com/YogoGit","followers_url":"https://api.github.com/users/YogoGit/followers","following_url":"https://api.github.com/users/YogoGit/following{/other_user}","gists_url":"https://api.github.com/users/YogoGit/gists{/gist_id}","starred_url":"https://api.github.com/users/YogoGit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YogoGit/subscriptions","organizations_url":"https://api.github.com/users/YogoGit/orgs","repos_url":"https://api.github.com/users/YogoGit/repos","events_url":"https://api.github.com/users/YogoGit/events{/privacy}","received_events_url":"https://api.github.com/users/YogoGit/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-05-04T18:59:40Z","updated_at":"2015-05-05T09:28:29Z","closed_at":null,"body":"It appears that merge caused Google Client to fail automated tests as well as production failures with the same error, so I can not update to the latest version of the production jar.\r\n\r\nhttps://github.com/pac4j/pac4j/issues/141\r\n\r\nmaven test -Dtest=org.pac4j.oauth.client.Google2ClientIT\r\n\r\n...\r\n12:53:34.694 [main] DEBUG org.pac4j.core.client.ClientIT - callbackUrl : https://accounts.google.com/ChangePassword?continue=https%3A%2F%2Faccounts.google.com%2Fo%2Foauth2%2Fauth%3Fresponse_type%3Dcode%26scope%3Dprofile%2Bemail%26redirect_uri%3Dhttp%3A%2F%2Fwww.pac4j.org%2F%26state%3DwtmFjIylmN%26client_id%3D682158564078-ndcjc83kp5v7vudikqu1fudtkcs2odeb.apps.googleusercontent.com%26hl%3Den-US%26from_login%3D1%26as%3D1d94c92567336a52&service=lso&sarp=1&scc=1&checkedDomains=youtube&pstMsg=0\r\n12:53:34.694 [main] DEBUG o.p.oauth.client.BaseOAuth20Client - sessionState : wtmFjIylmN / stateParameter : null\r\n12:53:34.694 [main] ERROR o.p.oauth.client.BaseOAuth20Client - Missing state parameter : session expired or possible threat of cross-site request forgery\r\n\r\nI haven't debugged this much, but it doesn't appear this was tested at all.  Part of the reason is the automated test in pac4j-oauth have what appears to be an infinite recursion problem, so the tests never go anywhere and have to be aborted manually."},"comment":{"url":"https://api.github.com/repos/pac4j/pac4j/issues/comments/99008043","html_url":"https://github.com/pac4j/pac4j/issues/150#issuecomment-99008043","issue_url":"https://api.github.com/repos/pac4j/pac4j/issues/150","id":99008043,"user":{"login":"leleuj","id":1038508,"avatar_url":"https://avatars.githubusercontent.com/u/1038508?v=3","gravatar_id":"","url":"https://api.github.com/users/leleuj","html_url":"https://github.com/leleuj","followers_url":"https://api.github.com/users/leleuj/followers","following_url":"https://api.github.com/users/leleuj/following{/other_user}","gists_url":"https://api.github.com/users/leleuj/gists{/gist_id}","starred_url":"https://api.github.com/users/leleuj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leleuj/subscriptions","organizations_url":"https://api.github.com/users/leleuj/orgs","repos_url":"https://api.github.com/users/leleuj/repos","events_url":"https://api.github.com/users/leleuj/events{/privacy}","received_events_url":"https://api.github.com/users/leleuj/received_events","type":"User","site_admin":false},"created_at":"2015-05-05T09:28:29Z","updated_at":"2015-05-05T09:28:29Z","body":"You're right: there might be a regression. Integration tests simulate real authentication processes and maintaining them is really complicated. So they don't run by default.\r\nThere are also bench tests which take some time but don't output anything in my case because of this: https://github.com/pac4j/pac4j/blob/master/pac4j-core/src/test/resources/logback.xml#L23.\r\n\r\nMaintaining pac4j and all *-pac4j libraries takes me a lot of time: any help will be appreciated.\r\n"}}