{"action":"created","comment":{"url":"https://api.github.com/repos/binjitsu/binjitsu/pulls/comments/27138059","id":27138059,"diff_hunk":"@@ -19,51 +19,42 @@ ${acceptloop}:\n         /*  Socket file descriptor is placed in EBP */\n \n         /*  sock = socket(AF_INET, SOCK_STREAM, 0) */\n-        ${i386.linux.mov('eax', 'SYS_socketcall')}\n-        ${i386.linux.mov('ebx', 'SYS_socketcall_socket')}\n-        cdq                     /*  clear EDX */\n-        push edx                /*  IPPROTO_IP (= 0) */\n-        push ebx                /*  SOCK_STREAM */\n+        xor edx, edx\n+        push edx                            /*  IPPROTO_IP (= 0) */","path":"pwnlib/shellcraft/templates/i386/linux/acceptloop_ipv4.asm","position":10,"original_position":10,"commit_id":"17c3a27861d838b2efb5bb2ef53b3aeeced73e53","original_commit_id":"17c3a27861d838b2efb5bb2ef53b3aeeced73e53","user":{"login":"zachriggle","id":111640,"avatar_url":"https://avatars.githubusercontent.com/u/111640?v=3","gravatar_id":"","url":"https://api.github.com/users/zachriggle","html_url":"https://github.com/zachriggle","followers_url":"https://api.github.com/users/zachriggle/followers","following_url":"https://api.github.com/users/zachriggle/following{/other_user}","gists_url":"https://api.github.com/users/zachriggle/gists{/gist_id}","starred_url":"https://api.github.com/users/zachriggle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachriggle/subscriptions","organizations_url":"https://api.github.com/users/zachriggle/orgs","repos_url":"https://api.github.com/users/zachriggle/repos","events_url":"https://api.github.com/users/zachriggle/events{/privacy}","received_events_url":"https://api.github.com/users/zachriggle/received_events","type":"User","site_admin":false},"body":"This should use ${push(0)}","created_at":"2015-03-25T16:27:57Z","updated_at":"2015-03-25T16:27:57Z","html_url":"https://github.com/binjitsu/binjitsu/pull/6#discussion_r27138059","pull_request_url":"https://api.github.com/repos/binjitsu/binjitsu/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/binjitsu/binjitsu/pulls/comments/27138059"},"html":{"href":"https://github.com/binjitsu/binjitsu/pull/6#discussion_r27138059"},"pull_request":{"href":"https://api.github.com/repos/binjitsu/binjitsu/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/binjitsu/binjitsu/pulls/6","id":31936607,"html_url":"https://github.com/binjitsu/binjitsu/pull/6","diff_url":"https://github.com/binjitsu/binjitsu/pull/6.diff","patch_url":"https://github.com/binjitsu/binjitsu/pull/6.patch","issue_url":"https://api.github.com/repos/binjitsu/binjitsu/issues/6","number":6,"state":"open","locked":false,"title":"Use MOV and SYSCALL templates in acceptloop_ipv4 and mprotect_all","user":{"login":"cebrusfs","id":2252236,"avatar_url":"https://avatars.githubusercontent.com/u/2252236?v=3","gravatar_id":"","url":"https://api.github.com/users/cebrusfs","html_url":"https://github.com/cebrusfs","followers_url":"https://api.github.com/users/cebrusfs/followers","following_url":"https://api.github.com/users/cebrusfs/following{/other_user}","gists_url":"https://api.github.com/users/cebrusfs/gists{/gist_id}","starred_url":"https://api.github.com/users/cebrusfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cebrusfs/subscriptions","organizations_url":"https://api.github.com/users/cebrusfs/orgs","repos_url":"https://api.github.com/users/cebrusfs/repos","events_url":"https://api.github.com/users/cebrusfs/events{/privacy}","received_events_url":"https://api.github.com/users/cebrusfs/received_events","type":"User","site_admin":false},"body":"I have finished this job and tested the behavior under `strace` and `gdb`.\r\n\r\nThere some changes in this commit.\r\n1. I rewrote the beginning part of `acceptloop_ipv4` for readability.\r\n2. Using the syscall template will increase the payload length. (In `acceptloop_ipv4`: 84 -> 94 bytes)\r\nThe origin code use some knowledge (reuse the register) to reduce the code length.","created_at":"2015-03-25T15:59:59Z","updated_at":"2015-03-25T16:27:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8d79d35ad8a80cbe0eb4f78f4aebe523b0980df","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/binjitsu/binjitsu/pulls/6/commits","review_comments_url":"https://api.github.com/repos/binjitsu/binjitsu/pulls/6/comments","review_comment_url":"https://api.github.com/repos/binjitsu/binjitsu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/binjitsu/binjitsu/issues/6/comments","statuses_url":"https://api.github.com/repos/binjitsu/binjitsu/statuses/17c3a27861d838b2efb5bb2ef53b3aeeced73e53","head":{"label":"cebrusfs:master","ref":"master","sha":"17c3a27861d838b2efb5bb2ef53b3aeeced73e53","user":{"login":"cebrusfs","id":2252236,"avatar_url":"https://avatars.githubusercontent.com/u/2252236?v=3","gravatar_id":"","url":"https://api.github.com/users/cebrusfs","html_url":"https://github.com/cebrusfs","followers_url":"https://api.github.com/users/cebrusfs/followers","following_url":"https://api.github.com/users/cebrusfs/following{/other_user}","gists_url":"https://api.github.com/users/cebrusfs/gists{/gist_id}","starred_url":"https://api.github.com/users/cebrusfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cebrusfs/subscriptions","organizations_url":"https://api.github.com/users/cebrusfs/orgs","repos_url":"https://api.github.com/users/cebrusfs/repos","events_url":"https://api.github.com/users/cebrusfs/events{/privacy}","received_events_url":"https://api.github.com/users/cebrusfs/received_events","type":"User","site_admin":false},"repo":{"id":32824809,"name":"binjitsu","full_name":"cebrusfs/binjitsu","owner":{"login":"cebrusfs","id":2252236,"avatar_url":"https://avatars.githubusercontent.com/u/2252236?v=3","gravatar_id":"","url":"https://api.github.com/users/cebrusfs","html_url":"https://github.com/cebrusfs","followers_url":"https://api.github.com/users/cebrusfs/followers","following_url":"https://api.github.com/users/cebrusfs/following{/other_user}","gists_url":"https://api.github.com/users/cebrusfs/gists{/gist_id}","starred_url":"https://api.github.com/users/cebrusfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cebrusfs/subscriptions","organizations_url":"https://api.github.com/users/cebrusfs/orgs","repos_url":"https://api.github.com/users/cebrusfs/repos","events_url":"https://api.github.com/users/cebrusfs/events{/privacy}","received_events_url":"https://api.github.com/users/cebrusfs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cebrusfs/binjitsu","description":"CTF framework and exploit development library","fork":true,"url":"https://api.github.com/repos/cebrusfs/binjitsu","forks_url":"https://api.github.com/repos/cebrusfs/binjitsu/forks","keys_url":"https://api.github.com/repos/cebrusfs/binjitsu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cebrusfs/binjitsu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cebrusfs/binjitsu/teams","hooks_url":"https://api.github.com/repos/cebrusfs/binjitsu/hooks","issue_events_url":"https://api.github.com/repos/cebrusfs/binjitsu/issues/events{/number}","events_url":"https://api.github.com/repos/cebrusfs/binjitsu/events","assignees_url":"https://api.github.com/repos/cebrusfs/binjitsu/assignees{/user}","branches_url":"https://api.github.com/repos/cebrusfs/binjitsu/branches{/branch}","tags_url":"https://api.github.com/repos/cebrusfs/binjitsu/tags","blobs_url":"https://api.github.com/repos/cebrusfs/binjitsu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cebrusfs/binjitsu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cebrusfs/binjitsu/git/refs{/sha}","trees_url":"https://api.github.com/repos/cebrusfs/binjitsu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cebrusfs/binjitsu/statuses/{sha}","languages_url":"https://api.github.com/repos/cebrusfs/binjitsu/languages","stargazers_url":"https://api.github.com/repos/cebrusfs/binjitsu/stargazers","contributors_url":"https://api.github.com/repos/cebrusfs/binjitsu/contributors","subscribers_url":"https://api.github.com/repos/cebrusfs/binjitsu/subscribers","subscription_url":"https://api.github.com/repos/cebrusfs/binjitsu/subscription","commits_url":"https://api.github.com/repos/cebrusfs/binjitsu/commits{/sha}","git_commits_url":"https://api.github.com/repos/cebrusfs/binjitsu/git/commits{/sha}","comments_url":"https://api.github.com/repos/cebrusfs/binjitsu/comments{/number}","issue_comment_url":"https://api.github.com/repos/cebrusfs/binjitsu/issues/comments{/number}","contents_url":"https://api.github.com/repos/cebrusfs/binjitsu/contents/{+path}","compare_url":"https://api.github.com/repos/cebrusfs/binjitsu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cebrusfs/binjitsu/merges","archive_url":"https://api.github.com/repos/cebrusfs/binjitsu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cebrusfs/binjitsu/downloads","issues_url":"https://api.github.com/repos/cebrusfs/binjitsu/issues{/number}","pulls_url":"https://api.github.com/repos/cebrusfs/binjitsu/pulls{/number}","milestones_url":"https://api.github.com/repos/cebrusfs/binjitsu/milestones{/number}","notifications_url":"https://api.github.com/repos/cebrusfs/binjitsu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cebrusfs/binjitsu/labels{/name}","releases_url":"https://api.github.com/repos/cebrusfs/binjitsu/releases{/id}","created_at":"2015-03-24T20:58:50Z","updated_at":"2015-03-25T15:51:16Z","pushed_at":"2015-03-25T15:51:15Z","git_url":"git://github.com/cebrusfs/binjitsu.git","ssh_url":"git@github.com:cebrusfs/binjitsu.git","clone_url":"https://github.com/cebrusfs/binjitsu.git","svn_url":"https://github.com/cebrusfs/binjitsu","homepage":"https://binjit.su","size":20326,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"binjitsu:master","ref":"master","sha":"36f1fc32e0f06a062d26681b39830f15d3fdc536","user":{"login":"binjitsu","id":6656233,"avatar_url":"https://avatars.githubusercontent.com/u/6656233?v=3","gravatar_id":"","url":"https://api.github.com/users/binjitsu","html_url":"https://github.com/binjitsu","followers_url":"https://api.github.com/users/binjitsu/followers","following_url":"https://api.github.com/users/binjitsu/following{/other_user}","gists_url":"https://api.github.com/users/binjitsu/gists{/gist_id}","starred_url":"https://api.github.com/users/binjitsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binjitsu/subscriptions","organizations_url":"https://api.github.com/users/binjitsu/orgs","repos_url":"https://api.github.com/users/binjitsu/repos","events_url":"https://api.github.com/users/binjitsu/events{/privacy}","received_events_url":"https://api.github.com/users/binjitsu/received_events","type":"Organization","site_admin":false},"repo":{"id":29157870,"name":"binjitsu","full_name":"binjitsu/binjitsu","owner":{"login":"binjitsu","id":6656233,"avatar_url":"https://avatars.githubusercontent.com/u/6656233?v=3","gravatar_id":"","url":"https://api.github.com/users/binjitsu","html_url":"https://github.com/binjitsu","followers_url":"https://api.github.com/users/binjitsu/followers","following_url":"https://api.github.com/users/binjitsu/following{/other_user}","gists_url":"https://api.github.com/users/binjitsu/gists{/gist_id}","starred_url":"https://api.github.com/users/binjitsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binjitsu/subscriptions","organizations_url":"https://api.github.com/users/binjitsu/orgs","repos_url":"https://api.github.com/users/binjitsu/repos","events_url":"https://api.github.com/users/binjitsu/events{/privacy}","received_events_url":"https://api.github.com/users/binjitsu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/binjitsu/binjitsu","description":"CTF framework and exploit development library","fork":true,"url":"https://api.github.com/repos/binjitsu/binjitsu","forks_url":"https://api.github.com/repos/binjitsu/binjitsu/forks","keys_url":"https://api.github.com/repos/binjitsu/binjitsu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/binjitsu/binjitsu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/binjitsu/binjitsu/teams","hooks_url":"https://api.github.com/repos/binjitsu/binjitsu/hooks","issue_events_url":"https://api.github.com/repos/binjitsu/binjitsu/issues/events{/number}","events_url":"https://api.github.com/repos/binjitsu/binjitsu/events","assignees_url":"https://api.github.com/repos/binjitsu/binjitsu/assignees{/user}","branches_url":"https://api.github.com/repos/binjitsu/binjitsu/branches{/branch}","tags_url":"https://api.github.com/repos/binjitsu/binjitsu/tags","blobs_url":"https://api.github.com/repos/binjitsu/binjitsu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/binjitsu/binjitsu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/binjitsu/binjitsu/git/refs{/sha}","trees_url":"https://api.github.com/repos/binjitsu/binjitsu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/binjitsu/binjitsu/statuses/{sha}","languages_url":"https://api.github.com/repos/binjitsu/binjitsu/languages","stargazers_url":"https://api.github.com/repos/binjitsu/binjitsu/stargazers","contributors_url":"https://api.github.com/repos/binjitsu/binjitsu/contributors","subscribers_url":"https://api.github.com/repos/binjitsu/binjitsu/subscribers","subscription_url":"https://api.github.com/repos/binjitsu/binjitsu/subscription","commits_url":"https://api.github.com/repos/binjitsu/binjitsu/commits{/sha}","git_commits_url":"https://api.github.com/repos/binjitsu/binjitsu/git/commits{/sha}","comments_url":"https://api.github.com/repos/binjitsu/binjitsu/comments{/number}","issue_comment_url":"https://api.github.com/repos/binjitsu/binjitsu/issues/comments{/number}","contents_url":"https://api.github.com/repos/binjitsu/binjitsu/contents/{+path}","compare_url":"https://api.github.com/repos/binjitsu/binjitsu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/binjitsu/binjitsu/merges","archive_url":"https://api.github.com/repos/binjitsu/binjitsu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/binjitsu/binjitsu/downloads","issues_url":"https://api.github.com/repos/binjitsu/binjitsu/issues{/number}","pulls_url":"https://api.github.com/repos/binjitsu/binjitsu/pulls{/number}","milestones_url":"https://api.github.com/repos/binjitsu/binjitsu/milestones{/number}","notifications_url":"https://api.github.com/repos/binjitsu/binjitsu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/binjitsu/binjitsu/labels{/name}","releases_url":"https://api.github.com/repos/binjitsu/binjitsu/releases{/id}","created_at":"2015-01-12T21:28:40Z","updated_at":"2015-03-24T18:29:05Z","pushed_at":"2015-03-25T15:59:59Z","git_url":"git://github.com/binjitsu/binjitsu.git","ssh_url":"git@github.com:binjitsu/binjitsu.git","clone_url":"https://github.com/binjitsu/binjitsu.git","svn_url":"https://github.com/binjitsu/binjitsu","homepage":"https://binjit.su","size":20326,"stargazers_count":44,"watchers_count":44,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"open_issues_count":3,"forks":10,"open_issues":3,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/binjitsu/binjitsu/pulls/6"},"html":{"href":"https://github.com/binjitsu/binjitsu/pull/6"},"issue":{"href":"https://api.github.com/repos/binjitsu/binjitsu/issues/6"},"comments":{"href":"https://api.github.com/repos/binjitsu/binjitsu/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/binjitsu/binjitsu/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/binjitsu/binjitsu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/binjitsu/binjitsu/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/binjitsu/binjitsu/statuses/17c3a27861d838b2efb5bb2ef53b3aeeced73e53"}}}}