{"action":"created","comment":{"url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/comments/42933512","id":42933512,"diff_hunk":"@@ -2992,6 +2996,8 @@\n \t\t\t\tGCC_NO_COMMON_BLOCKS = YES;\n \t\t\t\tIPHONEOS_DEPLOYMENT_TARGET = 8.0;\n \t\t\t\tMACOSX_DEPLOYMENT_TARGET = 10.9;\n+\t\t\t\tPRODUCT_BUNDLE_IDENTIFIER = \"org.reactivecocoa.$(PRODUCT_NAME:rfc1034identifier)-Tests\";\n+\t\t\t\tPRODUCT_NAME = \"$(PROJECT_NAME)\";","path":"ReactiveCocoa.xcodeproj/project.pbxproj","position":73,"original_position":73,"commit_id":"0c28e8e63fe48b862f79ad59afa5a843cb5f88ec","original_commit_id":"0c28e8e63fe48b862f79ad59afa5a843cb5f88ec","user":{"login":"neilpa","id":42419,"avatar_url":"https://avatars.githubusercontent.com/u/42419?v=3","gravatar_id":"","url":"https://api.github.com/users/neilpa","html_url":"https://github.com/neilpa","followers_url":"https://api.github.com/users/neilpa/followers","following_url":"https://api.github.com/users/neilpa/following{/other_user}","gists_url":"https://api.github.com/users/neilpa/gists{/gist_id}","starred_url":"https://api.github.com/users/neilpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neilpa/subscriptions","organizations_url":"https://api.github.com/users/neilpa/orgs","repos_url":"https://api.github.com/users/neilpa/repos","events_url":"https://api.github.com/users/neilpa/events{/privacy}","received_events_url":"https://api.github.com/users/neilpa/received_events","type":"User","site_admin":false},"body":"> The thing that is broken is that ENABLE_BITCODE is enabled for the OS X targets\r\n\r\nThis needs to be explicitly disabled for the mac tests. It already is for the framework","created_at":"2015-10-24T12:38:42Z","updated_at":"2015-10-24T12:38:42Z","html_url":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/2511#discussion_r42933512","pull_request_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/2511","_links":{"self":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/comments/42933512"},"html":{"href":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/2511#discussion_r42933512"},"pull_request":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/2511"}}},"pull_request":{"url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/2511","id":48654691,"html_url":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/2511","diff_url":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/2511.diff","patch_url":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/2511.patch","issue_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/2511","number":2511,"state":"open","locked":false,"title":"Fix the test target bundle identifiers and names","user":{"login":"tonyarnold","id":4802,"avatar_url":"https://avatars.githubusercontent.com/u/4802?v=3","gravatar_id":"","url":"https://api.github.com/users/tonyarnold","html_url":"https://github.com/tonyarnold","followers_url":"https://api.github.com/users/tonyarnold/followers","following_url":"https://api.github.com/users/tonyarnold/following{/other_user}","gists_url":"https://api.github.com/users/tonyarnold/gists{/gist_id}","starred_url":"https://api.github.com/users/tonyarnold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonyarnold/subscriptions","organizations_url":"https://api.github.com/users/tonyarnold/orgs","repos_url":"https://api.github.com/users/tonyarnold/repos","events_url":"https://api.github.com/users/tonyarnold/events{/privacy}","received_events_url":"https://api.github.com/users/tonyarnold/received_events","type":"User","site_admin":false},"body":"This is a follow on to #2509 — the test targets ended up broken because they have no PRODUCT_NAME and no PRODUCT_BUNDLE_IDENTIFIER. \r\n\r\nThis PR supersedes #2510.","created_at":"2015-10-24T12:02:50Z","updated_at":"2015-10-24T12:38:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b2c07615b3fc3cb6d9ccc372770037079c8377a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/2511/commits","review_comments_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/2511/comments","review_comment_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/2511/comments","statuses_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/statuses/0c28e8e63fe48b862f79ad59afa5a843cb5f88ec","head":{"label":"tonyarnold:fix/productname","ref":"fix/productname","sha":"0c28e8e63fe48b862f79ad59afa5a843cb5f88ec","user":{"login":"tonyarnold","id":4802,"avatar_url":"https://avatars.githubusercontent.com/u/4802?v=3","gravatar_id":"","url":"https://api.github.com/users/tonyarnold","html_url":"https://github.com/tonyarnold","followers_url":"https://api.github.com/users/tonyarnold/followers","following_url":"https://api.github.com/users/tonyarnold/following{/other_user}","gists_url":"https://api.github.com/users/tonyarnold/gists{/gist_id}","starred_url":"https://api.github.com/users/tonyarnold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonyarnold/subscriptions","organizations_url":"https://api.github.com/users/tonyarnold/orgs","repos_url":"https://api.github.com/users/tonyarnold/repos","events_url":"https://api.github.com/users/tonyarnold/events{/privacy}","received_events_url":"https://api.github.com/users/tonyarnold/received_events","type":"User","site_admin":false},"repo":{"id":6135581,"name":"ReactiveCocoa","full_name":"tonyarnold/ReactiveCocoa","owner":{"login":"tonyarnold","id":4802,"avatar_url":"https://avatars.githubusercontent.com/u/4802?v=3","gravatar_id":"","url":"https://api.github.com/users/tonyarnold","html_url":"https://github.com/tonyarnold","followers_url":"https://api.github.com/users/tonyarnold/followers","following_url":"https://api.github.com/users/tonyarnold/following{/other_user}","gists_url":"https://api.github.com/users/tonyarnold/gists{/gist_id}","starred_url":"https://api.github.com/users/tonyarnold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonyarnold/subscriptions","organizations_url":"https://api.github.com/users/tonyarnold/orgs","repos_url":"https://api.github.com/users/tonyarnold/repos","events_url":"https://api.github.com/users/tonyarnold/events{/privacy}","received_events_url":"https://api.github.com/users/tonyarnold/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tonyarnold/ReactiveCocoa","description":"A framework for composing and transforming sequences of values.","fork":true,"url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa","forks_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/forks","keys_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/teams","hooks_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/hooks","issue_events_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/issues/events{/number}","events_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/events","assignees_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/assignees{/user}","branches_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/branches{/branch}","tags_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/tags","blobs_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/git/refs{/sha}","trees_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/statuses/{sha}","languages_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/languages","stargazers_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/stargazers","contributors_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/contributors","subscribers_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/subscribers","subscription_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/subscription","commits_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/commits{/sha}","git_commits_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/git/commits{/sha}","comments_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/comments{/number}","issue_comment_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/issues/comments{/number}","contents_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/contents/{+path}","compare_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/merges","archive_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/downloads","issues_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/issues{/number}","pulls_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/pulls{/number}","milestones_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/milestones{/number}","notifications_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/labels{/name}","releases_url":"https://api.github.com/repos/tonyarnold/ReactiveCocoa/releases{/id}","created_at":"2012-10-09T04:59:43Z","updated_at":"2013-08-04T03:30:38Z","pushed_at":"2015-10-24T11:54:10Z","git_url":"git://github.com/tonyarnold/ReactiveCocoa.git","ssh_url":"git@github.com:tonyarnold/ReactiveCocoa.git","clone_url":"https://github.com/tonyarnold/ReactiveCocoa.git","svn_url":"https://github.com/tonyarnold/ReactiveCocoa","homepage":"","size":13914,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ReactiveCocoa:master","ref":"master","sha":"37616fd2e465bb01b16e40425d5204b00c46d415","user":{"login":"ReactiveCocoa","id":3422977,"avatar_url":"https://avatars.githubusercontent.com/u/3422977?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveCocoa","html_url":"https://github.com/ReactiveCocoa","followers_url":"https://api.github.com/users/ReactiveCocoa/followers","following_url":"https://api.github.com/users/ReactiveCocoa/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveCocoa/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveCocoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveCocoa/subscriptions","organizations_url":"https://api.github.com/users/ReactiveCocoa/orgs","repos_url":"https://api.github.com/users/ReactiveCocoa/repos","events_url":"https://api.github.com/users/ReactiveCocoa/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveCocoa/received_events","type":"Organization","site_admin":false},"repo":{"id":3606624,"name":"ReactiveCocoa","full_name":"ReactiveCocoa/ReactiveCocoa","owner":{"login":"ReactiveCocoa","id":3422977,"avatar_url":"https://avatars.githubusercontent.com/u/3422977?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveCocoa","html_url":"https://github.com/ReactiveCocoa","followers_url":"https://api.github.com/users/ReactiveCocoa/followers","following_url":"https://api.github.com/users/ReactiveCocoa/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveCocoa/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveCocoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveCocoa/subscriptions","organizations_url":"https://api.github.com/users/ReactiveCocoa/orgs","repos_url":"https://api.github.com/users/ReactiveCocoa/repos","events_url":"https://api.github.com/users/ReactiveCocoa/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveCocoa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactiveCocoa/ReactiveCocoa","description":"Streams of values over time","fork":false,"url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa","forks_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/forks","keys_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/teams","hooks_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/hooks","issue_events_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/events{/number}","events_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/events","assignees_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/assignees{/user}","branches_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/branches{/branch}","tags_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/tags","blobs_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/languages","stargazers_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/stargazers","contributors_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/contributors","subscribers_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/subscribers","subscription_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/subscription","commits_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/contents/{+path}","compare_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/merges","archive_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/downloads","issues_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues{/number}","pulls_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/labels{/name}","releases_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/releases{/id}","created_at":"2012-03-02T22:11:24Z","updated_at":"2015-10-24T10:56:49Z","pushed_at":"2015-10-24T12:02:50Z","git_url":"git://github.com/ReactiveCocoa/ReactiveCocoa.git","ssh_url":"git@github.com:ReactiveCocoa/ReactiveCocoa.git","clone_url":"https://github.com/ReactiveCocoa/ReactiveCocoa.git","svn_url":"https://github.com/ReactiveCocoa/ReactiveCocoa","homepage":"","size":36049,"stargazers_count":10804,"watchers_count":10804,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1866,"mirror_url":null,"open_issues_count":191,"forks":1866,"open_issues":191,"watchers":10804,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/2511"},"html":{"href":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/2511"},"issue":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/2511"},"comments":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/issues/2511/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/2511/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/2511/commits"},"statuses":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/statuses/0c28e8e63fe48b862f79ad59afa5a843cb5f88ec"}}}}