{"action":"created","comment":{"url":"https://api.github.com/repos/mtibben/gogpm/pulls/comments/22763167","id":22763167,"diff_hunk":"@@ -14,7 +15,7 @@ func TestPresentPackageRepoSimpleGopath(t *testing.T) {\n \t\trepo, _ := PackageForImportPath(\"github.com/fake/library\")\n \t\trepo.ctx = build.Context{Compiler: \"gc\", GOPATH: gopath}\n \n-\t\texpected := path.Join(gopath, \"src\", \"/github.com/fake/library\")\n+\t\texpected := path.Join(gopath, \"src\", \"github.com\", \"fake\", \"library\")","path":"vcs/gogpm_test.go","position":13,"original_position":13,"commit_id":"3fda339d3f971b3e9d7d73bc1c20a7d5094ce693","original_commit_id":"3fda339d3f971b3e9d7d73bc1c20a7d5094ce693","user":{"login":"joho","id":4092,"avatar_url":"https://avatars.githubusercontent.com/u/4092?v=3","gravatar_id":"","url":"https://api.github.com/users/joho","html_url":"https://github.com/joho","followers_url":"https://api.github.com/users/joho/followers","following_url":"https://api.github.com/users/joho/following{/other_user}","gists_url":"https://api.github.com/users/joho/gists{/gist_id}","starred_url":"https://api.github.com/users/joho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joho/subscriptions","organizations_url":"https://api.github.com/users/joho/orgs","repos_url":"https://api.github.com/users/joho/repos","events_url":"https://api.github.com/users/joho/events{/privacy}","received_events_url":"https://api.github.com/users/joho/received_events","type":"User","site_admin":false},"body":"it appears that `go/build` uses filepath internall\r\n\r\n```\r\n// joinPath calls ctxt.JoinPath (if not nil) or else filepath.Join.\r\n    98\tfunc (ctxt *Context) joinPath(elem ...string) string {\r\n    99\t\tif f := ctxt.JoinPath; f != nil {\r\n   100\t\t\treturn f(elem...)\r\n   101\t\t}\r\n   102\t\treturn filepath.Join(elem...)\r\n   103\t}\r\n```\r\n\r\nSo i'll switch to consistently using filepath everywhere","created_at":"2015-01-11T00:15:30Z","updated_at":"2015-01-11T00:15:30Z","html_url":"https://github.com/mtibben/gogpm/pull/13#discussion_r22763167","pull_request_url":"https://api.github.com/repos/mtibben/gogpm/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/mtibben/gogpm/pulls/comments/22763167"},"html":{"href":"https://github.com/mtibben/gogpm/pull/13#discussion_r22763167"},"pull_request":{"href":"https://api.github.com/repos/mtibben/gogpm/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/mtibben/gogpm/pulls/13","id":27156020,"html_url":"https://github.com/mtibben/gogpm/pull/13","diff_url":"https://github.com/mtibben/gogpm/pull/13.diff","patch_url":"https://github.com/mtibben/gogpm/pull/13.patch","issue_url":"https://api.github.com/repos/mtibben/gogpm/issues/13","number":13,"state":"open","locked":false,"title":"Reliability improvements for GOPATH searching","user":{"login":"joho","id":4092,"avatar_url":"https://avatars.githubusercontent.com/u/4092?v=3","gravatar_id":"","url":"https://api.github.com/users/joho","html_url":"https://github.com/joho","followers_url":"https://api.github.com/users/joho/followers","following_url":"https://api.github.com/users/joho/following{/other_user}","gists_url":"https://api.github.com/users/joho/gists{/gist_id}","starred_url":"https://api.github.com/users/joho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joho/subscriptions","organizations_url":"https://api.github.com/users/joho/orgs","repos_url":"https://api.github.com/users/joho/repos","events_url":"https://api.github.com/users/joho/events{/privacy}","received_events_url":"https://api.github.com/users/joho/received_events","type":"User","site_admin":false},"body":"* handle an error I was ignoring before\r\n* TIL that path list separators vary by platform","created_at":"2015-01-10T23:09:54Z","updated_at":"2015-01-11T00:15:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ce89b9e534541ef0d4fe48290de308b830b30ae","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mtibben/gogpm/pulls/13/commits","review_comments_url":"https://api.github.com/repos/mtibben/gogpm/pulls/13/comments","review_comment_url":"https://api.github.com/repos/mtibben/gogpm/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mtibben/gogpm/issues/13/comments","statuses_url":"https://api.github.com/repos/mtibben/gogpm/statuses/3fda339d3f971b3e9d7d73bc1c20a7d5094ce693","head":{"label":"joho:master","ref":"master","sha":"3fda339d3f971b3e9d7d73bc1c20a7d5094ce693","user":{"login":"joho","id":4092,"avatar_url":"https://avatars.githubusercontent.com/u/4092?v=3","gravatar_id":"","url":"https://api.github.com/users/joho","html_url":"https://github.com/joho","followers_url":"https://api.github.com/users/joho/followers","following_url":"https://api.github.com/users/joho/following{/other_user}","gists_url":"https://api.github.com/users/joho/gists{/gist_id}","starred_url":"https://api.github.com/users/joho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joho/subscriptions","organizations_url":"https://api.github.com/users/joho/orgs","repos_url":"https://api.github.com/users/joho/repos","events_url":"https://api.github.com/users/joho/events{/privacy}","received_events_url":"https://api.github.com/users/joho/received_events","type":"User","site_admin":false},"repo":{"id":28895617,"name":"gogpm","full_name":"joho/gogpm","owner":{"login":"joho","id":4092,"avatar_url":"https://avatars.githubusercontent.com/u/4092?v=3","gravatar_id":"","url":"https://api.github.com/users/joho","html_url":"https://github.com/joho","followers_url":"https://api.github.com/users/joho/followers","following_url":"https://api.github.com/users/joho/following{/other_user}","gists_url":"https://api.github.com/users/joho/gists{/gist_id}","starred_url":"https://api.github.com/users/joho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joho/subscriptions","organizations_url":"https://api.github.com/users/joho/orgs","repos_url":"https://api.github.com/users/joho/repos","events_url":"https://api.github.com/users/joho/events{/privacy}","received_events_url":"https://api.github.com/users/joho/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joho/gogpm","description":"Barebones dependency manager for Go.","fork":true,"url":"https://api.github.com/repos/joho/gogpm","forks_url":"https://api.github.com/repos/joho/gogpm/forks","keys_url":"https://api.github.com/repos/joho/gogpm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joho/gogpm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joho/gogpm/teams","hooks_url":"https://api.github.com/repos/joho/gogpm/hooks","issue_events_url":"https://api.github.com/repos/joho/gogpm/issues/events{/number}","events_url":"https://api.github.com/repos/joho/gogpm/events","assignees_url":"https://api.github.com/repos/joho/gogpm/assignees{/user}","branches_url":"https://api.github.com/repos/joho/gogpm/branches{/branch}","tags_url":"https://api.github.com/repos/joho/gogpm/tags","blobs_url":"https://api.github.com/repos/joho/gogpm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joho/gogpm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joho/gogpm/git/refs{/sha}","trees_url":"https://api.github.com/repos/joho/gogpm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joho/gogpm/statuses/{sha}","languages_url":"https://api.github.com/repos/joho/gogpm/languages","stargazers_url":"https://api.github.com/repos/joho/gogpm/stargazers","contributors_url":"https://api.github.com/repos/joho/gogpm/contributors","subscribers_url":"https://api.github.com/repos/joho/gogpm/subscribers","subscription_url":"https://api.github.com/repos/joho/gogpm/subscription","commits_url":"https://api.github.com/repos/joho/gogpm/commits{/sha}","git_commits_url":"https://api.github.com/repos/joho/gogpm/git/commits{/sha}","comments_url":"https://api.github.com/repos/joho/gogpm/comments{/number}","issue_comment_url":"https://api.github.com/repos/joho/gogpm/issues/comments/{number}","contents_url":"https://api.github.com/repos/joho/gogpm/contents/{+path}","compare_url":"https://api.github.com/repos/joho/gogpm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joho/gogpm/merges","archive_url":"https://api.github.com/repos/joho/gogpm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joho/gogpm/downloads","issues_url":"https://api.github.com/repos/joho/gogpm/issues{/number}","pulls_url":"https://api.github.com/repos/joho/gogpm/pulls{/number}","milestones_url":"https://api.github.com/repos/joho/gogpm/milestones{/number}","notifications_url":"https://api.github.com/repos/joho/gogpm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joho/gogpm/labels{/name}","releases_url":"https://api.github.com/repos/joho/gogpm/releases{/id}","created_at":"2015-01-07T03:04:34Z","updated_at":"2015-01-10T23:06:59Z","pushed_at":"2015-01-10T23:06:58Z","git_url":"git://github.com/joho/gogpm.git","ssh_url":"git@github.com:joho/gogpm.git","clone_url":"https://github.com/joho/gogpm.git","svn_url":"https://github.com/joho/gogpm","homepage":"","size":136,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mtibben:master","ref":"master","sha":"9cec4c99408cedc7055f88e3a61b5d1d73e2dc58","user":{"login":"mtibben","id":980499,"avatar_url":"https://avatars.githubusercontent.com/u/980499?v=3","gravatar_id":"","url":"https://api.github.com/users/mtibben","html_url":"https://github.com/mtibben","followers_url":"https://api.github.com/users/mtibben/followers","following_url":"https://api.github.com/users/mtibben/following{/other_user}","gists_url":"https://api.github.com/users/mtibben/gists{/gist_id}","starred_url":"https://api.github.com/users/mtibben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtibben/subscriptions","organizations_url":"https://api.github.com/users/mtibben/orgs","repos_url":"https://api.github.com/users/mtibben/repos","events_url":"https://api.github.com/users/mtibben/events{/privacy}","received_events_url":"https://api.github.com/users/mtibben/received_events","type":"User","site_admin":false},"repo":{"id":19196375,"name":"gogpm","full_name":"mtibben/gogpm","owner":{"login":"mtibben","id":980499,"avatar_url":"https://avatars.githubusercontent.com/u/980499?v=3","gravatar_id":"","url":"https://api.github.com/users/mtibben","html_url":"https://github.com/mtibben","followers_url":"https://api.github.com/users/mtibben/followers","following_url":"https://api.github.com/users/mtibben/following{/other_user}","gists_url":"https://api.github.com/users/mtibben/gists{/gist_id}","starred_url":"https://api.github.com/users/mtibben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtibben/subscriptions","organizations_url":"https://api.github.com/users/mtibben/orgs","repos_url":"https://api.github.com/users/mtibben/repos","events_url":"https://api.github.com/users/mtibben/events{/privacy}","received_events_url":"https://api.github.com/users/mtibben/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mtibben/gogpm","description":"Barebones dependency manager for Go.","fork":false,"url":"https://api.github.com/repos/mtibben/gogpm","forks_url":"https://api.github.com/repos/mtibben/gogpm/forks","keys_url":"https://api.github.com/repos/mtibben/gogpm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mtibben/gogpm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mtibben/gogpm/teams","hooks_url":"https://api.github.com/repos/mtibben/gogpm/hooks","issue_events_url":"https://api.github.com/repos/mtibben/gogpm/issues/events{/number}","events_url":"https://api.github.com/repos/mtibben/gogpm/events","assignees_url":"https://api.github.com/repos/mtibben/gogpm/assignees{/user}","branches_url":"https://api.github.com/repos/mtibben/gogpm/branches{/branch}","tags_url":"https://api.github.com/repos/mtibben/gogpm/tags","blobs_url":"https://api.github.com/repos/mtibben/gogpm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mtibben/gogpm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mtibben/gogpm/git/refs{/sha}","trees_url":"https://api.github.com/repos/mtibben/gogpm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mtibben/gogpm/statuses/{sha}","languages_url":"https://api.github.com/repos/mtibben/gogpm/languages","stargazers_url":"https://api.github.com/repos/mtibben/gogpm/stargazers","contributors_url":"https://api.github.com/repos/mtibben/gogpm/contributors","subscribers_url":"https://api.github.com/repos/mtibben/gogpm/subscribers","subscription_url":"https://api.github.com/repos/mtibben/gogpm/subscription","commits_url":"https://api.github.com/repos/mtibben/gogpm/commits{/sha}","git_commits_url":"https://api.github.com/repos/mtibben/gogpm/git/commits{/sha}","comments_url":"https://api.github.com/repos/mtibben/gogpm/comments{/number}","issue_comment_url":"https://api.github.com/repos/mtibben/gogpm/issues/comments/{number}","contents_url":"https://api.github.com/repos/mtibben/gogpm/contents/{+path}","compare_url":"https://api.github.com/repos/mtibben/gogpm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mtibben/gogpm/merges","archive_url":"https://api.github.com/repos/mtibben/gogpm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mtibben/gogpm/downloads","issues_url":"https://api.github.com/repos/mtibben/gogpm/issues{/number}","pulls_url":"https://api.github.com/repos/mtibben/gogpm/pulls{/number}","milestones_url":"https://api.github.com/repos/mtibben/gogpm/milestones{/number}","notifications_url":"https://api.github.com/repos/mtibben/gogpm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mtibben/gogpm/labels{/name}","releases_url":"https://api.github.com/repos/mtibben/gogpm/releases{/id}","created_at":"2014-04-27T05:11:18Z","updated_at":"2015-01-10T19:40:31Z","pushed_at":"2015-01-09T03:29:07Z","git_url":"git://github.com/mtibben/gogpm.git","ssh_url":"git@github.com:mtibben/gogpm.git","clone_url":"https://github.com/mtibben/gogpm.git","svn_url":"https://github.com/mtibben/gogpm","homepage":"","size":388,"stargazers_count":6,"watchers_count":6,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mtibben/gogpm/pulls/13"},"html":{"href":"https://github.com/mtibben/gogpm/pull/13"},"issue":{"href":"https://api.github.com/repos/mtibben/gogpm/issues/13"},"comments":{"href":"https://api.github.com/repos/mtibben/gogpm/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/mtibben/gogpm/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/mtibben/gogpm/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mtibben/gogpm/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/mtibben/gogpm/statuses/3fda339d3f971b3e9d7d73bc1c20a7d5094ce693"}}}}