{"action":"created","comment":{"url":"https://api.github.com/repos/numenta/nupic.core/pulls/comments/24025365","id":24025365,"diff_hunk":"@@ -34,7 +34,11 @@ LoggingException::~LoggingException() throw()\n   if (!alreadyLogged_) {\n     // Let LogItem do the work for us. This code is a bit complex\n     // because LogItem was designed to be used from a logging macro\n+#if defined(NTA_OS_WINDOWS) && defined(NTA_COMPILER_MSVC) && defined(NDEBUG)\n+    auto li = new LogItem(filename_.c_str(), lineno_, LogItem::info);","path":"src/nupic/utils/LoggingException.cpp","position":5,"original_position":5,"commit_id":"14a45c512326f506695892bc69292bd199d4975d","original_commit_id":"dadd375e8c1a8799beaefac98090e2f8012b9f0f","user":{"login":"scottpurdy","id":239726,"avatar_url":"https://avatars.githubusercontent.com/u/239726?v=3","gravatar_id":"","url":"https://api.github.com/users/scottpurdy","html_url":"https://github.com/scottpurdy","followers_url":"https://api.github.com/users/scottpurdy/followers","following_url":"https://api.github.com/users/scottpurdy/following{/other_user}","gists_url":"https://api.github.com/users/scottpurdy/gists{/gist_id}","starred_url":"https://api.github.com/users/scottpurdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottpurdy/subscriptions","organizations_url":"https://api.github.com/users/scottpurdy/orgs","repos_url":"https://api.github.com/users/scottpurdy/repos","events_url":"https://api.github.com/users/scottpurdy/events{/privacy}","received_events_url":"https://api.github.com/users/scottpurdy/received_events","type":"User","site_admin":false},"body":"OK so I looked into the code slightly more. This is an exception class so it makes sense that it is specifying `error` instead of `info`. I think it would be logically incorrect to switch it to `info`, even if it is just for Windows. So I see two scenarios:\r\n\r\n1. This is being called somewhere when there isn't actually an error. In this case, we should change the calling code to not call this unless there is actually an error.\r\n2. There is actually an error but we don't want the AppVeyor build to fail. In this case, we should look at what we are running in AppVeyor that leads to the failure and see if it makes sense to suppress the error output or something.\r\n\r\nCan one of you point me to the output from the AppVeyor failure?","created_at":"2015-02-03T18:20:16Z","updated_at":"2015-02-03T18:20:16Z","html_url":"https://github.com/numenta/nupic.core/pull/275#discussion_r24025365","pull_request_url":"https://api.github.com/repos/numenta/nupic.core/pulls/275","_links":{"self":{"href":"https://api.github.com/repos/numenta/nupic.core/pulls/comments/24025365"},"html":{"href":"https://github.com/numenta/nupic.core/pull/275#discussion_r24025365"},"pull_request":{"href":"https://api.github.com/repos/numenta/nupic.core/pulls/275"}}},"pull_request":{"url":"https://api.github.com/repos/numenta/nupic.core/pulls/275","id":26627888,"html_url":"https://github.com/numenta/nupic.core/pull/275","diff_url":"https://github.com/numenta/nupic.core/pull/275.diff","patch_url":"https://github.com/numenta/nupic.core/pull/275.patch","issue_url":"https://api.github.com/repos/numenta/nupic.core/issues/275","number":275,"state":"open","locked":false,"title":"Windows build: Update source files to build under Windows","user":{"login":"david-ragazzi","id":3386273,"avatar_url":"https://avatars.githubusercontent.com/u/3386273?v=3","gravatar_id":"","url":"https://api.github.com/users/david-ragazzi","html_url":"https://github.com/david-ragazzi","followers_url":"https://api.github.com/users/david-ragazzi/followers","following_url":"https://api.github.com/users/david-ragazzi/following{/other_user}","gists_url":"https://api.github.com/users/david-ragazzi/gists{/gist_id}","starred_url":"https://api.github.com/users/david-ragazzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-ragazzi/subscriptions","organizations_url":"https://api.github.com/users/david-ragazzi/orgs","repos_url":"https://api.github.com/users/david-ragazzi/repos","events_url":"https://api.github.com/users/david-ragazzi/events{/privacy}","received_events_url":"https://api.github.com/users/david-ragazzi/received_events","type":"User","site_admin":false},"body":"Fixes #309\r\nDepends https://github.com/numenta/nupic.core/pull/313\r\n\r\n**Very important:**\r\nThis PR depends of https://github.com/numenta/nupic.core/pull/313, once the latter one is merged then this PR should be reviewed.\r\n\r\nNotes:\r\n- `<sys/time.h>` was replaced by `<nupic/os/Timer.hpp>`. `<sys/time.h>` doesn't exist in Windows, and `<nupic/os/Timer.hpp>` is the default Nupic class to handle this job.\r\n","created_at":"2014-12-28T21:21:43Z","updated_at":"2015-02-03T18:20:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23a5a1208327b74753a06f8f9ed2e4a17cf0d7e4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/numenta/nupic.core/pulls/275/commits","review_comments_url":"https://api.github.com/repos/numenta/nupic.core/pulls/275/comments","review_comment_url":"https://api.github.com/repos/numenta/nupic.core/pulls/comments/{number}","comments_url":"https://api.github.com/repos/numenta/nupic.core/issues/275/comments","statuses_url":"https://api.github.com/repos/numenta/nupic.core/statuses/14a45c512326f506695892bc69292bd199d4975d","head":{"label":"david-ragazzi:update_source_to_windows","ref":"update_source_to_windows","sha":"14a45c512326f506695892bc69292bd199d4975d","user":{"login":"david-ragazzi","id":3386273,"avatar_url":"https://avatars.githubusercontent.com/u/3386273?v=3","gravatar_id":"","url":"https://api.github.com/users/david-ragazzi","html_url":"https://github.com/david-ragazzi","followers_url":"https://api.github.com/users/david-ragazzi/followers","following_url":"https://api.github.com/users/david-ragazzi/following{/other_user}","gists_url":"https://api.github.com/users/david-ragazzi/gists{/gist_id}","starred_url":"https://api.github.com/users/david-ragazzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-ragazzi/subscriptions","organizations_url":"https://api.github.com/users/david-ragazzi/orgs","repos_url":"https://api.github.com/users/david-ragazzi/repos","events_url":"https://api.github.com/users/david-ragazzi/events{/privacy}","received_events_url":"https://api.github.com/users/david-ragazzi/received_events","type":"User","site_admin":false},"repo":{"id":18156397,"name":"nupic.core","full_name":"david-ragazzi/nupic.core","owner":{"login":"david-ragazzi","id":3386273,"avatar_url":"https://avatars.githubusercontent.com/u/3386273?v=3","gravatar_id":"","url":"https://api.github.com/users/david-ragazzi","html_url":"https://github.com/david-ragazzi","followers_url":"https://api.github.com/users/david-ragazzi/followers","following_url":"https://api.github.com/users/david-ragazzi/following{/other_user}","gists_url":"https://api.github.com/users/david-ragazzi/gists{/gist_id}","starred_url":"https://api.github.com/users/david-ragazzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-ragazzi/subscriptions","organizations_url":"https://api.github.com/users/david-ragazzi/orgs","repos_url":"https://api.github.com/users/david-ragazzi/repos","events_url":"https://api.github.com/users/david-ragazzi/events{/privacy}","received_events_url":"https://api.github.com/users/david-ragazzi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/david-ragazzi/nupic.core","description":"Core algorithms for NuPIC (under construction).","fork":true,"url":"https://api.github.com/repos/david-ragazzi/nupic.core","forks_url":"https://api.github.com/repos/david-ragazzi/nupic.core/forks","keys_url":"https://api.github.com/repos/david-ragazzi/nupic.core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/david-ragazzi/nupic.core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/david-ragazzi/nupic.core/teams","hooks_url":"https://api.github.com/repos/david-ragazzi/nupic.core/hooks","issue_events_url":"https://api.github.com/repos/david-ragazzi/nupic.core/issues/events{/number}","events_url":"https://api.github.com/repos/david-ragazzi/nupic.core/events","assignees_url":"https://api.github.com/repos/david-ragazzi/nupic.core/assignees{/user}","branches_url":"https://api.github.com/repos/david-ragazzi/nupic.core/branches{/branch}","tags_url":"https://api.github.com/repos/david-ragazzi/nupic.core/tags","blobs_url":"https://api.github.com/repos/david-ragazzi/nupic.core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/david-ragazzi/nupic.core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/david-ragazzi/nupic.core/git/refs{/sha}","trees_url":"https://api.github.com/repos/david-ragazzi/nupic.core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/david-ragazzi/nupic.core/statuses/{sha}","languages_url":"https://api.github.com/repos/david-ragazzi/nupic.core/languages","stargazers_url":"https://api.github.com/repos/david-ragazzi/nupic.core/stargazers","contributors_url":"https://api.github.com/repos/david-ragazzi/nupic.core/contributors","subscribers_url":"https://api.github.com/repos/david-ragazzi/nupic.core/subscribers","subscription_url":"https://api.github.com/repos/david-ragazzi/nupic.core/subscription","commits_url":"https://api.github.com/repos/david-ragazzi/nupic.core/commits{/sha}","git_commits_url":"https://api.github.com/repos/david-ragazzi/nupic.core/git/commits{/sha}","comments_url":"https://api.github.com/repos/david-ragazzi/nupic.core/comments{/number}","issue_comment_url":"https://api.github.com/repos/david-ragazzi/nupic.core/issues/comments/{number}","contents_url":"https://api.github.com/repos/david-ragazzi/nupic.core/contents/{+path}","compare_url":"https://api.github.com/repos/david-ragazzi/nupic.core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/david-ragazzi/nupic.core/merges","archive_url":"https://api.github.com/repos/david-ragazzi/nupic.core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/david-ragazzi/nupic.core/downloads","issues_url":"https://api.github.com/repos/david-ragazzi/nupic.core/issues{/number}","pulls_url":"https://api.github.com/repos/david-ragazzi/nupic.core/pulls{/number}","milestones_url":"https://api.github.com/repos/david-ragazzi/nupic.core/milestones{/number}","notifications_url":"https://api.github.com/repos/david-ragazzi/nupic.core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/david-ragazzi/nupic.core/labels{/name}","releases_url":"https://api.github.com/repos/david-ragazzi/nupic.core/releases{/id}","created_at":"2014-03-26T22:34:34Z","updated_at":"2015-01-13T23:31:48Z","pushed_at":"2015-01-30T19:44:35Z","git_url":"git://github.com/david-ragazzi/nupic.core.git","ssh_url":"git@github.com:david-ragazzi/nupic.core.git","clone_url":"https://github.com/david-ragazzi/nupic.core.git","svn_url":"https://github.com/david-ragazzi/nupic.core","homepage":null,"size":75882,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"numenta:master","ref":"master","sha":"82296d52f7676f2bd00ddf4e295acd28ce7f6ce6","user":{"login":"numenta","id":1039191,"avatar_url":"https://avatars.githubusercontent.com/u/1039191?v=3","gravatar_id":"","url":"https://api.github.com/users/numenta","html_url":"https://github.com/numenta","followers_url":"https://api.github.com/users/numenta/followers","following_url":"https://api.github.com/users/numenta/following{/other_user}","gists_url":"https://api.github.com/users/numenta/gists{/gist_id}","starred_url":"https://api.github.com/users/numenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numenta/subscriptions","organizations_url":"https://api.github.com/users/numenta/orgs","repos_url":"https://api.github.com/users/numenta/repos","events_url":"https://api.github.com/users/numenta/events{/privacy}","received_events_url":"https://api.github.com/users/numenta/received_events","type":"Organization","site_admin":false},"repo":{"id":16366081,"name":"nupic.core","full_name":"numenta/nupic.core","owner":{"login":"numenta","id":1039191,"avatar_url":"https://avatars.githubusercontent.com/u/1039191?v=3","gravatar_id":"","url":"https://api.github.com/users/numenta","html_url":"https://github.com/numenta","followers_url":"https://api.github.com/users/numenta/followers","following_url":"https://api.github.com/users/numenta/following{/other_user}","gists_url":"https://api.github.com/users/numenta/gists{/gist_id}","starred_url":"https://api.github.com/users/numenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numenta/subscriptions","organizations_url":"https://api.github.com/users/numenta/orgs","repos_url":"https://api.github.com/users/numenta/repos","events_url":"https://api.github.com/users/numenta/events{/privacy}","received_events_url":"https://api.github.com/users/numenta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/numenta/nupic.core","description":"Core algorithms for NuPIC (under construction).","fork":false,"url":"https://api.github.com/repos/numenta/nupic.core","forks_url":"https://api.github.com/repos/numenta/nupic.core/forks","keys_url":"https://api.github.com/repos/numenta/nupic.core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/numenta/nupic.core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/numenta/nupic.core/teams","hooks_url":"https://api.github.com/repos/numenta/nupic.core/hooks","issue_events_url":"https://api.github.com/repos/numenta/nupic.core/issues/events{/number}","events_url":"https://api.github.com/repos/numenta/nupic.core/events","assignees_url":"https://api.github.com/repos/numenta/nupic.core/assignees{/user}","branches_url":"https://api.github.com/repos/numenta/nupic.core/branches{/branch}","tags_url":"https://api.github.com/repos/numenta/nupic.core/tags","blobs_url":"https://api.github.com/repos/numenta/nupic.core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/numenta/nupic.core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/numenta/nupic.core/git/refs{/sha}","trees_url":"https://api.github.com/repos/numenta/nupic.core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/numenta/nupic.core/statuses/{sha}","languages_url":"https://api.github.com/repos/numenta/nupic.core/languages","stargazers_url":"https://api.github.com/repos/numenta/nupic.core/stargazers","contributors_url":"https://api.github.com/repos/numenta/nupic.core/contributors","subscribers_url":"https://api.github.com/repos/numenta/nupic.core/subscribers","subscription_url":"https://api.github.com/repos/numenta/nupic.core/subscription","commits_url":"https://api.github.com/repos/numenta/nupic.core/commits{/sha}","git_commits_url":"https://api.github.com/repos/numenta/nupic.core/git/commits{/sha}","comments_url":"https://api.github.com/repos/numenta/nupic.core/comments{/number}","issue_comment_url":"https://api.github.com/repos/numenta/nupic.core/issues/comments/{number}","contents_url":"https://api.github.com/repos/numenta/nupic.core/contents/{+path}","compare_url":"https://api.github.com/repos/numenta/nupic.core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/numenta/nupic.core/merges","archive_url":"https://api.github.com/repos/numenta/nupic.core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/numenta/nupic.core/downloads","issues_url":"https://api.github.com/repos/numenta/nupic.core/issues{/number}","pulls_url":"https://api.github.com/repos/numenta/nupic.core/pulls{/number}","milestones_url":"https://api.github.com/repos/numenta/nupic.core/milestones{/number}","notifications_url":"https://api.github.com/repos/numenta/nupic.core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/numenta/nupic.core/labels{/name}","releases_url":"https://api.github.com/repos/numenta/nupic.core/releases{/id}","created_at":"2014-01-30T02:13:40Z","updated_at":"2015-01-30T00:34:48Z","pushed_at":"2015-01-30T00:34:48Z","git_url":"git://github.com/numenta/nupic.core.git","ssh_url":"git@github.com:numenta/nupic.core.git","clone_url":"https://github.com/numenta/nupic.core.git","svn_url":"https://github.com/numenta/nupic.core","homepage":null,"size":79706,"stargazers_count":94,"watchers_count":94,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":90,"mirror_url":null,"open_issues_count":68,"forks":90,"open_issues":68,"watchers":94,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/numenta/nupic.core/pulls/275"},"html":{"href":"https://github.com/numenta/nupic.core/pull/275"},"issue":{"href":"https://api.github.com/repos/numenta/nupic.core/issues/275"},"comments":{"href":"https://api.github.com/repos/numenta/nupic.core/issues/275/comments"},"review_comments":{"href":"https://api.github.com/repos/numenta/nupic.core/pulls/275/comments"},"review_comment":{"href":"https://api.github.com/repos/numenta/nupic.core/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/numenta/nupic.core/pulls/275/commits"},"statuses":{"href":"https://api.github.com/repos/numenta/nupic.core/statuses/14a45c512326f506695892bc69292bd199d4975d"}}}}