{"action":"created","issue":{"url":"https://api.github.com/repos/rudolfochrist/interleave/issues/4","labels_url":"https://api.github.com/repos/rudolfochrist/interleave/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/rudolfochrist/interleave/issues/4/comments","events_url":"https://api.github.com/repos/rudolfochrist/interleave/issues/4/events","html_url":"https://github.com/rudolfochrist/interleave/pull/4","id":65783638,"number":4,"title":"Naming consistency; saving window config; lighter","user":{"login":"kaushalmodi","id":3578197,"avatar_url":"https://avatars.githubusercontent.com/u/3578197?v=3","gravatar_id":"","url":"https://api.github.com/users/kaushalmodi","html_url":"https://github.com/kaushalmodi","followers_url":"https://api.github.com/users/kaushalmodi/followers","following_url":"https://api.github.com/users/kaushalmodi/following{/other_user}","gists_url":"https://api.github.com/users/kaushalmodi/gists{/gist_id}","starred_url":"https://api.github.com/users/kaushalmodi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaushalmodi/subscriptions","organizations_url":"https://api.github.com/users/kaushalmodi/orgs","repos_url":"https://api.github.com/users/kaushalmodi/repos","events_url":"https://api.github.com/users/kaushalmodi/events{/privacy}","received_events_url":"https://api.github.com/users/kaushalmodi/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-04-01T21:34:08Z","updated_at":"2015-04-02T11:23:59Z","closed_at":"2015-04-02T09:06:20Z","pull_request":{"url":"https://api.github.com/repos/rudolfochrist/interleave/pulls/4","html_url":"https://github.com/rudolfochrist/interleave/pull/4","diff_url":"https://github.com/rudolfochrist/interleave/pull/4.diff","patch_url":"https://github.com/rudolfochrist/interleave/pull/4.patch"},"body":"Hi,\r\n\r\nThe following implementation to make the interleave mode work with pdf files viewed using `pdf-view` did not work for me; it started throwing error backtraces.\r\n\r\n```el\r\n(defun interleave-pdf-view-after-page ()\r\n    \"Go to the page's notes after the page has been changend with `pdf-tools'.\"\r\n    (interleave-go-to-page-note (pdf-view-current-page)))\r\n\r\n  (add-hook 'pdf-view-change-page-hook 'interleave-pdf-view-after-page)\r\n```\r\n\r\nSo I went ahead and reverted my fork to the earlier implementation of simply redefining the `interleave--` functions if `pdf-view` is used.\r\n\r\nIn addition, I made few house-keeping and minor feature-addition changes:\r\n\r\n- All the package variable and function names now begin with\r\n  `interleave--`\r\n- Added explicit definition of the `doc-view-kill-proc-and-buffer`\r\n  function (from emacs 24.4 source) in the package itself as that\r\n  function's behavior changes to a mere current buffer kill in emacs\r\n  25.1 onwards.\r\n- The window configurations are saved and restored when entering and\r\n  exiting the `interleave` mode.\r\n- `interleave-create-new-note` function is modified to enter a new line\r\n  if the point is not already on a new line.\r\n- `interleave--create-new-note` and `interleave--add-note` functions are\r\n  modified to use the new `interleave--switch-to-other-window` function.\r\n- `interleave-docview-mode` is renamed to a more generic name\r\n  `interleave-pdf-mode` because the pdf file could be viewed in\r\n  `doc-view-mode`, `pdf-view-mode` (pdf-tools) and any other mode too?\r\n- `interleave` mode lighter changed to  ` ≡` for its succinctness "},"comment":{"url":"https://api.github.com/repos/rudolfochrist/interleave/issues/comments/88869844","html_url":"https://github.com/rudolfochrist/interleave/pull/4#issuecomment-88869844","issue_url":"https://api.github.com/repos/rudolfochrist/interleave/issues/4","id":88869844,"user":{"login":"kaushalmodi","id":3578197,"avatar_url":"https://avatars.githubusercontent.com/u/3578197?v=3","gravatar_id":"","url":"https://api.github.com/users/kaushalmodi","html_url":"https://github.com/kaushalmodi","followers_url":"https://api.github.com/users/kaushalmodi/followers","following_url":"https://api.github.com/users/kaushalmodi/following{/other_user}","gists_url":"https://api.github.com/users/kaushalmodi/gists{/gist_id}","starred_url":"https://api.github.com/users/kaushalmodi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaushalmodi/subscriptions","organizations_url":"https://api.github.com/users/kaushalmodi/orgs","repos_url":"https://api.github.com/users/kaushalmodi/repos","events_url":"https://api.github.com/users/kaushalmodi/events{/privacy}","received_events_url":"https://api.github.com/users/kaushalmodi/received_events","type":"User","site_admin":false},"created_at":"2015-04-02T11:23:59Z","updated_at":"2015-04-02T11:23:59Z","body":"Thanks for accepting the pull request! :)"}}