{"action":"created","comment":{"url":"https://api.github.com/repos/weaveworks/weave/pulls/comments/30680107","id":30680107,"diff_hunk":"@@ -75,6 +75,10 @@ func (mz *mockedZoneWithRecords) AddRecord(ident string, name string, ip net.IP)\n \tnotImplWarn()\n \treturn nil\n }\n+func (mz *mockedZoneWithRecords) DeleteRecords(ident *string, ip *net.IP, name *string) int {","path":"nameserver/mocks_test.go","position":4,"original_position":4,"commit_id":"c080bf3fcd5ca690660b10ab0de969215fc98a09","original_commit_id":"c080bf3fcd5ca690660b10ab0de969215fc98a09","user":{"login":"inercia","id":1841612,"avatar_url":"https://avatars.githubusercontent.com/u/1841612?v=3","gravatar_id":"","url":"https://api.github.com/users/inercia","html_url":"https://github.com/inercia","followers_url":"https://api.github.com/users/inercia/followers","following_url":"https://api.github.com/users/inercia/following{/other_user}","gists_url":"https://api.github.com/users/inercia/gists{/gist_id}","starred_url":"https://api.github.com/users/inercia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inercia/subscriptions","organizations_url":"https://api.github.com/users/inercia/orgs","repos_url":"https://api.github.com/users/inercia/repos","events_url":"https://api.github.com/users/inercia/events{/privacy}","received_events_url":"https://api.github.com/users/inercia/received_events","type":"User","site_admin":false},"body":"There is something I don't like: `DeleteRecords` takes **pointers** to strings/IPs, while `DeleteRecord` does not. I understand it is for passing `nil` as a _wildcard argument_, but maybe we could use the empty values for that (eg, `ip=net.IP{}`)...","created_at":"2015-05-20T08:28:18Z","updated_at":"2015-05-20T08:28:18Z","html_url":"https://github.com/weaveworks/weave/pull/706#discussion_r30680107","pull_request_url":"https://api.github.com/repos/weaveworks/weave/pulls/706","_links":{"self":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/comments/30680107"},"html":{"href":"https://github.com/weaveworks/weave/pull/706#discussion_r30680107"},"pull_request":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/706"}}},"pull_request":{"url":"https://api.github.com/repos/weaveworks/weave/pulls/706","id":35754199,"html_url":"https://github.com/weaveworks/weave/pull/706","diff_url":"https://github.com/weaveworks/weave/pull/706.diff","patch_url":"https://github.com/weaveworks/weave/pull/706.patch","issue_url":"https://api.github.com/repos/weaveworks/weave/issues/706","number":706,"state":"open","locked":false,"title":"DNS delete individual records","user":{"login":"awh","id":1504438,"avatar_url":"https://avatars.githubusercontent.com/u/1504438?v=3","gravatar_id":"","url":"https://api.github.com/users/awh","html_url":"https://github.com/awh","followers_url":"https://api.github.com/users/awh/followers","following_url":"https://api.github.com/users/awh/following{/other_user}","gists_url":"https://api.github.com/users/awh/gists{/gist_id}","starred_url":"https://api.github.com/users/awh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awh/subscriptions","organizations_url":"https://api.github.com/users/awh/orgs","repos_url":"https://api.github.com/users/awh/repos","events_url":"https://api.github.com/users/awh/events{/privacy}","received_events_url":"https://api.github.com/users/awh/received_events","type":"User","site_admin":false},"body":"Fixes #631\r\nFixes #654","created_at":"2015-05-19T17:24:46Z","updated_at":"2015-05-20T08:28:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"758cae841024f86af2a0ad625cf87f3f17f640ba","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/weaveworks/weave/pulls/706/commits","review_comments_url":"https://api.github.com/repos/weaveworks/weave/pulls/706/comments","review_comment_url":"https://api.github.com/repos/weaveworks/weave/pulls/comments{/number}","comments_url":"https://api.github.com/repos/weaveworks/weave/issues/706/comments","statuses_url":"https://api.github.com/repos/weaveworks/weave/statuses/c080bf3fcd5ca690660b10ab0de969215fc98a09","head":{"label":"awh:dns_delete_individual_records","ref":"dns_delete_individual_records","sha":"c080bf3fcd5ca690660b10ab0de969215fc98a09","user":{"login":"awh","id":1504438,"avatar_url":"https://avatars.githubusercontent.com/u/1504438?v=3","gravatar_id":"","url":"https://api.github.com/users/awh","html_url":"https://github.com/awh","followers_url":"https://api.github.com/users/awh/followers","following_url":"https://api.github.com/users/awh/following{/other_user}","gists_url":"https://api.github.com/users/awh/gists{/gist_id}","starred_url":"https://api.github.com/users/awh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awh/subscriptions","organizations_url":"https://api.github.com/users/awh/orgs","repos_url":"https://api.github.com/users/awh/repos","events_url":"https://api.github.com/users/awh/events{/privacy}","received_events_url":"https://api.github.com/users/awh/received_events","type":"User","site_admin":false},"repo":{"id":30765046,"name":"weave","full_name":"awh/weave","owner":{"login":"awh","id":1504438,"avatar_url":"https://avatars.githubusercontent.com/u/1504438?v=3","gravatar_id":"","url":"https://api.github.com/users/awh","html_url":"https://github.com/awh","followers_url":"https://api.github.com/users/awh/followers","following_url":"https://api.github.com/users/awh/following{/other_user}","gists_url":"https://api.github.com/users/awh/gists{/gist_id}","starred_url":"https://api.github.com/users/awh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awh/subscriptions","organizations_url":"https://api.github.com/users/awh/orgs","repos_url":"https://api.github.com/users/awh/repos","events_url":"https://api.github.com/users/awh/events{/privacy}","received_events_url":"https://api.github.com/users/awh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/awh/weave","description":"The Docker Network","fork":true,"url":"https://api.github.com/repos/awh/weave","forks_url":"https://api.github.com/repos/awh/weave/forks","keys_url":"https://api.github.com/repos/awh/weave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awh/weave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awh/weave/teams","hooks_url":"https://api.github.com/repos/awh/weave/hooks","issue_events_url":"https://api.github.com/repos/awh/weave/issues/events{/number}","events_url":"https://api.github.com/repos/awh/weave/events","assignees_url":"https://api.github.com/repos/awh/weave/assignees{/user}","branches_url":"https://api.github.com/repos/awh/weave/branches{/branch}","tags_url":"https://api.github.com/repos/awh/weave/tags","blobs_url":"https://api.github.com/repos/awh/weave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awh/weave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awh/weave/git/refs{/sha}","trees_url":"https://api.github.com/repos/awh/weave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awh/weave/statuses/{sha}","languages_url":"https://api.github.com/repos/awh/weave/languages","stargazers_url":"https://api.github.com/repos/awh/weave/stargazers","contributors_url":"https://api.github.com/repos/awh/weave/contributors","subscribers_url":"https://api.github.com/repos/awh/weave/subscribers","subscription_url":"https://api.github.com/repos/awh/weave/subscription","commits_url":"https://api.github.com/repos/awh/weave/commits{/sha}","git_commits_url":"https://api.github.com/repos/awh/weave/git/commits{/sha}","comments_url":"https://api.github.com/repos/awh/weave/comments{/number}","issue_comment_url":"https://api.github.com/repos/awh/weave/issues/comments{/number}","contents_url":"https://api.github.com/repos/awh/weave/contents/{+path}","compare_url":"https://api.github.com/repos/awh/weave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awh/weave/merges","archive_url":"https://api.github.com/repos/awh/weave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awh/weave/downloads","issues_url":"https://api.github.com/repos/awh/weave/issues{/number}","pulls_url":"https://api.github.com/repos/awh/weave/pulls{/number}","milestones_url":"https://api.github.com/repos/awh/weave/milestones{/number}","notifications_url":"https://api.github.com/repos/awh/weave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awh/weave/labels{/name}","releases_url":"https://api.github.com/repos/awh/weave/releases{/id}","created_at":"2015-02-13T16:32:58Z","updated_at":"2015-05-07T13:52:45Z","pushed_at":"2015-05-19T17:12:20Z","git_url":"git://github.com/awh/weave.git","ssh_url":"git@github.com:awh/weave.git","clone_url":"https://github.com/awh/weave.git","svn_url":"https://github.com/awh/weave","homepage":"","size":2521,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"weaveworks:master","ref":"master","sha":"70b595c4a20d28f3516fee9c77767c25ad3c1fbb","user":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars.githubusercontent.com/u/9976052?v=3","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"repo":{"id":23059575,"name":"weave","full_name":"weaveworks/weave","owner":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars.githubusercontent.com/u/9976052?v=3","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/weaveworks/weave","description":"The Docker Network","fork":false,"url":"https://api.github.com/repos/weaveworks/weave","forks_url":"https://api.github.com/repos/weaveworks/weave/forks","keys_url":"https://api.github.com/repos/weaveworks/weave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weaveworks/weave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weaveworks/weave/teams","hooks_url":"https://api.github.com/repos/weaveworks/weave/hooks","issue_events_url":"https://api.github.com/repos/weaveworks/weave/issues/events{/number}","events_url":"https://api.github.com/repos/weaveworks/weave/events","assignees_url":"https://api.github.com/repos/weaveworks/weave/assignees{/user}","branches_url":"https://api.github.com/repos/weaveworks/weave/branches{/branch}","tags_url":"https://api.github.com/repos/weaveworks/weave/tags","blobs_url":"https://api.github.com/repos/weaveworks/weave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weaveworks/weave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weaveworks/weave/git/refs{/sha}","trees_url":"https://api.github.com/repos/weaveworks/weave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weaveworks/weave/statuses/{sha}","languages_url":"https://api.github.com/repos/weaveworks/weave/languages","stargazers_url":"https://api.github.com/repos/weaveworks/weave/stargazers","contributors_url":"https://api.github.com/repos/weaveworks/weave/contributors","subscribers_url":"https://api.github.com/repos/weaveworks/weave/subscribers","subscription_url":"https://api.github.com/repos/weaveworks/weave/subscription","commits_url":"https://api.github.com/repos/weaveworks/weave/commits{/sha}","git_commits_url":"https://api.github.com/repos/weaveworks/weave/git/commits{/sha}","comments_url":"https://api.github.com/repos/weaveworks/weave/comments{/number}","issue_comment_url":"https://api.github.com/repos/weaveworks/weave/issues/comments{/number}","contents_url":"https://api.github.com/repos/weaveworks/weave/contents/{+path}","compare_url":"https://api.github.com/repos/weaveworks/weave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weaveworks/weave/merges","archive_url":"https://api.github.com/repos/weaveworks/weave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weaveworks/weave/downloads","issues_url":"https://api.github.com/repos/weaveworks/weave/issues{/number}","pulls_url":"https://api.github.com/repos/weaveworks/weave/pulls{/number}","milestones_url":"https://api.github.com/repos/weaveworks/weave/milestones{/number}","notifications_url":"https://api.github.com/repos/weaveworks/weave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weaveworks/weave/labels{/name}","releases_url":"https://api.github.com/repos/weaveworks/weave/releases{/id}","created_at":"2014-08-18T05:19:07Z","updated_at":"2015-05-19T17:21:18Z","pushed_at":"2015-05-20T07:28:15Z","git_url":"git://github.com/weaveworks/weave.git","ssh_url":"git@github.com:weaveworks/weave.git","clone_url":"https://github.com/weaveworks/weave.git","svn_url":"https://github.com/weaveworks/weave","homepage":"http://weave.works","size":12272,"stargazers_count":3309,"watchers_count":3309,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":177,"mirror_url":null,"open_issues_count":123,"forks":177,"open_issues":123,"watchers":3309,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/706"},"html":{"href":"https://github.com/weaveworks/weave/pull/706"},"issue":{"href":"https://api.github.com/repos/weaveworks/weave/issues/706"},"comments":{"href":"https://api.github.com/repos/weaveworks/weave/issues/706/comments"},"review_comments":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/706/comments"},"review_comment":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/706/commits"},"statuses":{"href":"https://api.github.com/repos/weaveworks/weave/statuses/c080bf3fcd5ca690660b10ab0de969215fc98a09"}}}}