{"action":"opened","number":3,"pull_request":{"url":"https://api.github.com/repos/tyba/storable/pulls/3","id":38034312,"html_url":"https://github.com/tyba/storable/pull/3","diff_url":"https://github.com/tyba/storable/pull/3.diff","patch_url":"https://github.com/tyba/storable/pull/3.patch","issue_url":"https://api.github.com/repos/tyba/storable/issues/3","number":3,"state":"open","locked":false,"title":"Fix generator for recursive structures.","user":{"login":"tcard","id":727422,"avatar_url":"https://avatars.githubusercontent.com/u/727422?v=3","gravatar_id":"","url":"https://api.github.com/users/tcard","html_url":"https://github.com/tcard","followers_url":"https://api.github.com/users/tcard/followers","following_url":"https://api.github.com/users/tcard/following{/other_user}","gists_url":"https://api.github.com/users/tcard/gists{/gist_id}","starred_url":"https://api.github.com/users/tcard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcard/subscriptions","organizations_url":"https://api.github.com/users/tcard/orgs","repos_url":"https://api.github.com/users/tcard/repos","events_url":"https://api.github.com/users/tcard/events{/privacy}","received_events_url":"https://api.github.com/users/tcard/received_events","type":"User","site_admin":false},"body":"As we are processing a struct, it might be that we hit that same struct again as a child. We can't process twice the same struct without falling into an infinite loop.\r\n\r\nThis change detects such case. It defers the point at which structs get their subfields until the end, because we don't know all of them beforehand, and for that we need an extra layer of indirection for the fields slice, because slice are immutable.","created_at":"2015-06-18T17:57:51Z","updated_at":"2015-06-18T17:57:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tyba/storable/pulls/3/commits","review_comments_url":"https://api.github.com/repos/tyba/storable/pulls/3/comments","review_comment_url":"https://api.github.com/repos/tyba/storable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tyba/storable/issues/3/comments","statuses_url":"https://api.github.com/repos/tyba/storable/statuses/98f3032d6f4b129ecd8eeb8bc66bd11f0f199fb3","head":{"label":"tcard:master","ref":"master","sha":"98f3032d6f4b129ecd8eeb8bc66bd11f0f199fb3","user":{"login":"tcard","id":727422,"avatar_url":"https://avatars.githubusercontent.com/u/727422?v=3","gravatar_id":"","url":"https://api.github.com/users/tcard","html_url":"https://github.com/tcard","followers_url":"https://api.github.com/users/tcard/followers","following_url":"https://api.github.com/users/tcard/following{/other_user}","gists_url":"https://api.github.com/users/tcard/gists{/gist_id}","starred_url":"https://api.github.com/users/tcard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcard/subscriptions","organizations_url":"https://api.github.com/users/tcard/orgs","repos_url":"https://api.github.com/users/tcard/repos","events_url":"https://api.github.com/users/tcard/events{/privacy}","received_events_url":"https://api.github.com/users/tcard/received_events","type":"User","site_admin":false},"repo":{"id":37675618,"name":"storable","full_name":"tcard/storable","owner":{"login":"tcard","id":727422,"avatar_url":"https://avatars.githubusercontent.com/u/727422?v=3","gravatar_id":"","url":"https://api.github.com/users/tcard","html_url":"https://github.com/tcard","followers_url":"https://api.github.com/users/tcard/followers","following_url":"https://api.github.com/users/tcard/following{/other_user}","gists_url":"https://api.github.com/users/tcard/gists{/gist_id}","starred_url":"https://api.github.com/users/tcard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcard/subscriptions","organizations_url":"https://api.github.com/users/tcard/orgs","repos_url":"https://api.github.com/users/tcard/repos","events_url":"https://api.github.com/users/tcard/events{/privacy}","received_events_url":"https://api.github.com/users/tcard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tcard/storable","description":"","fork":true,"url":"https://api.github.com/repos/tcard/storable","forks_url":"https://api.github.com/repos/tcard/storable/forks","keys_url":"https://api.github.com/repos/tcard/storable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tcard/storable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tcard/storable/teams","hooks_url":"https://api.github.com/repos/tcard/storable/hooks","issue_events_url":"https://api.github.com/repos/tcard/storable/issues/events{/number}","events_url":"https://api.github.com/repos/tcard/storable/events","assignees_url":"https://api.github.com/repos/tcard/storable/assignees{/user}","branches_url":"https://api.github.com/repos/tcard/storable/branches{/branch}","tags_url":"https://api.github.com/repos/tcard/storable/tags","blobs_url":"https://api.github.com/repos/tcard/storable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tcard/storable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tcard/storable/git/refs{/sha}","trees_url":"https://api.github.com/repos/tcard/storable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tcard/storable/statuses/{sha}","languages_url":"https://api.github.com/repos/tcard/storable/languages","stargazers_url":"https://api.github.com/repos/tcard/storable/stargazers","contributors_url":"https://api.github.com/repos/tcard/storable/contributors","subscribers_url":"https://api.github.com/repos/tcard/storable/subscribers","subscription_url":"https://api.github.com/repos/tcard/storable/subscription","commits_url":"https://api.github.com/repos/tcard/storable/commits{/sha}","git_commits_url":"https://api.github.com/repos/tcard/storable/git/commits{/sha}","comments_url":"https://api.github.com/repos/tcard/storable/comments{/number}","issue_comment_url":"https://api.github.com/repos/tcard/storable/issues/comments{/number}","contents_url":"https://api.github.com/repos/tcard/storable/contents/{+path}","compare_url":"https://api.github.com/repos/tcard/storable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tcard/storable/merges","archive_url":"https://api.github.com/repos/tcard/storable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tcard/storable/downloads","issues_url":"https://api.github.com/repos/tcard/storable/issues{/number}","pulls_url":"https://api.github.com/repos/tcard/storable/pulls{/number}","milestones_url":"https://api.github.com/repos/tcard/storable/milestones{/number}","notifications_url":"https://api.github.com/repos/tcard/storable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tcard/storable/labels{/name}","releases_url":"https://api.github.com/repos/tcard/storable/releases{/id}","created_at":"2015-06-18T17:56:40Z","updated_at":"2015-06-18T17:56:41Z","pushed_at":"2015-06-18T17:57:16Z","git_url":"git://github.com/tcard/storable.git","ssh_url":"git@github.com:tcard/storable.git","clone_url":"https://github.com/tcard/storable.git","svn_url":"https://github.com/tcard/storable","homepage":null,"size":273,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tyba:master","ref":"master","sha":"f88648119b85a99899e67d34b8dfd3605cb78b28","user":{"login":"tyba","id":6660662,"avatar_url":"https://avatars.githubusercontent.com/u/6660662?v=3","gravatar_id":"","url":"https://api.github.com/users/tyba","html_url":"https://github.com/tyba","followers_url":"https://api.github.com/users/tyba/followers","following_url":"https://api.github.com/users/tyba/following{/other_user}","gists_url":"https://api.github.com/users/tyba/gists{/gist_id}","starred_url":"https://api.github.com/users/tyba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyba/subscriptions","organizations_url":"https://api.github.com/users/tyba/orgs","repos_url":"https://api.github.com/users/tyba/repos","events_url":"https://api.github.com/users/tyba/events{/privacy}","received_events_url":"https://api.github.com/users/tyba/received_events","type":"Organization","site_admin":false},"repo":{"id":33259324,"name":"storable","full_name":"tyba/storable","owner":{"login":"tyba","id":6660662,"avatar_url":"https://avatars.githubusercontent.com/u/6660662?v=3","gravatar_id":"","url":"https://api.github.com/users/tyba","html_url":"https://github.com/tyba","followers_url":"https://api.github.com/users/tyba/followers","following_url":"https://api.github.com/users/tyba/following{/other_user}","gists_url":"https://api.github.com/users/tyba/gists{/gist_id}","starred_url":"https://api.github.com/users/tyba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyba/subscriptions","organizations_url":"https://api.github.com/users/tyba/orgs","repos_url":"https://api.github.com/users/tyba/repos","events_url":"https://api.github.com/users/tyba/events{/privacy}","received_events_url":"https://api.github.com/users/tyba/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tyba/storable","description":"","fork":false,"url":"https://api.github.com/repos/tyba/storable","forks_url":"https://api.github.com/repos/tyba/storable/forks","keys_url":"https://api.github.com/repos/tyba/storable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tyba/storable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tyba/storable/teams","hooks_url":"https://api.github.com/repos/tyba/storable/hooks","issue_events_url":"https://api.github.com/repos/tyba/storable/issues/events{/number}","events_url":"https://api.github.com/repos/tyba/storable/events","assignees_url":"https://api.github.com/repos/tyba/storable/assignees{/user}","branches_url":"https://api.github.com/repos/tyba/storable/branches{/branch}","tags_url":"https://api.github.com/repos/tyba/storable/tags","blobs_url":"https://api.github.com/repos/tyba/storable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tyba/storable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tyba/storable/git/refs{/sha}","trees_url":"https://api.github.com/repos/tyba/storable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tyba/storable/statuses/{sha}","languages_url":"https://api.github.com/repos/tyba/storable/languages","stargazers_url":"https://api.github.com/repos/tyba/storable/stargazers","contributors_url":"https://api.github.com/repos/tyba/storable/contributors","subscribers_url":"https://api.github.com/repos/tyba/storable/subscribers","subscription_url":"https://api.github.com/repos/tyba/storable/subscription","commits_url":"https://api.github.com/repos/tyba/storable/commits{/sha}","git_commits_url":"https://api.github.com/repos/tyba/storable/git/commits{/sha}","comments_url":"https://api.github.com/repos/tyba/storable/comments{/number}","issue_comment_url":"https://api.github.com/repos/tyba/storable/issues/comments{/number}","contents_url":"https://api.github.com/repos/tyba/storable/contents/{+path}","compare_url":"https://api.github.com/repos/tyba/storable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tyba/storable/merges","archive_url":"https://api.github.com/repos/tyba/storable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tyba/storable/downloads","issues_url":"https://api.github.com/repos/tyba/storable/issues{/number}","pulls_url":"https://api.github.com/repos/tyba/storable/pulls{/number}","milestones_url":"https://api.github.com/repos/tyba/storable/milestones{/number}","notifications_url":"https://api.github.com/repos/tyba/storable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tyba/storable/labels{/name}","releases_url":"https://api.github.com/repos/tyba/storable/releases{/id}","created_at":"2015-04-01T16:36:28Z","updated_at":"2015-05-22T02:40:39Z","pushed_at":"2015-05-06T10:58:46Z","git_url":"git://github.com/tyba/storable.git","ssh_url":"git@github.com:tyba/storable.git","clone_url":"https://github.com/tyba/storable.git","svn_url":"https://github.com/tyba/storable","homepage":null,"size":273,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tyba/storable/pulls/3"},"html":{"href":"https://github.com/tyba/storable/pull/3"},"issue":{"href":"https://api.github.com/repos/tyba/storable/issues/3"},"comments":{"href":"https://api.github.com/repos/tyba/storable/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/tyba/storable/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/tyba/storable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tyba/storable/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/tyba/storable/statuses/98f3032d6f4b129ecd8eeb8bc66bd11f0f199fb3"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":134,"deletions":13,"changed_files":3}}