{"action":"created","issue":{"url":"https://api.github.com/repos/odoo/odoo/issues/5269","labels_url":"https://api.github.com/repos/odoo/odoo/issues/5269/labels{/name}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/5269/comments","events_url":"https://api.github.com/repos/odoo/odoo/issues/5269/events","html_url":"https://github.com/odoo/odoo/pull/5269","id":57657839,"number":5269,"title":"[FIX] Validate if the DAEMON is already running before attending to start it.","user":{"login":"menstar","id":5893352,"avatar_url":"https://avatars.githubusercontent.com/u/5893352?v=3","gravatar_id":"","url":"https://api.github.com/users/menstar","html_url":"https://github.com/menstar","followers_url":"https://api.github.com/users/menstar/followers","following_url":"https://api.github.com/users/menstar/following{/other_user}","gists_url":"https://api.github.com/users/menstar/gists{/gist_id}","starred_url":"https://api.github.com/users/menstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menstar/subscriptions","organizations_url":"https://api.github.com/users/menstar/orgs","repos_url":"https://api.github.com/users/menstar/repos","events_url":"https://api.github.com/users/menstar/events{/privacy}","received_events_url":"https://api.github.com/users/menstar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-02-13T21:41:45Z","updated_at":"2015-02-16T13:19:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/5269","html_url":"https://github.com/odoo/odoo/pull/5269","diff_url":"https://github.com/odoo/odoo/pull/5269.diff","patch_url":"https://github.com/odoo/odoo/pull/5269.patch"},"body":"If we try to start odoo (service start odoo) twice, we crush the PID file and can't stop the worker process without a manual kill (killall odoo). This is probably caused by the background option of the start-stop-deamon that had difficulty managing the subprocess. To fix this issue, we validate if odoo is running before attempting to execute it... and I've added colors to status for aesthetic purposes"},"comment":{"url":"https://api.github.com/repos/odoo/odoo/issues/comments/74506892","html_url":"https://github.com/odoo/odoo/pull/5269#issuecomment-74506892","issue_url":"https://api.github.com/repos/odoo/odoo/issues/5269","id":74506892,"user":{"login":"sle-odoo","id":7601090,"avatar_url":"https://avatars.githubusercontent.com/u/7601090?v=3","gravatar_id":"","url":"https://api.github.com/users/sle-odoo","html_url":"https://github.com/sle-odoo","followers_url":"https://api.github.com/users/sle-odoo/followers","following_url":"https://api.github.com/users/sle-odoo/following{/other_user}","gists_url":"https://api.github.com/users/sle-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/sle-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sle-odoo/subscriptions","organizations_url":"https://api.github.com/users/sle-odoo/orgs","repos_url":"https://api.github.com/users/sle-odoo/repos","events_url":"https://api.github.com/users/sle-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/sle-odoo/received_events","type":"User","site_admin":false},"created_at":"2015-02-16T13:19:26Z","updated_at":"2015-02-16T13:19:26Z","body":"Hi,\r\nThanks for your contribution.\r\nI'm not very familiar with ~advanced init scripts, however i have some questions/suggestions:\r\n* have you thought about using some functions of /lib/lsb/init-functions? I think `pidofproc` can replace your calls to `ps`.\r\n* how did you chose the return codes? [it looks like they have a proper meaning.](http://refspecs.linuxbase.org/LSB_2.1.0/LSB-generic/LSB-generic/iniscrptact.html)\r\n\r\nRegards"}}