{"action":"created","issue":{"url":"https://api.github.com/repos/pantheon-systems/cli/issues/538","labels_url":"https://api.github.com/repos/pantheon-systems/cli/issues/538/labels{/name}","comments_url":"https://api.github.com/repos/pantheon-systems/cli/issues/538/comments","events_url":"https://api.github.com/repos/pantheon-systems/cli/issues/538/events","html_url":"https://github.com/pantheon-systems/cli/pull/538","id":108421131,"number":538,"title":"Output cleanup#531","user":{"login":"ronan","id":36866,"avatar_url":"https://avatars.githubusercontent.com/u/36866?v=3","gravatar_id":"","url":"https://api.github.com/users/ronan","html_url":"https://github.com/ronan","followers_url":"https://api.github.com/users/ronan/followers","following_url":"https://api.github.com/users/ronan/following{/other_user}","gists_url":"https://api.github.com/users/ronan/gists{/gist_id}","starred_url":"https://api.github.com/users/ronan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronan/subscriptions","organizations_url":"https://api.github.com/users/ronan/orgs","repos_url":"https://api.github.com/users/ronan/repos","events_url":"https://api.github.com/users/ronan/events{/privacy}","received_events_url":"https://api.github.com/users/ronan/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/pantheon-systems/cli/labels/Needs%20Review","name":"Needs Review","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-25T23:02:54Z","updated_at":"2015-09-25T23:30:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pantheon-systems/cli/pulls/538","html_url":"https://github.com/pantheon-systems/cli/pull/538","diff_url":"https://github.com/pantheon-systems/cli/pull/538.diff","patch_url":"https://github.com/pantheon-systems/cli/pull/538.patch"},"body":"Ok, this one's a monster. I punted on DI because it wasn't obvious where that should be done but almost all access to logging and output are now through `$this->log()` or `$this->output()` so it should be possible to inject the logger and outputter at some point.\r\n\r\nI wasn't quit able to get rid of all calls to `Terminus::line()` because the usage info is generated from outside the command classes and it doens't render right with the current logger (every line is prefixed with a timestamp)\r\n\r\nFailures are now handled with Exceptions.\r\n\r\nMuch deprecated code has been removed.\r\n"},"comment":{"url":"https://api.github.com/repos/pantheon-systems/cli/issues/comments/143375390","html_url":"https://github.com/pantheon-systems/cli/pull/538#issuecomment-143375390","issue_url":"https://api.github.com/repos/pantheon-systems/cli/issues/538","id":143375390,"user":{"login":"TeslaDethray","id":868204,"avatar_url":"https://avatars.githubusercontent.com/u/868204?v=3","gravatar_id":"","url":"https://api.github.com/users/TeslaDethray","html_url":"https://github.com/TeslaDethray","followers_url":"https://api.github.com/users/TeslaDethray/followers","following_url":"https://api.github.com/users/TeslaDethray/following{/other_user}","gists_url":"https://api.github.com/users/TeslaDethray/gists{/gist_id}","starred_url":"https://api.github.com/users/TeslaDethray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeslaDethray/subscriptions","organizations_url":"https://api.github.com/users/TeslaDethray/orgs","repos_url":"https://api.github.com/users/TeslaDethray/repos","events_url":"https://api.github.com/users/TeslaDethray/events{/privacy}","received_events_url":"https://api.github.com/users/TeslaDethray/received_events","type":"User","site_admin":false},"created_at":"2015-09-25T23:30:05Z","updated_at":"2015-09-25T23:30:05Z","body":"This looks pretty good! The only real issue is that the too-new syntax will break Terminus for some of our biggest clients.\r\n\r\nI also do not want to change the logger namespace. There will only be one, so adding another level to it becomes obfuscation."}}