{"action":"created","issue":{"url":"https://api.github.com/repos/cablehead/python-consul/issues/37","labels_url":"https://api.github.com/repos/cablehead/python-consul/issues/37/labels{/name}","comments_url":"https://api.github.com/repos/cablehead/python-consul/issues/37/comments","events_url":"https://api.github.com/repos/cablehead/python-consul/issues/37/events","html_url":"https://github.com/cablehead/python-consul/pull/37","id":69017124,"number":37,"title":"Adding ability to register checks with services","user":{"login":"cruatta","id":2013264,"avatar_url":"https://avatars.githubusercontent.com/u/2013264?v=3","gravatar_id":"","url":"https://api.github.com/users/cruatta","html_url":"https://github.com/cruatta","followers_url":"https://api.github.com/users/cruatta/followers","following_url":"https://api.github.com/users/cruatta/following{/other_user}","gists_url":"https://api.github.com/users/cruatta/gists{/gist_id}","starred_url":"https://api.github.com/users/cruatta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cruatta/subscriptions","organizations_url":"https://api.github.com/users/cruatta/orgs","repos_url":"https://api.github.com/users/cruatta/repos","events_url":"https://api.github.com/users/cruatta/events{/privacy}","received_events_url":"https://api.github.com/users/cruatta/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-04-16T21:49:44Z","updated_at":"2015-04-17T04:51:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cablehead/python-consul/pulls/37","html_url":"https://github.com/cablehead/python-consul/pull/37","diff_url":"https://github.com/cablehead/python-consul/pull/37.diff","patch_url":"https://github.com/cablehead/python-consul/pull/37.patch"},"body":"This should fix https://github.com/cablehead/python-consul/issues/36. I did a quick test and it worked fine. Thanks for taking a look!"},"comment":{"url":"https://api.github.com/repos/cablehead/python-consul/issues/comments/93892823","html_url":"https://github.com/cablehead/python-consul/pull/37#issuecomment-93892823","issue_url":"https://api.github.com/repos/cablehead/python-consul/issues/37","id":93892823,"user":{"login":"cablehead","id":1394,"avatar_url":"https://avatars.githubusercontent.com/u/1394?v=3","gravatar_id":"","url":"https://api.github.com/users/cablehead","html_url":"https://github.com/cablehead","followers_url":"https://api.github.com/users/cablehead/followers","following_url":"https://api.github.com/users/cablehead/following{/other_user}","gists_url":"https://api.github.com/users/cablehead/gists{/gist_id}","starred_url":"https://api.github.com/users/cablehead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cablehead/subscriptions","organizations_url":"https://api.github.com/users/cablehead/orgs","repos_url":"https://api.github.com/users/cablehead/repos","events_url":"https://api.github.com/users/cablehead/events{/privacy}","received_events_url":"https://api.github.com/users/cablehead/received_events","type":"User","site_admin":false},"created_at":"2015-04-17T04:51:31Z","updated_at":"2015-04-17T04:51:31Z","body":"Interesting. Yeah, I'd vote for leaving it out. Especially since\ndocumentation for this feature is so hard to come by, that people won't\nhave a reason to expect to be able to pass it.\n\nOn Thu, Apr 16, 2015 at 8:47 PM, Cameron Ruatta <notifications@github.com>\nwrote:\n\n> It looks like when you're registering a check, whatever you set\n> ServiceName to automatically gets overwritten by consul when the check is\n> registered:\n>\n> https://github.com/hashicorp/consul/blob/master/command/agent/agent.go#L712\n>\n> This means we could actually get rid of ServiceName since it's essentially\n> useless to provide it.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/cablehead/python-consul/pull/37#issuecomment-93887399>\n> .\n>\n"}}