{"action":"created","comment":{"url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/pulls/comments/36260047","id":36260047,"diff_hunk":"@@ -136,6 +136,106 @@ Example payload for setting \"Airplane Mode\":\n Data is the upper bits since in the future we may want to support setting\n certain types of Data the device is capable of. For example 3G, 4G, LTE.\n \n+Device Orientation\n+------------------\n+\n+The [JSON Wire Protocol](https://code.google.com/p/selenium/wiki/JsonWireProtocol#/session/:sessionId/orientation)\n+already supports a very basic concept of\n+orientation, involving two orientation options: portrait and landscape.\n+Ultimately this will be subsumed under Device Rotation (see below), but for now\n+we continue to support these endopints for mobile devices.\n+\n+* GET /session/:sessionid/orientation\n+    * returns ScreenOrientation\n+* POST /session/:sessionid/orientation\n+    * accepts a ScreenOrientation\n+\n+### ScreenOrientation\n+\n+A `ScreenOrientation` can be one of two strings:\n+\n+* `LANDSCAPE`\n+* `PORTRAIT`\n+\n+Device Rotation\n+---------------\n+\n+Mobile devices can theoretically be used in any spatial orientation. Thus the\n+concept of 'orientation' is actually much more general. We will call it","path":"spec-draft.md","position":51,"original_position":51,"commit_id":"47d3fbb2e481affa5851301ec5e1ce0562faac33","original_commit_id":"47d3fbb2e481affa5851301ec5e1ce0562faac33","user":{"login":"lukeis","id":926454,"avatar_url":"https://avatars.githubusercontent.com/u/926454?v=3","gravatar_id":"","url":"https://api.github.com/users/lukeis","html_url":"https://github.com/lukeis","followers_url":"https://api.github.com/users/lukeis/followers","following_url":"https://api.github.com/users/lukeis/following{/other_user}","gists_url":"https://api.github.com/users/lukeis/gists{/gist_id}","starred_url":"https://api.github.com/users/lukeis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukeis/subscriptions","organizations_url":"https://api.github.com/users/lukeis/orgs","repos_url":"https://api.github.com/users/lukeis/repos","events_url":"https://api.github.com/users/lukeis/events{/privacy}","received_events_url":"https://api.github.com/users/lukeis/received_events","type":"User","site_admin":false},"body":"\"We will call it\" I don't like the use of 'it' here, it's unclear in the sentence. Maybe \"We will call this spacial orientation 'rotation'\"?","created_at":"2015-08-05T00:52:04Z","updated_at":"2015-08-05T00:52:04Z","html_url":"https://github.com/SeleniumHQ/mobile-spec/pull/1#discussion_r36260047","pull_request_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/SeleniumHQ/mobile-spec/pulls/comments/36260047"},"html":{"href":"https://github.com/SeleniumHQ/mobile-spec/pull/1#discussion_r36260047"},"pull_request":{"href":"https://api.github.com/repos/SeleniumHQ/mobile-spec/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/pulls/1","id":41629013,"html_url":"https://github.com/SeleniumHQ/mobile-spec/pull/1","diff_url":"https://github.com/SeleniumHQ/mobile-spec/pull/1.diff","patch_url":"https://github.com/SeleniumHQ/mobile-spec/pull/1.patch","issue_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/issues/1","number":1,"state":"open","locked":false,"title":"add device orientation and rotation to spec for review","user":{"login":"jlipps","id":605053,"avatar_url":"https://avatars.githubusercontent.com/u/605053?v=3","gravatar_id":"","url":"https://api.github.com/users/jlipps","html_url":"https://github.com/jlipps","followers_url":"https://api.github.com/users/jlipps/followers","following_url":"https://api.github.com/users/jlipps/following{/other_user}","gists_url":"https://api.github.com/users/jlipps/gists{/gist_id}","starred_url":"https://api.github.com/users/jlipps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlipps/subscriptions","organizations_url":"https://api.github.com/users/jlipps/orgs","repos_url":"https://api.github.com/users/jlipps/repos","events_url":"https://api.github.com/users/jlipps/events{/privacy}","received_events_url":"https://api.github.com/users/jlipps/received_events","type":"User","site_admin":false},"body":"any thoughts on this proposal, @lukeis @AutomatedTester @malini @shs96c?","created_at":"2015-08-04T23:23:12Z","updated_at":"2015-08-05T00:52:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c66a3e95312e15293e8fb630e2a1fa6fffe9294","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/pulls/1/commits","review_comments_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/pulls/1/comments","review_comment_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/issues/1/comments","statuses_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/statuses/47d3fbb2e481affa5851301ec5e1ce0562faac33","head":{"label":"SeleniumHQ:jlipps-orientation","ref":"jlipps-orientation","sha":"47d3fbb2e481affa5851301ec5e1ce0562faac33","user":{"login":"SeleniumHQ","id":983927,"avatar_url":"https://avatars.githubusercontent.com/u/983927?v=3","gravatar_id":"","url":"https://api.github.com/users/SeleniumHQ","html_url":"https://github.com/SeleniumHQ","followers_url":"https://api.github.com/users/SeleniumHQ/followers","following_url":"https://api.github.com/users/SeleniumHQ/following{/other_user}","gists_url":"https://api.github.com/users/SeleniumHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/SeleniumHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeleniumHQ/subscriptions","organizations_url":"https://api.github.com/users/SeleniumHQ/orgs","repos_url":"https://api.github.com/users/SeleniumHQ/repos","events_url":"https://api.github.com/users/SeleniumHQ/events{/privacy}","received_events_url":"https://api.github.com/users/SeleniumHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":32183673,"name":"mobile-spec","full_name":"SeleniumHQ/mobile-spec","owner":{"login":"SeleniumHQ","id":983927,"avatar_url":"https://avatars.githubusercontent.com/u/983927?v=3","gravatar_id":"","url":"https://api.github.com/users/SeleniumHQ","html_url":"https://github.com/SeleniumHQ","followers_url":"https://api.github.com/users/SeleniumHQ/followers","following_url":"https://api.github.com/users/SeleniumHQ/following{/other_user}","gists_url":"https://api.github.com/users/SeleniumHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/SeleniumHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeleniumHQ/subscriptions","organizations_url":"https://api.github.com/users/SeleniumHQ/orgs","repos_url":"https://api.github.com/users/SeleniumHQ/repos","events_url":"https://api.github.com/users/SeleniumHQ/events{/privacy}","received_events_url":"https://api.github.com/users/SeleniumHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SeleniumHQ/mobile-spec","description":"","fork":false,"url":"https://api.github.com/repos/SeleniumHQ/mobile-spec","forks_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/forks","keys_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/teams","hooks_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/hooks","issue_events_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/issues/events{/number}","events_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/events","assignees_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/assignees{/user}","branches_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/branches{/branch}","tags_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/tags","blobs_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/languages","stargazers_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/stargazers","contributors_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/contributors","subscribers_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/subscribers","subscription_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/subscription","commits_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/contents/{+path}","compare_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/merges","archive_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/downloads","issues_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/issues{/number}","pulls_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/labels{/name}","releases_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/releases{/id}","created_at":"2015-03-13T22:19:38Z","updated_at":"2015-04-02T20:57:38Z","pushed_at":"2015-08-04T23:23:13Z","git_url":"git://github.com/SeleniumHQ/mobile-spec.git","ssh_url":"git@github.com:SeleniumHQ/mobile-spec.git","clone_url":"https://github.com/SeleniumHQ/mobile-spec.git","svn_url":"https://github.com/SeleniumHQ/mobile-spec","homepage":null,"size":2392,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"SeleniumHQ:master","ref":"master","sha":"d092f19128182199f4fafdb78534958102547283","user":{"login":"SeleniumHQ","id":983927,"avatar_url":"https://avatars.githubusercontent.com/u/983927?v=3","gravatar_id":"","url":"https://api.github.com/users/SeleniumHQ","html_url":"https://github.com/SeleniumHQ","followers_url":"https://api.github.com/users/SeleniumHQ/followers","following_url":"https://api.github.com/users/SeleniumHQ/following{/other_user}","gists_url":"https://api.github.com/users/SeleniumHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/SeleniumHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeleniumHQ/subscriptions","organizations_url":"https://api.github.com/users/SeleniumHQ/orgs","repos_url":"https://api.github.com/users/SeleniumHQ/repos","events_url":"https://api.github.com/users/SeleniumHQ/events{/privacy}","received_events_url":"https://api.github.com/users/SeleniumHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":32183673,"name":"mobile-spec","full_name":"SeleniumHQ/mobile-spec","owner":{"login":"SeleniumHQ","id":983927,"avatar_url":"https://avatars.githubusercontent.com/u/983927?v=3","gravatar_id":"","url":"https://api.github.com/users/SeleniumHQ","html_url":"https://github.com/SeleniumHQ","followers_url":"https://api.github.com/users/SeleniumHQ/followers","following_url":"https://api.github.com/users/SeleniumHQ/following{/other_user}","gists_url":"https://api.github.com/users/SeleniumHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/SeleniumHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeleniumHQ/subscriptions","organizations_url":"https://api.github.com/users/SeleniumHQ/orgs","repos_url":"https://api.github.com/users/SeleniumHQ/repos","events_url":"https://api.github.com/users/SeleniumHQ/events{/privacy}","received_events_url":"https://api.github.com/users/SeleniumHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SeleniumHQ/mobile-spec","description":"","fork":false,"url":"https://api.github.com/repos/SeleniumHQ/mobile-spec","forks_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/forks","keys_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/teams","hooks_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/hooks","issue_events_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/issues/events{/number}","events_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/events","assignees_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/assignees{/user}","branches_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/branches{/branch}","tags_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/tags","blobs_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/languages","stargazers_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/stargazers","contributors_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/contributors","subscribers_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/subscribers","subscription_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/subscription","commits_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/contents/{+path}","compare_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/merges","archive_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/downloads","issues_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/issues{/number}","pulls_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/labels{/name}","releases_url":"https://api.github.com/repos/SeleniumHQ/mobile-spec/releases{/id}","created_at":"2015-03-13T22:19:38Z","updated_at":"2015-04-02T20:57:38Z","pushed_at":"2015-08-04T23:23:13Z","git_url":"git://github.com/SeleniumHQ/mobile-spec.git","ssh_url":"git@github.com:SeleniumHQ/mobile-spec.git","clone_url":"https://github.com/SeleniumHQ/mobile-spec.git","svn_url":"https://github.com/SeleniumHQ/mobile-spec","homepage":null,"size":2392,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SeleniumHQ/mobile-spec/pulls/1"},"html":{"href":"https://github.com/SeleniumHQ/mobile-spec/pull/1"},"issue":{"href":"https://api.github.com/repos/SeleniumHQ/mobile-spec/issues/1"},"comments":{"href":"https://api.github.com/repos/SeleniumHQ/mobile-spec/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/SeleniumHQ/mobile-spec/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/SeleniumHQ/mobile-spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SeleniumHQ/mobile-spec/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/SeleniumHQ/mobile-spec/statuses/47d3fbb2e481affa5851301ec5e1ce0562faac33"}}}}