{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/jdbc-util/pulls/comments/30749144","id":30749144,"diff_hunk":"@@ -7,12 +7,21 @@\n   :license {:name \"Apache License, Version 2.0\"\n             :url \"http://www.apache.org/licenses/LICENSE-2.0.html\"}\n \n-  :dependencies [[org.clojure/clojure \"1.6.0\"]\n-                 [org.clojure/java.jdbc \"0.3.2\"]\n-                 [org.postgresql/postgresql \"9.3-1100-jdbc41\"]\n-                 [com.jolbox/bonecp \"0.8.0.RELEASE\" :exclusions [[org.slf4j/slf4j-api]]]\n+  :dependencies [[com.jolbox/bonecp \"0.8.0.RELEASE\" :exclusions [[org.slf4j/slf4j-api]]]\n+                 [com.zaxxer/HikariCP-java6 \"2.3.7\" :exclusions [[org.slf4j/slf4j-api]]]\n+                 [metrics-clojure \"2.5.1\" :exclusions [[org.slf4j/slf4j-api]]]","path":"project.clj","position":16,"original_position":16,"commit_id":"a9e5701f96f1aeb4cda8bf22defe0c3371736b99","original_commit_id":"a9e5701f96f1aeb4cda8bf22defe0c3371736b99","user":{"login":"kbarber","id":80595,"avatar_url":"https://avatars.githubusercontent.com/u/80595?v=3","gravatar_id":"","url":"https://api.github.com/users/kbarber","html_url":"https://github.com/kbarber","followers_url":"https://api.github.com/users/kbarber/followers","following_url":"https://api.github.com/users/kbarber/following{/other_user}","gists_url":"https://api.github.com/users/kbarber/gists{/gist_id}","starred_url":"https://api.github.com/users/kbarber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbarber/subscriptions","organizations_url":"https://api.github.com/users/kbarber/orgs","repos_url":"https://api.github.com/users/kbarber/repos","events_url":"https://api.github.com/users/kbarber/events{/privacy}","received_events_url":"https://api.github.com/users/kbarber/received_events","type":"User","site_admin":false},"body":"This is required because of how hikaricp wishes to register statistics, however - I'm tempted to leave this work or see how @cprice404's metrics work goes, since I presume we might need to somehow have an existing MetricRegistry passed to HikariCP. Anyway, lots of uncertainties here, we can have metrics without cprice's work, but it requires manual registration work for the data to get exposed via jmx:\r\n\r\n```\r\n(def JR (jmx/reporter {}))\r\n(metrics.reporters.jmx/start JR)\r\n```\r\n\r\nThese steps don't feel like they belong in jdbc-util obviously :-).\r\n\r\nRight now, I'm using the default-registry provided out of metrics-clojure by default, so this should just work.","created_at":"2015-05-20T21:03:54Z","updated_at":"2015-05-20T21:03:54Z","html_url":"https://github.com/puppetlabs/jdbc-util/pull/10#discussion_r30749144","pull_request_url":"https://api.github.com/repos/puppetlabs/jdbc-util/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/jdbc-util/pulls/comments/30749144"},"html":{"href":"https://github.com/puppetlabs/jdbc-util/pull/10#discussion_r30749144"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/jdbc-util/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/jdbc-util/pulls/10","id":35875539,"html_url":"https://github.com/puppetlabs/jdbc-util/pull/10","diff_url":"https://github.com/puppetlabs/jdbc-util/pull/10.diff","patch_url":"https://github.com/puppetlabs/jdbc-util/pull/10.patch","issue_url":"https://api.github.com/repos/puppetlabs/jdbc-util/issues/10","number":10,"state":"open","locked":false,"title":"WIP: (PDB-1488) Connection pooling","user":{"login":"kbarber","id":80595,"avatar_url":"https://avatars.githubusercontent.com/u/80595?v=3","gravatar_id":"","url":"https://api.github.com/users/kbarber","html_url":"https://github.com/kbarber","followers_url":"https://api.github.com/users/kbarber/followers","following_url":"https://api.github.com/users/kbarber/following{/other_user}","gists_url":"https://api.github.com/users/kbarber/gists{/gist_id}","starred_url":"https://api.github.com/users/kbarber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbarber/subscriptions","organizations_url":"https://api.github.com/users/kbarber/orgs","repos_url":"https://api.github.com/users/kbarber/repos","events_url":"https://api.github.com/users/kbarber/events{/privacy}","received_events_url":"https://api.github.com/users/kbarber/received_events","type":"User","site_admin":false},"body":"(work in progress, please don't merge)\r\n\r\nI'm raising this early as I'm going to work on some PDB tickets this sprint, and wanted to\r\nget something up there to look at.\r\n\r\nThis is a work-in-progress attempt at getting HikariCP connection pooling + jdbcdslog-exp +\r\nsome earlier metrics working going. I'll try to annotate where the dodgy parts are.\r\n\r\nIn particular you can see the fork of jdbcdslog-exp introduced here, this is for a few reasons:\r\n\r\n* That older code is no longer maintained, last touched 2011\r\n* The old code doesn't log to debug, this fork does\r\n* There is an absence of obvious things, like an inability to retrieve the proxied object so you can call close() on it, which is useful for testing at the very least\r\n\r\nI'm still not convinced forking is the right idea, however I have high hopes for this newer fork\r\nI found here: https://github.com/adrianshum/jdbcdslog, however it suffers all the same problems\r\nas before except for still being maintained. Perhaps the better direction is to patch upstream, however\r\nthere is one remaining element that related to per pool configuration, as opposed to the global\r\nnature of configuration in jdbcdslog today.\r\n\r\nAnyway ... the logging does work even though it looks horrid to fork all this code.\r\n\r\nI'll leave other annotations throughout the code where applicable.\r\n\r\nSigned-off-by: Ken Barber <ken@bob.sh>","created_at":"2015-05-20T20:59:51Z","updated_at":"2015-05-20T21:03:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f25dc95bf34f4cb3eee2d9647d75bddfd67ff93","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/jdbc-util/pulls/10/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/jdbc-util/pulls/10/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/jdbc-util/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/jdbc-util/issues/10/comments","statuses_url":"https://api.github.com/repos/puppetlabs/jdbc-util/statuses/a9e5701f96f1aeb4cda8bf22defe0c3371736b99","head":{"label":"kbarber:ticket/master/pdb-1488-connection-pooling","ref":"ticket/master/pdb-1488-connection-pooling","sha":"a9e5701f96f1aeb4cda8bf22defe0c3371736b99","user":{"login":"kbarber","id":80595,"avatar_url":"https://avatars.githubusercontent.com/u/80595?v=3","gravatar_id":"","url":"https://api.github.com/users/kbarber","html_url":"https://github.com/kbarber","followers_url":"https://api.github.com/users/kbarber/followers","following_url":"https://api.github.com/users/kbarber/following{/other_user}","gists_url":"https://api.github.com/users/kbarber/gists{/gist_id}","starred_url":"https://api.github.com/users/kbarber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbarber/subscriptions","organizations_url":"https://api.github.com/users/kbarber/orgs","repos_url":"https://api.github.com/users/kbarber/repos","events_url":"https://api.github.com/users/kbarber/events{/privacy}","received_events_url":"https://api.github.com/users/kbarber/received_events","type":"User","site_admin":false},"repo":{"id":35878040,"name":"jdbc-util","full_name":"kbarber/jdbc-util","owner":{"login":"kbarber","id":80595,"avatar_url":"https://avatars.githubusercontent.com/u/80595?v=3","gravatar_id":"","url":"https://api.github.com/users/kbarber","html_url":"https://github.com/kbarber","followers_url":"https://api.github.com/users/kbarber/followers","following_url":"https://api.github.com/users/kbarber/following{/other_user}","gists_url":"https://api.github.com/users/kbarber/gists{/gist_id}","starred_url":"https://api.github.com/users/kbarber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbarber/subscriptions","organizations_url":"https://api.github.com/users/kbarber/orgs","repos_url":"https://api.github.com/users/kbarber/repos","events_url":"https://api.github.com/users/kbarber/events{/privacy}","received_events_url":"https://api.github.com/users/kbarber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kbarber/jdbc-util","description":"Common jdbc utilities for use in Puppet Labs clojure projects","fork":true,"url":"https://api.github.com/repos/kbarber/jdbc-util","forks_url":"https://api.github.com/repos/kbarber/jdbc-util/forks","keys_url":"https://api.github.com/repos/kbarber/jdbc-util/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kbarber/jdbc-util/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kbarber/jdbc-util/teams","hooks_url":"https://api.github.com/repos/kbarber/jdbc-util/hooks","issue_events_url":"https://api.github.com/repos/kbarber/jdbc-util/issues/events{/number}","events_url":"https://api.github.com/repos/kbarber/jdbc-util/events","assignees_url":"https://api.github.com/repos/kbarber/jdbc-util/assignees{/user}","branches_url":"https://api.github.com/repos/kbarber/jdbc-util/branches{/branch}","tags_url":"https://api.github.com/repos/kbarber/jdbc-util/tags","blobs_url":"https://api.github.com/repos/kbarber/jdbc-util/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kbarber/jdbc-util/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kbarber/jdbc-util/git/refs{/sha}","trees_url":"https://api.github.com/repos/kbarber/jdbc-util/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kbarber/jdbc-util/statuses/{sha}","languages_url":"https://api.github.com/repos/kbarber/jdbc-util/languages","stargazers_url":"https://api.github.com/repos/kbarber/jdbc-util/stargazers","contributors_url":"https://api.github.com/repos/kbarber/jdbc-util/contributors","subscribers_url":"https://api.github.com/repos/kbarber/jdbc-util/subscribers","subscription_url":"https://api.github.com/repos/kbarber/jdbc-util/subscription","commits_url":"https://api.github.com/repos/kbarber/jdbc-util/commits{/sha}","git_commits_url":"https://api.github.com/repos/kbarber/jdbc-util/git/commits{/sha}","comments_url":"https://api.github.com/repos/kbarber/jdbc-util/comments{/number}","issue_comment_url":"https://api.github.com/repos/kbarber/jdbc-util/issues/comments{/number}","contents_url":"https://api.github.com/repos/kbarber/jdbc-util/contents/{+path}","compare_url":"https://api.github.com/repos/kbarber/jdbc-util/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kbarber/jdbc-util/merges","archive_url":"https://api.github.com/repos/kbarber/jdbc-util/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kbarber/jdbc-util/downloads","issues_url":"https://api.github.com/repos/kbarber/jdbc-util/issues{/number}","pulls_url":"https://api.github.com/repos/kbarber/jdbc-util/pulls{/number}","milestones_url":"https://api.github.com/repos/kbarber/jdbc-util/milestones{/number}","notifications_url":"https://api.github.com/repos/kbarber/jdbc-util/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kbarber/jdbc-util/labels{/name}","releases_url":"https://api.github.com/repos/kbarber/jdbc-util/releases{/id}","created_at":"2015-05-19T11:28:11Z","updated_at":"2015-05-19T11:28:12Z","pushed_at":"2015-05-20T20:52:58Z","git_url":"git://github.com/kbarber/jdbc-util.git","ssh_url":"git@github.com:kbarber/jdbc-util.git","clone_url":"https://github.com/kbarber/jdbc-util.git","svn_url":"https://github.com/kbarber/jdbc-util","homepage":null,"size":108,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"07f335d91554dcf2972023f93193ac2fcd44c535","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":18688473,"name":"jdbc-util","full_name":"puppetlabs/jdbc-util","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/jdbc-util","description":"Common jdbc utilities for use in Puppet Labs clojure projects","fork":false,"url":"https://api.github.com/repos/puppetlabs/jdbc-util","forks_url":"https://api.github.com/repos/puppetlabs/jdbc-util/forks","keys_url":"https://api.github.com/repos/puppetlabs/jdbc-util/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/jdbc-util/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/jdbc-util/teams","hooks_url":"https://api.github.com/repos/puppetlabs/jdbc-util/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/jdbc-util/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/jdbc-util/events","assignees_url":"https://api.github.com/repos/puppetlabs/jdbc-util/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/jdbc-util/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/jdbc-util/tags","blobs_url":"https://api.github.com/repos/puppetlabs/jdbc-util/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/jdbc-util/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/jdbc-util/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/jdbc-util/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/jdbc-util/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/jdbc-util/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/jdbc-util/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/jdbc-util/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/jdbc-util/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/jdbc-util/subscription","commits_url":"https://api.github.com/repos/puppetlabs/jdbc-util/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/jdbc-util/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/jdbc-util/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/jdbc-util/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/jdbc-util/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/jdbc-util/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/jdbc-util/merges","archive_url":"https://api.github.com/repos/puppetlabs/jdbc-util/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/jdbc-util/downloads","issues_url":"https://api.github.com/repos/puppetlabs/jdbc-util/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/jdbc-util/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/jdbc-util/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/jdbc-util/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/jdbc-util/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/jdbc-util/releases{/id}","created_at":"2014-04-11T20:55:57Z","updated_at":"2014-12-31T18:58:03Z","pushed_at":"2015-05-20T20:59:52Z","git_url":"git://github.com/puppetlabs/jdbc-util.git","ssh_url":"git@github.com:puppetlabs/jdbc-util.git","clone_url":"https://github.com/puppetlabs/jdbc-util.git","svn_url":"https://github.com/puppetlabs/jdbc-util","homepage":null,"size":213,"stargazers_count":1,"watchers_count":1,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/jdbc-util/pulls/10"},"html":{"href":"https://github.com/puppetlabs/jdbc-util/pull/10"},"issue":{"href":"https://api.github.com/repos/puppetlabs/jdbc-util/issues/10"},"comments":{"href":"https://api.github.com/repos/puppetlabs/jdbc-util/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/jdbc-util/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/jdbc-util/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/jdbc-util/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/jdbc-util/statuses/a9e5701f96f1aeb4cda8bf22defe0c3371736b99"}}}}