{"action":"closed","number":511,"pull_request":{"url":"https://api.github.com/repos/SitePen/dgrid/pulls/511","id":4843539,"html_url":"https://github.com/SitePen/dgrid/pull/511","diff_url":"https://github.com/SitePen/dgrid/pull/511.diff","patch_url":"https://github.com/SitePen/dgrid/pull/511.patch","issue_url":"https://api.github.com/repos/SitePen/dgrid/issues/511","number":511,"state":"closed","locked":false,"title":"[SAMPLE] simulate pagination bug when adding new row","user":{"login":"gratex","id":1631199,"avatar_url":"https://avatars.githubusercontent.com/u/1631199?v=3","gravatar_id":"","url":"https://api.github.com/users/gratex","html_url":"https://github.com/gratex","followers_url":"https://api.github.com/users/gratex/followers","following_url":"https://api.github.com/users/gratex/following{/other_user}","gists_url":"https://api.github.com/users/gratex/gists{/gist_id}","starred_url":"https://api.github.com/users/gratex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gratex/subscriptions","organizations_url":"https://api.github.com/users/gratex/orgs","repos_url":"https://api.github.com/users/gratex/repos","events_url":"https://api.github.com/users/gratex/events{/privacy}","received_events_url":"https://api.github.com/users/gratex/received_events","type":"User","site_admin":false},"body":"pagination extension is not being notified about adding new item into observable store in the case when item should be inserted into the next page.\r\n\r\nThe root of this problem seems to be inside dojo/store/Observable \r\nhttps://github.com/dojo/dojo/blob/master/store/Observable.js#L103\r\n\r\nVariable insertedInto equals -1 which prevents notifying listeners (in this case pagination extension) about changes and therefore grid will not update total count of items neither page links. User can not see new rows, because these rows are on the other page, however link to the other page was not created... User will see new rows only in the case, when other notification was fired (sort, delete, etc).\r\n\r\nWe have added simple testcase where you can try it. Just create more than three rows.\r\nWhen you comment out line 103 in Observable store, it seems to be working correctly.\r\n","created_at":"2013-03-27T15:42:29Z","updated_at":"2015-02-12T04:12:13Z","closed_at":"2015-02-12T04:12:13Z","merged_at":null,"merge_commit_sha":"7723e9192efa0e334053117eca00bb4c0cf25c55","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SitePen/dgrid/pulls/511/commits","review_comments_url":"https://api.github.com/repos/SitePen/dgrid/pulls/511/comments","review_comment_url":"https://api.github.com/repos/SitePen/dgrid/pulls/comments/{number}","comments_url":"https://api.github.com/repos/SitePen/dgrid/issues/511/comments","statuses_url":"https://api.github.com/repos/SitePen/dgrid/statuses/ffa90b35d53f29d32d6acab574e672327753a88b","head":{"label":"gratex:pagination-observe-bug","ref":"pagination-observe-bug","sha":"ffa90b35d53f29d32d6acab574e672327753a88b","user":{"login":"gratex","id":1631199,"avatar_url":"https://avatars.githubusercontent.com/u/1631199?v=3","gravatar_id":"","url":"https://api.github.com/users/gratex","html_url":"https://github.com/gratex","followers_url":"https://api.github.com/users/gratex/followers","following_url":"https://api.github.com/users/gratex/following{/other_user}","gists_url":"https://api.github.com/users/gratex/gists{/gist_id}","starred_url":"https://api.github.com/users/gratex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gratex/subscriptions","organizations_url":"https://api.github.com/users/gratex/orgs","repos_url":"https://api.github.com/users/gratex/repos","events_url":"https://api.github.com/users/gratex/events{/privacy}","received_events_url":"https://api.github.com/users/gratex/received_events","type":"User","site_admin":false},"repo":{"id":4699566,"name":"dgrid","full_name":"gratex/dgrid","owner":{"login":"gratex","id":1631199,"avatar_url":"https://avatars.githubusercontent.com/u/1631199?v=3","gravatar_id":"","url":"https://api.github.com/users/gratex","html_url":"https://github.com/gratex","followers_url":"https://api.github.com/users/gratex/followers","following_url":"https://api.github.com/users/gratex/following{/other_user}","gists_url":"https://api.github.com/users/gratex/gists{/gist_id}","starred_url":"https://api.github.com/users/gratex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gratex/subscriptions","organizations_url":"https://api.github.com/users/gratex/orgs","repos_url":"https://api.github.com/users/gratex/repos","events_url":"https://api.github.com/users/gratex/events{/privacy}","received_events_url":"https://api.github.com/users/gratex/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gratex/dgrid","description":"A lightweight, mobile-ready, data-driven, modular grid widget designed for use with the Dojo object store","fork":true,"url":"https://api.github.com/repos/gratex/dgrid","forks_url":"https://api.github.com/repos/gratex/dgrid/forks","keys_url":"https://api.github.com/repos/gratex/dgrid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gratex/dgrid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gratex/dgrid/teams","hooks_url":"https://api.github.com/repos/gratex/dgrid/hooks","issue_events_url":"https://api.github.com/repos/gratex/dgrid/issues/events{/number}","events_url":"https://api.github.com/repos/gratex/dgrid/events","assignees_url":"https://api.github.com/repos/gratex/dgrid/assignees{/user}","branches_url":"https://api.github.com/repos/gratex/dgrid/branches{/branch}","tags_url":"https://api.github.com/repos/gratex/dgrid/tags","blobs_url":"https://api.github.com/repos/gratex/dgrid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gratex/dgrid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gratex/dgrid/git/refs{/sha}","trees_url":"https://api.github.com/repos/gratex/dgrid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gratex/dgrid/statuses/{sha}","languages_url":"https://api.github.com/repos/gratex/dgrid/languages","stargazers_url":"https://api.github.com/repos/gratex/dgrid/stargazers","contributors_url":"https://api.github.com/repos/gratex/dgrid/contributors","subscribers_url":"https://api.github.com/repos/gratex/dgrid/subscribers","subscription_url":"https://api.github.com/repos/gratex/dgrid/subscription","commits_url":"https://api.github.com/repos/gratex/dgrid/commits{/sha}","git_commits_url":"https://api.github.com/repos/gratex/dgrid/git/commits{/sha}","comments_url":"https://api.github.com/repos/gratex/dgrid/comments{/number}","issue_comment_url":"https://api.github.com/repos/gratex/dgrid/issues/comments/{number}","contents_url":"https://api.github.com/repos/gratex/dgrid/contents/{+path}","compare_url":"https://api.github.com/repos/gratex/dgrid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gratex/dgrid/merges","archive_url":"https://api.github.com/repos/gratex/dgrid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gratex/dgrid/downloads","issues_url":"https://api.github.com/repos/gratex/dgrid/issues{/number}","pulls_url":"https://api.github.com/repos/gratex/dgrid/pulls{/number}","milestones_url":"https://api.github.com/repos/gratex/dgrid/milestones{/number}","notifications_url":"https://api.github.com/repos/gratex/dgrid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gratex/dgrid/labels{/name}","releases_url":"https://api.github.com/repos/gratex/dgrid/releases{/id}","created_at":"2012-06-18T10:05:55Z","updated_at":"2014-06-23T10:57:42Z","pushed_at":"2015-01-30T16:06:39Z","git_url":"git://github.com/gratex/dgrid.git","ssh_url":"git@github.com:gratex/dgrid.git","clone_url":"https://github.com/gratex/dgrid.git","svn_url":"https://github.com/gratex/dgrid","homepage":"http://dojotoolkit.org/","size":11155,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"SitePen:master","ref":"master","sha":"38da696433f4471d4e036087586dc26acb200b5a","user":{"login":"SitePen","id":1067343,"avatar_url":"https://avatars.githubusercontent.com/u/1067343?v=3","gravatar_id":"","url":"https://api.github.com/users/SitePen","html_url":"https://github.com/SitePen","followers_url":"https://api.github.com/users/SitePen/followers","following_url":"https://api.github.com/users/SitePen/following{/other_user}","gists_url":"https://api.github.com/users/SitePen/gists{/gist_id}","starred_url":"https://api.github.com/users/SitePen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SitePen/subscriptions","organizations_url":"https://api.github.com/users/SitePen/orgs","repos_url":"https://api.github.com/users/SitePen/repos","events_url":"https://api.github.com/users/SitePen/events{/privacy}","received_events_url":"https://api.github.com/users/SitePen/received_events","type":"Organization","site_admin":false},"repo":{"id":966614,"name":"dgrid","full_name":"SitePen/dgrid","owner":{"login":"SitePen","id":1067343,"avatar_url":"https://avatars.githubusercontent.com/u/1067343?v=3","gravatar_id":"","url":"https://api.github.com/users/SitePen","html_url":"https://github.com/SitePen","followers_url":"https://api.github.com/users/SitePen/followers","following_url":"https://api.github.com/users/SitePen/following{/other_user}","gists_url":"https://api.github.com/users/SitePen/gists{/gist_id}","starred_url":"https://api.github.com/users/SitePen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SitePen/subscriptions","organizations_url":"https://api.github.com/users/SitePen/orgs","repos_url":"https://api.github.com/users/SitePen/repos","events_url":"https://api.github.com/users/SitePen/events{/privacy}","received_events_url":"https://api.github.com/users/SitePen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SitePen/dgrid","description":"A lightweight, mobile-ready, data-driven, modular grid widget designed for use with the Dojo object store","fork":false,"url":"https://api.github.com/repos/SitePen/dgrid","forks_url":"https://api.github.com/repos/SitePen/dgrid/forks","keys_url":"https://api.github.com/repos/SitePen/dgrid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SitePen/dgrid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SitePen/dgrid/teams","hooks_url":"https://api.github.com/repos/SitePen/dgrid/hooks","issue_events_url":"https://api.github.com/repos/SitePen/dgrid/issues/events{/number}","events_url":"https://api.github.com/repos/SitePen/dgrid/events","assignees_url":"https://api.github.com/repos/SitePen/dgrid/assignees{/user}","branches_url":"https://api.github.com/repos/SitePen/dgrid/branches{/branch}","tags_url":"https://api.github.com/repos/SitePen/dgrid/tags","blobs_url":"https://api.github.com/repos/SitePen/dgrid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SitePen/dgrid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SitePen/dgrid/git/refs{/sha}","trees_url":"https://api.github.com/repos/SitePen/dgrid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SitePen/dgrid/statuses/{sha}","languages_url":"https://api.github.com/repos/SitePen/dgrid/languages","stargazers_url":"https://api.github.com/repos/SitePen/dgrid/stargazers","contributors_url":"https://api.github.com/repos/SitePen/dgrid/contributors","subscribers_url":"https://api.github.com/repos/SitePen/dgrid/subscribers","subscription_url":"https://api.github.com/repos/SitePen/dgrid/subscription","commits_url":"https://api.github.com/repos/SitePen/dgrid/commits{/sha}","git_commits_url":"https://api.github.com/repos/SitePen/dgrid/git/commits{/sha}","comments_url":"https://api.github.com/repos/SitePen/dgrid/comments{/number}","issue_comment_url":"https://api.github.com/repos/SitePen/dgrid/issues/comments/{number}","contents_url":"https://api.github.com/repos/SitePen/dgrid/contents/{+path}","compare_url":"https://api.github.com/repos/SitePen/dgrid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SitePen/dgrid/merges","archive_url":"https://api.github.com/repos/SitePen/dgrid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SitePen/dgrid/downloads","issues_url":"https://api.github.com/repos/SitePen/dgrid/issues{/number}","pulls_url":"https://api.github.com/repos/SitePen/dgrid/pulls{/number}","milestones_url":"https://api.github.com/repos/SitePen/dgrid/milestones{/number}","notifications_url":"https://api.github.com/repos/SitePen/dgrid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SitePen/dgrid/labels{/name}","releases_url":"https://api.github.com/repos/SitePen/dgrid/releases{/id}","created_at":"2010-10-06T14:27:11Z","updated_at":"2015-02-10T23:48:33Z","pushed_at":"2015-02-10T23:48:32Z","git_url":"git://github.com/SitePen/dgrid.git","ssh_url":"git@github.com:SitePen/dgrid.git","clone_url":"https://github.com/SitePen/dgrid.git","svn_url":"https://github.com/SitePen/dgrid","homepage":"http://dojotoolkit.org/","size":16707,"stargazers_count":478,"watchers_count":478,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":232,"mirror_url":null,"open_issues_count":175,"forks":232,"open_issues":175,"watchers":478,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SitePen/dgrid/pulls/511"},"html":{"href":"https://github.com/SitePen/dgrid/pull/511"},"issue":{"href":"https://api.github.com/repos/SitePen/dgrid/issues/511"},"comments":{"href":"https://api.github.com/repos/SitePen/dgrid/issues/511/comments"},"review_comments":{"href":"https://api.github.com/repos/SitePen/dgrid/pulls/511/comments"},"review_comment":{"href":"https://api.github.com/repos/SitePen/dgrid/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/SitePen/dgrid/pulls/511/commits"},"statuses":{"href":"https://api.github.com/repos/SitePen/dgrid/statuses/ffa90b35d53f29d32d6acab574e672327753a88b"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":94,"deletions":0,"changed_files":1}}