{"action":"opened","number":44,"pull_request":{"url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/44","id":30571297,"html_url":"https://github.com/SUSE/saltstack-netapi-client-java/pull/44","diff_url":"https://github.com/SUSE/saltstack-netapi-client-java/pull/44.diff","patch_url":"https://github.com/SUSE/saltstack-netapi-client-java/pull/44.patch","issue_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/issues/44","number":44,"state":"open","locked":false,"title":"/stats endpoint implementation","user":{"login":"lucidd","id":688888,"avatar_url":"https://avatars.githubusercontent.com/u/688888?v=3","gravatar_id":"","url":"https://api.github.com/users/lucidd","html_url":"https://github.com/lucidd","followers_url":"https://api.github.com/users/lucidd/followers","following_url":"https://api.github.com/users/lucidd/following{/other_user}","gists_url":"https://api.github.com/users/lucidd/gists{/gist_id}","starred_url":"https://api.github.com/users/lucidd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucidd/subscriptions","organizations_url":"https://api.github.com/users/lucidd/orgs","repos_url":"https://api.github.com/users/lucidd/repos","events_url":"https://api.github.com/users/lucidd/events{/privacy}","received_events_url":"https://api.github.com/users/lucidd/received_events","type":"User","site_admin":false},"body":"This PR implements access to the netapi `/stats` endpoint. I couldn't find any documentation on the return type of this call so all the datatypes are \"best guess\" implementations based on the `json` returned by my local saltmaster. I also left the `Request` field of `cherrypy.Applications` unimplemented and added a todo since the `json` only contains an empty object so i don't know it's structure.\r\n\r\n\r\n\r\n#### Aditional thoughts / Improvements\r\n\r\n* `getBindAddress` could return a `InetSocketAddress` instead of a `String`\r\n* Exposing `getThreads` feels redundant since `getWorkerThreads.size()` should give the same information.\r\n* `Uptime` could be represented with `java.time.Duration` when we move to Java 8.\r\n* Redundant information like in `threads` /  `workerThreads` and `uptime` / `startTime` / `currentTime` could be checked against each other for validation to filter some \"bad\" responses.","created_at":"2015-03-05T16:24:29Z","updated_at":"2015-03-05T16:24:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/44/commits","review_comments_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/44/comments","review_comment_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/issues/44/comments","statuses_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/statuses/c1c940ee00767b68c3308454a7a075aa08c08614","head":{"label":"lucidd:stats","ref":"stats","sha":"c1c940ee00767b68c3308454a7a075aa08c08614","user":{"login":"lucidd","id":688888,"avatar_url":"https://avatars.githubusercontent.com/u/688888?v=3","gravatar_id":"","url":"https://api.github.com/users/lucidd","html_url":"https://github.com/lucidd","followers_url":"https://api.github.com/users/lucidd/followers","following_url":"https://api.github.com/users/lucidd/following{/other_user}","gists_url":"https://api.github.com/users/lucidd/gists{/gist_id}","starred_url":"https://api.github.com/users/lucidd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucidd/subscriptions","organizations_url":"https://api.github.com/users/lucidd/orgs","repos_url":"https://api.github.com/users/lucidd/repos","events_url":"https://api.github.com/users/lucidd/events{/privacy}","received_events_url":"https://api.github.com/users/lucidd/received_events","type":"User","site_admin":false},"repo":{"id":30558019,"name":"saltstack-netapi-client-java","full_name":"lucidd/saltstack-netapi-client-java","owner":{"login":"lucidd","id":688888,"avatar_url":"https://avatars.githubusercontent.com/u/688888?v=3","gravatar_id":"","url":"https://api.github.com/users/lucidd","html_url":"https://github.com/lucidd","followers_url":"https://api.github.com/users/lucidd/followers","following_url":"https://api.github.com/users/lucidd/following{/other_user}","gists_url":"https://api.github.com/users/lucidd/gists{/gist_id}","starred_url":"https://api.github.com/users/lucidd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucidd/subscriptions","organizations_url":"https://api.github.com/users/lucidd/orgs","repos_url":"https://api.github.com/users/lucidd/repos","events_url":"https://api.github.com/users/lucidd/events{/privacy}","received_events_url":"https://api.github.com/users/lucidd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lucidd/saltstack-netapi-client-java","description":"Java client to access the SaltStack net-api","fork":true,"url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java","forks_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/forks","keys_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/teams","hooks_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/hooks","issue_events_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/issues/events{/number}","events_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/events","assignees_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/assignees{/user}","branches_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/branches{/branch}","tags_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/tags","blobs_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/statuses/{sha}","languages_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/languages","stargazers_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/stargazers","contributors_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/contributors","subscribers_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/subscribers","subscription_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/subscription","commits_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/contents/{+path}","compare_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/merges","archive_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/downloads","issues_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/issues{/number}","pulls_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/pulls{/number}","milestones_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/milestones{/number}","notifications_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/labels{/name}","releases_url":"https://api.github.com/repos/lucidd/saltstack-netapi-client-java/releases{/id}","created_at":"2015-02-09T20:55:31Z","updated_at":"2015-02-27T23:19:41Z","pushed_at":"2015-03-05T15:30:57Z","git_url":"git://github.com/lucidd/saltstack-netapi-client-java.git","ssh_url":"git@github.com:lucidd/saltstack-netapi-client-java.git","clone_url":"https://github.com/lucidd/saltstack-netapi-client-java.git","svn_url":"https://github.com/lucidd/saltstack-netapi-client-java","homepage":null,"size":7839,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SUSE:master","ref":"master","sha":"02accaa9e7b3e13d4a3fd2cb79ca1851567fc899","user":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":25811020,"name":"saltstack-netapi-client-java","full_name":"SUSE/saltstack-netapi-client-java","owner":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE/saltstack-netapi-client-java","description":"Java client to access the SaltStack net-api","fork":false,"url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java","forks_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/forks","keys_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/teams","hooks_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/hooks","issue_events_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/events","assignees_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/tags","blobs_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/languages","stargazers_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/stargazers","contributors_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/contributors","subscribers_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/subscribers","subscription_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/subscription","commits_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/merges","archive_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/downloads","issues_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/releases{/id}","created_at":"2014-10-27T09:06:51Z","updated_at":"2015-03-03T09:39:22Z","pushed_at":"2015-03-03T09:39:21Z","git_url":"git://github.com/SUSE/saltstack-netapi-client-java.git","ssh_url":"git@github.com:SUSE/saltstack-netapi-client-java.git","clone_url":"https://github.com/SUSE/saltstack-netapi-client-java.git","svn_url":"https://github.com/SUSE/saltstack-netapi-client-java","homepage":null,"size":21029,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":2,"forks":12,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/44"},"html":{"href":"https://github.com/SUSE/saltstack-netapi-client-java/pull/44"},"issue":{"href":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/issues/44"},"comments":{"href":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/SUSE/saltstack-netapi-client-java/statuses/c1c940ee00767b68c3308454a7a075aa08c08614"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":510,"deletions":1,"changed_files":9}}