{"action":"closed","issue":{"url":"https://api.github.com/repos/xetorthio/jedis/issues/1104","labels_url":"https://api.github.com/repos/xetorthio/jedis/issues/1104/labels{/name}","comments_url":"https://api.github.com/repos/xetorthio/jedis/issues/1104/comments","events_url":"https://api.github.com/repos/xetorthio/jedis/issues/1104/events","html_url":"https://github.com/xetorthio/jedis/issues/1104","id":103133694,"number":1104,"title":"Socket leak when commands failed at makeObject()","user":{"login":"yaxing","id":392918,"avatar_url":"https://avatars.githubusercontent.com/u/392918?v=3","gravatar_id":"","url":"https://api.github.com/users/yaxing","html_url":"https://github.com/yaxing","followers_url":"https://api.github.com/users/yaxing/followers","following_url":"https://api.github.com/users/yaxing/following{/other_user}","gists_url":"https://api.github.com/users/yaxing/gists{/gist_id}","starred_url":"https://api.github.com/users/yaxing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaxing/subscriptions","organizations_url":"https://api.github.com/users/yaxing/orgs","repos_url":"https://api.github.com/users/yaxing/repos","events_url":"https://api.github.com/users/yaxing/events{/privacy}","received_events_url":"https://api.github.com/users/yaxing/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-08-25T22:52:12Z","updated_at":"2015-08-28T12:57:35Z","closed_at":"2015-08-28T12:57:35Z","body":"There's a potential socket leak issue at makeObject() when using JedisPool here:\r\n\r\nhttps://github.com/xetorthio/jedis/blob/master/src/main/java/redis/clients/jedis/JedisFactory.java#L87\r\n\r\nAfter establishing the connection using ```.connect()```, if commands like ```.select()``` failed and exception thrown there, then this socket would hang since there's no way to call ```returnBrokenResource``` or ```close()``` on it in higher level logics. \r\n\r\nIf Redis is not configured to close idle connections from server side, such connections would stay idle there.\r\n"}}