{"action":"created","comment":{"url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/pulls/comments/41867290","id":41867290,"diff_hunk":"@@ -0,0 +1,8 @@\n+﻿namespace Monopoly\n+{\n+    public interface IRandomNumberGenerator\n+    {\n+        int Generate(int min, int max);\n+        int RollDice();","path":"IRandomNumberGenerator.cs","position":6,"original_position":6,"commit_id":"dcf024c94c1fd1360c6271d2e9bf0265f53e7f36","original_commit_id":"dcf024c94c1fd1360c6271d2e9bf0265f53e7f36","user":{"login":"FGS-BMarkham","id":10197798,"avatar_url":"https://avatars.githubusercontent.com/u/10197798?v=3","gravatar_id":"","url":"https://api.github.com/users/FGS-BMarkham","html_url":"https://github.com/FGS-BMarkham","followers_url":"https://api.github.com/users/FGS-BMarkham/followers","following_url":"https://api.github.com/users/FGS-BMarkham/following{/other_user}","gists_url":"https://api.github.com/users/FGS-BMarkham/gists{/gist_id}","starred_url":"https://api.github.com/users/FGS-BMarkham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FGS-BMarkham/subscriptions","organizations_url":"https://api.github.com/users/FGS-BMarkham/orgs","repos_url":"https://api.github.com/users/FGS-BMarkham/repos","events_url":"https://api.github.com/users/FGS-BMarkham/events{/privacy}","received_events_url":"https://api.github.com/users/FGS-BMarkham/received_events","type":"User","site_admin":false},"body":"Try not to have interfaces expose members that can be functionally composed on top of the interface abstraction itself. That is, either take dice rolling into a separate abstraction+implementation pair that takes a dependency on `IRandomNumberGenerator`, or write an extension method that extends `IRandomNumberGenerator`.","created_at":"2015-10-13T13:51:08Z","updated_at":"2015-10-13T13:51:08Z","html_url":"https://github.com/foxguardsolutions/DBudwin-Monopoly/pull/1#discussion_r41867290","pull_request_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/pulls/comments/41867290"},"html":{"href":"https://github.com/foxguardsolutions/DBudwin-Monopoly/pull/1#discussion_r41867290"},"pull_request":{"href":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/pulls/1","id":47443014,"html_url":"https://github.com/foxguardsolutions/DBudwin-Monopoly/pull/1","diff_url":"https://github.com/foxguardsolutions/DBudwin-Monopoly/pull/1.diff","patch_url":"https://github.com/foxguardsolutions/DBudwin-Monopoly/pull/1.patch","issue_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/issues/1","number":1,"state":"open","locked":false,"title":"Monopoly release 1 commit","user":{"login":"fgs-dbudwin","id":14611316,"avatar_url":"https://avatars.githubusercontent.com/u/14611316?v=3","gravatar_id":"","url":"https://api.github.com/users/fgs-dbudwin","html_url":"https://github.com/fgs-dbudwin","followers_url":"https://api.github.com/users/fgs-dbudwin/followers","following_url":"https://api.github.com/users/fgs-dbudwin/following{/other_user}","gists_url":"https://api.github.com/users/fgs-dbudwin/gists{/gist_id}","starred_url":"https://api.github.com/users/fgs-dbudwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgs-dbudwin/subscriptions","organizations_url":"https://api.github.com/users/fgs-dbudwin/orgs","repos_url":"https://api.github.com/users/fgs-dbudwin/repos","events_url":"https://api.github.com/users/fgs-dbudwin/events{/privacy}","received_events_url":"https://api.github.com/users/fgs-dbudwin/received_events","type":"User","site_admin":false},"body":"Monopoly release 1 commit\r\n\r\n-Implements the board and basic player movement\r\n-Test cases for the provided User Stories\r\n-Please review my use of Moq for Mocking random numbers","created_at":"2015-10-12T17:08:45Z","updated_at":"2015-10-13T13:51:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c3418820c0925e8979a83ef92eccde7eb076e6c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/pulls/1/commits","review_comments_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/pulls/1/comments","review_comment_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/issues/1/comments","statuses_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/statuses/dcf024c94c1fd1360c6271d2e9bf0265f53e7f36","head":{"label":"fgs-dbudwin:release1","ref":"release1","sha":"dcf024c94c1fd1360c6271d2e9bf0265f53e7f36","user":{"login":"fgs-dbudwin","id":14611316,"avatar_url":"https://avatars.githubusercontent.com/u/14611316?v=3","gravatar_id":"","url":"https://api.github.com/users/fgs-dbudwin","html_url":"https://github.com/fgs-dbudwin","followers_url":"https://api.github.com/users/fgs-dbudwin/followers","following_url":"https://api.github.com/users/fgs-dbudwin/following{/other_user}","gists_url":"https://api.github.com/users/fgs-dbudwin/gists{/gist_id}","starred_url":"https://api.github.com/users/fgs-dbudwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgs-dbudwin/subscriptions","organizations_url":"https://api.github.com/users/fgs-dbudwin/orgs","repos_url":"https://api.github.com/users/fgs-dbudwin/repos","events_url":"https://api.github.com/users/fgs-dbudwin/events{/privacy}","received_events_url":"https://api.github.com/users/fgs-dbudwin/received_events","type":"User","site_admin":false},"repo":{"id":44116482,"name":"DBudwin-Monopoly","full_name":"fgs-dbudwin/DBudwin-Monopoly","owner":{"login":"fgs-dbudwin","id":14611316,"avatar_url":"https://avatars.githubusercontent.com/u/14611316?v=3","gravatar_id":"","url":"https://api.github.com/users/fgs-dbudwin","html_url":"https://github.com/fgs-dbudwin","followers_url":"https://api.github.com/users/fgs-dbudwin/followers","following_url":"https://api.github.com/users/fgs-dbudwin/following{/other_user}","gists_url":"https://api.github.com/users/fgs-dbudwin/gists{/gist_id}","starred_url":"https://api.github.com/users/fgs-dbudwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgs-dbudwin/subscriptions","organizations_url":"https://api.github.com/users/fgs-dbudwin/orgs","repos_url":"https://api.github.com/users/fgs-dbudwin/repos","events_url":"https://api.github.com/users/fgs-dbudwin/events{/privacy}","received_events_url":"https://api.github.com/users/fgs-dbudwin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fgs-dbudwin/DBudwin-Monopoly","description":"","fork":true,"url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly","forks_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/forks","keys_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/teams","hooks_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/hooks","issue_events_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/issues/events{/number}","events_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/events","assignees_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/assignees{/user}","branches_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/branches{/branch}","tags_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/tags","blobs_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/git/refs{/sha}","trees_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/statuses/{sha}","languages_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/languages","stargazers_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/stargazers","contributors_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/contributors","subscribers_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/subscribers","subscription_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/subscription","commits_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/commits{/sha}","git_commits_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/git/commits{/sha}","comments_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/comments{/number}","issue_comment_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/issues/comments{/number}","contents_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/contents/{+path}","compare_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/merges","archive_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/downloads","issues_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/issues{/number}","pulls_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/pulls{/number}","milestones_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/milestones{/number}","notifications_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/labels{/name}","releases_url":"https://api.github.com/repos/fgs-dbudwin/DBudwin-Monopoly/releases{/id}","created_at":"2015-10-12T15:30:37Z","updated_at":"2015-10-12T15:30:38Z","pushed_at":"2015-10-12T17:11:10Z","git_url":"git://github.com/fgs-dbudwin/DBudwin-Monopoly.git","ssh_url":"git@github.com:fgs-dbudwin/DBudwin-Monopoly.git","clone_url":"https://github.com/fgs-dbudwin/DBudwin-Monopoly.git","svn_url":"https://github.com/fgs-dbudwin/DBudwin-Monopoly","homepage":null,"size":66,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"foxguardsolutions:master","ref":"master","sha":"99f1db34636c835a59797e87b435f810443603ea","user":{"login":"foxguardsolutions","id":10062567,"avatar_url":"https://avatars.githubusercontent.com/u/10062567?v=3","gravatar_id":"","url":"https://api.github.com/users/foxguardsolutions","html_url":"https://github.com/foxguardsolutions","followers_url":"https://api.github.com/users/foxguardsolutions/followers","following_url":"https://api.github.com/users/foxguardsolutions/following{/other_user}","gists_url":"https://api.github.com/users/foxguardsolutions/gists{/gist_id}","starred_url":"https://api.github.com/users/foxguardsolutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foxguardsolutions/subscriptions","organizations_url":"https://api.github.com/users/foxguardsolutions/orgs","repos_url":"https://api.github.com/users/foxguardsolutions/repos","events_url":"https://api.github.com/users/foxguardsolutions/events{/privacy}","received_events_url":"https://api.github.com/users/foxguardsolutions/received_events","type":"Organization","site_admin":false},"repo":{"id":42936416,"name":"DBudwin-Monopoly","full_name":"foxguardsolutions/DBudwin-Monopoly","owner":{"login":"foxguardsolutions","id":10062567,"avatar_url":"https://avatars.githubusercontent.com/u/10062567?v=3","gravatar_id":"","url":"https://api.github.com/users/foxguardsolutions","html_url":"https://github.com/foxguardsolutions","followers_url":"https://api.github.com/users/foxguardsolutions/followers","following_url":"https://api.github.com/users/foxguardsolutions/following{/other_user}","gists_url":"https://api.github.com/users/foxguardsolutions/gists{/gist_id}","starred_url":"https://api.github.com/users/foxguardsolutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foxguardsolutions/subscriptions","organizations_url":"https://api.github.com/users/foxguardsolutions/orgs","repos_url":"https://api.github.com/users/foxguardsolutions/repos","events_url":"https://api.github.com/users/foxguardsolutions/events{/privacy}","received_events_url":"https://api.github.com/users/foxguardsolutions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/foxguardsolutions/DBudwin-Monopoly","description":"","fork":false,"url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly","forks_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/forks","keys_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/teams","hooks_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/hooks","issue_events_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/issues/events{/number}","events_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/events","assignees_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/assignees{/user}","branches_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/branches{/branch}","tags_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/tags","blobs_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/git/refs{/sha}","trees_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/statuses/{sha}","languages_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/languages","stargazers_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/stargazers","contributors_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/contributors","subscribers_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/subscribers","subscription_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/subscription","commits_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/commits{/sha}","git_commits_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/git/commits{/sha}","comments_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/comments{/number}","issue_comment_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/issues/comments{/number}","contents_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/contents/{+path}","compare_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/merges","archive_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/downloads","issues_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/issues{/number}","pulls_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/pulls{/number}","milestones_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/milestones{/number}","notifications_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/labels{/name}","releases_url":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/releases{/id}","created_at":"2015-09-22T13:46:35Z","updated_at":"2015-10-12T15:56:41Z","pushed_at":"2015-10-12T17:11:11Z","git_url":"git://github.com/foxguardsolutions/DBudwin-Monopoly.git","ssh_url":"git@github.com:foxguardsolutions/DBudwin-Monopoly.git","clone_url":"https://github.com/foxguardsolutions/DBudwin-Monopoly.git","svn_url":"https://github.com/foxguardsolutions/DBudwin-Monopoly","homepage":null,"size":118,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/pulls/1"},"html":{"href":"https://github.com/foxguardsolutions/DBudwin-Monopoly/pull/1"},"issue":{"href":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/issues/1"},"comments":{"href":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/foxguardsolutions/DBudwin-Monopoly/statuses/dcf024c94c1fd1360c6271d2e9bf0265f53e7f36"}}}}