{"action":"closed","number":23,"pull_request":{"url":"https://api.github.com/repos/boostorg/log/pulls/23","id":53876125,"html_url":"https://github.com/boostorg/log/pull/23","diff_url":"https://github.com/boostorg/log/pull/23.diff","patch_url":"https://github.com/boostorg/log/pull/23.patch","issue_url":"https://api.github.com/repos/boostorg/log/issues/23","number":23,"state":"closed","locked":false,"title":"Use the MSVC 8 workaround on 9 for SFINAE fail too","user":{"login":"muggenhor","id":484066,"avatar_url":"https://avatars.githubusercontent.com/u/484066?v=3","gravatar_id":"","url":"https://api.github.com/users/muggenhor","html_url":"https://github.com/muggenhor","followers_url":"https://api.github.com/users/muggenhor/followers","following_url":"https://api.github.com/users/muggenhor/following{/other_user}","gists_url":"https://api.github.com/users/muggenhor/gists{/gist_id}","starred_url":"https://api.github.com/users/muggenhor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muggenhor/subscriptions","organizations_url":"https://api.github.com/users/muggenhor/orgs","repos_url":"https://api.github.com/users/muggenhor/repos","events_url":"https://api.github.com/users/muggenhor/events{/privacy}","received_events_url":"https://api.github.com/users/muggenhor/received_events","type":"User","site_admin":false},"body":"Use the MSVC 8 workaround on 9 for SFINAE fail too\r\n\r\nTemplate expansion fails on MSVC 9 otherwise with:\r\n> error C2440: 'default argument' : cannot convert from 'int' to 'boost::type'\r\non the basic_formatter constructor taking a functor.\r\n\r\nFor reference the full compiler error on VS 2008:\r\n```\r\n--------------------Configuration: Boost.Log\r\nCompiling...\r\nformatter_parser.cpp (0:07.12 at +0:07)\r\nboost_1_59_0\\include\\boost\\log\\expressions\\formatter.hpp(156) : error C2440: 'default argument' : cannot convert from 'int' to 'boost::type'\r\n        The target type has no constructors\r\n        boost_1_59_0\\libs\\log\\src\\formatter_parser.cpp(422) : see reference to function template instantiation 'boost::log::v2s_mt_nt5::`anonymous-namespace'::chained_formatter<CharT,SecondT>::chained_formatter<boost::rv<T>>(boost::rv<T> &,const boost::rv<T> &)' being compiled\r\n        with\r\n        [\r\n            CharT=char,\r\n            SecondT=boost::log::v2s_mt_nt5::basic_formatter<char>,\r\n            T=boost::log::v2s_mt_nt5::basic_formatter<char>\r\n        ]\r\n        boost_1_59_0\\libs\\log\\src\\formatter_parser.cpp(401) : see reference to function template instantiation 'void boost::log::v2s_mt_nt5::`anonymous-namespace'::formatter_parser<CharT>::append_formatter<boost::log::v2s_mt_nt5::basic_formatter<CharT>>(FormatterT)' being compiled\r\n        with\r\n        [\r\n            CharT=char_type,\r\n            FormatterT=boost::log::v2s_mt_nt5::basic_formatter<char>\r\n        ]\r\n        boost_1_59_0\\libs\\log\\src\\formatter_parser.cpp(388) : while compiling class template member function 'void boost::log::v2s_mt_nt5::`anonymous-namespace'::formatter_parser<CharT>::push_attr(void)'\r\n        with\r\n        [\r\n            CharT=char_type\r\n        ]\r\n        boost_1_59_0\\libs\\log\\src\\formatter_parser.cpp(452) : see reference to class template instantiation 'boost::log::v2s_mt_nt5::`anonymous-namespace'::formatter_parser<CharT>' being compiled\r\n        with\r\n        [\r\n            CharT=char_type\r\n        ]\r\n        boost_1_59_0\\libs\\log\\src\\formatter_parser.cpp(468) : see reference to function template instantiation 'boost::log::v2s_mt_nt5::basic_formatter<CharT> boost::log::v2s_mt_nt5::parse_formatter<char>(const char *,const char *)' being compiled\r\n        with\r\n        [\r\n            CharT=char\r\n        ]\r\nboost_1_59_0\\libs\\log\\src\\formatter_parser.cpp(135) : fatal error C1903: unable to recover from previous error(s); stopping compilation\r\n```","created_at":"2015-12-16T17:59:52Z","updated_at":"2015-12-20T11:23:37Z","closed_at":"2015-12-20T11:23:37Z","merged_at":"2015-12-20T11:23:37Z","merge_commit_sha":"e06c12f0103c28a90e5cf3a89e2af8bdabfdefad","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/boostorg/log/pulls/23/commits","review_comments_url":"https://api.github.com/repos/boostorg/log/pulls/23/comments","review_comment_url":"https://api.github.com/repos/boostorg/log/pulls/comments{/number}","comments_url":"https://api.github.com/repos/boostorg/log/issues/23/comments","statuses_url":"https://api.github.com/repos/boostorg/log/statuses/3b6d6dc158931d701021fcbf7f442be007966c0c","head":{"label":"muggenhor:msvc9-sfinae-compatibility","ref":"msvc9-sfinae-compatibility","sha":"3b6d6dc158931d701021fcbf7f442be007966c0c","user":{"login":"muggenhor","id":484066,"avatar_url":"https://avatars.githubusercontent.com/u/484066?v=3","gravatar_id":"","url":"https://api.github.com/users/muggenhor","html_url":"https://github.com/muggenhor","followers_url":"https://api.github.com/users/muggenhor/followers","following_url":"https://api.github.com/users/muggenhor/following{/other_user}","gists_url":"https://api.github.com/users/muggenhor/gists{/gist_id}","starred_url":"https://api.github.com/users/muggenhor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muggenhor/subscriptions","organizations_url":"https://api.github.com/users/muggenhor/orgs","repos_url":"https://api.github.com/users/muggenhor/repos","events_url":"https://api.github.com/users/muggenhor/events{/privacy}","received_events_url":"https://api.github.com/users/muggenhor/received_events","type":"User","site_admin":false},"repo":{"id":48121205,"name":"boost-log","full_name":"muggenhor/boost-log","owner":{"login":"muggenhor","id":484066,"avatar_url":"https://avatars.githubusercontent.com/u/484066?v=3","gravatar_id":"","url":"https://api.github.com/users/muggenhor","html_url":"https://github.com/muggenhor","followers_url":"https://api.github.com/users/muggenhor/followers","following_url":"https://api.github.com/users/muggenhor/following{/other_user}","gists_url":"https://api.github.com/users/muggenhor/gists{/gist_id}","starred_url":"https://api.github.com/users/muggenhor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muggenhor/subscriptions","organizations_url":"https://api.github.com/users/muggenhor/orgs","repos_url":"https://api.github.com/users/muggenhor/repos","events_url":"https://api.github.com/users/muggenhor/events{/privacy}","received_events_url":"https://api.github.com/users/muggenhor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/muggenhor/boost-log","description":"","fork":true,"url":"https://api.github.com/repos/muggenhor/boost-log","forks_url":"https://api.github.com/repos/muggenhor/boost-log/forks","keys_url":"https://api.github.com/repos/muggenhor/boost-log/keys{/key_id}","collaborators_url":"https://api.github.com/repos/muggenhor/boost-log/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/muggenhor/boost-log/teams","hooks_url":"https://api.github.com/repos/muggenhor/boost-log/hooks","issue_events_url":"https://api.github.com/repos/muggenhor/boost-log/issues/events{/number}","events_url":"https://api.github.com/repos/muggenhor/boost-log/events","assignees_url":"https://api.github.com/repos/muggenhor/boost-log/assignees{/user}","branches_url":"https://api.github.com/repos/muggenhor/boost-log/branches{/branch}","tags_url":"https://api.github.com/repos/muggenhor/boost-log/tags","blobs_url":"https://api.github.com/repos/muggenhor/boost-log/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/muggenhor/boost-log/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/muggenhor/boost-log/git/refs{/sha}","trees_url":"https://api.github.com/repos/muggenhor/boost-log/git/trees{/sha}","statuses_url":"https://api.github.com/repos/muggenhor/boost-log/statuses/{sha}","languages_url":"https://api.github.com/repos/muggenhor/boost-log/languages","stargazers_url":"https://api.github.com/repos/muggenhor/boost-log/stargazers","contributors_url":"https://api.github.com/repos/muggenhor/boost-log/contributors","subscribers_url":"https://api.github.com/repos/muggenhor/boost-log/subscribers","subscription_url":"https://api.github.com/repos/muggenhor/boost-log/subscription","commits_url":"https://api.github.com/repos/muggenhor/boost-log/commits{/sha}","git_commits_url":"https://api.github.com/repos/muggenhor/boost-log/git/commits{/sha}","comments_url":"https://api.github.com/repos/muggenhor/boost-log/comments{/number}","issue_comment_url":"https://api.github.com/repos/muggenhor/boost-log/issues/comments{/number}","contents_url":"https://api.github.com/repos/muggenhor/boost-log/contents/{+path}","compare_url":"https://api.github.com/repos/muggenhor/boost-log/compare/{base}...{head}","merges_url":"https://api.github.com/repos/muggenhor/boost-log/merges","archive_url":"https://api.github.com/repos/muggenhor/boost-log/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/muggenhor/boost-log/downloads","issues_url":"https://api.github.com/repos/muggenhor/boost-log/issues{/number}","pulls_url":"https://api.github.com/repos/muggenhor/boost-log/pulls{/number}","milestones_url":"https://api.github.com/repos/muggenhor/boost-log/milestones{/number}","notifications_url":"https://api.github.com/repos/muggenhor/boost-log/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/muggenhor/boost-log/labels{/name}","releases_url":"https://api.github.com/repos/muggenhor/boost-log/releases{/id}","created_at":"2015-12-16T16:15:07Z","updated_at":"2015-12-16T16:15:22Z","pushed_at":"2015-12-16T17:59:25Z","git_url":"git://github.com/muggenhor/boost-log.git","ssh_url":"git@github.com:muggenhor/boost-log.git","clone_url":"https://github.com/muggenhor/boost-log.git","svn_url":"https://github.com/muggenhor/boost-log","homepage":null,"size":1874,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"boostorg:develop","ref":"develop","sha":"92bc02594205c48f685083fc7f8251cc22f1c9d8","user":{"login":"boostorg","id":3170529,"avatar_url":"https://avatars.githubusercontent.com/u/3170529?v=3","gravatar_id":"","url":"https://api.github.com/users/boostorg","html_url":"https://github.com/boostorg","followers_url":"https://api.github.com/users/boostorg/followers","following_url":"https://api.github.com/users/boostorg/following{/other_user}","gists_url":"https://api.github.com/users/boostorg/gists{/gist_id}","starred_url":"https://api.github.com/users/boostorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boostorg/subscriptions","organizations_url":"https://api.github.com/users/boostorg/orgs","repos_url":"https://api.github.com/users/boostorg/repos","events_url":"https://api.github.com/users/boostorg/events{/privacy}","received_events_url":"https://api.github.com/users/boostorg/received_events","type":"Organization","site_admin":false},"repo":{"id":9418496,"name":"log","full_name":"boostorg/log","owner":{"login":"boostorg","id":3170529,"avatar_url":"https://avatars.githubusercontent.com/u/3170529?v=3","gravatar_id":"","url":"https://api.github.com/users/boostorg","html_url":"https://github.com/boostorg","followers_url":"https://api.github.com/users/boostorg/followers","following_url":"https://api.github.com/users/boostorg/following{/other_user}","gists_url":"https://api.github.com/users/boostorg/gists{/gist_id}","starred_url":"https://api.github.com/users/boostorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boostorg/subscriptions","organizations_url":"https://api.github.com/users/boostorg/orgs","repos_url":"https://api.github.com/users/boostorg/repos","events_url":"https://api.github.com/users/boostorg/events{/privacy}","received_events_url":"https://api.github.com/users/boostorg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/boostorg/log","description":"","fork":false,"url":"https://api.github.com/repos/boostorg/log","forks_url":"https://api.github.com/repos/boostorg/log/forks","keys_url":"https://api.github.com/repos/boostorg/log/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boostorg/log/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boostorg/log/teams","hooks_url":"https://api.github.com/repos/boostorg/log/hooks","issue_events_url":"https://api.github.com/repos/boostorg/log/issues/events{/number}","events_url":"https://api.github.com/repos/boostorg/log/events","assignees_url":"https://api.github.com/repos/boostorg/log/assignees{/user}","branches_url":"https://api.github.com/repos/boostorg/log/branches{/branch}","tags_url":"https://api.github.com/repos/boostorg/log/tags","blobs_url":"https://api.github.com/repos/boostorg/log/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boostorg/log/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boostorg/log/git/refs{/sha}","trees_url":"https://api.github.com/repos/boostorg/log/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boostorg/log/statuses/{sha}","languages_url":"https://api.github.com/repos/boostorg/log/languages","stargazers_url":"https://api.github.com/repos/boostorg/log/stargazers","contributors_url":"https://api.github.com/repos/boostorg/log/contributors","subscribers_url":"https://api.github.com/repos/boostorg/log/subscribers","subscription_url":"https://api.github.com/repos/boostorg/log/subscription","commits_url":"https://api.github.com/repos/boostorg/log/commits{/sha}","git_commits_url":"https://api.github.com/repos/boostorg/log/git/commits{/sha}","comments_url":"https://api.github.com/repos/boostorg/log/comments{/number}","issue_comment_url":"https://api.github.com/repos/boostorg/log/issues/comments{/number}","contents_url":"https://api.github.com/repos/boostorg/log/contents/{+path}","compare_url":"https://api.github.com/repos/boostorg/log/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boostorg/log/merges","archive_url":"https://api.github.com/repos/boostorg/log/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boostorg/log/downloads","issues_url":"https://api.github.com/repos/boostorg/log/issues{/number}","pulls_url":"https://api.github.com/repos/boostorg/log/pulls{/number}","milestones_url":"https://api.github.com/repos/boostorg/log/milestones{/number}","notifications_url":"https://api.github.com/repos/boostorg/log/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boostorg/log/labels{/name}","releases_url":"https://api.github.com/repos/boostorg/log/releases{/id}","created_at":"2013-04-13T18:57:25Z","updated_at":"2015-11-21T07:44:19Z","pushed_at":"2015-12-20T11:23:37Z","git_url":"git://github.com/boostorg/log.git","ssh_url":"git@github.com:boostorg/log.git","clone_url":"https://github.com/boostorg/log.git","svn_url":"https://github.com/boostorg/log","homepage":null,"size":2284,"stargazers_count":29,"watchers_count":29,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":4,"forks":30,"open_issues":4,"watchers":29,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/boostorg/log/pulls/23"},"html":{"href":"https://github.com/boostorg/log/pull/23"},"issue":{"href":"https://api.github.com/repos/boostorg/log/issues/23"},"comments":{"href":"https://api.github.com/repos/boostorg/log/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/boostorg/log/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/boostorg/log/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/boostorg/log/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/boostorg/log/statuses/3b6d6dc158931d701021fcbf7f442be007966c0c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Lastique","id":1589747,"avatar_url":"https://avatars.githubusercontent.com/u/1589747?v=3","gravatar_id":"","url":"https://api.github.com/users/Lastique","html_url":"https://github.com/Lastique","followers_url":"https://api.github.com/users/Lastique/followers","following_url":"https://api.github.com/users/Lastique/following{/other_user}","gists_url":"https://api.github.com/users/Lastique/gists{/gist_id}","starred_url":"https://api.github.com/users/Lastique/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lastique/subscriptions","organizations_url":"https://api.github.com/users/Lastique/orgs","repos_url":"https://api.github.com/users/Lastique/repos","events_url":"https://api.github.com/users/Lastique/events{/privacy}","received_events_url":"https://api.github.com/users/Lastique/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}