{"action":"created","comment":{"url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/pulls/comments/26997944","id":26997944,"diff_hunk":"@@ -484,6 +484,9 @@ function ChildCheck:_runChild(exePath, exeArgs, environ, callback)\n           checkStatus = fmt('Plugin exited with non-zero status code (code=%s)', (code))\n         end\n \n+        -- some python crash dumps print to stdout and were getting set in the\n+        -- status line. clear the status line and set to failure\n+        checkResult:setStatus(\"failure\")\n         checkResult:setError(checkStatus)","path":"check/base.lua","position":7,"original_position":7,"commit_id":"167b7d6ac292d245c82c9c89a801615d318988d1","original_commit_id":"167b7d6ac292d245c82c9c89a801615d318988d1","user":{"login":"jjbuchan","id":4358210,"avatar_url":"https://avatars.githubusercontent.com/u/4358210?v=3","gravatar_id":"","url":"https://api.github.com/users/jjbuchan","html_url":"https://github.com/jjbuchan","followers_url":"https://api.github.com/users/jjbuchan/followers","following_url":"https://api.github.com/users/jjbuchan/following{/other_user}","gists_url":"https://api.github.com/users/jjbuchan/gists{/gist_id}","starred_url":"https://api.github.com/users/jjbuchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjbuchan/subscriptions","organizations_url":"https://api.github.com/users/jjbuchan/orgs","repos_url":"https://api.github.com/users/jjbuchan/repos","events_url":"https://api.github.com/users/jjbuchan/events{/privacy}","received_events_url":"https://api.github.com/users/jjbuchan/received_events","type":"User","site_admin":false},"body":"Wouldn't this override the `setStatus`?\r\n\r\n```\r\nfunction CheckResult:setError(message)\r\n    self._metrics = {}\r\n    self:setUnavailable()\r\n    self:setStatus(message)\r\nend\r\n```","created_at":"2015-03-24T01:44:56Z","updated_at":"2015-03-24T01:44:56Z","html_url":"https://github.com/virgo-agent-toolkit/rackspace-monitoring-agent/pull/699#discussion_r26997944","pull_request_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/pulls/699","_links":{"self":{"href":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/pulls/comments/26997944"},"html":{"href":"https://github.com/virgo-agent-toolkit/rackspace-monitoring-agent/pull/699#discussion_r26997944"},"pull_request":{"href":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/pulls/699"}}},"pull_request":{"url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/pulls/699","id":31790239,"html_url":"https://github.com/virgo-agent-toolkit/rackspace-monitoring-agent/pull/699","diff_url":"https://github.com/virgo-agent-toolkit/rackspace-monitoring-agent/pull/699.diff","patch_url":"https://github.com/virgo-agent-toolkit/rackspace-monitoring-agent/pull/699.patch","issue_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/issues/699","number":699,"state":"open","locked":false,"title":"fix(plugins): status line on errors","user":{"login":"rphillips","id":1963,"avatar_url":"https://avatars.githubusercontent.com/u/1963?v=3","gravatar_id":"","url":"https://api.github.com/users/rphillips","html_url":"https://github.com/rphillips","followers_url":"https://api.github.com/users/rphillips/followers","following_url":"https://api.github.com/users/rphillips/following{/other_user}","gists_url":"https://api.github.com/users/rphillips/gists{/gist_id}","starred_url":"https://api.github.com/users/rphillips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rphillips/subscriptions","organizations_url":"https://api.github.com/users/rphillips/orgs","repos_url":"https://api.github.com/users/rphillips/repos","events_url":"https://api.github.com/users/rphillips/events{/privacy}","received_events_url":"https://api.github.com/users/rphillips/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-03-24T01:31:30Z","updated_at":"2015-03-24T01:44:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55f3e38302f58f4f8096ed3f1d0bac99a1bde20c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/pulls/699/commits","review_comments_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/pulls/699/comments","review_comment_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/issues/699/comments","statuses_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/statuses/167b7d6ac292d245c82c9c89a801615d318988d1","head":{"label":"virgo-agent-toolkit:fixes/fix_status_line_on_errors","ref":"fixes/fix_status_line_on_errors","sha":"167b7d6ac292d245c82c9c89a801615d318988d1","user":{"login":"virgo-agent-toolkit","id":6343547,"avatar_url":"https://avatars.githubusercontent.com/u/6343547?v=3","gravatar_id":"","url":"https://api.github.com/users/virgo-agent-toolkit","html_url":"https://github.com/virgo-agent-toolkit","followers_url":"https://api.github.com/users/virgo-agent-toolkit/followers","following_url":"https://api.github.com/users/virgo-agent-toolkit/following{/other_user}","gists_url":"https://api.github.com/users/virgo-agent-toolkit/gists{/gist_id}","starred_url":"https://api.github.com/users/virgo-agent-toolkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virgo-agent-toolkit/subscriptions","organizations_url":"https://api.github.com/users/virgo-agent-toolkit/orgs","repos_url":"https://api.github.com/users/virgo-agent-toolkit/repos","events_url":"https://api.github.com/users/virgo-agent-toolkit/events{/privacy}","received_events_url":"https://api.github.com/users/virgo-agent-toolkit/received_events","type":"Organization","site_admin":false},"repo":{"id":2034526,"name":"rackspace-monitoring-agent","full_name":"virgo-agent-toolkit/rackspace-monitoring-agent","owner":{"login":"virgo-agent-toolkit","id":6343547,"avatar_url":"https://avatars.githubusercontent.com/u/6343547?v=3","gravatar_id":"","url":"https://api.github.com/users/virgo-agent-toolkit","html_url":"https://github.com/virgo-agent-toolkit","followers_url":"https://api.github.com/users/virgo-agent-toolkit/followers","following_url":"https://api.github.com/users/virgo-agent-toolkit/following{/other_user}","gists_url":"https://api.github.com/users/virgo-agent-toolkit/gists{/gist_id}","starred_url":"https://api.github.com/users/virgo-agent-toolkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virgo-agent-toolkit/subscriptions","organizations_url":"https://api.github.com/users/virgo-agent-toolkit/orgs","repos_url":"https://api.github.com/users/virgo-agent-toolkit/repos","events_url":"https://api.github.com/users/virgo-agent-toolkit/events{/privacy}","received_events_url":"https://api.github.com/users/virgo-agent-toolkit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/virgo-agent-toolkit/rackspace-monitoring-agent","description":"Rackspace Cloud Monitoring Agent","fork":false,"url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent","forks_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/forks","keys_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/teams","hooks_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/hooks","issue_events_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/issues/events{/number}","events_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/events","assignees_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/assignees{/user}","branches_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/branches{/branch}","tags_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/tags","blobs_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/languages","stargazers_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/stargazers","contributors_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/contributors","subscribers_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/subscribers","subscription_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/subscription","commits_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/contents/{+path}","compare_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/merges","archive_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/downloads","issues_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/issues{/number}","pulls_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/labels{/name}","releases_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/releases{/id}","created_at":"2011-07-12T06:25:25Z","updated_at":"2015-03-23T21:51:24Z","pushed_at":"2015-03-24T01:31:31Z","git_url":"git://github.com/virgo-agent-toolkit/rackspace-monitoring-agent.git","ssh_url":"git@github.com:virgo-agent-toolkit/rackspace-monitoring-agent.git","clone_url":"https://github.com/virgo-agent-toolkit/rackspace-monitoring-agent.git","svn_url":"https://github.com/virgo-agent-toolkit/rackspace-monitoring-agent","homepage":"http://virgoagent.com/rackspace-monitoring-agent/","size":101479,"stargazers_count":105,"watchers_count":105,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":31,"mirror_url":null,"open_issues_count":51,"forks":31,"open_issues":51,"watchers":105,"default_branch":"luvi-up"}},"base":{"label":"virgo-agent-toolkit:master","ref":"master","sha":"107b98334194038a6abd20c85cf1f06e298eb8b4","user":{"login":"virgo-agent-toolkit","id":6343547,"avatar_url":"https://avatars.githubusercontent.com/u/6343547?v=3","gravatar_id":"","url":"https://api.github.com/users/virgo-agent-toolkit","html_url":"https://github.com/virgo-agent-toolkit","followers_url":"https://api.github.com/users/virgo-agent-toolkit/followers","following_url":"https://api.github.com/users/virgo-agent-toolkit/following{/other_user}","gists_url":"https://api.github.com/users/virgo-agent-toolkit/gists{/gist_id}","starred_url":"https://api.github.com/users/virgo-agent-toolkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virgo-agent-toolkit/subscriptions","organizations_url":"https://api.github.com/users/virgo-agent-toolkit/orgs","repos_url":"https://api.github.com/users/virgo-agent-toolkit/repos","events_url":"https://api.github.com/users/virgo-agent-toolkit/events{/privacy}","received_events_url":"https://api.github.com/users/virgo-agent-toolkit/received_events","type":"Organization","site_admin":false},"repo":{"id":2034526,"name":"rackspace-monitoring-agent","full_name":"virgo-agent-toolkit/rackspace-monitoring-agent","owner":{"login":"virgo-agent-toolkit","id":6343547,"avatar_url":"https://avatars.githubusercontent.com/u/6343547?v=3","gravatar_id":"","url":"https://api.github.com/users/virgo-agent-toolkit","html_url":"https://github.com/virgo-agent-toolkit","followers_url":"https://api.github.com/users/virgo-agent-toolkit/followers","following_url":"https://api.github.com/users/virgo-agent-toolkit/following{/other_user}","gists_url":"https://api.github.com/users/virgo-agent-toolkit/gists{/gist_id}","starred_url":"https://api.github.com/users/virgo-agent-toolkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virgo-agent-toolkit/subscriptions","organizations_url":"https://api.github.com/users/virgo-agent-toolkit/orgs","repos_url":"https://api.github.com/users/virgo-agent-toolkit/repos","events_url":"https://api.github.com/users/virgo-agent-toolkit/events{/privacy}","received_events_url":"https://api.github.com/users/virgo-agent-toolkit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/virgo-agent-toolkit/rackspace-monitoring-agent","description":"Rackspace Cloud Monitoring Agent","fork":false,"url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent","forks_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/forks","keys_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/teams","hooks_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/hooks","issue_events_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/issues/events{/number}","events_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/events","assignees_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/assignees{/user}","branches_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/branches{/branch}","tags_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/tags","blobs_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/languages","stargazers_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/stargazers","contributors_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/contributors","subscribers_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/subscribers","subscription_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/subscription","commits_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/contents/{+path}","compare_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/merges","archive_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/downloads","issues_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/issues{/number}","pulls_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/labels{/name}","releases_url":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/releases{/id}","created_at":"2011-07-12T06:25:25Z","updated_at":"2015-03-23T21:51:24Z","pushed_at":"2015-03-24T01:31:31Z","git_url":"git://github.com/virgo-agent-toolkit/rackspace-monitoring-agent.git","ssh_url":"git@github.com:virgo-agent-toolkit/rackspace-monitoring-agent.git","clone_url":"https://github.com/virgo-agent-toolkit/rackspace-monitoring-agent.git","svn_url":"https://github.com/virgo-agent-toolkit/rackspace-monitoring-agent","homepage":"http://virgoagent.com/rackspace-monitoring-agent/","size":101479,"stargazers_count":105,"watchers_count":105,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":31,"mirror_url":null,"open_issues_count":51,"forks":31,"open_issues":51,"watchers":105,"default_branch":"luvi-up"}},"_links":{"self":{"href":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/pulls/699"},"html":{"href":"https://github.com/virgo-agent-toolkit/rackspace-monitoring-agent/pull/699"},"issue":{"href":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/issues/699"},"comments":{"href":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/issues/699/comments"},"review_comments":{"href":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/pulls/699/comments"},"review_comment":{"href":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/pulls/699/commits"},"statuses":{"href":"https://api.github.com/repos/virgo-agent-toolkit/rackspace-monitoring-agent/statuses/167b7d6ac292d245c82c9c89a801615d318988d1"}}}}