{"action":"created","comment":{"url":"https://api.github.com/repos/percona/PerconaFT/pulls/comments/37868937","id":37868937,"diff_hunk":"@@ -117,6 +117,13 @@ if (NOT CMAKE_CXX_COMPILER_ID MATCHES Clang)\n     )\n endif ()\n \n+option (PROFILING \"Allow profiling and debug\" OFF)\n+if (PROFILING)\n+  set_cflags_if_supported(","path":"cmake_modules/TokuSetupCompiler.cmake","position":6,"original_position":6,"commit_id":"76b10122fab12ddf379a9d3a0c0d81c07bdc2378","original_commit_id":"76b10122fab12ddf379a9d3a0c0d81c07bdc2378","user":{"login":"vadimtk","id":290907,"avatar_url":"https://avatars.githubusercontent.com/u/290907?v=3","gravatar_id":"","url":"https://api.github.com/users/vadimtk","html_url":"https://github.com/vadimtk","followers_url":"https://api.github.com/users/vadimtk/followers","following_url":"https://api.github.com/users/vadimtk/following{/other_user}","gists_url":"https://api.github.com/users/vadimtk/gists{/gist_id}","starred_url":"https://api.github.com/users/vadimtk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadimtk/subscriptions","organizations_url":"https://api.github.com/users/vadimtk/orgs","repos_url":"https://api.github.com/users/vadimtk/repos","events_url":"https://api.github.com/users/vadimtk/events{/privacy}","received_events_url":"https://api.github.com/users/vadimtk/received_events","type":"User","site_admin":false},"body":"what about cxxflags ?","created_at":"2015-08-25T14:10:32Z","updated_at":"2015-08-25T14:10:32Z","html_url":"https://github.com/percona/PerconaFT/pull/312#discussion_r37868937","pull_request_url":"https://api.github.com/repos/percona/PerconaFT/pulls/312","_links":{"self":{"href":"https://api.github.com/repos/percona/PerconaFT/pulls/comments/37868937"},"html":{"href":"https://github.com/percona/PerconaFT/pull/312#discussion_r37868937"},"pull_request":{"href":"https://api.github.com/repos/percona/PerconaFT/pulls/312"}}},"pull_request":{"url":"https://api.github.com/repos/percona/PerconaFT/pulls/312","id":43279364,"html_url":"https://github.com/percona/PerconaFT/pull/312","diff_url":"https://github.com/percona/PerconaFT/pull/312.diff","patch_url":"https://github.com/percona/PerconaFT/pull/312.patch","issue_url":"https://api.github.com/repos/percona/PerconaFT/issues/312","number":312,"state":"closed","locked":false,"title":"added profiling option to allow profiling/debug. Jira ticket BLD-300","user":{"login":"abychko","id":1659715,"avatar_url":"https://avatars.githubusercontent.com/u/1659715?v=3","gravatar_id":"","url":"https://api.github.com/users/abychko","html_url":"https://github.com/abychko","followers_url":"https://api.github.com/users/abychko/followers","following_url":"https://api.github.com/users/abychko/following{/other_user}","gists_url":"https://api.github.com/users/abychko/gists{/gist_id}","starred_url":"https://api.github.com/users/abychko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abychko/subscriptions","organizations_url":"https://api.github.com/users/abychko/orgs","repos_url":"https://api.github.com/users/abychko/repos","events_url":"https://api.github.com/users/abychko/events{/privacy}","received_events_url":"https://api.github.com/users/abychko/received_events","type":"User","site_admin":false},"body":"[+] new option for cmake (-DPROFILING)\r\n[+] added -fno-omit-frame-pointer by request from Vadim and turned it on only if -DPROFILING is set\r\n\r\ntested 3 times to make sure it works:\r\n1) without -DPROFILING. result - -fno-omit-frame-pointer is not set\r\n2) with -DPROFILING=on. result - -fno-omit-frame-pointer is set\r\n3) with -DPROFILING=off. result - -fno-omit-frame-pointer is not set","created_at":"2015-08-25T12:27:46Z","updated_at":"2015-08-25T14:10:32Z","closed_at":"2015-08-25T14:09:42Z","merged_at":"2015-08-25T14:09:42Z","merge_commit_sha":"b0bdb5fe4f2b6de14495e2e596b5cab6e0261116","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/percona/PerconaFT/pulls/312/commits","review_comments_url":"https://api.github.com/repos/percona/PerconaFT/pulls/312/comments","review_comment_url":"https://api.github.com/repos/percona/PerconaFT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/percona/PerconaFT/issues/312/comments","statuses_url":"https://api.github.com/repos/percona/PerconaFT/statuses/76b10122fab12ddf379a9d3a0c0d81c07bdc2378","head":{"label":"abychko:master","ref":"master","sha":"76b10122fab12ddf379a9d3a0c0d81c07bdc2378","user":{"login":"abychko","id":1659715,"avatar_url":"https://avatars.githubusercontent.com/u/1659715?v=3","gravatar_id":"","url":"https://api.github.com/users/abychko","html_url":"https://github.com/abychko","followers_url":"https://api.github.com/users/abychko/followers","following_url":"https://api.github.com/users/abychko/following{/other_user}","gists_url":"https://api.github.com/users/abychko/gists{/gist_id}","starred_url":"https://api.github.com/users/abychko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abychko/subscriptions","organizations_url":"https://api.github.com/users/abychko/orgs","repos_url":"https://api.github.com/users/abychko/repos","events_url":"https://api.github.com/users/abychko/events{/privacy}","received_events_url":"https://api.github.com/users/abychko/received_events","type":"User","site_admin":false},"repo":{"id":41359232,"name":"PerconaFT","full_name":"abychko/PerconaFT","owner":{"login":"abychko","id":1659715,"avatar_url":"https://avatars.githubusercontent.com/u/1659715?v=3","gravatar_id":"","url":"https://api.github.com/users/abychko","html_url":"https://github.com/abychko","followers_url":"https://api.github.com/users/abychko/followers","following_url":"https://api.github.com/users/abychko/following{/other_user}","gists_url":"https://api.github.com/users/abychko/gists{/gist_id}","starred_url":"https://api.github.com/users/abychko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abychko/subscriptions","organizations_url":"https://api.github.com/users/abychko/orgs","repos_url":"https://api.github.com/users/abychko/repos","events_url":"https://api.github.com/users/abychko/events{/privacy}","received_events_url":"https://api.github.com/users/abychko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abychko/PerconaFT","description":"PerconaFT is a high-performance, transactional key-value store","fork":true,"url":"https://api.github.com/repos/abychko/PerconaFT","forks_url":"https://api.github.com/repos/abychko/PerconaFT/forks","keys_url":"https://api.github.com/repos/abychko/PerconaFT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abychko/PerconaFT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abychko/PerconaFT/teams","hooks_url":"https://api.github.com/repos/abychko/PerconaFT/hooks","issue_events_url":"https://api.github.com/repos/abychko/PerconaFT/issues/events{/number}","events_url":"https://api.github.com/repos/abychko/PerconaFT/events","assignees_url":"https://api.github.com/repos/abychko/PerconaFT/assignees{/user}","branches_url":"https://api.github.com/repos/abychko/PerconaFT/branches{/branch}","tags_url":"https://api.github.com/repos/abychko/PerconaFT/tags","blobs_url":"https://api.github.com/repos/abychko/PerconaFT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abychko/PerconaFT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abychko/PerconaFT/git/refs{/sha}","trees_url":"https://api.github.com/repos/abychko/PerconaFT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abychko/PerconaFT/statuses/{sha}","languages_url":"https://api.github.com/repos/abychko/PerconaFT/languages","stargazers_url":"https://api.github.com/repos/abychko/PerconaFT/stargazers","contributors_url":"https://api.github.com/repos/abychko/PerconaFT/contributors","subscribers_url":"https://api.github.com/repos/abychko/PerconaFT/subscribers","subscription_url":"https://api.github.com/repos/abychko/PerconaFT/subscription","commits_url":"https://api.github.com/repos/abychko/PerconaFT/commits{/sha}","git_commits_url":"https://api.github.com/repos/abychko/PerconaFT/git/commits{/sha}","comments_url":"https://api.github.com/repos/abychko/PerconaFT/comments{/number}","issue_comment_url":"https://api.github.com/repos/abychko/PerconaFT/issues/comments{/number}","contents_url":"https://api.github.com/repos/abychko/PerconaFT/contents/{+path}","compare_url":"https://api.github.com/repos/abychko/PerconaFT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abychko/PerconaFT/merges","archive_url":"https://api.github.com/repos/abychko/PerconaFT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abychko/PerconaFT/downloads","issues_url":"https://api.github.com/repos/abychko/PerconaFT/issues{/number}","pulls_url":"https://api.github.com/repos/abychko/PerconaFT/pulls{/number}","milestones_url":"https://api.github.com/repos/abychko/PerconaFT/milestones{/number}","notifications_url":"https://api.github.com/repos/abychko/PerconaFT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abychko/PerconaFT/labels{/name}","releases_url":"https://api.github.com/repos/abychko/PerconaFT/releases{/id}","created_at":"2015-08-25T11:17:20Z","updated_at":"2015-08-25T11:17:24Z","pushed_at":"2015-08-25T13:37:34Z","git_url":"git://github.com/abychko/PerconaFT.git","ssh_url":"git@github.com:abychko/PerconaFT.git","clone_url":"https://github.com/abychko/PerconaFT.git","svn_url":"https://github.com/abychko/PerconaFT","homepage":"http://www.percona.com/","size":50380,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"percona:master","ref":"master","sha":"8b5d0ed30c7d047b7542e25b07297f3f21dff235","user":{"login":"percona","id":1683025,"avatar_url":"https://avatars.githubusercontent.com/u/1683025?v=3","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"repo":{"id":9465623,"name":"PerconaFT","full_name":"percona/PerconaFT","owner":{"login":"percona","id":1683025,"avatar_url":"https://avatars.githubusercontent.com/u/1683025?v=3","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/percona/PerconaFT","description":"PerconaFT is a high-performance, transactional key-value store","fork":false,"url":"https://api.github.com/repos/percona/PerconaFT","forks_url":"https://api.github.com/repos/percona/PerconaFT/forks","keys_url":"https://api.github.com/repos/percona/PerconaFT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/percona/PerconaFT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/percona/PerconaFT/teams","hooks_url":"https://api.github.com/repos/percona/PerconaFT/hooks","issue_events_url":"https://api.github.com/repos/percona/PerconaFT/issues/events{/number}","events_url":"https://api.github.com/repos/percona/PerconaFT/events","assignees_url":"https://api.github.com/repos/percona/PerconaFT/assignees{/user}","branches_url":"https://api.github.com/repos/percona/PerconaFT/branches{/branch}","tags_url":"https://api.github.com/repos/percona/PerconaFT/tags","blobs_url":"https://api.github.com/repos/percona/PerconaFT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/percona/PerconaFT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/percona/PerconaFT/git/refs{/sha}","trees_url":"https://api.github.com/repos/percona/PerconaFT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/percona/PerconaFT/statuses/{sha}","languages_url":"https://api.github.com/repos/percona/PerconaFT/languages","stargazers_url":"https://api.github.com/repos/percona/PerconaFT/stargazers","contributors_url":"https://api.github.com/repos/percona/PerconaFT/contributors","subscribers_url":"https://api.github.com/repos/percona/PerconaFT/subscribers","subscription_url":"https://api.github.com/repos/percona/PerconaFT/subscription","commits_url":"https://api.github.com/repos/percona/PerconaFT/commits{/sha}","git_commits_url":"https://api.github.com/repos/percona/PerconaFT/git/commits{/sha}","comments_url":"https://api.github.com/repos/percona/PerconaFT/comments{/number}","issue_comment_url":"https://api.github.com/repos/percona/PerconaFT/issues/comments{/number}","contents_url":"https://api.github.com/repos/percona/PerconaFT/contents/{+path}","compare_url":"https://api.github.com/repos/percona/PerconaFT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/percona/PerconaFT/merges","archive_url":"https://api.github.com/repos/percona/PerconaFT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/percona/PerconaFT/downloads","issues_url":"https://api.github.com/repos/percona/PerconaFT/issues{/number}","pulls_url":"https://api.github.com/repos/percona/PerconaFT/pulls{/number}","milestones_url":"https://api.github.com/repos/percona/PerconaFT/milestones{/number}","notifications_url":"https://api.github.com/repos/percona/PerconaFT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/percona/PerconaFT/labels{/name}","releases_url":"https://api.github.com/repos/percona/PerconaFT/releases{/id}","created_at":"2013-04-16T06:14:08Z","updated_at":"2015-08-24T11:49:58Z","pushed_at":"2015-08-25T14:09:42Z","git_url":"git://github.com/percona/PerconaFT.git","ssh_url":"git@github.com:percona/PerconaFT.git","clone_url":"https://github.com/percona/PerconaFT.git","svn_url":"https://github.com/percona/PerconaFT","homepage":"http://www.percona.com/","size":50380,"stargazers_count":324,"watchers_count":324,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":62,"mirror_url":null,"open_issues_count":8,"forks":62,"open_issues":8,"watchers":324,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/percona/PerconaFT/pulls/312"},"html":{"href":"https://github.com/percona/PerconaFT/pull/312"},"issue":{"href":"https://api.github.com/repos/percona/PerconaFT/issues/312"},"comments":{"href":"https://api.github.com/repos/percona/PerconaFT/issues/312/comments"},"review_comments":{"href":"https://api.github.com/repos/percona/PerconaFT/pulls/312/comments"},"review_comment":{"href":"https://api.github.com/repos/percona/PerconaFT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/percona/PerconaFT/pulls/312/commits"},"statuses":{"href":"https://api.github.com/repos/percona/PerconaFT/statuses/76b10122fab12ddf379a9d3a0c0d81c07bdc2378"}}}}