{"action":"closed","number":6,"pull_request":{"url":"https://api.github.com/repos/pbsag/tcadr/pulls/6","id":44166964,"html_url":"https://github.com/pbsag/tcadr/pull/6","diff_url":"https://github.com/pbsag/tcadr/pull/6.diff","patch_url":"https://github.com/pbsag/tcadr/pull/6.patch","issue_url":"https://api.github.com/repos/pbsag/tcadr/issues/6","number":6,"state":"closed","locked":false,"title":"Handle optional fields to dcb input file.","user":{"login":"gregmacfarlane","id":2234830,"avatar_url":"https://avatars.githubusercontent.com/u/2234830?v=3","gravatar_id":"","url":"https://api.github.com/users/gregmacfarlane","html_url":"https://github.com/gregmacfarlane","followers_url":"https://api.github.com/users/gregmacfarlane/followers","following_url":"https://api.github.com/users/gregmacfarlane/following{/other_user}","gists_url":"https://api.github.com/users/gregmacfarlane/gists{/gist_id}","starred_url":"https://api.github.com/users/gregmacfarlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregmacfarlane/subscriptions","organizations_url":"https://api.github.com/users/gregmacfarlane/orgs","repos_url":"https://api.github.com/users/gregmacfarlane/repos","events_url":"https://api.github.com/users/gregmacfarlane/events{/privacy}","received_events_url":"https://api.github.com/users/gregmacfarlane/received_events","type":"User","site_admin":false},"body":"Apparently (see #5), not all of the fields on the TransCAD dcb are mandatory. This can cause a failure if a particular bin is missing some of the fields. \r\n\r\nWe may need to test and see what happens if one of the fields is missing but another is not. But for now, it seems that none of the optional fields are passed on to `get_df_from_binary()`.","created_at":"2015-09-03T22:50:48Z","updated_at":"2015-09-24T20:28:47Z","closed_at":"2015-09-24T20:28:47Z","merged_at":null,"merge_commit_sha":"6b27b9cc305c487f84abbcd1fa0bb658b803f70c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pbsag/tcadr/pulls/6/commits","review_comments_url":"https://api.github.com/repos/pbsag/tcadr/pulls/6/comments","review_comment_url":"https://api.github.com/repos/pbsag/tcadr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pbsag/tcadr/issues/6/comments","statuses_url":"https://api.github.com/repos/pbsag/tcadr/statuses/6ec1ac7c73c1953d66d79bfdcb719924c052fed0","head":{"label":"pbsag:gregmacfarlane-patch-1","ref":"gregmacfarlane-patch-1","sha":"6ec1ac7c73c1953d66d79bfdcb719924c052fed0","user":{"login":"pbsag","id":13039573,"avatar_url":"https://avatars.githubusercontent.com/u/13039573?v=3","gravatar_id":"","url":"https://api.github.com/users/pbsag","html_url":"https://github.com/pbsag","followers_url":"https://api.github.com/users/pbsag/followers","following_url":"https://api.github.com/users/pbsag/following{/other_user}","gists_url":"https://api.github.com/users/pbsag/gists{/gist_id}","starred_url":"https://api.github.com/users/pbsag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbsag/subscriptions","organizations_url":"https://api.github.com/users/pbsag/orgs","repos_url":"https://api.github.com/users/pbsag/repos","events_url":"https://api.github.com/users/pbsag/events{/privacy}","received_events_url":"https://api.github.com/users/pbsag/received_events","type":"Organization","site_admin":false},"repo":{"id":33955610,"name":"tcadr","full_name":"pbsag/tcadr","owner":{"login":"pbsag","id":13039573,"avatar_url":"https://avatars.githubusercontent.com/u/13039573?v=3","gravatar_id":"","url":"https://api.github.com/users/pbsag","html_url":"https://github.com/pbsag","followers_url":"https://api.github.com/users/pbsag/followers","following_url":"https://api.github.com/users/pbsag/following{/other_user}","gists_url":"https://api.github.com/users/pbsag/gists{/gist_id}","starred_url":"https://api.github.com/users/pbsag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbsag/subscriptions","organizations_url":"https://api.github.com/users/pbsag/orgs","repos_url":"https://api.github.com/users/pbsag/repos","events_url":"https://api.github.com/users/pbsag/events{/privacy}","received_events_url":"https://api.github.com/users/pbsag/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pbsag/tcadr","description":"A library to read TransCAD data files in R.","fork":false,"url":"https://api.github.com/repos/pbsag/tcadr","forks_url":"https://api.github.com/repos/pbsag/tcadr/forks","keys_url":"https://api.github.com/repos/pbsag/tcadr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pbsag/tcadr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pbsag/tcadr/teams","hooks_url":"https://api.github.com/repos/pbsag/tcadr/hooks","issue_events_url":"https://api.github.com/repos/pbsag/tcadr/issues/events{/number}","events_url":"https://api.github.com/repos/pbsag/tcadr/events","assignees_url":"https://api.github.com/repos/pbsag/tcadr/assignees{/user}","branches_url":"https://api.github.com/repos/pbsag/tcadr/branches{/branch}","tags_url":"https://api.github.com/repos/pbsag/tcadr/tags","blobs_url":"https://api.github.com/repos/pbsag/tcadr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pbsag/tcadr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pbsag/tcadr/git/refs{/sha}","trees_url":"https://api.github.com/repos/pbsag/tcadr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pbsag/tcadr/statuses/{sha}","languages_url":"https://api.github.com/repos/pbsag/tcadr/languages","stargazers_url":"https://api.github.com/repos/pbsag/tcadr/stargazers","contributors_url":"https://api.github.com/repos/pbsag/tcadr/contributors","subscribers_url":"https://api.github.com/repos/pbsag/tcadr/subscribers","subscription_url":"https://api.github.com/repos/pbsag/tcadr/subscription","commits_url":"https://api.github.com/repos/pbsag/tcadr/commits{/sha}","git_commits_url":"https://api.github.com/repos/pbsag/tcadr/git/commits{/sha}","comments_url":"https://api.github.com/repos/pbsag/tcadr/comments{/number}","issue_comment_url":"https://api.github.com/repos/pbsag/tcadr/issues/comments{/number}","contents_url":"https://api.github.com/repos/pbsag/tcadr/contents/{+path}","compare_url":"https://api.github.com/repos/pbsag/tcadr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pbsag/tcadr/merges","archive_url":"https://api.github.com/repos/pbsag/tcadr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pbsag/tcadr/downloads","issues_url":"https://api.github.com/repos/pbsag/tcadr/issues{/number}","pulls_url":"https://api.github.com/repos/pbsag/tcadr/pulls{/number}","milestones_url":"https://api.github.com/repos/pbsag/tcadr/milestones{/number}","notifications_url":"https://api.github.com/repos/pbsag/tcadr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pbsag/tcadr/labels{/name}","releases_url":"https://api.github.com/repos/pbsag/tcadr/releases{/id}","created_at":"2015-04-14T20:34:08Z","updated_at":"2015-06-30T12:14:59Z","pushed_at":"2015-09-24T20:28:47Z","git_url":"git://github.com/pbsag/tcadr.git","ssh_url":"git@github.com:pbsag/tcadr.git","clone_url":"https://github.com/pbsag/tcadr.git","svn_url":"https://github.com/pbsag/tcadr","homepage":"","size":299,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":6,"forks":1,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"pbsag:master","ref":"master","sha":"718a65cdded69a3f49b8b003887fdada0e53daec","user":{"login":"pbsag","id":13039573,"avatar_url":"https://avatars.githubusercontent.com/u/13039573?v=3","gravatar_id":"","url":"https://api.github.com/users/pbsag","html_url":"https://github.com/pbsag","followers_url":"https://api.github.com/users/pbsag/followers","following_url":"https://api.github.com/users/pbsag/following{/other_user}","gists_url":"https://api.github.com/users/pbsag/gists{/gist_id}","starred_url":"https://api.github.com/users/pbsag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbsag/subscriptions","organizations_url":"https://api.github.com/users/pbsag/orgs","repos_url":"https://api.github.com/users/pbsag/repos","events_url":"https://api.github.com/users/pbsag/events{/privacy}","received_events_url":"https://api.github.com/users/pbsag/received_events","type":"Organization","site_admin":false},"repo":{"id":33955610,"name":"tcadr","full_name":"pbsag/tcadr","owner":{"login":"pbsag","id":13039573,"avatar_url":"https://avatars.githubusercontent.com/u/13039573?v=3","gravatar_id":"","url":"https://api.github.com/users/pbsag","html_url":"https://github.com/pbsag","followers_url":"https://api.github.com/users/pbsag/followers","following_url":"https://api.github.com/users/pbsag/following{/other_user}","gists_url":"https://api.github.com/users/pbsag/gists{/gist_id}","starred_url":"https://api.github.com/users/pbsag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbsag/subscriptions","organizations_url":"https://api.github.com/users/pbsag/orgs","repos_url":"https://api.github.com/users/pbsag/repos","events_url":"https://api.github.com/users/pbsag/events{/privacy}","received_events_url":"https://api.github.com/users/pbsag/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pbsag/tcadr","description":"A library to read TransCAD data files in R.","fork":false,"url":"https://api.github.com/repos/pbsag/tcadr","forks_url":"https://api.github.com/repos/pbsag/tcadr/forks","keys_url":"https://api.github.com/repos/pbsag/tcadr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pbsag/tcadr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pbsag/tcadr/teams","hooks_url":"https://api.github.com/repos/pbsag/tcadr/hooks","issue_events_url":"https://api.github.com/repos/pbsag/tcadr/issues/events{/number}","events_url":"https://api.github.com/repos/pbsag/tcadr/events","assignees_url":"https://api.github.com/repos/pbsag/tcadr/assignees{/user}","branches_url":"https://api.github.com/repos/pbsag/tcadr/branches{/branch}","tags_url":"https://api.github.com/repos/pbsag/tcadr/tags","blobs_url":"https://api.github.com/repos/pbsag/tcadr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pbsag/tcadr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pbsag/tcadr/git/refs{/sha}","trees_url":"https://api.github.com/repos/pbsag/tcadr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pbsag/tcadr/statuses/{sha}","languages_url":"https://api.github.com/repos/pbsag/tcadr/languages","stargazers_url":"https://api.github.com/repos/pbsag/tcadr/stargazers","contributors_url":"https://api.github.com/repos/pbsag/tcadr/contributors","subscribers_url":"https://api.github.com/repos/pbsag/tcadr/subscribers","subscription_url":"https://api.github.com/repos/pbsag/tcadr/subscription","commits_url":"https://api.github.com/repos/pbsag/tcadr/commits{/sha}","git_commits_url":"https://api.github.com/repos/pbsag/tcadr/git/commits{/sha}","comments_url":"https://api.github.com/repos/pbsag/tcadr/comments{/number}","issue_comment_url":"https://api.github.com/repos/pbsag/tcadr/issues/comments{/number}","contents_url":"https://api.github.com/repos/pbsag/tcadr/contents/{+path}","compare_url":"https://api.github.com/repos/pbsag/tcadr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pbsag/tcadr/merges","archive_url":"https://api.github.com/repos/pbsag/tcadr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pbsag/tcadr/downloads","issues_url":"https://api.github.com/repos/pbsag/tcadr/issues{/number}","pulls_url":"https://api.github.com/repos/pbsag/tcadr/pulls{/number}","milestones_url":"https://api.github.com/repos/pbsag/tcadr/milestones{/number}","notifications_url":"https://api.github.com/repos/pbsag/tcadr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pbsag/tcadr/labels{/name}","releases_url":"https://api.github.com/repos/pbsag/tcadr/releases{/id}","created_at":"2015-04-14T20:34:08Z","updated_at":"2015-06-30T12:14:59Z","pushed_at":"2015-09-24T20:28:47Z","git_url":"git://github.com/pbsag/tcadr.git","ssh_url":"git@github.com:pbsag/tcadr.git","clone_url":"https://github.com/pbsag/tcadr.git","svn_url":"https://github.com/pbsag/tcadr","homepage":"","size":299,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":6,"forks":1,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pbsag/tcadr/pulls/6"},"html":{"href":"https://github.com/pbsag/tcadr/pull/6"},"issue":{"href":"https://api.github.com/repos/pbsag/tcadr/issues/6"},"comments":{"href":"https://api.github.com/repos/pbsag/tcadr/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/pbsag/tcadr/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/pbsag/tcadr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pbsag/tcadr/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/pbsag/tcadr/statuses/6ec1ac7c73c1953d66d79bfdcb719924c052fed0"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":4,"additions":19,"deletions":18,"changed_files":4}}