{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4309","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4309/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4309/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4309/events","html_url":"https://github.com/scikit-learn/scikit-learn/pull/4309","id":59393534,"number":4309,"title":"[MRG+3] move NotFittedError to sklearn.base","user":{"login":"larsmans","id":335383,"avatar_url":"https://avatars.githubusercontent.com/u/335383?v=3","gravatar_id":"","url":"https://api.github.com/users/larsmans","html_url":"https://github.com/larsmans","followers_url":"https://api.github.com/users/larsmans/followers","following_url":"https://api.github.com/users/larsmans/following{/other_user}","gists_url":"https://api.github.com/users/larsmans/gists{/gist_id}","starred_url":"https://api.github.com/users/larsmans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsmans/subscriptions","organizations_url":"https://api.github.com/users/larsmans/orgs","repos_url":"https://api.github.com/users/larsmans/repos","events_url":"https://api.github.com/users/larsmans/events{/privacy}","received_events_url":"https://api.github.com/users/larsmans/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":24,"created_at":"2015-03-01T12:05:22Z","updated_at":"2015-10-20T09:26:50Z","closed_at":"2015-10-20T09:26:50Z","pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4309","html_url":"https://github.com/scikit-learn/scikit-learn/pull/4309","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/4309.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/4309.patch"},"body":"This moves the recently added `NotFittedError` to `sklearn.base` so user code that wants to catch it does not have to import it from `sklearn.utils.validation`. I'm not sure if we've made a decision regarding the public status of (parts of) `sklearn.utils` yet, but in any case, an exception that is thrown at the user is a public thing, and it is not a utility.\r\n\r\nPing @ogrisel."},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/149491613","html_url":"https://github.com/scikit-learn/scikit-learn/pull/4309#issuecomment-149491613","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4309","id":149491613,"user":{"login":"glouppe","id":477771,"avatar_url":"https://avatars.githubusercontent.com/u/477771?v=3","gravatar_id":"","url":"https://api.github.com/users/glouppe","html_url":"https://github.com/glouppe","followers_url":"https://api.github.com/users/glouppe/followers","following_url":"https://api.github.com/users/glouppe/following{/other_user}","gists_url":"https://api.github.com/users/glouppe/gists{/gist_id}","starred_url":"https://api.github.com/users/glouppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glouppe/subscriptions","organizations_url":"https://api.github.com/users/glouppe/orgs","repos_url":"https://api.github.com/users/glouppe/repos","events_url":"https://api.github.com/users/glouppe/events{/privacy}","received_events_url":"https://api.github.com/users/glouppe/received_events","type":"User","site_admin":false},"created_at":"2015-10-20T09:26:50Z","updated_at":"2015-10-20T09:26:50Z","body":"This can be closed, as #4826 has been merged. "}}