{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/14021","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/14021/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/14021/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/14021/events","html_url":"https://github.com/mantidproject/mantid/issues/14021","id":111813714,"number":14021,"title":"Upgrade Find Reflectometry Lines","user":{"login":"OwenArnold","id":1109536,"avatar_url":"https://avatars.githubusercontent.com/u/1109536?v=3","gravatar_id":"","url":"https://api.github.com/users/OwenArnold","html_url":"https://github.com/OwenArnold","followers_url":"https://api.github.com/users/OwenArnold/followers","following_url":"https://api.github.com/users/OwenArnold/following{/other_user}","gists_url":"https://api.github.com/users/OwenArnold/gists{/gist_id}","starred_url":"https://api.github.com/users/OwenArnold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OwenArnold/subscriptions","organizations_url":"https://api.github.com/users/OwenArnold/orgs","repos_url":"https://api.github.com/users/OwenArnold/repos","events_url":"https://api.github.com/users/OwenArnold/events{/privacy}","received_events_url":"https://api.github.com/users/OwenArnold/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Reflectometry","name":"Component: Reflectometry","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"OwenArnold","id":1109536,"avatar_url":"https://avatars.githubusercontent.com/u/1109536?v=3","gravatar_id":"","url":"https://api.github.com/users/OwenArnold","html_url":"https://github.com/OwenArnold","followers_url":"https://api.github.com/users/OwenArnold/followers","following_url":"https://api.github.com/users/OwenArnold/following{/other_user}","gists_url":"https://api.github.com/users/OwenArnold/gists{/gist_id}","starred_url":"https://api.github.com/users/OwenArnold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OwenArnold/subscriptions","organizations_url":"https://api.github.com/users/OwenArnold/orgs","repos_url":"https://api.github.com/users/OwenArnold/repos","events_url":"https://api.github.com/users/OwenArnold/events{/privacy}","received_events_url":"https://api.github.com/users/OwenArnold/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/4","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.6","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/4/labels","id":1106937,"number":4,"title":"Release 3.6","description":"","creator":{"login":"peterfpeterson","id":404003,"avatar_url":"https://avatars.githubusercontent.com/u/404003?v=3","gravatar_id":"","url":"https://api.github.com/users/peterfpeterson","html_url":"https://github.com/peterfpeterson","followers_url":"https://api.github.com/users/peterfpeterson/followers","following_url":"https://api.github.com/users/peterfpeterson/following{/other_user}","gists_url":"https://api.github.com/users/peterfpeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/peterfpeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterfpeterson/subscriptions","organizations_url":"https://api.github.com/users/peterfpeterson/orgs","repos_url":"https://api.github.com/users/peterfpeterson/repos","events_url":"https://api.github.com/users/peterfpeterson/events{/privacy}","received_events_url":"https://api.github.com/users/peterfpeterson/received_events","type":"User","site_admin":false},"open_issues":584,"closed_issues":606,"state":"open","created_at":"2015-05-12T15:36:23Z","updated_at":"2015-11-19T17:16:17Z","due_on":"2016-01-30T05:00:00Z","closed_at":null},"comments":2,"created_at":"2015-10-16T11:36:41Z","updated_at":"2015-11-19T17:29:54Z","closed_at":null,"body":"I suspect FindReflectometryLines that this algorithm is not being heavily used. So I suggest Deprecating it.\r\n\r\nWe need a new version, primarily aimed at OFFSPEC. This should be version 2, if the name above is kept, but a better name might could be used.\r\n\r\n* Find Two maxima in the same ways as done before.\r\n* Use the geometry setup to predict which line is going to be the Specular. Corresponds to having the same ThetaF as ThetaI. \r\n* Determine the width of each peak at the 0.5 max intensity of each peak.\r\n* Return the SpectrumNumber, WorkspaceIndex, and width information for each Peak so that it can be fed into `RefectometryReductionOne` as `ProcessingInstructions` and `DirectBeamRegion`."},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/158128603","html_url":"https://github.com/mantidproject/mantid/issues/14021#issuecomment-158128603","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/14021","id":158128603,"user":{"login":"OwenArnold","id":1109536,"avatar_url":"https://avatars.githubusercontent.com/u/1109536?v=3","gravatar_id":"","url":"https://api.github.com/users/OwenArnold","html_url":"https://github.com/OwenArnold","followers_url":"https://api.github.com/users/OwenArnold/followers","following_url":"https://api.github.com/users/OwenArnold/following{/other_user}","gists_url":"https://api.github.com/users/OwenArnold/gists{/gist_id}","starred_url":"https://api.github.com/users/OwenArnold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OwenArnold/subscriptions","organizations_url":"https://api.github.com/users/OwenArnold/orgs","repos_url":"https://api.github.com/users/OwenArnold/repos","events_url":"https://api.github.com/users/OwenArnold/events{/privacy}","received_events_url":"https://api.github.com/users/OwenArnold/received_events","type":"User","site_admin":false},"created_at":"2015-11-19T17:29:53Z","updated_at":"2015-11-19T17:29:53Z","body":"Proposed solution.\r\n\r\nNew algorithm called `PredictSpecular`.\r\n\r\nDoes the following:\r\n\r\n* Crops workspace to StartWavelength, EndWavelength range\r\n* Integrates over the full range\r\n* Transposes the workspace so that we have a single array\r\n* Records everything looking like a peak, but then discards all but the 3-most intense\r\n* Loops over each peak and calculates \r\n\r\n"}}