{"action":"created","comment":{"url":"https://api.github.com/repos/soundcloud/ua-parser/pulls/comments/37292366","id":37292366,"diff_hunk":"@@ -1,12 +1,21 @@\n package main\n \n import (\n-\t\"../uaparser\" // You could change this to a github repo as well\n \t\"fmt\"\n+\t\"io/ioutil\"\n+\t\"os\" // You could change this to a github repo as well\n+\n+\t\"../uaparser\"\n )\n \n func main() {\n-\ttestStr := \"Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_3; en-us; Silk/1.1.0-80) AppleWebKit/533.16 (KHTML, like Gecko) Version/5.0 Safari/533.16 Silk-Accelerated=true\"\n+\ttestBytes, err := ioutil.ReadAll(os.Stdin)","path":"go/example/example.go","position":14,"original_position":14,"commit_id":"82ee265bb0a520e0833dfa0df66d605f63767047","original_commit_id":"82ee265bb0a520e0833dfa0df66d605f63767047","user":{"login":"ellenkoenig","id":1550201,"avatar_url":"https://avatars.githubusercontent.com/u/1550201?v=3","gravatar_id":"","url":"https://api.github.com/users/ellenkoenig","html_url":"https://github.com/ellenkoenig","followers_url":"https://api.github.com/users/ellenkoenig/followers","following_url":"https://api.github.com/users/ellenkoenig/following{/other_user}","gists_url":"https://api.github.com/users/ellenkoenig/gists{/gist_id}","starred_url":"https://api.github.com/users/ellenkoenig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ellenkoenig/subscriptions","organizations_url":"https://api.github.com/users/ellenkoenig/orgs","repos_url":"https://api.github.com/users/ellenkoenig/repos","events_url":"https://api.github.com/users/ellenkoenig/events{/privacy}","received_events_url":"https://api.github.com/users/ellenkoenig/received_events","type":"User","site_admin":false},"body":"Then maybe it should be reverted before merging?","created_at":"2015-08-18T12:32:54Z","updated_at":"2015-08-18T12:32:54Z","html_url":"https://github.com/soundcloud/ua-parser/pull/1#discussion_r37292366","pull_request_url":"https://api.github.com/repos/soundcloud/ua-parser/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/soundcloud/ua-parser/pulls/comments/37292366"},"html":{"href":"https://github.com/soundcloud/ua-parser/pull/1#discussion_r37292366"},"pull_request":{"href":"https://api.github.com/repos/soundcloud/ua-parser/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/soundcloud/ua-parser/pulls/1","id":37810299,"html_url":"https://github.com/soundcloud/ua-parser/pull/1","diff_url":"https://github.com/soundcloud/ua-parser/pull/1.diff","patch_url":"https://github.com/soundcloud/ua-parser/pull/1.patch","issue_url":"https://api.github.com/repos/soundcloud/ua-parser/issues/1","number":1,"state":"open","locked":false,"title":"ua_device regex better samsung support","user":{"login":"andreadipersio","id":1267841,"avatar_url":"https://avatars.githubusercontent.com/u/1267841?v=3","gravatar_id":"","url":"https://api.github.com/users/andreadipersio","html_url":"https://github.com/andreadipersio","followers_url":"https://api.github.com/users/andreadipersio/followers","following_url":"https://api.github.com/users/andreadipersio/following{/other_user}","gists_url":"https://api.github.com/users/andreadipersio/gists{/gist_id}","starred_url":"https://api.github.com/users/andreadipersio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreadipersio/subscriptions","organizations_url":"https://api.github.com/users/andreadipersio/orgs","repos_url":"https://api.github.com/users/andreadipersio/repos","events_url":"https://api.github.com/users/andreadipersio/events{/privacy}","received_events_url":"https://api.github.com/users/andreadipersio/received_events","type":"User","site_admin":false},"body":"The regexes are falling for a lot of samsung devices, where\r\nthe vendor name is lowercase.\r\n\r\nExample:\r\n```\r\nSoundCloud-Android/15.06.09-release (Android 5.0.1; samsung SM-N910P)\r\n```\r\n\r\nI am not familiar with java so I don't know how to actually test it, but I was able to reproduce it and fix it using the go version.","created_at":"2015-06-16T15:51:08Z","updated_at":"2015-08-18T12:32:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92e3688d9d8903287d9cd37530304cb1e62815e1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/soundcloud/ua-parser/pulls/1/commits","review_comments_url":"https://api.github.com/repos/soundcloud/ua-parser/pulls/1/comments","review_comment_url":"https://api.github.com/repos/soundcloud/ua-parser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/soundcloud/ua-parser/issues/1/comments","statuses_url":"https://api.github.com/repos/soundcloud/ua-parser/statuses/82ee265bb0a520e0833dfa0df66d605f63767047","head":{"label":"soundcloud:ua-device-regex","ref":"ua-device-regex","sha":"82ee265bb0a520e0833dfa0df66d605f63767047","user":{"login":"soundcloud","id":21021,"avatar_url":"https://avatars.githubusercontent.com/u/21021?v=3","gravatar_id":"","url":"https://api.github.com/users/soundcloud","html_url":"https://github.com/soundcloud","followers_url":"https://api.github.com/users/soundcloud/followers","following_url":"https://api.github.com/users/soundcloud/following{/other_user}","gists_url":"https://api.github.com/users/soundcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/soundcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soundcloud/subscriptions","organizations_url":"https://api.github.com/users/soundcloud/orgs","repos_url":"https://api.github.com/users/soundcloud/repos","events_url":"https://api.github.com/users/soundcloud/events{/privacy}","received_events_url":"https://api.github.com/users/soundcloud/received_events","type":"Organization","site_admin":false},"repo":{"id":21233415,"name":"ua-parser","full_name":"soundcloud/ua-parser","owner":{"login":"soundcloud","id":21021,"avatar_url":"https://avatars.githubusercontent.com/u/21021?v=3","gravatar_id":"","url":"https://api.github.com/users/soundcloud","html_url":"https://github.com/soundcloud","followers_url":"https://api.github.com/users/soundcloud/followers","following_url":"https://api.github.com/users/soundcloud/following{/other_user}","gists_url":"https://api.github.com/users/soundcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/soundcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soundcloud/subscriptions","organizations_url":"https://api.github.com/users/soundcloud/orgs","repos_url":"https://api.github.com/users/soundcloud/repos","events_url":"https://api.github.com/users/soundcloud/events{/privacy}","received_events_url":"https://api.github.com/users/soundcloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/soundcloud/ua-parser","description":"A multi-language port of Browserscope's user agent parser.","fork":true,"url":"https://api.github.com/repos/soundcloud/ua-parser","forks_url":"https://api.github.com/repos/soundcloud/ua-parser/forks","keys_url":"https://api.github.com/repos/soundcloud/ua-parser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/soundcloud/ua-parser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/soundcloud/ua-parser/teams","hooks_url":"https://api.github.com/repos/soundcloud/ua-parser/hooks","issue_events_url":"https://api.github.com/repos/soundcloud/ua-parser/issues/events{/number}","events_url":"https://api.github.com/repos/soundcloud/ua-parser/events","assignees_url":"https://api.github.com/repos/soundcloud/ua-parser/assignees{/user}","branches_url":"https://api.github.com/repos/soundcloud/ua-parser/branches{/branch}","tags_url":"https://api.github.com/repos/soundcloud/ua-parser/tags","blobs_url":"https://api.github.com/repos/soundcloud/ua-parser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/soundcloud/ua-parser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/soundcloud/ua-parser/git/refs{/sha}","trees_url":"https://api.github.com/repos/soundcloud/ua-parser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/soundcloud/ua-parser/statuses/{sha}","languages_url":"https://api.github.com/repos/soundcloud/ua-parser/languages","stargazers_url":"https://api.github.com/repos/soundcloud/ua-parser/stargazers","contributors_url":"https://api.github.com/repos/soundcloud/ua-parser/contributors","subscribers_url":"https://api.github.com/repos/soundcloud/ua-parser/subscribers","subscription_url":"https://api.github.com/repos/soundcloud/ua-parser/subscription","commits_url":"https://api.github.com/repos/soundcloud/ua-parser/commits{/sha}","git_commits_url":"https://api.github.com/repos/soundcloud/ua-parser/git/commits{/sha}","comments_url":"https://api.github.com/repos/soundcloud/ua-parser/comments{/number}","issue_comment_url":"https://api.github.com/repos/soundcloud/ua-parser/issues/comments{/number}","contents_url":"https://api.github.com/repos/soundcloud/ua-parser/contents/{+path}","compare_url":"https://api.github.com/repos/soundcloud/ua-parser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/soundcloud/ua-parser/merges","archive_url":"https://api.github.com/repos/soundcloud/ua-parser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/soundcloud/ua-parser/downloads","issues_url":"https://api.github.com/repos/soundcloud/ua-parser/issues{/number}","pulls_url":"https://api.github.com/repos/soundcloud/ua-parser/pulls{/number}","milestones_url":"https://api.github.com/repos/soundcloud/ua-parser/milestones{/number}","notifications_url":"https://api.github.com/repos/soundcloud/ua-parser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/soundcloud/ua-parser/labels{/name}","releases_url":"https://api.github.com/repos/soundcloud/ua-parser/releases{/id}","created_at":"2014-06-26T08:22:30Z","updated_at":"2015-08-05T10:40:49Z","pushed_at":"2015-06-16T15:51:08Z","git_url":"git://github.com/soundcloud/ua-parser.git","ssh_url":"git@github.com:soundcloud/ua-parser.git","clone_url":"https://github.com/soundcloud/ua-parser.git","svn_url":"https://github.com/soundcloud/ua-parser","homepage":"","size":3534,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"soundcloud:master","ref":"master","sha":"326bc24c838eabf396d135e65e9d0ad7b4c97b42","user":{"login":"soundcloud","id":21021,"avatar_url":"https://avatars.githubusercontent.com/u/21021?v=3","gravatar_id":"","url":"https://api.github.com/users/soundcloud","html_url":"https://github.com/soundcloud","followers_url":"https://api.github.com/users/soundcloud/followers","following_url":"https://api.github.com/users/soundcloud/following{/other_user}","gists_url":"https://api.github.com/users/soundcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/soundcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soundcloud/subscriptions","organizations_url":"https://api.github.com/users/soundcloud/orgs","repos_url":"https://api.github.com/users/soundcloud/repos","events_url":"https://api.github.com/users/soundcloud/events{/privacy}","received_events_url":"https://api.github.com/users/soundcloud/received_events","type":"Organization","site_admin":false},"repo":{"id":21233415,"name":"ua-parser","full_name":"soundcloud/ua-parser","owner":{"login":"soundcloud","id":21021,"avatar_url":"https://avatars.githubusercontent.com/u/21021?v=3","gravatar_id":"","url":"https://api.github.com/users/soundcloud","html_url":"https://github.com/soundcloud","followers_url":"https://api.github.com/users/soundcloud/followers","following_url":"https://api.github.com/users/soundcloud/following{/other_user}","gists_url":"https://api.github.com/users/soundcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/soundcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soundcloud/subscriptions","organizations_url":"https://api.github.com/users/soundcloud/orgs","repos_url":"https://api.github.com/users/soundcloud/repos","events_url":"https://api.github.com/users/soundcloud/events{/privacy}","received_events_url":"https://api.github.com/users/soundcloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/soundcloud/ua-parser","description":"A multi-language port of Browserscope's user agent parser.","fork":true,"url":"https://api.github.com/repos/soundcloud/ua-parser","forks_url":"https://api.github.com/repos/soundcloud/ua-parser/forks","keys_url":"https://api.github.com/repos/soundcloud/ua-parser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/soundcloud/ua-parser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/soundcloud/ua-parser/teams","hooks_url":"https://api.github.com/repos/soundcloud/ua-parser/hooks","issue_events_url":"https://api.github.com/repos/soundcloud/ua-parser/issues/events{/number}","events_url":"https://api.github.com/repos/soundcloud/ua-parser/events","assignees_url":"https://api.github.com/repos/soundcloud/ua-parser/assignees{/user}","branches_url":"https://api.github.com/repos/soundcloud/ua-parser/branches{/branch}","tags_url":"https://api.github.com/repos/soundcloud/ua-parser/tags","blobs_url":"https://api.github.com/repos/soundcloud/ua-parser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/soundcloud/ua-parser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/soundcloud/ua-parser/git/refs{/sha}","trees_url":"https://api.github.com/repos/soundcloud/ua-parser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/soundcloud/ua-parser/statuses/{sha}","languages_url":"https://api.github.com/repos/soundcloud/ua-parser/languages","stargazers_url":"https://api.github.com/repos/soundcloud/ua-parser/stargazers","contributors_url":"https://api.github.com/repos/soundcloud/ua-parser/contributors","subscribers_url":"https://api.github.com/repos/soundcloud/ua-parser/subscribers","subscription_url":"https://api.github.com/repos/soundcloud/ua-parser/subscription","commits_url":"https://api.github.com/repos/soundcloud/ua-parser/commits{/sha}","git_commits_url":"https://api.github.com/repos/soundcloud/ua-parser/git/commits{/sha}","comments_url":"https://api.github.com/repos/soundcloud/ua-parser/comments{/number}","issue_comment_url":"https://api.github.com/repos/soundcloud/ua-parser/issues/comments{/number}","contents_url":"https://api.github.com/repos/soundcloud/ua-parser/contents/{+path}","compare_url":"https://api.github.com/repos/soundcloud/ua-parser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/soundcloud/ua-parser/merges","archive_url":"https://api.github.com/repos/soundcloud/ua-parser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/soundcloud/ua-parser/downloads","issues_url":"https://api.github.com/repos/soundcloud/ua-parser/issues{/number}","pulls_url":"https://api.github.com/repos/soundcloud/ua-parser/pulls{/number}","milestones_url":"https://api.github.com/repos/soundcloud/ua-parser/milestones{/number}","notifications_url":"https://api.github.com/repos/soundcloud/ua-parser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/soundcloud/ua-parser/labels{/name}","releases_url":"https://api.github.com/repos/soundcloud/ua-parser/releases{/id}","created_at":"2014-06-26T08:22:30Z","updated_at":"2015-08-05T10:40:49Z","pushed_at":"2015-06-16T15:51:08Z","git_url":"git://github.com/soundcloud/ua-parser.git","ssh_url":"git@github.com:soundcloud/ua-parser.git","clone_url":"https://github.com/soundcloud/ua-parser.git","svn_url":"https://github.com/soundcloud/ua-parser","homepage":"","size":3534,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/soundcloud/ua-parser/pulls/1"},"html":{"href":"https://github.com/soundcloud/ua-parser/pull/1"},"issue":{"href":"https://api.github.com/repos/soundcloud/ua-parser/issues/1"},"comments":{"href":"https://api.github.com/repos/soundcloud/ua-parser/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/soundcloud/ua-parser/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/soundcloud/ua-parser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/soundcloud/ua-parser/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/soundcloud/ua-parser/statuses/82ee265bb0a520e0833dfa0df66d605f63767047"}}}}