{"action":"created","issue":{"url":"https://api.github.com/repos/symfony/symfony/issues/15056","labels_url":"https://api.github.com/repos/symfony/symfony/issues/15056/labels{/name}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/15056/comments","events_url":"https://api.github.com/repos/symfony/symfony/issues/15056/events","html_url":"https://github.com/symfony/symfony/pull/15056","id":89936258,"number":15056,"title":"[WIP][HttpKernel] render_esi should behave in dev as it does in prod","user":{"login":"bpaulin","id":115711,"avatar_url":"https://avatars.githubusercontent.com/u/115711?v=3","gravatar_id":"","url":"https://api.github.com/users/bpaulin","html_url":"https://github.com/bpaulin","followers_url":"https://api.github.com/users/bpaulin/followers","following_url":"https://api.github.com/users/bpaulin/following{/other_user}","gists_url":"https://api.github.com/users/bpaulin/gists{/gist_id}","starred_url":"https://api.github.com/users/bpaulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpaulin/subscriptions","organizations_url":"https://api.github.com/users/bpaulin/orgs","repos_url":"https://api.github.com/users/bpaulin/repos","events_url":"https://api.github.com/users/bpaulin/events{/privacy}","received_events_url":"https://api.github.com/users/bpaulin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-06-21T17:14:01Z","updated_at":"2015-06-21T21:06:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/15056","html_url":"https://github.com/symfony/symfony/pull/15056","diff_url":"https://github.com/symfony/symfony/pull/15056.diff","patch_url":"https://github.com/symfony/symfony/pull/15056.patch"},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | \r\n| License       | MIT\r\n| Doc PR        | todo\r\n\r\n- [ ] gather feedback\r\n- [ ] submit changes to the documentation\r\n\r\nHello,\r\n\r\nIf an object can't be turned into a string for the URL, then calling render_esi would throw an exception. \r\nBut in dev env, render_esi silently falls back on using a InlineFragmentRenderer and everything seems to work.\r\n\r\nI add a parameter (*framework.fragments.strict*) to make the fallback throw the same exception, to detect the logic error in dev mode, before deploying on an env with cache enabled."},"comment":{"url":"https://api.github.com/repos/symfony/symfony/issues/comments/113959224","html_url":"https://github.com/symfony/symfony/pull/15056#issuecomment-113959224","issue_url":"https://api.github.com/repos/symfony/symfony/issues/15056","id":113959224,"user":{"login":"bpaulin","id":115711,"avatar_url":"https://avatars.githubusercontent.com/u/115711?v=3","gravatar_id":"","url":"https://api.github.com/users/bpaulin","html_url":"https://github.com/bpaulin","followers_url":"https://api.github.com/users/bpaulin/followers","following_url":"https://api.github.com/users/bpaulin/following{/other_user}","gists_url":"https://api.github.com/users/bpaulin/gists{/gist_id}","starred_url":"https://api.github.com/users/bpaulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpaulin/subscriptions","organizations_url":"https://api.github.com/users/bpaulin/orgs","repos_url":"https://api.github.com/users/bpaulin/repos","events_url":"https://api.github.com/users/bpaulin/events{/privacy}","received_events_url":"https://api.github.com/users/bpaulin/received_events","type":"User","site_admin":false},"created_at":"2015-06-21T21:06:15Z","updated_at":"2015-06-21T21:06:15Z","body":"I agree and I think the new behaviour would be better.\nThe option was here to avoid breaking compatibility.\n\nI can rebase this pr and set this as default if needed\n\nThanks!\n Le 21 juin 2015 22:19, \"Fabien Potencier\" <notifications@github.com> a\nécrit :\n\n> Adding an option only makes things more difficult for no real benefit.\n> Either we think that the current behavior is best, and no need to do\n> anything, or we think the new behavior is much better and it should be the\n> default.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/symfony/symfony/pull/15056#issuecomment-113951443>.\n>\n"}}