{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/41601240","id":41601240,"diff_hunk":"@@ -14,8 +15,7 @@ func (s *DockerSuite) TestLoginWithoutTTY(c *check.C) {\n \tcmd.Stdin = bytes.NewBufferString(\"buffer test string \\n\")\n \n \t// run the command and block until it's done\n-\tif err := cmd.Run(); err == nil {\n-\t\tc.Fatal(\"Expected non nil err when loginning in & TTY not available\")\n-\t}\n+\terr := cmd.Run()\n+\tc.Assert(err, checker.NotNil, check.Commentf(\"Expected non nil err when loginning in & TTY not available\"))","path":"integration-cli/docker_cli_login_test.go","position":16,"original_position":16,"commit_id":"79498b1c6124ab4faabb408ef7d973ac899ad1e1","original_commit_id":"79498b1c6124ab4faabb408ef7d973ac899ad1e1","user":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars.githubusercontent.com/u/6508?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"body":"@MHBauer oh right, it will print it, didn't remember that :sweat_smile:.","created_at":"2015-10-09T06:38:53Z","updated_at":"2015-10-09T06:38:53Z","html_url":"https://github.com/docker/docker/pull/16858#discussion_r41601240","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/16858","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/41601240"},"html":{"href":"https://github.com/docker/docker/pull/16858#discussion_r41601240"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/16858"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/16858","id":47177519,"html_url":"https://github.com/docker/docker/pull/16858","diff_url":"https://github.com/docker/docker/pull/16858.diff","patch_url":"https://github.com/docker/docker/pull/16858.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/16858","number":16858,"state":"open","locked":false,"title":"refactor integration-cli/docker_cli_login_test.go with Assert","user":{"login":"cxxly","id":8372068,"avatar_url":"https://avatars.githubusercontent.com/u/8372068?v=3","gravatar_id":"","url":"https://api.github.com/users/cxxly","html_url":"https://github.com/cxxly","followers_url":"https://api.github.com/users/cxxly/followers","following_url":"https://api.github.com/users/cxxly/following{/other_user}","gists_url":"https://api.github.com/users/cxxly/gists{/gist_id}","starred_url":"https://api.github.com/users/cxxly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cxxly/subscriptions","organizations_url":"https://api.github.com/users/cxxly/orgs","repos_url":"https://api.github.com/users/cxxly/repos","events_url":"https://api.github.com/users/cxxly/events{/privacy}","received_events_url":"https://api.github.com/users/cxxly/received_events","type":"User","site_admin":false},"body":"part of #16756\r\n\r\nSigned-off-by: Xiaoxu Chen <chenxiaoxu14@otcaix.iscas.ac.cn>","created_at":"2015-10-08T16:47:02Z","updated_at":"2015-10-09T06:38:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30849e284b01966d1eecaef5a2c97468674a94fd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/16858/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/16858/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/16858/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/79498b1c6124ab4faabb408ef7d973ac899ad1e1","head":{"label":"cxxly:16756-refactor-docker_cli_login_test","ref":"16756-refactor-docker_cli_login_test","sha":"79498b1c6124ab4faabb408ef7d973ac899ad1e1","user":{"login":"cxxly","id":8372068,"avatar_url":"https://avatars.githubusercontent.com/u/8372068?v=3","gravatar_id":"","url":"https://api.github.com/users/cxxly","html_url":"https://github.com/cxxly","followers_url":"https://api.github.com/users/cxxly/followers","following_url":"https://api.github.com/users/cxxly/following{/other_user}","gists_url":"https://api.github.com/users/cxxly/gists{/gist_id}","starred_url":"https://api.github.com/users/cxxly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cxxly/subscriptions","organizations_url":"https://api.github.com/users/cxxly/orgs","repos_url":"https://api.github.com/users/cxxly/repos","events_url":"https://api.github.com/users/cxxly/events{/privacy}","received_events_url":"https://api.github.com/users/cxxly/received_events","type":"User","site_admin":false},"repo":{"id":43901231,"name":"docker","full_name":"cxxly/docker","owner":{"login":"cxxly","id":8372068,"avatar_url":"https://avatars.githubusercontent.com/u/8372068?v=3","gravatar_id":"","url":"https://api.github.com/users/cxxly","html_url":"https://github.com/cxxly","followers_url":"https://api.github.com/users/cxxly/followers","following_url":"https://api.github.com/users/cxxly/following{/other_user}","gists_url":"https://api.github.com/users/cxxly/gists{/gist_id}","starred_url":"https://api.github.com/users/cxxly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cxxly/subscriptions","organizations_url":"https://api.github.com/users/cxxly/orgs","repos_url":"https://api.github.com/users/cxxly/repos","events_url":"https://api.github.com/users/cxxly/events{/privacy}","received_events_url":"https://api.github.com/users/cxxly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cxxly/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/cxxly/docker","forks_url":"https://api.github.com/repos/cxxly/docker/forks","keys_url":"https://api.github.com/repos/cxxly/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cxxly/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cxxly/docker/teams","hooks_url":"https://api.github.com/repos/cxxly/docker/hooks","issue_events_url":"https://api.github.com/repos/cxxly/docker/issues/events{/number}","events_url":"https://api.github.com/repos/cxxly/docker/events","assignees_url":"https://api.github.com/repos/cxxly/docker/assignees{/user}","branches_url":"https://api.github.com/repos/cxxly/docker/branches{/branch}","tags_url":"https://api.github.com/repos/cxxly/docker/tags","blobs_url":"https://api.github.com/repos/cxxly/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cxxly/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cxxly/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/cxxly/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cxxly/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/cxxly/docker/languages","stargazers_url":"https://api.github.com/repos/cxxly/docker/stargazers","contributors_url":"https://api.github.com/repos/cxxly/docker/contributors","subscribers_url":"https://api.github.com/repos/cxxly/docker/subscribers","subscription_url":"https://api.github.com/repos/cxxly/docker/subscription","commits_url":"https://api.github.com/repos/cxxly/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/cxxly/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/cxxly/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/cxxly/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/cxxly/docker/contents/{+path}","compare_url":"https://api.github.com/repos/cxxly/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cxxly/docker/merges","archive_url":"https://api.github.com/repos/cxxly/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cxxly/docker/downloads","issues_url":"https://api.github.com/repos/cxxly/docker/issues{/number}","pulls_url":"https://api.github.com/repos/cxxly/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/cxxly/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/cxxly/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cxxly/docker/labels{/name}","releases_url":"https://api.github.com/repos/cxxly/docker/releases{/id}","created_at":"2015-10-08T16:10:57Z","updated_at":"2015-10-08T16:11:09Z","pushed_at":"2015-10-09T03:13:12Z","git_url":"git://github.com/cxxly/docker.git","ssh_url":"git@github.com:cxxly/docker.git","clone_url":"https://github.com/cxxly/docker.git","svn_url":"https://github.com/cxxly/docker","homepage":"http://www.docker.com","size":70001,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"2b6af905faacc5eff0f1b3263974f5af12a92ed4","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-10-09T05:57:22Z","pushed_at":"2015-10-09T06:34:57Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":264638,"stargazers_count":25302,"watchers_count":25302,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6641,"mirror_url":null,"open_issues_count":1115,"forks":6641,"open_issues":1115,"watchers":25302,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/16858"},"html":{"href":"https://github.com/docker/docker/pull/16858"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/16858"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/16858/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/16858/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/16858/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/79498b1c6124ab4faabb408ef7d973ac899ad1e1"}}}}