{"action":"closed","number":12073,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/12073","id":32628662,"html_url":"https://github.com/docker/docker/pull/12073","diff_url":"https://github.com/docker/docker/pull/12073.diff","patch_url":"https://github.com/docker/docker/pull/12073.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/12073","number":12073,"state":"closed","locked":false,"title":"Add building the RPM to the make process","user":{"login":"pdevine","id":75239,"avatar_url":"https://avatars.githubusercontent.com/u/75239?v=3","gravatar_id":"","url":"https://api.github.com/users/pdevine","html_url":"https://github.com/pdevine","followers_url":"https://api.github.com/users/pdevine/followers","following_url":"https://api.github.com/users/pdevine/following{/other_user}","gists_url":"https://api.github.com/users/pdevine/gists{/gist_id}","starred_url":"https://api.github.com/users/pdevine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdevine/subscriptions","organizations_url":"https://api.github.com/users/pdevine/orgs","repos_url":"https://api.github.com/users/pdevine/repos","events_url":"https://api.github.com/users/pdevine/events{/privacy}","received_events_url":"https://api.github.com/users/pdevine/received_events","type":"User","site_admin":false},"body":"This change uses docker-in-docker to build a centos build container\r\nduring the build process which then creates the dynamically linked\r\nbinary.  This is done because statically linked binaries on Centos/\r\nRHEL/Fedora are a non-starter, and we want the release process to\r\nnot be disrupted.  To create the RPMs, you can use the command:\r\n\r\nhack/make.sh binary dind-rpm\r\n\r\nwhich will first create the statically linked docker binary which is\r\nthen used to run docker-in-docker to run a centos build container.","created_at":"2015-04-04T04:13:45Z","updated_at":"2015-05-01T00:10:24Z","closed_at":"2015-05-01T00:10:24Z","merged_at":null,"merge_commit_sha":"3932e6e9ecd00d6e2362d031a19dcb221dbe5f13","assignee":{"login":"jfrazelle","id":1445228,"avatar_url":"https://avatars.githubusercontent.com/u/1445228?v=3","gravatar_id":"","url":"https://api.github.com/users/jfrazelle","html_url":"https://github.com/jfrazelle","followers_url":"https://api.github.com/users/jfrazelle/followers","following_url":"https://api.github.com/users/jfrazelle/following{/other_user}","gists_url":"https://api.github.com/users/jfrazelle/gists{/gist_id}","starred_url":"https://api.github.com/users/jfrazelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfrazelle/subscriptions","organizations_url":"https://api.github.com/users/jfrazelle/orgs","repos_url":"https://api.github.com/users/jfrazelle/repos","events_url":"https://api.github.com/users/jfrazelle/events{/privacy}","received_events_url":"https://api.github.com/users/jfrazelle/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/12073/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/12073/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/12073/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/d16946e9f496f05645577bbe1e79254cbd1dfc17","head":{"label":"pdevine:dind-rpm","ref":"dind-rpm","sha":"d16946e9f496f05645577bbe1e79254cbd1dfc17","user":{"login":"pdevine","id":75239,"avatar_url":"https://avatars.githubusercontent.com/u/75239?v=3","gravatar_id":"","url":"https://api.github.com/users/pdevine","html_url":"https://github.com/pdevine","followers_url":"https://api.github.com/users/pdevine/followers","following_url":"https://api.github.com/users/pdevine/following{/other_user}","gists_url":"https://api.github.com/users/pdevine/gists{/gist_id}","starred_url":"https://api.github.com/users/pdevine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdevine/subscriptions","organizations_url":"https://api.github.com/users/pdevine/orgs","repos_url":"https://api.github.com/users/pdevine/repos","events_url":"https://api.github.com/users/pdevine/events{/privacy}","received_events_url":"https://api.github.com/users/pdevine/received_events","type":"User","site_admin":false},"repo":{"id":32956215,"name":"docker","full_name":"pdevine/docker","owner":{"login":"pdevine","id":75239,"avatar_url":"https://avatars.githubusercontent.com/u/75239?v=3","gravatar_id":"","url":"https://api.github.com/users/pdevine","html_url":"https://github.com/pdevine","followers_url":"https://api.github.com/users/pdevine/followers","following_url":"https://api.github.com/users/pdevine/following{/other_user}","gists_url":"https://api.github.com/users/pdevine/gists{/gist_id}","starred_url":"https://api.github.com/users/pdevine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdevine/subscriptions","organizations_url":"https://api.github.com/users/pdevine/orgs","repos_url":"https://api.github.com/users/pdevine/repos","events_url":"https://api.github.com/users/pdevine/events{/privacy}","received_events_url":"https://api.github.com/users/pdevine/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pdevine/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/pdevine/docker","forks_url":"https://api.github.com/repos/pdevine/docker/forks","keys_url":"https://api.github.com/repos/pdevine/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pdevine/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pdevine/docker/teams","hooks_url":"https://api.github.com/repos/pdevine/docker/hooks","issue_events_url":"https://api.github.com/repos/pdevine/docker/issues/events{/number}","events_url":"https://api.github.com/repos/pdevine/docker/events","assignees_url":"https://api.github.com/repos/pdevine/docker/assignees{/user}","branches_url":"https://api.github.com/repos/pdevine/docker/branches{/branch}","tags_url":"https://api.github.com/repos/pdevine/docker/tags","blobs_url":"https://api.github.com/repos/pdevine/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pdevine/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pdevine/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/pdevine/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pdevine/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/pdevine/docker/languages","stargazers_url":"https://api.github.com/repos/pdevine/docker/stargazers","contributors_url":"https://api.github.com/repos/pdevine/docker/contributors","subscribers_url":"https://api.github.com/repos/pdevine/docker/subscribers","subscription_url":"https://api.github.com/repos/pdevine/docker/subscription","commits_url":"https://api.github.com/repos/pdevine/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/pdevine/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/pdevine/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/pdevine/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/pdevine/docker/contents/{+path}","compare_url":"https://api.github.com/repos/pdevine/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pdevine/docker/merges","archive_url":"https://api.github.com/repos/pdevine/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pdevine/docker/downloads","issues_url":"https://api.github.com/repos/pdevine/docker/issues{/number}","pulls_url":"https://api.github.com/repos/pdevine/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/pdevine/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/pdevine/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pdevine/docker/labels{/name}","releases_url":"https://api.github.com/repos/pdevine/docker/releases{/id}","created_at":"2015-03-26T22:55:05Z","updated_at":"2015-04-15T18:05:17Z","pushed_at":"2015-04-15T18:09:32Z","git_url":"git://github.com/pdevine/docker.git","ssh_url":"git@github.com:pdevine/docker.git","clone_url":"https://github.com/pdevine/docker.git","svn_url":"https://github.com/pdevine/docker","homepage":"http://www.docker.com","size":49296,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"2499baefddb03e38b38a413a7290340a3f4b7420","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-05-01T00:08:23Z","pushed_at":"2015-05-01T00:10:03Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":192378,"stargazers_count":21273,"watchers_count":21273,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4945,"mirror_url":null,"open_issues_count":970,"forks":4945,"open_issues":970,"watchers":21273,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/12073"},"html":{"href":"https://github.com/docker/docker/pull/12073"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/12073"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/12073/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/12073/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/12073/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/d16946e9f496f05645577bbe1e79254cbd1dfc17"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":12,"review_comments":0,"commits":3,"additions":255,"deletions":2,"changed_files":6}}