{"action":"opened","number":1383,"pull_request":{"url":"https://api.github.com/repos/pantsbuild/pants/pulls/1383","id":32959518,"html_url":"https://github.com/pantsbuild/pants/pull/1383","diff_url":"https://github.com/pantsbuild/pants/pull/1383.diff","patch_url":"https://github.com/pantsbuild/pants/pull/1383.patch","issue_url":"https://api.github.com/repos/pantsbuild/pants/issues/1383","number":1383,"state":"open","locked":false,"title":"Tejal29/goal idea for twitter","user":{"login":"tejal29","id":1534539,"avatar_url":"https://avatars.githubusercontent.com/u/1534539?v=3","gravatar_id":"","url":"https://api.github.com/users/tejal29","html_url":"https://github.com/tejal29","followers_url":"https://api.github.com/users/tejal29/followers","following_url":"https://api.github.com/users/tejal29/following{/other_user}","gists_url":"https://api.github.com/users/tejal29/gists{/gist_id}","starred_url":"https://api.github.com/users/tejal29/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tejal29/subscriptions","organizations_url":"https://api.github.com/users/tejal29/orgs","repos_url":"https://api.github.com/users/tejal29/repos","events_url":"https://api.github.com/users/tejal29/events{/privacy}","received_events_url":"https://api.github.com/users/tejal29/received_events","type":"User","site_admin":false},"body":"Add 'java-resource' and 'java-test-resource' content type for Resources Roots. \r\n\r\nI also discovered an error in how resources content types were added. The target.target_base was used as root_dir to add resources instead of resource.target_base. \r\nThis was masked by the fact `resource` target was also included in self.context_targets. The right source root was registered then.\r\n\r\nIn this review, after fixing above bug, i saw 2 content roots registered for the same resource target. Changed the self.sources to be a set instead of an array.\r\n ","created_at":"2015-04-09T14:16:44Z","updated_at":"2015-04-09T14:16:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pantsbuild/pants/pulls/1383/commits","review_comments_url":"https://api.github.com/repos/pantsbuild/pants/pulls/1383/comments","review_comment_url":"https://api.github.com/repos/pantsbuild/pants/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pantsbuild/pants/issues/1383/comments","statuses_url":"https://api.github.com/repos/pantsbuild/pants/statuses/b778ed65f5442ed0f7a70ce8a0b3c416a70ba1a0","head":{"label":"tejal29:tejal29/goal_idea_for_twitter","ref":"tejal29/goal_idea_for_twitter","sha":"b778ed65f5442ed0f7a70ce8a0b3c416a70ba1a0","user":{"login":"tejal29","id":1534539,"avatar_url":"https://avatars.githubusercontent.com/u/1534539?v=3","gravatar_id":"","url":"https://api.github.com/users/tejal29","html_url":"https://github.com/tejal29","followers_url":"https://api.github.com/users/tejal29/followers","following_url":"https://api.github.com/users/tejal29/following{/other_user}","gists_url":"https://api.github.com/users/tejal29/gists{/gist_id}","starred_url":"https://api.github.com/users/tejal29/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tejal29/subscriptions","organizations_url":"https://api.github.com/users/tejal29/orgs","repos_url":"https://api.github.com/users/tejal29/repos","events_url":"https://api.github.com/users/tejal29/events{/privacy}","received_events_url":"https://api.github.com/users/tejal29/received_events","type":"User","site_admin":false},"repo":{"id":29284850,"name":"pants","full_name":"tejal29/pants","owner":{"login":"tejal29","id":1534539,"avatar_url":"https://avatars.githubusercontent.com/u/1534539?v=3","gravatar_id":"","url":"https://api.github.com/users/tejal29","html_url":"https://github.com/tejal29","followers_url":"https://api.github.com/users/tejal29/followers","following_url":"https://api.github.com/users/tejal29/following{/other_user}","gists_url":"https://api.github.com/users/tejal29/gists{/gist_id}","starred_url":"https://api.github.com/users/tejal29/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tejal29/subscriptions","organizations_url":"https://api.github.com/users/tejal29/orgs","repos_url":"https://api.github.com/users/tejal29/repos","events_url":"https://api.github.com/users/tejal29/events{/privacy}","received_events_url":"https://api.github.com/users/tejal29/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tejal29/pants","description":"Pants Build System","fork":true,"url":"https://api.github.com/repos/tejal29/pants","forks_url":"https://api.github.com/repos/tejal29/pants/forks","keys_url":"https://api.github.com/repos/tejal29/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tejal29/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tejal29/pants/teams","hooks_url":"https://api.github.com/repos/tejal29/pants/hooks","issue_events_url":"https://api.github.com/repos/tejal29/pants/issues/events{/number}","events_url":"https://api.github.com/repos/tejal29/pants/events","assignees_url":"https://api.github.com/repos/tejal29/pants/assignees{/user}","branches_url":"https://api.github.com/repos/tejal29/pants/branches{/branch}","tags_url":"https://api.github.com/repos/tejal29/pants/tags","blobs_url":"https://api.github.com/repos/tejal29/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tejal29/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tejal29/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/tejal29/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tejal29/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/tejal29/pants/languages","stargazers_url":"https://api.github.com/repos/tejal29/pants/stargazers","contributors_url":"https://api.github.com/repos/tejal29/pants/contributors","subscribers_url":"https://api.github.com/repos/tejal29/pants/subscribers","subscription_url":"https://api.github.com/repos/tejal29/pants/subscription","commits_url":"https://api.github.com/repos/tejal29/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/tejal29/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/tejal29/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/tejal29/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/tejal29/pants/contents/{+path}","compare_url":"https://api.github.com/repos/tejal29/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tejal29/pants/merges","archive_url":"https://api.github.com/repos/tejal29/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tejal29/pants/downloads","issues_url":"https://api.github.com/repos/tejal29/pants/issues{/number}","pulls_url":"https://api.github.com/repos/tejal29/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/tejal29/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/tejal29/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tejal29/pants/labels{/name}","releases_url":"https://api.github.com/repos/tejal29/pants/releases{/id}","created_at":"2015-01-15T06:52:11Z","updated_at":"2015-02-20T18:42:57Z","pushed_at":"2015-04-09T14:11:48Z","git_url":"git://github.com/tejal29/pants.git","ssh_url":"git@github.com:tejal29/pants.git","clone_url":"https://github.com/tejal29/pants.git","svn_url":"https://github.com/tejal29/pants","homepage":"http://pantsbuild.github.io/","size":50303,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pantsbuild:master","ref":"master","sha":"9844090b3d2c89c408db8d2b36a43409a0076577","user":{"login":"pantsbuild","id":3065172,"avatar_url":"https://avatars.githubusercontent.com/u/3065172?v=3","gravatar_id":"","url":"https://api.github.com/users/pantsbuild","html_url":"https://github.com/pantsbuild","followers_url":"https://api.github.com/users/pantsbuild/followers","following_url":"https://api.github.com/users/pantsbuild/following{/other_user}","gists_url":"https://api.github.com/users/pantsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/pantsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantsbuild/subscriptions","organizations_url":"https://api.github.com/users/pantsbuild/orgs","repos_url":"https://api.github.com/users/pantsbuild/repos","events_url":"https://api.github.com/users/pantsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/pantsbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":7209075,"name":"pants","full_name":"pantsbuild/pants","owner":{"login":"pantsbuild","id":3065172,"avatar_url":"https://avatars.githubusercontent.com/u/3065172?v=3","gravatar_id":"","url":"https://api.github.com/users/pantsbuild","html_url":"https://github.com/pantsbuild","followers_url":"https://api.github.com/users/pantsbuild/followers","following_url":"https://api.github.com/users/pantsbuild/following{/other_user}","gists_url":"https://api.github.com/users/pantsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/pantsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantsbuild/subscriptions","organizations_url":"https://api.github.com/users/pantsbuild/orgs","repos_url":"https://api.github.com/users/pantsbuild/repos","events_url":"https://api.github.com/users/pantsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/pantsbuild/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pantsbuild/pants","description":"Pants Build System","fork":false,"url":"https://api.github.com/repos/pantsbuild/pants","forks_url":"https://api.github.com/repos/pantsbuild/pants/forks","keys_url":"https://api.github.com/repos/pantsbuild/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pantsbuild/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pantsbuild/pants/teams","hooks_url":"https://api.github.com/repos/pantsbuild/pants/hooks","issue_events_url":"https://api.github.com/repos/pantsbuild/pants/issues/events{/number}","events_url":"https://api.github.com/repos/pantsbuild/pants/events","assignees_url":"https://api.github.com/repos/pantsbuild/pants/assignees{/user}","branches_url":"https://api.github.com/repos/pantsbuild/pants/branches{/branch}","tags_url":"https://api.github.com/repos/pantsbuild/pants/tags","blobs_url":"https://api.github.com/repos/pantsbuild/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pantsbuild/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pantsbuild/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/pantsbuild/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pantsbuild/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/pantsbuild/pants/languages","stargazers_url":"https://api.github.com/repos/pantsbuild/pants/stargazers","contributors_url":"https://api.github.com/repos/pantsbuild/pants/contributors","subscribers_url":"https://api.github.com/repos/pantsbuild/pants/subscribers","subscription_url":"https://api.github.com/repos/pantsbuild/pants/subscription","commits_url":"https://api.github.com/repos/pantsbuild/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/pantsbuild/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/pantsbuild/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/pantsbuild/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/pantsbuild/pants/contents/{+path}","compare_url":"https://api.github.com/repos/pantsbuild/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pantsbuild/pants/merges","archive_url":"https://api.github.com/repos/pantsbuild/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pantsbuild/pants/downloads","issues_url":"https://api.github.com/repos/pantsbuild/pants/issues{/number}","pulls_url":"https://api.github.com/repos/pantsbuild/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/pantsbuild/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/pantsbuild/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pantsbuild/pants/labels{/name}","releases_url":"https://api.github.com/repos/pantsbuild/pants/releases{/id}","created_at":"2012-12-17T17:39:04Z","updated_at":"2015-04-08T16:04:28Z","pushed_at":"2015-04-09T03:37:00Z","git_url":"git://github.com/pantsbuild/pants.git","ssh_url":"git@github.com:pantsbuild/pants.git","clone_url":"https://github.com/pantsbuild/pants.git","svn_url":"https://github.com/pantsbuild/pants","homepage":"http://pantsbuild.github.io/","size":74407,"stargazers_count":335,"watchers_count":335,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":81,"mirror_url":null,"open_issues_count":231,"forks":81,"open_issues":231,"watchers":335,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/1383"},"html":{"href":"https://github.com/pantsbuild/pants/pull/1383"},"issue":{"href":"https://api.github.com/repos/pantsbuild/pants/issues/1383"},"comments":{"href":"https://api.github.com/repos/pantsbuild/pants/issues/1383/comments"},"review_comments":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/1383/comments"},"review_comment":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/1383/commits"},"statuses":{"href":"https://api.github.com/repos/pantsbuild/pants/statuses/b778ed65f5442ed0f7a70ce8a0b3c416a70ba1a0"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":54,"deletions":10,"changed_files":4}}