{"action":"opened","number":18,"pull_request":{"url":"https://api.github.com/repos/skanaar/nomnoml/pulls/18","id":36558301,"html_url":"https://github.com/skanaar/nomnoml/pull/18","diff_url":"https://github.com/skanaar/nomnoml/pull/18.diff","patch_url":"https://github.com/skanaar/nomnoml/pull/18.patch","issue_url":"https://api.github.com/repos/skanaar/nomnoml/issues/18","number":18,"state":"open","locked":false,"title":"Librarify","user":{"login":"korroz","id":723273,"avatar_url":"https://avatars.githubusercontent.com/u/723273?v=3","gravatar_id":"","url":"https://api.github.com/users/korroz","html_url":"https://github.com/korroz","followers_url":"https://api.github.com/users/korroz/followers","following_url":"https://api.github.com/users/korroz/following{/other_user}","gists_url":"https://api.github.com/users/korroz/gists{/gist_id}","starred_url":"https://api.github.com/users/korroz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/korroz/subscriptions","organizations_url":"https://api.github.com/users/korroz/orgs","repos_url":"https://api.github.com/users/korroz/repos","events_url":"https://api.github.com/users/korroz/events{/privacy}","received_events_url":"https://api.github.com/users/korroz/received_events","type":"User","site_admin":false},"body":"The goal of this branch was to make the core functionality of nomnoml standalone in the form of a single javascript library file. When I started the core functionality was tightly coupled with the nomnoml web application so a lot of work went into refactoring dependencies. In the end this branch has these main features:\r\n\r\n - Standalone `nomnoml.js`.\r\n - Only dependency for the standalone is on **lodash**.\r\n - RequireJS (amd) and global support.\r\n - Configured as a [Bower](http://bower.io) package for easy consumption.\r\n\r\nLesser features of the project:\r\n\r\n - Project is now using the [npm](https://www.npmjs.com) package manager.\r\n - Project is now using the [Bower](http://bower.io) package manager for front-end dependencies.\r\n - Switched from depending on **underscore** to **lodash**. (Bower)\r\n - Project uses [gulp](http://gulpjs.com) for building `nomnoml.js`. (npm)\r\n\r\nAnother sort of outstanding issue is to register the repo in [Bower](http://bower.io) so people can use the short form `nomnoml` when installing the package instead of the full url to the github repo.\r\n\r\nThe above are the major points. Code wise there have been some major restructuring that may be interesting to note, some of which:\r\n\r\n - The **underscore** extensions were decoupled and now simply live on an object called `_skanaar`.\r\n - The `vector.js` helper functions were pushed into the nomnoml namespace as the object `nomnoml.vectorMath`.\r\n - All core functionality was pulled out from `nomnoml.app.js`, moving many functions and even splitting `fitCanvasSize()` into two.\r\n\r\nI also need to mention that while this is a good step, separating core from app there are still things I'm not particularly pleased with, so there are areas which could use further improvement.\r\n\r\nAnd lastly, this should close issue #17.","created_at":"2015-05-30T02:17:36Z","updated_at":"2015-05-30T02:17:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/skanaar/nomnoml/pulls/18/commits","review_comments_url":"https://api.github.com/repos/skanaar/nomnoml/pulls/18/comments","review_comment_url":"https://api.github.com/repos/skanaar/nomnoml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/skanaar/nomnoml/issues/18/comments","statuses_url":"https://api.github.com/repos/skanaar/nomnoml/statuses/b399e5c06837332712a6b054cc5a803dd78c5b9a","head":{"label":"korroz:librarify","ref":"librarify","sha":"b399e5c06837332712a6b054cc5a803dd78c5b9a","user":{"login":"korroz","id":723273,"avatar_url":"https://avatars.githubusercontent.com/u/723273?v=3","gravatar_id":"","url":"https://api.github.com/users/korroz","html_url":"https://github.com/korroz","followers_url":"https://api.github.com/users/korroz/followers","following_url":"https://api.github.com/users/korroz/following{/other_user}","gists_url":"https://api.github.com/users/korroz/gists{/gist_id}","starred_url":"https://api.github.com/users/korroz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/korroz/subscriptions","organizations_url":"https://api.github.com/users/korroz/orgs","repos_url":"https://api.github.com/users/korroz/repos","events_url":"https://api.github.com/users/korroz/events{/privacy}","received_events_url":"https://api.github.com/users/korroz/received_events","type":"User","site_admin":false},"repo":{"id":31969584,"name":"nomnoml","full_name":"korroz/nomnoml","owner":{"login":"korroz","id":723273,"avatar_url":"https://avatars.githubusercontent.com/u/723273?v=3","gravatar_id":"","url":"https://api.github.com/users/korroz","html_url":"https://github.com/korroz","followers_url":"https://api.github.com/users/korroz/followers","following_url":"https://api.github.com/users/korroz/following{/other_user}","gists_url":"https://api.github.com/users/korroz/gists{/gist_id}","starred_url":"https://api.github.com/users/korroz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/korroz/subscriptions","organizations_url":"https://api.github.com/users/korroz/orgs","repos_url":"https://api.github.com/users/korroz/repos","events_url":"https://api.github.com/users/korroz/events{/privacy}","received_events_url":"https://api.github.com/users/korroz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/korroz/nomnoml","description":"The sassy UML diagram renderer","fork":true,"url":"https://api.github.com/repos/korroz/nomnoml","forks_url":"https://api.github.com/repos/korroz/nomnoml/forks","keys_url":"https://api.github.com/repos/korroz/nomnoml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/korroz/nomnoml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/korroz/nomnoml/teams","hooks_url":"https://api.github.com/repos/korroz/nomnoml/hooks","issue_events_url":"https://api.github.com/repos/korroz/nomnoml/issues/events{/number}","events_url":"https://api.github.com/repos/korroz/nomnoml/events","assignees_url":"https://api.github.com/repos/korroz/nomnoml/assignees{/user}","branches_url":"https://api.github.com/repos/korroz/nomnoml/branches{/branch}","tags_url":"https://api.github.com/repos/korroz/nomnoml/tags","blobs_url":"https://api.github.com/repos/korroz/nomnoml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/korroz/nomnoml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/korroz/nomnoml/git/refs{/sha}","trees_url":"https://api.github.com/repos/korroz/nomnoml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/korroz/nomnoml/statuses/{sha}","languages_url":"https://api.github.com/repos/korroz/nomnoml/languages","stargazers_url":"https://api.github.com/repos/korroz/nomnoml/stargazers","contributors_url":"https://api.github.com/repos/korroz/nomnoml/contributors","subscribers_url":"https://api.github.com/repos/korroz/nomnoml/subscribers","subscription_url":"https://api.github.com/repos/korroz/nomnoml/subscription","commits_url":"https://api.github.com/repos/korroz/nomnoml/commits{/sha}","git_commits_url":"https://api.github.com/repos/korroz/nomnoml/git/commits{/sha}","comments_url":"https://api.github.com/repos/korroz/nomnoml/comments{/number}","issue_comment_url":"https://api.github.com/repos/korroz/nomnoml/issues/comments{/number}","contents_url":"https://api.github.com/repos/korroz/nomnoml/contents/{+path}","compare_url":"https://api.github.com/repos/korroz/nomnoml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/korroz/nomnoml/merges","archive_url":"https://api.github.com/repos/korroz/nomnoml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/korroz/nomnoml/downloads","issues_url":"https://api.github.com/repos/korroz/nomnoml/issues{/number}","pulls_url":"https://api.github.com/repos/korroz/nomnoml/pulls{/number}","milestones_url":"https://api.github.com/repos/korroz/nomnoml/milestones{/number}","notifications_url":"https://api.github.com/repos/korroz/nomnoml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/korroz/nomnoml/labels{/name}","releases_url":"https://api.github.com/repos/korroz/nomnoml/releases{/id}","created_at":"2015-03-10T16:51:41Z","updated_at":"2015-03-10T16:51:42Z","pushed_at":"2015-05-30T01:36:58Z","git_url":"git://github.com/korroz/nomnoml.git","ssh_url":"git@github.com:korroz/nomnoml.git","clone_url":"https://github.com/korroz/nomnoml.git","svn_url":"https://github.com/korroz/nomnoml","homepage":null,"size":259,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"skanaar:master","ref":"master","sha":"9cdb47c8d33c2d4cffd1f8b4aeefe1a9f6d690f1","user":{"login":"skanaar","id":641015,"avatar_url":"https://avatars.githubusercontent.com/u/641015?v=3","gravatar_id":"","url":"https://api.github.com/users/skanaar","html_url":"https://github.com/skanaar","followers_url":"https://api.github.com/users/skanaar/followers","following_url":"https://api.github.com/users/skanaar/following{/other_user}","gists_url":"https://api.github.com/users/skanaar/gists{/gist_id}","starred_url":"https://api.github.com/users/skanaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skanaar/subscriptions","organizations_url":"https://api.github.com/users/skanaar/orgs","repos_url":"https://api.github.com/users/skanaar/repos","events_url":"https://api.github.com/users/skanaar/events{/privacy}","received_events_url":"https://api.github.com/users/skanaar/received_events","type":"User","site_admin":false},"repo":{"id":20434274,"name":"nomnoml","full_name":"skanaar/nomnoml","owner":{"login":"skanaar","id":641015,"avatar_url":"https://avatars.githubusercontent.com/u/641015?v=3","gravatar_id":"","url":"https://api.github.com/users/skanaar","html_url":"https://github.com/skanaar","followers_url":"https://api.github.com/users/skanaar/followers","following_url":"https://api.github.com/users/skanaar/following{/other_user}","gists_url":"https://api.github.com/users/skanaar/gists{/gist_id}","starred_url":"https://api.github.com/users/skanaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skanaar/subscriptions","organizations_url":"https://api.github.com/users/skanaar/orgs","repos_url":"https://api.github.com/users/skanaar/repos","events_url":"https://api.github.com/users/skanaar/events{/privacy}","received_events_url":"https://api.github.com/users/skanaar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skanaar/nomnoml","description":"The sassy UML diagram renderer","fork":false,"url":"https://api.github.com/repos/skanaar/nomnoml","forks_url":"https://api.github.com/repos/skanaar/nomnoml/forks","keys_url":"https://api.github.com/repos/skanaar/nomnoml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skanaar/nomnoml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skanaar/nomnoml/teams","hooks_url":"https://api.github.com/repos/skanaar/nomnoml/hooks","issue_events_url":"https://api.github.com/repos/skanaar/nomnoml/issues/events{/number}","events_url":"https://api.github.com/repos/skanaar/nomnoml/events","assignees_url":"https://api.github.com/repos/skanaar/nomnoml/assignees{/user}","branches_url":"https://api.github.com/repos/skanaar/nomnoml/branches{/branch}","tags_url":"https://api.github.com/repos/skanaar/nomnoml/tags","blobs_url":"https://api.github.com/repos/skanaar/nomnoml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skanaar/nomnoml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skanaar/nomnoml/git/refs{/sha}","trees_url":"https://api.github.com/repos/skanaar/nomnoml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skanaar/nomnoml/statuses/{sha}","languages_url":"https://api.github.com/repos/skanaar/nomnoml/languages","stargazers_url":"https://api.github.com/repos/skanaar/nomnoml/stargazers","contributors_url":"https://api.github.com/repos/skanaar/nomnoml/contributors","subscribers_url":"https://api.github.com/repos/skanaar/nomnoml/subscribers","subscription_url":"https://api.github.com/repos/skanaar/nomnoml/subscription","commits_url":"https://api.github.com/repos/skanaar/nomnoml/commits{/sha}","git_commits_url":"https://api.github.com/repos/skanaar/nomnoml/git/commits{/sha}","comments_url":"https://api.github.com/repos/skanaar/nomnoml/comments{/number}","issue_comment_url":"https://api.github.com/repos/skanaar/nomnoml/issues/comments{/number}","contents_url":"https://api.github.com/repos/skanaar/nomnoml/contents/{+path}","compare_url":"https://api.github.com/repos/skanaar/nomnoml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skanaar/nomnoml/merges","archive_url":"https://api.github.com/repos/skanaar/nomnoml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skanaar/nomnoml/downloads","issues_url":"https://api.github.com/repos/skanaar/nomnoml/issues{/number}","pulls_url":"https://api.github.com/repos/skanaar/nomnoml/pulls{/number}","milestones_url":"https://api.github.com/repos/skanaar/nomnoml/milestones{/number}","notifications_url":"https://api.github.com/repos/skanaar/nomnoml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skanaar/nomnoml/labels{/name}","releases_url":"https://api.github.com/repos/skanaar/nomnoml/releases{/id}","created_at":"2014-06-03T07:57:09Z","updated_at":"2015-05-27T11:26:00Z","pushed_at":"2015-05-25T20:37:34Z","git_url":"git://github.com/skanaar/nomnoml.git","ssh_url":"git@github.com:skanaar/nomnoml.git","clone_url":"https://github.com/skanaar/nomnoml.git","svn_url":"https://github.com/skanaar/nomnoml","homepage":null,"size":298,"stargazers_count":110,"watchers_count":110,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":12,"forks":16,"open_issues":12,"watchers":110,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/skanaar/nomnoml/pulls/18"},"html":{"href":"https://github.com/skanaar/nomnoml/pull/18"},"issue":{"href":"https://api.github.com/repos/skanaar/nomnoml/issues/18"},"comments":{"href":"https://api.github.com/repos/skanaar/nomnoml/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/skanaar/nomnoml/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/skanaar/nomnoml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/skanaar/nomnoml/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/skanaar/nomnoml/statuses/b399e5c06837332712a6b054cc5a803dd78c5b9a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":17,"additions":1526,"deletions":131,"changed_files":21}}