{"action":"opened","number":10888,"pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/10888","id":33419128,"html_url":"https://github.com/emberjs/ember.js/pull/10888","diff_url":"https://github.com/emberjs/ember.js/pull/10888.diff","patch_url":"https://github.com/emberjs/ember.js/pull/10888.patch","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/10888","number":10888,"state":"open","locked":false,"title":"isVisible fixes","user":{"login":"mitchlloyd","id":15169,"avatar_url":"https://avatars.githubusercontent.com/u/15169?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchlloyd","html_url":"https://github.com/mitchlloyd","followers_url":"https://api.github.com/users/mitchlloyd/followers","following_url":"https://api.github.com/users/mitchlloyd/following{/other_user}","gists_url":"https://api.github.com/users/mitchlloyd/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchlloyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchlloyd/subscriptions","organizations_url":"https://api.github.com/users/mitchlloyd/orgs","repos_url":"https://api.github.com/users/mitchlloyd/repos","events_url":"https://api.github.com/users/mitchlloyd/events{/privacy}","received_events_url":"https://api.github.com/users/mitchlloyd/received_events","type":"User","site_admin":false},"body":"A couple small additions got the isVisible tests passing.\r\n\r\nThe first change sets the initial style value based on the `isVisible` property. One potential problem with this is that if someone has `attributeBindings` for style setup, then `isVisible` will stomp on the style property with `display: none` when the component is rendered. However, when `isVisible` becomes true, the style from attributeBindings is restored. Really one could argue that this isn't a problem, but I went ahead and added a test and a fix for this in the 3rd commit.\r\n\r\nMost of the \"isVisible with Container\" tests were failing because a view had a template method that returned a raw string. Adding an additional check for `layoutTemplate.raw` before attempting to setup `blockToRender` worked around this issue.\r\n\r\n","created_at":"2015-04-16T04:58:55Z","updated_at":"2015-04-16T04:58:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember.js/pulls/10888/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember.js/pulls/10888/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/10888/comments","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/db465aefdbe4472dc90bfdd481b7cdedd1095bda","head":{"label":"mitchlloyd:is-visible-fixes","ref":"is-visible-fixes","sha":"db465aefdbe4472dc90bfdd481b7cdedd1095bda","user":{"login":"mitchlloyd","id":15169,"avatar_url":"https://avatars.githubusercontent.com/u/15169?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchlloyd","html_url":"https://github.com/mitchlloyd","followers_url":"https://api.github.com/users/mitchlloyd/followers","following_url":"https://api.github.com/users/mitchlloyd/following{/other_user}","gists_url":"https://api.github.com/users/mitchlloyd/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchlloyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchlloyd/subscriptions","organizations_url":"https://api.github.com/users/mitchlloyd/orgs","repos_url":"https://api.github.com/users/mitchlloyd/repos","events_url":"https://api.github.com/users/mitchlloyd/events{/privacy}","received_events_url":"https://api.github.com/users/mitchlloyd/received_events","type":"User","site_admin":false},"repo":{"id":10712207,"name":"ember.js","full_name":"mitchlloyd/ember.js","owner":{"login":"mitchlloyd","id":15169,"avatar_url":"https://avatars.githubusercontent.com/u/15169?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchlloyd","html_url":"https://github.com/mitchlloyd","followers_url":"https://api.github.com/users/mitchlloyd/followers","following_url":"https://api.github.com/users/mitchlloyd/following{/other_user}","gists_url":"https://api.github.com/users/mitchlloyd/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchlloyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchlloyd/subscriptions","organizations_url":"https://api.github.com/users/mitchlloyd/orgs","repos_url":"https://api.github.com/users/mitchlloyd/repos","events_url":"https://api.github.com/users/mitchlloyd/events{/privacy}","received_events_url":"https://api.github.com/users/mitchlloyd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mitchlloyd/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":true,"url":"https://api.github.com/repos/mitchlloyd/ember.js","forks_url":"https://api.github.com/repos/mitchlloyd/ember.js/forks","keys_url":"https://api.github.com/repos/mitchlloyd/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitchlloyd/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitchlloyd/ember.js/teams","hooks_url":"https://api.github.com/repos/mitchlloyd/ember.js/hooks","issue_events_url":"https://api.github.com/repos/mitchlloyd/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/mitchlloyd/ember.js/events","assignees_url":"https://api.github.com/repos/mitchlloyd/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/mitchlloyd/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/mitchlloyd/ember.js/tags","blobs_url":"https://api.github.com/repos/mitchlloyd/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitchlloyd/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitchlloyd/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitchlloyd/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitchlloyd/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mitchlloyd/ember.js/languages","stargazers_url":"https://api.github.com/repos/mitchlloyd/ember.js/stargazers","contributors_url":"https://api.github.com/repos/mitchlloyd/ember.js/contributors","subscribers_url":"https://api.github.com/repos/mitchlloyd/ember.js/subscribers","subscription_url":"https://api.github.com/repos/mitchlloyd/ember.js/subscription","commits_url":"https://api.github.com/repos/mitchlloyd/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitchlloyd/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitchlloyd/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitchlloyd/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitchlloyd/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/mitchlloyd/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitchlloyd/ember.js/merges","archive_url":"https://api.github.com/repos/mitchlloyd/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitchlloyd/ember.js/downloads","issues_url":"https://api.github.com/repos/mitchlloyd/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/mitchlloyd/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mitchlloyd/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mitchlloyd/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitchlloyd/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/mitchlloyd/ember.js/releases{/id}","created_at":"2013-06-15T21:23:01Z","updated_at":"2013-06-19T16:22:33Z","pushed_at":"2015-04-16T04:57:16Z","git_url":"git://github.com/mitchlloyd/ember.js.git","ssh_url":"git@github.com:mitchlloyd/ember.js.git","clone_url":"https://github.com/mitchlloyd/ember.js.git","svn_url":"https://github.com/mitchlloyd/ember.js","homepage":"http://www.emberjs.com","size":22415,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:idempotent-rerender","ref":"idempotent-rerender","sha":"9ce28453fb77ecf092ff237e1490f37114d7e66a","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1801829,"name":"ember.js","full_name":"emberjs/ember.js","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":false,"url":"https://api.github.com/repos/emberjs/ember.js","forks_url":"https://api.github.com/repos/emberjs/ember.js/forks","keys_url":"https://api.github.com/repos/emberjs/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember.js/teams","hooks_url":"https://api.github.com/repos/emberjs/ember.js/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember.js/events","assignees_url":"https://api.github.com/repos/emberjs/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember.js/tags","blobs_url":"https://api.github.com/repos/emberjs/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember.js/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember.js/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember.js/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember.js/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember.js/subscription","commits_url":"https://api.github.com/repos/emberjs/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember.js/merges","archive_url":"https://api.github.com/repos/emberjs/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember.js/downloads","issues_url":"https://api.github.com/repos/emberjs/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember.js/releases{/id}","created_at":"2011-05-25T23:39:40Z","updated_at":"2015-04-16T01:30:05Z","pushed_at":"2015-04-16T03:54:22Z","git_url":"git://github.com/emberjs/ember.js.git","ssh_url":"git@github.com:emberjs/ember.js.git","clone_url":"https://github.com/emberjs/ember.js.git","svn_url":"https://github.com/emberjs/ember.js","homepage":"http://www.emberjs.com","size":77298,"stargazers_count":13403,"watchers_count":13403,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2859,"mirror_url":null,"open_issues_count":367,"forks":2859,"open_issues":367,"watchers":13403,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/10888"},"html":{"href":"https://github.com/emberjs/ember.js/pull/10888"},"issue":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/10888"},"comments":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/10888/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/10888/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/10888/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember.js/statuses/db465aefdbe4472dc90bfdd481b7cdedd1095bda"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":34,"deletions":9,"changed_files":2}}