{"action":"created","comment":{"url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/pulls/comments/28201872","id":28201872,"diff_hunk":"@@ -161,6 +161,68 @@ node_types:\n                     create: cloudstack.cloudstack_plugin.volume.create\n                     delete: cloudstack.cloudstack_plugin.volume.delete\n \n+    cloudify.cloudstack.nodes.VpnGateway:\n+        derived_from: cloudify.nodes.Root\n+        properties:\n+            use_external_resource:\n+                default: false\n+                description: >\n+                    A boolean describing whether this resource should be\n+                    created or rather that it already exists on CloudStack\n+                    and should be used as-is.\n+\n+    cloudify.cloudstack.nodes.VpnCustomerGateway:\n+        derived_from: cloudify.nodes.Root\n+        properties:\n+            use_external_resource:\n+                default: false\n+                description: >\n+                    A boolean describing whether this resource should be\n+                    created or rather that it already exists on CloudStack\n+                    and should be used as-is.\n+            resource_id:\n+                default: ''\n+            cidr_list:\n+                default: ''\n+            ipsec_psk:\n+                default: ''\n+            esp_policy:\n+                default: '3des-md5'\n+            ike_policy:\n+                default: '3des-md5'\n+            ike_lifetime:\n+                default: 86400\n+            esp_lifetime:\n+                default: 3600\n+            dpd:\n+                default: false\n+\n+    cloudify.cloudstack.nodes.VpnConnection:\n+        derived_from: cloudify.nodes.Root\n+        properties:\n+            use_external_resource:\n+                default: false\n+                description: >\n+                    A boolean describing whether this resource should be\n+                    created or rather that it already exists on CloudStack\n+                    and should be used as-is.\n+            resource_id:\n+                default: ''\n+            passive:\n+                default: true\n+        interfaces:\n+            cloudify.interfaces.lifecycle:\n+                create:\n+                    implementation: cloudstack.cloudstack_plugin.vpn.create_vpn_connection\n+                    inputs:\n+                        vpn_gateway_id:\n+                            default: ''\n+                        vpn_customer_gateway_id:\n+                            default: ''\n+                delete:\n+                    implementation: cloudstack.cloudstack_plugin.vpn.delete_vpn_connection\n+                    inputs: {}","path":"plugin.yaml","position":73,"original_position":73,"commit_id":"80659208d06012d2f68d2006101c394d9022654b","original_commit_id":"80659208d06012d2f68d2006101c394d9022654b","user":{"login":"idanmo","id":1758680,"avatar_url":"https://avatars.githubusercontent.com/u/1758680?v=3","gravatar_id":"","url":"https://api.github.com/users/idanmo","html_url":"https://github.com/idanmo","followers_url":"https://api.github.com/users/idanmo/followers","following_url":"https://api.github.com/users/idanmo/following{/other_user}","gists_url":"https://api.github.com/users/idanmo/gists{/gist_id}","starred_url":"https://api.github.com/users/idanmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idanmo/subscriptions","organizations_url":"https://api.github.com/users/idanmo/orgs","repos_url":"https://api.github.com/users/idanmo/repos","events_url":"https://api.github.com/users/idanmo/events{/privacy}","received_events_url":"https://api.github.com/users/idanmo/received_events","type":"User","site_admin":false},"body":"There's no need to specify empty inputs\r\n","created_at":"2015-04-12T08:52:13Z","updated_at":"2015-04-12T08:52:13Z","html_url":"https://github.com/cloudify-cosmo/cloudify-cloudstack-plugin/pull/12#discussion_r28201872","pull_request_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/pulls/comments/28201872"},"html":{"href":"https://github.com/cloudify-cosmo/cloudify-cloudstack-plugin/pull/12#discussion_r28201872"},"pull_request":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/pulls/12","id":32873121,"html_url":"https://github.com/cloudify-cosmo/cloudify-cloudstack-plugin/pull/12","diff_url":"https://github.com/cloudify-cosmo/cloudify-cloudstack-plugin/pull/12.diff","patch_url":"https://github.com/cloudify-cosmo/cloudify-cloudstack-plugin/pull/12.patch","issue_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/issues/12","number":12,"state":"open","locked":false,"title":"Implements Site to Site VPN Connections","user":{"login":"av1nashs1ngh","id":4093105,"avatar_url":"https://avatars.githubusercontent.com/u/4093105?v=3","gravatar_id":"","url":"https://api.github.com/users/av1nashs1ngh","html_url":"https://github.com/av1nashs1ngh","followers_url":"https://api.github.com/users/av1nashs1ngh/followers","following_url":"https://api.github.com/users/av1nashs1ngh/following{/other_user}","gists_url":"https://api.github.com/users/av1nashs1ngh/gists{/gist_id}","starred_url":"https://api.github.com/users/av1nashs1ngh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/av1nashs1ngh/subscriptions","organizations_url":"https://api.github.com/users/av1nashs1ngh/orgs","repos_url":"https://api.github.com/users/av1nashs1ngh/repos","events_url":"https://api.github.com/users/av1nashs1ngh/events{/privacy}","received_events_url":"https://api.github.com/users/av1nashs1ngh/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nI've written some code for the CloudStack plugin to implement Site-to-Site VPN Connectivity. Could you guys please have a look at the code?\r\n\r\nThanks,\r\n\r\nAvi","created_at":"2015-04-08T15:42:34Z","updated_at":"2015-04-12T08:52:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1bd40c373cb54d6ff8d9bfe0d00287f36cc7b4a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/pulls/12/commits","review_comments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/pulls/12/comments","review_comment_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/issues/12/comments","statuses_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/statuses/80659208d06012d2f68d2006101c394d9022654b","head":{"label":"schubergphilis:VPC-Site2Site-VPN","ref":"VPC-Site2Site-VPN","sha":"80659208d06012d2f68d2006101c394d9022654b","user":{"login":"schubergphilis","id":864482,"avatar_url":"https://avatars.githubusercontent.com/u/864482?v=3","gravatar_id":"","url":"https://api.github.com/users/schubergphilis","html_url":"https://github.com/schubergphilis","followers_url":"https://api.github.com/users/schubergphilis/followers","following_url":"https://api.github.com/users/schubergphilis/following{/other_user}","gists_url":"https://api.github.com/users/schubergphilis/gists{/gist_id}","starred_url":"https://api.github.com/users/schubergphilis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schubergphilis/subscriptions","organizations_url":"https://api.github.com/users/schubergphilis/orgs","repos_url":"https://api.github.com/users/schubergphilis/repos","events_url":"https://api.github.com/users/schubergphilis/events{/privacy}","received_events_url":"https://api.github.com/users/schubergphilis/received_events","type":"Organization","site_admin":false},"repo":{"id":24587563,"name":"cloudify-cloudstack-plugin","full_name":"schubergphilis/cloudify-cloudstack-plugin","owner":{"login":"schubergphilis","id":864482,"avatar_url":"https://avatars.githubusercontent.com/u/864482?v=3","gravatar_id":"","url":"https://api.github.com/users/schubergphilis","html_url":"https://github.com/schubergphilis","followers_url":"https://api.github.com/users/schubergphilis/followers","following_url":"https://api.github.com/users/schubergphilis/following{/other_user}","gists_url":"https://api.github.com/users/schubergphilis/gists{/gist_id}","starred_url":"https://api.github.com/users/schubergphilis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schubergphilis/subscriptions","organizations_url":"https://api.github.com/users/schubergphilis/orgs","repos_url":"https://api.github.com/users/schubergphilis/repos","events_url":"https://api.github.com/users/schubergphilis/events{/privacy}","received_events_url":"https://api.github.com/users/schubergphilis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/schubergphilis/cloudify-cloudstack-plugin","description":"Cloudify plugin for CloudStack ","fork":true,"url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin","forks_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/forks","keys_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/teams","hooks_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/hooks","issue_events_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/events","assignees_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/tags","blobs_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/languages","stargazers_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/stargazers","contributors_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/contributors","subscribers_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/subscribers","subscription_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/subscription","commits_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/merges","archive_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/downloads","issues_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/labels{/name}","releases_url":"https://api.github.com/repos/schubergphilis/cloudify-cloudstack-plugin/releases{/id}","created_at":"2014-09-29T09:17:06Z","updated_at":"2015-02-18T10:10:25Z","pushed_at":"2015-04-08T15:41:28Z","git_url":"git://github.com/schubergphilis/cloudify-cloudstack-plugin.git","ssh_url":"git@github.com:schubergphilis/cloudify-cloudstack-plugin.git","clone_url":"https://github.com/schubergphilis/cloudify-cloudstack-plugin.git","svn_url":"https://github.com/schubergphilis/cloudify-cloudstack-plugin","homepage":null,"size":1152,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudify-cosmo:master","ref":"master","sha":"a5ca76d3a35db1edf2929d7b50b6c88e0088b9e5","user":{"login":"cloudify-cosmo","id":6260555,"avatar_url":"https://avatars.githubusercontent.com/u/6260555?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudify-cosmo","html_url":"https://github.com/cloudify-cosmo","followers_url":"https://api.github.com/users/cloudify-cosmo/followers","following_url":"https://api.github.com/users/cloudify-cosmo/following{/other_user}","gists_url":"https://api.github.com/users/cloudify-cosmo/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify-cosmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify-cosmo/subscriptions","organizations_url":"https://api.github.com/users/cloudify-cosmo/orgs","repos_url":"https://api.github.com/users/cloudify-cosmo/repos","events_url":"https://api.github.com/users/cloudify-cosmo/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify-cosmo/received_events","type":"Organization","site_admin":false},"repo":{"id":19569477,"name":"cloudify-cloudstack-plugin","full_name":"cloudify-cosmo/cloudify-cloudstack-plugin","owner":{"login":"cloudify-cosmo","id":6260555,"avatar_url":"https://avatars.githubusercontent.com/u/6260555?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudify-cosmo","html_url":"https://github.com/cloudify-cosmo","followers_url":"https://api.github.com/users/cloudify-cosmo/followers","following_url":"https://api.github.com/users/cloudify-cosmo/following{/other_user}","gists_url":"https://api.github.com/users/cloudify-cosmo/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify-cosmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify-cosmo/subscriptions","organizations_url":"https://api.github.com/users/cloudify-cosmo/orgs","repos_url":"https://api.github.com/users/cloudify-cosmo/repos","events_url":"https://api.github.com/users/cloudify-cosmo/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify-cosmo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudify-cosmo/cloudify-cloudstack-plugin","description":"Cloudify plugin for CloudStack ","fork":false,"url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin","forks_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/forks","keys_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/teams","hooks_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/hooks","issue_events_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/events","assignees_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/tags","blobs_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/languages","stargazers_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/stargazers","contributors_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/contributors","subscribers_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/subscribers","subscription_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/subscription","commits_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/merges","archive_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/downloads","issues_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/labels{/name}","releases_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/releases{/id}","created_at":"2014-05-08T10:23:17Z","updated_at":"2015-04-10T08:38:49Z","pushed_at":"2015-04-11T23:14:55Z","git_url":"git://github.com/cloudify-cosmo/cloudify-cloudstack-plugin.git","ssh_url":"git@github.com:cloudify-cosmo/cloudify-cloudstack-plugin.git","clone_url":"https://github.com/cloudify-cosmo/cloudify-cloudstack-plugin.git","svn_url":"https://github.com/cloudify-cosmo/cloudify-cloudstack-plugin","homepage":null,"size":1990,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/pulls/12"},"html":{"href":"https://github.com/cloudify-cosmo/cloudify-cloudstack-plugin/pull/12"},"issue":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/issues/12"},"comments":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-cloudstack-plugin/statuses/80659208d06012d2f68d2006101c394d9022654b"}}}}