{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/comments/29459145","id":29459145,"diff_hunk":"@@ -116,16 +116,16 @@ for (fn,arg) in ((:Φinv,:p),(:logΦinv,:logp))\n             else\n                 if $(fn == :Φinv)\n                     if p <= 0f0\n-                        return p == 0f0 ? -inf(Float32) : nan(Float32)\n+                        return p == 0f0 ? -Inf32 : NaN32\n                     elseif p >= 1f0 \n-                        return p == 1f0 ? inf(Float32) : nan(Float32)\n+                        return p == 1f0 ? inf(Float32) : NaN32","path":"src/specialfuns.jl","position":8,"original_position":8,"commit_id":"cbdbfed3f131509991e8a563ce9fee451d819ce2","original_commit_id":"cbdbfed3f131509991e8a563ce9fee451d819ce2","user":{"login":"simonster","id":470884,"avatar_url":"https://avatars.githubusercontent.com/u/470884?v=3","gravatar_id":"","url":"https://api.github.com/users/simonster","html_url":"https://github.com/simonster","followers_url":"https://api.github.com/users/simonster/followers","following_url":"https://api.github.com/users/simonster/following{/other_user}","gists_url":"https://api.github.com/users/simonster/gists{/gist_id}","starred_url":"https://api.github.com/users/simonster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonster/subscriptions","organizations_url":"https://api.github.com/users/simonster/orgs","repos_url":"https://api.github.com/users/simonster/repos","events_url":"https://api.github.com/users/simonster/events{/privacy}","received_events_url":"https://api.github.com/users/simonster/received_events","type":"User","site_admin":false},"body":"`inf(Float32) -> Inf32` here as well?","created_at":"2015-04-30T18:56:01Z","updated_at":"2015-04-30T18:56:01Z","html_url":"https://github.com/JuliaStats/Distributions.jl/pull/368#discussion_r29459145","pull_request_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/368","_links":{"self":{"href":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/comments/29459145"},"html":{"href":"https://github.com/JuliaStats/Distributions.jl/pull/368#discussion_r29459145"},"pull_request":{"href":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/368"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/368","id":34489715,"html_url":"https://github.com/JuliaStats/Distributions.jl/pull/368","diff_url":"https://github.com/JuliaStats/Distributions.jl/pull/368.diff","patch_url":"https://github.com/JuliaStats/Distributions.jl/pull/368.patch","issue_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/issues/368","number":368,"state":"open","locked":false,"title":"removed deprecated inf and nan","user":{"login":"zenna","id":313946,"avatar_url":"https://avatars.githubusercontent.com/u/313946?v=3","gravatar_id":"","url":"https://api.github.com/users/zenna","html_url":"https://github.com/zenna","followers_url":"https://api.github.com/users/zenna/followers","following_url":"https://api.github.com/users/zenna/following{/other_user}","gists_url":"https://api.github.com/users/zenna/gists{/gist_id}","starred_url":"https://api.github.com/users/zenna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenna/subscriptions","organizations_url":"https://api.github.com/users/zenna/orgs","repos_url":"https://api.github.com/users/zenna/repos","events_url":"https://api.github.com/users/zenna/events{/privacy}","received_events_url":"https://api.github.com/users/zenna/received_events","type":"User","site_admin":false},"body":"I was getting many warnings when using `quantile` due to\r\n\r\nInf(Float32/64)\r\nnan(Float32/64)","created_at":"2015-04-30T18:52:51Z","updated_at":"2015-04-30T18:56:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44e6c8e24ad801a7296c662459c68db8f6b9504d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/368/commits","review_comments_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/368/comments","review_comment_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/issues/368/comments","statuses_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/statuses/cbdbfed3f131509991e8a563ce9fee451d819ce2","head":{"label":"zenna:master","ref":"master","sha":"cbdbfed3f131509991e8a563ce9fee451d819ce2","user":{"login":"zenna","id":313946,"avatar_url":"https://avatars.githubusercontent.com/u/313946?v=3","gravatar_id":"","url":"https://api.github.com/users/zenna","html_url":"https://github.com/zenna","followers_url":"https://api.github.com/users/zenna/followers","following_url":"https://api.github.com/users/zenna/following{/other_user}","gists_url":"https://api.github.com/users/zenna/gists{/gist_id}","starred_url":"https://api.github.com/users/zenna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenna/subscriptions","organizations_url":"https://api.github.com/users/zenna/orgs","repos_url":"https://api.github.com/users/zenna/repos","events_url":"https://api.github.com/users/zenna/events{/privacy}","received_events_url":"https://api.github.com/users/zenna/received_events","type":"User","site_admin":false},"repo":{"id":34870450,"name":"Distributions.jl","full_name":"zenna/Distributions.jl","owner":{"login":"zenna","id":313946,"avatar_url":"https://avatars.githubusercontent.com/u/313946?v=3","gravatar_id":"","url":"https://api.github.com/users/zenna","html_url":"https://github.com/zenna","followers_url":"https://api.github.com/users/zenna/followers","following_url":"https://api.github.com/users/zenna/following{/other_user}","gists_url":"https://api.github.com/users/zenna/gists{/gist_id}","starred_url":"https://api.github.com/users/zenna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenna/subscriptions","organizations_url":"https://api.github.com/users/zenna/orgs","repos_url":"https://api.github.com/users/zenna/repos","events_url":"https://api.github.com/users/zenna/events{/privacy}","received_events_url":"https://api.github.com/users/zenna/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zenna/Distributions.jl","description":"A Julia package for probability distributions and associated functions.","fork":true,"url":"https://api.github.com/repos/zenna/Distributions.jl","forks_url":"https://api.github.com/repos/zenna/Distributions.jl/forks","keys_url":"https://api.github.com/repos/zenna/Distributions.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zenna/Distributions.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zenna/Distributions.jl/teams","hooks_url":"https://api.github.com/repos/zenna/Distributions.jl/hooks","issue_events_url":"https://api.github.com/repos/zenna/Distributions.jl/issues/events{/number}","events_url":"https://api.github.com/repos/zenna/Distributions.jl/events","assignees_url":"https://api.github.com/repos/zenna/Distributions.jl/assignees{/user}","branches_url":"https://api.github.com/repos/zenna/Distributions.jl/branches{/branch}","tags_url":"https://api.github.com/repos/zenna/Distributions.jl/tags","blobs_url":"https://api.github.com/repos/zenna/Distributions.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zenna/Distributions.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zenna/Distributions.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/zenna/Distributions.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zenna/Distributions.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/zenna/Distributions.jl/languages","stargazers_url":"https://api.github.com/repos/zenna/Distributions.jl/stargazers","contributors_url":"https://api.github.com/repos/zenna/Distributions.jl/contributors","subscribers_url":"https://api.github.com/repos/zenna/Distributions.jl/subscribers","subscription_url":"https://api.github.com/repos/zenna/Distributions.jl/subscription","commits_url":"https://api.github.com/repos/zenna/Distributions.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/zenna/Distributions.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/zenna/Distributions.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/zenna/Distributions.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/zenna/Distributions.jl/contents/{+path}","compare_url":"https://api.github.com/repos/zenna/Distributions.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zenna/Distributions.jl/merges","archive_url":"https://api.github.com/repos/zenna/Distributions.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zenna/Distributions.jl/downloads","issues_url":"https://api.github.com/repos/zenna/Distributions.jl/issues{/number}","pulls_url":"https://api.github.com/repos/zenna/Distributions.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/zenna/Distributions.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/zenna/Distributions.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zenna/Distributions.jl/labels{/name}","releases_url":"https://api.github.com/repos/zenna/Distributions.jl/releases{/id}","created_at":"2015-04-30T18:38:29Z","updated_at":"2015-04-30T18:50:03Z","pushed_at":"2015-04-30T18:50:03Z","git_url":"git://github.com/zenna/Distributions.jl.git","ssh_url":"git@github.com:zenna/Distributions.jl.git","clone_url":"https://github.com/zenna/Distributions.jl.git","svn_url":"https://github.com/zenna/Distributions.jl","homepage":"","size":5139,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaStats:master","ref":"master","sha":"dacb401cfcfc7463f69af0009497960038b25dd5","user":{"login":"JuliaStats","id":2761531,"avatar_url":"https://avatars.githubusercontent.com/u/2761531?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaStats","html_url":"https://github.com/JuliaStats","followers_url":"https://api.github.com/users/JuliaStats/followers","following_url":"https://api.github.com/users/JuliaStats/following{/other_user}","gists_url":"https://api.github.com/users/JuliaStats/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaStats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaStats/subscriptions","organizations_url":"https://api.github.com/users/JuliaStats/orgs","repos_url":"https://api.github.com/users/JuliaStats/repos","events_url":"https://api.github.com/users/JuliaStats/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaStats/received_events","type":"Organization","site_admin":false},"repo":{"id":6619192,"name":"Distributions.jl","full_name":"JuliaStats/Distributions.jl","owner":{"login":"JuliaStats","id":2761531,"avatar_url":"https://avatars.githubusercontent.com/u/2761531?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaStats","html_url":"https://github.com/JuliaStats","followers_url":"https://api.github.com/users/JuliaStats/followers","following_url":"https://api.github.com/users/JuliaStats/following{/other_user}","gists_url":"https://api.github.com/users/JuliaStats/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaStats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaStats/subscriptions","organizations_url":"https://api.github.com/users/JuliaStats/orgs","repos_url":"https://api.github.com/users/JuliaStats/repos","events_url":"https://api.github.com/users/JuliaStats/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaStats/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaStats/Distributions.jl","description":"A Julia package for probability distributions and associated functions.","fork":false,"url":"https://api.github.com/repos/JuliaStats/Distributions.jl","forks_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/forks","keys_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/teams","hooks_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/events","assignees_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/tags","blobs_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/subscription","commits_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/merges","archive_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/downloads","issues_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaStats/Distributions.jl/releases{/id}","created_at":"2012-11-09T20:01:33Z","updated_at":"2015-04-30T13:13:17Z","pushed_at":"2015-04-30T18:52:51Z","git_url":"git://github.com/JuliaStats/Distributions.jl.git","ssh_url":"git@github.com:JuliaStats/Distributions.jl.git","clone_url":"https://github.com/JuliaStats/Distributions.jl.git","svn_url":"https://github.com/JuliaStats/Distributions.jl","homepage":"","size":5139,"stargazers_count":90,"watchers_count":90,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":71,"mirror_url":null,"open_issues_count":57,"forks":71,"open_issues":57,"watchers":90,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/368"},"html":{"href":"https://github.com/JuliaStats/Distributions.jl/pull/368"},"issue":{"href":"https://api.github.com/repos/JuliaStats/Distributions.jl/issues/368"},"comments":{"href":"https://api.github.com/repos/JuliaStats/Distributions.jl/issues/368/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/368/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaStats/Distributions.jl/pulls/368/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaStats/Distributions.jl/statuses/cbdbfed3f131509991e8a563ce9fee451d819ce2"}}}}