{"action":"created","issue":{"url":"https://api.github.com/repos/juho-jaakkola/elgg-event_calendar/issues/35","labels_url":"https://api.github.com/repos/juho-jaakkola/elgg-event_calendar/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/juho-jaakkola/elgg-event_calendar/issues/35/comments","events_url":"https://api.github.com/repos/juho-jaakkola/elgg-event_calendar/issues/35/events","html_url":"https://github.com/juho-jaakkola/elgg-event_calendar/pull/35","id":65077303,"number":35,"title":"Improvements in i18n support","user":{"login":"iionly","id":1773681,"avatar_url":"https://avatars.githubusercontent.com/u/1773681?v=3","gravatar_id":"","url":"https://api.github.com/users/iionly","html_url":"https://github.com/iionly","followers_url":"https://api.github.com/users/iionly/followers","following_url":"https://api.github.com/users/iionly/following{/other_user}","gists_url":"https://api.github.com/users/iionly/gists{/gist_id}","starred_url":"https://api.github.com/users/iionly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iionly/subscriptions","organizations_url":"https://api.github.com/users/iionly/orgs","repos_url":"https://api.github.com/users/iionly/repos","events_url":"https://api.github.com/users/iionly/events{/privacy}","received_events_url":"https://api.github.com/users/iionly/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2015-03-29T16:51:15Z","updated_at":"2015-04-19T18:22:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/juho-jaakkola/elgg-event_calendar/pulls/35","html_url":"https://github.com/juho-jaakkola/elgg-event_calendar/pull/35","diff_url":"https://github.com/juho-jaakkola/elgg-event_calendar/pull/35.diff","patch_url":"https://github.com/juho-jaakkola/elgg-event_calendar/pull/35.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/juho-jaakkola/elgg-event_calendar/issues/comments/94303299","html_url":"https://github.com/juho-jaakkola/elgg-event_calendar/pull/35#issuecomment-94303299","issue_url":"https://api.github.com/repos/juho-jaakkola/elgg-event_calendar/issues/35","id":94303299,"user":{"login":"iionly","id":1773681,"avatar_url":"https://avatars.githubusercontent.com/u/1773681?v=3","gravatar_id":"","url":"https://api.github.com/users/iionly","html_url":"https://github.com/iionly","followers_url":"https://api.github.com/users/iionly/followers","following_url":"https://api.github.com/users/iionly/following{/other_user}","gists_url":"https://api.github.com/users/iionly/gists{/gist_id}","starred_url":"https://api.github.com/users/iionly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iionly/subscriptions","organizations_url":"https://api.github.com/users/iionly/orgs","repos_url":"https://api.github.com/users/iionly/repos","events_url":"https://api.github.com/users/iionly/events{/privacy}","received_events_url":"https://api.github.com/users/iionly/received_events","type":"User","site_admin":false},"created_at":"2015-04-19T18:22:55Z","updated_at":"2015-04-19T18:22:55Z","body":"I'm still not really sure about usage of setlocale(). On the one hand, it's of course not difficult to implement it within the plugin. On the other hand, I still think it can get complicated for users to configure it (different encodings) and likely even impossible in some cases (I don't think you would be able to add missing locales on a shared server). Additionally, I'm still not sure if setlocale() might cause conflicts with other scripts (after reading the warning on the php docs page and also some comments about it).\r\n\r\nJS might be a possibility (maybe using jquere datepicker.parseDate might work, too).\r\n\r\nWould it be possible to decide on this separately? The problem is that any change I would like to make would involve modifications in model.php. And I really don't want to constantly rebase if I make these PRs in parallel.\r\n\r\nAnother possibility could be to not implement much more in terms of i18n for now but wait for Elgg 2.0 (which I'm sure will require some rewrites anyway). It looks like Elgg 2.0 might bring some changes / improvements in terms of i18n and language strings support. If these changes get implemented it would be much easier to realize different date formats."}}