{"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka/pulls/comments/29320907","id":29320907,"diff_hunk":"@@ -18,8 +18,10 @@ import akka.event.Logging.simpleName\n  */\n private[akka] object StreamLayout {\n \n-  // compile-time constant\n-  final val Debug = true\n+  // Turn this on to add run-time checks about Stream consistency during\n+  // stream operations.","path":"akka-stream/src/main/scala/akka/stream/impl/StreamLayout.scala","position":7,"original_position":7,"commit_id":"3be66a9d5869eb38faad8c35341e7eaf8cebb0d6","original_commit_id":"3be66a9d5869eb38faad8c35341e7eaf8cebb0d6","user":{"login":"drewhk","id":932285,"avatar_url":"https://avatars.githubusercontent.com/u/932285?v=3","gravatar_id":"","url":"https://api.github.com/users/drewhk","html_url":"https://github.com/drewhk","followers_url":"https://api.github.com/users/drewhk/followers","following_url":"https://api.github.com/users/drewhk/following{/other_user}","gists_url":"https://api.github.com/users/drewhk/gists{/gist_id}","starred_url":"https://api.github.com/users/drewhk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewhk/subscriptions","organizations_url":"https://api.github.com/users/drewhk/orgs","repos_url":"https://api.github.com/users/drewhk/repos","events_url":"https://api.github.com/users/drewhk/events{/privacy}","received_events_url":"https://api.github.com/users/drewhk/received_events","type":"User","site_admin":false},"body":"it only validates during materialization, not during opertions (unless a stream operation does materialization of streams of course)","created_at":"2015-04-29T09:22:51Z","updated_at":"2015-04-29T09:22:51Z","html_url":"https://github.com/akka/akka/pull/17332#discussion_r29320907","pull_request_url":"https://api.github.com/repos/akka/akka/pulls/17332","_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/29320907"},"html":{"href":"https://github.com/akka/akka/pull/17332#discussion_r29320907"},"pull_request":{"href":"https://api.github.com/repos/akka/akka/pulls/17332"}}},"pull_request":{"url":"https://api.github.com/repos/akka/akka/pulls/17332","id":34286511,"html_url":"https://github.com/akka/akka/pull/17332","diff_url":"https://github.com/akka/akka/pull/17332.diff","patch_url":"https://github.com/akka/akka/pull/17332.patch","issue_url":"https://api.github.com/repos/akka/akka/issues/17332","number":17332,"state":"open","locked":false,"title":"StreamLayout debug mode","user":{"login":"RichardBradley","id":1265780,"avatar_url":"https://avatars.githubusercontent.com/u/1265780?v=3","gravatar_id":"","url":"https://api.github.com/users/RichardBradley","html_url":"https://github.com/RichardBradley","followers_url":"https://api.github.com/users/RichardBradley/followers","following_url":"https://api.github.com/users/RichardBradley/following{/other_user}","gists_url":"https://api.github.com/users/RichardBradley/gists{/gist_id}","starred_url":"https://api.github.com/users/RichardBradley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RichardBradley/subscriptions","organizations_url":"https://api.github.com/users/RichardBradley/orgs","repos_url":"https://api.github.com/users/RichardBradley/repos","events_url":"https://api.github.com/users/RichardBradley/events{/privacy}","received_events_url":"https://api.github.com/users/RichardBradley/received_events","type":"User","site_admin":false},"body":"Is this \"debug\" val on intentionally?\r\n\r\nI know you haven't officially addressed HTTP performance yet, but we have been doing some perf profiling of our Akka HTTP based app, and the \"validate()\" calls behind this \"debug\" flag are very expensive at runtime.\r\n\r\nI can't find any warnings from the validate() calls in our logs, so it seems like this isn't needed at runtime.\r\n\r\nUnless I'm missing something, this should be safe to turn off now.","created_at":"2015-04-28T16:41:03Z","updated_at":"2015-04-29T09:22:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c50087c7424a98e6131f70953f0b3528f580a981","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka/pulls/17332/commits","review_comments_url":"https://api.github.com/repos/akka/akka/pulls/17332/comments","review_comment_url":"https://api.github.com/repos/akka/akka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/akka/issues/17332/comments","statuses_url":"https://api.github.com/repos/akka/akka/statuses/3be66a9d5869eb38faad8c35341e7eaf8cebb0d6","head":{"label":"RichardBradley:streamlayout-debug-mode","ref":"streamlayout-debug-mode","sha":"3be66a9d5869eb38faad8c35341e7eaf8cebb0d6","user":{"login":"RichardBradley","id":1265780,"avatar_url":"https://avatars.githubusercontent.com/u/1265780?v=3","gravatar_id":"","url":"https://api.github.com/users/RichardBradley","html_url":"https://github.com/RichardBradley","followers_url":"https://api.github.com/users/RichardBradley/followers","following_url":"https://api.github.com/users/RichardBradley/following{/other_user}","gists_url":"https://api.github.com/users/RichardBradley/gists{/gist_id}","starred_url":"https://api.github.com/users/RichardBradley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RichardBradley/subscriptions","organizations_url":"https://api.github.com/users/RichardBradley/orgs","repos_url":"https://api.github.com/users/RichardBradley/repos","events_url":"https://api.github.com/users/RichardBradley/events{/privacy}","received_events_url":"https://api.github.com/users/RichardBradley/received_events","type":"User","site_admin":false},"repo":{"id":32083642,"name":"akka","full_name":"RichardBradley/akka","owner":{"login":"RichardBradley","id":1265780,"avatar_url":"https://avatars.githubusercontent.com/u/1265780?v=3","gravatar_id":"","url":"https://api.github.com/users/RichardBradley","html_url":"https://github.com/RichardBradley","followers_url":"https://api.github.com/users/RichardBradley/followers","following_url":"https://api.github.com/users/RichardBradley/following{/other_user}","gists_url":"https://api.github.com/users/RichardBradley/gists{/gist_id}","starred_url":"https://api.github.com/users/RichardBradley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RichardBradley/subscriptions","organizations_url":"https://api.github.com/users/RichardBradley/orgs","repos_url":"https://api.github.com/users/RichardBradley/repos","events_url":"https://api.github.com/users/RichardBradley/events{/privacy}","received_events_url":"https://api.github.com/users/RichardBradley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RichardBradley/akka","description":"Akka Project","fork":true,"url":"https://api.github.com/repos/RichardBradley/akka","forks_url":"https://api.github.com/repos/RichardBradley/akka/forks","keys_url":"https://api.github.com/repos/RichardBradley/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RichardBradley/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RichardBradley/akka/teams","hooks_url":"https://api.github.com/repos/RichardBradley/akka/hooks","issue_events_url":"https://api.github.com/repos/RichardBradley/akka/issues/events{/number}","events_url":"https://api.github.com/repos/RichardBradley/akka/events","assignees_url":"https://api.github.com/repos/RichardBradley/akka/assignees{/user}","branches_url":"https://api.github.com/repos/RichardBradley/akka/branches{/branch}","tags_url":"https://api.github.com/repos/RichardBradley/akka/tags","blobs_url":"https://api.github.com/repos/RichardBradley/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RichardBradley/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RichardBradley/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/RichardBradley/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RichardBradley/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/RichardBradley/akka/languages","stargazers_url":"https://api.github.com/repos/RichardBradley/akka/stargazers","contributors_url":"https://api.github.com/repos/RichardBradley/akka/contributors","subscribers_url":"https://api.github.com/repos/RichardBradley/akka/subscribers","subscription_url":"https://api.github.com/repos/RichardBradley/akka/subscription","commits_url":"https://api.github.com/repos/RichardBradley/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/RichardBradley/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/RichardBradley/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/RichardBradley/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/RichardBradley/akka/contents/{+path}","compare_url":"https://api.github.com/repos/RichardBradley/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RichardBradley/akka/merges","archive_url":"https://api.github.com/repos/RichardBradley/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RichardBradley/akka/downloads","issues_url":"https://api.github.com/repos/RichardBradley/akka/issues{/number}","pulls_url":"https://api.github.com/repos/RichardBradley/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/RichardBradley/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/RichardBradley/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RichardBradley/akka/labels{/name}","releases_url":"https://api.github.com/repos/RichardBradley/akka/releases{/id}","created_at":"2015-03-12T15:11:39Z","updated_at":"2015-03-12T15:11:46Z","pushed_at":"2015-04-28T16:41:38Z","git_url":"git://github.com/RichardBradley/akka.git","ssh_url":"git@github.com:RichardBradley/akka.git","clone_url":"https://github.com/RichardBradley/akka.git","svn_url":"https://github.com/RichardBradley/akka","homepage":"http://akka.io","size":161409,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"akka:release-2.3-dev","ref":"release-2.3-dev","sha":"a47667cf8c8c332c633aa9dab6e3354f9a548931","user":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"name":"akka","full_name":"akka/akka","owner":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka","description":"Akka Project","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","created_at":"2009-02-16T12:51:54Z","updated_at":"2015-04-29T08:44:11Z","pushed_at":"2015-04-29T07:58:50Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":249472,"stargazers_count":3883,"watchers_count":3883,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1116,"mirror_url":null,"open_issues_count":630,"forks":1116,"open_issues":630,"watchers":3883,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/17332"},"html":{"href":"https://github.com/akka/akka/pull/17332"},"issue":{"href":"https://api.github.com/repos/akka/akka/issues/17332"},"comments":{"href":"https://api.github.com/repos/akka/akka/issues/17332/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka/pulls/17332/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/akka/pulls/17332/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka/statuses/3be66a9d5869eb38faad8c35341e7eaf8cebb0d6"}}}}