{"action":"created","comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/39719463","id":39719463,"diff_hunk":"@@ -35,7 +35,7 @@ bloom_t *bloom_new(size_t size, size_t num_hashes, ...)\n     }\n \n     /* Allocate Bloom array */\n-    if (!(bloom->a = calloc(ROUND(size), sizeof(char)))) {\n+    if (!(bloom->a = calloc(sizeof(uint8_t), ROUND(size)))) {","path":"sys/bloom/bloom.c","position":5,"original_position":5,"commit_id":"1ff41432e08b3190bc397253a065ad2dd7f9c763","original_commit_id":"1ff41432e08b3190bc397253a065ad2dd7f9c763","user":{"login":"cgundogan","id":739129,"avatar_url":"https://avatars.githubusercontent.com/u/739129?v=3","gravatar_id":"","url":"https://api.github.com/users/cgundogan","html_url":"https://github.com/cgundogan","followers_url":"https://api.github.com/users/cgundogan/followers","following_url":"https://api.github.com/users/cgundogan/following{/other_user}","gists_url":"https://api.github.com/users/cgundogan/gists{/gist_id}","starred_url":"https://api.github.com/users/cgundogan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgundogan/subscriptions","organizations_url":"https://api.github.com/users/cgundogan/orgs","repos_url":"https://api.github.com/users/cgundogan/repos","events_url":"https://api.github.com/users/cgundogan/events{/privacy}","received_events_url":"https://api.github.com/users/cgundogan/received_events","type":"User","site_admin":false},"body":"While it makes not really a difference which order you choose here, I'd say the current order is the semantically more correct one. The bloom filter buffer operates on `nmemb` different `uint8_t`s, hence `size = sizeof(uint8_t)` and `nmemb = ROUND(size)`","created_at":"2015-09-17T08:02:06Z","updated_at":"2015-09-17T08:02:06Z","html_url":"https://github.com/RIOT-OS/RIOT/pull/3699#discussion_r39719463","pull_request_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3699","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/39719463"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/3699#discussion_r39719463"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3699"}}},"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3699","id":43131105,"html_url":"https://github.com/RIOT-OS/RIOT/pull/3699","diff_url":"https://github.com/RIOT-OS/RIOT/pull/3699.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/3699.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3699","number":3699,"state":"open","locked":false,"title":"clean up: fix some scan-build warnings","user":{"login":"Kijewski","id":136776,"avatar_url":"https://avatars.githubusercontent.com/u/136776?v=3","gravatar_id":"","url":"https://api.github.com/users/Kijewski","html_url":"https://github.com/Kijewski","followers_url":"https://api.github.com/users/Kijewski/followers","following_url":"https://api.github.com/users/Kijewski/following{/other_user}","gists_url":"https://api.github.com/users/Kijewski/gists{/gist_id}","starred_url":"https://api.github.com/users/Kijewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kijewski/subscriptions","organizations_url":"https://api.github.com/users/Kijewski/orgs","repos_url":"https://api.github.com/users/Kijewski/repos","events_url":"https://api.github.com/users/Kijewski/events{/privacy}","received_events_url":"https://api.github.com/users/Kijewski/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-08-23T23:37:07Z","updated_at":"2015-09-17T08:02:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae699983c5ed97e7082c32b15ea60b4ffe6d9c39","assignee":{"login":"gebart","id":317506,"avatar_url":"https://avatars.githubusercontent.com/u/317506?v=3","gravatar_id":"","url":"https://api.github.com/users/gebart","html_url":"https://github.com/gebart","followers_url":"https://api.github.com/users/gebart/followers","following_url":"https://api.github.com/users/gebart/following{/other_user}","gists_url":"https://api.github.com/users/gebart/gists{/gist_id}","starred_url":"https://api.github.com/users/gebart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gebart/subscriptions","organizations_url":"https://api.github.com/users/gebart/orgs","repos_url":"https://api.github.com/users/gebart/repos","events_url":"https://api.github.com/users/gebart/events{/privacy}","received_events_url":"https://api.github.com/users/gebart/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones/12","html_url":"https://github.com/RIOT-OS/RIOT/milestones/Release%202015.09","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones/12/labels","id":1088995,"number":12,"title":"Release 2015.09","description":"This release aims mainly to include the gnrc network stack as the new default IPv6/6LoWPAN stack.","creator":{"login":"OlegHahm","id":1590423,"avatar_url":"https://avatars.githubusercontent.com/u/1590423?v=3","gravatar_id":"","url":"https://api.github.com/users/OlegHahm","html_url":"https://github.com/OlegHahm","followers_url":"https://api.github.com/users/OlegHahm/followers","following_url":"https://api.github.com/users/OlegHahm/following{/other_user}","gists_url":"https://api.github.com/users/OlegHahm/gists{/gist_id}","starred_url":"https://api.github.com/users/OlegHahm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OlegHahm/subscriptions","organizations_url":"https://api.github.com/users/OlegHahm/orgs","repos_url":"https://api.github.com/users/OlegHahm/repos","events_url":"https://api.github.com/users/OlegHahm/events{/privacy}","received_events_url":"https://api.github.com/users/OlegHahm/received_events","type":"User","site_admin":false},"open_issues":47,"closed_issues":488,"state":"open","created_at":"2015-04-29T10:11:27Z","updated_at":"2015-09-17T01:39:36Z","due_on":"2015-09-17T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3699/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3699/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3699/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/1ff41432e08b3190bc397253a065ad2dd7f9c763","head":{"label":"Kijewski:some-scan-build-warnings","ref":"some-scan-build-warnings","sha":"1ff41432e08b3190bc397253a065ad2dd7f9c763","user":{"login":"Kijewski","id":136776,"avatar_url":"https://avatars.githubusercontent.com/u/136776?v=3","gravatar_id":"","url":"https://api.github.com/users/Kijewski","html_url":"https://github.com/Kijewski","followers_url":"https://api.github.com/users/Kijewski/followers","following_url":"https://api.github.com/users/Kijewski/following{/other_user}","gists_url":"https://api.github.com/users/Kijewski/gists{/gist_id}","starred_url":"https://api.github.com/users/Kijewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kijewski/subscriptions","organizations_url":"https://api.github.com/users/Kijewski/orgs","repos_url":"https://api.github.com/users/Kijewski/repos","events_url":"https://api.github.com/users/Kijewski/events{/privacy}","received_events_url":"https://api.github.com/users/Kijewski/received_events","type":"User","site_admin":false},"repo":{"id":10765176,"name":"RIOT","full_name":"Kijewski/RIOT","owner":{"login":"Kijewski","id":136776,"avatar_url":"https://avatars.githubusercontent.com/u/136776?v=3","gravatar_id":"","url":"https://api.github.com/users/Kijewski","html_url":"https://github.com/Kijewski","followers_url":"https://api.github.com/users/Kijewski/followers","following_url":"https://api.github.com/users/Kijewski/following{/other_user}","gists_url":"https://api.github.com/users/Kijewski/gists{/gist_id}","starred_url":"https://api.github.com/users/Kijewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kijewski/subscriptions","organizations_url":"https://api.github.com/users/Kijewski/orgs","repos_url":"https://api.github.com/users/Kijewski/repos","events_url":"https://api.github.com/users/Kijewski/events{/privacy}","received_events_url":"https://api.github.com/users/Kijewski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Kijewski/RIOT","description":"RIOT OS -  The revolutionary IoT OS","fork":true,"url":"https://api.github.com/repos/Kijewski/RIOT","forks_url":"https://api.github.com/repos/Kijewski/RIOT/forks","keys_url":"https://api.github.com/repos/Kijewski/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kijewski/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kijewski/RIOT/teams","hooks_url":"https://api.github.com/repos/Kijewski/RIOT/hooks","issue_events_url":"https://api.github.com/repos/Kijewski/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/Kijewski/RIOT/events","assignees_url":"https://api.github.com/repos/Kijewski/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/Kijewski/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/Kijewski/RIOT/tags","blobs_url":"https://api.github.com/repos/Kijewski/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kijewski/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kijewski/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kijewski/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kijewski/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/Kijewski/RIOT/languages","stargazers_url":"https://api.github.com/repos/Kijewski/RIOT/stargazers","contributors_url":"https://api.github.com/repos/Kijewski/RIOT/contributors","subscribers_url":"https://api.github.com/repos/Kijewski/RIOT/subscribers","subscription_url":"https://api.github.com/repos/Kijewski/RIOT/subscription","commits_url":"https://api.github.com/repos/Kijewski/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kijewski/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kijewski/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kijewski/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kijewski/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/Kijewski/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kijewski/RIOT/merges","archive_url":"https://api.github.com/repos/Kijewski/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kijewski/RIOT/downloads","issues_url":"https://api.github.com/repos/Kijewski/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/Kijewski/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/Kijewski/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/Kijewski/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kijewski/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/Kijewski/RIOT/releases{/id}","created_at":"2013-06-18T14:25:14Z","updated_at":"2014-12-11T21:14:01Z","pushed_at":"2015-08-29T23:37:37Z","git_url":"git://github.com/Kijewski/RIOT.git","ssh_url":"git@github.com:Kijewski/RIOT.git","clone_url":"https://github.com/Kijewski/RIOT.git","svn_url":"https://github.com/Kijewski/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":23877,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"014939805e042c5b013231843d1c0a53b21fab8a","user":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars.githubusercontent.com/u/3079480?v=3","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"name":"RIOT","full_name":"RIOT-OS/RIOT","owner":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars.githubusercontent.com/u/3079480?v=3","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT -  The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","created_at":"2012-12-29T20:38:40Z","updated_at":"2015-09-16T16:16:44Z","pushed_at":"2015-09-17T07:47:23Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":127947,"stargazers_count":500,"watchers_count":500,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":383,"mirror_url":null,"open_issues_count":371,"forks":383,"open_issues":371,"watchers":500,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3699"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/3699"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3699"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3699/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3699/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3699/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/1ff41432e08b3190bc397253a065ad2dd7f9c763"}}}}