{"action":"created","issue":{"url":"https://api.github.com/repos/google/double-conversion/issues/15","labels_url":"https://api.github.com/repos/google/double-conversion/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/google/double-conversion/issues/15/comments","events_url":"https://api.github.com/repos/google/double-conversion/issues/15/events","html_url":"https://github.com/google/double-conversion/pull/15","id":97242586,"number":15,"title":"Fix compiler warning on GCC 5.1.0","user":{"login":"davisp","id":19929,"avatar_url":"https://avatars.githubusercontent.com/u/19929?v=3","gravatar_id":"","url":"https://api.github.com/users/davisp","html_url":"https://github.com/davisp","followers_url":"https://api.github.com/users/davisp/followers","following_url":"https://api.github.com/users/davisp/following{/other_user}","gists_url":"https://api.github.com/users/davisp/gists{/gist_id}","starred_url":"https://api.github.com/users/davisp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davisp/subscriptions","organizations_url":"https://api.github.com/users/davisp/orgs","repos_url":"https://api.github.com/users/davisp/repos","events_url":"https://api.github.com/users/davisp/events{/privacy}","received_events_url":"https://api.github.com/users/davisp/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-07-25T17:44:14Z","updated_at":"2015-10-30T23:49:54Z","closed_at":"2015-09-03T09:55:49Z","pull_request":{"url":"https://api.github.com/repos/google/double-conversion/pulls/15","html_url":"https://github.com/google/double-conversion/pull/15","diff_url":"https://github.com/google/double-conversion/pull/15.diff","patch_url":"https://github.com/google/double-conversion/pull/15.patch"},"body":"I've gotten a number of reports on this in a project that vendors double-conversion. I've pasted an example of compiling with -Werror below. The fix is straight forward.\r\n\r\n<pre>\r\n==> jiffy (compile)\r\n...\r\nCompiling c_src/double-conversion/bignum.cc\r\nc_src/double-conversion/bignum.cc: In member function ‘void double_conversion::Bignum::AssignDecimalString(double_conversion::Vector<const char>)’:\r\nc_src/double-conversion/bignum.cc:101:6: error: assuming signed overflow does not occur when assuming that (X + c) < X is always false [-Werror=strict-overflow]\r\n void Bignum::AssignDecimalString(Vector<const char> value) {\r\n      ^\r\ncc1plus: all warnings being treated as errors\r\nERROR: c++ -c  -g -Wall -Werror -O3 -g -Wall -fPIC  -I/usr/lib/erlang/lib/erl_interface-3.7.20/include -I/usr/lib/erlang/erts-6.4/include   c_src/double-conversion/bignum.cc -o c_src/double-conversion/bignum.o failed with error: 1 and output:\r\nc_src/double-conversion/bignum.cc: In member function ‘void double_conversion::Bignum::AssignDecimalString(double_conversion::Vector<const char>)’:\r\nc_src/double-conversion/bignum.cc:101:6: error: assuming signed overflow does not occur when assuming that (X + c) < X is always false [-Werror=strict-overflow]\r\n void Bignum::AssignDecimalString(Vector<const char> value) {\r\n      ^\r\ncc1plus: all warnings being treated as errors\r\n</pre>\r\n\r\n<pre>\r\ngcc -v\r\nUsing built-in specs.\r\nCOLLECT_GCC=gcc\r\nCOLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-unknown-linux-gnu/5.1.0/lto-wrapper\r\nTarget: x86_64-unknown-linux-gnu\r\nConfigured with: /build/gcc-multilib/src/gcc-5.1.0/configure --prefix=/usr --libdir=/usr/lib --libexecdir=/usr/lib --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=https://bugs.archlinux.org/ --enable-languages=c,c++,ada,fortran,go,lto,objc,obj-c++ --enable-shared --enable-threads=posix --with-system-zlib --with-isl --enable-__cxa_atexit --disable-libunwind-exceptions --enable-clocale=gnu --disable-libstdcxx-pch --disable-libssp --enable-gnu-unique-object --enable-linker-build-id --enable-lto --enable-plugin --enable-install-libiberty --with-linker-hash-style=gnu --enable-gnu-indirect-function --enable-multilib --disable-werror --with-multilib-list=m32,m64,mx32 --enable-checking=release --enable-libmpx --with-default-libstdcxx-abi=c++98\r\nThread model: posix\r\ngcc version 5.1.0 (GCC)\r\n</pre>"},"comment":{"url":"https://api.github.com/repos/google/double-conversion/issues/comments/152675275","html_url":"https://github.com/google/double-conversion/pull/15#issuecomment-152675275","issue_url":"https://api.github.com/repos/google/double-conversion/issues/15","id":152675275,"user":{"login":"floitschG","id":8631949,"avatar_url":"https://avatars.githubusercontent.com/u/8631949?v=3","gravatar_id":"","url":"https://api.github.com/users/floitschG","html_url":"https://github.com/floitschG","followers_url":"https://api.github.com/users/floitschG/followers","following_url":"https://api.github.com/users/floitschG/following{/other_user}","gists_url":"https://api.github.com/users/floitschG/gists{/gist_id}","starred_url":"https://api.github.com/users/floitschG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floitschG/subscriptions","organizations_url":"https://api.github.com/users/floitschG/orgs","repos_url":"https://api.github.com/users/floitschG/repos","events_url":"https://api.github.com/users/floitschG/events{/privacy}","received_events_url":"https://api.github.com/users/floitschG/received_events","type":"User","site_admin":false},"created_at":"2015-10-30T23:49:54Z","updated_at":"2015-10-30T23:49:54Z","body":"Sorry to reopen this after several weeks...\r\nCould you please sign Google's CLA [0].\r\nI thought that small patches don't need to go through that process, but apparently I was wrong... :(\r\nThanks.\r\n\r\n[0] https://cla.developers.google.com/about/google-individual"}}