{"action":"created","comment":{"url":"https://api.github.com/repos/este/este/pulls/comments/33913371","id":33913371,"diff_hunk":"@@ -66,5 +66,5 @@ gulp.task('default', (done) => {\n   if (args.production)\n     runSequence('server', done);\n   else\n-    runSequence('server', 'karma-dev', done);\n+    runSequence('server', done);","path":"gulpfile.babel.js","position":5,"original_position":5,"commit_id":"7deb27211cf6001bed5f4e80889f3f98300042be","original_commit_id":"7deb27211cf6001bed5f4e80889f3f98300042be","user":{"login":"XeeD","id":17111,"avatar_url":"https://avatars.githubusercontent.com/u/17111?v=3","gravatar_id":"","url":"https://api.github.com/users/XeeD","html_url":"https://github.com/XeeD","followers_url":"https://api.github.com/users/XeeD/followers","following_url":"https://api.github.com/users/XeeD/following{/other_user}","gists_url":"https://api.github.com/users/XeeD/gists{/gist_id}","starred_url":"https://api.github.com/users/XeeD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XeeD/subscriptions","organizations_url":"https://api.github.com/users/XeeD/orgs","repos_url":"https://api.github.com/users/XeeD/repos","events_url":"https://api.github.com/users/XeeD/events{/privacy}","received_events_url":"https://api.github.com/users/XeeD/received_events","type":"User","site_admin":false},"body":"I'll remove this change from the PR before merging :smile: \r\n\r\nIt opens up new browser window and somehow OS X thinks it's the primary browser window and opens all links in it. ","created_at":"2015-07-06T08:16:54Z","updated_at":"2015-07-06T08:16:54Z","html_url":"https://github.com/este/este/pull/325#discussion_r33913371","pull_request_url":"https://api.github.com/repos/este/este/pulls/325","_links":{"self":{"href":"https://api.github.com/repos/este/este/pulls/comments/33913371"},"html":{"href":"https://github.com/este/este/pull/325#discussion_r33913371"},"pull_request":{"href":"https://api.github.com/repos/este/este/pulls/325"}}},"pull_request":{"url":"https://api.github.com/repos/este/este/pulls/325","id":39220513,"html_url":"https://github.com/este/este/pull/325","diff_url":"https://github.com/este/este/pull/325.diff","patch_url":"https://github.com/este/este/pull/325.patch","issue_url":"https://api.github.com/repos/este/este/issues/325","number":325,"state":"open","locked":false,"title":"Upgrade to react-router 1.0.0-beta1","user":{"login":"XeeD","id":17111,"avatar_url":"https://avatars.githubusercontent.com/u/17111?v=3","gravatar_id":"","url":"https://api.github.com/users/XeeD","html_url":"https://github.com/XeeD","followers_url":"https://api.github.com/users/XeeD/followers","following_url":"https://api.github.com/users/XeeD/following{/other_user}","gists_url":"https://api.github.com/users/XeeD/gists{/gist_id}","starred_url":"https://api.github.com/users/XeeD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XeeD/subscriptions","organizations_url":"https://api.github.com/users/XeeD/orgs","repos_url":"https://api.github.com/users/XeeD/repos","events_url":"https://api.github.com/users/XeeD/events{/privacy}","received_events_url":"https://api.github.com/users/XeeD/received_events","type":"User","site_admin":false},"body":"I am pretty excited about the possibilities that the new Router gives us after I saw the presentation on ReactEurope. I know that is it still beta, but I would like to migrate Este to it ASAP (we could have a branch supporting it until it is out of beta). I've already spent a few hours on this - not as easy as I thought. The new version includes a lot of changes. The whole react-router library feels \"cleaner\" and much more mature then previous version.\r\n\r\nThis is still WIP. I was able to make server rendering work and render the app on client side as well.\r\n\r\nTODO:\r\n- [ ] Error handling (onAbort, onError)\r\n- [ ] Check if `pureComponentLastPath` is still needed\r\n- [ ] `transition.to` does not work when rendering on server\r\n- [ ] Remove child cloning and setState from App component (waiting for ideas from @steida and @grabbou)\r\n- [x] Remove `contextTypes` and use passed props.\r\n- [x] What to do with failed prop checks (all components under App are rendered twice)?\r\n- [x] Migrate from `componentWillTransitionTo` to `onEnter`\r\n- [x] Named routes are gone (or I missed something?), use the pathnames directly when rendering `Link`\r\n- [x] Rename some vars in `frontend/render` (Handler) to match their content\r\n\r\nTODO later: :wink:\r\n- Maybe Include example of [`AsyncProps`](https://github.com/rackt/react-router/tree/dec7558fb01eb685d9a023b13dfc149de600bd01/examples/async-data) in Este?\r\n\r\n- I do not much like the way I am passing the props to components from App (although it is taken from [router's examples](https://github.com/rackt/react-router/blob/dec7558fb01eb685d9a023b13dfc149de600bd01/examples/passing-props-to-children/app.js). ~~I think I have a better way for this, but I'll try to explore that in different PR.~~ We need to do this in this PR, otherwise we will be getting errors from Route handlers (they will be rendered twice, first with props, then without)\r\n\r\n- Add example of async loading of modules\r\n\r\n","created_at":"2015-07-05T13:01:19Z","updated_at":"2015-07-06T08:16:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8aaa236e9ca361eb7675fa443d0d34da539e961d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/este/este/pulls/325/commits","review_comments_url":"https://api.github.com/repos/este/este/pulls/325/comments","review_comment_url":"https://api.github.com/repos/este/este/pulls/comments{/number}","comments_url":"https://api.github.com/repos/este/este/issues/325/comments","statuses_url":"https://api.github.com/repos/este/este/statuses/7deb27211cf6001bed5f4e80889f3f98300042be","head":{"label":"XeeD:react-router-1.0","ref":"react-router-1.0","sha":"7deb27211cf6001bed5f4e80889f3f98300042be","user":{"login":"XeeD","id":17111,"avatar_url":"https://avatars.githubusercontent.com/u/17111?v=3","gravatar_id":"","url":"https://api.github.com/users/XeeD","html_url":"https://github.com/XeeD","followers_url":"https://api.github.com/users/XeeD/followers","following_url":"https://api.github.com/users/XeeD/following{/other_user}","gists_url":"https://api.github.com/users/XeeD/gists{/gist_id}","starred_url":"https://api.github.com/users/XeeD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XeeD/subscriptions","organizations_url":"https://api.github.com/users/XeeD/orgs","repos_url":"https://api.github.com/users/XeeD/repos","events_url":"https://api.github.com/users/XeeD/events{/privacy}","received_events_url":"https://api.github.com/users/XeeD/received_events","type":"User","site_admin":false},"repo":{"id":35564518,"name":"este","full_name":"XeeD/este","owner":{"login":"XeeD","id":17111,"avatar_url":"https://avatars.githubusercontent.com/u/17111?v=3","gravatar_id":"","url":"https://api.github.com/users/XeeD","html_url":"https://github.com/XeeD","followers_url":"https://api.github.com/users/XeeD/followers","following_url":"https://api.github.com/users/XeeD/following{/other_user}","gists_url":"https://api.github.com/users/XeeD/gists{/gist_id}","starred_url":"https://api.github.com/users/XeeD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XeeD/subscriptions","organizations_url":"https://api.github.com/users/XeeD/orgs","repos_url":"https://api.github.com/users/XeeD/repos","events_url":"https://api.github.com/users/XeeD/events{/privacy}","received_events_url":"https://api.github.com/users/XeeD/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/XeeD/este","description":"The most complete React/Flux dev stack and starter kit for isomorphic functional web apps","fork":true,"url":"https://api.github.com/repos/XeeD/este","forks_url":"https://api.github.com/repos/XeeD/este/forks","keys_url":"https://api.github.com/repos/XeeD/este/keys{/key_id}","collaborators_url":"https://api.github.com/repos/XeeD/este/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/XeeD/este/teams","hooks_url":"https://api.github.com/repos/XeeD/este/hooks","issue_events_url":"https://api.github.com/repos/XeeD/este/issues/events{/number}","events_url":"https://api.github.com/repos/XeeD/este/events","assignees_url":"https://api.github.com/repos/XeeD/este/assignees{/user}","branches_url":"https://api.github.com/repos/XeeD/este/branches{/branch}","tags_url":"https://api.github.com/repos/XeeD/este/tags","blobs_url":"https://api.github.com/repos/XeeD/este/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/XeeD/este/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/XeeD/este/git/refs{/sha}","trees_url":"https://api.github.com/repos/XeeD/este/git/trees{/sha}","statuses_url":"https://api.github.com/repos/XeeD/este/statuses/{sha}","languages_url":"https://api.github.com/repos/XeeD/este/languages","stargazers_url":"https://api.github.com/repos/XeeD/este/stargazers","contributors_url":"https://api.github.com/repos/XeeD/este/contributors","subscribers_url":"https://api.github.com/repos/XeeD/este/subscribers","subscription_url":"https://api.github.com/repos/XeeD/este/subscription","commits_url":"https://api.github.com/repos/XeeD/este/commits{/sha}","git_commits_url":"https://api.github.com/repos/XeeD/este/git/commits{/sha}","comments_url":"https://api.github.com/repos/XeeD/este/comments{/number}","issue_comment_url":"https://api.github.com/repos/XeeD/este/issues/comments{/number}","contents_url":"https://api.github.com/repos/XeeD/este/contents/{+path}","compare_url":"https://api.github.com/repos/XeeD/este/compare/{base}...{head}","merges_url":"https://api.github.com/repos/XeeD/este/merges","archive_url":"https://api.github.com/repos/XeeD/este/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/XeeD/este/downloads","issues_url":"https://api.github.com/repos/XeeD/este/issues{/number}","pulls_url":"https://api.github.com/repos/XeeD/este/pulls{/number}","milestones_url":"https://api.github.com/repos/XeeD/este/milestones{/number}","notifications_url":"https://api.github.com/repos/XeeD/este/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/XeeD/este/labels{/name}","releases_url":"https://api.github.com/repos/XeeD/este/releases{/id}","created_at":"2015-05-13T17:44:51Z","updated_at":"2015-05-13T17:44:52Z","pushed_at":"2015-07-05T15:01:10Z","git_url":"git://github.com/XeeD/este.git","ssh_url":"git@github.com:XeeD/este.git","clone_url":"https://github.com/XeeD/este.git","svn_url":"https://github.com/XeeD/este","homepage":"","size":774,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"este:master","ref":"master","sha":"bd65818085fc9bcd6c08c2e21966be1960445613","user":{"login":"este","id":3302034,"avatar_url":"https://avatars.githubusercontent.com/u/3302034?v=3","gravatar_id":"","url":"https://api.github.com/users/este","html_url":"https://github.com/este","followers_url":"https://api.github.com/users/este/followers","following_url":"https://api.github.com/users/este/following{/other_user}","gists_url":"https://api.github.com/users/este/gists{/gist_id}","starred_url":"https://api.github.com/users/este/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/este/subscriptions","organizations_url":"https://api.github.com/users/este/orgs","repos_url":"https://api.github.com/users/este/repos","events_url":"https://api.github.com/users/este/events{/privacy}","received_events_url":"https://api.github.com/users/este/received_events","type":"Organization","site_admin":false},"repo":{"id":8230809,"name":"este","full_name":"este/este","owner":{"login":"este","id":3302034,"avatar_url":"https://avatars.githubusercontent.com/u/3302034?v=3","gravatar_id":"","url":"https://api.github.com/users/este","html_url":"https://github.com/este","followers_url":"https://api.github.com/users/este/followers","following_url":"https://api.github.com/users/este/following{/other_user}","gists_url":"https://api.github.com/users/este/gists{/gist_id}","starred_url":"https://api.github.com/users/este/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/este/subscriptions","organizations_url":"https://api.github.com/users/este/orgs","repos_url":"https://api.github.com/users/este/repos","events_url":"https://api.github.com/users/este/events{/privacy}","received_events_url":"https://api.github.com/users/este/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/este/este","description":"The most complete React/Flux dev stack and starter kit for universal functional web apps. Este.js acts as a next-gen to-go everything-but-the-kitchen-sink boilerplate.","fork":false,"url":"https://api.github.com/repos/este/este","forks_url":"https://api.github.com/repos/este/este/forks","keys_url":"https://api.github.com/repos/este/este/keys{/key_id}","collaborators_url":"https://api.github.com/repos/este/este/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/este/este/teams","hooks_url":"https://api.github.com/repos/este/este/hooks","issue_events_url":"https://api.github.com/repos/este/este/issues/events{/number}","events_url":"https://api.github.com/repos/este/este/events","assignees_url":"https://api.github.com/repos/este/este/assignees{/user}","branches_url":"https://api.github.com/repos/este/este/branches{/branch}","tags_url":"https://api.github.com/repos/este/este/tags","blobs_url":"https://api.github.com/repos/este/este/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/este/este/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/este/este/git/refs{/sha}","trees_url":"https://api.github.com/repos/este/este/git/trees{/sha}","statuses_url":"https://api.github.com/repos/este/este/statuses/{sha}","languages_url":"https://api.github.com/repos/este/este/languages","stargazers_url":"https://api.github.com/repos/este/este/stargazers","contributors_url":"https://api.github.com/repos/este/este/contributors","subscribers_url":"https://api.github.com/repos/este/este/subscribers","subscription_url":"https://api.github.com/repos/este/este/subscription","commits_url":"https://api.github.com/repos/este/este/commits{/sha}","git_commits_url":"https://api.github.com/repos/este/este/git/commits{/sha}","comments_url":"https://api.github.com/repos/este/este/comments{/number}","issue_comment_url":"https://api.github.com/repos/este/este/issues/comments{/number}","contents_url":"https://api.github.com/repos/este/este/contents/{+path}","compare_url":"https://api.github.com/repos/este/este/compare/{base}...{head}","merges_url":"https://api.github.com/repos/este/este/merges","archive_url":"https://api.github.com/repos/este/este/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/este/este/downloads","issues_url":"https://api.github.com/repos/este/este/issues{/number}","pulls_url":"https://api.github.com/repos/este/este/pulls{/number}","milestones_url":"https://api.github.com/repos/este/este/milestones{/number}","notifications_url":"https://api.github.com/repos/este/este/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/este/este/labels{/name}","releases_url":"https://api.github.com/repos/este/este/releases{/id}","created_at":"2013-02-16T03:30:38Z","updated_at":"2015-07-06T07:06:40Z","pushed_at":"2015-07-05T15:01:10Z","git_url":"git://github.com/este/este.git","ssh_url":"git@github.com:este/este.git","clone_url":"https://github.com/este/este.git","svn_url":"https://github.com/este/este","homepage":"http://www.learn-reactjs.com/","size":3776,"stargazers_count":1240,"watchers_count":1240,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":119,"mirror_url":null,"open_issues_count":35,"forks":119,"open_issues":35,"watchers":1240,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/este/este/pulls/325"},"html":{"href":"https://github.com/este/este/pull/325"},"issue":{"href":"https://api.github.com/repos/este/este/issues/325"},"comments":{"href":"https://api.github.com/repos/este/este/issues/325/comments"},"review_comments":{"href":"https://api.github.com/repos/este/este/pulls/325/comments"},"review_comment":{"href":"https://api.github.com/repos/este/este/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/este/este/pulls/325/commits"},"statuses":{"href":"https://api.github.com/repos/este/este/statuses/7deb27211cf6001bed5f4e80889f3f98300042be"}}}}