{"action":"created","comment":{"url":"https://api.github.com/repos/opf/openproject/pulls/comments/33918433","id":33918433,"diff_hunk":"@@ -0,0 +1,172 @@\n+//-- copyright\n+// OpenProject is a project management system.\n+// Copyright (C) 2012-2015 the OpenProject Foundation (OPF)\n+//\n+// This program is free software; you can redistribute it and/or\n+// modify it under the terms of the GNU General Public License version 3.\n+//\n+// OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:\n+// Copyright (C) 2006-2013 Jean-Philippe Lang\n+// Copyright (C) 2010-2013 the ChiliProject Team\n+//\n+// This program is free software; you can redistribute it and/or\n+// modify it under the terms of the GNU General Public License\n+// as published by the Free Software Foundation; either version 2\n+// of the License, or (at your option) any later version.\n+//\n+// This program is distributed in the hope that it will be useful,\n+// but WITHOUT ANY WARRANTY; without even the implied warranty of\n+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+// GNU General Public License for more details.\n+//\n+// You should have received a copy of the GNU General Public License\n+// along with this program; if not, write to the Free Software\n+// Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.\n+//\n+// See doc/COPYRIGHT.rdoc for more details.\n+//++\n+\n+module.exports = function(\n+           $scope,\n+           $rootScope,\n+           $state,\n+           $stateParams,\n+           $timeout,\n+           $window,\n+           PathHelper,\n+           WorkPackagesOverviewService,\n+           WorkPackageFieldService,\n+           WorkPackageService,\n+           EditableFieldsState\n+           ) {\n+\n+  var vm = this,\n+      unhideableFields = [\n+        'subject',\n+        'type',\n+        'status',\n+        'description',\n+        'priority',\n+        'assignee',\n+        'percentageDone'\n+      ];\n+\n+  vm.groupedFields = [];\n+  vm.hideEmptyFields = true;\n+\n+  vm.submit = submit;\n+  vm.cancel = cancel;\n+\n+  vm.loaderPromise = null;\n+\n+  vm.isGroupHideable = isGroupHideable;\n+  vm.isFieldHideable = isFieldHideable;\n+  vm.getLabel = getLabel;\n+  vm.isSpecified = isSpecified;\n+  vm.isEditable = isEditable;\n+  vm.hasNiceStar = hasNiceStar;\n+  vm.showToggleButton = showToggleButton;\n+\n+  activate();\n+\n+  function activate() {\n+    EditableFieldsState.forcedEditState = true;\n+    vm.loaderPromise = WorkPackageService.initializeWorkPackage($scope.projectIdentifier, {\n+      type: PathHelper.apiV3TypePath($stateParams.type)","path":"frontend/app/work_packages/controllers/work-package-new-controller.js","position":75,"original_position":75,"commit_id":"2995ad8f53af0c06755d31554f0d3c28e8055baa","original_commit_id":"2995ad8f53af0c06755d31554f0d3c28e8055baa","user":{"login":"NobodysNightmare","id":453584,"avatar_url":"https://avatars.githubusercontent.com/u/453584?v=3","gravatar_id":"","url":"https://api.github.com/users/NobodysNightmare","html_url":"https://github.com/NobodysNightmare","followers_url":"https://api.github.com/users/NobodysNightmare/followers","following_url":"https://api.github.com/users/NobodysNightmare/following{/other_user}","gists_url":"https://api.github.com/users/NobodysNightmare/gists{/gist_id}","starred_url":"https://api.github.com/users/NobodysNightmare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NobodysNightmare/subscriptions","organizations_url":"https://api.github.com/users/NobodysNightmare/orgs","repos_url":"https://api.github.com/users/NobodysNightmare/repos","events_url":"https://api.github.com/users/NobodysNightmare/events{/privacy}","received_events_url":"https://api.github.com/users/NobodysNightmare/received_events","type":"User","site_admin":false},"body":"Disclaimer: I don't know the surrounding/calling code. From a wishful unicorn perspective I would love the following:\r\n\r\n* `$stateParams.type` is a type resource as returned by APIv3\r\n* you don't need to use a pathhelper, but simply use `type.links.self.href`\r\n\r\nIf you say that would require lots of rewriting we should do it later (hope that does not mean \"never\"). But judging from other code in the frontend, chances are high, that the source of `$stateParams.type` was already a \"good\"/\"full\" type and only its id got ripped off. In that case the change would be easy and I'd request it.","created_at":"2015-07-06T09:34:20Z","updated_at":"2015-07-06T09:34:20Z","html_url":"https://github.com/opf/openproject/pull/3204#discussion_r33918433","pull_request_url":"https://api.github.com/repos/opf/openproject/pulls/3204","_links":{"self":{"href":"https://api.github.com/repos/opf/openproject/pulls/comments/33918433"},"html":{"href":"https://github.com/opf/openproject/pull/3204#discussion_r33918433"},"pull_request":{"href":"https://api.github.com/repos/opf/openproject/pulls/3204"}}},"pull_request":{"url":"https://api.github.com/repos/opf/openproject/pulls/3204","id":39056508,"html_url":"https://github.com/opf/openproject/pull/3204","diff_url":"https://github.com/opf/openproject/pull/3204.diff","patch_url":"https://github.com/opf/openproject/pull/3204.patch","issue_url":"https://api.github.com/repos/opf/openproject/issues/3204","number":3204,"state":"open","locked":false,"title":"[17549] Initial Work Package Creation in Details","user":{"login":"floriank","id":498241,"avatar_url":"https://avatars.githubusercontent.com/u/498241?v=3","gravatar_id":"","url":"https://api.github.com/users/floriank","html_url":"https://github.com/floriank","followers_url":"https://api.github.com/users/floriank/followers","following_url":"https://api.github.com/users/floriank/following{/other_user}","gists_url":"https://api.github.com/users/floriank/gists{/gist_id}","starred_url":"https://api.github.com/users/floriank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floriank/subscriptions","organizations_url":"https://api.github.com/users/floriank/orgs","repos_url":"https://api.github.com/users/floriank/repos","events_url":"https://api.github.com/users/floriank/events{/privacy}","received_events_url":"https://api.github.com/users/floriank/received_events","type":"User","site_admin":false},"body":"The original PR was #3124 by @0xF013.\r\n\r\nThis PR is reopenend against `release/4.3`. The checklist from the original:\r\n\r\n- [x] fix autocomplete noscope\r\n- [x] refactor or remove task dropdown menu controller\r\n- [x] fix refresh for /create url\r\n- [x] fix annoying focus on each element on create mode\r\n- [x] focus to title on create toggle\r\n- [x] new work package header in german\r\n      button_save_all: \"Save\"\r\n      button_save_and_send_all: \"Save and send email\"\r\n      button_cancel_all: \"Cancel\"\r\n- [x] column arrows position bug\r\n- [x] time group is now always empty\r\n- [x] payload API title or name\r\n- [x] type switch during creation\r\n\r\n----\r\n\r\nWork Package: https://community.openproject.org/work_packages/17549 (internal)\r\n\r\nThe change introduces the ability to create new work packages from the details pane. The change is a draft preparing to fully implement the workflow in the wake of `4.3`","created_at":"2015-07-02T07:53:12Z","updated_at":"2015-07-06T09:34:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca947f6c7301064c59f5839d620004f9c618c178","assignee":null,"milestone":{"url":"https://api.github.com/repos/opf/openproject/milestones/3","html_url":"https://github.com/opf/openproject/milestones/4.3","labels_url":"https://api.github.com/repos/opf/openproject/milestones/3/labels","id":1104474,"number":3,"title":"4.3","description":"","creator":{"login":"myabc","id":755,"avatar_url":"https://avatars.githubusercontent.com/u/755?v=3","gravatar_id":"","url":"https://api.github.com/users/myabc","html_url":"https://github.com/myabc","followers_url":"https://api.github.com/users/myabc/followers","following_url":"https://api.github.com/users/myabc/following{/other_user}","gists_url":"https://api.github.com/users/myabc/gists{/gist_id}","starred_url":"https://api.github.com/users/myabc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myabc/subscriptions","organizations_url":"https://api.github.com/users/myabc/orgs","repos_url":"https://api.github.com/users/myabc/repos","events_url":"https://api.github.com/users/myabc/events{/privacy}","received_events_url":"https://api.github.com/users/myabc/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":0,"state":"open","created_at":"2015-05-11T10:04:28Z","updated_at":"2015-07-06T09:08:24Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/opf/openproject/pulls/3204/commits","review_comments_url":"https://api.github.com/repos/opf/openproject/pulls/3204/comments","review_comment_url":"https://api.github.com/repos/opf/openproject/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opf/openproject/issues/3204/comments","statuses_url":"https://api.github.com/repos/opf/openproject/statuses/2995ad8f53af0c06755d31554f0d3c28e8055baa","head":{"label":"floriank:feature/17549-initial-wp-create-frontend","ref":"feature/17549-initial-wp-create-frontend","sha":"2995ad8f53af0c06755d31554f0d3c28e8055baa","user":{"login":"floriank","id":498241,"avatar_url":"https://avatars.githubusercontent.com/u/498241?v=3","gravatar_id":"","url":"https://api.github.com/users/floriank","html_url":"https://github.com/floriank","followers_url":"https://api.github.com/users/floriank/followers","following_url":"https://api.github.com/users/floriank/following{/other_user}","gists_url":"https://api.github.com/users/floriank/gists{/gist_id}","starred_url":"https://api.github.com/users/floriank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floriank/subscriptions","organizations_url":"https://api.github.com/users/floriank/orgs","repos_url":"https://api.github.com/users/floriank/repos","events_url":"https://api.github.com/users/floriank/events{/privacy}","received_events_url":"https://api.github.com/users/floriank/received_events","type":"User","site_admin":false},"repo":{"id":29468662,"name":"openproject","full_name":"floriank/openproject","owner":{"login":"floriank","id":498241,"avatar_url":"https://avatars.githubusercontent.com/u/498241?v=3","gravatar_id":"","url":"https://api.github.com/users/floriank","html_url":"https://github.com/floriank","followers_url":"https://api.github.com/users/floriank/followers","following_url":"https://api.github.com/users/floriank/following{/other_user}","gists_url":"https://api.github.com/users/floriank/gists{/gist_id}","starred_url":"https://api.github.com/users/floriank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floriank/subscriptions","organizations_url":"https://api.github.com/users/floriank/orgs","repos_url":"https://api.github.com/users/floriank/repos","events_url":"https://api.github.com/users/floriank/events{/privacy}","received_events_url":"https://api.github.com/users/floriank/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/floriank/openproject","description":"OpenProject is a web based project management system built on Ruby on Rails","fork":true,"url":"https://api.github.com/repos/floriank/openproject","forks_url":"https://api.github.com/repos/floriank/openproject/forks","keys_url":"https://api.github.com/repos/floriank/openproject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/floriank/openproject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/floriank/openproject/teams","hooks_url":"https://api.github.com/repos/floriank/openproject/hooks","issue_events_url":"https://api.github.com/repos/floriank/openproject/issues/events{/number}","events_url":"https://api.github.com/repos/floriank/openproject/events","assignees_url":"https://api.github.com/repos/floriank/openproject/assignees{/user}","branches_url":"https://api.github.com/repos/floriank/openproject/branches{/branch}","tags_url":"https://api.github.com/repos/floriank/openproject/tags","blobs_url":"https://api.github.com/repos/floriank/openproject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/floriank/openproject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/floriank/openproject/git/refs{/sha}","trees_url":"https://api.github.com/repos/floriank/openproject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/floriank/openproject/statuses/{sha}","languages_url":"https://api.github.com/repos/floriank/openproject/languages","stargazers_url":"https://api.github.com/repos/floriank/openproject/stargazers","contributors_url":"https://api.github.com/repos/floriank/openproject/contributors","subscribers_url":"https://api.github.com/repos/floriank/openproject/subscribers","subscription_url":"https://api.github.com/repos/floriank/openproject/subscription","commits_url":"https://api.github.com/repos/floriank/openproject/commits{/sha}","git_commits_url":"https://api.github.com/repos/floriank/openproject/git/commits{/sha}","comments_url":"https://api.github.com/repos/floriank/openproject/comments{/number}","issue_comment_url":"https://api.github.com/repos/floriank/openproject/issues/comments{/number}","contents_url":"https://api.github.com/repos/floriank/openproject/contents/{+path}","compare_url":"https://api.github.com/repos/floriank/openproject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/floriank/openproject/merges","archive_url":"https://api.github.com/repos/floriank/openproject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/floriank/openproject/downloads","issues_url":"https://api.github.com/repos/floriank/openproject/issues{/number}","pulls_url":"https://api.github.com/repos/floriank/openproject/pulls{/number}","milestones_url":"https://api.github.com/repos/floriank/openproject/milestones{/number}","notifications_url":"https://api.github.com/repos/floriank/openproject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/floriank/openproject/labels{/name}","releases_url":"https://api.github.com/repos/floriank/openproject/releases{/id}","created_at":"2015-01-19T11:56:20Z","updated_at":"2015-04-20T08:53:16Z","pushed_at":"2015-07-06T08:58:27Z","git_url":"git://github.com/floriank/openproject.git","ssh_url":"git@github.com:floriank/openproject.git","clone_url":"https://github.com/floriank/openproject.git","svn_url":"https://github.com/floriank/openproject","homepage":"https://www.openproject.org","size":69884,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"opf:release/4.3","ref":"release/4.3","sha":"073c3818462880a771d63ce190f54cf321c8096b","user":{"login":"opf","id":1756674,"avatar_url":"https://avatars.githubusercontent.com/u/1756674?v=3","gravatar_id":"","url":"https://api.github.com/users/opf","html_url":"https://github.com/opf","followers_url":"https://api.github.com/users/opf/followers","following_url":"https://api.github.com/users/opf/following{/other_user}","gists_url":"https://api.github.com/users/opf/gists{/gist_id}","starred_url":"https://api.github.com/users/opf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opf/subscriptions","organizations_url":"https://api.github.com/users/opf/orgs","repos_url":"https://api.github.com/users/opf/repos","events_url":"https://api.github.com/users/opf/events{/privacy}","received_events_url":"https://api.github.com/users/opf/received_events","type":"Organization","site_admin":false},"repo":{"id":6899875,"name":"openproject","full_name":"opf/openproject","owner":{"login":"opf","id":1756674,"avatar_url":"https://avatars.githubusercontent.com/u/1756674?v=3","gravatar_id":"","url":"https://api.github.com/users/opf","html_url":"https://github.com/opf","followers_url":"https://api.github.com/users/opf/followers","following_url":"https://api.github.com/users/opf/following{/other_user}","gists_url":"https://api.github.com/users/opf/gists{/gist_id}","starred_url":"https://api.github.com/users/opf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opf/subscriptions","organizations_url":"https://api.github.com/users/opf/orgs","repos_url":"https://api.github.com/users/opf/repos","events_url":"https://api.github.com/users/opf/events{/privacy}","received_events_url":"https://api.github.com/users/opf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opf/openproject","description":"OpenProject is a web-based project management system built on Ruby on Rails","fork":false,"url":"https://api.github.com/repos/opf/openproject","forks_url":"https://api.github.com/repos/opf/openproject/forks","keys_url":"https://api.github.com/repos/opf/openproject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opf/openproject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opf/openproject/teams","hooks_url":"https://api.github.com/repos/opf/openproject/hooks","issue_events_url":"https://api.github.com/repos/opf/openproject/issues/events{/number}","events_url":"https://api.github.com/repos/opf/openproject/events","assignees_url":"https://api.github.com/repos/opf/openproject/assignees{/user}","branches_url":"https://api.github.com/repos/opf/openproject/branches{/branch}","tags_url":"https://api.github.com/repos/opf/openproject/tags","blobs_url":"https://api.github.com/repos/opf/openproject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opf/openproject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opf/openproject/git/refs{/sha}","trees_url":"https://api.github.com/repos/opf/openproject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opf/openproject/statuses/{sha}","languages_url":"https://api.github.com/repos/opf/openproject/languages","stargazers_url":"https://api.github.com/repos/opf/openproject/stargazers","contributors_url":"https://api.github.com/repos/opf/openproject/contributors","subscribers_url":"https://api.github.com/repos/opf/openproject/subscribers","subscription_url":"https://api.github.com/repos/opf/openproject/subscription","commits_url":"https://api.github.com/repos/opf/openproject/commits{/sha}","git_commits_url":"https://api.github.com/repos/opf/openproject/git/commits{/sha}","comments_url":"https://api.github.com/repos/opf/openproject/comments{/number}","issue_comment_url":"https://api.github.com/repos/opf/openproject/issues/comments{/number}","contents_url":"https://api.github.com/repos/opf/openproject/contents/{+path}","compare_url":"https://api.github.com/repos/opf/openproject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opf/openproject/merges","archive_url":"https://api.github.com/repos/opf/openproject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opf/openproject/downloads","issues_url":"https://api.github.com/repos/opf/openproject/issues{/number}","pulls_url":"https://api.github.com/repos/opf/openproject/pulls{/number}","milestones_url":"https://api.github.com/repos/opf/openproject/milestones{/number}","notifications_url":"https://api.github.com/repos/opf/openproject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opf/openproject/labels{/name}","releases_url":"https://api.github.com/repos/opf/openproject/releases{/id}","created_at":"2012-11-28T09:59:11Z","updated_at":"2015-07-06T05:33:56Z","pushed_at":"2015-07-06T09:08:24Z","git_url":"git://github.com/opf/openproject.git","ssh_url":"git@github.com:opf/openproject.git","clone_url":"https://github.com/opf/openproject.git","svn_url":"https://github.com/opf/openproject","homepage":"https://www.openproject.org","size":202328,"stargazers_count":657,"watchers_count":657,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":283,"mirror_url":null,"open_issues_count":40,"forks":283,"open_issues":40,"watchers":657,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/opf/openproject/pulls/3204"},"html":{"href":"https://github.com/opf/openproject/pull/3204"},"issue":{"href":"https://api.github.com/repos/opf/openproject/issues/3204"},"comments":{"href":"https://api.github.com/repos/opf/openproject/issues/3204/comments"},"review_comments":{"href":"https://api.github.com/repos/opf/openproject/pulls/3204/comments"},"review_comment":{"href":"https://api.github.com/repos/opf/openproject/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opf/openproject/pulls/3204/commits"},"statuses":{"href":"https://api.github.com/repos/opf/openproject/statuses/2995ad8f53af0c06755d31554f0d3c28e8055baa"}}}}