{"action":"created","comment":{"url":"https://api.github.com/repos/micropython/micropython/pulls/comments/27290604","id":27290604,"diff_hunk":"@@ -562,12 +458,6 @@ static const BYTE ExCvt[] = _EXCVT;\t/* Upper conversion table for extended chara\n /* String functions                                                      */\r\n /*-----------------------------------------------------------------------*/\r\n \r\n-// dpgeorge:\r\n-// We use stdlib version of memset and memcmp to reduce code size.\r\n-// We use the original custom version of mem_cpy so that gcc doesn't\r\n-// recognise the builtin function and then inline it.  Allowing gcc\r\n-// to use the builtin memcpy increases code size by 72 bytes.\r","path":"lib/fatfs/ff.c","position":242,"original_position":242,"commit_id":"e816f537ea882407f3ac1fe47283c2d6513f4d08","original_commit_id":"e816f537ea882407f3ac1fe47283c2d6513f4d08","user":{"login":"dpgeorge","id":6187689,"avatar_url":"https://avatars.githubusercontent.com/u/6187689?v=3","gravatar_id":"","url":"https://api.github.com/users/dpgeorge","html_url":"https://github.com/dpgeorge","followers_url":"https://api.github.com/users/dpgeorge/followers","following_url":"https://api.github.com/users/dpgeorge/following{/other_user}","gists_url":"https://api.github.com/users/dpgeorge/gists{/gist_id}","starred_url":"https://api.github.com/users/dpgeorge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpgeorge/subscriptions","organizations_url":"https://api.github.com/users/dpgeorge/orgs","repos_url":"https://api.github.com/users/dpgeorge/repos","events_url":"https://api.github.com/users/dpgeorge/events{/privacy}","received_events_url":"https://api.github.com/users/dpgeorge/received_events","type":"User","site_admin":false},"body":"Why did you remove this comment, and the #if's below?","created_at":"2015-03-27T12:20:52Z","updated_at":"2015-03-27T12:20:52Z","html_url":"https://github.com/micropython/micropython/pull/1171#discussion_r27290604","pull_request_url":"https://api.github.com/repos/micropython/micropython/pulls/1171","_links":{"self":{"href":"https://api.github.com/repos/micropython/micropython/pulls/comments/27290604"},"html":{"href":"https://github.com/micropython/micropython/pull/1171#discussion_r27290604"},"pull_request":{"href":"https://api.github.com/repos/micropython/micropython/pulls/1171"}}},"pull_request":{"url":"https://api.github.com/repos/micropython/micropython/pulls/1171","id":32101100,"html_url":"https://github.com/micropython/micropython/pull/1171","diff_url":"https://github.com/micropython/micropython/pull/1171.diff","patch_url":"https://github.com/micropython/micropython/pull/1171.patch","issue_url":"https://api.github.com/repos/micropython/micropython/issues/1171","number":1171,"state":"open","locked":false,"title":"lib: Update FatFs to R0.11.","user":{"login":"danicampora","id":7749335,"avatar_url":"https://avatars.githubusercontent.com/u/7749335?v=3","gravatar_id":"","url":"https://api.github.com/users/danicampora","html_url":"https://github.com/danicampora","followers_url":"https://api.github.com/users/danicampora/followers","following_url":"https://api.github.com/users/danicampora/following{/other_user}","gists_url":"https://api.github.com/users/danicampora/gists{/gist_id}","starred_url":"https://api.github.com/users/danicampora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danicampora/subscriptions","organizations_url":"https://api.github.com/users/danicampora/orgs","repos_url":"https://api.github.com/users/danicampora/repos","events_url":"https://api.github.com/users/danicampora/events{/privacy}","received_events_url":"https://api.github.com/users/danicampora/received_events","type":"User","site_admin":false},"body":"There are lots of cosmetic changes, but this release brings a  very\r\nimportant bug fix:\r\n - Fixed f_unlink() does not remove cluster chain of the file.\r\n\r\nWith R0.10c if you try to write a file that is too large to fit in the\r\nfree space of the drive, the operation fails, you delete the incomplete\r\nfile, and it seems to be erased, but the space is not really freed,\r\nbecause any subsequent write operations fail because the drive is\r\n\"still\" full. The only way to recover from this is by formatting the\r\ndrive. \r\nI can confirm that R0.11 fixes the problem.","created_at":"2015-03-27T11:54:31Z","updated_at":"2015-03-27T12:20:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd45fd0f8dae27c86c67410653c9a0d35d348838","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/micropython/micropython/pulls/1171/commits","review_comments_url":"https://api.github.com/repos/micropython/micropython/pulls/1171/comments","review_comment_url":"https://api.github.com/repos/micropython/micropython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/micropython/micropython/issues/1171/comments","statuses_url":"https://api.github.com/repos/micropython/micropython/statuses/e816f537ea882407f3ac1fe47283c2d6513f4d08","head":{"label":"danicampora:FatFS011","ref":"FatFS011","sha":"e816f537ea882407f3ac1fe47283c2d6513f4d08","user":{"login":"danicampora","id":7749335,"avatar_url":"https://avatars.githubusercontent.com/u/7749335?v=3","gravatar_id":"","url":"https://api.github.com/users/danicampora","html_url":"https://github.com/danicampora","followers_url":"https://api.github.com/users/danicampora/followers","following_url":"https://api.github.com/users/danicampora/following{/other_user}","gists_url":"https://api.github.com/users/danicampora/gists{/gist_id}","starred_url":"https://api.github.com/users/danicampora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danicampora/subscriptions","organizations_url":"https://api.github.com/users/danicampora/orgs","repos_url":"https://api.github.com/users/danicampora/repos","events_url":"https://api.github.com/users/danicampora/events{/privacy}","received_events_url":"https://api.github.com/users/danicampora/received_events","type":"User","site_admin":false},"repo":{"id":24649240,"name":"micropython","full_name":"danicampora/micropython","owner":{"login":"danicampora","id":7749335,"avatar_url":"https://avatars.githubusercontent.com/u/7749335?v=3","gravatar_id":"","url":"https://api.github.com/users/danicampora","html_url":"https://github.com/danicampora","followers_url":"https://api.github.com/users/danicampora/followers","following_url":"https://api.github.com/users/danicampora/following{/other_user}","gists_url":"https://api.github.com/users/danicampora/gists{/gist_id}","starred_url":"https://api.github.com/users/danicampora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danicampora/subscriptions","organizations_url":"https://api.github.com/users/danicampora/orgs","repos_url":"https://api.github.com/users/danicampora/repos","events_url":"https://api.github.com/users/danicampora/events{/privacy}","received_events_url":"https://api.github.com/users/danicampora/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danicampora/micropython","description":"The Micro Python project","fork":true,"url":"https://api.github.com/repos/danicampora/micropython","forks_url":"https://api.github.com/repos/danicampora/micropython/forks","keys_url":"https://api.github.com/repos/danicampora/micropython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danicampora/micropython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danicampora/micropython/teams","hooks_url":"https://api.github.com/repos/danicampora/micropython/hooks","issue_events_url":"https://api.github.com/repos/danicampora/micropython/issues/events{/number}","events_url":"https://api.github.com/repos/danicampora/micropython/events","assignees_url":"https://api.github.com/repos/danicampora/micropython/assignees{/user}","branches_url":"https://api.github.com/repos/danicampora/micropython/branches{/branch}","tags_url":"https://api.github.com/repos/danicampora/micropython/tags","blobs_url":"https://api.github.com/repos/danicampora/micropython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danicampora/micropython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danicampora/micropython/git/refs{/sha}","trees_url":"https://api.github.com/repos/danicampora/micropython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danicampora/micropython/statuses/{sha}","languages_url":"https://api.github.com/repos/danicampora/micropython/languages","stargazers_url":"https://api.github.com/repos/danicampora/micropython/stargazers","contributors_url":"https://api.github.com/repos/danicampora/micropython/contributors","subscribers_url":"https://api.github.com/repos/danicampora/micropython/subscribers","subscription_url":"https://api.github.com/repos/danicampora/micropython/subscription","commits_url":"https://api.github.com/repos/danicampora/micropython/commits{/sha}","git_commits_url":"https://api.github.com/repos/danicampora/micropython/git/commits{/sha}","comments_url":"https://api.github.com/repos/danicampora/micropython/comments{/number}","issue_comment_url":"https://api.github.com/repos/danicampora/micropython/issues/comments{/number}","contents_url":"https://api.github.com/repos/danicampora/micropython/contents/{+path}","compare_url":"https://api.github.com/repos/danicampora/micropython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danicampora/micropython/merges","archive_url":"https://api.github.com/repos/danicampora/micropython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danicampora/micropython/downloads","issues_url":"https://api.github.com/repos/danicampora/micropython/issues{/number}","pulls_url":"https://api.github.com/repos/danicampora/micropython/pulls{/number}","milestones_url":"https://api.github.com/repos/danicampora/micropython/milestones{/number}","notifications_url":"https://api.github.com/repos/danicampora/micropython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danicampora/micropython/labels{/name}","releases_url":"https://api.github.com/repos/danicampora/micropython/releases{/id}","created_at":"2014-09-30T18:03:00Z","updated_at":"2015-02-06T15:10:00Z","pushed_at":"2015-03-27T11:43:27Z","git_url":"git://github.com/danicampora/micropython.git","ssh_url":"git@github.com:danicampora/micropython.git","clone_url":"https://github.com/danicampora/micropython.git","svn_url":"https://github.com/danicampora/micropython","homepage":null,"size":26209,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":12,"forks":0,"open_issues":12,"watchers":1,"default_branch":"master"}},"base":{"label":"micropython:master","ref":"master","sha":"28fa84b4454ef253dfba5f1ceb023be2184a7271","user":{"login":"micropython","id":6298560,"avatar_url":"https://avatars.githubusercontent.com/u/6298560?v=3","gravatar_id":"","url":"https://api.github.com/users/micropython","html_url":"https://github.com/micropython","followers_url":"https://api.github.com/users/micropython/followers","following_url":"https://api.github.com/users/micropython/following{/other_user}","gists_url":"https://api.github.com/users/micropython/gists{/gist_id}","starred_url":"https://api.github.com/users/micropython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micropython/subscriptions","organizations_url":"https://api.github.com/users/micropython/orgs","repos_url":"https://api.github.com/users/micropython/repos","events_url":"https://api.github.com/users/micropython/events{/privacy}","received_events_url":"https://api.github.com/users/micropython/received_events","type":"Organization","site_admin":false},"repo":{"id":15337142,"name":"micropython","full_name":"micropython/micropython","owner":{"login":"micropython","id":6298560,"avatar_url":"https://avatars.githubusercontent.com/u/6298560?v=3","gravatar_id":"","url":"https://api.github.com/users/micropython","html_url":"https://github.com/micropython","followers_url":"https://api.github.com/users/micropython/followers","following_url":"https://api.github.com/users/micropython/following{/other_user}","gists_url":"https://api.github.com/users/micropython/gists{/gist_id}","starred_url":"https://api.github.com/users/micropython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micropython/subscriptions","organizations_url":"https://api.github.com/users/micropython/orgs","repos_url":"https://api.github.com/users/micropython/repos","events_url":"https://api.github.com/users/micropython/events{/privacy}","received_events_url":"https://api.github.com/users/micropython/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/micropython/micropython","description":"The Micro Python project","fork":false,"url":"https://api.github.com/repos/micropython/micropython","forks_url":"https://api.github.com/repos/micropython/micropython/forks","keys_url":"https://api.github.com/repos/micropython/micropython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/micropython/micropython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/micropython/micropython/teams","hooks_url":"https://api.github.com/repos/micropython/micropython/hooks","issue_events_url":"https://api.github.com/repos/micropython/micropython/issues/events{/number}","events_url":"https://api.github.com/repos/micropython/micropython/events","assignees_url":"https://api.github.com/repos/micropython/micropython/assignees{/user}","branches_url":"https://api.github.com/repos/micropython/micropython/branches{/branch}","tags_url":"https://api.github.com/repos/micropython/micropython/tags","blobs_url":"https://api.github.com/repos/micropython/micropython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/micropython/micropython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/micropython/micropython/git/refs{/sha}","trees_url":"https://api.github.com/repos/micropython/micropython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/micropython/micropython/statuses/{sha}","languages_url":"https://api.github.com/repos/micropython/micropython/languages","stargazers_url":"https://api.github.com/repos/micropython/micropython/stargazers","contributors_url":"https://api.github.com/repos/micropython/micropython/contributors","subscribers_url":"https://api.github.com/repos/micropython/micropython/subscribers","subscription_url":"https://api.github.com/repos/micropython/micropython/subscription","commits_url":"https://api.github.com/repos/micropython/micropython/commits{/sha}","git_commits_url":"https://api.github.com/repos/micropython/micropython/git/commits{/sha}","comments_url":"https://api.github.com/repos/micropython/micropython/comments{/number}","issue_comment_url":"https://api.github.com/repos/micropython/micropython/issues/comments{/number}","contents_url":"https://api.github.com/repos/micropython/micropython/contents/{+path}","compare_url":"https://api.github.com/repos/micropython/micropython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/micropython/micropython/merges","archive_url":"https://api.github.com/repos/micropython/micropython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/micropython/micropython/downloads","issues_url":"https://api.github.com/repos/micropython/micropython/issues{/number}","pulls_url":"https://api.github.com/repos/micropython/micropython/pulls{/number}","milestones_url":"https://api.github.com/repos/micropython/micropython/milestones{/number}","notifications_url":"https://api.github.com/repos/micropython/micropython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/micropython/micropython/labels{/name}","releases_url":"https://api.github.com/repos/micropython/micropython/releases{/id}","created_at":"2013-12-20T11:47:07Z","updated_at":"2015-03-26T23:56:15Z","pushed_at":"2015-03-27T11:54:32Z","git_url":"git://github.com/micropython/micropython.git","ssh_url":"git@github.com:micropython/micropython.git","clone_url":"https://github.com/micropython/micropython.git","svn_url":"https://github.com/micropython/micropython","homepage":null,"size":42905,"stargazers_count":1645,"watchers_count":1645,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":291,"mirror_url":null,"open_issues_count":115,"forks":291,"open_issues":115,"watchers":1645,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/micropython/micropython/pulls/1171"},"html":{"href":"https://github.com/micropython/micropython/pull/1171"},"issue":{"href":"https://api.github.com/repos/micropython/micropython/issues/1171"},"comments":{"href":"https://api.github.com/repos/micropython/micropython/issues/1171/comments"},"review_comments":{"href":"https://api.github.com/repos/micropython/micropython/pulls/1171/comments"},"review_comment":{"href":"https://api.github.com/repos/micropython/micropython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/micropython/micropython/pulls/1171/commits"},"statuses":{"href":"https://api.github.com/repos/micropython/micropython/statuses/e816f537ea882407f3ac1fe47283c2d6513f4d08"}}}}