{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/29975044","id":29975044,"diff_hunk":"@@ -243,32 +243,32 @@ class NodeTable: UDPSocketEvents, public std::enable_shared_from_this<NodeTable>\n \t/// Purges and pings nodes for any buckets which haven't been touched for c_bucketRefresh seconds.\n \tvoid doRefreshBuckets(boost::system::error_code const& _ec);\n \n-\tstd::unique_ptr<NodeTableEventHandler> m_nodeEventHandler;\t///< Event handler for node events.\n+\tstd::unique_ptr<NodeTableEventHandler> m_nodeEventHandler;\t\t///< Event handler for node events.\n \n-\tNode m_node;\t\t\t\t\t\t\t\t\t\t\t\t///< This node.\n-\tSecret m_secret;\t\t\t\t\t\t\t\t\t\t\t///< This nodes secret key.\n+\tNode m_node;\t\t\t\t\t\t\t\t\t\t\t\t\t///< This node.\n+\tSecret m_secret;\t\t\t\t\t\t\t\t\t\t\t\t///< This nodes secret key.\n \n-\tmutable Mutex x_nodes;\t\t\t\t\t\t\t\t\t///< LOCK x_state first if both locks are required. Mutable for thread-safe copy in nodes() const.\n-\tstd::map<NodeId, std::shared_ptr<NodeEntry>> m_nodes;\t\t///< Nodes\n+\tmutable Mutex x_nodes;\t\t\t\t\t\t\t\t\t\t\t///< LOCK x_state first if both locks are required. Mutable for thread-safe copy in nodes() const.\n+\tstd::unordered_map<NodeId, std::shared_ptr<NodeEntry>> m_nodes;\t///< Nodes\n \n-\tmutable Mutex x_state;\t\t\t\t\t\t\t\t\t///< LOCK x_state first if both x_nodes and x_state locks are required.\n-\tstd::array<NodeBucket, s_bins> m_state;\t\t\t\t\t///< State of p2p node network.\n+\tmutable Mutex x_state;\t\t\t\t\t\t\t\t\t\t\t///< LOCK x_state first if both x_nodes and x_state locks are required.\n+\tstd::array<NodeBucket, s_bins> m_state;\t\t\t\t\t\t\t///< State of p2p node network.\n \n-\tMutex x_evictions;\t\t\t\t\t\t\t\t\t\t///< LOCK x_evictions first if both x_nodes and x_evictions locks are required.\n-\tstd::deque<EvictionTimeout> m_evictions;\t\t\t\t\t///< Eviction timeouts.\n+\tMutex x_evictions;\t\t\t\t\t\t\t\t\t\t\t\t///< LOCK x_nodes first if both x_nodes and x_evictions locks are required.","path":"libp2p/NodeTable.h","position":33,"original_position":33,"commit_id":"f52f8682c4604376c1fa352743a1142e89780a18","original_commit_id":"6cec14026c6d9b29c79b9cf75e5b83cd067f8183","user":{"login":"arkpar","id":9008569,"avatar_url":"https://avatars.githubusercontent.com/u/9008569?v=3","gravatar_id":"","url":"https://api.github.com/users/arkpar","html_url":"https://github.com/arkpar","followers_url":"https://api.github.com/users/arkpar/followers","following_url":"https://api.github.com/users/arkpar/following{/other_user}","gists_url":"https://api.github.com/users/arkpar/gists{/gist_id}","starred_url":"https://api.github.com/users/arkpar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arkpar/subscriptions","organizations_url":"https://api.github.com/users/arkpar/orgs","repos_url":"https://api.github.com/users/arkpar/repos","events_url":"https://api.github.com/users/arkpar/events{/privacy}","received_events_url":"https://api.github.com/users/arkpar/received_events","type":"User","site_admin":false},"body":"Rebased. ","created_at":"2015-05-08T20:44:23Z","updated_at":"2015-05-08T20:44:23Z","html_url":"https://github.com/ethereum/cpp-ethereum/pull/1825#discussion_r29975044","pull_request_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1825","_links":{"self":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/29975044"},"html":{"href":"https://github.com/ethereum/cpp-ethereum/pull/1825#discussion_r29975044"},"pull_request":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1825"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1825","id":34913177,"html_url":"https://github.com/ethereum/cpp-ethereum/pull/1825","diff_url":"https://github.com/ethereum/cpp-ethereum/pull/1825.diff","patch_url":"https://github.com/ethereum/cpp-ethereum/pull/1825.patch","issue_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/1825","number":1825,"state":"open","locked":false,"title":"Moved from stl::set and stl::map to hash tables","user":{"login":"arkpar","id":9008569,"avatar_url":"https://avatars.githubusercontent.com/u/9008569?v=3","gravatar_id":"","url":"https://api.github.com/users/arkpar","html_url":"https://github.com/arkpar","followers_url":"https://api.github.com/users/arkpar/followers","following_url":"https://api.github.com/users/arkpar/following{/other_user}","gists_url":"https://api.github.com/users/arkpar/gists{/gist_id}","starred_url":"https://api.github.com/users/arkpar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arkpar/subscriptions","organizations_url":"https://api.github.com/users/arkpar/orgs","repos_url":"https://api.github.com/users/arkpar/repos","events_url":"https://api.github.com/users/arkpar/events{/privacy}","received_events_url":"https://api.github.com/users/arkpar/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-05-07T13:05:45Z","updated_at":"2015-05-08T20:44:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d1286abcd27fce949600628f94ad14a3ec3136a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1825/commits","review_comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1825/comments","review_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/1825/comments","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/f52f8682c4604376c1fa352743a1142e89780a18","head":{"label":"arkpar:core_perf","ref":"core_perf","sha":"f52f8682c4604376c1fa352743a1142e89780a18","user":{"login":"arkpar","id":9008569,"avatar_url":"https://avatars.githubusercontent.com/u/9008569?v=3","gravatar_id":"","url":"https://api.github.com/users/arkpar","html_url":"https://github.com/arkpar","followers_url":"https://api.github.com/users/arkpar/followers","following_url":"https://api.github.com/users/arkpar/following{/other_user}","gists_url":"https://api.github.com/users/arkpar/gists{/gist_id}","starred_url":"https://api.github.com/users/arkpar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arkpar/subscriptions","organizations_url":"https://api.github.com/users/arkpar/orgs","repos_url":"https://api.github.com/users/arkpar/repos","events_url":"https://api.github.com/users/arkpar/events{/privacy}","received_events_url":"https://api.github.com/users/arkpar/received_events","type":"User","site_admin":false},"repo":{"id":24758906,"name":"cpp-ethereum","full_name":"arkpar/cpp-ethereum","owner":{"login":"arkpar","id":9008569,"avatar_url":"https://avatars.githubusercontent.com/u/9008569?v=3","gravatar_id":"","url":"https://api.github.com/users/arkpar","html_url":"https://github.com/arkpar","followers_url":"https://api.github.com/users/arkpar/followers","following_url":"https://api.github.com/users/arkpar/following{/other_user}","gists_url":"https://api.github.com/users/arkpar/gists{/gist_id}","starred_url":"https://api.github.com/users/arkpar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arkpar/subscriptions","organizations_url":"https://api.github.com/users/arkpar/orgs","repos_url":"https://api.github.com/users/arkpar/repos","events_url":"https://api.github.com/users/arkpar/events{/privacy}","received_events_url":"https://api.github.com/users/arkpar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arkpar/cpp-ethereum","description":"Gavin Wood's C++ implementation of the Ethereum yellowpaper.","fork":true,"url":"https://api.github.com/repos/arkpar/cpp-ethereum","forks_url":"https://api.github.com/repos/arkpar/cpp-ethereum/forks","keys_url":"https://api.github.com/repos/arkpar/cpp-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arkpar/cpp-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arkpar/cpp-ethereum/teams","hooks_url":"https://api.github.com/repos/arkpar/cpp-ethereum/hooks","issue_events_url":"https://api.github.com/repos/arkpar/cpp-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/arkpar/cpp-ethereum/events","assignees_url":"https://api.github.com/repos/arkpar/cpp-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/arkpar/cpp-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/arkpar/cpp-ethereum/tags","blobs_url":"https://api.github.com/repos/arkpar/cpp-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arkpar/cpp-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arkpar/cpp-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/arkpar/cpp-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arkpar/cpp-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/arkpar/cpp-ethereum/languages","stargazers_url":"https://api.github.com/repos/arkpar/cpp-ethereum/stargazers","contributors_url":"https://api.github.com/repos/arkpar/cpp-ethereum/contributors","subscribers_url":"https://api.github.com/repos/arkpar/cpp-ethereum/subscribers","subscription_url":"https://api.github.com/repos/arkpar/cpp-ethereum/subscription","commits_url":"https://api.github.com/repos/arkpar/cpp-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/arkpar/cpp-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/arkpar/cpp-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/arkpar/cpp-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/arkpar/cpp-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/arkpar/cpp-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arkpar/cpp-ethereum/merges","archive_url":"https://api.github.com/repos/arkpar/cpp-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arkpar/cpp-ethereum/downloads","issues_url":"https://api.github.com/repos/arkpar/cpp-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/arkpar/cpp-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/arkpar/cpp-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/arkpar/cpp-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arkpar/cpp-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/arkpar/cpp-ethereum/releases{/id}","created_at":"2014-10-03T13:14:36Z","updated_at":"2014-10-03T13:54:10Z","pushed_at":"2015-05-08T20:41:09Z","git_url":"git://github.com/arkpar/cpp-ethereum.git","ssh_url":"git@github.com:arkpar/cpp-ethereum.git","clone_url":"https://github.com/arkpar/cpp-ethereum.git","svn_url":"https://github.com/arkpar/cpp-ethereum","homepage":"www.gavwood.com/Paper.pdf","size":22437,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"2f5eb4e2ea5df89933a06b12af019d0fbb8841a0","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15460666,"name":"cpp-ethereum","full_name":"ethereum/cpp-ethereum","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/cpp-ethereum","description":"Gavin Wood's C++ implementation of the Ethereum yellowpaper.","fork":false,"url":"https://api.github.com/repos/ethereum/cpp-ethereum","forks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/forks","keys_url":"https://api.github.com/repos/ethereum/cpp-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/cpp-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/cpp-ethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/events","assignees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/cpp-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/cpp-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/cpp-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/cpp-ethereum/merges","archive_url":"https://api.github.com/repos/ethereum/cpp-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/cpp-ethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/cpp-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/cpp-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/cpp-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/cpp-ethereum/releases{/id}","created_at":"2013-12-26T21:26:06Z","updated_at":"2015-05-08T16:58:43Z","pushed_at":"2015-05-08T20:41:10Z","git_url":"git://github.com/ethereum/cpp-ethereum.git","ssh_url":"git@github.com:ethereum/cpp-ethereum.git","clone_url":"https://github.com/ethereum/cpp-ethereum.git","svn_url":"https://github.com/ethereum/cpp-ethereum","homepage":"www.gavwood.com/Paper.pdf","size":97124,"stargazers_count":461,"watchers_count":461,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":157,"mirror_url":null,"open_issues_count":132,"forks":157,"open_issues":132,"watchers":461,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1825"},"html":{"href":"https://github.com/ethereum/cpp-ethereum/pull/1825"},"issue":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/1825"},"comments":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/1825/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1825/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1825/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/f52f8682c4604376c1fa352743a1142e89780a18"}}}}