{"action":"opened","number":4,"pull_request":{"url":"https://api.github.com/repos/sonoro1234/supercollider/pulls/4","id":36561503,"html_url":"https://github.com/sonoro1234/supercollider/pull/4","diff_url":"https://github.com/sonoro1234/supercollider/pull/4.diff","patch_url":"https://github.com/sonoro1234/supercollider/pull/4.patch","issue_url":"https://api.github.com/repos/sonoro1234/supercollider/issues/4","number":4,"state":"open","locked":false,"title":"Supernova: Don't print spurious late messages for immediate bundles","user":{"login":"jamshark70","id":318301,"avatar_url":"https://avatars.githubusercontent.com/u/318301?v=3","gravatar_id":"","url":"https://api.github.com/users/jamshark70","html_url":"https://github.com/jamshark70","followers_url":"https://api.github.com/users/jamshark70/followers","following_url":"https://api.github.com/users/jamshark70/following{/other_user}","gists_url":"https://api.github.com/users/jamshark70/gists{/gist_id}","starred_url":"https://api.github.com/users/jamshark70/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamshark70/subscriptions","organizations_url":"https://api.github.com/users/jamshark70/orgs","repos_url":"https://api.github.com/users/jamshark70/repos","events_url":"https://api.github.com/users/jamshark70/events{/privacy}","received_events_url":"https://api.github.com/users/jamshark70/received_events","type":"User","site_admin":false},"body":"I found this issue while testing your timedll branch -- supernova prints unnecessary \"late\" messages for bundles with \"immediate\" timestamps. The condition for printing a late message is if the time tag is less than now. An immediate time tag has a uint64 value == 1, which is always less than now.\r\n\r\nThe code is quite different between supercollider/supercollider/master and sonoro1234/supercollider/timedll, so I think I shouldn't make a pull request against the main repository. So I'm sending the PR specifically to your branch, and it can be pushed up to the main repository in due time.\r\n\r\nThanks for working on the timedll, by the way!\r\n\r\nTests:\r\n\r\n```\r\ns.sendMsg(\\c_set, 0, 0.63);  // should not say \"late\"\r\n\r\ns.sendBundle(0.2, [\\c_set, 0, 0.63]);  // should not say \"late\"\r\n\r\ns.sendBundle(0.0, [\\c_set, 0, 0.63]);  // SHOULD (and does) say \"late\"\r\n\r\ns.sendBundle(nil, [\\c_set, 0, 0.63]);  // should not say \"late,\" but does w/o fix\r\n```","created_at":"2015-05-30T07:14:34Z","updated_at":"2015-05-30T07:14:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sonoro1234/supercollider/pulls/4/commits","review_comments_url":"https://api.github.com/repos/sonoro1234/supercollider/pulls/4/comments","review_comment_url":"https://api.github.com/repos/sonoro1234/supercollider/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonoro1234/supercollider/issues/4/comments","statuses_url":"https://api.github.com/repos/sonoro1234/supercollider/statuses/73fe727c72b19580d17c31194e90ef56037d525b","head":{"label":"jamshark70:supernova-late-msgs","ref":"supernova-late-msgs","sha":"73fe727c72b19580d17c31194e90ef56037d525b","user":{"login":"jamshark70","id":318301,"avatar_url":"https://avatars.githubusercontent.com/u/318301?v=3","gravatar_id":"","url":"https://api.github.com/users/jamshark70","html_url":"https://github.com/jamshark70","followers_url":"https://api.github.com/users/jamshark70/followers","following_url":"https://api.github.com/users/jamshark70/following{/other_user}","gists_url":"https://api.github.com/users/jamshark70/gists{/gist_id}","starred_url":"https://api.github.com/users/jamshark70/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamshark70/subscriptions","organizations_url":"https://api.github.com/users/jamshark70/orgs","repos_url":"https://api.github.com/users/jamshark70/repos","events_url":"https://api.github.com/users/jamshark70/events{/privacy}","received_events_url":"https://api.github.com/users/jamshark70/received_events","type":"User","site_admin":false},"repo":{"id":15625264,"name":"supercollider-rename","full_name":"jamshark70/supercollider-rename","owner":{"login":"jamshark70","id":318301,"avatar_url":"https://avatars.githubusercontent.com/u/318301?v=3","gravatar_id":"","url":"https://api.github.com/users/jamshark70","html_url":"https://github.com/jamshark70","followers_url":"https://api.github.com/users/jamshark70/followers","following_url":"https://api.github.com/users/jamshark70/following{/other_user}","gists_url":"https://api.github.com/users/jamshark70/gists{/gist_id}","starred_url":"https://api.github.com/users/jamshark70/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamshark70/subscriptions","organizations_url":"https://api.github.com/users/jamshark70/orgs","repos_url":"https://api.github.com/users/jamshark70/repos","events_url":"https://api.github.com/users/jamshark70/events{/privacy}","received_events_url":"https://api.github.com/users/jamshark70/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jamshark70/supercollider-rename","description":"an environment and programming language for real time audio synthesis and algorithmic composition","fork":true,"url":"https://api.github.com/repos/jamshark70/supercollider-rename","forks_url":"https://api.github.com/repos/jamshark70/supercollider-rename/forks","keys_url":"https://api.github.com/repos/jamshark70/supercollider-rename/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jamshark70/supercollider-rename/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jamshark70/supercollider-rename/teams","hooks_url":"https://api.github.com/repos/jamshark70/supercollider-rename/hooks","issue_events_url":"https://api.github.com/repos/jamshark70/supercollider-rename/issues/events{/number}","events_url":"https://api.github.com/repos/jamshark70/supercollider-rename/events","assignees_url":"https://api.github.com/repos/jamshark70/supercollider-rename/assignees{/user}","branches_url":"https://api.github.com/repos/jamshark70/supercollider-rename/branches{/branch}","tags_url":"https://api.github.com/repos/jamshark70/supercollider-rename/tags","blobs_url":"https://api.github.com/repos/jamshark70/supercollider-rename/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jamshark70/supercollider-rename/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jamshark70/supercollider-rename/git/refs{/sha}","trees_url":"https://api.github.com/repos/jamshark70/supercollider-rename/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jamshark70/supercollider-rename/statuses/{sha}","languages_url":"https://api.github.com/repos/jamshark70/supercollider-rename/languages","stargazers_url":"https://api.github.com/repos/jamshark70/supercollider-rename/stargazers","contributors_url":"https://api.github.com/repos/jamshark70/supercollider-rename/contributors","subscribers_url":"https://api.github.com/repos/jamshark70/supercollider-rename/subscribers","subscription_url":"https://api.github.com/repos/jamshark70/supercollider-rename/subscription","commits_url":"https://api.github.com/repos/jamshark70/supercollider-rename/commits{/sha}","git_commits_url":"https://api.github.com/repos/jamshark70/supercollider-rename/git/commits{/sha}","comments_url":"https://api.github.com/repos/jamshark70/supercollider-rename/comments{/number}","issue_comment_url":"https://api.github.com/repos/jamshark70/supercollider-rename/issues/comments{/number}","contents_url":"https://api.github.com/repos/jamshark70/supercollider-rename/contents/{+path}","compare_url":"https://api.github.com/repos/jamshark70/supercollider-rename/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jamshark70/supercollider-rename/merges","archive_url":"https://api.github.com/repos/jamshark70/supercollider-rename/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jamshark70/supercollider-rename/downloads","issues_url":"https://api.github.com/repos/jamshark70/supercollider-rename/issues{/number}","pulls_url":"https://api.github.com/repos/jamshark70/supercollider-rename/pulls{/number}","milestones_url":"https://api.github.com/repos/jamshark70/supercollider-rename/milestones{/number}","notifications_url":"https://api.github.com/repos/jamshark70/supercollider-rename/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jamshark70/supercollider-rename/labels{/name}","releases_url":"https://api.github.com/repos/jamshark70/supercollider-rename/releases{/id}","created_at":"2014-01-04T03:01:29Z","updated_at":"2015-04-27T03:11:26Z","pushed_at":"2015-05-30T07:12:11Z","git_url":"git://github.com/jamshark70/supercollider-rename.git","ssh_url":"git@github.com:jamshark70/supercollider-rename.git","clone_url":"https://github.com/jamshark70/supercollider-rename.git","svn_url":"https://github.com/jamshark70/supercollider-rename","homepage":null,"size":60189,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sonoro1234:timedll","ref":"timedll","sha":"20c21ede56d9f88268dd30ff829b3af001cb00f1","user":{"login":"sonoro1234","id":1795930,"avatar_url":"https://avatars.githubusercontent.com/u/1795930?v=3","gravatar_id":"","url":"https://api.github.com/users/sonoro1234","html_url":"https://github.com/sonoro1234","followers_url":"https://api.github.com/users/sonoro1234/followers","following_url":"https://api.github.com/users/sonoro1234/following{/other_user}","gists_url":"https://api.github.com/users/sonoro1234/gists{/gist_id}","starred_url":"https://api.github.com/users/sonoro1234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonoro1234/subscriptions","organizations_url":"https://api.github.com/users/sonoro1234/orgs","repos_url":"https://api.github.com/users/sonoro1234/repos","events_url":"https://api.github.com/users/sonoro1234/events{/privacy}","received_events_url":"https://api.github.com/users/sonoro1234/received_events","type":"User","site_admin":false},"repo":{"id":31024327,"name":"supercollider","full_name":"sonoro1234/supercollider","owner":{"login":"sonoro1234","id":1795930,"avatar_url":"https://avatars.githubusercontent.com/u/1795930?v=3","gravatar_id":"","url":"https://api.github.com/users/sonoro1234","html_url":"https://github.com/sonoro1234","followers_url":"https://api.github.com/users/sonoro1234/followers","following_url":"https://api.github.com/users/sonoro1234/following{/other_user}","gists_url":"https://api.github.com/users/sonoro1234/gists{/gist_id}","starred_url":"https://api.github.com/users/sonoro1234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonoro1234/subscriptions","organizations_url":"https://api.github.com/users/sonoro1234/orgs","repos_url":"https://api.github.com/users/sonoro1234/repos","events_url":"https://api.github.com/users/sonoro1234/events{/privacy}","received_events_url":"https://api.github.com/users/sonoro1234/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sonoro1234/supercollider","description":"A programming language for real time audio synthesis and algorithmic composition","fork":true,"url":"https://api.github.com/repos/sonoro1234/supercollider","forks_url":"https://api.github.com/repos/sonoro1234/supercollider/forks","keys_url":"https://api.github.com/repos/sonoro1234/supercollider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonoro1234/supercollider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonoro1234/supercollider/teams","hooks_url":"https://api.github.com/repos/sonoro1234/supercollider/hooks","issue_events_url":"https://api.github.com/repos/sonoro1234/supercollider/issues/events{/number}","events_url":"https://api.github.com/repos/sonoro1234/supercollider/events","assignees_url":"https://api.github.com/repos/sonoro1234/supercollider/assignees{/user}","branches_url":"https://api.github.com/repos/sonoro1234/supercollider/branches{/branch}","tags_url":"https://api.github.com/repos/sonoro1234/supercollider/tags","blobs_url":"https://api.github.com/repos/sonoro1234/supercollider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonoro1234/supercollider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonoro1234/supercollider/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonoro1234/supercollider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonoro1234/supercollider/statuses/{sha}","languages_url":"https://api.github.com/repos/sonoro1234/supercollider/languages","stargazers_url":"https://api.github.com/repos/sonoro1234/supercollider/stargazers","contributors_url":"https://api.github.com/repos/sonoro1234/supercollider/contributors","subscribers_url":"https://api.github.com/repos/sonoro1234/supercollider/subscribers","subscription_url":"https://api.github.com/repos/sonoro1234/supercollider/subscription","commits_url":"https://api.github.com/repos/sonoro1234/supercollider/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonoro1234/supercollider/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonoro1234/supercollider/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonoro1234/supercollider/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonoro1234/supercollider/contents/{+path}","compare_url":"https://api.github.com/repos/sonoro1234/supercollider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonoro1234/supercollider/merges","archive_url":"https://api.github.com/repos/sonoro1234/supercollider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonoro1234/supercollider/downloads","issues_url":"https://api.github.com/repos/sonoro1234/supercollider/issues{/number}","pulls_url":"https://api.github.com/repos/sonoro1234/supercollider/pulls{/number}","milestones_url":"https://api.github.com/repos/sonoro1234/supercollider/milestones{/number}","notifications_url":"https://api.github.com/repos/sonoro1234/supercollider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonoro1234/supercollider/labels{/name}","releases_url":"https://api.github.com/repos/sonoro1234/supercollider/releases{/id}","created_at":"2015-02-19T16:23:45Z","updated_at":"2015-05-07T15:57:12Z","pushed_at":"2015-05-30T07:03:30Z","git_url":"git://github.com/sonoro1234/supercollider.git","ssh_url":"git@github.com:sonoro1234/supercollider.git","clone_url":"https://github.com/sonoro1234/supercollider.git","svn_url":"https://github.com/sonoro1234/supercollider","homepage":"supercollider.github.io","size":60071,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sonoro1234/supercollider/pulls/4"},"html":{"href":"https://github.com/sonoro1234/supercollider/pull/4"},"issue":{"href":"https://api.github.com/repos/sonoro1234/supercollider/issues/4"},"comments":{"href":"https://api.github.com/repos/sonoro1234/supercollider/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/sonoro1234/supercollider/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/sonoro1234/supercollider/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonoro1234/supercollider/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/sonoro1234/supercollider/statuses/73fe727c72b19580d17c31194e90ef56037d525b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":9,"deletions":2,"changed_files":2}}