{"action":"created","issue":{"url":"https://api.github.com/repos/timruffles/ios-html5-drag-drop-shim/issues/44","labels_url":"https://api.github.com/repos/timruffles/ios-html5-drag-drop-shim/issues/44/labels{/name}","comments_url":"https://api.github.com/repos/timruffles/ios-html5-drag-drop-shim/issues/44/comments","events_url":"https://api.github.com/repos/timruffles/ios-html5-drag-drop-shim/issues/44/events","html_url":"https://github.com/timruffles/ios-html5-drag-drop-shim/pull/44","id":100077588,"number":44,"title":"Complete rewrite for HTML5 spec compatiblity","user":{"login":"reppners","id":3855704,"avatar_url":"https://avatars.githubusercontent.com/u/3855704?v=3","gravatar_id":"","url":"https://api.github.com/users/reppners","html_url":"https://github.com/reppners","followers_url":"https://api.github.com/users/reppners/followers","following_url":"https://api.github.com/users/reppners/following{/other_user}","gists_url":"https://api.github.com/users/reppners/gists{/gist_id}","starred_url":"https://api.github.com/users/reppners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reppners/subscriptions","organizations_url":"https://api.github.com/users/reppners/orgs","repos_url":"https://api.github.com/users/reppners/repos","events_url":"https://api.github.com/users/reppners/events{/privacy}","received_events_url":"https://api.github.com/users/reppners/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2015-08-10T14:17:22Z","updated_at":"2015-08-27T11:37:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/timruffles/ios-html5-drag-drop-shim/pulls/44","html_url":"https://github.com/timruffles/ios-html5-drag-drop-shim/pull/44","diff_url":"https://github.com/timruffles/ios-html5-drag-drop-shim/pull/44.diff","patch_url":"https://github.com/timruffles/ios-html5-drag-drop-shim/pull/44.patch"},"body":"Hey there,\r\n\r\nit started out as an attempt to make this shim work with an existing html5 drag and drop library we use in our angular project and ended up as a rewrite that is as close as possible to the HTML5 spec and support for all mobile browsers, making it a polyfill that aims to fill the gap for all browsers currently not implementing the spec natively.\r\n\r\nAre you interested in pulling this back in?"},"comment":{"url":"https://api.github.com/repos/timruffles/ios-html5-drag-drop-shim/issues/comments/135395181","html_url":"https://github.com/timruffles/ios-html5-drag-drop-shim/pull/44#issuecomment-135395181","issue_url":"https://api.github.com/repos/timruffles/ios-html5-drag-drop-shim/issues/44","id":135395181,"user":{"login":"timruffles","id":249800,"avatar_url":"https://avatars.githubusercontent.com/u/249800?v=3","gravatar_id":"","url":"https://api.github.com/users/timruffles","html_url":"https://github.com/timruffles","followers_url":"https://api.github.com/users/timruffles/followers","following_url":"https://api.github.com/users/timruffles/following{/other_user}","gists_url":"https://api.github.com/users/timruffles/gists{/gist_id}","starred_url":"https://api.github.com/users/timruffles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timruffles/subscriptions","organizations_url":"https://api.github.com/users/timruffles/orgs","repos_url":"https://api.github.com/users/timruffles/repos","events_url":"https://api.github.com/users/timruffles/events{/privacy}","received_events_url":"https://api.github.com/users/timruffles/received_events","type":"User","site_admin":false},"created_at":"2015-08-27T11:37:41Z","updated_at":"2015-08-27T11:37:41Z","body":"As you've done a heap of work, I wanted to get involved a bit. I made a [quick stab](https://github.com/reppners/ios-html5-drag-drop-shim/compare/refactoring...timruffles:ts-privacy) at moving all methods that don't rely on internal state to stand-alone functions. Cuts down the compiled code size and simplifies the code, keeping stuff that potentially read/writes from mutable state to a minimum.\r\n\r\nI've never written a line of TypeScript so this is probably a mess :)\r\n\r\nOne other request - if you're hoping to have the original maintainers involved - is to strip out the tautological @param style comments, e.g\r\n\r\n```ts\r\n    /** ...\r\n        * @param e\r\n        * @constructor\r\n        */\r\n    function OnTouchstart( e:TouchEvent ) {\r\n```\r\n\r\nIt's noisy and kills readability for me. The JS community's style is very minimalist when it comes to commenting. Especially with TypeScript's richer type system, the Javadoc style comments don't seem justified.\r\n\r\nI still feel there is a leaner, meaner version of the typescript code we could squeeze out. Right now I can't navigate the code to get a feel for it due to the comment blizzard :)"}}