{"action":"created","issue":{"url":"https://api.github.com/repos/joyent/node/issues/14574","labels_url":"https://api.github.com/repos/joyent/node/issues/14574/labels{/name}","comments_url":"https://api.github.com/repos/joyent/node/issues/14574/comments","events_url":"https://api.github.com/repos/joyent/node/issues/14574/events","html_url":"https://github.com/joyent/node/pull/14574","id":67242456,"number":14574,"title":"tls: throw an error on getLegacyCipher","user":{"login":"jasnell","id":439929,"avatar_url":"https://avatars.githubusercontent.com/u/439929?v=3","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joyent/node/labels/in%20progress","name":"in progress","color":"ededed"},{"url":"https://api.github.com/repos/joyent/node/labels/master","name":"master","color":"5319e7"},{"url":"https://api.github.com/repos/joyent/node/labels/pr","name":"pr","color":"006b75"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-04-08T23:27:50Z","updated_at":"2015-04-16T13:23:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joyent/node/pulls/14574","html_url":"https://github.com/joyent/node/pull/14574","diff_url":"https://github.com/joyent/node/pull/14574.diff","patch_url":"https://github.com/joyent/node/pull/14574.patch"},"body":"throw an error on unknown getLegacyCipher input\r\nrather than returning the default. Makes the\r\nbehavior more explicit and matches up with the\r\nbehavior on the command line switches."},"comment":{"url":"https://api.github.com/repos/joyent/node/issues/comments/93732790","html_url":"https://github.com/joyent/node/pull/14574#issuecomment-93732790","issue_url":"https://api.github.com/repos/joyent/node/issues/14574","id":93732790,"user":{"login":"mdawsonibm","id":9373002,"avatar_url":"https://avatars.githubusercontent.com/u/9373002?v=3","gravatar_id":"","url":"https://api.github.com/users/mdawsonibm","html_url":"https://github.com/mdawsonibm","followers_url":"https://api.github.com/users/mdawsonibm/followers","following_url":"https://api.github.com/users/mdawsonibm/following{/other_user}","gists_url":"https://api.github.com/users/mdawsonibm/gists{/gist_id}","starred_url":"https://api.github.com/users/mdawsonibm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdawsonibm/subscriptions","organizations_url":"https://api.github.com/users/mdawsonibm/orgs","repos_url":"https://api.github.com/users/mdawsonibm/repos","events_url":"https://api.github.com/users/mdawsonibm/events{/privacy}","received_events_url":"https://api.github.com/users/mdawsonibm/received_events","type":"User","site_admin":false},"created_at":"2015-04-16T13:23:20Z","updated_at":"2015-04-16T13:23:20Z","body":"One minor nit.  Should the tests validate the type of the Error, ie a TypeError or an Error as appropriate ? Otherwise lgtm."}}