{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/jquense/react/pulls/1","id":54884580,"html_url":"https://github.com/jquense/react/pull/1","diff_url":"https://github.com/jquense/react/pull/1.diff","patch_url":"https://github.com/jquense/react/pull/1.patch","issue_url":"https://api.github.com/repos/jquense/react/issues/1","number":1,"state":"open","locked":false,"title":"Mouse enter leave","user":{"login":"jquense","id":339286,"avatar_url":"https://avatars.githubusercontent.com/u/339286?v=3","gravatar_id":"","url":"https://api.github.com/users/jquense","html_url":"https://github.com/jquense","followers_url":"https://api.github.com/users/jquense/followers","following_url":"https://api.github.com/users/jquense/following{/other_user}","gists_url":"https://api.github.com/users/jquense/gists{/gist_id}","starred_url":"https://api.github.com/users/jquense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquense/subscriptions","organizations_url":"https://api.github.com/users/jquense/orgs","repos_url":"https://api.github.com/users/jquense/repos","events_url":"https://api.github.com/users/jquense/events{/privacy}","received_events_url":"https://api.github.com/users/jquense/received_events","type":"User","site_admin":false},"body":"makes an attempt at fixing #4251.\r\n\r\nFirst, I added support for native mouseenter and mouseleave, I am not sure why they weren't used before, there may have been a good reason I didn't realize :)\r\n\r\nDrastically changes how enter|leave is implemented, modeling the jQuery approach. I tried to keep with the current implementation but browsers just don't fire the necessary mouse events so it seemed that there was no way to \"fix\" the current approach.\r\n\r\nThe EnterLeave logic is pretty deeply integrated so I am not sure I added the various utils in the write spot to maintain the right sort of encapsulation.\r\n\r\nWhile fairly easy to implement with normal handlers the React event system made this sort of tough since you don't know interested nodes. One concern with this approach is that it needs to walk up the instance tree for every mouseout|over event fired to try and find a parent node listening for enter|leave. I thought this approach was more in keeping with how stuff works other places, but I wasn't sure if it represents an unacceptable perf concern (my light testing didn't seem to indicate that). \r\n\r\nAlternatively I could have just used the `didPutListener` hook to manually attach mouse over|out listeners.\r\n\r\nThere could also be a hook or accumulation pattern that does this already that I missed.\r\n\r\nthanks for all the hard work ya'll and Happy new years!","created_at":"2016-01-01T00:00:08Z","updated_at":"2016-01-01T00:00:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jquense/react/pulls/1/commits","review_comments_url":"https://api.github.com/repos/jquense/react/pulls/1/comments","review_comment_url":"https://api.github.com/repos/jquense/react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jquense/react/issues/1/comments","statuses_url":"https://api.github.com/repos/jquense/react/statuses/bed60a178a7802da76e126085bde8830e4609897","head":{"label":"jquense:mouse-enter-leave","ref":"mouse-enter-leave","sha":"bed60a178a7802da76e126085bde8830e4609897","user":{"login":"jquense","id":339286,"avatar_url":"https://avatars.githubusercontent.com/u/339286?v=3","gravatar_id":"","url":"https://api.github.com/users/jquense","html_url":"https://github.com/jquense","followers_url":"https://api.github.com/users/jquense/followers","following_url":"https://api.github.com/users/jquense/following{/other_user}","gists_url":"https://api.github.com/users/jquense/gists{/gist_id}","starred_url":"https://api.github.com/users/jquense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquense/subscriptions","organizations_url":"https://api.github.com/users/jquense/orgs","repos_url":"https://api.github.com/users/jquense/repos","events_url":"https://api.github.com/users/jquense/events{/privacy}","received_events_url":"https://api.github.com/users/jquense/received_events","type":"User","site_admin":false},"repo":{"id":24542193,"name":"react","full_name":"jquense/react","owner":{"login":"jquense","id":339286,"avatar_url":"https://avatars.githubusercontent.com/u/339286?v=3","gravatar_id":"","url":"https://api.github.com/users/jquense","html_url":"https://github.com/jquense","followers_url":"https://api.github.com/users/jquense/followers","following_url":"https://api.github.com/users/jquense/following{/other_user}","gists_url":"https://api.github.com/users/jquense/gists{/gist_id}","starred_url":"https://api.github.com/users/jquense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquense/subscriptions","organizations_url":"https://api.github.com/users/jquense/orgs","repos_url":"https://api.github.com/users/jquense/repos","events_url":"https://api.github.com/users/jquense/events{/privacy}","received_events_url":"https://api.github.com/users/jquense/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jquense/react","description":"React is a JavaScript library for building user interfaces. It's declarative, efficient, and extremely flexible. What's more, it works with the libraries and frameworks that you already know.","fork":true,"url":"https://api.github.com/repos/jquense/react","forks_url":"https://api.github.com/repos/jquense/react/forks","keys_url":"https://api.github.com/repos/jquense/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jquense/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jquense/react/teams","hooks_url":"https://api.github.com/repos/jquense/react/hooks","issue_events_url":"https://api.github.com/repos/jquense/react/issues/events{/number}","events_url":"https://api.github.com/repos/jquense/react/events","assignees_url":"https://api.github.com/repos/jquense/react/assignees{/user}","branches_url":"https://api.github.com/repos/jquense/react/branches{/branch}","tags_url":"https://api.github.com/repos/jquense/react/tags","blobs_url":"https://api.github.com/repos/jquense/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jquense/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jquense/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/jquense/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jquense/react/statuses/{sha}","languages_url":"https://api.github.com/repos/jquense/react/languages","stargazers_url":"https://api.github.com/repos/jquense/react/stargazers","contributors_url":"https://api.github.com/repos/jquense/react/contributors","subscribers_url":"https://api.github.com/repos/jquense/react/subscribers","subscription_url":"https://api.github.com/repos/jquense/react/subscription","commits_url":"https://api.github.com/repos/jquense/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/jquense/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/jquense/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/jquense/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/jquense/react/contents/{+path}","compare_url":"https://api.github.com/repos/jquense/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jquense/react/merges","archive_url":"https://api.github.com/repos/jquense/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jquense/react/downloads","issues_url":"https://api.github.com/repos/jquense/react/issues{/number}","pulls_url":"https://api.github.com/repos/jquense/react/pulls{/number}","milestones_url":"https://api.github.com/repos/jquense/react/milestones{/number}","notifications_url":"https://api.github.com/repos/jquense/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jquense/react/labels{/name}","releases_url":"https://api.github.com/repos/jquense/react/releases{/id}","created_at":"2014-09-27T20:36:16Z","updated_at":"2015-05-06T13:00:26Z","pushed_at":"2016-01-01T00:00:02Z","git_url":"git://github.com/jquense/react.git","ssh_url":"git@github.com:jquense/react.git","clone_url":"https://github.com/jquense/react.git","svn_url":"https://github.com/jquense/react","homepage":"http://facebook.github.io/react/","size":58369,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"jquense:master","ref":"master","sha":"51295bf7d014c3225f14e11c408da438a7f84f5f","user":{"login":"jquense","id":339286,"avatar_url":"https://avatars.githubusercontent.com/u/339286?v=3","gravatar_id":"","url":"https://api.github.com/users/jquense","html_url":"https://github.com/jquense","followers_url":"https://api.github.com/users/jquense/followers","following_url":"https://api.github.com/users/jquense/following{/other_user}","gists_url":"https://api.github.com/users/jquense/gists{/gist_id}","starred_url":"https://api.github.com/users/jquense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquense/subscriptions","organizations_url":"https://api.github.com/users/jquense/orgs","repos_url":"https://api.github.com/users/jquense/repos","events_url":"https://api.github.com/users/jquense/events{/privacy}","received_events_url":"https://api.github.com/users/jquense/received_events","type":"User","site_admin":false},"repo":{"id":24542193,"name":"react","full_name":"jquense/react","owner":{"login":"jquense","id":339286,"avatar_url":"https://avatars.githubusercontent.com/u/339286?v=3","gravatar_id":"","url":"https://api.github.com/users/jquense","html_url":"https://github.com/jquense","followers_url":"https://api.github.com/users/jquense/followers","following_url":"https://api.github.com/users/jquense/following{/other_user}","gists_url":"https://api.github.com/users/jquense/gists{/gist_id}","starred_url":"https://api.github.com/users/jquense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquense/subscriptions","organizations_url":"https://api.github.com/users/jquense/orgs","repos_url":"https://api.github.com/users/jquense/repos","events_url":"https://api.github.com/users/jquense/events{/privacy}","received_events_url":"https://api.github.com/users/jquense/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jquense/react","description":"React is a JavaScript library for building user interfaces. It's declarative, efficient, and extremely flexible. What's more, it works with the libraries and frameworks that you already know.","fork":true,"url":"https://api.github.com/repos/jquense/react","forks_url":"https://api.github.com/repos/jquense/react/forks","keys_url":"https://api.github.com/repos/jquense/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jquense/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jquense/react/teams","hooks_url":"https://api.github.com/repos/jquense/react/hooks","issue_events_url":"https://api.github.com/repos/jquense/react/issues/events{/number}","events_url":"https://api.github.com/repos/jquense/react/events","assignees_url":"https://api.github.com/repos/jquense/react/assignees{/user}","branches_url":"https://api.github.com/repos/jquense/react/branches{/branch}","tags_url":"https://api.github.com/repos/jquense/react/tags","blobs_url":"https://api.github.com/repos/jquense/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jquense/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jquense/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/jquense/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jquense/react/statuses/{sha}","languages_url":"https://api.github.com/repos/jquense/react/languages","stargazers_url":"https://api.github.com/repos/jquense/react/stargazers","contributors_url":"https://api.github.com/repos/jquense/react/contributors","subscribers_url":"https://api.github.com/repos/jquense/react/subscribers","subscription_url":"https://api.github.com/repos/jquense/react/subscription","commits_url":"https://api.github.com/repos/jquense/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/jquense/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/jquense/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/jquense/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/jquense/react/contents/{+path}","compare_url":"https://api.github.com/repos/jquense/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jquense/react/merges","archive_url":"https://api.github.com/repos/jquense/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jquense/react/downloads","issues_url":"https://api.github.com/repos/jquense/react/issues{/number}","pulls_url":"https://api.github.com/repos/jquense/react/pulls{/number}","milestones_url":"https://api.github.com/repos/jquense/react/milestones{/number}","notifications_url":"https://api.github.com/repos/jquense/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jquense/react/labels{/name}","releases_url":"https://api.github.com/repos/jquense/react/releases{/id}","created_at":"2014-09-27T20:36:16Z","updated_at":"2015-05-06T13:00:26Z","pushed_at":"2016-01-01T00:00:02Z","git_url":"git://github.com/jquense/react.git","ssh_url":"git@github.com:jquense/react.git","clone_url":"https://github.com/jquense/react.git","svn_url":"https://github.com/jquense/react","homepage":"http://facebook.github.io/react/","size":58369,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jquense/react/pulls/1"},"html":{"href":"https://github.com/jquense/react/pull/1"},"issue":{"href":"https://api.github.com/repos/jquense/react/issues/1"},"comments":{"href":"https://api.github.com/repos/jquense/react/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/jquense/react/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/jquense/react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jquense/react/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/jquense/react/statuses/bed60a178a7802da76e126085bde8830e4609897"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":315,"deletions":238,"changed_files":7}}