{"action":"created","issue":{"url":"https://api.github.com/repos/randombit/botan/issues/107","labels_url":"https://api.github.com/repos/randombit/botan/issues/107/labels{/name}","comments_url":"https://api.github.com/repos/randombit/botan/issues/107/comments","events_url":"https://api.github.com/repos/randombit/botan/issues/107/events","html_url":"https://github.com/randombit/botan/pull/107","id":85898163,"number":107,"title":"Fix LIBNAME being defined twice","user":{"login":"cdesjardins","id":1149188,"avatar_url":"https://avatars.githubusercontent.com/u/1149188?v=3","gravatar_id":"","url":"https://api.github.com/users/cdesjardins","html_url":"https://github.com/cdesjardins","followers_url":"https://api.github.com/users/cdesjardins/followers","following_url":"https://api.github.com/users/cdesjardins/following{/other_user}","gists_url":"https://api.github.com/users/cdesjardins/gists{/gist_id}","starred_url":"https://api.github.com/users/cdesjardins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdesjardins/subscriptions","organizations_url":"https://api.github.com/users/cdesjardins/orgs","repos_url":"https://api.github.com/users/cdesjardins/repos","events_url":"https://api.github.com/users/cdesjardins/events{/privacy}","received_events_url":"https://api.github.com/users/cdesjardins/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-06-07T12:26:18Z","updated_at":"2015-06-11T09:16:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/randombit/botan/pulls/107","html_url":"https://github.com/randombit/botan/pull/107","diff_url":"https://github.com/randombit/botan/pull/107.diff","patch_url":"https://github.com/randombit/botan/pull/107.patch"},"body":"Some magic puts \r\nLIBNAME        = botan-1.11\r\n\r\nin the nmake Makefile, but then later it is changed to just\r\nLIBNAME        = botan\r\n\r\nWhich causes problems when installing the library, this change will remove that second def."},"comment":{"url":"https://api.github.com/repos/randombit/botan/issues/comments/111054995","html_url":"https://github.com/randombit/botan/pull/107#issuecomment-111054995","issue_url":"https://api.github.com/repos/randombit/botan/issues/107","id":111054995,"user":{"login":"webmaster128","id":2603011,"avatar_url":"https://avatars.githubusercontent.com/u/2603011?v=3","gravatar_id":"","url":"https://api.github.com/users/webmaster128","html_url":"https://github.com/webmaster128","followers_url":"https://api.github.com/users/webmaster128/followers","following_url":"https://api.github.com/users/webmaster128/following{/other_user}","gists_url":"https://api.github.com/users/webmaster128/gists{/gist_id}","starred_url":"https://api.github.com/users/webmaster128/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmaster128/subscriptions","organizations_url":"https://api.github.com/users/webmaster128/orgs","repos_url":"https://api.github.com/users/webmaster128/repos","events_url":"https://api.github.com/users/webmaster128/events{/privacy}","received_events_url":"https://api.github.com/users/webmaster128/received_events","type":"User","site_admin":false},"created_at":"2015-06-11T09:16:51Z","updated_at":"2015-06-11T09:16:51Z","body":"The screenshot is only mingw because git bash uses it on Windows. The build is also MSVC 2013 using the nmake.in with jom. The difference might be this case distinction in the link command:\r\n\r\n```\r\n$(BOTAN_LIB): $(LIBOBJS)\r\n!If \"$(SO_OBJ_FLAGS)\" == \"\"\r\n\t$(AR) /OUT:$(BOTAN_LIB) $(LIBOBJS)\r\n!Else\r\n\t$(LIB_LINK_CMD) /Fe$(LIBNAME) $(LIBOBJS) $(LIB_LINKS_TO)\r\n!Endif\r\n```\r\n\r\nIn my Makefile `SO_OBJ_FLAGS   =  /DBOTAN_DLL=__declspec(dllexport)`, so I think the second one is used. What about yours?"}}