{"action":"created","issue":{"url":"https://api.github.com/repos/morrissinger/ESP8266-Websocket/issues/2","labels_url":"https://api.github.com/repos/morrissinger/ESP8266-Websocket/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/morrissinger/ESP8266-Websocket/issues/2/comments","events_url":"https://api.github.com/repos/morrissinger/ESP8266-Websocket/issues/2/events","html_url":"https://github.com/morrissinger/ESP8266-Websocket/issues/2","id":109324436,"number":2,"title":"handshake error","user":{"login":"jc19000","id":4046379,"avatar_url":"https://avatars.githubusercontent.com/u/4046379?v=3","gravatar_id":"","url":"https://api.github.com/users/jc19000","html_url":"https://github.com/jc19000","followers_url":"https://api.github.com/users/jc19000/followers","following_url":"https://api.github.com/users/jc19000/following{/other_user}","gists_url":"https://api.github.com/users/jc19000/gists{/gist_id}","starred_url":"https://api.github.com/users/jc19000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jc19000/subscriptions","organizations_url":"https://api.github.com/users/jc19000/orgs","repos_url":"https://api.github.com/users/jc19000/repos","events_url":"https://api.github.com/users/jc19000/events{/privacy}","received_events_url":"https://api.github.com/users/jc19000/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-01T15:30:04Z","updated_at":"2015-10-09T13:08:21Z","closed_at":null,"body":"Dear morrissinger,\r\n\r\nI have some issue with yout websocket client part. I try with example as you defined and i have the following message on the serial port:\r\n\r\nConnecting to NUMERICABLE-A8B3\r\n.........\r\nWiFi connected\r\nIP address:\r\n192.168.0.22\r\nConnection failed.\r\n\r\nctx: cont\r\nsp: 3ffea780 end: 3ffea960 offset: 01b0\r\n\r\n>>>stack>>>\r\n3ffea930:  3ffe8f88 1600a8c0 00000000 00000000\r\n3ffea940:  3fffdc20 00000000 3ffea984 40201863\r\n3ffea950:  00000000 00000000 3ffe9940 40100db4\r\n▒▒▒▒L▒<1▒▒▒\r\n\r\n\r\nI modify the different information and try to connect to my own websocket server and i have the following message:\r\nConnecting to NUMERICABLE-A8B3\r\n...........\r\nWiFi connected\r\nIP address:\r\n192.168.0.22\r\nConnected\r\nClient connected\r\nSending websocket upgrade headers\r\nAnalyzing response headers\r\nInvalid ANALYSE REQUEST\r\nTerminating socket\r\nHandshake failed.\r\n\r\nI also test my server with the websocket echo online client and it worked. But with your client it does not work It seems that the client nerver received data from the handshake.\r\n\r\nDid you have a client example that works?\r\n"},"comment":{"url":"https://api.github.com/repos/morrissinger/ESP8266-Websocket/issues/comments/146866868","html_url":"https://github.com/morrissinger/ESP8266-Websocket/issues/2#issuecomment-146866868","issue_url":"https://api.github.com/repos/morrissinger/ESP8266-Websocket/issues/2","id":146866868,"user":{"login":"frippe75","id":7848204,"avatar_url":"https://avatars.githubusercontent.com/u/7848204?v=3","gravatar_id":"","url":"https://api.github.com/users/frippe75","html_url":"https://github.com/frippe75","followers_url":"https://api.github.com/users/frippe75/followers","following_url":"https://api.github.com/users/frippe75/following{/other_user}","gists_url":"https://api.github.com/users/frippe75/gists{/gist_id}","starred_url":"https://api.github.com/users/frippe75/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frippe75/subscriptions","organizations_url":"https://api.github.com/users/frippe75/orgs","repos_url":"https://api.github.com/users/frippe75/repos","events_url":"https://api.github.com/users/frippe75/events{/privacy}","received_events_url":"https://api.github.com/users/frippe75/received_events","type":"User","site_admin":false},"created_at":"2015-10-09T13:08:21Z","updated_at":"2015-10-09T13:08:21Z","body":"I'm having the same issue as of yesterday. Found some simple errors I will be sending you a pull request later on. As to the handshake issue.\r\n\r\nLooking at the handshake part its clearly stated that improvements to both string extraction and the string compare part of upgrade requests \"Upgrade: WebSocket\" that sets the foundupgrade variable is needed. \r\n\r\nI used firefox to trace the upgrade request and firefox is falling into the category of \"Upgrade: websocket\" which is covered by the first elseif. But in my case I think that socket_client->read() fails to get any data because I enable debugging and the line \"Got Line:\" never appeared over serial. So two options. Either no data or no newline. Will look more into this later this weekend."}}