{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/cudevmaxwell/amy/pulls/2","id":26758412,"html_url":"https://github.com/cudevmaxwell/amy/pull/2","diff_url":"https://github.com/cudevmaxwell/amy/pull/2.diff","patch_url":"https://github.com/cudevmaxwell/amy/pull/2.patch","issue_url":"https://api.github.com/repos/cudevmaxwell/amy/issues/2","number":2,"state":"closed","locked":false,"title":"Slimming down (but still not actually adding people)","user":{"login":"gvwilson","id":911566,"avatar_url":"https://avatars.githubusercontent.com/u/911566?v=3","gravatar_id":"","url":"https://api.github.com/users/gvwilson","html_url":"https://github.com/gvwilson","followers_url":"https://api.github.com/users/gvwilson/followers","following_url":"https://api.github.com/users/gvwilson/following{/other_user}","gists_url":"https://api.github.com/users/gvwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/gvwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvwilson/subscriptions","organizations_url":"https://api.github.com/users/gvwilson/orgs","repos_url":"https://api.github.com/users/gvwilson/repos","events_url":"https://api.github.com/users/gvwilson/events{/privacy}","received_events_url":"https://api.github.com/users/gvwilson/received_events","type":"User","site_admin":false},"body":"1.  Merge from latest `master`.\r\n2.  Eliminate some code that isn't being used.\r\n3.  A couple of file renames to be consistent with other usage.\r\n4.  Realize that people aren't actually being added to the database.\r\n\r\nThe fourth point is obviously the important one, and reveals that I don't understand as much as I'd like to about Django.  When the sample CSV file `test/upload-person-3.csv` is uploaded, the new people are rendered, but no records are added to the DB, despite the fact that `Person` objects are being created.  After reading [the documentation on transactions in Django](https://docs.djangoproject.com/en/1.7/topics/db/transactions/), I thought that new records would be auto-committed (and that in fact we'd have to turn that *off*, since we everyone to be added, or no-one --- no partial adds).  Was the extra code I've slimmed out (the confirmation button) going to force a commit of some kind if there were no errors in the data?  If so, how?\r\n\r\nThanks,\r\nGreg\r\n\r\np.s. and can you please mail me (gvwilson at software-carpentry.org) so that I have your email address?  I'd like to make sure you're included in the thanks for this project.","created_at":"2015-01-02T14:25:52Z","updated_at":"2015-01-02T23:18:22Z","closed_at":"2015-01-02T23:18:22Z","merged_at":"2015-01-02T23:18:22Z","merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cudevmaxwell/amy/pulls/2/commits","review_comments_url":"https://api.github.com/repos/cudevmaxwell/amy/pulls/2/comments","review_comment_url":"https://api.github.com/repos/cudevmaxwell/amy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cudevmaxwell/amy/issues/2/comments","statuses_url":"https://api.github.com/repos/cudevmaxwell/amy/statuses/7f7d9b6131850856d29c2448441861740336d8d8","head":{"label":"gvwilson:27-csv-bulk-add-people","ref":"27-csv-bulk-add-people","sha":"7f7d9b6131850856d29c2448441861740336d8d8","user":{"login":"gvwilson","id":911566,"avatar_url":"https://avatars.githubusercontent.com/u/911566?v=3","gravatar_id":"","url":"https://api.github.com/users/gvwilson","html_url":"https://github.com/gvwilson","followers_url":"https://api.github.com/users/gvwilson/followers","following_url":"https://api.github.com/users/gvwilson/following{/other_user}","gists_url":"https://api.github.com/users/gvwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/gvwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvwilson/subscriptions","organizations_url":"https://api.github.com/users/gvwilson/orgs","repos_url":"https://api.github.com/users/gvwilson/repos","events_url":"https://api.github.com/users/gvwilson/events{/privacy}","received_events_url":"https://api.github.com/users/gvwilson/received_events","type":"User","site_admin":false},"repo":{"id":27387341,"name":"amy","full_name":"gvwilson/amy","owner":{"login":"gvwilson","id":911566,"avatar_url":"https://avatars.githubusercontent.com/u/911566?v=3","gravatar_id":"","url":"https://api.github.com/users/gvwilson","html_url":"https://github.com/gvwilson","followers_url":"https://api.github.com/users/gvwilson/followers","following_url":"https://api.github.com/users/gvwilson/following{/other_user}","gists_url":"https://api.github.com/users/gvwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/gvwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvwilson/subscriptions","organizations_url":"https://api.github.com/users/gvwilson/orgs","repos_url":"https://api.github.com/users/gvwilson/repos","events_url":"https://api.github.com/users/gvwilson/events{/privacy}","received_events_url":"https://api.github.com/users/gvwilson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gvwilson/amy","description":"A web-based workshop administration application built using Django.","fork":true,"url":"https://api.github.com/repos/gvwilson/amy","forks_url":"https://api.github.com/repos/gvwilson/amy/forks","keys_url":"https://api.github.com/repos/gvwilson/amy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gvwilson/amy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gvwilson/amy/teams","hooks_url":"https://api.github.com/repos/gvwilson/amy/hooks","issue_events_url":"https://api.github.com/repos/gvwilson/amy/issues/events{/number}","events_url":"https://api.github.com/repos/gvwilson/amy/events","assignees_url":"https://api.github.com/repos/gvwilson/amy/assignees{/user}","branches_url":"https://api.github.com/repos/gvwilson/amy/branches{/branch}","tags_url":"https://api.github.com/repos/gvwilson/amy/tags","blobs_url":"https://api.github.com/repos/gvwilson/amy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gvwilson/amy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gvwilson/amy/git/refs{/sha}","trees_url":"https://api.github.com/repos/gvwilson/amy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gvwilson/amy/statuses/{sha}","languages_url":"https://api.github.com/repos/gvwilson/amy/languages","stargazers_url":"https://api.github.com/repos/gvwilson/amy/stargazers","contributors_url":"https://api.github.com/repos/gvwilson/amy/contributors","subscribers_url":"https://api.github.com/repos/gvwilson/amy/subscribers","subscription_url":"https://api.github.com/repos/gvwilson/amy/subscription","commits_url":"https://api.github.com/repos/gvwilson/amy/commits{/sha}","git_commits_url":"https://api.github.com/repos/gvwilson/amy/git/commits{/sha}","comments_url":"https://api.github.com/repos/gvwilson/amy/comments{/number}","issue_comment_url":"https://api.github.com/repos/gvwilson/amy/issues/comments/{number}","contents_url":"https://api.github.com/repos/gvwilson/amy/contents/{+path}","compare_url":"https://api.github.com/repos/gvwilson/amy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gvwilson/amy/merges","archive_url":"https://api.github.com/repos/gvwilson/amy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gvwilson/amy/downloads","issues_url":"https://api.github.com/repos/gvwilson/amy/issues{/number}","pulls_url":"https://api.github.com/repos/gvwilson/amy/pulls{/number}","milestones_url":"https://api.github.com/repos/gvwilson/amy/milestones{/number}","notifications_url":"https://api.github.com/repos/gvwilson/amy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gvwilson/amy/labels{/name}","releases_url":"https://api.github.com/repos/gvwilson/amy/releases{/id}","created_at":"2014-12-01T16:08:33Z","updated_at":"2015-01-02T06:50:55Z","pushed_at":"2015-01-02T23:10:40Z","git_url":"git://github.com/gvwilson/amy.git","ssh_url":"git@github.com:gvwilson/amy.git","clone_url":"https://github.com/gvwilson/amy.git","svn_url":"https://github.com/gvwilson/amy","homepage":null,"size":2507,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cudevmaxwell:27-csv-bulk-add-people","ref":"27-csv-bulk-add-people","sha":"4255a1c29cbbb42bde5219388b311256d951b59c","user":{"login":"cudevmaxwell","id":1489722,"avatar_url":"https://avatars.githubusercontent.com/u/1489722?v=3","gravatar_id":"","url":"https://api.github.com/users/cudevmaxwell","html_url":"https://github.com/cudevmaxwell","followers_url":"https://api.github.com/users/cudevmaxwell/followers","following_url":"https://api.github.com/users/cudevmaxwell/following{/other_user}","gists_url":"https://api.github.com/users/cudevmaxwell/gists{/gist_id}","starred_url":"https://api.github.com/users/cudevmaxwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cudevmaxwell/subscriptions","organizations_url":"https://api.github.com/users/cudevmaxwell/orgs","repos_url":"https://api.github.com/users/cudevmaxwell/repos","events_url":"https://api.github.com/users/cudevmaxwell/events{/privacy}","received_events_url":"https://api.github.com/users/cudevmaxwell/received_events","type":"User","site_admin":false},"repo":{"id":28311366,"name":"amy","full_name":"cudevmaxwell/amy","owner":{"login":"cudevmaxwell","id":1489722,"avatar_url":"https://avatars.githubusercontent.com/u/1489722?v=3","gravatar_id":"","url":"https://api.github.com/users/cudevmaxwell","html_url":"https://github.com/cudevmaxwell","followers_url":"https://api.github.com/users/cudevmaxwell/followers","following_url":"https://api.github.com/users/cudevmaxwell/following{/other_user}","gists_url":"https://api.github.com/users/cudevmaxwell/gists{/gist_id}","starred_url":"https://api.github.com/users/cudevmaxwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cudevmaxwell/subscriptions","organizations_url":"https://api.github.com/users/cudevmaxwell/orgs","repos_url":"https://api.github.com/users/cudevmaxwell/repos","events_url":"https://api.github.com/users/cudevmaxwell/events{/privacy}","received_events_url":"https://api.github.com/users/cudevmaxwell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cudevmaxwell/amy","description":"A web-based workshop administration application built using Django.","fork":true,"url":"https://api.github.com/repos/cudevmaxwell/amy","forks_url":"https://api.github.com/repos/cudevmaxwell/amy/forks","keys_url":"https://api.github.com/repos/cudevmaxwell/amy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cudevmaxwell/amy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cudevmaxwell/amy/teams","hooks_url":"https://api.github.com/repos/cudevmaxwell/amy/hooks","issue_events_url":"https://api.github.com/repos/cudevmaxwell/amy/issues/events{/number}","events_url":"https://api.github.com/repos/cudevmaxwell/amy/events","assignees_url":"https://api.github.com/repos/cudevmaxwell/amy/assignees{/user}","branches_url":"https://api.github.com/repos/cudevmaxwell/amy/branches{/branch}","tags_url":"https://api.github.com/repos/cudevmaxwell/amy/tags","blobs_url":"https://api.github.com/repos/cudevmaxwell/amy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cudevmaxwell/amy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cudevmaxwell/amy/git/refs{/sha}","trees_url":"https://api.github.com/repos/cudevmaxwell/amy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cudevmaxwell/amy/statuses/{sha}","languages_url":"https://api.github.com/repos/cudevmaxwell/amy/languages","stargazers_url":"https://api.github.com/repos/cudevmaxwell/amy/stargazers","contributors_url":"https://api.github.com/repos/cudevmaxwell/amy/contributors","subscribers_url":"https://api.github.com/repos/cudevmaxwell/amy/subscribers","subscription_url":"https://api.github.com/repos/cudevmaxwell/amy/subscription","commits_url":"https://api.github.com/repos/cudevmaxwell/amy/commits{/sha}","git_commits_url":"https://api.github.com/repos/cudevmaxwell/amy/git/commits{/sha}","comments_url":"https://api.github.com/repos/cudevmaxwell/amy/comments{/number}","issue_comment_url":"https://api.github.com/repos/cudevmaxwell/amy/issues/comments/{number}","contents_url":"https://api.github.com/repos/cudevmaxwell/amy/contents/{+path}","compare_url":"https://api.github.com/repos/cudevmaxwell/amy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cudevmaxwell/amy/merges","archive_url":"https://api.github.com/repos/cudevmaxwell/amy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cudevmaxwell/amy/downloads","issues_url":"https://api.github.com/repos/cudevmaxwell/amy/issues{/number}","pulls_url":"https://api.github.com/repos/cudevmaxwell/amy/pulls{/number}","milestones_url":"https://api.github.com/repos/cudevmaxwell/amy/milestones{/number}","notifications_url":"https://api.github.com/repos/cudevmaxwell/amy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cudevmaxwell/amy/labels{/name}","releases_url":"https://api.github.com/repos/cudevmaxwell/amy/releases{/id}","created_at":"2014-12-21T20:03:49Z","updated_at":"2015-01-02T19:34:41Z","pushed_at":"2015-01-02T23:18:21Z","git_url":"git://github.com/cudevmaxwell/amy.git","ssh_url":"git@github.com:cudevmaxwell/amy.git","clone_url":"https://github.com/cudevmaxwell/amy.git","svn_url":"https://github.com/cudevmaxwell/amy","homepage":null,"size":1948,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cudevmaxwell/amy/pulls/2"},"html":{"href":"https://github.com/cudevmaxwell/amy/pull/2"},"issue":{"href":"https://api.github.com/repos/cudevmaxwell/amy/issues/2"},"comments":{"href":"https://api.github.com/repos/cudevmaxwell/amy/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/cudevmaxwell/amy/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/cudevmaxwell/amy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cudevmaxwell/amy/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/cudevmaxwell/amy/statuses/7f7d9b6131850856d29c2448441861740336d8d8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"cudevmaxwell","id":1489722,"avatar_url":"https://avatars.githubusercontent.com/u/1489722?v=3","gravatar_id":"","url":"https://api.github.com/users/cudevmaxwell","html_url":"https://github.com/cudevmaxwell","followers_url":"https://api.github.com/users/cudevmaxwell/followers","following_url":"https://api.github.com/users/cudevmaxwell/following{/other_user}","gists_url":"https://api.github.com/users/cudevmaxwell/gists{/gist_id}","starred_url":"https://api.github.com/users/cudevmaxwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cudevmaxwell/subscriptions","organizations_url":"https://api.github.com/users/cudevmaxwell/orgs","repos_url":"https://api.github.com/users/cudevmaxwell/repos","events_url":"https://api.github.com/users/cudevmaxwell/events{/privacy}","received_events_url":"https://api.github.com/users/cudevmaxwell/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":6,"additions":137,"deletions":5,"changed_files":9}}