{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/9960","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/9960/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/9960/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/9960/events","html_url":"https://github.com/cms-sw/cmssw/pull/9960","id":92005378,"number":9960,"title":"Migrate HitPattern to use TrackerTopology (62X_SLHCDEV)","user":{"login":"makortel","id":33993,"avatar_url":"https://avatars.githubusercontent.com/u/33993?v=3","gravatar_id":"","url":"https://api.github.com/users/makortel","html_url":"https://github.com/makortel","followers_url":"https://api.github.com/users/makortel/followers","following_url":"https://api.github.com/users/makortel/following{/other_user}","gists_url":"https://api.github.com/users/makortel/gists{/gist_id}","starred_url":"https://api.github.com/users/makortel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makortel/subscriptions","organizations_url":"https://api.github.com/users/makortel/orgs","repos_url":"https://api.github.com/users/makortel/repos","events_url":"https://api.github.com/users/makortel/events{/privacy}","received_events_url":"https://api.github.com/users/makortel/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fef2c0"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/dqm-pending","name":"dqm-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/fastsim-pending","name":"fastsim-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/simulation-pending","name":"simulation-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-pending","name":"tests-pending","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/52","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_6_2_SLHCDEV_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/52/labels","id":1044711,"number":52,"title":"Next CMSSW_6_2_SLHCDEV_X","description":"","creator":{"login":"nclopezo","id":1944922,"avatar_url":"https://avatars.githubusercontent.com/u/1944922?v=3","gravatar_id":"","url":"https://api.github.com/users/nclopezo","html_url":"https://github.com/nclopezo","followers_url":"https://api.github.com/users/nclopezo/followers","following_url":"https://api.github.com/users/nclopezo/following{/other_user}","gists_url":"https://api.github.com/users/nclopezo/gists{/gist_id}","starred_url":"https://api.github.com/users/nclopezo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nclopezo/subscriptions","organizations_url":"https://api.github.com/users/nclopezo/orgs","repos_url":"https://api.github.com/users/nclopezo/repos","events_url":"https://api.github.com/users/nclopezo/events{/privacy}","received_events_url":"https://api.github.com/users/nclopezo/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":7,"state":"open","created_at":"2015-03-30T13:21:02Z","updated_at":"2015-06-30T06:51:24Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2015-06-30T06:44:51Z","updated_at":"2015-07-01T15:04:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/9960","html_url":"https://github.com/cms-sw/cmssw/pull/9960","diff_url":"https://github.com/cms-sw/cmssw/pull/9960.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/9960.patch"},"body":"Backport of #9959: This PR migrates HitPattern to use TrackerTopology instead of the tracker DetId classes. In contrast to 76X/#9959, here in 62X HitPattern is always filled from DetIds from hits, so it was enough to percolate TrackerTopology to all places where HitPattern is filled.\r\n\r\nTested in CMSSW_6_2_SLHCDEV_X_2015-06-23-2300 with wfs 10000, 10200, 10400, 11200, 11400, 11600, 12000, 13000. I have the alternative-comparisons' results here (black=old, red=new)\r\n* https://mkortela.web.cern.ch/mkortela/tracking/trackerTopologyHitPattern_slhcdev_result_10000.pdf\r\n* https://mkortela.web.cern.ch/mkortela/tracking/trackerTopologyHitPattern_slhcdev_result_10200.pdf\r\n* https://mkortela.web.cern.ch/mkortela/tracking/trackerTopologyHitPattern_slhcdev_result_10400.pdf\r\n* https://mkortela.web.cern.ch/mkortela/tracking/trackerTopologyHitPattern_slhcdev_result_11200.pdf\r\n* https://mkortela.web.cern.ch/mkortela/tracking/trackerTopologyHitPattern_slhcdev_result_11400.pdf\r\n* https://mkortela.web.cern.ch/mkortela/tracking/trackerTopologyHitPattern_slhcdev_result_11600.pdf\r\n* https://mkortela.web.cern.ch/mkortela/tracking/trackerTopologyHitPattern_slhcdev_result_12000.pdf\r\n* https://mkortela.web.cern.ch/mkortela/tracking/trackerTopologyHitPattern_slhcdev_result_13000.pdf\r\n\r\nOf these, 10000, 10200, 11200, 11600 give equal results, and 10400, 11400, 12000, 13000 show differences. I haven't taken too deep look on the geometry differences between the workflows, but maybe in the latter 4 the changes are expected?\r\n\r\n@rovere @VinInn @boudoul @venturia "},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/117709807","html_url":"https://github.com/cms-sw/cmssw/pull/9960#issuecomment-117709807","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/9960","id":117709807,"user":{"login":"mark-grimes","id":6480160,"avatar_url":"https://avatars.githubusercontent.com/u/6480160?v=3","gravatar_id":"","url":"https://api.github.com/users/mark-grimes","html_url":"https://github.com/mark-grimes","followers_url":"https://api.github.com/users/mark-grimes/followers","following_url":"https://api.github.com/users/mark-grimes/following{/other_user}","gists_url":"https://api.github.com/users/mark-grimes/gists{/gist_id}","starred_url":"https://api.github.com/users/mark-grimes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mark-grimes/subscriptions","organizations_url":"https://api.github.com/users/mark-grimes/orgs","repos_url":"https://api.github.com/users/mark-grimes/repos","events_url":"https://api.github.com/users/mark-grimes/events{/privacy}","received_events_url":"https://api.github.com/users/mark-grimes/received_events","type":"User","site_admin":false},"created_at":"2015-07-01T15:04:48Z","updated_at":"2015-07-01T15:04:48Z","body":"Does the templated constructor at [HitPattern.h#L146](https://github.com/makortel/cmssw/blob/trackerTopologyHitPattern_slhcdev/DataFormats/TrackReco/interface/HitPattern.h#L146) also need ttopo?  I guess it's never used otherwise the inline `set(c);` would cause a compiler error.  Can we either remove the constructor or add ttopo if it's going to be used in future?\r\n\r\n(couldn't seem to add this as a line comment since the line is not part of the diff)"}}