{"action":"created","issue":{"url":"https://api.github.com/repos/thbar/kiba/issues/3","labels_url":"https://api.github.com/repos/thbar/kiba/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/thbar/kiba/issues/3/comments","events_url":"https://api.github.com/repos/thbar/kiba/issues/3/events","html_url":"https://github.com/thbar/kiba/pull/3","id":67545101,"number":3,"title":"Use transform class to extract away Proc/Klass logic","user":{"login":"ollie","id":53026,"avatar_url":"https://avatars.githubusercontent.com/u/53026?v=3","gravatar_id":"","url":"https://api.github.com/users/ollie","html_url":"https://github.com/ollie","followers_url":"https://api.github.com/users/ollie/followers","following_url":"https://api.github.com/users/ollie/following{/other_user}","gists_url":"https://api.github.com/users/ollie/gists{/gist_id}","starred_url":"https://api.github.com/users/ollie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ollie/subscriptions","organizations_url":"https://api.github.com/users/ollie/orgs","repos_url":"https://api.github.com/users/ollie/repos","events_url":"https://api.github.com/users/ollie/events{/privacy}","received_events_url":"https://api.github.com/users/ollie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-04-10T08:53:28Z","updated_at":"2015-04-20T07:55:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/thbar/kiba/pulls/3","html_url":"https://github.com/thbar/kiba/pull/3","diff_url":"https://github.com/thbar/kiba/pull/3.diff","patch_url":"https://github.com/thbar/kiba/pull/3.patch"},"body":"Hi,\r\n\r\nI'm sorry but I couldn't resist it. I wrapped your transforms into another class so that it exposes the same interface for class or proc, which has the benefit of removing the if/else logic from control and runner files. I also extracted away the transform application into a separate method so that it looks a bit cleaner.\r\n\r\nFeel free to use or discard this entirely, I was just curious if I could improve it and if so would like to share the result. :-)\r\n\r\nOllie"},"comment":{"url":"https://api.github.com/repos/thbar/kiba/issues/comments/94385563","html_url":"https://github.com/thbar/kiba/pull/3#issuecomment-94385563","issue_url":"https://api.github.com/repos/thbar/kiba/issues/3","id":94385563,"user":{"login":"thbar","id":10141,"avatar_url":"https://avatars.githubusercontent.com/u/10141?v=3","gravatar_id":"","url":"https://api.github.com/users/thbar","html_url":"https://github.com/thbar","followers_url":"https://api.github.com/users/thbar/followers","following_url":"https://api.github.com/users/thbar/following{/other_user}","gists_url":"https://api.github.com/users/thbar/gists{/gist_id}","starred_url":"https://api.github.com/users/thbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thbar/subscriptions","organizations_url":"https://api.github.com/users/thbar/orgs","repos_url":"https://api.github.com/users/thbar/repos","events_url":"https://api.github.com/users/thbar/events{/privacy}","received_events_url":"https://api.github.com/users/thbar/received_events","type":"User","site_admin":false},"created_at":"2015-04-20T07:55:35Z","updated_at":"2015-04-20T07:55:35Z","body":"No, please keep this opened (unless this bugs you, I can recreate separate issues)! This acts as a reminder for me to apply the whitespaces fixes to the whole codebase, and to think about the wrapper aspect. Thanks!"}}