{"action":"created","issue":{"url":"https://api.github.com/repos/percona/percona-server/issues/218","labels_url":"https://api.github.com/repos/percona/percona-server/issues/218/labels{/name}","comments_url":"https://api.github.com/repos/percona/percona-server/issues/218/comments","events_url":"https://api.github.com/repos/percona/percona-server/issues/218/events","html_url":"https://github.com/percona/percona-server/pull/218","id":114544271,"number":218,"title":"Bug1500720 5.6","user":{"login":"laurynas-biveinis","id":58894,"avatar_url":"https://avatars.githubusercontent.com/u/58894?v=3","gravatar_id":"","url":"https://api.github.com/users/laurynas-biveinis","html_url":"https://github.com/laurynas-biveinis","followers_url":"https://api.github.com/users/laurynas-biveinis/followers","following_url":"https://api.github.com/users/laurynas-biveinis/following{/other_user}","gists_url":"https://api.github.com/users/laurynas-biveinis/gists{/gist_id}","starred_url":"https://api.github.com/users/laurynas-biveinis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laurynas-biveinis/subscriptions","organizations_url":"https://api.github.com/users/laurynas-biveinis/orgs","repos_url":"https://api.github.com/users/laurynas-biveinis/repos","events_url":"https://api.github.com/users/laurynas-biveinis/events{/privacy}","received_events_url":"https://api.github.com/users/laurynas-biveinis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-02T07:58:12Z","updated_at":"2015-11-02T09:03:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/percona/percona-server/pulls/218","html_url":"https://github.com/percona/percona-server/pull/218","diff_url":"https://github.com/percona/percona-server/pull/218.diff","patch_url":"https://github.com/percona/percona-server/pull/218.patch"},"body":"http://jenkins.percona.com/job/percona-server-5.6-param/1008/#showFailuresLink"},"comment":{"url":"https://api.github.com/repos/percona/percona-server/issues/comments/152961442","html_url":"https://github.com/percona/percona-server/pull/218#issuecomment-152961442","issue_url":"https://api.github.com/repos/percona/percona-server/issues/218","id":152961442,"user":{"login":"kbauskar","id":14107301,"avatar_url":"https://avatars.githubusercontent.com/u/14107301?v=3","gravatar_id":"","url":"https://api.github.com/users/kbauskar","html_url":"https://github.com/kbauskar","followers_url":"https://api.github.com/users/kbauskar/followers","following_url":"https://api.github.com/users/kbauskar/following{/other_user}","gists_url":"https://api.github.com/users/kbauskar/gists{/gist_id}","starred_url":"https://api.github.com/users/kbauskar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbauskar/subscriptions","organizations_url":"https://api.github.com/users/kbauskar/orgs","repos_url":"https://api.github.com/users/kbauskar/repos","events_url":"https://api.github.com/users/kbauskar/events{/privacy}","received_events_url":"https://api.github.com/users/kbauskar/received_events","type":"User","site_admin":false},"created_at":"2015-11-02T09:03:23Z","updated_at":"2015-11-02T09:03:23Z","body":"if (!srv_read_only_mode\r\n&& *success && *success\r\n&& (srv_unix_file_flush_method == SRV_UNIX_O_DIRECT && (srv_unix_file_flush_method == SRV_UNIX_O_DIRECT\r\n\r\n|| srv_unix_file_flush_method == SRV_UNIX_O_DIRECT_NO_FSYNC)) { + || srv_unix_file_flush_method == SRV_UNIX_O_DIRECT_NO_FSYNC\r\n|| srv_unix_file_flush_method == SRV_UNIX_ALL_O_DIRECT)\r\n&& access_type != OS_FILE_READ_WRITE_CACHED) {\r\nSame logic exist in os_file_create_func.\r\nAs discussed over IM it would be good to create a macro for it and use it at both places."}}