{"action":"created","issue":{"url":"https://api.github.com/repos/vispy/vispy/issues/901","labels_url":"https://api.github.com/repos/vispy/vispy/issues/901/labels{/name}","comments_url":"https://api.github.com/repos/vispy/vispy/issues/901/comments","events_url":"https://api.github.com/repos/vispy/vispy/issues/901/events","html_url":"https://github.com/vispy/vispy/pull/901","id":76151382,"number":901,"title":"PR: Support for parametric plane and box geometries.","user":{"login":"KelSolaar","id":99779,"avatar_url":"https://avatars.githubusercontent.com/u/99779?v=3","gravatar_id":"","url":"https://api.github.com/users/KelSolaar","html_url":"https://github.com/KelSolaar","followers_url":"https://api.github.com/users/KelSolaar/followers","following_url":"https://api.github.com/users/KelSolaar/following{/other_user}","gists_url":"https://api.github.com/users/KelSolaar/gists{/gist_id}","starred_url":"https://api.github.com/users/KelSolaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KelSolaar/subscriptions","organizations_url":"https://api.github.com/users/KelSolaar/orgs","repos_url":"https://api.github.com/users/KelSolaar/repos","events_url":"https://api.github.com/users/KelSolaar/events{/privacy}","received_events_url":"https://api.github.com/users/KelSolaar/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":25,"created_at":"2015-05-13T22:47:28Z","updated_at":"2015-06-01T16:59:46Z","closed_at":"2015-06-01T15:41:35Z","pull_request":{"url":"https://api.github.com/repos/vispy/vispy/pulls/901","html_url":"https://github.com/vispy/vispy/pull/901","diff_url":"https://github.com/vispy/vispy/pull/901.diff","patch_url":"https://github.com/vispy/vispy/pull/901.patch"},"body":"This PR implements support for a parametric plane and a parametric box that builds on it through the following objects:\r\n\r\n- `vispy.geometry.generation.create_plane`\r\n\r\n![image](https://cloud.githubusercontent.com/assets/99779/7622624/4d4b4f16-f9d1-11e4-935d-8163c860f053.png)\r\n\r\n- `vispy.geometry.generation.create_box`\r\n\r\n![image](https://cloud.githubusercontent.com/assets/99779/7622628/5678e5b2-f9d1-11e4-8cc1-bcf6eed282f0.png)\r\n\r\nSome things to consider:\r\n\r\n- It would be neat to actually return a `MeshData` instance instead of the current tuple for `create_cube`, `create_plane` and `create_box` definitions, however the class may not have all the needed fields, especially one for the outline. Upon really quick inspection it doesn't seem to support arbitrary data.\r\n- As I didn't wanted to break anything, I did not replaced `make_cube`, it is maybe worth for it to be an alias to `make_box` or whatever you feel the best.\r\n- I haven't created matching visuals for the new geometries, but I have some that fit my usage accordingly to #900 there: https://github.com/colour-science/colour-vispy/blob/master/colour_vispy/visuals.py"},"comment":{"url":"https://api.github.com/repos/vispy/vispy/issues/comments/107637915","html_url":"https://github.com/vispy/vispy/pull/901#issuecomment-107637915","issue_url":"https://api.github.com/repos/vispy/vispy/issues/901","id":107637915,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2015-06-01T16:59:46Z","updated_at":"2015-06-01T16:59:46Z","body":"\n[![Coverage Status](https://coveralls.io/builds/2689357/badge)](https://coveralls.io/builds/2689357)\n\nCoverage increased (+0.83%) to 73.52% when pulling **dc5581f8ee34d38cb570812cc203ee9975f083ff on colour-science:master** into **4c0cfccf771b4f22cdfdf9faf8af2d75bf4bc47b on vispy:master**.\n"}}