{"action":"created","issue":{"url":"https://api.github.com/repos/eslint/eslint/issues/3788","labels_url":"https://api.github.com/repos/eslint/eslint/issues/3788/labels{/name}","comments_url":"https://api.github.com/repos/eslint/eslint/issues/3788/comments","events_url":"https://api.github.com/repos/eslint/eslint/issues/3788/events","html_url":"https://github.com/eslint/eslint/issues/3788","id":106295494,"number":3788,"title":"eslint 1.4 does not ignore patterns like \"**/node_modules\"","user":{"login":"mickaeltr","id":378910,"avatar_url":"https://avatars.githubusercontent.com/u/378910?v=3","gravatar_id":"","url":"https://api.github.com/users/mickaeltr","html_url":"https://github.com/mickaeltr","followers_url":"https://api.github.com/users/mickaeltr/followers","following_url":"https://api.github.com/users/mickaeltr/following{/other_user}","gists_url":"https://api.github.com/users/mickaeltr/gists{/gist_id}","starred_url":"https://api.github.com/users/mickaeltr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickaeltr/subscriptions","organizations_url":"https://api.github.com/users/mickaeltr/orgs","repos_url":"https://api.github.com/users/mickaeltr/repos","events_url":"https://api.github.com/users/mickaeltr/events{/privacy}","received_events_url":"https://api.github.com/users/mickaeltr/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/eslint/eslint/labels/accepted","name":"accepted","color":"0052cc"},{"url":"https://api.github.com/repos/eslint/eslint/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/eslint/eslint/labels/cli","name":"cli","color":"eb6420"}],"state":"open","locked":false,"assignee":{"login":"BYK","id":126780,"avatar_url":"https://avatars.githubusercontent.com/u/126780?v=3","gravatar_id":"","url":"https://api.github.com/users/BYK","html_url":"https://github.com/BYK","followers_url":"https://api.github.com/users/BYK/followers","following_url":"https://api.github.com/users/BYK/following{/other_user}","gists_url":"https://api.github.com/users/BYK/gists{/gist_id}","starred_url":"https://api.github.com/users/BYK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BYK/subscriptions","organizations_url":"https://api.github.com/users/BYK/orgs","repos_url":"https://api.github.com/users/BYK/repos","events_url":"https://api.github.com/users/BYK/events{/privacy}","received_events_url":"https://api.github.com/users/BYK/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2015-09-14T08:35:22Z","updated_at":"2015-09-14T23:07:04Z","closed_at":null,"body":"Hello,\r\n\r\nMy .gitignore file contains patterns like **/node_modules. eslint uses the .gitignore file (instead of the .eslintignore). It used to work but it stopped working after I upgraded from eslint 1.3 to 1.4. Now it returns error about files which are in the node_modules.\r\n\r\neslint = 1.4.1\r\n.gitignore = **/node_modules\r\ncommand = eslint  --quiet --ignore-path .gitignore\r\n\r\nThanks"},"comment":{"url":"https://api.github.com/repos/eslint/eslint/issues/comments/140229700","html_url":"https://github.com/eslint/eslint/issues/3788#issuecomment-140229700","issue_url":"https://api.github.com/repos/eslint/eslint/issues/3788","id":140229700,"user":{"login":"nzakas","id":38546,"avatar_url":"https://avatars.githubusercontent.com/u/38546?v=3","gravatar_id":"","url":"https://api.github.com/users/nzakas","html_url":"https://github.com/nzakas","followers_url":"https://api.github.com/users/nzakas/followers","following_url":"https://api.github.com/users/nzakas/following{/other_user}","gists_url":"https://api.github.com/users/nzakas/gists{/gist_id}","starred_url":"https://api.github.com/users/nzakas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nzakas/subscriptions","organizations_url":"https://api.github.com/users/nzakas/orgs","repos_url":"https://api.github.com/users/nzakas/repos","events_url":"https://api.github.com/users/nzakas/events{/privacy}","received_events_url":"https://api.github.com/users/nzakas/received_events","type":"User","site_admin":false},"created_at":"2015-09-14T23:07:04Z","updated_at":"2015-09-14T23:07:04Z","body":"I'm unable to verify this in v1.4.1. As far as I can tell, we're correctly ignoring `node_modules` by default. Here's my setup:\r\n\r\n```\r\n|- node_modules\r\n|--- tmp\r\n|----- foo.js\r\n|- foo.js\r\n```\r\n\r\nThen I run this:\r\n\r\n```\r\n$ eslint node_modules/tmp/*.js\r\n\r\nc:\\Users\\Nicholas\\projects\\personal\\tmp\\node_modules\\tmp\\foo.js\r\n  0:0  warning  File ignored because of your .eslintignore file. Use --no-ignore\r\n to override\r\n\r\n✖ 1 problem (0 errors, 1 warning)\r\n```\r\n\r\nDitto if I run with a more general pattern:\r\n\r\n```\r\nc:\\Users\\Nicholas\\projects\\personal\\tmp\\foo.js\r\n   1:23  error    Expected linebreaks to be 'LF' but found 'CRLF'       linebrea\r\nk-style\r\n   2:10  error    \"BOOMR\" is defined but never used                     no-unuse\r\nd-vars\r\n   2:22  error    \"BOOMR_start\" is defined but never used               no-unuse\r\nd-vars\r\n   2:40  error    \"BOOMR_lstart\" is defined but never used              no-unuse\r\nd-vars\r\n   7:8   error    \"cookies_a\" is defined but never used                 no-unuse\r\nd-vars\r\n   8:8   error    Expected indentation of 4 tab characters but found 3  indent\r\n   8:8   warning  Multiple spaces found before 'i'                      no-multi\r\n-spaces\r\n   8:8   error    \"i\" is defined but never used                         no-unuse\r\nd-vars\r\n   8:11  error    \"l\" is defined but never used                         no-unuse\r\nd-vars\r\n   8:14  error    \"kv\" is defined but never used                        no-unuse\r\nd-vars\r\n   9:8   error    Expected indentation of 4 tab characters but found 3  indent\r\n   9:8   error    \"gotcookies\" is defined but never used                no-unuse\r\nd-vars\r\n   9:8   warning  Multiple spaces found before 'gotcookies'             no-multi\r\n-spaces\r\n  10:8   error    Expected indentation of 4 tab characters but found 3  indent\r\n  10:8   error    \"cookies\" is defined but never used                   no-unuse\r\nd-vars\r\n  10:8   warning  Multiple spaces found before 'cookies'                no-multi\r\n-spaces\r\n\r\n✖ 16 problems (13 errors, 3 warnings)\r\n```\r\n\r\nIf I downgrade to v1.4.0, then I can see that we are still linting in `node_modules`, but I cannot reproduce in v1.4.1.\r\n\r\n@mickaeltr @iOiurson are you certain you're using the latest version? If you are, can you provide more details on your setup?\r\n"}}