{"action":"created","issue":{"url":"https://api.github.com/repos/boostorg/geometry/issues/263","labels_url":"https://api.github.com/repos/boostorg/geometry/issues/263/labels{/name}","comments_url":"https://api.github.com/repos/boostorg/geometry/issues/263/comments","events_url":"https://api.github.com/repos/boostorg/geometry/issues/263/events","html_url":"https://github.com/boostorg/geometry/pull/263","id":60707335,"number":263,"title":"Fix: allow geometry test common to be included in all unit tests","user":{"login":"mkaravel","id":6397014,"avatar_url":"https://avatars.githubusercontent.com/u/6397014?v=3","gravatar_id":"","url":"https://api.github.com/users/mkaravel","html_url":"https://github.com/mkaravel","followers_url":"https://api.github.com/users/mkaravel/followers","following_url":"https://api.github.com/users/mkaravel/following{/other_user}","gists_url":"https://api.github.com/users/mkaravel/gists{/gist_id}","starred_url":"https://api.github.com/users/mkaravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkaravel/subscriptions","organizations_url":"https://api.github.com/users/mkaravel/orgs","repos_url":"https://api.github.com/users/mkaravel/repos","events_url":"https://api.github.com/users/mkaravel/events{/privacy}","received_events_url":"https://api.github.com/users/mkaravel/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-03-11T18:31:20Z","updated_at":"2015-03-12T11:11:33Z","closed_at":"2015-03-11T18:48:56Z","pull_request":{"url":"https://api.github.com/repos/boostorg/geometry/pulls/263","html_url":"https://github.com/boostorg/geometry/pull/263","diff_url":"https://github.com/boostorg/geometry/pull/263.diff","patch_url":"https://github.com/boostorg/geometry/pull/263.patch"},"body":"In this PR I guard the inclusion of Unit.Test related include by the macro `BOOST_TEST_MODULE`.\r\nThis macro is defined in many unit tests (distance, set-ops, validity, simplicity and possibly others), and is used for using Boost.Test is a different way than in traditionally written unit tests.\r\n\r\nWhen `<geometry_test_common.hpp>` is included in those tests, the `test_main()` function is defined twice and gives a compilation error.\r\n\r\nWith the guarding proposed in this PR, `<geometry_test_common.hpp>` can be safely included in those unit tests as well, without any problems."},"comment":{"url":"https://api.github.com/repos/boostorg/geometry/issues/comments/78461091","html_url":"https://github.com/boostorg/geometry/pull/263#issuecomment-78461091","issue_url":"https://api.github.com/repos/boostorg/geometry/issues/263","id":78461091,"user":{"login":"mkaravel","id":6397014,"avatar_url":"https://avatars.githubusercontent.com/u/6397014?v=3","gravatar_id":"","url":"https://api.github.com/users/mkaravel","html_url":"https://github.com/mkaravel","followers_url":"https://api.github.com/users/mkaravel/followers","following_url":"https://api.github.com/users/mkaravel/following{/other_user}","gists_url":"https://api.github.com/users/mkaravel/gists{/gist_id}","starred_url":"https://api.github.com/users/mkaravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkaravel/subscriptions","organizations_url":"https://api.github.com/users/mkaravel/orgs","repos_url":"https://api.github.com/users/mkaravel/repos","events_url":"https://api.github.com/users/mkaravel/events{/privacy}","received_events_url":"https://api.github.com/users/mkaravel/received_events","type":"User","site_admin":false},"created_at":"2015-03-12T11:11:33Z","updated_at":"2015-03-12T11:11:33Z","body":"The contents of `geometry_test_common.hpp` are quite neutral and generic so, I am not against this idea.\r\n\r\nOn the other hand this enforces the inclusion of `geometry_test_common.hpp` in all unit tests, and I am not sure this is something we want to enforce.\r\n\r\nLet's wait for other opinions about this. If we agree that this is the way we want to go, I can modify the tests that need to be changed, and include this header file."}}