{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/scripts/pulls/comments/28558522","id":28558522,"diff_hunk":"@@ -47,28 +50,34 @@ function load_coreos {\n         set suf=\"\"\n     fi\n \n-    echo \"Loading ($root)/boot/vmlinuz\"\n-    linux$suf /boot/vmlinuz $linux_console $linux_root \"$@\" $linux_append\n+    search --no-floppy --set root --part-label EFI-SYSTEM","path":"build_library/grub.cfg","position":24,"original_position":24,"commit_id":"08b03a69287da1ec25506917f270e5e42118aa75","original_commit_id":"08b03a69287da1ec25506917f270e5e42118aa75","user":{"login":"marineam","id":153640,"avatar_url":"https://avatars.githubusercontent.com/u/153640?v=3","gravatar_id":"","url":"https://api.github.com/users/marineam","html_url":"https://github.com/marineam","followers_url":"https://api.github.com/users/marineam/followers","following_url":"https://api.github.com/users/marineam/following{/other_user}","gists_url":"https://api.github.com/users/marineam/gists{/gist_id}","starred_url":"https://api.github.com/users/marineam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marineam/subscriptions","organizations_url":"https://api.github.com/users/marineam/orgs","repos_url":"https://api.github.com/users/marineam/repos","events_url":"https://api.github.com/users/marineam/events{/privacy}","received_events_url":"https://api.github.com/users/marineam/received_events","type":"User","site_admin":false},"body":"$root is initially set th the ESP in load.cfg:\r\n\r\n```\r\nsearch.fs_uuid ${ESP_FSID} root \\$root\r\n```\r\n\r\nthe gptprio.next calls should be updated to set $usr or similar instead of $root","created_at":"2015-04-16T23:13:48Z","updated_at":"2015-04-16T23:13:48Z","html_url":"https://github.com/coreos/scripts/pull/397#discussion_r28558522","pull_request_url":"https://api.github.com/repos/coreos/scripts/pulls/397","_links":{"self":{"href":"https://api.github.com/repos/coreos/scripts/pulls/comments/28558522"},"html":{"href":"https://github.com/coreos/scripts/pull/397#discussion_r28558522"},"pull_request":{"href":"https://api.github.com/repos/coreos/scripts/pulls/397"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/scripts/pulls/397","id":33501201,"html_url":"https://github.com/coreos/scripts/pull/397","diff_url":"https://github.com/coreos/scripts/pull/397.diff","patch_url":"https://github.com/coreos/scripts/pull/397.patch","issue_url":"https://api.github.com/repos/coreos/scripts/issues/397","number":397,"state":"open","locked":false,"title":"Add support for signed kernels","user":{"login":"mjg59","id":1420843,"avatar_url":"https://avatars.githubusercontent.com/u/1420843?v=3","gravatar_id":"","url":"https://api.github.com/users/mjg59","html_url":"https://github.com/mjg59","followers_url":"https://api.github.com/users/mjg59/followers","following_url":"https://api.github.com/users/mjg59/following{/other_user}","gists_url":"https://api.github.com/users/mjg59/gists{/gist_id}","starred_url":"https://api.github.com/users/mjg59/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjg59/subscriptions","organizations_url":"https://api.github.com/users/mjg59/orgs","repos_url":"https://api.github.com/users/mjg59/repos","events_url":"https://api.github.com/users/mjg59/events{/privacy}","received_events_url":"https://api.github.com/users/mjg59/received_events","type":"User","site_admin":false},"body":"grub needs shim in order to verify kernels, and we need to rework our image format a little to enable the dm-verity work. This gets us to a fully trusted boot chain in the qemu-uefi-secure target.","created_at":"2015-04-16T23:03:56Z","updated_at":"2015-04-16T23:13:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90e5a6620bb5f3bb45fca0efb8ad6d062db6e6c9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coreos/scripts/pulls/397/commits","review_comments_url":"https://api.github.com/repos/coreos/scripts/pulls/397/comments","review_comment_url":"https://api.github.com/repos/coreos/scripts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/scripts/issues/397/comments","statuses_url":"https://api.github.com/repos/coreos/scripts/statuses/08b03a69287da1ec25506917f270e5e42118aa75","head":{"label":"mjg59:master","ref":"master","sha":"08b03a69287da1ec25506917f270e5e42118aa75","user":{"login":"mjg59","id":1420843,"avatar_url":"https://avatars.githubusercontent.com/u/1420843?v=3","gravatar_id":"","url":"https://api.github.com/users/mjg59","html_url":"https://github.com/mjg59","followers_url":"https://api.github.com/users/mjg59/followers","following_url":"https://api.github.com/users/mjg59/following{/other_user}","gists_url":"https://api.github.com/users/mjg59/gists{/gist_id}","starred_url":"https://api.github.com/users/mjg59/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjg59/subscriptions","organizations_url":"https://api.github.com/users/mjg59/orgs","repos_url":"https://api.github.com/users/mjg59/repos","events_url":"https://api.github.com/users/mjg59/events{/privacy}","received_events_url":"https://api.github.com/users/mjg59/received_events","type":"User","site_admin":false},"repo":{"id":33894440,"name":"scripts","full_name":"mjg59/scripts","owner":{"login":"mjg59","id":1420843,"avatar_url":"https://avatars.githubusercontent.com/u/1420843?v=3","gravatar_id":"","url":"https://api.github.com/users/mjg59","html_url":"https://github.com/mjg59","followers_url":"https://api.github.com/users/mjg59/followers","following_url":"https://api.github.com/users/mjg59/following{/other_user}","gists_url":"https://api.github.com/users/mjg59/gists{/gist_id}","starred_url":"https://api.github.com/users/mjg59/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjg59/subscriptions","organizations_url":"https://api.github.com/users/mjg59/orgs","repos_url":"https://api.github.com/users/mjg59/repos","events_url":"https://api.github.com/users/mjg59/events{/privacy}","received_events_url":"https://api.github.com/users/mjg59/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjg59/scripts","description":"Build and maintenance scripts for CoreOS","fork":true,"url":"https://api.github.com/repos/mjg59/scripts","forks_url":"https://api.github.com/repos/mjg59/scripts/forks","keys_url":"https://api.github.com/repos/mjg59/scripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjg59/scripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjg59/scripts/teams","hooks_url":"https://api.github.com/repos/mjg59/scripts/hooks","issue_events_url":"https://api.github.com/repos/mjg59/scripts/issues/events{/number}","events_url":"https://api.github.com/repos/mjg59/scripts/events","assignees_url":"https://api.github.com/repos/mjg59/scripts/assignees{/user}","branches_url":"https://api.github.com/repos/mjg59/scripts/branches{/branch}","tags_url":"https://api.github.com/repos/mjg59/scripts/tags","blobs_url":"https://api.github.com/repos/mjg59/scripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjg59/scripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjg59/scripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjg59/scripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjg59/scripts/statuses/{sha}","languages_url":"https://api.github.com/repos/mjg59/scripts/languages","stargazers_url":"https://api.github.com/repos/mjg59/scripts/stargazers","contributors_url":"https://api.github.com/repos/mjg59/scripts/contributors","subscribers_url":"https://api.github.com/repos/mjg59/scripts/subscribers","subscription_url":"https://api.github.com/repos/mjg59/scripts/subscription","commits_url":"https://api.github.com/repos/mjg59/scripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjg59/scripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjg59/scripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjg59/scripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjg59/scripts/contents/{+path}","compare_url":"https://api.github.com/repos/mjg59/scripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjg59/scripts/merges","archive_url":"https://api.github.com/repos/mjg59/scripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjg59/scripts/downloads","issues_url":"https://api.github.com/repos/mjg59/scripts/issues{/number}","pulls_url":"https://api.github.com/repos/mjg59/scripts/pulls{/number}","milestones_url":"https://api.github.com/repos/mjg59/scripts/milestones{/number}","notifications_url":"https://api.github.com/repos/mjg59/scripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjg59/scripts/labels{/name}","releases_url":"https://api.github.com/repos/mjg59/scripts/releases{/id}","created_at":"2015-04-13T21:15:19Z","updated_at":"2015-04-16T23:00:58Z","pushed_at":"2015-04-16T23:00:58Z","git_url":"git://github.com/mjg59/scripts.git","ssh_url":"git@github.com:mjg59/scripts.git","clone_url":"https://github.com/mjg59/scripts.git","svn_url":"https://github.com/mjg59/scripts","homepage":"http://coreos.com/docs/sdk/","size":7738,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"a3d8d43cb2a80543e8d537e187cd7e746659a3c0","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":8488880,"name":"scripts","full_name":"coreos/scripts","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/scripts","description":"Build and maintenance scripts for CoreOS","fork":false,"url":"https://api.github.com/repos/coreos/scripts","forks_url":"https://api.github.com/repos/coreos/scripts/forks","keys_url":"https://api.github.com/repos/coreos/scripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/scripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/scripts/teams","hooks_url":"https://api.github.com/repos/coreos/scripts/hooks","issue_events_url":"https://api.github.com/repos/coreos/scripts/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/scripts/events","assignees_url":"https://api.github.com/repos/coreos/scripts/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/scripts/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/scripts/tags","blobs_url":"https://api.github.com/repos/coreos/scripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/scripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/scripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/scripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/scripts/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/scripts/languages","stargazers_url":"https://api.github.com/repos/coreos/scripts/stargazers","contributors_url":"https://api.github.com/repos/coreos/scripts/contributors","subscribers_url":"https://api.github.com/repos/coreos/scripts/subscribers","subscription_url":"https://api.github.com/repos/coreos/scripts/subscription","commits_url":"https://api.github.com/repos/coreos/scripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/scripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/scripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/scripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/scripts/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/scripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/scripts/merges","archive_url":"https://api.github.com/repos/coreos/scripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/scripts/downloads","issues_url":"https://api.github.com/repos/coreos/scripts/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/scripts/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/scripts/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/scripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/scripts/labels{/name}","releases_url":"https://api.github.com/repos/coreos/scripts/releases{/id}","created_at":"2013-02-28T21:45:57Z","updated_at":"2015-04-15T21:50:56Z","pushed_at":"2015-04-16T23:03:56Z","git_url":"git://github.com/coreos/scripts.git","ssh_url":"git@github.com:coreos/scripts.git","clone_url":"https://github.com/coreos/scripts.git","svn_url":"https://github.com/coreos/scripts","homepage":"http://coreos.com/docs/sdk/","size":10064,"stargazers_count":47,"watchers_count":47,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":5,"forks":51,"open_issues":5,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/scripts/pulls/397"},"html":{"href":"https://github.com/coreos/scripts/pull/397"},"issue":{"href":"https://api.github.com/repos/coreos/scripts/issues/397"},"comments":{"href":"https://api.github.com/repos/coreos/scripts/issues/397/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/scripts/pulls/397/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/scripts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/scripts/pulls/397/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/scripts/statuses/08b03a69287da1ec25506917f270e5e42118aa75"}}}}