{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-apt/issues/354","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apt/issues/354/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apt/issues/354/comments","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apt/issues/354/events","html_url":"https://github.com/puppetlabs/puppetlabs-apt/pull/354","id":41887616,"number":354,"title":"Allow GPG key fingerprints.","user":{"login":"rfkrocktk","id":347571,"avatar_url":"https://avatars.githubusercontent.com/u/347571?v=3","gravatar_id":"","url":"https://api.github.com/users/rfkrocktk","html_url":"https://github.com/rfkrocktk","followers_url":"https://api.github.com/users/rfkrocktk/followers","following_url":"https://api.github.com/users/rfkrocktk/following{/other_user}","gists_url":"https://api.github.com/users/rfkrocktk/gists{/gist_id}","starred_url":"https://api.github.com/users/rfkrocktk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfkrocktk/subscriptions","organizations_url":"https://api.github.com/users/rfkrocktk/orgs","repos_url":"https://api.github.com/users/rfkrocktk/repos","events_url":"https://api.github.com/users/rfkrocktk/events{/privacy}","received_events_url":"https://api.github.com/users/rfkrocktk/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-apt/labels/needs-docs","name":"needs-docs","color":"006b75"},{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-apt/labels/needs-tests","name":"needs-tests","color":"f7c6c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":32,"created_at":"2014-09-04T02:01:29Z","updated_at":"2015-01-08T19:20:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-apt/pulls/354","html_url":"https://github.com/puppetlabs/puppetlabs-apt/pull/354","diff_url":"https://github.com/puppetlabs/puppetlabs-apt/pull/354.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-apt/pull/354.patch"},"body":"Patch to allow GPG key fingerprints as key values. "},"comment":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-apt/issues/comments/69232957","html_url":"https://github.com/puppetlabs/puppetlabs-apt/pull/354#issuecomment-69232957","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apt/issues/354","id":69232957,"user":{"login":"rfkrocktk","id":347571,"avatar_url":"https://avatars.githubusercontent.com/u/347571?v=3","gravatar_id":"","url":"https://api.github.com/users/rfkrocktk","html_url":"https://github.com/rfkrocktk","followers_url":"https://api.github.com/users/rfkrocktk/followers","following_url":"https://api.github.com/users/rfkrocktk/following{/other_user}","gists_url":"https://api.github.com/users/rfkrocktk/gists{/gist_id}","starred_url":"https://api.github.com/users/rfkrocktk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfkrocktk/subscriptions","organizations_url":"https://api.github.com/users/rfkrocktk/orgs","repos_url":"https://api.github.com/users/rfkrocktk/repos","events_url":"https://api.github.com/users/rfkrocktk/events{/privacy}","received_events_url":"https://api.github.com/users/rfkrocktk/received_events","type":"User","site_admin":false},"created_at":"2015-01-08T19:20:33Z","updated_at":"2015-01-08T19:20:33Z","body":"Thanks everyone for helping out on this. You're planning on adding tests to\r\ncover this exact case, right? Getting the tests to pass is one thing, but\r\ncovering this new case is another, both are really important.\r\nOn Jan 8, 2015 9:46 AM, \"WolverineFan\" <notifications@github.com> wrote:\r\n\r\n> I did that too:\r\n>\r\n>    def self.key_line_hash(pub_line, fpr_line)\r\n>      pub_split = pub_line.split(':')\r\n>      fpr_split = fpr_line.split(':')\r\n>\r\n>     fingerprint = fpr_split.last\r\n>      return_hash = {\r\n>       :key_fingerprint => fingerprint,\r\n>       :key_long        => fingerprint[-16..-1], # last 16 characters of fingerprint\r\n>       :key_short       => fingerprint[-8..-1], # last 8 characters of fingerprint\r\n>\r\n> And referenced them in the self.instances function. Maybe some other\r\n> change I made is causing the failure. I'll do some more experimenting today\r\n> if I can get the tests running locally\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub\r\n> <https://github.com/puppetlabs/puppetlabs-apt/pull/354#issuecomment-69218060>\r\n> .\r\n>"}}