{"action":"created","issue":{"url":"https://api.github.com/repos/niftools/nifxml/issues/41","labels_url":"https://api.github.com/repos/niftools/nifxml/issues/41/labels{/name}","comments_url":"https://api.github.com/repos/niftools/nifxml/issues/41/comments","events_url":"https://api.github.com/repos/niftools/nifxml/issues/41/events","html_url":"https://github.com/niftools/nifxml/pull/41","id":54007214,"number":41,"title":"BSShaderProperties update","user":{"login":"ttl269","id":2514993,"avatar_url":"https://avatars.githubusercontent.com/u/2514993?v=3","gravatar_id":"","url":"https://api.github.com/users/ttl269","html_url":"https://github.com/ttl269","followers_url":"https://api.github.com/users/ttl269/followers","following_url":"https://api.github.com/users/ttl269/following{/other_user}","gists_url":"https://api.github.com/users/ttl269/gists{/gist_id}","starred_url":"https://api.github.com/users/ttl269/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttl269/subscriptions","organizations_url":"https://api.github.com/users/ttl269/orgs","repos_url":"https://api.github.com/users/ttl269/repos","events_url":"https://api.github.com/users/ttl269/events{/privacy}","received_events_url":"https://api.github.com/users/ttl269/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-01-11T22:12:55Z","updated_at":"2015-01-13T21:21:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/niftools/nifxml/pulls/41","html_url":"https://github.com/niftools/nifxml/pull/41","diff_url":"https://github.com/niftools/nifxml/pull/41.diff","patch_url":"https://github.com/niftools/nifxml/pull/41.patch"},"body":"@neomonkeus @skyfox69 @jonwd7 @Ghostwalker71 @throttlekitty @nexustheru @amorilia\r\nChanges made in `BSEffectShaderProperty`:\r\n1. Changed `Texture Clamp Mode` storage type from `uint` to `byte`, due to Skyrim's `BSEffectShaderProperty`, where the byte value of Texture Clamp Mode is followed by unknown non-zero byte value - it caused showing of a number in Texture Clamp Mode line instead of its showing of named value. This unknown byte is mostly set to 255 but in many meshes there are other values.\r\n2. \"Emmisive Color\" splitted to \"Base Color\" (renamed according to CK) and \"Alpha\". Now the variables `0` and `5` in `EffectShaderControlledVariable` list can be clearly named.\r\n\r\nAdded proposal of abstract parent object for Bethesda Shader properties which must not be shared (can't be \"combined\") for easier excluding of these properties in Nifskope's Combine Properties spell as requested @jonwd7 [#72](https://github.com/niftools/nifskope/pull/72#issuecomment-69505408). It is named `NonSharableBSShaderProperty`."},"comment":{"url":"https://api.github.com/repos/niftools/nifxml/issues/comments/69822388","html_url":"https://github.com/niftools/nifxml/pull/41#issuecomment-69822388","issue_url":"https://api.github.com/repos/niftools/nifxml/issues/41","id":69822388,"user":{"login":"ttl269","id":2514993,"avatar_url":"https://avatars.githubusercontent.com/u/2514993?v=3","gravatar_id":"","url":"https://api.github.com/users/ttl269","html_url":"https://github.com/ttl269","followers_url":"https://api.github.com/users/ttl269/followers","following_url":"https://api.github.com/users/ttl269/following{/other_user}","gists_url":"https://api.github.com/users/ttl269/gists{/gist_id}","starred_url":"https://api.github.com/users/ttl269/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttl269/subscriptions","organizations_url":"https://api.github.com/users/ttl269/orgs","repos_url":"https://api.github.com/users/ttl269/repos","events_url":"https://api.github.com/users/ttl269/events{/privacy}","received_events_url":"https://api.github.com/users/ttl269/received_events","type":"User","site_admin":false},"created_at":"2015-01-13T21:21:07Z","updated_at":"2015-01-13T21:21:07Z","body":"@jonwd7 *Did BSShaderProperty not inherit from NiProperty at some point in nif.xml's history?* It seems that no. Just before doing change to nif.xml today I have been searching for when `BSShaderProperty` was added to nif.xml (because this block was strange to me when I determined that it is not present in any Oblivion, Fallout 3 or Skyrim nif file. So, isn't it a real node and should it be abstract?). They added it [29. 10. 2008](https://github.com/amorilia/nifxml/commit/93a37f0e9cdbfc1869bd77d3c4ea50494f443048)  - but only added it, not used anywhere in nif.xml. I don't understand this step - maybe it was used in nifskope?. Then on [16.11.2008](https://github.com/amorilia/nifxml/commit/47c6b25f8bdd933fc13fe94126572a49c852af43) they made change and `BSShaderProperty` was used for inheritance in nif.xml."}}