{"action":"created","issue":{"url":"https://api.github.com/repos/whatwg/streams/issues/344","labels_url":"https://api.github.com/repos/whatwg/streams/issues/344/labels{/name}","comments_url":"https://api.github.com/repos/whatwg/streams/issues/344/comments","events_url":"https://api.github.com/repos/whatwg/streams/issues/344/events","html_url":"https://github.com/whatwg/streams/issues/344","id":70191248,"number":344,"title":"Difference in the specification between notes, pseudocode and example code","user":{"login":"edhager","id":4441986,"avatar_url":"https://avatars.githubusercontent.com/u/4441986?v=3","gravatar_id":"","url":"https://api.github.com/users/edhager","html_url":"https://github.com/edhager","followers_url":"https://api.github.com/users/edhager/followers","following_url":"https://api.github.com/users/edhager/following{/other_user}","gists_url":"https://api.github.com/users/edhager/gists{/gist_id}","starred_url":"https://api.github.com/users/edhager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edhager/subscriptions","organizations_url":"https://api.github.com/users/edhager/orgs","repos_url":"https://api.github.com/users/edhager/repos","events_url":"https://api.github.com/users/edhager/events{/privacy}","received_events_url":"https://api.github.com/users/edhager/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-22T17:44:41Z","updated_at":"2015-04-22T17:46:33Z","closed_at":null,"body":"Are you interested in comments related to inconsistencies in the specification?  I have a couple examples:\r\n\r\n**3.2.4.2. getReader()**\r\n\r\nThe notes say that getReader locks the stream and addition readers cannot be acquired.  The pseudocode and the reference implementation do not enforce this.  Also the specification does not indicate how getReader should respond when the stream is locked.\r\n\r\n**3.5.5. EnqueueInReadableStream ( stream, chunk )**\r\n\r\nLine 7 in the pseudocode indicates that undefined should be returned and this is reflected in the reference implementation but the example in \"9.2. A readable stream with an underlying push source and backpressure support\" shows that enqueue needs to return an indication of backpressure."},"comment":{"url":"https://api.github.com/repos/whatwg/streams/issues/comments/95281006","html_url":"https://github.com/whatwg/streams/issues/344#issuecomment-95281006","issue_url":"https://api.github.com/repos/whatwg/streams/issues/344","id":95281006,"user":{"login":"domenic","id":617481,"avatar_url":"https://avatars.githubusercontent.com/u/617481?v=3","gravatar_id":"","url":"https://api.github.com/users/domenic","html_url":"https://github.com/domenic","followers_url":"https://api.github.com/users/domenic/followers","following_url":"https://api.github.com/users/domenic/following{/other_user}","gists_url":"https://api.github.com/users/domenic/gists{/gist_id}","starred_url":"https://api.github.com/users/domenic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domenic/subscriptions","organizations_url":"https://api.github.com/users/domenic/orgs","repos_url":"https://api.github.com/users/domenic/repos","events_url":"https://api.github.com/users/domenic/events{/privacy}","received_events_url":"https://api.github.com/users/domenic/received_events","type":"User","site_admin":false},"created_at":"2015-04-22T17:46:33Z","updated_at":"2015-04-22T17:46:33Z","body":"> The pseudocode and the reference implementation do not enforce this.\r\n\r\nCan you write a test showing otherwise? The pseudocode and reference implementation do enforce this from what I can see.\r\n\r\n> but the example in \"9.2. A readable stream with an underlying push source and backpressure support\" shows that enqueue needs to return an indication of backpressure.\r\n\r\nExcellent catch, thank you; this was left out when merging #317."}}