{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/37083284","id":37083284,"diff_hunk":"@@ -0,0 +1,120 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements.  See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License.  You may obtain a copy of the License at\n+ *\n+ *    http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.spark.sql.catalyst.expressions\n+\n+import scala.collection.mutable.ArrayBuffer\n+\n+import org.apache.spark.SparkFunSuite\n+import org.apache.spark.sql.catalyst.plans.logical._\n+import org.apache.spark.sql.catalyst.dsl.plans._\n+import org.apache.spark.sql.catalyst.dsl.expressions._\n+\n+class CNFNormalizationSuite extends SparkFunSuite with PredicateHelper {\n+\n+  val testRelation = LocalRelation('a.int, 'b.int, 'c.int, 'd.int, 'e.int)\n+\n+  // Take in expression without And, normalize to its leftmost representation to be comparable\n+  private def normalizeOrExpression(expression: Expression): Expression = {\n+    val atoms = ArrayBuffer.empty[Expression]\n+    expression.foreachUp {\n+      case Or(l: Or, r: Or) => // do nothing\n+      case Or(l, r: Or) => atoms += l\n+      case Or(l: Or, r) => atoms += r\n+      case Or(l, r) => atoms += l; atoms += r\n+      case _ => // do nothing\n+    }\n+    if (!expression.isInstanceOf[Or]) {\n+      atoms += expression\n+    }\n+    atoms.sortBy(_.toString).reduce(Or)\n+  }","path":"sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CNFNormalizationSuite.scala","position":45,"original_position":45,"commit_id":"c00f3a3b6ebecf04890fe252ea04d8b5f1d44641","original_commit_id":"c00f3a3b6ebecf04890fe252ea04d8b5f1d44641","user":{"login":"liancheng","id":230655,"avatar_url":"https://avatars.githubusercontent.com/u/230655?v=3","gravatar_id":"","url":"https://api.github.com/users/liancheng","html_url":"https://github.com/liancheng","followers_url":"https://api.github.com/users/liancheng/followers","following_url":"https://api.github.com/users/liancheng/following{/other_user}","gists_url":"https://api.github.com/users/liancheng/gists{/gist_id}","starred_url":"https://api.github.com/users/liancheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liancheng/subscriptions","organizations_url":"https://api.github.com/users/liancheng/orgs","repos_url":"https://api.github.com/users/liancheng/repos","events_url":"https://api.github.com/users/liancheng/events{/privacy}","received_events_url":"https://api.github.com/users/liancheng/received_events","type":"User","site_admin":false},"body":"@yjshen Yeah, the above assumption is only correct if you do REAL CNF conversion in this PR. Currently De Morgan law is not considered.","created_at":"2015-08-14T14:47:59Z","updated_at":"2015-08-14T14:47:59Z","html_url":"https://github.com/apache/spark/pull/8200#discussion_r37083284","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/8200","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/37083284"},"html":{"href":"https://github.com/apache/spark/pull/8200#discussion_r37083284"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/8200"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/8200","id":42450000,"html_url":"https://github.com/apache/spark/pull/8200","diff_url":"https://github.com/apache/spark/pull/8200.diff","patch_url":"https://github.com/apache/spark/pull/8200.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/8200","number":8200,"state":"open","locked":false,"title":"[SPARK-6624][SQL]Convert filters into CNF for data sources","user":{"login":"yjshen","id":1387718,"avatar_url":"https://avatars.githubusercontent.com/u/1387718?v=3","gravatar_id":"","url":"https://api.github.com/users/yjshen","html_url":"https://github.com/yjshen","followers_url":"https://api.github.com/users/yjshen/followers","following_url":"https://api.github.com/users/yjshen/following{/other_user}","gists_url":"https://api.github.com/users/yjshen/gists{/gist_id}","starred_url":"https://api.github.com/users/yjshen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjshen/subscriptions","organizations_url":"https://api.github.com/users/yjshen/orgs","repos_url":"https://api.github.com/users/yjshen/repos","events_url":"https://api.github.com/users/yjshen/events{/privacy}","received_events_url":"https://api.github.com/users/yjshen/received_events","type":"User","site_admin":false},"body":"This PR aims at converting filters into CNF, i.e. AND of ORs. By doing this, we can possibly push more filters into datasource.\r\n\r\nFor example:\r\n```\r\na && b || f => (a || f) && (b || f)\r\na || b || c && d => (a || b || c) && (a || b || d)\r\na || (b && c || d) => (a || b || d) && (a || c || d)\r\n```\r\n\r\nJIRA: https://issues.apache.org/jira/browse/SPARK-6624","created_at":"2015-08-14T12:18:15Z","updated_at":"2015-08-14T14:47:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0343f04aaa1cf377206e4173a40ed43f0ef399d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/8200/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/8200/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/8200/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/c00f3a3b6ebecf04890fe252ea04d8b5f1d44641","head":{"label":"yjshen:cnf","ref":"cnf","sha":"c00f3a3b6ebecf04890fe252ea04d8b5f1d44641","user":{"login":"yjshen","id":1387718,"avatar_url":"https://avatars.githubusercontent.com/u/1387718?v=3","gravatar_id":"","url":"https://api.github.com/users/yjshen","html_url":"https://github.com/yjshen","followers_url":"https://api.github.com/users/yjshen/followers","following_url":"https://api.github.com/users/yjshen/following{/other_user}","gists_url":"https://api.github.com/users/yjshen/gists{/gist_id}","starred_url":"https://api.github.com/users/yjshen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjshen/subscriptions","organizations_url":"https://api.github.com/users/yjshen/orgs","repos_url":"https://api.github.com/users/yjshen/repos","events_url":"https://api.github.com/users/yjshen/events{/privacy}","received_events_url":"https://api.github.com/users/yjshen/received_events","type":"User","site_admin":false},"repo":{"id":32433144,"name":"spark","full_name":"yjshen/spark","owner":{"login":"yjshen","id":1387718,"avatar_url":"https://avatars.githubusercontent.com/u/1387718?v=3","gravatar_id":"","url":"https://api.github.com/users/yjshen","html_url":"https://github.com/yjshen","followers_url":"https://api.github.com/users/yjshen/followers","following_url":"https://api.github.com/users/yjshen/following{/other_user}","gists_url":"https://api.github.com/users/yjshen/gists{/gist_id}","starred_url":"https://api.github.com/users/yjshen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjshen/subscriptions","organizations_url":"https://api.github.com/users/yjshen/orgs","repos_url":"https://api.github.com/users/yjshen/repos","events_url":"https://api.github.com/users/yjshen/events{/privacy}","received_events_url":"https://api.github.com/users/yjshen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yjshen/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/yjshen/spark","forks_url":"https://api.github.com/repos/yjshen/spark/forks","keys_url":"https://api.github.com/repos/yjshen/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yjshen/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yjshen/spark/teams","hooks_url":"https://api.github.com/repos/yjshen/spark/hooks","issue_events_url":"https://api.github.com/repos/yjshen/spark/issues/events{/number}","events_url":"https://api.github.com/repos/yjshen/spark/events","assignees_url":"https://api.github.com/repos/yjshen/spark/assignees{/user}","branches_url":"https://api.github.com/repos/yjshen/spark/branches{/branch}","tags_url":"https://api.github.com/repos/yjshen/spark/tags","blobs_url":"https://api.github.com/repos/yjshen/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yjshen/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yjshen/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/yjshen/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yjshen/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/yjshen/spark/languages","stargazers_url":"https://api.github.com/repos/yjshen/spark/stargazers","contributors_url":"https://api.github.com/repos/yjshen/spark/contributors","subscribers_url":"https://api.github.com/repos/yjshen/spark/subscribers","subscription_url":"https://api.github.com/repos/yjshen/spark/subscription","commits_url":"https://api.github.com/repos/yjshen/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/yjshen/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/yjshen/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/yjshen/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/yjshen/spark/contents/{+path}","compare_url":"https://api.github.com/repos/yjshen/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yjshen/spark/merges","archive_url":"https://api.github.com/repos/yjshen/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yjshen/spark/downloads","issues_url":"https://api.github.com/repos/yjshen/spark/issues{/number}","pulls_url":"https://api.github.com/repos/yjshen/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/yjshen/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/yjshen/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yjshen/spark/labels{/name}","releases_url":"https://api.github.com/repos/yjshen/spark/releases{/id}","created_at":"2015-03-18T02:27:58Z","updated_at":"2015-05-02T04:50:02Z","pushed_at":"2015-08-14T12:53:21Z","git_url":"git://github.com/yjshen/spark.git","ssh_url":"git@github.com:yjshen/spark.git","clone_url":"https://github.com/yjshen/spark.git","svn_url":"https://github.com/yjshen/spark","homepage":null,"size":120055,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"c8677d73666850b37ff937520e538650632ce304","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-08-14T14:04:13Z","pushed_at":"2015-08-14T14:24:32Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1610030,"stargazers_count":5082,"watchers_count":5082,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4638,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":337,"forks":4638,"open_issues":337,"watchers":5082,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/8200"},"html":{"href":"https://github.com/apache/spark/pull/8200"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/8200"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/8200/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/8200/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/8200/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/c00f3a3b6ebecf04890fe252ea04d8b5f1d44641"}}}}