{"action":"created","comment":{"url":"https://api.github.com/repos/leethomason/tinyxml2/pulls/comments/35824799","id":35824799,"diff_hunk":"@@ -75,10 +75,12 @@ distribution.\n \t\t\t\tconst int required = _vsnprintf(str, len, format, va);\r\n \t\t\t\tdelete[] str;\r\n \t\t\t\tif ( required != -1 ) {\r\n+\t\t\t\t\tTIXMLASSERT( required >= 0 );\r","path":"tinyxml2.cpp","position":4,"original_position":4,"commit_id":"1d32e586d563ba0aaa5e5e54d802c105f73adf74","original_commit_id":"1d32e586d563ba0aaa5e5e54d802c105f73adf74","user":{"login":"ariccio","id":2142308,"avatar_url":"https://avatars.githubusercontent.com/u/2142308?v=3","gravatar_id":"","url":"https://api.github.com/users/ariccio","html_url":"https://github.com/ariccio","followers_url":"https://api.github.com/users/ariccio/followers","following_url":"https://api.github.com/users/ariccio/following{/other_user}","gists_url":"https://api.github.com/users/ariccio/gists{/gist_id}","starred_url":"https://api.github.com/users/ariccio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariccio/subscriptions","organizations_url":"https://api.github.com/users/ariccio/orgs","repos_url":"https://api.github.com/users/ariccio/repos","events_url":"https://api.github.com/users/ariccio/events{/privacy}","received_events_url":"https://api.github.com/users/ariccio/received_events","type":"User","site_admin":false},"body":"I think that this'd make more sense if it were outside the branch? (before `if ( required != -1 )`","created_at":"2015-07-29T23:41:02Z","updated_at":"2015-07-29T23:41:02Z","html_url":"https://github.com/leethomason/tinyxml2/pull/363#discussion_r35824799","pull_request_url":"https://api.github.com/repos/leethomason/tinyxml2/pulls/363","_links":{"self":{"href":"https://api.github.com/repos/leethomason/tinyxml2/pulls/comments/35824799"},"html":{"href":"https://github.com/leethomason/tinyxml2/pull/363#discussion_r35824799"},"pull_request":{"href":"https://api.github.com/repos/leethomason/tinyxml2/pulls/363"}}},"pull_request":{"url":"https://api.github.com/repos/leethomason/tinyxml2/pulls/363","id":40907300,"html_url":"https://github.com/leethomason/tinyxml2/pull/363","diff_url":"https://github.com/leethomason/tinyxml2/pull/363.diff","patch_url":"https://github.com/leethomason/tinyxml2/pull/363.patch","issue_url":"https://api.github.com/repos/leethomason/tinyxml2/issues/363","number":363,"state":"open","locked":false,"title":"Asserts for formatted output length","user":{"login":"Dmitry-Me","id":1277095,"avatar_url":"https://avatars.githubusercontent.com/u/1277095?v=3","gravatar_id":"","url":"https://api.github.com/users/Dmitry-Me","html_url":"https://github.com/Dmitry-Me","followers_url":"https://api.github.com/users/Dmitry-Me/followers","following_url":"https://api.github.com/users/Dmitry-Me/following{/other_user}","gists_url":"https://api.github.com/users/Dmitry-Me/gists{/gist_id}","starred_url":"https://api.github.com/users/Dmitry-Me/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dmitry-Me/subscriptions","organizations_url":"https://api.github.com/users/Dmitry-Me/orgs","repos_url":"https://api.github.com/users/Dmitry-Me/repos","events_url":"https://api.github.com/users/Dmitry-Me/events{/privacy}","received_events_url":"https://api.github.com/users/Dmitry-Me/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-07-27T14:13:18Z","updated_at":"2015-07-29T23:41:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"434d335487040f6976d6d4a8a47c8d28fbefc19b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/leethomason/tinyxml2/pulls/363/commits","review_comments_url":"https://api.github.com/repos/leethomason/tinyxml2/pulls/363/comments","review_comment_url":"https://api.github.com/repos/leethomason/tinyxml2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/leethomason/tinyxml2/issues/363/comments","statuses_url":"https://api.github.com/repos/leethomason/tinyxml2/statuses/1d32e586d563ba0aaa5e5e54d802c105f73adf74","head":{"label":"Dmitry-Me:outputLengthAsserts","ref":"outputLengthAsserts","sha":"1d32e586d563ba0aaa5e5e54d802c105f73adf74","user":{"login":"Dmitry-Me","id":1277095,"avatar_url":"https://avatars.githubusercontent.com/u/1277095?v=3","gravatar_id":"","url":"https://api.github.com/users/Dmitry-Me","html_url":"https://github.com/Dmitry-Me","followers_url":"https://api.github.com/users/Dmitry-Me/followers","following_url":"https://api.github.com/users/Dmitry-Me/following{/other_user}","gists_url":"https://api.github.com/users/Dmitry-Me/gists{/gist_id}","starred_url":"https://api.github.com/users/Dmitry-Me/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dmitry-Me/subscriptions","organizations_url":"https://api.github.com/users/Dmitry-Me/orgs","repos_url":"https://api.github.com/users/Dmitry-Me/repos","events_url":"https://api.github.com/users/Dmitry-Me/events{/privacy}","received_events_url":"https://api.github.com/users/Dmitry-Me/received_events","type":"User","site_admin":false},"repo":{"id":22466434,"name":"tinyxml2","full_name":"Dmitry-Me/tinyxml2","owner":{"login":"Dmitry-Me","id":1277095,"avatar_url":"https://avatars.githubusercontent.com/u/1277095?v=3","gravatar_id":"","url":"https://api.github.com/users/Dmitry-Me","html_url":"https://github.com/Dmitry-Me","followers_url":"https://api.github.com/users/Dmitry-Me/followers","following_url":"https://api.github.com/users/Dmitry-Me/following{/other_user}","gists_url":"https://api.github.com/users/Dmitry-Me/gists{/gist_id}","starred_url":"https://api.github.com/users/Dmitry-Me/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dmitry-Me/subscriptions","organizations_url":"https://api.github.com/users/Dmitry-Me/orgs","repos_url":"https://api.github.com/users/Dmitry-Me/repos","events_url":"https://api.github.com/users/Dmitry-Me/events{/privacy}","received_events_url":"https://api.github.com/users/Dmitry-Me/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Dmitry-Me/tinyxml2","description":"TinyXML2 is a simple, small, efficient, C++ XML parser that can be easily integrating into other programs.","fork":true,"url":"https://api.github.com/repos/Dmitry-Me/tinyxml2","forks_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/forks","keys_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/teams","hooks_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/hooks","issue_events_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/issues/events{/number}","events_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/events","assignees_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/assignees{/user}","branches_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/branches{/branch}","tags_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/tags","blobs_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/statuses/{sha}","languages_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/languages","stargazers_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/stargazers","contributors_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/contributors","subscribers_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/subscribers","subscription_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/subscription","commits_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/contents/{+path}","compare_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/merges","archive_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/downloads","issues_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/issues{/number}","pulls_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/pulls{/number}","milestones_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/milestones{/number}","notifications_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/labels{/name}","releases_url":"https://api.github.com/repos/Dmitry-Me/tinyxml2/releases{/id}","created_at":"2014-07-31T11:09:27Z","updated_at":"2014-09-04T07:31:28Z","pushed_at":"2015-07-27T14:12:36Z","git_url":"git://github.com/Dmitry-Me/tinyxml2.git","ssh_url":"git@github.com:Dmitry-Me/tinyxml2.git","clone_url":"https://github.com/Dmitry-Me/tinyxml2.git","svn_url":"https://github.com/Dmitry-Me/tinyxml2","homepage":"","size":2482,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"leethomason:master","ref":"master","sha":"78fca3db835a5e2de1f3e90f5c6362dda750e3ac","user":{"login":"leethomason","id":699925,"avatar_url":"https://avatars.githubusercontent.com/u/699925?v=3","gravatar_id":"","url":"https://api.github.com/users/leethomason","html_url":"https://github.com/leethomason","followers_url":"https://api.github.com/users/leethomason/followers","following_url":"https://api.github.com/users/leethomason/following{/other_user}","gists_url":"https://api.github.com/users/leethomason/gists{/gist_id}","starred_url":"https://api.github.com/users/leethomason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leethomason/subscriptions","organizations_url":"https://api.github.com/users/leethomason/orgs","repos_url":"https://api.github.com/users/leethomason/repos","events_url":"https://api.github.com/users/leethomason/events{/privacy}","received_events_url":"https://api.github.com/users/leethomason/received_events","type":"User","site_admin":false},"repo":{"id":3542607,"name":"tinyxml2","full_name":"leethomason/tinyxml2","owner":{"login":"leethomason","id":699925,"avatar_url":"https://avatars.githubusercontent.com/u/699925?v=3","gravatar_id":"","url":"https://api.github.com/users/leethomason","html_url":"https://github.com/leethomason","followers_url":"https://api.github.com/users/leethomason/followers","following_url":"https://api.github.com/users/leethomason/following{/other_user}","gists_url":"https://api.github.com/users/leethomason/gists{/gist_id}","starred_url":"https://api.github.com/users/leethomason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leethomason/subscriptions","organizations_url":"https://api.github.com/users/leethomason/orgs","repos_url":"https://api.github.com/users/leethomason/repos","events_url":"https://api.github.com/users/leethomason/events{/privacy}","received_events_url":"https://api.github.com/users/leethomason/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leethomason/tinyxml2","description":"TinyXML2 is a simple, small, efficient, C++ XML parser that can be easily integrating into other programs.","fork":false,"url":"https://api.github.com/repos/leethomason/tinyxml2","forks_url":"https://api.github.com/repos/leethomason/tinyxml2/forks","keys_url":"https://api.github.com/repos/leethomason/tinyxml2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leethomason/tinyxml2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leethomason/tinyxml2/teams","hooks_url":"https://api.github.com/repos/leethomason/tinyxml2/hooks","issue_events_url":"https://api.github.com/repos/leethomason/tinyxml2/issues/events{/number}","events_url":"https://api.github.com/repos/leethomason/tinyxml2/events","assignees_url":"https://api.github.com/repos/leethomason/tinyxml2/assignees{/user}","branches_url":"https://api.github.com/repos/leethomason/tinyxml2/branches{/branch}","tags_url":"https://api.github.com/repos/leethomason/tinyxml2/tags","blobs_url":"https://api.github.com/repos/leethomason/tinyxml2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leethomason/tinyxml2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leethomason/tinyxml2/git/refs{/sha}","trees_url":"https://api.github.com/repos/leethomason/tinyxml2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leethomason/tinyxml2/statuses/{sha}","languages_url":"https://api.github.com/repos/leethomason/tinyxml2/languages","stargazers_url":"https://api.github.com/repos/leethomason/tinyxml2/stargazers","contributors_url":"https://api.github.com/repos/leethomason/tinyxml2/contributors","subscribers_url":"https://api.github.com/repos/leethomason/tinyxml2/subscribers","subscription_url":"https://api.github.com/repos/leethomason/tinyxml2/subscription","commits_url":"https://api.github.com/repos/leethomason/tinyxml2/commits{/sha}","git_commits_url":"https://api.github.com/repos/leethomason/tinyxml2/git/commits{/sha}","comments_url":"https://api.github.com/repos/leethomason/tinyxml2/comments{/number}","issue_comment_url":"https://api.github.com/repos/leethomason/tinyxml2/issues/comments{/number}","contents_url":"https://api.github.com/repos/leethomason/tinyxml2/contents/{+path}","compare_url":"https://api.github.com/repos/leethomason/tinyxml2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leethomason/tinyxml2/merges","archive_url":"https://api.github.com/repos/leethomason/tinyxml2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leethomason/tinyxml2/downloads","issues_url":"https://api.github.com/repos/leethomason/tinyxml2/issues{/number}","pulls_url":"https://api.github.com/repos/leethomason/tinyxml2/pulls{/number}","milestones_url":"https://api.github.com/repos/leethomason/tinyxml2/milestones{/number}","notifications_url":"https://api.github.com/repos/leethomason/tinyxml2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leethomason/tinyxml2/labels{/name}","releases_url":"https://api.github.com/repos/leethomason/tinyxml2/releases{/id}","created_at":"2012-02-25T05:15:50Z","updated_at":"2015-07-29T10:12:01Z","pushed_at":"2015-07-27T14:13:18Z","git_url":"git://github.com/leethomason/tinyxml2.git","ssh_url":"git@github.com:leethomason/tinyxml2.git","clone_url":"https://github.com/leethomason/tinyxml2.git","svn_url":"https://github.com/leethomason/tinyxml2","homepage":"","size":3257,"stargazers_count":846,"watchers_count":846,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":406,"mirror_url":null,"open_issues_count":35,"forks":406,"open_issues":35,"watchers":846,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/leethomason/tinyxml2/pulls/363"},"html":{"href":"https://github.com/leethomason/tinyxml2/pull/363"},"issue":{"href":"https://api.github.com/repos/leethomason/tinyxml2/issues/363"},"comments":{"href":"https://api.github.com/repos/leethomason/tinyxml2/issues/363/comments"},"review_comments":{"href":"https://api.github.com/repos/leethomason/tinyxml2/pulls/363/comments"},"review_comment":{"href":"https://api.github.com/repos/leethomason/tinyxml2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/leethomason/tinyxml2/pulls/363/commits"},"statuses":{"href":"https://api.github.com/repos/leethomason/tinyxml2/statuses/1d32e586d563ba0aaa5e5e54d802c105f73adf74"}}}}