{"action":"created","comment":{"url":"https://api.github.com/repos/ignatov/intellij-erlang/pulls/comments/37501876","id":37501876,"diff_hunk":"@@ -321,6 +324,32 @@ argument_definition_list ::= '(' argument_definition? (',' argument_definition)*\n clause_guard ::= when <<guarded guard>> {pin=1}\n clause_body ::= '->' exprs {pin=1}\n \n+app_expression ::= empty '{' 'application' ',' module_ref ',' app_parameters '}' {elementType=tuple_expression}\n+app_parameters ::= '[' app_parameter? (',' app_parameter)* ']' {elementType=list_expression}\n+app_parameter ::= '{'\n+   ('description' ',' string_literal\n+  | 'id' ',' string_literal\n+  | 'vsn' ',' string_literal\n+  | 'modules' ',' app_modules\n+  | 'maxP' ',' integer\n+  | 'maxT' ',' integer\n+  | 'registered' ',' app_modules\n+  | 'included_applications' ',' app_applications\n+  | 'applications' ',' app_applications\n+  | 'env' ',' app_env\n+  | 'mod' ',' app_mod\n+  | 'start_phases' ',' expression\n+  | 'runtime_dependencies' ',' app_runtime_deps\n+  | config_exprs)\n+  '}' {methods=[getName]}","path":"grammars/erlang.bnf","position":60,"original_position":58,"commit_id":"6a7e7003578382ef1cc5fd3862157b0f732dbdde","original_commit_id":"6d746b255ce2a23ca5d86686d578caee99e8e45f","user":{"login":"telezhnaya","id":11246099,"avatar_url":"https://avatars.githubusercontent.com/u/11246099?v=3","gravatar_id":"","url":"https://api.github.com/users/telezhnaya","html_url":"https://github.com/telezhnaya","followers_url":"https://api.github.com/users/telezhnaya/followers","following_url":"https://api.github.com/users/telezhnaya/following{/other_user}","gists_url":"https://api.github.com/users/telezhnaya/gists{/gist_id}","starred_url":"https://api.github.com/users/telezhnaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telezhnaya/subscriptions","organizations_url":"https://api.github.com/users/telezhnaya/orgs","repos_url":"https://api.github.com/users/telezhnaya/repos","events_url":"https://api.github.com/users/telezhnaya/events{/privacy}","received_events_url":"https://api.github.com/users/telezhnaya/received_events","type":"User","site_admin":false},"body":"No. I've introduced this PSI element for resolving of modules. Name of commit and name of pull request alludes to it.\r\nI think it's the most natural solution. When we type `-behaviour(<caret>)`, we already know that there will be module. This scenario is identical. When we are in app file and typing `modules, [<caret>]`, we already know that there will be list of modules.\r\n\r\nI didn't want to change ImportedOtpApp at all, but it depended on old PSI structure. So I've changed PSI structure and refresh ImportedOtpApp.","created_at":"2015-08-20T07:29:24Z","updated_at":"2015-08-20T07:29:24Z","html_url":"https://github.com/ignatov/intellij-erlang/pull/669#discussion_r37501876","pull_request_url":"https://api.github.com/repos/ignatov/intellij-erlang/pulls/669","_links":{"self":{"href":"https://api.github.com/repos/ignatov/intellij-erlang/pulls/comments/37501876"},"html":{"href":"https://github.com/ignatov/intellij-erlang/pull/669#discussion_r37501876"},"pull_request":{"href":"https://api.github.com/repos/ignatov/intellij-erlang/pulls/669"}}},"pull_request":{"url":"https://api.github.com/repos/ignatov/intellij-erlang/pulls/669","id":42581309,"html_url":"https://github.com/ignatov/intellij-erlang/pull/669","diff_url":"https://github.com/ignatov/intellij-erlang/pull/669.diff","patch_url":"https://github.com/ignatov/intellij-erlang/pull/669.patch","issue_url":"https://api.github.com/repos/ignatov/intellij-erlang/issues/669","number":669,"state":"open","locked":false,"title":"Resolving application files","user":{"login":"telezhnaya","id":11246099,"avatar_url":"https://avatars.githubusercontent.com/u/11246099?v=3","gravatar_id":"","url":"https://api.github.com/users/telezhnaya","html_url":"https://github.com/telezhnaya","followers_url":"https://api.github.com/users/telezhnaya/followers","following_url":"https://api.github.com/users/telezhnaya/following{/other_user}","gists_url":"https://api.github.com/users/telezhnaya/gists{/gist_id}","starred_url":"https://api.github.com/users/telezhnaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telezhnaya/subscriptions","organizations_url":"https://api.github.com/users/telezhnaya/orgs","repos_url":"https://api.github.com/users/telezhnaya/repos","events_url":"https://api.github.com/users/telezhnaya/events{/privacy}","received_events_url":"https://api.github.com/users/telezhnaya/received_events","type":"User","site_admin":false},"body":"Have a look, please.\r\n\r\nUpd: I haven't added any tests on resolving. I just want to understand, is it a good solution. I will add them after first review.","created_at":"2015-08-17T12:12:33Z","updated_at":"2015-08-20T07:29:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d75520cdcac13ffade333ef153cd2cf3d190630","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ignatov/intellij-erlang/pulls/669/commits","review_comments_url":"https://api.github.com/repos/ignatov/intellij-erlang/pulls/669/comments","review_comment_url":"https://api.github.com/repos/ignatov/intellij-erlang/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ignatov/intellij-erlang/issues/669/comments","statuses_url":"https://api.github.com/repos/ignatov/intellij-erlang/statuses/6a7e7003578382ef1cc5fd3862157b0f732dbdde","head":{"label":"telezhnaya:appResolving","ref":"appResolving","sha":"6a7e7003578382ef1cc5fd3862157b0f732dbdde","user":{"login":"telezhnaya","id":11246099,"avatar_url":"https://avatars.githubusercontent.com/u/11246099?v=3","gravatar_id":"","url":"https://api.github.com/users/telezhnaya","html_url":"https://github.com/telezhnaya","followers_url":"https://api.github.com/users/telezhnaya/followers","following_url":"https://api.github.com/users/telezhnaya/following{/other_user}","gists_url":"https://api.github.com/users/telezhnaya/gists{/gist_id}","starred_url":"https://api.github.com/users/telezhnaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telezhnaya/subscriptions","organizations_url":"https://api.github.com/users/telezhnaya/orgs","repos_url":"https://api.github.com/users/telezhnaya/repos","events_url":"https://api.github.com/users/telezhnaya/events{/privacy}","received_events_url":"https://api.github.com/users/telezhnaya/received_events","type":"User","site_admin":false},"repo":{"id":38743302,"name":"intellij-erlang","full_name":"telezhnaya/intellij-erlang","owner":{"login":"telezhnaya","id":11246099,"avatar_url":"https://avatars.githubusercontent.com/u/11246099?v=3","gravatar_id":"","url":"https://api.github.com/users/telezhnaya","html_url":"https://github.com/telezhnaya","followers_url":"https://api.github.com/users/telezhnaya/followers","following_url":"https://api.github.com/users/telezhnaya/following{/other_user}","gists_url":"https://api.github.com/users/telezhnaya/gists{/gist_id}","starred_url":"https://api.github.com/users/telezhnaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telezhnaya/subscriptions","organizations_url":"https://api.github.com/users/telezhnaya/orgs","repos_url":"https://api.github.com/users/telezhnaya/repos","events_url":"https://api.github.com/users/telezhnaya/events{/privacy}","received_events_url":"https://api.github.com/users/telezhnaya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/telezhnaya/intellij-erlang","description":"Erlang IDE (IntelliJ-based)","fork":true,"url":"https://api.github.com/repos/telezhnaya/intellij-erlang","forks_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/forks","keys_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/teams","hooks_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/hooks","issue_events_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/issues/events{/number}","events_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/events","assignees_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/assignees{/user}","branches_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/branches{/branch}","tags_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/tags","blobs_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/git/refs{/sha}","trees_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/statuses/{sha}","languages_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/languages","stargazers_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/stargazers","contributors_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/contributors","subscribers_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/subscribers","subscription_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/subscription","commits_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/commits{/sha}","git_commits_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/git/commits{/sha}","comments_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/comments{/number}","issue_comment_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/issues/comments{/number}","contents_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/contents/{+path}","compare_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/merges","archive_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/downloads","issues_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/issues{/number}","pulls_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/pulls{/number}","milestones_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/milestones{/number}","notifications_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/labels{/name}","releases_url":"https://api.github.com/repos/telezhnaya/intellij-erlang/releases{/id}","created_at":"2015-07-08T09:00:53Z","updated_at":"2015-07-08T09:00:56Z","pushed_at":"2015-08-20T05:34:20Z","git_url":"git://github.com/telezhnaya/intellij-erlang.git","ssh_url":"git@github.com:telezhnaya/intellij-erlang.git","clone_url":"https://github.com/telezhnaya/intellij-erlang.git","svn_url":"https://github.com/telezhnaya/intellij-erlang","homepage":"https://www.jetbrains.com/idea/features/erlang.html","size":69378,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ignatov:master","ref":"master","sha":"eaf36c22295225695a617d77afb384a01faf4806","user":{"login":"ignatov","id":426890,"avatar_url":"https://avatars.githubusercontent.com/u/426890?v=3","gravatar_id":"","url":"https://api.github.com/users/ignatov","html_url":"https://github.com/ignatov","followers_url":"https://api.github.com/users/ignatov/followers","following_url":"https://api.github.com/users/ignatov/following{/other_user}","gists_url":"https://api.github.com/users/ignatov/gists{/gist_id}","starred_url":"https://api.github.com/users/ignatov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignatov/subscriptions","organizations_url":"https://api.github.com/users/ignatov/orgs","repos_url":"https://api.github.com/users/ignatov/repos","events_url":"https://api.github.com/users/ignatov/events{/privacy}","received_events_url":"https://api.github.com/users/ignatov/received_events","type":"User","site_admin":false},"repo":{"id":5168907,"name":"intellij-erlang","full_name":"ignatov/intellij-erlang","owner":{"login":"ignatov","id":426890,"avatar_url":"https://avatars.githubusercontent.com/u/426890?v=3","gravatar_id":"","url":"https://api.github.com/users/ignatov","html_url":"https://github.com/ignatov","followers_url":"https://api.github.com/users/ignatov/followers","following_url":"https://api.github.com/users/ignatov/following{/other_user}","gists_url":"https://api.github.com/users/ignatov/gists{/gist_id}","starred_url":"https://api.github.com/users/ignatov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignatov/subscriptions","organizations_url":"https://api.github.com/users/ignatov/orgs","repos_url":"https://api.github.com/users/ignatov/repos","events_url":"https://api.github.com/users/ignatov/events{/privacy}","received_events_url":"https://api.github.com/users/ignatov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ignatov/intellij-erlang","description":"Erlang IDE (IntelliJ-based)","fork":false,"url":"https://api.github.com/repos/ignatov/intellij-erlang","forks_url":"https://api.github.com/repos/ignatov/intellij-erlang/forks","keys_url":"https://api.github.com/repos/ignatov/intellij-erlang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ignatov/intellij-erlang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ignatov/intellij-erlang/teams","hooks_url":"https://api.github.com/repos/ignatov/intellij-erlang/hooks","issue_events_url":"https://api.github.com/repos/ignatov/intellij-erlang/issues/events{/number}","events_url":"https://api.github.com/repos/ignatov/intellij-erlang/events","assignees_url":"https://api.github.com/repos/ignatov/intellij-erlang/assignees{/user}","branches_url":"https://api.github.com/repos/ignatov/intellij-erlang/branches{/branch}","tags_url":"https://api.github.com/repos/ignatov/intellij-erlang/tags","blobs_url":"https://api.github.com/repos/ignatov/intellij-erlang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ignatov/intellij-erlang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ignatov/intellij-erlang/git/refs{/sha}","trees_url":"https://api.github.com/repos/ignatov/intellij-erlang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ignatov/intellij-erlang/statuses/{sha}","languages_url":"https://api.github.com/repos/ignatov/intellij-erlang/languages","stargazers_url":"https://api.github.com/repos/ignatov/intellij-erlang/stargazers","contributors_url":"https://api.github.com/repos/ignatov/intellij-erlang/contributors","subscribers_url":"https://api.github.com/repos/ignatov/intellij-erlang/subscribers","subscription_url":"https://api.github.com/repos/ignatov/intellij-erlang/subscription","commits_url":"https://api.github.com/repos/ignatov/intellij-erlang/commits{/sha}","git_commits_url":"https://api.github.com/repos/ignatov/intellij-erlang/git/commits{/sha}","comments_url":"https://api.github.com/repos/ignatov/intellij-erlang/comments{/number}","issue_comment_url":"https://api.github.com/repos/ignatov/intellij-erlang/issues/comments{/number}","contents_url":"https://api.github.com/repos/ignatov/intellij-erlang/contents/{+path}","compare_url":"https://api.github.com/repos/ignatov/intellij-erlang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ignatov/intellij-erlang/merges","archive_url":"https://api.github.com/repos/ignatov/intellij-erlang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ignatov/intellij-erlang/downloads","issues_url":"https://api.github.com/repos/ignatov/intellij-erlang/issues{/number}","pulls_url":"https://api.github.com/repos/ignatov/intellij-erlang/pulls{/number}","milestones_url":"https://api.github.com/repos/ignatov/intellij-erlang/milestones{/number}","notifications_url":"https://api.github.com/repos/ignatov/intellij-erlang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ignatov/intellij-erlang/labels{/name}","releases_url":"https://api.github.com/repos/ignatov/intellij-erlang/releases{/id}","created_at":"2012-07-24T17:41:30Z","updated_at":"2015-08-18T23:53:32Z","pushed_at":"2015-08-19T16:34:58Z","git_url":"git://github.com/ignatov/intellij-erlang.git","ssh_url":"git@github.com:ignatov/intellij-erlang.git","clone_url":"https://github.com/ignatov/intellij-erlang.git","svn_url":"https://github.com/ignatov/intellij-erlang","homepage":"https://www.jetbrains.com/idea/features/erlang.html","size":74350,"stargazers_count":396,"watchers_count":396,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":44,"mirror_url":null,"open_issues_count":120,"forks":44,"open_issues":120,"watchers":396,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ignatov/intellij-erlang/pulls/669"},"html":{"href":"https://github.com/ignatov/intellij-erlang/pull/669"},"issue":{"href":"https://api.github.com/repos/ignatov/intellij-erlang/issues/669"},"comments":{"href":"https://api.github.com/repos/ignatov/intellij-erlang/issues/669/comments"},"review_comments":{"href":"https://api.github.com/repos/ignatov/intellij-erlang/pulls/669/comments"},"review_comment":{"href":"https://api.github.com/repos/ignatov/intellij-erlang/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ignatov/intellij-erlang/pulls/669/commits"},"statuses":{"href":"https://api.github.com/repos/ignatov/intellij-erlang/statuses/6a7e7003578382ef1cc5fd3862157b0f732dbdde"}}}}