{"action":"created","comment":{"url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/comments/42936039","id":42936039,"diff_hunk":"@@ -0,0 +1,82 @@\n+/*\n+ * Bittorrent Client using Qt and libtorrent.\n+ * Copyright (C) 2015 Eugene Shalygin\n+ *\n+ * This program is free software; you can redistribute it and/or\n+ * modify it under the terms of the GNU General Public License\n+ * as published by the Free Software Foundation; either version 2\n+ * of the License, or (at your option) any later version.\n+ *\n+ * This program is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+ * GNU General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU General Public License\n+ * along with this program; if not, write to the Free Software\n+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.\n+ *\n+ * In addition, as a special exception, the copyright holders give permission to\n+ * link this program with the OpenSSL project's \"OpenSSL\" library (or with\n+ * modified versions of it that use the same license as the \"OpenSSL\" library),\n+ * and distribute the linked executables. You must obey the GNU General Public\n+ * License in all respects for all of the code used other than \"OpenSSL\".  If you\n+ * modify file(s), you may extend this exception to your version of the file(s),\n+ * but you are not obligated to do so. If you do not wish to do so, delete this\n+ * exception statement from your version.\n+ */\n+\n+#ifndef NOTIFIER_H\n+#define NOTIFIER_H\n+\n+#include <QObject>\n+\n+QT_BEGIN_NAMESPACE","path":"src/gui/notifications/notifier.h","position":34,"original_position":34,"commit_id":"38146ad0808ccda81122e8d44260c14cbea76e95","original_commit_id":"38146ad0808ccda81122e8d44260c14cbea76e95","user":{"login":"glassez","id":5063477,"avatar_url":"https://avatars.githubusercontent.com/u/5063477?v=3","gravatar_id":"","url":"https://api.github.com/users/glassez","html_url":"https://github.com/glassez","followers_url":"https://api.github.com/users/glassez/followers","following_url":"https://api.github.com/users/glassez/following{/other_user}","gists_url":"https://api.github.com/users/glassez/gists{/gist_id}","starred_url":"https://api.github.com/users/glassez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glassez/subscriptions","organizations_url":"https://api.github.com/users/glassez/orgs","repos_url":"https://api.github.com/users/glassez/repos","events_url":"https://api.github.com/users/glassez/events{/privacy}","received_events_url":"https://api.github.com/users/glassez/received_events","type":"User","site_admin":false},"body":"No. But QT_BEGIN_NAMESPACE/QT_END_NAMESPACE are not enough to support Qt namespace.","created_at":"2015-10-24T17:21:04Z","updated_at":"2015-10-24T17:21:04Z","html_url":"https://github.com/qbittorrent/qBittorrent/pull/3810#discussion_r42936039","pull_request_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/3810","_links":{"self":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/comments/42936039"},"html":{"href":"https://github.com/qbittorrent/qBittorrent/pull/3810#discussion_r42936039"},"pull_request":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/3810"}}},"pull_request":{"url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/3810","id":45310949,"html_url":"https://github.com/qbittorrent/qBittorrent/pull/3810","diff_url":"https://github.com/qbittorrent/qBittorrent/pull/3810.diff","patch_url":"https://github.com/qbittorrent/qBittorrent/pull/3810.patch","issue_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/3810","number":3810,"state":"open","locked":false,"title":"Improve desktop notifications","user":{"login":"evsh","id":394621,"avatar_url":"https://avatars.githubusercontent.com/u/394621?v=3","gravatar_id":"","url":"https://api.github.com/users/evsh","html_url":"https://github.com/evsh","followers_url":"https://api.github.com/users/evsh/followers","following_url":"https://api.github.com/users/evsh/following{/other_user}","gists_url":"https://api.github.com/users/evsh/gists{/gist_id}","starred_url":"https://api.github.com/users/evsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evsh/subscriptions","organizations_url":"https://api.github.com/users/evsh/orgs","repos_url":"https://api.github.com/users/evsh/repos","events_url":"https://api.github.com/users/evsh/events{/privacy}","received_events_url":"https://api.github.com/users/evsh/received_events","type":"User","site_admin":false},"body":"After discussion in the pull request #2717 here is the proposed implementation of the DBus notification events. These changes add action to the popup for the downloaded torrents (via hyper link or button) to open finished torrent, specify urgency level for critical messages. The missing part from #2717 is user configurable notifications via Plasma settings.\r\n\r\nAnd there is no Plasma colours for the torrents list here, just notifications.\r\n\r\nIt might have sense to add an action to \"search finished\" notification to activate the search panel.\r\n","created_at":"2015-09-17T16:20:37Z","updated_at":"2015-10-24T17:21:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44495b2a82012d708ee19609cc34932d895d587b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/3810/commits","review_comments_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/3810/comments","review_comment_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/3810/comments","statuses_url":"https://api.github.com/repos/qbittorrent/qBittorrent/statuses/38146ad0808ccda81122e8d44260c14cbea76e95","head":{"label":"evsh:notifications","ref":"notifications","sha":"38146ad0808ccda81122e8d44260c14cbea76e95","user":{"login":"evsh","id":394621,"avatar_url":"https://avatars.githubusercontent.com/u/394621?v=3","gravatar_id":"","url":"https://api.github.com/users/evsh","html_url":"https://github.com/evsh","followers_url":"https://api.github.com/users/evsh/followers","following_url":"https://api.github.com/users/evsh/following{/other_user}","gists_url":"https://api.github.com/users/evsh/gists{/gist_id}","starred_url":"https://api.github.com/users/evsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evsh/subscriptions","organizations_url":"https://api.github.com/users/evsh/orgs","repos_url":"https://api.github.com/users/evsh/repos","events_url":"https://api.github.com/users/evsh/events{/privacy}","received_events_url":"https://api.github.com/users/evsh/received_events","type":"User","site_admin":false},"repo":{"id":31520234,"name":"qBittorrent","full_name":"evsh/qBittorrent","owner":{"login":"evsh","id":394621,"avatar_url":"https://avatars.githubusercontent.com/u/394621?v=3","gravatar_id":"","url":"https://api.github.com/users/evsh","html_url":"https://github.com/evsh","followers_url":"https://api.github.com/users/evsh/followers","following_url":"https://api.github.com/users/evsh/following{/other_user}","gists_url":"https://api.github.com/users/evsh/gists{/gist_id}","starred_url":"https://api.github.com/users/evsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evsh/subscriptions","organizations_url":"https://api.github.com/users/evsh/orgs","repos_url":"https://api.github.com/users/evsh/repos","events_url":"https://api.github.com/users/evsh/events{/privacy}","received_events_url":"https://api.github.com/users/evsh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/evsh/qBittorrent","description":"qBittorrent BitTorrent client","fork":true,"url":"https://api.github.com/repos/evsh/qBittorrent","forks_url":"https://api.github.com/repos/evsh/qBittorrent/forks","keys_url":"https://api.github.com/repos/evsh/qBittorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evsh/qBittorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evsh/qBittorrent/teams","hooks_url":"https://api.github.com/repos/evsh/qBittorrent/hooks","issue_events_url":"https://api.github.com/repos/evsh/qBittorrent/issues/events{/number}","events_url":"https://api.github.com/repos/evsh/qBittorrent/events","assignees_url":"https://api.github.com/repos/evsh/qBittorrent/assignees{/user}","branches_url":"https://api.github.com/repos/evsh/qBittorrent/branches{/branch}","tags_url":"https://api.github.com/repos/evsh/qBittorrent/tags","blobs_url":"https://api.github.com/repos/evsh/qBittorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evsh/qBittorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evsh/qBittorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/evsh/qBittorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evsh/qBittorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/evsh/qBittorrent/languages","stargazers_url":"https://api.github.com/repos/evsh/qBittorrent/stargazers","contributors_url":"https://api.github.com/repos/evsh/qBittorrent/contributors","subscribers_url":"https://api.github.com/repos/evsh/qBittorrent/subscribers","subscription_url":"https://api.github.com/repos/evsh/qBittorrent/subscription","commits_url":"https://api.github.com/repos/evsh/qBittorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/evsh/qBittorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/evsh/qBittorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/evsh/qBittorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/evsh/qBittorrent/contents/{+path}","compare_url":"https://api.github.com/repos/evsh/qBittorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evsh/qBittorrent/merges","archive_url":"https://api.github.com/repos/evsh/qBittorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evsh/qBittorrent/downloads","issues_url":"https://api.github.com/repos/evsh/qBittorrent/issues{/number}","pulls_url":"https://api.github.com/repos/evsh/qBittorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/evsh/qBittorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/evsh/qBittorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evsh/qBittorrent/labels{/name}","releases_url":"https://api.github.com/repos/evsh/qBittorrent/releases{/id}","created_at":"2015-03-02T02:38:49Z","updated_at":"2015-09-18T17:49:23Z","pushed_at":"2015-10-21T15:16:55Z","git_url":"git://github.com/evsh/qBittorrent.git","ssh_url":"git@github.com:evsh/qBittorrent.git","clone_url":"https://github.com/evsh/qBittorrent.git","svn_url":"https://github.com/evsh/qBittorrent","homepage":"http://www.qbittorrent.org","size":109092,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qbittorrent:master","ref":"master","sha":"4a271d358fff6a55316bbb915c02d84024990934","user":{"login":"qbittorrent","id":2131270,"avatar_url":"https://avatars.githubusercontent.com/u/2131270?v=3","gravatar_id":"","url":"https://api.github.com/users/qbittorrent","html_url":"https://github.com/qbittorrent","followers_url":"https://api.github.com/users/qbittorrent/followers","following_url":"https://api.github.com/users/qbittorrent/following{/other_user}","gists_url":"https://api.github.com/users/qbittorrent/gists{/gist_id}","starred_url":"https://api.github.com/users/qbittorrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qbittorrent/subscriptions","organizations_url":"https://api.github.com/users/qbittorrent/orgs","repos_url":"https://api.github.com/users/qbittorrent/repos","events_url":"https://api.github.com/users/qbittorrent/events{/privacy}","received_events_url":"https://api.github.com/users/qbittorrent/received_events","type":"Organization","site_admin":false},"repo":{"id":3351871,"name":"qBittorrent","full_name":"qbittorrent/qBittorrent","owner":{"login":"qbittorrent","id":2131270,"avatar_url":"https://avatars.githubusercontent.com/u/2131270?v=3","gravatar_id":"","url":"https://api.github.com/users/qbittorrent","html_url":"https://github.com/qbittorrent","followers_url":"https://api.github.com/users/qbittorrent/followers","following_url":"https://api.github.com/users/qbittorrent/following{/other_user}","gists_url":"https://api.github.com/users/qbittorrent/gists{/gist_id}","starred_url":"https://api.github.com/users/qbittorrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qbittorrent/subscriptions","organizations_url":"https://api.github.com/users/qbittorrent/orgs","repos_url":"https://api.github.com/users/qbittorrent/repos","events_url":"https://api.github.com/users/qbittorrent/events{/privacy}","received_events_url":"https://api.github.com/users/qbittorrent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qbittorrent/qBittorrent","description":"qBittorrent BitTorrent client","fork":false,"url":"https://api.github.com/repos/qbittorrent/qBittorrent","forks_url":"https://api.github.com/repos/qbittorrent/qBittorrent/forks","keys_url":"https://api.github.com/repos/qbittorrent/qBittorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qbittorrent/qBittorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qbittorrent/qBittorrent/teams","hooks_url":"https://api.github.com/repos/qbittorrent/qBittorrent/hooks","issue_events_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/events{/number}","events_url":"https://api.github.com/repos/qbittorrent/qBittorrent/events","assignees_url":"https://api.github.com/repos/qbittorrent/qBittorrent/assignees{/user}","branches_url":"https://api.github.com/repos/qbittorrent/qBittorrent/branches{/branch}","tags_url":"https://api.github.com/repos/qbittorrent/qBittorrent/tags","blobs_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qbittorrent/qBittorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/qbittorrent/qBittorrent/languages","stargazers_url":"https://api.github.com/repos/qbittorrent/qBittorrent/stargazers","contributors_url":"https://api.github.com/repos/qbittorrent/qBittorrent/contributors","subscribers_url":"https://api.github.com/repos/qbittorrent/qBittorrent/subscribers","subscription_url":"https://api.github.com/repos/qbittorrent/qBittorrent/subscription","commits_url":"https://api.github.com/repos/qbittorrent/qBittorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/qbittorrent/qBittorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/qbittorrent/qBittorrent/contents/{+path}","compare_url":"https://api.github.com/repos/qbittorrent/qBittorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qbittorrent/qBittorrent/merges","archive_url":"https://api.github.com/repos/qbittorrent/qBittorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qbittorrent/qBittorrent/downloads","issues_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues{/number}","pulls_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/qbittorrent/qBittorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/qbittorrent/qBittorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qbittorrent/qBittorrent/labels{/name}","releases_url":"https://api.github.com/repos/qbittorrent/qBittorrent/releases{/id}","created_at":"2012-02-04T09:37:46Z","updated_at":"2015-10-23T22:14:42Z","pushed_at":"2015-10-24T13:03:08Z","git_url":"git://github.com/qbittorrent/qBittorrent.git","ssh_url":"git@github.com:qbittorrent/qBittorrent.git","clone_url":"https://github.com/qbittorrent/qBittorrent.git","svn_url":"https://github.com/qbittorrent/qBittorrent","homepage":"http://www.qbittorrent.org","size":129321,"stargazers_count":1246,"watchers_count":1246,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":363,"mirror_url":null,"open_issues_count":1140,"forks":363,"open_issues":1140,"watchers":1246,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/3810"},"html":{"href":"https://github.com/qbittorrent/qBittorrent/pull/3810"},"issue":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/3810"},"comments":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/3810/comments"},"review_comments":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/3810/comments"},"review_comment":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/3810/commits"},"statuses":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/statuses/38146ad0808ccda81122e8d44260c14cbea76e95"}}}}