{"action":"created","comment":{"url":"https://api.github.com/repos/atom/electron/pulls/comments/30817506","id":30817506,"diff_hunk":"@@ -54,6 +54,7 @@ void CrashReporterWin::InitBreakpad(const std::string& product_name,\n   if (waiting_event != INVALID_HANDLE_VALUE)\n     WaitForSingleObject(waiting_event, 1000);\n \n+  breakpad_.reset(nullptr);","path":"atom/common/crash_reporter/crash_reporter_win.cc","position":null,"original_position":4,"commit_id":"9a768dd4f0f55149d8dbcbb191d559c42dfbc646","original_commit_id":"dcbc6a127bb97e97a0cc63e16d4f6de01f558230","user":{"login":"adill","id":144914,"avatar_url":"https://avatars.githubusercontent.com/u/144914?v=3","gravatar_id":"","url":"https://api.github.com/users/adill","html_url":"https://github.com/adill","followers_url":"https://api.github.com/users/adill/followers","following_url":"https://api.github.com/users/adill/following{/other_user}","gists_url":"https://api.github.com/users/adill/gists{/gist_id}","starred_url":"https://api.github.com/users/adill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adill/subscriptions","organizations_url":"https://api.github.com/users/adill/orgs","repos_url":"https://api.github.com/users/adill/repos","events_url":"https://api.github.com/users/adill/events{/privacy}","received_events_url":"https://api.github.com/users/adill/received_events","type":"User","site_admin":false},"body":"Thanks for the feedback. I removed the explicit `nullptr` and added a comment.","created_at":"2015-05-21T16:03:40Z","updated_at":"2015-05-21T16:03:40Z","html_url":"https://github.com/atom/electron/pull/1706#discussion_r30817506","pull_request_url":"https://api.github.com/repos/atom/electron/pulls/1706","_links":{"self":{"href":"https://api.github.com/repos/atom/electron/pulls/comments/30817506"},"html":{"href":"https://github.com/atom/electron/pull/1706#discussion_r30817506"},"pull_request":{"href":"https://api.github.com/repos/atom/electron/pulls/1706"}}},"pull_request":{"url":"https://api.github.com/repos/atom/electron/pulls/1706","id":35566528,"html_url":"https://github.com/atom/electron/pull/1706","diff_url":"https://github.com/atom/electron/pull/1706.diff","patch_url":"https://github.com/atom/electron/pull/1706.patch","issue_url":"https://api.github.com/repos/atom/electron/issues/1706","number":1706,"state":"open","locked":false,"title":"Explicitly null the crash reporter before assigning it","user":{"login":"adill","id":144914,"avatar_url":"https://avatars.githubusercontent.com/u/144914?v=3","gravatar_id":"","url":"https://api.github.com/users/adill","html_url":"https://github.com/adill","followers_url":"https://api.github.com/users/adill/followers","following_url":"https://api.github.com/users/adill/following{/other_user}","gists_url":"https://api.github.com/users/adill/gists{/gist_id}","starred_url":"https://api.github.com/users/adill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adill/subscriptions","organizations_url":"https://api.github.com/users/adill/orgs","repos_url":"https://api.github.com/users/adill/repos","events_url":"https://api.github.com/users/adill/events{/privacy}","received_events_url":"https://api.github.com/users/adill/received_events","type":"User","site_admin":false},"body":"In my app I call CrashReporter start() multiple times (when I need to update the metadata) -- but this doesn't work out of the box -- crashes fail to report.\r\n\r\nThis change explicitly nulls the existing breakpad EH before allocating a new one to make sure we're cleaning out the old EH before installing the new one.","created_at":"2015-05-16T06:23:09Z","updated_at":"2015-05-21T16:03:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3eaee6c2c99ef96613e81069b0b42614dfe5ef5d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/atom/electron/pulls/1706/commits","review_comments_url":"https://api.github.com/repos/atom/electron/pulls/1706/comments","review_comment_url":"https://api.github.com/repos/atom/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atom/electron/issues/1706/comments","statuses_url":"https://api.github.com/repos/atom/electron/statuses/9a768dd4f0f55149d8dbcbb191d559c42dfbc646","head":{"label":"hammerandchisel:crash-reporter-reinit","ref":"crash-reporter-reinit","sha":"9a768dd4f0f55149d8dbcbb191d559c42dfbc646","user":{"login":"hammerandchisel","id":1965106,"avatar_url":"https://avatars.githubusercontent.com/u/1965106?v=3","gravatar_id":"","url":"https://api.github.com/users/hammerandchisel","html_url":"https://github.com/hammerandchisel","followers_url":"https://api.github.com/users/hammerandchisel/followers","following_url":"https://api.github.com/users/hammerandchisel/following{/other_user}","gists_url":"https://api.github.com/users/hammerandchisel/gists{/gist_id}","starred_url":"https://api.github.com/users/hammerandchisel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hammerandchisel/subscriptions","organizations_url":"https://api.github.com/users/hammerandchisel/orgs","repos_url":"https://api.github.com/users/hammerandchisel/repos","events_url":"https://api.github.com/users/hammerandchisel/events{/privacy}","received_events_url":"https://api.github.com/users/hammerandchisel/received_events","type":"Organization","site_admin":false},"repo":{"id":35711102,"name":"electron","full_name":"hammerandchisel/electron","owner":{"login":"hammerandchisel","id":1965106,"avatar_url":"https://avatars.githubusercontent.com/u/1965106?v=3","gravatar_id":"","url":"https://api.github.com/users/hammerandchisel","html_url":"https://github.com/hammerandchisel","followers_url":"https://api.github.com/users/hammerandchisel/followers","following_url":"https://api.github.com/users/hammerandchisel/following{/other_user}","gists_url":"https://api.github.com/users/hammerandchisel/gists{/gist_id}","starred_url":"https://api.github.com/users/hammerandchisel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hammerandchisel/subscriptions","organizations_url":"https://api.github.com/users/hammerandchisel/orgs","repos_url":"https://api.github.com/users/hammerandchisel/repos","events_url":"https://api.github.com/users/hammerandchisel/events{/privacy}","received_events_url":"https://api.github.com/users/hammerandchisel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hammerandchisel/electron","description":"Build cross platform desktop apps with web technologies","fork":true,"url":"https://api.github.com/repos/hammerandchisel/electron","forks_url":"https://api.github.com/repos/hammerandchisel/electron/forks","keys_url":"https://api.github.com/repos/hammerandchisel/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hammerandchisel/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hammerandchisel/electron/teams","hooks_url":"https://api.github.com/repos/hammerandchisel/electron/hooks","issue_events_url":"https://api.github.com/repos/hammerandchisel/electron/issues/events{/number}","events_url":"https://api.github.com/repos/hammerandchisel/electron/events","assignees_url":"https://api.github.com/repos/hammerandchisel/electron/assignees{/user}","branches_url":"https://api.github.com/repos/hammerandchisel/electron/branches{/branch}","tags_url":"https://api.github.com/repos/hammerandchisel/electron/tags","blobs_url":"https://api.github.com/repos/hammerandchisel/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hammerandchisel/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hammerandchisel/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/hammerandchisel/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hammerandchisel/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/hammerandchisel/electron/languages","stargazers_url":"https://api.github.com/repos/hammerandchisel/electron/stargazers","contributors_url":"https://api.github.com/repos/hammerandchisel/electron/contributors","subscribers_url":"https://api.github.com/repos/hammerandchisel/electron/subscribers","subscription_url":"https://api.github.com/repos/hammerandchisel/electron/subscription","commits_url":"https://api.github.com/repos/hammerandchisel/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/hammerandchisel/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/hammerandchisel/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/hammerandchisel/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/hammerandchisel/electron/contents/{+path}","compare_url":"https://api.github.com/repos/hammerandchisel/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hammerandchisel/electron/merges","archive_url":"https://api.github.com/repos/hammerandchisel/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hammerandchisel/electron/downloads","issues_url":"https://api.github.com/repos/hammerandchisel/electron/issues{/number}","pulls_url":"https://api.github.com/repos/hammerandchisel/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/hammerandchisel/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/hammerandchisel/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hammerandchisel/electron/labels{/name}","releases_url":"https://api.github.com/repos/hammerandchisel/electron/releases{/id}","created_at":"2015-05-16T05:22:41Z","updated_at":"2015-05-16T05:22:43Z","pushed_at":"2015-05-21T16:03:02Z","git_url":"git://github.com/hammerandchisel/electron.git","ssh_url":"git@github.com:hammerandchisel/electron.git","clone_url":"https://github.com/hammerandchisel/electron.git","svn_url":"https://github.com/hammerandchisel/electron","homepage":"http://electron.atom.io","size":8220,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"b4403fa9ec387512136551cd57e138c18cd4cbf0","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"name":"electron","full_name":"atom/electron","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/electron","description":"Build cross platform desktop apps with web technologies","fork":false,"url":"https://api.github.com/repos/atom/electron","forks_url":"https://api.github.com/repos/atom/electron/forks","keys_url":"https://api.github.com/repos/atom/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/electron/teams","hooks_url":"https://api.github.com/repos/atom/electron/hooks","issue_events_url":"https://api.github.com/repos/atom/electron/issues/events{/number}","events_url":"https://api.github.com/repos/atom/electron/events","assignees_url":"https://api.github.com/repos/atom/electron/assignees{/user}","branches_url":"https://api.github.com/repos/atom/electron/branches{/branch}","tags_url":"https://api.github.com/repos/atom/electron/tags","blobs_url":"https://api.github.com/repos/atom/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/electron/languages","stargazers_url":"https://api.github.com/repos/atom/electron/stargazers","contributors_url":"https://api.github.com/repos/atom/electron/contributors","subscribers_url":"https://api.github.com/repos/atom/electron/subscribers","subscription_url":"https://api.github.com/repos/atom/electron/subscription","commits_url":"https://api.github.com/repos/atom/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/electron/contents/{+path}","compare_url":"https://api.github.com/repos/atom/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/electron/merges","archive_url":"https://api.github.com/repos/atom/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/electron/downloads","issues_url":"https://api.github.com/repos/atom/electron/issues{/number}","pulls_url":"https://api.github.com/repos/atom/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/electron/labels{/name}","releases_url":"https://api.github.com/repos/atom/electron/releases{/id}","created_at":"2013-04-12T01:47:36Z","updated_at":"2015-05-21T15:51:28Z","pushed_at":"2015-05-21T16:03:05Z","git_url":"git://github.com/atom/electron.git","ssh_url":"git@github.com:atom/electron.git","clone_url":"https://github.com/atom/electron.git","svn_url":"https://github.com/atom/electron","homepage":"http://electron.atom.io","size":23184,"stargazers_count":11524,"watchers_count":11524,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":821,"mirror_url":null,"open_issues_count":175,"forks":821,"open_issues":175,"watchers":11524,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/electron/pulls/1706"},"html":{"href":"https://github.com/atom/electron/pull/1706"},"issue":{"href":"https://api.github.com/repos/atom/electron/issues/1706"},"comments":{"href":"https://api.github.com/repos/atom/electron/issues/1706/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/electron/pulls/1706/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atom/electron/pulls/1706/commits"},"statuses":{"href":"https://api.github.com/repos/atom/electron/statuses/9a768dd4f0f55149d8dbcbb191d559c42dfbc646"}}}}