{"action":"created","comment":{"url":"https://api.github.com/repos/leapcode/soledad/pulls/comments/40931349","id":40931349,"diff_hunk":"@@ -59,9 +59,12 @@\n from u1db.remote.server_state import ServerState\n \n \n-from leap.soledad.common import ddocs, errors\n+from leap.soledad.common import ddocs\n+from leap.soledad.common.errors import raise_server_error","path":"common/src/leap/soledad/common/couch.py","position":22,"original_position":22,"commit_id":"947fc92a9887c630f5006fe54b7302851472f661","original_commit_id":"947fc92a9887c630f5006fe54b7302851472f661","user":{"login":"kalikaneko","id":3072993,"avatar_url":"https://avatars.githubusercontent.com/u/3072993?v=3","gravatar_id":"","url":"https://api.github.com/users/kalikaneko","html_url":"https://github.com/kalikaneko","followers_url":"https://api.github.com/users/kalikaneko/followers","following_url":"https://api.github.com/users/kalikaneko/following{/other_user}","gists_url":"https://api.github.com/users/kalikaneko/gists{/gist_id}","starred_url":"https://api.github.com/users/kalikaneko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalikaneko/subscriptions","organizations_url":"https://api.github.com/users/kalikaneko/orgs","repos_url":"https://api.github.com/users/kalikaneko/repos","events_url":"https://api.github.com/users/kalikaneko/events{/privacy}","received_events_url":"https://api.github.com/users/kalikaneko/received_events","type":"User","site_admin":false},"body":"same as the other comment: this is couch specific, so maybe move to common.couch.errrors ","created_at":"2015-10-01T16:01:46Z","updated_at":"2015-10-01T16:01:46Z","html_url":"https://github.com/leapcode/soledad/pull/281#discussion_r40931349","pull_request_url":"https://api.github.com/repos/leapcode/soledad/pulls/281","_links":{"self":{"href":"https://api.github.com/repos/leapcode/soledad/pulls/comments/40931349"},"html":{"href":"https://github.com/leapcode/soledad/pull/281#discussion_r40931349"},"pull_request":{"href":"https://api.github.com/repos/leapcode/soledad/pulls/281"}}},"pull_request":{"url":"https://api.github.com/repos/leapcode/soledad/pulls/281","id":46452357,"html_url":"https://github.com/leapcode/soledad/pull/281","diff_url":"https://github.com/leapcode/soledad/pull/281.diff","patch_url":"https://github.com/leapcode/soledad/pull/281.patch","issue_url":"https://api.github.com/repos/leapcode/soledad/issues/281","number":281,"state":"open","locked":false,"title":"Refactor/isolated couchdb code","user":{"login":"shyba","id":1302078,"avatar_url":"https://avatars.githubusercontent.com/u/1302078?v=3","gravatar_id":"","url":"https://api.github.com/users/shyba","html_url":"https://github.com/shyba","followers_url":"https://api.github.com/users/shyba/followers","following_url":"https://api.github.com/users/shyba/following{/other_user}","gists_url":"https://api.github.com/users/shyba/gists{/gist_id}","starred_url":"https://api.github.com/users/shyba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shyba/subscriptions","organizations_url":"https://api.github.com/users/shyba/orgs","repos_url":"https://api.github.com/users/shyba/repos","events_url":"https://api.github.com/users/shyba/events{/privacy}","received_events_url":"https://api.github.com/users/shyba/received_events","type":"User","site_admin":false},"body":"WIP\r\nGoals:\r\nMake all couchdb calls in a single place, isolating it from other backend code.\r\n\r\nNongoal:\r\nMove modules to right place, mocking for tests and other possible changes after this isolation. IMHO, those modifications should occur as needed after isolating couch code.","created_at":"2015-09-30T20:30:52Z","updated_at":"2015-10-01T16:01:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f669813fed5427ce7179ec8f7a6584bc983a5fe1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/leapcode/soledad/pulls/281/commits","review_comments_url":"https://api.github.com/repos/leapcode/soledad/pulls/281/comments","review_comment_url":"https://api.github.com/repos/leapcode/soledad/pulls/comments{/number}","comments_url":"https://api.github.com/repos/leapcode/soledad/issues/281/comments","statuses_url":"https://api.github.com/repos/leapcode/soledad/statuses/947fc92a9887c630f5006fe54b7302851472f661","head":{"label":"pixelated:refactor/isolated_couchdb_code","ref":"refactor/isolated_couchdb_code","sha":"947fc92a9887c630f5006fe54b7302851472f661","user":{"login":"pixelated","id":8321323,"avatar_url":"https://avatars.githubusercontent.com/u/8321323?v=3","gravatar_id":"","url":"https://api.github.com/users/pixelated","html_url":"https://github.com/pixelated","followers_url":"https://api.github.com/users/pixelated/followers","following_url":"https://api.github.com/users/pixelated/following{/other_user}","gists_url":"https://api.github.com/users/pixelated/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelated/subscriptions","organizations_url":"https://api.github.com/users/pixelated/orgs","repos_url":"https://api.github.com/users/pixelated/repos","events_url":"https://api.github.com/users/pixelated/events{/privacy}","received_events_url":"https://api.github.com/users/pixelated/received_events","type":"Organization","site_admin":false},"repo":{"id":39564686,"name":"soledad","full_name":"pixelated/soledad","owner":{"login":"pixelated","id":8321323,"avatar_url":"https://avatars.githubusercontent.com/u/8321323?v=3","gravatar_id":"","url":"https://api.github.com/users/pixelated","html_url":"https://github.com/pixelated","followers_url":"https://api.github.com/users/pixelated/followers","following_url":"https://api.github.com/users/pixelated/following{/other_user}","gists_url":"https://api.github.com/users/pixelated/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelated/subscriptions","organizations_url":"https://api.github.com/users/pixelated/orgs","repos_url":"https://api.github.com/users/pixelated/repos","events_url":"https://api.github.com/users/pixelated/events{/privacy}","received_events_url":"https://api.github.com/users/pixelated/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pixelated/soledad","description":"Synchronization Of Locally Encrypted Data Among Devices","fork":true,"url":"https://api.github.com/repos/pixelated/soledad","forks_url":"https://api.github.com/repos/pixelated/soledad/forks","keys_url":"https://api.github.com/repos/pixelated/soledad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pixelated/soledad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pixelated/soledad/teams","hooks_url":"https://api.github.com/repos/pixelated/soledad/hooks","issue_events_url":"https://api.github.com/repos/pixelated/soledad/issues/events{/number}","events_url":"https://api.github.com/repos/pixelated/soledad/events","assignees_url":"https://api.github.com/repos/pixelated/soledad/assignees{/user}","branches_url":"https://api.github.com/repos/pixelated/soledad/branches{/branch}","tags_url":"https://api.github.com/repos/pixelated/soledad/tags","blobs_url":"https://api.github.com/repos/pixelated/soledad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pixelated/soledad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pixelated/soledad/git/refs{/sha}","trees_url":"https://api.github.com/repos/pixelated/soledad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pixelated/soledad/statuses/{sha}","languages_url":"https://api.github.com/repos/pixelated/soledad/languages","stargazers_url":"https://api.github.com/repos/pixelated/soledad/stargazers","contributors_url":"https://api.github.com/repos/pixelated/soledad/contributors","subscribers_url":"https://api.github.com/repos/pixelated/soledad/subscribers","subscription_url":"https://api.github.com/repos/pixelated/soledad/subscription","commits_url":"https://api.github.com/repos/pixelated/soledad/commits{/sha}","git_commits_url":"https://api.github.com/repos/pixelated/soledad/git/commits{/sha}","comments_url":"https://api.github.com/repos/pixelated/soledad/comments{/number}","issue_comment_url":"https://api.github.com/repos/pixelated/soledad/issues/comments{/number}","contents_url":"https://api.github.com/repos/pixelated/soledad/contents/{+path}","compare_url":"https://api.github.com/repos/pixelated/soledad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pixelated/soledad/merges","archive_url":"https://api.github.com/repos/pixelated/soledad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pixelated/soledad/downloads","issues_url":"https://api.github.com/repos/pixelated/soledad/issues{/number}","pulls_url":"https://api.github.com/repos/pixelated/soledad/pulls{/number}","milestones_url":"https://api.github.com/repos/pixelated/soledad/milestones{/number}","notifications_url":"https://api.github.com/repos/pixelated/soledad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pixelated/soledad/labels{/name}","releases_url":"https://api.github.com/repos/pixelated/soledad/releases{/id}","created_at":"2015-07-23T11:55:37Z","updated_at":"2015-09-26T02:40:19Z","pushed_at":"2015-10-01T13:59:06Z","git_url":"git://github.com/pixelated/soledad.git","ssh_url":"git@github.com:pixelated/soledad.git","clone_url":"https://github.com/pixelated/soledad.git","svn_url":"https://github.com/pixelated/soledad","homepage":"https://leap.se/en/docs/soledad","size":3118,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"leapcode:develop","ref":"develop","sha":"4de93f472ac224ef32beffa1acd1c98765519160","user":{"login":"leapcode","id":1700464,"avatar_url":"https://avatars.githubusercontent.com/u/1700464?v=3","gravatar_id":"","url":"https://api.github.com/users/leapcode","html_url":"https://github.com/leapcode","followers_url":"https://api.github.com/users/leapcode/followers","following_url":"https://api.github.com/users/leapcode/following{/other_user}","gists_url":"https://api.github.com/users/leapcode/gists{/gist_id}","starred_url":"https://api.github.com/users/leapcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leapcode/subscriptions","organizations_url":"https://api.github.com/users/leapcode/orgs","repos_url":"https://api.github.com/users/leapcode/repos","events_url":"https://api.github.com/users/leapcode/events{/privacy}","received_events_url":"https://api.github.com/users/leapcode/received_events","type":"Organization","site_admin":false},"repo":{"id":9917542,"name":"soledad","full_name":"leapcode/soledad","owner":{"login":"leapcode","id":1700464,"avatar_url":"https://avatars.githubusercontent.com/u/1700464?v=3","gravatar_id":"","url":"https://api.github.com/users/leapcode","html_url":"https://github.com/leapcode","followers_url":"https://api.github.com/users/leapcode/followers","following_url":"https://api.github.com/users/leapcode/following{/other_user}","gists_url":"https://api.github.com/users/leapcode/gists{/gist_id}","starred_url":"https://api.github.com/users/leapcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leapcode/subscriptions","organizations_url":"https://api.github.com/users/leapcode/orgs","repos_url":"https://api.github.com/users/leapcode/repos","events_url":"https://api.github.com/users/leapcode/events{/privacy}","received_events_url":"https://api.github.com/users/leapcode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/leapcode/soledad","description":"Synchronization Of Locally Encrypted Data Among Devices","fork":false,"url":"https://api.github.com/repos/leapcode/soledad","forks_url":"https://api.github.com/repos/leapcode/soledad/forks","keys_url":"https://api.github.com/repos/leapcode/soledad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leapcode/soledad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leapcode/soledad/teams","hooks_url":"https://api.github.com/repos/leapcode/soledad/hooks","issue_events_url":"https://api.github.com/repos/leapcode/soledad/issues/events{/number}","events_url":"https://api.github.com/repos/leapcode/soledad/events","assignees_url":"https://api.github.com/repos/leapcode/soledad/assignees{/user}","branches_url":"https://api.github.com/repos/leapcode/soledad/branches{/branch}","tags_url":"https://api.github.com/repos/leapcode/soledad/tags","blobs_url":"https://api.github.com/repos/leapcode/soledad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leapcode/soledad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leapcode/soledad/git/refs{/sha}","trees_url":"https://api.github.com/repos/leapcode/soledad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leapcode/soledad/statuses/{sha}","languages_url":"https://api.github.com/repos/leapcode/soledad/languages","stargazers_url":"https://api.github.com/repos/leapcode/soledad/stargazers","contributors_url":"https://api.github.com/repos/leapcode/soledad/contributors","subscribers_url":"https://api.github.com/repos/leapcode/soledad/subscribers","subscription_url":"https://api.github.com/repos/leapcode/soledad/subscription","commits_url":"https://api.github.com/repos/leapcode/soledad/commits{/sha}","git_commits_url":"https://api.github.com/repos/leapcode/soledad/git/commits{/sha}","comments_url":"https://api.github.com/repos/leapcode/soledad/comments{/number}","issue_comment_url":"https://api.github.com/repos/leapcode/soledad/issues/comments{/number}","contents_url":"https://api.github.com/repos/leapcode/soledad/contents/{+path}","compare_url":"https://api.github.com/repos/leapcode/soledad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leapcode/soledad/merges","archive_url":"https://api.github.com/repos/leapcode/soledad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leapcode/soledad/downloads","issues_url":"https://api.github.com/repos/leapcode/soledad/issues{/number}","pulls_url":"https://api.github.com/repos/leapcode/soledad/pulls{/number}","milestones_url":"https://api.github.com/repos/leapcode/soledad/milestones{/number}","notifications_url":"https://api.github.com/repos/leapcode/soledad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leapcode/soledad/labels{/name}","releases_url":"https://api.github.com/repos/leapcode/soledad/releases{/id}","created_at":"2013-05-07T17:30:44Z","updated_at":"2015-09-08T18:17:25Z","pushed_at":"2015-10-01T15:28:41Z","git_url":"git://github.com/leapcode/soledad.git","ssh_url":"git@github.com:leapcode/soledad.git","clone_url":"https://github.com/leapcode/soledad.git","svn_url":"https://github.com/leapcode/soledad","homepage":"https://leap.se/en/docs/design/soledad","size":5230,"stargazers_count":19,"watchers_count":19,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":2,"forks":20,"open_issues":2,"watchers":19,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/leapcode/soledad/pulls/281"},"html":{"href":"https://github.com/leapcode/soledad/pull/281"},"issue":{"href":"https://api.github.com/repos/leapcode/soledad/issues/281"},"comments":{"href":"https://api.github.com/repos/leapcode/soledad/issues/281/comments"},"review_comments":{"href":"https://api.github.com/repos/leapcode/soledad/pulls/281/comments"},"review_comment":{"href":"https://api.github.com/repos/leapcode/soledad/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/leapcode/soledad/pulls/281/commits"},"statuses":{"href":"https://api.github.com/repos/leapcode/soledad/statuses/947fc92a9887c630f5006fe54b7302851472f661"}}}}