{"action":"opened","number":22255,"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/22255","id":50350365,"html_url":"https://github.com/rails/rails/pull/22255","diff_url":"https://github.com/rails/rails/pull/22255.diff","patch_url":"https://github.com/rails/rails/pull/22255.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/22255","number":22255,"state":"open","locked":false,"title":"update docs for MessageEncryptor#new to recommend a KDF [ci skip]","user":{"login":"reaperhulk","id":161495,"avatar_url":"https://avatars.githubusercontent.com/u/161495?v=3","gravatar_id":"","url":"https://api.github.com/users/reaperhulk","html_url":"https://github.com/reaperhulk","followers_url":"https://api.github.com/users/reaperhulk/followers","following_url":"https://api.github.com/users/reaperhulk/following{/other_user}","gists_url":"https://api.github.com/users/reaperhulk/gists{/gist_id}","starred_url":"https://api.github.com/users/reaperhulk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaperhulk/subscriptions","organizations_url":"https://api.github.com/users/reaperhulk/orgs","repos_url":"https://api.github.com/users/reaperhulk/repos","events_url":"https://api.github.com/users/reaperhulk/events{/privacy}","received_events_url":"https://api.github.com/users/reaperhulk/received_events","type":"User","site_admin":false},"body":"The class docs for ActiveSupport::MessageEncryptor already demonstrate the use of ActiveSupport::KeyGenerator to derive a key from a user passphrase. This PR simply updates the initialize docs to avoid recommending an unsafe behavior.\r\n\r\nI marked this as CI skip as the contributor guide recommended for docs only PRs, but let me know if I've made any mistakes!","created_at":"2015-11-11T05:45:43Z","updated_at":"2015-11-11T05:45:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"647e58dd7dd459d43198e927d3c34eb4b735fa8a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/22255/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/22255/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/rails/issues/22255/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/4f51433831a64605f14e14a8250fa6c166161af2","head":{"label":"reaperhulk:key-derivation","ref":"key-derivation","sha":"4f51433831a64605f14e14a8250fa6c166161af2","user":{"login":"reaperhulk","id":161495,"avatar_url":"https://avatars.githubusercontent.com/u/161495?v=3","gravatar_id":"","url":"https://api.github.com/users/reaperhulk","html_url":"https://github.com/reaperhulk","followers_url":"https://api.github.com/users/reaperhulk/followers","following_url":"https://api.github.com/users/reaperhulk/following{/other_user}","gists_url":"https://api.github.com/users/reaperhulk/gists{/gist_id}","starred_url":"https://api.github.com/users/reaperhulk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaperhulk/subscriptions","organizations_url":"https://api.github.com/users/reaperhulk/orgs","repos_url":"https://api.github.com/users/reaperhulk/repos","events_url":"https://api.github.com/users/reaperhulk/events{/privacy}","received_events_url":"https://api.github.com/users/reaperhulk/received_events","type":"User","site_admin":false},"repo":{"id":45961255,"name":"rails","full_name":"reaperhulk/rails","owner":{"login":"reaperhulk","id":161495,"avatar_url":"https://avatars.githubusercontent.com/u/161495?v=3","gravatar_id":"","url":"https://api.github.com/users/reaperhulk","html_url":"https://github.com/reaperhulk","followers_url":"https://api.github.com/users/reaperhulk/followers","following_url":"https://api.github.com/users/reaperhulk/following{/other_user}","gists_url":"https://api.github.com/users/reaperhulk/gists{/gist_id}","starred_url":"https://api.github.com/users/reaperhulk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaperhulk/subscriptions","organizations_url":"https://api.github.com/users/reaperhulk/orgs","repos_url":"https://api.github.com/users/reaperhulk/repos","events_url":"https://api.github.com/users/reaperhulk/events{/privacy}","received_events_url":"https://api.github.com/users/reaperhulk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reaperhulk/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/reaperhulk/rails","forks_url":"https://api.github.com/repos/reaperhulk/rails/forks","keys_url":"https://api.github.com/repos/reaperhulk/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reaperhulk/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reaperhulk/rails/teams","hooks_url":"https://api.github.com/repos/reaperhulk/rails/hooks","issue_events_url":"https://api.github.com/repos/reaperhulk/rails/issues/events{/number}","events_url":"https://api.github.com/repos/reaperhulk/rails/events","assignees_url":"https://api.github.com/repos/reaperhulk/rails/assignees{/user}","branches_url":"https://api.github.com/repos/reaperhulk/rails/branches{/branch}","tags_url":"https://api.github.com/repos/reaperhulk/rails/tags","blobs_url":"https://api.github.com/repos/reaperhulk/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reaperhulk/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reaperhulk/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/reaperhulk/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reaperhulk/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/reaperhulk/rails/languages","stargazers_url":"https://api.github.com/repos/reaperhulk/rails/stargazers","contributors_url":"https://api.github.com/repos/reaperhulk/rails/contributors","subscribers_url":"https://api.github.com/repos/reaperhulk/rails/subscribers","subscription_url":"https://api.github.com/repos/reaperhulk/rails/subscription","commits_url":"https://api.github.com/repos/reaperhulk/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/reaperhulk/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/reaperhulk/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/reaperhulk/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/reaperhulk/rails/contents/{+path}","compare_url":"https://api.github.com/repos/reaperhulk/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reaperhulk/rails/merges","archive_url":"https://api.github.com/repos/reaperhulk/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reaperhulk/rails/downloads","issues_url":"https://api.github.com/repos/reaperhulk/rails/issues{/number}","pulls_url":"https://api.github.com/repos/reaperhulk/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/reaperhulk/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/reaperhulk/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reaperhulk/rails/labels{/name}","releases_url":"https://api.github.com/repos/reaperhulk/rails/releases{/id}","created_at":"2015-11-11T05:14:22Z","updated_at":"2015-11-11T05:14:57Z","pushed_at":"2015-11-11T05:43:22Z","git_url":"git://github.com/reaperhulk/rails.git","ssh_url":"git@github.com:reaperhulk/rails.git","clone_url":"https://github.com/reaperhulk/rails.git","svn_url":"https://github.com/reaperhulk/rails","homepage":"http://rubyonrails.org","size":618975,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"5388464af6ec229ddf3a1040cd7466f45370cedd","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","created_at":"2008-04-11T02:19:47Z","updated_at":"2015-11-11T04:50:08Z","pushed_at":"2015-11-11T05:45:43Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":618975,"stargazers_count":28341,"watchers_count":28341,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11454,"mirror_url":null,"open_issues_count":837,"forks":11454,"open_issues":837,"watchers":28341,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/22255"},"html":{"href":"https://github.com/rails/rails/pull/22255"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/22255"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/22255/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/22255/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/22255/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/4f51433831a64605f14e14a8250fa6c166161af2"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}