{"action":"created","comment":{"url":"https://api.github.com/repos/Polymer/core-image/pulls/comments/25527109","id":25527109,"diff_hunk":"@@ -61,24 +61,41 @@\n -->\n \n <link rel=\"import\" href=\"../polymer/polymer.html\">\n+<link rel=\"import\" href=\"../layout/layout.html\">\n+<dom-module id=\"core-image\">\n+  <style>\n+    core-image {\n+      display: inline-block;\n+      overflow: hidden;\n+      position: relative;\n+    }\n \n-<polymer-element name=\"core-image\">\n-<template>\n-  <link rel=\"stylesheet\" href=\"core-image.css\">\n-  <template if=\"{{!sizing}}\">\n-    <img id=\"img\">\n-  </template>\n-  <template if=\"{{preload && fade}}\">\n-    <div id=\"placeholder\" fit></div>\n+    core-image[sizing] #img {\n+      display: none;\n+    }\n+\n+    core-image #placeholder {\n+      background-color: inherit;\n+      opacity: 1;\n+    }\n+\n+    core-image #placeholder.faded-out {\n+      transition: opacity 0.5s linear;\n+      opacity: 0;\n+    }\n+  </style>\n+  <template>\n+    <img id=\"img\" role=\"none\" class$=\"{{imageClassName}}\">","path":"core-image.html","position":36,"original_position":36,"commit_id":"4dfbacb87d3364621a875ea74ebb856b15c6844a","original_commit_id":"4dfbacb87d3364621a875ea74ebb856b15c6844a","user":{"login":"cdata","id":240083,"avatar_url":"https://avatars.githubusercontent.com/u/240083?v=3","gravatar_id":"","url":"https://api.github.com/users/cdata","html_url":"https://github.com/cdata","followers_url":"https://api.github.com/users/cdata/followers","following_url":"https://api.github.com/users/cdata/following{/other_user}","gists_url":"https://api.github.com/users/cdata/gists{/gist_id}","starred_url":"https://api.github.com/users/cdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdata/subscriptions","organizations_url":"https://api.github.com/users/cdata/orgs","repos_url":"https://api.github.com/users/cdata/repos","events_url":"https://api.github.com/users/cdata/events{/privacy}","received_events_url":"https://api.github.com/users/cdata/received_events","type":"User","site_admin":false},"body":"Making them 1-way for now. After talking to them, the switch may or may not be happening immediately.","created_at":"2015-02-27T18:31:24Z","updated_at":"2015-02-27T18:31:24Z","html_url":"https://github.com/Polymer/core-image/pull/19#discussion_r25527109","pull_request_url":"https://api.github.com/repos/Polymer/core-image/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/Polymer/core-image/pulls/comments/25527109"},"html":{"href":"https://github.com/Polymer/core-image/pull/19#discussion_r25527109"},"pull_request":{"href":"https://api.github.com/repos/Polymer/core-image/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/Polymer/core-image/pulls/19","id":30047630,"html_url":"https://github.com/Polymer/core-image/pull/19","diff_url":"https://github.com/Polymer/core-image/pull/19.diff","patch_url":"https://github.com/Polymer/core-image/pull/19.patch","issue_url":"https://api.github.com/repos/Polymer/core-image/issues/19","number":19,"state":"open","locked":false,"title":"Feature parity with 0.5.","user":{"login":"cdata","id":240083,"avatar_url":"https://avatars.githubusercontent.com/u/240083?v=3","gravatar_id":"","url":"https://api.github.com/users/cdata","html_url":"https://github.com/cdata","followers_url":"https://api.github.com/users/cdata/followers","following_url":"https://api.github.com/users/cdata/following{/other_user}","gists_url":"https://api.github.com/users/cdata/gists{/gist_id}","starred_url":"https://api.github.com/users/cdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdata/subscriptions","organizations_url":"https://api.github.com/users/cdata/orgs","repos_url":"https://api.github.com/users/cdata/repos","events_url":"https://api.github.com/users/cdata/events{/privacy}","received_events_url":"https://api.github.com/users/cdata/received_events","type":"User","site_admin":false},"body":" - Changed `load` to inverse `preventLoad`\r\n - Departed from usage of `template[if]` to show and hide things\r\n - Thoroughly abused `computed` properties\r\n - Tweezed apart many overlapping concerns in `update`\r\n - Added some basic tests","created_at":"2015-02-26T03:15:06Z","updated_at":"2015-02-27T18:31:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"afeb03606f3411a756c5ba9f53ec445dd025997a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Polymer/core-image/pulls/19/commits","review_comments_url":"https://api.github.com/repos/Polymer/core-image/pulls/19/comments","review_comment_url":"https://api.github.com/repos/Polymer/core-image/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Polymer/core-image/issues/19/comments","statuses_url":"https://api.github.com/repos/Polymer/core-image/statuses/4dfbacb87d3364621a875ea74ebb856b15c6844a","head":{"label":"Polymer:0.8-initial-port","ref":"0.8-initial-port","sha":"4dfbacb87d3364621a875ea74ebb856b15c6844a","user":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":24661613,"name":"core-image","full_name":"Polymer/core-image","owner":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polymer/core-image","description":"A custom element that provides sizing and preloading options not found on the standard <img> tag.","fork":false,"url":"https://api.github.com/repos/Polymer/core-image","forks_url":"https://api.github.com/repos/Polymer/core-image/forks","keys_url":"https://api.github.com/repos/Polymer/core-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/core-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/core-image/teams","hooks_url":"https://api.github.com/repos/Polymer/core-image/hooks","issue_events_url":"https://api.github.com/repos/Polymer/core-image/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/core-image/events","assignees_url":"https://api.github.com/repos/Polymer/core-image/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/core-image/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/core-image/tags","blobs_url":"https://api.github.com/repos/Polymer/core-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/core-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/core-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/core-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/core-image/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/core-image/languages","stargazers_url":"https://api.github.com/repos/Polymer/core-image/stargazers","contributors_url":"https://api.github.com/repos/Polymer/core-image/contributors","subscribers_url":"https://api.github.com/repos/Polymer/core-image/subscribers","subscription_url":"https://api.github.com/repos/Polymer/core-image/subscription","commits_url":"https://api.github.com/repos/Polymer/core-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/core-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/core-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/core-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polymer/core-image/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/core-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/core-image/merges","archive_url":"https://api.github.com/repos/Polymer/core-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/core-image/downloads","issues_url":"https://api.github.com/repos/Polymer/core-image/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/core-image/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/core-image/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/core-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/core-image/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/core-image/releases{/id}","created_at":"2014-10-01T01:15:00Z","updated_at":"2015-02-25T18:32:46Z","pushed_at":"2015-02-26T03:02:49Z","git_url":"git://github.com/Polymer/core-image.git","ssh_url":"git@github.com:Polymer/core-image.git","clone_url":"https://github.com/Polymer/core-image.git","svn_url":"https://github.com/Polymer/core-image","homepage":"https://www.polymer-project.org/docs/elements/core-elements.html#core-image","size":355,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":11,"forks":2,"open_issues":11,"watchers":3,"default_branch":"master"}},"base":{"label":"Polymer:0.8-preview","ref":"0.8-preview","sha":"64f225817a07a0c43cf91bb879a4c1c8d7d356e8","user":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":24661613,"name":"core-image","full_name":"Polymer/core-image","owner":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polymer/core-image","description":"A custom element that provides sizing and preloading options not found on the standard <img> tag.","fork":false,"url":"https://api.github.com/repos/Polymer/core-image","forks_url":"https://api.github.com/repos/Polymer/core-image/forks","keys_url":"https://api.github.com/repos/Polymer/core-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/core-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/core-image/teams","hooks_url":"https://api.github.com/repos/Polymer/core-image/hooks","issue_events_url":"https://api.github.com/repos/Polymer/core-image/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/core-image/events","assignees_url":"https://api.github.com/repos/Polymer/core-image/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/core-image/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/core-image/tags","blobs_url":"https://api.github.com/repos/Polymer/core-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/core-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/core-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/core-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/core-image/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/core-image/languages","stargazers_url":"https://api.github.com/repos/Polymer/core-image/stargazers","contributors_url":"https://api.github.com/repos/Polymer/core-image/contributors","subscribers_url":"https://api.github.com/repos/Polymer/core-image/subscribers","subscription_url":"https://api.github.com/repos/Polymer/core-image/subscription","commits_url":"https://api.github.com/repos/Polymer/core-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/core-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/core-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/core-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polymer/core-image/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/core-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/core-image/merges","archive_url":"https://api.github.com/repos/Polymer/core-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/core-image/downloads","issues_url":"https://api.github.com/repos/Polymer/core-image/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/core-image/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/core-image/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/core-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/core-image/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/core-image/releases{/id}","created_at":"2014-10-01T01:15:00Z","updated_at":"2015-02-25T18:32:46Z","pushed_at":"2015-02-26T03:02:49Z","git_url":"git://github.com/Polymer/core-image.git","ssh_url":"git@github.com:Polymer/core-image.git","clone_url":"https://github.com/Polymer/core-image.git","svn_url":"https://github.com/Polymer/core-image","homepage":"https://www.polymer-project.org/docs/elements/core-elements.html#core-image","size":355,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":11,"forks":2,"open_issues":11,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Polymer/core-image/pulls/19"},"html":{"href":"https://github.com/Polymer/core-image/pull/19"},"issue":{"href":"https://api.github.com/repos/Polymer/core-image/issues/19"},"comments":{"href":"https://api.github.com/repos/Polymer/core-image/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/Polymer/core-image/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/Polymer/core-image/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Polymer/core-image/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/Polymer/core-image/statuses/4dfbacb87d3364621a875ea74ebb856b15c6844a"}}}}