{"action":"created","comment":{"url":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls/comments/32917926","id":32917926,"diff_hunk":"@@ -23,7 +25,9 @@\n         return seq(\n                 bind(CountryCode.class).qualifiedWith(\"default\").toInstance(defaultCountry(configuration)), // checks on start\n                 bind(PlayJavaSphereClient.class).toProvider(PlayJavaSphereClientProvider.class).in(Singleton.class),\n-                bind(CategoryTree.class).toProvider(CategoryTreeProvider.class)\n+                bind(CategoryTree.class).toProvider(CategoryTreeProvider.class),","path":"app/inject/ProductionModule.java","position":15,"original_position":15,"commit_id":"c7b728ea8795c3407c94e15e9876206b752d1606","original_commit_id":"c7b728ea8795c3407c94e15e9876206b752d1606","user":{"login":"schleichardt","id":1320833,"avatar_url":"https://avatars.githubusercontent.com/u/1320833?v=3","gravatar_id":"","url":"https://api.github.com/users/schleichardt","html_url":"https://github.com/schleichardt","followers_url":"https://api.github.com/users/schleichardt/followers","following_url":"https://api.github.com/users/schleichardt/following{/other_user}","gists_url":"https://api.github.com/users/schleichardt/gists{/gist_id}","starred_url":"https://api.github.com/users/schleichardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schleichardt/subscriptions","organizations_url":"https://api.github.com/users/schleichardt/orgs","repos_url":"https://api.github.com/users/schleichardt/repos","events_url":"https://api.github.com/users/schleichardt/events{/privacy}","received_events_url":"https://api.github.com/users/schleichardt/received_events","type":"User","site_admin":false},"body":"I think Providers are cool but there is the danger that you expect a singleton where it isn't. (at-Singleton on the provider reuses only the provider). Suppose you have multiple controllers, should everyone have its own copy of a CategoryTree, TemplateService and CmsService or should they share one instance?\r\n\r\n`bind(Hello.class).toProvider(HelloProvider.class).in(Singleton.class) //make singleton even if class have not the annotation` ","created_at":"2015-06-22T09:36:48Z","updated_at":"2015-06-22T09:36:48Z","html_url":"https://github.com/sphereio/sphere-sunrise/pull/99#discussion_r32917926","pull_request_url":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls/99","_links":{"self":{"href":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls/comments/32917926"},"html":{"href":"https://github.com/sphereio/sphere-sunrise/pull/99#discussion_r32917926"},"pull_request":{"href":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls/99"}}},"pull_request":{"url":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls/99","id":38104864,"html_url":"https://github.com/sphereio/sphere-sunrise/pull/99","diff_url":"https://github.com/sphereio/sphere-sunrise/pull/99.diff","patch_url":"https://github.com/sphereio/sphere-sunrise/pull/99.patch","issue_url":"https://api.github.com/repos/sphereio/sphere-sunrise/issues/99","number":99,"state":"open","locked":false,"title":"Cms service","user":{"login":"lauraluiz","id":1917621,"avatar_url":"https://avatars.githubusercontent.com/u/1917621?v=3","gravatar_id":"","url":"https://api.github.com/users/lauraluiz","html_url":"https://github.com/lauraluiz","followers_url":"https://api.github.com/users/lauraluiz/followers","following_url":"https://api.github.com/users/lauraluiz/following{/other_user}","gists_url":"https://api.github.com/users/lauraluiz/gists{/gist_id}","starred_url":"https://api.github.com/users/lauraluiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lauraluiz/subscriptions","organizations_url":"https://api.github.com/users/lauraluiz/orgs","repos_url":"https://api.github.com/users/lauraluiz/repos","events_url":"https://api.github.com/users/lauraluiz/events{/privacy}","received_events_url":"https://api.github.com/users/lauraluiz/received_events","type":"User","site_admin":false},"body":"@schleichardt @butenkor please review.\r\nSince the architecture is still under development, there are some dummy classes, please ignore them ;)\r\nFocus on the CmsService and the HandlebarsViewService, which is the main focus of this PR.","created_at":"2015-06-19T12:58:39Z","updated_at":"2015-06-22T09:36:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b27b0ecadbf3a3707e0780309fb2e6d17ec4e28d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls/99/commits","review_comments_url":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls/99/comments","review_comment_url":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sphereio/sphere-sunrise/issues/99/comments","statuses_url":"https://api.github.com/repos/sphereio/sphere-sunrise/statuses/c7b728ea8795c3407c94e15e9876206b752d1606","head":{"label":"sphereio:cms-service","ref":"cms-service","sha":"c7b728ea8795c3407c94e15e9876206b752d1606","user":{"login":"sphereio","id":4119130,"avatar_url":"https://avatars.githubusercontent.com/u/4119130?v=3","gravatar_id":"","url":"https://api.github.com/users/sphereio","html_url":"https://github.com/sphereio","followers_url":"https://api.github.com/users/sphereio/followers","following_url":"https://api.github.com/users/sphereio/following{/other_user}","gists_url":"https://api.github.com/users/sphereio/gists{/gist_id}","starred_url":"https://api.github.com/users/sphereio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphereio/subscriptions","organizations_url":"https://api.github.com/users/sphereio/orgs","repos_url":"https://api.github.com/users/sphereio/repos","events_url":"https://api.github.com/users/sphereio/events{/privacy}","received_events_url":"https://api.github.com/users/sphereio/received_events","type":"Organization","site_admin":false},"repo":{"id":20036001,"name":"sphere-sunrise","full_name":"sphereio/sphere-sunrise","owner":{"login":"sphereio","id":4119130,"avatar_url":"https://avatars.githubusercontent.com/u/4119130?v=3","gravatar_id":"","url":"https://api.github.com/users/sphereio","html_url":"https://github.com/sphereio","followers_url":"https://api.github.com/users/sphereio/followers","following_url":"https://api.github.com/users/sphereio/following{/other_user}","gists_url":"https://api.github.com/users/sphereio/gists{/gist_id}","starred_url":"https://api.github.com/users/sphereio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphereio/subscriptions","organizations_url":"https://api.github.com/users/sphereio/orgs","repos_url":"https://api.github.com/users/sphereio/repos","events_url":"https://api.github.com/users/sphereio/events{/privacy}","received_events_url":"https://api.github.com/users/sphereio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sphereio/sphere-sunrise","description":"The next generation SPHERE.IO demo shop template","fork":false,"url":"https://api.github.com/repos/sphereio/sphere-sunrise","forks_url":"https://api.github.com/repos/sphereio/sphere-sunrise/forks","keys_url":"https://api.github.com/repos/sphereio/sphere-sunrise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sphereio/sphere-sunrise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sphereio/sphere-sunrise/teams","hooks_url":"https://api.github.com/repos/sphereio/sphere-sunrise/hooks","issue_events_url":"https://api.github.com/repos/sphereio/sphere-sunrise/issues/events{/number}","events_url":"https://api.github.com/repos/sphereio/sphere-sunrise/events","assignees_url":"https://api.github.com/repos/sphereio/sphere-sunrise/assignees{/user}","branches_url":"https://api.github.com/repos/sphereio/sphere-sunrise/branches{/branch}","tags_url":"https://api.github.com/repos/sphereio/sphere-sunrise/tags","blobs_url":"https://api.github.com/repos/sphereio/sphere-sunrise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sphereio/sphere-sunrise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sphereio/sphere-sunrise/git/refs{/sha}","trees_url":"https://api.github.com/repos/sphereio/sphere-sunrise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sphereio/sphere-sunrise/statuses/{sha}","languages_url":"https://api.github.com/repos/sphereio/sphere-sunrise/languages","stargazers_url":"https://api.github.com/repos/sphereio/sphere-sunrise/stargazers","contributors_url":"https://api.github.com/repos/sphereio/sphere-sunrise/contributors","subscribers_url":"https://api.github.com/repos/sphereio/sphere-sunrise/subscribers","subscription_url":"https://api.github.com/repos/sphereio/sphere-sunrise/subscription","commits_url":"https://api.github.com/repos/sphereio/sphere-sunrise/commits{/sha}","git_commits_url":"https://api.github.com/repos/sphereio/sphere-sunrise/git/commits{/sha}","comments_url":"https://api.github.com/repos/sphereio/sphere-sunrise/comments{/number}","issue_comment_url":"https://api.github.com/repos/sphereio/sphere-sunrise/issues/comments{/number}","contents_url":"https://api.github.com/repos/sphereio/sphere-sunrise/contents/{+path}","compare_url":"https://api.github.com/repos/sphereio/sphere-sunrise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sphereio/sphere-sunrise/merges","archive_url":"https://api.github.com/repos/sphereio/sphere-sunrise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sphereio/sphere-sunrise/downloads","issues_url":"https://api.github.com/repos/sphereio/sphere-sunrise/issues{/number}","pulls_url":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls{/number}","milestones_url":"https://api.github.com/repos/sphereio/sphere-sunrise/milestones{/number}","notifications_url":"https://api.github.com/repos/sphereio/sphere-sunrise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sphereio/sphere-sunrise/labels{/name}","releases_url":"https://api.github.com/repos/sphereio/sphere-sunrise/releases{/id}","created_at":"2014-05-21T20:20:52Z","updated_at":"2015-04-26T16:17:40Z","pushed_at":"2015-06-22T08:59:33Z","git_url":"git://github.com/sphereio/sphere-sunrise.git","ssh_url":"git@github.com:sphereio/sphere-sunrise.git","clone_url":"https://github.com/sphereio/sphere-sunrise.git","svn_url":"https://github.com/sphereio/sphere-sunrise","homepage":"https://sunrise.sphere.io","size":4189,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":54,"forks":1,"open_issues":54,"watchers":5,"default_branch":"master"}},"base":{"label":"sphereio:master","ref":"master","sha":"872368c8656d7b71ea95f73b39ef32e8f4ff79b0","user":{"login":"sphereio","id":4119130,"avatar_url":"https://avatars.githubusercontent.com/u/4119130?v=3","gravatar_id":"","url":"https://api.github.com/users/sphereio","html_url":"https://github.com/sphereio","followers_url":"https://api.github.com/users/sphereio/followers","following_url":"https://api.github.com/users/sphereio/following{/other_user}","gists_url":"https://api.github.com/users/sphereio/gists{/gist_id}","starred_url":"https://api.github.com/users/sphereio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphereio/subscriptions","organizations_url":"https://api.github.com/users/sphereio/orgs","repos_url":"https://api.github.com/users/sphereio/repos","events_url":"https://api.github.com/users/sphereio/events{/privacy}","received_events_url":"https://api.github.com/users/sphereio/received_events","type":"Organization","site_admin":false},"repo":{"id":20036001,"name":"sphere-sunrise","full_name":"sphereio/sphere-sunrise","owner":{"login":"sphereio","id":4119130,"avatar_url":"https://avatars.githubusercontent.com/u/4119130?v=3","gravatar_id":"","url":"https://api.github.com/users/sphereio","html_url":"https://github.com/sphereio","followers_url":"https://api.github.com/users/sphereio/followers","following_url":"https://api.github.com/users/sphereio/following{/other_user}","gists_url":"https://api.github.com/users/sphereio/gists{/gist_id}","starred_url":"https://api.github.com/users/sphereio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphereio/subscriptions","organizations_url":"https://api.github.com/users/sphereio/orgs","repos_url":"https://api.github.com/users/sphereio/repos","events_url":"https://api.github.com/users/sphereio/events{/privacy}","received_events_url":"https://api.github.com/users/sphereio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sphereio/sphere-sunrise","description":"The next generation SPHERE.IO demo shop template","fork":false,"url":"https://api.github.com/repos/sphereio/sphere-sunrise","forks_url":"https://api.github.com/repos/sphereio/sphere-sunrise/forks","keys_url":"https://api.github.com/repos/sphereio/sphere-sunrise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sphereio/sphere-sunrise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sphereio/sphere-sunrise/teams","hooks_url":"https://api.github.com/repos/sphereio/sphere-sunrise/hooks","issue_events_url":"https://api.github.com/repos/sphereio/sphere-sunrise/issues/events{/number}","events_url":"https://api.github.com/repos/sphereio/sphere-sunrise/events","assignees_url":"https://api.github.com/repos/sphereio/sphere-sunrise/assignees{/user}","branches_url":"https://api.github.com/repos/sphereio/sphere-sunrise/branches{/branch}","tags_url":"https://api.github.com/repos/sphereio/sphere-sunrise/tags","blobs_url":"https://api.github.com/repos/sphereio/sphere-sunrise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sphereio/sphere-sunrise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sphereio/sphere-sunrise/git/refs{/sha}","trees_url":"https://api.github.com/repos/sphereio/sphere-sunrise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sphereio/sphere-sunrise/statuses/{sha}","languages_url":"https://api.github.com/repos/sphereio/sphere-sunrise/languages","stargazers_url":"https://api.github.com/repos/sphereio/sphere-sunrise/stargazers","contributors_url":"https://api.github.com/repos/sphereio/sphere-sunrise/contributors","subscribers_url":"https://api.github.com/repos/sphereio/sphere-sunrise/subscribers","subscription_url":"https://api.github.com/repos/sphereio/sphere-sunrise/subscription","commits_url":"https://api.github.com/repos/sphereio/sphere-sunrise/commits{/sha}","git_commits_url":"https://api.github.com/repos/sphereio/sphere-sunrise/git/commits{/sha}","comments_url":"https://api.github.com/repos/sphereio/sphere-sunrise/comments{/number}","issue_comment_url":"https://api.github.com/repos/sphereio/sphere-sunrise/issues/comments{/number}","contents_url":"https://api.github.com/repos/sphereio/sphere-sunrise/contents/{+path}","compare_url":"https://api.github.com/repos/sphereio/sphere-sunrise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sphereio/sphere-sunrise/merges","archive_url":"https://api.github.com/repos/sphereio/sphere-sunrise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sphereio/sphere-sunrise/downloads","issues_url":"https://api.github.com/repos/sphereio/sphere-sunrise/issues{/number}","pulls_url":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls{/number}","milestones_url":"https://api.github.com/repos/sphereio/sphere-sunrise/milestones{/number}","notifications_url":"https://api.github.com/repos/sphereio/sphere-sunrise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sphereio/sphere-sunrise/labels{/name}","releases_url":"https://api.github.com/repos/sphereio/sphere-sunrise/releases{/id}","created_at":"2014-05-21T20:20:52Z","updated_at":"2015-04-26T16:17:40Z","pushed_at":"2015-06-22T08:59:33Z","git_url":"git://github.com/sphereio/sphere-sunrise.git","ssh_url":"git@github.com:sphereio/sphere-sunrise.git","clone_url":"https://github.com/sphereio/sphere-sunrise.git","svn_url":"https://github.com/sphereio/sphere-sunrise","homepage":"https://sunrise.sphere.io","size":4189,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":54,"forks":1,"open_issues":54,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls/99"},"html":{"href":"https://github.com/sphereio/sphere-sunrise/pull/99"},"issue":{"href":"https://api.github.com/repos/sphereio/sphere-sunrise/issues/99"},"comments":{"href":"https://api.github.com/repos/sphereio/sphere-sunrise/issues/99/comments"},"review_comments":{"href":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls/99/comments"},"review_comment":{"href":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sphereio/sphere-sunrise/pulls/99/commits"},"statuses":{"href":"https://api.github.com/repos/sphereio/sphere-sunrise/statuses/c7b728ea8795c3407c94e15e9876206b752d1606"}}}}