{"action":"created","issue":{"url":"https://api.github.com/repos/acplt/open62541/issues/362","labels_url":"https://api.github.com/repos/acplt/open62541/issues/362/labels{/name}","comments_url":"https://api.github.com/repos/acplt/open62541/issues/362/comments","events_url":"https://api.github.com/repos/acplt/open62541/issues/362/events","html_url":"https://github.com/acplt/open62541/issues/362","id":104224167,"number":362,"title":"Re-review client part of hl_abstractions branch","user":{"login":"jpfr","id":1726411,"avatar_url":"https://avatars.githubusercontent.com/u/1726411?v=3","gravatar_id":"","url":"https://api.github.com/users/jpfr","html_url":"https://github.com/jpfr","followers_url":"https://api.github.com/users/jpfr/followers","following_url":"https://api.github.com/users/jpfr/following{/other_user}","gists_url":"https://api.github.com/users/jpfr/gists{/gist_id}","starred_url":"https://api.github.com/users/jpfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpfr/subscriptions","organizations_url":"https://api.github.com/users/jpfr/orgs","repos_url":"https://api.github.com/users/jpfr/repos","events_url":"https://api.github.com/users/jpfr/events{/privacy}","received_events_url":"https://api.github.com/users/jpfr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-01T09:23:29Z","updated_at":"2015-09-01T09:52:23Z","closed_at":null,"body":"Hey all,\r\n\r\nthank you @ichrispa for your hard work on the xml namespace import and the API improvements.\r\n\r\nI was a bit surprised to see the PR go through so fast.\r\nNormally, the big PRs improve a lot during code review and should be allowed this opportunity.\r\nAlso, the PR could have been split into distinct functionalities that are easier to review.\r\n\r\n@ichrispa If it is okay with you, I'd keep the xml generation and server part as-is in master. But I would revert the client API for the time being. With the goal of getting it back in after a proper review.\r\n\r\n- Many of the 34 new Coverity bugs are in the client (they could have been found *at home* with clang-analyzer)\r\n- Stasik and I asked for some API changes early on (not exposing the node objects in the client). We never heard back on that.\r\n- There is time pressure to have the xml-generation functionality for the workshop. The client is not so time critical.\r\n\r\nIs that approach okay with you?\r\nBy the way, looking forward to seeing you next week!"},"comment":{"url":"https://api.github.com/repos/acplt/open62541/issues/comments/136655858","html_url":"https://github.com/acplt/open62541/issues/362#issuecomment-136655858","issue_url":"https://api.github.com/repos/acplt/open62541/issues/362","id":136655858,"user":{"login":"ichrispa","id":2773265,"avatar_url":"https://avatars.githubusercontent.com/u/2773265?v=3","gravatar_id":"","url":"https://api.github.com/users/ichrispa","html_url":"https://github.com/ichrispa","followers_url":"https://api.github.com/users/ichrispa/followers","following_url":"https://api.github.com/users/ichrispa/following{/other_user}","gists_url":"https://api.github.com/users/ichrispa/gists{/gist_id}","starred_url":"https://api.github.com/users/ichrispa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ichrispa/subscriptions","organizations_url":"https://api.github.com/users/ichrispa/orgs","repos_url":"https://api.github.com/users/ichrispa/repos","events_url":"https://api.github.com/users/ichrispa/events{/privacy}","received_events_url":"https://api.github.com/users/ichrispa/received_events","type":"User","site_admin":false},"created_at":"2015-09-01T09:52:23Z","updated_at":"2015-09-01T09:52:23Z","body":"Hi @jpfr,\r\n\r\nI was a bit suprised to seeing the hl-api having been merged in with master this morning too. So reverting the change to separate branches is ok with me.\r\n\r\nI just fixed many of the 34 coverity bugs and I am hunting down several more; I am fixing them in my local version of the hl-branch as well; if you want to, I can push that branch back up to origin and you can revert master.\r\n\r\nThe non-exposing of the nodes refers to get|deleteNodeCopy? Sry, I must have skipped over that issue somehow.\r\n\r\nRegards,\r\n\r\nichrispa"}}