{"action":"created","comment":{"url":"https://api.github.com/repos/apache/drill/pulls/comments/39996569","id":39996569,"diff_hunk":"@@ -102,6 +119,29 @@ public void setOption(OptionValue value) {\n   }\n \n   @Override\n+  public void deleteOption(final String name, final OptionType type) {\n+    try {\n+      SystemOptionManager.getValidator(name); // ensure the option exists\n+    } catch (final IllegalArgumentException e) {\n+      throw UserException.validationError(e)\n+        .build(logger);\n+    }\n+\n+    // fallback if unable to delete locally\n+    if (!deleteLocalOption(name, type)) {","path":"exec/java-exec/src/main/java/org/apache/drill/exec/server/options/FallbackOptionManager.java","position":54,"original_position":54,"commit_id":"0f97e40b2fb2d1638d8ac20909b667e1ea1ddc77","original_commit_id":"0f97e40b2fb2d1638d8ac20909b667e1ea1ddc77","user":{"login":"adeneche","id":8422943,"avatar_url":"https://avatars.githubusercontent.com/u/8422943?v=3","gravatar_id":"","url":"https://api.github.com/users/adeneche","html_url":"https://github.com/adeneche","followers_url":"https://api.github.com/users/adeneche/followers","following_url":"https://api.github.com/users/adeneche/following{/other_user}","gists_url":"https://api.github.com/users/adeneche/gists{/gist_id}","starred_url":"https://api.github.com/users/adeneche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adeneche/subscriptions","organizations_url":"https://api.github.com/users/adeneche/orgs","repos_url":"https://api.github.com/users/adeneche/repos","events_url":"https://api.github.com/users/adeneche/events{/privacy}","received_events_url":"https://api.github.com/users/adeneche/received_events","type":"User","site_admin":false},"body":"you should call `name.toLowerCase()` here to make sure implementation will always be case insensitive.","created_at":"2015-09-21T17:07:50Z","updated_at":"2015-09-21T17:07:50Z","html_url":"https://github.com/apache/drill/pull/159#discussion_r39996569","pull_request_url":"https://api.github.com/repos/apache/drill/pulls/159","_links":{"self":{"href":"https://api.github.com/repos/apache/drill/pulls/comments/39996569"},"html":{"href":"https://github.com/apache/drill/pull/159#discussion_r39996569"},"pull_request":{"href":"https://api.github.com/repos/apache/drill/pulls/159"}}},"pull_request":{"url":"https://api.github.com/repos/apache/drill/pulls/159","id":45115118,"html_url":"https://github.com/apache/drill/pull/159","diff_url":"https://github.com/apache/drill/pull/159.diff","patch_url":"https://github.com/apache/drill/pull/159.patch","issue_url":"https://api.github.com/repos/apache/drill/issues/159","number":159,"state":"open","locked":false,"title":"DRILL-1065: Support for ALTER ... RESET statement","user":{"login":"sudheeshkatkam","id":3272600,"avatar_url":"https://avatars.githubusercontent.com/u/3272600?v=3","gravatar_id":"","url":"https://api.github.com/users/sudheeshkatkam","html_url":"https://github.com/sudheeshkatkam","followers_url":"https://api.github.com/users/sudheeshkatkam/followers","following_url":"https://api.github.com/users/sudheeshkatkam/following{/other_user}","gists_url":"https://api.github.com/users/sudheeshkatkam/gists{/gist_id}","starred_url":"https://api.github.com/users/sudheeshkatkam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sudheeshkatkam/subscriptions","organizations_url":"https://api.github.com/users/sudheeshkatkam/orgs","repos_url":"https://api.github.com/users/sudheeshkatkam/repos","events_url":"https://api.github.com/users/sudheeshkatkam/events{/privacy}","received_events_url":"https://api.github.com/users/sudheeshkatkam/received_events","type":"User","site_admin":false},"body":"+ Support for \"SET option = value\" statement (assumes scope as SESSION)\r\n+ Better error messages in SetOptionHandler\r\n+ Changes in CompoundIdentifierConverter\r\n  - update when rewritten operand is not deeply equal to the original operand\r\n  - Added Override annotations\r\n+ Default ExecutionControls option value should be at SYSTEM level\r\n\r\n@jacques-n @vkorukanti please review.","created_at":"2015-09-15T23:27:24Z","updated_at":"2015-09-21T17:07:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2fda8f8c8396bc1ece0d02d475d4fd3b24bb699b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/drill/pulls/159/commits","review_comments_url":"https://api.github.com/repos/apache/drill/pulls/159/comments","review_comment_url":"https://api.github.com/repos/apache/drill/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/drill/issues/159/comments","statuses_url":"https://api.github.com/repos/apache/drill/statuses/0f97e40b2fb2d1638d8ac20909b667e1ea1ddc77","head":{"label":"sudheeshkatkam:DRILL-1065","ref":"DRILL-1065","sha":"0f97e40b2fb2d1638d8ac20909b667e1ea1ddc77","user":{"login":"sudheeshkatkam","id":3272600,"avatar_url":"https://avatars.githubusercontent.com/u/3272600?v=3","gravatar_id":"","url":"https://api.github.com/users/sudheeshkatkam","html_url":"https://github.com/sudheeshkatkam","followers_url":"https://api.github.com/users/sudheeshkatkam/followers","following_url":"https://api.github.com/users/sudheeshkatkam/following{/other_user}","gists_url":"https://api.github.com/users/sudheeshkatkam/gists{/gist_id}","starred_url":"https://api.github.com/users/sudheeshkatkam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sudheeshkatkam/subscriptions","organizations_url":"https://api.github.com/users/sudheeshkatkam/orgs","repos_url":"https://api.github.com/users/sudheeshkatkam/repos","events_url":"https://api.github.com/users/sudheeshkatkam/events{/privacy}","received_events_url":"https://api.github.com/users/sudheeshkatkam/received_events","type":"User","site_admin":false},"repo":{"id":20229967,"name":"drill","full_name":"sudheeshkatkam/drill","owner":{"login":"sudheeshkatkam","id":3272600,"avatar_url":"https://avatars.githubusercontent.com/u/3272600?v=3","gravatar_id":"","url":"https://api.github.com/users/sudheeshkatkam","html_url":"https://github.com/sudheeshkatkam","followers_url":"https://api.github.com/users/sudheeshkatkam/followers","following_url":"https://api.github.com/users/sudheeshkatkam/following{/other_user}","gists_url":"https://api.github.com/users/sudheeshkatkam/gists{/gist_id}","starred_url":"https://api.github.com/users/sudheeshkatkam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sudheeshkatkam/subscriptions","organizations_url":"https://api.github.com/users/sudheeshkatkam/orgs","repos_url":"https://api.github.com/users/sudheeshkatkam/repos","events_url":"https://api.github.com/users/sudheeshkatkam/events{/privacy}","received_events_url":"https://api.github.com/users/sudheeshkatkam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sudheeshkatkam/drill","description":"Sudheesh's Drill Fork","fork":true,"url":"https://api.github.com/repos/sudheeshkatkam/drill","forks_url":"https://api.github.com/repos/sudheeshkatkam/drill/forks","keys_url":"https://api.github.com/repos/sudheeshkatkam/drill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sudheeshkatkam/drill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sudheeshkatkam/drill/teams","hooks_url":"https://api.github.com/repos/sudheeshkatkam/drill/hooks","issue_events_url":"https://api.github.com/repos/sudheeshkatkam/drill/issues/events{/number}","events_url":"https://api.github.com/repos/sudheeshkatkam/drill/events","assignees_url":"https://api.github.com/repos/sudheeshkatkam/drill/assignees{/user}","branches_url":"https://api.github.com/repos/sudheeshkatkam/drill/branches{/branch}","tags_url":"https://api.github.com/repos/sudheeshkatkam/drill/tags","blobs_url":"https://api.github.com/repos/sudheeshkatkam/drill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sudheeshkatkam/drill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sudheeshkatkam/drill/git/refs{/sha}","trees_url":"https://api.github.com/repos/sudheeshkatkam/drill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sudheeshkatkam/drill/statuses/{sha}","languages_url":"https://api.github.com/repos/sudheeshkatkam/drill/languages","stargazers_url":"https://api.github.com/repos/sudheeshkatkam/drill/stargazers","contributors_url":"https://api.github.com/repos/sudheeshkatkam/drill/contributors","subscribers_url":"https://api.github.com/repos/sudheeshkatkam/drill/subscribers","subscription_url":"https://api.github.com/repos/sudheeshkatkam/drill/subscription","commits_url":"https://api.github.com/repos/sudheeshkatkam/drill/commits{/sha}","git_commits_url":"https://api.github.com/repos/sudheeshkatkam/drill/git/commits{/sha}","comments_url":"https://api.github.com/repos/sudheeshkatkam/drill/comments{/number}","issue_comment_url":"https://api.github.com/repos/sudheeshkatkam/drill/issues/comments{/number}","contents_url":"https://api.github.com/repos/sudheeshkatkam/drill/contents/{+path}","compare_url":"https://api.github.com/repos/sudheeshkatkam/drill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sudheeshkatkam/drill/merges","archive_url":"https://api.github.com/repos/sudheeshkatkam/drill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sudheeshkatkam/drill/downloads","issues_url":"https://api.github.com/repos/sudheeshkatkam/drill/issues{/number}","pulls_url":"https://api.github.com/repos/sudheeshkatkam/drill/pulls{/number}","milestones_url":"https://api.github.com/repos/sudheeshkatkam/drill/milestones{/number}","notifications_url":"https://api.github.com/repos/sudheeshkatkam/drill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sudheeshkatkam/drill/labels{/name}","releases_url":"https://api.github.com/repos/sudheeshkatkam/drill/releases{/id}","created_at":"2014-05-27T18:08:52Z","updated_at":"2015-05-07T16:46:06Z","pushed_at":"2015-09-17T23:48:33Z","git_url":"git://github.com/sudheeshkatkam/drill.git","ssh_url":"git@github.com:sudheeshkatkam/drill.git","clone_url":"https://github.com/sudheeshkatkam/drill.git","svn_url":"https://github.com/sudheeshkatkam/drill","homepage":"","size":34814,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"5fab01fab93c3b51496aec2358645ac2ac78568c","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":5683653,"name":"drill","full_name":"apache/drill","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/drill","description":"Mirror of Apache Drill","fork":false,"url":"https://api.github.com/repos/apache/drill","forks_url":"https://api.github.com/repos/apache/drill/forks","keys_url":"https://api.github.com/repos/apache/drill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/drill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/drill/teams","hooks_url":"https://api.github.com/repos/apache/drill/hooks","issue_events_url":"https://api.github.com/repos/apache/drill/issues/events{/number}","events_url":"https://api.github.com/repos/apache/drill/events","assignees_url":"https://api.github.com/repos/apache/drill/assignees{/user}","branches_url":"https://api.github.com/repos/apache/drill/branches{/branch}","tags_url":"https://api.github.com/repos/apache/drill/tags","blobs_url":"https://api.github.com/repos/apache/drill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/drill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/drill/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/drill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/drill/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/drill/languages","stargazers_url":"https://api.github.com/repos/apache/drill/stargazers","contributors_url":"https://api.github.com/repos/apache/drill/contributors","subscribers_url":"https://api.github.com/repos/apache/drill/subscribers","subscription_url":"https://api.github.com/repos/apache/drill/subscription","commits_url":"https://api.github.com/repos/apache/drill/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/drill/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/drill/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/drill/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/drill/contents/{+path}","compare_url":"https://api.github.com/repos/apache/drill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/drill/merges","archive_url":"https://api.github.com/repos/apache/drill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/drill/downloads","issues_url":"https://api.github.com/repos/apache/drill/issues{/number}","pulls_url":"https://api.github.com/repos/apache/drill/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/drill/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/drill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/drill/labels{/name}","releases_url":"https://api.github.com/repos/apache/drill/releases{/id}","created_at":"2012-09-05T07:00:26Z","updated_at":"2015-09-21T16:23:34Z","pushed_at":"2015-09-21T16:45:20Z","git_url":"git://github.com/apache/drill.git","ssh_url":"git@github.com:apache/drill.git","clone_url":"https://github.com/apache/drill.git","svn_url":"https://github.com/apache/drill","homepage":"","size":44614,"stargazers_count":479,"watchers_count":479,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":305,"mirror_url":"git://git.apache.org/incubator-drill.git","open_issues_count":32,"forks":305,"open_issues":32,"watchers":479,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/drill/pulls/159"},"html":{"href":"https://github.com/apache/drill/pull/159"},"issue":{"href":"https://api.github.com/repos/apache/drill/issues/159"},"comments":{"href":"https://api.github.com/repos/apache/drill/issues/159/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/drill/pulls/159/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/drill/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/drill/pulls/159/commits"},"statuses":{"href":"https://api.github.com/repos/apache/drill/statuses/0f97e40b2fb2d1638d8ac20909b667e1ea1ddc77"}}}}