{"action":"created","issue":{"url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/issues/2","labels_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/issues/2/comments","events_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/issues/2/events","html_url":"https://github.com/Ada-Developers-Academy/C3Projects--MediaRanker/pull/2","id":94401191,"number":2,"title":"Complete MediaRanker","user":{"login":"acmei","id":8615571,"avatar_url":"https://avatars.githubusercontent.com/u/8615571?v=3","gravatar_id":"","url":"https://api.github.com/users/acmei","html_url":"https://github.com/acmei","followers_url":"https://api.github.com/users/acmei/followers","following_url":"https://api.github.com/users/acmei/following{/other_user}","gists_url":"https://api.github.com/users/acmei/gists{/gist_id}","starred_url":"https://api.github.com/users/acmei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acmei/subscriptions","organizations_url":"https://api.github.com/users/acmei/orgs","repos_url":"https://api.github.com/users/acmei/repos","events_url":"https://api.github.com/users/acmei/events{/privacy}","received_events_url":"https://api.github.com/users/acmei/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"GreyKn","id":2430394,"avatar_url":"https://avatars.githubusercontent.com/u/2430394?v=3","gravatar_id":"","url":"https://api.github.com/users/GreyKn","html_url":"https://github.com/GreyKn","followers_url":"https://api.github.com/users/GreyKn/followers","following_url":"https://api.github.com/users/GreyKn/following{/other_user}","gists_url":"https://api.github.com/users/GreyKn/gists{/gist_id}","starred_url":"https://api.github.com/users/GreyKn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GreyKn/subscriptions","organizations_url":"https://api.github.com/users/GreyKn/orgs","repos_url":"https://api.github.com/users/GreyKn/repos","events_url":"https://api.github.com/users/GreyKn/events{/privacy}","received_events_url":"https://api.github.com/users/GreyKn/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-07-10T21:53:40Z","updated_at":"2015-07-16T23:36:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/pulls/2","html_url":"https://github.com/Ada-Developers-Academy/C3Projects--MediaRanker/pull/2","diff_url":"https://github.com/Ada-Developers-Academy/C3Projects--MediaRanker/pull/2.diff","patch_url":"https://github.com/Ada-Developers-Academy/C3Projects--MediaRanker/pull/2.patch"},"body":"I tried to use partials (for views) and shared examples (for specs) where I could to DRY out my code as much as possible. I learned a lot more about testing in Rails with this project. Also, since we utilized bootstrap and were instructed to design our website similar to an example, I felt like it saved me from having to make CSS design decisions. I was proud of how I was able to incorporate the shared code among all of my pages and specs and deleted tons of lines of code.\r\n\r\n**Things I Learned via MediaRanker**  \r\n  - Rails rspec testing, creating and writing specs for models and controllers\r\n  - rspec shared examples\r\n  - Bootstrap\r\n  - polymorphic paths\r\n  - model validations\r\n  - scopes\r\n\r\nThanks for your feedback!"},"comment":{"url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/issues/comments/122131156","html_url":"https://github.com/Ada-Developers-Academy/C3Projects--MediaRanker/pull/2#issuecomment-122131156","issue_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/issues/2","id":122131156,"user":{"login":"GreyKn","id":2430394,"avatar_url":"https://avatars.githubusercontent.com/u/2430394?v=3","gravatar_id":"","url":"https://api.github.com/users/GreyKn","html_url":"https://github.com/GreyKn","followers_url":"https://api.github.com/users/GreyKn/followers","following_url":"https://api.github.com/users/GreyKn/following{/other_user}","gists_url":"https://api.github.com/users/GreyKn/gists{/gist_id}","starred_url":"https://api.github.com/users/GreyKn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GreyKn/subscriptions","organizations_url":"https://api.github.com/users/GreyKn/orgs","repos_url":"https://api.github.com/users/GreyKn/repos","events_url":"https://api.github.com/users/GreyKn/events{/privacy}","received_events_url":"https://api.github.com/users/GreyKn/received_events","type":"User","site_admin":false},"created_at":"2015-07-16T23:36:48Z","updated_at":"2015-07-16T23:36:48Z","body":"Hey Anita,\r\n\r\nGood on this project. I liked that you used shared examples to DRY up your tests. Looking at that, do you think could could dry up your controllers as well?\r\n\r\nI left a couple of comments about how you might make your tests more resilient.\r\n\r\nLet me know if you have any questions."}}