{"action":"closed","number":498,"pull_request":{"url":"https://api.github.com/repos/sdelements/lets-chat/pulls/498","id":37552781,"html_url":"https://github.com/sdelements/lets-chat/pull/498","diff_url":"https://github.com/sdelements/lets-chat/pull/498.diff","patch_url":"https://github.com/sdelements/lets-chat/pull/498.patch","issue_url":"https://api.github.com/repos/sdelements/lets-chat/issues/498","number":498,"state":"closed","locked":false,"title":"Handling error on Avatar caching. Ignoring Exception","user":{"login":"greggigon","id":932013,"avatar_url":"https://avatars.githubusercontent.com/u/932013?v=3","gravatar_id":"","url":"https://api.github.com/users/greggigon","html_url":"https://github.com/greggigon","followers_url":"https://api.github.com/users/greggigon/followers","following_url":"https://api.github.com/users/greggigon/following{/other_user}","gists_url":"https://api.github.com/users/greggigon/gists{/gist_id}","starred_url":"https://api.github.com/users/greggigon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greggigon/subscriptions","organizations_url":"https://api.github.com/users/greggigon/orgs","repos_url":"https://api.github.com/users/greggigon/repos","events_url":"https://api.github.com/users/greggigon/events{/privacy}","received_events_url":"https://api.github.com/users/greggigon/received_events","type":"User","site_admin":false},"body":"I'm trying to run Lets chat inside corporate network behind proxy.\r\nApplication crashes when Avatar caching is called. Problem is that there is no error handler for HTTP request. The error handler ignores the error as the calls to cache handle the situation where Cache does not contain user Avatar.\r\n\r\nIdeally, it should be possible to setup HTTP Proxy for the HTTP calls to the external services. This pull request only fixes the very immediate problem of Crashing Application.\r\n\r\nThere should be a way to use http.get function with proxy.","created_at":"2015-06-12T11:11:35Z","updated_at":"2015-06-12T13:44:36Z","closed_at":"2015-06-12T13:44:36Z","merged_at":"2015-06-12T13:44:36Z","merge_commit_sha":"88d562e6da19b89bb9de8b578862db43d701a39f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sdelements/lets-chat/pulls/498/commits","review_comments_url":"https://api.github.com/repos/sdelements/lets-chat/pulls/498/comments","review_comment_url":"https://api.github.com/repos/sdelements/lets-chat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sdelements/lets-chat/issues/498/comments","statuses_url":"https://api.github.com/repos/sdelements/lets-chat/statuses/9a88cb35add18fea94f0c6dd0a6c4cd9d66b6b6b","head":{"label":"greggigon:develop","ref":"develop","sha":"9a88cb35add18fea94f0c6dd0a6c4cd9d66b6b6b","user":{"login":"greggigon","id":932013,"avatar_url":"https://avatars.githubusercontent.com/u/932013?v=3","gravatar_id":"","url":"https://api.github.com/users/greggigon","html_url":"https://github.com/greggigon","followers_url":"https://api.github.com/users/greggigon/followers","following_url":"https://api.github.com/users/greggigon/following{/other_user}","gists_url":"https://api.github.com/users/greggigon/gists{/gist_id}","starred_url":"https://api.github.com/users/greggigon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greggigon/subscriptions","organizations_url":"https://api.github.com/users/greggigon/orgs","repos_url":"https://api.github.com/users/greggigon/repos","events_url":"https://api.github.com/users/greggigon/events{/privacy}","received_events_url":"https://api.github.com/users/greggigon/received_events","type":"User","site_admin":false},"repo":{"id":37314279,"name":"lets-chat","full_name":"greggigon/lets-chat","owner":{"login":"greggigon","id":932013,"avatar_url":"https://avatars.githubusercontent.com/u/932013?v=3","gravatar_id":"","url":"https://api.github.com/users/greggigon","html_url":"https://github.com/greggigon","followers_url":"https://api.github.com/users/greggigon/followers","following_url":"https://api.github.com/users/greggigon/following{/other_user}","gists_url":"https://api.github.com/users/greggigon/gists{/gist_id}","starred_url":"https://api.github.com/users/greggigon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greggigon/subscriptions","organizations_url":"https://api.github.com/users/greggigon/orgs","repos_url":"https://api.github.com/users/greggigon/repos","events_url":"https://api.github.com/users/greggigon/events{/privacy}","received_events_url":"https://api.github.com/users/greggigon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/greggigon/lets-chat","description":"Self-hosted chat app for small teams","fork":true,"url":"https://api.github.com/repos/greggigon/lets-chat","forks_url":"https://api.github.com/repos/greggigon/lets-chat/forks","keys_url":"https://api.github.com/repos/greggigon/lets-chat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greggigon/lets-chat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greggigon/lets-chat/teams","hooks_url":"https://api.github.com/repos/greggigon/lets-chat/hooks","issue_events_url":"https://api.github.com/repos/greggigon/lets-chat/issues/events{/number}","events_url":"https://api.github.com/repos/greggigon/lets-chat/events","assignees_url":"https://api.github.com/repos/greggigon/lets-chat/assignees{/user}","branches_url":"https://api.github.com/repos/greggigon/lets-chat/branches{/branch}","tags_url":"https://api.github.com/repos/greggigon/lets-chat/tags","blobs_url":"https://api.github.com/repos/greggigon/lets-chat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greggigon/lets-chat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greggigon/lets-chat/git/refs{/sha}","trees_url":"https://api.github.com/repos/greggigon/lets-chat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greggigon/lets-chat/statuses/{sha}","languages_url":"https://api.github.com/repos/greggigon/lets-chat/languages","stargazers_url":"https://api.github.com/repos/greggigon/lets-chat/stargazers","contributors_url":"https://api.github.com/repos/greggigon/lets-chat/contributors","subscribers_url":"https://api.github.com/repos/greggigon/lets-chat/subscribers","subscription_url":"https://api.github.com/repos/greggigon/lets-chat/subscription","commits_url":"https://api.github.com/repos/greggigon/lets-chat/commits{/sha}","git_commits_url":"https://api.github.com/repos/greggigon/lets-chat/git/commits{/sha}","comments_url":"https://api.github.com/repos/greggigon/lets-chat/comments{/number}","issue_comment_url":"https://api.github.com/repos/greggigon/lets-chat/issues/comments{/number}","contents_url":"https://api.github.com/repos/greggigon/lets-chat/contents/{+path}","compare_url":"https://api.github.com/repos/greggigon/lets-chat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greggigon/lets-chat/merges","archive_url":"https://api.github.com/repos/greggigon/lets-chat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greggigon/lets-chat/downloads","issues_url":"https://api.github.com/repos/greggigon/lets-chat/issues{/number}","pulls_url":"https://api.github.com/repos/greggigon/lets-chat/pulls{/number}","milestones_url":"https://api.github.com/repos/greggigon/lets-chat/milestones{/number}","notifications_url":"https://api.github.com/repos/greggigon/lets-chat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greggigon/lets-chat/labels{/name}","releases_url":"https://api.github.com/repos/greggigon/lets-chat/releases{/id}","created_at":"2015-06-12T09:42:34Z","updated_at":"2015-06-12T09:42:35Z","pushed_at":"2015-06-12T11:24:51Z","git_url":"git://github.com/greggigon/lets-chat.git","ssh_url":"git@github.com:greggigon/lets-chat.git","clone_url":"https://github.com/greggigon/lets-chat.git","svn_url":"https://github.com/greggigon/lets-chat","homepage":"http://sdelements.github.io/lets-chat","size":28364,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sdelements:develop","ref":"develop","sha":"965e5251748b10e930e72186d705df92e70ab401","user":{"login":"sdelements","id":739346,"avatar_url":"https://avatars.githubusercontent.com/u/739346?v=3","gravatar_id":"","url":"https://api.github.com/users/sdelements","html_url":"https://github.com/sdelements","followers_url":"https://api.github.com/users/sdelements/followers","following_url":"https://api.github.com/users/sdelements/following{/other_user}","gists_url":"https://api.github.com/users/sdelements/gists{/gist_id}","starred_url":"https://api.github.com/users/sdelements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdelements/subscriptions","organizations_url":"https://api.github.com/users/sdelements/orgs","repos_url":"https://api.github.com/users/sdelements/repos","events_url":"https://api.github.com/users/sdelements/events{/privacy}","received_events_url":"https://api.github.com/users/sdelements/received_events","type":"Organization","site_admin":false},"repo":{"id":3673976,"name":"lets-chat","full_name":"sdelements/lets-chat","owner":{"login":"sdelements","id":739346,"avatar_url":"https://avatars.githubusercontent.com/u/739346?v=3","gravatar_id":"","url":"https://api.github.com/users/sdelements","html_url":"https://github.com/sdelements","followers_url":"https://api.github.com/users/sdelements/followers","following_url":"https://api.github.com/users/sdelements/following{/other_user}","gists_url":"https://api.github.com/users/sdelements/gists{/gist_id}","starred_url":"https://api.github.com/users/sdelements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdelements/subscriptions","organizations_url":"https://api.github.com/users/sdelements/orgs","repos_url":"https://api.github.com/users/sdelements/repos","events_url":"https://api.github.com/users/sdelements/events{/privacy}","received_events_url":"https://api.github.com/users/sdelements/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sdelements/lets-chat","description":"Self-hosted chat app for small teams","fork":false,"url":"https://api.github.com/repos/sdelements/lets-chat","forks_url":"https://api.github.com/repos/sdelements/lets-chat/forks","keys_url":"https://api.github.com/repos/sdelements/lets-chat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdelements/lets-chat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdelements/lets-chat/teams","hooks_url":"https://api.github.com/repos/sdelements/lets-chat/hooks","issue_events_url":"https://api.github.com/repos/sdelements/lets-chat/issues/events{/number}","events_url":"https://api.github.com/repos/sdelements/lets-chat/events","assignees_url":"https://api.github.com/repos/sdelements/lets-chat/assignees{/user}","branches_url":"https://api.github.com/repos/sdelements/lets-chat/branches{/branch}","tags_url":"https://api.github.com/repos/sdelements/lets-chat/tags","blobs_url":"https://api.github.com/repos/sdelements/lets-chat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdelements/lets-chat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdelements/lets-chat/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdelements/lets-chat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdelements/lets-chat/statuses/{sha}","languages_url":"https://api.github.com/repos/sdelements/lets-chat/languages","stargazers_url":"https://api.github.com/repos/sdelements/lets-chat/stargazers","contributors_url":"https://api.github.com/repos/sdelements/lets-chat/contributors","subscribers_url":"https://api.github.com/repos/sdelements/lets-chat/subscribers","subscription_url":"https://api.github.com/repos/sdelements/lets-chat/subscription","commits_url":"https://api.github.com/repos/sdelements/lets-chat/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdelements/lets-chat/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdelements/lets-chat/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdelements/lets-chat/issues/comments{/number}","contents_url":"https://api.github.com/repos/sdelements/lets-chat/contents/{+path}","compare_url":"https://api.github.com/repos/sdelements/lets-chat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdelements/lets-chat/merges","archive_url":"https://api.github.com/repos/sdelements/lets-chat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdelements/lets-chat/downloads","issues_url":"https://api.github.com/repos/sdelements/lets-chat/issues{/number}","pulls_url":"https://api.github.com/repos/sdelements/lets-chat/pulls{/number}","milestones_url":"https://api.github.com/repos/sdelements/lets-chat/milestones{/number}","notifications_url":"https://api.github.com/repos/sdelements/lets-chat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdelements/lets-chat/labels{/name}","releases_url":"https://api.github.com/repos/sdelements/lets-chat/releases{/id}","created_at":"2012-03-09T19:32:33Z","updated_at":"2015-06-12T11:15:25Z","pushed_at":"2015-06-12T13:44:36Z","git_url":"git://github.com/sdelements/lets-chat.git","ssh_url":"git@github.com:sdelements/lets-chat.git","clone_url":"https://github.com/sdelements/lets-chat.git","svn_url":"https://github.com/sdelements/lets-chat","homepage":"http://sdelements.github.io/lets-chat","size":28364,"stargazers_count":6680,"watchers_count":6680,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":807,"mirror_url":null,"open_issues_count":92,"forks":807,"open_issues":92,"watchers":6680,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sdelements/lets-chat/pulls/498"},"html":{"href":"https://github.com/sdelements/lets-chat/pull/498"},"issue":{"href":"https://api.github.com/repos/sdelements/lets-chat/issues/498"},"comments":{"href":"https://api.github.com/repos/sdelements/lets-chat/issues/498/comments"},"review_comments":{"href":"https://api.github.com/repos/sdelements/lets-chat/pulls/498/comments"},"review_comment":{"href":"https://api.github.com/repos/sdelements/lets-chat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sdelements/lets-chat/pulls/498/commits"},"statuses":{"href":"https://api.github.com/repos/sdelements/lets-chat/statuses/9a88cb35add18fea94f0c6dd0a6c4cd9d66b6b6b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"sibartlett","id":216687,"avatar_url":"https://avatars.githubusercontent.com/u/216687?v=3","gravatar_id":"","url":"https://api.github.com/users/sibartlett","html_url":"https://github.com/sibartlett","followers_url":"https://api.github.com/users/sibartlett/followers","following_url":"https://api.github.com/users/sibartlett/following{/other_user}","gists_url":"https://api.github.com/users/sibartlett/gists{/gist_id}","starred_url":"https://api.github.com/users/sibartlett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sibartlett/subscriptions","organizations_url":"https://api.github.com/users/sibartlett/orgs","repos_url":"https://api.github.com/users/sibartlett/repos","events_url":"https://api.github.com/users/sibartlett/events{/privacy}","received_events_url":"https://api.github.com/users/sibartlett/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":1,"deletions":1,"changed_files":1}}