{"action":"created","issue":{"url":"https://api.github.com/repos/NuCivic/dkan_dataset/issues/121","labels_url":"https://api.github.com/repos/NuCivic/dkan_dataset/issues/121/labels{/name}","comments_url":"https://api.github.com/repos/NuCivic/dkan_dataset/issues/121/comments","events_url":"https://api.github.com/repos/NuCivic/dkan_dataset/issues/121/events","html_url":"https://github.com/NuCivic/dkan_dataset/pull/121","id":88534666,"number":121,"title":"#173 Download all dataset resources as a zip file.","user":{"login":"ahmed-sghaier","id":5232172,"avatar_url":"https://avatars.githubusercontent.com/u/5232172?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmed-sghaier","html_url":"https://github.com/ahmed-sghaier","followers_url":"https://api.github.com/users/ahmed-sghaier/followers","following_url":"https://api.github.com/users/ahmed-sghaier/following{/other_user}","gists_url":"https://api.github.com/users/ahmed-sghaier/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmed-sghaier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmed-sghaier/subscriptions","organizations_url":"https://api.github.com/users/ahmed-sghaier/orgs","repos_url":"https://api.github.com/users/ahmed-sghaier/repos","events_url":"https://api.github.com/users/ahmed-sghaier/events{/privacy}","received_events_url":"https://api.github.com/users/ahmed-sghaier/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-06-15T20:40:17Z","updated_at":"2015-06-17T12:07:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NuCivic/dkan_dataset/pulls/121","html_url":"https://github.com/NuCivic/dkan_dataset/pull/121","diff_url":"https://github.com/NuCivic/dkan_dataset/pull/121.diff","patch_url":"https://github.com/NuCivic/dkan_dataset/pull/121.patch"},"body":"NuCivic/dkan#173\r\n\r\nThis adds a button \"Download All\" at the bottom of the resource list. Clicking on the button zips all the resources on the dataset and downloads them.\r\n\r\nItems to consider :\r\n\r\n* The zip file naming convention - generally produces long file names based on the node title and timestamp. Is there a better pattern?\r\n* This dynamically creates a zip in the tmp directory and downloads it. Could have performance impact. Another approach would be to recreate a zip on hook_node_update and serve it from the public files directory.\r\n* I'm not sure if the theming code is as good as it could be.\r\n* See attached for a screenshot\r\n\r\n![173-dkan_dataset-download-all-resources](https://cloud.githubusercontent.com/assets/5232172/8169994/59681408-13a5-11e5-8644-a1a8506832da.png)\r\n"},"comment":{"url":"https://api.github.com/repos/NuCivic/dkan_dataset/issues/comments/112775064","html_url":"https://github.com/NuCivic/dkan_dataset/pull/121#issuecomment-112775064","issue_url":"https://api.github.com/repos/NuCivic/dkan_dataset/issues/121","id":112775064,"user":{"login":"wardmarzouki","id":11943262,"avatar_url":"https://avatars.githubusercontent.com/u/11943262?v=3","gravatar_id":"","url":"https://api.github.com/users/wardmarzouki","html_url":"https://github.com/wardmarzouki","followers_url":"https://api.github.com/users/wardmarzouki/followers","following_url":"https://api.github.com/users/wardmarzouki/following{/other_user}","gists_url":"https://api.github.com/users/wardmarzouki/gists{/gist_id}","starred_url":"https://api.github.com/users/wardmarzouki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wardmarzouki/subscriptions","organizations_url":"https://api.github.com/users/wardmarzouki/orgs","repos_url":"https://api.github.com/users/wardmarzouki/repos","events_url":"https://api.github.com/users/wardmarzouki/events{/privacy}","received_events_url":"https://api.github.com/users/wardmarzouki/received_events","type":"User","site_admin":false},"created_at":"2015-06-17T12:07:55Z","updated_at":"2015-06-17T12:07:55Z","body":"Hi @ahmed-sghaier ,\r\n\r\nI have tested the last test case that didn't work on the previous commit, it is now fixed.\r\nAnd I also checked all the previous test cases."}}