{"action":"closed","number":6,"pull_request":{"url":"https://api.github.com/repos/openspending/openspending-migrate/pulls/6","id":54547241,"html_url":"https://github.com/openspending/openspending-migrate/pull/6","diff_url":"https://github.com/openspending/openspending-migrate/pull/6.diff","patch_url":"https://github.com/openspending/openspending-migrate/pull/6.patch","issue_url":"https://api.github.com/repos/openspending/openspending-migrate/issues/6","number":6,"state":"closed","locked":false,"title":"Modify primary key for date dimensions","user":{"login":"akariv","id":265333,"avatar_url":"https://avatars.githubusercontent.com/u/265333?v=3","gravatar_id":"","url":"https://api.github.com/users/akariv","html_url":"https://github.com/akariv","followers_url":"https://api.github.com/users/akariv/followers","following_url":"https://api.github.com/users/akariv/following{/other_user}","gists_url":"https://api.github.com/users/akariv/gists{/gist_id}","starred_url":"https://api.github.com/users/akariv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akariv/subscriptions","organizations_url":"https://api.github.com/users/akariv/orgs","repos_url":"https://api.github.com/users/akariv/repos","events_url":"https://api.github.com/users/akariv/events{/privacy}","received_events_url":"https://api.github.com/users/akariv/received_events","type":"User","site_admin":false},"body":"Hey @danfowler , I think that for date fields we'd want the primary keys to consist of the actual values for (year,month,day), as it would make it easier to use on queries (e.g. cut on year=X).\r\n\r\nwdyt?","created_at":"2015-12-24T12:01:03Z","updated_at":"2015-12-28T15:09:45Z","closed_at":"2015-12-28T15:09:45Z","merged_at":"2015-12-28T15:09:45Z","merge_commit_sha":"390e00a0427953ac6059dd68a73a7a1b469f0cae","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openspending/openspending-migrate/pulls/6/commits","review_comments_url":"https://api.github.com/repos/openspending/openspending-migrate/pulls/6/comments","review_comment_url":"https://api.github.com/repos/openspending/openspending-migrate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openspending/openspending-migrate/issues/6/comments","statuses_url":"https://api.github.com/repos/openspending/openspending-migrate/statuses/ea7c3f788c103359fae63f35438d1772c7245b33","head":{"label":"akariv:master","ref":"master","sha":"ea7c3f788c103359fae63f35438d1772c7245b33","user":{"login":"akariv","id":265333,"avatar_url":"https://avatars.githubusercontent.com/u/265333?v=3","gravatar_id":"","url":"https://api.github.com/users/akariv","html_url":"https://github.com/akariv","followers_url":"https://api.github.com/users/akariv/followers","following_url":"https://api.github.com/users/akariv/following{/other_user}","gists_url":"https://api.github.com/users/akariv/gists{/gist_id}","starred_url":"https://api.github.com/users/akariv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akariv/subscriptions","organizations_url":"https://api.github.com/users/akariv/orgs","repos_url":"https://api.github.com/users/akariv/repos","events_url":"https://api.github.com/users/akariv/events{/privacy}","received_events_url":"https://api.github.com/users/akariv/received_events","type":"User","site_admin":false},"repo":{"id":48540220,"name":"openspending-migrate","full_name":"akariv/openspending-migrate","owner":{"login":"akariv","id":265333,"avatar_url":"https://avatars.githubusercontent.com/u/265333?v=3","gravatar_id":"","url":"https://api.github.com/users/akariv","html_url":"https://github.com/akariv","followers_url":"https://api.github.com/users/akariv/followers","following_url":"https://api.github.com/users/akariv/following{/other_user}","gists_url":"https://api.github.com/users/akariv/gists{/gist_id}","starred_url":"https://api.github.com/users/akariv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akariv/subscriptions","organizations_url":"https://api.github.com/users/akariv/orgs","repos_url":"https://api.github.com/users/akariv/repos","events_url":"https://api.github.com/users/akariv/events{/privacy}","received_events_url":"https://api.github.com/users/akariv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akariv/openspending-migrate","description":"","fork":true,"url":"https://api.github.com/repos/akariv/openspending-migrate","forks_url":"https://api.github.com/repos/akariv/openspending-migrate/forks","keys_url":"https://api.github.com/repos/akariv/openspending-migrate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akariv/openspending-migrate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akariv/openspending-migrate/teams","hooks_url":"https://api.github.com/repos/akariv/openspending-migrate/hooks","issue_events_url":"https://api.github.com/repos/akariv/openspending-migrate/issues/events{/number}","events_url":"https://api.github.com/repos/akariv/openspending-migrate/events","assignees_url":"https://api.github.com/repos/akariv/openspending-migrate/assignees{/user}","branches_url":"https://api.github.com/repos/akariv/openspending-migrate/branches{/branch}","tags_url":"https://api.github.com/repos/akariv/openspending-migrate/tags","blobs_url":"https://api.github.com/repos/akariv/openspending-migrate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akariv/openspending-migrate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akariv/openspending-migrate/git/refs{/sha}","trees_url":"https://api.github.com/repos/akariv/openspending-migrate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akariv/openspending-migrate/statuses/{sha}","languages_url":"https://api.github.com/repos/akariv/openspending-migrate/languages","stargazers_url":"https://api.github.com/repos/akariv/openspending-migrate/stargazers","contributors_url":"https://api.github.com/repos/akariv/openspending-migrate/contributors","subscribers_url":"https://api.github.com/repos/akariv/openspending-migrate/subscribers","subscription_url":"https://api.github.com/repos/akariv/openspending-migrate/subscription","commits_url":"https://api.github.com/repos/akariv/openspending-migrate/commits{/sha}","git_commits_url":"https://api.github.com/repos/akariv/openspending-migrate/git/commits{/sha}","comments_url":"https://api.github.com/repos/akariv/openspending-migrate/comments{/number}","issue_comment_url":"https://api.github.com/repos/akariv/openspending-migrate/issues/comments{/number}","contents_url":"https://api.github.com/repos/akariv/openspending-migrate/contents/{+path}","compare_url":"https://api.github.com/repos/akariv/openspending-migrate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akariv/openspending-migrate/merges","archive_url":"https://api.github.com/repos/akariv/openspending-migrate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akariv/openspending-migrate/downloads","issues_url":"https://api.github.com/repos/akariv/openspending-migrate/issues{/number}","pulls_url":"https://api.github.com/repos/akariv/openspending-migrate/pulls{/number}","milestones_url":"https://api.github.com/repos/akariv/openspending-migrate/milestones{/number}","notifications_url":"https://api.github.com/repos/akariv/openspending-migrate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akariv/openspending-migrate/labels{/name}","releases_url":"https://api.github.com/repos/akariv/openspending-migrate/releases{/id}","created_at":"2015-12-24T11:33:57Z","updated_at":"2015-12-24T11:33:59Z","pushed_at":"2015-12-24T12:03:04Z","git_url":"git://github.com/akariv/openspending-migrate.git","ssh_url":"git@github.com:akariv/openspending-migrate.git","clone_url":"https://github.com/akariv/openspending-migrate.git","svn_url":"https://github.com/akariv/openspending-migrate","homepage":null,"size":12872,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openspending:master","ref":"master","sha":"065fd3b7c6bb800f2e38b2aa0223d5ad3f1dee2f","user":{"login":"openspending","id":1392301,"avatar_url":"https://avatars.githubusercontent.com/u/1392301?v=3","gravatar_id":"","url":"https://api.github.com/users/openspending","html_url":"https://github.com/openspending","followers_url":"https://api.github.com/users/openspending/followers","following_url":"https://api.github.com/users/openspending/following{/other_user}","gists_url":"https://api.github.com/users/openspending/gists{/gist_id}","starred_url":"https://api.github.com/users/openspending/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openspending/subscriptions","organizations_url":"https://api.github.com/users/openspending/orgs","repos_url":"https://api.github.com/users/openspending/repos","events_url":"https://api.github.com/users/openspending/events{/privacy}","received_events_url":"https://api.github.com/users/openspending/received_events","type":"Organization","site_admin":false},"repo":{"id":48029532,"name":"openspending-migrate","full_name":"openspending/openspending-migrate","owner":{"login":"openspending","id":1392301,"avatar_url":"https://avatars.githubusercontent.com/u/1392301?v=3","gravatar_id":"","url":"https://api.github.com/users/openspending","html_url":"https://github.com/openspending","followers_url":"https://api.github.com/users/openspending/followers","following_url":"https://api.github.com/users/openspending/following{/other_user}","gists_url":"https://api.github.com/users/openspending/gists{/gist_id}","starred_url":"https://api.github.com/users/openspending/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openspending/subscriptions","organizations_url":"https://api.github.com/users/openspending/orgs","repos_url":"https://api.github.com/users/openspending/repos","events_url":"https://api.github.com/users/openspending/events{/privacy}","received_events_url":"https://api.github.com/users/openspending/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openspending/openspending-migrate","description":"","fork":false,"url":"https://api.github.com/repos/openspending/openspending-migrate","forks_url":"https://api.github.com/repos/openspending/openspending-migrate/forks","keys_url":"https://api.github.com/repos/openspending/openspending-migrate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openspending/openspending-migrate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openspending/openspending-migrate/teams","hooks_url":"https://api.github.com/repos/openspending/openspending-migrate/hooks","issue_events_url":"https://api.github.com/repos/openspending/openspending-migrate/issues/events{/number}","events_url":"https://api.github.com/repos/openspending/openspending-migrate/events","assignees_url":"https://api.github.com/repos/openspending/openspending-migrate/assignees{/user}","branches_url":"https://api.github.com/repos/openspending/openspending-migrate/branches{/branch}","tags_url":"https://api.github.com/repos/openspending/openspending-migrate/tags","blobs_url":"https://api.github.com/repos/openspending/openspending-migrate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openspending/openspending-migrate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openspending/openspending-migrate/git/refs{/sha}","trees_url":"https://api.github.com/repos/openspending/openspending-migrate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openspending/openspending-migrate/statuses/{sha}","languages_url":"https://api.github.com/repos/openspending/openspending-migrate/languages","stargazers_url":"https://api.github.com/repos/openspending/openspending-migrate/stargazers","contributors_url":"https://api.github.com/repos/openspending/openspending-migrate/contributors","subscribers_url":"https://api.github.com/repos/openspending/openspending-migrate/subscribers","subscription_url":"https://api.github.com/repos/openspending/openspending-migrate/subscription","commits_url":"https://api.github.com/repos/openspending/openspending-migrate/commits{/sha}","git_commits_url":"https://api.github.com/repos/openspending/openspending-migrate/git/commits{/sha}","comments_url":"https://api.github.com/repos/openspending/openspending-migrate/comments{/number}","issue_comment_url":"https://api.github.com/repos/openspending/openspending-migrate/issues/comments{/number}","contents_url":"https://api.github.com/repos/openspending/openspending-migrate/contents/{+path}","compare_url":"https://api.github.com/repos/openspending/openspending-migrate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openspending/openspending-migrate/merges","archive_url":"https://api.github.com/repos/openspending/openspending-migrate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openspending/openspending-migrate/downloads","issues_url":"https://api.github.com/repos/openspending/openspending-migrate/issues{/number}","pulls_url":"https://api.github.com/repos/openspending/openspending-migrate/pulls{/number}","milestones_url":"https://api.github.com/repos/openspending/openspending-migrate/milestones{/number}","notifications_url":"https://api.github.com/repos/openspending/openspending-migrate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openspending/openspending-migrate/labels{/name}","releases_url":"https://api.github.com/repos/openspending/openspending-migrate/releases{/id}","created_at":"2015-12-15T08:25:14Z","updated_at":"2015-12-16T11:56:08Z","pushed_at":"2015-12-28T15:09:45Z","git_url":"git://github.com/openspending/openspending-migrate.git","ssh_url":"git@github.com:openspending/openspending-migrate.git","clone_url":"https://github.com/openspending/openspending-migrate.git","svn_url":"https://github.com/openspending/openspending-migrate","homepage":null,"size":12871,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openspending/openspending-migrate/pulls/6"},"html":{"href":"https://github.com/openspending/openspending-migrate/pull/6"},"issue":{"href":"https://api.github.com/repos/openspending/openspending-migrate/issues/6"},"comments":{"href":"https://api.github.com/repos/openspending/openspending-migrate/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/openspending/openspending-migrate/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/openspending/openspending-migrate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openspending/openspending-migrate/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/openspending/openspending-migrate/statuses/ea7c3f788c103359fae63f35438d1772c7245b33"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"danfowler","id":772616,"avatar_url":"https://avatars.githubusercontent.com/u/772616?v=3","gravatar_id":"","url":"https://api.github.com/users/danfowler","html_url":"https://github.com/danfowler","followers_url":"https://api.github.com/users/danfowler/followers","following_url":"https://api.github.com/users/danfowler/following{/other_user}","gists_url":"https://api.github.com/users/danfowler/gists{/gist_id}","starred_url":"https://api.github.com/users/danfowler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danfowler/subscriptions","organizations_url":"https://api.github.com/users/danfowler/orgs","repos_url":"https://api.github.com/users/danfowler/repos","events_url":"https://api.github.com/users/danfowler/events{/privacy}","received_events_url":"https://api.github.com/users/danfowler/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}