{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-myriad/pulls/comments/43793300","id":43793300,"diff_hunk":"@@ -1,6 +1,6 @@\n-#Wed Jun 10 10:58:12 CDT 2015\n+#Wed Oct 28 13:11:41 EDT 2015\n distributionBase=GRADLE_USER_HOME\n distributionPath=wrapper/dists\n zipStoreBase=GRADLE_USER_HOME\n zipStorePath=wrapper/dists\n-distributionUrl=https\\://services.gradle.org/distributions/gradle-2.4-bin.zip\n+distributionUrl=https\\://services.gradle.org/distributions/gradle-2.4-all.zip","path":"gradle/wrapper/gradle-wrapper.properties","position":8,"original_position":8,"commit_id":"022fec765c2ec598bb142c8022f73f1ceb2134da","original_commit_id":"022fec765c2ec598bb142c8022f73f1ceb2134da","user":{"login":"DarinJ","id":6180638,"avatar_url":"https://avatars.githubusercontent.com/u/6180638?v=3","gravatar_id":"","url":"https://api.github.com/users/DarinJ","html_url":"https://github.com/DarinJ","followers_url":"https://api.github.com/users/DarinJ/followers","following_url":"https://api.github.com/users/DarinJ/following{/other_user}","gists_url":"https://api.github.com/users/DarinJ/gists{/gist_id}","starred_url":"https://api.github.com/users/DarinJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarinJ/subscriptions","organizations_url":"https://api.github.com/users/DarinJ/orgs","repos_url":"https://api.github.com/users/DarinJ/repos","events_url":"https://api.github.com/users/DarinJ/events{/privacy}","received_events_url":"https://api.github.com/users/DarinJ/received_events","type":"User","site_admin":false},"body":"yeah happens everytime, I usually fix it prior. Will fix.","created_at":"2015-11-03T19:18:47Z","updated_at":"2015-11-03T19:18:47Z","html_url":"https://github.com/apache/incubator-myriad/pull/32#discussion_r43793300","pull_request_url":"https://api.github.com/repos/apache/incubator-myriad/pulls/32","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-myriad/pulls/comments/43793300"},"html":{"href":"https://github.com/apache/incubator-myriad/pull/32#discussion_r43793300"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-myriad/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-myriad/pulls/32","id":49437553,"html_url":"https://github.com/apache/incubator-myriad/pull/32","diff_url":"https://github.com/apache/incubator-myriad/pull/32.diff","patch_url":"https://github.com/apache/incubator-myriad/pull/32.patch","issue_url":"https://api.github.com/repos/apache/incubator-myriad/issues/32","number":32,"state":"open","locked":false,"title":"MYRIAD-162","user":{"login":"DarinJ","id":6180638,"avatar_url":"https://avatars.githubusercontent.com/u/6180638?v=3","gravatar_id":"","url":"https://api.github.com/users/DarinJ","html_url":"https://github.com/DarinJ","followers_url":"https://api.github.com/users/DarinJ/followers","following_url":"https://api.github.com/users/DarinJ/following{/other_user}","gists_url":"https://api.github.com/users/DarinJ/gists{/gist_id}","starred_url":"https://api.github.com/users/DarinJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarinJ/subscriptions","organizations_url":"https://api.github.com/users/DarinJ/orgs","repos_url":"https://api.github.com/users/DarinJ/repos","events_url":"https://api.github.com/users/DarinJ/events{/privacy}","received_events_url":"https://api.github.com/users/DarinJ/received_events","type":"User","site_admin":false},"body":"This corrects how offers are handled when using the framework role parameter.  Prior to this fix if Myriad received an offer with resource from the default role and it's declared role it incorrectly declared all cpu and memory as used by the default role.  This let to TASK_LOST errors, which the logs stated were a result of insufficient resources.\r\n\r\nTested on a cluster with a variety of different agent configurations, which required the use of cpus and mem resources from both the default (\"*\") and frameworkRole (\"roleA\").  Verified correct behavior for both coarse and fine grained scaling.\r\n\r\nNB: This PR does not fix the issue for the ports resource and explicitly forces Myriad the use the default (\"*\") role for ports.  I believe there is potential to use reserved port for a role to help Myriad, but that would require more changes and be more of a improvement than bug-fix, hence is to be future work.\r\n\r\nI would like to squash commits and clean up formatting before merge, but I thought I'd submit the PR now to solicit comments.","created_at":"2015-11-02T14:31:23Z","updated_at":"2015-11-03T19:18:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0b62c82d53173aa469445d46ec3c618d046a0be","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-myriad/pulls/32/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-myriad/pulls/32/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-myriad/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-myriad/issues/32/comments","statuses_url":"https://api.github.com/repos/apache/incubator-myriad/statuses/022fec765c2ec598bb142c8022f73f1ceb2134da","head":{"label":"DarinJ:master","ref":"master","sha":"022fec765c2ec598bb142c8022f73f1ceb2134da","user":{"login":"DarinJ","id":6180638,"avatar_url":"https://avatars.githubusercontent.com/u/6180638?v=3","gravatar_id":"","url":"https://api.github.com/users/DarinJ","html_url":"https://github.com/DarinJ","followers_url":"https://api.github.com/users/DarinJ/followers","following_url":"https://api.github.com/users/DarinJ/following{/other_user}","gists_url":"https://api.github.com/users/DarinJ/gists{/gist_id}","starred_url":"https://api.github.com/users/DarinJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarinJ/subscriptions","organizations_url":"https://api.github.com/users/DarinJ/orgs","repos_url":"https://api.github.com/users/DarinJ/repos","events_url":"https://api.github.com/users/DarinJ/events{/privacy}","received_events_url":"https://api.github.com/users/DarinJ/received_events","type":"User","site_admin":false},"repo":{"id":43473289,"name":"incubator-myriad","full_name":"DarinJ/incubator-myriad","owner":{"login":"DarinJ","id":6180638,"avatar_url":"https://avatars.githubusercontent.com/u/6180638?v=3","gravatar_id":"","url":"https://api.github.com/users/DarinJ","html_url":"https://github.com/DarinJ","followers_url":"https://api.github.com/users/DarinJ/followers","following_url":"https://api.github.com/users/DarinJ/following{/other_user}","gists_url":"https://api.github.com/users/DarinJ/gists{/gist_id}","starred_url":"https://api.github.com/users/DarinJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarinJ/subscriptions","organizations_url":"https://api.github.com/users/DarinJ/orgs","repos_url":"https://api.github.com/users/DarinJ/repos","events_url":"https://api.github.com/users/DarinJ/events{/privacy}","received_events_url":"https://api.github.com/users/DarinJ/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DarinJ/incubator-myriad","description":"Mirror of Apache Myriad (Incubating)","fork":true,"url":"https://api.github.com/repos/DarinJ/incubator-myriad","forks_url":"https://api.github.com/repos/DarinJ/incubator-myriad/forks","keys_url":"https://api.github.com/repos/DarinJ/incubator-myriad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DarinJ/incubator-myriad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DarinJ/incubator-myriad/teams","hooks_url":"https://api.github.com/repos/DarinJ/incubator-myriad/hooks","issue_events_url":"https://api.github.com/repos/DarinJ/incubator-myriad/issues/events{/number}","events_url":"https://api.github.com/repos/DarinJ/incubator-myriad/events","assignees_url":"https://api.github.com/repos/DarinJ/incubator-myriad/assignees{/user}","branches_url":"https://api.github.com/repos/DarinJ/incubator-myriad/branches{/branch}","tags_url":"https://api.github.com/repos/DarinJ/incubator-myriad/tags","blobs_url":"https://api.github.com/repos/DarinJ/incubator-myriad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DarinJ/incubator-myriad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DarinJ/incubator-myriad/git/refs{/sha}","trees_url":"https://api.github.com/repos/DarinJ/incubator-myriad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DarinJ/incubator-myriad/statuses/{sha}","languages_url":"https://api.github.com/repos/DarinJ/incubator-myriad/languages","stargazers_url":"https://api.github.com/repos/DarinJ/incubator-myriad/stargazers","contributors_url":"https://api.github.com/repos/DarinJ/incubator-myriad/contributors","subscribers_url":"https://api.github.com/repos/DarinJ/incubator-myriad/subscribers","subscription_url":"https://api.github.com/repos/DarinJ/incubator-myriad/subscription","commits_url":"https://api.github.com/repos/DarinJ/incubator-myriad/commits{/sha}","git_commits_url":"https://api.github.com/repos/DarinJ/incubator-myriad/git/commits{/sha}","comments_url":"https://api.github.com/repos/DarinJ/incubator-myriad/comments{/number}","issue_comment_url":"https://api.github.com/repos/DarinJ/incubator-myriad/issues/comments{/number}","contents_url":"https://api.github.com/repos/DarinJ/incubator-myriad/contents/{+path}","compare_url":"https://api.github.com/repos/DarinJ/incubator-myriad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DarinJ/incubator-myriad/merges","archive_url":"https://api.github.com/repos/DarinJ/incubator-myriad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DarinJ/incubator-myriad/downloads","issues_url":"https://api.github.com/repos/DarinJ/incubator-myriad/issues{/number}","pulls_url":"https://api.github.com/repos/DarinJ/incubator-myriad/pulls{/number}","milestones_url":"https://api.github.com/repos/DarinJ/incubator-myriad/milestones{/number}","notifications_url":"https://api.github.com/repos/DarinJ/incubator-myriad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DarinJ/incubator-myriad/labels{/name}","releases_url":"https://api.github.com/repos/DarinJ/incubator-myriad/releases{/id}","created_at":"2015-10-01T01:51:43Z","updated_at":"2015-10-01T01:51:44Z","pushed_at":"2015-11-03T04:00:47Z","git_url":"git://github.com/DarinJ/incubator-myriad.git","ssh_url":"git@github.com:DarinJ/incubator-myriad.git","clone_url":"https://github.com/DarinJ/incubator-myriad.git","svn_url":"https://github.com/DarinJ/incubator-myriad","homepage":null,"size":7231,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"47d90dad7968d208c19455697bf0997cb4a51882","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":33397227,"name":"incubator-myriad","full_name":"apache/incubator-myriad","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-myriad","description":"Mirror of Apache Myriad (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-myriad","forks_url":"https://api.github.com/repos/apache/incubator-myriad/forks","keys_url":"https://api.github.com/repos/apache/incubator-myriad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-myriad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-myriad/teams","hooks_url":"https://api.github.com/repos/apache/incubator-myriad/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-myriad/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-myriad/events","assignees_url":"https://api.github.com/repos/apache/incubator-myriad/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-myriad/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-myriad/tags","blobs_url":"https://api.github.com/repos/apache/incubator-myriad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-myriad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-myriad/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-myriad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-myriad/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-myriad/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-myriad/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-myriad/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-myriad/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-myriad/subscription","commits_url":"https://api.github.com/repos/apache/incubator-myriad/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-myriad/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-myriad/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-myriad/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-myriad/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-myriad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-myriad/merges","archive_url":"https://api.github.com/repos/apache/incubator-myriad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-myriad/downloads","issues_url":"https://api.github.com/repos/apache/incubator-myriad/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-myriad/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-myriad/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-myriad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-myriad/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-myriad/releases{/id}","created_at":"2015-04-04T07:00:05Z","updated_at":"2015-11-02T21:00:37Z","pushed_at":"2015-11-03T04:00:48Z","git_url":"git://github.com/apache/incubator-myriad.git","ssh_url":"git@github.com:apache/incubator-myriad.git","clone_url":"https://github.com/apache/incubator-myriad.git","svn_url":"https://github.com/apache/incubator-myriad","homepage":null,"size":8849,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":"git://git.apache.org/incubator-myriad.git","open_issues_count":7,"forks":12,"open_issues":7,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-myriad/pulls/32"},"html":{"href":"https://github.com/apache/incubator-myriad/pull/32"},"issue":{"href":"https://api.github.com/repos/apache/incubator-myriad/issues/32"},"comments":{"href":"https://api.github.com/repos/apache/incubator-myriad/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-myriad/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-myriad/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-myriad/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-myriad/statuses/022fec765c2ec598bb142c8022f73f1ceb2134da"}}}}