{"action":"created","comment":{"url":"https://api.github.com/repos/MIT-IR/abet/pulls/comments/48273783","id":48273783,"diff_hunk":"@@ -9,9 +9,7 @@ def manage_assessments?\n \n   class Scope < Scope\n     def resolve\n-      Subject.\n-        with_direct_assessments.\n-        where(department_number: user.departments.pluck(:number))\n+      Subject.where(department_number: user.departments.pluck(:number))","path":"app/policies/subject_policy.rb","position":7,"original_position":7,"commit_id":"82c764b35a02e4247ea370a6dd8a95295d3c5d58","original_commit_id":"fd49b4a6c465b5be44c4e89cc0bbf96eb04f533a","user":{"login":"derekprior","id":152152,"avatar_url":"https://avatars.githubusercontent.com/u/152152?v=3","gravatar_id":"","url":"https://api.github.com/users/derekprior","html_url":"https://github.com/derekprior","followers_url":"https://api.github.com/users/derekprior/followers","following_url":"https://api.github.com/users/derekprior/following{/other_user}","gists_url":"https://api.github.com/users/derekprior/gists{/gist_id}","starred_url":"https://api.github.com/users/derekprior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekprior/subscriptions","organizations_url":"https://api.github.com/users/derekprior/orgs","repos_url":"https://api.github.com/users/derekprior/repos","events_url":"https://api.github.com/users/derekprior/events{/privacy}","received_events_url":"https://api.github.com/users/derekprior/received_events","type":"User","site_admin":false},"body":"It should not. I made a corresponding change adding this scope back in to where we need it - the subjects controller.","created_at":"2015-12-22T16:59:41Z","updated_at":"2015-12-22T16:59:41Z","html_url":"https://github.com/MIT-IR/abet/pull/134#discussion_r48273783","pull_request_url":"https://api.github.com/repos/MIT-IR/abet/pulls/134","_links":{"self":{"href":"https://api.github.com/repos/MIT-IR/abet/pulls/comments/48273783"},"html":{"href":"https://github.com/MIT-IR/abet/pull/134#discussion_r48273783"},"pull_request":{"href":"https://api.github.com/repos/MIT-IR/abet/pulls/134"}}},"pull_request":{"url":"https://api.github.com/repos/MIT-IR/abet/pulls/134","id":54390145,"html_url":"https://github.com/MIT-IR/abet/pull/134","diff_url":"https://github.com/MIT-IR/abet/pull/134.diff","patch_url":"https://github.com/MIT-IR/abet/pull/134.patch","issue_url":"https://api.github.com/repos/MIT-IR/abet/issues/134","number":134,"state":"open","locked":false,"title":"Rough in Gradebook Histogram","user":{"login":"derekprior","id":152152,"avatar_url":"https://avatars.githubusercontent.com/u/152152?v=3","gravatar_id":"","url":"https://api.github.com/users/derekprior","html_url":"https://github.com/derekprior","followers_url":"https://api.github.com/users/derekprior/followers","following_url":"https://api.github.com/users/derekprior/following{/other_user}","gists_url":"https://api.github.com/users/derekprior/gists{/gist_id}","starred_url":"https://api.github.com/users/derekprior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekprior/subscriptions","organizations_url":"https://api.github.com/users/derekprior/orgs","repos_url":"https://api.github.com/users/derekprior/repos","events_url":"https://api.github.com/users/derekprior/events{/privacy}","received_events_url":"https://api.github.com/users/derekprior/received_events","type":"User","site_admin":false},"body":"We can assist users in reporting results on a direct assessment by\nallowing them to view the gradebook grade distribution histogram from\nthe gradebook service. This will be particularly helpful to users who do\nnot have access to the gradebook (because it provides personal student\ninformation) but can have access to aggregate grade data for the\npurposes of completing ABET assessments.\n\nThis change works off of local fixtures rather than integrating with the\nactual gradebook service. That will be in the next change.","created_at":"2015-12-22T16:46:22Z","updated_at":"2015-12-22T16:59:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"742062e63b6612535ec7faadddcc0fa9d834b252","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MIT-IR/abet/pulls/134/commits","review_comments_url":"https://api.github.com/repos/MIT-IR/abet/pulls/134/comments","review_comment_url":"https://api.github.com/repos/MIT-IR/abet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MIT-IR/abet/issues/134/comments","statuses_url":"https://api.github.com/repos/MIT-IR/abet/statuses/82c764b35a02e4247ea370a6dd8a95295d3c5d58","head":{"label":"MIT-IR:dp-histograms","ref":"dp-histograms","sha":"82c764b35a02e4247ea370a6dd8a95295d3c5d58","user":{"login":"MIT-IR","id":12716289,"avatar_url":"https://avatars.githubusercontent.com/u/12716289?v=3","gravatar_id":"","url":"https://api.github.com/users/MIT-IR","html_url":"https://github.com/MIT-IR","followers_url":"https://api.github.com/users/MIT-IR/followers","following_url":"https://api.github.com/users/MIT-IR/following{/other_user}","gists_url":"https://api.github.com/users/MIT-IR/gists{/gist_id}","starred_url":"https://api.github.com/users/MIT-IR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MIT-IR/subscriptions","organizations_url":"https://api.github.com/users/MIT-IR/orgs","repos_url":"https://api.github.com/users/MIT-IR/repos","events_url":"https://api.github.com/users/MIT-IR/events{/privacy}","received_events_url":"https://api.github.com/users/MIT-IR/received_events","type":"Organization","site_admin":false},"repo":{"id":36762042,"name":"abet","full_name":"MIT-IR/abet","owner":{"login":"MIT-IR","id":12716289,"avatar_url":"https://avatars.githubusercontent.com/u/12716289?v=3","gravatar_id":"","url":"https://api.github.com/users/MIT-IR","html_url":"https://github.com/MIT-IR","followers_url":"https://api.github.com/users/MIT-IR/followers","following_url":"https://api.github.com/users/MIT-IR/following{/other_user}","gists_url":"https://api.github.com/users/MIT-IR/gists{/gist_id}","starred_url":"https://api.github.com/users/MIT-IR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MIT-IR/subscriptions","organizations_url":"https://api.github.com/users/MIT-IR/orgs","repos_url":"https://api.github.com/users/MIT-IR/repos","events_url":"https://api.github.com/users/MIT-IR/events{/privacy}","received_events_url":"https://api.github.com/users/MIT-IR/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MIT-IR/abet","description":"ABET outcomes assessment","fork":false,"url":"https://api.github.com/repos/MIT-IR/abet","forks_url":"https://api.github.com/repos/MIT-IR/abet/forks","keys_url":"https://api.github.com/repos/MIT-IR/abet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MIT-IR/abet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MIT-IR/abet/teams","hooks_url":"https://api.github.com/repos/MIT-IR/abet/hooks","issue_events_url":"https://api.github.com/repos/MIT-IR/abet/issues/events{/number}","events_url":"https://api.github.com/repos/MIT-IR/abet/events","assignees_url":"https://api.github.com/repos/MIT-IR/abet/assignees{/user}","branches_url":"https://api.github.com/repos/MIT-IR/abet/branches{/branch}","tags_url":"https://api.github.com/repos/MIT-IR/abet/tags","blobs_url":"https://api.github.com/repos/MIT-IR/abet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MIT-IR/abet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MIT-IR/abet/git/refs{/sha}","trees_url":"https://api.github.com/repos/MIT-IR/abet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MIT-IR/abet/statuses/{sha}","languages_url":"https://api.github.com/repos/MIT-IR/abet/languages","stargazers_url":"https://api.github.com/repos/MIT-IR/abet/stargazers","contributors_url":"https://api.github.com/repos/MIT-IR/abet/contributors","subscribers_url":"https://api.github.com/repos/MIT-IR/abet/subscribers","subscription_url":"https://api.github.com/repos/MIT-IR/abet/subscription","commits_url":"https://api.github.com/repos/MIT-IR/abet/commits{/sha}","git_commits_url":"https://api.github.com/repos/MIT-IR/abet/git/commits{/sha}","comments_url":"https://api.github.com/repos/MIT-IR/abet/comments{/number}","issue_comment_url":"https://api.github.com/repos/MIT-IR/abet/issues/comments{/number}","contents_url":"https://api.github.com/repos/MIT-IR/abet/contents/{+path}","compare_url":"https://api.github.com/repos/MIT-IR/abet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MIT-IR/abet/merges","archive_url":"https://api.github.com/repos/MIT-IR/abet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MIT-IR/abet/downloads","issues_url":"https://api.github.com/repos/MIT-IR/abet/issues{/number}","pulls_url":"https://api.github.com/repos/MIT-IR/abet/pulls{/number}","milestones_url":"https://api.github.com/repos/MIT-IR/abet/milestones{/number}","notifications_url":"https://api.github.com/repos/MIT-IR/abet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MIT-IR/abet/labels{/name}","releases_url":"https://api.github.com/repos/MIT-IR/abet/releases{/id}","created_at":"2015-06-02T21:09:57Z","updated_at":"2015-06-02T21:13:53Z","pushed_at":"2015-12-22T16:57:09Z","git_url":"git://github.com/MIT-IR/abet.git","ssh_url":"git@github.com:MIT-IR/abet.git","clone_url":"https://github.com/MIT-IR/abet.git","svn_url":"https://github.com/MIT-IR/abet","homepage":null,"size":1423,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"MIT-IR:master","ref":"master","sha":"6c90e718b3c89b3497cfce7719201223fb825b9a","user":{"login":"MIT-IR","id":12716289,"avatar_url":"https://avatars.githubusercontent.com/u/12716289?v=3","gravatar_id":"","url":"https://api.github.com/users/MIT-IR","html_url":"https://github.com/MIT-IR","followers_url":"https://api.github.com/users/MIT-IR/followers","following_url":"https://api.github.com/users/MIT-IR/following{/other_user}","gists_url":"https://api.github.com/users/MIT-IR/gists{/gist_id}","starred_url":"https://api.github.com/users/MIT-IR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MIT-IR/subscriptions","organizations_url":"https://api.github.com/users/MIT-IR/orgs","repos_url":"https://api.github.com/users/MIT-IR/repos","events_url":"https://api.github.com/users/MIT-IR/events{/privacy}","received_events_url":"https://api.github.com/users/MIT-IR/received_events","type":"Organization","site_admin":false},"repo":{"id":36762042,"name":"abet","full_name":"MIT-IR/abet","owner":{"login":"MIT-IR","id":12716289,"avatar_url":"https://avatars.githubusercontent.com/u/12716289?v=3","gravatar_id":"","url":"https://api.github.com/users/MIT-IR","html_url":"https://github.com/MIT-IR","followers_url":"https://api.github.com/users/MIT-IR/followers","following_url":"https://api.github.com/users/MIT-IR/following{/other_user}","gists_url":"https://api.github.com/users/MIT-IR/gists{/gist_id}","starred_url":"https://api.github.com/users/MIT-IR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MIT-IR/subscriptions","organizations_url":"https://api.github.com/users/MIT-IR/orgs","repos_url":"https://api.github.com/users/MIT-IR/repos","events_url":"https://api.github.com/users/MIT-IR/events{/privacy}","received_events_url":"https://api.github.com/users/MIT-IR/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MIT-IR/abet","description":"ABET outcomes assessment","fork":false,"url":"https://api.github.com/repos/MIT-IR/abet","forks_url":"https://api.github.com/repos/MIT-IR/abet/forks","keys_url":"https://api.github.com/repos/MIT-IR/abet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MIT-IR/abet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MIT-IR/abet/teams","hooks_url":"https://api.github.com/repos/MIT-IR/abet/hooks","issue_events_url":"https://api.github.com/repos/MIT-IR/abet/issues/events{/number}","events_url":"https://api.github.com/repos/MIT-IR/abet/events","assignees_url":"https://api.github.com/repos/MIT-IR/abet/assignees{/user}","branches_url":"https://api.github.com/repos/MIT-IR/abet/branches{/branch}","tags_url":"https://api.github.com/repos/MIT-IR/abet/tags","blobs_url":"https://api.github.com/repos/MIT-IR/abet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MIT-IR/abet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MIT-IR/abet/git/refs{/sha}","trees_url":"https://api.github.com/repos/MIT-IR/abet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MIT-IR/abet/statuses/{sha}","languages_url":"https://api.github.com/repos/MIT-IR/abet/languages","stargazers_url":"https://api.github.com/repos/MIT-IR/abet/stargazers","contributors_url":"https://api.github.com/repos/MIT-IR/abet/contributors","subscribers_url":"https://api.github.com/repos/MIT-IR/abet/subscribers","subscription_url":"https://api.github.com/repos/MIT-IR/abet/subscription","commits_url":"https://api.github.com/repos/MIT-IR/abet/commits{/sha}","git_commits_url":"https://api.github.com/repos/MIT-IR/abet/git/commits{/sha}","comments_url":"https://api.github.com/repos/MIT-IR/abet/comments{/number}","issue_comment_url":"https://api.github.com/repos/MIT-IR/abet/issues/comments{/number}","contents_url":"https://api.github.com/repos/MIT-IR/abet/contents/{+path}","compare_url":"https://api.github.com/repos/MIT-IR/abet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MIT-IR/abet/merges","archive_url":"https://api.github.com/repos/MIT-IR/abet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MIT-IR/abet/downloads","issues_url":"https://api.github.com/repos/MIT-IR/abet/issues{/number}","pulls_url":"https://api.github.com/repos/MIT-IR/abet/pulls{/number}","milestones_url":"https://api.github.com/repos/MIT-IR/abet/milestones{/number}","notifications_url":"https://api.github.com/repos/MIT-IR/abet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MIT-IR/abet/labels{/name}","releases_url":"https://api.github.com/repos/MIT-IR/abet/releases{/id}","created_at":"2015-06-02T21:09:57Z","updated_at":"2015-06-02T21:13:53Z","pushed_at":"2015-12-22T16:57:09Z","git_url":"git://github.com/MIT-IR/abet.git","ssh_url":"git@github.com:MIT-IR/abet.git","clone_url":"https://github.com/MIT-IR/abet.git","svn_url":"https://github.com/MIT-IR/abet","homepage":null,"size":1423,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MIT-IR/abet/pulls/134"},"html":{"href":"https://github.com/MIT-IR/abet/pull/134"},"issue":{"href":"https://api.github.com/repos/MIT-IR/abet/issues/134"},"comments":{"href":"https://api.github.com/repos/MIT-IR/abet/issues/134/comments"},"review_comments":{"href":"https://api.github.com/repos/MIT-IR/abet/pulls/134/comments"},"review_comment":{"href":"https://api.github.com/repos/MIT-IR/abet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MIT-IR/abet/pulls/134/commits"},"statuses":{"href":"https://api.github.com/repos/MIT-IR/abet/statuses/82c764b35a02e4247ea370a6dd8a95295d3c5d58"}}}}