{"action":"created","issue":{"url":"https://api.github.com/repos/Qabel/qabel-core/issues/269","labels_url":"https://api.github.com/repos/Qabel/qabel-core/issues/269/labels{/name}","comments_url":"https://api.github.com/repos/Qabel/qabel-core/issues/269/comments","events_url":"https://api.github.com/repos/Qabel/qabel-core/issues/269/events","html_url":"https://github.com/Qabel/qabel-core/pull/269","id":56164265,"number":269,"title":"Refactored Drop API","user":{"login":"cburkert","id":122697,"avatar_url":"https://avatars.githubusercontent.com/u/122697?v=3","gravatar_id":"","url":"https://api.github.com/users/cburkert","html_url":"https://github.com/cburkert","followers_url":"https://api.github.com/users/cburkert/followers","following_url":"https://api.github.com/users/cburkert/following{/other_user}","gists_url":"https://api.github.com/users/cburkert/gists{/gist_id}","starred_url":"https://api.github.com/users/cburkert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cburkert/subscriptions","organizations_url":"https://api.github.com/users/cburkert/orgs","repos_url":"https://api.github.com/users/cburkert/repos","events_url":"https://api.github.com/users/cburkert/events{/privacy}","received_events_url":"https://api.github.com/users/cburkert/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"cburkert","id":122697,"avatar_url":"https://avatars.githubusercontent.com/u/122697?v=3","gravatar_id":"","url":"https://api.github.com/users/cburkert","html_url":"https://github.com/cburkert","followers_url":"https://api.github.com/users/cburkert/followers","following_url":"https://api.github.com/users/cburkert/following{/other_user}","gists_url":"https://api.github.com/users/cburkert/gists{/gist_id}","starred_url":"https://api.github.com/users/cburkert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cburkert/subscriptions","organizations_url":"https://api.github.com/users/cburkert/orgs","repos_url":"https://api.github.com/users/cburkert/repos","events_url":"https://api.github.com/users/cburkert/events{/privacy}","received_events_url":"https://api.github.com/users/cburkert/received_events","type":"User","site_admin":false},"milestone":null,"comments":7,"created_at":"2015-02-01T13:57:32Z","updated_at":"2015-02-06T14:02:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Qabel/qabel-core/pulls/269","html_url":"https://github.com/Qabel/qabel-core/pull/269","diff_url":"https://github.com/Qabel/qabel-core/pull/269.diff","patch_url":"https://github.com/Qabel/qabel-core/pull/269.patch"},"body":"I refactored drop API with particular focus on\r\n* use model classes instead of serialization representations wherever possible\r\n* make DropMessage construction easier\r\n\r\nThis PR\r\n* introduces a abstraction layer called Entity above Contact and Identity that contains common properties like drops, public key getters\r\n* introduces an general mapper for Entity lookups by key identifier and uses it for Contacts and Identites\r\n* implements acknowledge ID generation using UUIDv4\r\n* implements detection of spoofed sender information in DropMessages\r\n* complains about unexpected drop message version by throwing parser exception instead of treating the version field like a meaningless field\r\n\r\nCloses #247 \r\n\r\nEDIT: Added version checking \"functionality\" description"},"comment":{"url":"https://api.github.com/repos/Qabel/qabel-core/issues/comments/73240291","html_url":"https://github.com/Qabel/qabel-core/pull/269#issuecomment-73240291","issue_url":"https://api.github.com/repos/Qabel/qabel-core/issues/269","id":73240291,"user":{"login":"cburkert","id":122697,"avatar_url":"https://avatars.githubusercontent.com/u/122697?v=3","gravatar_id":"","url":"https://api.github.com/users/cburkert","html_url":"https://github.com/cburkert","followers_url":"https://api.github.com/users/cburkert/followers","following_url":"https://api.github.com/users/cburkert/following{/other_user}","gists_url":"https://api.github.com/users/cburkert/gists{/gist_id}","starred_url":"https://api.github.com/users/cburkert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cburkert/subscriptions","organizations_url":"https://api.github.com/users/cburkert/orgs","repos_url":"https://api.github.com/users/cburkert/repos","events_url":"https://api.github.com/users/cburkert/events{/privacy}","received_events_url":"https://api.github.com/users/cburkert/received_events","type":"User","site_admin":false},"created_at":"2015-02-06T14:02:49Z","updated_at":"2015-02-06T14:02:49Z","body":"By the way, this PR is ready for merging again."}}