{"action":"created","comment":{"url":"https://api.github.com/repos/square/spoon/pulls/comments/24201141","id":24201141,"diff_hunk":"@@ -138,7 +140,6 @@ private void printStream(InputStream stream, String tag) throws IOException {\n \n   /** Execute instrumentation on the target device and return a result summary. */\n   public DeviceResult run(AndroidDebugBridge adb) {","path":"spoon-runner/src/main/java/com/squareup/spoon/SpoonDeviceRunner.java","position":35,"original_position":35,"commit_id":"7ea19b1ba8324fdff0a751b6147d365ef418145a","original_commit_id":"7ea19b1ba8324fdff0a751b6147d365ef418145a","user":{"login":"f2prateek","id":843979,"avatar_url":"https://avatars.githubusercontent.com/u/843979?v=3","gravatar_id":"","url":"https://api.github.com/users/f2prateek","html_url":"https://github.com/f2prateek","followers_url":"https://api.github.com/users/f2prateek/followers","following_url":"https://api.github.com/users/f2prateek/following{/other_user}","gists_url":"https://api.github.com/users/f2prateek/gists{/gist_id}","starred_url":"https://api.github.com/users/f2prateek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/f2prateek/subscriptions","organizations_url":"https://api.github.com/users/f2prateek/orgs","repos_url":"https://api.github.com/users/f2prateek/repos","events_url":"https://api.github.com/users/f2prateek/events{/privacy}","received_events_url":"https://api.github.com/users/f2prateek/received_events","type":"User","site_admin":false},"body":"The checkstyle error is form here - you'll ned to break this method apart into more sub-methods to reduce it's size.","created_at":"2015-02-05T21:27:09Z","updated_at":"2015-02-05T21:27:09Z","html_url":"https://github.com/square/spoon/pull/227#discussion_r24201141","pull_request_url":"https://api.github.com/repos/square/spoon/pulls/227","_links":{"self":{"href":"https://api.github.com/repos/square/spoon/pulls/comments/24201141"},"html":{"href":"https://github.com/square/spoon/pull/227#discussion_r24201141"},"pull_request":{"href":"https://api.github.com/repos/square/spoon/pulls/227"}}},"pull_request":{"url":"https://api.github.com/repos/square/spoon/pulls/227","id":28756600,"html_url":"https://github.com/square/spoon/pull/227","diff_url":"https://github.com/square/spoon/pull/227.diff","patch_url":"https://github.com/square/spoon/pull/227.patch","issue_url":"https://api.github.com/repos/square/spoon/issues/227","number":227,"state":"open","locked":false,"title":"Updated screenshot transfer for Lollipop.","user":{"login":"joe-engel","id":5127704,"avatar_url":"https://avatars.githubusercontent.com/u/5127704?v=3","gravatar_id":"","url":"https://api.github.com/users/joe-engel","html_url":"https://github.com/joe-engel","followers_url":"https://api.github.com/users/joe-engel/followers","following_url":"https://api.github.com/users/joe-engel/following{/other_user}","gists_url":"https://api.github.com/users/joe-engel/gists{/gist_id}","starred_url":"https://api.github.com/users/joe-engel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joe-engel/subscriptions","organizations_url":"https://api.github.com/users/joe-engel/orgs","repos_url":"https://api.github.com/users/joe-engel/repos","events_url":"https://api.github.com/users/joe-engel/events{/privacy}","received_events_url":"https://api.github.com/users/joe-engel/received_events","type":"User","site_admin":false},"body":"These changes address issue #189\r\n\r\nhttps://github.com/square/spoon/issues/189\r\n\r\nSpoon now saves screenshots in a folder \"spoon-screenshots\" inside the shared external storage directory. It uses Environment.getExternalStorageDirectory()\r\n\r\nSpoonDeviceRunner calls \"echo $EXTERNAL_STORAGE\" in the ADB shell to dynamically detect the path, as this path will be different on each device.\r\n\r\nAlso, dimensions of the screenshots are increased slightly to capture content underneath transparent status or nav bars. It gets width and height from activity.getWindow().getDecorView()\r\n","created_at":"2015-02-05T20:06:05Z","updated_at":"2015-02-05T21:27:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7e4bd7f1e595faf662bb88e67ef13c72795a8dd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/square/spoon/pulls/227/commits","review_comments_url":"https://api.github.com/repos/square/spoon/pulls/227/comments","review_comment_url":"https://api.github.com/repos/square/spoon/pulls/comments/{number}","comments_url":"https://api.github.com/repos/square/spoon/issues/227/comments","statuses_url":"https://api.github.com/repos/square/spoon/statuses/7ea19b1ba8324fdff0a751b6147d365ef418145a","head":{"label":"joe-engel:screenshots-for-lollipop","ref":"screenshots-for-lollipop","sha":"7ea19b1ba8324fdff0a751b6147d365ef418145a","user":{"login":"joe-engel","id":5127704,"avatar_url":"https://avatars.githubusercontent.com/u/5127704?v=3","gravatar_id":"","url":"https://api.github.com/users/joe-engel","html_url":"https://github.com/joe-engel","followers_url":"https://api.github.com/users/joe-engel/followers","following_url":"https://api.github.com/users/joe-engel/following{/other_user}","gists_url":"https://api.github.com/users/joe-engel/gists{/gist_id}","starred_url":"https://api.github.com/users/joe-engel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joe-engel/subscriptions","organizations_url":"https://api.github.com/users/joe-engel/orgs","repos_url":"https://api.github.com/users/joe-engel/repos","events_url":"https://api.github.com/users/joe-engel/events{/privacy}","received_events_url":"https://api.github.com/users/joe-engel/received_events","type":"User","site_admin":false},"repo":{"id":30337044,"name":"spoon","full_name":"joe-engel/spoon","owner":{"login":"joe-engel","id":5127704,"avatar_url":"https://avatars.githubusercontent.com/u/5127704?v=3","gravatar_id":"","url":"https://api.github.com/users/joe-engel","html_url":"https://github.com/joe-engel","followers_url":"https://api.github.com/users/joe-engel/followers","following_url":"https://api.github.com/users/joe-engel/following{/other_user}","gists_url":"https://api.github.com/users/joe-engel/gists{/gist_id}","starred_url":"https://api.github.com/users/joe-engel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joe-engel/subscriptions","organizations_url":"https://api.github.com/users/joe-engel/orgs","repos_url":"https://api.github.com/users/joe-engel/repos","events_url":"https://api.github.com/users/joe-engel/events{/privacy}","received_events_url":"https://api.github.com/users/joe-engel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joe-engel/spoon","description":"Distributing instrumentation tests to all your Androids.","fork":true,"url":"https://api.github.com/repos/joe-engel/spoon","forks_url":"https://api.github.com/repos/joe-engel/spoon/forks","keys_url":"https://api.github.com/repos/joe-engel/spoon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joe-engel/spoon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joe-engel/spoon/teams","hooks_url":"https://api.github.com/repos/joe-engel/spoon/hooks","issue_events_url":"https://api.github.com/repos/joe-engel/spoon/issues/events{/number}","events_url":"https://api.github.com/repos/joe-engel/spoon/events","assignees_url":"https://api.github.com/repos/joe-engel/spoon/assignees{/user}","branches_url":"https://api.github.com/repos/joe-engel/spoon/branches{/branch}","tags_url":"https://api.github.com/repos/joe-engel/spoon/tags","blobs_url":"https://api.github.com/repos/joe-engel/spoon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joe-engel/spoon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joe-engel/spoon/git/refs{/sha}","trees_url":"https://api.github.com/repos/joe-engel/spoon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joe-engel/spoon/statuses/{sha}","languages_url":"https://api.github.com/repos/joe-engel/spoon/languages","stargazers_url":"https://api.github.com/repos/joe-engel/spoon/stargazers","contributors_url":"https://api.github.com/repos/joe-engel/spoon/contributors","subscribers_url":"https://api.github.com/repos/joe-engel/spoon/subscribers","subscription_url":"https://api.github.com/repos/joe-engel/spoon/subscription","commits_url":"https://api.github.com/repos/joe-engel/spoon/commits{/sha}","git_commits_url":"https://api.github.com/repos/joe-engel/spoon/git/commits{/sha}","comments_url":"https://api.github.com/repos/joe-engel/spoon/comments{/number}","issue_comment_url":"https://api.github.com/repos/joe-engel/spoon/issues/comments/{number}","contents_url":"https://api.github.com/repos/joe-engel/spoon/contents/{+path}","compare_url":"https://api.github.com/repos/joe-engel/spoon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joe-engel/spoon/merges","archive_url":"https://api.github.com/repos/joe-engel/spoon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joe-engel/spoon/downloads","issues_url":"https://api.github.com/repos/joe-engel/spoon/issues{/number}","pulls_url":"https://api.github.com/repos/joe-engel/spoon/pulls{/number}","milestones_url":"https://api.github.com/repos/joe-engel/spoon/milestones{/number}","notifications_url":"https://api.github.com/repos/joe-engel/spoon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joe-engel/spoon/labels{/name}","releases_url":"https://api.github.com/repos/joe-engel/spoon/releases{/id}","created_at":"2015-02-05T04:07:02Z","updated_at":"2015-02-05T19:23:48Z","pushed_at":"2015-02-05T21:21:41Z","git_url":"git://github.com/joe-engel/spoon.git","ssh_url":"git@github.com:joe-engel/spoon.git","clone_url":"https://github.com/joe-engel/spoon.git","svn_url":"https://github.com/joe-engel/spoon","homepage":"http://square.github.io/spoon/","size":40893,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"square:master","ref":"master","sha":"2e5d7b437a1098bd7614e31af9bf84162c5f4848","user":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?v=3","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"repo":{"id":7764585,"name":"spoon","full_name":"square/spoon","owner":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?v=3","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/square/spoon","description":"Distributing instrumentation tests to all your Androids.","fork":false,"url":"https://api.github.com/repos/square/spoon","forks_url":"https://api.github.com/repos/square/spoon/forks","keys_url":"https://api.github.com/repos/square/spoon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/square/spoon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/square/spoon/teams","hooks_url":"https://api.github.com/repos/square/spoon/hooks","issue_events_url":"https://api.github.com/repos/square/spoon/issues/events{/number}","events_url":"https://api.github.com/repos/square/spoon/events","assignees_url":"https://api.github.com/repos/square/spoon/assignees{/user}","branches_url":"https://api.github.com/repos/square/spoon/branches{/branch}","tags_url":"https://api.github.com/repos/square/spoon/tags","blobs_url":"https://api.github.com/repos/square/spoon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/square/spoon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/square/spoon/git/refs{/sha}","trees_url":"https://api.github.com/repos/square/spoon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/square/spoon/statuses/{sha}","languages_url":"https://api.github.com/repos/square/spoon/languages","stargazers_url":"https://api.github.com/repos/square/spoon/stargazers","contributors_url":"https://api.github.com/repos/square/spoon/contributors","subscribers_url":"https://api.github.com/repos/square/spoon/subscribers","subscription_url":"https://api.github.com/repos/square/spoon/subscription","commits_url":"https://api.github.com/repos/square/spoon/commits{/sha}","git_commits_url":"https://api.github.com/repos/square/spoon/git/commits{/sha}","comments_url":"https://api.github.com/repos/square/spoon/comments{/number}","issue_comment_url":"https://api.github.com/repos/square/spoon/issues/comments/{number}","contents_url":"https://api.github.com/repos/square/spoon/contents/{+path}","compare_url":"https://api.github.com/repos/square/spoon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/square/spoon/merges","archive_url":"https://api.github.com/repos/square/spoon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/square/spoon/downloads","issues_url":"https://api.github.com/repos/square/spoon/issues{/number}","pulls_url":"https://api.github.com/repos/square/spoon/pulls{/number}","milestones_url":"https://api.github.com/repos/square/spoon/milestones{/number}","notifications_url":"https://api.github.com/repos/square/spoon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/square/spoon/labels{/name}","releases_url":"https://api.github.com/repos/square/spoon/releases{/id}","created_at":"2013-01-23T00:29:36Z","updated_at":"2015-02-05T21:15:00Z","pushed_at":"2015-01-25T09:39:30Z","git_url":"git://github.com/square/spoon.git","ssh_url":"git@github.com:square/spoon.git","clone_url":"https://github.com/square/spoon.git","svn_url":"https://github.com/square/spoon","homepage":"http://square.github.io/spoon/","size":40893,"stargazers_count":949,"watchers_count":949,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":191,"mirror_url":null,"open_issues_count":68,"forks":191,"open_issues":68,"watchers":949,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/square/spoon/pulls/227"},"html":{"href":"https://github.com/square/spoon/pull/227"},"issue":{"href":"https://api.github.com/repos/square/spoon/issues/227"},"comments":{"href":"https://api.github.com/repos/square/spoon/issues/227/comments"},"review_comments":{"href":"https://api.github.com/repos/square/spoon/pulls/227/comments"},"review_comment":{"href":"https://api.github.com/repos/square/spoon/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/square/spoon/pulls/227/commits"},"statuses":{"href":"https://api.github.com/repos/square/spoon/statuses/7ea19b1ba8324fdff0a751b6147d365ef418145a"}}}}