{"action":"opened","number":39,"pull_request":{"url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/pulls/39","id":36036180,"html_url":"https://github.com/saltstack-formulas/collectd-formula/pull/39","diff_url":"https://github.com/saltstack-formulas/collectd-formula/pull/39.diff","patch_url":"https://github.com/saltstack-formulas/collectd-formula/pull/39.patch","issue_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/issues/39","number":39,"state":"open","locked":false,"title":"More fixes","user":{"login":"genuss","id":3119969,"avatar_url":"https://avatars.githubusercontent.com/u/3119969?v=3","gravatar_id":"","url":"https://api.github.com/users/genuss","html_url":"https://github.com/genuss","followers_url":"https://api.github.com/users/genuss/followers","following_url":"https://api.github.com/users/genuss/following{/other_user}","gists_url":"https://api.github.com/users/genuss/gists{/gist_id}","starred_url":"https://api.github.com/users/genuss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genuss/subscriptions","organizations_url":"https://api.github.com/users/genuss/orgs","repos_url":"https://api.github.com/users/genuss/repos","events_url":"https://api.github.com/users/genuss/events{/privacy}","received_events_url":"https://api.github.com/users/genuss/received_events","type":"User","site_admin":false},"body":"What I have done here:\r\n* Added more global configuration parameters.\r\n* I believe hostname should be configurable, although with my patch I stay with backwards-compatible change.\r\n* For df plugin: it should support many Devices.\r\n* Mysql plugin: splitted db.name into two parameters: db.name and db.dbname.\r\nImagine you have two mysql instances on one server. One called ``first`` another: ``second``. Two add them into collectd you should have this kind of config:\r\n```\r\n<Plugin mysql>\r\n    <Database first>\r\n        Host 127.0.0.1\r\n        Port 3306\r\n        Database mysql\r\n    </Database>\r\n    <Database second>\r\n        Host 127.0.0.1\r\n        Port 3306\r\n        Database mysql\r\n    </Database>\r\n</Plugin>\r\n```\r\nWith old state, you couldn't do it.\r\n* Added more default parameters. Without them it will fail now.","created_at":"2015-05-22T14:30:36Z","updated_at":"2015-05-22T14:30:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"355e01f1309bff52752fba0caf28e9740174cb78","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/pulls/39/commits","review_comments_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/pulls/39/comments","review_comment_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/issues/39/comments","statuses_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/statuses/ad4fcb2d59ebd7f94725955f67457decb04d4ad9","head":{"label":"genuss:more-fixes","ref":"more-fixes","sha":"ad4fcb2d59ebd7f94725955f67457decb04d4ad9","user":{"login":"genuss","id":3119969,"avatar_url":"https://avatars.githubusercontent.com/u/3119969?v=3","gravatar_id":"","url":"https://api.github.com/users/genuss","html_url":"https://github.com/genuss","followers_url":"https://api.github.com/users/genuss/followers","following_url":"https://api.github.com/users/genuss/following{/other_user}","gists_url":"https://api.github.com/users/genuss/gists{/gist_id}","starred_url":"https://api.github.com/users/genuss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genuss/subscriptions","organizations_url":"https://api.github.com/users/genuss/orgs","repos_url":"https://api.github.com/users/genuss/repos","events_url":"https://api.github.com/users/genuss/events{/privacy}","received_events_url":"https://api.github.com/users/genuss/received_events","type":"User","site_admin":false},"repo":{"id":35615613,"name":"collectd-formula","full_name":"genuss/collectd-formula","owner":{"login":"genuss","id":3119969,"avatar_url":"https://avatars.githubusercontent.com/u/3119969?v=3","gravatar_id":"","url":"https://api.github.com/users/genuss","html_url":"https://github.com/genuss","followers_url":"https://api.github.com/users/genuss/followers","following_url":"https://api.github.com/users/genuss/following{/other_user}","gists_url":"https://api.github.com/users/genuss/gists{/gist_id}","starred_url":"https://api.github.com/users/genuss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genuss/subscriptions","organizations_url":"https://api.github.com/users/genuss/orgs","repos_url":"https://api.github.com/users/genuss/repos","events_url":"https://api.github.com/users/genuss/events{/privacy}","received_events_url":"https://api.github.com/users/genuss/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/genuss/collectd-formula","description":null,"fork":true,"url":"https://api.github.com/repos/genuss/collectd-formula","forks_url":"https://api.github.com/repos/genuss/collectd-formula/forks","keys_url":"https://api.github.com/repos/genuss/collectd-formula/keys{/key_id}","collaborators_url":"https://api.github.com/repos/genuss/collectd-formula/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/genuss/collectd-formula/teams","hooks_url":"https://api.github.com/repos/genuss/collectd-formula/hooks","issue_events_url":"https://api.github.com/repos/genuss/collectd-formula/issues/events{/number}","events_url":"https://api.github.com/repos/genuss/collectd-formula/events","assignees_url":"https://api.github.com/repos/genuss/collectd-formula/assignees{/user}","branches_url":"https://api.github.com/repos/genuss/collectd-formula/branches{/branch}","tags_url":"https://api.github.com/repos/genuss/collectd-formula/tags","blobs_url":"https://api.github.com/repos/genuss/collectd-formula/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/genuss/collectd-formula/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/genuss/collectd-formula/git/refs{/sha}","trees_url":"https://api.github.com/repos/genuss/collectd-formula/git/trees{/sha}","statuses_url":"https://api.github.com/repos/genuss/collectd-formula/statuses/{sha}","languages_url":"https://api.github.com/repos/genuss/collectd-formula/languages","stargazers_url":"https://api.github.com/repos/genuss/collectd-formula/stargazers","contributors_url":"https://api.github.com/repos/genuss/collectd-formula/contributors","subscribers_url":"https://api.github.com/repos/genuss/collectd-formula/subscribers","subscription_url":"https://api.github.com/repos/genuss/collectd-formula/subscription","commits_url":"https://api.github.com/repos/genuss/collectd-formula/commits{/sha}","git_commits_url":"https://api.github.com/repos/genuss/collectd-formula/git/commits{/sha}","comments_url":"https://api.github.com/repos/genuss/collectd-formula/comments{/number}","issue_comment_url":"https://api.github.com/repos/genuss/collectd-formula/issues/comments{/number}","contents_url":"https://api.github.com/repos/genuss/collectd-formula/contents/{+path}","compare_url":"https://api.github.com/repos/genuss/collectd-formula/compare/{base}...{head}","merges_url":"https://api.github.com/repos/genuss/collectd-formula/merges","archive_url":"https://api.github.com/repos/genuss/collectd-formula/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/genuss/collectd-formula/downloads","issues_url":"https://api.github.com/repos/genuss/collectd-formula/issues{/number}","pulls_url":"https://api.github.com/repos/genuss/collectd-formula/pulls{/number}","milestones_url":"https://api.github.com/repos/genuss/collectd-formula/milestones{/number}","notifications_url":"https://api.github.com/repos/genuss/collectd-formula/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/genuss/collectd-formula/labels{/name}","releases_url":"https://api.github.com/repos/genuss/collectd-formula/releases{/id}","created_at":"2015-05-14T14:25:14Z","updated_at":"2015-05-20T15:45:19Z","pushed_at":"2015-05-22T14:22:26Z","git_url":"git://github.com/genuss/collectd-formula.git","ssh_url":"git@github.com:genuss/collectd-formula.git","clone_url":"https://github.com/genuss/collectd-formula.git","svn_url":"https://github.com/genuss/collectd-formula","homepage":"http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html","size":202,"stargazers_count":0,"watchers_count":0,"language":"SaltStack","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"saltstack-formulas:master","ref":"master","sha":"4eb41cfe6c5e91348582bc6a7192734a34a40959","user":{"login":"saltstack-formulas","id":4683350,"avatar_url":"https://avatars.githubusercontent.com/u/4683350?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack-formulas","html_url":"https://github.com/saltstack-formulas","followers_url":"https://api.github.com/users/saltstack-formulas/followers","following_url":"https://api.github.com/users/saltstack-formulas/following{/other_user}","gists_url":"https://api.github.com/users/saltstack-formulas/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack-formulas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack-formulas/subscriptions","organizations_url":"https://api.github.com/users/saltstack-formulas/orgs","repos_url":"https://api.github.com/users/saltstack-formulas/repos","events_url":"https://api.github.com/users/saltstack-formulas/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack-formulas/received_events","type":"Organization","site_admin":false},"repo":{"id":23077805,"name":"collectd-formula","full_name":"saltstack-formulas/collectd-formula","owner":{"login":"saltstack-formulas","id":4683350,"avatar_url":"https://avatars.githubusercontent.com/u/4683350?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack-formulas","html_url":"https://github.com/saltstack-formulas","followers_url":"https://api.github.com/users/saltstack-formulas/followers","following_url":"https://api.github.com/users/saltstack-formulas/following{/other_user}","gists_url":"https://api.github.com/users/saltstack-formulas/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack-formulas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack-formulas/subscriptions","organizations_url":"https://api.github.com/users/saltstack-formulas/orgs","repos_url":"https://api.github.com/users/saltstack-formulas/repos","events_url":"https://api.github.com/users/saltstack-formulas/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack-formulas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack-formulas/collectd-formula","description":null,"fork":false,"url":"https://api.github.com/repos/saltstack-formulas/collectd-formula","forks_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/forks","keys_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/teams","hooks_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/hooks","issue_events_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/events","assignees_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/tags","blobs_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/languages","stargazers_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/stargazers","contributors_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/contributors","subscribers_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/subscribers","subscription_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/subscription","commits_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/merges","archive_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/downloads","issues_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/labels{/name}","releases_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/releases{/id}","created_at":"2014-08-18T16:09:47Z","updated_at":"2015-05-20T15:41:58Z","pushed_at":"2015-05-22T14:30:37Z","git_url":"git://github.com/saltstack-formulas/collectd-formula.git","ssh_url":"git@github.com:saltstack-formulas/collectd-formula.git","clone_url":"https://github.com/saltstack-formulas/collectd-formula.git","svn_url":"https://github.com/saltstack-formulas/collectd-formula","homepage":"http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html","size":485,"stargazers_count":6,"watchers_count":6,"language":"SaltStack","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":6,"forks":19,"open_issues":6,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack-formulas/collectd-formula/pulls/39"},"html":{"href":"https://github.com/saltstack-formulas/collectd-formula/pull/39"},"issue":{"href":"https://api.github.com/repos/saltstack-formulas/collectd-formula/issues/39"},"comments":{"href":"https://api.github.com/repos/saltstack-formulas/collectd-formula/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack-formulas/collectd-formula/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack-formulas/collectd-formula/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack-formulas/collectd-formula/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack-formulas/collectd-formula/statuses/ad4fcb2d59ebd7f94725955f67457decb04d4ad9"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":5,"additions":35,"deletions":15,"changed_files":6}}