{"action":"created","issue":{"url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/244","labels_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/244/labels{/name}","comments_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/244/comments","events_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/244/events","html_url":"https://github.com/BloomBooks/BloomDesktop/pull/244","id":55349903,"number":244,"title":"Fix BL-945 governing book captions and initial titles","user":{"login":"hatton","id":8448,"avatar_url":"https://avatars.githubusercontent.com/u/8448?v=3","gravatar_id":"","url":"https://api.github.com/users/hatton","html_url":"https://github.com/hatton","followers_url":"https://api.github.com/users/hatton/followers","following_url":"https://api.github.com/users/hatton/following{/other_user}","gists_url":"https://api.github.com/users/hatton/gists{/gist_id}","starred_url":"https://api.github.com/users/hatton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatton/subscriptions","organizations_url":"https://api.github.com/users/hatton/orgs","repos_url":"https://api.github.com/users/hatton/repos","events_url":"https://api.github.com/users/hatton/events{/privacy}","received_events_url":"https://api.github.com/users/hatton/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-24T00:18:01Z","updated_at":"2015-01-24T00:20:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/244","html_url":"https://github.com/BloomBooks/BloomDesktop/pull/244","diff_url":"https://github.com/BloomBooks/BloomDesktop/pull/244.diff","patch_url":"https://github.com/BloomBooks/BloomDesktop/pull/244.patch"},"body":"In the past there were well-intentioned attempts to provide default title for new books. It turns out that this is fraught with unintended consequences that would just confuse the user. This PR overhauls this system, taking in to account differences such as:\r\n\r\n- whether the book we're making is from a template (remove all titles, name the book's file \"Book\" until we have something better\r\n- if we're making it from a Shell Book (leave all the titles)\r\n- If we're just displaying a caption of a source book, in which case prefer the current UI Language but then keep digging in order of guess preferences until your find *some* label to show\r\n- If we're just displaying a caption of one of the editable books in our collection, in which case just show \"Title Missing\" until they enter a title in the primary language of the collection\r\n\r\nREVIEW appreciated, but please don't merge yet. There's a lot of code changing here, so I would rather get the next public beta out first."},"comment":{"url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/comments/71289210","html_url":"https://github.com/BloomBooks/BloomDesktop/pull/244#issuecomment-71289210","issue_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/244","id":71289210,"user":{"login":"sillsdevgerrit","id":1415386,"avatar_url":"https://avatars.githubusercontent.com/u/1415386?v=3","gravatar_id":"","url":"https://api.github.com/users/sillsdevgerrit","html_url":"https://github.com/sillsdevgerrit","followers_url":"https://api.github.com/users/sillsdevgerrit/followers","following_url":"https://api.github.com/users/sillsdevgerrit/following{/other_user}","gists_url":"https://api.github.com/users/sillsdevgerrit/gists{/gist_id}","starred_url":"https://api.github.com/users/sillsdevgerrit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sillsdevgerrit/subscriptions","organizations_url":"https://api.github.com/users/sillsdevgerrit/orgs","repos_url":"https://api.github.com/users/sillsdevgerrit/repos","events_url":"https://api.github.com/users/sillsdevgerrit/events{/privacy}","received_events_url":"https://api.github.com/users/sillsdevgerrit/received_events","type":"User","site_admin":false},"created_at":"2015-01-24T00:20:52Z","updated_at":"2015-01-24T00:20:52Z","body":"\nRefer to this link for build results (access rights to CI server needed): \nhttps://jenkins.lsdev.sil.org//job/GitHub-Bloom-Wrapper-debug/92/\nBuild failed"}}