{"action":"created","issue":{"url":"https://api.github.com/repos/coreos/etcd/issues/2323","labels_url":"https://api.github.com/repos/coreos/etcd/issues/2323/labels{/name}","comments_url":"https://api.github.com/repos/coreos/etcd/issues/2323/comments","events_url":"https://api.github.com/repos/coreos/etcd/issues/2323/events","html_url":"https://github.com/coreos/etcd/pull/2323","id":57855141,"number":2323,"title":"rafthttp: refactor peer","user":{"login":"yichengq","id":2976232,"avatar_url":"https://avatars.githubusercontent.com/u/2976232?v=3","gravatar_id":"","url":"https://api.github.com/users/yichengq","html_url":"https://github.com/yichengq","followers_url":"https://api.github.com/users/yichengq/followers","following_url":"https://api.github.com/users/yichengq/following{/other_user}","gists_url":"https://api.github.com/users/yichengq/gists{/gist_id}","starred_url":"https://api.github.com/users/yichengq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yichengq/subscriptions","organizations_url":"https://api.github.com/users/yichengq/orgs","repos_url":"https://api.github.com/users/yichengq/repos","events_url":"https://api.github.com/users/yichengq/events{/privacy}","received_events_url":"https://api.github.com/users/yichengq/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-02-16T21:49:20Z","updated_at":"2015-02-22T02:27:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/coreos/etcd/pulls/2323","html_url":"https://github.com/coreos/etcd/pull/2323","diff_url":"https://github.com/coreos/etcd/pull/2323.diff","patch_url":"https://github.com/coreos/etcd/pull/2323.patch"},"body":"Architecture:\r\nEach peer manages three worker:\r\nmsgApp stream: receive/send entries of msgApp fast\r\ngeneral stream: receive/send all other messages fast\r\npipeline: the safest but slowest way to receive/send messages\r\n\r\nPerformance:\r\nEnvironment: MacBook Pro (Retina, 15-inch, Mid 2014), 3-member cluster, 200 clients\r\npropose to leader: 7245 req/s\r\npropose to follower: 1963 req/s\r\n\r\nFeedback is welcome.\r\n\r\nKeep working:\r\n- [x] fix tests\r\n- [ ] add tests\r\n\r\nFurther thoughts:\r\n1. more specific-usage streams can make it faster and more stable\r\n2. the speed that propose to follower is restricted heavily because we don't recover CommitIndex in msgApp stream"},"comment":{"url":"https://api.github.com/repos/coreos/etcd/issues/comments/75415729","html_url":"https://github.com/coreos/etcd/pull/2323#issuecomment-75415729","issue_url":"https://api.github.com/repos/coreos/etcd/issues/2323","id":75415729,"user":{"login":"yichengq","id":2976232,"avatar_url":"https://avatars.githubusercontent.com/u/2976232?v=3","gravatar_id":"","url":"https://api.github.com/users/yichengq","html_url":"https://github.com/yichengq","followers_url":"https://api.github.com/users/yichengq/followers","following_url":"https://api.github.com/users/yichengq/following{/other_user}","gists_url":"https://api.github.com/users/yichengq/gists{/gist_id}","starred_url":"https://api.github.com/users/yichengq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yichengq/subscriptions","organizations_url":"https://api.github.com/users/yichengq/orgs","repos_url":"https://api.github.com/users/yichengq/repos","events_url":"https://api.github.com/users/yichengq/events{/privacy}","received_events_url":"https://api.github.com/users/yichengq/received_events","type":"User","site_admin":false},"created_at":"2015-02-22T02:27:09Z","updated_at":"2015-02-22T02:27:09Z","body":"PTAL. comments are all addressed.\r\n@barakmich : I plan to add unit tests, integration tests and benchmark tests in the following-ups. "}}