{"action":"created","comment":{"url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments/48029482","id":48029482,"diff_hunk":"@@ -24,13 +24,19 @@\n module Cisco\n   # VxlanVtepVni - node utility for vxlan vtep vni members.\n   class VxlanVtepVni < NodeUtil\n-    attr_reader :name, :vni\n+    attr_reader :name, :vni, :vrf\n \n-    def initialize(name, vni, instantiate=true)\n+    def initialize(name, vni, vrf=false, instantiate=true)","path":"lib/cisco_node_utils/vxlan_vtep_vni.rb","position":8,"original_position":8,"commit_id":"9b4a50140dcd117f04c5155dcf52bf910479386b","original_commit_id":"9b4a50140dcd117f04c5155dcf52bf910479386b","user":{"login":"mikewiebe","id":12445795,"avatar_url":"https://avatars.githubusercontent.com/u/12445795?v=3","gravatar_id":"","url":"https://api.github.com/users/mikewiebe","html_url":"https://github.com/mikewiebe","followers_url":"https://api.github.com/users/mikewiebe/followers","following_url":"https://api.github.com/users/mikewiebe/following{/other_user}","gists_url":"https://api.github.com/users/mikewiebe/gists{/gist_id}","starred_url":"https://api.github.com/users/mikewiebe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikewiebe/subscriptions","organizations_url":"https://api.github.com/users/mikewiebe/orgs","repos_url":"https://api.github.com/users/mikewiebe/repos","events_url":"https://api.github.com/users/mikewiebe/events{/privacy}","received_events_url":"https://api.github.com/users/mikewiebe/received_events","type":"User","site_admin":false},"body":"Yeah.. glad you made the comment.  I went aback and forth with several names before I settled on `vrf` but based on your suggestion I agree that `assoc_vrf` adds more clarity.","created_at":"2015-12-18T14:31:32Z","updated_at":"2015-12-18T14:31:32Z","html_url":"https://github.com/cisco/cisco-network-node-utils/pull/141#discussion_r48029482","pull_request_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/141","_links":{"self":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments/48029482"},"html":{"href":"https://github.com/cisco/cisco-network-node-utils/pull/141#discussion_r48029482"},"pull_request":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/141"}}},"pull_request":{"url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/141","id":54057099,"html_url":"https://github.com/cisco/cisco-network-node-utils/pull/141","diff_url":"https://github.com/cisco/cisco-network-node-utils/pull/141.diff","patch_url":"https://github.com/cisco/cisco-network-node-utils/pull/141.patch","issue_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/141","number":141,"state":"open","locked":false,"title":"vxlan_vtep and vxlan_vtep_vni refactoring","user":{"login":"mikewiebe","id":12445795,"avatar_url":"https://avatars.githubusercontent.com/u/12445795?v=3","gravatar_id":"","url":"https://api.github.com/users/mikewiebe","html_url":"https://github.com/mikewiebe","followers_url":"https://api.github.com/users/mikewiebe/followers","following_url":"https://api.github.com/users/mikewiebe/following{/other_user}","gists_url":"https://api.github.com/users/mikewiebe/gists{/gist_id}","starred_url":"https://api.github.com/users/mikewiebe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikewiebe/subscriptions","organizations_url":"https://api.github.com/users/mikewiebe/orgs","repos_url":"https://api.github.com/users/mikewiebe/repos","events_url":"https://api.github.com/users/mikewiebe/events{/privacy}","received_events_url":"https://api.github.com/users/mikewiebe/received_events","type":"User","site_admin":false},"body":"**Summary of changes**\r\n* vxlan_vtep\r\n  * Renamed mac_distribution property to be host_reachability and simplifed.\r\n  * Added shutdown yaml entry.\r\n  * Removed dead code\r\n  * Added minitests for new code\r\n* vxlan_vtep_vni\r\n  * Added associate-vrf parameter\r\n  * Added minitests for now code\r\n\r\n**MiniTest Results**\r\n\r\n```\r\nrtp-ads-432:/nobackup/mwiebe/REPOS_NODE_UTILS/vxlan/cisco-network-node-utils> ruby tests/test_vxlan_vtep.rb -v -- 10.122.197.222 admin admin\r\nRun options: -v -- --seed 59261\r\n\r\n# Running:\r\n\r\n\r\nNode under test:\r\n  - name  - dt-n9k5-1\r\n  - type  - N9K-C9396PX\r\n  - image - bootflash:///nxos.7.0.3.I2.1.74.bin\r\n\r\nTestVxlanVtep#test_shutdown = 16.55 s = .\r\nTestVxlanVtep#test_description = 9.72 s = .\r\nTestVxlanVtep#test_source_interface = 10.12 s = .\r\nTestVxlanVtep#test_create_multiple_negative = 8.46 s = .\r\nTestVxlanVtep#test_create_destroy_one = 9.08 s = .\r\nTestVxlanVtep#test_host_reachability = 9.49 s = .\r\nTestVxlanVtep#test_create_destroy_multiple = 0.83 s = S\r\n\r\nFinished in 64.250164s, 0.1089 runs/s, 0.3424 assertions/s.\r\n\r\n  1) Skipped:\r\nTestVxlanVtep#test_create_destroy_multiple [tests/test_vxlan_vtep.rb:53]:\r\nOnly supported on n7k\r\n\r\n7 runs, 22 assertions, 0 failures, 0 errors, 1 skips\r\nCoverage report generated for MiniTest to /nobackup/mwiebe/REPOS_NODE_UTILS/vxlan/cisco-network-node-utils/coverage. 446 / 526 LOC (84.79%) covered.\r\nrtp-ads-432:/nobackup/mwiebe/REPOS_NODE_UTILS/vxlan/cisco-network-node-utils> \r\n```\r\n\r\n```\r\nrtp-ads-432:/nobackup/mwiebe/REPOS_NODE_UTILS/vxlan/cisco-network-node-utils> ruby tests/test_vxlan_vtep_vni.rb -v -- 10.122.197.222 admin admin\r\nRun options: -v -- --seed 46655\r\n\r\n# Running:\r\n\r\n\r\nNode under test:\r\n  - name  - dt-n9k5-1\r\n  - type  - N9K-C9396PX\r\n  - image - bootflash:///nxos.7.0.3.I2.1.74.bin\r\n\r\nTestVxlanVtepVni#test_suppress_arp = 9.99 s = E\r\nTestVxlanVtepVni#test_ingress_replication = 11.55 s = .\r\nTestVxlanVtepVni#test_multicast_group = 11.00 s = .\r\nTestVxlanVtepVni#test_create_with_existing = 10.24 s = .\r\nTestVxlanVtepVni#test_peer_list = 10.81 s = .\r\nTestVxlanVtepVni#test_vnis = 12.10 s = .\r\n\r\nFinished in 65.698252s, 0.0913 runs/s, 0.6697 assertions/s.\r\n\r\n  1) Error:\r\nTestVxlanVtepVni#test_suppress_arp:\r\nCisco::CliError: CliError: ' suppress-arp' rejected with message:\r\n'ERROR: Please configure TCAM region for Ingress ARP-Ether ACL before configuring ARP supression.'\r\n    /nobackup/mwiebe/REPOS_NODE_UTILS/vxlan/cisco-network-node-utils/lib/cisco_node_utils/node.rb:266:in `rescue in config'\r\n    /nobackup/mwiebe/REPOS_NODE_UTILS/vxlan/cisco-network-node-utils/lib/cisco_node_utils/node.rb:263:in `config'\r\n    /nobackup/mwiebe/REPOS_NODE_UTILS/vxlan/cisco-network-node-utils/lib/cisco_node_utils/node.rb:161:in `config_set'\r\n    /nobackup/mwiebe/REPOS_NODE_UTILS/vxlan/cisco-network-node-utils/lib/cisco_node_utils/node_util.rb:58:in `config_set'\r\n    /nobackup/mwiebe/REPOS_NODE_UTILS/vxlan/cisco-network-node-utils/lib/cisco_node_utils/vxlan_vtep_vni.rb:204:in `suppress_arp='\r\n    tests/test_vxlan_vtep_vni.rb:170:in `test_suppress_arp'\r\n\r\n6 runs, 44 assertions, 0 failures, 1 errors, 0 skips\r\nCoverage report generated for MiniTest to /nobackup/mwiebe/REPOS_NODE_UTILS/vxlan/cisco-network-node-utils/coverage. 540 / 681 LOC (79.3%) covered.\r\nrtp-ads-432:/nobackup/mwiebe/REPOS_NODE_UTILS/vxlan/cisco-network-node-utils> \r\n```\r\n\r\n**NOTE:** Suppress arp error is expected... box requires a reload to set the prop.\r\n","created_at":"2015-12-18T02:04:59Z","updated_at":"2015-12-18T14:31:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00fc33bade1620f63f39c75df52306e2a2b39f30","assignee":{"login":"chrisvanheuveln","id":12087548,"avatar_url":"https://avatars.githubusercontent.com/u/12087548?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisvanheuveln","html_url":"https://github.com/chrisvanheuveln","followers_url":"https://api.github.com/users/chrisvanheuveln/followers","following_url":"https://api.github.com/users/chrisvanheuveln/following{/other_user}","gists_url":"https://api.github.com/users/chrisvanheuveln/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvanheuveln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvanheuveln/subscriptions","organizations_url":"https://api.github.com/users/chrisvanheuveln/orgs","repos_url":"https://api.github.com/users/chrisvanheuveln/repos","events_url":"https://api.github.com/users/chrisvanheuveln/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvanheuveln/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/141/commits","review_comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/141/comments","review_comment_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/141/comments","statuses_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/9b4a50140dcd117f04c5155dcf52bf910479386b","head":{"label":"cisco:feature/vxlan_vtep","ref":"feature/vxlan_vtep","sha":"9b4a50140dcd117f04c5155dcf52bf910479386b","user":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"repo":{"id":39565196,"name":"cisco-network-node-utils","full_name":"cisco/cisco-network-node-utils","owner":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cisco/cisco-network-node-utils","description":"","fork":false,"url":"https://api.github.com/repos/cisco/cisco-network-node-utils","forks_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/forks","keys_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/teams","hooks_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/hooks","issue_events_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/events{/number}","events_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/events","assignees_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/assignees{/user}","branches_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/branches{/branch}","tags_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/tags","blobs_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/languages","stargazers_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/stargazers","contributors_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/contributors","subscribers_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/subscribers","subscription_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/subscription","commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/contents/{+path}","compare_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/merges","archive_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/downloads","issues_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues{/number}","pulls_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/labels{/name}","releases_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/releases{/id}","created_at":"2015-07-23T12:07:39Z","updated_at":"2015-12-17T07:37:55Z","pushed_at":"2015-12-18T13:05:30Z","git_url":"git://github.com/cisco/cisco-network-node-utils.git","ssh_url":"git@github.com:cisco/cisco-network-node-utils.git","clone_url":"https://github.com/cisco/cisco-network-node-utils.git","svn_url":"https://github.com/cisco/cisco-network-node-utils","homepage":null,"size":2333,"stargazers_count":7,"watchers_count":7,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":9,"forks":30,"open_issues":9,"watchers":7,"default_branch":"develop"}},"base":{"label":"cisco:develop","ref":"develop","sha":"0dc72ae1bf66e461f6f51760ed7aeaf9c97ec207","user":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"repo":{"id":39565196,"name":"cisco-network-node-utils","full_name":"cisco/cisco-network-node-utils","owner":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cisco/cisco-network-node-utils","description":"","fork":false,"url":"https://api.github.com/repos/cisco/cisco-network-node-utils","forks_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/forks","keys_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/teams","hooks_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/hooks","issue_events_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/events{/number}","events_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/events","assignees_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/assignees{/user}","branches_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/branches{/branch}","tags_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/tags","blobs_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/languages","stargazers_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/stargazers","contributors_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/contributors","subscribers_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/subscribers","subscription_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/subscription","commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/contents/{+path}","compare_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/merges","archive_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/downloads","issues_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues{/number}","pulls_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/labels{/name}","releases_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/releases{/id}","created_at":"2015-07-23T12:07:39Z","updated_at":"2015-12-17T07:37:55Z","pushed_at":"2015-12-18T13:05:30Z","git_url":"git://github.com/cisco/cisco-network-node-utils.git","ssh_url":"git@github.com:cisco/cisco-network-node-utils.git","clone_url":"https://github.com/cisco/cisco-network-node-utils.git","svn_url":"https://github.com/cisco/cisco-network-node-utils","homepage":null,"size":2333,"stargazers_count":7,"watchers_count":7,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":9,"forks":30,"open_issues":9,"watchers":7,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/141"},"html":{"href":"https://github.com/cisco/cisco-network-node-utils/pull/141"},"issue":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/141"},"comments":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/141/comments"},"review_comments":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/141/comments"},"review_comment":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/141/commits"},"statuses":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/9b4a50140dcd117f04c5155dcf52bf910479386b"}}}}