{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14943","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14943/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14943/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14943/events","html_url":"https://github.com/kubernetes/kubernetes/pull/14943","id":109394974,"number":14943,"title":"Updaing QoS policy to not be per-resource.","user":{"login":"vishh","id":7063592,"avatar_url":"https://avatars.githubusercontent.com/u/7063592?v=3","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-rebase","name":"needs-rebase","color":"BDBDBD"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XL","name":"size/XL","color":"ee5500"}],"state":"open","locked":false,"assignee":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"milestone":null,"comments":10,"created_at":"2015-10-01T22:09:14Z","updated_at":"2015-10-05T17:04:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14943","html_url":"https://github.com/kubernetes/kubernetes/pull/14943","diff_url":"https://github.com/kubernetes/kubernetes/pull/14943.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/14943.patch"},"body":"This patch, makes the QoS policy for a container equal to the least common class for all the resources combined.\r\nFor example, a container is Guaranteed, only if limits == request for all the required resources.\r\nThe existing design requires controlling cgroup hierarchies individually for each resource. \r\nFor example, if a container is cpu *guaranteed* and memory *burstable*, kubelet will have to place the container in a guranteed cpu cgroup hierarchy and for memory, place it in a burstable hierarchy. \r\nThis will break when we transition to unified hierarchy.\r\nLet's not expose a feature that we know won't work on many systems.\r\ncc @bgrant0607 @derekwaynecarr \r\n\r\nThis patch also moves qos doc from proposal to design. I have moved the existing TODO to an issue. The rest of the TODOs are projects by themselves and does not make sense to include here."},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/145600011","html_url":"https://github.com/kubernetes/kubernetes/pull/14943#issuecomment-145600011","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14943","id":145600011,"user":{"login":"derekwaynecarr","id":6233452,"avatar_url":"https://avatars.githubusercontent.com/u/6233452?v=3","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false},"created_at":"2015-10-05T17:04:56Z","updated_at":"2015-10-05T17:04:56Z","body":"@davidopp - I am not a huge fan of requiring all compute resources be a member of the same qos class as part of validation.  We have a number of things that are setting resources, that I think that requiring this rule would make for a poor user experience.  I still need to read the referenced document on unified hierarchy.  I agree with @vishh that we want to more proactively prevent OOM scenarios using some type of memory monitoring in the future that pro-actively kills containers when under memory pressure.  In that scenario, I was less concerned with this change just updating the oom_score_adj value, and more concerned on if there were other semantics I was missing as part of this change."}}