{"action":"created","comment":{"url":"https://api.github.com/repos/prometheus/prometheus/pulls/comments/38506534","id":38506534,"diff_hunk":"@@ -186,6 +202,12 @@ func reloadConfig(filename string, rls ...Reloadable) bool {\n \tfor _, rl := range rls {\n \t\tsuccess = success && rl.ApplyConfig(conf)\n \t}\n+\tif success {\n+\t\tconfigSuccess.Set(1.0)\n+\t\tconfigSuccessTime.Set(float64(time.Now().Unix()))\n+\t} else {\n+\t\tconfigSuccess.Set(0)","path":"cmd/prometheus/main.go","position":45,"original_position":45,"commit_id":"aa00ae69202b465a8956b996a67ad2d460a8632f","original_commit_id":"aa00ae69202b465a8956b996a67ad2d460a8632f","user":{"login":"brian-brazil","id":7115638,"avatar_url":"https://avatars.githubusercontent.com/u/7115638?v=3","gravatar_id":"","url":"https://api.github.com/users/brian-brazil","html_url":"https://github.com/brian-brazil","followers_url":"https://api.github.com/users/brian-brazil/followers","following_url":"https://api.github.com/users/brian-brazil/following{/other_user}","gists_url":"https://api.github.com/users/brian-brazil/gists{/gist_id}","starred_url":"https://api.github.com/users/brian-brazil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brian-brazil/subscriptions","organizations_url":"https://api.github.com/users/brian-brazil/orgs","repos_url":"https://api.github.com/users/brian-brazil/repos","events_url":"https://api.github.com/users/brian-brazil/events{/privacy}","received_events_url":"https://api.github.com/users/brian-brazil/received_events","type":"User","site_admin":false},"body":"this is redundant, probably best to combine this if with the one above","created_at":"2015-09-02T07:53:58Z","updated_at":"2015-09-02T07:53:58Z","html_url":"https://github.com/prometheus/prometheus/pull/1047#discussion_r38506534","pull_request_url":"https://api.github.com/repos/prometheus/prometheus/pulls/1047","_links":{"self":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/comments/38506534"},"html":{"href":"https://github.com/prometheus/prometheus/pull/1047#discussion_r38506534"},"pull_request":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/1047"}}},"pull_request":{"url":"https://api.github.com/repos/prometheus/prometheus/pulls/1047","id":43902580,"html_url":"https://github.com/prometheus/prometheus/pull/1047","diff_url":"https://github.com/prometheus/prometheus/pull/1047.diff","patch_url":"https://github.com/prometheus/prometheus/pull/1047.patch","issue_url":"https://api.github.com/repos/prometheus/prometheus/issues/1047","number":1047,"state":"open","locked":false,"title":"Add an exported counter to track configuration reloads","user":{"login":"swsnider","id":1662,"avatar_url":"https://avatars.githubusercontent.com/u/1662?v=3","gravatar_id":"","url":"https://api.github.com/users/swsnider","html_url":"https://github.com/swsnider","followers_url":"https://api.github.com/users/swsnider/followers","following_url":"https://api.github.com/users/swsnider/following{/other_user}","gists_url":"https://api.github.com/users/swsnider/gists{/gist_id}","starred_url":"https://api.github.com/users/swsnider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swsnider/subscriptions","organizations_url":"https://api.github.com/users/swsnider/orgs","repos_url":"https://api.github.com/users/swsnider/repos","events_url":"https://api.github.com/users/swsnider/events{/privacy}","received_events_url":"https://api.github.com/users/swsnider/received_events","type":"User","site_admin":false},"body":"This makes it easier for automation to detect whether a configuration reload actually worked, so that rollbacks of config at the filesystem can be done in concert with rollbacks in memory.","created_at":"2015-09-01T17:20:55Z","updated_at":"2015-09-02T07:53:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a22ba3f83fd7402ed3d57c1797cba096ac8a2313","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/prometheus/prometheus/pulls/1047/commits","review_comments_url":"https://api.github.com/repos/prometheus/prometheus/pulls/1047/comments","review_comment_url":"https://api.github.com/repos/prometheus/prometheus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prometheus/prometheus/issues/1047/comments","statuses_url":"https://api.github.com/repos/prometheus/prometheus/statuses/aa00ae69202b465a8956b996a67ad2d460a8632f","head":{"label":"swsnider:upstreamed","ref":"upstreamed","sha":"aa00ae69202b465a8956b996a67ad2d460a8632f","user":{"login":"swsnider","id":1662,"avatar_url":"https://avatars.githubusercontent.com/u/1662?v=3","gravatar_id":"","url":"https://api.github.com/users/swsnider","html_url":"https://github.com/swsnider","followers_url":"https://api.github.com/users/swsnider/followers","following_url":"https://api.github.com/users/swsnider/following{/other_user}","gists_url":"https://api.github.com/users/swsnider/gists{/gist_id}","starred_url":"https://api.github.com/users/swsnider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swsnider/subscriptions","organizations_url":"https://api.github.com/users/swsnider/orgs","repos_url":"https://api.github.com/users/swsnider/repos","events_url":"https://api.github.com/users/swsnider/events{/privacy}","received_events_url":"https://api.github.com/users/swsnider/received_events","type":"User","site_admin":false},"repo":{"id":41752576,"name":"prometheus","full_name":"swsnider/prometheus","owner":{"login":"swsnider","id":1662,"avatar_url":"https://avatars.githubusercontent.com/u/1662?v=3","gravatar_id":"","url":"https://api.github.com/users/swsnider","html_url":"https://github.com/swsnider","followers_url":"https://api.github.com/users/swsnider/followers","following_url":"https://api.github.com/users/swsnider/following{/other_user}","gists_url":"https://api.github.com/users/swsnider/gists{/gist_id}","starred_url":"https://api.github.com/users/swsnider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swsnider/subscriptions","organizations_url":"https://api.github.com/users/swsnider/orgs","repos_url":"https://api.github.com/users/swsnider/repos","events_url":"https://api.github.com/users/swsnider/events{/privacy}","received_events_url":"https://api.github.com/users/swsnider/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/swsnider/prometheus","description":"The Prometheus monitoring system and time series database.","fork":true,"url":"https://api.github.com/repos/swsnider/prometheus","forks_url":"https://api.github.com/repos/swsnider/prometheus/forks","keys_url":"https://api.github.com/repos/swsnider/prometheus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swsnider/prometheus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swsnider/prometheus/teams","hooks_url":"https://api.github.com/repos/swsnider/prometheus/hooks","issue_events_url":"https://api.github.com/repos/swsnider/prometheus/issues/events{/number}","events_url":"https://api.github.com/repos/swsnider/prometheus/events","assignees_url":"https://api.github.com/repos/swsnider/prometheus/assignees{/user}","branches_url":"https://api.github.com/repos/swsnider/prometheus/branches{/branch}","tags_url":"https://api.github.com/repos/swsnider/prometheus/tags","blobs_url":"https://api.github.com/repos/swsnider/prometheus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swsnider/prometheus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swsnider/prometheus/git/refs{/sha}","trees_url":"https://api.github.com/repos/swsnider/prometheus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swsnider/prometheus/statuses/{sha}","languages_url":"https://api.github.com/repos/swsnider/prometheus/languages","stargazers_url":"https://api.github.com/repos/swsnider/prometheus/stargazers","contributors_url":"https://api.github.com/repos/swsnider/prometheus/contributors","subscribers_url":"https://api.github.com/repos/swsnider/prometheus/subscribers","subscription_url":"https://api.github.com/repos/swsnider/prometheus/subscription","commits_url":"https://api.github.com/repos/swsnider/prometheus/commits{/sha}","git_commits_url":"https://api.github.com/repos/swsnider/prometheus/git/commits{/sha}","comments_url":"https://api.github.com/repos/swsnider/prometheus/comments{/number}","issue_comment_url":"https://api.github.com/repos/swsnider/prometheus/issues/comments{/number}","contents_url":"https://api.github.com/repos/swsnider/prometheus/contents/{+path}","compare_url":"https://api.github.com/repos/swsnider/prometheus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swsnider/prometheus/merges","archive_url":"https://api.github.com/repos/swsnider/prometheus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swsnider/prometheus/downloads","issues_url":"https://api.github.com/repos/swsnider/prometheus/issues{/number}","pulls_url":"https://api.github.com/repos/swsnider/prometheus/pulls{/number}","milestones_url":"https://api.github.com/repos/swsnider/prometheus/milestones{/number}","notifications_url":"https://api.github.com/repos/swsnider/prometheus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swsnider/prometheus/labels{/name}","releases_url":"https://api.github.com/repos/swsnider/prometheus/releases{/id}","created_at":"2015-09-01T17:19:04Z","updated_at":"2015-09-01T17:19:05Z","pushed_at":"2015-09-01T23:22:33Z","git_url":"git://github.com/swsnider/prometheus.git","ssh_url":"git@github.com:swsnider/prometheus.git","clone_url":"https://github.com/swsnider/prometheus.git","svn_url":"https://github.com/swsnider/prometheus","homepage":"http://prometheus.io/","size":18590,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prometheus:master","ref":"master","sha":"44592657391baa70b9de4187a78d460bbf511fca","user":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"repo":{"id":6838921,"name":"prometheus","full_name":"prometheus/prometheus","owner":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prometheus/prometheus","description":"The Prometheus monitoring system and time series database.","fork":false,"url":"https://api.github.com/repos/prometheus/prometheus","forks_url":"https://api.github.com/repos/prometheus/prometheus/forks","keys_url":"https://api.github.com/repos/prometheus/prometheus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prometheus/prometheus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prometheus/prometheus/teams","hooks_url":"https://api.github.com/repos/prometheus/prometheus/hooks","issue_events_url":"https://api.github.com/repos/prometheus/prometheus/issues/events{/number}","events_url":"https://api.github.com/repos/prometheus/prometheus/events","assignees_url":"https://api.github.com/repos/prometheus/prometheus/assignees{/user}","branches_url":"https://api.github.com/repos/prometheus/prometheus/branches{/branch}","tags_url":"https://api.github.com/repos/prometheus/prometheus/tags","blobs_url":"https://api.github.com/repos/prometheus/prometheus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prometheus/prometheus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prometheus/prometheus/git/refs{/sha}","trees_url":"https://api.github.com/repos/prometheus/prometheus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prometheus/prometheus/statuses/{sha}","languages_url":"https://api.github.com/repos/prometheus/prometheus/languages","stargazers_url":"https://api.github.com/repos/prometheus/prometheus/stargazers","contributors_url":"https://api.github.com/repos/prometheus/prometheus/contributors","subscribers_url":"https://api.github.com/repos/prometheus/prometheus/subscribers","subscription_url":"https://api.github.com/repos/prometheus/prometheus/subscription","commits_url":"https://api.github.com/repos/prometheus/prometheus/commits{/sha}","git_commits_url":"https://api.github.com/repos/prometheus/prometheus/git/commits{/sha}","comments_url":"https://api.github.com/repos/prometheus/prometheus/comments{/number}","issue_comment_url":"https://api.github.com/repos/prometheus/prometheus/issues/comments{/number}","contents_url":"https://api.github.com/repos/prometheus/prometheus/contents/{+path}","compare_url":"https://api.github.com/repos/prometheus/prometheus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prometheus/prometheus/merges","archive_url":"https://api.github.com/repos/prometheus/prometheus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prometheus/prometheus/downloads","issues_url":"https://api.github.com/repos/prometheus/prometheus/issues{/number}","pulls_url":"https://api.github.com/repos/prometheus/prometheus/pulls{/number}","milestones_url":"https://api.github.com/repos/prometheus/prometheus/milestones{/number}","notifications_url":"https://api.github.com/repos/prometheus/prometheus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prometheus/prometheus/labels{/name}","releases_url":"https://api.github.com/repos/prometheus/prometheus/releases{/id}","created_at":"2012-11-24T11:14:12Z","updated_at":"2015-09-02T07:24:26Z","pushed_at":"2015-09-01T23:22:34Z","git_url":"git://github.com/prometheus/prometheus.git","ssh_url":"git@github.com:prometheus/prometheus.git","clone_url":"https://github.com/prometheus/prometheus.git","svn_url":"https://github.com/prometheus/prometheus","homepage":"http://prometheus.io/","size":18590,"stargazers_count":2897,"watchers_count":2897,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":184,"mirror_url":null,"open_issues_count":98,"forks":184,"open_issues":98,"watchers":2897,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/1047"},"html":{"href":"https://github.com/prometheus/prometheus/pull/1047"},"issue":{"href":"https://api.github.com/repos/prometheus/prometheus/issues/1047"},"comments":{"href":"https://api.github.com/repos/prometheus/prometheus/issues/1047/comments"},"review_comments":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/1047/comments"},"review_comment":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/1047/commits"},"statuses":{"href":"https://api.github.com/repos/prometheus/prometheus/statuses/aa00ae69202b465a8956b996a67ad2d460a8632f"}}}}