{"action":"created","comment":{"url":"https://api.github.com/repos/geodynamics/aspect/pulls/comments/22859252","id":22859252,"diff_hunk":"@@ -0,0 +1,356 @@\n+/*\n+  Copyright (C) 2011 - 2014 by the authors of the ASPECT code.\n+\n+  This file is part of ASPECT.\n+\n+  ASPECT is free software; you can redistribute it and/or modify\n+  it under the terms of the GNU General Public License as published by\n+  the Free Software Foundation; either version 2, or (at your option)\n+  any later version.\n+\n+  ASPECT is distributed in the hope that it will be useful,\n+  but WITHOUT ANY WARRANTY; without even the implied warranty of\n+  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+  GNU General Public License for more details.\n+\n+  You should have received a copy of the GNU General Public License\n+  along with ASPECT; see the file doc/COPYING.  If not see\n+  <http://www.gnu.org/licenses/>.\n+*/\n+\n+\n+#ifndef __aspect__velocity_boundary_conditions_ascii_data_h\n+#define __aspect__velocity_boundary_conditions_ascii_data_h\n+\n+#include <aspect/velocity_boundary_conditions/interface.h>\n+#include <aspect/simulator_access.h>\n+\n+\n+namespace aspect\n+{\n+  namespace VelocityBoundaryConditions\n+  {\n+    using namespace dealii;\n+\n+\n+    namespace internal\n+    {\n+\n+      /**\n+       * AsciiDataLookup handles all kinds of tasks around looking up a certain\n+       * velocity boundary condition from a text file. This class\n+       * keeps around the contents of two sets of files, corresponding to two\n+       * instances in time where the text files provides us with data; the boundary\n+       * values at one particular time are interpolated between the two\n+       * currently loaded data sets.\n+       */\n+      template <int dim>\n+      class AsciiDataLookup\n+      {\n+        public:\n+\n+          /**\n+           * Initialize all members and the two tables referring to the\n+           * actual velocities.\n+           */\n+          AsciiDataLookup(const Point<dim> &grid_extent_,\n+                          const unsigned int npoints_[3],\n+                          const unsigned int boundary_dimensions_[2],","path":"include/aspect/velocity_boundary_conditions/ascii_data.h","position":58,"original_position":58,"commit_id":"41f0fd51704b4e6ecd94bce83f353165fdf940a7","original_commit_id":"41f0fd51704b4e6ecd94bce83f353165fdf940a7","user":{"login":"bangerth","id":7504421,"avatar_url":"https://avatars.githubusercontent.com/u/7504421?v=3","gravatar_id":"","url":"https://api.github.com/users/bangerth","html_url":"https://github.com/bangerth","followers_url":"https://api.github.com/users/bangerth/followers","following_url":"https://api.github.com/users/bangerth/following{/other_user}","gists_url":"https://api.github.com/users/bangerth/gists{/gist_id}","starred_url":"https://api.github.com/users/bangerth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangerth/subscriptions","organizations_url":"https://api.github.com/users/bangerth/orgs","repos_url":"https://api.github.com/users/bangerth/repos","events_url":"https://api.github.com/users/bangerth/events{/privacy}","received_events_url":"https://api.github.com/users/bangerth/received_events","type":"User","site_admin":false},"body":"This probably doesn't quite do what you intend. You need to write it as\r\n```\r\n  const unsigned int (npoints_)[3]\r\n```\r\n(Note the parentheses.) We don't usually mark variables with a trailing underscore. Are you willing to undo this?","created_at":"2015-01-13T12:45:41Z","updated_at":"2015-01-13T12:45:41Z","html_url":"https://github.com/geodynamics/aspect/pull/240#discussion_r22859252","pull_request_url":"https://api.github.com/repos/geodynamics/aspect/pulls/240","_links":{"self":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/comments/22859252"},"html":{"href":"https://github.com/geodynamics/aspect/pull/240#discussion_r22859252"},"pull_request":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/240"}}},"pull_request":{"url":"https://api.github.com/repos/geodynamics/aspect/pulls/240","id":27092169,"html_url":"https://github.com/geodynamics/aspect/pull/240","diff_url":"https://github.com/geodynamics/aspect/pull/240.diff","patch_url":"https://github.com/geodynamics/aspect/pull/240.patch","issue_url":"https://api.github.com/repos/geodynamics/aspect/issues/240","number":240,"state":"open","locked":false,"title":"Side boundary conditions","user":{"login":"ebredow","id":9881327,"avatar_url":"https://avatars.githubusercontent.com/u/9881327?v=3","gravatar_id":"","url":"https://api.github.com/users/ebredow","html_url":"https://github.com/ebredow","followers_url":"https://api.github.com/users/ebredow/followers","following_url":"https://api.github.com/users/ebredow/following{/other_user}","gists_url":"https://api.github.com/users/ebredow/gists{/gist_id}","starred_url":"https://api.github.com/users/ebredow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebredow/subscriptions","organizations_url":"https://api.github.com/users/ebredow/orgs","repos_url":"https://api.github.com/users/ebredow/repos","events_url":"https://api.github.com/users/ebredow/events{/privacy}","received_events_url":"https://api.github.com/users/ebredow/received_events","type":"User","site_admin":false},"body":"We are currently working on models that would like to prescribe velocity boundary conditions read in from a file. Therefore we created a generic plugin that reads in ascii files and uses the velocities as boundary condition. While writing the plugin we noticed that it would be nice to have similar plugins for the other boundary conditions and initial conditions. Therefore we would like to ask for comments, before we start implementing similar things for the other plugin types. Later on, with this set of plugins we will be able to create a cookbook that is similar to the CitcomS cookbook 5 (subduction with trench rollback).","created_at":"2015-01-09T10:46:23Z","updated_at":"2015-01-13T12:45:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9a4d8b26bf320d7a92e26632c9a2518b1e02a4f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/geodynamics/aspect/pulls/240/commits","review_comments_url":"https://api.github.com/repos/geodynamics/aspect/pulls/240/comments","review_comment_url":"https://api.github.com/repos/geodynamics/aspect/pulls/comments/{number}","comments_url":"https://api.github.com/repos/geodynamics/aspect/issues/240/comments","statuses_url":"https://api.github.com/repos/geodynamics/aspect/statuses/41f0fd51704b4e6ecd94bce83f353165fdf940a7","head":{"label":"ebredow:side_boundary_conditions","ref":"side_boundary_conditions","sha":"41f0fd51704b4e6ecd94bce83f353165fdf940a7","user":{"login":"ebredow","id":9881327,"avatar_url":"https://avatars.githubusercontent.com/u/9881327?v=3","gravatar_id":"","url":"https://api.github.com/users/ebredow","html_url":"https://github.com/ebredow","followers_url":"https://api.github.com/users/ebredow/followers","following_url":"https://api.github.com/users/ebredow/following{/other_user}","gists_url":"https://api.github.com/users/ebredow/gists{/gist_id}","starred_url":"https://api.github.com/users/ebredow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebredow/subscriptions","organizations_url":"https://api.github.com/users/ebredow/orgs","repos_url":"https://api.github.com/users/ebredow/repos","events_url":"https://api.github.com/users/ebredow/events{/privacy}","received_events_url":"https://api.github.com/users/ebredow/received_events","type":"User","site_admin":false},"repo":{"id":28975227,"name":"aspect","full_name":"ebredow/aspect","owner":{"login":"ebredow","id":9881327,"avatar_url":"https://avatars.githubusercontent.com/u/9881327?v=3","gravatar_id":"","url":"https://api.github.com/users/ebredow","html_url":"https://github.com/ebredow","followers_url":"https://api.github.com/users/ebredow/followers","following_url":"https://api.github.com/users/ebredow/following{/other_user}","gists_url":"https://api.github.com/users/ebredow/gists{/gist_id}","starred_url":"https://api.github.com/users/ebredow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebredow/subscriptions","organizations_url":"https://api.github.com/users/ebredow/orgs","repos_url":"https://api.github.com/users/ebredow/repos","events_url":"https://api.github.com/users/ebredow/events{/privacy}","received_events_url":"https://api.github.com/users/ebredow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ebredow/aspect","description":"A parallel, extendible finite element code to simulate thermal convection in both 2D and 3D models.","fork":true,"url":"https://api.github.com/repos/ebredow/aspect","forks_url":"https://api.github.com/repos/ebredow/aspect/forks","keys_url":"https://api.github.com/repos/ebredow/aspect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ebredow/aspect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ebredow/aspect/teams","hooks_url":"https://api.github.com/repos/ebredow/aspect/hooks","issue_events_url":"https://api.github.com/repos/ebredow/aspect/issues/events{/number}","events_url":"https://api.github.com/repos/ebredow/aspect/events","assignees_url":"https://api.github.com/repos/ebredow/aspect/assignees{/user}","branches_url":"https://api.github.com/repos/ebredow/aspect/branches{/branch}","tags_url":"https://api.github.com/repos/ebredow/aspect/tags","blobs_url":"https://api.github.com/repos/ebredow/aspect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ebredow/aspect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ebredow/aspect/git/refs{/sha}","trees_url":"https://api.github.com/repos/ebredow/aspect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ebredow/aspect/statuses/{sha}","languages_url":"https://api.github.com/repos/ebredow/aspect/languages","stargazers_url":"https://api.github.com/repos/ebredow/aspect/stargazers","contributors_url":"https://api.github.com/repos/ebredow/aspect/contributors","subscribers_url":"https://api.github.com/repos/ebredow/aspect/subscribers","subscription_url":"https://api.github.com/repos/ebredow/aspect/subscription","commits_url":"https://api.github.com/repos/ebredow/aspect/commits{/sha}","git_commits_url":"https://api.github.com/repos/ebredow/aspect/git/commits{/sha}","comments_url":"https://api.github.com/repos/ebredow/aspect/comments{/number}","issue_comment_url":"https://api.github.com/repos/ebredow/aspect/issues/comments/{number}","contents_url":"https://api.github.com/repos/ebredow/aspect/contents/{+path}","compare_url":"https://api.github.com/repos/ebredow/aspect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ebredow/aspect/merges","archive_url":"https://api.github.com/repos/ebredow/aspect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ebredow/aspect/downloads","issues_url":"https://api.github.com/repos/ebredow/aspect/issues{/number}","pulls_url":"https://api.github.com/repos/ebredow/aspect/pulls{/number}","milestones_url":"https://api.github.com/repos/ebredow/aspect/milestones{/number}","notifications_url":"https://api.github.com/repos/ebredow/aspect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ebredow/aspect/labels{/name}","releases_url":"https://api.github.com/repos/ebredow/aspect/releases{/id}","created_at":"2015-01-08T16:40:47Z","updated_at":"2015-01-08T16:40:53Z","pushed_at":"2015-01-09T13:09:00Z","git_url":"git://github.com/ebredow/aspect.git","ssh_url":"git@github.com:ebredow/aspect.git","clone_url":"https://github.com/ebredow/aspect.git","svn_url":"https://github.com/ebredow/aspect","homepage":"http://aspect.dealii.org/","size":106550,"stargazers_count":0,"watchers_count":0,"language":"Gnuplot","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"geodynamics:master","ref":"master","sha":"fef0a8c311e49678b2ecbce0941ac0f2fd57d12e","user":{"login":"geodynamics","id":4052461,"avatar_url":"https://avatars.githubusercontent.com/u/4052461?v=3","gravatar_id":"","url":"https://api.github.com/users/geodynamics","html_url":"https://github.com/geodynamics","followers_url":"https://api.github.com/users/geodynamics/followers","following_url":"https://api.github.com/users/geodynamics/following{/other_user}","gists_url":"https://api.github.com/users/geodynamics/gists{/gist_id}","starred_url":"https://api.github.com/users/geodynamics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geodynamics/subscriptions","organizations_url":"https://api.github.com/users/geodynamics/orgs","repos_url":"https://api.github.com/users/geodynamics/repos","events_url":"https://api.github.com/users/geodynamics/events{/privacy}","received_events_url":"https://api.github.com/users/geodynamics/received_events","type":"Organization","site_admin":false},"repo":{"id":19502452,"name":"aspect","full_name":"geodynamics/aspect","owner":{"login":"geodynamics","id":4052461,"avatar_url":"https://avatars.githubusercontent.com/u/4052461?v=3","gravatar_id":"","url":"https://api.github.com/users/geodynamics","html_url":"https://github.com/geodynamics","followers_url":"https://api.github.com/users/geodynamics/followers","following_url":"https://api.github.com/users/geodynamics/following{/other_user}","gists_url":"https://api.github.com/users/geodynamics/gists{/gist_id}","starred_url":"https://api.github.com/users/geodynamics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geodynamics/subscriptions","organizations_url":"https://api.github.com/users/geodynamics/orgs","repos_url":"https://api.github.com/users/geodynamics/repos","events_url":"https://api.github.com/users/geodynamics/events{/privacy}","received_events_url":"https://api.github.com/users/geodynamics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geodynamics/aspect","description":"A parallel, extendible finite element code to simulate thermal convection in both 2D and 3D models.","fork":false,"url":"https://api.github.com/repos/geodynamics/aspect","forks_url":"https://api.github.com/repos/geodynamics/aspect/forks","keys_url":"https://api.github.com/repos/geodynamics/aspect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geodynamics/aspect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geodynamics/aspect/teams","hooks_url":"https://api.github.com/repos/geodynamics/aspect/hooks","issue_events_url":"https://api.github.com/repos/geodynamics/aspect/issues/events{/number}","events_url":"https://api.github.com/repos/geodynamics/aspect/events","assignees_url":"https://api.github.com/repos/geodynamics/aspect/assignees{/user}","branches_url":"https://api.github.com/repos/geodynamics/aspect/branches{/branch}","tags_url":"https://api.github.com/repos/geodynamics/aspect/tags","blobs_url":"https://api.github.com/repos/geodynamics/aspect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geodynamics/aspect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geodynamics/aspect/git/refs{/sha}","trees_url":"https://api.github.com/repos/geodynamics/aspect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geodynamics/aspect/statuses/{sha}","languages_url":"https://api.github.com/repos/geodynamics/aspect/languages","stargazers_url":"https://api.github.com/repos/geodynamics/aspect/stargazers","contributors_url":"https://api.github.com/repos/geodynamics/aspect/contributors","subscribers_url":"https://api.github.com/repos/geodynamics/aspect/subscribers","subscription_url":"https://api.github.com/repos/geodynamics/aspect/subscription","commits_url":"https://api.github.com/repos/geodynamics/aspect/commits{/sha}","git_commits_url":"https://api.github.com/repos/geodynamics/aspect/git/commits{/sha}","comments_url":"https://api.github.com/repos/geodynamics/aspect/comments{/number}","issue_comment_url":"https://api.github.com/repos/geodynamics/aspect/issues/comments/{number}","contents_url":"https://api.github.com/repos/geodynamics/aspect/contents/{+path}","compare_url":"https://api.github.com/repos/geodynamics/aspect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geodynamics/aspect/merges","archive_url":"https://api.github.com/repos/geodynamics/aspect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geodynamics/aspect/downloads","issues_url":"https://api.github.com/repos/geodynamics/aspect/issues{/number}","pulls_url":"https://api.github.com/repos/geodynamics/aspect/pulls{/number}","milestones_url":"https://api.github.com/repos/geodynamics/aspect/milestones{/number}","notifications_url":"https://api.github.com/repos/geodynamics/aspect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geodynamics/aspect/labels{/name}","releases_url":"https://api.github.com/repos/geodynamics/aspect/releases{/id}","created_at":"2014-05-06T16:47:18Z","updated_at":"2015-01-10T00:21:49Z","pushed_at":"2015-01-10T00:21:44Z","git_url":"git://github.com/geodynamics/aspect.git","ssh_url":"git@github.com:geodynamics/aspect.git","clone_url":"https://github.com/geodynamics/aspect.git","svn_url":"https://github.com/geodynamics/aspect","homepage":"http://aspect.dealii.org/","size":106550,"stargazers_count":8,"watchers_count":8,"language":"Gnuplot","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":26,"forks":25,"open_issues":26,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/240"},"html":{"href":"https://github.com/geodynamics/aspect/pull/240"},"issue":{"href":"https://api.github.com/repos/geodynamics/aspect/issues/240"},"comments":{"href":"https://api.github.com/repos/geodynamics/aspect/issues/240/comments"},"review_comments":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/240/comments"},"review_comment":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/240/commits"},"statuses":{"href":"https://api.github.com/repos/geodynamics/aspect/statuses/41f0fd51704b4e6ecd94bce83f353165fdf940a7"}}}}