{"action":"created","comment":{"url":"https://api.github.com/repos/runk/protractor/pulls/comments/43346716","id":43346716,"diff_hunk":"@@ -34,97 +34,165 @@ util.inherits(TaskRunner, EventEmitter);\n  *       taskId, specs, capabilities, failedCount, exitCode, specResults\n  */\n TaskRunner.prototype.run = function() {\n-  var runResults = {\n-    taskId: this.task.taskId,\n-    specs: this.task.specs,\n-    capabilities: this.task.capabilities,\n-    // The following are populated while running the test:\n-    failedCount: 0,\n-    exitCode: -1,\n-    specResults: []\n-  };\n-\n-  if (this.runInFork) {\n-    var deferred = q.defer();\n-\n-    var childProcess = child.fork(\n-      __dirname + '/runnerCli.js',\n-      process.argv.slice(2), {\n-        cwd: process.cwd(),\n-        silent: true\n-      }\n-    );\n-    var taskLogger = new TaskLogger(this.task, childProcess.pid);\n-\n-    // stdout pipe\n-    childProcess.stdout.on('data', function(data) {\n-      taskLogger.log(data);\n-    });\n-\n-    // stderr pipe\n-    childProcess.stderr.on('data', function(data) {\n-      taskLogger.log(data);\n-    });\n-\n-    childProcess.on('message', function(m) {\n-      switch (m.event) {\n-        case 'testPass':\n-          log.print('.');\n-          break;\n-        case 'testFail':\n-          log.print('F');\n-          break;\n-        case 'testsDone':\n-          runResults.failedCount = m.results.failedCount;\n-          runResults.specResults = m.results.specResults;\n-          break;\n-      }\n-    })\n-    .on('error', function(err) {\n-      taskLogger.flush();\n-      deferred.reject(err);\n+  var deferred = q.defer();","path":"lib/taskRunner.js","position":53,"original_position":53,"commit_id":"92bdcdebfd8c02714c3021b0d718bb5cf515d1b0","original_commit_id":"92bdcdebfd8c02714c3021b0d718bb5cf515d1b0","user":{"login":"antklim","id":1148143,"avatar_url":"https://avatars.githubusercontent.com/u/1148143?v=3","gravatar_id":"","url":"https://api.github.com/users/antklim","html_url":"https://github.com/antklim","followers_url":"https://api.github.com/users/antklim/followers","following_url":"https://api.github.com/users/antklim/following{/other_user}","gists_url":"https://api.github.com/users/antklim/gists{/gist_id}","starred_url":"https://api.github.com/users/antklim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antklim/subscriptions","organizations_url":"https://api.github.com/users/antklim/orgs","repos_url":"https://api.github.com/users/antklim/repos","events_url":"https://api.github.com/users/antklim/events{/privacy}","received_events_url":"https://api.github.com/users/antklim/received_events","type":"User","site_admin":false},"body":"Why the half of the lines end with `;` and the other half with nothing?","created_at":"2015-10-29T03:53:11Z","updated_at":"2015-10-29T03:53:11Z","html_url":"https://github.com/runk/protractor/pull/1#discussion_r43346716","pull_request_url":"https://api.github.com/repos/runk/protractor/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/runk/protractor/pulls/comments/43346716"},"html":{"href":"https://github.com/runk/protractor/pull/1#discussion_r43346716"},"pull_request":{"href":"https://api.github.com/repos/runk/protractor/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/runk/protractor/pulls/1","id":48849034,"html_url":"https://github.com/runk/protractor/pull/1","diff_url":"https://github.com/runk/protractor/pull/1.diff","patch_url":"https://github.com/runk/protractor/pull/1.patch","issue_url":"https://api.github.com/repos/runk/protractor/issues/1","number":1,"state":"open","locked":false,"title":"Retires for task scheduler","user":{"login":"runk","id":903687,"avatar_url":"https://avatars.githubusercontent.com/u/903687?v=3","gravatar_id":"","url":"https://api.github.com/users/runk","html_url":"https://github.com/runk","followers_url":"https://api.github.com/users/runk/followers","following_url":"https://api.github.com/users/runk/following{/other_user}","gists_url":"https://api.github.com/users/runk/gists{/gist_id}","starred_url":"https://api.github.com/users/runk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runk/subscriptions","organizations_url":"https://api.github.com/users/runk/orgs","repos_url":"https://api.github.com/users/runk/repos","events_url":"https://api.github.com/users/runk/events{/privacy}","received_events_url":"https://api.github.com/users/runk/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-27T09:59:54Z","updated_at":"2015-10-29T03:53:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2b8a0865ae06fc4f19ad027b85f42404eaf106b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/runk/protractor/pulls/1/commits","review_comments_url":"https://api.github.com/repos/runk/protractor/pulls/1/comments","review_comment_url":"https://api.github.com/repos/runk/protractor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/runk/protractor/issues/1/comments","statuses_url":"https://api.github.com/repos/runk/protractor/statuses/92bdcdebfd8c02714c3021b0d718bb5cf515d1b0","head":{"label":"runk:retries","ref":"retries","sha":"92bdcdebfd8c02714c3021b0d718bb5cf515d1b0","user":{"login":"runk","id":903687,"avatar_url":"https://avatars.githubusercontent.com/u/903687?v=3","gravatar_id":"","url":"https://api.github.com/users/runk","html_url":"https://github.com/runk","followers_url":"https://api.github.com/users/runk/followers","following_url":"https://api.github.com/users/runk/following{/other_user}","gists_url":"https://api.github.com/users/runk/gists{/gist_id}","starred_url":"https://api.github.com/users/runk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runk/subscriptions","organizations_url":"https://api.github.com/users/runk/orgs","repos_url":"https://api.github.com/users/runk/repos","events_url":"https://api.github.com/users/runk/events{/privacy}","received_events_url":"https://api.github.com/users/runk/received_events","type":"User","site_admin":false},"repo":{"id":45018237,"name":"protractor","full_name":"runk/protractor","owner":{"login":"runk","id":903687,"avatar_url":"https://avatars.githubusercontent.com/u/903687?v=3","gravatar_id":"","url":"https://api.github.com/users/runk","html_url":"https://github.com/runk","followers_url":"https://api.github.com/users/runk/followers","following_url":"https://api.github.com/users/runk/following{/other_user}","gists_url":"https://api.github.com/users/runk/gists{/gist_id}","starred_url":"https://api.github.com/users/runk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runk/subscriptions","organizations_url":"https://api.github.com/users/runk/orgs","repos_url":"https://api.github.com/users/runk/repos","events_url":"https://api.github.com/users/runk/events{/privacy}","received_events_url":"https://api.github.com/users/runk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/runk/protractor","description":"E2E test framework for Angular apps","fork":true,"url":"https://api.github.com/repos/runk/protractor","forks_url":"https://api.github.com/repos/runk/protractor/forks","keys_url":"https://api.github.com/repos/runk/protractor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/runk/protractor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/runk/protractor/teams","hooks_url":"https://api.github.com/repos/runk/protractor/hooks","issue_events_url":"https://api.github.com/repos/runk/protractor/issues/events{/number}","events_url":"https://api.github.com/repos/runk/protractor/events","assignees_url":"https://api.github.com/repos/runk/protractor/assignees{/user}","branches_url":"https://api.github.com/repos/runk/protractor/branches{/branch}","tags_url":"https://api.github.com/repos/runk/protractor/tags","blobs_url":"https://api.github.com/repos/runk/protractor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/runk/protractor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/runk/protractor/git/refs{/sha}","trees_url":"https://api.github.com/repos/runk/protractor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/runk/protractor/statuses/{sha}","languages_url":"https://api.github.com/repos/runk/protractor/languages","stargazers_url":"https://api.github.com/repos/runk/protractor/stargazers","contributors_url":"https://api.github.com/repos/runk/protractor/contributors","subscribers_url":"https://api.github.com/repos/runk/protractor/subscribers","subscription_url":"https://api.github.com/repos/runk/protractor/subscription","commits_url":"https://api.github.com/repos/runk/protractor/commits{/sha}","git_commits_url":"https://api.github.com/repos/runk/protractor/git/commits{/sha}","comments_url":"https://api.github.com/repos/runk/protractor/comments{/number}","issue_comment_url":"https://api.github.com/repos/runk/protractor/issues/comments{/number}","contents_url":"https://api.github.com/repos/runk/protractor/contents/{+path}","compare_url":"https://api.github.com/repos/runk/protractor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/runk/protractor/merges","archive_url":"https://api.github.com/repos/runk/protractor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/runk/protractor/downloads","issues_url":"https://api.github.com/repos/runk/protractor/issues{/number}","pulls_url":"https://api.github.com/repos/runk/protractor/pulls{/number}","milestones_url":"https://api.github.com/repos/runk/protractor/milestones{/number}","notifications_url":"https://api.github.com/repos/runk/protractor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/runk/protractor/labels{/name}","releases_url":"https://api.github.com/repos/runk/protractor/releases{/id}","created_at":"2015-10-27T05:06:09Z","updated_at":"2015-10-27T05:06:10Z","pushed_at":"2015-10-29T03:17:20Z","git_url":"git://github.com/runk/protractor.git","ssh_url":"git@github.com:runk/protractor.git","clone_url":"https://github.com/runk/protractor.git","svn_url":"https://github.com/runk/protractor","homepage":"http://www.protractortest.org","size":4070,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"runk:master","ref":"master","sha":"bc16de70ae7f58474ba46ae4bf24497fab09ae70","user":{"login":"runk","id":903687,"avatar_url":"https://avatars.githubusercontent.com/u/903687?v=3","gravatar_id":"","url":"https://api.github.com/users/runk","html_url":"https://github.com/runk","followers_url":"https://api.github.com/users/runk/followers","following_url":"https://api.github.com/users/runk/following{/other_user}","gists_url":"https://api.github.com/users/runk/gists{/gist_id}","starred_url":"https://api.github.com/users/runk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runk/subscriptions","organizations_url":"https://api.github.com/users/runk/orgs","repos_url":"https://api.github.com/users/runk/repos","events_url":"https://api.github.com/users/runk/events{/privacy}","received_events_url":"https://api.github.com/users/runk/received_events","type":"User","site_admin":false},"repo":{"id":45018237,"name":"protractor","full_name":"runk/protractor","owner":{"login":"runk","id":903687,"avatar_url":"https://avatars.githubusercontent.com/u/903687?v=3","gravatar_id":"","url":"https://api.github.com/users/runk","html_url":"https://github.com/runk","followers_url":"https://api.github.com/users/runk/followers","following_url":"https://api.github.com/users/runk/following{/other_user}","gists_url":"https://api.github.com/users/runk/gists{/gist_id}","starred_url":"https://api.github.com/users/runk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runk/subscriptions","organizations_url":"https://api.github.com/users/runk/orgs","repos_url":"https://api.github.com/users/runk/repos","events_url":"https://api.github.com/users/runk/events{/privacy}","received_events_url":"https://api.github.com/users/runk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/runk/protractor","description":"E2E test framework for Angular apps","fork":true,"url":"https://api.github.com/repos/runk/protractor","forks_url":"https://api.github.com/repos/runk/protractor/forks","keys_url":"https://api.github.com/repos/runk/protractor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/runk/protractor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/runk/protractor/teams","hooks_url":"https://api.github.com/repos/runk/protractor/hooks","issue_events_url":"https://api.github.com/repos/runk/protractor/issues/events{/number}","events_url":"https://api.github.com/repos/runk/protractor/events","assignees_url":"https://api.github.com/repos/runk/protractor/assignees{/user}","branches_url":"https://api.github.com/repos/runk/protractor/branches{/branch}","tags_url":"https://api.github.com/repos/runk/protractor/tags","blobs_url":"https://api.github.com/repos/runk/protractor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/runk/protractor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/runk/protractor/git/refs{/sha}","trees_url":"https://api.github.com/repos/runk/protractor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/runk/protractor/statuses/{sha}","languages_url":"https://api.github.com/repos/runk/protractor/languages","stargazers_url":"https://api.github.com/repos/runk/protractor/stargazers","contributors_url":"https://api.github.com/repos/runk/protractor/contributors","subscribers_url":"https://api.github.com/repos/runk/protractor/subscribers","subscription_url":"https://api.github.com/repos/runk/protractor/subscription","commits_url":"https://api.github.com/repos/runk/protractor/commits{/sha}","git_commits_url":"https://api.github.com/repos/runk/protractor/git/commits{/sha}","comments_url":"https://api.github.com/repos/runk/protractor/comments{/number}","issue_comment_url":"https://api.github.com/repos/runk/protractor/issues/comments{/number}","contents_url":"https://api.github.com/repos/runk/protractor/contents/{+path}","compare_url":"https://api.github.com/repos/runk/protractor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/runk/protractor/merges","archive_url":"https://api.github.com/repos/runk/protractor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/runk/protractor/downloads","issues_url":"https://api.github.com/repos/runk/protractor/issues{/number}","pulls_url":"https://api.github.com/repos/runk/protractor/pulls{/number}","milestones_url":"https://api.github.com/repos/runk/protractor/milestones{/number}","notifications_url":"https://api.github.com/repos/runk/protractor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/runk/protractor/labels{/name}","releases_url":"https://api.github.com/repos/runk/protractor/releases{/id}","created_at":"2015-10-27T05:06:09Z","updated_at":"2015-10-27T05:06:10Z","pushed_at":"2015-10-29T03:17:20Z","git_url":"git://github.com/runk/protractor.git","ssh_url":"git@github.com:runk/protractor.git","clone_url":"https://github.com/runk/protractor.git","svn_url":"https://github.com/runk/protractor","homepage":"http://www.protractortest.org","size":4070,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/runk/protractor/pulls/1"},"html":{"href":"https://github.com/runk/protractor/pull/1"},"issue":{"href":"https://api.github.com/repos/runk/protractor/issues/1"},"comments":{"href":"https://api.github.com/repos/runk/protractor/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/runk/protractor/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/runk/protractor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/runk/protractor/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/runk/protractor/statuses/92bdcdebfd8c02714c3021b0d718bb5cf515d1b0"}}}}