{"action":"created","issue":{"url":"https://api.github.com/repos/jpcsupplies/Economy_mod/issues/55","labels_url":"https://api.github.com/repos/jpcsupplies/Economy_mod/issues/55/labels{/name}","comments_url":"https://api.github.com/repos/jpcsupplies/Economy_mod/issues/55/comments","events_url":"https://api.github.com/repos/jpcsupplies/Economy_mod/issues/55/events","html_url":"https://github.com/jpcsupplies/Economy_mod/issues/55","id":109659923,"number":55,"title":"Alpha Milestone Not Far to Go!","user":{"login":"jpcsupplies","id":13939039,"avatar_url":"https://avatars.githubusercontent.com/u/13939039?v=3","gravatar_id":"","url":"https://api.github.com/users/jpcsupplies","html_url":"https://github.com/jpcsupplies","followers_url":"https://api.github.com/users/jpcsupplies/followers","following_url":"https://api.github.com/users/jpcsupplies/following{/other_user}","gists_url":"https://api.github.com/users/jpcsupplies/gists{/gist_id}","starred_url":"https://api.github.com/users/jpcsupplies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpcsupplies/subscriptions","organizations_url":"https://api.github.com/users/jpcsupplies/orgs","repos_url":"https://api.github.com/users/jpcsupplies/repos","events_url":"https://api.github.com/users/jpcsupplies/events{/privacy}","received_events_url":"https://api.github.com/users/jpcsupplies/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-10-04T03:04:17Z","updated_at":"2015-10-20T10:56:40Z","closed_at":null,"body":"Looks like we are down to last three issues relevant to our alpha release:\r\nKey issues:\r\n* ~~#32 Buy from server command (basically cloning sell command but adding not removing; and dropping overflow at feet) (/buy X Y)  No \"all\" support is needed in this context. - needs #57 to finalize~~  done :+1: \r\n* ~~#35 request logic (display a prompt to accept or deny X action - may be reusable in several places) can be used when selling to players, or demanding payment from a player for services~~\r\n* #46 Sell items to other players - needs working request logic functionality\r\n\r\nENH or misc or OCD nitpicks\r\n* ~~#45 should resolve itself as part of above~~\r\n* #53 is not critical to operation of plugin but makes it inconvenient for admins to tweak pricing or blacklist.\r\n* #20 This can wait until next milestone - as it is dependent on #49 logic becoming functional which is needed for a bunch of other cool stuff like #44 logic\r\n* #6 purge logic - this can wait, we have everything we need, but it is not easy to implement without faction bank balances; or rethinking \"asset disposal\" logic..  not likely to become urgent unless servers start getting player turnover in the thousands\r\n* #33 this is basically moving our behavior constants to the config file. Once NPC trade is finalized, this can wait until our next milestone.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/jpcsupplies/Economy_mod/issues/comments/149524283","html_url":"https://github.com/jpcsupplies/Economy_mod/issues/55#issuecomment-149524283","issue_url":"https://api.github.com/repos/jpcsupplies/Economy_mod/issues/55","id":149524283,"user":{"login":"jpcsupplies","id":13939039,"avatar_url":"https://avatars.githubusercontent.com/u/13939039?v=3","gravatar_id":"","url":"https://api.github.com/users/jpcsupplies","html_url":"https://github.com/jpcsupplies","followers_url":"https://api.github.com/users/jpcsupplies/followers","following_url":"https://api.github.com/users/jpcsupplies/following{/other_user}","gists_url":"https://api.github.com/users/jpcsupplies/gists{/gist_id}","starred_url":"https://api.github.com/users/jpcsupplies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpcsupplies/subscriptions","organizations_url":"https://api.github.com/users/jpcsupplies/orgs","repos_url":"https://api.github.com/users/jpcsupplies/repos","events_url":"https://api.github.com/users/jpcsupplies/events{/privacy}","received_events_url":"https://api.github.com/users/jpcsupplies/received_events","type":"User","site_admin":false},"created_at":"2015-10-20T10:56:40Z","updated_at":"2015-10-20T10:56:40Z","body":"Testing results:\r\nScenario 1:  join server\r\non join i am informed timers ran out, type /sell collect to retrive items\r\ntwo rifles return to inventory.  (from my last test apparently)\r\n\r\nScenario 2: sell using incorrect syntax (alone on server)\r\n/sell 1 rifle lana 10\r\nit then appeared to sell to the NPC market instead of giving an error or such\r\n\r\nScenario 3: sell to online player\r\nlana then connected\r\nand i did /sell 1 rifle 10 lana\r\nthe offer sent to lana, on typing /sell accept\r\ni got a message \r\nyou just sold 10 worth of xxx (0 units)\r\nyou just purchased 10 worth of xxx (0 units)\r\nnothing appears to add to inventory\r\n\r\nScenario 4: deny the offer\r\nif i sell deny i get not yet complete and offer still remains active\r\n\r\nScenario 5: try to sell to offline player with correct syntax\r\nif i do /sell 1 rifle 10 lana\r\ni get sell not yet complete error\r\nbut rifle is removed from inventory no timeout seems to occur (but i may be just impatient)\r\n\r\nScenario 6:  use /sell collect\r\n2 rifles returned to my inventory\r\n"}}