{"action":"created","issue":{"url":"https://api.github.com/repos/ripple/rippled/issues/1142","labels_url":"https://api.github.com/repos/ripple/rippled/issues/1142/labels{/name}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/1142/comments","events_url":"https://api.github.com/repos/ripple/rippled/issues/1142/events","html_url":"https://github.com/ripple/rippled/pull/1142","id":90387639,"number":1142,"title":"Fix rm funded offer issue (RIPD-113)","user":{"login":"seelabs","id":5853458,"avatar_url":"https://avatars.githubusercontent.com/u/5853458?v=3","gravatar_id":"","url":"https://api.github.com/users/seelabs","html_url":"https://github.com/seelabs","followers_url":"https://api.github.com/users/seelabs/followers","following_url":"https://api.github.com/users/seelabs/following{/other_user}","gists_url":"https://api.github.com/users/seelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/seelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seelabs/subscriptions","organizations_url":"https://api.github.com/users/seelabs/orgs","repos_url":"https://api.github.com/users/seelabs/repos","events_url":"https://api.github.com/users/seelabs/events{/privacy}","received_events_url":"https://api.github.com/users/seelabs/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ripple/rippled/labels/Nik","name":"Nik","color":"eeeeee"},{"url":"https://api.github.com/repos/ripple/rippled/labels/Tom","name":"Tom","color":"eeeeee"},{"url":"https://api.github.com/repos/ripple/rippled/labels/Tx%20Change","name":"Tx Change","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":26,"created_at":"2015-06-23T13:22:36Z","updated_at":"2015-07-15T17:48:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/1142","html_url":"https://github.com/ripple/rippled/pull/1142","diff_url":"https://github.com/ripple/rippled/pull/1142.diff","patch_url":"https://github.com/ripple/rippled/pull/1142.patch"},"body":"In some cases, funded offers were incorrectly removed. This happened\r\nwhen:\r\n\r\n1) There are multiple payment paths.\r\n2) A payment path has a \"taker gets\" XRP immediately followed by another offer.\r\n3) There must be multiple offers at the same best quality for \"taker gets\" XRP. Neither offer should fully satisfy the payment.\r\n4) There must be multiple offers at the same best quality for the offer immediately following the \"taker gets\" XRP offer. Neither offer should fully satisfy the payment.\r\n5) The offer after the \"taker gets\" XRP causes the \"taker gets\" XRP offer to be added to the perm unfunded list when calculating reverse liquidity.\r\n4) The payment path is not used to satisfy the payment (there are other paths at better quality that do the job).\r\n\r\n@rec @nbougalis "},"comment":{"url":"https://api.github.com/repos/ripple/rippled/issues/comments/121691399","html_url":"https://github.com/ripple/rippled/pull/1142#issuecomment-121691399","issue_url":"https://api.github.com/repos/ripple/rippled/issues/1142","id":121691399,"user":{"login":"vinniefalco","id":1503976,"avatar_url":"https://avatars.githubusercontent.com/u/1503976?v=3","gravatar_id":"","url":"https://api.github.com/users/vinniefalco","html_url":"https://github.com/vinniefalco","followers_url":"https://api.github.com/users/vinniefalco/followers","following_url":"https://api.github.com/users/vinniefalco/following{/other_user}","gists_url":"https://api.github.com/users/vinniefalco/gists{/gist_id}","starred_url":"https://api.github.com/users/vinniefalco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinniefalco/subscriptions","organizations_url":"https://api.github.com/users/vinniefalco/orgs","repos_url":"https://api.github.com/users/vinniefalco/repos","events_url":"https://api.github.com/users/vinniefalco/events{/privacy}","received_events_url":"https://api.github.com/users/vinniefalco/received_events","type":"User","site_admin":false},"created_at":"2015-07-15T17:48:38Z","updated_at":"2015-07-15T17:48:38Z","body":"@rec `rippleCalc_.view.info().parentCloseTime` is not \"repeated code.\" Its a repeated trivial expression. As a general rule trivial expressions are already in their most reduced form. Furthermore functions should usually always be passed the minimum amount of information necessary to do their job."}}