{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/32862234","id":32862234,"diff_hunk":"@@ -157,6 +159,7 @@ func (j *jwtTokenAuthenticator) AuthenticateToken(token string) (user.Info, bool\n \t\t\t\tif (err.Errors & jwt.ValidationErrorSignatureInvalid) != 0 {\n \t\t\t\t\t// Signature error, perhaps one of the other keys will verify the signature\n \t\t\t\t\t// If not, we want to return this error\n+\t\t\t\t\tglog.V(4).Infof(\"Signature error (key %d): %v\", i, err)","path":"pkg/serviceaccount/jwt.go","position":22,"original_position":22,"commit_id":"1d3dca67962272b82610571a9619d97daf343ed4","original_commit_id":"1d3dca67962272b82610571a9619d97daf343ed4","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"signature verification tries keys in order. if you've rotated the signer, the old signer's public key would get bumped to position 2, and it would be useful to know failures were happening against the first and second public key. I think the index matters more than the key content","created_at":"2015-06-19T19:41:07Z","updated_at":"2015-06-19T19:41:07Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/10041#discussion_r32862234","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10041","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/32862234"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/10041#discussion_r32862234"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10041"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10041","id":38035165,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/10041","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/10041.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/10041.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/10041","number":10041,"state":"open","locked":false,"title":"Be more judicious about cleaning up service account tokens","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"As we moved some of our controllers to use service account credentials to run, we ran into a bug (https://github.com/openshift/origin/issues/3298) where the token controller was \"cleaning up\" tokens it didn't find a service account for. As a result, those controllers' reflectors API calls started failing.\r\n\r\nSomehow, the service account whose addition to the `serviceAccounts` store triggered token creation is missing from the same store when the secret addition is observed. @deads2k, @smarterclayton and I are still trying to figure out how that is possible, but in the meantime, this PR:\r\n* adds better logging around failed token auth to make it easier to debug situations like this\r\n* verifies a service account is actually missing if there is a cache miss before cleaning up a token for it","created_at":"2015-06-18T18:06:37Z","updated_at":"2015-06-19T19:41:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eaf72ed0915abcad11699c9eb8eb780f1e0dba66","assignee":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=3","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10041/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10041/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/10041/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/1d3dca67962272b82610571a9619d97daf343ed4","head":{"label":"liggitt:token_delete_live_check","ref":"token_delete_live_check","sha":"1d3dca67962272b82610571a9619d97daf343ed4","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"repo":{"id":22823654,"name":"kubernetes","full_name":"liggitt/kubernetes","owner":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/liggitt/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/liggitt/kubernetes","forks_url":"https://api.github.com/repos/liggitt/kubernetes/forks","keys_url":"https://api.github.com/repos/liggitt/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liggitt/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liggitt/kubernetes/teams","hooks_url":"https://api.github.com/repos/liggitt/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/liggitt/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/liggitt/kubernetes/events","assignees_url":"https://api.github.com/repos/liggitt/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/liggitt/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/liggitt/kubernetes/tags","blobs_url":"https://api.github.com/repos/liggitt/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liggitt/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liggitt/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/liggitt/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liggitt/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/liggitt/kubernetes/languages","stargazers_url":"https://api.github.com/repos/liggitt/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/liggitt/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/liggitt/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/liggitt/kubernetes/subscription","commits_url":"https://api.github.com/repos/liggitt/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/liggitt/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/liggitt/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/liggitt/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/liggitt/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/liggitt/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liggitt/kubernetes/merges","archive_url":"https://api.github.com/repos/liggitt/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liggitt/kubernetes/downloads","issues_url":"https://api.github.com/repos/liggitt/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/liggitt/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/liggitt/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/liggitt/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liggitt/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/liggitt/kubernetes/releases{/id}","created_at":"2014-08-11T01:56:03Z","updated_at":"2015-05-08T17:59:39Z","pushed_at":"2015-06-19T15:36:28Z","git_url":"git://github.com/liggitt/kubernetes.git","ssh_url":"git@github.com:liggitt/kubernetes.git","clone_url":"https://github.com/liggitt/kubernetes.git","svn_url":"https://github.com/liggitt/kubernetes","homepage":null,"size":76676,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"8062c6f0ad5c0411b2a83f4cb37c79de297cb046","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-06-19T19:07:29Z","pushed_at":"2015-06-19T19:39:25Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":294572,"stargazers_count":8513,"watchers_count":8513,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1827,"mirror_url":null,"open_issues_count":1402,"forks":1827,"open_issues":1402,"watchers":8513,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10041"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/10041"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/10041"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/10041/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10041/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10041/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/1d3dca67962272b82610571a9619d97daf343ed4"}}}}