{"action":"created","comment":{"url":"https://api.github.com/repos/europeana/europeana-portal-collections/pulls/comments/47335027","id":47335027,"diff_hunk":"@@ -0,0 +1,55 @@\n+# Rack::Rewrite rules\n+#\n+# Includes redirects for old portal query params to Rails/Blacklight equivalents\n+Rails.application.configure do\n+  config.middleware.insert_before(Rack::Runtime, Rack::Rewrite) do\n+    # Redirect searches with old params to app's equivalents\n+    # @todo Move the logic into a class\n+    r301 %r{/search(.html)?(\\?.*)},\n+      lambda { |match, rack_env|\n+        params = Rack::Utils.parse_query(rack_env['QUERY_STRING'])\n+\n+        # Search query\n+        params['q'] = params.delete('query') if params.key?('query')\n+\n+        # Search results per page\n+        rows = (params.delete('rows') || '24').to_i\n+\n+        # Search results page, adjusted to new 12-per-page default\n+        if params.key?('start')\n+          start = params.delete('start').to_i\n+          unless start <= rows\n+            per_page = (params['per_page'] || '12').to_i\n+            params['page'] = ((start - 1) / per_page) + 1\n+          end\n+        end\n+\n+        # Facet params\n+        if params.key?('qf')\n+          bl_facets = PortalController.blacklight_config.facet_fields.keys\n+          [params['qf']].flatten.each do |qf|\n+            if qf.include?(':')\n+              field, value = qf.split(':')\n+              if bl_facets.include?(field)\n+                params['f'] ||= {}\n+                params['f'][field] ||= []\n+                params['f'][field] << value\n+                if params['qf'].is_a?(Array)","path":"config/initializers/rack_rewrite.rb","position":37,"original_position":37,"commit_id":"7c6f598cea7b8e0a25f13bf759fcd3f7749dd46a","original_commit_id":"7c6f598cea7b8e0a25f13bf759fcd3f7749dd46a","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Avoid more than 3 levels of block nesting.","created_at":"2015-12-11T09:26:39Z","updated_at":"2015-12-11T09:26:39Z","html_url":"https://github.com/europeana/europeana-portal-collections/pull/300#discussion_r47335027","pull_request_url":"https://api.github.com/repos/europeana/europeana-portal-collections/pulls/300","_links":{"self":{"href":"https://api.github.com/repos/europeana/europeana-portal-collections/pulls/comments/47335027"},"html":{"href":"https://github.com/europeana/europeana-portal-collections/pull/300#discussion_r47335027"},"pull_request":{"href":"https://api.github.com/repos/europeana/europeana-portal-collections/pulls/300"}}},"pull_request":{"url":"https://api.github.com/repos/europeana/europeana-portal-collections/pulls/300","id":53370029,"html_url":"https://github.com/europeana/europeana-portal-collections/pull/300","diff_url":"https://github.com/europeana/europeana-portal-collections/pull/300.diff","patch_url":"https://github.com/europeana/europeana-portal-collections/pull/300.patch","issue_url":"https://api.github.com/repos/europeana/europeana-portal-collections/issues/300","number":300,"state":"open","locked":false,"title":"Re #738: Rack URL rewriting for old search params","user":{"login":"rwd","id":218337,"avatar_url":"https://avatars.githubusercontent.com/u/218337?v=3","gravatar_id":"","url":"https://api.github.com/users/rwd","html_url":"https://github.com/rwd","followers_url":"https://api.github.com/users/rwd/followers","following_url":"https://api.github.com/users/rwd/following{/other_user}","gists_url":"https://api.github.com/users/rwd/gists{/gist_id}","starred_url":"https://api.github.com/users/rwd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwd/subscriptions","organizations_url":"https://api.github.com/users/rwd/orgs","repos_url":"https://api.github.com/users/rwd/repos","events_url":"https://api.github.com/users/rwd/events{/privacy}","received_events_url":"https://api.github.com/users/rwd/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-11T09:26:36Z","updated_at":"2015-12-11T09:26:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90bb4adfc7c412db839167dcf95a15029de3fa2a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/europeana/europeana-portal-collections/pulls/300/commits","review_comments_url":"https://api.github.com/repos/europeana/europeana-portal-collections/pulls/300/comments","review_comment_url":"https://api.github.com/repos/europeana/europeana-portal-collections/pulls/comments{/number}","comments_url":"https://api.github.com/repos/europeana/europeana-portal-collections/issues/300/comments","statuses_url":"https://api.github.com/repos/europeana/europeana-portal-collections/statuses/7c6f598cea7b8e0a25f13bf759fcd3f7749dd46a","head":{"label":"europeana:feat/738-param-redirection-middleware","ref":"feat/738-param-redirection-middleware","sha":"7c6f598cea7b8e0a25f13bf759fcd3f7749dd46a","user":{"login":"europeana","id":4570681,"avatar_url":"https://avatars.githubusercontent.com/u/4570681?v=3","gravatar_id":"","url":"https://api.github.com/users/europeana","html_url":"https://github.com/europeana","followers_url":"https://api.github.com/users/europeana/followers","following_url":"https://api.github.com/users/europeana/following{/other_user}","gists_url":"https://api.github.com/users/europeana/gists{/gist_id}","starred_url":"https://api.github.com/users/europeana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/europeana/subscriptions","organizations_url":"https://api.github.com/users/europeana/orgs","repos_url":"https://api.github.com/users/europeana/repos","events_url":"https://api.github.com/users/europeana/events{/privacy}","received_events_url":"https://api.github.com/users/europeana/received_events","type":"Organization","site_admin":false},"repo":{"id":27171162,"name":"europeana-portal-collections","full_name":"europeana/europeana-portal-collections","owner":{"login":"europeana","id":4570681,"avatar_url":"https://avatars.githubusercontent.com/u/4570681?v=3","gravatar_id":"","url":"https://api.github.com/users/europeana","html_url":"https://github.com/europeana","followers_url":"https://api.github.com/users/europeana/followers","following_url":"https://api.github.com/users/europeana/following{/other_user}","gists_url":"https://api.github.com/users/europeana/gists{/gist_id}","starred_url":"https://api.github.com/users/europeana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/europeana/subscriptions","organizations_url":"https://api.github.com/users/europeana/orgs","repos_url":"https://api.github.com/users/europeana/repos","events_url":"https://api.github.com/users/europeana/events{/privacy}","received_events_url":"https://api.github.com/users/europeana/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/europeana/europeana-portal-collections","description":"Europeana Portal with Collections as a Rails + Blacklight application.","fork":false,"url":"https://api.github.com/repos/europeana/europeana-portal-collections","forks_url":"https://api.github.com/repos/europeana/europeana-portal-collections/forks","keys_url":"https://api.github.com/repos/europeana/europeana-portal-collections/keys{/key_id}","collaborators_url":"https://api.github.com/repos/europeana/europeana-portal-collections/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/europeana/europeana-portal-collections/teams","hooks_url":"https://api.github.com/repos/europeana/europeana-portal-collections/hooks","issue_events_url":"https://api.github.com/repos/europeana/europeana-portal-collections/issues/events{/number}","events_url":"https://api.github.com/repos/europeana/europeana-portal-collections/events","assignees_url":"https://api.github.com/repos/europeana/europeana-portal-collections/assignees{/user}","branches_url":"https://api.github.com/repos/europeana/europeana-portal-collections/branches{/branch}","tags_url":"https://api.github.com/repos/europeana/europeana-portal-collections/tags","blobs_url":"https://api.github.com/repos/europeana/europeana-portal-collections/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/europeana/europeana-portal-collections/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/europeana/europeana-portal-collections/git/refs{/sha}","trees_url":"https://api.github.com/repos/europeana/europeana-portal-collections/git/trees{/sha}","statuses_url":"https://api.github.com/repos/europeana/europeana-portal-collections/statuses/{sha}","languages_url":"https://api.github.com/repos/europeana/europeana-portal-collections/languages","stargazers_url":"https://api.github.com/repos/europeana/europeana-portal-collections/stargazers","contributors_url":"https://api.github.com/repos/europeana/europeana-portal-collections/contributors","subscribers_url":"https://api.github.com/repos/europeana/europeana-portal-collections/subscribers","subscription_url":"https://api.github.com/repos/europeana/europeana-portal-collections/subscription","commits_url":"https://api.github.com/repos/europeana/europeana-portal-collections/commits{/sha}","git_commits_url":"https://api.github.com/repos/europeana/europeana-portal-collections/git/commits{/sha}","comments_url":"https://api.github.com/repos/europeana/europeana-portal-collections/comments{/number}","issue_comment_url":"https://api.github.com/repos/europeana/europeana-portal-collections/issues/comments{/number}","contents_url":"https://api.github.com/repos/europeana/europeana-portal-collections/contents/{+path}","compare_url":"https://api.github.com/repos/europeana/europeana-portal-collections/compare/{base}...{head}","merges_url":"https://api.github.com/repos/europeana/europeana-portal-collections/merges","archive_url":"https://api.github.com/repos/europeana/europeana-portal-collections/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/europeana/europeana-portal-collections/downloads","issues_url":"https://api.github.com/repos/europeana/europeana-portal-collections/issues{/number}","pulls_url":"https://api.github.com/repos/europeana/europeana-portal-collections/pulls{/number}","milestones_url":"https://api.github.com/repos/europeana/europeana-portal-collections/milestones{/number}","notifications_url":"https://api.github.com/repos/europeana/europeana-portal-collections/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/europeana/europeana-portal-collections/labels{/name}","releases_url":"https://api.github.com/repos/europeana/europeana-portal-collections/releases{/id}","created_at":"2014-11-26T10:14:22Z","updated_at":"2015-10-28T11:43:24Z","pushed_at":"2015-12-11T09:26:37Z","git_url":"git://github.com/europeana/europeana-portal-collections.git","ssh_url":"git@github.com:europeana/europeana-portal-collections.git","clone_url":"https://github.com/europeana/europeana-portal-collections.git","svn_url":"https://github.com/europeana/europeana-portal-collections","homepage":"","size":2193,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":3,"default_branch":"develop"}},"base":{"label":"europeana:develop","ref":"develop","sha":"496bc465006f3cb03adf5c6c93f23d2377a64dfa","user":{"login":"europeana","id":4570681,"avatar_url":"https://avatars.githubusercontent.com/u/4570681?v=3","gravatar_id":"","url":"https://api.github.com/users/europeana","html_url":"https://github.com/europeana","followers_url":"https://api.github.com/users/europeana/followers","following_url":"https://api.github.com/users/europeana/following{/other_user}","gists_url":"https://api.github.com/users/europeana/gists{/gist_id}","starred_url":"https://api.github.com/users/europeana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/europeana/subscriptions","organizations_url":"https://api.github.com/users/europeana/orgs","repos_url":"https://api.github.com/users/europeana/repos","events_url":"https://api.github.com/users/europeana/events{/privacy}","received_events_url":"https://api.github.com/users/europeana/received_events","type":"Organization","site_admin":false},"repo":{"id":27171162,"name":"europeana-portal-collections","full_name":"europeana/europeana-portal-collections","owner":{"login":"europeana","id":4570681,"avatar_url":"https://avatars.githubusercontent.com/u/4570681?v=3","gravatar_id":"","url":"https://api.github.com/users/europeana","html_url":"https://github.com/europeana","followers_url":"https://api.github.com/users/europeana/followers","following_url":"https://api.github.com/users/europeana/following{/other_user}","gists_url":"https://api.github.com/users/europeana/gists{/gist_id}","starred_url":"https://api.github.com/users/europeana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/europeana/subscriptions","organizations_url":"https://api.github.com/users/europeana/orgs","repos_url":"https://api.github.com/users/europeana/repos","events_url":"https://api.github.com/users/europeana/events{/privacy}","received_events_url":"https://api.github.com/users/europeana/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/europeana/europeana-portal-collections","description":"Europeana Portal with Collections as a Rails + Blacklight application.","fork":false,"url":"https://api.github.com/repos/europeana/europeana-portal-collections","forks_url":"https://api.github.com/repos/europeana/europeana-portal-collections/forks","keys_url":"https://api.github.com/repos/europeana/europeana-portal-collections/keys{/key_id}","collaborators_url":"https://api.github.com/repos/europeana/europeana-portal-collections/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/europeana/europeana-portal-collections/teams","hooks_url":"https://api.github.com/repos/europeana/europeana-portal-collections/hooks","issue_events_url":"https://api.github.com/repos/europeana/europeana-portal-collections/issues/events{/number}","events_url":"https://api.github.com/repos/europeana/europeana-portal-collections/events","assignees_url":"https://api.github.com/repos/europeana/europeana-portal-collections/assignees{/user}","branches_url":"https://api.github.com/repos/europeana/europeana-portal-collections/branches{/branch}","tags_url":"https://api.github.com/repos/europeana/europeana-portal-collections/tags","blobs_url":"https://api.github.com/repos/europeana/europeana-portal-collections/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/europeana/europeana-portal-collections/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/europeana/europeana-portal-collections/git/refs{/sha}","trees_url":"https://api.github.com/repos/europeana/europeana-portal-collections/git/trees{/sha}","statuses_url":"https://api.github.com/repos/europeana/europeana-portal-collections/statuses/{sha}","languages_url":"https://api.github.com/repos/europeana/europeana-portal-collections/languages","stargazers_url":"https://api.github.com/repos/europeana/europeana-portal-collections/stargazers","contributors_url":"https://api.github.com/repos/europeana/europeana-portal-collections/contributors","subscribers_url":"https://api.github.com/repos/europeana/europeana-portal-collections/subscribers","subscription_url":"https://api.github.com/repos/europeana/europeana-portal-collections/subscription","commits_url":"https://api.github.com/repos/europeana/europeana-portal-collections/commits{/sha}","git_commits_url":"https://api.github.com/repos/europeana/europeana-portal-collections/git/commits{/sha}","comments_url":"https://api.github.com/repos/europeana/europeana-portal-collections/comments{/number}","issue_comment_url":"https://api.github.com/repos/europeana/europeana-portal-collections/issues/comments{/number}","contents_url":"https://api.github.com/repos/europeana/europeana-portal-collections/contents/{+path}","compare_url":"https://api.github.com/repos/europeana/europeana-portal-collections/compare/{base}...{head}","merges_url":"https://api.github.com/repos/europeana/europeana-portal-collections/merges","archive_url":"https://api.github.com/repos/europeana/europeana-portal-collections/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/europeana/europeana-portal-collections/downloads","issues_url":"https://api.github.com/repos/europeana/europeana-portal-collections/issues{/number}","pulls_url":"https://api.github.com/repos/europeana/europeana-portal-collections/pulls{/number}","milestones_url":"https://api.github.com/repos/europeana/europeana-portal-collections/milestones{/number}","notifications_url":"https://api.github.com/repos/europeana/europeana-portal-collections/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/europeana/europeana-portal-collections/labels{/name}","releases_url":"https://api.github.com/repos/europeana/europeana-portal-collections/releases{/id}","created_at":"2014-11-26T10:14:22Z","updated_at":"2015-10-28T11:43:24Z","pushed_at":"2015-12-11T09:26:37Z","git_url":"git://github.com/europeana/europeana-portal-collections.git","ssh_url":"git@github.com:europeana/europeana-portal-collections.git","clone_url":"https://github.com/europeana/europeana-portal-collections.git","svn_url":"https://github.com/europeana/europeana-portal-collections","homepage":"","size":2193,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/europeana/europeana-portal-collections/pulls/300"},"html":{"href":"https://github.com/europeana/europeana-portal-collections/pull/300"},"issue":{"href":"https://api.github.com/repos/europeana/europeana-portal-collections/issues/300"},"comments":{"href":"https://api.github.com/repos/europeana/europeana-portal-collections/issues/300/comments"},"review_comments":{"href":"https://api.github.com/repos/europeana/europeana-portal-collections/pulls/300/comments"},"review_comment":{"href":"https://api.github.com/repos/europeana/europeana-portal-collections/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/europeana/europeana-portal-collections/pulls/300/commits"},"statuses":{"href":"https://api.github.com/repos/europeana/europeana-portal-collections/statuses/7c6f598cea7b8e0a25f13bf759fcd3f7749dd46a"}}}}