{"action":"closed","number":275,"pull_request":{"url":"https://api.github.com/repos/apache/storm/pulls/275","id":22062459,"html_url":"https://github.com/apache/storm/pull/275","diff_url":"https://github.com/apache/storm/pull/275.diff","patch_url":"https://github.com/apache/storm/pull/275.patch","issue_url":"https://api.github.com/repos/apache/storm/issues/275","number":275,"state":"closed","locked":false,"title":"STORM-512 KafkaBolt doesn't handle ticks properly","user":{"login":"nielsbasjes","id":240096,"avatar_url":"https://avatars.githubusercontent.com/u/240096?v=3","gravatar_id":"","url":"https://api.github.com/users/nielsbasjes","html_url":"https://github.com/nielsbasjes","followers_url":"https://api.github.com/users/nielsbasjes/followers","following_url":"https://api.github.com/users/nielsbasjes/following{/other_user}","gists_url":"https://api.github.com/users/nielsbasjes/gists{/gist_id}","starred_url":"https://api.github.com/users/nielsbasjes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nielsbasjes/subscriptions","organizations_url":"https://api.github.com/users/nielsbasjes/orgs","repos_url":"https://api.github.com/users/nielsbasjes/repos","events_url":"https://api.github.com/users/nielsbasjes/events{/privacy}","received_events_url":"https://api.github.com/users/nielsbasjes/received_events","type":"User","site_admin":false},"body":"I implemented this by \r\n1.   Adding an 'boolean isTick()' method to the Tuple interface. \r\n       This way it is for application builders much easier to  determine if the tuple at hand is a Tick or not.\r\n2.   Letting the KafkaBolt use that method to ignore the ticks.\r\n3.   Updating the other place in the code base that handles ticks differently to use this new method.","created_at":"2014-10-01T09:59:24Z","updated_at":"2015-04-03T14:38:15Z","closed_at":"2015-04-03T14:38:15Z","merged_at":"2015-04-03T14:38:15Z","merge_commit_sha":"f3df2e3892bffd63d738f894c363670a4e25870b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/storm/pulls/275/commits","review_comments_url":"https://api.github.com/repos/apache/storm/pulls/275/comments","review_comment_url":"https://api.github.com/repos/apache/storm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/storm/issues/275/comments","statuses_url":"https://api.github.com/repos/apache/storm/statuses/1ca5f7659ea807f1ae83694788e889ac5cae6669","head":{"label":"nielsbasjes:STORM-512","ref":"STORM-512","sha":"1ca5f7659ea807f1ae83694788e889ac5cae6669","user":{"login":"nielsbasjes","id":240096,"avatar_url":"https://avatars.githubusercontent.com/u/240096?v=3","gravatar_id":"","url":"https://api.github.com/users/nielsbasjes","html_url":"https://github.com/nielsbasjes","followers_url":"https://api.github.com/users/nielsbasjes/followers","following_url":"https://api.github.com/users/nielsbasjes/following{/other_user}","gists_url":"https://api.github.com/users/nielsbasjes/gists{/gist_id}","starred_url":"https://api.github.com/users/nielsbasjes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nielsbasjes/subscriptions","organizations_url":"https://api.github.com/users/nielsbasjes/orgs","repos_url":"https://api.github.com/users/nielsbasjes/repos","events_url":"https://api.github.com/users/nielsbasjes/events{/privacy}","received_events_url":"https://api.github.com/users/nielsbasjes/received_events","type":"User","site_admin":false},"repo":{"id":24671108,"name":"storm","full_name":"nielsbasjes/storm","owner":{"login":"nielsbasjes","id":240096,"avatar_url":"https://avatars.githubusercontent.com/u/240096?v=3","gravatar_id":"","url":"https://api.github.com/users/nielsbasjes","html_url":"https://github.com/nielsbasjes","followers_url":"https://api.github.com/users/nielsbasjes/followers","following_url":"https://api.github.com/users/nielsbasjes/following{/other_user}","gists_url":"https://api.github.com/users/nielsbasjes/gists{/gist_id}","starred_url":"https://api.github.com/users/nielsbasjes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nielsbasjes/subscriptions","organizations_url":"https://api.github.com/users/nielsbasjes/orgs","repos_url":"https://api.github.com/users/nielsbasjes/repos","events_url":"https://api.github.com/users/nielsbasjes/events{/privacy}","received_events_url":"https://api.github.com/users/nielsbasjes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nielsbasjes/storm","description":"Mirror of Apache Storm","fork":true,"url":"https://api.github.com/repos/nielsbasjes/storm","forks_url":"https://api.github.com/repos/nielsbasjes/storm/forks","keys_url":"https://api.github.com/repos/nielsbasjes/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nielsbasjes/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nielsbasjes/storm/teams","hooks_url":"https://api.github.com/repos/nielsbasjes/storm/hooks","issue_events_url":"https://api.github.com/repos/nielsbasjes/storm/issues/events{/number}","events_url":"https://api.github.com/repos/nielsbasjes/storm/events","assignees_url":"https://api.github.com/repos/nielsbasjes/storm/assignees{/user}","branches_url":"https://api.github.com/repos/nielsbasjes/storm/branches{/branch}","tags_url":"https://api.github.com/repos/nielsbasjes/storm/tags","blobs_url":"https://api.github.com/repos/nielsbasjes/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nielsbasjes/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nielsbasjes/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/nielsbasjes/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nielsbasjes/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/nielsbasjes/storm/languages","stargazers_url":"https://api.github.com/repos/nielsbasjes/storm/stargazers","contributors_url":"https://api.github.com/repos/nielsbasjes/storm/contributors","subscribers_url":"https://api.github.com/repos/nielsbasjes/storm/subscribers","subscription_url":"https://api.github.com/repos/nielsbasjes/storm/subscription","commits_url":"https://api.github.com/repos/nielsbasjes/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/nielsbasjes/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/nielsbasjes/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/nielsbasjes/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/nielsbasjes/storm/contents/{+path}","compare_url":"https://api.github.com/repos/nielsbasjes/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nielsbasjes/storm/merges","archive_url":"https://api.github.com/repos/nielsbasjes/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nielsbasjes/storm/downloads","issues_url":"https://api.github.com/repos/nielsbasjes/storm/issues{/number}","pulls_url":"https://api.github.com/repos/nielsbasjes/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/nielsbasjes/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/nielsbasjes/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nielsbasjes/storm/labels{/name}","releases_url":"https://api.github.com/repos/nielsbasjes/storm/releases{/id}","created_at":"2014-10-01T08:31:16Z","updated_at":"2014-10-01T03:32:54Z","pushed_at":"2014-12-15T09:58:54Z","git_url":"git://github.com/nielsbasjes/storm.git","ssh_url":"git@github.com:nielsbasjes/storm.git","clone_url":"https://github.com/nielsbasjes/storm.git","svn_url":"https://github.com/nielsbasjes/storm","homepage":null,"size":11446,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"24b5eefb1553ae37951807502a433f24d3e95ec1","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":14135470,"name":"storm","full_name":"apache/storm","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/storm","description":"Mirror of Apache Storm","fork":false,"url":"https://api.github.com/repos/apache/storm","forks_url":"https://api.github.com/repos/apache/storm/forks","keys_url":"https://api.github.com/repos/apache/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/storm/teams","hooks_url":"https://api.github.com/repos/apache/storm/hooks","issue_events_url":"https://api.github.com/repos/apache/storm/issues/events{/number}","events_url":"https://api.github.com/repos/apache/storm/events","assignees_url":"https://api.github.com/repos/apache/storm/assignees{/user}","branches_url":"https://api.github.com/repos/apache/storm/branches{/branch}","tags_url":"https://api.github.com/repos/apache/storm/tags","blobs_url":"https://api.github.com/repos/apache/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/storm/languages","stargazers_url":"https://api.github.com/repos/apache/storm/stargazers","contributors_url":"https://api.github.com/repos/apache/storm/contributors","subscribers_url":"https://api.github.com/repos/apache/storm/subscribers","subscription_url":"https://api.github.com/repos/apache/storm/subscription","commits_url":"https://api.github.com/repos/apache/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/storm/contents/{+path}","compare_url":"https://api.github.com/repos/apache/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/storm/merges","archive_url":"https://api.github.com/repos/apache/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/storm/downloads","issues_url":"https://api.github.com/repos/apache/storm/issues{/number}","pulls_url":"https://api.github.com/repos/apache/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/storm/labels{/name}","releases_url":"https://api.github.com/repos/apache/storm/releases{/id}","created_at":"2013-11-05T08:00:14Z","updated_at":"2015-04-03T14:38:15Z","pushed_at":"2015-04-03T14:38:15Z","git_url":"git://github.com/apache/storm.git","ssh_url":"git@github.com:apache/storm.git","clone_url":"https://github.com/apache/storm.git","svn_url":"https://github.com/apache/storm","homepage":null,"size":880371,"stargazers_count":1752,"watchers_count":1752,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1136,"mirror_url":"git://git.apache.org/incubator-storm.git","open_issues_count":66,"forks":1136,"open_issues":66,"watchers":1752,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/275"},"html":{"href":"https://github.com/apache/storm/pull/275"},"issue":{"href":"https://api.github.com/repos/apache/storm/issues/275"},"comments":{"href":"https://api.github.com/repos/apache/storm/issues/275/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/storm/pulls/275/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/storm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/storm/pulls/275/commits"},"statuses":{"href":"https://api.github.com/repos/apache/storm/statuses/1ca5f7659ea807f1ae83694788e889ac5cae6669"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"asfgit","id":1341245,"avatar_url":"https://avatars.githubusercontent.com/u/1341245?v=3","gravatar_id":"","url":"https://api.github.com/users/asfgit","html_url":"https://github.com/asfgit","followers_url":"https://api.github.com/users/asfgit/followers","following_url":"https://api.github.com/users/asfgit/following{/other_user}","gists_url":"https://api.github.com/users/asfgit/gists{/gist_id}","starred_url":"https://api.github.com/users/asfgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asfgit/subscriptions","organizations_url":"https://api.github.com/users/asfgit/orgs","repos_url":"https://api.github.com/users/asfgit/repos","events_url":"https://api.github.com/users/asfgit/events{/privacy}","received_events_url":"https://api.github.com/users/asfgit/received_events","type":"User","site_admin":false},"comments":19,"review_comments":0,"commits":11,"additions":19,"deletions":11,"changed_files":5}}