{"action":"created","comment":{"url":"https://api.github.com/repos/mumble-voip/mumble/pulls/comments/44990336","id":44990336,"diff_hunk":"@@ -104,6 +107,9 @@ ACLEditor::ACLEditor(int channelid, const MumbleProto::ACL &mea, QWidget *p) : Q\n \tqsbChannelPosition->setRange(INT_MIN, INT_MAX);\n \tqsbChannelPosition->setValue(pChannel->iPosition);\n \n+\tqsbChannelMaxUsers->setRange(0, INT_MAX);\n+\tqsbChannelMaxUsers->setValue(pChannel->uiMaxUsers);","path":"src/mumble/ACLEditor.cpp","position":15,"original_position":15,"commit_id":"290e1a0d091ae301fa19e9bf94c46915c0436624","original_commit_id":"290e1a0d091ae301fa19e9bf94c46915c0436624","user":{"login":"hacst","id":237537,"avatar_url":"https://avatars.githubusercontent.com/u/237537?v=3","gravatar_id":"","url":"https://api.github.com/users/hacst","html_url":"https://github.com/hacst","followers_url":"https://api.github.com/users/hacst/followers","following_url":"https://api.github.com/users/hacst/following{/other_user}","gists_url":"https://api.github.com/users/hacst/gists{/gist_id}","starred_url":"https://api.github.com/users/hacst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hacst/subscriptions","organizations_url":"https://api.github.com/users/hacst/orgs","repos_url":"https://api.github.com/users/hacst/repos","events_url":"https://api.github.com/users/hacst/events{/privacy}","received_events_url":"https://api.github.com/users/hacst/received_events","type":"User","site_admin":false},"body":"We should use http://doc.qt.io/qt-4.8/qabstractspinbox.html#specialValueText-prop to display \"Unlimited\" (or something like that) instead of 0.","created_at":"2015-11-16T21:59:57Z","updated_at":"2015-11-16T21:59:57Z","html_url":"https://github.com/mumble-voip/mumble/pull/1889#discussion_r44990336","pull_request_url":"https://api.github.com/repos/mumble-voip/mumble/pulls/1889","_links":{"self":{"href":"https://api.github.com/repos/mumble-voip/mumble/pulls/comments/44990336"},"html":{"href":"https://github.com/mumble-voip/mumble/pull/1889#discussion_r44990336"},"pull_request":{"href":"https://api.github.com/repos/mumble-voip/mumble/pulls/1889"}}},"pull_request":{"url":"https://api.github.com/repos/mumble-voip/mumble/pulls/1889","id":50816122,"html_url":"https://github.com/mumble-voip/mumble/pull/1889","diff_url":"https://github.com/mumble-voip/mumble/pull/1889.diff","patch_url":"https://github.com/mumble-voip/mumble/pull/1889.patch","issue_url":"https://api.github.com/repos/mumble-voip/mumble/issues/1889","number":1889,"state":"open","locked":false,"title":"add per-channel user limit","user":{"login":"bontibon","id":110883,"avatar_url":"https://avatars.githubusercontent.com/u/110883?v=3","gravatar_id":"","url":"https://api.github.com/users/bontibon","html_url":"https://github.com/bontibon","followers_url":"https://api.github.com/users/bontibon/followers","following_url":"https://api.github.com/users/bontibon/following{/other_user}","gists_url":"https://api.github.com/users/bontibon/gists{/gist_id}","starred_url":"https://api.github.com/users/bontibon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bontibon/subscriptions","organizations_url":"https://api.github.com/users/bontibon/orgs","repos_url":"https://api.github.com/users/bontibon/repos","events_url":"https://api.github.com/users/bontibon/events{/privacy}","received_events_url":"https://api.github.com/users/bontibon/received_events","type":"User","site_admin":false},"body":"Adds ability to set per-channel user limit from the Mumble client.\r\n\r\nFixes #1619, #1882","created_at":"2015-11-16T14:28:22Z","updated_at":"2015-11-16T21:59:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ab6a86674f5f3c3fc42eb51d91db7d392007c77","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mumble-voip/mumble/pulls/1889/commits","review_comments_url":"https://api.github.com/repos/mumble-voip/mumble/pulls/1889/comments","review_comment_url":"https://api.github.com/repos/mumble-voip/mumble/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mumble-voip/mumble/issues/1889/comments","statuses_url":"https://api.github.com/repos/mumble-voip/mumble/statuses/290e1a0d091ae301fa19e9bf94c46915c0436624","head":{"label":"bontibon:maxchanuser","ref":"maxchanuser","sha":"290e1a0d091ae301fa19e9bf94c46915c0436624","user":{"login":"bontibon","id":110883,"avatar_url":"https://avatars.githubusercontent.com/u/110883?v=3","gravatar_id":"","url":"https://api.github.com/users/bontibon","html_url":"https://github.com/bontibon","followers_url":"https://api.github.com/users/bontibon/followers","following_url":"https://api.github.com/users/bontibon/following{/other_user}","gists_url":"https://api.github.com/users/bontibon/gists{/gist_id}","starred_url":"https://api.github.com/users/bontibon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bontibon/subscriptions","organizations_url":"https://api.github.com/users/bontibon/orgs","repos_url":"https://api.github.com/users/bontibon/repos","events_url":"https://api.github.com/users/bontibon/events{/privacy}","received_events_url":"https://api.github.com/users/bontibon/received_events","type":"User","site_admin":false},"repo":{"id":18245666,"name":"mumble","full_name":"bontibon/mumble","owner":{"login":"bontibon","id":110883,"avatar_url":"https://avatars.githubusercontent.com/u/110883?v=3","gravatar_id":"","url":"https://api.github.com/users/bontibon","html_url":"https://github.com/bontibon","followers_url":"https://api.github.com/users/bontibon/followers","following_url":"https://api.github.com/users/bontibon/following{/other_user}","gists_url":"https://api.github.com/users/bontibon/gists{/gist_id}","starred_url":"https://api.github.com/users/bontibon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bontibon/subscriptions","organizations_url":"https://api.github.com/users/bontibon/orgs","repos_url":"https://api.github.com/users/bontibon/repos","events_url":"https://api.github.com/users/bontibon/events{/privacy}","received_events_url":"https://api.github.com/users/bontibon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bontibon/mumble","description":"Mumble VoIP Client/Server","fork":true,"url":"https://api.github.com/repos/bontibon/mumble","forks_url":"https://api.github.com/repos/bontibon/mumble/forks","keys_url":"https://api.github.com/repos/bontibon/mumble/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bontibon/mumble/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bontibon/mumble/teams","hooks_url":"https://api.github.com/repos/bontibon/mumble/hooks","issue_events_url":"https://api.github.com/repos/bontibon/mumble/issues/events{/number}","events_url":"https://api.github.com/repos/bontibon/mumble/events","assignees_url":"https://api.github.com/repos/bontibon/mumble/assignees{/user}","branches_url":"https://api.github.com/repos/bontibon/mumble/branches{/branch}","tags_url":"https://api.github.com/repos/bontibon/mumble/tags","blobs_url":"https://api.github.com/repos/bontibon/mumble/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bontibon/mumble/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bontibon/mumble/git/refs{/sha}","trees_url":"https://api.github.com/repos/bontibon/mumble/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bontibon/mumble/statuses/{sha}","languages_url":"https://api.github.com/repos/bontibon/mumble/languages","stargazers_url":"https://api.github.com/repos/bontibon/mumble/stargazers","contributors_url":"https://api.github.com/repos/bontibon/mumble/contributors","subscribers_url":"https://api.github.com/repos/bontibon/mumble/subscribers","subscription_url":"https://api.github.com/repos/bontibon/mumble/subscription","commits_url":"https://api.github.com/repos/bontibon/mumble/commits{/sha}","git_commits_url":"https://api.github.com/repos/bontibon/mumble/git/commits{/sha}","comments_url":"https://api.github.com/repos/bontibon/mumble/comments{/number}","issue_comment_url":"https://api.github.com/repos/bontibon/mumble/issues/comments{/number}","contents_url":"https://api.github.com/repos/bontibon/mumble/contents/{+path}","compare_url":"https://api.github.com/repos/bontibon/mumble/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bontibon/mumble/merges","archive_url":"https://api.github.com/repos/bontibon/mumble/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bontibon/mumble/downloads","issues_url":"https://api.github.com/repos/bontibon/mumble/issues{/number}","pulls_url":"https://api.github.com/repos/bontibon/mumble/pulls{/number}","milestones_url":"https://api.github.com/repos/bontibon/mumble/milestones{/number}","notifications_url":"https://api.github.com/repos/bontibon/mumble/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bontibon/mumble/labels{/name}","releases_url":"https://api.github.com/repos/bontibon/mumble/releases{/id}","created_at":"2014-03-29T16:49:07Z","updated_at":"2015-10-13T05:53:06Z","pushed_at":"2015-11-16T21:44:16Z","git_url":"git://github.com/bontibon/mumble.git","ssh_url":"git@github.com:bontibon/mumble.git","clone_url":"https://github.com/bontibon/mumble.git","svn_url":"https://github.com/bontibon/mumble","homepage":"http://mumble.info","size":30692,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"grpc"}},"base":{"label":"mumble-voip:master","ref":"master","sha":"1f6a1f2e6a2aedef01e5808a2c6426bfcaf8c418","user":{"login":"mumble-voip","id":639008,"avatar_url":"https://avatars.githubusercontent.com/u/639008?v=3","gravatar_id":"","url":"https://api.github.com/users/mumble-voip","html_url":"https://github.com/mumble-voip","followers_url":"https://api.github.com/users/mumble-voip/followers","following_url":"https://api.github.com/users/mumble-voip/following{/other_user}","gists_url":"https://api.github.com/users/mumble-voip/gists{/gist_id}","starred_url":"https://api.github.com/users/mumble-voip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mumble-voip/subscriptions","organizations_url":"https://api.github.com/users/mumble-voip/orgs","repos_url":"https://api.github.com/users/mumble-voip/repos","events_url":"https://api.github.com/users/mumble-voip/events{/privacy}","received_events_url":"https://api.github.com/users/mumble-voip/received_events","type":"Organization","site_admin":false},"repo":{"id":1413319,"name":"mumble","full_name":"mumble-voip/mumble","owner":{"login":"mumble-voip","id":639008,"avatar_url":"https://avatars.githubusercontent.com/u/639008?v=3","gravatar_id":"","url":"https://api.github.com/users/mumble-voip","html_url":"https://github.com/mumble-voip","followers_url":"https://api.github.com/users/mumble-voip/followers","following_url":"https://api.github.com/users/mumble-voip/following{/other_user}","gists_url":"https://api.github.com/users/mumble-voip/gists{/gist_id}","starred_url":"https://api.github.com/users/mumble-voip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mumble-voip/subscriptions","organizations_url":"https://api.github.com/users/mumble-voip/orgs","repos_url":"https://api.github.com/users/mumble-voip/repos","events_url":"https://api.github.com/users/mumble-voip/events{/privacy}","received_events_url":"https://api.github.com/users/mumble-voip/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mumble-voip/mumble","description":"Mumble VoIP Client/Server","fork":false,"url":"https://api.github.com/repos/mumble-voip/mumble","forks_url":"https://api.github.com/repos/mumble-voip/mumble/forks","keys_url":"https://api.github.com/repos/mumble-voip/mumble/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mumble-voip/mumble/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mumble-voip/mumble/teams","hooks_url":"https://api.github.com/repos/mumble-voip/mumble/hooks","issue_events_url":"https://api.github.com/repos/mumble-voip/mumble/issues/events{/number}","events_url":"https://api.github.com/repos/mumble-voip/mumble/events","assignees_url":"https://api.github.com/repos/mumble-voip/mumble/assignees{/user}","branches_url":"https://api.github.com/repos/mumble-voip/mumble/branches{/branch}","tags_url":"https://api.github.com/repos/mumble-voip/mumble/tags","blobs_url":"https://api.github.com/repos/mumble-voip/mumble/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mumble-voip/mumble/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mumble-voip/mumble/git/refs{/sha}","trees_url":"https://api.github.com/repos/mumble-voip/mumble/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mumble-voip/mumble/statuses/{sha}","languages_url":"https://api.github.com/repos/mumble-voip/mumble/languages","stargazers_url":"https://api.github.com/repos/mumble-voip/mumble/stargazers","contributors_url":"https://api.github.com/repos/mumble-voip/mumble/contributors","subscribers_url":"https://api.github.com/repos/mumble-voip/mumble/subscribers","subscription_url":"https://api.github.com/repos/mumble-voip/mumble/subscription","commits_url":"https://api.github.com/repos/mumble-voip/mumble/commits{/sha}","git_commits_url":"https://api.github.com/repos/mumble-voip/mumble/git/commits{/sha}","comments_url":"https://api.github.com/repos/mumble-voip/mumble/comments{/number}","issue_comment_url":"https://api.github.com/repos/mumble-voip/mumble/issues/comments{/number}","contents_url":"https://api.github.com/repos/mumble-voip/mumble/contents/{+path}","compare_url":"https://api.github.com/repos/mumble-voip/mumble/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mumble-voip/mumble/merges","archive_url":"https://api.github.com/repos/mumble-voip/mumble/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mumble-voip/mumble/downloads","issues_url":"https://api.github.com/repos/mumble-voip/mumble/issues{/number}","pulls_url":"https://api.github.com/repos/mumble-voip/mumble/pulls{/number}","milestones_url":"https://api.github.com/repos/mumble-voip/mumble/milestones{/number}","notifications_url":"https://api.github.com/repos/mumble-voip/mumble/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mumble-voip/mumble/labels{/name}","releases_url":"https://api.github.com/repos/mumble-voip/mumble/releases{/id}","created_at":"2011-02-26T01:30:08Z","updated_at":"2015-11-16T14:33:59Z","pushed_at":"2015-11-16T21:56:42Z","git_url":"git://github.com/mumble-voip/mumble.git","ssh_url":"git@github.com:mumble-voip/mumble.git","clone_url":"https://github.com/mumble-voip/mumble.git","svn_url":"https://github.com/mumble-voip/mumble","homepage":"http://www.mumble.info","size":37831,"stargazers_count":1005,"watchers_count":1005,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":330,"mirror_url":null,"open_issues_count":427,"forks":330,"open_issues":427,"watchers":1005,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mumble-voip/mumble/pulls/1889"},"html":{"href":"https://github.com/mumble-voip/mumble/pull/1889"},"issue":{"href":"https://api.github.com/repos/mumble-voip/mumble/issues/1889"},"comments":{"href":"https://api.github.com/repos/mumble-voip/mumble/issues/1889/comments"},"review_comments":{"href":"https://api.github.com/repos/mumble-voip/mumble/pulls/1889/comments"},"review_comment":{"href":"https://api.github.com/repos/mumble-voip/mumble/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mumble-voip/mumble/pulls/1889/commits"},"statuses":{"href":"https://api.github.com/repos/mumble-voip/mumble/statuses/290e1a0d091ae301fa19e9bf94c46915c0436624"}}}}