{"action":"created","comment":{"url":"https://api.github.com/repos/google/cadvisor/pulls/comments/33368961","id":33368961,"diff_hunk":"@@ -0,0 +1,100 @@\n+// Copyright 2015 Google Inc. All Rights Reserved.\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+//     http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+package collector\n+\n+import (\n+\t\"encoding/json\"\n+\t\"io/ioutil\"\n+\t\"time\"\n+\n+\t\"github.com/google/cadvisor/info/v2\"\n+)\n+\n+type Collector struct {","path":"collector/collector.go","position":25,"original_position":25,"commit_id":"e1be4ca110ffceebb537c8b1774cbb7fab6b482d","original_commit_id":"e1be4ca110ffceebb537c8b1774cbb7fab6b482d","user":{"login":"vmarmol","id":985208,"avatar_url":"https://avatars.githubusercontent.com/u/985208?v=3","gravatar_id":"","url":"https://api.github.com/users/vmarmol","html_url":"https://github.com/vmarmol","followers_url":"https://api.github.com/users/vmarmol/followers","following_url":"https://api.github.com/users/vmarmol/following{/other_user}","gists_url":"https://api.github.com/users/vmarmol/gists{/gist_id}","starred_url":"https://api.github.com/users/vmarmol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmarmol/subscriptions","organizations_url":"https://api.github.com/users/vmarmol/orgs","repos_url":"https://api.github.com/users/vmarmol/repos","events_url":"https://api.github.com/users/vmarmol/events{/privacy}","received_events_url":"https://api.github.com/users/vmarmol/received_events","type":"User","site_admin":false},"body":"I'd call this `GenericCollector` or `GeneralCollector` and leave the interface as `Collector` :)","created_at":"2015-06-26T15:58:39Z","updated_at":"2015-06-26T15:58:39Z","html_url":"https://github.com/google/cadvisor/pull/775#discussion_r33368961","pull_request_url":"https://api.github.com/repos/google/cadvisor/pulls/775","_links":{"self":{"href":"https://api.github.com/repos/google/cadvisor/pulls/comments/33368961"},"html":{"href":"https://github.com/google/cadvisor/pull/775#discussion_r33368961"},"pull_request":{"href":"https://api.github.com/repos/google/cadvisor/pulls/775"}}},"pull_request":{"url":"https://api.github.com/repos/google/cadvisor/pulls/775","id":38149857,"html_url":"https://github.com/google/cadvisor/pull/775","diff_url":"https://github.com/google/cadvisor/pull/775.diff","patch_url":"https://github.com/google/cadvisor/pull/775.patch","issue_url":"https://api.github.com/repos/google/cadvisor/issues/775","number":775,"state":"open","locked":false,"title":"Add config file for custom metrics and pull config file into a suitable structure","user":{"login":"anushree-n","id":12520254,"avatar_url":"https://avatars.githubusercontent.com/u/12520254?v=3","gravatar_id":"","url":"https://api.github.com/users/anushree-n","html_url":"https://github.com/anushree-n","followers_url":"https://api.github.com/users/anushree-n/followers","following_url":"https://api.github.com/users/anushree-n/following{/other_user}","gists_url":"https://api.github.com/users/anushree-n/gists{/gist_id}","starred_url":"https://api.github.com/users/anushree-n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anushree-n/subscriptions","organizations_url":"https://api.github.com/users/anushree-n/orgs","repos_url":"https://api.github.com/users/anushree-n/repos","events_url":"https://api.github.com/users/anushree-n/events{/privacy}","received_events_url":"https://api.github.com/users/anushree-n/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-19T21:31:00Z","updated_at":"2015-06-26T15:58:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"185fad5b9fbe9414d728d2cd8373369c7e8c4bbd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/cadvisor/pulls/775/commits","review_comments_url":"https://api.github.com/repos/google/cadvisor/pulls/775/comments","review_comment_url":"https://api.github.com/repos/google/cadvisor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/cadvisor/issues/775/comments","statuses_url":"https://api.github.com/repos/google/cadvisor/statuses/e1be4ca110ffceebb537c8b1774cbb7fab6b482d","head":{"label":"anushree-n:master","ref":"master","sha":"e1be4ca110ffceebb537c8b1774cbb7fab6b482d","user":{"login":"anushree-n","id":12520254,"avatar_url":"https://avatars.githubusercontent.com/u/12520254?v=3","gravatar_id":"","url":"https://api.github.com/users/anushree-n","html_url":"https://github.com/anushree-n","followers_url":"https://api.github.com/users/anushree-n/followers","following_url":"https://api.github.com/users/anushree-n/following{/other_user}","gists_url":"https://api.github.com/users/anushree-n/gists{/gist_id}","starred_url":"https://api.github.com/users/anushree-n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anushree-n/subscriptions","organizations_url":"https://api.github.com/users/anushree-n/orgs","repos_url":"https://api.github.com/users/anushree-n/repos","events_url":"https://api.github.com/users/anushree-n/events{/privacy}","received_events_url":"https://api.github.com/users/anushree-n/received_events","type":"User","site_admin":false},"repo":{"id":37743674,"name":"cadvisor","full_name":"anushree-n/cadvisor","owner":{"login":"anushree-n","id":12520254,"avatar_url":"https://avatars.githubusercontent.com/u/12520254?v=3","gravatar_id":"","url":"https://api.github.com/users/anushree-n","html_url":"https://github.com/anushree-n","followers_url":"https://api.github.com/users/anushree-n/followers","following_url":"https://api.github.com/users/anushree-n/following{/other_user}","gists_url":"https://api.github.com/users/anushree-n/gists{/gist_id}","starred_url":"https://api.github.com/users/anushree-n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anushree-n/subscriptions","organizations_url":"https://api.github.com/users/anushree-n/orgs","repos_url":"https://api.github.com/users/anushree-n/repos","events_url":"https://api.github.com/users/anushree-n/events{/privacy}","received_events_url":"https://api.github.com/users/anushree-n/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anushree-n/cadvisor","description":"Analyzes resource usage and performance characteristics of running containers.","fork":true,"url":"https://api.github.com/repos/anushree-n/cadvisor","forks_url":"https://api.github.com/repos/anushree-n/cadvisor/forks","keys_url":"https://api.github.com/repos/anushree-n/cadvisor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anushree-n/cadvisor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anushree-n/cadvisor/teams","hooks_url":"https://api.github.com/repos/anushree-n/cadvisor/hooks","issue_events_url":"https://api.github.com/repos/anushree-n/cadvisor/issues/events{/number}","events_url":"https://api.github.com/repos/anushree-n/cadvisor/events","assignees_url":"https://api.github.com/repos/anushree-n/cadvisor/assignees{/user}","branches_url":"https://api.github.com/repos/anushree-n/cadvisor/branches{/branch}","tags_url":"https://api.github.com/repos/anushree-n/cadvisor/tags","blobs_url":"https://api.github.com/repos/anushree-n/cadvisor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anushree-n/cadvisor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anushree-n/cadvisor/git/refs{/sha}","trees_url":"https://api.github.com/repos/anushree-n/cadvisor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anushree-n/cadvisor/statuses/{sha}","languages_url":"https://api.github.com/repos/anushree-n/cadvisor/languages","stargazers_url":"https://api.github.com/repos/anushree-n/cadvisor/stargazers","contributors_url":"https://api.github.com/repos/anushree-n/cadvisor/contributors","subscribers_url":"https://api.github.com/repos/anushree-n/cadvisor/subscribers","subscription_url":"https://api.github.com/repos/anushree-n/cadvisor/subscription","commits_url":"https://api.github.com/repos/anushree-n/cadvisor/commits{/sha}","git_commits_url":"https://api.github.com/repos/anushree-n/cadvisor/git/commits{/sha}","comments_url":"https://api.github.com/repos/anushree-n/cadvisor/comments{/number}","issue_comment_url":"https://api.github.com/repos/anushree-n/cadvisor/issues/comments{/number}","contents_url":"https://api.github.com/repos/anushree-n/cadvisor/contents/{+path}","compare_url":"https://api.github.com/repos/anushree-n/cadvisor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anushree-n/cadvisor/merges","archive_url":"https://api.github.com/repos/anushree-n/cadvisor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anushree-n/cadvisor/downloads","issues_url":"https://api.github.com/repos/anushree-n/cadvisor/issues{/number}","pulls_url":"https://api.github.com/repos/anushree-n/cadvisor/pulls{/number}","milestones_url":"https://api.github.com/repos/anushree-n/cadvisor/milestones{/number}","notifications_url":"https://api.github.com/repos/anushree-n/cadvisor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anushree-n/cadvisor/labels{/name}","releases_url":"https://api.github.com/repos/anushree-n/cadvisor/releases{/id}","created_at":"2015-06-19T20:13:54Z","updated_at":"2015-06-19T20:13:55Z","pushed_at":"2015-06-24T20:27:33Z","git_url":"git://github.com/anushree-n/cadvisor.git","ssh_url":"git@github.com:anushree-n/cadvisor.git","clone_url":"https://github.com/anushree-n/cadvisor.git","svn_url":"https://github.com/anushree-n/cadvisor","homepage":"","size":18180,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"afc21887db5f650bf2f0b114c6e87600ceb66b87","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":20653934,"name":"cadvisor","full_name":"google/cadvisor","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/cadvisor","description":"Analyzes resource usage and performance characteristics of running containers.","fork":false,"url":"https://api.github.com/repos/google/cadvisor","forks_url":"https://api.github.com/repos/google/cadvisor/forks","keys_url":"https://api.github.com/repos/google/cadvisor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/cadvisor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/cadvisor/teams","hooks_url":"https://api.github.com/repos/google/cadvisor/hooks","issue_events_url":"https://api.github.com/repos/google/cadvisor/issues/events{/number}","events_url":"https://api.github.com/repos/google/cadvisor/events","assignees_url":"https://api.github.com/repos/google/cadvisor/assignees{/user}","branches_url":"https://api.github.com/repos/google/cadvisor/branches{/branch}","tags_url":"https://api.github.com/repos/google/cadvisor/tags","blobs_url":"https://api.github.com/repos/google/cadvisor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/cadvisor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/cadvisor/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/cadvisor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/cadvisor/statuses/{sha}","languages_url":"https://api.github.com/repos/google/cadvisor/languages","stargazers_url":"https://api.github.com/repos/google/cadvisor/stargazers","contributors_url":"https://api.github.com/repos/google/cadvisor/contributors","subscribers_url":"https://api.github.com/repos/google/cadvisor/subscribers","subscription_url":"https://api.github.com/repos/google/cadvisor/subscription","commits_url":"https://api.github.com/repos/google/cadvisor/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/cadvisor/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/cadvisor/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/cadvisor/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/cadvisor/contents/{+path}","compare_url":"https://api.github.com/repos/google/cadvisor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/cadvisor/merges","archive_url":"https://api.github.com/repos/google/cadvisor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/cadvisor/downloads","issues_url":"https://api.github.com/repos/google/cadvisor/issues{/number}","pulls_url":"https://api.github.com/repos/google/cadvisor/pulls{/number}","milestones_url":"https://api.github.com/repos/google/cadvisor/milestones{/number}","notifications_url":"https://api.github.com/repos/google/cadvisor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/cadvisor/labels{/name}","releases_url":"https://api.github.com/repos/google/cadvisor/releases{/id}","created_at":"2014-06-09T16:36:33Z","updated_at":"2015-06-26T08:45:05Z","pushed_at":"2015-06-25T19:21:34Z","git_url":"git://github.com/google/cadvisor.git","ssh_url":"git@github.com:google/cadvisor.git","clone_url":"https://github.com/google/cadvisor.git","svn_url":"https://github.com/google/cadvisor","homepage":"","size":26016,"stargazers_count":2541,"watchers_count":2541,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":287,"mirror_url":null,"open_issues_count":59,"forks":287,"open_issues":59,"watchers":2541,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/cadvisor/pulls/775"},"html":{"href":"https://github.com/google/cadvisor/pull/775"},"issue":{"href":"https://api.github.com/repos/google/cadvisor/issues/775"},"comments":{"href":"https://api.github.com/repos/google/cadvisor/issues/775/comments"},"review_comments":{"href":"https://api.github.com/repos/google/cadvisor/pulls/775/comments"},"review_comment":{"href":"https://api.github.com/repos/google/cadvisor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/cadvisor/pulls/775/commits"},"statuses":{"href":"https://api.github.com/repos/google/cadvisor/statuses/e1be4ca110ffceebb537c8b1774cbb7fab6b482d"}}}}