{"action":"created","issue":{"url":"https://api.github.com/repos/kamailio/kamailio/issues/257","labels_url":"https://api.github.com/repos/kamailio/kamailio/issues/257/labels{/name}","comments_url":"https://api.github.com/repos/kamailio/kamailio/issues/257/comments","events_url":"https://api.github.com/repos/kamailio/kamailio/issues/257/events","html_url":"https://github.com/kamailio/kamailio/pull/257","id":96090240,"number":257,"title":"rr: add enable_double_rr_always option","user":{"login":"krieger-od","id":803351,"avatar_url":"https://avatars.githubusercontent.com/u/803351?v=3","gravatar_id":"","url":"https://api.github.com/users/krieger-od","html_url":"https://github.com/krieger-od","followers_url":"https://api.github.com/users/krieger-od/followers","following_url":"https://api.github.com/users/krieger-od/following{/other_user}","gists_url":"https://api.github.com/users/krieger-od/gists{/gist_id}","starred_url":"https://api.github.com/users/krieger-od/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krieger-od/subscriptions","organizations_url":"https://api.github.com/users/krieger-od/orgs","repos_url":"https://api.github.com/users/krieger-od/repos","events_url":"https://api.github.com/users/krieger-od/events{/privacy}","received_events_url":"https://api.github.com/users/krieger-od/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-07-20T15:34:40Z","updated_at":"2015-08-03T17:33:23Z","closed_at":"2015-07-30T10:36:14Z","pull_request":{"url":"https://api.github.com/repos/kamailio/kamailio/pulls/257","html_url":"https://github.com/kamailio/kamailio/pull/257","diff_url":"https://github.com/kamailio/kamailio/pull/257.diff","patch_url":"https://github.com/kamailio/kamailio/pull/257.patch"},"body":"This patch helps us to handle inadequatness of Linphone mobile apps (both iOS and Android flavours are affected) without reinventing a lot of logics to handle each transport (we use TCP, TLS, WS, WSS).\r\nE.g. if we have two TLS-based Linphone clients, even with enable_double_rr for gentle cross-forwarding we would get single RR header without transport= attribute, resulting in Linphone sending ACK and BYE via UDP.\r\nThis new option, being enabled, results in two RR headers being always inserted, with transport attribute being always added. I believe this cannot harm the installation with enable_double_rr, just makes instructions more explicit.\r\nThe Linphone's behaviour looks like a set of different bugs, but it would get us much more efforts to fix.\r\nI don't know if any other useragent needs such workaround. So I would perfectly understand if this commit wouldn't be accepted upstream.\r\n\r\nAlso this commit currently lacks README doc rebuild, because I don't know how to do that. Only XML doc is updated."},"comment":{"url":"https://api.github.com/repos/kamailio/kamailio/issues/comments/127339688","html_url":"https://github.com/kamailio/kamailio/pull/257#issuecomment-127339688","issue_url":"https://api.github.com/repos/kamailio/kamailio/issues/257","id":127339688,"user":{"login":"krieger-od","id":803351,"avatar_url":"https://avatars.githubusercontent.com/u/803351?v=3","gravatar_id":"","url":"https://api.github.com/users/krieger-od","html_url":"https://github.com/krieger-od","followers_url":"https://api.github.com/users/krieger-od/followers","following_url":"https://api.github.com/users/krieger-od/following{/other_user}","gists_url":"https://api.github.com/users/krieger-od/gists{/gist_id}","starred_url":"https://api.github.com/users/krieger-od/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krieger-od/subscriptions","organizations_url":"https://api.github.com/users/krieger-od/orgs","repos_url":"https://api.github.com/users/krieger-od/repos","events_url":"https://api.github.com/users/krieger-od/events{/privacy}","received_events_url":"https://api.github.com/users/krieger-od/received_events","type":"User","site_admin":false},"created_at":"2015-08-03T17:33:23Z","updated_at":"2015-08-03T17:33:23Z","body":"Damn, sorry for unrelated change in tcp_read.c in my commit. Thank you for fixing that."}}