{"action":"created","issue":{"url":"https://api.github.com/repos/hypothesis/h/issues/2215","labels_url":"https://api.github.com/repos/hypothesis/h/issues/2215/labels{/name}","comments_url":"https://api.github.com/repos/hypothesis/h/issues/2215/comments","events_url":"https://api.github.com/repos/hypothesis/h/issues/2215/events","html_url":"https://github.com/hypothesis/h/pull/2215","id":73494608,"number":2215,"title":"Add ability to share via links from the sidebar.","user":{"login":"RawKStar77","id":521978,"avatar_url":"https://avatars.githubusercontent.com/u/521978?v=3","gravatar_id":"","url":"https://api.github.com/users/RawKStar77","html_url":"https://github.com/RawKStar77","followers_url":"https://api.github.com/users/RawKStar77/followers","following_url":"https://api.github.com/users/RawKStar77/following{/other_user}","gists_url":"https://api.github.com/users/RawKStar77/gists{/gist_id}","starred_url":"https://api.github.com/users/RawKStar77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RawKStar77/subscriptions","organizations_url":"https://api.github.com/users/RawKStar77/orgs","repos_url":"https://api.github.com/users/RawKStar77/repos","events_url":"https://api.github.com/users/RawKStar77/events{/privacy}","received_events_url":"https://api.github.com/users/RawKStar77/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/hypothesis/h/milestones/16","html_url":"https://github.com/hypothesis/h/milestones/05-19-2015","labels_url":"https://api.github.com/repos/hypothesis/h/milestones/16/labels","id":1097366,"number":16,"title":"05-19-2015","description":"","creator":{"login":"judell","id":46509,"avatar_url":"https://avatars.githubusercontent.com/u/46509?v=3","gravatar_id":"","url":"https://api.github.com/users/judell","html_url":"https://github.com/judell","followers_url":"https://api.github.com/users/judell/followers","following_url":"https://api.github.com/users/judell/following{/other_user}","gists_url":"https://api.github.com/users/judell/gists{/gist_id}","starred_url":"https://api.github.com/users/judell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/judell/subscriptions","organizations_url":"https://api.github.com/users/judell/orgs","repos_url":"https://api.github.com/users/judell/repos","events_url":"https://api.github.com/users/judell/events{/privacy}","received_events_url":"https://api.github.com/users/judell/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":14,"state":"open","created_at":"2015-05-05T18:12:11Z","updated_at":"2015-06-02T18:43:35Z","due_on":"2015-05-19T07:00:00Z","closed_at":null},"comments":47,"created_at":"2015-05-06T02:39:19Z","updated_at":"2015-06-03T15:39:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hypothesis/h/pulls/2215","html_url":"https://github.com/hypothesis/h/pull/2215","diff_url":"https://github.com/hypothesis/h/pull/2215.diff","patch_url":"https://github.com/hypothesis/h/pull/2215.patch"},"body":"Did a little bit more design work and thinking around sharing today, I'm submitting this PR as an alternative to #2012.\r\n\r\nHere's what the new share dialog looks like:\r\n![Share dialog](https://cloud.githubusercontent.com/assets/521978/7845043/43ec6584-0469-11e5-9214-635273516620.png)\r\n\r\nThe changes include:\r\n- Use the canonical url for generating via links. \r\n- Generate via uri in the share-dialog directive. (Thanks @csillag and @gergely-ujvari!)\r\n- Introduce toolbar share icon, the tooltip says \"Share this page\"\r\n- Update help/welcome page to cover sharing\r\n- Add simple sharing via Facebook, Twitter, Google plus, and email\r\n- Add social media icons to icomoon\r\n\r\n**Edit:** We used have a share button on each annotation that links to the standalone annotation page. In the name of simplifying, I had removed it for the time being (thinking we should add it back when we can directly link to an annotation *in context*), but put it back after some outcry. Changes were made in a separate PR: https://github.com/hypothesis/h/pull/2231"},"comment":{"url":"https://api.github.com/repos/hypothesis/h/issues/comments/108488674","html_url":"https://github.com/hypothesis/h/pull/2215#issuecomment-108488674","issue_url":"https://api.github.com/repos/hypothesis/h/issues/2215","id":108488674,"user":{"login":"nickstenning","id":3602,"avatar_url":"https://avatars.githubusercontent.com/u/3602?v=3","gravatar_id":"","url":"https://api.github.com/users/nickstenning","html_url":"https://github.com/nickstenning","followers_url":"https://api.github.com/users/nickstenning/followers","following_url":"https://api.github.com/users/nickstenning/following{/other_user}","gists_url":"https://api.github.com/users/nickstenning/gists{/gist_id}","starred_url":"https://api.github.com/users/nickstenning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickstenning/subscriptions","organizations_url":"https://api.github.com/users/nickstenning/orgs","repos_url":"https://api.github.com/users/nickstenning/repos","events_url":"https://api.github.com/users/nickstenning/events{/privacy}","received_events_url":"https://api.github.com/users/nickstenning/received_events","type":"User","site_admin":false},"created_at":"2015-06-03T15:39:55Z","updated_at":"2015-06-03T15:39:55Z","body":"This has been open forever, and it's now looking pretty good. I'd love to merge it, but it doesn't seem to have any tests. Could you add some tests for the share-dialog directive?"}}