{"action":"created","comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/47016287","id":47016287,"diff_hunk":"@@ -148,14 +152,21 @@ module.exports = React.createClass( {\n \t},\n \n \trender: function() {\n-\t\tvar codePlaceholder = '123456';\n+\t\tvar codePlaceholder = this.translate( 'e.g. 123456', {\n+\t\t\tcontext: '6 digit two factor code placeholder.',\n+\t\t\ttextOnly: true\n+\t\t} );\n \n \t\tif ( this.props.twoStepAuthorization.isTwoStepSMSEnabled() ) {\n-\t\t\tcodePlaceholder = '1234567';\n+\t\t\tcodePlaceholder = this.translate( 'e.g. 1234567', {\n+\t\t\t\tcontext: '7 digit two factor code placeholder.',\n+\t\t\t\ttextOnly: true\n+\t\t\t} );\n \t\t}\n \n \t\treturn (\n \t\t\t<Dialog\n+\t\t\t\tautoFocus={ false }","path":"client/me/reauth-required/index.jsx","position":31,"original_position":31,"commit_id":"729ed72c525d5deb7a1262aab67f7b150012ab41","original_commit_id":"729ed72c525d5deb7a1262aab67f7b150012ab41","user":{"login":"lezama","id":104869,"avatar_url":"https://avatars.githubusercontent.com/u/104869?v=3","gravatar_id":"","url":"https://api.github.com/users/lezama","html_url":"https://github.com/lezama","followers_url":"https://api.github.com/users/lezama/followers","following_url":"https://api.github.com/users/lezama/following{/other_user}","gists_url":"https://api.github.com/users/lezama/gists{/gist_id}","starred_url":"https://api.github.com/users/lezama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lezama/subscriptions","organizations_url":"https://api.github.com/users/lezama/orgs","repos_url":"https://api.github.com/users/lezama/repos","events_url":"https://api.github.com/users/lezama/events{/privacy}","received_events_url":"https://api.github.com/users/lezama/received_events","type":"User","site_admin":false},"body":"Is this prop necessary?","created_at":"2015-12-08T21:29:17Z","updated_at":"2015-12-08T21:29:17Z","html_url":"https://github.com/Automattic/wp-calypso/pull/1386#discussion_r47016287","pull_request_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/1386","_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/47016287"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/1386#discussion_r47016287"},"pull_request":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/1386"}}},"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/1386","id":53019318,"html_url":"https://github.com/Automattic/wp-calypso/pull/1386","diff_url":"https://github.com/Automattic/wp-calypso/pull/1386.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/1386.patch","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/1386","number":1386,"state":"open","locked":false,"title":"Me: 2fa Reauth Required Improvements","user":{"login":"ebinnion","id":1126811,"avatar_url":"https://avatars.githubusercontent.com/u/1126811?v=3","gravatar_id":"","url":"https://api.github.com/users/ebinnion","html_url":"https://github.com/ebinnion","followers_url":"https://api.github.com/users/ebinnion/followers","following_url":"https://api.github.com/users/ebinnion/following{/other_user}","gists_url":"https://api.github.com/users/ebinnion/gists{/gist_id}","starred_url":"https://api.github.com/users/ebinnion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebinnion/subscriptions","organizations_url":"https://api.github.com/users/ebinnion/orgs","repos_url":"https://api.github.com/users/ebinnion/repos","events_url":"https://api.github.com/users/ebinnion/events{/privacy}","received_events_url":"https://api.github.com/users/ebinnion/received_events","type":"User","site_admin":false},"body":"Fixes #401\r\nFixes #400\r\n\r\nThis PR allows auto focusing of the 2fa code input when the reauth required dialog opens in `/me`.\r\n\r\nI found a similar solution in [this commit](https://github.com/Automattic/calypso-pre-oss/commit/abff3fc2242f65a621e30719a61eee7f1ab246b2) from Gregory Cornelius. :bow: \r\n\r\n![reauth-autofocus](https://cloud.githubusercontent.com/assets/1126811/11664424/498707e2-9da7-11e5-9794-985ee785b0de.gif)\r\n\r\ncc @v18 and @lezama for review\r\n\r\nTo test:\r\n- Checkout `fix/me-reauth-autofocus`\r\n- Go to WordPress.com\r\n- Delete `twostep_auth` cookie\r\n- Go to `/me` in Calypso\r\n- In the dialog that pops up, the input should focus automagically","created_at":"2015-12-08T18:30:32Z","updated_at":"2015-12-08T21:29:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e6b864ce0b6696a879960bc82820470cc773703","assignee":{"login":"ebinnion","id":1126811,"avatar_url":"https://avatars.githubusercontent.com/u/1126811?v=3","gravatar_id":"","url":"https://api.github.com/users/ebinnion","html_url":"https://github.com/ebinnion","followers_url":"https://api.github.com/users/ebinnion/followers","following_url":"https://api.github.com/users/ebinnion/following{/other_user}","gists_url":"https://api.github.com/users/ebinnion/gists{/gist_id}","starred_url":"https://api.github.com/users/ebinnion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebinnion/subscriptions","organizations_url":"https://api.github.com/users/ebinnion/orgs","repos_url":"https://api.github.com/users/ebinnion/repos","events_url":"https://api.github.com/users/ebinnion/events{/privacy}","received_events_url":"https://api.github.com/users/ebinnion/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/Automattic/wp-calypso/milestones/44","html_url":"https://github.com/Automattic/wp-calypso/milestones/Mercury%20Me%20&%20Jetpack%20Plans%20bug%20scrub","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones/44/labels","id":1448766,"number":44,"title":"Mercury Me & Jetpack Plans bug scrub","description":"The bug scrub as described here. https://mercuryo2.wordpress.com/2015/12/04/mercury-maintenance-plan-for-end-of-year/\r\n","creator":{"login":"enejb","id":115071,"avatar_url":"https://avatars.githubusercontent.com/u/115071?v=3","gravatar_id":"","url":"https://api.github.com/users/enejb","html_url":"https://github.com/enejb","followers_url":"https://api.github.com/users/enejb/followers","following_url":"https://api.github.com/users/enejb/following{/other_user}","gists_url":"https://api.github.com/users/enejb/gists{/gist_id}","starred_url":"https://api.github.com/users/enejb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enejb/subscriptions","organizations_url":"https://api.github.com/users/enejb/orgs","repos_url":"https://api.github.com/users/enejb/repos","events_url":"https://api.github.com/users/enejb/events{/privacy}","received_events_url":"https://api.github.com/users/enejb/received_events","type":"User","site_admin":false},"open_issues":39,"closed_issues":7,"state":"open","created_at":"2015-12-07T21:59:52Z","updated_at":"2015-12-08T18:30:32Z","due_on":"2015-12-31T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/1386/commits","review_comments_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/1386/comments","review_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/1386/comments","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/729ed72c525d5deb7a1262aab67f7b150012ab41","head":{"label":"Automattic:fix/me-reauth-autofocus","ref":"fix/me-reauth-autofocus","sha":"729ed72c525d5deb7a1262aab67f7b150012ab41","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","created_at":"2015-11-10T20:00:16Z","updated_at":"2015-12-08T21:04:15Z","pushed_at":"2015-12-08T21:26:08Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":12005,"stargazers_count":5985,"watchers_count":5985,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":641,"mirror_url":null,"open_issues_count":823,"forks":641,"open_issues":823,"watchers":5985,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"b56c49ad713e7a88178f3fd0e545a311176d3517","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","created_at":"2015-11-10T20:00:16Z","updated_at":"2015-12-08T21:04:15Z","pushed_at":"2015-12-08T21:26:08Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":12005,"stargazers_count":5985,"watchers_count":5985,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":641,"mirror_url":null,"open_issues_count":823,"forks":641,"open_issues":823,"watchers":5985,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/1386"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/1386"},"issue":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/1386"},"comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/1386/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/1386/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/1386/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/wp-calypso/statuses/729ed72c525d5deb7a1262aab67f7b150012ab41"}}}}