{"action":"created","comment":{"url":"https://api.github.com/repos/acquia/personalize_module/pulls/comments/28916512","id":28916512,"diff_hunk":"@@ -0,0 +1,78 @@\n+<?php\n+\n+/**\n+ * @file personalize_taxonomy_context.module\n+ * Provides a visitor context plugin for taxonomy.\n+ */\n+\n+/**\n+ * Implements hook_personalize_visitor_contexts().\n+ */\n+function personalize_taxonomy_context_personalize_visitor_context() {\n+  $info = array();\n+  $path = drupal_get_path('module', 'personalize_taxonomy_context') . '/plugins';\n+  $info['taxonomy_context'] = array(\n+    'path' => $path . '/visitor_context',\n+    'handler' => array(\n+      'file' => 'TaxonomyContext.inc',\n+      'class' => 'TaxonomyContext',\n+    ),\n+  );\n+  return $info;\n+}\n+\n+/**\n+ * Implements hook_node_view().\n+ */\n+function personalize_taxonomy_context_node_view($node, $view_mode, $langcode) {\n+  personalize_taxonomy_context_node_taxonomy($node, $view_mode == 'full');\n+}\n+\n+/**\n+ * Handles the node-specific taxonomy data.\n+ *\n+ * @param $node\n+ *   (optional) If passed then the taxonomy terms for the selected node","path":"modules/personalize_taxonomy_context/personalize_taxonomy_context.module","position":35,"original_position":35,"commit_id":"847827bab2323c84bb307be3704deb904569b40c","original_commit_id":"8f08aa446555eea4585614c011ee43cc6e6f1d57","user":{"login":"ynx","id":1379691,"avatar_url":"https://avatars.githubusercontent.com/u/1379691?v=3","gravatar_id":"","url":"https://api.github.com/users/ynx","html_url":"https://github.com/ynx","followers_url":"https://api.github.com/users/ynx/followers","following_url":"https://api.github.com/users/ynx/following{/other_user}","gists_url":"https://api.github.com/users/ynx/gists{/gist_id}","starred_url":"https://api.github.com/users/ynx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ynx/subscriptions","organizations_url":"https://api.github.com/users/ynx/orgs","repos_url":"https://api.github.com/users/ynx/repos","events_url":"https://api.github.com/users/ynx/events{/privacy}","received_events_url":"https://api.github.com/users/ynx/received_events","type":"User","site_admin":false},"body":"Same reason you did in [here](https://github.com/acquia/visitor_actions/blame/7.x-1.x/visitor_actions.module#L617) and [here](https://github.com/acquia/acquia_lift/blame/7.x-1.x/acquia_lift_profiles/acquia_lift_profiles.module#L433)? =D\r\n\r\nTo be serious, I think it is \"optional\" because 1) when the node is passed in, we are scooping up the node's taxonomy, and 2) when the node is not passed in, we are using the function to retrieve statically stored taxonomy.","created_at":"2015-04-22T21:26:10Z","updated_at":"2015-04-22T21:26:10Z","html_url":"https://github.com/acquia/personalize_module/pull/102#discussion_r28916512","pull_request_url":"https://api.github.com/repos/acquia/personalize_module/pulls/102","_links":{"self":{"href":"https://api.github.com/repos/acquia/personalize_module/pulls/comments/28916512"},"html":{"href":"https://github.com/acquia/personalize_module/pull/102#discussion_r28916512"},"pull_request":{"href":"https://api.github.com/repos/acquia/personalize_module/pulls/102"}}},"pull_request":{"url":"https://api.github.com/repos/acquia/personalize_module/pulls/102","id":33225253,"html_url":"https://github.com/acquia/personalize_module/pull/102","diff_url":"https://github.com/acquia/personalize_module/pull/102.diff","patch_url":"https://github.com/acquia/personalize_module/pull/102.patch","issue_url":"https://api.github.com/repos/acquia/personalize_module/issues/102","number":102,"state":"open","locked":false,"title":"Ch 1770 Change Vocabulary Mappings to use any visitor context; make vocabulary a visitor context too","user":{"login":"ynx","id":1379691,"avatar_url":"https://avatars.githubusercontent.com/u/1379691?v=3","gravatar_id":"","url":"https://api.github.com/users/ynx","html_url":"https://github.com/ynx","followers_url":"https://api.github.com/users/ynx/followers","following_url":"https://api.github.com/users/ynx/following{/other_user}","gists_url":"https://api.github.com/users/ynx/gists{/gist_id}","starred_url":"https://api.github.com/users/ynx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ynx/subscriptions","organizations_url":"https://api.github.com/users/ynx/orgs","repos_url":"https://api.github.com/users/ynx/repos","events_url":"https://api.github.com/users/ynx/events{/privacy}","received_events_url":"https://api.github.com/users/ynx/received_events","type":"User","site_admin":false},"body":"I am creating this pull request so Kat can review my current approach. I feel I may not have implemented in the most informed ways, that's why I'm hoping we can take a look right now and figure out how I can do better.","created_at":"2015-04-14T04:19:33Z","updated_at":"2015-04-22T21:26:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4ddc3d3824576803bbb47d64fa5d2290cce7fbd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/acquia/personalize_module/pulls/102/commits","review_comments_url":"https://api.github.com/repos/acquia/personalize_module/pulls/102/comments","review_comment_url":"https://api.github.com/repos/acquia/personalize_module/pulls/comments{/number}","comments_url":"https://api.github.com/repos/acquia/personalize_module/issues/102/comments","statuses_url":"https://api.github.com/repos/acquia/personalize_module/statuses/847827bab2323c84bb307be3704deb904569b40c","head":{"label":"acquia:CH-1770","ref":"CH-1770","sha":"847827bab2323c84bb307be3704deb904569b40c","user":{"login":"acquia","id":514789,"avatar_url":"https://avatars.githubusercontent.com/u/514789?v=3","gravatar_id":"","url":"https://api.github.com/users/acquia","html_url":"https://github.com/acquia","followers_url":"https://api.github.com/users/acquia/followers","following_url":"https://api.github.com/users/acquia/following{/other_user}","gists_url":"https://api.github.com/users/acquia/gists{/gist_id}","starred_url":"https://api.github.com/users/acquia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acquia/subscriptions","organizations_url":"https://api.github.com/users/acquia/orgs","repos_url":"https://api.github.com/users/acquia/repos","events_url":"https://api.github.com/users/acquia/events{/privacy}","received_events_url":"https://api.github.com/users/acquia/received_events","type":"Organization","site_admin":false},"repo":{"id":17369639,"name":"personalize_module","full_name":"acquia/personalize_module","owner":{"login":"acquia","id":514789,"avatar_url":"https://avatars.githubusercontent.com/u/514789?v=3","gravatar_id":"","url":"https://api.github.com/users/acquia","html_url":"https://github.com/acquia","followers_url":"https://api.github.com/users/acquia/followers","following_url":"https://api.github.com/users/acquia/following{/other_user}","gists_url":"https://api.github.com/users/acquia/gists{/gist_id}","starred_url":"https://api.github.com/users/acquia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acquia/subscriptions","organizations_url":"https://api.github.com/users/acquia/orgs","repos_url":"https://api.github.com/users/acquia/repos","events_url":"https://api.github.com/users/acquia/events{/privacy}","received_events_url":"https://api.github.com/users/acquia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/acquia/personalize_module","description":"","fork":false,"url":"https://api.github.com/repos/acquia/personalize_module","forks_url":"https://api.github.com/repos/acquia/personalize_module/forks","keys_url":"https://api.github.com/repos/acquia/personalize_module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acquia/personalize_module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acquia/personalize_module/teams","hooks_url":"https://api.github.com/repos/acquia/personalize_module/hooks","issue_events_url":"https://api.github.com/repos/acquia/personalize_module/issues/events{/number}","events_url":"https://api.github.com/repos/acquia/personalize_module/events","assignees_url":"https://api.github.com/repos/acquia/personalize_module/assignees{/user}","branches_url":"https://api.github.com/repos/acquia/personalize_module/branches{/branch}","tags_url":"https://api.github.com/repos/acquia/personalize_module/tags","blobs_url":"https://api.github.com/repos/acquia/personalize_module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acquia/personalize_module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acquia/personalize_module/git/refs{/sha}","trees_url":"https://api.github.com/repos/acquia/personalize_module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acquia/personalize_module/statuses/{sha}","languages_url":"https://api.github.com/repos/acquia/personalize_module/languages","stargazers_url":"https://api.github.com/repos/acquia/personalize_module/stargazers","contributors_url":"https://api.github.com/repos/acquia/personalize_module/contributors","subscribers_url":"https://api.github.com/repos/acquia/personalize_module/subscribers","subscription_url":"https://api.github.com/repos/acquia/personalize_module/subscription","commits_url":"https://api.github.com/repos/acquia/personalize_module/commits{/sha}","git_commits_url":"https://api.github.com/repos/acquia/personalize_module/git/commits{/sha}","comments_url":"https://api.github.com/repos/acquia/personalize_module/comments{/number}","issue_comment_url":"https://api.github.com/repos/acquia/personalize_module/issues/comments{/number}","contents_url":"https://api.github.com/repos/acquia/personalize_module/contents/{+path}","compare_url":"https://api.github.com/repos/acquia/personalize_module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acquia/personalize_module/merges","archive_url":"https://api.github.com/repos/acquia/personalize_module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acquia/personalize_module/downloads","issues_url":"https://api.github.com/repos/acquia/personalize_module/issues{/number}","pulls_url":"https://api.github.com/repos/acquia/personalize_module/pulls{/number}","milestones_url":"https://api.github.com/repos/acquia/personalize_module/milestones{/number}","notifications_url":"https://api.github.com/repos/acquia/personalize_module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acquia/personalize_module/labels{/name}","releases_url":"https://api.github.com/repos/acquia/personalize_module/releases{/id}","created_at":"2014-03-03T15:10:12Z","updated_at":"2014-10-03T15:16:14Z","pushed_at":"2015-04-22T21:17:15Z","git_url":"git://github.com/acquia/personalize_module.git","ssh_url":"git@github.com:acquia/personalize_module.git","clone_url":"https://github.com/acquia/personalize_module.git","svn_url":"https://github.com/acquia/personalize_module","homepage":null,"size":4809,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":8,"forks":3,"open_issues":8,"watchers":1,"default_branch":"master"}},"base":{"label":"acquia:develop","ref":"develop","sha":"dd81675192c356e8d9a26aecbefe24825b0e5cb4","user":{"login":"acquia","id":514789,"avatar_url":"https://avatars.githubusercontent.com/u/514789?v=3","gravatar_id":"","url":"https://api.github.com/users/acquia","html_url":"https://github.com/acquia","followers_url":"https://api.github.com/users/acquia/followers","following_url":"https://api.github.com/users/acquia/following{/other_user}","gists_url":"https://api.github.com/users/acquia/gists{/gist_id}","starred_url":"https://api.github.com/users/acquia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acquia/subscriptions","organizations_url":"https://api.github.com/users/acquia/orgs","repos_url":"https://api.github.com/users/acquia/repos","events_url":"https://api.github.com/users/acquia/events{/privacy}","received_events_url":"https://api.github.com/users/acquia/received_events","type":"Organization","site_admin":false},"repo":{"id":17369639,"name":"personalize_module","full_name":"acquia/personalize_module","owner":{"login":"acquia","id":514789,"avatar_url":"https://avatars.githubusercontent.com/u/514789?v=3","gravatar_id":"","url":"https://api.github.com/users/acquia","html_url":"https://github.com/acquia","followers_url":"https://api.github.com/users/acquia/followers","following_url":"https://api.github.com/users/acquia/following{/other_user}","gists_url":"https://api.github.com/users/acquia/gists{/gist_id}","starred_url":"https://api.github.com/users/acquia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acquia/subscriptions","organizations_url":"https://api.github.com/users/acquia/orgs","repos_url":"https://api.github.com/users/acquia/repos","events_url":"https://api.github.com/users/acquia/events{/privacy}","received_events_url":"https://api.github.com/users/acquia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/acquia/personalize_module","description":"","fork":false,"url":"https://api.github.com/repos/acquia/personalize_module","forks_url":"https://api.github.com/repos/acquia/personalize_module/forks","keys_url":"https://api.github.com/repos/acquia/personalize_module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acquia/personalize_module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acquia/personalize_module/teams","hooks_url":"https://api.github.com/repos/acquia/personalize_module/hooks","issue_events_url":"https://api.github.com/repos/acquia/personalize_module/issues/events{/number}","events_url":"https://api.github.com/repos/acquia/personalize_module/events","assignees_url":"https://api.github.com/repos/acquia/personalize_module/assignees{/user}","branches_url":"https://api.github.com/repos/acquia/personalize_module/branches{/branch}","tags_url":"https://api.github.com/repos/acquia/personalize_module/tags","blobs_url":"https://api.github.com/repos/acquia/personalize_module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acquia/personalize_module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acquia/personalize_module/git/refs{/sha}","trees_url":"https://api.github.com/repos/acquia/personalize_module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acquia/personalize_module/statuses/{sha}","languages_url":"https://api.github.com/repos/acquia/personalize_module/languages","stargazers_url":"https://api.github.com/repos/acquia/personalize_module/stargazers","contributors_url":"https://api.github.com/repos/acquia/personalize_module/contributors","subscribers_url":"https://api.github.com/repos/acquia/personalize_module/subscribers","subscription_url":"https://api.github.com/repos/acquia/personalize_module/subscription","commits_url":"https://api.github.com/repos/acquia/personalize_module/commits{/sha}","git_commits_url":"https://api.github.com/repos/acquia/personalize_module/git/commits{/sha}","comments_url":"https://api.github.com/repos/acquia/personalize_module/comments{/number}","issue_comment_url":"https://api.github.com/repos/acquia/personalize_module/issues/comments{/number}","contents_url":"https://api.github.com/repos/acquia/personalize_module/contents/{+path}","compare_url":"https://api.github.com/repos/acquia/personalize_module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acquia/personalize_module/merges","archive_url":"https://api.github.com/repos/acquia/personalize_module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acquia/personalize_module/downloads","issues_url":"https://api.github.com/repos/acquia/personalize_module/issues{/number}","pulls_url":"https://api.github.com/repos/acquia/personalize_module/pulls{/number}","milestones_url":"https://api.github.com/repos/acquia/personalize_module/milestones{/number}","notifications_url":"https://api.github.com/repos/acquia/personalize_module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acquia/personalize_module/labels{/name}","releases_url":"https://api.github.com/repos/acquia/personalize_module/releases{/id}","created_at":"2014-03-03T15:10:12Z","updated_at":"2014-10-03T15:16:14Z","pushed_at":"2015-04-22T21:17:15Z","git_url":"git://github.com/acquia/personalize_module.git","ssh_url":"git@github.com:acquia/personalize_module.git","clone_url":"https://github.com/acquia/personalize_module.git","svn_url":"https://github.com/acquia/personalize_module","homepage":null,"size":4809,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":8,"forks":3,"open_issues":8,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/acquia/personalize_module/pulls/102"},"html":{"href":"https://github.com/acquia/personalize_module/pull/102"},"issue":{"href":"https://api.github.com/repos/acquia/personalize_module/issues/102"},"comments":{"href":"https://api.github.com/repos/acquia/personalize_module/issues/102/comments"},"review_comments":{"href":"https://api.github.com/repos/acquia/personalize_module/pulls/102/comments"},"review_comment":{"href":"https://api.github.com/repos/acquia/personalize_module/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/acquia/personalize_module/pulls/102/commits"},"statuses":{"href":"https://api.github.com/repos/acquia/personalize_module/statuses/847827bab2323c84bb307be3704deb904569b40c"}}}}