{"action":"created","comment":{"url":"https://api.github.com/repos/odoo/odoo/pulls/comments/24810931","id":24810931,"diff_hunk":"@@ -213,6 +213,16 @@ var Tour = {\n         Tour.$element = $element;\n         $element.data(\"tour\", state.id);\n         $element.data(\"tour-step\", step.id);\n+\n+        // if element is not on window (screen) then it scroll down to get popup visible\n+        if (!$element.is('body')){\n+            var element_top = $element.offset().top;\n+            var visible = ((element_top > $(window).scrollTop()) && (element_top < ($(window).scrollTop() + $(window).height())));\n+            if (!visible) {\n+                $(\"body, html\").animate({scrollTop: $element.offset().top - $(window).height() / 2 }, 800);\n+            }\n+        }","path":"addons/web/static/src/js/tour.js","position":12,"original_position":12,"commit_id":"10374fe9595e7d334ba48b61a97a755e8cbc3daf","original_commit_id":"10374fe9595e7d334ba48b61a97a755e8cbc3daf","user":{"login":"vme-odoo","id":7599826,"avatar_url":"https://avatars.githubusercontent.com/u/7599826?v=3","gravatar_id":"","url":"https://api.github.com/users/vme-odoo","html_url":"https://github.com/vme-odoo","followers_url":"https://api.github.com/users/vme-odoo/followers","following_url":"https://api.github.com/users/vme-odoo/following{/other_user}","gists_url":"https://api.github.com/users/vme-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/vme-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vme-odoo/subscriptions","organizations_url":"https://api.github.com/users/vme-odoo/orgs","repos_url":"https://api.github.com/users/vme-odoo/repos","events_url":"https://api.github.com/users/vme-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/vme-odoo/received_events","type":"User","site_admin":false},"body":"try to fix like this, http://stackoverflow.com/questions/487073/check-if-element-is-visible-after-scrolling","created_at":"2015-02-17T11:47:13Z","updated_at":"2015-02-17T11:47:13Z","html_url":"https://github.com/odoo/odoo/pull/4638#discussion_r24810931","pull_request_url":"https://api.github.com/repos/odoo/odoo/pulls/4638","_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments/24810931"},"html":{"href":"https://github.com/odoo/odoo/pull/4638#discussion_r24810931"},"pull_request":{"href":"https://api.github.com/repos/odoo/odoo/pulls/4638"}}},"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/4638","id":27181490,"html_url":"https://github.com/odoo/odoo/pull/4638","diff_url":"https://github.com/odoo/odoo/pull/4638.diff","patch_url":"https://github.com/odoo/odoo/pull/4638.patch","issue_url":"https://api.github.com/repos/odoo/odoo/issues/4638","number":4638,"state":"open","locked":false,"title":"[FIX] Web : In Tour if elemtnt is not on window then it scroll down page...","user":{"login":"vme-odoo","id":7599826,"avatar_url":"https://avatars.githubusercontent.com/u/7599826?v=3","gravatar_id":"","url":"https://api.github.com/users/vme-odoo","html_url":"https://github.com/vme-odoo","followers_url":"https://api.github.com/users/vme-odoo/followers","following_url":"https://api.github.com/users/vme-odoo/following{/other_user}","gists_url":"https://api.github.com/users/vme-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/vme-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vme-odoo/subscriptions","organizations_url":"https://api.github.com/users/vme-odoo/orgs","repos_url":"https://api.github.com/users/vme-odoo/repos","events_url":"https://api.github.com/users/vme-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/vme-odoo/received_events","type":"User","site_admin":false},"body":"... to get popup and element visible\r\nTASK: https://www.odoo.com/web#id=11194&view_type=form&model=project.task&action=333&active_id=131\r\nPAD: https://pad.odoo.com/p/r.6pZ0CSOTbl8z87uT","created_at":"2015-01-12T09:15:37Z","updated_at":"2015-02-17T11:47:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"caccbae27d1ae5c076522b315b739dfa7c8a6419","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/odoo/odoo/pulls/4638/commits","review_comments_url":"https://api.github.com/repos/odoo/odoo/pulls/4638/comments","review_comment_url":"https://api.github.com/repos/odoo/odoo/pulls/comments/{number}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/4638/comments","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/10374fe9595e7d334ba48b61a97a755e8cbc3daf","head":{"label":"odoo-dev:master-web-tourscrolldown-htr","ref":"master-web-tourscrolldown-htr","sha":"10374fe9595e7d334ba48b61a97a755e8cbc3daf","user":{"login":"odoo-dev","id":7466976,"avatar_url":"https://avatars.githubusercontent.com/u/7466976?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":19853934,"name":"odoo","full_name":"odoo-dev/odoo","owner":{"login":"odoo-dev","id":7466976,"avatar_url":"https://avatars.githubusercontent.com/u/7466976?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo-dev/odoo","description":"RD Dev Repository","fork":true,"url":"https://api.github.com/repos/odoo-dev/odoo","forks_url":"https://api.github.com/repos/odoo-dev/odoo/forks","keys_url":"https://api.github.com/repos/odoo-dev/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo-dev/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo-dev/odoo/teams","hooks_url":"https://api.github.com/repos/odoo-dev/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo-dev/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo-dev/odoo/events","assignees_url":"https://api.github.com/repos/odoo-dev/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo-dev/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo-dev/odoo/tags","blobs_url":"https://api.github.com/repos/odoo-dev/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo-dev/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo-dev/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo-dev/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo-dev/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo-dev/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo-dev/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo-dev/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo-dev/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo-dev/odoo/subscription","commits_url":"https://api.github.com/repos/odoo-dev/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo-dev/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo-dev/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo-dev/odoo/issues/comments/{number}","contents_url":"https://api.github.com/repos/odoo-dev/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo-dev/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo-dev/odoo/merges","archive_url":"https://api.github.com/repos/odoo-dev/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo-dev/odoo/downloads","issues_url":"https://api.github.com/repos/odoo-dev/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo-dev/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo-dev/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo-dev/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo-dev/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo-dev/odoo/releases{/id}","created_at":"2014-05-16T11:16:19Z","updated_at":"2015-02-13T06:49:47Z","pushed_at":"2015-02-17T11:29:24Z","git_url":"git://github.com/odoo-dev/odoo.git","ssh_url":"git@github.com:odoo-dev/odoo.git","clone_url":"https://github.com/odoo-dev/odoo.git","svn_url":"https://github.com/odoo-dev/odoo","homepage":"https://www.odoo.com","size":1054856,"stargazers_count":40,"watchers_count":40,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":7,"forks":18,"open_issues":7,"watchers":40,"default_branch":"master"}},"base":{"label":"odoo:master","ref":"master","sha":"07e734cab8dc722f1ff198998d21762e3684c7fb","user":{"login":"odoo","id":6368483,"avatar_url":"https://avatars.githubusercontent.com/u/6368483?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"repo":{"id":19745004,"name":"odoo","full_name":"odoo/odoo","owner":{"login":"odoo","id":6368483,"avatar_url":"https://avatars.githubusercontent.com/u/6368483?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo/odoo","description":"Odoo (formerly OpenERP). Open Source Apps To Grow Your Business.","fork":false,"url":"https://api.github.com/repos/odoo/odoo","forks_url":"https://api.github.com/repos/odoo/odoo/forks","keys_url":"https://api.github.com/repos/odoo/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo/odoo/teams","hooks_url":"https://api.github.com/repos/odoo/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo/odoo/events","assignees_url":"https://api.github.com/repos/odoo/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo/odoo/tags","blobs_url":"https://api.github.com/repos/odoo/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo/odoo/subscription","commits_url":"https://api.github.com/repos/odoo/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo/odoo/issues/comments/{number}","contents_url":"https://api.github.com/repos/odoo/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo/odoo/merges","archive_url":"https://api.github.com/repos/odoo/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo/odoo/downloads","issues_url":"https://api.github.com/repos/odoo/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo/odoo/releases{/id}","created_at":"2014-05-13T15:38:58Z","updated_at":"2015-02-17T11:34:36Z","pushed_at":"2015-02-17T10:30:50Z","git_url":"git://github.com/odoo/odoo.git","ssh_url":"git@github.com:odoo/odoo.git","clone_url":"https://github.com/odoo/odoo.git","svn_url":"https://github.com/odoo/odoo","homepage":"https://www.odoo.com","size":1081662,"stargazers_count":2027,"watchers_count":2027,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1633,"mirror_url":null,"open_issues_count":1851,"forks":1633,"open_issues":1851,"watchers":2027,"default_branch":"8.0"}},"_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/4638"},"html":{"href":"https://github.com/odoo/odoo/pull/4638"},"issue":{"href":"https://api.github.com/repos/odoo/odoo/issues/4638"},"comments":{"href":"https://api.github.com/repos/odoo/odoo/issues/4638/comments"},"review_comments":{"href":"https://api.github.com/repos/odoo/odoo/pulls/4638/comments"},"review_comment":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/odoo/odoo/pulls/4638/commits"},"statuses":{"href":"https://api.github.com/repos/odoo/odoo/statuses/10374fe9595e7d334ba48b61a97a755e8cbc3daf"}}}}