{"action":"created","issue":{"url":"https://api.github.com/repos/palantir/atlasdb/issues/118","labels_url":"https://api.github.com/repos/palantir/atlasdb/issues/118/labels{/name}","comments_url":"https://api.github.com/repos/palantir/atlasdb/issues/118/comments","events_url":"https://api.github.com/repos/palantir/atlasdb/issues/118/events","html_url":"https://github.com/palantir/atlasdb/pull/118","id":112668706,"number":118,"title":"allow underscores in table names","user":{"login":"rjullman","id":714325,"avatar_url":"https://avatars.githubusercontent.com/u/714325?v=3","gravatar_id":"","url":"https://api.github.com/users/rjullman","html_url":"https://github.com/rjullman","followers_url":"https://api.github.com/users/rjullman/followers","following_url":"https://api.github.com/users/rjullman/following{/other_user}","gists_url":"https://api.github.com/users/rjullman/gists{/gist_id}","starred_url":"https://api.github.com/users/rjullman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjullman/subscriptions","organizations_url":"https://api.github.com/users/rjullman/orgs","repos_url":"https://api.github.com/users/rjullman/repos","events_url":"https://api.github.com/users/rjullman/events{/privacy}","received_events_url":"https://api.github.com/users/rjullman/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/palantir/atlasdb/labels/pr:%20needs%20revision","name":"pr: needs revision","color":"f7c6c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-21T20:06:40Z","updated_at":"2015-10-21T21:17:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/palantir/atlasdb/pulls/118","html_url":"https://github.com/palantir/atlasdb/pull/118","diff_url":"https://github.com/palantir/atlasdb/pull/118.diff","patch_url":"https://github.com/palantir/atlasdb/pull/118.patch"},"body":"It is a little silly that we can't allow some kind of reasonable (non-numeric) delimiter in our table names.  Per @tjwilson90 's suggestion this changes our use of '_' to '__' (for namespacing) to allow clients to have underscores in table names.  I'm mostly interested in if this will break existing atlas code (basically everything is namespace mapped so this probably won't be a problem).  Thoughts?\r\n@carrino @tjwilson90 @clockfort "},"comment":{"url":"https://api.github.com/repos/palantir/atlasdb/issues/comments/150026960","html_url":"https://github.com/palantir/atlasdb/pull/118#issuecomment-150026960","issue_url":"https://api.github.com/repos/palantir/atlasdb/issues/118","id":150026960,"user":{"login":"rjullman","id":714325,"avatar_url":"https://avatars.githubusercontent.com/u/714325?v=3","gravatar_id":"","url":"https://api.github.com/users/rjullman","html_url":"https://github.com/rjullman","followers_url":"https://api.github.com/users/rjullman/followers","following_url":"https://api.github.com/users/rjullman/following{/other_user}","gists_url":"https://api.github.com/users/rjullman/gists{/gist_id}","starred_url":"https://api.github.com/users/rjullman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjullman/subscriptions","organizations_url":"https://api.github.com/users/rjullman/orgs","repos_url":"https://api.github.com/users/rjullman/repos","events_url":"https://api.github.com/users/rjullman/events{/privacy}","received_events_url":"https://api.github.com/users/rjullman/received_events","type":"User","site_admin":false},"created_at":"2015-10-21T21:17:53Z","updated_at":"2015-10-21T21:17:53Z","body":"After closer inspection there is definitely something wonky with the current code path.  I'll get around to figuring this out -- it will probably affect this PR."}}