{"action":"created","issue":{"url":"https://api.github.com/repos/vedmack/yadcf/issues/145","labels_url":"https://api.github.com/repos/vedmack/yadcf/issues/145/labels{/name}","comments_url":"https://api.github.com/repos/vedmack/yadcf/issues/145/comments","events_url":"https://api.github.com/repos/vedmack/yadcf/issues/145/events","html_url":"https://github.com/vedmack/yadcf/issues/145","id":54646186,"number":145,"title":"Generate more correct HTML for the filter clear button","user":{"login":"MrCsabaToth","id":744949,"avatar_url":"https://avatars.githubusercontent.com/u/744949?v=3","gravatar_id":"","url":"https://api.github.com/users/MrCsabaToth","html_url":"https://github.com/MrCsabaToth","followers_url":"https://api.github.com/users/MrCsabaToth/followers","following_url":"https://api.github.com/users/MrCsabaToth/following{/other_user}","gists_url":"https://api.github.com/users/MrCsabaToth/gists{/gist_id}","starred_url":"https://api.github.com/users/MrCsabaToth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrCsabaToth/subscriptions","organizations_url":"https://api.github.com/users/MrCsabaToth/orgs","repos_url":"https://api.github.com/users/MrCsabaToth/repos","events_url":"https://api.github.com/users/MrCsabaToth/events{/privacy}","received_events_url":"https://api.github.com/users/MrCsabaToth/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-01-17T01:47:13Z","updated_at":"2015-01-17T21:10:37Z","closed_at":"2015-01-17T21:10:37Z","body":"There's a missing space between the end of the added filter clear class (column_number + \"-reset\\\"\") and the following onclick handler. The resulting HTML:\r\n\r\n'\" yadcf-filter--reporttable-6-reset\"onclick=\"yadcf.stopPropagation(event);yadcf.textKeyUP('-reportTable', event, 'clear'); return false;\" value=\"NaN id=\">x</button>'\r\n\r\nNotice the missing space before the onclick. Maybe it doesn't cause a trouble, but it's better off having a space there IMHO."},"comment":{"url":"https://api.github.com/repos/vedmack/yadcf/issues/comments/70384539","html_url":"https://github.com/vedmack/yadcf/issues/145#issuecomment-70384539","issue_url":"https://api.github.com/repos/vedmack/yadcf/issues/145","id":70384539,"user":{"login":"vedmack","id":1679967,"avatar_url":"https://avatars.githubusercontent.com/u/1679967?v=3","gravatar_id":"","url":"https://api.github.com/users/vedmack","html_url":"https://github.com/vedmack","followers_url":"https://api.github.com/users/vedmack/followers","following_url":"https://api.github.com/users/vedmack/following{/other_user}","gists_url":"https://api.github.com/users/vedmack/gists{/gist_id}","starred_url":"https://api.github.com/users/vedmack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vedmack/subscriptions","organizations_url":"https://api.github.com/users/vedmack/orgs","repos_url":"https://api.github.com/users/vedmack/repos","events_url":"https://api.github.com/users/vedmack/events{/privacy}","received_events_url":"https://api.github.com/users/vedmack/received_events","type":"User","site_admin":false},"created_at":"2015-01-17T21:10:37Z","updated_at":"2015-01-17T21:10:37Z","body":"Fixed in https://github.com/vedmack/yadcf/pull/147 :+1: "}}