{"action":"created","issue":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3089","labels_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3089/labels{/name}","comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3089/comments","events_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3089/events","html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3089","id":92682495,"number":3089,"title":"[AdminPoolLoader] Added missing \"array\" type hint in constructor","user":{"login":"phansys","id":1231441,"avatar_url":"https://avatars.githubusercontent.com/u/1231441?v=3","gravatar_id":"","url":"https://api.github.com/users/phansys","html_url":"https://github.com/phansys","followers_url":"https://api.github.com/users/phansys/followers","following_url":"https://api.github.com/users/phansys/following{/other_user}","gists_url":"https://api.github.com/users/phansys/gists{/gist_id}","starred_url":"https://api.github.com/users/phansys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phansys/subscriptions","organizations_url":"https://api.github.com/users/phansys/orgs","repos_url":"https://api.github.com/users/phansys/repos","events_url":"https://api.github.com/users/phansys/events{/privacy}","received_events_url":"https://api.github.com/users/phansys/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-07-02T16:45:53Z","updated_at":"2015-07-03T07:49:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3089","html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3089","diff_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3089.diff","patch_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3089.patch"},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets |\r\n| License       | MIT\r\n| Doc PR        |\r\n\r\nAdded missing ```array``` type hint for 2nd argument in ```AdminPoolLoader::__construct()```."},"comment":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/comments/118267014","html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3089#issuecomment-118267014","issue_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3089","id":118267014,"user":{"login":"Soullivaneuh","id":1698357,"avatar_url":"https://avatars.githubusercontent.com/u/1698357?v=3","gravatar_id":"","url":"https://api.github.com/users/Soullivaneuh","html_url":"https://github.com/Soullivaneuh","followers_url":"https://api.github.com/users/Soullivaneuh/followers","following_url":"https://api.github.com/users/Soullivaneuh/following{/other_user}","gists_url":"https://api.github.com/users/Soullivaneuh/gists{/gist_id}","starred_url":"https://api.github.com/users/Soullivaneuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soullivaneuh/subscriptions","organizations_url":"https://api.github.com/users/Soullivaneuh/orgs","repos_url":"https://api.github.com/users/Soullivaneuh/repos","events_url":"https://api.github.com/users/Soullivaneuh/events{/privacy}","received_events_url":"https://api.github.com/users/Soullivaneuh/received_events","type":"User","site_admin":false},"created_at":"2015-07-03T07:49:54Z","updated_at":"2015-07-03T07:49:54Z","body":"As I said:\r\n\r\n> Could be BC with signature change if developers extends this class\r\n\r\nFor example, with the `AdminPoolLoader` class modified by your PR:\r\n\r\n```php\r\nclass AdminPoolLoader extends FileLoader\r\n{\r\n    public function __construct(Pool $pool, array $adminServiceIds, ContainerInterface $container)\r\n    {\r\n        // ...\r\n    }\r\n```\r\n\r\nIf this class is extended like this:\r\n\r\n```php\r\nclass FooBarLoader extends AdminPoolLoader\r\n{\r\n    public function __construct(Pool $pool, $adminServiceIds, ContainerInterface $container)\r\n    {\r\n        // ...\r\n    }\r\n```\r\n\r\nThis will throw a php strict error AFAIK.\r\n\r\nBut I agree with @rande if this class is not a lot extended by users, could be OK with an explicit upgrade note although I think there is no \"small\" BC break. :-)"}}