{"action":"opened","number":5347,"pull_request":{"url":"https://api.github.com/repos/atom/atom/pulls/5347","id":28434521,"html_url":"https://github.com/atom/atom/pull/5347","diff_url":"https://github.com/atom/atom/pull/5347.diff","patch_url":"https://github.com/atom/atom/pull/5347.patch","issue_url":"https://api.github.com/repos/atom/atom/issues/5347","number":5347,"state":"open","locked":false,"title":":bug: Fix ident guides missing on whitespace only lines with invisible characters","user":{"login":"driskell","id":939815,"avatar_url":"https://avatars.githubusercontent.com/u/939815?v=3","gravatar_id":"","url":"https://api.github.com/users/driskell","html_url":"https://github.com/driskell","followers_url":"https://api.github.com/users/driskell/followers","following_url":"https://api.github.com/users/driskell/following{/other_user}","gists_url":"https://api.github.com/users/driskell/gists{/gist_id}","starred_url":"https://api.github.com/users/driskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/driskell/subscriptions","organizations_url":"https://api.github.com/users/driskell/orgs","repos_url":"https://api.github.com/users/driskell/repos","events_url":"https://api.github.com/users/driskell/events{/privacy}","received_events_url":"https://api.github.com/users/driskell/received_events","type":"User","site_admin":false},"body":"Using 0.175.0 on Mac OS X 10.10.2 (though likely affecting all platforms), the indent guides are missing on whitespace only lines. So when you start a new line which auto-indents the indent guides are visibly missing. Snapshot below:\r\n\r\n![screen shot 2015-02-01 at 17 59 23](https://cloud.githubusercontent.com/assets/939815/5993100/77e73eea-aa3c-11e4-8812-82568431c5ab.png)\r\n\r\nThis is down the fact that the \"isWhitespaceOnly\" detection only works if invisible characters is disabled. With invisible characters enabled, it sees the invisible characters and thinks the line does not contain only whitespace, thus disabling the guides.\r\n\r\nThis patch also means the whitespace only flag is stored, and there's no need to run any regex again when re-rendering the HTML for the line.\r\n\r\nSnapshot after applying the patch:\r\n\r\n![screen shot 2015-02-01 at 18 01 01](https://cloud.githubusercontent.com/assets/939815/5993127/7490fad2-aa3d-11e4-909d-30c187ba6f9e.png)\r\n","created_at":"2015-02-01T18:09:32Z","updated_at":"2015-02-01T18:09:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/atom/atom/pulls/5347/commits","review_comments_url":"https://api.github.com/repos/atom/atom/pulls/5347/comments","review_comment_url":"https://api.github.com/repos/atom/atom/pulls/comments/{number}","comments_url":"https://api.github.com/repos/atom/atom/issues/5347/comments","statuses_url":"https://api.github.com/repos/atom/atom/statuses/1d4f16e9777854a74b180d69b43ac90077bff992","head":{"label":"driskell:bugs/ident_guide_whitespace_only","ref":"bugs/ident_guide_whitespace_only","sha":"1d4f16e9777854a74b180d69b43ac90077bff992","user":{"login":"driskell","id":939815,"avatar_url":"https://avatars.githubusercontent.com/u/939815?v=3","gravatar_id":"","url":"https://api.github.com/users/driskell","html_url":"https://github.com/driskell","followers_url":"https://api.github.com/users/driskell/followers","following_url":"https://api.github.com/users/driskell/following{/other_user}","gists_url":"https://api.github.com/users/driskell/gists{/gist_id}","starred_url":"https://api.github.com/users/driskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/driskell/subscriptions","organizations_url":"https://api.github.com/users/driskell/orgs","repos_url":"https://api.github.com/users/driskell/repos","events_url":"https://api.github.com/users/driskell/events{/privacy}","received_events_url":"https://api.github.com/users/driskell/received_events","type":"User","site_admin":false},"repo":{"id":29882925,"name":"atom","full_name":"driskell/atom","owner":{"login":"driskell","id":939815,"avatar_url":"https://avatars.githubusercontent.com/u/939815?v=3","gravatar_id":"","url":"https://api.github.com/users/driskell","html_url":"https://github.com/driskell","followers_url":"https://api.github.com/users/driskell/followers","following_url":"https://api.github.com/users/driskell/following{/other_user}","gists_url":"https://api.github.com/users/driskell/gists{/gist_id}","starred_url":"https://api.github.com/users/driskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/driskell/subscriptions","organizations_url":"https://api.github.com/users/driskell/orgs","repos_url":"https://api.github.com/users/driskell/repos","events_url":"https://api.github.com/users/driskell/events{/privacy}","received_events_url":"https://api.github.com/users/driskell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/driskell/atom","description":"The hackable editor","fork":true,"url":"https://api.github.com/repos/driskell/atom","forks_url":"https://api.github.com/repos/driskell/atom/forks","keys_url":"https://api.github.com/repos/driskell/atom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/driskell/atom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/driskell/atom/teams","hooks_url":"https://api.github.com/repos/driskell/atom/hooks","issue_events_url":"https://api.github.com/repos/driskell/atom/issues/events{/number}","events_url":"https://api.github.com/repos/driskell/atom/events","assignees_url":"https://api.github.com/repos/driskell/atom/assignees{/user}","branches_url":"https://api.github.com/repos/driskell/atom/branches{/branch}","tags_url":"https://api.github.com/repos/driskell/atom/tags","blobs_url":"https://api.github.com/repos/driskell/atom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/driskell/atom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/driskell/atom/git/refs{/sha}","trees_url":"https://api.github.com/repos/driskell/atom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/driskell/atom/statuses/{sha}","languages_url":"https://api.github.com/repos/driskell/atom/languages","stargazers_url":"https://api.github.com/repos/driskell/atom/stargazers","contributors_url":"https://api.github.com/repos/driskell/atom/contributors","subscribers_url":"https://api.github.com/repos/driskell/atom/subscribers","subscription_url":"https://api.github.com/repos/driskell/atom/subscription","commits_url":"https://api.github.com/repos/driskell/atom/commits{/sha}","git_commits_url":"https://api.github.com/repos/driskell/atom/git/commits{/sha}","comments_url":"https://api.github.com/repos/driskell/atom/comments{/number}","issue_comment_url":"https://api.github.com/repos/driskell/atom/issues/comments/{number}","contents_url":"https://api.github.com/repos/driskell/atom/contents/{+path}","compare_url":"https://api.github.com/repos/driskell/atom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/driskell/atom/merges","archive_url":"https://api.github.com/repos/driskell/atom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/driskell/atom/downloads","issues_url":"https://api.github.com/repos/driskell/atom/issues{/number}","pulls_url":"https://api.github.com/repos/driskell/atom/pulls{/number}","milestones_url":"https://api.github.com/repos/driskell/atom/milestones{/number}","notifications_url":"https://api.github.com/repos/driskell/atom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/driskell/atom/labels{/name}","releases_url":"https://api.github.com/repos/driskell/atom/releases{/id}","created_at":"2015-01-26T21:38:55Z","updated_at":"2015-02-01T17:47:07Z","pushed_at":"2015-02-01T18:07:37Z","git_url":"git://github.com/driskell/atom.git","ssh_url":"git@github.com:driskell/atom.git","clone_url":"https://github.com/driskell/atom.git","svn_url":"https://github.com/driskell/atom","homepage":"https://atom.io/","size":262055,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"feature/tabulation_control"}},"base":{"label":"atom:master","ref":"master","sha":"7add4af5854402331bba3ec59ff4dd25a994f97c","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":3228505,"name":"atom","full_name":"atom/atom","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/atom","description":"The hackable editor","fork":false,"url":"https://api.github.com/repos/atom/atom","forks_url":"https://api.github.com/repos/atom/atom/forks","keys_url":"https://api.github.com/repos/atom/atom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/atom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/atom/teams","hooks_url":"https://api.github.com/repos/atom/atom/hooks","issue_events_url":"https://api.github.com/repos/atom/atom/issues/events{/number}","events_url":"https://api.github.com/repos/atom/atom/events","assignees_url":"https://api.github.com/repos/atom/atom/assignees{/user}","branches_url":"https://api.github.com/repos/atom/atom/branches{/branch}","tags_url":"https://api.github.com/repos/atom/atom/tags","blobs_url":"https://api.github.com/repos/atom/atom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/atom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/atom/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/atom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/atom/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/atom/languages","stargazers_url":"https://api.github.com/repos/atom/atom/stargazers","contributors_url":"https://api.github.com/repos/atom/atom/contributors","subscribers_url":"https://api.github.com/repos/atom/atom/subscribers","subscription_url":"https://api.github.com/repos/atom/atom/subscription","commits_url":"https://api.github.com/repos/atom/atom/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/atom/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/atom/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/atom/issues/comments/{number}","contents_url":"https://api.github.com/repos/atom/atom/contents/{+path}","compare_url":"https://api.github.com/repos/atom/atom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/atom/merges","archive_url":"https://api.github.com/repos/atom/atom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/atom/downloads","issues_url":"https://api.github.com/repos/atom/atom/issues{/number}","pulls_url":"https://api.github.com/repos/atom/atom/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/atom/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/atom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/atom/labels{/name}","releases_url":"https://api.github.com/repos/atom/atom/releases{/id}","created_at":"2012-01-20T18:18:21Z","updated_at":"2015-02-01T17:35:43Z","pushed_at":"2015-02-01T18:07:54Z","git_url":"git://github.com/atom/atom.git","ssh_url":"git@github.com:atom/atom.git","clone_url":"https://github.com/atom/atom.git","svn_url":"https://github.com/atom/atom","homepage":"https://atom.io/","size":336480,"stargazers_count":11981,"watchers_count":11981,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2010,"mirror_url":null,"open_issues_count":818,"forks":2010,"open_issues":818,"watchers":11981,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/atom/pulls/5347"},"html":{"href":"https://github.com/atom/atom/pull/5347"},"issue":{"href":"https://api.github.com/repos/atom/atom/issues/5347"},"comments":{"href":"https://api.github.com/repos/atom/atom/issues/5347/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/atom/pulls/5347/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/atom/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/atom/atom/pulls/5347/commits"},"statuses":{"href":"https://api.github.com/repos/atom/atom/statuses/1d4f16e9777854a74b180d69b43ac90077bff992"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":10,"deletions":15,"changed_files":2}}