{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/comments/44293946","id":44293946,"diff_hunk":"@@ -76,7 +81,20 @@ public ModuleDeploymentId deploy(ModuleDeploymentRequest request) {\n \t\tfor (Map.Entry<String, String> entry : request.getDefinition().getParameters().entrySet()) {\n \t\t\tenvironmentVariables.add(new EnvironmentVariable(entry.getKey(), entry.getValue()));\n \t\t}\n-\n+\t\t// Module launcher properties from Deployment properties","path":"spring-cloud-dataflow-module-deployers/spring-cloud-dataflow-module-deployer-lattice/src/main/java/org/springframework/cloud/dataflow/module/deployer/lattice/TaskModuleDeployer.java","position":26,"original_position":26,"commit_id":"d2a0a35246b2efc2961f11cdd3dc2b86b4f2c9f0","original_commit_id":"d2a0a35246b2efc2961f11cdd3dc2b86b4f2c9f0","user":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars.githubusercontent.com/u/151690?v=3","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"body":"Does anyone disagree on *not* to support passing module resolver/launcher properties via deployment properties?\r\nIt might be ok just to have the support to set the module resolver/launcher properties for the spring-cloud-dataflow-adming at the startup level. ","created_at":"2015-11-09T16:19:23Z","updated_at":"2015-11-09T16:19:23Z","html_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/135#discussion_r44293946","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/135","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/comments/44293946"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/135#discussion_r44293946"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/135"}}},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/135","id":49696547,"html_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/135","diff_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/135.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/135.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/135","number":135,"state":"open","locked":false,"title":"XD-3616 Pass module resolver props via dataflow admin","user":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars.githubusercontent.com/u/151690?v=3","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"body":" - This PR adds the ability to pass `module-resolver` properties from `spring-cloud-dataflow-admin`.\r\nThe module resolver properties would have a prefix `moduleResolver.` in the deployment properties when provided during `deploy` operation.\r\nFor instance, a stream deployment command could override the module resolver properties like this:\r\n  `stream deploy <stream> --properties \"module.time.moduleResolver.remoteRepositories=repo1,module.time.moduleResolver.localRepository=/tmp/m2,module.log.moduleResolver.offline=true\"`\r\n\r\nSince the `moduleResolver` configuration is setup at the dataflow-admin `startup` itself, we can not rely to simple property override for the `moduleResolver` properties.\r\n - There were few road blocks while addressing this in few different approaches (especially in local deployer):\r\n   - Spawning separate process for `ModuleLauncherApplication` from `LocalModuleDeployer` needed to have its own classpath and process management (for deploying/un-deploy/destroy)\r\n   - The oracle-tools runtime library seemed to be a better option; but the classpath management within the dataflow-admin -> module-launcher -> oracle-tools gets complicated.\r\n\r\nThe current approach explicitly sets the module resolver properties via `ModuleResolver` implementation.","created_at":"2015-11-04T14:45:41Z","updated_at":"2015-11-09T16:19:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b09091f9f9c5b418167c234a807566e4506def1","assignee":{"login":"ericbottard","id":313494,"avatar_url":"https://avatars.githubusercontent.com/u/313494?v=3","gravatar_id":"","url":"https://api.github.com/users/ericbottard","html_url":"https://github.com/ericbottard","followers_url":"https://api.github.com/users/ericbottard/followers","following_url":"https://api.github.com/users/ericbottard/following{/other_user}","gists_url":"https://api.github.com/users/ericbottard/gists{/gist_id}","starred_url":"https://api.github.com/users/ericbottard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericbottard/subscriptions","organizations_url":"https://api.github.com/users/ericbottard/orgs","repos_url":"https://api.github.com/users/ericbottard/repos","events_url":"https://api.github.com/users/ericbottard/events{/privacy}","received_events_url":"https://api.github.com/users/ericbottard/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/135/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/135/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/135/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/statuses/d2a0a35246b2efc2961f11cdd3dc2b86b4f2c9f0","head":{"label":"ilayaperumalg:pass-module-resolver-props","ref":"pass-module-resolver-props","sha":"d2a0a35246b2efc2961f11cdd3dc2b86b4f2c9f0","user":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars.githubusercontent.com/u/151690?v=3","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"repo":{"id":40140476,"name":"spring-cloud-dataflow","full_name":"ilayaperumalg/spring-cloud-dataflow","owner":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars.githubusercontent.com/u/151690?v=3","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ilayaperumalg/spring-cloud-dataflow","description":"","fork":true,"url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow","forks_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/forks","keys_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/teams","hooks_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/hooks","issue_events_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/issues/events{/number}","events_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/events","assignees_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/assignees{/user}","branches_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/branches{/branch}","tags_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/tags","blobs_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/statuses/{sha}","languages_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/languages","stargazers_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/stargazers","contributors_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/contributors","subscribers_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/subscribers","subscription_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/subscription","commits_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/contents/{+path}","compare_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/merges","archive_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/downloads","issues_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/issues{/number}","pulls_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/pulls{/number}","milestones_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/milestones{/number}","notifications_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/labels{/name}","releases_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-dataflow/releases{/id}","created_at":"2015-08-03T18:13:31Z","updated_at":"2015-09-08T19:40:58Z","pushed_at":"2015-11-09T07:38:33Z","git_url":"git://github.com/ilayaperumalg/spring-cloud-dataflow.git","ssh_url":"git@github.com:ilayaperumalg/spring-cloud-dataflow.git","clone_url":"https://github.com/ilayaperumalg/spring-cloud-dataflow.git","svn_url":"https://github.com/ilayaperumalg/spring-cloud-dataflow","homepage":null,"size":1192,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"16c9db1a2138ca597c8a8dbd13966e3cece26c98","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":39469487,"name":"spring-cloud-dataflow","full_name":"spring-cloud/spring-cloud-dataflow","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-dataflow","description":"","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/releases{/id}","created_at":"2015-07-21T20:56:11Z","updated_at":"2015-11-07T19:40:17Z","pushed_at":"2015-11-09T07:38:33Z","git_url":"git://github.com/spring-cloud/spring-cloud-dataflow.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-dataflow.git","clone_url":"https://github.com/spring-cloud/spring-cloud-dataflow.git","svn_url":"https://github.com/spring-cloud/spring-cloud-dataflow","homepage":null,"size":2846,"stargazers_count":24,"watchers_count":24,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":29,"mirror_url":null,"open_issues_count":14,"forks":29,"open_issues":14,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/135"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/135"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/135"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/135/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/135/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/135/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/statuses/d2a0a35246b2efc2961f11cdd3dc2b86b4f2c9f0"}}}}