{"action":"created","comment":{"url":"https://api.github.com/repos/PaycoinFoundation/paycoin/pulls/comments/47526376","id":47526376,"diff_hunk":"@@ -62,7 +62,7 @@ BOOST_FIXTURE_TEST_CASE(rpc_addmultisig, TestNetFixture)\n     string short1(address1Hex, address1Hex+sizeof(address1Hex)-2); // last byte missing","path":"src/test/rpc_tests.cpp","position":13,"original_position":13,"commit_id":"338b1c1430c6c36976247abcb007b1fde5f91436","original_commit_id":"338b1c1430c6c36976247abcb007b1fde5f91436","user":{"login":"IngCr3at1on","id":922158,"avatar_url":"https://avatars.githubusercontent.com/u/922158?v=3","gravatar_id":"","url":"https://api.github.com/users/IngCr3at1on","html_url":"https://github.com/IngCr3at1on","followers_url":"https://api.github.com/users/IngCr3at1on/followers","following_url":"https://api.github.com/users/IngCr3at1on/following{/other_user}","gists_url":"https://api.github.com/users/IngCr3at1on/gists{/gist_id}","starred_url":"https://api.github.com/users/IngCr3at1on/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IngCr3at1on/subscriptions","organizations_url":"https://api.github.com/users/IngCr3at1on/orgs","repos_url":"https://api.github.com/users/IngCr3at1on/repos","events_url":"https://api.github.com/users/IngCr3at1on/events{/privacy}","received_events_url":"https://api.github.com/users/IngCr3at1on/received_events","type":"User","site_admin":false},"body":"Interesting that we remove 2 here but only add 1 below...\r\n\r\nMain problem with these tests, they check if something is thrown but have no valid way to check what (this is an issue with a lot of the tests actually).","created_at":"2015-12-14T17:16:42Z","updated_at":"2015-12-14T17:16:42Z","html_url":"https://github.com/PaycoinFoundation/paycoin/pull/412#discussion_r47526376","pull_request_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/pulls/412","_links":{"self":{"href":"https://api.github.com/repos/PaycoinFoundation/paycoin/pulls/comments/47526376"},"html":{"href":"https://github.com/PaycoinFoundation/paycoin/pull/412#discussion_r47526376"},"pull_request":{"href":"https://api.github.com/repos/PaycoinFoundation/paycoin/pulls/412"}}},"pull_request":{"url":"https://api.github.com/repos/PaycoinFoundation/paycoin/pulls/412","id":53475956,"html_url":"https://github.com/PaycoinFoundation/paycoin/pull/412","diff_url":"https://github.com/PaycoinFoundation/paycoin/pull/412.diff","patch_url":"https://github.com/PaycoinFoundation/paycoin/pull/412.patch","issue_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/issues/412","number":412,"state":"open","locked":false,"title":"Small fix to rpc_tests","user":{"login":"mitchellcash","id":8009243,"avatar_url":"https://avatars.githubusercontent.com/u/8009243?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchellcash","html_url":"https://github.com/mitchellcash","followers_url":"https://api.github.com/users/mitchellcash/followers","following_url":"https://api.github.com/users/mitchellcash/following{/other_user}","gists_url":"https://api.github.com/users/mitchellcash/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchellcash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchellcash/subscriptions","organizations_url":"https://api.github.com/users/mitchellcash/orgs","repos_url":"https://api.github.com/users/mitchellcash/repos","events_url":"https://api.github.com/users/mitchellcash/events{/privacy}","received_events_url":"https://api.github.com/users/mitchellcash/received_events","type":"User","site_admin":false},"body":"sizeof(const char*) == 4 or 8 (on \"sane\" processor architectures) :-), sizeof(const char[]) is what you want.\r\n\r\nAs written the first substring was \"04\" and the second was \"88c2\" (on 32 bits architectures)\r\n\r\nAnd I have changed the +2 in +1 so that the comment is right.","created_at":"2015-12-12T13:09:06Z","updated_at":"2015-12-14T17:16:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a86fc2750506a550e9e7ca56c36b195d843f450","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/pulls/412/commits","review_comments_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/pulls/412/comments","review_comment_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/issues/412/comments","statuses_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/statuses/338b1c1430c6c36976247abcb007b1fde5f91436","head":{"label":"mitchellcash:rpc_tests","ref":"rpc_tests","sha":"338b1c1430c6c36976247abcb007b1fde5f91436","user":{"login":"mitchellcash","id":8009243,"avatar_url":"https://avatars.githubusercontent.com/u/8009243?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchellcash","html_url":"https://github.com/mitchellcash","followers_url":"https://api.github.com/users/mitchellcash/followers","following_url":"https://api.github.com/users/mitchellcash/following{/other_user}","gists_url":"https://api.github.com/users/mitchellcash/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchellcash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchellcash/subscriptions","organizations_url":"https://api.github.com/users/mitchellcash/orgs","repos_url":"https://api.github.com/users/mitchellcash/repos","events_url":"https://api.github.com/users/mitchellcash/events{/privacy}","received_events_url":"https://api.github.com/users/mitchellcash/received_events","type":"User","site_admin":false},"repo":{"id":32920530,"name":"paycoin","full_name":"mitchellcash/paycoin","owner":{"login":"mitchellcash","id":8009243,"avatar_url":"https://avatars.githubusercontent.com/u/8009243?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchellcash","html_url":"https://github.com/mitchellcash","followers_url":"https://api.github.com/users/mitchellcash/followers","following_url":"https://api.github.com/users/mitchellcash/following{/other_user}","gists_url":"https://api.github.com/users/mitchellcash/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchellcash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchellcash/subscriptions","organizations_url":"https://api.github.com/users/mitchellcash/orgs","repos_url":"https://api.github.com/users/mitchellcash/repos","events_url":"https://api.github.com/users/mitchellcash/events{/privacy}","received_events_url":"https://api.github.com/users/mitchellcash/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mitchellcash/paycoin","description":"Paycoin","fork":true,"url":"https://api.github.com/repos/mitchellcash/paycoin","forks_url":"https://api.github.com/repos/mitchellcash/paycoin/forks","keys_url":"https://api.github.com/repos/mitchellcash/paycoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitchellcash/paycoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitchellcash/paycoin/teams","hooks_url":"https://api.github.com/repos/mitchellcash/paycoin/hooks","issue_events_url":"https://api.github.com/repos/mitchellcash/paycoin/issues/events{/number}","events_url":"https://api.github.com/repos/mitchellcash/paycoin/events","assignees_url":"https://api.github.com/repos/mitchellcash/paycoin/assignees{/user}","branches_url":"https://api.github.com/repos/mitchellcash/paycoin/branches{/branch}","tags_url":"https://api.github.com/repos/mitchellcash/paycoin/tags","blobs_url":"https://api.github.com/repos/mitchellcash/paycoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitchellcash/paycoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitchellcash/paycoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitchellcash/paycoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitchellcash/paycoin/statuses/{sha}","languages_url":"https://api.github.com/repos/mitchellcash/paycoin/languages","stargazers_url":"https://api.github.com/repos/mitchellcash/paycoin/stargazers","contributors_url":"https://api.github.com/repos/mitchellcash/paycoin/contributors","subscribers_url":"https://api.github.com/repos/mitchellcash/paycoin/subscribers","subscription_url":"https://api.github.com/repos/mitchellcash/paycoin/subscription","commits_url":"https://api.github.com/repos/mitchellcash/paycoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitchellcash/paycoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitchellcash/paycoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitchellcash/paycoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitchellcash/paycoin/contents/{+path}","compare_url":"https://api.github.com/repos/mitchellcash/paycoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitchellcash/paycoin/merges","archive_url":"https://api.github.com/repos/mitchellcash/paycoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitchellcash/paycoin/downloads","issues_url":"https://api.github.com/repos/mitchellcash/paycoin/issues{/number}","pulls_url":"https://api.github.com/repos/mitchellcash/paycoin/pulls{/number}","milestones_url":"https://api.github.com/repos/mitchellcash/paycoin/milestones{/number}","notifications_url":"https://api.github.com/repos/mitchellcash/paycoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitchellcash/paycoin/labels{/name}","releases_url":"https://api.github.com/repos/mitchellcash/paycoin/releases{/id}","created_at":"2015-03-26T10:17:02Z","updated_at":"2015-04-16T11:37:37Z","pushed_at":"2015-12-14T11:11:59Z","git_url":"git://github.com/mitchellcash/paycoin.git","ssh_url":"git@github.com:mitchellcash/paycoin.git","clone_url":"https://github.com/mitchellcash/paycoin.git","svn_url":"https://github.com/mitchellcash/paycoin","homepage":"https://paycoin.com","size":34492,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"PaycoinFoundation:master","ref":"master","sha":"65b923bcfa681e5a560cad9a04f6506555ed1f58","user":{"login":"PaycoinFoundation","id":10690863,"avatar_url":"https://avatars.githubusercontent.com/u/10690863?v=3","gravatar_id":"","url":"https://api.github.com/users/PaycoinFoundation","html_url":"https://github.com/PaycoinFoundation","followers_url":"https://api.github.com/users/PaycoinFoundation/followers","following_url":"https://api.github.com/users/PaycoinFoundation/following{/other_user}","gists_url":"https://api.github.com/users/PaycoinFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/PaycoinFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaycoinFoundation/subscriptions","organizations_url":"https://api.github.com/users/PaycoinFoundation/orgs","repos_url":"https://api.github.com/users/PaycoinFoundation/repos","events_url":"https://api.github.com/users/PaycoinFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/PaycoinFoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":27197763,"name":"paycoin","full_name":"PaycoinFoundation/paycoin","owner":{"login":"PaycoinFoundation","id":10690863,"avatar_url":"https://avatars.githubusercontent.com/u/10690863?v=3","gravatar_id":"","url":"https://api.github.com/users/PaycoinFoundation","html_url":"https://github.com/PaycoinFoundation","followers_url":"https://api.github.com/users/PaycoinFoundation/followers","following_url":"https://api.github.com/users/PaycoinFoundation/following{/other_user}","gists_url":"https://api.github.com/users/PaycoinFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/PaycoinFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaycoinFoundation/subscriptions","organizations_url":"https://api.github.com/users/PaycoinFoundation/orgs","repos_url":"https://api.github.com/users/PaycoinFoundation/repos","events_url":"https://api.github.com/users/PaycoinFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/PaycoinFoundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PaycoinFoundation/paycoin","description":"Paycoin","fork":false,"url":"https://api.github.com/repos/PaycoinFoundation/paycoin","forks_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/forks","keys_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/teams","hooks_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/hooks","issue_events_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/issues/events{/number}","events_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/events","assignees_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/assignees{/user}","branches_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/branches{/branch}","tags_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/tags","blobs_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/statuses/{sha}","languages_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/languages","stargazers_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/stargazers","contributors_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/contributors","subscribers_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/subscribers","subscription_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/subscription","commits_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/contents/{+path}","compare_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/merges","archive_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/downloads","issues_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/issues{/number}","pulls_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/pulls{/number}","milestones_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/milestones{/number}","notifications_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/labels{/name}","releases_url":"https://api.github.com/repos/PaycoinFoundation/paycoin/releases{/id}","created_at":"2014-11-26T21:51:18Z","updated_at":"2015-11-24T06:12:59Z","pushed_at":"2015-12-14T11:15:29Z","git_url":"git://github.com/PaycoinFoundation/paycoin.git","ssh_url":"git@github.com:PaycoinFoundation/paycoin.git","clone_url":"https://github.com/PaycoinFoundation/paycoin.git","svn_url":"https://github.com/PaycoinFoundation/paycoin","homepage":"https://paycoin.com","size":35752,"stargazers_count":33,"watchers_count":33,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":74,"mirror_url":null,"open_issues_count":82,"forks":74,"open_issues":82,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PaycoinFoundation/paycoin/pulls/412"},"html":{"href":"https://github.com/PaycoinFoundation/paycoin/pull/412"},"issue":{"href":"https://api.github.com/repos/PaycoinFoundation/paycoin/issues/412"},"comments":{"href":"https://api.github.com/repos/PaycoinFoundation/paycoin/issues/412/comments"},"review_comments":{"href":"https://api.github.com/repos/PaycoinFoundation/paycoin/pulls/412/comments"},"review_comment":{"href":"https://api.github.com/repos/PaycoinFoundation/paycoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PaycoinFoundation/paycoin/pulls/412/commits"},"statuses":{"href":"https://api.github.com/repos/PaycoinFoundation/paycoin/statuses/338b1c1430c6c36976247abcb007b1fde5f91436"}}}}