{"action":"created","comment":{"url":"https://api.github.com/repos/wikimedia/jquery.uls/pulls/comments/25411989","id":25411989,"diff_hunk":"@@ -354,12 +354,26 @@\n \t\t * @return string\n \t\t */\n \t\tgetMenuWidth: function () {\n-\t\t\tvar languagesCount;\n+\t\t\tvar language, languagesCount = 0;\n \n \t\t\tif ( this.options.menuWidth ) {\n \t\t\t\treturn this.options.menuWidth;\n \t\t\t}\n \n+\t\t\t// IE8 does not support Object.keys\n+\t\t\tif ( Object.keys ) {\n+\t\t\t\tlanguagesCount = Object.keys( this.options.languages ).length;\n+\t\t\t} else {\n+\t\t\t\tfor ( language in this.options.languages ) {\n+\t\t\t\t\tif ( Object.prototype.hasOwnProperty.call(\n+\t\t\t\t\t\tthis.options.languages,\n+\t\t\t\t\t\tlanguage\n+\t\t\t\t\t) ) {\n+\t\t\t\t\t\tlanguagesCount++;\n+\t\t\t\t\t}\n+\t\t\t\t}\n+\t\t\t}\n+\n \t\t\tlanguagesCount = Object.keys( this.options.languages ).length;","path":"src/jquery.uls.core.js","position":25,"original_position":25,"commit_id":"eb0cdd3a34b11c5f5976a55cfba067defc1e2b27","original_commit_id":"eb0cdd3a34b11c5f5976a55cfba067defc1e2b27","user":{"login":"amire80","id":346271,"avatar_url":"https://avatars.githubusercontent.com/u/346271?v=3","gravatar_id":"","url":"https://api.github.com/users/amire80","html_url":"https://github.com/amire80","followers_url":"https://api.github.com/users/amire80/followers","following_url":"https://api.github.com/users/amire80/following{/other_user}","gists_url":"https://api.github.com/users/amire80/gists{/gist_id}","starred_url":"https://api.github.com/users/amire80/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amire80/subscriptions","organizations_url":"https://api.github.com/users/amire80/orgs","repos_url":"https://api.github.com/users/amire80/repos","events_url":"https://api.github.com/users/amire80/events{/privacy}","received_events_url":"https://api.github.com/users/amire80/received_events","type":"User","site_admin":false},"body":"Resubmitted cleanly at https://github.com/wikimedia/jquery.uls/pull/180 .","created_at":"2015-02-26T08:47:36Z","updated_at":"2015-02-26T08:47:36Z","html_url":"https://github.com/wikimedia/jquery.uls/pull/178#discussion_r25411989","pull_request_url":"https://api.github.com/repos/wikimedia/jquery.uls/pulls/178","_links":{"self":{"href":"https://api.github.com/repos/wikimedia/jquery.uls/pulls/comments/25411989"},"html":{"href":"https://github.com/wikimedia/jquery.uls/pull/178#discussion_r25411989"},"pull_request":{"href":"https://api.github.com/repos/wikimedia/jquery.uls/pulls/178"}}},"pull_request":{"url":"https://api.github.com/repos/wikimedia/jquery.uls/pulls/178","id":28131467,"html_url":"https://github.com/wikimedia/jquery.uls/pull/178","diff_url":"https://github.com/wikimedia/jquery.uls/pull/178.diff","patch_url":"https://github.com/wikimedia/jquery.uls/pull/178.patch","issue_url":"https://api.github.com/repos/wikimedia/jquery.uls/issues/178","number":178,"state":"open","locked":false,"title":"Restore support for IE8","user":{"login":"amire80","id":346271,"avatar_url":"https://avatars.githubusercontent.com/u/346271?v=3","gravatar_id":"","url":"https://api.github.com/users/amire80","html_url":"https://github.com/amire80","followers_url":"https://api.github.com/users/amire80/followers","following_url":"https://api.github.com/users/amire80/following{/other_user}","gists_url":"https://api.github.com/users/amire80/gists{/gist_id}","starred_url":"https://api.github.com/users/amire80/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amire80/subscriptions","organizations_url":"https://api.github.com/users/amire80/orgs","repos_url":"https://api.github.com/users/amire80/repos","events_url":"https://api.github.com/users/amire80/events{/privacy}","received_events_url":"https://api.github.com/users/amire80/received_events","type":"User","site_admin":false},"body":"IE8 does not support Object.keys.\r\n\r\nhttps://phabricator.wikimedia.org/T86516\r\n\r\nCopying the patch from Gerrit:\r\nhttps://gerrit.wikimedia.org/r/#/c/184316/","created_at":"2015-01-27T18:17:27Z","updated_at":"2015-02-26T08:47:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86c7e33fd49925ff979aa9bea99beda677e40593","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wikimedia/jquery.uls/pulls/178/commits","review_comments_url":"https://api.github.com/repos/wikimedia/jquery.uls/pulls/178/comments","review_comment_url":"https://api.github.com/repos/wikimedia/jquery.uls/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wikimedia/jquery.uls/issues/178/comments","statuses_url":"https://api.github.com/repos/wikimedia/jquery.uls/statuses/eb0cdd3a34b11c5f5976a55cfba067defc1e2b27","head":{"label":"amire80:ie8","ref":"ie8","sha":"eb0cdd3a34b11c5f5976a55cfba067defc1e2b27","user":{"login":"amire80","id":346271,"avatar_url":"https://avatars.githubusercontent.com/u/346271?v=3","gravatar_id":"","url":"https://api.github.com/users/amire80","html_url":"https://github.com/amire80","followers_url":"https://api.github.com/users/amire80/followers","following_url":"https://api.github.com/users/amire80/following{/other_user}","gists_url":"https://api.github.com/users/amire80/gists{/gist_id}","starred_url":"https://api.github.com/users/amire80/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amire80/subscriptions","organizations_url":"https://api.github.com/users/amire80/orgs","repos_url":"https://api.github.com/users/amire80/repos","events_url":"https://api.github.com/users/amire80/events{/privacy}","received_events_url":"https://api.github.com/users/amire80/received_events","type":"User","site_admin":false},"repo":{"id":5928893,"name":"jquery.uls","full_name":"amire80/jquery.uls","owner":{"login":"amire80","id":346271,"avatar_url":"https://avatars.githubusercontent.com/u/346271?v=3","gravatar_id":"","url":"https://api.github.com/users/amire80","html_url":"https://github.com/amire80","followers_url":"https://api.github.com/users/amire80/followers","following_url":"https://api.github.com/users/amire80/following{/other_user}","gists_url":"https://api.github.com/users/amire80/gists{/gist_id}","starred_url":"https://api.github.com/users/amire80/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amire80/subscriptions","organizations_url":"https://api.github.com/users/amire80/orgs","repos_url":"https://api.github.com/users/amire80/repos","events_url":"https://api.github.com/users/amire80/events{/privacy}","received_events_url":"https://api.github.com/users/amire80/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amire80/jquery.uls","description":"Universal Language Selector ","fork":true,"url":"https://api.github.com/repos/amire80/jquery.uls","forks_url":"https://api.github.com/repos/amire80/jquery.uls/forks","keys_url":"https://api.github.com/repos/amire80/jquery.uls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amire80/jquery.uls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amire80/jquery.uls/teams","hooks_url":"https://api.github.com/repos/amire80/jquery.uls/hooks","issue_events_url":"https://api.github.com/repos/amire80/jquery.uls/issues/events{/number}","events_url":"https://api.github.com/repos/amire80/jquery.uls/events","assignees_url":"https://api.github.com/repos/amire80/jquery.uls/assignees{/user}","branches_url":"https://api.github.com/repos/amire80/jquery.uls/branches{/branch}","tags_url":"https://api.github.com/repos/amire80/jquery.uls/tags","blobs_url":"https://api.github.com/repos/amire80/jquery.uls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amire80/jquery.uls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amire80/jquery.uls/git/refs{/sha}","trees_url":"https://api.github.com/repos/amire80/jquery.uls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amire80/jquery.uls/statuses/{sha}","languages_url":"https://api.github.com/repos/amire80/jquery.uls/languages","stargazers_url":"https://api.github.com/repos/amire80/jquery.uls/stargazers","contributors_url":"https://api.github.com/repos/amire80/jquery.uls/contributors","subscribers_url":"https://api.github.com/repos/amire80/jquery.uls/subscribers","subscription_url":"https://api.github.com/repos/amire80/jquery.uls/subscription","commits_url":"https://api.github.com/repos/amire80/jquery.uls/commits{/sha}","git_commits_url":"https://api.github.com/repos/amire80/jquery.uls/git/commits{/sha}","comments_url":"https://api.github.com/repos/amire80/jquery.uls/comments{/number}","issue_comment_url":"https://api.github.com/repos/amire80/jquery.uls/issues/comments{/number}","contents_url":"https://api.github.com/repos/amire80/jquery.uls/contents/{+path}","compare_url":"https://api.github.com/repos/amire80/jquery.uls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amire80/jquery.uls/merges","archive_url":"https://api.github.com/repos/amire80/jquery.uls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amire80/jquery.uls/downloads","issues_url":"https://api.github.com/repos/amire80/jquery.uls/issues{/number}","pulls_url":"https://api.github.com/repos/amire80/jquery.uls/pulls{/number}","milestones_url":"https://api.github.com/repos/amire80/jquery.uls/milestones{/number}","notifications_url":"https://api.github.com/repos/amire80/jquery.uls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amire80/jquery.uls/labels{/name}","releases_url":"https://api.github.com/repos/amire80/jquery.uls/releases{/id}","created_at":"2012-09-24T02:55:58Z","updated_at":"2015-02-26T08:45:33Z","pushed_at":"2015-02-26T08:46:46Z","git_url":"git://github.com/amire80/jquery.uls.git","ssh_url":"git@github.com:amire80/jquery.uls.git","clone_url":"https://github.com/amire80/jquery.uls.git","svn_url":"https://github.com/amire80/jquery.uls","homepage":null,"size":2254,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wikimedia:master","ref":"master","sha":"0a627fb5313b000f596438d0b359893f5a343987","user":{"login":"wikimedia","id":56668,"avatar_url":"https://avatars.githubusercontent.com/u/56668?v=3","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"repo":{"id":5444106,"name":"jquery.uls","full_name":"wikimedia/jquery.uls","owner":{"login":"wikimedia","id":56668,"avatar_url":"https://avatars.githubusercontent.com/u/56668?v=3","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wikimedia/jquery.uls","description":"Universal Language Selector ","fork":false,"url":"https://api.github.com/repos/wikimedia/jquery.uls","forks_url":"https://api.github.com/repos/wikimedia/jquery.uls/forks","keys_url":"https://api.github.com/repos/wikimedia/jquery.uls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wikimedia/jquery.uls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wikimedia/jquery.uls/teams","hooks_url":"https://api.github.com/repos/wikimedia/jquery.uls/hooks","issue_events_url":"https://api.github.com/repos/wikimedia/jquery.uls/issues/events{/number}","events_url":"https://api.github.com/repos/wikimedia/jquery.uls/events","assignees_url":"https://api.github.com/repos/wikimedia/jquery.uls/assignees{/user}","branches_url":"https://api.github.com/repos/wikimedia/jquery.uls/branches{/branch}","tags_url":"https://api.github.com/repos/wikimedia/jquery.uls/tags","blobs_url":"https://api.github.com/repos/wikimedia/jquery.uls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wikimedia/jquery.uls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wikimedia/jquery.uls/git/refs{/sha}","trees_url":"https://api.github.com/repos/wikimedia/jquery.uls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wikimedia/jquery.uls/statuses/{sha}","languages_url":"https://api.github.com/repos/wikimedia/jquery.uls/languages","stargazers_url":"https://api.github.com/repos/wikimedia/jquery.uls/stargazers","contributors_url":"https://api.github.com/repos/wikimedia/jquery.uls/contributors","subscribers_url":"https://api.github.com/repos/wikimedia/jquery.uls/subscribers","subscription_url":"https://api.github.com/repos/wikimedia/jquery.uls/subscription","commits_url":"https://api.github.com/repos/wikimedia/jquery.uls/commits{/sha}","git_commits_url":"https://api.github.com/repos/wikimedia/jquery.uls/git/commits{/sha}","comments_url":"https://api.github.com/repos/wikimedia/jquery.uls/comments{/number}","issue_comment_url":"https://api.github.com/repos/wikimedia/jquery.uls/issues/comments{/number}","contents_url":"https://api.github.com/repos/wikimedia/jquery.uls/contents/{+path}","compare_url":"https://api.github.com/repos/wikimedia/jquery.uls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wikimedia/jquery.uls/merges","archive_url":"https://api.github.com/repos/wikimedia/jquery.uls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wikimedia/jquery.uls/downloads","issues_url":"https://api.github.com/repos/wikimedia/jquery.uls/issues{/number}","pulls_url":"https://api.github.com/repos/wikimedia/jquery.uls/pulls{/number}","milestones_url":"https://api.github.com/repos/wikimedia/jquery.uls/milestones{/number}","notifications_url":"https://api.github.com/repos/wikimedia/jquery.uls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wikimedia/jquery.uls/labels{/name}","releases_url":"https://api.github.com/repos/wikimedia/jquery.uls/releases{/id}","created_at":"2012-08-16T20:20:09Z","updated_at":"2015-02-22T10:18:14Z","pushed_at":"2015-02-19T12:06:04Z","git_url":"git://github.com/wikimedia/jquery.uls.git","ssh_url":"git@github.com:wikimedia/jquery.uls.git","clone_url":"https://github.com/wikimedia/jquery.uls.git","svn_url":"https://github.com/wikimedia/jquery.uls","homepage":null,"size":2909,"stargazers_count":34,"watchers_count":34,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":17,"forks":36,"open_issues":17,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wikimedia/jquery.uls/pulls/178"},"html":{"href":"https://github.com/wikimedia/jquery.uls/pull/178"},"issue":{"href":"https://api.github.com/repos/wikimedia/jquery.uls/issues/178"},"comments":{"href":"https://api.github.com/repos/wikimedia/jquery.uls/issues/178/comments"},"review_comments":{"href":"https://api.github.com/repos/wikimedia/jquery.uls/pulls/178/comments"},"review_comment":{"href":"https://api.github.com/repos/wikimedia/jquery.uls/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wikimedia/jquery.uls/pulls/178/commits"},"statuses":{"href":"https://api.github.com/repos/wikimedia/jquery.uls/statuses/eb0cdd3a34b11c5f5976a55cfba067defc1e2b27"}}}}