{"action":"created","comment":{"url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/comments/43576436","id":43576436,"diff_hunk":"@@ -279,7 +279,7 @@ describe('collectionview - emptyView', function() {\n       });\n \n       it('renders other empty view instance', function() {\n-        expect(this.getEmptyViewStub).to.have.been.calledWith(this.collectionView.children.first());\n+        expect(this.getEmptyViewStub).to.have.been.called;","path":"test/unit/collection-view.empty-view.spec.js","position":5,"original_position":5,"commit_id":"41aa89aadd018457a7ca190ca1bab8d9e6cb0470","original_commit_id":"41aa89aadd018457a7ca190ca1bab8d9e6cb0470","user":{"login":"paulfalgout","id":2028470,"avatar_url":"https://avatars.githubusercontent.com/u/2028470?v=3","gravatar_id":"","url":"https://api.github.com/users/paulfalgout","html_url":"https://github.com/paulfalgout","followers_url":"https://api.github.com/users/paulfalgout/followers","following_url":"https://api.github.com/users/paulfalgout/following{/other_user}","gists_url":"https://api.github.com/users/paulfalgout/gists{/gist_id}","starred_url":"https://api.github.com/users/paulfalgout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulfalgout/subscriptions","organizations_url":"https://api.github.com/users/paulfalgout/orgs","repos_url":"https://api.github.com/users/paulfalgout/repos","events_url":"https://api.github.com/users/paulfalgout/events{/privacy}","received_events_url":"https://api.github.com/users/paulfalgout/received_events","type":"User","site_admin":false},"body":"So this happened after some dependency updates.  I am not 100%, but I expect (pun intended)  that this is a later version of chai failing the test.   `getEmptyView` is not called with _any_ arguments. ","created_at":"2015-10-31T21:36:05Z","updated_at":"2015-10-31T21:36:05Z","html_url":"https://github.com/marionettejs/backbone.marionette/pull/2801#discussion_r43576436","pull_request_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2801","_links":{"self":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/comments/43576436"},"html":{"href":"https://github.com/marionettejs/backbone.marionette/pull/2801#discussion_r43576436"},"pull_request":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2801"}}},"pull_request":{"url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2801","id":49358862,"html_url":"https://github.com/marionettejs/backbone.marionette/pull/2801","diff_url":"https://github.com/marionettejs/backbone.marionette/pull/2801.diff","patch_url":"https://github.com/marionettejs/backbone.marionette/pull/2801.patch","issue_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/2801","number":2801,"state":"open","locked":false,"title":"Improve gulp","user":{"login":"paulfalgout","id":2028470,"avatar_url":"https://avatars.githubusercontent.com/u/2028470?v=3","gravatar_id":"","url":"https://api.github.com/users/paulfalgout","html_url":"https://github.com/paulfalgout","followers_url":"https://api.github.com/users/paulfalgout/followers","following_url":"https://api.github.com/users/paulfalgout/following{/other_user}","gists_url":"https://api.github.com/users/paulfalgout/gists{/gist_id}","starred_url":"https://api.github.com/users/paulfalgout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulfalgout/subscriptions","organizations_url":"https://api.github.com/users/paulfalgout/orgs","repos_url":"https://api.github.com/users/paulfalgout/repos","events_url":"https://api.github.com/users/paulfalgout/events{/privacy}","received_events_url":"https://api.github.com/users/paulfalgout/received_events","type":"User","site_admin":false},"body":"This is related to https://github.com/marionettejs/backbone.marionette/pull/2769\r\n\r\nMoving to gulp was :+1: \r\nBut keeping grunt around and some of the legacy things were subtly breaking tests or making things seem ok when they weren't.  And things have changed a bit for the better in the node world since we started.  This should be more future friendly.\r\n\r\n**Also this halves the time of the tests/build on Travis.**\r\n\r\nI spent a bit of time, ripping all of the build tools out and putting the back carefully and minimally.\r\n\r\n- jshint is now completely gone and eslint should match the old hint settings.\r\n- grunt is gone and the duplicate test setup files were removed.  They were causing plenty of issues\r\n- jsdom is upgraded to ^7.0 which is good for our windows devs.  This also means that node 4+ is a requirement\r\n- coveralls and coverage are working\r\n- the gulp tasks are broken up by build, test, and linter in an effort to make things more readable.\r\n- I made `gulp-unwrapper` to make `unwrap` a gulp plugin and make it a cleaner implementation\r\n- I moved the includes list into it's own file so that both bundler.js and core.js didn't have to be maintained.\r\n- Dependencies have been updated and removed if not in use (other than dox)\r\n\r\n*Issues*\r\n- This does include a strange fix for Metal for the instance in which Travis loads a different backbone version.  This might indicate we have a bigger problem though.\r\n- Lodash isn't loading for the two 3.x builds and so this won't pass initially.  @megawac @samccone any ideas here in Travis?\r\n- There was also a strange failing test that was checking for undefined being passed in a very strange way that was modified to work.\r\n\r\n*ES6* and https://github.com/marionettejs/backbone.marionette/pull/2769\r\nThis does not further the ES6 stuff at all.  In fact, some of that has been removed in the PR.  Hopefully it can be added easier following this new style.  Plus with babel6 and updates to the boilerplate for that v6 including webpack, I believe there are better ways to handle the ES6 stuff that we should get on now.  Some of the fixes on that branch are handled here as well, but differently.\r\n\r\nThere will be three separate efforts involved there.\r\n1. The most important will be removing the `requireHelper` from the tests and having babel/webpack package the file for testing.  All ES6 dev can be done from here.  Most of it is done in some form on another branch and just needs to be added cleanly.\r\n2. The build.  I think this can be left until last.\r\n3. Eventually we'll want to implement boilerplates test-browser with the live-reload","created_at":"2015-10-31T21:10:46Z","updated_at":"2015-10-31T21:36:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8b21d929bdb882a7ee6cfe69a00c4ce343ff897","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2801/commits","review_comments_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2801/comments","review_comment_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/comments{/number}","comments_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/2801/comments","statuses_url":"https://api.github.com/repos/marionettejs/backbone.marionette/statuses/41aa89aadd018457a7ca190ca1bab8d9e6cb0470","head":{"label":"paulfalgout:improve-gulp","ref":"improve-gulp","sha":"41aa89aadd018457a7ca190ca1bab8d9e6cb0470","user":{"login":"paulfalgout","id":2028470,"avatar_url":"https://avatars.githubusercontent.com/u/2028470?v=3","gravatar_id":"","url":"https://api.github.com/users/paulfalgout","html_url":"https://github.com/paulfalgout","followers_url":"https://api.github.com/users/paulfalgout/followers","following_url":"https://api.github.com/users/paulfalgout/following{/other_user}","gists_url":"https://api.github.com/users/paulfalgout/gists{/gist_id}","starred_url":"https://api.github.com/users/paulfalgout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulfalgout/subscriptions","organizations_url":"https://api.github.com/users/paulfalgout/orgs","repos_url":"https://api.github.com/users/paulfalgout/repos","events_url":"https://api.github.com/users/paulfalgout/events{/privacy}","received_events_url":"https://api.github.com/users/paulfalgout/received_events","type":"User","site_admin":false},"repo":{"id":20825660,"name":"backbone.marionette","full_name":"paulfalgout/backbone.marionette","owner":{"login":"paulfalgout","id":2028470,"avatar_url":"https://avatars.githubusercontent.com/u/2028470?v=3","gravatar_id":"","url":"https://api.github.com/users/paulfalgout","html_url":"https://github.com/paulfalgout","followers_url":"https://api.github.com/users/paulfalgout/followers","following_url":"https://api.github.com/users/paulfalgout/following{/other_user}","gists_url":"https://api.github.com/users/paulfalgout/gists{/gist_id}","starred_url":"https://api.github.com/users/paulfalgout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulfalgout/subscriptions","organizations_url":"https://api.github.com/users/paulfalgout/orgs","repos_url":"https://api.github.com/users/paulfalgout/repos","events_url":"https://api.github.com/users/paulfalgout/events{/privacy}","received_events_url":"https://api.github.com/users/paulfalgout/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paulfalgout/backbone.marionette","description":"Make your Backbone.js applications dance!","fork":true,"url":"https://api.github.com/repos/paulfalgout/backbone.marionette","forks_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/forks","keys_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/teams","hooks_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/hooks","issue_events_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/issues/events{/number}","events_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/events","assignees_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/assignees{/user}","branches_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/branches{/branch}","tags_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/tags","blobs_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/git/refs{/sha}","trees_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/statuses/{sha}","languages_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/languages","stargazers_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/stargazers","contributors_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/contributors","subscribers_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/subscribers","subscription_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/subscription","commits_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/commits{/sha}","git_commits_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/git/commits{/sha}","comments_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/comments{/number}","issue_comment_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/issues/comments{/number}","contents_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/contents/{+path}","compare_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/merges","archive_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/downloads","issues_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/issues{/number}","pulls_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/pulls{/number}","milestones_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/milestones{/number}","notifications_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/labels{/name}","releases_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/releases{/id}","created_at":"2014-06-14T05:19:05Z","updated_at":"2014-07-01T06:11:27Z","pushed_at":"2015-10-31T20:48:18Z","git_url":"git://github.com/paulfalgout/backbone.marionette.git","ssh_url":"git@github.com:paulfalgout/backbone.marionette.git","clone_url":"https://github.com/paulfalgout/backbone.marionette.git","svn_url":"https://github.com/paulfalgout/backbone.marionette","homepage":"http://marionettejs.com","size":11430,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"marionettejs:next","ref":"next","sha":"9025212f2a94ad85a920856c5535433b276640a0","user":{"login":"marionettejs","id":2273169,"avatar_url":"https://avatars.githubusercontent.com/u/2273169?v=3","gravatar_id":"","url":"https://api.github.com/users/marionettejs","html_url":"https://github.com/marionettejs","followers_url":"https://api.github.com/users/marionettejs/followers","following_url":"https://api.github.com/users/marionettejs/following{/other_user}","gists_url":"https://api.github.com/users/marionettejs/gists{/gist_id}","starred_url":"https://api.github.com/users/marionettejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marionettejs/subscriptions","organizations_url":"https://api.github.com/users/marionettejs/orgs","repos_url":"https://api.github.com/users/marionettejs/repos","events_url":"https://api.github.com/users/marionettejs/events{/privacy}","received_events_url":"https://api.github.com/users/marionettejs/received_events","type":"Organization","site_admin":false},"repo":{"id":2965621,"name":"backbone.marionette","full_name":"marionettejs/backbone.marionette","owner":{"login":"marionettejs","id":2273169,"avatar_url":"https://avatars.githubusercontent.com/u/2273169?v=3","gravatar_id":"","url":"https://api.github.com/users/marionettejs","html_url":"https://github.com/marionettejs","followers_url":"https://api.github.com/users/marionettejs/followers","following_url":"https://api.github.com/users/marionettejs/following{/other_user}","gists_url":"https://api.github.com/users/marionettejs/gists{/gist_id}","starred_url":"https://api.github.com/users/marionettejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marionettejs/subscriptions","organizations_url":"https://api.github.com/users/marionettejs/orgs","repos_url":"https://api.github.com/users/marionettejs/repos","events_url":"https://api.github.com/users/marionettejs/events{/privacy}","received_events_url":"https://api.github.com/users/marionettejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/marionettejs/backbone.marionette","description":"The Backbone Framework","fork":false,"url":"https://api.github.com/repos/marionettejs/backbone.marionette","forks_url":"https://api.github.com/repos/marionettejs/backbone.marionette/forks","keys_url":"https://api.github.com/repos/marionettejs/backbone.marionette/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marionettejs/backbone.marionette/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marionettejs/backbone.marionette/teams","hooks_url":"https://api.github.com/repos/marionettejs/backbone.marionette/hooks","issue_events_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/events{/number}","events_url":"https://api.github.com/repos/marionettejs/backbone.marionette/events","assignees_url":"https://api.github.com/repos/marionettejs/backbone.marionette/assignees{/user}","branches_url":"https://api.github.com/repos/marionettejs/backbone.marionette/branches{/branch}","tags_url":"https://api.github.com/repos/marionettejs/backbone.marionette/tags","blobs_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/refs{/sha}","trees_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marionettejs/backbone.marionette/statuses/{sha}","languages_url":"https://api.github.com/repos/marionettejs/backbone.marionette/languages","stargazers_url":"https://api.github.com/repos/marionettejs/backbone.marionette/stargazers","contributors_url":"https://api.github.com/repos/marionettejs/backbone.marionette/contributors","subscribers_url":"https://api.github.com/repos/marionettejs/backbone.marionette/subscribers","subscription_url":"https://api.github.com/repos/marionettejs/backbone.marionette/subscription","commits_url":"https://api.github.com/repos/marionettejs/backbone.marionette/commits{/sha}","git_commits_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/commits{/sha}","comments_url":"https://api.github.com/repos/marionettejs/backbone.marionette/comments{/number}","issue_comment_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/comments{/number}","contents_url":"https://api.github.com/repos/marionettejs/backbone.marionette/contents/{+path}","compare_url":"https://api.github.com/repos/marionettejs/backbone.marionette/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marionettejs/backbone.marionette/merges","archive_url":"https://api.github.com/repos/marionettejs/backbone.marionette/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marionettejs/backbone.marionette/downloads","issues_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues{/number}","pulls_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls{/number}","milestones_url":"https://api.github.com/repos/marionettejs/backbone.marionette/milestones{/number}","notifications_url":"https://api.github.com/repos/marionettejs/backbone.marionette/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marionettejs/backbone.marionette/labels{/name}","releases_url":"https://api.github.com/repos/marionettejs/backbone.marionette/releases{/id}","created_at":"2011-12-12T16:36:09Z","updated_at":"2015-10-31T05:41:07Z","pushed_at":"2015-10-31T21:10:46Z","git_url":"git://github.com/marionettejs/backbone.marionette.git","ssh_url":"git@github.com:marionettejs/backbone.marionette.git","clone_url":"https://github.com/marionettejs/backbone.marionette.git","svn_url":"https://github.com/marionettejs/backbone.marionette","homepage":"http://marionettejs.com","size":22965,"stargazers_count":6557,"watchers_count":6557,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1303,"mirror_url":null,"open_issues_count":138,"forks":1303,"open_issues":138,"watchers":6557,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2801"},"html":{"href":"https://github.com/marionettejs/backbone.marionette/pull/2801"},"issue":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/2801"},"comments":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/2801/comments"},"review_comments":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2801/comments"},"review_comment":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2801/commits"},"statuses":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/statuses/41aa89aadd018457a7ca190ca1bab8d9e6cb0470"}}}}