{"action":"created","comment":{"url":"https://api.github.com/repos/pydata/pandas/pulls/comments/41132020","id":41132020,"diff_hunk":"@@ -5853,6 +5853,10 @@ def test_ptp(self):\n         ser = Series(arr)\n         self.assertEqual(np.ptp(ser), np.ptp(arr))\n \n+        # GH11163\n+        s = Series([3, 5, np.nan, -3, 10])","path":"pandas/tests/test_series.py","position":5,"original_position":5,"commit_id":"6c7842305e038fd2240c2b99b389b19dc76fbef8","original_commit_id":"6c7842305e038fd2240c2b99b389b19dc76fbef8","user":{"login":"jreback","id":953992,"avatar_url":"https://avatars.githubusercontent.com/u/953992?v=3","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"body":"since going to change args add tests that exercise these","created_at":"2015-10-05T11:05:11Z","updated_at":"2015-10-05T11:05:11Z","html_url":"https://github.com/pydata/pandas/pull/11172#discussion_r41132020","pull_request_url":"https://api.github.com/repos/pydata/pandas/pulls/11172","_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments/41132020"},"html":{"href":"https://github.com/pydata/pandas/pull/11172#discussion_r41132020"},"pull_request":{"href":"https://api.github.com/repos/pydata/pandas/pulls/11172"}}},"pull_request":{"url":"https://api.github.com/repos/pydata/pandas/pulls/11172","id":45712932,"html_url":"https://github.com/pydata/pandas/pull/11172","diff_url":"https://github.com/pydata/pandas/pull/11172.diff","patch_url":"https://github.com/pydata/pandas/pull/11172.patch","issue_url":"https://api.github.com/repos/pydata/pandas/issues/11172","number":11172,"state":"open","locked":false,"title":"ENH: make Series.ptp ignore NaN values (GH11163)","user":{"login":"ajcr","id":6031088,"avatar_url":"https://avatars.githubusercontent.com/u/6031088?v=3","gravatar_id":"","url":"https://api.github.com/users/ajcr","html_url":"https://github.com/ajcr","followers_url":"https://api.github.com/users/ajcr/followers","following_url":"https://api.github.com/users/ajcr/following{/other_user}","gists_url":"https://api.github.com/users/ajcr/gists{/gist_id}","starred_url":"https://api.github.com/users/ajcr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajcr/subscriptions","organizations_url":"https://api.github.com/users/ajcr/orgs","repos_url":"https://api.github.com/users/ajcr/repos","events_url":"https://api.github.com/users/ajcr/events{/privacy}","received_events_url":"https://api.github.com/users/ajcr/received_events","type":"User","site_admin":false},"body":"Closes [GH11163](https://github.com/pydata/pandas/issues/11163).\r\n\r\n`Series.ptp` will now ignore missing values when calculating the peak to peak difference.","created_at":"2015-09-22T20:31:53Z","updated_at":"2015-10-05T11:05:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c619b93a476de169ba988dea798cf4b8cbc69852","assignee":null,"milestone":{"url":"https://api.github.com/repos/pydata/pandas/milestones/37","html_url":"https://github.com/pydata/pandas/milestones/0.17.1","labels_url":"https://api.github.com/repos/pydata/pandas/milestones/37/labels","id":1299459,"number":37,"title":"0.17.1","description":"after 0.17.0 of course!","creator":{"login":"jreback","id":953992,"avatar_url":"https://avatars.githubusercontent.com/u/953992?v=3","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"open_issues":45,"closed_issues":0,"state":"open","created_at":"2015-09-10T14:30:44Z","updated_at":"2015-10-05T11:02:22Z","due_on":"2015-11-14T05:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pydata/pandas/pulls/11172/commits","review_comments_url":"https://api.github.com/repos/pydata/pandas/pulls/11172/comments","review_comment_url":"https://api.github.com/repos/pydata/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pydata/pandas/issues/11172/comments","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/6c7842305e038fd2240c2b99b389b19dc76fbef8","head":{"label":"ajcr:ptp-handle-nan","ref":"ptp-handle-nan","sha":"6c7842305e038fd2240c2b99b389b19dc76fbef8","user":{"login":"ajcr","id":6031088,"avatar_url":"https://avatars.githubusercontent.com/u/6031088?v=3","gravatar_id":"","url":"https://api.github.com/users/ajcr","html_url":"https://github.com/ajcr","followers_url":"https://api.github.com/users/ajcr/followers","following_url":"https://api.github.com/users/ajcr/following{/other_user}","gists_url":"https://api.github.com/users/ajcr/gists{/gist_id}","starred_url":"https://api.github.com/users/ajcr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajcr/subscriptions","organizations_url":"https://api.github.com/users/ajcr/orgs","repos_url":"https://api.github.com/users/ajcr/repos","events_url":"https://api.github.com/users/ajcr/events{/privacy}","received_events_url":"https://api.github.com/users/ajcr/received_events","type":"User","site_admin":false},"repo":{"id":21327520,"name":"pandas","full_name":"ajcr/pandas","owner":{"login":"ajcr","id":6031088,"avatar_url":"https://avatars.githubusercontent.com/u/6031088?v=3","gravatar_id":"","url":"https://api.github.com/users/ajcr","html_url":"https://github.com/ajcr","followers_url":"https://api.github.com/users/ajcr/followers","following_url":"https://api.github.com/users/ajcr/following{/other_user}","gists_url":"https://api.github.com/users/ajcr/gists{/gist_id}","starred_url":"https://api.github.com/users/ajcr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajcr/subscriptions","organizations_url":"https://api.github.com/users/ajcr/orgs","repos_url":"https://api.github.com/users/ajcr/repos","events_url":"https://api.github.com/users/ajcr/events{/privacy}","received_events_url":"https://api.github.com/users/ajcr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajcr/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/ajcr/pandas","forks_url":"https://api.github.com/repos/ajcr/pandas/forks","keys_url":"https://api.github.com/repos/ajcr/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajcr/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajcr/pandas/teams","hooks_url":"https://api.github.com/repos/ajcr/pandas/hooks","issue_events_url":"https://api.github.com/repos/ajcr/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/ajcr/pandas/events","assignees_url":"https://api.github.com/repos/ajcr/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/ajcr/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/ajcr/pandas/tags","blobs_url":"https://api.github.com/repos/ajcr/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajcr/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajcr/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajcr/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajcr/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/ajcr/pandas/languages","stargazers_url":"https://api.github.com/repos/ajcr/pandas/stargazers","contributors_url":"https://api.github.com/repos/ajcr/pandas/contributors","subscribers_url":"https://api.github.com/repos/ajcr/pandas/subscribers","subscription_url":"https://api.github.com/repos/ajcr/pandas/subscription","commits_url":"https://api.github.com/repos/ajcr/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajcr/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajcr/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajcr/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajcr/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/ajcr/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajcr/pandas/merges","archive_url":"https://api.github.com/repos/ajcr/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajcr/pandas/downloads","issues_url":"https://api.github.com/repos/ajcr/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/ajcr/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/ajcr/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/ajcr/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajcr/pandas/labels{/name}","releases_url":"https://api.github.com/repos/ajcr/pandas/releases{/id}","created_at":"2014-06-29T16:43:24Z","updated_at":"2014-06-27T17:35:04Z","pushed_at":"2015-09-22T20:27:12Z","git_url":"git://github.com/ajcr/pandas.git","ssh_url":"git@github.com:ajcr/pandas.git","clone_url":"https://github.com/ajcr/pandas.git","svn_url":"https://github.com/ajcr/pandas","homepage":"http://pandas.pydata.org","size":65128,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pydata:master","ref":"master","sha":"c6bcc991e5bd6b62f837cb7cd371c2fdeb95ab6e","user":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=3","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pydata/pandas","owner":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=3","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pydata/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pydata/pandas","forks_url":"https://api.github.com/repos/pydata/pandas/forks","keys_url":"https://api.github.com/repos/pydata/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pydata/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pydata/pandas/teams","hooks_url":"https://api.github.com/repos/pydata/pandas/hooks","issue_events_url":"https://api.github.com/repos/pydata/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pydata/pandas/events","assignees_url":"https://api.github.com/repos/pydata/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pydata/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pydata/pandas/tags","blobs_url":"https://api.github.com/repos/pydata/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pydata/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pydata/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pydata/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pydata/pandas/languages","stargazers_url":"https://api.github.com/repos/pydata/pandas/stargazers","contributors_url":"https://api.github.com/repos/pydata/pandas/contributors","subscribers_url":"https://api.github.com/repos/pydata/pandas/subscribers","subscription_url":"https://api.github.com/repos/pydata/pandas/subscription","commits_url":"https://api.github.com/repos/pydata/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pydata/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pydata/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pydata/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pydata/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pydata/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pydata/pandas/merges","archive_url":"https://api.github.com/repos/pydata/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pydata/pandas/downloads","issues_url":"https://api.github.com/repos/pydata/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pydata/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pydata/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pydata/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pydata/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pydata/pandas/releases{/id}","created_at":"2010-08-24T01:37:33Z","updated_at":"2015-10-05T00:07:36Z","pushed_at":"2015-10-05T00:30:25Z","git_url":"git://github.com/pydata/pandas.git","ssh_url":"git@github.com:pydata/pandas.git","clone_url":"https://github.com/pydata/pandas.git","svn_url":"https://github.com/pydata/pandas","homepage":"http://pandas.pydata.org","size":160758,"stargazers_count":5050,"watchers_count":5050,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1956,"mirror_url":null,"open_issues_count":1502,"forks":1956,"open_issues":1502,"watchers":5050,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/11172"},"html":{"href":"https://github.com/pydata/pandas/pull/11172"},"issue":{"href":"https://api.github.com/repos/pydata/pandas/issues/11172"},"comments":{"href":"https://api.github.com/repos/pydata/pandas/issues/11172/comments"},"review_comments":{"href":"https://api.github.com/repos/pydata/pandas/pulls/11172/comments"},"review_comment":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pydata/pandas/pulls/11172/commits"},"statuses":{"href":"https://api.github.com/repos/pydata/pandas/statuses/6c7842305e038fd2240c2b99b389b19dc76fbef8"}}}}