{"action":"created","issue":{"url":"https://api.github.com/repos/yiisoft/yii2/issues/8573","labels_url":"https://api.github.com/repos/yiisoft/yii2/issues/8573/labels{/name}","comments_url":"https://api.github.com/repos/yiisoft/yii2/issues/8573/comments","events_url":"https://api.github.com/repos/yiisoft/yii2/issues/8573/events","html_url":"https://github.com/yiisoft/yii2/issues/8573","id":81420747,"number":8573,"title":"oci schema map wrongly NUMBER dbType to either type INTEGER or DECIMAL","user":{"login":"bobonov","id":1412083,"avatar_url":"https://avatars.githubusercontent.com/u/1412083?v=3","gravatar_id":"","url":"https://api.github.com/users/bobonov","html_url":"https://github.com/bobonov","followers_url":"https://api.github.com/users/bobonov/followers","following_url":"https://api.github.com/users/bobonov/following{/other_user}","gists_url":"https://api.github.com/users/bobonov/gists{/gist_id}","starred_url":"https://api.github.com/users/bobonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobonov/subscriptions","organizations_url":"https://api.github.com/users/bobonov/orgs","repos_url":"https://api.github.com/users/bobonov/repos","events_url":"https://api.github.com/users/bobonov/events{/privacy}","received_events_url":"https://api.github.com/users/bobonov/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/yiisoft/yii2/labels/feature:db","name":"feature:db","color":"bfd4f2"},{"url":"https://api.github.com/repos/yiisoft/yii2/labels/type:bug","name":"type:bug","color":"e102d8"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/yiisoft/yii2/milestones/9","html_url":"https://github.com/yiisoft/yii2/milestones/2.0.x","labels_url":"https://api.github.com/repos/yiisoft/yii2/milestones/9/labels","id":831720,"number":9,"title":"2.0.x","description":"","creator":{"login":"cebe","id":189796,"avatar_url":"https://avatars.githubusercontent.com/u/189796?v=3","gravatar_id":"","url":"https://api.github.com/users/cebe","html_url":"https://github.com/cebe","followers_url":"https://api.github.com/users/cebe/followers","following_url":"https://api.github.com/users/cebe/following{/other_user}","gists_url":"https://api.github.com/users/cebe/gists{/gist_id}","starred_url":"https://api.github.com/users/cebe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cebe/subscriptions","organizations_url":"https://api.github.com/users/cebe/orgs","repos_url":"https://api.github.com/users/cebe/repos","events_url":"https://api.github.com/users/cebe/events{/privacy}","received_events_url":"https://api.github.com/users/cebe/received_events","type":"User","site_admin":false},"open_issues":352,"closed_issues":1,"state":"open","created_at":"2014-10-19T13:49:45Z","updated_at":"2015-06-03T11:11:15Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2015-05-27T12:02:30Z","updated_at":"2015-06-03T11:12:15Z","closed_at":null,"body":"In /yii2/db/oci/Schema.php\r\nextractColumnType method wrongly map NUMBERS to INTEGER or DECIMAL.\r\n\r\nAccording to Oracle documentation\r\nhttp://docs.oracle.com/cd/B28359_01/server.111/b28318/datatype.htm#CNCPT1832\r\n\r\nWhen scale is 0 the number should be treated as an integer.\r\nBut if \"If a precision is not specified, the column stores values as given.\"\r\nAs I tested, even is is not clear from the docs, this override the scale.\r\n\r\nSo if the NUMBER column has scale=0 and precision=0 a double value is stored correctly.\r\n"},"comment":{"url":"https://api.github.com/repos/yiisoft/yii2/issues/comments/108300617","html_url":"https://github.com/yiisoft/yii2/issues/8573#issuecomment-108300617","issue_url":"https://api.github.com/repos/yiisoft/yii2/issues/8573","id":108300617,"user":{"login":"cebe","id":189796,"avatar_url":"https://avatars.githubusercontent.com/u/189796?v=3","gravatar_id":"","url":"https://api.github.com/users/cebe","html_url":"https://github.com/cebe","followers_url":"https://api.github.com/users/cebe/followers","following_url":"https://api.github.com/users/cebe/following{/other_user}","gists_url":"https://api.github.com/users/cebe/gists{/gist_id}","starred_url":"https://api.github.com/users/cebe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cebe/subscriptions","organizations_url":"https://api.github.com/users/cebe/orgs","repos_url":"https://api.github.com/users/cebe/repos","events_url":"https://api.github.com/users/cebe/events{/privacy}","received_events_url":"https://api.github.com/users/cebe/received_events","type":"User","site_admin":false},"created_at":"2015-06-03T11:12:15Z","updated_at":"2015-06-03T11:12:15Z","body":"> How i can make new pull request without pending changes (only framework/db/oci/Schema.php)?\r\n\r\nyou should always work on a different branch to separate the changes."}}