{"action":"created","comment":{"url":"https://api.github.com/repos/thumbor/thumbor/pulls/comments/41398288","id":41398288,"diff_hunk":"@@ -250,16 +250,13 @@ def _load_results(self, context):\n \n         return results, content_type\n \n+    @gen.coroutine\n     def _process_result_from_storage(self, result):\n         if self.context.config.SEND_IF_MODIFIED_LAST_MODIFIED_HEADERS:\n             # Handle If-Modified-Since & Last-Modified header\n             try:\n-                result_last_modified = self.context.modules.result_storage.last_updated()\n-            except NotImplementedError:\n-                logger.warn('last_updated method is not supported by your result storage service, hence If-Modified-Since & '\n-                            'Last-Updated headers support is disabled.')\n+                result_last_modified = yield gen.maybe_future(self.context.modules.result_storage.last_updated())\n \n-            if result_last_modified:","path":"thumbor/handlers/__init__.py","position":15,"original_position":15,"commit_id":"c7d466bf50977ad171dbd4a056ef38af792e2274","original_commit_id":"c7d466bf50977ad171dbd4a056ef38af792e2274","user":{"login":"masom","id":438456,"avatar_url":"https://avatars.githubusercontent.com/u/438456?v=3","gravatar_id":"","url":"https://api.github.com/users/masom","html_url":"https://github.com/masom","followers_url":"https://api.github.com/users/masom/followers","following_url":"https://api.github.com/users/masom/following{/other_user}","gists_url":"https://api.github.com/users/masom/gists{/gist_id}","starred_url":"https://api.github.com/users/masom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masom/subscriptions","organizations_url":"https://api.github.com/users/masom/orgs","repos_url":"https://api.github.com/users/masom/repos","events_url":"https://api.github.com/users/masom/events{/privacy}","received_events_url":"https://api.github.com/users/masom/received_events","type":"User","site_admin":false},"body":"Removing this if might make \r\n`if result_last_modified <= date_modified_since` succeed/ fail even if it should not.\r\n\r\nif `result_last_modified` is `None` then if clause is always true.\r\n","created_at":"2015-10-07T14:41:56Z","updated_at":"2015-10-07T14:41:56Z","html_url":"https://github.com/thumbor/thumbor/pull/574#discussion_r41398288","pull_request_url":"https://api.github.com/repos/thumbor/thumbor/pulls/574","_links":{"self":{"href":"https://api.github.com/repos/thumbor/thumbor/pulls/comments/41398288"},"html":{"href":"https://github.com/thumbor/thumbor/pull/574#discussion_r41398288"},"pull_request":{"href":"https://api.github.com/repos/thumbor/thumbor/pulls/574"}}},"pull_request":{"url":"https://api.github.com/repos/thumbor/thumbor/pulls/574","id":47030006,"html_url":"https://github.com/thumbor/thumbor/pull/574","diff_url":"https://github.com/thumbor/thumbor/pull/574.diff","patch_url":"https://github.com/thumbor/thumbor/pull/574.patch","issue_url":"https://api.github.com/repos/thumbor/thumbor/issues/574","number":574,"state":"open","locked":false,"title":"Fixed async result storage with last modified header","user":{"login":"Bladrak","id":1321977,"avatar_url":"https://avatars.githubusercontent.com/u/1321977?v=3","gravatar_id":"","url":"https://api.github.com/users/Bladrak","html_url":"https://github.com/Bladrak","followers_url":"https://api.github.com/users/Bladrak/followers","following_url":"https://api.github.com/users/Bladrak/following{/other_user}","gists_url":"https://api.github.com/users/Bladrak/gists{/gist_id}","starred_url":"https://api.github.com/users/Bladrak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bladrak/subscriptions","organizations_url":"https://api.github.com/users/Bladrak/orgs","repos_url":"https://api.github.com/users/Bladrak/repos","events_url":"https://api.github.com/users/Bladrak/events{/privacy}","received_events_url":"https://api.github.com/users/Bladrak/received_events","type":"User","site_admin":false},"body":"Following up #573","created_at":"2015-10-07T13:55:39Z","updated_at":"2015-10-07T14:41:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"514b1fd34fdf0a7afa33cff545bab73fa8b2f9c8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/thumbor/thumbor/pulls/574/commits","review_comments_url":"https://api.github.com/repos/thumbor/thumbor/pulls/574/comments","review_comment_url":"https://api.github.com/repos/thumbor/thumbor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thumbor/thumbor/issues/574/comments","statuses_url":"https://api.github.com/repos/thumbor/thumbor/statuses/c7d466bf50977ad171dbd4a056ef38af792e2274","head":{"label":"Bladrak:async_last_modified","ref":"async_last_modified","sha":"c7d466bf50977ad171dbd4a056ef38af792e2274","user":{"login":"Bladrak","id":1321977,"avatar_url":"https://avatars.githubusercontent.com/u/1321977?v=3","gravatar_id":"","url":"https://api.github.com/users/Bladrak","html_url":"https://github.com/Bladrak","followers_url":"https://api.github.com/users/Bladrak/followers","following_url":"https://api.github.com/users/Bladrak/following{/other_user}","gists_url":"https://api.github.com/users/Bladrak/gists{/gist_id}","starred_url":"https://api.github.com/users/Bladrak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bladrak/subscriptions","organizations_url":"https://api.github.com/users/Bladrak/orgs","repos_url":"https://api.github.com/users/Bladrak/repos","events_url":"https://api.github.com/users/Bladrak/events{/privacy}","received_events_url":"https://api.github.com/users/Bladrak/received_events","type":"User","site_admin":false},"repo":{"id":28046032,"name":"thumbor","full_name":"Bladrak/thumbor","owner":{"login":"Bladrak","id":1321977,"avatar_url":"https://avatars.githubusercontent.com/u/1321977?v=3","gravatar_id":"","url":"https://api.github.com/users/Bladrak","html_url":"https://github.com/Bladrak","followers_url":"https://api.github.com/users/Bladrak/followers","following_url":"https://api.github.com/users/Bladrak/following{/other_user}","gists_url":"https://api.github.com/users/Bladrak/gists{/gist_id}","starred_url":"https://api.github.com/users/Bladrak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bladrak/subscriptions","organizations_url":"https://api.github.com/users/Bladrak/orgs","repos_url":"https://api.github.com/users/Bladrak/repos","events_url":"https://api.github.com/users/Bladrak/events{/privacy}","received_events_url":"https://api.github.com/users/Bladrak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Bladrak/thumbor","description":"thumbor is an open-source photo thumbnail service by globo.com","fork":true,"url":"https://api.github.com/repos/Bladrak/thumbor","forks_url":"https://api.github.com/repos/Bladrak/thumbor/forks","keys_url":"https://api.github.com/repos/Bladrak/thumbor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bladrak/thumbor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bladrak/thumbor/teams","hooks_url":"https://api.github.com/repos/Bladrak/thumbor/hooks","issue_events_url":"https://api.github.com/repos/Bladrak/thumbor/issues/events{/number}","events_url":"https://api.github.com/repos/Bladrak/thumbor/events","assignees_url":"https://api.github.com/repos/Bladrak/thumbor/assignees{/user}","branches_url":"https://api.github.com/repos/Bladrak/thumbor/branches{/branch}","tags_url":"https://api.github.com/repos/Bladrak/thumbor/tags","blobs_url":"https://api.github.com/repos/Bladrak/thumbor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bladrak/thumbor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bladrak/thumbor/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bladrak/thumbor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bladrak/thumbor/statuses/{sha}","languages_url":"https://api.github.com/repos/Bladrak/thumbor/languages","stargazers_url":"https://api.github.com/repos/Bladrak/thumbor/stargazers","contributors_url":"https://api.github.com/repos/Bladrak/thumbor/contributors","subscribers_url":"https://api.github.com/repos/Bladrak/thumbor/subscribers","subscription_url":"https://api.github.com/repos/Bladrak/thumbor/subscription","commits_url":"https://api.github.com/repos/Bladrak/thumbor/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bladrak/thumbor/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bladrak/thumbor/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bladrak/thumbor/issues/comments{/number}","contents_url":"https://api.github.com/repos/Bladrak/thumbor/contents/{+path}","compare_url":"https://api.github.com/repos/Bladrak/thumbor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bladrak/thumbor/merges","archive_url":"https://api.github.com/repos/Bladrak/thumbor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bladrak/thumbor/downloads","issues_url":"https://api.github.com/repos/Bladrak/thumbor/issues{/number}","pulls_url":"https://api.github.com/repos/Bladrak/thumbor/pulls{/number}","milestones_url":"https://api.github.com/repos/Bladrak/thumbor/milestones{/number}","notifications_url":"https://api.github.com/repos/Bladrak/thumbor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bladrak/thumbor/labels{/name}","releases_url":"https://api.github.com/repos/Bladrak/thumbor/releases{/id}","created_at":"2014-12-15T16:46:46Z","updated_at":"2014-12-15T16:46:48Z","pushed_at":"2015-10-07T13:55:15Z","git_url":"git://github.com/Bladrak/thumbor.git","ssh_url":"git@github.com:Bladrak/thumbor.git","clone_url":"https://github.com/Bladrak/thumbor.git","svn_url":"https://github.com/Bladrak/thumbor","homepage":"http://thumbor.org","size":7443,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thumbor:master","ref":"master","sha":"97a55594a67e3cf3b5e7d09cde5944bc821eeb1e","user":{"login":"thumbor","id":6918711,"avatar_url":"https://avatars.githubusercontent.com/u/6918711?v=3","gravatar_id":"","url":"https://api.github.com/users/thumbor","html_url":"https://github.com/thumbor","followers_url":"https://api.github.com/users/thumbor/followers","following_url":"https://api.github.com/users/thumbor/following{/other_user}","gists_url":"https://api.github.com/users/thumbor/gists{/gist_id}","starred_url":"https://api.github.com/users/thumbor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thumbor/subscriptions","organizations_url":"https://api.github.com/users/thumbor/orgs","repos_url":"https://api.github.com/users/thumbor/repos","events_url":"https://api.github.com/users/thumbor/events{/privacy}","received_events_url":"https://api.github.com/users/thumbor/received_events","type":"Organization","site_admin":false},"repo":{"id":1488139,"name":"thumbor","full_name":"thumbor/thumbor","owner":{"login":"thumbor","id":6918711,"avatar_url":"https://avatars.githubusercontent.com/u/6918711?v=3","gravatar_id":"","url":"https://api.github.com/users/thumbor","html_url":"https://github.com/thumbor","followers_url":"https://api.github.com/users/thumbor/followers","following_url":"https://api.github.com/users/thumbor/following{/other_user}","gists_url":"https://api.github.com/users/thumbor/gists{/gist_id}","starred_url":"https://api.github.com/users/thumbor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thumbor/subscriptions","organizations_url":"https://api.github.com/users/thumbor/orgs","repos_url":"https://api.github.com/users/thumbor/repos","events_url":"https://api.github.com/users/thumbor/events{/privacy}","received_events_url":"https://api.github.com/users/thumbor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thumbor/thumbor","description":"thumbor is an open-source photo thumbnail service by globo.com","fork":false,"url":"https://api.github.com/repos/thumbor/thumbor","forks_url":"https://api.github.com/repos/thumbor/thumbor/forks","keys_url":"https://api.github.com/repos/thumbor/thumbor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thumbor/thumbor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thumbor/thumbor/teams","hooks_url":"https://api.github.com/repos/thumbor/thumbor/hooks","issue_events_url":"https://api.github.com/repos/thumbor/thumbor/issues/events{/number}","events_url":"https://api.github.com/repos/thumbor/thumbor/events","assignees_url":"https://api.github.com/repos/thumbor/thumbor/assignees{/user}","branches_url":"https://api.github.com/repos/thumbor/thumbor/branches{/branch}","tags_url":"https://api.github.com/repos/thumbor/thumbor/tags","blobs_url":"https://api.github.com/repos/thumbor/thumbor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thumbor/thumbor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thumbor/thumbor/git/refs{/sha}","trees_url":"https://api.github.com/repos/thumbor/thumbor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thumbor/thumbor/statuses/{sha}","languages_url":"https://api.github.com/repos/thumbor/thumbor/languages","stargazers_url":"https://api.github.com/repos/thumbor/thumbor/stargazers","contributors_url":"https://api.github.com/repos/thumbor/thumbor/contributors","subscribers_url":"https://api.github.com/repos/thumbor/thumbor/subscribers","subscription_url":"https://api.github.com/repos/thumbor/thumbor/subscription","commits_url":"https://api.github.com/repos/thumbor/thumbor/commits{/sha}","git_commits_url":"https://api.github.com/repos/thumbor/thumbor/git/commits{/sha}","comments_url":"https://api.github.com/repos/thumbor/thumbor/comments{/number}","issue_comment_url":"https://api.github.com/repos/thumbor/thumbor/issues/comments{/number}","contents_url":"https://api.github.com/repos/thumbor/thumbor/contents/{+path}","compare_url":"https://api.github.com/repos/thumbor/thumbor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thumbor/thumbor/merges","archive_url":"https://api.github.com/repos/thumbor/thumbor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thumbor/thumbor/downloads","issues_url":"https://api.github.com/repos/thumbor/thumbor/issues{/number}","pulls_url":"https://api.github.com/repos/thumbor/thumbor/pulls{/number}","milestones_url":"https://api.github.com/repos/thumbor/thumbor/milestones{/number}","notifications_url":"https://api.github.com/repos/thumbor/thumbor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thumbor/thumbor/labels{/name}","releases_url":"https://api.github.com/repos/thumbor/thumbor/releases{/id}","created_at":"2011-03-16T17:30:05Z","updated_at":"2015-10-06T15:38:40Z","pushed_at":"2015-10-07T13:55:39Z","git_url":"git://github.com/thumbor/thumbor.git","ssh_url":"git@github.com:thumbor/thumbor.git","clone_url":"https://github.com/thumbor/thumbor.git","svn_url":"https://github.com/thumbor/thumbor","homepage":"http://thumbor.org","size":27591,"stargazers_count":3327,"watchers_count":3327,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":309,"mirror_url":null,"open_issues_count":64,"forks":309,"open_issues":64,"watchers":3327,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thumbor/thumbor/pulls/574"},"html":{"href":"https://github.com/thumbor/thumbor/pull/574"},"issue":{"href":"https://api.github.com/repos/thumbor/thumbor/issues/574"},"comments":{"href":"https://api.github.com/repos/thumbor/thumbor/issues/574/comments"},"review_comments":{"href":"https://api.github.com/repos/thumbor/thumbor/pulls/574/comments"},"review_comment":{"href":"https://api.github.com/repos/thumbor/thumbor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thumbor/thumbor/pulls/574/commits"},"statuses":{"href":"https://api.github.com/repos/thumbor/thumbor/statuses/c7d466bf50977ad171dbd4a056ef38af792e2274"}}}}