{"action":"created","comment":{"url":"https://api.github.com/repos/cogneco/ooc-kean/pulls/comments/40554179","id":40554179,"diff_hunk":"@@ -37,36 +37,70 @@ Gles3VertexArrayObject: class extends GLVertexArrayObject {\n \t\t\t\tpackedArray[attributeCount * dimensions * i + j + dimensions] = textureCoordinates[dimensions * i + j]\n \t\t\t}\n \t\t}\n+\t\tthis _generate(packedArray[0]&, 2, vertexCount)\n+\t}\n+\tinit: func ~twoDimensions (positions, textureCoordinates: FloatPoint2D[]) {\n+\t\tvertexCount := positions length\n+\t\tthis _vertexCount = vertexCount\n+\t\tfloatsPerVertex := 4\n+\t\tpackedArray: Float[floatsPerVertex * vertexCount]\n+\t\tfor (i in 0 .. vertexCount) {\n+\t\t\t//Positions\n+\t\t\tpackedArray[floatsPerVertex * i + 0] = positions[i] x\n+\t\t\tpackedArray[floatsPerVertex * i + 1] = positions[i] y\n+\t\t\t//Texture coordinates\n+\t\t\tpackedArray[floatsPerVertex * i + 2] = textureCoordinates[i] x\n+\t\t\tpackedArray[floatsPerVertex * i + 3] = textureCoordinates[i] y\n+\t\t}\n+\t\tthis _generate(packedArray[0]&, 2, vertexCount)\n+\t}\n+\tinit: func ~threeDimensions (positions: FloatPoint3D[], textureCoordinates: FloatPoint2D[]) {\n+\t\tvertexCount := positions length\n+\t\tthis _vertexCount = vertexCount\n+\t\tfloatsPerVertex := 5\n+\t\tpackedArray: Float[vertexCount * floatsPerVertex]\n+\t\tfor (i in 0 .. vertexCount) {\n+\t\t\t//Positions\n+\t\t\tpackedArray[floatsPerVertex * i + 0] = positions[i] x\n+\t\t\tpackedArray[floatsPerVertex * i + 1] = positions[i] y\n+\t\t\tpackedArray[floatsPerVertex * i + 2] = positions[i] z\n+\t\t\t//Texture coordinates\n+\t\t\tpackedArray[floatsPerVertex * i + 3] = textureCoordinates[i] x\n+\t\t\tpackedArray[floatsPerVertex * i + 4] = textureCoordinates[i] y\n+\t\t}\n+\t\tthis _generate(packedArray[0]&, 3, vertexCount)","path":"source/draw/gpu/opengl/backend/gles3/Gles3VertexArrayObject.ooc","position":58,"original_position":58,"commit_id":"bdd8faba40e46c4afff70c715cea280c95c60b07","original_commit_id":"bdd8faba40e46c4afff70c715cea280c95c60b07","user":{"login":"emilwestergren","id":7700995,"avatar_url":"https://avatars.githubusercontent.com/u/7700995?v=3","gravatar_id":"","url":"https://api.github.com/users/emilwestergren","html_url":"https://github.com/emilwestergren","followers_url":"https://api.github.com/users/emilwestergren/followers","following_url":"https://api.github.com/users/emilwestergren/following{/other_user}","gists_url":"https://api.github.com/users/emilwestergren/gists{/gist_id}","starred_url":"https://api.github.com/users/emilwestergren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilwestergren/subscriptions","organizations_url":"https://api.github.com/users/emilwestergren/orgs","repos_url":"https://api.github.com/users/emilwestergren/repos","events_url":"https://api.github.com/users/emilwestergren/events{/privacy}","received_events_url":"https://api.github.com/users/emilwestergren/received_events","type":"User","site_admin":false},"body":"I know... I will remove the first constructor (the one with the C pointers) but I need an index operator for the FloatPoint classes to replace all this with a single loop (i.e. point[0] == point x). What do you think?","created_at":"2015-09-28T13:56:16Z","updated_at":"2015-09-28T13:56:16Z","html_url":"https://github.com/cogneco/ooc-kean/pull/445#discussion_r40554179","pull_request_url":"https://api.github.com/repos/cogneco/ooc-kean/pulls/445","_links":{"self":{"href":"https://api.github.com/repos/cogneco/ooc-kean/pulls/comments/40554179"},"html":{"href":"https://github.com/cogneco/ooc-kean/pull/445#discussion_r40554179"},"pull_request":{"href":"https://api.github.com/repos/cogneco/ooc-kean/pulls/445"}}},"pull_request":{"url":"https://api.github.com/repos/cogneco/ooc-kean/pulls/445","id":46129263,"html_url":"https://github.com/cogneco/ooc-kean/pull/445","diff_url":"https://github.com/cogneco/ooc-kean/pull/445.diff","patch_url":"https://github.com/cogneco/ooc-kean/pull/445.patch","issue_url":"https://api.github.com/repos/cogneco/ooc-kean/issues/445","number":445,"state":"open","locked":false,"title":"Added drawing of mesh","user":{"login":"emilwestergren","id":7700995,"avatar_url":"https://avatars.githubusercontent.com/u/7700995?v=3","gravatar_id":"","url":"https://api.github.com/users/emilwestergren","html_url":"https://github.com/emilwestergren","followers_url":"https://api.github.com/users/emilwestergren/followers","following_url":"https://api.github.com/users/emilwestergren/following{/other_user}","gists_url":"https://api.github.com/users/emilwestergren/gists{/gist_id}","starred_url":"https://api.github.com/users/emilwestergren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilwestergren/subscriptions","organizations_url":"https://api.github.com/users/emilwestergren/orgs","repos_url":"https://api.github.com/users/emilwestergren/repos","events_url":"https://api.github.com/users/emilwestergren/events{/privacy}","received_events_url":"https://api.github.com/users/emilwestergren/received_events","type":"User","site_admin":false},"body":"It is now possible to create a 3D mesh and draw a texture on it.","created_at":"2015-09-28T08:03:27Z","updated_at":"2015-09-28T13:56:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"62889ef1770956853f81cc8cb65d98c0751e11c3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cogneco/ooc-kean/pulls/445/commits","review_comments_url":"https://api.github.com/repos/cogneco/ooc-kean/pulls/445/comments","review_comment_url":"https://api.github.com/repos/cogneco/ooc-kean/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cogneco/ooc-kean/issues/445/comments","statuses_url":"https://api.github.com/repos/cogneco/ooc-kean/statuses/bdd8faba40e46c4afff70c715cea280c95c60b07","head":{"label":"emilwestergren:RS_opti","ref":"RS_opti","sha":"bdd8faba40e46c4afff70c715cea280c95c60b07","user":{"login":"emilwestergren","id":7700995,"avatar_url":"https://avatars.githubusercontent.com/u/7700995?v=3","gravatar_id":"","url":"https://api.github.com/users/emilwestergren","html_url":"https://github.com/emilwestergren","followers_url":"https://api.github.com/users/emilwestergren/followers","following_url":"https://api.github.com/users/emilwestergren/following{/other_user}","gists_url":"https://api.github.com/users/emilwestergren/gists{/gist_id}","starred_url":"https://api.github.com/users/emilwestergren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilwestergren/subscriptions","organizations_url":"https://api.github.com/users/emilwestergren/orgs","repos_url":"https://api.github.com/users/emilwestergren/repos","events_url":"https://api.github.com/users/emilwestergren/events{/privacy}","received_events_url":"https://api.github.com/users/emilwestergren/received_events","type":"User","site_admin":false},"repo":{"id":25524995,"name":"ooc-kean","full_name":"emilwestergren/ooc-kean","owner":{"login":"emilwestergren","id":7700995,"avatar_url":"https://avatars.githubusercontent.com/u/7700995?v=3","gravatar_id":"","url":"https://api.github.com/users/emilwestergren","html_url":"https://github.com/emilwestergren","followers_url":"https://api.github.com/users/emilwestergren/followers","following_url":"https://api.github.com/users/emilwestergren/following{/other_user}","gists_url":"https://api.github.com/users/emilwestergren/gists{/gist_id}","starred_url":"https://api.github.com/users/emilwestergren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilwestergren/subscriptions","organizations_url":"https://api.github.com/users/emilwestergren/orgs","repos_url":"https://api.github.com/users/emilwestergren/repos","events_url":"https://api.github.com/users/emilwestergren/events{/privacy}","received_events_url":"https://api.github.com/users/emilwestergren/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/emilwestergren/ooc-kean","description":"OOC port of parts of Kean.","fork":true,"url":"https://api.github.com/repos/emilwestergren/ooc-kean","forks_url":"https://api.github.com/repos/emilwestergren/ooc-kean/forks","keys_url":"https://api.github.com/repos/emilwestergren/ooc-kean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emilwestergren/ooc-kean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emilwestergren/ooc-kean/teams","hooks_url":"https://api.github.com/repos/emilwestergren/ooc-kean/hooks","issue_events_url":"https://api.github.com/repos/emilwestergren/ooc-kean/issues/events{/number}","events_url":"https://api.github.com/repos/emilwestergren/ooc-kean/events","assignees_url":"https://api.github.com/repos/emilwestergren/ooc-kean/assignees{/user}","branches_url":"https://api.github.com/repos/emilwestergren/ooc-kean/branches{/branch}","tags_url":"https://api.github.com/repos/emilwestergren/ooc-kean/tags","blobs_url":"https://api.github.com/repos/emilwestergren/ooc-kean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emilwestergren/ooc-kean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emilwestergren/ooc-kean/git/refs{/sha}","trees_url":"https://api.github.com/repos/emilwestergren/ooc-kean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emilwestergren/ooc-kean/statuses/{sha}","languages_url":"https://api.github.com/repos/emilwestergren/ooc-kean/languages","stargazers_url":"https://api.github.com/repos/emilwestergren/ooc-kean/stargazers","contributors_url":"https://api.github.com/repos/emilwestergren/ooc-kean/contributors","subscribers_url":"https://api.github.com/repos/emilwestergren/ooc-kean/subscribers","subscription_url":"https://api.github.com/repos/emilwestergren/ooc-kean/subscription","commits_url":"https://api.github.com/repos/emilwestergren/ooc-kean/commits{/sha}","git_commits_url":"https://api.github.com/repos/emilwestergren/ooc-kean/git/commits{/sha}","comments_url":"https://api.github.com/repos/emilwestergren/ooc-kean/comments{/number}","issue_comment_url":"https://api.github.com/repos/emilwestergren/ooc-kean/issues/comments{/number}","contents_url":"https://api.github.com/repos/emilwestergren/ooc-kean/contents/{+path}","compare_url":"https://api.github.com/repos/emilwestergren/ooc-kean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emilwestergren/ooc-kean/merges","archive_url":"https://api.github.com/repos/emilwestergren/ooc-kean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emilwestergren/ooc-kean/downloads","issues_url":"https://api.github.com/repos/emilwestergren/ooc-kean/issues{/number}","pulls_url":"https://api.github.com/repos/emilwestergren/ooc-kean/pulls{/number}","milestones_url":"https://api.github.com/repos/emilwestergren/ooc-kean/milestones{/number}","notifications_url":"https://api.github.com/repos/emilwestergren/ooc-kean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emilwestergren/ooc-kean/labels{/name}","releases_url":"https://api.github.com/repos/emilwestergren/ooc-kean/releases{/id}","created_at":"2014-10-21T13:51:19Z","updated_at":"2015-05-08T14:56:04Z","pushed_at":"2015-09-28T08:53:45Z","git_url":"git://github.com/emilwestergren/ooc-kean.git","ssh_url":"git@github.com:emilwestergren/ooc-kean.git","clone_url":"https://github.com/emilwestergren/ooc-kean.git","svn_url":"https://github.com/emilwestergren/ooc-kean","homepage":null,"size":13165,"stargazers_count":0,"watchers_count":0,"language":"ooc","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cogneco:master","ref":"master","sha":"96996a7adbb49115e316388e486c2fc7781ed79d","user":{"login":"cogneco","id":3601419,"avatar_url":"https://avatars.githubusercontent.com/u/3601419?v=3","gravatar_id":"","url":"https://api.github.com/users/cogneco","html_url":"https://github.com/cogneco","followers_url":"https://api.github.com/users/cogneco/followers","following_url":"https://api.github.com/users/cogneco/following{/other_user}","gists_url":"https://api.github.com/users/cogneco/gists{/gist_id}","starred_url":"https://api.github.com/users/cogneco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cogneco/subscriptions","organizations_url":"https://api.github.com/users/cogneco/orgs","repos_url":"https://api.github.com/users/cogneco/repos","events_url":"https://api.github.com/users/cogneco/events{/privacy}","received_events_url":"https://api.github.com/users/cogneco/received_events","type":"Organization","site_admin":false},"repo":{"id":25256330,"name":"ooc-kean","full_name":"cogneco/ooc-kean","owner":{"login":"cogneco","id":3601419,"avatar_url":"https://avatars.githubusercontent.com/u/3601419?v=3","gravatar_id":"","url":"https://api.github.com/users/cogneco","html_url":"https://github.com/cogneco","followers_url":"https://api.github.com/users/cogneco/followers","following_url":"https://api.github.com/users/cogneco/following{/other_user}","gists_url":"https://api.github.com/users/cogneco/gists{/gist_id}","starred_url":"https://api.github.com/users/cogneco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cogneco/subscriptions","organizations_url":"https://api.github.com/users/cogneco/orgs","repos_url":"https://api.github.com/users/cogneco/repos","events_url":"https://api.github.com/users/cogneco/events{/privacy}","received_events_url":"https://api.github.com/users/cogneco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cogneco/ooc-kean","description":"ooc port of parts of Kean.","fork":false,"url":"https://api.github.com/repos/cogneco/ooc-kean","forks_url":"https://api.github.com/repos/cogneco/ooc-kean/forks","keys_url":"https://api.github.com/repos/cogneco/ooc-kean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cogneco/ooc-kean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cogneco/ooc-kean/teams","hooks_url":"https://api.github.com/repos/cogneco/ooc-kean/hooks","issue_events_url":"https://api.github.com/repos/cogneco/ooc-kean/issues/events{/number}","events_url":"https://api.github.com/repos/cogneco/ooc-kean/events","assignees_url":"https://api.github.com/repos/cogneco/ooc-kean/assignees{/user}","branches_url":"https://api.github.com/repos/cogneco/ooc-kean/branches{/branch}","tags_url":"https://api.github.com/repos/cogneco/ooc-kean/tags","blobs_url":"https://api.github.com/repos/cogneco/ooc-kean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cogneco/ooc-kean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cogneco/ooc-kean/git/refs{/sha}","trees_url":"https://api.github.com/repos/cogneco/ooc-kean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cogneco/ooc-kean/statuses/{sha}","languages_url":"https://api.github.com/repos/cogneco/ooc-kean/languages","stargazers_url":"https://api.github.com/repos/cogneco/ooc-kean/stargazers","contributors_url":"https://api.github.com/repos/cogneco/ooc-kean/contributors","subscribers_url":"https://api.github.com/repos/cogneco/ooc-kean/subscribers","subscription_url":"https://api.github.com/repos/cogneco/ooc-kean/subscription","commits_url":"https://api.github.com/repos/cogneco/ooc-kean/commits{/sha}","git_commits_url":"https://api.github.com/repos/cogneco/ooc-kean/git/commits{/sha}","comments_url":"https://api.github.com/repos/cogneco/ooc-kean/comments{/number}","issue_comment_url":"https://api.github.com/repos/cogneco/ooc-kean/issues/comments{/number}","contents_url":"https://api.github.com/repos/cogneco/ooc-kean/contents/{+path}","compare_url":"https://api.github.com/repos/cogneco/ooc-kean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cogneco/ooc-kean/merges","archive_url":"https://api.github.com/repos/cogneco/ooc-kean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cogneco/ooc-kean/downloads","issues_url":"https://api.github.com/repos/cogneco/ooc-kean/issues{/number}","pulls_url":"https://api.github.com/repos/cogneco/ooc-kean/pulls{/number}","milestones_url":"https://api.github.com/repos/cogneco/ooc-kean/milestones{/number}","notifications_url":"https://api.github.com/repos/cogneco/ooc-kean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cogneco/ooc-kean/labels{/name}","releases_url":"https://api.github.com/repos/cogneco/ooc-kean/releases{/id}","created_at":"2014-10-15T13:42:17Z","updated_at":"2015-05-08T13:13:16Z","pushed_at":"2015-09-28T13:35:13Z","git_url":"git://github.com/cogneco/ooc-kean.git","ssh_url":"git@github.com:cogneco/ooc-kean.git","clone_url":"https://github.com/cogneco/ooc-kean.git","svn_url":"https://github.com/cogneco/ooc-kean","homepage":"","size":15413,"stargazers_count":3,"watchers_count":3,"language":"ooc","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":13,"forks":16,"open_issues":13,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cogneco/ooc-kean/pulls/445"},"html":{"href":"https://github.com/cogneco/ooc-kean/pull/445"},"issue":{"href":"https://api.github.com/repos/cogneco/ooc-kean/issues/445"},"comments":{"href":"https://api.github.com/repos/cogneco/ooc-kean/issues/445/comments"},"review_comments":{"href":"https://api.github.com/repos/cogneco/ooc-kean/pulls/445/comments"},"review_comment":{"href":"https://api.github.com/repos/cogneco/ooc-kean/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cogneco/ooc-kean/pulls/445/commits"},"statuses":{"href":"https://api.github.com/repos/cogneco/ooc-kean/statuses/bdd8faba40e46c4afff70c715cea280c95c60b07"}}}}