{"action":"created","comment":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments/29548445","id":29548445,"diff_hunk":"@@ -201,11 +203,11 @@ static BOOL autodetect_send_bandwidth_measure_stop(rdpContext* context, UINT16 p\n \t\t\t\tStream_Release(s);\n \t\t\t\treturn FALSE;\n \t\t\t}\n+\n \t\t\t/* Random data (better measurement in case the line is compressed) */\n-\t\t\tfor (i = 0; i < payloadLength / 4; i++)\n-\t\t\t{\n-\t\t\t\tStream_Write_UINT32(s, rand());\n-\t\t\t}\n+\t\t\tbuffer = malloc(payloadLength);","path":"libfreerdp/core/autodetect.c","position":54,"original_position":54,"commit_id":"df9ae5e31baf78f907229fe9393c3d0785cd7efe","original_commit_id":"df9ae5e31baf78f907229fe9393c3d0785cd7efe","user":{"login":"akallabeth","id":3472254,"avatar_url":"https://avatars.githubusercontent.com/u/3472254?v=3","gravatar_id":"","url":"https://api.github.com/users/akallabeth","html_url":"https://github.com/akallabeth","followers_url":"https://api.github.com/users/akallabeth/followers","following_url":"https://api.github.com/users/akallabeth/following{/other_user}","gists_url":"https://api.github.com/users/akallabeth/gists{/gist_id}","starred_url":"https://api.github.com/users/akallabeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akallabeth/subscriptions","organizations_url":"https://api.github.com/users/akallabeth/orgs","repos_url":"https://api.github.com/users/akallabeth/repos","events_url":"https://api.github.com/users/akallabeth/events{/privacy}","received_events_url":"https://api.github.com/users/akallabeth/received_events","type":"User","site_admin":false},"body":"unchecked malloc","created_at":"2015-05-02T15:57:39Z","updated_at":"2015-05-02T15:57:39Z","html_url":"https://github.com/FreeRDP/FreeRDP/pull/2583#discussion_r29548445","pull_request_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2583","_links":{"self":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments/29548445"},"html":{"href":"https://github.com/FreeRDP/FreeRDP/pull/2583#discussion_r29548445"},"pull_request":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2583"}}},"pull_request":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2583","id":34290112,"html_url":"https://github.com/FreeRDP/FreeRDP/pull/2583","diff_url":"https://github.com/FreeRDP/FreeRDP/pull/2583.diff","patch_url":"https://github.com/FreeRDP/FreeRDP/pull/2583.patch","issue_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/2583","number":2583,"state":"open","locked":false,"title":"Two minor source code changes to remove warnings","user":{"login":"bceverly","id":154481,"avatar_url":"https://avatars.githubusercontent.com/u/154481?v=3","gravatar_id":"","url":"https://api.github.com/users/bceverly","html_url":"https://github.com/bceverly","followers_url":"https://api.github.com/users/bceverly/followers","following_url":"https://api.github.com/users/bceverly/following{/other_user}","gists_url":"https://api.github.com/users/bceverly/gists{/gist_id}","starred_url":"https://api.github.com/users/bceverly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bceverly/subscriptions","organizations_url":"https://api.github.com/users/bceverly/orgs","repos_url":"https://api.github.com/users/bceverly/repos","events_url":"https://api.github.com/users/bceverly/events{/privacy}","received_events_url":"https://api.github.com/users/bceverly/received_events","type":"User","site_admin":false},"body":"Fixed linker warning about insecure crypto and fixed compiler warning about unsigned being compared to less than zero.\r\n\r\nBoth of these are probably safe to have hit all builds if someone wants to do a little testing and remove the #ifdef's.  I didn't want to make that assumption for everyone else however so I played it safe.","created_at":"2015-04-28T17:19:49Z","updated_at":"2015-05-02T15:57:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23d22b15ad7510211a5717d8056d99547618d8d3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2583/commits","review_comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2583/comments","review_comment_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/2583/comments","statuses_url":"https://api.github.com/repos/FreeRDP/FreeRDP/statuses/df9ae5e31baf78f907229fe9393c3d0785cd7efe","head":{"label":"bceverly:OpenBSD-cleanup","ref":"OpenBSD-cleanup","sha":"df9ae5e31baf78f907229fe9393c3d0785cd7efe","user":{"login":"bceverly","id":154481,"avatar_url":"https://avatars.githubusercontent.com/u/154481?v=3","gravatar_id":"","url":"https://api.github.com/users/bceverly","html_url":"https://github.com/bceverly","followers_url":"https://api.github.com/users/bceverly/followers","following_url":"https://api.github.com/users/bceverly/following{/other_user}","gists_url":"https://api.github.com/users/bceverly/gists{/gist_id}","starred_url":"https://api.github.com/users/bceverly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bceverly/subscriptions","organizations_url":"https://api.github.com/users/bceverly/orgs","repos_url":"https://api.github.com/users/bceverly/repos","events_url":"https://api.github.com/users/bceverly/events{/privacy}","received_events_url":"https://api.github.com/users/bceverly/received_events","type":"User","site_admin":false},"repo":{"id":34344546,"name":"FreeRDP","full_name":"bceverly/FreeRDP","owner":{"login":"bceverly","id":154481,"avatar_url":"https://avatars.githubusercontent.com/u/154481?v=3","gravatar_id":"","url":"https://api.github.com/users/bceverly","html_url":"https://github.com/bceverly","followers_url":"https://api.github.com/users/bceverly/followers","following_url":"https://api.github.com/users/bceverly/following{/other_user}","gists_url":"https://api.github.com/users/bceverly/gists{/gist_id}","starred_url":"https://api.github.com/users/bceverly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bceverly/subscriptions","organizations_url":"https://api.github.com/users/bceverly/orgs","repos_url":"https://api.github.com/users/bceverly/repos","events_url":"https://api.github.com/users/bceverly/events{/privacy}","received_events_url":"https://api.github.com/users/bceverly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bceverly/FreeRDP","description":"FreeRDP is a free remote desktop protocol client","fork":true,"url":"https://api.github.com/repos/bceverly/FreeRDP","forks_url":"https://api.github.com/repos/bceverly/FreeRDP/forks","keys_url":"https://api.github.com/repos/bceverly/FreeRDP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bceverly/FreeRDP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bceverly/FreeRDP/teams","hooks_url":"https://api.github.com/repos/bceverly/FreeRDP/hooks","issue_events_url":"https://api.github.com/repos/bceverly/FreeRDP/issues/events{/number}","events_url":"https://api.github.com/repos/bceverly/FreeRDP/events","assignees_url":"https://api.github.com/repos/bceverly/FreeRDP/assignees{/user}","branches_url":"https://api.github.com/repos/bceverly/FreeRDP/branches{/branch}","tags_url":"https://api.github.com/repos/bceverly/FreeRDP/tags","blobs_url":"https://api.github.com/repos/bceverly/FreeRDP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bceverly/FreeRDP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bceverly/FreeRDP/git/refs{/sha}","trees_url":"https://api.github.com/repos/bceverly/FreeRDP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bceverly/FreeRDP/statuses/{sha}","languages_url":"https://api.github.com/repos/bceverly/FreeRDP/languages","stargazers_url":"https://api.github.com/repos/bceverly/FreeRDP/stargazers","contributors_url":"https://api.github.com/repos/bceverly/FreeRDP/contributors","subscribers_url":"https://api.github.com/repos/bceverly/FreeRDP/subscribers","subscription_url":"https://api.github.com/repos/bceverly/FreeRDP/subscription","commits_url":"https://api.github.com/repos/bceverly/FreeRDP/commits{/sha}","git_commits_url":"https://api.github.com/repos/bceverly/FreeRDP/git/commits{/sha}","comments_url":"https://api.github.com/repos/bceverly/FreeRDP/comments{/number}","issue_comment_url":"https://api.github.com/repos/bceverly/FreeRDP/issues/comments{/number}","contents_url":"https://api.github.com/repos/bceverly/FreeRDP/contents/{+path}","compare_url":"https://api.github.com/repos/bceverly/FreeRDP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bceverly/FreeRDP/merges","archive_url":"https://api.github.com/repos/bceverly/FreeRDP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bceverly/FreeRDP/downloads","issues_url":"https://api.github.com/repos/bceverly/FreeRDP/issues{/number}","pulls_url":"https://api.github.com/repos/bceverly/FreeRDP/pulls{/number}","milestones_url":"https://api.github.com/repos/bceverly/FreeRDP/milestones{/number}","notifications_url":"https://api.github.com/repos/bceverly/FreeRDP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bceverly/FreeRDP/labels{/name}","releases_url":"https://api.github.com/repos/bceverly/FreeRDP/releases{/id}","created_at":"2015-04-21T18:23:30Z","updated_at":"2015-04-30T11:31:55Z","pushed_at":"2015-04-30T14:12:59Z","git_url":"git://github.com/bceverly/FreeRDP.git","ssh_url":"git@github.com:bceverly/FreeRDP.git","clone_url":"https://github.com/bceverly/FreeRDP.git","svn_url":"https://github.com/bceverly/FreeRDP","homepage":"http://www.freerdp.com/","size":28442,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FreeRDP:master","ref":"master","sha":"bfccc06ab2099b0e6a4a7fd6a9e113fb43842c87","user":{"login":"FreeRDP","id":663376,"avatar_url":"https://avatars.githubusercontent.com/u/663376?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeRDP","html_url":"https://github.com/FreeRDP","followers_url":"https://api.github.com/users/FreeRDP/followers","following_url":"https://api.github.com/users/FreeRDP/following{/other_user}","gists_url":"https://api.github.com/users/FreeRDP/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeRDP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeRDP/subscriptions","organizations_url":"https://api.github.com/users/FreeRDP/orgs","repos_url":"https://api.github.com/users/FreeRDP/repos","events_url":"https://api.github.com/users/FreeRDP/events{/privacy}","received_events_url":"https://api.github.com/users/FreeRDP/received_events","type":"Organization","site_admin":false},"repo":{"id":1979797,"name":"FreeRDP","full_name":"FreeRDP/FreeRDP","owner":{"login":"FreeRDP","id":663376,"avatar_url":"https://avatars.githubusercontent.com/u/663376?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeRDP","html_url":"https://github.com/FreeRDP","followers_url":"https://api.github.com/users/FreeRDP/followers","following_url":"https://api.github.com/users/FreeRDP/following{/other_user}","gists_url":"https://api.github.com/users/FreeRDP/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeRDP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeRDP/subscriptions","organizations_url":"https://api.github.com/users/FreeRDP/orgs","repos_url":"https://api.github.com/users/FreeRDP/repos","events_url":"https://api.github.com/users/FreeRDP/events{/privacy}","received_events_url":"https://api.github.com/users/FreeRDP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FreeRDP/FreeRDP","description":"FreeRDP is a free remote desktop protocol client","fork":false,"url":"https://api.github.com/repos/FreeRDP/FreeRDP","forks_url":"https://api.github.com/repos/FreeRDP/FreeRDP/forks","keys_url":"https://api.github.com/repos/FreeRDP/FreeRDP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FreeRDP/FreeRDP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FreeRDP/FreeRDP/teams","hooks_url":"https://api.github.com/repos/FreeRDP/FreeRDP/hooks","issue_events_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/events{/number}","events_url":"https://api.github.com/repos/FreeRDP/FreeRDP/events","assignees_url":"https://api.github.com/repos/FreeRDP/FreeRDP/assignees{/user}","branches_url":"https://api.github.com/repos/FreeRDP/FreeRDP/branches{/branch}","tags_url":"https://api.github.com/repos/FreeRDP/FreeRDP/tags","blobs_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/refs{/sha}","trees_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FreeRDP/FreeRDP/statuses/{sha}","languages_url":"https://api.github.com/repos/FreeRDP/FreeRDP/languages","stargazers_url":"https://api.github.com/repos/FreeRDP/FreeRDP/stargazers","contributors_url":"https://api.github.com/repos/FreeRDP/FreeRDP/contributors","subscribers_url":"https://api.github.com/repos/FreeRDP/FreeRDP/subscribers","subscription_url":"https://api.github.com/repos/FreeRDP/FreeRDP/subscription","commits_url":"https://api.github.com/repos/FreeRDP/FreeRDP/commits{/sha}","git_commits_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/commits{/sha}","comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/comments{/number}","issue_comment_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/comments{/number}","contents_url":"https://api.github.com/repos/FreeRDP/FreeRDP/contents/{+path}","compare_url":"https://api.github.com/repos/FreeRDP/FreeRDP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FreeRDP/FreeRDP/merges","archive_url":"https://api.github.com/repos/FreeRDP/FreeRDP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FreeRDP/FreeRDP/downloads","issues_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues{/number}","pulls_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls{/number}","milestones_url":"https://api.github.com/repos/FreeRDP/FreeRDP/milestones{/number}","notifications_url":"https://api.github.com/repos/FreeRDP/FreeRDP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FreeRDP/FreeRDP/labels{/name}","releases_url":"https://api.github.com/repos/FreeRDP/FreeRDP/releases{/id}","created_at":"2011-06-30T19:14:15Z","updated_at":"2015-05-01T18:30:26Z","pushed_at":"2015-05-02T03:39:09Z","git_url":"git://github.com/FreeRDP/FreeRDP.git","ssh_url":"git@github.com:FreeRDP/FreeRDP.git","clone_url":"https://github.com/FreeRDP/FreeRDP.git","svn_url":"https://github.com/FreeRDP/FreeRDP","homepage":"http://www.freerdp.com/","size":120199,"stargazers_count":940,"watchers_count":940,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":606,"mirror_url":null,"open_issues_count":558,"forks":606,"open_issues":558,"watchers":940,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2583"},"html":{"href":"https://github.com/FreeRDP/FreeRDP/pull/2583"},"issue":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/2583"},"comments":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/2583/comments"},"review_comments":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2583/comments"},"review_comment":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2583/commits"},"statuses":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/statuses/df9ae5e31baf78f907229fe9393c3d0785cd7efe"}}}}