{"action":"created","comment":{"url":"https://api.github.com/repos/docker/distribution/pulls/comments/46326189","id":46326189,"diff_hunk":"@@ -75,6 +75,17 @@ type BlobDeleter interface {\n \tDelete(ctx context.Context, dgst digest.Digest) error\n }\n \n+// BlobEnumerator allows to list blobs in storage.\n+type BlobEnumerator interface {\n+\t// Enumerate fills 'digests' with a lexicographically sorted list of\n+\t// digests up to the size of 'digests' and returns the value 'n' for the\n+\t// number of entries which were filled. 'last' contains an offset in the\n+\t// list. It's a string representation of digest. Empty string means 0\n+\t// offset. 'err' will be set to io.OEF if there are no more entries to\n+\t// obtain.\n+\tEnumerate(ctx context.Context, digests []digest.Digest, last string) (n int, err error)","path":"blobs.go","position":12,"original_position":12,"commit_id":"3bebfa29dae0328d34d1f7d8e554bbc1b1148099","original_commit_id":"3bebfa29dae0328d34d1f7d8e554bbc1b1148099","user":{"login":"stevvooe","id":120601,"avatar_url":"https://avatars.githubusercontent.com/u/120601?v=3","gravatar_id":"","url":"https://api.github.com/users/stevvooe","html_url":"https://github.com/stevvooe","followers_url":"https://api.github.com/users/stevvooe/followers","following_url":"https://api.github.com/users/stevvooe/following{/other_user}","gists_url":"https://api.github.com/users/stevvooe/gists{/gist_id}","starred_url":"https://api.github.com/users/stevvooe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevvooe/subscriptions","organizations_url":"https://api.github.com/users/stevvooe/orgs","repos_url":"https://api.github.com/users/stevvooe/repos","events_url":"https://api.github.com/users/stevvooe/events{/privacy}","received_events_url":"https://api.github.com/users/stevvooe/received_events","type":"User","site_admin":false},"body":"After some discussion, we decided that a lexicographical ordering makes no sense for blobs. Would it be a huge change to make this work with a callback?\r\n\r\nI'm sorry to flip flop on this one. I think I had suggested that this follow the semantics of tags and repository enumeration. In those cases, lexicographic paginations has a lot of benefits, semantically and storage-wise.","created_at":"2015-12-01T19:31:31Z","updated_at":"2015-12-01T19:31:31Z","html_url":"https://github.com/docker/distribution/pull/1050#discussion_r46326189","pull_request_url":"https://api.github.com/repos/docker/distribution/pulls/1050","_links":{"self":{"href":"https://api.github.com/repos/docker/distribution/pulls/comments/46326189"},"html":{"href":"https://github.com/docker/distribution/pull/1050#discussion_r46326189"},"pull_request":{"href":"https://api.github.com/repos/docker/distribution/pulls/1050"}}},"pull_request":{"url":"https://api.github.com/repos/docker/distribution/pulls/1050","id":46508883,"html_url":"https://github.com/docker/distribution/pull/1050","diff_url":"https://github.com/docker/distribution/pull/1050.diff","patch_url":"https://github.com/docker/distribution/pull/1050.patch","issue_url":"https://api.github.com/repos/docker/distribution/issues/1050","number":1050,"state":"open","locked":false,"title":"Exported storage API functions needed for pruning","user":{"login":"miminar","id":1478803,"avatar_url":"https://avatars.githubusercontent.com/u/1478803?v=3","gravatar_id":"","url":"https://api.github.com/users/miminar","html_url":"https://github.com/miminar","followers_url":"https://api.github.com/users/miminar/followers","following_url":"https://api.github.com/users/miminar/following{/other_user}","gists_url":"https://api.github.com/users/miminar/gists{/gist_id}","starred_url":"https://api.github.com/users/miminar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miminar/subscriptions","organizations_url":"https://api.github.com/users/miminar/orgs","repos_url":"https://api.github.com/users/miminar/repos","events_url":"https://api.github.com/users/miminar/events{/privacy}","received_events_url":"https://api.github.com/users/miminar/received_events","type":"User","site_admin":false},"body":"Extended following interfaces for `Enumerate` method:\r\n\r\n- `ManifestService`\r\n- `SignatureService`\r\n\r\nExtended `SignatureService` for `Delete` method.\r\n\r\nAdded new interface:\r\n\r\n- `BlobEnumerator`\r\n\r\nNew registry option:\r\n\r\n- `RemoveParentOnDelete` causes parent directory of blob's data or link\r\n  to be deleted together as well during `Delete`. This speeds up lookups\r\n  and enumeration and retrieves back storage inodes.\r\n\r\nPartially resolves #462\r\nIt's a stripped down version of #1032.","created_at":"2015-10-01T10:47:12Z","updated_at":"2015-12-01T19:31:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96710c12923f23d704a3e10195b5798ed7bb6b5e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/distribution/pulls/1050/commits","review_comments_url":"https://api.github.com/repos/docker/distribution/pulls/1050/comments","review_comment_url":"https://api.github.com/repos/docker/distribution/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/distribution/issues/1050/comments","statuses_url":"https://api.github.com/repos/docker/distribution/statuses/3bebfa29dae0328d34d1f7d8e554bbc1b1148099","head":{"label":"miminar:prune-api-exposed","ref":"prune-api-exposed","sha":"3bebfa29dae0328d34d1f7d8e554bbc1b1148099","user":{"login":"miminar","id":1478803,"avatar_url":"https://avatars.githubusercontent.com/u/1478803?v=3","gravatar_id":"","url":"https://api.github.com/users/miminar","html_url":"https://github.com/miminar","followers_url":"https://api.github.com/users/miminar/followers","following_url":"https://api.github.com/users/miminar/following{/other_user}","gists_url":"https://api.github.com/users/miminar/gists{/gist_id}","starred_url":"https://api.github.com/users/miminar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miminar/subscriptions","organizations_url":"https://api.github.com/users/miminar/orgs","repos_url":"https://api.github.com/users/miminar/repos","events_url":"https://api.github.com/users/miminar/events{/privacy}","received_events_url":"https://api.github.com/users/miminar/received_events","type":"User","site_admin":false},"repo":{"id":35223192,"name":"distribution","full_name":"miminar/distribution","owner":{"login":"miminar","id":1478803,"avatar_url":"https://avatars.githubusercontent.com/u/1478803?v=3","gravatar_id":"","url":"https://api.github.com/users/miminar","html_url":"https://github.com/miminar","followers_url":"https://api.github.com/users/miminar/followers","following_url":"https://api.github.com/users/miminar/following{/other_user}","gists_url":"https://api.github.com/users/miminar/gists{/gist_id}","starred_url":"https://api.github.com/users/miminar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miminar/subscriptions","organizations_url":"https://api.github.com/users/miminar/orgs","repos_url":"https://api.github.com/users/miminar/repos","events_url":"https://api.github.com/users/miminar/events{/privacy}","received_events_url":"https://api.github.com/users/miminar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miminar/distribution","description":"The Docker toolset to pack, ship, store, and deliver content","fork":true,"url":"https://api.github.com/repos/miminar/distribution","forks_url":"https://api.github.com/repos/miminar/distribution/forks","keys_url":"https://api.github.com/repos/miminar/distribution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miminar/distribution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miminar/distribution/teams","hooks_url":"https://api.github.com/repos/miminar/distribution/hooks","issue_events_url":"https://api.github.com/repos/miminar/distribution/issues/events{/number}","events_url":"https://api.github.com/repos/miminar/distribution/events","assignees_url":"https://api.github.com/repos/miminar/distribution/assignees{/user}","branches_url":"https://api.github.com/repos/miminar/distribution/branches{/branch}","tags_url":"https://api.github.com/repos/miminar/distribution/tags","blobs_url":"https://api.github.com/repos/miminar/distribution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miminar/distribution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miminar/distribution/git/refs{/sha}","trees_url":"https://api.github.com/repos/miminar/distribution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miminar/distribution/statuses/{sha}","languages_url":"https://api.github.com/repos/miminar/distribution/languages","stargazers_url":"https://api.github.com/repos/miminar/distribution/stargazers","contributors_url":"https://api.github.com/repos/miminar/distribution/contributors","subscribers_url":"https://api.github.com/repos/miminar/distribution/subscribers","subscription_url":"https://api.github.com/repos/miminar/distribution/subscription","commits_url":"https://api.github.com/repos/miminar/distribution/commits{/sha}","git_commits_url":"https://api.github.com/repos/miminar/distribution/git/commits{/sha}","comments_url":"https://api.github.com/repos/miminar/distribution/comments{/number}","issue_comment_url":"https://api.github.com/repos/miminar/distribution/issues/comments{/number}","contents_url":"https://api.github.com/repos/miminar/distribution/contents/{+path}","compare_url":"https://api.github.com/repos/miminar/distribution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miminar/distribution/merges","archive_url":"https://api.github.com/repos/miminar/distribution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miminar/distribution/downloads","issues_url":"https://api.github.com/repos/miminar/distribution/issues{/number}","pulls_url":"https://api.github.com/repos/miminar/distribution/pulls{/number}","milestones_url":"https://api.github.com/repos/miminar/distribution/milestones{/number}","notifications_url":"https://api.github.com/repos/miminar/distribution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miminar/distribution/labels{/name}","releases_url":"https://api.github.com/repos/miminar/distribution/releases{/id}","created_at":"2015-05-07T13:58:10Z","updated_at":"2015-05-07T13:58:10Z","pushed_at":"2015-12-01T17:13:36Z","git_url":"git://github.com/miminar/distribution.git","ssh_url":"git@github.com:miminar/distribution.git","clone_url":"https://github.com/miminar/distribution.git","svn_url":"https://github.com/miminar/distribution","homepage":null,"size":7536,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"1c5f8166e4ea5e97251a9d539acbd52f40955756","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":28366058,"name":"distribution","full_name":"docker/distribution","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/distribution","description":"The Docker toolset to pack, ship, store, and deliver content","fork":false,"url":"https://api.github.com/repos/docker/distribution","forks_url":"https://api.github.com/repos/docker/distribution/forks","keys_url":"https://api.github.com/repos/docker/distribution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/distribution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/distribution/teams","hooks_url":"https://api.github.com/repos/docker/distribution/hooks","issue_events_url":"https://api.github.com/repos/docker/distribution/issues/events{/number}","events_url":"https://api.github.com/repos/docker/distribution/events","assignees_url":"https://api.github.com/repos/docker/distribution/assignees{/user}","branches_url":"https://api.github.com/repos/docker/distribution/branches{/branch}","tags_url":"https://api.github.com/repos/docker/distribution/tags","blobs_url":"https://api.github.com/repos/docker/distribution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/distribution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/distribution/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/distribution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/distribution/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/distribution/languages","stargazers_url":"https://api.github.com/repos/docker/distribution/stargazers","contributors_url":"https://api.github.com/repos/docker/distribution/contributors","subscribers_url":"https://api.github.com/repos/docker/distribution/subscribers","subscription_url":"https://api.github.com/repos/docker/distribution/subscription","commits_url":"https://api.github.com/repos/docker/distribution/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/distribution/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/distribution/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/distribution/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/distribution/contents/{+path}","compare_url":"https://api.github.com/repos/docker/distribution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/distribution/merges","archive_url":"https://api.github.com/repos/docker/distribution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/distribution/downloads","issues_url":"https://api.github.com/repos/docker/distribution/issues{/number}","pulls_url":"https://api.github.com/repos/docker/distribution/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/distribution/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/distribution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/distribution/labels{/name}","releases_url":"https://api.github.com/repos/docker/distribution/releases{/id}","created_at":"2014-12-22T23:49:26Z","updated_at":"2015-12-01T07:58:56Z","pushed_at":"2015-12-01T17:57:46Z","git_url":"git://github.com/docker/distribution.git","ssh_url":"git@github.com:docker/distribution.git","clone_url":"https://github.com/docker/distribution.git","svn_url":"https://github.com/docker/distribution","homepage":null,"size":10237,"stargazers_count":1400,"watchers_count":1400,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":514,"mirror_url":null,"open_issues_count":170,"forks":514,"open_issues":170,"watchers":1400,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/distribution/pulls/1050"},"html":{"href":"https://github.com/docker/distribution/pull/1050"},"issue":{"href":"https://api.github.com/repos/docker/distribution/issues/1050"},"comments":{"href":"https://api.github.com/repos/docker/distribution/issues/1050/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/distribution/pulls/1050/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/distribution/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/distribution/pulls/1050/commits"},"statuses":{"href":"https://api.github.com/repos/docker/distribution/statuses/3bebfa29dae0328d34d1f7d8e554bbc1b1148099"}}}}