{"action":"created","comment":{"url":"https://api.github.com/repos/atom/vim-mode/pulls/comments/26420402","id":26420402,"diff_hunk":"@@ -14,9 +19,10 @@ class StatusBarManager\n \n   initialize: (@statusBar) ->\n \n-  update: (currentMode) ->\n+  update: (currentMode, currentSubmode) ->\n+    currentFullMode = currentMode + \"$\" + currentSubmode if currentSubmode?","path":"lib/status-bar-manager.coffee","position":null,"original_position":24,"commit_id":"91069db61fd16d6f7c6a03880cceea0fc8eeb235","original_commit_id":"4423c646becbb48888165ea77bb1a87622fb9445","user":{"login":"jacekkopecky","id":807315,"avatar_url":"https://avatars.githubusercontent.com/u/807315?v=3","gravatar_id":"","url":"https://api.github.com/users/jacekkopecky","html_url":"https://github.com/jacekkopecky","followers_url":"https://api.github.com/users/jacekkopecky/followers","following_url":"https://api.github.com/users/jacekkopecky/following{/other_user}","gists_url":"https://api.github.com/users/jacekkopecky/gists{/gist_id}","starred_url":"https://api.github.com/users/jacekkopecky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacekkopecky/subscriptions","organizations_url":"https://api.github.com/users/jacekkopecky/orgs","repos_url":"https://api.github.com/users/jacekkopecky/repos","events_url":"https://api.github.com/users/jacekkopecky/events{/privacy}","received_events_url":"https://api.github.com/users/jacekkopecky/received_events","type":"User","site_admin":false},"body":"Thank you.\r\nI've committed a fix in 91069db61fd16d6f7c6a03880cceea0fc8eeb235 so the code doesn't rely on order, keeping the ability to match only on the `mode`. If we don't keep `currentFullMode` we'd have to enumerate all submodes in ContentsByMode.\r\nWhich alternative would you prefer?","created_at":"2015-03-13T20:31:17Z","updated_at":"2015-03-13T20:31:17Z","html_url":"https://github.com/atom/vim-mode/pull/574#discussion_r26420402","pull_request_url":"https://api.github.com/repos/atom/vim-mode/pulls/574","_links":{"self":{"href":"https://api.github.com/repos/atom/vim-mode/pulls/comments/26420402"},"html":{"href":"https://github.com/atom/vim-mode/pull/574#discussion_r26420402"},"pull_request":{"href":"https://api.github.com/repos/atom/vim-mode/pulls/574"}}},"pull_request":{"url":"https://api.github.com/repos/atom/vim-mode/pulls/574","id":30998397,"html_url":"https://github.com/atom/vim-mode/pull/574","diff_url":"https://github.com/atom/vim-mode/pull/574.diff","patch_url":"https://github.com/atom/vim-mode/pull/574.patch","issue_url":"https://api.github.com/repos/atom/vim-mode/issues/574","number":574,"state":"open","locked":false,"title":":feature: show submode in status bar","user":{"login":"jacekkopecky","id":807315,"avatar_url":"https://avatars.githubusercontent.com/u/807315?v=3","gravatar_id":"","url":"https://api.github.com/users/jacekkopecky","html_url":"https://github.com/jacekkopecky","followers_url":"https://api.github.com/users/jacekkopecky/followers","following_url":"https://api.github.com/users/jacekkopecky/following{/other_user}","gists_url":"https://api.github.com/users/jacekkopecky/gists{/gist_id}","starred_url":"https://api.github.com/users/jacekkopecky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacekkopecky/subscriptions","organizations_url":"https://api.github.com/users/jacekkopecky/orgs","repos_url":"https://api.github.com/users/jacekkopecky/repos","events_url":"https://api.github.com/users/jacekkopecky/events{/privacy}","received_events_url":"https://api.github.com/users/jacekkopecky/received_events","type":"User","site_admin":false},"body":"This is a suggestion that we may want to show the submode in the status bar; the PR already includes values for replace mode, proposed in #573. ","created_at":"2015-03-12T00:18:27Z","updated_at":"2015-03-13T20:31:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5cc8e045f644f6c6b05fc5bef7295b648a8b6f92","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/atom/vim-mode/pulls/574/commits","review_comments_url":"https://api.github.com/repos/atom/vim-mode/pulls/574/comments","review_comment_url":"https://api.github.com/repos/atom/vim-mode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atom/vim-mode/issues/574/comments","statuses_url":"https://api.github.com/repos/atom/vim-mode/statuses/91069db61fd16d6f7c6a03880cceea0fc8eeb235","head":{"label":"jacekkopecky:status-bar-with-submode","ref":"status-bar-with-submode","sha":"91069db61fd16d6f7c6a03880cceea0fc8eeb235","user":{"login":"jacekkopecky","id":807315,"avatar_url":"https://avatars.githubusercontent.com/u/807315?v=3","gravatar_id":"","url":"https://api.github.com/users/jacekkopecky","html_url":"https://github.com/jacekkopecky","followers_url":"https://api.github.com/users/jacekkopecky/followers","following_url":"https://api.github.com/users/jacekkopecky/following{/other_user}","gists_url":"https://api.github.com/users/jacekkopecky/gists{/gist_id}","starred_url":"https://api.github.com/users/jacekkopecky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacekkopecky/subscriptions","organizations_url":"https://api.github.com/users/jacekkopecky/orgs","repos_url":"https://api.github.com/users/jacekkopecky/repos","events_url":"https://api.github.com/users/jacekkopecky/events{/privacy}","received_events_url":"https://api.github.com/users/jacekkopecky/received_events","type":"User","site_admin":false},"repo":{"id":30833935,"name":"vim-mode","full_name":"jacekkopecky/vim-mode","owner":{"login":"jacekkopecky","id":807315,"avatar_url":"https://avatars.githubusercontent.com/u/807315?v=3","gravatar_id":"","url":"https://api.github.com/users/jacekkopecky","html_url":"https://github.com/jacekkopecky","followers_url":"https://api.github.com/users/jacekkopecky/followers","following_url":"https://api.github.com/users/jacekkopecky/following{/other_user}","gists_url":"https://api.github.com/users/jacekkopecky/gists{/gist_id}","starred_url":"https://api.github.com/users/jacekkopecky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacekkopecky/subscriptions","organizations_url":"https://api.github.com/users/jacekkopecky/orgs","repos_url":"https://api.github.com/users/jacekkopecky/repos","events_url":"https://api.github.com/users/jacekkopecky/events{/privacy}","received_events_url":"https://api.github.com/users/jacekkopecky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jacekkopecky/vim-mode","description":"Next generation vim support for atom","fork":true,"url":"https://api.github.com/repos/jacekkopecky/vim-mode","forks_url":"https://api.github.com/repos/jacekkopecky/vim-mode/forks","keys_url":"https://api.github.com/repos/jacekkopecky/vim-mode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jacekkopecky/vim-mode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jacekkopecky/vim-mode/teams","hooks_url":"https://api.github.com/repos/jacekkopecky/vim-mode/hooks","issue_events_url":"https://api.github.com/repos/jacekkopecky/vim-mode/issues/events{/number}","events_url":"https://api.github.com/repos/jacekkopecky/vim-mode/events","assignees_url":"https://api.github.com/repos/jacekkopecky/vim-mode/assignees{/user}","branches_url":"https://api.github.com/repos/jacekkopecky/vim-mode/branches{/branch}","tags_url":"https://api.github.com/repos/jacekkopecky/vim-mode/tags","blobs_url":"https://api.github.com/repos/jacekkopecky/vim-mode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jacekkopecky/vim-mode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jacekkopecky/vim-mode/git/refs{/sha}","trees_url":"https://api.github.com/repos/jacekkopecky/vim-mode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jacekkopecky/vim-mode/statuses/{sha}","languages_url":"https://api.github.com/repos/jacekkopecky/vim-mode/languages","stargazers_url":"https://api.github.com/repos/jacekkopecky/vim-mode/stargazers","contributors_url":"https://api.github.com/repos/jacekkopecky/vim-mode/contributors","subscribers_url":"https://api.github.com/repos/jacekkopecky/vim-mode/subscribers","subscription_url":"https://api.github.com/repos/jacekkopecky/vim-mode/subscription","commits_url":"https://api.github.com/repos/jacekkopecky/vim-mode/commits{/sha}","git_commits_url":"https://api.github.com/repos/jacekkopecky/vim-mode/git/commits{/sha}","comments_url":"https://api.github.com/repos/jacekkopecky/vim-mode/comments{/number}","issue_comment_url":"https://api.github.com/repos/jacekkopecky/vim-mode/issues/comments{/number}","contents_url":"https://api.github.com/repos/jacekkopecky/vim-mode/contents/{+path}","compare_url":"https://api.github.com/repos/jacekkopecky/vim-mode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jacekkopecky/vim-mode/merges","archive_url":"https://api.github.com/repos/jacekkopecky/vim-mode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jacekkopecky/vim-mode/downloads","issues_url":"https://api.github.com/repos/jacekkopecky/vim-mode/issues{/number}","pulls_url":"https://api.github.com/repos/jacekkopecky/vim-mode/pulls{/number}","milestones_url":"https://api.github.com/repos/jacekkopecky/vim-mode/milestones{/number}","notifications_url":"https://api.github.com/repos/jacekkopecky/vim-mode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jacekkopecky/vim-mode/labels{/name}","releases_url":"https://api.github.com/repos/jacekkopecky/vim-mode/releases{/id}","created_at":"2015-02-15T16:53:14Z","updated_at":"2015-03-13T15:38:11Z","pushed_at":"2015-03-13T20:23:05Z","git_url":"git://github.com/jacekkopecky/vim-mode.git","ssh_url":"git@github.com:jacekkopecky/vim-mode.git","clone_url":"https://github.com/jacekkopecky/vim-mode.git","svn_url":"https://github.com/jacekkopecky/vim-mode","homepage":null,"size":1334,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"991a16c1066aac99b060d7af7762cc9613377c3f","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":11827104,"name":"vim-mode","full_name":"atom/vim-mode","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/vim-mode","description":"Next generation vim support for atom","fork":false,"url":"https://api.github.com/repos/atom/vim-mode","forks_url":"https://api.github.com/repos/atom/vim-mode/forks","keys_url":"https://api.github.com/repos/atom/vim-mode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/vim-mode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/vim-mode/teams","hooks_url":"https://api.github.com/repos/atom/vim-mode/hooks","issue_events_url":"https://api.github.com/repos/atom/vim-mode/issues/events{/number}","events_url":"https://api.github.com/repos/atom/vim-mode/events","assignees_url":"https://api.github.com/repos/atom/vim-mode/assignees{/user}","branches_url":"https://api.github.com/repos/atom/vim-mode/branches{/branch}","tags_url":"https://api.github.com/repos/atom/vim-mode/tags","blobs_url":"https://api.github.com/repos/atom/vim-mode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/vim-mode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/vim-mode/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/vim-mode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/vim-mode/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/vim-mode/languages","stargazers_url":"https://api.github.com/repos/atom/vim-mode/stargazers","contributors_url":"https://api.github.com/repos/atom/vim-mode/contributors","subscribers_url":"https://api.github.com/repos/atom/vim-mode/subscribers","subscription_url":"https://api.github.com/repos/atom/vim-mode/subscription","commits_url":"https://api.github.com/repos/atom/vim-mode/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/vim-mode/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/vim-mode/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/vim-mode/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/vim-mode/contents/{+path}","compare_url":"https://api.github.com/repos/atom/vim-mode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/vim-mode/merges","archive_url":"https://api.github.com/repos/atom/vim-mode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/vim-mode/downloads","issues_url":"https://api.github.com/repos/atom/vim-mode/issues{/number}","pulls_url":"https://api.github.com/repos/atom/vim-mode/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/vim-mode/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/vim-mode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/vim-mode/labels{/name}","releases_url":"https://api.github.com/repos/atom/vim-mode/releases{/id}","created_at":"2013-08-01T20:37:14Z","updated_at":"2015-03-13T19:10:38Z","pushed_at":"2015-03-13T19:10:38Z","git_url":"git://github.com/atom/vim-mode.git","ssh_url":"git@github.com:atom/vim-mode.git","clone_url":"https://github.com/atom/vim-mode.git","svn_url":"https://github.com/atom/vim-mode","homepage":null,"size":4367,"stargazers_count":843,"watchers_count":843,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":187,"mirror_url":null,"open_issues_count":132,"forks":187,"open_issues":132,"watchers":843,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/vim-mode/pulls/574"},"html":{"href":"https://github.com/atom/vim-mode/pull/574"},"issue":{"href":"https://api.github.com/repos/atom/vim-mode/issues/574"},"comments":{"href":"https://api.github.com/repos/atom/vim-mode/issues/574/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/vim-mode/pulls/574/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/vim-mode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atom/vim-mode/pulls/574/commits"},"statuses":{"href":"https://api.github.com/repos/atom/vim-mode/statuses/91069db61fd16d6f7c6a03880cceea0fc8eeb235"}}}}