{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/rkt/pulls/comments/43138727","id":43138727,"diff_hunk":"@@ -507,45 +491,29 @@ func (p *Pod) appToNspawnArgs(ra *schema.RuntimeApp) ([]string, error) {\n \tif err := os.Chmod(sharedVolPath, sharedVolPerm); err != nil {\n \t\treturn nil, fmt.Errorf(\"could not change permissions of %q: %v\", sharedVolPath, err)\n \t}\n-\t// Here we bind the volumes to the mountpoints via runtime mounts (--mount)\n+\n+\tvols := make(map[types.ACName]types.Volume)\n \tfor _, v := range p.Manifest.Volumes {\n \t\tvols[v.Name] = v\n-\t\tif v.Kind == \"empty\" {\n-\t\t\tif err := os.MkdirAll(filepath.Join(sharedVolPath, v.Name.String()), sharedVolPerm); err != nil {\n-\t\t\t\treturn nil, fmt.Errorf(\"could not create shared volume %q: %v\", v.Name, err)\n-\t\t\t}\n-\t\t}\n-\t}\n \n-\tfor _, mp := range app.MountPoints {\n-\t\t// there's already an injected mount for this target path, skip\n-\t\tif _, ok := mounts[mp.Path]; ok {\n-\t\t\tcontinue\n+\t\tif err := os.MkdirAll(filepath.Join(sharedVolPath, v.Name.String()), sharedVolPerm); err != nil {","path":"stage1/init/pod.go","position":68,"original_position":68,"commit_id":"a81802336705b5d0e5053e257d03bac6919de66e","original_commit_id":"a81802336705b5d0e5053e257d03bac6919de66e","user":{"login":"krnowak","id":96081,"avatar_url":"https://avatars.githubusercontent.com/u/96081?v=3","gravatar_id":"","url":"https://api.github.com/users/krnowak","html_url":"https://github.com/krnowak","followers_url":"https://api.github.com/users/krnowak/followers","following_url":"https://api.github.com/users/krnowak/following{/other_user}","gists_url":"https://api.github.com/users/krnowak/gists{/gist_id}","starred_url":"https://api.github.com/users/krnowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krnowak/subscriptions","organizations_url":"https://api.github.com/users/krnowak/orgs","repos_url":"https://api.github.com/users/krnowak/repos","events_url":"https://api.github.com/users/krnowak/events{/privacy}","received_events_url":"https://api.github.com/users/krnowak/received_events","type":"User","site_admin":false},"body":"Looks like the directory is created for all volumes, not only the \"empty\" ones. Intended? ","created_at":"2015-10-27T15:34:51Z","updated_at":"2015-10-27T15:34:51Z","html_url":"https://github.com/coreos/rkt/pull/1687#discussion_r43138727","pull_request_url":"https://api.github.com/repos/coreos/rkt/pulls/1687","_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments/43138727"},"html":{"href":"https://github.com/coreos/rkt/pull/1687#discussion_r43138727"},"pull_request":{"href":"https://api.github.com/repos/coreos/rkt/pulls/1687"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/rkt/pulls/1687","id":48885186,"html_url":"https://github.com/coreos/rkt/pull/1687","diff_url":"https://github.com/coreos/rkt/pull/1687.diff","patch_url":"https://github.com/coreos/rkt/pull/1687.patch","issue_url":"https://api.github.com/repos/coreos/rkt/issues/1687","number":1687,"state":"open","locked":false,"title":"stage1: use PodManifest.Mounts in the kvm flavor","user":{"login":"iaguis","id":507354,"avatar_url":"https://avatars.githubusercontent.com/u/507354?v=3","gravatar_id":"","url":"https://api.github.com/users/iaguis","html_url":"https://github.com/iaguis","followers_url":"https://api.github.com/users/iaguis/followers","following_url":"https://api.github.com/users/iaguis/following{/other_user}","gists_url":"https://api.github.com/users/iaguis/gists{/gist_id}","starred_url":"https://api.github.com/users/iaguis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iaguis/subscriptions","organizations_url":"https://api.github.com/users/iaguis/orgs","repos_url":"https://api.github.com/users/iaguis/repos","events_url":"https://api.github.com/users/iaguis/events{/privacy}","received_events_url":"https://api.github.com/users/iaguis/received_events","type":"User","site_admin":false},"body":"In https://github.com/coreos/rkt/pull/1582 we added support for\r\nPodManifest.Mounts but we didn't consider the kvm flavor.\r\n\r\nThis commit adds support for the kvm flavor and refactors the code a\r\nbit.\r\n\r\nFixes #1663","created_at":"2015-10-27T15:19:15Z","updated_at":"2015-10-27T15:34:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c52731499715cd536b1ae89c2eab42c735aa003d","assignee":null,"milestone":{"url":"https://api.github.com/repos/coreos/rkt/milestones/24","html_url":"https://github.com/coreos/rkt/milestones/v0.11.0","labels_url":"https://api.github.com/repos/coreos/rkt/milestones/24/labels","id":1360014,"number":24,"title":"v0.11.0","description":"","creator":{"login":"jonboulle","id":2601015,"avatar_url":"https://avatars.githubusercontent.com/u/2601015?v=3","gravatar_id":"","url":"https://api.github.com/users/jonboulle","html_url":"https://github.com/jonboulle","followers_url":"https://api.github.com/users/jonboulle/followers","following_url":"https://api.github.com/users/jonboulle/following{/other_user}","gists_url":"https://api.github.com/users/jonboulle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboulle/subscriptions","organizations_url":"https://api.github.com/users/jonboulle/orgs","repos_url":"https://api.github.com/users/jonboulle/repos","events_url":"https://api.github.com/users/jonboulle/events{/privacy}","received_events_url":"https://api.github.com/users/jonboulle/received_events","type":"User","site_admin":false},"open_issues":67,"closed_issues":8,"state":"open","created_at":"2015-10-16T18:28:50Z","updated_at":"2015-10-27T15:19:41Z","due_on":"2015-11-04T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/coreos/rkt/pulls/1687/commits","review_comments_url":"https://api.github.com/repos/coreos/rkt/pulls/1687/comments","review_comment_url":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/rkt/issues/1687/comments","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/a81802336705b5d0e5053e257d03bac6919de66e","head":{"label":"iaguis:mounts-kvm","ref":"mounts-kvm","sha":"a81802336705b5d0e5053e257d03bac6919de66e","user":{"login":"iaguis","id":507354,"avatar_url":"https://avatars.githubusercontent.com/u/507354?v=3","gravatar_id":"","url":"https://api.github.com/users/iaguis","html_url":"https://github.com/iaguis","followers_url":"https://api.github.com/users/iaguis/followers","following_url":"https://api.github.com/users/iaguis/following{/other_user}","gists_url":"https://api.github.com/users/iaguis/gists{/gist_id}","starred_url":"https://api.github.com/users/iaguis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iaguis/subscriptions","organizations_url":"https://api.github.com/users/iaguis/orgs","repos_url":"https://api.github.com/users/iaguis/repos","events_url":"https://api.github.com/users/iaguis/events{/privacy}","received_events_url":"https://api.github.com/users/iaguis/received_events","type":"User","site_admin":false},"repo":{"id":34848570,"name":"rkt","full_name":"iaguis/rkt","owner":{"login":"iaguis","id":507354,"avatar_url":"https://avatars.githubusercontent.com/u/507354?v=3","gravatar_id":"","url":"https://api.github.com/users/iaguis","html_url":"https://github.com/iaguis","followers_url":"https://api.github.com/users/iaguis/followers","following_url":"https://api.github.com/users/iaguis/following{/other_user}","gists_url":"https://api.github.com/users/iaguis/gists{/gist_id}","starred_url":"https://api.github.com/users/iaguis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iaguis/subscriptions","organizations_url":"https://api.github.com/users/iaguis/orgs","repos_url":"https://api.github.com/users/iaguis/repos","events_url":"https://api.github.com/users/iaguis/events{/privacy}","received_events_url":"https://api.github.com/users/iaguis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iaguis/rkt","description":"App Container runtime","fork":true,"url":"https://api.github.com/repos/iaguis/rkt","forks_url":"https://api.github.com/repos/iaguis/rkt/forks","keys_url":"https://api.github.com/repos/iaguis/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iaguis/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iaguis/rkt/teams","hooks_url":"https://api.github.com/repos/iaguis/rkt/hooks","issue_events_url":"https://api.github.com/repos/iaguis/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/iaguis/rkt/events","assignees_url":"https://api.github.com/repos/iaguis/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/iaguis/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/iaguis/rkt/tags","blobs_url":"https://api.github.com/repos/iaguis/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iaguis/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iaguis/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/iaguis/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iaguis/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/iaguis/rkt/languages","stargazers_url":"https://api.github.com/repos/iaguis/rkt/stargazers","contributors_url":"https://api.github.com/repos/iaguis/rkt/contributors","subscribers_url":"https://api.github.com/repos/iaguis/rkt/subscribers","subscription_url":"https://api.github.com/repos/iaguis/rkt/subscription","commits_url":"https://api.github.com/repos/iaguis/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/iaguis/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/iaguis/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/iaguis/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/iaguis/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/iaguis/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iaguis/rkt/merges","archive_url":"https://api.github.com/repos/iaguis/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iaguis/rkt/downloads","issues_url":"https://api.github.com/repos/iaguis/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/iaguis/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/iaguis/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/iaguis/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iaguis/rkt/labels{/name}","releases_url":"https://api.github.com/repos/iaguis/rkt/releases{/id}","created_at":"2015-04-30T10:23:40Z","updated_at":"2015-04-30T10:23:41Z","pushed_at":"2015-10-27T15:25:06Z","git_url":"git://github.com/iaguis/rkt.git","ssh_url":"git@github.com:iaguis/rkt.git","clone_url":"https://github.com/iaguis/rkt.git","svn_url":"https://github.com/iaguis/rkt","homepage":"","size":17441,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"621d40ac592488cb0d7f58c10e5d79fbd6d0505c","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":26509369,"name":"rkt","full_name":"coreos/rkt","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/rkt","description":"rkt is an App Container runtime for Linux","fork":false,"url":"https://api.github.com/repos/coreos/rkt","forks_url":"https://api.github.com/repos/coreos/rkt/forks","keys_url":"https://api.github.com/repos/coreos/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/rkt/teams","hooks_url":"https://api.github.com/repos/coreos/rkt/hooks","issue_events_url":"https://api.github.com/repos/coreos/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/rkt/events","assignees_url":"https://api.github.com/repos/coreos/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/rkt/tags","blobs_url":"https://api.github.com/repos/coreos/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/rkt/languages","stargazers_url":"https://api.github.com/repos/coreos/rkt/stargazers","contributors_url":"https://api.github.com/repos/coreos/rkt/contributors","subscribers_url":"https://api.github.com/repos/coreos/rkt/subscribers","subscription_url":"https://api.github.com/repos/coreos/rkt/subscription","commits_url":"https://api.github.com/repos/coreos/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/rkt/merges","archive_url":"https://api.github.com/repos/coreos/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/rkt/downloads","issues_url":"https://api.github.com/repos/coreos/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/rkt/labels{/name}","releases_url":"https://api.github.com/repos/coreos/rkt/releases{/id}","created_at":"2014-11-11T23:13:18Z","updated_at":"2015-10-27T14:23:19Z","pushed_at":"2015-10-27T15:25:08Z","git_url":"git://github.com/coreos/rkt.git","ssh_url":"git@github.com:coreos/rkt.git","clone_url":"https://github.com/coreos/rkt.git","svn_url":"https://github.com/coreos/rkt","homepage":"","size":28169,"stargazers_count":4778,"watchers_count":4778,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":402,"mirror_url":null,"open_issues_count":186,"forks":402,"open_issues":186,"watchers":4778,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/1687"},"html":{"href":"https://github.com/coreos/rkt/pull/1687"},"issue":{"href":"https://api.github.com/repos/coreos/rkt/issues/1687"},"comments":{"href":"https://api.github.com/repos/coreos/rkt/issues/1687/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/rkt/pulls/1687/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/rkt/pulls/1687/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/rkt/statuses/a81802336705b5d0e5053e257d03bac6919de66e"}}}}