{"action":"created","comment":{"url":"https://api.github.com/repos/edx/ux-pattern-library/pulls/comments/35324009","id":35324009,"diff_hunk":"@@ -23,29 +23,29 @@ info: Forms allow users to interact with the interface, set preferences, and ent\n         <fieldset class=\"form-group\">\n             <legend class=\"form-group-hd sr-only\">Personal Details</legend>\n             <div class=\"field\">\n-                <label class=\"field-label\" for=\"full_name_default\">Your name (default text field)</label>\n-                <input class=\"field-input input-text\" type=\"text\" id=\"full_name_default\" name=\"full_name_default\" placeholder=\"e.g. Jane Doe\" aria-describedby=\"full_name_default_helper\">\n-                <div class=\"field-hint\" id=\"full_name_default_helper\">\n+                <label class=\"field-label\" for=\"full-name-default\">Your name (default text field)</label>\n+                <input class=\"field-input input-text\" type=\"text\" id=\"full-name-default\" name=\"full-name-default\" placeholder=\"e.g. Jane Doe\" aria-describedby=\"full-name-default-hint\">\n+                <div class=\"field-hint\" id=\"full-name-default-hint\">\n                     <p>Example: Jane Doe</p>\n                 </div>\n             </div>\n             <div class=\"field\">\n-                <label class=\"field-label\" for=\"email_address_default_01\">Email address (default, disabled text field)</label>\n-                <input class=\"field-input input-text\" type=\"email\" id=\"email_address_default_01\" name=\"email_address_default_01\" placeholder=\"e.g. jane@email.com\"  aria-describedby=\"email_address_default_01_helper\" disabled>\n-                <div class=\"field-hint\" id=\"email_address_default_01_helper\">\n+                <label class=\"field-label\" for=\"email-address-default-01\">Email address (default, disabled text field)</label>\n+                <input class=\"field-input input-text\" type=\"email\" id=\"email-address-default-01\" name=\"email-address-default-01\" placeholder=\"e.g. jane@email.com\"  aria-describedby=\"email-address-default-01-hint\" disabled>\n+                <div class=\"field-hint\" id=\"email-address-default-01-hint\">\n                     <p>Example: jane@email.com</p>\n                 </div>\n             </div>\n             <div class=\"field\">\n-                <label class=\"field-label field-required\" for=\"email_address_default_helper\">Email address (default, required text field with helper text)</label>\n-                <input class=\"field-input input-text\" type=\"email\" id=\"email_address_default_helper\" name=\"email_address_default_helper\" placeholder=\"e.g. jane@email.com\" aria-describedby=\"email_address_default_helper\" required>\n-                <div class=\"field-hint\" id=\"email_address_default_helper\">\n+                <label class=\"field-label field-required\" for=\"email-address-default-helper\">Email address (default, required text field with hint text)</label>\n+                <input class=\"field-input input-text\" type=\"email\" id=\"email-address-default-helper\" name=\"email-address-default-hint\" placeholder=\"e.g. jane@email.com\" aria-describedby=\"email-address-default-hint\" required>\n+                <div class=\"field-hint\" id=\"email-address-default-hint\">\n                     <p>Your email address will never be shared. We promise.</p>\n                 </div>\n             </div>\n             <div class=\"field\">\n-                <label class=\"field-label field-required\" for=\"email_address_default_err_helper\">Email address (default, has error)</label>\n-                <input class=\"field-input input-text has-error\" type=\"email\" id=\"email_address_default_err_helper\" name=\"email_address_default_err_helper\" placeholder=\"e.g. jane@email.com\" value=\"jane@domain\" aria-describedby=\"email_address_default_err_helper\" required>\n+                <label class=\"field-label field-required\" for=\"email-address-default-err-hint\">Email address (default, has error)</label>\n+                <input class=\"field-input input-text has-error\" type=\"email\" id=\"email-address-default-err-hint\" name=\"email-address-default-err-hint\" placeholder=\"e.g. jane@email.com\" value=\"jane@domain\" required>","path":"_posts/elements/2015-05-12-forms.md","position":37,"original_position":37,"commit_id":"483c41335d5e0fb7706740baacefe7583e2a7148","original_commit_id":"483c41335d5e0fb7706740baacefe7583e2a7148","user":{"login":"talbs","id":163763,"avatar_url":"https://avatars.githubusercontent.com/u/163763?v=3","gravatar_id":"","url":"https://api.github.com/users/talbs","html_url":"https://github.com/talbs","followers_url":"https://api.github.com/users/talbs/followers","following_url":"https://api.github.com/users/talbs/following{/other_user}","gists_url":"https://api.github.com/users/talbs/gists{/gist_id}","starred_url":"https://api.github.com/users/talbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talbs/subscriptions","organizations_url":"https://api.github.com/users/talbs/orgs","repos_url":"https://api.github.com/users/talbs/repos","events_url":"https://api.github.com/users/talbs/events{/privacy}","received_events_url":"https://api.github.com/users/talbs/received_events","type":"User","site_admin":false},"body":"Please do not abbreviate ``err``? Let's match the ``error`` label/term used elsewhere in the DOM.","created_at":"2015-07-23T14:04:28Z","updated_at":"2015-07-23T14:04:28Z","html_url":"https://github.com/edx/ux-pattern-library/pull/130#discussion_r35324009","pull_request_url":"https://api.github.com/repos/edx/ux-pattern-library/pulls/130","_links":{"self":{"href":"https://api.github.com/repos/edx/ux-pattern-library/pulls/comments/35324009"},"html":{"href":"https://github.com/edx/ux-pattern-library/pull/130#discussion_r35324009"},"pull_request":{"href":"https://api.github.com/repos/edx/ux-pattern-library/pulls/130"}}},"pull_request":{"url":"https://api.github.com/repos/edx/ux-pattern-library/pulls/130","id":40601132,"html_url":"https://github.com/edx/ux-pattern-library/pull/130","diff_url":"https://github.com/edx/ux-pattern-library/pull/130.diff","patch_url":"https://github.com/edx/ux-pattern-library/pull/130.patch","issue_url":"https://api.github.com/repos/edx/ux-pattern-library/issues/130","number":130,"state":"open","locked":false,"title":"Remaining accessibility fixes to the PL site","user":{"login":"clrux","id":2112024,"avatar_url":"https://avatars.githubusercontent.com/u/2112024?v=3","gravatar_id":"","url":"https://api.github.com/users/clrux","html_url":"https://github.com/clrux","followers_url":"https://api.github.com/users/clrux/followers","following_url":"https://api.github.com/users/clrux/following{/other_user}","gists_url":"https://api.github.com/users/clrux/gists{/gist_id}","starred_url":"https://api.github.com/users/clrux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clrux/subscriptions","organizations_url":"https://api.github.com/users/clrux/orgs","repos_url":"https://api.github.com/users/clrux/repos","events_url":"https://api.github.com/users/clrux/events{/privacy}","received_events_url":"https://api.github.com/users/clrux/received_events","type":"User","site_admin":false},"body":"This relatively small bit of work cleans up the remaining (pertinent) accessibility issues.\r\n\r\nSome work performed:\r\n\r\n* contrast issues on links, especially those on gray\r\n* set background and foregrounds on the `.sr-only` elements (to black and white, respectively)\r\n* added a few `aria-label`'s on landmark elements\r\n* markup and structure improvements\r\n\r\nSome errors that aren't relevant:\r\n\r\n* form field examples don't have submit buttons; this is okay since these are just examples\r\n* a few of the colors have contrast issues; these are intentionally shown and we note them visually\r\n\r\n---\r\n\r\nPlease review:\r\n\r\n- [x] @talbs \r\n- [x] @cptvitamin ","created_at":"2015-07-22T19:18:26Z","updated_at":"2015-07-23T14:04:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b380c1a42cc29dadb81b87c7d444ec7d46d5eff4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/ux-pattern-library/pulls/130/commits","review_comments_url":"https://api.github.com/repos/edx/ux-pattern-library/pulls/130/comments","review_comment_url":"https://api.github.com/repos/edx/ux-pattern-library/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/ux-pattern-library/issues/130/comments","statuses_url":"https://api.github.com/repos/edx/ux-pattern-library/statuses/483c41335d5e0fb7706740baacefe7583e2a7148","head":{"label":"edx:clrux/a11y-wrap-up","ref":"clrux/a11y-wrap-up","sha":"483c41335d5e0fb7706740baacefe7583e2a7148","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":29666334,"name":"ux-pattern-library","full_name":"edx/ux-pattern-library","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/ux-pattern-library","description":"The (working) Visual, UI, and Front End Styleguide for edX.","fork":false,"url":"https://api.github.com/repos/edx/ux-pattern-library","forks_url":"https://api.github.com/repos/edx/ux-pattern-library/forks","keys_url":"https://api.github.com/repos/edx/ux-pattern-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/ux-pattern-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/ux-pattern-library/teams","hooks_url":"https://api.github.com/repos/edx/ux-pattern-library/hooks","issue_events_url":"https://api.github.com/repos/edx/ux-pattern-library/issues/events{/number}","events_url":"https://api.github.com/repos/edx/ux-pattern-library/events","assignees_url":"https://api.github.com/repos/edx/ux-pattern-library/assignees{/user}","branches_url":"https://api.github.com/repos/edx/ux-pattern-library/branches{/branch}","tags_url":"https://api.github.com/repos/edx/ux-pattern-library/tags","blobs_url":"https://api.github.com/repos/edx/ux-pattern-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/ux-pattern-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/ux-pattern-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/ux-pattern-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/ux-pattern-library/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/ux-pattern-library/languages","stargazers_url":"https://api.github.com/repos/edx/ux-pattern-library/stargazers","contributors_url":"https://api.github.com/repos/edx/ux-pattern-library/contributors","subscribers_url":"https://api.github.com/repos/edx/ux-pattern-library/subscribers","subscription_url":"https://api.github.com/repos/edx/ux-pattern-library/subscription","commits_url":"https://api.github.com/repos/edx/ux-pattern-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/ux-pattern-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/ux-pattern-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/ux-pattern-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/ux-pattern-library/contents/{+path}","compare_url":"https://api.github.com/repos/edx/ux-pattern-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/ux-pattern-library/merges","archive_url":"https://api.github.com/repos/edx/ux-pattern-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/ux-pattern-library/downloads","issues_url":"https://api.github.com/repos/edx/ux-pattern-library/issues{/number}","pulls_url":"https://api.github.com/repos/edx/ux-pattern-library/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/ux-pattern-library/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/ux-pattern-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/ux-pattern-library/labels{/name}","releases_url":"https://api.github.com/repos/edx/ux-pattern-library/releases{/id}","created_at":"2015-01-22T07:19:42Z","updated_at":"2015-07-09T15:46:06Z","pushed_at":"2015-07-23T13:10:32Z","git_url":"git://github.com/edx/ux-pattern-library.git","ssh_url":"git@github.com:edx/ux-pattern-library.git","clone_url":"https://github.com/edx/ux-pattern-library.git","svn_url":"https://github.com/edx/ux-pattern-library","homepage":"http://ux.edx.org","size":6043,"stargazers_count":20,"watchers_count":20,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":7,"forks":5,"open_issues":7,"watchers":20,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"de968ca598578fa33aae2cdd98d3e959538ea67d","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":29666334,"name":"ux-pattern-library","full_name":"edx/ux-pattern-library","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/ux-pattern-library","description":"The (working) Visual, UI, and Front End Styleguide for edX.","fork":false,"url":"https://api.github.com/repos/edx/ux-pattern-library","forks_url":"https://api.github.com/repos/edx/ux-pattern-library/forks","keys_url":"https://api.github.com/repos/edx/ux-pattern-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/ux-pattern-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/ux-pattern-library/teams","hooks_url":"https://api.github.com/repos/edx/ux-pattern-library/hooks","issue_events_url":"https://api.github.com/repos/edx/ux-pattern-library/issues/events{/number}","events_url":"https://api.github.com/repos/edx/ux-pattern-library/events","assignees_url":"https://api.github.com/repos/edx/ux-pattern-library/assignees{/user}","branches_url":"https://api.github.com/repos/edx/ux-pattern-library/branches{/branch}","tags_url":"https://api.github.com/repos/edx/ux-pattern-library/tags","blobs_url":"https://api.github.com/repos/edx/ux-pattern-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/ux-pattern-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/ux-pattern-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/ux-pattern-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/ux-pattern-library/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/ux-pattern-library/languages","stargazers_url":"https://api.github.com/repos/edx/ux-pattern-library/stargazers","contributors_url":"https://api.github.com/repos/edx/ux-pattern-library/contributors","subscribers_url":"https://api.github.com/repos/edx/ux-pattern-library/subscribers","subscription_url":"https://api.github.com/repos/edx/ux-pattern-library/subscription","commits_url":"https://api.github.com/repos/edx/ux-pattern-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/ux-pattern-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/ux-pattern-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/ux-pattern-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/ux-pattern-library/contents/{+path}","compare_url":"https://api.github.com/repos/edx/ux-pattern-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/ux-pattern-library/merges","archive_url":"https://api.github.com/repos/edx/ux-pattern-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/ux-pattern-library/downloads","issues_url":"https://api.github.com/repos/edx/ux-pattern-library/issues{/number}","pulls_url":"https://api.github.com/repos/edx/ux-pattern-library/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/ux-pattern-library/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/ux-pattern-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/ux-pattern-library/labels{/name}","releases_url":"https://api.github.com/repos/edx/ux-pattern-library/releases{/id}","created_at":"2015-01-22T07:19:42Z","updated_at":"2015-07-09T15:46:06Z","pushed_at":"2015-07-23T13:10:32Z","git_url":"git://github.com/edx/ux-pattern-library.git","ssh_url":"git@github.com:edx/ux-pattern-library.git","clone_url":"https://github.com/edx/ux-pattern-library.git","svn_url":"https://github.com/edx/ux-pattern-library","homepage":"http://ux.edx.org","size":6043,"stargazers_count":20,"watchers_count":20,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":7,"forks":5,"open_issues":7,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/ux-pattern-library/pulls/130"},"html":{"href":"https://github.com/edx/ux-pattern-library/pull/130"},"issue":{"href":"https://api.github.com/repos/edx/ux-pattern-library/issues/130"},"comments":{"href":"https://api.github.com/repos/edx/ux-pattern-library/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/ux-pattern-library/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/ux-pattern-library/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/ux-pattern-library/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/edx/ux-pattern-library/statuses/483c41335d5e0fb7706740baacefe7583e2a7148"}}}}