{"action":"created","comment":{"url":"https://api.github.com/repos/dbellettini/php-eventstore-client/pulls/comments/31388769","id":31388769,"diff_hunk":"@@ -26,25 +25,33 @@\n     private $data;\n \n     /**\n+     * @var array\n+     */\n+    private $metadata;\n+\n+    /**\n      * @param  string        $type\n      * @param  array         $data\n+     * @param  array         $metadata\n      * @return WritableEvent\n      */\n-    public static function newInstance($type, $data)\n+    public static function newInstance($type, $data, $metadata = [])","path":"src/EventStore/WritableEvent.php","position":21,"original_position":21,"commit_id":"d9ebd090552bb11c1092be836ed5cf1b78f9b272","original_commit_id":"d9ebd090552bb11c1092be836ed5cf1b78f9b272","user":{"login":"nicolopignatelli","id":1071681,"avatar_url":"https://avatars.githubusercontent.com/u/1071681?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolopignatelli","html_url":"https://github.com/nicolopignatelli","followers_url":"https://api.github.com/users/nicolopignatelli/followers","following_url":"https://api.github.com/users/nicolopignatelli/following{/other_user}","gists_url":"https://api.github.com/users/nicolopignatelli/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolopignatelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolopignatelli/subscriptions","organizations_url":"https://api.github.com/users/nicolopignatelli/orgs","repos_url":"https://api.github.com/users/nicolopignatelli/repos","events_url":"https://api.github.com/users/nicolopignatelli/events{/privacy}","received_events_url":"https://api.github.com/users/nicolopignatelli/received_events","type":"User","site_admin":false},"body":"add type hint to $data and $metadata","created_at":"2015-05-31T10:10:43Z","updated_at":"2015-05-31T10:10:43Z","html_url":"https://github.com/dbellettini/php-eventstore-client/pull/18#discussion_r31388769","pull_request_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/dbellettini/php-eventstore-client/pulls/comments/31388769"},"html":{"href":"https://github.com/dbellettini/php-eventstore-client/pull/18#discussion_r31388769"},"pull_request":{"href":"https://api.github.com/repos/dbellettini/php-eventstore-client/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/dbellettini/php-eventstore-client/pulls/18","id":36038146,"html_url":"https://github.com/dbellettini/php-eventstore-client/pull/18","diff_url":"https://github.com/dbellettini/php-eventstore-client/pull/18.diff","patch_url":"https://github.com/dbellettini/php-eventstore-client/pull/18.patch","issue_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/issues/18","number":18,"state":"open","locked":false,"title":"[WIP][FEATURE] Implement support for event metadata","user":{"login":"Akii","id":1204017,"avatar_url":"https://avatars.githubusercontent.com/u/1204017?v=3","gravatar_id":"","url":"https://api.github.com/users/Akii","html_url":"https://github.com/Akii","followers_url":"https://api.github.com/users/Akii/followers","following_url":"https://api.github.com/users/Akii/following{/other_user}","gists_url":"https://api.github.com/users/Akii/gists{/gist_id}","starred_url":"https://api.github.com/users/Akii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akii/subscriptions","organizations_url":"https://api.github.com/users/Akii/orgs","repos_url":"https://api.github.com/users/Akii/repos","events_url":"https://api.github.com/users/Akii/events{/privacy}","received_events_url":"https://api.github.com/users/Akii/received_events","type":"User","site_admin":false},"body":"So I've looked into how the metadata thing works with eventstore. And during implementation I fixed some logical problems (fx. that the version is part of the Entry) along with code style inconsistencies.\r\n\r\nI marked this as WIP because I also would like to add some more tests. Please let me know what you think about the general approach.","created_at":"2015-05-22T14:50:40Z","updated_at":"2015-05-31T10:10:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd7d1953b36358bf15e780c392523f1600043116","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/pulls/18/commits","review_comments_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/pulls/18/comments","review_comment_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/issues/18/comments","statuses_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/statuses/d9ebd090552bb11c1092be836ed5cf1b78f9b272","head":{"label":"Akii:metadata","ref":"metadata","sha":"d9ebd090552bb11c1092be836ed5cf1b78f9b272","user":{"login":"Akii","id":1204017,"avatar_url":"https://avatars.githubusercontent.com/u/1204017?v=3","gravatar_id":"","url":"https://api.github.com/users/Akii","html_url":"https://github.com/Akii","followers_url":"https://api.github.com/users/Akii/followers","following_url":"https://api.github.com/users/Akii/following{/other_user}","gists_url":"https://api.github.com/users/Akii/gists{/gist_id}","starred_url":"https://api.github.com/users/Akii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akii/subscriptions","organizations_url":"https://api.github.com/users/Akii/orgs","repos_url":"https://api.github.com/users/Akii/repos","events_url":"https://api.github.com/users/Akii/events{/privacy}","received_events_url":"https://api.github.com/users/Akii/received_events","type":"User","site_admin":false},"repo":{"id":33591815,"name":"php-eventstore-client","full_name":"Akii/php-eventstore-client","owner":{"login":"Akii","id":1204017,"avatar_url":"https://avatars.githubusercontent.com/u/1204017?v=3","gravatar_id":"","url":"https://api.github.com/users/Akii","html_url":"https://github.com/Akii","followers_url":"https://api.github.com/users/Akii/followers","following_url":"https://api.github.com/users/Akii/following{/other_user}","gists_url":"https://api.github.com/users/Akii/gists{/gist_id}","starred_url":"https://api.github.com/users/Akii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akii/subscriptions","organizations_url":"https://api.github.com/users/Akii/orgs","repos_url":"https://api.github.com/users/Akii/repos","events_url":"https://api.github.com/users/Akii/events{/privacy}","received_events_url":"https://api.github.com/users/Akii/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Akii/php-eventstore-client","description":"PHP Client for EventStore. Development just started","fork":true,"url":"https://api.github.com/repos/Akii/php-eventstore-client","forks_url":"https://api.github.com/repos/Akii/php-eventstore-client/forks","keys_url":"https://api.github.com/repos/Akii/php-eventstore-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Akii/php-eventstore-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Akii/php-eventstore-client/teams","hooks_url":"https://api.github.com/repos/Akii/php-eventstore-client/hooks","issue_events_url":"https://api.github.com/repos/Akii/php-eventstore-client/issues/events{/number}","events_url":"https://api.github.com/repos/Akii/php-eventstore-client/events","assignees_url":"https://api.github.com/repos/Akii/php-eventstore-client/assignees{/user}","branches_url":"https://api.github.com/repos/Akii/php-eventstore-client/branches{/branch}","tags_url":"https://api.github.com/repos/Akii/php-eventstore-client/tags","blobs_url":"https://api.github.com/repos/Akii/php-eventstore-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Akii/php-eventstore-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Akii/php-eventstore-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/Akii/php-eventstore-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Akii/php-eventstore-client/statuses/{sha}","languages_url":"https://api.github.com/repos/Akii/php-eventstore-client/languages","stargazers_url":"https://api.github.com/repos/Akii/php-eventstore-client/stargazers","contributors_url":"https://api.github.com/repos/Akii/php-eventstore-client/contributors","subscribers_url":"https://api.github.com/repos/Akii/php-eventstore-client/subscribers","subscription_url":"https://api.github.com/repos/Akii/php-eventstore-client/subscription","commits_url":"https://api.github.com/repos/Akii/php-eventstore-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/Akii/php-eventstore-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/Akii/php-eventstore-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/Akii/php-eventstore-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/Akii/php-eventstore-client/contents/{+path}","compare_url":"https://api.github.com/repos/Akii/php-eventstore-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Akii/php-eventstore-client/merges","archive_url":"https://api.github.com/repos/Akii/php-eventstore-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Akii/php-eventstore-client/downloads","issues_url":"https://api.github.com/repos/Akii/php-eventstore-client/issues{/number}","pulls_url":"https://api.github.com/repos/Akii/php-eventstore-client/pulls{/number}","milestones_url":"https://api.github.com/repos/Akii/php-eventstore-client/milestones{/number}","notifications_url":"https://api.github.com/repos/Akii/php-eventstore-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Akii/php-eventstore-client/labels{/name}","releases_url":"https://api.github.com/repos/Akii/php-eventstore-client/releases{/id}","created_at":"2015-04-08T07:34:42Z","updated_at":"2015-04-08T07:34:43Z","pushed_at":"2015-05-22T14:48:45Z","git_url":"git://github.com/Akii/php-eventstore-client.git","ssh_url":"git@github.com:Akii/php-eventstore-client.git","clone_url":"https://github.com/Akii/php-eventstore-client.git","svn_url":"https://github.com/Akii/php-eventstore-client","homepage":"http://dbellettini.github.io/php-eventstore-client/","size":306,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dbellettini:master","ref":"master","sha":"c63df8549300902b25e633bea184b49d98d4c6de","user":{"login":"dbellettini","id":325358,"avatar_url":"https://avatars.githubusercontent.com/u/325358?v=3","gravatar_id":"","url":"https://api.github.com/users/dbellettini","html_url":"https://github.com/dbellettini","followers_url":"https://api.github.com/users/dbellettini/followers","following_url":"https://api.github.com/users/dbellettini/following{/other_user}","gists_url":"https://api.github.com/users/dbellettini/gists{/gist_id}","starred_url":"https://api.github.com/users/dbellettini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbellettini/subscriptions","organizations_url":"https://api.github.com/users/dbellettini/orgs","repos_url":"https://api.github.com/users/dbellettini/repos","events_url":"https://api.github.com/users/dbellettini/events{/privacy}","received_events_url":"https://api.github.com/users/dbellettini/received_events","type":"User","site_admin":false},"repo":{"id":18466422,"name":"php-eventstore-client","full_name":"dbellettini/php-eventstore-client","owner":{"login":"dbellettini","id":325358,"avatar_url":"https://avatars.githubusercontent.com/u/325358?v=3","gravatar_id":"","url":"https://api.github.com/users/dbellettini","html_url":"https://github.com/dbellettini","followers_url":"https://api.github.com/users/dbellettini/followers","following_url":"https://api.github.com/users/dbellettini/following{/other_user}","gists_url":"https://api.github.com/users/dbellettini/gists{/gist_id}","starred_url":"https://api.github.com/users/dbellettini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbellettini/subscriptions","organizations_url":"https://api.github.com/users/dbellettini/orgs","repos_url":"https://api.github.com/users/dbellettini/repos","events_url":"https://api.github.com/users/dbellettini/events{/privacy}","received_events_url":"https://api.github.com/users/dbellettini/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dbellettini/php-eventstore-client","description":"PHP Client for EventStore. Development just started","fork":false,"url":"https://api.github.com/repos/dbellettini/php-eventstore-client","forks_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/forks","keys_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/teams","hooks_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/hooks","issue_events_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/issues/events{/number}","events_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/events","assignees_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/assignees{/user}","branches_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/branches{/branch}","tags_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/tags","blobs_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/statuses/{sha}","languages_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/languages","stargazers_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/stargazers","contributors_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/contributors","subscribers_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/subscribers","subscription_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/subscription","commits_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/contents/{+path}","compare_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/merges","archive_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/downloads","issues_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/issues{/number}","pulls_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/pulls{/number}","milestones_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/milestones{/number}","notifications_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/labels{/name}","releases_url":"https://api.github.com/repos/dbellettini/php-eventstore-client/releases{/id}","created_at":"2014-04-05T12:33:02Z","updated_at":"2015-05-21T21:26:39Z","pushed_at":"2015-05-30T21:59:32Z","git_url":"git://github.com/dbellettini/php-eventstore-client.git","ssh_url":"git@github.com:dbellettini/php-eventstore-client.git","clone_url":"https://github.com/dbellettini/php-eventstore-client.git","svn_url":"https://github.com/dbellettini/php-eventstore-client","homepage":"http://dbellettini.github.io/php-eventstore-client/","size":1367,"stargazers_count":37,"watchers_count":37,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":4,"forks":6,"open_issues":4,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dbellettini/php-eventstore-client/pulls/18"},"html":{"href":"https://github.com/dbellettini/php-eventstore-client/pull/18"},"issue":{"href":"https://api.github.com/repos/dbellettini/php-eventstore-client/issues/18"},"comments":{"href":"https://api.github.com/repos/dbellettini/php-eventstore-client/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/dbellettini/php-eventstore-client/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/dbellettini/php-eventstore-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dbellettini/php-eventstore-client/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/dbellettini/php-eventstore-client/statuses/d9ebd090552bb11c1092be836ed5cf1b78f9b272"}}}}