{"action":"opened","number":29021,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/29021","id":47524407,"html_url":"https://github.com/rust-lang/rust/pull/29021","diff_url":"https://github.com/rust-lang/rust/pull/29021.diff","patch_url":"https://github.com/rust-lang/rust/pull/29021.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/29021","number":29021,"state":"open","locked":false,"title":"Make the Metadata struct Clone","user":{"login":"ogham","id":503760,"avatar_url":"https://avatars.githubusercontent.com/u/503760?v=3","gravatar_id":"","url":"https://api.github.com/users/ogham","html_url":"https://github.com/ogham","followers_url":"https://api.github.com/users/ogham/followers","following_url":"https://api.github.com/users/ogham/following{/other_user}","gists_url":"https://api.github.com/users/ogham/gists{/gist_id}","starred_url":"https://api.github.com/users/ogham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogham/subscriptions","organizations_url":"https://api.github.com/users/ogham/orgs","repos_url":"https://api.github.com/users/ogham/repos","events_url":"https://api.github.com/users/ogham/events{/privacy}","received_events_url":"https://api.github.com/users/ogham/received_events","type":"User","site_admin":false},"body":"This commit adds `#[derive(Clone)]` to `std::fs::Metadata`, making that struct cloneable. Although the exact contents of that struct differ between OSes, they all have it contain only value types, meaning that the data can be re-used without repercussions.\r\n\r\nIt also adds `#[derive(Clone)]` to every type used by that struct across all OSes, including the various Unix `stat` structs and Windows's `WIN32_FILE_ATTRIBUTE_DATA`.\r\n\r\nThis stems from my comment here: https://github.com/rust-lang/rfcs/issues/939#issuecomment-140524439","created_at":"2015-10-13T12:07:35Z","updated_at":"2015-10-13T12:07:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/29021/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/29021/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/29021/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/b40163beb925b176fdb570e4f4998ab9919e77a4","head":{"label":"ogham:master","ref":"master","sha":"b40163beb925b176fdb570e4f4998ab9919e77a4","user":{"login":"ogham","id":503760,"avatar_url":"https://avatars.githubusercontent.com/u/503760?v=3","gravatar_id":"","url":"https://api.github.com/users/ogham","html_url":"https://github.com/ogham","followers_url":"https://api.github.com/users/ogham/followers","following_url":"https://api.github.com/users/ogham/following{/other_user}","gists_url":"https://api.github.com/users/ogham/gists{/gist_id}","starred_url":"https://api.github.com/users/ogham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogham/subscriptions","organizations_url":"https://api.github.com/users/ogham/orgs","repos_url":"https://api.github.com/users/ogham/repos","events_url":"https://api.github.com/users/ogham/events{/privacy}","received_events_url":"https://api.github.com/users/ogham/received_events","type":"User","site_admin":false},"repo":{"id":27079779,"name":"rust","full_name":"ogham/rust","owner":{"login":"ogham","id":503760,"avatar_url":"https://avatars.githubusercontent.com/u/503760?v=3","gravatar_id":"","url":"https://api.github.com/users/ogham","html_url":"https://github.com/ogham","followers_url":"https://api.github.com/users/ogham/followers","following_url":"https://api.github.com/users/ogham/following{/other_user}","gists_url":"https://api.github.com/users/ogham/gists{/gist_id}","starred_url":"https://api.github.com/users/ogham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogham/subscriptions","organizations_url":"https://api.github.com/users/ogham/orgs","repos_url":"https://api.github.com/users/ogham/repos","events_url":"https://api.github.com/users/ogham/events{/privacy}","received_events_url":"https://api.github.com/users/ogham/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ogham/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/ogham/rust","forks_url":"https://api.github.com/repos/ogham/rust/forks","keys_url":"https://api.github.com/repos/ogham/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ogham/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ogham/rust/teams","hooks_url":"https://api.github.com/repos/ogham/rust/hooks","issue_events_url":"https://api.github.com/repos/ogham/rust/issues/events{/number}","events_url":"https://api.github.com/repos/ogham/rust/events","assignees_url":"https://api.github.com/repos/ogham/rust/assignees{/user}","branches_url":"https://api.github.com/repos/ogham/rust/branches{/branch}","tags_url":"https://api.github.com/repos/ogham/rust/tags","blobs_url":"https://api.github.com/repos/ogham/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ogham/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ogham/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/ogham/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ogham/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/ogham/rust/languages","stargazers_url":"https://api.github.com/repos/ogham/rust/stargazers","contributors_url":"https://api.github.com/repos/ogham/rust/contributors","subscribers_url":"https://api.github.com/repos/ogham/rust/subscribers","subscription_url":"https://api.github.com/repos/ogham/rust/subscription","commits_url":"https://api.github.com/repos/ogham/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/ogham/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/ogham/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/ogham/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/ogham/rust/contents/{+path}","compare_url":"https://api.github.com/repos/ogham/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ogham/rust/merges","archive_url":"https://api.github.com/repos/ogham/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ogham/rust/downloads","issues_url":"https://api.github.com/repos/ogham/rust/issues{/number}","pulls_url":"https://api.github.com/repos/ogham/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/ogham/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/ogham/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ogham/rust/labels{/name}","releases_url":"https://api.github.com/repos/ogham/rust/releases{/id}","created_at":"2014-11-24T14:45:03Z","updated_at":"2014-11-24T14:45:13Z","pushed_at":"2015-10-13T12:06:21Z","git_url":"git://github.com/ogham/rust.git","ssh_url":"git@github.com:ogham/rust.git","clone_url":"https://github.com/ogham/rust.git","svn_url":"https://github.com/ogham/rust","homepage":"http://www.rust-lang.org","size":320891,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"ec4362da562a4b591a7d120c6677e14ea713481a","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2015-10-13T11:40:34Z","pushed_at":"2015-10-13T09:56:14Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":692843,"stargazers_count":13785,"watchers_count":13785,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2676,"mirror_url":null,"open_issues_count":2285,"forks":2676,"open_issues":2285,"watchers":13785,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/29021"},"html":{"href":"https://github.com/rust-lang/rust/pull/29021"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/29021"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/29021/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/29021/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/29021/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/b40163beb925b176fdb570e4f4998ab9919e77a4"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":22,"deletions":0,"changed_files":14}}