{"action":"created","issue":{"url":"https://api.github.com/repos/rpgtoolkit/core/issues/7","labels_url":"https://api.github.com/repos/rpgtoolkit/core/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/rpgtoolkit/core/issues/7/comments","events_url":"https://api.github.com/repos/rpgtoolkit/core/issues/7/events","html_url":"https://github.com/rpgtoolkit/core/pull/7","id":123027258,"number":7,"title":"Simplified AbstractJsonSerializer and applied refactoring to all exis…","user":{"login":"chutchinson","id":2136005,"avatar_url":"https://avatars.githubusercontent.com/u/2136005?v=3","gravatar_id":"","url":"https://api.github.com/users/chutchinson","html_url":"https://github.com/chutchinson","followers_url":"https://api.github.com/users/chutchinson/followers","following_url":"https://api.github.com/users/chutchinson/following{/other_user}","gists_url":"https://api.github.com/users/chutchinson/gists{/gist_id}","starred_url":"https://api.github.com/users/chutchinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chutchinson/subscriptions","organizations_url":"https://api.github.com/users/chutchinson/orgs","repos_url":"https://api.github.com/users/chutchinson/repos","events_url":"https://api.github.com/users/chutchinson/events{/privacy}","received_events_url":"https://api.github.com/users/chutchinson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-12-18T21:15:48Z","updated_at":"2015-12-22T12:59:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rpgtoolkit/core/pulls/7","html_url":"https://github.com/rpgtoolkit/core/pull/7","diff_url":"https://github.com/rpgtoolkit/core/pull/7.diff","patch_url":"https://github.com/rpgtoolkit/core/pull/7.patch"},"body":"This is a breaking change.\r\n\r\nPlease review the changes made to the existing serializers in respect to AbstractJsonSerializer. This change simplifies the JSON serialization mechanism.\r\n\r\nThere have also been changes to the following assets:\r\n\r\n - Board\r\n - SpecialMove\r\n - Project\r\n\r\nIn the future, please ensure all assets implement Asset or inherit from AbstractAsset. I will mark BasicType as deprecated soon. \r\n\r\nDo not think of assets as a direct representation of the contents of their serialized form. Asset types will be used directly in the engine and should represent their concepts and not how they will be serialized. It's the AssetSerializer's job to do care about data structure, data types, etc. during serialization.\r\n\r\nDo not use strings to represent linked assets. Always use an AssetDescriptor. See the JsonSpecialMoveSerializer and SpecialMove for a concrete example."},"comment":{"url":"https://api.github.com/repos/rpgtoolkit/core/issues/comments/166611066","html_url":"https://github.com/rpgtoolkit/core/pull/7#issuecomment-166611066","issue_url":"https://api.github.com/repos/rpgtoolkit/core/issues/7","id":166611066,"user":{"login":"swordmaster2k","id":3354016,"avatar_url":"https://avatars.githubusercontent.com/u/3354016?v=3","gravatar_id":"","url":"https://api.github.com/users/swordmaster2k","html_url":"https://github.com/swordmaster2k","followers_url":"https://api.github.com/users/swordmaster2k/followers","following_url":"https://api.github.com/users/swordmaster2k/following{/other_user}","gists_url":"https://api.github.com/users/swordmaster2k/gists{/gist_id}","starred_url":"https://api.github.com/users/swordmaster2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swordmaster2k/subscriptions","organizations_url":"https://api.github.com/users/swordmaster2k/orgs","repos_url":"https://api.github.com/users/swordmaster2k/repos","events_url":"https://api.github.com/users/swordmaster2k/events{/privacy}","received_events_url":"https://api.github.com/users/swordmaster2k/received_events","type":"User","site_admin":false},"created_at":"2015-12-22T12:59:37Z","updated_at":"2015-12-22T12:59:37Z","body":"Personally I don't think we should be prioritizing legacy serializers. I can count the people who are going to directly upgrade projects and assets from 3.x to 4.x on one hand.\r\n\r\nAs Chris pointed out there are enhancements that could be made to the Board class if the mapping to the original binary format was not so rigid.\r\n\r\nIf you need help with integrating these changes into the editor let me know, I prefer to keep my working branches up to date with the core."}}