{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/9128","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/9128/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/9128/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/9128/events","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/9128","id":84087966,"number":9128,"title":"Addon upgrade (partial implementation of #8107)","user":{"login":"marekbiskup","id":11961560,"avatar_url":"https://avatars.githubusercontent.com/u/11961560?v=3","gravatar_id":"","url":"https://api.github.com/users/marekbiskup","html_url":"https://github.com/marekbiskup","followers_url":"https://api.github.com/users/marekbiskup/followers","following_url":"https://api.github.com/users/marekbiskup/following{/other_user}","gists_url":"https://api.github.com/users/marekbiskup/gists{/gist_id}","starred_url":"https://api.github.com/users/marekbiskup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marekbiskup/subscriptions","organizations_url":"https://api.github.com/users/marekbiskup/orgs","repos_url":"https://api.github.com/users/marekbiskup/repos","events_url":"https://api.github.com/users/marekbiskup/events{/privacy}","received_events_url":"https://api.github.com/users/marekbiskup/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"}],"state":"open","locked":false,"assignee":{"login":"zmerlynn","id":4942464,"avatar_url":"https://avatars.githubusercontent.com/u/4942464?v=3","gravatar_id":"","url":"https://api.github.com/users/zmerlynn","html_url":"https://github.com/zmerlynn","followers_url":"https://api.github.com/users/zmerlynn/followers","following_url":"https://api.github.com/users/zmerlynn/following{/other_user}","gists_url":"https://api.github.com/users/zmerlynn/gists{/gist_id}","starred_url":"https://api.github.com/users/zmerlynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmerlynn/subscriptions","organizations_url":"https://api.github.com/users/zmerlynn/orgs","repos_url":"https://api.github.com/users/zmerlynn/repos","events_url":"https://api.github.com/users/zmerlynn/events{/privacy}","received_events_url":"https://api.github.com/users/zmerlynn/received_events","type":"User","site_admin":false},"milestone":null,"comments":12,"created_at":"2015-06-02T16:07:34Z","updated_at":"2015-06-08T08:38:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/9128","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/9128","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/9128.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/9128.patch"},"body":"The minimal version. Probably not much more will go into v1.0, but we may want to resolve several questions.\r\n\r\nlimitations stated in kube-addon-update.sh.\r\n\r\nWhat is handled:\r\n\r\n 1. create new addon services\r\n 1. delete removed addon services\r\n 1. create/delete/update addon replication controllers\r\n   1. update if version is changed, e.g. if the name changes from my-rc-v1 to my-rc-v2\r\n 1. monitoring addon directory (it is checked every 5 minutes) - I don't know if this is necessary\r\n\r\nWhat is missing:\r\n 1. node addons - we hope they will be handled by salt\r\n 2. update when only parameters changed, but the name didn't. (it is particularly important for services\r\n 3. restarting the linux service kube-addon after kube push (somehow it doesn't work)\r\n 4. tests (only manual tests were performed).\r\n 5. robustness (it is bash)\r\n 6. agreement on naming conventions for update - is versioning like \"my-rc-v1\" a good idea?\r\n 7. Agreement whether the monitoring of the add-on dir is necessary\r\n\r\nFuture extensions (probably not for)\r\n 1. rewrite in go\r\n 2. put into a pod\r\n 3. perform rolling update of replication controllers\r\n"},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments/109908347","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/9128#issuecomment-109908347","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/9128","id":109908347,"user":{"login":"marekbiskup","id":11961560,"avatar_url":"https://avatars.githubusercontent.com/u/11961560?v=3","gravatar_id":"","url":"https://api.github.com/users/marekbiskup","html_url":"https://github.com/marekbiskup","followers_url":"https://api.github.com/users/marekbiskup/followers","following_url":"https://api.github.com/users/marekbiskup/following{/other_user}","gists_url":"https://api.github.com/users/marekbiskup/gists{/gist_id}","starred_url":"https://api.github.com/users/marekbiskup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marekbiskup/subscriptions","organizations_url":"https://api.github.com/users/marekbiskup/orgs","repos_url":"https://api.github.com/users/marekbiskup/repos","events_url":"https://api.github.com/users/marekbiskup/events{/privacy}","received_events_url":"https://api.github.com/users/marekbiskup/received_events","type":"User","site_admin":false},"created_at":"2015-06-08T08:38:05Z","updated_at":"2015-06-08T08:38:05Z","body":"@bgrant0607 clarified (in a personal email) that version string ``should be included`` in RC names"}}