{"action":"created","issue":{"url":"https://api.github.com/repos/bqworks/slider-pro/issues/97","labels_url":"https://api.github.com/repos/bqworks/slider-pro/issues/97/labels{/name}","comments_url":"https://api.github.com/repos/bqworks/slider-pro/issues/97/comments","events_url":"https://api.github.com/repos/bqworks/slider-pro/issues/97/events","html_url":"https://github.com/bqworks/slider-pro/issues/97","id":112991654,"number":97,"title":"Thumbnail Panel not scrolling on touch devices","user":{"login":"superluminalK","id":15245502,"avatar_url":"https://avatars.githubusercontent.com/u/15245502?v=3","gravatar_id":"","url":"https://api.github.com/users/superluminalK","html_url":"https://github.com/superluminalK","followers_url":"https://api.github.com/users/superluminalK/followers","following_url":"https://api.github.com/users/superluminalK/following{/other_user}","gists_url":"https://api.github.com/users/superluminalK/gists{/gist_id}","starred_url":"https://api.github.com/users/superluminalK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superluminalK/subscriptions","organizations_url":"https://api.github.com/users/superluminalK/orgs","repos_url":"https://api.github.com/users/superluminalK/repos","events_url":"https://api.github.com/users/superluminalK/events{/privacy}","received_events_url":"https://api.github.com/users/superluminalK/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-23T10:11:06Z","updated_at":"2015-10-26T18:38:07Z","closed_at":null,"body":"I believe I have discovered a bug in your until now exemplary piece of engineering! Can you please help me to solve it?\r\n\r\nFrom what I can see it only occurs when its running on a touch device, which I am simulating in Chrome dev tools (F12). \r\n\r\nI have removed all my CSS in-case that is what's causing it but to no avail. I'm afraid I cant show you as the site is in development but here is the code and my init code and a trace of yours.\r\n\r\nSo, the offending lines are 1798 -> 1804\r\n\r\nif ( previousThumbnailPosition < - this.thumbnailsPosition ) {\r\n\t\t\t\t\tnewThumbnailsPosition =- previousThumbnailPosition;\r\n\r\n// Move the thumbnail scroller to the calculated position\r\nthis._moveThumbnailsTo( newThumbnailsPosition );\r\n\r\nFirstly, I'm not sure if its supposed to be a < - in the first set of brackets ? If I press on a thumbnail that is partially outside the container in a browser session, the thumbnail locates properly. But in Chrome when simulating say an iPad, or Nexus 10, the code before the first brackets runs but it is transformed into a 0 or -0 value which results in it not moving.\r\n\r\nInterestingly, if I place these callbacks on with alerts it works correctly .....\r\n     gotoThumbnail: function ( alert() ) \r\n     thumbnailsMoveComplete: function ( alert() ) \r\n\r\nI hope you can help, if you need more info let me know.\r\n\r\nmy init code is \r\n\t        width: '100%',\r\n\t        height: 410,\r\n\t        arrows: true,\r\n\t        imageScaleMode: 'contain',\r\n\t        buttons: false,\r\n\t        autoplayDelay: 7000,\r\n\t        waitForLayers: true,\r\n\t        thumbnailsPosition: 'left',\r\n\t        thumbnailWidth: 290,\r\n\t        thumbnailHeight: 100,\r\n\t        thumbnailPointer: true,\r\n\t        autoScaleLayers: false,\r\n\r\nI'm using bootstrap 3, the slider markup (only 1 slide for brevity) is \r\n\r\n        <div class=\"sp-slides\">\r\n                    \t<div class=\"sp-slide\">\r\n\t\t\t\t            <img class=\"sp-image\" src=\"../src/css/images/blank.gif\" data-src=\"Images/xxx/xxx.jpg\" />\r\n\t\t\t\t            <div class=\"sp-caption\">xxxxx </div>\r\n\t\t\t            </div>\r\n                </div>\r\n\r\n                <div class=\"sp-thumbnails\">\r\n                                    <div class=\"sp-thumbnail\">\r\n\t\t\t\t                        <div class=\"sp-thumbnail-image-container\">\r\n\t\t\t\t\t                        <img class=\"sp-thumbnail-image\" src=\"Images/LogoVerySmall.png\"/>\r\n\t\t\t\t                        </div>\r\n\t\t\t\t                        <div class=\"sp-thumbnail-text\">\r\n\t\t\t\t\t                        <div class=\"sp-thumbnail-title\">xxxxx</div>\r\n\t\t\t\t\t                        <div class=\"sp-thumbnail-description\">xxxxx</div>\r\n\t\t\t\t                        </div>\r\n\t\t\t                        </div>\r\n                 </div>\r\n\r\n![code_grab](https://cloud.githubusercontent.com/assets/15245502/10689963/a1bdf038-7976-11e5-8e2c-20bba806110a.jpg)\r\n"},"comment":{"url":"https://api.github.com/repos/bqworks/slider-pro/issues/comments/151242087","html_url":"https://github.com/bqworks/slider-pro/issues/97#issuecomment-151242087","issue_url":"https://api.github.com/repos/bqworks/slider-pro/issues/97","id":151242087,"user":{"login":"superluminalK","id":15245502,"avatar_url":"https://avatars.githubusercontent.com/u/15245502?v=3","gravatar_id":"","url":"https://api.github.com/users/superluminalK","html_url":"https://github.com/superluminalK","followers_url":"https://api.github.com/users/superluminalK/followers","following_url":"https://api.github.com/users/superluminalK/following{/other_user}","gists_url":"https://api.github.com/users/superluminalK/gists{/gist_id}","starred_url":"https://api.github.com/users/superluminalK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superluminalK/subscriptions","organizations_url":"https://api.github.com/users/superluminalK/orgs","repos_url":"https://api.github.com/users/superluminalK/repos","events_url":"https://api.github.com/users/superluminalK/events{/privacy}","received_events_url":"https://api.github.com/users/superluminalK/received_events","type":"User","site_admin":false},"created_at":"2015-10-26T18:38:07Z","updated_at":"2015-10-26T18:38:07Z","body":"hi, \n\n \n\nbeen doing some more testing, it works fine on Safari, and Firefox on a touch device, so unless It’s the Chrome emulator, or another issue I don’t actually know.\n\n \n\nSorry to be a pain in your, just trying to help! thanks!\n\n \n\nKieran\n\n \n\nFrom: David Ghiurau [mailto:notifications@github.com] \nSent: 26 October 2015 15:12\nTo: bqworks/slider-pro\nCc: superluminalK\nSubject: Re: [slider-pro] Thumbnail Panel not scrolling on touch devices (#97)\n\n \n\nHi. Did you test on a real touch device? I tested my online examples and they work fine. I also tested it in browserstack.com and Chrome emulator, and it works there as well. So, I think you either have a bug somewhere in your code or a misconfiguration in Chrome.\n\nCheers.\n\n—\nReply to this email directly or view it on GitHub <https://github.com/bqworks/slider-pro/issues/97#issuecomment-151168960> .Image removed by sender.\n\n"}}