{"action":"created","comment":{"url":"https://api.github.com/repos/Lewuathe/storm-cookbook/pulls/comments/24879582","id":24879582,"diff_hunk":"@@ -22,40 +24,46 @@ Attributes\n     <th>Default</th>\n   </tr>\n   <tr>\n-    <td><tt>['storm'][:package]</tt></td>\n+    <td><tt>['storm']['package']</tt></td>\n     <td>String</td>\n     <td>Storm package name for constructing storm cluster</td>\n     <td><tt>apache-storm-0.10.0-SNAPSHOT</tt></td>\n   </tr>\n   \n   <tr>\n-    <td><tt>['storm'][:version]</tt></td>\n+    <td><tt>['storm']['version']</tt></td>\n     <td>String</td>\n     <td>Storm version</td>\n     <td><tt>0.10.0-SNAPSHOT</tt></td>\n   </tr>\n   \n   <tr>\n-    <td><tt>['storm'][:install_dir]</tt></td>\n+    <td><tt>['storm']['install_dir']</tt></td>\n     <td>String</td>\n     <td>Storm package install directory</td>\n     <td><tt>/usr/share/storm</tt></td>\n   </tr>\n   \n   <tr>\n-    <td><tt>['storm'][:zookeeper_ip]</tt></td>\n+    <td><tt>['storm']['zookeeper_ip']</tt></td>\n     <td>String</td>\n-    <td>Zookeeper server IP address</td>\n-    <td><tt>192.168.50.3</tt></td>\n+    <td>Zookeeper server IP addresses.  Set to an array of IPs</td>\n+    <td><tt>[]</tt></td>\n   </tr>\n \n   <tr>\n-    <td><tt>['storm'][:nimbus_ip]</tt></td>\n+    <td><tt>['storm']['nimbus_ip']</tt></td>\n     <td>String</td>\n-    <td>Storm nimbus server IP address</td>\n-    <td><tt>192.168.50.4</tt></td>\n+    <td>Storm nimbus server IP address, or insure nimbus dns name resolves to your nimbus server</td>","path":"README.md","position":61,"original_position":61,"commit_id":"8151868b022a7a12bef3adfbad5a5f83ff6ccad9","original_commit_id":"8151868b022a7a12bef3adfbad5a5f83ff6ccad9","user":{"login":"TD-4242","id":3487671,"avatar_url":"https://avatars.githubusercontent.com/u/3487671?v=3","gravatar_id":"","url":"https://api.github.com/users/TD-4242","html_url":"https://github.com/TD-4242","followers_url":"https://api.github.com/users/TD-4242/followers","following_url":"https://api.github.com/users/TD-4242/following{/other_user}","gists_url":"https://api.github.com/users/TD-4242/gists{/gist_id}","starred_url":"https://api.github.com/users/TD-4242/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TD-4242/subscriptions","organizations_url":"https://api.github.com/users/TD-4242/orgs","repos_url":"https://api.github.com/users/TD-4242/repos","events_url":"https://api.github.com/users/TD-4242/events{/privacy}","received_events_url":"https://api.github.com/users/TD-4242/received_events","type":"User","site_admin":false},"body":"I think Geico has a policy for this, or yes it's a typo.","created_at":"2015-02-18T05:20:08Z","updated_at":"2015-02-18T05:20:08Z","html_url":"https://github.com/Lewuathe/storm-cookbook/pull/4#discussion_r24879582","pull_request_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/Lewuathe/storm-cookbook/pulls/comments/24879582"},"html":{"href":"https://github.com/Lewuathe/storm-cookbook/pull/4#discussion_r24879582"},"pull_request":{"href":"https://api.github.com/repos/Lewuathe/storm-cookbook/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/Lewuathe/storm-cookbook/pulls/4","id":29305235,"html_url":"https://github.com/Lewuathe/storm-cookbook/pull/4","diff_url":"https://github.com/Lewuathe/storm-cookbook/pull/4.diff","patch_url":"https://github.com/Lewuathe/storm-cookbook/pull/4.patch","issue_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/issues/4","number":4,"state":"open","locked":false,"title":"rubocop fixes and install method","user":{"login":"TD-4242","id":3487671,"avatar_url":"https://avatars.githubusercontent.com/u/3487671?v=3","gravatar_id":"","url":"https://api.github.com/users/TD-4242","html_url":"https://github.com/TD-4242","followers_url":"https://api.github.com/users/TD-4242/followers","following_url":"https://api.github.com/users/TD-4242/following{/other_user}","gists_url":"https://api.github.com/users/TD-4242/gists{/gist_id}","starred_url":"https://api.github.com/users/TD-4242/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TD-4242/subscriptions","organizations_url":"https://api.github.com/users/TD-4242/orgs","repos_url":"https://api.github.com/users/TD-4242/repos","events_url":"https://api.github.com/users/TD-4242/events{/privacy}","received_events_url":"https://api.github.com/users/TD-4242/received_events","type":"User","site_admin":false},"body":"This includes a lot of fixes for rubocop style complaints.\r\n\r\nAlso added an install_method attribute that can be set to remote file and the cookbook will attempt to download from a provided url rather than having to add the file to the cookbook.","created_at":"2015-02-13T22:35:54Z","updated_at":"2015-02-18T05:20:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73e43bbb54394f45a0317e2b4d8af408012c0b36","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/pulls/4/commits","review_comments_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/pulls/4/comments","review_comment_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/issues/4/comments","statuses_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/statuses/8151868b022a7a12bef3adfbad5a5f83ff6ccad9","head":{"label":"TD-4242:master","ref":"master","sha":"8151868b022a7a12bef3adfbad5a5f83ff6ccad9","user":{"login":"TD-4242","id":3487671,"avatar_url":"https://avatars.githubusercontent.com/u/3487671?v=3","gravatar_id":"","url":"https://api.github.com/users/TD-4242","html_url":"https://github.com/TD-4242","followers_url":"https://api.github.com/users/TD-4242/followers","following_url":"https://api.github.com/users/TD-4242/following{/other_user}","gists_url":"https://api.github.com/users/TD-4242/gists{/gist_id}","starred_url":"https://api.github.com/users/TD-4242/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TD-4242/subscriptions","organizations_url":"https://api.github.com/users/TD-4242/orgs","repos_url":"https://api.github.com/users/TD-4242/repos","events_url":"https://api.github.com/users/TD-4242/events{/privacy}","received_events_url":"https://api.github.com/users/TD-4242/received_events","type":"User","site_admin":false},"repo":{"id":29617812,"name":"storm-cookbook","full_name":"TD-4242/storm-cookbook","owner":{"login":"TD-4242","id":3487671,"avatar_url":"https://avatars.githubusercontent.com/u/3487671?v=3","gravatar_id":"","url":"https://api.github.com/users/TD-4242","html_url":"https://github.com/TD-4242","followers_url":"https://api.github.com/users/TD-4242/followers","following_url":"https://api.github.com/users/TD-4242/following{/other_user}","gists_url":"https://api.github.com/users/TD-4242/gists{/gist_id}","starred_url":"https://api.github.com/users/TD-4242/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TD-4242/subscriptions","organizations_url":"https://api.github.com/users/TD-4242/orgs","repos_url":"https://api.github.com/users/TD-4242/repos","events_url":"https://api.github.com/users/TD-4242/events{/privacy}","received_events_url":"https://api.github.com/users/TD-4242/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TD-4242/storm-cookbook","description":"Chef cookbook for storm","fork":true,"url":"https://api.github.com/repos/TD-4242/storm-cookbook","forks_url":"https://api.github.com/repos/TD-4242/storm-cookbook/forks","keys_url":"https://api.github.com/repos/TD-4242/storm-cookbook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TD-4242/storm-cookbook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TD-4242/storm-cookbook/teams","hooks_url":"https://api.github.com/repos/TD-4242/storm-cookbook/hooks","issue_events_url":"https://api.github.com/repos/TD-4242/storm-cookbook/issues/events{/number}","events_url":"https://api.github.com/repos/TD-4242/storm-cookbook/events","assignees_url":"https://api.github.com/repos/TD-4242/storm-cookbook/assignees{/user}","branches_url":"https://api.github.com/repos/TD-4242/storm-cookbook/branches{/branch}","tags_url":"https://api.github.com/repos/TD-4242/storm-cookbook/tags","blobs_url":"https://api.github.com/repos/TD-4242/storm-cookbook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TD-4242/storm-cookbook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TD-4242/storm-cookbook/git/refs{/sha}","trees_url":"https://api.github.com/repos/TD-4242/storm-cookbook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TD-4242/storm-cookbook/statuses/{sha}","languages_url":"https://api.github.com/repos/TD-4242/storm-cookbook/languages","stargazers_url":"https://api.github.com/repos/TD-4242/storm-cookbook/stargazers","contributors_url":"https://api.github.com/repos/TD-4242/storm-cookbook/contributors","subscribers_url":"https://api.github.com/repos/TD-4242/storm-cookbook/subscribers","subscription_url":"https://api.github.com/repos/TD-4242/storm-cookbook/subscription","commits_url":"https://api.github.com/repos/TD-4242/storm-cookbook/commits{/sha}","git_commits_url":"https://api.github.com/repos/TD-4242/storm-cookbook/git/commits{/sha}","comments_url":"https://api.github.com/repos/TD-4242/storm-cookbook/comments{/number}","issue_comment_url":"https://api.github.com/repos/TD-4242/storm-cookbook/issues/comments/{number}","contents_url":"https://api.github.com/repos/TD-4242/storm-cookbook/contents/{+path}","compare_url":"https://api.github.com/repos/TD-4242/storm-cookbook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TD-4242/storm-cookbook/merges","archive_url":"https://api.github.com/repos/TD-4242/storm-cookbook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TD-4242/storm-cookbook/downloads","issues_url":"https://api.github.com/repos/TD-4242/storm-cookbook/issues{/number}","pulls_url":"https://api.github.com/repos/TD-4242/storm-cookbook/pulls{/number}","milestones_url":"https://api.github.com/repos/TD-4242/storm-cookbook/milestones{/number}","notifications_url":"https://api.github.com/repos/TD-4242/storm-cookbook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TD-4242/storm-cookbook/labels{/name}","releases_url":"https://api.github.com/repos/TD-4242/storm-cookbook/releases{/id}","created_at":"2015-01-21T21:40:09Z","updated_at":"2015-02-17T14:34:07Z","pushed_at":"2015-02-17T22:51:33Z","git_url":"git://github.com/TD-4242/storm-cookbook.git","ssh_url":"git@github.com:TD-4242/storm-cookbook.git","clone_url":"https://github.com/TD-4242/storm-cookbook.git","svn_url":"https://github.com/TD-4242/storm-cookbook","homepage":null,"size":188,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Lewuathe:master","ref":"master","sha":"325b2525ff37be452e942f789e4187c077e452fa","user":{"login":"Lewuathe","id":1713047,"avatar_url":"https://avatars.githubusercontent.com/u/1713047?v=3","gravatar_id":"","url":"https://api.github.com/users/Lewuathe","html_url":"https://github.com/Lewuathe","followers_url":"https://api.github.com/users/Lewuathe/followers","following_url":"https://api.github.com/users/Lewuathe/following{/other_user}","gists_url":"https://api.github.com/users/Lewuathe/gists{/gist_id}","starred_url":"https://api.github.com/users/Lewuathe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lewuathe/subscriptions","organizations_url":"https://api.github.com/users/Lewuathe/orgs","repos_url":"https://api.github.com/users/Lewuathe/repos","events_url":"https://api.github.com/users/Lewuathe/events{/privacy}","received_events_url":"https://api.github.com/users/Lewuathe/received_events","type":"User","site_admin":false},"repo":{"id":29392379,"name":"storm-cookbook","full_name":"Lewuathe/storm-cookbook","owner":{"login":"Lewuathe","id":1713047,"avatar_url":"https://avatars.githubusercontent.com/u/1713047?v=3","gravatar_id":"","url":"https://api.github.com/users/Lewuathe","html_url":"https://github.com/Lewuathe","followers_url":"https://api.github.com/users/Lewuathe/followers","following_url":"https://api.github.com/users/Lewuathe/following{/other_user}","gists_url":"https://api.github.com/users/Lewuathe/gists{/gist_id}","starred_url":"https://api.github.com/users/Lewuathe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lewuathe/subscriptions","organizations_url":"https://api.github.com/users/Lewuathe/orgs","repos_url":"https://api.github.com/users/Lewuathe/repos","events_url":"https://api.github.com/users/Lewuathe/events{/privacy}","received_events_url":"https://api.github.com/users/Lewuathe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Lewuathe/storm-cookbook","description":"Chef cookbook for storm","fork":false,"url":"https://api.github.com/repos/Lewuathe/storm-cookbook","forks_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/forks","keys_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/teams","hooks_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/hooks","issue_events_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/issues/events{/number}","events_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/events","assignees_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/assignees{/user}","branches_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/branches{/branch}","tags_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/tags","blobs_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/statuses/{sha}","languages_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/languages","stargazers_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/stargazers","contributors_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/contributors","subscribers_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/subscribers","subscription_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/subscription","commits_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/issues/comments/{number}","contents_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/contents/{+path}","compare_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/merges","archive_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/downloads","issues_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/issues{/number}","pulls_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/pulls{/number}","milestones_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/milestones{/number}","notifications_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/labels{/name}","releases_url":"https://api.github.com/repos/Lewuathe/storm-cookbook/releases{/id}","created_at":"2015-01-17T13:45:40Z","updated_at":"2015-02-09T12:42:21Z","pushed_at":"2015-02-09T12:42:20Z","git_url":"git://github.com/Lewuathe/storm-cookbook.git","ssh_url":"git@github.com:Lewuathe/storm-cookbook.git","clone_url":"https://github.com/Lewuathe/storm-cookbook.git","svn_url":"https://github.com/Lewuathe/storm-cookbook","homepage":null,"size":296,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Lewuathe/storm-cookbook/pulls/4"},"html":{"href":"https://github.com/Lewuathe/storm-cookbook/pull/4"},"issue":{"href":"https://api.github.com/repos/Lewuathe/storm-cookbook/issues/4"},"comments":{"href":"https://api.github.com/repos/Lewuathe/storm-cookbook/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/Lewuathe/storm-cookbook/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/Lewuathe/storm-cookbook/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Lewuathe/storm-cookbook/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/Lewuathe/storm-cookbook/statuses/8151868b022a7a12bef3adfbad5a5f83ff6ccad9"}}}}