{"action":"created","comment":{"url":"https://api.github.com/repos/sprangular/sprangular/pulls/comments/25469976","id":25469976,"diff_hunk":"@@ -52,9 +52,11 @@ Sprangular.service \"Account\", ($http, _, $q, Cart, Flash) ->\n       $http.post '/spree/login.json', $.param params\n         .success (data) ->\n           service.populateAccount(data)\n-          Flash.success 'Successfully signed in'\n+          $translate('app.signed_in').then (paragraph) ->\n+            Flash.success paragraph\n         .error ->\n-          Flash.error 'Sign in failed'\n+          $translate('app.signin_failed').then (paragraph) ->","path":"app/assets/javascripts/sprangular/services/account.coffee","position":15,"original_position":15,"commit_id":"323859fcce0d410b9ed1189074a79eb14356e0d5","original_commit_id":"cb0d45b35b6e44c1d079290a600db9667050481b","user":{"login":"rposborne","id":243989,"avatar_url":"https://avatars.githubusercontent.com/u/243989?v=3","gravatar_id":"","url":"https://api.github.com/users/rposborne","html_url":"https://github.com/rposborne","followers_url":"https://api.github.com/users/rposborne/followers","following_url":"https://api.github.com/users/rposborne/following{/other_user}","gists_url":"https://api.github.com/users/rposborne/gists{/gist_id}","starred_url":"https://api.github.com/users/rposborne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rposborne/subscriptions","organizations_url":"https://api.github.com/users/rposborne/orgs","repos_url":"https://api.github.com/users/rposborne/repos","events_url":"https://api.github.com/users/rposborne/events{/privacy}","received_events_url":"https://api.github.com/users/rposborne/received_events","type":"User","site_admin":false},"body":"Agreed,  to be fair. I haven't been thinking much on this.  Just bulldozing.  Give me a sec and i'll refactor Flash. ","created_at":"2015-02-26T22:09:58Z","updated_at":"2015-02-26T22:09:58Z","html_url":"https://github.com/sprangular/sprangular/pull/87#discussion_r25469976","pull_request_url":"https://api.github.com/repos/sprangular/sprangular/pulls/87","_links":{"self":{"href":"https://api.github.com/repos/sprangular/sprangular/pulls/comments/25469976"},"html":{"href":"https://github.com/sprangular/sprangular/pull/87#discussion_r25469976"},"pull_request":{"href":"https://api.github.com/repos/sprangular/sprangular/pulls/87"}}},"pull_request":{"url":"https://api.github.com/repos/sprangular/sprangular/pulls/87","id":29826157,"html_url":"https://github.com/sprangular/sprangular/pull/87","diff_url":"https://github.com/sprangular/sprangular/pull/87.diff","patch_url":"https://github.com/sprangular/sprangular/pull/87.patch","issue_url":"https://api.github.com/repos/sprangular/sprangular/issues/87","number":87,"state":"open","locked":false,"title":"I18n translations + currency (in progress)","user":{"login":"rposborne","id":243989,"avatar_url":"https://avatars.githubusercontent.com/u/243989?v=3","gravatar_id":"","url":"https://api.github.com/users/rposborne","html_url":"https://github.com/rposborne","followers_url":"https://api.github.com/users/rposborne/followers","following_url":"https://api.github.com/users/rposborne/following{/other_user}","gists_url":"https://api.github.com/users/rposborne/gists{/gist_id}","starred_url":"https://api.github.com/users/rposborne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rposborne/subscriptions","organizations_url":"https://api.github.com/users/rposborne/orgs","repos_url":"https://api.github.com/users/rposborne/repos","events_url":"https://api.github.com/users/rposborne/events{/privacy}","received_events_url":"https://api.github.com/users/rposborne/received_events","type":"User","site_admin":false},"body":"This is a twofold solution using both Rails translated files and JS translation.  \r\n\r\n- [x] Use Rails i18n to primarily translate templates. \r\n- [x] Use angular-translate to allow for translation in JS\r\n- [x] Expose Rails i18n translation to JS via js environment. \r\n- [x] Set session[:locale] for support with spree_i18n \r\n- [x] Handle switch locale via get request + redirect\r\n- [x] Verify that templates are properly cached by locale\r\n- [x] Handle an angular locale where the store does not support the locale's currency @joshnuss thoughts?\r\n- [x] Add Method to set allowed locales (piggy back of spree_i18n?)\r\n- [x] Establish intent of bourbon branch before modifying all templates :smile: \r\n- [x] Translate all templates\r\n- [x] Translate all flash messages\r\n- [x] Translate all page titles\r\n- [x] Add German Translation","created_at":"2015-02-23T17:08:37Z","updated_at":"2015-02-26T22:09:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd9cac8ecb390220e88522f2460d23b5e1675120","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sprangular/sprangular/pulls/87/commits","review_comments_url":"https://api.github.com/repos/sprangular/sprangular/pulls/87/comments","review_comment_url":"https://api.github.com/repos/sprangular/sprangular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sprangular/sprangular/issues/87/comments","statuses_url":"https://api.github.com/repos/sprangular/sprangular/statuses/323859fcce0d410b9ed1189074a79eb14356e0d5","head":{"label":"rposborne:i18n-currency","ref":"i18n-currency","sha":"323859fcce0d410b9ed1189074a79eb14356e0d5","user":{"login":"rposborne","id":243989,"avatar_url":"https://avatars.githubusercontent.com/u/243989?v=3","gravatar_id":"","url":"https://api.github.com/users/rposborne","html_url":"https://github.com/rposborne","followers_url":"https://api.github.com/users/rposborne/followers","following_url":"https://api.github.com/users/rposborne/following{/other_user}","gists_url":"https://api.github.com/users/rposborne/gists{/gist_id}","starred_url":"https://api.github.com/users/rposborne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rposborne/subscriptions","organizations_url":"https://api.github.com/users/rposborne/orgs","repos_url":"https://api.github.com/users/rposborne/repos","events_url":"https://api.github.com/users/rposborne/events{/privacy}","received_events_url":"https://api.github.com/users/rposborne/received_events","type":"User","site_admin":false},"repo":{"id":25781074,"name":"sprangular","full_name":"rposborne/sprangular","owner":{"login":"rposborne","id":243989,"avatar_url":"https://avatars.githubusercontent.com/u/243989?v=3","gravatar_id":"","url":"https://api.github.com/users/rposborne","html_url":"https://github.com/rposborne","followers_url":"https://api.github.com/users/rposborne/followers","following_url":"https://api.github.com/users/rposborne/following{/other_user}","gists_url":"https://api.github.com/users/rposborne/gists{/gist_id}","starred_url":"https://api.github.com/users/rposborne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rposborne/subscriptions","organizations_url":"https://api.github.com/users/rposborne/orgs","repos_url":"https://api.github.com/users/rposborne/repos","events_url":"https://api.github.com/users/rposborne/events{/privacy}","received_events_url":"https://api.github.com/users/rposborne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rposborne/sprangular","description":"Spree + Angular.js frontend","fork":true,"url":"https://api.github.com/repos/rposborne/sprangular","forks_url":"https://api.github.com/repos/rposborne/sprangular/forks","keys_url":"https://api.github.com/repos/rposborne/sprangular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rposborne/sprangular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rposborne/sprangular/teams","hooks_url":"https://api.github.com/repos/rposborne/sprangular/hooks","issue_events_url":"https://api.github.com/repos/rposborne/sprangular/issues/events{/number}","events_url":"https://api.github.com/repos/rposborne/sprangular/events","assignees_url":"https://api.github.com/repos/rposborne/sprangular/assignees{/user}","branches_url":"https://api.github.com/repos/rposborne/sprangular/branches{/branch}","tags_url":"https://api.github.com/repos/rposborne/sprangular/tags","blobs_url":"https://api.github.com/repos/rposborne/sprangular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rposborne/sprangular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rposborne/sprangular/git/refs{/sha}","trees_url":"https://api.github.com/repos/rposborne/sprangular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rposborne/sprangular/statuses/{sha}","languages_url":"https://api.github.com/repos/rposborne/sprangular/languages","stargazers_url":"https://api.github.com/repos/rposborne/sprangular/stargazers","contributors_url":"https://api.github.com/repos/rposborne/sprangular/contributors","subscribers_url":"https://api.github.com/repos/rposborne/sprangular/subscribers","subscription_url":"https://api.github.com/repos/rposborne/sprangular/subscription","commits_url":"https://api.github.com/repos/rposborne/sprangular/commits{/sha}","git_commits_url":"https://api.github.com/repos/rposborne/sprangular/git/commits{/sha}","comments_url":"https://api.github.com/repos/rposborne/sprangular/comments{/number}","issue_comment_url":"https://api.github.com/repos/rposborne/sprangular/issues/comments{/number}","contents_url":"https://api.github.com/repos/rposborne/sprangular/contents/{+path}","compare_url":"https://api.github.com/repos/rposborne/sprangular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rposborne/sprangular/merges","archive_url":"https://api.github.com/repos/rposborne/sprangular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rposborne/sprangular/downloads","issues_url":"https://api.github.com/repos/rposborne/sprangular/issues{/number}","pulls_url":"https://api.github.com/repos/rposborne/sprangular/pulls{/number}","milestones_url":"https://api.github.com/repos/rposborne/sprangular/milestones{/number}","notifications_url":"https://api.github.com/repos/rposborne/sprangular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rposborne/sprangular/labels{/name}","releases_url":"https://api.github.com/repos/rposborne/sprangular/releases{/id}","created_at":"2014-10-26T16:38:38Z","updated_at":"2015-02-26T20:23:40Z","pushed_at":"2015-02-26T22:01:57Z","git_url":"git://github.com/rposborne/sprangular.git","ssh_url":"git@github.com:rposborne/sprangular.git","clone_url":"https://github.com/rposborne/sprangular.git","svn_url":"https://github.com/rposborne/sprangular","homepage":null,"size":2997,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sprangular:master","ref":"master","sha":"afcc91a3a9683932c8f1fd479457328ae40dae0e","user":{"login":"sprangular","id":10926453,"avatar_url":"https://avatars.githubusercontent.com/u/10926453?v=3","gravatar_id":"","url":"https://api.github.com/users/sprangular","html_url":"https://github.com/sprangular","followers_url":"https://api.github.com/users/sprangular/followers","following_url":"https://api.github.com/users/sprangular/following{/other_user}","gists_url":"https://api.github.com/users/sprangular/gists{/gist_id}","starred_url":"https://api.github.com/users/sprangular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sprangular/subscriptions","organizations_url":"https://api.github.com/users/sprangular/orgs","repos_url":"https://api.github.com/users/sprangular/repos","events_url":"https://api.github.com/users/sprangular/events{/privacy}","received_events_url":"https://api.github.com/users/sprangular/received_events","type":"Organization","site_admin":false},"repo":{"id":22926972,"name":"sprangular","full_name":"sprangular/sprangular","owner":{"login":"sprangular","id":10926453,"avatar_url":"https://avatars.githubusercontent.com/u/10926453?v=3","gravatar_id":"","url":"https://api.github.com/users/sprangular","html_url":"https://github.com/sprangular","followers_url":"https://api.github.com/users/sprangular/followers","following_url":"https://api.github.com/users/sprangular/following{/other_user}","gists_url":"https://api.github.com/users/sprangular/gists{/gist_id}","starred_url":"https://api.github.com/users/sprangular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sprangular/subscriptions","organizations_url":"https://api.github.com/users/sprangular/orgs","repos_url":"https://api.github.com/users/sprangular/repos","events_url":"https://api.github.com/users/sprangular/events{/privacy}","received_events_url":"https://api.github.com/users/sprangular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sprangular/sprangular","description":"Spree + Angular.js frontend","fork":false,"url":"https://api.github.com/repos/sprangular/sprangular","forks_url":"https://api.github.com/repos/sprangular/sprangular/forks","keys_url":"https://api.github.com/repos/sprangular/sprangular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sprangular/sprangular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sprangular/sprangular/teams","hooks_url":"https://api.github.com/repos/sprangular/sprangular/hooks","issue_events_url":"https://api.github.com/repos/sprangular/sprangular/issues/events{/number}","events_url":"https://api.github.com/repos/sprangular/sprangular/events","assignees_url":"https://api.github.com/repos/sprangular/sprangular/assignees{/user}","branches_url":"https://api.github.com/repos/sprangular/sprangular/branches{/branch}","tags_url":"https://api.github.com/repos/sprangular/sprangular/tags","blobs_url":"https://api.github.com/repos/sprangular/sprangular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sprangular/sprangular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sprangular/sprangular/git/refs{/sha}","trees_url":"https://api.github.com/repos/sprangular/sprangular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sprangular/sprangular/statuses/{sha}","languages_url":"https://api.github.com/repos/sprangular/sprangular/languages","stargazers_url":"https://api.github.com/repos/sprangular/sprangular/stargazers","contributors_url":"https://api.github.com/repos/sprangular/sprangular/contributors","subscribers_url":"https://api.github.com/repos/sprangular/sprangular/subscribers","subscription_url":"https://api.github.com/repos/sprangular/sprangular/subscription","commits_url":"https://api.github.com/repos/sprangular/sprangular/commits{/sha}","git_commits_url":"https://api.github.com/repos/sprangular/sprangular/git/commits{/sha}","comments_url":"https://api.github.com/repos/sprangular/sprangular/comments{/number}","issue_comment_url":"https://api.github.com/repos/sprangular/sprangular/issues/comments{/number}","contents_url":"https://api.github.com/repos/sprangular/sprangular/contents/{+path}","compare_url":"https://api.github.com/repos/sprangular/sprangular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sprangular/sprangular/merges","archive_url":"https://api.github.com/repos/sprangular/sprangular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sprangular/sprangular/downloads","issues_url":"https://api.github.com/repos/sprangular/sprangular/issues{/number}","pulls_url":"https://api.github.com/repos/sprangular/sprangular/pulls{/number}","milestones_url":"https://api.github.com/repos/sprangular/sprangular/milestones{/number}","notifications_url":"https://api.github.com/repos/sprangular/sprangular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sprangular/sprangular/labels{/name}","releases_url":"https://api.github.com/repos/sprangular/sprangular/releases{/id}","created_at":"2014-08-13T18:43:03Z","updated_at":"2015-02-26T02:48:22Z","pushed_at":"2015-02-26T02:48:22Z","git_url":"git://github.com/sprangular/sprangular.git","ssh_url":"git@github.com:sprangular/sprangular.git","clone_url":"https://github.com/sprangular/sprangular.git","svn_url":"https://github.com/sprangular/sprangular","homepage":null,"size":5628,"stargazers_count":33,"watchers_count":33,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":18,"forks":11,"open_issues":18,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sprangular/sprangular/pulls/87"},"html":{"href":"https://github.com/sprangular/sprangular/pull/87"},"issue":{"href":"https://api.github.com/repos/sprangular/sprangular/issues/87"},"comments":{"href":"https://api.github.com/repos/sprangular/sprangular/issues/87/comments"},"review_comments":{"href":"https://api.github.com/repos/sprangular/sprangular/pulls/87/comments"},"review_comment":{"href":"https://api.github.com/repos/sprangular/sprangular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sprangular/sprangular/pulls/87/commits"},"statuses":{"href":"https://api.github.com/repos/sprangular/sprangular/statuses/323859fcce0d410b9ed1189074a79eb14356e0d5"}}}}