{"action":"created","issue":{"url":"https://api.github.com/repos/hishamhm/htop/issues/268","labels_url":"https://api.github.com/repos/hishamhm/htop/issues/268/labels{/name}","comments_url":"https://api.github.com/repos/hishamhm/htop/issues/268/comments","events_url":"https://api.github.com/repos/hishamhm/htop/issues/268/events","html_url":"https://github.com/hishamhm/htop/pull/268","id":105811616,"number":268,"title":"Darwin fixes - duplicate & conflicting decls","user":{"login":"jweyrich","id":206930,"avatar_url":"https://avatars.githubusercontent.com/u/206930?v=3","gravatar_id":"","url":"https://api.github.com/users/jweyrich","html_url":"https://github.com/jweyrich","followers_url":"https://api.github.com/users/jweyrich/followers","following_url":"https://api.github.com/users/jweyrich/following{/other_user}","gists_url":"https://api.github.com/users/jweyrich/gists{/gist_id}","starred_url":"https://api.github.com/users/jweyrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jweyrich/subscriptions","organizations_url":"https://api.github.com/users/jweyrich/orgs","repos_url":"https://api.github.com/users/jweyrich/repos","events_url":"https://api.github.com/users/jweyrich/events{/privacy}","received_events_url":"https://api.github.com/users/jweyrich/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-10T13:58:19Z","updated_at":"2015-09-10T19:42:13Z","closed_at":"2015-09-10T19:41:53Z","pull_request":{"url":"https://api.github.com/repos/hishamhm/htop/pulls/268","html_url":"https://github.com/hishamhm/htop/pull/268","diff_url":"https://github.com/hishamhm/htop/pull/268.diff","patch_url":"https://github.com/hishamhm/htop/pull/268.patch"},"body":"My first contribution to the project :-)\r\n\r\nCompilation on Mac OS X fails due to duplicate and conflicting declarations of `Process_pidFormat`.\r\n\r\n`darwin/Platform.c` declares `char* Process_pidFormat` while `process.c` declares `char Process_pidFormat[20]`, and there are some extern declarations on other places referring to _it_ as well.\r\n\r\nI did a blind-fix just to compile and get it running on OS X - I haven't analysed the code to understand the logic behind having different declarations, and mainly if my changes will affect the behaviour in other platforms, so **be cautions on accepting this PR**.\r\n\r\nAnother important thing is that `autogen.sh` did fail on my OS X (10.10.5) because it couldn't find `libtoolize` (which doesn't seem to come with Xcode, nor is provided by Homebrew), so I did run `glibtoolize` instead, which does the equivalent.\r\n\r\nFinally, nice work on getting it to run on Darwin! :-) Kudos!"},"comment":{"url":"https://api.github.com/repos/hishamhm/htop/issues/comments/139357377","html_url":"https://github.com/hishamhm/htop/pull/268#issuecomment-139357377","issue_url":"https://api.github.com/repos/hishamhm/htop/issues/268","id":139357377,"user":{"login":"hishamhm","id":245621,"avatar_url":"https://avatars.githubusercontent.com/u/245621?v=3","gravatar_id":"","url":"https://api.github.com/users/hishamhm","html_url":"https://github.com/hishamhm","followers_url":"https://api.github.com/users/hishamhm/followers","following_url":"https://api.github.com/users/hishamhm/following{/other_user}","gists_url":"https://api.github.com/users/hishamhm/gists{/gist_id}","starred_url":"https://api.github.com/users/hishamhm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hishamhm/subscriptions","organizations_url":"https://api.github.com/users/hishamhm/orgs","repos_url":"https://api.github.com/users/hishamhm/repos","events_url":"https://api.github.com/users/hishamhm/events{/privacy}","received_events_url":"https://api.github.com/users/hishamhm/received_events","type":"User","site_admin":false},"created_at":"2015-09-10T19:42:13Z","updated_at":"2015-09-10T19:42:13Z","body":"Thank you!\r\nIs `glibtoolize` provided by Xcode or Homebrew?"}}