{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/pulls/2","id":39261276,"html_url":"https://github.com/benbria/node-lumberjack-protocol/pull/2","diff_url":"https://github.com/benbria/node-lumberjack-protocol/pull/2.diff","patch_url":"https://github.com/benbria/node-lumberjack-protocol/pull/2.patch","issue_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/issues/2","number":2,"state":"closed","locked":false,"title":"Fixed reference error in ClientSocket.coffee","user":{"login":"elssar","id":1042301,"avatar_url":"https://avatars.githubusercontent.com/u/1042301?v=3","gravatar_id":"","url":"https://api.github.com/users/elssar","html_url":"https://github.com/elssar","followers_url":"https://api.github.com/users/elssar/followers","following_url":"https://api.github.com/users/elssar/following{/other_user}","gists_url":"https://api.github.com/users/elssar/gists{/gist_id}","starred_url":"https://api.github.com/users/elssar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elssar/subscriptions","organizations_url":"https://api.github.com/users/elssar/orgs","repos_url":"https://api.github.com/users/elssar/repos","events_url":"https://api.github.com/users/elssar/events{/privacy}","received_events_url":"https://api.github.com/users/elssar/received_events","type":"User","site_admin":false},"body":"`TooShortError`, which is defined in `lumberjack.coffee`, was used as if it were a global variable in `ClientSocket.coffee`, which caused this exception\r\n\r\n```\r\nReferenceError: TooShortError is not defined\r\n     at Error.DroppedError (/home/elssar/apps/log-forwarder/node_modules/lumberjack-protocol/lib/ClientSocket.js:23:35)\r\n     at ClientSocket.writeDataFrame (/home/elssar/apps/log-forwarder/node_modules/lumberjack-protocol/lib/ClientSocket.js:112:21)\r\n     at Client.writeDataFrame (/home/elssar/apps/log-forwarder/node_modules/lumberjack-protocol/lib/Client.js:59:29)\r\n     at /home/elssar/apps/log-forwarder/api/services/LogstashService.js:126:18\r\n     at Array.forEach (native)\r\n     at /home/elssar/apps/log-forwarder/api/services/LogstashService.js:125:19\r\n     at fn (/home/elssar/apps/log-forwarder/node_modules/sails/node_modules/async/lib/async.js:641:34)\r\n     at Immediate._onImmediate (/home/elssar/apps/log-forwarder/node_modules/sails/node_modules/async/lib/async.js:557:34)\r\n     at processImmediate [as _immediateCallback] (timers.js:358:17)\r\n```\r\n","created_at":"2015-07-06T12:11:49Z","updated_at":"2015-07-23T04:26:33Z","closed_at":"2015-07-23T04:26:32Z","merged_at":"2015-07-23T04:26:32Z","merge_commit_sha":"1139fe2c0455ed42a27aac5f77c3ff18549290d1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/pulls/2/commits","review_comments_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/pulls/2/comments","review_comment_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/pulls/comments{/number}","comments_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/issues/2/comments","statuses_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/statuses/d95f6226761d14ee695aba30990acbe64803a944","head":{"label":"elssar:fix-reference-error","ref":"fix-reference-error","sha":"d95f6226761d14ee695aba30990acbe64803a944","user":{"login":"elssar","id":1042301,"avatar_url":"https://avatars.githubusercontent.com/u/1042301?v=3","gravatar_id":"","url":"https://api.github.com/users/elssar","html_url":"https://github.com/elssar","followers_url":"https://api.github.com/users/elssar/followers","following_url":"https://api.github.com/users/elssar/following{/other_user}","gists_url":"https://api.github.com/users/elssar/gists{/gist_id}","starred_url":"https://api.github.com/users/elssar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elssar/subscriptions","organizations_url":"https://api.github.com/users/elssar/orgs","repos_url":"https://api.github.com/users/elssar/repos","events_url":"https://api.github.com/users/elssar/events{/privacy}","received_events_url":"https://api.github.com/users/elssar/received_events","type":"User","site_admin":false},"repo":{"id":38615567,"name":"node-lumberjack-protocol","full_name":"elssar/node-lumberjack-protocol","owner":{"login":"elssar","id":1042301,"avatar_url":"https://avatars.githubusercontent.com/u/1042301?v=3","gravatar_id":"","url":"https://api.github.com/users/elssar","html_url":"https://github.com/elssar","followers_url":"https://api.github.com/users/elssar/followers","following_url":"https://api.github.com/users/elssar/following{/other_user}","gists_url":"https://api.github.com/users/elssar/gists{/gist_id}","starred_url":"https://api.github.com/users/elssar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elssar/subscriptions","organizations_url":"https://api.github.com/users/elssar/orgs","repos_url":"https://api.github.com/users/elssar/repos","events_url":"https://api.github.com/users/elssar/events{/privacy}","received_events_url":"https://api.github.com/users/elssar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elssar/node-lumberjack-protocol","description":"Node.js implementation of the lumberjack protocol.","fork":true,"url":"https://api.github.com/repos/elssar/node-lumberjack-protocol","forks_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/forks","keys_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/teams","hooks_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/hooks","issue_events_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/issues/events{/number}","events_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/events","assignees_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/assignees{/user}","branches_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/branches{/branch}","tags_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/tags","blobs_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/git/refs{/sha}","trees_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/statuses/{sha}","languages_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/languages","stargazers_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/stargazers","contributors_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/contributors","subscribers_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/subscribers","subscription_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/subscription","commits_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/commits{/sha}","git_commits_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/git/commits{/sha}","comments_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/comments{/number}","issue_comment_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/issues/comments{/number}","contents_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/contents/{+path}","compare_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/merges","archive_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/downloads","issues_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/issues{/number}","pulls_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/pulls{/number}","milestones_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/milestones{/number}","notifications_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/labels{/name}","releases_url":"https://api.github.com/repos/elssar/node-lumberjack-protocol/releases{/id}","created_at":"2015-07-06T11:48:34Z","updated_at":"2015-07-06T11:48:34Z","pushed_at":"2015-07-06T12:07:59Z","git_url":"git://github.com/elssar/node-lumberjack-protocol.git","ssh_url":"git@github.com:elssar/node-lumberjack-protocol.git","clone_url":"https://github.com/elssar/node-lumberjack-protocol.git","svn_url":"https://github.com/elssar/node-lumberjack-protocol","homepage":null,"size":98,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"benbria:master","ref":"master","sha":"cbed60558f7b59b026916cadcead2bb48b7a746f","user":{"login":"benbria","id":1638248,"avatar_url":"https://avatars.githubusercontent.com/u/1638248?v=3","gravatar_id":"","url":"https://api.github.com/users/benbria","html_url":"https://github.com/benbria","followers_url":"https://api.github.com/users/benbria/followers","following_url":"https://api.github.com/users/benbria/following{/other_user}","gists_url":"https://api.github.com/users/benbria/gists{/gist_id}","starred_url":"https://api.github.com/users/benbria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbria/subscriptions","organizations_url":"https://api.github.com/users/benbria/orgs","repos_url":"https://api.github.com/users/benbria/repos","events_url":"https://api.github.com/users/benbria/events{/privacy}","received_events_url":"https://api.github.com/users/benbria/received_events","type":"Organization","site_admin":false},"repo":{"id":29698045,"name":"node-lumberjack-protocol","full_name":"benbria/node-lumberjack-protocol","owner":{"login":"benbria","id":1638248,"avatar_url":"https://avatars.githubusercontent.com/u/1638248?v=3","gravatar_id":"","url":"https://api.github.com/users/benbria","html_url":"https://github.com/benbria","followers_url":"https://api.github.com/users/benbria/followers","following_url":"https://api.github.com/users/benbria/following{/other_user}","gists_url":"https://api.github.com/users/benbria/gists{/gist_id}","starred_url":"https://api.github.com/users/benbria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbria/subscriptions","organizations_url":"https://api.github.com/users/benbria/orgs","repos_url":"https://api.github.com/users/benbria/repos","events_url":"https://api.github.com/users/benbria/events{/privacy}","received_events_url":"https://api.github.com/users/benbria/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/benbria/node-lumberjack-protocol","description":"Node.js implementation of the lumberjack protocol.","fork":false,"url":"https://api.github.com/repos/benbria/node-lumberjack-protocol","forks_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/forks","keys_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/teams","hooks_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/hooks","issue_events_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/issues/events{/number}","events_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/events","assignees_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/assignees{/user}","branches_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/branches{/branch}","tags_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/tags","blobs_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/git/refs{/sha}","trees_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/statuses/{sha}","languages_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/languages","stargazers_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/stargazers","contributors_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/contributors","subscribers_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/subscribers","subscription_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/subscription","commits_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/commits{/sha}","git_commits_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/git/commits{/sha}","comments_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/comments{/number}","issue_comment_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/issues/comments{/number}","contents_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/contents/{+path}","compare_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/merges","archive_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/downloads","issues_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/issues{/number}","pulls_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/pulls{/number}","milestones_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/milestones{/number}","notifications_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/labels{/name}","releases_url":"https://api.github.com/repos/benbria/node-lumberjack-protocol/releases{/id}","created_at":"2015-01-22T20:16:48Z","updated_at":"2015-06-28T21:40:43Z","pushed_at":"2015-07-23T04:26:33Z","git_url":"git://github.com/benbria/node-lumberjack-protocol.git","ssh_url":"git@github.com:benbria/node-lumberjack-protocol.git","clone_url":"https://github.com/benbria/node-lumberjack-protocol.git","svn_url":"https://github.com/benbria/node-lumberjack-protocol","homepage":null,"size":225,"stargazers_count":4,"watchers_count":4,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/benbria/node-lumberjack-protocol/pulls/2"},"html":{"href":"https://github.com/benbria/node-lumberjack-protocol/pull/2"},"issue":{"href":"https://api.github.com/repos/benbria/node-lumberjack-protocol/issues/2"},"comments":{"href":"https://api.github.com/repos/benbria/node-lumberjack-protocol/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/benbria/node-lumberjack-protocol/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/benbria/node-lumberjack-protocol/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/benbria/node-lumberjack-protocol/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/benbria/node-lumberjack-protocol/statuses/d95f6226761d14ee695aba30990acbe64803a944"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jwalton","id":1771003,"avatar_url":"https://avatars.githubusercontent.com/u/1771003?v=3","gravatar_id":"","url":"https://api.github.com/users/jwalton","html_url":"https://github.com/jwalton","followers_url":"https://api.github.com/users/jwalton/followers","following_url":"https://api.github.com/users/jwalton/following{/other_user}","gists_url":"https://api.github.com/users/jwalton/gists{/gist_id}","starred_url":"https://api.github.com/users/jwalton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwalton/subscriptions","organizations_url":"https://api.github.com/users/jwalton/orgs","repos_url":"https://api.github.com/users/jwalton/repos","events_url":"https://api.github.com/users/jwalton/events{/privacy}","received_events_url":"https://api.github.com/users/jwalton/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}