{"action":"created","comment":{"url":"https://api.github.com/repos/balabit/syslog-ng/pulls/comments/47446396","id":47446396,"diff_hunk":"@@ -481,6 +481,12 @@ plugin_free_candidate_modules(GlobalConfig *cfg)\n }\n \n void\n+plugin_get_module_path(FILE *out)\n+{\n+    fprintf(out, \"Module path: %s\\n\", module_path);\n+}\n+","path":"lib/plugin.c","position":8,"original_position":8,"commit_id":"343d2c2d7e0fd3a77abcbcbac7f0c9f37268ca75","original_commit_id":"343d2c2d7e0fd3a77abcbcbac7f0c9f37268ca75","user":{"login":"bazsi","id":714102,"avatar_url":"https://avatars.githubusercontent.com/u/714102?v=3","gravatar_id":"","url":"https://api.github.com/users/bazsi","html_url":"https://github.com/bazsi","followers_url":"https://api.github.com/users/bazsi/followers","following_url":"https://api.github.com/users/bazsi/following{/other_user}","gists_url":"https://api.github.com/users/bazsi/gists{/gist_id}","starred_url":"https://api.github.com/users/bazsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazsi/subscriptions","organizations_url":"https://api.github.com/users/bazsi/orgs","repos_url":"https://api.github.com/users/bazsi/repos","events_url":"https://api.github.com/users/bazsi/events{/privacy}","received_events_url":"https://api.github.com/users/bazsi/received_events","type":"User","site_admin":false},"body":"also, the module_path global is pretty sure to be at the wrong location in mainloop.c and should probably be pushed down to plugin.c, but that's a separate issue.\r\n","created_at":"2015-12-13T15:58:45Z","updated_at":"2015-12-13T15:58:45Z","html_url":"https://github.com/balabit/syslog-ng/pull/813#discussion_r47446396","pull_request_url":"https://api.github.com/repos/balabit/syslog-ng/pulls/813","_links":{"self":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/comments/47446396"},"html":{"href":"https://github.com/balabit/syslog-ng/pull/813#discussion_r47446396"},"pull_request":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/813"}}},"pull_request":{"url":"https://api.github.com/repos/balabit/syslog-ng/pulls/813","id":52050514,"html_url":"https://github.com/balabit/syslog-ng/pull/813","diff_url":"https://github.com/balabit/syslog-ng/pull/813.diff","patch_url":"https://github.com/balabit/syslog-ng/pull/813.patch","issue_url":"https://api.github.com/repos/balabit/syslog-ng/issues/813","number":813,"state":"open","locked":false,"title":"tests: made func tests a bit flexible","user":{"login":"lmesz","id":498925,"avatar_url":"https://avatars.githubusercontent.com/u/498925?v=3","gravatar_id":"","url":"https://api.github.com/users/lmesz","html_url":"https://github.com/lmesz","followers_url":"https://api.github.com/users/lmesz/followers","following_url":"https://api.github.com/users/lmesz/following{/other_user}","gists_url":"https://api.github.com/users/lmesz/gists{/gist_id}","starred_url":"https://api.github.com/users/lmesz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmesz/subscriptions","organizations_url":"https://api.github.com/users/lmesz/orgs","repos_url":"https://api.github.com/users/lmesz/repos","events_url":"https://api.github.com/users/lmesz/events{/privacy}","received_events_url":"https://api.github.com/users/lmesz/received_events","type":"User","site_admin":false},"body":"With this minimal fix in tests, syslog-ng can be installed on arbitary place in a host. This place can be passed via SYSLOG_NG_BINARY and functional test can be executed like before.","created_at":"2015-11-28T23:09:47Z","updated_at":"2015-12-13T15:58:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05ba034b1cb0805aaa42ae53bd00d61ddedb8c8f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/balabit/syslog-ng/pulls/813/commits","review_comments_url":"https://api.github.com/repos/balabit/syslog-ng/pulls/813/comments","review_comment_url":"https://api.github.com/repos/balabit/syslog-ng/pulls/comments{/number}","comments_url":"https://api.github.com/repos/balabit/syslog-ng/issues/813/comments","statuses_url":"https://api.github.com/repos/balabit/syslog-ng/statuses/343d2c2d7e0fd3a77abcbcbac7f0c9f37268ca75","head":{"label":"lmesz:remove-fix-relative-path-of-syslog-ng-in-func-test","ref":"remove-fix-relative-path-of-syslog-ng-in-func-test","sha":"343d2c2d7e0fd3a77abcbcbac7f0c9f37268ca75","user":{"login":"lmesz","id":498925,"avatar_url":"https://avatars.githubusercontent.com/u/498925?v=3","gravatar_id":"","url":"https://api.github.com/users/lmesz","html_url":"https://github.com/lmesz","followers_url":"https://api.github.com/users/lmesz/followers","following_url":"https://api.github.com/users/lmesz/following{/other_user}","gists_url":"https://api.github.com/users/lmesz/gists{/gist_id}","starred_url":"https://api.github.com/users/lmesz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmesz/subscriptions","organizations_url":"https://api.github.com/users/lmesz/orgs","repos_url":"https://api.github.com/users/lmesz/repos","events_url":"https://api.github.com/users/lmesz/events{/privacy}","received_events_url":"https://api.github.com/users/lmesz/received_events","type":"User","site_admin":false},"repo":{"id":19833930,"name":"syslog-ng","full_name":"lmesz/syslog-ng","owner":{"login":"lmesz","id":498925,"avatar_url":"https://avatars.githubusercontent.com/u/498925?v=3","gravatar_id":"","url":"https://api.github.com/users/lmesz","html_url":"https://github.com/lmesz","followers_url":"https://api.github.com/users/lmesz/followers","following_url":"https://api.github.com/users/lmesz/following{/other_user}","gists_url":"https://api.github.com/users/lmesz/gists{/gist_id}","starred_url":"https://api.github.com/users/lmesz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmesz/subscriptions","organizations_url":"https://api.github.com/users/lmesz/orgs","repos_url":"https://api.github.com/users/lmesz/repos","events_url":"https://api.github.com/users/lmesz/events{/privacy}","received_events_url":"https://api.github.com/users/lmesz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lmesz/syslog-ng","description":"syslog-ng is an enhanced log daemon, supporting a wide range of input and output methods: syslog, unstructured text, queueing, SQL & NoSQL.","fork":true,"url":"https://api.github.com/repos/lmesz/syslog-ng","forks_url":"https://api.github.com/repos/lmesz/syslog-ng/forks","keys_url":"https://api.github.com/repos/lmesz/syslog-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lmesz/syslog-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lmesz/syslog-ng/teams","hooks_url":"https://api.github.com/repos/lmesz/syslog-ng/hooks","issue_events_url":"https://api.github.com/repos/lmesz/syslog-ng/issues/events{/number}","events_url":"https://api.github.com/repos/lmesz/syslog-ng/events","assignees_url":"https://api.github.com/repos/lmesz/syslog-ng/assignees{/user}","branches_url":"https://api.github.com/repos/lmesz/syslog-ng/branches{/branch}","tags_url":"https://api.github.com/repos/lmesz/syslog-ng/tags","blobs_url":"https://api.github.com/repos/lmesz/syslog-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lmesz/syslog-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lmesz/syslog-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/lmesz/syslog-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lmesz/syslog-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/lmesz/syslog-ng/languages","stargazers_url":"https://api.github.com/repos/lmesz/syslog-ng/stargazers","contributors_url":"https://api.github.com/repos/lmesz/syslog-ng/contributors","subscribers_url":"https://api.github.com/repos/lmesz/syslog-ng/subscribers","subscription_url":"https://api.github.com/repos/lmesz/syslog-ng/subscription","commits_url":"https://api.github.com/repos/lmesz/syslog-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/lmesz/syslog-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/lmesz/syslog-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/lmesz/syslog-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/lmesz/syslog-ng/contents/{+path}","compare_url":"https://api.github.com/repos/lmesz/syslog-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lmesz/syslog-ng/merges","archive_url":"https://api.github.com/repos/lmesz/syslog-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lmesz/syslog-ng/downloads","issues_url":"https://api.github.com/repos/lmesz/syslog-ng/issues{/number}","pulls_url":"https://api.github.com/repos/lmesz/syslog-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/lmesz/syslog-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/lmesz/syslog-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lmesz/syslog-ng/labels{/name}","releases_url":"https://api.github.com/repos/lmesz/syslog-ng/releases{/id}","created_at":"2014-05-15T20:21:04Z","updated_at":"2015-10-31T10:55:20Z","pushed_at":"2015-12-07T21:13:25Z","git_url":"git://github.com/lmesz/syslog-ng.git","ssh_url":"git@github.com:lmesz/syslog-ng.git","clone_url":"https://github.com/lmesz/syslog-ng.git","svn_url":"https://github.com/lmesz/syslog-ng","homepage":"https://www.balabit.com/network-security/syslog-ng/opensource-logging-system/","size":16202,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"balabit:master","ref":"master","sha":"7c83cfa4bf3f2e1bb44e46c6878c7d176f213daf","user":{"login":"balabit","id":986981,"avatar_url":"https://avatars.githubusercontent.com/u/986981?v=3","gravatar_id":"","url":"https://api.github.com/users/balabit","html_url":"https://github.com/balabit","followers_url":"https://api.github.com/users/balabit/followers","following_url":"https://api.github.com/users/balabit/following{/other_user}","gists_url":"https://api.github.com/users/balabit/gists{/gist_id}","starred_url":"https://api.github.com/users/balabit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balabit/subscriptions","organizations_url":"https://api.github.com/users/balabit/orgs","repos_url":"https://api.github.com/users/balabit/repos","events_url":"https://api.github.com/users/balabit/events{/privacy}","received_events_url":"https://api.github.com/users/balabit/received_events","type":"Organization","site_admin":false},"repo":{"id":14146757,"name":"syslog-ng","full_name":"balabit/syslog-ng","owner":{"login":"balabit","id":986981,"avatar_url":"https://avatars.githubusercontent.com/u/986981?v=3","gravatar_id":"","url":"https://api.github.com/users/balabit","html_url":"https://github.com/balabit","followers_url":"https://api.github.com/users/balabit/followers","following_url":"https://api.github.com/users/balabit/following{/other_user}","gists_url":"https://api.github.com/users/balabit/gists{/gist_id}","starred_url":"https://api.github.com/users/balabit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balabit/subscriptions","organizations_url":"https://api.github.com/users/balabit/orgs","repos_url":"https://api.github.com/users/balabit/repos","events_url":"https://api.github.com/users/balabit/events{/privacy}","received_events_url":"https://api.github.com/users/balabit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/balabit/syslog-ng","description":"syslog-ng is an enhanced log daemon, supporting a wide range of input and output methods: syslog, unstructured text, queueing, SQL & NoSQL.","fork":false,"url":"https://api.github.com/repos/balabit/syslog-ng","forks_url":"https://api.github.com/repos/balabit/syslog-ng/forks","keys_url":"https://api.github.com/repos/balabit/syslog-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/balabit/syslog-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/balabit/syslog-ng/teams","hooks_url":"https://api.github.com/repos/balabit/syslog-ng/hooks","issue_events_url":"https://api.github.com/repos/balabit/syslog-ng/issues/events{/number}","events_url":"https://api.github.com/repos/balabit/syslog-ng/events","assignees_url":"https://api.github.com/repos/balabit/syslog-ng/assignees{/user}","branches_url":"https://api.github.com/repos/balabit/syslog-ng/branches{/branch}","tags_url":"https://api.github.com/repos/balabit/syslog-ng/tags","blobs_url":"https://api.github.com/repos/balabit/syslog-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/balabit/syslog-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/balabit/syslog-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/balabit/syslog-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/balabit/syslog-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/balabit/syslog-ng/languages","stargazers_url":"https://api.github.com/repos/balabit/syslog-ng/stargazers","contributors_url":"https://api.github.com/repos/balabit/syslog-ng/contributors","subscribers_url":"https://api.github.com/repos/balabit/syslog-ng/subscribers","subscription_url":"https://api.github.com/repos/balabit/syslog-ng/subscription","commits_url":"https://api.github.com/repos/balabit/syslog-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/balabit/syslog-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/balabit/syslog-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/balabit/syslog-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/balabit/syslog-ng/contents/{+path}","compare_url":"https://api.github.com/repos/balabit/syslog-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/balabit/syslog-ng/merges","archive_url":"https://api.github.com/repos/balabit/syslog-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/balabit/syslog-ng/downloads","issues_url":"https://api.github.com/repos/balabit/syslog-ng/issues{/number}","pulls_url":"https://api.github.com/repos/balabit/syslog-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/balabit/syslog-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/balabit/syslog-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/balabit/syslog-ng/labels{/name}","releases_url":"https://api.github.com/repos/balabit/syslog-ng/releases{/id}","created_at":"2013-11-05T16:22:02Z","updated_at":"2015-12-09T01:58:14Z","pushed_at":"2015-12-12T14:07:51Z","git_url":"git://github.com/balabit/syslog-ng.git","ssh_url":"git@github.com:balabit/syslog-ng.git","clone_url":"https://github.com/balabit/syslog-ng.git","svn_url":"https://github.com/balabit/syslog-ng","homepage":"http://www.syslog-ng.org/","size":17765,"stargazers_count":190,"watchers_count":190,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"open_issues_count":119,"forks":76,"open_issues":119,"watchers":190,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/813"},"html":{"href":"https://github.com/balabit/syslog-ng/pull/813"},"issue":{"href":"https://api.github.com/repos/balabit/syslog-ng/issues/813"},"comments":{"href":"https://api.github.com/repos/balabit/syslog-ng/issues/813/comments"},"review_comments":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/813/comments"},"review_comment":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/813/commits"},"statuses":{"href":"https://api.github.com/repos/balabit/syslog-ng/statuses/343d2c2d7e0fd3a77abcbcbac7f0c9f37268ca75"}}}}