{"action":"created","comment":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/47640785","id":47640785,"diff_hunk":"@@ -68,6 +69,18 @@ namespace RT\n         /* C0 c0_shifted = c0(p_zone.offset); ...; CN cN_shifted = cN(p_zone.offset); */                              \\\n         BOOST_PP_REPEAT(N, SHIFT_CURSOR_ZONE, _)                                                                    \\\n                                                                                                                     \\\n+        if(this->_blockDim == math::Size_t<3>::create(0))                                                           \\\n+        {                                                                                                           \\\n+            this->_blockDim = math::Size_t<3>::create(1);                                                           \\\n+            /* The greatest common divisor of each component of the volume size                                         \\\n+             * and a certain power of two value gives the best suitable block size */                                   \\\n+            boost::math::gcd_evaluator<size_t> gcd; /* greatest common divisor */                                       \\\n+            size_t maxValues[] = {16, 16, 4}; /* maximum values for each axis */                                      \\","path":"src/libPMacc/include/cuSTL/algorithm/kernel/run-time/Foreach.hpp","position":null,"original_position":18,"commit_id":"6042f029834f141bae944e94c53fb16ba713a1ab","original_commit_id":"592e58730960438aa5aa737c549e0348ee86228b","user":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"body":"can we define this constant somewhere more central?","created_at":"2015-12-15T14:22:04Z","updated_at":"2015-12-15T14:22:04Z","html_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/1309#discussion_r47640785","pull_request_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/1309","_links":{"self":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/47640785"},"html":{"href":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/1309#discussion_r47640785"},"pull_request":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/1309"}}},"pull_request":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/1309","id":53704593,"html_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/1309","diff_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/1309.diff","patch_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/1309.patch","issue_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/1309","number":1309,"state":"open","locked":false,"title":"let cuSTL/kernel/runtime/Foreach compute best BlockDim","user":{"login":"Heikman","id":5159590,"avatar_url":"https://avatars.githubusercontent.com/u/5159590?v=3","gravatar_id":"","url":"https://api.github.com/users/Heikman","html_url":"https://github.com/Heikman","followers_url":"https://api.github.com/users/Heikman/followers","following_url":"https://api.github.com/users/Heikman/following{/other_user}","gists_url":"https://api.github.com/users/Heikman/gists{/gist_id}","starred_url":"https://api.github.com/users/Heikman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Heikman/subscriptions","organizations_url":"https://api.github.com/users/Heikman/orgs","repos_url":"https://api.github.com/users/Heikman/repos","events_url":"https://api.github.com/users/Heikman/events{/privacy}","received_events_url":"https://api.github.com/users/Heikman/received_events","type":"User","site_admin":false},"body":"If no BlockDim is given `Foreach` computes it by itself.\r\n\r\nSolves #1256\r\n\r\nTested with SliceFieldPrinter plugin.","created_at":"2015-12-15T13:46:09Z","updated_at":"2015-12-15T14:22:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ff11363557ed5d40ab6c2252217f34cb0ae52b5","assignee":{"login":"psychocoderHPC","id":4037125,"avatar_url":"https://avatars.githubusercontent.com/u/4037125?v=3","gravatar_id":"","url":"https://api.github.com/users/psychocoderHPC","html_url":"https://github.com/psychocoderHPC","followers_url":"https://api.github.com/users/psychocoderHPC/followers","following_url":"https://api.github.com/users/psychocoderHPC/following{/other_user}","gists_url":"https://api.github.com/users/psychocoderHPC/gists{/gist_id}","starred_url":"https://api.github.com/users/psychocoderHPC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychocoderHPC/subscriptions","organizations_url":"https://api.github.com/users/psychocoderHPC/orgs","repos_url":"https://api.github.com/users/psychocoderHPC/repos","events_url":"https://api.github.com/users/psychocoderHPC/events{/privacy}","received_events_url":"https://api.github.com/users/psychocoderHPC/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones/2","html_url":"https://github.com/ComputationalRadiationPhysics/picongpu/milestones/Open%20Beta","labels_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones/2/labels","id":395839,"number":2,"title":"Open Beta","description":"Tasks to complete until the release of our open beta (version 0.1)\r\n\r\nThe [beta](https://en.wikipedia.org/wiki/Software_release_life_cycle#Beta) release shall be useful for *physicist* that used a Particle-in-Cell code *before*. Experience with *compiling libraries from source* and a *good Linux knowledge* is required for the initial installation.\r\n","creator":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"open_issues":147,"closed_issues":1056,"state":"open","created_at":"2013-08-06T16:38:57Z","updated_at":"2015-12-15T13:46:48Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/1309/commits","review_comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/1309/comments","review_comment_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/1309/comments","statuses_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/6042f029834f141bae944e94c53fb16ba713a1ab","head":{"label":"Heikman:feat-AutoBlockDim","ref":"feat-AutoBlockDim","sha":"6042f029834f141bae944e94c53fb16ba713a1ab","user":{"login":"Heikman","id":5159590,"avatar_url":"https://avatars.githubusercontent.com/u/5159590?v=3","gravatar_id":"","url":"https://api.github.com/users/Heikman","html_url":"https://github.com/Heikman","followers_url":"https://api.github.com/users/Heikman/followers","following_url":"https://api.github.com/users/Heikman/following{/other_user}","gists_url":"https://api.github.com/users/Heikman/gists{/gist_id}","starred_url":"https://api.github.com/users/Heikman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Heikman/subscriptions","organizations_url":"https://api.github.com/users/Heikman/orgs","repos_url":"https://api.github.com/users/Heikman/repos","events_url":"https://api.github.com/users/Heikman/events{/privacy}","received_events_url":"https://api.github.com/users/Heikman/received_events","type":"User","site_admin":false},"repo":{"id":12133878,"name":"picongpu","full_name":"Heikman/picongpu","owner":{"login":"Heikman","id":5159590,"avatar_url":"https://avatars.githubusercontent.com/u/5159590?v=3","gravatar_id":"","url":"https://api.github.com/users/Heikman","html_url":"https://github.com/Heikman","followers_url":"https://api.github.com/users/Heikman/followers","following_url":"https://api.github.com/users/Heikman/following{/other_user}","gists_url":"https://api.github.com/users/Heikman/gists{/gist_id}","starred_url":"https://api.github.com/users/Heikman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Heikman/subscriptions","organizations_url":"https://api.github.com/users/Heikman/orgs","repos_url":"https://api.github.com/users/Heikman/repos","events_url":"https://api.github.com/users/Heikman/events{/privacy}","received_events_url":"https://api.github.com/users/Heikman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Heikman/picongpu","description":"PIConGPU - A particle-in-cell code for GPGPUs","fork":true,"url":"https://api.github.com/repos/Heikman/picongpu","forks_url":"https://api.github.com/repos/Heikman/picongpu/forks","keys_url":"https://api.github.com/repos/Heikman/picongpu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Heikman/picongpu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Heikman/picongpu/teams","hooks_url":"https://api.github.com/repos/Heikman/picongpu/hooks","issue_events_url":"https://api.github.com/repos/Heikman/picongpu/issues/events{/number}","events_url":"https://api.github.com/repos/Heikman/picongpu/events","assignees_url":"https://api.github.com/repos/Heikman/picongpu/assignees{/user}","branches_url":"https://api.github.com/repos/Heikman/picongpu/branches{/branch}","tags_url":"https://api.github.com/repos/Heikman/picongpu/tags","blobs_url":"https://api.github.com/repos/Heikman/picongpu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Heikman/picongpu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Heikman/picongpu/git/refs{/sha}","trees_url":"https://api.github.com/repos/Heikman/picongpu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Heikman/picongpu/statuses/{sha}","languages_url":"https://api.github.com/repos/Heikman/picongpu/languages","stargazers_url":"https://api.github.com/repos/Heikman/picongpu/stargazers","contributors_url":"https://api.github.com/repos/Heikman/picongpu/contributors","subscribers_url":"https://api.github.com/repos/Heikman/picongpu/subscribers","subscription_url":"https://api.github.com/repos/Heikman/picongpu/subscription","commits_url":"https://api.github.com/repos/Heikman/picongpu/commits{/sha}","git_commits_url":"https://api.github.com/repos/Heikman/picongpu/git/commits{/sha}","comments_url":"https://api.github.com/repos/Heikman/picongpu/comments{/number}","issue_comment_url":"https://api.github.com/repos/Heikman/picongpu/issues/comments{/number}","contents_url":"https://api.github.com/repos/Heikman/picongpu/contents/{+path}","compare_url":"https://api.github.com/repos/Heikman/picongpu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Heikman/picongpu/merges","archive_url":"https://api.github.com/repos/Heikman/picongpu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Heikman/picongpu/downloads","issues_url":"https://api.github.com/repos/Heikman/picongpu/issues{/number}","pulls_url":"https://api.github.com/repos/Heikman/picongpu/pulls{/number}","milestones_url":"https://api.github.com/repos/Heikman/picongpu/milestones{/number}","notifications_url":"https://api.github.com/repos/Heikman/picongpu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Heikman/picongpu/labels{/name}","releases_url":"https://api.github.com/repos/Heikman/picongpu/releases{/id}","created_at":"2013-08-15T12:28:22Z","updated_at":"2014-06-12T11:22:44Z","pushed_at":"2015-12-15T14:19:50Z","git_url":"git://github.com/Heikman/picongpu.git","ssh_url":"git@github.com:Heikman/picongpu.git","clone_url":"https://github.com/Heikman/picongpu.git","svn_url":"https://github.com/Heikman/picongpu","homepage":"http://picongpu.hzdr.de","size":9790,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ComputationalRadiationPhysics:dev","ref":"dev","sha":"237dcc8227aedb41e16deb4968476b45b23806f6","user":{"login":"ComputationalRadiationPhysics","id":5120388,"avatar_url":"https://avatars.githubusercontent.com/u/5120388?v=3","gravatar_id":"","url":"https://api.github.com/users/ComputationalRadiationPhysics","html_url":"https://github.com/ComputationalRadiationPhysics","followers_url":"https://api.github.com/users/ComputationalRadiationPhysics/followers","following_url":"https://api.github.com/users/ComputationalRadiationPhysics/following{/other_user}","gists_url":"https://api.github.com/users/ComputationalRadiationPhysics/gists{/gist_id}","starred_url":"https://api.github.com/users/ComputationalRadiationPhysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ComputationalRadiationPhysics/subscriptions","organizations_url":"https://api.github.com/users/ComputationalRadiationPhysics/orgs","repos_url":"https://api.github.com/users/ComputationalRadiationPhysics/repos","events_url":"https://api.github.com/users/ComputationalRadiationPhysics/events{/privacy}","received_events_url":"https://api.github.com/users/ComputationalRadiationPhysics/received_events","type":"Organization","site_admin":false},"repo":{"id":11764461,"name":"picongpu","full_name":"ComputationalRadiationPhysics/picongpu","owner":{"login":"ComputationalRadiationPhysics","id":5120388,"avatar_url":"https://avatars.githubusercontent.com/u/5120388?v=3","gravatar_id":"","url":"https://api.github.com/users/ComputationalRadiationPhysics","html_url":"https://github.com/ComputationalRadiationPhysics","followers_url":"https://api.github.com/users/ComputationalRadiationPhysics/followers","following_url":"https://api.github.com/users/ComputationalRadiationPhysics/following{/other_user}","gists_url":"https://api.github.com/users/ComputationalRadiationPhysics/gists{/gist_id}","starred_url":"https://api.github.com/users/ComputationalRadiationPhysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ComputationalRadiationPhysics/subscriptions","organizations_url":"https://api.github.com/users/ComputationalRadiationPhysics/orgs","repos_url":"https://api.github.com/users/ComputationalRadiationPhysics/repos","events_url":"https://api.github.com/users/ComputationalRadiationPhysics/events{/privacy}","received_events_url":"https://api.github.com/users/ComputationalRadiationPhysics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ComputationalRadiationPhysics/picongpu","description":"PIConGPU - A particle-in-cell code for GPGPUs","fork":false,"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu","forks_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/forks","keys_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/teams","hooks_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/hooks","issue_events_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/events{/number}","events_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/events","assignees_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/assignees{/user}","branches_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/branches{/branch}","tags_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/tags","blobs_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/refs{/sha}","trees_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/{sha}","languages_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/languages","stargazers_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/stargazers","contributors_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/contributors","subscribers_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/subscribers","subscription_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/subscription","commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/commits{/sha}","git_commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/commits{/sha}","comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/comments{/number}","issue_comment_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/comments{/number}","contents_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/contents/{+path}","compare_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/merges","archive_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/downloads","issues_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues{/number}","pulls_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls{/number}","milestones_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones{/number}","notifications_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/labels{/name}","releases_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/releases{/id}","created_at":"2013-07-30T12:28:20Z","updated_at":"2015-11-20T16:27:08Z","pushed_at":"2015-12-15T14:19:50Z","git_url":"git://github.com/ComputationalRadiationPhysics/picongpu.git","ssh_url":"git@github.com:ComputationalRadiationPhysics/picongpu.git","clone_url":"https://github.com/ComputationalRadiationPhysics/picongpu.git","svn_url":"https://github.com/ComputationalRadiationPhysics/picongpu","homepage":"http://picongpu.hzdr.de","size":10398,"stargazers_count":137,"watchers_count":137,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":73,"mirror_url":null,"open_issues_count":214,"forks":73,"open_issues":214,"watchers":137,"default_branch":"release-0.1.1"}},"_links":{"self":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/1309"},"html":{"href":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/1309"},"issue":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/1309"},"comments":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/1309/comments"},"review_comments":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/1309/comments"},"review_comment":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/1309/commits"},"statuses":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/6042f029834f141bae944e94c53fb16ba713a1ab"}}}}