{"action":"created","comment":{"url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/pulls/comments/29548004","id":29548004,"diff_hunk":"@@ -33,14 +34,8 @@ module.exports = function(options) {\n     requireFn = function (name) {\n       // This searches up from the specified package.json file, making sure\n       // the config option behaves as expected. See issue #56.\n-      var searchFor = path.join('node_modules', name);\n-\n-      var src = findup(searchFor, {cwd: path.dirname(config)}) || name;\n-      if (src !== null) {\n-        return require(src);\n-      } else {\n-        throw new Error('Cannot find `' + name + '` in your node_modules!');\n-      }","path":"index.js","position":19,"original_position":19,"commit_id":"e8f81eef56e406f229f02a4f1f6bbde0d67c980f","original_commit_id":"e8f81eef56e406f229f02a4f1f6bbde0d67c980f","user":{"login":"jackfranklin","id":193238,"avatar_url":"https://avatars.githubusercontent.com/u/193238?v=3","gravatar_id":"","url":"https://api.github.com/users/jackfranklin","html_url":"https://github.com/jackfranklin","followers_url":"https://api.github.com/users/jackfranklin/followers","following_url":"https://api.github.com/users/jackfranklin/following{/other_user}","gists_url":"https://api.github.com/users/jackfranklin/gists{/gist_id}","starred_url":"https://api.github.com/users/jackfranklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackfranklin/subscriptions","organizations_url":"https://api.github.com/users/jackfranklin/orgs","repos_url":"https://api.github.com/users/jackfranklin/repos","events_url":"https://api.github.com/users/jackfranklin/events{/privacy}","received_events_url":"https://api.github.com/users/jackfranklin/received_events","type":"User","site_admin":false},"body":":+1: ","created_at":"2015-05-02T14:52:33Z","updated_at":"2015-05-02T14:52:33Z","html_url":"https://github.com/jackfranklin/gulp-load-plugins/pull/75#discussion_r29548004","pull_request_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/pulls/75","_links":{"self":{"href":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/pulls/comments/29548004"},"html":{"href":"https://github.com/jackfranklin/gulp-load-plugins/pull/75#discussion_r29548004"},"pull_request":{"href":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/pulls/75"}}},"pull_request":{"url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/pulls/75","id":34543271,"html_url":"https://github.com/jackfranklin/gulp-load-plugins/pull/75","diff_url":"https://github.com/jackfranklin/gulp-load-plugins/pull/75.diff","patch_url":"https://github.com/jackfranklin/gulp-load-plugins/pull/75.patch","issue_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/issues/75","number":75,"state":"open","locked":false,"title":"Replaced findup with resolve.","user":{"login":"callumacrae","id":472830,"avatar_url":"https://avatars.githubusercontent.com/u/472830?v=3","gravatar_id":"","url":"https://api.github.com/users/callumacrae","html_url":"https://github.com/callumacrae","followers_url":"https://api.github.com/users/callumacrae/followers","following_url":"https://api.github.com/users/callumacrae/following{/other_user}","gists_url":"https://api.github.com/users/callumacrae/gists{/gist_id}","starred_url":"https://api.github.com/users/callumacrae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callumacrae/subscriptions","organizations_url":"https://api.github.com/users/callumacrae/orgs","repos_url":"https://api.github.com/users/callumacrae/repos","events_url":"https://api.github.com/users/callumacrae/events{/privacy}","received_events_url":"https://api.github.com/users/callumacrae/received_events","type":"User","site_admin":false},"body":"The actual code is much nicer.\r\n\r\nThis has the side effect that it drops support for NODE_PATH, because it isn't supported by resolve: substack/node-resolve#47. However, according to the Node.js docs, you're not supposed to use NODE_PATH anyway: https://nodejs.org/api/modules.html#modules_loading_from_the_global_folders\r\n\r\nI can probably work around if you want NODE_PATH support or you don't want to break BC, but it would make the code quite a bit longer (it would involve a try-catch in a try-catch!)","created_at":"2015-05-01T15:19:01Z","updated_at":"2015-05-02T14:52:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87d3eb89c8d763c0ebbc099a07eb00acadeeb9af","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/pulls/75/commits","review_comments_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/pulls/75/comments","review_comment_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/issues/75/comments","statuses_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/statuses/e8f81eef56e406f229f02a4f1f6bbde0d67c980f","head":{"label":"callumacrae:resolve","ref":"resolve","sha":"e8f81eef56e406f229f02a4f1f6bbde0d67c980f","user":{"login":"callumacrae","id":472830,"avatar_url":"https://avatars.githubusercontent.com/u/472830?v=3","gravatar_id":"","url":"https://api.github.com/users/callumacrae","html_url":"https://github.com/callumacrae","followers_url":"https://api.github.com/users/callumacrae/followers","following_url":"https://api.github.com/users/callumacrae/following{/other_user}","gists_url":"https://api.github.com/users/callumacrae/gists{/gist_id}","starred_url":"https://api.github.com/users/callumacrae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callumacrae/subscriptions","organizations_url":"https://api.github.com/users/callumacrae/orgs","repos_url":"https://api.github.com/users/callumacrae/repos","events_url":"https://api.github.com/users/callumacrae/events{/privacy}","received_events_url":"https://api.github.com/users/callumacrae/received_events","type":"User","site_admin":false},"repo":{"id":30197667,"name":"gulp-load-plugins","full_name":"callumacrae/gulp-load-plugins","owner":{"login":"callumacrae","id":472830,"avatar_url":"https://avatars.githubusercontent.com/u/472830?v=3","gravatar_id":"","url":"https://api.github.com/users/callumacrae","html_url":"https://github.com/callumacrae","followers_url":"https://api.github.com/users/callumacrae/followers","following_url":"https://api.github.com/users/callumacrae/following{/other_user}","gists_url":"https://api.github.com/users/callumacrae/gists{/gist_id}","starred_url":"https://api.github.com/users/callumacrae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callumacrae/subscriptions","organizations_url":"https://api.github.com/users/callumacrae/orgs","repos_url":"https://api.github.com/users/callumacrae/repos","events_url":"https://api.github.com/users/callumacrae/events{/privacy}","received_events_url":"https://api.github.com/users/callumacrae/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/callumacrae/gulp-load-plugins","description":"Automatically load in gulp plugins","fork":true,"url":"https://api.github.com/repos/callumacrae/gulp-load-plugins","forks_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/forks","keys_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/teams","hooks_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/hooks","issue_events_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/events","assignees_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/tags","blobs_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/languages","stargazers_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/stargazers","contributors_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/contributors","subscribers_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/subscribers","subscription_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/subscription","commits_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/merges","archive_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/downloads","issues_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/labels{/name}","releases_url":"https://api.github.com/repos/callumacrae/gulp-load-plugins/releases{/id}","created_at":"2015-02-02T17:02:12Z","updated_at":"2015-02-02T17:02:12Z","pushed_at":"2015-05-01T15:16:34Z","git_url":"git://github.com/callumacrae/gulp-load-plugins.git","ssh_url":"git@github.com:callumacrae/gulp-load-plugins.git","clone_url":"https://github.com/callumacrae/gulp-load-plugins.git","svn_url":"https://github.com/callumacrae/gulp-load-plugins","homepage":"https://github.com/jackfranklin/gulp-load-plugins","size":156,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jackfranklin:master","ref":"master","sha":"ef31ce655d19a4e66febc9dfb56c0df7c4693df5","user":{"login":"jackfranklin","id":193238,"avatar_url":"https://avatars.githubusercontent.com/u/193238?v=3","gravatar_id":"","url":"https://api.github.com/users/jackfranklin","html_url":"https://github.com/jackfranklin","followers_url":"https://api.github.com/users/jackfranklin/followers","following_url":"https://api.github.com/users/jackfranklin/following{/other_user}","gists_url":"https://api.github.com/users/jackfranklin/gists{/gist_id}","starred_url":"https://api.github.com/users/jackfranklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackfranklin/subscriptions","organizations_url":"https://api.github.com/users/jackfranklin/orgs","repos_url":"https://api.github.com/users/jackfranklin/repos","events_url":"https://api.github.com/users/jackfranklin/events{/privacy}","received_events_url":"https://api.github.com/users/jackfranklin/received_events","type":"User","site_admin":false},"repo":{"id":14910179,"name":"gulp-load-plugins","full_name":"jackfranklin/gulp-load-plugins","owner":{"login":"jackfranklin","id":193238,"avatar_url":"https://avatars.githubusercontent.com/u/193238?v=3","gravatar_id":"","url":"https://api.github.com/users/jackfranklin","html_url":"https://github.com/jackfranklin","followers_url":"https://api.github.com/users/jackfranklin/followers","following_url":"https://api.github.com/users/jackfranklin/following{/other_user}","gists_url":"https://api.github.com/users/jackfranklin/gists{/gist_id}","starred_url":"https://api.github.com/users/jackfranklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackfranklin/subscriptions","organizations_url":"https://api.github.com/users/jackfranklin/orgs","repos_url":"https://api.github.com/users/jackfranklin/repos","events_url":"https://api.github.com/users/jackfranklin/events{/privacy}","received_events_url":"https://api.github.com/users/jackfranklin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jackfranklin/gulp-load-plugins","description":"Automatically load in gulp plugins","fork":false,"url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins","forks_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/forks","keys_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/teams","hooks_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/hooks","issue_events_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/events","assignees_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/tags","blobs_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/languages","stargazers_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/stargazers","contributors_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/contributors","subscribers_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/subscribers","subscription_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/subscription","commits_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/merges","archive_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/downloads","issues_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/labels{/name}","releases_url":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/releases{/id}","created_at":"2013-12-04T00:48:35Z","updated_at":"2015-04-29T17:26:48Z","pushed_at":"2015-05-01T15:19:02Z","git_url":"git://github.com/jackfranklin/gulp-load-plugins.git","ssh_url":"git@github.com:jackfranklin/gulp-load-plugins.git","clone_url":"https://github.com/jackfranklin/gulp-load-plugins.git","svn_url":"https://github.com/jackfranklin/gulp-load-plugins","homepage":"https://github.com/jackfranklin/gulp-load-plugins","size":706,"stargazers_count":304,"watchers_count":304,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":5,"forks":26,"open_issues":5,"watchers":304,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/pulls/75"},"html":{"href":"https://github.com/jackfranklin/gulp-load-plugins/pull/75"},"issue":{"href":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/issues/75"},"comments":{"href":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/jackfranklin/gulp-load-plugins/statuses/e8f81eef56e406f229f02a4f1f6bbde0d67c980f"}}}}