{"action":"created","comment":{"url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/pulls/comments/37795009","id":37795009,"diff_hunk":"@@ -249,6 +250,20 @@ def _get_column_info(self, *args, **kwargs):\n \n         return column_info\n \n+    def create_connect_args(self, *args, **kwargs):\n+        default_args = {\n+            'sslmode': 'verify-full',","path":"redshift_sqlalchemy/dialect.py","position":11,"original_position":11,"commit_id":"1e09e37e89156189564b8167d18ff28db0ad9d31","original_commit_id":"1e09e37e89156189564b8167d18ff28db0ad9d31","user":{"login":"graingert","id":413772,"avatar_url":"https://avatars.githubusercontent.com/u/413772?v=3","gravatar_id":"","url":"https://api.github.com/users/graingert","html_url":"https://github.com/graingert","followers_url":"https://api.github.com/users/graingert/followers","following_url":"https://api.github.com/users/graingert/following{/other_user}","gists_url":"https://api.github.com/users/graingert/gists{/gist_id}","starred_url":"https://api.github.com/users/graingert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graingert/subscriptions","organizations_url":"https://api.github.com/users/graingert/orgs","repos_url":"https://api.github.com/users/graingert/repos","events_url":"https://api.github.com/users/graingert/events{/privacy}","received_events_url":"https://api.github.com/users/graingert/received_events","type":"User","site_admin":false},"body":"It looks like the redshift cluster is sending a valid ServerCertificate (when validated with redshift-ssl-ca-cert.pem)  with the correct common name: \"redshift-sqlalchemy-test.cforsfjmjsja.us-west-2.redshift.amazonaws.com\" see https://gist.github.com/graingert/3a46c493520db7caa460#file-redshift-tls-server-hello-txt-L188","created_at":"2015-08-24T19:45:26Z","updated_at":"2015-08-24T19:45:26Z","html_url":"https://github.com/graingert/redshift_sqlalchemy/pull/20#discussion_r37795009","pull_request_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/graingert/redshift_sqlalchemy/pulls/comments/37795009"},"html":{"href":"https://github.com/graingert/redshift_sqlalchemy/pull/20#discussion_r37795009"},"pull_request":{"href":"https://api.github.com/repos/graingert/redshift_sqlalchemy/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/pulls/20","id":43108353,"html_url":"https://github.com/graingert/redshift_sqlalchemy/pull/20","diff_url":"https://github.com/graingert/redshift_sqlalchemy/pull/20.diff","patch_url":"https://github.com/graingert/redshift_sqlalchemy/pull/20.patch","issue_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/issues/20","number":20,"state":"closed","locked":false,"title":"Default to SSL with hardcoded AWS Redshift CA","user":{"login":"graingert","id":413772,"avatar_url":"https://avatars.githubusercontent.com/u/413772?v=3","gravatar_id":"","url":"https://api.github.com/users/graingert","html_url":"https://github.com/graingert","followers_url":"https://api.github.com/users/graingert/followers","following_url":"https://api.github.com/users/graingert/following{/other_user}","gists_url":"https://api.github.com/users/graingert/gists{/gist_id}","starred_url":"https://api.github.com/users/graingert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graingert/subscriptions","organizations_url":"https://api.github.com/users/graingert/orgs","repos_url":"https://api.github.com/users/graingert/repos","events_url":"https://api.github.com/users/graingert/events{/privacy}","received_events_url":"https://api.github.com/users/graingert/received_events","type":"User","site_admin":false},"body":"You can still override this by setting `{'sslmode': 'disable'}`\r\n\r\nIn fact I'd recommend using `{'sslmode': 'verify-full', 'sslrootcert': '/path/to/redshift-ssl-ca-cert.pem'}`","created_at":"2015-08-22T18:59:48Z","updated_at":"2015-08-24T19:45:26Z","closed_at":"2015-08-22T21:37:16Z","merged_at":"2015-08-22T21:37:16Z","merge_commit_sha":"bf0da0902869e180e8d19c44dc6a0fc9aafdcdc2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/pulls/20/commits","review_comments_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/pulls/20/comments","review_comment_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/issues/20/comments","statuses_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/statuses/1e09e37e89156189564b8167d18ff28db0ad9d31","head":{"label":"graingert:enable-tls-by-default","ref":"enable-tls-by-default","sha":"1e09e37e89156189564b8167d18ff28db0ad9d31","user":{"login":"graingert","id":413772,"avatar_url":"https://avatars.githubusercontent.com/u/413772?v=3","gravatar_id":"","url":"https://api.github.com/users/graingert","html_url":"https://github.com/graingert","followers_url":"https://api.github.com/users/graingert/followers","following_url":"https://api.github.com/users/graingert/following{/other_user}","gists_url":"https://api.github.com/users/graingert/gists{/gist_id}","starred_url":"https://api.github.com/users/graingert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graingert/subscriptions","organizations_url":"https://api.github.com/users/graingert/orgs","repos_url":"https://api.github.com/users/graingert/repos","events_url":"https://api.github.com/users/graingert/events{/privacy}","received_events_url":"https://api.github.com/users/graingert/received_events","type":"User","site_admin":false},"repo":{"id":35280897,"name":"redshift_sqlalchemy","full_name":"graingert/redshift_sqlalchemy","owner":{"login":"graingert","id":413772,"avatar_url":"https://avatars.githubusercontent.com/u/413772?v=3","gravatar_id":"","url":"https://api.github.com/users/graingert","html_url":"https://github.com/graingert","followers_url":"https://api.github.com/users/graingert/followers","following_url":"https://api.github.com/users/graingert/following{/other_user}","gists_url":"https://api.github.com/users/graingert/gists{/gist_id}","starred_url":"https://api.github.com/users/graingert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graingert/subscriptions","organizations_url":"https://api.github.com/users/graingert/orgs","repos_url":"https://api.github.com/users/graingert/repos","events_url":"https://api.github.com/users/graingert/events{/privacy}","received_events_url":"https://api.github.com/users/graingert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/graingert/redshift_sqlalchemy","description":"Amazon Redshift SQLAlchemy Dialect","fork":true,"url":"https://api.github.com/repos/graingert/redshift_sqlalchemy","forks_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/forks","keys_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/teams","hooks_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/hooks","issue_events_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/issues/events{/number}","events_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/events","assignees_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/assignees{/user}","branches_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/branches{/branch}","tags_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/tags","blobs_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/git/refs{/sha}","trees_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/statuses/{sha}","languages_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/languages","stargazers_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/stargazers","contributors_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/contributors","subscribers_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/subscribers","subscription_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/subscription","commits_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/commits{/sha}","git_commits_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/git/commits{/sha}","comments_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/comments{/number}","issue_comment_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/issues/comments{/number}","contents_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/contents/{+path}","compare_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/merges","archive_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/downloads","issues_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/issues{/number}","pulls_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/pulls{/number}","milestones_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/milestones{/number}","notifications_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/labels{/name}","releases_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/releases{/id}","created_at":"2015-05-08T13:29:24Z","updated_at":"2015-08-10T22:14:18Z","pushed_at":"2015-08-24T18:26:40Z","git_url":"git://github.com/graingert/redshift_sqlalchemy.git","ssh_url":"git@github.com:graingert/redshift_sqlalchemy.git","clone_url":"https://github.com/graingert/redshift_sqlalchemy.git","svn_url":"https://github.com/graingert/redshift_sqlalchemy","homepage":null,"size":516,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":3,"default_branch":"master"}},"base":{"label":"graingert:master","ref":"master","sha":"916c6785ff29fcace3ad84c9e6ce51e3afc25404","user":{"login":"graingert","id":413772,"avatar_url":"https://avatars.githubusercontent.com/u/413772?v=3","gravatar_id":"","url":"https://api.github.com/users/graingert","html_url":"https://github.com/graingert","followers_url":"https://api.github.com/users/graingert/followers","following_url":"https://api.github.com/users/graingert/following{/other_user}","gists_url":"https://api.github.com/users/graingert/gists{/gist_id}","starred_url":"https://api.github.com/users/graingert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graingert/subscriptions","organizations_url":"https://api.github.com/users/graingert/orgs","repos_url":"https://api.github.com/users/graingert/repos","events_url":"https://api.github.com/users/graingert/events{/privacy}","received_events_url":"https://api.github.com/users/graingert/received_events","type":"User","site_admin":false},"repo":{"id":35280897,"name":"redshift_sqlalchemy","full_name":"graingert/redshift_sqlalchemy","owner":{"login":"graingert","id":413772,"avatar_url":"https://avatars.githubusercontent.com/u/413772?v=3","gravatar_id":"","url":"https://api.github.com/users/graingert","html_url":"https://github.com/graingert","followers_url":"https://api.github.com/users/graingert/followers","following_url":"https://api.github.com/users/graingert/following{/other_user}","gists_url":"https://api.github.com/users/graingert/gists{/gist_id}","starred_url":"https://api.github.com/users/graingert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graingert/subscriptions","organizations_url":"https://api.github.com/users/graingert/orgs","repos_url":"https://api.github.com/users/graingert/repos","events_url":"https://api.github.com/users/graingert/events{/privacy}","received_events_url":"https://api.github.com/users/graingert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/graingert/redshift_sqlalchemy","description":"Amazon Redshift SQLAlchemy Dialect","fork":true,"url":"https://api.github.com/repos/graingert/redshift_sqlalchemy","forks_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/forks","keys_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/teams","hooks_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/hooks","issue_events_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/issues/events{/number}","events_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/events","assignees_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/assignees{/user}","branches_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/branches{/branch}","tags_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/tags","blobs_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/git/refs{/sha}","trees_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/statuses/{sha}","languages_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/languages","stargazers_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/stargazers","contributors_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/contributors","subscribers_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/subscribers","subscription_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/subscription","commits_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/commits{/sha}","git_commits_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/git/commits{/sha}","comments_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/comments{/number}","issue_comment_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/issues/comments{/number}","contents_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/contents/{+path}","compare_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/merges","archive_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/downloads","issues_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/issues{/number}","pulls_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/pulls{/number}","milestones_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/milestones{/number}","notifications_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/labels{/name}","releases_url":"https://api.github.com/repos/graingert/redshift_sqlalchemy/releases{/id}","created_at":"2015-05-08T13:29:24Z","updated_at":"2015-08-10T22:14:18Z","pushed_at":"2015-08-24T18:26:40Z","git_url":"git://github.com/graingert/redshift_sqlalchemy.git","ssh_url":"git@github.com:graingert/redshift_sqlalchemy.git","clone_url":"https://github.com/graingert/redshift_sqlalchemy.git","svn_url":"https://github.com/graingert/redshift_sqlalchemy","homepage":null,"size":516,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/graingert/redshift_sqlalchemy/pulls/20"},"html":{"href":"https://github.com/graingert/redshift_sqlalchemy/pull/20"},"issue":{"href":"https://api.github.com/repos/graingert/redshift_sqlalchemy/issues/20"},"comments":{"href":"https://api.github.com/repos/graingert/redshift_sqlalchemy/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/graingert/redshift_sqlalchemy/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/graingert/redshift_sqlalchemy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/graingert/redshift_sqlalchemy/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/graingert/redshift_sqlalchemy/statuses/1e09e37e89156189564b8167d18ff28db0ad9d31"}}}}