{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4853","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4853/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4853/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4853/events","html_url":"https://github.com/ManageIQ/manageiq/pull/4853","id":111358630,"number":4853,"title":"[WIP] Patternfly toolbars","user":{"login":"martinpovolny","id":51095,"avatar_url":"https://avatars.githubusercontent.com/u/51095?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/ui","name":"ui","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/wip","name":"wip","color":"eeeeee"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-10-14T09:29:32Z","updated_at":"2015-10-19T14:46:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4853","html_url":"https://github.com/ManageIQ/manageiq/pull/4853","diff_url":"https://github.com/ManageIQ/manageiq/pull/4853.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/4853.patch"},"body":"@jzigmund , @skateman , @dclarizio : minimal changes, no refactoring, straight run on replacing dhtmlx toolbars with Patterny toolbars from latest Patternfly \r\n\r\nhttps://rawgit.com/patternfly/patternfly/master/tests/toolbar.html\r\n\r\nTodo:\r\n * write all the client-side javascript (@skateman)\r\n * verify top button bar splitter (SPEC=./spec/controllers/miq_request_controller_spec.rb:142) in the UI\r\n * write some tests\r\n * cleanup, remove dead (ruby) code\r\n * remove dead HTML markup in place of the old toolbars, make sure that the new divs are there all the time\r\n * replace 12 occurences of  `miqReinitToolbars` with `javascript_pf_toolbar_reload` with the correct toolbar definition (figure out which toolbar to load into the center_tb) -- @jzigmund \r\n * styling tweeks and fixes -- @epwinchell : can you, please, start working on the styling of this PR? all the buttons and function should be there to allow that work\r\n\r\n![screenshot_2015-10-14_11-27-10](https://cloud.githubusercontent.com/assets/51095/10479829/d40ed28a-7266-11e5-90eb-d1b4f598de81.png)"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/149237126","html_url":"https://github.com/ManageIQ/manageiq/pull/4853#issuecomment-149237126","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4853","id":149237126,"user":{"login":"jzigmund","id":2270962,"avatar_url":"https://avatars.githubusercontent.com/u/2270962?v=3","gravatar_id":"","url":"https://api.github.com/users/jzigmund","html_url":"https://github.com/jzigmund","followers_url":"https://api.github.com/users/jzigmund/followers","following_url":"https://api.github.com/users/jzigmund/following{/other_user}","gists_url":"https://api.github.com/users/jzigmund/gists{/gist_id}","starred_url":"https://api.github.com/users/jzigmund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzigmund/subscriptions","organizations_url":"https://api.github.com/users/jzigmund/orgs","repos_url":"https://api.github.com/users/jzigmund/repos","events_url":"https://api.github.com/users/jzigmund/events{/privacy}","received_events_url":"https://api.github.com/users/jzigmund/received_events","type":"User","site_admin":false},"created_at":"2015-10-19T14:46:54Z","updated_at":"2015-10-19T14:46:54Z","body":"On Storage (in UI Datastores) related pages, none of the button is calling the miqReinitToolbar (note: manually tested)"}}