{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/2564","labels_url":"https://api.github.com/repos/openshift/origin/issues/2564/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/2564/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/2564/events","html_url":"https://github.com/openshift/origin/pull/2564","id":81977498,"number":2564,"title":"Refactor deploy retry to create a new deployment","user":{"login":"ironcladlou","id":298299,"avatar_url":"https://avatars.githubusercontent.com/u/298299?v=3","gravatar_id":"","url":"https://api.github.com/users/ironcladlou","html_url":"https://github.com/ironcladlou","followers_url":"https://api.github.com/users/ironcladlou/followers","following_url":"https://api.github.com/users/ironcladlou/following{/other_user}","gists_url":"https://api.github.com/users/ironcladlou/gists{/gist_id}","starred_url":"https://api.github.com/users/ironcladlou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironcladlou/subscriptions","organizations_url":"https://api.github.com/users/ironcladlou/orgs","repos_url":"https://api.github.com/users/ironcladlou/repos","events_url":"https://api.github.com/users/ironcladlou/events{/privacy}","received_events_url":"https://api.github.com/users/ironcladlou/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-05-28T15:17:05Z","updated_at":"2015-05-28T16:36:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/2564","html_url":"https://github.com/openshift/origin/pull/2564","diff_url":"https://github.com/openshift/origin/pull/2564.diff","patch_url":"https://github.com/openshift/origin/pull/2564.patch"},"body":"Now that deployer names are deterministic, the retry function can't\r\nsimply reset the status of a deployment, as the infra will attempt\r\nto recreate a deployer with the same name as the reset deployment.\r\n\r\nInstead, just create a new deployment upon retry.\r\n\r\nCloses #2558"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/106472321","html_url":"https://github.com/openshift/origin/pull/2564#issuecomment-106472321","issue_url":"https://api.github.com/repos/openshift/origin/issues/2564","id":106472321,"user":{"login":"ironcladlou","id":298299,"avatar_url":"https://avatars.githubusercontent.com/u/298299?v=3","gravatar_id":"","url":"https://api.github.com/users/ironcladlou","html_url":"https://github.com/ironcladlou","followers_url":"https://api.github.com/users/ironcladlou/followers","following_url":"https://api.github.com/users/ironcladlou/following{/other_user}","gists_url":"https://api.github.com/users/ironcladlou/gists{/gist_id}","starred_url":"https://api.github.com/users/ironcladlou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironcladlou/subscriptions","organizations_url":"https://api.github.com/users/ironcladlou/orgs","repos_url":"https://api.github.com/users/ironcladlou/repos","events_url":"https://api.github.com/users/ironcladlou/events{/privacy}","received_events_url":"https://api.github.com/users/ironcladlou/received_events","type":"User","site_admin":false},"created_at":"2015-05-28T16:36:54Z","updated_at":"2015-05-28T16:36:54Z","body":"@abhgupta \r\n>@ironcladlou Is there any difference between --latest and --retry any more? Also, retries originally retried the previous deployment faithfully since the deployment config was serialized as an annotation and not affected by subsequent changes to the deployment config. As it stands, we are not guaranteed to retry the exact same deployment - strategy could be different, hooks is another thing that could change (part of strategy config).\r\n\r\nThanks, I had totally forgotten about that design element."}}