{"action":"created","issue":{"url":"https://api.github.com/repos/puli/manager/issues/28","labels_url":"https://api.github.com/repos/puli/manager/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/puli/manager/issues/28/comments","events_url":"https://api.github.com/repos/puli/manager/issues/28/events","html_url":"https://github.com/puli/manager/pull/28","id":121367588,"number":28,"title":"Fix JsonFileStore instanciation in JsonFileStoreGenerator","user":{"login":"tgalopin","id":1651494,"avatar_url":"https://avatars.githubusercontent.com/u/1651494?v=3","gravatar_id":"","url":"https://api.github.com/users/tgalopin","html_url":"https://github.com/tgalopin","followers_url":"https://api.github.com/users/tgalopin/followers","following_url":"https://api.github.com/users/tgalopin/following{/other_user}","gists_url":"https://api.github.com/users/tgalopin/gists{/gist_id}","starred_url":"https://api.github.com/users/tgalopin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgalopin/subscriptions","organizations_url":"https://api.github.com/users/tgalopin/orgs","repos_url":"https://api.github.com/users/tgalopin/repos","events_url":"https://api.github.com/users/tgalopin/events{/privacy}","received_events_url":"https://api.github.com/users/tgalopin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-12-09T23:41:47Z","updated_at":"2015-12-10T12:23:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/puli/manager/pulls/28","html_url":"https://github.com/puli/manager/pull/28","diff_url":"https://github.com/puli/manager/pull/28.diff","patch_url":"https://github.com/puli/manager/pull/28.patch"},"body":"The `GeneratedPuliFactory` currently uses a very old way to implement the `JsonKeyValueStore`, with a cache argument (see https://github.com/webmozart/key-value-store/commit/1e60c6750f67af693f9451f1f65073847efb882d). When we removed the second argument,  PHP simply ignored the boolean and it went unnoticed.\r\n\r\nLater, when the `JsonKeyValueStore` got a second argument back (`$flag`, https://github.com/webmozart/key-value-store/commit/196c4c8ff4c643e6ba9f954ed482629620ac88d4#diff-d59c34cb33c1eb8de6bace8a46cfea1cR59), a problem started to appear and we got this issue : https://github.com/puli/issues/issues/142.\r\n\r\nThis PR aims to fix this. I removed the cache system completely as it seems a bit complicated to detect `doctrine/cache` in the generated file. What do you think?\r\n\r\n> **Side note:** I think this isn't a BC-break as the `GeneratedPuliFactory` is a\r\n> generated file, but please tell me if it is and I'll add a line in the Changelog."},"comment":{"url":"https://api.github.com/repos/puli/manager/issues/comments/163594775","html_url":"https://github.com/puli/manager/pull/28#issuecomment-163594775","issue_url":"https://api.github.com/repos/puli/manager/issues/28","id":163594775,"user":{"login":"EmanueleMinotto","id":417201,"avatar_url":"https://avatars.githubusercontent.com/u/417201?v=3","gravatar_id":"","url":"https://api.github.com/users/EmanueleMinotto","html_url":"https://github.com/EmanueleMinotto","followers_url":"https://api.github.com/users/EmanueleMinotto/followers","following_url":"https://api.github.com/users/EmanueleMinotto/following{/other_user}","gists_url":"https://api.github.com/users/EmanueleMinotto/gists{/gist_id}","starred_url":"https://api.github.com/users/EmanueleMinotto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EmanueleMinotto/subscriptions","organizations_url":"https://api.github.com/users/EmanueleMinotto/orgs","repos_url":"https://api.github.com/users/EmanueleMinotto/repos","events_url":"https://api.github.com/users/EmanueleMinotto/events{/privacy}","received_events_url":"https://api.github.com/users/EmanueleMinotto/received_events","type":"User","site_admin":false},"created_at":"2015-12-10T12:23:06Z","updated_at":"2015-12-10T12:23:06Z","body":"@tgalopin I didn't investigate in depth yet, but the problem is related to `setEscapeSlash` and the PHP 5.4+ `JSON_UNESCAPED_SLASHES ` ([ref](http://php.net/manual/en/function.json-encode.php#refsect1-function.json-encode-changelog))"}}