{"action":"closed","number":22,"pull_request":{"url":"https://api.github.com/repos/cegeka/puppet-sunjdk/pulls/22","id":28811831,"html_url":"https://github.com/cegeka/puppet-sunjdk/pull/22","diff_url":"https://github.com/cegeka/puppet-sunjdk/pull/22.diff","patch_url":"https://github.com/cegeka/puppet-sunjdk/pull/22.patch","issue_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/issues/22","number":22,"state":"closed","locked":false,"title":"Make jdk package name configurable","user":{"login":"bkkrw","id":2774045,"avatar_url":"https://avatars.githubusercontent.com/u/2774045?v=3","gravatar_id":"","url":"https://api.github.com/users/bkkrw","html_url":"https://github.com/bkkrw","followers_url":"https://api.github.com/users/bkkrw/followers","following_url":"https://api.github.com/users/bkkrw/following{/other_user}","gists_url":"https://api.github.com/users/bkkrw/gists{/gist_id}","starred_url":"https://api.github.com/users/bkkrw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkkrw/subscriptions","organizations_url":"https://api.github.com/users/bkkrw/orgs","repos_url":"https://api.github.com/users/bkkrw/repos","events_url":"https://api.github.com/users/bkkrw/events{/privacy}","received_events_url":"https://api.github.com/users/bkkrw/received_events","type":"User","site_admin":false},"body":"As Oracle changed the name of the JDK package from \"jdk\" to \"jdk<version>\",\r\nwe need to make the package name configurable.\r\n\r\nPossibilities:\r\n* Derive the package name from the version\r\n* Provide the package name explicitly\r\n\r\nAs deriving the name from the version seems rather fragile, I opted to provide\r\nthe package name explicitly. An example:\r\n\r\n    sunjdk:: instance { 'installing jdk1.8.0_31':\r\n      ensure      => 'present',\r\n      pkg_name    => 'jdk1.8.0_31',\r\n      jdk_version => 1.8.0_31-fcs',\r\n      versionlock => true\r\n    }\r\n\r\nAs the name and the version are now rather redundant, we can optionally leave out the version.","created_at":"2015-02-06T14:26:32Z","updated_at":"2015-02-06T14:29:24Z","closed_at":"2015-02-06T14:29:24Z","merged_at":"2015-02-06T14:29:24Z","merge_commit_sha":"2cdc9e06ff3e7715a9d68e77cd0c6059160a931d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/pulls/22/commits","review_comments_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/pulls/22/comments","review_comment_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/issues/22/comments","statuses_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/statuses/61494136a6cf65e559687e9f32ac34d1386b7ef4","head":{"label":"bkkrw:master","ref":"master","sha":"61494136a6cf65e559687e9f32ac34d1386b7ef4","user":{"login":"bkkrw","id":2774045,"avatar_url":"https://avatars.githubusercontent.com/u/2774045?v=3","gravatar_id":"","url":"https://api.github.com/users/bkkrw","html_url":"https://github.com/bkkrw","followers_url":"https://api.github.com/users/bkkrw/followers","following_url":"https://api.github.com/users/bkkrw/following{/other_user}","gists_url":"https://api.github.com/users/bkkrw/gists{/gist_id}","starred_url":"https://api.github.com/users/bkkrw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkkrw/subscriptions","organizations_url":"https://api.github.com/users/bkkrw/orgs","repos_url":"https://api.github.com/users/bkkrw/repos","events_url":"https://api.github.com/users/bkkrw/events{/privacy}","received_events_url":"https://api.github.com/users/bkkrw/received_events","type":"User","site_admin":false},"repo":{"id":8094597,"name":"puppet-sunjdk","full_name":"bkkrw/puppet-sunjdk","owner":{"login":"bkkrw","id":2774045,"avatar_url":"https://avatars.githubusercontent.com/u/2774045?v=3","gravatar_id":"","url":"https://api.github.com/users/bkkrw","html_url":"https://github.com/bkkrw","followers_url":"https://api.github.com/users/bkkrw/followers","following_url":"https://api.github.com/users/bkkrw/following{/other_user}","gists_url":"https://api.github.com/users/bkkrw/gists{/gist_id}","starred_url":"https://api.github.com/users/bkkrw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkkrw/subscriptions","organizations_url":"https://api.github.com/users/bkkrw/orgs","repos_url":"https://api.github.com/users/bkkrw/repos","events_url":"https://api.github.com/users/bkkrw/events{/privacy}","received_events_url":"https://api.github.com/users/bkkrw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bkkrw/puppet-sunjdk","description":null,"fork":true,"url":"https://api.github.com/repos/bkkrw/puppet-sunjdk","forks_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/forks","keys_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/teams","hooks_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/hooks","issue_events_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/issues/events{/number}","events_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/events","assignees_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/assignees{/user}","branches_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/branches{/branch}","tags_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/tags","blobs_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/statuses/{sha}","languages_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/languages","stargazers_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/stargazers","contributors_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/contributors","subscribers_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/subscribers","subscription_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/subscription","commits_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/issues/comments/{number}","contents_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/contents/{+path}","compare_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/merges","archive_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/downloads","issues_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/issues{/number}","pulls_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/pulls{/number}","milestones_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/milestones{/number}","notifications_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/labels{/name}","releases_url":"https://api.github.com/repos/bkkrw/puppet-sunjdk/releases{/id}","created_at":"2013-02-08T14:14:21Z","updated_at":"2015-02-06T14:11:24Z","pushed_at":"2015-02-06T14:11:23Z","git_url":"git://github.com/bkkrw/puppet-sunjdk.git","ssh_url":"git@github.com:bkkrw/puppet-sunjdk.git","clone_url":"https://github.com/bkkrw/puppet-sunjdk.git","svn_url":"https://github.com/bkkrw/puppet-sunjdk","homepage":"https://github.com","size":130716,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cegeka:master","ref":"master","sha":"5801909ba420d5b8efaf09976c29cf62cf956f74","user":{"login":"cegeka","id":1333450,"avatar_url":"https://avatars.githubusercontent.com/u/1333450?v=3","gravatar_id":"","url":"https://api.github.com/users/cegeka","html_url":"https://github.com/cegeka","followers_url":"https://api.github.com/users/cegeka/followers","following_url":"https://api.github.com/users/cegeka/following{/other_user}","gists_url":"https://api.github.com/users/cegeka/gists{/gist_id}","starred_url":"https://api.github.com/users/cegeka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cegeka/subscriptions","organizations_url":"https://api.github.com/users/cegeka/orgs","repos_url":"https://api.github.com/users/cegeka/repos","events_url":"https://api.github.com/users/cegeka/events{/privacy}","received_events_url":"https://api.github.com/users/cegeka/received_events","type":"Organization","site_admin":false},"repo":{"id":4419190,"name":"puppet-sunjdk","full_name":"cegeka/puppet-sunjdk","owner":{"login":"cegeka","id":1333450,"avatar_url":"https://avatars.githubusercontent.com/u/1333450?v=3","gravatar_id":"","url":"https://api.github.com/users/cegeka","html_url":"https://github.com/cegeka","followers_url":"https://api.github.com/users/cegeka/followers","following_url":"https://api.github.com/users/cegeka/following{/other_user}","gists_url":"https://api.github.com/users/cegeka/gists{/gist_id}","starred_url":"https://api.github.com/users/cegeka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cegeka/subscriptions","organizations_url":"https://api.github.com/users/cegeka/orgs","repos_url":"https://api.github.com/users/cegeka/repos","events_url":"https://api.github.com/users/cegeka/events{/privacy}","received_events_url":"https://api.github.com/users/cegeka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cegeka/puppet-sunjdk","description":null,"fork":false,"url":"https://api.github.com/repos/cegeka/puppet-sunjdk","forks_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/forks","keys_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/teams","hooks_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/hooks","issue_events_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/issues/events{/number}","events_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/events","assignees_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/assignees{/user}","branches_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/branches{/branch}","tags_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/tags","blobs_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/statuses/{sha}","languages_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/languages","stargazers_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/stargazers","contributors_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/contributors","subscribers_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/subscribers","subscription_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/subscription","commits_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/issues/comments/{number}","contents_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/contents/{+path}","compare_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/merges","archive_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/downloads","issues_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/issues{/number}","pulls_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/pulls{/number}","milestones_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/milestones{/number}","notifications_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/labels{/name}","releases_url":"https://api.github.com/repos/cegeka/puppet-sunjdk/releases{/id}","created_at":"2012-05-23T11:25:53Z","updated_at":"2014-07-31T13:26:42Z","pushed_at":"2015-02-06T14:29:24Z","git_url":"git://github.com/cegeka/puppet-sunjdk.git","ssh_url":"git@github.com:cegeka/puppet-sunjdk.git","clone_url":"https://github.com/cegeka/puppet-sunjdk.git","svn_url":"https://github.com/cegeka/puppet-sunjdk","homepage":"https://github.com","size":130750,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":0,"forks":4,"open_issues":0,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cegeka/puppet-sunjdk/pulls/22"},"html":{"href":"https://github.com/cegeka/puppet-sunjdk/pull/22"},"issue":{"href":"https://api.github.com/repos/cegeka/puppet-sunjdk/issues/22"},"comments":{"href":"https://api.github.com/repos/cegeka/puppet-sunjdk/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/cegeka/puppet-sunjdk/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/cegeka/puppet-sunjdk/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cegeka/puppet-sunjdk/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/cegeka/puppet-sunjdk/statuses/61494136a6cf65e559687e9f32ac34d1386b7ef4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dieterdemeyer","id":523286,"avatar_url":"https://avatars.githubusercontent.com/u/523286?v=3","gravatar_id":"","url":"https://api.github.com/users/dieterdemeyer","html_url":"https://github.com/dieterdemeyer","followers_url":"https://api.github.com/users/dieterdemeyer/followers","following_url":"https://api.github.com/users/dieterdemeyer/following{/other_user}","gists_url":"https://api.github.com/users/dieterdemeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/dieterdemeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dieterdemeyer/subscriptions","organizations_url":"https://api.github.com/users/dieterdemeyer/orgs","repos_url":"https://api.github.com/users/dieterdemeyer/repos","events_url":"https://api.github.com/users/dieterdemeyer/events{/privacy}","received_events_url":"https://api.github.com/users/dieterdemeyer/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":79,"deletions":47,"changed_files":5}}