{"action":"created","comment":{"url":"https://api.github.com/repos/lichray/moecache/pulls/comments/25984701","id":25984701,"diff_hunk":"@@ -422,25 +478,39 @@ def set(self, key, val, exptime=0):\n \n         if isinstance(val, str):\n             flag = ' 274 '  # 18 | 0x100\n-            sent = val\n+            if Client.is_py3:\n+                sent = bytearray(val, 'utf-8')","path":"moecache.py","position":195,"original_position":195,"commit_id":"3b8f501b9ad18c82fbf9ada1f8f24b02bbd8af4b","original_commit_id":"3b8f501b9ad18c82fbf9ada1f8f24b02bbd8af4b","user":{"login":"lichray","id":433009,"avatar_url":"https://avatars.githubusercontent.com/u/433009?v=3","gravatar_id":"","url":"https://api.github.com/users/lichray","html_url":"https://github.com/lichray","followers_url":"https://api.github.com/users/lichray/followers","following_url":"https://api.github.com/users/lichray/following{/other_user}","gists_url":"https://api.github.com/users/lichray/gists{/gist_id}","starred_url":"https://api.github.com/users/lichray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lichray/subscriptions","organizations_url":"https://api.github.com/users/lichray/orgs","repos_url":"https://api.github.com/users/lichray/repos","events_url":"https://api.github.com/users/lichray/events{/privacy}","received_events_url":"https://api.github.com/users/lichray/received_events","type":"User","site_admin":false},"body":"`val.decode('utf-8')` is more traditional.","created_at":"2015-03-06T22:42:05Z","updated_at":"2015-03-06T22:42:05Z","html_url":"https://github.com/lichray/moecache/pull/1#discussion_r25984701","pull_request_url":"https://api.github.com/repos/lichray/moecache/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/lichray/moecache/pulls/comments/25984701"},"html":{"href":"https://github.com/lichray/moecache/pull/1#discussion_r25984701"},"pull_request":{"href":"https://api.github.com/repos/lichray/moecache/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/lichray/moecache/pulls/1","id":30646110,"html_url":"https://github.com/lichray/moecache/pull/1","diff_url":"https://github.com/lichray/moecache/pull/1.diff","patch_url":"https://github.com/lichray/moecache/pull/1.patch","issue_url":"https://api.github.com/repos/lichray/moecache/issues/1","number":1,"state":"open","locked":false,"title":"Try py3 compatibility","user":{"login":"isaacm","id":838526,"avatar_url":"https://avatars.githubusercontent.com/u/838526?v=3","gravatar_id":"","url":"https://api.github.com/users/isaacm","html_url":"https://github.com/isaacm","followers_url":"https://api.github.com/users/isaacm/followers","following_url":"https://api.github.com/users/isaacm/following{/other_user}","gists_url":"https://api.github.com/users/isaacm/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacm/subscriptions","organizations_url":"https://api.github.com/users/isaacm/orgs","repos_url":"https://api.github.com/users/isaacm/repos","events_url":"https://api.github.com/users/isaacm/events{/privacy}","received_events_url":"https://api.github.com/users/isaacm/received_events","type":"User","site_admin":false},"body":"Please review.","created_at":"2015-03-06T13:56:32Z","updated_at":"2015-03-06T22:42:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be91a8934b5e2af5ca5a1cf4f282c0ac1fe1e35d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lichray/moecache/pulls/1/commits","review_comments_url":"https://api.github.com/repos/lichray/moecache/pulls/1/comments","review_comment_url":"https://api.github.com/repos/lichray/moecache/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lichray/moecache/issues/1/comments","statuses_url":"https://api.github.com/repos/lichray/moecache/statuses/3b8f501b9ad18c82fbf9ada1f8f24b02bbd8af4b","head":{"label":"isaacm:py3-compat","ref":"py3-compat","sha":"3b8f501b9ad18c82fbf9ada1f8f24b02bbd8af4b","user":{"login":"isaacm","id":838526,"avatar_url":"https://avatars.githubusercontent.com/u/838526?v=3","gravatar_id":"","url":"https://api.github.com/users/isaacm","html_url":"https://github.com/isaacm","followers_url":"https://api.github.com/users/isaacm/followers","following_url":"https://api.github.com/users/isaacm/following{/other_user}","gists_url":"https://api.github.com/users/isaacm/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacm/subscriptions","organizations_url":"https://api.github.com/users/isaacm/orgs","repos_url":"https://api.github.com/users/isaacm/repos","events_url":"https://api.github.com/users/isaacm/events{/privacy}","received_events_url":"https://api.github.com/users/isaacm/received_events","type":"User","site_admin":false},"repo":{"id":31733918,"name":"moecache","full_name":"isaacm/moecache","owner":{"login":"isaacm","id":838526,"avatar_url":"https://avatars.githubusercontent.com/u/838526?v=3","gravatar_id":"","url":"https://api.github.com/users/isaacm","html_url":"https://github.com/isaacm","followers_url":"https://api.github.com/users/isaacm/followers","following_url":"https://api.github.com/users/isaacm/following{/other_user}","gists_url":"https://api.github.com/users/isaacm/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacm/subscriptions","organizations_url":"https://api.github.com/users/isaacm/orgs","repos_url":"https://api.github.com/users/isaacm/repos","events_url":"https://api.github.com/users/isaacm/events{/privacy}","received_events_url":"https://api.github.com/users/isaacm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/isaacm/moecache","description":"A memcached client with a different shading strategy.","fork":true,"url":"https://api.github.com/repos/isaacm/moecache","forks_url":"https://api.github.com/repos/isaacm/moecache/forks","keys_url":"https://api.github.com/repos/isaacm/moecache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/isaacm/moecache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/isaacm/moecache/teams","hooks_url":"https://api.github.com/repos/isaacm/moecache/hooks","issue_events_url":"https://api.github.com/repos/isaacm/moecache/issues/events{/number}","events_url":"https://api.github.com/repos/isaacm/moecache/events","assignees_url":"https://api.github.com/repos/isaacm/moecache/assignees{/user}","branches_url":"https://api.github.com/repos/isaacm/moecache/branches{/branch}","tags_url":"https://api.github.com/repos/isaacm/moecache/tags","blobs_url":"https://api.github.com/repos/isaacm/moecache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/isaacm/moecache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/isaacm/moecache/git/refs{/sha}","trees_url":"https://api.github.com/repos/isaacm/moecache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/isaacm/moecache/statuses/{sha}","languages_url":"https://api.github.com/repos/isaacm/moecache/languages","stargazers_url":"https://api.github.com/repos/isaacm/moecache/stargazers","contributors_url":"https://api.github.com/repos/isaacm/moecache/contributors","subscribers_url":"https://api.github.com/repos/isaacm/moecache/subscribers","subscription_url":"https://api.github.com/repos/isaacm/moecache/subscription","commits_url":"https://api.github.com/repos/isaacm/moecache/commits{/sha}","git_commits_url":"https://api.github.com/repos/isaacm/moecache/git/commits{/sha}","comments_url":"https://api.github.com/repos/isaacm/moecache/comments{/number}","issue_comment_url":"https://api.github.com/repos/isaacm/moecache/issues/comments{/number}","contents_url":"https://api.github.com/repos/isaacm/moecache/contents/{+path}","compare_url":"https://api.github.com/repos/isaacm/moecache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/isaacm/moecache/merges","archive_url":"https://api.github.com/repos/isaacm/moecache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/isaacm/moecache/downloads","issues_url":"https://api.github.com/repos/isaacm/moecache/issues{/number}","pulls_url":"https://api.github.com/repos/isaacm/moecache/pulls{/number}","milestones_url":"https://api.github.com/repos/isaacm/moecache/milestones{/number}","notifications_url":"https://api.github.com/repos/isaacm/moecache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/isaacm/moecache/labels{/name}","releases_url":"https://api.github.com/repos/isaacm/moecache/releases{/id}","created_at":"2015-03-05T20:11:34Z","updated_at":"2015-03-05T20:11:34Z","pushed_at":"2015-03-06T22:27:21Z","git_url":"git://github.com/isaacm/moecache.git","ssh_url":"git@github.com:isaacm/moecache.git","clone_url":"https://github.com/isaacm/moecache.git","svn_url":"https://github.com/isaacm/moecache","homepage":"http://pythonhosted.org/moecache/","size":264,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lichray:master","ref":"master","sha":"cec21cfec170632efcccc657c8aed9e297ca3ab3","user":{"login":"lichray","id":433009,"avatar_url":"https://avatars.githubusercontent.com/u/433009?v=3","gravatar_id":"","url":"https://api.github.com/users/lichray","html_url":"https://github.com/lichray","followers_url":"https://api.github.com/users/lichray/followers","following_url":"https://api.github.com/users/lichray/following{/other_user}","gists_url":"https://api.github.com/users/lichray/gists{/gist_id}","starred_url":"https://api.github.com/users/lichray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lichray/subscriptions","organizations_url":"https://api.github.com/users/lichray/orgs","repos_url":"https://api.github.com/users/lichray/repos","events_url":"https://api.github.com/users/lichray/events{/privacy}","received_events_url":"https://api.github.com/users/lichray/received_events","type":"User","site_admin":false},"repo":{"id":18559207,"name":"moecache","full_name":"lichray/moecache","owner":{"login":"lichray","id":433009,"avatar_url":"https://avatars.githubusercontent.com/u/433009?v=3","gravatar_id":"","url":"https://api.github.com/users/lichray","html_url":"https://github.com/lichray","followers_url":"https://api.github.com/users/lichray/followers","following_url":"https://api.github.com/users/lichray/following{/other_user}","gists_url":"https://api.github.com/users/lichray/gists{/gist_id}","starred_url":"https://api.github.com/users/lichray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lichray/subscriptions","organizations_url":"https://api.github.com/users/lichray/orgs","repos_url":"https://api.github.com/users/lichray/repos","events_url":"https://api.github.com/users/lichray/events{/privacy}","received_events_url":"https://api.github.com/users/lichray/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lichray/moecache","description":"A memcached client with a different shading strategy.","fork":true,"url":"https://api.github.com/repos/lichray/moecache","forks_url":"https://api.github.com/repos/lichray/moecache/forks","keys_url":"https://api.github.com/repos/lichray/moecache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lichray/moecache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lichray/moecache/teams","hooks_url":"https://api.github.com/repos/lichray/moecache/hooks","issue_events_url":"https://api.github.com/repos/lichray/moecache/issues/events{/number}","events_url":"https://api.github.com/repos/lichray/moecache/events","assignees_url":"https://api.github.com/repos/lichray/moecache/assignees{/user}","branches_url":"https://api.github.com/repos/lichray/moecache/branches{/branch}","tags_url":"https://api.github.com/repos/lichray/moecache/tags","blobs_url":"https://api.github.com/repos/lichray/moecache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lichray/moecache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lichray/moecache/git/refs{/sha}","trees_url":"https://api.github.com/repos/lichray/moecache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lichray/moecache/statuses/{sha}","languages_url":"https://api.github.com/repos/lichray/moecache/languages","stargazers_url":"https://api.github.com/repos/lichray/moecache/stargazers","contributors_url":"https://api.github.com/repos/lichray/moecache/contributors","subscribers_url":"https://api.github.com/repos/lichray/moecache/subscribers","subscription_url":"https://api.github.com/repos/lichray/moecache/subscription","commits_url":"https://api.github.com/repos/lichray/moecache/commits{/sha}","git_commits_url":"https://api.github.com/repos/lichray/moecache/git/commits{/sha}","comments_url":"https://api.github.com/repos/lichray/moecache/comments{/number}","issue_comment_url":"https://api.github.com/repos/lichray/moecache/issues/comments{/number}","contents_url":"https://api.github.com/repos/lichray/moecache/contents/{+path}","compare_url":"https://api.github.com/repos/lichray/moecache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lichray/moecache/merges","archive_url":"https://api.github.com/repos/lichray/moecache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lichray/moecache/downloads","issues_url":"https://api.github.com/repos/lichray/moecache/issues{/number}","pulls_url":"https://api.github.com/repos/lichray/moecache/pulls{/number}","milestones_url":"https://api.github.com/repos/lichray/moecache/milestones{/number}","notifications_url":"https://api.github.com/repos/lichray/moecache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lichray/moecache/labels{/name}","releases_url":"https://api.github.com/repos/lichray/moecache/releases{/id}","created_at":"2014-04-08T13:29:25Z","updated_at":"2014-05-01T19:54:09Z","pushed_at":"2014-05-01T19:52:07Z","git_url":"git://github.com/lichray/moecache.git","ssh_url":"git@github.com:lichray/moecache.git","clone_url":"https://github.com/lichray/moecache.git","svn_url":"https://github.com/lichray/moecache","homepage":"http://pythonhosted.org/moecache/","size":583,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lichray/moecache/pulls/1"},"html":{"href":"https://github.com/lichray/moecache/pull/1"},"issue":{"href":"https://api.github.com/repos/lichray/moecache/issues/1"},"comments":{"href":"https://api.github.com/repos/lichray/moecache/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/lichray/moecache/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/lichray/moecache/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lichray/moecache/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/lichray/moecache/statuses/3b8f501b9ad18c82fbf9ada1f8f24b02bbd8af4b"}}}}