{"action":"created","issue":{"url":"https://api.github.com/repos/flux-framework/flux-core/issues/391","labels_url":"https://api.github.com/repos/flux-framework/flux-core/issues/391/labels{/name}","comments_url":"https://api.github.com/repos/flux-framework/flux-core/issues/391/comments","events_url":"https://api.github.com/repos/flux-framework/flux-core/issues/391/events","html_url":"https://github.com/flux-framework/flux-core/pull/391","id":104796987,"number":391,"title":"jsc: increase kvs key buffer sizes","user":{"login":"dongahn","id":862123,"avatar_url":"https://avatars.githubusercontent.com/u/862123?v=3","gravatar_id":"","url":"https://api.github.com/users/dongahn","html_url":"https://github.com/dongahn","followers_url":"https://api.github.com/users/dongahn/followers","following_url":"https://api.github.com/users/dongahn/following{/other_user}","gists_url":"https://api.github.com/users/dongahn/gists{/gist_id}","starred_url":"https://api.github.com/users/dongahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongahn/subscriptions","organizations_url":"https://api.github.com/users/dongahn/orgs","repos_url":"https://api.github.com/users/dongahn/repos","events_url":"https://api.github.com/users/dongahn/events{/privacy}","received_events_url":"https://api.github.com/users/dongahn/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/flux-framework/flux-core/labels/review","name":"review","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-09-03T22:52:42Z","updated_at":"2015-09-03T23:16:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/flux-framework/flux-core/pulls/391","html_url":"https://github.com/flux-framework/flux-core/pull/391","diff_url":"https://github.com/flux-framework/flux-core/pull/391.diff","patch_url":"https://github.com/flux-framework/flux-core/pull/391.patch"},"body":"- take into account the max number of digits (20) that int64_t type can hold for kvs-key-buffer sizes\r\n\r\n-  fixes a problem where a truncated kvs to a lwj.<id>.rank.cores led to a later wrexec failure"},"comment":{"url":"https://api.github.com/repos/flux-framework/flux-core/issues/comments/137599018","html_url":"https://github.com/flux-framework/flux-core/pull/391#issuecomment-137599018","issue_url":"https://api.github.com/repos/flux-framework/flux-core/issues/391","id":137599018,"user":{"login":"trws","id":660149,"avatar_url":"https://avatars.githubusercontent.com/u/660149?v=3","gravatar_id":"","url":"https://api.github.com/users/trws","html_url":"https://github.com/trws","followers_url":"https://api.github.com/users/trws/followers","following_url":"https://api.github.com/users/trws/following{/other_user}","gists_url":"https://api.github.com/users/trws/gists{/gist_id}","starred_url":"https://api.github.com/users/trws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trws/subscriptions","organizations_url":"https://api.github.com/users/trws/orgs","repos_url":"https://api.github.com/users/trws/repos","events_url":"https://api.github.com/users/trws/events{/privacy}","received_events_url":"https://api.github.com/users/trws/received_events","type":"User","site_admin":false},"created_at":"2015-09-03T23:16:39Z","updated_at":"2015-09-03T23:16:39Z","body":"Yeah, highly recommended for building strings that may need to have their size change dynamically.  It's easy, or at least easier than base C string handling, also quite snappy and binary safe too. (just make sure you free with sdsfree, that's all)\r\n\r\nOr actually for this it could just be asprintf for that matter, but sds can be materially cheaper than using any of the printf variants if you use the sdscatfmt instead of sds...printf whatever, it's a custom restricted version with a lot of the branches stripped out for basic string formatting like this."}}