{"action":"created","issue":{"url":"https://api.github.com/repos/philc/vimium/issues/1722","labels_url":"https://api.github.com/repos/philc/vimium/issues/1722/labels{/name}","comments_url":"https://api.github.com/repos/philc/vimium/issues/1722/comments","events_url":"https://api.github.com/repos/philc/vimium/issues/1722/events","html_url":"https://github.com/philc/vimium/pull/1722","id":85886358,"number":1722,"title":"Use \"keypress\" for link hints (instead of \"keydown\")","user":{"login":"smblott-github","id":2641335,"avatar_url":"https://avatars.githubusercontent.com/u/2641335?v=3","gravatar_id":"","url":"https://api.github.com/users/smblott-github","html_url":"https://github.com/smblott-github","followers_url":"https://api.github.com/users/smblott-github/followers","following_url":"https://api.github.com/users/smblott-github/following{/other_user}","gists_url":"https://api.github.com/users/smblott-github/gists{/gist_id}","starred_url":"https://api.github.com/users/smblott-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smblott-github/subscriptions","organizations_url":"https://api.github.com/users/smblott-github/orgs","repos_url":"https://api.github.com/users/smblott-github/repos","events_url":"https://api.github.com/users/smblott-github/events{/privacy}","received_events_url":"https://api.github.com/users/smblott-github/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-06-07T10:01:07Z","updated_at":"2015-06-09T07:48:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/philc/vimium/pulls/1722","html_url":"https://github.com/philc/vimium/pull/1722","diff_url":"https://github.com/philc/vimium/pull/1722.diff","patch_url":"https://github.com/philc/vimium/pull/1722.patch"},"body":"Currently, if the user sets non-ASCII link-hint characters on the options page, they can't select links because we use the `keydown` event.  This uses `keypress` instead.  It should be the case that whatever characters the user can type into options-page option (from which we generate link hints), they can later type those same characters to activate link hints.\r\n\r\n(Also, exit link-hints mode on `click` and `scroll` events.)\r\n\r\n~~Fixes~~ Related to #1387 (I think)."},"comment":{"url":"https://api.github.com/repos/philc/vimium/issues/comments/110263346","html_url":"https://github.com/philc/vimium/pull/1722#issuecomment-110263346","issue_url":"https://api.github.com/repos/philc/vimium/issues/1722","id":110263346,"user":{"login":"mrmr1993","id":1847343,"avatar_url":"https://avatars.githubusercontent.com/u/1847343?v=3","gravatar_id":"","url":"https://api.github.com/users/mrmr1993","html_url":"https://github.com/mrmr1993","followers_url":"https://api.github.com/users/mrmr1993/followers","following_url":"https://api.github.com/users/mrmr1993/following{/other_user}","gists_url":"https://api.github.com/users/mrmr1993/gists{/gist_id}","starred_url":"https://api.github.com/users/mrmr1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrmr1993/subscriptions","organizations_url":"https://api.github.com/users/mrmr1993/orgs","repos_url":"https://api.github.com/users/mrmr1993/repos","events_url":"https://api.github.com/users/mrmr1993/events{/privacy}","received_events_url":"https://api.github.com/users/mrmr1993/received_events","type":"User","site_admin":false},"created_at":"2015-06-09T07:48:52Z","updated_at":"2015-06-09T07:48:52Z","body":"@smblott-github that looks great, it should cover the cases I was concerned about nicely. (NB: The `useKeydown` regexp could include `0-9` as well without causing any problems.)\r\n\r\n> Doing the same thing for number hints isn't quite so obvious... seems too confusing for users.\r\n\r\nAgreed. Being able to filter links with non-ASCII characters is a big positive here, so it seems fair to let that and simplicity take priority."}}