{"action":"created","issue":{"url":"https://api.github.com/repos/google/incremental-dom/issues/47","labels_url":"https://api.github.com/repos/google/incremental-dom/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/google/incremental-dom/issues/47/comments","events_url":"https://api.github.com/repos/google/incremental-dom/issues/47/events","html_url":"https://github.com/google/incremental-dom/pull/47","id":94437580,"number":47,"title":"Bugfixes: positional attributes and trailing attributes","user":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-07-11T05:13:12Z","updated_at":"2015-07-11T05:41:09Z","closed_at":"2015-07-11T05:41:07Z","pull_request":{"url":"https://api.github.com/repos/google/incremental-dom/pulls/47","html_url":"https://github.com/google/incremental-dom/pull/47","diff_url":"https://github.com/google/incremental-dom/pull/47.diff","patch_url":"https://github.com/google/incremental-dom/pull/47.patch"},"body":"Fixes two bugs:\r\n\r\n1. [Swapping attribute positions may not update attributes](https://github.com/google/incremental-dom/commit/cdf2800889092ae68e628823694fdf5e1db45fdd)\r\n\r\n  ```js\r\n  var container = document.createElement(‘div’);\r\n  patch(container, function() {\r\n  elementOpen(‘div’, null, null, ‘class’, ‘test’);\r\n  elementClose();\r\n  });\r\n  patch(container, function() {\r\n  elementOpen(‘div’, null, null, ‘id’, ‘test’);\r\n  elementClose();\r\n  });\r\n\r\n  var el = container.firstChild;\r\n  el.className; // “test”\r\n  el.id; // => “”\r\n  ```\r\n\r\n2. [Any missing trailing attributes won't be removed](https://github.com/google/incremental-dom/commit/fcba7ac2f2aa5fec6f568d21537b1eeca09db6ae)\r\n\r\n  ```js\r\n  var container = document.createElement(‘div’);\r\n  patch(container, function() {\r\n    elementOpen(‘div’, null, null, ‘class’, ‘test’, ‘id’, ‘test’);\r\n    elementClose();\r\n  });\r\n  patch(container, function() {\r\n    elementOpen(‘div’, null, null, ‘class’, ‘test’);\r\n    elementClose();\r\n  });\r\n\r\n  var el = container.firstChild;\r\n  el.id; // => “test”\r\n  ```"},"comment":{"url":"https://api.github.com/repos/google/incremental-dom/issues/comments/120579329","html_url":"https://github.com/google/incremental-dom/pull/47#issuecomment-120579329","issue_url":"https://api.github.com/repos/google/incremental-dom/issues/47","id":120579329,"user":{"login":"sparhami","id":1410321,"avatar_url":"https://avatars.githubusercontent.com/u/1410321?v=3","gravatar_id":"","url":"https://api.github.com/users/sparhami","html_url":"https://github.com/sparhami","followers_url":"https://api.github.com/users/sparhami/followers","following_url":"https://api.github.com/users/sparhami/following{/other_user}","gists_url":"https://api.github.com/users/sparhami/gists{/gist_id}","starred_url":"https://api.github.com/users/sparhami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sparhami/subscriptions","organizations_url":"https://api.github.com/users/sparhami/orgs","repos_url":"https://api.github.com/users/sparhami/repos","events_url":"https://api.github.com/users/sparhami/events{/privacy}","received_events_url":"https://api.github.com/users/sparhami/received_events","type":"User","site_admin":false},"created_at":"2015-07-11T05:41:09Z","updated_at":"2015-07-11T05:41:09Z","body":"Nice catch."}}