{"action":"created","issue":{"url":"https://api.github.com/repos/ibara/oksh/issues/1","labels_url":"https://api.github.com/repos/ibara/oksh/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/ibara/oksh/issues/1/comments","events_url":"https://api.github.com/repos/ibara/oksh/issues/1/events","html_url":"https://github.com/ibara/oksh/pull/1","id":73487869,"number":1,"title":"`make install` on Ubuntu and FreeBSD","user":{"login":"0xMF","id":6260119,"avatar_url":"https://avatars.githubusercontent.com/u/6260119?v=3","gravatar_id":"","url":"https://api.github.com/users/0xMF","html_url":"https://github.com/0xMF","followers_url":"https://api.github.com/users/0xMF/followers","following_url":"https://api.github.com/users/0xMF/following{/other_user}","gists_url":"https://api.github.com/users/0xMF/gists{/gist_id}","starred_url":"https://api.github.com/users/0xMF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xMF/subscriptions","organizations_url":"https://api.github.com/users/0xMF/orgs","repos_url":"https://api.github.com/users/0xMF/repos","events_url":"https://api.github.com/users/0xMF/events{/privacy}","received_events_url":"https://api.github.com/users/0xMF/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-05-06T02:02:32Z","updated_at":"2015-05-08T14:02:11Z","closed_at":"2015-05-07T02:39:37Z","pull_request":{"url":"https://api.github.com/repos/ibara/oksh/pulls/1","html_url":"https://github.com/ibara/oksh/pull/1","diff_url":"https://github.com/ibara/oksh/pull/1.diff","patch_url":"https://github.com/ibara/oksh/pull/1.patch"},"body":"Handles the following `make install` situations:\r\n\r\n- correctly identifies group for oksh on Ubuntu as `root`, while on FreeBSD sets oksh group `wheel`\r\n- ensures one entry in `/etc/shells`. So, an oksh update doesn't create a new entry in `/etc/shells`\r\n- verifies user is root, a common error by non-root users on Linux. Now make fails telling user why\r\n\r\nDue to the wackiness of gmake and bsd-make, I was forced to split logic into separate Makefiles and detect which one needs to be called. \r\n\r\n`Makefile`,  on Ubuntu, uses gmake and includes `Makefile.linux` whereas on FreeBSD `Makefile` uses bsd-make and includes `Makefile.bsd`, thereby `Makefile` only requires the os-native build tools."},"comment":{"url":"https://api.github.com/repos/ibara/oksh/issues/comments/100241036","html_url":"https://github.com/ibara/oksh/pull/1#issuecomment-100241036","issue_url":"https://api.github.com/repos/ibara/oksh/issues/1","id":100241036,"user":{"login":"ibara","id":3883351,"avatar_url":"https://avatars.githubusercontent.com/u/3883351?v=3","gravatar_id":"","url":"https://api.github.com/users/ibara","html_url":"https://github.com/ibara","followers_url":"https://api.github.com/users/ibara/followers","following_url":"https://api.github.com/users/ibara/following{/other_user}","gists_url":"https://api.github.com/users/ibara/gists{/gist_id}","starred_url":"https://api.github.com/users/ibara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibara/subscriptions","organizations_url":"https://api.github.com/users/ibara/orgs","repos_url":"https://api.github.com/users/ibara/repos","events_url":"https://api.github.com/users/ibara/events{/privacy}","received_events_url":"https://api.github.com/users/ibara/received_events","type":"User","site_admin":false},"created_at":"2015-05-08T14:02:11Z","updated_at":"2015-05-08T14:02:11Z","body":"My knowledge of git is just about zero. Blame me knowing CVS for that.\r\nBut hey it worked out so I'm just gonna say it's magic :-)"}}