{"action":"created","comment":{"url":"https://api.github.com/repos/otwcode/otwarchive/pulls/comments/30131563","id":30131563,"diff_hunk":"@@ -215,40 +214,43 @@ def cache!\n     self.cached = true\n     save!\n   end\n-  \n+\n   def clear_cache!\n     skin_dir = Skin.skins_dir + skin_dirname\n-    FileUtils.rm_rf skin_dir # clear out old if exists    \n+    FileUtils.rm_rf skin_dir # clear out old if exists\n     self.cached = false\n     save!\n   end\n-  \n+\n   def get_sheet_role\n     \"#{get_role}_#{get_media_for_filename}_#{ie_condition}\"\n   end\n-  \n+\n   # have to handle any media types that aren't a single alphanumeric word here\n   def get_media_for_filename\n     ((media.nil? || media.empty?) ? DEFAULT_MEDIA : media).map {|m|\n-      case \n-      when m.match(/max-width/)\n-        \"maxwidth\"\n+      case\n+      when m.match(/max-width: 44em/)\n+        \"narrow\"\n+      when m.match(/max-width: 64px/)","path":"app/models/skin.rb","position":148,"original_position":148,"commit_id":"bf8b87f1f6de0491bb4b3f3ffa7feced3a8a251f","original_commit_id":"bf8b87f1f6de0491bb4b3f3ffa7feced3a8a251f","user":{"login":"samjohnsson","id":1217668,"avatar_url":"https://avatars.githubusercontent.com/u/1217668?v=3","gravatar_id":"","url":"https://api.github.com/users/samjohnsson","html_url":"https://github.com/samjohnsson","followers_url":"https://api.github.com/users/samjohnsson/followers","following_url":"https://api.github.com/users/samjohnsson/following{/other_user}","gists_url":"https://api.github.com/users/samjohnsson/gists{/gist_id}","starred_url":"https://api.github.com/users/samjohnsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samjohnsson/subscriptions","organizations_url":"https://api.github.com/users/samjohnsson/orgs","repos_url":"https://api.github.com/users/samjohnsson/repos","events_url":"https://api.github.com/users/samjohnsson/events{/privacy}","received_events_url":"https://api.github.com/users/samjohnsson/received_events","type":"User","site_admin":false},"body":"Did you mean to change units to px here?","created_at":"2015-05-12T13:14:03Z","updated_at":"2015-05-12T13:14:03Z","html_url":"https://github.com/otwcode/otwarchive/pull/2107#discussion_r30131563","pull_request_url":"https://api.github.com/repos/otwcode/otwarchive/pulls/2107","_links":{"self":{"href":"https://api.github.com/repos/otwcode/otwarchive/pulls/comments/30131563"},"html":{"href":"https://github.com/otwcode/otwarchive/pull/2107#discussion_r30131563"},"pull_request":{"href":"https://api.github.com/repos/otwcode/otwarchive/pulls/2107"}}},"pull_request":{"url":"https://api.github.com/repos/otwcode/otwarchive/pulls/2107","id":35201509,"html_url":"https://github.com/otwcode/otwarchive/pull/2107","diff_url":"https://github.com/otwcode/otwarchive/pull/2107.diff","patch_url":"https://github.com/otwcode/otwarchive/pull/2107.patch","issue_url":"https://api.github.com/repos/otwcode/otwarchive/issues/2107","number":2107,"state":"open","locked":false,"title":"4300 Unsquish the layout","user":{"login":"sarken","id":907055,"avatar_url":"https://avatars.githubusercontent.com/u/907055?v=3","gravatar_id":"","url":"https://api.github.com/users/sarken","html_url":"https://github.com/sarken","followers_url":"https://api.github.com/users/sarken/followers","following_url":"https://api.github.com/users/sarken/following{/other_user}","gists_url":"https://api.github.com/users/sarken/gists{/gist_id}","starred_url":"https://api.github.com/users/sarken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarken/subscriptions","organizations_url":"https://api.github.com/users/sarken/orgs","repos_url":"https://api.github.com/users/sarken/repos","events_url":"https://api.github.com/users/sarken/events{/privacy}","received_events_url":"https://api.github.com/users/sarken/received_events","type":"User","site_admin":false},"body":"https://code.google.com/p/otwarchive/issues/detail?id=4300\r\n\r\nAfter running the included `After` task, it is also necessary to run `rake skins:load_site_skins`.\r\n\r\nThis creates a mid-size stylesheet that kicks in at 64em (1024px for most users) and puts the dashboard navigation at the top of the page. It also adjusts the narrow stylesheet so it kicks in at 44em (704px for most users) rather than 640px. In keeping with modern practices, the breakpoints are not based on any particular device dimensions, but rather on the points at which our layout starts looking funky. \r\n\r\nWe're using em rather than px because it plays nicer if the user has adjusted their browser's default font size to be larger or smaller than the standard 16px. For example, this is the layout in Google Chrome when the default font size is set to Very Large and the breakpoint is 1024px:\r\n\r\n![Very Large font in Chrome with a 1024px breakpoint](https://cloud.githubusercontent.com/assets/907055/7582367/c830d002-f85a-11e4-9fab-582db663e9f0.png)\r\n\r\nAnd here are the same settings with our breakpoint set to 64em:\r\n\r\n![Very Large font in Chrome with a 64em breakpoint](https://cloud.githubusercontent.com/assets/907055/7582376/e8bf83fe-f85a-11e4-9f1c-c08279e9c5e6.png)\r\n","created_at":"2015-05-12T07:59:25Z","updated_at":"2015-05-12T13:14:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e73c540f6fc7c1b459b681ec0a2b6b34e5dc87b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/otwcode/otwarchive/pulls/2107/commits","review_comments_url":"https://api.github.com/repos/otwcode/otwarchive/pulls/2107/comments","review_comment_url":"https://api.github.com/repos/otwcode/otwarchive/pulls/comments{/number}","comments_url":"https://api.github.com/repos/otwcode/otwarchive/issues/2107/comments","statuses_url":"https://api.github.com/repos/otwcode/otwarchive/statuses/bf8b87f1f6de0491bb4b3f3ffa7feced3a8a251f","head":{"label":"sarken:issue_4300","ref":"issue_4300","sha":"bf8b87f1f6de0491bb4b3f3ffa7feced3a8a251f","user":{"login":"sarken","id":907055,"avatar_url":"https://avatars.githubusercontent.com/u/907055?v=3","gravatar_id":"","url":"https://api.github.com/users/sarken","html_url":"https://github.com/sarken","followers_url":"https://api.github.com/users/sarken/followers","following_url":"https://api.github.com/users/sarken/following{/other_user}","gists_url":"https://api.github.com/users/sarken/gists{/gist_id}","starred_url":"https://api.github.com/users/sarken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarken/subscriptions","organizations_url":"https://api.github.com/users/sarken/orgs","repos_url":"https://api.github.com/users/sarken/repos","events_url":"https://api.github.com/users/sarken/events{/privacy}","received_events_url":"https://api.github.com/users/sarken/received_events","type":"User","site_admin":false},"repo":{"id":2028681,"name":"otwarchive","full_name":"sarken/otwarchive","owner":{"login":"sarken","id":907055,"avatar_url":"https://avatars.githubusercontent.com/u/907055?v=3","gravatar_id":"","url":"https://api.github.com/users/sarken","html_url":"https://github.com/sarken","followers_url":"https://api.github.com/users/sarken/followers","following_url":"https://api.github.com/users/sarken/following{/other_user}","gists_url":"https://api.github.com/users/sarken/gists{/gist_id}","starred_url":"https://api.github.com/users/sarken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarken/subscriptions","organizations_url":"https://api.github.com/users/sarken/orgs","repos_url":"https://api.github.com/users/sarken/repos","events_url":"https://api.github.com/users/sarken/events{/privacy}","received_events_url":"https://api.github.com/users/sarken/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sarken/otwarchive","description":"The Organization for Transformative Works - Archive Project","fork":true,"url":"https://api.github.com/repos/sarken/otwarchive","forks_url":"https://api.github.com/repos/sarken/otwarchive/forks","keys_url":"https://api.github.com/repos/sarken/otwarchive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sarken/otwarchive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sarken/otwarchive/teams","hooks_url":"https://api.github.com/repos/sarken/otwarchive/hooks","issue_events_url":"https://api.github.com/repos/sarken/otwarchive/issues/events{/number}","events_url":"https://api.github.com/repos/sarken/otwarchive/events","assignees_url":"https://api.github.com/repos/sarken/otwarchive/assignees{/user}","branches_url":"https://api.github.com/repos/sarken/otwarchive/branches{/branch}","tags_url":"https://api.github.com/repos/sarken/otwarchive/tags","blobs_url":"https://api.github.com/repos/sarken/otwarchive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sarken/otwarchive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sarken/otwarchive/git/refs{/sha}","trees_url":"https://api.github.com/repos/sarken/otwarchive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sarken/otwarchive/statuses/{sha}","languages_url":"https://api.github.com/repos/sarken/otwarchive/languages","stargazers_url":"https://api.github.com/repos/sarken/otwarchive/stargazers","contributors_url":"https://api.github.com/repos/sarken/otwarchive/contributors","subscribers_url":"https://api.github.com/repos/sarken/otwarchive/subscribers","subscription_url":"https://api.github.com/repos/sarken/otwarchive/subscription","commits_url":"https://api.github.com/repos/sarken/otwarchive/commits{/sha}","git_commits_url":"https://api.github.com/repos/sarken/otwarchive/git/commits{/sha}","comments_url":"https://api.github.com/repos/sarken/otwarchive/comments{/number}","issue_comment_url":"https://api.github.com/repos/sarken/otwarchive/issues/comments{/number}","contents_url":"https://api.github.com/repos/sarken/otwarchive/contents/{+path}","compare_url":"https://api.github.com/repos/sarken/otwarchive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sarken/otwarchive/merges","archive_url":"https://api.github.com/repos/sarken/otwarchive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sarken/otwarchive/downloads","issues_url":"https://api.github.com/repos/sarken/otwarchive/issues{/number}","pulls_url":"https://api.github.com/repos/sarken/otwarchive/pulls{/number}","milestones_url":"https://api.github.com/repos/sarken/otwarchive/milestones{/number}","notifications_url":"https://api.github.com/repos/sarken/otwarchive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sarken/otwarchive/labels{/name}","releases_url":"https://api.github.com/repos/sarken/otwarchive/releases{/id}","created_at":"2011-07-11T05:42:20Z","updated_at":"2015-05-07T22:58:35Z","pushed_at":"2015-05-12T08:05:50Z","git_url":"git://github.com/sarken/otwarchive.git","ssh_url":"git@github.com:sarken/otwarchive.git","clone_url":"https://github.com/sarken/otwarchive.git","svn_url":"https://github.com/sarken/otwarchive","homepage":"http://transformativeworks.org/projects/archive","size":52344,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"otwcode:master","ref":"master","sha":"b0c594272c0b63c7932c23f02f34c39b24ed9ade","user":{"login":"otwcode","id":408606,"avatar_url":"https://avatars.githubusercontent.com/u/408606?v=3","gravatar_id":"","url":"https://api.github.com/users/otwcode","html_url":"https://github.com/otwcode","followers_url":"https://api.github.com/users/otwcode/followers","following_url":"https://api.github.com/users/otwcode/following{/other_user}","gists_url":"https://api.github.com/users/otwcode/gists{/gist_id}","starred_url":"https://api.github.com/users/otwcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otwcode/subscriptions","organizations_url":"https://api.github.com/users/otwcode/orgs","repos_url":"https://api.github.com/users/otwcode/repos","events_url":"https://api.github.com/users/otwcode/events{/privacy}","received_events_url":"https://api.github.com/users/otwcode/received_events","type":"Organization","site_admin":false},"repo":{"id":1338040,"name":"otwarchive","full_name":"otwcode/otwarchive","owner":{"login":"otwcode","id":408606,"avatar_url":"https://avatars.githubusercontent.com/u/408606?v=3","gravatar_id":"","url":"https://api.github.com/users/otwcode","html_url":"https://github.com/otwcode","followers_url":"https://api.github.com/users/otwcode/followers","following_url":"https://api.github.com/users/otwcode/following{/other_user}","gists_url":"https://api.github.com/users/otwcode/gists{/gist_id}","starred_url":"https://api.github.com/users/otwcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otwcode/subscriptions","organizations_url":"https://api.github.com/users/otwcode/orgs","repos_url":"https://api.github.com/users/otwcode/repos","events_url":"https://api.github.com/users/otwcode/events{/privacy}","received_events_url":"https://api.github.com/users/otwcode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/otwcode/otwarchive","description":"The Organization for Transformative Works (OTW) - Archive Of Our Own (AO3) Project","fork":false,"url":"https://api.github.com/repos/otwcode/otwarchive","forks_url":"https://api.github.com/repos/otwcode/otwarchive/forks","keys_url":"https://api.github.com/repos/otwcode/otwarchive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/otwcode/otwarchive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/otwcode/otwarchive/teams","hooks_url":"https://api.github.com/repos/otwcode/otwarchive/hooks","issue_events_url":"https://api.github.com/repos/otwcode/otwarchive/issues/events{/number}","events_url":"https://api.github.com/repos/otwcode/otwarchive/events","assignees_url":"https://api.github.com/repos/otwcode/otwarchive/assignees{/user}","branches_url":"https://api.github.com/repos/otwcode/otwarchive/branches{/branch}","tags_url":"https://api.github.com/repos/otwcode/otwarchive/tags","blobs_url":"https://api.github.com/repos/otwcode/otwarchive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/otwcode/otwarchive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/otwcode/otwarchive/git/refs{/sha}","trees_url":"https://api.github.com/repos/otwcode/otwarchive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/otwcode/otwarchive/statuses/{sha}","languages_url":"https://api.github.com/repos/otwcode/otwarchive/languages","stargazers_url":"https://api.github.com/repos/otwcode/otwarchive/stargazers","contributors_url":"https://api.github.com/repos/otwcode/otwarchive/contributors","subscribers_url":"https://api.github.com/repos/otwcode/otwarchive/subscribers","subscription_url":"https://api.github.com/repos/otwcode/otwarchive/subscription","commits_url":"https://api.github.com/repos/otwcode/otwarchive/commits{/sha}","git_commits_url":"https://api.github.com/repos/otwcode/otwarchive/git/commits{/sha}","comments_url":"https://api.github.com/repos/otwcode/otwarchive/comments{/number}","issue_comment_url":"https://api.github.com/repos/otwcode/otwarchive/issues/comments{/number}","contents_url":"https://api.github.com/repos/otwcode/otwarchive/contents/{+path}","compare_url":"https://api.github.com/repos/otwcode/otwarchive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/otwcode/otwarchive/merges","archive_url":"https://api.github.com/repos/otwcode/otwarchive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/otwcode/otwarchive/downloads","issues_url":"https://api.github.com/repos/otwcode/otwarchive/issues{/number}","pulls_url":"https://api.github.com/repos/otwcode/otwarchive/pulls{/number}","milestones_url":"https://api.github.com/repos/otwcode/otwarchive/milestones{/number}","notifications_url":"https://api.github.com/repos/otwcode/otwarchive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/otwcode/otwarchive/labels{/name}","releases_url":"https://api.github.com/repos/otwcode/otwarchive/releases{/id}","created_at":"2011-02-07T14:50:58Z","updated_at":"2015-05-08T04:38:37Z","pushed_at":"2015-05-12T08:05:51Z","git_url":"git://github.com/otwcode/otwarchive.git","ssh_url":"git@github.com:otwcode/otwarchive.git","clone_url":"https://github.com/otwcode/otwarchive.git","svn_url":"https://github.com/otwcode/otwarchive","homepage":"http://transformativeworks.org/projects/archive","size":153690,"stargazers_count":141,"watchers_count":141,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":103,"mirror_url":null,"open_issues_count":29,"forks":103,"open_issues":29,"watchers":141,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/otwcode/otwarchive/pulls/2107"},"html":{"href":"https://github.com/otwcode/otwarchive/pull/2107"},"issue":{"href":"https://api.github.com/repos/otwcode/otwarchive/issues/2107"},"comments":{"href":"https://api.github.com/repos/otwcode/otwarchive/issues/2107/comments"},"review_comments":{"href":"https://api.github.com/repos/otwcode/otwarchive/pulls/2107/comments"},"review_comment":{"href":"https://api.github.com/repos/otwcode/otwarchive/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/otwcode/otwarchive/pulls/2107/commits"},"statuses":{"href":"https://api.github.com/repos/otwcode/otwarchive/statuses/bf8b87f1f6de0491bb4b3f3ffa7feced3a8a251f"}}}}