{"action":"created","comment":{"url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/comments/38863238","id":38863238,"diff_hunk":"@@ -1,11 +1,63 @@\n-<div><!-- TODO block to be shown only in cases where no map is selected -->\n+<div ng-show=\"!ctrl.mymap\">\n   <p translate>\n     Create, save and share your own maps.\n   </p>\n-  <p class=\"text-center\" ng-if=\"mainCtrl.loggedin\">\n-    <button class=\"btn btn-default\" translate>Open a map</button>\n+  <p class=\"text-center\"><!-- Show only when logged in -->\n+    <button class=\"btn btn-default\" ng-click=\"ctrl.choose()\" translate>Open a map</button>\n   </p>\n   <p class=\"text-center\">\n-    <button class=\"btn btn-default\" translate>Create new map</button>\n+    <button class=\"btn btn-default\" ng-click=\"ctrl.create()\" translate>Create new map</button>\n   </p>\n </div>\n+\n+<!-- Map displayed -->\n+<div ng-show=\"ctrl.mymap && ctrl.mymap.id\">\n+  <div class=\"panel-header\">\n+    <button type=\"button\" class=\"close\" aria-label=\"Close\" ng-click=\"ctrl.close()\"><span aria-hidden=\"true\">&times;</span></button>\n+  </div>\n+  <p class=\"title\" ng-click=\"ctrl.modify()\">{{ctrl.mymap.title}}</p>\n+  <p class=\"description\" ng-click=\"ctrl.modify()\" ng-if=\"ctrl.mymap.description\">{{ctrl.mymap.description}}</p>\n+  <p class=\"no-description\" ng-click=\"ctrl.modify()\" ng-if=\"!ctrl.mymap.description\" translate><em>No description</em></p>\n+</div>\n+\n+<!-- Modification Modal -->\n+<ngeo-modal ngeo-modal-shown=\"ctrl.modifying\">\n+  <div class=\"modal-header\">\n+    <button type=\"button\" class=\"close\" data-dismiss=\"modal\" aria-label=\"Close\"><span aria-hidden=\"true\">&times;</span></button>\n+    <h4 class=\"modal-title\" translate>Modify title and description of the map</h4>\n+  </div>\n+  <div class=\"modal-body\">\n+    <form>\n+    <div class=\"form-group\">\n+      <label for=\"mymapsTitle\" translate>Title of the map</label>\n+      <input type=\"text\" class=\"form-control\" id=\"mymapsTitle\" ng-model=\"ctrl.newTitle\">\n+    </div>\n+    <div class=\"form-group\">\n+      <label for=\"mymapsDescription\" translate>Description</label>\n+      <textarea class=\"form-control\" id=\"mymapsDescription\" rows=\"3\" ng-model=\"ctrl.newDescription\"></textarea>\n+    </div>\n+    </form>\n+  </div>\n+  <div class=\"modal-footer\">\n+    <button type=\"button\" class=\"btn btn-default\" data-dismiss=\"modal\" translate>Cancel</button>\n+    <button type=\"button\" class=\"btn btn-primary\" ng-click=\"ctrl.saveModifications()\" translate>Save changes</button>","path":"geoportailv3/static/js/mymaps/mymaps.html","position":47,"original_position":47,"commit_id":"e91a0038cb432095f85e09d0c7266e0153dd50cf","original_commit_id":"e91a0038cb432095f85e09d0c7266e0153dd50cf","user":{"login":"elemoine","id":76594,"avatar_url":"https://avatars.githubusercontent.com/u/76594?v=3","gravatar_id":"","url":"https://api.github.com/users/elemoine","html_url":"https://github.com/elemoine","followers_url":"https://api.github.com/users/elemoine/followers","following_url":"https://api.github.com/users/elemoine/following{/other_user}","gists_url":"https://api.github.com/users/elemoine/gists{/gist_id}","starred_url":"https://api.github.com/users/elemoine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elemoine/subscriptions","organizations_url":"https://api.github.com/users/elemoine/orgs","repos_url":"https://api.github.com/users/elemoine/repos","events_url":"https://api.github.com/users/elemoine/events{/privacy}","received_events_url":"https://api.github.com/users/elemoine/received_events","type":"User","site_admin":false},"body":"That's an explicit name ;) You could also use `saveChanges` to save a few characters and be more consistent with the translation key. Super minor.","created_at":"2015-09-07T13:48:16Z","updated_at":"2015-09-07T13:48:16Z","html_url":"https://github.com/Geoportail-Luxembourg/geoportailv3/pull/859#discussion_r38863238","pull_request_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/859","_links":{"self":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/comments/38863238"},"html":{"href":"https://github.com/Geoportail-Luxembourg/geoportailv3/pull/859#discussion_r38863238"},"pull_request":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/859"}}},"pull_request":{"url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/859","id":44212495,"html_url":"https://github.com/Geoportail-Luxembourg/geoportailv3/pull/859","diff_url":"https://github.com/Geoportail-Luxembourg/geoportailv3/pull/859.diff","patch_url":"https://github.com/Geoportail-Luxembourg/geoportailv3/pull/859.patch","issue_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/859","number":859,"state":"open","locked":false,"title":"Base UI code for managing mymaps creation and modification","user":{"login":"pgiraud","id":319774,"avatar_url":"https://avatars.githubusercontent.com/u/319774?v=3","gravatar_id":"","url":"https://api.github.com/users/pgiraud","html_url":"https://github.com/pgiraud","followers_url":"https://api.github.com/users/pgiraud/followers","following_url":"https://api.github.com/users/pgiraud/following{/other_user}","gists_url":"https://api.github.com/users/pgiraud/gists{/gist_id}","starred_url":"https://api.github.com/users/pgiraud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgiraud/subscriptions","organizations_url":"https://api.github.com/users/pgiraud/orgs","repos_url":"https://api.github.com/users/pgiraud/repos","events_url":"https://api.github.com/users/pgiraud/events{/privacy}","received_events_url":"https://api.github.com/users/pgiraud/received_events","type":"User","site_admin":false},"body":"With this pull request we get the base code to manage maps.\r\nIt includes the base code to show the \"open a map\" as well as the \"modify\" modal windows.\r\nThis of course simulates a lot of things for now. For example, it considers that the user is authenticated.\r\n\r\nOnce this pull request is merged, I'll work on the styling a bit more.","created_at":"2015-09-04T12:30:18Z","updated_at":"2015-09-07T13:48:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab37af26e75083fdf44e9882dd4759079bf508b2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/859/commits","review_comments_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/859/comments","review_comment_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/859/comments","statuses_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/statuses/e91a0038cb432095f85e09d0c7266e0153dd50cf","head":{"label":"Geoportail-Luxembourg:pgiraud_mymaps_modify","ref":"pgiraud_mymaps_modify","sha":"e91a0038cb432095f85e09d0c7266e0153dd50cf","user":{"login":"Geoportail-Luxembourg","id":5592884,"avatar_url":"https://avatars.githubusercontent.com/u/5592884?v=3","gravatar_id":"","url":"https://api.github.com/users/Geoportail-Luxembourg","html_url":"https://github.com/Geoportail-Luxembourg","followers_url":"https://api.github.com/users/Geoportail-Luxembourg/followers","following_url":"https://api.github.com/users/Geoportail-Luxembourg/following{/other_user}","gists_url":"https://api.github.com/users/Geoportail-Luxembourg/gists{/gist_id}","starred_url":"https://api.github.com/users/Geoportail-Luxembourg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geoportail-Luxembourg/subscriptions","organizations_url":"https://api.github.com/users/Geoportail-Luxembourg/orgs","repos_url":"https://api.github.com/users/Geoportail-Luxembourg/repos","events_url":"https://api.github.com/users/Geoportail-Luxembourg/events{/privacy}","received_events_url":"https://api.github.com/users/Geoportail-Luxembourg/received_events","type":"Organization","site_admin":false},"repo":{"id":24669372,"name":"geoportailv3","full_name":"Geoportail-Luxembourg/geoportailv3","owner":{"login":"Geoportail-Luxembourg","id":5592884,"avatar_url":"https://avatars.githubusercontent.com/u/5592884?v=3","gravatar_id":"","url":"https://api.github.com/users/Geoportail-Luxembourg","html_url":"https://github.com/Geoportail-Luxembourg","followers_url":"https://api.github.com/users/Geoportail-Luxembourg/followers","following_url":"https://api.github.com/users/Geoportail-Luxembourg/following{/other_user}","gists_url":"https://api.github.com/users/Geoportail-Luxembourg/gists{/gist_id}","starred_url":"https://api.github.com/users/Geoportail-Luxembourg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geoportail-Luxembourg/subscriptions","organizations_url":"https://api.github.com/users/Geoportail-Luxembourg/orgs","repos_url":"https://api.github.com/users/Geoportail-Luxembourg/repos","events_url":"https://api.github.com/users/Geoportail-Luxembourg/events{/privacy}","received_events_url":"https://api.github.com/users/Geoportail-Luxembourg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Geoportail-Luxembourg/geoportailv3","description":"geoportailv3 is the implementation of the v3 of the map viewer of the luxembourgish geoportal","fork":false,"url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3","forks_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/forks","keys_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/teams","hooks_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/hooks","issue_events_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/events{/number}","events_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/events","assignees_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/assignees{/user}","branches_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/branches{/branch}","tags_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/tags","blobs_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/refs{/sha}","trees_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/statuses/{sha}","languages_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/languages","stargazers_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/stargazers","contributors_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/contributors","subscribers_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/subscribers","subscription_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/subscription","commits_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/commits{/sha}","git_commits_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/commits{/sha}","comments_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/comments{/number}","issue_comment_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/comments{/number}","contents_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/contents/{+path}","compare_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/merges","archive_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/downloads","issues_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues{/number}","pulls_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls{/number}","milestones_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/milestones{/number}","notifications_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/labels{/name}","releases_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/releases{/id}","created_at":"2014-10-01T07:23:27Z","updated_at":"2015-08-11T14:30:31Z","pushed_at":"2015-09-07T13:09:12Z","git_url":"git://github.com/Geoportail-Luxembourg/geoportailv3.git","ssh_url":"git@github.com:Geoportail-Luxembourg/geoportailv3.git","clone_url":"https://github.com/Geoportail-Luxembourg/geoportailv3.git","svn_url":"https://github.com/Geoportail-Luxembourg/geoportailv3","homepage":"","size":114126,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":88,"forks":1,"open_issues":88,"watchers":5,"default_branch":"master"}},"base":{"label":"Geoportail-Luxembourg:master","ref":"master","sha":"5f76c08b24314bdeb14e2c4b646e43806fa01f51","user":{"login":"Geoportail-Luxembourg","id":5592884,"avatar_url":"https://avatars.githubusercontent.com/u/5592884?v=3","gravatar_id":"","url":"https://api.github.com/users/Geoportail-Luxembourg","html_url":"https://github.com/Geoportail-Luxembourg","followers_url":"https://api.github.com/users/Geoportail-Luxembourg/followers","following_url":"https://api.github.com/users/Geoportail-Luxembourg/following{/other_user}","gists_url":"https://api.github.com/users/Geoportail-Luxembourg/gists{/gist_id}","starred_url":"https://api.github.com/users/Geoportail-Luxembourg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geoportail-Luxembourg/subscriptions","organizations_url":"https://api.github.com/users/Geoportail-Luxembourg/orgs","repos_url":"https://api.github.com/users/Geoportail-Luxembourg/repos","events_url":"https://api.github.com/users/Geoportail-Luxembourg/events{/privacy}","received_events_url":"https://api.github.com/users/Geoportail-Luxembourg/received_events","type":"Organization","site_admin":false},"repo":{"id":24669372,"name":"geoportailv3","full_name":"Geoportail-Luxembourg/geoportailv3","owner":{"login":"Geoportail-Luxembourg","id":5592884,"avatar_url":"https://avatars.githubusercontent.com/u/5592884?v=3","gravatar_id":"","url":"https://api.github.com/users/Geoportail-Luxembourg","html_url":"https://github.com/Geoportail-Luxembourg","followers_url":"https://api.github.com/users/Geoportail-Luxembourg/followers","following_url":"https://api.github.com/users/Geoportail-Luxembourg/following{/other_user}","gists_url":"https://api.github.com/users/Geoportail-Luxembourg/gists{/gist_id}","starred_url":"https://api.github.com/users/Geoportail-Luxembourg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geoportail-Luxembourg/subscriptions","organizations_url":"https://api.github.com/users/Geoportail-Luxembourg/orgs","repos_url":"https://api.github.com/users/Geoportail-Luxembourg/repos","events_url":"https://api.github.com/users/Geoportail-Luxembourg/events{/privacy}","received_events_url":"https://api.github.com/users/Geoportail-Luxembourg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Geoportail-Luxembourg/geoportailv3","description":"geoportailv3 is the implementation of the v3 of the map viewer of the luxembourgish geoportal","fork":false,"url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3","forks_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/forks","keys_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/teams","hooks_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/hooks","issue_events_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/events{/number}","events_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/events","assignees_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/assignees{/user}","branches_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/branches{/branch}","tags_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/tags","blobs_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/refs{/sha}","trees_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/statuses/{sha}","languages_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/languages","stargazers_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/stargazers","contributors_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/contributors","subscribers_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/subscribers","subscription_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/subscription","commits_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/commits{/sha}","git_commits_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/commits{/sha}","comments_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/comments{/number}","issue_comment_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/comments{/number}","contents_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/contents/{+path}","compare_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/merges","archive_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/downloads","issues_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues{/number}","pulls_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls{/number}","milestones_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/milestones{/number}","notifications_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/labels{/name}","releases_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/releases{/id}","created_at":"2014-10-01T07:23:27Z","updated_at":"2015-08-11T14:30:31Z","pushed_at":"2015-09-07T13:09:12Z","git_url":"git://github.com/Geoportail-Luxembourg/geoportailv3.git","ssh_url":"git@github.com:Geoportail-Luxembourg/geoportailv3.git","clone_url":"https://github.com/Geoportail-Luxembourg/geoportailv3.git","svn_url":"https://github.com/Geoportail-Luxembourg/geoportailv3","homepage":"","size":114126,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":88,"forks":1,"open_issues":88,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/859"},"html":{"href":"https://github.com/Geoportail-Luxembourg/geoportailv3/pull/859"},"issue":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/859"},"comments":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/859/comments"},"review_comments":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/859/comments"},"review_comment":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/859/commits"},"statuses":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/statuses/e91a0038cb432095f85e09d0c7266e0153dd50cf"}}}}