{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoinj/bitcoinj/issues/1115","labels_url":"https://api.github.com/repos/bitcoinj/bitcoinj/issues/1115/labels{/name}","comments_url":"https://api.github.com/repos/bitcoinj/bitcoinj/issues/1115/comments","events_url":"https://api.github.com/repos/bitcoinj/bitcoinj/issues/1115/events","html_url":"https://github.com/bitcoinj/bitcoinj/pull/1115","id":117215443,"number":1115,"title":"Fixed behaviour of OP_0 to not NullPointerException","user":{"login":"w-shackleton","id":2139216,"avatar_url":"https://avatars.githubusercontent.com/u/2139216?v=3","gravatar_id":"","url":"https://api.github.com/users/w-shackleton","html_url":"https://github.com/w-shackleton","followers_url":"https://api.github.com/users/w-shackleton/followers","following_url":"https://api.github.com/users/w-shackleton/following{/other_user}","gists_url":"https://api.github.com/users/w-shackleton/gists{/gist_id}","starred_url":"https://api.github.com/users/w-shackleton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w-shackleton/subscriptions","organizations_url":"https://api.github.com/users/w-shackleton/orgs","repos_url":"https://api.github.com/users/w-shackleton/repos","events_url":"https://api.github.com/users/w-shackleton/events{/privacy}","received_events_url":"https://api.github.com/users/w-shackleton/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-11-16T20:54:21Z","updated_at":"2015-11-28T12:45:02Z","closed_at":"2015-11-28T11:14:25Z","pull_request":{"url":"https://api.github.com/repos/bitcoinj/bitcoinj/pulls/1115","html_url":"https://github.com/bitcoinj/bitcoinj/pull/1115","diff_url":"https://github.com/bitcoinj/bitcoinj/pull/1115.diff","patch_url":"https://github.com/bitcoinj/bitcoinj/pull/1115.patch"},"body":"`OP_0` was throwing a `NullPointerException` when chunk.data was attempted to access inside the if statement below. Since the behaviour of `OP_0` is to push an empty array to the stack I modified the behaviour as so."},"comment":{"url":"https://api.github.com/repos/bitcoinj/bitcoinj/issues/comments/160291678","html_url":"https://github.com/bitcoinj/bitcoinj/pull/1115#issuecomment-160291678","issue_url":"https://api.github.com/repos/bitcoinj/bitcoinj/issues/1115","id":160291678,"user":{"login":"dexX7","id":5836089,"avatar_url":"https://avatars.githubusercontent.com/u/5836089?v=3","gravatar_id":"","url":"https://api.github.com/users/dexX7","html_url":"https://github.com/dexX7","followers_url":"https://api.github.com/users/dexX7/followers","following_url":"https://api.github.com/users/dexX7/following{/other_user}","gists_url":"https://api.github.com/users/dexX7/gists{/gist_id}","starred_url":"https://api.github.com/users/dexX7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dexX7/subscriptions","organizations_url":"https://api.github.com/users/dexX7/orgs","repos_url":"https://api.github.com/users/dexX7/repos","events_url":"https://api.github.com/users/dexX7/events{/privacy}","received_events_url":"https://api.github.com/users/dexX7/received_events","type":"User","site_admin":false},"created_at":"2015-11-28T12:45:02Z","updated_at":"2015-11-28T12:45:02Z","body":"@schildbach: yeah, this was just a mention, so no one gets the idea `null` may be the correct representation.\r\n\r\n> If you know of occurences which use the wrong representation can you submit a PR to fix it, or open an issue?\r\n\r\nBack then I tested BitcoinJ with the script unit tests of Bitcoin Core, and the failing tests I've found were all related to missing script flags, such as `DISCOURAGE_UPGRADABLE_NOPS` or `MINIMALDATA`.\r\n\r\nHere is an older test report, which may provide an insight:\r\n\r\n- http://bitwatch.co/uploads/reports/java-libbitcoinconsensus/149aa39248-bitcoinj/classes/co.bitwatch.libbitcoinconsensus.DataDrivenBitcoinJSpec.html\r\n\r\nThe report was generated before #1089 was merged, if I recall correctly. \r\n\r\nBut other than that, I'm currently not aware of other wrong representations or issues. :)"}}