{"action":"created","issue":{"url":"https://api.github.com/repos/emberjs/ember.js/issues/11357","labels_url":"https://api.github.com/repos/emberjs/ember.js/issues/11357/labels{/name}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/11357/comments","events_url":"https://api.github.com/repos/emberjs/ember.js/issues/11357/events","html_url":"https://github.com/emberjs/ember.js/pull/11357","id":85595930,"number":11357,"title":"[DOC release] modelFor will never return a promise","user":{"login":"nruth","id":26158,"avatar_url":"https://avatars.githubusercontent.com/u/26158?v=3","gravatar_id":"","url":"https://api.github.com/users/nruth","html_url":"https://github.com/nruth","followers_url":"https://api.github.com/users/nruth/followers","following_url":"https://api.github.com/users/nruth/following{/other_user}","gists_url":"https://api.github.com/users/nruth/gists{/gist_id}","starred_url":"https://api.github.com/users/nruth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nruth/subscriptions","organizations_url":"https://api.github.com/users/nruth/orgs","repos_url":"https://api.github.com/users/nruth/repos","events_url":"https://api.github.com/users/nruth/events{/privacy}","received_events_url":"https://api.github.com/users/nruth/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/emberjs/ember.js/labels/Needs%20Submitter%20Response","name":"Needs Submitter Response","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-06-05T18:11:25Z","updated_at":"2015-08-09T13:39:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/11357","html_url":"https://github.com/emberjs/ember.js/pull/11357","diff_url":"https://github.com/emberjs/ember.js/pull/11357.diff","patch_url":"https://github.com/emberjs/ember.js/pull/11357.patch"},"body":"I was confused by how parent/child routes work with promises and modelFor. I'd find it useful to have it written in the modelFor docs whether it might return a promise.\r\n\r\nAccording to http://guides.emberjs.com/v1.11.0/routing/asynchronous-routing/ :\r\n\r\n> If the promise fulfills, the transition will pick up where it left off and begin resolving the next (child) route's model, pausing if it too is a promise, and so on, until all destination route models have been resolved.\r\n\r\nI'm assuming this covers modelFor, since the parent's model (promise) will be fully loaded before the child route where modelFor can be used.\r\n\r\nCorrections welcome."},"comment":{"url":"https://api.github.com/repos/emberjs/ember.js/issues/comments/129188636","html_url":"https://github.com/emberjs/ember.js/pull/11357#issuecomment-129188636","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/11357","id":129188636,"user":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars.githubusercontent.com/u/12637?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"created_at":"2015-08-09T13:39:21Z","updated_at":"2015-08-09T13:39:21Z","body":"@nruth - Ping?"}}