{"action":"closed","issue":{"url":"https://api.github.com/repos/stevenwanderski/bxslider-4/issues/283","labels_url":"https://api.github.com/repos/stevenwanderski/bxslider-4/issues/283/labels{/name}","comments_url":"https://api.github.com/repos/stevenwanderski/bxslider-4/issues/283/comments","events_url":"https://api.github.com/repos/stevenwanderski/bxslider-4/issues/283/events","html_url":"https://github.com/stevenwanderski/bxslider-4/issues/283","id":17265053,"number":283,"title":"Idomatic javascript and less comments more tests","user":{"login":"andredublin","id":464761,"avatar_url":"https://avatars.githubusercontent.com/u/464761?v=3","gravatar_id":"","url":"https://api.github.com/users/andredublin","html_url":"https://github.com/andredublin","followers_url":"https://api.github.com/users/andredublin/followers","following_url":"https://api.github.com/users/andredublin/following{/other_user}","gists_url":"https://api.github.com/users/andredublin/gists{/gist_id}","starred_url":"https://api.github.com/users/andredublin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andredublin/subscriptions","organizations_url":"https://api.github.com/users/andredublin/orgs","repos_url":"https://api.github.com/users/andredublin/repos","events_url":"https://api.github.com/users/andredublin/events{/privacy}","received_events_url":"https://api.github.com/users/andredublin/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/stevenwanderski/bxslider-4/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"closed","locked":false,"assignee":{"login":"Tidal-Wave","id":4382867,"avatar_url":"https://avatars.githubusercontent.com/u/4382867?v=3","gravatar_id":"","url":"https://api.github.com/users/Tidal-Wave","html_url":"https://github.com/Tidal-Wave","followers_url":"https://api.github.com/users/Tidal-Wave/followers","following_url":"https://api.github.com/users/Tidal-Wave/following{/other_user}","gists_url":"https://api.github.com/users/Tidal-Wave/gists{/gist_id}","starred_url":"https://api.github.com/users/Tidal-Wave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tidal-Wave/subscriptions","organizations_url":"https://api.github.com/users/Tidal-Wave/orgs","repos_url":"https://api.github.com/users/Tidal-Wave/repos","events_url":"https://api.github.com/users/Tidal-Wave/events{/privacy}","received_events_url":"https://api.github.com/users/Tidal-Wave/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2013-07-26T14:09:33Z","updated_at":"2015-01-19T18:33:19Z","closed_at":"2015-01-19T18:33:19Z","body":"It would be great to clean up the code so its easier on the eyes.\r\nI'd rather see\r\n```javascript\r\nif (slider.settings.slideMargin > 0) {\r\n  height += slider.settings.slideMargin * (slider.settings.minSlides - 1);\r\n}\r\n```\r\n\r\ninstead of \r\n\r\n```javascript\r\nif(slider.settings.slideMargin > 0) height += slider.settings.slideMargin * (slider.settings.minSlides - 1);\r\n```\r\n\r\n[idomatic js](https://github.com/rwldrn/idiomatic.js)\r\n\r\nAnd there are way too many comments used as documentation, tests should reveal the intention of the code."}}