{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/comments/23835425","id":23835425,"diff_hunk":"@@ -65,18 +65,26 @@\n end\n \n networking_plugin = node[:neutron][:networking_plugin]\n+\n case networking_plugin\n-when \"openvswitch\", \"cisco\"\n-  neutron_agent = node[:neutron][:platform][:ovs_agent_name]\n-when \"linuxbridge\"\n-  neutron_agent = node[:neutron][:platform][:lb_agent_name]\n+when 'ml2'\n+  ml2_mech_drivers = node[:neutron][:ml2_mechanism_drivers]\n+  case\n+  when ml2_mech_drivers.include?(\"openvswitch\")\n+    neutron_agent = node[:neutron][:platform][:ovs_agent_name]\n+    neutron_agent_ra = node[:neutron][:ha][:l3][\"openvswitch_ra\"]\n+  when ml2_mech_drivers.include?(\"linuxbridge\")\n+    neutron_agent = node[:neutron][:platform][:lb_agent_name]\n+    neutron_agent_ra = node[:neutron][:ha][:l3][\"linuxbridge_ra\"]\n+  end\n when \"vmware\"\n   neutron_agent = ''\n+  neutron_agent_ra = node[:neutron][:ha][:l3][\"vmware_ra\"]","path":"chef/cookbooks/neutron/recipes/l3_ha.rb","position":22,"original_position":22,"commit_id":"d66c1bfa9a37c7a7666ca0addece5663081f5abe","original_commit_id":"d66c1bfa9a37c7a7666ca0addece5663081f5abe","user":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"body":"This should be an empty string, as there's no l3 service with vmware (and this attribute doesn't exist)","created_at":"2015-01-30T10:55:45Z","updated_at":"2015-01-30T10:55:45Z","html_url":"https://github.com/crowbar/barclamp-neutron/pull/175#discussion_r23835425","pull_request_url":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/175","_links":{"self":{"href":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/comments/23835425"},"html":{"href":"https://github.com/crowbar/barclamp-neutron/pull/175#discussion_r23835425"},"pull_request":{"href":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/175"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/175","id":27745861,"html_url":"https://github.com/crowbar/barclamp-neutron/pull/175","diff_url":"https://github.com/crowbar/barclamp-neutron/pull/175.diff","patch_url":"https://github.com/crowbar/barclamp-neutron/pull/175.patch","issue_url":"https://api.github.com/repos/crowbar/barclamp-neutron/issues/175","number":175,"state":"open","locked":false,"title":"Allow multiple ml2 type drivers at the same time","user":{"login":"toabctl","id":276317,"avatar_url":"https://avatars.githubusercontent.com/u/276317?v=3","gravatar_id":"","url":"https://api.github.com/users/toabctl","html_url":"https://github.com/toabctl","followers_url":"https://api.github.com/users/toabctl/followers","following_url":"https://api.github.com/users/toabctl/following{/other_user}","gists_url":"https://api.github.com/users/toabctl/gists{/gist_id}","starred_url":"https://api.github.com/users/toabctl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toabctl/subscriptions","organizations_url":"https://api.github.com/users/toabctl/orgs","repos_url":"https://api.github.com/users/toabctl/repos","events_url":"https://api.github.com/users/toabctl/events{/privacy}","received_events_url":"https://api.github.com/users/toabctl/received_events","type":"User","site_admin":false},"body":"Restructure the UI to reflect the current situation where users can\r\nchoose between ml2 or vmware as core plugin. Selecting ml2 has then\r\nml2_type_drivers and ml2_mechanism_drivers to configure. For both are\r\nmultiple values allowed.","created_at":"2015-01-21T09:37:35Z","updated_at":"2015-01-30T10:55:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5a869d6fad7c51bd0a6551fbaaa32b2d82df614","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/175/commits","review_comments_url":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/175/comments","review_comment_url":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/comments/{number}","comments_url":"https://api.github.com/repos/crowbar/barclamp-neutron/issues/175/comments","statuses_url":"https://api.github.com/repos/crowbar/barclamp-neutron/statuses/d66c1bfa9a37c7a7666ca0addece5663081f5abe","head":{"label":"toabctl:fate-317823-allow-using-multiple-ml2-type-drivers","ref":"fate-317823-allow-using-multiple-ml2-type-drivers","sha":"d66c1bfa9a37c7a7666ca0addece5663081f5abe","user":{"login":"toabctl","id":276317,"avatar_url":"https://avatars.githubusercontent.com/u/276317?v=3","gravatar_id":"","url":"https://api.github.com/users/toabctl","html_url":"https://github.com/toabctl","followers_url":"https://api.github.com/users/toabctl/followers","following_url":"https://api.github.com/users/toabctl/following{/other_user}","gists_url":"https://api.github.com/users/toabctl/gists{/gist_id}","starred_url":"https://api.github.com/users/toabctl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toabctl/subscriptions","organizations_url":"https://api.github.com/users/toabctl/orgs","repos_url":"https://api.github.com/users/toabctl/repos","events_url":"https://api.github.com/users/toabctl/events{/privacy}","received_events_url":"https://api.github.com/users/toabctl/received_events","type":"User","site_admin":false},"repo":{"id":24886360,"name":"barclamp-neutron","full_name":"toabctl/barclamp-neutron","owner":{"login":"toabctl","id":276317,"avatar_url":"https://avatars.githubusercontent.com/u/276317?v=3","gravatar_id":"","url":"https://api.github.com/users/toabctl","html_url":"https://github.com/toabctl","followers_url":"https://api.github.com/users/toabctl/followers","following_url":"https://api.github.com/users/toabctl/following{/other_user}","gists_url":"https://api.github.com/users/toabctl/gists{/gist_id}","starred_url":"https://api.github.com/users/toabctl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toabctl/subscriptions","organizations_url":"https://api.github.com/users/toabctl/orgs","repos_url":"https://api.github.com/users/toabctl/repos","events_url":"https://api.github.com/users/toabctl/events{/privacy}","received_events_url":"https://api.github.com/users/toabctl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/toabctl/barclamp-neutron","description":"OpenStack Neutron: Networking component","fork":true,"url":"https://api.github.com/repos/toabctl/barclamp-neutron","forks_url":"https://api.github.com/repos/toabctl/barclamp-neutron/forks","keys_url":"https://api.github.com/repos/toabctl/barclamp-neutron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toabctl/barclamp-neutron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toabctl/barclamp-neutron/teams","hooks_url":"https://api.github.com/repos/toabctl/barclamp-neutron/hooks","issue_events_url":"https://api.github.com/repos/toabctl/barclamp-neutron/issues/events{/number}","events_url":"https://api.github.com/repos/toabctl/barclamp-neutron/events","assignees_url":"https://api.github.com/repos/toabctl/barclamp-neutron/assignees{/user}","branches_url":"https://api.github.com/repos/toabctl/barclamp-neutron/branches{/branch}","tags_url":"https://api.github.com/repos/toabctl/barclamp-neutron/tags","blobs_url":"https://api.github.com/repos/toabctl/barclamp-neutron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toabctl/barclamp-neutron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toabctl/barclamp-neutron/git/refs{/sha}","trees_url":"https://api.github.com/repos/toabctl/barclamp-neutron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toabctl/barclamp-neutron/statuses/{sha}","languages_url":"https://api.github.com/repos/toabctl/barclamp-neutron/languages","stargazers_url":"https://api.github.com/repos/toabctl/barclamp-neutron/stargazers","contributors_url":"https://api.github.com/repos/toabctl/barclamp-neutron/contributors","subscribers_url":"https://api.github.com/repos/toabctl/barclamp-neutron/subscribers","subscription_url":"https://api.github.com/repos/toabctl/barclamp-neutron/subscription","commits_url":"https://api.github.com/repos/toabctl/barclamp-neutron/commits{/sha}","git_commits_url":"https://api.github.com/repos/toabctl/barclamp-neutron/git/commits{/sha}","comments_url":"https://api.github.com/repos/toabctl/barclamp-neutron/comments{/number}","issue_comment_url":"https://api.github.com/repos/toabctl/barclamp-neutron/issues/comments/{number}","contents_url":"https://api.github.com/repos/toabctl/barclamp-neutron/contents/{+path}","compare_url":"https://api.github.com/repos/toabctl/barclamp-neutron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toabctl/barclamp-neutron/merges","archive_url":"https://api.github.com/repos/toabctl/barclamp-neutron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toabctl/barclamp-neutron/downloads","issues_url":"https://api.github.com/repos/toabctl/barclamp-neutron/issues{/number}","pulls_url":"https://api.github.com/repos/toabctl/barclamp-neutron/pulls{/number}","milestones_url":"https://api.github.com/repos/toabctl/barclamp-neutron/milestones{/number}","notifications_url":"https://api.github.com/repos/toabctl/barclamp-neutron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toabctl/barclamp-neutron/labels{/name}","releases_url":"https://api.github.com/repos/toabctl/barclamp-neutron/releases{/id}","created_at":"2014-10-07T10:43:26Z","updated_at":"2014-09-03T08:15:31Z","pushed_at":"2015-01-30T10:34:33Z","git_url":"git://github.com/toabctl/barclamp-neutron.git","ssh_url":"git@github.com:toabctl/barclamp-neutron.git","clone_url":"https://github.com/toabctl/barclamp-neutron.git","svn_url":"https://github.com/toabctl/barclamp-neutron","homepage":"https://github.com/crowbar/crowbar","size":1190,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"068fdded9d6f1d54f25145fd6d5fbb9014618993","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":13688641,"name":"barclamp-neutron","full_name":"crowbar/barclamp-neutron","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/barclamp-neutron","description":"OpenStack Neutron: Networking component","fork":false,"url":"https://api.github.com/repos/crowbar/barclamp-neutron","forks_url":"https://api.github.com/repos/crowbar/barclamp-neutron/forks","keys_url":"https://api.github.com/repos/crowbar/barclamp-neutron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/barclamp-neutron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/barclamp-neutron/teams","hooks_url":"https://api.github.com/repos/crowbar/barclamp-neutron/hooks","issue_events_url":"https://api.github.com/repos/crowbar/barclamp-neutron/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/barclamp-neutron/events","assignees_url":"https://api.github.com/repos/crowbar/barclamp-neutron/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/barclamp-neutron/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/barclamp-neutron/tags","blobs_url":"https://api.github.com/repos/crowbar/barclamp-neutron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/barclamp-neutron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/barclamp-neutron/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/barclamp-neutron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/barclamp-neutron/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/barclamp-neutron/languages","stargazers_url":"https://api.github.com/repos/crowbar/barclamp-neutron/stargazers","contributors_url":"https://api.github.com/repos/crowbar/barclamp-neutron/contributors","subscribers_url":"https://api.github.com/repos/crowbar/barclamp-neutron/subscribers","subscription_url":"https://api.github.com/repos/crowbar/barclamp-neutron/subscription","commits_url":"https://api.github.com/repos/crowbar/barclamp-neutron/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/barclamp-neutron/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/barclamp-neutron/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/barclamp-neutron/issues/comments/{number}","contents_url":"https://api.github.com/repos/crowbar/barclamp-neutron/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/barclamp-neutron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/barclamp-neutron/merges","archive_url":"https://api.github.com/repos/crowbar/barclamp-neutron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/barclamp-neutron/downloads","issues_url":"https://api.github.com/repos/crowbar/barclamp-neutron/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/barclamp-neutron/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/barclamp-neutron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/barclamp-neutron/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/barclamp-neutron/releases{/id}","created_at":"2013-10-18T20:39:52Z","updated_at":"2015-01-29T17:18:34Z","pushed_at":"2015-01-29T17:18:33Z","git_url":"git://github.com/crowbar/barclamp-neutron.git","ssh_url":"git@github.com:crowbar/barclamp-neutron.git","clone_url":"https://github.com/crowbar/barclamp-neutron.git","svn_url":"https://github.com/crowbar/barclamp-neutron","homepage":"https://github.com/crowbar/crowbar","size":2681,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":68,"mirror_url":null,"open_issues_count":8,"forks":68,"open_issues":8,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/175"},"html":{"href":"https://github.com/crowbar/barclamp-neutron/pull/175"},"issue":{"href":"https://api.github.com/repos/crowbar/barclamp-neutron/issues/175"},"comments":{"href":"https://api.github.com/repos/crowbar/barclamp-neutron/issues/175/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/175/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/crowbar/barclamp-neutron/pulls/175/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/barclamp-neutron/statuses/d66c1bfa9a37c7a7666ca0addece5663081f5abe"}}}}