{"action":"created","comment":{"url":"https://api.github.com/repos/sulu-io/sulu/pulls/comments/35629346","id":35629346,"diff_hunk":"@@ -2,6 +2,23 @@\n \n ## Dev-develop\n \n+### Header-toolbar and tabs\n+The header got a complete redesign, the breadcrumb, title and bottom-content are not available anymore. Also the event header.set-toolbar got removed. A sulu-header can still be initialized via the header property when a view-component gets started.\n+\n+#### Tabs\n+The tabs can be configured with the 'url', 'data' and 'container' option. The 'option' fullControll' got removed. You can get the same effect by passing data with no 'component'-property.\n+\n+#### Toolbar\n+The language-changer can be configured as it was. Template and parentTemplate in contrast are not supported anymore. Instead you pass an array of sulu-buttons.\n+Moreover the format of the buttons itself changed: https://github.com/massiveart/husky/blob/f9b3abeb547553c9c031710f1f98d0288b08ca9c/UPGRADE.md\n+\n+#### Sulu-buttons\n+Buttons for toolbars get specified in an aura-extension (sandbox.sulu.buttons and sandbox.sulu.buttons.dropdownItems). Therfore each bundle can add their own buttons to the pool. The toolbar in the header fetches its buttons from this pool.\n+\n+#### List-toolbar\n+The inHeader option got removed and is not supported anymore. Sulu.buttons are used internally and can be passed via the template which is recommended instead of using string templates.","path":"UPGRADE.md","position":null,"original_position":18,"commit_id":"cf78386062d7a8247e7d43a49d069ffb9fff4482","original_commit_id":"542a0f56ef2db72b5f4b69cd1943eb99a8ce47b4","user":{"login":"marcelmoosbrugger","id":1998663,"avatar_url":"https://avatars.githubusercontent.com/u/1998663?v=3","gravatar_id":"","url":"https://api.github.com/users/marcelmoosbrugger","html_url":"https://github.com/marcelmoosbrugger","followers_url":"https://api.github.com/users/marcelmoosbrugger/followers","following_url":"https://api.github.com/users/marcelmoosbrugger/following{/other_user}","gists_url":"https://api.github.com/users/marcelmoosbrugger/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelmoosbrugger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelmoosbrugger/subscriptions","organizations_url":"https://api.github.com/users/marcelmoosbrugger/orgs","repos_url":"https://api.github.com/users/marcelmoosbrugger/repos","events_url":"https://api.github.com/users/marcelmoosbrugger/events{/privacy}","received_events_url":"https://api.github.com/users/marcelmoosbrugger/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2015-07-28T09:27:47Z","updated_at":"2015-07-28T09:27:47Z","html_url":"https://github.com/sulu-io/sulu/pull/1417#discussion_r35629346","pull_request_url":"https://api.github.com/repos/sulu-io/sulu/pulls/1417","_links":{"self":{"href":"https://api.github.com/repos/sulu-io/sulu/pulls/comments/35629346"},"html":{"href":"https://github.com/sulu-io/sulu/pull/1417#discussion_r35629346"},"pull_request":{"href":"https://api.github.com/repos/sulu-io/sulu/pulls/1417"}}},"pull_request":{"url":"https://api.github.com/repos/sulu-io/sulu/pulls/1417","id":40745442,"html_url":"https://github.com/sulu-io/sulu/pull/1417","diff_url":"https://github.com/sulu-io/sulu/pull/1417.diff","patch_url":"https://github.com/sulu-io/sulu/pull/1417.patch","issue_url":"https://api.github.com/repos/sulu-io/sulu/issues/1417","number":1417,"state":"open","locked":false,"title":"implemented new header design","user":{"login":"marcelmoosbrugger","id":1998663,"avatar_url":"https://avatars.githubusercontent.com/u/1998663?v=3","gravatar_id":"","url":"https://api.github.com/users/marcelmoosbrugger","html_url":"https://github.com/marcelmoosbrugger","followers_url":"https://api.github.com/users/marcelmoosbrugger/followers","following_url":"https://api.github.com/users/marcelmoosbrugger/following{/other_user}","gists_url":"https://api.github.com/users/marcelmoosbrugger/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelmoosbrugger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelmoosbrugger/subscriptions","organizations_url":"https://api.github.com/users/marcelmoosbrugger/orgs","repos_url":"https://api.github.com/users/marcelmoosbrugger/repos","events_url":"https://api.github.com/users/marcelmoosbrugger/events{/privacy}","received_events_url":"https://api.github.com/users/marcelmoosbrugger/received_events","type":"User","site_admin":false},"body":"__Tasks:__\r\n- [x] implemented new header design\r\n- [x] moved tabs behaviour into header\r\n- [ ] got feedback\r\n\r\n__PRs:__\r\n- Husky: https://github.com/massiveart/husky/pull/510\r\n- Sulu-Buttons and behat tests: https://github.com/sulu-io/sulu/pull/1421\r\n\r\n__Informations:__\r\n\r\n| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| Tests pass?   | none\r\n| Fixed tickets | none\r\n| Doc           | none","created_at":"2015-07-24T06:11:24Z","updated_at":"2015-07-28T09:27:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b6845833dc3a7cdb95124191fa0b4e6cfcf5202","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sulu-io/sulu/pulls/1417/commits","review_comments_url":"https://api.github.com/repos/sulu-io/sulu/pulls/1417/comments","review_comment_url":"https://api.github.com/repos/sulu-io/sulu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sulu-io/sulu/issues/1417/comments","statuses_url":"https://api.github.com/repos/sulu-io/sulu/statuses/cf78386062d7a8247e7d43a49d069ffb9fff4482","head":{"label":"sulu-io:feature/header","ref":"feature/header","sha":"cf78386062d7a8247e7d43a49d069ffb9fff4482","user":{"login":"sulu-io","id":5717006,"avatar_url":"https://avatars.githubusercontent.com/u/5717006?v=3","gravatar_id":"","url":"https://api.github.com/users/sulu-io","html_url":"https://github.com/sulu-io","followers_url":"https://api.github.com/users/sulu-io/followers","following_url":"https://api.github.com/users/sulu-io/following{/other_user}","gists_url":"https://api.github.com/users/sulu-io/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu-io/subscriptions","organizations_url":"https://api.github.com/users/sulu-io/orgs","repos_url":"https://api.github.com/users/sulu-io/repos","events_url":"https://api.github.com/users/sulu-io/events{/privacy}","received_events_url":"https://api.github.com/users/sulu-io/received_events","type":"Organization","site_admin":false},"repo":{"id":13678015,"name":"sulu","full_name":"sulu-io/sulu","owner":{"login":"sulu-io","id":5717006,"avatar_url":"https://avatars.githubusercontent.com/u/5717006?v=3","gravatar_id":"","url":"https://api.github.com/users/sulu-io","html_url":"https://github.com/sulu-io","followers_url":"https://api.github.com/users/sulu-io/followers","following_url":"https://api.github.com/users/sulu-io/following{/other_user}","gists_url":"https://api.github.com/users/sulu-io/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu-io/subscriptions","organizations_url":"https://api.github.com/users/sulu-io/orgs","repos_url":"https://api.github.com/users/sulu-io/repos","events_url":"https://api.github.com/users/sulu-io/events{/privacy}","received_events_url":"https://api.github.com/users/sulu-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sulu-io/sulu","description":"Sulu core bundle & components","fork":false,"url":"https://api.github.com/repos/sulu-io/sulu","forks_url":"https://api.github.com/repos/sulu-io/sulu/forks","keys_url":"https://api.github.com/repos/sulu-io/sulu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sulu-io/sulu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sulu-io/sulu/teams","hooks_url":"https://api.github.com/repos/sulu-io/sulu/hooks","issue_events_url":"https://api.github.com/repos/sulu-io/sulu/issues/events{/number}","events_url":"https://api.github.com/repos/sulu-io/sulu/events","assignees_url":"https://api.github.com/repos/sulu-io/sulu/assignees{/user}","branches_url":"https://api.github.com/repos/sulu-io/sulu/branches{/branch}","tags_url":"https://api.github.com/repos/sulu-io/sulu/tags","blobs_url":"https://api.github.com/repos/sulu-io/sulu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sulu-io/sulu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sulu-io/sulu/git/refs{/sha}","trees_url":"https://api.github.com/repos/sulu-io/sulu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sulu-io/sulu/statuses/{sha}","languages_url":"https://api.github.com/repos/sulu-io/sulu/languages","stargazers_url":"https://api.github.com/repos/sulu-io/sulu/stargazers","contributors_url":"https://api.github.com/repos/sulu-io/sulu/contributors","subscribers_url":"https://api.github.com/repos/sulu-io/sulu/subscribers","subscription_url":"https://api.github.com/repos/sulu-io/sulu/subscription","commits_url":"https://api.github.com/repos/sulu-io/sulu/commits{/sha}","git_commits_url":"https://api.github.com/repos/sulu-io/sulu/git/commits{/sha}","comments_url":"https://api.github.com/repos/sulu-io/sulu/comments{/number}","issue_comment_url":"https://api.github.com/repos/sulu-io/sulu/issues/comments{/number}","contents_url":"https://api.github.com/repos/sulu-io/sulu/contents/{+path}","compare_url":"https://api.github.com/repos/sulu-io/sulu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sulu-io/sulu/merges","archive_url":"https://api.github.com/repos/sulu-io/sulu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sulu-io/sulu/downloads","issues_url":"https://api.github.com/repos/sulu-io/sulu/issues{/number}","pulls_url":"https://api.github.com/repos/sulu-io/sulu/pulls{/number}","milestones_url":"https://api.github.com/repos/sulu-io/sulu/milestones{/number}","notifications_url":"https://api.github.com/repos/sulu-io/sulu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sulu-io/sulu/labels{/name}","releases_url":"https://api.github.com/repos/sulu-io/sulu/releases{/id}","created_at":"2013-10-18T12:57:02Z","updated_at":"2015-07-28T08:18:54Z","pushed_at":"2015-07-28T09:27:20Z","git_url":"git://github.com/sulu-io/sulu.git","ssh_url":"git@github.com:sulu-io/sulu.git","clone_url":"https://github.com/sulu-io/sulu.git","svn_url":"https://github.com/sulu-io/sulu","homepage":"sulu.io","size":63034,"stargazers_count":58,"watchers_count":58,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":324,"forks":17,"open_issues":324,"watchers":58,"default_branch":"develop"}},"base":{"label":"sulu-io:feature/redesign","ref":"feature/redesign","sha":"a0efccae7b1abfa60283ff9076f03e0f9a07a128","user":{"login":"sulu-io","id":5717006,"avatar_url":"https://avatars.githubusercontent.com/u/5717006?v=3","gravatar_id":"","url":"https://api.github.com/users/sulu-io","html_url":"https://github.com/sulu-io","followers_url":"https://api.github.com/users/sulu-io/followers","following_url":"https://api.github.com/users/sulu-io/following{/other_user}","gists_url":"https://api.github.com/users/sulu-io/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu-io/subscriptions","organizations_url":"https://api.github.com/users/sulu-io/orgs","repos_url":"https://api.github.com/users/sulu-io/repos","events_url":"https://api.github.com/users/sulu-io/events{/privacy}","received_events_url":"https://api.github.com/users/sulu-io/received_events","type":"Organization","site_admin":false},"repo":{"id":13678015,"name":"sulu","full_name":"sulu-io/sulu","owner":{"login":"sulu-io","id":5717006,"avatar_url":"https://avatars.githubusercontent.com/u/5717006?v=3","gravatar_id":"","url":"https://api.github.com/users/sulu-io","html_url":"https://github.com/sulu-io","followers_url":"https://api.github.com/users/sulu-io/followers","following_url":"https://api.github.com/users/sulu-io/following{/other_user}","gists_url":"https://api.github.com/users/sulu-io/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu-io/subscriptions","organizations_url":"https://api.github.com/users/sulu-io/orgs","repos_url":"https://api.github.com/users/sulu-io/repos","events_url":"https://api.github.com/users/sulu-io/events{/privacy}","received_events_url":"https://api.github.com/users/sulu-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sulu-io/sulu","description":"Sulu core bundle & components","fork":false,"url":"https://api.github.com/repos/sulu-io/sulu","forks_url":"https://api.github.com/repos/sulu-io/sulu/forks","keys_url":"https://api.github.com/repos/sulu-io/sulu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sulu-io/sulu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sulu-io/sulu/teams","hooks_url":"https://api.github.com/repos/sulu-io/sulu/hooks","issue_events_url":"https://api.github.com/repos/sulu-io/sulu/issues/events{/number}","events_url":"https://api.github.com/repos/sulu-io/sulu/events","assignees_url":"https://api.github.com/repos/sulu-io/sulu/assignees{/user}","branches_url":"https://api.github.com/repos/sulu-io/sulu/branches{/branch}","tags_url":"https://api.github.com/repos/sulu-io/sulu/tags","blobs_url":"https://api.github.com/repos/sulu-io/sulu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sulu-io/sulu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sulu-io/sulu/git/refs{/sha}","trees_url":"https://api.github.com/repos/sulu-io/sulu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sulu-io/sulu/statuses/{sha}","languages_url":"https://api.github.com/repos/sulu-io/sulu/languages","stargazers_url":"https://api.github.com/repos/sulu-io/sulu/stargazers","contributors_url":"https://api.github.com/repos/sulu-io/sulu/contributors","subscribers_url":"https://api.github.com/repos/sulu-io/sulu/subscribers","subscription_url":"https://api.github.com/repos/sulu-io/sulu/subscription","commits_url":"https://api.github.com/repos/sulu-io/sulu/commits{/sha}","git_commits_url":"https://api.github.com/repos/sulu-io/sulu/git/commits{/sha}","comments_url":"https://api.github.com/repos/sulu-io/sulu/comments{/number}","issue_comment_url":"https://api.github.com/repos/sulu-io/sulu/issues/comments{/number}","contents_url":"https://api.github.com/repos/sulu-io/sulu/contents/{+path}","compare_url":"https://api.github.com/repos/sulu-io/sulu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sulu-io/sulu/merges","archive_url":"https://api.github.com/repos/sulu-io/sulu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sulu-io/sulu/downloads","issues_url":"https://api.github.com/repos/sulu-io/sulu/issues{/number}","pulls_url":"https://api.github.com/repos/sulu-io/sulu/pulls{/number}","milestones_url":"https://api.github.com/repos/sulu-io/sulu/milestones{/number}","notifications_url":"https://api.github.com/repos/sulu-io/sulu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sulu-io/sulu/labels{/name}","releases_url":"https://api.github.com/repos/sulu-io/sulu/releases{/id}","created_at":"2013-10-18T12:57:02Z","updated_at":"2015-07-28T08:18:54Z","pushed_at":"2015-07-28T09:27:20Z","git_url":"git://github.com/sulu-io/sulu.git","ssh_url":"git@github.com:sulu-io/sulu.git","clone_url":"https://github.com/sulu-io/sulu.git","svn_url":"https://github.com/sulu-io/sulu","homepage":"sulu.io","size":63034,"stargazers_count":58,"watchers_count":58,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":324,"forks":17,"open_issues":324,"watchers":58,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sulu-io/sulu/pulls/1417"},"html":{"href":"https://github.com/sulu-io/sulu/pull/1417"},"issue":{"href":"https://api.github.com/repos/sulu-io/sulu/issues/1417"},"comments":{"href":"https://api.github.com/repos/sulu-io/sulu/issues/1417/comments"},"review_comments":{"href":"https://api.github.com/repos/sulu-io/sulu/pulls/1417/comments"},"review_comment":{"href":"https://api.github.com/repos/sulu-io/sulu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sulu-io/sulu/pulls/1417/commits"},"statuses":{"href":"https://api.github.com/repos/sulu-io/sulu/statuses/cf78386062d7a8247e7d43a49d069ffb9fff4482"}}}}