{"action":"created","comment":{"url":"https://api.github.com/repos/mobify/vellum/pulls/comments/27438831","id":27438831,"diff_hunk":"@@ -33,8 +33,8 @@ ol {\n // following code:\n \n %ol {\n-    margin-bottom: $v-space;\n-    padding-left: $h-space;\n+    margin-bottom: $unit;\n+    padding-left: $unit * 0.5;\n ","path":"dist/vellum/_lists.scss","position":19,"original_position":19,"commit_id":"67ae51b91d6fe2609612508cbfe9ad20cd72c9eb","original_commit_id":"67ae51b91d6fe2609612508cbfe9ad20cd72c9eb","user":{"login":"nastiatikk","id":4110509,"avatar_url":"https://avatars.githubusercontent.com/u/4110509?v=3","gravatar_id":"","url":"https://api.github.com/users/nastiatikk","html_url":"https://github.com/nastiatikk","followers_url":"https://api.github.com/users/nastiatikk/followers","following_url":"https://api.github.com/users/nastiatikk/following{/other_user}","gists_url":"https://api.github.com/users/nastiatikk/gists{/gist_id}","starred_url":"https://api.github.com/users/nastiatikk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nastiatikk/subscriptions","organizations_url":"https://api.github.com/users/nastiatikk/orgs","repos_url":"https://api.github.com/users/nastiatikk/repos","events_url":"https://api.github.com/users/nastiatikk/events{/privacy}","received_events_url":"https://api.github.com/users/nastiatikk/received_events","type":"User","site_admin":false},"body":"It's a minor thing but previously you've been using `$unit / 2` and here you do the same thing but with `$unit * 0.5`. ","created_at":"2015-03-30T22:38:26Z","updated_at":"2015-03-30T22:38:26Z","html_url":"https://github.com/mobify/vellum/pull/70#discussion_r27438831","pull_request_url":"https://api.github.com/repos/mobify/vellum/pulls/70","_links":{"self":{"href":"https://api.github.com/repos/mobify/vellum/pulls/comments/27438831"},"html":{"href":"https://github.com/mobify/vellum/pull/70#discussion_r27438831"},"pull_request":{"href":"https://api.github.com/repos/mobify/vellum/pulls/70"}}},"pull_request":{"url":"https://api.github.com/repos/mobify/vellum/pulls/70","id":31383485,"html_url":"https://github.com/mobify/vellum/pull/70","diff_url":"https://github.com/mobify/vellum/pull/70.diff","patch_url":"https://github.com/mobify/vellum/pull/70.patch","issue_url":"https://api.github.com/repos/mobify/vellum/issues/70","number":70,"state":"open","locked":false,"title":"Replace $v-space and $h-space with a single $unit","user":{"login":"ry5n","id":804014,"avatar_url":"https://avatars.githubusercontent.com/u/804014?v=3","gravatar_id":"","url":"https://api.github.com/users/ry5n","html_url":"https://github.com/ry5n","followers_url":"https://api.github.com/users/ry5n/followers","following_url":"https://api.github.com/users/ry5n/following{/other_user}","gists_url":"https://api.github.com/users/ry5n/gists{/gist_id}","starred_url":"https://api.github.com/users/ry5n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ry5n/subscriptions","organizations_url":"https://api.github.com/users/ry5n/orgs","repos_url":"https://api.github.com/users/ry5n/repos","events_url":"https://api.github.com/users/ry5n/events{/privacy}","received_events_url":"https://api.github.com/users/ry5n/received_events","type":"User","site_admin":false},"body":"Since we first switched from `$margin` to `$v-space` and `$h-space`, they have been a source of confusion:\r\n\r\n> Can I only use v-space for vertical metrics? Same with h-space?\r\n> What if I need the value of one of them for something that isn’t spacing? Is that weird?\r\n> Why is the distinction between horizontal and vertical so important?\r\n\r\nThis PR introduces `$unit` to replace both v-space and h-space. Think of it as the fundamental unit for doing layout, including things like spacing and alignment. The suggested value is between 6px and 12px (in Vellum it computes to 11px, identical to the old $v-space).\r\n\r\nStatus: **Ready for review**\r\n\r\nReviewers: @kpeatt @jeffkamo @nastiatikk @avelinet @cole-sanderson @mlworks \r\nTicket: N/A\r\n\r\n## Changes\r\n- Replaces the `$v-space` and `$h-space` variables with `$unit`\r\n- Changes instances of the old variables to the new one while keeping output values the same\r\n- <del>Ignore sourcemaps in tests</del> <ins>Sourcemaps now ignored in master</ins>\r\n\r\n## How to test-drive this PR\r\n1. Checkout the master branch of vellum\r\n2. Run `grunt` (default task) to compile the css\r\n3. Open test/index.html in a browser; don’t close the tab\r\n4. Check out the unit-var branch and run `grunt` again to recompile\r\n5. Open a _new_ browser window; load up a new instance of index.html\r\n6. Do a visual comparison of the two pages and verify things look the same\r\n\r\n## Todos\r\n- [x] Discussed at one Design + UI Dev joint meeting \r\n- [x] Designer/Developer +1\r\n- [x] Designer/Developer +1\r\n- [ ] Designer/Developer +1","created_at":"2015-03-17T22:14:03Z","updated_at":"2015-03-30T22:38:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af325bf29d2e8c88dfe11058ab3e81017f607a0c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mobify/vellum/pulls/70/commits","review_comments_url":"https://api.github.com/repos/mobify/vellum/pulls/70/comments","review_comment_url":"https://api.github.com/repos/mobify/vellum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mobify/vellum/issues/70/comments","statuses_url":"https://api.github.com/repos/mobify/vellum/statuses/67ae51b91d6fe2609612508cbfe9ad20cd72c9eb","head":{"label":"mobify:unit-var","ref":"unit-var","sha":"67ae51b91d6fe2609612508cbfe9ad20cd72c9eb","user":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"repo":{"id":18122172,"name":"vellum","full_name":"mobify/vellum","owner":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mobify/vellum","description":"Default project styles for a mobile-first AdaptiveJS build.","fork":false,"url":"https://api.github.com/repos/mobify/vellum","forks_url":"https://api.github.com/repos/mobify/vellum/forks","keys_url":"https://api.github.com/repos/mobify/vellum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mobify/vellum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mobify/vellum/teams","hooks_url":"https://api.github.com/repos/mobify/vellum/hooks","issue_events_url":"https://api.github.com/repos/mobify/vellum/issues/events{/number}","events_url":"https://api.github.com/repos/mobify/vellum/events","assignees_url":"https://api.github.com/repos/mobify/vellum/assignees{/user}","branches_url":"https://api.github.com/repos/mobify/vellum/branches{/branch}","tags_url":"https://api.github.com/repos/mobify/vellum/tags","blobs_url":"https://api.github.com/repos/mobify/vellum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mobify/vellum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mobify/vellum/git/refs{/sha}","trees_url":"https://api.github.com/repos/mobify/vellum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mobify/vellum/statuses/{sha}","languages_url":"https://api.github.com/repos/mobify/vellum/languages","stargazers_url":"https://api.github.com/repos/mobify/vellum/stargazers","contributors_url":"https://api.github.com/repos/mobify/vellum/contributors","subscribers_url":"https://api.github.com/repos/mobify/vellum/subscribers","subscription_url":"https://api.github.com/repos/mobify/vellum/subscription","commits_url":"https://api.github.com/repos/mobify/vellum/commits{/sha}","git_commits_url":"https://api.github.com/repos/mobify/vellum/git/commits{/sha}","comments_url":"https://api.github.com/repos/mobify/vellum/comments{/number}","issue_comment_url":"https://api.github.com/repos/mobify/vellum/issues/comments{/number}","contents_url":"https://api.github.com/repos/mobify/vellum/contents/{+path}","compare_url":"https://api.github.com/repos/mobify/vellum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mobify/vellum/merges","archive_url":"https://api.github.com/repos/mobify/vellum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mobify/vellum/downloads","issues_url":"https://api.github.com/repos/mobify/vellum/issues{/number}","pulls_url":"https://api.github.com/repos/mobify/vellum/pulls{/number}","milestones_url":"https://api.github.com/repos/mobify/vellum/milestones{/number}","notifications_url":"https://api.github.com/repos/mobify/vellum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mobify/vellum/labels{/name}","releases_url":"https://api.github.com/repos/mobify/vellum/releases{/id}","created_at":"2014-03-26T00:52:38Z","updated_at":"2015-03-27T00:48:41Z","pushed_at":"2015-03-30T22:09:22Z","git_url":"git://github.com/mobify/vellum.git","ssh_url":"git@github.com:mobify/vellum.git","clone_url":"https://github.com/mobify/vellum.git","svn_url":"https://github.com/mobify/vellum","homepage":null,"size":920,"stargazers_count":3,"watchers_count":3,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":3,"default_branch":"master"}},"base":{"label":"mobify:master","ref":"master","sha":"5220378db26402dc15ee8497611208d15731ae58","user":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"repo":{"id":18122172,"name":"vellum","full_name":"mobify/vellum","owner":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mobify/vellum","description":"Default project styles for a mobile-first AdaptiveJS build.","fork":false,"url":"https://api.github.com/repos/mobify/vellum","forks_url":"https://api.github.com/repos/mobify/vellum/forks","keys_url":"https://api.github.com/repos/mobify/vellum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mobify/vellum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mobify/vellum/teams","hooks_url":"https://api.github.com/repos/mobify/vellum/hooks","issue_events_url":"https://api.github.com/repos/mobify/vellum/issues/events{/number}","events_url":"https://api.github.com/repos/mobify/vellum/events","assignees_url":"https://api.github.com/repos/mobify/vellum/assignees{/user}","branches_url":"https://api.github.com/repos/mobify/vellum/branches{/branch}","tags_url":"https://api.github.com/repos/mobify/vellum/tags","blobs_url":"https://api.github.com/repos/mobify/vellum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mobify/vellum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mobify/vellum/git/refs{/sha}","trees_url":"https://api.github.com/repos/mobify/vellum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mobify/vellum/statuses/{sha}","languages_url":"https://api.github.com/repos/mobify/vellum/languages","stargazers_url":"https://api.github.com/repos/mobify/vellum/stargazers","contributors_url":"https://api.github.com/repos/mobify/vellum/contributors","subscribers_url":"https://api.github.com/repos/mobify/vellum/subscribers","subscription_url":"https://api.github.com/repos/mobify/vellum/subscription","commits_url":"https://api.github.com/repos/mobify/vellum/commits{/sha}","git_commits_url":"https://api.github.com/repos/mobify/vellum/git/commits{/sha}","comments_url":"https://api.github.com/repos/mobify/vellum/comments{/number}","issue_comment_url":"https://api.github.com/repos/mobify/vellum/issues/comments{/number}","contents_url":"https://api.github.com/repos/mobify/vellum/contents/{+path}","compare_url":"https://api.github.com/repos/mobify/vellum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mobify/vellum/merges","archive_url":"https://api.github.com/repos/mobify/vellum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mobify/vellum/downloads","issues_url":"https://api.github.com/repos/mobify/vellum/issues{/number}","pulls_url":"https://api.github.com/repos/mobify/vellum/pulls{/number}","milestones_url":"https://api.github.com/repos/mobify/vellum/milestones{/number}","notifications_url":"https://api.github.com/repos/mobify/vellum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mobify/vellum/labels{/name}","releases_url":"https://api.github.com/repos/mobify/vellum/releases{/id}","created_at":"2014-03-26T00:52:38Z","updated_at":"2015-03-27T00:48:41Z","pushed_at":"2015-03-30T22:09:22Z","git_url":"git://github.com/mobify/vellum.git","ssh_url":"git@github.com:mobify/vellum.git","clone_url":"https://github.com/mobify/vellum.git","svn_url":"https://github.com/mobify/vellum","homepage":null,"size":920,"stargazers_count":3,"watchers_count":3,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mobify/vellum/pulls/70"},"html":{"href":"https://github.com/mobify/vellum/pull/70"},"issue":{"href":"https://api.github.com/repos/mobify/vellum/issues/70"},"comments":{"href":"https://api.github.com/repos/mobify/vellum/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/mobify/vellum/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/mobify/vellum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mobify/vellum/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/mobify/vellum/statuses/67ae51b91d6fe2609612508cbfe9ad20cd72c9eb"}}}}