{"action":"created","issue":{"url":"https://api.github.com/repos/xbehave/xbehave.net/issues/270","labels_url":"https://api.github.com/repos/xbehave/xbehave.net/issues/270/labels{/name}","comments_url":"https://api.github.com/repos/xbehave/xbehave.net/issues/270/comments","events_url":"https://api.github.com/repos/xbehave/xbehave.net/issues/270/events","html_url":"https://github.com/xbehave/xbehave.net/pull/270","id":107659197,"number":270,"title":"Argument formatting of arrays","user":{"login":"ursenzler","id":287565,"avatar_url":"https://avatars.githubusercontent.com/u/287565?v=3","gravatar_id":"","url":"https://api.github.com/users/ursenzler","html_url":"https://github.com/ursenzler","followers_url":"https://api.github.com/users/ursenzler/followers","following_url":"https://api.github.com/users/ursenzler/following{/other_user}","gists_url":"https://api.github.com/users/ursenzler/gists{/gist_id}","starred_url":"https://api.github.com/users/ursenzler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ursenzler/subscriptions","organizations_url":"https://api.github.com/users/ursenzler/orgs","repos_url":"https://api.github.com/users/ursenzler/repos","events_url":"https://api.github.com/users/ursenzler/events{/privacy}","received_events_url":"https://api.github.com/users/ursenzler/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"adamralph","id":677704,"avatar_url":"https://avatars.githubusercontent.com/u/677704?v=3","gravatar_id":"","url":"https://api.github.com/users/adamralph","html_url":"https://github.com/adamralph","followers_url":"https://api.github.com/users/adamralph/followers","following_url":"https://api.github.com/users/adamralph/following{/other_user}","gists_url":"https://api.github.com/users/adamralph/gists{/gist_id}","starred_url":"https://api.github.com/users/adamralph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamralph/subscriptions","organizations_url":"https://api.github.com/users/adamralph/orgs","repos_url":"https://api.github.com/users/adamralph/repos","events_url":"https://api.github.com/users/adamralph/events{/privacy}","received_events_url":"https://api.github.com/users/adamralph/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2015-09-22T07:22:17Z","updated_at":"2015-10-12T20:07:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xbehave/xbehave.net/pulls/270","html_url":"https://github.com/xbehave/xbehave.net/pull/270","diff_url":"https://github.com/xbehave/xbehave.net/pull/270.diff","patch_url":"https://github.com/xbehave/xbehave.net/pull/270.patch"},"body":"I changed the formatting of scenario arguments from `Example`s in the report to match the xUnit formatting.\r\n\r\nI took the `ArgumentFormatter` from xUnit to format the arguments in the test report. The code is copied because the class is internal to xUnit. Maybe we could make a pull request to make the class public?\r\n\r\nI used the `Reflector` from xUnit to convert the arguments from `Example`s to the type specified in the `Scenario` method.\r\n\r\nPlease provide feedback for:\r\n- is the spec written in the correct way (`ArgumentFormatting`). I'm not sure I understood this `Feature` construct correctly.\r\n- The code converting the arguments is not covered enough by tests in my opinion, but where would I add these tests? The class where I added the code has no unit tests (`MethodInfoExtensions`)."},"comment":{"url":"https://api.github.com/repos/xbehave/xbehave.net/issues/comments/147505771","html_url":"https://github.com/xbehave/xbehave.net/pull/270#issuecomment-147505771","issue_url":"https://api.github.com/repos/xbehave/xbehave.net/issues/270","id":147505771,"user":{"login":"adamralph","id":677704,"avatar_url":"https://avatars.githubusercontent.com/u/677704?v=3","gravatar_id":"","url":"https://api.github.com/users/adamralph","html_url":"https://github.com/adamralph","followers_url":"https://api.github.com/users/adamralph/followers","following_url":"https://api.github.com/users/adamralph/following{/other_user}","gists_url":"https://api.github.com/users/adamralph/gists{/gist_id}","starred_url":"https://api.github.com/users/adamralph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamralph/subscriptions","organizations_url":"https://api.github.com/users/adamralph/orgs","repos_url":"https://api.github.com/users/adamralph/repos","events_url":"https://api.github.com/users/adamralph/events{/privacy}","received_events_url":"https://api.github.com/users/adamralph/received_events","type":"User","site_admin":false},"created_at":"2015-10-12T20:07:36Z","updated_at":"2015-10-12T20:07:36Z","body":"> I took the ArgumentFormatter from xUnit to format the arguments in the test report. The code is copied because the class is internal to xUnit. Maybe we could make a pull request to make the class public?\r\n\r\n@bradwilson - would you accept a PR making `ArgumentFormatter ` public?\r\n\r\n"}}