{"action":"closed","number":21,"pull_request":{"url":"https://api.github.com/repos/tonistiigi/dnsdock/pulls/21","id":38560949,"html_url":"https://github.com/tonistiigi/dnsdock/pull/21","diff_url":"https://github.com/tonistiigi/dnsdock/pull/21.diff","patch_url":"https://github.com/tonistiigi/dnsdock/pull/21.patch","issue_url":"https://api.github.com/repos/tonistiigi/dnsdock/issues/21","number":21,"state":"closed","locked":false,"title":"Respond with SOA in the authority section when no records found.","user":{"login":"kgutwin","id":6315798,"avatar_url":"https://avatars.githubusercontent.com/u/6315798?v=3","gravatar_id":"","url":"https://api.github.com/users/kgutwin","html_url":"https://github.com/kgutwin","followers_url":"https://api.github.com/users/kgutwin/followers","following_url":"https://api.github.com/users/kgutwin/following{/other_user}","gists_url":"https://api.github.com/users/kgutwin/gists{/gist_id}","starred_url":"https://api.github.com/users/kgutwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgutwin/subscriptions","organizations_url":"https://api.github.com/users/kgutwin/orgs","repos_url":"https://api.github.com/users/kgutwin/repos","events_url":"https://api.github.com/users/kgutwin/events{/privacy}","received_events_url":"https://api.github.com/users/kgutwin/received_events","type":"User","site_admin":false},"body":"When no records were found for a particular request, instead of sending one Answer with the SOA record, we should instead set the Rcode to NXDOMAIN and provide the SOA record in the Ns (authority) section of the reply. Also, we can claim to have SOA over the domain provided on launch, and generate a reasonable hostname for ourselves (dnsdock.domain). ","created_at":"2015-06-25T15:35:45Z","updated_at":"2015-06-27T08:25:19Z","closed_at":"2015-06-27T08:25:19Z","merged_at":"2015-06-27T08:25:19Z","merge_commit_sha":"8dd1a832f379705b83db8d255f4740ceed4ba766","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tonistiigi/dnsdock/pulls/21/commits","review_comments_url":"https://api.github.com/repos/tonistiigi/dnsdock/pulls/21/comments","review_comment_url":"https://api.github.com/repos/tonistiigi/dnsdock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tonistiigi/dnsdock/issues/21/comments","statuses_url":"https://api.github.com/repos/tonistiigi/dnsdock/statuses/c8ff6a3405881239ed581c1d4491ce4c004de47a","head":{"label":"kgutwin:soafix","ref":"soafix","sha":"c8ff6a3405881239ed581c1d4491ce4c004de47a","user":{"login":"kgutwin","id":6315798,"avatar_url":"https://avatars.githubusercontent.com/u/6315798?v=3","gravatar_id":"","url":"https://api.github.com/users/kgutwin","html_url":"https://github.com/kgutwin","followers_url":"https://api.github.com/users/kgutwin/followers","following_url":"https://api.github.com/users/kgutwin/following{/other_user}","gists_url":"https://api.github.com/users/kgutwin/gists{/gist_id}","starred_url":"https://api.github.com/users/kgutwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgutwin/subscriptions","organizations_url":"https://api.github.com/users/kgutwin/orgs","repos_url":"https://api.github.com/users/kgutwin/repos","events_url":"https://api.github.com/users/kgutwin/events{/privacy}","received_events_url":"https://api.github.com/users/kgutwin/received_events","type":"User","site_admin":false},"repo":{"id":37866823,"name":"dnsdock","full_name":"kgutwin/dnsdock","owner":{"login":"kgutwin","id":6315798,"avatar_url":"https://avatars.githubusercontent.com/u/6315798?v=3","gravatar_id":"","url":"https://api.github.com/users/kgutwin","html_url":"https://github.com/kgutwin","followers_url":"https://api.github.com/users/kgutwin/followers","following_url":"https://api.github.com/users/kgutwin/following{/other_user}","gists_url":"https://api.github.com/users/kgutwin/gists{/gist_id}","starred_url":"https://api.github.com/users/kgutwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgutwin/subscriptions","organizations_url":"https://api.github.com/users/kgutwin/orgs","repos_url":"https://api.github.com/users/kgutwin/repos","events_url":"https://api.github.com/users/kgutwin/events{/privacy}","received_events_url":"https://api.github.com/users/kgutwin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kgutwin/dnsdock","description":"DNS service discovery for Docker containers","fork":true,"url":"https://api.github.com/repos/kgutwin/dnsdock","forks_url":"https://api.github.com/repos/kgutwin/dnsdock/forks","keys_url":"https://api.github.com/repos/kgutwin/dnsdock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kgutwin/dnsdock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kgutwin/dnsdock/teams","hooks_url":"https://api.github.com/repos/kgutwin/dnsdock/hooks","issue_events_url":"https://api.github.com/repos/kgutwin/dnsdock/issues/events{/number}","events_url":"https://api.github.com/repos/kgutwin/dnsdock/events","assignees_url":"https://api.github.com/repos/kgutwin/dnsdock/assignees{/user}","branches_url":"https://api.github.com/repos/kgutwin/dnsdock/branches{/branch}","tags_url":"https://api.github.com/repos/kgutwin/dnsdock/tags","blobs_url":"https://api.github.com/repos/kgutwin/dnsdock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kgutwin/dnsdock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kgutwin/dnsdock/git/refs{/sha}","trees_url":"https://api.github.com/repos/kgutwin/dnsdock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kgutwin/dnsdock/statuses/{sha}","languages_url":"https://api.github.com/repos/kgutwin/dnsdock/languages","stargazers_url":"https://api.github.com/repos/kgutwin/dnsdock/stargazers","contributors_url":"https://api.github.com/repos/kgutwin/dnsdock/contributors","subscribers_url":"https://api.github.com/repos/kgutwin/dnsdock/subscribers","subscription_url":"https://api.github.com/repos/kgutwin/dnsdock/subscription","commits_url":"https://api.github.com/repos/kgutwin/dnsdock/commits{/sha}","git_commits_url":"https://api.github.com/repos/kgutwin/dnsdock/git/commits{/sha}","comments_url":"https://api.github.com/repos/kgutwin/dnsdock/comments{/number}","issue_comment_url":"https://api.github.com/repos/kgutwin/dnsdock/issues/comments{/number}","contents_url":"https://api.github.com/repos/kgutwin/dnsdock/contents/{+path}","compare_url":"https://api.github.com/repos/kgutwin/dnsdock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kgutwin/dnsdock/merges","archive_url":"https://api.github.com/repos/kgutwin/dnsdock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kgutwin/dnsdock/downloads","issues_url":"https://api.github.com/repos/kgutwin/dnsdock/issues{/number}","pulls_url":"https://api.github.com/repos/kgutwin/dnsdock/pulls{/number}","milestones_url":"https://api.github.com/repos/kgutwin/dnsdock/milestones{/number}","notifications_url":"https://api.github.com/repos/kgutwin/dnsdock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kgutwin/dnsdock/labels{/name}","releases_url":"https://api.github.com/repos/kgutwin/dnsdock/releases{/id}","created_at":"2015-06-22T16:30:39Z","updated_at":"2015-06-22T16:30:39Z","pushed_at":"2015-06-25T18:13:29Z","git_url":"git://github.com/kgutwin/dnsdock.git","ssh_url":"git@github.com:kgutwin/dnsdock.git","clone_url":"https://github.com/kgutwin/dnsdock.git","svn_url":"https://github.com/kgutwin/dnsdock","homepage":null,"size":323,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tonistiigi:master","ref":"master","sha":"5cf17e70d5cbe0c1cde637632289adaef6e355ff","user":{"login":"tonistiigi","id":585223,"avatar_url":"https://avatars.githubusercontent.com/u/585223?v=3","gravatar_id":"","url":"https://api.github.com/users/tonistiigi","html_url":"https://github.com/tonistiigi","followers_url":"https://api.github.com/users/tonistiigi/followers","following_url":"https://api.github.com/users/tonistiigi/following{/other_user}","gists_url":"https://api.github.com/users/tonistiigi/gists{/gist_id}","starred_url":"https://api.github.com/users/tonistiigi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonistiigi/subscriptions","organizations_url":"https://api.github.com/users/tonistiigi/orgs","repos_url":"https://api.github.com/users/tonistiigi/repos","events_url":"https://api.github.com/users/tonistiigi/events{/privacy}","received_events_url":"https://api.github.com/users/tonistiigi/received_events","type":"User","site_admin":false},"repo":{"id":23159297,"name":"dnsdock","full_name":"tonistiigi/dnsdock","owner":{"login":"tonistiigi","id":585223,"avatar_url":"https://avatars.githubusercontent.com/u/585223?v=3","gravatar_id":"","url":"https://api.github.com/users/tonistiigi","html_url":"https://github.com/tonistiigi","followers_url":"https://api.github.com/users/tonistiigi/followers","following_url":"https://api.github.com/users/tonistiigi/following{/other_user}","gists_url":"https://api.github.com/users/tonistiigi/gists{/gist_id}","starred_url":"https://api.github.com/users/tonistiigi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonistiigi/subscriptions","organizations_url":"https://api.github.com/users/tonistiigi/orgs","repos_url":"https://api.github.com/users/tonistiigi/repos","events_url":"https://api.github.com/users/tonistiigi/events{/privacy}","received_events_url":"https://api.github.com/users/tonistiigi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tonistiigi/dnsdock","description":"DNS service discovery for Docker containers","fork":false,"url":"https://api.github.com/repos/tonistiigi/dnsdock","forks_url":"https://api.github.com/repos/tonistiigi/dnsdock/forks","keys_url":"https://api.github.com/repos/tonistiigi/dnsdock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tonistiigi/dnsdock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tonistiigi/dnsdock/teams","hooks_url":"https://api.github.com/repos/tonistiigi/dnsdock/hooks","issue_events_url":"https://api.github.com/repos/tonistiigi/dnsdock/issues/events{/number}","events_url":"https://api.github.com/repos/tonistiigi/dnsdock/events","assignees_url":"https://api.github.com/repos/tonistiigi/dnsdock/assignees{/user}","branches_url":"https://api.github.com/repos/tonistiigi/dnsdock/branches{/branch}","tags_url":"https://api.github.com/repos/tonistiigi/dnsdock/tags","blobs_url":"https://api.github.com/repos/tonistiigi/dnsdock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tonistiigi/dnsdock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tonistiigi/dnsdock/git/refs{/sha}","trees_url":"https://api.github.com/repos/tonistiigi/dnsdock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tonistiigi/dnsdock/statuses/{sha}","languages_url":"https://api.github.com/repos/tonistiigi/dnsdock/languages","stargazers_url":"https://api.github.com/repos/tonistiigi/dnsdock/stargazers","contributors_url":"https://api.github.com/repos/tonistiigi/dnsdock/contributors","subscribers_url":"https://api.github.com/repos/tonistiigi/dnsdock/subscribers","subscription_url":"https://api.github.com/repos/tonistiigi/dnsdock/subscription","commits_url":"https://api.github.com/repos/tonistiigi/dnsdock/commits{/sha}","git_commits_url":"https://api.github.com/repos/tonistiigi/dnsdock/git/commits{/sha}","comments_url":"https://api.github.com/repos/tonistiigi/dnsdock/comments{/number}","issue_comment_url":"https://api.github.com/repos/tonistiigi/dnsdock/issues/comments{/number}","contents_url":"https://api.github.com/repos/tonistiigi/dnsdock/contents/{+path}","compare_url":"https://api.github.com/repos/tonistiigi/dnsdock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tonistiigi/dnsdock/merges","archive_url":"https://api.github.com/repos/tonistiigi/dnsdock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tonistiigi/dnsdock/downloads","issues_url":"https://api.github.com/repos/tonistiigi/dnsdock/issues{/number}","pulls_url":"https://api.github.com/repos/tonistiigi/dnsdock/pulls{/number}","milestones_url":"https://api.github.com/repos/tonistiigi/dnsdock/milestones{/number}","notifications_url":"https://api.github.com/repos/tonistiigi/dnsdock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tonistiigi/dnsdock/labels{/name}","releases_url":"https://api.github.com/repos/tonistiigi/dnsdock/releases{/id}","created_at":"2014-08-20T18:22:31Z","updated_at":"2015-06-26T11:56:43Z","pushed_at":"2015-06-27T08:25:19Z","git_url":"git://github.com/tonistiigi/dnsdock.git","ssh_url":"git@github.com:tonistiigi/dnsdock.git","clone_url":"https://github.com/tonistiigi/dnsdock.git","svn_url":"https://github.com/tonistiigi/dnsdock","homepage":null,"size":522,"stargazers_count":74,"watchers_count":74,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":6,"forks":12,"open_issues":6,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tonistiigi/dnsdock/pulls/21"},"html":{"href":"https://github.com/tonistiigi/dnsdock/pull/21"},"issue":{"href":"https://api.github.com/repos/tonistiigi/dnsdock/issues/21"},"comments":{"href":"https://api.github.com/repos/tonistiigi/dnsdock/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/tonistiigi/dnsdock/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/tonistiigi/dnsdock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tonistiigi/dnsdock/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/tonistiigi/dnsdock/statuses/c8ff6a3405881239ed581c1d4491ce4c004de47a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tonistiigi","id":585223,"avatar_url":"https://avatars.githubusercontent.com/u/585223?v=3","gravatar_id":"","url":"https://api.github.com/users/tonistiigi","html_url":"https://github.com/tonistiigi","followers_url":"https://api.github.com/users/tonistiigi/followers","following_url":"https://api.github.com/users/tonistiigi/following{/other_user}","gists_url":"https://api.github.com/users/tonistiigi/gists{/gist_id}","starred_url":"https://api.github.com/users/tonistiigi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonistiigi/subscriptions","organizations_url":"https://api.github.com/users/tonistiigi/orgs","repos_url":"https://api.github.com/users/tonistiigi/repos","events_url":"https://api.github.com/users/tonistiigi/events{/privacy}","received_events_url":"https://api.github.com/users/tonistiigi/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":25,"deletions":20,"changed_files":2}}