{"action":"closed","number":962,"pull_request":{"url":"https://api.github.com/repos/intridea/grape/pulls/962","id":31579537,"html_url":"https://github.com/intridea/grape/pull/962","diff_url":"https://github.com/intridea/grape/pull/962.diff","patch_url":"https://github.com/intridea/grape/pull/962.patch","issue_url":"https://api.github.com/repos/intridea/grape/issues/962","number":962,"state":"closed","locked":false,"title":"Make sure to set documentation attribute even for `default: false`","user":{"login":"ajvondrak","id":600924,"avatar_url":"https://avatars.githubusercontent.com/u/600924?v=3","gravatar_id":"","url":"https://api.github.com/users/ajvondrak","html_url":"https://github.com/ajvondrak","followers_url":"https://api.github.com/users/ajvondrak/followers","following_url":"https://api.github.com/users/ajvondrak/following{/other_user}","gists_url":"https://api.github.com/users/ajvondrak/gists{/gist_id}","starred_url":"https://api.github.com/users/ajvondrak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajvondrak/subscriptions","organizations_url":"https://api.github.com/users/ajvondrak/orgs","repos_url":"https://api.github.com/users/ajvondrak/repos","events_url":"https://api.github.com/users/ajvondrak/events{/privacy}","received_events_url":"https://api.github.com/users/ajvondrak/received_events","type":"User","site_admin":false},"body":"I wasn't seeing documentation attributes get propagated for default values of `false` as in\r\n```\r\nparam :foo, type: Boolean, default: false\r\n```\r\n\r\nWhether or not this still propagates the default value correctly with grape-swagger / swagger-ui is tangential. Just noticed that the guard was being perhaps a bit too liberal with excluding values.\r\n\r\nMade a quick fix + added a couple regression tests.","created_at":"2015-03-20T00:33:51Z","updated_at":"2015-03-23T09:03:16Z","closed_at":"2015-03-23T09:03:16Z","merged_at":null,"merge_commit_sha":"8fb5cc85ca57eda69d9d339589c044589ea1adde","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/intridea/grape/pulls/962/commits","review_comments_url":"https://api.github.com/repos/intridea/grape/pulls/962/comments","review_comment_url":"https://api.github.com/repos/intridea/grape/pulls/comments{/number}","comments_url":"https://api.github.com/repos/intridea/grape/issues/962/comments","statuses_url":"https://api.github.com/repos/intridea/grape/statuses/4e01f351206693840b5398dd1ab7c0f4e79d527e","head":{"label":"ajvondrak:doc_attrs_fix","ref":"doc_attrs_fix","sha":"4e01f351206693840b5398dd1ab7c0f4e79d527e","user":{"login":"ajvondrak","id":600924,"avatar_url":"https://avatars.githubusercontent.com/u/600924?v=3","gravatar_id":"","url":"https://api.github.com/users/ajvondrak","html_url":"https://github.com/ajvondrak","followers_url":"https://api.github.com/users/ajvondrak/followers","following_url":"https://api.github.com/users/ajvondrak/following{/other_user}","gists_url":"https://api.github.com/users/ajvondrak/gists{/gist_id}","starred_url":"https://api.github.com/users/ajvondrak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajvondrak/subscriptions","organizations_url":"https://api.github.com/users/ajvondrak/orgs","repos_url":"https://api.github.com/users/ajvondrak/repos","events_url":"https://api.github.com/users/ajvondrak/events{/privacy}","received_events_url":"https://api.github.com/users/ajvondrak/received_events","type":"User","site_admin":false},"repo":{"id":26506503,"name":"grape","full_name":"ajvondrak/grape","owner":{"login":"ajvondrak","id":600924,"avatar_url":"https://avatars.githubusercontent.com/u/600924?v=3","gravatar_id":"","url":"https://api.github.com/users/ajvondrak","html_url":"https://github.com/ajvondrak","followers_url":"https://api.github.com/users/ajvondrak/followers","following_url":"https://api.github.com/users/ajvondrak/following{/other_user}","gists_url":"https://api.github.com/users/ajvondrak/gists{/gist_id}","starred_url":"https://api.github.com/users/ajvondrak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajvondrak/subscriptions","organizations_url":"https://api.github.com/users/ajvondrak/orgs","repos_url":"https://api.github.com/users/ajvondrak/repos","events_url":"https://api.github.com/users/ajvondrak/events{/privacy}","received_events_url":"https://api.github.com/users/ajvondrak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajvondrak/grape","description":"An opinionated micro-framework for creating REST-like APIs in Ruby.","fork":true,"url":"https://api.github.com/repos/ajvondrak/grape","forks_url":"https://api.github.com/repos/ajvondrak/grape/forks","keys_url":"https://api.github.com/repos/ajvondrak/grape/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajvondrak/grape/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajvondrak/grape/teams","hooks_url":"https://api.github.com/repos/ajvondrak/grape/hooks","issue_events_url":"https://api.github.com/repos/ajvondrak/grape/issues/events{/number}","events_url":"https://api.github.com/repos/ajvondrak/grape/events","assignees_url":"https://api.github.com/repos/ajvondrak/grape/assignees{/user}","branches_url":"https://api.github.com/repos/ajvondrak/grape/branches{/branch}","tags_url":"https://api.github.com/repos/ajvondrak/grape/tags","blobs_url":"https://api.github.com/repos/ajvondrak/grape/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajvondrak/grape/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajvondrak/grape/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajvondrak/grape/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajvondrak/grape/statuses/{sha}","languages_url":"https://api.github.com/repos/ajvondrak/grape/languages","stargazers_url":"https://api.github.com/repos/ajvondrak/grape/stargazers","contributors_url":"https://api.github.com/repos/ajvondrak/grape/contributors","subscribers_url":"https://api.github.com/repos/ajvondrak/grape/subscribers","subscription_url":"https://api.github.com/repos/ajvondrak/grape/subscription","commits_url":"https://api.github.com/repos/ajvondrak/grape/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajvondrak/grape/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajvondrak/grape/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajvondrak/grape/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajvondrak/grape/contents/{+path}","compare_url":"https://api.github.com/repos/ajvondrak/grape/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajvondrak/grape/merges","archive_url":"https://api.github.com/repos/ajvondrak/grape/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajvondrak/grape/downloads","issues_url":"https://api.github.com/repos/ajvondrak/grape/issues{/number}","pulls_url":"https://api.github.com/repos/ajvondrak/grape/pulls{/number}","milestones_url":"https://api.github.com/repos/ajvondrak/grape/milestones{/number}","notifications_url":"https://api.github.com/repos/ajvondrak/grape/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajvondrak/grape/labels{/name}","releases_url":"https://api.github.com/repos/ajvondrak/grape/releases{/id}","created_at":"2014-11-11T21:51:21Z","updated_at":"2015-03-20T00:22:18Z","pushed_at":"2015-03-20T23:54:20Z","git_url":"git://github.com/ajvondrak/grape.git","ssh_url":"git@github.com:ajvondrak/grape.git","clone_url":"https://github.com/ajvondrak/grape.git","svn_url":"https://github.com/ajvondrak/grape","homepage":"http://intridea.github.io/grape","size":5916,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"intridea:master","ref":"master","sha":"30aa864b625fe9208d37ce50bc759cfd1ccc34aa","user":{"login":"intridea","id":3747,"avatar_url":"https://avatars.githubusercontent.com/u/3747?v=3","gravatar_id":"","url":"https://api.github.com/users/intridea","html_url":"https://github.com/intridea","followers_url":"https://api.github.com/users/intridea/followers","following_url":"https://api.github.com/users/intridea/following{/other_user}","gists_url":"https://api.github.com/users/intridea/gists{/gist_id}","starred_url":"https://api.github.com/users/intridea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intridea/subscriptions","organizations_url":"https://api.github.com/users/intridea/orgs","repos_url":"https://api.github.com/users/intridea/repos","events_url":"https://api.github.com/users/intridea/events{/privacy}","received_events_url":"https://api.github.com/users/intridea/received_events","type":"Organization","site_admin":false},"repo":{"id":812393,"name":"grape","full_name":"intridea/grape","owner":{"login":"intridea","id":3747,"avatar_url":"https://avatars.githubusercontent.com/u/3747?v=3","gravatar_id":"","url":"https://api.github.com/users/intridea","html_url":"https://github.com/intridea","followers_url":"https://api.github.com/users/intridea/followers","following_url":"https://api.github.com/users/intridea/following{/other_user}","gists_url":"https://api.github.com/users/intridea/gists{/gist_id}","starred_url":"https://api.github.com/users/intridea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intridea/subscriptions","organizations_url":"https://api.github.com/users/intridea/orgs","repos_url":"https://api.github.com/users/intridea/repos","events_url":"https://api.github.com/users/intridea/events{/privacy}","received_events_url":"https://api.github.com/users/intridea/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/intridea/grape","description":"An opinionated micro-framework for creating REST-like APIs in Ruby.","fork":false,"url":"https://api.github.com/repos/intridea/grape","forks_url":"https://api.github.com/repos/intridea/grape/forks","keys_url":"https://api.github.com/repos/intridea/grape/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intridea/grape/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intridea/grape/teams","hooks_url":"https://api.github.com/repos/intridea/grape/hooks","issue_events_url":"https://api.github.com/repos/intridea/grape/issues/events{/number}","events_url":"https://api.github.com/repos/intridea/grape/events","assignees_url":"https://api.github.com/repos/intridea/grape/assignees{/user}","branches_url":"https://api.github.com/repos/intridea/grape/branches{/branch}","tags_url":"https://api.github.com/repos/intridea/grape/tags","blobs_url":"https://api.github.com/repos/intridea/grape/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intridea/grape/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intridea/grape/git/refs{/sha}","trees_url":"https://api.github.com/repos/intridea/grape/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intridea/grape/statuses/{sha}","languages_url":"https://api.github.com/repos/intridea/grape/languages","stargazers_url":"https://api.github.com/repos/intridea/grape/stargazers","contributors_url":"https://api.github.com/repos/intridea/grape/contributors","subscribers_url":"https://api.github.com/repos/intridea/grape/subscribers","subscription_url":"https://api.github.com/repos/intridea/grape/subscription","commits_url":"https://api.github.com/repos/intridea/grape/commits{/sha}","git_commits_url":"https://api.github.com/repos/intridea/grape/git/commits{/sha}","comments_url":"https://api.github.com/repos/intridea/grape/comments{/number}","issue_comment_url":"https://api.github.com/repos/intridea/grape/issues/comments{/number}","contents_url":"https://api.github.com/repos/intridea/grape/contents/{+path}","compare_url":"https://api.github.com/repos/intridea/grape/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intridea/grape/merges","archive_url":"https://api.github.com/repos/intridea/grape/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intridea/grape/downloads","issues_url":"https://api.github.com/repos/intridea/grape/issues{/number}","pulls_url":"https://api.github.com/repos/intridea/grape/pulls{/number}","milestones_url":"https://api.github.com/repos/intridea/grape/milestones{/number}","notifications_url":"https://api.github.com/repos/intridea/grape/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intridea/grape/labels{/name}","releases_url":"https://api.github.com/repos/intridea/grape/releases{/id}","created_at":"2010-08-02T14:25:08Z","updated_at":"2015-03-23T09:00:52Z","pushed_at":"2015-03-23T09:00:52Z","git_url":"git://github.com/intridea/grape.git","ssh_url":"git@github.com:intridea/grape.git","clone_url":"https://github.com/intridea/grape.git","svn_url":"https://github.com/intridea/grape","homepage":"http://intridea.github.io/grape","size":12154,"stargazers_count":5914,"watchers_count":5914,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":653,"mirror_url":null,"open_issues_count":89,"forks":653,"open_issues":89,"watchers":5914,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/intridea/grape/pulls/962"},"html":{"href":"https://github.com/intridea/grape/pull/962"},"issue":{"href":"https://api.github.com/repos/intridea/grape/issues/962"},"comments":{"href":"https://api.github.com/repos/intridea/grape/issues/962/comments"},"review_comments":{"href":"https://api.github.com/repos/intridea/grape/pulls/962/comments"},"review_comment":{"href":"https://api.github.com/repos/intridea/grape/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/intridea/grape/pulls/962/commits"},"statuses":{"href":"https://api.github.com/repos/intridea/grape/statuses/4e01f351206693840b5398dd1ab7c0f4e79d527e"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":7,"review_comments":2,"commits":1,"additions":65,"deletions":1,"changed_files":2}}