{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/8306","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/8306/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/8306/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/8306/events","html_url":"https://github.com/xbmc/xbmc/pull/8306","id":113667766,"number":8306,"title":"[Fix]jsonrpc getting consistent song and album artist data - names, IDs and MusicbrainzIDs","user":{"login":"DaveTBlake","id":13371422,"avatar_url":"https://avatars.githubusercontent.com/u/13371422?v=3","gravatar_id":"","url":"https://api.github.com/users/DaveTBlake","html_url":"https://github.com/DaveTBlake","followers_url":"https://api.github.com/users/DaveTBlake/followers","following_url":"https://api.github.com/users/DaveTBlake/following{/other_user}","gists_url":"https://api.github.com/users/DaveTBlake/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveTBlake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveTBlake/subscriptions","organizations_url":"https://api.github.com/users/DaveTBlake/orgs","repos_url":"https://api.github.com/users/DaveTBlake/repos","events_url":"https://api.github.com/users/DaveTBlake/events{/privacy}","received_events_url":"https://api.github.com/users/DaveTBlake/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/xbmc/xbmc/labels/Fix","name":"Fix","color":"0b02e1"},{"url":"https://api.github.com/repos/xbmc/xbmc/labels/JSON-RPC%20API%20Change","name":"JSON-RPC API Change","color":"e11d21"},{"url":"https://api.github.com/repos/xbmc/xbmc/labels/Music","name":"Music","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-27T19:48:52Z","updated_at":"2015-10-30T09:46:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/8306","html_url":"https://github.com/xbmc/xbmc/pull/8306","diff_url":"https://github.com/xbmc/xbmc/pull/8306.diff","patch_url":"https://github.com/xbmc/xbmc/pull/8306.patch"},"body":"This fixes the issue that JSON may in some circumstances return inconsistent artist name and ID arrays for song and albums. It also correctly provides Musicbrainz IDs, that would never have been working properly before.\r\n\r\nSince adding processing for ARTISTS tag #7486 it is possible that the splitting the artists string may not give the same artists as held in the song_artist or album_artist tables, so could lead to discrepencies. In particular `audioLibrary::GetAlbums` and `GetSongs` the array of artists for an album may not match the array of artistIds.  This was discussed under #8268 \r\n\r\nIt ensures that when JSON gets albums or songs the underlying query uses song_artist or album_artist tables to fully populate artist credits. Hence artist names and id arrays will be consistent. As a bonus now gets MBID (as a vector to match names and ids)\r\n\r\nIt bumps JSON version for now artist data returned is consistent.\r\n\r\nThis is a fix, not an improvement, but does make changes to underlying queries so could be considered major. I have deliberately avoided impacting the main music navigation SQL, but longer term we should be getting artist data from the song_artist table in more places.\r\n\r\nEven if it does not make Jarvis alpha since it is JSON related @Montellese I am hoping you can have a look at this before you are away for a month, and at least approve the approach. It needs some more testing with live data, so I am hoping a team member will build it so this can happen.\r\n\r\n@Tolriq see I did as I promised. Hope that you can test it with some Yatse data.\r\n@Razzeee and @evilhamster have a look please since it is music.\r\n"},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/152474880","html_url":"https://github.com/xbmc/xbmc/pull/8306#issuecomment-152474880","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/8306","id":152474880,"user":{"login":"ronie","id":687265,"avatar_url":"https://avatars.githubusercontent.com/u/687265?v=3","gravatar_id":"","url":"https://api.github.com/users/ronie","html_url":"https://github.com/ronie","followers_url":"https://api.github.com/users/ronie/followers","following_url":"https://api.github.com/users/ronie/following{/other_user}","gists_url":"https://api.github.com/users/ronie/gists{/gist_id}","starred_url":"https://api.github.com/users/ronie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronie/subscriptions","organizations_url":"https://api.github.com/users/ronie/orgs","repos_url":"https://api.github.com/users/ronie/repos","events_url":"https://api.github.com/users/ronie/events{/privacy}","received_events_url":"https://api.github.com/users/ronie/received_events","type":"User","site_admin":false},"created_at":"2015-10-30T09:46:56Z","updated_at":"2015-10-30T09:46:56Z","body":"will give it a spin in the next few days."}}