{"action":"created","issue":{"url":"https://api.github.com/repos/RetroShare/RetroShare/issues/118","labels_url":"https://api.github.com/repos/RetroShare/RetroShare/issues/118/labels{/name}","comments_url":"https://api.github.com/repos/RetroShare/RetroShare/issues/118/comments","events_url":"https://api.github.com/repos/RetroShare/RetroShare/issues/118/events","html_url":"https://github.com/RetroShare/RetroShare/issues/118","id":108904999,"number":118,"title":"Improve file search by ignoring diacritical marks","user":{"login":"guiweber","id":7825368,"avatar_url":"https://avatars.githubusercontent.com/u/7825368?v=3","gravatar_id":"","url":"https://api.github.com/users/guiweber","html_url":"https://github.com/guiweber","followers_url":"https://api.github.com/users/guiweber/followers","following_url":"https://api.github.com/users/guiweber/following{/other_user}","gists_url":"https://api.github.com/users/guiweber/gists{/gist_id}","starred_url":"https://api.github.com/users/guiweber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guiweber/subscriptions","organizations_url":"https://api.github.com/users/guiweber/orgs","repos_url":"https://api.github.com/users/guiweber/repos","events_url":"https://api.github.com/users/guiweber/events{/privacy}","received_events_url":"https://api.github.com/users/guiweber/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-29T16:18:39Z","updated_at":"2015-09-29T16:50:24Z","closed_at":null,"body":"When searching for files under File Tranfers, characters with diacritical marks such as accents, cedillas, umlauts and tildes (e.g. é, è, ê, ü, ç, ñ...) are treated as discrete characters. Treating these accented characters the same as the base characters would make searching easier.\r\n\r\nFor example, if I share a video of Björk with the accented \"ö\" in the file name and a someone searches for \"bjork\", he will get no results. It would be better if searching for \"o\" returned results for that letter with any possible diacritical mark. An option to only match the exact characters could be added to the advanced search options if necessary, in a way similar to the \"match case\" option.\r\n\r\nThere are several scenarios where people are unlikely to know the right diacritical marks to use (foreign artists for example). There are also situations when searching with the right diacritical marks may return no results, as some people omit them on purpose from their file names for compatibility or other reasons.\r\n\r\nThanks!"},"comment":{"url":"https://api.github.com/repos/RetroShare/RetroShare/issues/comments/144118057","html_url":"https://github.com/RetroShare/RetroShare/issues/118#issuecomment-144118057","issue_url":"https://api.github.com/repos/RetroShare/RetroShare/issues/118","id":144118057,"user":{"login":"csoler","id":329008,"avatar_url":"https://avatars.githubusercontent.com/u/329008?v=3","gravatar_id":"","url":"https://api.github.com/users/csoler","html_url":"https://github.com/csoler","followers_url":"https://api.github.com/users/csoler/followers","following_url":"https://api.github.com/users/csoler/following{/other_user}","gists_url":"https://api.github.com/users/csoler/gists{/gist_id}","starred_url":"https://api.github.com/users/csoler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csoler/subscriptions","organizations_url":"https://api.github.com/users/csoler/orgs","repos_url":"https://api.github.com/users/csoler/repos","events_url":"https://api.github.com/users/csoler/events{/privacy}","received_events_url":"https://api.github.com/users/csoler/received_events","type":"User","site_admin":false},"created_at":"2015-09-29T16:50:24Z","updated_at":"2015-09-29T16:50:24Z","body":"That has been suggested already. It needs a proper comparison function between strings in the code that select files from the shared lists. But it's going to raise the cost of handling file searches. "}}