{"action":"created","issue":{"url":"https://api.github.com/repos/ripple/rippled/issues/1029","labels_url":"https://api.github.com/repos/ripple/rippled/issues/1029/labels{/name}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/1029/comments","events_url":"https://api.github.com/repos/ripple/rippled/issues/1029/events","html_url":"https://github.com/ripple/rippled/pull/1029","id":72485050,"number":1029,"title":"Simplify InboundLedger expiration","user":{"login":"JoelKatz","id":877549,"avatar_url":"https://avatars.githubusercontent.com/u/877549?v=3","gravatar_id":"","url":"https://api.github.com/users/JoelKatz","html_url":"https://github.com/JoelKatz","followers_url":"https://api.github.com/users/JoelKatz/followers","following_url":"https://api.github.com/users/JoelKatz/following{/other_user}","gists_url":"https://api.github.com/users/JoelKatz/gists{/gist_id}","starred_url":"https://api.github.com/users/JoelKatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoelKatz/subscriptions","organizations_url":"https://api.github.com/users/JoelKatz/orgs","repos_url":"https://api.github.com/users/JoelKatz/repos","events_url":"https://api.github.com/users/JoelKatz/events{/privacy}","received_events_url":"https://api.github.com/users/JoelKatz/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ripple/rippled/labels/Ed","name":"Ed","color":"eeeeee"},{"url":"https://api.github.com/repos/ripple/rippled/labels/Howard","name":"Howard","color":"eeeeee"},{"url":"https://api.github.com/repos/ripple/rippled/labels/Mark","name":"Mark","color":"eeeeee"},{"url":"https://api.github.com/repos/ripple/rippled/labels/Mickey","name":"Mickey","color":"eeeeee"},{"url":"https://api.github.com/repos/ripple/rippled/labels/Nik","name":"Nik","color":"eeeeee"},{"url":"https://api.github.com/repos/ripple/rippled/labels/Passed","name":"Passed","color":"009800"},{"url":"https://api.github.com/repos/ripple/rippled/labels/Scott.D","name":"Scott.D","color":"eeeeee"},{"url":"https://api.github.com/repos/ripple/rippled/labels/Scott.S","name":"Scott.S","color":"eeeeee"},{"url":"https://api.github.com/repos/ripple/rippled/labels/Tom","name":"Tom","color":"eeeeee"},{"url":"https://api.github.com/repos/ripple/rippled/labels/Vinnie","name":"Vinnie","color":"eeeeee"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-05-01T18:01:12Z","updated_at":"2015-05-07T20:49:50Z","closed_at":"2015-05-06T21:52:41Z","pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/1029","html_url":"https://github.com/ripple/rippled/pull/1029","diff_url":"https://github.com/ripple/rippled/pull/1029.diff","patch_url":"https://github.com/ripple/rippled/pull/1029.patch"},"body":"This allows the sweep logic to remove \"stale\" inbound ledger requests, touching them if they're requested again. Also, the sequence of the inbound ledger object is updated if the request provides one and the old request didn't have one. This should produce more reasonable retention times for ledger requests, keeping current/validated requests around longer but still expiring stale requests if they build up.\r\n\r\nThis may result in slightly worse performance for connections with poor bandwith, allowing more inbound ledger requests to accumulate (about 18, worst case) when the server falls way behind. We will need all these ledgers eventually to catch up anyway."},"comment":{"url":"https://api.github.com/repos/ripple/rippled/issues/comments/100014929","html_url":"https://github.com/ripple/rippled/pull/1029#issuecomment-100014929","issue_url":"https://api.github.com/repos/ripple/rippled/issues/1029","id":100014929,"user":{"login":"ximinez","id":6757714,"avatar_url":"https://avatars.githubusercontent.com/u/6757714?v=3","gravatar_id":"","url":"https://api.github.com/users/ximinez","html_url":"https://github.com/ximinez","followers_url":"https://api.github.com/users/ximinez/followers","following_url":"https://api.github.com/users/ximinez/following{/other_user}","gists_url":"https://api.github.com/users/ximinez/gists{/gist_id}","starred_url":"https://api.github.com/users/ximinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximinez/subscriptions","organizations_url":"https://api.github.com/users/ximinez/orgs","repos_url":"https://api.github.com/users/ximinez/repos","events_url":"https://api.github.com/users/ximinez/events{/privacy}","received_events_url":"https://api.github.com/users/ximinez/received_events","type":"User","site_admin":false},"created_at":"2015-05-07T20:49:50Z","updated_at":"2015-05-07T20:49:50Z","body":"I know this PR is closed, but I took a look at it anyway. I have nothing to add. :+1: "}}