{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/25652037","id":25652037,"diff_hunk":"@@ -385,8 +386,8 @@ class SparkContext(config: SparkConf) extends Logging with ExecutorAllocationCli\n   // Optionally log Spark events\n   private[spark] val eventLogger: Option[EventLoggingListener] = {\n     if (isEventLogEnabled) {\n-      val logger =\n-        new EventLoggingListener(applicationId, eventLogDir.get, conf, hadoopConfiguration)\n+      val logger = new EventLoggingListener(\n+          applicationId, applicationAttemptId, eventLogDir.get, conf, hadoopConfiguration)","path":"core/src/main/scala/org/apache/spark/SparkContext.scala","position":15,"original_position":15,"commit_id":"cc9311e8d88bf2c03fe17cca0d2833ba836202ab","original_commit_id":"cc9311e8d88bf2c03fe17cca0d2833ba836202ab","user":{"login":"vanzin","id":1694083,"avatar_url":"https://avatars.githubusercontent.com/u/1694083?v=3","gravatar_id":"","url":"https://api.github.com/users/vanzin","html_url":"https://github.com/vanzin","followers_url":"https://api.github.com/users/vanzin/followers","following_url":"https://api.github.com/users/vanzin/following{/other_user}","gists_url":"https://api.github.com/users/vanzin/gists{/gist_id}","starred_url":"https://api.github.com/users/vanzin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanzin/subscriptions","organizations_url":"https://api.github.com/users/vanzin/orgs","repos_url":"https://api.github.com/users/vanzin/repos","events_url":"https://api.github.com/users/vanzin/events{/privacy}","received_events_url":"https://api.github.com/users/vanzin/received_events","type":"User","site_admin":false},"body":"nit: indented too far","created_at":"2015-03-03T00:06:27Z","updated_at":"2015-03-03T00:06:27Z","html_url":"https://github.com/apache/spark/pull/4845#discussion_r25652037","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/4845","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/25652037"},"html":{"href":"https://github.com/apache/spark/pull/4845#discussion_r25652037"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/4845"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/4845","id":30243305,"html_url":"https://github.com/apache/spark/pull/4845","diff_url":"https://github.com/apache/spark/pull/4845.diff","patch_url":"https://github.com/apache/spark/pull/4845.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/4845","number":4845,"state":"open","locked":false,"title":"SPARK-4705:[ For Cluster mode ] Pull request for being able to retain the event logs for all the application attempts. Currently they need to be overridden using  property \"spark.eventLog.overwrite\"","user":{"login":"twinkle-sachdeva","id":7300226,"avatar_url":"https://avatars.githubusercontent.com/u/7300226?v=3","gravatar_id":"","url":"https://api.github.com/users/twinkle-sachdeva","html_url":"https://github.com/twinkle-sachdeva","followers_url":"https://api.github.com/users/twinkle-sachdeva/followers","following_url":"https://api.github.com/users/twinkle-sachdeva/following{/other_user}","gists_url":"https://api.github.com/users/twinkle-sachdeva/gists{/gist_id}","starred_url":"https://api.github.com/users/twinkle-sachdeva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twinkle-sachdeva/subscriptions","organizations_url":"https://api.github.com/users/twinkle-sachdeva/orgs","repos_url":"https://api.github.com/users/twinkle-sachdeva/repos","events_url":"https://api.github.com/users/twinkle-sachdeva/events{/privacy}","received_events_url":"https://api.github.com/users/twinkle-sachdeva/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nFollowing is the approach taken:\r\n1. For applications with attempt ID,\" _<attempt_id>\" has been added to file name, while creating the event log file. For example, with attempt id file name will be : application_1423546284151_0031_2\r\n\r\n2. Added the attempt id inside the SparkListenerApplicationStart event, so that same can be read while replaying the event log file too.\r\n\r\n3. If there is no application with attempt id info (e.g. all played in client mode ), then old UI will continue to display, as an application with attempt id has been logged, then following new UI will start appearing \r\n \r\n![updated ui - ii](https://cloud.githubusercontent.com/assets/7300226/6431362/9387c7be-c053-11e4-9ea9-127d637e3a45.png)\r\n\r\n","created_at":"2015-03-01T15:15:23Z","updated_at":"2015-03-03T00:06:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a70d0cf6e72ad157539717133a5619a3320eee28","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/4845/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/4845/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/4845/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/cc9311e8d88bf2c03fe17cca0d2833ba836202ab","head":{"label":"twinkle-sachdeva:SPARK-4705-Master","ref":"SPARK-4705-Master","sha":"cc9311e8d88bf2c03fe17cca0d2833ba836202ab","user":{"login":"twinkle-sachdeva","id":7300226,"avatar_url":"https://avatars.githubusercontent.com/u/7300226?v=3","gravatar_id":"","url":"https://api.github.com/users/twinkle-sachdeva","html_url":"https://github.com/twinkle-sachdeva","followers_url":"https://api.github.com/users/twinkle-sachdeva/followers","following_url":"https://api.github.com/users/twinkle-sachdeva/following{/other_user}","gists_url":"https://api.github.com/users/twinkle-sachdeva/gists{/gist_id}","starred_url":"https://api.github.com/users/twinkle-sachdeva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twinkle-sachdeva/subscriptions","organizations_url":"https://api.github.com/users/twinkle-sachdeva/orgs","repos_url":"https://api.github.com/users/twinkle-sachdeva/repos","events_url":"https://api.github.com/users/twinkle-sachdeva/events{/privacy}","received_events_url":"https://api.github.com/users/twinkle-sachdeva/received_events","type":"User","site_admin":false},"repo":{"id":22202179,"name":"spark","full_name":"twinkle-sachdeva/spark","owner":{"login":"twinkle-sachdeva","id":7300226,"avatar_url":"https://avatars.githubusercontent.com/u/7300226?v=3","gravatar_id":"","url":"https://api.github.com/users/twinkle-sachdeva","html_url":"https://github.com/twinkle-sachdeva","followers_url":"https://api.github.com/users/twinkle-sachdeva/followers","following_url":"https://api.github.com/users/twinkle-sachdeva/following{/other_user}","gists_url":"https://api.github.com/users/twinkle-sachdeva/gists{/gist_id}","starred_url":"https://api.github.com/users/twinkle-sachdeva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twinkle-sachdeva/subscriptions","organizations_url":"https://api.github.com/users/twinkle-sachdeva/orgs","repos_url":"https://api.github.com/users/twinkle-sachdeva/repos","events_url":"https://api.github.com/users/twinkle-sachdeva/events{/privacy}","received_events_url":"https://api.github.com/users/twinkle-sachdeva/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/twinkle-sachdeva/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/twinkle-sachdeva/spark","forks_url":"https://api.github.com/repos/twinkle-sachdeva/spark/forks","keys_url":"https://api.github.com/repos/twinkle-sachdeva/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twinkle-sachdeva/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twinkle-sachdeva/spark/teams","hooks_url":"https://api.github.com/repos/twinkle-sachdeva/spark/hooks","issue_events_url":"https://api.github.com/repos/twinkle-sachdeva/spark/issues/events{/number}","events_url":"https://api.github.com/repos/twinkle-sachdeva/spark/events","assignees_url":"https://api.github.com/repos/twinkle-sachdeva/spark/assignees{/user}","branches_url":"https://api.github.com/repos/twinkle-sachdeva/spark/branches{/branch}","tags_url":"https://api.github.com/repos/twinkle-sachdeva/spark/tags","blobs_url":"https://api.github.com/repos/twinkle-sachdeva/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twinkle-sachdeva/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twinkle-sachdeva/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/twinkle-sachdeva/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twinkle-sachdeva/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/twinkle-sachdeva/spark/languages","stargazers_url":"https://api.github.com/repos/twinkle-sachdeva/spark/stargazers","contributors_url":"https://api.github.com/repos/twinkle-sachdeva/spark/contributors","subscribers_url":"https://api.github.com/repos/twinkle-sachdeva/spark/subscribers","subscription_url":"https://api.github.com/repos/twinkle-sachdeva/spark/subscription","commits_url":"https://api.github.com/repos/twinkle-sachdeva/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/twinkle-sachdeva/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/twinkle-sachdeva/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/twinkle-sachdeva/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/twinkle-sachdeva/spark/contents/{+path}","compare_url":"https://api.github.com/repos/twinkle-sachdeva/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twinkle-sachdeva/spark/merges","archive_url":"https://api.github.com/repos/twinkle-sachdeva/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twinkle-sachdeva/spark/downloads","issues_url":"https://api.github.com/repos/twinkle-sachdeva/spark/issues{/number}","pulls_url":"https://api.github.com/repos/twinkle-sachdeva/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/twinkle-sachdeva/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/twinkle-sachdeva/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twinkle-sachdeva/spark/labels{/name}","releases_url":"https://api.github.com/repos/twinkle-sachdeva/spark/releases{/id}","created_at":"2014-07-24T06:46:45Z","updated_at":"2014-07-24T10:12:43Z","pushed_at":"2015-03-02T08:30:10Z","git_url":"git://github.com/twinkle-sachdeva/spark.git","ssh_url":"git@github.com:twinkle-sachdeva/spark.git","clone_url":"https://github.com/twinkle-sachdeva/spark.git","svn_url":"https://github.com/twinkle-sachdeva/spark","homepage":null,"size":90784,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"3f00bb3ef1384fabf86a68180d40a1a515f6f5e3","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-03-02T23:34:25Z","pushed_at":"2015-03-02T23:34:24Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1337721,"stargazers_count":3048,"watchers_count":3048,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2638,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":263,"forks":2638,"open_issues":263,"watchers":3048,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/4845"},"html":{"href":"https://github.com/apache/spark/pull/4845"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/4845"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/4845/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/4845/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/4845/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/cc9311e8d88bf2c03fe17cca0d2833ba836202ab"}}}}