{"action":"closed","number":58,"pull_request":{"url":"https://api.github.com/repos/HubSpot/drop/pulls/58","id":31001420,"html_url":"https://github.com/HubSpot/drop/pull/58","diff_url":"https://github.com/HubSpot/drop/pull/58.diff","patch_url":"https://github.com/HubSpot/drop/pull/58.patch","issue_url":"https://api.github.com/repos/HubSpot/drop/issues/58","number":58,"state":"closed","locked":false,"title":"the after-open setTimeout is now more resilient to synchronous testing","user":{"login":"SohumB","id":66472,"avatar_url":"https://avatars.githubusercontent.com/u/66472?v=3","gravatar_id":"","url":"https://api.github.com/users/SohumB","html_url":"https://github.com/SohumB","followers_url":"https://api.github.com/users/SohumB/followers","following_url":"https://api.github.com/users/SohumB/following{/other_user}","gists_url":"https://api.github.com/users/SohumB/gists{/gist_id}","starred_url":"https://api.github.com/users/SohumB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SohumB/subscriptions","organizations_url":"https://api.github.com/users/SohumB/orgs","repos_url":"https://api.github.com/users/SohumB/repos","events_url":"https://api.github.com/users/SohumB/events{/privacy}","received_events_url":"https://api.github.com/users/SohumB/received_events","type":"User","site_admin":false},"body":"We were running into issues in automated testing of drop, where we synchronously run a lot of events that open and close drop instances. This makes the case we kept hitting go away, and is probably(?) what drop should be doing anyway. ","created_at":"2015-03-12T01:29:14Z","updated_at":"2015-05-23T07:06:54Z","closed_at":"2015-05-23T07:06:54Z","merged_at":null,"merge_commit_sha":"cc652b8230562779dd24b1ba898b3f773fb4f453","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HubSpot/drop/pulls/58/commits","review_comments_url":"https://api.github.com/repos/HubSpot/drop/pulls/58/comments","review_comment_url":"https://api.github.com/repos/HubSpot/drop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HubSpot/drop/issues/58/comments","statuses_url":"https://api.github.com/repos/HubSpot/drop/statuses/5a41be33c8e8cd8cec885c1dd8b2716ac9adfda7","head":{"label":"franq:bugfix/setTimeout-resilience","ref":"bugfix/setTimeout-resilience","sha":"5a41be33c8e8cd8cec885c1dd8b2716ac9adfda7","user":{"login":"franq","id":6486420,"avatar_url":"https://avatars.githubusercontent.com/u/6486420?v=3","gravatar_id":"","url":"https://api.github.com/users/franq","html_url":"https://github.com/franq","followers_url":"https://api.github.com/users/franq/followers","following_url":"https://api.github.com/users/franq/following{/other_user}","gists_url":"https://api.github.com/users/franq/gists{/gist_id}","starred_url":"https://api.github.com/users/franq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franq/subscriptions","organizations_url":"https://api.github.com/users/franq/orgs","repos_url":"https://api.github.com/users/franq/repos","events_url":"https://api.github.com/users/franq/events{/privacy}","received_events_url":"https://api.github.com/users/franq/received_events","type":"Organization","site_admin":false},"repo":{"id":32049994,"name":"drop","full_name":"franq/drop","owner":{"login":"franq","id":6486420,"avatar_url":"https://avatars.githubusercontent.com/u/6486420?v=3","gravatar_id":"","url":"https://api.github.com/users/franq","html_url":"https://github.com/franq","followers_url":"https://api.github.com/users/franq/followers","following_url":"https://api.github.com/users/franq/following{/other_user}","gists_url":"https://api.github.com/users/franq/gists{/gist_id}","starred_url":"https://api.github.com/users/franq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franq/subscriptions","organizations_url":"https://api.github.com/users/franq/orgs","repos_url":"https://api.github.com/users/franq/repos","events_url":"https://api.github.com/users/franq/events{/privacy}","received_events_url":"https://api.github.com/users/franq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/franq/drop","description":"A library for creating dropdowns and other floating elements. #hubspot-open-source","fork":true,"url":"https://api.github.com/repos/franq/drop","forks_url":"https://api.github.com/repos/franq/drop/forks","keys_url":"https://api.github.com/repos/franq/drop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/franq/drop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/franq/drop/teams","hooks_url":"https://api.github.com/repos/franq/drop/hooks","issue_events_url":"https://api.github.com/repos/franq/drop/issues/events{/number}","events_url":"https://api.github.com/repos/franq/drop/events","assignees_url":"https://api.github.com/repos/franq/drop/assignees{/user}","branches_url":"https://api.github.com/repos/franq/drop/branches{/branch}","tags_url":"https://api.github.com/repos/franq/drop/tags","blobs_url":"https://api.github.com/repos/franq/drop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/franq/drop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/franq/drop/git/refs{/sha}","trees_url":"https://api.github.com/repos/franq/drop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/franq/drop/statuses/{sha}","languages_url":"https://api.github.com/repos/franq/drop/languages","stargazers_url":"https://api.github.com/repos/franq/drop/stargazers","contributors_url":"https://api.github.com/repos/franq/drop/contributors","subscribers_url":"https://api.github.com/repos/franq/drop/subscribers","subscription_url":"https://api.github.com/repos/franq/drop/subscription","commits_url":"https://api.github.com/repos/franq/drop/commits{/sha}","git_commits_url":"https://api.github.com/repos/franq/drop/git/commits{/sha}","comments_url":"https://api.github.com/repos/franq/drop/comments{/number}","issue_comment_url":"https://api.github.com/repos/franq/drop/issues/comments{/number}","contents_url":"https://api.github.com/repos/franq/drop/contents/{+path}","compare_url":"https://api.github.com/repos/franq/drop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/franq/drop/merges","archive_url":"https://api.github.com/repos/franq/drop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/franq/drop/downloads","issues_url":"https://api.github.com/repos/franq/drop/issues{/number}","pulls_url":"https://api.github.com/repos/franq/drop/pulls{/number}","milestones_url":"https://api.github.com/repos/franq/drop/milestones{/number}","notifications_url":"https://api.github.com/repos/franq/drop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/franq/drop/labels{/name}","releases_url":"https://api.github.com/repos/franq/drop/releases{/id}","created_at":"2015-03-12T01:15:35Z","updated_at":"2015-03-12T01:44:07Z","pushed_at":"2015-03-12T01:44:07Z","git_url":"git://github.com/franq/drop.git","ssh_url":"git@github.com:franq/drop.git","clone_url":"https://github.com/franq/drop.git","svn_url":"https://github.com/franq/drop","homepage":"http://github.hubspot.com/drop/docs/welcome","size":1066,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HubSpot:master","ref":"master","sha":"95a610dcb2e14c95249a31ee89802ff91cc5384d","user":{"login":"HubSpot","id":326419,"avatar_url":"https://avatars.githubusercontent.com/u/326419?v=3","gravatar_id":"","url":"https://api.github.com/users/HubSpot","html_url":"https://github.com/HubSpot","followers_url":"https://api.github.com/users/HubSpot/followers","following_url":"https://api.github.com/users/HubSpot/following{/other_user}","gists_url":"https://api.github.com/users/HubSpot/gists{/gist_id}","starred_url":"https://api.github.com/users/HubSpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubSpot/subscriptions","organizations_url":"https://api.github.com/users/HubSpot/orgs","repos_url":"https://api.github.com/users/HubSpot/repos","events_url":"https://api.github.com/users/HubSpot/events{/privacy}","received_events_url":"https://api.github.com/users/HubSpot/received_events","type":"Organization","site_admin":false},"repo":{"id":15153572,"name":"drop","full_name":"HubSpot/drop","owner":{"login":"HubSpot","id":326419,"avatar_url":"https://avatars.githubusercontent.com/u/326419?v=3","gravatar_id":"","url":"https://api.github.com/users/HubSpot","html_url":"https://github.com/HubSpot","followers_url":"https://api.github.com/users/HubSpot/followers","following_url":"https://api.github.com/users/HubSpot/following{/other_user}","gists_url":"https://api.github.com/users/HubSpot/gists{/gist_id}","starred_url":"https://api.github.com/users/HubSpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubSpot/subscriptions","organizations_url":"https://api.github.com/users/HubSpot/orgs","repos_url":"https://api.github.com/users/HubSpot/repos","events_url":"https://api.github.com/users/HubSpot/events{/privacy}","received_events_url":"https://api.github.com/users/HubSpot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HubSpot/drop","description":"A library for creating dropdowns and other floating elements. #hubspot-open-source","fork":false,"url":"https://api.github.com/repos/HubSpot/drop","forks_url":"https://api.github.com/repos/HubSpot/drop/forks","keys_url":"https://api.github.com/repos/HubSpot/drop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HubSpot/drop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HubSpot/drop/teams","hooks_url":"https://api.github.com/repos/HubSpot/drop/hooks","issue_events_url":"https://api.github.com/repos/HubSpot/drop/issues/events{/number}","events_url":"https://api.github.com/repos/HubSpot/drop/events","assignees_url":"https://api.github.com/repos/HubSpot/drop/assignees{/user}","branches_url":"https://api.github.com/repos/HubSpot/drop/branches{/branch}","tags_url":"https://api.github.com/repos/HubSpot/drop/tags","blobs_url":"https://api.github.com/repos/HubSpot/drop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HubSpot/drop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HubSpot/drop/git/refs{/sha}","trees_url":"https://api.github.com/repos/HubSpot/drop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HubSpot/drop/statuses/{sha}","languages_url":"https://api.github.com/repos/HubSpot/drop/languages","stargazers_url":"https://api.github.com/repos/HubSpot/drop/stargazers","contributors_url":"https://api.github.com/repos/HubSpot/drop/contributors","subscribers_url":"https://api.github.com/repos/HubSpot/drop/subscribers","subscription_url":"https://api.github.com/repos/HubSpot/drop/subscription","commits_url":"https://api.github.com/repos/HubSpot/drop/commits{/sha}","git_commits_url":"https://api.github.com/repos/HubSpot/drop/git/commits{/sha}","comments_url":"https://api.github.com/repos/HubSpot/drop/comments{/number}","issue_comment_url":"https://api.github.com/repos/HubSpot/drop/issues/comments{/number}","contents_url":"https://api.github.com/repos/HubSpot/drop/contents/{+path}","compare_url":"https://api.github.com/repos/HubSpot/drop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HubSpot/drop/merges","archive_url":"https://api.github.com/repos/HubSpot/drop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HubSpot/drop/downloads","issues_url":"https://api.github.com/repos/HubSpot/drop/issues{/number}","pulls_url":"https://api.github.com/repos/HubSpot/drop/pulls{/number}","milestones_url":"https://api.github.com/repos/HubSpot/drop/milestones{/number}","notifications_url":"https://api.github.com/repos/HubSpot/drop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HubSpot/drop/labels{/name}","releases_url":"https://api.github.com/repos/HubSpot/drop/releases{/id}","created_at":"2013-12-13T03:03:52Z","updated_at":"2015-05-22T08:27:32Z","pushed_at":"2015-05-23T07:06:28Z","git_url":"git://github.com/HubSpot/drop.git","ssh_url":"git@github.com:HubSpot/drop.git","clone_url":"https://github.com/HubSpot/drop.git","svn_url":"https://github.com/HubSpot/drop","homepage":"http://github.hubspot.com/drop/docs/welcome","size":2463,"stargazers_count":925,"watchers_count":925,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":86,"mirror_url":null,"open_issues_count":5,"forks":86,"open_issues":5,"watchers":925,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HubSpot/drop/pulls/58"},"html":{"href":"https://github.com/HubSpot/drop/pull/58"},"issue":{"href":"https://api.github.com/repos/HubSpot/drop/issues/58"},"comments":{"href":"https://api.github.com/repos/HubSpot/drop/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/HubSpot/drop/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/HubSpot/drop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HubSpot/drop/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/HubSpot/drop/statuses/5a41be33c8e8cd8cec885c1dd8b2716ac9adfda7"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":4,"review_comments":0,"commits":1,"additions":12,"deletions":4,"changed_files":4}}