{"action":"opened","number":69,"pull_request":{"url":"https://api.github.com/repos/asaskevich/govalidator/pulls/69","id":39650631,"html_url":"https://github.com/asaskevich/govalidator/pull/69","diff_url":"https://github.com/asaskevich/govalidator/pull/69.diff","patch_url":"https://github.com/asaskevich/govalidator/pull/69.patch","issue_url":"https://api.github.com/repos/asaskevich/govalidator/issues/69","number":69,"state":"open","locked":false,"title":"Added some extra fields to TestIsURL","user":{"login":"nathj07","id":3279761,"avatar_url":"https://avatars.githubusercontent.com/u/3279761?v=3","gravatar_id":"","url":"https://api.github.com/users/nathj07","html_url":"https://github.com/nathj07","followers_url":"https://api.github.com/users/nathj07/followers","following_url":"https://api.github.com/users/nathj07/following{/other_user}","gists_url":"https://api.github.com/users/nathj07/gists{/gist_id}","starred_url":"https://api.github.com/users/nathj07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathj07/subscriptions","organizations_url":"https://api.github.com/users/nathj07/orgs","repos_url":"https://api.github.com/users/nathj07/repos","events_url":"https://api.github.com/users/nathj07/events{/privacy}","received_events_url":"https://api.github.com/users/nathj07/received_events","type":"User","site_admin":false},"body":"The fields added to the test are based on values I've seen in URLs in the wild that are not valid. It turns out these extra cases were already handled correctly. \r\n\r\nHowever, I think that adding the tests makes it explicit that these cases are catered for.","created_at":"2015-07-10T04:07:33Z","updated_at":"2015-07-10T04:07:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/asaskevich/govalidator/pulls/69/commits","review_comments_url":"https://api.github.com/repos/asaskevich/govalidator/pulls/69/comments","review_comment_url":"https://api.github.com/repos/asaskevich/govalidator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/asaskevich/govalidator/issues/69/comments","statuses_url":"https://api.github.com/repos/asaskevich/govalidator/statuses/2a25508c3eef560c14d774a4a47b15594779c25d","head":{"label":"nathj07:extra_tests_isURL","ref":"extra_tests_isURL","sha":"2a25508c3eef560c14d774a4a47b15594779c25d","user":{"login":"nathj07","id":3279761,"avatar_url":"https://avatars.githubusercontent.com/u/3279761?v=3","gravatar_id":"","url":"https://api.github.com/users/nathj07","html_url":"https://github.com/nathj07","followers_url":"https://api.github.com/users/nathj07/followers","following_url":"https://api.github.com/users/nathj07/following{/other_user}","gists_url":"https://api.github.com/users/nathj07/gists{/gist_id}","starred_url":"https://api.github.com/users/nathj07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathj07/subscriptions","organizations_url":"https://api.github.com/users/nathj07/orgs","repos_url":"https://api.github.com/users/nathj07/repos","events_url":"https://api.github.com/users/nathj07/events{/privacy}","received_events_url":"https://api.github.com/users/nathj07/received_events","type":"User","site_admin":false},"repo":{"id":29688756,"name":"govalidator","full_name":"nathj07/govalidator","owner":{"login":"nathj07","id":3279761,"avatar_url":"https://avatars.githubusercontent.com/u/3279761?v=3","gravatar_id":"","url":"https://api.github.com/users/nathj07","html_url":"https://github.com/nathj07","followers_url":"https://api.github.com/users/nathj07/followers","following_url":"https://api.github.com/users/nathj07/following{/other_user}","gists_url":"https://api.github.com/users/nathj07/gists{/gist_id}","starred_url":"https://api.github.com/users/nathj07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathj07/subscriptions","organizations_url":"https://api.github.com/users/nathj07/orgs","repos_url":"https://api.github.com/users/nathj07/repos","events_url":"https://api.github.com/users/nathj07/events{/privacy}","received_events_url":"https://api.github.com/users/nathj07/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nathj07/govalidator","description":"[Go] Package of string validators and sanitizers for Go lang.","fork":true,"url":"https://api.github.com/repos/nathj07/govalidator","forks_url":"https://api.github.com/repos/nathj07/govalidator/forks","keys_url":"https://api.github.com/repos/nathj07/govalidator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nathj07/govalidator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nathj07/govalidator/teams","hooks_url":"https://api.github.com/repos/nathj07/govalidator/hooks","issue_events_url":"https://api.github.com/repos/nathj07/govalidator/issues/events{/number}","events_url":"https://api.github.com/repos/nathj07/govalidator/events","assignees_url":"https://api.github.com/repos/nathj07/govalidator/assignees{/user}","branches_url":"https://api.github.com/repos/nathj07/govalidator/branches{/branch}","tags_url":"https://api.github.com/repos/nathj07/govalidator/tags","blobs_url":"https://api.github.com/repos/nathj07/govalidator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nathj07/govalidator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nathj07/govalidator/git/refs{/sha}","trees_url":"https://api.github.com/repos/nathj07/govalidator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nathj07/govalidator/statuses/{sha}","languages_url":"https://api.github.com/repos/nathj07/govalidator/languages","stargazers_url":"https://api.github.com/repos/nathj07/govalidator/stargazers","contributors_url":"https://api.github.com/repos/nathj07/govalidator/contributors","subscribers_url":"https://api.github.com/repos/nathj07/govalidator/subscribers","subscription_url":"https://api.github.com/repos/nathj07/govalidator/subscription","commits_url":"https://api.github.com/repos/nathj07/govalidator/commits{/sha}","git_commits_url":"https://api.github.com/repos/nathj07/govalidator/git/commits{/sha}","comments_url":"https://api.github.com/repos/nathj07/govalidator/comments{/number}","issue_comment_url":"https://api.github.com/repos/nathj07/govalidator/issues/comments{/number}","contents_url":"https://api.github.com/repos/nathj07/govalidator/contents/{+path}","compare_url":"https://api.github.com/repos/nathj07/govalidator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nathj07/govalidator/merges","archive_url":"https://api.github.com/repos/nathj07/govalidator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nathj07/govalidator/downloads","issues_url":"https://api.github.com/repos/nathj07/govalidator/issues{/number}","pulls_url":"https://api.github.com/repos/nathj07/govalidator/pulls{/number}","milestones_url":"https://api.github.com/repos/nathj07/govalidator/milestones{/number}","notifications_url":"https://api.github.com/repos/nathj07/govalidator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nathj07/govalidator/labels{/name}","releases_url":"https://api.github.com/repos/nathj07/govalidator/releases{/id}","created_at":"2015-01-22T16:42:45Z","updated_at":"2015-01-25T17:01:29Z","pushed_at":"2015-07-10T04:07:02Z","git_url":"git://github.com/nathj07/govalidator.git","ssh_url":"git@github.com:nathj07/govalidator.git","clone_url":"https://github.com/nathj07/govalidator.git","svn_url":"https://github.com/nathj07/govalidator","homepage":"","size":261,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"asaskevich:master","ref":"master","sha":"dd82d520f7795e8da1cfde36b17b2f7283f74fff","user":{"login":"asaskevich","id":5049590,"avatar_url":"https://avatars.githubusercontent.com/u/5049590?v=3","gravatar_id":"","url":"https://api.github.com/users/asaskevich","html_url":"https://github.com/asaskevich","followers_url":"https://api.github.com/users/asaskevich/followers","following_url":"https://api.github.com/users/asaskevich/following{/other_user}","gists_url":"https://api.github.com/users/asaskevich/gists{/gist_id}","starred_url":"https://api.github.com/users/asaskevich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asaskevich/subscriptions","organizations_url":"https://api.github.com/users/asaskevich/orgs","repos_url":"https://api.github.com/users/asaskevich/repos","events_url":"https://api.github.com/users/asaskevich/events{/privacy}","received_events_url":"https://api.github.com/users/asaskevich/received_events","type":"User","site_admin":false},"repo":{"id":21034555,"name":"govalidator","full_name":"asaskevich/govalidator","owner":{"login":"asaskevich","id":5049590,"avatar_url":"https://avatars.githubusercontent.com/u/5049590?v=3","gravatar_id":"","url":"https://api.github.com/users/asaskevich","html_url":"https://github.com/asaskevich","followers_url":"https://api.github.com/users/asaskevich/followers","following_url":"https://api.github.com/users/asaskevich/following{/other_user}","gists_url":"https://api.github.com/users/asaskevich/gists{/gist_id}","starred_url":"https://api.github.com/users/asaskevich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asaskevich/subscriptions","organizations_url":"https://api.github.com/users/asaskevich/orgs","repos_url":"https://api.github.com/users/asaskevich/repos","events_url":"https://api.github.com/users/asaskevich/events{/privacy}","received_events_url":"https://api.github.com/users/asaskevich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asaskevich/govalidator","description":"[Go] Package of string validators and sanitizers for Go lang.","fork":false,"url":"https://api.github.com/repos/asaskevich/govalidator","forks_url":"https://api.github.com/repos/asaskevich/govalidator/forks","keys_url":"https://api.github.com/repos/asaskevich/govalidator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asaskevich/govalidator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asaskevich/govalidator/teams","hooks_url":"https://api.github.com/repos/asaskevich/govalidator/hooks","issue_events_url":"https://api.github.com/repos/asaskevich/govalidator/issues/events{/number}","events_url":"https://api.github.com/repos/asaskevich/govalidator/events","assignees_url":"https://api.github.com/repos/asaskevich/govalidator/assignees{/user}","branches_url":"https://api.github.com/repos/asaskevich/govalidator/branches{/branch}","tags_url":"https://api.github.com/repos/asaskevich/govalidator/tags","blobs_url":"https://api.github.com/repos/asaskevich/govalidator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asaskevich/govalidator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asaskevich/govalidator/git/refs{/sha}","trees_url":"https://api.github.com/repos/asaskevich/govalidator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asaskevich/govalidator/statuses/{sha}","languages_url":"https://api.github.com/repos/asaskevich/govalidator/languages","stargazers_url":"https://api.github.com/repos/asaskevich/govalidator/stargazers","contributors_url":"https://api.github.com/repos/asaskevich/govalidator/contributors","subscribers_url":"https://api.github.com/repos/asaskevich/govalidator/subscribers","subscription_url":"https://api.github.com/repos/asaskevich/govalidator/subscription","commits_url":"https://api.github.com/repos/asaskevich/govalidator/commits{/sha}","git_commits_url":"https://api.github.com/repos/asaskevich/govalidator/git/commits{/sha}","comments_url":"https://api.github.com/repos/asaskevich/govalidator/comments{/number}","issue_comment_url":"https://api.github.com/repos/asaskevich/govalidator/issues/comments{/number}","contents_url":"https://api.github.com/repos/asaskevich/govalidator/contents/{+path}","compare_url":"https://api.github.com/repos/asaskevich/govalidator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asaskevich/govalidator/merges","archive_url":"https://api.github.com/repos/asaskevich/govalidator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asaskevich/govalidator/downloads","issues_url":"https://api.github.com/repos/asaskevich/govalidator/issues{/number}","pulls_url":"https://api.github.com/repos/asaskevich/govalidator/pulls{/number}","milestones_url":"https://api.github.com/repos/asaskevich/govalidator/milestones{/number}","notifications_url":"https://api.github.com/repos/asaskevich/govalidator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asaskevich/govalidator/labels{/name}","releases_url":"https://api.github.com/repos/asaskevich/govalidator/releases{/id}","created_at":"2014-06-20T10:45:23Z","updated_at":"2015-07-10T03:35:36Z","pushed_at":"2015-07-05T10:42:05Z","git_url":"git://github.com/asaskevich/govalidator.git","ssh_url":"git@github.com:asaskevich/govalidator.git","clone_url":"https://github.com/asaskevich/govalidator.git","svn_url":"https://github.com/asaskevich/govalidator","homepage":"","size":778,"stargazers_count":474,"watchers_count":474,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":12,"forks":42,"open_issues":12,"watchers":474,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/asaskevich/govalidator/pulls/69"},"html":{"href":"https://github.com/asaskevich/govalidator/pull/69"},"issue":{"href":"https://api.github.com/repos/asaskevich/govalidator/issues/69"},"comments":{"href":"https://api.github.com/repos/asaskevich/govalidator/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/asaskevich/govalidator/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/asaskevich/govalidator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/asaskevich/govalidator/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/asaskevich/govalidator/statuses/2a25508c3eef560c14d774a4a47b15594779c25d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":0,"changed_files":1}}