{"action":"closed","number":3,"pull_request":{"url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/pulls/3","id":33080463,"html_url":"https://github.com/JeremyHeleine/Photo-Sphere-Viewer/pull/3","diff_url":"https://github.com/JeremyHeleine/Photo-Sphere-Viewer/pull/3.diff","patch_url":"https://github.com/JeremyHeleine/Photo-Sphere-Viewer/pull/3.patch","issue_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/issues/3","number":3,"state":"closed","locked":false,"title":"prototyped, AMD loader, Grunt task","user":{"login":"mistic100","id":41597,"avatar_url":"https://avatars.githubusercontent.com/u/41597?v=3","gravatar_id":"","url":"https://api.github.com/users/mistic100","html_url":"https://github.com/mistic100","followers_url":"https://api.github.com/users/mistic100/followers","following_url":"https://api.github.com/users/mistic100/following{/other_user}","gists_url":"https://api.github.com/users/mistic100/gists{/gist_id}","starred_url":"https://api.github.com/users/mistic100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mistic100/subscriptions","organizations_url":"https://api.github.com/users/mistic100/orgs","repos_url":"https://api.github.com/users/mistic100/repos","events_url":"https://api.github.com/users/mistic100/events{/privacy}","received_events_url":"https://api.github.com/users/mistic100/received_events","type":"User","site_admin":false},"body":"I know the diff is absolutely ugly :-)\r\n\r\nWhat I did:\r\n * switch to prototyped objects, all methods are now public\r\n * separate the 3 buttons in 3 separated classes\r\n * use KyleAMathews/deepmerge (included) for configuration load\r\n * move generic static methods to PSVUtils\r\n * add AMD (RequireJS) loader\r\n * add Grunt task (concat and minify)\r\n * JSHint compliant\r\n * removed some type checks and color format checks (that's really a personal preference, I tend to assume developers know what's going on, I generally only check user inputs and complex configuration objects)\r\n\r\nnothing changed functionally (these will come in other PRs !)\r\n\r\n(that's quite big changes I'll understand you refuse it of course)","created_at":"2015-04-10T20:26:14Z","updated_at":"2015-12-07T19:35:10Z","closed_at":"2015-12-07T19:35:10Z","merged_at":null,"merge_commit_sha":"195f12d8cb7b878799036729ec5c1a2926a8a470","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/pulls/3/commits","review_comments_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/pulls/3/comments","review_comment_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/issues/3/comments","statuses_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/statuses/1a9b6aacd91e225fae243e03b3920d3dd6f0fcb9","head":{"label":"mistic100:prototyped","ref":"prototyped","sha":"1a9b6aacd91e225fae243e03b3920d3dd6f0fcb9","user":{"login":"mistic100","id":41597,"avatar_url":"https://avatars.githubusercontent.com/u/41597?v=3","gravatar_id":"","url":"https://api.github.com/users/mistic100","html_url":"https://github.com/mistic100","followers_url":"https://api.github.com/users/mistic100/followers","following_url":"https://api.github.com/users/mistic100/following{/other_user}","gists_url":"https://api.github.com/users/mistic100/gists{/gist_id}","starred_url":"https://api.github.com/users/mistic100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mistic100/subscriptions","organizations_url":"https://api.github.com/users/mistic100/orgs","repos_url":"https://api.github.com/users/mistic100/repos","events_url":"https://api.github.com/users/mistic100/events{/privacy}","received_events_url":"https://api.github.com/users/mistic100/received_events","type":"User","site_admin":false},"repo":{"id":33748729,"name":"Photo-Sphere-Viewer","full_name":"mistic100/Photo-Sphere-Viewer","owner":{"login":"mistic100","id":41597,"avatar_url":"https://avatars.githubusercontent.com/u/41597?v=3","gravatar_id":"","url":"https://api.github.com/users/mistic100","html_url":"https://github.com/mistic100","followers_url":"https://api.github.com/users/mistic100/followers","following_url":"https://api.github.com/users/mistic100/following{/other_user}","gists_url":"https://api.github.com/users/mistic100/gists{/gist_id}","starred_url":"https://api.github.com/users/mistic100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mistic100/subscriptions","organizations_url":"https://api.github.com/users/mistic100/orgs","repos_url":"https://api.github.com/users/mistic100/repos","events_url":"https://api.github.com/users/mistic100/events{/privacy}","received_events_url":"https://api.github.com/users/mistic100/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mistic100/Photo-Sphere-Viewer","description":"A JavaScript library to display Photo Sphere panoramas.","fork":true,"url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer","forks_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/forks","keys_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/teams","hooks_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/hooks","issue_events_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/issues/events{/number}","events_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/events","assignees_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/assignees{/user}","branches_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/branches{/branch}","tags_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/tags","blobs_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/git/refs{/sha}","trees_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/statuses/{sha}","languages_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/languages","stargazers_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/stargazers","contributors_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/contributors","subscribers_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/subscribers","subscription_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/subscription","commits_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/commits{/sha}","git_commits_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/git/commits{/sha}","comments_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/comments{/number}","issue_comment_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/issues/comments{/number}","contents_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/contents/{+path}","compare_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/merges","archive_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/downloads","issues_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/issues{/number}","pulls_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/pulls{/number}","milestones_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/milestones{/number}","notifications_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/labels{/name}","releases_url":"https://api.github.com/repos/mistic100/Photo-Sphere-Viewer/releases{/id}","created_at":"2015-04-10T20:16:16Z","updated_at":"2015-12-07T14:06:30Z","pushed_at":"2015-12-07T19:35:10Z","git_url":"git://github.com/mistic100/Photo-Sphere-Viewer.git","ssh_url":"git@github.com:mistic100/Photo-Sphere-Viewer.git","clone_url":"https://github.com/mistic100/Photo-Sphere-Viewer.git","svn_url":"https://github.com/mistic100/Photo-Sphere-Viewer","homepage":"http://mistic100.github.io/Photo-Sphere-Viewer","size":10836,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":12,"default_branch":"master"}},"base":{"label":"JeremyHeleine:master","ref":"master","sha":"43a22242be1faa254c21ebb671a276af81753917","user":{"login":"JeremyHeleine","id":3313605,"avatar_url":"https://avatars.githubusercontent.com/u/3313605?v=3","gravatar_id":"","url":"https://api.github.com/users/JeremyHeleine","html_url":"https://github.com/JeremyHeleine","followers_url":"https://api.github.com/users/JeremyHeleine/followers","following_url":"https://api.github.com/users/JeremyHeleine/following{/other_user}","gists_url":"https://api.github.com/users/JeremyHeleine/gists{/gist_id}","starred_url":"https://api.github.com/users/JeremyHeleine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeremyHeleine/subscriptions","organizations_url":"https://api.github.com/users/JeremyHeleine/orgs","repos_url":"https://api.github.com/users/JeremyHeleine/repos","events_url":"https://api.github.com/users/JeremyHeleine/events{/privacy}","received_events_url":"https://api.github.com/users/JeremyHeleine/received_events","type":"User","site_admin":false},"repo":{"id":17211085,"name":"Photo-Sphere-Viewer","full_name":"JeremyHeleine/Photo-Sphere-Viewer","owner":{"login":"JeremyHeleine","id":3313605,"avatar_url":"https://avatars.githubusercontent.com/u/3313605?v=3","gravatar_id":"","url":"https://api.github.com/users/JeremyHeleine","html_url":"https://github.com/JeremyHeleine","followers_url":"https://api.github.com/users/JeremyHeleine/followers","following_url":"https://api.github.com/users/JeremyHeleine/following{/other_user}","gists_url":"https://api.github.com/users/JeremyHeleine/gists{/gist_id}","starred_url":"https://api.github.com/users/JeremyHeleine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeremyHeleine/subscriptions","organizations_url":"https://api.github.com/users/JeremyHeleine/orgs","repos_url":"https://api.github.com/users/JeremyHeleine/repos","events_url":"https://api.github.com/users/JeremyHeleine/events{/privacy}","received_events_url":"https://api.github.com/users/JeremyHeleine/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JeremyHeleine/Photo-Sphere-Viewer","description":"A JavaScript library to display Photo Sphere panoramas.","fork":false,"url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer","forks_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/forks","keys_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/teams","hooks_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/hooks","issue_events_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/issues/events{/number}","events_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/events","assignees_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/assignees{/user}","branches_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/branches{/branch}","tags_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/tags","blobs_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/git/refs{/sha}","trees_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/statuses/{sha}","languages_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/languages","stargazers_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/stargazers","contributors_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/contributors","subscribers_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/subscribers","subscription_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/subscription","commits_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/commits{/sha}","git_commits_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/git/commits{/sha}","comments_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/comments{/number}","issue_comment_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/issues/comments{/number}","contents_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/contents/{+path}","compare_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/merges","archive_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/downloads","issues_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/issues{/number}","pulls_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/pulls{/number}","milestones_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/milestones{/number}","notifications_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/labels{/name}","releases_url":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/releases{/id}","created_at":"2014-02-26T13:14:33Z","updated_at":"2015-12-02T13:47:03Z","pushed_at":"2015-11-21T09:48:47Z","git_url":"git://github.com/JeremyHeleine/Photo-Sphere-Viewer.git","ssh_url":"git@github.com:JeremyHeleine/Photo-Sphere-Viewer.git","clone_url":"https://github.com/JeremyHeleine/Photo-Sphere-Viewer.git","svn_url":"https://github.com/JeremyHeleine/Photo-Sphere-Viewer","homepage":null,"size":6770,"stargazers_count":92,"watchers_count":92,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":5,"forks":36,"open_issues":5,"watchers":92,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/pulls/3"},"html":{"href":"https://github.com/JeremyHeleine/Photo-Sphere-Viewer/pull/3"},"issue":{"href":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/issues/3"},"comments":{"href":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/JeremyHeleine/Photo-Sphere-Viewer/statuses/1a9b6aacd91e225fae243e03b3920d3dd6f0fcb9"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":3,"review_comments":0,"commits":1,"additions":2694,"deletions":2692,"changed_files":20}}