{"action":"created","issue":{"url":"https://api.github.com/repos/aurelia/validation/issues/149","labels_url":"https://api.github.com/repos/aurelia/validation/issues/149/labels{/name}","comments_url":"https://api.github.com/repos/aurelia/validation/issues/149/comments","events_url":"https://api.github.com/repos/aurelia/validation/issues/149/events","html_url":"https://github.com/aurelia/validation/pull/149","id":108347794,"number":149,"title":"Fix validating length of numbers","user":{"login":"Zensavona","id":425801,"avatar_url":"https://avatars.githubusercontent.com/u/425801?v=3","gravatar_id":"","url":"https://api.github.com/users/Zensavona","html_url":"https://github.com/Zensavona","followers_url":"https://api.github.com/users/Zensavona/followers","following_url":"https://api.github.com/users/Zensavona/following{/other_user}","gists_url":"https://api.github.com/users/Zensavona/gists{/gist_id}","starred_url":"https://api.github.com/users/Zensavona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zensavona/subscriptions","organizations_url":"https://api.github.com/users/Zensavona/orgs","repos_url":"https://api.github.com/users/Zensavona/repos","events_url":"https://api.github.com/users/Zensavona/events{/privacy}","received_events_url":"https://api.github.com/users/Zensavona/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-25T15:28:56Z","updated_at":"2015-09-25T19:20:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/aurelia/validation/pulls/149","html_url":"https://github.com/aurelia/validation/pull/149","diff_url":"https://github.com/aurelia/validation/pull/149.diff","patch_url":"https://github.com/aurelia/validation/pull/149.patch"},"body":"Validating the length of numbers was broken in a few places, as noted in #136, here are some fixes.\r\n\r\nBasically the bug happens because length is measured and compared using `.length`, which is not a method on `Number`, so I'm checking the `typeof` on values passed into `BetweenLengthValidationRule`, `MaximumLengthValidationRule` and `MinimumLengthValidationRule`. If it's a `Number`, convert it to a `String`.\r\n\r\nSimples.\r\n\r\nThis is my first PR, so if I've done something per convention please let me know.\r\n\r\n:heart: "},"comment":{"url":"https://api.github.com/repos/aurelia/validation/issues/comments/143329697","html_url":"https://github.com/aurelia/validation/pull/149#issuecomment-143329697","issue_url":"https://api.github.com/repos/aurelia/validation/issues/149","id":143329697,"user":{"login":"PWKad","id":4238393,"avatar_url":"https://avatars.githubusercontent.com/u/4238393?v=3","gravatar_id":"","url":"https://api.github.com/users/PWKad","html_url":"https://github.com/PWKad","followers_url":"https://api.github.com/users/PWKad/followers","following_url":"https://api.github.com/users/PWKad/following{/other_user}","gists_url":"https://api.github.com/users/PWKad/gists{/gist_id}","starred_url":"https://api.github.com/users/PWKad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PWKad/subscriptions","organizations_url":"https://api.github.com/users/PWKad/orgs","repos_url":"https://api.github.com/users/PWKad/repos","events_url":"https://api.github.com/users/PWKad/events{/privacy}","received_events_url":"https://api.github.com/users/PWKad/received_events","type":"User","site_admin":false},"created_at":"2015-09-25T19:20:40Z","updated_at":"2015-09-25T19:20:40Z","body":"Thanks @Zensavona - first please make sure you signed the CLA for contributions.  After that could you please squash these in to a single commit since they are all so small?\r\n\r\nThanks a ton!"}}