{"action":"created","issue":{"url":"https://api.github.com/repos/jprichardson/node-fs-extra/issues/132","labels_url":"https://api.github.com/repos/jprichardson/node-fs-extra/issues/132/labels{/name}","comments_url":"https://api.github.com/repos/jprichardson/node-fs-extra/issues/132/comments","events_url":"https://api.github.com/repos/jprichardson/node-fs-extra/issues/132/events","html_url":"https://github.com/jprichardson/node-fs-extra/pull/132","id":73700014,"number":132,"title":"isDirectory method","user":{"login":"overlookmotel","id":557937,"avatar_url":"https://avatars.githubusercontent.com/u/557937?v=3","gravatar_id":"","url":"https://api.github.com/users/overlookmotel","html_url":"https://github.com/overlookmotel","followers_url":"https://api.github.com/users/overlookmotel/followers","following_url":"https://api.github.com/users/overlookmotel/following{/other_user}","gists_url":"https://api.github.com/users/overlookmotel/gists{/gist_id}","starred_url":"https://api.github.com/users/overlookmotel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overlookmotel/subscriptions","organizations_url":"https://api.github.com/users/overlookmotel/orgs","repos_url":"https://api.github.com/users/overlookmotel/repos","events_url":"https://api.github.com/users/overlookmotel/events{/privacy}","received_events_url":"https://api.github.com/users/overlookmotel/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-05-06T18:28:30Z","updated_at":"2015-05-14T18:17:24Z","closed_at":"2015-05-14T18:17:24Z","pull_request":{"url":"https://api.github.com/repos/jprichardson/node-fs-extra/pulls/132","html_url":"https://github.com/jprichardson/node-fs-extra/pull/132","diff_url":"https://github.com/jprichardson/node-fs-extra/pull/132.diff","patch_url":"https://github.com/jprichardson/node-fs-extra/pull/132.patch"},"body":"This PR adds convenience methods `isDirectory()` and `isDirectorySync()`.\r\n\r\nThey are shortcuts for `fs.stat()` followed by calling `.isDirectory()` on the result. These methods are in my [fs-extra-promise](https://github.com/overlookmotel/fs-extra-promise) module, but you said previously that you thought this could be useful to add to fs-extra, and it seems more natural to me to have them here. So here they are!\r\n\r\nI've called them `isDirectory` to match the native node method name, but also aliased them as `isDir` to fit with the naming of other methods in fs-extra.\r\n\r\nI didn't write any tests as (a) I'm not sure how to exactly within your testing framework and (b) the tests would basically be comprised of the same code as the methods themselves!\r\n\r\nPlease let me know if you'd like any amends to this PR."},"comment":{"url":"https://api.github.com/repos/jprichardson/node-fs-extra/issues/comments/102125381","html_url":"https://github.com/jprichardson/node-fs-extra/pull/132#issuecomment-102125381","issue_url":"https://api.github.com/repos/jprichardson/node-fs-extra/issues/132","id":102125381,"user":{"login":"jprichardson","id":150063,"avatar_url":"https://avatars.githubusercontent.com/u/150063?v=3","gravatar_id":"","url":"https://api.github.com/users/jprichardson","html_url":"https://github.com/jprichardson","followers_url":"https://api.github.com/users/jprichardson/followers","following_url":"https://api.github.com/users/jprichardson/following{/other_user}","gists_url":"https://api.github.com/users/jprichardson/gists{/gist_id}","starred_url":"https://api.github.com/users/jprichardson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jprichardson/subscriptions","organizations_url":"https://api.github.com/users/jprichardson/orgs","repos_url":"https://api.github.com/users/jprichardson/repos","events_url":"https://api.github.com/users/jprichardson/events{/privacy}","received_events_url":"https://api.github.com/users/jprichardson/received_events","type":"User","site_admin":false},"created_at":"2015-05-14T18:17:24Z","updated_at":"2015-05-14T18:17:24Z","body":"I have thought about it. I'm still undecided. But it's probably better to just make a decision now and move forward and revisit it later. So for now, I'll reject it. If in the future I change my mind, I'll ping you. Thanks for taking the time and the interest though :)"}}