{"action":"created","issue":{"url":"https://api.github.com/repos/ninenines/erlang.mk/issues/244","labels_url":"https://api.github.com/repos/ninenines/erlang.mk/issues/244/labels{/name}","comments_url":"https://api.github.com/repos/ninenines/erlang.mk/issues/244/comments","events_url":"https://api.github.com/repos/ninenines/erlang.mk/issues/244/events","html_url":"https://github.com/ninenines/erlang.mk/pull/244","id":76222742,"number":244,"title":"Build NIF C code also on tests","user":{"login":"jj1bdx","id":27508,"avatar_url":"https://avatars.githubusercontent.com/u/27508?v=3","gravatar_id":"","url":"https://api.github.com/users/jj1bdx","html_url":"https://github.com/jj1bdx","followers_url":"https://api.github.com/users/jj1bdx/followers","following_url":"https://api.github.com/users/jj1bdx/following{/other_user}","gists_url":"https://api.github.com/users/jj1bdx/gists{/gist_id}","starred_url":"https://api.github.com/users/jj1bdx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jj1bdx/subscriptions","organizations_url":"https://api.github.com/users/jj1bdx/orgs","repos_url":"https://api.github.com/users/jj1bdx/repos","events_url":"https://api.github.com/users/jj1bdx/events{/privacy}","received_events_url":"https://api.github.com/users/jj1bdx/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-05-14T04:13:17Z","updated_at":"2015-05-15T03:44:20Z","closed_at":"2015-05-14T16:40:29Z","pull_request":{"url":"https://api.github.com/repos/ninenines/erlang.mk/pulls/244","html_url":"https://github.com/ninenines/erlang.mk/pull/244","diff_url":"https://github.com/ninenines/erlang.mk/pull/244.diff","patch_url":"https://github.com/ninenines/erlang.mk/pull/244.patch"},"body":"* This patch ensures building the NIF code under`c_src`\r\n  even on running `make tests`\r\n\r\n* When `c_src/Makefile` exists:\r\n    * Split the Makefile invocation dependency into `app-c_src`\r\n    * Invoke `app-c_src` also in `test-build` as well as `app`\r\n* When `c_src/Makefile` does not exist:\r\n    * Add `$(C_SRC_ENV) $(C_SRC_OUTPUT)` dependencies to `test-build`"},"comment":{"url":"https://api.github.com/repos/ninenines/erlang.mk/issues/comments/102245270","html_url":"https://github.com/ninenines/erlang.mk/pull/244#issuecomment-102245270","issue_url":"https://api.github.com/repos/ninenines/erlang.mk/issues/244","id":102245270,"user":{"login":"jj1bdx","id":27508,"avatar_url":"https://avatars.githubusercontent.com/u/27508?v=3","gravatar_id":"","url":"https://api.github.com/users/jj1bdx","html_url":"https://github.com/jj1bdx","followers_url":"https://api.github.com/users/jj1bdx/followers","following_url":"https://api.github.com/users/jj1bdx/following{/other_user}","gists_url":"https://api.github.com/users/jj1bdx/gists{/gist_id}","starred_url":"https://api.github.com/users/jj1bdx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jj1bdx/subscriptions","organizations_url":"https://api.github.com/users/jj1bdx/orgs","repos_url":"https://api.github.com/users/jj1bdx/repos","events_url":"https://api.github.com/users/jj1bdx/events{/privacy}","received_events_url":"https://api.github.com/users/jj1bdx/received_events","type":"User","site_admin":false},"created_at":"2015-05-15T03:44:20Z","updated_at":"2015-05-15T03:44:20Z","body":"Note: the `make check` worked OK on GNU Make 3.81 on OS X. The FreeBSD Port GNU Make `devel/gmake` is GNU Make 4.1:\r\n\r\n```\r\nGNU Make 4.1\r\nBuilt for amd64-portbld-freebsd10.1\r\nCopyright (C) 1988-2014 Free Software Foundation, Inc.\r\nLicense GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>\r\nThis is free software: you are free to change and redistribute it.\r\nThere is NO WARRANTY, to the extent permitted by law.\r\n```"}}