{"action":"created","comment":{"url":"https://api.github.com/repos/segmentio/analytics-go/pulls/comments/34684066","id":34684066,"diff_hunk":"@@ -283,13 +302,13 @@ func (c *Client) loop() {\n \t\t\tmsgs = append(msgs, msg)\n \t\t\tif len(msgs) == c.Size {\n \t\t\t\tc.verbose(\"exceeded %d messages – flushing\", c.Size)\n-\t\t\t\tc.send(msgs)\n+\t\t\t\tgo c.send(msgs)","path":"analytics.go","position":73,"original_position":73,"commit_id":"df260aaed40eaba3d20eb3c888c020791f06b6f6","original_commit_id":"903e7eafcf6e2b5dc1be55cab6eaac2d9a0b3b85","user":{"login":"tj","id":25254,"avatar_url":"https://avatars.githubusercontent.com/u/25254?v=3","gravatar_id":"","url":"https://api.github.com/users/tj","html_url":"https://github.com/tj","followers_url":"https://api.github.com/users/tj/followers","following_url":"https://api.github.com/users/tj/following{/other_user}","gists_url":"https://api.github.com/users/tj/gists{/gist_id}","starred_url":"https://api.github.com/users/tj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tj/subscriptions","organizations_url":"https://api.github.com/users/tj/orgs","repos_url":"https://api.github.com/users/tj/repos","events_url":"https://api.github.com/users/tj/events{/privacy}","received_events_url":"https://api.github.com/users/tj/received_events","type":"User","site_admin":false},"body":"Hmm yeah might not be a bad idea, though hopefully we're never down enough for it to back up like mad with retries haha. Maybe just a second goro for handling retries with a high watermark that just drops after, not sure","created_at":"2015-07-15T14:33:22Z","updated_at":"2015-07-15T14:33:22Z","html_url":"https://github.com/segmentio/analytics-go/pull/16#discussion_r34684066","pull_request_url":"https://api.github.com/repos/segmentio/analytics-go/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/segmentio/analytics-go/pulls/comments/34684066"},"html":{"href":"https://github.com/segmentio/analytics-go/pull/16#discussion_r34684066"},"pull_request":{"href":"https://api.github.com/repos/segmentio/analytics-go/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/segmentio/analytics-go/pulls/16","id":34613041,"html_url":"https://github.com/segmentio/analytics-go/pull/16","diff_url":"https://github.com/segmentio/analytics-go/pull/16.diff","patch_url":"https://github.com/segmentio/analytics-go/pull/16.patch","issue_url":"https://api.github.com/repos/segmentio/analytics-go/issues/16","number":16,"state":"open","locked":false,"title":"Retry and backoff","user":{"login":"f2prateek","id":843979,"avatar_url":"https://avatars.githubusercontent.com/u/843979?v=3","gravatar_id":"","url":"https://api.github.com/users/f2prateek","html_url":"https://github.com/f2prateek","followers_url":"https://api.github.com/users/f2prateek/followers","following_url":"https://api.github.com/users/f2prateek/following{/other_user}","gists_url":"https://api.github.com/users/f2prateek/gists{/gist_id}","starred_url":"https://api.github.com/users/f2prateek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/f2prateek/subscriptions","organizations_url":"https://api.github.com/users/f2prateek/orgs","repos_url":"https://api.github.com/users/f2prateek/repos","events_url":"https://api.github.com/users/f2prateek/events{/privacy}","received_events_url":"https://api.github.com/users/f2prateek/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-05-04T02:43:28Z","updated_at":"2015-07-15T14:33:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5dba604c1d0ab1c7e82f664ea746bc43a27b32a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/segmentio/analytics-go/pulls/16/commits","review_comments_url":"https://api.github.com/repos/segmentio/analytics-go/pulls/16/comments","review_comment_url":"https://api.github.com/repos/segmentio/analytics-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/segmentio/analytics-go/issues/16/comments","statuses_url":"https://api.github.com/repos/segmentio/analytics-go/statuses/df260aaed40eaba3d20eb3c888c020791f06b6f6","head":{"label":"segmentio:retry-and-backoff","ref":"retry-and-backoff","sha":"df260aaed40eaba3d20eb3c888c020791f06b6f6","user":{"login":"segmentio","id":819518,"avatar_url":"https://avatars.githubusercontent.com/u/819518?v=3","gravatar_id":"","url":"https://api.github.com/users/segmentio","html_url":"https://github.com/segmentio","followers_url":"https://api.github.com/users/segmentio/followers","following_url":"https://api.github.com/users/segmentio/following{/other_user}","gists_url":"https://api.github.com/users/segmentio/gists{/gist_id}","starred_url":"https://api.github.com/users/segmentio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segmentio/subscriptions","organizations_url":"https://api.github.com/users/segmentio/orgs","repos_url":"https://api.github.com/users/segmentio/repos","events_url":"https://api.github.com/users/segmentio/events{/privacy}","received_events_url":"https://api.github.com/users/segmentio/received_events","type":"Organization","site_admin":false},"repo":{"id":19091205,"name":"analytics-go","full_name":"segmentio/analytics-go","owner":{"login":"segmentio","id":819518,"avatar_url":"https://avatars.githubusercontent.com/u/819518?v=3","gravatar_id":"","url":"https://api.github.com/users/segmentio","html_url":"https://github.com/segmentio","followers_url":"https://api.github.com/users/segmentio/followers","following_url":"https://api.github.com/users/segmentio/following{/other_user}","gists_url":"https://api.github.com/users/segmentio/gists{/gist_id}","starred_url":"https://api.github.com/users/segmentio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segmentio/subscriptions","organizations_url":"https://api.github.com/users/segmentio/orgs","repos_url":"https://api.github.com/users/segmentio/repos","events_url":"https://api.github.com/users/segmentio/events{/privacy}","received_events_url":"https://api.github.com/users/segmentio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/segmentio/analytics-go","description":"Segment analytics client for Go","fork":false,"url":"https://api.github.com/repos/segmentio/analytics-go","forks_url":"https://api.github.com/repos/segmentio/analytics-go/forks","keys_url":"https://api.github.com/repos/segmentio/analytics-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/segmentio/analytics-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/segmentio/analytics-go/teams","hooks_url":"https://api.github.com/repos/segmentio/analytics-go/hooks","issue_events_url":"https://api.github.com/repos/segmentio/analytics-go/issues/events{/number}","events_url":"https://api.github.com/repos/segmentio/analytics-go/events","assignees_url":"https://api.github.com/repos/segmentio/analytics-go/assignees{/user}","branches_url":"https://api.github.com/repos/segmentio/analytics-go/branches{/branch}","tags_url":"https://api.github.com/repos/segmentio/analytics-go/tags","blobs_url":"https://api.github.com/repos/segmentio/analytics-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/segmentio/analytics-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/segmentio/analytics-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/segmentio/analytics-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/segmentio/analytics-go/statuses/{sha}","languages_url":"https://api.github.com/repos/segmentio/analytics-go/languages","stargazers_url":"https://api.github.com/repos/segmentio/analytics-go/stargazers","contributors_url":"https://api.github.com/repos/segmentio/analytics-go/contributors","subscribers_url":"https://api.github.com/repos/segmentio/analytics-go/subscribers","subscription_url":"https://api.github.com/repos/segmentio/analytics-go/subscription","commits_url":"https://api.github.com/repos/segmentio/analytics-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/segmentio/analytics-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/segmentio/analytics-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/segmentio/analytics-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/segmentio/analytics-go/contents/{+path}","compare_url":"https://api.github.com/repos/segmentio/analytics-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/segmentio/analytics-go/merges","archive_url":"https://api.github.com/repos/segmentio/analytics-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/segmentio/analytics-go/downloads","issues_url":"https://api.github.com/repos/segmentio/analytics-go/issues{/number}","pulls_url":"https://api.github.com/repos/segmentio/analytics-go/pulls{/number}","milestones_url":"https://api.github.com/repos/segmentio/analytics-go/milestones{/number}","notifications_url":"https://api.github.com/repos/segmentio/analytics-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/segmentio/analytics-go/labels{/name}","releases_url":"https://api.github.com/repos/segmentio/analytics-go/releases{/id}","created_at":"2014-04-24T01:15:51Z","updated_at":"2015-06-03T06:06:02Z","pushed_at":"2015-07-15T14:31:19Z","git_url":"git://github.com/segmentio/analytics-go.git","ssh_url":"git@github.com:segmentio/analytics-go.git","clone_url":"https://github.com/segmentio/analytics-go.git","svn_url":"https://github.com/segmentio/analytics-go","homepage":"https://segment.com/docs/libraries/go","size":374,"stargazers_count":42,"watchers_count":42,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":3,"forks":8,"open_issues":3,"watchers":42,"default_branch":"master"}},"base":{"label":"segmentio:master","ref":"master","sha":"a00c44e153c2dc3ed596f6f2478ed806e7461ee6","user":{"login":"segmentio","id":819518,"avatar_url":"https://avatars.githubusercontent.com/u/819518?v=3","gravatar_id":"","url":"https://api.github.com/users/segmentio","html_url":"https://github.com/segmentio","followers_url":"https://api.github.com/users/segmentio/followers","following_url":"https://api.github.com/users/segmentio/following{/other_user}","gists_url":"https://api.github.com/users/segmentio/gists{/gist_id}","starred_url":"https://api.github.com/users/segmentio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segmentio/subscriptions","organizations_url":"https://api.github.com/users/segmentio/orgs","repos_url":"https://api.github.com/users/segmentio/repos","events_url":"https://api.github.com/users/segmentio/events{/privacy}","received_events_url":"https://api.github.com/users/segmentio/received_events","type":"Organization","site_admin":false},"repo":{"id":19091205,"name":"analytics-go","full_name":"segmentio/analytics-go","owner":{"login":"segmentio","id":819518,"avatar_url":"https://avatars.githubusercontent.com/u/819518?v=3","gravatar_id":"","url":"https://api.github.com/users/segmentio","html_url":"https://github.com/segmentio","followers_url":"https://api.github.com/users/segmentio/followers","following_url":"https://api.github.com/users/segmentio/following{/other_user}","gists_url":"https://api.github.com/users/segmentio/gists{/gist_id}","starred_url":"https://api.github.com/users/segmentio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segmentio/subscriptions","organizations_url":"https://api.github.com/users/segmentio/orgs","repos_url":"https://api.github.com/users/segmentio/repos","events_url":"https://api.github.com/users/segmentio/events{/privacy}","received_events_url":"https://api.github.com/users/segmentio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/segmentio/analytics-go","description":"Segment analytics client for Go","fork":false,"url":"https://api.github.com/repos/segmentio/analytics-go","forks_url":"https://api.github.com/repos/segmentio/analytics-go/forks","keys_url":"https://api.github.com/repos/segmentio/analytics-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/segmentio/analytics-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/segmentio/analytics-go/teams","hooks_url":"https://api.github.com/repos/segmentio/analytics-go/hooks","issue_events_url":"https://api.github.com/repos/segmentio/analytics-go/issues/events{/number}","events_url":"https://api.github.com/repos/segmentio/analytics-go/events","assignees_url":"https://api.github.com/repos/segmentio/analytics-go/assignees{/user}","branches_url":"https://api.github.com/repos/segmentio/analytics-go/branches{/branch}","tags_url":"https://api.github.com/repos/segmentio/analytics-go/tags","blobs_url":"https://api.github.com/repos/segmentio/analytics-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/segmentio/analytics-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/segmentio/analytics-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/segmentio/analytics-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/segmentio/analytics-go/statuses/{sha}","languages_url":"https://api.github.com/repos/segmentio/analytics-go/languages","stargazers_url":"https://api.github.com/repos/segmentio/analytics-go/stargazers","contributors_url":"https://api.github.com/repos/segmentio/analytics-go/contributors","subscribers_url":"https://api.github.com/repos/segmentio/analytics-go/subscribers","subscription_url":"https://api.github.com/repos/segmentio/analytics-go/subscription","commits_url":"https://api.github.com/repos/segmentio/analytics-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/segmentio/analytics-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/segmentio/analytics-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/segmentio/analytics-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/segmentio/analytics-go/contents/{+path}","compare_url":"https://api.github.com/repos/segmentio/analytics-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/segmentio/analytics-go/merges","archive_url":"https://api.github.com/repos/segmentio/analytics-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/segmentio/analytics-go/downloads","issues_url":"https://api.github.com/repos/segmentio/analytics-go/issues{/number}","pulls_url":"https://api.github.com/repos/segmentio/analytics-go/pulls{/number}","milestones_url":"https://api.github.com/repos/segmentio/analytics-go/milestones{/number}","notifications_url":"https://api.github.com/repos/segmentio/analytics-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/segmentio/analytics-go/labels{/name}","releases_url":"https://api.github.com/repos/segmentio/analytics-go/releases{/id}","created_at":"2014-04-24T01:15:51Z","updated_at":"2015-06-03T06:06:02Z","pushed_at":"2015-07-15T14:31:19Z","git_url":"git://github.com/segmentio/analytics-go.git","ssh_url":"git@github.com:segmentio/analytics-go.git","clone_url":"https://github.com/segmentio/analytics-go.git","svn_url":"https://github.com/segmentio/analytics-go","homepage":"https://segment.com/docs/libraries/go","size":374,"stargazers_count":42,"watchers_count":42,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":3,"forks":8,"open_issues":3,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/segmentio/analytics-go/pulls/16"},"html":{"href":"https://github.com/segmentio/analytics-go/pull/16"},"issue":{"href":"https://api.github.com/repos/segmentio/analytics-go/issues/16"},"comments":{"href":"https://api.github.com/repos/segmentio/analytics-go/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/segmentio/analytics-go/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/segmentio/analytics-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/segmentio/analytics-go/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/segmentio/analytics-go/statuses/df260aaed40eaba3d20eb3c888c020791f06b6f6"}}}}