{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/36374359","id":36374359,"diff_hunk":"@@ -155,7 +160,7 @@ func verifyPlatformContainerSettings(daemon *Daemon, hostConfig *runconfig.HostC\n \tif hostConfig.Memory == 0 && hostConfig.MemorySwap > 0 {\n \t\treturn warnings, fmt.Errorf(\"You should always set the Memory limit when using Memoryswap limit, see usage.\")\n \t}\n-\tif hostConfig.MemorySwappiness != nil && !daemon.SystemConfig().MemorySwappiness {\n+\tif hostConfig.MemorySwappiness != nil && !sysInfo.MemorySwappiness {","path":"daemon/daemon_unix.go","position":41,"original_position":41,"commit_id":"b1fd0fe61649b278c80d8f24fd77254f20b1598c","original_commit_id":"a2c578e1907f5cc9836e148f6c2745eac300371f","user":{"login":"runcom","id":849915,"avatar_url":"https://avatars.githubusercontent.com/u/849915?v=3","gravatar_id":"","url":"https://api.github.com/users/runcom","html_url":"https://github.com/runcom","followers_url":"https://api.github.com/users/runcom/followers","following_url":"https://api.github.com/users/runcom/following{/other_user}","gists_url":"https://api.github.com/users/runcom/gists{/gist_id}","starred_url":"https://api.github.com/users/runcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runcom/subscriptions","organizations_url":"https://api.github.com/users/runcom/orgs","repos_url":"https://api.github.com/users/runcom/repos","events_url":"https://api.github.com/users/runcom/events{/privacy}","received_events_url":"https://api.github.com/users/runcom/received_events","type":"User","site_admin":false},"body":"You're right, fixing","created_at":"2015-08-06T01:35:19Z","updated_at":"2015-08-06T01:35:19Z","html_url":"https://github.com/docker/docker/pull/15275#discussion_r36374359","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/15275","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/36374359"},"html":{"href":"https://github.com/docker/docker/pull/15275#discussion_r36374359"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/15275"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/15275","id":41518363,"html_url":"https://github.com/docker/docker/pull/15275","diff_url":"https://github.com/docker/docker/pull/15275.diff","patch_url":"https://github.com/docker/docker/pull/15275.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/15275","number":15275,"state":"open","locked":false,"title":"Runtime sysinfo check","user":{"login":"runcom","id":849915,"avatar_url":"https://avatars.githubusercontent.com/u/849915?v=3","gravatar_id":"","url":"https://api.github.com/users/runcom","html_url":"https://github.com/runcom","followers_url":"https://api.github.com/users/runcom/followers","following_url":"https://api.github.com/users/runcom/following{/other_user}","gists_url":"https://api.github.com/users/runcom/gists{/gist_id}","starred_url":"https://api.github.com/users/runcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runcom/subscriptions","organizations_url":"https://api.github.com/users/runcom/orgs","repos_url":"https://api.github.com/users/runcom/repos","events_url":"https://api.github.com/users/runcom/events{/privacy}","received_events_url":"https://api.github.com/users/runcom/received_events","type":"User","site_admin":false},"body":"fix #15159\r\nfix #15286 \r\n\r\ntl;dr (more in commit messages)\r\n\r\nsysinfo is initialized and stored in the daemon struct at daemon startup\r\nruntime system settings changes aren't reflected in sysinfo daemon field\r\nerrors from libcontainer complaining about write to non existent cgroup path when it wasn't supposed to not even write there\r\n\r\nnow if a cgroup is umounted at runtime (memory for instance) and a container had memory-swappiness enabled and it's started again, the error from libcontainer is gone and in daemon logs you get\r\n```\r\nWARN[0108] Your kernel does not support cgroup memory limit: mountpoint for memory not found \r\nWARN[0108] Your kernel does not support memory swappiness capabilities, memory swappiness discarded. \r\nWARN[0108] IPv4 forwarding is disabled. Networking will not work \r\nWARN[0109] Your kernel does not support OOM notifications: There is no path for \"memory\" in state\r\n```\r\n**NOTE: warnings are not printed to stdout/stderr while starting a container (as it's happening for `run`) with wrong memory swappiness but only in daemon-logs.** This is because start return StatusNoContent so would not be good to break that behavior and print the warnings there and also this is more of a sysadmin thing who watches for wrong behaviors in daemon logs (please someone confirm this also)\r\n\r\nI've made sysinfo checks at runtime and removed the field from the daemon struct\r\nhostConfig is checked at container's start too\r\ndouble ipv4forward check is removed","created_at":"2015-08-03T22:50:04Z","updated_at":"2015-08-06T01:35:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed98d364f4c6a339fcf350cdc3014c7a61983df0","assignee":null,"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/39","html_url":"https://github.com/docker/docker/milestones/1.8.0","labels_url":"https://api.github.com/repos/docker/docker/milestones/39/labels","id":1151952,"number":39,"title":"1.8.0","description":"","creator":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":125,"state":"open","created_at":"2015-06-05T19:27:06Z","updated_at":"2015-08-06T00:45:40Z","due_on":"2015-08-09T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/docker/docker/pulls/15275/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/15275/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/15275/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/b1fd0fe61649b278c80d8f24fd77254f20b1598c","head":{"label":"runcom:runtime-sysinfo-check","ref":"runtime-sysinfo-check","sha":"b1fd0fe61649b278c80d8f24fd77254f20b1598c","user":{"login":"runcom","id":849915,"avatar_url":"https://avatars.githubusercontent.com/u/849915?v=3","gravatar_id":"","url":"https://api.github.com/users/runcom","html_url":"https://github.com/runcom","followers_url":"https://api.github.com/users/runcom/followers","following_url":"https://api.github.com/users/runcom/following{/other_user}","gists_url":"https://api.github.com/users/runcom/gists{/gist_id}","starred_url":"https://api.github.com/users/runcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runcom/subscriptions","organizations_url":"https://api.github.com/users/runcom/orgs","repos_url":"https://api.github.com/users/runcom/repos","events_url":"https://api.github.com/users/runcom/events{/privacy}","received_events_url":"https://api.github.com/users/runcom/received_events","type":"User","site_admin":false},"repo":{"id":32636176,"name":"docker","full_name":"runcom/docker","owner":{"login":"runcom","id":849915,"avatar_url":"https://avatars.githubusercontent.com/u/849915?v=3","gravatar_id":"","url":"https://api.github.com/users/runcom","html_url":"https://github.com/runcom","followers_url":"https://api.github.com/users/runcom/followers","following_url":"https://api.github.com/users/runcom/following{/other_user}","gists_url":"https://api.github.com/users/runcom/gists{/gist_id}","starred_url":"https://api.github.com/users/runcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runcom/subscriptions","organizations_url":"https://api.github.com/users/runcom/orgs","repos_url":"https://api.github.com/users/runcom/repos","events_url":"https://api.github.com/users/runcom/events{/privacy}","received_events_url":"https://api.github.com/users/runcom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/runcom/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/runcom/docker","forks_url":"https://api.github.com/repos/runcom/docker/forks","keys_url":"https://api.github.com/repos/runcom/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/runcom/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/runcom/docker/teams","hooks_url":"https://api.github.com/repos/runcom/docker/hooks","issue_events_url":"https://api.github.com/repos/runcom/docker/issues/events{/number}","events_url":"https://api.github.com/repos/runcom/docker/events","assignees_url":"https://api.github.com/repos/runcom/docker/assignees{/user}","branches_url":"https://api.github.com/repos/runcom/docker/branches{/branch}","tags_url":"https://api.github.com/repos/runcom/docker/tags","blobs_url":"https://api.github.com/repos/runcom/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/runcom/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/runcom/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/runcom/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/runcom/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/runcom/docker/languages","stargazers_url":"https://api.github.com/repos/runcom/docker/stargazers","contributors_url":"https://api.github.com/repos/runcom/docker/contributors","subscribers_url":"https://api.github.com/repos/runcom/docker/subscribers","subscription_url":"https://api.github.com/repos/runcom/docker/subscription","commits_url":"https://api.github.com/repos/runcom/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/runcom/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/runcom/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/runcom/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/runcom/docker/contents/{+path}","compare_url":"https://api.github.com/repos/runcom/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/runcom/docker/merges","archive_url":"https://api.github.com/repos/runcom/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/runcom/docker/downloads","issues_url":"https://api.github.com/repos/runcom/docker/issues{/number}","pulls_url":"https://api.github.com/repos/runcom/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/runcom/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/runcom/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/runcom/docker/labels{/name}","releases_url":"https://api.github.com/repos/runcom/docker/releases{/id}","created_at":"2015-03-21T14:55:26Z","updated_at":"2015-05-07T17:30:16Z","pushed_at":"2015-08-05T12:27:17Z","git_url":"git://github.com/runcom/docker.git","ssh_url":"git@github.com:runcom/docker.git","clone_url":"https://github.com/runcom/docker.git","svn_url":"https://github.com/runcom/docker","homepage":"http://www.docker.com","size":66549,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"7374852be9def787921aea2ca831771982badecf","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-08-06T01:22:35Z","pushed_at":"2015-08-06T01:16:02Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":235112,"stargazers_count":23771,"watchers_count":23771,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5999,"mirror_url":null,"open_issues_count":1050,"forks":5999,"open_issues":1050,"watchers":23771,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/15275"},"html":{"href":"https://github.com/docker/docker/pull/15275"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/15275"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/15275/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/15275/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/15275/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/b1fd0fe61649b278c80d8f24fd77254f20b1598c"}}}}