{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaLang/julia/issues/9098","labels_url":"https://api.github.com/repos/JuliaLang/julia/issues/9098/labels{/name}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/9098/comments","events_url":"https://api.github.com/repos/JuliaLang/julia/issues/9098/events","html_url":"https://github.com/JuliaLang/julia/pull/9098","id":49721949,"number":9098,"title":"Expunging @ngenerate and @nsplat","user":{"login":"timholy","id":1525481,"avatar_url":"https://avatars.githubusercontent.com/u/1525481?v=3","gravatar_id":"","url":"https://api.github.com/users/timholy","html_url":"https://github.com/timholy","followers_url":"https://api.github.com/users/timholy/followers","following_url":"https://api.github.com/users/timholy/following{/other_user}","gists_url":"https://api.github.com/users/timholy/gists{/gist_id}","starred_url":"https://api.github.com/users/timholy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timholy/subscriptions","organizations_url":"https://api.github.com/users/timholy/orgs","repos_url":"https://api.github.com/users/timholy/repos","events_url":"https://api.github.com/users/timholy/events{/privacy}","received_events_url":"https://api.github.com/users/timholy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2014-11-21T17:07:20Z","updated_at":"2015-02-04T13:21:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/9098","html_url":"https://github.com/JuliaLang/julia/pull/9098","diff_url":"https://github.com/JuliaLang/julia/pull/9098.diff","patch_url":"https://github.com/JuliaLang/julia/pull/9098.patch"},"body":"This one's for you, @JeffBezanson. Happy early thesis-defense.\r\n\r\nNow that we have `stagedfunction`s/`@generated function`s, there is no need for `@ngenerate`. (`@nsplat` still might have a purpose, but without `@ngenerate` I think we might as well ditch both at once. You can fake de-splatting with `stagedfunction`s.) This is a WIP at getting rid of them. Currently if I try to convert those last few BitArray methods, I get failures: building hangs at `primes.jl`, the first file after `multidimensional.jl`. Interestingly, they all involve `@ncall`, leading me to suspect a type-inference problem. #8504 is a likely suspect.\r\n\r\nThis is broken up in a series of small steps because it was basically murder to debug this---these functions are core infrastructure, and with multiple breakages it's hard to figure out what's happening. Given that we don't fully trust stagedfunctions yet (see https://github.com/JuliaLang/julia/pull/8501#issuecomment-63922923), I also thought it would be good to ensure that `git bisect` would be as informative as possible. But if people object, I can (reluctantly) squash. Just don't ask me to bisect any problems later :smile:.\r\n\r\nSee also https://github.com/JuliaLang/Compat.jl/pull/19, which hopefully will provide backward-compatibility. I know this wasn't an exported interface, but I still felt guilty about just yanking it. I'll also write up some docs about how to convert functions.\r\n"},"comment":{"url":"https://api.github.com/repos/JuliaLang/julia/issues/comments/72852865","html_url":"https://github.com/JuliaLang/julia/pull/9098#issuecomment-72852865","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/9098","id":72852865,"user":{"login":"timholy","id":1525481,"avatar_url":"https://avatars.githubusercontent.com/u/1525481?v=3","gravatar_id":"","url":"https://api.github.com/users/timholy","html_url":"https://github.com/timholy","followers_url":"https://api.github.com/users/timholy/followers","following_url":"https://api.github.com/users/timholy/following{/other_user}","gists_url":"https://api.github.com/users/timholy/gists{/gist_id}","starred_url":"https://api.github.com/users/timholy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timholy/subscriptions","organizations_url":"https://api.github.com/users/timholy/orgs","repos_url":"https://api.github.com/users/timholy/repos","events_url":"https://api.github.com/users/timholy/events{/privacy}","received_events_url":"https://api.github.com/users/timholy/received_events","type":"User","site_admin":false},"created_at":"2015-02-04T13:21:40Z","updated_at":"2015-02-04T13:21:40Z","body":"Thanks.\r\n\r\nI'm traveling over the next few days, so I'll hold off on merging this until I can deal with any problems that arise."}}