{"action":"opened","number":1738,"pull_request":{"url":"https://api.github.com/repos/Codeception/Codeception/pulls/1738","id":29825699,"html_url":"https://github.com/Codeception/Codeception/pull/1738","diff_url":"https://github.com/Codeception/Codeception/pull/1738.diff","patch_url":"https://github.com/Codeception/Codeception/pull/1738.patch","issue_url":"https://api.github.com/repos/Codeception/Codeception/issues/1738","number":1738,"state":"open","locked":false,"title":"FTP Passive Mode","user":{"login":"PH2M","id":1543581,"avatar_url":"https://avatars.githubusercontent.com/u/1543581?v=3","gravatar_id":"","url":"https://api.github.com/users/PH2M","html_url":"https://github.com/PH2M","followers_url":"https://api.github.com/users/PH2M/followers","following_url":"https://api.github.com/users/PH2M/following{/other_user}","gists_url":"https://api.github.com/users/PH2M/gists{/gist_id}","starred_url":"https://api.github.com/users/PH2M/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PH2M/subscriptions","organizations_url":"https://api.github.com/users/PH2M/orgs","repos_url":"https://api.github.com/users/PH2M/repos","events_url":"https://api.github.com/users/PH2M/events{/privacy}","received_events_url":"https://api.github.com/users/PH2M/received_events","type":"User","site_admin":false},"body":"Hello Michael,\r\n\r\nI found an issue of FTP module:\r\n\r\n1. Passive mode do not get config value. Line 578 => You compare `$this->config['passive’]` with enabled instead of `true` or `1`\r\n2. (Most important) You define passive mode before login, and you have to set it just after login.\r\n\r\nI found the solution here :\r\n- http://stackoverflow.com/a/1612323/3437153\r\n- http://biostall.com/phps-ftp_nlist-returning-false-even-when-files-definitely-exist\r\n\r\nWith this pull request, FTP Module is fully operational.","created_at":"2015-02-23T17:03:23Z","updated_at":"2015-02-23T17:03:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Codeception/Codeception/pulls/1738/commits","review_comments_url":"https://api.github.com/repos/Codeception/Codeception/pulls/1738/comments","review_comment_url":"https://api.github.com/repos/Codeception/Codeception/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Codeception/Codeception/issues/1738/comments","statuses_url":"https://api.github.com/repos/Codeception/Codeception/statuses/a2ba0bc80d0fab73e80f611cad06e5a061dea3a3","head":{"label":"PH2M:patch-1","ref":"patch-1","sha":"a2ba0bc80d0fab73e80f611cad06e5a061dea3a3","user":{"login":"PH2M","id":1543581,"avatar_url":"https://avatars.githubusercontent.com/u/1543581?v=3","gravatar_id":"","url":"https://api.github.com/users/PH2M","html_url":"https://github.com/PH2M","followers_url":"https://api.github.com/users/PH2M/followers","following_url":"https://api.github.com/users/PH2M/following{/other_user}","gists_url":"https://api.github.com/users/PH2M/gists{/gist_id}","starred_url":"https://api.github.com/users/PH2M/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PH2M/subscriptions","organizations_url":"https://api.github.com/users/PH2M/orgs","repos_url":"https://api.github.com/users/PH2M/repos","events_url":"https://api.github.com/users/PH2M/events{/privacy}","received_events_url":"https://api.github.com/users/PH2M/received_events","type":"User","site_admin":false},"repo":{"id":31218348,"name":"Codeception","full_name":"PH2M/Codeception","owner":{"login":"PH2M","id":1543581,"avatar_url":"https://avatars.githubusercontent.com/u/1543581?v=3","gravatar_id":"","url":"https://api.github.com/users/PH2M","html_url":"https://github.com/PH2M","followers_url":"https://api.github.com/users/PH2M/followers","following_url":"https://api.github.com/users/PH2M/following{/other_user}","gists_url":"https://api.github.com/users/PH2M/gists{/gist_id}","starred_url":"https://api.github.com/users/PH2M/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PH2M/subscriptions","organizations_url":"https://api.github.com/users/PH2M/orgs","repos_url":"https://api.github.com/users/PH2M/repos","events_url":"https://api.github.com/users/PH2M/events{/privacy}","received_events_url":"https://api.github.com/users/PH2M/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PH2M/Codeception","description":"Full-stack testing PHP framework","fork":true,"url":"https://api.github.com/repos/PH2M/Codeception","forks_url":"https://api.github.com/repos/PH2M/Codeception/forks","keys_url":"https://api.github.com/repos/PH2M/Codeception/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PH2M/Codeception/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PH2M/Codeception/teams","hooks_url":"https://api.github.com/repos/PH2M/Codeception/hooks","issue_events_url":"https://api.github.com/repos/PH2M/Codeception/issues/events{/number}","events_url":"https://api.github.com/repos/PH2M/Codeception/events","assignees_url":"https://api.github.com/repos/PH2M/Codeception/assignees{/user}","branches_url":"https://api.github.com/repos/PH2M/Codeception/branches{/branch}","tags_url":"https://api.github.com/repos/PH2M/Codeception/tags","blobs_url":"https://api.github.com/repos/PH2M/Codeception/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PH2M/Codeception/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PH2M/Codeception/git/refs{/sha}","trees_url":"https://api.github.com/repos/PH2M/Codeception/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PH2M/Codeception/statuses/{sha}","languages_url":"https://api.github.com/repos/PH2M/Codeception/languages","stargazers_url":"https://api.github.com/repos/PH2M/Codeception/stargazers","contributors_url":"https://api.github.com/repos/PH2M/Codeception/contributors","subscribers_url":"https://api.github.com/repos/PH2M/Codeception/subscribers","subscription_url":"https://api.github.com/repos/PH2M/Codeception/subscription","commits_url":"https://api.github.com/repos/PH2M/Codeception/commits{/sha}","git_commits_url":"https://api.github.com/repos/PH2M/Codeception/git/commits{/sha}","comments_url":"https://api.github.com/repos/PH2M/Codeception/comments{/number}","issue_comment_url":"https://api.github.com/repos/PH2M/Codeception/issues/comments{/number}","contents_url":"https://api.github.com/repos/PH2M/Codeception/contents/{+path}","compare_url":"https://api.github.com/repos/PH2M/Codeception/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PH2M/Codeception/merges","archive_url":"https://api.github.com/repos/PH2M/Codeception/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PH2M/Codeception/downloads","issues_url":"https://api.github.com/repos/PH2M/Codeception/issues{/number}","pulls_url":"https://api.github.com/repos/PH2M/Codeception/pulls{/number}","milestones_url":"https://api.github.com/repos/PH2M/Codeception/milestones{/number}","notifications_url":"https://api.github.com/repos/PH2M/Codeception/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PH2M/Codeception/labels{/name}","releases_url":"https://api.github.com/repos/PH2M/Codeception/releases{/id}","created_at":"2015-02-23T16:56:31Z","updated_at":"2015-02-23T16:56:33Z","pushed_at":"2015-02-23T17:02:45Z","git_url":"git://github.com/PH2M/Codeception.git","ssh_url":"git@github.com:PH2M/Codeception.git","clone_url":"https://github.com/PH2M/Codeception.git","svn_url":"https://github.com/PH2M/Codeception","homepage":"http://codeception.com","size":62405,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.0"}},"base":{"label":"Codeception:2.0","ref":"2.0","sha":"11414e0dd330d354fa29f49e0e1c86910601f613","user":{"login":"Codeception","id":1288753,"avatar_url":"https://avatars.githubusercontent.com/u/1288753?v=3","gravatar_id":"","url":"https://api.github.com/users/Codeception","html_url":"https://github.com/Codeception","followers_url":"https://api.github.com/users/Codeception/followers","following_url":"https://api.github.com/users/Codeception/following{/other_user}","gists_url":"https://api.github.com/users/Codeception/gists{/gist_id}","starred_url":"https://api.github.com/users/Codeception/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Codeception/subscriptions","organizations_url":"https://api.github.com/users/Codeception/orgs","repos_url":"https://api.github.com/users/Codeception/repos","events_url":"https://api.github.com/users/Codeception/events{/privacy}","received_events_url":"https://api.github.com/users/Codeception/received_events","type":"Organization","site_admin":false},"repo":{"id":2880469,"name":"Codeception","full_name":"Codeception/Codeception","owner":{"login":"Codeception","id":1288753,"avatar_url":"https://avatars.githubusercontent.com/u/1288753?v=3","gravatar_id":"","url":"https://api.github.com/users/Codeception","html_url":"https://github.com/Codeception","followers_url":"https://api.github.com/users/Codeception/followers","following_url":"https://api.github.com/users/Codeception/following{/other_user}","gists_url":"https://api.github.com/users/Codeception/gists{/gist_id}","starred_url":"https://api.github.com/users/Codeception/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Codeception/subscriptions","organizations_url":"https://api.github.com/users/Codeception/orgs","repos_url":"https://api.github.com/users/Codeception/repos","events_url":"https://api.github.com/users/Codeception/events{/privacy}","received_events_url":"https://api.github.com/users/Codeception/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Codeception/Codeception","description":"Full-stack testing PHP framework","fork":false,"url":"https://api.github.com/repos/Codeception/Codeception","forks_url":"https://api.github.com/repos/Codeception/Codeception/forks","keys_url":"https://api.github.com/repos/Codeception/Codeception/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Codeception/Codeception/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Codeception/Codeception/teams","hooks_url":"https://api.github.com/repos/Codeception/Codeception/hooks","issue_events_url":"https://api.github.com/repos/Codeception/Codeception/issues/events{/number}","events_url":"https://api.github.com/repos/Codeception/Codeception/events","assignees_url":"https://api.github.com/repos/Codeception/Codeception/assignees{/user}","branches_url":"https://api.github.com/repos/Codeception/Codeception/branches{/branch}","tags_url":"https://api.github.com/repos/Codeception/Codeception/tags","blobs_url":"https://api.github.com/repos/Codeception/Codeception/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Codeception/Codeception/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Codeception/Codeception/git/refs{/sha}","trees_url":"https://api.github.com/repos/Codeception/Codeception/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Codeception/Codeception/statuses/{sha}","languages_url":"https://api.github.com/repos/Codeception/Codeception/languages","stargazers_url":"https://api.github.com/repos/Codeception/Codeception/stargazers","contributors_url":"https://api.github.com/repos/Codeception/Codeception/contributors","subscribers_url":"https://api.github.com/repos/Codeception/Codeception/subscribers","subscription_url":"https://api.github.com/repos/Codeception/Codeception/subscription","commits_url":"https://api.github.com/repos/Codeception/Codeception/commits{/sha}","git_commits_url":"https://api.github.com/repos/Codeception/Codeception/git/commits{/sha}","comments_url":"https://api.github.com/repos/Codeception/Codeception/comments{/number}","issue_comment_url":"https://api.github.com/repos/Codeception/Codeception/issues/comments{/number}","contents_url":"https://api.github.com/repos/Codeception/Codeception/contents/{+path}","compare_url":"https://api.github.com/repos/Codeception/Codeception/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Codeception/Codeception/merges","archive_url":"https://api.github.com/repos/Codeception/Codeception/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Codeception/Codeception/downloads","issues_url":"https://api.github.com/repos/Codeception/Codeception/issues{/number}","pulls_url":"https://api.github.com/repos/Codeception/Codeception/pulls{/number}","milestones_url":"https://api.github.com/repos/Codeception/Codeception/milestones{/number}","notifications_url":"https://api.github.com/repos/Codeception/Codeception/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Codeception/Codeception/labels{/name}","releases_url":"https://api.github.com/repos/Codeception/Codeception/releases{/id}","created_at":"2011-11-30T04:06:44Z","updated_at":"2015-02-23T14:19:52Z","pushed_at":"2015-02-23T14:19:52Z","git_url":"git://github.com/Codeception/Codeception.git","ssh_url":"git@github.com:Codeception/Codeception.git","clone_url":"https://github.com/Codeception/Codeception.git","svn_url":"https://github.com/Codeception/Codeception","homepage":"http://codeception.com","size":62405,"stargazers_count":1324,"watchers_count":1324,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":509,"mirror_url":null,"open_issues_count":181,"forks":509,"open_issues":181,"watchers":1324,"default_branch":"2.0"}},"_links":{"self":{"href":"https://api.github.com/repos/Codeception/Codeception/pulls/1738"},"html":{"href":"https://github.com/Codeception/Codeception/pull/1738"},"issue":{"href":"https://api.github.com/repos/Codeception/Codeception/issues/1738"},"comments":{"href":"https://api.github.com/repos/Codeception/Codeception/issues/1738/comments"},"review_comments":{"href":"https://api.github.com/repos/Codeception/Codeception/pulls/1738/comments"},"review_comment":{"href":"https://api.github.com/repos/Codeception/Codeception/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Codeception/Codeception/pulls/1738/commits"},"statuses":{"href":"https://api.github.com/repos/Codeception/Codeception/statuses/a2ba0bc80d0fab73e80f611cad06e5a061dea3a3"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":6,"deletions":6,"changed_files":1}}