{"action":"created","comment":{"url":"https://api.github.com/repos/kripken/emscripten-fastcomp/pulls/comments/26212352","id":26212352,"diff_hunk":"@@ -407,19 +407,25 @@ void AllocaManager::computeFrameOffsets() {\n   for (SmallVectorImpl<AllocaInfo>::const_iterator I = SortedAllocas.begin(),\n        E = SortedAllocas.end(); I != E; ++I) {\n     const AllocaInfo &Info = *I;\n-    uint64_t NewOffset = RoundUpToAlignment(CurrentOffset, Info.getAlignment());\n+    const AllocaInst *AI = Info.getInst();\n+\n+    // Skip any allocas that have been nativized\n+    if (nativizedVars.count(AI)) {\n+      StaticAllocas[AI] = StaticAllocation(AI, false);","path":"lib/Target/JSBackend/AllocaManager.cpp","position":18,"original_position":18,"commit_id":"22acf5731294374ffec1f4ae9cca3130799d8d9b","original_commit_id":"22acf5731294374ffec1f4ae9cca3130799d8d9b","user":{"login":"sunfishcode","id":4503403,"avatar_url":"https://avatars.githubusercontent.com/u/4503403?v=3","gravatar_id":"","url":"https://api.github.com/users/sunfishcode","html_url":"https://github.com/sunfishcode","followers_url":"https://api.github.com/users/sunfishcode/followers","following_url":"https://api.github.com/users/sunfishcode/following{/other_user}","gists_url":"https://api.github.com/users/sunfishcode/gists{/gist_id}","starred_url":"https://api.github.com/users/sunfishcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunfishcode/subscriptions","organizations_url":"https://api.github.com/users/sunfishcode/orgs","repos_url":"https://api.github.com/users/sunfishcode/repos","events_url":"https://api.github.com/users/sunfishcode/events{/privacy}","received_events_url":"https://api.github.com/users/sunfishcode/received_events","type":"User","site_admin":false},"body":"Would it be possible to avoid creating sentinal StaticAllocation instances for nativized allocas? If there's code that's looking up allocas in StaticAllocas, it could possibly filter out nativized allocas before doing so.","created_at":"2015-03-11T13:45:07Z","updated_at":"2015-03-11T13:45:07Z","html_url":"https://github.com/kripken/emscripten-fastcomp/pull/66#discussion_r26212352","pull_request_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/pulls/66","_links":{"self":{"href":"https://api.github.com/repos/kripken/emscripten-fastcomp/pulls/comments/26212352"},"html":{"href":"https://github.com/kripken/emscripten-fastcomp/pull/66#discussion_r26212352"},"pull_request":{"href":"https://api.github.com/repos/kripken/emscripten-fastcomp/pulls/66"}}},"pull_request":{"url":"https://api.github.com/repos/kripken/emscripten-fastcomp/pulls/66","id":30905469,"html_url":"https://github.com/kripken/emscripten-fastcomp/pull/66","diff_url":"https://github.com/kripken/emscripten-fastcomp/pull/66.diff","patch_url":"https://github.com/kripken/emscripten-fastcomp/pull/66.patch","issue_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/issues/66","number":66,"state":"open","locked":false,"title":"Nativized variables shouldn't consume stack space.","user":{"login":"waywardmonkeys","id":178582,"avatar_url":"https://avatars.githubusercontent.com/u/178582?v=3","gravatar_id":"","url":"https://api.github.com/users/waywardmonkeys","html_url":"https://github.com/waywardmonkeys","followers_url":"https://api.github.com/users/waywardmonkeys/followers","following_url":"https://api.github.com/users/waywardmonkeys/following{/other_user}","gists_url":"https://api.github.com/users/waywardmonkeys/gists{/gist_id}","starred_url":"https://api.github.com/users/waywardmonkeys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waywardmonkeys/subscriptions","organizations_url":"https://api.github.com/users/waywardmonkeys/orgs","repos_url":"https://api.github.com/users/waywardmonkeys/repos","events_url":"https://api.github.com/users/waywardmonkeys/events{/privacy}","received_events_url":"https://api.github.com/users/waywardmonkeys/received_events","type":"User","site_admin":false},"body":"Prior to this change, whether or not a variable had been \"nativized\"\r\nwasn't taken into account when calculating the static space required\r\nfor the frame.\r\n\r\nNow, they aren't included in that and a minor safety measure is taken\r\nto ensure that the frame offset of a nativized variable isn't requested.\r\n\r\nAdditionally, the logic for skipping a stack restoration no longer\r\nemits a stack restore when only nativized variables are present within\r\nthe frame.","created_at":"2015-03-11T00:12:36Z","updated_at":"2015-03-11T13:45:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42cf60c5093a14deb91603fefbc8f395758f735c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/pulls/66/commits","review_comments_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/pulls/66/comments","review_comment_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/issues/66/comments","statuses_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/statuses/22acf5731294374ffec1f4ae9cca3130799d8d9b","head":{"label":"waywardmonkeys:no-stack-slot-for-nativized","ref":"no-stack-slot-for-nativized","sha":"22acf5731294374ffec1f4ae9cca3130799d8d9b","user":{"login":"waywardmonkeys","id":178582,"avatar_url":"https://avatars.githubusercontent.com/u/178582?v=3","gravatar_id":"","url":"https://api.github.com/users/waywardmonkeys","html_url":"https://github.com/waywardmonkeys","followers_url":"https://api.github.com/users/waywardmonkeys/followers","following_url":"https://api.github.com/users/waywardmonkeys/following{/other_user}","gists_url":"https://api.github.com/users/waywardmonkeys/gists{/gist_id}","starred_url":"https://api.github.com/users/waywardmonkeys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waywardmonkeys/subscriptions","organizations_url":"https://api.github.com/users/waywardmonkeys/orgs","repos_url":"https://api.github.com/users/waywardmonkeys/repos","events_url":"https://api.github.com/users/waywardmonkeys/events{/privacy}","received_events_url":"https://api.github.com/users/waywardmonkeys/received_events","type":"User","site_admin":false},"repo":{"id":15736769,"name":"emscripten-fastcomp","full_name":"waywardmonkeys/emscripten-fastcomp","owner":{"login":"waywardmonkeys","id":178582,"avatar_url":"https://avatars.githubusercontent.com/u/178582?v=3","gravatar_id":"","url":"https://api.github.com/users/waywardmonkeys","html_url":"https://github.com/waywardmonkeys","followers_url":"https://api.github.com/users/waywardmonkeys/followers","following_url":"https://api.github.com/users/waywardmonkeys/following{/other_user}","gists_url":"https://api.github.com/users/waywardmonkeys/gists{/gist_id}","starred_url":"https://api.github.com/users/waywardmonkeys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waywardmonkeys/subscriptions","organizations_url":"https://api.github.com/users/waywardmonkeys/orgs","repos_url":"https://api.github.com/users/waywardmonkeys/repos","events_url":"https://api.github.com/users/waywardmonkeys/events{/privacy}","received_events_url":"https://api.github.com/users/waywardmonkeys/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/waywardmonkeys/emscripten-fastcomp","description":"","fork":true,"url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp","forks_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/forks","keys_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/teams","hooks_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/hooks","issue_events_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/issues/events{/number}","events_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/events","assignees_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/assignees{/user}","branches_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/branches{/branch}","tags_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/tags","blobs_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/git/refs{/sha}","trees_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/statuses/{sha}","languages_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/languages","stargazers_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/stargazers","contributors_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/contributors","subscribers_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/subscribers","subscription_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/subscription","commits_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/commits{/sha}","git_commits_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/git/commits{/sha}","comments_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/comments{/number}","issue_comment_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/issues/comments{/number}","contents_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/contents/{+path}","compare_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/merges","archive_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/downloads","issues_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/issues{/number}","pulls_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/pulls{/number}","milestones_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/milestones{/number}","notifications_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/labels{/name}","releases_url":"https://api.github.com/repos/waywardmonkeys/emscripten-fastcomp/releases{/id}","created_at":"2014-01-08T13:55:43Z","updated_at":"2015-03-07T01:00:13Z","pushed_at":"2015-03-11T00:10:10Z","git_url":"git://github.com/waywardmonkeys/emscripten-fastcomp.git","ssh_url":"git@github.com:waywardmonkeys/emscripten-fastcomp.git","clone_url":"https://github.com/waywardmonkeys/emscripten-fastcomp.git","svn_url":"https://github.com/waywardmonkeys/emscripten-fastcomp","homepage":null,"size":132876,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kripken:incoming","ref":"incoming","sha":"13334fab4b7d7e92c57dec189004f5db59301ebe","user":{"login":"kripken","id":173661,"avatar_url":"https://avatars.githubusercontent.com/u/173661?v=3","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"repo":{"id":14601190,"name":"emscripten-fastcomp","full_name":"kripken/emscripten-fastcomp","owner":{"login":"kripken","id":173661,"avatar_url":"https://avatars.githubusercontent.com/u/173661?v=3","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kripken/emscripten-fastcomp","description":"emscripten llvm","fork":false,"url":"https://api.github.com/repos/kripken/emscripten-fastcomp","forks_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/forks","keys_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/teams","hooks_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/hooks","issue_events_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/issues/events{/number}","events_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/events","assignees_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/assignees{/user}","branches_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/branches{/branch}","tags_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/tags","blobs_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/git/refs{/sha}","trees_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/statuses/{sha}","languages_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/languages","stargazers_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/stargazers","contributors_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/contributors","subscribers_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/subscribers","subscription_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/subscription","commits_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/commits{/sha}","git_commits_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/git/commits{/sha}","comments_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/comments{/number}","issue_comment_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/issues/comments{/number}","contents_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/contents/{+path}","compare_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/merges","archive_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/downloads","issues_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/issues{/number}","pulls_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/pulls{/number}","milestones_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/milestones{/number}","notifications_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/labels{/name}","releases_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/releases{/id}","created_at":"2013-11-21T21:54:33Z","updated_at":"2015-03-09T20:03:50Z","pushed_at":"2015-03-11T00:22:17Z","git_url":"git://github.com/kripken/emscripten-fastcomp.git","ssh_url":"git@github.com:kripken/emscripten-fastcomp.git","clone_url":"https://github.com/kripken/emscripten-fastcomp.git","svn_url":"https://github.com/kripken/emscripten-fastcomp","homepage":"","size":202416,"stargazers_count":40,"watchers_count":40,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":14,"forks":29,"open_issues":14,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kripken/emscripten-fastcomp/pulls/66"},"html":{"href":"https://github.com/kripken/emscripten-fastcomp/pull/66"},"issue":{"href":"https://api.github.com/repos/kripken/emscripten-fastcomp/issues/66"},"comments":{"href":"https://api.github.com/repos/kripken/emscripten-fastcomp/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/kripken/emscripten-fastcomp/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/kripken/emscripten-fastcomp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kripken/emscripten-fastcomp/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/kripken/emscripten-fastcomp/statuses/22acf5731294374ffec1f4ae9cca3130799d8d9b"}}}}