{"action":"created","issue":{"url":"https://api.github.com/repos/phildawes/racer/issues/262","labels_url":"https://api.github.com/repos/phildawes/racer/issues/262/labels{/name}","comments_url":"https://api.github.com/repos/phildawes/racer/issues/262/comments","events_url":"https://api.github.com/repos/phildawes/racer/issues/262/events","html_url":"https://github.com/phildawes/racer/pull/262","id":84636286,"number":262,"title":"Clean nameres","user":{"login":"tafia","id":7351502,"avatar_url":"https://avatars.githubusercontent.com/u/7351502?v=3","gravatar_id":"","url":"https://api.github.com/users/tafia","html_url":"https://github.com/tafia","followers_url":"https://api.github.com/users/tafia/followers","following_url":"https://api.github.com/users/tafia/following{/other_user}","gists_url":"https://api.github.com/users/tafia/gists{/gist_id}","starred_url":"https://api.github.com/users/tafia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tafia/subscriptions","organizations_url":"https://api.github.com/users/tafia/orgs","repos_url":"https://api.github.com/users/tafia/repos","events_url":"https://api.github.com/users/tafia/events{/privacy}","received_events_url":"https://api.github.com/users/tafia/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-06-03T15:57:05Z","updated_at":"2015-06-04T07:55:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/phildawes/racer/pulls/262","html_url":"https://github.com/phildawes/racer/pull/262","diff_url":"https://github.com/phildawes/racer/pull/262.diff","patch_url":"https://github.com/phildawes/racer/pull/262.patch"},"body":"Lot of changes to *nameres.rs*.\r\nI have splitted all commits so I can probably revert the ones you don't like.\r\n\r\nMain changes are:\r\n- add constructors for `Match` and `PathSegment`\r\n- use more iterator constructs, with the benefits:\r\n  - do not check for `ExactMatch` for each item\r\n  - use extend whenever possible\r\n  - sometimes do not even create intermediary vector, just return the existing `vec::IntoIter`\r\n  - most of the time, it is shorter. It looks easier to read for me\r\n\r\n\r\nI haven't modified the biggest function `search_scope` because the alternatives I found didn't look good.\r\n\r\nIf needed I can squash it."},"comment":{"url":"https://api.github.com/repos/phildawes/racer/issues/comments/108770923","html_url":"https://github.com/phildawes/racer/pull/262#issuecomment-108770923","issue_url":"https://api.github.com/repos/phildawes/racer/issues/262","id":108770923,"user":{"login":"tafia","id":7351502,"avatar_url":"https://avatars.githubusercontent.com/u/7351502?v=3","gravatar_id":"","url":"https://api.github.com/users/tafia","html_url":"https://github.com/tafia","followers_url":"https://api.github.com/users/tafia/followers","following_url":"https://api.github.com/users/tafia/following{/other_user}","gists_url":"https://api.github.com/users/tafia/gists{/gist_id}","starred_url":"https://api.github.com/users/tafia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tafia/subscriptions","organizations_url":"https://api.github.com/users/tafia/orgs","repos_url":"https://api.github.com/users/tafia/repos","events_url":"https://api.github.com/users/tafia/events{/privacy}","received_events_url":"https://api.github.com/users/tafia/received_events","type":"User","site_admin":false},"created_at":"2015-06-04T07:55:10Z","updated_at":"2015-06-04T07:55:10Z","body":"No pressure !\nOn 4 Jun 2015 12:58, \"Phil Dawes\" <notifications@github.com> wrote:\n\n> Wow thanks @tafia <https://github.com/tafia>! It's going to take me a\n> while to go through these but from an initial glance through the commits\n> these changes look good.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/phildawes/racer/pull/262#issuecomment-108722035>.\n>\n"}}