{"action":"created","comment":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/40539934","id":40539934,"diff_hunk":"@@ -109,9 +109,18 @@\n         except:\n             res = 'QVariant API v2 specification failed. Defaulting to v1.'\n             verbose.report(cond + res, 'helpful')\n+    if QT_API == QT_API_PYQT5:\n+        try:\n+            from PyQt5 import QtCore, QtGui, QtWidgets\n+            _getSaveFileName = QtWidgets.QFileDialog.getSaveFileName\n+        except ImportError:\n+            # fell through, tried PyQt5, failed fall back to PyQt4\n+            QT_API = rcParams['backend.qt4']","path":"lib/matplotlib/backends/qt_compat.py","position":10,"original_position":10,"commit_id":"9a7a14821bada76ab1255099a6ce82067c8a2309","original_commit_id":"9a7a14821bada76ab1255099a6ce82067c8a2309","user":{"login":"jenshnielsen","id":548266,"avatar_url":"https://avatars.githubusercontent.com/u/548266?v=3","gravatar_id":"","url":"https://api.github.com/users/jenshnielsen","html_url":"https://github.com/jenshnielsen","followers_url":"https://api.github.com/users/jenshnielsen/followers","following_url":"https://api.github.com/users/jenshnielsen/following{/other_user}","gists_url":"https://api.github.com/users/jenshnielsen/gists{/gist_id}","starred_url":"https://api.github.com/users/jenshnielsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenshnielsen/subscriptions","organizations_url":"https://api.github.com/users/jenshnielsen/orgs","repos_url":"https://api.github.com/users/jenshnielsen/repos","events_url":"https://api.github.com/users/jenshnielsen/events{/privacy}","received_events_url":"https://api.github.com/users/jenshnielsen/received_events","type":"User","site_admin":false},"body":"Ok fair enough","created_at":"2015-09-28T10:59:29Z","updated_at":"2015-09-28T10:59:29Z","html_url":"https://github.com/matplotlib/matplotlib/pull/5153#discussion_r40539934","pull_request_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/5153","_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/40539934"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/5153#discussion_r40539934"},"pull_request":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/5153"}}},"pull_request":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/5153","id":46094967,"html_url":"https://github.com/matplotlib/matplotlib/pull/5153","diff_url":"https://github.com/matplotlib/matplotlib/pull/5153.diff","patch_url":"https://github.com/matplotlib/matplotlib/pull/5153.patch","issue_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/5153","number":5153,"state":"open","locked":false,"title":"MNT: more minor tweaks to qt_compat.py","user":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars.githubusercontent.com/u/199813?v=3","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"body":"If we the backend is not a Qt* backend, a version of pyqt has not been\r\nimported and PyQt5 is not installed qt_compat would raise as\r\nImportError.  Now it will gracefully fall back to PyQt4.\r\n\r\nattn @jrevans @mfitzp ","created_at":"2015-09-27T04:16:48Z","updated_at":"2015-09-28T10:59:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3337868d0e2eb437186a8efb5e0d0e57f51d8ae","assignee":null,"milestone":{"url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/18","html_url":"https://github.com/matplotlib/matplotlib/milestones/next%20point%20release%20(1.5.0)","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/18/labels","id":970105,"number":18,"title":"next point release (1.5.0)","description":"Next minor release.","creator":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars.githubusercontent.com/u/199813?v=3","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":355,"state":"open","created_at":"2015-02-07T21:22:30Z","updated_at":"2015-09-27T04:16:48Z","due_on":"2015-09-30T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/5153/commits","review_comments_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/5153/comments","review_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/5153/comments","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/9a7a14821bada76ab1255099a6ce82067c8a2309","head":{"label":"tacaswell:mnt_qt_compat_again","ref":"mnt_qt_compat_again","sha":"9a7a14821bada76ab1255099a6ce82067c8a2309","user":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars.githubusercontent.com/u/199813?v=3","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"repo":{"id":5345572,"name":"matplotlib","full_name":"tacaswell/matplotlib","owner":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars.githubusercontent.com/u/199813?v=3","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tacaswell/matplotlib","description":"","fork":true,"url":"https://api.github.com/repos/tacaswell/matplotlib","forks_url":"https://api.github.com/repos/tacaswell/matplotlib/forks","keys_url":"https://api.github.com/repos/tacaswell/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tacaswell/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tacaswell/matplotlib/teams","hooks_url":"https://api.github.com/repos/tacaswell/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/tacaswell/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/tacaswell/matplotlib/events","assignees_url":"https://api.github.com/repos/tacaswell/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/tacaswell/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/tacaswell/matplotlib/tags","blobs_url":"https://api.github.com/repos/tacaswell/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tacaswell/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tacaswell/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/tacaswell/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tacaswell/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/tacaswell/matplotlib/languages","stargazers_url":"https://api.github.com/repos/tacaswell/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/tacaswell/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/tacaswell/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/tacaswell/matplotlib/subscription","commits_url":"https://api.github.com/repos/tacaswell/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/tacaswell/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/tacaswell/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/tacaswell/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/tacaswell/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/tacaswell/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tacaswell/matplotlib/merges","archive_url":"https://api.github.com/repos/tacaswell/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tacaswell/matplotlib/downloads","issues_url":"https://api.github.com/repos/tacaswell/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/tacaswell/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/tacaswell/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/tacaswell/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tacaswell/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/tacaswell/matplotlib/releases{/id}","created_at":"2012-08-08T18:19:38Z","updated_at":"2015-05-08T04:25:14Z","pushed_at":"2015-09-27T20:17:05Z","git_url":"git://github.com/tacaswell/matplotlib.git","ssh_url":"git@github.com:tacaswell/matplotlib.git","clone_url":"https://github.com/tacaswell/matplotlib.git","svn_url":"https://github.com/tacaswell/matplotlib","homepage":"","size":222496,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"matplotlib:master","ref":"master","sha":"0037595096e3be3ec863f3e3008e73c469e2f2b8","user":{"login":"matplotlib","id":215947,"avatar_url":"https://avatars.githubusercontent.com/u/215947?v=3","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"repo":{"id":1385122,"name":"matplotlib","full_name":"matplotlib/matplotlib","owner":{"login":"matplotlib","id":215947,"avatar_url":"https://avatars.githubusercontent.com/u/215947?v=3","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matplotlib/matplotlib","description":"matplotlib: plotting with Python","fork":false,"url":"https://api.github.com/repos/matplotlib/matplotlib","forks_url":"https://api.github.com/repos/matplotlib/matplotlib/forks","keys_url":"https://api.github.com/repos/matplotlib/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matplotlib/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matplotlib/matplotlib/teams","hooks_url":"https://api.github.com/repos/matplotlib/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/matplotlib/matplotlib/events","assignees_url":"https://api.github.com/repos/matplotlib/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/matplotlib/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/matplotlib/matplotlib/tags","blobs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matplotlib/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/matplotlib/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/matplotlib/matplotlib/languages","stargazers_url":"https://api.github.com/repos/matplotlib/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/matplotlib/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/matplotlib/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/matplotlib/matplotlib/subscription","commits_url":"https://api.github.com/repos/matplotlib/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/matplotlib/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/matplotlib/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/matplotlib/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matplotlib/matplotlib/merges","archive_url":"https://api.github.com/repos/matplotlib/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matplotlib/matplotlib/downloads","issues_url":"https://api.github.com/repos/matplotlib/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/matplotlib/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/matplotlib/matplotlib/releases{/id}","created_at":"2011-02-19T03:17:12Z","updated_at":"2015-09-28T09:44:43Z","pushed_at":"2015-09-28T10:01:39Z","git_url":"git://github.com/matplotlib/matplotlib.git","ssh_url":"git@github.com:matplotlib/matplotlib.git","clone_url":"https://github.com/matplotlib/matplotlib.git","svn_url":"https://github.com/matplotlib/matplotlib","homepage":"http://matplotlib.org/","size":278130,"stargazers_count":2861,"watchers_count":2861,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1464,"mirror_url":null,"open_issues_count":656,"forks":1464,"open_issues":656,"watchers":2861,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/5153"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/5153"},"issue":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/5153"},"comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/5153/comments"},"review_comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/5153/comments"},"review_comment":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/5153/commits"},"statuses":{"href":"https://api.github.com/repos/matplotlib/matplotlib/statuses/9a7a14821bada76ab1255099a6ce82067c8a2309"}}}}