{"action":"created","issue":{"url":"https://api.github.com/repos/ajgilbert/ICAnalysis-ElectronConversionCalculator/issues/2","labels_url":"https://api.github.com/repos/ajgilbert/ICAnalysis-ElectronConversionCalculator/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/ajgilbert/ICAnalysis-ElectronConversionCalculator/issues/2/comments","events_url":"https://api.github.com/repos/ajgilbert/ICAnalysis-ElectronConversionCalculator/issues/2/events","html_url":"https://github.com/ajgilbert/ICAnalysis-ElectronConversionCalculator/pull/2","id":70953868,"number":2,"title":"ValueMap creation from reco::GsfElectron or pat::Electron","user":{"login":"ajgilbert","id":1001931,"avatar_url":"https://avatars.githubusercontent.com/u/1001931?v=3","gravatar_id":"","url":"https://api.github.com/users/ajgilbert","html_url":"https://github.com/ajgilbert","followers_url":"https://api.github.com/users/ajgilbert/followers","following_url":"https://api.github.com/users/ajgilbert/following{/other_user}","gists_url":"https://api.github.com/users/ajgilbert/gists{/gist_id}","starred_url":"https://api.github.com/users/ajgilbert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajgilbert/subscriptions","organizations_url":"https://api.github.com/users/ajgilbert/orgs","repos_url":"https://api.github.com/users/ajgilbert/repos","events_url":"https://api.github.com/users/ajgilbert/events{/privacy}","received_events_url":"https://api.github.com/users/ajgilbert/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-25T19:02:00Z","updated_at":"2015-04-26T14:58:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ajgilbert/ICAnalysis-ElectronConversionCalculator/pulls/2","html_url":"https://github.com/ajgilbert/ICAnalysis-ElectronConversionCalculator/pull/2","diff_url":"https://github.com/ajgilbert/ICAnalysis-ElectronConversionCalculator/pull/2.diff","patch_url":"https://github.com/ajgilbert/ICAnalysis-ElectronConversionCalculator/pull/2.patch"},"body":" - To work on either type we need to use an edm::View\r\n - But an edm::View can point to a RefVector which will give an invalid ValueMap\r\n - Work around this by creating an edm::RefToBaseProd (basically a View onto the\r\n   original collection) and use this instead"},"comment":{"url":"https://api.github.com/repos/ajgilbert/ICAnalysis-ElectronConversionCalculator/issues/comments/96394156","html_url":"https://github.com/ajgilbert/ICAnalysis-ElectronConversionCalculator/pull/2#issuecomment-96394156","issue_url":"https://api.github.com/repos/ajgilbert/ICAnalysis-ElectronConversionCalculator/issues/2","id":96394156,"user":{"login":"ajgilbert","id":1001931,"avatar_url":"https://avatars.githubusercontent.com/u/1001931?v=3","gravatar_id":"","url":"https://api.github.com/users/ajgilbert","html_url":"https://github.com/ajgilbert","followers_url":"https://api.github.com/users/ajgilbert/followers","following_url":"https://api.github.com/users/ajgilbert/following{/other_user}","gists_url":"https://api.github.com/users/ajgilbert/gists{/gist_id}","starred_url":"https://api.github.com/users/ajgilbert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajgilbert/subscriptions","organizations_url":"https://api.github.com/users/ajgilbert/orgs","repos_url":"https://api.github.com/users/ajgilbert/repos","events_url":"https://api.github.com/users/ajgilbert/events{/privacy}","received_events_url":"https://api.github.com/users/ajgilbert/received_events","type":"User","site_admin":false},"created_at":"2015-04-26T14:58:04Z","updated_at":"2015-04-26T14:58:04Z","body":"Hi @adewit, @rcl11 -  regarding #1 I think I've found a solution  that lets us use an edm:View<GsfElectron> safely instead of a concrete vector<GsfElectron>, thereby allowing the module to work on pat::Electrons too. I put some technical details as comments in the code. Assuming this compiles ok in all the releases (i'll check tomorrow) I don't see a barrier to copying these plugins back into the main repo and deleting this one"}}