{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/36685588","id":36685588,"diff_hunk":"@@ -415,13 +415,19 @@ func (s *APIServer) Run(_ []string) error {\n \t}\n \n \tlongRunningRE := regexp.MustCompile(s.LongRunningRequestRE)\n+\tlongRunningTimeout := func(req *http.Request) (<-chan time.Time, string) {\n+\t\t// TODO unify this with apiserver.MaxInFlightLimit\n+\t\tif longRunningRE.MatchString(req.URL.Path) || req.URL.Query().Get(\"watch\") == \"true\" {\n+\t\t\treturn nil, \"\"","path":"cmd/kube-apiserver/app/server.go","position":7,"original_position":7,"commit_id":"1d033b99123311e47057c0be83b0b77899008488","original_commit_id":"1d033b99123311e47057c0be83b0b77899008488","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"does this make long-running requests of unlimited duration?","created_at":"2015-08-10T21:15:19Z","updated_at":"2015-08-10T21:15:19Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/10656#discussion_r36685588","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10656","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/36685588"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/10656#discussion_r36685588"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10656"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10656","id":39037670,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/10656","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/10656.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/10656.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/10656","number":10656,"state":"closed","locked":false,"title":"Adding proper timeouts.","user":{"login":"krousey","id":157083,"avatar_url":"https://avatars.githubusercontent.com/u/157083?v=3","gravatar_id":"","url":"https://api.github.com/users/krousey","html_url":"https://github.com/krousey","followers_url":"https://api.github.com/users/krousey/followers","following_url":"https://api.github.com/users/krousey/following{/other_user}","gists_url":"https://api.github.com/users/krousey/gists{/gist_id}","starred_url":"https://api.github.com/users/krousey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krousey/subscriptions","organizations_url":"https://api.github.com/users/krousey/orgs","repos_url":"https://api.github.com/users/krousey/repos","events_url":"https://api.github.com/users/krousey/events{/privacy}","received_events_url":"https://api.github.com/users/krousey/received_events","type":"User","site_admin":false},"body":"An attempt to properly fix #9013 and #9180. \r\n\r\ncc @bgrant0607 @thockin ","created_at":"2015-07-02T00:11:55Z","updated_at":"2015-08-10T21:15:19Z","closed_at":"2015-07-27T08:56:58Z","merged_at":"2015-07-27T08:56:58Z","merge_commit_sha":"4511b34fdb67639bf9c28a1d3b66e4f0cbcec064","assignee":{"login":"brendandburns","id":5751682,"avatar_url":"https://avatars.githubusercontent.com/u/5751682?v=3","gravatar_id":"","url":"https://api.github.com/users/brendandburns","html_url":"https://github.com/brendandburns","followers_url":"https://api.github.com/users/brendandburns/followers","following_url":"https://api.github.com/users/brendandburns/following{/other_user}","gists_url":"https://api.github.com/users/brendandburns/gists{/gist_id}","starred_url":"https://api.github.com/users/brendandburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendandburns/subscriptions","organizations_url":"https://api.github.com/users/brendandburns/orgs","repos_url":"https://api.github.com/users/brendandburns/repos","events_url":"https://api.github.com/users/brendandburns/events{/privacy}","received_events_url":"https://api.github.com/users/brendandburns/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10656/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10656/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/10656/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/1d033b99123311e47057c0be83b0b77899008488","head":{"label":"krousey:timeouts","ref":"timeouts","sha":"1d033b99123311e47057c0be83b0b77899008488","user":{"login":"krousey","id":157083,"avatar_url":"https://avatars.githubusercontent.com/u/157083?v=3","gravatar_id":"","url":"https://api.github.com/users/krousey","html_url":"https://github.com/krousey","followers_url":"https://api.github.com/users/krousey/followers","following_url":"https://api.github.com/users/krousey/following{/other_user}","gists_url":"https://api.github.com/users/krousey/gists{/gist_id}","starred_url":"https://api.github.com/users/krousey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krousey/subscriptions","organizations_url":"https://api.github.com/users/krousey/orgs","repos_url":"https://api.github.com/users/krousey/repos","events_url":"https://api.github.com/users/krousey/events{/privacy}","received_events_url":"https://api.github.com/users/krousey/received_events","type":"User","site_admin":false},"repo":{"id":33140890,"name":"kubernetes","full_name":"krousey/kubernetes","owner":{"login":"krousey","id":157083,"avatar_url":"https://avatars.githubusercontent.com/u/157083?v=3","gravatar_id":"","url":"https://api.github.com/users/krousey","html_url":"https://github.com/krousey","followers_url":"https://api.github.com/users/krousey/followers","following_url":"https://api.github.com/users/krousey/following{/other_user}","gists_url":"https://api.github.com/users/krousey/gists{/gist_id}","starred_url":"https://api.github.com/users/krousey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krousey/subscriptions","organizations_url":"https://api.github.com/users/krousey/orgs","repos_url":"https://api.github.com/users/krousey/repos","events_url":"https://api.github.com/users/krousey/events{/privacy}","received_events_url":"https://api.github.com/users/krousey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krousey/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/krousey/kubernetes","forks_url":"https://api.github.com/repos/krousey/kubernetes/forks","keys_url":"https://api.github.com/repos/krousey/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krousey/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krousey/kubernetes/teams","hooks_url":"https://api.github.com/repos/krousey/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/krousey/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/krousey/kubernetes/events","assignees_url":"https://api.github.com/repos/krousey/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/krousey/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/krousey/kubernetes/tags","blobs_url":"https://api.github.com/repos/krousey/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krousey/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krousey/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/krousey/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krousey/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/krousey/kubernetes/languages","stargazers_url":"https://api.github.com/repos/krousey/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/krousey/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/krousey/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/krousey/kubernetes/subscription","commits_url":"https://api.github.com/repos/krousey/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/krousey/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/krousey/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/krousey/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/krousey/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/krousey/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krousey/kubernetes/merges","archive_url":"https://api.github.com/repos/krousey/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krousey/kubernetes/downloads","issues_url":"https://api.github.com/repos/krousey/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/krousey/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/krousey/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/krousey/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krousey/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/krousey/kubernetes/releases{/id}","created_at":"2015-03-30T18:38:40Z","updated_at":"2015-04-20T21:05:26Z","pushed_at":"2015-08-10T17:52:48Z","git_url":"git://github.com/krousey/kubernetes.git","ssh_url":"git@github.com:krousey/kubernetes.git","clone_url":"https://github.com/krousey/kubernetes.git","svn_url":"https://github.com/krousey/kubernetes","homepage":"http://kubernetes.io","size":100091,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"869df32d00fc56bddaa476d368b74a8c565a015b","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-08-10T20:31:50Z","pushed_at":"2015-08-10T21:15:07Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":340662,"stargazers_count":9613,"watchers_count":9613,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2284,"mirror_url":null,"open_issues_count":1734,"forks":2284,"open_issues":1734,"watchers":9613,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10656"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/10656"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/10656"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/10656/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10656/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10656/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/1d033b99123311e47057c0be83b0b77899008488"}}}}