{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/mysql/pulls/comments/27037890","id":27037890,"diff_hunk":"@@ -34,6 +34,13 @@ The image recognizes following environment variables that you can set during ini\n |  `MYSQL_DATABASE`      | Database name                             |\n |  `MYSQL_ROOT_PASSWORD` | Password for the root user (optional)     |\n \n+Following environment variables influence MySQL configuration file. They are all optional.\n+\n+|    Variable name         |    Description                                                  |    Default\n+| :----------------------- | --------------------------------------------------------------- | -------------------------------\n+|  `MYSQL_MAX_CONNECTIONS` | The maximum permitted number of simultaneous client connections |  151\n+|  `MYSQL_TIME_ZONE`       | The MySQL server default timezone                               |  none\n+","path":"README.md","position":10,"original_position":10,"commit_id":"b23fb441836758932c2196facbd30a78f95ac323","original_commit_id":"b23fb441836758932c2196facbd30a78f95ac323","user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"body":"yeah actually adding the config settings/env variables to the various DB carts should be part of this effort.\r\n","created_at":"2015-03-24T15:21:14Z","updated_at":"2015-03-24T15:21:14Z","html_url":"https://github.com/openshift/mysql/pull/25#discussion_r27037890","pull_request_url":"https://api.github.com/repos/openshift/mysql/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/openshift/mysql/pulls/comments/27037890"},"html":{"href":"https://github.com/openshift/mysql/pull/25#discussion_r27037890"},"pull_request":{"href":"https://api.github.com/repos/openshift/mysql/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/mysql/pulls/25","id":31760396,"html_url":"https://github.com/openshift/mysql/pull/25","diff_url":"https://github.com/openshift/mysql/pull/25.diff","patch_url":"https://github.com/openshift/mysql/pull/25.patch","issue_url":"https://api.github.com/repos/openshift/mysql/issues/25","number":25,"state":"open","locked":false,"title":"Generate configuration file with envsubst","user":{"login":"mnagy","id":72469,"avatar_url":"https://avatars.githubusercontent.com/u/72469?v=3","gravatar_id":"","url":"https://api.github.com/users/mnagy","html_url":"https://github.com/mnagy","followers_url":"https://api.github.com/users/mnagy/followers","following_url":"https://api.github.com/users/mnagy/following{/other_user}","gists_url":"https://api.github.com/users/mnagy/gists{/gist_id}","starred_url":"https://api.github.com/users/mnagy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnagy/subscriptions","organizations_url":"https://api.github.com/users/mnagy/orgs","repos_url":"https://api.github.com/users/mnagy/repos","events_url":"https://api.github.com/users/mnagy/events{/privacy}","received_events_url":"https://api.github.com/users/mnagy/received_events","type":"User","site_admin":false},"body":"This is my first take on https://trello.com/c/NGcr5u20/534-5-database-image-configuration-details-image-beta3\n\nI added two settings from v2 MySQL cartridge. One, `MYSQL_MAX_CONNECTIONS` has a default set and is simply substituted in the config file. The other, `MYSQL_TIME_ZONE` is only used if it set, otherwise a commented entry is added into the config file for clarity.\n\nComments and suggestions are wanted, after this gets merged I'll do the same for PostgreSQL.","created_at":"2015-03-23T18:28:59Z","updated_at":"2015-03-24T15:21:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5f5281cba0aaea76131afa19654af20b8c9d4e9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/mysql/pulls/25/commits","review_comments_url":"https://api.github.com/repos/openshift/mysql/pulls/25/comments","review_comment_url":"https://api.github.com/repos/openshift/mysql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/mysql/issues/25/comments","statuses_url":"https://api.github.com/repos/openshift/mysql/statuses/b23fb441836758932c2196facbd30a78f95ac323","head":{"label":"mnagy:config_customization","ref":"config_customization","sha":"b23fb441836758932c2196facbd30a78f95ac323","user":{"login":"mnagy","id":72469,"avatar_url":"https://avatars.githubusercontent.com/u/72469?v=3","gravatar_id":"","url":"https://api.github.com/users/mnagy","html_url":"https://github.com/mnagy","followers_url":"https://api.github.com/users/mnagy/followers","following_url":"https://api.github.com/users/mnagy/following{/other_user}","gists_url":"https://api.github.com/users/mnagy/gists{/gist_id}","starred_url":"https://api.github.com/users/mnagy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnagy/subscriptions","organizations_url":"https://api.github.com/users/mnagy/orgs","repos_url":"https://api.github.com/users/mnagy/repos","events_url":"https://api.github.com/users/mnagy/events{/privacy}","received_events_url":"https://api.github.com/users/mnagy/received_events","type":"User","site_admin":false},"repo":{"id":31023512,"name":"mysql","full_name":"mnagy/mysql","owner":{"login":"mnagy","id":72469,"avatar_url":"https://avatars.githubusercontent.com/u/72469?v=3","gravatar_id":"","url":"https://api.github.com/users/mnagy","html_url":"https://github.com/mnagy","followers_url":"https://api.github.com/users/mnagy/followers","following_url":"https://api.github.com/users/mnagy/following{/other_user}","gists_url":"https://api.github.com/users/mnagy/gists{/gist_id}","starred_url":"https://api.github.com/users/mnagy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnagy/subscriptions","organizations_url":"https://api.github.com/users/mnagy/orgs","repos_url":"https://api.github.com/users/mnagy/repos","events_url":"https://api.github.com/users/mnagy/events{/privacy}","received_events_url":"https://api.github.com/users/mnagy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mnagy/mysql","description":"","fork":true,"url":"https://api.github.com/repos/mnagy/mysql","forks_url":"https://api.github.com/repos/mnagy/mysql/forks","keys_url":"https://api.github.com/repos/mnagy/mysql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mnagy/mysql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mnagy/mysql/teams","hooks_url":"https://api.github.com/repos/mnagy/mysql/hooks","issue_events_url":"https://api.github.com/repos/mnagy/mysql/issues/events{/number}","events_url":"https://api.github.com/repos/mnagy/mysql/events","assignees_url":"https://api.github.com/repos/mnagy/mysql/assignees{/user}","branches_url":"https://api.github.com/repos/mnagy/mysql/branches{/branch}","tags_url":"https://api.github.com/repos/mnagy/mysql/tags","blobs_url":"https://api.github.com/repos/mnagy/mysql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mnagy/mysql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mnagy/mysql/git/refs{/sha}","trees_url":"https://api.github.com/repos/mnagy/mysql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mnagy/mysql/statuses/{sha}","languages_url":"https://api.github.com/repos/mnagy/mysql/languages","stargazers_url":"https://api.github.com/repos/mnagy/mysql/stargazers","contributors_url":"https://api.github.com/repos/mnagy/mysql/contributors","subscribers_url":"https://api.github.com/repos/mnagy/mysql/subscribers","subscription_url":"https://api.github.com/repos/mnagy/mysql/subscription","commits_url":"https://api.github.com/repos/mnagy/mysql/commits{/sha}","git_commits_url":"https://api.github.com/repos/mnagy/mysql/git/commits{/sha}","comments_url":"https://api.github.com/repos/mnagy/mysql/comments{/number}","issue_comment_url":"https://api.github.com/repos/mnagy/mysql/issues/comments{/number}","contents_url":"https://api.github.com/repos/mnagy/mysql/contents/{+path}","compare_url":"https://api.github.com/repos/mnagy/mysql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mnagy/mysql/merges","archive_url":"https://api.github.com/repos/mnagy/mysql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mnagy/mysql/downloads","issues_url":"https://api.github.com/repos/mnagy/mysql/issues{/number}","pulls_url":"https://api.github.com/repos/mnagy/mysql/pulls{/number}","milestones_url":"https://api.github.com/repos/mnagy/mysql/milestones{/number}","notifications_url":"https://api.github.com/repos/mnagy/mysql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mnagy/mysql/labels{/name}","releases_url":"https://api.github.com/repos/mnagy/mysql/releases{/id}","created_at":"2015-02-19T16:07:22Z","updated_at":"2015-03-09T14:13:35Z","pushed_at":"2015-03-23T18:19:48Z","git_url":"git://github.com/mnagy/mysql.git","ssh_url":"git@github.com:mnagy/mysql.git","clone_url":"https://github.com/mnagy/mysql.git","svn_url":"https://github.com/mnagy/mysql","homepage":null,"size":224,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"8e45e847110c3f537debf5cc3458e33a1f0a2c35","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":31020442,"name":"mysql","full_name":"openshift/mysql","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/mysql","description":"","fork":false,"url":"https://api.github.com/repos/openshift/mysql","forks_url":"https://api.github.com/repos/openshift/mysql/forks","keys_url":"https://api.github.com/repos/openshift/mysql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/mysql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/mysql/teams","hooks_url":"https://api.github.com/repos/openshift/mysql/hooks","issue_events_url":"https://api.github.com/repos/openshift/mysql/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/mysql/events","assignees_url":"https://api.github.com/repos/openshift/mysql/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/mysql/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/mysql/tags","blobs_url":"https://api.github.com/repos/openshift/mysql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/mysql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/mysql/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/mysql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/mysql/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/mysql/languages","stargazers_url":"https://api.github.com/repos/openshift/mysql/stargazers","contributors_url":"https://api.github.com/repos/openshift/mysql/contributors","subscribers_url":"https://api.github.com/repos/openshift/mysql/subscribers","subscription_url":"https://api.github.com/repos/openshift/mysql/subscription","commits_url":"https://api.github.com/repos/openshift/mysql/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/mysql/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/mysql/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/mysql/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/mysql/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/mysql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/mysql/merges","archive_url":"https://api.github.com/repos/openshift/mysql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/mysql/downloads","issues_url":"https://api.github.com/repos/openshift/mysql/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/mysql/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/mysql/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/mysql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/mysql/labels{/name}","releases_url":"https://api.github.com/repos/openshift/mysql/releases{/id}","created_at":"2015-02-19T15:03:58Z","updated_at":"2015-03-23T13:11:17Z","pushed_at":"2015-03-23T18:28:59Z","git_url":"git://github.com/openshift/mysql.git","ssh_url":"git@github.com:openshift/mysql.git","clone_url":"https://github.com/openshift/mysql.git","svn_url":"https://github.com/openshift/mysql","homepage":null,"size":288,"stargazers_count":2,"watchers_count":2,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":5,"forks":6,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/mysql/pulls/25"},"html":{"href":"https://github.com/openshift/mysql/pull/25"},"issue":{"href":"https://api.github.com/repos/openshift/mysql/issues/25"},"comments":{"href":"https://api.github.com/repos/openshift/mysql/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/mysql/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/mysql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/mysql/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/mysql/statuses/b23fb441836758932c2196facbd30a78f95ac323"}}}}