{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/14098","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/14098/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/14098/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/14098/events","html_url":"https://github.com/mantidproject/mantid/pull/14098","id":113035631,"number":14098,"title":"RenameWorkspace algo should rename attached workspace too.","user":{"login":"abuts","id":1109606,"avatar_url":"https://avatars.githubusercontent.com/u/1109606?v=3","gravatar_id":"","url":"https://api.github.com/users/abuts","html_url":"https://github.com/abuts","followers_url":"https://api.github.com/users/abuts/followers","following_url":"https://api.github.com/users/abuts/following{/other_user}","gists_url":"https://api.github.com/users/abuts/gists{/gist_id}","starred_url":"https://api.github.com/users/abuts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abuts/subscriptions","organizations_url":"https://api.github.com/users/abuts/orgs","repos_url":"https://api.github.com/users/abuts/repos","events_url":"https://api.github.com/users/abuts/events{/privacy}","received_events_url":"https://api.github.com/users/abuts/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Framework","name":"Component: Framework","color":"009800"}],"state":"closed","locked":false,"assignee":{"login":"FedeMPouzols","id":5257172,"avatar_url":"https://avatars.githubusercontent.com/u/5257172?v=3","gravatar_id":"","url":"https://api.github.com/users/FedeMPouzols","html_url":"https://github.com/FedeMPouzols","followers_url":"https://api.github.com/users/FedeMPouzols/followers","following_url":"https://api.github.com/users/FedeMPouzols/following{/other_user}","gists_url":"https://api.github.com/users/FedeMPouzols/gists{/gist_id}","starred_url":"https://api.github.com/users/FedeMPouzols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FedeMPouzols/subscriptions","organizations_url":"https://api.github.com/users/FedeMPouzols/orgs","repos_url":"https://api.github.com/users/FedeMPouzols/repos","events_url":"https://api.github.com/users/FedeMPouzols/events{/privacy}","received_events_url":"https://api.github.com/users/FedeMPouzols/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/4","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.6","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/4/labels","id":1106937,"number":4,"title":"Release 3.6","description":"","creator":{"login":"peterfpeterson","id":404003,"avatar_url":"https://avatars.githubusercontent.com/u/404003?v=3","gravatar_id":"","url":"https://api.github.com/users/peterfpeterson","html_url":"https://github.com/peterfpeterson","followers_url":"https://api.github.com/users/peterfpeterson/followers","following_url":"https://api.github.com/users/peterfpeterson/following{/other_user}","gists_url":"https://api.github.com/users/peterfpeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/peterfpeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterfpeterson/subscriptions","organizations_url":"https://api.github.com/users/peterfpeterson/orgs","repos_url":"https://api.github.com/users/peterfpeterson/repos","events_url":"https://api.github.com/users/peterfpeterson/events{/privacy}","received_events_url":"https://api.github.com/users/peterfpeterson/received_events","type":"User","site_admin":false},"open_issues":578,"closed_issues":386,"state":"open","created_at":"2015-05-12T15:36:23Z","updated_at":"2015-11-04T14:36:52Z","due_on":"2016-01-30T05:00:00Z","closed_at":null},"comments":2,"created_at":"2015-10-23T14:52:41Z","updated_at":"2015-11-04T14:38:58Z","closed_at":"2015-11-04T14:28:39Z","pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/14098","html_url":"https://github.com/mantidproject/mantid/pull/14098","diff_url":"https://github.com/mantidproject/mantid/pull/14098.diff","patch_url":"https://github.com/mantidproject/mantid/pull/14098.patch"},"body":"resolves issue #14071 \r\n\r\nTicket's  commits become a bit convoluted as I've done number of rebases splitting one big ticket into parts but the changes here are pretty simple. \r\n\r\nRenameWorkspace algorithm renames monitor workspace too, if one is attached to the workspace being renamed. Unit test for algorithm and python function overload verifies that this indeed happens and doctest for RenameWorkspace modified to reflect the changes.  I believe, unit tests for algorithm clearly shows what changes intended to do. To maintain compatibility with old python interface I have to add the algorithm wrapper to simple API. Python unit test for that verifies wrapper and shows that the changes work as expected. [Release notes](http://www.mantidproject.org/Release_Notes_3_6_Direct_Inelastic) have been modified accordingly. \r\n\r\nI had to modify a bit of python due to Pylint going mad + simple modification to LoadRaw with was not setting monitor workspace pointer while loading workspace separately (some previous version used to), but these are minor deviations. "},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/153746812","html_url":"https://github.com/mantidproject/mantid/pull/14098#issuecomment-153746812","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/14098","id":153746812,"user":{"login":"FedeMPouzols","id":5257172,"avatar_url":"https://avatars.githubusercontent.com/u/5257172?v=3","gravatar_id":"","url":"https://api.github.com/users/FedeMPouzols","html_url":"https://github.com/FedeMPouzols","followers_url":"https://api.github.com/users/FedeMPouzols/followers","following_url":"https://api.github.com/users/FedeMPouzols/following{/other_user}","gists_url":"https://api.github.com/users/FedeMPouzols/gists{/gist_id}","starred_url":"https://api.github.com/users/FedeMPouzols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FedeMPouzols/subscriptions","organizations_url":"https://api.github.com/users/FedeMPouzols/orgs","repos_url":"https://api.github.com/users/FedeMPouzols/repos","events_url":"https://api.github.com/users/FedeMPouzols/events{/privacy}","received_events_url":"https://api.github.com/users/FedeMPouzols/received_events","type":"User","site_admin":false},"created_at":"2015-11-04T14:38:58Z","updated_at":"2015-11-04T14:38:58Z","body":"Oh, sorry, just before closing my test Mantid build I found now a minor issue? with the python documentation of RenameWorkspace. I'm not sure if this is the intended behavior: If you type `RenameWorkspace(` in the script interpreter it won't show you the new option (RenameMonitors), just the help string that comes from https://github.com/mantidproject/mantid/pull/14098/files#diff-21e1642a0ce7da9cc69e0c7542489c39R473, and the Input/Ouput Workspace options.\r\n"}}