{"action":"created","comment":{"url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/comments/22611748","id":22611748,"diff_hunk":"@@ -22,23 +22,20 @@ use NCM::Component;\n our @ISA = qw(NCM::Component);\n use LC::Exception qw(throw_error);\n our $EC=LC::Exception::Context->new->will_store_all;\n+our $NoActionSupported = 1;\n \n+use CAF::Process;\n use EDG::WP4::CCM::Element;\n-\n use NCM::Check;\n-use LC::Process qw(trun);\n-\n-# For convenience\n-my $base = '/software/components/sysctl';\n \n \n ##########################################################################\n sub Configure {","path":"ncm-sysctl/src/main/perl/sysctl.pm","position":17,"original_position":17,"commit_id":"8052976ad48e370de99ff8eb415d30c7f653edd7","original_commit_id":"8052976ad48e370de99ff8eb415d30c7f653edd7","user":{"login":"stdweird","id":1517606,"avatar_url":"https://avatars.githubusercontent.com/u/1517606?v=3","gravatar_id":"","url":"https://api.github.com/users/stdweird","html_url":"https://github.com/stdweird","followers_url":"https://api.github.com/users/stdweird/followers","following_url":"https://api.github.com/users/stdweird/following{/other_user}","gists_url":"https://api.github.com/users/stdweird/gists{/gist_id}","starred_url":"https://api.github.com/users/stdweird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stdweird/subscriptions","organizations_url":"https://api.github.com/users/stdweird/orgs","repos_url":"https://api.github.com/users/stdweird/repos","events_url":"https://api.github.com/users/stdweird/events{/privacy}","received_events_url":"https://api.github.com/users/stdweird/received_events","type":"User","site_admin":false},"body":"remove the `####` lines, the `{` should start on a new line\r\n(i know this is not your code :smile: )","created_at":"2015-01-07T20:05:24Z","updated_at":"2015-01-07T20:05:24Z","html_url":"https://github.com/quattor/configuration-modules-core/pull/405#discussion_r22611748","pull_request_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/405","_links":{"self":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/comments/22611748"},"html":{"href":"https://github.com/quattor/configuration-modules-core/pull/405#discussion_r22611748"},"pull_request":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/405"}}},"pull_request":{"url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/405","id":26970281,"html_url":"https://github.com/quattor/configuration-modules-core/pull/405","diff_url":"https://github.com/quattor/configuration-modules-core/pull/405.diff","patch_url":"https://github.com/quattor/configuration-modules-core/pull/405.patch","issue_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/405","number":405,"state":"open","locked":false,"title":"ncm-sysctl: clean up and enable NoAction support","user":{"login":"ned21","id":278425,"avatar_url":"https://avatars.githubusercontent.com/u/278425?v=3","gravatar_id":"","url":"https://api.github.com/users/ned21","html_url":"https://github.com/ned21","followers_url":"https://api.github.com/users/ned21/followers","following_url":"https://api.github.com/users/ned21/following{/other_user}","gists_url":"https://api.github.com/users/ned21/gists{/gist_id}","starred_url":"https://api.github.com/users/ned21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ned21/subscriptions","organizations_url":"https://api.github.com/users/ned21/orgs","repos_url":"https://api.github.com/users/ned21/repos","events_url":"https://api.github.com/users/ned21/events{/privacy}","received_events_url":"https://api.github.com/users/ned21/received_events","type":"User","site_admin":false},"body":"Switch ncm-sysctl to using CAF::Process instead of LC::Process. This\r\nenables the component to be run in NoAction mode. It also causes a\r\nnon-zero exit code form /sbin/systctl to be logged as an error.\r\nPreviously a non-zero exit code was not being caught by the if()\r\nstatement.\r\n","created_at":"2015-01-07T16:52:48Z","updated_at":"2015-01-07T20:05:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"58b85481874657b0634241e174c6d5fbb29352e4","assignee":null,"milestone":{"url":"https://api.github.com/repos/quattor/configuration-modules-core/milestones/8","labels_url":"https://api.github.com/repos/quattor/configuration-modules-core/milestones/8/labels","id":811146,"number":8,"title":"15.2","description":null,"creator":{"login":"jrha","id":323309,"avatar_url":"https://avatars.githubusercontent.com/u/323309?v=3","gravatar_id":"","url":"https://api.github.com/users/jrha","html_url":"https://github.com/jrha","followers_url":"https://api.github.com/users/jrha/followers","following_url":"https://api.github.com/users/jrha/following{/other_user}","gists_url":"https://api.github.com/users/jrha/gists{/gist_id}","starred_url":"https://api.github.com/users/jrha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrha/subscriptions","organizations_url":"https://api.github.com/users/jrha/orgs","repos_url":"https://api.github.com/users/jrha/repos","events_url":"https://api.github.com/users/jrha/events{/privacy}","received_events_url":"https://api.github.com/users/jrha/received_events","type":"User","site_admin":false},"open_issues":26,"closed_issues":0,"state":"open","created_at":"2014-10-02T10:30:31Z","updated_at":"2015-01-07T17:00:52Z","due_on":"2015-02-28T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/405/commits","review_comments_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/405/comments","review_comment_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/comments/{number}","comments_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/405/comments","statuses_url":"https://api.github.com/repos/quattor/configuration-modules-core/statuses/8052976ad48e370de99ff8eb415d30c7f653edd7","head":{"label":"ned21:ncm-sysctl","ref":"ncm-sysctl","sha":"8052976ad48e370de99ff8eb415d30c7f653edd7","user":{"login":"ned21","id":278425,"avatar_url":"https://avatars.githubusercontent.com/u/278425?v=3","gravatar_id":"","url":"https://api.github.com/users/ned21","html_url":"https://github.com/ned21","followers_url":"https://api.github.com/users/ned21/followers","following_url":"https://api.github.com/users/ned21/following{/other_user}","gists_url":"https://api.github.com/users/ned21/gists{/gist_id}","starred_url":"https://api.github.com/users/ned21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ned21/subscriptions","organizations_url":"https://api.github.com/users/ned21/orgs","repos_url":"https://api.github.com/users/ned21/repos","events_url":"https://api.github.com/users/ned21/events{/privacy}","received_events_url":"https://api.github.com/users/ned21/received_events","type":"User","site_admin":false},"repo":{"id":9676040,"name":"configuration-modules-core","full_name":"ned21/configuration-modules-core","owner":{"login":"ned21","id":278425,"avatar_url":"https://avatars.githubusercontent.com/u/278425?v=3","gravatar_id":"","url":"https://api.github.com/users/ned21","html_url":"https://github.com/ned21","followers_url":"https://api.github.com/users/ned21/followers","following_url":"https://api.github.com/users/ned21/following{/other_user}","gists_url":"https://api.github.com/users/ned21/gists{/gist_id}","starred_url":"https://api.github.com/users/ned21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ned21/subscriptions","organizations_url":"https://api.github.com/users/ned21/orgs","repos_url":"https://api.github.com/users/ned21/repos","events_url":"https://api.github.com/users/ned21/events{/privacy}","received_events_url":"https://api.github.com/users/ned21/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ned21/configuration-modules-core","description":"Core NCM components for Quattor","fork":true,"url":"https://api.github.com/repos/ned21/configuration-modules-core","forks_url":"https://api.github.com/repos/ned21/configuration-modules-core/forks","keys_url":"https://api.github.com/repos/ned21/configuration-modules-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ned21/configuration-modules-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ned21/configuration-modules-core/teams","hooks_url":"https://api.github.com/repos/ned21/configuration-modules-core/hooks","issue_events_url":"https://api.github.com/repos/ned21/configuration-modules-core/issues/events{/number}","events_url":"https://api.github.com/repos/ned21/configuration-modules-core/events","assignees_url":"https://api.github.com/repos/ned21/configuration-modules-core/assignees{/user}","branches_url":"https://api.github.com/repos/ned21/configuration-modules-core/branches{/branch}","tags_url":"https://api.github.com/repos/ned21/configuration-modules-core/tags","blobs_url":"https://api.github.com/repos/ned21/configuration-modules-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ned21/configuration-modules-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ned21/configuration-modules-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ned21/configuration-modules-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ned21/configuration-modules-core/statuses/{sha}","languages_url":"https://api.github.com/repos/ned21/configuration-modules-core/languages","stargazers_url":"https://api.github.com/repos/ned21/configuration-modules-core/stargazers","contributors_url":"https://api.github.com/repos/ned21/configuration-modules-core/contributors","subscribers_url":"https://api.github.com/repos/ned21/configuration-modules-core/subscribers","subscription_url":"https://api.github.com/repos/ned21/configuration-modules-core/subscription","commits_url":"https://api.github.com/repos/ned21/configuration-modules-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ned21/configuration-modules-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ned21/configuration-modules-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ned21/configuration-modules-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/ned21/configuration-modules-core/contents/{+path}","compare_url":"https://api.github.com/repos/ned21/configuration-modules-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ned21/configuration-modules-core/merges","archive_url":"https://api.github.com/repos/ned21/configuration-modules-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ned21/configuration-modules-core/downloads","issues_url":"https://api.github.com/repos/ned21/configuration-modules-core/issues{/number}","pulls_url":"https://api.github.com/repos/ned21/configuration-modules-core/pulls{/number}","milestones_url":"https://api.github.com/repos/ned21/configuration-modules-core/milestones{/number}","notifications_url":"https://api.github.com/repos/ned21/configuration-modules-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ned21/configuration-modules-core/labels{/name}","releases_url":"https://api.github.com/repos/ned21/configuration-modules-core/releases{/id}","created_at":"2013-04-25T16:21:09Z","updated_at":"2015-01-07T13:39:49Z","pushed_at":"2015-01-07T19:37:00Z","git_url":"git://github.com/ned21/configuration-modules-core.git","ssh_url":"git@github.com:ned21/configuration-modules-core.git","clone_url":"https://github.com/ned21/configuration-modules-core.git","svn_url":"https://github.com/ned21/configuration-modules-core","homepage":null,"size":7048,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"quattor:master","ref":"master","sha":"8b0ae53d95ae1b565559eb74205398f0335a8024","user":{"login":"quattor","id":1557169,"avatar_url":"https://avatars.githubusercontent.com/u/1557169?v=3","gravatar_id":"","url":"https://api.github.com/users/quattor","html_url":"https://github.com/quattor","followers_url":"https://api.github.com/users/quattor/followers","following_url":"https://api.github.com/users/quattor/following{/other_user}","gists_url":"https://api.github.com/users/quattor/gists{/gist_id}","starred_url":"https://api.github.com/users/quattor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quattor/subscriptions","organizations_url":"https://api.github.com/users/quattor/orgs","repos_url":"https://api.github.com/users/quattor/repos","events_url":"https://api.github.com/users/quattor/events{/privacy}","received_events_url":"https://api.github.com/users/quattor/received_events","type":"Organization","site_admin":false},"repo":{"id":6471233,"name":"configuration-modules-core","full_name":"quattor/configuration-modules-core","owner":{"login":"quattor","id":1557169,"avatar_url":"https://avatars.githubusercontent.com/u/1557169?v=3","gravatar_id":"","url":"https://api.github.com/users/quattor","html_url":"https://github.com/quattor","followers_url":"https://api.github.com/users/quattor/followers","following_url":"https://api.github.com/users/quattor/following{/other_user}","gists_url":"https://api.github.com/users/quattor/gists{/gist_id}","starred_url":"https://api.github.com/users/quattor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quattor/subscriptions","organizations_url":"https://api.github.com/users/quattor/orgs","repos_url":"https://api.github.com/users/quattor/repos","events_url":"https://api.github.com/users/quattor/events{/privacy}","received_events_url":"https://api.github.com/users/quattor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quattor/configuration-modules-core","description":"Node Configuration Manager Components for Everyone","fork":false,"url":"https://api.github.com/repos/quattor/configuration-modules-core","forks_url":"https://api.github.com/repos/quattor/configuration-modules-core/forks","keys_url":"https://api.github.com/repos/quattor/configuration-modules-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quattor/configuration-modules-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quattor/configuration-modules-core/teams","hooks_url":"https://api.github.com/repos/quattor/configuration-modules-core/hooks","issue_events_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/events{/number}","events_url":"https://api.github.com/repos/quattor/configuration-modules-core/events","assignees_url":"https://api.github.com/repos/quattor/configuration-modules-core/assignees{/user}","branches_url":"https://api.github.com/repos/quattor/configuration-modules-core/branches{/branch}","tags_url":"https://api.github.com/repos/quattor/configuration-modules-core/tags","blobs_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quattor/configuration-modules-core/statuses/{sha}","languages_url":"https://api.github.com/repos/quattor/configuration-modules-core/languages","stargazers_url":"https://api.github.com/repos/quattor/configuration-modules-core/stargazers","contributors_url":"https://api.github.com/repos/quattor/configuration-modules-core/contributors","subscribers_url":"https://api.github.com/repos/quattor/configuration-modules-core/subscribers","subscription_url":"https://api.github.com/repos/quattor/configuration-modules-core/subscription","commits_url":"https://api.github.com/repos/quattor/configuration-modules-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/quattor/configuration-modules-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/quattor/configuration-modules-core/contents/{+path}","compare_url":"https://api.github.com/repos/quattor/configuration-modules-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quattor/configuration-modules-core/merges","archive_url":"https://api.github.com/repos/quattor/configuration-modules-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quattor/configuration-modules-core/downloads","issues_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues{/number}","pulls_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls{/number}","milestones_url":"https://api.github.com/repos/quattor/configuration-modules-core/milestones{/number}","notifications_url":"https://api.github.com/repos/quattor/configuration-modules-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quattor/configuration-modules-core/labels{/name}","releases_url":"https://api.github.com/repos/quattor/configuration-modules-core/releases{/id}","created_at":"2012-10-31T09:08:07Z","updated_at":"2014-12-23T18:02:22Z","pushed_at":"2014-12-23T18:02:22Z","git_url":"git://github.com/quattor/configuration-modules-core.git","ssh_url":"git@github.com:quattor/configuration-modules-core.git","clone_url":"https://github.com/quattor/configuration-modules-core.git","svn_url":"https://github.com/quattor/configuration-modules-core","homepage":"www.quattor.org","size":12783,"stargazers_count":5,"watchers_count":5,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":40,"forks":23,"open_issues":40,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/405"},"html":{"href":"https://github.com/quattor/configuration-modules-core/pull/405"},"issue":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/issues/405"},"comments":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/issues/405/comments"},"review_comments":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/405/comments"},"review_comment":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/405/commits"},"statuses":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/statuses/8052976ad48e370de99ff8eb415d30c7f653edd7"}}}}