{"action":"created","comment":{"url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/pulls/comments/38148495","id":38148495,"diff_hunk":"@@ -189,6 +230,9 @@ PHP_MINIT_FUNCTION(Binary)\n \n \tmemcpy(&php_phongo_handler_binary, phongo_get_std_object_handlers(), sizeof(zend_object_handlers));\n \tphp_phongo_handler_binary.get_debug_info = php_phongo_binary_get_debug_info;\n+#if PHP_VERSION_ID >= 70000\n+        php_phongo_handler_binary.free_obj = php_phongo_binary_free_object;","path":"src/BSON/Binary.c","position":88,"original_position":88,"commit_id":"3226c1b23c2663f8dca67a4e3f726167621eb4e4","original_commit_id":"3226c1b23c2663f8dca67a4e3f726167621eb4e4","user":{"login":"bjori","id":72407,"avatar_url":"https://avatars.githubusercontent.com/u/72407?v=3","gravatar_id":"","url":"https://api.github.com/users/bjori","html_url":"https://github.com/bjori","followers_url":"https://api.github.com/users/bjori/followers","following_url":"https://api.github.com/users/bjori/following{/other_user}","gists_url":"https://api.github.com/users/bjori/gists{/gist_id}","starred_url":"https://api.github.com/users/bjori/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjori/subscriptions","organizations_url":"https://api.github.com/users/bjori/orgs","repos_url":"https://api.github.com/users/bjori/repos","events_url":"https://api.github.com/users/bjori/events{/privacy}","received_events_url":"https://api.github.com/users/bjori/received_events","type":"User","site_admin":false},"body":"We also need to add\r\n```\r\nphp_phongo_handler_binary.offset = XtOffsetOf(php_phongo_binary_t, std);\r\n```","created_at":"2015-08-27T21:29:10Z","updated_at":"2015-08-27T21:29:10Z","html_url":"https://github.com/10gen-labs/mongo-php-driver-prototype/pull/90#discussion_r38148495","pull_request_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/pulls/90","_links":{"self":{"href":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/pulls/comments/38148495"},"html":{"href":"https://github.com/10gen-labs/mongo-php-driver-prototype/pull/90#discussion_r38148495"},"pull_request":{"href":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/pulls/90"}}},"pull_request":{"url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/pulls/90","id":43531175,"html_url":"https://github.com/10gen-labs/mongo-php-driver-prototype/pull/90","diff_url":"https://github.com/10gen-labs/mongo-php-driver-prototype/pull/90.diff","patch_url":"https://github.com/10gen-labs/mongo-php-driver-prototype/pull/90.patch","issue_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/issues/90","number":90,"state":"open","locked":false,"title":"PHP7: Change create_object functions to support new PHP7 function prototype","user":{"login":"pboyd04","id":594097,"avatar_url":"https://avatars.githubusercontent.com/u/594097?v=3","gravatar_id":"","url":"https://api.github.com/users/pboyd04","html_url":"https://github.com/pboyd04","followers_url":"https://api.github.com/users/pboyd04/followers","following_url":"https://api.github.com/users/pboyd04/following{/other_user}","gists_url":"https://api.github.com/users/pboyd04/gists{/gist_id}","starred_url":"https://api.github.com/users/pboyd04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pboyd04/subscriptions","organizations_url":"https://api.github.com/users/pboyd04/orgs","repos_url":"https://api.github.com/users/pboyd04/repos","events_url":"https://api.github.com/users/pboyd04/events{/privacy}","received_events_url":"https://api.github.com/users/pboyd04/received_events","type":"User","site_admin":false},"body":"This pull change the create_object prototypes for the object classes so that they should work with the new PHP7 create_object prototype as well as a few other miscellaneous changes to the files to compile against PHP7. ","created_at":"2015-08-27T15:29:09Z","updated_at":"2015-08-27T21:29:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aefcdedb58b7b8ef8b6269fa0c9e141fd495ba18","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/pulls/90/commits","review_comments_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/pulls/90/comments","review_comment_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/pulls/comments{/number}","comments_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/issues/90/comments","statuses_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/statuses/3226c1b23c2663f8dca67a4e3f726167621eb4e4","head":{"label":"pboyd04:PHP7","ref":"PHP7","sha":"3226c1b23c2663f8dca67a4e3f726167621eb4e4","user":{"login":"pboyd04","id":594097,"avatar_url":"https://avatars.githubusercontent.com/u/594097?v=3","gravatar_id":"","url":"https://api.github.com/users/pboyd04","html_url":"https://github.com/pboyd04","followers_url":"https://api.github.com/users/pboyd04/followers","following_url":"https://api.github.com/users/pboyd04/following{/other_user}","gists_url":"https://api.github.com/users/pboyd04/gists{/gist_id}","starred_url":"https://api.github.com/users/pboyd04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pboyd04/subscriptions","organizations_url":"https://api.github.com/users/pboyd04/orgs","repos_url":"https://api.github.com/users/pboyd04/repos","events_url":"https://api.github.com/users/pboyd04/events{/privacy}","received_events_url":"https://api.github.com/users/pboyd04/received_events","type":"User","site_admin":false},"repo":{"id":41494660,"name":"mongo-php-driver-prototype","full_name":"pboyd04/mongo-php-driver-prototype","owner":{"login":"pboyd04","id":594097,"avatar_url":"https://avatars.githubusercontent.com/u/594097?v=3","gravatar_id":"","url":"https://api.github.com/users/pboyd04","html_url":"https://github.com/pboyd04","followers_url":"https://api.github.com/users/pboyd04/followers","following_url":"https://api.github.com/users/pboyd04/following{/other_user}","gists_url":"https://api.github.com/users/pboyd04/gists{/gist_id}","starred_url":"https://api.github.com/users/pboyd04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pboyd04/subscriptions","organizations_url":"https://api.github.com/users/pboyd04/orgs","repos_url":"https://api.github.com/users/pboyd04/repos","events_url":"https://api.github.com/users/pboyd04/events{/privacy}","received_events_url":"https://api.github.com/users/pboyd04/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pboyd04/mongo-php-driver-prototype","description":"MongoDB PHP driver (experimental)","fork":true,"url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype","forks_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/forks","keys_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/teams","hooks_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/hooks","issue_events_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/issues/events{/number}","events_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/events","assignees_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/assignees{/user}","branches_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/branches{/branch}","tags_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/tags","blobs_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/git/refs{/sha}","trees_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/statuses/{sha}","languages_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/languages","stargazers_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/stargazers","contributors_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/contributors","subscribers_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/subscribers","subscription_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/subscription","commits_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/commits{/sha}","git_commits_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/git/commits{/sha}","comments_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/comments{/number}","issue_comment_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/issues/comments{/number}","contents_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/contents/{+path}","compare_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/merges","archive_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/downloads","issues_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/issues{/number}","pulls_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/pulls{/number}","milestones_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/milestones{/number}","notifications_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/labels{/name}","releases_url":"https://api.github.com/repos/pboyd04/mongo-php-driver-prototype/releases{/id}","created_at":"2015-08-27T15:21:58Z","updated_at":"2015-08-27T15:21:59Z","pushed_at":"2015-08-27T20:58:05Z","git_url":"git://github.com/pboyd04/mongo-php-driver-prototype.git","ssh_url":"git@github.com:pboyd04/mongo-php-driver-prototype.git","clone_url":"https://github.com/pboyd04/mongo-php-driver-prototype.git","svn_url":"https://github.com/pboyd04/mongo-php-driver-prototype","homepage":"","size":4153,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"10gen-labs:PHP7","ref":"PHP7","sha":"787f665c252bceb1704f11a33d1d021b16973788","user":{"login":"10gen-labs","id":2118794,"avatar_url":"https://avatars.githubusercontent.com/u/2118794?v=3","gravatar_id":"","url":"https://api.github.com/users/10gen-labs","html_url":"https://github.com/10gen-labs","followers_url":"https://api.github.com/users/10gen-labs/followers","following_url":"https://api.github.com/users/10gen-labs/following{/other_user}","gists_url":"https://api.github.com/users/10gen-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/10gen-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/10gen-labs/subscriptions","organizations_url":"https://api.github.com/users/10gen-labs/orgs","repos_url":"https://api.github.com/users/10gen-labs/repos","events_url":"https://api.github.com/users/10gen-labs/events{/privacy}","received_events_url":"https://api.github.com/users/10gen-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":19514152,"name":"mongo-php-driver-prototype","full_name":"10gen-labs/mongo-php-driver-prototype","owner":{"login":"10gen-labs","id":2118794,"avatar_url":"https://avatars.githubusercontent.com/u/2118794?v=3","gravatar_id":"","url":"https://api.github.com/users/10gen-labs","html_url":"https://github.com/10gen-labs","followers_url":"https://api.github.com/users/10gen-labs/followers","following_url":"https://api.github.com/users/10gen-labs/following{/other_user}","gists_url":"https://api.github.com/users/10gen-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/10gen-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/10gen-labs/subscriptions","organizations_url":"https://api.github.com/users/10gen-labs/orgs","repos_url":"https://api.github.com/users/10gen-labs/repos","events_url":"https://api.github.com/users/10gen-labs/events{/privacy}","received_events_url":"https://api.github.com/users/10gen-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/10gen-labs/mongo-php-driver-prototype","description":"MongoDB PHP driver (experimental)","fork":false,"url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype","forks_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/forks","keys_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/keys{/key_id}","collaborators_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/teams","hooks_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/hooks","issue_events_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/issues/events{/number}","events_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/events","assignees_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/assignees{/user}","branches_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/branches{/branch}","tags_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/tags","blobs_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/git/refs{/sha}","trees_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/git/trees{/sha}","statuses_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/statuses/{sha}","languages_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/languages","stargazers_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/stargazers","contributors_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/contributors","subscribers_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/subscribers","subscription_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/subscription","commits_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/commits{/sha}","git_commits_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/git/commits{/sha}","comments_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/comments{/number}","issue_comment_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/issues/comments{/number}","contents_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/contents/{+path}","compare_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/compare/{base}...{head}","merges_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/merges","archive_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/downloads","issues_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/issues{/number}","pulls_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/pulls{/number}","milestones_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/milestones{/number}","notifications_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/labels{/name}","releases_url":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/releases{/id}","created_at":"2014-05-06T23:18:32Z","updated_at":"2015-08-26T07:54:07Z","pushed_at":"2015-08-27T20:58:05Z","git_url":"git://github.com/10gen-labs/mongo-php-driver-prototype.git","ssh_url":"git@github.com:10gen-labs/mongo-php-driver-prototype.git","clone_url":"https://github.com/10gen-labs/mongo-php-driver-prototype.git","svn_url":"https://github.com/10gen-labs/mongo-php-driver-prototype","homepage":"","size":4153,"stargazers_count":32,"watchers_count":32,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":11,"mirror_url":null,"open_issues_count":6,"forks":11,"open_issues":6,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/pulls/90"},"html":{"href":"https://github.com/10gen-labs/mongo-php-driver-prototype/pull/90"},"issue":{"href":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/issues/90"},"comments":{"href":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/issues/90/comments"},"review_comments":{"href":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/pulls/90/comments"},"review_comment":{"href":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/pulls/90/commits"},"statuses":{"href":"https://api.github.com/repos/10gen-labs/mongo-php-driver-prototype/statuses/3226c1b23c2663f8dca67a4e3f726167621eb4e4"}}}}