{"action":"created","issue":{"url":"https://api.github.com/repos/shopkeep/shpkpr/issues/55","labels_url":"https://api.github.com/repos/shopkeep/shpkpr/issues/55/labels{/name}","comments_url":"https://api.github.com/repos/shopkeep/shpkpr/issues/55/comments","events_url":"https://api.github.com/repos/shopkeep/shpkpr/issues/55/events","html_url":"https://github.com/shopkeep/shpkpr/pull/55","id":122506296,"number":55,"title":"Jinja2 template loading","user":{"login":"paddycarey","id":164309,"avatar_url":"https://avatars.githubusercontent.com/u/164309?v=3","gravatar_id":"","url":"https://api.github.com/users/paddycarey","html_url":"https://github.com/paddycarey","followers_url":"https://api.github.com/users/paddycarey/followers","following_url":"https://api.github.com/users/paddycarey/following{/other_user}","gists_url":"https://api.github.com/users/paddycarey/gists{/gist_id}","starred_url":"https://api.github.com/users/paddycarey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paddycarey/subscriptions","organizations_url":"https://api.github.com/users/paddycarey/orgs","repos_url":"https://api.github.com/users/paddycarey/repos","events_url":"https://api.github.com/users/paddycarey/events{/privacy}","received_events_url":"https://api.github.com/users/paddycarey/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-16T13:45:54Z","updated_at":"2015-12-16T14:39:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/shopkeep/shpkpr/pulls/55","html_url":"https://github.com/shopkeep/shpkpr/pull/55","diff_url":"https://github.com/shopkeep/shpkpr/pull/55.diff","patch_url":"https://github.com/shopkeep/shpkpr/pull/55.patch"},"body":"This PR changes template loading behaviour to use a proper `jinja2.FilesystemLoader`. This allows the use of more advanced template features such as inheritance (useful in a project with multiple deploys but only very slightly differing configurations).\r\n\r\n**NOTE:** This PR changes/breaks the public-facing API of `shpkpr` slightly. I explored alternative approaches that wouldn't have broken the API, but this explicit approach (specifying both the template dir and name) makes the most sense, has the least surprises and weird edge cases and will be familiar to anyone who has used Jinja2 or Django templates in the past."},"comment":{"url":"https://api.github.com/repos/shopkeep/shpkpr/issues/comments/165128422","html_url":"https://github.com/shopkeep/shpkpr/pull/55#issuecomment-165128422","issue_url":"https://api.github.com/repos/shopkeep/shpkpr/issues/55","id":165128422,"user":{"login":"swmcc","id":356955,"avatar_url":"https://avatars.githubusercontent.com/u/356955?v=3","gravatar_id":"","url":"https://api.github.com/users/swmcc","html_url":"https://github.com/swmcc","followers_url":"https://api.github.com/users/swmcc/followers","following_url":"https://api.github.com/users/swmcc/following{/other_user}","gists_url":"https://api.github.com/users/swmcc/gists{/gist_id}","starred_url":"https://api.github.com/users/swmcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swmcc/subscriptions","organizations_url":"https://api.github.com/users/swmcc/orgs","repos_url":"https://api.github.com/users/swmcc/repos","events_url":"https://api.github.com/users/swmcc/events{/privacy}","received_events_url":"https://api.github.com/users/swmcc/received_events","type":"User","site_admin":false},"created_at":"2015-12-16T14:39:48Z","updated_at":"2015-12-16T14:39:48Z","body":"LGTM - All very concise. I think it should be a :ship: "}}