{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/pulls/comments/34524997","id":34524997,"diff_hunk":"@@ -1,72 +1,99 @@\n source ENV['GEM_SOURCE'] || \"https://rubygems.org\"\n \n-def location_for(place, fake_version = nil)\n-  if place =~ /^(git:[^#]*)#(.*)/\n-    [fake_version, { :git => $1, :branch => $2, :require => false }].compact\n-  elsif place =~ /^file:\\/\\/(.*)/\n-    ['>= 0', { :path => File.expand_path($1), :require => false }]\n+# Determines what type of gem is requested based on place_or_version.\n+def gem_type(place_or_version)\n+  if place_or_version =~ /^git:/\n+    :git\n+  elsif place_or_version =~ /^file:/\n+    :file\n   else\n-    [place, { :require => false }]\n+    :gem\n   end\n end\n \n-if ENV['PUPPET_GEM_VERSION']\n-  gem \"puppet\", *location_for(ENV['PUPPET_GEM_VERSION'] )\n-else\n-  gem \"puppet\", :require => false\n-end\n-\n-if ENV['FACTER_GEM_VERSION']\n-  gem \"facter\", *location_for(ENV['FACTER_GEM_VERSION'] || '~> 1.6')\n-else\n-  gem \"facter\", :require => false\n-end\n-\n-if ENV['HIERA_GEM_VERSION']\n-  gem \"hiera\", *location_for(ENV['HIERA_GEM_VERISON'])\n-else\n-  gem \"hiera\"\n-end\n-\n-is_ruby18 = RUBY_VERSION.start_with? '1.8'\n-\n-group :development, :test do\n-  if is_ruby18\n-    gem 'pry', \"~> 0.9.12\"\n+# Find a location or specific version for a gem. place_or_version can be a\n+# version, which is most often used. It can also be git, which is specified as\n+# `git://somewhere.git#branch`. You can also use a file source location, which\n+# is specified as `file://some/location/on/disk`.\n+def location_for(place_or_version, fake_version = nil)\n+  if place_or_version =~ /^(git[:@][^#]*)#(.*)/\n+    [fake_version, { :git => $1, :branch => $2, :require => false }].compact\n+  elsif place_or_version =~ /^file:\\/\\/(.*)/\n+    ['>= 0', { :path => File.expand_path($1), :require => false }]\n   else\n-    gem 'pry'\n+    [place_or_version, { :require => false }]\n   end\n-  gem 'rake'\n-  gem 'rspec', \"~> 2.13.0\"\n-  gem 'mocha', \"~> 0.10.5\"\n-  gem 'puppetlabs_spec_helper'\n-  gem 'nokogiri', \"~> 1.5.10\"\n-  gem 'mime-types', '<2.0',      :require => false\n-  gem 'puppet-lint',             :require => false\n-  gem 'simplecov',               :require => false\n end\n \n-beaker_version = ENV['BEAKER_VERSION']\n+group :development do\n+  gem 'rake',                    :require => false\n+  gem 'rspec', '~>2.14.0',       :require => false\n+  gem 'puppet-lint',             :require => false\n+  gem 'puppetlabs_spec_helper',  :require => false\n+  gem 'puppet_facts',            :require => false\n+  gem 'mocha', '~>0.10.5',       :require => false\n+  gem 'nokogiri', '~>1.5.10',    :require => false, :platforms => :ruby\n+  gem 'mime-types', '<2.0',      :require => false\n+end\n group :system_tests do\n+  beaker_version = ENV['BEAKER_VERSION'] || '~> 2.2'\n   if beaker_version\n     gem 'beaker', *location_for(beaker_version)\n   else\n-    gem 'beaker',                :require => false, :platforms => :ruby\n+    gem 'beaker', :require => false, :platforms => :ruby\n   end\n-  gem 'beaker-puppet_install_helper', :require => false\n+  gem 'beaker-puppet_install_helper',  :require => false\n end\n \n-# see http://projects.puppetlabs.com/issues/21698\n-platforms :mswin, :mingw do\n-  gem \"ffi\", \"~> 1.9.3\", :require => false\n-  gem \"sys-admin\", \"~> 1.5.6\", :require => false\n-  gem \"win32-dir\", \"~> 0.3.7\", :require => false\n-  gem \"win32-process\", \"~> 0.6.5\", :require => false\n-  gem \"win32-service\", \"~> 0.7.2\", :require => false\n-  gem \"win32-taskscheduler\", \"~> 0.2.2\", :require => false\n+# The recommendation is for PROJECT_GEM_VERSION, although there are older ways\n+# of referencing these. Add them all for compatibility reasons. We'll remove\n+# later when no issues are known. We'll prefer them in the right order.\n+puppetversion = ENV['PUPPET_GEM_VERSION'] || ENV['GEM_PUPPET_VERSION'] || ENV['PUPPET_LOCATION'] || '>= 0'","path":"Gemfile","position":100,"original_position":100,"commit_id":"6e38dc7d96c85672a0f8e1b7b9b97e16eae59b76","original_commit_id":"6e38dc7d96c85672a0f8e1b7b9b97e16eae59b76","user":{"login":"cyberious","id":1703710,"avatar_url":"https://avatars.githubusercontent.com/u/1703710?v=3","gravatar_id":"","url":"https://api.github.com/users/cyberious","html_url":"https://github.com/cyberious","followers_url":"https://api.github.com/users/cyberious/followers","following_url":"https://api.github.com/users/cyberious/following{/other_user}","gists_url":"https://api.github.com/users/cyberious/gists{/gist_id}","starred_url":"https://api.github.com/users/cyberious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyberious/subscriptions","organizations_url":"https://api.github.com/users/cyberious/orgs","repos_url":"https://api.github.com/users/cyberious/repos","events_url":"https://api.github.com/users/cyberious/events{/privacy}","received_events_url":"https://api.github.com/users/cyberious/received_events","type":"User","site_admin":false},"body":"Not totally happy with this over defaulting to ~> 4.0","created_at":"2015-07-13T23:48:05Z","updated_at":"2015-07-13T23:48:05Z","html_url":"https://github.com/puppetlabs/puppetlabs-reboot/pull/83#discussion_r34524997","pull_request_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/pulls/83","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/pulls/comments/34524997"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-reboot/pull/83#discussion_r34524997"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/pulls/83","id":39734105,"html_url":"https://github.com/puppetlabs/puppetlabs-reboot/pull/83","diff_url":"https://github.com/puppetlabs/puppetlabs-reboot/pull/83.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-reboot/pull/83.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/issues/83","number":83,"state":"open","locked":false,"title":"(MODULES-2207) Update Modulesync","user":{"login":"ferventcoder","id":63502,"avatar_url":"https://avatars.githubusercontent.com/u/63502?v=3","gravatar_id":"","url":"https://api.github.com/users/ferventcoder","html_url":"https://github.com/ferventcoder","followers_url":"https://api.github.com/users/ferventcoder/followers","following_url":"https://api.github.com/users/ferventcoder/following{/other_user}","gists_url":"https://api.github.com/users/ferventcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/ferventcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferventcoder/subscriptions","organizations_url":"https://api.github.com/users/ferventcoder/orgs","repos_url":"https://api.github.com/users/ferventcoder/repos","events_url":"https://api.github.com/users/ferventcoder/events{/privacy}","received_events_url":"https://api.github.com/users/ferventcoder/received_events","type":"User","site_admin":false},"body":" This ensures the following items are under moduleysnc:\r\n\r\n* .gitignore\r\n* .travis.yml\r\n* CONTRIBUTING.md\r\n* Gemfile\r\n* appveyor.yml\r\n* spec/spec.opts\r\n\r\nMost importantly, this ensures that acl has up to date Gemfile, Travis\r\nCI and AppVeyor configurations that allow it to be tested properly.","created_at":"2015-07-10T23:40:06Z","updated_at":"2015-07-13T23:48:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54c2bf80ca4e2168256ff1190dcfdcd46be35a08","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/pulls/83/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/pulls/83/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/issues/83/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/statuses/6e38dc7d96c85672a0f8e1b7b9b97e16eae59b76","head":{"label":"ferventcoder:maint/master/modsync-changes","ref":"maint/master/modsync-changes","sha":"6e38dc7d96c85672a0f8e1b7b9b97e16eae59b76","user":{"login":"ferventcoder","id":63502,"avatar_url":"https://avatars.githubusercontent.com/u/63502?v=3","gravatar_id":"","url":"https://api.github.com/users/ferventcoder","html_url":"https://github.com/ferventcoder","followers_url":"https://api.github.com/users/ferventcoder/followers","following_url":"https://api.github.com/users/ferventcoder/following{/other_user}","gists_url":"https://api.github.com/users/ferventcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/ferventcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferventcoder/subscriptions","organizations_url":"https://api.github.com/users/ferventcoder/orgs","repos_url":"https://api.github.com/users/ferventcoder/repos","events_url":"https://api.github.com/users/ferventcoder/events{/privacy}","received_events_url":"https://api.github.com/users/ferventcoder/received_events","type":"User","site_admin":false},"repo":{"id":11961706,"name":"puppetlabs-reboot","full_name":"ferventcoder/puppetlabs-reboot","owner":{"login":"ferventcoder","id":63502,"avatar_url":"https://avatars.githubusercontent.com/u/63502?v=3","gravatar_id":"","url":"https://api.github.com/users/ferventcoder","html_url":"https://github.com/ferventcoder","followers_url":"https://api.github.com/users/ferventcoder/followers","following_url":"https://api.github.com/users/ferventcoder/following{/other_user}","gists_url":"https://api.github.com/users/ferventcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/ferventcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferventcoder/subscriptions","organizations_url":"https://api.github.com/users/ferventcoder/orgs","repos_url":"https://api.github.com/users/ferventcoder/repos","events_url":"https://api.github.com/users/ferventcoder/events{/privacy}","received_events_url":"https://api.github.com/users/ferventcoder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ferventcoder/puppetlabs-reboot","description":"Reboot type and provider","fork":true,"url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot","forks_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/forks","keys_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/teams","hooks_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/hooks","issue_events_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/issues/events{/number}","events_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/events","assignees_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/assignees{/user}","branches_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/branches{/branch}","tags_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/tags","blobs_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/git/refs{/sha}","trees_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/statuses/{sha}","languages_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/languages","stargazers_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/stargazers","contributors_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/contributors","subscribers_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/subscribers","subscription_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/subscription","commits_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/commits{/sha}","git_commits_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/git/commits{/sha}","comments_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/comments{/number}","issue_comment_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/issues/comments{/number}","contents_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/contents/{+path}","compare_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/merges","archive_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/downloads","issues_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/issues{/number}","pulls_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/pulls{/number}","milestones_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/milestones{/number}","notifications_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/labels{/name}","releases_url":"https://api.github.com/repos/ferventcoder/puppetlabs-reboot/releases{/id}","created_at":"2013-08-07T22:07:16Z","updated_at":"2015-07-02T21:22:34Z","pushed_at":"2015-07-11T00:35:42Z","git_url":"git://github.com/ferventcoder/puppetlabs-reboot.git","ssh_url":"git@github.com:ferventcoder/puppetlabs-reboot.git","clone_url":"https://github.com/ferventcoder/puppetlabs-reboot.git","svn_url":"https://github.com/ferventcoder/puppetlabs-reboot","homepage":null,"size":264,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"c0f40f8b47873b4e1f89b1a451775b9066ae0e14","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":8871577,"name":"puppetlabs-reboot","full_name":"puppetlabs/puppetlabs-reboot","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetlabs-reboot","description":"Reboot type and provider","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot","forks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/releases{/id}","created_at":"2013-03-19T05:35:15Z","updated_at":"2015-06-30T12:59:41Z","pushed_at":"2015-07-11T00:35:42Z","git_url":"git://github.com/puppetlabs/puppetlabs-reboot.git","ssh_url":"git@github.com:puppetlabs/puppetlabs-reboot.git","clone_url":"https://github.com/puppetlabs/puppetlabs-reboot.git","svn_url":"https://github.com/puppetlabs/puppetlabs-reboot","homepage":null,"size":1038,"stargazers_count":11,"watchers_count":11,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":4,"forks":27,"open_issues":4,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/pulls/83"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-reboot/pull/83"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/issues/83"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-reboot/statuses/6e38dc7d96c85672a0f8e1b7b9b97e16eae59b76"}}}}