{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/41101099","id":41101099,"diff_hunk":"@@ -185,6 +185,29 @@ Most test targets require that you build these precursor targets first:\n \n ## Running individual or multiple named tests \n \n+### Unit tests \n+\n+We use golang standard [testing](https://golang.org/pkg/testing/)\n+package or [gocheck](https://labix.org/gocheck) for our unit tests. \n+\n+You can also use the `TESTDIRS` environment variable to run unit tests for","path":"docs/project/test-and-docs.md","position":9,"original_position":9,"commit_id":"7090fe3f1927d0a229bfdf6870c17bfe8aecec8a","original_commit_id":"7090fe3f1927d0a229bfdf6870c17bfe8aecec8a","user":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars.githubusercontent.com/u/6508?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"body":"Oh I think I messed up there.. using \"also\" here, and nothing in the next paragraph, I'll update that :sweat_smile: ","created_at":"2015-10-04T19:08:04Z","updated_at":"2015-10-04T19:08:04Z","html_url":"https://github.com/docker/docker/pull/16747#discussion_r41101099","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/16747","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/41101099"},"html":{"href":"https://github.com/docker/docker/pull/16747#discussion_r41101099"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/16747"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/16747","id":46714917,"html_url":"https://github.com/docker/docker/pull/16747","diff_url":"https://github.com/docker/docker/pull/16747.diff","patch_url":"https://github.com/docker/docker/pull/16747.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/16747","number":16747,"state":"open","locked":false,"title":"Update test-and-docs with TESTDIRS","user":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars.githubusercontent.com/u/6508?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"body":"Add a paragraph on `TESTDIRS` and the combination with `TEST_FLAGS` in `test_and_docs.md`, as I didn't find anywhere that this is mentionned 🐡.\r\n\r\nAlso fix the rendering of `make test-unit` when `TESTDIRS` is used.\r\n\r\n```bash\r\n# before\r\n$ TESTDIRS=opts TESTFLAGS='-test.run ^TestValidateIPAddress$' make test-unit\r\n# […]\r\n+ go test -test.run ^TestValidateIPAddress$ -test.timeout=60m github.com/docker/dockeropts\r\nPASS\r\ncoverage: 2.4% of statements\r\n# after\r\n$ TESTDIRS=opts TESTFLAGS='-test.run ^TestValidateIPAddress$' make test-unit\r\n# […]\r\n+ go test -test.run ^TestValidateIPAddress$ -test.timeout=60m github.com/docker/docker/opts\r\nPASS\r\ncoverage: 2.4% of statements\r\n```\r\n- docs : @thaJeztah @moxiegirl \r\n- scripts : @jfrazelle @tianon \r\n\r\n🐸\r\n\r\nSigned-off-by: Vincent Demeester <vincent@sbr.pm>","created_at":"2015-10-03T22:35:41Z","updated_at":"2015-10-04T19:08:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67c3f12e4edef4b2d6e2d8cf6097f19896bb3751","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/16747/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/16747/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/16747/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/7090fe3f1927d0a229bfdf6870c17bfe8aecec8a","head":{"label":"vdemeester:docs-testdirs","ref":"docs-testdirs","sha":"7090fe3f1927d0a229bfdf6870c17bfe8aecec8a","user":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars.githubusercontent.com/u/6508?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"repo":{"id":32953007,"name":"docker","full_name":"vdemeester/docker","owner":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars.githubusercontent.com/u/6508?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vdemeester/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/vdemeester/docker","forks_url":"https://api.github.com/repos/vdemeester/docker/forks","keys_url":"https://api.github.com/repos/vdemeester/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vdemeester/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vdemeester/docker/teams","hooks_url":"https://api.github.com/repos/vdemeester/docker/hooks","issue_events_url":"https://api.github.com/repos/vdemeester/docker/issues/events{/number}","events_url":"https://api.github.com/repos/vdemeester/docker/events","assignees_url":"https://api.github.com/repos/vdemeester/docker/assignees{/user}","branches_url":"https://api.github.com/repos/vdemeester/docker/branches{/branch}","tags_url":"https://api.github.com/repos/vdemeester/docker/tags","blobs_url":"https://api.github.com/repos/vdemeester/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vdemeester/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vdemeester/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/vdemeester/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vdemeester/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/vdemeester/docker/languages","stargazers_url":"https://api.github.com/repos/vdemeester/docker/stargazers","contributors_url":"https://api.github.com/repos/vdemeester/docker/contributors","subscribers_url":"https://api.github.com/repos/vdemeester/docker/subscribers","subscription_url":"https://api.github.com/repos/vdemeester/docker/subscription","commits_url":"https://api.github.com/repos/vdemeester/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/vdemeester/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/vdemeester/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/vdemeester/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/vdemeester/docker/contents/{+path}","compare_url":"https://api.github.com/repos/vdemeester/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vdemeester/docker/merges","archive_url":"https://api.github.com/repos/vdemeester/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vdemeester/docker/downloads","issues_url":"https://api.github.com/repos/vdemeester/docker/issues{/number}","pulls_url":"https://api.github.com/repos/vdemeester/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/vdemeester/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/vdemeester/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vdemeester/docker/labels{/name}","releases_url":"https://api.github.com/repos/vdemeester/docker/releases{/id}","created_at":"2015-03-26T21:32:15Z","updated_at":"2015-05-08T12:20:26Z","pushed_at":"2015-10-04T18:22:09Z","git_url":"git://github.com/vdemeester/docker.git","ssh_url":"git@github.com:vdemeester/docker.git","clone_url":"https://github.com/vdemeester/docker.git","svn_url":"https://github.com/vdemeester/docker","homepage":"http://www.docker.com","size":70250,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"2fcacf8ea3898b731828866f09df3ccd8bfb8f9b","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-10-04T18:46:06Z","pushed_at":"2015-10-04T18:48:23Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":261854,"stargazers_count":25201,"watchers_count":25201,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6595,"mirror_url":null,"open_issues_count":1115,"forks":6595,"open_issues":1115,"watchers":25201,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/16747"},"html":{"href":"https://github.com/docker/docker/pull/16747"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/16747"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/16747/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/16747/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/16747/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/7090fe3f1927d0a229bfdf6870c17bfe8aecec8a"}}}}