{"action":"opened","number":16,"pull_request":{"url":"https://api.github.com/repos/chipsec/chipsec/pulls/16","id":53183980,"html_url":"https://github.com/chipsec/chipsec/pull/16","diff_url":"https://github.com/chipsec/chipsec/pull/16.diff","patch_url":"https://github.com/chipsec/chipsec/pull/16.patch","issue_url":"https://api.github.com/repos/chipsec/chipsec/issues/16","number":16,"state":"open","locked":false,"title":"Check that hardware sequencing is enabled before interacting with the flash","user":{"login":"tweksteen","id":109376,"avatar_url":"https://avatars.githubusercontent.com/u/109376?v=3","gravatar_id":"","url":"https://api.github.com/users/tweksteen","html_url":"https://github.com/tweksteen","followers_url":"https://api.github.com/users/tweksteen/followers","following_url":"https://api.github.com/users/tweksteen/following{/other_user}","gists_url":"https://api.github.com/users/tweksteen/gists{/gist_id}","starred_url":"https://api.github.com/users/tweksteen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tweksteen/subscriptions","organizations_url":"https://api.github.com/users/tweksteen/orgs","repos_url":"https://api.github.com/users/tweksteen/repos","events_url":"https://api.github.com/users/tweksteen/events{/privacy}","received_events_url":"https://api.github.com/users/tweksteen/received_events","type":"User","site_admin":false},"body":"Currently, no check is performed to detect that hardware sequencing is enabled (HSFS.FDV). When such configuration is encountered, although the base and limit values are meaningless, Chipsec still interpret them and try to read/write to the flash.\r\n\r\nThis patch add a method to the SPI HAL to detect such configuration. A call to this method is added to the beginning of each SPI operation.\r\n\r\nBy doing so, it is still possible to run 'chipsec_utils.py spi info' to get some information on the flash.","created_at":"2015-12-09T21:56:35Z","updated_at":"2015-12-09T21:56:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/chipsec/chipsec/pulls/16/commits","review_comments_url":"https://api.github.com/repos/chipsec/chipsec/pulls/16/comments","review_comment_url":"https://api.github.com/repos/chipsec/chipsec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chipsec/chipsec/issues/16/comments","statuses_url":"https://api.github.com/repos/chipsec/chipsec/statuses/1700f856a0ef47a513fb4a033dea27471a28a3d3","head":{"label":"tweksteen:check_hardware_sequencing","ref":"check_hardware_sequencing","sha":"1700f856a0ef47a513fb4a033dea27471a28a3d3","user":{"login":"tweksteen","id":109376,"avatar_url":"https://avatars.githubusercontent.com/u/109376?v=3","gravatar_id":"","url":"https://api.github.com/users/tweksteen","html_url":"https://github.com/tweksteen","followers_url":"https://api.github.com/users/tweksteen/followers","following_url":"https://api.github.com/users/tweksteen/following{/other_user}","gists_url":"https://api.github.com/users/tweksteen/gists{/gist_id}","starred_url":"https://api.github.com/users/tweksteen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tweksteen/subscriptions","organizations_url":"https://api.github.com/users/tweksteen/orgs","repos_url":"https://api.github.com/users/tweksteen/repos","events_url":"https://api.github.com/users/tweksteen/events{/privacy}","received_events_url":"https://api.github.com/users/tweksteen/received_events","type":"User","site_admin":false},"repo":{"id":44282910,"name":"chipsec","full_name":"tweksteen/chipsec","owner":{"login":"tweksteen","id":109376,"avatar_url":"https://avatars.githubusercontent.com/u/109376?v=3","gravatar_id":"","url":"https://api.github.com/users/tweksteen","html_url":"https://github.com/tweksteen","followers_url":"https://api.github.com/users/tweksteen/followers","following_url":"https://api.github.com/users/tweksteen/following{/other_user}","gists_url":"https://api.github.com/users/tweksteen/gists{/gist_id}","starred_url":"https://api.github.com/users/tweksteen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tweksteen/subscriptions","organizations_url":"https://api.github.com/users/tweksteen/orgs","repos_url":"https://api.github.com/users/tweksteen/repos","events_url":"https://api.github.com/users/tweksteen/events{/privacy}","received_events_url":"https://api.github.com/users/tweksteen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tweksteen/chipsec","description":"Platform Security Assessment Framework","fork":true,"url":"https://api.github.com/repos/tweksteen/chipsec","forks_url":"https://api.github.com/repos/tweksteen/chipsec/forks","keys_url":"https://api.github.com/repos/tweksteen/chipsec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tweksteen/chipsec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tweksteen/chipsec/teams","hooks_url":"https://api.github.com/repos/tweksteen/chipsec/hooks","issue_events_url":"https://api.github.com/repos/tweksteen/chipsec/issues/events{/number}","events_url":"https://api.github.com/repos/tweksteen/chipsec/events","assignees_url":"https://api.github.com/repos/tweksteen/chipsec/assignees{/user}","branches_url":"https://api.github.com/repos/tweksteen/chipsec/branches{/branch}","tags_url":"https://api.github.com/repos/tweksteen/chipsec/tags","blobs_url":"https://api.github.com/repos/tweksteen/chipsec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tweksteen/chipsec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tweksteen/chipsec/git/refs{/sha}","trees_url":"https://api.github.com/repos/tweksteen/chipsec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tweksteen/chipsec/statuses/{sha}","languages_url":"https://api.github.com/repos/tweksteen/chipsec/languages","stargazers_url":"https://api.github.com/repos/tweksteen/chipsec/stargazers","contributors_url":"https://api.github.com/repos/tweksteen/chipsec/contributors","subscribers_url":"https://api.github.com/repos/tweksteen/chipsec/subscribers","subscription_url":"https://api.github.com/repos/tweksteen/chipsec/subscription","commits_url":"https://api.github.com/repos/tweksteen/chipsec/commits{/sha}","git_commits_url":"https://api.github.com/repos/tweksteen/chipsec/git/commits{/sha}","comments_url":"https://api.github.com/repos/tweksteen/chipsec/comments{/number}","issue_comment_url":"https://api.github.com/repos/tweksteen/chipsec/issues/comments{/number}","contents_url":"https://api.github.com/repos/tweksteen/chipsec/contents/{+path}","compare_url":"https://api.github.com/repos/tweksteen/chipsec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tweksteen/chipsec/merges","archive_url":"https://api.github.com/repos/tweksteen/chipsec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tweksteen/chipsec/downloads","issues_url":"https://api.github.com/repos/tweksteen/chipsec/issues{/number}","pulls_url":"https://api.github.com/repos/tweksteen/chipsec/pulls{/number}","milestones_url":"https://api.github.com/repos/tweksteen/chipsec/milestones{/number}","notifications_url":"https://api.github.com/repos/tweksteen/chipsec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tweksteen/chipsec/labels{/name}","releases_url":"https://api.github.com/repos/tweksteen/chipsec/releases{/id}","created_at":"2015-10-14T23:56:31Z","updated_at":"2015-11-23T23:05:41Z","pushed_at":"2015-12-09T21:49:28Z","git_url":"git://github.com/tweksteen/chipsec.git","ssh_url":"git@github.com:tweksteen/chipsec.git","clone_url":"https://github.com/tweksteen/chipsec.git","svn_url":"https://github.com/tweksteen/chipsec","homepage":"","size":36105,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"chipsec:master","ref":"master","sha":"dc3ec303aa099a49f4b492a972bf81a839ad0f9a","user":{"login":"chipsec","id":6620051,"avatar_url":"https://avatars.githubusercontent.com/u/6620051?v=3","gravatar_id":"","url":"https://api.github.com/users/chipsec","html_url":"https://github.com/chipsec","followers_url":"https://api.github.com/users/chipsec/followers","following_url":"https://api.github.com/users/chipsec/following{/other_user}","gists_url":"https://api.github.com/users/chipsec/gists{/gist_id}","starred_url":"https://api.github.com/users/chipsec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chipsec/subscriptions","organizations_url":"https://api.github.com/users/chipsec/orgs","repos_url":"https://api.github.com/users/chipsec/repos","events_url":"https://api.github.com/users/chipsec/events{/privacy}","received_events_url":"https://api.github.com/users/chipsec/received_events","type":"Organization","site_admin":false},"repo":{"id":17494082,"name":"chipsec","full_name":"chipsec/chipsec","owner":{"login":"chipsec","id":6620051,"avatar_url":"https://avatars.githubusercontent.com/u/6620051?v=3","gravatar_id":"","url":"https://api.github.com/users/chipsec","html_url":"https://github.com/chipsec","followers_url":"https://api.github.com/users/chipsec/followers","following_url":"https://api.github.com/users/chipsec/following{/other_user}","gists_url":"https://api.github.com/users/chipsec/gists{/gist_id}","starred_url":"https://api.github.com/users/chipsec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chipsec/subscriptions","organizations_url":"https://api.github.com/users/chipsec/orgs","repos_url":"https://api.github.com/users/chipsec/repos","events_url":"https://api.github.com/users/chipsec/events{/privacy}","received_events_url":"https://api.github.com/users/chipsec/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chipsec/chipsec","description":"Platform Security Assessment Framework","fork":false,"url":"https://api.github.com/repos/chipsec/chipsec","forks_url":"https://api.github.com/repos/chipsec/chipsec/forks","keys_url":"https://api.github.com/repos/chipsec/chipsec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chipsec/chipsec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chipsec/chipsec/teams","hooks_url":"https://api.github.com/repos/chipsec/chipsec/hooks","issue_events_url":"https://api.github.com/repos/chipsec/chipsec/issues/events{/number}","events_url":"https://api.github.com/repos/chipsec/chipsec/events","assignees_url":"https://api.github.com/repos/chipsec/chipsec/assignees{/user}","branches_url":"https://api.github.com/repos/chipsec/chipsec/branches{/branch}","tags_url":"https://api.github.com/repos/chipsec/chipsec/tags","blobs_url":"https://api.github.com/repos/chipsec/chipsec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chipsec/chipsec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chipsec/chipsec/git/refs{/sha}","trees_url":"https://api.github.com/repos/chipsec/chipsec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chipsec/chipsec/statuses/{sha}","languages_url":"https://api.github.com/repos/chipsec/chipsec/languages","stargazers_url":"https://api.github.com/repos/chipsec/chipsec/stargazers","contributors_url":"https://api.github.com/repos/chipsec/chipsec/contributors","subscribers_url":"https://api.github.com/repos/chipsec/chipsec/subscribers","subscription_url":"https://api.github.com/repos/chipsec/chipsec/subscription","commits_url":"https://api.github.com/repos/chipsec/chipsec/commits{/sha}","git_commits_url":"https://api.github.com/repos/chipsec/chipsec/git/commits{/sha}","comments_url":"https://api.github.com/repos/chipsec/chipsec/comments{/number}","issue_comment_url":"https://api.github.com/repos/chipsec/chipsec/issues/comments{/number}","contents_url":"https://api.github.com/repos/chipsec/chipsec/contents/{+path}","compare_url":"https://api.github.com/repos/chipsec/chipsec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chipsec/chipsec/merges","archive_url":"https://api.github.com/repos/chipsec/chipsec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chipsec/chipsec/downloads","issues_url":"https://api.github.com/repos/chipsec/chipsec/issues{/number}","pulls_url":"https://api.github.com/repos/chipsec/chipsec/pulls{/number}","milestones_url":"https://api.github.com/repos/chipsec/chipsec/milestones{/number}","notifications_url":"https://api.github.com/repos/chipsec/chipsec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chipsec/chipsec/labels{/name}","releases_url":"https://api.github.com/repos/chipsec/chipsec/releases{/id}","created_at":"2014-03-06T21:57:10Z","updated_at":"2015-12-04T08:41:01Z","pushed_at":"2015-11-27T04:51:41Z","git_url":"git://github.com/chipsec/chipsec.git","ssh_url":"git@github.com:chipsec/chipsec.git","clone_url":"https://github.com/chipsec/chipsec.git","svn_url":"https://github.com/chipsec/chipsec","homepage":"","size":36718,"stargazers_count":335,"watchers_count":335,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":68,"mirror_url":null,"open_issues_count":7,"forks":68,"open_issues":7,"watchers":335,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chipsec/chipsec/pulls/16"},"html":{"href":"https://github.com/chipsec/chipsec/pull/16"},"issue":{"href":"https://api.github.com/repos/chipsec/chipsec/issues/16"},"comments":{"href":"https://api.github.com/repos/chipsec/chipsec/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/chipsec/chipsec/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/chipsec/chipsec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chipsec/chipsec/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/chipsec/chipsec/statuses/1700f856a0ef47a513fb4a033dea27471a28a3d3"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":16,"deletions":0,"changed_files":1}}