{"action":"created","comment":{"url":"https://api.github.com/repos/google/traceur-compiler/pulls/comments/27937001","id":27937001,"diff_hunk":"@@ -83,7 +83,7 @@ suite('System.js', function() {\n \n   test('System.set', function() {\n     var store = $traceurRuntime.ModuleStore;\n-    var polyfills = store.getForTesting('src/runtime/polyfills/polyfills.js');\n+    var polyfills = store.get(System.version + '/src/runtime/polyfills/polyfills.js');","path":"test/unit/browser/System.js","position":5,"original_position":5,"commit_id":"db6f5721bc4cc2721b4e9013d68b2d6b377e4fbd","original_commit_id":"db6f5721bc4cc2721b4e9013d68b2d6b377e4fbd","user":{"login":"johnjbarton","id":205570,"avatar_url":"https://avatars.githubusercontent.com/u/205570?v=3","gravatar_id":"","url":"https://api.github.com/users/johnjbarton","html_url":"https://github.com/johnjbarton","followers_url":"https://api.github.com/users/johnjbarton/followers","following_url":"https://api.github.com/users/johnjbarton/following{/other_user}","gists_url":"https://api.github.com/users/johnjbarton/gists{/gist_id}","starred_url":"https://api.github.com/users/johnjbarton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnjbarton/subscriptions","organizations_url":"https://api.github.com/users/johnjbarton/orgs","repos_url":"https://api.github.com/users/johnjbarton/repos","events_url":"https://api.github.com/users/johnjbarton/events{/privacy}","received_events_url":"https://api.github.com/users/johnjbarton/received_events","type":"User","site_admin":false},"body":"The purpose of that test was to verify `../bin/traceur-runtime.js`in the\nbrowser. But since we did not run it, it does nothing.  Removing is fine by\nme.\n\nOn Tue, Apr 7, 2015 at 6:30 PM, Erik Arvidsson <notifications@github.com>\nwrote:\n\n> In test/unit/browser/System.js\n> <https://github.com/google/traceur-compiler/pull/1871#discussion_r27936628>\n> :\n>\n> > @@ -83,7 +83,7 @@ suite('System.js', function() {\n> >\n> >    test('System.set', function() {\n> >      var store = $traceurRuntime.ModuleStore;\n> > -    var polyfills = store.getForTesting('src/runtime/polyfills/polyfills.js');\n> > +    var polyfills = store.get(System.version + '/src/runtime/polyfills/polyfills.js');\n>\n>\n> https://github.com/google/traceur-compiler/blob/master/test/runtime.html#L13\n>\n> It just uses a script[src] to an es6 file. This probably broke a while\n> ago. We should probably remover this html file and only use 1 html test\n> runner.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/google/traceur-compiler/pull/1871/files#r27936628>.\n>\n","created_at":"2015-04-08T01:41:24Z","updated_at":"2015-04-08T01:41:24Z","html_url":"https://github.com/google/traceur-compiler/pull/1871#discussion_r27937001","pull_request_url":"https://api.github.com/repos/google/traceur-compiler/pulls/1871","_links":{"self":{"href":"https://api.github.com/repos/google/traceur-compiler/pulls/comments/27937001"},"html":{"href":"https://github.com/google/traceur-compiler/pull/1871#discussion_r27937001"},"pull_request":{"href":"https://api.github.com/repos/google/traceur-compiler/pulls/1871"}}},"pull_request":{"url":"https://api.github.com/repos/google/traceur-compiler/pulls/1871","id":32817117,"html_url":"https://github.com/google/traceur-compiler/pull/1871","diff_url":"https://github.com/google/traceur-compiler/pull/1871.diff","patch_url":"https://github.com/google/traceur-compiler/pull/1871.patch","issue_url":"https://api.github.com/repos/google/traceur-compiler/issues/1871","number":1871,"state":"open","locked":false,"title":"Remove getForTesting","user":{"login":"arv","id":45845,"avatar_url":"https://avatars.githubusercontent.com/u/45845?v=3","gravatar_id":"","url":"https://api.github.com/users/arv","html_url":"https://github.com/arv","followers_url":"https://api.github.com/users/arv/followers","following_url":"https://api.github.com/users/arv/following{/other_user}","gists_url":"https://api.github.com/users/arv/gists{/gist_id}","starred_url":"https://api.github.com/users/arv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arv/subscriptions","organizations_url":"https://api.github.com/users/arv/orgs","repos_url":"https://api.github.com/users/arv/repos","events_url":"https://api.github.com/users/arv/events{/privacy}","received_events_url":"https://api.github.com/users/arv/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-04-07T23:50:15Z","updated_at":"2015-04-08T01:41:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e25bca69162ce37aaf163ca357774639ba52c3d5","assignee":{"login":"johnjbarton","id":205570,"avatar_url":"https://avatars.githubusercontent.com/u/205570?v=3","gravatar_id":"","url":"https://api.github.com/users/johnjbarton","html_url":"https://github.com/johnjbarton","followers_url":"https://api.github.com/users/johnjbarton/followers","following_url":"https://api.github.com/users/johnjbarton/following{/other_user}","gists_url":"https://api.github.com/users/johnjbarton/gists{/gist_id}","starred_url":"https://api.github.com/users/johnjbarton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnjbarton/subscriptions","organizations_url":"https://api.github.com/users/johnjbarton/orgs","repos_url":"https://api.github.com/users/johnjbarton/repos","events_url":"https://api.github.com/users/johnjbarton/events{/privacy}","received_events_url":"https://api.github.com/users/johnjbarton/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/google/traceur-compiler/pulls/1871/commits","review_comments_url":"https://api.github.com/repos/google/traceur-compiler/pulls/1871/comments","review_comment_url":"https://api.github.com/repos/google/traceur-compiler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/traceur-compiler/issues/1871/comments","statuses_url":"https://api.github.com/repos/google/traceur-compiler/statuses/db6f5721bc4cc2721b4e9013d68b2d6b377e4fbd","head":{"label":"arv:remove-get-for-testing","ref":"remove-get-for-testing","sha":"db6f5721bc4cc2721b4e9013d68b2d6b377e4fbd","user":{"login":"arv","id":45845,"avatar_url":"https://avatars.githubusercontent.com/u/45845?v=3","gravatar_id":"","url":"https://api.github.com/users/arv","html_url":"https://github.com/arv","followers_url":"https://api.github.com/users/arv/followers","following_url":"https://api.github.com/users/arv/following{/other_user}","gists_url":"https://api.github.com/users/arv/gists{/gist_id}","starred_url":"https://api.github.com/users/arv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arv/subscriptions","organizations_url":"https://api.github.com/users/arv/orgs","repos_url":"https://api.github.com/users/arv/repos","events_url":"https://api.github.com/users/arv/events{/privacy}","received_events_url":"https://api.github.com/users/arv/received_events","type":"User","site_admin":false},"repo":{"id":9069860,"name":"traceur-compiler","full_name":"arv/traceur-compiler","owner":{"login":"arv","id":45845,"avatar_url":"https://avatars.githubusercontent.com/u/45845?v=3","gravatar_id":"","url":"https://api.github.com/users/arv","html_url":"https://github.com/arv","followers_url":"https://api.github.com/users/arv/followers","following_url":"https://api.github.com/users/arv/following{/other_user}","gists_url":"https://api.github.com/users/arv/gists{/gist_id}","starred_url":"https://api.github.com/users/arv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arv/subscriptions","organizations_url":"https://api.github.com/users/arv/orgs","repos_url":"https://api.github.com/users/arv/repos","events_url":"https://api.github.com/users/arv/events{/privacy}","received_events_url":"https://api.github.com/users/arv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arv/traceur-compiler","description":"Traceur is a JavaScript.next-to-JavaScript-of-today compiler","fork":true,"url":"https://api.github.com/repos/arv/traceur-compiler","forks_url":"https://api.github.com/repos/arv/traceur-compiler/forks","keys_url":"https://api.github.com/repos/arv/traceur-compiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arv/traceur-compiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arv/traceur-compiler/teams","hooks_url":"https://api.github.com/repos/arv/traceur-compiler/hooks","issue_events_url":"https://api.github.com/repos/arv/traceur-compiler/issues/events{/number}","events_url":"https://api.github.com/repos/arv/traceur-compiler/events","assignees_url":"https://api.github.com/repos/arv/traceur-compiler/assignees{/user}","branches_url":"https://api.github.com/repos/arv/traceur-compiler/branches{/branch}","tags_url":"https://api.github.com/repos/arv/traceur-compiler/tags","blobs_url":"https://api.github.com/repos/arv/traceur-compiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arv/traceur-compiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arv/traceur-compiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/arv/traceur-compiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arv/traceur-compiler/statuses/{sha}","languages_url":"https://api.github.com/repos/arv/traceur-compiler/languages","stargazers_url":"https://api.github.com/repos/arv/traceur-compiler/stargazers","contributors_url":"https://api.github.com/repos/arv/traceur-compiler/contributors","subscribers_url":"https://api.github.com/repos/arv/traceur-compiler/subscribers","subscription_url":"https://api.github.com/repos/arv/traceur-compiler/subscription","commits_url":"https://api.github.com/repos/arv/traceur-compiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/arv/traceur-compiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/arv/traceur-compiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/arv/traceur-compiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/arv/traceur-compiler/contents/{+path}","compare_url":"https://api.github.com/repos/arv/traceur-compiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arv/traceur-compiler/merges","archive_url":"https://api.github.com/repos/arv/traceur-compiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arv/traceur-compiler/downloads","issues_url":"https://api.github.com/repos/arv/traceur-compiler/issues{/number}","pulls_url":"https://api.github.com/repos/arv/traceur-compiler/pulls{/number}","milestones_url":"https://api.github.com/repos/arv/traceur-compiler/milestones{/number}","notifications_url":"https://api.github.com/repos/arv/traceur-compiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arv/traceur-compiler/labels{/name}","releases_url":"https://api.github.com/repos/arv/traceur-compiler/releases{/id}","created_at":"2013-03-28T04:13:00Z","updated_at":"2015-04-03T22:01:29Z","pushed_at":"2015-04-07T23:54:21Z","git_url":"git://github.com/arv/traceur-compiler.git","ssh_url":"git@github.com:arv/traceur-compiler.git","clone_url":"https://github.com/arv/traceur-compiler.git","svn_url":"https://github.com/arv/traceur-compiler","homepage":"","size":26149,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":10,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"5feca665f9abc8aa721aefb6ff4a76d9450e1324","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":9060347,"name":"traceur-compiler","full_name":"google/traceur-compiler","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/traceur-compiler","description":"Traceur is a JavaScript.next-to-JavaScript-of-today compiler","fork":false,"url":"https://api.github.com/repos/google/traceur-compiler","forks_url":"https://api.github.com/repos/google/traceur-compiler/forks","keys_url":"https://api.github.com/repos/google/traceur-compiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/traceur-compiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/traceur-compiler/teams","hooks_url":"https://api.github.com/repos/google/traceur-compiler/hooks","issue_events_url":"https://api.github.com/repos/google/traceur-compiler/issues/events{/number}","events_url":"https://api.github.com/repos/google/traceur-compiler/events","assignees_url":"https://api.github.com/repos/google/traceur-compiler/assignees{/user}","branches_url":"https://api.github.com/repos/google/traceur-compiler/branches{/branch}","tags_url":"https://api.github.com/repos/google/traceur-compiler/tags","blobs_url":"https://api.github.com/repos/google/traceur-compiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/traceur-compiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/traceur-compiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/traceur-compiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/traceur-compiler/statuses/{sha}","languages_url":"https://api.github.com/repos/google/traceur-compiler/languages","stargazers_url":"https://api.github.com/repos/google/traceur-compiler/stargazers","contributors_url":"https://api.github.com/repos/google/traceur-compiler/contributors","subscribers_url":"https://api.github.com/repos/google/traceur-compiler/subscribers","subscription_url":"https://api.github.com/repos/google/traceur-compiler/subscription","commits_url":"https://api.github.com/repos/google/traceur-compiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/traceur-compiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/traceur-compiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/traceur-compiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/traceur-compiler/contents/{+path}","compare_url":"https://api.github.com/repos/google/traceur-compiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/traceur-compiler/merges","archive_url":"https://api.github.com/repos/google/traceur-compiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/traceur-compiler/downloads","issues_url":"https://api.github.com/repos/google/traceur-compiler/issues{/number}","pulls_url":"https://api.github.com/repos/google/traceur-compiler/pulls{/number}","milestones_url":"https://api.github.com/repos/google/traceur-compiler/milestones{/number}","notifications_url":"https://api.github.com/repos/google/traceur-compiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/traceur-compiler/labels{/name}","releases_url":"https://api.github.com/repos/google/traceur-compiler/releases{/id}","created_at":"2013-03-27T18:05:40Z","updated_at":"2015-04-07T23:54:13Z","pushed_at":"2015-04-08T01:15:43Z","git_url":"git://github.com/google/traceur-compiler.git","ssh_url":"git@github.com:google/traceur-compiler.git","clone_url":"https://github.com/google/traceur-compiler.git","svn_url":"https://github.com/google/traceur-compiler","homepage":"","size":37515,"stargazers_count":4958,"watchers_count":4958,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":289,"mirror_url":null,"open_issues_count":271,"forks":289,"open_issues":271,"watchers":4958,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/traceur-compiler/pulls/1871"},"html":{"href":"https://github.com/google/traceur-compiler/pull/1871"},"issue":{"href":"https://api.github.com/repos/google/traceur-compiler/issues/1871"},"comments":{"href":"https://api.github.com/repos/google/traceur-compiler/issues/1871/comments"},"review_comments":{"href":"https://api.github.com/repos/google/traceur-compiler/pulls/1871/comments"},"review_comment":{"href":"https://api.github.com/repos/google/traceur-compiler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/traceur-compiler/pulls/1871/commits"},"statuses":{"href":"https://api.github.com/repos/google/traceur-compiler/statuses/db6f5721bc4cc2721b4e9013d68b2d6b377e4fbd"}}}}