{"action":"created","issue":{"url":"https://api.github.com/repos/rackspace/gophercloud/issues/473","labels_url":"https://api.github.com/repos/rackspace/gophercloud/issues/473/labels{/name}","comments_url":"https://api.github.com/repos/rackspace/gophercloud/issues/473/comments","events_url":"https://api.github.com/repos/rackspace/gophercloud/issues/473/events","html_url":"https://github.com/rackspace/gophercloud/issues/473","id":104994162,"number":473,"title":"Import of volumes and volumeattach package causes indirect dependency on testing","user":{"login":"spothanis","id":4702326,"avatar_url":"https://avatars.githubusercontent.com/u/4702326?v=3","gravatar_id":"","url":"https://api.github.com/users/spothanis","html_url":"https://github.com/spothanis","followers_url":"https://api.github.com/users/spothanis/followers","following_url":"https://api.github.com/users/spothanis/following{/other_user}","gists_url":"https://api.github.com/users/spothanis/gists{/gist_id}","starred_url":"https://api.github.com/users/spothanis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spothanis/subscriptions","organizations_url":"https://api.github.com/users/spothanis/orgs","repos_url":"https://api.github.com/users/spothanis/repos","events_url":"https://api.github.com/users/spothanis/events{/privacy}","received_events_url":"https://api.github.com/users/spothanis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-05T01:12:04Z","updated_at":"2015-09-10T15:20:59Z","closed_at":null,"body":"I guess it is common knowledge that gophercloud is used in kubernetes for openstack\r\n\r\nImport of the below packages is resulting in addition of test flags to kubernetes binaries \r\n```\r\n\"github.com/rackspace/gophercloud/openstack/blockstorage/v1/volumes\"\r\n\"github.com/rackspace/gophercloud/openstack/compute/v2/extensions/volumeattach\"\r\n```\r\nIf we look in say https://github.com/rackspace/gophercloud/blob/master/openstack/blockstorage/v1/volumes/fixtures.go#L6\r\n\r\nWe will see that these imports are in turn importing \"testing\". Which is declaring a bunch of command line args. https://github.com/golang/go/blob/master/src/testing/testing.go#L187\r\n\r\nMoving fixtures.go to a testing sub package and updating the dependencies appropriately seems to fix this issue. (thanks to @thockin for the suggestion)\r\nhttps://github.com/kubernetes/kubernetes/pull/13367\r\n\r\nPlease let me know if this sounds like a right thing to do, I would be more than happy to send a PR for the same.\r\n"},"comment":{"url":"https://api.github.com/repos/rackspace/gophercloud/issues/comments/139277750","html_url":"https://github.com/rackspace/gophercloud/issues/473#issuecomment-139277750","issue_url":"https://api.github.com/repos/rackspace/gophercloud/issues/473","id":139277750,"user":{"login":"spothanis","id":4702326,"avatar_url":"https://avatars.githubusercontent.com/u/4702326?v=3","gravatar_id":"","url":"https://api.github.com/users/spothanis","html_url":"https://github.com/spothanis","followers_url":"https://api.github.com/users/spothanis/followers","following_url":"https://api.github.com/users/spothanis/following{/other_user}","gists_url":"https://api.github.com/users/spothanis/gists{/gist_id}","starred_url":"https://api.github.com/users/spothanis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spothanis/subscriptions","organizations_url":"https://api.github.com/users/spothanis/orgs","repos_url":"https://api.github.com/users/spothanis/repos","events_url":"https://api.github.com/users/spothanis/events{/privacy}","received_events_url":"https://api.github.com/users/spothanis/received_events","type":"User","site_admin":false},"created_at":"2015-09-10T15:20:59Z","updated_at":"2015-09-10T15:20:59Z","body":"Bump :)"}}