{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/26879551","id":26879551,"diff_hunk":"@@ -77,7 +77,13 @@ func (c *services) Get(name string) (result *api.Service, err error) {\n // Create creates a new service.\n func (c *services) Create(svc *api.Service) (result *api.Service, err error) {\n \tresult = &api.Service{}\n-\terr = c.r.Post().Namespace(c.ns).Resource(\"services\").Body(svc).Do().Into(result)\n+\t// v1beta3 does not allow POST without a namespace.\n+\tneedNamespace := !api.PreV1Beta3(c.r.APIVersion())","path":"pkg/client/services.go","position":6,"original_position":6,"commit_id":"7e36bbab3c0ff98046a37725233548e6ca304598","original_commit_id":"7e36bbab3c0ff98046a37725233548e6ca304598","user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"body":"I'm saying that anyone who has an empty string either got it from client input (in which case the server will catch it) or it will be caught lower in the code base.  No one should be passing an empty namespace, ever.  I don't think we need to test in the client (I have a pull incoming which normalizes all our clients now that the server is normalized).\n\n----- Original Message -----\n> > @@ -77,7 +77,13 @@ func (c *services) Get(name string) (result\n> > *api.Service, err error) {\n> >  // Create creates a new service.\n> >  func (c *services) Create(svc *api.Service) (result *api.Service, err\n> >  error) {\n> >  \tresult = &api.Service{}\n> > -\terr =\n> > c.r.Post().Namespace(c.ns).Resource(\"services\").Body(svc).Do().Into(result)\n> > +\t// v1beta3 does not allow POST without a namespace.\n> > +\tneedNamespace := !api.PreV1Beta3(c.r.APIVersion())\n> \n> If not here, then we will need such conditions everywhere at higher level\n> code.\n> ```\n> If (apiVersion = v1beta3 && ns == \"\") {\n>   ns = api.NamespaceDefault\n> }\n> servicesInterface = client.services(ns)\n> ```\n> Is that better?\n> \n> ---\n> Reply to this email directly or view it on GitHub:\n> https://github.com/GoogleCloudPlatform/kubernetes/pull/5587/files#r26879365\n","created_at":"2015-03-20T21:52:36Z","updated_at":"2015-03-20T21:52:36Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5587#discussion_r26879551","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5587","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/26879551"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5587#discussion_r26879551"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5587"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5587","id":31408064,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5587","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5587.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5587.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5587","number":5587,"state":"closed","locked":false,"title":"Updating integration tests to test both API versions - v1beta1 and 3","user":{"login":"nikhiljindal","id":10199099,"avatar_url":"https://avatars.githubusercontent.com/u/10199099?v=3","gravatar_id":"","url":"https://api.github.com/users/nikhiljindal","html_url":"https://github.com/nikhiljindal","followers_url":"https://api.github.com/users/nikhiljindal/followers","following_url":"https://api.github.com/users/nikhiljindal/following{/other_user}","gists_url":"https://api.github.com/users/nikhiljindal/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhiljindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhiljindal/subscriptions","organizations_url":"https://api.github.com/users/nikhiljindal/orgs","repos_url":"https://api.github.com/users/nikhiljindal/repos","events_url":"https://api.github.com/users/nikhiljindal/events{/privacy}","received_events_url":"https://api.github.com/users/nikhiljindal/received_events","type":"User","site_admin":false},"body":"https://github.com/GoogleCloudPlatform/kubernetes/issues/5475","created_at":"2015-03-18T08:24:24Z","updated_at":"2015-03-20T21:52:36Z","closed_at":"2015-03-18T23:14:20Z","merged_at":"2015-03-18T23:14:20Z","merge_commit_sha":"db013ed5a414561f91d247cf7b2fb5e822225e38","assignee":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5587/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5587/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5587/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/7e36bbab3c0ff98046a37725233548e6ca304598","head":{"label":"nikhiljindal:enable3","ref":"enable3","sha":"7e36bbab3c0ff98046a37725233548e6ca304598","user":{"login":"nikhiljindal","id":10199099,"avatar_url":"https://avatars.githubusercontent.com/u/10199099?v=3","gravatar_id":"","url":"https://api.github.com/users/nikhiljindal","html_url":"https://github.com/nikhiljindal","followers_url":"https://api.github.com/users/nikhiljindal/followers","following_url":"https://api.github.com/users/nikhiljindal/following{/other_user}","gists_url":"https://api.github.com/users/nikhiljindal/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhiljindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhiljindal/subscriptions","organizations_url":"https://api.github.com/users/nikhiljindal/orgs","repos_url":"https://api.github.com/users/nikhiljindal/repos","events_url":"https://api.github.com/users/nikhiljindal/events{/privacy}","received_events_url":"https://api.github.com/users/nikhiljindal/received_events","type":"User","site_admin":false},"repo":{"id":29988055,"name":"kubernetes","full_name":"nikhiljindal/kubernetes","owner":{"login":"nikhiljindal","id":10199099,"avatar_url":"https://avatars.githubusercontent.com/u/10199099?v=3","gravatar_id":"","url":"https://api.github.com/users/nikhiljindal","html_url":"https://github.com/nikhiljindal","followers_url":"https://api.github.com/users/nikhiljindal/followers","following_url":"https://api.github.com/users/nikhiljindal/following{/other_user}","gists_url":"https://api.github.com/users/nikhiljindal/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhiljindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhiljindal/subscriptions","organizations_url":"https://api.github.com/users/nikhiljindal/orgs","repos_url":"https://api.github.com/users/nikhiljindal/repos","events_url":"https://api.github.com/users/nikhiljindal/events{/privacy}","received_events_url":"https://api.github.com/users/nikhiljindal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nikhiljindal/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/nikhiljindal/kubernetes","forks_url":"https://api.github.com/repos/nikhiljindal/kubernetes/forks","keys_url":"https://api.github.com/repos/nikhiljindal/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nikhiljindal/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nikhiljindal/kubernetes/teams","hooks_url":"https://api.github.com/repos/nikhiljindal/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/nikhiljindal/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/nikhiljindal/kubernetes/events","assignees_url":"https://api.github.com/repos/nikhiljindal/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/nikhiljindal/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/nikhiljindal/kubernetes/tags","blobs_url":"https://api.github.com/repos/nikhiljindal/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nikhiljindal/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nikhiljindal/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/nikhiljindal/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nikhiljindal/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/nikhiljindal/kubernetes/languages","stargazers_url":"https://api.github.com/repos/nikhiljindal/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/nikhiljindal/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/nikhiljindal/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/nikhiljindal/kubernetes/subscription","commits_url":"https://api.github.com/repos/nikhiljindal/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/nikhiljindal/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/nikhiljindal/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/nikhiljindal/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/nikhiljindal/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/nikhiljindal/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nikhiljindal/kubernetes/merges","archive_url":"https://api.github.com/repos/nikhiljindal/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nikhiljindal/kubernetes/downloads","issues_url":"https://api.github.com/repos/nikhiljindal/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/nikhiljindal/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/nikhiljindal/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/nikhiljindal/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nikhiljindal/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/nikhiljindal/kubernetes/releases{/id}","created_at":"2015-01-28T21:01:50Z","updated_at":"2015-01-28T21:01:53Z","pushed_at":"2015-03-20T20:58:41Z","git_url":"git://github.com/nikhiljindal/kubernetes.git","ssh_url":"git@github.com:nikhiljindal/kubernetes.git","clone_url":"https://github.com/nikhiljindal/kubernetes.git","svn_url":"https://github.com/nikhiljindal/kubernetes","homepage":"http://kubernetes.io","size":37522,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"9a3afb7628105f69b3a4142c1141cd7abc8ce003","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-03-20T21:38:49Z","pushed_at":"2015-03-20T21:51:01Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":109400,"stargazers_count":6671,"watchers_count":6671,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1247,"mirror_url":null,"open_issues_count":778,"forks":1247,"open_issues":778,"watchers":6671,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5587"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5587"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5587"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5587/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5587/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5587/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/7e36bbab3c0ff98046a37725233548e6ca304598"}}}}