{"action":"created","issue":{"url":"https://api.github.com/repos/ged-lab/khmer/issues/752","labels_url":"https://api.github.com/repos/ged-lab/khmer/issues/752/labels{/name}","comments_url":"https://api.github.com/repos/ged-lab/khmer/issues/752/comments","events_url":"https://api.github.com/repos/ged-lab/khmer/issues/752/events","html_url":"https://github.com/ged-lab/khmer/pull/752","id":56403641,"number":752,"title":"Enable specification of output directory","user":{"login":"bede","id":1007616,"avatar_url":"https://avatars.githubusercontent.com/u/1007616?v=3","gravatar_id":"","url":"https://api.github.com/users/bede","html_url":"https://github.com/bede","followers_url":"https://api.github.com/users/bede/followers","following_url":"https://api.github.com/users/bede/following{/other_user}","gists_url":"https://api.github.com/users/bede/gists{/gist_id}","starred_url":"https://api.github.com/users/bede/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bede/subscriptions","organizations_url":"https://api.github.com/users/bede/orgs","repos_url":"https://api.github.com/users/bede/repos","events_url":"https://api.github.com/users/bede/events{/privacy}","received_events_url":"https://api.github.com/users/bede/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":19,"created_at":"2015-02-03T16:46:16Z","updated_at":"2015-02-09T16:46:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ged-lab/khmer/pulls/752","html_url":"https://github.com/ged-lab/khmer/pull/752","diff_url":"https://github.com/ged-lab/khmer/pull/752.diff","patch_url":"https://github.com/ged-lab/khmer/pull/752.patch"},"body":"Follow up to https://twitter.com/beconstant/status/560885880907243520\r\n\r\nThe script now imports the whole `os` module since `os.makedirs()` is being used.\r\n\r\n- [x] Is it mergable?\r\n- [x] Did it pass the tests?\r\n- [x] If it introduces new functionality in scripts/ is it tested?\r\n  Check for code coverage.\r\n- [x] Is it well formatted? Look at `make pep8`, `make diff_pylint_report`,\r\n  `make cppcheck`, and `make doc` output. Use `make format` and manual\r\n  fixing as needed.\r\n- [x] Did it change the command-line interface? Only additions are allowed\r\n  without a major version increment. Changing file formats also requires a\r\n  major version number increment.\r\n- [x] Is it documented in the ChangeLog?\r\n- [x] Was a spellchecker run on the source code and documentation after\r\n  changes were made?"},"comment":{"url":"https://api.github.com/repos/ged-lab/khmer/issues/comments/73542798","html_url":"https://github.com/ged-lab/khmer/pull/752#issuecomment-73542798","issue_url":"https://api.github.com/repos/ged-lab/khmer/issues/752","id":73542798,"user":{"login":"ctb","id":51016,"avatar_url":"https://avatars.githubusercontent.com/u/51016?v=3","gravatar_id":"","url":"https://api.github.com/users/ctb","html_url":"https://github.com/ctb","followers_url":"https://api.github.com/users/ctb/followers","following_url":"https://api.github.com/users/ctb/following{/other_user}","gists_url":"https://api.github.com/users/ctb/gists{/gist_id}","starred_url":"https://api.github.com/users/ctb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctb/subscriptions","organizations_url":"https://api.github.com/users/ctb/orgs","repos_url":"https://api.github.com/users/ctb/repos","events_url":"https://api.github.com/users/ctb/events{/privacy}","received_events_url":"https://api.github.com/users/ctb/received_events","type":"User","site_admin":false},"created_at":"2015-02-09T16:46:22Z","updated_at":"2015-02-09T16:46:22Z","body":"It looks fine to me; one last request: could you add a brief description of -o and --output-dir options to the epilog? See scripts/normalize-by-median.py for how we do the formatting for this.  Then the option info will appear automagically on our docs page.\r\n\r\nIf you want to do os.path.join and/or rebase, that's fine, but not necessary IMO."}}