{"action":"created","comment":{"url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/pulls/comments/22499053","id":22499053,"diff_hunk":"@@ -70,33 +71,25 @@ ArchitectChain.prototype._getRegisterId = function (inputOrStore) {\n     //lookup corresponding store in the architecture object\n     storeToWaitFor = architecture[inputOrStore];\n     //if no store maps to this input throw error\n-    if (!storeToWaitFor) {\n-      throw new Error('store is waiting for an input: \"' + inputOrStore + '\" that no store outputs.  If this store needs no inputs than only call \"itOutputs\" method.');\n-    }\n+    invariant(storeToWaitFor, 'store is waiting for an input: \"%s\" that no store outputs.  If this store needs no inputs than only call \"itOutputs\" method.', inputOrStore);\n   } else {\n     //if inputOrStore is a store use that\n     storeToWaitFor = inputOrStore;\n   }\n   //return __registerId__ from storeToWaitFor\n   storeRegistrationId = storeToWaitFor.__registerId__;\n-  if (storeRegistrationId) {\n-    return storeRegistrationId;\n-  } else {\n-    //if store does not have __registerId__ than it has not been registered to the dispatcher so throw an error\n-    throw new Error('store is waiting for a store that has not been registered to any actions.');\n-  }\n+  //if store does not have __registerId__ than it has not been registered to the dispatcher so throw an error\n+  invariant(storeRegistrationId, 'store is waiting for a store that has not been registered to any actions.');","path":"src/TuxArchitectStores.js","position":28,"original_position":28,"commit_id":"83fc8ea0f5f0dd1adefc5b4d10810e737872c659","original_commit_id":"83fc8ea0f5f0dd1adefc5b4d10810e737872c659","user":{"login":"Cheerazar","id":5581107,"avatar_url":"https://avatars.githubusercontent.com/u/5581107?v=3","gravatar_id":"","url":"https://api.github.com/users/Cheerazar","html_url":"https://github.com/Cheerazar","followers_url":"https://api.github.com/users/Cheerazar/followers","following_url":"https://api.github.com/users/Cheerazar/following{/other_user}","gists_url":"https://api.github.com/users/Cheerazar/gists{/gist_id}","starred_url":"https://api.github.com/users/Cheerazar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cheerazar/subscriptions","organizations_url":"https://api.github.com/users/Cheerazar/orgs","repos_url":"https://api.github.com/users/Cheerazar/repos","events_url":"https://api.github.com/users/Cheerazar/events{/privacy}","received_events_url":"https://api.github.com/users/Cheerazar/received_events","type":"User","site_admin":false},"body":"Recommend providing additional comments for invariant function invocation. ","created_at":"2015-01-05T23:46:36Z","updated_at":"2015-01-05T23:46:36Z","html_url":"https://github.com/TuxedoJS/TuxedoJS/pull/35#discussion_r22499053","pull_request_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/TuxedoJS/TuxedoJS/pulls/comments/22499053"},"html":{"href":"https://github.com/TuxedoJS/TuxedoJS/pull/35#discussion_r22499053"},"pull_request":{"href":"https://api.github.com/repos/TuxedoJS/TuxedoJS/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/pulls/35","id":26859397,"html_url":"https://github.com/TuxedoJS/TuxedoJS/pull/35","diff_url":"https://github.com/TuxedoJS/TuxedoJS/pull/35.diff","patch_url":"https://github.com/TuxedoJS/TuxedoJS/pull/35.patch","issue_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/issues/35","number":35,"state":"open","locked":false,"title":"Update error handling to take advantage of invariant syntax.","user":{"login":"drabinowitz","id":7275304,"avatar_url":"https://avatars.githubusercontent.com/u/7275304?v=3","gravatar_id":"","url":"https://api.github.com/users/drabinowitz","html_url":"https://github.com/drabinowitz","followers_url":"https://api.github.com/users/drabinowitz/followers","following_url":"https://api.github.com/users/drabinowitz/following{/other_user}","gists_url":"https://api.github.com/users/drabinowitz/gists{/gist_id}","starred_url":"https://api.github.com/users/drabinowitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drabinowitz/subscriptions","organizations_url":"https://api.github.com/users/drabinowitz/orgs","repos_url":"https://api.github.com/users/drabinowitz/repos","events_url":"https://api.github.com/users/drabinowitz/events{/privacy}","received_events_url":"https://api.github.com/users/drabinowitz/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-01-05T23:29:08Z","updated_at":"2015-01-05T23:46:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e95f32f9c962b2ea3eaa631438da06ab879f373c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/pulls/35/commits","review_comments_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/pulls/35/comments","review_comment_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/pulls/comments/{number}","comments_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/issues/35/comments","statuses_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/statuses/83fc8ea0f5f0dd1adefc5b4d10810e737872c659","head":{"label":"drabinowitz:updateTestsWithInvariantSyntax","ref":"updateTestsWithInvariantSyntax","sha":"83fc8ea0f5f0dd1adefc5b4d10810e737872c659","user":{"login":"drabinowitz","id":7275304,"avatar_url":"https://avatars.githubusercontent.com/u/7275304?v=3","gravatar_id":"","url":"https://api.github.com/users/drabinowitz","html_url":"https://github.com/drabinowitz","followers_url":"https://api.github.com/users/drabinowitz/followers","following_url":"https://api.github.com/users/drabinowitz/following{/other_user}","gists_url":"https://api.github.com/users/drabinowitz/gists{/gist_id}","starred_url":"https://api.github.com/users/drabinowitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drabinowitz/subscriptions","organizations_url":"https://api.github.com/users/drabinowitz/orgs","repos_url":"https://api.github.com/users/drabinowitz/repos","events_url":"https://api.github.com/users/drabinowitz/events{/privacy}","received_events_url":"https://api.github.com/users/drabinowitz/received_events","type":"User","site_admin":false},"repo":{"id":28604161,"name":"TuxedoJS","full_name":"drabinowitz/TuxedoJS","owner":{"login":"drabinowitz","id":7275304,"avatar_url":"https://avatars.githubusercontent.com/u/7275304?v=3","gravatar_id":"","url":"https://api.github.com/users/drabinowitz","html_url":"https://github.com/drabinowitz","followers_url":"https://api.github.com/users/drabinowitz/followers","following_url":"https://api.github.com/users/drabinowitz/following{/other_user}","gists_url":"https://api.github.com/users/drabinowitz/gists{/gist_id}","starred_url":"https://api.github.com/users/drabinowitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drabinowitz/subscriptions","organizations_url":"https://api.github.com/users/drabinowitz/orgs","repos_url":"https://api.github.com/users/drabinowitz/repos","events_url":"https://api.github.com/users/drabinowitz/events{/privacy}","received_events_url":"https://api.github.com/users/drabinowitz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drabinowitz/TuxedoJS","description":"","fork":true,"url":"https://api.github.com/repos/drabinowitz/TuxedoJS","forks_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/forks","keys_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/teams","hooks_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/hooks","issue_events_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/issues/events{/number}","events_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/events","assignees_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/assignees{/user}","branches_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/branches{/branch}","tags_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/tags","blobs_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/statuses/{sha}","languages_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/languages","stargazers_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/stargazers","contributors_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/contributors","subscribers_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/subscribers","subscription_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/subscription","commits_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/issues/comments/{number}","contents_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/contents/{+path}","compare_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/merges","archive_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/downloads","issues_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/issues{/number}","pulls_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/pulls{/number}","milestones_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/milestones{/number}","notifications_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/labels{/name}","releases_url":"https://api.github.com/repos/drabinowitz/TuxedoJS/releases{/id}","created_at":"2014-12-29T19:49:06Z","updated_at":"2014-12-18T21:58:57Z","pushed_at":"2015-01-05T23:24:37Z","git_url":"git://github.com/drabinowitz/TuxedoJS.git","ssh_url":"git@github.com:drabinowitz/TuxedoJS.git","clone_url":"https://github.com/drabinowitz/TuxedoJS.git","svn_url":"https://github.com/drabinowitz/TuxedoJS","homepage":null,"size":203,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TuxedoJS:master","ref":"master","sha":"e7748363d290dabfcb2c1b32d17f12ef6379cd5c","user":{"login":"TuxedoJS","id":10237217,"avatar_url":"https://avatars.githubusercontent.com/u/10237217?v=3","gravatar_id":"","url":"https://api.github.com/users/TuxedoJS","html_url":"https://github.com/TuxedoJS","followers_url":"https://api.github.com/users/TuxedoJS/followers","following_url":"https://api.github.com/users/TuxedoJS/following{/other_user}","gists_url":"https://api.github.com/users/TuxedoJS/gists{/gist_id}","starred_url":"https://api.github.com/users/TuxedoJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TuxedoJS/subscriptions","organizations_url":"https://api.github.com/users/TuxedoJS/orgs","repos_url":"https://api.github.com/users/TuxedoJS/repos","events_url":"https://api.github.com/users/TuxedoJS/events{/privacy}","received_events_url":"https://api.github.com/users/TuxedoJS/received_events","type":"Organization","site_admin":false},"repo":{"id":28203450,"name":"TuxedoJS","full_name":"TuxedoJS/TuxedoJS","owner":{"login":"TuxedoJS","id":10237217,"avatar_url":"https://avatars.githubusercontent.com/u/10237217?v=3","gravatar_id":"","url":"https://api.github.com/users/TuxedoJS","html_url":"https://github.com/TuxedoJS","followers_url":"https://api.github.com/users/TuxedoJS/followers","following_url":"https://api.github.com/users/TuxedoJS/following{/other_user}","gists_url":"https://api.github.com/users/TuxedoJS/gists{/gist_id}","starred_url":"https://api.github.com/users/TuxedoJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TuxedoJS/subscriptions","organizations_url":"https://api.github.com/users/TuxedoJS/orgs","repos_url":"https://api.github.com/users/TuxedoJS/repos","events_url":"https://api.github.com/users/TuxedoJS/events{/privacy}","received_events_url":"https://api.github.com/users/TuxedoJS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TuxedoJS/TuxedoJS","description":"","fork":false,"url":"https://api.github.com/repos/TuxedoJS/TuxedoJS","forks_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/forks","keys_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/teams","hooks_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/hooks","issue_events_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/issues/events{/number}","events_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/events","assignees_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/assignees{/user}","branches_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/branches{/branch}","tags_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/tags","blobs_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/statuses/{sha}","languages_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/languages","stargazers_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/stargazers","contributors_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/contributors","subscribers_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/subscribers","subscription_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/subscription","commits_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/issues/comments/{number}","contents_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/contents/{+path}","compare_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/merges","archive_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/downloads","issues_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/issues{/number}","pulls_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/pulls{/number}","milestones_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/milestones{/number}","notifications_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/labels{/name}","releases_url":"https://api.github.com/repos/TuxedoJS/TuxedoJS/releases{/id}","created_at":"2014-12-18T21:58:57Z","updated_at":"2015-01-05T22:22:24Z","pushed_at":"2015-01-05T22:22:24Z","git_url":"git://github.com/TuxedoJS/TuxedoJS.git","ssh_url":"git@github.com:TuxedoJS/TuxedoJS.git","clone_url":"https://github.com/TuxedoJS/TuxedoJS.git","svn_url":"https://github.com/TuxedoJS/TuxedoJS","homepage":null,"size":277,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":16,"forks":4,"open_issues":16,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TuxedoJS/TuxedoJS/pulls/35"},"html":{"href":"https://github.com/TuxedoJS/TuxedoJS/pull/35"},"issue":{"href":"https://api.github.com/repos/TuxedoJS/TuxedoJS/issues/35"},"comments":{"href":"https://api.github.com/repos/TuxedoJS/TuxedoJS/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/TuxedoJS/TuxedoJS/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/TuxedoJS/TuxedoJS/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/TuxedoJS/TuxedoJS/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/TuxedoJS/TuxedoJS/statuses/83fc8ea0f5f0dd1adefc5b4d10810e737872c659"}}}}