{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/26312","labels_url":"https://api.github.com/repos/saltstack/salt/issues/26312/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/26312/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/26312/events","html_url":"https://github.com/saltstack/salt/pull/26312","id":100911360,"number":26312,"title":"allow vpc_name instead of vpc_id for boto_secgroup","user":{"login":"scoates","id":71983,"avatar_url":"https://avatars.githubusercontent.com/u/71983?v=3","gravatar_id":"","url":"https://api.github.com/users/scoates","html_url":"https://github.com/scoates","followers_url":"https://api.github.com/users/scoates/followers","following_url":"https://api.github.com/users/scoates/following{/other_user}","gists_url":"https://api.github.com/users/scoates/gists{/gist_id}","starred_url":"https://api.github.com/users/scoates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scoates/subscriptions","organizations_url":"https://api.github.com/users/scoates/orgs","repos_url":"https://api.github.com/users/scoates/repos","events_url":"https://api.github.com/users/scoates/events{/privacy}","received_events_url":"https://api.github.com/users/scoates/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/saltstack/salt/labels/Execution%20Module","name":"Execution Module","color":"006b75"},{"url":"https://api.github.com/repos/saltstack/salt/labels/Medium%20Change","name":"Medium Change","color":"d4c5f9"},{"url":"https://api.github.com/repos/saltstack/salt/labels/Pending%20Discussion","name":"Pending Discussion","color":"c7def8"},{"url":"https://api.github.com/repos/saltstack/salt/labels/RIoT","name":"RIoT","color":"fef2c0"},{"url":"https://api.github.com/repos/saltstack/salt/labels/State%20Module","name":"State Module","color":"006b75"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-08-14T01:59:52Z","updated_at":"2015-08-14T17:51:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/26312","html_url":"https://github.com/saltstack/salt/pull/26312","diff_url":"https://github.com/saltstack/salt/pull/26312.diff","patch_url":"https://github.com/saltstack/salt/pull/26312.patch"},"body":"When creating a VPC with `boto_vpc.present`, the remote end (the AWS API) determines the `vpc_id`. To make further additions in `boto_vpc`, you can use the `vpc_name` instead of the `vpc_id` because the `vpc_id` is not known (declaratively).\r\n\r\nUnfortunately, this functionality was missing from `boto_secgroup`, which expected `vpc_id` only. Since we create VPCs with `boto_vpc`, it's not possible to know the `vpc_id` in our salt states (when writing declarative states). Thus, we need to be able to provide the `vpc_name`.\r\n\r\nThis patch allows for `vpc_name`."},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/131193942","html_url":"https://github.com/saltstack/salt/pull/26312#issuecomment-131193942","issue_url":"https://api.github.com/repos/saltstack/salt/issues/26312","id":131193942,"user":{"login":"scoates","id":71983,"avatar_url":"https://avatars.githubusercontent.com/u/71983?v=3","gravatar_id":"","url":"https://api.github.com/users/scoates","html_url":"https://github.com/scoates","followers_url":"https://api.github.com/users/scoates/followers","following_url":"https://api.github.com/users/scoates/following{/other_user}","gists_url":"https://api.github.com/users/scoates/gists{/gist_id}","starred_url":"https://api.github.com/users/scoates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scoates/subscriptions","organizations_url":"https://api.github.com/users/scoates/orgs","repos_url":"https://api.github.com/users/scoates/repos","events_url":"https://api.github.com/users/scoates/events{/privacy}","received_events_url":"https://api.github.com/users/scoates/received_events","type":"User","site_admin":false},"created_at":"2015-08-14T17:51:16Z","updated_at":"2015-08-14T17:51:16Z","body":"Yep. Good call. I was concerned about mixing module dependencies together, and didn't realize this was already done. Will do. Especially now that I know how to run tests. (-;"}}