{"action":"created","issue":{"url":"https://api.github.com/repos/pentaho/pentaho-platform/issues/2453","labels_url":"https://api.github.com/repos/pentaho/pentaho-platform/issues/2453/labels{/name}","comments_url":"https://api.github.com/repos/pentaho/pentaho-platform/issues/2453/comments","events_url":"https://api.github.com/repos/pentaho/pentaho-platform/issues/2453/events","html_url":"https://github.com/pentaho/pentaho-platform/pull/2453","id":102413207,"number":2453,"title":"[PDI-13961] Spoon firstly tries to conect via JNDI although connection type is JDBC","user":{"login":"akhayrutdinov","id":7514251,"avatar_url":"https://avatars.githubusercontent.com/u/7514251?v=3","gravatar_id":"","url":"https://api.github.com/users/akhayrutdinov","html_url":"https://github.com/akhayrutdinov","followers_url":"https://api.github.com/users/akhayrutdinov/followers","following_url":"https://api.github.com/users/akhayrutdinov/following{/other_user}","gists_url":"https://api.github.com/users/akhayrutdinov/gists{/gist_id}","starred_url":"https://api.github.com/users/akhayrutdinov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhayrutdinov/subscriptions","organizations_url":"https://api.github.com/users/akhayrutdinov/orgs","repos_url":"https://api.github.com/users/akhayrutdinov/repos","events_url":"https://api.github.com/users/akhayrutdinov/events{/privacy}","received_events_url":"https://api.github.com/users/akhayrutdinov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-08-21T16:15:29Z","updated_at":"2015-08-26T00:53:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pentaho/pentaho-platform/pulls/2453","html_url":"https://github.com/pentaho/pentaho-platform/pull/2453","diff_url":"https://github.com/pentaho/pentaho-platform/pull/2453.diff","patch_url":"https://github.com/pentaho/pentaho-platform/pull/2453.patch"},"body":"- introduce two interfaces for sharing different data source providers\r\n- update PlatformKettleDataSourceProvider to implement new method in DataSourceProviderInterface\r\n\r\n@pentaho-nbaker, @rmansoor, please review it.\r\nThis PR comes together with https://github.com/pentaho/pentaho-kettle/pull/1655 and **should not be merged before it**\r\n/cc @pamval "},"comment":{"url":"https://api.github.com/repos/pentaho/pentaho-platform/issues/comments/134780818","html_url":"https://github.com/pentaho/pentaho-platform/pull/2453#issuecomment-134780818","issue_url":"https://api.github.com/repos/pentaho/pentaho-platform/issues/2453","id":134780818,"user":{"login":"rmansoor","id":866980,"avatar_url":"https://avatars.githubusercontent.com/u/866980?v=3","gravatar_id":"","url":"https://api.github.com/users/rmansoor","html_url":"https://github.com/rmansoor","followers_url":"https://api.github.com/users/rmansoor/followers","following_url":"https://api.github.com/users/rmansoor/following{/other_user}","gists_url":"https://api.github.com/users/rmansoor/gists{/gist_id}","starred_url":"https://api.github.com/users/rmansoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmansoor/subscriptions","organizations_url":"https://api.github.com/users/rmansoor/orgs","repos_url":"https://api.github.com/users/rmansoor/repos","events_url":"https://api.github.com/users/rmansoor/events{/privacy}","received_events_url":"https://api.github.com/users/rmansoor/received_events","type":"User","site_admin":false},"created_at":"2015-08-26T00:53:44Z","updated_at":"2015-08-26T00:53:44Z","body":"@akhayrutdinov the code looks ok. I did notice that none of the unit tests were change. Were they all working with this change. I do have to download this locally and run some test before I process this pull request."}}