{"push_id":695367305,"size":2,"distinct_size":2,"ref":"refs/heads/stable/kilo","head":"c61c0437307b9d7076d8ef0fb98bcdb890278979","before":"5cc06138332a06334fa1d4fa28e71c59d58f8aca","commits":[{"sha":"053fd30cbc1f71c7854150beab5f81292e222afe","author":{"email":"793d6d7c60bd6329d6f91fdb8c1b53aab99bf3da@michali.net","name":"Paul Michali"},"message":"VPNaaS: Fix breakage in status reporting\n\nIn the plugin, the status for the VPN service and its connections\nare only updated if there is a change in the status or if the\npending_status_update flag is set. This flag is supposed to be\nset when the status changes and the database has the resource in\nPENDING_* state.\n\nIn the failure case, when the connection is created, the service\nand connection are in PENDING_CREATE state in the plugin. In the\ndevice driver, because of the create the service is set to ACTIVE\nand its pending_status_update flag is set. The connection will be\nin either DOWN or ACTIVE state and the pending_status_update_flag\nis set. This is as expected.\n\nWhen the device driver is about to report, it reads the latest\nstatus and updates it, before reporting. This is where the bug\noccurred.\n\nBecause of the recent change for translating the FQDN of peer to\nIP address, if that fails, it attempts to set the status to ERROR\nand force an update by setting updated_pending_status (so that it\nupdates, even if in pending state). However, the implementation\nis set the updated_pending_status flag based on this \"force\" flag,\nwhich is by default, false.\n\nAs a result, the flag gets cleared before the first report is sent\nand the connection is never updated from then on (because it never\nchecks again to see if in PENDING_* state).\n\nThe fix is to simply only update the pending_status_update, when\nthe forced flag is set, otherwise leave it alone so that the flag\nis not cleared on the first report.\n\nIn the future, this shoudl be reworked to a simpler mechanism that\njust checks previous vs current status and reports any change, and\nthe plugin unconditionally updates the status.\n\nChange-Id: Id49e54c49f3c72f676b6f2513288c0eae2c6db7b\nCloses-Bug: #1440655\n(cherry picked from commit 462a1165d8f347ff5afa08aa502436ee7d4dc9dd)","distinct":true,"url":"https://api.github.com/repos/openstack/neutron-vpnaas/commits/053fd30cbc1f71c7854150beab5f81292e222afe"},{"sha":"c61c0437307b9d7076d8ef0fb98bcdb890278979","author":{"email":"d95b56ce41a2e1ac4cecdd398defd7414407cc08@review.openstack.org","name":"Jenkins"},"message":"Merge \"VPNaaS: Fix breakage in status reporting\" into stable/kilo","distinct":true,"url":"https://api.github.com/repos/openstack/neutron-vpnaas/commits/c61c0437307b9d7076d8ef0fb98bcdb890278979"}]}