{"action":"created","issue":{"url":"https://api.github.com/repos/neos/neos-development-collection/issues/21","labels_url":"https://api.github.com/repos/neos/neos-development-collection/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/neos/neos-development-collection/issues/21/comments","events_url":"https://api.github.com/repos/neos/neos-development-collection/issues/21/events","html_url":"https://github.com/neos/neos-development-collection/pull/21","id":103685667,"number":21,"title":"[FEATURE] Thumbnail Generator Strategy for advanced thumbnails","user":{"login":"dfeyer","id":221173,"avatar_url":"https://avatars.githubusercontent.com/u/221173?v=3","gravatar_id":"","url":"https://api.github.com/users/dfeyer","html_url":"https://github.com/dfeyer","followers_url":"https://api.github.com/users/dfeyer/followers","following_url":"https://api.github.com/users/dfeyer/following{/other_user}","gists_url":"https://api.github.com/users/dfeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/dfeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfeyer/subscriptions","organizations_url":"https://api.github.com/users/dfeyer/orgs","repos_url":"https://api.github.com/users/dfeyer/repos","events_url":"https://api.github.com/users/dfeyer/events{/privacy}","received_events_url":"https://api.github.com/users/dfeyer/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/neos/neos-development-collection/labels/P:%20Media","name":"P: Media","color":"0052cc"},{"url":"https://api.github.com/repos/neos/neos-development-collection/labels/T:%20PHP","name":"T: PHP","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"dfeyer","id":221173,"avatar_url":"https://avatars.githubusercontent.com/u/221173?v=3","gravatar_id":"","url":"https://api.github.com/users/dfeyer","html_url":"https://github.com/dfeyer","followers_url":"https://api.github.com/users/dfeyer/followers","following_url":"https://api.github.com/users/dfeyer/following{/other_user}","gists_url":"https://api.github.com/users/dfeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/dfeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfeyer/subscriptions","organizations_url":"https://api.github.com/users/dfeyer/orgs","repos_url":"https://api.github.com/users/dfeyer/repos","events_url":"https://api.github.com/users/dfeyer/events{/privacy}","received_events_url":"https://api.github.com/users/dfeyer/received_events","type":"User","site_admin":false},"milestone":null,"comments":32,"created_at":"2015-08-28T09:38:19Z","updated_at":"2015-11-29T13:32:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/neos/neos-development-collection/pulls/21","html_url":"https://github.com/neos/neos-development-collection/pull/21","diff_url":"https://github.com/neos/neos-development-collection/pull/21.diff","patch_url":"https://github.com/neos/neos-development-collection/pull/21.patch"},"body":"Implements strategies to select to generate a thumbnail. A developper\r\ncan add new generator by implementing the interface ``ThumbnailGeneratorInterface``.\r\nA generator can have a priority and can implement a method ``canRefresh``\r\nto decide if it can handle the current asset.\r\n\r\nThis change include the following generators:\r\n\r\n- DocumentThumbnailGenerator (PDF, EPS, AI)\r\n- FontDocumentThumbnailGenerator (TTF, OTF)\r\n- ImageThumbnailGenerator (image formats supported by ``Imagick``)\r\n\r\nYou must use the ``Imagick`` driver to enable use of those generators.\r\nOnly the ImageThumbnailGenerator is supported by all drivers\r\n(GD, Imagick, Gmagick)\r\n\r\nResolves: NEOS-1165"},"comment":{"url":"https://api.github.com/repos/neos/neos-development-collection/issues/comments/160416816","html_url":"https://github.com/neos/neos-development-collection/pull/21#issuecomment-160416816","issue_url":"https://api.github.com/repos/neos/neos-development-collection/issues/21","id":160416816,"user":{"login":"aertmann","id":903567,"avatar_url":"https://avatars.githubusercontent.com/u/903567?v=3","gravatar_id":"","url":"https://api.github.com/users/aertmann","html_url":"https://github.com/aertmann","followers_url":"https://api.github.com/users/aertmann/followers","following_url":"https://api.github.com/users/aertmann/following{/other_user}","gists_url":"https://api.github.com/users/aertmann/gists{/gist_id}","starred_url":"https://api.github.com/users/aertmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aertmann/subscriptions","organizations_url":"https://api.github.com/users/aertmann/orgs","repos_url":"https://api.github.com/users/aertmann/repos","events_url":"https://api.github.com/users/aertmann/events{/privacy}","received_events_url":"https://api.github.com/users/aertmann/received_events","type":"User","site_admin":false},"created_at":"2015-11-29T13:32:22Z","updated_at":"2015-11-29T13:32:22Z","body":"Thanks for taking care of the adjustments. I'm fine with the way it is now and don't really see any good ways to make improve it.\r\n\r\nRegarding configurable priority, there's a difference between the type converters and these strategies in the way that you might want to configure the default ones differently and not just override them like you do with type converters. There you always have to write a new class with higher priority to customize, but that would be very cumbersome having to do just to remove a strategy e.g. To keep ``getPriority`` static, that logic has to be done outside the generators. Pushed a PR with those changes, see https://github.com/dfeyer/neos-development-collection/pull/3"}}