{"action":"created","comment":{"url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/pulls/comments/27238505","id":27238505,"diff_hunk":"@@ -37,7 +40,16 @@ public CSVRiver(RiverName riverName, RiverSettings settings, Client client) {\n \n         config = new Configuration(settings, riverName.name());\n \n-        listener = new DelegatingFileProcessorListener(this, new BashFileProcessorListener(logger, config));\n+        ProcessRunnerFactory processRunnerFactory;\n+\n+        if (System.getProperty(\"os.name\").toLowerCase().contains(\"windows\")) {","path":"src/main/groovy/org/agileworks/elasticsearch/river/csv/CSVRiver.java","position":17,"original_position":17,"commit_id":"57ab9c6daedc48b2a8434583302627fe04c3299f","original_commit_id":"57ab9c6daedc48b2a8434583302627fe04c3299f","user":{"login":"vtajzich","id":1038312,"avatar_url":"https://avatars.githubusercontent.com/u/1038312?v=3","gravatar_id":"","url":"https://api.github.com/users/vtajzich","html_url":"https://github.com/vtajzich","followers_url":"https://api.github.com/users/vtajzich/followers","following_url":"https://api.github.com/users/vtajzich/following{/other_user}","gists_url":"https://api.github.com/users/vtajzich/gists{/gist_id}","starred_url":"https://api.github.com/users/vtajzich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vtajzich/subscriptions","organizations_url":"https://api.github.com/users/vtajzich/orgs","repos_url":"https://api.github.com/users/vtajzich/repos","events_url":"https://api.github.com/users/vtajzich/events{/privacy}","received_events_url":"https://api.github.com/users/vtajzich/received_events","type":"User","site_admin":false},"body":"I did not say it clearly. I wanted to move this decision to the factory. So, there should be only one which will decide which runner will be used. Something like:\r\n\r\n```\r\nprocessRunnerFactory.getInstance().getRunner()\r\n```","created_at":"2015-03-26T17:56:37Z","updated_at":"2015-03-26T17:56:37Z","html_url":"https://github.com/AgileWorksOrg/elasticsearch-river-csv/pull/52#discussion_r27238505","pull_request_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/pulls/52","_links":{"self":{"href":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/pulls/comments/27238505"},"html":{"href":"https://github.com/AgileWorksOrg/elasticsearch-river-csv/pull/52#discussion_r27238505"},"pull_request":{"href":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/pulls/52"}}},"pull_request":{"url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/pulls/52","id":31850532,"html_url":"https://github.com/AgileWorksOrg/elasticsearch-river-csv/pull/52","diff_url":"https://github.com/AgileWorksOrg/elasticsearch-river-csv/pull/52.diff","patch_url":"https://github.com/AgileWorksOrg/elasticsearch-river-csv/pull/52.patch","issue_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/issues/52","number":52,"state":"open","locked":false,"title":"Run bash, powershell and \"Windows script host\" files in a Windows environment directly.","user":{"login":"ESPNSTI","id":11448987,"avatar_url":"https://avatars.githubusercontent.com/u/11448987?v=3","gravatar_id":"","url":"https://api.github.com/users/ESPNSTI","html_url":"https://github.com/ESPNSTI","followers_url":"https://api.github.com/users/ESPNSTI/followers","following_url":"https://api.github.com/users/ESPNSTI/following{/other_user}","gists_url":"https://api.github.com/users/ESPNSTI/gists{/gist_id}","starred_url":"https://api.github.com/users/ESPNSTI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ESPNSTI/subscriptions","organizations_url":"https://api.github.com/users/ESPNSTI/orgs","repos_url":"https://api.github.com/users/ESPNSTI/repos","events_url":"https://api.github.com/users/ESPNSTI/events{/privacy}","received_events_url":"https://api.github.com/users/ESPNSTI/received_events","type":"User","site_admin":false},"body":"Running bash, Powershell and \"Windows script host\" files directly by specifying just the script file name in \"script_before_all\", \"script_after_all\", \"script_before_file\" or \"script_after_file\", did not work in a Windows environment.\r\nIt seems that only traditional Windows executable types such as Exe, Com or Bat files worked for this.\r\n\r\nThis change adds code to enable running bash scripts if the script file extension is \".sh\", powershell scripts if the extension is \".ps1\" and Windows script host files if the extension is \".wsf\", \".wsh\", \".vbs\" or \".js\".","created_at":"2015-03-24T17:32:59Z","updated_at":"2015-03-26T17:56:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4285c6db46d7729da7113ca7a7bdcd9ecd75eb11","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/pulls/52/commits","review_comments_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/pulls/52/comments","review_comment_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/issues/52/comments","statuses_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/statuses/57ab9c6daedc48b2a8434583302627fe04c3299f","head":{"label":"ESPNSTI:additional_runnable_windows_script_types","ref":"additional_runnable_windows_script_types","sha":"57ab9c6daedc48b2a8434583302627fe04c3299f","user":{"login":"ESPNSTI","id":11448987,"avatar_url":"https://avatars.githubusercontent.com/u/11448987?v=3","gravatar_id":"","url":"https://api.github.com/users/ESPNSTI","html_url":"https://github.com/ESPNSTI","followers_url":"https://api.github.com/users/ESPNSTI/followers","following_url":"https://api.github.com/users/ESPNSTI/following{/other_user}","gists_url":"https://api.github.com/users/ESPNSTI/gists{/gist_id}","starred_url":"https://api.github.com/users/ESPNSTI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ESPNSTI/subscriptions","organizations_url":"https://api.github.com/users/ESPNSTI/orgs","repos_url":"https://api.github.com/users/ESPNSTI/repos","events_url":"https://api.github.com/users/ESPNSTI/events{/privacy}","received_events_url":"https://api.github.com/users/ESPNSTI/received_events","type":"User","site_admin":false},"repo":{"id":32108100,"name":"elasticsearch-river-csv","full_name":"ESPNSTI/elasticsearch-river-csv","owner":{"login":"ESPNSTI","id":11448987,"avatar_url":"https://avatars.githubusercontent.com/u/11448987?v=3","gravatar_id":"","url":"https://api.github.com/users/ESPNSTI","html_url":"https://github.com/ESPNSTI","followers_url":"https://api.github.com/users/ESPNSTI/followers","following_url":"https://api.github.com/users/ESPNSTI/following{/other_user}","gists_url":"https://api.github.com/users/ESPNSTI/gists{/gist_id}","starred_url":"https://api.github.com/users/ESPNSTI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ESPNSTI/subscriptions","organizations_url":"https://api.github.com/users/ESPNSTI/orgs","repos_url":"https://api.github.com/users/ESPNSTI/repos","events_url":"https://api.github.com/users/ESPNSTI/events{/privacy}","received_events_url":"https://api.github.com/users/ESPNSTI/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ESPNSTI/elasticsearch-river-csv","description":"CSV river for ElasticSearch","fork":true,"url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv","forks_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/forks","keys_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/teams","hooks_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/hooks","issue_events_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/issues/events{/number}","events_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/events","assignees_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/assignees{/user}","branches_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/branches{/branch}","tags_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/tags","blobs_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/git/refs{/sha}","trees_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/statuses/{sha}","languages_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/languages","stargazers_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/stargazers","contributors_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/contributors","subscribers_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/subscribers","subscription_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/subscription","commits_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/commits{/sha}","git_commits_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/git/commits{/sha}","comments_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/comments{/number}","issue_comment_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/issues/comments{/number}","contents_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/contents/{+path}","compare_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/merges","archive_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/downloads","issues_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/issues{/number}","pulls_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/pulls{/number}","milestones_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/milestones{/number}","notifications_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/labels{/name}","releases_url":"https://api.github.com/repos/ESPNSTI/elasticsearch-river-csv/releases{/id}","created_at":"2015-03-12T23:08:36Z","updated_at":"2015-03-17T19:39:23Z","pushed_at":"2015-03-26T14:13:39Z","git_url":"git://github.com/ESPNSTI/elasticsearch-river-csv.git","ssh_url":"git@github.com:ESPNSTI/elasticsearch-river-csv.git","clone_url":"https://github.com/ESPNSTI/elasticsearch-river-csv.git","svn_url":"https://github.com/ESPNSTI/elasticsearch-river-csv","homepage":null,"size":203,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AgileWorksOrg:master","ref":"master","sha":"96b77ad9bf7adb8555811a1b36d0f56725483ca3","user":{"login":"AgileWorksOrg","id":7228687,"avatar_url":"https://avatars.githubusercontent.com/u/7228687?v=3","gravatar_id":"","url":"https://api.github.com/users/AgileWorksOrg","html_url":"https://github.com/AgileWorksOrg","followers_url":"https://api.github.com/users/AgileWorksOrg/followers","following_url":"https://api.github.com/users/AgileWorksOrg/following{/other_user}","gists_url":"https://api.github.com/users/AgileWorksOrg/gists{/gist_id}","starred_url":"https://api.github.com/users/AgileWorksOrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AgileWorksOrg/subscriptions","organizations_url":"https://api.github.com/users/AgileWorksOrg/orgs","repos_url":"https://api.github.com/users/AgileWorksOrg/repos","events_url":"https://api.github.com/users/AgileWorksOrg/events{/privacy}","received_events_url":"https://api.github.com/users/AgileWorksOrg/received_events","type":"Organization","site_admin":false},"repo":{"id":7455573,"name":"elasticsearch-river-csv","full_name":"AgileWorksOrg/elasticsearch-river-csv","owner":{"login":"AgileWorksOrg","id":7228687,"avatar_url":"https://avatars.githubusercontent.com/u/7228687?v=3","gravatar_id":"","url":"https://api.github.com/users/AgileWorksOrg","html_url":"https://github.com/AgileWorksOrg","followers_url":"https://api.github.com/users/AgileWorksOrg/followers","following_url":"https://api.github.com/users/AgileWorksOrg/following{/other_user}","gists_url":"https://api.github.com/users/AgileWorksOrg/gists{/gist_id}","starred_url":"https://api.github.com/users/AgileWorksOrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AgileWorksOrg/subscriptions","organizations_url":"https://api.github.com/users/AgileWorksOrg/orgs","repos_url":"https://api.github.com/users/AgileWorksOrg/repos","events_url":"https://api.github.com/users/AgileWorksOrg/events{/privacy}","received_events_url":"https://api.github.com/users/AgileWorksOrg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AgileWorksOrg/elasticsearch-river-csv","description":"CSV river for ElasticSearch","fork":false,"url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv","forks_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/forks","keys_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/teams","hooks_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/hooks","issue_events_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/issues/events{/number}","events_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/events","assignees_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/assignees{/user}","branches_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/branches{/branch}","tags_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/tags","blobs_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/git/refs{/sha}","trees_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/statuses/{sha}","languages_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/languages","stargazers_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/stargazers","contributors_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/contributors","subscribers_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/subscribers","subscription_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/subscription","commits_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/commits{/sha}","git_commits_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/git/commits{/sha}","comments_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/comments{/number}","issue_comment_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/issues/comments{/number}","contents_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/contents/{+path}","compare_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/merges","archive_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/downloads","issues_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/issues{/number}","pulls_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/pulls{/number}","milestones_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/milestones{/number}","notifications_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/labels{/name}","releases_url":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/releases{/id}","created_at":"2013-01-05T13:22:23Z","updated_at":"2015-03-25T13:35:26Z","pushed_at":"2015-03-26T14:13:39Z","git_url":"git://github.com/AgileWorksOrg/elasticsearch-river-csv.git","ssh_url":"git@github.com:AgileWorksOrg/elasticsearch-river-csv.git","clone_url":"https://github.com/AgileWorksOrg/elasticsearch-river-csv.git","svn_url":"https://github.com/AgileWorksOrg/elasticsearch-river-csv","homepage":null,"size":478,"stargazers_count":68,"watchers_count":68,"language":"Groovy","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":4,"forks":38,"open_issues":4,"watchers":68,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/pulls/52"},"html":{"href":"https://github.com/AgileWorksOrg/elasticsearch-river-csv/pull/52"},"issue":{"href":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/issues/52"},"comments":{"href":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/AgileWorksOrg/elasticsearch-river-csv/statuses/57ab9c6daedc48b2a8434583302627fe04c3299f"}}}}