{"action":"created","issue":{"url":"https://api.github.com/repos/aslagle/reactive-table/issues/243","labels_url":"https://api.github.com/repos/aslagle/reactive-table/issues/243/labels{/name}","comments_url":"https://api.github.com/repos/aslagle/reactive-table/issues/243/comments","events_url":"https://api.github.com/repos/aslagle/reactive-table/issues/243/events","html_url":"https://github.com/aslagle/reactive-table/issues/243","id":92876052,"number":243,"title":"Problems with column toggling dropdown","user":{"login":"57even","id":4533204,"avatar_url":"https://avatars.githubusercontent.com/u/4533204?v=3","gravatar_id":"","url":"https://api.github.com/users/57even","html_url":"https://github.com/57even","followers_url":"https://api.github.com/users/57even/followers","following_url":"https://api.github.com/users/57even/following{/other_user}","gists_url":"https://api.github.com/users/57even/gists{/gist_id}","starred_url":"https://api.github.com/users/57even/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/57even/subscriptions","organizations_url":"https://api.github.com/users/57even/orgs","repos_url":"https://api.github.com/users/57even/repos","events_url":"https://api.github.com/users/57even/events{/privacy}","received_events_url":"https://api.github.com/users/57even/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-03T13:27:55Z","updated_at":"2015-07-05T20:16:27Z","closed_at":null,"body":"You use `change .reactive-table-columns-dropdown input` to decide whether the user has toggled a column. But the template is:\r\n\r\n    <li>\r\n      <a tabindex=\"-1\" data-target=\"#\">\r\n          <label>\r\n            {{#if isVisible}}\r\n              <input type=\"checkbox\" checked data-fieldid=\"{{fieldId}}\">\r\n            {{else}}\r\n              <input type=\"checkbox\" data-fieldid=\"{{fieldId}}\">\r\n            {{/if}}\r\n            {{#if labelIsTemplate}}{{#with labelData}}{{> ../label}}{{/with}}{{else}}{{getLabel}}{{/if}}\r\n          </label>\r\n        </a>\r\n    </li>\r\n\r\nI think it would give a better UX if the entire `<li>` was clickable. When using `<li>` in the bootstrap dropdown the entire `<li>` appears to be clickable but the column is only toggled if the user clicks exactly on the label/checkbox (the label will often fill most of the `<li>` but not always).\r\n\r\nWouldn't it be better not to use the checkbox and instead color the `<li>` if it is toggled and thus 'allow' clicks on the entire `<li>`?"},"comment":{"url":"https://api.github.com/repos/aslagle/reactive-table/issues/comments/118663341","html_url":"https://github.com/aslagle/reactive-table/issues/243#issuecomment-118663341","issue_url":"https://api.github.com/repos/aslagle/reactive-table/issues/243","id":118663341,"user":{"login":"aslagle","id":3409215,"avatar_url":"https://avatars.githubusercontent.com/u/3409215?v=3","gravatar_id":"","url":"https://api.github.com/users/aslagle","html_url":"https://github.com/aslagle","followers_url":"https://api.github.com/users/aslagle/followers","following_url":"https://api.github.com/users/aslagle/following{/other_user}","gists_url":"https://api.github.com/users/aslagle/gists{/gist_id}","starred_url":"https://api.github.com/users/aslagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aslagle/subscriptions","organizations_url":"https://api.github.com/users/aslagle/orgs","repos_url":"https://api.github.com/users/aslagle/repos","events_url":"https://api.github.com/users/aslagle/events{/privacy}","received_events_url":"https://api.github.com/users/aslagle/received_events","type":"User","site_admin":false},"created_at":"2015-07-05T20:16:27Z","updated_at":"2015-07-05T20:16:27Z","body":"Yes, thanks. Fixed in v0.8.5"}}