{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/41069710","id":41069710,"diff_hunk":"@@ -201,8 +207,22 @@ object ConsumerPerformance {\n       .withRequiredArg\n       .describedAs(\"count\")\n       .ofType(classOf[java.lang.Integer])\n-      .defaultsTo(1)\n+      .defaultsTo(1)    \n+    val propsFileOpt = parser.accepts(\"consumer.config\", \"External consumer properties file.\")\n+      .withRequiredArg\n+      .describedAs(\"consumer properties\")\n+      .ofType(classOf[java.lang.String])\n+      .defaultsTo(\"\")\n+    val freeformPropsOpt = parser.accepts(\"consumer-properties\", \"Freeform consumer properties in the format key=val,key=val,key=val...\")","path":"core/src/main/scala/kafka/tools/ConsumerPerformance.scala","position":98,"original_position":98,"commit_id":"149ee434ea1353a85c903965f2d05bc705b3a171","original_commit_id":"149ee434ea1353a85c903965f2d05bc705b3a171","user":{"login":"junrao","id":132330,"avatar_url":"https://avatars.githubusercontent.com/u/132330?v=3","gravatar_id":"","url":"https://api.github.com/users/junrao","html_url":"https://github.com/junrao","followers_url":"https://api.github.com/users/junrao/followers","following_url":"https://api.github.com/users/junrao/following{/other_user}","gists_url":"https://api.github.com/users/junrao/gists{/gist_id}","starred_url":"https://api.github.com/users/junrao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junrao/subscriptions","organizations_url":"https://api.github.com/users/junrao/orgs","repos_url":"https://api.github.com/users/junrao/repos","events_url":"https://api.github.com/users/junrao/events{/privacy}","received_events_url":"https://api.github.com/users/junrao/received_events","type":"User","site_admin":false},"body":"Do we need both consumer-properties and consumer.config? It seems that having one of the two is enough? If we want to keep both, perhaps we should do the same in ProducerPerformance.","created_at":"2015-10-02T21:28:37Z","updated_at":"2015-10-02T21:28:37Z","html_url":"https://github.com/apache/kafka/pull/217#discussion_r41069710","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/217","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/41069710"},"html":{"href":"https://github.com/apache/kafka/pull/217#discussion_r41069710"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/217"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/217","id":45002104,"html_url":"https://github.com/apache/kafka/pull/217","diff_url":"https://github.com/apache/kafka/pull/217.diff","patch_url":"https://github.com/apache/kafka/pull/217.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/217","number":217,"state":"open","locked":false,"title":"KAFKA-2431: Easier Testing of SSL","user":{"login":"benstopford","id":1297498,"avatar_url":"https://avatars.githubusercontent.com/u/1297498?v=3","gravatar_id":"","url":"https://api.github.com/users/benstopford","html_url":"https://github.com/benstopford","followers_url":"https://api.github.com/users/benstopford/followers","following_url":"https://api.github.com/users/benstopford/following{/other_user}","gists_url":"https://api.github.com/users/benstopford/gists{/gist_id}","starred_url":"https://api.github.com/users/benstopford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benstopford/subscriptions","organizations_url":"https://api.github.com/users/benstopford/orgs","repos_url":"https://api.github.com/users/benstopford/repos","events_url":"https://api.github.com/users/benstopford/events{/privacy}","received_events_url":"https://api.github.com/users/benstopford/received_events","type":"User","site_admin":false},"body":"- Allow cipher suites to be specified relevant properties\r\n- Avoid System.exit in ProducerPerformance so this can be externally invoked\r\n- Add command line option so that a default properties can be specified in ConsumerPerformance (needed for ssl properties)\r\n- Allow cipher suites to be specified via properties\r\n- Increase timeout in ConsumerPerformance (useful when running with SSL under load)\r\n- Use a relative default value for the reporting interval in Consumer Performance\r\n- Add option for show-all-stats (includes intermediary and summary stats) in Consumer Performance ","created_at":"2015-09-15T02:12:42Z","updated_at":"2015-10-02T21:28:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7950288ee85cd17462befe8e5155690a8123e3d3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/217/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/217/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/217/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/149ee434ea1353a85c903965f2d05bc705b3a171","head":{"label":"benstopford:ssl-1","ref":"ssl-1","sha":"149ee434ea1353a85c903965f2d05bc705b3a171","user":{"login":"benstopford","id":1297498,"avatar_url":"https://avatars.githubusercontent.com/u/1297498?v=3","gravatar_id":"","url":"https://api.github.com/users/benstopford","html_url":"https://github.com/benstopford","followers_url":"https://api.github.com/users/benstopford/followers","following_url":"https://api.github.com/users/benstopford/following{/other_user}","gists_url":"https://api.github.com/users/benstopford/gists{/gist_id}","starred_url":"https://api.github.com/users/benstopford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benstopford/subscriptions","organizations_url":"https://api.github.com/users/benstopford/orgs","repos_url":"https://api.github.com/users/benstopford/repos","events_url":"https://api.github.com/users/benstopford/events{/privacy}","received_events_url":"https://api.github.com/users/benstopford/received_events","type":"User","site_admin":false},"repo":{"id":40359697,"name":"kafka","full_name":"benstopford/kafka","owner":{"login":"benstopford","id":1297498,"avatar_url":"https://avatars.githubusercontent.com/u/1297498?v=3","gravatar_id":"","url":"https://api.github.com/users/benstopford","html_url":"https://github.com/benstopford","followers_url":"https://api.github.com/users/benstopford/followers","following_url":"https://api.github.com/users/benstopford/following{/other_user}","gists_url":"https://api.github.com/users/benstopford/gists{/gist_id}","starred_url":"https://api.github.com/users/benstopford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benstopford/subscriptions","organizations_url":"https://api.github.com/users/benstopford/orgs","repos_url":"https://api.github.com/users/benstopford/repos","events_url":"https://api.github.com/users/benstopford/events{/privacy}","received_events_url":"https://api.github.com/users/benstopford/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benstopford/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/benstopford/kafka","forks_url":"https://api.github.com/repos/benstopford/kafka/forks","keys_url":"https://api.github.com/repos/benstopford/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benstopford/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benstopford/kafka/teams","hooks_url":"https://api.github.com/repos/benstopford/kafka/hooks","issue_events_url":"https://api.github.com/repos/benstopford/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/benstopford/kafka/events","assignees_url":"https://api.github.com/repos/benstopford/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/benstopford/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/benstopford/kafka/tags","blobs_url":"https://api.github.com/repos/benstopford/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benstopford/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benstopford/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/benstopford/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benstopford/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/benstopford/kafka/languages","stargazers_url":"https://api.github.com/repos/benstopford/kafka/stargazers","contributors_url":"https://api.github.com/repos/benstopford/kafka/contributors","subscribers_url":"https://api.github.com/repos/benstopford/kafka/subscribers","subscription_url":"https://api.github.com/repos/benstopford/kafka/subscription","commits_url":"https://api.github.com/repos/benstopford/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/benstopford/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/benstopford/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/benstopford/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/benstopford/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/benstopford/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benstopford/kafka/merges","archive_url":"https://api.github.com/repos/benstopford/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benstopford/kafka/downloads","issues_url":"https://api.github.com/repos/benstopford/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/benstopford/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/benstopford/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/benstopford/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benstopford/kafka/labels{/name}","releases_url":"https://api.github.com/repos/benstopford/kafka/releases{/id}","created_at":"2015-08-07T12:36:48Z","updated_at":"2015-08-07T12:36:51Z","pushed_at":"2015-09-29T21:16:36Z","git_url":"git://github.com/benstopford/kafka.git","ssh_url":"git@github.com:benstopford/kafka.git","clone_url":"https://github.com/benstopford/kafka.git","svn_url":"https://github.com/benstopford/kafka","homepage":null,"size":22460,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"73720113b97ccfcd796a844f87438546ed2e09e4","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","created_at":"2011-08-15T18:06:16Z","updated_at":"2015-10-02T19:55:46Z","pushed_at":"2015-10-02T14:59:43Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":36248,"stargazers_count":1991,"watchers_count":1991,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1191,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":101,"forks":1191,"open_issues":101,"watchers":1991,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/217"},"html":{"href":"https://github.com/apache/kafka/pull/217"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/217"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/217/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/217/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/217/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/149ee434ea1353a85c903965f2d05bc705b3a171"}}}}