{"action":"created","issue":{"url":"https://api.github.com/repos/daledotshan/liferay-portal/issues/272","labels_url":"https://api.github.com/repos/daledotshan/liferay-portal/issues/272/labels{/name}","comments_url":"https://api.github.com/repos/daledotshan/liferay-portal/issues/272/comments","events_url":"https://api.github.com/repos/daledotshan/liferay-portal/issues/272/events","html_url":"https://github.com/daledotshan/liferay-portal/pull/272","id":94236413,"number":272,"title":"LPS-57007 [TECHNICAL SUPPORT] Expiration Date gone missing when publish the content from Staging to Live","user":{"login":"yuhai","id":1029227,"avatar_url":"https://avatars.githubusercontent.com/u/1029227?v=3","gravatar_id":"","url":"https://api.github.com/users/yuhai","html_url":"https://github.com/yuhai","followers_url":"https://api.github.com/users/yuhai/followers","following_url":"https://api.github.com/users/yuhai/following{/other_user}","gists_url":"https://api.github.com/users/yuhai/gists{/gist_id}","starred_url":"https://api.github.com/users/yuhai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuhai/subscriptions","organizations_url":"https://api.github.com/users/yuhai/orgs","repos_url":"https://api.github.com/users/yuhai/repos","events_url":"https://api.github.com/users/yuhai/events{/privacy}","received_events_url":"https://api.github.com/users/yuhai/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-10T07:21:43Z","updated_at":"2015-07-10T10:01:48Z","closed_at":"2015-07-10T10:01:48Z","pull_request":{"url":"https://api.github.com/repos/daledotshan/liferay-portal/pulls/272","html_url":"https://github.com/daledotshan/liferay-portal/pull/272","diff_url":"https://github.com/daledotshan/liferay-portal/pull/272.diff","patch_url":"https://github.com/daledotshan/liferay-portal/pull/272.patch"},"body":"The issue only occur in when expirationDate < publishDate(now date) and this article's status is not expired.\r\n\r\n**Why expirationDate < publishDate(now date) and this article's status is not expired?**\r\nDue to our schedule CheckArticleMessageListener don't execute in \"journal.article.check.interval\", so even though expirationDate is earlier than nowDate, the article isn't updated in journalArticle so that its status is not expired.\r\n\r\nThe fix refers to the logic regarding web content has expired (its status is expired in journalArticle table).\r\n\r\nIf we don't set expired status for those web content articles actually have expired, but their status still be approved(or scheduled, I think scheduled date should not later than expired date, this is another bug), once those articles are imported into one site, their expired date will be null. That is to say, if I don't any operations (for example, publish to live), these articles won't be expired.\r\n\r\nWhen using the fix, the logic will be returned in the below logic.\r\nWorkflowHandlerRegistryUtil.startWorkflowInstance() {\r\n               if (serviceContext.getWorkflowAction() !=\r\n\t\t\t\tWorkflowConstants.ACTION_PUBLISH) {\r\n\r\n\t\t\treturn model;\r\n\t\t}\r\n} \r\n\r\nThe issue occur in the logic enter JournalArticleLocalServiceImpl.updateStatus(), in there, expireDate is set for null.\r\n\r\nThanks,\r\nHai"},"comment":{"url":"https://api.github.com/repos/daledotshan/liferay-portal/issues/comments/120332042","html_url":"https://github.com/daledotshan/liferay-portal/pull/272#issuecomment-120332042","issue_url":"https://api.github.com/repos/daledotshan/liferay-portal/issues/272","id":120332042,"user":{"login":"daledotshan","id":861683,"avatar_url":"https://avatars.githubusercontent.com/u/861683?v=3","gravatar_id":"","url":"https://api.github.com/users/daledotshan","html_url":"https://github.com/daledotshan","followers_url":"https://api.github.com/users/daledotshan/followers","following_url":"https://api.github.com/users/daledotshan/following{/other_user}","gists_url":"https://api.github.com/users/daledotshan/gists{/gist_id}","starred_url":"https://api.github.com/users/daledotshan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daledotshan/subscriptions","organizations_url":"https://api.github.com/users/daledotshan/orgs","repos_url":"https://api.github.com/users/daledotshan/repos","events_url":"https://api.github.com/users/daledotshan/events{/privacy}","received_events_url":"https://api.github.com/users/daledotshan/received_events","type":"User","site_admin":false},"created_at":"2015-07-10T10:01:47Z","updated_at":"2015-07-10T10:01:47Z","body":"see\r\nhttps://github.com/hhuijser/liferay-portal/pull/2409"}}