{"action":"created","comment":{"url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/pulls/comments/23136841","id":23136841,"diff_hunk":"@@ -207,13 +207,67 @@ private void HandleIdentifierNameSyntax(SyntaxNodeAnalysisContext context)\n             default:\n                 return;\n             }\n-\n+            \n             SyntaxNode locationNode = identifierNameSyntax;\n             if (identifierNameSyntax.Parent is QualifiedNameSyntax)\n                 locationNode = identifierNameSyntax.Parent;\n \n+            // Allow nameof\n+            if(IsInNameOfExpression(identifierNameSyntax, semanticModel))\n+            {\n+                return;\n+            }\n+\n             // Use built-in type alias\n             context.ReportDiagnostic(Diagnostic.Create(Descriptor, locationNode.GetLocation()));\n         }\n+\n+        private bool IsInNameOfExpression(IdentifierNameSyntax identifierNameSyntax, SemanticModel semanticModel)","path":"StyleCop.Analyzers/StyleCop.Analyzers/ReadabilityRules/SA1121UseBuiltInTypeAlias.cs","position":20,"original_position":20,"commit_id":"ceb3a39ba4aa38d4b247a9e9a76a84a969e2ab46","original_commit_id":"ceb3a39ba4aa38d4b247a9e9a76a84a969e2ab46","user":{"login":"sharwell","id":1408396,"avatar_url":"https://avatars.githubusercontent.com/u/1408396?v=3","gravatar_id":"","url":"https://api.github.com/users/sharwell","html_url":"https://github.com/sharwell","followers_url":"https://api.github.com/users/sharwell/followers","following_url":"https://api.github.com/users/sharwell/following{/other_user}","gists_url":"https://api.github.com/users/sharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharwell/subscriptions","organizations_url":"https://api.github.com/users/sharwell/orgs","repos_url":"https://api.github.com/users/sharwell/repos","events_url":"https://api.github.com/users/sharwell/events{/privacy}","received_events_url":"https://api.github.com/users/sharwell/received_events","type":"User","site_admin":false},"body":"It seems this entire method could be simplified to the following:\r\n\r\n```csharp\r\nprivate bool IsNameInNameOfExpression(IdentifierNameSyntax identifierNameSyntax)\r\n{\r\n    // The only time a type name can appear as an argument is for the invocation expression created for the\r\n    // nameof keyword. This assumption is the foundation of the following simple analysis algorithm.\r\n\r\n    if (identifierNameSyntax.Parent == null)\r\n        return false;\r\n\r\n    // This covers the case nameof(Int32)\r\n    if (identifierNameSyntax.Parent is ArgumentSyntax)\r\n        return true;\r\n\r\n    // This covers the case nameof(System.Int32)\r\n    if (identifierNameSyntax.Parent.IsKind(SyntaxKind.SimpleMemberAccessExpression))\r\n    {\r\n        // This final check ensures that we don't consider nameof(System.Int32.ToString) the same as\r\n        // nameof(System.Int32)\r\n        if (identifierNameSyntax.Parent.Parent is ArgumentSyntax)\r\n            return true;\r\n    }\r\n\r\n    return false;\r\n}\r\n```","created_at":"2015-01-18T21:02:08Z","updated_at":"2015-01-18T21:02:08Z","html_url":"https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/394#discussion_r23136841","pull_request_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/pulls/394","_links":{"self":{"href":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/pulls/comments/23136841"},"html":{"href":"https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/394#discussion_r23136841"},"pull_request":{"href":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/pulls/394"}}},"pull_request":{"url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/pulls/394","id":27576532,"html_url":"https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/394","diff_url":"https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/394.diff","patch_url":"https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/394.patch","issue_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/issues/394","number":394,"state":"open","locked":false,"title":"Fix SA1121 incorrectly reported in nameof","user":{"login":"pdelvo","id":1710209,"avatar_url":"https://avatars.githubusercontent.com/u/1710209?v=3","gravatar_id":"","url":"https://api.github.com/users/pdelvo","html_url":"https://github.com/pdelvo","followers_url":"https://api.github.com/users/pdelvo/followers","following_url":"https://api.github.com/users/pdelvo/following{/other_user}","gists_url":"https://api.github.com/users/pdelvo/gists{/gist_id}","starred_url":"https://api.github.com/users/pdelvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdelvo/subscriptions","organizations_url":"https://api.github.com/users/pdelvo/orgs","repos_url":"https://api.github.com/users/pdelvo/repos","events_url":"https://api.github.com/users/pdelvo/events{/privacy}","received_events_url":"https://api.github.com/users/pdelvo/received_events","type":"User","site_admin":false},"body":"Fixes #387","created_at":"2015-01-18T20:35:49Z","updated_at":"2015-01-18T21:02:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a2f26fa4f85bc9429b1fec1cf4f3eccc7a78b922","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/pulls/394/commits","review_comments_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/pulls/394/comments","review_comment_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/pulls/comments/{number}","comments_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/issues/394/comments","statuses_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/statuses/ceb3a39ba4aa38d4b247a9e9a76a84a969e2ab46","head":{"label":"pdelvo:387-fix","ref":"387-fix","sha":"ceb3a39ba4aa38d4b247a9e9a76a84a969e2ab46","user":{"login":"pdelvo","id":1710209,"avatar_url":"https://avatars.githubusercontent.com/u/1710209?v=3","gravatar_id":"","url":"https://api.github.com/users/pdelvo","html_url":"https://github.com/pdelvo","followers_url":"https://api.github.com/users/pdelvo/followers","following_url":"https://api.github.com/users/pdelvo/following{/other_user}","gists_url":"https://api.github.com/users/pdelvo/gists{/gist_id}","starred_url":"https://api.github.com/users/pdelvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdelvo/subscriptions","organizations_url":"https://api.github.com/users/pdelvo/orgs","repos_url":"https://api.github.com/users/pdelvo/repos","events_url":"https://api.github.com/users/pdelvo/events{/privacy}","received_events_url":"https://api.github.com/users/pdelvo/received_events","type":"User","site_admin":false},"repo":{"id":28428027,"name":"StyleCopAnalyzers","full_name":"pdelvo/StyleCopAnalyzers","owner":{"login":"pdelvo","id":1710209,"avatar_url":"https://avatars.githubusercontent.com/u/1710209?v=3","gravatar_id":"","url":"https://api.github.com/users/pdelvo","html_url":"https://github.com/pdelvo","followers_url":"https://api.github.com/users/pdelvo/followers","following_url":"https://api.github.com/users/pdelvo/following{/other_user}","gists_url":"https://api.github.com/users/pdelvo/gists{/gist_id}","starred_url":"https://api.github.com/users/pdelvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdelvo/subscriptions","organizations_url":"https://api.github.com/users/pdelvo/orgs","repos_url":"https://api.github.com/users/pdelvo/repos","events_url":"https://api.github.com/users/pdelvo/events{/privacy}","received_events_url":"https://api.github.com/users/pdelvo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pdelvo/StyleCopAnalyzers","description":"An implementation of StyleCop rules using the .NET Compiler Platform","fork":true,"url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers","forks_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/forks","keys_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/teams","hooks_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/hooks","issue_events_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/issues/events{/number}","events_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/events","assignees_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/assignees{/user}","branches_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/branches{/branch}","tags_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/tags","blobs_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/git/refs{/sha}","trees_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/statuses/{sha}","languages_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/languages","stargazers_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/stargazers","contributors_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/contributors","subscribers_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/subscribers","subscription_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/subscription","commits_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/commits{/sha}","git_commits_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/git/commits{/sha}","comments_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/comments{/number}","issue_comment_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/issues/comments/{number}","contents_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/contents/{+path}","compare_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/merges","archive_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/downloads","issues_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/issues{/number}","pulls_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/pulls{/number}","milestones_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/milestones{/number}","notifications_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/labels{/name}","releases_url":"https://api.github.com/repos/pdelvo/StyleCopAnalyzers/releases{/id}","created_at":"2014-12-24T01:24:25Z","updated_at":"2015-01-18T19:41:10Z","pushed_at":"2015-01-18T20:52:58Z","git_url":"git://github.com/pdelvo/StyleCopAnalyzers.git","ssh_url":"git@github.com:pdelvo/StyleCopAnalyzers.git","clone_url":"https://github.com/pdelvo/StyleCopAnalyzers.git","svn_url":"https://github.com/pdelvo/StyleCopAnalyzers","homepage":null,"size":883,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DotNetAnalyzers:master","ref":"master","sha":"cc50701dea4f24741f5da99d1d79e8632e2cab8e","user":{"login":"DotNetAnalyzers","id":9735576,"avatar_url":"https://avatars.githubusercontent.com/u/9735576?v=3","gravatar_id":"","url":"https://api.github.com/users/DotNetAnalyzers","html_url":"https://github.com/DotNetAnalyzers","followers_url":"https://api.github.com/users/DotNetAnalyzers/followers","following_url":"https://api.github.com/users/DotNetAnalyzers/following{/other_user}","gists_url":"https://api.github.com/users/DotNetAnalyzers/gists{/gist_id}","starred_url":"https://api.github.com/users/DotNetAnalyzers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DotNetAnalyzers/subscriptions","organizations_url":"https://api.github.com/users/DotNetAnalyzers/orgs","repos_url":"https://api.github.com/users/DotNetAnalyzers/repos","events_url":"https://api.github.com/users/DotNetAnalyzers/events{/privacy}","received_events_url":"https://api.github.com/users/DotNetAnalyzers/received_events","type":"Organization","site_admin":false},"repo":{"id":26768275,"name":"StyleCopAnalyzers","full_name":"DotNetAnalyzers/StyleCopAnalyzers","owner":{"login":"DotNetAnalyzers","id":9735576,"avatar_url":"https://avatars.githubusercontent.com/u/9735576?v=3","gravatar_id":"","url":"https://api.github.com/users/DotNetAnalyzers","html_url":"https://github.com/DotNetAnalyzers","followers_url":"https://api.github.com/users/DotNetAnalyzers/followers","following_url":"https://api.github.com/users/DotNetAnalyzers/following{/other_user}","gists_url":"https://api.github.com/users/DotNetAnalyzers/gists{/gist_id}","starred_url":"https://api.github.com/users/DotNetAnalyzers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DotNetAnalyzers/subscriptions","organizations_url":"https://api.github.com/users/DotNetAnalyzers/orgs","repos_url":"https://api.github.com/users/DotNetAnalyzers/repos","events_url":"https://api.github.com/users/DotNetAnalyzers/events{/privacy}","received_events_url":"https://api.github.com/users/DotNetAnalyzers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DotNetAnalyzers/StyleCopAnalyzers","description":"An implementation of StyleCop rules using the .NET Compiler Platform","fork":false,"url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers","forks_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/forks","keys_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/teams","hooks_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/hooks","issue_events_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/issues/events{/number}","events_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/events","assignees_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/assignees{/user}","branches_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/branches{/branch}","tags_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/tags","blobs_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/git/refs{/sha}","trees_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/statuses/{sha}","languages_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/languages","stargazers_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/stargazers","contributors_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/contributors","subscribers_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/subscribers","subscription_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/subscription","commits_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/commits{/sha}","git_commits_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/git/commits{/sha}","comments_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/comments{/number}","issue_comment_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/issues/comments/{number}","contents_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/contents/{+path}","compare_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/merges","archive_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/downloads","issues_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/issues{/number}","pulls_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/pulls{/number}","milestones_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/milestones{/number}","notifications_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/labels{/name}","releases_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/releases{/id}","created_at":"2014-11-17T17:29:54Z","updated_at":"2015-01-18T20:22:23Z","pushed_at":"2015-01-18T20:22:22Z","git_url":"git://github.com/DotNetAnalyzers/StyleCopAnalyzers.git","ssh_url":"git@github.com:DotNetAnalyzers/StyleCopAnalyzers.git","clone_url":"https://github.com/DotNetAnalyzers/StyleCopAnalyzers.git","svn_url":"https://github.com/DotNetAnalyzers/StyleCopAnalyzers","homepage":null,"size":1414,"stargazers_count":35,"watchers_count":35,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":243,"forks":10,"open_issues":243,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/pulls/394"},"html":{"href":"https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/394"},"issue":{"href":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/issues/394"},"comments":{"href":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/issues/394/comments"},"review_comments":{"href":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/pulls/394/comments"},"review_comment":{"href":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/pulls/394/commits"},"statuses":{"href":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/statuses/ceb3a39ba4aa38d4b247a9e9a76a84a969e2ab46"}}}}