{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/43656943","id":43656943,"diff_hunk":"@@ -6,21 +6,20 @@ import (\n \t\"github.com/docker/docker/api/server/httputils\"\n \t\"github.com/docker/docker/api/server/router\"\n \t\"github.com/docker/docker/api/server/router/local\"\n-\t\"github.com/docker/docker/daemon\"\n \t\"github.com/docker/docker/errors\"\n \t\"golang.org/x/net/context\"\n )\n \n // networkRouter is a router to talk with the network controller\n type networkRouter struct {\n-\tdaemon *daemon.Daemon\n+\timpl   Backend","path":"api/server/router/network/network.go","position":12,"original_position":12,"commit_id":"2e06f6fb419123839b4d972c246ef521fb09ab12","original_commit_id":"2e06f6fb419123839b4d972c246ef521fb09ab12","user":{"login":"calavera","id":1050,"avatar_url":"https://avatars.githubusercontent.com/u/1050?v=3","gravatar_id":"","url":"https://api.github.com/users/calavera","html_url":"https://github.com/calavera","followers_url":"https://api.github.com/users/calavera/followers","following_url":"https://api.github.com/users/calavera/following{/other_user}","gists_url":"https://api.github.com/users/calavera/gists{/gist_id}","starred_url":"https://api.github.com/users/calavera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calavera/subscriptions","organizations_url":"https://api.github.com/users/calavera/orgs","repos_url":"https://api.github.com/users/calavera/repos","events_url":"https://api.github.com/users/calavera/events{/privacy}","received_events_url":"https://api.github.com/users/calavera/received_events","type":"User","site_admin":false},"body":"can we call this var `backend` rather than `impl`?","created_at":"2015-11-02T17:43:52Z","updated_at":"2015-11-02T17:43:52Z","html_url":"https://github.com/docker/docker/pull/17517#discussion_r43656943","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/17517","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/43656943"},"html":{"href":"https://github.com/docker/docker/pull/17517#discussion_r43656943"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/17517"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/17517","id":49235005,"html_url":"https://github.com/docker/docker/pull/17517","diff_url":"https://github.com/docker/docker/pull/17517.diff","patch_url":"https://github.com/docker/docker/pull/17517.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/17517","number":17517,"state":"open","locked":false,"title":"create generic backend to cut dependency on daemon ","user":{"login":"MHBauer","id":13337345,"avatar_url":"https://avatars.githubusercontent.com/u/13337345?v=3","gravatar_id":"","url":"https://api.github.com/users/MHBauer","html_url":"https://github.com/MHBauer","followers_url":"https://api.github.com/users/MHBauer/followers","following_url":"https://api.github.com/users/MHBauer/following{/other_user}","gists_url":"https://api.github.com/users/MHBauer/gists{/gist_id}","starred_url":"https://api.github.com/users/MHBauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MHBauer/subscriptions","organizations_url":"https://api.github.com/users/MHBauer/orgs","repos_url":"https://api.github.com/users/MHBauer/repos","events_url":"https://api.github.com/users/MHBauer/events{/privacy}","received_events_url":"https://api.github.com/users/MHBauer/received_events","type":"User","site_admin":false},"body":"seeing #17463 gave me the idea that at least somewhat the routers can be 'impl-ized' individually.\r\n\r\nIf we apply similar changes to the `local` router, that would successfully split the api.\r\n\r\nThis is just an sample of what the final version would look like. I am interested in what people think about splitting the different sections into separate routers and separate `Backends`, vs keeping them all as one, with a single `Backend`.\r\n\r\nNames are subject to change, and I need to write a better commit message.","created_at":"2015-10-30T06:13:29Z","updated_at":"2015-11-02T17:43:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6bdb3dc8c551df2e7317ad4d7ec5b7a6c8203ca","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/17517/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/17517/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/17517/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/2e06f6fb419123839b4d972c246ef521fb09ab12","head":{"label":"MHBauer:network-impl","ref":"network-impl","sha":"2e06f6fb419123839b4d972c246ef521fb09ab12","user":{"login":"MHBauer","id":13337345,"avatar_url":"https://avatars.githubusercontent.com/u/13337345?v=3","gravatar_id":"","url":"https://api.github.com/users/MHBauer","html_url":"https://github.com/MHBauer","followers_url":"https://api.github.com/users/MHBauer/followers","following_url":"https://api.github.com/users/MHBauer/following{/other_user}","gists_url":"https://api.github.com/users/MHBauer/gists{/gist_id}","starred_url":"https://api.github.com/users/MHBauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MHBauer/subscriptions","organizations_url":"https://api.github.com/users/MHBauer/orgs","repos_url":"https://api.github.com/users/MHBauer/repos","events_url":"https://api.github.com/users/MHBauer/events{/privacy}","received_events_url":"https://api.github.com/users/MHBauer/received_events","type":"User","site_admin":false},"repo":{"id":39091680,"name":"docker","full_name":"MHBauer/docker","owner":{"login":"MHBauer","id":13337345,"avatar_url":"https://avatars.githubusercontent.com/u/13337345?v=3","gravatar_id":"","url":"https://api.github.com/users/MHBauer","html_url":"https://github.com/MHBauer","followers_url":"https://api.github.com/users/MHBauer/followers","following_url":"https://api.github.com/users/MHBauer/following{/other_user}","gists_url":"https://api.github.com/users/MHBauer/gists{/gist_id}","starred_url":"https://api.github.com/users/MHBauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MHBauer/subscriptions","organizations_url":"https://api.github.com/users/MHBauer/orgs","repos_url":"https://api.github.com/users/MHBauer/repos","events_url":"https://api.github.com/users/MHBauer/events{/privacy}","received_events_url":"https://api.github.com/users/MHBauer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MHBauer/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/MHBauer/docker","forks_url":"https://api.github.com/repos/MHBauer/docker/forks","keys_url":"https://api.github.com/repos/MHBauer/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MHBauer/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MHBauer/docker/teams","hooks_url":"https://api.github.com/repos/MHBauer/docker/hooks","issue_events_url":"https://api.github.com/repos/MHBauer/docker/issues/events{/number}","events_url":"https://api.github.com/repos/MHBauer/docker/events","assignees_url":"https://api.github.com/repos/MHBauer/docker/assignees{/user}","branches_url":"https://api.github.com/repos/MHBauer/docker/branches{/branch}","tags_url":"https://api.github.com/repos/MHBauer/docker/tags","blobs_url":"https://api.github.com/repos/MHBauer/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MHBauer/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MHBauer/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/MHBauer/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MHBauer/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/MHBauer/docker/languages","stargazers_url":"https://api.github.com/repos/MHBauer/docker/stargazers","contributors_url":"https://api.github.com/repos/MHBauer/docker/contributors","subscribers_url":"https://api.github.com/repos/MHBauer/docker/subscribers","subscription_url":"https://api.github.com/repos/MHBauer/docker/subscription","commits_url":"https://api.github.com/repos/MHBauer/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/MHBauer/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/MHBauer/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/MHBauer/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/MHBauer/docker/contents/{+path}","compare_url":"https://api.github.com/repos/MHBauer/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MHBauer/docker/merges","archive_url":"https://api.github.com/repos/MHBauer/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MHBauer/docker/downloads","issues_url":"https://api.github.com/repos/MHBauer/docker/issues{/number}","pulls_url":"https://api.github.com/repos/MHBauer/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/MHBauer/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/MHBauer/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MHBauer/docker/labels{/name}","releases_url":"https://api.github.com/repos/MHBauer/docker/releases{/id}","created_at":"2015-07-14T18:02:26Z","updated_at":"2015-07-14T18:02:34Z","pushed_at":"2015-11-02T02:22:23Z","git_url":"git://github.com/MHBauer/docker.git","ssh_url":"git@github.com:MHBauer/docker.git","clone_url":"https://github.com/MHBauer/docker.git","svn_url":"https://github.com/MHBauer/docker","homepage":"http://www.docker.com","size":72792,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"e2e2ea401a6e1095064bd8f5731f012cee45797b","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-11-02T17:34:24Z","pushed_at":"2015-11-02T17:41:31Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":282406,"stargazers_count":25851,"watchers_count":25851,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6898,"mirror_url":null,"open_issues_count":1194,"forks":6898,"open_issues":1194,"watchers":25851,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/17517"},"html":{"href":"https://github.com/docker/docker/pull/17517"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/17517"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/17517/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/17517/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/17517/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/2e06f6fb419123839b4d972c246ef521fb09ab12"}}}}