{"push_id":901041480,"size":71,"distinct_size":1,"ref":"refs/heads/better-error-message-for-includes-relations-missing","head":"313909c07c6c9172b60cff01f1bcf89fd6e1d030","before":"4e3a42540a813752db18131227ab8547fbef6013","commits":[{"sha":"0dc8166536f708ad6d20325797484f4c0b0b4ae5","author":{"email":"815806a5fcba2cb411d0f70b662adf0091c5dee5@gmail.com","name":"Yasuo Honda"},"message":"Use adapter supports_datetime_with_precision to support 3rd party adapter tests","distinct":false,"url":"https://api.github.com/repos/RochesterinNYC/rails/commits/0dc8166536f708ad6d20325797484f4c0b0b4ae5"},{"sha":"4687e59d5c941f57e39376d2011ce811eb18d47a","author":{"email":"815806a5fcba2cb411d0f70b662adf0091c5dee5@gmail.com","name":"Yasuo Honda"},"message":"Support supports_datetime_with_precision? for sqlite3","distinct":false,"url":"https://api.github.com/repos/RochesterinNYC/rails/commits/4687e59d5c941f57e39376d2011ce811eb18d47a"},{"sha":"589cef086fd06df80bcf988a014c7b6628013039","author":{"email":"815806a5fcba2cb411d0f70b662adf0091c5dee5@gmail.com","name":"Yasuo Honda"},"message":"Avoid dummy_time_value to add \"2000-01-01\" twice","distinct":false,"url":"https://api.github.com/repos/RochesterinNYC/rails/commits/589cef086fd06df80bcf988a014c7b6628013039"},{"sha":"87ee4f41490665602873d69a2d6bbfc9db049938","author":{"email":"815806a5fcba2cb411d0f70b662adf0091c5dee5@gmail.com","name":"Yasuo Honda"},"message":"Consolidate tests for time and datetime columns options, limit and precision","distinct":false,"url":"https://api.github.com/repos/RochesterinNYC/rails/commits/87ee4f41490665602873d69a2d6bbfc9db049938"},{"sha":"8a410043beea5e1da8afcbb4e75ca2a227e33a48","author":{"email":"ebd73beb044ee5759f027a56464cea105bbc60a7@gmail.com","name":"claudiob"},"message":"Add missing require to strong_parameters.rb\n\nThe file [references Rack::Test here](https://github.com/rails/rails/blame/master/actionpack/lib/action_controller/metal/strong_parameters.rb#L671)\nso it's better off requiring 'rack/test' in the first place.","distinct":false,"url":"https://api.github.com/repos/RochesterinNYC/rails/commits/8a410043beea5e1da8afcbb4e75ca2a227e33a48"},{"sha":"c199b703a8ca09fafc8f2eda7250fa7750eb27a8","author":{"email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@jonathanmoss.me","name":"Jon Moss"},"message":"Remove unused deprecation notice\n\nThe `rake db:test:*` tasks were deprecated in #13528, but were\nundeprecated and added back in via #17739.","distinct":false,"url":"https://api.github.com/repos/RochesterinNYC/rails/commits/c199b703a8ca09fafc8f2eda7250fa7750eb27a8"},{"sha":"cf8a41e1305bb7445f09f7ced481fee0619c0ce5","author":{"email":"16356534c1589fe78070f5640bedf8614007153c@gmail.com","name":"yuuji.yaginuma"},"message":"remove `request_forgery_protection` initializer from rails api\n\nIn rails api, since default is so as not to use the `protect_from_forgery`,\n`request_forgery_protection` initializer I think that's unnecessary","distinct":false,"url":"https://api.github.com/repos/RochesterinNYC/rails/commits/cf8a41e1305bb7445f09f7ced481fee0619c0ce5"},{"sha":"b24711621075350285fed67392720349722f4654","author":{"email":"46912bed2c3b56d601323fb1c76bee025b5234eb@gmail.com","name":"Prathamesh Sonpatki"},"message":"Use assert over assert_predicate in assert_response\n\n- `assert_predicate` appends its own error message at the end of message\n  generated by `assert_response` and because of that the error message\n  displays the whole `response` object.\n- For eg.\n\n  Expected response to be a <success>, but was a redirect to <http://test.host/posts>.\n  Expected #<ActionDispatch::TestResponse:0x007fb1cc1cf6f8....(lambda)>}>> to be successful?.\n\n- Complete message can be found here -\n  https://gist.github.com/prathamesh-sonpatki/055afb74b66108e71ded#file-gistfile1-txt-L19.\n\n- After this change the message from `assert_predicate` won't be\n  displayed and only message generated by `assert_response` will be shown\n  as follows:\n\n  Expected response to be a <success>, but was a redirect to <http://test.host/posts>","distinct":false,"url":"https://api.github.com/repos/RochesterinNYC/rails/commits/b24711621075350285fed67392720349722f4654"},{"sha":"6bd417df5075f1006557f6d9e44b5a9637015c70","author":{"email":"d298c18d76d9719bdf0bbcfd41a3d8048749996a@gmail.com","name":"Elektron1c97"},"message":"[ci skip] Add a dollar sign to each command in the READMEs\n\nAccording to pr #22443 in the guides there's always a dollar sign before every command, so why is in the main README a `$` and in every submodule a `%`?\n\nJust eye candy..","distinct":false,"url":"https://api.github.com/repos/RochesterinNYC/rails/commits/6bd417df5075f1006557f6d9e44b5a9637015c70"},{"sha":"5a300b2ed6b603474a7ee44d081da9e69465ec10","author":{"email":"4df7f3dad182da66af235a1249daf95d26b3dee6@gmail.com","name":"Genadi Samokovarov"},"message":"Introduce after_{create,update,delete}_commit callbacks\n\nThose are actually shortcuts for `after_commit`.\n\nBefore:\n\n    after_commit :add_to_index_later, on: :create\n    after_commit :update_in_index_later, on: :update\n    after_commit :remove_from_index_later, on: :destroy\n\nAfter:\n\n    after_create_commit  :add_to_index_later\n    after_update_commit  :update_in_index_later\n    after_destroy_commit :remove_from_index_later","distinct":false,"url":"https://api.github.com/repos/RochesterinNYC/rails/commits/5a300b2ed6b603474a7ee44d081da9e69465ec10"},{"sha":"a246a69e92a8ed54eb569a662dbaba16d743b2b7","author":{"email":"aa743a0aaec8f7d7a1f01442503957f4d7a2d634@loudthinking.com","name":"David Heinemeier Hansson"},"message":"Merge pull request #22516 from gsamokovarov/after-create-update-destroy-commit\n\nIntroduce after_{create,update,delete}_commit callbacks","distinct":false,"url":"https://api.github.com/repos/RochesterinNYC/rails/commits/a246a69e92a8ed54eb569a662dbaba16d743b2b7"},{"sha":"492b134433653cbbea1b30c459d41054f0da5ad7","author":{"email":"7a0559213618bb59f33e95efd260811728549345@gmail.com","name":"eileencodes"},"message":"Push `before_sending` to super class\n\nWe want to get rid of the `Live::Response` so we are consolidating methods\nfrom `Live::Response` and `Response` by merging them together.\n\nThis adds an `#empty` method to the request so we don't need to\nhard-code the empty array each time we call an empty\n`ActionDispatch::Request`.\n\nThe work here is a continuation on combining controller and integration\ntest code bases into one.","distinct":false,"url":"https://api.github.com/repos/RochesterinNYC/rails/commits/492b134433653cbbea1b30c459d41054f0da5ad7"},{"sha":"8350925bec434168f56b4fae22b5298cb4a83c41","author":{"email":"7a0559213618bb59f33e95efd260811728549345@gmail.com","name":"eileencodes"},"message":"Stop violating law of demeter in response cookie_jar\n\nThis adds a new method to request and response so we don't need to\nviolate the law of demeter.\n\nWe are changing `Request` and `Response` so that they always have a\n`cookie_jar`\n\nThis is a continuation on work to combine integration and controller\ntest code bases in Rails.","distinct":false,"url":"https://api.github.com/repos/RochesterinNYC/rails/commits/8350925bec434168f56b4fae22b5298cb4a83c41"},{"sha":"ff891616ac8a5c41f1fa2aba6c747d81f0782198","author":{"email":"7a0559213618bb59f33e95efd260811728549345@gmail.com","name":"eileencodes"},"message":"Only commit the cookie jar if it hasn't been committed\n\nWe don't want to commit the cookie jar more than once because then we\nwill be attempting to modify a frozen hash.\n\nFixes Railties test failure caused by 492b134.","distinct":false,"url":"https://api.github.com/repos/RochesterinNYC/rails/commits/ff891616ac8a5c41f1fa2aba6c747d81f0782198"},{"sha":"e7c48db509f1b712c2a72a3ff7f27e3e8b7b4868","author":{"email":"a97c4d522bbf25700c868f6869652a8e7e938a5c@gmail.com","name":"Arthur Neves"},"message":"Make sure we touch all the parents when touch_later.\n\nThe problem was that when saving an object, we would\ncall touch_later on the parent which wont be saved immediteally, and\nit wont call any callbacks. That was working one level up because\nwe were calling touch, during the touch_later commit phase. However that still\ndidnt solve the problem when you have a 3+ levels of parents to be touched,\nas calling touch would affect the parent, but it would be too late to run callbacks\non its grand-parent.\n\nThe solution for this, is instead, call touch_later upwards when the first\ntouch_later is called. So we make sure all the timestamps are updated without relying\non callbacks.\n\nThis also removed the hard dependency BelongsTo builder had with the TouchLater module.\nSo we can still have the old behaviour if TouchLater module is not included.\n\n[fixes 5f5e6d924973003c105feb711cefdb726f312768]\n[related #19324]","distinct":false,"url":"https://api.github.com/repos/RochesterinNYC/rails/commits/e7c48db509f1b712c2a72a3ff7f27e3e8b7b4868"},{"sha":"bf9facb31cf029f3ec1ef888825d50c9a2c713d6","author":{"email":"84c66fc058fe65d1bb08ca33b21bfe0fa5cb8f17@gmail.com","name":"Rafael França"},"message":"Merge pull request #22517 from Elektron1c97/master\n\n[ci skip] Add a dollar sign to each command in the READMEs","distinct":false,"url":"https://api.github.com/repos/RochesterinNYC/rails/commits/bf9facb31cf029f3ec1ef888825d50c9a2c713d6"},{"sha":"bcf89f44e0597b0ef8886d5d82be12c51462793c","author":{"email":"d298c18d76d9719bdf0bbcfd41a3d8048749996a@gmail.com","name":"Yves Siegrist"},"message":"Typo correction\n\nIn the doc the `dependent` option was set with: `dependent: destroy`.\nThis is not working because destroy would call the method of the activerecord::base object.\n\nThe right way is: `dependent: :destroy`","distinct":false,"url":"https://api.github.com/repos/RochesterinNYC/rails/commits/bcf89f44e0597b0ef8886d5d82be12c51462793c"},{"sha":"87b207aa7f62e1c43bc80c6d9de7614efdd296ac","author":{"email":"84c66fc058fe65d1bb08ca33b21bfe0fa5cb8f17@gmail.com","name":"Rafael França"},"message":"Merge pull request #22523 from Elektron1c97/master\n\nTypo correction","distinct":false,"url":"https://api.github.com/repos/RochesterinNYC/rails/commits/87b207aa7f62e1c43bc80c6d9de7614efdd296ac"},{"sha":"8b2eb4aa7a38c37cb4b2b4f6be9968aa60e82f20","author":{"email":"f80d0ca101e967b50b730ddf8e8aca0de85e8df6@trebex.net","name":"Matthew Draper"},"message":"Merge pull request #22475 from claudiob/missing-require\n\nAdd missing require to strong_parameters.rb","distinct":false,"url":"https://api.github.com/repos/RochesterinNYC/rails/commits/8b2eb4aa7a38c37cb4b2b4f6be9968aa60e82f20"},{"sha":"ba1bfa7a542e6c81729c8e0039d3866f549ff109","author":{"email":"792d28329de7ed446c01b83f731a071248ffeaf4@wyeworks.com","name":"Santiago Pastorino"},"message":"Merge pull request #22508 from y-yagi/remove_request_forgery_protection_from_rails_api\n\nremove `request_forgery_protection` initializer from rails api","distinct":false,"url":"https://api.github.com/repos/RochesterinNYC/rails/commits/ba1bfa7a542e6c81729c8e0039d3866f549ff109"}]}