{"action":"created","issue":{"url":"https://api.github.com/repos/rwjblue/ember-waypoints/issues/6","labels_url":"https://api.github.com/repos/rwjblue/ember-waypoints/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/rwjblue/ember-waypoints/issues/6/comments","events_url":"https://api.github.com/repos/rwjblue/ember-waypoints/issues/6/events","html_url":"https://github.com/rwjblue/ember-waypoints/pull/6","id":68852337,"number":6,"title":"Cleaned up add-on","user":{"login":"habdelra","id":61075,"avatar_url":"https://avatars.githubusercontent.com/u/61075?v=3","gravatar_id":"","url":"https://api.github.com/users/habdelra","html_url":"https://github.com/habdelra","followers_url":"https://api.github.com/users/habdelra/followers","following_url":"https://api.github.com/users/habdelra/following{/other_user}","gists_url":"https://api.github.com/users/habdelra/gists{/gist_id}","starred_url":"https://api.github.com/users/habdelra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/habdelra/subscriptions","organizations_url":"https://api.github.com/users/habdelra/orgs","repos_url":"https://api.github.com/users/habdelra/repos","events_url":"https://api.github.com/users/habdelra/events{/privacy}","received_events_url":"https://api.github.com/users/habdelra/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-04-16T06:01:55Z","updated_at":"2015-04-23T13:33:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rwjblue/ember-waypoints/pulls/6","html_url":"https://github.com/rwjblue/ember-waypoints/pull/6","diff_url":"https://github.com/rwjblue/ember-waypoints/pull/6.diff","patch_url":"https://github.com/rwjblue/ember-waypoints/pull/6.patch"},"body":"- I updated the add-on to use the latest Ember-CLI\r\n- I fixed the broken unit tests (the acceptance test didn't make sense to me, and it was failing anyways so i got rid of it)\r\n- Used the current add-on process for including bower dependencies\r\n- Fixed the `context` option. This option didn't actually work as the jquery waypoint expects a DOM node as a parameter--not a selector string. I updated this to make it more clear that you need to pass the ID of the node you want to have as context\r\n- Updated the readme\r\n\r\nFixes https://github.com/rwjblue/ember-waypoints/issues/5\r\nFixes https://github.com/rwjblue/ember-waypoints/issues/1\r\n\r\n(I'm giving a talk on this addon at the next NYC meetup--i figured i'd get it ship shape before the meetup)"},"comment":{"url":"https://api.github.com/repos/rwjblue/ember-waypoints/issues/comments/95586249","html_url":"https://github.com/rwjblue/ember-waypoints/pull/6#issuecomment-95586249","issue_url":"https://api.github.com/repos/rwjblue/ember-waypoints/issues/6","id":95586249,"user":{"login":"habdelra","id":61075,"avatar_url":"https://avatars.githubusercontent.com/u/61075?v=3","gravatar_id":"","url":"https://api.github.com/users/habdelra","html_url":"https://github.com/habdelra","followers_url":"https://api.github.com/users/habdelra/followers","following_url":"https://api.github.com/users/habdelra/following{/other_user}","gists_url":"https://api.github.com/users/habdelra/gists{/gist_id}","starred_url":"https://api.github.com/users/habdelra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/habdelra/subscriptions","organizations_url":"https://api.github.com/users/habdelra/orgs","repos_url":"https://api.github.com/users/habdelra/repos","events_url":"https://api.github.com/users/habdelra/events{/privacy}","received_events_url":"https://api.github.com/users/habdelra/received_events","type":"User","site_admin":false},"created_at":"2015-04-23T13:33:24Z","updated_at":"2015-04-23T13:33:24Z","body":"actualy I'm thinking of removing the contentFor--since I have a blueprint for bower waypoints, and included hook adds the app import to for the bower waypoints folder, then why do I need contentFor?"}}