{"action":"created","comment":{"url":"https://api.github.com/repos/ament/ament_cmake/pulls/comments/37369131","id":37369131,"diff_hunk":"@@ -21,11 +21,17 @@ macro(_ament_cmake_gmock_find_gmock)\n \n     find_package(ament_cmake_test QUIET REQUIRED)\n \n+    set(_prefix \"${ament_cmake_gmock_DIR}/../../..\")\n+\n     if(NOT GMOCK_FOUND)\n       # find gmock include and source folders\n-      # fall back to system installed path (i.e. on Ubuntu)\n-      set(_search_path_include \"/usr/include/gmock\")\n-      set(_search_path_src \"/usr/src/gmock/src\")\n+      # build the list of locations to search in reverse order","path":"ament_cmake_gmock/ament_cmake_gmock-extras.cmake","position":null,"original_position":11,"commit_id":"0488df968087e457337651b484078f8393839065","original_commit_id":"7db5d7708eb3cc8972d87155df47195cf0212fe6","user":{"login":"wjwwood","id":100427,"avatar_url":"https://avatars.githubusercontent.com/u/100427?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwwood","html_url":"https://github.com/wjwwood","followers_url":"https://api.github.com/users/wjwwood/followers","following_url":"https://api.github.com/users/wjwwood/following{/other_user}","gists_url":"https://api.github.com/users/wjwwood/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwwood/subscriptions","organizations_url":"https://api.github.com/users/wjwwood/orgs","repos_url":"https://api.github.com/users/wjwwood/repos","events_url":"https://api.github.com/users/wjwwood/events{/privacy}","received_events_url":"https://api.github.com/users/wjwwood/received_events","type":"User","site_admin":false},"body":"Fixed in 0488df9","created_at":"2015-08-19T00:22:44Z","updated_at":"2015-08-19T00:22:44Z","html_url":"https://github.com/ament/ament_cmake/pull/22#discussion_r37369131","pull_request_url":"https://api.github.com/repos/ament/ament_cmake/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/ament/ament_cmake/pulls/comments/37369131"},"html":{"href":"https://github.com/ament/ament_cmake/pull/22#discussion_r37369131"},"pull_request":{"href":"https://api.github.com/repos/ament/ament_cmake/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/ament/ament_cmake/pulls/22","id":42761809,"html_url":"https://github.com/ament/ament_cmake/pull/22","diff_url":"https://github.com/ament/ament_cmake/pull/22.diff","patch_url":"https://github.com/ament/ament_cmake/pull/22.patch","issue_url":"https://api.github.com/repos/ament/ament_cmake/issues/22","number":22,"state":"open","locked":false,"title":"ament_cmake_gmock: add final fallback to embedded gmock version","user":{"login":"wjwwood","id":100427,"avatar_url":"https://avatars.githubusercontent.com/u/100427?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwwood","html_url":"https://github.com/wjwwood","followers_url":"https://api.github.com/users/wjwwood/followers","following_url":"https://api.github.com/users/wjwwood/following{/other_user}","gists_url":"https://api.github.com/users/wjwwood/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwwood/subscriptions","organizations_url":"https://api.github.com/users/wjwwood/orgs","repos_url":"https://api.github.com/users/wjwwood/repos","events_url":"https://api.github.com/users/wjwwood/events{/privacy}","received_events_url":"https://api.github.com/users/wjwwood/received_events","type":"User","site_admin":false},"body":"This pull request adds an embedded (vendor) version of gmock (1.7.0) which it will use as a last resort if `GMOCK_DIR` is not set in the environment and if it is not found in `/usr/src/...` from the Debian package on Ubuntu.\r\n\r\nThis makes it easier to use on OS X and Windows. The vendor files number 5 and include two headers, two source files, and a `CMakeLists.txt`. This seems to be the recommended practice for gtest and gmock:\r\n\r\n- https://github.com/nickbruun/hayai/tree/master/vendor/gtest/fused-src/gtest\r\n- https://github.com/CRREL/points2grid/tree/master/vendor/gtest-1.7.0/include/gtest\r\n- https://github.com/mrtazz/plustache/tree/master/vendor/gtest-1.6.0/include/gtest\r\n- https://github.com/opencash/vendor/tree/master/gmock\r\n- https://github.com/phs/sauce/tree/master/vendor/gmock-1.6.0\r\n- https://github.com/puppetlabs/libpuppetdb/tree/master/vendor\r\n\r\nObviously the fact that others do it isn't proof in of itself, but I think it's a good indication that this is ok.\r\n\r\nAlso Homebrew actively discourages distributing `gmock` and `gtest` in the package manager and recommends you distribute it with your project:\r\n\r\n```\r\n% brew search gmock\r\nInstalling gmock system-wide is not recommended; it should be vendored\r\nin your projects that use it.\r\n\r\n% brew search gtest\r\nInstalling gtest system-wide is not recommended; it should be vendored\r\nin your projects that use it.\r\n```","created_at":"2015-08-18T23:36:04Z","updated_at":"2015-08-19T00:22:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a45383f21d323ac1cc3952c0e0b285a733c84d7","assignee":{"login":"wjwwood","id":100427,"avatar_url":"https://avatars.githubusercontent.com/u/100427?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwwood","html_url":"https://github.com/wjwwood","followers_url":"https://api.github.com/users/wjwwood/followers","following_url":"https://api.github.com/users/wjwwood/following{/other_user}","gists_url":"https://api.github.com/users/wjwwood/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwwood/subscriptions","organizations_url":"https://api.github.com/users/wjwwood/orgs","repos_url":"https://api.github.com/users/wjwwood/repos","events_url":"https://api.github.com/users/wjwwood/events{/privacy}","received_events_url":"https://api.github.com/users/wjwwood/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ament/ament_cmake/pulls/22/commits","review_comments_url":"https://api.github.com/repos/ament/ament_cmake/pulls/22/comments","review_comment_url":"https://api.github.com/repos/ament/ament_cmake/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ament/ament_cmake/issues/22/comments","statuses_url":"https://api.github.com/repos/ament/ament_cmake/statuses/0488df968087e457337651b484078f8393839065","head":{"label":"ament:embedded_gmock","ref":"embedded_gmock","sha":"0488df968087e457337651b484078f8393839065","user":{"login":"ament","id":7365061,"avatar_url":"https://avatars.githubusercontent.com/u/7365061?v=3","gravatar_id":"","url":"https://api.github.com/users/ament","html_url":"https://github.com/ament","followers_url":"https://api.github.com/users/ament/followers","following_url":"https://api.github.com/users/ament/following{/other_user}","gists_url":"https://api.github.com/users/ament/gists{/gist_id}","starred_url":"https://api.github.com/users/ament/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ament/subscriptions","organizations_url":"https://api.github.com/users/ament/orgs","repos_url":"https://api.github.com/users/ament/repos","events_url":"https://api.github.com/users/ament/events{/privacy}","received_events_url":"https://api.github.com/users/ament/received_events","type":"Organization","site_admin":false},"repo":{"id":19872267,"name":"ament_cmake","full_name":"ament/ament_cmake","owner":{"login":"ament","id":7365061,"avatar_url":"https://avatars.githubusercontent.com/u/7365061?v=3","gravatar_id":"","url":"https://api.github.com/users/ament","html_url":"https://github.com/ament","followers_url":"https://api.github.com/users/ament/followers","following_url":"https://api.github.com/users/ament/following{/other_user}","gists_url":"https://api.github.com/users/ament/gists{/gist_id}","starred_url":"https://api.github.com/users/ament/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ament/subscriptions","organizations_url":"https://api.github.com/users/ament/orgs","repos_url":"https://api.github.com/users/ament/repos","events_url":"https://api.github.com/users/ament/events{/privacy}","received_events_url":"https://api.github.com/users/ament/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ament/ament_cmake","description":"Supporting CMake packages for working with ament","fork":false,"url":"https://api.github.com/repos/ament/ament_cmake","forks_url":"https://api.github.com/repos/ament/ament_cmake/forks","keys_url":"https://api.github.com/repos/ament/ament_cmake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ament/ament_cmake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ament/ament_cmake/teams","hooks_url":"https://api.github.com/repos/ament/ament_cmake/hooks","issue_events_url":"https://api.github.com/repos/ament/ament_cmake/issues/events{/number}","events_url":"https://api.github.com/repos/ament/ament_cmake/events","assignees_url":"https://api.github.com/repos/ament/ament_cmake/assignees{/user}","branches_url":"https://api.github.com/repos/ament/ament_cmake/branches{/branch}","tags_url":"https://api.github.com/repos/ament/ament_cmake/tags","blobs_url":"https://api.github.com/repos/ament/ament_cmake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ament/ament_cmake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ament/ament_cmake/git/refs{/sha}","trees_url":"https://api.github.com/repos/ament/ament_cmake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ament/ament_cmake/statuses/{sha}","languages_url":"https://api.github.com/repos/ament/ament_cmake/languages","stargazers_url":"https://api.github.com/repos/ament/ament_cmake/stargazers","contributors_url":"https://api.github.com/repos/ament/ament_cmake/contributors","subscribers_url":"https://api.github.com/repos/ament/ament_cmake/subscribers","subscription_url":"https://api.github.com/repos/ament/ament_cmake/subscription","commits_url":"https://api.github.com/repos/ament/ament_cmake/commits{/sha}","git_commits_url":"https://api.github.com/repos/ament/ament_cmake/git/commits{/sha}","comments_url":"https://api.github.com/repos/ament/ament_cmake/comments{/number}","issue_comment_url":"https://api.github.com/repos/ament/ament_cmake/issues/comments{/number}","contents_url":"https://api.github.com/repos/ament/ament_cmake/contents/{+path}","compare_url":"https://api.github.com/repos/ament/ament_cmake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ament/ament_cmake/merges","archive_url":"https://api.github.com/repos/ament/ament_cmake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ament/ament_cmake/downloads","issues_url":"https://api.github.com/repos/ament/ament_cmake/issues{/number}","pulls_url":"https://api.github.com/repos/ament/ament_cmake/pulls{/number}","milestones_url":"https://api.github.com/repos/ament/ament_cmake/milestones{/number}","notifications_url":"https://api.github.com/repos/ament/ament_cmake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ament/ament_cmake/labels{/name}","releases_url":"https://api.github.com/repos/ament/ament_cmake/releases{/id}","created_at":"2014-05-16T22:13:54Z","updated_at":"2015-07-08T05:42:14Z","pushed_at":"2015-08-19T00:15:41Z","git_url":"git://github.com/ament/ament_cmake.git","ssh_url":"git@github.com:ament/ament_cmake.git","clone_url":"https://github.com/ament/ament_cmake.git","svn_url":"https://github.com/ament/ament_cmake","homepage":"","size":908,"stargazers_count":4,"watchers_count":4,"language":"CMake","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":4,"default_branch":"master"}},"base":{"label":"ament:master","ref":"master","sha":"9048899acba0a095dfbddf7f2645d3c8f2937bfa","user":{"login":"ament","id":7365061,"avatar_url":"https://avatars.githubusercontent.com/u/7365061?v=3","gravatar_id":"","url":"https://api.github.com/users/ament","html_url":"https://github.com/ament","followers_url":"https://api.github.com/users/ament/followers","following_url":"https://api.github.com/users/ament/following{/other_user}","gists_url":"https://api.github.com/users/ament/gists{/gist_id}","starred_url":"https://api.github.com/users/ament/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ament/subscriptions","organizations_url":"https://api.github.com/users/ament/orgs","repos_url":"https://api.github.com/users/ament/repos","events_url":"https://api.github.com/users/ament/events{/privacy}","received_events_url":"https://api.github.com/users/ament/received_events","type":"Organization","site_admin":false},"repo":{"id":19872267,"name":"ament_cmake","full_name":"ament/ament_cmake","owner":{"login":"ament","id":7365061,"avatar_url":"https://avatars.githubusercontent.com/u/7365061?v=3","gravatar_id":"","url":"https://api.github.com/users/ament","html_url":"https://github.com/ament","followers_url":"https://api.github.com/users/ament/followers","following_url":"https://api.github.com/users/ament/following{/other_user}","gists_url":"https://api.github.com/users/ament/gists{/gist_id}","starred_url":"https://api.github.com/users/ament/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ament/subscriptions","organizations_url":"https://api.github.com/users/ament/orgs","repos_url":"https://api.github.com/users/ament/repos","events_url":"https://api.github.com/users/ament/events{/privacy}","received_events_url":"https://api.github.com/users/ament/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ament/ament_cmake","description":"Supporting CMake packages for working with ament","fork":false,"url":"https://api.github.com/repos/ament/ament_cmake","forks_url":"https://api.github.com/repos/ament/ament_cmake/forks","keys_url":"https://api.github.com/repos/ament/ament_cmake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ament/ament_cmake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ament/ament_cmake/teams","hooks_url":"https://api.github.com/repos/ament/ament_cmake/hooks","issue_events_url":"https://api.github.com/repos/ament/ament_cmake/issues/events{/number}","events_url":"https://api.github.com/repos/ament/ament_cmake/events","assignees_url":"https://api.github.com/repos/ament/ament_cmake/assignees{/user}","branches_url":"https://api.github.com/repos/ament/ament_cmake/branches{/branch}","tags_url":"https://api.github.com/repos/ament/ament_cmake/tags","blobs_url":"https://api.github.com/repos/ament/ament_cmake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ament/ament_cmake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ament/ament_cmake/git/refs{/sha}","trees_url":"https://api.github.com/repos/ament/ament_cmake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ament/ament_cmake/statuses/{sha}","languages_url":"https://api.github.com/repos/ament/ament_cmake/languages","stargazers_url":"https://api.github.com/repos/ament/ament_cmake/stargazers","contributors_url":"https://api.github.com/repos/ament/ament_cmake/contributors","subscribers_url":"https://api.github.com/repos/ament/ament_cmake/subscribers","subscription_url":"https://api.github.com/repos/ament/ament_cmake/subscription","commits_url":"https://api.github.com/repos/ament/ament_cmake/commits{/sha}","git_commits_url":"https://api.github.com/repos/ament/ament_cmake/git/commits{/sha}","comments_url":"https://api.github.com/repos/ament/ament_cmake/comments{/number}","issue_comment_url":"https://api.github.com/repos/ament/ament_cmake/issues/comments{/number}","contents_url":"https://api.github.com/repos/ament/ament_cmake/contents/{+path}","compare_url":"https://api.github.com/repos/ament/ament_cmake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ament/ament_cmake/merges","archive_url":"https://api.github.com/repos/ament/ament_cmake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ament/ament_cmake/downloads","issues_url":"https://api.github.com/repos/ament/ament_cmake/issues{/number}","pulls_url":"https://api.github.com/repos/ament/ament_cmake/pulls{/number}","milestones_url":"https://api.github.com/repos/ament/ament_cmake/milestones{/number}","notifications_url":"https://api.github.com/repos/ament/ament_cmake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ament/ament_cmake/labels{/name}","releases_url":"https://api.github.com/repos/ament/ament_cmake/releases{/id}","created_at":"2014-05-16T22:13:54Z","updated_at":"2015-07-08T05:42:14Z","pushed_at":"2015-08-19T00:15:41Z","git_url":"git://github.com/ament/ament_cmake.git","ssh_url":"git@github.com:ament/ament_cmake.git","clone_url":"https://github.com/ament/ament_cmake.git","svn_url":"https://github.com/ament/ament_cmake","homepage":"","size":908,"stargazers_count":4,"watchers_count":4,"language":"CMake","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ament/ament_cmake/pulls/22"},"html":{"href":"https://github.com/ament/ament_cmake/pull/22"},"issue":{"href":"https://api.github.com/repos/ament/ament_cmake/issues/22"},"comments":{"href":"https://api.github.com/repos/ament/ament_cmake/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/ament/ament_cmake/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/ament/ament_cmake/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ament/ament_cmake/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/ament/ament_cmake/statuses/0488df968087e457337651b484078f8393839065"}}}}