{"action":"created","issue":{"url":"https://api.github.com/repos/chapel-lang/chapel/issues/1631","labels_url":"https://api.github.com/repos/chapel-lang/chapel/issues/1631/labels{/name}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/issues/1631/comments","events_url":"https://api.github.com/repos/chapel-lang/chapel/issues/1631/events","html_url":"https://github.com/chapel-lang/chapel/pull/1631","id":62446607,"number":1631,"title":"Remove ___always_inline","user":{"login":"mppf","id":3653132,"avatar_url":"https://avatars.githubusercontent.com/u/3653132?v=3","gravatar_id":"","url":"https://api.github.com/users/mppf","html_url":"https://github.com/mppf","followers_url":"https://api.github.com/users/mppf/followers","following_url":"https://api.github.com/users/mppf/following{/other_user}","gists_url":"https://api.github.com/users/mppf/gists{/gist_id}","starred_url":"https://api.github.com/users/mppf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mppf/subscriptions","organizations_url":"https://api.github.com/users/mppf/orgs","repos_url":"https://api.github.com/users/mppf/repos","events_url":"https://api.github.com/users/mppf/events{/privacy}","received_events_url":"https://api.github.com/users/mppf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-03-17T16:26:09Z","updated_at":"2015-03-27T18:09:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/1631","html_url":"https://github.com/chapel-lang/chapel/pull/1631","diff_url":"https://github.com/chapel-lang/chapel/pull/1631.diff","patch_url":"https://github.com/chapel-lang/chapel/pull/1631.patch"},"body":"Historically, we introduced ___always_inline as a way around errors that\r\nGASNet builds got because GASNet flags include -Winline. That is not\r\nthe best solution, since we want C compilers to be able to make their\r\nown good choices about inlining, and since ___always_inline is not\r\nstandard C or C++. Here we remove ___always_inline and replace it\r\nwith just plain inline. In order to solve the problem with GASNet builds\r\nthat include -Winline, we find-and-replace -Winline with the empty\r\nstring in runtime/src/comm/gasnet/Makefile.share.\r\n\r\nWe will need to monitor this change for any significant performance impact.\r\n\r\nPasses test/release/examples/ with CHPL_COMM=gasnet"},"comment":{"url":"https://api.github.com/repos/chapel-lang/chapel/issues/comments/87037077","html_url":"https://github.com/chapel-lang/chapel/pull/1631#issuecomment-87037077","issue_url":"https://api.github.com/repos/chapel-lang/chapel/issues/1631","id":87037077,"user":{"login":"gbtitus","id":7740880,"avatar_url":"https://avatars.githubusercontent.com/u/7740880?v=3","gravatar_id":"","url":"https://api.github.com/users/gbtitus","html_url":"https://github.com/gbtitus","followers_url":"https://api.github.com/users/gbtitus/followers","following_url":"https://api.github.com/users/gbtitus/following{/other_user}","gists_url":"https://api.github.com/users/gbtitus/gists{/gist_id}","starred_url":"https://api.github.com/users/gbtitus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbtitus/subscriptions","organizations_url":"https://api.github.com/users/gbtitus/orgs","repos_url":"https://api.github.com/users/gbtitus/repos","events_url":"https://api.github.com/users/gbtitus/events{/privacy}","received_events_url":"https://api.github.com/users/gbtitus/received_events","type":"User","site_admin":false},"created_at":"2015-03-27T18:09:48Z","updated_at":"2015-03-27T18:09:48Z","body":"Looks good, and good to merge. It would be nice if you could tackle WIDE_PTR_INLINE as mentioned in the line comment before merging; I don't need to see it again if you do this."}}