{"action":"opened","number":59,"pull_request":{"url":"https://api.github.com/repos/skavanagh/KeyBox/pulls/59","id":30378222,"html_url":"https://github.com/skavanagh/KeyBox/pull/59","diff_url":"https://github.com/skavanagh/KeyBox/pull/59.diff","patch_url":"https://github.com/skavanagh/KeyBox/pull/59.patch","issue_url":"https://api.github.com/repos/skavanagh/KeyBox/issues/59","number":59,"state":"open","locked":false,"title":"Separate fingerprint","user":{"login":"StoertebekerHST","id":10989582,"avatar_url":"https://avatars.githubusercontent.com/u/10989582?v=3","gravatar_id":"","url":"https://api.github.com/users/StoertebekerHST","html_url":"https://github.com/StoertebekerHST","followers_url":"https://api.github.com/users/StoertebekerHST/followers","following_url":"https://api.github.com/users/StoertebekerHST/following{/other_user}","gists_url":"https://api.github.com/users/StoertebekerHST/gists{/gist_id}","starred_url":"https://api.github.com/users/StoertebekerHST/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StoertebekerHST/subscriptions","organizations_url":"https://api.github.com/users/StoertebekerHST/orgs","repos_url":"https://api.github.com/users/StoertebekerHST/repos","events_url":"https://api.github.com/users/StoertebekerHST/events{/privacy}","received_events_url":"https://api.github.com/users/StoertebekerHST/received_events","type":"User","site_admin":false},"body":"Sean,\r\nin preparation of some further db changes (cleanup and restructure for audit) we ask you to review and merge this pull request. We've separated the storage for user keys fingerprints from the actual key.\r\nReason: \r\n\r\n- We separate fingerprint in database to check on deleted keys simultaneously to other actions (compare for add, modify action). \r\n- We want to track the fingerprints but not the key if it gets deleted to prevent users from reuse. Also this gives us a chance to drop the fingerprint in case of misconfiguration seperate from the keydb\r\n- more normalized db structure\r\n\r\nFunction overview:\r\n- User can have multiple keys\r\n- avoid usage of the same Key for different user\r\n- avoid usage of the same key in the same user / profile  constellation multiple times\r\n- Deleted keys can not be applied anymore\r\n\r\nTests we've run:\r\n- User adds two different keys for same profile--> OK --> right\r\n- User adds wants to add the same key for the same profile twice --> Fail --> right\r\n- Two users add the same key to same profile--> Fails at second add --> right\r\n- Two users add the same key to different profile--> Fails at second add --> right\r\n- User adds an alredy deleted Key to a profile--> Fail --> right","created_at":"2015-03-03T14:36:30Z","updated_at":"2015-03-03T14:36:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1fbab8861e3e7bd281def4d312ce6102c0d85fb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/skavanagh/KeyBox/pulls/59/commits","review_comments_url":"https://api.github.com/repos/skavanagh/KeyBox/pulls/59/comments","review_comment_url":"https://api.github.com/repos/skavanagh/KeyBox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/skavanagh/KeyBox/issues/59/comments","statuses_url":"https://api.github.com/repos/skavanagh/KeyBox/statuses/61a4670e6c19f72df8e424978567d6a153254713","head":{"label":"hufsm:feature_fingerprint_save","ref":"feature_fingerprint_save","sha":"61a4670e6c19f72df8e424978567d6a153254713","user":{"login":"hufsm","id":7997325,"avatar_url":"https://avatars.githubusercontent.com/u/7997325?v=3","gravatar_id":"","url":"https://api.github.com/users/hufsm","html_url":"https://github.com/hufsm","followers_url":"https://api.github.com/users/hufsm/followers","following_url":"https://api.github.com/users/hufsm/following{/other_user}","gists_url":"https://api.github.com/users/hufsm/gists{/gist_id}","starred_url":"https://api.github.com/users/hufsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hufsm/subscriptions","organizations_url":"https://api.github.com/users/hufsm/orgs","repos_url":"https://api.github.com/users/hufsm/repos","events_url":"https://api.github.com/users/hufsm/events{/privacy}","received_events_url":"https://api.github.com/users/hufsm/received_events","type":"Organization","site_admin":false},"repo":{"id":30010786,"name":"KeyBox","full_name":"hufsm/KeyBox","owner":{"login":"hufsm","id":7997325,"avatar_url":"https://avatars.githubusercontent.com/u/7997325?v=3","gravatar_id":"","url":"https://api.github.com/users/hufsm","html_url":"https://github.com/hufsm","followers_url":"https://api.github.com/users/hufsm/followers","following_url":"https://api.github.com/users/hufsm/following{/other_user}","gists_url":"https://api.github.com/users/hufsm/gists{/gist_id}","starred_url":"https://api.github.com/users/hufsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hufsm/subscriptions","organizations_url":"https://api.github.com/users/hufsm/orgs","repos_url":"https://api.github.com/users/hufsm/repos","events_url":"https://api.github.com/users/hufsm/events{/privacy}","received_events_url":"https://api.github.com/users/hufsm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hufsm/KeyBox","description":"A web-based SSH console that executes commands on multiple shells. KeyBox allows you to manage keys, share terminal commands, and upload files to multiple systems simultaneously.","fork":true,"url":"https://api.github.com/repos/hufsm/KeyBox","forks_url":"https://api.github.com/repos/hufsm/KeyBox/forks","keys_url":"https://api.github.com/repos/hufsm/KeyBox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hufsm/KeyBox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hufsm/KeyBox/teams","hooks_url":"https://api.github.com/repos/hufsm/KeyBox/hooks","issue_events_url":"https://api.github.com/repos/hufsm/KeyBox/issues/events{/number}","events_url":"https://api.github.com/repos/hufsm/KeyBox/events","assignees_url":"https://api.github.com/repos/hufsm/KeyBox/assignees{/user}","branches_url":"https://api.github.com/repos/hufsm/KeyBox/branches{/branch}","tags_url":"https://api.github.com/repos/hufsm/KeyBox/tags","blobs_url":"https://api.github.com/repos/hufsm/KeyBox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hufsm/KeyBox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hufsm/KeyBox/git/refs{/sha}","trees_url":"https://api.github.com/repos/hufsm/KeyBox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hufsm/KeyBox/statuses/{sha}","languages_url":"https://api.github.com/repos/hufsm/KeyBox/languages","stargazers_url":"https://api.github.com/repos/hufsm/KeyBox/stargazers","contributors_url":"https://api.github.com/repos/hufsm/KeyBox/contributors","subscribers_url":"https://api.github.com/repos/hufsm/KeyBox/subscribers","subscription_url":"https://api.github.com/repos/hufsm/KeyBox/subscription","commits_url":"https://api.github.com/repos/hufsm/KeyBox/commits{/sha}","git_commits_url":"https://api.github.com/repos/hufsm/KeyBox/git/commits{/sha}","comments_url":"https://api.github.com/repos/hufsm/KeyBox/comments{/number}","issue_comment_url":"https://api.github.com/repos/hufsm/KeyBox/issues/comments{/number}","contents_url":"https://api.github.com/repos/hufsm/KeyBox/contents/{+path}","compare_url":"https://api.github.com/repos/hufsm/KeyBox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hufsm/KeyBox/merges","archive_url":"https://api.github.com/repos/hufsm/KeyBox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hufsm/KeyBox/downloads","issues_url":"https://api.github.com/repos/hufsm/KeyBox/issues{/number}","pulls_url":"https://api.github.com/repos/hufsm/KeyBox/pulls{/number}","milestones_url":"https://api.github.com/repos/hufsm/KeyBox/milestones{/number}","notifications_url":"https://api.github.com/repos/hufsm/KeyBox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hufsm/KeyBox/labels{/name}","releases_url":"https://api.github.com/repos/hufsm/KeyBox/releases{/id}","created_at":"2015-01-29T08:25:09Z","updated_at":"2015-02-27T07:53:04Z","pushed_at":"2015-03-03T14:31:17Z","git_url":"git://github.com/hufsm/KeyBox.git","ssh_url":"git@github.com:hufsm/KeyBox.git","clone_url":"https://github.com/hufsm/KeyBox.git","svn_url":"https://github.com/hufsm/KeyBox","homepage":"http://sshkeybox.com","size":30265,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"skavanagh:master","ref":"master","sha":"37bd6c4aa50e99bccbd194c002ffc50b89fdbeae","user":{"login":"skavanagh","id":3192731,"avatar_url":"https://avatars.githubusercontent.com/u/3192731?v=3","gravatar_id":"","url":"https://api.github.com/users/skavanagh","html_url":"https://github.com/skavanagh","followers_url":"https://api.github.com/users/skavanagh/followers","following_url":"https://api.github.com/users/skavanagh/following{/other_user}","gists_url":"https://api.github.com/users/skavanagh/gists{/gist_id}","starred_url":"https://api.github.com/users/skavanagh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skavanagh/subscriptions","organizations_url":"https://api.github.com/users/skavanagh/orgs","repos_url":"https://api.github.com/users/skavanagh/repos","events_url":"https://api.github.com/users/skavanagh/events{/privacy}","received_events_url":"https://api.github.com/users/skavanagh/received_events","type":"User","site_admin":false},"repo":{"id":8083731,"name":"KeyBox","full_name":"skavanagh/KeyBox","owner":{"login":"skavanagh","id":3192731,"avatar_url":"https://avatars.githubusercontent.com/u/3192731?v=3","gravatar_id":"","url":"https://api.github.com/users/skavanagh","html_url":"https://github.com/skavanagh","followers_url":"https://api.github.com/users/skavanagh/followers","following_url":"https://api.github.com/users/skavanagh/following{/other_user}","gists_url":"https://api.github.com/users/skavanagh/gists{/gist_id}","starred_url":"https://api.github.com/users/skavanagh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skavanagh/subscriptions","organizations_url":"https://api.github.com/users/skavanagh/orgs","repos_url":"https://api.github.com/users/skavanagh/repos","events_url":"https://api.github.com/users/skavanagh/events{/privacy}","received_events_url":"https://api.github.com/users/skavanagh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skavanagh/KeyBox","description":"KeyBox is a web-based SSH console that centrally manages administrative access to systems. KeyBox combines key management and administration through profiles assigned to defined users.","fork":false,"url":"https://api.github.com/repos/skavanagh/KeyBox","forks_url":"https://api.github.com/repos/skavanagh/KeyBox/forks","keys_url":"https://api.github.com/repos/skavanagh/KeyBox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skavanagh/KeyBox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skavanagh/KeyBox/teams","hooks_url":"https://api.github.com/repos/skavanagh/KeyBox/hooks","issue_events_url":"https://api.github.com/repos/skavanagh/KeyBox/issues/events{/number}","events_url":"https://api.github.com/repos/skavanagh/KeyBox/events","assignees_url":"https://api.github.com/repos/skavanagh/KeyBox/assignees{/user}","branches_url":"https://api.github.com/repos/skavanagh/KeyBox/branches{/branch}","tags_url":"https://api.github.com/repos/skavanagh/KeyBox/tags","blobs_url":"https://api.github.com/repos/skavanagh/KeyBox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skavanagh/KeyBox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skavanagh/KeyBox/git/refs{/sha}","trees_url":"https://api.github.com/repos/skavanagh/KeyBox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skavanagh/KeyBox/statuses/{sha}","languages_url":"https://api.github.com/repos/skavanagh/KeyBox/languages","stargazers_url":"https://api.github.com/repos/skavanagh/KeyBox/stargazers","contributors_url":"https://api.github.com/repos/skavanagh/KeyBox/contributors","subscribers_url":"https://api.github.com/repos/skavanagh/KeyBox/subscribers","subscription_url":"https://api.github.com/repos/skavanagh/KeyBox/subscription","commits_url":"https://api.github.com/repos/skavanagh/KeyBox/commits{/sha}","git_commits_url":"https://api.github.com/repos/skavanagh/KeyBox/git/commits{/sha}","comments_url":"https://api.github.com/repos/skavanagh/KeyBox/comments{/number}","issue_comment_url":"https://api.github.com/repos/skavanagh/KeyBox/issues/comments{/number}","contents_url":"https://api.github.com/repos/skavanagh/KeyBox/contents/{+path}","compare_url":"https://api.github.com/repos/skavanagh/KeyBox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skavanagh/KeyBox/merges","archive_url":"https://api.github.com/repos/skavanagh/KeyBox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skavanagh/KeyBox/downloads","issues_url":"https://api.github.com/repos/skavanagh/KeyBox/issues{/number}","pulls_url":"https://api.github.com/repos/skavanagh/KeyBox/pulls{/number}","milestones_url":"https://api.github.com/repos/skavanagh/KeyBox/milestones{/number}","notifications_url":"https://api.github.com/repos/skavanagh/KeyBox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skavanagh/KeyBox/labels{/name}","releases_url":"https://api.github.com/repos/skavanagh/KeyBox/releases{/id}","created_at":"2013-02-07T23:11:49Z","updated_at":"2015-03-02T18:00:32Z","pushed_at":"2015-03-02T22:17:27Z","git_url":"git://github.com/skavanagh/KeyBox.git","ssh_url":"git@github.com:skavanagh/KeyBox.git","clone_url":"https://github.com/skavanagh/KeyBox.git","svn_url":"https://github.com/skavanagh/KeyBox","homepage":"http://sshkeybox.com","size":33920,"stargazers_count":730,"watchers_count":730,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":70,"mirror_url":null,"open_issues_count":13,"forks":70,"open_issues":13,"watchers":730,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/skavanagh/KeyBox/pulls/59"},"html":{"href":"https://github.com/skavanagh/KeyBox/pull/59"},"issue":{"href":"https://api.github.com/repos/skavanagh/KeyBox/issues/59"},"comments":{"href":"https://api.github.com/repos/skavanagh/KeyBox/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/skavanagh/KeyBox/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/skavanagh/KeyBox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/skavanagh/KeyBox/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/skavanagh/KeyBox/statuses/61a4670e6c19f72df8e424978567d6a153254713"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":8,"additions":1275,"deletions":1152,"changed_files":5}}