{"action":"created","issue":{"url":"https://api.github.com/repos/palantir/plottable/issues/1831","labels_url":"https://api.github.com/repos/palantir/plottable/issues/1831/labels{/name}","comments_url":"https://api.github.com/repos/palantir/plottable/issues/1831/comments","events_url":"https://api.github.com/repos/palantir/plottable/issues/1831/events","html_url":"https://github.com/palantir/plottable/pull/1831","id":68224231,"number":1831,"title":"[abstractComponentContainer] Can now merge groups that are already anchored","user":{"login":"aicioara","id":3248682,"avatar_url":"https://avatars.githubusercontent.com/u/3248682?v=3","gravatar_id":"","url":"https://api.github.com/users/aicioara","html_url":"https://github.com/aicioara","followers_url":"https://api.github.com/users/aicioara/followers","following_url":"https://api.github.com/users/aicioara/following{/other_user}","gists_url":"https://api.github.com/users/aicioara/gists{/gist_id}","starred_url":"https://api.github.com/users/aicioara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aicioara/subscriptions","organizations_url":"https://api.github.com/users/aicioara/orgs","repos_url":"https://api.github.com/users/aicioara/repos","events_url":"https://api.github.com/users/aicioara/events{/privacy}","received_events_url":"https://api.github.com/users/aicioara/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"jtlan","id":1440449,"avatar_url":"https://avatars.githubusercontent.com/u/1440449?v=3","gravatar_id":"","url":"https://api.github.com/users/jtlan","html_url":"https://github.com/jtlan","followers_url":"https://api.github.com/users/jtlan/followers","following_url":"https://api.github.com/users/jtlan/following{/other_user}","gists_url":"https://api.github.com/users/jtlan/gists{/gist_id}","starred_url":"https://api.github.com/users/jtlan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtlan/subscriptions","organizations_url":"https://api.github.com/users/jtlan/orgs","repos_url":"https://api.github.com/users/jtlan/repos","events_url":"https://api.github.com/users/jtlan/events{/privacy}","received_events_url":"https://api.github.com/users/jtlan/received_events","type":"User","site_admin":false},"milestone":null,"comments":6,"created_at":"2015-04-14T00:08:37Z","updated_at":"2015-04-15T00:18:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/palantir/plottable/pulls/1831","html_url":"https://github.com/palantir/plottable/pull/1831","diff_url":"https://github.com/palantir/plottable/pull/1831.diff","patch_url":"https://github.com/palantir/plottable/pull/1831.patch"},"body":"Changelog:\r\n- No longer setting the parent field, but rather have a method for doing that, which also detaches the component from its old parent (if there's the case)\r\n- No longer throwing an error if the component was already setup or anchored, as we can now do it\r\n- Throwing an error if we are trying to add `null` to a table cell\r\n\r\nCloses #1823 \r\n\r\nBefore: http://jsfiddle.net/0r93afbf/\r\nAfter: http://jsfiddle.net/0r93afbf/1/\r\n\r\nFiddle explanation: Click on the button. If it works correctly, the label \"AWESOME\" should be taken from the x-Axis and put inside the graph. The default position is center (vertically and horizontally)"},"comment":{"url":"https://api.github.com/repos/palantir/plottable/issues/comments/93120374","html_url":"https://github.com/palantir/plottable/pull/1831#issuecomment-93120374","issue_url":"https://api.github.com/repos/palantir/plottable/issues/1831","id":93120374,"user":{"login":"aicioara","id":3248682,"avatar_url":"https://avatars.githubusercontent.com/u/3248682?v=3","gravatar_id":"","url":"https://api.github.com/users/aicioara","html_url":"https://github.com/aicioara","followers_url":"https://api.github.com/users/aicioara/followers","following_url":"https://api.github.com/users/aicioara/following{/other_user}","gists_url":"https://api.github.com/users/aicioara/gists{/gist_id}","starred_url":"https://api.github.com/users/aicioara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aicioara/subscriptions","organizations_url":"https://api.github.com/users/aicioara/orgs","repos_url":"https://api.github.com/users/aicioara/repos","events_url":"https://api.github.com/users/aicioara/events{/privacy}","received_events_url":"https://api.github.com/users/aicioara/received_events","type":"User","site_admin":false},"created_at":"2015-04-15T00:18:31Z","updated_at":"2015-04-15T00:18:31Z","body":"Discussion with @jtlan and @bluong concluded that there are 3 options when adding null to a table cell where there is something\r\n- Throw an Error - We cannot add null to a table cell. Pro for this was that the user is notified straight away that something wrong has happened. Code does not fail later on unexpectedly\r\n- Do not do anything - fail silently. Pro for this would be that user might have a list of components, some of which are null and wants to add them to the cell\r\n- Create a group containing only 1 element (the element which was originally in the cell). Pro for this was that user expects a group, even though he added a null\r\n\r\nWent for option 1\r\n\r\nSolved that. Adding `null` to a table cell now throws an exception. Tests changed accordingly. "}}