{"action":"created","issue":{"url":"https://api.github.com/repos/TauLabs/TauLabs/issues/1887","labels_url":"https://api.github.com/repos/TauLabs/TauLabs/issues/1887/labels{/name}","comments_url":"https://api.github.com/repos/TauLabs/TauLabs/issues/1887/comments","events_url":"https://api.github.com/repos/TauLabs/TauLabs/issues/1887/events","html_url":"https://github.com/TauLabs/TauLabs/pull/1887","id":104314585,"number":1887,"title":"UAVObjectGenerator: Added NUMOPTS #define for options fields","user":{"login":"ekaszubski","id":666500,"avatar_url":"https://avatars.githubusercontent.com/u/666500?v=3","gravatar_id":"","url":"https://api.github.com/users/ekaszubski","html_url":"https://github.com/ekaszubski","followers_url":"https://api.github.com/users/ekaszubski/followers","following_url":"https://api.github.com/users/ekaszubski/following{/other_user}","gists_url":"https://api.github.com/users/ekaszubski/gists{/gist_id}","starred_url":"https://api.github.com/users/ekaszubski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekaszubski/subscriptions","organizations_url":"https://api.github.com/users/ekaszubski/orgs","repos_url":"https://api.github.com/users/ekaszubski/repos","events_url":"https://api.github.com/users/ekaszubski/events{/privacy}","received_events_url":"https://api.github.com/users/ekaszubski/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-01T17:17:18Z","updated_at":"2015-09-01T18:00:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TauLabs/TauLabs/pulls/1887","html_url":"https://github.com/TauLabs/TauLabs/pull/1887","diff_url":"https://github.com/TauLabs/TauLabs/pull/1887.diff","patch_url":"https://github.com/TauLabs/TauLabs/pull/1887.patch"},"body":"Fixes #1886 \r\n- Field `MyCoolUAVO->MyCoolField` with `options=\"Option1, Option2, Option3\"` will now have `#define MYCOOLUAVO_MYCOOLFIELD_NUMOPTS=3` in `uavobject-synthetics/flight/mycooluavo.h`\r\n- Also note that this should (and does) happen even if there's only one option"},"comment":{"url":"https://api.github.com/repos/TauLabs/TauLabs/issues/comments/136812960","html_url":"https://github.com/TauLabs/TauLabs/pull/1887#issuecomment-136812960","issue_url":"https://api.github.com/repos/TauLabs/TauLabs/issues/1887","id":136812960,"user":{"login":"mlyle","id":90903,"avatar_url":"https://avatars.githubusercontent.com/u/90903?v=3","gravatar_id":"","url":"https://api.github.com/users/mlyle","html_url":"https://github.com/mlyle","followers_url":"https://api.github.com/users/mlyle/followers","following_url":"https://api.github.com/users/mlyle/following{/other_user}","gists_url":"https://api.github.com/users/mlyle/gists{/gist_id}","starred_url":"https://api.github.com/users/mlyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlyle/subscriptions","organizations_url":"https://api.github.com/users/mlyle/orgs","repos_url":"https://api.github.com/users/mlyle/repos","events_url":"https://api.github.com/users/mlyle/events{/privacy}","received_events_url":"https://api.github.com/users/mlyle/received_events","type":"User","site_admin":false},"created_at":"2015-09-01T18:00:08Z","updated_at":"2015-09-01T18:00:08Z","body":"This is very good.\r\n\r\nIt should probably be combined with code to check the range when we convert a binary blob to a uavo, preventing an invalid value from ever getting into the system-- both over the telemetry link and when we read objects from flash.  Then we can stop range checking in most of our code (or make most of the range checks an assert)."}}