{"action":"created","issue":{"url":"https://api.github.com/repos/dollarshaveclub/ember-responds-to/issues/2","labels_url":"https://api.github.com/repos/dollarshaveclub/ember-responds-to/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/dollarshaveclub/ember-responds-to/issues/2/comments","events_url":"https://api.github.com/repos/dollarshaveclub/ember-responds-to/issues/2/events","html_url":"https://github.com/dollarshaveclub/ember-responds-to/pull/2","id":108254444,"number":2,"title":"Fix runloop and tests","user":{"login":"bantic","id":2023,"avatar_url":"https://avatars.githubusercontent.com/u/2023?v=3","gravatar_id":"","url":"https://api.github.com/users/bantic","html_url":"https://github.com/bantic","followers_url":"https://api.github.com/users/bantic/followers","following_url":"https://api.github.com/users/bantic/following{/other_user}","gists_url":"https://api.github.com/users/bantic/gists{/gist_id}","starred_url":"https://api.github.com/users/bantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bantic/subscriptions","organizations_url":"https://api.github.com/users/bantic/orgs","repos_url":"https://api.github.com/users/bantic/repos","events_url":"https://api.github.com/users/bantic/events{/privacy}","received_events_url":"https://api.github.com/users/bantic/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-25T03:20:41Z","updated_at":"2015-09-25T07:14:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dollarshaveclub/ember-responds-to/pulls/2","html_url":"https://github.com/dollarshaveclub/ember-responds-to/pull/2","diff_url":"https://github.com/dollarshaveclub/ember-responds-to/pull/2.diff","patch_url":"https://github.com/dollarshaveclub/ember-responds-to/pull/2.patch"},"body":"I was playing around with this today and noticed that the event-responding code was ignoring ember's runloop, causing some issues in tests.\r\n\r\nThere are a couple commits here:\r\n  * 87590e6 fixes the tests — mostly just fixing jshint and removing usage of a `.property` function prototype extension\r\n  * 04eaa4a introduces a few failing tests — these fail because they cause property changes outside of ember's runloop\r\n  * 7e78861 fixes the failing tests by using ember's runloop to handle property changes\r\n\r\nThere are still some runloop-related issues with `RespondsToEnterKeydown` and `RespondsToEscKeydown` that I will issue a separate PR for if I have a chance."},"comment":{"url":"https://api.github.com/repos/dollarshaveclub/ember-responds-to/issues/comments/143146957","html_url":"https://github.com/dollarshaveclub/ember-responds-to/pull/2#issuecomment-143146957","issue_url":"https://api.github.com/repos/dollarshaveclub/ember-responds-to/issues/2","id":143146957,"user":{"login":"pwfisher","id":126581,"avatar_url":"https://avatars.githubusercontent.com/u/126581?v=3","gravatar_id":"","url":"https://api.github.com/users/pwfisher","html_url":"https://github.com/pwfisher","followers_url":"https://api.github.com/users/pwfisher/followers","following_url":"https://api.github.com/users/pwfisher/following{/other_user}","gists_url":"https://api.github.com/users/pwfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/pwfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwfisher/subscriptions","organizations_url":"https://api.github.com/users/pwfisher/orgs","repos_url":"https://api.github.com/users/pwfisher/repos","events_url":"https://api.github.com/users/pwfisher/events{/privacy}","received_events_url":"https://api.github.com/users/pwfisher/received_events","type":"User","site_admin":false},"created_at":"2015-09-25T07:14:00Z","updated_at":"2015-09-25T07:14:00Z","body":"Thank you for this! I'm formatting it a bit to match our (arbitrary, but consistent) standards and getting it to work with phantomjs now..."}}