{"action":"created","issue":{"url":"https://api.github.com/repos/apache/kafka/issues/602","labels_url":"https://api.github.com/repos/apache/kafka/issues/602/labels{/name}","comments_url":"https://api.github.com/repos/apache/kafka/issues/602/comments","events_url":"https://api.github.com/repos/apache/kafka/issues/602/events","html_url":"https://github.com/apache/kafka/pull/602","id":119414425,"number":602,"title":"Trunk kafka 2839","user":{"login":"ZoneMayor","id":4058918,"avatar_url":"https://avatars.githubusercontent.com/u/4058918?v=3","gravatar_id":"","url":"https://api.github.com/users/ZoneMayor","html_url":"https://github.com/ZoneMayor","followers_url":"https://api.github.com/users/ZoneMayor/followers","following_url":"https://api.github.com/users/ZoneMayor/following{/other_user}","gists_url":"https://api.github.com/users/ZoneMayor/gists{/gist_id}","starred_url":"https://api.github.com/users/ZoneMayor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZoneMayor/subscriptions","organizations_url":"https://api.github.com/users/ZoneMayor/orgs","repos_url":"https://api.github.com/users/ZoneMayor/repos","events_url":"https://api.github.com/users/ZoneMayor/events{/privacy}","received_events_url":"https://api.github.com/users/ZoneMayor/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-30T03:53:34Z","updated_at":"2015-12-01T10:30:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/602","html_url":"https://github.com/apache/kafka/pull/602","diff_url":"https://github.com/apache/kafka/pull/602.diff","patch_url":"https://github.com/apache/kafka/pull/602.patch"},"body":"I believe there is a bug in KafkaBasedLogTest implementation;\r\nRecords are appended to \"KafkaBasedLog\" by :\r\nconsumer.addRecord(new ConsumerRecord<>(TOPIC, 0, 0, TP0_KEY, TP0_VALUE));\r\nconsumer.addRecord(new ConsumerRecord<>(TOPIC, 0, 1, TP0_KEY, TP0_VALUE_NEW));\r\nconsumer.addRecord(new ConsumerRecord<>(TOPIC, 1, 0, TP1_KEY, TP1_VALUE));\r\nconsumer.addRecord(new ConsumerRecord<>(TOPIC, 1, 1, TP1_KEY, TP1_VALUE_NEW));\r\nand achieved by \"consumedRecords\";\r\nInside of \"ConsumerRecords\", in order to turn \"records\", \r\nwhich is a HashMap[TopicPartition, List[ConsumerRecord[K, V]]], \r\ninto Iterator[ConsumerRecord[K, V]];\r\nWe can just guarantee the sequence underneath same key, while we cannot assure the sequence under different keys;\r\nAm I wrong?\r\n@gwenshap "},"comment":{"url":"https://api.github.com/repos/apache/kafka/issues/comments/160928216","html_url":"https://github.com/apache/kafka/pull/602#issuecomment-160928216","issue_url":"https://api.github.com/repos/apache/kafka/issues/602","id":160928216,"user":{"login":"ZoneMayor","id":4058918,"avatar_url":"https://avatars.githubusercontent.com/u/4058918?v=3","gravatar_id":"","url":"https://api.github.com/users/ZoneMayor","html_url":"https://github.com/ZoneMayor","followers_url":"https://api.github.com/users/ZoneMayor/followers","following_url":"https://api.github.com/users/ZoneMayor/following{/other_user}","gists_url":"https://api.github.com/users/ZoneMayor/gists{/gist_id}","starred_url":"https://api.github.com/users/ZoneMayor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZoneMayor/subscriptions","organizations_url":"https://api.github.com/users/ZoneMayor/orgs","repos_url":"https://api.github.com/users/ZoneMayor/repos","events_url":"https://api.github.com/users/ZoneMayor/events{/privacy}","received_events_url":"https://api.github.com/users/ZoneMayor/received_events","type":"User","site_admin":false},"created_at":"2015-12-01T10:30:50Z","updated_at":"2015-12-01T10:30:50Z","body":"@guozhangwang does this patch make sense?"}}