{"action":"created","issue":{"url":"https://api.github.com/repos/RomanYankovsky/DelphiAST/issues/119","labels_url":"https://api.github.com/repos/RomanYankovsky/DelphiAST/issues/119/labels{/name}","comments_url":"https://api.github.com/repos/RomanYankovsky/DelphiAST/issues/119/comments","events_url":"https://api.github.com/repos/RomanYankovsky/DelphiAST/issues/119/events","html_url":"https://github.com/RomanYankovsky/DelphiAST/pull/119","id":102547463,"number":119,"title":"ConstRef keyword","user":{"login":"Wosi","id":3448684,"avatar_url":"https://avatars.githubusercontent.com/u/3448684?v=3","gravatar_id":"","url":"https://api.github.com/users/Wosi","html_url":"https://github.com/Wosi","followers_url":"https://api.github.com/users/Wosi/followers","following_url":"https://api.github.com/users/Wosi/following{/other_user}","gists_url":"https://api.github.com/users/Wosi/gists{/gist_id}","starred_url":"https://api.github.com/users/Wosi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wosi/subscriptions","organizations_url":"https://api.github.com/users/Wosi/orgs","repos_url":"https://api.github.com/users/Wosi/repos","events_url":"https://api.github.com/users/Wosi/events{/privacy}","received_events_url":"https://api.github.com/users/Wosi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-08-22T16:17:55Z","updated_at":"2015-08-26T14:19:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/RomanYankovsky/DelphiAST/pulls/119","html_url":"https://github.com/RomanYankovsky/DelphiAST/pull/119","diff_url":"https://github.com/RomanYankovsky/DelphiAST/pull/119.diff","patch_url":"https://github.com/RomanYankovsky/DelphiAST/pull/119.patch"},"body":"In FreePascal 2.6.0 the `ConstRef` keyword has been introduced.\r\nIt's a parameter modifier like `const` or `var`. \r\nMore information about it here: http://wiki.freepascal.org/FPC_New_Features_2.6.0#Constref_parameter_modifier\r\n\r\nI extended DelphiAST to handle `constref` properly.\r\nI'm not sure if this project aims to be compatible to FPC related language features. If not then just let me know and it will only be present in my own fork. "},"comment":{"url":"https://api.github.com/repos/RomanYankovsky/DelphiAST/issues/comments/135037176","html_url":"https://github.com/RomanYankovsky/DelphiAST/pull/119#issuecomment-135037176","issue_url":"https://api.github.com/repos/RomanYankovsky/DelphiAST/issues/119","id":135037176,"user":{"login":"vintagedave","id":8351450,"avatar_url":"https://avatars.githubusercontent.com/u/8351450?v=3","gravatar_id":"","url":"https://api.github.com/users/vintagedave","html_url":"https://github.com/vintagedave","followers_url":"https://api.github.com/users/vintagedave/followers","following_url":"https://api.github.com/users/vintagedave/following{/other_user}","gists_url":"https://api.github.com/users/vintagedave/gists{/gist_id}","starred_url":"https://api.github.com/users/vintagedave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vintagedave/subscriptions","organizations_url":"https://api.github.com/users/vintagedave/orgs","repos_url":"https://api.github.com/users/vintagedave/repos","events_url":"https://api.github.com/users/vintagedave/events{/privacy}","received_events_url":"https://api.github.com/users/vintagedave/received_events","type":"User","site_admin":false},"created_at":"2015-08-26T14:19:40Z","updated_at":"2015-08-26T14:19:40Z","body":"The numbers represent a hash?  Crikey.\n\nIt would be easy to volunteer, since it would be a simple rename\nrefactoring... if there were unit tests to ensure the output didn't\nchange.  I've been thinking about this before and lack of tests is (to me)\none glaring problem with the lexer.  Does anyone else feel adding them\nwould be a useful addition?  Now, how to add them - or what to test and why\nand where and how - is another matter...\n\nOn 26 August 2015 at 16:05, Stefan Glienke <notifications@github.com> wrote:\n\n> The FuncXX methods are an optimization for keywords. Each keyword has a\n> hash value that is represented by the XX. Imo this can be done different\n> and in a way more understandable yet fast way. But hey who volunteers in\n> rewriting the lexer from scratch and making sure that everything still\n> works.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/RomanYankovsky/DelphiAST/pull/119#issuecomment-135032584>\n> .\n>\n"}}