{"action":"created","issue":{"url":"https://api.github.com/repos/pfultz2/Fit/issues/4","labels_url":"https://api.github.com/repos/pfultz2/Fit/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/pfultz2/Fit/issues/4/comments","events_url":"https://api.github.com/repos/pfultz2/Fit/issues/4/events","html_url":"https://github.com/pfultz2/Fit/pull/4","id":58153652,"number":4,"title":"adapted CMakeLists.txt for biicode","user":{"login":"drodri","id":1108595,"avatar_url":"https://avatars.githubusercontent.com/u/1108595?v=3","gravatar_id":"","url":"https://api.github.com/users/drodri","html_url":"https://github.com/drodri","followers_url":"https://api.github.com/users/drodri/followers","following_url":"https://api.github.com/users/drodri/following{/other_user}","gists_url":"https://api.github.com/users/drodri/gists{/gist_id}","starred_url":"https://api.github.com/users/drodri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drodri/subscriptions","organizations_url":"https://api.github.com/users/drodri/orgs","repos_url":"https://api.github.com/users/drodri/repos","events_url":"https://api.github.com/users/drodri/events{/privacy}","received_events_url":"https://api.github.com/users/drodri/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-02-19T00:53:52Z","updated_at":"2015-02-22T21:03:47Z","closed_at":"2015-02-19T15:35:41Z","pull_request":{"url":"https://api.github.com/repos/pfultz2/Fit/pulls/4","html_url":"https://github.com/pfultz2/Fit/pull/4","diff_url":"https://github.com/pfultz2/Fit/pull/4.diff","patch_url":"https://github.com/pfultz2/Fit/pull/4.patch"},"body":"Hi Paul,\r\n\r\nIf I have understood your requirements correctly from last email, I think this PR might solve the issue:\r\n- Moved down the IF(BIICODE) section, so all the above conf is common to both biicode and non-biicode builds\r\n- Macro Add_test_executable() also works for biicode, where it is not necessary to define the target as it is already defined by biicode, so just the EXCLUDE_FROM_ALL is defined\r\n- The biicode section calls the macro for every defined EXE. Note that this will work OK even when depending on the lib and the tests are not retrieved\r\n- It is not necessary to further process the file after that, so for biicode builds a return() finishes the configuration there.\r\n\r\nI have tested and the \"bii cpp:build --target check\" works ok (tested in Win-MInGW) and also \"bii cpp:build\" does not build the tests.\r\nThe lib as a problem as is. When published and dependen on, it will generate compile errors, as the consumer does not adequately define C++11/14 configuration. I have checked to publish it to one of my tracks and after depend on it, and had to copy all the ENABLE_CXXFLAGS_TO_CHECK stuff in the consumer.\r\n\r\nThis can be done transitively (only fit defines the flags and the consumer inherits them automatically), if you need help, I might try to contribute with another PR."},"comment":{"url":"https://api.github.com/repos/pfultz2/Fit/issues/comments/75457768","html_url":"https://github.com/pfultz2/Fit/pull/4#issuecomment-75457768","issue_url":"https://api.github.com/repos/pfultz2/Fit/issues/4","id":75457768,"user":{"login":"drodri","id":1108595,"avatar_url":"https://avatars.githubusercontent.com/u/1108595?v=3","gravatar_id":"","url":"https://api.github.com/users/drodri","html_url":"https://github.com/drodri","followers_url":"https://api.github.com/users/drodri/followers","following_url":"https://api.github.com/users/drodri/following{/other_user}","gists_url":"https://api.github.com/users/drodri/gists{/gist_id}","starred_url":"https://api.github.com/users/drodri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drodri/subscriptions","organizations_url":"https://api.github.com/users/drodri/orgs","repos_url":"https://api.github.com/users/drodri/repos","events_url":"https://api.github.com/users/drodri/events{/privacy}","received_events_url":"https://api.github.com/users/drodri/received_events","type":"User","site_admin":false},"created_at":"2015-02-22T21:03:47Z","updated_at":"2015-02-22T21:03:47Z","body":"You are right, tried it out, works perfectly, thanks!"}}