{"action":"created","comment":{"url":"https://api.github.com/repos/OpenLightingProject/ola/pulls/comments/44754999","id":44754999,"diff_hunk":"@@ -175,6 +183,14 @@ bool AsyncPluginImpl::NewWidget(JaRuleWidget *widget) {\n                                 new JaRuleDevice(m_plugin, widget, str.str()));\n }\n \n+bool AsyncPluginImpl::NewWidget(NodleU1 *widget) {\n+  return StartAndRegisterDevice(\n+      widget,\n+      new NodleU1Device(m_plugin, widget, \"DMXControl Projects e.V. Nodle U1\",","path":"plugins/usbdmx/AsyncPluginImpl.cpp","position":41,"original_position":41,"commit_id":"211b0267b3b4cddc1f32cb7a95976970aa096829","original_commit_id":"211b0267b3b4cddc1f32cb7a95976970aa096829","user":{"login":"StefanKrupop","id":12464991,"avatar_url":"https://avatars.githubusercontent.com/u/12464991?v=3","gravatar_id":"","url":"https://api.github.com/users/StefanKrupop","html_url":"https://github.com/StefanKrupop","followers_url":"https://api.github.com/users/StefanKrupop/followers","following_url":"https://api.github.com/users/StefanKrupop/following{/other_user}","gists_url":"https://api.github.com/users/StefanKrupop/gists{/gist_id}","starred_url":"https://api.github.com/users/StefanKrupop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StefanKrupop/subscriptions","organizations_url":"https://api.github.com/users/StefanKrupop/orgs","repos_url":"https://api.github.com/users/StefanKrupop/repos","events_url":"https://api.github.com/users/StefanKrupop/events{/privacy}","received_events_url":"https://api.github.com/users/StefanKrupop/received_events","type":"User","site_admin":false},"body":"The serial number is already shown in the \"Description\" field like (IIRC) the Enttec plugin does. Is that not okay? I think the description is visible everywhere you see the device name in the UI...","created_at":"2015-11-13T06:58:02Z","updated_at":"2015-11-13T06:58:02Z","html_url":"https://github.com/OpenLightingProject/ola/pull/892#discussion_r44754999","pull_request_url":"https://api.github.com/repos/OpenLightingProject/ola/pulls/892","_links":{"self":{"href":"https://api.github.com/repos/OpenLightingProject/ola/pulls/comments/44754999"},"html":{"href":"https://github.com/OpenLightingProject/ola/pull/892#discussion_r44754999"},"pull_request":{"href":"https://api.github.com/repos/OpenLightingProject/ola/pulls/892"}}},"pull_request":{"url":"https://api.github.com/repos/OpenLightingProject/ola/pulls/892","id":44292425,"html_url":"https://github.com/OpenLightingProject/ola/pull/892","diff_url":"https://github.com/OpenLightingProject/ola/pull/892.diff","patch_url":"https://github.com/OpenLightingProject/ola/pull/892.patch","issue_url":"https://api.github.com/repos/OpenLightingProject/ola/issues/892","number":892,"state":"open","locked":false,"title":"Add Nodle U1 support for usbdmx plugin","user":{"login":"StefanKrupop","id":12464991,"avatar_url":"https://avatars.githubusercontent.com/u/12464991?v=3","gravatar_id":"","url":"https://api.github.com/users/StefanKrupop","html_url":"https://github.com/StefanKrupop","followers_url":"https://api.github.com/users/StefanKrupop/followers","following_url":"https://api.github.com/users/StefanKrupop/following{/other_user}","gists_url":"https://api.github.com/users/StefanKrupop/gists{/gist_id}","starred_url":"https://api.github.com/users/StefanKrupop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StefanKrupop/subscriptions","organizations_url":"https://api.github.com/users/StefanKrupop/orgs","repos_url":"https://api.github.com/users/StefanKrupop/repos","events_url":"https://api.github.com/users/StefanKrupop/events{/privacy}","received_events_url":"https://api.github.com/users/StefanKrupop/received_events","type":"User","site_admin":false},"body":"I added support for the DMXControl Projects e.V. Nodle U1 to the usbdmx plugin. The interface supports an output and an input port (at the same time), so I also added support to read from USB devices in synchronous and asynchronous mode. Some smaller changes to the existing code where necessary.\r\nI hope I did everything right. On my Linux Test-VM everything seems to work fine.","created_at":"2015-09-06T00:01:42Z","updated_at":"2015-11-13T06:58:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db774145d8d8ed6b9126de45a12783eefbad74a7","assignee":{"login":"nomis52","id":4355332,"avatar_url":"https://avatars.githubusercontent.com/u/4355332?v=3","gravatar_id":"","url":"https://api.github.com/users/nomis52","html_url":"https://github.com/nomis52","followers_url":"https://api.github.com/users/nomis52/followers","following_url":"https://api.github.com/users/nomis52/following{/other_user}","gists_url":"https://api.github.com/users/nomis52/gists{/gist_id}","starred_url":"https://api.github.com/users/nomis52/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nomis52/subscriptions","organizations_url":"https://api.github.com/users/nomis52/orgs","repos_url":"https://api.github.com/users/nomis52/repos","events_url":"https://api.github.com/users/nomis52/events{/privacy}","received_events_url":"https://api.github.com/users/nomis52/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/OpenLightingProject/ola/pulls/892/commits","review_comments_url":"https://api.github.com/repos/OpenLightingProject/ola/pulls/892/comments","review_comment_url":"https://api.github.com/repos/OpenLightingProject/ola/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenLightingProject/ola/issues/892/comments","statuses_url":"https://api.github.com/repos/OpenLightingProject/ola/statuses/211b0267b3b4cddc1f32cb7a95976970aa096829","head":{"label":"StefanKrupop:master","ref":"master","sha":"211b0267b3b4cddc1f32cb7a95976970aa096829","user":{"login":"StefanKrupop","id":12464991,"avatar_url":"https://avatars.githubusercontent.com/u/12464991?v=3","gravatar_id":"","url":"https://api.github.com/users/StefanKrupop","html_url":"https://github.com/StefanKrupop","followers_url":"https://api.github.com/users/StefanKrupop/followers","following_url":"https://api.github.com/users/StefanKrupop/following{/other_user}","gists_url":"https://api.github.com/users/StefanKrupop/gists{/gist_id}","starred_url":"https://api.github.com/users/StefanKrupop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StefanKrupop/subscriptions","organizations_url":"https://api.github.com/users/StefanKrupop/orgs","repos_url":"https://api.github.com/users/StefanKrupop/repos","events_url":"https://api.github.com/users/StefanKrupop/events{/privacy}","received_events_url":"https://api.github.com/users/StefanKrupop/received_events","type":"User","site_admin":false},"repo":{"id":41211497,"name":"ola","full_name":"StefanKrupop/ola","owner":{"login":"StefanKrupop","id":12464991,"avatar_url":"https://avatars.githubusercontent.com/u/12464991?v=3","gravatar_id":"","url":"https://api.github.com/users/StefanKrupop","html_url":"https://github.com/StefanKrupop","followers_url":"https://api.github.com/users/StefanKrupop/followers","following_url":"https://api.github.com/users/StefanKrupop/following{/other_user}","gists_url":"https://api.github.com/users/StefanKrupop/gists{/gist_id}","starred_url":"https://api.github.com/users/StefanKrupop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StefanKrupop/subscriptions","organizations_url":"https://api.github.com/users/StefanKrupop/orgs","repos_url":"https://api.github.com/users/StefanKrupop/repos","events_url":"https://api.github.com/users/StefanKrupop/events{/privacy}","received_events_url":"https://api.github.com/users/StefanKrupop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/StefanKrupop/ola","description":"The Open Lighting Architecture","fork":true,"url":"https://api.github.com/repos/StefanKrupop/ola","forks_url":"https://api.github.com/repos/StefanKrupop/ola/forks","keys_url":"https://api.github.com/repos/StefanKrupop/ola/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StefanKrupop/ola/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StefanKrupop/ola/teams","hooks_url":"https://api.github.com/repos/StefanKrupop/ola/hooks","issue_events_url":"https://api.github.com/repos/StefanKrupop/ola/issues/events{/number}","events_url":"https://api.github.com/repos/StefanKrupop/ola/events","assignees_url":"https://api.github.com/repos/StefanKrupop/ola/assignees{/user}","branches_url":"https://api.github.com/repos/StefanKrupop/ola/branches{/branch}","tags_url":"https://api.github.com/repos/StefanKrupop/ola/tags","blobs_url":"https://api.github.com/repos/StefanKrupop/ola/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StefanKrupop/ola/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StefanKrupop/ola/git/refs{/sha}","trees_url":"https://api.github.com/repos/StefanKrupop/ola/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StefanKrupop/ola/statuses/{sha}","languages_url":"https://api.github.com/repos/StefanKrupop/ola/languages","stargazers_url":"https://api.github.com/repos/StefanKrupop/ola/stargazers","contributors_url":"https://api.github.com/repos/StefanKrupop/ola/contributors","subscribers_url":"https://api.github.com/repos/StefanKrupop/ola/subscribers","subscription_url":"https://api.github.com/repos/StefanKrupop/ola/subscription","commits_url":"https://api.github.com/repos/StefanKrupop/ola/commits{/sha}","git_commits_url":"https://api.github.com/repos/StefanKrupop/ola/git/commits{/sha}","comments_url":"https://api.github.com/repos/StefanKrupop/ola/comments{/number}","issue_comment_url":"https://api.github.com/repos/StefanKrupop/ola/issues/comments{/number}","contents_url":"https://api.github.com/repos/StefanKrupop/ola/contents/{+path}","compare_url":"https://api.github.com/repos/StefanKrupop/ola/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StefanKrupop/ola/merges","archive_url":"https://api.github.com/repos/StefanKrupop/ola/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StefanKrupop/ola/downloads","issues_url":"https://api.github.com/repos/StefanKrupop/ola/issues{/number}","pulls_url":"https://api.github.com/repos/StefanKrupop/ola/pulls{/number}","milestones_url":"https://api.github.com/repos/StefanKrupop/ola/milestones{/number}","notifications_url":"https://api.github.com/repos/StefanKrupop/ola/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StefanKrupop/ola/labels{/name}","releases_url":"https://api.github.com/repos/StefanKrupop/ola/releases{/id}","created_at":"2015-08-22T14:44:33Z","updated_at":"2015-09-06T11:02:47Z","pushed_at":"2015-11-13T00:16:43Z","git_url":"git://github.com/StefanKrupop/ola.git","ssh_url":"git@github.com:StefanKrupop/ola.git","clone_url":"https://github.com/StefanKrupop/ola.git","svn_url":"https://github.com/StefanKrupop/ola","homepage":"https://www.openlighting.org/ola/","size":17383,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"OpenLightingProject:master","ref":"master","sha":"9e82e288ee55bef4ccdfa78e3ebc0748afe4a279","user":{"login":"OpenLightingProject","id":6199314,"avatar_url":"https://avatars.githubusercontent.com/u/6199314?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenLightingProject","html_url":"https://github.com/OpenLightingProject","followers_url":"https://api.github.com/users/OpenLightingProject/followers","following_url":"https://api.github.com/users/OpenLightingProject/following{/other_user}","gists_url":"https://api.github.com/users/OpenLightingProject/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenLightingProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenLightingProject/subscriptions","organizations_url":"https://api.github.com/users/OpenLightingProject/orgs","repos_url":"https://api.github.com/users/OpenLightingProject/repos","events_url":"https://api.github.com/users/OpenLightingProject/events{/privacy}","received_events_url":"https://api.github.com/users/OpenLightingProject/received_events","type":"Organization","site_admin":false},"repo":{"id":15233168,"name":"ola","full_name":"OpenLightingProject/ola","owner":{"login":"OpenLightingProject","id":6199314,"avatar_url":"https://avatars.githubusercontent.com/u/6199314?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenLightingProject","html_url":"https://github.com/OpenLightingProject","followers_url":"https://api.github.com/users/OpenLightingProject/followers","following_url":"https://api.github.com/users/OpenLightingProject/following{/other_user}","gists_url":"https://api.github.com/users/OpenLightingProject/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenLightingProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenLightingProject/subscriptions","organizations_url":"https://api.github.com/users/OpenLightingProject/orgs","repos_url":"https://api.github.com/users/OpenLightingProject/repos","events_url":"https://api.github.com/users/OpenLightingProject/events{/privacy}","received_events_url":"https://api.github.com/users/OpenLightingProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenLightingProject/ola","description":"The Open Lighting Architecture","fork":false,"url":"https://api.github.com/repos/OpenLightingProject/ola","forks_url":"https://api.github.com/repos/OpenLightingProject/ola/forks","keys_url":"https://api.github.com/repos/OpenLightingProject/ola/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenLightingProject/ola/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenLightingProject/ola/teams","hooks_url":"https://api.github.com/repos/OpenLightingProject/ola/hooks","issue_events_url":"https://api.github.com/repos/OpenLightingProject/ola/issues/events{/number}","events_url":"https://api.github.com/repos/OpenLightingProject/ola/events","assignees_url":"https://api.github.com/repos/OpenLightingProject/ola/assignees{/user}","branches_url":"https://api.github.com/repos/OpenLightingProject/ola/branches{/branch}","tags_url":"https://api.github.com/repos/OpenLightingProject/ola/tags","blobs_url":"https://api.github.com/repos/OpenLightingProject/ola/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenLightingProject/ola/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenLightingProject/ola/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenLightingProject/ola/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenLightingProject/ola/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenLightingProject/ola/languages","stargazers_url":"https://api.github.com/repos/OpenLightingProject/ola/stargazers","contributors_url":"https://api.github.com/repos/OpenLightingProject/ola/contributors","subscribers_url":"https://api.github.com/repos/OpenLightingProject/ola/subscribers","subscription_url":"https://api.github.com/repos/OpenLightingProject/ola/subscription","commits_url":"https://api.github.com/repos/OpenLightingProject/ola/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenLightingProject/ola/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenLightingProject/ola/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenLightingProject/ola/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenLightingProject/ola/contents/{+path}","compare_url":"https://api.github.com/repos/OpenLightingProject/ola/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenLightingProject/ola/merges","archive_url":"https://api.github.com/repos/OpenLightingProject/ola/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenLightingProject/ola/downloads","issues_url":"https://api.github.com/repos/OpenLightingProject/ola/issues{/number}","pulls_url":"https://api.github.com/repos/OpenLightingProject/ola/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenLightingProject/ola/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenLightingProject/ola/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenLightingProject/ola/labels{/name}","releases_url":"https://api.github.com/repos/OpenLightingProject/ola/releases{/id}","created_at":"2013-12-16T18:06:52Z","updated_at":"2015-10-23T17:45:58Z","pushed_at":"2015-11-13T01:17:43Z","git_url":"git://github.com/OpenLightingProject/ola.git","ssh_url":"git@github.com:OpenLightingProject/ola.git","clone_url":"https://github.com/OpenLightingProject/ola.git","svn_url":"https://github.com/OpenLightingProject/ola","homepage":"https://www.openlighting.org/ola/","size":24327,"stargazers_count":108,"watchers_count":108,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":95,"forks":63,"open_issues":95,"watchers":108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenLightingProject/ola/pulls/892"},"html":{"href":"https://github.com/OpenLightingProject/ola/pull/892"},"issue":{"href":"https://api.github.com/repos/OpenLightingProject/ola/issues/892"},"comments":{"href":"https://api.github.com/repos/OpenLightingProject/ola/issues/892/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenLightingProject/ola/pulls/892/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenLightingProject/ola/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenLightingProject/ola/pulls/892/commits"},"statuses":{"href":"https://api.github.com/repos/OpenLightingProject/ola/statuses/211b0267b3b4cddc1f32cb7a95976970aa096829"}}}}