{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Identity/pulls/comments/22994151","id":22994151,"diff_hunk":"@@ -568,9 +593,18 @@ public virtual string NormalizeKey(string key)\n             var result = await VerifyPasswordAsync(passwordStore, user, password, cancellationToken);\n             if (result == PasswordVerificationResult.SuccessRehashNeeded) {\n                 await UpdatePasswordHash(passwordStore, user, password, cancellationToken, validatePassword: false);\n-                await UpdateAsync(user, cancellationToken);\n+                await UpdateUserAsync(user, cancellationToken);\n+            }\n+            if (result != PasswordVerificationResult.Failed)\n+            {\n+                await LogResultAsync(IdentityResult.Success, user);\n+            }\n+            else\n+            {\n+                await LogResultAsync(IdentityResult.Failed(ErrorDescriber.IncorrectPassword()), user);","path":"src/Microsoft.AspNet.Identity/UserManager.cs","position":139,"original_position":139,"commit_id":"bc87b975e711bd0fdb4cbdb850541c5a24850648","original_commit_id":"bc87b975e711bd0fdb4cbdb850541c5a24850648","user":{"login":"HaoK","id":6537861,"avatar_url":"https://avatars.githubusercontent.com/u/6537861?v=3","gravatar_id":"","url":"https://api.github.com/users/HaoK","html_url":"https://github.com/HaoK","followers_url":"https://api.github.com/users/HaoK/followers","following_url":"https://api.github.com/users/HaoK/following{/other_user}","gists_url":"https://api.github.com/users/HaoK/gists{/gist_id}","starred_url":"https://api.github.com/users/HaoK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaoK/subscriptions","organizations_url":"https://api.github.com/users/HaoK/orgs","repos_url":"https://api.github.com/users/HaoK/repos","events_url":"https://api.github.com/users/HaoK/events{/privacy}","received_events_url":"https://api.github.com/users/HaoK/received_events","type":"User","site_admin":false},"body":"I think you should have an overload of LogResult that takes a bool and just prints out, instead of introducing a new resource that isn't used except for logging\r\n\r\nCheckPasswordAsync for user: whatever : True | False","created_at":"2015-01-15T07:29:04Z","updated_at":"2015-01-15T07:29:04Z","html_url":"https://github.com/aspnet/Identity/pull/327#discussion_r22994151","pull_request_url":"https://api.github.com/repos/aspnet/Identity/pulls/327","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Identity/pulls/comments/22994151"},"html":{"href":"https://github.com/aspnet/Identity/pull/327#discussion_r22994151"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Identity/pulls/327"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Identity/pulls/327","id":27389628,"html_url":"https://github.com/aspnet/Identity/pull/327","diff_url":"https://github.com/aspnet/Identity/pull/327.diff","patch_url":"https://github.com/aspnet/Identity/pull/327.patch","issue_url":"https://api.github.com/repos/aspnet/Identity/issues/327","number":327,"state":"open","locked":false,"title":"Add logging","user":{"login":"suhasj","id":1919946,"avatar_url":"https://avatars.githubusercontent.com/u/1919946?v=3","gravatar_id":"","url":"https://api.github.com/users/suhasj","html_url":"https://github.com/suhasj","followers_url":"https://api.github.com/users/suhasj/followers","following_url":"https://api.github.com/users/suhasj/following{/other_user}","gists_url":"https://api.github.com/users/suhasj/gists{/gist_id}","starred_url":"https://api.github.com/users/suhasj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suhasj/subscriptions","organizations_url":"https://api.github.com/users/suhasj/orgs","repos_url":"https://api.github.com/users/suhasj/repos","events_url":"https://api.github.com/users/suhasj/events{/privacy}","received_events_url":"https://api.github.com/users/suhasj/received_events","type":"User","site_admin":false},"body":"@HaoK @divega \r\nPR for adding logging","created_at":"2015-01-14T22:29:23Z","updated_at":"2015-01-15T07:29:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2262c53054a85e119bfaf482cb1a026a706195f8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Identity/pulls/327/commits","review_comments_url":"https://api.github.com/repos/aspnet/Identity/pulls/327/comments","review_comment_url":"https://api.github.com/repos/aspnet/Identity/pulls/comments/{number}","comments_url":"https://api.github.com/repos/aspnet/Identity/issues/327/comments","statuses_url":"https://api.github.com/repos/aspnet/Identity/statuses/bc87b975e711bd0fdb4cbdb850541c5a24850648","head":{"label":"aspnet:AddLogging","ref":"AddLogging","sha":"bc87b975e711bd0fdb4cbdb850541c5a24850648","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":16491880,"name":"Identity","full_name":"aspnet/Identity","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Identity","description":"Membership system for building ASP.NET web applications, including membership, login, and user data.","fork":false,"url":"https://api.github.com/repos/aspnet/Identity","forks_url":"https://api.github.com/repos/aspnet/Identity/forks","keys_url":"https://api.github.com/repos/aspnet/Identity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Identity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Identity/teams","hooks_url":"https://api.github.com/repos/aspnet/Identity/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Identity/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Identity/events","assignees_url":"https://api.github.com/repos/aspnet/Identity/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Identity/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Identity/tags","blobs_url":"https://api.github.com/repos/aspnet/Identity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Identity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Identity/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Identity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Identity/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Identity/languages","stargazers_url":"https://api.github.com/repos/aspnet/Identity/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Identity/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Identity/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Identity/subscription","commits_url":"https://api.github.com/repos/aspnet/Identity/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Identity/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Identity/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Identity/issues/comments/{number}","contents_url":"https://api.github.com/repos/aspnet/Identity/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Identity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Identity/merges","archive_url":"https://api.github.com/repos/aspnet/Identity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Identity/downloads","issues_url":"https://api.github.com/repos/aspnet/Identity/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Identity/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Identity/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Identity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Identity/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Identity/releases{/id}","created_at":"2014-02-03T20:23:53Z","updated_at":"2015-01-14T11:58:16Z","pushed_at":"2015-01-14T22:28:59Z","git_url":"git://github.com/aspnet/Identity.git","ssh_url":"git@github.com:aspnet/Identity.git","clone_url":"https://github.com/aspnet/Identity.git","svn_url":"https://github.com/aspnet/Identity","homepage":"","size":6260,"stargazers_count":229,"watchers_count":229,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"open_issues_count":45,"forks":67,"open_issues":45,"watchers":229,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"69ac9abcc5bdd831026bb31983b9e4f2979915e5","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":16491880,"name":"Identity","full_name":"aspnet/Identity","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Identity","description":"Membership system for building ASP.NET web applications, including membership, login, and user data.","fork":false,"url":"https://api.github.com/repos/aspnet/Identity","forks_url":"https://api.github.com/repos/aspnet/Identity/forks","keys_url":"https://api.github.com/repos/aspnet/Identity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Identity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Identity/teams","hooks_url":"https://api.github.com/repos/aspnet/Identity/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Identity/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Identity/events","assignees_url":"https://api.github.com/repos/aspnet/Identity/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Identity/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Identity/tags","blobs_url":"https://api.github.com/repos/aspnet/Identity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Identity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Identity/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Identity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Identity/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Identity/languages","stargazers_url":"https://api.github.com/repos/aspnet/Identity/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Identity/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Identity/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Identity/subscription","commits_url":"https://api.github.com/repos/aspnet/Identity/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Identity/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Identity/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Identity/issues/comments/{number}","contents_url":"https://api.github.com/repos/aspnet/Identity/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Identity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Identity/merges","archive_url":"https://api.github.com/repos/aspnet/Identity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Identity/downloads","issues_url":"https://api.github.com/repos/aspnet/Identity/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Identity/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Identity/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Identity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Identity/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Identity/releases{/id}","created_at":"2014-02-03T20:23:53Z","updated_at":"2015-01-14T11:58:16Z","pushed_at":"2015-01-14T22:28:59Z","git_url":"git://github.com/aspnet/Identity.git","ssh_url":"git@github.com:aspnet/Identity.git","clone_url":"https://github.com/aspnet/Identity.git","svn_url":"https://github.com/aspnet/Identity","homepage":"","size":6260,"stargazers_count":229,"watchers_count":229,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"open_issues_count":45,"forks":67,"open_issues":45,"watchers":229,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Identity/pulls/327"},"html":{"href":"https://github.com/aspnet/Identity/pull/327"},"issue":{"href":"https://api.github.com/repos/aspnet/Identity/issues/327"},"comments":{"href":"https://api.github.com/repos/aspnet/Identity/issues/327/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Identity/pulls/327/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Identity/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Identity/pulls/327/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Identity/statuses/bc87b975e711bd0fdb4cbdb850541c5a24850648"}}}}