{"action":"created","comment":{"url":"https://api.github.com/repos/delapuente/offliner/pulls/comments/44052999","id":44052999,"diff_hunk":"@@ -185,7 +244,20 @@\n     },\n \n     /**\n-     * Discriminates between {{#crossLink OfflinerClient/xpromise:event}}{{/crossLink}}\n+     * Make offliner to check for pending activations and dispatch\n+     * {{#crossLink \"OfflinerClient/activationPending:event\"}}{{/crossLink}}\n+     * if so.\n+     *\n+     * @method _checkForActivationPending\n+     * @private\n+     */\n+    _checkForActivationPending: function () {\n+      // TODO: should we add a prefix for offliner messages?","path":"src/offliner-client.js","position":123,"original_position":123,"commit_id":"06b0a141a4c1446a09944ba1dcea143b7976c4fb","original_commit_id":"06b0a141a4c1446a09944ba1dcea143b7976c4fb","user":{"login":"marco-c","id":1616846,"avatar_url":"https://avatars.githubusercontent.com/u/1616846?v=3","gravatar_id":"","url":"https://api.github.com/users/marco-c","html_url":"https://github.com/marco-c","followers_url":"https://api.github.com/users/marco-c/followers","following_url":"https://api.github.com/users/marco-c/following{/other_user}","gists_url":"https://api.github.com/users/marco-c/gists{/gist_id}","starred_url":"https://api.github.com/users/marco-c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marco-c/subscriptions","organizations_url":"https://api.github.com/users/marco-c/orgs","repos_url":"https://api.github.com/users/marco-c/repos","events_url":"https://api.github.com/users/marco-c/events{/privacy}","received_events_url":"https://api.github.com/users/marco-c/received_events","type":"User","site_admin":false},"body":"I think it would be better to avoid conflicts.","created_at":"2015-11-05T18:59:57Z","updated_at":"2015-11-05T18:59:57Z","html_url":"https://github.com/delapuente/offliner/pull/13#discussion_r44052999","pull_request_url":"https://api.github.com/repos/delapuente/offliner/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/delapuente/offliner/pulls/comments/44052999"},"html":{"href":"https://github.com/delapuente/offliner/pull/13#discussion_r44052999"},"pull_request":{"href":"https://api.github.com/repos/delapuente/offliner/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/delapuente/offliner/pulls/13","id":49766149,"html_url":"https://github.com/delapuente/offliner/pull/13","diff_url":"https://github.com/delapuente/offliner/pull/13.diff","patch_url":"https://github.com/delapuente/offliner/pull/13.patch","issue_url":"https://api.github.com/repos/delapuente/offliner/issues/13","number":13,"state":"open","locked":false,"title":"Communication enhancements","user":{"login":"delapuente","id":757942,"avatar_url":"https://avatars.githubusercontent.com/u/757942?v=3","gravatar_id":"","url":"https://api.github.com/users/delapuente","html_url":"https://github.com/delapuente","followers_url":"https://api.github.com/users/delapuente/followers","following_url":"https://api.github.com/users/delapuente/following{/other_user}","gists_url":"https://api.github.com/users/delapuente/gists{/gist_id}","starred_url":"https://api.github.com/users/delapuente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delapuente/subscriptions","organizations_url":"https://api.github.com/users/delapuente/orgs","repos_url":"https://api.github.com/users/delapuente/repos","events_url":"https://api.github.com/users/delapuente/events{/privacy}","received_events_url":"https://api.github.com/users/delapuente/received_events","type":"User","site_admin":false},"body":"This closes #8 , closes #7 , closes #6 and closes #5 .\r\n@mykmelez or @marco-c , do you want to take a look for a second opinion before merging? Thanks!\r\n\r\nPS: You should pay attention to files under `/src` as everything else is autogenerated.","created_at":"2015-11-05T00:19:11Z","updated_at":"2015-11-05T18:59:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"905c1f09962a1be1769a3332515ae8473363f032","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/delapuente/offliner/pulls/13/commits","review_comments_url":"https://api.github.com/repos/delapuente/offliner/pulls/13/comments","review_comment_url":"https://api.github.com/repos/delapuente/offliner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/delapuente/offliner/issues/13/comments","statuses_url":"https://api.github.com/repos/delapuente/offliner/statuses/06b0a141a4c1446a09944ba1dcea143b7976c4fb","head":{"label":"delapuente:communication-enhancements","ref":"communication-enhancements","sha":"06b0a141a4c1446a09944ba1dcea143b7976c4fb","user":{"login":"delapuente","id":757942,"avatar_url":"https://avatars.githubusercontent.com/u/757942?v=3","gravatar_id":"","url":"https://api.github.com/users/delapuente","html_url":"https://github.com/delapuente","followers_url":"https://api.github.com/users/delapuente/followers","following_url":"https://api.github.com/users/delapuente/following{/other_user}","gists_url":"https://api.github.com/users/delapuente/gists{/gist_id}","starred_url":"https://api.github.com/users/delapuente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delapuente/subscriptions","organizations_url":"https://api.github.com/users/delapuente/orgs","repos_url":"https://api.github.com/users/delapuente/repos","events_url":"https://api.github.com/users/delapuente/events{/privacy}","received_events_url":"https://api.github.com/users/delapuente/received_events","type":"User","site_admin":false},"repo":{"id":28295910,"name":"offliner","full_name":"delapuente/offliner","owner":{"login":"delapuente","id":757942,"avatar_url":"https://avatars.githubusercontent.com/u/757942?v=3","gravatar_id":"","url":"https://api.github.com/users/delapuente","html_url":"https://github.com/delapuente","followers_url":"https://api.github.com/users/delapuente/followers","following_url":"https://api.github.com/users/delapuente/following{/other_user}","gists_url":"https://api.github.com/users/delapuente/gists{/gist_id}","starred_url":"https://api.github.com/users/delapuente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delapuente/subscriptions","organizations_url":"https://api.github.com/users/delapuente/orgs","repos_url":"https://api.github.com/users/delapuente/repos","events_url":"https://api.github.com/users/delapuente/events{/privacy}","received_events_url":"https://api.github.com/users/delapuente/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/delapuente/offliner","description":"Offliner is a proof of concept about bringing offline web applications through service workers","fork":false,"url":"https://api.github.com/repos/delapuente/offliner","forks_url":"https://api.github.com/repos/delapuente/offliner/forks","keys_url":"https://api.github.com/repos/delapuente/offliner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/delapuente/offliner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/delapuente/offliner/teams","hooks_url":"https://api.github.com/repos/delapuente/offliner/hooks","issue_events_url":"https://api.github.com/repos/delapuente/offliner/issues/events{/number}","events_url":"https://api.github.com/repos/delapuente/offliner/events","assignees_url":"https://api.github.com/repos/delapuente/offliner/assignees{/user}","branches_url":"https://api.github.com/repos/delapuente/offliner/branches{/branch}","tags_url":"https://api.github.com/repos/delapuente/offliner/tags","blobs_url":"https://api.github.com/repos/delapuente/offliner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/delapuente/offliner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/delapuente/offliner/git/refs{/sha}","trees_url":"https://api.github.com/repos/delapuente/offliner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/delapuente/offliner/statuses/{sha}","languages_url":"https://api.github.com/repos/delapuente/offliner/languages","stargazers_url":"https://api.github.com/repos/delapuente/offliner/stargazers","contributors_url":"https://api.github.com/repos/delapuente/offliner/contributors","subscribers_url":"https://api.github.com/repos/delapuente/offliner/subscribers","subscription_url":"https://api.github.com/repos/delapuente/offliner/subscription","commits_url":"https://api.github.com/repos/delapuente/offliner/commits{/sha}","git_commits_url":"https://api.github.com/repos/delapuente/offliner/git/commits{/sha}","comments_url":"https://api.github.com/repos/delapuente/offliner/comments{/number}","issue_comment_url":"https://api.github.com/repos/delapuente/offliner/issues/comments{/number}","contents_url":"https://api.github.com/repos/delapuente/offliner/contents/{+path}","compare_url":"https://api.github.com/repos/delapuente/offliner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/delapuente/offliner/merges","archive_url":"https://api.github.com/repos/delapuente/offliner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/delapuente/offliner/downloads","issues_url":"https://api.github.com/repos/delapuente/offliner/issues{/number}","pulls_url":"https://api.github.com/repos/delapuente/offliner/pulls{/number}","milestones_url":"https://api.github.com/repos/delapuente/offliner/milestones{/number}","notifications_url":"https://api.github.com/repos/delapuente/offliner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/delapuente/offliner/labels{/name}","releases_url":"https://api.github.com/repos/delapuente/offliner/releases{/id}","created_at":"2014-12-21T10:31:09Z","updated_at":"2015-11-05T04:04:54Z","pushed_at":"2015-11-05T00:19:11Z","git_url":"git://github.com/delapuente/offliner.git","ssh_url":"git@github.com:delapuente/offliner.git","clone_url":"https://github.com/delapuente/offliner.git","svn_url":"https://github.com/delapuente/offliner","homepage":null,"size":1113,"stargazers_count":38,"watchers_count":38,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":12,"forks":3,"open_issues":12,"watchers":38,"default_branch":"master"}},"base":{"label":"delapuente:master","ref":"master","sha":"6f3a58a63ce8186f6c694954347be6b524508b65","user":{"login":"delapuente","id":757942,"avatar_url":"https://avatars.githubusercontent.com/u/757942?v=3","gravatar_id":"","url":"https://api.github.com/users/delapuente","html_url":"https://github.com/delapuente","followers_url":"https://api.github.com/users/delapuente/followers","following_url":"https://api.github.com/users/delapuente/following{/other_user}","gists_url":"https://api.github.com/users/delapuente/gists{/gist_id}","starred_url":"https://api.github.com/users/delapuente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delapuente/subscriptions","organizations_url":"https://api.github.com/users/delapuente/orgs","repos_url":"https://api.github.com/users/delapuente/repos","events_url":"https://api.github.com/users/delapuente/events{/privacy}","received_events_url":"https://api.github.com/users/delapuente/received_events","type":"User","site_admin":false},"repo":{"id":28295910,"name":"offliner","full_name":"delapuente/offliner","owner":{"login":"delapuente","id":757942,"avatar_url":"https://avatars.githubusercontent.com/u/757942?v=3","gravatar_id":"","url":"https://api.github.com/users/delapuente","html_url":"https://github.com/delapuente","followers_url":"https://api.github.com/users/delapuente/followers","following_url":"https://api.github.com/users/delapuente/following{/other_user}","gists_url":"https://api.github.com/users/delapuente/gists{/gist_id}","starred_url":"https://api.github.com/users/delapuente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delapuente/subscriptions","organizations_url":"https://api.github.com/users/delapuente/orgs","repos_url":"https://api.github.com/users/delapuente/repos","events_url":"https://api.github.com/users/delapuente/events{/privacy}","received_events_url":"https://api.github.com/users/delapuente/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/delapuente/offliner","description":"Offliner is a proof of concept about bringing offline web applications through service workers","fork":false,"url":"https://api.github.com/repos/delapuente/offliner","forks_url":"https://api.github.com/repos/delapuente/offliner/forks","keys_url":"https://api.github.com/repos/delapuente/offliner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/delapuente/offliner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/delapuente/offliner/teams","hooks_url":"https://api.github.com/repos/delapuente/offliner/hooks","issue_events_url":"https://api.github.com/repos/delapuente/offliner/issues/events{/number}","events_url":"https://api.github.com/repos/delapuente/offliner/events","assignees_url":"https://api.github.com/repos/delapuente/offliner/assignees{/user}","branches_url":"https://api.github.com/repos/delapuente/offliner/branches{/branch}","tags_url":"https://api.github.com/repos/delapuente/offliner/tags","blobs_url":"https://api.github.com/repos/delapuente/offliner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/delapuente/offliner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/delapuente/offliner/git/refs{/sha}","trees_url":"https://api.github.com/repos/delapuente/offliner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/delapuente/offliner/statuses/{sha}","languages_url":"https://api.github.com/repos/delapuente/offliner/languages","stargazers_url":"https://api.github.com/repos/delapuente/offliner/stargazers","contributors_url":"https://api.github.com/repos/delapuente/offliner/contributors","subscribers_url":"https://api.github.com/repos/delapuente/offliner/subscribers","subscription_url":"https://api.github.com/repos/delapuente/offliner/subscription","commits_url":"https://api.github.com/repos/delapuente/offliner/commits{/sha}","git_commits_url":"https://api.github.com/repos/delapuente/offliner/git/commits{/sha}","comments_url":"https://api.github.com/repos/delapuente/offliner/comments{/number}","issue_comment_url":"https://api.github.com/repos/delapuente/offliner/issues/comments{/number}","contents_url":"https://api.github.com/repos/delapuente/offliner/contents/{+path}","compare_url":"https://api.github.com/repos/delapuente/offliner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/delapuente/offliner/merges","archive_url":"https://api.github.com/repos/delapuente/offliner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/delapuente/offliner/downloads","issues_url":"https://api.github.com/repos/delapuente/offliner/issues{/number}","pulls_url":"https://api.github.com/repos/delapuente/offliner/pulls{/number}","milestones_url":"https://api.github.com/repos/delapuente/offliner/milestones{/number}","notifications_url":"https://api.github.com/repos/delapuente/offliner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/delapuente/offliner/labels{/name}","releases_url":"https://api.github.com/repos/delapuente/offliner/releases{/id}","created_at":"2014-12-21T10:31:09Z","updated_at":"2015-11-05T04:04:54Z","pushed_at":"2015-11-05T00:19:11Z","git_url":"git://github.com/delapuente/offliner.git","ssh_url":"git@github.com:delapuente/offliner.git","clone_url":"https://github.com/delapuente/offliner.git","svn_url":"https://github.com/delapuente/offliner","homepage":null,"size":1113,"stargazers_count":38,"watchers_count":38,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":12,"forks":3,"open_issues":12,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/delapuente/offliner/pulls/13"},"html":{"href":"https://github.com/delapuente/offliner/pull/13"},"issue":{"href":"https://api.github.com/repos/delapuente/offliner/issues/13"},"comments":{"href":"https://api.github.com/repos/delapuente/offliner/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/delapuente/offliner/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/delapuente/offliner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/delapuente/offliner/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/delapuente/offliner/statuses/06b0a141a4c1446a09944ba1dcea143b7976c4fb"}}}}