{"action":"created","comment":{"url":"https://api.github.com/repos/SUSE/smdba/pulls/comments/41750595","id":41750595,"diff_hunk":"@@ -941,7 +941,7 @@ def do_system_check(self, *args, **params):\n             changed = True\n \n         # max_locks_per_transaction\n-        if not conf.get('max_locks_per_transaction'):\n+        if not conf.get('max_locks_per_transaction') or conf.get('max_locks_per_transaction') < '100':","path":"src/smdba/postgresqlgate.py","position":5,"original_position":5,"commit_id":"2f1de45bcf4b24114c1b998b2e83a36dcf2aa1b2","original_commit_id":"2f1de45bcf4b24114c1b998b2e83a36dcf2aa1b2","user":{"login":"isbm","id":1073714,"avatar_url":"https://avatars.githubusercontent.com/u/1073714?v=3","gravatar_id":"","url":"https://api.github.com/users/isbm","html_url":"https://github.com/isbm","followers_url":"https://api.github.com/users/isbm/followers","following_url":"https://api.github.com/users/isbm/following{/other_user}","gists_url":"https://api.github.com/users/isbm/gists{/gist_id}","starred_url":"https://api.github.com/users/isbm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isbm/subscriptions","organizations_url":"https://api.github.com/users/isbm/orgs","repos_url":"https://api.github.com/users/isbm/repos","events_url":"https://api.github.com/users/isbm/events{/privacy}","received_events_url":"https://api.github.com/users/isbm/received_events","type":"User","site_admin":false},"body":"That's another problem. Ideally, I like your way best though, but then config should be more smart and do something like:\r\n```python\r\ndef __setitem__(self, key, value):\r\n    if self.get(key) != value:\r\n        self[key] = value\r\n        self.changed = True\r\n```\r\n\r\nThen:\r\n```python\r\nconf['foo'] = 'blah'\r\n...\r\nif conf.changed:\r\n    ....\r\n```","created_at":"2015-10-12T12:23:21Z","updated_at":"2015-10-12T12:23:21Z","html_url":"https://github.com/SUSE/smdba/pull/8#discussion_r41750595","pull_request_url":"https://api.github.com/repos/SUSE/smdba/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/SUSE/smdba/pulls/comments/41750595"},"html":{"href":"https://github.com/SUSE/smdba/pull/8#discussion_r41750595"},"pull_request":{"href":"https://api.github.com/repos/SUSE/smdba/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/SUSE/smdba/pulls/8","id":47411926,"html_url":"https://github.com/SUSE/smdba/pull/8","diff_url":"https://github.com/SUSE/smdba/pull/8.diff","patch_url":"https://github.com/SUSE/smdba/pull/8.patch","issue_url":"https://api.github.com/repos/SUSE/smdba/issues/8","number":8,"state":"open","locked":false,"title":"do not set max_locks_per_transaction if already big enough","user":{"login":"mantel","id":1080885,"avatar_url":"https://avatars.githubusercontent.com/u/1080885?v=3","gravatar_id":"","url":"https://api.github.com/users/mantel","html_url":"https://github.com/mantel","followers_url":"https://api.github.com/users/mantel/followers","following_url":"https://api.github.com/users/mantel/following{/other_user}","gists_url":"https://api.github.com/users/mantel/gists{/gist_id}","starred_url":"https://api.github.com/users/mantel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantel/subscriptions","organizations_url":"https://api.github.com/users/mantel/orgs","repos_url":"https://api.github.com/users/mantel/repos","events_url":"https://api.github.com/users/mantel/events{/privacy}","received_events_url":"https://api.github.com/users/mantel/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-12T12:03:14Z","updated_at":"2015-10-12T12:23:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fdd5dd870f82b2e355ec4c65eced4d533c427e8d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SUSE/smdba/pulls/8/commits","review_comments_url":"https://api.github.com/repos/SUSE/smdba/pulls/8/comments","review_comment_url":"https://api.github.com/repos/SUSE/smdba/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SUSE/smdba/issues/8/comments","statuses_url":"https://api.github.com/repos/SUSE/smdba/statuses/2f1de45bcf4b24114c1b998b2e83a36dcf2aa1b2","head":{"label":"SUSE:max_locks_per_transaction","ref":"max_locks_per_transaction","sha":"2f1de45bcf4b24114c1b998b2e83a36dcf2aa1b2","user":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":4809407,"name":"smdba","full_name":"SUSE/smdba","owner":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE/smdba","description":"SUSE Manager database administration tool (replacement for spacewalk-dobby)","fork":false,"url":"https://api.github.com/repos/SUSE/smdba","forks_url":"https://api.github.com/repos/SUSE/smdba/forks","keys_url":"https://api.github.com/repos/SUSE/smdba/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/smdba/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/smdba/teams","hooks_url":"https://api.github.com/repos/SUSE/smdba/hooks","issue_events_url":"https://api.github.com/repos/SUSE/smdba/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/smdba/events","assignees_url":"https://api.github.com/repos/SUSE/smdba/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/smdba/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/smdba/tags","blobs_url":"https://api.github.com/repos/SUSE/smdba/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/smdba/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/smdba/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/smdba/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/smdba/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/smdba/languages","stargazers_url":"https://api.github.com/repos/SUSE/smdba/stargazers","contributors_url":"https://api.github.com/repos/SUSE/smdba/contributors","subscribers_url":"https://api.github.com/repos/SUSE/smdba/subscribers","subscription_url":"https://api.github.com/repos/SUSE/smdba/subscription","commits_url":"https://api.github.com/repos/SUSE/smdba/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/smdba/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/smdba/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/smdba/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE/smdba/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/smdba/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/smdba/merges","archive_url":"https://api.github.com/repos/SUSE/smdba/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/smdba/downloads","issues_url":"https://api.github.com/repos/SUSE/smdba/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/smdba/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/smdba/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/smdba/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/smdba/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/smdba/releases{/id}","created_at":"2012-06-27T14:36:21Z","updated_at":"2015-04-21T22:09:02Z","pushed_at":"2015-10-12T12:03:14Z","git_url":"git://github.com/SUSE/smdba.git","ssh_url":"git@github.com:SUSE/smdba.git","clone_url":"https://github.com/SUSE/smdba.git","svn_url":"https://github.com/SUSE/smdba","homepage":null,"size":388,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"SUSE:master","ref":"master","sha":"81767076e19120ebc9ae364668131a57a9d44d54","user":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":4809407,"name":"smdba","full_name":"SUSE/smdba","owner":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE/smdba","description":"SUSE Manager database administration tool (replacement for spacewalk-dobby)","fork":false,"url":"https://api.github.com/repos/SUSE/smdba","forks_url":"https://api.github.com/repos/SUSE/smdba/forks","keys_url":"https://api.github.com/repos/SUSE/smdba/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/smdba/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/smdba/teams","hooks_url":"https://api.github.com/repos/SUSE/smdba/hooks","issue_events_url":"https://api.github.com/repos/SUSE/smdba/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/smdba/events","assignees_url":"https://api.github.com/repos/SUSE/smdba/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/smdba/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/smdba/tags","blobs_url":"https://api.github.com/repos/SUSE/smdba/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/smdba/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/smdba/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/smdba/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/smdba/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/smdba/languages","stargazers_url":"https://api.github.com/repos/SUSE/smdba/stargazers","contributors_url":"https://api.github.com/repos/SUSE/smdba/contributors","subscribers_url":"https://api.github.com/repos/SUSE/smdba/subscribers","subscription_url":"https://api.github.com/repos/SUSE/smdba/subscription","commits_url":"https://api.github.com/repos/SUSE/smdba/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/smdba/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/smdba/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/smdba/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE/smdba/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/smdba/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/smdba/merges","archive_url":"https://api.github.com/repos/SUSE/smdba/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/smdba/downloads","issues_url":"https://api.github.com/repos/SUSE/smdba/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/smdba/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/smdba/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/smdba/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/smdba/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/smdba/releases{/id}","created_at":"2012-06-27T14:36:21Z","updated_at":"2015-04-21T22:09:02Z","pushed_at":"2015-10-12T12:03:14Z","git_url":"git://github.com/SUSE/smdba.git","ssh_url":"git@github.com:SUSE/smdba.git","clone_url":"https://github.com/SUSE/smdba.git","svn_url":"https://github.com/SUSE/smdba","homepage":null,"size":388,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SUSE/smdba/pulls/8"},"html":{"href":"https://github.com/SUSE/smdba/pull/8"},"issue":{"href":"https://api.github.com/repos/SUSE/smdba/issues/8"},"comments":{"href":"https://api.github.com/repos/SUSE/smdba/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/SUSE/smdba/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/SUSE/smdba/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SUSE/smdba/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/SUSE/smdba/statuses/2f1de45bcf4b24114c1b998b2e83a36dcf2aa1b2"}}}}