{"action":"created","comment":{"url":"https://api.github.com/repos/TouchType/CornedBeef/pulls/comments/47353991","id":47353991,"diff_hunk":"@@ -24,3 +29,42 @@ dependencies {\n     testCompile 'org.robolectric:robolectric:3.0-rc3'\n     testCompile 'org.mockito:mockito-all:2.0.2-beta'\n }\n+\n+publishing {\n+    publications {\n+        aar(MavenPublication) {\n+            groupId \"TouchType\"\n+            version = android.defaultConfig.versionName\n+            artifactId project.getName()\n+\n+            // Tell maven to prepare the generated \"*.aar\" file for publishing\n+            artifact(\"$buildDir/outputs/aar/${project.getName()}-release.aar\")\n+        }\n+    }\n+}\n+\n+artifactory {\n+\n+    // artifactory properties with local defaults\n+    def user=project.properties['artifactory_user'] ?: \"admin\"","path":"cornedbeef/build.gradle","position":39,"original_position":39,"commit_id":"9e3dfa9cb5d5e2366d1c74042ecf2f8c3d39fe01","original_commit_id":"9e3dfa9cb5d5e2366d1c74042ecf2f8c3d39fe01","user":{"login":"lachiemurray","id":3168140,"avatar_url":"https://avatars.githubusercontent.com/u/3168140?v=3","gravatar_id":"","url":"https://api.github.com/users/lachiemurray","html_url":"https://github.com/lachiemurray","followers_url":"https://api.github.com/users/lachiemurray/followers","following_url":"https://api.github.com/users/lachiemurray/following{/other_user}","gists_url":"https://api.github.com/users/lachiemurray/gists{/gist_id}","starred_url":"https://api.github.com/users/lachiemurray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lachiemurray/subscriptions","organizations_url":"https://api.github.com/users/lachiemurray/orgs","repos_url":"https://api.github.com/users/lachiemurray/repos","events_url":"https://api.github.com/users/lachiemurray/events{/privacy}","received_events_url":"https://api.github.com/users/lachiemurray/received_events","type":"User","site_admin":false},"body":"Interested in your thoughts on this @eartle ?\r\n\r\nThe intention is that this publish job will overwrite the params using -Partifactory_user -Partifactory_pass etc.\r\n\r\nbut is there a better / more standard way of doing this?\r\n\r\nI can't reference the properties directly because it will throw an error when they are not specified (even if I'm not publishing)","created_at":"2015-12-11T13:23:21Z","updated_at":"2015-12-11T13:23:21Z","html_url":"https://github.com/TouchType/CornedBeef/pull/2#discussion_r47353991","pull_request_url":"https://api.github.com/repos/TouchType/CornedBeef/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/TouchType/CornedBeef/pulls/comments/47353991"},"html":{"href":"https://github.com/TouchType/CornedBeef/pull/2#discussion_r47353991"},"pull_request":{"href":"https://api.github.com/repos/TouchType/CornedBeef/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/TouchType/CornedBeef/pulls/2","id":53385642,"html_url":"https://github.com/TouchType/CornedBeef/pull/2","diff_url":"https://github.com/TouchType/CornedBeef/pull/2.diff","patch_url":"https://github.com/TouchType/CornedBeef/pull/2.patch","issue_url":"https://api.github.com/repos/TouchType/CornedBeef/issues/2","number":2,"state":"open","locked":false,"title":"Add support for publishing to artifactory","user":{"login":"lachiemurray","id":3168140,"avatar_url":"https://avatars.githubusercontent.com/u/3168140?v=3","gravatar_id":"","url":"https://api.github.com/users/lachiemurray","html_url":"https://github.com/lachiemurray","followers_url":"https://api.github.com/users/lachiemurray/followers","following_url":"https://api.github.com/users/lachiemurray/following{/other_user}","gists_url":"https://api.github.com/users/lachiemurray/gists{/gist_id}","starred_url":"https://api.github.com/users/lachiemurray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lachiemurray/subscriptions","organizations_url":"https://api.github.com/users/lachiemurray/orgs","repos_url":"https://api.github.com/users/lachiemurray/repos","events_url":"https://api.github.com/users/lachiemurray/events{/privacy}","received_events_url":"https://api.github.com/users/lachiemurray/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-11T12:12:54Z","updated_at":"2015-12-11T13:23:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60ff8ab3ce461706eac9b6353818998f36707680","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TouchType/CornedBeef/pulls/2/commits","review_comments_url":"https://api.github.com/repos/TouchType/CornedBeef/pulls/2/comments","review_comment_url":"https://api.github.com/repos/TouchType/CornedBeef/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TouchType/CornedBeef/issues/2/comments","statuses_url":"https://api.github.com/repos/TouchType/CornedBeef/statuses/9e3dfa9cb5d5e2366d1c74042ecf2f8c3d39fe01","head":{"label":"TouchType:artifactory-publishing","ref":"artifactory-publishing","sha":"9e3dfa9cb5d5e2366d1c74042ecf2f8c3d39fe01","user":{"login":"TouchType","id":506645,"avatar_url":"https://avatars.githubusercontent.com/u/506645?v=3","gravatar_id":"","url":"https://api.github.com/users/TouchType","html_url":"https://github.com/TouchType","followers_url":"https://api.github.com/users/TouchType/followers","following_url":"https://api.github.com/users/TouchType/following{/other_user}","gists_url":"https://api.github.com/users/TouchType/gists{/gist_id}","starred_url":"https://api.github.com/users/TouchType/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TouchType/subscriptions","organizations_url":"https://api.github.com/users/TouchType/orgs","repos_url":"https://api.github.com/users/TouchType/repos","events_url":"https://api.github.com/users/TouchType/events{/privacy}","received_events_url":"https://api.github.com/users/TouchType/received_events","type":"Organization","site_admin":false},"repo":{"id":38813242,"name":"CornedBeef","full_name":"TouchType/CornedBeef","owner":{"login":"TouchType","id":506645,"avatar_url":"https://avatars.githubusercontent.com/u/506645?v=3","gravatar_id":"","url":"https://api.github.com/users/TouchType","html_url":"https://github.com/TouchType","followers_url":"https://api.github.com/users/TouchType/followers","following_url":"https://api.github.com/users/TouchType/following{/other_user}","gists_url":"https://api.github.com/users/TouchType/gists{/gist_id}","starred_url":"https://api.github.com/users/TouchType/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TouchType/subscriptions","organizations_url":"https://api.github.com/users/TouchType/orgs","repos_url":"https://api.github.com/users/TouchType/repos","events_url":"https://api.github.com/users/TouchType/events{/privacy}","received_events_url":"https://api.github.com/users/TouchType/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TouchType/CornedBeef","description":"Android 'coach mark' library","fork":false,"url":"https://api.github.com/repos/TouchType/CornedBeef","forks_url":"https://api.github.com/repos/TouchType/CornedBeef/forks","keys_url":"https://api.github.com/repos/TouchType/CornedBeef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TouchType/CornedBeef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TouchType/CornedBeef/teams","hooks_url":"https://api.github.com/repos/TouchType/CornedBeef/hooks","issue_events_url":"https://api.github.com/repos/TouchType/CornedBeef/issues/events{/number}","events_url":"https://api.github.com/repos/TouchType/CornedBeef/events","assignees_url":"https://api.github.com/repos/TouchType/CornedBeef/assignees{/user}","branches_url":"https://api.github.com/repos/TouchType/CornedBeef/branches{/branch}","tags_url":"https://api.github.com/repos/TouchType/CornedBeef/tags","blobs_url":"https://api.github.com/repos/TouchType/CornedBeef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TouchType/CornedBeef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TouchType/CornedBeef/git/refs{/sha}","trees_url":"https://api.github.com/repos/TouchType/CornedBeef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TouchType/CornedBeef/statuses/{sha}","languages_url":"https://api.github.com/repos/TouchType/CornedBeef/languages","stargazers_url":"https://api.github.com/repos/TouchType/CornedBeef/stargazers","contributors_url":"https://api.github.com/repos/TouchType/CornedBeef/contributors","subscribers_url":"https://api.github.com/repos/TouchType/CornedBeef/subscribers","subscription_url":"https://api.github.com/repos/TouchType/CornedBeef/subscription","commits_url":"https://api.github.com/repos/TouchType/CornedBeef/commits{/sha}","git_commits_url":"https://api.github.com/repos/TouchType/CornedBeef/git/commits{/sha}","comments_url":"https://api.github.com/repos/TouchType/CornedBeef/comments{/number}","issue_comment_url":"https://api.github.com/repos/TouchType/CornedBeef/issues/comments{/number}","contents_url":"https://api.github.com/repos/TouchType/CornedBeef/contents/{+path}","compare_url":"https://api.github.com/repos/TouchType/CornedBeef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TouchType/CornedBeef/merges","archive_url":"https://api.github.com/repos/TouchType/CornedBeef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TouchType/CornedBeef/downloads","issues_url":"https://api.github.com/repos/TouchType/CornedBeef/issues{/number}","pulls_url":"https://api.github.com/repos/TouchType/CornedBeef/pulls{/number}","milestones_url":"https://api.github.com/repos/TouchType/CornedBeef/milestones{/number}","notifications_url":"https://api.github.com/repos/TouchType/CornedBeef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TouchType/CornedBeef/labels{/name}","releases_url":"https://api.github.com/repos/TouchType/CornedBeef/releases{/id}","created_at":"2015-07-09T10:08:08Z","updated_at":"2015-11-07T22:56:30Z","pushed_at":"2015-12-11T13:19:35Z","git_url":"git://github.com/TouchType/CornedBeef.git","ssh_url":"git@github.com:TouchType/CornedBeef.git","clone_url":"https://github.com/TouchType/CornedBeef.git","svn_url":"https://github.com/TouchType/CornedBeef","homepage":null,"size":118,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":3,"default_branch":"master"}},"base":{"label":"TouchType:master","ref":"master","sha":"7d8387066eae52af1755684b2af476547c34bd00","user":{"login":"TouchType","id":506645,"avatar_url":"https://avatars.githubusercontent.com/u/506645?v=3","gravatar_id":"","url":"https://api.github.com/users/TouchType","html_url":"https://github.com/TouchType","followers_url":"https://api.github.com/users/TouchType/followers","following_url":"https://api.github.com/users/TouchType/following{/other_user}","gists_url":"https://api.github.com/users/TouchType/gists{/gist_id}","starred_url":"https://api.github.com/users/TouchType/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TouchType/subscriptions","organizations_url":"https://api.github.com/users/TouchType/orgs","repos_url":"https://api.github.com/users/TouchType/repos","events_url":"https://api.github.com/users/TouchType/events{/privacy}","received_events_url":"https://api.github.com/users/TouchType/received_events","type":"Organization","site_admin":false},"repo":{"id":38813242,"name":"CornedBeef","full_name":"TouchType/CornedBeef","owner":{"login":"TouchType","id":506645,"avatar_url":"https://avatars.githubusercontent.com/u/506645?v=3","gravatar_id":"","url":"https://api.github.com/users/TouchType","html_url":"https://github.com/TouchType","followers_url":"https://api.github.com/users/TouchType/followers","following_url":"https://api.github.com/users/TouchType/following{/other_user}","gists_url":"https://api.github.com/users/TouchType/gists{/gist_id}","starred_url":"https://api.github.com/users/TouchType/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TouchType/subscriptions","organizations_url":"https://api.github.com/users/TouchType/orgs","repos_url":"https://api.github.com/users/TouchType/repos","events_url":"https://api.github.com/users/TouchType/events{/privacy}","received_events_url":"https://api.github.com/users/TouchType/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TouchType/CornedBeef","description":"Android 'coach mark' library","fork":false,"url":"https://api.github.com/repos/TouchType/CornedBeef","forks_url":"https://api.github.com/repos/TouchType/CornedBeef/forks","keys_url":"https://api.github.com/repos/TouchType/CornedBeef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TouchType/CornedBeef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TouchType/CornedBeef/teams","hooks_url":"https://api.github.com/repos/TouchType/CornedBeef/hooks","issue_events_url":"https://api.github.com/repos/TouchType/CornedBeef/issues/events{/number}","events_url":"https://api.github.com/repos/TouchType/CornedBeef/events","assignees_url":"https://api.github.com/repos/TouchType/CornedBeef/assignees{/user}","branches_url":"https://api.github.com/repos/TouchType/CornedBeef/branches{/branch}","tags_url":"https://api.github.com/repos/TouchType/CornedBeef/tags","blobs_url":"https://api.github.com/repos/TouchType/CornedBeef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TouchType/CornedBeef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TouchType/CornedBeef/git/refs{/sha}","trees_url":"https://api.github.com/repos/TouchType/CornedBeef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TouchType/CornedBeef/statuses/{sha}","languages_url":"https://api.github.com/repos/TouchType/CornedBeef/languages","stargazers_url":"https://api.github.com/repos/TouchType/CornedBeef/stargazers","contributors_url":"https://api.github.com/repos/TouchType/CornedBeef/contributors","subscribers_url":"https://api.github.com/repos/TouchType/CornedBeef/subscribers","subscription_url":"https://api.github.com/repos/TouchType/CornedBeef/subscription","commits_url":"https://api.github.com/repos/TouchType/CornedBeef/commits{/sha}","git_commits_url":"https://api.github.com/repos/TouchType/CornedBeef/git/commits{/sha}","comments_url":"https://api.github.com/repos/TouchType/CornedBeef/comments{/number}","issue_comment_url":"https://api.github.com/repos/TouchType/CornedBeef/issues/comments{/number}","contents_url":"https://api.github.com/repos/TouchType/CornedBeef/contents/{+path}","compare_url":"https://api.github.com/repos/TouchType/CornedBeef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TouchType/CornedBeef/merges","archive_url":"https://api.github.com/repos/TouchType/CornedBeef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TouchType/CornedBeef/downloads","issues_url":"https://api.github.com/repos/TouchType/CornedBeef/issues{/number}","pulls_url":"https://api.github.com/repos/TouchType/CornedBeef/pulls{/number}","milestones_url":"https://api.github.com/repos/TouchType/CornedBeef/milestones{/number}","notifications_url":"https://api.github.com/repos/TouchType/CornedBeef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TouchType/CornedBeef/labels{/name}","releases_url":"https://api.github.com/repos/TouchType/CornedBeef/releases{/id}","created_at":"2015-07-09T10:08:08Z","updated_at":"2015-11-07T22:56:30Z","pushed_at":"2015-12-11T13:19:35Z","git_url":"git://github.com/TouchType/CornedBeef.git","ssh_url":"git@github.com:TouchType/CornedBeef.git","clone_url":"https://github.com/TouchType/CornedBeef.git","svn_url":"https://github.com/TouchType/CornedBeef","homepage":null,"size":118,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TouchType/CornedBeef/pulls/2"},"html":{"href":"https://github.com/TouchType/CornedBeef/pull/2"},"issue":{"href":"https://api.github.com/repos/TouchType/CornedBeef/issues/2"},"comments":{"href":"https://api.github.com/repos/TouchType/CornedBeef/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/TouchType/CornedBeef/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/TouchType/CornedBeef/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TouchType/CornedBeef/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/TouchType/CornedBeef/statuses/9e3dfa9cb5d5e2366d1c74042ecf2f8c3d39fe01"}}}}