{"action":"created","issue":{"url":"https://api.github.com/repos/ipython/ipython/issues/8191","labels_url":"https://api.github.com/repos/ipython/ipython/issues/8191/labels{/name}","comments_url":"https://api.github.com/repos/ipython/ipython/issues/8191/comments","events_url":"https://api.github.com/repos/ipython/ipython/issues/8191/events","html_url":"https://github.com/ipython/ipython/pull/8191","id":65108830,"number":8191,"title":"small focus/keyboard-related fixes for 3.1","user":{"login":"minrk","id":151929,"avatar_url":"https://avatars.githubusercontent.com/u/151929?v=3","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-29T23:56:30Z","updated_at":"2015-03-30T01:10:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ipython/ipython/pulls/8191","html_url":"https://github.com/ipython/ipython/pull/8191","diff_url":"https://github.com/ipython/ipython/pull/8191.diff","patch_url":"https://github.com/ipython/ipython/pull/8191.patch"},"body":"- don't disable keyboard shortcuts on main toolbar\n- remove some extraneous focus_cell calls from actions.js\n\nThis restores most of the toolbar behavior of 2.x.\n\n@ellisonbg can you enumerate some of the remaining focus problems that are still problematic in this PR? I'm trying to keep this reasonable for 3.1."},"comment":{"url":"https://api.github.com/repos/ipython/ipython/issues/comments/87506567","html_url":"https://github.com/ipython/ipython/pull/8191#issuecomment-87506567","issue_url":"https://api.github.com/repos/ipython/ipython/issues/8191","id":87506567,"user":{"login":"ellisonbg","id":27600,"avatar_url":"https://avatars.githubusercontent.com/u/27600?v=3","gravatar_id":"","url":"https://api.github.com/users/ellisonbg","html_url":"https://github.com/ellisonbg","followers_url":"https://api.github.com/users/ellisonbg/followers","following_url":"https://api.github.com/users/ellisonbg/following{/other_user}","gists_url":"https://api.github.com/users/ellisonbg/gists{/gist_id}","starred_url":"https://api.github.com/users/ellisonbg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ellisonbg/subscriptions","organizations_url":"https://api.github.com/users/ellisonbg/orgs","repos_url":"https://api.github.com/users/ellisonbg/repos","events_url":"https://api.github.com/users/ellisonbg/events{/privacy}","received_events_url":"https://api.github.com/users/ellisonbg/received_events","type":"User","site_admin":false},"created_at":"2015-03-30T01:10:29Z","updated_at":"2015-03-30T01:10:29Z","body":"This does fix some behaviors, but there are still some others that remain:\r\n\r\n* Clicking on save in the toolbar causes a jump because of the `ensure_focus` logic that appears in a few places. Let's try removing that stuff as well (it is super simple and only in a few places).\r\n* Hitting `esc` to enter command mode can cause a jump if the cell is large and not scrolled into the optimal position. The code that does this is carefully commented by me, but I thought that code behaved differently than it does now. It could be a browser change or my memory. @jdfreder do you remember how this behaved in 2.0?\r\n* There are still 2 calls to `focus_cell` in `maintoolbar.js` to manage the cell type and celltoolbar select menues. I am not sure how these will behave after we re-add those to the register_events..."}}