{"action":"created","comment":{"url":"https://api.github.com/repos/Igalia/snabbswitch/pulls/comments/47894107","id":47894107,"diff_hunk":"@@ -1,7 +1,13 @@\n {\n- {'127:2:3:4:5:6:7:128', '178.79.150.233', 1, 100, '8:9:a:b:c:d:e:f'},\n- {'127:11:12:13:14:15:16:128', '178.79.150.233', 101, 64000},\n- {'127:22:33:44:55:66:77:128', '178.79.150.15', 5, 7000},\n- {'127:24:35:46:57:68:79:128', '178.79.150.2', 7800, 7900, '1E:1:1:1:1:1:1:af'},\n- {'127:14:25:36:47:58:69:128', '178.79.150.3', 4000, 5050, '1E:2:2:2:2:2:2:af'}\n+ {'127:2:3:4:5:6:7:128', '178.79.150.233', {80, 0, 16}, '8:9:a:b:c:d:e:f'},\n+ {'127:11:12:13:14:15:16:128', '178.79.150.233', {2300, 0, 16}},","path":"src/program/snabb_lwaftr/tests/data/binding.table","position":8,"original_position":8,"commit_id":"90fe0ead6b2707e990b47721fd9dbf823e661f10","original_commit_id":"90fe0ead6b2707e990b47721fd9dbf823e661f10","user":{"login":"andywingo","id":1745903,"avatar_url":"https://avatars.githubusercontent.com/u/1745903?v=3","gravatar_id":"","url":"https://api.github.com/users/andywingo","html_url":"https://github.com/andywingo","followers_url":"https://api.github.com/users/andywingo/followers","following_url":"https://api.github.com/users/andywingo/following{/other_user}","gists_url":"https://api.github.com/users/andywingo/gists{/gist_id}","starred_url":"https://api.github.com/users/andywingo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andywingo/subscriptions","organizations_url":"https://api.github.com/users/andywingo/orgs","repos_url":"https://api.github.com/users/andywingo/repos","events_url":"https://api.github.com/users/andywingo/events{/privacy}","received_events_url":"https://api.github.com/users/andywingo/received_events","type":"User","site_admin":false},"body":"I think we don't need to force a=0, given that we already have to look up the.... the what?  You see, we need names :)  I'll call it the bitwidth then.  \"PSID bitwidth\" -- how many bits wide the PSID is.  Anyway given that we have to look it up in a table, we might as well look up the shift at the same time.\r\n\r\nWe could alternately assume that shift = 16-bitwidth.  Probably a better way to do things.","created_at":"2015-12-17T11:11:17Z","updated_at":"2015-12-17T11:11:17Z","html_url":"https://github.com/Igalia/snabbswitch/pull/161#discussion_r47894107","pull_request_url":"https://api.github.com/repos/Igalia/snabbswitch/pulls/161","_links":{"self":{"href":"https://api.github.com/repos/Igalia/snabbswitch/pulls/comments/47894107"},"html":{"href":"https://github.com/Igalia/snabbswitch/pull/161#discussion_r47894107"},"pull_request":{"href":"https://api.github.com/repos/Igalia/snabbswitch/pulls/161"}}},"pull_request":{"url":"https://api.github.com/repos/Igalia/snabbswitch/pulls/161","id":53025233,"html_url":"https://github.com/Igalia/snabbswitch/pull/161","diff_url":"https://github.com/Igalia/snabbswitch/pull/161.diff","patch_url":"https://github.com/Igalia/snabbswitch/pull/161.patch","issue_url":"https://api.github.com/repos/Igalia/snabbswitch/issues/161","number":161,"state":"open","locked":false,"title":"Use PSID format in binding table","user":{"login":"dpino","id":11567,"avatar_url":"https://avatars.githubusercontent.com/u/11567?v=3","gravatar_id":"","url":"https://api.github.com/users/dpino","html_url":"https://github.com/dpino","followers_url":"https://api.github.com/users/dpino/followers","following_url":"https://api.github.com/users/dpino/following{/other_user}","gists_url":"https://api.github.com/users/dpino/gists{/gist_id}","starred_url":"https://api.github.com/users/dpino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpino/subscriptions","organizations_url":"https://api.github.com/users/dpino/orgs","repos_url":"https://api.github.com/users/dpino/repos","events_url":"https://api.github.com/users/dpino/events{/privacy}","received_events_url":"https://api.github.com/users/dpino/received_events","type":"User","site_admin":false},"body":"This PR changes the format of each entry in the binding table:\r\n\r\n```\r\n{ b4_v6, v4, { psid_info }, br_v6 }\r\n```\r\n\r\nWhere psid:\r\n\r\n```\r\n{ PSID, psid_offset, psid_length }\r\n```\r\n\r\nIt also changes the lookup code in the binding table by converting a port number to PSID. Some tests are failing, probably it's necessary to update some pcap packets port number. This PR implements #101 and outdates #157.","created_at":"2015-12-08T19:20:02Z","updated_at":"2015-12-17T11:11:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22f600b79c3bf45b5924bf6fbef2394224d5eac0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Igalia/snabbswitch/pulls/161/commits","review_comments_url":"https://api.github.com/repos/Igalia/snabbswitch/pulls/161/comments","review_comment_url":"https://api.github.com/repos/Igalia/snabbswitch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Igalia/snabbswitch/issues/161/comments","statuses_url":"https://api.github.com/repos/Igalia/snabbswitch/statuses/90fe0ead6b2707e990b47721fd9dbf823e661f10","head":{"label":"dpino:lookup_psid","ref":"lookup_psid","sha":"90fe0ead6b2707e990b47721fd9dbf823e661f10","user":{"login":"dpino","id":11567,"avatar_url":"https://avatars.githubusercontent.com/u/11567?v=3","gravatar_id":"","url":"https://api.github.com/users/dpino","html_url":"https://github.com/dpino","followers_url":"https://api.github.com/users/dpino/followers","following_url":"https://api.github.com/users/dpino/following{/other_user}","gists_url":"https://api.github.com/users/dpino/gists{/gist_id}","starred_url":"https://api.github.com/users/dpino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpino/subscriptions","organizations_url":"https://api.github.com/users/dpino/orgs","repos_url":"https://api.github.com/users/dpino/repos","events_url":"https://api.github.com/users/dpino/events{/privacy}","received_events_url":"https://api.github.com/users/dpino/received_events","type":"User","site_admin":false},"repo":{"id":24632602,"name":"snabbswitch","full_name":"dpino/snabbswitch","owner":{"login":"dpino","id":11567,"avatar_url":"https://avatars.githubusercontent.com/u/11567?v=3","gravatar_id":"","url":"https://api.github.com/users/dpino","html_url":"https://github.com/dpino","followers_url":"https://api.github.com/users/dpino/followers","following_url":"https://api.github.com/users/dpino/following{/other_user}","gists_url":"https://api.github.com/users/dpino/gists{/gist_id}","starred_url":"https://api.github.com/users/dpino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpino/subscriptions","organizations_url":"https://api.github.com/users/dpino/orgs","repos_url":"https://api.github.com/users/dpino/repos","events_url":"https://api.github.com/users/dpino/events{/privacy}","received_events_url":"https://api.github.com/users/dpino/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dpino/snabbswitch","description":"Snabb Switch: Fast open source packet processing","fork":true,"url":"https://api.github.com/repos/dpino/snabbswitch","forks_url":"https://api.github.com/repos/dpino/snabbswitch/forks","keys_url":"https://api.github.com/repos/dpino/snabbswitch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dpino/snabbswitch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dpino/snabbswitch/teams","hooks_url":"https://api.github.com/repos/dpino/snabbswitch/hooks","issue_events_url":"https://api.github.com/repos/dpino/snabbswitch/issues/events{/number}","events_url":"https://api.github.com/repos/dpino/snabbswitch/events","assignees_url":"https://api.github.com/repos/dpino/snabbswitch/assignees{/user}","branches_url":"https://api.github.com/repos/dpino/snabbswitch/branches{/branch}","tags_url":"https://api.github.com/repos/dpino/snabbswitch/tags","blobs_url":"https://api.github.com/repos/dpino/snabbswitch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dpino/snabbswitch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dpino/snabbswitch/git/refs{/sha}","trees_url":"https://api.github.com/repos/dpino/snabbswitch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dpino/snabbswitch/statuses/{sha}","languages_url":"https://api.github.com/repos/dpino/snabbswitch/languages","stargazers_url":"https://api.github.com/repos/dpino/snabbswitch/stargazers","contributors_url":"https://api.github.com/repos/dpino/snabbswitch/contributors","subscribers_url":"https://api.github.com/repos/dpino/snabbswitch/subscribers","subscription_url":"https://api.github.com/repos/dpino/snabbswitch/subscription","commits_url":"https://api.github.com/repos/dpino/snabbswitch/commits{/sha}","git_commits_url":"https://api.github.com/repos/dpino/snabbswitch/git/commits{/sha}","comments_url":"https://api.github.com/repos/dpino/snabbswitch/comments{/number}","issue_comment_url":"https://api.github.com/repos/dpino/snabbswitch/issues/comments{/number}","contents_url":"https://api.github.com/repos/dpino/snabbswitch/contents/{+path}","compare_url":"https://api.github.com/repos/dpino/snabbswitch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dpino/snabbswitch/merges","archive_url":"https://api.github.com/repos/dpino/snabbswitch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dpino/snabbswitch/downloads","issues_url":"https://api.github.com/repos/dpino/snabbswitch/issues{/number}","pulls_url":"https://api.github.com/repos/dpino/snabbswitch/pulls{/number}","milestones_url":"https://api.github.com/repos/dpino/snabbswitch/milestones{/number}","notifications_url":"https://api.github.com/repos/dpino/snabbswitch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dpino/snabbswitch/labels{/name}","releases_url":"https://api.github.com/repos/dpino/snabbswitch/releases{/id}","created_at":"2014-09-30T09:33:54Z","updated_at":"2015-04-23T11:16:19Z","pushed_at":"2015-12-17T10:19:06Z","git_url":"git://github.com/dpino/snabbswitch.git","ssh_url":"git@github.com:dpino/snabbswitch.git","clone_url":"https://github.com/dpino/snabbswitch.git","svn_url":"https://github.com/dpino/snabbswitch","homepage":"","size":7431,"stargazers_count":1,"watchers_count":1,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Igalia:lwaftr_olive","ref":"lwaftr_olive","sha":"c69dfc17191e4a61a886956a4384648c92ff2f29","user":{"login":"Igalia","id":1576566,"avatar_url":"https://avatars.githubusercontent.com/u/1576566?v=3","gravatar_id":"","url":"https://api.github.com/users/Igalia","html_url":"https://github.com/Igalia","followers_url":"https://api.github.com/users/Igalia/followers","following_url":"https://api.github.com/users/Igalia/following{/other_user}","gists_url":"https://api.github.com/users/Igalia/gists{/gist_id}","starred_url":"https://api.github.com/users/Igalia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Igalia/subscriptions","organizations_url":"https://api.github.com/users/Igalia/orgs","repos_url":"https://api.github.com/users/Igalia/repos","events_url":"https://api.github.com/users/Igalia/events{/privacy}","received_events_url":"https://api.github.com/users/Igalia/received_events","type":"Organization","site_admin":false},"repo":{"id":34452469,"name":"snabbswitch","full_name":"Igalia/snabbswitch","owner":{"login":"Igalia","id":1576566,"avatar_url":"https://avatars.githubusercontent.com/u/1576566?v=3","gravatar_id":"","url":"https://api.github.com/users/Igalia","html_url":"https://github.com/Igalia","followers_url":"https://api.github.com/users/Igalia/followers","following_url":"https://api.github.com/users/Igalia/following{/other_user}","gists_url":"https://api.github.com/users/Igalia/gists{/gist_id}","starred_url":"https://api.github.com/users/Igalia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Igalia/subscriptions","organizations_url":"https://api.github.com/users/Igalia/orgs","repos_url":"https://api.github.com/users/Igalia/repos","events_url":"https://api.github.com/users/Igalia/events{/privacy}","received_events_url":"https://api.github.com/users/Igalia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Igalia/snabbswitch","description":"Snabb Switch: Fast open source packet processing","fork":true,"url":"https://api.github.com/repos/Igalia/snabbswitch","forks_url":"https://api.github.com/repos/Igalia/snabbswitch/forks","keys_url":"https://api.github.com/repos/Igalia/snabbswitch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Igalia/snabbswitch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Igalia/snabbswitch/teams","hooks_url":"https://api.github.com/repos/Igalia/snabbswitch/hooks","issue_events_url":"https://api.github.com/repos/Igalia/snabbswitch/issues/events{/number}","events_url":"https://api.github.com/repos/Igalia/snabbswitch/events","assignees_url":"https://api.github.com/repos/Igalia/snabbswitch/assignees{/user}","branches_url":"https://api.github.com/repos/Igalia/snabbswitch/branches{/branch}","tags_url":"https://api.github.com/repos/Igalia/snabbswitch/tags","blobs_url":"https://api.github.com/repos/Igalia/snabbswitch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Igalia/snabbswitch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Igalia/snabbswitch/git/refs{/sha}","trees_url":"https://api.github.com/repos/Igalia/snabbswitch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Igalia/snabbswitch/statuses/{sha}","languages_url":"https://api.github.com/repos/Igalia/snabbswitch/languages","stargazers_url":"https://api.github.com/repos/Igalia/snabbswitch/stargazers","contributors_url":"https://api.github.com/repos/Igalia/snabbswitch/contributors","subscribers_url":"https://api.github.com/repos/Igalia/snabbswitch/subscribers","subscription_url":"https://api.github.com/repos/Igalia/snabbswitch/subscription","commits_url":"https://api.github.com/repos/Igalia/snabbswitch/commits{/sha}","git_commits_url":"https://api.github.com/repos/Igalia/snabbswitch/git/commits{/sha}","comments_url":"https://api.github.com/repos/Igalia/snabbswitch/comments{/number}","issue_comment_url":"https://api.github.com/repos/Igalia/snabbswitch/issues/comments{/number}","contents_url":"https://api.github.com/repos/Igalia/snabbswitch/contents/{+path}","compare_url":"https://api.github.com/repos/Igalia/snabbswitch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Igalia/snabbswitch/merges","archive_url":"https://api.github.com/repos/Igalia/snabbswitch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Igalia/snabbswitch/downloads","issues_url":"https://api.github.com/repos/Igalia/snabbswitch/issues{/number}","pulls_url":"https://api.github.com/repos/Igalia/snabbswitch/pulls{/number}","milestones_url":"https://api.github.com/repos/Igalia/snabbswitch/milestones{/number}","notifications_url":"https://api.github.com/repos/Igalia/snabbswitch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Igalia/snabbswitch/labels{/name}","releases_url":"https://api.github.com/repos/Igalia/snabbswitch/releases{/id}","created_at":"2015-04-23T11:35:43Z","updated_at":"2015-12-16T07:20:42Z","pushed_at":"2015-12-17T10:19:07Z","git_url":"git://github.com/Igalia/snabbswitch.git","ssh_url":"git@github.com:Igalia/snabbswitch.git","clone_url":"https://github.com/Igalia/snabbswitch.git","svn_url":"https://github.com/Igalia/snabbswitch","homepage":"","size":7352,"stargazers_count":5,"watchers_count":5,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":20,"forks":1,"open_issues":20,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Igalia/snabbswitch/pulls/161"},"html":{"href":"https://github.com/Igalia/snabbswitch/pull/161"},"issue":{"href":"https://api.github.com/repos/Igalia/snabbswitch/issues/161"},"comments":{"href":"https://api.github.com/repos/Igalia/snabbswitch/issues/161/comments"},"review_comments":{"href":"https://api.github.com/repos/Igalia/snabbswitch/pulls/161/comments"},"review_comment":{"href":"https://api.github.com/repos/Igalia/snabbswitch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Igalia/snabbswitch/pulls/161/commits"},"statuses":{"href":"https://api.github.com/repos/Igalia/snabbswitch/statuses/90fe0ead6b2707e990b47721fd9dbf823e661f10"}}}}