{"action":"created","issue":{"url":"https://api.github.com/repos/nom-tam-fits/nom-tam-fits/issues/11","labels_url":"https://api.github.com/repos/nom-tam-fits/nom-tam-fits/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/nom-tam-fits/nom-tam-fits/issues/11/comments","events_url":"https://api.github.com/repos/nom-tam-fits/nom-tam-fits/issues/11/events","html_url":"https://github.com/nom-tam-fits/nom-tam-fits/issues/11","id":66579118,"number":11,"title":"String value length limitation?","user":{"login":"supermartzin","id":6864050,"avatar_url":"https://avatars.githubusercontent.com/u/6864050?v=3","gravatar_id":"","url":"https://api.github.com/users/supermartzin","html_url":"https://github.com/supermartzin","followers_url":"https://api.github.com/users/supermartzin/followers","following_url":"https://api.github.com/users/supermartzin/following{/other_user}","gists_url":"https://api.github.com/users/supermartzin/gists{/gist_id}","starred_url":"https://api.github.com/users/supermartzin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supermartzin/subscriptions","organizations_url":"https://api.github.com/users/supermartzin/orgs","repos_url":"https://api.github.com/users/supermartzin/repos","events_url":"https://api.github.com/users/supermartzin/events{/privacy}","received_events_url":"https://api.github.com/users/supermartzin/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nom-tam-fits/nom-tam-fits/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/nom-tam-fits/nom-tam-fits/labels/question","name":"question","color":"cc317c"}],"state":"open","locked":false,"assignee":{"login":"TomMcGlynn","id":3277276,"avatar_url":"https://avatars.githubusercontent.com/u/3277276?v=3","gravatar_id":"","url":"https://api.github.com/users/TomMcGlynn","html_url":"https://github.com/TomMcGlynn","followers_url":"https://api.github.com/users/TomMcGlynn/followers","following_url":"https://api.github.com/users/TomMcGlynn/following{/other_user}","gists_url":"https://api.github.com/users/TomMcGlynn/gists{/gist_id}","starred_url":"https://api.github.com/users/TomMcGlynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomMcGlynn/subscriptions","organizations_url":"https://api.github.com/users/TomMcGlynn/orgs","repos_url":"https://api.github.com/users/TomMcGlynn/repos","events_url":"https://api.github.com/users/TomMcGlynn/events{/privacy}","received_events_url":"https://api.github.com/users/TomMcGlynn/received_events","type":"User","site_admin":false},"milestone":null,"comments":8,"created_at":"2015-04-06T10:42:52Z","updated_at":"2015-04-07T12:33:47Z","closed_at":null,"body":"Hi,\r\nI've got another case of strange behaviour when saving **string value** to header card:\r\n```java\r\nHeaderCard card = new HeaderCard(\"KEYWORD\", \"v\", \"comment of FITS header card with length of exactly 64 characters\");\r\n```\r\nWhole header card should have now length of **80** characters - **10** for ```KEYWORD˽=˽```, **3** for ```'v'```, another **3** for ```˽/˽``` and remaining **64** for comment value ```comment of FITS header card with length of exactly 64 characters```\r\nNevertheless header card is saved to header as this:\r\n```\r\nKEYWORD = 'v       '           / comment of FITS header card with length of exac\r\n```\r\n\r\nI'm not aware of any length limitation for string values in FITS file specification so is this an expected behaviour?\r\n\r\nThanks :)"},"comment":{"url":"https://api.github.com/repos/nom-tam-fits/nom-tam-fits/issues/comments/90533675","html_url":"https://github.com/nom-tam-fits/nom-tam-fits/issues/11#issuecomment-90533675","issue_url":"https://api.github.com/repos/nom-tam-fits/nom-tam-fits/issues/11","id":90533675,"user":{"login":"TomMcGlynn","id":3277276,"avatar_url":"https://avatars.githubusercontent.com/u/3277276?v=3","gravatar_id":"","url":"https://api.github.com/users/TomMcGlynn","html_url":"https://github.com/TomMcGlynn","followers_url":"https://api.github.com/users/TomMcGlynn/followers","following_url":"https://api.github.com/users/TomMcGlynn/following{/other_user}","gists_url":"https://api.github.com/users/TomMcGlynn/gists{/gist_id}","starred_url":"https://api.github.com/users/TomMcGlynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomMcGlynn/subscriptions","organizations_url":"https://api.github.com/users/TomMcGlynn/orgs","repos_url":"https://api.github.com/users/TomMcGlynn/repos","events_url":"https://api.github.com/users/TomMcGlynn/events{/privacy}","received_events_url":"https://api.github.com/users/TomMcGlynn/received_events","type":"User","site_admin":false},"created_at":"2015-04-07T12:33:47Z","updated_at":"2015-04-07T12:33:47Z","body":"Richard van Nieuwenhoven wrote:\n>\n> Maybe it would be good to try to allign the String but if the comment \n> would not fit then go without alignment?\n>\n> —\n> Reply to this email directly or view it on GitHub \n> <https://github.com/nom-tam-fits/nom-tam-fits/issues/11#issuecomment-90130041>.\n>\nThis would be fine as an option, but I think it would be a mistake to \nmake it the default.  Other people using the library will see the \ncontents of their files change and regression tests may fail.  If there \nwere a significant benefit it might be worth inflicting that pain but\nregardless of this choice, the API silently truncates comments at some \nlength, the only question is do we allow short string to have slightly \nlonger comments.\n"}}