{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-app-ios/pulls/comments/41398837","id":41398837,"diff_hunk":"@@ -56,26 +51,34 @@ class DiscussionTopicsCell: UITableViewCell {\n         self.contentView.addSubview(titleLabel)\n \n         self.titleLabel.snp_makeConstraints { (make) -> Void in\n-            make.trailing.equalTo(self.contentView).offset(margin)\n-            make.top.equalTo(self.contentView)\n-            make.bottom.equalTo(self.contentView)\n+            make.trailing.equalTo(self.contentView).offset(-StandardHorizontalMargin)\n+            make.top.equalTo(self.contentView).offset(StandardVerticalMargin)\n+            make.bottom.equalTo(self.contentView).offset(-StandardVerticalMargin)\n             make.leading.equalTo(self.contentView).offset(self.indentationOffsetForDepth(itemDepth: depth))\n         }\n+        self.titleLabel.numberOfLines = 0\n     }\n     \n     private var depth : UInt = 0 {\n         didSet {\n             self.titleLabel.snp_updateConstraints { make in\n                 make.leading.equalTo(self.contentView).offset(self.indentationOffsetForDepth(itemDepth: depth))\n+                depth == 0 ? self.applyStandardSeparatorInsets() : self.removeStandardSeparatorInsets()","path":"Source/DiscussionTopicCell.swift","position":69,"original_position":69,"commit_id":"b7b8ae87ba9bfb32149a1f4b9fe021423a429444","original_commit_id":"b7b8ae87ba9bfb32149a1f4b9fe021423a429444","user":{"login":"aleffert","id":114396,"avatar_url":"https://avatars.githubusercontent.com/u/114396?v=3","gravatar_id":"","url":"https://api.github.com/users/aleffert","html_url":"https://github.com/aleffert","followers_url":"https://api.github.com/users/aleffert/followers","following_url":"https://api.github.com/users/aleffert/following{/other_user}","gists_url":"https://api.github.com/users/aleffert/gists{/gist_id}","starred_url":"https://api.github.com/users/aleffert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleffert/subscriptions","organizations_url":"https://api.github.com/users/aleffert/orgs","repos_url":"https://api.github.com/users/aleffert/repos","events_url":"https://api.github.com/users/aleffert/events{/privacy}","received_events_url":"https://api.github.com/users/aleffert/received_events","type":"User","site_admin":false},"body":"Instead of \"removing\" the insets, should we instead apply a \"nested\" inset or something like that? That way we don't have to care what the defaults are, since Apple has been known to change them.","created_at":"2015-10-07T14:46:10Z","updated_at":"2015-10-07T14:46:10Z","html_url":"https://github.com/edx/edx-app-ios/pull/457#discussion_r41398837","pull_request_url":"https://api.github.com/repos/edx/edx-app-ios/pulls/457","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-app-ios/pulls/comments/41398837"},"html":{"href":"https://github.com/edx/edx-app-ios/pull/457#discussion_r41398837"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-app-ios/pulls/457"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-app-ios/pulls/457","id":47016187,"html_url":"https://github.com/edx/edx-app-ios/pull/457","diff_url":"https://github.com/edx/edx-app-ios/pull/457.diff","patch_url":"https://github.com/edx/edx-app-ios/pull/457.patch","issue_url":"https://api.github.com/repos/edx/edx-app-ios/issues/457","number":457,"state":"open","locked":false,"title":"Assorted changes to Discussion Screens","user":{"login":"ehmadzubair","id":10597112,"avatar_url":"https://avatars.githubusercontent.com/u/10597112?v=3","gravatar_id":"","url":"https://api.github.com/users/ehmadzubair","html_url":"https://github.com/ehmadzubair","followers_url":"https://api.github.com/users/ehmadzubair/followers","following_url":"https://api.github.com/users/ehmadzubair/following{/other_user}","gists_url":"https://api.github.com/users/ehmadzubair/gists{/gist_id}","starred_url":"https://api.github.com/users/ehmadzubair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehmadzubair/subscriptions","organizations_url":"https://api.github.com/users/ehmadzubair/orgs","repos_url":"https://api.github.com/users/ehmadzubair/repos","events_url":"https://api.github.com/users/ehmadzubair/events{/privacy}","received_events_url":"https://api.github.com/users/ehmadzubair/received_events","type":"User","site_admin":false},"body":"- Discussion Topics screen now matches spec + Auto Resizing for Topics with longer titles\r\n- `UISearchBar` matches spec when on iOS9\r\n- Match Add Comment and Add Response as navigation titles\r\n- Pin the Search Bar to the top and add a separator\r\n- Replace a \"\" String with a user-friendly string\r\n\r\n###### \"If user is not following any posts, the \"Posts I'm following\" should not be visible\"\r\nThis wasn't done because there's no graceful way to know if the user is following any posts for the endpoint : `/api/discussion/v1/course-v1:TestX+TestCourse+TestRun`\r\n\r\n### Topics Screen\r\n![simulator screen shot 07-oct-2015 4 56 35 pm](https://cloud.githubusercontent.com/assets/10597112/10336741/77fb4d90-6d14-11e5-9d16-2cf3df5ce916.png)\r\n\r\n### Resizing Cells\r\n\r\n![simulator screen shot 07-oct-2015 3 12 25 pm](https://cloud.githubusercontent.com/assets/10597112/10336331/7fe1f732-6d11-11e5-9709-0cf9b1d9be14.png)","created_at":"2015-10-07T11:37:17Z","updated_at":"2015-10-07T14:46:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec2daacb081f1607e2a46072f27a0a22e9241256","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-app-ios/pulls/457/commits","review_comments_url":"https://api.github.com/repos/edx/edx-app-ios/pulls/457/comments","review_comment_url":"https://api.github.com/repos/edx/edx-app-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-app-ios/issues/457/comments","statuses_url":"https://api.github.com/repos/edx/edx-app-ios/statuses/b7b8ae87ba9bfb32149a1f4b9fe021423a429444","head":{"label":"edx:ehmad/DiscussionImprovements","ref":"ehmad/DiscussionImprovements","sha":"b7b8ae87ba9bfb32149a1f4b9fe021423a429444","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":29251733,"name":"edx-app-ios","full_name":"edx/edx-app-ios","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-app-ios","description":"","fork":false,"url":"https://api.github.com/repos/edx/edx-app-ios","forks_url":"https://api.github.com/repos/edx/edx-app-ios/forks","keys_url":"https://api.github.com/repos/edx/edx-app-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-app-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-app-ios/teams","hooks_url":"https://api.github.com/repos/edx/edx-app-ios/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-app-ios/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-app-ios/events","assignees_url":"https://api.github.com/repos/edx/edx-app-ios/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-app-ios/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-app-ios/tags","blobs_url":"https://api.github.com/repos/edx/edx-app-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-app-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-app-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-app-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-app-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-app-ios/languages","stargazers_url":"https://api.github.com/repos/edx/edx-app-ios/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-app-ios/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-app-ios/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-app-ios/subscription","commits_url":"https://api.github.com/repos/edx/edx-app-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-app-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-app-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-app-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-app-ios/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-app-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-app-ios/merges","archive_url":"https://api.github.com/repos/edx/edx-app-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-app-ios/downloads","issues_url":"https://api.github.com/repos/edx/edx-app-ios/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-app-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-app-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-app-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-app-ios/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-app-ios/releases{/id}","created_at":"2015-01-14T15:49:29Z","updated_at":"2015-09-28T05:59:42Z","pushed_at":"2015-10-07T14:24:50Z","git_url":"git://github.com/edx/edx-app-ios.git","ssh_url":"git@github.com:edx/edx-app-ios.git","clone_url":"https://github.com/edx/edx-app-ios.git","svn_url":"https://github.com/edx/edx-app-ios","homepage":null,"size":291418,"stargazers_count":34,"watchers_count":34,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":7,"forks":47,"open_issues":7,"watchers":34,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"ac266d627a65365f20f52e8b4a1e320046a2bb53","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":29251733,"name":"edx-app-ios","full_name":"edx/edx-app-ios","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-app-ios","description":"","fork":false,"url":"https://api.github.com/repos/edx/edx-app-ios","forks_url":"https://api.github.com/repos/edx/edx-app-ios/forks","keys_url":"https://api.github.com/repos/edx/edx-app-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-app-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-app-ios/teams","hooks_url":"https://api.github.com/repos/edx/edx-app-ios/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-app-ios/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-app-ios/events","assignees_url":"https://api.github.com/repos/edx/edx-app-ios/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-app-ios/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-app-ios/tags","blobs_url":"https://api.github.com/repos/edx/edx-app-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-app-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-app-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-app-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-app-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-app-ios/languages","stargazers_url":"https://api.github.com/repos/edx/edx-app-ios/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-app-ios/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-app-ios/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-app-ios/subscription","commits_url":"https://api.github.com/repos/edx/edx-app-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-app-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-app-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-app-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-app-ios/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-app-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-app-ios/merges","archive_url":"https://api.github.com/repos/edx/edx-app-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-app-ios/downloads","issues_url":"https://api.github.com/repos/edx/edx-app-ios/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-app-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-app-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-app-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-app-ios/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-app-ios/releases{/id}","created_at":"2015-01-14T15:49:29Z","updated_at":"2015-09-28T05:59:42Z","pushed_at":"2015-10-07T14:24:50Z","git_url":"git://github.com/edx/edx-app-ios.git","ssh_url":"git@github.com:edx/edx-app-ios.git","clone_url":"https://github.com/edx/edx-app-ios.git","svn_url":"https://github.com/edx/edx-app-ios","homepage":null,"size":291418,"stargazers_count":34,"watchers_count":34,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":7,"forks":47,"open_issues":7,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-app-ios/pulls/457"},"html":{"href":"https://github.com/edx/edx-app-ios/pull/457"},"issue":{"href":"https://api.github.com/repos/edx/edx-app-ios/issues/457"},"comments":{"href":"https://api.github.com/repos/edx/edx-app-ios/issues/457/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-app-ios/pulls/457/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-app-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-app-ios/pulls/457/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-app-ios/statuses/b7b8ae87ba9bfb32149a1f4b9fe021423a429444"}}}}