{"action":"created","issue":{"url":"https://api.github.com/repos/ember-cli/ember-cli/issues/3786","labels_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/3786/labels{/name}","comments_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/3786/comments","events_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/3786/events","html_url":"https://github.com/ember-cli/ember-cli/pull/3786","id":66265815,"number":3786,"title":"Throw if templating a file fails","user":{"login":"davewasmer","id":707213,"avatar_url":"https://avatars.githubusercontent.com/u/707213?v=3","gravatar_id":"","url":"https://api.github.com/users/davewasmer","html_url":"https://github.com/davewasmer","followers_url":"https://api.github.com/users/davewasmer/followers","following_url":"https://api.github.com/users/davewasmer/following{/other_user}","gists_url":"https://api.github.com/users/davewasmer/gists{/gist_id}","starred_url":"https://api.github.com/users/davewasmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davewasmer/subscriptions","organizations_url":"https://api.github.com/users/davewasmer/orgs","repos_url":"https://api.github.com/users/davewasmer/repos","events_url":"https://api.github.com/users/davewasmer/events{/privacy}","received_events_url":"https://api.github.com/users/davewasmer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-04T02:42:28Z","updated_at":"2015-04-04T08:47:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/3786","html_url":"https://github.com/ember-cli/ember-cli/pull/3786","diff_url":"https://github.com/ember-cli/ember-cli/pull/3786.diff","patch_url":"https://github.com/ember-cli/ember-cli/pull/3786.patch"},"body":"Previously, if an error was thrown during the template rendering process, the error was simply swallowed. This was likely to avoid errors when attempting to template a binary file, since the byte stream, when converted to a string, could contain template markers.\r\n\r\nAdds the isbinaryfile package to detect if the file is binary. If so, it skips templating entirely. If not, it attempts to template the file, and allows exceptions to reject the render promise.\r\n\r\nThis happened to expose some tests that should have been failing around the http-proxy generators (the tests were not supplying enough arguments). Fixes those tests too."},"comment":{"url":"https://api.github.com/repos/ember-cli/ember-cli/issues/comments/89529968","html_url":"https://github.com/ember-cli/ember-cli/pull/3786#issuecomment-89529968","issue_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/3786","id":89529968,"user":{"login":"QuantumInformation","id":216566,"avatar_url":"https://avatars.githubusercontent.com/u/216566?v=3","gravatar_id":"","url":"https://api.github.com/users/QuantumInformation","html_url":"https://github.com/QuantumInformation","followers_url":"https://api.github.com/users/QuantumInformation/followers","following_url":"https://api.github.com/users/QuantumInformation/following{/other_user}","gists_url":"https://api.github.com/users/QuantumInformation/gists{/gist_id}","starred_url":"https://api.github.com/users/QuantumInformation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuantumInformation/subscriptions","organizations_url":"https://api.github.com/users/QuantumInformation/orgs","repos_url":"https://api.github.com/users/QuantumInformation/repos","events_url":"https://api.github.com/users/QuantumInformation/events{/privacy}","received_events_url":"https://api.github.com/users/QuantumInformation/received_events","type":"User","site_admin":false},"created_at":"2015-04-04T08:47:21Z","updated_at":"2015-04-04T08:47:21Z","body":"I'm going through the upgrade steps for my test-recorder then will link to this branch from my npm and run ember init again."}}