{"action":"created","comment":{"url":"https://api.github.com/repos/begriffs/postgrest/pulls/comments/40847982","id":40847982,"diff_hunk":"@@ -29,12 +29,12 @@ spec = beforeAll (clearTable \"items\" >> createItems 15) . afterAll_ (clearTable\n             }\n \n         it \"returns range Content-Range with range/*\" $\n-          request methodGet \"/items?order=id\"\n+          request methodGet \"/items?id=eq.1&order=id\"","path":"test/Feature/RangeSpec.hs","position":5,"original_position":5,"commit_id":"6ea995efa3729e73d2214b9a62b63183c69ad258","original_commit_id":"6ea995efa3729e73d2214b9a62b63183c69ad258","user":{"login":"begriffs","id":911911,"avatar_url":"https://avatars.githubusercontent.com/u/911911?v=3","gravatar_id":"","url":"https://api.github.com/users/begriffs","html_url":"https://github.com/begriffs","followers_url":"https://api.github.com/users/begriffs/followers","following_url":"https://api.github.com/users/begriffs/following{/other_user}","gists_url":"https://api.github.com/users/begriffs/gists{/gist_id}","starred_url":"https://api.github.com/users/begriffs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/begriffs/subscriptions","organizations_url":"https://api.github.com/users/begriffs/orgs","repos_url":"https://api.github.com/users/begriffs/repos","events_url":"https://api.github.com/users/begriffs/events{/privacy}","received_events_url":"https://api.github.com/users/begriffs/received_events","type":"User","site_admin":false},"body":"What about leaving the old test in place and adding this one with the filter as an additional test rather than replacing the old test? Might as well cover both paths in the code.","created_at":"2015-09-30T20:37:32Z","updated_at":"2015-09-30T20:37:32Z","html_url":"https://github.com/begriffs/postgrest/pull/298#discussion_r40847982","pull_request_url":"https://api.github.com/repos/begriffs/postgrest/pulls/298","_links":{"self":{"href":"https://api.github.com/repos/begriffs/postgrest/pulls/comments/40847982"},"html":{"href":"https://github.com/begriffs/postgrest/pull/298#discussion_r40847982"},"pull_request":{"href":"https://api.github.com/repos/begriffs/postgrest/pulls/298"}}},"pull_request":{"url":"https://api.github.com/repos/begriffs/postgrest/pulls/298","id":46448177,"html_url":"https://github.com/begriffs/postgrest/pull/298","diff_url":"https://github.com/begriffs/postgrest/pull/298.diff","patch_url":"https://github.com/begriffs/postgrest/pull/298.patch","issue_url":"https://api.github.com/repos/begriffs/postgrest/issues/298","number":298,"state":"open","locked":false,"title":"Fix count=none when we have filters","user":{"login":"diogob","id":20662,"avatar_url":"https://avatars.githubusercontent.com/u/20662?v=3","gravatar_id":"","url":"https://api.github.com/users/diogob","html_url":"https://github.com/diogob","followers_url":"https://api.github.com/users/diogob/followers","following_url":"https://api.github.com/users/diogob/following{/other_user}","gists_url":"https://api.github.com/users/diogob/gists{/gist_id}","starred_url":"https://api.github.com/users/diogob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diogob/subscriptions","organizations_url":"https://api.github.com/users/diogob/orgs","repos_url":"https://api.github.com/users/diogob/repos","events_url":"https://api.github.com/users/diogob/events{/privacy}","received_events_url":"https://api.github.com/users/diogob/received_events","type":"User","site_admin":false},"body":"The where clause should be discarded when count=none.\r\nThis was generating a database run time error for we did not have a test case for filters with count=none, so I modified one of the test cases I've included in the previous PR","created_at":"2015-09-30T19:54:56Z","updated_at":"2015-09-30T20:37:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9fe64f0d2e7c481e3cb501f337e4718e32c1afb1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/begriffs/postgrest/pulls/298/commits","review_comments_url":"https://api.github.com/repos/begriffs/postgrest/pulls/298/comments","review_comment_url":"https://api.github.com/repos/begriffs/postgrest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/begriffs/postgrest/issues/298/comments","statuses_url":"https://api.github.com/repos/begriffs/postgrest/statuses/6ea995efa3729e73d2214b9a62b63183c69ad258","head":{"label":"diogob:fix_count_none","ref":"fix_count_none","sha":"6ea995efa3729e73d2214b9a62b63183c69ad258","user":{"login":"diogob","id":20662,"avatar_url":"https://avatars.githubusercontent.com/u/20662?v=3","gravatar_id":"","url":"https://api.github.com/users/diogob","html_url":"https://github.com/diogob","followers_url":"https://api.github.com/users/diogob/followers","following_url":"https://api.github.com/users/diogob/following{/other_user}","gists_url":"https://api.github.com/users/diogob/gists{/gist_id}","starred_url":"https://api.github.com/users/diogob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diogob/subscriptions","organizations_url":"https://api.github.com/users/diogob/orgs","repos_url":"https://api.github.com/users/diogob/repos","events_url":"https://api.github.com/users/diogob/events{/privacy}","received_events_url":"https://api.github.com/users/diogob/received_events","type":"User","site_admin":false},"repo":{"id":36082351,"name":"postgrest","full_name":"diogob/postgrest","owner":{"login":"diogob","id":20662,"avatar_url":"https://avatars.githubusercontent.com/u/20662?v=3","gravatar_id":"","url":"https://api.github.com/users/diogob","html_url":"https://github.com/diogob","followers_url":"https://api.github.com/users/diogob/followers","following_url":"https://api.github.com/users/diogob/following{/other_user}","gists_url":"https://api.github.com/users/diogob/gists{/gist_id}","starred_url":"https://api.github.com/users/diogob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diogob/subscriptions","organizations_url":"https://api.github.com/users/diogob/orgs","repos_url":"https://api.github.com/users/diogob/repos","events_url":"https://api.github.com/users/diogob/events{/privacy}","received_events_url":"https://api.github.com/users/diogob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/diogob/postgrest","description":"REST API for any Postgres database","fork":true,"url":"https://api.github.com/repos/diogob/postgrest","forks_url":"https://api.github.com/repos/diogob/postgrest/forks","keys_url":"https://api.github.com/repos/diogob/postgrest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diogob/postgrest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diogob/postgrest/teams","hooks_url":"https://api.github.com/repos/diogob/postgrest/hooks","issue_events_url":"https://api.github.com/repos/diogob/postgrest/issues/events{/number}","events_url":"https://api.github.com/repos/diogob/postgrest/events","assignees_url":"https://api.github.com/repos/diogob/postgrest/assignees{/user}","branches_url":"https://api.github.com/repos/diogob/postgrest/branches{/branch}","tags_url":"https://api.github.com/repos/diogob/postgrest/tags","blobs_url":"https://api.github.com/repos/diogob/postgrest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diogob/postgrest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diogob/postgrest/git/refs{/sha}","trees_url":"https://api.github.com/repos/diogob/postgrest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diogob/postgrest/statuses/{sha}","languages_url":"https://api.github.com/repos/diogob/postgrest/languages","stargazers_url":"https://api.github.com/repos/diogob/postgrest/stargazers","contributors_url":"https://api.github.com/repos/diogob/postgrest/contributors","subscribers_url":"https://api.github.com/repos/diogob/postgrest/subscribers","subscription_url":"https://api.github.com/repos/diogob/postgrest/subscription","commits_url":"https://api.github.com/repos/diogob/postgrest/commits{/sha}","git_commits_url":"https://api.github.com/repos/diogob/postgrest/git/commits{/sha}","comments_url":"https://api.github.com/repos/diogob/postgrest/comments{/number}","issue_comment_url":"https://api.github.com/repos/diogob/postgrest/issues/comments{/number}","contents_url":"https://api.github.com/repos/diogob/postgrest/contents/{+path}","compare_url":"https://api.github.com/repos/diogob/postgrest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diogob/postgrest/merges","archive_url":"https://api.github.com/repos/diogob/postgrest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diogob/postgrest/downloads","issues_url":"https://api.github.com/repos/diogob/postgrest/issues{/number}","pulls_url":"https://api.github.com/repos/diogob/postgrest/pulls{/number}","milestones_url":"https://api.github.com/repos/diogob/postgrest/milestones{/number}","notifications_url":"https://api.github.com/repos/diogob/postgrest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diogob/postgrest/labels{/name}","releases_url":"https://api.github.com/repos/diogob/postgrest/releases{/id}","created_at":"2015-05-22T16:20:22Z","updated_at":"2015-05-22T16:20:23Z","pushed_at":"2015-09-30T17:50:40Z","git_url":"git://github.com/diogob/postgrest.git","ssh_url":"git@github.com:diogob/postgrest.git","clone_url":"https://github.com/diogob/postgrest.git","svn_url":"https://github.com/diogob/postgrest","homepage":"","size":731,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"begriffs:master","ref":"master","sha":"29ae1bdefdd32514a9bba064fbd3a1725fbc9290","user":{"login":"begriffs","id":911911,"avatar_url":"https://avatars.githubusercontent.com/u/911911?v=3","gravatar_id":"","url":"https://api.github.com/users/begriffs","html_url":"https://github.com/begriffs","followers_url":"https://api.github.com/users/begriffs/followers","following_url":"https://api.github.com/users/begriffs/following{/other_user}","gists_url":"https://api.github.com/users/begriffs/gists{/gist_id}","starred_url":"https://api.github.com/users/begriffs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/begriffs/subscriptions","organizations_url":"https://api.github.com/users/begriffs/orgs","repos_url":"https://api.github.com/users/begriffs/repos","events_url":"https://api.github.com/users/begriffs/events{/privacy}","received_events_url":"https://api.github.com/users/begriffs/received_events","type":"User","site_admin":false},"repo":{"id":20787122,"name":"postgrest","full_name":"begriffs/postgrest","owner":{"login":"begriffs","id":911911,"avatar_url":"https://avatars.githubusercontent.com/u/911911?v=3","gravatar_id":"","url":"https://api.github.com/users/begriffs","html_url":"https://github.com/begriffs","followers_url":"https://api.github.com/users/begriffs/followers","following_url":"https://api.github.com/users/begriffs/following{/other_user}","gists_url":"https://api.github.com/users/begriffs/gists{/gist_id}","starred_url":"https://api.github.com/users/begriffs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/begriffs/subscriptions","organizations_url":"https://api.github.com/users/begriffs/orgs","repos_url":"https://api.github.com/users/begriffs/repos","events_url":"https://api.github.com/users/begriffs/events{/privacy}","received_events_url":"https://api.github.com/users/begriffs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/begriffs/postgrest","description":"REST API for any Postgres database","fork":false,"url":"https://api.github.com/repos/begriffs/postgrest","forks_url":"https://api.github.com/repos/begriffs/postgrest/forks","keys_url":"https://api.github.com/repos/begriffs/postgrest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/begriffs/postgrest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/begriffs/postgrest/teams","hooks_url":"https://api.github.com/repos/begriffs/postgrest/hooks","issue_events_url":"https://api.github.com/repos/begriffs/postgrest/issues/events{/number}","events_url":"https://api.github.com/repos/begriffs/postgrest/events","assignees_url":"https://api.github.com/repos/begriffs/postgrest/assignees{/user}","branches_url":"https://api.github.com/repos/begriffs/postgrest/branches{/branch}","tags_url":"https://api.github.com/repos/begriffs/postgrest/tags","blobs_url":"https://api.github.com/repos/begriffs/postgrest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/begriffs/postgrest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/begriffs/postgrest/git/refs{/sha}","trees_url":"https://api.github.com/repos/begriffs/postgrest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/begriffs/postgrest/statuses/{sha}","languages_url":"https://api.github.com/repos/begriffs/postgrest/languages","stargazers_url":"https://api.github.com/repos/begriffs/postgrest/stargazers","contributors_url":"https://api.github.com/repos/begriffs/postgrest/contributors","subscribers_url":"https://api.github.com/repos/begriffs/postgrest/subscribers","subscription_url":"https://api.github.com/repos/begriffs/postgrest/subscription","commits_url":"https://api.github.com/repos/begriffs/postgrest/commits{/sha}","git_commits_url":"https://api.github.com/repos/begriffs/postgrest/git/commits{/sha}","comments_url":"https://api.github.com/repos/begriffs/postgrest/comments{/number}","issue_comment_url":"https://api.github.com/repos/begriffs/postgrest/issues/comments{/number}","contents_url":"https://api.github.com/repos/begriffs/postgrest/contents/{+path}","compare_url":"https://api.github.com/repos/begriffs/postgrest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/begriffs/postgrest/merges","archive_url":"https://api.github.com/repos/begriffs/postgrest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/begriffs/postgrest/downloads","issues_url":"https://api.github.com/repos/begriffs/postgrest/issues{/number}","pulls_url":"https://api.github.com/repos/begriffs/postgrest/pulls{/number}","milestones_url":"https://api.github.com/repos/begriffs/postgrest/milestones{/number}","notifications_url":"https://api.github.com/repos/begriffs/postgrest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/begriffs/postgrest/labels{/name}","releases_url":"https://api.github.com/repos/begriffs/postgrest/releases{/id}","created_at":"2014-06-13T00:23:00Z","updated_at":"2015-09-30T20:03:19Z","pushed_at":"2015-09-30T19:54:56Z","git_url":"git://github.com/begriffs/postgrest.git","ssh_url":"git@github.com:begriffs/postgrest.git","clone_url":"https://github.com/begriffs/postgrest.git","svn_url":"https://github.com/begriffs/postgrest","homepage":"","size":3498,"stargazers_count":5552,"watchers_count":5552,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":168,"mirror_url":null,"open_issues_count":81,"forks":168,"open_issues":81,"watchers":5552,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/begriffs/postgrest/pulls/298"},"html":{"href":"https://github.com/begriffs/postgrest/pull/298"},"issue":{"href":"https://api.github.com/repos/begriffs/postgrest/issues/298"},"comments":{"href":"https://api.github.com/repos/begriffs/postgrest/issues/298/comments"},"review_comments":{"href":"https://api.github.com/repos/begriffs/postgrest/pulls/298/comments"},"review_comment":{"href":"https://api.github.com/repos/begriffs/postgrest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/begriffs/postgrest/pulls/298/commits"},"statuses":{"href":"https://api.github.com/repos/begriffs/postgrest/statuses/6ea995efa3729e73d2214b9a62b63183c69ad258"}}}}