{"action":"created","issue":{"url":"https://api.github.com/repos/ClusterHQ/flocker/issues/1123","labels_url":"https://api.github.com/repos/ClusterHQ/flocker/issues/1123/labels{/name}","comments_url":"https://api.github.com/repos/ClusterHQ/flocker/issues/1123/comments","events_url":"https://api.github.com/repos/ClusterHQ/flocker/issues/1123/events","html_url":"https://github.com/ClusterHQ/flocker/pull/1123","id":56506717,"number":1123,"title":"[FLOC-1250] Custom 404 generated by Sphinx","user":{"login":"wallrj","id":978965,"avatar_url":"https://avatars.githubusercontent.com/u/978965?v=3","gravatar_id":"","url":"https://api.github.com/users/wallrj","html_url":"https://github.com/wallrj","followers_url":"https://api.github.com/users/wallrj/followers","following_url":"https://api.github.com/users/wallrj/following{/other_user}","gists_url":"https://api.github.com/users/wallrj/gists{/gist_id}","starred_url":"https://api.github.com/users/wallrj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallrj/subscriptions","organizations_url":"https://api.github.com/users/wallrj/orgs","repos_url":"https://api.github.com/users/wallrj/repos","events_url":"https://api.github.com/users/wallrj/events{/privacy}","received_events_url":"https://api.github.com/users/wallrj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-02-04T10:05:55Z","updated_at":"2015-04-09T08:37:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ClusterHQ/flocker/pulls/1123","html_url":"https://github.com/ClusterHQ/flocker/pull/1123","diff_url":"https://github.com/ClusterHQ/flocker/pull/1123.diff","patch_url":"https://github.com/ClusterHQ/flocker/pull/1123.patch"},"body":"Design for https://clusterhq.atlassian.net/browse/FLOC-1250\r\n\r\n * Thought it might be neat to generate the error page using sphinx to avoid duplicating the content in the template.\r\n * Only trouble is that the 404 may be served from anywhere in the URL hierarchy, so relative links in the template will not always work.\r\n * So I conditionally generate a `<base href` tag to set the actual URL of the 404 page.\r\n * Only trouble is that you have to specify an absolute base url, which means that the links on the 404 page will point to the current (old) docs.\r\n\r\nAlternative is to create a completely separate template where all the links are absolute or  \"root-relative\".\r\n\r\nOr update  the main template to generate absolute URLs.\r\n\r\nTo properly test this, I (or reviewer) need to upload the generated 404.html page to https://s3.amazonaws.com/clusterhq-staging-docs/404.html using gsutil.\r\n\r\nAlso note that the error page will be shown for all 40x errors so it may not make sense to call it `404.html`. Then again, it's possible that we could configure the custom error page using cloudfront, which does allow separate error pages for each error status code."},"comment":{"url":"https://api.github.com/repos/ClusterHQ/flocker/issues/comments/91151003","html_url":"https://github.com/ClusterHQ/flocker/pull/1123#issuecomment-91151003","issue_url":"https://api.github.com/repos/ClusterHQ/flocker/issues/1123","id":91151003,"user":{"login":"adamtheturtle","id":797801,"avatar_url":"https://avatars.githubusercontent.com/u/797801?v=3","gravatar_id":"","url":"https://api.github.com/users/adamtheturtle","html_url":"https://github.com/adamtheturtle","followers_url":"https://api.github.com/users/adamtheturtle/followers","following_url":"https://api.github.com/users/adamtheturtle/following{/other_user}","gists_url":"https://api.github.com/users/adamtheturtle/gists{/gist_id}","starred_url":"https://api.github.com/users/adamtheturtle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamtheturtle/subscriptions","organizations_url":"https://api.github.com/users/adamtheturtle/orgs","repos_url":"https://api.github.com/users/adamtheturtle/repos","events_url":"https://api.github.com/users/adamtheturtle/events{/privacy}","received_events_url":"https://api.github.com/users/adamtheturtle/received_events","type":"User","site_admin":false},"created_at":"2015-04-09T08:37:18Z","updated_at":"2015-04-09T08:37:18Z","body":"There is a TODO for this issue in docs/gettinginvolved/infrastructure/documentation.rst, so this PR should remove or update that."}}