{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/saucam/incubator-parquet-mr/pulls/1","id":27136403,"html_url":"https://github.com/saucam/incubator-parquet-mr/pull/1","diff_url":"https://github.com/saucam/incubator-parquet-mr/pull/1.diff","patch_url":"https://github.com/saucam/incubator-parquet-mr/pull/1.patch","issue_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/issues/1","number":1,"state":"closed","locked":false,"title":"Some updates for PARQUET 161 + 136","user":{"login":"isnotinvain","id":372969,"avatar_url":"https://avatars.githubusercontent.com/u/372969?v=3","gravatar_id":"","url":"https://api.github.com/users/isnotinvain","html_url":"https://github.com/isnotinvain","followers_url":"https://api.github.com/users/isnotinvain/followers","following_url":"https://api.github.com/users/isnotinvain/following{/other_user}","gists_url":"https://api.github.com/users/isnotinvain/gists{/gist_id}","starred_url":"https://api.github.com/users/isnotinvain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isnotinvain/subscriptions","organizations_url":"https://api.github.com/users/isnotinvain/orgs","repos_url":"https://api.github.com/users/isnotinvain/repos","events_url":"https://api.github.com/users/isnotinvain/events{/privacy}","received_events_url":"https://api.github.com/users/isnotinvain/received_events","type":"User","site_admin":false},"body":"How's this look?\r\n\r\nThis builds on top of your PR to fix the isEmpty() bug in the Statistics super class (no need to do it in the sub classes), this should fix the write path. Then it updates the stats filter to handle the corner cases (both the ones you added by checking isEmpty, plus in a few cases we need to nog inspect the min / max (which are going to be 0) if the column is all nulls.","created_at":"2015-01-09T23:04:47Z","updated_at":"2015-01-11T06:17:57Z","closed_at":"2015-01-11T06:17:57Z","merged_at":"2015-01-11T06:17:57Z","merge_commit_sha":"8ec69f001f681f7b5146d77ca6e09711e2e0827d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/pulls/1/commits","review_comments_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/pulls/1/comments","review_comment_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/pulls/comments/{number}","comments_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/issues/1/comments","statuses_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/statuses/b1001eb265842e18c8ec5761213d1c99114fe582","head":{"label":"isnotinvain:alexlevenson/PARQUET-161-136","ref":"alexlevenson/PARQUET-161-136","sha":"b1001eb265842e18c8ec5761213d1c99114fe582","user":{"login":"isnotinvain","id":372969,"avatar_url":"https://avatars.githubusercontent.com/u/372969?v=3","gravatar_id":"","url":"https://api.github.com/users/isnotinvain","html_url":"https://github.com/isnotinvain","followers_url":"https://api.github.com/users/isnotinvain/followers","following_url":"https://api.github.com/users/isnotinvain/following{/other_user}","gists_url":"https://api.github.com/users/isnotinvain/gists{/gist_id}","starred_url":"https://api.github.com/users/isnotinvain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isnotinvain/subscriptions","organizations_url":"https://api.github.com/users/isnotinvain/orgs","repos_url":"https://api.github.com/users/isnotinvain/repos","events_url":"https://api.github.com/users/isnotinvain/events{/privacy}","received_events_url":"https://api.github.com/users/isnotinvain/received_events","type":"User","site_admin":false},"repo":{"id":21011791,"name":"incubator-parquet-mr","full_name":"isnotinvain/incubator-parquet-mr","owner":{"login":"isnotinvain","id":372969,"avatar_url":"https://avatars.githubusercontent.com/u/372969?v=3","gravatar_id":"","url":"https://api.github.com/users/isnotinvain","html_url":"https://github.com/isnotinvain","followers_url":"https://api.github.com/users/isnotinvain/followers","following_url":"https://api.github.com/users/isnotinvain/following{/other_user}","gists_url":"https://api.github.com/users/isnotinvain/gists{/gist_id}","starred_url":"https://api.github.com/users/isnotinvain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isnotinvain/subscriptions","organizations_url":"https://api.github.com/users/isnotinvain/orgs","repos_url":"https://api.github.com/users/isnotinvain/repos","events_url":"https://api.github.com/users/isnotinvain/events{/privacy}","received_events_url":"https://api.github.com/users/isnotinvain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/isnotinvain/incubator-parquet-mr","description":"Mirror of Apache Parquet","fork":true,"url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr","forks_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/forks","keys_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/teams","hooks_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/hooks","issue_events_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/issues/events{/number}","events_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/events","assignees_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/assignees{/user}","branches_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/branches{/branch}","tags_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/tags","blobs_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/git/refs{/sha}","trees_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/statuses/{sha}","languages_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/languages","stargazers_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/stargazers","contributors_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/contributors","subscribers_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/subscribers","subscription_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/subscription","commits_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/commits{/sha}","git_commits_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/git/commits{/sha}","comments_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/comments{/number}","issue_comment_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/issues/comments/{number}","contents_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/contents/{+path}","compare_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/merges","archive_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/downloads","issues_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/issues{/number}","pulls_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/pulls{/number}","milestones_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/milestones{/number}","notifications_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/labels{/name}","releases_url":"https://api.github.com/repos/isnotinvain/incubator-parquet-mr/releases{/id}","created_at":"2014-06-19T18:55:45Z","updated_at":"2015-01-09T21:00:28Z","pushed_at":"2015-01-09T23:00:08Z","git_url":"git://github.com/isnotinvain/incubator-parquet-mr.git","ssh_url":"git@github.com:isnotinvain/incubator-parquet-mr.git","clone_url":"https://github.com/isnotinvain/incubator-parquet-mr.git","svn_url":"https://github.com/isnotinvain/incubator-parquet-mr","homepage":null,"size":12195,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"saucam:npe","ref":"npe","sha":"1ac919227395bf325fa6072afe992f70868061cf","user":{"login":"saucam","id":1253893,"avatar_url":"https://avatars.githubusercontent.com/u/1253893?v=3","gravatar_id":"","url":"https://api.github.com/users/saucam","html_url":"https://github.com/saucam","followers_url":"https://api.github.com/users/saucam/followers","following_url":"https://api.github.com/users/saucam/following{/other_user}","gists_url":"https://api.github.com/users/saucam/gists{/gist_id}","starred_url":"https://api.github.com/users/saucam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saucam/subscriptions","organizations_url":"https://api.github.com/users/saucam/orgs","repos_url":"https://api.github.com/users/saucam/repos","events_url":"https://api.github.com/users/saucam/events{/privacy}","received_events_url":"https://api.github.com/users/saucam/received_events","type":"User","site_admin":false},"repo":{"id":25388619,"name":"incubator-parquet-mr","full_name":"saucam/incubator-parquet-mr","owner":{"login":"saucam","id":1253893,"avatar_url":"https://avatars.githubusercontent.com/u/1253893?v=3","gravatar_id":"","url":"https://api.github.com/users/saucam","html_url":"https://github.com/saucam","followers_url":"https://api.github.com/users/saucam/followers","following_url":"https://api.github.com/users/saucam/following{/other_user}","gists_url":"https://api.github.com/users/saucam/gists{/gist_id}","starred_url":"https://api.github.com/users/saucam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saucam/subscriptions","organizations_url":"https://api.github.com/users/saucam/orgs","repos_url":"https://api.github.com/users/saucam/repos","events_url":"https://api.github.com/users/saucam/events{/privacy}","received_events_url":"https://api.github.com/users/saucam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saucam/incubator-parquet-mr","description":"Mirror of Apache Parquet","fork":true,"url":"https://api.github.com/repos/saucam/incubator-parquet-mr","forks_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/forks","keys_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/teams","hooks_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/hooks","issue_events_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/issues/events{/number}","events_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/events","assignees_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/assignees{/user}","branches_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/branches{/branch}","tags_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/tags","blobs_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/git/refs{/sha}","trees_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/statuses/{sha}","languages_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/languages","stargazers_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/stargazers","contributors_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/contributors","subscribers_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/subscribers","subscription_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/subscription","commits_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/commits{/sha}","git_commits_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/git/commits{/sha}","comments_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/comments{/number}","issue_comment_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/issues/comments/{number}","contents_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/contents/{+path}","compare_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/merges","archive_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/downloads","issues_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/issues{/number}","pulls_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/pulls{/number}","milestones_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/milestones{/number}","notifications_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/labels{/name}","releases_url":"https://api.github.com/repos/saucam/incubator-parquet-mr/releases{/id}","created_at":"2014-10-18T05:43:43Z","updated_at":"2014-10-18T07:12:25Z","pushed_at":"2015-01-11T06:17:57Z","git_url":"git://github.com/saucam/incubator-parquet-mr.git","ssh_url":"git@github.com:saucam/incubator-parquet-mr.git","clone_url":"https://github.com/saucam/incubator-parquet-mr.git","svn_url":"https://github.com/saucam/incubator-parquet-mr","homepage":null,"size":11690,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/saucam/incubator-parquet-mr/pulls/1"},"html":{"href":"https://github.com/saucam/incubator-parquet-mr/pull/1"},"issue":{"href":"https://api.github.com/repos/saucam/incubator-parquet-mr/issues/1"},"comments":{"href":"https://api.github.com/repos/saucam/incubator-parquet-mr/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/saucam/incubator-parquet-mr/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/saucam/incubator-parquet-mr/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/saucam/incubator-parquet-mr/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/saucam/incubator-parquet-mr/statuses/b1001eb265842e18c8ec5761213d1c99114fe582"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"saucam","id":1253893,"avatar_url":"https://avatars.githubusercontent.com/u/1253893?v=3","gravatar_id":"","url":"https://api.github.com/users/saucam","html_url":"https://github.com/saucam","followers_url":"https://api.github.com/users/saucam/followers","following_url":"https://api.github.com/users/saucam/following{/other_user}","gists_url":"https://api.github.com/users/saucam/gists{/gist_id}","starred_url":"https://api.github.com/users/saucam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saucam/subscriptions","organizations_url":"https://api.github.com/users/saucam/orgs","repos_url":"https://api.github.com/users/saucam/repos","events_url":"https://api.github.com/users/saucam/events{/privacy}","received_events_url":"https://api.github.com/users/saucam/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":43,"deletions":44,"changed_files":3}}