{"action":"created","issue":{"url":"https://api.github.com/repos/jjriv/emogrifier/issues/92","labels_url":"https://api.github.com/repos/jjriv/emogrifier/issues/92/labels{/name}","comments_url":"https://api.github.com/repos/jjriv/emogrifier/issues/92/comments","events_url":"https://api.github.com/repos/jjriv/emogrifier/issues/92/events","html_url":"https://github.com/jjriv/emogrifier/issues/92","id":35924692,"number":92,"title":"refactor of parseCssDeclarationBlock","user":{"login":"jdchmiel","id":2118572,"avatar_url":"https://avatars.githubusercontent.com/u/2118572?v=3","gravatar_id":"","url":"https://api.github.com/users/jdchmiel","html_url":"https://github.com/jdchmiel","followers_url":"https://api.github.com/users/jdchmiel/followers","following_url":"https://api.github.com/users/jdchmiel/following{/other_user}","gists_url":"https://api.github.com/users/jdchmiel/gists{/gist_id}","starred_url":"https://api.github.com/users/jdchmiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdchmiel/subscriptions","organizations_url":"https://api.github.com/users/jdchmiel/orgs","repos_url":"https://api.github.com/users/jdchmiel/repos","events_url":"https://api.github.com/users/jdchmiel/events{/privacy}","received_events_url":"https://api.github.com/users/jdchmiel/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jjriv/emogrifier/labels/waiting%20for%20feedback","name":"waiting for feedback","color":"207de5"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/jjriv/emogrifier/milestones/2","html_url":"https://github.com/jjriv/emogrifier/milestones/1.1.0","labels_url":"https://api.github.com/repos/jjriv/emogrifier/milestones/2/labels","id":1194397,"number":2,"title":"1.1.0","description":null,"creator":{"login":"oliverklee","id":765746,"avatar_url":"https://avatars.githubusercontent.com/u/765746?v=3","gravatar_id":"","url":"https://api.github.com/users/oliverklee","html_url":"https://github.com/oliverklee","followers_url":"https://api.github.com/users/oliverklee/followers","following_url":"https://api.github.com/users/oliverklee/following{/other_user}","gists_url":"https://api.github.com/users/oliverklee/gists{/gist_id}","starred_url":"https://api.github.com/users/oliverklee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliverklee/subscriptions","organizations_url":"https://api.github.com/users/oliverklee/orgs","repos_url":"https://api.github.com/users/oliverklee/repos","events_url":"https://api.github.com/users/oliverklee/events{/privacy}","received_events_url":"https://api.github.com/users/oliverklee/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":14,"state":"open","created_at":"2015-07-06T08:58:04Z","updated_at":"2015-10-12T09:26:57Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2014-06-17T19:49:45Z","updated_at":"2015-10-12T09:26:58Z","closed_at":"2015-10-12T09:26:57Z","body":"Creating this ticket per request  to not leave comments in the code:\r\n\r\nif (!preg_match('/ *([A-Za-z\\\\-]+) *: *([^;]+) */', $declaration, $matches)) {\r\n                 continue;\r\n}\r\n// can we remove this regex entirely and replace with an explode on :, and conditional on resulting array being 2 strings?\r\n\r\nIt seems like this regex is only verifying that we have a single css declaration, and then using the regex match for the propertyName and propertyValue.  I added the note because in the back of my head I thought an explode on the colon, and then verifying the resultant array has exactly 2 elements, and then using the 1st as propertyName and second as propertyValue would be quicker than a regex. \r\n"},"comment":{"url":"https://api.github.com/repos/jjriv/emogrifier/issues/comments/147346840","html_url":"https://github.com/jjriv/emogrifier/issues/92#issuecomment-147346840","issue_url":"https://api.github.com/repos/jjriv/emogrifier/issues/92","id":147346840,"user":{"login":"oliverklee","id":765746,"avatar_url":"https://avatars.githubusercontent.com/u/765746?v=3","gravatar_id":"","url":"https://api.github.com/users/oliverklee","html_url":"https://github.com/oliverklee","followers_url":"https://api.github.com/users/oliverklee/followers","following_url":"https://api.github.com/users/oliverklee/following{/other_user}","gists_url":"https://api.github.com/users/oliverklee/gists{/gist_id}","starred_url":"https://api.github.com/users/oliverklee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliverklee/subscriptions","organizations_url":"https://api.github.com/users/oliverklee/orgs","repos_url":"https://api.github.com/users/oliverklee/repos","events_url":"https://api.github.com/users/oliverklee/events{/privacy}","received_events_url":"https://api.github.com/users/oliverklee/received_events","type":"User","site_admin":false},"created_at":"2015-10-12T09:26:57Z","updated_at":"2015-10-12T09:26:57Z","body":"This will probably break the parsing (as mentioned in #251). Closing."}}