{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/presto/pulls/comments/28537235","id":28537235,"diff_hunk":"@@ -49,18 +48,19 @@ private ArrayGreaterThanOrEqualOperator()\n     @Override\n     public FunctionInfo specialize(Map<String, Type> types, int arity, TypeManager typeManager, FunctionRegistry functionRegistry)\n     {\n-        Type type = types.get(\"T\");\n-        type = typeManager.getParameterizedType(StandardTypes.ARRAY, ImmutableList.of(type.getTypeSignature()), ImmutableList.of());\n+        Type elementType = types.get(\"T\");\n+        Type type = typeManager.getParameterizedType(StandardTypes.ARRAY, ImmutableList.of(elementType.getTypeSignature()), ImmutableList.of());\n         TypeSignature typeSignature = type.getTypeSignature();\n-        return operatorInfo(GREATER_THAN_OR_EQUAL, RETURN_TYPE, ImmutableList.of(typeSignature, typeSignature), METHOD_HANDLE.bindTo(type), false, ImmutableList.of(false, false));\n+        MethodHandle lessThanFunction = functionRegistry.resolveOperator(LESS_THAN, ImmutableList.of(elementType, elementType)).getMethodHandle();","path":"presto-main/src/main/java/com/facebook/presto/operator/scalar/ArrayGreaterThanOrEqualOperator.java","position":37,"original_position":37,"commit_id":"db194c637ebd06d50f10aa4299dca0183c6b9235","original_commit_id":"db194c637ebd06d50f10aa4299dca0183c6b9235","user":{"login":"cberner","id":842688,"avatar_url":"https://avatars.githubusercontent.com/u/842688?v=3","gravatar_id":"","url":"https://api.github.com/users/cberner","html_url":"https://github.com/cberner","followers_url":"https://api.github.com/users/cberner/followers","following_url":"https://api.github.com/users/cberner/following{/other_user}","gists_url":"https://api.github.com/users/cberner/gists{/gist_id}","starred_url":"https://api.github.com/users/cberner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cberner/subscriptions","organizations_url":"https://api.github.com/users/cberner/orgs","repos_url":"https://api.github.com/users/cberner/repos","events_url":"https://api.github.com/users/cberner/events{/privacy}","received_events_url":"https://api.github.com/users/cberner/received_events","type":"User","site_admin":false},"body":"instead of using these two operators, lets use the LESS_THAN_OR_EQUAL/GREATER_THAN_OR_EQUAL","created_at":"2015-04-16T18:36:03Z","updated_at":"2015-04-16T18:36:03Z","html_url":"https://github.com/facebook/presto/pull/2625#discussion_r28537235","pull_request_url":"https://api.github.com/repos/facebook/presto/pulls/2625","_links":{"self":{"href":"https://api.github.com/repos/facebook/presto/pulls/comments/28537235"},"html":{"href":"https://github.com/facebook/presto/pull/2625#discussion_r28537235"},"pull_request":{"href":"https://api.github.com/repos/facebook/presto/pulls/2625"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/presto/pulls/2625","id":32379328,"html_url":"https://github.com/facebook/presto/pull/2625","diff_url":"https://github.com/facebook/presto/pull/2625.diff","patch_url":"https://github.com/facebook/presto/pull/2625.patch","issue_url":"https://api.github.com/repos/facebook/presto/issues/2625","number":2625,"state":"open","locked":false,"title":"Array comparison functions should use MethodHandle","user":{"login":"zhenxiao","id":1274155,"avatar_url":"https://avatars.githubusercontent.com/u/1274155?v=3","gravatar_id":"","url":"https://api.github.com/users/zhenxiao","html_url":"https://github.com/zhenxiao","followers_url":"https://api.github.com/users/zhenxiao/followers","following_url":"https://api.github.com/users/zhenxiao/following{/other_user}","gists_url":"https://api.github.com/users/zhenxiao/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenxiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenxiao/subscriptions","organizations_url":"https://api.github.com/users/zhenxiao/orgs","repos_url":"https://api.github.com/users/zhenxiao/repos","events_url":"https://api.github.com/users/zhenxiao/events{/privacy}","received_events_url":"https://api.github.com/users/zhenxiao/received_events","type":"User","site_admin":false},"body":"Fix https://github.com/facebook/presto/issues/2444 and https://github.com/facebook/presto/issues/2530","created_at":"2015-04-01T00:25:19Z","updated_at":"2015-04-16T18:36:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53240c4c8beb4bddaaabfc90c59d4d5a4acc10d7","assignee":{"login":"cberner","id":842688,"avatar_url":"https://avatars.githubusercontent.com/u/842688?v=3","gravatar_id":"","url":"https://api.github.com/users/cberner","html_url":"https://github.com/cberner","followers_url":"https://api.github.com/users/cberner/followers","following_url":"https://api.github.com/users/cberner/following{/other_user}","gists_url":"https://api.github.com/users/cberner/gists{/gist_id}","starred_url":"https://api.github.com/users/cberner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cberner/subscriptions","organizations_url":"https://api.github.com/users/cberner/orgs","repos_url":"https://api.github.com/users/cberner/repos","events_url":"https://api.github.com/users/cberner/events{/privacy}","received_events_url":"https://api.github.com/users/cberner/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/facebook/presto/pulls/2625/commits","review_comments_url":"https://api.github.com/repos/facebook/presto/pulls/2625/comments","review_comment_url":"https://api.github.com/repos/facebook/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/presto/issues/2625/comments","statuses_url":"https://api.github.com/repos/facebook/presto/statuses/db194c637ebd06d50f10aa4299dca0183c6b9235","head":{"label":"zhenxiao:arrayOp","ref":"arrayOp","sha":"db194c637ebd06d50f10aa4299dca0183c6b9235","user":{"login":"zhenxiao","id":1274155,"avatar_url":"https://avatars.githubusercontent.com/u/1274155?v=3","gravatar_id":"","url":"https://api.github.com/users/zhenxiao","html_url":"https://github.com/zhenxiao","followers_url":"https://api.github.com/users/zhenxiao/followers","following_url":"https://api.github.com/users/zhenxiao/following{/other_user}","gists_url":"https://api.github.com/users/zhenxiao/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenxiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenxiao/subscriptions","organizations_url":"https://api.github.com/users/zhenxiao/orgs","repos_url":"https://api.github.com/users/zhenxiao/repos","events_url":"https://api.github.com/users/zhenxiao/events{/privacy}","received_events_url":"https://api.github.com/users/zhenxiao/received_events","type":"User","site_admin":false},"repo":{"id":17963913,"name":"presto","full_name":"zhenxiao/presto","owner":{"login":"zhenxiao","id":1274155,"avatar_url":"https://avatars.githubusercontent.com/u/1274155?v=3","gravatar_id":"","url":"https://api.github.com/users/zhenxiao","html_url":"https://github.com/zhenxiao","followers_url":"https://api.github.com/users/zhenxiao/followers","following_url":"https://api.github.com/users/zhenxiao/following{/other_user}","gists_url":"https://api.github.com/users/zhenxiao/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenxiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenxiao/subscriptions","organizations_url":"https://api.github.com/users/zhenxiao/orgs","repos_url":"https://api.github.com/users/zhenxiao/repos","events_url":"https://api.github.com/users/zhenxiao/events{/privacy}","received_events_url":"https://api.github.com/users/zhenxiao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zhenxiao/presto","description":"Distributed SQL query engine for big data","fork":true,"url":"https://api.github.com/repos/zhenxiao/presto","forks_url":"https://api.github.com/repos/zhenxiao/presto/forks","keys_url":"https://api.github.com/repos/zhenxiao/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhenxiao/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhenxiao/presto/teams","hooks_url":"https://api.github.com/repos/zhenxiao/presto/hooks","issue_events_url":"https://api.github.com/repos/zhenxiao/presto/issues/events{/number}","events_url":"https://api.github.com/repos/zhenxiao/presto/events","assignees_url":"https://api.github.com/repos/zhenxiao/presto/assignees{/user}","branches_url":"https://api.github.com/repos/zhenxiao/presto/branches{/branch}","tags_url":"https://api.github.com/repos/zhenxiao/presto/tags","blobs_url":"https://api.github.com/repos/zhenxiao/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhenxiao/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhenxiao/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhenxiao/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhenxiao/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/zhenxiao/presto/languages","stargazers_url":"https://api.github.com/repos/zhenxiao/presto/stargazers","contributors_url":"https://api.github.com/repos/zhenxiao/presto/contributors","subscribers_url":"https://api.github.com/repos/zhenxiao/presto/subscribers","subscription_url":"https://api.github.com/repos/zhenxiao/presto/subscription","commits_url":"https://api.github.com/repos/zhenxiao/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhenxiao/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhenxiao/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhenxiao/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhenxiao/presto/contents/{+path}","compare_url":"https://api.github.com/repos/zhenxiao/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhenxiao/presto/merges","archive_url":"https://api.github.com/repos/zhenxiao/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhenxiao/presto/downloads","issues_url":"https://api.github.com/repos/zhenxiao/presto/issues{/number}","pulls_url":"https://api.github.com/repos/zhenxiao/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/zhenxiao/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/zhenxiao/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhenxiao/presto/labels{/name}","releases_url":"https://api.github.com/repos/zhenxiao/presto/releases{/id}","created_at":"2014-03-21T01:03:42Z","updated_at":"2015-03-09T20:15:09Z","pushed_at":"2015-04-16T17:41:58Z","git_url":"git://github.com/zhenxiao/presto.git","ssh_url":"git@github.com:zhenxiao/presto.git","clone_url":"https://github.com/zhenxiao/presto.git","svn_url":"https://github.com/zhenxiao/presto","homepage":"http://prestodb.io/","size":36561,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"a204cc6e5f02a11438c0fc399f4c9a12f7888ea5","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"name":"presto","full_name":"facebook/presto","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/presto","description":"Distributed SQL query engine for running interactive analytic queries against big data sources.","fork":false,"url":"https://api.github.com/repos/facebook/presto","forks_url":"https://api.github.com/repos/facebook/presto/forks","keys_url":"https://api.github.com/repos/facebook/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/presto/teams","hooks_url":"https://api.github.com/repos/facebook/presto/hooks","issue_events_url":"https://api.github.com/repos/facebook/presto/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/presto/events","assignees_url":"https://api.github.com/repos/facebook/presto/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/presto/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/presto/tags","blobs_url":"https://api.github.com/repos/facebook/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/presto/languages","stargazers_url":"https://api.github.com/repos/facebook/presto/stargazers","contributors_url":"https://api.github.com/repos/facebook/presto/contributors","subscribers_url":"https://api.github.com/repos/facebook/presto/subscribers","subscription_url":"https://api.github.com/repos/facebook/presto/subscription","commits_url":"https://api.github.com/repos/facebook/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/presto/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/presto/merges","archive_url":"https://api.github.com/repos/facebook/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/presto/downloads","issues_url":"https://api.github.com/repos/facebook/presto/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/presto/labels{/name}","releases_url":"https://api.github.com/repos/facebook/presto/releases{/id}","created_at":"2012-08-09T01:03:37Z","updated_at":"2015-04-16T18:18:14Z","pushed_at":"2015-04-16T18:18:14Z","git_url":"git://github.com/facebook/presto.git","ssh_url":"git@github.com:facebook/presto.git","clone_url":"https://github.com/facebook/presto.git","svn_url":"https://github.com/facebook/presto","homepage":"https://prestodb.io","size":81576,"stargazers_count":3341,"watchers_count":3341,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":761,"mirror_url":null,"open_issues_count":321,"forks":761,"open_issues":321,"watchers":3341,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/presto/pulls/2625"},"html":{"href":"https://github.com/facebook/presto/pull/2625"},"issue":{"href":"https://api.github.com/repos/facebook/presto/issues/2625"},"comments":{"href":"https://api.github.com/repos/facebook/presto/issues/2625/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/presto/pulls/2625/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/presto/pulls/2625/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/presto/statuses/db194c637ebd06d50f10aa4299dca0183c6b9235"}}}}