{"action":"created","issue":{"url":"https://api.github.com/repos/jackschaedler/circles-sines-signals/issues/15","labels_url":"https://api.github.com/repos/jackschaedler/circles-sines-signals/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/jackschaedler/circles-sines-signals/issues/15/comments","events_url":"https://api.github.com/repos/jackschaedler/circles-sines-signals/issues/15/events","html_url":"https://github.com/jackschaedler/circles-sines-signals/issues/15","id":69036967,"number":15,"title":"Suggested change to frequency resolution","user":{"login":"mgold","id":1191970,"avatar_url":"https://avatars.githubusercontent.com/u/1191970?v=3","gravatar_id":"","url":"https://api.github.com/users/mgold","html_url":"https://github.com/mgold","followers_url":"https://api.github.com/users/mgold/followers","following_url":"https://api.github.com/users/mgold/following{/other_user}","gists_url":"https://api.github.com/users/mgold/gists{/gist_id}","starred_url":"https://api.github.com/users/mgold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgold/subscriptions","organizations_url":"https://api.github.com/users/mgold/orgs","repos_url":"https://api.github.com/users/mgold/repos","events_url":"https://api.github.com/users/mgold/events{/privacy}","received_events_url":"https://api.github.com/users/mgold/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-04-17T00:32:50Z","updated_at":"2015-04-19T11:47:49Z","closed_at":null,"body":"I'm referring to [this page](http://jackschaedler.github.io/circles-sines-signals/dft_frequency.html), figure 3, which seems to be working as intended but I found to be misleading.\r\n\r\nAt first I thought the samples better approximated an underlying analog curve. But it soon dawned on my that the horizontal time scale is not constant, and the curve compresses in from the right. This is because the sampling frequency is fixed and the time domain increases.\r\n\r\nI think a more honest visualization is to show the underlying curve with sample points placed only on the left side. More points are added left to right as the slider is moved. Conceptually, equal horizontal spacing corresponds to the constant sampling rate.\r\n\r\nThis is unsolicited advice that you are free to take or leave as you like. I can also try implementing it myself if you assure me you'll merge it."},"comment":{"url":"https://api.github.com/repos/jackschaedler/circles-sines-signals/issues/comments/94269557","html_url":"https://github.com/jackschaedler/circles-sines-signals/issues/15#issuecomment-94269557","issue_url":"https://api.github.com/repos/jackschaedler/circles-sines-signals/issues/15","id":94269557,"user":{"login":"jackschaedler","id":365491,"avatar_url":"https://avatars.githubusercontent.com/u/365491?v=3","gravatar_id":"","url":"https://api.github.com/users/jackschaedler","html_url":"https://github.com/jackschaedler","followers_url":"https://api.github.com/users/jackschaedler/followers","following_url":"https://api.github.com/users/jackschaedler/following{/other_user}","gists_url":"https://api.github.com/users/jackschaedler/gists{/gist_id}","starred_url":"https://api.github.com/users/jackschaedler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackschaedler/subscriptions","organizations_url":"https://api.github.com/users/jackschaedler/orgs","repos_url":"https://api.github.com/users/jackschaedler/repos","events_url":"https://api.github.com/users/jackschaedler/events{/privacy}","received_events_url":"https://api.github.com/users/jackschaedler/received_events","type":"User","site_admin":false},"created_at":"2015-04-19T11:47:49Z","updated_at":"2015-04-19T11:47:49Z","body":"Thanks Max,\r\n\r\nI appreciate it! Your visualization of Melkman's algorithm is really nicely done. And it's nice to see your work on the explorable explanations wiki."}}