{"action":"created","issue":{"url":"https://api.github.com/repos/adobe/brackets/issues/11150","labels_url":"https://api.github.com/repos/adobe/brackets/issues/11150/labels{/name}","comments_url":"https://api.github.com/repos/adobe/brackets/issues/11150/comments","events_url":"https://api.github.com/repos/adobe/brackets/issues/11150/events","html_url":"https://github.com/adobe/brackets/pull/11150","id":79119085,"number":11150,"title":"Rename CodeMirror2 folder to CodeMirror","user":{"login":"MarcelGerber","id":2641501,"avatar_url":"https://avatars.githubusercontent.com/u/2641501?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcelGerber","html_url":"https://github.com/MarcelGerber","followers_url":"https://api.github.com/users/MarcelGerber/followers","following_url":"https://api.github.com/users/MarcelGerber/following{/other_user}","gists_url":"https://api.github.com/users/MarcelGerber/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcelGerber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcelGerber/subscriptions","organizations_url":"https://api.github.com/users/MarcelGerber/orgs","repos_url":"https://api.github.com/users/MarcelGerber/repos","events_url":"https://api.github.com/users/MarcelGerber/events{/privacy}","received_events_url":"https://api.github.com/users/MarcelGerber/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-05-21T18:52:20Z","updated_at":"2015-05-23T21:25:28Z","closed_at":"2015-05-23T09:14:20Z","pull_request":{"url":"https://api.github.com/repos/adobe/brackets/pulls/11150","html_url":"https://github.com/adobe/brackets/pull/11150","diff_url":"https://github.com/adobe/brackets/pull/11150.diff","patch_url":"https://github.com/adobe/brackets/pull/11150.patch"},"body":"Now that we use CodeMirror 5, it's a little misleading our submodule is still called `CodeMirror2`. Thus, in this PR, I've renamed it to `CodeMirror`.\r\n\r\nThere are some things to keep in mind, though:\r\n* While most extensions will still work through our require mapping, other ways to access `CodeMirror2` (FileSystem, node) __won't work__. Look out for those.\r\n* We probably cannot utilize deprecation warnings.\r\n\r\n\r\n* [ ] See if any extension accesses `CodeMirror2` through anything else than a `require` (FileSystem, node, ...)\r\n* [ ] See if we can fire deprecation warnings\r\n* [ ] See if it makes sense to rename our [adobe/CodeMirror2](/adobe/CodeMirror2) repo as well"},"comment":{"url":"https://api.github.com/repos/adobe/brackets/issues/comments/104945609","html_url":"https://github.com/adobe/brackets/pull/11150#issuecomment-104945609","issue_url":"https://api.github.com/repos/adobe/brackets/issues/11150","id":104945609,"user":{"login":"abose","id":5336369,"avatar_url":"https://avatars.githubusercontent.com/u/5336369?v=3","gravatar_id":"","url":"https://api.github.com/users/abose","html_url":"https://github.com/abose","followers_url":"https://api.github.com/users/abose/followers","following_url":"https://api.github.com/users/abose/following{/other_user}","gists_url":"https://api.github.com/users/abose/gists{/gist_id}","starred_url":"https://api.github.com/users/abose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abose/subscriptions","organizations_url":"https://api.github.com/users/abose/orgs","repos_url":"https://api.github.com/users/abose/repos","events_url":"https://api.github.com/users/abose/events{/privacy}","received_events_url":"https://api.github.com/users/abose/received_events","type":"User","site_admin":false},"created_at":"2015-05-23T21:25:28Z","updated_at":"2015-05-23T21:25:28Z","body":"Thanks Marcel, i'll run a search for the usage of `codeMirror2` on the source codes in the extension registry just in case and update. If the extension usage is proper, there would be nothing to worry about this going in the release :hamster: "}}