{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-reef/issues/237","labels_url":"https://api.github.com/repos/apache/incubator-reef/issues/237/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-reef/issues/237/comments","events_url":"https://api.github.com/repos/apache/incubator-reef/issues/237/events","html_url":"https://github.com/apache/incubator-reef/pull/237","id":90147152,"number":237,"title":"[REEF-395] Implement ClassHierarchySerializer using Avro on the Java side","user":{"login":"yunseong","id":1748276,"avatar_url":"https://avatars.githubusercontent.com/u/1748276?v=3","gravatar_id":"","url":"https://api.github.com/users/yunseong","html_url":"https://github.com/yunseong","followers_url":"https://api.github.com/users/yunseong/followers","following_url":"https://api.github.com/users/yunseong/following{/other_user}","gists_url":"https://api.github.com/users/yunseong/gists{/gist_id}","starred_url":"https://api.github.com/users/yunseong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yunseong/subscriptions","organizations_url":"https://api.github.com/users/yunseong/orgs","repos_url":"https://api.github.com/users/yunseong/repos","events_url":"https://api.github.com/users/yunseong/events{/privacy}","received_events_url":"https://api.github.com/users/yunseong/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-06-22T16:31:48Z","updated_at":"2015-06-23T15:34:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/incubator-reef/pulls/237","html_url":"https://github.com/apache/incubator-reef/pull/237","diff_url":"https://github.com/apache/incubator-reef/pull/237.diff","patch_url":"https://github.com/apache/incubator-reef/pull/237.patch"},"body":"This addressed the issue by\r\n  * Defining the avro schema for class hierarchy\r\n  * Implementing the AvroClassHierarchy\r\n  * Define ClassHierarchySerializer interface and implement an Avro version\r\n  * Replace the class hierarchy serializer for the round trip tests\r\n  * Leave TODO comments for the future issues to resolve when we revisit REEF-148\r\n  * Mark the `ProtocolBufferClassHierarchy` class as deprecated\r\n\r\np.s.\r\nThere was an additional change for the types in Avro. By default, Avro uses `CharSequence` for the string field: In the Java code, we should convert the types between `String` and `CharSequence` all the time. I could change the configuration to use `String` for the string field in the `pom.xml`. There was only one class (`org/apache/reef/io/network/naming/serialization/NamingLookupRequestCodec.java`) that is affected by this change and the conflict was resolved by changing only one type."},"comment":{"url":"https://api.github.com/repos/apache/incubator-reef/issues/comments/114547797","html_url":"https://github.com/apache/incubator-reef/pull/237#issuecomment-114547797","issue_url":"https://api.github.com/repos/apache/incubator-reef/issues/237","id":114547797,"user":{"login":"asfbot","id":5243949,"avatar_url":"https://avatars.githubusercontent.com/u/5243949?v=3","gravatar_id":"","url":"https://api.github.com/users/asfbot","html_url":"https://github.com/asfbot","followers_url":"https://api.github.com/users/asfbot/followers","following_url":"https://api.github.com/users/asfbot/following{/other_user}","gists_url":"https://api.github.com/users/asfbot/gists{/gist_id}","starred_url":"https://api.github.com/users/asfbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asfbot/subscriptions","organizations_url":"https://api.github.com/users/asfbot/orgs","repos_url":"https://api.github.com/users/asfbot/repos","events_url":"https://api.github.com/users/asfbot/events{/privacy}","received_events_url":"https://api.github.com/users/asfbot/received_events","type":"User","site_admin":false},"created_at":"2015-06-23T15:34:40Z","updated_at":"2015-06-23T15:34:40Z","body":"[Reef-pull-request-ubuntu #581](https://builds.apache.org/job/Reef-pull-request-ubuntu/581/) SUCCESS\nThis pull request looks good"}}