{"action":"created","comment":{"url":"https://api.github.com/repos/Theano/Theano/pulls/comments/25018870","id":25018870,"diff_hunk":"@@ -63,6 +63,7 @@ def __init__(self,\n         # adding properties into self\n         self.inputs = inputs\n         self.outputs = outputs\n+        self.output_is_input = [out in inputs for out in outputs]","path":"theano/scan_module/scan_op.py","position":4,"original_position":4,"commit_id":"cc4717d9479a23684efff17abe3cd8f1b9867354","original_commit_id":"cc4717d9479a23684efff17abe3cd8f1b9867354","user":{"login":"nouiz","id":180987,"avatar_url":"https://avatars.githubusercontent.com/u/180987?v=3","gravatar_id":"","url":"https://api.github.com/users/nouiz","html_url":"https://github.com/nouiz","followers_url":"https://api.github.com/users/nouiz/followers","following_url":"https://api.github.com/users/nouiz/following{/other_user}","gists_url":"https://api.github.com/users/nouiz/gists{/gist_id}","starred_url":"https://api.github.com/users/nouiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nouiz/subscriptions","organizations_url":"https://api.github.com/users/nouiz/orgs","repos_url":"https://api.github.com/users/nouiz/repos","events_url":"https://api.github.com/users/nouiz/events{/privacy}","received_events_url":"https://api.github.com/users/nouiz/received_events","type":"User","site_admin":false},"body":"I think this isn't the complete fix.\r\n\r\nI think I understand more the problems. Around line 910-932, we put in the input_storage some value that come from outs. It happen in the test case from test_borrow_bug_jeremiah, that this data set in input_storage is also set in output_storage. So we override the input. If this work or not depend on the order of the node in the graph and in that case, the order is random. So we are lucky that it make this test fail !\r\n\r\nI think we must analyze more when we put in the input_storage something from outs and more sure that we do not put in the output_storage what is currently in the input_storage or will be in the intput_storage at a later step. We could in theory allow some input_storage to point to the same data as the output_storage in some case. But 1) I think it is hard to do right and 2) I think it won't be used frequently. So I think we do not need to optimize now this case.\r\n\r\n@carriepl, I let you look more in detail on that and try to find the additional condition we need to do.","created_at":"2015-02-19T19:50:39Z","updated_at":"2015-02-19T19:50:39Z","html_url":"https://github.com/Theano/Theano/pull/2479#discussion_r25018870","pull_request_url":"https://api.github.com/repos/Theano/Theano/pulls/2479","_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments/25018870"},"html":{"href":"https://github.com/Theano/Theano/pull/2479#discussion_r25018870"},"pull_request":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2479"}}},"pull_request":{"url":"https://api.github.com/repos/Theano/Theano/pulls/2479","id":28812421,"html_url":"https://github.com/Theano/Theano/pull/2479","diff_url":"https://github.com/Theano/Theano/pull/2479.diff","patch_url":"https://github.com/Theano/Theano/pull/2479.patch","issue_url":"https://api.github.com/repos/Theano/Theano/issues/2479","number":2479,"state":"open","locked":false,"title":"Feature for no outputs from inplace.","user":{"login":"carriepl","id":832811,"avatar_url":"https://avatars.githubusercontent.com/u/832811?v=3","gravatar_id":"","url":"https://api.github.com/users/carriepl","html_url":"https://github.com/carriepl","followers_url":"https://api.github.com/users/carriepl/followers","following_url":"https://api.github.com/users/carriepl/following{/other_user}","gists_url":"https://api.github.com/users/carriepl/gists{/gist_id}","starred_url":"https://api.github.com/users/carriepl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carriepl/subscriptions","organizations_url":"https://api.github.com/users/carriepl/orgs","repos_url":"https://api.github.com/users/carriepl/repos","events_url":"https://api.github.com/users/carriepl/events{/privacy}","received_events_url":"https://api.github.com/users/carriepl/received_events","type":"User","site_admin":false},"body":"Add Feature (and optimization to add it to a fgraph) to prevent computing outputs via inplace operations","created_at":"2015-02-06T14:34:36Z","updated_at":"2015-02-19T19:50:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9cec83b96648ad4a0f1910accb25734d91847187","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Theano/Theano/pulls/2479/commits","review_comments_url":"https://api.github.com/repos/Theano/Theano/pulls/2479/comments","review_comment_url":"https://api.github.com/repos/Theano/Theano/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Theano/Theano/issues/2479/comments","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/cc4717d9479a23684efff17abe3cd8f1b9867354","head":{"label":"carriepl:prevent_output_from_inplace","ref":"prevent_output_from_inplace","sha":"cc4717d9479a23684efff17abe3cd8f1b9867354","user":{"login":"carriepl","id":832811,"avatar_url":"https://avatars.githubusercontent.com/u/832811?v=3","gravatar_id":"","url":"https://api.github.com/users/carriepl","html_url":"https://github.com/carriepl","followers_url":"https://api.github.com/users/carriepl/followers","following_url":"https://api.github.com/users/carriepl/following{/other_user}","gists_url":"https://api.github.com/users/carriepl/gists{/gist_id}","starred_url":"https://api.github.com/users/carriepl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carriepl/subscriptions","organizations_url":"https://api.github.com/users/carriepl/orgs","repos_url":"https://api.github.com/users/carriepl/repos","events_url":"https://api.github.com/users/carriepl/events{/privacy}","received_events_url":"https://api.github.com/users/carriepl/received_events","type":"User","site_admin":false},"repo":{"id":18150468,"name":"Theano","full_name":"carriepl/Theano","owner":{"login":"carriepl","id":832811,"avatar_url":"https://avatars.githubusercontent.com/u/832811?v=3","gravatar_id":"","url":"https://api.github.com/users/carriepl","html_url":"https://github.com/carriepl","followers_url":"https://api.github.com/users/carriepl/followers","following_url":"https://api.github.com/users/carriepl/following{/other_user}","gists_url":"https://api.github.com/users/carriepl/gists{/gist_id}","starred_url":"https://api.github.com/users/carriepl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carriepl/subscriptions","organizations_url":"https://api.github.com/users/carriepl/orgs","repos_url":"https://api.github.com/users/carriepl/repos","events_url":"https://api.github.com/users/carriepl/events{/privacy}","received_events_url":"https://api.github.com/users/carriepl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/carriepl/Theano","description":"Optimizing GPU-meta-programming code generating array oriented optimizing math compiler in Python","fork":true,"url":"https://api.github.com/repos/carriepl/Theano","forks_url":"https://api.github.com/repos/carriepl/Theano/forks","keys_url":"https://api.github.com/repos/carriepl/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carriepl/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carriepl/Theano/teams","hooks_url":"https://api.github.com/repos/carriepl/Theano/hooks","issue_events_url":"https://api.github.com/repos/carriepl/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/carriepl/Theano/events","assignees_url":"https://api.github.com/repos/carriepl/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/carriepl/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/carriepl/Theano/tags","blobs_url":"https://api.github.com/repos/carriepl/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carriepl/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carriepl/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/carriepl/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carriepl/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/carriepl/Theano/languages","stargazers_url":"https://api.github.com/repos/carriepl/Theano/stargazers","contributors_url":"https://api.github.com/repos/carriepl/Theano/contributors","subscribers_url":"https://api.github.com/repos/carriepl/Theano/subscribers","subscription_url":"https://api.github.com/repos/carriepl/Theano/subscription","commits_url":"https://api.github.com/repos/carriepl/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/carriepl/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/carriepl/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/carriepl/Theano/issues/comments/{number}","contents_url":"https://api.github.com/repos/carriepl/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/carriepl/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carriepl/Theano/merges","archive_url":"https://api.github.com/repos/carriepl/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carriepl/Theano/downloads","issues_url":"https://api.github.com/repos/carriepl/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/carriepl/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/carriepl/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/carriepl/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carriepl/Theano/labels{/name}","releases_url":"https://api.github.com/repos/carriepl/Theano/releases{/id}","created_at":"2014-03-26T19:13:49Z","updated_at":"2014-09-10T14:19:14Z","pushed_at":"2015-02-19T14:05:54Z","git_url":"git://github.com/carriepl/Theano.git","ssh_url":"git@github.com:carriepl/Theano.git","clone_url":"https://github.com/carriepl/Theano.git","svn_url":"https://github.com/carriepl/Theano","homepage":"http://www.deeplearning.net/software/theano","size":25684,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Theano:master","ref":"master","sha":"0ebdb42f5ba18ebcaf68a060d8e8db892b041bb6","user":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"repo":{"id":2183193,"name":"Theano","full_name":"Theano/Theano","owner":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Theano/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":false,"url":"https://api.github.com/repos/Theano/Theano","forks_url":"https://api.github.com/repos/Theano/Theano/forks","keys_url":"https://api.github.com/repos/Theano/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Theano/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Theano/Theano/teams","hooks_url":"https://api.github.com/repos/Theano/Theano/hooks","issue_events_url":"https://api.github.com/repos/Theano/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/Theano/Theano/events","assignees_url":"https://api.github.com/repos/Theano/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/Theano/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/Theano/Theano/tags","blobs_url":"https://api.github.com/repos/Theano/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Theano/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Theano/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/Theano/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/Theano/Theano/languages","stargazers_url":"https://api.github.com/repos/Theano/Theano/stargazers","contributors_url":"https://api.github.com/repos/Theano/Theano/contributors","subscribers_url":"https://api.github.com/repos/Theano/Theano/subscribers","subscription_url":"https://api.github.com/repos/Theano/Theano/subscription","commits_url":"https://api.github.com/repos/Theano/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/Theano/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/Theano/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/Theano/Theano/issues/comments/{number}","contents_url":"https://api.github.com/repos/Theano/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/Theano/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Theano/Theano/merges","archive_url":"https://api.github.com/repos/Theano/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Theano/Theano/downloads","issues_url":"https://api.github.com/repos/Theano/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/Theano/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/Theano/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/Theano/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Theano/Theano/labels{/name}","releases_url":"https://api.github.com/repos/Theano/Theano/releases{/id}","created_at":"2011-08-10T03:48:06Z","updated_at":"2015-02-19T18:44:01Z","pushed_at":"2015-02-19T18:43:58Z","git_url":"git://github.com/Theano/Theano.git","ssh_url":"git@github.com:Theano/Theano.git","clone_url":"https://github.com/Theano/Theano.git","svn_url":"https://github.com/Theano/Theano","homepage":"http://www.deeplearning.net/software/theano","size":38633,"stargazers_count":1159,"watchers_count":1159,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":433,"mirror_url":null,"open_issues_count":318,"forks":433,"open_issues":318,"watchers":1159,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2479"},"html":{"href":"https://github.com/Theano/Theano/pull/2479"},"issue":{"href":"https://api.github.com/repos/Theano/Theano/issues/2479"},"comments":{"href":"https://api.github.com/repos/Theano/Theano/issues/2479/comments"},"review_comments":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2479/comments"},"review_comment":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2479/commits"},"statuses":{"href":"https://api.github.com/repos/Theano/Theano/statuses/cc4717d9479a23684efff17abe3cd8f1b9867354"}}}}