{"action":"created","issue":{"url":"https://api.github.com/repos/piwik/piwik/issues/8015","labels_url":"https://api.github.com/repos/piwik/piwik/issues/8015/labels{/name}","comments_url":"https://api.github.com/repos/piwik/piwik/issues/8015/comments","events_url":"https://api.github.com/repos/piwik/piwik/issues/8015/events","html_url":"https://github.com/piwik/piwik/pull/8015","id":81933393,"number":8015,"title":"Regression test for themes","user":{"login":"mnapoli","id":720328,"avatar_url":"https://avatars.githubusercontent.com/u/720328?v=3","gravatar_id":"","url":"https://api.github.com/users/mnapoli","html_url":"https://github.com/mnapoli","followers_url":"https://api.github.com/users/mnapoli/followers","following_url":"https://api.github.com/users/mnapoli/following{/other_user}","gists_url":"https://api.github.com/users/mnapoli/gists{/gist_id}","starred_url":"https://api.github.com/users/mnapoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnapoli/subscriptions","organizations_url":"https://api.github.com/users/mnapoli/orgs","repos_url":"https://api.github.com/users/mnapoli/repos","events_url":"https://api.github.com/users/mnapoli/events{/privacy}","received_events_url":"https://api.github.com/users/mnapoli/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/piwik/piwik/labels/c:%20Tests%20&%20QA","name":"c: Tests & QA","color":"bfdadc"},{"url":"https://api.github.com/repos/piwik/piwik/labels/Needs%20Review","name":"Needs Review","color":"fad8c7"},{"url":"https://api.github.com/repos/piwik/piwik/labels/not-in-changelog","name":"not-in-changelog","color":"ffffff"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/piwik/piwik/milestones/79","html_url":"https://github.com/piwik/piwik/milestones/2.14.0","labels_url":"https://api.github.com/repos/piwik/piwik/milestones/79/labels","id":1005076,"number":79,"title":"2.14.0","description":"","creator":{"login":"mattab","id":466765,"avatar_url":"https://avatars.githubusercontent.com/u/466765?v=3","gravatar_id":"","url":"https://api.github.com/users/mattab","html_url":"https://github.com/mattab","followers_url":"https://api.github.com/users/mattab/followers","following_url":"https://api.github.com/users/mattab/following{/other_user}","gists_url":"https://api.github.com/users/mattab/gists{/gist_id}","starred_url":"https://api.github.com/users/mattab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattab/subscriptions","organizations_url":"https://api.github.com/users/mattab/orgs","repos_url":"https://api.github.com/users/mattab/repos","events_url":"https://api.github.com/users/mattab/events{/privacy}","received_events_url":"https://api.github.com/users/mattab/received_events","type":"User","site_admin":false},"open_issues":51,"closed_issues":91,"state":"open","created_at":"2015-03-04T03:03:44Z","updated_at":"2015-06-01T04:52:55Z","due_on":"2015-06-02T12:00:00Z","closed_at":null},"comments":9,"created_at":"2015-05-28T13:46:38Z","updated_at":"2015-06-01T09:34:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/piwik/piwik/pulls/8015","html_url":"https://github.com/piwik/piwik/pull/8015","diff_url":"https://github.com/piwik/piwik/pull/8015.diff","patch_url":"https://github.com/piwik/piwik/pull/8015.patch"},"body":"Themes were broken because of new code now affected by this existing bug: leafo/lessphp#302. I bumped to v0.5.0 and checked the changelog, it was one of the 2 only significant change. The only other significant change is that syntax errors in Less now throw an exception (which allowed to fix a few existing bugs in our Less files). I think it's good to have (definitely help in when developing, I know I've raged a lot against mixins like `.box-shadow()` that weren't doing working without any explanation), however it might break plugins that have errors in their less files. Do we consider that a problem or a very small risk (for example we only had 2 Less bugs in our whole codebase)?\r\n\r\nI added a UI test that checks that themes work so that we avoid any regression in the future.\r\n\r\nEdit: FYI I removed the `.box-shadow` mixins for the following reasons:\r\n\r\n> They are useless since box-shadow is supported in all browsers except IE 8 (in which using a prefix doesn't help anyway)."},"comment":{"url":"https://api.github.com/repos/piwik/piwik/issues/comments/107380870","html_url":"https://github.com/piwik/piwik/pull/8015#issuecomment-107380870","issue_url":"https://api.github.com/repos/piwik/piwik/issues/8015","id":107380870,"user":{"login":"mnapoli","id":720328,"avatar_url":"https://avatars.githubusercontent.com/u/720328?v=3","gravatar_id":"","url":"https://api.github.com/users/mnapoli","html_url":"https://github.com/mnapoli","followers_url":"https://api.github.com/users/mnapoli/followers","following_url":"https://api.github.com/users/mnapoli/following{/other_user}","gists_url":"https://api.github.com/users/mnapoli/gists{/gist_id}","starred_url":"https://api.github.com/users/mnapoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnapoli/subscriptions","organizations_url":"https://api.github.com/users/mnapoli/orgs","repos_url":"https://api.github.com/users/mnapoli/repos","events_url":"https://api.github.com/users/mnapoli/events{/privacy}","received_events_url":"https://api.github.com/users/mnapoli/received_events","type":"User","site_admin":false},"created_at":"2015-06-01T09:34:38Z","updated_at":"2015-06-01T09:34:38Z","body":"Shadows and tests are fixed, this PR introduces no visual change: http://builds-artifacts.piwik.org/ui-tests.fixing-themes/12946.7/screenshot-diffs/diffviewer.html\r\n\r\nReady for review and merge."}}