{"action":"created","comment":{"url":"https://api.github.com/repos/divmain/interlock/pulls/comments/34758365","id":34758365,"diff_hunk":"@@ -0,0 +1,96 @@\n+import most from \"most\";\n+import escodegen from \"escodegen\";\n+\n+import applyPlugins from \"./apply-plugins\";\n+import construct from \"./construct\";\n+import compileModules from \"./modules/compile\";\n+import bootstrapBundles from \"./bundles/bootstrap\";\n+import hashBundle from \"./bundles/hash\";\n+import interpolateFilename from \"./bundles/interpolate-filename\";\n+import dedupeExplicit from \"./bundles/dedupe-explicit\";\n+import dedupeImplicit from \"./bundles/dedupe-implicit\";\n+\n+export default function compile (opts, compilation) {\n+  compilation = compilation || {\n+    cache: {\n+      modulesByAbsPath: Object.create(null)\n+    },\n+    applyPlugins: (ev, ...args) => applyPlugins(opts.plugins, ev, ...args),","path":"lib/compile/index.js","position":18,"original_position":18,"commit_id":"57f5e79c4fc3174607303b33fed2a5266c59c0bd","original_commit_id":"57f5e79c4fc3174607303b33fed2a5266c59c0bd","user":{"login":"divmain","id":5016978,"avatar_url":"https://avatars.githubusercontent.com/u/5016978?v=3","gravatar_id":"","url":"https://api.github.com/users/divmain","html_url":"https://github.com/divmain","followers_url":"https://api.github.com/users/divmain/followers","following_url":"https://api.github.com/users/divmain/following{/other_user}","gists_url":"https://api.github.com/users/divmain/gists{/gist_id}","starred_url":"https://api.github.com/users/divmain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divmain/subscriptions","organizations_url":"https://api.github.com/users/divmain/orgs","repos_url":"https://api.github.com/users/divmain/repos","events_url":"https://api.github.com/users/divmain/events{/privacy}","received_events_url":"https://api.github.com/users/divmain/received_events","type":"User","site_admin":false},"body":"I share most of your objections to the plugin architecture, and this is one of the things I want to completely rethink.  To answer this question, tho, `applyPlugins` was only intended to be used internally.","created_at":"2015-07-16T06:13:40Z","updated_at":"2015-07-16T06:13:40Z","html_url":"https://github.com/divmain/interlock/pull/4#discussion_r34758365","pull_request_url":"https://api.github.com/repos/divmain/interlock/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/divmain/interlock/pulls/comments/34758365"},"html":{"href":"https://github.com/divmain/interlock/pull/4#discussion_r34758365"},"pull_request":{"href":"https://api.github.com/repos/divmain/interlock/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/divmain/interlock/pulls/4","id":40081709,"html_url":"https://github.com/divmain/interlock/pull/4","diff_url":"https://github.com/divmain/interlock/pull/4.diff","patch_url":"https://github.com/divmain/interlock/pull/4.patch","issue_url":"https://api.github.com/repos/divmain/interlock/issues/4","number":4,"state":"open","locked":false,"title":"Solicit feedback; running commentary","user":{"login":"divmain","id":5016978,"avatar_url":"https://avatars.githubusercontent.com/u/5016978?v=3","gravatar_id":"","url":"https://api.github.com/users/divmain","html_url":"https://github.com/divmain","followers_url":"https://api.github.com/users/divmain/followers","following_url":"https://api.github.com/users/divmain/following{/other_user}","gists_url":"https://api.github.com/users/divmain/gists{/gist_id}","starred_url":"https://api.github.com/users/divmain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divmain/subscriptions","organizations_url":"https://api.github.com/users/divmain/orgs","repos_url":"https://api.github.com/users/divmain/repos","events_url":"https://api.github.com/users/divmain/events{/privacy}","received_events_url":"https://api.github.com/users/divmain/received_events","type":"User","site_admin":false},"body":"This won't be merged, but is intended as a place to solicit feedback on the current state of the codebase.","created_at":"2015-07-15T23:43:19Z","updated_at":"2015-07-16T06:13:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54b646880690c0a737215208618463923e17127f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/divmain/interlock/pulls/4/commits","review_comments_url":"https://api.github.com/repos/divmain/interlock/pulls/4/comments","review_comment_url":"https://api.github.com/repos/divmain/interlock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/divmain/interlock/issues/4/comments","statuses_url":"https://api.github.com/repos/divmain/interlock/statuses/57f5e79c4fc3174607303b33fed2a5266c59c0bd","head":{"label":"divmain:master","ref":"master","sha":"57f5e79c4fc3174607303b33fed2a5266c59c0bd","user":{"login":"divmain","id":5016978,"avatar_url":"https://avatars.githubusercontent.com/u/5016978?v=3","gravatar_id":"","url":"https://api.github.com/users/divmain","html_url":"https://github.com/divmain","followers_url":"https://api.github.com/users/divmain/followers","following_url":"https://api.github.com/users/divmain/following{/other_user}","gists_url":"https://api.github.com/users/divmain/gists{/gist_id}","starred_url":"https://api.github.com/users/divmain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divmain/subscriptions","organizations_url":"https://api.github.com/users/divmain/orgs","repos_url":"https://api.github.com/users/divmain/repos","events_url":"https://api.github.com/users/divmain/events{/privacy}","received_events_url":"https://api.github.com/users/divmain/received_events","type":"User","site_admin":false},"repo":{"id":35057998,"name":"interlock","full_name":"divmain/interlock","owner":{"login":"divmain","id":5016978,"avatar_url":"https://avatars.githubusercontent.com/u/5016978?v=3","gravatar_id":"","url":"https://api.github.com/users/divmain","html_url":"https://github.com/divmain","followers_url":"https://api.github.com/users/divmain/followers","following_url":"https://api.github.com/users/divmain/following{/other_user}","gists_url":"https://api.github.com/users/divmain/gists{/gist_id}","starred_url":"https://api.github.com/users/divmain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divmain/subscriptions","organizations_url":"https://api.github.com/users/divmain/orgs","repos_url":"https://api.github.com/users/divmain/repos","events_url":"https://api.github.com/users/divmain/events{/privacy}","received_events_url":"https://api.github.com/users/divmain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/divmain/interlock","description":"Git-inspired JS bundler/loader.","fork":false,"url":"https://api.github.com/repos/divmain/interlock","forks_url":"https://api.github.com/repos/divmain/interlock/forks","keys_url":"https://api.github.com/repos/divmain/interlock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/divmain/interlock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/divmain/interlock/teams","hooks_url":"https://api.github.com/repos/divmain/interlock/hooks","issue_events_url":"https://api.github.com/repos/divmain/interlock/issues/events{/number}","events_url":"https://api.github.com/repos/divmain/interlock/events","assignees_url":"https://api.github.com/repos/divmain/interlock/assignees{/user}","branches_url":"https://api.github.com/repos/divmain/interlock/branches{/branch}","tags_url":"https://api.github.com/repos/divmain/interlock/tags","blobs_url":"https://api.github.com/repos/divmain/interlock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/divmain/interlock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/divmain/interlock/git/refs{/sha}","trees_url":"https://api.github.com/repos/divmain/interlock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/divmain/interlock/statuses/{sha}","languages_url":"https://api.github.com/repos/divmain/interlock/languages","stargazers_url":"https://api.github.com/repos/divmain/interlock/stargazers","contributors_url":"https://api.github.com/repos/divmain/interlock/contributors","subscribers_url":"https://api.github.com/repos/divmain/interlock/subscribers","subscription_url":"https://api.github.com/repos/divmain/interlock/subscription","commits_url":"https://api.github.com/repos/divmain/interlock/commits{/sha}","git_commits_url":"https://api.github.com/repos/divmain/interlock/git/commits{/sha}","comments_url":"https://api.github.com/repos/divmain/interlock/comments{/number}","issue_comment_url":"https://api.github.com/repos/divmain/interlock/issues/comments{/number}","contents_url":"https://api.github.com/repos/divmain/interlock/contents/{+path}","compare_url":"https://api.github.com/repos/divmain/interlock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/divmain/interlock/merges","archive_url":"https://api.github.com/repos/divmain/interlock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/divmain/interlock/downloads","issues_url":"https://api.github.com/repos/divmain/interlock/issues{/number}","pulls_url":"https://api.github.com/repos/divmain/interlock/pulls{/number}","milestones_url":"https://api.github.com/repos/divmain/interlock/milestones{/number}","notifications_url":"https://api.github.com/repos/divmain/interlock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/divmain/interlock/labels{/name}","releases_url":"https://api.github.com/repos/divmain/interlock/releases{/id}","created_at":"2015-05-04T20:33:50Z","updated_at":"2015-07-14T20:47:19Z","pushed_at":"2015-07-15T23:43:19Z","git_url":"git://github.com/divmain/interlock.git","ssh_url":"git@github.com:divmain/interlock.git","clone_url":"https://github.com/divmain/interlock.git","svn_url":"https://github.com/divmain/interlock","homepage":"","size":301,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"divmain:initial","ref":"initial","sha":"086d7abeb6c4511a72c7be855197de8cc5d31299","user":{"login":"divmain","id":5016978,"avatar_url":"https://avatars.githubusercontent.com/u/5016978?v=3","gravatar_id":"","url":"https://api.github.com/users/divmain","html_url":"https://github.com/divmain","followers_url":"https://api.github.com/users/divmain/followers","following_url":"https://api.github.com/users/divmain/following{/other_user}","gists_url":"https://api.github.com/users/divmain/gists{/gist_id}","starred_url":"https://api.github.com/users/divmain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divmain/subscriptions","organizations_url":"https://api.github.com/users/divmain/orgs","repos_url":"https://api.github.com/users/divmain/repos","events_url":"https://api.github.com/users/divmain/events{/privacy}","received_events_url":"https://api.github.com/users/divmain/received_events","type":"User","site_admin":false},"repo":{"id":35057998,"name":"interlock","full_name":"divmain/interlock","owner":{"login":"divmain","id":5016978,"avatar_url":"https://avatars.githubusercontent.com/u/5016978?v=3","gravatar_id":"","url":"https://api.github.com/users/divmain","html_url":"https://github.com/divmain","followers_url":"https://api.github.com/users/divmain/followers","following_url":"https://api.github.com/users/divmain/following{/other_user}","gists_url":"https://api.github.com/users/divmain/gists{/gist_id}","starred_url":"https://api.github.com/users/divmain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divmain/subscriptions","organizations_url":"https://api.github.com/users/divmain/orgs","repos_url":"https://api.github.com/users/divmain/repos","events_url":"https://api.github.com/users/divmain/events{/privacy}","received_events_url":"https://api.github.com/users/divmain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/divmain/interlock","description":"Git-inspired JS bundler/loader.","fork":false,"url":"https://api.github.com/repos/divmain/interlock","forks_url":"https://api.github.com/repos/divmain/interlock/forks","keys_url":"https://api.github.com/repos/divmain/interlock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/divmain/interlock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/divmain/interlock/teams","hooks_url":"https://api.github.com/repos/divmain/interlock/hooks","issue_events_url":"https://api.github.com/repos/divmain/interlock/issues/events{/number}","events_url":"https://api.github.com/repos/divmain/interlock/events","assignees_url":"https://api.github.com/repos/divmain/interlock/assignees{/user}","branches_url":"https://api.github.com/repos/divmain/interlock/branches{/branch}","tags_url":"https://api.github.com/repos/divmain/interlock/tags","blobs_url":"https://api.github.com/repos/divmain/interlock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/divmain/interlock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/divmain/interlock/git/refs{/sha}","trees_url":"https://api.github.com/repos/divmain/interlock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/divmain/interlock/statuses/{sha}","languages_url":"https://api.github.com/repos/divmain/interlock/languages","stargazers_url":"https://api.github.com/repos/divmain/interlock/stargazers","contributors_url":"https://api.github.com/repos/divmain/interlock/contributors","subscribers_url":"https://api.github.com/repos/divmain/interlock/subscribers","subscription_url":"https://api.github.com/repos/divmain/interlock/subscription","commits_url":"https://api.github.com/repos/divmain/interlock/commits{/sha}","git_commits_url":"https://api.github.com/repos/divmain/interlock/git/commits{/sha}","comments_url":"https://api.github.com/repos/divmain/interlock/comments{/number}","issue_comment_url":"https://api.github.com/repos/divmain/interlock/issues/comments{/number}","contents_url":"https://api.github.com/repos/divmain/interlock/contents/{+path}","compare_url":"https://api.github.com/repos/divmain/interlock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/divmain/interlock/merges","archive_url":"https://api.github.com/repos/divmain/interlock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/divmain/interlock/downloads","issues_url":"https://api.github.com/repos/divmain/interlock/issues{/number}","pulls_url":"https://api.github.com/repos/divmain/interlock/pulls{/number}","milestones_url":"https://api.github.com/repos/divmain/interlock/milestones{/number}","notifications_url":"https://api.github.com/repos/divmain/interlock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/divmain/interlock/labels{/name}","releases_url":"https://api.github.com/repos/divmain/interlock/releases{/id}","created_at":"2015-05-04T20:33:50Z","updated_at":"2015-07-14T20:47:19Z","pushed_at":"2015-07-15T23:43:19Z","git_url":"git://github.com/divmain/interlock.git","ssh_url":"git@github.com:divmain/interlock.git","clone_url":"https://github.com/divmain/interlock.git","svn_url":"https://github.com/divmain/interlock","homepage":"","size":301,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/divmain/interlock/pulls/4"},"html":{"href":"https://github.com/divmain/interlock/pull/4"},"issue":{"href":"https://api.github.com/repos/divmain/interlock/issues/4"},"comments":{"href":"https://api.github.com/repos/divmain/interlock/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/divmain/interlock/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/divmain/interlock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/divmain/interlock/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/divmain/interlock/statuses/57f5e79c4fc3174607303b33fed2a5266c59c0bd"}}}}