{"action":"created","issue":{"url":"https://api.github.com/repos/pusher/pusher-http-php/issues/68","labels_url":"https://api.github.com/repos/pusher/pusher-http-php/issues/68/labels{/name}","comments_url":"https://api.github.com/repos/pusher/pusher-http-php/issues/68/comments","events_url":"https://api.github.com/repos/pusher/pusher-http-php/issues/68/events","html_url":"https://github.com/pusher/pusher-http-php/issues/68","id":100533335,"number":68,"title":"Add logging to 3.0 to at least the same level as 2.0","user":{"login":"leggetter","id":328367,"avatar_url":"https://avatars.githubusercontent.com/u/328367?v=3","gravatar_id":"","url":"https://api.github.com/users/leggetter","html_url":"https://github.com/leggetter","followers_url":"https://api.github.com/users/leggetter/followers","following_url":"https://api.github.com/users/leggetter/following{/other_user}","gists_url":"https://api.github.com/users/leggetter/gists{/gist_id}","starred_url":"https://api.github.com/users/leggetter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leggetter/subscriptions","organizations_url":"https://api.github.com/users/leggetter/orgs","repos_url":"https://api.github.com/users/leggetter/repos","events_url":"https://api.github.com/users/leggetter/events{/privacy}","received_events_url":"https://api.github.com/users/leggetter/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/pusher/pusher-http-php/milestones/1","html_url":"https://github.com/pusher/pusher-http-php/milestones/3.0.0%20release","labels_url":"https://api.github.com/repos/pusher/pusher-http-php/milestones/1/labels","id":1250697,"number":1,"title":"3.0.0 release","description":"The 3.0 release represents a re-write of the Pusher PHP library adhering to modern PHP standards.","creator":{"login":"leggetter","id":328367,"avatar_url":"https://avatars.githubusercontent.com/u/328367?v=3","gravatar_id":"","url":"https://api.github.com/users/leggetter","html_url":"https://github.com/leggetter","followers_url":"https://api.github.com/users/leggetter/followers","following_url":"https://api.github.com/users/leggetter/following{/other_user}","gists_url":"https://api.github.com/users/leggetter/gists{/gist_id}","starred_url":"https://api.github.com/users/leggetter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leggetter/subscriptions","organizations_url":"https://api.github.com/users/leggetter/orgs","repos_url":"https://api.github.com/users/leggetter/repos","events_url":"https://api.github.com/users/leggetter/events{/privacy}","received_events_url":"https://api.github.com/users/leggetter/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":0,"state":"open","created_at":"2015-08-11T20:56:46Z","updated_at":"2015-08-12T12:36:58Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2015-08-12T12:36:57Z","updated_at":"2015-08-12T22:23:27Z","closed_at":null,"body":"Logging has been essential in debugging interactions with the Pusher HTTP API. The 2.0 logging isn't perfect, but it is *really useful*. So we need the at least the same level of logging in 3.0.\r\n\r\nThe preference would be to be able to set a logger as an option when creating the `Pusher` instance. The logger would implement to https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-3-logger-interface.md"},"comment":{"url":"https://api.github.com/repos/pusher/pusher-http-php/issues/comments/130465146","html_url":"https://github.com/pusher/pusher-http-php/issues/68#issuecomment-130465146","issue_url":"https://api.github.com/repos/pusher/pusher-http-php/issues/68","id":130465146,"user":{"login":"leggetter","id":328367,"avatar_url":"https://avatars.githubusercontent.com/u/328367?v=3","gravatar_id":"","url":"https://api.github.com/users/leggetter","html_url":"https://github.com/leggetter","followers_url":"https://api.github.com/users/leggetter/followers","following_url":"https://api.github.com/users/leggetter/following{/other_user}","gists_url":"https://api.github.com/users/leggetter/gists{/gist_id}","starred_url":"https://api.github.com/users/leggetter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leggetter/subscriptions","organizations_url":"https://api.github.com/users/leggetter/orgs","repos_url":"https://api.github.com/users/leggetter/repos","events_url":"https://api.github.com/users/leggetter/events{/privacy}","received_events_url":"https://api.github.com/users/leggetter/received_events","type":"User","site_admin":false},"created_at":"2015-08-12T22:23:27Z","updated_at":"2015-08-12T22:23:27Z","body":"I'd suggest we ditch the `setLogger` for this library and instead make it:\r\n\r\n```php\r\n$pusher = new Pusher($appId, $appKey, $appSecret, array('logger' => $PSR3CompliantLogger));\r\n```\r\n\r\nor something similar depending on what's decided for #66.\r\n\r\nBy default there's maybe some kind of null logger implementation and a developer can pass in their own implementation to the constructor.\r\n\r\nHow's that sound?"}}