{"action":"closed","issue":{"url":"https://api.github.com/repos/FreeUKGen/MyopicVicar/issues/266","labels_url":"https://api.github.com/repos/FreeUKGen/MyopicVicar/issues/266/labels{/name}","comments_url":"https://api.github.com/repos/FreeUKGen/MyopicVicar/issues/266/comments","events_url":"https://api.github.com/repos/FreeUKGen/MyopicVicar/issues/266/events","html_url":"https://github.com/FreeUKGen/MyopicVicar/issues/266","id":48091369,"number":266,"title":"Link database code to front-end design repositories","user":{"login":"benwbrum","id":199961,"avatar_url":"https://avatars.githubusercontent.com/u/199961?v=3","gravatar_id":"","url":"https://api.github.com/users/benwbrum","html_url":"https://github.com/benwbrum","followers_url":"https://api.github.com/users/benwbrum/followers","following_url":"https://api.github.com/users/benwbrum/following{/other_user}","gists_url":"https://api.github.com/users/benwbrum/gists{/gist_id}","starred_url":"https://api.github.com/users/benwbrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benwbrum/subscriptions","organizations_url":"https://api.github.com/users/benwbrum/orgs","repos_url":"https://api.github.com/users/benwbrum/repos","events_url":"https://api.github.com/users/benwbrum/events{/privacy}","received_events_url":"https://api.github.com/users/benwbrum/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/FreeUKGen/MyopicVicar/labels/Actor:%20technician","name":"Actor: technician","color":"006b75"},{"url":"https://api.github.com/repos/FreeUKGen/MyopicVicar/labels/enhancement","name":"enhancement","color":"009800"}],"state":"closed","locked":false,"assignee":{"login":"dougkdev","id":13754318,"avatar_url":"https://avatars.githubusercontent.com/u/13754318?v=3","gravatar_id":"","url":"https://api.github.com/users/dougkdev","html_url":"https://github.com/dougkdev","followers_url":"https://api.github.com/users/dougkdev/followers","following_url":"https://api.github.com/users/dougkdev/following{/other_user}","gists_url":"https://api.github.com/users/dougkdev/gists{/gist_id}","starred_url":"https://api.github.com/users/dougkdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dougkdev/subscriptions","organizations_url":"https://api.github.com/users/dougkdev/orgs","repos_url":"https://api.github.com/users/dougkdev/repos","events_url":"https://api.github.com/users/dougkdev/events{/privacy}","received_events_url":"https://api.github.com/users/dougkdev/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/FreeUKGen/MyopicVicar/milestones/4","html_url":"https://github.com/FreeUKGen/MyopicVicar/milestones/Version%201.3%20Initial%20Release","labels_url":"https://api.github.com/repos/FreeUKGen/MyopicVicar/milestones/4/labels","id":913381,"number":4,"title":"Version 1.3 Initial Release","description":"Targeted actors:  transcribers","creator":{"login":"Captainkirkdawson","id":2874694,"avatar_url":"https://avatars.githubusercontent.com/u/2874694?v=3","gravatar_id":"","url":"https://api.github.com/users/Captainkirkdawson","html_url":"https://github.com/Captainkirkdawson","followers_url":"https://api.github.com/users/Captainkirkdawson/followers","following_url":"https://api.github.com/users/Captainkirkdawson/following{/other_user}","gists_url":"https://api.github.com/users/Captainkirkdawson/gists{/gist_id}","starred_url":"https://api.github.com/users/Captainkirkdawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Captainkirkdawson/subscriptions","organizations_url":"https://api.github.com/users/Captainkirkdawson/orgs","repos_url":"https://api.github.com/users/Captainkirkdawson/repos","events_url":"https://api.github.com/users/Captainkirkdawson/events{/privacy}","received_events_url":"https://api.github.com/users/Captainkirkdawson/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":24,"state":"open","created_at":"2014-12-23T15:38:47Z","updated_at":"2015-09-10T18:43:55Z","due_on":"2015-06-26T06:00:00Z","closed_at":null},"comments":7,"created_at":"2014-11-07T15:10:25Z","updated_at":"2015-09-10T18:43:55Z","closed_at":"2015-09-10T18:43:55Z","body":"At present, @Captainkirkdawson and I are manually copying assets like logos, images, javascript snippets and stylesheets from the repository created by @joshangell et al. into the MyopicVicar codebase.  There are much less error-prone ways to do this, and Josh has been working towards a more modular, automated approach.\r\n\r\nAt the moment, Kirk and I still need to come up to speed on front-end work, but once we've got our heads around things, we should switch the framework over to a Bower-based solution.  \r\n\r\nSee chat log below\r\n```\r\nJosh:\r\nRight - one of the things I wanted to check with you is the framework we've made for all future FreeUKGen projects\r\nI'm pretty sure its not compulsory by any means but we thought it a good idea to consolidate all the resources that were the same across the two projects we know about - the one you're working on and the free uk gen website\r\nTo that end I created a Core repo that projects can inherit from using Bower.\r\nbower.io\r\nI have made an up-dated project for you guys using this new core framework and set up the project specific resources in there as well\r\n\r\nBen: \r\nOkay.\r\nHow does this sound for a strategy:\r\nAt the moment, Kirk and I are still getting our feet wet on front-end work.  Copying compiled assets into our project specific repo is about all we can handle.   However,\r\nI'd like to create a tech debt story for us to switch over to multi-repo inheritance and really using Bower once we've got enough clue, front-end-wise.\r\nThen we'd pick up the assets from the core repo, the project-specific repo\r\nand we'd probably not point to local copies of assets within our source code, but rather use bower/grunt/etc to pull them in (presumably upon deployment)\r\nDoes that sound like an approach that might get us where we need to be?\r\n\r\nJosh:\r\nyes - that is exactly what I was shooting for\r\n\r\nBen:\r\nOK.\r\nIt definitely won't be before November 20.\r\nBut possibly the following sprint.\r\n\r\nJosh:\r\nIt could happen on deployment but it would probably be safer to manage the updates on a per project basis - it would just be quicker with bower etc\r\nAnyway - I see your point and will just hold those for now\r\n\r\nBen:\r\nSo if I understand you,\r\nLet's say an asset in the common repo changes (Free UK Genealogy changes their logo)\r\nThen we'd run something in bower to pull that into our source, check it in, and deploy that?\r\n\r\nJosh:\r\nYes - exactly\r\n\r\nBen:\r\nSo the copies would still be local, but the copying would be an output of a build process, rather than manual drag-and-drop by me or Kirk?\r\n\r\nJosh:\r\nYes - I have set it up so bower only pulls in source files, then grunt (build tool) compiles those and any local ones into one big blob\r\nEffectively.\r\nThe reason you wouldn't want to do it all on deploy is because you'd want to verify that the core changes hadn't messed with any of your local css / markup\r\n\r\nBen:\r\nAhh.  Right.\r\n\r\nJosh:\r\nSo, in our scenario of building the new free uk gen site:\r\ncore contains css/images/svgs\r\nour project pulls all that in, compiles it with our local stuff some of which overrides (hardly any actually) and a lot of which is extra js/css\r\nthat way we get the all the fonts, logos, colour variables etc without having multiple places where they are defined\r\nAnyway - at present all this is sat on our github but it would be better from our perspective if it was sat on yours\r\n\r\nBen:\r\nI'm very happy to add you to the github org, if you'd like to transfer the repos to FreeUKGen\r\nI can do that right now, actually.\r\n\r\nJosh:\r\nAh lovely thanks - then I'll write some readmes and you can peruse at your leisure\r\nI have also been a bit over zealous and created a 'project template' repo - just to get you started with integrating the core into anything else\r\n```"}}