{"action":"created","issue":{"url":"https://api.github.com/repos/kgaughan/dbkit/issues/22","labels_url":"https://api.github.com/repos/kgaughan/dbkit/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/kgaughan/dbkit/issues/22/comments","events_url":"https://api.github.com/repos/kgaughan/dbkit/issues/22/events","html_url":"https://github.com/kgaughan/dbkit/issues/22","id":112320254,"number":22,"title":"Python3 support","user":{"login":"justinfay","id":933069,"avatar_url":"https://avatars.githubusercontent.com/u/933069?v=3","gravatar_id":"","url":"https://api.github.com/users/justinfay","html_url":"https://github.com/justinfay","followers_url":"https://api.github.com/users/justinfay/followers","following_url":"https://api.github.com/users/justinfay/following{/other_user}","gists_url":"https://api.github.com/users/justinfay/gists{/gist_id}","starred_url":"https://api.github.com/users/justinfay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinfay/subscriptions","organizations_url":"https://api.github.com/users/justinfay/orgs","repos_url":"https://api.github.com/users/justinfay/repos","events_url":"https://api.github.com/users/justinfay/events{/privacy}","received_events_url":"https://api.github.com/users/justinfay/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-20T09:08:23Z","updated_at":"2015-12-01T09:32:24Z","closed_at":"2015-11-30T18:19:29Z","body":"dbkit should work with Python 3. The pypi version will not even install in a python 3 enviromnent, the current github HEAD will.\r\n\r\nSome quick and dirty patching of dbkit.py and the test cases got them all passing under Python3.4. The main changes being how exceptions are caught, using `io` module instead of `StringIO`, replacing `StandardError` with `Exception` and changing the `print` statements.\r\n\r\n```\r\ntests.test_dbkit.test_good_connect ... ok\r\ntests.test_dbkit.test_bad_connect ... ok\r\ntests.test_dbkit.test_context ... ok\r\ntests.test_dbkit.test_create_table ... ok\r\ntests.test_dbkit.test_bad_drop_table ... ok\r\ntests.test_dbkit.test_transaction ... ok\r\ntests.test_dbkit.test_transaction_decorator ... ok\r\ntests.test_dbkit.test_factory ... ok\r\ntests.test_dbkit.test_unpooled_disconnect ... ok\r\ntests.test_dbkit.test_make_file_object_logger ... ok\r\ntests.test_dbkit.test_logging ... ok\r\ntests.test_dbkit.test_procs ... ok\r\ntests.test_dbkit.test_to_dict_nothing ... ok\r\ntests.test_dbkit.test_to_dict_bad_key ... ok\r\ntests.test_dbkit.test_to_dict_happy_path ... ok\r\ntests.test_dbkit.test_to_dict_sequence ... ok\r\ntests.test_dbkit.test_make_placeholders ... ok\r\ntests.test_pool.test_check_pool ... ok\r\ntests.test_pool.test_lazy_connect ... ok\r\ntests.test_pool.test_real_connect ... ok\r\ntests.test_pool.test_bad_query ... ok\r\ntests.test_pool.test_pool_contention ... ok\r\ntests.test_pool.test_setting_propagation ... ok\r\n\r\n----------------------------------------------------------------------\r\nRan 23 tests in 0.041s\r\n``` \r\n\r\nCurrently 308 of the 360 most popular libraries support Python 3 [py3readiness](http://py3readiness.org/) there is nor reason why dbkit shouldn't.\r\n\r\nIf Python3 support is desired I can clean up my patch so it works with both 2 and 3 and submit a PR."},"comment":{"url":"https://api.github.com/repos/kgaughan/dbkit/issues/comments/160908353","html_url":"https://github.com/kgaughan/dbkit/issues/22#issuecomment-160908353","issue_url":"https://api.github.com/repos/kgaughan/dbkit/issues/22","id":160908353,"user":{"login":"justinfay","id":933069,"avatar_url":"https://avatars.githubusercontent.com/u/933069?v=3","gravatar_id":"","url":"https://api.github.com/users/justinfay","html_url":"https://github.com/justinfay","followers_url":"https://api.github.com/users/justinfay/followers","following_url":"https://api.github.com/users/justinfay/following{/other_user}","gists_url":"https://api.github.com/users/justinfay/gists{/gist_id}","starred_url":"https://api.github.com/users/justinfay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinfay/subscriptions","organizations_url":"https://api.github.com/users/justinfay/orgs","repos_url":"https://api.github.com/users/justinfay/repos","events_url":"https://api.github.com/users/justinfay/events{/privacy}","received_events_url":"https://api.github.com/users/justinfay/received_events","type":"User","site_admin":false},"created_at":"2015-12-01T09:32:23Z","updated_at":"2015-12-01T09:32:23Z","body":"Thanks @kgaughan "}}