{"action":"created","issue":{"url":"https://api.github.com/repos/aphyr/riemann-java-client/issues/48","labels_url":"https://api.github.com/repos/aphyr/riemann-java-client/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/aphyr/riemann-java-client/issues/48/comments","events_url":"https://api.github.com/repos/aphyr/riemann-java-client/issues/48/events","html_url":"https://github.com/aphyr/riemann-java-client/issues/48","id":54595829,"number":48,"title":"TcpTransport `writeTimeout` appears to be ignored","user":{"login":"benfleis","id":2185001,"avatar_url":"https://avatars.githubusercontent.com/u/2185001?v=3","gravatar_id":"","url":"https://api.github.com/users/benfleis","html_url":"https://github.com/benfleis","followers_url":"https://api.github.com/users/benfleis/followers","following_url":"https://api.github.com/users/benfleis/following{/other_user}","gists_url":"https://api.github.com/users/benfleis/gists{/gist_id}","starred_url":"https://api.github.com/users/benfleis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benfleis/subscriptions","organizations_url":"https://api.github.com/users/benfleis/orgs","repos_url":"https://api.github.com/users/benfleis/repos","events_url":"https://api.github.com/users/benfleis/events{/privacy}","received_events_url":"https://api.github.com/users/benfleis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-01-16T16:38:17Z","updated_at":"2015-01-20T19:30:35Z","closed_at":null,"body":"Both from my own testing, and from looking through the code, it appears the the `writeTimeout` AtomicBoolean is ignored.  It looks like it should be ferried through to bootstrap, and then possibly have some exception handling added to make it do the right thing.  (I dunno, I've never used netty myself.)  In any case, I see in deployment cases where it takes multiple minutes for the socket to recognize that it's dead (seeing TCP PUSH over and over); if the default of 5s was effective, this slow stream failure detection would be avoided by the high level timeout."},"comment":{"url":"https://api.github.com/repos/aphyr/riemann-java-client/issues/comments/70716444","html_url":"https://github.com/aphyr/riemann-java-client/issues/48#issuecomment-70716444","issue_url":"https://api.github.com/repos/aphyr/riemann-java-client/issues/48","id":70716444,"user":{"login":"aphyr","id":3748,"avatar_url":"https://avatars.githubusercontent.com/u/3748?v=3","gravatar_id":"","url":"https://api.github.com/users/aphyr","html_url":"https://github.com/aphyr","followers_url":"https://api.github.com/users/aphyr/followers","following_url":"https://api.github.com/users/aphyr/following{/other_user}","gists_url":"https://api.github.com/users/aphyr/gists{/gist_id}","starred_url":"https://api.github.com/users/aphyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aphyr/subscriptions","organizations_url":"https://api.github.com/users/aphyr/orgs","repos_url":"https://api.github.com/users/aphyr/repos","events_url":"https://api.github.com/users/aphyr/events{/privacy}","received_events_url":"https://api.github.com/users/aphyr/received_events","type":"User","site_admin":false},"created_at":"2015-01-20T19:30:35Z","updated_at":"2015-01-20T19:30:35Z","body":"Yeah, could you shoot me a PR for this? I'm, like, incredibly backlogged right now and haven't had good internet, but that'll make sure I get around to reviewing/merging. :)"}}