{"push_id":775941084,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"b199e528dfc9bcfea98964004f5dbfbd1801061a","before":"ad9f8480c8e08b95d6c217ec4a126bd93b7f376a","commits":[{"sha":"b199e528dfc9bcfea98964004f5dbfbd1801061a","author":{"email":"86f39098c3d6e8fa24cceea9f4753c2782977b2d@gmail.com","name":"John Sirois"},"message":"Ensure pipeline failuires fail CI.\n\nWe use pipelines to collect filtered lists of targets for\nseveral CI steps.  Previously these could fail when BUILD\nfiles had sytax or other errors, but the CI run would proceed\nwith no targets.  This change turns on pipefail and lifts up\ntarget collection steps so they are AND'ed with the steps\nthat use them such that pipefail actually triggers an overall\nfailure in those steps.\n\nTesting Done:\nManually tested by introducing 2 BUILD file errors:\n```diff\n$ git diff -U1 pants-plugins/\ndiff --git a/pants-plugins/tests/python/internal_backend_test/BUILD b/pants-plugins/tests/python/internal_backend_test/BUILD\nindex b9577ff..7b0e067 100644\n--- a/pants-plugins/tests/python/internal_backend_test/BUILD\n+++ b/pants-plugins/tests/python/internal_backend_test/BUILD\n@@ -3,3 +3,3 @@\n\n-target(\n+target2(\n   name='all',\n\n$ git diff -U1 -- tests/python/\ndiff --git a/tests/python/pants_test/BUILD b/tests/python/pants_test/BUILD\nindex 3a3cc05..a710ed0 100644\n--- a/tests/python/pants_test/BUILD\n+++ b/tests/python/pants_test/BUILD\n@@ -3,2 +3,4 @@\n\n+GARBAGE\n+\n python_library(\n```\n\nThen tested each pipeline-using CI step.\n\nInternal plugins:\n```console\n$ ./build-support/bin/ci.sh -fkmsrjpnca\n...\nException message: name 'target2' is not defined\n while executing BUILD file FilesystemBuildFile(/home/jsirois/dev/3rdparty/jsirois-pants/pants-plugins/tests/python/internal_backend_test/BUILD)\n Loading addresses from 'pants-plugins/tests/python/internal_backend_test' failed.\nInvalid BUILD files for [pants-plugins/tests/python::]\n\nINFO] Detected git repository at /home/jsirois/dev/3rdparty/jsirois-pants on branch jsirois/issues/2053\n\nInternal backend python test failure\n```\n\nPython unit tests:\n```console\n$ ./build-support/bin/ci.sh -fkmsrjlnca\n...\nException message: name 'GARBAGE' is not defined\n while executing BUILD file FilesystemBuildFile(/home/jsirois/dev/3rdparty/jsirois-pants/tests/python/pants_test/BUILD)\n Loading addresses from 'tests/python/pants_test' failed.\nInvalid BUILD files for [tests/python::]\n\nINFO] Detected git repository at /home/jsirois/dev/3rdparty/jsirois-pants on branch jsirois/issues/2053\n\nCore python test failure\n```\n\nPython integration tests:\n```console\n$ ./build-support/bin/ci.sh -fkmsrjlpna\n...\nException message: name 'GARBAGE' is not defined\n while executing BUILD file FilesystemBuildFile(/home/jsirois/dev/3rdparty/jsirois-pants/tests/python/pants_test/BUILD)\n Loading addresses from 'tests/python/pants_test' failed.\nInvalid BUILD files for [tests/python::]\n\nINFO] Detected git repository at /home/jsirois/dev/3rdparty/jsirois-pants on branch jsirois/issues/2053\n\nPants Integration test failure\n```\n\nCI went green here:\n  https://travis-ci.org/pantsbuild/pants/builds/77969386\n\nBugs closed: 2053, 2096\n\nReviewed at https://rbcommons.com/s/twitter/r/2731/","distinct":true,"url":"https://api.github.com/repos/pantsbuild/pants/commits/b199e528dfc9bcfea98964004f5dbfbd1801061a"}]}