{"action":"created","comment":{"url":"https://api.github.com/repos/seiflotfy/counts/pulls/comments/37232442","id":37232442,"diff_hunk":"@@ -12,29 +16,35 @@ var logger = utils.GetLogger()\n Domain is the toplevel domain to control the HLL implementation\n */\n type Domain struct {\n-\tabstract.Info\n+\t*abstract.Info\n \timpl *cuckoofilter.CuckooFilter\n+\tlock sync.RWMutex\n }\n \n /*\n NewDomain ...\n */\n-func NewDomain(info abstract.Info) Domain {\n-\treturn Domain{info, cuckoofilter.NewCuckooFilter(uint(info.Capacity))}\n+func NewDomain(info *abstract.Info) (*Domain, error) {\n+\treturn &Domain{info, cuckoofilter.NewCuckooFilter(info), sync.RWMutex{}}, nil","path":"counters/wrappers/cuckoofilter/domain.go","position":29,"original_position":29,"commit_id":"1445813aa473310dddec3ab40d7dc26ad7ca3f38","original_commit_id":"1445813aa473310dddec3ab40d7dc26ad7ca3f38","user":{"login":"seiflotfy","id":117837,"avatar_url":"https://avatars.githubusercontent.com/u/117837?v=3","gravatar_id":"","url":"https://api.github.com/users/seiflotfy","html_url":"https://github.com/seiflotfy","followers_url":"https://api.github.com/users/seiflotfy/followers","following_url":"https://api.github.com/users/seiflotfy/following{/other_user}","gists_url":"https://api.github.com/users/seiflotfy/gists{/gist_id}","starred_url":"https://api.github.com/users/seiflotfy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seiflotfy/subscriptions","organizations_url":"https://api.github.com/users/seiflotfy/orgs","repos_url":"https://api.github.com/users/seiflotfy/repos","events_url":"https://api.github.com/users/seiflotfy/events{/privacy}","received_events_url":"https://api.github.com/users/seiflotfy/received_events","type":"User","site_admin":false},"body":"Each request made via http is its own go routine. Golang default :D","created_at":"2015-08-17T20:24:50Z","updated_at":"2015-08-17T20:24:50Z","html_url":"https://github.com/seiflotfy/counts/pull/36#discussion_r37232442","pull_request_url":"https://api.github.com/repos/seiflotfy/counts/pulls/36","_links":{"self":{"href":"https://api.github.com/repos/seiflotfy/counts/pulls/comments/37232442"},"html":{"href":"https://github.com/seiflotfy/counts/pull/36#discussion_r37232442"},"pull_request":{"href":"https://api.github.com/repos/seiflotfy/counts/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/seiflotfy/counts/pulls/36","id":42527146,"html_url":"https://github.com/seiflotfy/counts/pull/36","diff_url":"https://github.com/seiflotfy/counts/pull/36.diff","patch_url":"https://github.com/seiflotfy/counts/pull/36.patch","issue_url":"https://api.github.com/repos/seiflotfy/counts/issues/36","number":36,"state":"open","locked":false,"title":"Cuckoofilter storage to disk and loading (WIP)","user":{"login":"seiflotfy","id":117837,"avatar_url":"https://avatars.githubusercontent.com/u/117837?v=3","gravatar_id":"","url":"https://api.github.com/users/seiflotfy","html_url":"https://github.com/seiflotfy","followers_url":"https://api.github.com/users/seiflotfy/followers","following_url":"https://api.github.com/users/seiflotfy/following{/other_user}","gists_url":"https://api.github.com/users/seiflotfy/gists{/gist_id}","starred_url":"https://api.github.com/users/seiflotfy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seiflotfy/subscriptions","organizations_url":"https://api.github.com/users/seiflotfy/orgs","repos_url":"https://api.github.com/users/seiflotfy/repos","events_url":"https://api.github.com/users/seiflotfy/events{/privacy}","received_events_url":"https://api.github.com/users/seiflotfy/received_events","type":"User","site_admin":false},"body":"This is a work in progress:\r\n- [x] store cuckoo filter buckets and fingerprints to disk\r\n- [x] load cuckoo filter state from disk\r\n- [x] cleanup","created_at":"2015-08-15T22:47:04Z","updated_at":"2015-08-17T20:24:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7d164cc9d67530717960406684aa7f88d7fa141","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/seiflotfy/counts/pulls/36/commits","review_comments_url":"https://api.github.com/repos/seiflotfy/counts/pulls/36/comments","review_comment_url":"https://api.github.com/repos/seiflotfy/counts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/seiflotfy/counts/issues/36/comments","statuses_url":"https://api.github.com/repos/seiflotfy/counts/statuses/1445813aa473310dddec3ab40d7dc26ad7ca3f38","head":{"label":"seiflotfy:storeCuckooFilter","ref":"storeCuckooFilter","sha":"1445813aa473310dddec3ab40d7dc26ad7ca3f38","user":{"login":"seiflotfy","id":117837,"avatar_url":"https://avatars.githubusercontent.com/u/117837?v=3","gravatar_id":"","url":"https://api.github.com/users/seiflotfy","html_url":"https://github.com/seiflotfy","followers_url":"https://api.github.com/users/seiflotfy/followers","following_url":"https://api.github.com/users/seiflotfy/following{/other_user}","gists_url":"https://api.github.com/users/seiflotfy/gists{/gist_id}","starred_url":"https://api.github.com/users/seiflotfy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seiflotfy/subscriptions","organizations_url":"https://api.github.com/users/seiflotfy/orgs","repos_url":"https://api.github.com/users/seiflotfy/repos","events_url":"https://api.github.com/users/seiflotfy/events{/privacy}","received_events_url":"https://api.github.com/users/seiflotfy/received_events","type":"User","site_admin":false},"repo":{"id":39992228,"name":"counts","full_name":"seiflotfy/counts","owner":{"login":"seiflotfy","id":117837,"avatar_url":"https://avatars.githubusercontent.com/u/117837?v=3","gravatar_id":"","url":"https://api.github.com/users/seiflotfy","html_url":"https://github.com/seiflotfy","followers_url":"https://api.github.com/users/seiflotfy/followers","following_url":"https://api.github.com/users/seiflotfy/following{/other_user}","gists_url":"https://api.github.com/users/seiflotfy/gists{/gist_id}","starred_url":"https://api.github.com/users/seiflotfy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seiflotfy/subscriptions","organizations_url":"https://api.github.com/users/seiflotfy/orgs","repos_url":"https://api.github.com/users/seiflotfy/repos","events_url":"https://api.github.com/users/seiflotfy/events{/privacy}","received_events_url":"https://api.github.com/users/seiflotfy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/seiflotfy/counts","description":"A domain-counter data store","fork":false,"url":"https://api.github.com/repos/seiflotfy/counts","forks_url":"https://api.github.com/repos/seiflotfy/counts/forks","keys_url":"https://api.github.com/repos/seiflotfy/counts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seiflotfy/counts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seiflotfy/counts/teams","hooks_url":"https://api.github.com/repos/seiflotfy/counts/hooks","issue_events_url":"https://api.github.com/repos/seiflotfy/counts/issues/events{/number}","events_url":"https://api.github.com/repos/seiflotfy/counts/events","assignees_url":"https://api.github.com/repos/seiflotfy/counts/assignees{/user}","branches_url":"https://api.github.com/repos/seiflotfy/counts/branches{/branch}","tags_url":"https://api.github.com/repos/seiflotfy/counts/tags","blobs_url":"https://api.github.com/repos/seiflotfy/counts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seiflotfy/counts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seiflotfy/counts/git/refs{/sha}","trees_url":"https://api.github.com/repos/seiflotfy/counts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seiflotfy/counts/statuses/{sha}","languages_url":"https://api.github.com/repos/seiflotfy/counts/languages","stargazers_url":"https://api.github.com/repos/seiflotfy/counts/stargazers","contributors_url":"https://api.github.com/repos/seiflotfy/counts/contributors","subscribers_url":"https://api.github.com/repos/seiflotfy/counts/subscribers","subscription_url":"https://api.github.com/repos/seiflotfy/counts/subscription","commits_url":"https://api.github.com/repos/seiflotfy/counts/commits{/sha}","git_commits_url":"https://api.github.com/repos/seiflotfy/counts/git/commits{/sha}","comments_url":"https://api.github.com/repos/seiflotfy/counts/comments{/number}","issue_comment_url":"https://api.github.com/repos/seiflotfy/counts/issues/comments{/number}","contents_url":"https://api.github.com/repos/seiflotfy/counts/contents/{+path}","compare_url":"https://api.github.com/repos/seiflotfy/counts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seiflotfy/counts/merges","archive_url":"https://api.github.com/repos/seiflotfy/counts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seiflotfy/counts/downloads","issues_url":"https://api.github.com/repos/seiflotfy/counts/issues{/number}","pulls_url":"https://api.github.com/repos/seiflotfy/counts/pulls{/number}","milestones_url":"https://api.github.com/repos/seiflotfy/counts/milestones{/number}","notifications_url":"https://api.github.com/repos/seiflotfy/counts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seiflotfy/counts/labels{/name}","releases_url":"https://api.github.com/repos/seiflotfy/counts/releases{/id}","created_at":"2015-07-31T07:17:02Z","updated_at":"2015-08-14T20:39:17Z","pushed_at":"2015-08-16T21:52:38Z","git_url":"git://github.com/seiflotfy/counts.git","ssh_url":"git@github.com:seiflotfy/counts.git","clone_url":"https://github.com/seiflotfy/counts.git","svn_url":"https://github.com/seiflotfy/counts","homepage":"","size":877,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":11,"forks":3,"open_issues":11,"watchers":4,"default_branch":"master"}},"base":{"label":"seiflotfy:master","ref":"master","sha":"3c574bef0cda65b33a402a6a45434aae6481e154","user":{"login":"seiflotfy","id":117837,"avatar_url":"https://avatars.githubusercontent.com/u/117837?v=3","gravatar_id":"","url":"https://api.github.com/users/seiflotfy","html_url":"https://github.com/seiflotfy","followers_url":"https://api.github.com/users/seiflotfy/followers","following_url":"https://api.github.com/users/seiflotfy/following{/other_user}","gists_url":"https://api.github.com/users/seiflotfy/gists{/gist_id}","starred_url":"https://api.github.com/users/seiflotfy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seiflotfy/subscriptions","organizations_url":"https://api.github.com/users/seiflotfy/orgs","repos_url":"https://api.github.com/users/seiflotfy/repos","events_url":"https://api.github.com/users/seiflotfy/events{/privacy}","received_events_url":"https://api.github.com/users/seiflotfy/received_events","type":"User","site_admin":false},"repo":{"id":39992228,"name":"counts","full_name":"seiflotfy/counts","owner":{"login":"seiflotfy","id":117837,"avatar_url":"https://avatars.githubusercontent.com/u/117837?v=3","gravatar_id":"","url":"https://api.github.com/users/seiflotfy","html_url":"https://github.com/seiflotfy","followers_url":"https://api.github.com/users/seiflotfy/followers","following_url":"https://api.github.com/users/seiflotfy/following{/other_user}","gists_url":"https://api.github.com/users/seiflotfy/gists{/gist_id}","starred_url":"https://api.github.com/users/seiflotfy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seiflotfy/subscriptions","organizations_url":"https://api.github.com/users/seiflotfy/orgs","repos_url":"https://api.github.com/users/seiflotfy/repos","events_url":"https://api.github.com/users/seiflotfy/events{/privacy}","received_events_url":"https://api.github.com/users/seiflotfy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/seiflotfy/counts","description":"A domain-counter data store","fork":false,"url":"https://api.github.com/repos/seiflotfy/counts","forks_url":"https://api.github.com/repos/seiflotfy/counts/forks","keys_url":"https://api.github.com/repos/seiflotfy/counts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seiflotfy/counts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seiflotfy/counts/teams","hooks_url":"https://api.github.com/repos/seiflotfy/counts/hooks","issue_events_url":"https://api.github.com/repos/seiflotfy/counts/issues/events{/number}","events_url":"https://api.github.com/repos/seiflotfy/counts/events","assignees_url":"https://api.github.com/repos/seiflotfy/counts/assignees{/user}","branches_url":"https://api.github.com/repos/seiflotfy/counts/branches{/branch}","tags_url":"https://api.github.com/repos/seiflotfy/counts/tags","blobs_url":"https://api.github.com/repos/seiflotfy/counts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seiflotfy/counts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seiflotfy/counts/git/refs{/sha}","trees_url":"https://api.github.com/repos/seiflotfy/counts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seiflotfy/counts/statuses/{sha}","languages_url":"https://api.github.com/repos/seiflotfy/counts/languages","stargazers_url":"https://api.github.com/repos/seiflotfy/counts/stargazers","contributors_url":"https://api.github.com/repos/seiflotfy/counts/contributors","subscribers_url":"https://api.github.com/repos/seiflotfy/counts/subscribers","subscription_url":"https://api.github.com/repos/seiflotfy/counts/subscription","commits_url":"https://api.github.com/repos/seiflotfy/counts/commits{/sha}","git_commits_url":"https://api.github.com/repos/seiflotfy/counts/git/commits{/sha}","comments_url":"https://api.github.com/repos/seiflotfy/counts/comments{/number}","issue_comment_url":"https://api.github.com/repos/seiflotfy/counts/issues/comments{/number}","contents_url":"https://api.github.com/repos/seiflotfy/counts/contents/{+path}","compare_url":"https://api.github.com/repos/seiflotfy/counts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seiflotfy/counts/merges","archive_url":"https://api.github.com/repos/seiflotfy/counts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seiflotfy/counts/downloads","issues_url":"https://api.github.com/repos/seiflotfy/counts/issues{/number}","pulls_url":"https://api.github.com/repos/seiflotfy/counts/pulls{/number}","milestones_url":"https://api.github.com/repos/seiflotfy/counts/milestones{/number}","notifications_url":"https://api.github.com/repos/seiflotfy/counts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seiflotfy/counts/labels{/name}","releases_url":"https://api.github.com/repos/seiflotfy/counts/releases{/id}","created_at":"2015-07-31T07:17:02Z","updated_at":"2015-08-14T20:39:17Z","pushed_at":"2015-08-16T21:52:38Z","git_url":"git://github.com/seiflotfy/counts.git","ssh_url":"git@github.com:seiflotfy/counts.git","clone_url":"https://github.com/seiflotfy/counts.git","svn_url":"https://github.com/seiflotfy/counts","homepage":"","size":877,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":11,"forks":3,"open_issues":11,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/seiflotfy/counts/pulls/36"},"html":{"href":"https://github.com/seiflotfy/counts/pull/36"},"issue":{"href":"https://api.github.com/repos/seiflotfy/counts/issues/36"},"comments":{"href":"https://api.github.com/repos/seiflotfy/counts/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/seiflotfy/counts/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/seiflotfy/counts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/seiflotfy/counts/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/seiflotfy/counts/statuses/1445813aa473310dddec3ab40d7dc26ad7ca3f38"}}}}