{"action":"created","issue":{"url":"https://api.github.com/repos/benperez/chinese-poker/issues/2","labels_url":"https://api.github.com/repos/benperez/chinese-poker/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/benperez/chinese-poker/issues/2/comments","events_url":"https://api.github.com/repos/benperez/chinese-poker/issues/2/events","html_url":"https://github.com/benperez/chinese-poker/pull/2","id":101808751,"number":2,"title":"add support for a-2-3-4-5 straights","user":{"login":"benperez","id":1057202,"avatar_url":"https://avatars.githubusercontent.com/u/1057202?v=3","gravatar_id":"","url":"https://api.github.com/users/benperez","html_url":"https://github.com/benperez","followers_url":"https://api.github.com/users/benperez/followers","following_url":"https://api.github.com/users/benperez/following{/other_user}","gists_url":"https://api.github.com/users/benperez/gists{/gist_id}","starred_url":"https://api.github.com/users/benperez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benperez/subscriptions","organizations_url":"https://api.github.com/users/benperez/orgs","repos_url":"https://api.github.com/users/benperez/repos","events_url":"https://api.github.com/users/benperez/events{/privacy}","received_events_url":"https://api.github.com/users/benperez/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-19T05:06:19Z","updated_at":"2015-08-19T16:29:37Z","closed_at":"2015-08-19T16:18:59Z","pull_request":{"url":"https://api.github.com/repos/benperez/chinese-poker/pulls/2","html_url":"https://github.com/benperez/chinese-poker/pull/2","diff_url":"https://github.com/benperez/chinese-poker/pull/2.diff","patch_url":"https://github.com/benperez/chinese-poker/pull/2.patch"},"body":"This PR addresses the problem of comparing Ace through Five straights. I handled this case by making an Ace through Five straight a different type that loses to a regular straight but beats trips. This will prevent the two straights from being compared based solely on their cards, which would result in an error since in the case of Ace-2-3-4-5 vs 2-3-4-5-6 the Ace would be a higher card than the 6 but the 2-3-4-5-6 straight is clearly better.\r\n\r\n\r\n\r\nping @davidchambers"},"comment":{"url":"https://api.github.com/repos/benperez/chinese-poker/issues/comments/132684519","html_url":"https://github.com/benperez/chinese-poker/pull/2#issuecomment-132684519","issue_url":"https://api.github.com/repos/benperez/chinese-poker/issues/2","id":132684519,"user":{"login":"davidchambers","id":210406,"avatar_url":"https://avatars.githubusercontent.com/u/210406?v=3","gravatar_id":"","url":"https://api.github.com/users/davidchambers","html_url":"https://github.com/davidchambers","followers_url":"https://api.github.com/users/davidchambers/followers","following_url":"https://api.github.com/users/davidchambers/following{/other_user}","gists_url":"https://api.github.com/users/davidchambers/gists{/gist_id}","starred_url":"https://api.github.com/users/davidchambers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidchambers/subscriptions","organizations_url":"https://api.github.com/users/davidchambers/orgs","repos_url":"https://api.github.com/users/davidchambers/repos","events_url":"https://api.github.com/users/davidchambers/events{/privacy}","received_events_url":"https://api.github.com/users/davidchambers/received_events","type":"User","site_admin":false},"created_at":"2015-08-19T16:29:37Z","updated_at":"2015-08-19T16:29:37Z","body":"Clever! This is fine since the hand types will not be exposed. Were this a module we intended others to import, I wouldn't want implementation concerns to affect the public interface.\r\n"}}