{"action":"created","issue":{"url":"https://api.github.com/repos/cargomedia/cm-janus/issues/59","labels_url":"https://api.github.com/repos/cargomedia/cm-janus/issues/59/labels{/name}","comments_url":"https://api.github.com/repos/cargomedia/cm-janus/issues/59/comments","events_url":"https://api.github.com/repos/cargomedia/cm-janus/issues/59/events","html_url":"https://github.com/cargomedia/cm-janus/pull/59","id":117844561,"number":59,"title":"Inject ServiceLocator to application classes","user":{"login":"fvovan","id":2360687,"avatar_url":"https://avatars.githubusercontent.com/u/2360687?v=3","gravatar_id":"","url":"https://api.github.com/users/fvovan","html_url":"https://github.com/fvovan","followers_url":"https://api.github.com/users/fvovan/followers","following_url":"https://api.github.com/users/fvovan/following{/other_user}","gists_url":"https://api.github.com/users/fvovan/gists{/gist_id}","starred_url":"https://api.github.com/users/fvovan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvovan/subscriptions","organizations_url":"https://api.github.com/users/fvovan/orgs","repos_url":"https://api.github.com/users/fvovan/repos","events_url":"https://api.github.com/users/fvovan/events{/privacy}","received_events_url":"https://api.github.com/users/fvovan/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cargomedia/cm-janus/labels/selfmade","name":"selfmade","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"fvovan","id":2360687,"avatar_url":"https://avatars.githubusercontent.com/u/2360687?v=3","gravatar_id":"","url":"https://api.github.com/users/fvovan","html_url":"https://github.com/fvovan","followers_url":"https://api.github.com/users/fvovan/followers","following_url":"https://api.github.com/users/fvovan/following{/other_user}","gists_url":"https://api.github.com/users/fvovan/gists{/gist_id}","starred_url":"https://api.github.com/users/fvovan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvovan/subscriptions","organizations_url":"https://api.github.com/users/fvovan/orgs","repos_url":"https://api.github.com/users/fvovan/repos","events_url":"https://api.github.com/users/fvovan/events{/privacy}","received_events_url":"https://api.github.com/users/fvovan/received_events","type":"User","site_admin":false},"milestone":null,"comments":8,"created_at":"2015-11-19T15:59:10Z","updated_at":"2015-11-20T11:41:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cargomedia/cm-janus/pulls/59","html_url":"https://github.com/cargomedia/cm-janus/pull/59","diff_url":"https://github.com/cargomedia/cm-janus/pull/59.diff","patch_url":"https://github.com/cargomedia/cm-janus/pull/59.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/cargomedia/cm-janus/issues/comments/158370546","html_url":"https://github.com/cargomedia/cm-janus/pull/59#issuecomment-158370546","issue_url":"https://api.github.com/repos/cargomedia/cm-janus/issues/59","id":158370546,"user":{"login":"tomaszdurka","id":113303,"avatar_url":"https://avatars.githubusercontent.com/u/113303?v=3","gravatar_id":"","url":"https://api.github.com/users/tomaszdurka","html_url":"https://github.com/tomaszdurka","followers_url":"https://api.github.com/users/tomaszdurka/followers","following_url":"https://api.github.com/users/tomaszdurka/following{/other_user}","gists_url":"https://api.github.com/users/tomaszdurka/gists{/gist_id}","starred_url":"https://api.github.com/users/tomaszdurka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomaszdurka/subscriptions","organizations_url":"https://api.github.com/users/tomaszdurka/orgs","repos_url":"https://api.github.com/users/tomaszdurka/repos","events_url":"https://api.github.com/users/tomaszdurka/events{/privacy}","received_events_url":"https://api.github.com/users/tomaszdurka/received_events","type":"User","site_admin":false},"created_at":"2015-11-20T11:41:16Z","updated_at":"2015-11-20T11:41:16Z","body":"Guys, let's not worry about Auth please. I think we might remove it all together some time soon.\r\nRegarding service-locator I would keep it as is! @fvovan All of this is done to make it testable or basically more \"correct\"? We should be able to leave with single global singelton for now. \r\n\r\nPlus testing it ain't so hard. It doesn't have any state we cannot really check (it's javascript) and doesn't have any state set in constructor too."}}