{"action":"created","issue":{"url":"https://api.github.com/repos/tildeio/htmlbars/issues/248","labels_url":"https://api.github.com/repos/tildeio/htmlbars/issues/248/labels{/name}","comments_url":"https://api.github.com/repos/tildeio/htmlbars/issues/248/comments","events_url":"https://api.github.com/repos/tildeio/htmlbars/issues/248/events","html_url":"https://github.com/tildeio/htmlbars/pull/248","id":53965386,"number":248,"title":"Change setProperty and morph to remove an undefined or NaN attr value","user":{"login":"mixonic","id":8752,"avatar_url":"https://avatars.githubusercontent.com/u/8752?v=3","gravatar_id":"","url":"https://api.github.com/users/mixonic","html_url":"https://github.com/mixonic","followers_url":"https://api.github.com/users/mixonic/followers","following_url":"https://api.github.com/users/mixonic/following{/other_user}","gists_url":"https://api.github.com/users/mixonic/gists{/gist_id}","starred_url":"https://api.github.com/users/mixonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixonic/subscriptions","organizations_url":"https://api.github.com/users/mixonic/orgs","repos_url":"https://api.github.com/users/mixonic/repos","events_url":"https://api.github.com/users/mixonic/events{/privacy}","received_events_url":"https://api.github.com/users/mixonic/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-01-10T17:43:04Z","updated_at":"2015-01-11T05:24:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tildeio/htmlbars/pulls/248","html_url":"https://github.com/tildeio/htmlbars/pull/248","diff_url":"https://github.com/tildeio/htmlbars/pull/248.diff","patch_url":"https://github.com/tildeio/htmlbars/pull/248.patch"},"body":"Open for debate. Maybe this should be part of another layer in Ember. IMO it is ok here.\r\n\r\nEmber expects setting an attribute binding to `undefined` or `NaN` to remove the attribute entirely. This follows that logic."},"comment":{"url":"https://api.github.com/repos/tildeio/htmlbars/issues/comments/69484206","html_url":"https://github.com/tildeio/htmlbars/pull/248#issuecomment-69484206","issue_url":"https://api.github.com/repos/tildeio/htmlbars/issues/248","id":69484206,"user":{"login":"mixonic","id":8752,"avatar_url":"https://avatars.githubusercontent.com/u/8752?v=3","gravatar_id":"","url":"https://api.github.com/users/mixonic","html_url":"https://github.com/mixonic","followers_url":"https://api.github.com/users/mixonic/followers","following_url":"https://api.github.com/users/mixonic/following{/other_user}","gists_url":"https://api.github.com/users/mixonic/gists{/gist_id}","starred_url":"https://api.github.com/users/mixonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixonic/subscriptions","organizations_url":"https://api.github.com/users/mixonic/orgs","repos_url":"https://api.github.com/users/mixonic/repos","events_url":"https://api.github.com/users/mixonic/events{/privacy}","received_events_url":"https://api.github.com/users/mixonic/received_events","type":"User","site_admin":false},"created_at":"2015-01-11T05:24:53Z","updated_at":"2015-01-11T05:24:53Z","body":"After discussion with @rwjblue I've dropped the `NaN` check.\r\n\r\nIn Ember, I'm leaving the `NaN` value behavior undefined: https://github.com/emberjs/ember.js/pull/10186/files#diff-f7920bfff32661282a5d9c883cc26641L43"}}