{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/13876","labels_url":"https://api.github.com/repos/docker/docker/issues/13876/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/13876/comments","events_url":"https://api.github.com/repos/docker/docker/issues/13876/events","html_url":"https://github.com/docker/docker/pull/13876","id":87246212,"number":13876,"title":"Add test coverage to pkg/jsonlog","user":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars.githubusercontent.com/u/6508?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/status/4-ready-to-merge","name":"status/4-ready-to-merge","color":"d4c5f9"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-06-11T07:35:54Z","updated_at":"2015-06-29T20:50:31Z","closed_at":"2015-06-29T14:39:56Z","pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/13876","html_url":"https://github.com/docker/docker/pull/13876","diff_url":"https://github.com/docker/docker/pull/13876.diff","patch_url":"https://github.com/docker/docker/pull/13876.patch"},"body":"After ``opts`` package (https://github.com/docker/docker/pull/13694), it was time for ``pkg/jsonlog`` :smile_cat:.\r\n\r\n- I've removed a few lines in ``jsonlog_marshalling.go`` that will never be called (or I missed something :sweat:), and updated the header with the *diff*.\r\n- Did the same for ``jsonlogbytes.go`` (almost).\r\n- It felt a little *weird*/*overkill*/*too much* to add the same test for ``jsonlogbytes.go`` and ``jsonlog_marshalling.go`` but well, I was on my way so.. :sweat_smile:.\r\n\r\n```sh\r\n# before\r\n+ go test -test.timeout=45m github.com/docker/docker/pkg/jsonlog\r\nPASS\r\ncoverage: 10.6% of statements\r\n# after\r\n+ go test -test.timeout=30m github.com/docker/docker/pkg/jsonlog\r\nPASS\r\ncoverage: 94.9% of statements\r\n```\r\n\r\n\r\nSigned-off-by: Vincent Demeester <vincent@sbr.pm>"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/116842923","html_url":"https://github.com/docker/docker/pull/13876#issuecomment-116842923","issue_url":"https://api.github.com/repos/docker/docker/issues/13876","id":116842923,"user":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars.githubusercontent.com/u/6508?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"created_at":"2015-06-29T20:50:31Z","updated_at":"2015-06-29T20:50:31Z","body":":blush: "}}