{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/io.js/pulls/comments/32117768","id":32117768,"diff_hunk":"@@ -88,6 +88,11 @@ parser.add_option(\"--openssl-no-asm\",\n     dest=\"openssl_no_asm\",\n     help=\"Do not build optimized assembly for OpenSSL\")\n \n+parser.add_option(\"--openssl-fips\",","path":"configure","position":4,"original_position":4,"commit_id":"8cfe4ab2dce4cd252a139d2262bf11bdc01abb63","original_commit_id":"8cfe4ab2dce4cd252a139d2262bf11bdc01abb63","user":{"login":"thefourtheye","id":696611,"avatar_url":"https://avatars.githubusercontent.com/u/696611?v=3","gravatar_id":"","url":"https://api.github.com/users/thefourtheye","html_url":"https://github.com/thefourtheye","followers_url":"https://api.github.com/users/thefourtheye/followers","following_url":"https://api.github.com/users/thefourtheye/following{/other_user}","gists_url":"https://api.github.com/users/thefourtheye/gists{/gist_id}","starred_url":"https://api.github.com/users/thefourtheye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefourtheye/subscriptions","organizations_url":"https://api.github.com/users/thefourtheye/orgs","repos_url":"https://api.github.com/users/thefourtheye/repos","events_url":"https://api.github.com/users/thefourtheye/events{/privacy}","received_events_url":"https://api.github.com/users/thefourtheye/received_events","type":"User","site_admin":false},"body":"Very minor. Everywhere else in the PR, `'` is used and only here `\"` is used. Is there any convention followed?","created_at":"2015-06-10T13:42:13Z","updated_at":"2015-06-10T13:42:13Z","html_url":"https://github.com/nodejs/io.js/pull/1890#discussion_r32117768","pull_request_url":"https://api.github.com/repos/nodejs/io.js/pulls/1890","_links":{"self":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/comments/32117768"},"html":{"href":"https://github.com/nodejs/io.js/pull/1890#discussion_r32117768"},"pull_request":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/1890"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/io.js/pulls/1890","id":36879489,"html_url":"https://github.com/nodejs/io.js/pull/1890","diff_url":"https://github.com/nodejs/io.js/pull/1890.diff","patch_url":"https://github.com/nodejs/io.js/pull/1890.patch","issue_url":"https://api.github.com/repos/nodejs/io.js/issues/1890","number":1890,"state":"open","locked":false,"title":"crypto: support FIPS mode of OpenSSL","user":{"login":"indutny","id":238531,"avatar_url":"https://avatars.githubusercontent.com/u/238531?v=3","gravatar_id":"","url":"https://api.github.com/users/indutny","html_url":"https://github.com/indutny","followers_url":"https://api.github.com/users/indutny/followers","following_url":"https://api.github.com/users/indutny/following{/other_user}","gists_url":"https://api.github.com/users/indutny/gists{/gist_id}","starred_url":"https://api.github.com/users/indutny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indutny/subscriptions","organizations_url":"https://api.github.com/users/indutny/orgs","repos_url":"https://api.github.com/users/indutny/repos","events_url":"https://api.github.com/users/indutny/events{/privacy}","received_events_url":"https://api.github.com/users/indutny/received_events","type":"User","site_admin":false},"body":"Support building and running with FIPS-compliant OpenSSL. The process is\r\nfollowing:\r\n\r\n1. Download and verify `openssl-fips-x.x.x.tar.gz` from\r\n   https://www.openssl.org/source/\r\n2. Extract source to `openssl-fips` folder\r\n3. `cd openssl-fips && ./config fipscanisterbuild --prefix=`pwd`/out`\r\n4. `make -j && make install`\r\n5. Get into io.js checkout folder\r\n6. `./configure --openssl-fips=/path/to/openssl-fips/out`\r\n7. Build io.js with `make -j`\r\n\r\nFix: https://github.com/joyent/node/issues/25463","created_at":"2015-06-03T21:21:47Z","updated_at":"2015-06-10T13:42:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf920c0bd7bb9577bad54e9b82b62aec1d18887c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/io.js/pulls/1890/commits","review_comments_url":"https://api.github.com/repos/nodejs/io.js/pulls/1890/comments","review_comment_url":"https://api.github.com/repos/nodejs/io.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/io.js/issues/1890/comments","statuses_url":"https://api.github.com/repos/nodejs/io.js/statuses/8cfe4ab2dce4cd252a139d2262bf11bdc01abb63","head":{"label":"indutny:feature/fips-mode","ref":"feature/fips-mode","sha":"8cfe4ab2dce4cd252a139d2262bf11bdc01abb63","user":{"login":"indutny","id":238531,"avatar_url":"https://avatars.githubusercontent.com/u/238531?v=3","gravatar_id":"","url":"https://api.github.com/users/indutny","html_url":"https://github.com/indutny","followers_url":"https://api.github.com/users/indutny/followers","following_url":"https://api.github.com/users/indutny/following{/other_user}","gists_url":"https://api.github.com/users/indutny/gists{/gist_id}","starred_url":"https://api.github.com/users/indutny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indutny/subscriptions","organizations_url":"https://api.github.com/users/indutny/orgs","repos_url":"https://api.github.com/users/indutny/repos","events_url":"https://api.github.com/users/indutny/events{/privacy}","received_events_url":"https://api.github.com/users/indutny/received_events","type":"User","site_admin":false},"repo":{"id":27231488,"name":"io.js","full_name":"indutny/io.js","owner":{"login":"indutny","id":238531,"avatar_url":"https://avatars.githubusercontent.com/u/238531?v=3","gravatar_id":"","url":"https://api.github.com/users/indutny","html_url":"https://github.com/indutny","followers_url":"https://api.github.com/users/indutny/followers","following_url":"https://api.github.com/users/indutny/following{/other_user}","gists_url":"https://api.github.com/users/indutny/gists{/gist_id}","starred_url":"https://api.github.com/users/indutny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indutny/subscriptions","organizations_url":"https://api.github.com/users/indutny/orgs","repos_url":"https://api.github.com/users/indutny/repos","events_url":"https://api.github.com/users/indutny/events{/privacy}","received_events_url":"https://api.github.com/users/indutny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/indutny/io.js","description":"Evented IO for V8 JavaScript","fork":true,"url":"https://api.github.com/repos/indutny/io.js","forks_url":"https://api.github.com/repos/indutny/io.js/forks","keys_url":"https://api.github.com/repos/indutny/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/indutny/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/indutny/io.js/teams","hooks_url":"https://api.github.com/repos/indutny/io.js/hooks","issue_events_url":"https://api.github.com/repos/indutny/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/indutny/io.js/events","assignees_url":"https://api.github.com/repos/indutny/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/indutny/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/indutny/io.js/tags","blobs_url":"https://api.github.com/repos/indutny/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/indutny/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/indutny/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/indutny/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/indutny/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/indutny/io.js/languages","stargazers_url":"https://api.github.com/repos/indutny/io.js/stargazers","contributors_url":"https://api.github.com/repos/indutny/io.js/contributors","subscribers_url":"https://api.github.com/repos/indutny/io.js/subscribers","subscription_url":"https://api.github.com/repos/indutny/io.js/subscription","commits_url":"https://api.github.com/repos/indutny/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/indutny/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/indutny/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/indutny/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/indutny/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/indutny/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/indutny/io.js/merges","archive_url":"https://api.github.com/repos/indutny/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/indutny/io.js/downloads","issues_url":"https://api.github.com/repos/indutny/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/indutny/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/indutny/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/indutny/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/indutny/io.js/labels{/name}","releases_url":"https://api.github.com/repos/indutny/io.js/releases{/id}","created_at":"2014-11-27T15:38:33Z","updated_at":"2015-02-18T15:41:43Z","pushed_at":"2015-06-10T11:08:15Z","git_url":"git://github.com/indutny/io.js.git","ssh_url":"git@github.com:indutny/io.js.git","clone_url":"https://github.com/indutny/io.js.git","svn_url":"https://github.com/indutny/io.js","homepage":null,"size":132246,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"v0.12"}},"base":{"label":"nodejs:master","ref":"master","sha":"6d95f4ff923018bb9720888e4ea986cddf0ff5b5","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"io.js","full_name":"nodejs/io.js","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/io.js","description":"Node.js, but with bigger and faster version numbers","fork":false,"url":"https://api.github.com/repos/nodejs/io.js","forks_url":"https://api.github.com/repos/nodejs/io.js/forks","keys_url":"https://api.github.com/repos/nodejs/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/io.js/teams","hooks_url":"https://api.github.com/repos/nodejs/io.js/hooks","issue_events_url":"https://api.github.com/repos/nodejs/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/io.js/events","assignees_url":"https://api.github.com/repos/nodejs/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/io.js/tags","blobs_url":"https://api.github.com/repos/nodejs/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/io.js/languages","stargazers_url":"https://api.github.com/repos/nodejs/io.js/stargazers","contributors_url":"https://api.github.com/repos/nodejs/io.js/contributors","subscribers_url":"https://api.github.com/repos/nodejs/io.js/subscribers","subscription_url":"https://api.github.com/repos/nodejs/io.js/subscription","commits_url":"https://api.github.com/repos/nodejs/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/io.js/merges","archive_url":"https://api.github.com/repos/nodejs/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/io.js/downloads","issues_url":"https://api.github.com/repos/nodejs/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/io.js/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/io.js/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2015-06-10T13:37:16Z","pushed_at":"2015-06-10T13:34:40Z","git_url":"git://github.com/nodejs/io.js.git","ssh_url":"git@github.com:nodejs/io.js.git","clone_url":"https://github.com/nodejs/io.js.git","svn_url":"https://github.com/nodejs/io.js","homepage":"https://iojs.org","size":179328,"stargazers_count":12643,"watchers_count":12643,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":967,"mirror_url":null,"open_issues_count":292,"forks":967,"open_issues":292,"watchers":12643,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/1890"},"html":{"href":"https://github.com/nodejs/io.js/pull/1890"},"issue":{"href":"https://api.github.com/repos/nodejs/io.js/issues/1890"},"comments":{"href":"https://api.github.com/repos/nodejs/io.js/issues/1890/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/1890/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/1890/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/io.js/statuses/8cfe4ab2dce4cd252a139d2262bf11bdc01abb63"}}}}