{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/olympia/pulls/comments/38795256","id":38795256,"diff_hunk":"@@ -89,6 +90,12 @@ def test_dupe_uuid(self, flag_is_active):\n               'type': 'error', 'fatal': True}])\n         eq_(data['validation']['ending_tier'], 1)\n \n+    def test_too_long_uuid(self):\n+        \"\"\"An add-on uuid must be 64chars at most, see bug 1201176.\"\"\"\n+        with self.assertRaises(forms.ValidationError,\n+                               msg='UUID must be less than 64chars'):\n+            parse_addon(self.get_upload('extension-too-long-guid.xpi'))","path":"apps/devhub/tests/test_views_validation.py","position":16,"original_position":16,"commit_id":"44eba2cfe1721aeff71d48e927ef05b2a6f3d836","original_commit_id":"44eba2cfe1721aeff71d48e927ef05b2a6f3d836","user":{"login":"kmaglione","id":125842,"avatar_url":"https://avatars.githubusercontent.com/u/125842?v=3","gravatar_id":"","url":"https://api.github.com/users/kmaglione","html_url":"https://github.com/kmaglione","followers_url":"https://api.github.com/users/kmaglione/followers","following_url":"https://api.github.com/users/kmaglione/following{/other_user}","gists_url":"https://api.github.com/users/kmaglione/gists{/gist_id}","starred_url":"https://api.github.com/users/kmaglione/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmaglione/subscriptions","organizations_url":"https://api.github.com/users/kmaglione/orgs","repos_url":"https://api.github.com/users/kmaglione/repos","events_url":"https://api.github.com/users/kmaglione/events{/privacy}","received_events_url":"https://api.github.com/users/kmaglione/received_events","type":"User","site_admin":false},"body":"Any chance you could try this using `files.utils.make_xpi` (as in https://github.com/mozilla/olympia/blob/master/apps/zadmin/tests/test_tasks.py#L46) rather than creating a file fixture? Fixtures can be kind of opaque, and I'd much rather be able to look at exactly what this is testing rather than locate and unzip an XPI.","created_at":"2015-09-04T21:20:55Z","updated_at":"2015-09-04T21:20:55Z","html_url":"https://github.com/mozilla/olympia/pull/714#discussion_r38795256","pull_request_url":"https://api.github.com/repos/mozilla/olympia/pulls/714","_links":{"self":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/comments/38795256"},"html":{"href":"https://github.com/mozilla/olympia/pull/714#discussion_r38795256"},"pull_request":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/714"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/olympia/pulls/714","id":44202376,"html_url":"https://github.com/mozilla/olympia/pull/714","diff_url":"https://github.com/mozilla/olympia/pull/714.diff","patch_url":"https://github.com/mozilla/olympia/pull/714.patch","issue_url":"https://api.github.com/repos/mozilla/olympia/issues/714","number":714,"state":"open","locked":false,"title":"Reject add-on submission if its guid is more than 64chars (bug 1201176)","user":{"login":"magopian","id":167767,"avatar_url":"https://avatars.githubusercontent.com/u/167767?v=3","gravatar_id":"","url":"https://api.github.com/users/magopian","html_url":"https://github.com/magopian","followers_url":"https://api.github.com/users/magopian/followers","following_url":"https://api.github.com/users/magopian/following{/other_user}","gists_url":"https://api.github.com/users/magopian/gists{/gist_id}","starred_url":"https://api.github.com/users/magopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magopian/subscriptions","organizations_url":"https://api.github.com/users/magopian/orgs","repos_url":"https://api.github.com/users/magopian/repos","events_url":"https://api.github.com/users/magopian/events{/privacy}","received_events_url":"https://api.github.com/users/magopian/received_events","type":"User","site_admin":false},"body":"Fixes [bug 1201176](https://bugzilla.mozilla.org/show_bug.cgi?id=1201176)\n\nThis PR doesn't deal (yet) with the current add-ons that have too long GUIDs.","created_at":"2015-09-04T10:15:41Z","updated_at":"2015-09-04T21:20:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56257fe2dd5f0791cd51952a30303dd57f7edc58","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/olympia/pulls/714/commits","review_comments_url":"https://api.github.com/repos/mozilla/olympia/pulls/714/comments","review_comment_url":"https://api.github.com/repos/mozilla/olympia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/olympia/issues/714/comments","statuses_url":"https://api.github.com/repos/mozilla/olympia/statuses/44eba2cfe1721aeff71d48e927ef05b2a6f3d836","head":{"label":"magopian:1201176-reject-addon-submission-if-guid-too-long","ref":"1201176-reject-addon-submission-if-guid-too-long","sha":"44eba2cfe1721aeff71d48e927ef05b2a6f3d836","user":{"login":"magopian","id":167767,"avatar_url":"https://avatars.githubusercontent.com/u/167767?v=3","gravatar_id":"","url":"https://api.github.com/users/magopian","html_url":"https://github.com/magopian","followers_url":"https://api.github.com/users/magopian/followers","following_url":"https://api.github.com/users/magopian/following{/other_user}","gists_url":"https://api.github.com/users/magopian/gists{/gist_id}","starred_url":"https://api.github.com/users/magopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magopian/subscriptions","organizations_url":"https://api.github.com/users/magopian/orgs","repos_url":"https://api.github.com/users/magopian/repos","events_url":"https://api.github.com/users/magopian/events{/privacy}","received_events_url":"https://api.github.com/users/magopian/received_events","type":"User","site_admin":false},"repo":{"id":17664164,"name":"olympia","full_name":"magopian/olympia","owner":{"login":"magopian","id":167767,"avatar_url":"https://avatars.githubusercontent.com/u/167767?v=3","gravatar_id":"","url":"https://api.github.com/users/magopian","html_url":"https://github.com/magopian","followers_url":"https://api.github.com/users/magopian/followers","following_url":"https://api.github.com/users/magopian/following{/other_user}","gists_url":"https://api.github.com/users/magopian/gists{/gist_id}","starred_url":"https://api.github.com/users/magopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magopian/subscriptions","organizations_url":"https://api.github.com/users/magopian/orgs","repos_url":"https://api.github.com/users/magopian/repos","events_url":"https://api.github.com/users/magopian/events{/privacy}","received_events_url":"https://api.github.com/users/magopian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/magopian/olympia","description":"AMO, reloaded.","fork":true,"url":"https://api.github.com/repos/magopian/olympia","forks_url":"https://api.github.com/repos/magopian/olympia/forks","keys_url":"https://api.github.com/repos/magopian/olympia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magopian/olympia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magopian/olympia/teams","hooks_url":"https://api.github.com/repos/magopian/olympia/hooks","issue_events_url":"https://api.github.com/repos/magopian/olympia/issues/events{/number}","events_url":"https://api.github.com/repos/magopian/olympia/events","assignees_url":"https://api.github.com/repos/magopian/olympia/assignees{/user}","branches_url":"https://api.github.com/repos/magopian/olympia/branches{/branch}","tags_url":"https://api.github.com/repos/magopian/olympia/tags","blobs_url":"https://api.github.com/repos/magopian/olympia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magopian/olympia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magopian/olympia/git/refs{/sha}","trees_url":"https://api.github.com/repos/magopian/olympia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magopian/olympia/statuses/{sha}","languages_url":"https://api.github.com/repos/magopian/olympia/languages","stargazers_url":"https://api.github.com/repos/magopian/olympia/stargazers","contributors_url":"https://api.github.com/repos/magopian/olympia/contributors","subscribers_url":"https://api.github.com/repos/magopian/olympia/subscribers","subscription_url":"https://api.github.com/repos/magopian/olympia/subscription","commits_url":"https://api.github.com/repos/magopian/olympia/commits{/sha}","git_commits_url":"https://api.github.com/repos/magopian/olympia/git/commits{/sha}","comments_url":"https://api.github.com/repos/magopian/olympia/comments{/number}","issue_comment_url":"https://api.github.com/repos/magopian/olympia/issues/comments{/number}","contents_url":"https://api.github.com/repos/magopian/olympia/contents/{+path}","compare_url":"https://api.github.com/repos/magopian/olympia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magopian/olympia/merges","archive_url":"https://api.github.com/repos/magopian/olympia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magopian/olympia/downloads","issues_url":"https://api.github.com/repos/magopian/olympia/issues{/number}","pulls_url":"https://api.github.com/repos/magopian/olympia/pulls{/number}","milestones_url":"https://api.github.com/repos/magopian/olympia/milestones{/number}","notifications_url":"https://api.github.com/repos/magopian/olympia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magopian/olympia/labels{/name}","releases_url":"https://api.github.com/repos/magopian/olympia/releases{/id}","created_at":"2014-03-12T11:05:51Z","updated_at":"2015-04-24T16:05:25Z","pushed_at":"2015-09-04T21:17:25Z","git_url":"git://github.com/magopian/olympia.git","ssh_url":"git@github.com:magopian/olympia.git","clone_url":"https://github.com/magopian/olympia.git","svn_url":"https://github.com/magopian/olympia","homepage":"","size":415975,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"301f8608df6afceec795d5ec81ab7c8cf6d7fd3e","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":16416867,"name":"olympia","full_name":"mozilla/olympia","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/olympia","description":"addons.mozilla.org, reloaded.","fork":false,"url":"https://api.github.com/repos/mozilla/olympia","forks_url":"https://api.github.com/repos/mozilla/olympia/forks","keys_url":"https://api.github.com/repos/mozilla/olympia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/olympia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/olympia/teams","hooks_url":"https://api.github.com/repos/mozilla/olympia/hooks","issue_events_url":"https://api.github.com/repos/mozilla/olympia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/olympia/events","assignees_url":"https://api.github.com/repos/mozilla/olympia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/olympia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/olympia/tags","blobs_url":"https://api.github.com/repos/mozilla/olympia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/olympia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/olympia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/olympia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/olympia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/olympia/languages","stargazers_url":"https://api.github.com/repos/mozilla/olympia/stargazers","contributors_url":"https://api.github.com/repos/mozilla/olympia/contributors","subscribers_url":"https://api.github.com/repos/mozilla/olympia/subscribers","subscription_url":"https://api.github.com/repos/mozilla/olympia/subscription","commits_url":"https://api.github.com/repos/mozilla/olympia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/olympia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/olympia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/olympia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/olympia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/olympia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/olympia/merges","archive_url":"https://api.github.com/repos/mozilla/olympia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/olympia/downloads","issues_url":"https://api.github.com/repos/mozilla/olympia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/olympia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/olympia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/olympia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/olympia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/olympia/releases{/id}","created_at":"2014-01-31T18:44:15Z","updated_at":"2015-09-01T17:12:45Z","pushed_at":"2015-09-04T21:12:45Z","git_url":"git://github.com/mozilla/olympia.git","ssh_url":"git@github.com:mozilla/olympia.git","clone_url":"https://github.com/mozilla/olympia.git","svn_url":"https://github.com/mozilla/olympia","homepage":"https://addons.mozilla.org/","size":465376,"stargazers_count":50,"watchers_count":50,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":100,"mirror_url":null,"open_issues_count":17,"forks":100,"open_issues":17,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/714"},"html":{"href":"https://github.com/mozilla/olympia/pull/714"},"issue":{"href":"https://api.github.com/repos/mozilla/olympia/issues/714"},"comments":{"href":"https://api.github.com/repos/mozilla/olympia/issues/714/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/714/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/714/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/olympia/statuses/44eba2cfe1721aeff71d48e927ef05b2a6f3d836"}}}}