{"action":"created","comment":{"url":"https://api.github.com/repos/scrapy/scrapy/pulls/comments/42277517","id":42277517,"diff_hunk":"@@ -235,5 +224,33 @@ def _get_uri_params(self, spider):\n             params[k] = getattr(spider, k)\n         ts = datetime.utcnow().replace(microsecond=0).isoformat().replace(':', '-')\n         params['time'] = ts\n+        params['start'] = self.start\n         self._uripar(params, spider)\n         return params\n+\n+    def _start_export(self, spider):","path":"scrapy/extensions/feedexport.py","position":60,"original_position":60,"commit_id":"fa8209fb6b1d673fbb0315bb227f3a45ed7982c3","original_commit_id":"fa8209fb6b1d673fbb0315bb227f3a45ed7982c3","user":{"login":"nhuray","id":958983,"avatar_url":"https://avatars.githubusercontent.com/u/958983?v=3","gravatar_id":"","url":"https://api.github.com/users/nhuray","html_url":"https://github.com/nhuray","followers_url":"https://api.github.com/users/nhuray/followers","following_url":"https://api.github.com/users/nhuray/following{/other_user}","gists_url":"https://api.github.com/users/nhuray/gists{/gist_id}","starred_url":"https://api.github.com/users/nhuray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhuray/subscriptions","organizations_url":"https://api.github.com/users/nhuray/orgs","repos_url":"https://api.github.com/users/nhuray/repos","events_url":"https://api.github.com/users/nhuray/events{/privacy}","received_events_url":"https://api.github.com/users/nhuray/received_events","type":"User","site_admin":false},"body":"That's just syntaxic so I let you decide how you want to name this method","created_at":"2015-10-16T18:56:12Z","updated_at":"2015-10-16T18:56:12Z","html_url":"https://github.com/scrapy/scrapy/pull/1340#discussion_r42277517","pull_request_url":"https://api.github.com/repos/scrapy/scrapy/pulls/1340","_links":{"self":{"href":"https://api.github.com/repos/scrapy/scrapy/pulls/comments/42277517"},"html":{"href":"https://github.com/scrapy/scrapy/pull/1340#discussion_r42277517"},"pull_request":{"href":"https://api.github.com/repos/scrapy/scrapy/pulls/1340"}}},"pull_request":{"url":"https://api.github.com/repos/scrapy/scrapy/pulls/1340","id":39225936,"html_url":"https://github.com/scrapy/scrapy/pull/1340","diff_url":"https://github.com/scrapy/scrapy/pull/1340.diff","patch_url":"https://github.com/scrapy/scrapy/pull/1340.patch","issue_url":"https://api.github.com/repos/scrapy/scrapy/issues/1340","number":1340,"state":"open","locked":false,"title":"Support Batch Feed Export controlling batch size","user":{"login":"nhuray","id":958983,"avatar_url":"https://avatars.githubusercontent.com/u/958983?v=3","gravatar_id":"","url":"https://api.github.com/users/nhuray","html_url":"https://github.com/nhuray","followers_url":"https://api.github.com/users/nhuray/followers","following_url":"https://api.github.com/users/nhuray/following{/other_user}","gists_url":"https://api.github.com/users/nhuray/gists{/gist_id}","starred_url":"https://api.github.com/users/nhuray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhuray/subscriptions","organizations_url":"https://api.github.com/users/nhuray/orgs","repos_url":"https://api.github.com/users/nhuray/repos","events_url":"https://api.github.com/users/nhuray/events{/privacy}","received_events_url":"https://api.github.com/users/nhuray/received_events","type":"User","site_admin":false},"body":"Hi Scrapy Team,\r\n\r\nFor our needs at 1science, we modified the feed exporter to support batch export controlling the size (number of item in a file) with a new settings ```FEED_BATCH_SIZE```.\r\n\r\nWe added a unit test and updated the documentation.\r\n\r\nPlease give me your feedbacks !\r\n\r\nNicolas Huray","created_at":"2015-07-05T19:51:30Z","updated_at":"2015-10-16T18:56:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"263b68060bcae6d72d70aacd9d7f35828a28b153","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scrapy/scrapy/pulls/1340/commits","review_comments_url":"https://api.github.com/repos/scrapy/scrapy/pulls/1340/comments","review_comment_url":"https://api.github.com/repos/scrapy/scrapy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scrapy/scrapy/issues/1340/comments","statuses_url":"https://api.github.com/repos/scrapy/scrapy/statuses/fa8209fb6b1d673fbb0315bb227f3a45ed7982c3","head":{"label":"1science:feedexport","ref":"feedexport","sha":"fa8209fb6b1d673fbb0315bb227f3a45ed7982c3","user":{"login":"1science","id":10089348,"avatar_url":"https://avatars.githubusercontent.com/u/10089348?v=3","gravatar_id":"","url":"https://api.github.com/users/1science","html_url":"https://github.com/1science","followers_url":"https://api.github.com/users/1science/followers","following_url":"https://api.github.com/users/1science/following{/other_user}","gists_url":"https://api.github.com/users/1science/gists{/gist_id}","starred_url":"https://api.github.com/users/1science/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1science/subscriptions","organizations_url":"https://api.github.com/users/1science/orgs","repos_url":"https://api.github.com/users/1science/repos","events_url":"https://api.github.com/users/1science/events{/privacy}","received_events_url":"https://api.github.com/users/1science/received_events","type":"Organization","site_admin":false},"repo":null},"base":{"label":"scrapy:master","ref":"master","sha":"8b3ca4f250b4d831403c7fcfa72efe7ecdfa5247","user":{"login":"scrapy","id":733635,"avatar_url":"https://avatars.githubusercontent.com/u/733635?v=3","gravatar_id":"","url":"https://api.github.com/users/scrapy","html_url":"https://github.com/scrapy","followers_url":"https://api.github.com/users/scrapy/followers","following_url":"https://api.github.com/users/scrapy/following{/other_user}","gists_url":"https://api.github.com/users/scrapy/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapy/subscriptions","organizations_url":"https://api.github.com/users/scrapy/orgs","repos_url":"https://api.github.com/users/scrapy/repos","events_url":"https://api.github.com/users/scrapy/events{/privacy}","received_events_url":"https://api.github.com/users/scrapy/received_events","type":"Organization","site_admin":false},"repo":{"id":529502,"name":"scrapy","full_name":"scrapy/scrapy","owner":{"login":"scrapy","id":733635,"avatar_url":"https://avatars.githubusercontent.com/u/733635?v=3","gravatar_id":"","url":"https://api.github.com/users/scrapy","html_url":"https://github.com/scrapy","followers_url":"https://api.github.com/users/scrapy/followers","following_url":"https://api.github.com/users/scrapy/following{/other_user}","gists_url":"https://api.github.com/users/scrapy/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapy/subscriptions","organizations_url":"https://api.github.com/users/scrapy/orgs","repos_url":"https://api.github.com/users/scrapy/repos","events_url":"https://api.github.com/users/scrapy/events{/privacy}","received_events_url":"https://api.github.com/users/scrapy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scrapy/scrapy","description":"Scrapy, a fast high-level web crawling & scraping framework for Python.","fork":false,"url":"https://api.github.com/repos/scrapy/scrapy","forks_url":"https://api.github.com/repos/scrapy/scrapy/forks","keys_url":"https://api.github.com/repos/scrapy/scrapy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scrapy/scrapy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scrapy/scrapy/teams","hooks_url":"https://api.github.com/repos/scrapy/scrapy/hooks","issue_events_url":"https://api.github.com/repos/scrapy/scrapy/issues/events{/number}","events_url":"https://api.github.com/repos/scrapy/scrapy/events","assignees_url":"https://api.github.com/repos/scrapy/scrapy/assignees{/user}","branches_url":"https://api.github.com/repos/scrapy/scrapy/branches{/branch}","tags_url":"https://api.github.com/repos/scrapy/scrapy/tags","blobs_url":"https://api.github.com/repos/scrapy/scrapy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scrapy/scrapy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scrapy/scrapy/git/refs{/sha}","trees_url":"https://api.github.com/repos/scrapy/scrapy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scrapy/scrapy/statuses/{sha}","languages_url":"https://api.github.com/repos/scrapy/scrapy/languages","stargazers_url":"https://api.github.com/repos/scrapy/scrapy/stargazers","contributors_url":"https://api.github.com/repos/scrapy/scrapy/contributors","subscribers_url":"https://api.github.com/repos/scrapy/scrapy/subscribers","subscription_url":"https://api.github.com/repos/scrapy/scrapy/subscription","commits_url":"https://api.github.com/repos/scrapy/scrapy/commits{/sha}","git_commits_url":"https://api.github.com/repos/scrapy/scrapy/git/commits{/sha}","comments_url":"https://api.github.com/repos/scrapy/scrapy/comments{/number}","issue_comment_url":"https://api.github.com/repos/scrapy/scrapy/issues/comments{/number}","contents_url":"https://api.github.com/repos/scrapy/scrapy/contents/{+path}","compare_url":"https://api.github.com/repos/scrapy/scrapy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scrapy/scrapy/merges","archive_url":"https://api.github.com/repos/scrapy/scrapy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scrapy/scrapy/downloads","issues_url":"https://api.github.com/repos/scrapy/scrapy/issues{/number}","pulls_url":"https://api.github.com/repos/scrapy/scrapy/pulls{/number}","milestones_url":"https://api.github.com/repos/scrapy/scrapy/milestones{/number}","notifications_url":"https://api.github.com/repos/scrapy/scrapy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scrapy/scrapy/labels{/name}","releases_url":"https://api.github.com/repos/scrapy/scrapy/releases{/id}","created_at":"2010-02-22T02:01:14Z","updated_at":"2015-10-16T16:49:40Z","pushed_at":"2015-10-16T00:40:20Z","git_url":"git://github.com/scrapy/scrapy.git","ssh_url":"git@github.com:scrapy/scrapy.git","clone_url":"https://github.com/scrapy/scrapy.git","svn_url":"https://github.com/scrapy/scrapy","homepage":"http://scrapy.org","size":28845,"stargazers_count":10647,"watchers_count":10647,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":3070,"mirror_url":null,"open_issues_count":295,"forks":3070,"open_issues":295,"watchers":10647,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scrapy/scrapy/pulls/1340"},"html":{"href":"https://github.com/scrapy/scrapy/pull/1340"},"issue":{"href":"https://api.github.com/repos/scrapy/scrapy/issues/1340"},"comments":{"href":"https://api.github.com/repos/scrapy/scrapy/issues/1340/comments"},"review_comments":{"href":"https://api.github.com/repos/scrapy/scrapy/pulls/1340/comments"},"review_comment":{"href":"https://api.github.com/repos/scrapy/scrapy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scrapy/scrapy/pulls/1340/commits"},"statuses":{"href":"https://api.github.com/repos/scrapy/scrapy/statuses/fa8209fb6b1d673fbb0315bb227f3a45ed7982c3"}}}}