{"action":"created","issue":{"url":"https://api.github.com/repos/weaveworks/weave/issues/1473","labels_url":"https://api.github.com/repos/weaveworks/weave/issues/1473/labels{/name}","comments_url":"https://api.github.com/repos/weaveworks/weave/issues/1473/comments","events_url":"https://api.github.com/repos/weaveworks/weave/issues/1473/events","html_url":"https://github.com/weaveworks/weave/issues/1473","id":108345876,"number":1473,"title":"`weave status` shows incorrect 'connections between' count","user":{"login":"awh","id":1504438,"avatar_url":"https://avatars.githubusercontent.com/u/1504438?v=3","gravatar_id":"","url":"https://api.github.com/users/awh","html_url":"https://github.com/awh","followers_url":"https://api.github.com/users/awh/followers","following_url":"https://api.github.com/users/awh/following{/other_user}","gists_url":"https://api.github.com/users/awh/gists{/gist_id}","starred_url":"https://api.github.com/users/awh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awh/subscriptions","organizations_url":"https://api.github.com/users/awh/orgs","repos_url":"https://api.github.com/users/awh/repos","events_url":"https://api.github.com/users/awh/events{/privacy}","received_events_url":"https://api.github.com/users/awh/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/weaveworks/weave/labels/chore","name":"chore","color":"207de5"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-09-25T15:17:27Z","updated_at":"2015-09-28T10:27:29Z","closed_at":null,"body":"With two peers:\r\n````\r\n$ weave status\r\n\r\n       Version: git-0cf3de454106\r\n\r\n       Service: router\r\n      Protocol: weave 1..2\r\n          Name: 6a:7e:6e:d2:5e:17(host1)\r\n    Encryption: disabled\r\n PeerDiscovery: enabled\r\n       Targets: 0\r\n   Connections: 1 (1 established)\r\n         Peers: 2 (with 2 established connections between them)\r\n````\r\nWith three peers:\r\n````\r\n$ weave status\r\n\r\n       Version: git-0cf3de454106\r\n\r\n       Service: router\r\n      Protocol: weave 1..2\r\n          Name: 56:26:d9:97:69:2e(host1)\r\n    Encryption: disabled\r\n PeerDiscovery: enabled\r\n       Targets: 0\r\n   Connections: 2 (2 established)\r\n         Peers: 3 (with 6 established connections between them)\r\n\r\n````"},"comment":{"url":"https://api.github.com/repos/weaveworks/weave/issues/comments/143702650","html_url":"https://github.com/weaveworks/weave/issues/1473#issuecomment-143702650","issue_url":"https://api.github.com/repos/weaveworks/weave/issues/1473","id":143702650,"user":{"login":"dpw","id":15074,"avatar_url":"https://avatars.githubusercontent.com/u/15074?v=3","gravatar_id":"","url":"https://api.github.com/users/dpw","html_url":"https://github.com/dpw","followers_url":"https://api.github.com/users/dpw/followers","following_url":"https://api.github.com/users/dpw/following{/other_user}","gists_url":"https://api.github.com/users/dpw/gists{/gist_id}","starred_url":"https://api.github.com/users/dpw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpw/subscriptions","organizations_url":"https://api.github.com/users/dpw/orgs","repos_url":"https://api.github.com/users/dpw/repos","events_url":"https://api.github.com/users/dpw/events{/privacy}","received_events_url":"https://api.github.com/users/dpw/received_events","type":"User","site_admin":false},"created_at":"2015-09-28T10:27:29Z","updated_at":"2015-09-28T10:27:29Z","body":"The conventional use of the word connection is a two-ended thing.  E.g., from RFC793:\r\n> Each connection is uniquely specified by a pair of sockets identifying its two sides.\r\n\r\nWe can take some liberty in defining what we mean by terms within the codebase (though I think that tendency should be restrained).  But when it comes to information presented to users, it's better to stick to conventional terms.  The number of connections we present could be those fully connected ones, with a count of failed and otherwise unestablished ones presented separately."}}