{"action":"created","comment":{"url":"https://api.github.com/repos/wandernauta/viskell/pulls/comments/33412560","id":33412560,"diff_hunk":"@@ -72,10 +94,29 @@ private void inputPressed(int inputId){\n \t\t}\n \t}\n \t\n+    /**\n+     * Method to indicate that the input moved.\n+     * \n+     * @param inputId\n+     *            The id associated with the input that triggered this action.\n+     * @param x\n+     *            The sceneX coordinate of the input.\n+     * @param y\n+     *            The sceneY coordinate of the input.\n+     */\n \tprivate void inputMoved(int inputId, double x, double y){\n \t\tmanager.updateLine(inputId, x, y);\n \t}\n \t\n+\t    /**","path":"Code/src/main/java/nl/utwente/group10/ui/handlers/AnchorHandler.java","position":93,"original_position":93,"commit_id":"91906463e717a17a3540405a5633246af089ac77","original_commit_id":"91906463e717a17a3540405a5633246af089ac77","user":{"login":"i3anaan","id":2911348,"avatar_url":"https://avatars.githubusercontent.com/u/2911348?v=3","gravatar_id":"","url":"https://api.github.com/users/i3anaan","html_url":"https://github.com/i3anaan","followers_url":"https://api.github.com/users/i3anaan/followers","following_url":"https://api.github.com/users/i3anaan/following{/other_user}","gists_url":"https://api.github.com/users/i3anaan/gists{/gist_id}","starred_url":"https://api.github.com/users/i3anaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/i3anaan/subscriptions","organizations_url":"https://api.github.com/users/i3anaan/orgs","repos_url":"https://api.github.com/users/i3anaan/repos","events_url":"https://api.github.com/users/i3anaan/events{/privacy}","received_events_url":"https://api.github.com/users/i3anaan/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2015-06-27T12:59:07Z","updated_at":"2015-06-27T12:59:07Z","html_url":"https://github.com/wandernauta/viskell/pull/120#discussion_r33412560","pull_request_url":"https://api.github.com/repos/wandernauta/viskell/pulls/120","_links":{"self":{"href":"https://api.github.com/repos/wandernauta/viskell/pulls/comments/33412560"},"html":{"href":"https://github.com/wandernauta/viskell/pull/120#discussion_r33412560"},"pull_request":{"href":"https://api.github.com/repos/wandernauta/viskell/pulls/120"}}},"pull_request":{"url":"https://api.github.com/repos/wandernauta/viskell/pulls/120","id":38696667,"html_url":"https://github.com/wandernauta/viskell/pull/120","diff_url":"https://github.com/wandernauta/viskell/pull/120.diff","patch_url":"https://github.com/wandernauta/viskell/pull/120.patch","issue_url":"https://api.github.com/repos/wandernauta/viskell/issues/120","number":120,"state":"open","locked":false,"title":"Massive UI cleanup, refactoring and documentation","user":{"login":"i3anaan","id":2911348,"avatar_url":"https://avatars.githubusercontent.com/u/2911348?v=3","gravatar_id":"","url":"https://api.github.com/users/i3anaan","html_url":"https://github.com/i3anaan","followers_url":"https://api.github.com/users/i3anaan/followers","following_url":"https://api.github.com/users/i3anaan/following{/other_user}","gists_url":"https://api.github.com/users/i3anaan/gists{/gist_id}","starred_url":"https://api.github.com/users/i3anaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/i3anaan/subscriptions","organizations_url":"https://api.github.com/users/i3anaan/orgs","repos_url":"https://api.github.com/users/i3anaan/repos","events_url":"https://api.github.com/users/i3anaan/events{/privacy}","received_events_url":"https://api.github.com/users/i3anaan/received_events","type":"User","site_admin":false},"body":"Lots of changes, probably more then I can remember.\r\n- Overall lots of cleanup of code and refactoring and better javaFX usage.\r\n- Documentation for most UI classes\r\n- ConnectionAnchors now have a signature, and will typecheck this themselves.\r\n- Error state checking is now also moved to a property inside ConnectionAnchors.\r\n- Block error state is removed.\r\n- Moved the ConnectionState methods to a ConnectionStateDependent interface.\r\n- ConnectionAnchors now implement the ConnectionStateDependent interface.\r\n- Simplified the InputBlock and OutputBlock interfaces.\r\n- Renamed bowtie and bowtieIndex to knot and knotIndex\r\n- Some small fixes to the UI related to updating.\r\n\r\nThings not included in this PR:\r\n- Better Type propagation\r\n- Fix for the Type display issue\r\n- Fix for the CircleMenu\r\n- Cleanup and Documentation for the UI menu classes and the UI (general) classes\r\n- import cleanup\r\n\r\n\r\n","created_at":"2015-06-26T22:56:39Z","updated_at":"2015-06-27T12:59:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wandernauta/viskell/pulls/120/commits","review_comments_url":"https://api.github.com/repos/wandernauta/viskell/pulls/120/comments","review_comment_url":"https://api.github.com/repos/wandernauta/viskell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wandernauta/viskell/issues/120/comments","statuses_url":"https://api.github.com/repos/wandernauta/viskell/statuses/91906463e717a17a3540405a5633246af089ac77","head":{"label":"wandernauta:ui-types-bowtie","ref":"ui-types-bowtie","sha":"91906463e717a17a3540405a5633246af089ac77","user":{"login":"wandernauta","id":126832,"avatar_url":"https://avatars.githubusercontent.com/u/126832?v=3","gravatar_id":"","url":"https://api.github.com/users/wandernauta","html_url":"https://github.com/wandernauta","followers_url":"https://api.github.com/users/wandernauta/followers","following_url":"https://api.github.com/users/wandernauta/following{/other_user}","gists_url":"https://api.github.com/users/wandernauta/gists{/gist_id}","starred_url":"https://api.github.com/users/wandernauta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wandernauta/subscriptions","organizations_url":"https://api.github.com/users/wandernauta/orgs","repos_url":"https://api.github.com/users/wandernauta/repos","events_url":"https://api.github.com/users/wandernauta/events{/privacy}","received_events_url":"https://api.github.com/users/wandernauta/received_events","type":"User","site_admin":false},"repo":{"id":30242992,"name":"viskell","full_name":"wandernauta/viskell","owner":{"login":"wandernauta","id":126832,"avatar_url":"https://avatars.githubusercontent.com/u/126832?v=3","gravatar_id":"","url":"https://api.github.com/users/wandernauta","html_url":"https://github.com/wandernauta","followers_url":"https://api.github.com/users/wandernauta/followers","following_url":"https://api.github.com/users/wandernauta/following{/other_user}","gists_url":"https://api.github.com/users/wandernauta/gists{/gist_id}","starred_url":"https://api.github.com/users/wandernauta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wandernauta/subscriptions","organizations_url":"https://api.github.com/users/wandernauta/orgs","repos_url":"https://api.github.com/users/wandernauta/repos","events_url":"https://api.github.com/users/wandernauta/events{/privacy}","received_events_url":"https://api.github.com/users/wandernauta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wandernauta/viskell","description":"Ontwerpproject.","fork":false,"url":"https://api.github.com/repos/wandernauta/viskell","forks_url":"https://api.github.com/repos/wandernauta/viskell/forks","keys_url":"https://api.github.com/repos/wandernauta/viskell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wandernauta/viskell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wandernauta/viskell/teams","hooks_url":"https://api.github.com/repos/wandernauta/viskell/hooks","issue_events_url":"https://api.github.com/repos/wandernauta/viskell/issues/events{/number}","events_url":"https://api.github.com/repos/wandernauta/viskell/events","assignees_url":"https://api.github.com/repos/wandernauta/viskell/assignees{/user}","branches_url":"https://api.github.com/repos/wandernauta/viskell/branches{/branch}","tags_url":"https://api.github.com/repos/wandernauta/viskell/tags","blobs_url":"https://api.github.com/repos/wandernauta/viskell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wandernauta/viskell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wandernauta/viskell/git/refs{/sha}","trees_url":"https://api.github.com/repos/wandernauta/viskell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wandernauta/viskell/statuses/{sha}","languages_url":"https://api.github.com/repos/wandernauta/viskell/languages","stargazers_url":"https://api.github.com/repos/wandernauta/viskell/stargazers","contributors_url":"https://api.github.com/repos/wandernauta/viskell/contributors","subscribers_url":"https://api.github.com/repos/wandernauta/viskell/subscribers","subscription_url":"https://api.github.com/repos/wandernauta/viskell/subscription","commits_url":"https://api.github.com/repos/wandernauta/viskell/commits{/sha}","git_commits_url":"https://api.github.com/repos/wandernauta/viskell/git/commits{/sha}","comments_url":"https://api.github.com/repos/wandernauta/viskell/comments{/number}","issue_comment_url":"https://api.github.com/repos/wandernauta/viskell/issues/comments{/number}","contents_url":"https://api.github.com/repos/wandernauta/viskell/contents/{+path}","compare_url":"https://api.github.com/repos/wandernauta/viskell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wandernauta/viskell/merges","archive_url":"https://api.github.com/repos/wandernauta/viskell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wandernauta/viskell/downloads","issues_url":"https://api.github.com/repos/wandernauta/viskell/issues{/number}","pulls_url":"https://api.github.com/repos/wandernauta/viskell/pulls{/number}","milestones_url":"https://api.github.com/repos/wandernauta/viskell/milestones{/number}","notifications_url":"https://api.github.com/repos/wandernauta/viskell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wandernauta/viskell/labels{/name}","releases_url":"https://api.github.com/repos/wandernauta/viskell/releases{/id}","created_at":"2015-02-03T13:04:49Z","updated_at":"2015-06-09T07:28:51Z","pushed_at":"2015-06-27T12:55:14Z","git_url":"git://github.com/wandernauta/viskell.git","ssh_url":"git@github.com:wandernauta/viskell.git","clone_url":"https://github.com/wandernauta/viskell.git","svn_url":"https://github.com/wandernauta/viskell","homepage":null,"size":4781,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":18,"forks":0,"open_issues":18,"watchers":0,"default_branch":"master"}},"base":{"label":"wandernauta:master","ref":"master","sha":"2c80afdde5fd372042583793c2928f7beda6a4e3","user":{"login":"wandernauta","id":126832,"avatar_url":"https://avatars.githubusercontent.com/u/126832?v=3","gravatar_id":"","url":"https://api.github.com/users/wandernauta","html_url":"https://github.com/wandernauta","followers_url":"https://api.github.com/users/wandernauta/followers","following_url":"https://api.github.com/users/wandernauta/following{/other_user}","gists_url":"https://api.github.com/users/wandernauta/gists{/gist_id}","starred_url":"https://api.github.com/users/wandernauta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wandernauta/subscriptions","organizations_url":"https://api.github.com/users/wandernauta/orgs","repos_url":"https://api.github.com/users/wandernauta/repos","events_url":"https://api.github.com/users/wandernauta/events{/privacy}","received_events_url":"https://api.github.com/users/wandernauta/received_events","type":"User","site_admin":false},"repo":{"id":30242992,"name":"viskell","full_name":"wandernauta/viskell","owner":{"login":"wandernauta","id":126832,"avatar_url":"https://avatars.githubusercontent.com/u/126832?v=3","gravatar_id":"","url":"https://api.github.com/users/wandernauta","html_url":"https://github.com/wandernauta","followers_url":"https://api.github.com/users/wandernauta/followers","following_url":"https://api.github.com/users/wandernauta/following{/other_user}","gists_url":"https://api.github.com/users/wandernauta/gists{/gist_id}","starred_url":"https://api.github.com/users/wandernauta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wandernauta/subscriptions","organizations_url":"https://api.github.com/users/wandernauta/orgs","repos_url":"https://api.github.com/users/wandernauta/repos","events_url":"https://api.github.com/users/wandernauta/events{/privacy}","received_events_url":"https://api.github.com/users/wandernauta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wandernauta/viskell","description":"Ontwerpproject.","fork":false,"url":"https://api.github.com/repos/wandernauta/viskell","forks_url":"https://api.github.com/repos/wandernauta/viskell/forks","keys_url":"https://api.github.com/repos/wandernauta/viskell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wandernauta/viskell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wandernauta/viskell/teams","hooks_url":"https://api.github.com/repos/wandernauta/viskell/hooks","issue_events_url":"https://api.github.com/repos/wandernauta/viskell/issues/events{/number}","events_url":"https://api.github.com/repos/wandernauta/viskell/events","assignees_url":"https://api.github.com/repos/wandernauta/viskell/assignees{/user}","branches_url":"https://api.github.com/repos/wandernauta/viskell/branches{/branch}","tags_url":"https://api.github.com/repos/wandernauta/viskell/tags","blobs_url":"https://api.github.com/repos/wandernauta/viskell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wandernauta/viskell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wandernauta/viskell/git/refs{/sha}","trees_url":"https://api.github.com/repos/wandernauta/viskell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wandernauta/viskell/statuses/{sha}","languages_url":"https://api.github.com/repos/wandernauta/viskell/languages","stargazers_url":"https://api.github.com/repos/wandernauta/viskell/stargazers","contributors_url":"https://api.github.com/repos/wandernauta/viskell/contributors","subscribers_url":"https://api.github.com/repos/wandernauta/viskell/subscribers","subscription_url":"https://api.github.com/repos/wandernauta/viskell/subscription","commits_url":"https://api.github.com/repos/wandernauta/viskell/commits{/sha}","git_commits_url":"https://api.github.com/repos/wandernauta/viskell/git/commits{/sha}","comments_url":"https://api.github.com/repos/wandernauta/viskell/comments{/number}","issue_comment_url":"https://api.github.com/repos/wandernauta/viskell/issues/comments{/number}","contents_url":"https://api.github.com/repos/wandernauta/viskell/contents/{+path}","compare_url":"https://api.github.com/repos/wandernauta/viskell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wandernauta/viskell/merges","archive_url":"https://api.github.com/repos/wandernauta/viskell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wandernauta/viskell/downloads","issues_url":"https://api.github.com/repos/wandernauta/viskell/issues{/number}","pulls_url":"https://api.github.com/repos/wandernauta/viskell/pulls{/number}","milestones_url":"https://api.github.com/repos/wandernauta/viskell/milestones{/number}","notifications_url":"https://api.github.com/repos/wandernauta/viskell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wandernauta/viskell/labels{/name}","releases_url":"https://api.github.com/repos/wandernauta/viskell/releases{/id}","created_at":"2015-02-03T13:04:49Z","updated_at":"2015-06-09T07:28:51Z","pushed_at":"2015-06-27T12:55:14Z","git_url":"git://github.com/wandernauta/viskell.git","ssh_url":"git@github.com:wandernauta/viskell.git","clone_url":"https://github.com/wandernauta/viskell.git","svn_url":"https://github.com/wandernauta/viskell","homepage":null,"size":4781,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":18,"forks":0,"open_issues":18,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wandernauta/viskell/pulls/120"},"html":{"href":"https://github.com/wandernauta/viskell/pull/120"},"issue":{"href":"https://api.github.com/repos/wandernauta/viskell/issues/120"},"comments":{"href":"https://api.github.com/repos/wandernauta/viskell/issues/120/comments"},"review_comments":{"href":"https://api.github.com/repos/wandernauta/viskell/pulls/120/comments"},"review_comment":{"href":"https://api.github.com/repos/wandernauta/viskell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wandernauta/viskell/pulls/120/commits"},"statuses":{"href":"https://api.github.com/repos/wandernauta/viskell/statuses/91906463e717a17a3540405a5633246af089ac77"}}}}