{"action":"closed","number":9772,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/9772","id":26445956,"html_url":"https://github.com/docker/docker/pull/9772","diff_url":"https://github.com/docker/docker/pull/9772.diff","patch_url":"https://github.com/docker/docker/pull/9772.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/9772","number":9772,"state":"closed","locked":false,"title":"Minor readability change to TagStore.pullImage","user":{"login":"pwaller","id":438648,"avatar_url":"https://avatars.githubusercontent.com/u/438648?v=3","gravatar_id":"","url":"https://api.github.com/users/pwaller","html_url":"https://github.com/pwaller","followers_url":"https://api.github.com/users/pwaller/followers","following_url":"https://api.github.com/users/pwaller/following{/other_user}","gists_url":"https://api.github.com/users/pwaller/gists{/gist_id}","starred_url":"https://api.github.com/users/pwaller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwaller/subscriptions","organizations_url":"https://api.github.com/users/pwaller/orgs","repos_url":"https://api.github.com/users/pwaller/repos","events_url":"https://api.github.com/users/pwaller/events{/privacy}","received_events_url":"https://api.github.com/users/pwaller/received_events","type":"User","site_admin":false},"body":"This is almost entirely a whitespace change from:\r\n\r\n```go\r\nfor foo {\r\n    if !condition {\r\n        <large amount of code>\r\n    }\r\n    <done>\r\n}\r\n```\r\n\r\nTo:\r\n\r\n```go\r\nfor foo {\r\n    if condition {\r\n        <done>\r\n        continue\r\n    }\r\n    <large amount of code>\r\n    <done>\r\n}\r\n```\r\n\r\nIt's a small stepwise change which improves the readability of the code.\r\nIt makes it so you don't have to skip over `<large amount of code>` to\r\nsee the `condition == true` outcome, improving locality, and removes a\r\nlayer of indentation to `<large amount of code>`.\r\n\r\nI'm making this change in advance of other proposed changes I have inbound for this code relating to cancelling builds and pulls.\r\n\r\n/cc @shykes (original author)\r\n\r\nDocker-DCO-1.1-Signed-off-by: Peter Waller <p@pwaller.net> (github: pwaller)","created_at":"2014-12-22T09:18:53Z","updated_at":"2015-01-06T18:25:54Z","closed_at":"2015-01-06T18:25:54Z","merged_at":null,"merge_commit_sha":"12b6516a926660bccc1ec26bcdf39f9ecf3abf56","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/9772/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/9772/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments/{number}","comments_url":"https://api.github.com/repos/docker/docker/issues/9772/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/a1b9b6323e4a8fb38726804f458fabe00d0b1028","head":{"label":"pwaller:minor-readability-improvement","ref":"minor-readability-improvement","sha":"a1b9b6323e4a8fb38726804f458fabe00d0b1028","user":{"login":"pwaller","id":438648,"avatar_url":"https://avatars.githubusercontent.com/u/438648?v=3","gravatar_id":"","url":"https://api.github.com/users/pwaller","html_url":"https://github.com/pwaller","followers_url":"https://api.github.com/users/pwaller/followers","following_url":"https://api.github.com/users/pwaller/following{/other_user}","gists_url":"https://api.github.com/users/pwaller/gists{/gist_id}","starred_url":"https://api.github.com/users/pwaller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwaller/subscriptions","organizations_url":"https://api.github.com/users/pwaller/orgs","repos_url":"https://api.github.com/users/pwaller/repos","events_url":"https://api.github.com/users/pwaller/events{/privacy}","received_events_url":"https://api.github.com/users/pwaller/received_events","type":"User","site_admin":false},"repo":{"id":16286332,"name":"docker","full_name":"pwaller/docker","owner":{"login":"pwaller","id":438648,"avatar_url":"https://avatars.githubusercontent.com/u/438648?v=3","gravatar_id":"","url":"https://api.github.com/users/pwaller","html_url":"https://github.com/pwaller","followers_url":"https://api.github.com/users/pwaller/followers","following_url":"https://api.github.com/users/pwaller/following{/other_user}","gists_url":"https://api.github.com/users/pwaller/gists{/gist_id}","starred_url":"https://api.github.com/users/pwaller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwaller/subscriptions","organizations_url":"https://api.github.com/users/pwaller/orgs","repos_url":"https://api.github.com/users/pwaller/repos","events_url":"https://api.github.com/users/pwaller/events{/privacy}","received_events_url":"https://api.github.com/users/pwaller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pwaller/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/pwaller/docker","forks_url":"https://api.github.com/repos/pwaller/docker/forks","keys_url":"https://api.github.com/repos/pwaller/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pwaller/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pwaller/docker/teams","hooks_url":"https://api.github.com/repos/pwaller/docker/hooks","issue_events_url":"https://api.github.com/repos/pwaller/docker/issues/events{/number}","events_url":"https://api.github.com/repos/pwaller/docker/events","assignees_url":"https://api.github.com/repos/pwaller/docker/assignees{/user}","branches_url":"https://api.github.com/repos/pwaller/docker/branches{/branch}","tags_url":"https://api.github.com/repos/pwaller/docker/tags","blobs_url":"https://api.github.com/repos/pwaller/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pwaller/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pwaller/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/pwaller/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pwaller/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/pwaller/docker/languages","stargazers_url":"https://api.github.com/repos/pwaller/docker/stargazers","contributors_url":"https://api.github.com/repos/pwaller/docker/contributors","subscribers_url":"https://api.github.com/repos/pwaller/docker/subscribers","subscription_url":"https://api.github.com/repos/pwaller/docker/subscription","commits_url":"https://api.github.com/repos/pwaller/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/pwaller/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/pwaller/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/pwaller/docker/issues/comments/{number}","contents_url":"https://api.github.com/repos/pwaller/docker/contents/{+path}","compare_url":"https://api.github.com/repos/pwaller/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pwaller/docker/merges","archive_url":"https://api.github.com/repos/pwaller/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pwaller/docker/downloads","issues_url":"https://api.github.com/repos/pwaller/docker/issues{/number}","pulls_url":"https://api.github.com/repos/pwaller/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/pwaller/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/pwaller/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pwaller/docker/labels{/name}","releases_url":"https://api.github.com/repos/pwaller/docker/releases{/id}","created_at":"2014-01-27T17:22:29Z","updated_at":"2014-07-24T21:22:37Z","pushed_at":"2015-01-06T11:45:33Z","git_url":"git://github.com/pwaller/docker.git","ssh_url":"git@github.com:pwaller/docker.git","clone_url":"https://github.com/pwaller/docker.git","svn_url":"https://github.com/pwaller/docker","homepage":"http://www.docker.io","size":37871,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"0874f9ab77a7957633cd835241a76ee4406196d8","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments/{number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-01-06T18:21:58Z","pushed_at":"2015-01-06T18:09:22Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":123245,"stargazers_count":18156,"watchers_count":18156,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3685,"mirror_url":null,"open_issues_count":998,"forks":3685,"open_issues":998,"watchers":18156,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/9772"},"html":{"href":"https://github.com/docker/docker/pull/9772"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/9772"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/9772/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/9772/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/9772/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/a1b9b6323e4a8fb38726804f458fabe00d0b1028"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":2,"commits":1,"additions":65,"deletions":61,"changed_files":1}}