{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/presto/issues/4032","labels_url":"https://api.github.com/repos/facebook/presto/issues/4032/labels{/name}","comments_url":"https://api.github.com/repos/facebook/presto/issues/4032/comments","events_url":"https://api.github.com/repos/facebook/presto/issues/4032/events","html_url":"https://github.com/facebook/presto/pull/4032","id":118743372,"number":4032,"title":"Do not constant fold failures in conditional expressions","user":{"login":"nileema","id":1034143,"avatar_url":"https://avatars.githubusercontent.com/u/1034143?v=3","gravatar_id":"","url":"https://api.github.com/users/nileema","html_url":"https://github.com/nileema","followers_url":"https://api.github.com/users/nileema/followers","following_url":"https://api.github.com/users/nileema/following{/other_user}","gists_url":"https://api.github.com/users/nileema/gists{/gist_id}","starred_url":"https://api.github.com/users/nileema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nileema/subscriptions","organizations_url":"https://api.github.com/users/nileema/orgs","repos_url":"https://api.github.com/users/nileema/repos","events_url":"https://api.github.com/users/nileema/events{/privacy}","received_events_url":"https://api.github.com/users/nileema/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/presto/labels/CLA%20Signed","name":"CLA Signed","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"haozhun","id":2020503,"avatar_url":"https://avatars.githubusercontent.com/u/2020503?v=3","gravatar_id":"","url":"https://api.github.com/users/haozhun","html_url":"https://github.com/haozhun","followers_url":"https://api.github.com/users/haozhun/followers","following_url":"https://api.github.com/users/haozhun/following{/other_user}","gists_url":"https://api.github.com/users/haozhun/gists{/gist_id}","starred_url":"https://api.github.com/users/haozhun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haozhun/subscriptions","organizations_url":"https://api.github.com/users/haozhun/orgs","repos_url":"https://api.github.com/users/haozhun/repos","events_url":"https://api.github.com/users/haozhun/events{/privacy}","received_events_url":"https://api.github.com/users/haozhun/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-11-25T01:59:22Z","updated_at":"2015-11-25T02:05:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/presto/pulls/4032","html_url":"https://github.com/facebook/presto/pull/4032","diff_url":"https://github.com/facebook/presto/pull/4032.diff","patch_url":"https://github.com/facebook/presto/pull/4032.patch"},"body":"Failures are constant folded to FailureFunction with UNKNOWN type\r\nThis causes the failure function to be replaced by NULL in the\r\nExpressionOptimizer, causing incorrect results. Leave the failed\r\nexpression as is and constant fold all other expressions"},"comment":{"url":"https://api.github.com/repos/facebook/presto/issues/comments/159464349","html_url":"https://github.com/facebook/presto/pull/4032#issuecomment-159464349","issue_url":"https://api.github.com/repos/facebook/presto/issues/4032","id":159464349,"user":{"login":"haozhun","id":2020503,"avatar_url":"https://avatars.githubusercontent.com/u/2020503?v=3","gravatar_id":"","url":"https://api.github.com/users/haozhun","html_url":"https://github.com/haozhun","followers_url":"https://api.github.com/users/haozhun/followers","following_url":"https://api.github.com/users/haozhun/following{/other_user}","gists_url":"https://api.github.com/users/haozhun/gists{/gist_id}","starred_url":"https://api.github.com/users/haozhun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haozhun/subscriptions","organizations_url":"https://api.github.com/users/haozhun/orgs","repos_url":"https://api.github.com/users/haozhun/repos","events_url":"https://api.github.com/users/haozhun/events{/privacy}","received_events_url":"https://api.github.com/users/haozhun/received_events","type":"User","site_admin":false},"created_at":"2015-11-25T02:05:55Z","updated_at":"2015-11-25T02:05:55Z","body":"I don't understand why you chose to remove many of the tests. Other than that, the code seems good to me.\r\n\r\nBut I think it's worth discussing this change with @dain, @martint and see what they think."}}