{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-platform/issues/9666","labels_url":"https://api.github.com/repos/edx/edx-platform/issues/9666/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/9666/comments","events_url":"https://api.github.com/repos/edx/edx-platform/issues/9666/events","html_url":"https://github.com/edx/edx-platform/pull/9666","id":105474155,"number":9666,"title":"(WIP) Discussion post cleanup (in preparation for post author images support)","user":{"login":"marcotuts","id":2023680,"avatar_url":"https://avatars.githubusercontent.com/u/2023680?v=3","gravatar_id":"","url":"https://api.github.com/users/marcotuts","html_url":"https://github.com/marcotuts","followers_url":"https://api.github.com/users/marcotuts/followers","following_url":"https://api.github.com/users/marcotuts/following{/other_user}","gists_url":"https://api.github.com/users/marcotuts/gists{/gist_id}","starred_url":"https://api.github.com/users/marcotuts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcotuts/subscriptions","organizations_url":"https://api.github.com/users/marcotuts/orgs","repos_url":"https://api.github.com/users/marcotuts/repos","events_url":"https://api.github.com/users/marcotuts/events{/privacy}","received_events_url":"https://api.github.com/users/marcotuts/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-09-08T21:36:15Z","updated_at":"2015-09-16T13:51:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/9666","html_url":"https://github.com/edx/edx-platform/pull/9666","diff_url":"https://github.com/edx/edx-platform/pull/9666.diff","patch_url":"https://github.com/edx/edx-platform/pull/9666.patch"},"body":"**Description**\r\nA cleanup of the discussion forum styling in preparation for adding in profile images to posts. While the screenshots show images, this detail was removed from the final PR, as it requires follow-up engineering work. \r\n \r\n- - -\r\n \r\n**JIRA Story** ([UX-2586](https://openedx.atlassian.net/browse/UX-2586))\r\n**Confluence / Product Asset** N/A \r\n**Sandbox URL** (Last Updated: 9/16, 9am) ([pr9666.sandbox.edx.org](http://pr9666.sandbox.edx.org)) \r\n**Dependencies** N/A\r\n \r\n- - -\r\n**In Progress Cleanup Changes List** \r\nA number of forums bugs and visual issues are addressed in this cleanup, in addition to what was necessary to preparation for discussion forum post images. This was done in part to reduce the amount of churn on reviews and other issues from resolving these visual issues in separate PRs. In order to provide more clarity on what the changes were, I've detailed them here below.\r\n\r\nSASS Breakdown / General Cleanup\r\n* Moved response and comment styles out of the deprecated _discussion.scss into _response.scss, with some cleanup done to bring these styles in line with our sass style guidelines\r\n* Moved styles for the discussion home grid out of the deprecated _discussion.scss as well. \r\n* In general, moved rules that weren't correctly using bi-app rtl friendly rules on the discussion forums over to using the correct includes.\r\n* Addition of classes to the underscore templates to move away from element based styles within threads. \r\n\r\nEditing Posts, Responses, Comments\r\n* Removed min-width rule (and other similar rules) causing styling issues on editing of posts. \r\n* Changed default (pre-focus) height of the edit input area to be the same as the height once focus is applied.\r\n\r\nPost Area\r\n* Moved cohort visibility label (\"This post is visible to...\") section to the post-context area underneath the post content, grouping this with the link to courseware alignment (\"Related to:\") This cleans up the post header area in preparation for author images.\r\n\r\nResponse Area\r\n* Reduced the minimum height of responses from 240px to 100px or so, which shortens the visual height of responses that are 1-3 lines long.  \r\n\r\n- - -\r\n**PR Author(s) Notes / To-Do** A list of known open tasks that the PR author has.\r\n- [x] test on course with all cases / states for discussion post\r\n- [x] test editability of posts with new styling changes\r\n- [x] remove out commit for images from PR (will be added on in a future TNL story.) \r\n- [x] rtl testing for changes (and even existing forum styling that was impacted indirectly.) \r\n- [x] determine next steps for getting test changes onto this branch / PR. \r\n- [x] fix comment sizing (74%) & response sizing, currently overlaps with actions.\r\n- [x] fix \"0 votes\" label alignment\r\n- [x] BUG - On create of a post, the left sidebar visually hides other posts excepting the one created. refresh fixes the issue but this seems to not be a problem on production.' \r\n \r\n- - -\r\n**Screenshots** \r\n\r\nPost Changes (with static, example post image placeholder)\r\n![image](https://cloud.githubusercontent.com/assets/2023680/9751484/6dc9ee42-5673-11e5-892f-de579c209838.png)\r\n\r\nEdit Post Changes (visual fix)\r\n![image](https://cloud.githubusercontent.com/assets/2023680/9751503/c0400594-5673-11e5-9cbe-e2ce5c1750a2.png)\r\n\r\nResponse Changes\r\n![image](https://cloud.githubusercontent.com/assets/2023680/9751499/af4313c6-5673-11e5-8731-358188a16fe5.png)\r\n\r\nEdit Post Changes (visual fix) \r\n![image](https://cloud.githubusercontent.com/assets/2023680/9751508/caa79e2a-5673-11e5-8ff5-5bfbe5c45379.png)\r\n\r\nComment Changes\r\n![image](https://cloud.githubusercontent.com/assets/2023680/9751515/d736924a-5673-11e5-94a4-d53c00e56407.png)\r\n\r\n\r\n- - -\r\n**Reviewers**\r\n- [x] FED: @talbs \r\n- [ ] Product: @explorerleslie \r\n- [ ] Documentation: (TBD)\r\n\r\n \r\n - - -\r\n**Authors**\r\n@marcotuts"},"comment":{"url":"https://api.github.com/repos/edx/edx-platform/issues/comments/140748139","html_url":"https://github.com/edx/edx-platform/pull/9666#issuecomment-140748139","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/9666","id":140748139,"user":{"login":"marcotuts","id":2023680,"avatar_url":"https://avatars.githubusercontent.com/u/2023680?v=3","gravatar_id":"","url":"https://api.github.com/users/marcotuts","html_url":"https://github.com/marcotuts","followers_url":"https://api.github.com/users/marcotuts/followers","following_url":"https://api.github.com/users/marcotuts/following{/other_user}","gists_url":"https://api.github.com/users/marcotuts/gists{/gist_id}","starred_url":"https://api.github.com/users/marcotuts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcotuts/subscriptions","organizations_url":"https://api.github.com/users/marcotuts/orgs","repos_url":"https://api.github.com/users/marcotuts/repos","events_url":"https://api.github.com/users/marcotuts/events{/privacy}","received_events_url":"https://api.github.com/users/marcotuts/received_events","type":"User","site_admin":false},"created_at":"2015-09-16T13:51:42Z","updated_at":"2015-09-16T13:51:42Z","body":"jenkins run bokchoy\r\njenkins run lettuce"}}