{"action":"created","comment":{"url":"https://api.github.com/repos/camptocamp/puppet-kmod/pulls/comments/34443395","id":34443395,"diff_hunk":"@@ -18,7 +18,16 @@\n \n   case $ensure {\n     'present': {\n-      $changes = \"clear '${name}'\"\n+      case $::osfamily {\n+        'Debian': {\n+          $changes = \"clear '${name}'\"\n+        }\n+        'Suse': {\n+          $changes = \"set MODULES_LOADED_ON_BOOT/value[last()+1] '${name}'\"\n+          $onlyif  = \"match MODULES_LOADED_ON_BOOT/value[.='${name}'] include ${name}\"\n+        }\n+        default: { }","path":"manifests/load.pp","position":13,"original_position":13,"commit_id":"dfbd227e2a723d1c71c8cda081a1723d7b57e1bf","original_commit_id":"dfbd227e2a723d1c71c8cda081a1723d7b57e1bf","user":{"login":"mcanevet","id":2950673,"avatar_url":"https://avatars.githubusercontent.com/u/2950673?v=3","gravatar_id":"","url":"https://api.github.com/users/mcanevet","html_url":"https://github.com/mcanevet","followers_url":"https://api.github.com/users/mcanevet/followers","following_url":"https://api.github.com/users/mcanevet/following{/other_user}","gists_url":"https://api.github.com/users/mcanevet/gists{/gist_id}","starred_url":"https://api.github.com/users/mcanevet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcanevet/subscriptions","organizations_url":"https://api.github.com/users/mcanevet/orgs","repos_url":"https://api.github.com/users/mcanevet/repos","events_url":"https://api.github.com/users/mcanevet/events{/privacy}","received_events_url":"https://api.github.com/users/mcanevet/received_events","type":"User","site_admin":false},"body":"You should probably fail here","created_at":"2015-07-13T08:48:14Z","updated_at":"2015-07-13T08:48:14Z","html_url":"https://github.com/camptocamp/puppet-kmod/pull/35#discussion_r34443395","pull_request_url":"https://api.github.com/repos/camptocamp/puppet-kmod/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/camptocamp/puppet-kmod/pulls/comments/34443395"},"html":{"href":"https://github.com/camptocamp/puppet-kmod/pull/35#discussion_r34443395"},"pull_request":{"href":"https://api.github.com/repos/camptocamp/puppet-kmod/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/camptocamp/puppet-kmod/pulls/35","id":39789769,"html_url":"https://github.com/camptocamp/puppet-kmod/pull/35","diff_url":"https://github.com/camptocamp/puppet-kmod/pull/35.diff","patch_url":"https://github.com/camptocamp/puppet-kmod/pull/35.patch","issue_url":"https://api.github.com/repos/camptocamp/puppet-kmod/issues/35","number":35,"state":"open","locked":false,"title":"Minimal Suse Support, developed and tested on SLES11 SP3","user":{"login":"buzzdeee","id":8383396,"avatar_url":"https://avatars.githubusercontent.com/u/8383396?v=3","gravatar_id":"","url":"https://api.github.com/users/buzzdeee","html_url":"https://github.com/buzzdeee","followers_url":"https://api.github.com/users/buzzdeee/followers","following_url":"https://api.github.com/users/buzzdeee/following{/other_user}","gists_url":"https://api.github.com/users/buzzdeee/gists{/gist_id}","starred_url":"https://api.github.com/users/buzzdeee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buzzdeee/subscriptions","organizations_url":"https://api.github.com/users/buzzdeee/orgs","repos_url":"https://api.github.com/users/buzzdeee/repos","events_url":"https://api.github.com/users/buzzdeee/events{/privacy}","received_events_url":"https://api.github.com/users/buzzdeee/received_events","type":"User","site_admin":false},"body":"Very basic support to be able to use kmod::load, loads and unloads\r\nmodules correctly, and updates the /etc/sysconfig/kernel file\r\naccordingly. Other defined types etc. weren't touched since\r\nnot needed for now by me.\r\n\r\nAdd some specs for module_load for SLES, but they are not picked\r\nup. With SLES added to metadata.json, travis showed messages like:\r\nCan't find facts for 'sles-11.3-x86_64' for facter 1.7, skipping...","created_at":"2015-07-13T08:43:31Z","updated_at":"2015-07-13T08:48:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c55e29af84bd9643f3962e164261708bba5a9fe1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/camptocamp/puppet-kmod/pulls/35/commits","review_comments_url":"https://api.github.com/repos/camptocamp/puppet-kmod/pulls/35/comments","review_comment_url":"https://api.github.com/repos/camptocamp/puppet-kmod/pulls/comments{/number}","comments_url":"https://api.github.com/repos/camptocamp/puppet-kmod/issues/35/comments","statuses_url":"https://api.github.com/repos/camptocamp/puppet-kmod/statuses/dfbd227e2a723d1c71c8cda081a1723d7b57e1bf","head":{"label":"buzzdeee:master","ref":"master","sha":"dfbd227e2a723d1c71c8cda081a1723d7b57e1bf","user":{"login":"buzzdeee","id":8383396,"avatar_url":"https://avatars.githubusercontent.com/u/8383396?v=3","gravatar_id":"","url":"https://api.github.com/users/buzzdeee","html_url":"https://github.com/buzzdeee","followers_url":"https://api.github.com/users/buzzdeee/followers","following_url":"https://api.github.com/users/buzzdeee/following{/other_user}","gists_url":"https://api.github.com/users/buzzdeee/gists{/gist_id}","starred_url":"https://api.github.com/users/buzzdeee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buzzdeee/subscriptions","organizations_url":"https://api.github.com/users/buzzdeee/orgs","repos_url":"https://api.github.com/users/buzzdeee/repos","events_url":"https://api.github.com/users/buzzdeee/events{/privacy}","received_events_url":"https://api.github.com/users/buzzdeee/received_events","type":"User","site_admin":false},"repo":{"id":38868765,"name":"puppet-kmod","full_name":"buzzdeee/puppet-kmod","owner":{"login":"buzzdeee","id":8383396,"avatar_url":"https://avatars.githubusercontent.com/u/8383396?v=3","gravatar_id":"","url":"https://api.github.com/users/buzzdeee","html_url":"https://github.com/buzzdeee","followers_url":"https://api.github.com/users/buzzdeee/followers","following_url":"https://api.github.com/users/buzzdeee/following{/other_user}","gists_url":"https://api.github.com/users/buzzdeee/gists{/gist_id}","starred_url":"https://api.github.com/users/buzzdeee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buzzdeee/subscriptions","organizations_url":"https://api.github.com/users/buzzdeee/orgs","repos_url":"https://api.github.com/users/buzzdeee/repos","events_url":"https://api.github.com/users/buzzdeee/events{/privacy}","received_events_url":"https://api.github.com/users/buzzdeee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/buzzdeee/puppet-kmod","description":"manage kernel module with puppet","fork":true,"url":"https://api.github.com/repos/buzzdeee/puppet-kmod","forks_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/forks","keys_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/teams","hooks_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/hooks","issue_events_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/issues/events{/number}","events_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/events","assignees_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/assignees{/user}","branches_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/branches{/branch}","tags_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/tags","blobs_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/git/refs{/sha}","trees_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/statuses/{sha}","languages_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/languages","stargazers_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/stargazers","contributors_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/contributors","subscribers_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/subscribers","subscription_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/subscription","commits_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/commits{/sha}","git_commits_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/git/commits{/sha}","comments_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/comments{/number}","issue_comment_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/issues/comments{/number}","contents_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/contents/{+path}","compare_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/merges","archive_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/downloads","issues_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/issues{/number}","pulls_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/pulls{/number}","milestones_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/milestones{/number}","notifications_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/labels{/name}","releases_url":"https://api.github.com/repos/buzzdeee/puppet-kmod/releases{/id}","created_at":"2015-07-10T08:03:16Z","updated_at":"2015-07-10T08:03:17Z","pushed_at":"2015-07-13T08:39:48Z","git_url":"git://github.com/buzzdeee/puppet-kmod.git","ssh_url":"git@github.com:buzzdeee/puppet-kmod.git","clone_url":"https://github.com/buzzdeee/puppet-kmod.git","svn_url":"https://github.com/buzzdeee/puppet-kmod","homepage":"","size":190,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"camptocamp:master","ref":"master","sha":"d6883ccfcbca9ce92c0f2585d72d3d9326a008ce","user":{"login":"camptocamp","id":28109,"avatar_url":"https://avatars.githubusercontent.com/u/28109?v=3","gravatar_id":"","url":"https://api.github.com/users/camptocamp","html_url":"https://github.com/camptocamp","followers_url":"https://api.github.com/users/camptocamp/followers","following_url":"https://api.github.com/users/camptocamp/following{/other_user}","gists_url":"https://api.github.com/users/camptocamp/gists{/gist_id}","starred_url":"https://api.github.com/users/camptocamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camptocamp/subscriptions","organizations_url":"https://api.github.com/users/camptocamp/orgs","repos_url":"https://api.github.com/users/camptocamp/repos","events_url":"https://api.github.com/users/camptocamp/events{/privacy}","received_events_url":"https://api.github.com/users/camptocamp/received_events","type":"Organization","site_admin":false},"repo":{"id":3938525,"name":"puppet-kmod","full_name":"camptocamp/puppet-kmod","owner":{"login":"camptocamp","id":28109,"avatar_url":"https://avatars.githubusercontent.com/u/28109?v=3","gravatar_id":"","url":"https://api.github.com/users/camptocamp","html_url":"https://github.com/camptocamp","followers_url":"https://api.github.com/users/camptocamp/followers","following_url":"https://api.github.com/users/camptocamp/following{/other_user}","gists_url":"https://api.github.com/users/camptocamp/gists{/gist_id}","starred_url":"https://api.github.com/users/camptocamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camptocamp/subscriptions","organizations_url":"https://api.github.com/users/camptocamp/orgs","repos_url":"https://api.github.com/users/camptocamp/repos","events_url":"https://api.github.com/users/camptocamp/events{/privacy}","received_events_url":"https://api.github.com/users/camptocamp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/camptocamp/puppet-kmod","description":"manage kernel module with puppet","fork":false,"url":"https://api.github.com/repos/camptocamp/puppet-kmod","forks_url":"https://api.github.com/repos/camptocamp/puppet-kmod/forks","keys_url":"https://api.github.com/repos/camptocamp/puppet-kmod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/camptocamp/puppet-kmod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/camptocamp/puppet-kmod/teams","hooks_url":"https://api.github.com/repos/camptocamp/puppet-kmod/hooks","issue_events_url":"https://api.github.com/repos/camptocamp/puppet-kmod/issues/events{/number}","events_url":"https://api.github.com/repos/camptocamp/puppet-kmod/events","assignees_url":"https://api.github.com/repos/camptocamp/puppet-kmod/assignees{/user}","branches_url":"https://api.github.com/repos/camptocamp/puppet-kmod/branches{/branch}","tags_url":"https://api.github.com/repos/camptocamp/puppet-kmod/tags","blobs_url":"https://api.github.com/repos/camptocamp/puppet-kmod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/camptocamp/puppet-kmod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/camptocamp/puppet-kmod/git/refs{/sha}","trees_url":"https://api.github.com/repos/camptocamp/puppet-kmod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/camptocamp/puppet-kmod/statuses/{sha}","languages_url":"https://api.github.com/repos/camptocamp/puppet-kmod/languages","stargazers_url":"https://api.github.com/repos/camptocamp/puppet-kmod/stargazers","contributors_url":"https://api.github.com/repos/camptocamp/puppet-kmod/contributors","subscribers_url":"https://api.github.com/repos/camptocamp/puppet-kmod/subscribers","subscription_url":"https://api.github.com/repos/camptocamp/puppet-kmod/subscription","commits_url":"https://api.github.com/repos/camptocamp/puppet-kmod/commits{/sha}","git_commits_url":"https://api.github.com/repos/camptocamp/puppet-kmod/git/commits{/sha}","comments_url":"https://api.github.com/repos/camptocamp/puppet-kmod/comments{/number}","issue_comment_url":"https://api.github.com/repos/camptocamp/puppet-kmod/issues/comments{/number}","contents_url":"https://api.github.com/repos/camptocamp/puppet-kmod/contents/{+path}","compare_url":"https://api.github.com/repos/camptocamp/puppet-kmod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/camptocamp/puppet-kmod/merges","archive_url":"https://api.github.com/repos/camptocamp/puppet-kmod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/camptocamp/puppet-kmod/downloads","issues_url":"https://api.github.com/repos/camptocamp/puppet-kmod/issues{/number}","pulls_url":"https://api.github.com/repos/camptocamp/puppet-kmod/pulls{/number}","milestones_url":"https://api.github.com/repos/camptocamp/puppet-kmod/milestones{/number}","notifications_url":"https://api.github.com/repos/camptocamp/puppet-kmod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/camptocamp/puppet-kmod/labels{/name}","releases_url":"https://api.github.com/repos/camptocamp/puppet-kmod/releases{/id}","created_at":"2012-04-05T10:21:39Z","updated_at":"2015-06-27T05:04:41Z","pushed_at":"2015-07-13T08:43:32Z","git_url":"git://github.com/camptocamp/puppet-kmod.git","ssh_url":"git@github.com:camptocamp/puppet-kmod.git","clone_url":"https://github.com/camptocamp/puppet-kmod.git","svn_url":"https://github.com/camptocamp/puppet-kmod","homepage":"","size":672,"stargazers_count":14,"watchers_count":14,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":4,"forks":35,"open_issues":4,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/camptocamp/puppet-kmod/pulls/35"},"html":{"href":"https://github.com/camptocamp/puppet-kmod/pull/35"},"issue":{"href":"https://api.github.com/repos/camptocamp/puppet-kmod/issues/35"},"comments":{"href":"https://api.github.com/repos/camptocamp/puppet-kmod/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/camptocamp/puppet-kmod/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/camptocamp/puppet-kmod/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/camptocamp/puppet-kmod/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/camptocamp/puppet-kmod/statuses/dfbd227e2a723d1c71c8cda081a1723d7b57e1bf"}}}}