{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/firefox-ios/pulls/comments/35249544","id":35249544,"diff_hunk":"@@ -223,11 +238,23 @@ class URLBarView: UIView {\n             make.size.equalTo(URLBarViewUX.TabsButtonHeight)\n         }\n \n+        tabsButton.snp_makeConstraints { make in\n+            make.centerY.equalTo(self.locationContainer)\n+            make.trailing.equalTo(self)\n+            make.width.height.equalTo(UIConstants.ToolbarHeight)","path":"Client/Frontend/Browser/URLBarView.swift","position":180,"original_position":180,"commit_id":"ee2c0905fea4504db65e50633a54beedc543cdbd","original_commit_id":"ee2c0905fea4504db65e50633a54beedc543cdbd","user":{"login":"wesj","id":1117644,"avatar_url":"https://avatars.githubusercontent.com/u/1117644?v=3","gravatar_id":"","url":"https://api.github.com/users/wesj","html_url":"https://github.com/wesj","followers_url":"https://api.github.com/users/wesj/followers","following_url":"https://api.github.com/users/wesj/following{/other_user}","gists_url":"https://api.github.com/users/wesj/gists{/gist_id}","starred_url":"https://api.github.com/users/wesj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesj/subscriptions","organizations_url":"https://api.github.com/users/wesj/orgs","repos_url":"https://api.github.com/users/wesj/repos","events_url":"https://api.github.com/users/wesj/events{/privacy}","received_events_url":"https://api.github.com/users/wesj/received_events","type":"User","site_admin":false},"body":"Its probably better to just make this stretch the height of the container (i.e. so it detection works regardless of if the toolbarheight changes). i.e. make.top.bottom.equalTo(self.locationContainer)","created_at":"2015-07-22T18:53:47Z","updated_at":"2015-07-22T18:53:47Z","html_url":"https://github.com/mozilla/firefox-ios/pull/782#discussion_r35249544","pull_request_url":"https://api.github.com/repos/mozilla/firefox-ios/pulls/782","_links":{"self":{"href":"https://api.github.com/repos/mozilla/firefox-ios/pulls/comments/35249544"},"html":{"href":"https://github.com/mozilla/firefox-ios/pull/782#discussion_r35249544"},"pull_request":{"href":"https://api.github.com/repos/mozilla/firefox-ios/pulls/782"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/firefox-ios/pulls/782","id":40536119,"html_url":"https://github.com/mozilla/firefox-ios/pull/782","diff_url":"https://github.com/mozilla/firefox-ios/pull/782.diff","patch_url":"https://github.com/mozilla/firefox-ios/pull/782.patch","issue_url":"https://api.github.com/repos/mozilla/firefox-ios/issues/782","number":782,"state":"open","locked":false,"title":"Bug 1184239 - Refactor URL bar to use separate viewable and editable text fields","user":{"login":"thebnich","id":1093266,"avatar_url":"https://avatars.githubusercontent.com/u/1093266?v=3","gravatar_id":"","url":"https://api.github.com/users/thebnich","html_url":"https://github.com/thebnich","followers_url":"https://api.github.com/users/thebnich/followers","following_url":"https://api.github.com/users/thebnich/following{/other_user}","gists_url":"https://api.github.com/users/thebnich/gists{/gist_id}","starred_url":"https://api.github.com/users/thebnich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thebnich/subscriptions","organizations_url":"https://api.github.com/users/thebnich/orgs","repos_url":"https://api.github.com/users/thebnich/repos","events_url":"https://api.github.com/users/thebnich/events{/privacy}","received_events_url":"https://api.github.com/users/thebnich/received_events","type":"User","site_admin":false},"body":"Given all of the URL bar regressions, I think we should go back to how we did this before: use separate views for displaying and editing the page URL. Here's a mega-patch that does the following:\r\n* Moves the `AutocompleteTextField` back into `URLBarView`.\r\n* Creates an `inOverlayMode` variable to track whether we're in the panel overlay state. This is different from the `editing` state on a `UITextField` (we don't want to leave the mode just because the field loses focus). I decided to call it \"overlay mode\" instead of \"editing mode\" to avoid that confusion.\r\n* Removed lots of unneeded code, and lots of mini-refactorings.\r\n\r\nOverall, I'm pretty happy with the changes, but sorry I didn't split this up more. I can try breaking this down into smaller commits if needed.\r\n\r\n**257 insertions(+), 398 deletions(-)** -- woohoo!","created_at":"2015-07-22T07:08:59Z","updated_at":"2015-07-22T18:53:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b55cc8d15a57b7b399d4fee3833d346efe4cd31","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/firefox-ios/pulls/782/commits","review_comments_url":"https://api.github.com/repos/mozilla/firefox-ios/pulls/782/comments","review_comment_url":"https://api.github.com/repos/mozilla/firefox-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/firefox-ios/issues/782/comments","statuses_url":"https://api.github.com/repos/mozilla/firefox-ios/statuses/ee2c0905fea4504db65e50633a54beedc543cdbd","head":{"label":"thebnich:revert-url-bar","ref":"revert-url-bar","sha":"ee2c0905fea4504db65e50633a54beedc543cdbd","user":{"login":"thebnich","id":1093266,"avatar_url":"https://avatars.githubusercontent.com/u/1093266?v=3","gravatar_id":"","url":"https://api.github.com/users/thebnich","html_url":"https://github.com/thebnich","followers_url":"https://api.github.com/users/thebnich/followers","following_url":"https://api.github.com/users/thebnich/following{/other_user}","gists_url":"https://api.github.com/users/thebnich/gists{/gist_id}","starred_url":"https://api.github.com/users/thebnich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thebnich/subscriptions","organizations_url":"https://api.github.com/users/thebnich/orgs","repos_url":"https://api.github.com/users/thebnich/repos","events_url":"https://api.github.com/users/thebnich/events{/privacy}","received_events_url":"https://api.github.com/users/thebnich/received_events","type":"User","site_admin":false},"repo":{"id":27744299,"name":"firefox-ios","full_name":"thebnich/firefox-ios","owner":{"login":"thebnich","id":1093266,"avatar_url":"https://avatars.githubusercontent.com/u/1093266?v=3","gravatar_id":"","url":"https://api.github.com/users/thebnich","html_url":"https://github.com/thebnich","followers_url":"https://api.github.com/users/thebnich/followers","following_url":"https://api.github.com/users/thebnich/following{/other_user}","gists_url":"https://api.github.com/users/thebnich/gists{/gist_id}","starred_url":"https://api.github.com/users/thebnich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thebnich/subscriptions","organizations_url":"https://api.github.com/users/thebnich/orgs","repos_url":"https://api.github.com/users/thebnich/repos","events_url":"https://api.github.com/users/thebnich/events{/privacy}","received_events_url":"https://api.github.com/users/thebnich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thebnich/firefox-ios","description":"Firefox for iOS","fork":true,"url":"https://api.github.com/repos/thebnich/firefox-ios","forks_url":"https://api.github.com/repos/thebnich/firefox-ios/forks","keys_url":"https://api.github.com/repos/thebnich/firefox-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thebnich/firefox-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thebnich/firefox-ios/teams","hooks_url":"https://api.github.com/repos/thebnich/firefox-ios/hooks","issue_events_url":"https://api.github.com/repos/thebnich/firefox-ios/issues/events{/number}","events_url":"https://api.github.com/repos/thebnich/firefox-ios/events","assignees_url":"https://api.github.com/repos/thebnich/firefox-ios/assignees{/user}","branches_url":"https://api.github.com/repos/thebnich/firefox-ios/branches{/branch}","tags_url":"https://api.github.com/repos/thebnich/firefox-ios/tags","blobs_url":"https://api.github.com/repos/thebnich/firefox-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thebnich/firefox-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thebnich/firefox-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/thebnich/firefox-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thebnich/firefox-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/thebnich/firefox-ios/languages","stargazers_url":"https://api.github.com/repos/thebnich/firefox-ios/stargazers","contributors_url":"https://api.github.com/repos/thebnich/firefox-ios/contributors","subscribers_url":"https://api.github.com/repos/thebnich/firefox-ios/subscribers","subscription_url":"https://api.github.com/repos/thebnich/firefox-ios/subscription","commits_url":"https://api.github.com/repos/thebnich/firefox-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/thebnich/firefox-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/thebnich/firefox-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/thebnich/firefox-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/thebnich/firefox-ios/contents/{+path}","compare_url":"https://api.github.com/repos/thebnich/firefox-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thebnich/firefox-ios/merges","archive_url":"https://api.github.com/repos/thebnich/firefox-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thebnich/firefox-ios/downloads","issues_url":"https://api.github.com/repos/thebnich/firefox-ios/issues{/number}","pulls_url":"https://api.github.com/repos/thebnich/firefox-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/thebnich/firefox-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/thebnich/firefox-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thebnich/firefox-ios/labels{/name}","releases_url":"https://api.github.com/repos/thebnich/firefox-ios/releases{/id}","created_at":"2014-12-09T01:43:28Z","updated_at":"2015-02-20T01:57:25Z","pushed_at":"2015-07-22T17:16:04Z","git_url":"git://github.com/thebnich/firefox-ios.git","ssh_url":"git@github.com:thebnich/firefox-ios.git","clone_url":"https://github.com/thebnich/firefox-ios.git","svn_url":"https://github.com/thebnich/firefox-ios","homepage":"","size":31086,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"cc7d7429e60fbae23f9c28eea86a4fbd90a131f7","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":26133979,"name":"firefox-ios","full_name":"mozilla/firefox-ios","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/firefox-ios","description":"Firefox for iOS","fork":false,"url":"https://api.github.com/repos/mozilla/firefox-ios","forks_url":"https://api.github.com/repos/mozilla/firefox-ios/forks","keys_url":"https://api.github.com/repos/mozilla/firefox-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/firefox-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/firefox-ios/teams","hooks_url":"https://api.github.com/repos/mozilla/firefox-ios/hooks","issue_events_url":"https://api.github.com/repos/mozilla/firefox-ios/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/firefox-ios/events","assignees_url":"https://api.github.com/repos/mozilla/firefox-ios/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/firefox-ios/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/firefox-ios/tags","blobs_url":"https://api.github.com/repos/mozilla/firefox-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/firefox-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/firefox-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/firefox-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/firefox-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/firefox-ios/languages","stargazers_url":"https://api.github.com/repos/mozilla/firefox-ios/stargazers","contributors_url":"https://api.github.com/repos/mozilla/firefox-ios/contributors","subscribers_url":"https://api.github.com/repos/mozilla/firefox-ios/subscribers","subscription_url":"https://api.github.com/repos/mozilla/firefox-ios/subscription","commits_url":"https://api.github.com/repos/mozilla/firefox-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/firefox-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/firefox-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/firefox-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/firefox-ios/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/firefox-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/firefox-ios/merges","archive_url":"https://api.github.com/repos/mozilla/firefox-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/firefox-ios/downloads","issues_url":"https://api.github.com/repos/mozilla/firefox-ios/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/firefox-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/firefox-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/firefox-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/firefox-ios/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/firefox-ios/releases{/id}","created_at":"2014-11-03T19:07:02Z","updated_at":"2015-07-22T16:31:09Z","pushed_at":"2015-07-22T18:12:23Z","git_url":"git://github.com/mozilla/firefox-ios.git","ssh_url":"git@github.com:mozilla/firefox-ios.git","clone_url":"https://github.com/mozilla/firefox-ios.git","svn_url":"https://github.com/mozilla/firefox-ios","homepage":"","size":148773,"stargazers_count":3455,"watchers_count":3455,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":580,"mirror_url":null,"open_issues_count":48,"forks":580,"open_issues":48,"watchers":3455,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/firefox-ios/pulls/782"},"html":{"href":"https://github.com/mozilla/firefox-ios/pull/782"},"issue":{"href":"https://api.github.com/repos/mozilla/firefox-ios/issues/782"},"comments":{"href":"https://api.github.com/repos/mozilla/firefox-ios/issues/782/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/firefox-ios/pulls/782/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/firefox-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/firefox-ios/pulls/782/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/firefox-ios/statuses/ee2c0905fea4504db65e50633a54beedc543cdbd"}}}}