{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments/39815648","id":39815648,"diff_hunk":"@@ -1,314 +1,407 @@\n {\n-    \"$schema\": \"http://schema.management.azure.com/schemas/2014-04-01-preview/deploymentTemplate.json\",\n-    \"contentVersion\": \"1.0.0.0\",\n-    \"parameters\" : {\n-        \"adminUserName\": {\n-            \"type\": \"string\",\n-            \"defaultValue\": \"testuser\",\n-            \"metadata\": {\n-                \"description\": \"Admin user name for the Virtual Machines\"\n-            }\n-        },\n-        \"adminPassword\": {\n-            \"type\": \"securestring\",\n-            \"defaultValue\": \"Eur32#1e\",\n-            \"metadata\": {\n-                \"description\": \"Admin password for the Virtual Machines\"\n-            }\n-        },\n-        \"storageAccountPrefix\": {\n-            \"type\": \"string\",\n-            \"defaultValue\": \"defaultStorageAccountPrefix\",\n-            \"metadata\": {\n-                \"description\": \"Unique namespace for the Storage Account where the Virtual Machine's disks will be placed\"\n-            }\n-        },\n-        \"dnsNamePrefix\": {\n-            \"type\": \"string\",\n-            \"defaultValue\": \"defaultDnsNamePrefix\",\n-            \"metadata\": {\n-                \"description\": \"Unique public dns name where the Virtual Machines will be exposed\"\n-            }\n-        },\n-        \"region\": {\n-            \"type\": \"string\",\n-            \"metadata\": {\n-                \"description\": \"Location where resources will be provisioned\"\n-            }\n-        },\n-        \"storageAccountType\": {\n-            \"type\": \"string\",\n-            \"defaultValue\": \"Standard_LRS\",\n-            \"metadata\": {\n-                \"description\": \"The type of the Storage Account to be created (Default to Standard_LRS)\"\n-            }\n-        },\n-        \"virtualNetworkName\": { \n-            \"type\": \"string\", \n-            \"defaultValue\": \"clouderaVnet\", \n-            \"metadata\": { \n-                \"description\": \"The name of the virtual network provisioned for the deployment\" \n-            } \n-        }, \n-        \"subnetName\": { \n-            \"type\": \"string\", \n-            \"defaultValue\": \"clouderaSubnet\", \n-            \"metadata\": { \n-                \"description\": \"Subnet name for the virtual network where resources will be provisioned\" \n-            } \n-        },\n-        \"addressPrefix\": { \n-            \"type\": \"string\", \n-            \"defaultValue\": \"10.0.0.0/24\", \n-            \"metadata\": { \n-                \"description\": \"The network address space for the virtual network\" \n-            } \n-        }, \n-        \"subnetPrefix\": { \n-            \"type\": \"string\", \n-            \"defaultValue\": \"10.0.0.0/24\", \n-            \"metadata\": { \n-                \"description\": \"The network address space for the virtual subnet\" \n-            } \n-        }, \n-        \"nodeAddressPrefix\": { \n-            \"type\": \"string\", \n-            \"defaultValue\": \"10.0.0.\",\n-            \"metadata\": { \n-                \"description\": \"The IP address prefix that will be used for constructing private IP address for each node in the cluster\" \n-            } \n-        }, \n-        \"tshirtSize\": { \n-            \"type\": \"string\", \n-            \"defaultValue\": \"Eval\", \n-            \"allowedValues\": [\n-                \"Eval\",\n-                \"Prod\"\n-            ], \n-            \"metadata\": { \n-                \"description\": \"T-shirt size of the Cloudera cluster (Eval, Prod)\" \n-            } \n-        }, \n-        \"numberOfDataNodes\": {\n-            \"type\": \"int\",\n-            \"defaultValue\": 3,\n-            \"metadata\": { \n-                \"description\": \"Number of data nodes for Prod, default to 3\" \n-            } \n-        },\n-        \"vmSize\": {\n-            \"type\": \"string\",\n-            \"defaultValue\": \"Standard_D14\",\n-            \"metadata\": { \n-                \"description\": \"The size of the VMs deployed in the cluster (Defaults to Standard_D14)\" \n-            } \n-        },\n-        \"keyVaultResourceGroup\": {\n-            \"type\": \"string\",\n-            \"defaultValue\": \"AzureRM-Util\",\n-            \"metadata\": { \n-                \"description\": \"The resource group containing the key vault which provides the private key used for SSH login.  See the readme for details.\" \n-            } \n-        },\n-        \"keyVaultName\": {\n-            \"type\": \"string\",\n-            \"defaultValue\": \"AzureRM-Keys\",\n-            \"metadata\": { \n-                \"description\": \"The name of the key vault which provides the private key used for SSH login.  See the readme for details.\" \n-            } \n+  \"$schema\": \"http://schema.management.azure.com/schemas/2014-04-01-preview/deploymentTemplate.json\",\n+  \"contentVersion\": \"1.0.0.0\",\n+  \"parameters\": {\n+    \"adminUserName\": {\n+      \"type\": \"string\",\n+      \"defaultValue\": \"testuser\",\n+      \"metadata\": {\n+        \"description\": \"Admin user name for the Virtual Machines\"\n+      }\n+    },\n+    \"adminPassword\": {\n+      \"type\": \"securestring\",\n+      \"defaultValue\": \"Eur32#1e\",\n+      \"metadata\": {\n+        \"description\": \"Admin password for the Virtual Machines\"\n+      }\n+    },\n+    \"cmUsername\": {\n+      \"type\": \"string\",\n+      \"defaultValue\": \"cmadmin\",\n+      \"metadata\": {\n+        \"description\": \"User name for the Cloudera Manager\"\n+      }\n+    },\n+    \"cmPassword\": {\n+      \"type\": \"securestring\",\n+      \"defaultValue\": \"cmpassword\",\n+      \"metadata\": {\n+        \"description\": \"password for the Cloudera Manager\"\n+      }\n+    },\n+    \"storageAccountPrefix\": {\n+      \"type\": \"string\",\n+      \"defaultValue\": \"storageaccountprefix\",","path":"cloudera-on-centos/azuredeploy.json","position":152,"original_position":152,"commit_id":"e3c0d8ef669c0c88aeb30c8beb31fb784b4714cf","original_commit_id":"e3c0d8ef669c0c88aeb30c8beb31fb784b4714cf","user":{"login":"netwmr01","id":5139166,"avatar_url":"https://avatars.githubusercontent.com/u/5139166?v=3","gravatar_id":"","url":"https://api.github.com/users/netwmr01","html_url":"https://github.com/netwmr01","followers_url":"https://api.github.com/users/netwmr01/followers","following_url":"https://api.github.com/users/netwmr01/following{/other_user}","gists_url":"https://api.github.com/users/netwmr01/gists{/gist_id}","starred_url":"https://api.github.com/users/netwmr01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netwmr01/subscriptions","organizations_url":"https://api.github.com/users/netwmr01/orgs","repos_url":"https://api.github.com/users/netwmr01/repos","events_url":"https://api.github.com/users/netwmr01/events{/privacy}","received_events_url":"https://api.github.com/users/netwmr01/received_events","type":"User","site_admin":false},"body":"yes, but we think having default as place holder is fine.","created_at":"2015-09-18T00:45:13Z","updated_at":"2015-09-18T00:45:13Z","html_url":"https://github.com/Azure/azure-quickstart-templates/pull/607#discussion_r39815648","pull_request_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/607","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments/39815648"},"html":{"href":"https://github.com/Azure/azure-quickstart-templates/pull/607#discussion_r39815648"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/607"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/607","id":44990588,"html_url":"https://github.com/Azure/azure-quickstart-templates/pull/607","diff_url":"https://github.com/Azure/azure-quickstart-templates/pull/607.diff","patch_url":"https://github.com/Azure/azure-quickstart-templates/pull/607.patch","issue_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/607","number":607,"state":"open","locked":false,"title":"Cloudera offical template work","user":{"login":"netwmr01","id":5139166,"avatar_url":"https://avatars.githubusercontent.com/u/5139166?v=3","gravatar_id":"","url":"https://api.github.com/users/netwmr01","html_url":"https://github.com/netwmr01","followers_url":"https://api.github.com/users/netwmr01/followers","following_url":"https://api.github.com/users/netwmr01/following{/other_user}","gists_url":"https://api.github.com/users/netwmr01/gists{/gist_id}","starred_url":"https://api.github.com/users/netwmr01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netwmr01/subscriptions","organizations_url":"https://api.github.com/users/netwmr01/orgs","repos_url":"https://api.github.com/users/netwmr01/repos","events_url":"https://api.github.com/users/netwmr01/events{/privacy}","received_events_url":"https://api.github.com/users/netwmr01/received_events","type":"User","site_admin":false},"body":"Cloudera offical template work","created_at":"2015-09-14T22:48:06Z","updated_at":"2015-09-18T00:45:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/607/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/607/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/607/comments","statuses_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/e3c0d8ef669c0c88aeb30c8beb31fb784b4714cf","head":{"label":"netwmr01:master","ref":"master","sha":"e3c0d8ef669c0c88aeb30c8beb31fb784b4714cf","user":{"login":"netwmr01","id":5139166,"avatar_url":"https://avatars.githubusercontent.com/u/5139166?v=3","gravatar_id":"","url":"https://api.github.com/users/netwmr01","html_url":"https://github.com/netwmr01","followers_url":"https://api.github.com/users/netwmr01/followers","following_url":"https://api.github.com/users/netwmr01/following{/other_user}","gists_url":"https://api.github.com/users/netwmr01/gists{/gist_id}","starred_url":"https://api.github.com/users/netwmr01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netwmr01/subscriptions","organizations_url":"https://api.github.com/users/netwmr01/orgs","repos_url":"https://api.github.com/users/netwmr01/repos","events_url":"https://api.github.com/users/netwmr01/events{/privacy}","received_events_url":"https://api.github.com/users/netwmr01/received_events","type":"User","site_admin":false},"repo":{"id":39525261,"name":"azure-quickstart-templates","full_name":"netwmr01/azure-quickstart-templates","owner":{"login":"netwmr01","id":5139166,"avatar_url":"https://avatars.githubusercontent.com/u/5139166?v=3","gravatar_id":"","url":"https://api.github.com/users/netwmr01","html_url":"https://github.com/netwmr01","followers_url":"https://api.github.com/users/netwmr01/followers","following_url":"https://api.github.com/users/netwmr01/following{/other_user}","gists_url":"https://api.github.com/users/netwmr01/gists{/gist_id}","starred_url":"https://api.github.com/users/netwmr01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netwmr01/subscriptions","organizations_url":"https://api.github.com/users/netwmr01/orgs","repos_url":"https://api.github.com/users/netwmr01/repos","events_url":"https://api.github.com/users/netwmr01/events{/privacy}","received_events_url":"https://api.github.com/users/netwmr01/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/netwmr01/azure-quickstart-templates","description":"Azure Quickstart Templates","fork":true,"url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates","forks_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/forks","keys_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/teams","hooks_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/hooks","issue_events_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/issues/events{/number}","events_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/events","assignees_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/assignees{/user}","branches_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/branches{/branch}","tags_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/tags","blobs_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/languages","stargazers_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/stargazers","contributors_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/contributors","subscribers_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/subscribers","subscription_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/subscription","commits_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/contents/{+path}","compare_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/merges","archive_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/downloads","issues_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/issues{/number}","pulls_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/labels{/name}","releases_url":"https://api.github.com/repos/netwmr01/azure-quickstart-templates/releases{/id}","created_at":"2015-07-22T19:11:40Z","updated_at":"2015-07-22T19:11:42Z","pushed_at":"2015-09-14T22:40:06Z","git_url":"git://github.com/netwmr01/azure-quickstart-templates.git","ssh_url":"git@github.com:netwmr01/azure-quickstart-templates.git","clone_url":"https://github.com/netwmr01/azure-quickstart-templates.git","svn_url":"https://github.com/netwmr01/azure-quickstart-templates","homepage":null,"size":11632,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"43758769e06071f4eba9d8b3816c48aa75ca8999","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":34407651,"name":"azure-quickstart-templates","full_name":"Azure/azure-quickstart-templates","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-quickstart-templates","description":"Azure Quickstart Templates","fork":false,"url":"https://api.github.com/repos/Azure/azure-quickstart-templates","forks_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/forks","keys_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/teams","hooks_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/events","assignees_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/tags","blobs_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/subscription","commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/merges","archive_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/downloads","issues_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/releases{/id}","created_at":"2015-04-22T18:19:03Z","updated_at":"2015-09-17T22:59:52Z","pushed_at":"2015-09-18T00:43:05Z","git_url":"git://github.com/Azure/azure-quickstart-templates.git","ssh_url":"git@github.com:Azure/azure-quickstart-templates.git","clone_url":"https://github.com/Azure/azure-quickstart-templates.git","svn_url":"https://github.com/Azure/azure-quickstart-templates","homepage":null,"size":19795,"stargazers_count":261,"watchers_count":261,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":351,"mirror_url":null,"open_issues_count":40,"forks":351,"open_issues":40,"watchers":261,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/607"},"html":{"href":"https://github.com/Azure/azure-quickstart-templates/pull/607"},"issue":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/607"},"comments":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/607/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/607/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/607/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/e3c0d8ef669c0c88aeb30c8beb31fb784b4714cf"}}}}