{"action":"created","comment":{"url":"https://api.github.com/repos/detiber/openshift-ansible/pulls/comments/32491511","id":32491511,"diff_hunk":"@@ -27,10 +27,12 @@\n     stat:\n       path: \"{{ item }}\"\n     with_items:\n-    - \"/etc/openshift/node/node.key\"\n-    - \"/etc/openshift/node/node.kubeconfig\"\n+    - \"/etc/openshift/node/system:node:{{ openshift.common.hostname }}.crt\"\n+    - \"/etc/openshift/node/system:node:{{ openshift.common.hostname }}.key\"\n+    - \"/etc/openshift/node/system:node:{{ openshift.common.hostname }}.kubeconfig\"","path":"playbooks/common/openshift-node/config.yml","position":8,"original_position":8,"commit_id":"30550b6041c15db4794ba23937a1e04003bfd0f5","original_commit_id":"30550b6041c15db4794ba23937a1e04003bfd0f5","user":{"login":"detiber","id":915544,"avatar_url":"https://avatars.githubusercontent.com/u/915544?v=3","gravatar_id":"","url":"https://api.github.com/users/detiber","html_url":"https://github.com/detiber","followers_url":"https://api.github.com/users/detiber/followers","following_url":"https://api.github.com/users/detiber/following{/other_user}","gists_url":"https://api.github.com/users/detiber/gists{/gist_id}","starred_url":"https://api.github.com/users/detiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/detiber/subscriptions","organizations_url":"https://api.github.com/users/detiber/orgs","repos_url":"https://api.github.com/users/detiber/repos","events_url":"https://api.github.com/users/detiber/events{/privacy}","received_events_url":"https://api.github.com/users/detiber/received_events","type":"User","site_admin":false},"body":"@liggitt @sdodson There is no real reason that we couldn't use create-node-config, the only reason I didn't was to make it explicitly clear that we are not using the generated node config, and just using the generated server certs and generated client certs/kubeconfig.  We could easily go back to create-node-config and throw away the generated node config and node json files (preferably before we create the tarball and transfer over to the node host).","created_at":"2015-06-16T05:07:51Z","updated_at":"2015-06-16T05:07:51Z","html_url":"https://github.com/detiber/openshift-ansible/pull/46#discussion_r32491511","pull_request_url":"https://api.github.com/repos/detiber/openshift-ansible/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/detiber/openshift-ansible/pulls/comments/32491511"},"html":{"href":"https://github.com/detiber/openshift-ansible/pull/46#discussion_r32491511"},"pull_request":{"href":"https://api.github.com/repos/detiber/openshift-ansible/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/detiber/openshift-ansible/pulls/46","id":37735902,"html_url":"https://github.com/detiber/openshift-ansible/pull/46","diff_url":"https://github.com/detiber/openshift-ansible/pull/46.diff","patch_url":"https://github.com/detiber/openshift-ansible/pull/46.patch","issue_url":"https://api.github.com/repos/detiber/openshift-ansible/issues/46","number":46,"state":"closed","locked":false,"title":"Rename node cert/key/kubeconfig per openshift/origin#3160","user":{"login":"sdodson","id":48161,"avatar_url":"https://avatars.githubusercontent.com/u/48161?v=3","gravatar_id":"","url":"https://api.github.com/users/sdodson","html_url":"https://github.com/sdodson","followers_url":"https://api.github.com/users/sdodson/followers","following_url":"https://api.github.com/users/sdodson/following{/other_user}","gists_url":"https://api.github.com/users/sdodson/gists{/gist_id}","starred_url":"https://api.github.com/users/sdodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdodson/subscriptions","organizations_url":"https://api.github.com/users/sdodson/orgs","repos_url":"https://api.github.com/users/sdodson/repos","events_url":"https://api.github.com/users/sdodson/events{/privacy}","received_events_url":"https://api.github.com/users/sdodson/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-15T21:10:39Z","updated_at":"2015-06-16T05:07:51Z","closed_at":"2015-06-15T21:26:36Z","merged_at":"2015-06-15T21:26:36Z","merge_commit_sha":"92b5439d9f32868bbda722c7b0d223a5c1fe7bc0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/detiber/openshift-ansible/pulls/46/commits","review_comments_url":"https://api.github.com/repos/detiber/openshift-ansible/pulls/46/comments","review_comment_url":"https://api.github.com/repos/detiber/openshift-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/detiber/openshift-ansible/issues/46/comments","statuses_url":"https://api.github.com/repos/detiber/openshift-ansible/statuses/30550b6041c15db4794ba23937a1e04003bfd0f5","head":{"label":"sdodson:node-cert-names","ref":"node-cert-names","sha":"30550b6041c15db4794ba23937a1e04003bfd0f5","user":{"login":"sdodson","id":48161,"avatar_url":"https://avatars.githubusercontent.com/u/48161?v=3","gravatar_id":"","url":"https://api.github.com/users/sdodson","html_url":"https://github.com/sdodson","followers_url":"https://api.github.com/users/sdodson/followers","following_url":"https://api.github.com/users/sdodson/following{/other_user}","gists_url":"https://api.github.com/users/sdodson/gists{/gist_id}","starred_url":"https://api.github.com/users/sdodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdodson/subscriptions","organizations_url":"https://api.github.com/users/sdodson/orgs","repos_url":"https://api.github.com/users/sdodson/repos","events_url":"https://api.github.com/users/sdodson/events{/privacy}","received_events_url":"https://api.github.com/users/sdodson/received_events","type":"User","site_admin":false},"repo":{"id":32589211,"name":"openshift-ansible","full_name":"sdodson/openshift-ansible","owner":{"login":"sdodson","id":48161,"avatar_url":"https://avatars.githubusercontent.com/u/48161?v=3","gravatar_id":"","url":"https://api.github.com/users/sdodson","html_url":"https://github.com/sdodson","followers_url":"https://api.github.com/users/sdodson/followers","following_url":"https://api.github.com/users/sdodson/following{/other_user}","gists_url":"https://api.github.com/users/sdodson/gists{/gist_id}","starred_url":"https://api.github.com/users/sdodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdodson/subscriptions","organizations_url":"https://api.github.com/users/sdodson/orgs","repos_url":"https://api.github.com/users/sdodson/repos","events_url":"https://api.github.com/users/sdodson/events{/privacy}","received_events_url":"https://api.github.com/users/sdodson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sdodson/openshift-ansible","description":"OpenShift Ansible Code","fork":true,"url":"https://api.github.com/repos/sdodson/openshift-ansible","forks_url":"https://api.github.com/repos/sdodson/openshift-ansible/forks","keys_url":"https://api.github.com/repos/sdodson/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdodson/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdodson/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/sdodson/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/sdodson/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/sdodson/openshift-ansible/events","assignees_url":"https://api.github.com/repos/sdodson/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/sdodson/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/sdodson/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/sdodson/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdodson/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdodson/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdodson/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdodson/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/sdodson/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/sdodson/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/sdodson/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/sdodson/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/sdodson/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/sdodson/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdodson/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdodson/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdodson/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/sdodson/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/sdodson/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdodson/openshift-ansible/merges","archive_url":"https://api.github.com/repos/sdodson/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdodson/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/sdodson/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/sdodson/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/sdodson/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/sdodson/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdodson/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/sdodson/openshift-ansible/releases{/id}","created_at":"2015-03-20T14:44:06Z","updated_at":"2015-05-01T15:04:21Z","pushed_at":"2015-06-15T21:10:11Z","git_url":"git://github.com/sdodson/openshift-ansible.git","ssh_url":"git@github.com:sdodson/openshift-ansible.git","clone_url":"https://github.com/sdodson/openshift-ansible.git","svn_url":"https://github.com/sdodson/openshift-ansible","homepage":"","size":1188,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"detiber:rc","ref":"rc","sha":"97a919bcfbefba2976ca869ce348972fec9b7949","user":{"login":"detiber","id":915544,"avatar_url":"https://avatars.githubusercontent.com/u/915544?v=3","gravatar_id":"","url":"https://api.github.com/users/detiber","html_url":"https://github.com/detiber","followers_url":"https://api.github.com/users/detiber/followers","following_url":"https://api.github.com/users/detiber/following{/other_user}","gists_url":"https://api.github.com/users/detiber/gists{/gist_id}","starred_url":"https://api.github.com/users/detiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/detiber/subscriptions","organizations_url":"https://api.github.com/users/detiber/orgs","repos_url":"https://api.github.com/users/detiber/repos","events_url":"https://api.github.com/users/detiber/events{/privacy}","received_events_url":"https://api.github.com/users/detiber/received_events","type":"User","site_admin":false},"repo":{"id":29140945,"name":"openshift-ansible","full_name":"detiber/openshift-ansible","owner":{"login":"detiber","id":915544,"avatar_url":"https://avatars.githubusercontent.com/u/915544?v=3","gravatar_id":"","url":"https://api.github.com/users/detiber","html_url":"https://github.com/detiber","followers_url":"https://api.github.com/users/detiber/followers","following_url":"https://api.github.com/users/detiber/following{/other_user}","gists_url":"https://api.github.com/users/detiber/gists{/gist_id}","starred_url":"https://api.github.com/users/detiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/detiber/subscriptions","organizations_url":"https://api.github.com/users/detiber/orgs","repos_url":"https://api.github.com/users/detiber/repos","events_url":"https://api.github.com/users/detiber/events{/privacy}","received_events_url":"https://api.github.com/users/detiber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/detiber/openshift-ansible","description":"OpenShift Online's Ansible Code","fork":true,"url":"https://api.github.com/repos/detiber/openshift-ansible","forks_url":"https://api.github.com/repos/detiber/openshift-ansible/forks","keys_url":"https://api.github.com/repos/detiber/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/detiber/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/detiber/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/detiber/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/detiber/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/detiber/openshift-ansible/events","assignees_url":"https://api.github.com/repos/detiber/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/detiber/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/detiber/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/detiber/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/detiber/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/detiber/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/detiber/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/detiber/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/detiber/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/detiber/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/detiber/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/detiber/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/detiber/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/detiber/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/detiber/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/detiber/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/detiber/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/detiber/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/detiber/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/detiber/openshift-ansible/merges","archive_url":"https://api.github.com/repos/detiber/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/detiber/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/detiber/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/detiber/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/detiber/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/detiber/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/detiber/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/detiber/openshift-ansible/releases{/id}","created_at":"2015-01-12T15:09:30Z","updated_at":"2015-05-08T15:29:25Z","pushed_at":"2015-06-15T21:26:36Z","git_url":"git://github.com/detiber/openshift-ansible.git","ssh_url":"git@github.com:detiber/openshift-ansible.git","clone_url":"https://github.com/detiber/openshift-ansible.git","svn_url":"https://github.com/detiber/openshift-ansible","homepage":"","size":2331,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":9,"forks":8,"open_issues":9,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/detiber/openshift-ansible/pulls/46"},"html":{"href":"https://github.com/detiber/openshift-ansible/pull/46"},"issue":{"href":"https://api.github.com/repos/detiber/openshift-ansible/issues/46"},"comments":{"href":"https://api.github.com/repos/detiber/openshift-ansible/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/detiber/openshift-ansible/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/detiber/openshift-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/detiber/openshift-ansible/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/detiber/openshift-ansible/statuses/30550b6041c15db4794ba23937a1e04003bfd0f5"}}}}