{"action":"created","issue":{"url":"https://api.github.com/repos/moduloproject/pyappsch/issues/8","labels_url":"https://api.github.com/repos/moduloproject/pyappsch/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/moduloproject/pyappsch/issues/8/comments","events_url":"https://api.github.com/repos/moduloproject/pyappsch/issues/8/events","html_url":"https://github.com/moduloproject/pyappsch/pull/8","id":112216041,"number":8,"title":"Code Review \\O/","user":{"login":"Foggalong","id":5920259,"avatar_url":"https://avatars.githubusercontent.com/u/5920259?v=3","gravatar_id":"","url":"https://api.github.com/users/Foggalong","html_url":"https://github.com/Foggalong","followers_url":"https://api.github.com/users/Foggalong/followers","following_url":"https://api.github.com/users/Foggalong/following{/other_user}","gists_url":"https://api.github.com/users/Foggalong/gists{/gist_id}","starred_url":"https://api.github.com/users/Foggalong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Foggalong/subscriptions","organizations_url":"https://api.github.com/users/Foggalong/orgs","repos_url":"https://api.github.com/users/Foggalong/repos","events_url":"https://api.github.com/users/Foggalong/events{/privacy}","received_events_url":"https://api.github.com/users/Foggalong/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-10-19T19:34:23Z","updated_at":"2015-10-20T02:00:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/moduloproject/pyappsch/pulls/8","html_url":"https://github.com/moduloproject/pyappsch/pull/8","diff_url":"https://github.com/moduloproject/pyappsch/pull/8.diff","patch_url":"https://github.com/moduloproject/pyappsch/pull/8.patch"},"body":"Saw you wanted a review on Google+, so here on is! This is split into 5 parts:\r\n\r\n1. [Minor README adjustments](https://github.com/Foggalong/pyappsch/commit/a5049428de46f63d0798f70dbf4de302ff485cd4)\r\n  * Small grammatical error\r\n  * Added syntax highlighting for terminal input\r\n2. [Ad-hears to the PEP8 style guide](https://github.com/Foggalong/pyappsch/commit/d9802f02dac356a2722aafd81c2c4c285b305d36). If you've not seen it before I'd highly recommend you give it a [look over](https://www.python.org/dev/peps/pep-0008/) - it just details the best practices for writing Python code. Noticeable changes include:\r\n  * No trailing spaces\r\n  * Spaces around operators (e.g. `i = 1` not `i=1`)\r\n  * Double newlines before defining functions\r\n  * Spaces after commas (e.g, `x, y` not `x,y`)\r\n  * Module imports have to happen at the top of the file\r\n3. [Removing the deprecated `os.system` function](https://github.com/Foggalong/pyappsch/commit/596b9d60dcb5f04fd0491bd755acb5b47a29dede). You can read [the docs](https://docs.python.org/2/library/subprocess.html#replacing-older-functions-with-the-subprocess-module) for more information as to why, but basically you now have to use `subprocess.call` instead.\r\n4. [Cleaned up imports](https://github.com/Foggalong/pyappsch/commit/a3535da0c5b1e9a4c6942c4696c4813f504e1131). Generally it's better to only import the functions you need, rather than the whole module. Note the `from re import compile as recomp` is to avoid a function naming conflict with the default `compile()`.\r\n5. Probably one of the more controversial parts of the PEP8 is that it says you should be using [spaces rather than tabs](https://github.com/Foggalong/pyappsch/commit/4c6c80f682a317685a6d192aa05928cae641815d). This commit makes that switch."},"comment":{"url":"https://api.github.com/repos/moduloproject/pyappsch/issues/comments/149400858","html_url":"https://github.com/moduloproject/pyappsch/pull/8#issuecomment-149400858","issue_url":"https://api.github.com/repos/moduloproject/pyappsch/issues/8","id":149400858,"user":{"login":"crutchcorn","id":9100169,"avatar_url":"https://avatars.githubusercontent.com/u/9100169?v=3","gravatar_id":"","url":"https://api.github.com/users/crutchcorn","html_url":"https://github.com/crutchcorn","followers_url":"https://api.github.com/users/crutchcorn/followers","following_url":"https://api.github.com/users/crutchcorn/following{/other_user}","gists_url":"https://api.github.com/users/crutchcorn/gists{/gist_id}","starred_url":"https://api.github.com/users/crutchcorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crutchcorn/subscriptions","organizations_url":"https://api.github.com/users/crutchcorn/orgs","repos_url":"https://api.github.com/users/crutchcorn/repos","events_url":"https://api.github.com/users/crutchcorn/events{/privacy}","received_events_url":"https://api.github.com/users/crutchcorn/received_events","type":"User","site_admin":false},"created_at":"2015-10-20T02:00:03Z","updated_at":"2015-10-20T02:00:03Z","body":"You're the best! Thank you for the help yet again!\r\n\r\nI'd love to see how you did it as I could study up on the logic of how you did things! It would certainly teach me a lot! Perhaps not create a pull request but rather a gist or repo of your own?"}}