{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/TypeScript/issues/2946","labels_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/2946/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/2946/comments","events_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/2946/events","html_url":"https://github.com/Microsoft/TypeScript/pull/2946","id":71724049,"number":2946,"title":"Review PR: Abstract classes","user":{"login":"DickvdBrink","id":765657,"avatar_url":"https://avatars.githubusercontent.com/u/765657?v=3","gravatar_id":"","url":"https://api.github.com/users/DickvdBrink","html_url":"https://github.com/DickvdBrink","followers_url":"https://api.github.com/users/DickvdBrink/followers","following_url":"https://api.github.com/users/DickvdBrink/following{/other_user}","gists_url":"https://api.github.com/users/DickvdBrink/gists{/gist_id}","starred_url":"https://api.github.com/users/DickvdBrink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DickvdBrink/subscriptions","organizations_url":"https://api.github.com/users/DickvdBrink/orgs","repos_url":"https://api.github.com/users/DickvdBrink/repos","events_url":"https://api.github.com/users/DickvdBrink/events{/privacy}","received_events_url":"https://api.github.com/users/DickvdBrink/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Microsoft/TypeScript/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-04-28T22:23:37Z","updated_at":"2015-04-28T23:36:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/2946","html_url":"https://github.com/Microsoft/TypeScript/pull/2946","diff_url":"https://github.com/Microsoft/TypeScript/pull/2946.diff","patch_url":"https://github.com/Microsoft/TypeScript/pull/2946.patch"},"body":"This PR is only for review (to check if this is the right way to go)\r\n\r\n**NOTE** The baseline isn't correct yet (it says undefined)\r\n\r\nIf this isn't the right way, feel free to close this right away.\r\nAs mentioned in this [comment](https://github.com/Microsoft/TypeScript/issues/6#issuecomment-96850600) abstract will only be implemented for `classes` and not for `methods`/`properties`\r\n\r\n**edit**\r\nRefs #6, As mentioned there I should have shared a design first but I already created this part a few weeks back (just rewrote on top of the new `master` branch)"},"comment":{"url":"https://api.github.com/repos/Microsoft/TypeScript/issues/comments/97263854","html_url":"https://github.com/Microsoft/TypeScript/pull/2946#issuecomment-97263854","issue_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/2946","id":97263854,"user":{"login":"DickvdBrink","id":765657,"avatar_url":"https://avatars.githubusercontent.com/u/765657?v=3","gravatar_id":"","url":"https://api.github.com/users/DickvdBrink","html_url":"https://github.com/DickvdBrink","followers_url":"https://api.github.com/users/DickvdBrink/followers","following_url":"https://api.github.com/users/DickvdBrink/following{/other_user}","gists_url":"https://api.github.com/users/DickvdBrink/gists{/gist_id}","starred_url":"https://api.github.com/users/DickvdBrink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DickvdBrink/subscriptions","organizations_url":"https://api.github.com/users/DickvdBrink/orgs","repos_url":"https://api.github.com/users/DickvdBrink/repos","events_url":"https://api.github.com/users/DickvdBrink/events{/privacy}","received_events_url":"https://api.github.com/users/DickvdBrink/received_events","type":"User","site_admin":false},"created_at":"2015-04-28T23:36:24Z","updated_at":"2015-04-28T23:36:24Z","body":"I do have something to work with :) thanks for the reviews.\r\n\r\nThe only thing I really wanted to know if I was working in the right spots of the TS code (and that seems to be the case).\r\nSo not a lot more to discuss, will work on this stuff and I guess reopen/create a new one when in a more final state?"}}