{"action":"opened","number":212,"pull_request":{"url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/pulls/212","id":28337272,"html_url":"https://github.com/letsencrypt/lets-encrypt-preview/pull/212","diff_url":"https://github.com/letsencrypt/lets-encrypt-preview/pull/212.diff","patch_url":"https://github.com/letsencrypt/lets-encrypt-preview/pull/212.patch","issue_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/issues/212","number":212,"state":"open","locked":false,"title":"Patch auth handler cleanup","user":{"login":"jdkasten","id":1581662,"avatar_url":"https://avatars.githubusercontent.com/u/1581662?v=3","gravatar_id":"","url":"https://api.github.com/users/jdkasten","html_url":"https://github.com/jdkasten","followers_url":"https://api.github.com/users/jdkasten/followers","following_url":"https://api.github.com/users/jdkasten/following{/other_user}","gists_url":"https://api.github.com/users/jdkasten/gists{/gist_id}","starred_url":"https://api.github.com/users/jdkasten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdkasten/subscriptions","organizations_url":"https://api.github.com/users/jdkasten/orgs","repos_url":"https://api.github.com/users/jdkasten/repos","events_url":"https://api.github.com/users/jdkasten/events{/privacy}","received_events_url":"https://api.github.com/users/jdkasten/received_events","type":"User","site_admin":false},"body":"It came to my attention that auth_handler was sending down IndexedChallenges from challenge_util instead of a list of the raw types for the cleanup function.  I didn't write test_code for the cleanup as it was bound around protocol code (that will change).\r\n\r\nI fixed the bug (it wasn't affecting the ApacheConfigurator because it wasn't using the cleanup values... just the length of the list)\r\n\r\nI also added a catch around the perform functions so that Authenticators could throw appropriate errors and the AuthHandler could still cleanup.\r\n\r\nI added a test case for this new try block which also checks to make sure the cleanup functions are called appropriately.","created_at":"2015-01-30T04:21:16Z","updated_at":"2015-01-30T04:21:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/pulls/212/commits","review_comments_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/pulls/212/comments","review_comment_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/pulls/comments/{number}","comments_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/issues/212/comments","statuses_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/statuses/2cb4ab936d00e16aae143e199e9308d9cb94655c","head":{"label":"letsencrypt:patch_auth_handler_cleanup","ref":"patch_auth_handler_cleanup","sha":"2cb4ab936d00e16aae143e199e9308d9cb94655c","user":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"repo":{"id":26516210,"name":"lets-encrypt-preview","full_name":"letsencrypt/lets-encrypt-preview","owner":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/letsencrypt/lets-encrypt-preview","description":"An ACME client that can update Apache configurations (developer preview) ","fork":false,"url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview","forks_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/forks","keys_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/keys{/key_id}","collaborators_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/teams","hooks_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/hooks","issue_events_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/issues/events{/number}","events_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/events","assignees_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/assignees{/user}","branches_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/branches{/branch}","tags_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/tags","blobs_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/git/refs{/sha}","trees_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/git/trees{/sha}","statuses_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/statuses/{sha}","languages_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/languages","stargazers_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/stargazers","contributors_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/contributors","subscribers_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/subscribers","subscription_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/subscription","commits_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/commits{/sha}","git_commits_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/git/commits{/sha}","comments_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/comments{/number}","issue_comment_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/issues/comments/{number}","contents_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/contents/{+path}","compare_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/compare/{base}...{head}","merges_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/merges","archive_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/downloads","issues_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/issues{/number}","pulls_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/pulls{/number}","milestones_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/milestones{/number}","notifications_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/labels{/name}","releases_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/releases{/id}","created_at":"2014-11-12T02:52:20Z","updated_at":"2015-01-30T03:46:10Z","pushed_at":"2015-01-30T04:08:33Z","git_url":"git://github.com/letsencrypt/lets-encrypt-preview.git","ssh_url":"git@github.com:letsencrypt/lets-encrypt-preview.git","clone_url":"https://github.com/letsencrypt/lets-encrypt-preview.git","svn_url":"https://github.com/letsencrypt/lets-encrypt-preview","homepage":null,"size":3960,"stargazers_count":1346,"watchers_count":1346,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":89,"mirror_url":null,"open_issues_count":37,"forks":89,"open_issues":37,"watchers":1346,"default_branch":"master"}},"base":{"label":"letsencrypt:master","ref":"master","sha":"e56737de0bb2a923604c3eedf67f8e8400187364","user":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"repo":{"id":26516210,"name":"lets-encrypt-preview","full_name":"letsencrypt/lets-encrypt-preview","owner":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/letsencrypt/lets-encrypt-preview","description":"An ACME client that can update Apache configurations (developer preview) ","fork":false,"url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview","forks_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/forks","keys_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/keys{/key_id}","collaborators_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/teams","hooks_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/hooks","issue_events_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/issues/events{/number}","events_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/events","assignees_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/assignees{/user}","branches_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/branches{/branch}","tags_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/tags","blobs_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/git/refs{/sha}","trees_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/git/trees{/sha}","statuses_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/statuses/{sha}","languages_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/languages","stargazers_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/stargazers","contributors_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/contributors","subscribers_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/subscribers","subscription_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/subscription","commits_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/commits{/sha}","git_commits_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/git/commits{/sha}","comments_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/comments{/number}","issue_comment_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/issues/comments/{number}","contents_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/contents/{+path}","compare_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/compare/{base}...{head}","merges_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/merges","archive_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/downloads","issues_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/issues{/number}","pulls_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/pulls{/number}","milestones_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/milestones{/number}","notifications_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/labels{/name}","releases_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/releases{/id}","created_at":"2014-11-12T02:52:20Z","updated_at":"2015-01-30T03:46:10Z","pushed_at":"2015-01-30T04:08:33Z","git_url":"git://github.com/letsencrypt/lets-encrypt-preview.git","ssh_url":"git@github.com:letsencrypt/lets-encrypt-preview.git","clone_url":"https://github.com/letsencrypt/lets-encrypt-preview.git","svn_url":"https://github.com/letsencrypt/lets-encrypt-preview","homepage":null,"size":3960,"stargazers_count":1346,"watchers_count":1346,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":89,"mirror_url":null,"open_issues_count":37,"forks":89,"open_issues":37,"watchers":1346,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/pulls/212"},"html":{"href":"https://github.com/letsencrypt/lets-encrypt-preview/pull/212"},"issue":{"href":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/issues/212"},"comments":{"href":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/issues/212/comments"},"review_comments":{"href":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/pulls/212/comments"},"review_comment":{"href":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/pulls/212/commits"},"statuses":{"href":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/statuses/2cb4ab936d00e16aae143e199e9308d9cb94655c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":107,"deletions":21,"changed_files":3}}