{"action":"created","issue":{"url":"https://api.github.com/repos/SemanticMediaWiki/SemanticExtraSpecialProperties/issues/47","labels_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticExtraSpecialProperties/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticExtraSpecialProperties/issues/47/comments","events_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticExtraSpecialProperties/issues/47/events","html_url":"https://github.com/SemanticMediaWiki/SemanticExtraSpecialProperties/issues/47","id":89040036,"number":47,"title":"1.25 / WikiPage::getCount is gone","user":{"login":"mwjames","id":1245473,"avatar_url":"https://avatars.githubusercontent.com/u/1245473?v=3","gravatar_id":"","url":"https://api.github.com/users/mwjames","html_url":"https://github.com/mwjames","followers_url":"https://api.github.com/users/mwjames/followers","following_url":"https://api.github.com/users/mwjames/following{/other_user}","gists_url":"https://api.github.com/users/mwjames/gists{/gist_id}","starred_url":"https://api.github.com/users/mwjames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwjames/subscriptions","organizations_url":"https://api.github.com/users/mwjames/orgs","repos_url":"https://api.github.com/users/mwjames/repos","events_url":"https://api.github.com/users/mwjames/events{/privacy}","received_events_url":"https://api.github.com/users/mwjames/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/SemanticMediaWiki/SemanticExtraSpecialProperties/labels/feature","name":"feature","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/SemanticMediaWiki/SemanticExtraSpecialProperties/milestones/4","html_url":"https://github.com/SemanticMediaWiki/SemanticExtraSpecialProperties/milestones/SESP%201.4","labels_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticExtraSpecialProperties/milestones/4/labels","id":1173211,"number":4,"title":"SESP 1.4","description":"- Change dependency for SMW to require 2.3","creator":{"login":"mwjames","id":1245473,"avatar_url":"https://avatars.githubusercontent.com/u/1245473?v=3","gravatar_id":"","url":"https://api.github.com/users/mwjames","html_url":"https://github.com/mwjames","followers_url":"https://api.github.com/users/mwjames/followers","following_url":"https://api.github.com/users/mwjames/following{/other_user}","gists_url":"https://api.github.com/users/mwjames/gists{/gist_id}","starred_url":"https://api.github.com/users/mwjames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwjames/subscriptions","organizations_url":"https://api.github.com/users/mwjames/orgs","repos_url":"https://api.github.com/users/mwjames/repos","events_url":"https://api.github.com/users/mwjames/events{/privacy}","received_events_url":"https://api.github.com/users/mwjames/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2015-06-20T00:32:20Z","updated_at":"2015-07-18T19:35:45Z","due_on":"2015-08-19T22:00:00Z","closed_at":null},"comments":12,"created_at":"2015-06-17T14:55:48Z","updated_at":"2015-09-08T14:21:35Z","closed_at":null,"body":"I'm guessing \r\n\r\nhttps://github.com/SemanticMediaWiki/SemanticExtraSpecialProperties/blob/master/src/Annotator/ExtraPropertyAnnotator.php#L206-L209\r\n\r\n```\r\n\tprivate function makeNumberOfPageViewsDataItem() {\r\n\t\tif ( !$this->configuration['wgDisableCounters'] && $this->getWikiPage()->getCount() ) {\r\n\t\t\treturn new DINumber( $this->getWikiPage()->getCount() );\r\n\t\t}\r\n\t}\r\n```\r\n\r\nwill fail now that `WikiPage::getCount()` is gone in 1.25 (https://github.com/wikimedia/mediawiki/commit/90d90dad6e4d463b3db425d78f7ed1e084ca0816#diff-a0f7feeaae57e9d2c735c8919c16ad15)\r\n\r\nSee also https://gerrit.wikimedia.org/r/#/c/221427/.\r\n\r\n@kghbln Maybe something to follow-up? / https://www.mediawiki.org/wiki/Extension:HitCounters"},"comment":{"url":"https://api.github.com/repos/SemanticMediaWiki/SemanticExtraSpecialProperties/issues/comments/138577271","html_url":"https://github.com/SemanticMediaWiki/SemanticExtraSpecialProperties/issues/47#issuecomment-138577271","issue_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticExtraSpecialProperties/issues/47","id":138577271,"user":{"login":"mwjames","id":1245473,"avatar_url":"https://avatars.githubusercontent.com/u/1245473?v=3","gravatar_id":"","url":"https://api.github.com/users/mwjames","html_url":"https://github.com/mwjames","followers_url":"https://api.github.com/users/mwjames/followers","following_url":"https://api.github.com/users/mwjames/following{/other_user}","gists_url":"https://api.github.com/users/mwjames/gists{/gist_id}","starred_url":"https://api.github.com/users/mwjames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwjames/subscriptions","organizations_url":"https://api.github.com/users/mwjames/orgs","repos_url":"https://api.github.com/users/mwjames/repos","events_url":"https://api.github.com/users/mwjames/events{/privacy}","received_events_url":"https://api.github.com/users/mwjames/received_events","type":"User","site_admin":false},"created_at":"2015-09-08T14:21:35Z","updated_at":"2015-09-08T14:21:35Z","body":"> What is the next step in moving it forward? Is composer support in HitCounters the only limitation?\r\n\r\nIt would certainly help to clarify the dependency together with a spaghetti check that contains something like (under the expectation that `HitCounters::getCount` is a stable accessors):\r\n\r\n```\r\n\t\t$count = null;\r\n\r\n\t\tif ( class_exists( '\\HitCounters' ) ) {\r\n\t\t\t$count = \\HitCounters::getCount( $this->getWikiPage()->getTitle() );\r\n\t\t} else {\r\n\t\t\t$count = $this->getWikiPage()->getCount();\r\n\t\t}\r\n\r\n\t\tif ( !$this->configuration['wgDisableCounters'] && is_numeric( $count ) ) {\r\n\t\t\treturn new DINumber( $count );\r\n\t\t}\r\n```"}}