{"action":"created","comment":{"url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments/39337570","id":39337570,"diff_hunk":"@@ -330,16 +341,77 @@ s32 cellNetCtlGetInfo(s32 code, vm::ptr<CellNetCtlInfo> info)\n \t\tfreeifaddrs(ifaddr);\n #endif\n \t}\n+\telse\n+\t{\n+\t\tcellNetCtl.Todo(\"cellNetCtlGetInfo(code=0x%x (%s), info=*0x%x)\", code, InfoCodeToName(code), info);\n+\t}\n \n \treturn CELL_OK;\n }\n \n+void dialogOpenCallback()\n+{\n+\tnamed_thread_t(WRAP_EXPR(\"SignInDialog Thread\"), [=]()\n+\t{\n+\t\twhile (g_sign_in_dialog->state == signInDialogOpen)\n+\t\t{\n+\t\t\tif (Emu.IsStopped())\n+\t\t\t{\n+\t\t\t\tg_sign_in_dialog->state = signInDialogAbort;\n+\t\t\t\tbreak;\n+\t\t\t}\n+\n+\t\t\tstd::this_thread::sleep_for(std::chrono::milliseconds(1)); // hack\n+\t\t}\n+\n+\t\tCallAfter([]()\n+\t\t{\n+\t\t\tg_sign_in_dialog->Destroy();\n+\t\t\tg_sign_in_dialog->state = signInDialogNone;\n+\t\t});\n+\t}).detach();\n+}\n+\n s32 cellNetCtlNetStartDialogLoadAsync(vm::ptr<CellNetCtlNetStartDialogParam> param)\n {\n \tcellNetCtl.Warning(\"cellNetCtlNetStartDialogLoadAsync(param=*0x%x)\", param);\n \n-\t// TODO: Actually sign into PSN or an emulated network similar to PSN\n-\tsysutilSendSystemCommand(CELL_SYSUTIL_NET_CTL_NETSTART_FINISHED, 0);\n+\t// TODO: Actually sign into PSN or an emulated network similar to PSN (ESN)\n+\tsysutilSendSystemCommand(CELL_SYSUTIL_NET_CTL_NETSTART_LOADED, 0);\n+\n+\t// The way this is handled, is heavily inspired by the cellMsgDialogOpen2 implementation\n+\tif (1 && param->type == CELL_NET_CTL_NETSTART_TYPE_NP) // Currently disabled until ESN support is in","path":"rpcs3/Emu/SysCalls/Modules/cellNetCtl.cpp","position":72,"original_position":72,"commit_id":"f13a083330829746a1923e359b0f7d41dad259b7","original_commit_id":"f13a083330829746a1923e359b0f7d41dad259b7","user":{"login":"Nekotekina","id":6028184,"avatar_url":"https://avatars.githubusercontent.com/u/6028184?v=3","gravatar_id":"","url":"https://api.github.com/users/Nekotekina","html_url":"https://github.com/Nekotekina","followers_url":"https://api.github.com/users/Nekotekina/followers","following_url":"https://api.github.com/users/Nekotekina/following{/other_user}","gists_url":"https://api.github.com/users/Nekotekina/gists{/gist_id}","starred_url":"https://api.github.com/users/Nekotekina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nekotekina/subscriptions","organizations_url":"https://api.github.com/users/Nekotekina/orgs","repos_url":"https://api.github.com/users/Nekotekina/repos","events_url":"https://api.github.com/users/Nekotekina/events{/privacy}","received_events_url":"https://api.github.com/users/Nekotekina/received_events","type":"User","site_admin":false},"body":"These changes are likely wrong. If you understood them, you wouldn't copypaste them from msgdialog anyway. Just remove this from cellNetCtl completely (you still have SignInDialog.cpp draft). These functions should be faked for now in the way game would think that there is no Internet, PSN connection or both, according to circumstances. It is the best way for now.","created_at":"2015-09-12T14:05:49Z","updated_at":"2015-09-12T14:05:49Z","html_url":"https://github.com/RPCS3/rpcs3/pull/1216#discussion_r39337570","pull_request_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1216","_links":{"self":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments/39337570"},"html":{"href":"https://github.com/RPCS3/rpcs3/pull/1216#discussion_r39337570"},"pull_request":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1216"}}},"pull_request":{"url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1216","id":44797626,"html_url":"https://github.com/RPCS3/rpcs3/pull/1216","diff_url":"https://github.com/RPCS3/rpcs3/pull/1216.diff","patch_url":"https://github.com/RPCS3/rpcs3/pull/1216.patch","issue_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/1216","number":1216,"state":"open","locked":false,"title":"HLE improvements","user":{"login":"tambry","id":1827708,"avatar_url":"https://avatars.githubusercontent.com/u/1827708?v=3","gravatar_id":"","url":"https://api.github.com/users/tambry","html_url":"https://github.com/tambry","followers_url":"https://api.github.com/users/tambry/followers","following_url":"https://api.github.com/users/tambry/following{/other_user}","gists_url":"https://api.github.com/users/tambry/gists{/gist_id}","starred_url":"https://api.github.com/users/tambry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tambry/subscriptions","organizations_url":"https://api.github.com/users/tambry/orgs","repos_url":"https://api.github.com/users/tambry/repos","events_url":"https://api.github.com/users/tambry/events{/privacy}","received_events_url":"https://api.github.com/users/tambry/received_events","type":"User","site_admin":false},"body":"Mostly ported safe stuff over from #1205. Other stuff that was in that one, I'll probably further cleanup (cellGcm and RSX) and then will include as a part of another PR in the future.","created_at":"2015-09-11T15:45:27Z","updated_at":"2015-09-12T14:05:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08d91d904a5d115c0d274b3e56cf8e60b4524bdd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1216/commits","review_comments_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1216/comments","review_comment_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/1216/comments","statuses_url":"https://api.github.com/repos/RPCS3/rpcs3/statuses/f13a083330829746a1923e359b0f7d41dad259b7","head":{"label":"tambry:errormerge","ref":"errormerge","sha":"f13a083330829746a1923e359b0f7d41dad259b7","user":{"login":"tambry","id":1827708,"avatar_url":"https://avatars.githubusercontent.com/u/1827708?v=3","gravatar_id":"","url":"https://api.github.com/users/tambry","html_url":"https://github.com/tambry","followers_url":"https://api.github.com/users/tambry/followers","following_url":"https://api.github.com/users/tambry/following{/other_user}","gists_url":"https://api.github.com/users/tambry/gists{/gist_id}","starred_url":"https://api.github.com/users/tambry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tambry/subscriptions","organizations_url":"https://api.github.com/users/tambry/orgs","repos_url":"https://api.github.com/users/tambry/repos","events_url":"https://api.github.com/users/tambry/events{/privacy}","received_events_url":"https://api.github.com/users/tambry/received_events","type":"User","site_admin":false},"repo":{"id":36735794,"name":"rpcs3","full_name":"tambry/rpcs3","owner":{"login":"tambry","id":1827708,"avatar_url":"https://avatars.githubusercontent.com/u/1827708?v=3","gravatar_id":"","url":"https://api.github.com/users/tambry","html_url":"https://github.com/tambry","followers_url":"https://api.github.com/users/tambry/followers","following_url":"https://api.github.com/users/tambry/following{/other_user}","gists_url":"https://api.github.com/users/tambry/gists{/gist_id}","starred_url":"https://api.github.com/users/tambry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tambry/subscriptions","organizations_url":"https://api.github.com/users/tambry/orgs","repos_url":"https://api.github.com/users/tambry/repos","events_url":"https://api.github.com/users/tambry/events{/privacy}","received_events_url":"https://api.github.com/users/tambry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tambry/rpcs3","description":"PS3 emulator/debugger","fork":true,"url":"https://api.github.com/repos/tambry/rpcs3","forks_url":"https://api.github.com/repos/tambry/rpcs3/forks","keys_url":"https://api.github.com/repos/tambry/rpcs3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tambry/rpcs3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tambry/rpcs3/teams","hooks_url":"https://api.github.com/repos/tambry/rpcs3/hooks","issue_events_url":"https://api.github.com/repos/tambry/rpcs3/issues/events{/number}","events_url":"https://api.github.com/repos/tambry/rpcs3/events","assignees_url":"https://api.github.com/repos/tambry/rpcs3/assignees{/user}","branches_url":"https://api.github.com/repos/tambry/rpcs3/branches{/branch}","tags_url":"https://api.github.com/repos/tambry/rpcs3/tags","blobs_url":"https://api.github.com/repos/tambry/rpcs3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tambry/rpcs3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tambry/rpcs3/git/refs{/sha}","trees_url":"https://api.github.com/repos/tambry/rpcs3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tambry/rpcs3/statuses/{sha}","languages_url":"https://api.github.com/repos/tambry/rpcs3/languages","stargazers_url":"https://api.github.com/repos/tambry/rpcs3/stargazers","contributors_url":"https://api.github.com/repos/tambry/rpcs3/contributors","subscribers_url":"https://api.github.com/repos/tambry/rpcs3/subscribers","subscription_url":"https://api.github.com/repos/tambry/rpcs3/subscription","commits_url":"https://api.github.com/repos/tambry/rpcs3/commits{/sha}","git_commits_url":"https://api.github.com/repos/tambry/rpcs3/git/commits{/sha}","comments_url":"https://api.github.com/repos/tambry/rpcs3/comments{/number}","issue_comment_url":"https://api.github.com/repos/tambry/rpcs3/issues/comments{/number}","contents_url":"https://api.github.com/repos/tambry/rpcs3/contents/{+path}","compare_url":"https://api.github.com/repos/tambry/rpcs3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tambry/rpcs3/merges","archive_url":"https://api.github.com/repos/tambry/rpcs3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tambry/rpcs3/downloads","issues_url":"https://api.github.com/repos/tambry/rpcs3/issues{/number}","pulls_url":"https://api.github.com/repos/tambry/rpcs3/pulls{/number}","milestones_url":"https://api.github.com/repos/tambry/rpcs3/milestones{/number}","notifications_url":"https://api.github.com/repos/tambry/rpcs3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tambry/rpcs3/labels{/name}","releases_url":"https://api.github.com/repos/tambry/rpcs3/releases{/id}","created_at":"2015-06-02T13:40:11Z","updated_at":"2015-08-31T19:07:29Z","pushed_at":"2015-09-12T11:12:03Z","git_url":"git://github.com/tambry/rpcs3.git","ssh_url":"git@github.com:tambry/rpcs3.git","clone_url":"https://github.com/tambry/rpcs3.git","svn_url":"https://github.com/tambry/rpcs3","homepage":null,"size":25728,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"RPCS3:master","ref":"master","sha":"cbe83ad8dd052d00c415d489fcf4a95466690bea","user":{"login":"RPCS3","id":8070735,"avatar_url":"https://avatars.githubusercontent.com/u/8070735?v=3","gravatar_id":"","url":"https://api.github.com/users/RPCS3","html_url":"https://github.com/RPCS3","followers_url":"https://api.github.com/users/RPCS3/followers","following_url":"https://api.github.com/users/RPCS3/following{/other_user}","gists_url":"https://api.github.com/users/RPCS3/gists{/gist_id}","starred_url":"https://api.github.com/users/RPCS3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RPCS3/subscriptions","organizations_url":"https://api.github.com/users/RPCS3/orgs","repos_url":"https://api.github.com/users/RPCS3/repos","events_url":"https://api.github.com/users/RPCS3/events{/privacy}","received_events_url":"https://api.github.com/users/RPCS3/received_events","type":"Organization","site_admin":false},"repo":{"id":6520784,"name":"rpcs3","full_name":"RPCS3/rpcs3","owner":{"login":"RPCS3","id":8070735,"avatar_url":"https://avatars.githubusercontent.com/u/8070735?v=3","gravatar_id":"","url":"https://api.github.com/users/RPCS3","html_url":"https://github.com/RPCS3","followers_url":"https://api.github.com/users/RPCS3/followers","following_url":"https://api.github.com/users/RPCS3/following{/other_user}","gists_url":"https://api.github.com/users/RPCS3/gists{/gist_id}","starred_url":"https://api.github.com/users/RPCS3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RPCS3/subscriptions","organizations_url":"https://api.github.com/users/RPCS3/orgs","repos_url":"https://api.github.com/users/RPCS3/repos","events_url":"https://api.github.com/users/RPCS3/events{/privacy}","received_events_url":"https://api.github.com/users/RPCS3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RPCS3/rpcs3","description":"PS3 emulator/debugger","fork":false,"url":"https://api.github.com/repos/RPCS3/rpcs3","forks_url":"https://api.github.com/repos/RPCS3/rpcs3/forks","keys_url":"https://api.github.com/repos/RPCS3/rpcs3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RPCS3/rpcs3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RPCS3/rpcs3/teams","hooks_url":"https://api.github.com/repos/RPCS3/rpcs3/hooks","issue_events_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/events{/number}","events_url":"https://api.github.com/repos/RPCS3/rpcs3/events","assignees_url":"https://api.github.com/repos/RPCS3/rpcs3/assignees{/user}","branches_url":"https://api.github.com/repos/RPCS3/rpcs3/branches{/branch}","tags_url":"https://api.github.com/repos/RPCS3/rpcs3/tags","blobs_url":"https://api.github.com/repos/RPCS3/rpcs3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RPCS3/rpcs3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RPCS3/rpcs3/git/refs{/sha}","trees_url":"https://api.github.com/repos/RPCS3/rpcs3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RPCS3/rpcs3/statuses/{sha}","languages_url":"https://api.github.com/repos/RPCS3/rpcs3/languages","stargazers_url":"https://api.github.com/repos/RPCS3/rpcs3/stargazers","contributors_url":"https://api.github.com/repos/RPCS3/rpcs3/contributors","subscribers_url":"https://api.github.com/repos/RPCS3/rpcs3/subscribers","subscription_url":"https://api.github.com/repos/RPCS3/rpcs3/subscription","commits_url":"https://api.github.com/repos/RPCS3/rpcs3/commits{/sha}","git_commits_url":"https://api.github.com/repos/RPCS3/rpcs3/git/commits{/sha}","comments_url":"https://api.github.com/repos/RPCS3/rpcs3/comments{/number}","issue_comment_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/comments{/number}","contents_url":"https://api.github.com/repos/RPCS3/rpcs3/contents/{+path}","compare_url":"https://api.github.com/repos/RPCS3/rpcs3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RPCS3/rpcs3/merges","archive_url":"https://api.github.com/repos/RPCS3/rpcs3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RPCS3/rpcs3/downloads","issues_url":"https://api.github.com/repos/RPCS3/rpcs3/issues{/number}","pulls_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls{/number}","milestones_url":"https://api.github.com/repos/RPCS3/rpcs3/milestones{/number}","notifications_url":"https://api.github.com/repos/RPCS3/rpcs3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RPCS3/rpcs3/labels{/name}","releases_url":"https://api.github.com/repos/RPCS3/rpcs3/releases{/id}","created_at":"2012-11-03T15:16:18Z","updated_at":"2015-09-11T14:15:08Z","pushed_at":"2015-09-12T11:12:04Z","git_url":"git://github.com/RPCS3/rpcs3.git","ssh_url":"git@github.com:RPCS3/rpcs3.git","clone_url":"https://github.com/RPCS3/rpcs3.git","svn_url":"https://github.com/RPCS3/rpcs3","homepage":null,"size":74052,"stargazers_count":1598,"watchers_count":1598,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":302,"mirror_url":null,"open_issues_count":36,"forks":302,"open_issues":36,"watchers":1598,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1216"},"html":{"href":"https://github.com/RPCS3/rpcs3/pull/1216"},"issue":{"href":"https://api.github.com/repos/RPCS3/rpcs3/issues/1216"},"comments":{"href":"https://api.github.com/repos/RPCS3/rpcs3/issues/1216/comments"},"review_comments":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1216/comments"},"review_comment":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1216/commits"},"statuses":{"href":"https://api.github.com/repos/RPCS3/rpcs3/statuses/f13a083330829746a1923e359b0f7d41dad259b7"}}}}