{"action":"created","comment":{"url":"https://api.github.com/repos/letsencrypt/boulder/pulls/comments/31053554","id":31053554,"diff_hunk":"@@ -708,7 +708,11 @@ func (wfe *WebFrontEndImpl) Certificate(response http.ResponseWriter, request *h\n \n \t\tcert, err := wfe.SA.GetCertificateByShortSerial(serial)\n \t\tif err != nil {\n-\t\t\twfe.sendError(response, \"Not found\", err, http.StatusNotFound)\n+\t\t\tif strings.HasPrefix(err.Error(), \"gorp: multiple rows returned\") {","path":"wfe/web-front-end.go","position":5,"original_position":5,"commit_id":"5541a8ab373ff38970baccd71bf379bbad65071d","original_commit_id":"5541a8ab373ff38970baccd71bf379bbad65071d","user":{"login":"jcjones","id":518542,"avatar_url":"https://avatars.githubusercontent.com/u/518542?v=3","gravatar_id":"","url":"https://api.github.com/users/jcjones","html_url":"https://github.com/jcjones","followers_url":"https://api.github.com/users/jcjones/followers","following_url":"https://api.github.com/users/jcjones/following{/other_user}","gists_url":"https://api.github.com/users/jcjones/gists{/gist_id}","starred_url":"https://api.github.com/users/jcjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcjones/subscriptions","organizations_url":"https://api.github.com/users/jcjones/orgs","repos_url":"https://api.github.com/users/jcjones/repos","events_url":"https://api.github.com/users/jcjones/events{/privacy}","received_events_url":"https://api.github.com/users/jcjones/received_events","type":"User","site_admin":false},"body":"Gorp is already doing a multiple-row select on the call to [SelectOne](https://github.com/go-gorp/gorp/blob/master/gorp.go#L1537) and, annoyingly, is not returning a const object.\r\n\r\nI think this is a flaw with Gorp, but rather than code around it, let's keep the code as it is and let Gorp improve the situation. I'm going to file a bug upstream and will note it here.","created_at":"2015-05-26T16:39:22Z","updated_at":"2015-05-26T16:39:22Z","html_url":"https://github.com/letsencrypt/boulder/pull/224#discussion_r31053554","pull_request_url":"https://api.github.com/repos/letsencrypt/boulder/pulls/224","_links":{"self":{"href":"https://api.github.com/repos/letsencrypt/boulder/pulls/comments/31053554"},"html":{"href":"https://github.com/letsencrypt/boulder/pull/224#discussion_r31053554"},"pull_request":{"href":"https://api.github.com/repos/letsencrypt/boulder/pulls/224"}}},"pull_request":{"url":"https://api.github.com/repos/letsencrypt/boulder/pulls/224","id":36124768,"html_url":"https://github.com/letsencrypt/boulder/pull/224","diff_url":"https://github.com/letsencrypt/boulder/pull/224.diff","patch_url":"https://github.com/letsencrypt/boulder/pull/224.patch","issue_url":"https://api.github.com/repos/letsencrypt/boulder/issues/224","number":224,"state":"open","locked":false,"title":"Return 500 for multiple certs with same short serial","user":{"login":"rolandshoemaker","id":5080674,"avatar_url":"https://avatars.githubusercontent.com/u/5080674?v=3","gravatar_id":"","url":"https://api.github.com/users/rolandshoemaker","html_url":"https://github.com/rolandshoemaker","followers_url":"https://api.github.com/users/rolandshoemaker/followers","following_url":"https://api.github.com/users/rolandshoemaker/following{/other_user}","gists_url":"https://api.github.com/users/rolandshoemaker/gists{/gist_id}","starred_url":"https://api.github.com/users/rolandshoemaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolandshoemaker/subscriptions","organizations_url":"https://api.github.com/users/rolandshoemaker/orgs","repos_url":"https://api.github.com/users/rolandshoemaker/repos","events_url":"https://api.github.com/users/rolandshoemaker/events{/privacy}","received_events_url":"https://api.github.com/users/rolandshoemaker/received_events","type":"User","site_admin":false},"body":"Fixes #182.","created_at":"2015-05-25T08:27:18Z","updated_at":"2015-05-26T16:39:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa48263f22b6c5b2b6d3e644795936a2a4d164bd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/letsencrypt/boulder/pulls/224/commits","review_comments_url":"https://api.github.com/repos/letsencrypt/boulder/pulls/224/comments","review_comment_url":"https://api.github.com/repos/letsencrypt/boulder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/letsencrypt/boulder/issues/224/comments","statuses_url":"https://api.github.com/repos/letsencrypt/boulder/statuses/5541a8ab373ff38970baccd71bf379bbad65071d","head":{"label":"rolandshoemaker:182-return","ref":"182-return","sha":"5541a8ab373ff38970baccd71bf379bbad65071d","user":{"login":"rolandshoemaker","id":5080674,"avatar_url":"https://avatars.githubusercontent.com/u/5080674?v=3","gravatar_id":"","url":"https://api.github.com/users/rolandshoemaker","html_url":"https://github.com/rolandshoemaker","followers_url":"https://api.github.com/users/rolandshoemaker/followers","following_url":"https://api.github.com/users/rolandshoemaker/following{/other_user}","gists_url":"https://api.github.com/users/rolandshoemaker/gists{/gist_id}","starred_url":"https://api.github.com/users/rolandshoemaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolandshoemaker/subscriptions","organizations_url":"https://api.github.com/users/rolandshoemaker/orgs","repos_url":"https://api.github.com/users/rolandshoemaker/repos","events_url":"https://api.github.com/users/rolandshoemaker/events{/privacy}","received_events_url":"https://api.github.com/users/rolandshoemaker/received_events","type":"User","site_admin":false},"repo":{"id":32896331,"name":"boulder","full_name":"rolandshoemaker/boulder","owner":{"login":"rolandshoemaker","id":5080674,"avatar_url":"https://avatars.githubusercontent.com/u/5080674?v=3","gravatar_id":"","url":"https://api.github.com/users/rolandshoemaker","html_url":"https://github.com/rolandshoemaker","followers_url":"https://api.github.com/users/rolandshoemaker/followers","following_url":"https://api.github.com/users/rolandshoemaker/following{/other_user}","gists_url":"https://api.github.com/users/rolandshoemaker/gists{/gist_id}","starred_url":"https://api.github.com/users/rolandshoemaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolandshoemaker/subscriptions","organizations_url":"https://api.github.com/users/rolandshoemaker/orgs","repos_url":"https://api.github.com/users/rolandshoemaker/repos","events_url":"https://api.github.com/users/rolandshoemaker/events{/privacy}","received_events_url":"https://api.github.com/users/rolandshoemaker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rolandshoemaker/boulder","description":"An ACME-based CA, written in Go.","fork":true,"url":"https://api.github.com/repos/rolandshoemaker/boulder","forks_url":"https://api.github.com/repos/rolandshoemaker/boulder/forks","keys_url":"https://api.github.com/repos/rolandshoemaker/boulder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rolandshoemaker/boulder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rolandshoemaker/boulder/teams","hooks_url":"https://api.github.com/repos/rolandshoemaker/boulder/hooks","issue_events_url":"https://api.github.com/repos/rolandshoemaker/boulder/issues/events{/number}","events_url":"https://api.github.com/repos/rolandshoemaker/boulder/events","assignees_url":"https://api.github.com/repos/rolandshoemaker/boulder/assignees{/user}","branches_url":"https://api.github.com/repos/rolandshoemaker/boulder/branches{/branch}","tags_url":"https://api.github.com/repos/rolandshoemaker/boulder/tags","blobs_url":"https://api.github.com/repos/rolandshoemaker/boulder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rolandshoemaker/boulder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rolandshoemaker/boulder/git/refs{/sha}","trees_url":"https://api.github.com/repos/rolandshoemaker/boulder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rolandshoemaker/boulder/statuses/{sha}","languages_url":"https://api.github.com/repos/rolandshoemaker/boulder/languages","stargazers_url":"https://api.github.com/repos/rolandshoemaker/boulder/stargazers","contributors_url":"https://api.github.com/repos/rolandshoemaker/boulder/contributors","subscribers_url":"https://api.github.com/repos/rolandshoemaker/boulder/subscribers","subscription_url":"https://api.github.com/repos/rolandshoemaker/boulder/subscription","commits_url":"https://api.github.com/repos/rolandshoemaker/boulder/commits{/sha}","git_commits_url":"https://api.github.com/repos/rolandshoemaker/boulder/git/commits{/sha}","comments_url":"https://api.github.com/repos/rolandshoemaker/boulder/comments{/number}","issue_comment_url":"https://api.github.com/repos/rolandshoemaker/boulder/issues/comments{/number}","contents_url":"https://api.github.com/repos/rolandshoemaker/boulder/contents/{+path}","compare_url":"https://api.github.com/repos/rolandshoemaker/boulder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rolandshoemaker/boulder/merges","archive_url":"https://api.github.com/repos/rolandshoemaker/boulder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rolandshoemaker/boulder/downloads","issues_url":"https://api.github.com/repos/rolandshoemaker/boulder/issues{/number}","pulls_url":"https://api.github.com/repos/rolandshoemaker/boulder/pulls{/number}","milestones_url":"https://api.github.com/repos/rolandshoemaker/boulder/milestones{/number}","notifications_url":"https://api.github.com/repos/rolandshoemaker/boulder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rolandshoemaker/boulder/labels{/name}","releases_url":"https://api.github.com/repos/rolandshoemaker/boulder/releases{/id}","created_at":"2015-03-25T23:12:33Z","updated_at":"2015-04-30T07:04:29Z","pushed_at":"2015-05-26T16:08:54Z","git_url":"git://github.com/rolandshoemaker/boulder.git","ssh_url":"git@github.com:rolandshoemaker/boulder.git","clone_url":"https://github.com/rolandshoemaker/boulder.git","svn_url":"https://github.com/rolandshoemaker/boulder","homepage":null,"size":4560,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"letsencrypt:master","ref":"master","sha":"4a92001a5fe2cacf07e6e375e45fa0409b19a428","user":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"repo":{"id":28283593,"name":"boulder","full_name":"letsencrypt/boulder","owner":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/letsencrypt/boulder","description":"An ACME-based CA, written in Go.","fork":false,"url":"https://api.github.com/repos/letsencrypt/boulder","forks_url":"https://api.github.com/repos/letsencrypt/boulder/forks","keys_url":"https://api.github.com/repos/letsencrypt/boulder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/letsencrypt/boulder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/letsencrypt/boulder/teams","hooks_url":"https://api.github.com/repos/letsencrypt/boulder/hooks","issue_events_url":"https://api.github.com/repos/letsencrypt/boulder/issues/events{/number}","events_url":"https://api.github.com/repos/letsencrypt/boulder/events","assignees_url":"https://api.github.com/repos/letsencrypt/boulder/assignees{/user}","branches_url":"https://api.github.com/repos/letsencrypt/boulder/branches{/branch}","tags_url":"https://api.github.com/repos/letsencrypt/boulder/tags","blobs_url":"https://api.github.com/repos/letsencrypt/boulder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/letsencrypt/boulder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/letsencrypt/boulder/git/refs{/sha}","trees_url":"https://api.github.com/repos/letsencrypt/boulder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/letsencrypt/boulder/statuses/{sha}","languages_url":"https://api.github.com/repos/letsencrypt/boulder/languages","stargazers_url":"https://api.github.com/repos/letsencrypt/boulder/stargazers","contributors_url":"https://api.github.com/repos/letsencrypt/boulder/contributors","subscribers_url":"https://api.github.com/repos/letsencrypt/boulder/subscribers","subscription_url":"https://api.github.com/repos/letsencrypt/boulder/subscription","commits_url":"https://api.github.com/repos/letsencrypt/boulder/commits{/sha}","git_commits_url":"https://api.github.com/repos/letsencrypt/boulder/git/commits{/sha}","comments_url":"https://api.github.com/repos/letsencrypt/boulder/comments{/number}","issue_comment_url":"https://api.github.com/repos/letsencrypt/boulder/issues/comments{/number}","contents_url":"https://api.github.com/repos/letsencrypt/boulder/contents/{+path}","compare_url":"https://api.github.com/repos/letsencrypt/boulder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/letsencrypt/boulder/merges","archive_url":"https://api.github.com/repos/letsencrypt/boulder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/letsencrypt/boulder/downloads","issues_url":"https://api.github.com/repos/letsencrypt/boulder/issues{/number}","pulls_url":"https://api.github.com/repos/letsencrypt/boulder/pulls{/number}","milestones_url":"https://api.github.com/repos/letsencrypt/boulder/milestones{/number}","notifications_url":"https://api.github.com/repos/letsencrypt/boulder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/letsencrypt/boulder/labels{/name}","releases_url":"https://api.github.com/repos/letsencrypt/boulder/releases{/id}","created_at":"2014-12-21T00:29:54Z","updated_at":"2015-05-26T13:01:43Z","pushed_at":"2015-05-26T16:11:08Z","git_url":"git://github.com/letsencrypt/boulder.git","ssh_url":"git@github.com:letsencrypt/boulder.git","clone_url":"https://github.com/letsencrypt/boulder.git","svn_url":"https://github.com/letsencrypt/boulder","homepage":null,"size":6513,"stargazers_count":464,"watchers_count":464,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":49,"forks":33,"open_issues":49,"watchers":464,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/letsencrypt/boulder/pulls/224"},"html":{"href":"https://github.com/letsencrypt/boulder/pull/224"},"issue":{"href":"https://api.github.com/repos/letsencrypt/boulder/issues/224"},"comments":{"href":"https://api.github.com/repos/letsencrypt/boulder/issues/224/comments"},"review_comments":{"href":"https://api.github.com/repos/letsencrypt/boulder/pulls/224/comments"},"review_comment":{"href":"https://api.github.com/repos/letsencrypt/boulder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/letsencrypt/boulder/pulls/224/commits"},"statuses":{"href":"https://api.github.com/repos/letsencrypt/boulder/statuses/5541a8ab373ff38970baccd71bf379bbad65071d"}}}}