{"action":"closed","number":166,"pull_request":{"url":"https://api.github.com/repos/alphagov/manuals-frontend/pulls/166","id":49261929,"html_url":"https://github.com/alphagov/manuals-frontend/pull/166","diff_url":"https://github.com/alphagov/manuals-frontend/pull/166.diff","patch_url":"https://github.com/alphagov/manuals-frontend/pull/166.patch","issue_url":"https://api.github.com/repos/alphagov/manuals-frontend/issues/166","number":166,"state":"closed","locked":false,"title":"Fix multiple creation of close spans","user":{"login":"davidbasalla","id":5112255,"avatar_url":"https://avatars.githubusercontent.com/u/5112255?v=3","gravatar_id":"","url":"https://api.github.com/users/davidbasalla","html_url":"https://github.com/davidbasalla","followers_url":"https://api.github.com/users/davidbasalla/followers","following_url":"https://api.github.com/users/davidbasalla/following{/other_user}","gists_url":"https://api.github.com/users/davidbasalla/gists{/gist_id}","starred_url":"https://api.github.com/users/davidbasalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidbasalla/subscriptions","organizations_url":"https://api.github.com/users/davidbasalla/orgs","repos_url":"https://api.github.com/users/davidbasalla/repos","events_url":"https://api.github.com/users/davidbasalla/events{/privacy}","received_events_url":"https://api.github.com/users/davidbasalla/received_events","type":"User","site_admin":false},"body":"This fixes an issue for when a Collapsible would be opened by clicking on a link to it, a new Collapsible was created for it. In practice this meant that a collapsible could have an increasing number of clickable spans, which lead to unexpected such as a click not appearing to open a span (while actually the click was triggering the toggle open action twice, thereby opening and immediately closing the Collapsible). As part of the fix, some functionality was extracted to separate methods and respective Jasmine tests have been added.","created_at":"2015-10-30T12:11:11Z","updated_at":"2015-11-02T10:26:12Z","closed_at":"2015-11-02T10:26:12Z","merged_at":"2015-11-02T10:26:12Z","merge_commit_sha":"5ca88b1f9ee5b45207fe6d496967ec9dcc93482a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/manuals-frontend/pulls/166/commits","review_comments_url":"https://api.github.com/repos/alphagov/manuals-frontend/pulls/166/comments","review_comment_url":"https://api.github.com/repos/alphagov/manuals-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/manuals-frontend/issues/166/comments","statuses_url":"https://api.github.com/repos/alphagov/manuals-frontend/statuses/c037f89d182ac6b1f6e34203421777bbc3ab0e39","head":{"label":"alphagov:fix-multiple-creation-of-close-spans","ref":"fix-multiple-creation-of-close-spans","sha":"c037f89d182ac6b1f6e34203421777bbc3ab0e39","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":18512586,"name":"manuals-frontend","full_name":"alphagov/manuals-frontend","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/manuals-frontend","description":"Front-end app for the manuals format on GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/manuals-frontend","forks_url":"https://api.github.com/repos/alphagov/manuals-frontend/forks","keys_url":"https://api.github.com/repos/alphagov/manuals-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/manuals-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/manuals-frontend/teams","hooks_url":"https://api.github.com/repos/alphagov/manuals-frontend/hooks","issue_events_url":"https://api.github.com/repos/alphagov/manuals-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/manuals-frontend/events","assignees_url":"https://api.github.com/repos/alphagov/manuals-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/manuals-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/manuals-frontend/tags","blobs_url":"https://api.github.com/repos/alphagov/manuals-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/manuals-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/manuals-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/manuals-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/manuals-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/manuals-frontend/languages","stargazers_url":"https://api.github.com/repos/alphagov/manuals-frontend/stargazers","contributors_url":"https://api.github.com/repos/alphagov/manuals-frontend/contributors","subscribers_url":"https://api.github.com/repos/alphagov/manuals-frontend/subscribers","subscription_url":"https://api.github.com/repos/alphagov/manuals-frontend/subscription","commits_url":"https://api.github.com/repos/alphagov/manuals-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/manuals-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/manuals-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/manuals-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/manuals-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/manuals-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/manuals-frontend/merges","archive_url":"https://api.github.com/repos/alphagov/manuals-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/manuals-frontend/downloads","issues_url":"https://api.github.com/repos/alphagov/manuals-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/manuals-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/manuals-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/manuals-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/manuals-frontend/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/manuals-frontend/releases{/id}","created_at":"2014-04-07T09:51:47Z","updated_at":"2015-04-20T15:35:52Z","pushed_at":"2015-11-02T10:26:13Z","git_url":"git://github.com/alphagov/manuals-frontend.git","ssh_url":"git@github.com:alphagov/manuals-frontend.git","clone_url":"https://github.com/alphagov/manuals-frontend.git","svn_url":"https://github.com/alphagov/manuals-frontend","homepage":"","size":5811,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"d30ee50e74ebcbbf71444a6b387d2e5cfcddf4e6","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":18512586,"name":"manuals-frontend","full_name":"alphagov/manuals-frontend","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/manuals-frontend","description":"Front-end app for the manuals format on GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/manuals-frontend","forks_url":"https://api.github.com/repos/alphagov/manuals-frontend/forks","keys_url":"https://api.github.com/repos/alphagov/manuals-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/manuals-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/manuals-frontend/teams","hooks_url":"https://api.github.com/repos/alphagov/manuals-frontend/hooks","issue_events_url":"https://api.github.com/repos/alphagov/manuals-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/manuals-frontend/events","assignees_url":"https://api.github.com/repos/alphagov/manuals-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/manuals-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/manuals-frontend/tags","blobs_url":"https://api.github.com/repos/alphagov/manuals-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/manuals-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/manuals-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/manuals-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/manuals-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/manuals-frontend/languages","stargazers_url":"https://api.github.com/repos/alphagov/manuals-frontend/stargazers","contributors_url":"https://api.github.com/repos/alphagov/manuals-frontend/contributors","subscribers_url":"https://api.github.com/repos/alphagov/manuals-frontend/subscribers","subscription_url":"https://api.github.com/repos/alphagov/manuals-frontend/subscription","commits_url":"https://api.github.com/repos/alphagov/manuals-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/manuals-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/manuals-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/manuals-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/manuals-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/manuals-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/manuals-frontend/merges","archive_url":"https://api.github.com/repos/alphagov/manuals-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/manuals-frontend/downloads","issues_url":"https://api.github.com/repos/alphagov/manuals-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/manuals-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/manuals-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/manuals-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/manuals-frontend/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/manuals-frontend/releases{/id}","created_at":"2014-04-07T09:51:47Z","updated_at":"2015-04-20T15:35:52Z","pushed_at":"2015-11-02T10:26:13Z","git_url":"git://github.com/alphagov/manuals-frontend.git","ssh_url":"git@github.com:alphagov/manuals-frontend.git","clone_url":"https://github.com/alphagov/manuals-frontend.git","svn_url":"https://github.com/alphagov/manuals-frontend","homepage":"","size":5811,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/manuals-frontend/pulls/166"},"html":{"href":"https://github.com/alphagov/manuals-frontend/pull/166"},"issue":{"href":"https://api.github.com/repos/alphagov/manuals-frontend/issues/166"},"comments":{"href":"https://api.github.com/repos/alphagov/manuals-frontend/issues/166/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/manuals-frontend/pulls/166/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/manuals-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/manuals-frontend/pulls/166/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/manuals-frontend/statuses/c037f89d182ac6b1f6e34203421777bbc3ab0e39"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tommyp","id":449004,"avatar_url":"https://avatars.githubusercontent.com/u/449004?v=3","gravatar_id":"","url":"https://api.github.com/users/tommyp","html_url":"https://github.com/tommyp","followers_url":"https://api.github.com/users/tommyp/followers","following_url":"https://api.github.com/users/tommyp/following{/other_user}","gists_url":"https://api.github.com/users/tommyp/gists{/gist_id}","starred_url":"https://api.github.com/users/tommyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tommyp/subscriptions","organizations_url":"https://api.github.com/users/tommyp/orgs","repos_url":"https://api.github.com/users/tommyp/repos","events_url":"https://api.github.com/users/tommyp/events{/privacy}","received_events_url":"https://api.github.com/users/tommyp/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":3,"additions":108,"deletions":41,"changed_files":5}}