{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/comments/28932352","id":28932352,"diff_hunk":"@@ -259,272 +246,718 @@ var hdInsightCommandLine = function(cli, userInteractor, executionProcessor) {\n     this.processor = new ExecutionProcessor(this.cli);\n   }\n \n-  this.createClusterCommand = function (config, options, _) {\n-    var creationObject = { };\n-    if (config) {\n-      creationObject = self.user.readConfig(config);\n-    }\n-\n-    if (options.clusterName) {\n-      creationObject.name = options.clusterName;\n-    }\n-    if (options.nodes) {\n-      creationObject.nodes = options.nodes;\n-    }\n-    if (options.location) {\n-      creationObject.location = options.location;\n-    }\n-    if (options.storageAccountName) {\n-      creationObject.defaultStorageAccountName = options.storageAccountName;\n-    }\n-    if (options.storageAccountKey) {\n-      creationObject.defaultStorageAccountKey = options.storageAccountKey;\n-    }\n-    if (options.storageContainer) {\n-      creationObject.defaultStorageContainer = options.storageContainer;\n-    }\n-    if (options.username) {\n-      creationObject.user  = options.username;\n-    }\n-    if (options.clusterPassword) {\n-      creationObject.password = options.clusterPassword;\n+  this.createClusterCommand = function (clusterName, osType, storageAccountName, storageAccountKey, storageContainer, dataNodeCount, headNodeSize, dataNodeSize, location, userName, password, sshUserName, sshPassword, _) {\n+    clusterName = self.user.promptIfNotGiven($('Cluster name: '), clusterName, _);\n+    osType = self.user.promptIfNotGiven($('OS type: '), osType, _);\n+    storageAccountName = self.user.promptIfNotGiven($('storage account name: '), storageAccountName, _);\n+    storageAccountKey = self.user.promptIfNotGiven($('storage account key: '), storageAccountKey, _);\n+    storageContainer = self.user.promptIfNotGiven($('storage container name: '), storageContainer, _);\n+    dataNodeCount = self.user.promptIfNotGiven($('Number of data nodes: '), dataNodeCount, _);\n+    location = self.user.promptIfNotGiven($('Data center location: '), location, _);\n+    userName = self.user.promptIfNotGiven($('User name: '), userName, _);\n+    password = self.user.promptIfNotGiven($('Password: '), password, _);\n+\n+    var clusterCreationPayload = {};\n+    if(osType === 'windows')\n+    {\n+      headNodeSize = self.user.promptIfNotGiven($('Head node size (string): '), headNodeSize, _);\n+      dataNodeSize = self.user.promptIfNotGiven($('Data node size (string): '), dataNodeSize, _);\n+      var clusterPayload = '<Resource xmlns=\"http://schemas.microsoft.com/windowsazure\">';","path":"lib/commands/asm/hdinsight._js","position":256,"original_position":256,"commit_id":"2438e65aa27b4f6ad3883b5ef7f77b9fdf930322","original_commit_id":"2438e65aa27b4f6ad3883b5ef7f77b9fdf930322","user":{"login":"amarzavery","id":4521223,"avatar_url":"https://avatars.githubusercontent.com/u/4521223?v=3","gravatar_id":"","url":"https://api.github.com/users/amarzavery","html_url":"https://github.com/amarzavery","followers_url":"https://api.github.com/users/amarzavery/followers","following_url":"https://api.github.com/users/amarzavery/following{/other_user}","gists_url":"https://api.github.com/users/amarzavery/gists{/gist_id}","starred_url":"https://api.github.com/users/amarzavery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amarzavery/subscriptions","organizations_url":"https://api.github.com/users/amarzavery/orgs","repos_url":"https://api.github.com/users/amarzavery/repos","events_url":"https://api.github.com/users/amarzavery/events{/privacy}","received_events_url":"https://api.github.com/users/amarzavery/received_events","type":"User","site_admin":false},"body":"can this gigantic string be put into a separate file and reference from there.","created_at":"2015-04-23T02:28:25Z","updated_at":"2015-04-23T02:28:25Z","html_url":"https://github.com/Azure/azure-xplat-cli/pull/1716#discussion_r28932352","pull_request_url":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/1716","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/comments/28932352"},"html":{"href":"https://github.com/Azure/azure-xplat-cli/pull/1716#discussion_r28932352"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/1716"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/1716","id":33910826,"html_url":"https://github.com/Azure/azure-xplat-cli/pull/1716","diff_url":"https://github.com/Azure/azure-xplat-cli/pull/1716.diff","patch_url":"https://github.com/Azure/azure-xplat-cli/pull/1716.patch","issue_url":"https://api.github.com/repos/Azure/azure-xplat-cli/issues/1716","number":1716,"state":"open","locked":false,"title":"Merge from hdinsight to Dev, and apply several bug fixes on hdinsight._j...","user":{"login":"GuoyuHao","id":9014236,"avatar_url":"https://avatars.githubusercontent.com/u/9014236?v=3","gravatar_id":"","url":"https://api.github.com/users/GuoyuHao","html_url":"https://github.com/GuoyuHao","followers_url":"https://api.github.com/users/GuoyuHao/followers","following_url":"https://api.github.com/users/GuoyuHao/following{/other_user}","gists_url":"https://api.github.com/users/GuoyuHao/gists{/gist_id}","starred_url":"https://api.github.com/users/GuoyuHao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GuoyuHao/subscriptions","organizations_url":"https://api.github.com/users/GuoyuHao/orgs","repos_url":"https://api.github.com/users/GuoyuHao/repos","events_url":"https://api.github.com/users/GuoyuHao/events{/privacy}","received_events_url":"https://api.github.com/users/GuoyuHao/received_events","type":"User","site_admin":false},"body":"...s\r\n\r\n1. Merge back to Dev, hdinsight was used to ship OOB hdinsight package on\r\nFeb, we need to keep working on Dev in future\r\n\r\n2. There are several bug fixes against Feb's release, apply them on Dev branch","created_at":"2015-04-22T23:16:24Z","updated_at":"2015-04-23T02:28:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df3cdeb84129ba357061056803358131263fc0ff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/1716/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/1716/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-xplat-cli/issues/1716/comments","statuses_url":"https://api.github.com/repos/Azure/azure-xplat-cli/statuses/2438e65aa27b4f6ad3883b5ef7f77b9fdf930322","head":{"label":"GuoyuHao:dev","ref":"dev","sha":"2438e65aa27b4f6ad3883b5ef7f77b9fdf930322","user":{"login":"GuoyuHao","id":9014236,"avatar_url":"https://avatars.githubusercontent.com/u/9014236?v=3","gravatar_id":"","url":"https://api.github.com/users/GuoyuHao","html_url":"https://github.com/GuoyuHao","followers_url":"https://api.github.com/users/GuoyuHao/followers","following_url":"https://api.github.com/users/GuoyuHao/following{/other_user}","gists_url":"https://api.github.com/users/GuoyuHao/gists{/gist_id}","starred_url":"https://api.github.com/users/GuoyuHao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GuoyuHao/subscriptions","organizations_url":"https://api.github.com/users/GuoyuHao/orgs","repos_url":"https://api.github.com/users/GuoyuHao/repos","events_url":"https://api.github.com/users/GuoyuHao/events{/privacy}","received_events_url":"https://api.github.com/users/GuoyuHao/received_events","type":"User","site_admin":false},"repo":{"id":34085175,"name":"azure-xplat-cli","full_name":"GuoyuHao/azure-xplat-cli","owner":{"login":"GuoyuHao","id":9014236,"avatar_url":"https://avatars.githubusercontent.com/u/9014236?v=3","gravatar_id":"","url":"https://api.github.com/users/GuoyuHao","html_url":"https://github.com/GuoyuHao","followers_url":"https://api.github.com/users/GuoyuHao/followers","following_url":"https://api.github.com/users/GuoyuHao/following{/other_user}","gists_url":"https://api.github.com/users/GuoyuHao/gists{/gist_id}","starred_url":"https://api.github.com/users/GuoyuHao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GuoyuHao/subscriptions","organizations_url":"https://api.github.com/users/GuoyuHao/orgs","repos_url":"https://api.github.com/users/GuoyuHao/repos","events_url":"https://api.github.com/users/GuoyuHao/events{/privacy}","received_events_url":"https://api.github.com/users/GuoyuHao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GuoyuHao/azure-xplat-cli","description":"Microsoft Azure Cross Platform Command Line","fork":true,"url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli","forks_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/forks","keys_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/teams","hooks_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/hooks","issue_events_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/issues/events{/number}","events_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/events","assignees_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/assignees{/user}","branches_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/branches{/branch}","tags_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/tags","blobs_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/languages","stargazers_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/stargazers","contributors_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/contributors","subscribers_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/subscribers","subscription_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/subscription","commits_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/contents/{+path}","compare_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/merges","archive_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/downloads","issues_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/issues{/number}","pulls_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/labels{/name}","releases_url":"https://api.github.com/repos/GuoyuHao/azure-xplat-cli/releases{/id}","created_at":"2015-04-16T23:04:05Z","updated_at":"2015-04-23T02:02:14Z","pushed_at":"2015-04-23T02:02:13Z","git_url":"git://github.com/GuoyuHao/azure-xplat-cli.git","ssh_url":"git@github.com:GuoyuHao/azure-xplat-cli.git","clone_url":"https://github.com/GuoyuHao/azure-xplat-cli.git","svn_url":"https://github.com/GuoyuHao/azure-xplat-cli","homepage":"","size":39010,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"Azure:dev","ref":"dev","sha":"d68d014c1e49b6d6cc03a6d5c2803d7b66700f69","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":6506651,"name":"azure-xplat-cli","full_name":"Azure/azure-xplat-cli","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-xplat-cli","description":"Microsoft Azure Cross Platform Command Line","fork":false,"url":"https://api.github.com/repos/Azure/azure-xplat-cli","forks_url":"https://api.github.com/repos/Azure/azure-xplat-cli/forks","keys_url":"https://api.github.com/repos/Azure/azure-xplat-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-xplat-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-xplat-cli/teams","hooks_url":"https://api.github.com/repos/Azure/azure-xplat-cli/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-xplat-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-xplat-cli/events","assignees_url":"https://api.github.com/repos/Azure/azure-xplat-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-xplat-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-xplat-cli/tags","blobs_url":"https://api.github.com/repos/Azure/azure-xplat-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-xplat-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-xplat-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-xplat-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-xplat-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-xplat-cli/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-xplat-cli/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-xplat-cli/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-xplat-cli/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-xplat-cli/subscription","commits_url":"https://api.github.com/repos/Azure/azure-xplat-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-xplat-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-xplat-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-xplat-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-xplat-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-xplat-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-xplat-cli/merges","archive_url":"https://api.github.com/repos/Azure/azure-xplat-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-xplat-cli/downloads","issues_url":"https://api.github.com/repos/Azure/azure-xplat-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-xplat-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-xplat-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-xplat-cli/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-xplat-cli/releases{/id}","created_at":"2012-11-02T13:43:50Z","updated_at":"2015-04-22T18:09:48Z","pushed_at":"2015-04-23T02:02:14Z","git_url":"git://github.com/Azure/azure-xplat-cli.git","ssh_url":"git@github.com:Azure/azure-xplat-cli.git","clone_url":"https://github.com/Azure/azure-xplat-cli.git","svn_url":"https://github.com/Azure/azure-xplat-cli","homepage":"","size":44732,"stargazers_count":216,"watchers_count":216,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":175,"mirror_url":null,"open_issues_count":97,"forks":175,"open_issues":97,"watchers":216,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/1716"},"html":{"href":"https://github.com/Azure/azure-xplat-cli/pull/1716"},"issue":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/issues/1716"},"comments":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/issues/1716/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/1716/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/1716/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/statuses/2438e65aa27b4f6ad3883b5ef7f77b9fdf930322"}}}}