{"action":"created","comment":{"url":"https://api.github.com/repos/loomio/loomio/pulls/comments/30172792","id":30172792,"diff_hunk":"@@ -2,6 +2,13 @@ angular.module('loomioApp').factory 'NotificationRecordsInterface', (BaseRecords\n   class NotificationRecordsInterface extends BaseRecordsInterface\n     model: NotificationModel\n \n+    fetchMyNotifications: ->\n+      @fetch\n+        params:\n+          from: 0","path":"lineman/app/models/notification_records_interface.coffee","position":7,"original_position":7,"commit_id":"380379a3cc3205f8ea016f337dc9a9dce05cd0b9","original_commit_id":"42e6f67d51ac7a4c6cc1915aaa015834ce906b3e","user":{"login":"robguthrie","id":486367,"avatar_url":"https://avatars.githubusercontent.com/u/486367?v=3","gravatar_id":"","url":"https://api.github.com/users/robguthrie","html_url":"https://github.com/robguthrie","followers_url":"https://api.github.com/users/robguthrie/followers","following_url":"https://api.github.com/users/robguthrie/following{/other_user}","gists_url":"https://api.github.com/users/robguthrie/gists{/gist_id}","starred_url":"https://api.github.com/users/robguthrie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robguthrie/subscriptions","organizations_url":"https://api.github.com/users/robguthrie/orgs","repos_url":"https://api.github.com/users/robguthrie/repos","events_url":"https://api.github.com/users/robguthrie/events{/privacy}","received_events_url":"https://api.github.com/users/robguthrie/received_events","type":"User","site_admin":false},"body":"nope.. paging does not makes sense in this context. We can only grab most\nrecent records with this..\n\nOn Wed, 13 May 2015 at 03:13 James Kiesel <notifications@github.com> wrote:\n\n> In lineman/app/models/notification_records_interface.coffee\n> <https://github.com/loomio/loomio/pull/2149#discussion_r30144210>:\n>\n> > @@ -2,6 +2,13 @@ angular.module('loomioApp').factory 'NotificationRecordsInterface', (BaseRecords\n> >    class NotificationRecordsInterface extends BaseRecordsInterface\n> >      model: NotificationModel\n> >\n> > +    fetchMyNotifications: ->\n> > +      @fetch\n> > +        params:\n> > +          from: 0\n>\n> It might do to have a chat about paging with this system, which will be a\n> bit wonky; I don't think we want to be combining timeframe and page too\n> much. (Give me the 25th - 50th record created in the last day? Blerg. Even\n> 'give me the last 20 records created in the last timeframe' doesn't work,\n> because what if someone comes back after an hour and 30 things have been\n> created? Still have a hole.)\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/loomio/loomio/pull/2149/files#r30144210>.\n>\n","created_at":"2015-05-12T19:49:03Z","updated_at":"2015-05-12T19:49:03Z","html_url":"https://github.com/loomio/loomio/pull/2149#discussion_r30172792","pull_request_url":"https://api.github.com/repos/loomio/loomio/pulls/2149","_links":{"self":{"href":"https://api.github.com/repos/loomio/loomio/pulls/comments/30172792"},"html":{"href":"https://github.com/loomio/loomio/pull/2149#discussion_r30172792"},"pull_request":{"href":"https://api.github.com/repos/loomio/loomio/pulls/2149"}}},"pull_request":{"url":"https://api.github.com/repos/loomio/loomio/pulls/2149","id":35114127,"html_url":"https://github.com/loomio/loomio/pull/2149","diff_url":"https://github.com/loomio/loomio/pull/2149.diff","patch_url":"https://github.com/loomio/loomio/pull/2149.patch","issue_url":"https://api.github.com/repos/loomio/loomio/issues/2149","number":2149,"state":"open","locked":false,"title":"Dashboard fetch latest","user":{"login":"gdpelican","id":750477,"avatar_url":"https://avatars.githubusercontent.com/u/750477?v=3","gravatar_id":"","url":"https://api.github.com/users/gdpelican","html_url":"https://github.com/gdpelican","followers_url":"https://api.github.com/users/gdpelican/followers","following_url":"https://api.github.com/users/gdpelican/following{/other_user}","gists_url":"https://api.github.com/users/gdpelican/gists{/gist_id}","starred_url":"https://api.github.com/users/gdpelican/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdpelican/subscriptions","organizations_url":"https://api.github.com/users/gdpelican/orgs","repos_url":"https://api.github.com/users/gdpelican/repos","events_url":"https://api.github.com/users/gdpelican/events{/privacy}","received_events_url":"https://api.github.com/users/gdpelican/received_events","type":"User","site_admin":false},"body":"Okay @robguthrie here's a first pass for today at loading only the latest records for things.\r\n\r\nNotably missing from this implementation is\r\n- Loading activity in a discussion\r\n- Loading notifications\r\n\r\nYes, these are probably the two most important use cases for this. But figured I'd share and see what you think of this tack, which is very minimalist.","created_at":"2015-05-11T10:17:21Z","updated_at":"2015-05-12T19:49:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"feda2f1138e6d00f9a8e1a2c4539e0c9efcf2d05","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/loomio/loomio/pulls/2149/commits","review_comments_url":"https://api.github.com/repos/loomio/loomio/pulls/2149/comments","review_comment_url":"https://api.github.com/repos/loomio/loomio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/loomio/loomio/issues/2149/comments","statuses_url":"https://api.github.com/repos/loomio/loomio/statuses/380379a3cc3205f8ea016f337dc9a9dce05cd0b9","head":{"label":"loomio:dashboard-fetch-latest","ref":"dashboard-fetch-latest","sha":"380379a3cc3205f8ea016f337dc9a9dce05cd0b9","user":{"login":"loomio","id":1896739,"avatar_url":"https://avatars.githubusercontent.com/u/1896739?v=3","gravatar_id":"","url":"https://api.github.com/users/loomio","html_url":"https://github.com/loomio","followers_url":"https://api.github.com/users/loomio/followers","following_url":"https://api.github.com/users/loomio/following{/other_user}","gists_url":"https://api.github.com/users/loomio/gists{/gist_id}","starred_url":"https://api.github.com/users/loomio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loomio/subscriptions","organizations_url":"https://api.github.com/users/loomio/orgs","repos_url":"https://api.github.com/users/loomio/repos","events_url":"https://api.github.com/users/loomio/events{/privacy}","received_events_url":"https://api.github.com/users/loomio/received_events","type":"Organization","site_admin":false},"repo":{"id":2731301,"name":"loomio","full_name":"loomio/loomio","owner":{"login":"loomio","id":1896739,"avatar_url":"https://avatars.githubusercontent.com/u/1896739?v=3","gravatar_id":"","url":"https://api.github.com/users/loomio","html_url":"https://github.com/loomio","followers_url":"https://api.github.com/users/loomio/followers","following_url":"https://api.github.com/users/loomio/following{/other_user}","gists_url":"https://api.github.com/users/loomio/gists{/gist_id}","starred_url":"https://api.github.com/users/loomio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loomio/subscriptions","organizations_url":"https://api.github.com/users/loomio/orgs","repos_url":"https://api.github.com/users/loomio/repos","events_url":"https://api.github.com/users/loomio/events{/privacy}","received_events_url":"https://api.github.com/users/loomio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/loomio/loomio","description":"Loomio is an open-source web application that helps groups make better decisions together.","fork":false,"url":"https://api.github.com/repos/loomio/loomio","forks_url":"https://api.github.com/repos/loomio/loomio/forks","keys_url":"https://api.github.com/repos/loomio/loomio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/loomio/loomio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/loomio/loomio/teams","hooks_url":"https://api.github.com/repos/loomio/loomio/hooks","issue_events_url":"https://api.github.com/repos/loomio/loomio/issues/events{/number}","events_url":"https://api.github.com/repos/loomio/loomio/events","assignees_url":"https://api.github.com/repos/loomio/loomio/assignees{/user}","branches_url":"https://api.github.com/repos/loomio/loomio/branches{/branch}","tags_url":"https://api.github.com/repos/loomio/loomio/tags","blobs_url":"https://api.github.com/repos/loomio/loomio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/loomio/loomio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/loomio/loomio/git/refs{/sha}","trees_url":"https://api.github.com/repos/loomio/loomio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/loomio/loomio/statuses/{sha}","languages_url":"https://api.github.com/repos/loomio/loomio/languages","stargazers_url":"https://api.github.com/repos/loomio/loomio/stargazers","contributors_url":"https://api.github.com/repos/loomio/loomio/contributors","subscribers_url":"https://api.github.com/repos/loomio/loomio/subscribers","subscription_url":"https://api.github.com/repos/loomio/loomio/subscription","commits_url":"https://api.github.com/repos/loomio/loomio/commits{/sha}","git_commits_url":"https://api.github.com/repos/loomio/loomio/git/commits{/sha}","comments_url":"https://api.github.com/repos/loomio/loomio/comments{/number}","issue_comment_url":"https://api.github.com/repos/loomio/loomio/issues/comments{/number}","contents_url":"https://api.github.com/repos/loomio/loomio/contents/{+path}","compare_url":"https://api.github.com/repos/loomio/loomio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/loomio/loomio/merges","archive_url":"https://api.github.com/repos/loomio/loomio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/loomio/loomio/downloads","issues_url":"https://api.github.com/repos/loomio/loomio/issues{/number}","pulls_url":"https://api.github.com/repos/loomio/loomio/pulls{/number}","milestones_url":"https://api.github.com/repos/loomio/loomio/milestones{/number}","notifications_url":"https://api.github.com/repos/loomio/loomio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/loomio/loomio/labels{/name}","releases_url":"https://api.github.com/repos/loomio/loomio/releases{/id}","created_at":"2011-11-08T03:27:12Z","updated_at":"2015-05-12T13:15:03Z","pushed_at":"2015-05-12T16:06:31Z","git_url":"git://github.com/loomio/loomio.git","ssh_url":"git@github.com:loomio/loomio.git","clone_url":"https://github.com/loomio/loomio.git","svn_url":"https://github.com/loomio/loomio","homepage":"www.loomio.org","size":163354,"stargazers_count":897,"watchers_count":897,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":285,"mirror_url":null,"open_issues_count":71,"forks":285,"open_issues":71,"watchers":897,"default_branch":"master"}},"base":{"label":"loomio:master","ref":"master","sha":"56d7b5020b58ac8bfe32a9fa46b358ca376c6843","user":{"login":"loomio","id":1896739,"avatar_url":"https://avatars.githubusercontent.com/u/1896739?v=3","gravatar_id":"","url":"https://api.github.com/users/loomio","html_url":"https://github.com/loomio","followers_url":"https://api.github.com/users/loomio/followers","following_url":"https://api.github.com/users/loomio/following{/other_user}","gists_url":"https://api.github.com/users/loomio/gists{/gist_id}","starred_url":"https://api.github.com/users/loomio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loomio/subscriptions","organizations_url":"https://api.github.com/users/loomio/orgs","repos_url":"https://api.github.com/users/loomio/repos","events_url":"https://api.github.com/users/loomio/events{/privacy}","received_events_url":"https://api.github.com/users/loomio/received_events","type":"Organization","site_admin":false},"repo":{"id":2731301,"name":"loomio","full_name":"loomio/loomio","owner":{"login":"loomio","id":1896739,"avatar_url":"https://avatars.githubusercontent.com/u/1896739?v=3","gravatar_id":"","url":"https://api.github.com/users/loomio","html_url":"https://github.com/loomio","followers_url":"https://api.github.com/users/loomio/followers","following_url":"https://api.github.com/users/loomio/following{/other_user}","gists_url":"https://api.github.com/users/loomio/gists{/gist_id}","starred_url":"https://api.github.com/users/loomio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loomio/subscriptions","organizations_url":"https://api.github.com/users/loomio/orgs","repos_url":"https://api.github.com/users/loomio/repos","events_url":"https://api.github.com/users/loomio/events{/privacy}","received_events_url":"https://api.github.com/users/loomio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/loomio/loomio","description":"Loomio is an open-source web application that helps groups make better decisions together.","fork":false,"url":"https://api.github.com/repos/loomio/loomio","forks_url":"https://api.github.com/repos/loomio/loomio/forks","keys_url":"https://api.github.com/repos/loomio/loomio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/loomio/loomio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/loomio/loomio/teams","hooks_url":"https://api.github.com/repos/loomio/loomio/hooks","issue_events_url":"https://api.github.com/repos/loomio/loomio/issues/events{/number}","events_url":"https://api.github.com/repos/loomio/loomio/events","assignees_url":"https://api.github.com/repos/loomio/loomio/assignees{/user}","branches_url":"https://api.github.com/repos/loomio/loomio/branches{/branch}","tags_url":"https://api.github.com/repos/loomio/loomio/tags","blobs_url":"https://api.github.com/repos/loomio/loomio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/loomio/loomio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/loomio/loomio/git/refs{/sha}","trees_url":"https://api.github.com/repos/loomio/loomio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/loomio/loomio/statuses/{sha}","languages_url":"https://api.github.com/repos/loomio/loomio/languages","stargazers_url":"https://api.github.com/repos/loomio/loomio/stargazers","contributors_url":"https://api.github.com/repos/loomio/loomio/contributors","subscribers_url":"https://api.github.com/repos/loomio/loomio/subscribers","subscription_url":"https://api.github.com/repos/loomio/loomio/subscription","commits_url":"https://api.github.com/repos/loomio/loomio/commits{/sha}","git_commits_url":"https://api.github.com/repos/loomio/loomio/git/commits{/sha}","comments_url":"https://api.github.com/repos/loomio/loomio/comments{/number}","issue_comment_url":"https://api.github.com/repos/loomio/loomio/issues/comments{/number}","contents_url":"https://api.github.com/repos/loomio/loomio/contents/{+path}","compare_url":"https://api.github.com/repos/loomio/loomio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/loomio/loomio/merges","archive_url":"https://api.github.com/repos/loomio/loomio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/loomio/loomio/downloads","issues_url":"https://api.github.com/repos/loomio/loomio/issues{/number}","pulls_url":"https://api.github.com/repos/loomio/loomio/pulls{/number}","milestones_url":"https://api.github.com/repos/loomio/loomio/milestones{/number}","notifications_url":"https://api.github.com/repos/loomio/loomio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/loomio/loomio/labels{/name}","releases_url":"https://api.github.com/repos/loomio/loomio/releases{/id}","created_at":"2011-11-08T03:27:12Z","updated_at":"2015-05-12T13:15:03Z","pushed_at":"2015-05-12T16:06:31Z","git_url":"git://github.com/loomio/loomio.git","ssh_url":"git@github.com:loomio/loomio.git","clone_url":"https://github.com/loomio/loomio.git","svn_url":"https://github.com/loomio/loomio","homepage":"www.loomio.org","size":163354,"stargazers_count":897,"watchers_count":897,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":285,"mirror_url":null,"open_issues_count":71,"forks":285,"open_issues":71,"watchers":897,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/loomio/loomio/pulls/2149"},"html":{"href":"https://github.com/loomio/loomio/pull/2149"},"issue":{"href":"https://api.github.com/repos/loomio/loomio/issues/2149"},"comments":{"href":"https://api.github.com/repos/loomio/loomio/issues/2149/comments"},"review_comments":{"href":"https://api.github.com/repos/loomio/loomio/pulls/2149/comments"},"review_comment":{"href":"https://api.github.com/repos/loomio/loomio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/loomio/loomio/pulls/2149/commits"},"statuses":{"href":"https://api.github.com/repos/loomio/loomio/statuses/380379a3cc3205f8ea016f337dc9a9dce05cd0b9"}}}}