{"action":"opened","number":551,"pull_request":{"url":"https://api.github.com/repos/ResearchKit/ResearchKit/pulls/551","id":48806834,"html_url":"https://github.com/ResearchKit/ResearchKit/pull/551","diff_url":"https://github.com/ResearchKit/ResearchKit/pull/551.diff","patch_url":"https://github.com/ResearchKit/ResearchKit/pull/551.patch","issue_url":"https://api.github.com/repos/ResearchKit/ResearchKit/issues/551","number":551,"state":"open","locked":false,"title":"IOI # 517 - Image capture no permissions bug","user":{"login":"umerkhan-apple","id":13040996,"avatar_url":"https://avatars.githubusercontent.com/u/13040996?v=3","gravatar_id":"","url":"https://api.github.com/users/umerkhan-apple","html_url":"https://github.com/umerkhan-apple","followers_url":"https://api.github.com/users/umerkhan-apple/followers","following_url":"https://api.github.com/users/umerkhan-apple/following{/other_user}","gists_url":"https://api.github.com/users/umerkhan-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/umerkhan-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umerkhan-apple/subscriptions","organizations_url":"https://api.github.com/users/umerkhan-apple/orgs","repos_url":"https://api.github.com/users/umerkhan-apple/repos","events_url":"https://api.github.com/users/umerkhan-apple/events{/privacy}","received_events_url":"https://api.github.com/users/umerkhan-apple/received_events","type":"User","site_admin":false},"body":"The original implementation was implementing `requestedPermissions` on ORKImageCaptureStep which result in the delegate call `taskViewControllerDidFinish: WithReason:` if camera permission was not granted. Removing that implementation and instead only requesting permission on the actual image step resolved part of the issue.\r\n\r\nThe second half of the bug was due to the fact that in the error handling of the camera permissions, the delegate callback `taskViewControllerDidFinish: WithReason:` was being made also. This caused the image capture step to never appear on the screen and actually show the error message.\r\n\r\nRemoving both those factors allows the user to navigate through the steps and see the error messages so that they can resolve it by changing privacy in settings or by skipping the question.\r\n\r\nIssue #517 ","created_at":"2015-10-26T22:35:12Z","updated_at":"2015-10-26T22:35:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ResearchKit/ResearchKit/pulls/551/commits","review_comments_url":"https://api.github.com/repos/ResearchKit/ResearchKit/pulls/551/comments","review_comment_url":"https://api.github.com/repos/ResearchKit/ResearchKit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ResearchKit/ResearchKit/issues/551/comments","statuses_url":"https://api.github.com/repos/ResearchKit/ResearchKit/statuses/c0b751d05a7309b05127b201e2246a84cc78f63b","head":{"label":"umerkhan-apple:imageCaptureBug","ref":"imageCaptureBug","sha":"c0b751d05a7309b05127b201e2246a84cc78f63b","user":{"login":"umerkhan-apple","id":13040996,"avatar_url":"https://avatars.githubusercontent.com/u/13040996?v=3","gravatar_id":"","url":"https://api.github.com/users/umerkhan-apple","html_url":"https://github.com/umerkhan-apple","followers_url":"https://api.github.com/users/umerkhan-apple/followers","following_url":"https://api.github.com/users/umerkhan-apple/following{/other_user}","gists_url":"https://api.github.com/users/umerkhan-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/umerkhan-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umerkhan-apple/subscriptions","organizations_url":"https://api.github.com/users/umerkhan-apple/orgs","repos_url":"https://api.github.com/users/umerkhan-apple/repos","events_url":"https://api.github.com/users/umerkhan-apple/events{/privacy}","received_events_url":"https://api.github.com/users/umerkhan-apple/received_events","type":"User","site_admin":false},"repo":{"id":38137073,"name":"ResearchKit","full_name":"umerkhan-apple/ResearchKit","owner":{"login":"umerkhan-apple","id":13040996,"avatar_url":"https://avatars.githubusercontent.com/u/13040996?v=3","gravatar_id":"","url":"https://api.github.com/users/umerkhan-apple","html_url":"https://github.com/umerkhan-apple","followers_url":"https://api.github.com/users/umerkhan-apple/followers","following_url":"https://api.github.com/users/umerkhan-apple/following{/other_user}","gists_url":"https://api.github.com/users/umerkhan-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/umerkhan-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umerkhan-apple/subscriptions","organizations_url":"https://api.github.com/users/umerkhan-apple/orgs","repos_url":"https://api.github.com/users/umerkhan-apple/repos","events_url":"https://api.github.com/users/umerkhan-apple/events{/privacy}","received_events_url":"https://api.github.com/users/umerkhan-apple/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/umerkhan-apple/ResearchKit","description":"ResearchKit is an open source software framework that makes it easy to create apps for medical research or for other research projects.","fork":true,"url":"https://api.github.com/repos/umerkhan-apple/ResearchKit","forks_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/forks","keys_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/teams","hooks_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/hooks","issue_events_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/issues/events{/number}","events_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/events","assignees_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/assignees{/user}","branches_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/branches{/branch}","tags_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/tags","blobs_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/statuses/{sha}","languages_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/languages","stargazers_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/stargazers","contributors_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/contributors","subscribers_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/subscribers","subscription_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/subscription","commits_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/contents/{+path}","compare_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/merges","archive_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/downloads","issues_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/issues{/number}","pulls_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/pulls{/number}","milestones_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/milestones{/number}","notifications_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/labels{/name}","releases_url":"https://api.github.com/repos/umerkhan-apple/ResearchKit/releases{/id}","created_at":"2015-06-26T22:29:51Z","updated_at":"2015-06-26T22:29:53Z","pushed_at":"2015-10-26T22:29:35Z","git_url":"git://github.com/umerkhan-apple/ResearchKit.git","ssh_url":"git@github.com:umerkhan-apple/ResearchKit.git","clone_url":"https://github.com/umerkhan-apple/ResearchKit.git","svn_url":"https://github.com/umerkhan-apple/ResearchKit","homepage":"","size":19124,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ResearchKit:master","ref":"master","sha":"160b7c5f714ed56141f6a1b4de865f78ae55f8fe","user":{"login":"ResearchKit","id":11183179,"avatar_url":"https://avatars.githubusercontent.com/u/11183179?v=3","gravatar_id":"","url":"https://api.github.com/users/ResearchKit","html_url":"https://github.com/ResearchKit","followers_url":"https://api.github.com/users/ResearchKit/followers","following_url":"https://api.github.com/users/ResearchKit/following{/other_user}","gists_url":"https://api.github.com/users/ResearchKit/gists{/gist_id}","starred_url":"https://api.github.com/users/ResearchKit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ResearchKit/subscriptions","organizations_url":"https://api.github.com/users/ResearchKit/orgs","repos_url":"https://api.github.com/users/ResearchKit/repos","events_url":"https://api.github.com/users/ResearchKit/events{/privacy}","received_events_url":"https://api.github.com/users/ResearchKit/received_events","type":"Organization","site_admin":false},"repo":{"id":31979038,"name":"ResearchKit","full_name":"ResearchKit/ResearchKit","owner":{"login":"ResearchKit","id":11183179,"avatar_url":"https://avatars.githubusercontent.com/u/11183179?v=3","gravatar_id":"","url":"https://api.github.com/users/ResearchKit","html_url":"https://github.com/ResearchKit","followers_url":"https://api.github.com/users/ResearchKit/followers","following_url":"https://api.github.com/users/ResearchKit/following{/other_user}","gists_url":"https://api.github.com/users/ResearchKit/gists{/gist_id}","starred_url":"https://api.github.com/users/ResearchKit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ResearchKit/subscriptions","organizations_url":"https://api.github.com/users/ResearchKit/orgs","repos_url":"https://api.github.com/users/ResearchKit/repos","events_url":"https://api.github.com/users/ResearchKit/events{/privacy}","received_events_url":"https://api.github.com/users/ResearchKit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ResearchKit/ResearchKit","description":"ResearchKit is an open source software framework that makes it easy to create apps for medical research or for other research projects.","fork":false,"url":"https://api.github.com/repos/ResearchKit/ResearchKit","forks_url":"https://api.github.com/repos/ResearchKit/ResearchKit/forks","keys_url":"https://api.github.com/repos/ResearchKit/ResearchKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ResearchKit/ResearchKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ResearchKit/ResearchKit/teams","hooks_url":"https://api.github.com/repos/ResearchKit/ResearchKit/hooks","issue_events_url":"https://api.github.com/repos/ResearchKit/ResearchKit/issues/events{/number}","events_url":"https://api.github.com/repos/ResearchKit/ResearchKit/events","assignees_url":"https://api.github.com/repos/ResearchKit/ResearchKit/assignees{/user}","branches_url":"https://api.github.com/repos/ResearchKit/ResearchKit/branches{/branch}","tags_url":"https://api.github.com/repos/ResearchKit/ResearchKit/tags","blobs_url":"https://api.github.com/repos/ResearchKit/ResearchKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ResearchKit/ResearchKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ResearchKit/ResearchKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/ResearchKit/ResearchKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ResearchKit/ResearchKit/statuses/{sha}","languages_url":"https://api.github.com/repos/ResearchKit/ResearchKit/languages","stargazers_url":"https://api.github.com/repos/ResearchKit/ResearchKit/stargazers","contributors_url":"https://api.github.com/repos/ResearchKit/ResearchKit/contributors","subscribers_url":"https://api.github.com/repos/ResearchKit/ResearchKit/subscribers","subscription_url":"https://api.github.com/repos/ResearchKit/ResearchKit/subscription","commits_url":"https://api.github.com/repos/ResearchKit/ResearchKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/ResearchKit/ResearchKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/ResearchKit/ResearchKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/ResearchKit/ResearchKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/ResearchKit/ResearchKit/contents/{+path}","compare_url":"https://api.github.com/repos/ResearchKit/ResearchKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ResearchKit/ResearchKit/merges","archive_url":"https://api.github.com/repos/ResearchKit/ResearchKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ResearchKit/ResearchKit/downloads","issues_url":"https://api.github.com/repos/ResearchKit/ResearchKit/issues{/number}","pulls_url":"https://api.github.com/repos/ResearchKit/ResearchKit/pulls{/number}","milestones_url":"https://api.github.com/repos/ResearchKit/ResearchKit/milestones{/number}","notifications_url":"https://api.github.com/repos/ResearchKit/ResearchKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ResearchKit/ResearchKit/labels{/name}","releases_url":"https://api.github.com/repos/ResearchKit/ResearchKit/releases{/id}","created_at":"2015-03-10T20:05:32Z","updated_at":"2015-10-26T19:03:28Z","pushed_at":"2015-10-26T22:35:12Z","git_url":"git://github.com/ResearchKit/ResearchKit.git","ssh_url":"git@github.com:ResearchKit/ResearchKit.git","clone_url":"https://github.com/ResearchKit/ResearchKit.git","svn_url":"https://github.com/ResearchKit/ResearchKit","homepage":"","size":28209,"stargazers_count":4051,"watchers_count":4051,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":577,"mirror_url":null,"open_issues_count":78,"forks":577,"open_issues":78,"watchers":4051,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ResearchKit/ResearchKit/pulls/551"},"html":{"href":"https://github.com/ResearchKit/ResearchKit/pull/551"},"issue":{"href":"https://api.github.com/repos/ResearchKit/ResearchKit/issues/551"},"comments":{"href":"https://api.github.com/repos/ResearchKit/ResearchKit/issues/551/comments"},"review_comments":{"href":"https://api.github.com/repos/ResearchKit/ResearchKit/pulls/551/comments"},"review_comment":{"href":"https://api.github.com/repos/ResearchKit/ResearchKit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ResearchKit/ResearchKit/pulls/551/commits"},"statuses":{"href":"https://api.github.com/repos/ResearchKit/ResearchKit/statuses/c0b751d05a7309b05127b201e2246a84cc78f63b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":0,"deletions":9,"changed_files":2}}