{"action":"created","comment":{"url":"https://api.github.com/repos/rpm-software-management/dnf/pulls/comments/23305854","id":23305854,"diff_hunk":"@@ -148,3 +148,19 @@ def get_best_selector(self, sack, forms=None):\n             dep = str(reldep)\n             return sltr.set(provides=dep)\n         return sltr\n+\n+    def get_best_selectors(self, sack, forms=None):\n+        if not self.filename_pattern and is_glob_pattern(self.subj.pattern):\n+            nevra = first(self.subj.nevra_possibilities_real(sack, allow_globs=True))\n+\n+            if nevra and nevra.name and is_glob_pattern(nevra.name):\n+                    sltrs = []\n+                    pkgs = sack.query().filter(name__glob=nevra.name)","path":"dnf/subject.py","position":11,"original_position":11,"commit_id":"ff82082b0139cf4295b341a0f82a89f646e104c1","original_commit_id":"ff82082b0139cf4295b341a0f82a89f646e104c1","user":{"login":"jsilhan","id":5243763,"avatar_url":"https://avatars.githubusercontent.com/u/5243763?v=3","gravatar_id":"","url":"https://api.github.com/users/jsilhan","html_url":"https://github.com/jsilhan","followers_url":"https://api.github.com/users/jsilhan/followers","following_url":"https://api.github.com/users/jsilhan/following{/other_user}","gists_url":"https://api.github.com/users/jsilhan/gists{/gist_id}","starred_url":"https://api.github.com/users/jsilhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsilhan/subscriptions","organizations_url":"https://api.github.com/users/jsilhan/orgs","repos_url":"https://api.github.com/users/jsilhan/repos","events_url":"https://api.github.com/users/jsilhan/events{/privacy}","received_events_url":"https://api.github.com/users/jsilhan/received_events","type":"User","site_admin":false},"body":"Just have seen some scenario in other bug report. There should be `nevra.to_query()` instead. If you had available `pkg A.x86_64, pkg A-lib.i686` then `dnf install A*.x86_64` would fail with error like: `can't install A-lib.x86_64`","created_at":"2015-01-21T15:21:39Z","updated_at":"2015-01-21T15:21:39Z","html_url":"https://github.com/rpm-software-management/dnf/pull/194#discussion_r23305854","pull_request_url":"https://api.github.com/repos/rpm-software-management/dnf/pulls/194","_links":{"self":{"href":"https://api.github.com/repos/rpm-software-management/dnf/pulls/comments/23305854"},"html":{"href":"https://github.com/rpm-software-management/dnf/pull/194#discussion_r23305854"},"pull_request":{"href":"https://api.github.com/repos/rpm-software-management/dnf/pulls/194"}}},"pull_request":{"url":"https://api.github.com/repos/rpm-software-management/dnf/pulls/194","id":27557962,"html_url":"https://github.com/rpm-software-management/dnf/pull/194","diff_url":"https://github.com/rpm-software-management/dnf/pull/194.diff","patch_url":"https://github.com/rpm-software-management/dnf/pull/194.patch","issue_url":"https://api.github.com/repos/rpm-software-management/dnf/issues/194","number":194,"state":"open","locked":false,"title":"get_best_selectors","user":{"login":"mluscon","id":1122010,"avatar_url":"https://avatars.githubusercontent.com/u/1122010?v=3","gravatar_id":"","url":"https://api.github.com/users/mluscon","html_url":"https://github.com/mluscon","followers_url":"https://api.github.com/users/mluscon/followers","following_url":"https://api.github.com/users/mluscon/following{/other_user}","gists_url":"https://api.github.com/users/mluscon/gists{/gist_id}","starred_url":"https://api.github.com/users/mluscon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mluscon/subscriptions","organizations_url":"https://api.github.com/users/mluscon/orgs","repos_url":"https://api.github.com/users/mluscon/repos","events_url":"https://api.github.com/users/mluscon/events{/privacy}","received_events_url":"https://api.github.com/users/mluscon/received_events","type":"User","site_admin":false},"body":"- used nevra_possibilities_real for subject split\r\n- new test for get_best_selectors","created_at":"2015-01-17T15:27:26Z","updated_at":"2015-01-21T15:21:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f58f2be4158073570ee9064167f8b42e49c79950","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rpm-software-management/dnf/pulls/194/commits","review_comments_url":"https://api.github.com/repos/rpm-software-management/dnf/pulls/194/comments","review_comment_url":"https://api.github.com/repos/rpm-software-management/dnf/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rpm-software-management/dnf/issues/194/comments","statuses_url":"https://api.github.com/repos/rpm-software-management/dnf/statuses/ff82082b0139cf4295b341a0f82a89f646e104c1","head":{"label":"mluscon:glob_excludes","ref":"glob_excludes","sha":"ff82082b0139cf4295b341a0f82a89f646e104c1","user":{"login":"mluscon","id":1122010,"avatar_url":"https://avatars.githubusercontent.com/u/1122010?v=3","gravatar_id":"","url":"https://api.github.com/users/mluscon","html_url":"https://github.com/mluscon","followers_url":"https://api.github.com/users/mluscon/followers","following_url":"https://api.github.com/users/mluscon/following{/other_user}","gists_url":"https://api.github.com/users/mluscon/gists{/gist_id}","starred_url":"https://api.github.com/users/mluscon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mluscon/subscriptions","organizations_url":"https://api.github.com/users/mluscon/orgs","repos_url":"https://api.github.com/users/mluscon/repos","events_url":"https://api.github.com/users/mluscon/events{/privacy}","received_events_url":"https://api.github.com/users/mluscon/received_events","type":"User","site_admin":false},"repo":{"id":25162105,"name":"dnf","full_name":"mluscon/dnf","owner":{"login":"mluscon","id":1122010,"avatar_url":"https://avatars.githubusercontent.com/u/1122010?v=3","gravatar_id":"","url":"https://api.github.com/users/mluscon","html_url":"https://github.com/mluscon","followers_url":"https://api.github.com/users/mluscon/followers","following_url":"https://api.github.com/users/mluscon/following{/other_user}","gists_url":"https://api.github.com/users/mluscon/gists{/gist_id}","starred_url":"https://api.github.com/users/mluscon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mluscon/subscriptions","organizations_url":"https://api.github.com/users/mluscon/orgs","repos_url":"https://api.github.com/users/mluscon/repos","events_url":"https://api.github.com/users/mluscon/events{/privacy}","received_events_url":"https://api.github.com/users/mluscon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mluscon/dnf","description":"dnf is a package manager based on yum and libsolv","fork":true,"url":"https://api.github.com/repos/mluscon/dnf","forks_url":"https://api.github.com/repos/mluscon/dnf/forks","keys_url":"https://api.github.com/repos/mluscon/dnf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mluscon/dnf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mluscon/dnf/teams","hooks_url":"https://api.github.com/repos/mluscon/dnf/hooks","issue_events_url":"https://api.github.com/repos/mluscon/dnf/issues/events{/number}","events_url":"https://api.github.com/repos/mluscon/dnf/events","assignees_url":"https://api.github.com/repos/mluscon/dnf/assignees{/user}","branches_url":"https://api.github.com/repos/mluscon/dnf/branches{/branch}","tags_url":"https://api.github.com/repos/mluscon/dnf/tags","blobs_url":"https://api.github.com/repos/mluscon/dnf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mluscon/dnf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mluscon/dnf/git/refs{/sha}","trees_url":"https://api.github.com/repos/mluscon/dnf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mluscon/dnf/statuses/{sha}","languages_url":"https://api.github.com/repos/mluscon/dnf/languages","stargazers_url":"https://api.github.com/repos/mluscon/dnf/stargazers","contributors_url":"https://api.github.com/repos/mluscon/dnf/contributors","subscribers_url":"https://api.github.com/repos/mluscon/dnf/subscribers","subscription_url":"https://api.github.com/repos/mluscon/dnf/subscription","commits_url":"https://api.github.com/repos/mluscon/dnf/commits{/sha}","git_commits_url":"https://api.github.com/repos/mluscon/dnf/git/commits{/sha}","comments_url":"https://api.github.com/repos/mluscon/dnf/comments{/number}","issue_comment_url":"https://api.github.com/repos/mluscon/dnf/issues/comments/{number}","contents_url":"https://api.github.com/repos/mluscon/dnf/contents/{+path}","compare_url":"https://api.github.com/repos/mluscon/dnf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mluscon/dnf/merges","archive_url":"https://api.github.com/repos/mluscon/dnf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mluscon/dnf/downloads","issues_url":"https://api.github.com/repos/mluscon/dnf/issues{/number}","pulls_url":"https://api.github.com/repos/mluscon/dnf/pulls{/number}","milestones_url":"https://api.github.com/repos/mluscon/dnf/milestones{/number}","notifications_url":"https://api.github.com/repos/mluscon/dnf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mluscon/dnf/labels{/name}","releases_url":"https://api.github.com/repos/mluscon/dnf/releases{/id}","created_at":"2014-10-13T14:29:54Z","updated_at":"2015-01-19T17:15:13Z","pushed_at":"2015-01-19T17:15:12Z","git_url":"git://github.com/mluscon/dnf.git","ssh_url":"git@github.com:mluscon/dnf.git","clone_url":"https://github.com/mluscon/dnf.git","svn_url":"https://github.com/mluscon/dnf","homepage":"","size":33488,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rpm-software-management:master","ref":"master","sha":"206099c5c3b552fb4c09ea62593e3b5173b5c227","user":{"login":"rpm-software-management","id":8504469,"avatar_url":"https://avatars.githubusercontent.com/u/8504469?v=3","gravatar_id":"","url":"https://api.github.com/users/rpm-software-management","html_url":"https://github.com/rpm-software-management","followers_url":"https://api.github.com/users/rpm-software-management/followers","following_url":"https://api.github.com/users/rpm-software-management/following{/other_user}","gists_url":"https://api.github.com/users/rpm-software-management/gists{/gist_id}","starred_url":"https://api.github.com/users/rpm-software-management/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpm-software-management/subscriptions","organizations_url":"https://api.github.com/users/rpm-software-management/orgs","repos_url":"https://api.github.com/users/rpm-software-management/repos","events_url":"https://api.github.com/users/rpm-software-management/events{/privacy}","received_events_url":"https://api.github.com/users/rpm-software-management/received_events","type":"Organization","site_admin":false},"repo":{"id":3671909,"name":"dnf","full_name":"rpm-software-management/dnf","owner":{"login":"rpm-software-management","id":8504469,"avatar_url":"https://avatars.githubusercontent.com/u/8504469?v=3","gravatar_id":"","url":"https://api.github.com/users/rpm-software-management","html_url":"https://github.com/rpm-software-management","followers_url":"https://api.github.com/users/rpm-software-management/followers","following_url":"https://api.github.com/users/rpm-software-management/following{/other_user}","gists_url":"https://api.github.com/users/rpm-software-management/gists{/gist_id}","starred_url":"https://api.github.com/users/rpm-software-management/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpm-software-management/subscriptions","organizations_url":"https://api.github.com/users/rpm-software-management/orgs","repos_url":"https://api.github.com/users/rpm-software-management/repos","events_url":"https://api.github.com/users/rpm-software-management/events{/privacy}","received_events_url":"https://api.github.com/users/rpm-software-management/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rpm-software-management/dnf","description":"dnf is a package manager based on yum and libsolv","fork":false,"url":"https://api.github.com/repos/rpm-software-management/dnf","forks_url":"https://api.github.com/repos/rpm-software-management/dnf/forks","keys_url":"https://api.github.com/repos/rpm-software-management/dnf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rpm-software-management/dnf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rpm-software-management/dnf/teams","hooks_url":"https://api.github.com/repos/rpm-software-management/dnf/hooks","issue_events_url":"https://api.github.com/repos/rpm-software-management/dnf/issues/events{/number}","events_url":"https://api.github.com/repos/rpm-software-management/dnf/events","assignees_url":"https://api.github.com/repos/rpm-software-management/dnf/assignees{/user}","branches_url":"https://api.github.com/repos/rpm-software-management/dnf/branches{/branch}","tags_url":"https://api.github.com/repos/rpm-software-management/dnf/tags","blobs_url":"https://api.github.com/repos/rpm-software-management/dnf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rpm-software-management/dnf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rpm-software-management/dnf/git/refs{/sha}","trees_url":"https://api.github.com/repos/rpm-software-management/dnf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rpm-software-management/dnf/statuses/{sha}","languages_url":"https://api.github.com/repos/rpm-software-management/dnf/languages","stargazers_url":"https://api.github.com/repos/rpm-software-management/dnf/stargazers","contributors_url":"https://api.github.com/repos/rpm-software-management/dnf/contributors","subscribers_url":"https://api.github.com/repos/rpm-software-management/dnf/subscribers","subscription_url":"https://api.github.com/repos/rpm-software-management/dnf/subscription","commits_url":"https://api.github.com/repos/rpm-software-management/dnf/commits{/sha}","git_commits_url":"https://api.github.com/repos/rpm-software-management/dnf/git/commits{/sha}","comments_url":"https://api.github.com/repos/rpm-software-management/dnf/comments{/number}","issue_comment_url":"https://api.github.com/repos/rpm-software-management/dnf/issues/comments/{number}","contents_url":"https://api.github.com/repos/rpm-software-management/dnf/contents/{+path}","compare_url":"https://api.github.com/repos/rpm-software-management/dnf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rpm-software-management/dnf/merges","archive_url":"https://api.github.com/repos/rpm-software-management/dnf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rpm-software-management/dnf/downloads","issues_url":"https://api.github.com/repos/rpm-software-management/dnf/issues{/number}","pulls_url":"https://api.github.com/repos/rpm-software-management/dnf/pulls{/number}","milestones_url":"https://api.github.com/repos/rpm-software-management/dnf/milestones{/number}","notifications_url":"https://api.github.com/repos/rpm-software-management/dnf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rpm-software-management/dnf/labels{/name}","releases_url":"https://api.github.com/repos/rpm-software-management/dnf/releases{/id}","created_at":"2012-03-09T15:31:09Z","updated_at":"2015-01-20T18:09:43Z","pushed_at":"2015-01-20T18:09:43Z","git_url":"git://github.com/rpm-software-management/dnf.git","ssh_url":"git@github.com:rpm-software-management/dnf.git","clone_url":"https://github.com/rpm-software-management/dnf.git","svn_url":"https://github.com/rpm-software-management/dnf","homepage":"","size":38109,"stargazers_count":109,"watchers_count":109,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":40,"mirror_url":null,"open_issues_count":9,"forks":40,"open_issues":9,"watchers":109,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rpm-software-management/dnf/pulls/194"},"html":{"href":"https://github.com/rpm-software-management/dnf/pull/194"},"issue":{"href":"https://api.github.com/repos/rpm-software-management/dnf/issues/194"},"comments":{"href":"https://api.github.com/repos/rpm-software-management/dnf/issues/194/comments"},"review_comments":{"href":"https://api.github.com/repos/rpm-software-management/dnf/pulls/194/comments"},"review_comment":{"href":"https://api.github.com/repos/rpm-software-management/dnf/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rpm-software-management/dnf/pulls/194/commits"},"statuses":{"href":"https://api.github.com/repos/rpm-software-management/dnf/statuses/ff82082b0139cf4295b341a0f82a89f646e104c1"}}}}