{"action":"created","comment":{"url":"https://api.github.com/repos/Shopify/semian/pulls/comments/28338194","id":28338194,"diff_hunk":"@@ -144,25 +144,23 @@ slow resources. But it is by no means a magic wand that solves all your latency\n problems by being added to your `Gemfile`. This section describes the types of\n problems Semian solves.\n \n-If your server isn't single threaded (e.g. Resque and Unicorn) or evented these\n-problems are less immediate. However, still recommended at scale.\n+If your application is not multithreaded or evented (e.g. Resque or Unicorn)\n+these problems are not as pressing. You can still get use out of Semian however.\n \n ### Real World Example\n \n-This is better illustrated with a real world example from Shopify. If you are\n-browsing a store and you are signed in, Shopify stores your session in a session\n-store. If the session store becomes unavailable, the data driver will start\n-throwing driver errors. We rescue these exceptions and simply disable all\n-customer sign in functionality on the store until the session store is back\n-online.\n+This is better illustrated with a real world example from Shopify. When you are\n+browsing a store while signed in, Shopify stores your session in Redis.\n+If Redis becomes unavailable, the driver will start throwing exceptions.\n+We rescue these exceptions and simply disable all customer sign in functionality\n+on the store until Redis is back online.","path":"README.md","position":42,"original_position":42,"commit_id":"658d1ee939c9e1684d35c46926c523d6f4ba62a8","original_commit_id":"658d1ee939c9e1684d35c46926c523d6f4ba62a8","user":{"login":"Sirupsen","id":97400,"avatar_url":"https://avatars.githubusercontent.com/u/97400?v=3","gravatar_id":"","url":"https://api.github.com/users/Sirupsen","html_url":"https://github.com/Sirupsen","followers_url":"https://api.github.com/users/Sirupsen/followers","following_url":"https://api.github.com/users/Sirupsen/following{/other_user}","gists_url":"https://api.github.com/users/Sirupsen/gists{/gist_id}","starred_url":"https://api.github.com/users/Sirupsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sirupsen/subscriptions","organizations_url":"https://api.github.com/users/Sirupsen/orgs","repos_url":"https://api.github.com/users/Sirupsen/repos","events_url":"https://api.github.com/users/Sirupsen/events{/privacy}","received_events_url":"https://api.github.com/users/Sirupsen/received_events","type":"User","site_admin":false},"body":"Thank you!","created_at":"2015-04-14T15:32:25Z","updated_at":"2015-04-14T15:32:25Z","html_url":"https://github.com/Shopify/semian/pull/46#discussion_r28338194","pull_request_url":"https://api.github.com/repos/Shopify/semian/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/Shopify/semian/pulls/comments/28338194"},"html":{"href":"https://github.com/Shopify/semian/pull/46#discussion_r28338194"},"pull_request":{"href":"https://api.github.com/repos/Shopify/semian/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/Shopify/semian/pulls/46","id":33269231,"html_url":"https://github.com/Shopify/semian/pull/46","diff_url":"https://github.com/Shopify/semian/pull/46.diff","patch_url":"https://github.com/Shopify/semian/pull/46.patch","issue_url":"https://api.github.com/repos/Shopify/semian/issues/46","number":46,"state":"open","locked":false,"title":"Some grammatical and stylistic changes in the README","user":{"login":"bouk","id":97820,"avatar_url":"https://avatars.githubusercontent.com/u/97820?v=3","gravatar_id":"","url":"https://api.github.com/users/bouk","html_url":"https://github.com/bouk","followers_url":"https://api.github.com/users/bouk/followers","following_url":"https://api.github.com/users/bouk/following{/other_user}","gists_url":"https://api.github.com/users/bouk/gists{/gist_id}","starred_url":"https://api.github.com/users/bouk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bouk/subscriptions","organizations_url":"https://api.github.com/users/bouk/orgs","repos_url":"https://api.github.com/users/bouk/repos","events_url":"https://api.github.com/users/bouk/events{/privacy}","received_events_url":"https://api.github.com/users/bouk/received_events","type":"User","site_admin":false},"body":"@sirupsen This has a bunch of stylistic changes, you don't have to agree with all of them :). It's kind of hard to read in places and I tried to clear it up.\r\n\r\n### Some more notes\r\n\r\nFrom the standpoint of a non-C developer, the terms `ECONNREFUSED` and `ECONNRESET` might be unfamiliar\r\n\r\n\"convergence time\" is kind of vague","created_at":"2015-04-14T15:30:21Z","updated_at":"2015-04-14T15:32:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84ae42afeb7441d7d628d2e2e6777e5dc89fbc4a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/semian/pulls/46/commits","review_comments_url":"https://api.github.com/repos/Shopify/semian/pulls/46/comments","review_comment_url":"https://api.github.com/repos/Shopify/semian/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/semian/issues/46/comments","statuses_url":"https://api.github.com/repos/Shopify/semian/statuses/658d1ee939c9e1684d35c46926c523d6f4ba62a8","head":{"label":"Shopify:spelling","ref":"spelling","sha":"658d1ee939c9e1684d35c46926c523d6f4ba62a8","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":24375548,"name":"semian","full_name":"Shopify/semian","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/semian","description":":monkey: Resiliency toolkit for Ruby for failing fast","fork":false,"url":"https://api.github.com/repos/Shopify/semian","forks_url":"https://api.github.com/repos/Shopify/semian/forks","keys_url":"https://api.github.com/repos/Shopify/semian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/semian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/semian/teams","hooks_url":"https://api.github.com/repos/Shopify/semian/hooks","issue_events_url":"https://api.github.com/repos/Shopify/semian/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/semian/events","assignees_url":"https://api.github.com/repos/Shopify/semian/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/semian/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/semian/tags","blobs_url":"https://api.github.com/repos/Shopify/semian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/semian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/semian/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/semian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/semian/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/semian/languages","stargazers_url":"https://api.github.com/repos/Shopify/semian/stargazers","contributors_url":"https://api.github.com/repos/Shopify/semian/contributors","subscribers_url":"https://api.github.com/repos/Shopify/semian/subscribers","subscription_url":"https://api.github.com/repos/Shopify/semian/subscription","commits_url":"https://api.github.com/repos/Shopify/semian/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/semian/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/semian/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/semian/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/semian/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/semian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/semian/merges","archive_url":"https://api.github.com/repos/Shopify/semian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/semian/downloads","issues_url":"https://api.github.com/repos/Shopify/semian/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/semian/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/semian/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/semian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/semian/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/semian/releases{/id}","created_at":"2014-09-23T14:47:19Z","updated_at":"2015-04-14T15:25:52Z","pushed_at":"2015-04-14T15:30:21Z","git_url":"git://github.com/Shopify/semian.git","ssh_url":"git@github.com:Shopify/semian.git","clone_url":"https://github.com/Shopify/semian.git","svn_url":"https://github.com/Shopify/semian","homepage":"","size":1390,"stargazers_count":61,"watchers_count":61,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":6,"forks":3,"open_issues":6,"watchers":61,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"92ad45c4a2dd8aae20c943374999e12a928baa04","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":24375548,"name":"semian","full_name":"Shopify/semian","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/semian","description":":monkey: Resiliency toolkit for Ruby for failing fast","fork":false,"url":"https://api.github.com/repos/Shopify/semian","forks_url":"https://api.github.com/repos/Shopify/semian/forks","keys_url":"https://api.github.com/repos/Shopify/semian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/semian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/semian/teams","hooks_url":"https://api.github.com/repos/Shopify/semian/hooks","issue_events_url":"https://api.github.com/repos/Shopify/semian/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/semian/events","assignees_url":"https://api.github.com/repos/Shopify/semian/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/semian/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/semian/tags","blobs_url":"https://api.github.com/repos/Shopify/semian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/semian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/semian/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/semian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/semian/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/semian/languages","stargazers_url":"https://api.github.com/repos/Shopify/semian/stargazers","contributors_url":"https://api.github.com/repos/Shopify/semian/contributors","subscribers_url":"https://api.github.com/repos/Shopify/semian/subscribers","subscription_url":"https://api.github.com/repos/Shopify/semian/subscription","commits_url":"https://api.github.com/repos/Shopify/semian/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/semian/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/semian/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/semian/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/semian/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/semian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/semian/merges","archive_url":"https://api.github.com/repos/Shopify/semian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/semian/downloads","issues_url":"https://api.github.com/repos/Shopify/semian/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/semian/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/semian/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/semian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/semian/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/semian/releases{/id}","created_at":"2014-09-23T14:47:19Z","updated_at":"2015-04-14T15:25:52Z","pushed_at":"2015-04-14T15:30:21Z","git_url":"git://github.com/Shopify/semian.git","ssh_url":"git@github.com:Shopify/semian.git","clone_url":"https://github.com/Shopify/semian.git","svn_url":"https://github.com/Shopify/semian","homepage":"","size":1390,"stargazers_count":61,"watchers_count":61,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":6,"forks":3,"open_issues":6,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/semian/pulls/46"},"html":{"href":"https://github.com/Shopify/semian/pull/46"},"issue":{"href":"https://api.github.com/repos/Shopify/semian/issues/46"},"comments":{"href":"https://api.github.com/repos/Shopify/semian/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/semian/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/semian/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/semian/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/semian/statuses/658d1ee939c9e1684d35c46926c523d6f4ba62a8"}}}}