{"action":"created","comment":{"url":"https://api.github.com/repos/neos/flow-development-collection/pulls/comments/45574647","id":45574647,"diff_hunk":"@@ -834,8 +834,8 @@ public function saveConfigurationCacheSavesTheCurrentConfigurationAsPhpCode()\n         $expectedInclusionCode = <<< \"EOD\"\n <?php\n if (FLOW_PATH_ROOT !== 'XXX' || !file_exists('vfs://Flow/TemporaryDirectory/Configuration/FooContextConfigurations.php')) {\n-\tunlink(__FILE__);\n-\treturn array();\n+\t@unlink(__FILE__);\n+\treturn [];","path":"TYPO3.Flow/Tests/Unit/Configuration/ConfigurationManagerTest.php","position":7,"original_position":7,"commit_id":"c83d25ebaa1dd58aa954c7db3b0bfa343aec7dbe","original_commit_id":"c83d25ebaa1dd58aa954c7db3b0bfa343aec7dbe","user":{"login":"aertmann","id":903567,"avatar_url":"https://avatars.githubusercontent.com/u/903567?v=3","gravatar_id":"","url":"https://api.github.com/users/aertmann","html_url":"https://github.com/aertmann","followers_url":"https://api.github.com/users/aertmann/followers","following_url":"https://api.github.com/users/aertmann/following{/other_user}","gists_url":"https://api.github.com/users/aertmann/gists{/gist_id}","starred_url":"https://api.github.com/users/aertmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aertmann/subscriptions","organizations_url":"https://api.github.com/users/aertmann/orgs","repos_url":"https://api.github.com/users/aertmann/repos","events_url":"https://api.github.com/users/aertmann/events{/privacy}","received_events_url":"https://api.github.com/users/aertmann/received_events","type":"User","site_admin":false},"body":"same here","created_at":"2015-11-23T06:16:56Z","updated_at":"2015-11-23T06:16:56Z","html_url":"https://github.com/neos/flow-development-collection/pull/135#discussion_r45574647","pull_request_url":"https://api.github.com/repos/neos/flow-development-collection/pulls/135","_links":{"self":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/comments/45574647"},"html":{"href":"https://github.com/neos/flow-development-collection/pull/135#discussion_r45574647"},"pull_request":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/135"}}},"pull_request":{"url":"https://api.github.com/repos/neos/flow-development-collection/pulls/135","id":51478843,"html_url":"https://github.com/neos/flow-development-collection/pull/135","diff_url":"https://github.com/neos/flow-development-collection/pull/135.diff","patch_url":"https://github.com/neos/flow-development-collection/pull/135.patch","issue_url":"https://api.github.com/repos/neos/flow-development-collection/issues/135","number":135,"state":"open","locked":false,"title":"[BUGFIX] Ignore race condition on cached Configuration include","user":{"login":"kitsunet","id":324408,"avatar_url":"https://avatars.githubusercontent.com/u/324408?v=3","gravatar_id":"","url":"https://api.github.com/users/kitsunet","html_url":"https://github.com/kitsunet","followers_url":"https://api.github.com/users/kitsunet/followers","following_url":"https://api.github.com/users/kitsunet/following{/other_user}","gists_url":"https://api.github.com/users/kitsunet/gists{/gist_id}","starred_url":"https://api.github.com/users/kitsunet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitsunet/subscriptions","organizations_url":"https://api.github.com/users/kitsunet/orgs","repos_url":"https://api.github.com/users/kitsunet/repos","events_url":"https://api.github.com/users/kitsunet/events{/privacy}","received_events_url":"https://api.github.com/users/kitsunet/received_events","type":"User","site_admin":false},"body":"It can happen that the cache include file was already removed\r\nby a subrequest before getting to the unlink. The warning that\r\nwould follow can safely be ignored.","created_at":"2015-11-22T23:45:15Z","updated_at":"2015-11-23T06:16:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0555ea9ee7abdec2fbc39075d8510e10e9c41c02","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neos/flow-development-collection/pulls/135/commits","review_comments_url":"https://api.github.com/repos/neos/flow-development-collection/pulls/135/comments","review_comment_url":"https://api.github.com/repos/neos/flow-development-collection/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neos/flow-development-collection/issues/135/comments","statuses_url":"https://api.github.com/repos/neos/flow-development-collection/statuses/c83d25ebaa1dd58aa954c7db3b0bfa343aec7dbe","head":{"label":"kitsunet:ignore-cache-unlink-23","ref":"ignore-cache-unlink-23","sha":"c83d25ebaa1dd58aa954c7db3b0bfa343aec7dbe","user":{"login":"kitsunet","id":324408,"avatar_url":"https://avatars.githubusercontent.com/u/324408?v=3","gravatar_id":"","url":"https://api.github.com/users/kitsunet","html_url":"https://github.com/kitsunet","followers_url":"https://api.github.com/users/kitsunet/followers","following_url":"https://api.github.com/users/kitsunet/following{/other_user}","gists_url":"https://api.github.com/users/kitsunet/gists{/gist_id}","starred_url":"https://api.github.com/users/kitsunet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitsunet/subscriptions","organizations_url":"https://api.github.com/users/kitsunet/orgs","repos_url":"https://api.github.com/users/kitsunet/repos","events_url":"https://api.github.com/users/kitsunet/events{/privacy}","received_events_url":"https://api.github.com/users/kitsunet/received_events","type":"User","site_admin":false},"repo":{"id":41028859,"name":"flow-development-collection","full_name":"kitsunet/flow-development-collection","owner":{"login":"kitsunet","id":324408,"avatar_url":"https://avatars.githubusercontent.com/u/324408?v=3","gravatar_id":"","url":"https://api.github.com/users/kitsunet","html_url":"https://github.com/kitsunet","followers_url":"https://api.github.com/users/kitsunet/followers","following_url":"https://api.github.com/users/kitsunet/following{/other_user}","gists_url":"https://api.github.com/users/kitsunet/gists{/gist_id}","starred_url":"https://api.github.com/users/kitsunet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitsunet/subscriptions","organizations_url":"https://api.github.com/users/kitsunet/orgs","repos_url":"https://api.github.com/users/kitsunet/repos","events_url":"https://api.github.com/users/kitsunet/events{/privacy}","received_events_url":"https://api.github.com/users/kitsunet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kitsunet/flow-development-collection","description":"The unified repository containing the Flow core packages, used for Flow development.","fork":true,"url":"https://api.github.com/repos/kitsunet/flow-development-collection","forks_url":"https://api.github.com/repos/kitsunet/flow-development-collection/forks","keys_url":"https://api.github.com/repos/kitsunet/flow-development-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kitsunet/flow-development-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kitsunet/flow-development-collection/teams","hooks_url":"https://api.github.com/repos/kitsunet/flow-development-collection/hooks","issue_events_url":"https://api.github.com/repos/kitsunet/flow-development-collection/issues/events{/number}","events_url":"https://api.github.com/repos/kitsunet/flow-development-collection/events","assignees_url":"https://api.github.com/repos/kitsunet/flow-development-collection/assignees{/user}","branches_url":"https://api.github.com/repos/kitsunet/flow-development-collection/branches{/branch}","tags_url":"https://api.github.com/repos/kitsunet/flow-development-collection/tags","blobs_url":"https://api.github.com/repos/kitsunet/flow-development-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kitsunet/flow-development-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kitsunet/flow-development-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/kitsunet/flow-development-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kitsunet/flow-development-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/kitsunet/flow-development-collection/languages","stargazers_url":"https://api.github.com/repos/kitsunet/flow-development-collection/stargazers","contributors_url":"https://api.github.com/repos/kitsunet/flow-development-collection/contributors","subscribers_url":"https://api.github.com/repos/kitsunet/flow-development-collection/subscribers","subscription_url":"https://api.github.com/repos/kitsunet/flow-development-collection/subscription","commits_url":"https://api.github.com/repos/kitsunet/flow-development-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/kitsunet/flow-development-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/kitsunet/flow-development-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/kitsunet/flow-development-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/kitsunet/flow-development-collection/contents/{+path}","compare_url":"https://api.github.com/repos/kitsunet/flow-development-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kitsunet/flow-development-collection/merges","archive_url":"https://api.github.com/repos/kitsunet/flow-development-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kitsunet/flow-development-collection/downloads","issues_url":"https://api.github.com/repos/kitsunet/flow-development-collection/issues{/number}","pulls_url":"https://api.github.com/repos/kitsunet/flow-development-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/kitsunet/flow-development-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/kitsunet/flow-development-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kitsunet/flow-development-collection/labels{/name}","releases_url":"https://api.github.com/repos/kitsunet/flow-development-collection/releases{/id}","created_at":"2015-08-19T10:55:38Z","updated_at":"2015-08-19T10:55:45Z","pushed_at":"2015-11-23T00:09:08Z","git_url":"git://github.com/kitsunet/flow-development-collection.git","ssh_url":"git@github.com:kitsunet/flow-development-collection.git","clone_url":"https://github.com/kitsunet/flow-development-collection.git","svn_url":"https://github.com/kitsunet/flow-development-collection","homepage":null,"size":33245,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neos:2.3","ref":"2.3","sha":"7ead26e7927a310756ed9a239d5f4e780555a8e1","user":{"login":"neos","id":11575267,"avatar_url":"https://avatars.githubusercontent.com/u/11575267?v=3","gravatar_id":"","url":"https://api.github.com/users/neos","html_url":"https://github.com/neos","followers_url":"https://api.github.com/users/neos/followers","following_url":"https://api.github.com/users/neos/following{/other_user}","gists_url":"https://api.github.com/users/neos/gists{/gist_id}","starred_url":"https://api.github.com/users/neos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neos/subscriptions","organizations_url":"https://api.github.com/users/neos/orgs","repos_url":"https://api.github.com/users/neos/repos","events_url":"https://api.github.com/users/neos/events{/privacy}","received_events_url":"https://api.github.com/users/neos/received_events","type":"Organization","site_admin":false},"repo":{"id":40963991,"name":"flow-development-collection","full_name":"neos/flow-development-collection","owner":{"login":"neos","id":11575267,"avatar_url":"https://avatars.githubusercontent.com/u/11575267?v=3","gravatar_id":"","url":"https://api.github.com/users/neos","html_url":"https://github.com/neos","followers_url":"https://api.github.com/users/neos/followers","following_url":"https://api.github.com/users/neos/following{/other_user}","gists_url":"https://api.github.com/users/neos/gists{/gist_id}","starred_url":"https://api.github.com/users/neos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neos/subscriptions","organizations_url":"https://api.github.com/users/neos/orgs","repos_url":"https://api.github.com/users/neos/repos","events_url":"https://api.github.com/users/neos/events{/privacy}","received_events_url":"https://api.github.com/users/neos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neos/flow-development-collection","description":"The unified repository containing the Flow core packages, used for Flow development.","fork":false,"url":"https://api.github.com/repos/neos/flow-development-collection","forks_url":"https://api.github.com/repos/neos/flow-development-collection/forks","keys_url":"https://api.github.com/repos/neos/flow-development-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neos/flow-development-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neos/flow-development-collection/teams","hooks_url":"https://api.github.com/repos/neos/flow-development-collection/hooks","issue_events_url":"https://api.github.com/repos/neos/flow-development-collection/issues/events{/number}","events_url":"https://api.github.com/repos/neos/flow-development-collection/events","assignees_url":"https://api.github.com/repos/neos/flow-development-collection/assignees{/user}","branches_url":"https://api.github.com/repos/neos/flow-development-collection/branches{/branch}","tags_url":"https://api.github.com/repos/neos/flow-development-collection/tags","blobs_url":"https://api.github.com/repos/neos/flow-development-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neos/flow-development-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neos/flow-development-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/neos/flow-development-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neos/flow-development-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/neos/flow-development-collection/languages","stargazers_url":"https://api.github.com/repos/neos/flow-development-collection/stargazers","contributors_url":"https://api.github.com/repos/neos/flow-development-collection/contributors","subscribers_url":"https://api.github.com/repos/neos/flow-development-collection/subscribers","subscription_url":"https://api.github.com/repos/neos/flow-development-collection/subscription","commits_url":"https://api.github.com/repos/neos/flow-development-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/neos/flow-development-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/neos/flow-development-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/neos/flow-development-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/neos/flow-development-collection/contents/{+path}","compare_url":"https://api.github.com/repos/neos/flow-development-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neos/flow-development-collection/merges","archive_url":"https://api.github.com/repos/neos/flow-development-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neos/flow-development-collection/downloads","issues_url":"https://api.github.com/repos/neos/flow-development-collection/issues{/number}","pulls_url":"https://api.github.com/repos/neos/flow-development-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/neos/flow-development-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/neos/flow-development-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neos/flow-development-collection/labels{/name}","releases_url":"https://api.github.com/repos/neos/flow-development-collection/releases{/id}","created_at":"2015-08-18T09:48:13Z","updated_at":"2015-11-11T14:01:56Z","pushed_at":"2015-11-23T00:09:09Z","git_url":"git://github.com/neos/flow-development-collection.git","ssh_url":"git@github.com:neos/flow-development-collection.git","clone_url":"https://github.com/neos/flow-development-collection.git","svn_url":"https://github.com/neos/flow-development-collection","homepage":null,"size":33756,"stargazers_count":25,"watchers_count":25,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":38,"forks":35,"open_issues":38,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/135"},"html":{"href":"https://github.com/neos/flow-development-collection/pull/135"},"issue":{"href":"https://api.github.com/repos/neos/flow-development-collection/issues/135"},"comments":{"href":"https://api.github.com/repos/neos/flow-development-collection/issues/135/comments"},"review_comments":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/135/comments"},"review_comment":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/135/commits"},"statuses":{"href":"https://api.github.com/repos/neos/flow-development-collection/statuses/c83d25ebaa1dd58aa954c7db3b0bfa343aec7dbe"}}}}