{"action":"created","issue":{"url":"https://api.github.com/repos/ceph/ceph/issues/4794","labels_url":"https://api.github.com/repos/ceph/ceph/issues/4794/labels{/name}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/4794/comments","events_url":"https://api.github.com/repos/ceph/ceph/issues/4794/events","html_url":"https://github.com/ceph/ceph/pull/4794","id":82012846,"number":4794,"title":"test: check daemon is alive or not agagin when sleep 60s","user":{"login":"XinzeChi","id":3147032,"avatar_url":"https://avatars.githubusercontent.com/u/3147032?v=3","gravatar_id":"","url":"https://api.github.com/users/XinzeChi","html_url":"https://github.com/XinzeChi","followers_url":"https://api.github.com/users/XinzeChi/followers","following_url":"https://api.github.com/users/XinzeChi/following{/other_user}","gists_url":"https://api.github.com/users/XinzeChi/gists{/gist_id}","starred_url":"https://api.github.com/users/XinzeChi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XinzeChi/subscriptions","organizations_url":"https://api.github.com/users/XinzeChi/orgs","repos_url":"https://api.github.com/users/XinzeChi/repos","events_url":"https://api.github.com/users/XinzeChi/events{/privacy}","received_events_url":"https://api.github.com/users/XinzeChi/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ceph/ceph/labels/bug%20fix","name":"bug fix","color":"e11d21"},{"url":"https://api.github.com/repos/ceph/ceph/labels/tests","name":"tests","color":"cccccc"}],"state":"open","locked":false,"assignee":{"login":"dachary","id":433594,"avatar_url":"https://avatars.githubusercontent.com/u/433594?v=3","gravatar_id":"","url":"https://api.github.com/users/dachary","html_url":"https://github.com/dachary","followers_url":"https://api.github.com/users/dachary/followers","following_url":"https://api.github.com/users/dachary/following{/other_user}","gists_url":"https://api.github.com/users/dachary/gists{/gist_id}","starred_url":"https://api.github.com/users/dachary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dachary/subscriptions","organizations_url":"https://api.github.com/users/dachary/orgs","repos_url":"https://api.github.com/users/dachary/repos","events_url":"https://api.github.com/users/dachary/events{/privacy}","received_events_url":"https://api.github.com/users/dachary/received_events","type":"User","site_admin":false},"milestone":null,"comments":6,"created_at":"2015-05-28T16:24:38Z","updated_at":"2015-05-28T16:53:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/4794","html_url":"https://github.com/ceph/ceph/pull/4794","diff_url":"https://github.com/ceph/ceph/pull/4794.diff","patch_url":"https://github.com/ceph/ceph/pull/4794.patch"},"body":"@dachary , I think this code does not follow your means.\r\n\r\nSigned-off-by: Xinze Chi <xmdxcxz@gmail.com>"},"comment":{"url":"https://api.github.com/repos/ceph/ceph/issues/comments/106484894","html_url":"https://github.com/ceph/ceph/pull/4794#issuecomment-106484894","issue_url":"https://api.github.com/repos/ceph/ceph/issues/4794","id":106484894,"user":{"login":"dachary","id":433594,"avatar_url":"https://avatars.githubusercontent.com/u/433594?v=3","gravatar_id":"","url":"https://api.github.com/users/dachary","html_url":"https://github.com/dachary","followers_url":"https://api.github.com/users/dachary/followers","following_url":"https://api.github.com/users/dachary/following{/other_user}","gists_url":"https://api.github.com/users/dachary/gists{/gist_id}","starred_url":"https://api.github.com/users/dachary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dachary/subscriptions","organizations_url":"https://api.github.com/users/dachary/orgs","repos_url":"https://api.github.com/users/dachary/repos","events_url":"https://api.github.com/users/dachary/events{/privacy}","received_events_url":"https://api.github.com/users/dachary/received_events","type":"User","site_admin":false},"created_at":"2015-05-28T16:53:19Z","updated_at":"2015-05-28T16:53:19Z","body":"@XinzeChi the last minute is not wasted if the sleep is moved at the beginning of the for loop and the zero is at the start of the list. When maintaining the code **0 0 1 1 1 2 3 5 5 5 10 10 20 60** looks (and is indeed) straightforward to understand. If we have **0 1 1 1 2 3 5 5 5 10 10 20 60 0** (which would work without changing where the sleep is in the loop), it will look quite mysterious to the code reader who will ask her/himself : \"hum, what's that last 0 about ?\". "}}