{"action":"created","comment":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/comments/40849235","id":40849235,"diff_hunk":"@@ -468,11 +466,11 @@ public long createFile(TachyonURI path, long blockSizeBytes, boolean recursive)\n    * @param ttl time to live for file\n    * @return the file id of the create file\n    * @throws InvalidPathException\n-   * @throws FileAlreadyExistException\n+   * @throws FileAlreadyExistsException","path":"servers/src/main/java/tachyon/master/file/FileSystemMaster.java","position":70,"original_position":70,"commit_id":"b7345e28c8058bd48a026e6246e909b022d767f1","original_commit_id":"b7345e28c8058bd48a026e6246e909b022d767f1","user":{"login":"jsimsa","id":1072079,"avatar_url":"https://avatars.githubusercontent.com/u/1072079?v=3","gravatar_id":"","url":"https://api.github.com/users/jsimsa","html_url":"https://github.com/jsimsa","followers_url":"https://api.github.com/users/jsimsa/followers","following_url":"https://api.github.com/users/jsimsa/following{/other_user}","gists_url":"https://api.github.com/users/jsimsa/gists{/gist_id}","starred_url":"https://api.github.com/users/jsimsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsimsa/subscriptions","organizations_url":"https://api.github.com/users/jsimsa/orgs","repos_url":"https://api.github.com/users/jsimsa/repos","events_url":"https://api.github.com/users/jsimsa/events{/privacy}","received_events_url":"https://api.github.com/users/jsimsa/received_events","type":"User","site_admin":false},"body":"optionally, add the missing exception descriptions","created_at":"2015-09-30T20:47:12Z","updated_at":"2015-09-30T20:47:12Z","html_url":"https://github.com/amplab/tachyon/pull/1656#discussion_r40849235","pull_request_url":"https://api.github.com/repos/amplab/tachyon/pulls/1656","_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments/40849235"},"html":{"href":"https://github.com/amplab/tachyon/pull/1656#discussion_r40849235"},"pull_request":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1656"}}},"pull_request":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/1656","id":46071588,"html_url":"https://github.com/amplab/tachyon/pull/1656","diff_url":"https://github.com/amplab/tachyon/pull/1656.diff","patch_url":"https://github.com/amplab/tachyon/pull/1656.patch","issue_url":"https://api.github.com/repos/amplab/tachyon/issues/1656","number":1656,"state":"open","locked":false,"title":"[TACHYON-1061] Throw detailed exceptions isolated from RPC framework","user":{"login":"manugoyal","id":628968,"avatar_url":"https://avatars.githubusercontent.com/u/628968?v=3","gravatar_id":"","url":"https://api.github.com/users/manugoyal","html_url":"https://github.com/manugoyal","followers_url":"https://api.github.com/users/manugoyal/followers","following_url":"https://api.github.com/users/manugoyal/following{/other_user}","gists_url":"https://api.github.com/users/manugoyal/gists{/gist_id}","starred_url":"https://api.github.com/users/manugoyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manugoyal/subscriptions","organizations_url":"https://api.github.com/users/manugoyal/orgs","repos_url":"https://api.github.com/users/manugoyal/repos","events_url":"https://api.github.com/users/manugoyal/events{/privacy}","received_events_url":"https://api.github.com/users/manugoyal/received_events","type":"User","site_admin":false},"body":"The bulk of this commit is renaming/refactors, so below we detail\r\nthe important things to look at\r\n\r\nIn tachyon.thrift, we deleted all the thrift exceptions, and\r\nreplaced them with two exceptions, TachyonTException and\r\nThriftIOException, which are general containers for Tachyon\r\nexceptions and IOExceptions, respectively. Also modified the\r\nservice interfaces to only throw those exceptions.\r\n\r\nIn tacyhon/exception/, we defined the TachyonException class as a\r\nsuperclass of all Tachyon exceptions, which can convert back and\r\nforth between TachyonTException using error codes. We then\r\ndefined an exception subclass for each of the error code values,\r\nwhich will be the specific exceptions that we throw around in\r\nTachyon everywhere except the thrift layer.\r\n\r\nFinally, in the client code, whenever we make an RPC call, we\r\nimmediately convert the TachyonTException to a TachyonException\r\nand the ThriftIOException to an IOException, and propagate that\r\nup to the top layer of the client. At any user-facing boundary of\r\nthe client (like TachyonFileSystem), we'll unwrap the\r\nTachyonException with any specific ones we think it might throw.\r\nOtherwise, we'll throw the general TachyonException as-is, as a\r\ncatch-all for exceptions we didn't expect, or might add later. By\r\nincluding the TachyonException in all the 'throws' clauses of the\r\nfunction signatures, we allow for backwards compatibility by\r\nensuring that newly added exceptions won't cause a compile-time\r\nerror in user code.","created_at":"2015-09-26T00:54:56Z","updated_at":"2015-09-30T20:47:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e0cbb944f6a329b3fef768e3d515c9ca8ec2b99","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/amplab/tachyon/pulls/1656/commits","review_comments_url":"https://api.github.com/repos/amplab/tachyon/pulls/1656/comments","review_comment_url":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amplab/tachyon/issues/1656/comments","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/b7345e28c8058bd48a026e6246e909b022d767f1","head":{"label":"manugoyal:unify-exceptions","ref":"unify-exceptions","sha":"b7345e28c8058bd48a026e6246e909b022d767f1","user":{"login":"manugoyal","id":628968,"avatar_url":"https://avatars.githubusercontent.com/u/628968?v=3","gravatar_id":"","url":"https://api.github.com/users/manugoyal","html_url":"https://github.com/manugoyal","followers_url":"https://api.github.com/users/manugoyal/followers","following_url":"https://api.github.com/users/manugoyal/following{/other_user}","gists_url":"https://api.github.com/users/manugoyal/gists{/gist_id}","starred_url":"https://api.github.com/users/manugoyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manugoyal/subscriptions","organizations_url":"https://api.github.com/users/manugoyal/orgs","repos_url":"https://api.github.com/users/manugoyal/repos","events_url":"https://api.github.com/users/manugoyal/events{/privacy}","received_events_url":"https://api.github.com/users/manugoyal/received_events","type":"User","site_admin":false},"repo":{"id":16339378,"name":"tachyon","full_name":"manugoyal/tachyon","owner":{"login":"manugoyal","id":628968,"avatar_url":"https://avatars.githubusercontent.com/u/628968?v=3","gravatar_id":"","url":"https://api.github.com/users/manugoyal","html_url":"https://github.com/manugoyal","followers_url":"https://api.github.com/users/manugoyal/followers","following_url":"https://api.github.com/users/manugoyal/following{/other_user}","gists_url":"https://api.github.com/users/manugoyal/gists{/gist_id}","starred_url":"https://api.github.com/users/manugoyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manugoyal/subscriptions","organizations_url":"https://api.github.com/users/manugoyal/orgs","repos_url":"https://api.github.com/users/manugoyal/repos","events_url":"https://api.github.com/users/manugoyal/events{/privacy}","received_events_url":"https://api.github.com/users/manugoyal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/manugoyal/tachyon","description":"Reliable File Sharing at Memory Speed Across Cluster Frameworks","fork":true,"url":"https://api.github.com/repos/manugoyal/tachyon","forks_url":"https://api.github.com/repos/manugoyal/tachyon/forks","keys_url":"https://api.github.com/repos/manugoyal/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manugoyal/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manugoyal/tachyon/teams","hooks_url":"https://api.github.com/repos/manugoyal/tachyon/hooks","issue_events_url":"https://api.github.com/repos/manugoyal/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/manugoyal/tachyon/events","assignees_url":"https://api.github.com/repos/manugoyal/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/manugoyal/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/manugoyal/tachyon/tags","blobs_url":"https://api.github.com/repos/manugoyal/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manugoyal/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manugoyal/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/manugoyal/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manugoyal/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/manugoyal/tachyon/languages","stargazers_url":"https://api.github.com/repos/manugoyal/tachyon/stargazers","contributors_url":"https://api.github.com/repos/manugoyal/tachyon/contributors","subscribers_url":"https://api.github.com/repos/manugoyal/tachyon/subscribers","subscription_url":"https://api.github.com/repos/manugoyal/tachyon/subscription","commits_url":"https://api.github.com/repos/manugoyal/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/manugoyal/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/manugoyal/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/manugoyal/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/manugoyal/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/manugoyal/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manugoyal/tachyon/merges","archive_url":"https://api.github.com/repos/manugoyal/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manugoyal/tachyon/downloads","issues_url":"https://api.github.com/repos/manugoyal/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/manugoyal/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/manugoyal/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/manugoyal/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manugoyal/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/manugoyal/tachyon/releases{/id}","created_at":"2014-01-29T08:35:14Z","updated_at":"2014-07-17T03:07:23Z","pushed_at":"2015-09-30T18:54:26Z","git_url":"git://github.com/manugoyal/tachyon.git","ssh_url":"git@github.com:manugoyal/tachyon.git","clone_url":"https://github.com/manugoyal/tachyon.git","svn_url":"https://github.com/manugoyal/tachyon","homepage":"http://tachyon-project.org","size":22738,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"amplab:master","ref":"master","sha":"c31c9ed0fc9b43bfa472da8d5ff2f5352f2da189","user":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"tachyon","full_name":"amplab/tachyon","owner":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amplab/tachyon","description":"Memory Centric Reliable Distributed Storage","fork":false,"url":"https://api.github.com/repos/amplab/tachyon","forks_url":"https://api.github.com/repos/amplab/tachyon/forks","keys_url":"https://api.github.com/repos/amplab/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amplab/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amplab/tachyon/teams","hooks_url":"https://api.github.com/repos/amplab/tachyon/hooks","issue_events_url":"https://api.github.com/repos/amplab/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/amplab/tachyon/events","assignees_url":"https://api.github.com/repos/amplab/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/amplab/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/amplab/tachyon/tags","blobs_url":"https://api.github.com/repos/amplab/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amplab/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amplab/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/amplab/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/amplab/tachyon/languages","stargazers_url":"https://api.github.com/repos/amplab/tachyon/stargazers","contributors_url":"https://api.github.com/repos/amplab/tachyon/contributors","subscribers_url":"https://api.github.com/repos/amplab/tachyon/subscribers","subscription_url":"https://api.github.com/repos/amplab/tachyon/subscription","commits_url":"https://api.github.com/repos/amplab/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/amplab/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/amplab/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/amplab/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/amplab/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/amplab/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amplab/tachyon/merges","archive_url":"https://api.github.com/repos/amplab/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amplab/tachyon/downloads","issues_url":"https://api.github.com/repos/amplab/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/amplab/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/amplab/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/amplab/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amplab/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/amplab/tachyon/releases{/id}","created_at":"2012-12-21T17:43:46Z","updated_at":"2015-09-30T07:48:41Z","pushed_at":"2015-09-30T20:47:05Z","git_url":"git://github.com/amplab/tachyon.git","ssh_url":"git@github.com:amplab/tachyon.git","clone_url":"https://github.com/amplab/tachyon.git","svn_url":"https://github.com/amplab/tachyon","homepage":"http://tachyon-project.org","size":53275,"stargazers_count":1600,"watchers_count":1600,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":636,"mirror_url":null,"open_issues_count":36,"forks":636,"open_issues":36,"watchers":1600,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1656"},"html":{"href":"https://github.com/amplab/tachyon/pull/1656"},"issue":{"href":"https://api.github.com/repos/amplab/tachyon/issues/1656"},"comments":{"href":"https://api.github.com/repos/amplab/tachyon/issues/1656/comments"},"review_comments":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1656/comments"},"review_comment":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1656/commits"},"statuses":{"href":"https://api.github.com/repos/amplab/tachyon/statuses/b7345e28c8058bd48a026e6246e909b022d767f1"}}}}