{"action":"created","issue":{"url":"https://api.github.com/repos/timscaffidi/ofxVideoRecorder/issues/21","labels_url":"https://api.github.com/repos/timscaffidi/ofxVideoRecorder/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/timscaffidi/ofxVideoRecorder/issues/21/comments","events_url":"https://api.github.com/repos/timscaffidi/ofxVideoRecorder/issues/21/events","html_url":"https://github.com/timscaffidi/ofxVideoRecorder/issues/21","id":92405590,"number":21,"title":"audioPipeFd and videoPipeFd used in close() are never initialized.","user":{"login":"smallfly","id":157141,"avatar_url":"https://avatars.githubusercontent.com/u/157141?v=3","gravatar_id":"","url":"https://api.github.com/users/smallfly","html_url":"https://github.com/smallfly","followers_url":"https://api.github.com/users/smallfly/followers","following_url":"https://api.github.com/users/smallfly/following{/other_user}","gists_url":"https://api.github.com/users/smallfly/gists{/gist_id}","starred_url":"https://api.github.com/users/smallfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smallfly/subscriptions","organizations_url":"https://api.github.com/users/smallfly/orgs","repos_url":"https://api.github.com/users/smallfly/repos","events_url":"https://api.github.com/users/smallfly/events{/privacy}","received_events_url":"https://api.github.com/users/smallfly/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-01T14:53:27Z","updated_at":"2015-07-16T23:25:06Z","closed_at":null,"body":"In the close() methods there are calls to setNonblocking():\r\n```\r\n//set pipes to non_blocking so we dont get stuck at the final writes\r\nsetNonblocking(audioPipeFd);\r\nsetNonblocking(videoPipeFd);\r\n```\r\nBut it seems that the variables audioPipeFd and videoPipeFd are never initialized.\r\nShould the calls the setNonblocking() be removed?"},"comment":{"url":"https://api.github.com/repos/timscaffidi/ofxVideoRecorder/issues/comments/122129911","html_url":"https://github.com/timscaffidi/ofxVideoRecorder/issues/21#issuecomment-122129911","issue_url":"https://api.github.com/repos/timscaffidi/ofxVideoRecorder/issues/21","id":122129911,"user":{"login":"timscaffidi","id":177125,"avatar_url":"https://avatars.githubusercontent.com/u/177125?v=3","gravatar_id":"","url":"https://api.github.com/users/timscaffidi","html_url":"https://github.com/timscaffidi","followers_url":"https://api.github.com/users/timscaffidi/followers","following_url":"https://api.github.com/users/timscaffidi/following{/other_user}","gists_url":"https://api.github.com/users/timscaffidi/gists{/gist_id}","starred_url":"https://api.github.com/users/timscaffidi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timscaffidi/subscriptions","organizations_url":"https://api.github.com/users/timscaffidi/orgs","repos_url":"https://api.github.com/users/timscaffidi/repos","events_url":"https://api.github.com/users/timscaffidi/events{/privacy}","received_events_url":"https://api.github.com/users/timscaffidi/received_events","type":"User","site_admin":false},"created_at":"2015-07-16T23:25:06Z","updated_at":"2015-07-16T23:25:06Z","body":"yes it appears those should be moved instead to be called in a function of the audio/video writer threads instead, since the file descriptors are no longer held by the main thread"}}