{"comment":{"url":"https://api.github.com/repos/stealthly/mirror-maker-mesos/comments/12967445","html_url":"https://github.com/stealthly/mirror-maker-mesos/commit/14c1b1d4e315b59fae0ed9cc49da2b35f7213c08#commitcomment-12967445","id":12967445,"user":{"login":"abiletskyi","id":1733325,"avatar_url":"https://avatars.githubusercontent.com/u/1733325?v=3","gravatar_id":"","url":"https://api.github.com/users/abiletskyi","html_url":"https://github.com/abiletskyi","followers_url":"https://api.github.com/users/abiletskyi/followers","following_url":"https://api.github.com/users/abiletskyi/following{/other_user}","gists_url":"https://api.github.com/users/abiletskyi/gists{/gist_id}","starred_url":"https://api.github.com/users/abiletskyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abiletskyi/subscriptions","organizations_url":"https://api.github.com/users/abiletskyi/orgs","repos_url":"https://api.github.com/users/abiletskyi/repos","events_url":"https://api.github.com/users/abiletskyi/events{/privacy}","received_events_url":"https://api.github.com/users/abiletskyi/received_events","type":"User","site_admin":false},"position":141,"line":141,"path":"src/main/scala/ly/stealth/mesos/mirrormaker/executor/MirrorMakerProcess.scala","commit_id":"14c1b1d4e315b59fae0ed9cc49da2b35f7213c08","created_at":"2015-08-30T22:15:35Z","updated_at":"2015-08-30T22:15:35Z","body":"@joestein Yes, I agree at the first glance it doesn't seem like a durable solution.\r\nBut as I understood we are trying to follow here the trunk MM codebase (except for the new consumer part). The point is that I believe people from the different companies have tested such approach and I believe there are no concerns about this part of the MM.\r\nAs I understood we are trying to resolve another problem - we lose control of MM process and don't know what happened to it.\r\nAlso, as I understood committing offset on each producer callback completion might dramatically affect performance because this happens quite frequently unless you configure RecordAccumulator to be huge, but this has it's own drawbacks. Again, it might not, but in this case why MM is used in production written this way?\r\nLong story short, let me know if we should think about such aspects as learning/improving MM durability characteristics - for now my main focus was moving it to mesos \"as-is\"."}}