{"action":"created","issue":{"url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/issues/193","labels_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/issues/193/labels{/name}","comments_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/issues/193/comments","events_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/issues/193/events","html_url":"https://github.com/BoltsFramework/Bolts-iOS/pull/193","id":114438286,"number":193,"title":"Fixed issue 192","user":{"login":"marchy","id":1369360,"avatar_url":"https://avatars.githubusercontent.com/u/1369360?v=3","gravatar_id":"","url":"https://api.github.com/users/marchy","html_url":"https://github.com/marchy","followers_url":"https://api.github.com/users/marchy/followers","following_url":"https://api.github.com/users/marchy/following{/other_user}","gists_url":"https://api.github.com/users/marchy/gists{/gist_id}","starred_url":"https://api.github.com/users/marchy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marchy/subscriptions","organizations_url":"https://api.github.com/users/marchy/orgs","repos_url":"https://api.github.com/users/marchy/repos","events_url":"https://api.github.com/users/marchy/events{/privacy}","received_events_url":"https://api.github.com/users/marchy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-31T22:32:43Z","updated_at":"2015-10-31T22:33:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/pulls/193","html_url":"https://github.com/BoltsFramework/Bolts-iOS/pull/193","diff_url":"https://github.com/BoltsFramework/Bolts-iOS/pull/193.diff","patch_url":"https://github.com/BoltsFramework/Bolts-iOS/pull/193.patch"},"body":"Fixed issue 192 (https://github.com/BoltsFramework/Bolts-iOS/issues/192), allowing projects that include frameworks which themselves include Bolts to work without running into “Include of non-modular header inside framework module” compilation errors.\r\n\r\nThe problem here was that there were dependencies included directly in the .h file instead of in the .m files (see here: http://stackoverflow.com/questions/28552500/xcode6-receiving-error-include-of-non-modular-header-inside-framework-module).\r\n\r\nInstead these were moved to use the proper @class and @protocol definitions in the headers and only including the actual file in the .m file. This removes the circular dependency issues so that the Objective-C compiler can properly make everything work in projects that include sub-dependencies (ie: include a framework which it itself includes the Bolts library)"},"comment":{"url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/issues/comments/152778444","html_url":"https://github.com/BoltsFramework/Bolts-iOS/pull/193#issuecomment-152778444","issue_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/issues/193","id":152778444,"user":{"login":"facebook-github-bot","id":6422482,"avatar_url":"https://avatars.githubusercontent.com/u/6422482?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook-github-bot","html_url":"https://github.com/facebook-github-bot","followers_url":"https://api.github.com/users/facebook-github-bot/followers","following_url":"https://api.github.com/users/facebook-github-bot/following{/other_user}","gists_url":"https://api.github.com/users/facebook-github-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook-github-bot/subscriptions","organizations_url":"https://api.github.com/users/facebook-github-bot/orgs","repos_url":"https://api.github.com/users/facebook-github-bot/repos","events_url":"https://api.github.com/users/facebook-github-bot/events{/privacy}","received_events_url":"https://api.github.com/users/facebook-github-bot/received_events","type":"User","site_admin":false},"created_at":"2015-10-31T22:33:19Z","updated_at":"2015-10-31T22:33:19Z","body":"Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!"}}