{"action":"created","comment":{"url":"https://api.github.com/repos/angular/ts2dart/pulls/comments/36436494","id":36436494,"diff_hunk":"@@ -353,6 +353,50 @@ export class FacadeConverter extends base.TranspilerBase {\n         this.emitMethodCall('remove', c.arguments);\n         this.emit('!= null || true ) )');\n       },\n+      'Map.forEach': (c: ts.CallExpression, context: ts.Expression) => {\n+        let cb: any;\n+        let params: any;\n+\n+        switch (c.arguments[0].kind) {\n+          case ts.SyntaxKind.FunctionExpression:\n+            cb = <ts.FunctionExpression>(c.arguments[0]);\n+            params = cb.parameters;\n+            if (params.length != 2) {\n+              this.reportError(c, 'Map.forEach callback requires exactly two arguments');","path":"lib/facade_converter.ts","position":13,"original_position":13,"commit_id":"d73f549a46b46cd9ed915838e3941f3642cffd2f","original_commit_id":"36f3e18e5f6d32e3c63194200fa5c20c8e074363","user":{"login":"mprobst","id":7208,"avatar_url":"https://avatars.githubusercontent.com/u/7208?v=3","gravatar_id":"","url":"https://api.github.com/users/mprobst","html_url":"https://github.com/mprobst","followers_url":"https://api.github.com/users/mprobst/followers","following_url":"https://api.github.com/users/mprobst/following{/other_user}","gists_url":"https://api.github.com/users/mprobst/gists{/gist_id}","starred_url":"https://api.github.com/users/mprobst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mprobst/subscriptions","organizations_url":"https://api.github.com/users/mprobst/orgs","repos_url":"https://api.github.com/users/mprobst/repos","events_url":"https://api.github.com/users/mprobst/events{/privacy}","received_events_url":"https://api.github.com/users/mprobst/received_events","type":"User","site_admin":false},"body":"No please don't. It only breaks execution flow during tests so you get a nicer stack trace - but in production use, we want to capture all errors in a list, instead of failing at the first wrong thing (so that a user doesn't have to re-run for every single error).","created_at":"2015-08-06T16:42:16Z","updated_at":"2015-08-06T16:42:16Z","html_url":"https://github.com/angular/ts2dart/pull/256#discussion_r36436494","pull_request_url":"https://api.github.com/repos/angular/ts2dart/pulls/256","_links":{"self":{"href":"https://api.github.com/repos/angular/ts2dart/pulls/comments/36436494"},"html":{"href":"https://github.com/angular/ts2dart/pull/256#discussion_r36436494"},"pull_request":{"href":"https://api.github.com/repos/angular/ts2dart/pulls/256"}}},"pull_request":{"url":"https://api.github.com/repos/angular/ts2dart/pulls/256","id":41626910,"html_url":"https://github.com/angular/ts2dart/pull/256","diff_url":"https://github.com/angular/ts2dart/pull/256.diff","patch_url":"https://github.com/angular/ts2dart/pull/256.patch","issue_url":"https://api.github.com/repos/angular/ts2dart/issues/256","number":256,"state":"open","locked":false,"title":"feat(Facade): add support for Map.forEach","user":{"login":"vicb","id":248818,"avatar_url":"https://avatars.githubusercontent.com/u/248818?v=3","gravatar_id":"","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false},"body":"fixes #253\r\ncloses #215\r\n\r\n@mprobst I would have preferred to factorize some code but not sure if it's worth it due to the subtle diffs of fn vs arrow.\r\n\r\n/cc @tbosch \r\n\r\n/ref #227 ","created_at":"2015-08-04T22:51:49Z","updated_at":"2015-08-06T16:42:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"035fba95742c280c91b851098885ecbbcbd9b9ba","assignee":{"login":"mprobst","id":7208,"avatar_url":"https://avatars.githubusercontent.com/u/7208?v=3","gravatar_id":"","url":"https://api.github.com/users/mprobst","html_url":"https://github.com/mprobst","followers_url":"https://api.github.com/users/mprobst/followers","following_url":"https://api.github.com/users/mprobst/following{/other_user}","gists_url":"https://api.github.com/users/mprobst/gists{/gist_id}","starred_url":"https://api.github.com/users/mprobst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mprobst/subscriptions","organizations_url":"https://api.github.com/users/mprobst/orgs","repos_url":"https://api.github.com/users/mprobst/repos","events_url":"https://api.github.com/users/mprobst/events{/privacy}","received_events_url":"https://api.github.com/users/mprobst/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/angular/ts2dart/pulls/256/commits","review_comments_url":"https://api.github.com/repos/angular/ts2dart/pulls/256/comments","review_comment_url":"https://api.github.com/repos/angular/ts2dart/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/ts2dart/issues/256/comments","statuses_url":"https://api.github.com/repos/angular/ts2dart/statuses/d73f549a46b46cd9ed915838e3941f3642cffd2f","head":{"label":"vicb:0804-mfe","ref":"0804-mfe","sha":"d73f549a46b46cd9ed915838e3941f3642cffd2f","user":{"login":"vicb","id":248818,"avatar_url":"https://avatars.githubusercontent.com/u/248818?v=3","gravatar_id":"","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false},"repo":{"id":37546409,"name":"ts2dart","full_name":"vicb/ts2dart","owner":{"login":"vicb","id":248818,"avatar_url":"https://avatars.githubusercontent.com/u/248818?v=3","gravatar_id":"","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vicb/ts2dart","description":"ts2dart TypeScript to Dart transpiler","fork":true,"url":"https://api.github.com/repos/vicb/ts2dart","forks_url":"https://api.github.com/repos/vicb/ts2dart/forks","keys_url":"https://api.github.com/repos/vicb/ts2dart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vicb/ts2dart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vicb/ts2dart/teams","hooks_url":"https://api.github.com/repos/vicb/ts2dart/hooks","issue_events_url":"https://api.github.com/repos/vicb/ts2dart/issues/events{/number}","events_url":"https://api.github.com/repos/vicb/ts2dart/events","assignees_url":"https://api.github.com/repos/vicb/ts2dart/assignees{/user}","branches_url":"https://api.github.com/repos/vicb/ts2dart/branches{/branch}","tags_url":"https://api.github.com/repos/vicb/ts2dart/tags","blobs_url":"https://api.github.com/repos/vicb/ts2dart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vicb/ts2dart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vicb/ts2dart/git/refs{/sha}","trees_url":"https://api.github.com/repos/vicb/ts2dart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vicb/ts2dart/statuses/{sha}","languages_url":"https://api.github.com/repos/vicb/ts2dart/languages","stargazers_url":"https://api.github.com/repos/vicb/ts2dart/stargazers","contributors_url":"https://api.github.com/repos/vicb/ts2dart/contributors","subscribers_url":"https://api.github.com/repos/vicb/ts2dart/subscribers","subscription_url":"https://api.github.com/repos/vicb/ts2dart/subscription","commits_url":"https://api.github.com/repos/vicb/ts2dart/commits{/sha}","git_commits_url":"https://api.github.com/repos/vicb/ts2dart/git/commits{/sha}","comments_url":"https://api.github.com/repos/vicb/ts2dart/comments{/number}","issue_comment_url":"https://api.github.com/repos/vicb/ts2dart/issues/comments{/number}","contents_url":"https://api.github.com/repos/vicb/ts2dart/contents/{+path}","compare_url":"https://api.github.com/repos/vicb/ts2dart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vicb/ts2dart/merges","archive_url":"https://api.github.com/repos/vicb/ts2dart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vicb/ts2dart/downloads","issues_url":"https://api.github.com/repos/vicb/ts2dart/issues{/number}","pulls_url":"https://api.github.com/repos/vicb/ts2dart/pulls{/number}","milestones_url":"https://api.github.com/repos/vicb/ts2dart/milestones{/number}","notifications_url":"https://api.github.com/repos/vicb/ts2dart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vicb/ts2dart/labels{/name}","releases_url":"https://api.github.com/repos/vicb/ts2dart/releases{/id}","created_at":"2015-06-16T17:49:47Z","updated_at":"2015-06-16T17:49:47Z","pushed_at":"2015-08-06T15:48:17Z","git_url":"git://github.com/vicb/ts2dart.git","ssh_url":"git@github.com:vicb/ts2dart.git","clone_url":"https://github.com/vicb/ts2dart.git","svn_url":"https://github.com/vicb/ts2dart","homepage":"","size":461,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"8e3ca3b4e4087c7ec516b87717c0ffea3e7d3733","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":32405591,"name":"ts2dart","full_name":"angular/ts2dart","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/ts2dart","description":"ts2dart TypeScript to Dart transpiler","fork":false,"url":"https://api.github.com/repos/angular/ts2dart","forks_url":"https://api.github.com/repos/angular/ts2dart/forks","keys_url":"https://api.github.com/repos/angular/ts2dart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/ts2dart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/ts2dart/teams","hooks_url":"https://api.github.com/repos/angular/ts2dart/hooks","issue_events_url":"https://api.github.com/repos/angular/ts2dart/issues/events{/number}","events_url":"https://api.github.com/repos/angular/ts2dart/events","assignees_url":"https://api.github.com/repos/angular/ts2dart/assignees{/user}","branches_url":"https://api.github.com/repos/angular/ts2dart/branches{/branch}","tags_url":"https://api.github.com/repos/angular/ts2dart/tags","blobs_url":"https://api.github.com/repos/angular/ts2dart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/ts2dart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/ts2dart/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/ts2dart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/ts2dart/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/ts2dart/languages","stargazers_url":"https://api.github.com/repos/angular/ts2dart/stargazers","contributors_url":"https://api.github.com/repos/angular/ts2dart/contributors","subscribers_url":"https://api.github.com/repos/angular/ts2dart/subscribers","subscription_url":"https://api.github.com/repos/angular/ts2dart/subscription","commits_url":"https://api.github.com/repos/angular/ts2dart/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/ts2dart/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/ts2dart/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/ts2dart/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/ts2dart/contents/{+path}","compare_url":"https://api.github.com/repos/angular/ts2dart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/ts2dart/merges","archive_url":"https://api.github.com/repos/angular/ts2dart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/ts2dart/downloads","issues_url":"https://api.github.com/repos/angular/ts2dart/issues{/number}","pulls_url":"https://api.github.com/repos/angular/ts2dart/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/ts2dart/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/ts2dart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/ts2dart/labels{/name}","releases_url":"https://api.github.com/repos/angular/ts2dart/releases{/id}","created_at":"2015-03-17T16:28:22Z","updated_at":"2015-07-11T05:30:24Z","pushed_at":"2015-08-06T15:48:17Z","git_url":"git://github.com/angular/ts2dart.git","ssh_url":"git@github.com:angular/ts2dart.git","clone_url":"https://github.com/angular/ts2dart.git","svn_url":"https://github.com/angular/ts2dart","homepage":"","size":2016,"stargazers_count":22,"watchers_count":22,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":22,"forks":16,"open_issues":22,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/ts2dart/pulls/256"},"html":{"href":"https://github.com/angular/ts2dart/pull/256"},"issue":{"href":"https://api.github.com/repos/angular/ts2dart/issues/256"},"comments":{"href":"https://api.github.com/repos/angular/ts2dart/issues/256/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/ts2dart/pulls/256/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/ts2dart/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/ts2dart/pulls/256/commits"},"statuses":{"href":"https://api.github.com/repos/angular/ts2dart/statuses/d73f549a46b46cd9ed915838e3941f3642cffd2f"}}}}