{"action":"created","issue":{"url":"https://api.github.com/repos/Valloric/ycmd/issues/270","labels_url":"https://api.github.com/repos/Valloric/ycmd/issues/270/labels{/name}","comments_url":"https://api.github.com/repos/Valloric/ycmd/issues/270/comments","events_url":"https://api.github.com/repos/Valloric/ycmd/issues/270/events","html_url":"https://github.com/Valloric/ycmd/pull/270","id":121709755,"number":270,"title":"Refactoring integration tests","user":{"login":"micbou","id":10026824,"avatar_url":"https://avatars.githubusercontent.com/u/10026824?v=3","gravatar_id":"","url":"https://api.github.com/users/micbou","html_url":"https://github.com/micbou","followers_url":"https://api.github.com/users/micbou/followers","following_url":"https://api.github.com/users/micbou/following{/other_user}","gists_url":"https://api.github.com/users/micbou/gists{/gist_id}","starred_url":"https://api.github.com/users/micbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micbou/subscriptions","organizations_url":"https://api.github.com/users/micbou/orgs","repos_url":"https://api.github.com/users/micbou/repos","events_url":"https://api.github.com/users/micbou/events{/privacy}","received_events_url":"https://api.github.com/users/micbou/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":25,"created_at":"2015-12-11T13:41:36Z","updated_at":"2015-12-14T22:57:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Valloric/ycmd/pulls/270","html_url":"https://github.com/Valloric/ycmd/pull/270","diff_url":"https://github.com/Valloric/ycmd/pull/270.diff","patch_url":"https://github.com/Valloric/ycmd/pull/270.patch"},"body":"### Changes\r\n- Move related completer tests to their own subdirectories:\r\n```\r\nycmd\r\n  └── tests        \r\n      ├── clang\r\n      │   ├── testdata\r\n      │   ├── __init__.py\r\n      │   ├── get_completions_test.py\r\n      │   ├── diagnostics_test.py\r\n      │   ├── subcommands_test.py\r\n      │   └── utils.py \r\n      ├── cs ── ... \r\n      ├── python ── ...\r\n      ├── go ── ...\r\n      ...\r\n```\r\n- Regroup tests in classes and subclasses: take advantage of fixtures (`setUp` and `tearDown` methods) and inheritance.\r\n- Rename tests: names are now shorter;\r\n- Fix coding style;\r\n- Update copyright notices;\r\n- No tests were harmed during the making of this PR: 458 tests before, 458 tests after.\r\n\r\n### Issues?\r\n- Code to set the Bottle debug mode:\r\n```python\r\nimport bottle\r\n\r\nbottle.debug( True )\r\n```\r\nwas removed from all tests inheriting from `Handlers_test` where it is set in the `setUp` method. Is it enough to enable debug mode in all tests? I don't know how to check this.\r\n- `Basic_test` and `ZeroBasedLineAndColumn_test` tests in `Cs_Diagnostics_test` are near to be identical. Should we remove one of them?\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/valloric/ycmd/270)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/Valloric/ycmd/issues/comments/164587026","html_url":"https://github.com/Valloric/ycmd/pull/270#issuecomment-164587026","issue_url":"https://api.github.com/repos/Valloric/ycmd/issues/270","id":164587026,"user":{"login":"micbou","id":10026824,"avatar_url":"https://avatars.githubusercontent.com/u/10026824?v=3","gravatar_id":"","url":"https://api.github.com/users/micbou","html_url":"https://github.com/micbou","followers_url":"https://api.github.com/users/micbou/followers","following_url":"https://api.github.com/users/micbou/following{/other_user}","gists_url":"https://api.github.com/users/micbou/gists{/gist_id}","starred_url":"https://api.github.com/users/micbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micbou/subscriptions","organizations_url":"https://api.github.com/users/micbou/orgs","repos_url":"https://api.github.com/users/micbou/repos","events_url":"https://api.github.com/users/micbou/events{/privacy}","received_events_url":"https://api.github.com/users/micbou/received_events","type":"User","site_admin":false},"created_at":"2015-12-14T22:57:59Z","updated_at":"2015-12-14T22:57:59Z","body":"\n\n\n\nReview status: 110 of 116 files reviewed at latest revision, 3 unresolved discussions.\n\n---\n\n*[ycmd/tests/javascript/event_notification_test.py, line 54 \\[r6\\]](https://reviewable.io:443/reviews/valloric/ycmd/270#-K5XfgHnEEEoK_yHOLZi:-K5Xh6BrnUo5sNeI-IMV:-1793061001) ([raw file](https://github.com/valloric/ycmd/blob/fda5434408db82bd20bee36927850ddea63aae13/ycmd/tests/javascript/event_notification_test.py#L54)):*\nState is reset by the `tearDown` method in the `Javascript_Handlers_test`class. It should work exactly the same as before.\n\n---\n\n\n*Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/valloric/ycmd/270)*\n<!-- Sent from Reviewable.io -->\n"}}