{"action":"created","issue":{"url":"https://api.github.com/repos/rovo89/XposedAppSettings/issues/75","labels_url":"https://api.github.com/repos/rovo89/XposedAppSettings/issues/75/labels{/name}","comments_url":"https://api.github.com/repos/rovo89/XposedAppSettings/issues/75/comments","events_url":"https://api.github.com/repos/rovo89/XposedAppSettings/issues/75/events","html_url":"https://github.com/rovo89/XposedAppSettings/pull/75","id":101615910,"number":75,"title":"Added support for Android 5.1","user":{"login":"pylerSM","id":3438489,"avatar_url":"https://avatars.githubusercontent.com/u/3438489?v=3","gravatar_id":"","url":"https://api.github.com/users/pylerSM","html_url":"https://github.com/pylerSM","followers_url":"https://api.github.com/users/pylerSM/followers","following_url":"https://api.github.com/users/pylerSM/following{/other_user}","gists_url":"https://api.github.com/users/pylerSM/gists{/gist_id}","starred_url":"https://api.github.com/users/pylerSM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pylerSM/subscriptions","organizations_url":"https://api.github.com/users/pylerSM/orgs","repos_url":"https://api.github.com/users/pylerSM/repos","events_url":"https://api.github.com/users/pylerSM/events{/privacy}","received_events_url":"https://api.github.com/users/pylerSM/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-08-18T09:45:37Z","updated_at":"2015-08-28T10:15:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rovo89/XposedAppSettings/pulls/75","html_url":"https://github.com/rovo89/XposedAppSettings/pull/75","diff_url":"https://github.com/rovo89/XposedAppSettings/pull/75.diff","patch_url":"https://github.com/rovo89/XposedAppSettings/pull/75.patch"},"body":"There is no flag \"FLAG_NEEDS_MENU_KEY\" in Android 5.1 (and newer), so we should not look for it to prevent NoSuchFieldError, just set it to 0. Also hide option to show legacy menu, since it can't work on 5.1+.\r\n\r\nI posted fixed version on XDA some time ago and reports say it works. Consider packing all Lollipop base fixes and this fix and release update to repo. (I read you don't have key for it, just resign it and inform users to uninstall and then install this new version)"},"comment":{"url":"https://api.github.com/repos/rovo89/XposedAppSettings/issues/comments/135727473","html_url":"https://github.com/rovo89/XposedAppSettings/pull/75#issuecomment-135727473","issue_url":"https://api.github.com/repos/rovo89/XposedAppSettings/issues/75","id":135727473,"user":{"login":"rovo89","id":1573299,"avatar_url":"https://avatars.githubusercontent.com/u/1573299?v=3","gravatar_id":"","url":"https://api.github.com/users/rovo89","html_url":"https://github.com/rovo89","followers_url":"https://api.github.com/users/rovo89/followers","following_url":"https://api.github.com/users/rovo89/following{/other_user}","gists_url":"https://api.github.com/users/rovo89/gists{/gist_id}","starred_url":"https://api.github.com/users/rovo89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rovo89/subscriptions","organizations_url":"https://api.github.com/users/rovo89/orgs","repos_url":"https://api.github.com/users/rovo89/repos","events_url":"https://api.github.com/users/rovo89/events{/privacy}","received_events_url":"https://api.github.com/users/rovo89/received_events","type":"User","site_admin":false},"created_at":"2015-08-28T10:15:19Z","updated_at":"2015-08-28T10:15:19Z","body":"Sorry, but I currently have other priorities. I don't have the time to look at this in such a detailed way as I see necessary for such a wide-spread module (and I didn't even publish an official 5.1 update yet).\r\n\r\nRegarding the repo update: No way that I just upload a file that requires hundreds of thousands of users to uninstall the app and lose their settings. I've never tried the XML export and import, maybe that would be a way to avoid this. If yes, it would need to be clearly documented. Otherwise, we have to look for a better way, e.g. asking @Tungstwenty to sign the new APK, publishing the app under a new package name (maybe also with a new maintainer?), maybe also looking into your XInstaller module, although I would prefer a more targetted module that allows you to disable the signature check for a specific installation (e.g. you might be asked in the installer whether you want to override the check).\r\n\r\nSo for now, I couldn't do more than build a new APK, which is what you already did."}}