{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular.js/pulls/comments/47911920","id":47911920,"diff_hunk":"@@ -339,6 +341,56 @@ module.exports = function(grunt) {\n     grunt.task.run('shell:npm-install');\n   }\n \n+  grunt.registerTask('validate-angular-files', function() {\n+    var combinedFiles = Object.assign({}, files.angularModules);\n+    combinedFiles.ng = files.angularSrc;\n+    combinedFiles.angularLoader = files.angularLoader;\n+\n+    var errorsDetected = false;\n+    var directories = [];\n+    var detectedFiles = {\n+      \"src/ng/rootElement.js\": true\n+    };\n+\n+    for (var section in combinedFiles) {\n+      var sectionFiles = combinedFiles[section];\n+\n+      if (section != \"angularLoader\") {\n+        directories.push(\"src/\" + section);\n+      }\n+\n+      console.log(\"Validating \" + sectionFiles.length + \" files from the \\\"\" + section + \"\\\" module\");","path":"Gruntfile.js","position":32,"original_position":32,"commit_id":"e29d7a7d44f27b76116f97288bb6cdcdceb3cef3","original_commit_id":"e29d7a7d44f27b76116f97288bb6cdcdceb3cef3","user":{"login":"petebacondarwin","id":15655,"avatar_url":"https://avatars.githubusercontent.com/u/15655?v=3","gravatar_id":"","url":"https://api.github.com/users/petebacondarwin","html_url":"https://github.com/petebacondarwin","followers_url":"https://api.github.com/users/petebacondarwin/followers","following_url":"https://api.github.com/users/petebacondarwin/following{/other_user}","gists_url":"https://api.github.com/users/petebacondarwin/gists{/gist_id}","starred_url":"https://api.github.com/users/petebacondarwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petebacondarwin/subscriptions","organizations_url":"https://api.github.com/users/petebacondarwin/orgs","repos_url":"https://api.github.com/users/petebacondarwin/repos","events_url":"https://api.github.com/users/petebacondarwin/events{/privacy}","received_events_url":"https://api.github.com/users/petebacondarwin/received_events","type":"User","site_admin":false},"body":"why `console.log` by `grunt.log` elsewhere?","created_at":"2015-12-17T14:38:39Z","updated_at":"2015-12-17T14:38:39Z","html_url":"https://github.com/angular/angular.js/pull/13553#discussion_r47911920","pull_request_url":"https://api.github.com/repos/angular/angular.js/pulls/13553","_links":{"self":{"href":"https://api.github.com/repos/angular/angular.js/pulls/comments/47911920"},"html":{"href":"https://github.com/angular/angular.js/pull/13553#discussion_r47911920"},"pull_request":{"href":"https://api.github.com/repos/angular/angular.js/pulls/13553"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular.js/pulls/13553","id":53752436,"html_url":"https://github.com/angular/angular.js/pull/13553","diff_url":"https://github.com/angular/angular.js/pull/13553.diff","patch_url":"https://github.com/angular/angular.js/pull/13553.patch","issue_url":"https://api.github.com/repos/angular/angular.js/issues/13553","number":13553,"state":"open","locked":false,"title":"chore(build): add a validation step for angularFiles","user":{"login":"matsko","id":93018,"avatar_url":"https://avatars.githubusercontent.com/u/93018?v=3","gravatar_id":"","url":"https://api.github.com/users/matsko","html_url":"https://github.com/matsko","followers_url":"https://api.github.com/users/matsko/followers","following_url":"https://api.github.com/users/matsko/following{/other_user}","gists_url":"https://api.github.com/users/matsko/gists{/gist_id}","starred_url":"https://api.github.com/users/matsko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matsko/subscriptions","organizations_url":"https://api.github.com/users/matsko/orgs","repos_url":"https://api.github.com/users/matsko/repos","events_url":"https://api.github.com/users/matsko/events{/privacy}","received_events_url":"https://api.github.com/users/matsko/received_events","type":"User","site_admin":false},"body":"The output looks like this (when passing):\r\n\r\n```bash\r\nRunning \"validate-angular-files\" task\r\nValidating 13 files from the 'ngAnimate' module\r\nValidating 5 files from the 'ngCookies' module\r\nValidating 7 files from the 'ngMessageFormat' module\r\nValidating 3 files from the 'ngMessages' module\r\nValidating 3 files from the 'ngResource' module\r\nValidating 5 files from the 'ngRoute' module\r\nValidating 4 files from the 'ngSanitize' module\r\nValidating 3 files from the 'ngMock' module\r\nValidating 6 files from the 'ngTouch' module\r\nValidating 3 files from the 'ngAria' module\r\nValidating 76 files from the 'ng' module\r\nValidating 5 files from the 'angularLoader' module\r\nAll files were detected successfully!\r\n```\r\n\r\nWhen failing (when a file is referenced in a module but doesn't exist in the local filesystem):\r\n\r\n```bash\r\nRunning \"validate-angular-files\" task\r\nValidating 14 files from the 'ngAnimate' module\r\n>> src/ngAnimate/referenced-but-missing-file.js does not exist in the local file structure\r\nValidating 5 files from the 'ngCookies' module\r\nValidating 7 files from the 'ngMessageFormat' module\r\nValidating 3 files from the 'ngMessages' module\r\nValidating 3 files from the 'ngResource' module\r\nValidating 5 files from the 'ngRoute' module\r\nValidating 4 files from the 'ngSanitize' module\r\nValidating 3 files from the 'ngMock' module\r\nValidating 6 files from the 'ngTouch' module\r\nValidating 3 files from the 'ngAria' module\r\nValidating 76 files from the 'ng' module\r\nValidating 5 files from the 'angularLoader' module\r\nWarning: Not all files were properly detected the local file structure Use --force to continue.\r\n```\r\n\r\nWhen failing (when a file exists locally but isn't used in any module):\r\n\r\n```bash\r\nRunning \"validate-angular-files\" task\r\nValidating 13 files from the 'ngAnimate' module\r\nValidating 5 files from the 'ngCookies' module\r\nValidating 7 files from the 'ngMessageFormat' module\r\nValidating 3 files from the 'ngMessages' module\r\nValidating 3 files from the 'ngResource' module\r\nValidating 5 files from the 'ngRoute' module\r\nValidating 4 files from the 'ngSanitize' module\r\nValidating 3 files from the 'ngMock' module\r\nValidating 6 files from the 'ngTouch' module\r\nValidating 3 files from the 'ngAria' module\r\nValidating 76 files from the 'ng' module\r\nValidating 5 files from the 'angularLoader' module\r\n>> src/ngAnimate/missing-file exists in the local file structure but isn't used by any module\r\nWarning: Not all files were properly detected the local file structure Use --force to continue.\r\n```","created_at":"2015-12-15T19:48:12Z","updated_at":"2015-12-17T14:38:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"38b07755eddd7b105905a7963272aed16a5b63a5","assignee":{"login":"petebacondarwin","id":15655,"avatar_url":"https://avatars.githubusercontent.com/u/15655?v=3","gravatar_id":"","url":"https://api.github.com/users/petebacondarwin","html_url":"https://github.com/petebacondarwin","followers_url":"https://api.github.com/users/petebacondarwin/followers","following_url":"https://api.github.com/users/petebacondarwin/following{/other_user}","gists_url":"https://api.github.com/users/petebacondarwin/gists{/gist_id}","starred_url":"https://api.github.com/users/petebacondarwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petebacondarwin/subscriptions","organizations_url":"https://api.github.com/users/petebacondarwin/orgs","repos_url":"https://api.github.com/users/petebacondarwin/repos","events_url":"https://api.github.com/users/petebacondarwin/events{/privacy}","received_events_url":"https://api.github.com/users/petebacondarwin/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular.js/pulls/13553/commits","review_comments_url":"https://api.github.com/repos/angular/angular.js/pulls/13553/comments","review_comment_url":"https://api.github.com/repos/angular/angular.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular.js/issues/13553/comments","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/e29d7a7d44f27b76116f97288bb6cdcdceb3cef3","head":{"label":"matsko:track_local_files","ref":"track_local_files","sha":"e29d7a7d44f27b76116f97288bb6cdcdceb3cef3","user":{"login":"matsko","id":93018,"avatar_url":"https://avatars.githubusercontent.com/u/93018?v=3","gravatar_id":"","url":"https://api.github.com/users/matsko","html_url":"https://github.com/matsko","followers_url":"https://api.github.com/users/matsko/followers","following_url":"https://api.github.com/users/matsko/following{/other_user}","gists_url":"https://api.github.com/users/matsko/gists{/gist_id}","starred_url":"https://api.github.com/users/matsko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matsko/subscriptions","organizations_url":"https://api.github.com/users/matsko/orgs","repos_url":"https://api.github.com/users/matsko/repos","events_url":"https://api.github.com/users/matsko/events{/privacy}","received_events_url":"https://api.github.com/users/matsko/received_events","type":"User","site_admin":false},"repo":{"id":8178278,"name":"angular.js","full_name":"matsko/angular.js","owner":{"login":"matsko","id":93018,"avatar_url":"https://avatars.githubusercontent.com/u/93018?v=3","gravatar_id":"","url":"https://api.github.com/users/matsko","html_url":"https://github.com/matsko","followers_url":"https://api.github.com/users/matsko/followers","following_url":"https://api.github.com/users/matsko/following{/other_user}","gists_url":"https://api.github.com/users/matsko/gists{/gist_id}","starred_url":"https://api.github.com/users/matsko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matsko/subscriptions","organizations_url":"https://api.github.com/users/matsko/orgs","repos_url":"https://api.github.com/users/matsko/repos","events_url":"https://api.github.com/users/matsko/events{/privacy}","received_events_url":"https://api.github.com/users/matsko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matsko/angular.js","description":"","fork":true,"url":"https://api.github.com/repos/matsko/angular.js","forks_url":"https://api.github.com/repos/matsko/angular.js/forks","keys_url":"https://api.github.com/repos/matsko/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matsko/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matsko/angular.js/teams","hooks_url":"https://api.github.com/repos/matsko/angular.js/hooks","issue_events_url":"https://api.github.com/repos/matsko/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/matsko/angular.js/events","assignees_url":"https://api.github.com/repos/matsko/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/matsko/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/matsko/angular.js/tags","blobs_url":"https://api.github.com/repos/matsko/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matsko/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matsko/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/matsko/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matsko/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/matsko/angular.js/languages","stargazers_url":"https://api.github.com/repos/matsko/angular.js/stargazers","contributors_url":"https://api.github.com/repos/matsko/angular.js/contributors","subscribers_url":"https://api.github.com/repos/matsko/angular.js/subscribers","subscription_url":"https://api.github.com/repos/matsko/angular.js/subscription","commits_url":"https://api.github.com/repos/matsko/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/matsko/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/matsko/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/matsko/angular.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/matsko/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/matsko/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matsko/angular.js/merges","archive_url":"https://api.github.com/repos/matsko/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matsko/angular.js/downloads","issues_url":"https://api.github.com/repos/matsko/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/matsko/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/matsko/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/matsko/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matsko/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/matsko/angular.js/releases{/id}","created_at":"2013-02-13T11:54:29Z","updated_at":"2015-04-10T17:45:17Z","pushed_at":"2015-12-15T20:06:15Z","git_url":"git://github.com/matsko/angular.js.git","ssh_url":"git@github.com:matsko/angular.js.git","clone_url":"https://github.com/matsko/angular.js.git","svn_url":"https://github.com/matsko/angular.js","homepage":"http://angularjs.org","size":72021,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"983374c574de67dafa35cabd9f4a95cd90791060","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":460078,"name":"angular.js","full_name":"angular/angular.js","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular.js","description":"HTML enhanced for web apps","fork":false,"url":"https://api.github.com/repos/angular/angular.js","forks_url":"https://api.github.com/repos/angular/angular.js/forks","keys_url":"https://api.github.com/repos/angular/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular.js/teams","hooks_url":"https://api.github.com/repos/angular/angular.js/hooks","issue_events_url":"https://api.github.com/repos/angular/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular.js/events","assignees_url":"https://api.github.com/repos/angular/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular.js/tags","blobs_url":"https://api.github.com/repos/angular/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular.js/languages","stargazers_url":"https://api.github.com/repos/angular/angular.js/stargazers","contributors_url":"https://api.github.com/repos/angular/angular.js/contributors","subscribers_url":"https://api.github.com/repos/angular/angular.js/subscribers","subscription_url":"https://api.github.com/repos/angular/angular.js/subscription","commits_url":"https://api.github.com/repos/angular/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular.js/merges","archive_url":"https://api.github.com/repos/angular/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular.js/downloads","issues_url":"https://api.github.com/repos/angular/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular.js/releases{/id}","created_at":"2010-01-06T00:34:37Z","updated_at":"2015-12-17T14:15:18Z","pushed_at":"2015-12-17T14:15:49Z","git_url":"git://github.com/angular/angular.js.git","ssh_url":"git@github.com:angular/angular.js.git","clone_url":"https://github.com/angular/angular.js.git","svn_url":"https://github.com/angular/angular.js","homepage":"http://angularjs.org","size":140864,"stargazers_count":45205,"watchers_count":45205,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20821,"mirror_url":null,"open_issues_count":1268,"forks":20821,"open_issues":1268,"watchers":45205,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular.js/pulls/13553"},"html":{"href":"https://github.com/angular/angular.js/pull/13553"},"issue":{"href":"https://api.github.com/repos/angular/angular.js/issues/13553"},"comments":{"href":"https://api.github.com/repos/angular/angular.js/issues/13553/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular.js/pulls/13553/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular.js/pulls/13553/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular.js/statuses/e29d7a7d44f27b76116f97288bb6cdcdceb3cef3"}}}}