{"action":"closed","number":28,"pull_request":{"url":"https://api.github.com/repos/verma/pani/pulls/28","id":28898420,"html_url":"https://github.com/verma/pani/pull/28","diff_url":"https://github.com/verma/pani/pull/28.diff","patch_url":"https://github.com/verma/pani/pull/28.patch","issue_url":"https://api.github.com/repos/verma/pani/issues/28","number":28,"state":"closed","locked":false,"title":"Miscellaneous things","user":{"login":"crisptrutski","id":881351,"avatar_url":"https://avatars.githubusercontent.com/u/881351?v=3","gravatar_id":"","url":"https://api.github.com/users/crisptrutski","html_url":"https://github.com/crisptrutski","followers_url":"https://api.github.com/users/crisptrutski/followers","following_url":"https://api.github.com/users/crisptrutski/following{/other_user}","gists_url":"https://api.github.com/users/crisptrutski/gists{/gist_id}","starred_url":"https://api.github.com/users/crisptrutski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crisptrutski/subscriptions","organizations_url":"https://api.github.com/users/crisptrutski/orgs","repos_url":"https://api.github.com/users/crisptrutski/repos","events_url":"https://api.github.com/users/crisptrutski/events{/privacy}","received_events_url":"https://api.github.com/users/crisptrutski/received_events","type":"User","site_admin":false},"body":"#### Overview\r\n\r\n1. Decompose `get-in` to `value` + `walk-root`\r\n2. Always close `value` channels once work is done\r\n3. Add tests for `value` and `get-in`, and an extra test for `transact` with non-primitive data\r\n4. Fix regression around `transact` behaviour on non-primitive data \r\n5. Highlight some unintuitive behaviour in tests\r\n6. DRY up `listen<` somewhat, and convert `:under_keys` to `:kebab-keys` (breaking change for `0.0.4`)\r\n\r\n@martinklepsch `(comp ..)` for the win, as discussed ;)\r\n\r\n@verma looking at https://github.com/verma/pani/blob/df8b6a0a10f3dbcc4ef1351f1336dd56a65b6715/test/pani/core_test.cljs#L107-L110, do you think we should do something about this?\r\n\r\nPossible solution:\r\n\r\nPrepend `clj->js` with a tree walking phase, turning everything besides maps, vectors, primitives and keywords-in-map-entry into edn, and append `js->clj` with a edn hydration step.\r\n\r\nAnd perhaps a dynamic variable to turn this step off for users that want to avoid the (unmeasured) overhead involved.\r\n\r\nAlso not sure if \"maps, vectors, primitives and keywords-in-map-entry\" are the full exclusion list.\r\n\r\n(also weigh in if you're against [6])","created_at":"2015-02-09T06:11:06Z","updated_at":"2015-02-11T14:09:04Z","closed_at":"2015-02-11T14:09:04Z","merged_at":"2015-02-11T14:09:04Z","merge_commit_sha":"70f7da06618c640d84befa8f8901d5b182fbfc49","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/verma/pani/pulls/28/commits","review_comments_url":"https://api.github.com/repos/verma/pani/pulls/28/comments","review_comment_url":"https://api.github.com/repos/verma/pani/pulls/comments/{number}","comments_url":"https://api.github.com/repos/verma/pani/issues/28/comments","statuses_url":"https://api.github.com/repos/verma/pani/statuses/a88f8ebb2ccc9bec5f01f98828f21f58ae1294eb","head":{"label":"verma:misc-stuff","ref":"misc-stuff","sha":"a88f8ebb2ccc9bec5f01f98828f21f58ae1294eb","user":{"login":"verma","id":242524,"avatar_url":"https://avatars.githubusercontent.com/u/242524?v=3","gravatar_id":"","url":"https://api.github.com/users/verma","html_url":"https://github.com/verma","followers_url":"https://api.github.com/users/verma/followers","following_url":"https://api.github.com/users/verma/following{/other_user}","gists_url":"https://api.github.com/users/verma/gists{/gist_id}","starred_url":"https://api.github.com/users/verma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/verma/subscriptions","organizations_url":"https://api.github.com/users/verma/orgs","repos_url":"https://api.github.com/users/verma/repos","events_url":"https://api.github.com/users/verma/events{/privacy}","received_events_url":"https://api.github.com/users/verma/received_events","type":"User","site_admin":false},"repo":{"id":21102786,"name":"pani","full_name":"verma/pani","owner":{"login":"verma","id":242524,"avatar_url":"https://avatars.githubusercontent.com/u/242524?v=3","gravatar_id":"","url":"https://api.github.com/users/verma","html_url":"https://github.com/verma","followers_url":"https://api.github.com/users/verma/followers","following_url":"https://api.github.com/users/verma/following{/other_user}","gists_url":"https://api.github.com/users/verma/gists{/gist_id}","starred_url":"https://api.github.com/users/verma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/verma/subscriptions","organizations_url":"https://api.github.com/users/verma/orgs","repos_url":"https://api.github.com/users/verma/repos","events_url":"https://api.github.com/users/verma/events{/privacy}","received_events_url":"https://api.github.com/users/verma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/verma/pani","description":"Idiomatic Clojure/ClojureScript library for Firebase","fork":false,"url":"https://api.github.com/repos/verma/pani","forks_url":"https://api.github.com/repos/verma/pani/forks","keys_url":"https://api.github.com/repos/verma/pani/keys{/key_id}","collaborators_url":"https://api.github.com/repos/verma/pani/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/verma/pani/teams","hooks_url":"https://api.github.com/repos/verma/pani/hooks","issue_events_url":"https://api.github.com/repos/verma/pani/issues/events{/number}","events_url":"https://api.github.com/repos/verma/pani/events","assignees_url":"https://api.github.com/repos/verma/pani/assignees{/user}","branches_url":"https://api.github.com/repos/verma/pani/branches{/branch}","tags_url":"https://api.github.com/repos/verma/pani/tags","blobs_url":"https://api.github.com/repos/verma/pani/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/verma/pani/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/verma/pani/git/refs{/sha}","trees_url":"https://api.github.com/repos/verma/pani/git/trees{/sha}","statuses_url":"https://api.github.com/repos/verma/pani/statuses/{sha}","languages_url":"https://api.github.com/repos/verma/pani/languages","stargazers_url":"https://api.github.com/repos/verma/pani/stargazers","contributors_url":"https://api.github.com/repos/verma/pani/contributors","subscribers_url":"https://api.github.com/repos/verma/pani/subscribers","subscription_url":"https://api.github.com/repos/verma/pani/subscription","commits_url":"https://api.github.com/repos/verma/pani/commits{/sha}","git_commits_url":"https://api.github.com/repos/verma/pani/git/commits{/sha}","comments_url":"https://api.github.com/repos/verma/pani/comments{/number}","issue_comment_url":"https://api.github.com/repos/verma/pani/issues/comments/{number}","contents_url":"https://api.github.com/repos/verma/pani/contents/{+path}","compare_url":"https://api.github.com/repos/verma/pani/compare/{base}...{head}","merges_url":"https://api.github.com/repos/verma/pani/merges","archive_url":"https://api.github.com/repos/verma/pani/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/verma/pani/downloads","issues_url":"https://api.github.com/repos/verma/pani/issues{/number}","pulls_url":"https://api.github.com/repos/verma/pani/pulls{/number}","milestones_url":"https://api.github.com/repos/verma/pani/milestones{/number}","notifications_url":"https://api.github.com/repos/verma/pani/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/verma/pani/labels{/name}","releases_url":"https://api.github.com/repos/verma/pani/releases{/id}","created_at":"2014-06-22T19:21:40Z","updated_at":"2015-02-08T23:46:06Z","pushed_at":"2015-02-11T14:09:04Z","git_url":"git://github.com/verma/pani.git","ssh_url":"git@github.com:verma/pani.git","clone_url":"https://github.com/verma/pani.git","svn_url":"https://github.com/verma/pani","homepage":"","size":515,"stargazers_count":30,"watchers_count":30,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":7,"forks":5,"open_issues":7,"watchers":30,"default_branch":"master"}},"base":{"label":"verma:master","ref":"master","sha":"f8cbdaf16b57595e01a28bab05be79288ceb2894","user":{"login":"verma","id":242524,"avatar_url":"https://avatars.githubusercontent.com/u/242524?v=3","gravatar_id":"","url":"https://api.github.com/users/verma","html_url":"https://github.com/verma","followers_url":"https://api.github.com/users/verma/followers","following_url":"https://api.github.com/users/verma/following{/other_user}","gists_url":"https://api.github.com/users/verma/gists{/gist_id}","starred_url":"https://api.github.com/users/verma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/verma/subscriptions","organizations_url":"https://api.github.com/users/verma/orgs","repos_url":"https://api.github.com/users/verma/repos","events_url":"https://api.github.com/users/verma/events{/privacy}","received_events_url":"https://api.github.com/users/verma/received_events","type":"User","site_admin":false},"repo":{"id":21102786,"name":"pani","full_name":"verma/pani","owner":{"login":"verma","id":242524,"avatar_url":"https://avatars.githubusercontent.com/u/242524?v=3","gravatar_id":"","url":"https://api.github.com/users/verma","html_url":"https://github.com/verma","followers_url":"https://api.github.com/users/verma/followers","following_url":"https://api.github.com/users/verma/following{/other_user}","gists_url":"https://api.github.com/users/verma/gists{/gist_id}","starred_url":"https://api.github.com/users/verma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/verma/subscriptions","organizations_url":"https://api.github.com/users/verma/orgs","repos_url":"https://api.github.com/users/verma/repos","events_url":"https://api.github.com/users/verma/events{/privacy}","received_events_url":"https://api.github.com/users/verma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/verma/pani","description":"Idiomatic Clojure/ClojureScript library for Firebase","fork":false,"url":"https://api.github.com/repos/verma/pani","forks_url":"https://api.github.com/repos/verma/pani/forks","keys_url":"https://api.github.com/repos/verma/pani/keys{/key_id}","collaborators_url":"https://api.github.com/repos/verma/pani/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/verma/pani/teams","hooks_url":"https://api.github.com/repos/verma/pani/hooks","issue_events_url":"https://api.github.com/repos/verma/pani/issues/events{/number}","events_url":"https://api.github.com/repos/verma/pani/events","assignees_url":"https://api.github.com/repos/verma/pani/assignees{/user}","branches_url":"https://api.github.com/repos/verma/pani/branches{/branch}","tags_url":"https://api.github.com/repos/verma/pani/tags","blobs_url":"https://api.github.com/repos/verma/pani/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/verma/pani/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/verma/pani/git/refs{/sha}","trees_url":"https://api.github.com/repos/verma/pani/git/trees{/sha}","statuses_url":"https://api.github.com/repos/verma/pani/statuses/{sha}","languages_url":"https://api.github.com/repos/verma/pani/languages","stargazers_url":"https://api.github.com/repos/verma/pani/stargazers","contributors_url":"https://api.github.com/repos/verma/pani/contributors","subscribers_url":"https://api.github.com/repos/verma/pani/subscribers","subscription_url":"https://api.github.com/repos/verma/pani/subscription","commits_url":"https://api.github.com/repos/verma/pani/commits{/sha}","git_commits_url":"https://api.github.com/repos/verma/pani/git/commits{/sha}","comments_url":"https://api.github.com/repos/verma/pani/comments{/number}","issue_comment_url":"https://api.github.com/repos/verma/pani/issues/comments/{number}","contents_url":"https://api.github.com/repos/verma/pani/contents/{+path}","compare_url":"https://api.github.com/repos/verma/pani/compare/{base}...{head}","merges_url":"https://api.github.com/repos/verma/pani/merges","archive_url":"https://api.github.com/repos/verma/pani/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/verma/pani/downloads","issues_url":"https://api.github.com/repos/verma/pani/issues{/number}","pulls_url":"https://api.github.com/repos/verma/pani/pulls{/number}","milestones_url":"https://api.github.com/repos/verma/pani/milestones{/number}","notifications_url":"https://api.github.com/repos/verma/pani/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/verma/pani/labels{/name}","releases_url":"https://api.github.com/repos/verma/pani/releases{/id}","created_at":"2014-06-22T19:21:40Z","updated_at":"2015-02-08T23:46:06Z","pushed_at":"2015-02-11T14:09:04Z","git_url":"git://github.com/verma/pani.git","ssh_url":"git@github.com:verma/pani.git","clone_url":"https://github.com/verma/pani.git","svn_url":"https://github.com/verma/pani","homepage":"","size":515,"stargazers_count":30,"watchers_count":30,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":7,"forks":5,"open_issues":7,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/verma/pani/pulls/28"},"html":{"href":"https://github.com/verma/pani/pull/28"},"issue":{"href":"https://api.github.com/repos/verma/pani/issues/28"},"comments":{"href":"https://api.github.com/repos/verma/pani/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/verma/pani/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/verma/pani/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/verma/pani/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/verma/pani/statuses/a88f8ebb2ccc9bec5f01f98828f21f58ae1294eb"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"crisptrutski","id":881351,"avatar_url":"https://avatars.githubusercontent.com/u/881351?v=3","gravatar_id":"","url":"https://api.github.com/users/crisptrutski","html_url":"https://github.com/crisptrutski","followers_url":"https://api.github.com/users/crisptrutski/followers","following_url":"https://api.github.com/users/crisptrutski/following{/other_user}","gists_url":"https://api.github.com/users/crisptrutski/gists{/gist_id}","starred_url":"https://api.github.com/users/crisptrutski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crisptrutski/subscriptions","organizations_url":"https://api.github.com/users/crisptrutski/orgs","repos_url":"https://api.github.com/users/crisptrutski/repos","events_url":"https://api.github.com/users/crisptrutski/events{/privacy}","received_events_url":"https://api.github.com/users/crisptrutski/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":3,"additions":61,"deletions":18,"changed_files":2}}