{"action":"closed","number":207,"pull_request":{"url":"https://api.github.com/repos/leapcode/bitmask_android/pulls/207","id":37179776,"html_url":"https://github.com/leapcode/bitmask_android/pull/207","diff_url":"https://github.com/leapcode/bitmask_android/pull/207.diff","patch_url":"https://github.com/leapcode/bitmask_android/pull/207.patch","issue_url":"https://api.github.com/repos/leapcode/bitmask_android/issues/207","number":207,"state":"closed","locked":false,"title":"s/buildtype/flavor, changed riseup's pin","user":{"login":"parmegv","id":818240,"avatar_url":"https://avatars.githubusercontent.com/u/818240?v=3","gravatar_id":"","url":"https://api.github.com/users/parmegv","html_url":"https://github.com/parmegv","followers_url":"https://api.github.com/users/parmegv/followers","following_url":"https://api.github.com/users/parmegv/following{/other_user}","gists_url":"https://api.github.com/users/parmegv/gists{/gist_id}","starred_url":"https://api.github.com/users/parmegv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parmegv/subscriptions","organizations_url":"https://api.github.com/users/parmegv/orgs","repos_url":"https://api.github.com/users/parmegv/repos","events_url":"https://api.github.com/users/parmegv/events{/privacy}","received_events_url":"https://api.github.com/users/parmegv/received_events","type":"User","site_admin":false},"body":"Riseup's EE certificate expired (EE = End-Entity, the commercial\r\ncertificate signed by the issuer), and we weren't able to fetch\r\nprovider.json because the pin wasn't valid.\r\n\r\nThis problem needs to be avoided in the future, using\r\nHKPK (https://tools.ietf.org/html/rfc7469), which Micah's implementing\r\non Riseup.\r\n\r\nSwitching from build types from flavors enables us to run tests against\r\nproduction apk, not just debug. I didn't detect this pinning problem\r\nbecause tests were run only against the debug apk, which trusted\r\npreseeded providers by default (thus bypassing pinning issue).","created_at":"2015-06-08T18:04:25Z","updated_at":"2015-06-08T18:05:08Z","closed_at":"2015-06-08T18:05:08Z","merged_at":"2015-06-08T18:05:08Z","merge_commit_sha":"8240275ef3892279b067fedc6f9b3a949f0211f8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/leapcode/bitmask_android/pulls/207/commits","review_comments_url":"https://api.github.com/repos/leapcode/bitmask_android/pulls/207/comments","review_comment_url":"https://api.github.com/repos/leapcode/bitmask_android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/leapcode/bitmask_android/issues/207/comments","statuses_url":"https://api.github.com/repos/leapcode/bitmask_android/statuses/b0a0805ab81aaa4e204ecfc77d3a6a7f7ed66b2f","head":{"label":"parmegv:bug/Riseup-provider-fails-to-get-configured-#7113","ref":"bug/Riseup-provider-fails-to-get-configured-#7113","sha":"b0a0805ab81aaa4e204ecfc77d3a6a7f7ed66b2f","user":{"login":"parmegv","id":818240,"avatar_url":"https://avatars.githubusercontent.com/u/818240?v=3","gravatar_id":"","url":"https://api.github.com/users/parmegv","html_url":"https://github.com/parmegv","followers_url":"https://api.github.com/users/parmegv/followers","following_url":"https://api.github.com/users/parmegv/following{/other_user}","gists_url":"https://api.github.com/users/parmegv/gists{/gist_id}","starred_url":"https://api.github.com/users/parmegv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parmegv/subscriptions","organizations_url":"https://api.github.com/users/parmegv/orgs","repos_url":"https://api.github.com/users/parmegv/repos","events_url":"https://api.github.com/users/parmegv/events{/privacy}","received_events_url":"https://api.github.com/users/parmegv/received_events","type":"User","site_admin":false},"repo":{"id":9776256,"name":"bitmask_android","full_name":"parmegv/bitmask_android","owner":{"login":"parmegv","id":818240,"avatar_url":"https://avatars.githubusercontent.com/u/818240?v=3","gravatar_id":"","url":"https://api.github.com/users/parmegv","html_url":"https://github.com/parmegv","followers_url":"https://api.github.com/users/parmegv/followers","following_url":"https://api.github.com/users/parmegv/following{/other_user}","gists_url":"https://api.github.com/users/parmegv/gists{/gist_id}","starred_url":"https://api.github.com/users/parmegv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parmegv/subscriptions","organizations_url":"https://api.github.com/users/parmegv/orgs","repos_url":"https://api.github.com/users/parmegv/repos","events_url":"https://api.github.com/users/parmegv/events{/privacy}","received_events_url":"https://api.github.com/users/parmegv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/parmegv/bitmask_android","description":"Bitmask client for android","fork":true,"url":"https://api.github.com/repos/parmegv/bitmask_android","forks_url":"https://api.github.com/repos/parmegv/bitmask_android/forks","keys_url":"https://api.github.com/repos/parmegv/bitmask_android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/parmegv/bitmask_android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/parmegv/bitmask_android/teams","hooks_url":"https://api.github.com/repos/parmegv/bitmask_android/hooks","issue_events_url":"https://api.github.com/repos/parmegv/bitmask_android/issues/events{/number}","events_url":"https://api.github.com/repos/parmegv/bitmask_android/events","assignees_url":"https://api.github.com/repos/parmegv/bitmask_android/assignees{/user}","branches_url":"https://api.github.com/repos/parmegv/bitmask_android/branches{/branch}","tags_url":"https://api.github.com/repos/parmegv/bitmask_android/tags","blobs_url":"https://api.github.com/repos/parmegv/bitmask_android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/parmegv/bitmask_android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/parmegv/bitmask_android/git/refs{/sha}","trees_url":"https://api.github.com/repos/parmegv/bitmask_android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/parmegv/bitmask_android/statuses/{sha}","languages_url":"https://api.github.com/repos/parmegv/bitmask_android/languages","stargazers_url":"https://api.github.com/repos/parmegv/bitmask_android/stargazers","contributors_url":"https://api.github.com/repos/parmegv/bitmask_android/contributors","subscribers_url":"https://api.github.com/repos/parmegv/bitmask_android/subscribers","subscription_url":"https://api.github.com/repos/parmegv/bitmask_android/subscription","commits_url":"https://api.github.com/repos/parmegv/bitmask_android/commits{/sha}","git_commits_url":"https://api.github.com/repos/parmegv/bitmask_android/git/commits{/sha}","comments_url":"https://api.github.com/repos/parmegv/bitmask_android/comments{/number}","issue_comment_url":"https://api.github.com/repos/parmegv/bitmask_android/issues/comments{/number}","contents_url":"https://api.github.com/repos/parmegv/bitmask_android/contents/{+path}","compare_url":"https://api.github.com/repos/parmegv/bitmask_android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/parmegv/bitmask_android/merges","archive_url":"https://api.github.com/repos/parmegv/bitmask_android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/parmegv/bitmask_android/downloads","issues_url":"https://api.github.com/repos/parmegv/bitmask_android/issues{/number}","pulls_url":"https://api.github.com/repos/parmegv/bitmask_android/pulls{/number}","milestones_url":"https://api.github.com/repos/parmegv/bitmask_android/milestones{/number}","notifications_url":"https://api.github.com/repos/parmegv/bitmask_android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/parmegv/bitmask_android/labels{/name}","releases_url":"https://api.github.com/repos/parmegv/bitmask_android/releases{/id}","created_at":"2013-04-30T17:33:58Z","updated_at":"2015-06-04T22:05:11Z","pushed_at":"2015-06-08T18:04:53Z","git_url":"git://github.com/parmegv/bitmask_android.git","ssh_url":"git@github.com:parmegv/bitmask_android.git","clone_url":"https://github.com/parmegv/bitmask_android.git","svn_url":"https://github.com/parmegv/bitmask_android","homepage":"","size":76831,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"leapcode:develop","ref":"develop","sha":"8d39fbdb4980c95268249f21f3c6b8e36b22cf90","user":{"login":"leapcode","id":1700464,"avatar_url":"https://avatars.githubusercontent.com/u/1700464?v=3","gravatar_id":"","url":"https://api.github.com/users/leapcode","html_url":"https://github.com/leapcode","followers_url":"https://api.github.com/users/leapcode/followers","following_url":"https://api.github.com/users/leapcode/following{/other_user}","gists_url":"https://api.github.com/users/leapcode/gists{/gist_id}","starred_url":"https://api.github.com/users/leapcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leapcode/subscriptions","organizations_url":"https://api.github.com/users/leapcode/orgs","repos_url":"https://api.github.com/users/leapcode/repos","events_url":"https://api.github.com/users/leapcode/events{/privacy}","received_events_url":"https://api.github.com/users/leapcode/received_events","type":"Organization","site_admin":false},"repo":{"id":9706311,"name":"bitmask_android","full_name":"leapcode/bitmask_android","owner":{"login":"leapcode","id":1700464,"avatar_url":"https://avatars.githubusercontent.com/u/1700464?v=3","gravatar_id":"","url":"https://api.github.com/users/leapcode","html_url":"https://github.com/leapcode","followers_url":"https://api.github.com/users/leapcode/followers","following_url":"https://api.github.com/users/leapcode/following{/other_user}","gists_url":"https://api.github.com/users/leapcode/gists{/gist_id}","starred_url":"https://api.github.com/users/leapcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leapcode/subscriptions","organizations_url":"https://api.github.com/users/leapcode/orgs","repos_url":"https://api.github.com/users/leapcode/repos","events_url":"https://api.github.com/users/leapcode/events{/privacy}","received_events_url":"https://api.github.com/users/leapcode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/leapcode/bitmask_android","description":"LEAP client for android","fork":false,"url":"https://api.github.com/repos/leapcode/bitmask_android","forks_url":"https://api.github.com/repos/leapcode/bitmask_android/forks","keys_url":"https://api.github.com/repos/leapcode/bitmask_android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leapcode/bitmask_android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leapcode/bitmask_android/teams","hooks_url":"https://api.github.com/repos/leapcode/bitmask_android/hooks","issue_events_url":"https://api.github.com/repos/leapcode/bitmask_android/issues/events{/number}","events_url":"https://api.github.com/repos/leapcode/bitmask_android/events","assignees_url":"https://api.github.com/repos/leapcode/bitmask_android/assignees{/user}","branches_url":"https://api.github.com/repos/leapcode/bitmask_android/branches{/branch}","tags_url":"https://api.github.com/repos/leapcode/bitmask_android/tags","blobs_url":"https://api.github.com/repos/leapcode/bitmask_android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leapcode/bitmask_android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leapcode/bitmask_android/git/refs{/sha}","trees_url":"https://api.github.com/repos/leapcode/bitmask_android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leapcode/bitmask_android/statuses/{sha}","languages_url":"https://api.github.com/repos/leapcode/bitmask_android/languages","stargazers_url":"https://api.github.com/repos/leapcode/bitmask_android/stargazers","contributors_url":"https://api.github.com/repos/leapcode/bitmask_android/contributors","subscribers_url":"https://api.github.com/repos/leapcode/bitmask_android/subscribers","subscription_url":"https://api.github.com/repos/leapcode/bitmask_android/subscription","commits_url":"https://api.github.com/repos/leapcode/bitmask_android/commits{/sha}","git_commits_url":"https://api.github.com/repos/leapcode/bitmask_android/git/commits{/sha}","comments_url":"https://api.github.com/repos/leapcode/bitmask_android/comments{/number}","issue_comment_url":"https://api.github.com/repos/leapcode/bitmask_android/issues/comments{/number}","contents_url":"https://api.github.com/repos/leapcode/bitmask_android/contents/{+path}","compare_url":"https://api.github.com/repos/leapcode/bitmask_android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leapcode/bitmask_android/merges","archive_url":"https://api.github.com/repos/leapcode/bitmask_android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leapcode/bitmask_android/downloads","issues_url":"https://api.github.com/repos/leapcode/bitmask_android/issues{/number}","pulls_url":"https://api.github.com/repos/leapcode/bitmask_android/pulls{/number}","milestones_url":"https://api.github.com/repos/leapcode/bitmask_android/milestones{/number}","notifications_url":"https://api.github.com/repos/leapcode/bitmask_android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leapcode/bitmask_android/labels{/name}","releases_url":"https://api.github.com/repos/leapcode/bitmask_android/releases{/id}","created_at":"2013-04-26T23:44:38Z","updated_at":"2015-06-04T22:04:56Z","pushed_at":"2015-06-08T18:05:08Z","git_url":"git://github.com/leapcode/bitmask_android.git","ssh_url":"git@github.com:leapcode/bitmask_android.git","clone_url":"https://github.com/leapcode/bitmask_android.git","svn_url":"https://github.com/leapcode/bitmask_android","homepage":null,"size":24539,"stargazers_count":24,"watchers_count":24,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":11,"forks":14,"open_issues":11,"watchers":24,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/leapcode/bitmask_android/pulls/207"},"html":{"href":"https://github.com/leapcode/bitmask_android/pull/207"},"issue":{"href":"https://api.github.com/repos/leapcode/bitmask_android/issues/207"},"comments":{"href":"https://api.github.com/repos/leapcode/bitmask_android/issues/207/comments"},"review_comments":{"href":"https://api.github.com/repos/leapcode/bitmask_android/pulls/207/comments"},"review_comment":{"href":"https://api.github.com/repos/leapcode/bitmask_android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/leapcode/bitmask_android/pulls/207/commits"},"statuses":{"href":"https://api.github.com/repos/leapcode/bitmask_android/statuses/b0a0805ab81aaa4e204ecfc77d3a6a7f7ed66b2f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"leap-code-o-matic","id":3003406,"avatar_url":"https://avatars.githubusercontent.com/u/3003406?v=3","gravatar_id":"","url":"https://api.github.com/users/leap-code-o-matic","html_url":"https://github.com/leap-code-o-matic","followers_url":"https://api.github.com/users/leap-code-o-matic/followers","following_url":"https://api.github.com/users/leap-code-o-matic/following{/other_user}","gists_url":"https://api.github.com/users/leap-code-o-matic/gists{/gist_id}","starred_url":"https://api.github.com/users/leap-code-o-matic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leap-code-o-matic/subscriptions","organizations_url":"https://api.github.com/users/leap-code-o-matic/orgs","repos_url":"https://api.github.com/users/leap-code-o-matic/repos","events_url":"https://api.github.com/users/leap-code-o-matic/events{/privacy}","received_events_url":"https://api.github.com/users/leap-code-o-matic/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":424,"deletions":401,"changed_files":22}}