{"action":"created","comment":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/38557901","id":38557901,"diff_hunk":"@@ -9,7 +9,7 @@ namespace Dynamo.Utilities\n     /// </summary>\n     /// <typeparam name=\"T\"></typeparam>\n     /// <typeparam name=\"TKey\"></typeparam>\n-    internal class LinkedListOfList<TKey, T> : IEnumerable<List<T>>\n+    public class LinkedListOfList<TKey, T> : IEnumerable<List<T>>","path":"src/DynamoCore/Engine/LinkedListOfList.cs","position":14,"original_position":14,"commit_id":"a4d85c837010f9ea12112e6993f7102fd06096ad","original_commit_id":"a4d85c837010f9ea12112e6993f7102fd06096ad","user":{"login":"pboyer","id":916345,"avatar_url":"https://avatars.githubusercontent.com/u/916345?v=3","gravatar_id":"","url":"https://api.github.com/users/pboyer","html_url":"https://github.com/pboyer","followers_url":"https://api.github.com/users/pboyer/followers","following_url":"https://api.github.com/users/pboyer/following{/other_user}","gists_url":"https://api.github.com/users/pboyer/gists{/gist_id}","starred_url":"https://api.github.com/users/pboyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pboyer/subscriptions","organizations_url":"https://api.github.com/users/pboyer/orgs","repos_url":"https://api.github.com/users/pboyer/repos","events_url":"https://api.github.com/users/pboyer/events{/privacy}","received_events_url":"https://api.github.com/users/pboyer/received_events","type":"User","site_admin":false},"body":"`public`?","created_at":"2015-09-02T17:08:38Z","updated_at":"2015-09-02T17:08:38Z","html_url":"https://github.com/DynamoDS/Dynamo/pull/5195#discussion_r38557901","pull_request_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5195","_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/38557901"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/5195#discussion_r38557901"},"pull_request":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5195"}}},"pull_request":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5195","id":43572815,"html_url":"https://github.com/DynamoDS/Dynamo/pull/5195","diff_url":"https://github.com/DynamoDS/Dynamo/pull/5195.diff","patch_url":"https://github.com/DynamoDS/Dynamo/pull/5195.patch","issue_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/5195","number":5195,"state":"open","locked":false,"title":"MAGN-8200 Hide methods and properties in DynamoCore.dll which should not be exposed via the API.","user":{"login":"ikeough","id":1139788,"avatar_url":"https://avatars.githubusercontent.com/u/1139788?v=3","gravatar_id":"","url":"https://api.github.com/users/ikeough","html_url":"https://github.com/ikeough","followers_url":"https://api.github.com/users/ikeough/followers","following_url":"https://api.github.com/users/ikeough/following{/other_user}","gists_url":"https://api.github.com/users/ikeough/gists{/gist_id}","starred_url":"https://api.github.com/users/ikeough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikeough/subscriptions","organizations_url":"https://api.github.com/users/ikeough/orgs","repos_url":"https://api.github.com/users/ikeough/repos","events_url":"https://api.github.com/users/ikeough/events{/privacy}","received_events_url":"https://api.github.com/users/ikeough/received_events","type":"User","site_admin":false},"body":"\r\n### Purpose\r\n\r\nThis PR represents [MAGN-8200](http://adsk-oss.myjetbrains.com/youtrack/issue/MAGN-8200#tab=Comments) and does the following to DynamoCore:\r\n\r\n- Mark any classes that are currently only used within the core solution's projects as internal. Add `InternalsVisibleTo` to `AssemblyInfo.cs`, where appropriate to expose these classes for testing, our node libraries, etc..\r\n- Move classes in `Dynamo.Utilities` namespace inside `DynamoCore` to the `DynamoUtilities` project, and rename classes as necessary, to avoid clashes. \r\n- Move classes as close to their usage as possible. Ex. if a type is only used in one place, move it into the namespace where it is used. These types should not be stuck in `Dynamo.Utilities` just because we think they might be useful in the future.\r\n\r\n### Impact assessment\r\n\r\n- [x] Changes the way 3rd party nodes work (Add ikeough to the reviewer list)\r\n- [ ] Includes migrations (Add ikeough to the reviewer list)\r\n- [x] Changes a public interface (Add lukechurch to the reviewer list)\r\n- [ ] Affects which components of the system depends on which other components (Add pboyer to the reviewer list)\r\n- [ ] Introduces new components (Add lukechurch to the reviewer list)\r\n- [ ] Has a performance impact (Add keyu to the reviewer list)\r\n- [ ] Changes the installer (Add sharadkjaiswal to the reviewer list)\r\n- [ ] User facing strings, if any, are extracted into `*.resx` files\r\n\r\n#### Testing strategy\r\n\r\n(FILL ME IN) This section describes how this feature is going to be tested, and what the state of the tests are expected to be upon merging.\r\nIf there is a requirement for repeated manual testing, then add lukechurch to the reviewers list.\r\n\r\n### Review staging\r\n\r\n- [ ] Architectural Design Review\r\n- [ ] UI Review\r\n\r\n### Reviewers\r\n@pboyer @lukechurch \r\n\r\n#### Associated PRs which require review:\r\nhttps://github.com/DynamoDS/Reach/pull/63\r\nhttps://github.com/DynamoDS/DynamoRevit/pull/624  ","created_at":"2015-08-27T22:08:01Z","updated_at":"2015-09-02T17:08:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3288388ec32fb5d0671fc75db420988f5e979e7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5195/commits","review_comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5195/comments","review_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/5195/comments","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/a4d85c837010f9ea12112e6993f7102fd06096ad","head":{"label":"ikeough:MAGN-8200","ref":"MAGN-8200","sha":"a4d85c837010f9ea12112e6993f7102fd06096ad","user":{"login":"ikeough","id":1139788,"avatar_url":"https://avatars.githubusercontent.com/u/1139788?v=3","gravatar_id":"","url":"https://api.github.com/users/ikeough","html_url":"https://github.com/ikeough","followers_url":"https://api.github.com/users/ikeough/followers","following_url":"https://api.github.com/users/ikeough/following{/other_user}","gists_url":"https://api.github.com/users/ikeough/gists{/gist_id}","starred_url":"https://api.github.com/users/ikeough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikeough/subscriptions","organizations_url":"https://api.github.com/users/ikeough/orgs","repos_url":"https://api.github.com/users/ikeough/repos","events_url":"https://api.github.com/users/ikeough/events{/privacy}","received_events_url":"https://api.github.com/users/ikeough/received_events","type":"User","site_admin":false},"repo":{"id":37068216,"name":"Dynamo","full_name":"ikeough/Dynamo","owner":{"login":"ikeough","id":1139788,"avatar_url":"https://avatars.githubusercontent.com/u/1139788?v=3","gravatar_id":"","url":"https://api.github.com/users/ikeough","html_url":"https://github.com/ikeough","followers_url":"https://api.github.com/users/ikeough/followers","following_url":"https://api.github.com/users/ikeough/following{/other_user}","gists_url":"https://api.github.com/users/ikeough/gists{/gist_id}","starred_url":"https://api.github.com/users/ikeough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikeough/subscriptions","organizations_url":"https://api.github.com/users/ikeough/orgs","repos_url":"https://api.github.com/users/ikeough/repos","events_url":"https://api.github.com/users/ikeough/events{/privacy}","received_events_url":"https://api.github.com/users/ikeough/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ikeough/Dynamo","description":"Visual Programming","fork":true,"url":"https://api.github.com/repos/ikeough/Dynamo","forks_url":"https://api.github.com/repos/ikeough/Dynamo/forks","keys_url":"https://api.github.com/repos/ikeough/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ikeough/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ikeough/Dynamo/teams","hooks_url":"https://api.github.com/repos/ikeough/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/ikeough/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/ikeough/Dynamo/events","assignees_url":"https://api.github.com/repos/ikeough/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/ikeough/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/ikeough/Dynamo/tags","blobs_url":"https://api.github.com/repos/ikeough/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ikeough/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ikeough/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/ikeough/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ikeough/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/ikeough/Dynamo/languages","stargazers_url":"https://api.github.com/repos/ikeough/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/ikeough/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/ikeough/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/ikeough/Dynamo/subscription","commits_url":"https://api.github.com/repos/ikeough/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/ikeough/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/ikeough/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/ikeough/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/ikeough/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/ikeough/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ikeough/Dynamo/merges","archive_url":"https://api.github.com/repos/ikeough/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ikeough/Dynamo/downloads","issues_url":"https://api.github.com/repos/ikeough/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/ikeough/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/ikeough/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/ikeough/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ikeough/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/ikeough/Dynamo/releases{/id}","created_at":"2015-06-08T13:21:59Z","updated_at":"2015-08-04T20:52:36Z","pushed_at":"2015-09-02T16:45:33Z","git_url":"git://github.com/ikeough/Dynamo.git","ssh_url":"git@github.com:ikeough/Dynamo.git","clone_url":"https://github.com/ikeough/Dynamo.git","svn_url":"https://github.com/ikeough/Dynamo","homepage":"http://dynamobim.org","size":799593,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"DynamoDS:master","ref":"master","sha":"8aeb9eedc501a54f7c88c87004354347bcfffead","user":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"repo":{"id":3395179,"name":"Dynamo","full_name":"DynamoDS/Dynamo","owner":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DynamoDS/Dynamo","description":"Visual Programming","fork":false,"url":"https://api.github.com/repos/DynamoDS/Dynamo","forks_url":"https://api.github.com/repos/DynamoDS/Dynamo/forks","keys_url":"https://api.github.com/repos/DynamoDS/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DynamoDS/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DynamoDS/Dynamo/teams","hooks_url":"https://api.github.com/repos/DynamoDS/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/DynamoDS/Dynamo/events","assignees_url":"https://api.github.com/repos/DynamoDS/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/DynamoDS/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/tags","blobs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/DynamoDS/Dynamo/languages","stargazers_url":"https://api.github.com/repos/DynamoDS/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/DynamoDS/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscription","commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/DynamoDS/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/DynamoDS/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DynamoDS/Dynamo/merges","archive_url":"https://api.github.com/repos/DynamoDS/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DynamoDS/Dynamo/downloads","issues_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/DynamoDS/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/DynamoDS/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DynamoDS/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/DynamoDS/Dynamo/releases{/id}","created_at":"2012-02-09T07:35:33Z","updated_at":"2015-09-01T09:38:18Z","pushed_at":"2015-09-02T16:48:03Z","git_url":"git://github.com/DynamoDS/Dynamo.git","ssh_url":"git@github.com:DynamoDS/Dynamo.git","clone_url":"https://github.com/DynamoDS/Dynamo.git","svn_url":"https://github.com/DynamoDS/Dynamo","homepage":"http://dynamobim.org","size":1025535,"stargazers_count":254,"watchers_count":254,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":197,"mirror_url":null,"open_issues_count":726,"forks":197,"open_issues":726,"watchers":254,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5195"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/5195"},"issue":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/5195"},"comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/5195/comments"},"review_comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5195/comments"},"review_comment":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5195/commits"},"statuses":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/a4d85c837010f9ea12112e6993f7102fd06096ad"}}}}