{"action":"opened","number":155,"pull_request":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/155","id":33100546,"html_url":"https://github.com/apache/cloudstack/pull/155","diff_url":"https://github.com/apache/cloudstack/pull/155.diff","patch_url":"https://github.com/apache/cloudstack/pull/155.patch","issue_url":"https://api.github.com/repos/apache/cloudstack/issues/155","number":155,"state":"open","locked":false,"title":"CLOUDSTACK-8375: Marvin - Code Improvement  - Verifying VCenter port groups corresponding to traffic types in a zone","user":{"login":"gauravaradhye","id":4161170,"avatar_url":"https://avatars.githubusercontent.com/u/4161170?v=3","gravatar_id":"","url":"https://api.github.com/users/gauravaradhye","html_url":"https://github.com/gauravaradhye","followers_url":"https://api.github.com/users/gauravaradhye/followers","following_url":"https://api.github.com/users/gauravaradhye/following{/other_user}","gists_url":"https://api.github.com/users/gauravaradhye/gists{/gist_id}","starred_url":"https://api.github.com/users/gauravaradhye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gauravaradhye/subscriptions","organizations_url":"https://api.github.com/users/gauravaradhye/orgs","repos_url":"https://api.github.com/users/gauravaradhye/repos","events_url":"https://api.github.com/users/gauravaradhye/events{/privacy}","received_events_url":"https://api.github.com/users/gauravaradhye/received_events","type":"User","site_admin":false},"body":"1. Reducing complexity of function \"verifyVCenterPortGroups\". Earlier it had two for loops, now it has only one. The parameter zone_list has been replaced with \"zone\" because we map a VCenter to a zone and not multiple zones.\r\n\r\n2. Correcting the logic used to generate expected port group names for public traffic. The port group with network rate as defined in \"network.throttling.rate\" is created only when a VM is deployed and its network uses a public IP from public IP range dedicated to public traffic.\r\n\r\n3. Adding a wrapper function for verifying guest traffic port groups which creates vcenter connection object and calls verifyVCenterPortGroups function with GUEST_TRAFFIC as parameter. This function is very handy and can be called from any networking test case with only a single line call. This separates the additional logic from test case and moves it to this wrapper function.\r\n\r\n\r\nThe code has been tested against multiple types of Vmware deployments including mixture tagged and untagged traffic types and mixed switches (SVS and DVS).","created_at":"2015-04-11T09:16:53Z","updated_at":"2015-04-11T09:16:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/cloudstack/pulls/155/commits","review_comments_url":"https://api.github.com/repos/apache/cloudstack/pulls/155/comments","review_comment_url":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/cloudstack/issues/155/comments","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/1159089ca51ac44d41e565a2e0356741fe06b8ac","head":{"label":"gauravaradhye:8375","ref":"8375","sha":"1159089ca51ac44d41e565a2e0356741fe06b8ac","user":{"login":"gauravaradhye","id":4161170,"avatar_url":"https://avatars.githubusercontent.com/u/4161170?v=3","gravatar_id":"","url":"https://api.github.com/users/gauravaradhye","html_url":"https://github.com/gauravaradhye","followers_url":"https://api.github.com/users/gauravaradhye/followers","following_url":"https://api.github.com/users/gauravaradhye/following{/other_user}","gists_url":"https://api.github.com/users/gauravaradhye/gists{/gist_id}","starred_url":"https://api.github.com/users/gauravaradhye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gauravaradhye/subscriptions","organizations_url":"https://api.github.com/users/gauravaradhye/orgs","repos_url":"https://api.github.com/users/gauravaradhye/repos","events_url":"https://api.github.com/users/gauravaradhye/events{/privacy}","received_events_url":"https://api.github.com/users/gauravaradhye/received_events","type":"User","site_admin":false},"repo":{"id":31648314,"name":"cloudstack","full_name":"gauravaradhye/cloudstack","owner":{"login":"gauravaradhye","id":4161170,"avatar_url":"https://avatars.githubusercontent.com/u/4161170?v=3","gravatar_id":"","url":"https://api.github.com/users/gauravaradhye","html_url":"https://github.com/gauravaradhye","followers_url":"https://api.github.com/users/gauravaradhye/followers","following_url":"https://api.github.com/users/gauravaradhye/following{/other_user}","gists_url":"https://api.github.com/users/gauravaradhye/gists{/gist_id}","starred_url":"https://api.github.com/users/gauravaradhye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gauravaradhye/subscriptions","organizations_url":"https://api.github.com/users/gauravaradhye/orgs","repos_url":"https://api.github.com/users/gauravaradhye/repos","events_url":"https://api.github.com/users/gauravaradhye/events{/privacy}","received_events_url":"https://api.github.com/users/gauravaradhye/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gauravaradhye/cloudstack","description":"Mirror of Apache Cloudstack","fork":true,"url":"https://api.github.com/repos/gauravaradhye/cloudstack","forks_url":"https://api.github.com/repos/gauravaradhye/cloudstack/forks","keys_url":"https://api.github.com/repos/gauravaradhye/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gauravaradhye/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gauravaradhye/cloudstack/teams","hooks_url":"https://api.github.com/repos/gauravaradhye/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/gauravaradhye/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/gauravaradhye/cloudstack/events","assignees_url":"https://api.github.com/repos/gauravaradhye/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/gauravaradhye/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/gauravaradhye/cloudstack/tags","blobs_url":"https://api.github.com/repos/gauravaradhye/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gauravaradhye/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gauravaradhye/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/gauravaradhye/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gauravaradhye/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/gauravaradhye/cloudstack/languages","stargazers_url":"https://api.github.com/repos/gauravaradhye/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/gauravaradhye/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/gauravaradhye/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/gauravaradhye/cloudstack/subscription","commits_url":"https://api.github.com/repos/gauravaradhye/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/gauravaradhye/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/gauravaradhye/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/gauravaradhye/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/gauravaradhye/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/gauravaradhye/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gauravaradhye/cloudstack/merges","archive_url":"https://api.github.com/repos/gauravaradhye/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gauravaradhye/cloudstack/downloads","issues_url":"https://api.github.com/repos/gauravaradhye/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/gauravaradhye/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/gauravaradhye/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/gauravaradhye/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gauravaradhye/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/gauravaradhye/cloudstack/releases{/id}","created_at":"2015-03-04T09:18:12Z","updated_at":"2015-03-12T12:38:51Z","pushed_at":"2015-04-11T09:08:07Z","git_url":"git://github.com/gauravaradhye/cloudstack.git","ssh_url":"git@github.com:gauravaradhye/cloudstack.git","clone_url":"https://github.com/gauravaradhye/cloudstack.git","svn_url":"https://github.com/gauravaradhye/cloudstack","homepage":null,"size":478977,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"da233c7bf180dac3f8e940e90c232642e2ab06c1","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":9759448,"name":"cloudstack","full_name":"apache/cloudstack","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/cloudstack","description":"Mirror of Apache Cloudstack","fork":false,"url":"https://api.github.com/repos/apache/cloudstack","forks_url":"https://api.github.com/repos/apache/cloudstack/forks","keys_url":"https://api.github.com/repos/apache/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/cloudstack/teams","hooks_url":"https://api.github.com/repos/apache/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/apache/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/apache/cloudstack/events","assignees_url":"https://api.github.com/repos/apache/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/apache/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/apache/cloudstack/tags","blobs_url":"https://api.github.com/repos/apache/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/cloudstack/languages","stargazers_url":"https://api.github.com/repos/apache/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/apache/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/apache/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/apache/cloudstack/subscription","commits_url":"https://api.github.com/repos/apache/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/apache/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/cloudstack/merges","archive_url":"https://api.github.com/repos/apache/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/cloudstack/downloads","issues_url":"https://api.github.com/repos/apache/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/apache/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/apache/cloudstack/releases{/id}","created_at":"2013-04-29T22:27:12Z","updated_at":"2015-04-10T20:09:11Z","pushed_at":"2015-04-11T09:16:53Z","git_url":"git://github.com/apache/cloudstack.git","ssh_url":"git@github.com:apache/cloudstack.git","clone_url":"https://github.com/apache/cloudstack.git","svn_url":"https://github.com/apache/cloudstack","homepage":null,"size":720844,"stargazers_count":232,"watchers_count":232,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":266,"mirror_url":"git://git.apache.org/cloudstack.git","open_issues_count":8,"forks":266,"open_issues":8,"watchers":232,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/155"},"html":{"href":"https://github.com/apache/cloudstack/pull/155"},"issue":{"href":"https://api.github.com/repos/apache/cloudstack/issues/155"},"comments":{"href":"https://api.github.com/repos/apache/cloudstack/issues/155/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/155/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/155/commits"},"statuses":{"href":"https://api.github.com/repos/apache/cloudstack/statuses/1159089ca51ac44d41e565a2e0356741fe06b8ac"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":108,"deletions":36,"changed_files":2}}