{"action":"created","issue":{"url":"https://api.github.com/repos/daviferreira/medium-editor/issues/631","labels_url":"https://api.github.com/repos/daviferreira/medium-editor/issues/631/labels{/name}","comments_url":"https://api.github.com/repos/daviferreira/medium-editor/issues/631/comments","events_url":"https://api.github.com/repos/daviferreira/medium-editor/issues/631/events","html_url":"https://github.com/daviferreira/medium-editor/pull/631","id":79995336,"number":631,"title":"Deprecate .parent property of extensions","user":{"login":"nmielnik","id":2444240,"avatar_url":"https://avatars.githubusercontent.com/u/2444240?v=3","gravatar_id":"","url":"https://api.github.com/users/nmielnik","html_url":"https://github.com/nmielnik","followers_url":"https://api.github.com/users/nmielnik/followers","following_url":"https://api.github.com/users/nmielnik/following{/other_user}","gists_url":"https://api.github.com/users/nmielnik/gists{/gist_id}","starred_url":"https://api.github.com/users/nmielnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmielnik/subscriptions","organizations_url":"https://api.github.com/users/nmielnik/orgs","repos_url":"https://api.github.com/users/nmielnik/repos","events_url":"https://api.github.com/users/nmielnik/events{/privacy}","received_events_url":"https://api.github.com/users/nmielnik/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-24T00:17:39Z","updated_at":"2015-05-24T00:19:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/daviferreira/medium-editor/pulls/631","html_url":"https://github.com/daviferreira/medium-editor/pull/631","diff_url":"https://github.com/daviferreira/medium-editor/pull/631.diff","patch_url":"https://github.com/daviferreira/medium-editor/pull/631.patch"},"body":"This PR deprecates the `.parent` property for extensions.  Now, all extensions will have their `.base` property set to the instance of MediumEditor they are initialized as part of (unless they already have `.base` set to something else or they have the deprecated `.parent` property set to `false`, but this will only be supported until v5.0.0)\r\n\r\nHow `.parent` and `.base` work:\r\n\r\n* BEFORE this PR\r\n  * ONLY IF `.parent` property of an Extension is `true`, MediumEditor sets `.base` to be a reference to itself (MediumEditor)\r\n* AFTER this PR (but before v5.0.0)\r\n  * IF `.parent` property of an Extension is explicitly `false` OR if `.base` property of an Extension is already set to something, MediumEditor will NOT set `.base` property to be a reference to itself (MediumEditor)\r\n  * For all other cases, MediumEditor will set the `.base` property of all Extensions to be a reference to itself (MediumEditor)\r\n  * This will NOT be completely backwards compatible in all cases, since some extensions will now have a `.base` property when they didn't before.  However, since we won't override if it it already exists, this should be good enough to not break existing extensions.\r\n* AFTER v5.0.0\r\n  * All Extensions will have their `.base` property set to an instance of MediumEditor, unless they override the `.base` property to something else before initializing MediumEditor."},"comment":{"url":"https://api.github.com/repos/daviferreira/medium-editor/issues/comments/104960581","html_url":"https://github.com/daviferreira/medium-editor/pull/631#issuecomment-104960581","issue_url":"https://api.github.com/repos/daviferreira/medium-editor/issues/631","id":104960581,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2015-05-24T00:19:05Z","updated_at":"2015-05-24T00:19:05Z","body":"\n[![Coverage Status](https://coveralls.io/builds/2636459/badge)](https://coveralls.io/builds/2636459)\n\nCoverage increased (+0.0%) to 94.85% when pulling **78709a97405031ac3d94754fa398ba9d80da1e6c on extension-helpers** into **149dde73d942658cf1bd1bb348884f7f5d8d55ae on master**.\n"}}