{"action":"created","issue":{"url":"https://api.github.com/repos/neillturner/kitchen-puppet/issues/68","labels_url":"https://api.github.com/repos/neillturner/kitchen-puppet/issues/68/labels{/name}","comments_url":"https://api.github.com/repos/neillturner/kitchen-puppet/issues/68/comments","events_url":"https://api.github.com/repos/neillturner/kitchen-puppet/issues/68/events","html_url":"https://github.com/neillturner/kitchen-puppet/pull/68","id":104958423,"number":68,"title":"Fix Apt Repo Settings","user":{"login":"grubernaut","id":3082319,"avatar_url":"https://avatars.githubusercontent.com/u/3082319?v=3","gravatar_id":"","url":"https://api.github.com/users/grubernaut","html_url":"https://github.com/grubernaut","followers_url":"https://api.github.com/users/grubernaut/followers","following_url":"https://api.github.com/users/grubernaut/following{/other_user}","gists_url":"https://api.github.com/users/grubernaut/gists{/gist_id}","starred_url":"https://api.github.com/users/grubernaut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grubernaut/subscriptions","organizations_url":"https://api.github.com/users/grubernaut/orgs","repos_url":"https://api.github.com/users/grubernaut/repos","events_url":"https://api.github.com/users/grubernaut/events{/privacy}","received_events_url":"https://api.github.com/users/grubernaut/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-04T19:48:19Z","updated_at":"2015-09-04T20:54:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/neillturner/kitchen-puppet/pulls/68","html_url":"https://github.com/neillturner/kitchen-puppet/pull/68","diff_url":"https://github.com/neillturner/kitchen-puppet/pull/68.diff","patch_url":"https://github.com/neillturner/kitchen-puppet/pull/68.patch"},"body":"This allows kitchen-puppet to determine the correct apt repo to use when\r\ninstalling Puppet, instead of requiring manual user settings.\r\n\r\nDoing this, however, deprecates the configuration of `puppet-platform`,\r\nas this is now set from the platform configuration in\r\n`.kitchen.yml`.\r\n\r\nI have left the default `puppet_apt_repo` configuration parameter set to\r\nubuntu precise. I can be convinced fairly easily to change this to\r\ntrusty, yet I don't really see the benefit after the merge of this\r\npatch, as `kitchen-puppet` will now install the correct apt repo based\r\non the test-suite's platform without further configuration.\r\n\r\nDue to this deprecation we will likely need to increase the minor version from\r\n`0` to `1` according to semver rules. cc: @neillturner\r\n\r\nAs discovered in Issue #67, the puppet repo for ubuntu-precise still\r\nallowed for installation of the `hiera-puppet` package. This package is\r\nno longer needed if running a version of Puppet 3.x.x or greater.\r\n\r\nTo circumvent this issue, we no longer install the `hiera-puppet`\r\npackage by default, instead only installing this package when the\r\n`install_hiera` configuration flag is toggled.\r\n\r\nHiera will still be installed by the `puppet-common` package for any\r\nversion of puppet that is > 3.x.x"},"comment":{"url":"https://api.github.com/repos/neillturner/kitchen-puppet/issues/comments/137849839","html_url":"https://github.com/neillturner/kitchen-puppet/pull/68#issuecomment-137849839","issue_url":"https://api.github.com/repos/neillturner/kitchen-puppet/issues/68","id":137849839,"user":{"login":"ytsarev","id":518532,"avatar_url":"https://avatars.githubusercontent.com/u/518532?v=3","gravatar_id":"","url":"https://api.github.com/users/ytsarev","html_url":"https://github.com/ytsarev","followers_url":"https://api.github.com/users/ytsarev/followers","following_url":"https://api.github.com/users/ytsarev/following{/other_user}","gists_url":"https://api.github.com/users/ytsarev/gists{/gist_id}","starred_url":"https://api.github.com/users/ytsarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ytsarev/subscriptions","organizations_url":"https://api.github.com/users/ytsarev/orgs","repos_url":"https://api.github.com/users/ytsarev/repos","events_url":"https://api.github.com/users/ytsarev/events{/privacy}","received_events_url":"https://api.github.com/users/ytsarev/received_events","type":"User","site_admin":false},"created_at":"2015-09-04T20:54:29Z","updated_at":"2015-09-04T20:54:29Z","body":"let's write some specs for that ?"}}