{"action":"opened","number":14,"pull_request":{"url":"https://api.github.com/repos/litong01/python-monasca/pulls/14","id":38821234,"html_url":"https://github.com/litong01/python-monasca/pull/14","diff_url":"https://github.com/litong01/python-monasca/pull/14.diff","patch_url":"https://github.com/litong01/python-monasca/pull/14.patch","issue_url":"https://api.github.com/repos/litong01/python-monasca/issues/14","number":14,"state":"open","locked":false,"title":"Change es get/set to synchronized and fixed test cases","user":{"login":"hankok","id":9120282,"avatar_url":"https://avatars.githubusercontent.com/u/9120282?v=3","gravatar_id":"","url":"https://api.github.com/users/hankok","html_url":"https://github.com/hankok","followers_url":"https://api.github.com/users/hankok/followers","following_url":"https://api.github.com/users/hankok/following{/other_user}","gists_url":"https://api.github.com/users/hankok/gists{/gist_id}","starred_url":"https://api.github.com/users/hankok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hankok/subscriptions","organizations_url":"https://api.github.com/users/hankok/orgs","repos_url":"https://api.github.com/users/hankok/repos","events_url":"https://api.github.com/users/hankok/events{/privacy}","received_events_url":"https://api.github.com/users/hankok/received_events","type":"User","site_admin":false},"body":"Hi Tong,\r\n\r\nI changed the elasticsearch actions to synchronized. And all the alarmdefination and notification methods are stored in an index named \"admin\".\r\nOne question is will alarms be stored in data_2015... or admin index?\r\nAnother question is I can't get pep8 pass on one line of the test cases where \"with expressions \" with multiple patch objects are used. e.g.\r\n\r\n        with mock.patch.object(notifications.NotificationMethodDispatcher,\r\n                               'handle_notification_msg',\r\n                               return_value=200), \\\r\n             mock.patch.object(ast, 'literal_eval',\r\n                               return_value=ast.literal_eval(\r\n                                   \"{'type': 'PAGEDUTY', \"\r\n                                   \"'name': 'NotificationMethod2', \"\r\n                                   \"'address': '1234567'}\")):\r\n\r\nThe error is monasca/tests/v2/elasticsearch/test_notification.py:185:51: H904  Wrap long lines in parentheses instead of a backslash\r\n                               return_value=200), \\\r\n\r\nI don't know how to change it to (), because parentheses will make the with expression invalid.\r\n\r\nThanks,\r\nHan\r\n\r\n","created_at":"2015-06-29T21:45:31Z","updated_at":"2015-06-29T21:45:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/litong01/python-monasca/pulls/14/commits","review_comments_url":"https://api.github.com/repos/litong01/python-monasca/pulls/14/comments","review_comment_url":"https://api.github.com/repos/litong01/python-monasca/pulls/comments{/number}","comments_url":"https://api.github.com/repos/litong01/python-monasca/issues/14/comments","statuses_url":"https://api.github.com/repos/litong01/python-monasca/statuses/51277434ddaa90cbc20146c838b0f66cc153feb1","head":{"label":"hankok:master","ref":"master","sha":"51277434ddaa90cbc20146c838b0f66cc153feb1","user":{"login":"hankok","id":9120282,"avatar_url":"https://avatars.githubusercontent.com/u/9120282?v=3","gravatar_id":"","url":"https://api.github.com/users/hankok","html_url":"https://github.com/hankok","followers_url":"https://api.github.com/users/hankok/followers","following_url":"https://api.github.com/users/hankok/following{/other_user}","gists_url":"https://api.github.com/users/hankok/gists{/gist_id}","starred_url":"https://api.github.com/users/hankok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hankok/subscriptions","organizations_url":"https://api.github.com/users/hankok/orgs","repos_url":"https://api.github.com/users/hankok/repos","events_url":"https://api.github.com/users/hankok/events{/privacy}","received_events_url":"https://api.github.com/users/hankok/received_events","type":"User","site_admin":false},"repo":{"id":38272407,"name":"python-monasca","full_name":"hankok/python-monasca","owner":{"login":"hankok","id":9120282,"avatar_url":"https://avatars.githubusercontent.com/u/9120282?v=3","gravatar_id":"","url":"https://api.github.com/users/hankok","html_url":"https://github.com/hankok","followers_url":"https://api.github.com/users/hankok/followers","following_url":"https://api.github.com/users/hankok/following{/other_user}","gists_url":"https://api.github.com/users/hankok/gists{/gist_id}","starred_url":"https://api.github.com/users/hankok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hankok/subscriptions","organizations_url":"https://api.github.com/users/hankok/orgs","repos_url":"https://api.github.com/users/hankok/repos","events_url":"https://api.github.com/users/hankok/events{/privacy}","received_events_url":"https://api.github.com/users/hankok/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hankok/python-monasca","description":"the python implementation of monasca","fork":true,"url":"https://api.github.com/repos/hankok/python-monasca","forks_url":"https://api.github.com/repos/hankok/python-monasca/forks","keys_url":"https://api.github.com/repos/hankok/python-monasca/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hankok/python-monasca/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hankok/python-monasca/teams","hooks_url":"https://api.github.com/repos/hankok/python-monasca/hooks","issue_events_url":"https://api.github.com/repos/hankok/python-monasca/issues/events{/number}","events_url":"https://api.github.com/repos/hankok/python-monasca/events","assignees_url":"https://api.github.com/repos/hankok/python-monasca/assignees{/user}","branches_url":"https://api.github.com/repos/hankok/python-monasca/branches{/branch}","tags_url":"https://api.github.com/repos/hankok/python-monasca/tags","blobs_url":"https://api.github.com/repos/hankok/python-monasca/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hankok/python-monasca/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hankok/python-monasca/git/refs{/sha}","trees_url":"https://api.github.com/repos/hankok/python-monasca/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hankok/python-monasca/statuses/{sha}","languages_url":"https://api.github.com/repos/hankok/python-monasca/languages","stargazers_url":"https://api.github.com/repos/hankok/python-monasca/stargazers","contributors_url":"https://api.github.com/repos/hankok/python-monasca/contributors","subscribers_url":"https://api.github.com/repos/hankok/python-monasca/subscribers","subscription_url":"https://api.github.com/repos/hankok/python-monasca/subscription","commits_url":"https://api.github.com/repos/hankok/python-monasca/commits{/sha}","git_commits_url":"https://api.github.com/repos/hankok/python-monasca/git/commits{/sha}","comments_url":"https://api.github.com/repos/hankok/python-monasca/comments{/number}","issue_comment_url":"https://api.github.com/repos/hankok/python-monasca/issues/comments{/number}","contents_url":"https://api.github.com/repos/hankok/python-monasca/contents/{+path}","compare_url":"https://api.github.com/repos/hankok/python-monasca/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hankok/python-monasca/merges","archive_url":"https://api.github.com/repos/hankok/python-monasca/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hankok/python-monasca/downloads","issues_url":"https://api.github.com/repos/hankok/python-monasca/issues{/number}","pulls_url":"https://api.github.com/repos/hankok/python-monasca/pulls{/number}","milestones_url":"https://api.github.com/repos/hankok/python-monasca/milestones{/number}","notifications_url":"https://api.github.com/repos/hankok/python-monasca/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hankok/python-monasca/labels{/name}","releases_url":"https://api.github.com/repos/hankok/python-monasca/releases{/id}","created_at":"2015-06-29T21:30:59Z","updated_at":"2015-06-29T21:31:00Z","pushed_at":"2015-06-29T21:38:16Z","git_url":"git://github.com/hankok/python-monasca.git","ssh_url":"git@github.com:hankok/python-monasca.git","clone_url":"https://github.com/hankok/python-monasca.git","svn_url":"https://github.com/hankok/python-monasca","homepage":null,"size":611,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"litong01:master","ref":"master","sha":"017125109eea2138c99dda70480d312c1ecf3535","user":{"login":"litong01","id":1943243,"avatar_url":"https://avatars.githubusercontent.com/u/1943243?v=3","gravatar_id":"","url":"https://api.github.com/users/litong01","html_url":"https://github.com/litong01","followers_url":"https://api.github.com/users/litong01/followers","following_url":"https://api.github.com/users/litong01/following{/other_user}","gists_url":"https://api.github.com/users/litong01/gists{/gist_id}","starred_url":"https://api.github.com/users/litong01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/litong01/subscriptions","organizations_url":"https://api.github.com/users/litong01/orgs","repos_url":"https://api.github.com/users/litong01/repos","events_url":"https://api.github.com/users/litong01/events{/privacy}","received_events_url":"https://api.github.com/users/litong01/received_events","type":"User","site_admin":false},"repo":{"id":23794782,"name":"python-monasca","full_name":"litong01/python-monasca","owner":{"login":"litong01","id":1943243,"avatar_url":"https://avatars.githubusercontent.com/u/1943243?v=3","gravatar_id":"","url":"https://api.github.com/users/litong01","html_url":"https://github.com/litong01","followers_url":"https://api.github.com/users/litong01/followers","following_url":"https://api.github.com/users/litong01/following{/other_user}","gists_url":"https://api.github.com/users/litong01/gists{/gist_id}","starred_url":"https://api.github.com/users/litong01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/litong01/subscriptions","organizations_url":"https://api.github.com/users/litong01/orgs","repos_url":"https://api.github.com/users/litong01/repos","events_url":"https://api.github.com/users/litong01/events{/privacy}","received_events_url":"https://api.github.com/users/litong01/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/litong01/python-monasca","description":"the python implementation of monasca","fork":false,"url":"https://api.github.com/repos/litong01/python-monasca","forks_url":"https://api.github.com/repos/litong01/python-monasca/forks","keys_url":"https://api.github.com/repos/litong01/python-monasca/keys{/key_id}","collaborators_url":"https://api.github.com/repos/litong01/python-monasca/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/litong01/python-monasca/teams","hooks_url":"https://api.github.com/repos/litong01/python-monasca/hooks","issue_events_url":"https://api.github.com/repos/litong01/python-monasca/issues/events{/number}","events_url":"https://api.github.com/repos/litong01/python-monasca/events","assignees_url":"https://api.github.com/repos/litong01/python-monasca/assignees{/user}","branches_url":"https://api.github.com/repos/litong01/python-monasca/branches{/branch}","tags_url":"https://api.github.com/repos/litong01/python-monasca/tags","blobs_url":"https://api.github.com/repos/litong01/python-monasca/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/litong01/python-monasca/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/litong01/python-monasca/git/refs{/sha}","trees_url":"https://api.github.com/repos/litong01/python-monasca/git/trees{/sha}","statuses_url":"https://api.github.com/repos/litong01/python-monasca/statuses/{sha}","languages_url":"https://api.github.com/repos/litong01/python-monasca/languages","stargazers_url":"https://api.github.com/repos/litong01/python-monasca/stargazers","contributors_url":"https://api.github.com/repos/litong01/python-monasca/contributors","subscribers_url":"https://api.github.com/repos/litong01/python-monasca/subscribers","subscription_url":"https://api.github.com/repos/litong01/python-monasca/subscription","commits_url":"https://api.github.com/repos/litong01/python-monasca/commits{/sha}","git_commits_url":"https://api.github.com/repos/litong01/python-monasca/git/commits{/sha}","comments_url":"https://api.github.com/repos/litong01/python-monasca/comments{/number}","issue_comment_url":"https://api.github.com/repos/litong01/python-monasca/issues/comments{/number}","contents_url":"https://api.github.com/repos/litong01/python-monasca/contents/{+path}","compare_url":"https://api.github.com/repos/litong01/python-monasca/compare/{base}...{head}","merges_url":"https://api.github.com/repos/litong01/python-monasca/merges","archive_url":"https://api.github.com/repos/litong01/python-monasca/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/litong01/python-monasca/downloads","issues_url":"https://api.github.com/repos/litong01/python-monasca/issues{/number}","pulls_url":"https://api.github.com/repos/litong01/python-monasca/pulls{/number}","milestones_url":"https://api.github.com/repos/litong01/python-monasca/milestones{/number}","notifications_url":"https://api.github.com/repos/litong01/python-monasca/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/litong01/python-monasca/labels{/name}","releases_url":"https://api.github.com/repos/litong01/python-monasca/releases{/id}","created_at":"2014-09-08T14:50:44Z","updated_at":"2015-04-25T13:12:07Z","pushed_at":"2015-06-29T21:20:07Z","git_url":"git://github.com/litong01/python-monasca.git","ssh_url":"git@github.com:litong01/python-monasca.git","clone_url":"https://github.com/litong01/python-monasca.git","svn_url":"https://github.com/litong01/python-monasca","homepage":null,"size":611,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":10,"forks":4,"open_issues":10,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/litong01/python-monasca/pulls/14"},"html":{"href":"https://github.com/litong01/python-monasca/pull/14"},"issue":{"href":"https://api.github.com/repos/litong01/python-monasca/issues/14"},"comments":{"href":"https://api.github.com/repos/litong01/python-monasca/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/litong01/python-monasca/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/litong01/python-monasca/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/litong01/python-monasca/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/litong01/python-monasca/statuses/51277434ddaa90cbc20146c838b0f66cc153feb1"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1374,"deletions":6,"changed_files":11}}