{"action":"closed","number":49,"pull_request":{"url":"https://api.github.com/repos/rails/actioncable/pulls/49","id":41268066,"html_url":"https://github.com/rails/actioncable/pull/49","diff_url":"https://github.com/rails/actioncable/pull/49.diff","patch_url":"https://github.com/rails/actioncable/pull/49.patch","issue_url":"https://api.github.com/repos/rails/actioncable/issues/49","number":49,"state":"closed","locked":false,"title":"Fixes test failure in ActionCable::Channel::BroadcastingTest when run by itself","user":{"login":"jasondew","id":2415,"avatar_url":"https://avatars.githubusercontent.com/u/2415?v=3","gravatar_id":"","url":"https://api.github.com/users/jasondew","html_url":"https://github.com/jasondew","followers_url":"https://api.github.com/users/jasondew/followers","following_url":"https://api.github.com/users/jasondew/following{/other_user}","gists_url":"https://api.github.com/users/jasondew/gists{/gist_id}","starred_url":"https://api.github.com/users/jasondew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasondew/subscriptions","organizations_url":"https://api.github.com/users/jasondew/orgs","repos_url":"https://api.github.com/users/jasondew/repos","events_url":"https://api.github.com/users/jasondew/events{/privacy}","received_events_url":"https://api.github.com/users/jasondew/received_events","type":"User","site_admin":false},"body":"Here's the test output currently:\r\n\r\n```\r\n$ ruby -Ilib:test -rtest_helper test/channel/broadcasting_test.rb\r\nRun options: --seed 9529\r\n\r\n# Running:\r\n\r\nEEEE\r\n\r\nFinished in 0.002903s, 1378.0449 runs/s, 0.0000 assertions/s.\r\n\r\n  1) Error:\r\nActionCable::Channel::BroadcastingTest#test_broadcasting_for_with_a_string:\r\nNoMethodError: undefined method `to_param' for \"hello\":String\r\n    /Users/jasondew/Projects/jasondew-actioncable/lib/action_cable/channel/broadcasting.rb:21:in `broadcasting_for'\r\n    test/channel/broadcasting_test.rb:27:in `block in <class:BroadcastingTest>'\r\n\r\n\r\n  2) Error:\r\nActionCable::Channel::BroadcastingTest#test_broadcasting_for_with_an_array:\r\nNoMethodError: undefined method `to_param' for \"Room#1-Campfire\":String\r\n    /Users/jasondew/Projects/jasondew-actioncable/test/stubs/room.rb:14:in `to_gid_param'\r\n    /Users/jasondew/Projects/jasondew-actioncable/lib/action_cable/channel/broadcasting.rb:19:in `broadcasting_for'\r\n    /Users/jasondew/Projects/jasondew-actioncable/lib/action_cable/channel/broadcasting.rb:17:in `block in broadcasting_for'\r\n    /Users/jasondew/Projects/jasondew-actioncable/lib/action_cable/channel/broadcasting.rb:17:in `map'\r\n    /Users/jasondew/Projects/jasondew-actioncable/lib/action_cable/channel/broadcasting.rb:17:in `broadcasting_for'\r\n    test/channel/broadcasting_test.rb:23:in `block in <class:BroadcastingTest>'\r\n\r\n\r\n  3) Error:\r\nActionCable::Channel::BroadcastingTest#test_broadcasting_for_with_an_object:\r\nNoMethodError: undefined method `to_param' for \"Room#1-Campfire\":String\r\n    /Users/jasondew/Projects/jasondew-actioncable/test/stubs/room.rb:14:in `to_gid_param'\r\n    /Users/jasondew/Projects/jasondew-actioncable/lib/action_cable/channel/broadcasting.rb:19:in `broadcasting_for'\r\n    test/channel/broadcasting_test.rb:19:in `block in <class:BroadcastingTest>'\r\n\r\n\r\n  4) Error:\r\nActionCable::Channel::BroadcastingTest#test_broadcasts_to:\r\nNoMethodError: undefined method `to_param' for \"action_cable:channel:broadcasting_test:chat\":String\r\n    /Users/jasondew/Projects/jasondew-actioncable/lib/action_cable/channel/broadcasting.rb:21:in `broadcasting_for'\r\n    /Users/jasondew/Projects/jasondew-actioncable/lib/action_cable/channel/broadcasting.rb:17:in `block in broadcasting_for'\r\n    /Users/jasondew/Projects/jasondew-actioncable/lib/action_cable/channel/broadcasting.rb:17:in `map'\r\n    /Users/jasondew/Projects/jasondew-actioncable/lib/action_cable/channel/broadcasting.rb:17:in `broadcasting_for'\r\n    /Users/jasondew/Projects/jasondew-actioncable/lib/action_cable/channel/broadcasting.rb:11:in `broadcast_to'\r\n    test/channel/broadcasting_test.rb:15:in `block in <class:BroadcastingTest>'\r\n\r\n4 runs, 0 assertions, 0 failures, 4 errors, 0 skips\r\n```\r\n\r\nI haven't investigated further to find out where/how we're requiring this when the whole suite is run, but this fixes things up.","created_at":"2015-07-30T18:47:19Z","updated_at":"2015-07-30T18:59:12Z","closed_at":"2015-07-30T18:59:12Z","merged_at":"2015-07-30T18:59:12Z","merge_commit_sha":"3d6992b50e066bd26de17af375cdff4bb7a36bd6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rails/actioncable/pulls/49/commits","review_comments_url":"https://api.github.com/repos/rails/actioncable/pulls/49/comments","review_comment_url":"https://api.github.com/repos/rails/actioncable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/actioncable/issues/49/comments","statuses_url":"https://api.github.com/repos/rails/actioncable/statuses/92b0a993909f6f413a5486017f6401b5845762d0","head":{"label":"jasondew:channel_broadcasting_test_fix","ref":"channel_broadcasting_test_fix","sha":"92b0a993909f6f413a5486017f6401b5845762d0","user":{"login":"jasondew","id":2415,"avatar_url":"https://avatars.githubusercontent.com/u/2415?v=3","gravatar_id":"","url":"https://api.github.com/users/jasondew","html_url":"https://github.com/jasondew","followers_url":"https://api.github.com/users/jasondew/followers","following_url":"https://api.github.com/users/jasondew/following{/other_user}","gists_url":"https://api.github.com/users/jasondew/gists{/gist_id}","starred_url":"https://api.github.com/users/jasondew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasondew/subscriptions","organizations_url":"https://api.github.com/users/jasondew/orgs","repos_url":"https://api.github.com/users/jasondew/repos","events_url":"https://api.github.com/users/jasondew/events{/privacy}","received_events_url":"https://api.github.com/users/jasondew/received_events","type":"User","site_admin":false},"repo":{"id":39965515,"name":"actioncable","full_name":"jasondew/actioncable","owner":{"login":"jasondew","id":2415,"avatar_url":"https://avatars.githubusercontent.com/u/2415?v=3","gravatar_id":"","url":"https://api.github.com/users/jasondew","html_url":"https://github.com/jasondew","followers_url":"https://api.github.com/users/jasondew/followers","following_url":"https://api.github.com/users/jasondew/following{/other_user}","gists_url":"https://api.github.com/users/jasondew/gists{/gist_id}","starred_url":"https://api.github.com/users/jasondew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasondew/subscriptions","organizations_url":"https://api.github.com/users/jasondew/orgs","repos_url":"https://api.github.com/users/jasondew/repos","events_url":"https://api.github.com/users/jasondew/events{/privacy}","received_events_url":"https://api.github.com/users/jasondew/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jasondew/actioncable","description":"Framework for real-time communication over websockets","fork":true,"url":"https://api.github.com/repos/jasondew/actioncable","forks_url":"https://api.github.com/repos/jasondew/actioncable/forks","keys_url":"https://api.github.com/repos/jasondew/actioncable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasondew/actioncable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasondew/actioncable/teams","hooks_url":"https://api.github.com/repos/jasondew/actioncable/hooks","issue_events_url":"https://api.github.com/repos/jasondew/actioncable/issues/events{/number}","events_url":"https://api.github.com/repos/jasondew/actioncable/events","assignees_url":"https://api.github.com/repos/jasondew/actioncable/assignees{/user}","branches_url":"https://api.github.com/repos/jasondew/actioncable/branches{/branch}","tags_url":"https://api.github.com/repos/jasondew/actioncable/tags","blobs_url":"https://api.github.com/repos/jasondew/actioncable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasondew/actioncable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasondew/actioncable/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasondew/actioncable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasondew/actioncable/statuses/{sha}","languages_url":"https://api.github.com/repos/jasondew/actioncable/languages","stargazers_url":"https://api.github.com/repos/jasondew/actioncable/stargazers","contributors_url":"https://api.github.com/repos/jasondew/actioncable/contributors","subscribers_url":"https://api.github.com/repos/jasondew/actioncable/subscribers","subscription_url":"https://api.github.com/repos/jasondew/actioncable/subscription","commits_url":"https://api.github.com/repos/jasondew/actioncable/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasondew/actioncable/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasondew/actioncable/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasondew/actioncable/issues/comments{/number}","contents_url":"https://api.github.com/repos/jasondew/actioncable/contents/{+path}","compare_url":"https://api.github.com/repos/jasondew/actioncable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasondew/actioncable/merges","archive_url":"https://api.github.com/repos/jasondew/actioncable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasondew/actioncable/downloads","issues_url":"https://api.github.com/repos/jasondew/actioncable/issues{/number}","pulls_url":"https://api.github.com/repos/jasondew/actioncable/pulls{/number}","milestones_url":"https://api.github.com/repos/jasondew/actioncable/milestones{/number}","notifications_url":"https://api.github.com/repos/jasondew/actioncable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasondew/actioncable/labels{/name}","releases_url":"https://api.github.com/repos/jasondew/actioncable/releases{/id}","created_at":"2015-07-30T18:16:32Z","updated_at":"2015-07-30T18:16:33Z","pushed_at":"2015-07-30T18:54:16Z","git_url":"git://github.com/jasondew/actioncable.git","ssh_url":"git@github.com:jasondew/actioncable.git","clone_url":"https://github.com/jasondew/actioncable.git","svn_url":"https://github.com/jasondew/actioncable","homepage":null,"size":1113,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"219c48e18b10bebbefb1c12d94278f3e0d94a0b5","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":29253597,"name":"actioncable","full_name":"rails/actioncable","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/actioncable","description":"Framework for real-time communication over websockets","fork":false,"url":"https://api.github.com/repos/rails/actioncable","forks_url":"https://api.github.com/repos/rails/actioncable/forks","keys_url":"https://api.github.com/repos/rails/actioncable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/actioncable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/actioncable/teams","hooks_url":"https://api.github.com/repos/rails/actioncable/hooks","issue_events_url":"https://api.github.com/repos/rails/actioncable/issues/events{/number}","events_url":"https://api.github.com/repos/rails/actioncable/events","assignees_url":"https://api.github.com/repos/rails/actioncable/assignees{/user}","branches_url":"https://api.github.com/repos/rails/actioncable/branches{/branch}","tags_url":"https://api.github.com/repos/rails/actioncable/tags","blobs_url":"https://api.github.com/repos/rails/actioncable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/actioncable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/actioncable/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/actioncable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/actioncable/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/actioncable/languages","stargazers_url":"https://api.github.com/repos/rails/actioncable/stargazers","contributors_url":"https://api.github.com/repos/rails/actioncable/contributors","subscribers_url":"https://api.github.com/repos/rails/actioncable/subscribers","subscription_url":"https://api.github.com/repos/rails/actioncable/subscription","commits_url":"https://api.github.com/repos/rails/actioncable/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/actioncable/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/actioncable/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/actioncable/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/actioncable/contents/{+path}","compare_url":"https://api.github.com/repos/rails/actioncable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/actioncable/merges","archive_url":"https://api.github.com/repos/rails/actioncable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/actioncable/downloads","issues_url":"https://api.github.com/repos/rails/actioncable/issues{/number}","pulls_url":"https://api.github.com/repos/rails/actioncable/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/actioncable/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/actioncable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/actioncable/labels{/name}","releases_url":"https://api.github.com/repos/rails/actioncable/releases{/id}","created_at":"2015-01-14T16:27:07Z","updated_at":"2015-07-30T18:38:41Z","pushed_at":"2015-07-30T18:59:12Z","git_url":"git://github.com/rails/actioncable.git","ssh_url":"git@github.com:rails/actioncable.git","clone_url":"https://github.com/rails/actioncable.git","svn_url":"https://github.com/rails/actioncable","homepage":null,"size":1113,"stargazers_count":690,"watchers_count":690,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":12,"forks":51,"open_issues":12,"watchers":690,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/actioncable/pulls/49"},"html":{"href":"https://github.com/rails/actioncable/pull/49"},"issue":{"href":"https://api.github.com/repos/rails/actioncable/issues/49"},"comments":{"href":"https://api.github.com/repos/rails/actioncable/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/actioncable/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/actioncable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/actioncable/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/rails/actioncable/statuses/92b0a993909f6f413a5486017f6401b5845762d0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kaspth","id":350807,"avatar_url":"https://avatars.githubusercontent.com/u/350807?v=3","gravatar_id":"","url":"https://api.github.com/users/kaspth","html_url":"https://github.com/kaspth","followers_url":"https://api.github.com/users/kaspth/followers","following_url":"https://api.github.com/users/kaspth/following{/other_user}","gists_url":"https://api.github.com/users/kaspth/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspth/subscriptions","organizations_url":"https://api.github.com/users/kaspth/orgs","repos_url":"https://api.github.com/users/kaspth/repos","events_url":"https://api.github.com/users/kaspth/events{/privacy}","received_events_url":"https://api.github.com/users/kaspth/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":0,"changed_files":1}}