{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/branch-api-plugin/issues/5","labels_url":"https://api.github.com/repos/jenkinsci/branch-api-plugin/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/branch-api-plugin/issues/5/comments","events_url":"https://api.github.com/repos/jenkinsci/branch-api-plugin/issues/5/events","html_url":"https://github.com/jenkinsci/branch-api-plugin/pull/5","id":98433676,"number":5,"title":"Always run BranchIndexing on master","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-07-31T17:20:58Z","updated_at":"2015-08-05T12:45:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/branch-api-plugin/pulls/5","html_url":"https://github.com/jenkinsci/branch-api-plugin/pull/5","diff_url":"https://github.com/jenkinsci/branch-api-plugin/pull/5.diff","patch_url":"https://github.com/jenkinsci/branch-api-plugin/pull/5.patch"},"body":"`MultiBranchProject` is a `FlyweightTask` so it does not require a heavyweight executor; it could “run” on any node, even `master` when configured to have zero executors. (At least as of JENKINS-7291 in 1.510.) In fact `BranchIndexing` was not doing anything at all with the `Computer` it was handed, other than using its `Charset`, which was probably wrong anyway.\r\n\r\nFor compatibility of old indexing logs I am retaining the `charset` field, in case it was “run on” a slave with a different charset than master (and there were non-ASCII branch names!), though I am tempted to just delete the field and hardcode `Charset.default()`.\r\n\r\nWhy do I care about this issue? It turned out there was a bug in `durable-task` which I will fix as a separate PR, and the combination of these two bugs prevented use of `mock-slave` clouds in https://github.com/jenkinsci/workflow-plugin/pull/166: `BranchIndexing` would run periodically on a one-shot slave and when it finished it would kill the slave even while it was doing real work.\r\n\r\n@reviewbybees esp. @stephenc"},"comment":{"url":"https://api.github.com/repos/jenkinsci/branch-api-plugin/issues/comments/127984715","html_url":"https://github.com/jenkinsci/branch-api-plugin/pull/5#issuecomment-127984715","issue_url":"https://api.github.com/repos/jenkinsci/branch-api-plugin/issues/5","id":127984715,"user":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"created_at":"2015-08-05T12:45:20Z","updated_at":"2015-08-05T12:45:20Z","body":"> Will this still run on master when there are no dedicated executors on the master?\r\n\r\nYes; see PR description. (https://github.com/jenkinsci/workflow-plugin/pull/166 in fact demonstrates that case.)"}}