{"action":"closed","number":44,"pull_request":{"url":"https://api.github.com/repos/Icinga/icingaweb2/pulls/44","id":45710043,"html_url":"https://github.com/Icinga/icingaweb2/pull/44","diff_url":"https://github.com/Icinga/icingaweb2/pull/44.diff","patch_url":"https://github.com/Icinga/icingaweb2/pull/44.patch","issue_url":"https://api.github.com/repos/Icinga/icingaweb2/issues/44","number":44,"state":"closed","locked":false,"title":"Fixes for ldap group auth","user":{"login":"analogrithems","id":103706,"avatar_url":"https://avatars.githubusercontent.com/u/103706?v=3","gravatar_id":"","url":"https://api.github.com/users/analogrithems","html_url":"https://github.com/analogrithems","followers_url":"https://api.github.com/users/analogrithems/followers","following_url":"https://api.github.com/users/analogrithems/following{/other_user}","gists_url":"https://api.github.com/users/analogrithems/gists{/gist_id}","starred_url":"https://api.github.com/users/analogrithems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/analogrithems/subscriptions","organizations_url":"https://api.github.com/users/analogrithems/orgs","repos_url":"https://api.github.com/users/analogrithems/repos","events_url":"https://api.github.com/users/analogrithems/events{/privacy}","received_events_url":"https://api.github.com/users/analogrithems/received_events","type":"User","site_admin":false},"body":"The current LdapUserGroupBackend was incomplete and suffered from a little over zealous copy pasta.  It had over written certain functions that where unnecessary such as the constructor and a table validator.  This patch aims to clean those up.  Additionally it also makes this group auth work with posixGroup that use the username as the member identifier and not just inetGroups that use the full dn","created_at":"2015-09-22T20:05:27Z","updated_at":"2015-09-30T01:37:39Z","closed_at":"2015-09-30T01:37:39Z","merged_at":null,"merge_commit_sha":"378ad25e73e63cb7b2cf87e02c2e64851f990737","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Icinga/icingaweb2/pulls/44/commits","review_comments_url":"https://api.github.com/repos/Icinga/icingaweb2/pulls/44/comments","review_comment_url":"https://api.github.com/repos/Icinga/icingaweb2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Icinga/icingaweb2/issues/44/comments","statuses_url":"https://api.github.com/repos/Icinga/icingaweb2/statuses/43ef2fff284eda7bd1bcbf6fa949e4c5e78815ee","head":{"label":"analogrithems:master","ref":"master","sha":"43ef2fff284eda7bd1bcbf6fa949e4c5e78815ee","user":{"login":"analogrithems","id":103706,"avatar_url":"https://avatars.githubusercontent.com/u/103706?v=3","gravatar_id":"","url":"https://api.github.com/users/analogrithems","html_url":"https://github.com/analogrithems","followers_url":"https://api.github.com/users/analogrithems/followers","following_url":"https://api.github.com/users/analogrithems/following{/other_user}","gists_url":"https://api.github.com/users/analogrithems/gists{/gist_id}","starred_url":"https://api.github.com/users/analogrithems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/analogrithems/subscriptions","organizations_url":"https://api.github.com/users/analogrithems/orgs","repos_url":"https://api.github.com/users/analogrithems/repos","events_url":"https://api.github.com/users/analogrithems/events{/privacy}","received_events_url":"https://api.github.com/users/analogrithems/received_events","type":"User","site_admin":false},"repo":{"id":42956332,"name":"icingaweb2","full_name":"analogrithems/icingaweb2","owner":{"login":"analogrithems","id":103706,"avatar_url":"https://avatars.githubusercontent.com/u/103706?v=3","gravatar_id":"","url":"https://api.github.com/users/analogrithems","html_url":"https://github.com/analogrithems","followers_url":"https://api.github.com/users/analogrithems/followers","following_url":"https://api.github.com/users/analogrithems/following{/other_user}","gists_url":"https://api.github.com/users/analogrithems/gists{/gist_id}","starred_url":"https://api.github.com/users/analogrithems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/analogrithems/subscriptions","organizations_url":"https://api.github.com/users/analogrithems/orgs","repos_url":"https://api.github.com/users/analogrithems/repos","events_url":"https://api.github.com/users/analogrithems/events{/privacy}","received_events_url":"https://api.github.com/users/analogrithems/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/analogrithems/icingaweb2","description":"Git Mirror & Releases for Icinga Web 2 (Developer Guidelines: https://wiki.icinga.org/display/Dev/Developer+Guidelines)","fork":true,"url":"https://api.github.com/repos/analogrithems/icingaweb2","forks_url":"https://api.github.com/repos/analogrithems/icingaweb2/forks","keys_url":"https://api.github.com/repos/analogrithems/icingaweb2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/analogrithems/icingaweb2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/analogrithems/icingaweb2/teams","hooks_url":"https://api.github.com/repos/analogrithems/icingaweb2/hooks","issue_events_url":"https://api.github.com/repos/analogrithems/icingaweb2/issues/events{/number}","events_url":"https://api.github.com/repos/analogrithems/icingaweb2/events","assignees_url":"https://api.github.com/repos/analogrithems/icingaweb2/assignees{/user}","branches_url":"https://api.github.com/repos/analogrithems/icingaweb2/branches{/branch}","tags_url":"https://api.github.com/repos/analogrithems/icingaweb2/tags","blobs_url":"https://api.github.com/repos/analogrithems/icingaweb2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/analogrithems/icingaweb2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/analogrithems/icingaweb2/git/refs{/sha}","trees_url":"https://api.github.com/repos/analogrithems/icingaweb2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/analogrithems/icingaweb2/statuses/{sha}","languages_url":"https://api.github.com/repos/analogrithems/icingaweb2/languages","stargazers_url":"https://api.github.com/repos/analogrithems/icingaweb2/stargazers","contributors_url":"https://api.github.com/repos/analogrithems/icingaweb2/contributors","subscribers_url":"https://api.github.com/repos/analogrithems/icingaweb2/subscribers","subscription_url":"https://api.github.com/repos/analogrithems/icingaweb2/subscription","commits_url":"https://api.github.com/repos/analogrithems/icingaweb2/commits{/sha}","git_commits_url":"https://api.github.com/repos/analogrithems/icingaweb2/git/commits{/sha}","comments_url":"https://api.github.com/repos/analogrithems/icingaweb2/comments{/number}","issue_comment_url":"https://api.github.com/repos/analogrithems/icingaweb2/issues/comments{/number}","contents_url":"https://api.github.com/repos/analogrithems/icingaweb2/contents/{+path}","compare_url":"https://api.github.com/repos/analogrithems/icingaweb2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/analogrithems/icingaweb2/merges","archive_url":"https://api.github.com/repos/analogrithems/icingaweb2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/analogrithems/icingaweb2/downloads","issues_url":"https://api.github.com/repos/analogrithems/icingaweb2/issues{/number}","pulls_url":"https://api.github.com/repos/analogrithems/icingaweb2/pulls{/number}","milestones_url":"https://api.github.com/repos/analogrithems/icingaweb2/milestones{/number}","notifications_url":"https://api.github.com/repos/analogrithems/icingaweb2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/analogrithems/icingaweb2/labels{/name}","releases_url":"https://api.github.com/repos/analogrithems/icingaweb2/releases{/id}","created_at":"2015-09-22T19:35:06Z","updated_at":"2015-09-22T19:35:12Z","pushed_at":"2015-09-22T20:04:38Z","git_url":"git://github.com/analogrithems/icingaweb2.git","ssh_url":"git@github.com:analogrithems/icingaweb2.git","clone_url":"https://github.com/analogrithems/icingaweb2.git","svn_url":"https://github.com/analogrithems/icingaweb2","homepage":"https://dev.icinga.org/projects/icingaweb2/roadmap","size":42037,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Icinga:master","ref":"master","sha":"b69311165c0c207451e12593610ab7e1ed8677dc","user":{"login":"Icinga","id":835441,"avatar_url":"https://avatars.githubusercontent.com/u/835441?v=3","gravatar_id":"","url":"https://api.github.com/users/Icinga","html_url":"https://github.com/Icinga","followers_url":"https://api.github.com/users/Icinga/followers","following_url":"https://api.github.com/users/Icinga/following{/other_user}","gists_url":"https://api.github.com/users/Icinga/gists{/gist_id}","starred_url":"https://api.github.com/users/Icinga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Icinga/subscriptions","organizations_url":"https://api.github.com/users/Icinga/orgs","repos_url":"https://api.github.com/users/Icinga/repos","events_url":"https://api.github.com/users/Icinga/events{/privacy}","received_events_url":"https://api.github.com/users/Icinga/received_events","type":"Organization","site_admin":false},"repo":{"id":13872749,"name":"icingaweb2","full_name":"Icinga/icingaweb2","owner":{"login":"Icinga","id":835441,"avatar_url":"https://avatars.githubusercontent.com/u/835441?v=3","gravatar_id":"","url":"https://api.github.com/users/Icinga","html_url":"https://github.com/Icinga","followers_url":"https://api.github.com/users/Icinga/followers","following_url":"https://api.github.com/users/Icinga/following{/other_user}","gists_url":"https://api.github.com/users/Icinga/gists{/gist_id}","starred_url":"https://api.github.com/users/Icinga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Icinga/subscriptions","organizations_url":"https://api.github.com/users/Icinga/orgs","repos_url":"https://api.github.com/users/Icinga/repos","events_url":"https://api.github.com/users/Icinga/events{/privacy}","received_events_url":"https://api.github.com/users/Icinga/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Icinga/icingaweb2","description":"Git Mirror & Releases for Icinga Web 2 (Developer Guidelines: https://wiki.icinga.org/display/Dev/Developer+Guidelines)","fork":false,"url":"https://api.github.com/repos/Icinga/icingaweb2","forks_url":"https://api.github.com/repos/Icinga/icingaweb2/forks","keys_url":"https://api.github.com/repos/Icinga/icingaweb2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Icinga/icingaweb2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Icinga/icingaweb2/teams","hooks_url":"https://api.github.com/repos/Icinga/icingaweb2/hooks","issue_events_url":"https://api.github.com/repos/Icinga/icingaweb2/issues/events{/number}","events_url":"https://api.github.com/repos/Icinga/icingaweb2/events","assignees_url":"https://api.github.com/repos/Icinga/icingaweb2/assignees{/user}","branches_url":"https://api.github.com/repos/Icinga/icingaweb2/branches{/branch}","tags_url":"https://api.github.com/repos/Icinga/icingaweb2/tags","blobs_url":"https://api.github.com/repos/Icinga/icingaweb2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Icinga/icingaweb2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Icinga/icingaweb2/git/refs{/sha}","trees_url":"https://api.github.com/repos/Icinga/icingaweb2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Icinga/icingaweb2/statuses/{sha}","languages_url":"https://api.github.com/repos/Icinga/icingaweb2/languages","stargazers_url":"https://api.github.com/repos/Icinga/icingaweb2/stargazers","contributors_url":"https://api.github.com/repos/Icinga/icingaweb2/contributors","subscribers_url":"https://api.github.com/repos/Icinga/icingaweb2/subscribers","subscription_url":"https://api.github.com/repos/Icinga/icingaweb2/subscription","commits_url":"https://api.github.com/repos/Icinga/icingaweb2/commits{/sha}","git_commits_url":"https://api.github.com/repos/Icinga/icingaweb2/git/commits{/sha}","comments_url":"https://api.github.com/repos/Icinga/icingaweb2/comments{/number}","issue_comment_url":"https://api.github.com/repos/Icinga/icingaweb2/issues/comments{/number}","contents_url":"https://api.github.com/repos/Icinga/icingaweb2/contents/{+path}","compare_url":"https://api.github.com/repos/Icinga/icingaweb2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Icinga/icingaweb2/merges","archive_url":"https://api.github.com/repos/Icinga/icingaweb2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Icinga/icingaweb2/downloads","issues_url":"https://api.github.com/repos/Icinga/icingaweb2/issues{/number}","pulls_url":"https://api.github.com/repos/Icinga/icingaweb2/pulls{/number}","milestones_url":"https://api.github.com/repos/Icinga/icingaweb2/milestones{/number}","notifications_url":"https://api.github.com/repos/Icinga/icingaweb2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Icinga/icingaweb2/labels{/name}","releases_url":"https://api.github.com/repos/Icinga/icingaweb2/releases{/id}","created_at":"2013-10-25T21:39:44Z","updated_at":"2015-09-29T06:33:02Z","pushed_at":"2015-09-30T01:37:22Z","git_url":"git://github.com/Icinga/icingaweb2.git","ssh_url":"git@github.com:Icinga/icingaweb2.git","clone_url":"https://github.com/Icinga/icingaweb2.git","svn_url":"https://github.com/Icinga/icingaweb2","homepage":"https://dev.icinga.org/projects/icingaweb2/roadmap","size":79987,"stargazers_count":145,"watchers_count":145,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":74,"mirror_url":null,"open_issues_count":4,"forks":74,"open_issues":4,"watchers":145,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Icinga/icingaweb2/pulls/44"},"html":{"href":"https://github.com/Icinga/icingaweb2/pull/44"},"issue":{"href":"https://api.github.com/repos/Icinga/icingaweb2/issues/44"},"comments":{"href":"https://api.github.com/repos/Icinga/icingaweb2/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/Icinga/icingaweb2/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/Icinga/icingaweb2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Icinga/icingaweb2/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/Icinga/icingaweb2/statuses/43ef2fff284eda7bd1bcbf6fa949e4c5e78815ee"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"commits":2,"additions":23,"deletions":73,"changed_files":1}}