{"action":"created","comment":{"url":"https://api.github.com/repos/DGtal-team/DGtalTools/pulls/comments/41162961","id":41162961,"diff_hunk":"@@ -153,11 +153,24 @@ void displayDSS3dTangent( Viewer3D<space, kspace> & viewer,\n         const DGtal::Color & color3d )\n {\n   typedef typename StandardDSS6Computer::Point3d Point;\n-  typedef typename StandardDSS6Computer::PointD3d PointD3d;\n+  typedef typename StandardDSS6Computer::PointR3d PointR3d;\n+  typedef DGtal::PointVector<3,double> PointD3d;\n   typedef typename Display3D<>::BallD3D PointD3D;\n   Point directionZ3;\n-  PointD3d P1, P2, direction, intercept, thickness;\n-  dss3d.getParameters( directionZ3, intercept, thickness );\n+  PointR3d interceptR, thicknessR;\n+  PointD3d P1, P2, direction;\n+  dss3d.getParameters( directionZ3, interceptR, thicknessR );\n+  \n+  PointD3d intercept;\n+  intercept[0] = (double) NumberTraits<int>::castToInt64_t ( interceptR[0].first ) / (double) NumberTraits<int>::castToInt64_t ( interceptR[0].second );","path":"visualisation/3dCurveViewer.cpp","position":16,"original_position":16,"commit_id":"04cdd9149243ecf6190e76e6259c59e4678e1b18","original_commit_id":"04cdd9149243ecf6190e76e6259c59e4678e1b18","user":{"login":"copyme","id":456607,"avatar_url":"https://avatars.githubusercontent.com/u/456607?v=3","gravatar_id":"","url":"https://api.github.com/users/copyme","html_url":"https://github.com/copyme","followers_url":"https://api.github.com/users/copyme/followers","following_url":"https://api.github.com/users/copyme/following{/other_user}","gists_url":"https://api.github.com/users/copyme/gists{/gist_id}","starred_url":"https://api.github.com/users/copyme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/copyme/subscriptions","organizations_url":"https://api.github.com/users/copyme/orgs","repos_url":"https://api.github.com/users/copyme/repos","events_url":"https://api.github.com/users/copyme/events{/privacy}","received_events_url":"https://api.github.com/users/copyme/received_events","type":"User","site_admin":false},"body":"@dcoeurjo Agree, this could be also done in two places in DGtal code. Should I do it?","created_at":"2015-10-05T16:10:55Z","updated_at":"2015-10-05T16:10:55Z","html_url":"https://github.com/DGtal-team/DGtalTools/pull/218#discussion_r41162961","pull_request_url":"https://api.github.com/repos/DGtal-team/DGtalTools/pulls/218","_links":{"self":{"href":"https://api.github.com/repos/DGtal-team/DGtalTools/pulls/comments/41162961"},"html":{"href":"https://github.com/DGtal-team/DGtalTools/pull/218#discussion_r41162961"},"pull_request":{"href":"https://api.github.com/repos/DGtal-team/DGtalTools/pulls/218"}}},"pull_request":{"url":"https://api.github.com/repos/DGtal-team/DGtalTools/pulls/218","id":38101815,"html_url":"https://github.com/DGtal-team/DGtalTools/pull/218","diff_url":"https://github.com/DGtal-team/DGtalTools/pull/218.diff","patch_url":"https://github.com/DGtal-team/DGtalTools/pull/218.patch","issue_url":"https://api.github.com/repos/DGtal-team/DGtalTools/issues/218","number":218,"state":"open","locked":false,"title":"3d curve tangent estimator","user":{"login":"JacquesOlivierLachaud","id":793707,"avatar_url":"https://avatars.githubusercontent.com/u/793707?v=3","gravatar_id":"","url":"https://api.github.com/users/JacquesOlivierLachaud","html_url":"https://github.com/JacquesOlivierLachaud","followers_url":"https://api.github.com/users/JacquesOlivierLachaud/followers","following_url":"https://api.github.com/users/JacquesOlivierLachaud/following{/other_user}","gists_url":"https://api.github.com/users/JacquesOlivierLachaud/gists{/gist_id}","starred_url":"https://api.github.com/users/JacquesOlivierLachaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacquesOlivierLachaud/subscriptions","organizations_url":"https://api.github.com/users/JacquesOlivierLachaud/orgs","repos_url":"https://api.github.com/users/JacquesOlivierLachaud/repos","events_url":"https://api.github.com/users/JacquesOlivierLachaud/events{/privacy}","received_events_url":"https://api.github.com/users/JacquesOlivierLachaud/received_events","type":"User","site_admin":false},"body":"A simple tool to estimate the tangent to a set of points approaching a 3D curve, based on digital Voronoi Covariance Measure.","created_at":"2015-06-19T12:15:25Z","updated_at":"2015-10-05T16:10:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0963165ed3f2461f20e703603ad62b9ab4628515","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DGtal-team/DGtalTools/pulls/218/commits","review_comments_url":"https://api.github.com/repos/DGtal-team/DGtalTools/pulls/218/comments","review_comment_url":"https://api.github.com/repos/DGtal-team/DGtalTools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DGtal-team/DGtalTools/issues/218/comments","statuses_url":"https://api.github.com/repos/DGtal-team/DGtalTools/statuses/04cdd9149243ecf6190e76e6259c59e4678e1b18","head":{"label":"JacquesOlivierLachaud:3dCurveTangentEstimator","ref":"3dCurveTangentEstimator","sha":"04cdd9149243ecf6190e76e6259c59e4678e1b18","user":{"login":"JacquesOlivierLachaud","id":793707,"avatar_url":"https://avatars.githubusercontent.com/u/793707?v=3","gravatar_id":"","url":"https://api.github.com/users/JacquesOlivierLachaud","html_url":"https://github.com/JacquesOlivierLachaud","followers_url":"https://api.github.com/users/JacquesOlivierLachaud/followers","following_url":"https://api.github.com/users/JacquesOlivierLachaud/following{/other_user}","gists_url":"https://api.github.com/users/JacquesOlivierLachaud/gists{/gist_id}","starred_url":"https://api.github.com/users/JacquesOlivierLachaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacquesOlivierLachaud/subscriptions","organizations_url":"https://api.github.com/users/JacquesOlivierLachaud/orgs","repos_url":"https://api.github.com/users/JacquesOlivierLachaud/repos","events_url":"https://api.github.com/users/JacquesOlivierLachaud/events{/privacy}","received_events_url":"https://api.github.com/users/JacquesOlivierLachaud/received_events","type":"User","site_admin":false},"repo":{"id":4023998,"name":"DGtalTools","full_name":"JacquesOlivierLachaud/DGtalTools","owner":{"login":"JacquesOlivierLachaud","id":793707,"avatar_url":"https://avatars.githubusercontent.com/u/793707?v=3","gravatar_id":"","url":"https://api.github.com/users/JacquesOlivierLachaud","html_url":"https://github.com/JacquesOlivierLachaud","followers_url":"https://api.github.com/users/JacquesOlivierLachaud/followers","following_url":"https://api.github.com/users/JacquesOlivierLachaud/following{/other_user}","gists_url":"https://api.github.com/users/JacquesOlivierLachaud/gists{/gist_id}","starred_url":"https://api.github.com/users/JacquesOlivierLachaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacquesOlivierLachaud/subscriptions","organizations_url":"https://api.github.com/users/JacquesOlivierLachaud/orgs","repos_url":"https://api.github.com/users/JacquesOlivierLachaud/repos","events_url":"https://api.github.com/users/JacquesOlivierLachaud/events{/privacy}","received_events_url":"https://api.github.com/users/JacquesOlivierLachaud/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JacquesOlivierLachaud/DGtalTools","description":"Tools associated with DGtal Library","fork":true,"url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools","forks_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/forks","keys_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/teams","hooks_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/hooks","issue_events_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/issues/events{/number}","events_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/events","assignees_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/assignees{/user}","branches_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/branches{/branch}","tags_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/tags","blobs_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/git/refs{/sha}","trees_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/statuses/{sha}","languages_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/languages","stargazers_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/stargazers","contributors_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/contributors","subscribers_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/subscribers","subscription_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/subscription","commits_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/commits{/sha}","git_commits_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/git/commits{/sha}","comments_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/comments{/number}","issue_comment_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/issues/comments{/number}","contents_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/contents/{+path}","compare_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/merges","archive_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/downloads","issues_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/issues{/number}","pulls_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/pulls{/number}","milestones_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/milestones{/number}","notifications_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/labels{/name}","releases_url":"https://api.github.com/repos/JacquesOlivierLachaud/DGtalTools/releases{/id}","created_at":"2012-04-14T10:19:52Z","updated_at":"2015-06-19T12:12:14Z","pushed_at":"2015-10-05T15:32:57Z","git_url":"git://github.com/JacquesOlivierLachaud/DGtalTools.git","ssh_url":"git@github.com:JacquesOlivierLachaud/DGtalTools.git","clone_url":"https://github.com/JacquesOlivierLachaud/DGtalTools.git","svn_url":"https://github.com/JacquesOlivierLachaud/DGtalTools","homepage":"http://liris.cnrs.fr/dgtal","size":1314,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"DGtal-team:master","ref":"master","sha":"981e80639179933b2b94b0315aaa9c478003e4f2","user":{"login":"DGtal-team","id":1013900,"avatar_url":"https://avatars.githubusercontent.com/u/1013900?v=3","gravatar_id":"","url":"https://api.github.com/users/DGtal-team","html_url":"https://github.com/DGtal-team","followers_url":"https://api.github.com/users/DGtal-team/followers","following_url":"https://api.github.com/users/DGtal-team/following{/other_user}","gists_url":"https://api.github.com/users/DGtal-team/gists{/gist_id}","starred_url":"https://api.github.com/users/DGtal-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DGtal-team/subscriptions","organizations_url":"https://api.github.com/users/DGtal-team/orgs","repos_url":"https://api.github.com/users/DGtal-team/repos","events_url":"https://api.github.com/users/DGtal-team/events{/privacy}","received_events_url":"https://api.github.com/users/DGtal-team/received_events","type":"Organization","site_admin":false},"repo":{"id":3958971,"name":"DGtalTools","full_name":"DGtal-team/DGtalTools","owner":{"login":"DGtal-team","id":1013900,"avatar_url":"https://avatars.githubusercontent.com/u/1013900?v=3","gravatar_id":"","url":"https://api.github.com/users/DGtal-team","html_url":"https://github.com/DGtal-team","followers_url":"https://api.github.com/users/DGtal-team/followers","following_url":"https://api.github.com/users/DGtal-team/following{/other_user}","gists_url":"https://api.github.com/users/DGtal-team/gists{/gist_id}","starred_url":"https://api.github.com/users/DGtal-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DGtal-team/subscriptions","organizations_url":"https://api.github.com/users/DGtal-team/orgs","repos_url":"https://api.github.com/users/DGtal-team/repos","events_url":"https://api.github.com/users/DGtal-team/events{/privacy}","received_events_url":"https://api.github.com/users/DGtal-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DGtal-team/DGtalTools","description":"Tools associated with DGtal Library","fork":false,"url":"https://api.github.com/repos/DGtal-team/DGtalTools","forks_url":"https://api.github.com/repos/DGtal-team/DGtalTools/forks","keys_url":"https://api.github.com/repos/DGtal-team/DGtalTools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DGtal-team/DGtalTools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DGtal-team/DGtalTools/teams","hooks_url":"https://api.github.com/repos/DGtal-team/DGtalTools/hooks","issue_events_url":"https://api.github.com/repos/DGtal-team/DGtalTools/issues/events{/number}","events_url":"https://api.github.com/repos/DGtal-team/DGtalTools/events","assignees_url":"https://api.github.com/repos/DGtal-team/DGtalTools/assignees{/user}","branches_url":"https://api.github.com/repos/DGtal-team/DGtalTools/branches{/branch}","tags_url":"https://api.github.com/repos/DGtal-team/DGtalTools/tags","blobs_url":"https://api.github.com/repos/DGtal-team/DGtalTools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DGtal-team/DGtalTools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DGtal-team/DGtalTools/git/refs{/sha}","trees_url":"https://api.github.com/repos/DGtal-team/DGtalTools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DGtal-team/DGtalTools/statuses/{sha}","languages_url":"https://api.github.com/repos/DGtal-team/DGtalTools/languages","stargazers_url":"https://api.github.com/repos/DGtal-team/DGtalTools/stargazers","contributors_url":"https://api.github.com/repos/DGtal-team/DGtalTools/contributors","subscribers_url":"https://api.github.com/repos/DGtal-team/DGtalTools/subscribers","subscription_url":"https://api.github.com/repos/DGtal-team/DGtalTools/subscription","commits_url":"https://api.github.com/repos/DGtal-team/DGtalTools/commits{/sha}","git_commits_url":"https://api.github.com/repos/DGtal-team/DGtalTools/git/commits{/sha}","comments_url":"https://api.github.com/repos/DGtal-team/DGtalTools/comments{/number}","issue_comment_url":"https://api.github.com/repos/DGtal-team/DGtalTools/issues/comments{/number}","contents_url":"https://api.github.com/repos/DGtal-team/DGtalTools/contents/{+path}","compare_url":"https://api.github.com/repos/DGtal-team/DGtalTools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DGtal-team/DGtalTools/merges","archive_url":"https://api.github.com/repos/DGtal-team/DGtalTools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DGtal-team/DGtalTools/downloads","issues_url":"https://api.github.com/repos/DGtal-team/DGtalTools/issues{/number}","pulls_url":"https://api.github.com/repos/DGtal-team/DGtalTools/pulls{/number}","milestones_url":"https://api.github.com/repos/DGtal-team/DGtalTools/milestones{/number}","notifications_url":"https://api.github.com/repos/DGtal-team/DGtalTools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DGtal-team/DGtalTools/labels{/name}","releases_url":"https://api.github.com/repos/DGtal-team/DGtalTools/releases{/id}","created_at":"2012-04-07T16:28:49Z","updated_at":"2015-05-25T01:40:16Z","pushed_at":"2015-10-05T15:32:57Z","git_url":"git://github.com/DGtal-team/DGtalTools.git","ssh_url":"git@github.com:DGtal-team/DGtalTools.git","clone_url":"https://github.com/DGtal-team/DGtalTools.git","svn_url":"https://github.com/DGtal-team/DGtalTools","homepage":"http://dgtal.org","size":2171,"stargazers_count":11,"watchers_count":11,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":18,"forks":24,"open_issues":18,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DGtal-team/DGtalTools/pulls/218"},"html":{"href":"https://github.com/DGtal-team/DGtalTools/pull/218"},"issue":{"href":"https://api.github.com/repos/DGtal-team/DGtalTools/issues/218"},"comments":{"href":"https://api.github.com/repos/DGtal-team/DGtalTools/issues/218/comments"},"review_comments":{"href":"https://api.github.com/repos/DGtal-team/DGtalTools/pulls/218/comments"},"review_comment":{"href":"https://api.github.com/repos/DGtal-team/DGtalTools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DGtal-team/DGtalTools/pulls/218/commits"},"statuses":{"href":"https://api.github.com/repos/DGtal-team/DGtalTools/statuses/04cdd9149243ecf6190e76e6259c59e4678e1b18"}}}}