{"action":"created","issue":{"url":"https://api.github.com/repos/georchestra/georchestra/issues/1038","labels_url":"https://api.github.com/repos/georchestra/georchestra/issues/1038/labels{/name}","comments_url":"https://api.github.com/repos/georchestra/georchestra/issues/1038/comments","events_url":"https://api.github.com/repos/georchestra/georchestra/issues/1038/events","html_url":"https://github.com/georchestra/georchestra/pull/1038","id":104082348,"number":1038,"title":"mapfishapp - datadir","user":{"login":"pmauduit","id":594335,"avatar_url":"https://avatars.githubusercontent.com/u/594335?v=3","gravatar_id":"","url":"https://api.github.com/users/pmauduit","html_url":"https://github.com/pmauduit","followers_url":"https://api.github.com/users/pmauduit/followers","following_url":"https://api.github.com/users/pmauduit/following{/other_user}","gists_url":"https://api.github.com/users/pmauduit/gists{/gist_id}","starred_url":"https://api.github.com/users/pmauduit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmauduit/subscriptions","organizations_url":"https://api.github.com/users/pmauduit/orgs","repos_url":"https://api.github.com/users/pmauduit/repos","events_url":"https://api.github.com/users/pmauduit/events{/privacy}","received_events_url":"https://api.github.com/users/pmauduit/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-08-31T16:06:57Z","updated_at":"2015-09-14T08:06:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/georchestra/georchestra/pulls/1038","html_url":"https://github.com/georchestra/georchestra/pull/1038","diff_url":"https://github.com/georchestra/georchestra/pull/1038.diff","patch_url":"https://github.com/georchestra/georchestra/pull/1038.patch"},"body":"This PR proposes the datadirization of the mapfishapp webapp:\r\n\r\n- Exports the contexts, addons, JS configuration (including GEOR_custom.js) into the datadir\r\n- Makes the rest of the webapp configurable outside of the webapp WAR (using the same mechanisms as previously)\r\n- Allows mapfishapp to be easily customized by server-side addons (it allows automatic scanning of jars which classes begining with org.georchestra.mapfishapp.addons.*, as well as a applicationContext.xml to be defined. See https://github.com/pmauduit/osm2geor/tree/master/java as an example of use-case)\r\n\r\nAs the other PR, it requires the introduction of the georchestra-commons module. Travis-ci will fail until https://github.com/georchestra/georchestra/pull/1035 is merged.\r\n\r\nNote for the reviewers: A lot of files are related to default addons inclusion, the majority of files added to src/deb/resources/etc are not necessary to be reviewed IMHO.\r\n\r\nTODO:\r\n* [x] Test compilation\r\n* [x] testsuite\r\n* [x] runtime test with `georchestra.datadir`\r\n* [x] runtime test without `georchestra.datadir`\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/georchestra/georchestra/issues/comments/139990820","html_url":"https://github.com/georchestra/georchestra/pull/1038#issuecomment-139990820","issue_url":"https://api.github.com/repos/georchestra/georchestra/issues/1038","id":139990820,"user":{"login":"landryb","id":3421760,"avatar_url":"https://avatars.githubusercontent.com/u/3421760?v=3","gravatar_id":"","url":"https://api.github.com/users/landryb","html_url":"https://github.com/landryb","followers_url":"https://api.github.com/users/landryb/followers","following_url":"https://api.github.com/users/landryb/following{/other_user}","gists_url":"https://api.github.com/users/landryb/gists{/gist_id}","starred_url":"https://api.github.com/users/landryb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/landryb/subscriptions","organizations_url":"https://api.github.com/users/landryb/orgs","repos_url":"https://api.github.com/users/landryb/repos","events_url":"https://api.github.com/users/landryb/events{/privacy}","received_events_url":"https://api.github.com/users/landryb/received_events","type":"User","site_admin":false},"created_at":"2015-09-14T08:06:04Z","updated_at":"2015-09-14T08:06:04Z","body":"Hm, i was mistaken, at mapfishapp loading /ws/app/js/GEOR_custom.js is called and it effectively returns the content of the file found in the datadir."}}