{"action":"created","issue":{"url":"https://api.github.com/repos/w3c/csvw/issues/469","labels_url":"https://api.github.com/repos/w3c/csvw/issues/469/labels{/name}","comments_url":"https://api.github.com/repos/w3c/csvw/issues/469/comments","events_url":"https://api.github.com/repos/w3c/csvw/issues/469/events","html_url":"https://github.com/w3c/csvw/pull/469","id":67213251,"number":469,"title":"Issue 463: Change the `value` term in the model document to `annotation value`.","user":{"login":"gkellogg","id":46296,"avatar_url":"https://avatars.githubusercontent.com/u/46296?v=3","gravatar_id":"","url":"https://api.github.com/users/gkellogg","html_url":"https://github.com/gkellogg","followers_url":"https://api.github.com/users/gkellogg/followers","following_url":"https://api.github.com/users/gkellogg/following{/other_user}","gists_url":"https://api.github.com/users/gkellogg/gists{/gist_id}","starred_url":"https://api.github.com/users/gkellogg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkellogg/subscriptions","organizations_url":"https://api.github.com/users/gkellogg/orgs","repos_url":"https://api.github.com/users/gkellogg/repos","events_url":"https://api.github.com/users/gkellogg/events{/privacy}","received_events_url":"https://api.github.com/users/gkellogg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"JeniT","id":395050,"avatar_url":"https://avatars.githubusercontent.com/u/395050?v=3","gravatar_id":"","url":"https://api.github.com/users/JeniT","html_url":"https://github.com/JeniT","followers_url":"https://api.github.com/users/JeniT/followers","following_url":"https://api.github.com/users/JeniT/following{/other_user}","gists_url":"https://api.github.com/users/JeniT/gists{/gist_id}","starred_url":"https://api.github.com/users/JeniT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeniT/subscriptions","organizations_url":"https://api.github.com/users/JeniT/orgs","repos_url":"https://api.github.com/users/JeniT/repos","events_url":"https://api.github.com/users/JeniT/events{/privacy}","received_events_url":"https://api.github.com/users/JeniT/received_events","type":"User","site_admin":false},"milestone":null,"comments":7,"created_at":"2015-04-08T20:29:02Z","updated_at":"2015-04-10T09:57:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/w3c/csvw/pulls/469","html_url":"https://github.com/w3c/csvw/pull/469","diff_url":"https://github.com/w3c/csvw/pull/469.diff","patch_url":"https://github.com/w3c/csvw/pull/469.patch"},"body":"Remove `property value` term, and use within the model document refering instead to the appropriate annotation value within the model document.\r\nFixes #463."},"comment":{"url":"https://api.github.com/repos/w3c/csvw/issues/comments/91500186","html_url":"https://github.com/w3c/csvw/pull/469#issuecomment-91500186","issue_url":"https://api.github.com/repos/w3c/csvw/issues/469","id":91500186,"user":{"login":"iherman","id":520723,"avatar_url":"https://avatars.githubusercontent.com/u/520723?v=3","gravatar_id":"","url":"https://api.github.com/users/iherman","html_url":"https://github.com/iherman","followers_url":"https://api.github.com/users/iherman/followers","following_url":"https://api.github.com/users/iherman/following{/other_user}","gists_url":"https://api.github.com/users/iherman/gists{/gist_id}","starred_url":"https://api.github.com/users/iherman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iherman/subscriptions","organizations_url":"https://api.github.com/users/iherman/orgs","repos_url":"https://api.github.com/users/iherman/repos","events_url":"https://api.github.com/users/iherman/events{/privacy}","received_events_url":"https://api.github.com/users/iherman/received_events","type":"User","site_admin":false},"created_at":"2015-04-10T09:57:09Z","updated_at":"2015-04-10T09:57:09Z","body":"First of all, deep bow towards San Francisco:-)\r\n\r\nI have some editing on the text; I will commit that (with comments) separately, so that you can accept them or change them. I also have some comments below that may require some discussion, so I did not want to change them.\r\n\r\n* [ ] I was a bit struggling with the presence of the `aboutUrl` and friends in the column annotations. Do we need them there? The final, purely URL values appear on the cell level annotation, and that seems to be enough. (Of course, implementations may optimize these things for conversions, i.e., extract the common `aboutUrl` values for cells, but that is not something for the model)\r\n* [ ] The title property in the syntax is defined as \"any number of human-readable titles for the column, each of which has an associated language represented as an object whose properties MUST be language codes as defined by [[!BCP47]] and whose values are arrays of strings related to that language.\" Is this correct, grammatically? But, more importantly... I personally would have preferred to keep it as it was, i.e., something like \"any number of human readable titles for the column, each of which with an associated language as defined in [[!BCP47]]\". However, if we do that change, the metadata document has to change, to (for natural language properties) so I did not do any change.\r\n* [ ] I note that there are still two references to the metadata documents (beyond the url templates): foreign keys and transformations. I have no problem for the latter, I wonder whether the former should not be rather defined in the syntax document.\r\n* [ ] I see that you have kept the datatype diagram and corresponding text in the metadata document. It is not strictly necessary; after all, the definition is now in the syntax document. I do not have any strong feeling whether it is good to keep it in the metadata document or not; I though I would flag it nevertheless...\r\n\r\n\r\n/Cc @JeniT\r\n\r\n\r\n\r\n\r\n"}}