{"action":"created","issue":{"url":"https://api.github.com/repos/tzyganu/UMC1.9/issues/104","labels_url":"https://api.github.com/repos/tzyganu/UMC1.9/issues/104/labels{/name}","comments_url":"https://api.github.com/repos/tzyganu/UMC1.9/issues/104/comments","events_url":"https://api.github.com/repos/tzyganu/UMC1.9/issues/104/events","html_url":"https://github.com/tzyganu/UMC1.9/pull/104","id":111043331,"number":104,"title":"Update 130_footer","user":{"login":"dfelton","id":2659558,"avatar_url":"https://avatars.githubusercontent.com/u/2659558?v=3","gravatar_id":"","url":"https://api.github.com/users/dfelton","html_url":"https://github.com/dfelton","followers_url":"https://api.github.com/users/dfelton/followers","following_url":"https://api.github.com/users/dfelton/following{/other_user}","gists_url":"https://api.github.com/users/dfelton/gists{/gist_id}","starred_url":"https://api.github.com/users/dfelton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfelton/subscriptions","organizations_url":"https://api.github.com/users/dfelton/orgs","repos_url":"https://api.github.com/users/dfelton/repos","events_url":"https://api.github.com/users/dfelton/events{/privacy}","received_events_url":"https://api.github.com/users/dfelton/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-12T19:53:47Z","updated_at":"2015-10-27T07:03:17Z","closed_at":"2015-10-27T07:03:17Z","pull_request":{"url":"https://api.github.com/repos/tzyganu/UMC1.9/pulls/104","html_url":"https://github.com/tzyganu/UMC1.9/pull/104","diff_url":"https://github.com/tzyganu/UMC1.9/pull/104.diff","patch_url":"https://github.com/tzyganu/UMC1.9/pull/104.patch"},"body":"Added two new line characters to top of file. Reason is that the generated class files `app/code/{{codepool}}/{{Namespace}}/{{Module}}/Model/Resource/{{Entity}}.php` files are currently ending in a double \"}}\" at the second to last line of the class (rather than the ending curly bracket character for the class, ending on it's own new line AFTER the last class method's closing curly bracket).\r\n\r\n(1st) new line character added so that there is a new line after the classes' final method\r\n(2nd) new line character added so that there is a an empty line between the closing curly bracket of the last method in the class, and the closing curly bracket for the class itself.\r\n\r\nI noticed that other *_footer source files do not have a leading new line characters; therefore this update may be more appropriate elsewhere. I suspect that the logic which appends the source files of other classes handles adding a new line character between source files. Whereas the logic which appends the source file app/code/community/Ultimate/ModuleCreator/etc/source/app/code/Model/Resource/Entity/130_footer is simply missing logic to append a new line character prior to the contents of this file. Due to time availability, I was unable to track down the logic which is appending this file to our Resource Entities."},"comment":{"url":"https://api.github.com/repos/tzyganu/UMC1.9/issues/comments/151397642","html_url":"https://github.com/tzyganu/UMC1.9/pull/104#issuecomment-151397642","issue_url":"https://api.github.com/repos/tzyganu/UMC1.9/issues/104","id":151397642,"user":{"login":"tzyganu","id":2447784,"avatar_url":"https://avatars.githubusercontent.com/u/2447784?v=3","gravatar_id":"","url":"https://api.github.com/users/tzyganu","html_url":"https://github.com/tzyganu","followers_url":"https://api.github.com/users/tzyganu/followers","following_url":"https://api.github.com/users/tzyganu/following{/other_user}","gists_url":"https://api.github.com/users/tzyganu/gists{/gist_id}","starred_url":"https://api.github.com/users/tzyganu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzyganu/subscriptions","organizations_url":"https://api.github.com/users/tzyganu/orgs","repos_url":"https://api.github.com/users/tzyganu/repos","events_url":"https://api.github.com/users/tzyganu/events{/privacy}","received_events_url":"https://api.github.com/users/tzyganu/received_events","type":"User","site_admin":false},"created_at":"2015-10-27T07:03:17Z","updated_at":"2015-10-27T07:03:17Z","body":"The problem is not with the footer. There are other files before it that should end with an empty new line. The footer should stay as it is. \r\nThanks for spotting this. it will be fixed in the next version."}}