{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/34894699","id":34894699,"diff_hunk":"@@ -353,49 +404,101 @@ func (r *RollingUpdater) Update(config *RollingUpdaterConfig) error {\n \t\t}\n \t}\n \n-\t// +1, -1 on oldRc, newRc until newRc has desired number of replicas or oldRc has 0 replicas\n-\tfor newRc.Spec.Replicas < desired && oldRc.Spec.Replicas != 0 {\n-\t\tnewRc.Spec.Replicas += 1\n-\t\toldRc.Spec.Replicas -= 1\n-\t\tfmt.Printf(\"At beginning of loop: %s replicas: %d, %s replicas: %d\\n\",\n-\t\t\toldName, oldRc.Spec.Replicas,\n-\t\t\tnewName, newRc.Spec.Replicas)\n-\t\tfmt.Fprintf(out, \"Updating %s replicas: %d, %s replicas: %d\\n\",\n-\t\t\toldName, oldRc.Spec.Replicas,\n-\t\t\tnewName, newRc.Spec.Replicas)\n+\toldSpec := &oldRc.Spec\n+\tnewSpec := &newRc.Spec\n \n-\t\tnewRc, err = r.scaleAndWait(newRc, retry, waitForReplicas)\n-\t\tif err != nil {\n-\t\t\treturn err\n+\t// Compute the scale amount based on a percentage of the new desired count.\n+\t// A negative percentage indicates our scale direction should be down-first.\n+\tscaleAmount := 1\n+\tscaleUpFirst := true\n+\tif config.UpdatePercent != nil {\n+\t\tscaleAmount = int(math.Ceil(float64(desired) * (math.Abs(float64(*config.UpdatePercent)) / 100)))\n+\t\tif *config.UpdatePercent < 0 {\n+\t\t\tscaleUpFirst = false\n \t\t}\n-\t\ttime.Sleep(updatePeriod)\n-\t\toldRc, err = r.scaleAndWait(oldRc, retry, waitForReplicas)\n-\t\tif err != nil {\n-\t\t\treturn err\n+\t}\n+\t// Helpful output about what we're about to do.\n+\tdirection := \"up\"\n+\tif !scaleUpFirst {\n+\t\tdirection = \"down\"\n+\t}\n+\tfmt.Fprintf(out, \"Scaling up %s from %d to %d, scaling down %s from %d to 0 (scale %s first by %d each interval)\\n\",\n+\t\tnewName, newSpec.Replicas, desired, oldName, oldSpec.Replicas, direction, scaleAmount)\n+\n+\t// Scale newRc and oldRc until newRc has the desired number of replicas and\n+\t// oldRc has 0 replicas.\n+\tfor newSpec.Replicas != desired || oldSpec.Replicas != 0 {\n+\t\t// Set up a function for scaling up.\n+\t\tscaleUp := func() error {\n+\t\t\t// Nothing to do.\n+\t\t\tif newSpec.Replicas == desired {\n+\t\t\t\treturn nil\n+\t\t\t}\n+\t\t\t// Scale up new. Account for fencepost conditions. If the old spec is\n+\t\t\t// already scaled to 0, go ahead and scale all the way up.\n+\t\t\tnewSpec.Replicas += scaleAmount\n+\t\t\tif newSpec.Replicas > desired || oldSpec.Replicas == 0 {\n+\t\t\t\tnewSpec.Replicas = desired\n+\t\t\t}\n+\t\t\tfmt.Fprintf(out, \"Scaling %s up to %d\\n\", newName, newSpec.Replicas)\n+\t\t\tnewRc, err = r.scaleAndWait(newRc, retry, waitForReplicas)\n+\t\t\tif err != nil {\n+\t\t\t\treturn err\n+\t\t\t}\n+\t\t\tnewSpec = &newRc.Spec\n+\t\t\t// Perform acceptance checking, if necessary.\n+\t\t\tif config.UpdateAcceptor != nil {","path":"pkg/kubectl/rolling_updater.go","position":null,"original_position":179,"commit_id":"83456e79674b4030eb860b800571dce7b718ef4b","original_commit_id":"ef2407a76e1c1dadf32580a0b7177c9d096e7391","user":{"login":"ironcladlou","id":298299,"avatar_url":"https://avatars.githubusercontent.com/u/298299?v=3","gravatar_id":"","url":"https://api.github.com/users/ironcladlou","html_url":"https://github.com/ironcladlou","followers_url":"https://api.github.com/users/ironcladlou/followers","following_url":"https://api.github.com/users/ironcladlou/following{/other_user}","gists_url":"https://api.github.com/users/ironcladlou/gists{/gist_id}","starred_url":"https://api.github.com/users/ironcladlou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironcladlou/subscriptions","organizations_url":"https://api.github.com/users/ironcladlou/orgs","repos_url":"https://api.github.com/users/ironcladlou/repos","events_url":"https://api.github.com/users/ironcladlou/events{/privacy}","received_events_url":"https://api.github.com/users/ironcladlou/received_events","type":"User","site_admin":false},"body":"Made these changes.","created_at":"2015-07-17T14:37:33Z","updated_at":"2015-07-17T14:37:33Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/10062#discussion_r34894699","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10062","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/34894699"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/10062#discussion_r34894699"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10062"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10062","id":38049438,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/10062","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/10062.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/10062.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/10062","number":10062,"state":"open","locked":false,"title":"Rolling updater configurability enhancements","user":{"login":"ironcladlou","id":298299,"avatar_url":"https://avatars.githubusercontent.com/u/298299?v=3","gravatar_id":"","url":"https://api.github.com/users/ironcladlou","html_url":"https://github.com/ironcladlou","followers_url":"https://api.github.com/users/ironcladlou/followers","following_url":"https://api.github.com/users/ironcladlou/following{/other_user}","gists_url":"https://api.github.com/users/ironcladlou/gists{/gist_id}","starred_url":"https://api.github.com/users/ironcladlou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironcladlou/subscriptions","organizations_url":"https://api.github.com/users/ironcladlou/orgs","repos_url":"https://api.github.com/users/ironcladlou/repos","events_url":"https://api.github.com/users/ironcladlou/events{/privacy}","received_events_url":"https://api.github.com/users/ironcladlou/received_events","type":"User","site_admin":false},"body":"This PR adds two enhancements to the rolling updater:\r\n\r\n1. Add an `UpdateAcceptor` interface to the rolling updater which supports injecting code to validate the first replica during scale-up. If the replica is not accepted, the deployment fails. This facilitates canary checking so that many broken replicas aren't rolled out during an update.\r\n\r\n2. Make the rolling update scale amount configurable as a percent of the replica count. Refactor the tests.          ","created_at":"2015-06-18T20:31:08Z","updated_at":"2015-07-17T14:37:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"981e9ccfebb88960bdb5c38e0c2d48a6f5485472","assignee":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones/11","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/milestones/v1.0-post","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones/11/labels","id":1035380,"number":11,"title":"v1.0-post","description":"Things that are triaged and decided not for inclusion to v1.0","creator":{"login":"brendandburns","id":5751682,"avatar_url":"https://avatars.githubusercontent.com/u/5751682?v=3","gravatar_id":"","url":"https://api.github.com/users/brendandburns","html_url":"https://github.com/brendandburns","followers_url":"https://api.github.com/users/brendandburns/followers","following_url":"https://api.github.com/users/brendandburns/following{/other_user}","gists_url":"https://api.github.com/users/brendandburns/gists{/gist_id}","starred_url":"https://api.github.com/users/brendandburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendandburns/subscriptions","organizations_url":"https://api.github.com/users/brendandburns/orgs","repos_url":"https://api.github.com/users/brendandburns/repos","events_url":"https://api.github.com/users/brendandburns/events{/privacy}","received_events_url":"https://api.github.com/users/brendandburns/received_events","type":"User","site_admin":false},"open_issues":486,"closed_issues":92,"state":"open","created_at":"2015-03-23T22:54:17Z","updated_at":"2015-07-17T05:45:30Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10062/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10062/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/10062/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/83456e79674b4030eb860b800571dce7b718ef4b","head":{"label":"ironcladlou:update-acceptor","ref":"update-acceptor","sha":"83456e79674b4030eb860b800571dce7b718ef4b","user":{"login":"ironcladlou","id":298299,"avatar_url":"https://avatars.githubusercontent.com/u/298299?v=3","gravatar_id":"","url":"https://api.github.com/users/ironcladlou","html_url":"https://github.com/ironcladlou","followers_url":"https://api.github.com/users/ironcladlou/followers","following_url":"https://api.github.com/users/ironcladlou/following{/other_user}","gists_url":"https://api.github.com/users/ironcladlou/gists{/gist_id}","starred_url":"https://api.github.com/users/ironcladlou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironcladlou/subscriptions","organizations_url":"https://api.github.com/users/ironcladlou/orgs","repos_url":"https://api.github.com/users/ironcladlou/repos","events_url":"https://api.github.com/users/ironcladlou/events{/privacy}","received_events_url":"https://api.github.com/users/ironcladlou/received_events","type":"User","site_admin":false},"repo":{"id":20937083,"name":"kubernetes","full_name":"ironcladlou/kubernetes","owner":{"login":"ironcladlou","id":298299,"avatar_url":"https://avatars.githubusercontent.com/u/298299?v=3","gravatar_id":"","url":"https://api.github.com/users/ironcladlou","html_url":"https://github.com/ironcladlou","followers_url":"https://api.github.com/users/ironcladlou/followers","following_url":"https://api.github.com/users/ironcladlou/following{/other_user}","gists_url":"https://api.github.com/users/ironcladlou/gists{/gist_id}","starred_url":"https://api.github.com/users/ironcladlou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironcladlou/subscriptions","organizations_url":"https://api.github.com/users/ironcladlou/orgs","repos_url":"https://api.github.com/users/ironcladlou/repos","events_url":"https://api.github.com/users/ironcladlou/events{/privacy}","received_events_url":"https://api.github.com/users/ironcladlou/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ironcladlou/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/ironcladlou/kubernetes","forks_url":"https://api.github.com/repos/ironcladlou/kubernetes/forks","keys_url":"https://api.github.com/repos/ironcladlou/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ironcladlou/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ironcladlou/kubernetes/teams","hooks_url":"https://api.github.com/repos/ironcladlou/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/ironcladlou/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/ironcladlou/kubernetes/events","assignees_url":"https://api.github.com/repos/ironcladlou/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/ironcladlou/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/ironcladlou/kubernetes/tags","blobs_url":"https://api.github.com/repos/ironcladlou/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ironcladlou/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ironcladlou/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/ironcladlou/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ironcladlou/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/ironcladlou/kubernetes/languages","stargazers_url":"https://api.github.com/repos/ironcladlou/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/ironcladlou/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/ironcladlou/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/ironcladlou/kubernetes/subscription","commits_url":"https://api.github.com/repos/ironcladlou/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/ironcladlou/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/ironcladlou/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/ironcladlou/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/ironcladlou/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/ironcladlou/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ironcladlou/kubernetes/merges","archive_url":"https://api.github.com/repos/ironcladlou/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ironcladlou/kubernetes/downloads","issues_url":"https://api.github.com/repos/ironcladlou/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/ironcladlou/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/ironcladlou/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/ironcladlou/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ironcladlou/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/ironcladlou/kubernetes/releases{/id}","created_at":"2014-06-17T19:38:11Z","updated_at":"2015-04-27T13:01:52Z","pushed_at":"2015-07-17T14:36:43Z","git_url":"git://github.com/ironcladlou/kubernetes.git","ssh_url":"git@github.com:ironcladlou/kubernetes.git","clone_url":"https://github.com/ironcladlou/kubernetes.git","svn_url":"https://github.com/ironcladlou/kubernetes","homepage":null,"size":90012,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"596a8a40d12498b5335140f50753980bfaea4f6b","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-07-17T13:11:53Z","pushed_at":"2015-07-17T14:36:45Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":319322,"stargazers_count":8960,"watchers_count":8960,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2039,"mirror_url":null,"open_issues_count":1636,"forks":2039,"open_issues":1636,"watchers":8960,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10062"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/10062"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/10062"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/10062/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10062/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/10062/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/83456e79674b4030eb860b800571dce7b718ef4b"}}}}