{"action":"opened","number":26,"pull_request":{"url":"https://api.github.com/repos/cartoloupe/gamesonthetable/pulls/26","id":39179425,"html_url":"https://github.com/cartoloupe/gamesonthetable/pull/26","diff_url":"https://github.com/cartoloupe/gamesonthetable/pull/26.diff","patch_url":"https://github.com/cartoloupe/gamesonthetable/pull/26.patch","issue_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/issues/26","number":26,"state":"open","locked":false,"title":"Did a variety of cleanup.","user":{"login":"toddh","id":747491,"avatar_url":"https://avatars.githubusercontent.com/u/747491?v=3","gravatar_id":"","url":"https://api.github.com/users/toddh","html_url":"https://github.com/toddh","followers_url":"https://api.github.com/users/toddh/followers","following_url":"https://api.github.com/users/toddh/following{/other_user}","gists_url":"https://api.github.com/users/toddh/gists{/gist_id}","starred_url":"https://api.github.com/users/toddh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toddh/subscriptions","organizations_url":"https://api.github.com/users/toddh/orgs","repos_url":"https://api.github.com/users/toddh/repos","events_url":"https://api.github.com/users/toddh/events{/privacy}","received_events_url":"https://api.github.com/users/toddh/received_events","type":"User","site_admin":false},"body":"Angular unit testing has been setup. Only one test has been written. So there's a bunch\r\nof work to do create unit tests. The description language is jasmine and it's provided by\r\nthe jasmine-rails gem. To run a test, enter the comment\r\n\r\nRAILS_ENV=test rake spec:javascript\r\n\r\nAdditional items such a node.js might need setup.\r\n\r\nAdd a player model to indicate when a user is a player in a game.\r\n\r\nDon't think ActiveRecord:Associations are correct for the game model. I don't think the Game\r\nreally has_many players. But rather each Game belongs to one or more players. This needs to be fixed.\r\n\r\nStarted to add in some tradition rails testing with rspect. We're going to need this also. This would help uncover the problem above.","created_at":"2015-07-03T14:27:32Z","updated_at":"2015-07-03T14:27:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/pulls/26/commits","review_comments_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/pulls/26/comments","review_comment_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/issues/26/comments","statuses_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/statuses/e3837ffd37024f21b65747e51bdaececf0c0d816","head":{"label":"cartoloupe:cleanup","ref":"cleanup","sha":"e3837ffd37024f21b65747e51bdaececf0c0d816","user":{"login":"cartoloupe","id":4593934,"avatar_url":"https://avatars.githubusercontent.com/u/4593934?v=3","gravatar_id":"","url":"https://api.github.com/users/cartoloupe","html_url":"https://github.com/cartoloupe","followers_url":"https://api.github.com/users/cartoloupe/followers","following_url":"https://api.github.com/users/cartoloupe/following{/other_user}","gists_url":"https://api.github.com/users/cartoloupe/gists{/gist_id}","starred_url":"https://api.github.com/users/cartoloupe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cartoloupe/subscriptions","organizations_url":"https://api.github.com/users/cartoloupe/orgs","repos_url":"https://api.github.com/users/cartoloupe/repos","events_url":"https://api.github.com/users/cartoloupe/events{/privacy}","received_events_url":"https://api.github.com/users/cartoloupe/received_events","type":"User","site_admin":false},"repo":{"id":33761544,"name":"gamesonthetable","full_name":"cartoloupe/gamesonthetable","owner":{"login":"cartoloupe","id":4593934,"avatar_url":"https://avatars.githubusercontent.com/u/4593934?v=3","gravatar_id":"","url":"https://api.github.com/users/cartoloupe","html_url":"https://github.com/cartoloupe","followers_url":"https://api.github.com/users/cartoloupe/followers","following_url":"https://api.github.com/users/cartoloupe/following{/other_user}","gists_url":"https://api.github.com/users/cartoloupe/gists{/gist_id}","starred_url":"https://api.github.com/users/cartoloupe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cartoloupe/subscriptions","organizations_url":"https://api.github.com/users/cartoloupe/orgs","repos_url":"https://api.github.com/users/cartoloupe/repos","events_url":"https://api.github.com/users/cartoloupe/events{/privacy}","received_events_url":"https://api.github.com/users/cartoloupe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cartoloupe/gamesonthetable","description":"a table on which there are games","fork":false,"url":"https://api.github.com/repos/cartoloupe/gamesonthetable","forks_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/forks","keys_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/teams","hooks_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/hooks","issue_events_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/issues/events{/number}","events_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/events","assignees_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/assignees{/user}","branches_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/branches{/branch}","tags_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/tags","blobs_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/git/refs{/sha}","trees_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/statuses/{sha}","languages_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/languages","stargazers_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/stargazers","contributors_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/contributors","subscribers_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/subscribers","subscription_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/subscription","commits_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/commits{/sha}","git_commits_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/git/commits{/sha}","comments_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/comments{/number}","issue_comment_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/issues/comments{/number}","contents_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/contents/{+path}","compare_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/merges","archive_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/downloads","issues_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/issues{/number}","pulls_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/pulls{/number}","milestones_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/milestones{/number}","notifications_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/labels{/name}","releases_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/releases{/id}","created_at":"2015-04-11T03:47:10Z","updated_at":"2015-05-05T14:09:27Z","pushed_at":"2015-07-03T14:27:00Z","git_url":"git://github.com/cartoloupe/gamesonthetable.git","ssh_url":"git@github.com:cartoloupe/gamesonthetable.git","clone_url":"https://github.com/cartoloupe/gamesonthetable.git","svn_url":"https://github.com/cartoloupe/gamesonthetable","homepage":null,"size":1656,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"cartoloupe:master","ref":"master","sha":"8f338ab314907dc15ab9b1bb6f5259e1f7fe0d52","user":{"login":"cartoloupe","id":4593934,"avatar_url":"https://avatars.githubusercontent.com/u/4593934?v=3","gravatar_id":"","url":"https://api.github.com/users/cartoloupe","html_url":"https://github.com/cartoloupe","followers_url":"https://api.github.com/users/cartoloupe/followers","following_url":"https://api.github.com/users/cartoloupe/following{/other_user}","gists_url":"https://api.github.com/users/cartoloupe/gists{/gist_id}","starred_url":"https://api.github.com/users/cartoloupe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cartoloupe/subscriptions","organizations_url":"https://api.github.com/users/cartoloupe/orgs","repos_url":"https://api.github.com/users/cartoloupe/repos","events_url":"https://api.github.com/users/cartoloupe/events{/privacy}","received_events_url":"https://api.github.com/users/cartoloupe/received_events","type":"User","site_admin":false},"repo":{"id":33761544,"name":"gamesonthetable","full_name":"cartoloupe/gamesonthetable","owner":{"login":"cartoloupe","id":4593934,"avatar_url":"https://avatars.githubusercontent.com/u/4593934?v=3","gravatar_id":"","url":"https://api.github.com/users/cartoloupe","html_url":"https://github.com/cartoloupe","followers_url":"https://api.github.com/users/cartoloupe/followers","following_url":"https://api.github.com/users/cartoloupe/following{/other_user}","gists_url":"https://api.github.com/users/cartoloupe/gists{/gist_id}","starred_url":"https://api.github.com/users/cartoloupe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cartoloupe/subscriptions","organizations_url":"https://api.github.com/users/cartoloupe/orgs","repos_url":"https://api.github.com/users/cartoloupe/repos","events_url":"https://api.github.com/users/cartoloupe/events{/privacy}","received_events_url":"https://api.github.com/users/cartoloupe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cartoloupe/gamesonthetable","description":"a table on which there are games","fork":false,"url":"https://api.github.com/repos/cartoloupe/gamesonthetable","forks_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/forks","keys_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/teams","hooks_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/hooks","issue_events_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/issues/events{/number}","events_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/events","assignees_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/assignees{/user}","branches_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/branches{/branch}","tags_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/tags","blobs_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/git/refs{/sha}","trees_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/statuses/{sha}","languages_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/languages","stargazers_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/stargazers","contributors_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/contributors","subscribers_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/subscribers","subscription_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/subscription","commits_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/commits{/sha}","git_commits_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/git/commits{/sha}","comments_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/comments{/number}","issue_comment_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/issues/comments{/number}","contents_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/contents/{+path}","compare_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/merges","archive_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/downloads","issues_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/issues{/number}","pulls_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/pulls{/number}","milestones_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/milestones{/number}","notifications_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/labels{/name}","releases_url":"https://api.github.com/repos/cartoloupe/gamesonthetable/releases{/id}","created_at":"2015-04-11T03:47:10Z","updated_at":"2015-05-05T14:09:27Z","pushed_at":"2015-07-03T14:27:00Z","git_url":"git://github.com/cartoloupe/gamesonthetable.git","ssh_url":"git@github.com:cartoloupe/gamesonthetable.git","clone_url":"https://github.com/cartoloupe/gamesonthetable.git","svn_url":"https://github.com/cartoloupe/gamesonthetable","homepage":null,"size":1656,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cartoloupe/gamesonthetable/pulls/26"},"html":{"href":"https://github.com/cartoloupe/gamesonthetable/pull/26"},"issue":{"href":"https://api.github.com/repos/cartoloupe/gamesonthetable/issues/26"},"comments":{"href":"https://api.github.com/repos/cartoloupe/gamesonthetable/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/cartoloupe/gamesonthetable/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/cartoloupe/gamesonthetable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cartoloupe/gamesonthetable/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/cartoloupe/gamesonthetable/statuses/e3837ffd37024f21b65747e51bdaececf0c0d816"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1084,"deletions":256,"changed_files":69}}