{"action":"created","comment":{"url":"https://api.github.com/repos/google/closure-library/pulls/comments/39456368","id":39456368,"diff_hunk":"@@ -86,8 +86,8 @@ goog.i18n.NumberFormat = function(pattern, opt_currency, opt_currencyStyle) {\n   // The multiplier for use in percent, per mille, etc.\n   /** @private {number} */\n   this.multiplier_ = 1;\n-  /** @private {number} */\n-  this.groupingSize_ = 3;\n+  /** @private {Array} */","path":"closure/goog/i18n/numberformat.js","position":6,"original_position":6,"commit_id":"b4d33dc2aabe08a545aa0b86e9650a583fd310bf","original_commit_id":"ae693a83d5f2af7323561ab4e2dc8e1768a551d6","user":{"login":"jvu","id":2966460,"avatar_url":"https://avatars.githubusercontent.com/u/2966460?v=3","gravatar_id":"","url":"https://api.github.com/users/jvu","html_url":"https://github.com/jvu","followers_url":"https://api.github.com/users/jvu/followers","following_url":"https://api.github.com/users/jvu/following{/other_user}","gists_url":"https://api.github.com/users/jvu/gists{/gist_id}","starred_url":"https://api.github.com/users/jvu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvu/subscriptions","organizations_url":"https://api.github.com/users/jvu/orgs","repos_url":"https://api.github.com/users/jvu/repos","events_url":"https://api.github.com/users/jvu/events{/privacy}","received_events_url":"https://api.github.com/users/jvu/received_events","type":"User","site_admin":false},"body":"Done. Will be part of the next commit. Here's what I have so far:\r\n```\r\n  /**\r\n   * The grouping array is used to store the values of each number group\r\n   * following left of the decimal place. For example, a number group with\r\n   * goog.i18n.NumberFormat('#,##,###') should have [3,2] where 2 is the\r\n   * repeated number group following a fixed number grouping of size 3.\r\n   */\r\n  /** @private {!Array} */\r\n  this.groupingArray_ = [];\r\n```","created_at":"2015-09-14T22:40:39Z","updated_at":"2015-09-14T22:40:39Z","html_url":"https://github.com/google/closure-library/pull/335#discussion_r39456368","pull_request_url":"https://api.github.com/repos/google/closure-library/pulls/335","_links":{"self":{"href":"https://api.github.com/repos/google/closure-library/pulls/comments/39456368"},"html":{"href":"https://github.com/google/closure-library/pull/335#discussion_r39456368"},"pull_request":{"href":"https://api.github.com/repos/google/closure-library/pulls/335"}}},"pull_request":{"url":"https://api.github.com/repos/google/closure-library/pulls/335","id":20083256,"html_url":"https://github.com/google/closure-library/pull/335","diff_url":"https://github.com/google/closure-library/pull/335.diff","patch_url":"https://github.com/google/closure-library/pull/335.patch","issue_url":"https://api.github.com/repos/google/closure-library/issues/335","number":335,"state":"open","locked":false,"title":"Handle Multiple Number Groupings","user":{"login":"jvu","id":2966460,"avatar_url":"https://avatars.githubusercontent.com/u/2966460?v=3","gravatar_id":"","url":"https://api.github.com/users/jvu","html_url":"https://github.com/jvu","followers_url":"https://api.github.com/users/jvu/followers","following_url":"https://api.github.com/users/jvu/following{/other_user}","gists_url":"https://api.github.com/users/jvu/gists{/gist_id}","starred_url":"https://api.github.com/users/jvu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvu/subscriptions","organizations_url":"https://api.github.com/users/jvu/orgs","repos_url":"https://api.github.com/users/jvu/repos","events_url":"https://api.github.com/users/jvu/events{/privacy}","received_events_url":"https://api.github.com/users/jvu/received_events","type":"User","site_admin":false},"body":"Our Globalization Engineering team at PayPal found a bug that is affecting those in India. Since the number grouping \"#,##,###\" isn't supported, our team found it was necessary to put in a bit of time and development to support users in India. Please see <b>Indian comma placement</b> found under <a href=\"http://en.wikipedia.org/wiki/Indian_rupee\">Wikipedia's Indian rupee</a>.\r\n\r\nThe pull request includes code development and tests that supports (1) the Indian comma placement for the number grouping \"#,##,###\"; and (2) other future number groupings. The hope for (2) is that regardless of how absurd the number grouping might turn out, it will be supported in Google Closure.\r\n\r\nPlease contact me, <b>John Vu</b> at <a href=\"mailto:jovu@paypal.com\">jovu@paypal.com</a>, if you have any questions.\r\n\r\nP.S. This is my first time contributing to an open-source project so please let me know if there's anything else I should do aside from your <a href=\"https://github.com/google/closure-library/blob/master/CONTRIBUTING\">guidelines for contributing</a>.","created_at":"2014-08-21T00:20:12Z","updated_at":"2015-09-14T22:40:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee854be7921eaf2a95894797ff9adc5186680712","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/closure-library/pulls/335/commits","review_comments_url":"https://api.github.com/repos/google/closure-library/pulls/335/comments","review_comment_url":"https://api.github.com/repos/google/closure-library/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/closure-library/issues/335/comments","statuses_url":"https://api.github.com/repos/google/closure-library/statuses/b4d33dc2aabe08a545aa0b86e9650a583fd310bf","head":{"label":"jvu:master","ref":"master","sha":"b4d33dc2aabe08a545aa0b86e9650a583fd310bf","user":{"login":"jvu","id":2966460,"avatar_url":"https://avatars.githubusercontent.com/u/2966460?v=3","gravatar_id":"","url":"https://api.github.com/users/jvu","html_url":"https://github.com/jvu","followers_url":"https://api.github.com/users/jvu/followers","following_url":"https://api.github.com/users/jvu/following{/other_user}","gists_url":"https://api.github.com/users/jvu/gists{/gist_id}","starred_url":"https://api.github.com/users/jvu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvu/subscriptions","organizations_url":"https://api.github.com/users/jvu/orgs","repos_url":"https://api.github.com/users/jvu/repos","events_url":"https://api.github.com/users/jvu/events{/privacy}","received_events_url":"https://api.github.com/users/jvu/received_events","type":"User","site_admin":false},"repo":{"id":23130660,"name":"closure-library","full_name":"jvu/closure-library","owner":{"login":"jvu","id":2966460,"avatar_url":"https://avatars.githubusercontent.com/u/2966460?v=3","gravatar_id":"","url":"https://api.github.com/users/jvu","html_url":"https://github.com/jvu","followers_url":"https://api.github.com/users/jvu/followers","following_url":"https://api.github.com/users/jvu/following{/other_user}","gists_url":"https://api.github.com/users/jvu/gists{/gist_id}","starred_url":"https://api.github.com/users/jvu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvu/subscriptions","organizations_url":"https://api.github.com/users/jvu/orgs","repos_url":"https://api.github.com/users/jvu/repos","events_url":"https://api.github.com/users/jvu/events{/privacy}","received_events_url":"https://api.github.com/users/jvu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jvu/closure-library","description":"Google's common JavaScript library","fork":true,"url":"https://api.github.com/repos/jvu/closure-library","forks_url":"https://api.github.com/repos/jvu/closure-library/forks","keys_url":"https://api.github.com/repos/jvu/closure-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jvu/closure-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jvu/closure-library/teams","hooks_url":"https://api.github.com/repos/jvu/closure-library/hooks","issue_events_url":"https://api.github.com/repos/jvu/closure-library/issues/events{/number}","events_url":"https://api.github.com/repos/jvu/closure-library/events","assignees_url":"https://api.github.com/repos/jvu/closure-library/assignees{/user}","branches_url":"https://api.github.com/repos/jvu/closure-library/branches{/branch}","tags_url":"https://api.github.com/repos/jvu/closure-library/tags","blobs_url":"https://api.github.com/repos/jvu/closure-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jvu/closure-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jvu/closure-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/jvu/closure-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jvu/closure-library/statuses/{sha}","languages_url":"https://api.github.com/repos/jvu/closure-library/languages","stargazers_url":"https://api.github.com/repos/jvu/closure-library/stargazers","contributors_url":"https://api.github.com/repos/jvu/closure-library/contributors","subscribers_url":"https://api.github.com/repos/jvu/closure-library/subscribers","subscription_url":"https://api.github.com/repos/jvu/closure-library/subscription","commits_url":"https://api.github.com/repos/jvu/closure-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/jvu/closure-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/jvu/closure-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/jvu/closure-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/jvu/closure-library/contents/{+path}","compare_url":"https://api.github.com/repos/jvu/closure-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jvu/closure-library/merges","archive_url":"https://api.github.com/repos/jvu/closure-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jvu/closure-library/downloads","issues_url":"https://api.github.com/repos/jvu/closure-library/issues{/number}","pulls_url":"https://api.github.com/repos/jvu/closure-library/pulls{/number}","milestones_url":"https://api.github.com/repos/jvu/closure-library/milestones{/number}","notifications_url":"https://api.github.com/repos/jvu/closure-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jvu/closure-library/labels{/name}","releases_url":"https://api.github.com/repos/jvu/closure-library/releases{/id}","created_at":"2014-08-20T00:41:48Z","updated_at":"2015-05-08T06:47:11Z","pushed_at":"2015-09-14T22:28:48Z","git_url":"git://github.com/jvu/closure-library.git","ssh_url":"git@github.com:jvu/closure-library.git","clone_url":"https://github.com/jvu/closure-library.git","svn_url":"https://github.com/jvu/closure-library","homepage":"code.google.com/closure/library/","size":38083,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"2149d4aaf7fc1534ba7cc7fa0029742fa14e070f","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":12169108,"name":"closure-library","full_name":"google/closure-library","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/closure-library","description":"Google's common JavaScript library","fork":false,"url":"https://api.github.com/repos/google/closure-library","forks_url":"https://api.github.com/repos/google/closure-library/forks","keys_url":"https://api.github.com/repos/google/closure-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/closure-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/closure-library/teams","hooks_url":"https://api.github.com/repos/google/closure-library/hooks","issue_events_url":"https://api.github.com/repos/google/closure-library/issues/events{/number}","events_url":"https://api.github.com/repos/google/closure-library/events","assignees_url":"https://api.github.com/repos/google/closure-library/assignees{/user}","branches_url":"https://api.github.com/repos/google/closure-library/branches{/branch}","tags_url":"https://api.github.com/repos/google/closure-library/tags","blobs_url":"https://api.github.com/repos/google/closure-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/closure-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/closure-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/closure-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/closure-library/statuses/{sha}","languages_url":"https://api.github.com/repos/google/closure-library/languages","stargazers_url":"https://api.github.com/repos/google/closure-library/stargazers","contributors_url":"https://api.github.com/repos/google/closure-library/contributors","subscribers_url":"https://api.github.com/repos/google/closure-library/subscribers","subscription_url":"https://api.github.com/repos/google/closure-library/subscription","commits_url":"https://api.github.com/repos/google/closure-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/closure-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/closure-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/closure-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/closure-library/contents/{+path}","compare_url":"https://api.github.com/repos/google/closure-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/closure-library/merges","archive_url":"https://api.github.com/repos/google/closure-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/closure-library/downloads","issues_url":"https://api.github.com/repos/google/closure-library/issues{/number}","pulls_url":"https://api.github.com/repos/google/closure-library/pulls{/number}","milestones_url":"https://api.github.com/repos/google/closure-library/milestones{/number}","notifications_url":"https://api.github.com/repos/google/closure-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/closure-library/labels{/name}","releases_url":"https://api.github.com/repos/google/closure-library/releases{/id}","created_at":"2013-08-16T21:54:05Z","updated_at":"2015-09-13T13:25:17Z","pushed_at":"2015-09-14T22:28:50Z","git_url":"git://github.com/google/closure-library.git","ssh_url":"git@github.com:google/closure-library.git","clone_url":"https://github.com/google/closure-library.git","svn_url":"https://github.com/google/closure-library","homepage":"code.google.com/closure/library/","size":56348,"stargazers_count":1109,"watchers_count":1109,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":360,"mirror_url":null,"open_issues_count":142,"forks":360,"open_issues":142,"watchers":1109,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/closure-library/pulls/335"},"html":{"href":"https://github.com/google/closure-library/pull/335"},"issue":{"href":"https://api.github.com/repos/google/closure-library/issues/335"},"comments":{"href":"https://api.github.com/repos/google/closure-library/issues/335/comments"},"review_comments":{"href":"https://api.github.com/repos/google/closure-library/pulls/335/comments"},"review_comment":{"href":"https://api.github.com/repos/google/closure-library/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/closure-library/pulls/335/commits"},"statuses":{"href":"https://api.github.com/repos/google/closure-library/statuses/b4d33dc2aabe08a545aa0b86e9650a583fd310bf"}}}}