{"action":"created","issue":{"url":"https://api.github.com/repos/e-conomic/phantom-render-stream/issues/48","labels_url":"https://api.github.com/repos/e-conomic/phantom-render-stream/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/e-conomic/phantom-render-stream/issues/48/comments","events_url":"https://api.github.com/repos/e-conomic/phantom-render-stream/issues/48/events","html_url":"https://github.com/e-conomic/phantom-render-stream/pull/48","id":38950061,"number":48,"title":"Fix hardcoded timeout value affecting renders taking longer than 10 seconds, but less then `timeout`.","user":{"login":"markstos","id":25829,"avatar_url":"https://avatars.githubusercontent.com/u/25829?v=3","gravatar_id":"","url":"https://api.github.com/users/markstos","html_url":"https://github.com/markstos","followers_url":"https://api.github.com/users/markstos/followers","following_url":"https://api.github.com/users/markstos/following{/other_user}","gists_url":"https://api.github.com/users/markstos/gists{/gist_id}","starred_url":"https://api.github.com/users/markstos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markstos/subscriptions","organizations_url":"https://api.github.com/users/markstos/orgs","repos_url":"https://api.github.com/users/markstos/repos","events_url":"https://api.github.com/users/markstos/events{/privacy}","received_events_url":"https://api.github.com/users/markstos/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2014-07-29T01:14:15Z","updated_at":"2015-01-28T14:07:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/e-conomic/phantom-render-stream/pulls/48","html_url":"https://github.com/e-conomic/phantom-render-stream/pull/48","diff_url":"https://github.com/e-conomic/phantom-render-stream/pull/48.diff","patch_url":"https://github.com/e-conomic/phantom-render-stream/pull/48.patch"},"body":"There are additional commits here as this work built on other work:\r\n\r\n * I also ended up fixing a bug that I found in-process which is that `expects` is documented as something that can be passed to `phantom` as well as `render`, but that wasn't actually working. I added new test coverage to illustrate that.\r\n* That detour in turn built on some other clean-up work I did, including addressing an issue where the tmp file names weren't been generated consistently. In one place they included in the PID, but not in the other, now they consistently include the PID.\r\n* The changes above built on the work to improve the handling options in general, so those commits are included. \r\n* New test coverage for the longer-than-10-seconds render issue is also included. \r\n\r\nThe fix includes using the same `timeout` option for the render timeout as well as the general phantom timeout. This is simpler than having two timeout values and might well be sufficient, so it's try it out. \r\n\r\nSee the commit messages for more detail. I tried to make smaller commits with clear messages to you could see the detail of what was going on. I do see some typos in my commit messages where I meant \"simplify\" but typed \"simply\" instead. "},"comment":{"url":"https://api.github.com/repos/e-conomic/phantom-render-stream/issues/comments/71839513","html_url":"https://github.com/e-conomic/phantom-render-stream/pull/48#issuecomment-71839513","issue_url":"https://api.github.com/repos/e-conomic/phantom-render-stream/issues/48","id":71839513,"user":{"login":"markstos","id":25829,"avatar_url":"https://avatars.githubusercontent.com/u/25829?v=3","gravatar_id":"","url":"https://api.github.com/users/markstos","html_url":"https://github.com/markstos","followers_url":"https://api.github.com/users/markstos/followers","following_url":"https://api.github.com/users/markstos/following{/other_user}","gists_url":"https://api.github.com/users/markstos/gists{/gist_id}","starred_url":"https://api.github.com/users/markstos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markstos/subscriptions","organizations_url":"https://api.github.com/users/markstos/orgs","repos_url":"https://api.github.com/users/markstos/repos","events_url":"https://api.github.com/users/markstos/events{/privacy}","received_events_url":"https://api.github.com/users/markstos/received_events","type":"User","site_admin":false},"created_at":"2015-01-28T14:07:25Z","updated_at":"2015-01-28T14:07:25Z","body":"@sorribas I submitted this pull request over six months ago. Is there any sense of when it might be reviewed or rejected?"}}