{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Configuration/pulls/comments/40166258","id":40166258,"diff_hunk":"@@ -10,18 +10,13 @@ public static class ConfigurationHelper\n     {\n         public static string ResolveConfigurationFilePath(IConfigurationBuilder configuration, string path)\n         {\n-            if (!Path.IsPathRooted(path))\n+            if (configuration.Properties.ContainsKey(\"BasePath\"))\n             {\n-                if (configuration.BasePath == null)\n-                {\n-                    throw new InvalidOperationException(Resources.FormatError_MissingBasePath(\n-                        path,\n-                        typeof(IConfigurationBuilder).Name,\n-                        nameof(configuration.BasePath)));\n-                }\n-                else\n+                string basePath = configuration.Properties[\"BasePath\"].ToString();","path":"src/Microsoft.Framework.Configuration.File/Helper/ConfigurationHelper.cs","position":15,"original_position":15,"commit_id":"99a80f9fff34b0aca6bf31b91f4721214a233235","original_commit_id":"99a80f9fff34b0aca6bf31b91f4721214a233235","user":{"login":"lodejard","id":1693989,"avatar_url":"https://avatars.githubusercontent.com/u/1693989?v=3","gravatar_id":"","url":"https://api.github.com/users/lodejard","html_url":"https://github.com/lodejard","followers_url":"https://api.github.com/users/lodejard/followers","following_url":"https://api.github.com/users/lodejard/following{/other_user}","gists_url":"https://api.github.com/users/lodejard/gists{/gist_id}","starred_url":"https://api.github.com/users/lodejard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lodejard/subscriptions","organizations_url":"https://api.github.com/users/lodejard/orgs","repos_url":"https://api.github.com/users/lodejard/repos","events_url":"https://api.github.com/users/lodejard/events{/privacy}","received_events_url":"https://api.github.com/users/lodejard/received_events","type":"User","site_admin":false},"body":"Call TryGet instead of ContainsKey, then `(string)` case like @divega mentioned","created_at":"2015-09-23T02:34:19Z","updated_at":"2015-09-23T02:34:19Z","html_url":"https://github.com/aspnet/Configuration/pull/293#discussion_r40166258","pull_request_url":"https://api.github.com/repos/aspnet/Configuration/pulls/293","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Configuration/pulls/comments/40166258"},"html":{"href":"https://github.com/aspnet/Configuration/pull/293#discussion_r40166258"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Configuration/pulls/293"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Configuration/pulls/293","id":45587882,"html_url":"https://github.com/aspnet/Configuration/pull/293","diff_url":"https://github.com/aspnet/Configuration/pull/293.diff","patch_url":"https://github.com/aspnet/Configuration/pull/293.patch","issue_url":"https://api.github.com/repos/aspnet/Configuration/issues/293","number":293,"state":"open","locked":false,"title":"Get rid of BasePath on IConfigurationBuilder","user":{"login":"kirthik","id":1267650,"avatar_url":"https://avatars.githubusercontent.com/u/1267650?v=3","gravatar_id":"","url":"https://api.github.com/users/kirthik","html_url":"https://github.com/kirthik","followers_url":"https://api.github.com/users/kirthik/followers","following_url":"https://api.github.com/users/kirthik/following{/other_user}","gists_url":"https://api.github.com/users/kirthik/gists{/gist_id}","starred_url":"https://api.github.com/users/kirthik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirthik/subscriptions","organizations_url":"https://api.github.com/users/kirthik/orgs","repos_url":"https://api.github.com/users/kirthik/repos","events_url":"https://api.github.com/users/kirthik/events{/privacy}","received_events_url":"https://api.github.com/users/kirthik/received_events","type":"User","site_admin":false},"body":"cc @divega ","created_at":"2015-09-21T19:17:29Z","updated_at":"2015-09-23T02:34:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f64529101987475d73cefd77f4efb8505c035bcb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Configuration/pulls/293/commits","review_comments_url":"https://api.github.com/repos/aspnet/Configuration/pulls/293/comments","review_comment_url":"https://api.github.com/repos/aspnet/Configuration/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Configuration/issues/293/comments","statuses_url":"https://api.github.com/repos/aspnet/Configuration/statuses/99a80f9fff34b0aca6bf31b91f4721214a233235","head":{"label":"aspnet:fix233","ref":"fix233","sha":"99a80f9fff34b0aca6bf31b91f4721214a233235","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":16329342,"name":"Configuration","full_name":"aspnet/Configuration","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Configuration","description":"Interfaces and providers for accessing simple config files.","fork":false,"url":"https://api.github.com/repos/aspnet/Configuration","forks_url":"https://api.github.com/repos/aspnet/Configuration/forks","keys_url":"https://api.github.com/repos/aspnet/Configuration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Configuration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Configuration/teams","hooks_url":"https://api.github.com/repos/aspnet/Configuration/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Configuration/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Configuration/events","assignees_url":"https://api.github.com/repos/aspnet/Configuration/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Configuration/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Configuration/tags","blobs_url":"https://api.github.com/repos/aspnet/Configuration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Configuration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Configuration/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Configuration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Configuration/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Configuration/languages","stargazers_url":"https://api.github.com/repos/aspnet/Configuration/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Configuration/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Configuration/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Configuration/subscription","commits_url":"https://api.github.com/repos/aspnet/Configuration/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Configuration/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Configuration/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Configuration/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Configuration/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Configuration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Configuration/merges","archive_url":"https://api.github.com/repos/aspnet/Configuration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Configuration/downloads","issues_url":"https://api.github.com/repos/aspnet/Configuration/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Configuration/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Configuration/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Configuration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Configuration/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Configuration/releases{/id}","created_at":"2014-01-28T23:11:33Z","updated_at":"2015-09-22T15:45:22Z","pushed_at":"2015-09-22T17:45:59Z","git_url":"git://github.com/aspnet/Configuration.git","ssh_url":"git@github.com:aspnet/Configuration.git","clone_url":"https://github.com/aspnet/Configuration.git","svn_url":"https://github.com/aspnet/Configuration","homepage":"","size":3136,"stargazers_count":98,"watchers_count":98,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":32,"forks":47,"open_issues":32,"watchers":98,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"f4b65289061c18ead783e78ef6b6e6716b91b2a4","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":16329342,"name":"Configuration","full_name":"aspnet/Configuration","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Configuration","description":"Interfaces and providers for accessing simple config files.","fork":false,"url":"https://api.github.com/repos/aspnet/Configuration","forks_url":"https://api.github.com/repos/aspnet/Configuration/forks","keys_url":"https://api.github.com/repos/aspnet/Configuration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Configuration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Configuration/teams","hooks_url":"https://api.github.com/repos/aspnet/Configuration/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Configuration/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Configuration/events","assignees_url":"https://api.github.com/repos/aspnet/Configuration/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Configuration/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Configuration/tags","blobs_url":"https://api.github.com/repos/aspnet/Configuration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Configuration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Configuration/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Configuration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Configuration/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Configuration/languages","stargazers_url":"https://api.github.com/repos/aspnet/Configuration/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Configuration/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Configuration/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Configuration/subscription","commits_url":"https://api.github.com/repos/aspnet/Configuration/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Configuration/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Configuration/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Configuration/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Configuration/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Configuration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Configuration/merges","archive_url":"https://api.github.com/repos/aspnet/Configuration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Configuration/downloads","issues_url":"https://api.github.com/repos/aspnet/Configuration/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Configuration/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Configuration/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Configuration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Configuration/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Configuration/releases{/id}","created_at":"2014-01-28T23:11:33Z","updated_at":"2015-09-22T15:45:22Z","pushed_at":"2015-09-22T17:45:59Z","git_url":"git://github.com/aspnet/Configuration.git","ssh_url":"git@github.com:aspnet/Configuration.git","clone_url":"https://github.com/aspnet/Configuration.git","svn_url":"https://github.com/aspnet/Configuration","homepage":"","size":3136,"stargazers_count":98,"watchers_count":98,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":32,"forks":47,"open_issues":32,"watchers":98,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Configuration/pulls/293"},"html":{"href":"https://github.com/aspnet/Configuration/pull/293"},"issue":{"href":"https://api.github.com/repos/aspnet/Configuration/issues/293"},"comments":{"href":"https://api.github.com/repos/aspnet/Configuration/issues/293/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Configuration/pulls/293/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Configuration/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Configuration/pulls/293/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Configuration/statuses/99a80f9fff34b0aca6bf31b91f4721214a233235"}}}}