{"action":"created","issue":{"url":"https://api.github.com/repos/VSoftTechnologies/Delphi-Mocks/issues/71","labels_url":"https://api.github.com/repos/VSoftTechnologies/Delphi-Mocks/issues/71/labels{/name}","comments_url":"https://api.github.com/repos/VSoftTechnologies/Delphi-Mocks/issues/71/comments","events_url":"https://api.github.com/repos/VSoftTechnologies/Delphi-Mocks/issues/71/events","html_url":"https://github.com/VSoftTechnologies/Delphi-Mocks/pull/71","id":102887325,"number":71,"title":"TValue support for ole variant and Variant array of Variant","user":{"login":"MartinSedgewick","id":5257040,"avatar_url":"https://avatars.githubusercontent.com/u/5257040?v=3","gravatar_id":"","url":"https://api.github.com/users/MartinSedgewick","html_url":"https://github.com/MartinSedgewick","followers_url":"https://api.github.com/users/MartinSedgewick/followers","following_url":"https://api.github.com/users/MartinSedgewick/following{/other_user}","gists_url":"https://api.github.com/users/MartinSedgewick/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinSedgewick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinSedgewick/subscriptions","organizations_url":"https://api.github.com/users/MartinSedgewick/orgs","repos_url":"https://api.github.com/users/MartinSedgewick/repos","events_url":"https://api.github.com/users/MartinSedgewick/events{/privacy}","received_events_url":"https://api.github.com/users/MartinSedgewick/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-08-24T20:44:06Z","updated_at":"2015-09-23T12:12:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/VSoftTechnologies/Delphi-Mocks/pulls/71","html_url":"https://github.com/VSoftTechnologies/Delphi-Mocks/pull/71","diff_url":"https://github.com/VSoftTechnologies/Delphi-Mocks/pull/71.diff","patch_url":"https://github.com/VSoftTechnologies/Delphi-Mocks/pull/71.patch"},"body":"I could not get TValue.FromVariant to support variant array of variants. \r\n\r\nTo work with this, you need to set TValue using TValue.From<Variant>(myvar)\r\n\r\nThe rest is now supported in SameValue using a SameVariant function to try and determine a comparison on the Left/Right Variants if they are arrays"},"comment":{"url":"https://api.github.com/repos/VSoftTechnologies/Delphi-Mocks/issues/comments/142581059","html_url":"https://github.com/VSoftTechnologies/Delphi-Mocks/pull/71#issuecomment-142581059","issue_url":"https://api.github.com/repos/VSoftTechnologies/Delphi-Mocks/issues/71","id":142581059,"user":{"login":"sglienke","id":6238697,"avatar_url":"https://avatars.githubusercontent.com/u/6238697?v=3","gravatar_id":"","url":"https://api.github.com/users/sglienke","html_url":"https://github.com/sglienke","followers_url":"https://api.github.com/users/sglienke/followers","following_url":"https://api.github.com/users/sglienke/following{/other_user}","gists_url":"https://api.github.com/users/sglienke/gists{/gist_id}","starred_url":"https://api.github.com/users/sglienke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sglienke/subscriptions","organizations_url":"https://api.github.com/users/sglienke/orgs","repos_url":"https://api.github.com/users/sglienke/repos","events_url":"https://api.github.com/users/sglienke/events{/privacy}","received_events_url":"https://api.github.com/users/sglienke/received_events","type":"User","site_admin":false},"created_at":"2015-09-23T12:12:02Z","updated_at":"2015-09-23T12:12:02Z","body":"Actually most of the tests are wrong since they use FromVariant to fill the TValue. FromVariant looks into the varType and then converts that into TValue holding whats inside the Variant rather than the variant itself. So for example the test Test_TValue_Equals_Variants will never hit the SameVariant function since the TValue are holding a tkUString and not a tkVariant. To really put the Variant inside the TValue you must use TValue.From."}}