{"action":"closed","number":131,"pull_request":{"url":"https://api.github.com/repos/shinnlok/liferay-portal/pulls/131","id":43869734,"html_url":"https://github.com/shinnlok/liferay-portal/pull/131","diff_url":"https://github.com/shinnlok/liferay-portal/pull/131.diff","patch_url":"https://github.com/shinnlok/liferay-portal/pull/131.patch","issue_url":"https://api.github.com/repos/shinnlok/liferay-portal/issues/131","number":131,"state":"closed","locked":false,"title":"LPS-58294","user":{"login":"jcampoy","id":2361190,"avatar_url":"https://avatars.githubusercontent.com/u/2361190?v=3","gravatar_id":"","url":"https://api.github.com/users/jcampoy","html_url":"https://github.com/jcampoy","followers_url":"https://api.github.com/users/jcampoy/followers","following_url":"https://api.github.com/users/jcampoy/following{/other_user}","gists_url":"https://api.github.com/users/jcampoy/gists{/gist_id}","starred_url":"https://api.github.com/users/jcampoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcampoy/subscriptions","organizations_url":"https://api.github.com/users/jcampoy/orgs","repos_url":"https://api.github.com/users/jcampoy/repos","events_url":"https://api.github.com/users/jcampoy/events{/privacy}","received_events_url":"https://api.github.com/users/jcampoy/received_events","type":"User","site_admin":false},"body":"Hi Shinn, could you review this fix? the problem is only related with oracle db because we are transforming all varchar(n) to varchar2(n char) in the method OracleDB.replaceTemplate and this breaks the login of buildColumnTypeTokens. Let me know if you have any question. Thx! ","created_at":"2015-09-01T12:32:16Z","updated_at":"2015-09-01T22:35:57Z","closed_at":"2015-09-01T22:35:57Z","merged_at":null,"merge_commit_sha":"527e220dc48be7d83784cfeb4c398682e77764f7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/shinnlok/liferay-portal/pulls/131/commits","review_comments_url":"https://api.github.com/repos/shinnlok/liferay-portal/pulls/131/comments","review_comment_url":"https://api.github.com/repos/shinnlok/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shinnlok/liferay-portal/issues/131/comments","statuses_url":"https://api.github.com/repos/shinnlok/liferay-portal/statuses/c04696c4f7e0af9e52d113dfc6d097679844b963","head":{"label":"jcampoy:LPS-58294","ref":"LPS-58294","sha":"c04696c4f7e0af9e52d113dfc6d097679844b963","user":{"login":"jcampoy","id":2361190,"avatar_url":"https://avatars.githubusercontent.com/u/2361190?v=3","gravatar_id":"","url":"https://api.github.com/users/jcampoy","html_url":"https://github.com/jcampoy","followers_url":"https://api.github.com/users/jcampoy/followers","following_url":"https://api.github.com/users/jcampoy/following{/other_user}","gists_url":"https://api.github.com/users/jcampoy/gists{/gist_id}","starred_url":"https://api.github.com/users/jcampoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcampoy/subscriptions","organizations_url":"https://api.github.com/users/jcampoy/orgs","repos_url":"https://api.github.com/users/jcampoy/repos","events_url":"https://api.github.com/users/jcampoy/events{/privacy}","received_events_url":"https://api.github.com/users/jcampoy/received_events","type":"User","site_admin":false},"repo":{"id":5841611,"name":"liferay-portal","full_name":"jcampoy/liferay-portal","owner":{"login":"jcampoy","id":2361190,"avatar_url":"https://avatars.githubusercontent.com/u/2361190?v=3","gravatar_id":"","url":"https://api.github.com/users/jcampoy","html_url":"https://github.com/jcampoy","followers_url":"https://api.github.com/users/jcampoy/followers","following_url":"https://api.github.com/users/jcampoy/following{/other_user}","gists_url":"https://api.github.com/users/jcampoy/gists{/gist_id}","starred_url":"https://api.github.com/users/jcampoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcampoy/subscriptions","organizations_url":"https://api.github.com/users/jcampoy/orgs","repos_url":"https://api.github.com/users/jcampoy/repos","events_url":"https://api.github.com/users/jcampoy/events{/privacy}","received_events_url":"https://api.github.com/users/jcampoy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcampoy/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/jcampoy/liferay-portal","forks_url":"https://api.github.com/repos/jcampoy/liferay-portal/forks","keys_url":"https://api.github.com/repos/jcampoy/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcampoy/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcampoy/liferay-portal/teams","hooks_url":"https://api.github.com/repos/jcampoy/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/jcampoy/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/jcampoy/liferay-portal/events","assignees_url":"https://api.github.com/repos/jcampoy/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/jcampoy/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/jcampoy/liferay-portal/tags","blobs_url":"https://api.github.com/repos/jcampoy/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcampoy/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcampoy/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcampoy/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcampoy/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/jcampoy/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/jcampoy/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/jcampoy/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/jcampoy/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/jcampoy/liferay-portal/subscription","commits_url":"https://api.github.com/repos/jcampoy/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcampoy/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcampoy/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcampoy/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcampoy/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/jcampoy/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcampoy/liferay-portal/merges","archive_url":"https://api.github.com/repos/jcampoy/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcampoy/liferay-portal/downloads","issues_url":"https://api.github.com/repos/jcampoy/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/jcampoy/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/jcampoy/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/jcampoy/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcampoy/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/jcampoy/liferay-portal/releases{/id}","created_at":"2012-09-17T13:47:00Z","updated_at":"2014-05-23T10:00:30Z","pushed_at":"2015-09-01T15:13:08Z","git_url":"git://github.com/jcampoy/liferay-portal.git","ssh_url":"git@github.com:jcampoy/liferay-portal.git","clone_url":"https://github.com/jcampoy/liferay-portal.git","svn_url":"https://github.com/jcampoy/liferay-portal","homepage":"http://liferay.com","size":4873115,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"shinnlok:master","ref":"master","sha":"e82a22683774b3ab4bf5b4813bfd3f94d168e8d7","user":{"login":"shinnlok","id":860730,"avatar_url":"https://avatars.githubusercontent.com/u/860730?v=3","gravatar_id":"","url":"https://api.github.com/users/shinnlok","html_url":"https://github.com/shinnlok","followers_url":"https://api.github.com/users/shinnlok/followers","following_url":"https://api.github.com/users/shinnlok/following{/other_user}","gists_url":"https://api.github.com/users/shinnlok/gists{/gist_id}","starred_url":"https://api.github.com/users/shinnlok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shinnlok/subscriptions","organizations_url":"https://api.github.com/users/shinnlok/orgs","repos_url":"https://api.github.com/users/shinnlok/repos","events_url":"https://api.github.com/users/shinnlok/events{/privacy}","received_events_url":"https://api.github.com/users/shinnlok/received_events","type":"User","site_admin":false},"repo":{"id":8759466,"name":"liferay-portal","full_name":"shinnlok/liferay-portal","owner":{"login":"shinnlok","id":860730,"avatar_url":"https://avatars.githubusercontent.com/u/860730?v=3","gravatar_id":"","url":"https://api.github.com/users/shinnlok","html_url":"https://github.com/shinnlok","followers_url":"https://api.github.com/users/shinnlok/followers","following_url":"https://api.github.com/users/shinnlok/following{/other_user}","gists_url":"https://api.github.com/users/shinnlok/gists{/gist_id}","starred_url":"https://api.github.com/users/shinnlok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shinnlok/subscriptions","organizations_url":"https://api.github.com/users/shinnlok/orgs","repos_url":"https://api.github.com/users/shinnlok/repos","events_url":"https://api.github.com/users/shinnlok/events{/privacy}","received_events_url":"https://api.github.com/users/shinnlok/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shinnlok/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/shinnlok/liferay-portal","forks_url":"https://api.github.com/repos/shinnlok/liferay-portal/forks","keys_url":"https://api.github.com/repos/shinnlok/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shinnlok/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shinnlok/liferay-portal/teams","hooks_url":"https://api.github.com/repos/shinnlok/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/shinnlok/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/shinnlok/liferay-portal/events","assignees_url":"https://api.github.com/repos/shinnlok/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/shinnlok/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/shinnlok/liferay-portal/tags","blobs_url":"https://api.github.com/repos/shinnlok/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shinnlok/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shinnlok/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/shinnlok/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shinnlok/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/shinnlok/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/shinnlok/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/shinnlok/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/shinnlok/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/shinnlok/liferay-portal/subscription","commits_url":"https://api.github.com/repos/shinnlok/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/shinnlok/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/shinnlok/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/shinnlok/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/shinnlok/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/shinnlok/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shinnlok/liferay-portal/merges","archive_url":"https://api.github.com/repos/shinnlok/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shinnlok/liferay-portal/downloads","issues_url":"https://api.github.com/repos/shinnlok/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/shinnlok/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/shinnlok/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/shinnlok/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shinnlok/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/shinnlok/liferay-portal/releases{/id}","created_at":"2013-03-13T19:11:54Z","updated_at":"2015-04-28T07:35:11Z","pushed_at":"2015-09-01T22:35:01Z","git_url":"git://github.com/shinnlok/liferay-portal.git","ssh_url":"git@github.com:shinnlok/liferay-portal.git","clone_url":"https://github.com/shinnlok/liferay-portal.git","svn_url":"https://github.com/shinnlok/liferay-portal","homepage":"http://liferay.com","size":4912648,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shinnlok/liferay-portal/pulls/131"},"html":{"href":"https://github.com/shinnlok/liferay-portal/pull/131"},"issue":{"href":"https://api.github.com/repos/shinnlok/liferay-portal/issues/131"},"comments":{"href":"https://api.github.com/repos/shinnlok/liferay-portal/issues/131/comments"},"review_comments":{"href":"https://api.github.com/repos/shinnlok/liferay-portal/pulls/131/comments"},"review_comment":{"href":"https://api.github.com/repos/shinnlok/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shinnlok/liferay-portal/pulls/131/commits"},"statuses":{"href":"https://api.github.com/repos/shinnlok/liferay-portal/statuses/c04696c4f7e0af9e52d113dfc6d097679844b963"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":2775,"additions":4398,"deletions":143,"changed_files":16074}}