{"action":"created","comment":{"url":"https://api.github.com/repos/junit-team/junit/pulls/comments/30750995","id":30750995,"diff_hunk":"@@ -122,6 +123,15 @@ public void testAssumptionFailure(Failure failure) {\n     public void testIgnored(Description description) throws Exception {\n     }\n \n+    /**\n+     * Called when some services loaded using {@link org.junit.internal.ServiceLoaderWrapper}\n+     * @param serviceType a type of the loaded services\n+     * @param services loaded services\n+     *\n+     * @since 4.12\n+     */\n+    public <T> void servicesLoaded(Class<T> serviceType, List<T> services) {\n+    }","path":"src/main/java/org/junit/runner/notification/RunListener.java","position":20,"original_position":20,"commit_id":"94de4df4d60e21c7504f6b88176d5dfbdbb980dd","original_commit_id":"94de4df4d60e21c7504f6b88176d5dfbdbb980dd","user":{"login":"marcphilipp","id":214207,"avatar_url":"https://avatars.githubusercontent.com/u/214207?v=3","gravatar_id":"","url":"https://api.github.com/users/marcphilipp","html_url":"https://github.com/marcphilipp","followers_url":"https://api.github.com/users/marcphilipp/followers","following_url":"https://api.github.com/users/marcphilipp/following{/other_user}","gists_url":"https://api.github.com/users/marcphilipp/gists{/gist_id}","starred_url":"https://api.github.com/users/marcphilipp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcphilipp/subscriptions","organizations_url":"https://api.github.com/users/marcphilipp/orgs","repos_url":"https://api.github.com/users/marcphilipp/repos","events_url":"https://api.github.com/users/marcphilipp/events{/privacy}","received_events_url":"https://api.github.com/users/marcphilipp/received_events","type":"User","site_admin":false},"body":"It feels a bit strange to me to have RunListeners notified of new RunListeners. What do you think?","created_at":"2015-05-20T21:23:33Z","updated_at":"2015-05-20T21:23:33Z","html_url":"https://github.com/junit-team/junit/pull/1122#discussion_r30750995","pull_request_url":"https://api.github.com/repos/junit-team/junit/pulls/1122","_links":{"self":{"href":"https://api.github.com/repos/junit-team/junit/pulls/comments/30750995"},"html":{"href":"https://github.com/junit-team/junit/pull/1122#discussion_r30750995"},"pull_request":{"href":"https://api.github.com/repos/junit-team/junit/pulls/1122"}}},"pull_request":{"url":"https://api.github.com/repos/junit-team/junit/pulls/1122","id":32910218,"html_url":"https://github.com/junit-team/junit/pull/1122","diff_url":"https://github.com/junit-team/junit/pull/1122.diff","patch_url":"https://github.com/junit-team/junit/pull/1122.patch","issue_url":"https://api.github.com/repos/junit-team/junit/issues/1122","number":1122,"state":"open","locked":false,"title":"Provide ability to add RunListeners using SPI (#80)","user":{"login":"baev","id":2149631,"avatar_url":"https://avatars.githubusercontent.com/u/2149631?v=3","gravatar_id":"","url":"https://api.github.com/users/baev","html_url":"https://github.com/baev","followers_url":"https://api.github.com/users/baev/followers","following_url":"https://api.github.com/users/baev/following{/other_user}","gists_url":"https://api.github.com/users/baev/gists{/gist_id}","starred_url":"https://api.github.com/users/baev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baev/subscriptions","organizations_url":"https://api.github.com/users/baev/orgs","repos_url":"https://api.github.com/users/baev/repos","events_url":"https://api.github.com/users/baev/events{/privacy}","received_events_url":"https://api.github.com/users/baev/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-04-08T22:51:27Z","updated_at":"2015-05-20T21:23:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1cb7c76342a4554b34ba5ce752fb8c0f4118faf","assignee":null,"milestone":{"url":"https://api.github.com/repos/junit-team/junit/milestones/4","html_url":"https://github.com/junit-team/junit/milestones/5.0","labels_url":"https://api.github.com/repos/junit-team/junit/milestones/4/labels","id":774513,"number":4,"title":"5.0","description":"Scheduled for next major version of JUnit. Use this if the change would require changes that are incompatible with JUnit 4.11","creator":{"login":"kcooney","id":478190,"avatar_url":"https://avatars.githubusercontent.com/u/478190?v=3","gravatar_id":"","url":"https://api.github.com/users/kcooney","html_url":"https://github.com/kcooney","followers_url":"https://api.github.com/users/kcooney/followers","following_url":"https://api.github.com/users/kcooney/following{/other_user}","gists_url":"https://api.github.com/users/kcooney/gists{/gist_id}","starred_url":"https://api.github.com/users/kcooney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kcooney/subscriptions","organizations_url":"https://api.github.com/users/kcooney/orgs","repos_url":"https://api.github.com/users/kcooney/repos","events_url":"https://api.github.com/users/kcooney/events{/privacy}","received_events_url":"https://api.github.com/users/kcooney/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":7,"state":"open","created_at":"2014-09-01T22:11:36Z","updated_at":"2015-04-23T07:24:39Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/junit-team/junit/pulls/1122/commits","review_comments_url":"https://api.github.com/repos/junit-team/junit/pulls/1122/comments","review_comment_url":"https://api.github.com/repos/junit-team/junit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/junit-team/junit/issues/1122/comments","statuses_url":"https://api.github.com/repos/junit-team/junit/statuses/94de4df4d60e21c7504f6b88176d5dfbdbb980dd","head":{"label":"baev:spi-run-listeners","ref":"spi-run-listeners","sha":"94de4df4d60e21c7504f6b88176d5dfbdbb980dd","user":{"login":"baev","id":2149631,"avatar_url":"https://avatars.githubusercontent.com/u/2149631?v=3","gravatar_id":"","url":"https://api.github.com/users/baev","html_url":"https://github.com/baev","followers_url":"https://api.github.com/users/baev/followers","following_url":"https://api.github.com/users/baev/following{/other_user}","gists_url":"https://api.github.com/users/baev/gists{/gist_id}","starred_url":"https://api.github.com/users/baev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baev/subscriptions","organizations_url":"https://api.github.com/users/baev/orgs","repos_url":"https://api.github.com/users/baev/repos","events_url":"https://api.github.com/users/baev/events{/privacy}","received_events_url":"https://api.github.com/users/baev/received_events","type":"User","site_admin":false},"repo":{"id":19407415,"name":"junit","full_name":"baev/junit","owner":{"login":"baev","id":2149631,"avatar_url":"https://avatars.githubusercontent.com/u/2149631?v=3","gravatar_id":"","url":"https://api.github.com/users/baev","html_url":"https://github.com/baev","followers_url":"https://api.github.com/users/baev/followers","following_url":"https://api.github.com/users/baev/following{/other_user}","gists_url":"https://api.github.com/users/baev/gists{/gist_id}","starred_url":"https://api.github.com/users/baev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baev/subscriptions","organizations_url":"https://api.github.com/users/baev/orgs","repos_url":"https://api.github.com/users/baev/repos","events_url":"https://api.github.com/users/baev/events{/privacy}","received_events_url":"https://api.github.com/users/baev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/baev/junit","description":"A programmer-oriented testing framework for Java.","fork":true,"url":"https://api.github.com/repos/baev/junit","forks_url":"https://api.github.com/repos/baev/junit/forks","keys_url":"https://api.github.com/repos/baev/junit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/baev/junit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/baev/junit/teams","hooks_url":"https://api.github.com/repos/baev/junit/hooks","issue_events_url":"https://api.github.com/repos/baev/junit/issues/events{/number}","events_url":"https://api.github.com/repos/baev/junit/events","assignees_url":"https://api.github.com/repos/baev/junit/assignees{/user}","branches_url":"https://api.github.com/repos/baev/junit/branches{/branch}","tags_url":"https://api.github.com/repos/baev/junit/tags","blobs_url":"https://api.github.com/repos/baev/junit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/baev/junit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/baev/junit/git/refs{/sha}","trees_url":"https://api.github.com/repos/baev/junit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/baev/junit/statuses/{sha}","languages_url":"https://api.github.com/repos/baev/junit/languages","stargazers_url":"https://api.github.com/repos/baev/junit/stargazers","contributors_url":"https://api.github.com/repos/baev/junit/contributors","subscribers_url":"https://api.github.com/repos/baev/junit/subscribers","subscription_url":"https://api.github.com/repos/baev/junit/subscription","commits_url":"https://api.github.com/repos/baev/junit/commits{/sha}","git_commits_url":"https://api.github.com/repos/baev/junit/git/commits{/sha}","comments_url":"https://api.github.com/repos/baev/junit/comments{/number}","issue_comment_url":"https://api.github.com/repos/baev/junit/issues/comments{/number}","contents_url":"https://api.github.com/repos/baev/junit/contents/{+path}","compare_url":"https://api.github.com/repos/baev/junit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/baev/junit/merges","archive_url":"https://api.github.com/repos/baev/junit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/baev/junit/downloads","issues_url":"https://api.github.com/repos/baev/junit/issues{/number}","pulls_url":"https://api.github.com/repos/baev/junit/pulls{/number}","milestones_url":"https://api.github.com/repos/baev/junit/milestones{/number}","notifications_url":"https://api.github.com/repos/baev/junit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/baev/junit/labels{/name}","releases_url":"https://api.github.com/repos/baev/junit/releases{/id}","created_at":"2014-05-03T16:42:03Z","updated_at":"2015-04-26T20:11:16Z","pushed_at":"2015-05-13T11:21:42Z","git_url":"git://github.com/baev/junit.git","ssh_url":"git@github.com:baev/junit.git","clone_url":"https://github.com/baev/junit.git","svn_url":"https://github.com/baev/junit","homepage":"","size":9200,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"junit-team:junit5","ref":"junit5","sha":"a92dcbb55bd3bdaebbde57577adc2448b8b58fb3","user":{"login":"junit-team","id":874086,"avatar_url":"https://avatars.githubusercontent.com/u/874086?v=3","gravatar_id":"","url":"https://api.github.com/users/junit-team","html_url":"https://github.com/junit-team","followers_url":"https://api.github.com/users/junit-team/followers","following_url":"https://api.github.com/users/junit-team/following{/other_user}","gists_url":"https://api.github.com/users/junit-team/gists{/gist_id}","starred_url":"https://api.github.com/users/junit-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junit-team/subscriptions","organizations_url":"https://api.github.com/users/junit-team/orgs","repos_url":"https://api.github.com/users/junit-team/repos","events_url":"https://api.github.com/users/junit-team/events{/privacy}","received_events_url":"https://api.github.com/users/junit-team/received_events","type":"Organization","site_admin":false},"repo":{"id":106310,"name":"junit","full_name":"junit-team/junit","owner":{"login":"junit-team","id":874086,"avatar_url":"https://avatars.githubusercontent.com/u/874086?v=3","gravatar_id":"","url":"https://api.github.com/users/junit-team","html_url":"https://github.com/junit-team","followers_url":"https://api.github.com/users/junit-team/followers","following_url":"https://api.github.com/users/junit-team/following{/other_user}","gists_url":"https://api.github.com/users/junit-team/gists{/gist_id}","starred_url":"https://api.github.com/users/junit-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junit-team/subscriptions","organizations_url":"https://api.github.com/users/junit-team/orgs","repos_url":"https://api.github.com/users/junit-team/repos","events_url":"https://api.github.com/users/junit-team/events{/privacy}","received_events_url":"https://api.github.com/users/junit-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/junit-team/junit","description":"A programmer-oriented testing framework for Java.","fork":false,"url":"https://api.github.com/repos/junit-team/junit","forks_url":"https://api.github.com/repos/junit-team/junit/forks","keys_url":"https://api.github.com/repos/junit-team/junit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/junit-team/junit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/junit-team/junit/teams","hooks_url":"https://api.github.com/repos/junit-team/junit/hooks","issue_events_url":"https://api.github.com/repos/junit-team/junit/issues/events{/number}","events_url":"https://api.github.com/repos/junit-team/junit/events","assignees_url":"https://api.github.com/repos/junit-team/junit/assignees{/user}","branches_url":"https://api.github.com/repos/junit-team/junit/branches{/branch}","tags_url":"https://api.github.com/repos/junit-team/junit/tags","blobs_url":"https://api.github.com/repos/junit-team/junit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/junit-team/junit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/junit-team/junit/git/refs{/sha}","trees_url":"https://api.github.com/repos/junit-team/junit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/junit-team/junit/statuses/{sha}","languages_url":"https://api.github.com/repos/junit-team/junit/languages","stargazers_url":"https://api.github.com/repos/junit-team/junit/stargazers","contributors_url":"https://api.github.com/repos/junit-team/junit/contributors","subscribers_url":"https://api.github.com/repos/junit-team/junit/subscribers","subscription_url":"https://api.github.com/repos/junit-team/junit/subscription","commits_url":"https://api.github.com/repos/junit-team/junit/commits{/sha}","git_commits_url":"https://api.github.com/repos/junit-team/junit/git/commits{/sha}","comments_url":"https://api.github.com/repos/junit-team/junit/comments{/number}","issue_comment_url":"https://api.github.com/repos/junit-team/junit/issues/comments{/number}","contents_url":"https://api.github.com/repos/junit-team/junit/contents/{+path}","compare_url":"https://api.github.com/repos/junit-team/junit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/junit-team/junit/merges","archive_url":"https://api.github.com/repos/junit-team/junit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/junit-team/junit/downloads","issues_url":"https://api.github.com/repos/junit-team/junit/issues{/number}","pulls_url":"https://api.github.com/repos/junit-team/junit/pulls{/number}","milestones_url":"https://api.github.com/repos/junit-team/junit/milestones{/number}","notifications_url":"https://api.github.com/repos/junit-team/junit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/junit-team/junit/labels{/name}","releases_url":"https://api.github.com/repos/junit-team/junit/releases{/id}","created_at":"2009-01-13T03:41:26Z","updated_at":"2015-05-20T12:54:58Z","pushed_at":"2015-05-20T21:21:04Z","git_url":"git://github.com/junit-team/junit.git","ssh_url":"git@github.com:junit-team/junit.git","clone_url":"https://github.com/junit-team/junit.git","svn_url":"https://github.com/junit-team/junit","homepage":"","size":27708,"stargazers_count":3525,"watchers_count":3525,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1399,"mirror_url":null,"open_issues_count":134,"forks":1399,"open_issues":134,"watchers":3525,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/junit-team/junit/pulls/1122"},"html":{"href":"https://github.com/junit-team/junit/pull/1122"},"issue":{"href":"https://api.github.com/repos/junit-team/junit/issues/1122"},"comments":{"href":"https://api.github.com/repos/junit-team/junit/issues/1122/comments"},"review_comments":{"href":"https://api.github.com/repos/junit-team/junit/pulls/1122/comments"},"review_comment":{"href":"https://api.github.com/repos/junit-team/junit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/junit-team/junit/pulls/1122/commits"},"statuses":{"href":"https://api.github.com/repos/junit-team/junit/statuses/94de4df4d60e21c7504f6b88176d5dfbdbb980dd"}}}}