{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc/pulls/comments/30180798","id":30180798,"diff_hunk":"@@ -38,5 +38,5 @@ rm -rf python2.7_virtual_environment\n virtualenv -p /usr/bin/python2.7 python2.7_virtual_environment\n source python2.7_virtual_environment/bin/activate\n pip install enum34==1.0.4 futures==2.2.0 protobuf==3.0.0-alpha-1\n-CFLAGS=-I$root/include LDFLAGS=-L$root/libs/$CONFIG pip install src/python/src\n+CFLAGS=\"-I$root/include\" LDFLAGS=\"-L$root/libs/$CONFIG\" pip install src/python/src","path":"tools/run_tests/build_python.sh","position":5,"original_position":5,"commit_id":"fb7d7eb4ab4e2685523d1388dc0d79b8c87fe558","original_commit_id":"fb7d7eb4ab4e2685523d1388dc0d79b8c87fe558","user":{"login":"nathanielmanistaatgoogle","id":10131044,"avatar_url":"https://avatars.githubusercontent.com/u/10131044?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanielmanistaatgoogle","html_url":"https://github.com/nathanielmanistaatgoogle","followers_url":"https://api.github.com/users/nathanielmanistaatgoogle/followers","following_url":"https://api.github.com/users/nathanielmanistaatgoogle/following{/other_user}","gists_url":"https://api.github.com/users/nathanielmanistaatgoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanielmanistaatgoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanielmanistaatgoogle/subscriptions","organizations_url":"https://api.github.com/users/nathanielmanistaatgoogle/orgs","repos_url":"https://api.github.com/users/nathanielmanistaatgoogle/repos","events_url":"https://api.github.com/users/nathanielmanistaatgoogle/events{/privacy}","received_events_url":"https://api.github.com/users/nathanielmanistaatgoogle/received_events","type":"User","site_admin":false},"body":"The change on this line smells entirely independent of the whole rest of this commit. May this be made in a separate pull request?","created_at":"2015-05-12T21:09:16Z","updated_at":"2015-05-12T21:09:16Z","html_url":"https://github.com/grpc/grpc/pull/1558#discussion_r30180798","pull_request_url":"https://api.github.com/repos/grpc/grpc/pulls/1558","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments/30180798"},"html":{"href":"https://github.com/grpc/grpc/pull/1558#discussion_r30180798"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc/pulls/1558"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/1558","id":35212279,"html_url":"https://github.com/grpc/grpc/pull/1558","diff_url":"https://github.com/grpc/grpc/pull/1558.diff","patch_url":"https://github.com/grpc/grpc/pull/1558.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/1558","number":1558,"state":"open","locked":false,"title":"Overhaul Python C layer","user":{"login":"soltanmm","id":4889063,"avatar_url":"https://avatars.githubusercontent.com/u/4889063?v=3","gravatar_id":"","url":"https://api.github.com/users/soltanmm","html_url":"https://github.com/soltanmm","followers_url":"https://api.github.com/users/soltanmm/followers","following_url":"https://api.github.com/users/soltanmm/following{/other_user}","gists_url":"https://api.github.com/users/soltanmm/gists{/gist_id}","starred_url":"https://api.github.com/users/soltanmm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltanmm/subscriptions","organizations_url":"https://api.github.com/users/soltanmm/orgs","repos_url":"https://api.github.com/users/soltanmm/repos","events_url":"https://api.github.com/users/soltanmm/events{/privacy}","received_events_url":"https://api.github.com/users/soltanmm/received_events","type":"User","site_admin":false},"body":"Change the Python C layer to better match the core; currently adapts the new C layer via `_low.py` to what the old `_low.py` looked like (sans a name change `EXPIRED` -> `DEADLINE_EXCEEDED` to match the core enums). This effectively moves the boundary between old-style and new-style APIs from the shared Python/C layer to the lowest pure Python layer.\r\n\r\nThere is much to be cleaned up in this pull request (file copyrights, doc comments, commit messages, source file organization, enum location [lingual]...), and I'd rather wait for #1472 and #1493 to go through first as they seem like potential sources of surprise (which is also a reason for the alternative, but, meh).\r\n\r\nThis is being put up as a PR to check against Travis (all tests are passing locally) and for initial comments.","created_at":"2015-05-12T10:23:17Z","updated_at":"2015-05-12T21:09:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a7ff325b07a4cce1bf984114954ba832a81974d","assignee":{"login":"nathanielmanistaatgoogle","id":10131044,"avatar_url":"https://avatars.githubusercontent.com/u/10131044?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanielmanistaatgoogle","html_url":"https://github.com/nathanielmanistaatgoogle","followers_url":"https://api.github.com/users/nathanielmanistaatgoogle/followers","following_url":"https://api.github.com/users/nathanielmanistaatgoogle/following{/other_user}","gists_url":"https://api.github.com/users/nathanielmanistaatgoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanielmanistaatgoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanielmanistaatgoogle/subscriptions","organizations_url":"https://api.github.com/users/nathanielmanistaatgoogle/orgs","repos_url":"https://api.github.com/users/nathanielmanistaatgoogle/repos","events_url":"https://api.github.com/users/nathanielmanistaatgoogle/events{/privacy}","received_events_url":"https://api.github.com/users/nathanielmanistaatgoogle/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/1558/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/1558/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/1558/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/fb7d7eb4ab4e2685523d1388dc0d79b8c87fe558","head":{"label":"soltanmm:extension","ref":"extension","sha":"fb7d7eb4ab4e2685523d1388dc0d79b8c87fe558","user":{"login":"soltanmm","id":4889063,"avatar_url":"https://avatars.githubusercontent.com/u/4889063?v=3","gravatar_id":"","url":"https://api.github.com/users/soltanmm","html_url":"https://github.com/soltanmm","followers_url":"https://api.github.com/users/soltanmm/followers","following_url":"https://api.github.com/users/soltanmm/following{/other_user}","gists_url":"https://api.github.com/users/soltanmm/gists{/gist_id}","starred_url":"https://api.github.com/users/soltanmm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltanmm/subscriptions","organizations_url":"https://api.github.com/users/soltanmm/orgs","repos_url":"https://api.github.com/users/soltanmm/repos","events_url":"https://api.github.com/users/soltanmm/events{/privacy}","received_events_url":"https://api.github.com/users/soltanmm/received_events","type":"User","site_admin":false},"repo":{"id":31384607,"name":"grpc","full_name":"soltanmm/grpc","owner":{"login":"soltanmm","id":4889063,"avatar_url":"https://avatars.githubusercontent.com/u/4889063?v=3","gravatar_id":"","url":"https://api.github.com/users/soltanmm","html_url":"https://github.com/soltanmm","followers_url":"https://api.github.com/users/soltanmm/followers","following_url":"https://api.github.com/users/soltanmm/following{/other_user}","gists_url":"https://api.github.com/users/soltanmm/gists{/gist_id}","starred_url":"https://api.github.com/users/soltanmm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltanmm/subscriptions","organizations_url":"https://api.github.com/users/soltanmm/orgs","repos_url":"https://api.github.com/users/soltanmm/repos","events_url":"https://api.github.com/users/soltanmm/events{/privacy}","received_events_url":"https://api.github.com/users/soltanmm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/soltanmm/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/soltanmm/grpc","forks_url":"https://api.github.com/repos/soltanmm/grpc/forks","keys_url":"https://api.github.com/repos/soltanmm/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/soltanmm/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/soltanmm/grpc/teams","hooks_url":"https://api.github.com/repos/soltanmm/grpc/hooks","issue_events_url":"https://api.github.com/repos/soltanmm/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/soltanmm/grpc/events","assignees_url":"https://api.github.com/repos/soltanmm/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/soltanmm/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/soltanmm/grpc/tags","blobs_url":"https://api.github.com/repos/soltanmm/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/soltanmm/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/soltanmm/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/soltanmm/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/soltanmm/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/soltanmm/grpc/languages","stargazers_url":"https://api.github.com/repos/soltanmm/grpc/stargazers","contributors_url":"https://api.github.com/repos/soltanmm/grpc/contributors","subscribers_url":"https://api.github.com/repos/soltanmm/grpc/subscribers","subscription_url":"https://api.github.com/repos/soltanmm/grpc/subscription","commits_url":"https://api.github.com/repos/soltanmm/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/soltanmm/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/soltanmm/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/soltanmm/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/soltanmm/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/soltanmm/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/soltanmm/grpc/merges","archive_url":"https://api.github.com/repos/soltanmm/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/soltanmm/grpc/downloads","issues_url":"https://api.github.com/repos/soltanmm/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/soltanmm/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/soltanmm/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/soltanmm/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/soltanmm/grpc/labels{/name}","releases_url":"https://api.github.com/repos/soltanmm/grpc/releases{/id}","created_at":"2015-02-26T19:25:31Z","updated_at":"2015-05-06T19:41:05Z","pushed_at":"2015-05-12T10:07:49Z","git_url":"git://github.com/soltanmm/grpc.git","ssh_url":"git@github.com:soltanmm/grpc.git","clone_url":"https://github.com/soltanmm/grpc.git","svn_url":"https://github.com/soltanmm/grpc","homepage":"","size":21678,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"19991c2bc9a6d06c715ca0194308f7dd0e150a1d","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"name":"grpc","full_name":"grpc/grpc","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","created_at":"2014-12-08T18:58:53Z","updated_at":"2015-05-12T18:18:33Z","pushed_at":"2015-05-12T21:09:09Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"git@github.com:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"","size":46762,"stargazers_count":2560,"watchers_count":2560,"language":"C","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":338,"mirror_url":null,"open_issues_count":190,"forks":338,"open_issues":190,"watchers":2560,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/1558"},"html":{"href":"https://github.com/grpc/grpc/pull/1558"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/1558"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/1558/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/1558/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/1558/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/fb7d7eb4ab4e2685523d1388dc0d79b8c87fe558"}}}}