{"action":"created","comment":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/comments/24573711","id":24573711,"diff_hunk":"@@ -77,7 +78,15 @@ public ActionForward execute(\n \t\t\tjson = getJSON(actionMapping, actionForm, request, response);\n \n \t\t\tif (Validator.isNotNull(callback)) {\n-\t\t\t\tjson = callback + \"(\" + json + \");\";\n+\t\t\t\tStringBundler sb = new StringBundler(5);\n+\n+\t\t\t\tsb.append(\"/**/\");","path":"portal-impl/src/com/liferay/portal/struts/JSONAction.java","position":15,"original_position":15,"commit_id":"4d86a65979d6251a73d16faf83821a5188d08e73","original_commit_id":"4d86a65979d6251a73d16faf83821a5188d08e73","user":{"login":"samuelkong","id":864966,"avatar_url":"https://avatars.githubusercontent.com/u/864966?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelkong","html_url":"https://github.com/samuelkong","followers_url":"https://api.github.com/users/samuelkong/followers","following_url":"https://api.github.com/users/samuelkong/following{/other_user}","gists_url":"https://api.github.com/users/samuelkong/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelkong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelkong/subscriptions","organizations_url":"https://api.github.com/users/samuelkong/orgs","repos_url":"https://api.github.com/users/samuelkong/repos","events_url":"https://api.github.com/users/samuelkong/events{/privacy}","received_events_url":"https://api.github.com/users/samuelkong/received_events","type":"User","site_admin":false},"body":"Recommend method to fix is to prepend the callback with `/**/`\r\nSee https://miki.it/blog/2014/7/8/abusing-jsonp-with-rosetta-flash/#mitigations-by-website-owners","created_at":"2015-02-12T11:12:46Z","updated_at":"2015-02-12T11:12:46Z","html_url":"https://github.com/brianchandotcom/liferay-portal/pull/23999#discussion_r24573711","pull_request_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/23999","_links":{"self":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/comments/24573711"},"html":{"href":"https://github.com/brianchandotcom/liferay-portal/pull/23999#discussion_r24573711"},"pull_request":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/23999"}}},"pull_request":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/23999","id":29170228,"html_url":"https://github.com/brianchandotcom/liferay-portal/pull/23999","diff_url":"https://github.com/brianchandotcom/liferay-portal/pull/23999.diff","patch_url":"https://github.com/brianchandotcom/liferay-portal/pull/23999.patch","issue_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/23999","number":23999,"state":"open","locked":false,"title":"LPS-53431","user":{"login":"samuelkong","id":864966,"avatar_url":"https://avatars.githubusercontent.com/u/864966?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelkong","html_url":"https://github.com/samuelkong","followers_url":"https://api.github.com/users/samuelkong/followers","following_url":"https://api.github.com/users/samuelkong/following{/other_user}","gists_url":"https://api.github.com/users/samuelkong/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelkong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelkong/subscriptions","organizations_url":"https://api.github.com/users/samuelkong/orgs","repos_url":"https://api.github.com/users/samuelkong/repos","events_url":"https://api.github.com/users/samuelkong/events{/privacy}","received_events_url":"https://api.github.com/users/samuelkong/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-02-12T11:10:59Z","updated_at":"2015-02-12T11:12:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f2555ba61ca47f19c9661b6c5ce759f45f67c8c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/23999/commits","review_comments_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/23999/comments","review_comment_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/comments/{number}","comments_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/23999/comments","statuses_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/statuses/4d86a65979d6251a73d16faf83821a5188d08e73","head":{"label":"samuelkong:LPS-53431","ref":"LPS-53431","sha":"4d86a65979d6251a73d16faf83821a5188d08e73","user":{"login":"samuelkong","id":864966,"avatar_url":"https://avatars.githubusercontent.com/u/864966?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelkong","html_url":"https://github.com/samuelkong","followers_url":"https://api.github.com/users/samuelkong/followers","following_url":"https://api.github.com/users/samuelkong/following{/other_user}","gists_url":"https://api.github.com/users/samuelkong/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelkong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelkong/subscriptions","organizations_url":"https://api.github.com/users/samuelkong/orgs","repos_url":"https://api.github.com/users/samuelkong/repos","events_url":"https://api.github.com/users/samuelkong/events{/privacy}","received_events_url":"https://api.github.com/users/samuelkong/received_events","type":"User","site_admin":false},"repo":{"id":1930678,"name":"liferay-portal","full_name":"samuelkong/liferay-portal","owner":{"login":"samuelkong","id":864966,"avatar_url":"https://avatars.githubusercontent.com/u/864966?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelkong","html_url":"https://github.com/samuelkong","followers_url":"https://api.github.com/users/samuelkong/followers","following_url":"https://api.github.com/users/samuelkong/following{/other_user}","gists_url":"https://api.github.com/users/samuelkong/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelkong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelkong/subscriptions","organizations_url":"https://api.github.com/users/samuelkong/orgs","repos_url":"https://api.github.com/users/samuelkong/repos","events_url":"https://api.github.com/users/samuelkong/events{/privacy}","received_events_url":"https://api.github.com/users/samuelkong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samuelkong/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/samuelkong/liferay-portal","forks_url":"https://api.github.com/repos/samuelkong/liferay-portal/forks","keys_url":"https://api.github.com/repos/samuelkong/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samuelkong/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samuelkong/liferay-portal/teams","hooks_url":"https://api.github.com/repos/samuelkong/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/samuelkong/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/samuelkong/liferay-portal/events","assignees_url":"https://api.github.com/repos/samuelkong/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/samuelkong/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/samuelkong/liferay-portal/tags","blobs_url":"https://api.github.com/repos/samuelkong/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samuelkong/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samuelkong/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/samuelkong/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samuelkong/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/samuelkong/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/samuelkong/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/samuelkong/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/samuelkong/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/samuelkong/liferay-portal/subscription","commits_url":"https://api.github.com/repos/samuelkong/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/samuelkong/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/samuelkong/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/samuelkong/liferay-portal/issues/comments/{number}","contents_url":"https://api.github.com/repos/samuelkong/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/samuelkong/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samuelkong/liferay-portal/merges","archive_url":"https://api.github.com/repos/samuelkong/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samuelkong/liferay-portal/downloads","issues_url":"https://api.github.com/repos/samuelkong/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/samuelkong/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/samuelkong/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/samuelkong/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samuelkong/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/samuelkong/liferay-portal/releases{/id}","created_at":"2011-06-21T18:18:39Z","updated_at":"2015-02-12T01:22:23Z","pushed_at":"2015-02-12T11:09:46Z","git_url":"git://github.com/samuelkong/liferay-portal.git","ssh_url":"git@github.com:samuelkong/liferay-portal.git","clone_url":"https://github.com/samuelkong/liferay-portal.git","svn_url":"https://github.com/samuelkong/liferay-portal","homepage":"http://liferay.com","size":4060059,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":9,"default_branch":"master"}},"base":{"label":"brianchandotcom:master","ref":"master","sha":"a5feb9480cf0b6090da977da848df4ed7d6c664b","user":{"login":"brianchandotcom","id":282080,"avatar_url":"https://avatars.githubusercontent.com/u/282080?v=3","gravatar_id":"","url":"https://api.github.com/users/brianchandotcom","html_url":"https://github.com/brianchandotcom","followers_url":"https://api.github.com/users/brianchandotcom/followers","following_url":"https://api.github.com/users/brianchandotcom/following{/other_user}","gists_url":"https://api.github.com/users/brianchandotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/brianchandotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianchandotcom/subscriptions","organizations_url":"https://api.github.com/users/brianchandotcom/orgs","repos_url":"https://api.github.com/users/brianchandotcom/repos","events_url":"https://api.github.com/users/brianchandotcom/events{/privacy}","received_events_url":"https://api.github.com/users/brianchandotcom/received_events","type":"User","site_admin":false},"repo":{"id":1920851,"name":"liferay-portal","full_name":"brianchandotcom/liferay-portal","owner":{"login":"brianchandotcom","id":282080,"avatar_url":"https://avatars.githubusercontent.com/u/282080?v=3","gravatar_id":"","url":"https://api.github.com/users/brianchandotcom","html_url":"https://github.com/brianchandotcom","followers_url":"https://api.github.com/users/brianchandotcom/followers","following_url":"https://api.github.com/users/brianchandotcom/following{/other_user}","gists_url":"https://api.github.com/users/brianchandotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/brianchandotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianchandotcom/subscriptions","organizations_url":"https://api.github.com/users/brianchandotcom/orgs","repos_url":"https://api.github.com/users/brianchandotcom/repos","events_url":"https://api.github.com/users/brianchandotcom/events{/privacy}","received_events_url":"https://api.github.com/users/brianchandotcom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brianchandotcom/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/brianchandotcom/liferay-portal","forks_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/forks","keys_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/teams","hooks_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/events","assignees_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/tags","blobs_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/subscription","commits_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/comments/{number}","contents_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/merges","archive_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/downloads","issues_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/releases{/id}","created_at":"2011-06-19T21:37:56Z","updated_at":"2015-02-12T06:35:37Z","pushed_at":"2015-02-12T11:12:23Z","git_url":"git://github.com/brianchandotcom/liferay-portal.git","ssh_url":"git@github.com:brianchandotcom/liferay-portal.git","clone_url":"https://github.com/brianchandotcom/liferay-portal.git","svn_url":"https://github.com/brianchandotcom/liferay-portal","homepage":"http://liferay.com","size":4594270,"stargazers_count":28,"watchers_count":28,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":5,"forks":5,"open_issues":5,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/23999"},"html":{"href":"https://github.com/brianchandotcom/liferay-portal/pull/23999"},"issue":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/23999"},"comments":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/23999/comments"},"review_comments":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/23999/comments"},"review_comment":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/23999/commits"},"statuses":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/statuses/4d86a65979d6251a73d16faf83821a5188d08e73"}}}}