{"action":"closed","number":331,"pull_request":{"url":"https://api.github.com/repos/markevans/dragonfly/pulls/331","id":13691656,"html_url":"https://github.com/markevans/dragonfly/pull/331","diff_url":"https://github.com/markevans/dragonfly/pull/331.diff","patch_url":"https://github.com/markevans/dragonfly/pull/331.patch","issue_url":"https://api.github.com/repos/markevans/dragonfly/issues/331","number":331,"state":"closed","locked":false,"title":"fix for temporary files without the original_filename attribute.","user":{"login":"MaG21","id":1760771,"avatar_url":"https://avatars.githubusercontent.com/u/1760771?v=3","gravatar_id":"","url":"https://api.github.com/users/MaG21","html_url":"https://github.com/MaG21","followers_url":"https://api.github.com/users/MaG21/followers","following_url":"https://api.github.com/users/MaG21/following{/other_user}","gists_url":"https://api.github.com/users/MaG21/gists{/gist_id}","starred_url":"https://api.github.com/users/MaG21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaG21/subscriptions","organizations_url":"https://api.github.com/users/MaG21/orgs","repos_url":"https://api.github.com/users/MaG21/repos","events_url":"https://api.github.com/users/MaG21/events{/privacy}","received_events_url":"https://api.github.com/users/MaG21/received_events","type":"User","site_admin":false},"body":"This PR fix a bug in the *TempObject*,  now one can use temporary files in conjunction with dragonfly without losing the original name of the temporary file, even if the `original_filename` attribute it's not defined.\r\n\r\nhow to reproduce the actual bug\r\nie:\r\n```ruby\r\ntmp_file = Tempfile.new(['hola', '.txt'], :encoding => 'ascii-8bit')\r\ntmp_file.write(content)\r\nimg_uid = app.store(tmp_file)\r\nputs img_uid\r\n```\r\nwill output something similar to this:\r\n*2014/03/18/11/47/41/506/file*\r\n\r\nWith this PR output should be something similar to:\r\n*...path.../hola2843-84--0.txt*\r\n","created_at":"2014-03-18T16:03:16Z","updated_at":"2015-04-29T14:55:17Z","closed_at":"2015-04-29T14:55:17Z","merged_at":null,"merge_commit_sha":"dd2c2ecce290ee24929a2647e5f1c7433f532d88","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/markevans/dragonfly/pulls/331/commits","review_comments_url":"https://api.github.com/repos/markevans/dragonfly/pulls/331/comments","review_comment_url":"https://api.github.com/repos/markevans/dragonfly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/markevans/dragonfly/issues/331/comments","statuses_url":"https://api.github.com/repos/markevans/dragonfly/statuses/dd2e9d04cd37f94dc290587fdf4367da65e896d8","head":{"label":"MaG21:master","ref":"master","sha":"dd2e9d04cd37f94dc290587fdf4367da65e896d8","user":{"login":"MaG21","id":1760771,"avatar_url":"https://avatars.githubusercontent.com/u/1760771?v=3","gravatar_id":"","url":"https://api.github.com/users/MaG21","html_url":"https://github.com/MaG21","followers_url":"https://api.github.com/users/MaG21/followers","following_url":"https://api.github.com/users/MaG21/following{/other_user}","gists_url":"https://api.github.com/users/MaG21/gists{/gist_id}","starred_url":"https://api.github.com/users/MaG21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaG21/subscriptions","organizations_url":"https://api.github.com/users/MaG21/orgs","repos_url":"https://api.github.com/users/MaG21/repos","events_url":"https://api.github.com/users/MaG21/events{/privacy}","received_events_url":"https://api.github.com/users/MaG21/received_events","type":"User","site_admin":false},"repo":{"id":17868301,"name":"dragonfly","full_name":"MaG21/dragonfly","owner":{"login":"MaG21","id":1760771,"avatar_url":"https://avatars.githubusercontent.com/u/1760771?v=3","gravatar_id":"","url":"https://api.github.com/users/MaG21","html_url":"https://github.com/MaG21","followers_url":"https://api.github.com/users/MaG21/followers","following_url":"https://api.github.com/users/MaG21/following{/other_user}","gists_url":"https://api.github.com/users/MaG21/gists{/gist_id}","starred_url":"https://api.github.com/users/MaG21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaG21/subscriptions","organizations_url":"https://api.github.com/users/MaG21/orgs","repos_url":"https://api.github.com/users/MaG21/repos","events_url":"https://api.github.com/users/MaG21/events{/privacy}","received_events_url":"https://api.github.com/users/MaG21/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MaG21/dragonfly","description":"A Ruby gem for on-the-fly processing - suitable for image uploading in Rails, Sinatra and much more!","fork":true,"url":"https://api.github.com/repos/MaG21/dragonfly","forks_url":"https://api.github.com/repos/MaG21/dragonfly/forks","keys_url":"https://api.github.com/repos/MaG21/dragonfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MaG21/dragonfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MaG21/dragonfly/teams","hooks_url":"https://api.github.com/repos/MaG21/dragonfly/hooks","issue_events_url":"https://api.github.com/repos/MaG21/dragonfly/issues/events{/number}","events_url":"https://api.github.com/repos/MaG21/dragonfly/events","assignees_url":"https://api.github.com/repos/MaG21/dragonfly/assignees{/user}","branches_url":"https://api.github.com/repos/MaG21/dragonfly/branches{/branch}","tags_url":"https://api.github.com/repos/MaG21/dragonfly/tags","blobs_url":"https://api.github.com/repos/MaG21/dragonfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MaG21/dragonfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MaG21/dragonfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/MaG21/dragonfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MaG21/dragonfly/statuses/{sha}","languages_url":"https://api.github.com/repos/MaG21/dragonfly/languages","stargazers_url":"https://api.github.com/repos/MaG21/dragonfly/stargazers","contributors_url":"https://api.github.com/repos/MaG21/dragonfly/contributors","subscribers_url":"https://api.github.com/repos/MaG21/dragonfly/subscribers","subscription_url":"https://api.github.com/repos/MaG21/dragonfly/subscription","commits_url":"https://api.github.com/repos/MaG21/dragonfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/MaG21/dragonfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/MaG21/dragonfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/MaG21/dragonfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/MaG21/dragonfly/contents/{+path}","compare_url":"https://api.github.com/repos/MaG21/dragonfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MaG21/dragonfly/merges","archive_url":"https://api.github.com/repos/MaG21/dragonfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MaG21/dragonfly/downloads","issues_url":"https://api.github.com/repos/MaG21/dragonfly/issues{/number}","pulls_url":"https://api.github.com/repos/MaG21/dragonfly/pulls{/number}","milestones_url":"https://api.github.com/repos/MaG21/dragonfly/milestones{/number}","notifications_url":"https://api.github.com/repos/MaG21/dragonfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MaG21/dragonfly/labels{/name}","releases_url":"https://api.github.com/repos/MaG21/dragonfly/releases{/id}","created_at":"2014-03-18T14:15:42Z","updated_at":"2014-03-18T20:42:41Z","pushed_at":"2014-03-18T20:42:40Z","git_url":"git://github.com/MaG21/dragonfly.git","ssh_url":"git@github.com:MaG21/dragonfly.git","clone_url":"https://github.com/MaG21/dragonfly.git","svn_url":"https://github.com/MaG21/dragonfly","homepage":"http://markevans.github.io/dragonfly","size":8262,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"markevans:master","ref":"master","sha":"32a64b40055cd3bd2c8f40e898630fe9341a343c","user":{"login":"markevans","id":12292,"avatar_url":"https://avatars.githubusercontent.com/u/12292?v=3","gravatar_id":"","url":"https://api.github.com/users/markevans","html_url":"https://github.com/markevans","followers_url":"https://api.github.com/users/markevans/followers","following_url":"https://api.github.com/users/markevans/following{/other_user}","gists_url":"https://api.github.com/users/markevans/gists{/gist_id}","starred_url":"https://api.github.com/users/markevans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markevans/subscriptions","organizations_url":"https://api.github.com/users/markevans/orgs","repos_url":"https://api.github.com/users/markevans/repos","events_url":"https://api.github.com/users/markevans/events{/privacy}","received_events_url":"https://api.github.com/users/markevans/received_events","type":"User","site_admin":false},"repo":{"id":291884,"name":"dragonfly","full_name":"markevans/dragonfly","owner":{"login":"markevans","id":12292,"avatar_url":"https://avatars.githubusercontent.com/u/12292?v=3","gravatar_id":"","url":"https://api.github.com/users/markevans","html_url":"https://github.com/markevans","followers_url":"https://api.github.com/users/markevans/followers","following_url":"https://api.github.com/users/markevans/following{/other_user}","gists_url":"https://api.github.com/users/markevans/gists{/gist_id}","starred_url":"https://api.github.com/users/markevans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markevans/subscriptions","organizations_url":"https://api.github.com/users/markevans/orgs","repos_url":"https://api.github.com/users/markevans/repos","events_url":"https://api.github.com/users/markevans/events{/privacy}","received_events_url":"https://api.github.com/users/markevans/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/markevans/dragonfly","description":"A Ruby gem for on-the-fly processing - suitable for image uploading in Rails, Sinatra and much more!","fork":false,"url":"https://api.github.com/repos/markevans/dragonfly","forks_url":"https://api.github.com/repos/markevans/dragonfly/forks","keys_url":"https://api.github.com/repos/markevans/dragonfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markevans/dragonfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markevans/dragonfly/teams","hooks_url":"https://api.github.com/repos/markevans/dragonfly/hooks","issue_events_url":"https://api.github.com/repos/markevans/dragonfly/issues/events{/number}","events_url":"https://api.github.com/repos/markevans/dragonfly/events","assignees_url":"https://api.github.com/repos/markevans/dragonfly/assignees{/user}","branches_url":"https://api.github.com/repos/markevans/dragonfly/branches{/branch}","tags_url":"https://api.github.com/repos/markevans/dragonfly/tags","blobs_url":"https://api.github.com/repos/markevans/dragonfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markevans/dragonfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markevans/dragonfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/markevans/dragonfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markevans/dragonfly/statuses/{sha}","languages_url":"https://api.github.com/repos/markevans/dragonfly/languages","stargazers_url":"https://api.github.com/repos/markevans/dragonfly/stargazers","contributors_url":"https://api.github.com/repos/markevans/dragonfly/contributors","subscribers_url":"https://api.github.com/repos/markevans/dragonfly/subscribers","subscription_url":"https://api.github.com/repos/markevans/dragonfly/subscription","commits_url":"https://api.github.com/repos/markevans/dragonfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/markevans/dragonfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/markevans/dragonfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/markevans/dragonfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/markevans/dragonfly/contents/{+path}","compare_url":"https://api.github.com/repos/markevans/dragonfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markevans/dragonfly/merges","archive_url":"https://api.github.com/repos/markevans/dragonfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markevans/dragonfly/downloads","issues_url":"https://api.github.com/repos/markevans/dragonfly/issues{/number}","pulls_url":"https://api.github.com/repos/markevans/dragonfly/pulls{/number}","milestones_url":"https://api.github.com/repos/markevans/dragonfly/milestones{/number}","notifications_url":"https://api.github.com/repos/markevans/dragonfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markevans/dragonfly/labels{/name}","releases_url":"https://api.github.com/repos/markevans/dragonfly/releases{/id}","created_at":"2009-08-29T19:15:08Z","updated_at":"2015-04-29T14:36:48Z","pushed_at":"2015-04-29T14:36:50Z","git_url":"git://github.com/markevans/dragonfly.git","ssh_url":"git@github.com:markevans/dragonfly.git","clone_url":"https://github.com/markevans/dragonfly.git","svn_url":"https://github.com/markevans/dragonfly","homepage":"http://markevans.github.io/dragonfly","size":13125,"stargazers_count":1718,"watchers_count":1718,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":197,"mirror_url":null,"open_issues_count":25,"forks":197,"open_issues":25,"watchers":1718,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/markevans/dragonfly/pulls/331"},"html":{"href":"https://github.com/markevans/dragonfly/pull/331"},"issue":{"href":"https://api.github.com/repos/markevans/dragonfly/issues/331"},"comments":{"href":"https://api.github.com/repos/markevans/dragonfly/issues/331/comments"},"review_comments":{"href":"https://api.github.com/repos/markevans/dragonfly/pulls/331/comments"},"review_comment":{"href":"https://api.github.com/repos/markevans/dragonfly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/markevans/dragonfly/pulls/331/commits"},"statuses":{"href":"https://api.github.com/repos/markevans/dragonfly/statuses/dd2e9d04cd37f94dc290587fdf4367da65e896d8"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":4,"review_comments":0,"commits":2,"additions":6,"deletions":4,"changed_files":2}}