{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/35021318","id":35021318,"diff_hunk":"@@ -140,6 +141,37 @@ class StreamingListenerSuite extends TestSuiteBase with Matchers {\n     }\n     true\n   }\n+\n+  test(\"registering listeners via spark.streaming.extraListeners\") {\n+    // Test for success with zero-argument constructor and sparkConf constructor\n+    val conf = new SparkConf().setMaster(\"local\").setAppName(\"test\")\n+      .set(\"spark.streaming.extraListeners\",\n+        classOf[StreamingListenerThatAcceptsSparkConf].getName + \",\" +\n+        classOf[ReceiverInfoCollector].getName)\n+    val scc = new StreamingContext(conf, Seconds(1))","path":"streaming/src/test/scala/org/apache/spark/streaming/StreamingListenerSuite.scala","position":32,"original_position":32,"commit_id":"fa8c752d6a78d1c54717819f37ffe2a0f0ec48a5","original_commit_id":"fa8c752d6a78d1c54717819f37ffe2a0f0ec48a5","user":{"login":"tdas","id":663212,"avatar_url":"https://avatars.githubusercontent.com/u/663212?v=3","gravatar_id":"","url":"https://api.github.com/users/tdas","html_url":"https://github.com/tdas","followers_url":"https://api.github.com/users/tdas/followers","following_url":"https://api.github.com/users/tdas/following{/other_user}","gists_url":"https://api.github.com/users/tdas/gists{/gist_id}","starred_url":"https://api.github.com/users/tdas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdas/subscriptions","organizations_url":"https://api.github.com/users/tdas/orgs","repos_url":"https://api.github.com/users/tdas/repos","events_url":"https://api.github.com/users/tdas/events{/privacy}","received_events_url":"https://api.github.com/users/tdas/received_events","type":"User","site_admin":false},"body":"Yes, the StreamingContext is being created, which means an underlying SparkContext is being created, which is not being cleaned up.","created_at":"2015-07-20T17:37:25Z","updated_at":"2015-07-20T17:37:25Z","html_url":"https://github.com/apache/spark/pull/6380#discussion_r35021318","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/6380","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/35021318"},"html":{"href":"https://github.com/apache/spark/pull/6380#discussion_r35021318"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/6380"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/6380","id":36092028,"html_url":"https://github.com/apache/spark/pull/6380","diff_url":"https://github.com/apache/spark/pull/6380.diff","patch_url":"https://github.com/apache/spark/pull/6380.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/6380","number":6380,"state":"open","locked":false,"title":"[SPARK-7786][STREAMING] Allow StreamingListener to be specified in SparkConf and loaded when creating StreamingContext","user":{"login":"His-name-is-Joof","id":1543809,"avatar_url":"https://avatars.githubusercontent.com/u/1543809?v=3","gravatar_id":"","url":"https://api.github.com/users/His-name-is-Joof","html_url":"https://github.com/His-name-is-Joof","followers_url":"https://api.github.com/users/His-name-is-Joof/followers","following_url":"https://api.github.com/users/His-name-is-Joof/following{/other_user}","gists_url":"https://api.github.com/users/His-name-is-Joof/gists{/gist_id}","starred_url":"https://api.github.com/users/His-name-is-Joof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/His-name-is-Joof/subscriptions","organizations_url":"https://api.github.com/users/His-name-is-Joof/orgs","repos_url":"https://api.github.com/users/His-name-is-Joof/repos","events_url":"https://api.github.com/users/His-name-is-Joof/events{/privacy}","received_events_url":"https://api.github.com/users/His-name-is-Joof/received_events","type":"User","site_admin":false},"body":"Add SparkConf option spark.streamingListeners to implement similar functionality to spark.extraListeners defined in [[SPARK-5411]](https://issues.apache.org/jira/browse/SPARK-5411). \r\n\r\nAlso modifies StatsReportListener to have a zero-valued constructor and adds a simple test","created_at":"2015-05-23T19:03:57Z","updated_at":"2015-07-20T17:37:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8183ba4def7edfbee70b0ca1b9ad31f81a2296e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/6380/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/6380/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/6380/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/fa8c752d6a78d1c54717819f37ffe2a0f0ec48a5","head":{"label":"His-name-is-Joof:SparkConf_Listeners","ref":"SparkConf_Listeners","sha":"fa8c752d6a78d1c54717819f37ffe2a0f0ec48a5","user":{"login":"His-name-is-Joof","id":1543809,"avatar_url":"https://avatars.githubusercontent.com/u/1543809?v=3","gravatar_id":"","url":"https://api.github.com/users/His-name-is-Joof","html_url":"https://github.com/His-name-is-Joof","followers_url":"https://api.github.com/users/His-name-is-Joof/followers","following_url":"https://api.github.com/users/His-name-is-Joof/following{/other_user}","gists_url":"https://api.github.com/users/His-name-is-Joof/gists{/gist_id}","starred_url":"https://api.github.com/users/His-name-is-Joof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/His-name-is-Joof/subscriptions","organizations_url":"https://api.github.com/users/His-name-is-Joof/orgs","repos_url":"https://api.github.com/users/His-name-is-Joof/repos","events_url":"https://api.github.com/users/His-name-is-Joof/events{/privacy}","received_events_url":"https://api.github.com/users/His-name-is-Joof/received_events","type":"User","site_admin":false},"repo":{"id":34104057,"name":"spark","full_name":"His-name-is-Joof/spark","owner":{"login":"His-name-is-Joof","id":1543809,"avatar_url":"https://avatars.githubusercontent.com/u/1543809?v=3","gravatar_id":"","url":"https://api.github.com/users/His-name-is-Joof","html_url":"https://github.com/His-name-is-Joof","followers_url":"https://api.github.com/users/His-name-is-Joof/followers","following_url":"https://api.github.com/users/His-name-is-Joof/following{/other_user}","gists_url":"https://api.github.com/users/His-name-is-Joof/gists{/gist_id}","starred_url":"https://api.github.com/users/His-name-is-Joof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/His-name-is-Joof/subscriptions","organizations_url":"https://api.github.com/users/His-name-is-Joof/orgs","repos_url":"https://api.github.com/users/His-name-is-Joof/repos","events_url":"https://api.github.com/users/His-name-is-Joof/events{/privacy}","received_events_url":"https://api.github.com/users/His-name-is-Joof/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/His-name-is-Joof/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/His-name-is-Joof/spark","forks_url":"https://api.github.com/repos/His-name-is-Joof/spark/forks","keys_url":"https://api.github.com/repos/His-name-is-Joof/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/His-name-is-Joof/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/His-name-is-Joof/spark/teams","hooks_url":"https://api.github.com/repos/His-name-is-Joof/spark/hooks","issue_events_url":"https://api.github.com/repos/His-name-is-Joof/spark/issues/events{/number}","events_url":"https://api.github.com/repos/His-name-is-Joof/spark/events","assignees_url":"https://api.github.com/repos/His-name-is-Joof/spark/assignees{/user}","branches_url":"https://api.github.com/repos/His-name-is-Joof/spark/branches{/branch}","tags_url":"https://api.github.com/repos/His-name-is-Joof/spark/tags","blobs_url":"https://api.github.com/repos/His-name-is-Joof/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/His-name-is-Joof/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/His-name-is-Joof/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/His-name-is-Joof/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/His-name-is-Joof/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/His-name-is-Joof/spark/languages","stargazers_url":"https://api.github.com/repos/His-name-is-Joof/spark/stargazers","contributors_url":"https://api.github.com/repos/His-name-is-Joof/spark/contributors","subscribers_url":"https://api.github.com/repos/His-name-is-Joof/spark/subscribers","subscription_url":"https://api.github.com/repos/His-name-is-Joof/spark/subscription","commits_url":"https://api.github.com/repos/His-name-is-Joof/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/His-name-is-Joof/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/His-name-is-Joof/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/His-name-is-Joof/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/His-name-is-Joof/spark/contents/{+path}","compare_url":"https://api.github.com/repos/His-name-is-Joof/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/His-name-is-Joof/spark/merges","archive_url":"https://api.github.com/repos/His-name-is-Joof/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/His-name-is-Joof/spark/downloads","issues_url":"https://api.github.com/repos/His-name-is-Joof/spark/issues{/number}","pulls_url":"https://api.github.com/repos/His-name-is-Joof/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/His-name-is-Joof/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/His-name-is-Joof/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/His-name-is-Joof/spark/labels{/name}","releases_url":"https://api.github.com/repos/His-name-is-Joof/spark/releases{/id}","created_at":"2015-04-17T08:00:14Z","updated_at":"2015-04-17T08:00:35Z","pushed_at":"2015-07-16T22:40:05Z","git_url":"git://github.com/His-name-is-Joof/spark.git","ssh_url":"git@github.com:His-name-is-Joof/spark.git","clone_url":"https://github.com/His-name-is-Joof/spark.git","svn_url":"https://github.com/His-name-is-Joof/spark","homepage":null,"size":111163,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"0e78e40c0b221e09d9ea22177a99f3bea4b2b4fb","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-07-20T16:14:46Z","pushed_at":"2015-07-20T17:36:23Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1544794,"stargazers_count":4802,"watchers_count":4802,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4300,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":344,"forks":4300,"open_issues":344,"watchers":4802,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/6380"},"html":{"href":"https://github.com/apache/spark/pull/6380"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/6380"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/6380/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/6380/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/6380/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/fa8c752d6a78d1c54717819f37ffe2a0f0ec48a5"}}}}