{"action":"closed","number":3279,"pull_request":{"url":"https://api.github.com/repos/elastic/logstash/pulls/3279","id":35760390,"html_url":"https://github.com/elastic/logstash/pull/3279","diff_url":"https://github.com/elastic/logstash/pull/3279.diff","patch_url":"https://github.com/elastic/logstash/pull/3279.patch","issue_url":"https://api.github.com/repos/elastic/logstash/issues/3279","number":3279,"state":"closed","locked":false,"title":"[1.4] Dont allow creating new files outside the document root","user":{"login":"ph","id":640,"avatar_url":"https://avatars.githubusercontent.com/u/640?v=3","gravatar_id":"","url":"https://api.github.com/users/ph","html_url":"https://github.com/ph","followers_url":"https://api.github.com/users/ph/followers","following_url":"https://api.github.com/users/ph/following{/other_user}","gists_url":"https://api.github.com/users/ph/gists{/gist_id}","starred_url":"https://api.github.com/users/ph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ph/subscriptions","organizations_url":"https://api.github.com/users/ph/orgs","repos_url":"https://api.github.com/users/ph/repos","events_url":"https://api.github.com/users/ph/events{/privacy}","received_events_url":"https://api.github.com/users/ph/received_events","type":"User","site_admin":false},"body":"Before this Fix, people were able to use the string interpolation of the event (Event#sprintf)\r\nto generate files outside the defined path. This pull request try to extract a document\r\nroot from the configuration and sandbox the creation of new file in that environment.\r\n","created_at":"2015-05-19T18:31:04Z","updated_at":"2015-05-26T03:20:58Z","closed_at":"2015-05-26T03:20:58Z","merged_at":"2015-05-26T03:20:58Z","merge_commit_sha":"4d7c9dcdd04d1a0f0926a30650801d6add47a60f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elastic/logstash/pulls/3279/commits","review_comments_url":"https://api.github.com/repos/elastic/logstash/pulls/3279/comments","review_comment_url":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/logstash/issues/3279/comments","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/20140d21db8a486ca5467f63aae6117a684b0240","head":{"label":"ph:fix/file-output-check-path","ref":"fix/file-output-check-path","sha":"20140d21db8a486ca5467f63aae6117a684b0240","user":{"login":"ph","id":640,"avatar_url":"https://avatars.githubusercontent.com/u/640?v=3","gravatar_id":"","url":"https://api.github.com/users/ph","html_url":"https://github.com/ph","followers_url":"https://api.github.com/users/ph/followers","following_url":"https://api.github.com/users/ph/following{/other_user}","gists_url":"https://api.github.com/users/ph/gists{/gist_id}","starred_url":"https://api.github.com/users/ph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ph/subscriptions","organizations_url":"https://api.github.com/users/ph/orgs","repos_url":"https://api.github.com/users/ph/repos","events_url":"https://api.github.com/users/ph/events{/privacy}","received_events_url":"https://api.github.com/users/ph/received_events","type":"User","site_admin":false},"repo":{"id":24861697,"name":"logstash","full_name":"ph/logstash","owner":{"login":"ph","id":640,"avatar_url":"https://avatars.githubusercontent.com/u/640?v=3","gravatar_id":"","url":"https://api.github.com/users/ph","html_url":"https://github.com/ph","followers_url":"https://api.github.com/users/ph/followers","following_url":"https://api.github.com/users/ph/following{/other_user}","gists_url":"https://api.github.com/users/ph/gists{/gist_id}","starred_url":"https://api.github.com/users/ph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ph/subscriptions","organizations_url":"https://api.github.com/users/ph/orgs","repos_url":"https://api.github.com/users/ph/repos","events_url":"https://api.github.com/users/ph/events{/privacy}","received_events_url":"https://api.github.com/users/ph/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ph/logstash","description":"logstash - logs/event transport, processing, management, search.","fork":true,"url":"https://api.github.com/repos/ph/logstash","forks_url":"https://api.github.com/repos/ph/logstash/forks","keys_url":"https://api.github.com/repos/ph/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ph/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ph/logstash/teams","hooks_url":"https://api.github.com/repos/ph/logstash/hooks","issue_events_url":"https://api.github.com/repos/ph/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/ph/logstash/events","assignees_url":"https://api.github.com/repos/ph/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/ph/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/ph/logstash/tags","blobs_url":"https://api.github.com/repos/ph/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ph/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ph/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/ph/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ph/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/ph/logstash/languages","stargazers_url":"https://api.github.com/repos/ph/logstash/stargazers","contributors_url":"https://api.github.com/repos/ph/logstash/contributors","subscribers_url":"https://api.github.com/repos/ph/logstash/subscribers","subscription_url":"https://api.github.com/repos/ph/logstash/subscription","commits_url":"https://api.github.com/repos/ph/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/ph/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/ph/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/ph/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/ph/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/ph/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ph/logstash/merges","archive_url":"https://api.github.com/repos/ph/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ph/logstash/downloads","issues_url":"https://api.github.com/repos/ph/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/ph/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/ph/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/ph/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ph/logstash/labels{/name}","releases_url":"https://api.github.com/repos/ph/logstash/releases{/id}","created_at":"2014-10-06T19:37:59Z","updated_at":"2014-10-06T15:15:20Z","pushed_at":"2015-05-19T18:27:26Z","git_url":"git://github.com/ph/logstash.git","ssh_url":"git@github.com:ph/logstash.git","clone_url":"https://github.com/ph/logstash.git","svn_url":"https://github.com/ph/logstash","homepage":"http://logstash.net/","size":71692,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:1.4","ref":"1.4","sha":"457efa41dee957165e6cee9e4eb79f7cafc75ec5","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":1090311,"name":"logstash","full_name":"elastic/logstash","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/logstash","description":"logstash - transport and process your logs, events, or other data","fork":false,"url":"https://api.github.com/repos/elastic/logstash","forks_url":"https://api.github.com/repos/elastic/logstash/forks","keys_url":"https://api.github.com/repos/elastic/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/logstash/teams","hooks_url":"https://api.github.com/repos/elastic/logstash/hooks","issue_events_url":"https://api.github.com/repos/elastic/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/logstash/events","assignees_url":"https://api.github.com/repos/elastic/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/logstash/tags","blobs_url":"https://api.github.com/repos/elastic/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/logstash/languages","stargazers_url":"https://api.github.com/repos/elastic/logstash/stargazers","contributors_url":"https://api.github.com/repos/elastic/logstash/contributors","subscribers_url":"https://api.github.com/repos/elastic/logstash/subscribers","subscription_url":"https://api.github.com/repos/elastic/logstash/subscription","commits_url":"https://api.github.com/repos/elastic/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/logstash/merges","archive_url":"https://api.github.com/repos/elastic/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/logstash/downloads","issues_url":"https://api.github.com/repos/elastic/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/logstash/labels{/name}","releases_url":"https://api.github.com/repos/elastic/logstash/releases{/id}","created_at":"2010-11-18T01:31:50Z","updated_at":"2015-05-26T01:59:52Z","pushed_at":"2015-05-26T03:20:57Z","git_url":"git://github.com/elastic/logstash.git","ssh_url":"git@github.com:elastic/logstash.git","clone_url":"https://github.com/elastic/logstash.git","svn_url":"https://github.com/elastic/logstash","homepage":"https://www.elastic.co/products/logstash","size":91409,"stargazers_count":4208,"watchers_count":4208,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1437,"mirror_url":null,"open_issues_count":522,"forks":1437,"open_issues":522,"watchers":4208,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash/pulls/3279"},"html":{"href":"https://github.com/elastic/logstash/pull/3279"},"issue":{"href":"https://api.github.com/repos/elastic/logstash/issues/3279"},"comments":{"href":"https://api.github.com/repos/elastic/logstash/issues/3279/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/logstash/pulls/3279/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/logstash/pulls/3279/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/logstash/statuses/20140d21db8a486ca5467f63aae6117a684b0240"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"suyograo","id":1595958,"avatar_url":"https://avatars.githubusercontent.com/u/1595958?v=3","gravatar_id":"","url":"https://api.github.com/users/suyograo","html_url":"https://github.com/suyograo","followers_url":"https://api.github.com/users/suyograo/followers","following_url":"https://api.github.com/users/suyograo/following{/other_user}","gists_url":"https://api.github.com/users/suyograo/gists{/gist_id}","starred_url":"https://api.github.com/users/suyograo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suyograo/subscriptions","organizations_url":"https://api.github.com/users/suyograo/orgs","repos_url":"https://api.github.com/users/suyograo/repos","events_url":"https://api.github.com/users/suyograo/events{/privacy}","received_events_url":"https://api.github.com/users/suyograo/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":275,"deletions":23,"changed_files":2}}