{"action":"created","comment":{"url":"https://api.github.com/repos/brickify/brickify/pulls/comments/32328035","id":32328035,"diff_hunk":"@@ -16,13 +18,20 @@ module.exports = class Voxelizer\n \n \t\tvoxelSpaceModel = @_getOptimizedVoxelSpaceModel optimizedModel, options\n \n-\t\t@worker = @_getWorker()\n-\t\t@worker.voxelize voxelSpaceModel, lineStepSize, (message) =>\n+\t\tcallback = (message) =>\n \t\t\tif message.state is 'progress'\n \t\t\t\tprogressCallback message.progress\n \t\t\telse # if state is 'finished'\n \t\t\t\t@resolve grid: @voxelGrid, gridPOJO: message.data\n \n+\t\t@worker = @_getWorker()\n+\t\t@worker.voxelize(\n+\t\t\tvoxelSpaceModel\n+\t\t\tlineStepSize\n+\t\t\tfloatDelta","path":"src/plugins/newBrickator/pipeline/HullVoxelizer.coffee","position":24,"original_position":24,"commit_id":"231e39a4cba05a8ae2b618a21c204ae0ce52e525","original_commit_id":"231e39a4cba05a8ae2b618a21c204ae0ce52e525","user":{"login":"stuikomma","id":2040603,"avatar_url":"https://avatars.githubusercontent.com/u/2040603?v=3","gravatar_id":"","url":"https://api.github.com/users/stuikomma","html_url":"https://github.com/stuikomma","followers_url":"https://api.github.com/users/stuikomma/followers","following_url":"https://api.github.com/users/stuikomma/following{/other_user}","gists_url":"https://api.github.com/users/stuikomma/gists{/gist_id}","starred_url":"https://api.github.com/users/stuikomma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stuikomma/subscriptions","organizations_url":"https://api.github.com/users/stuikomma/orgs","repos_url":"https://api.github.com/users/stuikomma/repos","events_url":"https://api.github.com/users/stuikomma/events{/privacy}","received_events_url":"https://api.github.com/users/stuikomma/received_events","type":"User","site_admin":false},"body":"I meant that the definition of floatDelta isn't. It's in line 3.","created_at":"2015-06-12T15:51:38Z","updated_at":"2015-06-12T15:51:38Z","html_url":"https://github.com/brickify/brickify/pull/603#discussion_r32328035","pull_request_url":"https://api.github.com/repos/brickify/brickify/pulls/603","_links":{"self":{"href":"https://api.github.com/repos/brickify/brickify/pulls/comments/32328035"},"html":{"href":"https://github.com/brickify/brickify/pull/603#discussion_r32328035"},"pull_request":{"href":"https://api.github.com/repos/brickify/brickify/pulls/603"}}},"pull_request":{"url":"https://api.github.com/repos/brickify/brickify/pulls/603","id":37567591,"html_url":"https://github.com/brickify/brickify/pull/603","diff_url":"https://github.com/brickify/brickify/pull/603.diff","patch_url":"https://github.com/brickify/brickify/pull/603.patch","issue_url":"https://api.github.com/repos/brickify/brickify/issues/603","number":603,"state":"open","locked":false,"title":"prefer closing voxels","user":{"login":"stuikomma","id":2040603,"avatar_url":"https://avatars.githubusercontent.com/u/2040603?v=3","gravatar_id":"","url":"https://api.github.com/users/stuikomma","html_url":"https://github.com/stuikomma","followers_url":"https://api.github.com/users/stuikomma/followers","following_url":"https://api.github.com/users/stuikomma/following{/other_user}","gists_url":"https://api.github.com/users/stuikomma/gists{/gist_id}","starred_url":"https://api.github.com/users/stuikomma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stuikomma/subscriptions","organizations_url":"https://api.github.com/users/stuikomma/orgs","repos_url":"https://api.github.com/users/stuikomma/repos","events_url":"https://api.github.com/users/stuikomma/events{/privacy}","received_events_url":"https://api.github.com/users/stuikomma/received_events","type":"User","site_admin":false},"body":"Voxel that had both a negative and a positive normal at the same z level would get filled wrongly if the former was voxelized first. Now the positive normals take precedence over the other ones.\r\nfixes #598","created_at":"2015-06-12T14:09:49Z","updated_at":"2015-06-12T15:51:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5305ab65db9d6fc86b61919525a07db937226c2e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/brickify/brickify/pulls/603/commits","review_comments_url":"https://api.github.com/repos/brickify/brickify/pulls/603/comments","review_comment_url":"https://api.github.com/repos/brickify/brickify/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brickify/brickify/issues/603/comments","statuses_url":"https://api.github.com/repos/brickify/brickify/statuses/231e39a4cba05a8ae2b618a21c204ae0ce52e525","head":{"label":"brickify:feature/fix_voxelizer","ref":"feature/fix_voxelizer","sha":"231e39a4cba05a8ae2b618a21c204ae0ce52e525","user":{"login":"brickify","id":9961854,"avatar_url":"https://avatars.githubusercontent.com/u/9961854?v=3","gravatar_id":"","url":"https://api.github.com/users/brickify","html_url":"https://github.com/brickify","followers_url":"https://api.github.com/users/brickify/followers","following_url":"https://api.github.com/users/brickify/following{/other_user}","gists_url":"https://api.github.com/users/brickify/gists{/gist_id}","starred_url":"https://api.github.com/users/brickify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brickify/subscriptions","organizations_url":"https://api.github.com/users/brickify/orgs","repos_url":"https://api.github.com/users/brickify/repos","events_url":"https://api.github.com/users/brickify/events{/privacy}","received_events_url":"https://api.github.com/users/brickify/received_events","type":"Organization","site_admin":false},"repo":{"id":27174799,"name":"brickify","full_name":"brickify/brickify","owner":{"login":"brickify","id":9961854,"avatar_url":"https://avatars.githubusercontent.com/u/9961854?v=3","gravatar_id":"","url":"https://api.github.com/users/brickify","html_url":"https://github.com/brickify","followers_url":"https://api.github.com/users/brickify/followers","following_url":"https://api.github.com/users/brickify/following{/other_user}","gists_url":"https://api.github.com/users/brickify/gists{/gist_id}","starred_url":"https://api.github.com/users/brickify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brickify/subscriptions","organizations_url":"https://api.github.com/users/brickify/orgs","repos_url":"https://api.github.com/users/brickify/repos","events_url":"https://api.github.com/users/brickify/events{/privacy}","received_events_url":"https://api.github.com/users/brickify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brickify/brickify","description":"Speed up 3D printing using LEGO® bricks.","fork":false,"url":"https://api.github.com/repos/brickify/brickify","forks_url":"https://api.github.com/repos/brickify/brickify/forks","keys_url":"https://api.github.com/repos/brickify/brickify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brickify/brickify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brickify/brickify/teams","hooks_url":"https://api.github.com/repos/brickify/brickify/hooks","issue_events_url":"https://api.github.com/repos/brickify/brickify/issues/events{/number}","events_url":"https://api.github.com/repos/brickify/brickify/events","assignees_url":"https://api.github.com/repos/brickify/brickify/assignees{/user}","branches_url":"https://api.github.com/repos/brickify/brickify/branches{/branch}","tags_url":"https://api.github.com/repos/brickify/brickify/tags","blobs_url":"https://api.github.com/repos/brickify/brickify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brickify/brickify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brickify/brickify/git/refs{/sha}","trees_url":"https://api.github.com/repos/brickify/brickify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brickify/brickify/statuses/{sha}","languages_url":"https://api.github.com/repos/brickify/brickify/languages","stargazers_url":"https://api.github.com/repos/brickify/brickify/stargazers","contributors_url":"https://api.github.com/repos/brickify/brickify/contributors","subscribers_url":"https://api.github.com/repos/brickify/brickify/subscribers","subscription_url":"https://api.github.com/repos/brickify/brickify/subscription","commits_url":"https://api.github.com/repos/brickify/brickify/commits{/sha}","git_commits_url":"https://api.github.com/repos/brickify/brickify/git/commits{/sha}","comments_url":"https://api.github.com/repos/brickify/brickify/comments{/number}","issue_comment_url":"https://api.github.com/repos/brickify/brickify/issues/comments{/number}","contents_url":"https://api.github.com/repos/brickify/brickify/contents/{+path}","compare_url":"https://api.github.com/repos/brickify/brickify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brickify/brickify/merges","archive_url":"https://api.github.com/repos/brickify/brickify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brickify/brickify/downloads","issues_url":"https://api.github.com/repos/brickify/brickify/issues{/number}","pulls_url":"https://api.github.com/repos/brickify/brickify/pulls{/number}","milestones_url":"https://api.github.com/repos/brickify/brickify/milestones{/number}","notifications_url":"https://api.github.com/repos/brickify/brickify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brickify/brickify/labels{/name}","releases_url":"https://api.github.com/repos/brickify/brickify/releases{/id}","created_at":"2014-11-26T11:58:38Z","updated_at":"2015-06-09T11:45:40Z","pushed_at":"2015-06-12T15:05:25Z","git_url":"git://github.com/brickify/brickify.git","ssh_url":"git@github.com:brickify/brickify.git","clone_url":"https://github.com/brickify/brickify.git","svn_url":"https://github.com/brickify/brickify","homepage":"http://brickify.it","size":26562,"stargazers_count":6,"watchers_count":6,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":99,"forks":0,"open_issues":99,"watchers":6,"default_branch":"develop"}},"base":{"label":"brickify:develop","ref":"develop","sha":"70a96bc3edd58c2455130c2996f022fdb276c183","user":{"login":"brickify","id":9961854,"avatar_url":"https://avatars.githubusercontent.com/u/9961854?v=3","gravatar_id":"","url":"https://api.github.com/users/brickify","html_url":"https://github.com/brickify","followers_url":"https://api.github.com/users/brickify/followers","following_url":"https://api.github.com/users/brickify/following{/other_user}","gists_url":"https://api.github.com/users/brickify/gists{/gist_id}","starred_url":"https://api.github.com/users/brickify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brickify/subscriptions","organizations_url":"https://api.github.com/users/brickify/orgs","repos_url":"https://api.github.com/users/brickify/repos","events_url":"https://api.github.com/users/brickify/events{/privacy}","received_events_url":"https://api.github.com/users/brickify/received_events","type":"Organization","site_admin":false},"repo":{"id":27174799,"name":"brickify","full_name":"brickify/brickify","owner":{"login":"brickify","id":9961854,"avatar_url":"https://avatars.githubusercontent.com/u/9961854?v=3","gravatar_id":"","url":"https://api.github.com/users/brickify","html_url":"https://github.com/brickify","followers_url":"https://api.github.com/users/brickify/followers","following_url":"https://api.github.com/users/brickify/following{/other_user}","gists_url":"https://api.github.com/users/brickify/gists{/gist_id}","starred_url":"https://api.github.com/users/brickify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brickify/subscriptions","organizations_url":"https://api.github.com/users/brickify/orgs","repos_url":"https://api.github.com/users/brickify/repos","events_url":"https://api.github.com/users/brickify/events{/privacy}","received_events_url":"https://api.github.com/users/brickify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brickify/brickify","description":"Speed up 3D printing using LEGO® bricks.","fork":false,"url":"https://api.github.com/repos/brickify/brickify","forks_url":"https://api.github.com/repos/brickify/brickify/forks","keys_url":"https://api.github.com/repos/brickify/brickify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brickify/brickify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brickify/brickify/teams","hooks_url":"https://api.github.com/repos/brickify/brickify/hooks","issue_events_url":"https://api.github.com/repos/brickify/brickify/issues/events{/number}","events_url":"https://api.github.com/repos/brickify/brickify/events","assignees_url":"https://api.github.com/repos/brickify/brickify/assignees{/user}","branches_url":"https://api.github.com/repos/brickify/brickify/branches{/branch}","tags_url":"https://api.github.com/repos/brickify/brickify/tags","blobs_url":"https://api.github.com/repos/brickify/brickify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brickify/brickify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brickify/brickify/git/refs{/sha}","trees_url":"https://api.github.com/repos/brickify/brickify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brickify/brickify/statuses/{sha}","languages_url":"https://api.github.com/repos/brickify/brickify/languages","stargazers_url":"https://api.github.com/repos/brickify/brickify/stargazers","contributors_url":"https://api.github.com/repos/brickify/brickify/contributors","subscribers_url":"https://api.github.com/repos/brickify/brickify/subscribers","subscription_url":"https://api.github.com/repos/brickify/brickify/subscription","commits_url":"https://api.github.com/repos/brickify/brickify/commits{/sha}","git_commits_url":"https://api.github.com/repos/brickify/brickify/git/commits{/sha}","comments_url":"https://api.github.com/repos/brickify/brickify/comments{/number}","issue_comment_url":"https://api.github.com/repos/brickify/brickify/issues/comments{/number}","contents_url":"https://api.github.com/repos/brickify/brickify/contents/{+path}","compare_url":"https://api.github.com/repos/brickify/brickify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brickify/brickify/merges","archive_url":"https://api.github.com/repos/brickify/brickify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brickify/brickify/downloads","issues_url":"https://api.github.com/repos/brickify/brickify/issues{/number}","pulls_url":"https://api.github.com/repos/brickify/brickify/pulls{/number}","milestones_url":"https://api.github.com/repos/brickify/brickify/milestones{/number}","notifications_url":"https://api.github.com/repos/brickify/brickify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brickify/brickify/labels{/name}","releases_url":"https://api.github.com/repos/brickify/brickify/releases{/id}","created_at":"2014-11-26T11:58:38Z","updated_at":"2015-06-09T11:45:40Z","pushed_at":"2015-06-12T15:05:25Z","git_url":"git://github.com/brickify/brickify.git","ssh_url":"git@github.com:brickify/brickify.git","clone_url":"https://github.com/brickify/brickify.git","svn_url":"https://github.com/brickify/brickify","homepage":"http://brickify.it","size":26562,"stargazers_count":6,"watchers_count":6,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":99,"forks":0,"open_issues":99,"watchers":6,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/brickify/brickify/pulls/603"},"html":{"href":"https://github.com/brickify/brickify/pull/603"},"issue":{"href":"https://api.github.com/repos/brickify/brickify/issues/603"},"comments":{"href":"https://api.github.com/repos/brickify/brickify/issues/603/comments"},"review_comments":{"href":"https://api.github.com/repos/brickify/brickify/pulls/603/comments"},"review_comment":{"href":"https://api.github.com/repos/brickify/brickify/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brickify/brickify/pulls/603/commits"},"statuses":{"href":"https://api.github.com/repos/brickify/brickify/statuses/231e39a4cba05a8ae2b618a21c204ae0ce52e525"}}}}