{"action":"created","comment":{"url":"https://api.github.com/repos/systemd/systemd/pulls/comments/44873729","id":44873729,"diff_hunk":"@@ -0,0 +1,28 @@\n+#  -*- Mode: makefile; indent-tabs-mode: t -*- */\n+#\n+#  -*- Mode: rpm-spec; indent-tabs-mode: nil -*- */\n+#\n+#  This file is part of systemd.\n+#\n+#  Copyright 2015 Zbigniew Jędrzejewski-Szmek\n+#\n+#  systemd is free software; you can redistribute it and/or modify it\n+#  under the terms of the GNU Lesser General Public License as published by\n+#  the Free Software Foundation; either version 2.1 of the License, or\n+#  (at your option) any later version.\n+#\n+#  systemd is distributed in the hope that it will be useful, but\n+#  WITHOUT ANY WARRANTY; without even the implied warranty of\n+#  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU\n+#  Lesser General Public License for more details.\n+#\n+#  You should have received a copy of the GNU Lesser General Public License\n+#  along with systemd; If not, see <http://www.gnu.org/licenses/>.\n+\n+# The contents of this are an example to be copied into systemd.spec.\n+\n+%transfiletriggerin -- @systemunitdir@ /etc/systemd/system","path":"src/core/triggers.systemd.in","position":24,"original_position":24,"commit_id":"e395ea8a1dcf17fd5db2072ed51f70ab35c6ce43","original_commit_id":"e395ea8a1dcf17fd5db2072ed51f70ab35c6ce43","user":{"login":"keszybz","id":349618,"avatar_url":"https://avatars.githubusercontent.com/u/349618?v=3","gravatar_id":"","url":"https://api.github.com/users/keszybz","html_url":"https://github.com/keszybz","followers_url":"https://api.github.com/users/keszybz/followers","following_url":"https://api.github.com/users/keszybz/following{/other_user}","gists_url":"https://api.github.com/users/keszybz/gists{/gist_id}","starred_url":"https://api.github.com/users/keszybz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keszybz/subscriptions","organizations_url":"https://api.github.com/users/keszybz/orgs","repos_url":"https://api.github.com/users/keszybz/repos","events_url":"https://api.github.com/users/keszybz/events{/privacy}","received_events_url":"https://api.github.com/users/keszybz/received_events","type":"User","site_admin":false},"body":"It's a \"better safe than sorry\" consideration. Some packages install commented-out files in there (systemd itself, sssd, tlp). In principle those files shouldn't matter, but I thought it would be simpler to also react to that than to prove that we don't ever need to. Anyway, since packages *rarely* install anything there, triggering on /etc is not costly.","created_at":"2015-11-15T16:33:17Z","updated_at":"2015-11-15T16:33:17Z","html_url":"https://github.com/systemd/systemd/pull/1893#discussion_r44873729","pull_request_url":"https://api.github.com/repos/systemd/systemd/pulls/1893","_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments/44873729"},"html":{"href":"https://github.com/systemd/systemd/pull/1893#discussion_r44873729"},"pull_request":{"href":"https://api.github.com/repos/systemd/systemd/pulls/1893"}}},"pull_request":{"url":"https://api.github.com/repos/systemd/systemd/pulls/1893","id":50736078,"html_url":"https://github.com/systemd/systemd/pull/1893","diff_url":"https://github.com/systemd/systemd/pull/1893.diff","patch_url":"https://github.com/systemd/systemd/pull/1893.patch","issue_url":"https://api.github.com/repos/systemd/systemd/issues/1893","number":1893,"state":"open","locked":false,"title":"RFC: Filetriggers","user":{"login":"keszybz","id":349618,"avatar_url":"https://avatars.githubusercontent.com/u/349618?v=3","gravatar_id":"","url":"https://api.github.com/users/keszybz","html_url":"https://github.com/keszybz","followers_url":"https://api.github.com/users/keszybz/followers","following_url":"https://api.github.com/users/keszybz/following{/other_user}","gists_url":"https://api.github.com/users/keszybz/gists{/gist_id}","starred_url":"https://api.github.com/users/keszybz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keszybz/subscriptions","organizations_url":"https://api.github.com/users/keszybz/orgs","repos_url":"https://api.github.com/users/keszybz/repos","events_url":"https://api.github.com/users/keszybz/events{/privacy}","received_events_url":"https://api.github.com/users/keszybz/received_events","type":"User","site_admin":false},"body":"Fedora change page: https://fedoraproject.org/wiki/Changes/systemd_file_triggers\r\n\r\nI'm putting this out here for comments. It appears to work fine, but there're still some open questions, at least https://bugzilla.redhat.com/show_bug.cgi?id=1282115.","created_at":"2015-11-15T00:25:07Z","updated_at":"2015-11-15T16:33:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53e713e052c85f442800c0ececc1f86484522a99","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/systemd/systemd/pulls/1893/commits","review_comments_url":"https://api.github.com/repos/systemd/systemd/pulls/1893/comments","review_comment_url":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/systemd/systemd/issues/1893/comments","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/e395ea8a1dcf17fd5db2072ed51f70ab35c6ce43","head":{"label":"keszybz:filetriggers","ref":"filetriggers","sha":"e395ea8a1dcf17fd5db2072ed51f70ab35c6ce43","user":{"login":"keszybz","id":349618,"avatar_url":"https://avatars.githubusercontent.com/u/349618?v=3","gravatar_id":"","url":"https://api.github.com/users/keszybz","html_url":"https://github.com/keszybz","followers_url":"https://api.github.com/users/keszybz/followers","following_url":"https://api.github.com/users/keszybz/following{/other_user}","gists_url":"https://api.github.com/users/keszybz/gists{/gist_id}","starred_url":"https://api.github.com/users/keszybz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keszybz/subscriptions","organizations_url":"https://api.github.com/users/keszybz/orgs","repos_url":"https://api.github.com/users/keszybz/repos","events_url":"https://api.github.com/users/keszybz/events{/privacy}","received_events_url":"https://api.github.com/users/keszybz/received_events","type":"User","site_admin":false},"repo":{"id":37000824,"name":"systemd","full_name":"keszybz/systemd","owner":{"login":"keszybz","id":349618,"avatar_url":"https://avatars.githubusercontent.com/u/349618?v=3","gravatar_id":"","url":"https://api.github.com/users/keszybz","html_url":"https://github.com/keszybz","followers_url":"https://api.github.com/users/keszybz/followers","following_url":"https://api.github.com/users/keszybz/following{/other_user}","gists_url":"https://api.github.com/users/keszybz/gists{/gist_id}","starred_url":"https://api.github.com/users/keszybz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keszybz/subscriptions","organizations_url":"https://api.github.com/users/keszybz/orgs","repos_url":"https://api.github.com/users/keszybz/repos","events_url":"https://api.github.com/users/keszybz/events{/privacy}","received_events_url":"https://api.github.com/users/keszybz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/keszybz/systemd","description":"systemd upstream","fork":true,"url":"https://api.github.com/repos/keszybz/systemd","forks_url":"https://api.github.com/repos/keszybz/systemd/forks","keys_url":"https://api.github.com/repos/keszybz/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keszybz/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keszybz/systemd/teams","hooks_url":"https://api.github.com/repos/keszybz/systemd/hooks","issue_events_url":"https://api.github.com/repos/keszybz/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/keszybz/systemd/events","assignees_url":"https://api.github.com/repos/keszybz/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/keszybz/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/keszybz/systemd/tags","blobs_url":"https://api.github.com/repos/keszybz/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keszybz/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keszybz/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/keszybz/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keszybz/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/keszybz/systemd/languages","stargazers_url":"https://api.github.com/repos/keszybz/systemd/stargazers","contributors_url":"https://api.github.com/repos/keszybz/systemd/contributors","subscribers_url":"https://api.github.com/repos/keszybz/systemd/subscribers","subscription_url":"https://api.github.com/repos/keszybz/systemd/subscription","commits_url":"https://api.github.com/repos/keszybz/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/keszybz/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/keszybz/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/keszybz/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/keszybz/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/keszybz/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keszybz/systemd/merges","archive_url":"https://api.github.com/repos/keszybz/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keszybz/systemd/downloads","issues_url":"https://api.github.com/repos/keszybz/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/keszybz/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/keszybz/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/keszybz/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keszybz/systemd/labels{/name}","releases_url":"https://api.github.com/repos/keszybz/systemd/releases{/id}","created_at":"2015-06-07T01:43:08Z","updated_at":"2015-06-07T01:43:13Z","pushed_at":"2015-11-15T00:24:31Z","git_url":"git://github.com/keszybz/systemd.git","ssh_url":"git@github.com:keszybz/systemd.git","clone_url":"https://github.com/keszybz/systemd.git","svn_url":"https://github.com/keszybz/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":45807,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"systemd:master","ref":"master","sha":"eee15abcdb04ff2528409f82616216ae2e3b55ff","user":{"login":"systemd","id":1918868,"avatar_url":"https://avatars.githubusercontent.com/u/1918868?v=3","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"repo":{"id":32873313,"name":"systemd","full_name":"systemd/systemd","owner":{"login":"systemd","id":1918868,"avatar_url":"https://avatars.githubusercontent.com/u/1918868?v=3","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/systemd/systemd","description":"systemd upstream","fork":false,"url":"https://api.github.com/repos/systemd/systemd","forks_url":"https://api.github.com/repos/systemd/systemd/forks","keys_url":"https://api.github.com/repos/systemd/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/systemd/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/systemd/systemd/teams","hooks_url":"https://api.github.com/repos/systemd/systemd/hooks","issue_events_url":"https://api.github.com/repos/systemd/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/systemd/systemd/events","assignees_url":"https://api.github.com/repos/systemd/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/systemd/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/systemd/systemd/tags","blobs_url":"https://api.github.com/repos/systemd/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/systemd/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/systemd/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/systemd/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/systemd/systemd/languages","stargazers_url":"https://api.github.com/repos/systemd/systemd/stargazers","contributors_url":"https://api.github.com/repos/systemd/systemd/contributors","subscribers_url":"https://api.github.com/repos/systemd/systemd/subscribers","subscription_url":"https://api.github.com/repos/systemd/systemd/subscription","commits_url":"https://api.github.com/repos/systemd/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/systemd/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/systemd/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/systemd/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/systemd/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/systemd/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/systemd/systemd/merges","archive_url":"https://api.github.com/repos/systemd/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/systemd/systemd/downloads","issues_url":"https://api.github.com/repos/systemd/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/systemd/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/systemd/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/systemd/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/systemd/systemd/labels{/name}","releases_url":"https://api.github.com/repos/systemd/systemd/releases{/id}","created_at":"2015-03-25T15:27:27Z","updated_at":"2015-11-14T16:38:37Z","pushed_at":"2015-11-15T16:31:18Z","git_url":"git://github.com/systemd/systemd.git","ssh_url":"git@github.com:systemd/systemd.git","clone_url":"https://github.com/systemd/systemd.git","svn_url":"https://github.com/systemd/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":59160,"stargazers_count":688,"watchers_count":688,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":270,"mirror_url":null,"open_issues_count":239,"forks":270,"open_issues":239,"watchers":688,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/1893"},"html":{"href":"https://github.com/systemd/systemd/pull/1893"},"issue":{"href":"https://api.github.com/repos/systemd/systemd/issues/1893"},"comments":{"href":"https://api.github.com/repos/systemd/systemd/issues/1893/comments"},"review_comments":{"href":"https://api.github.com/repos/systemd/systemd/pulls/1893/comments"},"review_comment":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/systemd/systemd/pulls/1893/commits"},"statuses":{"href":"https://api.github.com/repos/systemd/systemd/statuses/e395ea8a1dcf17fd5db2072ed51f70ab35c6ce43"}}}}