{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4900","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4900/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4900/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4900/events","html_url":"https://github.com/ManageIQ/manageiq/pull/4900","id":111652082,"number":4900,"title":"[WIP] dhtmlxgrid - remove dhtmlxgrid, replace XML with PORO","user":{"login":"himdel","id":289743,"avatar_url":"https://avatars.githubusercontent.com/u/289743?v=3","gravatar_id":"","url":"https://api.github.com/users/himdel","html_url":"https://github.com/himdel","followers_url":"https://api.github.com/users/himdel/followers","following_url":"https://api.github.com/users/himdel/following{/other_user}","gists_url":"https://api.github.com/users/himdel/gists{/gist_id}","starred_url":"https://api.github.com/users/himdel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himdel/subscriptions","organizations_url":"https://api.github.com/users/himdel/orgs","repos_url":"https://api.github.com/users/himdel/repos","events_url":"https://api.github.com/users/himdel/events{/privacy}","received_events_url":"https://api.github.com/users/himdel/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/technical%20debt","name":"technical debt","color":"eb6420"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/ui","name":"ui","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/wip","name":"wip","color":"eeeeee"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-10-15T16:11:53Z","updated_at":"2015-10-26T15:24:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4900","html_url":"https://github.com/ManageIQ/manageiq/pull/4900","diff_url":"https://github.com/ManageIQ/manageiq/pull/4900.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/4900.patch"},"body":"   * Replaces dhtmlxgrid with a vanilla patternfly table\r\n   * Replaces view_to_xml with view_to_hash (and grid_xml with grid_hash)\r\n   * Completely removes the save_col_widths logic, and settings[:col_widths], etc.\r\n   * ManageIQ.grids.grids.FOO is now ManageIQ.grids.FOO\r\n   * ..."},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/151173586","html_url":"https://github.com/ManageIQ/manageiq/pull/4900#issuecomment-151173586","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4900","id":151173586,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2015-10-26T15:24:55Z","updated_at":"2015-10-26T15:24:55Z","body":"<rubocop />Checked commits https://github.com/himdel/manageiq/compare/1fe86d728abd9024fd7cd8b86c721ff322477c94~...7910e97e064be67bc032c50fa839f50929868ae1 with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0\n12 files checked, 38 offenses detected\n\n**app/controllers/application_controller.rb**\n- [ ] :large_orange_diamond: - [Line 1057](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/controllers/application_controller.rb#L1057), Col 39 - [Style/ExtraSpacing](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Style/ExtraSpacing) - Unnecessary spacing detected.\n- [ ] :large_orange_diamond: - [Line 1927](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/controllers/application_controller.rb#L1927), Col 36 - [Style/NonNilCheck](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Style/NonNilCheck) - Prefer `!expression.nil?` over `expression != nil`.\n- [ ] :large_orange_diamond: - [Line 1936](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/controllers/application_controller.rb#L1936), Col 21 - [Style/AlignHash](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Style/AlignHash) - Align the elements of a hash literal if they span more than one line.\n- [ ] :large_orange_diamond: - [Line 1937](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/controllers/application_controller.rb#L1937), Col 21 - [Style/AlignHash](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Style/AlignHash) - Align the elements of a hash literal if they span more than one line.\n- [ ] :large_orange_diamond: - [Line 1938](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/controllers/application_controller.rb#L1938), Col 21 - [Style/AlignHash](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Style/AlignHash) - Align the elements of a hash literal if they span more than one line.\n- [ ] :large_orange_diamond: - [Line 1939](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/controllers/application_controller.rb#L1939), Col 21 - [Style/AlignHash](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Style/AlignHash) - Align the elements of a hash literal if they span more than one line.\n- [ ] :large_orange_diamond: - [Line 1940](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/controllers/application_controller.rb#L1940), Col 21 - [Style/AlignHash](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Style/AlignHash) - Align the elements of a hash literal if they span more than one line.\n- [ ] :large_orange_diamond: - [Line 1941](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/controllers/application_controller.rb#L1941), Col 19 - [Style/AlignHash](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Style/AlignHash) - Align the elements of a hash literal if they span more than one line.\n- [ ] :large_orange_diamond: - [Line 1942](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/controllers/application_controller.rb#L1942), Col 19 - [Style/AlignHash](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Style/AlignHash) - Align the elements of a hash literal if they span more than one line.\n- [ ] :large_orange_diamond: - [Line 1943](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/controllers/application_controller.rb#L1943), Col 19 - [Style/AlignHash](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Style/AlignHash) - Align the elements of a hash literal if they span more than one line.\n- [ ] :large_orange_diamond: - [Line 1944](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/controllers/application_controller.rb#L1944), Col 19 - [Style/AlignHash](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Style/AlignHash) - Align the elements of a hash literal if they span more than one line.\n- [ ] :large_orange_diamond: - [Line 1945](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/controllers/application_controller.rb#L1945), Col 19 - [Style/AlignHash](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Style/AlignHash) - Align the elements of a hash literal if they span more than one line.\n- [ ] :large_orange_diamond: - [Line 1948](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/controllers/application_controller.rb#L1948), Col 37 - [Style/AlignHash](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Style/AlignHash) - Align the elements of a hash literal if they span more than one line.\n- [ ] :small_blue_diamond: - [Line 1050](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/controllers/application_controller.rb#L1050), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for view_to_hash is too high. [75.68/15]\n- [ ] :small_blue_diamond: - [Line 1050](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/controllers/application_controller.rb#L1050), Col 3 - [Metrics/CyclomaticComplexity](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Metrics/CyclomaticComplexity) - Cyclomatic complexity for view_to_hash is too high. [21/6]\n- [ ] :small_blue_diamond: - [Line 1050](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/controllers/application_controller.rb#L1050), Col 3 - [Metrics/MethodLength](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Metrics/MethodLength) - Method has too many lines. [55/25]\n- [ ] :small_blue_diamond: - [Line 1050](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/controllers/application_controller.rb#L1050), Col 3 - [Metrics/PerceivedComplexity](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Metrics/PerceivedComplexity) - Perceived complexity for view_to_hash is too high. [19/7]\n- [ ] :small_blue_diamond: - [Line 1134](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/controllers/application_controller.rb#L1134), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for listicon_image is too high. [39.9/15]\n- [ ] :small_blue_diamond: - [Line 1134](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/controllers/application_controller.rb#L1134), Col 3 - [Metrics/CyclomaticComplexity](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Metrics/CyclomaticComplexity) - Cyclomatic complexity for listicon_image is too high. [21/6]\n- [ ] :small_blue_diamond: - [Line 1134](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/controllers/application_controller.rb#L1134), Col 3 - [Metrics/MethodLength](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Metrics/MethodLength) - Method has too many lines. [32/25]\n- [ ] :small_blue_diamond: - [Line 1134](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/controllers/application_controller.rb#L1134), Col 3 - [Metrics/PerceivedComplexity](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Metrics/PerceivedComplexity) - Perceived complexity for listicon_image is too high. [12/7]\n- [ ] :small_blue_diamond: - [Line 1918](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/controllers/application_controller.rb#L1918), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for replace_list_grid is too high. [22.16/15]\n- [ ] :small_blue_diamond: - [Line 1918](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/controllers/application_controller.rb#L1918), Col 3 - [Metrics/CyclomaticComplexity](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Metrics/CyclomaticComplexity) - Cyclomatic complexity for replace_list_grid is too high. [10/6]\n- [ ] :small_blue_diamond: - [Line 1918](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/controllers/application_controller.rb#L1918), Col 3 - [Metrics/MethodLength](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Metrics/MethodLength) - Method has too many lines. [28/25]\n- [ ] :small_blue_diamond: - [Line 1918](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/controllers/application_controller.rb#L1918), Col 3 - [Metrics/PerceivedComplexity](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Metrics/PerceivedComplexity) - Perceived complexity for replace_list_grid is too high. [11/7]\n- [ ] :small_blue_diamond: - [Line 1933](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/controllers/application_controller.rb#L1933), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [192/120]\n\n**app/views/layouts/_dhtmlxgrid.html.haml**\n- [ ] :red_circle: **Warn** - [Line 38](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/views/layouts/_dhtmlxgrid.html.haml#L38), Col  -  - Style/SpaceAfterNot: Do not leave space between `!` and its argument.\n- [ ] :red_circle: **Warn** - [Line 38](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/views/layouts/_dhtmlxgrid.html.haml#L38), Col  -  - Style/SpaceAfterNot: Do not leave space between `!` and its argument.\n- [ ] :red_circle: **Warn** - [Line 42](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/views/layouts/_dhtmlxgrid.html.haml#L42), Col  -  - Style/DoubleNegation: Avoid the use of double negation (`!!`).\n- [ ] :red_circle: **Warn** - [Line 42](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/views/layouts/_dhtmlxgrid.html.haml#L42), Col  -  - Style/SpaceAfterNot: Do not leave space between `!` and its argument.\n- [ ] :red_circle: **Warn** - [Line 55](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/views/layouts/_dhtmlxgrid.html.haml#L55), Col  -  - Style/BracesAroundHashParameters: Redundant curly braces around a hash parameter.\n\n**app/views/layouts/gtl/_list.html.haml**\n- [ ] :red_circle: **Warn** - [Line 12](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/views/layouts/gtl/_list.html.haml#L12), Col  -  - Line is too long. [196/160]\n- [ ] :red_circle: **Warn** - [Line 93](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/views/layouts/gtl/_list.html.haml#L93), Col  -  - Metrics/BlockNesting: Avoid more than 3 levels of block nesting.\n- [ ] :red_circle: **Warn** - [Line 94](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/views/layouts/gtl/_list.html.haml#L94), Col  -  - Metrics/BlockNesting: Avoid more than 3 levels of block nesting.\n- [ ] :red_circle: **Warn** - [Line 126](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/views/layouts/gtl/_list.html.haml#L126), Col  -  - Metrics/BlockNesting: Avoid more than 3 levels of block nesting.\n- [ ] :red_circle: **Warn** - [Line 131](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/app/views/layouts/gtl/_list.html.haml#L131), Col  -  - Metrics/BlockNesting: Avoid more than 3 levels of block nesting.\n\n**config/routes.rb**\n- [ ] :large_orange_diamond: - [Line 420](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/config/routes.rb#L420), Col 11 - [Style/ExtraSpacing](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Style/ExtraSpacing) - Unnecessary spacing detected.\n- [ ] :large_orange_diamond: - [Line 448](https://github.com/himdel/manageiq/blob/7910e97e064be67bc032c50fa839f50929868ae1/config/routes.rb#L448), Col 11 - [Style/ExtraSpacing](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Style/ExtraSpacing) - Unnecessary spacing detected.\n"}}