{"push_id":625285450,"size":1,"distinct_size":1,"ref":"refs/heads/wmf/1.25wmf23","head":"2f3a3dcf3c88483f64c9b668563c2a1909235335","before":"f5528203bbf91ceeeadaf785184748ab44afe993","commits":[{"sha":"2f3a3dcf3c88483f64c9b668563c2a1909235335","author":{"email":"50ca0c48f84890f36429654e16bfac06aad43e5e@live.com","name":"Kevin Israel"},"message":"Allow setting anonnotice to \"\" to prevent fallback to sitenotice\n\nPreviously we only used Message::isDisabled (non-existent, empty string,\nor \"-\") to decide whether to show a notice. If 'anonnotice' was disabled\n'sitenotice' was shown instead.\n\nWhen addressing logged-in users only, wikis typically use 'sitenotice'\nand then put invisible content in 'anonnotice' (so that it shadows the\n'sitenotice'). Now that the DismissableSiteNotice extension supports\nclosing of the notice for anonymous users (as of I87df3301c), this\nbecomes problematic as it has no way of knowing the notice was meant to\nbe invisible (and thus renders bogus \"[close]\" to all users).\n\nThis supersedes hacks such as <p></p> or <span></span>. Instead, the\nempty string can now be used to have no anonnotice content, but also\ndon't show the 'sitenotice'.\n\nDisabling with '-' (default) can still used to fallback to 'sitenotice'.\n\nAlso changed the code to, for consistency, allow hiding $wgSiteNotice\nfor all users by setting the sitenotice message to \"-\".\n\nBug: T94536\nChange-Id: I11b8b883d480d0e07d8b395dd92360cb15de7c5b\n(cherry picked from commit 251b345151a1ce517d9f06f9bfa18d520a6c7e5a)","distinct":true,"url":"https://api.github.com/repos/wikimedia/mediawiki/commits/2f3a3dcf3c88483f64c9b668563c2a1909235335"}]}