{"action":"created","comment":{"url":"https://api.github.com/repos/aodn/core-geonetwork/pulls/comments/40054531","id":40054531,"diff_hunk":"@@ -0,0 +1,91 @@\n+package org.fao.geonet.monitor.link;\n+\n+import org.jdom.Element;\n+\n+import java.util.ArrayList;\n+import java.util.Collections;\n+import java.util.List;\n+\n+public class LinkInfo {\n+\n+    private List<CheckInfo> checkInfoList;\n+\n+    private final Element onlineResource;\n+\n+    private final LinkCheckerInterface linkChecker;\n+\n+    public LinkInfo(Element onlineResource, LinkCheckerInterface linkChecker) {\n+        checkInfoList = Collections.synchronizedList(new ArrayList<CheckInfo>());","path":"web/src/main/java/org/fao/geonet/monitor/link/LinkInfo.java","position":18,"original_position":18,"commit_id":"c9a071281995071a828e47bdeb484a0c92bf65af","original_commit_id":"c9a071281995071a828e47bdeb484a0c92bf65af","user":{"login":"jkburges","id":1849176,"avatar_url":"https://avatars.githubusercontent.com/u/1849176?v=3","gravatar_id":"","url":"https://api.github.com/users/jkburges","html_url":"https://github.com/jkburges","followers_url":"https://api.github.com/users/jkburges/followers","following_url":"https://api.github.com/users/jkburges/following{/other_user}","gists_url":"https://api.github.com/users/jkburges/gists{/gist_id}","starred_url":"https://api.github.com/users/jkburges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkburges/subscriptions","organizations_url":"https://api.github.com/users/jkburges/orgs","repos_url":"https://api.github.com/users/jkburges/repos","events_url":"https://api.github.com/users/jkburges/events{/privacy}","received_events_url":"https://api.github.com/users/jkburges/received_events","type":"User","site_admin":false},"body":"Why the need for a synchronized list?  In any case, we're not synchronizing on it when iterating (see http://docs.oracle.com/javase/7/docs/api/java/util/Collections.html#synchronizedList(java.util.List)) so in case we *do* actually need it, then we've possibly got a bug.","created_at":"2015-09-22T05:49:14Z","updated_at":"2015-09-22T05:49:14Z","html_url":"https://github.com/aodn/core-geonetwork/pull/41#discussion_r40054531","pull_request_url":"https://api.github.com/repos/aodn/core-geonetwork/pulls/41","_links":{"self":{"href":"https://api.github.com/repos/aodn/core-geonetwork/pulls/comments/40054531"},"html":{"href":"https://github.com/aodn/core-geonetwork/pull/41#discussion_r40054531"},"pull_request":{"href":"https://api.github.com/repos/aodn/core-geonetwork/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/aodn/core-geonetwork/pulls/41","id":45362913,"html_url":"https://github.com/aodn/core-geonetwork/pull/41","diff_url":"https://github.com/aodn/core-geonetwork/pull/41.diff","patch_url":"https://github.com/aodn/core-geonetwork/pull/41.patch","issue_url":"https://api.github.com/repos/aodn/core-geonetwork/issues/41","number":41,"state":"open","locked":false,"title":"Link Monitor","user":{"login":"danfruehauf","id":830676,"avatar_url":"https://avatars.githubusercontent.com/u/830676?v=3","gravatar_id":"","url":"https://api.github.com/users/danfruehauf","html_url":"https://github.com/danfruehauf","followers_url":"https://api.github.com/users/danfruehauf/followers","following_url":"https://api.github.com/users/danfruehauf/following{/other_user}","gists_url":"https://api.github.com/users/danfruehauf/gists{/gist_id}","starred_url":"https://api.github.com/users/danfruehauf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danfruehauf/subscriptions","organizations_url":"https://api.github.com/users/danfruehauf/orgs","repos_url":"https://api.github.com/users/danfruehauf/repos","events_url":"https://api.github.com/users/danfruehauf/events{/privacy}","received_events_url":"https://api.github.com/users/danfruehauf/received_events","type":"User","site_admin":false},"body":" * Core logic (and interface)\r\n * Unit tests","created_at":"2015-09-18T02:19:05Z","updated_at":"2015-09-22T05:49:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75b1c9211b701364c355c6c70840d0af6eb2c9d6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aodn/core-geonetwork/pulls/41/commits","review_comments_url":"https://api.github.com/repos/aodn/core-geonetwork/pulls/41/comments","review_comment_url":"https://api.github.com/repos/aodn/core-geonetwork/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aodn/core-geonetwork/issues/41/comments","statuses_url":"https://api.github.com/repos/aodn/core-geonetwork/statuses/c9a071281995071a828e47bdeb484a0c92bf65af","head":{"label":"aodn:2.10.x-imos-link-monitor","ref":"2.10.x-imos-link-monitor","sha":"c9a071281995071a828e47bdeb484a0c92bf65af","user":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?v=3","gravatar_id":"","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"repo":{"id":21967655,"name":"core-geonetwork","full_name":"aodn/core-geonetwork","owner":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?v=3","gravatar_id":"","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aodn/core-geonetwork","description":"GeoNetwork repository","fork":true,"url":"https://api.github.com/repos/aodn/core-geonetwork","forks_url":"https://api.github.com/repos/aodn/core-geonetwork/forks","keys_url":"https://api.github.com/repos/aodn/core-geonetwork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aodn/core-geonetwork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aodn/core-geonetwork/teams","hooks_url":"https://api.github.com/repos/aodn/core-geonetwork/hooks","issue_events_url":"https://api.github.com/repos/aodn/core-geonetwork/issues/events{/number}","events_url":"https://api.github.com/repos/aodn/core-geonetwork/events","assignees_url":"https://api.github.com/repos/aodn/core-geonetwork/assignees{/user}","branches_url":"https://api.github.com/repos/aodn/core-geonetwork/branches{/branch}","tags_url":"https://api.github.com/repos/aodn/core-geonetwork/tags","blobs_url":"https://api.github.com/repos/aodn/core-geonetwork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aodn/core-geonetwork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aodn/core-geonetwork/git/refs{/sha}","trees_url":"https://api.github.com/repos/aodn/core-geonetwork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aodn/core-geonetwork/statuses/{sha}","languages_url":"https://api.github.com/repos/aodn/core-geonetwork/languages","stargazers_url":"https://api.github.com/repos/aodn/core-geonetwork/stargazers","contributors_url":"https://api.github.com/repos/aodn/core-geonetwork/contributors","subscribers_url":"https://api.github.com/repos/aodn/core-geonetwork/subscribers","subscription_url":"https://api.github.com/repos/aodn/core-geonetwork/subscription","commits_url":"https://api.github.com/repos/aodn/core-geonetwork/commits{/sha}","git_commits_url":"https://api.github.com/repos/aodn/core-geonetwork/git/commits{/sha}","comments_url":"https://api.github.com/repos/aodn/core-geonetwork/comments{/number}","issue_comment_url":"https://api.github.com/repos/aodn/core-geonetwork/issues/comments{/number}","contents_url":"https://api.github.com/repos/aodn/core-geonetwork/contents/{+path}","compare_url":"https://api.github.com/repos/aodn/core-geonetwork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aodn/core-geonetwork/merges","archive_url":"https://api.github.com/repos/aodn/core-geonetwork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aodn/core-geonetwork/downloads","issues_url":"https://api.github.com/repos/aodn/core-geonetwork/issues{/number}","pulls_url":"https://api.github.com/repos/aodn/core-geonetwork/pulls{/number}","milestones_url":"https://api.github.com/repos/aodn/core-geonetwork/milestones{/number}","notifications_url":"https://api.github.com/repos/aodn/core-geonetwork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aodn/core-geonetwork/labels{/name}","releases_url":"https://api.github.com/repos/aodn/core-geonetwork/releases{/id}","created_at":"2014-07-18T04:26:22Z","updated_at":"2015-04-01T04:58:58Z","pushed_at":"2015-09-21T23:03:02Z","git_url":"git://github.com/aodn/core-geonetwork.git","ssh_url":"git@github.com:aodn/core-geonetwork.git","clone_url":"https://github.com/aodn/core-geonetwork.git","svn_url":"https://github.com/aodn/core-geonetwork","homepage":"http://geonetwork-opensource.org/","size":246770,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":0,"default_branch":"2.10.x-imos"}},"base":{"label":"aodn:2.10.x-imos","ref":"2.10.x-imos","sha":"7df73780867f6ceea2486aa4b0a92df9790506aa","user":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?v=3","gravatar_id":"","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"repo":{"id":21967655,"name":"core-geonetwork","full_name":"aodn/core-geonetwork","owner":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?v=3","gravatar_id":"","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aodn/core-geonetwork","description":"GeoNetwork repository","fork":true,"url":"https://api.github.com/repos/aodn/core-geonetwork","forks_url":"https://api.github.com/repos/aodn/core-geonetwork/forks","keys_url":"https://api.github.com/repos/aodn/core-geonetwork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aodn/core-geonetwork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aodn/core-geonetwork/teams","hooks_url":"https://api.github.com/repos/aodn/core-geonetwork/hooks","issue_events_url":"https://api.github.com/repos/aodn/core-geonetwork/issues/events{/number}","events_url":"https://api.github.com/repos/aodn/core-geonetwork/events","assignees_url":"https://api.github.com/repos/aodn/core-geonetwork/assignees{/user}","branches_url":"https://api.github.com/repos/aodn/core-geonetwork/branches{/branch}","tags_url":"https://api.github.com/repos/aodn/core-geonetwork/tags","blobs_url":"https://api.github.com/repos/aodn/core-geonetwork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aodn/core-geonetwork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aodn/core-geonetwork/git/refs{/sha}","trees_url":"https://api.github.com/repos/aodn/core-geonetwork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aodn/core-geonetwork/statuses/{sha}","languages_url":"https://api.github.com/repos/aodn/core-geonetwork/languages","stargazers_url":"https://api.github.com/repos/aodn/core-geonetwork/stargazers","contributors_url":"https://api.github.com/repos/aodn/core-geonetwork/contributors","subscribers_url":"https://api.github.com/repos/aodn/core-geonetwork/subscribers","subscription_url":"https://api.github.com/repos/aodn/core-geonetwork/subscription","commits_url":"https://api.github.com/repos/aodn/core-geonetwork/commits{/sha}","git_commits_url":"https://api.github.com/repos/aodn/core-geonetwork/git/commits{/sha}","comments_url":"https://api.github.com/repos/aodn/core-geonetwork/comments{/number}","issue_comment_url":"https://api.github.com/repos/aodn/core-geonetwork/issues/comments{/number}","contents_url":"https://api.github.com/repos/aodn/core-geonetwork/contents/{+path}","compare_url":"https://api.github.com/repos/aodn/core-geonetwork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aodn/core-geonetwork/merges","archive_url":"https://api.github.com/repos/aodn/core-geonetwork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aodn/core-geonetwork/downloads","issues_url":"https://api.github.com/repos/aodn/core-geonetwork/issues{/number}","pulls_url":"https://api.github.com/repos/aodn/core-geonetwork/pulls{/number}","milestones_url":"https://api.github.com/repos/aodn/core-geonetwork/milestones{/number}","notifications_url":"https://api.github.com/repos/aodn/core-geonetwork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aodn/core-geonetwork/labels{/name}","releases_url":"https://api.github.com/repos/aodn/core-geonetwork/releases{/id}","created_at":"2014-07-18T04:26:22Z","updated_at":"2015-04-01T04:58:58Z","pushed_at":"2015-09-21T23:03:02Z","git_url":"git://github.com/aodn/core-geonetwork.git","ssh_url":"git@github.com:aodn/core-geonetwork.git","clone_url":"https://github.com/aodn/core-geonetwork.git","svn_url":"https://github.com/aodn/core-geonetwork","homepage":"http://geonetwork-opensource.org/","size":246770,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":0,"default_branch":"2.10.x-imos"}},"_links":{"self":{"href":"https://api.github.com/repos/aodn/core-geonetwork/pulls/41"},"html":{"href":"https://github.com/aodn/core-geonetwork/pull/41"},"issue":{"href":"https://api.github.com/repos/aodn/core-geonetwork/issues/41"},"comments":{"href":"https://api.github.com/repos/aodn/core-geonetwork/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/aodn/core-geonetwork/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/aodn/core-geonetwork/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aodn/core-geonetwork/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/aodn/core-geonetwork/statuses/c9a071281995071a828e47bdeb484a0c92bf65af"}}}}