{"push_id":623348068,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"fb2c1fa7580c08edb9830e2e7c6c3bd160231fe0","before":"93cc41001c6387087ada6946ebb3635d726da918","commits":[{"sha":"945ab28df04e22f3c1b8948972f538ee6b5e7410","author":{"email":"bb938cf255e055ff3507f2627d214e8e62118fcf@redhat.com","name":"Daniel P. Berrange"},"message":"libvirt: fix disablement of NUMA & hugepages on unsupported platforms\n\nTwo previous commits updated the libvirt XML config generator so\nthat it would omit the config elements for huge pages and NUMA\nplacement when running on old libvirt:\n\n  commit cf3a1262ecf12f4345326309c273722ebc26b466\n  Author: Vladik Romanovsky <vladik.romanovsky@enovance.com>\n  Date:   Wed Jan 28 00:54:26 2015 -0500\n\n    libvirt: avoid setting the memnodes where when it's not a supported option\n\n  commit 3466e727546e0f7595378b8274254bed913f42ee\n  Author: Vladik Romanovsky <vladik.romanovsky@enovance.com>\n  Date:   Tue Jan 6 14:23:38 2015 -0500\n\n    libvirt: not setting membacking when mempages are empty host topology\n\nThe problem arising from this is that the hosts are still reporting\nto the schedular that they can support NUMA and huge pages if\nlibvirt >= 1.0.4, but we are silently discarding the guest config\nif libvirt < 1.2.7 (numa) or 1.2.8 (huge pages).\n\nThe result is that the schedular thinks the host can support the\nrequested feature and so places the guest there, but the actual\nguest that is launched is missing the feature. So the user is not\ngetting what they requested.\n\nThe correct approach is to update the \"_get_host_numa_topology\"\nmethod so that it does not report any NUMA topology in the first\nplace, if the host is incapable of having guests configured in\nthe way Nova requires. Likewise if the host cannot support the\nhuge page configuration method required, it should not report\navailability of huge pages.\n\nIn summary, we are moving the version checks added by the two\ncommits above to the point at which host capability reporting\nis done. We add a fatal error check in the guest XML config\ngenerator methods, so that if there is some future schedular\nbug causing it to not honour host capabilities, we see a\nclear error instead of silently starting guests with the\nwrong config.\n\nThere is a further mistake in that a version number check alone\nis insufficient. We must also check that the hypervisor is\neither QEMU or KVM, to prevent the code paths running on Xen\nor LXC.\n\nCloses-bug: #1425115\nRelated-bug: #1408070\nRelated-bug: #1415333\n\nChange-Id: I8326596696cbb030ae95d17f3dd430d05279081a","distinct":true,"url":"https://api.github.com/repos/mandeepdhami/nova/commits/945ab28df04e22f3c1b8948972f538ee6b5e7410"},{"sha":"fb2c1fa7580c08edb9830e2e7c6c3bd160231fe0","author":{"email":"d95b56ce41a2e1ac4cecdd398defd7414407cc08@review.openstack.org","name":"Jenkins"},"message":"Merge \"libvirt: fix disablement of NUMA & hugepages on unsupported platforms\"","distinct":true,"url":"https://api.github.com/repos/mandeepdhami/nova/commits/fb2c1fa7580c08edb9830e2e7c6c3bd160231fe0"}]}