{"action":"opened","number":672,"pull_request":{"url":"https://api.github.com/repos/lenskit/lenskit/pulls/672","id":29326047,"html_url":"https://github.com/lenskit/lenskit/pull/672","diff_url":"https://github.com/lenskit/lenskit/pull/672.diff","patch_url":"https://github.com/lenskit/lenskit/pull/672.patch","issue_url":"https://api.github.com/repos/lenskit/lenskit/issues/672","number":672,"state":"open","locked":false,"title":"Add tests with subsetted item DAOs","user":{"login":"elehack","id":186612,"avatar_url":"https://avatars.githubusercontent.com/u/186612?v=3","gravatar_id":"","url":"https://api.github.com/users/elehack","html_url":"https://github.com/elehack","followers_url":"https://api.github.com/users/elehack/followers","following_url":"https://api.github.com/users/elehack/following{/other_user}","gists_url":"https://api.github.com/users/elehack/gists{/gist_id}","starred_url":"https://api.github.com/users/elehack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elehack/subscriptions","organizations_url":"https://api.github.com/users/elehack/orgs","repos_url":"https://api.github.com/users/elehack/repos","events_url":"https://api.github.com/users/elehack/events{/privacy}","received_events_url":"https://api.github.com/users/elehack/received_events","type":"User","site_admin":false},"body":"This adds integration tests with subsetted item DAOs, doing the testing for #671. Right now, it just tests that nothing fails w/ an exception (e.g. invalid key or index out of bounds) if we build a recommender with a subset of the items in its `ItemDAO`.\r\n\r\nI'm somewhat surprised that these tests didn't shake out any fresh errors.","created_at":"2015-02-14T21:50:06Z","updated_at":"2015-02-14T21:50:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8477722e1d2e145bf98f6bd06aeee90f18e2fddb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lenskit/lenskit/pulls/672/commits","review_comments_url":"https://api.github.com/repos/lenskit/lenskit/pulls/672/comments","review_comment_url":"https://api.github.com/repos/lenskit/lenskit/pulls/comments/{number}","comments_url":"https://api.github.com/repos/lenskit/lenskit/issues/672/comments","statuses_url":"https://api.github.com/repos/lenskit/lenskit/statuses/b6f3d86624ac3ac8c1ceff89d6de7cc0166e379d","head":{"label":"elehack:feature/671-missing-items","ref":"feature/671-missing-items","sha":"b6f3d86624ac3ac8c1ceff89d6de7cc0166e379d","user":{"login":"elehack","id":186612,"avatar_url":"https://avatars.githubusercontent.com/u/186612?v=3","gravatar_id":"","url":"https://api.github.com/users/elehack","html_url":"https://github.com/elehack","followers_url":"https://api.github.com/users/elehack/followers","following_url":"https://api.github.com/users/elehack/following{/other_user}","gists_url":"https://api.github.com/users/elehack/gists{/gist_id}","starred_url":"https://api.github.com/users/elehack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elehack/subscriptions","organizations_url":"https://api.github.com/users/elehack/orgs","repos_url":"https://api.github.com/users/elehack/repos","events_url":"https://api.github.com/users/elehack/events{/privacy}","received_events_url":"https://api.github.com/users/elehack/received_events","type":"User","site_admin":false},"repo":{"id":12954960,"name":"lenskit","full_name":"elehack/lenskit","owner":{"login":"elehack","id":186612,"avatar_url":"https://avatars.githubusercontent.com/u/186612?v=3","gravatar_id":"","url":"https://api.github.com/users/elehack","html_url":"https://github.com/elehack","followers_url":"https://api.github.com/users/elehack/followers","following_url":"https://api.github.com/users/elehack/following{/other_user}","gists_url":"https://api.github.com/users/elehack/gists{/gist_id}","starred_url":"https://api.github.com/users/elehack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elehack/subscriptions","organizations_url":"https://api.github.com/users/elehack/orgs","repos_url":"https://api.github.com/users/elehack/repos","events_url":"https://api.github.com/users/elehack/events{/privacy}","received_events_url":"https://api.github.com/users/elehack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elehack/lenskit","description":"LensKit recommender toolkit (Michael's work-in-progress fork, feature branches may be rebased).","fork":true,"url":"https://api.github.com/repos/elehack/lenskit","forks_url":"https://api.github.com/repos/elehack/lenskit/forks","keys_url":"https://api.github.com/repos/elehack/lenskit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elehack/lenskit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elehack/lenskit/teams","hooks_url":"https://api.github.com/repos/elehack/lenskit/hooks","issue_events_url":"https://api.github.com/repos/elehack/lenskit/issues/events{/number}","events_url":"https://api.github.com/repos/elehack/lenskit/events","assignees_url":"https://api.github.com/repos/elehack/lenskit/assignees{/user}","branches_url":"https://api.github.com/repos/elehack/lenskit/branches{/branch}","tags_url":"https://api.github.com/repos/elehack/lenskit/tags","blobs_url":"https://api.github.com/repos/elehack/lenskit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elehack/lenskit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elehack/lenskit/git/refs{/sha}","trees_url":"https://api.github.com/repos/elehack/lenskit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elehack/lenskit/statuses/{sha}","languages_url":"https://api.github.com/repos/elehack/lenskit/languages","stargazers_url":"https://api.github.com/repos/elehack/lenskit/stargazers","contributors_url":"https://api.github.com/repos/elehack/lenskit/contributors","subscribers_url":"https://api.github.com/repos/elehack/lenskit/subscribers","subscription_url":"https://api.github.com/repos/elehack/lenskit/subscription","commits_url":"https://api.github.com/repos/elehack/lenskit/commits{/sha}","git_commits_url":"https://api.github.com/repos/elehack/lenskit/git/commits{/sha}","comments_url":"https://api.github.com/repos/elehack/lenskit/comments{/number}","issue_comment_url":"https://api.github.com/repos/elehack/lenskit/issues/comments/{number}","contents_url":"https://api.github.com/repos/elehack/lenskit/contents/{+path}","compare_url":"https://api.github.com/repos/elehack/lenskit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elehack/lenskit/merges","archive_url":"https://api.github.com/repos/elehack/lenskit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elehack/lenskit/downloads","issues_url":"https://api.github.com/repos/elehack/lenskit/issues{/number}","pulls_url":"https://api.github.com/repos/elehack/lenskit/pulls{/number}","milestones_url":"https://api.github.com/repos/elehack/lenskit/milestones{/number}","notifications_url":"https://api.github.com/repos/elehack/lenskit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elehack/lenskit/labels{/name}","releases_url":"https://api.github.com/repos/elehack/lenskit/releases{/id}","created_at":"2013-09-19T17:41:33Z","updated_at":"2015-02-13T23:27:04Z","pushed_at":"2015-02-14T21:48:45Z","git_url":"git://github.com/elehack/lenskit.git","ssh_url":"git@github.com:elehack/lenskit.git","clone_url":"https://github.com/elehack/lenskit.git","svn_url":"https://github.com/elehack/lenskit","homepage":"","size":20251,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lenskit:master","ref":"master","sha":"612a6e57d024c19138f40a1a4498b2fe3af9aee7","user":{"login":"lenskit","id":7562892,"avatar_url":"https://avatars.githubusercontent.com/u/7562892?v=3","gravatar_id":"","url":"https://api.github.com/users/lenskit","html_url":"https://github.com/lenskit","followers_url":"https://api.github.com/users/lenskit/followers","following_url":"https://api.github.com/users/lenskit/following{/other_user}","gists_url":"https://api.github.com/users/lenskit/gists{/gist_id}","starred_url":"https://api.github.com/users/lenskit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lenskit/subscriptions","organizations_url":"https://api.github.com/users/lenskit/orgs","repos_url":"https://api.github.com/users/lenskit/repos","events_url":"https://api.github.com/users/lenskit/events{/privacy}","received_events_url":"https://api.github.com/users/lenskit/received_events","type":"Organization","site_admin":false},"repo":{"id":12953256,"name":"lenskit","full_name":"lenskit/lenskit","owner":{"login":"lenskit","id":7562892,"avatar_url":"https://avatars.githubusercontent.com/u/7562892?v=3","gravatar_id":"","url":"https://api.github.com/users/lenskit","html_url":"https://github.com/lenskit","followers_url":"https://api.github.com/users/lenskit/followers","following_url":"https://api.github.com/users/lenskit/following{/other_user}","gists_url":"https://api.github.com/users/lenskit/gists{/gist_id}","starred_url":"https://api.github.com/users/lenskit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lenskit/subscriptions","organizations_url":"https://api.github.com/users/lenskit/orgs","repos_url":"https://api.github.com/users/lenskit/repos","events_url":"https://api.github.com/users/lenskit/events{/privacy}","received_events_url":"https://api.github.com/users/lenskit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lenskit/lenskit","description":"LensKit recommender toolkit.","fork":false,"url":"https://api.github.com/repos/lenskit/lenskit","forks_url":"https://api.github.com/repos/lenskit/lenskit/forks","keys_url":"https://api.github.com/repos/lenskit/lenskit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lenskit/lenskit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lenskit/lenskit/teams","hooks_url":"https://api.github.com/repos/lenskit/lenskit/hooks","issue_events_url":"https://api.github.com/repos/lenskit/lenskit/issues/events{/number}","events_url":"https://api.github.com/repos/lenskit/lenskit/events","assignees_url":"https://api.github.com/repos/lenskit/lenskit/assignees{/user}","branches_url":"https://api.github.com/repos/lenskit/lenskit/branches{/branch}","tags_url":"https://api.github.com/repos/lenskit/lenskit/tags","blobs_url":"https://api.github.com/repos/lenskit/lenskit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lenskit/lenskit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lenskit/lenskit/git/refs{/sha}","trees_url":"https://api.github.com/repos/lenskit/lenskit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lenskit/lenskit/statuses/{sha}","languages_url":"https://api.github.com/repos/lenskit/lenskit/languages","stargazers_url":"https://api.github.com/repos/lenskit/lenskit/stargazers","contributors_url":"https://api.github.com/repos/lenskit/lenskit/contributors","subscribers_url":"https://api.github.com/repos/lenskit/lenskit/subscribers","subscription_url":"https://api.github.com/repos/lenskit/lenskit/subscription","commits_url":"https://api.github.com/repos/lenskit/lenskit/commits{/sha}","git_commits_url":"https://api.github.com/repos/lenskit/lenskit/git/commits{/sha}","comments_url":"https://api.github.com/repos/lenskit/lenskit/comments{/number}","issue_comment_url":"https://api.github.com/repos/lenskit/lenskit/issues/comments/{number}","contents_url":"https://api.github.com/repos/lenskit/lenskit/contents/{+path}","compare_url":"https://api.github.com/repos/lenskit/lenskit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lenskit/lenskit/merges","archive_url":"https://api.github.com/repos/lenskit/lenskit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lenskit/lenskit/downloads","issues_url":"https://api.github.com/repos/lenskit/lenskit/issues{/number}","pulls_url":"https://api.github.com/repos/lenskit/lenskit/pulls{/number}","milestones_url":"https://api.github.com/repos/lenskit/lenskit/milestones{/number}","notifications_url":"https://api.github.com/repos/lenskit/lenskit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lenskit/lenskit/labels{/name}","releases_url":"https://api.github.com/repos/lenskit/lenskit/releases{/id}","created_at":"2013-09-19T16:19:33Z","updated_at":"2015-02-14T21:38:45Z","pushed_at":"2015-02-14T21:38:44Z","git_url":"git://github.com/lenskit/lenskit.git","ssh_url":"git@github.com:lenskit/lenskit.git","clone_url":"https://github.com/lenskit/lenskit.git","svn_url":"https://github.com/lenskit/lenskit","homepage":"http://lenskit.grouplens.org","size":24151,"stargazers_count":254,"watchers_count":254,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":121,"mirror_url":null,"open_issues_count":121,"forks":121,"open_issues":121,"watchers":254,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lenskit/lenskit/pulls/672"},"html":{"href":"https://github.com/lenskit/lenskit/pull/672"},"issue":{"href":"https://api.github.com/repos/lenskit/lenskit/issues/672"},"comments":{"href":"https://api.github.com/repos/lenskit/lenskit/issues/672/comments"},"review_comments":{"href":"https://api.github.com/repos/lenskit/lenskit/pulls/672/comments"},"review_comment":{"href":"https://api.github.com/repos/lenskit/lenskit/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/lenskit/lenskit/pulls/672/commits"},"statuses":{"href":"https://api.github.com/repos/lenskit/lenskit/statuses/b6f3d86624ac3ac8c1ceff89d6de7cc0166e379d"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":6,"additions":105,"deletions":20,"changed_files":5}}