{"action":"created","issue":{"url":"https://api.github.com/repos/rancher/cattle/issues/942","labels_url":"https://api.github.com/repos/rancher/cattle/issues/942/labels{/name}","comments_url":"https://api.github.com/repos/rancher/cattle/issues/942/comments","events_url":"https://api.github.com/repos/rancher/cattle/issues/942/events","html_url":"https://github.com/rancher/cattle/pull/942","id":110922663,"number":942,"title":"ldap: check \"name\" field before using \"dn\" for display name.","user":{"login":"kaos","id":72965,"avatar_url":"https://avatars.githubusercontent.com/u/72965?v=3","gravatar_id":"","url":"https://api.github.com/users/kaos","html_url":"https://github.com/kaos","followers_url":"https://api.github.com/users/kaos/followers","following_url":"https://api.github.com/users/kaos/following{/other_user}","gists_url":"https://api.github.com/users/kaos/gists{/gist_id}","starred_url":"https://api.github.com/users/kaos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaos/subscriptions","organizations_url":"https://api.github.com/users/kaos/orgs","repos_url":"https://api.github.com/users/kaos/repos","events_url":"https://api.github.com/users/kaos/events{/privacy}","received_events_url":"https://api.github.com/users/kaos/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-12T07:43:12Z","updated_at":"2015-10-12T16:14:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rancher/cattle/pulls/942","html_url":"https://github.com/rancher/cattle/pull/942","diff_url":"https://github.com/rancher/cattle/pull/942.diff","patch_url":"https://github.com/rancher/cattle/pull/942.patch"},"body":"In case the requested name field is missing, look first at the `name` field, before resolving to using the `dn` field, which is very verbose..\r\n\r\nThis is an untested implementation for my comment in #936 \r\n"},"comment":{"url":"https://api.github.com/repos/rancher/cattle/issues/comments/147449289","html_url":"https://github.com/rancher/cattle/pull/942#issuecomment-147449289","issue_url":"https://api.github.com/repos/rancher/cattle/issues/942","id":147449289,"user":{"login":"cjellick","id":2473240,"avatar_url":"https://avatars.githubusercontent.com/u/2473240?v=3","gravatar_id":"","url":"https://api.github.com/users/cjellick","html_url":"https://github.com/cjellick","followers_url":"https://api.github.com/users/cjellick/followers","following_url":"https://api.github.com/users/cjellick/following{/other_user}","gists_url":"https://api.github.com/users/cjellick/gists{/gist_id}","starred_url":"https://api.github.com/users/cjellick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjellick/subscriptions","organizations_url":"https://api.github.com/users/cjellick/orgs","repos_url":"https://api.github.com/users/cjellick/repos","events_url":"https://api.github.com/users/cjellick/events{/privacy}","received_events_url":"https://api.github.com/users/cjellick/received_events","type":"User","site_admin":false},"created_at":"2015-10-12T16:14:32Z","updated_at":"2015-10-12T16:14:32Z","body":"This seems like a reasonable change. \r\n\r\nMy initial reaction was that providing two fallbacks (first to the default name field) and then to DN would be overkill, but this change doesn't make the code more complex, so I can't really say it overcomplicates things.\r\n\r\n@hibooboo2 are there any unintended consequences of falling back to a default \"name\" field before using the DN? Would it affect search in an odd way?\r\n\r\n@hibooboo2 if this change makes sense, can you pull it down and test it against our AD server?"}}