{"action":"created","comment":{"url":"https://api.github.com/repos/dropbox/pyston/pulls/comments/24230610","id":24230610,"diff_hunk":"@@ -1729,7 +1729,9 @@ extern \"C\" int PyType_Ready(PyTypeObject* cls) noexcept {\n \n     RELEASE_ASSERT(cls->tp_getattro == NULL || cls->tp_getattro == PyObject_GenericGetAttr, \"\");\n     RELEASE_ASSERT(cls->tp_setattro == NULL || cls->tp_setattro == PyObject_GenericSetAttr, \"\");\n-    RELEASE_ASSERT(cls->tp_as_buffer == NULL, \"\");\n+\n+    // TODO: I think this is not implemented yet but the arraymodules uses it.\n+    // RELEASE_ASSERT(cls->tp_as_buffer == NULL, \"\");","path":"src/capi/typeobject.cpp","position":7,"original_position":7,"commit_id":"bd658c1d43768f82f6d928ff267797a72d8773e5","original_commit_id":"bd658c1d43768f82f6d928ff267797a72d8773e5","user":{"login":"undingen","id":7397630,"avatar_url":"https://avatars.githubusercontent.com/u/7397630?v=3","gravatar_id":"","url":"https://api.github.com/users/undingen","html_url":"https://github.com/undingen","followers_url":"https://api.github.com/users/undingen/followers","following_url":"https://api.github.com/users/undingen/following{/other_user}","gists_url":"https://api.github.com/users/undingen/gists{/gist_id}","starred_url":"https://api.github.com/users/undingen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/undingen/subscriptions","organizations_url":"https://api.github.com/users/undingen/orgs","repos_url":"https://api.github.com/users/undingen/repos","events_url":"https://api.github.com/users/undingen/events{/privacy}","received_events_url":"https://api.github.com/users/undingen/received_events","type":"User","site_admin":false},"body":"ok I will remove the check","created_at":"2015-02-06T09:42:03Z","updated_at":"2015-02-06T09:42:03Z","html_url":"https://github.com/dropbox/pyston/pull/281#discussion_r24230610","pull_request_url":"https://api.github.com/repos/dropbox/pyston/pulls/281","_links":{"self":{"href":"https://api.github.com/repos/dropbox/pyston/pulls/comments/24230610"},"html":{"href":"https://github.com/dropbox/pyston/pull/281#discussion_r24230610"},"pull_request":{"href":"https://api.github.com/repos/dropbox/pyston/pulls/281"}}},"pull_request":{"url":"https://api.github.com/repos/dropbox/pyston/pulls/281","id":28752704,"html_url":"https://github.com/dropbox/pyston/pull/281","diff_url":"https://github.com/dropbox/pyston/pull/281.diff","patch_url":"https://github.com/dropbox/pyston/pull/281.patch","issue_url":"https://api.github.com/repos/dropbox/pyston/issues/281","number":281,"state":"open","locked":false,"title":"add the array module","user":{"login":"undingen","id":7397630,"avatar_url":"https://avatars.githubusercontent.com/u/7397630?v=3","gravatar_id":"","url":"https://api.github.com/users/undingen","html_url":"https://github.com/undingen","followers_url":"https://api.github.com/users/undingen/followers","following_url":"https://api.github.com/users/undingen/following{/other_user}","gists_url":"https://api.github.com/users/undingen/gists{/gist_id}","starred_url":"https://api.github.com/users/undingen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/undingen/subscriptions","organizations_url":"https://api.github.com/users/undingen/orgs","repos_url":"https://api.github.com/users/undingen/repos","events_url":"https://api.github.com/users/undingen/events{/privacy}","received_events_url":"https://api.github.com/users/undingen/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-02-05T19:19:48Z","updated_at":"2015-02-06T09:42:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"489eadd6a4228becf4907a6ca0cd1cfc082fde83","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dropbox/pyston/pulls/281/commits","review_comments_url":"https://api.github.com/repos/dropbox/pyston/pulls/281/comments","review_comment_url":"https://api.github.com/repos/dropbox/pyston/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dropbox/pyston/issues/281/comments","statuses_url":"https://api.github.com/repos/dropbox/pyston/statuses/bd658c1d43768f82f6d928ff267797a72d8773e5","head":{"label":"undingen:array","ref":"array","sha":"bd658c1d43768f82f6d928ff267797a72d8773e5","user":{"login":"undingen","id":7397630,"avatar_url":"https://avatars.githubusercontent.com/u/7397630?v=3","gravatar_id":"","url":"https://api.github.com/users/undingen","html_url":"https://github.com/undingen","followers_url":"https://api.github.com/users/undingen/followers","following_url":"https://api.github.com/users/undingen/following{/other_user}","gists_url":"https://api.github.com/users/undingen/gists{/gist_id}","starred_url":"https://api.github.com/users/undingen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/undingen/subscriptions","organizations_url":"https://api.github.com/users/undingen/orgs","repos_url":"https://api.github.com/users/undingen/repos","events_url":"https://api.github.com/users/undingen/events{/privacy}","received_events_url":"https://api.github.com/users/undingen/received_events","type":"User","site_admin":false},"repo":{"id":19117126,"name":"pyston","full_name":"undingen/pyston","owner":{"login":"undingen","id":7397630,"avatar_url":"https://avatars.githubusercontent.com/u/7397630?v=3","gravatar_id":"","url":"https://api.github.com/users/undingen","html_url":"https://github.com/undingen","followers_url":"https://api.github.com/users/undingen/followers","following_url":"https://api.github.com/users/undingen/following{/other_user}","gists_url":"https://api.github.com/users/undingen/gists{/gist_id}","starred_url":"https://api.github.com/users/undingen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/undingen/subscriptions","organizations_url":"https://api.github.com/users/undingen/orgs","repos_url":"https://api.github.com/users/undingen/repos","events_url":"https://api.github.com/users/undingen/events{/privacy}","received_events_url":"https://api.github.com/users/undingen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/undingen/pyston","description":"An open-source Python implementation using JIT techniques. ","fork":true,"url":"https://api.github.com/repos/undingen/pyston","forks_url":"https://api.github.com/repos/undingen/pyston/forks","keys_url":"https://api.github.com/repos/undingen/pyston/keys{/key_id}","collaborators_url":"https://api.github.com/repos/undingen/pyston/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/undingen/pyston/teams","hooks_url":"https://api.github.com/repos/undingen/pyston/hooks","issue_events_url":"https://api.github.com/repos/undingen/pyston/issues/events{/number}","events_url":"https://api.github.com/repos/undingen/pyston/events","assignees_url":"https://api.github.com/repos/undingen/pyston/assignees{/user}","branches_url":"https://api.github.com/repos/undingen/pyston/branches{/branch}","tags_url":"https://api.github.com/repos/undingen/pyston/tags","blobs_url":"https://api.github.com/repos/undingen/pyston/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/undingen/pyston/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/undingen/pyston/git/refs{/sha}","trees_url":"https://api.github.com/repos/undingen/pyston/git/trees{/sha}","statuses_url":"https://api.github.com/repos/undingen/pyston/statuses/{sha}","languages_url":"https://api.github.com/repos/undingen/pyston/languages","stargazers_url":"https://api.github.com/repos/undingen/pyston/stargazers","contributors_url":"https://api.github.com/repos/undingen/pyston/contributors","subscribers_url":"https://api.github.com/repos/undingen/pyston/subscribers","subscription_url":"https://api.github.com/repos/undingen/pyston/subscription","commits_url":"https://api.github.com/repos/undingen/pyston/commits{/sha}","git_commits_url":"https://api.github.com/repos/undingen/pyston/git/commits{/sha}","comments_url":"https://api.github.com/repos/undingen/pyston/comments{/number}","issue_comment_url":"https://api.github.com/repos/undingen/pyston/issues/comments/{number}","contents_url":"https://api.github.com/repos/undingen/pyston/contents/{+path}","compare_url":"https://api.github.com/repos/undingen/pyston/compare/{base}...{head}","merges_url":"https://api.github.com/repos/undingen/pyston/merges","archive_url":"https://api.github.com/repos/undingen/pyston/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/undingen/pyston/downloads","issues_url":"https://api.github.com/repos/undingen/pyston/issues{/number}","pulls_url":"https://api.github.com/repos/undingen/pyston/pulls{/number}","milestones_url":"https://api.github.com/repos/undingen/pyston/milestones{/number}","notifications_url":"https://api.github.com/repos/undingen/pyston/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/undingen/pyston/labels{/name}","releases_url":"https://api.github.com/repos/undingen/pyston/releases{/id}","created_at":"2014-04-24T17:17:10Z","updated_at":"2015-01-27T22:17:13Z","pushed_at":"2015-02-05T22:26:12Z","git_url":"git://github.com/undingen/pyston.git","ssh_url":"git@github.com:undingen/pyston.git","clone_url":"https://github.com/undingen/pyston.git","svn_url":"https://github.com/undingen/pyston","homepage":"https://tech.dropbox.com/2014/04/introducing-pyston-an-upcoming-jit-based-python-implementation/","size":13252,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dropbox:master","ref":"master","sha":"2df055711e05bc2cf4eafcee7f38bd4759054fc3","user":{"login":"dropbox","id":559357,"avatar_url":"https://avatars.githubusercontent.com/u/559357?v=3","gravatar_id":"","url":"https://api.github.com/users/dropbox","html_url":"https://github.com/dropbox","followers_url":"https://api.github.com/users/dropbox/followers","following_url":"https://api.github.com/users/dropbox/following{/other_user}","gists_url":"https://api.github.com/users/dropbox/gists{/gist_id}","starred_url":"https://api.github.com/users/dropbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dropbox/subscriptions","organizations_url":"https://api.github.com/users/dropbox/orgs","repos_url":"https://api.github.com/users/dropbox/repos","events_url":"https://api.github.com/users/dropbox/events{/privacy}","received_events_url":"https://api.github.com/users/dropbox/received_events","type":"Organization","site_admin":false},"repo":{"id":18320947,"name":"pyston","full_name":"dropbox/pyston","owner":{"login":"dropbox","id":559357,"avatar_url":"https://avatars.githubusercontent.com/u/559357?v=3","gravatar_id":"","url":"https://api.github.com/users/dropbox","html_url":"https://github.com/dropbox","followers_url":"https://api.github.com/users/dropbox/followers","following_url":"https://api.github.com/users/dropbox/following{/other_user}","gists_url":"https://api.github.com/users/dropbox/gists{/gist_id}","starred_url":"https://api.github.com/users/dropbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dropbox/subscriptions","organizations_url":"https://api.github.com/users/dropbox/orgs","repos_url":"https://api.github.com/users/dropbox/repos","events_url":"https://api.github.com/users/dropbox/events{/privacy}","received_events_url":"https://api.github.com/users/dropbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dropbox/pyston","description":"An open-source Python implementation using JIT techniques. ","fork":false,"url":"https://api.github.com/repos/dropbox/pyston","forks_url":"https://api.github.com/repos/dropbox/pyston/forks","keys_url":"https://api.github.com/repos/dropbox/pyston/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dropbox/pyston/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dropbox/pyston/teams","hooks_url":"https://api.github.com/repos/dropbox/pyston/hooks","issue_events_url":"https://api.github.com/repos/dropbox/pyston/issues/events{/number}","events_url":"https://api.github.com/repos/dropbox/pyston/events","assignees_url":"https://api.github.com/repos/dropbox/pyston/assignees{/user}","branches_url":"https://api.github.com/repos/dropbox/pyston/branches{/branch}","tags_url":"https://api.github.com/repos/dropbox/pyston/tags","blobs_url":"https://api.github.com/repos/dropbox/pyston/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dropbox/pyston/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dropbox/pyston/git/refs{/sha}","trees_url":"https://api.github.com/repos/dropbox/pyston/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dropbox/pyston/statuses/{sha}","languages_url":"https://api.github.com/repos/dropbox/pyston/languages","stargazers_url":"https://api.github.com/repos/dropbox/pyston/stargazers","contributors_url":"https://api.github.com/repos/dropbox/pyston/contributors","subscribers_url":"https://api.github.com/repos/dropbox/pyston/subscribers","subscription_url":"https://api.github.com/repos/dropbox/pyston/subscription","commits_url":"https://api.github.com/repos/dropbox/pyston/commits{/sha}","git_commits_url":"https://api.github.com/repos/dropbox/pyston/git/commits{/sha}","comments_url":"https://api.github.com/repos/dropbox/pyston/comments{/number}","issue_comment_url":"https://api.github.com/repos/dropbox/pyston/issues/comments/{number}","contents_url":"https://api.github.com/repos/dropbox/pyston/contents/{+path}","compare_url":"https://api.github.com/repos/dropbox/pyston/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dropbox/pyston/merges","archive_url":"https://api.github.com/repos/dropbox/pyston/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dropbox/pyston/downloads","issues_url":"https://api.github.com/repos/dropbox/pyston/issues{/number}","pulls_url":"https://api.github.com/repos/dropbox/pyston/pulls{/number}","milestones_url":"https://api.github.com/repos/dropbox/pyston/milestones{/number}","notifications_url":"https://api.github.com/repos/dropbox/pyston/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dropbox/pyston/labels{/name}","releases_url":"https://api.github.com/repos/dropbox/pyston/releases{/id}","created_at":"2014-04-01T07:17:20Z","updated_at":"2015-02-06T07:45:21Z","pushed_at":"2015-02-06T02:30:00Z","git_url":"git://github.com/dropbox/pyston.git","ssh_url":"git@github.com:dropbox/pyston.git","clone_url":"https://github.com/dropbox/pyston.git","svn_url":"https://github.com/dropbox/pyston","homepage":"https://tech.dropbox.com/2014/04/introducing-pyston-an-upcoming-jit-based-python-implementation/","size":17204,"stargazers_count":2660,"watchers_count":2660,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":194,"mirror_url":null,"open_issues_count":61,"forks":194,"open_issues":61,"watchers":2660,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dropbox/pyston/pulls/281"},"html":{"href":"https://github.com/dropbox/pyston/pull/281"},"issue":{"href":"https://api.github.com/repos/dropbox/pyston/issues/281"},"comments":{"href":"https://api.github.com/repos/dropbox/pyston/issues/281/comments"},"review_comments":{"href":"https://api.github.com/repos/dropbox/pyston/pulls/281/comments"},"review_comment":{"href":"https://api.github.com/repos/dropbox/pyston/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dropbox/pyston/pulls/281/commits"},"statuses":{"href":"https://api.github.com/repos/dropbox/pyston/statuses/bd658c1d43768f82f6d928ff267797a72d8773e5"}}}}