{"action":"created","comment":{"url":"https://api.github.com/repos/wg-perception/tod/pulls/comments/28652490","id":28652490,"diff_hunk":"@@ -1,5 +1,12 @@\n #include <ecto/ecto.hpp>\n-#include <opencv2/core/core.hpp>\n+\n+\n+#if CV_VERSION_MAJOR < 3","path":"src/training/ModelFiller.cpp","position":5,"original_position":5,"commit_id":"bc8f73b53dc9a3289d65dfc31610cb0a3688ec8a","original_commit_id":"bc8f73b53dc9a3289d65dfc31610cb0a3688ec8a","user":{"login":"vrabaud","id":700766,"avatar_url":"https://avatars.githubusercontent.com/u/700766?v=3","gravatar_id":"","url":"https://api.github.com/users/vrabaud","html_url":"https://github.com/vrabaud","followers_url":"https://api.github.com/users/vrabaud/followers","following_url":"https://api.github.com/users/vrabaud/following{/other_user}","gists_url":"https://api.github.com/users/vrabaud/gists{/gist_id}","starred_url":"https://api.github.com/users/vrabaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrabaud/subscriptions","organizations_url":"https://api.github.com/users/vrabaud/orgs","repos_url":"https://api.github.com/users/vrabaud/repos","events_url":"https://api.github.com/users/vrabaud/events{/privacy}","received_events_url":"https://api.github.com/users/vrabaud/received_events","type":"User","site_admin":false},"body":"the proper way is to look at the existence of CV_VERSION_EPOCH or not (it's not in OpenCV3) and yes, that needs to be changed in all OpenCV ROS code (for now, I create a pre-processor variable OPENCV3)","created_at":"2015-04-19T12:41:11Z","updated_at":"2015-04-19T12:41:11Z","html_url":"https://github.com/wg-perception/tod/pull/12#discussion_r28652490","pull_request_url":"https://api.github.com/repos/wg-perception/tod/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/wg-perception/tod/pulls/comments/28652490"},"html":{"href":"https://github.com/wg-perception/tod/pull/12#discussion_r28652490"},"pull_request":{"href":"https://api.github.com/repos/wg-perception/tod/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/wg-perception/tod/pulls/12","id":33600475,"html_url":"https://github.com/wg-perception/tod/pull/12","diff_url":"https://github.com/wg-perception/tod/pull/12.diff","patch_url":"https://github.com/wg-perception/tod/pull/12.patch","issue_url":"https://api.github.com/repos/wg-perception/tod/issues/12","number":12,"state":"open","locked":false,"title":"adding pnp","user":{"login":"edgarriba","id":5157099,"avatar_url":"https://avatars.githubusercontent.com/u/5157099?v=3","gravatar_id":"","url":"https://api.github.com/users/edgarriba","html_url":"https://github.com/edgarriba","followers_url":"https://api.github.com/users/edgarriba/followers","following_url":"https://api.github.com/users/edgarriba/following{/other_user}","gists_url":"https://api.github.com/users/edgarriba/gists{/gist_id}","starred_url":"https://api.github.com/users/edgarriba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgarriba/subscriptions","organizations_url":"https://api.github.com/users/edgarriba/orgs","repos_url":"https://api.github.com/users/edgarriba/repos","events_url":"https://api.github.com/users/edgarriba/events{/privacy}","received_events_url":"https://api.github.com/users/edgarriba/received_events","type":"User","site_admin":false},"body":"the code is running and solving. Need to test the performance with good training","created_at":"2015-04-18T10:59:08Z","updated_at":"2015-04-19T12:41:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97defd74fd982e236a55902619afa2288e882e42","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wg-perception/tod/pulls/12/commits","review_comments_url":"https://api.github.com/repos/wg-perception/tod/pulls/12/comments","review_comment_url":"https://api.github.com/repos/wg-perception/tod/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wg-perception/tod/issues/12/comments","statuses_url":"https://api.github.com/repos/wg-perception/tod/statuses/bc8f73b53dc9a3289d65dfc31610cb0a3688ec8a","head":{"label":"edgarriba:master","ref":"master","sha":"bc8f73b53dc9a3289d65dfc31610cb0a3688ec8a","user":{"login":"edgarriba","id":5157099,"avatar_url":"https://avatars.githubusercontent.com/u/5157099?v=3","gravatar_id":"","url":"https://api.github.com/users/edgarriba","html_url":"https://github.com/edgarriba","followers_url":"https://api.github.com/users/edgarriba/followers","following_url":"https://api.github.com/users/edgarriba/following{/other_user}","gists_url":"https://api.github.com/users/edgarriba/gists{/gist_id}","starred_url":"https://api.github.com/users/edgarriba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgarriba/subscriptions","organizations_url":"https://api.github.com/users/edgarriba/orgs","repos_url":"https://api.github.com/users/edgarriba/repos","events_url":"https://api.github.com/users/edgarriba/events{/privacy}","received_events_url":"https://api.github.com/users/edgarriba/received_events","type":"User","site_admin":false},"repo":{"id":21562628,"name":"tod","full_name":"edgarriba/tod","owner":{"login":"edgarriba","id":5157099,"avatar_url":"https://avatars.githubusercontent.com/u/5157099?v=3","gravatar_id":"","url":"https://api.github.com/users/edgarriba","html_url":"https://github.com/edgarriba","followers_url":"https://api.github.com/users/edgarriba/followers","following_url":"https://api.github.com/users/edgarriba/following{/other_user}","gists_url":"https://api.github.com/users/edgarriba/gists{/gist_id}","starred_url":"https://api.github.com/users/edgarriba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgarriba/subscriptions","organizations_url":"https://api.github.com/users/edgarriba/orgs","repos_url":"https://api.github.com/users/edgarriba/repos","events_url":"https://api.github.com/users/edgarriba/events{/privacy}","received_events_url":"https://api.github.com/users/edgarriba/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edgarriba/tod","description":"Textured Object Detection","fork":true,"url":"https://api.github.com/repos/edgarriba/tod","forks_url":"https://api.github.com/repos/edgarriba/tod/forks","keys_url":"https://api.github.com/repos/edgarriba/tod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edgarriba/tod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edgarriba/tod/teams","hooks_url":"https://api.github.com/repos/edgarriba/tod/hooks","issue_events_url":"https://api.github.com/repos/edgarriba/tod/issues/events{/number}","events_url":"https://api.github.com/repos/edgarriba/tod/events","assignees_url":"https://api.github.com/repos/edgarriba/tod/assignees{/user}","branches_url":"https://api.github.com/repos/edgarriba/tod/branches{/branch}","tags_url":"https://api.github.com/repos/edgarriba/tod/tags","blobs_url":"https://api.github.com/repos/edgarriba/tod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edgarriba/tod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edgarriba/tod/git/refs{/sha}","trees_url":"https://api.github.com/repos/edgarriba/tod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edgarriba/tod/statuses/{sha}","languages_url":"https://api.github.com/repos/edgarriba/tod/languages","stargazers_url":"https://api.github.com/repos/edgarriba/tod/stargazers","contributors_url":"https://api.github.com/repos/edgarriba/tod/contributors","subscribers_url":"https://api.github.com/repos/edgarriba/tod/subscribers","subscription_url":"https://api.github.com/repos/edgarriba/tod/subscription","commits_url":"https://api.github.com/repos/edgarriba/tod/commits{/sha}","git_commits_url":"https://api.github.com/repos/edgarriba/tod/git/commits{/sha}","comments_url":"https://api.github.com/repos/edgarriba/tod/comments{/number}","issue_comment_url":"https://api.github.com/repos/edgarriba/tod/issues/comments{/number}","contents_url":"https://api.github.com/repos/edgarriba/tod/contents/{+path}","compare_url":"https://api.github.com/repos/edgarriba/tod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edgarriba/tod/merges","archive_url":"https://api.github.com/repos/edgarriba/tod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edgarriba/tod/downloads","issues_url":"https://api.github.com/repos/edgarriba/tod/issues{/number}","pulls_url":"https://api.github.com/repos/edgarriba/tod/pulls{/number}","milestones_url":"https://api.github.com/repos/edgarriba/tod/milestones{/number}","notifications_url":"https://api.github.com/repos/edgarriba/tod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edgarriba/tod/labels{/name}","releases_url":"https://api.github.com/repos/edgarriba/tod/releases{/id}","created_at":"2014-07-07T08:17:31Z","updated_at":"2015-04-19T12:12:25Z","pushed_at":"2015-04-19T12:12:25Z","git_url":"git://github.com/edgarriba/tod.git","ssh_url":"git@github.com:edgarriba/tod.git","clone_url":"https://github.com/edgarriba/tod.git","svn_url":"https://github.com/edgarriba/tod","homepage":"","size":613,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wg-perception:master","ref":"master","sha":"82583a92d54eb2e30471799258fb290e151206c3","user":{"login":"wg-perception","id":1022876,"avatar_url":"https://avatars.githubusercontent.com/u/1022876?v=3","gravatar_id":"","url":"https://api.github.com/users/wg-perception","html_url":"https://github.com/wg-perception","followers_url":"https://api.github.com/users/wg-perception/followers","following_url":"https://api.github.com/users/wg-perception/following{/other_user}","gists_url":"https://api.github.com/users/wg-perception/gists{/gist_id}","starred_url":"https://api.github.com/users/wg-perception/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wg-perception/subscriptions","organizations_url":"https://api.github.com/users/wg-perception/orgs","repos_url":"https://api.github.com/users/wg-perception/repos","events_url":"https://api.github.com/users/wg-perception/events{/privacy}","received_events_url":"https://api.github.com/users/wg-perception/received_events","type":"Organization","site_admin":false},"repo":{"id":3120320,"name":"tod","full_name":"wg-perception/tod","owner":{"login":"wg-perception","id":1022876,"avatar_url":"https://avatars.githubusercontent.com/u/1022876?v=3","gravatar_id":"","url":"https://api.github.com/users/wg-perception","html_url":"https://github.com/wg-perception","followers_url":"https://api.github.com/users/wg-perception/followers","following_url":"https://api.github.com/users/wg-perception/following{/other_user}","gists_url":"https://api.github.com/users/wg-perception/gists{/gist_id}","starred_url":"https://api.github.com/users/wg-perception/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wg-perception/subscriptions","organizations_url":"https://api.github.com/users/wg-perception/orgs","repos_url":"https://api.github.com/users/wg-perception/repos","events_url":"https://api.github.com/users/wg-perception/events{/privacy}","received_events_url":"https://api.github.com/users/wg-perception/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wg-perception/tod","description":"Textured Object Detection","fork":false,"url":"https://api.github.com/repos/wg-perception/tod","forks_url":"https://api.github.com/repos/wg-perception/tod/forks","keys_url":"https://api.github.com/repos/wg-perception/tod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wg-perception/tod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wg-perception/tod/teams","hooks_url":"https://api.github.com/repos/wg-perception/tod/hooks","issue_events_url":"https://api.github.com/repos/wg-perception/tod/issues/events{/number}","events_url":"https://api.github.com/repos/wg-perception/tod/events","assignees_url":"https://api.github.com/repos/wg-perception/tod/assignees{/user}","branches_url":"https://api.github.com/repos/wg-perception/tod/branches{/branch}","tags_url":"https://api.github.com/repos/wg-perception/tod/tags","blobs_url":"https://api.github.com/repos/wg-perception/tod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wg-perception/tod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wg-perception/tod/git/refs{/sha}","trees_url":"https://api.github.com/repos/wg-perception/tod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wg-perception/tod/statuses/{sha}","languages_url":"https://api.github.com/repos/wg-perception/tod/languages","stargazers_url":"https://api.github.com/repos/wg-perception/tod/stargazers","contributors_url":"https://api.github.com/repos/wg-perception/tod/contributors","subscribers_url":"https://api.github.com/repos/wg-perception/tod/subscribers","subscription_url":"https://api.github.com/repos/wg-perception/tod/subscription","commits_url":"https://api.github.com/repos/wg-perception/tod/commits{/sha}","git_commits_url":"https://api.github.com/repos/wg-perception/tod/git/commits{/sha}","comments_url":"https://api.github.com/repos/wg-perception/tod/comments{/number}","issue_comment_url":"https://api.github.com/repos/wg-perception/tod/issues/comments{/number}","contents_url":"https://api.github.com/repos/wg-perception/tod/contents/{+path}","compare_url":"https://api.github.com/repos/wg-perception/tod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wg-perception/tod/merges","archive_url":"https://api.github.com/repos/wg-perception/tod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wg-perception/tod/downloads","issues_url":"https://api.github.com/repos/wg-perception/tod/issues{/number}","pulls_url":"https://api.github.com/repos/wg-perception/tod/pulls{/number}","milestones_url":"https://api.github.com/repos/wg-perception/tod/milestones{/number}","notifications_url":"https://api.github.com/repos/wg-perception/tod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wg-perception/tod/labels{/name}","releases_url":"https://api.github.com/repos/wg-perception/tod/releases{/id}","created_at":"2012-01-06T19:22:06Z","updated_at":"2015-04-19T11:52:59Z","pushed_at":"2015-04-19T12:12:25Z","git_url":"git://github.com/wg-perception/tod.git","ssh_url":"git@github.com:wg-perception/tod.git","clone_url":"https://github.com/wg-perception/tod.git","svn_url":"https://github.com/wg-perception/tod","homepage":"","size":1011,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":3,"forks":9,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wg-perception/tod/pulls/12"},"html":{"href":"https://github.com/wg-perception/tod/pull/12"},"issue":{"href":"https://api.github.com/repos/wg-perception/tod/issues/12"},"comments":{"href":"https://api.github.com/repos/wg-perception/tod/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/wg-perception/tod/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/wg-perception/tod/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wg-perception/tod/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/wg-perception/tod/statuses/bc8f73b53dc9a3289d65dfc31610cb0a3688ec8a"}}}}