{"action":"created","comment":{"url":"https://api.github.com/repos/jtriley/StarCluster/pulls/comments/36440790","id":36440790,"diff_hunk":"@@ -163,7 +165,10 @@ def _write_config(self, master, user, profile_dir):\n         f.close()\n \n     def _start_cluster(self, master, profile_dir):\n-        n_engines = max(1, master.num_processors - 1)\n+        if not self.master_engines: ","path":"starcluster/plugins/ipcluster.py","position":32,"original_position":32,"commit_id":"b1ce26fb3c7b5ec5fdd0def869c05afb2b6fe34a","original_commit_id":"b1ce26fb3c7b5ec5fdd0def869c05afb2b6fe34a","user":{"login":"cancan101","id":51059,"avatar_url":"https://avatars.githubusercontent.com/u/51059?v=3","gravatar_id":"","url":"https://api.github.com/users/cancan101","html_url":"https://github.com/cancan101","followers_url":"https://api.github.com/users/cancan101/followers","following_url":"https://api.github.com/users/cancan101/following{/other_user}","gists_url":"https://api.github.com/users/cancan101/gists{/gist_id}","starred_url":"https://api.github.com/users/cancan101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cancan101/subscriptions","organizations_url":"https://api.github.com/users/cancan101/orgs","repos_url":"https://api.github.com/users/cancan101/repos","events_url":"https://api.github.com/users/cancan101/events{/privacy}","received_events_url":"https://api.github.com/users/cancan101/received_events","type":"User","site_admin":false},"body":"if `self.master_engines == 0` won't this branch be taken? i.e. using 0 or None to turn of the master will not work.","created_at":"2015-08-06T17:21:19Z","updated_at":"2015-08-06T17:21:19Z","html_url":"https://github.com/jtriley/StarCluster/pull/547#discussion_r36440790","pull_request_url":"https://api.github.com/repos/jtriley/StarCluster/pulls/547","_links":{"self":{"href":"https://api.github.com/repos/jtriley/StarCluster/pulls/comments/36440790"},"html":{"href":"https://github.com/jtriley/StarCluster/pull/547#discussion_r36440790"},"pull_request":{"href":"https://api.github.com/repos/jtriley/StarCluster/pulls/547"}}},"pull_request":{"url":"https://api.github.com/repos/jtriley/StarCluster/pulls/547","id":41730858,"html_url":"https://github.com/jtriley/StarCluster/pull/547","diff_url":"https://github.com/jtriley/StarCluster/pull/547.diff","patch_url":"https://github.com/jtriley/StarCluster/pull/547.patch","issue_url":"https://api.github.com/repos/jtriley/StarCluster/issues/547","number":547,"state":"open","locked":false,"title":"Add an argument to ipcluster plugin to specify the number of engines","user":{"login":"clearf","id":1944486,"avatar_url":"https://avatars.githubusercontent.com/u/1944486?v=3","gravatar_id":"","url":"https://api.github.com/users/clearf","html_url":"https://github.com/clearf","followers_url":"https://api.github.com/users/clearf/followers","following_url":"https://api.github.com/users/clearf/following{/other_user}","gists_url":"https://api.github.com/users/clearf/gists{/gist_id}","starred_url":"https://api.github.com/users/clearf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearf/subscriptions","organizations_url":"https://api.github.com/users/clearf/orgs","repos_url":"https://api.github.com/users/clearf/repos","events_url":"https://api.github.com/users/clearf/events{/privacy}","received_events_url":"https://api.github.com/users/clearf/received_events","type":"User","site_admin":false},"body":"* Add parameters MASTER_ENGINES and NODE_ENGINES for the ipcluster and ipclusterrestart plugins to allow for the specification of a certain number of engines on the master and nodes, respectively. \r\n   * This is useful to run no calculations on the master (which can deplete resources and cause the master to hang), and \r\n   * Use e.g., scikit-learn's native joblib support (e.g., using jobs=-1) to enable multiprocessing on the nodes and reduce the amount of message passing around machines in the cluster. \r\n\r\nAlso addresses https://github.com/jtriley/StarCluster/issues/538","created_at":"2015-08-05T21:54:55Z","updated_at":"2015-08-06T17:21:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e486bbcad790956c4d07204f5c2a4121745795b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jtriley/StarCluster/pulls/547/commits","review_comments_url":"https://api.github.com/repos/jtriley/StarCluster/pulls/547/comments","review_comment_url":"https://api.github.com/repos/jtriley/StarCluster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jtriley/StarCluster/issues/547/comments","statuses_url":"https://api.github.com/repos/jtriley/StarCluster/statuses/b1ce26fb3c7b5ec5fdd0def869c05afb2b6fe34a","head":{"label":"clearf:ipcluster-plugin","ref":"ipcluster-plugin","sha":"b1ce26fb3c7b5ec5fdd0def869c05afb2b6fe34a","user":{"login":"clearf","id":1944486,"avatar_url":"https://avatars.githubusercontent.com/u/1944486?v=3","gravatar_id":"","url":"https://api.github.com/users/clearf","html_url":"https://github.com/clearf","followers_url":"https://api.github.com/users/clearf/followers","following_url":"https://api.github.com/users/clearf/following{/other_user}","gists_url":"https://api.github.com/users/clearf/gists{/gist_id}","starred_url":"https://api.github.com/users/clearf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearf/subscriptions","organizations_url":"https://api.github.com/users/clearf/orgs","repos_url":"https://api.github.com/users/clearf/repos","events_url":"https://api.github.com/users/clearf/events{/privacy}","received_events_url":"https://api.github.com/users/clearf/received_events","type":"User","site_admin":false},"repo":{"id":39800733,"name":"StarCluster","full_name":"clearf/StarCluster","owner":{"login":"clearf","id":1944486,"avatar_url":"https://avatars.githubusercontent.com/u/1944486?v=3","gravatar_id":"","url":"https://api.github.com/users/clearf","html_url":"https://github.com/clearf","followers_url":"https://api.github.com/users/clearf/followers","following_url":"https://api.github.com/users/clearf/following{/other_user}","gists_url":"https://api.github.com/users/clearf/gists{/gist_id}","starred_url":"https://api.github.com/users/clearf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearf/subscriptions","organizations_url":"https://api.github.com/users/clearf/orgs","repos_url":"https://api.github.com/users/clearf/repos","events_url":"https://api.github.com/users/clearf/events{/privacy}","received_events_url":"https://api.github.com/users/clearf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/clearf/StarCluster","description":"StarCluster is an open source cluster-computing toolkit for Amazon's Elastic Compute Cloud (EC2).","fork":true,"url":"https://api.github.com/repos/clearf/StarCluster","forks_url":"https://api.github.com/repos/clearf/StarCluster/forks","keys_url":"https://api.github.com/repos/clearf/StarCluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clearf/StarCluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clearf/StarCluster/teams","hooks_url":"https://api.github.com/repos/clearf/StarCluster/hooks","issue_events_url":"https://api.github.com/repos/clearf/StarCluster/issues/events{/number}","events_url":"https://api.github.com/repos/clearf/StarCluster/events","assignees_url":"https://api.github.com/repos/clearf/StarCluster/assignees{/user}","branches_url":"https://api.github.com/repos/clearf/StarCluster/branches{/branch}","tags_url":"https://api.github.com/repos/clearf/StarCluster/tags","blobs_url":"https://api.github.com/repos/clearf/StarCluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clearf/StarCluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clearf/StarCluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/clearf/StarCluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clearf/StarCluster/statuses/{sha}","languages_url":"https://api.github.com/repos/clearf/StarCluster/languages","stargazers_url":"https://api.github.com/repos/clearf/StarCluster/stargazers","contributors_url":"https://api.github.com/repos/clearf/StarCluster/contributors","subscribers_url":"https://api.github.com/repos/clearf/StarCluster/subscribers","subscription_url":"https://api.github.com/repos/clearf/StarCluster/subscription","commits_url":"https://api.github.com/repos/clearf/StarCluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/clearf/StarCluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/clearf/StarCluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/clearf/StarCluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/clearf/StarCluster/contents/{+path}","compare_url":"https://api.github.com/repos/clearf/StarCluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clearf/StarCluster/merges","archive_url":"https://api.github.com/repos/clearf/StarCluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clearf/StarCluster/downloads","issues_url":"https://api.github.com/repos/clearf/StarCluster/issues{/number}","pulls_url":"https://api.github.com/repos/clearf/StarCluster/pulls{/number}","milestones_url":"https://api.github.com/repos/clearf/StarCluster/milestones{/number}","notifications_url":"https://api.github.com/repos/clearf/StarCluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clearf/StarCluster/labels{/name}","releases_url":"https://api.github.com/repos/clearf/StarCluster/releases{/id}","created_at":"2015-07-27T22:21:29Z","updated_at":"2015-07-27T22:21:30Z","pushed_at":"2015-08-06T16:53:49Z","git_url":"git://github.com/clearf/StarCluster.git","ssh_url":"git@github.com:clearf/StarCluster.git","clone_url":"https://github.com/clearf/StarCluster.git","svn_url":"https://github.com/clearf/StarCluster","homepage":"http://star.mit.edu/cluster","size":10888,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"jtriley:develop","ref":"develop","sha":"91be28d9717c5fab488aa51c5434b39089b83929","user":{"login":"jtriley","id":46910,"avatar_url":"https://avatars.githubusercontent.com/u/46910?v=3","gravatar_id":"","url":"https://api.github.com/users/jtriley","html_url":"https://github.com/jtriley","followers_url":"https://api.github.com/users/jtriley/followers","following_url":"https://api.github.com/users/jtriley/following{/other_user}","gists_url":"https://api.github.com/users/jtriley/gists{/gist_id}","starred_url":"https://api.github.com/users/jtriley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtriley/subscriptions","organizations_url":"https://api.github.com/users/jtriley/orgs","repos_url":"https://api.github.com/users/jtriley/repos","events_url":"https://api.github.com/users/jtriley/events{/privacy}","received_events_url":"https://api.github.com/users/jtriley/received_events","type":"User","site_admin":false},"repo":{"id":237183,"name":"StarCluster","full_name":"jtriley/StarCluster","owner":{"login":"jtriley","id":46910,"avatar_url":"https://avatars.githubusercontent.com/u/46910?v=3","gravatar_id":"","url":"https://api.github.com/users/jtriley","html_url":"https://github.com/jtriley","followers_url":"https://api.github.com/users/jtriley/followers","following_url":"https://api.github.com/users/jtriley/following{/other_user}","gists_url":"https://api.github.com/users/jtriley/gists{/gist_id}","starred_url":"https://api.github.com/users/jtriley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtriley/subscriptions","organizations_url":"https://api.github.com/users/jtriley/orgs","repos_url":"https://api.github.com/users/jtriley/repos","events_url":"https://api.github.com/users/jtriley/events{/privacy}","received_events_url":"https://api.github.com/users/jtriley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jtriley/StarCluster","description":"StarCluster is an open source cluster-computing toolkit for Amazon's Elastic Compute Cloud (EC2).","fork":false,"url":"https://api.github.com/repos/jtriley/StarCluster","forks_url":"https://api.github.com/repos/jtriley/StarCluster/forks","keys_url":"https://api.github.com/repos/jtriley/StarCluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jtriley/StarCluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jtriley/StarCluster/teams","hooks_url":"https://api.github.com/repos/jtriley/StarCluster/hooks","issue_events_url":"https://api.github.com/repos/jtriley/StarCluster/issues/events{/number}","events_url":"https://api.github.com/repos/jtriley/StarCluster/events","assignees_url":"https://api.github.com/repos/jtriley/StarCluster/assignees{/user}","branches_url":"https://api.github.com/repos/jtriley/StarCluster/branches{/branch}","tags_url":"https://api.github.com/repos/jtriley/StarCluster/tags","blobs_url":"https://api.github.com/repos/jtriley/StarCluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jtriley/StarCluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jtriley/StarCluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/jtriley/StarCluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jtriley/StarCluster/statuses/{sha}","languages_url":"https://api.github.com/repos/jtriley/StarCluster/languages","stargazers_url":"https://api.github.com/repos/jtriley/StarCluster/stargazers","contributors_url":"https://api.github.com/repos/jtriley/StarCluster/contributors","subscribers_url":"https://api.github.com/repos/jtriley/StarCluster/subscribers","subscription_url":"https://api.github.com/repos/jtriley/StarCluster/subscription","commits_url":"https://api.github.com/repos/jtriley/StarCluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/jtriley/StarCluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/jtriley/StarCluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/jtriley/StarCluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/jtriley/StarCluster/contents/{+path}","compare_url":"https://api.github.com/repos/jtriley/StarCluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jtriley/StarCluster/merges","archive_url":"https://api.github.com/repos/jtriley/StarCluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jtriley/StarCluster/downloads","issues_url":"https://api.github.com/repos/jtriley/StarCluster/issues{/number}","pulls_url":"https://api.github.com/repos/jtriley/StarCluster/pulls{/number}","milestones_url":"https://api.github.com/repos/jtriley/StarCluster/milestones{/number}","notifications_url":"https://api.github.com/repos/jtriley/StarCluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jtriley/StarCluster/labels{/name}","releases_url":"https://api.github.com/repos/jtriley/StarCluster/releases{/id}","created_at":"2009-06-26T19:36:47Z","updated_at":"2015-08-03T12:20:37Z","pushed_at":"2015-08-06T16:53:50Z","git_url":"git://github.com/jtriley/StarCluster.git","ssh_url":"git@github.com:jtriley/StarCluster.git","clone_url":"https://github.com/jtriley/StarCluster.git","svn_url":"https://github.com/jtriley/StarCluster","homepage":"http://star.mit.edu/cluster","size":10816,"stargazers_count":439,"watchers_count":439,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":255,"mirror_url":null,"open_issues_count":219,"forks":255,"open_issues":219,"watchers":439,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/jtriley/StarCluster/pulls/547"},"html":{"href":"https://github.com/jtriley/StarCluster/pull/547"},"issue":{"href":"https://api.github.com/repos/jtriley/StarCluster/issues/547"},"comments":{"href":"https://api.github.com/repos/jtriley/StarCluster/issues/547/comments"},"review_comments":{"href":"https://api.github.com/repos/jtriley/StarCluster/pulls/547/comments"},"review_comment":{"href":"https://api.github.com/repos/jtriley/StarCluster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jtriley/StarCluster/pulls/547/commits"},"statuses":{"href":"https://api.github.com/repos/jtriley/StarCluster/statuses/b1ce26fb3c7b5ec5fdd0def869c05afb2b6fe34a"}}}}