{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/33838724","id":33838724,"diff_hunk":"@@ -248,9 +251,9 @@ public function getDate($key, \\DateTime $default = null)\n      */\n     public function addCacheControlDirective($key, $value = true)\n     {\n-        $this->cacheControl[$key] = $value;\n+        $this->cacheControl->addDirective($key, $value);\n \n-        $this->set('Cache-Control', $this->getCacheControlHeader());\n+        $this->set('Cache-Control', (string)$this->cacheControl);","path":"src/Symfony/Component/HttpFoundation/HeaderBag.php","position":43,"original_position":43,"commit_id":"857ecec18b17eb561b51650cdad8700a8c99a11e","original_commit_id":"857ecec18b17eb561b51650cdad8700a8c99a11e","user":{"login":"dosten","id":510842,"avatar_url":"https://avatars.githubusercontent.com/u/510842?v=3","gravatar_id":"","url":"https://api.github.com/users/dosten","html_url":"https://github.com/dosten","followers_url":"https://api.github.com/users/dosten/followers","following_url":"https://api.github.com/users/dosten/following{/other_user}","gists_url":"https://api.github.com/users/dosten/gists{/gist_id}","starred_url":"https://api.github.com/users/dosten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dosten/subscriptions","organizations_url":"https://api.github.com/users/dosten/orgs","repos_url":"https://api.github.com/users/dosten/repos","events_url":"https://api.github.com/users/dosten/events{/privacy}","received_events_url":"https://api.github.com/users/dosten/received_events","type":"User","site_admin":false},"body":"Missing space between the type cast and the variable","created_at":"2015-07-03T03:24:53Z","updated_at":"2015-07-03T03:24:53Z","html_url":"https://github.com/symfony/symfony/pull/15186#discussion_r33838724","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/15186","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/33838724"},"html":{"href":"https://github.com/symfony/symfony/pull/15186#discussion_r33838724"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/15186"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/15186","id":39141302,"html_url":"https://github.com/symfony/symfony/pull/15186","diff_url":"https://github.com/symfony/symfony/pull/15186.diff","patch_url":"https://github.com/symfony/symfony/pull/15186.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/15186","number":15186,"state":"open","locked":false,"title":"[WIP][Http Foundation] psr7 updates - request class refactor","user":{"login":"yjv","id":2610269,"avatar_url":"https://avatars.githubusercontent.com/u/2610269?v=3","gravatar_id":"","url":"https://api.github.com/users/yjv","html_url":"https://github.com/yjv","followers_url":"https://api.github.com/users/yjv/followers","following_url":"https://api.github.com/users/yjv/following{/other_user}","gists_url":"https://api.github.com/users/yjv/gists{/gist_id}","starred_url":"https://api.github.com/users/yjv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjv/subscriptions","organizations_url":"https://api.github.com/users/yjv/orgs","repos_url":"https://api.github.com/users/yjv/repos","events_url":"https://api.github.com/users/yjv/events{/privacy}","received_events_url":"https://api.github.com/users/yjv/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | yes\r\n| Tests pass?   | \r\n| Fixed tickets | \r\n| License       | MIT\r\n| Doc PR        | none yet\r\n\r\nThis is the WIP pr for the fisrt part of the work for adding support for psr7 in http foundation. at the moment i have copied most of the methods not connected with actually working with the request data itself to a few helper classes located in the `Symfony\\Component\\HttpFaoundation\\Request` namespace. The move is mostly to just get an idea of what methods need to be refactored out and to give it a rudimentary organization. Im working now on moving whatever methods can be made into more generally useful classes. to that affect I have moved header parsing to its own namespace now `Symfony\\Component\\HttpFoundation\\Header` ive added 2 headers CacheControl for managing the cache control stuff and IfNoneMatch to manage etags. I have starting work on the request uri and base url resolving by adding 2 new interfaces and plan to make a chain of request uri resolvers and base url resolvers.\r\nIm still working on getting a good idea on all the parts of this refactor and so this doesnt yet pass all unit tests or follow all the formatting requirements.\r\n\r\nComments and question are most welcome. \r\n\r\nThanks all!","created_at":"2015-07-03T02:15:50Z","updated_at":"2015-07-03T03:24:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f64d0977d7992d1c1e0348e835b7bb7f6f4dc35","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/15186/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/15186/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/15186/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/857ecec18b17eb561b51650cdad8700a8c99a11e","head":{"label":"yjv:2.8-refactor-request","ref":"2.8-refactor-request","sha":"857ecec18b17eb561b51650cdad8700a8c99a11e","user":{"login":"yjv","id":2610269,"avatar_url":"https://avatars.githubusercontent.com/u/2610269?v=3","gravatar_id":"","url":"https://api.github.com/users/yjv","html_url":"https://github.com/yjv","followers_url":"https://api.github.com/users/yjv/followers","following_url":"https://api.github.com/users/yjv/following{/other_user}","gists_url":"https://api.github.com/users/yjv/gists{/gist_id}","starred_url":"https://api.github.com/users/yjv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjv/subscriptions","organizations_url":"https://api.github.com/users/yjv/orgs","repos_url":"https://api.github.com/users/yjv/repos","events_url":"https://api.github.com/users/yjv/events{/privacy}","received_events_url":"https://api.github.com/users/yjv/received_events","type":"User","site_admin":false},"repo":{"id":37837141,"name":"symfony","full_name":"yjv/symfony","owner":{"login":"yjv","id":2610269,"avatar_url":"https://avatars.githubusercontent.com/u/2610269?v=3","gravatar_id":"","url":"https://api.github.com/users/yjv","html_url":"https://github.com/yjv","followers_url":"https://api.github.com/users/yjv/followers","following_url":"https://api.github.com/users/yjv/following{/other_user}","gists_url":"https://api.github.com/users/yjv/gists{/gist_id}","starred_url":"https://api.github.com/users/yjv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjv/subscriptions","organizations_url":"https://api.github.com/users/yjv/orgs","repos_url":"https://api.github.com/users/yjv/repos","events_url":"https://api.github.com/users/yjv/events{/privacy}","received_events_url":"https://api.github.com/users/yjv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yjv/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/yjv/symfony","forks_url":"https://api.github.com/repos/yjv/symfony/forks","keys_url":"https://api.github.com/repos/yjv/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yjv/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yjv/symfony/teams","hooks_url":"https://api.github.com/repos/yjv/symfony/hooks","issue_events_url":"https://api.github.com/repos/yjv/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/yjv/symfony/events","assignees_url":"https://api.github.com/repos/yjv/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/yjv/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/yjv/symfony/tags","blobs_url":"https://api.github.com/repos/yjv/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yjv/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yjv/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/yjv/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yjv/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/yjv/symfony/languages","stargazers_url":"https://api.github.com/repos/yjv/symfony/stargazers","contributors_url":"https://api.github.com/repos/yjv/symfony/contributors","subscribers_url":"https://api.github.com/repos/yjv/symfony/subscribers","subscription_url":"https://api.github.com/repos/yjv/symfony/subscription","commits_url":"https://api.github.com/repos/yjv/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/yjv/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/yjv/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/yjv/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/yjv/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/yjv/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yjv/symfony/merges","archive_url":"https://api.github.com/repos/yjv/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yjv/symfony/downloads","issues_url":"https://api.github.com/repos/yjv/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/yjv/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/yjv/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/yjv/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yjv/symfony/labels{/name}","releases_url":"https://api.github.com/repos/yjv/symfony/releases{/id}","created_at":"2015-06-22T04:17:45Z","updated_at":"2015-06-22T04:17:59Z","pushed_at":"2015-07-03T02:39:45Z","git_url":"git://github.com/yjv/symfony.git","ssh_url":"git@github.com:yjv/symfony.git","clone_url":"https://github.com/yjv/symfony.git","svn_url":"https://github.com/yjv/symfony","homepage":"symfony.com","size":57724,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.8"}},"base":{"label":"symfony:2.8","ref":"2.8","sha":"86e77eb36b0fd8bbd6a41f84b5b3cb26b886ace8","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2015-07-02T19:38:54Z","pushed_at":"2015-07-03T02:39:48Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":1194939,"stargazers_count":10412,"watchers_count":10412,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4136,"mirror_url":null,"open_issues_count":853,"forks":4136,"open_issues":853,"watchers":10412,"default_branch":"2.8"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/15186"},"html":{"href":"https://github.com/symfony/symfony/pull/15186"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/15186"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/15186/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/15186/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/15186/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/857ecec18b17eb561b51650cdad8700a8c99a11e"}}}}