{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/ruby-hocon/pulls/comments/26958532","id":26958532,"diff_hunk":"@@ -0,0 +1,28 @@\n+# encoding: utf-8\n+\n+require 'uri'\n+require 'hocon/impl'\n+\n+# There are several places in the Java codebase that\n+# use Java's URL constructor, and rely on it to throw\n+# a `MalformedURLException` if the URL isn't valid.\n+#\n+# Ruby doesn't really have a similar constructor /\n+# validator, so this is a little shim to hopefully\n+# make the ported code match up with the upstream more\n+# closely.\n+class Hocon::Impl::Url\n+  class MalformedUrlError < StandardError\n+  end\n+\n+  def initialize(url)\n+    begin\n+      @url = URI.parse(url)\n+      if !(@url.kind_of?(URI::HTTP))\n+        raise MalformedUrlError, \"Unrecognized URL: '#{url}'\"\n+      end\n+    rescue URI::InvalidURIError\n+      raise MalformedUrlError, \"Unrecognized URL: '#{url}'\"\n+    end\n+  end\n+end","path":"lib/hocon/impl/url.rb","position":28,"original_position":28,"commit_id":"60f016e845698e5fdc65ca6bebfc8bf29213e7df","original_commit_id":"cac32f63f4d7dbb6f8bc14c0d362ff42bf03953c","user":{"login":"cprice404","id":1341071,"avatar_url":"https://avatars.githubusercontent.com/u/1341071?v=3","gravatar_id":"","url":"https://api.github.com/users/cprice404","html_url":"https://github.com/cprice404","followers_url":"https://api.github.com/users/cprice404/followers","following_url":"https://api.github.com/users/cprice404/following{/other_user}","gists_url":"https://api.github.com/users/cprice404/gists{/gist_id}","starred_url":"https://api.github.com/users/cprice404/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cprice404/subscriptions","organizations_url":"https://api.github.com/users/cprice404/orgs","repos_url":"https://api.github.com/users/cprice404/repos","events_url":"https://api.github.com/users/cprice404/events{/privacy}","received_events_url":"https://api.github.com/users/cprice404/received_events","type":"User","site_admin":false},"body":"Yeah, that was my reasoning as well.","created_at":"2015-03-23T17:27:26Z","updated_at":"2015-03-23T17:27:26Z","html_url":"https://github.com/puppetlabs/ruby-hocon/pull/33#discussion_r26958532","pull_request_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/ruby-hocon/pulls/comments/26958532"},"html":{"href":"https://github.com/puppetlabs/ruby-hocon/pull/33#discussion_r26958532"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/ruby-hocon/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/ruby-hocon/pulls/33","id":31750351,"html_url":"https://github.com/puppetlabs/ruby-hocon/pull/33","diff_url":"https://github.com/puppetlabs/ruby-hocon/pull/33.diff","patch_url":"https://github.com/puppetlabs/ruby-hocon/pull/33.patch","issue_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/issues/33","number":33,"state":"open","locked":false,"title":"(FOR REVIEW) (TK-160) Port minimal `include` functionality","user":{"login":"cprice404","id":1341071,"avatar_url":"https://avatars.githubusercontent.com/u/1341071?v=3","gravatar_id":"","url":"https://api.github.com/users/cprice404","html_url":"https://github.com/cprice404","followers_url":"https://api.github.com/users/cprice404/followers","following_url":"https://api.github.com/users/cprice404/following{/other_user}","gists_url":"https://api.github.com/users/cprice404/gists{/gist_id}","starred_url":"https://api.github.com/users/cprice404/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cprice404/subscriptions","organizations_url":"https://api.github.com/users/cprice404/orgs","repos_url":"https://api.github.com/users/cprice404/repos","events_url":"https://api.github.com/users/cprice404/events{/privacy}","received_events_url":"https://api.github.com/users/cprice404/received_events","type":"User","site_admin":false},"body":"FOR REVIEW: this should probably land after @jpinsonault 's current PR.  I've already rebased in onto his current branch just to get a feel for whether or not there were going to be conflicts; it went smoothly.  I'll rebase it again onto master once his PR is merged, but wanted to go ahead and get this up so that people could see what files it touches just to make sure that we're not duplicating efforts too much.\r\n\r\n==================================================\r\n\r\nThis commit re-enables some disabled config parser tests that\r\nhad been failing due to missing functionality around HOCON's\r\n`include` capabilities.  It also includes a minimal port\r\nof all of the `include` functionality that was required\r\nto get the tests passing.","created_at":"2015-03-23T16:44:01Z","updated_at":"2015-03-23T17:27:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03236d57e3472e4d3a630290ae7e5bdecf17894c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/pulls/33/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/pulls/33/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/issues/33/comments","statuses_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/statuses/60f016e845698e5fdc65ca6bebfc8bf29213e7df","head":{"label":"cprice404:feature/master/TK-160-port-conf-parser-tests","ref":"feature/master/TK-160-port-conf-parser-tests","sha":"60f016e845698e5fdc65ca6bebfc8bf29213e7df","user":{"login":"cprice404","id":1341071,"avatar_url":"https://avatars.githubusercontent.com/u/1341071?v=3","gravatar_id":"","url":"https://api.github.com/users/cprice404","html_url":"https://github.com/cprice404","followers_url":"https://api.github.com/users/cprice404/followers","following_url":"https://api.github.com/users/cprice404/following{/other_user}","gists_url":"https://api.github.com/users/cprice404/gists{/gist_id}","starred_url":"https://api.github.com/users/cprice404/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cprice404/subscriptions","organizations_url":"https://api.github.com/users/cprice404/orgs","repos_url":"https://api.github.com/users/cprice404/repos","events_url":"https://api.github.com/users/cprice404/events{/privacy}","received_events_url":"https://api.github.com/users/cprice404/received_events","type":"User","site_admin":false},"repo":{"id":32554335,"name":"ruby-hocon","full_name":"cprice404/ruby-hocon","owner":{"login":"cprice404","id":1341071,"avatar_url":"https://avatars.githubusercontent.com/u/1341071?v=3","gravatar_id":"","url":"https://api.github.com/users/cprice404","html_url":"https://github.com/cprice404","followers_url":"https://api.github.com/users/cprice404/followers","following_url":"https://api.github.com/users/cprice404/following{/other_user}","gists_url":"https://api.github.com/users/cprice404/gists{/gist_id}","starred_url":"https://api.github.com/users/cprice404/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cprice404/subscriptions","organizations_url":"https://api.github.com/users/cprice404/orgs","repos_url":"https://api.github.com/users/cprice404/repos","events_url":"https://api.github.com/users/cprice404/events{/privacy}","received_events_url":"https://api.github.com/users/cprice404/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cprice404/ruby-hocon","description":"","fork":true,"url":"https://api.github.com/repos/cprice404/ruby-hocon","forks_url":"https://api.github.com/repos/cprice404/ruby-hocon/forks","keys_url":"https://api.github.com/repos/cprice404/ruby-hocon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cprice404/ruby-hocon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cprice404/ruby-hocon/teams","hooks_url":"https://api.github.com/repos/cprice404/ruby-hocon/hooks","issue_events_url":"https://api.github.com/repos/cprice404/ruby-hocon/issues/events{/number}","events_url":"https://api.github.com/repos/cprice404/ruby-hocon/events","assignees_url":"https://api.github.com/repos/cprice404/ruby-hocon/assignees{/user}","branches_url":"https://api.github.com/repos/cprice404/ruby-hocon/branches{/branch}","tags_url":"https://api.github.com/repos/cprice404/ruby-hocon/tags","blobs_url":"https://api.github.com/repos/cprice404/ruby-hocon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cprice404/ruby-hocon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cprice404/ruby-hocon/git/refs{/sha}","trees_url":"https://api.github.com/repos/cprice404/ruby-hocon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cprice404/ruby-hocon/statuses/{sha}","languages_url":"https://api.github.com/repos/cprice404/ruby-hocon/languages","stargazers_url":"https://api.github.com/repos/cprice404/ruby-hocon/stargazers","contributors_url":"https://api.github.com/repos/cprice404/ruby-hocon/contributors","subscribers_url":"https://api.github.com/repos/cprice404/ruby-hocon/subscribers","subscription_url":"https://api.github.com/repos/cprice404/ruby-hocon/subscription","commits_url":"https://api.github.com/repos/cprice404/ruby-hocon/commits{/sha}","git_commits_url":"https://api.github.com/repos/cprice404/ruby-hocon/git/commits{/sha}","comments_url":"https://api.github.com/repos/cprice404/ruby-hocon/comments{/number}","issue_comment_url":"https://api.github.com/repos/cprice404/ruby-hocon/issues/comments{/number}","contents_url":"https://api.github.com/repos/cprice404/ruby-hocon/contents/{+path}","compare_url":"https://api.github.com/repos/cprice404/ruby-hocon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cprice404/ruby-hocon/merges","archive_url":"https://api.github.com/repos/cprice404/ruby-hocon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cprice404/ruby-hocon/downloads","issues_url":"https://api.github.com/repos/cprice404/ruby-hocon/issues{/number}","pulls_url":"https://api.github.com/repos/cprice404/ruby-hocon/pulls{/number}","milestones_url":"https://api.github.com/repos/cprice404/ruby-hocon/milestones{/number}","notifications_url":"https://api.github.com/repos/cprice404/ruby-hocon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cprice404/ruby-hocon/labels{/name}","releases_url":"https://api.github.com/repos/cprice404/ruby-hocon/releases{/id}","created_at":"2015-03-20T00:49:03Z","updated_at":"2015-03-20T00:49:04Z","pushed_at":"2015-03-23T17:26:40Z","git_url":"git://github.com/cprice404/ruby-hocon.git","ssh_url":"git@github.com:cprice404/ruby-hocon.git","clone_url":"https://github.com/cprice404/ruby-hocon.git","svn_url":"https://github.com/cprice404/ruby-hocon","homepage":null,"size":666,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"f28f78ea84b8b21fad3b37ce171b259b793a9485","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":17326988,"name":"ruby-hocon","full_name":"puppetlabs/ruby-hocon","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/ruby-hocon","description":"","fork":false,"url":"https://api.github.com/repos/puppetlabs/ruby-hocon","forks_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/forks","keys_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/teams","hooks_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/events","assignees_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/tags","blobs_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/subscription","commits_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/merges","archive_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/downloads","issues_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/ruby-hocon/releases{/id}","created_at":"2014-03-01T23:44:17Z","updated_at":"2015-03-20T21:47:40Z","pushed_at":"2015-03-23T17:26:40Z","git_url":"git://github.com/puppetlabs/ruby-hocon.git","ssh_url":"git@github.com:puppetlabs/ruby-hocon.git","clone_url":"https://github.com/puppetlabs/ruby-hocon.git","svn_url":"https://github.com/puppetlabs/ruby-hocon","homepage":null,"size":666,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":3,"forks":7,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/ruby-hocon/pulls/33"},"html":{"href":"https://github.com/puppetlabs/ruby-hocon/pull/33"},"issue":{"href":"https://api.github.com/repos/puppetlabs/ruby-hocon/issues/33"},"comments":{"href":"https://api.github.com/repos/puppetlabs/ruby-hocon/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/ruby-hocon/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/ruby-hocon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/ruby-hocon/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/ruby-hocon/statuses/60f016e845698e5fdc65ca6bebfc8bf29213e7df"}}}}