{"action":"created","comment":{"url":"https://api.github.com/repos/boostorg/geometry/pulls/comments/24520296","id":24520296,"diff_hunk":"@@ -892,7 +893,7 @@ inline void buffer_inserter(GeometryInput const& geometry_input, OutputIterator\n \n     collection.get_turns();\n     collection.classify_turns(linear);\n-    if (areal)\n+    if ( BOOST_GEOMETRY_CONDITION(areal) )","path":"include/boost/geometry/algorithms/detail/buffer/buffer_inserter.hpp","position":13,"original_position":13,"commit_id":"1a5a1fa66164cf4647bdbf529090d03e15c07411","original_commit_id":"1a5a1fa66164cf4647bdbf529090d03e15c07411","user":{"login":"barendgehrels","id":334849,"avatar_url":"https://avatars.githubusercontent.com/u/334849?v=3","gravatar_id":"","url":"https://api.github.com/users/barendgehrels","html_url":"https://github.com/barendgehrels","followers_url":"https://api.github.com/users/barendgehrels/followers","following_url":"https://api.github.com/users/barendgehrels/following{/other_user}","gists_url":"https://api.github.com/users/barendgehrels/gists{/gist_id}","starred_url":"https://api.github.com/users/barendgehrels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barendgehrels/subscriptions","organizations_url":"https://api.github.com/users/barendgehrels/orgs","repos_url":"https://api.github.com/users/barendgehrels/repos","events_url":"https://api.github.com/users/barendgehrels/events{/privacy}","received_events_url":"https://api.github.com/users/barendgehrels/received_events","type":"User","site_admin":false},"body":"Idem, and everywhere","created_at":"2015-02-11T18:38:49Z","updated_at":"2015-02-11T18:38:49Z","html_url":"https://github.com/boostorg/geometry/pull/218#discussion_r24520296","pull_request_url":"https://api.github.com/repos/boostorg/geometry/pulls/218","_links":{"self":{"href":"https://api.github.com/repos/boostorg/geometry/pulls/comments/24520296"},"html":{"href":"https://github.com/boostorg/geometry/pull/218#discussion_r24520296"},"pull_request":{"href":"https://api.github.com/repos/boostorg/geometry/pulls/218"}}},"pull_request":{"url":"https://api.github.com/repos/boostorg/geometry/pulls/218","id":29097915,"html_url":"https://github.com/boostorg/geometry/pull/218","diff_url":"https://github.com/boostorg/geometry/pull/218.diff","patch_url":"https://github.com/boostorg/geometry/pull/218.patch","issue_url":"https://api.github.com/repos/boostorg/geometry/issues/218","number":218,"state":"open","locked":false,"title":"Fix/warnings","user":{"login":"awulkiew","id":1226951,"avatar_url":"https://avatars.githubusercontent.com/u/1226951?v=3","gravatar_id":"","url":"https://api.github.com/users/awulkiew","html_url":"https://github.com/awulkiew","followers_url":"https://api.github.com/users/awulkiew/followers","following_url":"https://api.github.com/users/awulkiew/following{/other_user}","gists_url":"https://api.github.com/users/awulkiew/gists{/gist_id}","starred_url":"https://api.github.com/users/awulkiew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awulkiew/subscriptions","organizations_url":"https://api.github.com/users/awulkiew/orgs","repos_url":"https://api.github.com/users/awulkiew/repos","events_url":"https://api.github.com/users/awulkiew/events{/privacy}","received_events_url":"https://api.github.com/users/awulkiew/received_events","type":"User","site_admin":false},"body":"This PR fixes the MSVC compiler warning C4127: conditional expression is constant in all parts of the library.\r\n\r\nFor this purpose a macro BOOST_GEOMETRY_CONDITION was added. It should be used in cases when a conditional expression may be constant.\r\nNote that the same expression may or may not be constant in various cases when template specialization is involved.","created_at":"2015-02-11T15:08:57Z","updated_at":"2015-02-11T18:38:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6cc5a5e614f0997528034dca59b0c3209a41e7c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/boostorg/geometry/pulls/218/commits","review_comments_url":"https://api.github.com/repos/boostorg/geometry/pulls/218/comments","review_comment_url":"https://api.github.com/repos/boostorg/geometry/pulls/comments/{number}","comments_url":"https://api.github.com/repos/boostorg/geometry/issues/218/comments","statuses_url":"https://api.github.com/repos/boostorg/geometry/statuses/1a5a1fa66164cf4647bdbf529090d03e15c07411","head":{"label":"awulkiew:fix/warnings","ref":"fix/warnings","sha":"1a5a1fa66164cf4647bdbf529090d03e15c07411","user":{"login":"awulkiew","id":1226951,"avatar_url":"https://avatars.githubusercontent.com/u/1226951?v=3","gravatar_id":"","url":"https://api.github.com/users/awulkiew","html_url":"https://github.com/awulkiew","followers_url":"https://api.github.com/users/awulkiew/followers","following_url":"https://api.github.com/users/awulkiew/following{/other_user}","gists_url":"https://api.github.com/users/awulkiew/gists{/gist_id}","starred_url":"https://api.github.com/users/awulkiew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awulkiew/subscriptions","organizations_url":"https://api.github.com/users/awulkiew/orgs","repos_url":"https://api.github.com/users/awulkiew/repos","events_url":"https://api.github.com/users/awulkiew/events{/privacy}","received_events_url":"https://api.github.com/users/awulkiew/received_events","type":"User","site_admin":false},"repo":{"id":20000078,"name":"geometry","full_name":"awulkiew/geometry","owner":{"login":"awulkiew","id":1226951,"avatar_url":"https://avatars.githubusercontent.com/u/1226951?v=3","gravatar_id":"","url":"https://api.github.com/users/awulkiew","html_url":"https://github.com/awulkiew","followers_url":"https://api.github.com/users/awulkiew/followers","following_url":"https://api.github.com/users/awulkiew/following{/other_user}","gists_url":"https://api.github.com/users/awulkiew/gists{/gist_id}","starred_url":"https://api.github.com/users/awulkiew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awulkiew/subscriptions","organizations_url":"https://api.github.com/users/awulkiew/orgs","repos_url":"https://api.github.com/users/awulkiew/repos","events_url":"https://api.github.com/users/awulkiew/events{/privacy}","received_events_url":"https://api.github.com/users/awulkiew/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/awulkiew/geometry","description":"Boost.org geometry module","fork":true,"url":"https://api.github.com/repos/awulkiew/geometry","forks_url":"https://api.github.com/repos/awulkiew/geometry/forks","keys_url":"https://api.github.com/repos/awulkiew/geometry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awulkiew/geometry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awulkiew/geometry/teams","hooks_url":"https://api.github.com/repos/awulkiew/geometry/hooks","issue_events_url":"https://api.github.com/repos/awulkiew/geometry/issues/events{/number}","events_url":"https://api.github.com/repos/awulkiew/geometry/events","assignees_url":"https://api.github.com/repos/awulkiew/geometry/assignees{/user}","branches_url":"https://api.github.com/repos/awulkiew/geometry/branches{/branch}","tags_url":"https://api.github.com/repos/awulkiew/geometry/tags","blobs_url":"https://api.github.com/repos/awulkiew/geometry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awulkiew/geometry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awulkiew/geometry/git/refs{/sha}","trees_url":"https://api.github.com/repos/awulkiew/geometry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awulkiew/geometry/statuses/{sha}","languages_url":"https://api.github.com/repos/awulkiew/geometry/languages","stargazers_url":"https://api.github.com/repos/awulkiew/geometry/stargazers","contributors_url":"https://api.github.com/repos/awulkiew/geometry/contributors","subscribers_url":"https://api.github.com/repos/awulkiew/geometry/subscribers","subscription_url":"https://api.github.com/repos/awulkiew/geometry/subscription","commits_url":"https://api.github.com/repos/awulkiew/geometry/commits{/sha}","git_commits_url":"https://api.github.com/repos/awulkiew/geometry/git/commits{/sha}","comments_url":"https://api.github.com/repos/awulkiew/geometry/comments{/number}","issue_comment_url":"https://api.github.com/repos/awulkiew/geometry/issues/comments/{number}","contents_url":"https://api.github.com/repos/awulkiew/geometry/contents/{+path}","compare_url":"https://api.github.com/repos/awulkiew/geometry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awulkiew/geometry/merges","archive_url":"https://api.github.com/repos/awulkiew/geometry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awulkiew/geometry/downloads","issues_url":"https://api.github.com/repos/awulkiew/geometry/issues{/number}","pulls_url":"https://api.github.com/repos/awulkiew/geometry/pulls{/number}","milestones_url":"https://api.github.com/repos/awulkiew/geometry/milestones{/number}","notifications_url":"https://api.github.com/repos/awulkiew/geometry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awulkiew/geometry/labels{/name}","releases_url":"https://api.github.com/repos/awulkiew/geometry/releases{/id}","created_at":"2014-05-20T22:38:29Z","updated_at":"2014-11-21T16:24:43Z","pushed_at":"2015-02-11T18:28:08Z","git_url":"git://github.com/awulkiew/geometry.git","ssh_url":"git@github.com:awulkiew/geometry.git","clone_url":"https://github.com/awulkiew/geometry.git","svn_url":"https://github.com/awulkiew/geometry","homepage":"http://boost.org/libs/geometry","size":33987,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"boostorg:develop","ref":"develop","sha":"db3743b4fdc38f0c980271cfab21844b1d983dac","user":{"login":"boostorg","id":3170529,"avatar_url":"https://avatars.githubusercontent.com/u/3170529?v=3","gravatar_id":"","url":"https://api.github.com/users/boostorg","html_url":"https://github.com/boostorg","followers_url":"https://api.github.com/users/boostorg/followers","following_url":"https://api.github.com/users/boostorg/following{/other_user}","gists_url":"https://api.github.com/users/boostorg/gists{/gist_id}","starred_url":"https://api.github.com/users/boostorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boostorg/subscriptions","organizations_url":"https://api.github.com/users/boostorg/orgs","repos_url":"https://api.github.com/users/boostorg/repos","events_url":"https://api.github.com/users/boostorg/events{/privacy}","received_events_url":"https://api.github.com/users/boostorg/received_events","type":"Organization","site_admin":false},"repo":{"id":7590021,"name":"geometry","full_name":"boostorg/geometry","owner":{"login":"boostorg","id":3170529,"avatar_url":"https://avatars.githubusercontent.com/u/3170529?v=3","gravatar_id":"","url":"https://api.github.com/users/boostorg","html_url":"https://github.com/boostorg","followers_url":"https://api.github.com/users/boostorg/followers","following_url":"https://api.github.com/users/boostorg/following{/other_user}","gists_url":"https://api.github.com/users/boostorg/gists{/gist_id}","starred_url":"https://api.github.com/users/boostorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boostorg/subscriptions","organizations_url":"https://api.github.com/users/boostorg/orgs","repos_url":"https://api.github.com/users/boostorg/repos","events_url":"https://api.github.com/users/boostorg/events{/privacy}","received_events_url":"https://api.github.com/users/boostorg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/boostorg/geometry","description":"Boost.org geometry module","fork":false,"url":"https://api.github.com/repos/boostorg/geometry","forks_url":"https://api.github.com/repos/boostorg/geometry/forks","keys_url":"https://api.github.com/repos/boostorg/geometry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boostorg/geometry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boostorg/geometry/teams","hooks_url":"https://api.github.com/repos/boostorg/geometry/hooks","issue_events_url":"https://api.github.com/repos/boostorg/geometry/issues/events{/number}","events_url":"https://api.github.com/repos/boostorg/geometry/events","assignees_url":"https://api.github.com/repos/boostorg/geometry/assignees{/user}","branches_url":"https://api.github.com/repos/boostorg/geometry/branches{/branch}","tags_url":"https://api.github.com/repos/boostorg/geometry/tags","blobs_url":"https://api.github.com/repos/boostorg/geometry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boostorg/geometry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boostorg/geometry/git/refs{/sha}","trees_url":"https://api.github.com/repos/boostorg/geometry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boostorg/geometry/statuses/{sha}","languages_url":"https://api.github.com/repos/boostorg/geometry/languages","stargazers_url":"https://api.github.com/repos/boostorg/geometry/stargazers","contributors_url":"https://api.github.com/repos/boostorg/geometry/contributors","subscribers_url":"https://api.github.com/repos/boostorg/geometry/subscribers","subscription_url":"https://api.github.com/repos/boostorg/geometry/subscription","commits_url":"https://api.github.com/repos/boostorg/geometry/commits{/sha}","git_commits_url":"https://api.github.com/repos/boostorg/geometry/git/commits{/sha}","comments_url":"https://api.github.com/repos/boostorg/geometry/comments{/number}","issue_comment_url":"https://api.github.com/repos/boostorg/geometry/issues/comments/{number}","contents_url":"https://api.github.com/repos/boostorg/geometry/contents/{+path}","compare_url":"https://api.github.com/repos/boostorg/geometry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boostorg/geometry/merges","archive_url":"https://api.github.com/repos/boostorg/geometry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boostorg/geometry/downloads","issues_url":"https://api.github.com/repos/boostorg/geometry/issues{/number}","pulls_url":"https://api.github.com/repos/boostorg/geometry/pulls{/number}","milestones_url":"https://api.github.com/repos/boostorg/geometry/milestones{/number}","notifications_url":"https://api.github.com/repos/boostorg/geometry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boostorg/geometry/labels{/name}","releases_url":"https://api.github.com/repos/boostorg/geometry/releases{/id}","created_at":"2013-01-13T15:59:29Z","updated_at":"2015-02-08T13:47:49Z","pushed_at":"2015-02-11T18:20:54Z","git_url":"git://github.com/boostorg/geometry.git","ssh_url":"git@github.com:boostorg/geometry.git","clone_url":"https://github.com/boostorg/geometry.git","svn_url":"https://github.com/boostorg/geometry","homepage":"http://boost.org/libs/geometry","size":45758,"stargazers_count":41,"watchers_count":41,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":5,"forks":25,"open_issues":5,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/boostorg/geometry/pulls/218"},"html":{"href":"https://github.com/boostorg/geometry/pull/218"},"issue":{"href":"https://api.github.com/repos/boostorg/geometry/issues/218"},"comments":{"href":"https://api.github.com/repos/boostorg/geometry/issues/218/comments"},"review_comments":{"href":"https://api.github.com/repos/boostorg/geometry/pulls/218/comments"},"review_comment":{"href":"https://api.github.com/repos/boostorg/geometry/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/boostorg/geometry/pulls/218/commits"},"statuses":{"href":"https://api.github.com/repos/boostorg/geometry/statuses/1a5a1fa66164cf4647bdbf529090d03e15c07411"}}}}