{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/issues/267","labels_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/issues/267/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/issues/267/comments","events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/issues/267/events","html_url":"https://github.com/alphagov/digitalmarketplace-api/pull/267","id":111358903,"number":267,"title":"Stop detecting frameworks (on service import)","user":{"login":"pcraig3","id":2454380,"avatar_url":"https://avatars.githubusercontent.com/u/2454380?v=3","gravatar_id":"","url":"https://api.github.com/users/pcraig3","html_url":"https://github.com/pcraig3","followers_url":"https://api.github.com/users/pcraig3/followers","following_url":"https://api.github.com/users/pcraig3/following{/other_user}","gists_url":"https://api.github.com/users/pcraig3/gists{/gist_id}","starred_url":"https://api.github.com/users/pcraig3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcraig3/subscriptions","organizations_url":"https://api.github.com/users/pcraig3/orgs","repos_url":"https://api.github.com/users/pcraig3/repos","events_url":"https://api.github.com/users/pcraig3/events{/privacy}","received_events_url":"https://api.github.com/users/pcraig3/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-14T09:31:23Z","updated_at":"2015-10-14T09:39:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/pulls/267","html_url":"https://github.com/alphagov/digitalmarketplace-api/pull/267","diff_url":"https://github.com/alphagov/digitalmarketplace-api/pull/267.diff","patch_url":"https://github.com/alphagov/digitalmarketplace-api/pull/267.patch"},"body":"Our import route was using some framework detection logic that we didn't need anymore, as services that are returned by the API have framework information included in their JSON content (set in the [`serialize()`](https://github.com/alphagov/digitalmarketplace-api/blob/master/app/models.py#L359) method for services).\r\n\r\n_ \r\n\r\nAs we're never creating a new service by directly importing them, we know that the import route only gets used to import services returned by the API.  So we can use the existing `validate_service` method to validate the service based on the correct schema, and now that's what we do."},"comment":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/issues/comments/147991111","html_url":"https://github.com/alphagov/digitalmarketplace-api/pull/267#issuecomment-147991111","issue_url":"https://api.github.com/repos/alphagov/digitalmarketplace-api/issues/267","id":147991111,"user":{"login":"TheDoubleK","id":6525554,"avatar_url":"https://avatars.githubusercontent.com/u/6525554?v=3","gravatar_id":"","url":"https://api.github.com/users/TheDoubleK","html_url":"https://github.com/TheDoubleK","followers_url":"https://api.github.com/users/TheDoubleK/followers","following_url":"https://api.github.com/users/TheDoubleK/following{/other_user}","gists_url":"https://api.github.com/users/TheDoubleK/gists{/gist_id}","starred_url":"https://api.github.com/users/TheDoubleK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheDoubleK/subscriptions","organizations_url":"https://api.github.com/users/TheDoubleK/orgs","repos_url":"https://api.github.com/users/TheDoubleK/repos","events_url":"https://api.github.com/users/TheDoubleK/events{/privacy}","received_events_url":"https://api.github.com/users/TheDoubleK/received_events","type":"User","site_admin":false},"created_at":"2015-10-14T09:39:29Z","updated_at":"2015-10-14T09:39:29Z","body":":+1: "}}