{"action":"closed","issue":{"url":"https://api.github.com/repos/Yelp/mrjob/issues/1006","labels_url":"https://api.github.com/repos/Yelp/mrjob/issues/1006/labels{/name}","comments_url":"https://api.github.com/repos/Yelp/mrjob/issues/1006/comments","events_url":"https://api.github.com/repos/Yelp/mrjob/issues/1006/events","html_url":"https://github.com/Yelp/mrjob/issues/1006","id":71644162,"number":1006,"title":"check_circular=False when encoding JSON","user":{"login":"davidmarin","id":50076,"avatar_url":"https://avatars.githubusercontent.com/u/50076?v=3","gravatar_id":"","url":"https://api.github.com/users/davidmarin","html_url":"https://github.com/davidmarin","followers_url":"https://api.github.com/users/davidmarin/followers","following_url":"https://api.github.com/users/davidmarin/following{/other_user}","gists_url":"https://api.github.com/users/davidmarin/gists{/gist_id}","starred_url":"https://api.github.com/users/davidmarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidmarin/subscriptions","organizations_url":"https://api.github.com/users/davidmarin/orgs","repos_url":"https://api.github.com/users/davidmarin/repos","events_url":"https://api.github.com/users/davidmarin/events{/privacy}","received_events_url":"https://api.github.com/users/davidmarin/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Yelp/mrjob/labels/Feature","name":"Feature","color":"008500"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/Yelp/mrjob/milestones/14","html_url":"https://github.com/Yelp/mrjob/milestones/v0.5.0","labels_url":"https://api.github.com/repos/Yelp/mrjob/milestones/14/labels","id":370135,"number":14,"title":"v0.5.0","description":"Python 3 support, get rid of deprecated things.","creator":{"login":"davidmarin","id":50076,"avatar_url":"https://avatars.githubusercontent.com/u/50076?v=3","gravatar_id":"","url":"https://api.github.com/users/davidmarin","html_url":"https://github.com/davidmarin","followers_url":"https://api.github.com/users/davidmarin/followers","following_url":"https://api.github.com/users/davidmarin/following{/other_user}","gists_url":"https://api.github.com/users/davidmarin/gists{/gist_id}","starred_url":"https://api.github.com/users/davidmarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidmarin/subscriptions","organizations_url":"https://api.github.com/users/davidmarin/orgs","repos_url":"https://api.github.com/users/davidmarin/repos","events_url":"https://api.github.com/users/davidmarin/events{/privacy}","received_events_url":"https://api.github.com/users/davidmarin/received_events","type":"User","site_admin":false},"open_issues":25,"closed_issues":8,"state":"open","created_at":"2013-07-03T23:10:21Z","updated_at":"2015-06-02T16:49:18Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2015-04-28T16:53:28Z","updated_at":"2015-06-02T16:49:18Z","closed_at":"2015-06-02T16:49:18Z","body":"We should be able to squeeze out a little extra efficiency by passing `check_circular=False` to `json.dumps()`.\r\n\r\nWe should save this for when strict protocols are on by default; currently, a circular reference would just count as unencodable output (causing a counter to be incremented), whereas without the check, it would cause a stack overflow.\r\n\r\nShould of course do some timing tests and see how much this matters."}}