{"action":"created","comment":{"url":"https://api.github.com/repos/trntv/probe/pulls/comments/29960163","id":29960163,"diff_hunk":"@@ -9,6 +9,7 @@\n abstract class AbstractUnixProvider extends AbstractProvider\n {\n     protected $cpuInfo;\n+\tprotected $cpuInfoByLsCpu;","path":"src/provider/AbstractUnixProvider.php","position":4,"original_position":4,"commit_id":"31861df63e005bdfc53e2248c694ce41fedf2090","original_commit_id":"31861df63e005bdfc53e2248c694ce41fedf2090","user":{"login":"TechKat","id":6548963,"avatar_url":"https://avatars.githubusercontent.com/u/6548963?v=3","gravatar_id":"","url":"https://api.github.com/users/TechKat","html_url":"https://github.com/TechKat","followers_url":"https://api.github.com/users/TechKat/followers","following_url":"https://api.github.com/users/TechKat/following{/other_user}","gists_url":"https://api.github.com/users/TechKat/gists{/gist_id}","starred_url":"https://api.github.com/users/TechKat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechKat/subscriptions","organizations_url":"https://api.github.com/users/TechKat/orgs","repos_url":"https://api.github.com/users/TechKat/repos","events_url":"https://api.github.com/users/TechKat/events{/privacy}","received_events_url":"https://api.github.com/users/TechKat/received_events","type":"User","site_admin":false},"body":"I could ask the same question about `cpuInfo`. Why is that in `AbstractUnixProvider` when corresponding methods are also in `LinuxProvider`?","created_at":"2015-05-08T17:43:36Z","updated_at":"2015-05-08T17:43:36Z","html_url":"https://github.com/trntv/probe/pull/4#discussion_r29960163","pull_request_url":"https://api.github.com/repos/trntv/probe/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/trntv/probe/pulls/comments/29960163"},"html":{"href":"https://github.com/trntv/probe/pull/4#discussion_r29960163"},"pull_request":{"href":"https://api.github.com/repos/trntv/probe/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/trntv/probe/pulls/4","id":35005781,"html_url":"https://github.com/trntv/probe/pull/4","diff_url":"https://github.com/trntv/probe/pull/4.diff","patch_url":"https://github.com/trntv/probe/pull/4.patch","issue_url":"https://api.github.com/repos/trntv/probe/issues/4","number":4,"state":"open","locked":false,"title":"Count physical CPUs by socket","user":{"login":"TechKat","id":6548963,"avatar_url":"https://avatars.githubusercontent.com/u/6548963?v=3","gravatar_id":"","url":"https://api.github.com/users/TechKat","html_url":"https://github.com/TechKat","followers_url":"https://api.github.com/users/TechKat/followers","following_url":"https://api.github.com/users/TechKat/following{/other_user}","gists_url":"https://api.github.com/users/TechKat/gists{/gist_id}","starred_url":"https://api.github.com/users/TechKat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechKat/subscriptions","organizations_url":"https://api.github.com/users/TechKat/orgs","repos_url":"https://api.github.com/users/TechKat/repos","events_url":"https://api.github.com/users/TechKat/events{/privacy}","received_events_url":"https://api.github.com/users/TechKat/received_events","type":"User","site_admin":false},"body":"Some servers have more than 1 CPU. Probe only counts the cores for 1\r\nCPU.\r\n\r\nThis update counts each socket, with the use of lscpu command, and also\r\ncounts cores per socket.","created_at":"2015-05-08T12:50:38Z","updated_at":"2015-05-08T17:43:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9fe30123e70a8079715d365a7c5032d831fcdc88","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/trntv/probe/pulls/4/commits","review_comments_url":"https://api.github.com/repos/trntv/probe/pulls/4/comments","review_comment_url":"https://api.github.com/repos/trntv/probe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/trntv/probe/issues/4/comments","statuses_url":"https://api.github.com/repos/trntv/probe/statuses/31861df63e005bdfc53e2248c694ce41fedf2090","head":{"label":"TechKat:master","ref":"master","sha":"31861df63e005bdfc53e2248c694ce41fedf2090","user":{"login":"TechKat","id":6548963,"avatar_url":"https://avatars.githubusercontent.com/u/6548963?v=3","gravatar_id":"","url":"https://api.github.com/users/TechKat","html_url":"https://github.com/TechKat","followers_url":"https://api.github.com/users/TechKat/followers","following_url":"https://api.github.com/users/TechKat/following{/other_user}","gists_url":"https://api.github.com/users/TechKat/gists{/gist_id}","starred_url":"https://api.github.com/users/TechKat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechKat/subscriptions","organizations_url":"https://api.github.com/users/TechKat/orgs","repos_url":"https://api.github.com/users/TechKat/repos","events_url":"https://api.github.com/users/TechKat/events{/privacy}","received_events_url":"https://api.github.com/users/TechKat/received_events","type":"User","site_admin":false},"repo":{"id":35278577,"name":"probe","full_name":"TechKat/probe","owner":{"login":"TechKat","id":6548963,"avatar_url":"https://avatars.githubusercontent.com/u/6548963?v=3","gravatar_id":"","url":"https://api.github.com/users/TechKat","html_url":"https://github.com/TechKat","followers_url":"https://api.github.com/users/TechKat/followers","following_url":"https://api.github.com/users/TechKat/following{/other_user}","gists_url":"https://api.github.com/users/TechKat/gists{/gist_id}","starred_url":"https://api.github.com/users/TechKat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechKat/subscriptions","organizations_url":"https://api.github.com/users/TechKat/orgs","repos_url":"https://api.github.com/users/TechKat/repos","events_url":"https://api.github.com/users/TechKat/events{/privacy}","received_events_url":"https://api.github.com/users/TechKat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TechKat/probe","description":"PHP System Information Provider","fork":true,"url":"https://api.github.com/repos/TechKat/probe","forks_url":"https://api.github.com/repos/TechKat/probe/forks","keys_url":"https://api.github.com/repos/TechKat/probe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TechKat/probe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TechKat/probe/teams","hooks_url":"https://api.github.com/repos/TechKat/probe/hooks","issue_events_url":"https://api.github.com/repos/TechKat/probe/issues/events{/number}","events_url":"https://api.github.com/repos/TechKat/probe/events","assignees_url":"https://api.github.com/repos/TechKat/probe/assignees{/user}","branches_url":"https://api.github.com/repos/TechKat/probe/branches{/branch}","tags_url":"https://api.github.com/repos/TechKat/probe/tags","blobs_url":"https://api.github.com/repos/TechKat/probe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TechKat/probe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TechKat/probe/git/refs{/sha}","trees_url":"https://api.github.com/repos/TechKat/probe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TechKat/probe/statuses/{sha}","languages_url":"https://api.github.com/repos/TechKat/probe/languages","stargazers_url":"https://api.github.com/repos/TechKat/probe/stargazers","contributors_url":"https://api.github.com/repos/TechKat/probe/contributors","subscribers_url":"https://api.github.com/repos/TechKat/probe/subscribers","subscription_url":"https://api.github.com/repos/TechKat/probe/subscription","commits_url":"https://api.github.com/repos/TechKat/probe/commits{/sha}","git_commits_url":"https://api.github.com/repos/TechKat/probe/git/commits{/sha}","comments_url":"https://api.github.com/repos/TechKat/probe/comments{/number}","issue_comment_url":"https://api.github.com/repos/TechKat/probe/issues/comments{/number}","contents_url":"https://api.github.com/repos/TechKat/probe/contents/{+path}","compare_url":"https://api.github.com/repos/TechKat/probe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TechKat/probe/merges","archive_url":"https://api.github.com/repos/TechKat/probe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TechKat/probe/downloads","issues_url":"https://api.github.com/repos/TechKat/probe/issues{/number}","pulls_url":"https://api.github.com/repos/TechKat/probe/pulls{/number}","milestones_url":"https://api.github.com/repos/TechKat/probe/milestones{/number}","notifications_url":"https://api.github.com/repos/TechKat/probe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TechKat/probe/labels{/name}","releases_url":"https://api.github.com/repos/TechKat/probe/releases{/id}","created_at":"2015-05-08T12:40:39Z","updated_at":"2015-05-08T13:00:43Z","pushed_at":"2015-05-08T13:00:43Z","git_url":"git://github.com/TechKat/probe.git","ssh_url":"git@github.com:TechKat/probe.git","clone_url":"https://github.com/TechKat/probe.git","svn_url":"https://github.com/TechKat/probe","homepage":"","size":161,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"trntv:master","ref":"master","sha":"e2e55206a488905a5bb8752cfb9be8ff2f65377c","user":{"login":"trntv","id":1162056,"avatar_url":"https://avatars.githubusercontent.com/u/1162056?v=3","gravatar_id":"","url":"https://api.github.com/users/trntv","html_url":"https://github.com/trntv","followers_url":"https://api.github.com/users/trntv/followers","following_url":"https://api.github.com/users/trntv/following{/other_user}","gists_url":"https://api.github.com/users/trntv/gists{/gist_id}","starred_url":"https://api.github.com/users/trntv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trntv/subscriptions","organizations_url":"https://api.github.com/users/trntv/orgs","repos_url":"https://api.github.com/users/trntv/repos","events_url":"https://api.github.com/users/trntv/events{/privacy}","received_events_url":"https://api.github.com/users/trntv/received_events","type":"User","site_admin":false},"repo":{"id":31515036,"name":"probe","full_name":"trntv/probe","owner":{"login":"trntv","id":1162056,"avatar_url":"https://avatars.githubusercontent.com/u/1162056?v=3","gravatar_id":"","url":"https://api.github.com/users/trntv","html_url":"https://github.com/trntv","followers_url":"https://api.github.com/users/trntv/followers","following_url":"https://api.github.com/users/trntv/following{/other_user}","gists_url":"https://api.github.com/users/trntv/gists{/gist_id}","starred_url":"https://api.github.com/users/trntv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trntv/subscriptions","organizations_url":"https://api.github.com/users/trntv/orgs","repos_url":"https://api.github.com/users/trntv/repos","events_url":"https://api.github.com/users/trntv/events{/privacy}","received_events_url":"https://api.github.com/users/trntv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trntv/probe","description":"PHP System Information Provider","fork":false,"url":"https://api.github.com/repos/trntv/probe","forks_url":"https://api.github.com/repos/trntv/probe/forks","keys_url":"https://api.github.com/repos/trntv/probe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trntv/probe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trntv/probe/teams","hooks_url":"https://api.github.com/repos/trntv/probe/hooks","issue_events_url":"https://api.github.com/repos/trntv/probe/issues/events{/number}","events_url":"https://api.github.com/repos/trntv/probe/events","assignees_url":"https://api.github.com/repos/trntv/probe/assignees{/user}","branches_url":"https://api.github.com/repos/trntv/probe/branches{/branch}","tags_url":"https://api.github.com/repos/trntv/probe/tags","blobs_url":"https://api.github.com/repos/trntv/probe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trntv/probe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trntv/probe/git/refs{/sha}","trees_url":"https://api.github.com/repos/trntv/probe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trntv/probe/statuses/{sha}","languages_url":"https://api.github.com/repos/trntv/probe/languages","stargazers_url":"https://api.github.com/repos/trntv/probe/stargazers","contributors_url":"https://api.github.com/repos/trntv/probe/contributors","subscribers_url":"https://api.github.com/repos/trntv/probe/subscribers","subscription_url":"https://api.github.com/repos/trntv/probe/subscription","commits_url":"https://api.github.com/repos/trntv/probe/commits{/sha}","git_commits_url":"https://api.github.com/repos/trntv/probe/git/commits{/sha}","comments_url":"https://api.github.com/repos/trntv/probe/comments{/number}","issue_comment_url":"https://api.github.com/repos/trntv/probe/issues/comments{/number}","contents_url":"https://api.github.com/repos/trntv/probe/contents/{+path}","compare_url":"https://api.github.com/repos/trntv/probe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trntv/probe/merges","archive_url":"https://api.github.com/repos/trntv/probe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trntv/probe/downloads","issues_url":"https://api.github.com/repos/trntv/probe/issues{/number}","pulls_url":"https://api.github.com/repos/trntv/probe/pulls{/number}","milestones_url":"https://api.github.com/repos/trntv/probe/milestones{/number}","notifications_url":"https://api.github.com/repos/trntv/probe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trntv/probe/labels{/name}","releases_url":"https://api.github.com/repos/trntv/probe/releases{/id}","created_at":"2015-03-01T23:27:33Z","updated_at":"2015-05-07T18:22:09Z","pushed_at":"2015-05-08T13:00:44Z","git_url":"git://github.com/trntv/probe.git","ssh_url":"git@github.com:trntv/probe.git","clone_url":"https://github.com/trntv/probe.git","svn_url":"https://github.com/trntv/probe","homepage":"","size":161,"stargazers_count":4,"watchers_count":4,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/trntv/probe/pulls/4"},"html":{"href":"https://github.com/trntv/probe/pull/4"},"issue":{"href":"https://api.github.com/repos/trntv/probe/issues/4"},"comments":{"href":"https://api.github.com/repos/trntv/probe/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/trntv/probe/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/trntv/probe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/trntv/probe/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/trntv/probe/statuses/31861df63e005bdfc53e2248c694ce41fedf2090"}}}}