{"action":"created","comment":{"url":"https://api.github.com/repos/OfficeDev/ews-java-api/pulls/comments/31418752","id":31418752,"diff_hunk":"@@ -193,8 +200,32 @@ private void initializeHttpClient() {\n       .build();\n   }\n \n+  private void initializeHttpPoolingClient() {\n+\t    Registry<ConnectionSocketFactory> registry = createConnectionSocketFactoryRegistry();\n+\t    PoolingHttpClientConnectionManager httpConnectionManager = new PoolingHttpClientConnectionManager(registry);\n+\t    httpConnectionManager.setMaxTotal(maximumPoolingConnections);\n+\t    httpConnectionManager.setDefaultMaxPerRoute(maximumPoolingConnections);\n+\t    AuthenticationStrategy authStrategy = new CookieProcessingTargetAuthenticationStrategy();\n+\n+\t    httpPoolingClient = HttpClients.custom()\n+\t      .setConnectionManager(httpConnectionManager)\n+\t      .setTargetAuthenticationStrategy(authStrategy)\n+\t      .build();\n+\t  }\n+  \n+  \n   /**\n-   * Create registry with configured {@link ConnectionSocketFactory} instances.\n+   * Sets the maximum number of connections for the pooling connection manager which is used for subscriptions.\n+   * <p>\n+   * Default is 10.\n+   * @param maximumPoolConnections\n+   */\n+  public void setMaximumPoolingConnections(int maximumPoolingConnections) {\n+    this.maximumPoolingConnections = maximumPoolingConnections;","path":"src/main/java/microsoft/exchange/webservices/data/core/ExchangeServiceBase.java","position":56,"original_position":56,"commit_id":"6faa53da2b17304fa87c808fb941e7ca2d7dad96","original_commit_id":"6faa53da2b17304fa87c808fb941e7ca2d7dad96","user":{"login":"serious6","id":3902037,"avatar_url":"https://avatars.githubusercontent.com/u/3902037?v=3","gravatar_id":"","url":"https://api.github.com/users/serious6","html_url":"https://github.com/serious6","followers_url":"https://api.github.com/users/serious6/followers","following_url":"https://api.github.com/users/serious6/following{/other_user}","gists_url":"https://api.github.com/users/serious6/gists{/gist_id}","starred_url":"https://api.github.com/users/serious6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serious6/subscriptions","organizations_url":"https://api.github.com/users/serious6/orgs","repos_url":"https://api.github.com/users/serious6/repos","events_url":"https://api.github.com/users/serious6/events{/privacy}","received_events_url":"https://api.github.com/users/serious6/received_events","type":"User","site_admin":false},"body":"maybe it might be usefull to include a check if the `maximumPoolingConnections` is >= 1 and throw an illegalArgument Exception if its not","created_at":"2015-06-01T11:57:00Z","updated_at":"2015-06-01T11:57:00Z","html_url":"https://github.com/OfficeDev/ews-java-api/pull/336#discussion_r31418752","pull_request_url":"https://api.github.com/repos/OfficeDev/ews-java-api/pulls/336","_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/ews-java-api/pulls/comments/31418752"},"html":{"href":"https://github.com/OfficeDev/ews-java-api/pull/336#discussion_r31418752"},"pull_request":{"href":"https://api.github.com/repos/OfficeDev/ews-java-api/pulls/336"}}},"pull_request":{"url":"https://api.github.com/repos/OfficeDev/ews-java-api/pulls/336","id":36583212,"html_url":"https://github.com/OfficeDev/ews-java-api/pull/336","diff_url":"https://github.com/OfficeDev/ews-java-api/pull/336.diff","patch_url":"https://github.com/OfficeDev/ews-java-api/pull/336.patch","issue_url":"https://api.github.com/repos/OfficeDev/ews-java-api/issues/336","number":336,"state":"open","locked":false,"title":"Fix for Issue #276 Streaming subscription throws connection error","user":{"login":"avromf","id":5580005,"avatar_url":"https://avatars.githubusercontent.com/u/5580005?v=3","gravatar_id":"","url":"https://api.github.com/users/avromf","html_url":"https://github.com/avromf","followers_url":"https://api.github.com/users/avromf/followers","following_url":"https://api.github.com/users/avromf/following{/other_user}","gists_url":"https://api.github.com/users/avromf/gists{/gist_id}","starred_url":"https://api.github.com/users/avromf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avromf/subscriptions","organizations_url":"https://api.github.com/users/avromf/orgs","repos_url":"https://api.github.com/users/avromf/repos","events_url":"https://api.github.com/users/avromf/events{/privacy}","received_events_url":"https://api.github.com/users/avromf/received_events","type":"User","site_admin":false},"body":"Fixes issues with subscriptions (e.g. streaming) and now uses a PoolingHttpClientConnectionManager instead of BasicHttpClientConnectionManager.\r\nSpecifically, it will create a separate PoolingHttpClientConnectionManager for subscriptions while still retaining the BasicHttpClientConnectionManager for all other connections.\r\n\r\nNew pull request of #297 ","created_at":"2015-05-31T14:38:30Z","updated_at":"2015-06-01T11:57:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e96f501a520cd26e0bd3df9d7b5f13a9565667a0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OfficeDev/ews-java-api/pulls/336/commits","review_comments_url":"https://api.github.com/repos/OfficeDev/ews-java-api/pulls/336/comments","review_comment_url":"https://api.github.com/repos/OfficeDev/ews-java-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OfficeDev/ews-java-api/issues/336/comments","statuses_url":"https://api.github.com/repos/OfficeDev/ews-java-api/statuses/6faa53da2b17304fa87c808fb941e7ca2d7dad96","head":{"label":"avromf:Issue276","ref":"Issue276","sha":"6faa53da2b17304fa87c808fb941e7ca2d7dad96","user":{"login":"avromf","id":5580005,"avatar_url":"https://avatars.githubusercontent.com/u/5580005?v=3","gravatar_id":"","url":"https://api.github.com/users/avromf","html_url":"https://github.com/avromf","followers_url":"https://api.github.com/users/avromf/followers","following_url":"https://api.github.com/users/avromf/following{/other_user}","gists_url":"https://api.github.com/users/avromf/gists{/gist_id}","starred_url":"https://api.github.com/users/avromf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avromf/subscriptions","organizations_url":"https://api.github.com/users/avromf/orgs","repos_url":"https://api.github.com/users/avromf/repos","events_url":"https://api.github.com/users/avromf/events{/privacy}","received_events_url":"https://api.github.com/users/avromf/received_events","type":"User","site_admin":false},"repo":{"id":23885665,"name":"ews-java-api","full_name":"avromf/ews-java-api","owner":{"login":"avromf","id":5580005,"avatar_url":"https://avatars.githubusercontent.com/u/5580005?v=3","gravatar_id":"","url":"https://api.github.com/users/avromf","html_url":"https://github.com/avromf","followers_url":"https://api.github.com/users/avromf/followers","following_url":"https://api.github.com/users/avromf/following{/other_user}","gists_url":"https://api.github.com/users/avromf/gists{/gist_id}","starred_url":"https://api.github.com/users/avromf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avromf/subscriptions","organizations_url":"https://api.github.com/users/avromf/orgs","repos_url":"https://api.github.com/users/avromf/repos","events_url":"https://api.github.com/users/avromf/events{/privacy}","received_events_url":"https://api.github.com/users/avromf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/avromf/ews-java-api","description":"A java client library to access Exchange web services.  The API works against Office 365 Exchange Online as well as on premises Exchange.","fork":true,"url":"https://api.github.com/repos/avromf/ews-java-api","forks_url":"https://api.github.com/repos/avromf/ews-java-api/forks","keys_url":"https://api.github.com/repos/avromf/ews-java-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/avromf/ews-java-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/avromf/ews-java-api/teams","hooks_url":"https://api.github.com/repos/avromf/ews-java-api/hooks","issue_events_url":"https://api.github.com/repos/avromf/ews-java-api/issues/events{/number}","events_url":"https://api.github.com/repos/avromf/ews-java-api/events","assignees_url":"https://api.github.com/repos/avromf/ews-java-api/assignees{/user}","branches_url":"https://api.github.com/repos/avromf/ews-java-api/branches{/branch}","tags_url":"https://api.github.com/repos/avromf/ews-java-api/tags","blobs_url":"https://api.github.com/repos/avromf/ews-java-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/avromf/ews-java-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/avromf/ews-java-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/avromf/ews-java-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/avromf/ews-java-api/statuses/{sha}","languages_url":"https://api.github.com/repos/avromf/ews-java-api/languages","stargazers_url":"https://api.github.com/repos/avromf/ews-java-api/stargazers","contributors_url":"https://api.github.com/repos/avromf/ews-java-api/contributors","subscribers_url":"https://api.github.com/repos/avromf/ews-java-api/subscribers","subscription_url":"https://api.github.com/repos/avromf/ews-java-api/subscription","commits_url":"https://api.github.com/repos/avromf/ews-java-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/avromf/ews-java-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/avromf/ews-java-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/avromf/ews-java-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/avromf/ews-java-api/contents/{+path}","compare_url":"https://api.github.com/repos/avromf/ews-java-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/avromf/ews-java-api/merges","archive_url":"https://api.github.com/repos/avromf/ews-java-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/avromf/ews-java-api/downloads","issues_url":"https://api.github.com/repos/avromf/ews-java-api/issues{/number}","pulls_url":"https://api.github.com/repos/avromf/ews-java-api/pulls{/number}","milestones_url":"https://api.github.com/repos/avromf/ews-java-api/milestones{/number}","notifications_url":"https://api.github.com/repos/avromf/ews-java-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/avromf/ews-java-api/labels{/name}","releases_url":"https://api.github.com/repos/avromf/ews-java-api/releases{/id}","created_at":"2014-09-10T18:02:11Z","updated_at":"2015-04-16T18:46:22Z","pushed_at":"2015-05-31T14:31:00Z","git_url":"git://github.com/avromf/ews-java-api.git","ssh_url":"git@github.com:avromf/ews-java-api.git","clone_url":"https://github.com/avromf/ews-java-api.git","svn_url":"https://github.com/avromf/ews-java-api","homepage":"","size":6511,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OfficeDev:master","ref":"master","sha":"c88387e2a2961dba504db5b921fc835a5da6db9c","user":{"login":"OfficeDev","id":6789362,"avatar_url":"https://avatars.githubusercontent.com/u/6789362?v=3","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"repo":{"id":23322482,"name":"ews-java-api","full_name":"OfficeDev/ews-java-api","owner":{"login":"OfficeDev","id":6789362,"avatar_url":"https://avatars.githubusercontent.com/u/6789362?v=3","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OfficeDev/ews-java-api","description":"A java client library to access Exchange web services.  The API works against Office 365 Exchange Online as well as on premises Exchange.","fork":false,"url":"https://api.github.com/repos/OfficeDev/ews-java-api","forks_url":"https://api.github.com/repos/OfficeDev/ews-java-api/forks","keys_url":"https://api.github.com/repos/OfficeDev/ews-java-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OfficeDev/ews-java-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OfficeDev/ews-java-api/teams","hooks_url":"https://api.github.com/repos/OfficeDev/ews-java-api/hooks","issue_events_url":"https://api.github.com/repos/OfficeDev/ews-java-api/issues/events{/number}","events_url":"https://api.github.com/repos/OfficeDev/ews-java-api/events","assignees_url":"https://api.github.com/repos/OfficeDev/ews-java-api/assignees{/user}","branches_url":"https://api.github.com/repos/OfficeDev/ews-java-api/branches{/branch}","tags_url":"https://api.github.com/repos/OfficeDev/ews-java-api/tags","blobs_url":"https://api.github.com/repos/OfficeDev/ews-java-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OfficeDev/ews-java-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OfficeDev/ews-java-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/OfficeDev/ews-java-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OfficeDev/ews-java-api/statuses/{sha}","languages_url":"https://api.github.com/repos/OfficeDev/ews-java-api/languages","stargazers_url":"https://api.github.com/repos/OfficeDev/ews-java-api/stargazers","contributors_url":"https://api.github.com/repos/OfficeDev/ews-java-api/contributors","subscribers_url":"https://api.github.com/repos/OfficeDev/ews-java-api/subscribers","subscription_url":"https://api.github.com/repos/OfficeDev/ews-java-api/subscription","commits_url":"https://api.github.com/repos/OfficeDev/ews-java-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/OfficeDev/ews-java-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/OfficeDev/ews-java-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/OfficeDev/ews-java-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/OfficeDev/ews-java-api/contents/{+path}","compare_url":"https://api.github.com/repos/OfficeDev/ews-java-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OfficeDev/ews-java-api/merges","archive_url":"https://api.github.com/repos/OfficeDev/ews-java-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OfficeDev/ews-java-api/downloads","issues_url":"https://api.github.com/repos/OfficeDev/ews-java-api/issues{/number}","pulls_url":"https://api.github.com/repos/OfficeDev/ews-java-api/pulls{/number}","milestones_url":"https://api.github.com/repos/OfficeDev/ews-java-api/milestones{/number}","notifications_url":"https://api.github.com/repos/OfficeDev/ews-java-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OfficeDev/ews-java-api/labels{/name}","releases_url":"https://api.github.com/repos/OfficeDev/ews-java-api/releases{/id}","created_at":"2014-08-25T17:33:09Z","updated_at":"2015-05-29T20:44:40Z","pushed_at":"2015-06-01T09:28:50Z","git_url":"git://github.com/OfficeDev/ews-java-api.git","ssh_url":"git@github.com:OfficeDev/ews-java-api.git","clone_url":"https://github.com/OfficeDev/ews-java-api.git","svn_url":"https://github.com/OfficeDev/ews-java-api","homepage":"","size":12858,"stargazers_count":171,"watchers_count":171,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":140,"mirror_url":null,"open_issues_count":80,"forks":140,"open_issues":80,"watchers":171,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/ews-java-api/pulls/336"},"html":{"href":"https://github.com/OfficeDev/ews-java-api/pull/336"},"issue":{"href":"https://api.github.com/repos/OfficeDev/ews-java-api/issues/336"},"comments":{"href":"https://api.github.com/repos/OfficeDev/ews-java-api/issues/336/comments"},"review_comments":{"href":"https://api.github.com/repos/OfficeDev/ews-java-api/pulls/336/comments"},"review_comment":{"href":"https://api.github.com/repos/OfficeDev/ews-java-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OfficeDev/ews-java-api/pulls/336/commits"},"statuses":{"href":"https://api.github.com/repos/OfficeDev/ews-java-api/statuses/6faa53da2b17304fa87c808fb941e7ca2d7dad96"}}}}