{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/40459266","id":40459266,"diff_hunk":"@@ -165,11 +165,13 @@ def assert_specific_flavor\n       ManageIQ::Providers::Openstack::CloudManager::Flavor.all.each do |flavor|\n         expect(flavor.ext_management_system).to eq @ems\n         # TODO(lsmola) expose below to Builder's data\n-        expect(flavor.enabled).to               eq true\n-        expect(flavor.cpu_cores).to             eq nil\n-        expect(flavor.description).to           eq nil\n-        expect(flavor.disk_size).to_not         be_nil\n-        expect(flavor.disk_count).to            eq flavor.disk_size == 0 ? 0 : 1\n+        expect(flavor.enabled).to                 eq true\n+        expect(flavor.cpu_cores).to               eq nil\n+        expect(flavor.description).to             eq nil\n+        expect(flavor.root_disk_size).to_not      be_nil\n+        expect(flavor.swap_disk_size).to_not      be_nil\n+        expect(flavor.ephemeral_disk_size).to_not be_nil","path":"spec/models/ems_refresh/refreshers/openstack/refresh_spec_common.rb","position":14,"original_position":14,"commit_id":"00771fc3df5c0ab508c8c679e522698564b05c89","original_commit_id":"00771fc3df5c0ab508c8c679e522698564b05c89","user":{"login":"jvlcek","id":729572,"avatar_url":"https://avatars.githubusercontent.com/u/729572?v=3","gravatar_id":"","url":"https://api.github.com/users/jvlcek","html_url":"https://github.com/jvlcek","followers_url":"https://api.github.com/users/jvlcek/followers","following_url":"https://api.github.com/users/jvlcek/following{/other_user}","gists_url":"https://api.github.com/users/jvlcek/gists{/gist_id}","starred_url":"https://api.github.com/users/jvlcek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvlcek/subscriptions","organizations_url":"https://api.github.com/users/jvlcek/orgs","repos_url":"https://api.github.com/users/jvlcek/repos","events_url":"https://api.github.com/users/jvlcek/events{/privacy}","received_events_url":"https://api.github.com/users/jvlcek/received_events","type":"User","site_admin":false},"body":"@Fryguy OK","created_at":"2015-09-25T18:14:07Z","updated_at":"2015-09-25T18:14:07Z","html_url":"https://github.com/ManageIQ/manageiq/pull/4525#discussion_r40459266","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4525","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/40459266"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/4525#discussion_r40459266"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4525"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4525","id":45951984,"html_url":"https://github.com/ManageIQ/manageiq/pull/4525","diff_url":"https://github.com/ManageIQ/manageiq/pull/4525.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/4525.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4525","number":4525,"state":"open","locked":false,"title":"Collect cloud provider flavor disk data","user":{"login":"jvlcek","id":729572,"avatar_url":"https://avatars.githubusercontent.com/u/729572?v=3","gravatar_id":"","url":"https://api.github.com/users/jvlcek","html_url":"https://github.com/jvlcek","followers_url":"https://api.github.com/users/jvlcek/followers","following_url":"https://api.github.com/users/jvlcek/following{/other_user}","gists_url":"https://api.github.com/users/jvlcek/gists{/gist_id}","starred_url":"https://api.github.com/users/jvlcek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvlcek/subscriptions","organizations_url":"https://api.github.com/users/jvlcek/orgs","repos_url":"https://api.github.com/users/jvlcek/repos","events_url":"https://api.github.com/users/jvlcek/events{/privacy}","received_events_url":"https://api.github.com/users/jvlcek/received_events","type":"User","site_admin":false},"body":"This PR will populate the appropriate DB column for flavor disk information\r\nas described in the below table by Cloud Provider\r\n\r\n(Azure uses the term to *Series* for *Flavor*)\r\n\r\nMiQ DB column             |    Amazon                            | OpenStack               | Azure\r\n--------------------------------|--------------------------------------|----------------------------|-----------------------\r\nroot_disk_size                | NA                                       | disk                           | OS disk \r\nswap_disk_size              | NA                                        | swap                        | swap\r\nephemeral_disk_size     | instance_store_size             | ephemeral               | NA\r\nephemeral_disk_count   | instance_store_volumes     | 1 if ephemeral > 0    | NA\r\n\r\n\r\n\r\nFixes #4427 \r\n\r\n","created_at":"2015-09-24T21:25:42Z","updated_at":"2015-09-25T18:14:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b20e9ac84b47f3ed752ace8db5e43e87cf8d186f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4525/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4525/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4525/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/00771fc3df5c0ab508c8c679e522698564b05c89","head":{"label":"jvlcek:issue_4427_cloud_provider_disk_info","ref":"issue_4427_cloud_provider_disk_info","sha":"00771fc3df5c0ab508c8c679e522698564b05c89","user":{"login":"jvlcek","id":729572,"avatar_url":"https://avatars.githubusercontent.com/u/729572?v=3","gravatar_id":"","url":"https://api.github.com/users/jvlcek","html_url":"https://github.com/jvlcek","followers_url":"https://api.github.com/users/jvlcek/followers","following_url":"https://api.github.com/users/jvlcek/following{/other_user}","gists_url":"https://api.github.com/users/jvlcek/gists{/gist_id}","starred_url":"https://api.github.com/users/jvlcek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvlcek/subscriptions","organizations_url":"https://api.github.com/users/jvlcek/orgs","repos_url":"https://api.github.com/users/jvlcek/repos","events_url":"https://api.github.com/users/jvlcek/events{/privacy}","received_events_url":"https://api.github.com/users/jvlcek/received_events","type":"User","site_admin":false},"repo":{"id":20890511,"name":"manageiq","full_name":"jvlcek/manageiq","owner":{"login":"jvlcek","id":729572,"avatar_url":"https://avatars.githubusercontent.com/u/729572?v=3","gravatar_id":"","url":"https://api.github.com/users/jvlcek","html_url":"https://github.com/jvlcek","followers_url":"https://api.github.com/users/jvlcek/followers","following_url":"https://api.github.com/users/jvlcek/following{/other_user}","gists_url":"https://api.github.com/users/jvlcek/gists{/gist_id}","starred_url":"https://api.github.com/users/jvlcek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvlcek/subscriptions","organizations_url":"https://api.github.com/users/jvlcek/orgs","repos_url":"https://api.github.com/users/jvlcek/repos","events_url":"https://api.github.com/users/jvlcek/events{/privacy}","received_events_url":"https://api.github.com/users/jvlcek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jvlcek/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/jvlcek/manageiq","forks_url":"https://api.github.com/repos/jvlcek/manageiq/forks","keys_url":"https://api.github.com/repos/jvlcek/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jvlcek/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jvlcek/manageiq/teams","hooks_url":"https://api.github.com/repos/jvlcek/manageiq/hooks","issue_events_url":"https://api.github.com/repos/jvlcek/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/jvlcek/manageiq/events","assignees_url":"https://api.github.com/repos/jvlcek/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/jvlcek/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/jvlcek/manageiq/tags","blobs_url":"https://api.github.com/repos/jvlcek/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jvlcek/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jvlcek/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/jvlcek/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jvlcek/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/jvlcek/manageiq/languages","stargazers_url":"https://api.github.com/repos/jvlcek/manageiq/stargazers","contributors_url":"https://api.github.com/repos/jvlcek/manageiq/contributors","subscribers_url":"https://api.github.com/repos/jvlcek/manageiq/subscribers","subscription_url":"https://api.github.com/repos/jvlcek/manageiq/subscription","commits_url":"https://api.github.com/repos/jvlcek/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/jvlcek/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/jvlcek/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/jvlcek/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/jvlcek/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/jvlcek/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jvlcek/manageiq/merges","archive_url":"https://api.github.com/repos/jvlcek/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jvlcek/manageiq/downloads","issues_url":"https://api.github.com/repos/jvlcek/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/jvlcek/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/jvlcek/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/jvlcek/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jvlcek/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/jvlcek/manageiq/releases{/id}","created_at":"2014-06-16T15:44:01Z","updated_at":"2015-04-23T15:03:22Z","pushed_at":"2015-09-24T21:20:25Z","git_url":"git://github.com/jvlcek/manageiq.git","ssh_url":"git@github.com:jvlcek/manageiq.git","clone_url":"https://github.com/jvlcek/manageiq.git","svn_url":"https://github.com/jvlcek/manageiq","homepage":null,"size":84577,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"783b4b461b58b09561389f0ec4100df7a98cc1a1","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-09-22T01:10:08Z","pushed_at":"2015-09-25T17:57:17Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":163814,"stargazers_count":152,"watchers_count":152,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":157,"mirror_url":null,"open_issues_count":418,"forks":157,"open_issues":418,"watchers":152,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4525"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/4525"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/4525"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/4525/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4525/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4525/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/00771fc3df5c0ab508c8c679e522698564b05c89"}}}}