{"action":"created","issue":{"url":"https://api.github.com/repos/paragonie/seedspring/issues/1","labels_url":"https://api.github.com/repos/paragonie/seedspring/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/paragonie/seedspring/issues/1/comments","events_url":"https://api.github.com/repos/paragonie/seedspring/issues/1/events","html_url":"https://github.com/paragonie/seedspring/pull/1","id":123606855,"number":1,"title":"fix static issue","user":{"login":"dbarr","id":1169249,"avatar_url":"https://avatars.githubusercontent.com/u/1169249?v=3","gravatar_id":"","url":"https://api.github.com/users/dbarr","html_url":"https://github.com/dbarr","followers_url":"https://api.github.com/users/dbarr/followers","following_url":"https://api.github.com/users/dbarr/following{/other_user}","gists_url":"https://api.github.com/users/dbarr/gists{/gist_id}","starred_url":"https://api.github.com/users/dbarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbarr/subscriptions","organizations_url":"https://api.github.com/users/dbarr/orgs","repos_url":"https://api.github.com/users/dbarr/repos","events_url":"https://api.github.com/users/dbarr/events{/privacy}","received_events_url":"https://api.github.com/users/dbarr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-12-23T06:01:15Z","updated_at":"2015-12-23T12:48:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/paragonie/seedspring/pulls/1","html_url":"https://github.com/paragonie/seedspring/pull/1","diff_url":"https://github.com/paragonie/seedspring/pull/1.diff","patch_url":"https://github.com/paragonie/seedspring/pull/1.patch"},"body":"This fixes an issue with using a static variable in a function.\r\n\r\nAlso, return $data; where $action was 'get' meant that the seed returned was always a blank string."},"comment":{"url":"https://api.github.com/repos/paragonie/seedspring/issues/comments/166888433","html_url":"https://github.com/paragonie/seedspring/pull/1#issuecomment-166888433","issue_url":"https://api.github.com/repos/paragonie/seedspring/issues/1","id":166888433,"user":{"login":"dbarr","id":1169249,"avatar_url":"https://avatars.githubusercontent.com/u/1169249?v=3","gravatar_id":"","url":"https://api.github.com/users/dbarr","html_url":"https://github.com/dbarr","followers_url":"https://api.github.com/users/dbarr/followers","following_url":"https://api.github.com/users/dbarr/following{/other_user}","gists_url":"https://api.github.com/users/dbarr/gists{/gist_id}","starred_url":"https://api.github.com/users/dbarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbarr/subscriptions","organizations_url":"https://api.github.com/users/dbarr/orgs","repos_url":"https://api.github.com/users/dbarr/repos","events_url":"https://api.github.com/users/dbarr/events{/privacy}","received_events_url":"https://api.github.com/users/dbarr/received_events","type":"User","site_admin":false},"created_at":"2015-12-23T12:48:06Z","updated_at":"2015-12-23T12:48:06Z","body":"Which is fine, except it means your class can only be used as a singleton.\nIs that the intent? Also what about the glaring bug in regards to returning\n$data when getting? (Which is always an empty string), or am I still\nmissing something?\n\nOn Wednesday, 23 December 2015, Scott <notifications@github.com> wrote:\n\n> I think you missed the entire purpose of this.\n>\n>\n> https://github.com/paragonie/seedspring/blob/2df8ae431ad2fc41a2e642081c3c686c2daac7df/src/SeedSpring.php#L15\n>\n> We're hiding this state so it can only be accessed by itself. Hiding it\n> means ensureing that it can't leak out in a stack trace or via xdebug.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/paragonie/seedspring/pull/1#issuecomment-166811482>.\n>\n"}}