{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/28670693","id":28670693,"diff_hunk":"@@ -24,12 +22,16 @@ def install\n       --with-libevent=#{Formula[\"libevent\"].opt_prefix}\n     ]\n \n-    args << '--enable-root-server' if build.with? 'root-server'\n-    args << '--enable-bind8-stats' if build.with? 'bind8-stats'\n-    args << '--enable-ratelimit' if build.with? 'ratelimit'\n-    args << '--enable-zone-stats' if build.with? 'zone-stats'\n+    args << \"--enable-root-server\" if build.with? \"root-server\"\n+    args << \"--enable-bind8-stats\" if build.with? \"bind8-stats\"\n+    args << \"--enable-ratelimit\" if build.with? \"ratelimit\"\n+    args << \"--enable-zone-stats\" if build.with? \"zone-stats\"\n \n     system \"./configure\", *args\n-    system \"make install\"\n+    system \"make\", \"install\"\n+  end\n+\n+  test do\n+    system \"#{sbin}/nsd\", \"-v\"","path":"Library/Formula/nsd.rb","position":50,"original_position":50,"commit_id":"584ccb8b88cf58283b0c93eef37d5749e4b0223e","original_commit_id":"584ccb8b88cf58283b0c93eef37d5749e4b0223e","user":{"login":"mikemcquaid","id":125011,"avatar_url":"https://avatars.githubusercontent.com/u/125011?v=3","gravatar_id":"","url":"https://api.github.com/users/mikemcquaid","html_url":"https://github.com/mikemcquaid","followers_url":"https://api.github.com/users/mikemcquaid/followers","following_url":"https://api.github.com/users/mikemcquaid/following{/other_user}","gists_url":"https://api.github.com/users/mikemcquaid/gists{/gist_id}","starred_url":"https://api.github.com/users/mikemcquaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikemcquaid/subscriptions","organizations_url":"https://api.github.com/users/mikemcquaid/orgs","repos_url":"https://api.github.com/users/mikemcquaid/repos","events_url":"https://api.github.com/users/mikemcquaid/events{/privacy}","received_events_url":"https://api.github.com/users/mikemcquaid/received_events","type":"User","site_admin":true},"body":"I'm not insisting; this test is a bit better than nothing but I just figured if you were doing cleanup you might be interested in doing an even better test. If you aren't: that's OK and I'll pull as-is.","created_at":"2015-04-20T08:23:37Z","updated_at":"2015-04-20T08:23:37Z","html_url":"https://github.com/Homebrew/homebrew/pull/38813#discussion_r28670693","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/38813","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/28670693"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/38813#discussion_r28670693"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/38813"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/38813","id":33616447,"html_url":"https://github.com/Homebrew/homebrew/pull/38813","diff_url":"https://github.com/Homebrew/homebrew/pull/38813.diff","patch_url":"https://github.com/Homebrew/homebrew/pull/38813.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew/issues/38813","number":38813,"state":"open","locked":false,"title":"nsd 4.1.2","user":{"login":"arhbkb","id":1058891,"avatar_url":"https://avatars.githubusercontent.com/u/1058891?v=3","gravatar_id":"","url":"https://api.github.com/users/arhbkb","html_url":"https://github.com/arhbkb","followers_url":"https://api.github.com/users/arhbkb/followers","following_url":"https://api.github.com/users/arhbkb/following{/other_user}","gists_url":"https://api.github.com/users/arhbkb/gists{/gist_id}","starred_url":"https://api.github.com/users/arhbkb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arhbkb/subscriptions","organizations_url":"https://api.github.com/users/arhbkb/orgs","repos_url":"https://api.github.com/users/arhbkb/repos","events_url":"https://api.github.com/users/arhbkb/events{/privacy}","received_events_url":"https://api.github.com/users/arhbkb/received_events","type":"User","site_admin":false},"body":"This PR updates nsd to version 4.1.2","created_at":"2015-04-19T10:07:53Z","updated_at":"2015-04-20T08:23:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"380fa2eaf8e88454ce9fa4a7cfba73331ed1bb67","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/38813/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/38813/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/issues/38813/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/584ccb8b88cf58283b0c93eef37d5749e4b0223e","head":{"label":"arhbkb:nsd412","ref":"nsd412","sha":"584ccb8b88cf58283b0c93eef37d5749e4b0223e","user":{"login":"arhbkb","id":1058891,"avatar_url":"https://avatars.githubusercontent.com/u/1058891?v=3","gravatar_id":"","url":"https://api.github.com/users/arhbkb","html_url":"https://github.com/arhbkb","followers_url":"https://api.github.com/users/arhbkb/followers","following_url":"https://api.github.com/users/arhbkb/following{/other_user}","gists_url":"https://api.github.com/users/arhbkb/gists{/gist_id}","starred_url":"https://api.github.com/users/arhbkb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arhbkb/subscriptions","organizations_url":"https://api.github.com/users/arhbkb/orgs","repos_url":"https://api.github.com/users/arhbkb/repos","events_url":"https://api.github.com/users/arhbkb/events{/privacy}","received_events_url":"https://api.github.com/users/arhbkb/received_events","type":"User","site_admin":false},"repo":{"id":15192577,"name":"homebrew","full_name":"arhbkb/homebrew","owner":{"login":"arhbkb","id":1058891,"avatar_url":"https://avatars.githubusercontent.com/u/1058891?v=3","gravatar_id":"","url":"https://api.github.com/users/arhbkb","html_url":"https://github.com/arhbkb","followers_url":"https://api.github.com/users/arhbkb/followers","following_url":"https://api.github.com/users/arhbkb/following{/other_user}","gists_url":"https://api.github.com/users/arhbkb/gists{/gist_id}","starred_url":"https://api.github.com/users/arhbkb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arhbkb/subscriptions","organizations_url":"https://api.github.com/users/arhbkb/orgs","repos_url":"https://api.github.com/users/arhbkb/repos","events_url":"https://api.github.com/users/arhbkb/events{/privacy}","received_events_url":"https://api.github.com/users/arhbkb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arhbkb/homebrew","description":"The missing package manager for OS X.","fork":true,"url":"https://api.github.com/repos/arhbkb/homebrew","forks_url":"https://api.github.com/repos/arhbkb/homebrew/forks","keys_url":"https://api.github.com/repos/arhbkb/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arhbkb/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arhbkb/homebrew/teams","hooks_url":"https://api.github.com/repos/arhbkb/homebrew/hooks","issue_events_url":"https://api.github.com/repos/arhbkb/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/arhbkb/homebrew/events","assignees_url":"https://api.github.com/repos/arhbkb/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/arhbkb/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/arhbkb/homebrew/tags","blobs_url":"https://api.github.com/repos/arhbkb/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arhbkb/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arhbkb/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/arhbkb/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arhbkb/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/arhbkb/homebrew/languages","stargazers_url":"https://api.github.com/repos/arhbkb/homebrew/stargazers","contributors_url":"https://api.github.com/repos/arhbkb/homebrew/contributors","subscribers_url":"https://api.github.com/repos/arhbkb/homebrew/subscribers","subscription_url":"https://api.github.com/repos/arhbkb/homebrew/subscription","commits_url":"https://api.github.com/repos/arhbkb/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/arhbkb/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/arhbkb/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/arhbkb/homebrew/issues/comments{/number}","contents_url":"https://api.github.com/repos/arhbkb/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/arhbkb/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arhbkb/homebrew/merges","archive_url":"https://api.github.com/repos/arhbkb/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arhbkb/homebrew/downloads","issues_url":"https://api.github.com/repos/arhbkb/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/arhbkb/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/arhbkb/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/arhbkb/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arhbkb/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/arhbkb/homebrew/releases{/id}","created_at":"2013-12-14T20:44:00Z","updated_at":"2015-04-19T09:50:07Z","pushed_at":"2015-04-19T16:24:13Z","git_url":"git://github.com/arhbkb/homebrew.git","ssh_url":"git@github.com:arhbkb/homebrew.git","clone_url":"https://github.com/arhbkb/homebrew.git","svn_url":"https://github.com/arhbkb/homebrew","homepage":"http://brew.sh","size":36954,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"8cab1ca4a9199ed11011a25905b314703d73a901","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":206084,"name":"homebrew","full_name":"Homebrew/homebrew","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew","description":"The missing package manager for OS X.","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew","forks_url":"https://api.github.com/repos/Homebrew/homebrew/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew/releases{/id}","created_at":"2009-05-20T19:38:37Z","updated_at":"2015-04-20T08:06:44Z","pushed_at":"2015-04-20T07:50:25Z","git_url":"git://github.com/Homebrew/homebrew.git","ssh_url":"git@github.com:Homebrew/homebrew.git","clone_url":"https://github.com/Homebrew/homebrew.git","svn_url":"https://github.com/Homebrew/homebrew","homepage":"http://brew.sh","size":1507352,"stargazers_count":22534,"watchers_count":22534,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":11308,"mirror_url":null,"open_issues_count":389,"forks":11308,"open_issues":389,"watchers":22534,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/38813"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/38813"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/38813"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/38813/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/38813/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/38813/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew/statuses/584ccb8b88cf58283b0c93eef37d5749e4b0223e"}}}}