{"action":"opened","number":506,"pull_request":{"url":"https://api.github.com/repos/xitrum-framework/xitrum/pulls/506","id":28172392,"html_url":"https://github.com/xitrum-framework/xitrum/pull/506","diff_url":"https://github.com/xitrum-framework/xitrum/pull/506.diff","patch_url":"https://github.com/xitrum-framework/xitrum/pull/506.patch","issue_url":"https://api.github.com/repos/xitrum-framework/xitrum/issues/506","number":506,"state":"open","locked":false,"title":"Make respondSockJsXxx return Future like other respondXxx methods","user":{"login":"georgeOsdDev","id":1381907,"avatar_url":"https://avatars.githubusercontent.com/u/1381907?v=3","gravatar_id":"","url":"https://api.github.com/users/georgeOsdDev","html_url":"https://github.com/georgeOsdDev","followers_url":"https://api.github.com/users/georgeOsdDev/followers","following_url":"https://api.github.com/users/georgeOsdDev/following{/other_user}","gists_url":"https://api.github.com/users/georgeOsdDev/gists{/gist_id}","starred_url":"https://api.github.com/users/georgeOsdDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgeOsdDev/subscriptions","organizations_url":"https://api.github.com/users/georgeOsdDev/orgs","repos_url":"https://api.github.com/users/georgeOsdDev/repos","events_url":"https://api.github.com/users/georgeOsdDev/events{/privacy}","received_events_url":"https://api.github.com/users/georgeOsdDev/received_events","type":"User","site_admin":false},"body":"This PR is against xitrum-framework/xitrum#503.\r\n\r\n@ngocdaothanh \r\nI'm not sure about how to get [EventExecutor](http://netty.io/4.0/api/io/netty/util/concurrent/EventExecutor.html) for DefaultPromise.  \r\nActually `channel.eventLoop` is available but can I use it in Actor(SockJSAction).\r\n\r\n```scala\r\nprivate def createPromise(index: Int):Future[String] = {\r\n  val p = new DefaultPromise[String](channel.eventLoop)\r\n  promises(index) = p\r\n  p\r\n}\r\n```","created_at":"2015-01-28T07:01:00Z","updated_at":"2015-01-28T07:01:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xitrum-framework/xitrum/pulls/506/commits","review_comments_url":"https://api.github.com/repos/xitrum-framework/xitrum/pulls/506/comments","review_comment_url":"https://api.github.com/repos/xitrum-framework/xitrum/pulls/comments/{number}","comments_url":"https://api.github.com/repos/xitrum-framework/xitrum/issues/506/comments","statuses_url":"https://api.github.com/repos/xitrum-framework/xitrum/statuses/6cd80b4391e4fa33f4c03bbe87a6b5cd600f3f01","head":{"label":"georgeOsdDev:patch/sockJSAction","ref":"patch/sockJSAction","sha":"6cd80b4391e4fa33f4c03bbe87a6b5cd600f3f01","user":{"login":"georgeOsdDev","id":1381907,"avatar_url":"https://avatars.githubusercontent.com/u/1381907?v=3","gravatar_id":"","url":"https://api.github.com/users/georgeOsdDev","html_url":"https://github.com/georgeOsdDev","followers_url":"https://api.github.com/users/georgeOsdDev/followers","following_url":"https://api.github.com/users/georgeOsdDev/following{/other_user}","gists_url":"https://api.github.com/users/georgeOsdDev/gists{/gist_id}","starred_url":"https://api.github.com/users/georgeOsdDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgeOsdDev/subscriptions","organizations_url":"https://api.github.com/users/georgeOsdDev/orgs","repos_url":"https://api.github.com/users/georgeOsdDev/repos","events_url":"https://api.github.com/users/georgeOsdDev/events{/privacy}","received_events_url":"https://api.github.com/users/georgeOsdDev/received_events","type":"User","site_admin":false},"repo":{"id":12475582,"name":"xitrum","full_name":"georgeOsdDev/xitrum","owner":{"login":"georgeOsdDev","id":1381907,"avatar_url":"https://avatars.githubusercontent.com/u/1381907?v=3","gravatar_id":"","url":"https://api.github.com/users/georgeOsdDev","html_url":"https://github.com/georgeOsdDev","followers_url":"https://api.github.com/users/georgeOsdDev/followers","following_url":"https://api.github.com/users/georgeOsdDev/following{/other_user}","gists_url":"https://api.github.com/users/georgeOsdDev/gists{/gist_id}","starred_url":"https://api.github.com/users/georgeOsdDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgeOsdDev/subscriptions","organizations_url":"https://api.github.com/users/georgeOsdDev/orgs","repos_url":"https://api.github.com/users/georgeOsdDev/repos","events_url":"https://api.github.com/users/georgeOsdDev/events{/privacy}","received_events_url":"https://api.github.com/users/georgeOsdDev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/georgeOsdDev/xitrum","description":"Async and clustered Scala web framework and HTTP(S) server","fork":true,"url":"https://api.github.com/repos/georgeOsdDev/xitrum","forks_url":"https://api.github.com/repos/georgeOsdDev/xitrum/forks","keys_url":"https://api.github.com/repos/georgeOsdDev/xitrum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/georgeOsdDev/xitrum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/georgeOsdDev/xitrum/teams","hooks_url":"https://api.github.com/repos/georgeOsdDev/xitrum/hooks","issue_events_url":"https://api.github.com/repos/georgeOsdDev/xitrum/issues/events{/number}","events_url":"https://api.github.com/repos/georgeOsdDev/xitrum/events","assignees_url":"https://api.github.com/repos/georgeOsdDev/xitrum/assignees{/user}","branches_url":"https://api.github.com/repos/georgeOsdDev/xitrum/branches{/branch}","tags_url":"https://api.github.com/repos/georgeOsdDev/xitrum/tags","blobs_url":"https://api.github.com/repos/georgeOsdDev/xitrum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/georgeOsdDev/xitrum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/georgeOsdDev/xitrum/git/refs{/sha}","trees_url":"https://api.github.com/repos/georgeOsdDev/xitrum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/georgeOsdDev/xitrum/statuses/{sha}","languages_url":"https://api.github.com/repos/georgeOsdDev/xitrum/languages","stargazers_url":"https://api.github.com/repos/georgeOsdDev/xitrum/stargazers","contributors_url":"https://api.github.com/repos/georgeOsdDev/xitrum/contributors","subscribers_url":"https://api.github.com/repos/georgeOsdDev/xitrum/subscribers","subscription_url":"https://api.github.com/repos/georgeOsdDev/xitrum/subscription","commits_url":"https://api.github.com/repos/georgeOsdDev/xitrum/commits{/sha}","git_commits_url":"https://api.github.com/repos/georgeOsdDev/xitrum/git/commits{/sha}","comments_url":"https://api.github.com/repos/georgeOsdDev/xitrum/comments{/number}","issue_comment_url":"https://api.github.com/repos/georgeOsdDev/xitrum/issues/comments/{number}","contents_url":"https://api.github.com/repos/georgeOsdDev/xitrum/contents/{+path}","compare_url":"https://api.github.com/repos/georgeOsdDev/xitrum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/georgeOsdDev/xitrum/merges","archive_url":"https://api.github.com/repos/georgeOsdDev/xitrum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/georgeOsdDev/xitrum/downloads","issues_url":"https://api.github.com/repos/georgeOsdDev/xitrum/issues{/number}","pulls_url":"https://api.github.com/repos/georgeOsdDev/xitrum/pulls{/number}","milestones_url":"https://api.github.com/repos/georgeOsdDev/xitrum/milestones{/number}","notifications_url":"https://api.github.com/repos/georgeOsdDev/xitrum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/georgeOsdDev/xitrum/labels{/name}","releases_url":"https://api.github.com/repos/georgeOsdDev/xitrum/releases{/id}","created_at":"2013-08-30T01:46:08Z","updated_at":"2014-03-13T12:53:08Z","pushed_at":"2015-01-28T06:53:33Z","git_url":"git://github.com/georgeOsdDev/xitrum.git","ssh_url":"git@github.com:georgeOsdDev/xitrum.git","clone_url":"https://github.com/georgeOsdDev/xitrum.git","svn_url":"https://github.com/georgeOsdDev/xitrum","homepage":"http://ngocdaothanh.github.io/xitrum","size":18770,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xitrum-framework:master","ref":"master","sha":"707aa6b84b399debd461b58411e34ee0cdf4e204","user":{"login":"xitrum-framework","id":7580751,"avatar_url":"https://avatars.githubusercontent.com/u/7580751?v=3","gravatar_id":"","url":"https://api.github.com/users/xitrum-framework","html_url":"https://github.com/xitrum-framework","followers_url":"https://api.github.com/users/xitrum-framework/followers","following_url":"https://api.github.com/users/xitrum-framework/following{/other_user}","gists_url":"https://api.github.com/users/xitrum-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/xitrum-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xitrum-framework/subscriptions","organizations_url":"https://api.github.com/users/xitrum-framework/orgs","repos_url":"https://api.github.com/users/xitrum-framework/repos","events_url":"https://api.github.com/users/xitrum-framework/events{/privacy}","received_events_url":"https://api.github.com/users/xitrum-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":785509,"name":"xitrum","full_name":"xitrum-framework/xitrum","owner":{"login":"xitrum-framework","id":7580751,"avatar_url":"https://avatars.githubusercontent.com/u/7580751?v=3","gravatar_id":"","url":"https://api.github.com/users/xitrum-framework","html_url":"https://github.com/xitrum-framework","followers_url":"https://api.github.com/users/xitrum-framework/followers","following_url":"https://api.github.com/users/xitrum-framework/following{/other_user}","gists_url":"https://api.github.com/users/xitrum-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/xitrum-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xitrum-framework/subscriptions","organizations_url":"https://api.github.com/users/xitrum-framework/orgs","repos_url":"https://api.github.com/users/xitrum-framework/repos","events_url":"https://api.github.com/users/xitrum-framework/events{/privacy}","received_events_url":"https://api.github.com/users/xitrum-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xitrum-framework/xitrum","description":"Async and clustered Scala web framework and HTTP(S) server","fork":false,"url":"https://api.github.com/repos/xitrum-framework/xitrum","forks_url":"https://api.github.com/repos/xitrum-framework/xitrum/forks","keys_url":"https://api.github.com/repos/xitrum-framework/xitrum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xitrum-framework/xitrum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xitrum-framework/xitrum/teams","hooks_url":"https://api.github.com/repos/xitrum-framework/xitrum/hooks","issue_events_url":"https://api.github.com/repos/xitrum-framework/xitrum/issues/events{/number}","events_url":"https://api.github.com/repos/xitrum-framework/xitrum/events","assignees_url":"https://api.github.com/repos/xitrum-framework/xitrum/assignees{/user}","branches_url":"https://api.github.com/repos/xitrum-framework/xitrum/branches{/branch}","tags_url":"https://api.github.com/repos/xitrum-framework/xitrum/tags","blobs_url":"https://api.github.com/repos/xitrum-framework/xitrum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xitrum-framework/xitrum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xitrum-framework/xitrum/git/refs{/sha}","trees_url":"https://api.github.com/repos/xitrum-framework/xitrum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xitrum-framework/xitrum/statuses/{sha}","languages_url":"https://api.github.com/repos/xitrum-framework/xitrum/languages","stargazers_url":"https://api.github.com/repos/xitrum-framework/xitrum/stargazers","contributors_url":"https://api.github.com/repos/xitrum-framework/xitrum/contributors","subscribers_url":"https://api.github.com/repos/xitrum-framework/xitrum/subscribers","subscription_url":"https://api.github.com/repos/xitrum-framework/xitrum/subscription","commits_url":"https://api.github.com/repos/xitrum-framework/xitrum/commits{/sha}","git_commits_url":"https://api.github.com/repos/xitrum-framework/xitrum/git/commits{/sha}","comments_url":"https://api.github.com/repos/xitrum-framework/xitrum/comments{/number}","issue_comment_url":"https://api.github.com/repos/xitrum-framework/xitrum/issues/comments/{number}","contents_url":"https://api.github.com/repos/xitrum-framework/xitrum/contents/{+path}","compare_url":"https://api.github.com/repos/xitrum-framework/xitrum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xitrum-framework/xitrum/merges","archive_url":"https://api.github.com/repos/xitrum-framework/xitrum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xitrum-framework/xitrum/downloads","issues_url":"https://api.github.com/repos/xitrum-framework/xitrum/issues{/number}","pulls_url":"https://api.github.com/repos/xitrum-framework/xitrum/pulls{/number}","milestones_url":"https://api.github.com/repos/xitrum-framework/xitrum/milestones{/number}","notifications_url":"https://api.github.com/repos/xitrum-framework/xitrum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xitrum-framework/xitrum/labels{/name}","releases_url":"https://api.github.com/repos/xitrum-framework/xitrum/releases{/id}","created_at":"2010-07-19T22:58:50Z","updated_at":"2015-01-27T14:47:29Z","pushed_at":"2015-01-20T08:40:31Z","git_url":"git://github.com/xitrum-framework/xitrum.git","ssh_url":"git@github.com:xitrum-framework/xitrum.git","clone_url":"https://github.com/xitrum-framework/xitrum.git","svn_url":"https://github.com/xitrum-framework/xitrum","homepage":"http://xitrum-framework.github.io/","size":24619,"stargazers_count":303,"watchers_count":303,"language":"Scala","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":51,"forks":35,"open_issues":51,"watchers":303,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xitrum-framework/xitrum/pulls/506"},"html":{"href":"https://github.com/xitrum-framework/xitrum/pull/506"},"issue":{"href":"https://api.github.com/repos/xitrum-framework/xitrum/issues/506"},"comments":{"href":"https://api.github.com/repos/xitrum-framework/xitrum/issues/506/comments"},"review_comments":{"href":"https://api.github.com/repos/xitrum-framework/xitrum/pulls/506/comments"},"review_comment":{"href":"https://api.github.com/repos/xitrum-framework/xitrum/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/xitrum-framework/xitrum/pulls/506/commits"},"statuses":{"href":"https://api.github.com/repos/xitrum-framework/xitrum/statuses/6cd80b4391e4fa33f4c03bbe87a6b5cd600f3f01"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":168,"deletions":39,"changed_files":4}}