{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/tslint/pulls/comments/24365862","id":24365862,"diff_hunk":"@@ -57,19 +57,28 @@ function toString(modifiers: IModifiers): string {\n export class MemberOrderingWalker extends Lint.RuleWalker {\n     private previous: IModifiers;\n \n-    constructor(sourceFile: ts.SourceFile, options: Lint.IOptions) {\n-        super(sourceFile, options);\n-    }\n-\n-    public visitClassDeclaration(node: ts.ClassDeclaration): void {\n+    private resetPrevious(): void {","path":"src/rules/memberOrderingRule.ts","position":9,"original_position":9,"commit_id":"94bee86392e1b4dbea34326d1530dec2987b11cc","original_commit_id":"94bee86392e1b4dbea34326d1530dec2987b11cc","user":{"login":"ashwinr","id":362990,"avatar_url":"https://avatars.githubusercontent.com/u/362990?v=3","gravatar_id":"","url":"https://api.github.com/users/ashwinr","html_url":"https://github.com/ashwinr","followers_url":"https://api.github.com/users/ashwinr/followers","following_url":"https://api.github.com/users/ashwinr/following{/other_user}","gists_url":"https://api.github.com/users/ashwinr/gists{/gist_id}","starred_url":"https://api.github.com/users/ashwinr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashwinr/subscriptions","organizations_url":"https://api.github.com/users/ashwinr/orgs","repos_url":"https://api.github.com/users/ashwinr/repos","events_url":"https://api.github.com/users/ashwinr/events{/privacy}","received_events_url":"https://api.github.com/users/ashwinr/received_events","type":"User","site_admin":false},"body":"otherwise, looks good! i can merge after you update the PR","created_at":"2015-02-09T21:13:53Z","updated_at":"2015-02-09T21:13:53Z","html_url":"https://github.com/palantir/tslint/pull/302#discussion_r24365862","pull_request_url":"https://api.github.com/repos/palantir/tslint/pulls/302","_links":{"self":{"href":"https://api.github.com/repos/palantir/tslint/pulls/comments/24365862"},"html":{"href":"https://github.com/palantir/tslint/pull/302#discussion_r24365862"},"pull_request":{"href":"https://api.github.com/repos/palantir/tslint/pulls/302"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/tslint/pulls/302","id":28876535,"html_url":"https://github.com/palantir/tslint/pull/302","diff_url":"https://github.com/palantir/tslint/pull/302.diff","patch_url":"https://github.com/palantir/tslint/pull/302.patch","issue_url":"https://api.github.com/repos/palantir/tslint/issues/302","number":302,"state":"open","locked":false,"title":"walk interface and reset previous state for member-ordering rules","user":{"login":"ericvw","id":1284017,"avatar_url":"https://avatars.githubusercontent.com/u/1284017?v=3","gravatar_id":"","url":"https://api.github.com/users/ericvw","html_url":"https://github.com/ericvw","followers_url":"https://api.github.com/users/ericvw/followers","following_url":"https://api.github.com/users/ericvw/following{/other_user}","gists_url":"https://api.github.com/users/ericvw/gists{/gist_id}","starred_url":"https://api.github.com/users/ericvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericvw/subscriptions","organizations_url":"https://api.github.com/users/ericvw/orgs","repos_url":"https://api.github.com/users/ericvw/repos","events_url":"https://api.github.com/users/ericvw/events{/privacy}","received_events_url":"https://api.github.com/users/ericvw/received_events","type":"User","site_admin":false},"body":"This change introduces resetting the previous `IModifiers` state when\r\nvisiting an interface declaration.  Without doing so, subsequent\r\ninterface declarations would be conflated as if they were the same\r\ninterface when using the `variables-before-functions` rule option.\r\n\r\nVersion `1.2.0` did not have this problem and `2.1.0` introduced this\r\nregression.  The `memberordering-method.test.ts` has been updated\r\nappropriately to test for this regression and an additional test has\r\nbeen provided to ensure that interface declarations should trigger\r\nsimilarly to class declarations.","created_at":"2015-02-08T06:46:19Z","updated_at":"2015-02-09T21:13:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd49c7d65ba2f7e6d6397c78507843acabe8ea73","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/palantir/tslint/pulls/302/commits","review_comments_url":"https://api.github.com/repos/palantir/tslint/pulls/302/comments","review_comment_url":"https://api.github.com/repos/palantir/tslint/pulls/comments/{number}","comments_url":"https://api.github.com/repos/palantir/tslint/issues/302/comments","statuses_url":"https://api.github.com/repos/palantir/tslint/statuses/94bee86392e1b4dbea34326d1530dec2987b11cc","head":{"label":"ericvw:member-ordering-walk-interface","ref":"member-ordering-walk-interface","sha":"94bee86392e1b4dbea34326d1530dec2987b11cc","user":{"login":"ericvw","id":1284017,"avatar_url":"https://avatars.githubusercontent.com/u/1284017?v=3","gravatar_id":"","url":"https://api.github.com/users/ericvw","html_url":"https://github.com/ericvw","followers_url":"https://api.github.com/users/ericvw/followers","following_url":"https://api.github.com/users/ericvw/following{/other_user}","gists_url":"https://api.github.com/users/ericvw/gists{/gist_id}","starred_url":"https://api.github.com/users/ericvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericvw/subscriptions","organizations_url":"https://api.github.com/users/ericvw/orgs","repos_url":"https://api.github.com/users/ericvw/repos","events_url":"https://api.github.com/users/ericvw/events{/privacy}","received_events_url":"https://api.github.com/users/ericvw/received_events","type":"User","site_admin":false},"repo":{"id":30482882,"name":"tslint","full_name":"ericvw/tslint","owner":{"login":"ericvw","id":1284017,"avatar_url":"https://avatars.githubusercontent.com/u/1284017?v=3","gravatar_id":"","url":"https://api.github.com/users/ericvw","html_url":"https://github.com/ericvw","followers_url":"https://api.github.com/users/ericvw/followers","following_url":"https://api.github.com/users/ericvw/following{/other_user}","gists_url":"https://api.github.com/users/ericvw/gists{/gist_id}","starred_url":"https://api.github.com/users/ericvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericvw/subscriptions","organizations_url":"https://api.github.com/users/ericvw/orgs","repos_url":"https://api.github.com/users/ericvw/repos","events_url":"https://api.github.com/users/ericvw/events{/privacy}","received_events_url":"https://api.github.com/users/ericvw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericvw/tslint","description":"A linter for the TypeScript language.","fork":true,"url":"https://api.github.com/repos/ericvw/tslint","forks_url":"https://api.github.com/repos/ericvw/tslint/forks","keys_url":"https://api.github.com/repos/ericvw/tslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericvw/tslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericvw/tslint/teams","hooks_url":"https://api.github.com/repos/ericvw/tslint/hooks","issue_events_url":"https://api.github.com/repos/ericvw/tslint/issues/events{/number}","events_url":"https://api.github.com/repos/ericvw/tslint/events","assignees_url":"https://api.github.com/repos/ericvw/tslint/assignees{/user}","branches_url":"https://api.github.com/repos/ericvw/tslint/branches{/branch}","tags_url":"https://api.github.com/repos/ericvw/tslint/tags","blobs_url":"https://api.github.com/repos/ericvw/tslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericvw/tslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericvw/tslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericvw/tslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericvw/tslint/statuses/{sha}","languages_url":"https://api.github.com/repos/ericvw/tslint/languages","stargazers_url":"https://api.github.com/repos/ericvw/tslint/stargazers","contributors_url":"https://api.github.com/repos/ericvw/tslint/contributors","subscribers_url":"https://api.github.com/repos/ericvw/tslint/subscribers","subscription_url":"https://api.github.com/repos/ericvw/tslint/subscription","commits_url":"https://api.github.com/repos/ericvw/tslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericvw/tslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericvw/tslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericvw/tslint/issues/comments/{number}","contents_url":"https://api.github.com/repos/ericvw/tslint/contents/{+path}","compare_url":"https://api.github.com/repos/ericvw/tslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericvw/tslint/merges","archive_url":"https://api.github.com/repos/ericvw/tslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericvw/tslint/downloads","issues_url":"https://api.github.com/repos/ericvw/tslint/issues{/number}","pulls_url":"https://api.github.com/repos/ericvw/tslint/pulls{/number}","milestones_url":"https://api.github.com/repos/ericvw/tslint/milestones{/number}","notifications_url":"https://api.github.com/repos/ericvw/tslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericvw/tslint/labels{/name}","releases_url":"https://api.github.com/repos/ericvw/tslint/releases{/id}","created_at":"2015-02-08T06:16:23Z","updated_at":"2015-02-08T06:16:24Z","pushed_at":"2015-02-08T07:38:06Z","git_url":"git://github.com/ericvw/tslint.git","ssh_url":"git@github.com:ericvw/tslint.git","clone_url":"https://github.com/ericvw/tslint.git","svn_url":"https://github.com/ericvw/tslint","homepage":null,"size":10946,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"palantir:master","ref":"master","sha":"c39bd6028e04b9068dcc6e4428da47939953a81d","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":11672345,"name":"tslint","full_name":"palantir/tslint","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/tslint","description":"A linter for the TypeScript language.","fork":false,"url":"https://api.github.com/repos/palantir/tslint","forks_url":"https://api.github.com/repos/palantir/tslint/forks","keys_url":"https://api.github.com/repos/palantir/tslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/tslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/tslint/teams","hooks_url":"https://api.github.com/repos/palantir/tslint/hooks","issue_events_url":"https://api.github.com/repos/palantir/tslint/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/tslint/events","assignees_url":"https://api.github.com/repos/palantir/tslint/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/tslint/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/tslint/tags","blobs_url":"https://api.github.com/repos/palantir/tslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/tslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/tslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/tslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/tslint/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/tslint/languages","stargazers_url":"https://api.github.com/repos/palantir/tslint/stargazers","contributors_url":"https://api.github.com/repos/palantir/tslint/contributors","subscribers_url":"https://api.github.com/repos/palantir/tslint/subscribers","subscription_url":"https://api.github.com/repos/palantir/tslint/subscription","commits_url":"https://api.github.com/repos/palantir/tslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/tslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/tslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/tslint/issues/comments/{number}","contents_url":"https://api.github.com/repos/palantir/tslint/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/tslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/tslint/merges","archive_url":"https://api.github.com/repos/palantir/tslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/tslint/downloads","issues_url":"https://api.github.com/repos/palantir/tslint/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/tslint/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/tslint/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/tslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/tslint/labels{/name}","releases_url":"https://api.github.com/repos/palantir/tslint/releases{/id}","created_at":"2013-07-25T22:19:18Z","updated_at":"2015-02-09T20:46:04Z","pushed_at":"2015-02-09T19:53:23Z","git_url":"git://github.com/palantir/tslint.git","ssh_url":"git@github.com:palantir/tslint.git","clone_url":"https://github.com/palantir/tslint.git","svn_url":"https://github.com/palantir/tslint","homepage":null,"size":10946,"stargazers_count":191,"watchers_count":191,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":50,"mirror_url":null,"open_issues_count":38,"forks":50,"open_issues":38,"watchers":191,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/tslint/pulls/302"},"html":{"href":"https://github.com/palantir/tslint/pull/302"},"issue":{"href":"https://api.github.com/repos/palantir/tslint/issues/302"},"comments":{"href":"https://api.github.com/repos/palantir/tslint/issues/302/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/tslint/pulls/302/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/tslint/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/palantir/tslint/pulls/302/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/tslint/statuses/94bee86392e1b4dbea34326d1530dec2987b11cc"}}}}