{"action":"created","comment":{"url":"https://api.github.com/repos/BladeRunnerJS/brjs/pulls/comments/32611949","id":32611949,"diff_hunk":"@@ -47,3 +47,9 @@ if (Function.prototype.bind && typeof console == \"object\" && typeof console.log\n \t\tconsole[method] = Function.prototype.call.bind(console[method], console);\n \t}\n }\n+\n+if(!Number.isNaN) {\n+\tNumber.isNaN = Number.isNaN || function(value) {\n+\t    return typeof value === \"number\" && value !== value;","path":"brjs-sdk/sdk/libs/javascript/br-ie8-shim/ie8-shim.js","position":7,"original_position":7,"commit_id":"5da325757ef59ae91dd97ead05bf1bba9e50c074","original_commit_id":"5da325757ef59ae91dd97ead05bf1bba9e50c074","user":{"login":"dchambers","id":283294,"avatar_url":"https://avatars.githubusercontent.com/u/283294?v=3","gravatar_id":"","url":"https://api.github.com/users/dchambers","html_url":"https://github.com/dchambers","followers_url":"https://api.github.com/users/dchambers/followers","following_url":"https://api.github.com/users/dchambers/following{/other_user}","gists_url":"https://api.github.com/users/dchambers/gists{/gist_id}","starred_url":"https://api.github.com/users/dchambers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchambers/subscriptions","organizations_url":"https://api.github.com/users/dchambers/orgs","repos_url":"https://api.github.com/users/dchambers/repos","events_url":"https://api.github.com/users/dchambers/events{/privacy}","received_events_url":"https://api.github.com/users/dchambers/received_events","type":"User","site_admin":false},"body":"`isNaN()` only produces sensible results for numbers, whereas `Number.isNaN()` accepts argument of any type.","created_at":"2015-06-17T10:08:26Z","updated_at":"2015-06-17T10:08:26Z","html_url":"https://github.com/BladeRunnerJS/brjs/pull/1429#discussion_r32611949","pull_request_url":"https://api.github.com/repos/BladeRunnerJS/brjs/pulls/1429","_links":{"self":{"href":"https://api.github.com/repos/BladeRunnerJS/brjs/pulls/comments/32611949"},"html":{"href":"https://github.com/BladeRunnerJS/brjs/pull/1429#discussion_r32611949"},"pull_request":{"href":"https://api.github.com/repos/BladeRunnerJS/brjs/pulls/1429"}}},"pull_request":{"url":"https://api.github.com/repos/BladeRunnerJS/brjs/pulls/1429","id":37880386,"html_url":"https://github.com/BladeRunnerJS/brjs/pull/1429","diff_url":"https://github.com/BladeRunnerJS/brjs/pull/1429.diff","patch_url":"https://github.com/BladeRunnerJS/brjs/pull/1429.patch","issue_url":"https://api.github.com/repos/BladeRunnerJS/brjs/issues/1429","number":1429,"state":"open","locked":false,"title":"Allow NaN to be handled by parsers without getting into an infinite l…","user":{"login":"dchambers","id":283294,"avatar_url":"https://avatars.githubusercontent.com/u/283294?v=3","gravatar_id":"","url":"https://api.github.com/users/dchambers","html_url":"https://github.com/dchambers","followers_url":"https://api.github.com/users/dchambers/followers","following_url":"https://api.github.com/users/dchambers/following{/other_user}","gists_url":"https://api.github.com/users/dchambers/gists{/gist_id}","starred_url":"https://api.github.com/users/dchambers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchambers/subscriptions","organizations_url":"https://api.github.com/users/dchambers/orgs","repos_url":"https://api.github.com/users/dchambers/repos","events_url":"https://api.github.com/users/dchambers/events{/privacy}","received_events_url":"https://api.github.com/users/dchambers/received_events","type":"User","site_admin":false},"body":"…oop.","created_at":"2015-06-17T09:17:51Z","updated_at":"2015-06-17T10:08:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1fb64f833d199f927879718002fa203d021b9e0c","assignee":null,"milestone":{"url":"https://api.github.com/repos/BladeRunnerJS/brjs/milestones/35","html_url":"https://github.com/BladeRunnerJS/brjs/milestones/1.1","labels_url":"https://api.github.com/repos/BladeRunnerJS/brjs/milestones/35/labels","id":1106406,"number":35,"title":"1.1","description":"","creator":{"login":"andyberry88","id":726896,"avatar_url":"https://avatars.githubusercontent.com/u/726896?v=3","gravatar_id":"","url":"https://api.github.com/users/andyberry88","html_url":"https://github.com/andyberry88","followers_url":"https://api.github.com/users/andyberry88/followers","following_url":"https://api.github.com/users/andyberry88/following{/other_user}","gists_url":"https://api.github.com/users/andyberry88/gists{/gist_id}","starred_url":"https://api.github.com/users/andyberry88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyberry88/subscriptions","organizations_url":"https://api.github.com/users/andyberry88/orgs","repos_url":"https://api.github.com/users/andyberry88/repos","events_url":"https://api.github.com/users/andyberry88/events{/privacy}","received_events_url":"https://api.github.com/users/andyberry88/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":0,"state":"open","created_at":"2015-05-12T09:52:29Z","updated_at":"2015-06-17T10:07:02Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/BladeRunnerJS/brjs/pulls/1429/commits","review_comments_url":"https://api.github.com/repos/BladeRunnerJS/brjs/pulls/1429/comments","review_comment_url":"https://api.github.com/repos/BladeRunnerJS/brjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BladeRunnerJS/brjs/issues/1429/comments","statuses_url":"https://api.github.com/repos/BladeRunnerJS/brjs/statuses/5da325757ef59ae91dd97ead05bf1bba9e50c074","head":{"label":"BladeRunnerJS:editable-property-NaN-support","ref":"editable-property-NaN-support","sha":"5da325757ef59ae91dd97ead05bf1bba9e50c074","user":{"login":"BladeRunnerJS","id":5066144,"avatar_url":"https://avatars.githubusercontent.com/u/5066144?v=3","gravatar_id":"","url":"https://api.github.com/users/BladeRunnerJS","html_url":"https://github.com/BladeRunnerJS","followers_url":"https://api.github.com/users/BladeRunnerJS/followers","following_url":"https://api.github.com/users/BladeRunnerJS/following{/other_user}","gists_url":"https://api.github.com/users/BladeRunnerJS/gists{/gist_id}","starred_url":"https://api.github.com/users/BladeRunnerJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BladeRunnerJS/subscriptions","organizations_url":"https://api.github.com/users/BladeRunnerJS/orgs","repos_url":"https://api.github.com/users/BladeRunnerJS/repos","events_url":"https://api.github.com/users/BladeRunnerJS/events{/privacy}","received_events_url":"https://api.github.com/users/BladeRunnerJS/received_events","type":"Organization","site_admin":false},"repo":{"id":11682819,"name":"brjs","full_name":"BladeRunnerJS/brjs","owner":{"login":"BladeRunnerJS","id":5066144,"avatar_url":"https://avatars.githubusercontent.com/u/5066144?v=3","gravatar_id":"","url":"https://api.github.com/users/BladeRunnerJS","html_url":"https://github.com/BladeRunnerJS","followers_url":"https://api.github.com/users/BladeRunnerJS/followers","following_url":"https://api.github.com/users/BladeRunnerJS/following{/other_user}","gists_url":"https://api.github.com/users/BladeRunnerJS/gists{/gist_id}","starred_url":"https://api.github.com/users/BladeRunnerJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BladeRunnerJS/subscriptions","organizations_url":"https://api.github.com/users/BladeRunnerJS/orgs","repos_url":"https://api.github.com/users/BladeRunnerJS/repos","events_url":"https://api.github.com/users/BladeRunnerJS/events{/privacy}","received_events_url":"https://api.github.com/users/BladeRunnerJS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BladeRunnerJS/brjs","description":"BladeRunnerJS (BRJS) is an open source development toolkit and framework for modular construction of large single-page HTML5 apps. It consists of a set of conventions, supporting tools and micro-libraries that make it easy to develop, test, deploy and maintain complex JavaScript apps.","fork":false,"url":"https://api.github.com/repos/BladeRunnerJS/brjs","forks_url":"https://api.github.com/repos/BladeRunnerJS/brjs/forks","keys_url":"https://api.github.com/repos/BladeRunnerJS/brjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BladeRunnerJS/brjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BladeRunnerJS/brjs/teams","hooks_url":"https://api.github.com/repos/BladeRunnerJS/brjs/hooks","issue_events_url":"https://api.github.com/repos/BladeRunnerJS/brjs/issues/events{/number}","events_url":"https://api.github.com/repos/BladeRunnerJS/brjs/events","assignees_url":"https://api.github.com/repos/BladeRunnerJS/brjs/assignees{/user}","branches_url":"https://api.github.com/repos/BladeRunnerJS/brjs/branches{/branch}","tags_url":"https://api.github.com/repos/BladeRunnerJS/brjs/tags","blobs_url":"https://api.github.com/repos/BladeRunnerJS/brjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BladeRunnerJS/brjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BladeRunnerJS/brjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/BladeRunnerJS/brjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BladeRunnerJS/brjs/statuses/{sha}","languages_url":"https://api.github.com/repos/BladeRunnerJS/brjs/languages","stargazers_url":"https://api.github.com/repos/BladeRunnerJS/brjs/stargazers","contributors_url":"https://api.github.com/repos/BladeRunnerJS/brjs/contributors","subscribers_url":"https://api.github.com/repos/BladeRunnerJS/brjs/subscribers","subscription_url":"https://api.github.com/repos/BladeRunnerJS/brjs/subscription","commits_url":"https://api.github.com/repos/BladeRunnerJS/brjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/BladeRunnerJS/brjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/BladeRunnerJS/brjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/BladeRunnerJS/brjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/BladeRunnerJS/brjs/contents/{+path}","compare_url":"https://api.github.com/repos/BladeRunnerJS/brjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BladeRunnerJS/brjs/merges","archive_url":"https://api.github.com/repos/BladeRunnerJS/brjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BladeRunnerJS/brjs/downloads","issues_url":"https://api.github.com/repos/BladeRunnerJS/brjs/issues{/number}","pulls_url":"https://api.github.com/repos/BladeRunnerJS/brjs/pulls{/number}","milestones_url":"https://api.github.com/repos/BladeRunnerJS/brjs/milestones{/number}","notifications_url":"https://api.github.com/repos/BladeRunnerJS/brjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BladeRunnerJS/brjs/labels{/name}","releases_url":"https://api.github.com/repos/BladeRunnerJS/brjs/releases{/id}","created_at":"2013-07-26T09:49:40Z","updated_at":"2015-06-09T09:18:36Z","pushed_at":"2015-06-17T09:17:51Z","git_url":"git://github.com/BladeRunnerJS/brjs.git","ssh_url":"git@github.com:BladeRunnerJS/brjs.git","clone_url":"https://github.com/BladeRunnerJS/brjs.git","svn_url":"https://github.com/BladeRunnerJS/brjs","homepage":"http://bladerunnerjs.org/","size":102854,"stargazers_count":202,"watchers_count":202,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":157,"forks":27,"open_issues":157,"watchers":202,"default_branch":"master"}},"base":{"label":"BladeRunnerJS:develop","ref":"develop","sha":"69243ff89548431c67ac24e6633af239da7cc242","user":{"login":"BladeRunnerJS","id":5066144,"avatar_url":"https://avatars.githubusercontent.com/u/5066144?v=3","gravatar_id":"","url":"https://api.github.com/users/BladeRunnerJS","html_url":"https://github.com/BladeRunnerJS","followers_url":"https://api.github.com/users/BladeRunnerJS/followers","following_url":"https://api.github.com/users/BladeRunnerJS/following{/other_user}","gists_url":"https://api.github.com/users/BladeRunnerJS/gists{/gist_id}","starred_url":"https://api.github.com/users/BladeRunnerJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BladeRunnerJS/subscriptions","organizations_url":"https://api.github.com/users/BladeRunnerJS/orgs","repos_url":"https://api.github.com/users/BladeRunnerJS/repos","events_url":"https://api.github.com/users/BladeRunnerJS/events{/privacy}","received_events_url":"https://api.github.com/users/BladeRunnerJS/received_events","type":"Organization","site_admin":false},"repo":{"id":11682819,"name":"brjs","full_name":"BladeRunnerJS/brjs","owner":{"login":"BladeRunnerJS","id":5066144,"avatar_url":"https://avatars.githubusercontent.com/u/5066144?v=3","gravatar_id":"","url":"https://api.github.com/users/BladeRunnerJS","html_url":"https://github.com/BladeRunnerJS","followers_url":"https://api.github.com/users/BladeRunnerJS/followers","following_url":"https://api.github.com/users/BladeRunnerJS/following{/other_user}","gists_url":"https://api.github.com/users/BladeRunnerJS/gists{/gist_id}","starred_url":"https://api.github.com/users/BladeRunnerJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BladeRunnerJS/subscriptions","organizations_url":"https://api.github.com/users/BladeRunnerJS/orgs","repos_url":"https://api.github.com/users/BladeRunnerJS/repos","events_url":"https://api.github.com/users/BladeRunnerJS/events{/privacy}","received_events_url":"https://api.github.com/users/BladeRunnerJS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BladeRunnerJS/brjs","description":"BladeRunnerJS (BRJS) is an open source development toolkit and framework for modular construction of large single-page HTML5 apps. It consists of a set of conventions, supporting tools and micro-libraries that make it easy to develop, test, deploy and maintain complex JavaScript apps.","fork":false,"url":"https://api.github.com/repos/BladeRunnerJS/brjs","forks_url":"https://api.github.com/repos/BladeRunnerJS/brjs/forks","keys_url":"https://api.github.com/repos/BladeRunnerJS/brjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BladeRunnerJS/brjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BladeRunnerJS/brjs/teams","hooks_url":"https://api.github.com/repos/BladeRunnerJS/brjs/hooks","issue_events_url":"https://api.github.com/repos/BladeRunnerJS/brjs/issues/events{/number}","events_url":"https://api.github.com/repos/BladeRunnerJS/brjs/events","assignees_url":"https://api.github.com/repos/BladeRunnerJS/brjs/assignees{/user}","branches_url":"https://api.github.com/repos/BladeRunnerJS/brjs/branches{/branch}","tags_url":"https://api.github.com/repos/BladeRunnerJS/brjs/tags","blobs_url":"https://api.github.com/repos/BladeRunnerJS/brjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BladeRunnerJS/brjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BladeRunnerJS/brjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/BladeRunnerJS/brjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BladeRunnerJS/brjs/statuses/{sha}","languages_url":"https://api.github.com/repos/BladeRunnerJS/brjs/languages","stargazers_url":"https://api.github.com/repos/BladeRunnerJS/brjs/stargazers","contributors_url":"https://api.github.com/repos/BladeRunnerJS/brjs/contributors","subscribers_url":"https://api.github.com/repos/BladeRunnerJS/brjs/subscribers","subscription_url":"https://api.github.com/repos/BladeRunnerJS/brjs/subscription","commits_url":"https://api.github.com/repos/BladeRunnerJS/brjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/BladeRunnerJS/brjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/BladeRunnerJS/brjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/BladeRunnerJS/brjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/BladeRunnerJS/brjs/contents/{+path}","compare_url":"https://api.github.com/repos/BladeRunnerJS/brjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BladeRunnerJS/brjs/merges","archive_url":"https://api.github.com/repos/BladeRunnerJS/brjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BladeRunnerJS/brjs/downloads","issues_url":"https://api.github.com/repos/BladeRunnerJS/brjs/issues{/number}","pulls_url":"https://api.github.com/repos/BladeRunnerJS/brjs/pulls{/number}","milestones_url":"https://api.github.com/repos/BladeRunnerJS/brjs/milestones{/number}","notifications_url":"https://api.github.com/repos/BladeRunnerJS/brjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BladeRunnerJS/brjs/labels{/name}","releases_url":"https://api.github.com/repos/BladeRunnerJS/brjs/releases{/id}","created_at":"2013-07-26T09:49:40Z","updated_at":"2015-06-09T09:18:36Z","pushed_at":"2015-06-17T09:17:51Z","git_url":"git://github.com/BladeRunnerJS/brjs.git","ssh_url":"git@github.com:BladeRunnerJS/brjs.git","clone_url":"https://github.com/BladeRunnerJS/brjs.git","svn_url":"https://github.com/BladeRunnerJS/brjs","homepage":"http://bladerunnerjs.org/","size":102854,"stargazers_count":202,"watchers_count":202,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":157,"forks":27,"open_issues":157,"watchers":202,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BladeRunnerJS/brjs/pulls/1429"},"html":{"href":"https://github.com/BladeRunnerJS/brjs/pull/1429"},"issue":{"href":"https://api.github.com/repos/BladeRunnerJS/brjs/issues/1429"},"comments":{"href":"https://api.github.com/repos/BladeRunnerJS/brjs/issues/1429/comments"},"review_comments":{"href":"https://api.github.com/repos/BladeRunnerJS/brjs/pulls/1429/comments"},"review_comment":{"href":"https://api.github.com/repos/BladeRunnerJS/brjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BladeRunnerJS/brjs/pulls/1429/commits"},"statuses":{"href":"https://api.github.com/repos/BladeRunnerJS/brjs/statuses/5da325757ef59ae91dd97ead05bf1bba9e50c074"}}}}