{"action":"opened","number":1048,"pull_request":{"url":"https://api.github.com/repos/Yelp/mrjob/pulls/1048","id":38197402,"html_url":"https://github.com/Yelp/mrjob/pull/1048","diff_url":"https://github.com/Yelp/mrjob/pull/1048.diff","patch_url":"https://github.com/Yelp/mrjob/pull/1048.patch","issue_url":"https://api.github.com/repos/Yelp/mrjob/issues/1048","number":1048,"state":"open","locked":false,"title":"Use Instances.Ec2SubnetId in doc examples","user":{"login":"tylernisonoff","id":1152284,"avatar_url":"https://avatars.githubusercontent.com/u/1152284?v=3","gravatar_id":"","url":"https://api.github.com/users/tylernisonoff","html_url":"https://github.com/tylernisonoff","followers_url":"https://api.github.com/users/tylernisonoff/followers","following_url":"https://api.github.com/users/tylernisonoff/following{/other_user}","gists_url":"https://api.github.com/users/tylernisonoff/gists{/gist_id}","starred_url":"https://api.github.com/users/tylernisonoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylernisonoff/subscriptions","organizations_url":"https://api.github.com/users/tylernisonoff/orgs","repos_url":"https://api.github.com/users/tylernisonoff/repos","events_url":"https://api.github.com/users/tylernisonoff/events{/privacy}","received_events_url":"https://api.github.com/users/tylernisonoff/received_events","type":"User","site_admin":false},"body":"The correct parameter to set the EMR job in a specific subnet is Instances.Ec2SubnetId, not Instance.Ec2SubnetId.  While the docs do not explicitly say this is the intention of the parameter, it can be misleading to readers as the correct parameter to pass for this behavior. Instance.Ec2SubnetId gets ignored by the Ec2 API and has no effect.  \r\n\r\nI've also updated the tests to reflect the change, since it seemed like the tests and docs were mirroring each other.","created_at":"2015-06-22T03:09:56Z","updated_at":"2015-06-22T03:09:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Yelp/mrjob/pulls/1048/commits","review_comments_url":"https://api.github.com/repos/Yelp/mrjob/pulls/1048/comments","review_comment_url":"https://api.github.com/repos/Yelp/mrjob/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yelp/mrjob/issues/1048/comments","statuses_url":"https://api.github.com/repos/Yelp/mrjob/statuses/ed128864d894433ed013bd5449df2131fbb67ba1","head":{"label":"tylernisonoff:update_emr_api_params_docs","ref":"update_emr_api_params_docs","sha":"ed128864d894433ed013bd5449df2131fbb67ba1","user":{"login":"tylernisonoff","id":1152284,"avatar_url":"https://avatars.githubusercontent.com/u/1152284?v=3","gravatar_id":"","url":"https://api.github.com/users/tylernisonoff","html_url":"https://github.com/tylernisonoff","followers_url":"https://api.github.com/users/tylernisonoff/followers","following_url":"https://api.github.com/users/tylernisonoff/following{/other_user}","gists_url":"https://api.github.com/users/tylernisonoff/gists{/gist_id}","starred_url":"https://api.github.com/users/tylernisonoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylernisonoff/subscriptions","organizations_url":"https://api.github.com/users/tylernisonoff/orgs","repos_url":"https://api.github.com/users/tylernisonoff/repos","events_url":"https://api.github.com/users/tylernisonoff/events{/privacy}","received_events_url":"https://api.github.com/users/tylernisonoff/received_events","type":"User","site_admin":false},"repo":{"id":37835378,"name":"mrjob","full_name":"tylernisonoff/mrjob","owner":{"login":"tylernisonoff","id":1152284,"avatar_url":"https://avatars.githubusercontent.com/u/1152284?v=3","gravatar_id":"","url":"https://api.github.com/users/tylernisonoff","html_url":"https://github.com/tylernisonoff","followers_url":"https://api.github.com/users/tylernisonoff/followers","following_url":"https://api.github.com/users/tylernisonoff/following{/other_user}","gists_url":"https://api.github.com/users/tylernisonoff/gists{/gist_id}","starred_url":"https://api.github.com/users/tylernisonoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylernisonoff/subscriptions","organizations_url":"https://api.github.com/users/tylernisonoff/orgs","repos_url":"https://api.github.com/users/tylernisonoff/repos","events_url":"https://api.github.com/users/tylernisonoff/events{/privacy}","received_events_url":"https://api.github.com/users/tylernisonoff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tylernisonoff/mrjob","description":"Run MapReduce jobs on Hadoop or Amazon Web Services","fork":true,"url":"https://api.github.com/repos/tylernisonoff/mrjob","forks_url":"https://api.github.com/repos/tylernisonoff/mrjob/forks","keys_url":"https://api.github.com/repos/tylernisonoff/mrjob/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tylernisonoff/mrjob/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tylernisonoff/mrjob/teams","hooks_url":"https://api.github.com/repos/tylernisonoff/mrjob/hooks","issue_events_url":"https://api.github.com/repos/tylernisonoff/mrjob/issues/events{/number}","events_url":"https://api.github.com/repos/tylernisonoff/mrjob/events","assignees_url":"https://api.github.com/repos/tylernisonoff/mrjob/assignees{/user}","branches_url":"https://api.github.com/repos/tylernisonoff/mrjob/branches{/branch}","tags_url":"https://api.github.com/repos/tylernisonoff/mrjob/tags","blobs_url":"https://api.github.com/repos/tylernisonoff/mrjob/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tylernisonoff/mrjob/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tylernisonoff/mrjob/git/refs{/sha}","trees_url":"https://api.github.com/repos/tylernisonoff/mrjob/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tylernisonoff/mrjob/statuses/{sha}","languages_url":"https://api.github.com/repos/tylernisonoff/mrjob/languages","stargazers_url":"https://api.github.com/repos/tylernisonoff/mrjob/stargazers","contributors_url":"https://api.github.com/repos/tylernisonoff/mrjob/contributors","subscribers_url":"https://api.github.com/repos/tylernisonoff/mrjob/subscribers","subscription_url":"https://api.github.com/repos/tylernisonoff/mrjob/subscription","commits_url":"https://api.github.com/repos/tylernisonoff/mrjob/commits{/sha}","git_commits_url":"https://api.github.com/repos/tylernisonoff/mrjob/git/commits{/sha}","comments_url":"https://api.github.com/repos/tylernisonoff/mrjob/comments{/number}","issue_comment_url":"https://api.github.com/repos/tylernisonoff/mrjob/issues/comments{/number}","contents_url":"https://api.github.com/repos/tylernisonoff/mrjob/contents/{+path}","compare_url":"https://api.github.com/repos/tylernisonoff/mrjob/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tylernisonoff/mrjob/merges","archive_url":"https://api.github.com/repos/tylernisonoff/mrjob/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tylernisonoff/mrjob/downloads","issues_url":"https://api.github.com/repos/tylernisonoff/mrjob/issues{/number}","pulls_url":"https://api.github.com/repos/tylernisonoff/mrjob/pulls{/number}","milestones_url":"https://api.github.com/repos/tylernisonoff/mrjob/milestones{/number}","notifications_url":"https://api.github.com/repos/tylernisonoff/mrjob/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tylernisonoff/mrjob/labels{/name}","releases_url":"https://api.github.com/repos/tylernisonoff/mrjob/releases{/id}","created_at":"2015-06-22T03:04:15Z","updated_at":"2015-06-22T03:04:16Z","pushed_at":"2015-06-22T03:06:58Z","git_url":"git://github.com/tylernisonoff/mrjob.git","ssh_url":"git@github.com:tylernisonoff/mrjob.git","clone_url":"https://github.com/tylernisonoff/mrjob.git","svn_url":"https://github.com/tylernisonoff/mrjob","homepage":"http://packages.python.org/mrjob/","size":13630,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Yelp:master","ref":"master","sha":"198035a5bfcd99db1bf84b35a8cfe83ee0f38e02","user":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":984742,"name":"mrjob","full_name":"Yelp/mrjob","owner":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/mrjob","description":"Run MapReduce jobs on Hadoop or Amazon Web Services","fork":false,"url":"https://api.github.com/repos/Yelp/mrjob","forks_url":"https://api.github.com/repos/Yelp/mrjob/forks","keys_url":"https://api.github.com/repos/Yelp/mrjob/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/mrjob/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/mrjob/teams","hooks_url":"https://api.github.com/repos/Yelp/mrjob/hooks","issue_events_url":"https://api.github.com/repos/Yelp/mrjob/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/mrjob/events","assignees_url":"https://api.github.com/repos/Yelp/mrjob/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/mrjob/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/mrjob/tags","blobs_url":"https://api.github.com/repos/Yelp/mrjob/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/mrjob/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/mrjob/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/mrjob/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/mrjob/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/mrjob/languages","stargazers_url":"https://api.github.com/repos/Yelp/mrjob/stargazers","contributors_url":"https://api.github.com/repos/Yelp/mrjob/contributors","subscribers_url":"https://api.github.com/repos/Yelp/mrjob/subscribers","subscription_url":"https://api.github.com/repos/Yelp/mrjob/subscription","commits_url":"https://api.github.com/repos/Yelp/mrjob/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/mrjob/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/mrjob/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/mrjob/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/mrjob/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/mrjob/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/mrjob/merges","archive_url":"https://api.github.com/repos/Yelp/mrjob/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/mrjob/downloads","issues_url":"https://api.github.com/repos/Yelp/mrjob/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/mrjob/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/mrjob/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/mrjob/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/mrjob/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/mrjob/releases{/id}","created_at":"2010-10-13T18:35:21Z","updated_at":"2015-06-21T19:47:01Z","pushed_at":"2015-06-18T23:01:51Z","git_url":"git://github.com/Yelp/mrjob.git","ssh_url":"git@github.com:Yelp/mrjob.git","clone_url":"https://github.com/Yelp/mrjob.git","svn_url":"https://github.com/Yelp/mrjob","homepage":"http://packages.python.org/mrjob/","size":13630,"stargazers_count":1466,"watchers_count":1466,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":372,"mirror_url":null,"open_issues_count":169,"forks":372,"open_issues":169,"watchers":1466,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Yelp/mrjob/pulls/1048"},"html":{"href":"https://github.com/Yelp/mrjob/pull/1048"},"issue":{"href":"https://api.github.com/repos/Yelp/mrjob/issues/1048"},"comments":{"href":"https://api.github.com/repos/Yelp/mrjob/issues/1048/comments"},"review_comments":{"href":"https://api.github.com/repos/Yelp/mrjob/pulls/1048/comments"},"review_comment":{"href":"https://api.github.com/repos/Yelp/mrjob/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yelp/mrjob/pulls/1048/commits"},"statuses":{"href":"https://api.github.com/repos/Yelp/mrjob/statuses/ed128864d894433ed013bd5449df2131fbb67ba1"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":7,"changed_files":2}}