{"action":"created","issue":{"url":"https://api.github.com/repos/adobe/brackets/issues/10859","labels_url":"https://api.github.com/repos/adobe/brackets/issues/10859/labels{/name}","comments_url":"https://api.github.com/repos/adobe/brackets/issues/10859/comments","events_url":"https://api.github.com/repos/adobe/brackets/issues/10859/events","html_url":"https://github.com/adobe/brackets/pull/10859","id":67307350,"number":10859,"title":"Code folding UI & code style tweaks","user":{"login":"peterflynn","id":1197510,"avatar_url":"https://avatars.githubusercontent.com/u/1197510?v=3","gravatar_id":"","url":"https://api.github.com/users/peterflynn","html_url":"https://github.com/peterflynn","followers_url":"https://api.github.com/users/peterflynn/followers","following_url":"https://api.github.com/users/peterflynn/following{/other_user}","gists_url":"https://api.github.com/users/peterflynn/gists{/gist_id}","starred_url":"https://api.github.com/users/peterflynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterflynn/subscriptions","organizations_url":"https://api.github.com/users/peterflynn/orgs","repos_url":"https://api.github.com/users/peterflynn/repos","events_url":"https://api.github.com/users/peterflynn/events{/privacy}","received_events_url":"https://api.github.com/users/peterflynn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/adobe/brackets/milestones/35","html_url":"https://github.com/adobe/brackets/milestones/Release%201.3","labels_url":"https://api.github.com/repos/adobe/brackets/milestones/35/labels","id":931685,"number":35,"title":"Release 1.3","description":"","creator":{"login":"pthiess","id":1584287,"avatar_url":"https://avatars.githubusercontent.com/u/1584287?v=3","gravatar_id":"","url":"https://api.github.com/users/pthiess","html_url":"https://github.com/pthiess","followers_url":"https://api.github.com/users/pthiess/followers","following_url":"https://api.github.com/users/pthiess/following{/other_user}","gists_url":"https://api.github.com/users/pthiess/gists{/gist_id}","starred_url":"https://api.github.com/users/pthiess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pthiess/subscriptions","organizations_url":"https://api.github.com/users/pthiess/orgs","repos_url":"https://api.github.com/users/pthiess/repos","events_url":"https://api.github.com/users/pthiess/events{/privacy}","received_events_url":"https://api.github.com/users/pthiess/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":25,"state":"open","created_at":"2015-01-12T15:46:53Z","updated_at":"2015-04-10T19:47:50Z","due_on":"2015-04-15T18:30:00Z","closed_at":null},"comments":13,"created_at":"2015-04-09T08:26:38Z","updated_at":"2015-04-12T15:23:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/adobe/brackets/pulls/10859","html_url":"https://github.com/adobe/brackets/pull/10859","diff_url":"https://github.com/adobe/brackets/pull/10859.diff","patch_url":"https://github.com/adobe/brackets/pull/10859.patch"},"body":"**Do not merge yet** - we should land PR #10850 first, and then the diff for this will be simplified.\r\n\r\nFor now, this link previews what the diff will be after 10850 lands: https://github.com/thehogfather/brackets/compare/issue10846...adobe:pflynn/codefolding-tweaks\r\n\r\nImprove visual appearance of code folding:\r\n\r\n- Fainter, smaller gutter triangle icons\r\n- Gutter triangle icons become less faint on mouseover (or when collapsed)\r\n- Vertically align gutter triangle icons with text better\r\n- Change inline collapsed placeholder to more readable arrow icon\r\n- Better colors in dark theme\r\n- Less horizontal gap between line numbers and triangle icons (without reducing gap between line numbers and text, if folding gutter disabled)\r\n\r\nUsability: rename `\"fadeFoldButtons\"` pref to clearer `\"hideUntilMouseover\"`\r\n\r\nAnd tweak code style issues:\r\n- Remove most of ignored, unneeded package.json\r\n- Preserve original CodeMirror copyright on CM-derived files\r\n- Rename a few things for clarity\r\n- Remove some unneeded code\r\n- Tweak formatting & spelling in comments\r\n\r\n**Update - adds a few more fixes/cleanups:**\r\n\r\nMore rigorous enable/disable flow for code folding: instead of piecemeal checking whether each bit has already initialized, atomically track whether init is done yet or not. Init/deinit all extant editors at once instead of doing each editor as it is activated, since splitview means editors may be already visible but not yet active. Fix listener leaks from repeated inits.\r\n\r\nAnd keep menu items in a more predictable order:\r\n\r\n- Add menu items at startup before user extensions load (at htmlReady instead of appReady), so core menu items like these don't move around as user extension load order changes\r\n- Place QuickView menu item more explicitly, so it doesn't move unpredictably relative to Code Folding menu items (within the extensions/default folder, load order is arbitrary)\r\n- Properly clean up menu divider, which used to get duplicated on each init pass"},"comment":{"url":"https://api.github.com/repos/adobe/brackets/issues/comments/92079298","html_url":"https://github.com/adobe/brackets/pull/10859#issuecomment-92079298","issue_url":"https://api.github.com/repos/adobe/brackets/issues/10859","id":92079298,"user":{"login":"abose","id":5336369,"avatar_url":"https://avatars.githubusercontent.com/u/5336369?v=3","gravatar_id":"","url":"https://api.github.com/users/abose","html_url":"https://github.com/abose","followers_url":"https://api.github.com/users/abose/followers","following_url":"https://api.github.com/users/abose/following{/other_user}","gists_url":"https://api.github.com/users/abose/gists{/gist_id}","starred_url":"https://api.github.com/users/abose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abose/subscriptions","organizations_url":"https://api.github.com/users/abose/orgs","repos_url":"https://api.github.com/users/abose/repos","events_url":"https://api.github.com/users/abose/events{/privacy}","received_events_url":"https://api.github.com/users/abose/received_events","type":"User","site_admin":false},"created_at":"2015-04-12T15:23:32Z","updated_at":"2015-04-12T15:23:32Z","body":"@peterflynn I was only fixing the unit test failures caused by the code folding extension in master.\r\n\r\nI think it's best to add an issue to add unit test cases here as this is one of the core features now."}}