{"action":"closed","number":10789,"pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/10789","id":32377432,"html_url":"https://github.com/emberjs/ember.js/pull/10789","diff_url":"https://github.com/emberjs/ember.js/pull/10789.diff","patch_url":"https://github.com/emberjs/ember.js/pull/10789.patch","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/10789","number":10789,"state":"closed","locked":false,"title":"[FEATURE ember-application-instance-initializers] Deprecation is never thrown on lookup/lookupFactory","user":{"login":"brzpegasus","id":1691398,"avatar_url":"https://avatars.githubusercontent.com/u/1691398?v=3","gravatar_id":"","url":"https://api.github.com/users/brzpegasus","html_url":"https://github.com/brzpegasus","followers_url":"https://api.github.com/users/brzpegasus/followers","following_url":"https://api.github.com/users/brzpegasus/following{/other_user}","gists_url":"https://api.github.com/users/brzpegasus/gists{/gist_id}","starred_url":"https://api.github.com/users/brzpegasus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brzpegasus/subscriptions","organizations_url":"https://api.github.com/users/brzpegasus/orgs","repos_url":"https://api.github.com/users/brzpegasus/repos","events_url":"https://api.github.com/users/brzpegasus/events{/privacy}","received_events_url":"https://api.github.com/users/brzpegasus/received_events","type":"User","site_admin":false},"body":"The deprecation is never thrown when calling `lookup` or `lookupFactory` on a registry because `Ember.deprecate` is called with an options argument but no deprecation test (the options argument is incorrectly interpreted as a truthy test value).","created_at":"2015-03-31T23:48:41Z","updated_at":"2015-04-04T16:05:36Z","closed_at":"2015-04-04T16:05:36Z","merged_at":"2015-04-04T16:05:36Z","merge_commit_sha":"1a00f218a35e5078d6b0894a4523fce7ba7a2c8a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember.js/pulls/10789/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember.js/pulls/10789/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/10789/comments","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/8f13acfc83c55d629371f25cd0e6b005ccfa6c91","head":{"label":"brzpegasus:instance-init-deprecation-warning","ref":"instance-init-deprecation-warning","sha":"8f13acfc83c55d629371f25cd0e6b005ccfa6c91","user":{"login":"brzpegasus","id":1691398,"avatar_url":"https://avatars.githubusercontent.com/u/1691398?v=3","gravatar_id":"","url":"https://api.github.com/users/brzpegasus","html_url":"https://github.com/brzpegasus","followers_url":"https://api.github.com/users/brzpegasus/followers","following_url":"https://api.github.com/users/brzpegasus/following{/other_user}","gists_url":"https://api.github.com/users/brzpegasus/gists{/gist_id}","starred_url":"https://api.github.com/users/brzpegasus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brzpegasus/subscriptions","organizations_url":"https://api.github.com/users/brzpegasus/orgs","repos_url":"https://api.github.com/users/brzpegasus/repos","events_url":"https://api.github.com/users/brzpegasus/events{/privacy}","received_events_url":"https://api.github.com/users/brzpegasus/received_events","type":"User","site_admin":false},"repo":{"id":15521313,"name":"ember.js","full_name":"brzpegasus/ember.js","owner":{"login":"brzpegasus","id":1691398,"avatar_url":"https://avatars.githubusercontent.com/u/1691398?v=3","gravatar_id":"","url":"https://api.github.com/users/brzpegasus","html_url":"https://github.com/brzpegasus","followers_url":"https://api.github.com/users/brzpegasus/followers","following_url":"https://api.github.com/users/brzpegasus/following{/other_user}","gists_url":"https://api.github.com/users/brzpegasus/gists{/gist_id}","starred_url":"https://api.github.com/users/brzpegasus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brzpegasus/subscriptions","organizations_url":"https://api.github.com/users/brzpegasus/orgs","repos_url":"https://api.github.com/users/brzpegasus/repos","events_url":"https://api.github.com/users/brzpegasus/events{/privacy}","received_events_url":"https://api.github.com/users/brzpegasus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brzpegasus/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":true,"url":"https://api.github.com/repos/brzpegasus/ember.js","forks_url":"https://api.github.com/repos/brzpegasus/ember.js/forks","keys_url":"https://api.github.com/repos/brzpegasus/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brzpegasus/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brzpegasus/ember.js/teams","hooks_url":"https://api.github.com/repos/brzpegasus/ember.js/hooks","issue_events_url":"https://api.github.com/repos/brzpegasus/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/brzpegasus/ember.js/events","assignees_url":"https://api.github.com/repos/brzpegasus/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/brzpegasus/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/brzpegasus/ember.js/tags","blobs_url":"https://api.github.com/repos/brzpegasus/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brzpegasus/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brzpegasus/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/brzpegasus/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brzpegasus/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/brzpegasus/ember.js/languages","stargazers_url":"https://api.github.com/repos/brzpegasus/ember.js/stargazers","contributors_url":"https://api.github.com/repos/brzpegasus/ember.js/contributors","subscribers_url":"https://api.github.com/repos/brzpegasus/ember.js/subscribers","subscription_url":"https://api.github.com/repos/brzpegasus/ember.js/subscription","commits_url":"https://api.github.com/repos/brzpegasus/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/brzpegasus/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/brzpegasus/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/brzpegasus/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/brzpegasus/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/brzpegasus/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brzpegasus/ember.js/merges","archive_url":"https://api.github.com/repos/brzpegasus/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brzpegasus/ember.js/downloads","issues_url":"https://api.github.com/repos/brzpegasus/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/brzpegasus/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/brzpegasus/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/brzpegasus/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brzpegasus/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/brzpegasus/ember.js/releases{/id}","created_at":"2013-12-30T05:41:31Z","updated_at":"2015-04-04T15:11:01Z","pushed_at":"2015-04-04T15:22:29Z","git_url":"git://github.com/brzpegasus/ember.js.git","ssh_url":"git@github.com:brzpegasus/ember.js.git","clone_url":"https://github.com/brzpegasus/ember.js.git","svn_url":"https://github.com/brzpegasus/ember.js","homepage":"http://www.emberjs.com","size":22252,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"0a02edd8a3fdf3591d9e39bbcb55f9b28c092da5","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1801829,"name":"ember.js","full_name":"emberjs/ember.js","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":false,"url":"https://api.github.com/repos/emberjs/ember.js","forks_url":"https://api.github.com/repos/emberjs/ember.js/forks","keys_url":"https://api.github.com/repos/emberjs/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember.js/teams","hooks_url":"https://api.github.com/repos/emberjs/ember.js/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember.js/events","assignees_url":"https://api.github.com/repos/emberjs/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember.js/tags","blobs_url":"https://api.github.com/repos/emberjs/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember.js/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember.js/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember.js/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember.js/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember.js/subscription","commits_url":"https://api.github.com/repos/emberjs/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember.js/merges","archive_url":"https://api.github.com/repos/emberjs/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember.js/downloads","issues_url":"https://api.github.com/repos/emberjs/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember.js/releases{/id}","created_at":"2011-05-25T23:39:40Z","updated_at":"2015-04-04T16:05:36Z","pushed_at":"2015-04-04T16:05:36Z","git_url":"git://github.com/emberjs/ember.js.git","ssh_url":"git@github.com:emberjs/ember.js.git","clone_url":"https://github.com/emberjs/ember.js.git","svn_url":"https://github.com/emberjs/ember.js","homepage":"http://www.emberjs.com","size":75726,"stargazers_count":13267,"watchers_count":13267,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2826,"mirror_url":null,"open_issues_count":337,"forks":2826,"open_issues":337,"watchers":13267,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/10789"},"html":{"href":"https://github.com/emberjs/ember.js/pull/10789"},"issue":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/10789"},"comments":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/10789/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/10789/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/10789/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember.js/statuses/8f13acfc83c55d629371f25cd0e6b005ccfa6c91"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars.githubusercontent.com/u/12637?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":48,"deletions":2,"changed_files":2}}