{"action":"created","comment":{"url":"https://api.github.com/repos/brucekeats/nra/pulls/comments/33462867","id":33462867,"diff_hunk":"@@ -478,24 +478,18 @@ public function getListOfUsers($credentials, &$errMsg)\n         //\n         // first lets grab all the teams\n         //\n-        $query = \"SELECT nra_users.UserID, \" .\n-                 \"       FirstName, \" .\n-                 \"       LastName, \" .\n-                 \"       TeamName \" .\n-                 \"FROM nra_users \" .\n-                 \"    LEFT JOIN nra_team_role ON (nra_users.UserID = nra_team_role.UserID) \" .\n-                 \"    LEFT JOIN nra_teams ON (nra_team_role.TeamID=nra_teams.TeamID) \";\n+\t//This new query only grabs parents if they are already assigned to a team for current season\n+\t$query = \"SELECT DISTINCT u.UserID,u.FirstName,u.LastName,t.TeamName FROM nra_users u, nra_teams t, nra_team_role r, nra_child_of c\n+\t\t\tWHERE u.UserID=c.ParentUserID AND u.UserID = r.UserID AND r.TeamID=t.TeamID\";","path":"include/dbinterface.php","position":22,"original_position":22,"commit_id":"cb0dfa094c05c2f692c42765787dae8cd3d1ac43","original_commit_id":"cb0dfa094c05c2f692c42765787dae8cd3d1ac43","user":{"login":"brucekeats","id":8771885,"avatar_url":"https://avatars.githubusercontent.com/u/8771885?v=3","gravatar_id":"","url":"https://api.github.com/users/brucekeats","html_url":"https://github.com/brucekeats","followers_url":"https://api.github.com/users/brucekeats/followers","following_url":"https://api.github.com/users/brucekeats/following{/other_user}","gists_url":"https://api.github.com/users/brucekeats/gists{/gist_id}","starred_url":"https://api.github.com/users/brucekeats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brucekeats/subscriptions","organizations_url":"https://api.github.com/users/brucekeats/orgs","repos_url":"https://api.github.com/users/brucekeats/repos","events_url":"https://api.github.com/users/brucekeats/events{/privacy}","received_events_url":"https://api.github.com/users/brucekeats/received_events","type":"User","site_admin":false},"body":"So what about teams where players have a role?  Teams with older players are a good example.  A player might be assigned a role at a particular event such as greeter or host.  Should be sort the list based on team role rather than excluding players?","created_at":"2015-06-29T13:27:15Z","updated_at":"2015-06-29T13:27:15Z","html_url":"https://github.com/brucekeats/nra/pull/14#discussion_r33462867","pull_request_url":"https://api.github.com/repos/brucekeats/nra/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/brucekeats/nra/pulls/comments/33462867"},"html":{"href":"https://github.com/brucekeats/nra/pull/14#discussion_r33462867"},"pull_request":{"href":"https://api.github.com/repos/brucekeats/nra/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/brucekeats/nra/pulls/14","id":38474268,"html_url":"https://github.com/brucekeats/nra/pull/14","diff_url":"https://github.com/brucekeats/nra/pull/14.diff","patch_url":"https://github.com/brucekeats/nra/pull/14.patch","issue_url":"https://api.github.com/repos/brucekeats/nra/issues/14","number":14,"state":"open","locked":false,"title":"Issue13","user":{"login":"daiglep","id":8892488,"avatar_url":"https://avatars.githubusercontent.com/u/8892488?v=3","gravatar_id":"","url":"https://api.github.com/users/daiglep","html_url":"https://github.com/daiglep","followers_url":"https://api.github.com/users/daiglep/followers","following_url":"https://api.github.com/users/daiglep/following{/other_user}","gists_url":"https://api.github.com/users/daiglep/gists{/gist_id}","starred_url":"https://api.github.com/users/daiglep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daiglep/subscriptions","organizations_url":"https://api.github.com/users/daiglep/orgs","repos_url":"https://api.github.com/users/daiglep/repos","events_url":"https://api.github.com/users/daiglep/events{/privacy}","received_events_url":"https://api.github.com/users/daiglep/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-24T18:48:14Z","updated_at":"2015-06-29T13:27:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d6dbfa8d3f222f9371e011ad4de6b08a72e723e2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/brucekeats/nra/pulls/14/commits","review_comments_url":"https://api.github.com/repos/brucekeats/nra/pulls/14/comments","review_comment_url":"https://api.github.com/repos/brucekeats/nra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brucekeats/nra/issues/14/comments","statuses_url":"https://api.github.com/repos/brucekeats/nra/statuses/cb0dfa094c05c2f692c42765787dae8cd3d1ac43","head":{"label":"brucekeats:issue13","ref":"issue13","sha":"cb0dfa094c05c2f692c42765787dae8cd3d1ac43","user":{"login":"brucekeats","id":8771885,"avatar_url":"https://avatars.githubusercontent.com/u/8771885?v=3","gravatar_id":"","url":"https://api.github.com/users/brucekeats","html_url":"https://github.com/brucekeats","followers_url":"https://api.github.com/users/brucekeats/followers","following_url":"https://api.github.com/users/brucekeats/following{/other_user}","gists_url":"https://api.github.com/users/brucekeats/gists{/gist_id}","starred_url":"https://api.github.com/users/brucekeats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brucekeats/subscriptions","organizations_url":"https://api.github.com/users/brucekeats/orgs","repos_url":"https://api.github.com/users/brucekeats/repos","events_url":"https://api.github.com/users/brucekeats/events{/privacy}","received_events_url":"https://api.github.com/users/brucekeats/received_events","type":"User","site_admin":false},"repo":{"id":24324225,"name":"nra","full_name":"brucekeats/nra","owner":{"login":"brucekeats","id":8771885,"avatar_url":"https://avatars.githubusercontent.com/u/8771885?v=3","gravatar_id":"","url":"https://api.github.com/users/brucekeats","html_url":"https://github.com/brucekeats","followers_url":"https://api.github.com/users/brucekeats/followers","following_url":"https://api.github.com/users/brucekeats/following{/other_user}","gists_url":"https://api.github.com/users/brucekeats/gists{/gist_id}","starred_url":"https://api.github.com/users/brucekeats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brucekeats/subscriptions","organizations_url":"https://api.github.com/users/brucekeats/orgs","repos_url":"https://api.github.com/users/brucekeats/repos","events_url":"https://api.github.com/users/brucekeats/events{/privacy}","received_events_url":"https://api.github.com/users/brucekeats/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brucekeats/nra","description":"","fork":false,"url":"https://api.github.com/repos/brucekeats/nra","forks_url":"https://api.github.com/repos/brucekeats/nra/forks","keys_url":"https://api.github.com/repos/brucekeats/nra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brucekeats/nra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brucekeats/nra/teams","hooks_url":"https://api.github.com/repos/brucekeats/nra/hooks","issue_events_url":"https://api.github.com/repos/brucekeats/nra/issues/events{/number}","events_url":"https://api.github.com/repos/brucekeats/nra/events","assignees_url":"https://api.github.com/repos/brucekeats/nra/assignees{/user}","branches_url":"https://api.github.com/repos/brucekeats/nra/branches{/branch}","tags_url":"https://api.github.com/repos/brucekeats/nra/tags","blobs_url":"https://api.github.com/repos/brucekeats/nra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brucekeats/nra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brucekeats/nra/git/refs{/sha}","trees_url":"https://api.github.com/repos/brucekeats/nra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brucekeats/nra/statuses/{sha}","languages_url":"https://api.github.com/repos/brucekeats/nra/languages","stargazers_url":"https://api.github.com/repos/brucekeats/nra/stargazers","contributors_url":"https://api.github.com/repos/brucekeats/nra/contributors","subscribers_url":"https://api.github.com/repos/brucekeats/nra/subscribers","subscription_url":"https://api.github.com/repos/brucekeats/nra/subscription","commits_url":"https://api.github.com/repos/brucekeats/nra/commits{/sha}","git_commits_url":"https://api.github.com/repos/brucekeats/nra/git/commits{/sha}","comments_url":"https://api.github.com/repos/brucekeats/nra/comments{/number}","issue_comment_url":"https://api.github.com/repos/brucekeats/nra/issues/comments{/number}","contents_url":"https://api.github.com/repos/brucekeats/nra/contents/{+path}","compare_url":"https://api.github.com/repos/brucekeats/nra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brucekeats/nra/merges","archive_url":"https://api.github.com/repos/brucekeats/nra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brucekeats/nra/downloads","issues_url":"https://api.github.com/repos/brucekeats/nra/issues{/number}","pulls_url":"https://api.github.com/repos/brucekeats/nra/pulls{/number}","milestones_url":"https://api.github.com/repos/brucekeats/nra/milestones{/number}","notifications_url":"https://api.github.com/repos/brucekeats/nra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brucekeats/nra/labels{/name}","releases_url":"https://api.github.com/repos/brucekeats/nra/releases{/id}","created_at":"2014-09-22T10:24:44Z","updated_at":"2014-09-24T10:21:05Z","pushed_at":"2015-06-28T18:11:27Z","git_url":"git://github.com/brucekeats/nra.git","ssh_url":"git@github.com:brucekeats/nra.git","clone_url":"https://github.com/brucekeats/nra.git","svn_url":"https://github.com/brucekeats/nra","homepage":null,"size":232,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"brucekeats:master","ref":"master","sha":"7629384278d0edf078880a4829a67c7c0a235a3a","user":{"login":"brucekeats","id":8771885,"avatar_url":"https://avatars.githubusercontent.com/u/8771885?v=3","gravatar_id":"","url":"https://api.github.com/users/brucekeats","html_url":"https://github.com/brucekeats","followers_url":"https://api.github.com/users/brucekeats/followers","following_url":"https://api.github.com/users/brucekeats/following{/other_user}","gists_url":"https://api.github.com/users/brucekeats/gists{/gist_id}","starred_url":"https://api.github.com/users/brucekeats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brucekeats/subscriptions","organizations_url":"https://api.github.com/users/brucekeats/orgs","repos_url":"https://api.github.com/users/brucekeats/repos","events_url":"https://api.github.com/users/brucekeats/events{/privacy}","received_events_url":"https://api.github.com/users/brucekeats/received_events","type":"User","site_admin":false},"repo":{"id":24324225,"name":"nra","full_name":"brucekeats/nra","owner":{"login":"brucekeats","id":8771885,"avatar_url":"https://avatars.githubusercontent.com/u/8771885?v=3","gravatar_id":"","url":"https://api.github.com/users/brucekeats","html_url":"https://github.com/brucekeats","followers_url":"https://api.github.com/users/brucekeats/followers","following_url":"https://api.github.com/users/brucekeats/following{/other_user}","gists_url":"https://api.github.com/users/brucekeats/gists{/gist_id}","starred_url":"https://api.github.com/users/brucekeats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brucekeats/subscriptions","organizations_url":"https://api.github.com/users/brucekeats/orgs","repos_url":"https://api.github.com/users/brucekeats/repos","events_url":"https://api.github.com/users/brucekeats/events{/privacy}","received_events_url":"https://api.github.com/users/brucekeats/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brucekeats/nra","description":"","fork":false,"url":"https://api.github.com/repos/brucekeats/nra","forks_url":"https://api.github.com/repos/brucekeats/nra/forks","keys_url":"https://api.github.com/repos/brucekeats/nra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brucekeats/nra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brucekeats/nra/teams","hooks_url":"https://api.github.com/repos/brucekeats/nra/hooks","issue_events_url":"https://api.github.com/repos/brucekeats/nra/issues/events{/number}","events_url":"https://api.github.com/repos/brucekeats/nra/events","assignees_url":"https://api.github.com/repos/brucekeats/nra/assignees{/user}","branches_url":"https://api.github.com/repos/brucekeats/nra/branches{/branch}","tags_url":"https://api.github.com/repos/brucekeats/nra/tags","blobs_url":"https://api.github.com/repos/brucekeats/nra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brucekeats/nra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brucekeats/nra/git/refs{/sha}","trees_url":"https://api.github.com/repos/brucekeats/nra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brucekeats/nra/statuses/{sha}","languages_url":"https://api.github.com/repos/brucekeats/nra/languages","stargazers_url":"https://api.github.com/repos/brucekeats/nra/stargazers","contributors_url":"https://api.github.com/repos/brucekeats/nra/contributors","subscribers_url":"https://api.github.com/repos/brucekeats/nra/subscribers","subscription_url":"https://api.github.com/repos/brucekeats/nra/subscription","commits_url":"https://api.github.com/repos/brucekeats/nra/commits{/sha}","git_commits_url":"https://api.github.com/repos/brucekeats/nra/git/commits{/sha}","comments_url":"https://api.github.com/repos/brucekeats/nra/comments{/number}","issue_comment_url":"https://api.github.com/repos/brucekeats/nra/issues/comments{/number}","contents_url":"https://api.github.com/repos/brucekeats/nra/contents/{+path}","compare_url":"https://api.github.com/repos/brucekeats/nra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brucekeats/nra/merges","archive_url":"https://api.github.com/repos/brucekeats/nra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brucekeats/nra/downloads","issues_url":"https://api.github.com/repos/brucekeats/nra/issues{/number}","pulls_url":"https://api.github.com/repos/brucekeats/nra/pulls{/number}","milestones_url":"https://api.github.com/repos/brucekeats/nra/milestones{/number}","notifications_url":"https://api.github.com/repos/brucekeats/nra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brucekeats/nra/labels{/name}","releases_url":"https://api.github.com/repos/brucekeats/nra/releases{/id}","created_at":"2014-09-22T10:24:44Z","updated_at":"2014-09-24T10:21:05Z","pushed_at":"2015-06-28T18:11:27Z","git_url":"git://github.com/brucekeats/nra.git","ssh_url":"git@github.com:brucekeats/nra.git","clone_url":"https://github.com/brucekeats/nra.git","svn_url":"https://github.com/brucekeats/nra","homepage":null,"size":232,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brucekeats/nra/pulls/14"},"html":{"href":"https://github.com/brucekeats/nra/pull/14"},"issue":{"href":"https://api.github.com/repos/brucekeats/nra/issues/14"},"comments":{"href":"https://api.github.com/repos/brucekeats/nra/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/brucekeats/nra/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/brucekeats/nra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brucekeats/nra/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/brucekeats/nra/statuses/cb0dfa094c05c2f692c42765787dae8cd3d1ac43"}}}}