{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/2624","labels_url":"https://api.github.com/repos/openshift/origin/issues/2624/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/2624/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/2624/events","html_url":"https://github.com/openshift/origin/issues/2624","id":83470501,"number":2624,"title":"builder images matches docker credentials differently","user":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/openshift/origin/labels/kind/bug","name":"kind/bug","color":"fc2929"},{"url":"https://api.github.com/repos/openshift/origin/labels/priority/P2","name":"priority/P2","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-06-01T12:35:35Z","updated_at":"2015-06-01T12:56:10Z","closed_at":null,"body":"The Kubelet matches docker credentials based on docker keyring logic that includes partial matches.  The builder images does not.  It should be updated.  See https://github.com/openshift/origin/blob/master/pkg/build/builder/cmd/dockercfg/cfg.go#L62  and https://github.com/openshift/origin/blob/master/Godeps/_workspace/src/github.com/GoogleCloudPlatform/kubernetes/pkg/credentialprovider/keyring.go#L129 .\r\n\r\n@bparees I'd call this p2.  "},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/107431923","html_url":"https://github.com/openshift/origin/issues/2624#issuecomment-107431923","issue_url":"https://api.github.com/repos/openshift/origin/issues/2624","id":107431923,"user":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"created_at":"2015-06-01T12:56:10Z","updated_at":"2015-06-01T12:56:10Z","body":"I'm not very familiar with the build code paths, but this looks like it would allow me to create a pull secret that works for regular image pulls, but fail when using it for a build because it matches URLs differently.  Is that not the case?"}}