{"action":"created","comment":{"url":"https://api.github.com/repos/astropy/astropy/pulls/comments/41795036","id":41795036,"diff_hunk":"@@ -34,13 +34,6 @@\n __all__ = ['Time', 'TimeDelta', 'TIME_SCALES', 'TIME_DELTA_SCALES',\n            'ScaleValueError', 'OperandTypeError']\n \n-try:\n-    # Not guaranteed available at setup time\n-    from . import erfa_time\n-except ImportError:\n-    if not _ASTROPY_SETUP_:\n-        raise\n-","path":"astropy/time/core.py","position":10,"original_position":10,"commit_id":"6be02b46b93df4b433ace992c88f6121acd7e890","original_commit_id":"6be02b46b93df4b433ace992c88f6121acd7e890","user":{"login":"taldcroft","id":348089,"avatar_url":"https://avatars.githubusercontent.com/u/348089?v=3","gravatar_id":"","url":"https://api.github.com/users/taldcroft","html_url":"https://github.com/taldcroft","followers_url":"https://api.github.com/users/taldcroft/followers","following_url":"https://api.github.com/users/taldcroft/following{/other_user}","gists_url":"https://api.github.com/users/taldcroft/gists{/gist_id}","starred_url":"https://api.github.com/users/taldcroft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taldcroft/subscriptions","organizations_url":"https://api.github.com/users/taldcroft/orgs","repos_url":"https://api.github.com/users/taldcroft/repos","events_url":"https://api.github.com/users/taldcroft/events{/privacy}","received_events_url":"https://api.github.com/users/taldcroft/received_events","type":"User","site_admin":false},"body":"Like I said, ignorant (or lazy) question.  :smile:","created_at":"2015-10-12T20:01:59Z","updated_at":"2015-10-12T20:01:59Z","html_url":"https://github.com/astropy/astropy/pull/4235#discussion_r41795036","pull_request_url":"https://api.github.com/repos/astropy/astropy/pulls/4235","_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments/41795036"},"html":{"href":"https://github.com/astropy/astropy/pull/4235#discussion_r41795036"},"pull_request":{"href":"https://api.github.com/repos/astropy/astropy/pulls/4235"}}},"pull_request":{"url":"https://api.github.com/repos/astropy/astropy/pulls/4235","id":47373871,"html_url":"https://github.com/astropy/astropy/pull/4235","diff_url":"https://github.com/astropy/astropy/pull/4235.diff","patch_url":"https://github.com/astropy/astropy/pull/4235.patch","issue_url":"https://api.github.com/repos/astropy/astropy/issues/4235","number":4235,"state":"open","locked":false,"title":"Remove erfa_time, replacing names with corresponding erfa ones","user":{"login":"mhvk","id":2789820,"avatar_url":"https://avatars.githubusercontent.com/u/2789820?v=3","gravatar_id":"","url":"https://api.github.com/users/mhvk","html_url":"https://github.com/mhvk","followers_url":"https://api.github.com/users/mhvk/followers","following_url":"https://api.github.com/users/mhvk/following{/other_user}","gists_url":"https://api.github.com/users/mhvk/gists{/gist_id}","starred_url":"https://api.github.com/users/mhvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhvk/subscriptions","organizations_url":"https://api.github.com/users/mhvk/orgs","repos_url":"https://api.github.com/users/mhvk/repos","events_url":"https://api.github.com/users/mhvk/events{/privacy}","received_events_url":"https://api.github.com/users/mhvk/received_events","type":"User","site_admin":false},"body":"A leftover from the overall vectorisation of `erfa`, because of which earlier work in `erfa_time` was replaced by just a list of assignments. Propagating these for `core.py` and `formats.py` means it can be removed.\r\n\r\n@taldcroft - this is straightforward, but could you have a look just to be sure?","created_at":"2015-10-11T19:43:24Z","updated_at":"2015-10-12T20:01:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5bd5241c9a275636ffa069adde14ba7ed3fdd487","assignee":{"login":"taldcroft","id":348089,"avatar_url":"https://avatars.githubusercontent.com/u/348089?v=3","gravatar_id":"","url":"https://api.github.com/users/taldcroft","html_url":"https://github.com/taldcroft","followers_url":"https://api.github.com/users/taldcroft/followers","following_url":"https://api.github.com/users/taldcroft/following{/other_user}","gists_url":"https://api.github.com/users/taldcroft/gists{/gist_id}","starred_url":"https://api.github.com/users/taldcroft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taldcroft/subscriptions","organizations_url":"https://api.github.com/users/taldcroft/orgs","repos_url":"https://api.github.com/users/taldcroft/repos","events_url":"https://api.github.com/users/taldcroft/events{/privacy}","received_events_url":"https://api.github.com/users/taldcroft/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/astropy/astropy/milestones/26","html_url":"https://github.com/astropy/astropy/milestones/v1.2.0","labels_url":"https://api.github.com/repos/astropy/astropy/milestones/26/labels","id":1114049,"number":26,"title":"v1.2.0","description":"","creator":{"login":"astrofrog","id":314716,"avatar_url":"https://avatars.githubusercontent.com/u/314716?v=3","gravatar_id":"","url":"https://api.github.com/users/astrofrog","html_url":"https://github.com/astrofrog","followers_url":"https://api.github.com/users/astrofrog/followers","following_url":"https://api.github.com/users/astrofrog/following{/other_user}","gists_url":"https://api.github.com/users/astrofrog/gists{/gist_id}","starred_url":"https://api.github.com/users/astrofrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astrofrog/subscriptions","organizations_url":"https://api.github.com/users/astrofrog/orgs","repos_url":"https://api.github.com/users/astrofrog/repos","events_url":"https://api.github.com/users/astrofrog/events{/privacy}","received_events_url":"https://api.github.com/users/astrofrog/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":0,"state":"open","created_at":"2015-05-17T16:11:47Z","updated_at":"2015-10-11T19:43:24Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/astropy/astropy/pulls/4235/commits","review_comments_url":"https://api.github.com/repos/astropy/astropy/pulls/4235/comments","review_comment_url":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astropy/astropy/issues/4235/comments","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/6be02b46b93df4b433ace992c88f6121acd7e890","head":{"label":"mhvk:time-remove-erfa-time","ref":"time-remove-erfa-time","sha":"6be02b46b93df4b433ace992c88f6121acd7e890","user":{"login":"mhvk","id":2789820,"avatar_url":"https://avatars.githubusercontent.com/u/2789820?v=3","gravatar_id":"","url":"https://api.github.com/users/mhvk","html_url":"https://github.com/mhvk","followers_url":"https://api.github.com/users/mhvk/followers","following_url":"https://api.github.com/users/mhvk/following{/other_user}","gists_url":"https://api.github.com/users/mhvk/gists{/gist_id}","starred_url":"https://api.github.com/users/mhvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhvk/subscriptions","organizations_url":"https://api.github.com/users/mhvk/orgs","repos_url":"https://api.github.com/users/mhvk/repos","events_url":"https://api.github.com/users/mhvk/events{/privacy}","received_events_url":"https://api.github.com/users/mhvk/received_events","type":"User","site_admin":false},"repo":{"id":9993739,"name":"astropy","full_name":"mhvk/astropy","owner":{"login":"mhvk","id":2789820,"avatar_url":"https://avatars.githubusercontent.com/u/2789820?v=3","gravatar_id":"","url":"https://api.github.com/users/mhvk","html_url":"https://github.com/mhvk","followers_url":"https://api.github.com/users/mhvk/followers","following_url":"https://api.github.com/users/mhvk/following{/other_user}","gists_url":"https://api.github.com/users/mhvk/gists{/gist_id}","starred_url":"https://api.github.com/users/mhvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhvk/subscriptions","organizations_url":"https://api.github.com/users/mhvk/orgs","repos_url":"https://api.github.com/users/mhvk/repos","events_url":"https://api.github.com/users/mhvk/events{/privacy}","received_events_url":"https://api.github.com/users/mhvk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mhvk/astropy","description":"Main AstroPy repository","fork":true,"url":"https://api.github.com/repos/mhvk/astropy","forks_url":"https://api.github.com/repos/mhvk/astropy/forks","keys_url":"https://api.github.com/repos/mhvk/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhvk/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhvk/astropy/teams","hooks_url":"https://api.github.com/repos/mhvk/astropy/hooks","issue_events_url":"https://api.github.com/repos/mhvk/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/mhvk/astropy/events","assignees_url":"https://api.github.com/repos/mhvk/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/mhvk/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/mhvk/astropy/tags","blobs_url":"https://api.github.com/repos/mhvk/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhvk/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhvk/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhvk/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhvk/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/mhvk/astropy/languages","stargazers_url":"https://api.github.com/repos/mhvk/astropy/stargazers","contributors_url":"https://api.github.com/repos/mhvk/astropy/contributors","subscribers_url":"https://api.github.com/repos/mhvk/astropy/subscribers","subscription_url":"https://api.github.com/repos/mhvk/astropy/subscription","commits_url":"https://api.github.com/repos/mhvk/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhvk/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhvk/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhvk/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhvk/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/mhvk/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhvk/astropy/merges","archive_url":"https://api.github.com/repos/mhvk/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhvk/astropy/downloads","issues_url":"https://api.github.com/repos/mhvk/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/mhvk/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/mhvk/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/mhvk/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhvk/astropy/labels{/name}","releases_url":"https://api.github.com/repos/mhvk/astropy/releases{/id}","created_at":"2013-05-11T02:02:37Z","updated_at":"2015-03-31T19:47:42Z","pushed_at":"2015-10-11T21:50:58Z","git_url":"git://github.com/mhvk/astropy.git","ssh_url":"git@github.com:mhvk/astropy.git","clone_url":"https://github.com/mhvk/astropy.git","svn_url":"https://github.com/mhvk/astropy","homepage":"astropy.org","size":41363,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"placeholder"}},"base":{"label":"astropy:master","ref":"master","sha":"37b53fbdb3a611cfa68191055ea4e67e46cb4ebe","user":{"login":"astropy","id":847984,"avatar_url":"https://avatars.githubusercontent.com/u/847984?v=3","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":2081289,"name":"astropy","full_name":"astropy/astropy","owner":{"login":"astropy","id":847984,"avatar_url":"https://avatars.githubusercontent.com/u/847984?v=3","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/astropy/astropy","description":"Repository for the Astropy core package","fork":false,"url":"https://api.github.com/repos/astropy/astropy","forks_url":"https://api.github.com/repos/astropy/astropy/forks","keys_url":"https://api.github.com/repos/astropy/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/astropy/teams","hooks_url":"https://api.github.com/repos/astropy/astropy/hooks","issue_events_url":"https://api.github.com/repos/astropy/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/astropy/events","assignees_url":"https://api.github.com/repos/astropy/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/astropy/tags","blobs_url":"https://api.github.com/repos/astropy/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/astropy/languages","stargazers_url":"https://api.github.com/repos/astropy/astropy/stargazers","contributors_url":"https://api.github.com/repos/astropy/astropy/contributors","subscribers_url":"https://api.github.com/repos/astropy/astropy/subscribers","subscription_url":"https://api.github.com/repos/astropy/astropy/subscription","commits_url":"https://api.github.com/repos/astropy/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/astropy/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/astropy/merges","archive_url":"https://api.github.com/repos/astropy/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/astropy/downloads","issues_url":"https://api.github.com/repos/astropy/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/astropy/labels{/name}","releases_url":"https://api.github.com/repos/astropy/astropy/releases{/id}","created_at":"2011-07-21T01:33:49Z","updated_at":"2015-10-12T16:30:38Z","pushed_at":"2015-10-12T19:12:58Z","git_url":"git://github.com/astropy/astropy.git","ssh_url":"git@github.com:astropy/astropy.git","clone_url":"https://github.com/astropy/astropy.git","svn_url":"https://github.com/astropy/astropy","homepage":"www.astropy.org","size":67997,"stargazers_count":677,"watchers_count":677,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":436,"mirror_url":null,"open_issues_count":595,"forks":436,"open_issues":595,"watchers":677,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/4235"},"html":{"href":"https://github.com/astropy/astropy/pull/4235"},"issue":{"href":"https://api.github.com/repos/astropy/astropy/issues/4235"},"comments":{"href":"https://api.github.com/repos/astropy/astropy/issues/4235/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/astropy/pulls/4235/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astropy/astropy/pulls/4235/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/astropy/statuses/6be02b46b93df4b433ace992c88f6121acd7e890"}}}}