{"action":"created","comment":{"url":"https://api.github.com/repos/opf/openproject/pulls/comments/24576791","id":24576791,"diff_hunk":"@@ -147,24 +147,16 @@ jQuery(document).ready(function($) {\n     });\n   });\n \n-  $(\"#content\").find(\"input\").each(function (index, e) {\n-    e = $(e);\n-    if (\n-        ((e.attr(\"type\") === \"text\" || e.attr(\"type\") === \"hidden\") && e.val() !== \"\" && !e.hasClass(\"select2-input\")) ||\n-        (e.attr(\"type\") === \"checkbox\" && e.attr(\"checked\"))\n-    ) {\n-      showFieldSet(e);\n+  $(\"#content\").find(\"input\").not('[type=\"radio\"]').not('[class^=\"select2-\"]').not(\".button\").not(\"[type='hidden']\").each(function(idx, element) {","path":"app/assets/javascripts/timelines_select_boxes.js","position":20,"original_position":20,"commit_id":"7aad8e565852afcac5e1e3cf27550359f67a503e","original_commit_id":"7aad8e565852afcac5e1e3cf27550359f67a503e","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Line is too long.<br>Mixed double and single quotes.","created_at":"2015-02-12T12:23:15Z","updated_at":"2015-02-12T12:23:15Z","html_url":"https://github.com/opf/openproject/pull/2492#discussion_r24576791","pull_request_url":"https://api.github.com/repos/opf/openproject/pulls/2492","_links":{"self":{"href":"https://api.github.com/repos/opf/openproject/pulls/comments/24576791"},"html":{"href":"https://github.com/opf/openproject/pull/2492#discussion_r24576791"},"pull_request":{"href":"https://api.github.com/repos/opf/openproject/pulls/2492"}}},"pull_request":{"url":"https://api.github.com/repos/opf/openproject/pulls/2492","id":28486191,"html_url":"https://github.com/opf/openproject/pull/2492","diff_url":"https://github.com/opf/openproject/pull/2492.diff","patch_url":"https://github.com/opf/openproject/pull/2492.patch","issue_url":"https://api.github.com/repos/opf/openproject/issues/2492","number":2492,"state":"open","locked":false,"title":"18329 Forms refactor based on Foundation for Apps","user":{"login":"myabc","id":755,"avatar_url":"https://avatars.githubusercontent.com/u/755?v=3","gravatar_id":"","url":"https://api.github.com/users/myabc","html_url":"https://github.com/myabc","followers_url":"https://api.github.com/users/myabc/followers","following_url":"https://api.github.com/users/myabc/following{/other_user}","gists_url":"https://api.github.com/users/myabc/gists{/gist_id}","starred_url":"https://api.github.com/users/myabc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myabc/subscriptions","organizations_url":"https://api.github.com/users/myabc/orgs","repos_url":"https://api.github.com/users/myabc/repos","events_url":"https://api.github.com/users/myabc/events{/privacy}","received_events_url":"https://api.github.com/users/myabc/received_events","type":"User","site_admin":false},"body":"Adresses:\r\n* https://community.openproject.org/work_packages/18329\r\n* https://community.openproject.org/work_packages/18454\r\n\r\nContinuation of #2294.\r\n\r\n- [x] Update, test TabularFormBuilder\r\n- [ ] Use TabularFormBuilder throughout application - @ulferts<br/> \r\n  - [x] project settings\r\n    - [x] project main attributes\r\n    - [x] project modules\r\n    - [x] categories\r\n    - [x] repositories\r\n    - [x] boards\r\n  - [x] versions\r\n       (i.e. make default)\r\n- [x] Refactor, cleanup TabularFormBuilder\r\n- [ ] Display Rails form errors correctly<br/> \r\n       (adapt or remove `ActionView::Base.wrap_with_error_span` monkey patch)\r\n- [ ] Update helpers generating forms\r\n  - [ ] CustomFieldsHelper - @ulferts\r\n  - [ ] ProjectsHelper\r\n  - [x] SettingsHelper - @myabc\r\n- [ ] Update views \r\n  - [x] Account (@myabc)\r\n  - [ ] Activities\r\n  - [x] Auth/LDAP Sources\r\n  - [x] Dependencies\r\n  - [x] Enumerations\r\n  - [x] Forum/Boards/Messages (@ulferts)\r\n  - [x] Groups\r\n  - [x] News\r\n  - [ ] Planning Type Colors\r\n  - [ ] Project Settings\r\n  - [ ] Project Types\r\n  - [x] Projects\r\n  - [ ] Reportings\r\n  - [x] Roles\r\n  - [x] Settings (@myabc)\r\n  - [x] Statuses\r\n  - [x] Status Reportings\r\n  - [ ] Time Entries\r\n  - [ ] Timelines @floriank\r\n  - [ ] Types\r\n  - [x] Users\r\n  - [ ] Versions\r\n  - [X] Wiki\r\n  - [ ] Work Packages @ulferts\r\n    - [ ] Bulk / Moves actions\r\n  - [ ] Workflows\r\n- [ ] Update OP plugins\r\n- [ ] check and fix specs \r\n\r\n---","created_at":"2015-02-02T17:27:19Z","updated_at":"2015-02-12T12:23:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"501fc88ac457c16b82cf47ba487a789c542e6c02","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opf/openproject/pulls/2492/commits","review_comments_url":"https://api.github.com/repos/opf/openproject/pulls/2492/comments","review_comment_url":"https://api.github.com/repos/opf/openproject/pulls/comments/{number}","comments_url":"https://api.github.com/repos/opf/openproject/issues/2492/comments","statuses_url":"https://api.github.com/repos/opf/openproject/statuses/7aad8e565852afcac5e1e3cf27550359f67a503e","head":{"label":"opf:feature/18329-foundation-apps-framework-forms-refactor","ref":"feature/18329-foundation-apps-framework-forms-refactor","sha":"7aad8e565852afcac5e1e3cf27550359f67a503e","user":{"login":"opf","id":1756674,"avatar_url":"https://avatars.githubusercontent.com/u/1756674?v=3","gravatar_id":"","url":"https://api.github.com/users/opf","html_url":"https://github.com/opf","followers_url":"https://api.github.com/users/opf/followers","following_url":"https://api.github.com/users/opf/following{/other_user}","gists_url":"https://api.github.com/users/opf/gists{/gist_id}","starred_url":"https://api.github.com/users/opf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opf/subscriptions","organizations_url":"https://api.github.com/users/opf/orgs","repos_url":"https://api.github.com/users/opf/repos","events_url":"https://api.github.com/users/opf/events{/privacy}","received_events_url":"https://api.github.com/users/opf/received_events","type":"Organization","site_admin":false},"repo":{"id":6899875,"name":"openproject","full_name":"opf/openproject","owner":{"login":"opf","id":1756674,"avatar_url":"https://avatars.githubusercontent.com/u/1756674?v=3","gravatar_id":"","url":"https://api.github.com/users/opf","html_url":"https://github.com/opf","followers_url":"https://api.github.com/users/opf/followers","following_url":"https://api.github.com/users/opf/following{/other_user}","gists_url":"https://api.github.com/users/opf/gists{/gist_id}","starred_url":"https://api.github.com/users/opf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opf/subscriptions","organizations_url":"https://api.github.com/users/opf/orgs","repos_url":"https://api.github.com/users/opf/repos","events_url":"https://api.github.com/users/opf/events{/privacy}","received_events_url":"https://api.github.com/users/opf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opf/openproject","description":"OpenProject is a web-based project management system built on Ruby on Rails","fork":false,"url":"https://api.github.com/repos/opf/openproject","forks_url":"https://api.github.com/repos/opf/openproject/forks","keys_url":"https://api.github.com/repos/opf/openproject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opf/openproject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opf/openproject/teams","hooks_url":"https://api.github.com/repos/opf/openproject/hooks","issue_events_url":"https://api.github.com/repos/opf/openproject/issues/events{/number}","events_url":"https://api.github.com/repos/opf/openproject/events","assignees_url":"https://api.github.com/repos/opf/openproject/assignees{/user}","branches_url":"https://api.github.com/repos/opf/openproject/branches{/branch}","tags_url":"https://api.github.com/repos/opf/openproject/tags","blobs_url":"https://api.github.com/repos/opf/openproject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opf/openproject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opf/openproject/git/refs{/sha}","trees_url":"https://api.github.com/repos/opf/openproject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opf/openproject/statuses/{sha}","languages_url":"https://api.github.com/repos/opf/openproject/languages","stargazers_url":"https://api.github.com/repos/opf/openproject/stargazers","contributors_url":"https://api.github.com/repos/opf/openproject/contributors","subscribers_url":"https://api.github.com/repos/opf/openproject/subscribers","subscription_url":"https://api.github.com/repos/opf/openproject/subscription","commits_url":"https://api.github.com/repos/opf/openproject/commits{/sha}","git_commits_url":"https://api.github.com/repos/opf/openproject/git/commits{/sha}","comments_url":"https://api.github.com/repos/opf/openproject/comments{/number}","issue_comment_url":"https://api.github.com/repos/opf/openproject/issues/comments/{number}","contents_url":"https://api.github.com/repos/opf/openproject/contents/{+path}","compare_url":"https://api.github.com/repos/opf/openproject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opf/openproject/merges","archive_url":"https://api.github.com/repos/opf/openproject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opf/openproject/downloads","issues_url":"https://api.github.com/repos/opf/openproject/issues{/number}","pulls_url":"https://api.github.com/repos/opf/openproject/pulls{/number}","milestones_url":"https://api.github.com/repos/opf/openproject/milestones{/number}","notifications_url":"https://api.github.com/repos/opf/openproject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opf/openproject/labels{/name}","releases_url":"https://api.github.com/repos/opf/openproject/releases{/id}","created_at":"2012-11-28T09:59:11Z","updated_at":"2015-02-12T10:34:45Z","pushed_at":"2015-02-12T12:23:01Z","git_url":"git://github.com/opf/openproject.git","ssh_url":"git@github.com:opf/openproject.git","clone_url":"https://github.com/opf/openproject.git","svn_url":"https://github.com/opf/openproject","homepage":"https://www.openproject.org","size":165234,"stargazers_count":504,"watchers_count":504,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":223,"mirror_url":null,"open_issues_count":71,"forks":223,"open_issues":71,"watchers":504,"default_branch":"dev"}},"base":{"label":"opf:dev","ref":"dev","sha":"533fed68f5ae090edb355dcdd7daec858cb6062e","user":{"login":"opf","id":1756674,"avatar_url":"https://avatars.githubusercontent.com/u/1756674?v=3","gravatar_id":"","url":"https://api.github.com/users/opf","html_url":"https://github.com/opf","followers_url":"https://api.github.com/users/opf/followers","following_url":"https://api.github.com/users/opf/following{/other_user}","gists_url":"https://api.github.com/users/opf/gists{/gist_id}","starred_url":"https://api.github.com/users/opf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opf/subscriptions","organizations_url":"https://api.github.com/users/opf/orgs","repos_url":"https://api.github.com/users/opf/repos","events_url":"https://api.github.com/users/opf/events{/privacy}","received_events_url":"https://api.github.com/users/opf/received_events","type":"Organization","site_admin":false},"repo":{"id":6899875,"name":"openproject","full_name":"opf/openproject","owner":{"login":"opf","id":1756674,"avatar_url":"https://avatars.githubusercontent.com/u/1756674?v=3","gravatar_id":"","url":"https://api.github.com/users/opf","html_url":"https://github.com/opf","followers_url":"https://api.github.com/users/opf/followers","following_url":"https://api.github.com/users/opf/following{/other_user}","gists_url":"https://api.github.com/users/opf/gists{/gist_id}","starred_url":"https://api.github.com/users/opf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opf/subscriptions","organizations_url":"https://api.github.com/users/opf/orgs","repos_url":"https://api.github.com/users/opf/repos","events_url":"https://api.github.com/users/opf/events{/privacy}","received_events_url":"https://api.github.com/users/opf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opf/openproject","description":"OpenProject is a web-based project management system built on Ruby on Rails","fork":false,"url":"https://api.github.com/repos/opf/openproject","forks_url":"https://api.github.com/repos/opf/openproject/forks","keys_url":"https://api.github.com/repos/opf/openproject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opf/openproject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opf/openproject/teams","hooks_url":"https://api.github.com/repos/opf/openproject/hooks","issue_events_url":"https://api.github.com/repos/opf/openproject/issues/events{/number}","events_url":"https://api.github.com/repos/opf/openproject/events","assignees_url":"https://api.github.com/repos/opf/openproject/assignees{/user}","branches_url":"https://api.github.com/repos/opf/openproject/branches{/branch}","tags_url":"https://api.github.com/repos/opf/openproject/tags","blobs_url":"https://api.github.com/repos/opf/openproject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opf/openproject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opf/openproject/git/refs{/sha}","trees_url":"https://api.github.com/repos/opf/openproject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opf/openproject/statuses/{sha}","languages_url":"https://api.github.com/repos/opf/openproject/languages","stargazers_url":"https://api.github.com/repos/opf/openproject/stargazers","contributors_url":"https://api.github.com/repos/opf/openproject/contributors","subscribers_url":"https://api.github.com/repos/opf/openproject/subscribers","subscription_url":"https://api.github.com/repos/opf/openproject/subscription","commits_url":"https://api.github.com/repos/opf/openproject/commits{/sha}","git_commits_url":"https://api.github.com/repos/opf/openproject/git/commits{/sha}","comments_url":"https://api.github.com/repos/opf/openproject/comments{/number}","issue_comment_url":"https://api.github.com/repos/opf/openproject/issues/comments/{number}","contents_url":"https://api.github.com/repos/opf/openproject/contents/{+path}","compare_url":"https://api.github.com/repos/opf/openproject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opf/openproject/merges","archive_url":"https://api.github.com/repos/opf/openproject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opf/openproject/downloads","issues_url":"https://api.github.com/repos/opf/openproject/issues{/number}","pulls_url":"https://api.github.com/repos/opf/openproject/pulls{/number}","milestones_url":"https://api.github.com/repos/opf/openproject/milestones{/number}","notifications_url":"https://api.github.com/repos/opf/openproject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opf/openproject/labels{/name}","releases_url":"https://api.github.com/repos/opf/openproject/releases{/id}","created_at":"2012-11-28T09:59:11Z","updated_at":"2015-02-12T10:34:45Z","pushed_at":"2015-02-12T12:23:01Z","git_url":"git://github.com/opf/openproject.git","ssh_url":"git@github.com:opf/openproject.git","clone_url":"https://github.com/opf/openproject.git","svn_url":"https://github.com/opf/openproject","homepage":"https://www.openproject.org","size":165234,"stargazers_count":504,"watchers_count":504,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":223,"mirror_url":null,"open_issues_count":71,"forks":223,"open_issues":71,"watchers":504,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/opf/openproject/pulls/2492"},"html":{"href":"https://github.com/opf/openproject/pull/2492"},"issue":{"href":"https://api.github.com/repos/opf/openproject/issues/2492"},"comments":{"href":"https://api.github.com/repos/opf/openproject/issues/2492/comments"},"review_comments":{"href":"https://api.github.com/repos/opf/openproject/pulls/2492/comments"},"review_comment":{"href":"https://api.github.com/repos/opf/openproject/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/opf/openproject/pulls/2492/commits"},"statuses":{"href":"https://api.github.com/repos/opf/openproject/statuses/7aad8e565852afcac5e1e3cf27550359f67a503e"}}}}