{"action":"created","comment":{"url":"https://api.github.com/repos/gemini-testing/gemini/pulls/comments/44019317","id":44019317,"diff_hunk":"@@ -0,0 +1,154 @@\n+'use strict';","path":"lib/suite-builder.js","position":1,"original_position":1,"commit_id":"d10079894c490c87d38103b7aff6ccccebaa2959","original_commit_id":"d10079894c490c87d38103b7aff6ccccebaa2959","user":{"login":"SwinX","id":854899,"avatar_url":"https://avatars.githubusercontent.com/u/854899?v=3","gravatar_id":"","url":"https://api.github.com/users/SwinX","html_url":"https://github.com/SwinX","followers_url":"https://api.github.com/users/SwinX/followers","following_url":"https://api.github.com/users/SwinX/following{/other_user}","gists_url":"https://api.github.com/users/SwinX/gists{/gist_id}","starred_url":"https://api.github.com/users/SwinX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SwinX/subscriptions","organizations_url":"https://api.github.com/users/SwinX/orgs","repos_url":"https://api.github.com/users/SwinX/repos","events_url":"https://api.github.com/users/SwinX/events{/privacy}","received_events_url":"https://api.github.com/users/SwinX/received_events","type":"User","site_admin":false},"body":"Why moving suite-builder to separate file? This is private part of suite API, it may not be needed anywhere externally.","created_at":"2015-11-05T14:51:30Z","updated_at":"2015-11-05T14:51:30Z","html_url":"https://github.com/gemini-testing/gemini/pull/284#discussion_r44019317","pull_request_url":"https://api.github.com/repos/gemini-testing/gemini/pulls/284","_links":{"self":{"href":"https://api.github.com/repos/gemini-testing/gemini/pulls/comments/44019317"},"html":{"href":"https://github.com/gemini-testing/gemini/pull/284#discussion_r44019317"},"pull_request":{"href":"https://api.github.com/repos/gemini-testing/gemini/pulls/284"}}},"pull_request":{"url":"https://api.github.com/repos/gemini-testing/gemini/pulls/284","id":49628686,"html_url":"https://github.com/gemini-testing/gemini/pull/284","diff_url":"https://github.com/gemini-testing/gemini/pull/284.diff","patch_url":"https://github.com/gemini-testing/gemini/pull/284.patch","issue_url":"https://api.github.com/repos/gemini-testing/gemini/issues/284","number":284,"state":"open","locked":false,"title":"[WIP] Custom functions","user":{"login":"fenduru","id":1354771,"avatar_url":"https://avatars.githubusercontent.com/u/1354771?v=3","gravatar_id":"","url":"https://api.github.com/users/fenduru","html_url":"https://github.com/fenduru","followers_url":"https://api.github.com/users/fenduru/followers","following_url":"https://api.github.com/users/fenduru/following{/other_user}","gists_url":"https://api.github.com/users/fenduru/gists{/gist_id}","starred_url":"https://api.github.com/users/fenduru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fenduru/subscriptions","organizations_url":"https://api.github.com/users/fenduru/orgs","repos_url":"https://api.github.com/users/fenduru/repos","events_url":"https://api.github.com/users/fenduru/events{/privacy}","received_events_url":"https://api.github.com/users/fenduru/received_events","type":"User","site_admin":false},"body":"130df9b is only there because I needed it for testing in my application. It will be removed before this is merged, but check out #282 \r\n\r\nJust want to get some eyes on this to make sure the approach is generally okay. I decided to go with a decorator approach rather than something like `addCustomFunction` because it is more flexible. In my particular use case, I want to override the existing `capture` function, so I need to store a copy of it first.\r\n\r\nI will add tests and docs if this looks okay.\r\n\r\nFixes #197 ","created_at":"2015-11-03T23:34:53Z","updated_at":"2015-11-05T14:51:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"962b78397d0905d98528dbbe70113ab7507e07e0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gemini-testing/gemini/pulls/284/commits","review_comments_url":"https://api.github.com/repos/gemini-testing/gemini/pulls/284/comments","review_comment_url":"https://api.github.com/repos/gemini-testing/gemini/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gemini-testing/gemini/issues/284/comments","statuses_url":"https://api.github.com/repos/gemini-testing/gemini/statuses/d10079894c490c87d38103b7aff6ccccebaa2959","head":{"label":"fenduru:custom-functions","ref":"custom-functions","sha":"d10079894c490c87d38103b7aff6ccccebaa2959","user":{"login":"fenduru","id":1354771,"avatar_url":"https://avatars.githubusercontent.com/u/1354771?v=3","gravatar_id":"","url":"https://api.github.com/users/fenduru","html_url":"https://github.com/fenduru","followers_url":"https://api.github.com/users/fenduru/followers","following_url":"https://api.github.com/users/fenduru/following{/other_user}","gists_url":"https://api.github.com/users/fenduru/gists{/gist_id}","starred_url":"https://api.github.com/users/fenduru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fenduru/subscriptions","organizations_url":"https://api.github.com/users/fenduru/orgs","repos_url":"https://api.github.com/users/fenduru/repos","events_url":"https://api.github.com/users/fenduru/events{/privacy}","received_events_url":"https://api.github.com/users/fenduru/received_events","type":"User","site_admin":false},"repo":{"id":45412749,"name":"gemini","full_name":"fenduru/gemini","owner":{"login":"fenduru","id":1354771,"avatar_url":"https://avatars.githubusercontent.com/u/1354771?v=3","gravatar_id":"","url":"https://api.github.com/users/fenduru","html_url":"https://github.com/fenduru","followers_url":"https://api.github.com/users/fenduru/followers","following_url":"https://api.github.com/users/fenduru/following{/other_user}","gists_url":"https://api.github.com/users/fenduru/gists{/gist_id}","starred_url":"https://api.github.com/users/fenduru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fenduru/subscriptions","organizations_url":"https://api.github.com/users/fenduru/orgs","repos_url":"https://api.github.com/users/fenduru/repos","events_url":"https://api.github.com/users/fenduru/events{/privacy}","received_events_url":"https://api.github.com/users/fenduru/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fenduru/gemini","description":"Utility for regression testing of web pages using screenshots","fork":true,"url":"https://api.github.com/repos/fenduru/gemini","forks_url":"https://api.github.com/repos/fenduru/gemini/forks","keys_url":"https://api.github.com/repos/fenduru/gemini/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fenduru/gemini/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fenduru/gemini/teams","hooks_url":"https://api.github.com/repos/fenduru/gemini/hooks","issue_events_url":"https://api.github.com/repos/fenduru/gemini/issues/events{/number}","events_url":"https://api.github.com/repos/fenduru/gemini/events","assignees_url":"https://api.github.com/repos/fenduru/gemini/assignees{/user}","branches_url":"https://api.github.com/repos/fenduru/gemini/branches{/branch}","tags_url":"https://api.github.com/repos/fenduru/gemini/tags","blobs_url":"https://api.github.com/repos/fenduru/gemini/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fenduru/gemini/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fenduru/gemini/git/refs{/sha}","trees_url":"https://api.github.com/repos/fenduru/gemini/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fenduru/gemini/statuses/{sha}","languages_url":"https://api.github.com/repos/fenduru/gemini/languages","stargazers_url":"https://api.github.com/repos/fenduru/gemini/stargazers","contributors_url":"https://api.github.com/repos/fenduru/gemini/contributors","subscribers_url":"https://api.github.com/repos/fenduru/gemini/subscribers","subscription_url":"https://api.github.com/repos/fenduru/gemini/subscription","commits_url":"https://api.github.com/repos/fenduru/gemini/commits{/sha}","git_commits_url":"https://api.github.com/repos/fenduru/gemini/git/commits{/sha}","comments_url":"https://api.github.com/repos/fenduru/gemini/comments{/number}","issue_comment_url":"https://api.github.com/repos/fenduru/gemini/issues/comments{/number}","contents_url":"https://api.github.com/repos/fenduru/gemini/contents/{+path}","compare_url":"https://api.github.com/repos/fenduru/gemini/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fenduru/gemini/merges","archive_url":"https://api.github.com/repos/fenduru/gemini/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fenduru/gemini/downloads","issues_url":"https://api.github.com/repos/fenduru/gemini/issues{/number}","pulls_url":"https://api.github.com/repos/fenduru/gemini/pulls{/number}","milestones_url":"https://api.github.com/repos/fenduru/gemini/milestones{/number}","notifications_url":"https://api.github.com/repos/fenduru/gemini/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fenduru/gemini/labels{/name}","releases_url":"https://api.github.com/repos/fenduru/gemini/releases{/id}","created_at":"2015-11-02T18:12:25Z","updated_at":"2015-11-02T18:12:26Z","pushed_at":"2015-11-03T23:41:43Z","git_url":"git://github.com/fenduru/gemini.git","ssh_url":"git@github.com:fenduru/gemini.git","clone_url":"https://github.com/fenduru/gemini.git","svn_url":"https://github.com/fenduru/gemini","homepage":null,"size":1150,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gemini-testing:master","ref":"master","sha":"81b779834473bfc2fb893aa2663b4d3a9580280c","user":{"login":"gemini-testing","id":11424134,"avatar_url":"https://avatars.githubusercontent.com/u/11424134?v=3","gravatar_id":"","url":"https://api.github.com/users/gemini-testing","html_url":"https://github.com/gemini-testing","followers_url":"https://api.github.com/users/gemini-testing/followers","following_url":"https://api.github.com/users/gemini-testing/following{/other_user}","gists_url":"https://api.github.com/users/gemini-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-testing/subscriptions","organizations_url":"https://api.github.com/users/gemini-testing/orgs","repos_url":"https://api.github.com/users/gemini-testing/repos","events_url":"https://api.github.com/users/gemini-testing/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-testing/received_events","type":"Organization","site_admin":false},"repo":{"id":16734168,"name":"gemini","full_name":"gemini-testing/gemini","owner":{"login":"gemini-testing","id":11424134,"avatar_url":"https://avatars.githubusercontent.com/u/11424134?v=3","gravatar_id":"","url":"https://api.github.com/users/gemini-testing","html_url":"https://github.com/gemini-testing","followers_url":"https://api.github.com/users/gemini-testing/followers","following_url":"https://api.github.com/users/gemini-testing/following{/other_user}","gists_url":"https://api.github.com/users/gemini-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-testing/subscriptions","organizations_url":"https://api.github.com/users/gemini-testing/orgs","repos_url":"https://api.github.com/users/gemini-testing/repos","events_url":"https://api.github.com/users/gemini-testing/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-testing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gemini-testing/gemini","description":"Utility for regression testing of web pages using screenshots","fork":false,"url":"https://api.github.com/repos/gemini-testing/gemini","forks_url":"https://api.github.com/repos/gemini-testing/gemini/forks","keys_url":"https://api.github.com/repos/gemini-testing/gemini/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gemini-testing/gemini/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gemini-testing/gemini/teams","hooks_url":"https://api.github.com/repos/gemini-testing/gemini/hooks","issue_events_url":"https://api.github.com/repos/gemini-testing/gemini/issues/events{/number}","events_url":"https://api.github.com/repos/gemini-testing/gemini/events","assignees_url":"https://api.github.com/repos/gemini-testing/gemini/assignees{/user}","branches_url":"https://api.github.com/repos/gemini-testing/gemini/branches{/branch}","tags_url":"https://api.github.com/repos/gemini-testing/gemini/tags","blobs_url":"https://api.github.com/repos/gemini-testing/gemini/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gemini-testing/gemini/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gemini-testing/gemini/git/refs{/sha}","trees_url":"https://api.github.com/repos/gemini-testing/gemini/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gemini-testing/gemini/statuses/{sha}","languages_url":"https://api.github.com/repos/gemini-testing/gemini/languages","stargazers_url":"https://api.github.com/repos/gemini-testing/gemini/stargazers","contributors_url":"https://api.github.com/repos/gemini-testing/gemini/contributors","subscribers_url":"https://api.github.com/repos/gemini-testing/gemini/subscribers","subscription_url":"https://api.github.com/repos/gemini-testing/gemini/subscription","commits_url":"https://api.github.com/repos/gemini-testing/gemini/commits{/sha}","git_commits_url":"https://api.github.com/repos/gemini-testing/gemini/git/commits{/sha}","comments_url":"https://api.github.com/repos/gemini-testing/gemini/comments{/number}","issue_comment_url":"https://api.github.com/repos/gemini-testing/gemini/issues/comments{/number}","contents_url":"https://api.github.com/repos/gemini-testing/gemini/contents/{+path}","compare_url":"https://api.github.com/repos/gemini-testing/gemini/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gemini-testing/gemini/merges","archive_url":"https://api.github.com/repos/gemini-testing/gemini/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gemini-testing/gemini/downloads","issues_url":"https://api.github.com/repos/gemini-testing/gemini/issues{/number}","pulls_url":"https://api.github.com/repos/gemini-testing/gemini/pulls{/number}","milestones_url":"https://api.github.com/repos/gemini-testing/gemini/milestones{/number}","notifications_url":"https://api.github.com/repos/gemini-testing/gemini/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gemini-testing/gemini/labels{/name}","releases_url":"https://api.github.com/repos/gemini-testing/gemini/releases{/id}","created_at":"2014-02-11T14:58:41Z","updated_at":"2015-11-05T09:51:20Z","pushed_at":"2015-11-05T14:02:02Z","git_url":"git://github.com/gemini-testing/gemini.git","ssh_url":"git@github.com:gemini-testing/gemini.git","clone_url":"https://github.com/gemini-testing/gemini.git","svn_url":"https://github.com/gemini-testing/gemini","homepage":null,"size":4358,"stargazers_count":455,"watchers_count":455,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"open_issues_count":64,"forks":53,"open_issues":64,"watchers":455,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gemini-testing/gemini/pulls/284"},"html":{"href":"https://github.com/gemini-testing/gemini/pull/284"},"issue":{"href":"https://api.github.com/repos/gemini-testing/gemini/issues/284"},"comments":{"href":"https://api.github.com/repos/gemini-testing/gemini/issues/284/comments"},"review_comments":{"href":"https://api.github.com/repos/gemini-testing/gemini/pulls/284/comments"},"review_comment":{"href":"https://api.github.com/repos/gemini-testing/gemini/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gemini-testing/gemini/pulls/284/commits"},"statuses":{"href":"https://api.github.com/repos/gemini-testing/gemini/statuses/d10079894c490c87d38103b7aff6ccccebaa2959"}}}}