{"action":"created","issue":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/2793","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/2793/labels{/name}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/2793/comments","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/2793/events","html_url":"https://github.com/RIOT-OS/RIOT/pull/2793","id":67879796,"number":2793,"title":"Tests: Creating unittests for the hash_string module","user":{"login":"kushalsingh007","id":6381935,"avatar_url":"https://avatars.githubusercontent.com/u/6381935?v=3","gravatar_id":"","url":"https://api.github.com/users/kushalsingh007","html_url":"https://github.com/kushalsingh007","followers_url":"https://api.github.com/users/kushalsingh007/followers","following_url":"https://api.github.com/users/kushalsingh007/following{/other_user}","gists_url":"https://api.github.com/users/kushalsingh007/gists{/gist_id}","starred_url":"https://api.github.com/users/kushalsingh007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kushalsingh007/subscriptions","organizations_url":"https://api.github.com/users/kushalsingh007/orgs","repos_url":"https://api.github.com/users/kushalsingh007/repos","events_url":"https://api.github.com/users/kushalsingh007/events{/privacy}","received_events_url":"https://api.github.com/users/kushalsingh007/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/tests","name":"tests","color":"0052cc"}],"state":"open","locked":false,"assignee":{"login":"Kijewski","id":136776,"avatar_url":"https://avatars.githubusercontent.com/u/136776?v=3","gravatar_id":"","url":"https://api.github.com/users/Kijewski","html_url":"https://github.com/Kijewski","followers_url":"https://api.github.com/users/Kijewski/followers","following_url":"https://api.github.com/users/Kijewski/following{/other_user}","gists_url":"https://api.github.com/users/Kijewski/gists{/gist_id}","starred_url":"https://api.github.com/users/Kijewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kijewski/subscriptions","organizations_url":"https://api.github.com/users/Kijewski/orgs","repos_url":"https://api.github.com/users/Kijewski/repos","events_url":"https://api.github.com/users/Kijewski/events{/privacy}","received_events_url":"https://api.github.com/users/Kijewski/received_events","type":"User","site_admin":false},"milestone":null,"comments":7,"created_at":"2015-04-12T06:51:25Z","updated_at":"2015-04-13T07:20:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2793","html_url":"https://github.com/RIOT-OS/RIOT/pull/2793","diff_url":"https://github.com/RIOT-OS/RIOT/pull/2793.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/2793.patch"},"body":"- Created unittests for hash_string module present in sys/hash_string\r\n- Fixes a part of #1131\r\n- Created a new PR because of some problems in my previous branch for #2698 "},"comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments/92246311","html_url":"https://github.com/RIOT-OS/RIOT/pull/2793#issuecomment-92246311","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/2793","id":92246311,"user":{"login":"authmillenon","id":675644,"avatar_url":"https://avatars.githubusercontent.com/u/675644?v=3","gravatar_id":"","url":"https://api.github.com/users/authmillenon","html_url":"https://github.com/authmillenon","followers_url":"https://api.github.com/users/authmillenon/followers","following_url":"https://api.github.com/users/authmillenon/following{/other_user}","gists_url":"https://api.github.com/users/authmillenon/gists{/gist_id}","starred_url":"https://api.github.com/users/authmillenon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/authmillenon/subscriptions","organizations_url":"https://api.github.com/users/authmillenon/orgs","repos_url":"https://api.github.com/users/authmillenon/repos","events_url":"https://api.github.com/users/authmillenon/events{/privacy}","received_events_url":"https://api.github.com/users/authmillenon/received_events","type":"User","site_admin":false},"created_at":"2015-04-13T07:20:44Z","updated_at":"2015-04-13T07:20:44Z","body":"Please don't squash until we explicitly say so. Unsquashed commits help us to track your changes and speed up the code review. To your points: yes it would be great if the contributers could control Travis too, but sadly they can't. I try to kill obsoleted builds whenever I see them, but even I have to sleep sometime. I think the best thing you can do right now is not to push everytime you commit something, but only when you are done ;). \r\nOn your second point: I'm personally against it. At least with my PRs I can see that it builds for all boards even before the review process is done, not just on the finish line. "}}