{"action":"created","issue":{"url":"https://api.github.com/repos/choderalab/openpathsampling/issues/304","labels_url":"https://api.github.com/repos/choderalab/openpathsampling/issues/304/labels{/name}","comments_url":"https://api.github.com/repos/choderalab/openpathsampling/issues/304/comments","events_url":"https://api.github.com/repos/choderalab/openpathsampling/issues/304/events","html_url":"https://github.com/choderalab/openpathsampling/pull/304","id":104784908,"number":304,"title":"Support for PyEmma Featurizer","user":{"login":"jhprinz","id":5091934,"avatar_url":"https://avatars.githubusercontent.com/u/5091934?v=3","gravatar_id":"","url":"https://api.github.com/users/jhprinz","html_url":"https://github.com/jhprinz","followers_url":"https://api.github.com/users/jhprinz/followers","following_url":"https://api.github.com/users/jhprinz/following{/other_user}","gists_url":"https://api.github.com/users/jhprinz/gists{/gist_id}","starred_url":"https://api.github.com/users/jhprinz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhprinz/subscriptions","organizations_url":"https://api.github.com/users/jhprinz/orgs","repos_url":"https://api.github.com/users/jhprinz/repos","events_url":"https://api.github.com/users/jhprinz/events{/privacy}","received_events_url":"https://api.github.com/users/jhprinz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-09-03T21:24:14Z","updated_at":"2015-11-03T16:05:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/choderalab/openpathsampling/pulls/304","html_url":"https://github.com/choderalab/openpathsampling/pull/304","diff_url":"https://github.com/choderalab/openpathsampling/pull/304.diff","patch_url":"https://github.com/choderalab/openpathsampling/pull/304.patch"},"body":"This is add support for usage of the PyEmma featurizer. This complements support for mdtraj and msmbuilder featurizer. All of these can be stored (using a little trick) since storing code is general a little tricky.\r\n\r\nThis PR was build on some of the other PRs before because it needed the better storage and CV support that is coming."},"comment":{"url":"https://api.github.com/repos/choderalab/openpathsampling/issues/comments/153399208","html_url":"https://github.com/choderalab/openpathsampling/pull/304#issuecomment-153399208","issue_url":"https://api.github.com/repos/choderalab/openpathsampling/issues/304","id":153399208,"user":{"login":"dwhswenson","id":8178546,"avatar_url":"https://avatars.githubusercontent.com/u/8178546?v=3","gravatar_id":"","url":"https://api.github.com/users/dwhswenson","html_url":"https://github.com/dwhswenson","followers_url":"https://api.github.com/users/dwhswenson/followers","following_url":"https://api.github.com/users/dwhswenson/following{/other_user}","gists_url":"https://api.github.com/users/dwhswenson/gists{/gist_id}","starred_url":"https://api.github.com/users/dwhswenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwhswenson/subscriptions","organizations_url":"https://api.github.com/users/dwhswenson/orgs","repos_url":"https://api.github.com/users/dwhswenson/repos","events_url":"https://api.github.com/users/dwhswenson/events{/privacy}","received_events_url":"https://api.github.com/users/dwhswenson/received_events","type":"User","site_admin":false},"created_at":"2015-11-03T16:05:11Z","updated_at":"2015-11-03T16:05:11Z","body":"> The default conda install puts PyEmma in the requirements.\r\n\r\nI keep going back and forth on this one. I definitely think it needs to be included in the Travis tests, but that can be done by installing it separately. That's probably the best approach for now: change the `.travis.yml` to include installation of PyEmma (and other things that are not required, but are supported). Since it doesn't matter whether the user installs PyEmma before of after OPS (the linking happens at runtime), it might be best to make the user install it separately.\r\n\r\n (Can't tell what you're doing now because this PR also shows all the changes from the big storage overhaul, so I won't be able to really review this until that is merged.)"}}