{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments/43379617","id":43379617,"diff_hunk":"@@ -31,30 +31,32 @@ import (\n // block, transaction and log events. The Filtering system can be used to listen\n // for specific LOG events fired by the EVM (Ethereum Virtual Machine).\n type FilterSystem struct {\n-\teventMux *event.TypeMux\n-\n \tfilterMu sync.RWMutex\n \tfilterId int\n \tfilters  map[int]*Filter\n \tcreated  map[int]time.Time\n-\n-\tquit chan struct{}\n+\tsub      event.Subscription\n }\n \n // NewFilterSystem returns a newly allocated filter manager\n func NewFilterSystem(mux *event.TypeMux) *FilterSystem {\n \tfs := &FilterSystem{\n-\t\teventMux: mux,\n-\t\tfilters:  make(map[int]*Filter),\n-\t\tcreated:  make(map[int]time.Time),\n+\t\tfilters: make(map[int]*Filter),\n+\t\tcreated: make(map[int]time.Time),\n \t}\n+\tfs.sub = mux.Subscribe(\n+\t\t//core.PendingBlockEvent{},","path":"eth/filters/filter_system.go","position":25,"original_position":25,"commit_id":"5cc34f6b7decfa5433180071a160fb775c1f36cb","original_commit_id":"5cc34f6b7decfa5433180071a160fb775c1f36cb","user":{"login":"Gustav-Simonsson","id":293096,"avatar_url":"https://avatars.githubusercontent.com/u/293096?v=3","gravatar_id":"","url":"https://api.github.com/users/Gustav-Simonsson","html_url":"https://github.com/Gustav-Simonsson","followers_url":"https://api.github.com/users/Gustav-Simonsson/followers","following_url":"https://api.github.com/users/Gustav-Simonsson/following{/other_user}","gists_url":"https://api.github.com/users/Gustav-Simonsson/gists{/gist_id}","starred_url":"https://api.github.com/users/Gustav-Simonsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gustav-Simonsson/subscriptions","organizations_url":"https://api.github.com/users/Gustav-Simonsson/orgs","repos_url":"https://api.github.com/users/Gustav-Simonsson/repos","events_url":"https://api.github.com/users/Gustav-Simonsson/events{/privacy}","received_events_url":"https://api.github.com/users/Gustav-Simonsson/received_events","type":"User","site_admin":false},"body":"Please add a comment describing why this is out commented.","created_at":"2015-10-29T12:44:12Z","updated_at":"2015-10-29T12:44:12Z","html_url":"https://github.com/ethereum/go-ethereum/pull/1946#discussion_r43379617","pull_request_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/1946","_links":{"self":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments/43379617"},"html":{"href":"https://github.com/ethereum/go-ethereum/pull/1946#discussion_r43379617"},"pull_request":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/1946"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/1946","id":49133020,"html_url":"https://github.com/ethereum/go-ethereum/pull/1946","diff_url":"https://github.com/ethereum/go-ethereum/pull/1946.diff","patch_url":"https://github.com/ethereum/go-ethereum/pull/1946.patch","issue_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/1946","number":1946,"state":"open","locked":false,"title":"Fix for xeth OOM issue","user":{"login":"fjl","id":6915,"avatar_url":"https://avatars.githubusercontent.com/u/6915?v=3","gravatar_id":"","url":"https://api.github.com/users/fjl","html_url":"https://github.com/fjl","followers_url":"https://api.github.com/users/fjl/followers","following_url":"https://api.github.com/users/fjl/following{/other_user}","gists_url":"https://api.github.com/users/fjl/gists{/gist_id}","starred_url":"https://api.github.com/users/fjl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjl/subscriptions","organizations_url":"https://api.github.com/users/fjl/orgs","repos_url":"https://api.github.com/users/fjl/repos","events_url":"https://api.github.com/users/fjl/events{/privacy}","received_events_url":"https://api.github.com/users/fjl/received_events","type":"User","site_admin":false},"body":"This PR fixes an issue where every IPC connection would leak goroutines and memory when the connection was closed.\r\nFixes #1930. I can ran the shell loop there for a few minutes and didn't see any changes in the memory profile. ","created_at":"2015-10-29T12:32:22Z","updated_at":"2015-10-29T12:44:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6adfc789661a6c80ee3b317431279081df88b23","assignee":null,"milestone":{"url":"https://api.github.com/repos/ethereum/go-ethereum/milestones/22","html_url":"https://github.com/ethereum/go-ethereum/milestones/1.3.0","labels_url":"https://api.github.com/repos/ethereum/go-ethereum/milestones/22/labels","id":1382463,"number":22,"title":"1.3.0","description":"","creator":{"login":"obscuren","id":6264126,"avatar_url":"https://avatars.githubusercontent.com/u/6264126?v=3","gravatar_id":"","url":"https://api.github.com/users/obscuren","html_url":"https://github.com/obscuren","followers_url":"https://api.github.com/users/obscuren/followers","following_url":"https://api.github.com/users/obscuren/following{/other_user}","gists_url":"https://api.github.com/users/obscuren/gists{/gist_id}","starred_url":"https://api.github.com/users/obscuren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obscuren/subscriptions","organizations_url":"https://api.github.com/users/obscuren/orgs","repos_url":"https://api.github.com/users/obscuren/repos","events_url":"https://api.github.com/users/obscuren/events{/privacy}","received_events_url":"https://api.github.com/users/obscuren/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":14,"state":"open","created_at":"2015-10-28T23:34:10Z","updated_at":"2015-10-29T12:32:30Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/1946/commits","review_comments_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/1946/comments","review_comment_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/1946/comments","statuses_url":"https://api.github.com/repos/ethereum/go-ethereum/statuses/5cc34f6b7decfa5433180071a160fb775c1f36cb","head":{"label":"fjl:xeth-oom","ref":"xeth-oom","sha":"5cc34f6b7decfa5433180071a160fb775c1f36cb","user":{"login":"fjl","id":6915,"avatar_url":"https://avatars.githubusercontent.com/u/6915?v=3","gravatar_id":"","url":"https://api.github.com/users/fjl","html_url":"https://github.com/fjl","followers_url":"https://api.github.com/users/fjl/followers","following_url":"https://api.github.com/users/fjl/following{/other_user}","gists_url":"https://api.github.com/users/fjl/gists{/gist_id}","starred_url":"https://api.github.com/users/fjl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjl/subscriptions","organizations_url":"https://api.github.com/users/fjl/orgs","repos_url":"https://api.github.com/users/fjl/repos","events_url":"https://api.github.com/users/fjl/events{/privacy}","received_events_url":"https://api.github.com/users/fjl/received_events","type":"User","site_admin":false},"repo":{"id":24951427,"name":"go-ethereum","full_name":"fjl/go-ethereum","owner":{"login":"fjl","id":6915,"avatar_url":"https://avatars.githubusercontent.com/u/6915?v=3","gravatar_id":"","url":"https://api.github.com/users/fjl","html_url":"https://github.com/fjl","followers_url":"https://api.github.com/users/fjl/followers","following_url":"https://api.github.com/users/fjl/following{/other_user}","gists_url":"https://api.github.com/users/fjl/gists{/gist_id}","starred_url":"https://api.github.com/users/fjl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjl/subscriptions","organizations_url":"https://api.github.com/users/fjl/orgs","repos_url":"https://api.github.com/users/fjl/repos","events_url":"https://api.github.com/users/fjl/events{/privacy}","received_events_url":"https://api.github.com/users/fjl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fjl/go-ethereum","description":"Work fork of go-ethereum.","fork":true,"url":"https://api.github.com/repos/fjl/go-ethereum","forks_url":"https://api.github.com/repos/fjl/go-ethereum/forks","keys_url":"https://api.github.com/repos/fjl/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fjl/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fjl/go-ethereum/teams","hooks_url":"https://api.github.com/repos/fjl/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/fjl/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/fjl/go-ethereum/events","assignees_url":"https://api.github.com/repos/fjl/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/fjl/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/fjl/go-ethereum/tags","blobs_url":"https://api.github.com/repos/fjl/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fjl/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fjl/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/fjl/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fjl/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/fjl/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/fjl/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/fjl/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/fjl/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/fjl/go-ethereum/subscription","commits_url":"https://api.github.com/repos/fjl/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/fjl/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/fjl/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/fjl/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/fjl/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/fjl/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fjl/go-ethereum/merges","archive_url":"https://api.github.com/repos/fjl/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fjl/go-ethereum/downloads","issues_url":"https://api.github.com/repos/fjl/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/fjl/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/fjl/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/fjl/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fjl/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/fjl/go-ethereum/releases{/id}","created_at":"2014-10-08T17:12:04Z","updated_at":"2015-05-29T23:48:03Z","pushed_at":"2015-10-29T12:31:46Z","git_url":"git://github.com/fjl/go-ethereum.git","ssh_url":"git@github.com:fjl/go-ethereum.git","clone_url":"https://github.com/fjl/go-ethereum.git","svn_url":"https://github.com/fjl/go-ethereum","homepage":"","size":49929,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"56f8699a6c6bfe613d2ab28c47631a1f4a29e36f","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15452919,"name":"go-ethereum","full_name":"ethereum/go-ethereum","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/go-ethereum","description":"Official golang implementation of the Ethereum protocol","fork":false,"url":"https://api.github.com/repos/ethereum/go-ethereum","forks_url":"https://api.github.com/repos/ethereum/go-ethereum/forks","keys_url":"https://api.github.com/repos/ethereum/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/go-ethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/go-ethereum/events","assignees_url":"https://api.github.com/repos/ethereum/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/go-ethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/go-ethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/go-ethereum/merges","archive_url":"https://api.github.com/repos/ethereum/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/go-ethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/go-ethereum/releases{/id}","created_at":"2013-12-26T13:05:46Z","updated_at":"2015-10-29T07:49:19Z","pushed_at":"2015-10-29T12:32:23Z","git_url":"git://github.com/ethereum/go-ethereum.git","ssh_url":"git@github.com:ethereum/go-ethereum.git","clone_url":"https://github.com/ethereum/go-ethereum.git","svn_url":"https://github.com/ethereum/go-ethereum","homepage":"http://ethereum.github.io/go-ethereum/","size":83892,"stargazers_count":690,"watchers_count":690,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":235,"mirror_url":null,"open_issues_count":129,"forks":235,"open_issues":129,"watchers":690,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/1946"},"html":{"href":"https://github.com/ethereum/go-ethereum/pull/1946"},"issue":{"href":"https://api.github.com/repos/ethereum/go-ethereum/issues/1946"},"comments":{"href":"https://api.github.com/repos/ethereum/go-ethereum/issues/1946/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/1946/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/1946/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/go-ethereum/statuses/5cc34f6b7decfa5433180071a160fb775c1f36cb"}}}}