{"action":"created","comment":{"url":"https://api.github.com/repos/quizlet/elasticsearch/pulls/comments/25457768","id":25457768,"diff_hunk":"@@ -126,10 +126,19 @@ public function commit($options = array()) {\n         if (!$this->chunks) return;\n         $chunksize = $this->chunksize? $this->chunksize: count($this->chunks);\n \n-        $ret = [];\n+        $ret = [\n+            'errors' => FALSE,\n+            'items' => [],","path":"src/ElasticSearch/Bulk.php","position":7,"original_position":7,"commit_id":"4880dd0ddd7d0473249824133e44ac2be5d738cc","original_commit_id":"7da3e5afe31a3b6d8ec2cbe2d25ca3eb5106de7b","user":{"login":"chanind","id":200725,"avatar_url":"https://avatars.githubusercontent.com/u/200725?v=3","gravatar_id":"","url":"https://api.github.com/users/chanind","html_url":"https://github.com/chanind","followers_url":"https://api.github.com/users/chanind/followers","following_url":"https://api.github.com/users/chanind/following{/other_user}","gists_url":"https://api.github.com/users/chanind/gists{/gist_id}","starred_url":"https://api.github.com/users/chanind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chanind/subscriptions","organizations_url":"https://api.github.com/users/chanind/orgs","repos_url":"https://api.github.com/users/chanind/repos","events_url":"https://api.github.com/users/chanind/events{/privacy}","received_events_url":"https://api.github.com/users/chanind/received_events","type":"User","site_admin":false},"body":"is there any case where the request would return more than these 2 keys?","created_at":"2015-02-26T19:45:38Z","updated_at":"2015-02-26T19:45:38Z","html_url":"https://github.com/quizlet/elasticsearch/pull/4#discussion_r25457768","pull_request_url":"https://api.github.com/repos/quizlet/elasticsearch/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/quizlet/elasticsearch/pulls/comments/25457768"},"html":{"href":"https://github.com/quizlet/elasticsearch/pull/4#discussion_r25457768"},"pull_request":{"href":"https://api.github.com/repos/quizlet/elasticsearch/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/quizlet/elasticsearch/pulls/4","id":30106917,"html_url":"https://github.com/quizlet/elasticsearch/pull/4","diff_url":"https://github.com/quizlet/elasticsearch/pull/4.diff","patch_url":"https://github.com/quizlet/elasticsearch/pull/4.patch","issue_url":"https://api.github.com/repos/quizlet/elasticsearch/issues/4","number":4,"state":"open","locked":false,"title":"Fixed bug in aggregation of responses in chunked bulk requests","user":{"login":"smreichling","id":6308602,"avatar_url":"https://avatars.githubusercontent.com/u/6308602?v=3","gravatar_id":"","url":"https://api.github.com/users/smreichling","html_url":"https://github.com/smreichling","followers_url":"https://api.github.com/users/smreichling/followers","following_url":"https://api.github.com/users/smreichling/following{/other_user}","gists_url":"https://api.github.com/users/smreichling/gists{/gist_id}","starred_url":"https://api.github.com/users/smreichling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smreichling/subscriptions","organizations_url":"https://api.github.com/users/smreichling/orgs","repos_url":"https://api.github.com/users/smreichling/repos","events_url":"https://api.github.com/users/smreichling/events{/privacy}","received_events_url":"https://api.github.com/users/smreichling/received_events","type":"User","site_admin":false},"body":"In the case where requests were chunked, the implementation was using a '+=' operator to join the responses. In PHP, this evidently creates the union of the arrays. So any keys in each response after the first that were already contained in a previous response were getting dropped. This change now properly aggregates the 'items' list of the response so that all chunks are kept.\r\n\r\n - [ ] reviewed by @chanind ","created_at":"2015-02-26T19:16:42Z","updated_at":"2015-02-26T19:45:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b5eb072e4d077cca82b2c5b71f461cc035a4274","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/quizlet/elasticsearch/pulls/4/commits","review_comments_url":"https://api.github.com/repos/quizlet/elasticsearch/pulls/4/comments","review_comment_url":"https://api.github.com/repos/quizlet/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quizlet/elasticsearch/issues/4/comments","statuses_url":"https://api.github.com/repos/quizlet/elasticsearch/statuses/4880dd0ddd7d0473249824133e44ac2be5d738cc","head":{"label":"quizlet:fix-chunked-response-handling","ref":"fix-chunked-response-handling","sha":"4880dd0ddd7d0473249824133e44ac2be5d738cc","user":{"login":"quizlet","id":616547,"avatar_url":"https://avatars.githubusercontent.com/u/616547?v=3","gravatar_id":"","url":"https://api.github.com/users/quizlet","html_url":"https://github.com/quizlet","followers_url":"https://api.github.com/users/quizlet/followers","following_url":"https://api.github.com/users/quizlet/following{/other_user}","gists_url":"https://api.github.com/users/quizlet/gists{/gist_id}","starred_url":"https://api.github.com/users/quizlet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quizlet/subscriptions","organizations_url":"https://api.github.com/users/quizlet/orgs","repos_url":"https://api.github.com/users/quizlet/repos","events_url":"https://api.github.com/users/quizlet/events{/privacy}","received_events_url":"https://api.github.com/users/quizlet/received_events","type":"Organization","site_admin":false},"repo":{"id":10616040,"name":"elasticsearch","full_name":"quizlet/elasticsearch","owner":{"login":"quizlet","id":616547,"avatar_url":"https://avatars.githubusercontent.com/u/616547?v=3","gravatar_id":"","url":"https://api.github.com/users/quizlet","html_url":"https://github.com/quizlet","followers_url":"https://api.github.com/users/quizlet/followers","following_url":"https://api.github.com/users/quizlet/following{/other_user}","gists_url":"https://api.github.com/users/quizlet/gists{/gist_id}","starred_url":"https://api.github.com/users/quizlet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quizlet/subscriptions","organizations_url":"https://api.github.com/users/quizlet/orgs","repos_url":"https://api.github.com/users/quizlet/repos","events_url":"https://api.github.com/users/quizlet/events{/privacy}","received_events_url":"https://api.github.com/users/quizlet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quizlet/elasticsearch","description":"Simple PHP client for ElasticSearch","fork":true,"url":"https://api.github.com/repos/quizlet/elasticsearch","forks_url":"https://api.github.com/repos/quizlet/elasticsearch/forks","keys_url":"https://api.github.com/repos/quizlet/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quizlet/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quizlet/elasticsearch/teams","hooks_url":"https://api.github.com/repos/quizlet/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/quizlet/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/quizlet/elasticsearch/events","assignees_url":"https://api.github.com/repos/quizlet/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/quizlet/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/quizlet/elasticsearch/tags","blobs_url":"https://api.github.com/repos/quizlet/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quizlet/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quizlet/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/quizlet/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quizlet/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/quizlet/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/quizlet/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/quizlet/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/quizlet/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/quizlet/elasticsearch/subscription","commits_url":"https://api.github.com/repos/quizlet/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/quizlet/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/quizlet/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/quizlet/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/quizlet/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/quizlet/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quizlet/elasticsearch/merges","archive_url":"https://api.github.com/repos/quizlet/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quizlet/elasticsearch/downloads","issues_url":"https://api.github.com/repos/quizlet/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/quizlet/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/quizlet/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/quizlet/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quizlet/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/quizlet/elasticsearch/releases{/id}","created_at":"2013-06-11T06:42:28Z","updated_at":"2015-02-20T22:42:17Z","pushed_at":"2015-02-26T19:41:11Z","git_url":"git://github.com/quizlet/elasticsearch.git","ssh_url":"git@github.com:quizlet/elasticsearch.git","clone_url":"https://github.com/quizlet/elasticsearch.git","svn_url":"https://github.com/quizlet/elasticsearch","homepage":"","size":475,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"quizlet:master","ref":"master","sha":"62026a2e9919dd787c0998fd88432218e3bb951c","user":{"login":"quizlet","id":616547,"avatar_url":"https://avatars.githubusercontent.com/u/616547?v=3","gravatar_id":"","url":"https://api.github.com/users/quizlet","html_url":"https://github.com/quizlet","followers_url":"https://api.github.com/users/quizlet/followers","following_url":"https://api.github.com/users/quizlet/following{/other_user}","gists_url":"https://api.github.com/users/quizlet/gists{/gist_id}","starred_url":"https://api.github.com/users/quizlet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quizlet/subscriptions","organizations_url":"https://api.github.com/users/quizlet/orgs","repos_url":"https://api.github.com/users/quizlet/repos","events_url":"https://api.github.com/users/quizlet/events{/privacy}","received_events_url":"https://api.github.com/users/quizlet/received_events","type":"Organization","site_admin":false},"repo":{"id":10616040,"name":"elasticsearch","full_name":"quizlet/elasticsearch","owner":{"login":"quizlet","id":616547,"avatar_url":"https://avatars.githubusercontent.com/u/616547?v=3","gravatar_id":"","url":"https://api.github.com/users/quizlet","html_url":"https://github.com/quizlet","followers_url":"https://api.github.com/users/quizlet/followers","following_url":"https://api.github.com/users/quizlet/following{/other_user}","gists_url":"https://api.github.com/users/quizlet/gists{/gist_id}","starred_url":"https://api.github.com/users/quizlet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quizlet/subscriptions","organizations_url":"https://api.github.com/users/quizlet/orgs","repos_url":"https://api.github.com/users/quizlet/repos","events_url":"https://api.github.com/users/quizlet/events{/privacy}","received_events_url":"https://api.github.com/users/quizlet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quizlet/elasticsearch","description":"Simple PHP client for ElasticSearch","fork":true,"url":"https://api.github.com/repos/quizlet/elasticsearch","forks_url":"https://api.github.com/repos/quizlet/elasticsearch/forks","keys_url":"https://api.github.com/repos/quizlet/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quizlet/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quizlet/elasticsearch/teams","hooks_url":"https://api.github.com/repos/quizlet/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/quizlet/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/quizlet/elasticsearch/events","assignees_url":"https://api.github.com/repos/quizlet/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/quizlet/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/quizlet/elasticsearch/tags","blobs_url":"https://api.github.com/repos/quizlet/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quizlet/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quizlet/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/quizlet/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quizlet/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/quizlet/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/quizlet/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/quizlet/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/quizlet/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/quizlet/elasticsearch/subscription","commits_url":"https://api.github.com/repos/quizlet/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/quizlet/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/quizlet/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/quizlet/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/quizlet/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/quizlet/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quizlet/elasticsearch/merges","archive_url":"https://api.github.com/repos/quizlet/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quizlet/elasticsearch/downloads","issues_url":"https://api.github.com/repos/quizlet/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/quizlet/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/quizlet/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/quizlet/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quizlet/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/quizlet/elasticsearch/releases{/id}","created_at":"2013-06-11T06:42:28Z","updated_at":"2015-02-20T22:42:17Z","pushed_at":"2015-02-26T19:41:11Z","git_url":"git://github.com/quizlet/elasticsearch.git","ssh_url":"git@github.com:quizlet/elasticsearch.git","clone_url":"https://github.com/quizlet/elasticsearch.git","svn_url":"https://github.com/quizlet/elasticsearch","homepage":"","size":475,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quizlet/elasticsearch/pulls/4"},"html":{"href":"https://github.com/quizlet/elasticsearch/pull/4"},"issue":{"href":"https://api.github.com/repos/quizlet/elasticsearch/issues/4"},"comments":{"href":"https://api.github.com/repos/quizlet/elasticsearch/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/quizlet/elasticsearch/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/quizlet/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quizlet/elasticsearch/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/quizlet/elasticsearch/statuses/4880dd0ddd7d0473249824133e44ac2be5d738cc"}}}}