{"action":"created","comment":{"url":"https://api.github.com/repos/ClusterLabs/hawk/pulls/comments/46003976","id":46003976,"diff_hunk":"@@ -10,121 +10,102 @@\n         = @resource.object_type\n \n   .modal-body\n-\n-\n-\n-\n-\n-\n-\n-\n-\n-\n-\n-\n-\n     .row\n-      .panel-group#r-info{role: :tablist, aria: {multiselectable: true}}\n-        - if @resource.params.any?\n-          .panel.panel-default\n-            .panel-heading#r-paramcontrol{role: :tab}\n-              %h4.panel-title\n-                %a{role: :button, data: {toggle: :collapse, parent: \"#r-info\"}, href: \"#r-params\", aria: {expanded: true, controls: \"r-params\"}}\n-                  = _(\"Parameters\")\n-                  .pull-right\n-                    %span.caret\n-            #r-params.panel-collapse.collapse.in{role: :tabpanel, aria: {labelledby: \"r-paramcontrol\"}}\n-              .panel-body\n-                %table.table\n-                  %tr\n-                    %th= _(\"Name\")\n-                    %th= _(\"Value\")\n-                  - @resource.params.each do |name, value|\n-                    %tr\n-                      %td= content_tag :code, name\n-                      %td= content_tag :code, value\n+      - if @resource.params.any?\n         .panel.panel-default\n-          .panel-heading#r-metacontrol{role: :tab}\n+          .panel-heading#r-paramcontrol{role: :tab}\n             %h4.panel-title\n-              %a{role: :button, data: {toggle: :collapse, parent: \"#r-info\"}, href: \"#r-metas\", aria: {expanded: false, controls: \"r-metas\"}}\n-                = _(\"Meta Attributes\")\n+              %a{role: :button, data: {toggle: :collapse}, href: \"#r-params\", aria: {expanded: true, controls: \"r-params\"}}\n+                = _(\"Parameters\")\n                 .pull-right\n                   %span.caret\n-          #r-metas.panel-collapse.collapse{role: :tabpanel, aria: {labelledby: \"r-metacontrol\"}}\n-            .panel-body\n-              %table.table\n+          #r-params.panel-collapse.collapse.in{role: :tabpanel, aria: {labelledby: \"r-paramcontrol\"}}\n+            %table.table\n+              %tr\n+                %th= _(\"Name\")\n+                %th= _(\"Value\")\n+              - @resource.params.each do |name, value|\n                 %tr\n-                  %th= _(\"Name\")\n-                  %th= _(\"Value\")\n-                - @resource.meta.each do |name, value|\n-                  %tr\n-                    %td= content_tag :code, name\n-                    %td= content_tag :code, value\n-\n-        - if @resource.ops.any?\n-          .panel.panel-default\n-            .panel-heading#r-opcontrol{role: :tab}\n-              %h4.panel-title\n-                %a{role: :button, data: {toggle: :collapse, parent: \"#r-info\"}, href: \"#r-ops\", aria: {expanded: false, controls: \"r-ops\"}}\n-                  = _(\"Operations\")\n-                  .pull-right\n-                    %span.caret\n-            #r-ops.panel-collapse.collapse{role: :tabpanel, aria: {labelledby: \"r-opcontrol\"}}\n-              .panel-body\n-                %table.table\n-                  %tr\n-                    %th= _(\"Name\")\n-                    %th= _(\"Timeout\")\n-                    %th= _(\"Interval\")\n-                  - @resource.ops.each do |id, op|\n-                    %tr\n-                      %td= content_tag :code, op[\"name\"]\n-                      %td= content_tag :code, op[\"timeout\"] || \"-\"\n-                      %td= content_tag :code, op[\"interval\"] || \"-\"\n+                  %td= content_tag :code, name\n+                  %td= content_tag :code, value\n+      .panel.panel-default\n+        .panel-heading#r-metacontrol{role: :tab}\n+          %h4.panel-title\n+            %a{role: :button, data: {toggle: :collapse}, href: \"#r-metas\", aria: {expanded: true, controls: \"r-metas\"}}\n+              = _(\"Meta Attributes\")\n+              .pull-right\n+                %span.caret\n+        #r-metas.panel-collapse.collapse.in{role: :tabpanel, aria: {labelledby: \"r-metacontrol\"}}\n+          %table.table\n+            %tr\n+              %th= _(\"Name\")\n+              %th= _(\"Value\")\n+            - @resource.meta.each do |name, value|\n+              %tr\n+                %td= content_tag :code, name\n+                %td= content_tag :code, value\n+\n+      - if @resource.ops.any?\n+        .panel.panel-default\n+          .panel-heading#r-opcontrol{role: :tab}\n+            %h4.panel-title\n+              %a{role: :button, data: {toggle: :collapse}, href: \"#r-ops\", aria: {expanded: false, controls: \"r-ops\"}}\n+                = _(\"Operations\")\n+                .pull-right\n+                  %span.caret\n+          #r-ops.panel-collapse.collapse{role: :tabpanel, aria: {labelledby: \"r-opcontrol\"}}","path":"hawk/app/views/resources/show.html.haml","position":112,"original_position":112,"commit_id":"3da04bbe2c8b16f41b5737f9cd420c111aa1b6fb","original_commit_id":"3da04bbe2c8b16f41b5737f9cd420c111aa1b6fb","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Hash attribute should start with one space after the opening brace<br>Hash attribute should end with one space before the closing brace<br>Classes should be listed before IDs (.panel-collapse should precede #r-ops)<br>Line is too long. [92/80]","created_at":"2015-11-26T19:42:37Z","updated_at":"2015-11-26T19:42:37Z","html_url":"https://github.com/ClusterLabs/hawk/pull/61#discussion_r46003976","pull_request_url":"https://api.github.com/repos/ClusterLabs/hawk/pulls/61","_links":{"self":{"href":"https://api.github.com/repos/ClusterLabs/hawk/pulls/comments/46003976"},"html":{"href":"https://github.com/ClusterLabs/hawk/pull/61#discussion_r46003976"},"pull_request":{"href":"https://api.github.com/repos/ClusterLabs/hawk/pulls/61"}}},"pull_request":{"url":"https://api.github.com/repos/ClusterLabs/hawk/pulls/61","id":51477681,"html_url":"https://github.com/ClusterLabs/hawk/pull/61","diff_url":"https://github.com/ClusterLabs/hawk/pull/61.diff","patch_url":"https://github.com/ClusterLabs/hawk/pull/61.patch","issue_url":"https://api.github.com/repos/ClusterLabs/hawk/issues/61","number":61,"state":"open","locked":false,"title":"Revised UI, new status view, node attribute editing support, etc.","user":{"login":"krig","id":25527,"avatar_url":"https://avatars.githubusercontent.com/u/25527?v=3","gravatar_id":"","url":"https://api.github.com/users/krig","html_url":"https://github.com/krig","followers_url":"https://api.github.com/users/krig/followers","following_url":"https://api.github.com/users/krig/following{/other_user}","gists_url":"https://api.github.com/users/krig/gists{/gist_id}","starred_url":"https://api.github.com/users/krig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krig/subscriptions","organizations_url":"https://api.github.com/users/krig/orgs","repos_url":"https://api.github.com/users/krig/repos","events_url":"https://api.github.com/users/krig/events{/privacy}","received_events_url":"https://api.github.com/users/krig/received_events","type":"User","site_admin":false},"body":"I had a productive weekend, and have been playing around with fixing a bunch of stuff in the UI.\r\n\r\nFeedback / comments are welcome!\r\n","created_at":"2015-11-22T22:58:38Z","updated_at":"2015-11-26T19:42:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9267f42a90577ee72176a51761837a88a66cd728","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ClusterLabs/hawk/pulls/61/commits","review_comments_url":"https://api.github.com/repos/ClusterLabs/hawk/pulls/61/comments","review_comment_url":"https://api.github.com/repos/ClusterLabs/hawk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ClusterLabs/hawk/issues/61/comments","statuses_url":"https://api.github.com/repos/ClusterLabs/hawk/statuses/3da04bbe2c8b16f41b5737f9cd420c111aa1b6fb","head":{"label":"krig:susecon","ref":"susecon","sha":"3da04bbe2c8b16f41b5737f9cd420c111aa1b6fb","user":{"login":"krig","id":25527,"avatar_url":"https://avatars.githubusercontent.com/u/25527?v=3","gravatar_id":"","url":"https://api.github.com/users/krig","html_url":"https://github.com/krig","followers_url":"https://api.github.com/users/krig/followers","following_url":"https://api.github.com/users/krig/following{/other_user}","gists_url":"https://api.github.com/users/krig/gists{/gist_id}","starred_url":"https://api.github.com/users/krig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krig/subscriptions","organizations_url":"https://api.github.com/users/krig/orgs","repos_url":"https://api.github.com/users/krig/repos","events_url":"https://api.github.com/users/krig/events{/privacy}","received_events_url":"https://api.github.com/users/krig/received_events","type":"User","site_admin":false},"repo":{"id":11468129,"name":"hawk","full_name":"krig/hawk","owner":{"login":"krig","id":25527,"avatar_url":"https://avatars.githubusercontent.com/u/25527?v=3","gravatar_id":"","url":"https://api.github.com/users/krig","html_url":"https://github.com/krig","followers_url":"https://api.github.com/users/krig/followers","following_url":"https://api.github.com/users/krig/following{/other_user}","gists_url":"https://api.github.com/users/krig/gists{/gist_id}","starred_url":"https://api.github.com/users/krig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krig/subscriptions","organizations_url":"https://api.github.com/users/krig/orgs","repos_url":"https://api.github.com/users/krig/repos","events_url":"https://api.github.com/users/krig/events{/privacy}","received_events_url":"https://api.github.com/users/krig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krig/hawk","description":"A web-based GUI for managing and monitoring the Pacemaker High-Availability cluster resource manager","fork":true,"url":"https://api.github.com/repos/krig/hawk","forks_url":"https://api.github.com/repos/krig/hawk/forks","keys_url":"https://api.github.com/repos/krig/hawk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krig/hawk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krig/hawk/teams","hooks_url":"https://api.github.com/repos/krig/hawk/hooks","issue_events_url":"https://api.github.com/repos/krig/hawk/issues/events{/number}","events_url":"https://api.github.com/repos/krig/hawk/events","assignees_url":"https://api.github.com/repos/krig/hawk/assignees{/user}","branches_url":"https://api.github.com/repos/krig/hawk/branches{/branch}","tags_url":"https://api.github.com/repos/krig/hawk/tags","blobs_url":"https://api.github.com/repos/krig/hawk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krig/hawk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krig/hawk/git/refs{/sha}","trees_url":"https://api.github.com/repos/krig/hawk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krig/hawk/statuses/{sha}","languages_url":"https://api.github.com/repos/krig/hawk/languages","stargazers_url":"https://api.github.com/repos/krig/hawk/stargazers","contributors_url":"https://api.github.com/repos/krig/hawk/contributors","subscribers_url":"https://api.github.com/repos/krig/hawk/subscribers","subscription_url":"https://api.github.com/repos/krig/hawk/subscription","commits_url":"https://api.github.com/repos/krig/hawk/commits{/sha}","git_commits_url":"https://api.github.com/repos/krig/hawk/git/commits{/sha}","comments_url":"https://api.github.com/repos/krig/hawk/comments{/number}","issue_comment_url":"https://api.github.com/repos/krig/hawk/issues/comments{/number}","contents_url":"https://api.github.com/repos/krig/hawk/contents/{+path}","compare_url":"https://api.github.com/repos/krig/hawk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krig/hawk/merges","archive_url":"https://api.github.com/repos/krig/hawk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krig/hawk/downloads","issues_url":"https://api.github.com/repos/krig/hawk/issues{/number}","pulls_url":"https://api.github.com/repos/krig/hawk/pulls{/number}","milestones_url":"https://api.github.com/repos/krig/hawk/milestones{/number}","notifications_url":"https://api.github.com/repos/krig/hawk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krig/hawk/labels{/name}","releases_url":"https://api.github.com/repos/krig/hawk/releases{/id}","created_at":"2013-07-17T05:38:56Z","updated_at":"2015-06-29T13:43:57Z","pushed_at":"2015-11-26T19:42:11Z","git_url":"git://github.com/krig/hawk.git","ssh_url":"git@github.com:krig/hawk.git","clone_url":"https://github.com/krig/hawk.git","svn_url":"https://github.com/krig/hawk","homepage":null,"size":13853,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ClusterLabs:master","ref":"master","sha":"9e7108330a3a921f04e8c2b50474860dd8a29614","user":{"login":"ClusterLabs","id":574912,"avatar_url":"https://avatars.githubusercontent.com/u/574912?v=3","gravatar_id":"","url":"https://api.github.com/users/ClusterLabs","html_url":"https://github.com/ClusterLabs","followers_url":"https://api.github.com/users/ClusterLabs/followers","following_url":"https://api.github.com/users/ClusterLabs/following{/other_user}","gists_url":"https://api.github.com/users/ClusterLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/ClusterLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClusterLabs/subscriptions","organizations_url":"https://api.github.com/users/ClusterLabs/orgs","repos_url":"https://api.github.com/users/ClusterLabs/repos","events_url":"https://api.github.com/users/ClusterLabs/events{/privacy}","received_events_url":"https://api.github.com/users/ClusterLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":4154361,"name":"hawk","full_name":"ClusterLabs/hawk","owner":{"login":"ClusterLabs","id":574912,"avatar_url":"https://avatars.githubusercontent.com/u/574912?v=3","gravatar_id":"","url":"https://api.github.com/users/ClusterLabs","html_url":"https://github.com/ClusterLabs","followers_url":"https://api.github.com/users/ClusterLabs/followers","following_url":"https://api.github.com/users/ClusterLabs/following{/other_user}","gists_url":"https://api.github.com/users/ClusterLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/ClusterLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClusterLabs/subscriptions","organizations_url":"https://api.github.com/users/ClusterLabs/orgs","repos_url":"https://api.github.com/users/ClusterLabs/repos","events_url":"https://api.github.com/users/ClusterLabs/events{/privacy}","received_events_url":"https://api.github.com/users/ClusterLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ClusterLabs/hawk","description":"A web-based GUI for managing and monitoring the Pacemaker High-Availability cluster resource manager","fork":false,"url":"https://api.github.com/repos/ClusterLabs/hawk","forks_url":"https://api.github.com/repos/ClusterLabs/hawk/forks","keys_url":"https://api.github.com/repos/ClusterLabs/hawk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ClusterLabs/hawk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ClusterLabs/hawk/teams","hooks_url":"https://api.github.com/repos/ClusterLabs/hawk/hooks","issue_events_url":"https://api.github.com/repos/ClusterLabs/hawk/issues/events{/number}","events_url":"https://api.github.com/repos/ClusterLabs/hawk/events","assignees_url":"https://api.github.com/repos/ClusterLabs/hawk/assignees{/user}","branches_url":"https://api.github.com/repos/ClusterLabs/hawk/branches{/branch}","tags_url":"https://api.github.com/repos/ClusterLabs/hawk/tags","blobs_url":"https://api.github.com/repos/ClusterLabs/hawk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ClusterLabs/hawk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ClusterLabs/hawk/git/refs{/sha}","trees_url":"https://api.github.com/repos/ClusterLabs/hawk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ClusterLabs/hawk/statuses/{sha}","languages_url":"https://api.github.com/repos/ClusterLabs/hawk/languages","stargazers_url":"https://api.github.com/repos/ClusterLabs/hawk/stargazers","contributors_url":"https://api.github.com/repos/ClusterLabs/hawk/contributors","subscribers_url":"https://api.github.com/repos/ClusterLabs/hawk/subscribers","subscription_url":"https://api.github.com/repos/ClusterLabs/hawk/subscription","commits_url":"https://api.github.com/repos/ClusterLabs/hawk/commits{/sha}","git_commits_url":"https://api.github.com/repos/ClusterLabs/hawk/git/commits{/sha}","comments_url":"https://api.github.com/repos/ClusterLabs/hawk/comments{/number}","issue_comment_url":"https://api.github.com/repos/ClusterLabs/hawk/issues/comments{/number}","contents_url":"https://api.github.com/repos/ClusterLabs/hawk/contents/{+path}","compare_url":"https://api.github.com/repos/ClusterLabs/hawk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ClusterLabs/hawk/merges","archive_url":"https://api.github.com/repos/ClusterLabs/hawk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ClusterLabs/hawk/downloads","issues_url":"https://api.github.com/repos/ClusterLabs/hawk/issues{/number}","pulls_url":"https://api.github.com/repos/ClusterLabs/hawk/pulls{/number}","milestones_url":"https://api.github.com/repos/ClusterLabs/hawk/milestones{/number}","notifications_url":"https://api.github.com/repos/ClusterLabs/hawk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ClusterLabs/hawk/labels{/name}","releases_url":"https://api.github.com/repos/ClusterLabs/hawk/releases{/id}","created_at":"2012-04-27T02:30:01Z","updated_at":"2015-11-19T21:15:49Z","pushed_at":"2015-11-26T19:42:12Z","git_url":"git://github.com/ClusterLabs/hawk.git","ssh_url":"git@github.com:ClusterLabs/hawk.git","clone_url":"https://github.com/ClusterLabs/hawk.git","svn_url":"https://github.com/ClusterLabs/hawk","homepage":null,"size":13583,"stargazers_count":46,"watchers_count":46,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":6,"forks":15,"open_issues":6,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ClusterLabs/hawk/pulls/61"},"html":{"href":"https://github.com/ClusterLabs/hawk/pull/61"},"issue":{"href":"https://api.github.com/repos/ClusterLabs/hawk/issues/61"},"comments":{"href":"https://api.github.com/repos/ClusterLabs/hawk/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/ClusterLabs/hawk/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/ClusterLabs/hawk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ClusterLabs/hawk/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/ClusterLabs/hawk/statuses/3da04bbe2c8b16f41b5737f9cd420c111aa1b6fb"}}}}