{"action":"created","issue":{"url":"https://api.github.com/repos/asciidoctor/asciidoctorj/issues/375","labels_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/issues/375/labels{/name}","comments_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/issues/375/comments","events_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/issues/375/events","html_url":"https://github.com/asciidoctor/asciidoctorj/issues/375","id":99713029,"number":375,"title":"Upgrade JRuby Gradle plugins to 1.0","user":{"login":"mojavelinux","id":79351,"avatar_url":"https://avatars.githubusercontent.com/u/79351?v=3","gravatar_id":"","url":"https://api.github.com/users/mojavelinux","html_url":"https://github.com/mojavelinux","followers_url":"https://api.github.com/users/mojavelinux/followers","following_url":"https://api.github.com/users/mojavelinux/following{/other_user}","gists_url":"https://api.github.com/users/mojavelinux/gists{/gist_id}","starred_url":"https://api.github.com/users/mojavelinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mojavelinux/subscriptions","organizations_url":"https://api.github.com/users/mojavelinux/orgs","repos_url":"https://api.github.com/users/mojavelinux/repos","events_url":"https://api.github.com/users/mojavelinux/events{/privacy}","received_events_url":"https://api.github.com/users/mojavelinux/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-08-07T19:29:19Z","updated_at":"2015-10-04T01:10:00Z","closed_at":null,"body":"The JRuby Gradle plugins have reached 1.0. We should upgrade and align with them.\r\n\r\nhttp://jruby-gradle.org/news/2015/08/04/jrubygradle-one-point-oh/\r\n\r\nNote that the default JRuby runtime is JRuby 9.0.0.0.\r\n\r\nWe should also look into the jar plugin again and see if we can use it now. Currently, we're only using the base plugin because the jar plugin didn't fit our use case. If that's still the case, we should make sure to file issues upstream so that eventually we can use it.\r\n\r\nI think it's fine to upgrade only the 1.6.0 branch, but I'll leave that decision up to @robertpanzer."},"comment":{"url":"https://api.github.com/repos/asciidoctor/asciidoctorj/issues/comments/145304028","html_url":"https://github.com/asciidoctor/asciidoctorj/issues/375#issuecomment-145304028","issue_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/issues/375","id":145304028,"user":{"login":"mojavelinux","id":79351,"avatar_url":"https://avatars.githubusercontent.com/u/79351?v=3","gravatar_id":"","url":"https://api.github.com/users/mojavelinux","html_url":"https://github.com/mojavelinux","followers_url":"https://api.github.com/users/mojavelinux/followers","following_url":"https://api.github.com/users/mojavelinux/following{/other_user}","gists_url":"https://api.github.com/users/mojavelinux/gists{/gist_id}","starred_url":"https://api.github.com/users/mojavelinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mojavelinux/subscriptions","organizations_url":"https://api.github.com/users/mojavelinux/orgs","repos_url":"https://api.github.com/users/mojavelinux/repos","events_url":"https://api.github.com/users/mojavelinux/events{/privacy}","received_events_url":"https://api.github.com/users/mojavelinux/received_events","type":"User","site_admin":false},"created_at":"2015-10-04T01:10:00Z","updated_at":"2015-10-04T01:10:00Z","body":"Thanks for identifying these requirements, @robertpanzer and @abelsromero. This is exactly the steps we need to take so that we can converge with the plugin. The way I look at the custom scripts in AsciidoctorJ is like a requirements list for what we would need to switch to the plugin. I do believe that rolling this into a Gradle plugin / task is the goal here. If fixing the jar plugin to cover this use case (a very common use case, I might add), then that's great. If it means another plugin or task, then that's what we'll need to do. But I think we definitely want to eventually get rid of the custom scripting.\r\n\r\nThe custom filtering would be nice, but I wouldn't say it's a hard requirement. We really shouldn't have to be doing that...better is to fix the gems upstream. We just happened to be able to use that workaround in the past.\r\n\r\nOf course, all of this packaging would be totally eliminated if JRuby had the ability to use a gem directly, without having to repackage it. I dream of that day :)"}}