{"action":"created","issue":{"url":"https://api.github.com/repos/scipy/scipy/issues/5186","labels_url":"https://api.github.com/repos/scipy/scipy/issues/5186/labels{/name}","comments_url":"https://api.github.com/repos/scipy/scipy/issues/5186/comments","events_url":"https://api.github.com/repos/scipy/scipy/issues/5186/events","html_url":"https://github.com/scipy/scipy/pull/5186","id":103529699,"number":5186,"title":"WIP: Port upfirdn","user":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=3","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/scipy/scipy/labels/enhancement","name":"enhancement","color":"bfe5bf"},{"url":"https://api.github.com/repos/scipy/scipy/labels/scipy.signal","name":"scipy.signal","color":"207de5"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":34,"created_at":"2015-08-27T14:59:05Z","updated_at":"2015-10-24T12:36:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scipy/scipy/pulls/5186","html_url":"https://github.com/scipy/scipy/pull/5186","diff_url":"https://github.com/scipy/scipy/pull/5186.diff","patch_url":"https://github.com/scipy/scipy/pull/5186.patch"},"body":"PR to eventually add `upfirdn` polyphase filtering to scipy. Built off of BSD-licensed `upfirdn` Python package:\r\n\r\nhttps://code.google.com/p/upfirdn/\r\n\r\nEventually this polyphase filtering approach be used to hopefully speed up resampling.\r\n\r\nOpening WIP PR to get some feedback on how to `scipy`-ify this code. It **will not run as is**.\r\n\r\nThe original code used (and still uses) SWIG to compile C++ to `.so`. I don't really see that done anywhere else in `scipy`, so I'm assuming that's the wrong way to go. Should I change the code over to C instead? If so, right now it supports real and complex signals and filters -- should I make different functions for the four different combinations of inputs (RR, CR, RC, CC), or is there another approach I should follow (e.g., a nice example of \"the right thing to do\")? We could also just do RR for now, and leave the other cases for future work.\r\n\r\nLet me know if I should put this to the `scipy-dev` listserv instead.\r\n\r\ncc the original author @sirtom67, thanks for writing what appears to be very clear code!"},"comment":{"url":"https://api.github.com/repos/scipy/scipy/issues/comments/150805560","html_url":"https://github.com/scipy/scipy/pull/5186#issuecomment-150805560","issue_url":"https://api.github.com/repos/scipy/scipy/issues/5186","id":150805560,"user":{"login":"ev-br","id":2133832,"avatar_url":"https://avatars.githubusercontent.com/u/2133832?v=3","gravatar_id":"","url":"https://api.github.com/users/ev-br","html_url":"https://github.com/ev-br","followers_url":"https://api.github.com/users/ev-br/followers","following_url":"https://api.github.com/users/ev-br/following{/other_user}","gists_url":"https://api.github.com/users/ev-br/gists{/gist_id}","starred_url":"https://api.github.com/users/ev-br/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ev-br/subscriptions","organizations_url":"https://api.github.com/users/ev-br/orgs","repos_url":"https://api.github.com/users/ev-br/repos","events_url":"https://api.github.com/users/ev-br/events{/privacy}","received_events_url":"https://api.github.com/users/ev-br/received_events","type":"User","site_admin":false},"created_at":"2015-10-24T12:36:22Z","updated_at":"2015-10-24T12:36:22Z","body":"Just a word of caution re pxi files: https://github.com/scipy/scipy/issues/3532 \r\n\r\nThere's also some fused types use in interpolate/_ppoly.pyx and of course linalg qr_update is a big one.\r\n"}}