{"action":"created","issue":{"url":"https://api.github.com/repos/lotus/controller/issues/125","labels_url":"https://api.github.com/repos/lotus/controller/issues/125/labels{/name}","comments_url":"https://api.github.com/repos/lotus/controller/issues/125/comments","events_url":"https://api.github.com/repos/lotus/controller/issues/125/events","html_url":"https://github.com/lotus/controller/pull/125","id":106656603,"number":125,"title":"introduces request and response format and deprecates default_format","user":{"login":"theocodes","id":5846601,"avatar_url":"https://avatars.githubusercontent.com/u/5846601?v=3","gravatar_id":"","url":"https://api.github.com/users/theocodes","html_url":"https://github.com/theocodes","followers_url":"https://api.github.com/users/theocodes/followers","following_url":"https://api.github.com/users/theocodes/following{/other_user}","gists_url":"https://api.github.com/users/theocodes/gists{/gist_id}","starred_url":"https://api.github.com/users/theocodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theocodes/subscriptions","organizations_url":"https://api.github.com/users/theocodes/orgs","repos_url":"https://api.github.com/users/theocodes/repos","events_url":"https://api.github.com/users/theocodes/events{/privacy}","received_events_url":"https://api.github.com/users/theocodes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-15T21:59:50Z","updated_at":"2015-09-16T07:14:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lotus/controller/pulls/125","html_url":"https://github.com/lotus/controller/pull/125","diff_url":"https://github.com/lotus/controller/pull/125.diff","patch_url":"https://github.com/lotus/controller/pull/125.patch"},"body":"Recap..\r\n\r\nAs per my issue #111  and suggestion from Luca, this PR introduces `default_request_format` and `response_request_format` and deprecates `default_format`. \r\n\r\nThe premise behind it is:\r\n\r\n`default_request_format` behaves the same as `default_format`. However, now it's clear what default format we're setting. request..\r\n\r\n`default_response_format` will set it's value to all responses. It can only be overwritten by directly setting `self.format = :whatever` in the action itself. If a value is not set, it will then behave as it did before (try to guess response format based on request format etc...)\r\n\r\n`default_format` has been deprecated and should be removed eventually.\r\n\r\nPlease have a look and let me know what you think. :-)\r\n\r\nNotes:\r\n\r\n* There's a PR on lotus/lotus that addresses the same thing.\r\n* I've versioned the new methods to 0.5.0 as I assume that's when it will be introduced, but that needs to be confirmed. thoughts?\r\n"},"comment":{"url":"https://api.github.com/repos/lotus/controller/issues/comments/140651740","html_url":"https://github.com/lotus/controller/pull/125#issuecomment-140651740","issue_url":"https://api.github.com/repos/lotus/controller/issues/125","id":140651740,"user":{"login":"jodosha","id":5089,"avatar_url":"https://avatars.githubusercontent.com/u/5089?v=3","gravatar_id":"","url":"https://api.github.com/users/jodosha","html_url":"https://github.com/jodosha","followers_url":"https://api.github.com/users/jodosha/followers","following_url":"https://api.github.com/users/jodosha/following{/other_user}","gists_url":"https://api.github.com/users/jodosha/gists{/gist_id}","starred_url":"https://api.github.com/users/jodosha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jodosha/subscriptions","organizations_url":"https://api.github.com/users/jodosha/orgs","repos_url":"https://api.github.com/users/jodosha/repos","events_url":"https://api.github.com/users/jodosha/events{/privacy}","received_events_url":"https://api.github.com/users/jodosha/received_events","type":"User","site_admin":false},"created_at":"2015-09-16T07:14:22Z","updated_at":"2015-09-16T07:14:22Z","body":"> I've versioned the new methods to 0.5.0 as I assume that's when it will be introduced, but that needs to be confirmed. thoughts?\r\n\r\nThis is fine right now, but please use `@since x.x.x` instead. Before a release we grep for these YARD tags and replace with the right value :smile: "}}