{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/firefox-ios/pulls/comments/23844780","id":23844780,"diff_hunk":"@@ -46,9 +46,34 @@ class SettingsViewController: UIViewController, ToolbarViewProtocol, UITableView\n         signOutButton.addTarget(self, action: \"didClickLogout\", forControlEvents: UIControlEvents.TouchUpInside)\n     }\n \n-    // Referenced as button selector.\n+    // A temporary delegate which merely updates the displayed email address on\n+    // succesful Firefox Accounts sign in.\n+    private class Delegate: FxASignInViewControllerDelegate {","path":"Client/Frontend/Settings/SettingsViewController.swift","position":7,"original_position":7,"commit_id":"550083449645804880705cdb135e55c0eb2f5676","original_commit_id":"550083449645804880705cdb135e55c0eb2f5676","user":{"login":"st3fan","id":28052,"avatar_url":"https://avatars.githubusercontent.com/u/28052?v=3","gravatar_id":"","url":"https://api.github.com/users/st3fan","html_url":"https://github.com/st3fan","followers_url":"https://api.github.com/users/st3fan/followers","following_url":"https://api.github.com/users/st3fan/following{/other_user}","gists_url":"https://api.github.com/users/st3fan/gists{/gist_id}","starred_url":"https://api.github.com/users/st3fan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/st3fan/subscriptions","organizations_url":"https://api.github.com/users/st3fan/orgs","repos_url":"https://api.github.com/users/st3fan/repos","events_url":"https://api.github.com/users/st3fan/events{/privacy}","received_events_url":"https://api.github.com/users/st3fan/received_events","type":"User","site_admin":false},"body":"Why do these need to be in their own class? Can't they be part of the `SettingsViewController` directly?\r\n\r\nI think it makes more sense to name these:\r\n\r\n```\r\nfunc signInViewControllerDidCancel(vc: FxASignInViewController)\r\nfunc signInViewController(vc: FxASignInViewController, didSignIn account: JSON)\r\n```\r\nAnd include them directly in SettingsViewController. It is very uncommon to do that extra level of indirection.","created_at":"2015-01-30T14:25:28Z","updated_at":"2015-01-30T14:25:28Z","html_url":"https://github.com/mozilla/firefox-ios/pull/117#discussion_r23844780","pull_request_url":"https://api.github.com/repos/mozilla/firefox-ios/pulls/117","_links":{"self":{"href":"https://api.github.com/repos/mozilla/firefox-ios/pulls/comments/23844780"},"html":{"href":"https://github.com/mozilla/firefox-ios/pull/117#discussion_r23844780"},"pull_request":{"href":"https://api.github.com/repos/mozilla/firefox-ios/pulls/117"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/firefox-ios/pulls/117","id":28158858,"html_url":"https://github.com/mozilla/firefox-ios/pull/117","diff_url":"https://github.com/mozilla/firefox-ios/pull/117.diff","patch_url":"https://github.com/mozilla/firefox-ios/pull/117.patch","issue_url":"https://api.github.com/repos/mozilla/firefox-ios/issues/117","number":117,"state":"open","locked":false,"title":"Bug 1126584 - Sign in to Firefox Account via embedded accounts.firefox.c...","user":{"login":"ncalexan","id":1097182,"avatar_url":"https://avatars.githubusercontent.com/u/1097182?v=3","gravatar_id":"","url":"https://api.github.com/users/ncalexan","html_url":"https://github.com/ncalexan","followers_url":"https://api.github.com/users/ncalexan/followers","following_url":"https://api.github.com/users/ncalexan/following{/other_user}","gists_url":"https://api.github.com/users/ncalexan/gists{/gist_id}","starred_url":"https://api.github.com/users/ncalexan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncalexan/subscriptions","organizations_url":"https://api.github.com/users/ncalexan/orgs","repos_url":"https://api.github.com/users/ncalexan/repos","events_url":"https://api.github.com/users/ncalexan/events{/privacy}","received_events_url":"https://api.github.com/users/ncalexan/received_events","type":"User","site_admin":false},"body":"...om.","created_at":"2015-01-28T00:41:03Z","updated_at":"2015-01-30T14:25:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47221dc8596f9337268b01c33e223f1d88cb9aa4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/firefox-ios/pulls/117/commits","review_comments_url":"https://api.github.com/repos/mozilla/firefox-ios/pulls/117/comments","review_comment_url":"https://api.github.com/repos/mozilla/firefox-ios/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla/firefox-ios/issues/117/comments","statuses_url":"https://api.github.com/repos/mozilla/firefox-ios/statuses/550083449645804880705cdb135e55c0eb2f5676","head":{"label":"ncalexan:nalexander/bug-1126584-sign-in","ref":"nalexander/bug-1126584-sign-in","sha":"550083449645804880705cdb135e55c0eb2f5676","user":{"login":"ncalexan","id":1097182,"avatar_url":"https://avatars.githubusercontent.com/u/1097182?v=3","gravatar_id":"","url":"https://api.github.com/users/ncalexan","html_url":"https://github.com/ncalexan","followers_url":"https://api.github.com/users/ncalexan/followers","following_url":"https://api.github.com/users/ncalexan/following{/other_user}","gists_url":"https://api.github.com/users/ncalexan/gists{/gist_id}","starred_url":"https://api.github.com/users/ncalexan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncalexan/subscriptions","organizations_url":"https://api.github.com/users/ncalexan/orgs","repos_url":"https://api.github.com/users/ncalexan/repos","events_url":"https://api.github.com/users/ncalexan/events{/privacy}","received_events_url":"https://api.github.com/users/ncalexan/received_events","type":"User","site_admin":false},"repo":{"id":27833717,"name":"firefox-ios","full_name":"ncalexan/firefox-ios","owner":{"login":"ncalexan","id":1097182,"avatar_url":"https://avatars.githubusercontent.com/u/1097182?v=3","gravatar_id":"","url":"https://api.github.com/users/ncalexan","html_url":"https://github.com/ncalexan","followers_url":"https://api.github.com/users/ncalexan/followers","following_url":"https://api.github.com/users/ncalexan/following{/other_user}","gists_url":"https://api.github.com/users/ncalexan/gists{/gist_id}","starred_url":"https://api.github.com/users/ncalexan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncalexan/subscriptions","organizations_url":"https://api.github.com/users/ncalexan/orgs","repos_url":"https://api.github.com/users/ncalexan/repos","events_url":"https://api.github.com/users/ncalexan/events{/privacy}","received_events_url":"https://api.github.com/users/ncalexan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ncalexan/firefox-ios","description":"Firefox for iOS","fork":true,"url":"https://api.github.com/repos/ncalexan/firefox-ios","forks_url":"https://api.github.com/repos/ncalexan/firefox-ios/forks","keys_url":"https://api.github.com/repos/ncalexan/firefox-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ncalexan/firefox-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ncalexan/firefox-ios/teams","hooks_url":"https://api.github.com/repos/ncalexan/firefox-ios/hooks","issue_events_url":"https://api.github.com/repos/ncalexan/firefox-ios/issues/events{/number}","events_url":"https://api.github.com/repos/ncalexan/firefox-ios/events","assignees_url":"https://api.github.com/repos/ncalexan/firefox-ios/assignees{/user}","branches_url":"https://api.github.com/repos/ncalexan/firefox-ios/branches{/branch}","tags_url":"https://api.github.com/repos/ncalexan/firefox-ios/tags","blobs_url":"https://api.github.com/repos/ncalexan/firefox-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ncalexan/firefox-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ncalexan/firefox-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/ncalexan/firefox-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ncalexan/firefox-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/ncalexan/firefox-ios/languages","stargazers_url":"https://api.github.com/repos/ncalexan/firefox-ios/stargazers","contributors_url":"https://api.github.com/repos/ncalexan/firefox-ios/contributors","subscribers_url":"https://api.github.com/repos/ncalexan/firefox-ios/subscribers","subscription_url":"https://api.github.com/repos/ncalexan/firefox-ios/subscription","commits_url":"https://api.github.com/repos/ncalexan/firefox-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/ncalexan/firefox-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/ncalexan/firefox-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/ncalexan/firefox-ios/issues/comments/{number}","contents_url":"https://api.github.com/repos/ncalexan/firefox-ios/contents/{+path}","compare_url":"https://api.github.com/repos/ncalexan/firefox-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ncalexan/firefox-ios/merges","archive_url":"https://api.github.com/repos/ncalexan/firefox-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ncalexan/firefox-ios/downloads","issues_url":"https://api.github.com/repos/ncalexan/firefox-ios/issues{/number}","pulls_url":"https://api.github.com/repos/ncalexan/firefox-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/ncalexan/firefox-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/ncalexan/firefox-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ncalexan/firefox-ios/labels{/name}","releases_url":"https://api.github.com/repos/ncalexan/firefox-ios/releases{/id}","created_at":"2014-12-10T18:32:42Z","updated_at":"2014-12-10T18:32:44Z","pushed_at":"2015-01-29T20:16:38Z","git_url":"git://github.com/ncalexan/firefox-ios.git","ssh_url":"git@github.com:ncalexan/firefox-ios.git","clone_url":"https://github.com/ncalexan/firefox-ios.git","svn_url":"https://github.com/ncalexan/firefox-ios","homepage":"","size":8894,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"88ca1e74f9486958b58d8efe17d216c21cf2f2aa","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":26133979,"name":"firefox-ios","full_name":"mozilla/firefox-ios","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/firefox-ios","description":"Firefox for iOS","fork":false,"url":"https://api.github.com/repos/mozilla/firefox-ios","forks_url":"https://api.github.com/repos/mozilla/firefox-ios/forks","keys_url":"https://api.github.com/repos/mozilla/firefox-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/firefox-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/firefox-ios/teams","hooks_url":"https://api.github.com/repos/mozilla/firefox-ios/hooks","issue_events_url":"https://api.github.com/repos/mozilla/firefox-ios/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/firefox-ios/events","assignees_url":"https://api.github.com/repos/mozilla/firefox-ios/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/firefox-ios/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/firefox-ios/tags","blobs_url":"https://api.github.com/repos/mozilla/firefox-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/firefox-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/firefox-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/firefox-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/firefox-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/firefox-ios/languages","stargazers_url":"https://api.github.com/repos/mozilla/firefox-ios/stargazers","contributors_url":"https://api.github.com/repos/mozilla/firefox-ios/contributors","subscribers_url":"https://api.github.com/repos/mozilla/firefox-ios/subscribers","subscription_url":"https://api.github.com/repos/mozilla/firefox-ios/subscription","commits_url":"https://api.github.com/repos/mozilla/firefox-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/firefox-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/firefox-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/firefox-ios/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/firefox-ios/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/firefox-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/firefox-ios/merges","archive_url":"https://api.github.com/repos/mozilla/firefox-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/firefox-ios/downloads","issues_url":"https://api.github.com/repos/mozilla/firefox-ios/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/firefox-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/firefox-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/firefox-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/firefox-ios/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/firefox-ios/releases{/id}","created_at":"2014-11-03T19:07:02Z","updated_at":"2015-01-30T11:49:04Z","pushed_at":"2015-01-30T00:06:41Z","git_url":"git://github.com/mozilla/firefox-ios.git","ssh_url":"git@github.com:mozilla/firefox-ios.git","clone_url":"https://github.com/mozilla/firefox-ios.git","svn_url":"https://github.com/mozilla/firefox-ios","homepage":"","size":14531,"stargazers_count":2841,"watchers_count":2841,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":441,"mirror_url":null,"open_issues_count":13,"forks":441,"open_issues":13,"watchers":2841,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/firefox-ios/pulls/117"},"html":{"href":"https://github.com/mozilla/firefox-ios/pull/117"},"issue":{"href":"https://api.github.com/repos/mozilla/firefox-ios/issues/117"},"comments":{"href":"https://api.github.com/repos/mozilla/firefox-ios/issues/117/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/firefox-ios/pulls/117/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/firefox-ios/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla/firefox-ios/pulls/117/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/firefox-ios/statuses/550083449645804880705cdb135e55c0eb2f5676"}}}}