{"action":"closed","number":127,"pull_request":{"url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/pulls/127","id":50066254,"html_url":"https://github.com/AngularClass/angular2-webpack-starter/pull/127","diff_url":"https://github.com/AngularClass/angular2-webpack-starter/pull/127.diff","patch_url":"https://github.com/AngularClass/angular2-webpack-starter/pull/127.patch","issue_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/issues/127","number":127,"state":"closed","locked":false,"title":"ng2-bootstrap + example","user":{"login":"dotcs","id":3976183,"avatar_url":"https://avatars.githubusercontent.com/u/3976183?v=3","gravatar_id":"","url":"https://api.github.com/users/dotcs","html_url":"https://github.com/dotcs","followers_url":"https://api.github.com/users/dotcs/followers","following_url":"https://api.github.com/users/dotcs/following{/other_user}","gists_url":"https://api.github.com/users/dotcs/gists{/gist_id}","starred_url":"https://api.github.com/users/dotcs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotcs/subscriptions","organizations_url":"https://api.github.com/users/dotcs/orgs","repos_url":"https://api.github.com/users/dotcs/repos","events_url":"https://api.github.com/users/dotcs/events{/privacy}","received_events_url":"https://api.github.com/users/dotcs/received_events","type":"User","site_admin":false},"body":"This PR adds `ng2-bootstrap` (as requested in https://github.com/AngularClass/angular2-webpack-starter/pull/83). `ng2-bootstrap` provides the ng2 components, `bootstrap` is purely used for the CSS file. The latter could be replaced with a CDN version, but I prefer to be able to work offline which is why I added also the `bootstrap` dependency.\r\n\r\nTo make things work, I had to [remove the `/node_modules/` regex](https://github.com/dotcs/angular2-webpack-starter/commit/f6a520138588300f27d6b1042f3d534117c23749#diff-11e9f7f953edc64ba14b0cc350ae7b9dL131) in webpack's typescript module loader definition. I tried to only include the `ng2-bootstrap` module - without success. The regex `node_modules\\/((?!(ng2-bootstrap)).)*` did not work, although it should exclude all but the `ng2-bootstrap` folder. If the exclusion of `node_modules` is necessary for any other parts of this project, we should find a way around this issue before merging.\r\n\r\n/cc: @gdi2290 ","created_at":"2015-11-08T18:25:18Z","updated_at":"2015-12-05T16:34:48Z","closed_at":"2015-12-05T16:34:48Z","merged_at":null,"merge_commit_sha":"36b2eed29a4579d306eef0e6dfaad4b3b38e36ed","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/pulls/127/commits","review_comments_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/pulls/127/comments","review_comment_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/issues/127/comments","statuses_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/statuses/48181e3c9a90ebc2e0882fa39bd8a51b0793c9d6","head":{"label":"dotcs:ng2-bootstrap","ref":"ng2-bootstrap","sha":"48181e3c9a90ebc2e0882fa39bd8a51b0793c9d6","user":{"login":"dotcs","id":3976183,"avatar_url":"https://avatars.githubusercontent.com/u/3976183?v=3","gravatar_id":"","url":"https://api.github.com/users/dotcs","html_url":"https://github.com/dotcs","followers_url":"https://api.github.com/users/dotcs/followers","following_url":"https://api.github.com/users/dotcs/following{/other_user}","gists_url":"https://api.github.com/users/dotcs/gists{/gist_id}","starred_url":"https://api.github.com/users/dotcs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotcs/subscriptions","organizations_url":"https://api.github.com/users/dotcs/orgs","repos_url":"https://api.github.com/users/dotcs/repos","events_url":"https://api.github.com/users/dotcs/events{/privacy}","received_events_url":"https://api.github.com/users/dotcs/received_events","type":"User","site_admin":false},"repo":{"id":42916732,"name":"angular2-webpack-starter","full_name":"dotcs/angular2-webpack-starter","owner":{"login":"dotcs","id":3976183,"avatar_url":"https://avatars.githubusercontent.com/u/3976183?v=3","gravatar_id":"","url":"https://api.github.com/users/dotcs","html_url":"https://github.com/dotcs","followers_url":"https://api.github.com/users/dotcs/followers","following_url":"https://api.github.com/users/dotcs/following{/other_user}","gists_url":"https://api.github.com/users/dotcs/gists{/gist_id}","starred_url":"https://api.github.com/users/dotcs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotcs/subscriptions","organizations_url":"https://api.github.com/users/dotcs/orgs","repos_url":"https://api.github.com/users/dotcs/repos","events_url":"https://api.github.com/users/dotcs/events{/privacy}","received_events_url":"https://api.github.com/users/dotcs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dotcs/angular2-webpack-starter","description":"An Angular 2 Webpack Starter kit featuring Angular 2 (Router, Http, Forms, Services, Tests, E2E), Karma, Protractor, Jasmine, TypeScript, and Webpack by @Angular-Class","fork":true,"url":"https://api.github.com/repos/dotcs/angular2-webpack-starter","forks_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/forks","keys_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/teams","hooks_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/hooks","issue_events_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/issues/events{/number}","events_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/events","assignees_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/assignees{/user}","branches_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/branches{/branch}","tags_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/tags","blobs_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/statuses/{sha}","languages_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/languages","stargazers_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/stargazers","contributors_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/contributors","subscribers_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/subscribers","subscription_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/subscription","commits_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/contents/{+path}","compare_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/merges","archive_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/downloads","issues_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/issues{/number}","pulls_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/pulls{/number}","milestones_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/milestones{/number}","notifications_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/labels{/name}","releases_url":"https://api.github.com/repos/dotcs/angular2-webpack-starter/releases{/id}","created_at":"2015-09-22T06:52:35Z","updated_at":"2015-09-22T06:52:35Z","pushed_at":"2015-11-23T07:57:25Z","git_url":"git://github.com/dotcs/angular2-webpack-starter.git","ssh_url":"git@github.com:dotcs/angular2-webpack-starter.git","clone_url":"https://github.com/dotcs/angular2-webpack-starter.git","svn_url":"https://github.com/dotcs/angular2-webpack-starter","homepage":"","size":1231,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AngularClass:master","ref":"master","sha":"aff85844f561fd07ddd5913b3c2682e7737bb033","user":{"login":"AngularClass","id":11602678,"avatar_url":"https://avatars.githubusercontent.com/u/11602678?v=3","gravatar_id":"","url":"https://api.github.com/users/AngularClass","html_url":"https://github.com/AngularClass","followers_url":"https://api.github.com/users/AngularClass/followers","following_url":"https://api.github.com/users/AngularClass/following{/other_user}","gists_url":"https://api.github.com/users/AngularClass/gists{/gist_id}","starred_url":"https://api.github.com/users/AngularClass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AngularClass/subscriptions","organizations_url":"https://api.github.com/users/AngularClass/orgs","repos_url":"https://api.github.com/users/AngularClass/repos","events_url":"https://api.github.com/users/AngularClass/events{/privacy}","received_events_url":"https://api.github.com/users/AngularClass/received_events","type":"Organization","site_admin":false},"repo":{"id":31829770,"name":"angular2-webpack-starter","full_name":"AngularClass/angular2-webpack-starter","owner":{"login":"AngularClass","id":11602678,"avatar_url":"https://avatars.githubusercontent.com/u/11602678?v=3","gravatar_id":"","url":"https://api.github.com/users/AngularClass","html_url":"https://github.com/AngularClass","followers_url":"https://api.github.com/users/AngularClass/followers","following_url":"https://api.github.com/users/AngularClass/following{/other_user}","gists_url":"https://api.github.com/users/AngularClass/gists{/gist_id}","starred_url":"https://api.github.com/users/AngularClass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AngularClass/subscriptions","organizations_url":"https://api.github.com/users/AngularClass/orgs","repos_url":"https://api.github.com/users/AngularClass/repos","events_url":"https://api.github.com/users/AngularClass/events{/privacy}","received_events_url":"https://api.github.com/users/AngularClass/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AngularClass/angular2-webpack-starter","description":"An Angular 2 Webpack Starter kit featuring Angular 2 (Router, Http, Forms, Services, Tests, E2E), Karma, Protractor, Jasmine, TypeScript, and Webpack by @AngularClass","fork":false,"url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter","forks_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/forks","keys_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/teams","hooks_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/hooks","issue_events_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/issues/events{/number}","events_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/events","assignees_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/assignees{/user}","branches_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/branches{/branch}","tags_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/tags","blobs_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/git/refs{/sha}","trees_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/statuses/{sha}","languages_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/languages","stargazers_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/stargazers","contributors_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/contributors","subscribers_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/subscribers","subscription_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/subscription","commits_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/commits{/sha}","git_commits_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/git/commits{/sha}","comments_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/comments{/number}","issue_comment_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/issues/comments{/number}","contents_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/contents/{+path}","compare_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/merges","archive_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/downloads","issues_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/issues{/number}","pulls_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/pulls{/number}","milestones_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/milestones{/number}","notifications_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/labels{/name}","releases_url":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/releases{/id}","created_at":"2015-03-07T22:25:10Z","updated_at":"2015-12-05T06:31:40Z","pushed_at":"2015-12-04T17:33:51Z","git_url":"git://github.com/AngularClass/angular2-webpack-starter.git","ssh_url":"git@github.com:AngularClass/angular2-webpack-starter.git","clone_url":"https://github.com/AngularClass/angular2-webpack-starter.git","svn_url":"https://github.com/AngularClass/angular2-webpack-starter","homepage":"https://angularclass.github.io/angular2-webpack-starter/","size":2335,"stargazers_count":906,"watchers_count":906,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":307,"mirror_url":null,"open_issues_count":11,"forks":307,"open_issues":11,"watchers":906,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/pulls/127"},"html":{"href":"https://github.com/AngularClass/angular2-webpack-starter/pull/127"},"issue":{"href":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/issues/127"},"comments":{"href":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/issues/127/comments"},"review_comments":{"href":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/pulls/127/comments"},"review_comment":{"href":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/pulls/127/commits"},"statuses":{"href":"https://api.github.com/repos/AngularClass/angular2-webpack-starter/statuses/48181e3c9a90ebc2e0882fa39bd8a51b0793c9d6"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":4,"review_comments":0,"commits":2,"additions":41,"deletions":2,"changed_files":4}}