{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/28624133","id":28624133,"diff_hunk":"@@ -37,6 +37,10 @@ html.video-fullscreen{\n       color: $white;\n     }\n   }\n+\n+  @media print {","path":"lms/static/sass/course/courseware/_courseware.scss","position":5,"original_position":5,"commit_id":"30982c4d27634b019e0c4e1238bff0eee7797344","original_commit_id":"8c38b7dd5e502d502211efd67179ede02723d999","user":{"login":"jolyonb","id":6232546,"avatar_url":"https://avatars.githubusercontent.com/u/6232546?v=3","gravatar_id":"","url":"https://api.github.com/users/jolyonb","html_url":"https://github.com/jolyonb","followers_url":"https://api.github.com/users/jolyonb/followers","following_url":"https://api.github.com/users/jolyonb/following{/other_user}","gists_url":"https://api.github.com/users/jolyonb/gists{/gist_id}","starred_url":"https://api.github.com/users/jolyonb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jolyonb/subscriptions","organizations_url":"https://api.github.com/users/jolyonb/orgs","repos_url":"https://api.github.com/users/jolyonb/repos","events_url":"https://api.github.com/users/jolyonb/events{/privacy}","received_events_url":"https://api.github.com/users/jolyonb/received_events","type":"User","site_admin":false},"body":"I see printing as being useful from two perspectives: creating PDF versions of a page for students to download, and allowing students to print. If I'm making a PDF version, I don't particularly want \"Staff Info Only\" plastered all over it. I'd much prefer to create something that is as close to what students will see as possible.","created_at":"2015-04-17T19:43:11Z","updated_at":"2015-04-17T19:43:11Z","html_url":"https://github.com/edx/edx-platform/pull/7595#discussion_r28624133","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/7595","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/28624133"},"html":{"href":"https://github.com/edx/edx-platform/pull/7595#discussion_r28624133"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/7595"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/7595","id":32628100,"html_url":"https://github.com/edx/edx-platform/pull/7595","diff_url":"https://github.com/edx/edx-platform/pull/7595.diff","patch_url":"https://github.com/edx/edx-platform/pull/7595.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/7595","number":7595,"state":"open","locked":false,"title":"Complete Printing Cleanup","user":{"login":"jolyonb","id":6232546,"avatar_url":"https://avatars.githubusercontent.com/u/6232546?v=3","gravatar_id":"","url":"https://api.github.com/users/jolyonb","html_url":"https://github.com/jolyonb","followers_url":"https://api.github.com/users/jolyonb/followers","following_url":"https://api.github.com/users/jolyonb/following{/other_user}","gists_url":"https://api.github.com/users/jolyonb/gists{/gist_id}","starred_url":"https://api.github.com/users/jolyonb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jolyonb/subscriptions","organizations_url":"https://api.github.com/users/jolyonb/orgs","repos_url":"https://api.github.com/users/jolyonb/repos","events_url":"https://api.github.com/users/jolyonb/events{/privacy}","received_events_url":"https://api.github.com/users/jolyonb/received_events","type":"User","site_admin":false},"body":"This PR applies a number of changes to the print media CSS.\r\n\r\nBeing able to print nicely from edX is important for a number of reasons, including making PDFs for students to view offline, and for a variety of accessibility issues. Currently, printing in the edX platform is unusable. For example, here is a print to pdf of a page from MITx: http://web.mit.edu/jolyon/Public/printing_present.pdf\r\n\r\nThis pull request modifies a number of things in the print media CSS to make this beautiful. I'll jump straight to the punchline. Here is what that same page looks like with this pull request in place: http://web.mit.edu/jolyon/Public/printing_with_changes.pdf\r\n\r\n(Two other pull requests are also in place for this second pdf; https://github.com/edx/edx-platform/pull/7592 and https://github.com/edx/edx-platform/pull/7591)\r\n\r\nAll of the changes included in this PR modify print media CSS *only*. I'll go through and annotate each change individually, so that you can see what it is doing. Most of the changes are hiding things; a few of them are changing borders and whitespace.","created_at":"2015-04-04T03:20:54Z","updated_at":"2015-04-17T19:43:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f70560d1b10bee6a17bb975710a0a3ffee2a005","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/7595/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/7595/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/7595/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/30982c4d27634b019e0c4e1238bff0eee7797344","head":{"label":"jolyonb:jolyonb/printing_cleanup","ref":"jolyonb/printing_cleanup","sha":"30982c4d27634b019e0c4e1238bff0eee7797344","user":{"login":"jolyonb","id":6232546,"avatar_url":"https://avatars.githubusercontent.com/u/6232546?v=3","gravatar_id":"","url":"https://api.github.com/users/jolyonb","html_url":"https://github.com/jolyonb","followers_url":"https://api.github.com/users/jolyonb/followers","following_url":"https://api.github.com/users/jolyonb/following{/other_user}","gists_url":"https://api.github.com/users/jolyonb/gists{/gist_id}","starred_url":"https://api.github.com/users/jolyonb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jolyonb/subscriptions","organizations_url":"https://api.github.com/users/jolyonb/orgs","repos_url":"https://api.github.com/users/jolyonb/repos","events_url":"https://api.github.com/users/jolyonb/events{/privacy}","received_events_url":"https://api.github.com/users/jolyonb/received_events","type":"User","site_admin":false},"repo":{"id":33374609,"name":"edx-platform","full_name":"jolyonb/edx-platform","owner":{"login":"jolyonb","id":6232546,"avatar_url":"https://avatars.githubusercontent.com/u/6232546?v=3","gravatar_id":"","url":"https://api.github.com/users/jolyonb","html_url":"https://github.com/jolyonb","followers_url":"https://api.github.com/users/jolyonb/followers","following_url":"https://api.github.com/users/jolyonb/following{/other_user}","gists_url":"https://api.github.com/users/jolyonb/gists{/gist_id}","starred_url":"https://api.github.com/users/jolyonb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jolyonb/subscriptions","organizations_url":"https://api.github.com/users/jolyonb/orgs","repos_url":"https://api.github.com/users/jolyonb/repos","events_url":"https://api.github.com/users/jolyonb/events{/privacy}","received_events_url":"https://api.github.com/users/jolyonb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jolyonb/edx-platform","description":"Open edX, the edX platform that powers http://edx.org","fork":true,"url":"https://api.github.com/repos/jolyonb/edx-platform","forks_url":"https://api.github.com/repos/jolyonb/edx-platform/forks","keys_url":"https://api.github.com/repos/jolyonb/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jolyonb/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jolyonb/edx-platform/teams","hooks_url":"https://api.github.com/repos/jolyonb/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/jolyonb/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/jolyonb/edx-platform/events","assignees_url":"https://api.github.com/repos/jolyonb/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/jolyonb/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/jolyonb/edx-platform/tags","blobs_url":"https://api.github.com/repos/jolyonb/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jolyonb/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jolyonb/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/jolyonb/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jolyonb/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/jolyonb/edx-platform/languages","stargazers_url":"https://api.github.com/repos/jolyonb/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/jolyonb/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/jolyonb/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/jolyonb/edx-platform/subscription","commits_url":"https://api.github.com/repos/jolyonb/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/jolyonb/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/jolyonb/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/jolyonb/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/jolyonb/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/jolyonb/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jolyonb/edx-platform/merges","archive_url":"https://api.github.com/repos/jolyonb/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jolyonb/edx-platform/downloads","issues_url":"https://api.github.com/repos/jolyonb/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/jolyonb/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/jolyonb/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/jolyonb/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jolyonb/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/jolyonb/edx-platform/releases{/id}","created_at":"2015-04-03T17:33:14Z","updated_at":"2015-04-03T17:33:47Z","pushed_at":"2015-04-04T17:39:37Z","git_url":"git://github.com/jolyonb/edx-platform.git","ssh_url":"git@github.com:jolyonb/edx-platform.git","clone_url":"https://github.com/jolyonb/edx-platform.git","svn_url":"https://github.com/jolyonb/edx-platform","homepage":"http://openedx.org/","size":452467,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"83e391ee9fcd854460456414f7f1c8f90cdddd57","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"Open edX, the edX platform that powers http://edx.org","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2015-04-17T18:23:04Z","pushed_at":"2015-04-17T19:41:26Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://openedx.org/","size":1867927,"stargazers_count":1867,"watchers_count":1867,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1066,"mirror_url":null,"open_issues_count":150,"forks":1066,"open_issues":150,"watchers":1867,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/7595"},"html":{"href":"https://github.com/edx/edx-platform/pull/7595"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/7595"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/7595/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/7595/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/7595/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/30982c4d27634b019e0c4e1238bff0eee7797344"}}}}