{"action":"created","comment":{"url":"https://api.github.com/repos/quattor/template-library-os/pulls/comments/29751623","id":29751623,"diff_hunk":"@@ -1,39 +1,39 @@\n-#######################################################################\n-#\n-# Standard repositories to use for the OS for YUM-based deployment\n-#\n-#######################################################################\n-\n-unique template repository/config/os;\n-\n-include { 'quattor/functions/repository' };\n-\n-@{\n-desc =  if true, add epel-testing repository\n-values = true or false\n-default = false\n-required = no\n-}\n-variable REPOSITORY_EPEL_TESTING_ENABLED ?= false;\n-\n-variable YUM_SNAPSHOT_NS ?= 'repository/snapshot';\n-variable YUM_OS_SNAPSHOT_NS ?= YUM_SNAPSHOT_NS;\n-\n-# Ordered list of repository to load\n-# NOTE: The repository which contains the AII rpms must be listed\n-# first in the list.  If not, then AII installations will fail\n-# because the post-install script will look in the wrong place.\n-include { 'repository/config/quattor' };\n-variable OS_REPOSITORY_LIST ?= {\n-    append(OS_VERSION_PARAMS['version']+'_'+OS_VERSION_PARAMS['arch']);\n-    append(OS_VERSION_PARAMS['version']+'_'+OS_VERSION_PARAMS['arch']+'_errata');\n-    append(OS_VERSION_PARAMS['version']+'_'+OS_VERSION_PARAMS['arch']+'_updates');\n-    append(OS_VERSION_PARAMS['major']+'_addons');\n-    append(OS_VERSION_PARAMS['major']+'_epel');\n-    if ( REPOSITORY_EPEL_TESTING_ENABLED ) {\n-      append(OS_VERSION_PARAMS['major']+'_epel_testing');\n-    };\n-    append('site');\n-};\n-\n-'/software/repositories' = add_repositories(OS_REPOSITORY_LIST,YUM_OS_SNAPSHOT_NS);\n+#######################################################################\r\n+#\r\n+# Standard repositories to use for the OS for YUM-based deployment\r\n+#\r\n+#######################################################################\r\n+ \r\n+unique template repository/config/os;\r\n+ \r\n+include { 'quattor/functions/repository' };\r\n+\r\n+@{\r\n+desc =  if true, add epel-testing repository\r\n+values = true or false\r\n+default = false\r\n+required = no\r\n+}\r\n+variable REPOSITORY_EPEL_TESTING_ENABLED ?= false;\r\n+\r\n+variable YUM_SNAPSHOT_NS ?= 'repository/snapshot';\r\n+variable YUM_OS_SNAPSHOT_NS ?= YUM_SNAPSHOT_NS;\r\n+\r\n+# Ordered list of repository to load\r","path":"repository/config/os.pan","position":null,"original_position":61,"commit_id":"ebab42cd32daa2688cc40fa2d9ff78276b8b0a6d","original_commit_id":"3ce69d40fbff2ee93609a247d225838ce215dc22","user":{"login":"jrha","id":323309,"avatar_url":"https://avatars.githubusercontent.com/u/323309?v=3","gravatar_id":"","url":"https://api.github.com/users/jrha","html_url":"https://github.com/jrha","followers_url":"https://api.github.com/users/jrha/followers","following_url":"https://api.github.com/users/jrha/following{/other_user}","gists_url":"https://api.github.com/users/jrha/gists{/gist_id}","starred_url":"https://api.github.com/users/jrha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrha/subscriptions","organizations_url":"https://api.github.com/users/jrha/orgs","repos_url":"https://api.github.com/users/jrha/repos","events_url":"https://api.github.com/users/jrha/events{/privacy}","received_events_url":"https://api.github.com/users/jrha/received_events","type":"User","site_admin":false},"body":"No problem! The comments are always attached to the line at the bottom of the preview window.","created_at":"2015-05-06T12:08:53Z","updated_at":"2015-05-06T12:08:53Z","html_url":"https://github.com/quattor/template-library-os/pull/69#discussion_r29751623","pull_request_url":"https://api.github.com/repos/quattor/template-library-os/pulls/69","_links":{"self":{"href":"https://api.github.com/repos/quattor/template-library-os/pulls/comments/29751623"},"html":{"href":"https://github.com/quattor/template-library-os/pull/69#discussion_r29751623"},"pull_request":{"href":"https://api.github.com/repos/quattor/template-library-os/pulls/69"}}},"pull_request":{"url":"https://api.github.com/repos/quattor/template-library-os/pulls/69","id":34447426,"html_url":"https://github.com/quattor/template-library-os/pull/69","diff_url":"https://github.com/quattor/template-library-os/pull/69.diff","patch_url":"https://github.com/quattor/template-library-os/pull/69.patch","issue_url":"https://api.github.com/repos/quattor/template-library-os/issues/69","number":69,"state":"open","locked":false,"title":"Fix EL7 support in OS templates","user":{"login":"jouvin","id":1511937,"avatar_url":"https://avatars.githubusercontent.com/u/1511937?v=3","gravatar_id":"","url":"https://api.github.com/users/jouvin","html_url":"https://github.com/jouvin","followers_url":"https://api.github.com/users/jouvin/followers","following_url":"https://api.github.com/users/jouvin/following{/other_user}","gists_url":"https://api.github.com/users/jouvin/gists{/gist_id}","starred_url":"https://api.github.com/users/jouvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jouvin/subscriptions","organizations_url":"https://api.github.com/users/jouvin/orgs","repos_url":"https://api.github.com/users/jouvin/repos","events_url":"https://api.github.com/users/jouvin/events{/privacy}","received_events_url":"https://api.github.com/users/jouvin/received_events","type":"User","site_admin":false},"body":"Note about CentOS: these templates use the YUM groups directly. But unfortunately, the `core` group lists a few RPMs that are not available in standard repos, related to some firmware (`ql2*` and `bfa`), most of them part of `linux-firmware`RPM. My workaround is to copy the EL6 version of these missing RPMs into a site specific repo so that they can be resolved. I think this should not pose any problem as device firmware is not OS version specific.\r\n\r\nSL doesn't have this problem. I will try to open an issue at CentOS about this.","created_at":"2015-04-30T10:36:56Z","updated_at":"2015-05-06T12:08:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75e433894ffb443dfeb81a8100e89123ee3e3415","assignee":null,"milestone":{"url":"https://api.github.com/repos/quattor/template-library-os/milestones/5","html_url":"https://github.com/quattor/template-library-os/milestones/15.4","labels_url":"https://api.github.com/repos/quattor/template-library-os/milestones/5/labels","id":811166,"number":5,"title":"15.4","description":null,"creator":{"login":"jrha","id":323309,"avatar_url":"https://avatars.githubusercontent.com/u/323309?v=3","gravatar_id":"","url":"https://api.github.com/users/jrha","html_url":"https://github.com/jrha","followers_url":"https://api.github.com/users/jrha/followers","following_url":"https://api.github.com/users/jrha/following{/other_user}","gists_url":"https://api.github.com/users/jrha/gists{/gist_id}","starred_url":"https://api.github.com/users/jrha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrha/subscriptions","organizations_url":"https://api.github.com/users/jrha/orgs","repos_url":"https://api.github.com/users/jrha/repos","events_url":"https://api.github.com/users/jrha/events{/privacy}","received_events_url":"https://api.github.com/users/jrha/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":3,"state":"open","created_at":"2014-10-02T10:31:07Z","updated_at":"2015-04-30T10:36:56Z","due_on":"2015-04-28T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/quattor/template-library-os/pulls/69/commits","review_comments_url":"https://api.github.com/repos/quattor/template-library-os/pulls/69/comments","review_comment_url":"https://api.github.com/repos/quattor/template-library-os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quattor/template-library-os/issues/69/comments","statuses_url":"https://api.github.com/repos/quattor/template-library-os/statuses/ebab42cd32daa2688cc40fa2d9ff78276b8b0a6d","head":{"label":"jouvin:el7_support","ref":"el7_support","sha":"ebab42cd32daa2688cc40fa2d9ff78276b8b0a6d","user":{"login":"jouvin","id":1511937,"avatar_url":"https://avatars.githubusercontent.com/u/1511937?v=3","gravatar_id":"","url":"https://api.github.com/users/jouvin","html_url":"https://github.com/jouvin","followers_url":"https://api.github.com/users/jouvin/followers","following_url":"https://api.github.com/users/jouvin/following{/other_user}","gists_url":"https://api.github.com/users/jouvin/gists{/gist_id}","starred_url":"https://api.github.com/users/jouvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jouvin/subscriptions","organizations_url":"https://api.github.com/users/jouvin/orgs","repos_url":"https://api.github.com/users/jouvin/repos","events_url":"https://api.github.com/users/jouvin/events{/privacy}","received_events_url":"https://api.github.com/users/jouvin/received_events","type":"User","site_admin":false},"repo":{"id":13407463,"name":"template-library-os","full_name":"jouvin/template-library-os","owner":{"login":"jouvin","id":1511937,"avatar_url":"https://avatars.githubusercontent.com/u/1511937?v=3","gravatar_id":"","url":"https://api.github.com/users/jouvin","html_url":"https://github.com/jouvin","followers_url":"https://api.github.com/users/jouvin/followers","following_url":"https://api.github.com/users/jouvin/following{/other_user}","gists_url":"https://api.github.com/users/jouvin/gists{/gist_id}","starred_url":"https://api.github.com/users/jouvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jouvin/subscriptions","organizations_url":"https://api.github.com/users/jouvin/orgs","repos_url":"https://api.github.com/users/jouvin/repos","events_url":"https://api.github.com/users/jouvin/events{/privacy}","received_events_url":"https://api.github.com/users/jouvin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jouvin/template-library-os","description":"Template library for configuring OS","fork":true,"url":"https://api.github.com/repos/jouvin/template-library-os","forks_url":"https://api.github.com/repos/jouvin/template-library-os/forks","keys_url":"https://api.github.com/repos/jouvin/template-library-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jouvin/template-library-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jouvin/template-library-os/teams","hooks_url":"https://api.github.com/repos/jouvin/template-library-os/hooks","issue_events_url":"https://api.github.com/repos/jouvin/template-library-os/issues/events{/number}","events_url":"https://api.github.com/repos/jouvin/template-library-os/events","assignees_url":"https://api.github.com/repos/jouvin/template-library-os/assignees{/user}","branches_url":"https://api.github.com/repos/jouvin/template-library-os/branches{/branch}","tags_url":"https://api.github.com/repos/jouvin/template-library-os/tags","blobs_url":"https://api.github.com/repos/jouvin/template-library-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jouvin/template-library-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jouvin/template-library-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/jouvin/template-library-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jouvin/template-library-os/statuses/{sha}","languages_url":"https://api.github.com/repos/jouvin/template-library-os/languages","stargazers_url":"https://api.github.com/repos/jouvin/template-library-os/stargazers","contributors_url":"https://api.github.com/repos/jouvin/template-library-os/contributors","subscribers_url":"https://api.github.com/repos/jouvin/template-library-os/subscribers","subscription_url":"https://api.github.com/repos/jouvin/template-library-os/subscription","commits_url":"https://api.github.com/repos/jouvin/template-library-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/jouvin/template-library-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/jouvin/template-library-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/jouvin/template-library-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/jouvin/template-library-os/contents/{+path}","compare_url":"https://api.github.com/repos/jouvin/template-library-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jouvin/template-library-os/merges","archive_url":"https://api.github.com/repos/jouvin/template-library-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jouvin/template-library-os/downloads","issues_url":"https://api.github.com/repos/jouvin/template-library-os/issues{/number}","pulls_url":"https://api.github.com/repos/jouvin/template-library-os/pulls{/number}","milestones_url":"https://api.github.com/repos/jouvin/template-library-os/milestones{/number}","notifications_url":"https://api.github.com/repos/jouvin/template-library-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jouvin/template-library-os/labels{/name}","releases_url":"https://api.github.com/repos/jouvin/template-library-os/releases{/id}","created_at":"2013-10-08T08:15:36Z","updated_at":"2014-08-13T15:14:33Z","pushed_at":"2015-05-06T11:20:55Z","git_url":"git://github.com/jouvin/template-library-os.git","ssh_url":"git@github.com:jouvin/template-library-os.git","clone_url":"https://github.com/jouvin/template-library-os.git","svn_url":"https://github.com/jouvin/template-library-os","homepage":null,"size":2366,"stargazers_count":1,"watchers_count":1,"language":"Pan","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"sl6.x-x86_64"}},"base":{"label":"quattor:el7.x-x86_64","ref":"el7.x-x86_64","sha":"a56f6d5394cddf1c79cc8c7c684e2d25636bdc68","user":{"login":"quattor","id":1557169,"avatar_url":"https://avatars.githubusercontent.com/u/1557169?v=3","gravatar_id":"","url":"https://api.github.com/users/quattor","html_url":"https://github.com/quattor","followers_url":"https://api.github.com/users/quattor/followers","following_url":"https://api.github.com/users/quattor/following{/other_user}","gists_url":"https://api.github.com/users/quattor/gists{/gist_id}","starred_url":"https://api.github.com/users/quattor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quattor/subscriptions","organizations_url":"https://api.github.com/users/quattor/orgs","repos_url":"https://api.github.com/users/quattor/repos","events_url":"https://api.github.com/users/quattor/events{/privacy}","received_events_url":"https://api.github.com/users/quattor/received_events","type":"Organization","site_admin":false},"repo":{"id":13247223,"name":"template-library-os","full_name":"quattor/template-library-os","owner":{"login":"quattor","id":1557169,"avatar_url":"https://avatars.githubusercontent.com/u/1557169?v=3","gravatar_id":"","url":"https://api.github.com/users/quattor","html_url":"https://github.com/quattor","followers_url":"https://api.github.com/users/quattor/followers","following_url":"https://api.github.com/users/quattor/following{/other_user}","gists_url":"https://api.github.com/users/quattor/gists{/gist_id}","starred_url":"https://api.github.com/users/quattor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quattor/subscriptions","organizations_url":"https://api.github.com/users/quattor/orgs","repos_url":"https://api.github.com/users/quattor/repos","events_url":"https://api.github.com/users/quattor/events{/privacy}","received_events_url":"https://api.github.com/users/quattor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quattor/template-library-os","description":"Template library for configuring OS","fork":false,"url":"https://api.github.com/repos/quattor/template-library-os","forks_url":"https://api.github.com/repos/quattor/template-library-os/forks","keys_url":"https://api.github.com/repos/quattor/template-library-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quattor/template-library-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quattor/template-library-os/teams","hooks_url":"https://api.github.com/repos/quattor/template-library-os/hooks","issue_events_url":"https://api.github.com/repos/quattor/template-library-os/issues/events{/number}","events_url":"https://api.github.com/repos/quattor/template-library-os/events","assignees_url":"https://api.github.com/repos/quattor/template-library-os/assignees{/user}","branches_url":"https://api.github.com/repos/quattor/template-library-os/branches{/branch}","tags_url":"https://api.github.com/repos/quattor/template-library-os/tags","blobs_url":"https://api.github.com/repos/quattor/template-library-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quattor/template-library-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quattor/template-library-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/quattor/template-library-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quattor/template-library-os/statuses/{sha}","languages_url":"https://api.github.com/repos/quattor/template-library-os/languages","stargazers_url":"https://api.github.com/repos/quattor/template-library-os/stargazers","contributors_url":"https://api.github.com/repos/quattor/template-library-os/contributors","subscribers_url":"https://api.github.com/repos/quattor/template-library-os/subscribers","subscription_url":"https://api.github.com/repos/quattor/template-library-os/subscription","commits_url":"https://api.github.com/repos/quattor/template-library-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/quattor/template-library-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/quattor/template-library-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/quattor/template-library-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/quattor/template-library-os/contents/{+path}","compare_url":"https://api.github.com/repos/quattor/template-library-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quattor/template-library-os/merges","archive_url":"https://api.github.com/repos/quattor/template-library-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quattor/template-library-os/downloads","issues_url":"https://api.github.com/repos/quattor/template-library-os/issues{/number}","pulls_url":"https://api.github.com/repos/quattor/template-library-os/pulls{/number}","milestones_url":"https://api.github.com/repos/quattor/template-library-os/milestones{/number}","notifications_url":"https://api.github.com/repos/quattor/template-library-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quattor/template-library-os/labels{/name}","releases_url":"https://api.github.com/repos/quattor/template-library-os/releases{/id}","created_at":"2013-10-01T15:08:30Z","updated_at":"2015-03-23T16:45:52Z","pushed_at":"2015-05-06T11:20:55Z","git_url":"git://github.com/quattor/template-library-os.git","ssh_url":"git@github.com:quattor/template-library-os.git","clone_url":"https://github.com/quattor/template-library-os.git","svn_url":"https://github.com/quattor/template-library-os","homepage":null,"size":3482,"stargazers_count":1,"watchers_count":1,"language":"Pan","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":1,"forks":8,"open_issues":1,"watchers":1,"default_branch":"sl6.x-x86_64"}},"_links":{"self":{"href":"https://api.github.com/repos/quattor/template-library-os/pulls/69"},"html":{"href":"https://github.com/quattor/template-library-os/pull/69"},"issue":{"href":"https://api.github.com/repos/quattor/template-library-os/issues/69"},"comments":{"href":"https://api.github.com/repos/quattor/template-library-os/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/quattor/template-library-os/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/quattor/template-library-os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quattor/template-library-os/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/quattor/template-library-os/statuses/ebab42cd32daa2688cc40fa2d9ff78276b8b0a6d"}}}}