{"action":"created","comment":{"url":"https://api.github.com/repos/sul-dlss/blacklight-maps/pulls/comments/22718080","id":22718080,"diff_hunk":"@@ -34,5 +34,5 @@\n \n \n RSpec.configure do |config|\n-\n+  config.infer_spec_type_from_file_location!","path":"spec/spec_helper.rb","position":5,"original_position":5,"commit_id":"bb62590e45baca2ebfbc7ba015e13c66e4ef98f3","original_commit_id":"bb62590e45baca2ebfbc7ba015e13c66e4ef98f3","user":{"login":"ebenenglish","id":2079425,"avatar_url":"https://avatars.githubusercontent.com/u/2079425?v=3","gravatar_id":"","url":"https://api.github.com/users/ebenenglish","html_url":"https://github.com/ebenenglish","followers_url":"https://api.github.com/users/ebenenglish/followers","following_url":"https://api.github.com/users/ebenenglish/following{/other_user}","gists_url":"https://api.github.com/users/ebenenglish/gists{/gist_id}","starred_url":"https://api.github.com/users/ebenenglish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebenenglish/subscriptions","organizations_url":"https://api.github.com/users/ebenenglish/orgs","repos_url":"https://api.github.com/users/ebenenglish/repos","events_url":"https://api.github.com/users/ebenenglish/events{/privacy}","received_events_url":"https://api.github.com/users/ebenenglish/received_events","type":"User","site_admin":false},"body":"Seems fine.","created_at":"2015-01-09T14:31:51Z","updated_at":"2015-01-09T14:31:51Z","html_url":"https://github.com/sul-dlss/blacklight-maps/pull/55#discussion_r22718080","pull_request_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/pulls/55","_links":{"self":{"href":"https://api.github.com/repos/sul-dlss/blacklight-maps/pulls/comments/22718080"},"html":{"href":"https://github.com/sul-dlss/blacklight-maps/pull/55#discussion_r22718080"},"pull_request":{"href":"https://api.github.com/repos/sul-dlss/blacklight-maps/pulls/55"}}},"pull_request":{"url":"https://api.github.com/repos/sul-dlss/blacklight-maps/pulls/55","id":26904813,"html_url":"https://github.com/sul-dlss/blacklight-maps/pull/55","diff_url":"https://github.com/sul-dlss/blacklight-maps/pull/55.diff","patch_url":"https://github.com/sul-dlss/blacklight-maps/pull/55.patch","issue_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/issues/55","number":55,"state":"open","locked":false,"title":"HydraConnect refactor","user":{"login":"ebenenglish","id":2079425,"avatar_url":"https://avatars.githubusercontent.com/u/2079425?v=3","gravatar_id":"","url":"https://api.github.com/users/ebenenglish","html_url":"https://github.com/ebenenglish","followers_url":"https://api.github.com/users/ebenenglish/followers","following_url":"https://api.github.com/users/ebenenglish/following{/other_user}","gists_url":"https://api.github.com/users/ebenenglish/gists{/gist_id}","starred_url":"https://api.github.com/users/ebenenglish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebenenglish/subscriptions","organizations_url":"https://api.github.com/users/ebenenglish/orgs","repos_url":"https://api.github.com/users/ebenenglish/repos","events_url":"https://api.github.com/users/ebenenglish/events{/privacy}","received_events_url":"https://api.github.com/users/ebenenglish/received_events","type":"User","site_admin":false},"body":"So here's the refactor based on our discussions at Hydra Connect and on the Blacklight-development list. To summarize, the main changes are:\r\n\r\n* add catalog#map view which displays all objects in Solr index with geospatial data\r\n* catalog#index map view uses facet data to populate map, so all results are immediately viewable (rather than just current page's worth of items)\r\n* maplet widget available for catalog#show view\r\n* use GeoJSON to store coordinates with placenames in Solr\r\n* marker popups display location name (or coordinates) and link to search params (rather than displaying results in the map view itself)\r\n* marker clusters/markers display number of hits, rather than locations\r\n* search control on map allows search for all items within current map window bounds\r\n* map bounds and zoom are set dynamically when more than one location displayed on map\r\n* add spatial search functionality to Blacklight\r\n* render spatial constraints in catalog#index\r\n\r\nNote: there are a handful of tests that are 'pending' because I couldn't get them passing despite extensive effort. But, they seemed important so I left them in -- hopefully someone can get these working?\r\n\r\nOther note: I haven't updated the version. Let me know if that's something I should be doing before submitting the PR.\r\n\r\nThanks for everyone's patience on this!","created_at":"2015-01-06T17:46:54Z","updated_at":"2015-01-09T14:31:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4620d4280d7e6c6fe29dc68fb9701a8ca9810b5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/pulls/55/commits","review_comments_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/pulls/55/comments","review_comment_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/issues/55/comments","statuses_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/statuses/bb62590e45baca2ebfbc7ba015e13c66e4ef98f3","head":{"label":"boston-library:hydra-connect-refactor","ref":"hydra-connect-refactor","sha":"bb62590e45baca2ebfbc7ba015e13c66e4ef98f3","user":{"login":"boston-library","id":1944955,"avatar_url":"https://avatars.githubusercontent.com/u/1944955?v=3","gravatar_id":"","url":"https://api.github.com/users/boston-library","html_url":"https://github.com/boston-library","followers_url":"https://api.github.com/users/boston-library/followers","following_url":"https://api.github.com/users/boston-library/following{/other_user}","gists_url":"https://api.github.com/users/boston-library/gists{/gist_id}","starred_url":"https://api.github.com/users/boston-library/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boston-library/subscriptions","organizations_url":"https://api.github.com/users/boston-library/orgs","repos_url":"https://api.github.com/users/boston-library/repos","events_url":"https://api.github.com/users/boston-library/events{/privacy}","received_events_url":"https://api.github.com/users/boston-library/received_events","type":"Organization","site_admin":false},"repo":{"id":18890117,"name":"blacklight-maps","full_name":"boston-library/blacklight-maps","owner":{"login":"boston-library","id":1944955,"avatar_url":"https://avatars.githubusercontent.com/u/1944955?v=3","gravatar_id":"","url":"https://api.github.com/users/boston-library","html_url":"https://github.com/boston-library","followers_url":"https://api.github.com/users/boston-library/followers","following_url":"https://api.github.com/users/boston-library/following{/other_user}","gists_url":"https://api.github.com/users/boston-library/gists{/gist_id}","starred_url":"https://api.github.com/users/boston-library/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boston-library/subscriptions","organizations_url":"https://api.github.com/users/boston-library/orgs","repos_url":"https://api.github.com/users/boston-library/repos","events_url":"https://api.github.com/users/boston-library/events{/privacy}","received_events_url":"https://api.github.com/users/boston-library/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/boston-library/blacklight-maps","description":"Map search results view for Blacklight","fork":true,"url":"https://api.github.com/repos/boston-library/blacklight-maps","forks_url":"https://api.github.com/repos/boston-library/blacklight-maps/forks","keys_url":"https://api.github.com/repos/boston-library/blacklight-maps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boston-library/blacklight-maps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boston-library/blacklight-maps/teams","hooks_url":"https://api.github.com/repos/boston-library/blacklight-maps/hooks","issue_events_url":"https://api.github.com/repos/boston-library/blacklight-maps/issues/events{/number}","events_url":"https://api.github.com/repos/boston-library/blacklight-maps/events","assignees_url":"https://api.github.com/repos/boston-library/blacklight-maps/assignees{/user}","branches_url":"https://api.github.com/repos/boston-library/blacklight-maps/branches{/branch}","tags_url":"https://api.github.com/repos/boston-library/blacklight-maps/tags","blobs_url":"https://api.github.com/repos/boston-library/blacklight-maps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boston-library/blacklight-maps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boston-library/blacklight-maps/git/refs{/sha}","trees_url":"https://api.github.com/repos/boston-library/blacklight-maps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boston-library/blacklight-maps/statuses/{sha}","languages_url":"https://api.github.com/repos/boston-library/blacklight-maps/languages","stargazers_url":"https://api.github.com/repos/boston-library/blacklight-maps/stargazers","contributors_url":"https://api.github.com/repos/boston-library/blacklight-maps/contributors","subscribers_url":"https://api.github.com/repos/boston-library/blacklight-maps/subscribers","subscription_url":"https://api.github.com/repos/boston-library/blacklight-maps/subscription","commits_url":"https://api.github.com/repos/boston-library/blacklight-maps/commits{/sha}","git_commits_url":"https://api.github.com/repos/boston-library/blacklight-maps/git/commits{/sha}","comments_url":"https://api.github.com/repos/boston-library/blacklight-maps/comments{/number}","issue_comment_url":"https://api.github.com/repos/boston-library/blacklight-maps/issues/comments/{number}","contents_url":"https://api.github.com/repos/boston-library/blacklight-maps/contents/{+path}","compare_url":"https://api.github.com/repos/boston-library/blacklight-maps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boston-library/blacklight-maps/merges","archive_url":"https://api.github.com/repos/boston-library/blacklight-maps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boston-library/blacklight-maps/downloads","issues_url":"https://api.github.com/repos/boston-library/blacklight-maps/issues{/number}","pulls_url":"https://api.github.com/repos/boston-library/blacklight-maps/pulls{/number}","milestones_url":"https://api.github.com/repos/boston-library/blacklight-maps/milestones{/number}","notifications_url":"https://api.github.com/repos/boston-library/blacklight-maps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boston-library/blacklight-maps/labels{/name}","releases_url":"https://api.github.com/repos/boston-library/blacklight-maps/releases{/id}","created_at":"2014-04-17T19:04:24Z","updated_at":"2014-12-10T21:02:54Z","pushed_at":"2015-01-06T17:25:20Z","git_url":"git://github.com/boston-library/blacklight-maps.git","ssh_url":"git@github.com:boston-library/blacklight-maps.git","clone_url":"https://github.com/boston-library/blacklight-maps.git","svn_url":"https://github.com/boston-library/blacklight-maps","homepage":"","size":662,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sul-dlss:master","ref":"master","sha":"3152dc50c8c40c38edff0bcccb80678dde024208","user":{"login":"sul-dlss","id":230583,"avatar_url":"https://avatars.githubusercontent.com/u/230583?v=3","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"repo":{"id":17373888,"name":"blacklight-maps","full_name":"sul-dlss/blacklight-maps","owner":{"login":"sul-dlss","id":230583,"avatar_url":"https://avatars.githubusercontent.com/u/230583?v=3","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sul-dlss/blacklight-maps","description":"Map search results view for Blacklight","fork":false,"url":"https://api.github.com/repos/sul-dlss/blacklight-maps","forks_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/forks","keys_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/teams","hooks_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/hooks","issue_events_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/issues/events{/number}","events_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/events","assignees_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/assignees{/user}","branches_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/branches{/branch}","tags_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/tags","blobs_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/git/refs{/sha}","trees_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/statuses/{sha}","languages_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/languages","stargazers_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/stargazers","contributors_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/contributors","subscribers_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/subscribers","subscription_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/subscription","commits_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/commits{/sha}","git_commits_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/git/commits{/sha}","comments_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/comments{/number}","issue_comment_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/issues/comments/{number}","contents_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/contents/{+path}","compare_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/merges","archive_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/downloads","issues_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/issues{/number}","pulls_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/pulls{/number}","milestones_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/milestones{/number}","notifications_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/labels{/name}","releases_url":"https://api.github.com/repos/sul-dlss/blacklight-maps/releases{/id}","created_at":"2014-03-03T17:32:27Z","updated_at":"2015-01-08T23:52:38Z","pushed_at":"2015-01-08T23:52:38Z","git_url":"git://github.com/sul-dlss/blacklight-maps.git","ssh_url":"git@github.com:sul-dlss/blacklight-maps.git","clone_url":"https://github.com/sul-dlss/blacklight-maps.git","svn_url":"https://github.com/sul-dlss/blacklight-maps","homepage":"","size":1066,"stargazers_count":6,"watchers_count":6,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":15,"forks":1,"open_issues":15,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sul-dlss/blacklight-maps/pulls/55"},"html":{"href":"https://github.com/sul-dlss/blacklight-maps/pull/55"},"issue":{"href":"https://api.github.com/repos/sul-dlss/blacklight-maps/issues/55"},"comments":{"href":"https://api.github.com/repos/sul-dlss/blacklight-maps/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/sul-dlss/blacklight-maps/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/sul-dlss/blacklight-maps/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sul-dlss/blacklight-maps/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/sul-dlss/blacklight-maps/statuses/bb62590e45baca2ebfbc7ba015e13c66e4ef98f3"}}}}