{"action":"created","issue":{"url":"https://api.github.com/repos/wildfly/wildfly/issues/7806","labels_url":"https://api.github.com/repos/wildfly/wildfly/issues/7806/labels{/name}","comments_url":"https://api.github.com/repos/wildfly/wildfly/issues/7806/comments","events_url":"https://api.github.com/repos/wildfly/wildfly/issues/7806/events","html_url":"https://github.com/wildfly/wildfly/pull/7806","id":96370292,"number":7806,"title":"[WFLY-4811] Add new batch-jberet subsystems","user":{"login":"jamezp","id":420065,"avatar_url":"https://avatars.githubusercontent.com/u/420065?v=3","gravatar_id":"","url":"https://api.github.com/users/jamezp","html_url":"https://github.com/jamezp","followers_url":"https://api.github.com/users/jamezp/followers","following_url":"https://api.github.com/users/jamezp/following{/other_user}","gists_url":"https://api.github.com/users/jamezp/gists{/gist_id}","starred_url":"https://api.github.com/users/jamezp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamezp/subscriptions","organizations_url":"https://api.github.com/users/jamezp/orgs","repos_url":"https://api.github.com/users/jamezp/repos","events_url":"https://api.github.com/users/jamezp/events{/privacy}","received_events_url":"https://api.github.com/users/jamezp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":25,"created_at":"2015-07-21T17:19:08Z","updated_at":"2015-07-23T00:17:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wildfly/wildfly/pulls/7806","html_url":"https://github.com/wildfly/wildfly/pull/7806","diff_url":"https://github.com/wildfly/wildfly/pull/7806.diff","patch_url":"https://github.com/wildfly/wildfly/pull/7806.patch"},"body":"This PR adds a new `batch-jberet` subsystem.\r\n\r\n### First Commit\r\nThis commit reverts a change to the original batch subsystem that will only be allowed in the new subsystem.\r\n\r\n### Second Commit\r\nThis commit brings JBeret to a level required for the new subsystem.\r\n\r\n### Third Commit\r\nThis commit just changes a few things to prepare for the new subsystem. It could be squashed with the next commit, but for the review process it may be easier having it separate.\r\n\r\n### Fourth Commit\r\nThis commit is the addition of the new subsystem. The new subsystem model looks like the following.\r\n\r\n```\r\n{\r\n    \"default-job-repository\" => \"in-memory\",\r\n    \"default-thread-pool\" => \"batch\",\r\n    \"in-memory-job-repository\" => {\"in-memory\" => {}},\r\n    \"jdbc-job-repository\" => {\"jdbc\" => {\"data-source\" => \"test\"}},\r\n    \"thread-factory\" => undefined,\r\n    \"thread-pool\" => {\"batch\" => {\r\n        \"keepalive-time\" => {\r\n            \"time\" => 30L,\r\n            \"unit\" => \"SECONDS\"\r\n        },\r\n        \"max-threads\" => 10,\r\n        \"name\" => \"batch\",\r\n        \"thread-factory\" => undefined\r\n    }}\r\n}\r\n```\r\n\r\nThis new model allows for the use of capabilities & requirements as well as hopefully cleans up the user experience. The `default-job-repository` and `default-thread-pool` attributes seem a bit awkward to me, but allow the deployments to work without a deployment descriptor.\r\n\r\nThe JNDI name is no longer used for a `jdbc-job-repository`. The data source capability is used and the data source is no longer looked up via a JNDI lookup.\r\n\r\nMultiple thread pools and job repositories are allowed to be defined. The `jboss-all.xml` deployment descriptor can be used to define specific job repositories or thread pools to the deployment.\r\n\r\nOnce this is acceptable I will submit a PR for the capabilities documentation.\r\n\r\n### Fifth Commit\r\nThis is just the tests and can be squashed with the third commit. I only left this separate as it may be easier to review the commits separated."},"comment":{"url":"https://api.github.com/repos/wildfly/wildfly/issues/comments/123913589","html_url":"https://github.com/wildfly/wildfly/pull/7806#issuecomment-123913589","issue_url":"https://api.github.com/repos/wildfly/wildfly/issues/7806","id":123913589,"user":{"login":"wildfly-ci","id":939955,"avatar_url":"https://avatars.githubusercontent.com/u/939955?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly-ci","html_url":"https://github.com/wildfly-ci","followers_url":"https://api.github.com/users/wildfly-ci/followers","following_url":"https://api.github.com/users/wildfly-ci/following{/other_user}","gists_url":"https://api.github.com/users/wildfly-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly-ci/subscriptions","organizations_url":"https://api.github.com/users/wildfly-ci/orgs","repos_url":"https://api.github.com/users/wildfly-ci/repos","events_url":"https://api.github.com/users/wildfly-ci/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly-ci/received_events","type":"User","site_admin":false},"created_at":"2015-07-23T00:17:40Z","updated_at":"2015-07-23T00:17:40Z","body":"**Windows** [Build 2199](http://brontes.lab.eng.brq.redhat.com/viewLog.html?buildId=61918&buildTypeId=WF_PullRequest_Windows) outcome was **FAILURE** using a merge of 44b096db24a094b4ead9a81b1ab6014d5853bc3d\nSummary: Tests failed: 9, passed: 2961, ignored: 357 Build time: 0:48:54\n### Build problems:\nFailed tests detected\n\n### Failed tests\n```\norg.jboss.as.test.integration.security.jacc.JACCAuthzPropagationTestCase.testBridge: <no details avaliable>\n\norg.jboss.as.test.integration.security.jacc.JACCAuthzPropagationTestCase.testTarget: <no details avaliable>\n\norg.jboss.as.test.integration.security.jacc.JACCForEarModulesTestCase.testWebPermissions: <no details avaliable>\n\norg.jboss.as.test.integration.security.jacc.JACCForEarModulesTestCase.testEJBPermissions: <no details avaliable>\n\norg.jboss.as.test.integration.security.jacc.JACCTranslateServletDDTestCase.testHTTPMethodCanonical: <no details avaliable>\n\norg.jboss.as.test.integration.security.jacc.JACCTranslateServletDDTestCase.testConnectionType: <no details avaliable>\n\norg.jboss.as.test.integration.security.jacc.JACCTranslateServletDDTestCase.testQualifiedPatterns: <no details avaliable>\n\norg.jboss.as.test.clustering.xsite.XSiteSimpleTestCase.testPutRelayedToBackups: <no details avaliable>\n\norg.jboss.as.test.manualmode.ejb.client.cluster.EJBClientClusterConfigurationTestCase.testServerToServerClusterFormation: <no details avaliable>\n\n```\n"}}