{"action":"created","comment":{"url":"https://api.github.com/repos/kripken/emscripten-fastcomp/pulls/comments/32786148","id":32786148,"diff_hunk":"@@ -797,6 +803,22 @@ std::string JSWriter::getAssignIfNeeded(const Value *V) {\n   return std::string();\n }\n \n+std::string SIMDType(VectorType *t, bool caps = false) {\n+  bool isInt = t->getElementType()->isIntegerTy();\n+  int primSize = t->getElementType()->getPrimitiveSizeInBits();\n+  int numElems = t->getNumElements();\n+\n+  return (caps ? (isInt ? \"Int\" : \"Float\") : (isInt ? \"int\" : \"float\")) + std::to_string(primSize) + 'x' + std::to_string(numElems);\n+}\n+\n+std::string WrapMathFRound(const std::string &value, bool wrap) {","path":"lib/Target/JSBackend/JSBackend.cpp","position":47,"original_position":47,"commit_id":"0ce96530c0bb7dd3d88059872d999a582dc7f7ba","original_commit_id":"0ce96530c0bb7dd3d88059872d999a582dc7f7ba","user":{"login":"kripken","id":173661,"avatar_url":"https://avatars.githubusercontent.com/u/173661?v=3","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"body":"this is similar to `ensureFloat`. First of all, the name should begin with a lowercase letter. Second, how about also calling it `ensureFloat`, but overloaded with a second parameter which is a bool? And implementing it right after `ensureFloat`?","created_at":"2015-06-18T22:34:44Z","updated_at":"2015-06-18T22:34:44Z","html_url":"https://github.com/kripken/emscripten-fastcomp/pull/103#discussion_r32786148","pull_request_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/pulls/103","_links":{"self":{"href":"https://api.github.com/repos/kripken/emscripten-fastcomp/pulls/comments/32786148"},"html":{"href":"https://github.com/kripken/emscripten-fastcomp/pull/103#discussion_r32786148"},"pull_request":{"href":"https://api.github.com/repos/kripken/emscripten-fastcomp/pulls/103"}}},"pull_request":{"url":"https://api.github.com/repos/kripken/emscripten-fastcomp/pulls/103","id":37897218,"html_url":"https://github.com/kripken/emscripten-fastcomp/pull/103","diff_url":"https://github.com/kripken/emscripten-fastcomp/pull/103.diff","patch_url":"https://github.com/kripken/emscripten-fastcomp/pull/103.patch","issue_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/issues/103","number":103,"state":"open","locked":false,"title":"Add support for building SSE2 code to JS.","user":{"login":"juj","id":225351,"avatar_url":"https://avatars.githubusercontent.com/u/225351?v=3","gravatar_id":"","url":"https://api.github.com/users/juj","html_url":"https://github.com/juj","followers_url":"https://api.github.com/users/juj/followers","following_url":"https://api.github.com/users/juj/following{/other_user}","gists_url":"https://api.github.com/users/juj/gists{/gist_id}","starred_url":"https://api.github.com/users/juj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juj/subscriptions","organizations_url":"https://api.github.com/users/juj/orgs","repos_url":"https://api.github.com/users/juj/repos","events_url":"https://api.github.com/users/juj/events{/privacy}","received_events_url":"https://api.github.com/users/juj/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-17T12:56:15Z","updated_at":"2015-06-18T22:34:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8603d8498b06000b0174840c293c5cf9425fc695","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/pulls/103/commits","review_comments_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/pulls/103/comments","review_comment_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/issues/103/comments","statuses_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/statuses/0ce96530c0bb7dd3d88059872d999a582dc7f7ba","head":{"label":"juj:sse2","ref":"sse2","sha":"0ce96530c0bb7dd3d88059872d999a582dc7f7ba","user":{"login":"juj","id":225351,"avatar_url":"https://avatars.githubusercontent.com/u/225351?v=3","gravatar_id":"","url":"https://api.github.com/users/juj","html_url":"https://github.com/juj","followers_url":"https://api.github.com/users/juj/followers","following_url":"https://api.github.com/users/juj/following{/other_user}","gists_url":"https://api.github.com/users/juj/gists{/gist_id}","starred_url":"https://api.github.com/users/juj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juj/subscriptions","organizations_url":"https://api.github.com/users/juj/orgs","repos_url":"https://api.github.com/users/juj/repos","events_url":"https://api.github.com/users/juj/events{/privacy}","received_events_url":"https://api.github.com/users/juj/received_events","type":"User","site_admin":false},"repo":{"id":15361866,"name":"emscripten-fastcomp","full_name":"juj/emscripten-fastcomp","owner":{"login":"juj","id":225351,"avatar_url":"https://avatars.githubusercontent.com/u/225351?v=3","gravatar_id":"","url":"https://api.github.com/users/juj","html_url":"https://github.com/juj","followers_url":"https://api.github.com/users/juj/followers","following_url":"https://api.github.com/users/juj/following{/other_user}","gists_url":"https://api.github.com/users/juj/gists{/gist_id}","starred_url":"https://api.github.com/users/juj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juj/subscriptions","organizations_url":"https://api.github.com/users/juj/orgs","repos_url":"https://api.github.com/users/juj/repos","events_url":"https://api.github.com/users/juj/events{/privacy}","received_events_url":"https://api.github.com/users/juj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/juj/emscripten-fastcomp","description":"","fork":true,"url":"https://api.github.com/repos/juj/emscripten-fastcomp","forks_url":"https://api.github.com/repos/juj/emscripten-fastcomp/forks","keys_url":"https://api.github.com/repos/juj/emscripten-fastcomp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juj/emscripten-fastcomp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juj/emscripten-fastcomp/teams","hooks_url":"https://api.github.com/repos/juj/emscripten-fastcomp/hooks","issue_events_url":"https://api.github.com/repos/juj/emscripten-fastcomp/issues/events{/number}","events_url":"https://api.github.com/repos/juj/emscripten-fastcomp/events","assignees_url":"https://api.github.com/repos/juj/emscripten-fastcomp/assignees{/user}","branches_url":"https://api.github.com/repos/juj/emscripten-fastcomp/branches{/branch}","tags_url":"https://api.github.com/repos/juj/emscripten-fastcomp/tags","blobs_url":"https://api.github.com/repos/juj/emscripten-fastcomp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juj/emscripten-fastcomp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juj/emscripten-fastcomp/git/refs{/sha}","trees_url":"https://api.github.com/repos/juj/emscripten-fastcomp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juj/emscripten-fastcomp/statuses/{sha}","languages_url":"https://api.github.com/repos/juj/emscripten-fastcomp/languages","stargazers_url":"https://api.github.com/repos/juj/emscripten-fastcomp/stargazers","contributors_url":"https://api.github.com/repos/juj/emscripten-fastcomp/contributors","subscribers_url":"https://api.github.com/repos/juj/emscripten-fastcomp/subscribers","subscription_url":"https://api.github.com/repos/juj/emscripten-fastcomp/subscription","commits_url":"https://api.github.com/repos/juj/emscripten-fastcomp/commits{/sha}","git_commits_url":"https://api.github.com/repos/juj/emscripten-fastcomp/git/commits{/sha}","comments_url":"https://api.github.com/repos/juj/emscripten-fastcomp/comments{/number}","issue_comment_url":"https://api.github.com/repos/juj/emscripten-fastcomp/issues/comments{/number}","contents_url":"https://api.github.com/repos/juj/emscripten-fastcomp/contents/{+path}","compare_url":"https://api.github.com/repos/juj/emscripten-fastcomp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juj/emscripten-fastcomp/merges","archive_url":"https://api.github.com/repos/juj/emscripten-fastcomp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juj/emscripten-fastcomp/downloads","issues_url":"https://api.github.com/repos/juj/emscripten-fastcomp/issues{/number}","pulls_url":"https://api.github.com/repos/juj/emscripten-fastcomp/pulls{/number}","milestones_url":"https://api.github.com/repos/juj/emscripten-fastcomp/milestones{/number}","notifications_url":"https://api.github.com/repos/juj/emscripten-fastcomp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juj/emscripten-fastcomp/labels{/name}","releases_url":"https://api.github.com/repos/juj/emscripten-fastcomp/releases{/id}","created_at":"2013-12-21T16:27:08Z","updated_at":"2014-01-28T08:59:55Z","pushed_at":"2015-06-17T14:27:56Z","git_url":"git://github.com/juj/emscripten-fastcomp.git","ssh_url":"git@github.com:juj/emscripten-fastcomp.git","clone_url":"https://github.com/juj/emscripten-fastcomp.git","svn_url":"https://github.com/juj/emscripten-fastcomp","homepage":null,"size":194139,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kripken:incoming","ref":"incoming","sha":"dccd6517fcc00126e4e74d77c5a8fa06efd3a2ad","user":{"login":"kripken","id":173661,"avatar_url":"https://avatars.githubusercontent.com/u/173661?v=3","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"repo":{"id":14601190,"name":"emscripten-fastcomp","full_name":"kripken/emscripten-fastcomp","owner":{"login":"kripken","id":173661,"avatar_url":"https://avatars.githubusercontent.com/u/173661?v=3","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kripken/emscripten-fastcomp","description":"emscripten llvm","fork":false,"url":"https://api.github.com/repos/kripken/emscripten-fastcomp","forks_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/forks","keys_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/teams","hooks_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/hooks","issue_events_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/issues/events{/number}","events_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/events","assignees_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/assignees{/user}","branches_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/branches{/branch}","tags_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/tags","blobs_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/git/refs{/sha}","trees_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/statuses/{sha}","languages_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/languages","stargazers_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/stargazers","contributors_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/contributors","subscribers_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/subscribers","subscription_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/subscription","commits_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/commits{/sha}","git_commits_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/git/commits{/sha}","comments_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/comments{/number}","issue_comment_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/issues/comments{/number}","contents_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/contents/{+path}","compare_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/merges","archive_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/downloads","issues_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/issues{/number}","pulls_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/pulls{/number}","milestones_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/milestones{/number}","notifications_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/labels{/name}","releases_url":"https://api.github.com/repos/kripken/emscripten-fastcomp/releases{/id}","created_at":"2013-11-21T21:54:33Z","updated_at":"2015-06-16T19:50:58Z","pushed_at":"2015-06-18T20:38:32Z","git_url":"git://github.com/kripken/emscripten-fastcomp.git","ssh_url":"git@github.com:kripken/emscripten-fastcomp.git","clone_url":"https://github.com/kripken/emscripten-fastcomp.git","svn_url":"https://github.com/kripken/emscripten-fastcomp","homepage":"","size":232137,"stargazers_count":47,"watchers_count":47,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":13,"forks":38,"open_issues":13,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kripken/emscripten-fastcomp/pulls/103"},"html":{"href":"https://github.com/kripken/emscripten-fastcomp/pull/103"},"issue":{"href":"https://api.github.com/repos/kripken/emscripten-fastcomp/issues/103"},"comments":{"href":"https://api.github.com/repos/kripken/emscripten-fastcomp/issues/103/comments"},"review_comments":{"href":"https://api.github.com/repos/kripken/emscripten-fastcomp/pulls/103/comments"},"review_comment":{"href":"https://api.github.com/repos/kripken/emscripten-fastcomp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kripken/emscripten-fastcomp/pulls/103/commits"},"statuses":{"href":"https://api.github.com/repos/kripken/emscripten-fastcomp/statuses/0ce96530c0bb7dd3d88059872d999a582dc7f7ba"}}}}