{"action":"created","issue":{"url":"https://api.github.com/repos/ivolo/disposable-email-domains/issues/31","labels_url":"https://api.github.com/repos/ivolo/disposable-email-domains/issues/31/labels{/name}","comments_url":"https://api.github.com/repos/ivolo/disposable-email-domains/issues/31/comments","events_url":"https://api.github.com/repos/ivolo/disposable-email-domains/issues/31/events","html_url":"https://github.com/ivolo/disposable-email-domains/pull/31","id":111360926,"number":31,"title":"Add domains from DisposableEmailChecker","user":{"login":"aaronbassett","id":97928,"avatar_url":"https://avatars.githubusercontent.com/u/97928?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronbassett","html_url":"https://github.com/aaronbassett","followers_url":"https://api.github.com/users/aaronbassett/followers","following_url":"https://api.github.com/users/aaronbassett/following{/other_user}","gists_url":"https://api.github.com/users/aaronbassett/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronbassett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronbassett/subscriptions","organizations_url":"https://api.github.com/users/aaronbassett/orgs","repos_url":"https://api.github.com/users/aaronbassett/repos","events_url":"https://api.github.com/users/aaronbassett/events{/privacy}","received_events_url":"https://api.github.com/users/aaronbassett/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-14T09:44:27Z","updated_at":"2015-12-10T22:29:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ivolo/disposable-email-domains/pulls/31","html_url":"https://github.com/ivolo/disposable-email-domains/pull/31","diff_url":"https://github.com/ivolo/disposable-email-domains/pull/31.diff","patch_url":"https://github.com/ivolo/disposable-email-domains/pull/31.patch"},"body":"The [DisposableEmailChecker Django package](https://github.com/aaronbassett/DisposableEmailChecker) has about ~250 domains not listed here. I've added, deduped and sorted the two lists."},"comment":{"url":"https://api.github.com/repos/ivolo/disposable-email-domains/issues/comments/163769655","html_url":"https://github.com/ivolo/disposable-email-domains/pull/31#issuecomment-163769655","issue_url":"https://api.github.com/repos/ivolo/disposable-email-domains/issues/31","id":163769655,"user":{"login":"danhstevens","id":1061040,"avatar_url":"https://avatars.githubusercontent.com/u/1061040?v=3","gravatar_id":"","url":"https://api.github.com/users/danhstevens","html_url":"https://github.com/danhstevens","followers_url":"https://api.github.com/users/danhstevens/followers","following_url":"https://api.github.com/users/danhstevens/following{/other_user}","gists_url":"https://api.github.com/users/danhstevens/gists{/gist_id}","starred_url":"https://api.github.com/users/danhstevens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danhstevens/subscriptions","organizations_url":"https://api.github.com/users/danhstevens/orgs","repos_url":"https://api.github.com/users/danhstevens/repos","events_url":"https://api.github.com/users/danhstevens/events{/privacy}","received_events_url":"https://api.github.com/users/danhstevens/received_events","type":"User","site_admin":false},"created_at":"2015-12-10T22:29:55Z","updated_at":"2015-12-10T22:29:55Z","body":"Much appreciate the additional domains. That said, there are several issues that need to be addressed before I would merge it:\r\n\r\n- [ ] All domain names need to be lower-cased\r\n- [ ] Since this is a simple JSON list, wildcards (ex: `discardmail.*`) are not supported. Those need to be broken down into .com/.net/etc\r\n- [ ] Some domains aren't truly disposable and need to be identified and removed. `qq.com` is one such example. It's the Chinese equivalent of Yahoo.com. Low quality domain? Perhaps. But not, by definition, a disposable domain\r\n- [ ] Invalid domains need to be identified and removed (ex: `dm.w3internet.co.uk example.com`)\r\n- [ ] And, of course, the merge conflict"}}