{"action":"created","issue":{"url":"https://api.github.com/repos/Metaswitch/cpp-common/issues/340","labels_url":"https://api.github.com/repos/Metaswitch/cpp-common/issues/340/labels{/name}","comments_url":"https://api.github.com/repos/Metaswitch/cpp-common/issues/340/comments","events_url":"https://api.github.com/repos/Metaswitch/cpp-common/issues/340/events","html_url":"https://github.com/Metaswitch/cpp-common/pull/340","id":95903550,"number":340,"title":"[Reviewer: Andy] Allow IPv6 DNS servers","user":{"login":"rkd-msw","id":4363492,"avatar_url":"https://avatars.githubusercontent.com/u/4363492?v=3","gravatar_id":"","url":"https://api.github.com/users/rkd-msw","html_url":"https://github.com/rkd-msw","followers_url":"https://api.github.com/users/rkd-msw/followers","following_url":"https://api.github.com/users/rkd-msw/following{/other_user}","gists_url":"https://api.github.com/users/rkd-msw/gists{/gist_id}","starred_url":"https://api.github.com/users/rkd-msw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkd-msw/subscriptions","organizations_url":"https://api.github.com/users/rkd-msw/orgs","repos_url":"https://api.github.com/users/rkd-msw/repos","events_url":"https://api.github.com/users/rkd-msw/events{/privacy}","received_events_url":"https://api.github.com/users/rkd-msw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"rkd-msw","id":4363492,"avatar_url":"https://avatars.githubusercontent.com/u/4363492?v=3","gravatar_id":"","url":"https://api.github.com/users/rkd-msw","html_url":"https://github.com/rkd-msw","followers_url":"https://api.github.com/users/rkd-msw/followers","following_url":"https://api.github.com/users/rkd-msw/following{/other_user}","gists_url":"https://api.github.com/users/rkd-msw/gists{/gist_id}","starred_url":"https://api.github.com/users/rkd-msw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkd-msw/subscriptions","organizations_url":"https://api.github.com/users/rkd-msw/orgs","repos_url":"https://api.github.com/users/rkd-msw/repos","events_url":"https://api.github.com/users/rkd-msw/events{/privacy}","received_events_url":"https://api.github.com/users/rkd-msw/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-07-19T10:13:11Z","updated_at":"2015-07-27T13:49:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Metaswitch/cpp-common/pulls/340","html_url":"https://github.com/Metaswitch/cpp-common/pull/340","diff_url":"https://github.com/Metaswitch/cpp-common/pull/340.diff","patch_url":"https://github.com/Metaswitch/cpp-common/pull/340.patch"},"body":"This fixes https://github.com/Metaswitch/cpp-common/issues/246, mostly by porting code from Sprout's ENUM code.\r\n\r\nI've given the resolver three constructors - one with a single IP address as a string, one with multiple IP address as strings, and one taking IP46Addresses directly (so that the ENUM resolution code can plug into this)."},"comment":{"url":"https://api.github.com/repos/Metaswitch/cpp-common/issues/comments/125211913","html_url":"https://github.com/Metaswitch/cpp-common/pull/340#issuecomment-125211913","issue_url":"https://api.github.com/repos/Metaswitch/cpp-common/issues/340","id":125211913,"user":{"login":"rkd-msw","id":4363492,"avatar_url":"https://avatars.githubusercontent.com/u/4363492?v=3","gravatar_id":"","url":"https://api.github.com/users/rkd-msw","html_url":"https://github.com/rkd-msw","followers_url":"https://api.github.com/users/rkd-msw/followers","following_url":"https://api.github.com/users/rkd-msw/following{/other_user}","gists_url":"https://api.github.com/users/rkd-msw/gists{/gist_id}","starred_url":"https://api.github.com/users/rkd-msw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkd-msw/subscriptions","organizations_url":"https://api.github.com/users/rkd-msw/orgs","repos_url":"https://api.github.com/users/rkd-msw/repos","events_url":"https://api.github.com/users/rkd-msw/events{/privacy}","received_events_url":"https://api.github.com/users/rkd-msw/received_events","type":"User","site_admin":false},"created_at":"2015-07-27T13:49:30Z","updated_at":"2015-07-27T13:49:30Z","body":"OK, I've made your suggested markups, and also decided to have three constructors (IP46Address list, std::string list, std::string) rather than factory methods, just to reduce the amount of updating I have to do."}}