{"action":"created","issue":{"url":"https://api.github.com/repos/ash-edmodo/codepath-week-2/issues/1","labels_url":"https://api.github.com/repos/ash-edmodo/codepath-week-2/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/ash-edmodo/codepath-week-2/issues/1/comments","events_url":"https://api.github.com/repos/ash-edmodo/codepath-week-2/issues/1/events","html_url":"https://github.com/ash-edmodo/codepath-week-2/issues/1","id":57750566,"number":1,"title":"Required features on week-2 assignment.","user":{"login":"ash-edmodo","id":1771822,"avatar_url":"https://avatars.githubusercontent.com/u/1771822?v=3","gravatar_id":"","url":"https://api.github.com/users/ash-edmodo","html_url":"https://github.com/ash-edmodo","followers_url":"https://api.github.com/users/ash-edmodo/followers","following_url":"https://api.github.com/users/ash-edmodo/following{/other_user}","gists_url":"https://api.github.com/users/ash-edmodo/gists{/gist_id}","starred_url":"https://api.github.com/users/ash-edmodo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ash-edmodo/subscriptions","organizations_url":"https://api.github.com/users/ash-edmodo/orgs","repos_url":"https://api.github.com/users/ash-edmodo/repos","events_url":"https://api.github.com/users/ash-edmodo/events{/privacy}","received_events_url":"https://api.github.com/users/ash-edmodo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-02-15T22:59:35Z","updated_at":"2015-02-16T23:13:03Z","closed_at":null,"body":"Afraid I only had enough time to complete the required features this week.\r\n@codepathreview, @codepath please review.\r\n\r\nThanks,\r\nAsh Rawstron\r\nash@edmodo.com"},"comment":{"url":"https://api.github.com/repos/ash-edmodo/codepath-week-2/issues/comments/74587199","html_url":"https://github.com/ash-edmodo/codepath-week-2/issues/1#issuecomment-74587199","issue_url":"https://api.github.com/repos/ash-edmodo/codepath-week-2/issues/1","id":74587199,"user":{"login":"codepathreview","id":7917093,"avatar_url":"https://avatars.githubusercontent.com/u/7917093?v=3","gravatar_id":"","url":"https://api.github.com/users/codepathreview","html_url":"https://github.com/codepathreview","followers_url":"https://api.github.com/users/codepathreview/followers","following_url":"https://api.github.com/users/codepathreview/following{/other_user}","gists_url":"https://api.github.com/users/codepathreview/gists{/gist_id}","starred_url":"https://api.github.com/users/codepathreview/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codepathreview/subscriptions","organizations_url":"https://api.github.com/users/codepathreview/orgs","repos_url":"https://api.github.com/users/codepathreview/repos","events_url":"https://api.github.com/users/codepathreview/events{/privacy}","received_events_url":"https://api.github.com/users/codepathreview/received_events","type":"User","site_admin":false},"created_at":"2015-02-16T23:13:03Z","updated_at":"2015-02-16T23:13:03Z","body":":+1: nice work completing the required stories, would advise to attempt more optional stories for the next assignment. A few notes after checking out the code:\r\n\r\n* Good to see you used a filters object to represent the filters to apply to the query\r\n* Properly used spinners (with populated values) to allow users to select filters\r\n* Consider adding the ability to [share an image](http://guides.codepath.com/android/Sharing-Content-with-Intents). This is an important learning for this assignment even though it's optional.\r\n* Consider moving the search field into the ActionBar using a [custom ActionBar layout](http://guides.codepath.com/android/Extended-ActionBar-Guide#custom-actionbar-layout) or with a [SearchView](http://guides.codepath.com/android/Extended-ActionBar-Guide#adding-searchview-to-actionbar)\r\n* Consider adding error checks/ check for internet connectivity, etc\r\n* Consider adding [progress bars](http://guides.codepath.com/android/Handling-ProgressBars#actionbar-progress-bar) to your app whenever a network request goes out\r\n\r\nAlso, here's a more detailed [Project 2 Feedback Guide here](http://courses.codepath.com/snippets/intro_to_android/project_2_feedback) which covers the most common issues with this submitted project. Read through the [feedback guide point-by-point](http://courses.codepath.com/snippets/intro_to_android/project_2_feedback) to determine how you could improve your submission. \r\n\r\nLet us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation."}}