{"action":"opened","number":4754,"pull_request":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4754","id":50081996,"html_url":"https://github.com/silverstripe/silverstripe-framework/pull/4754","diff_url":"https://github.com/silverstripe/silverstripe-framework/pull/4754.diff","patch_url":"https://github.com/silverstripe/silverstripe-framework/pull/4754.patch","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4754","number":4754,"state":"open","locked":false,"title":"BUG prevent UploadField edit form generation for Folders","user":{"login":"tractorcow","id":936064,"avatar_url":"https://avatars.githubusercontent.com/u/936064?v=3","gravatar_id":"","url":"https://api.github.com/users/tractorcow","html_url":"https://github.com/tractorcow","followers_url":"https://api.github.com/users/tractorcow/followers","following_url":"https://api.github.com/users/tractorcow/following{/other_user}","gists_url":"https://api.github.com/users/tractorcow/gists{/gist_id}","starred_url":"https://api.github.com/users/tractorcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tractorcow/subscriptions","organizations_url":"https://api.github.com/users/tractorcow/orgs","repos_url":"https://api.github.com/users/tractorcow/repos","events_url":"https://api.github.com/users/tractorcow/events{/privacy}","received_events_url":"https://api.github.com/users/tractorcow/received_events","type":"User","site_admin":false},"body":"This is actually a tiny minor issue, and only really manifests itself in edge-case testing.\r\n\r\nIf you attempt to resolve the edit form for a Folder DataObject it should fail. However, in some situations the edit form will be generated, but fail with a validation error on submission, resulting in an obscure `Exception: Object->__call(): the method 'redirectback' does not exist on 'UploadField_ItemHandler'` error.\r\n\r\nThis moves the error up to before the form is generated.","created_at":"2015-11-09T03:41:46Z","updated_at":"2015-11-09T03:41:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4754/commits","review_comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4754/comments","review_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4754/comments","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/414ea3de9e87812c5ac96cc15062307c608e0963","head":{"label":"tractorcow:pulls/3.2/upload-fixes","ref":"pulls/3.2/upload-fixes","sha":"414ea3de9e87812c5ac96cc15062307c608e0963","user":{"login":"tractorcow","id":936064,"avatar_url":"https://avatars.githubusercontent.com/u/936064?v=3","gravatar_id":"","url":"https://api.github.com/users/tractorcow","html_url":"https://github.com/tractorcow","followers_url":"https://api.github.com/users/tractorcow/followers","following_url":"https://api.github.com/users/tractorcow/following{/other_user}","gists_url":"https://api.github.com/users/tractorcow/gists{/gist_id}","starred_url":"https://api.github.com/users/tractorcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tractorcow/subscriptions","organizations_url":"https://api.github.com/users/tractorcow/orgs","repos_url":"https://api.github.com/users/tractorcow/repos","events_url":"https://api.github.com/users/tractorcow/events{/privacy}","received_events_url":"https://api.github.com/users/tractorcow/received_events","type":"User","site_admin":false},"repo":{"id":5337017,"name":"silverstripe-framework","full_name":"tractorcow/silverstripe-framework","owner":{"login":"tractorcow","id":936064,"avatar_url":"https://avatars.githubusercontent.com/u/936064?v=3","gravatar_id":"","url":"https://api.github.com/users/tractorcow","html_url":"https://github.com/tractorcow","followers_url":"https://api.github.com/users/tractorcow/followers","following_url":"https://api.github.com/users/tractorcow/following{/other_user}","gists_url":"https://api.github.com/users/tractorcow/gists{/gist_id}","starred_url":"https://api.github.com/users/tractorcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tractorcow/subscriptions","organizations_url":"https://api.github.com/users/tractorcow/orgs","repos_url":"https://api.github.com/users/tractorcow/repos","events_url":"https://api.github.com/users/tractorcow/events{/privacy}","received_events_url":"https://api.github.com/users/tractorcow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tractorcow/silverstripe-framework","description":"SilverStripe's Sapphire Framework","fork":true,"url":"https://api.github.com/repos/tractorcow/silverstripe-framework","forks_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/forks","keys_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/teams","hooks_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/hooks","issue_events_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/issues/events{/number}","events_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/events","assignees_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/assignees{/user}","branches_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/branches{/branch}","tags_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/tags","blobs_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/languages","stargazers_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/stargazers","contributors_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/contributors","subscribers_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/subscribers","subscription_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/subscription","commits_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/contents/{+path}","compare_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/merges","archive_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/downloads","issues_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/issues{/number}","pulls_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/labels{/name}","releases_url":"https://api.github.com/repos/tractorcow/silverstripe-framework/releases{/id}","created_at":"2012-08-08T04:07:21Z","updated_at":"2015-06-01T22:15:10Z","pushed_at":"2015-11-09T03:39:45Z","git_url":"git://github.com/tractorcow/silverstripe-framework.git","ssh_url":"git@github.com:tractorcow/silverstripe-framework.git","clone_url":"https://github.com/tractorcow/silverstripe-framework.git","svn_url":"https://github.com/tractorcow/silverstripe-framework","homepage":"http://silverstripe.org/","size":57665,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":11,"forks":1,"open_issues":11,"watchers":0,"default_branch":"3.2"}},"base":{"label":"silverstripe:3.2","ref":"3.2","sha":"6d85d618b6deef6bbff0e9c3a002e0a669c25c64","user":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars.githubusercontent.com/u/379348?v=3","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"repo":{"id":1318892,"name":"silverstripe-framework","full_name":"silverstripe/silverstripe-framework","owner":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars.githubusercontent.com/u/379348?v=3","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/silverstripe/silverstripe-framework","description":"SilverStripe Framework, the MVC framework that powers SilverStripe CMS","fork":false,"url":"https://api.github.com/repos/silverstripe/silverstripe-framework","forks_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/forks","keys_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/teams","hooks_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/hooks","issue_events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/events{/number}","events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/events","assignees_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/assignees{/user}","branches_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/branches{/branch}","tags_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/tags","blobs_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/languages","stargazers_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/stargazers","contributors_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/contributors","subscribers_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/subscribers","subscription_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/subscription","commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/contents/{+path}","compare_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/merges","archive_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/downloads","issues_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues{/number}","pulls_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/labels{/name}","releases_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/releases{/id}","created_at":"2011-02-02T02:04:13Z","updated_at":"2015-11-05T14:17:02Z","pushed_at":"2015-11-08T21:35:24Z","git_url":"git://github.com/silverstripe/silverstripe-framework.git","ssh_url":"git@github.com:silverstripe/silverstripe-framework.git","clone_url":"https://github.com/silverstripe/silverstripe-framework.git","svn_url":"https://github.com/silverstripe/silverstripe-framework","homepage":"http://silverstripe.org/","size":110768,"stargazers_count":468,"watchers_count":468,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":531,"mirror_url":null,"open_issues_count":642,"forks":531,"open_issues":642,"watchers":468,"default_branch":"3"}},"_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4754"},"html":{"href":"https://github.com/silverstripe/silverstripe-framework/pull/4754"},"issue":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4754"},"comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4754/comments"},"review_comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4754/comments"},"review_comment":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4754/commits"},"statuses":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/414ea3de9e87812c5ac96cc15062307c608e0963"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":0,"changed_files":1}}