{"action":"closed","number":19,"pull_request":{"url":"https://api.github.com/repos/sparkphp/Spark/pulls/19","id":38028488,"html_url":"https://github.com/sparkphp/Spark/pull/19","diff_url":"https://github.com/sparkphp/Spark/pull/19.diff","patch_url":"https://github.com/sparkphp/Spark/pull/19.patch","issue_url":"https://api.github.com/repos/sparkphp/Spark/issues/19","number":19,"state":"closed","locked":false,"title":"Change error() to use messages instead of output","user":{"login":"bvisness","id":4707402,"avatar_url":"https://avatars.githubusercontent.com/u/4707402?v=3","gravatar_id":"","url":"https://api.github.com/users/bvisness","html_url":"https://github.com/bvisness","followers_url":"https://api.github.com/users/bvisness/followers","following_url":"https://api.github.com/users/bvisness/following{/other_user}","gists_url":"https://api.github.com/users/bvisness/gists{/gist_id}","starred_url":"https://api.github.com/users/bvisness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvisness/subscriptions","organizations_url":"https://api.github.com/users/bvisness/orgs","repos_url":"https://api.github.com/users/bvisness/repos","events_url":"https://api.github.com/users/bvisness/events{/privacy}","received_events_url":"https://api.github.com/users/bvisness/received_events","type":"User","site_admin":false},"body":"In practice, I think it makes more sense for the error() method in AbstractResponder to have its \"error\" information based on the payload's messages rather than its output. I'm curious if you guys agree.","created_at":"2015-06-18T16:53:59Z","updated_at":"2015-08-11T16:52:46Z","closed_at":"2015-08-11T16:52:46Z","merged_at":null,"merge_commit_sha":"97313b3b65fcd2362c22a3df5d2aef2819ca7d97","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sparkphp/Spark/pulls/19/commits","review_comments_url":"https://api.github.com/repos/sparkphp/Spark/pulls/19/comments","review_comment_url":"https://api.github.com/repos/sparkphp/Spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sparkphp/Spark/issues/19/comments","statuses_url":"https://api.github.com/repos/sparkphp/Spark/statuses/7cd69161f8f81403afcc25c21ef6c2822fee11f1","head":{"label":"sparkphp:error-output","ref":"error-output","sha":"7cd69161f8f81403afcc25c21ef6c2822fee11f1","user":{"login":"sparkphp","id":12573848,"avatar_url":"https://avatars.githubusercontent.com/u/12573848?v=3","gravatar_id":"","url":"https://api.github.com/users/sparkphp","html_url":"https://github.com/sparkphp","followers_url":"https://api.github.com/users/sparkphp/followers","following_url":"https://api.github.com/users/sparkphp/following{/other_user}","gists_url":"https://api.github.com/users/sparkphp/gists{/gist_id}","starred_url":"https://api.github.com/users/sparkphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sparkphp/subscriptions","organizations_url":"https://api.github.com/users/sparkphp/orgs","repos_url":"https://api.github.com/users/sparkphp/repos","events_url":"https://api.github.com/users/sparkphp/events{/privacy}","received_events_url":"https://api.github.com/users/sparkphp/received_events","type":"Organization","site_admin":false},"repo":{"id":36032948,"name":"Spark","full_name":"sparkphp/Spark","owner":{"login":"sparkphp","id":12573848,"avatar_url":"https://avatars.githubusercontent.com/u/12573848?v=3","gravatar_id":"","url":"https://api.github.com/users/sparkphp","html_url":"https://github.com/sparkphp","followers_url":"https://api.github.com/users/sparkphp/followers","following_url":"https://api.github.com/users/sparkphp/following{/other_user}","gists_url":"https://api.github.com/users/sparkphp/gists{/gist_id}","starred_url":"https://api.github.com/users/sparkphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sparkphp/subscriptions","organizations_url":"https://api.github.com/users/sparkphp/orgs","repos_url":"https://api.github.com/users/sparkphp/repos","events_url":"https://api.github.com/users/sparkphp/events{/privacy}","received_events_url":"https://api.github.com/users/sparkphp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sparkphp/Spark","description":"A tiny, yet powerful, PHP micro-framework.","fork":false,"url":"https://api.github.com/repos/sparkphp/Spark","forks_url":"https://api.github.com/repos/sparkphp/Spark/forks","keys_url":"https://api.github.com/repos/sparkphp/Spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sparkphp/Spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sparkphp/Spark/teams","hooks_url":"https://api.github.com/repos/sparkphp/Spark/hooks","issue_events_url":"https://api.github.com/repos/sparkphp/Spark/issues/events{/number}","events_url":"https://api.github.com/repos/sparkphp/Spark/events","assignees_url":"https://api.github.com/repos/sparkphp/Spark/assignees{/user}","branches_url":"https://api.github.com/repos/sparkphp/Spark/branches{/branch}","tags_url":"https://api.github.com/repos/sparkphp/Spark/tags","blobs_url":"https://api.github.com/repos/sparkphp/Spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sparkphp/Spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sparkphp/Spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/sparkphp/Spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sparkphp/Spark/statuses/{sha}","languages_url":"https://api.github.com/repos/sparkphp/Spark/languages","stargazers_url":"https://api.github.com/repos/sparkphp/Spark/stargazers","contributors_url":"https://api.github.com/repos/sparkphp/Spark/contributors","subscribers_url":"https://api.github.com/repos/sparkphp/Spark/subscribers","subscription_url":"https://api.github.com/repos/sparkphp/Spark/subscription","commits_url":"https://api.github.com/repos/sparkphp/Spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/sparkphp/Spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/sparkphp/Spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/sparkphp/Spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/sparkphp/Spark/contents/{+path}","compare_url":"https://api.github.com/repos/sparkphp/Spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sparkphp/Spark/merges","archive_url":"https://api.github.com/repos/sparkphp/Spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sparkphp/Spark/downloads","issues_url":"https://api.github.com/repos/sparkphp/Spark/issues{/number}","pulls_url":"https://api.github.com/repos/sparkphp/Spark/pulls{/number}","milestones_url":"https://api.github.com/repos/sparkphp/Spark/milestones{/number}","notifications_url":"https://api.github.com/repos/sparkphp/Spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sparkphp/Spark/labels{/name}","releases_url":"https://api.github.com/repos/sparkphp/Spark/releases{/id}","created_at":"2015-05-21T19:24:54Z","updated_at":"2015-08-05T18:20:37Z","pushed_at":"2015-08-11T12:26:38Z","git_url":"git://github.com/sparkphp/Spark.git","ssh_url":"git@github.com:sparkphp/Spark.git","clone_url":"https://github.com/sparkphp/Spark.git","svn_url":"https://github.com/sparkphp/Spark","homepage":"http://sparkphp.github.io","size":516,"stargazers_count":24,"watchers_count":24,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":7,"forks":3,"open_issues":7,"watchers":24,"default_branch":"master"}},"base":{"label":"sparkphp:master","ref":"master","sha":"b17e562ea22ac1a0f93720b2d13edfadc1cee40a","user":{"login":"sparkphp","id":12573848,"avatar_url":"https://avatars.githubusercontent.com/u/12573848?v=3","gravatar_id":"","url":"https://api.github.com/users/sparkphp","html_url":"https://github.com/sparkphp","followers_url":"https://api.github.com/users/sparkphp/followers","following_url":"https://api.github.com/users/sparkphp/following{/other_user}","gists_url":"https://api.github.com/users/sparkphp/gists{/gist_id}","starred_url":"https://api.github.com/users/sparkphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sparkphp/subscriptions","organizations_url":"https://api.github.com/users/sparkphp/orgs","repos_url":"https://api.github.com/users/sparkphp/repos","events_url":"https://api.github.com/users/sparkphp/events{/privacy}","received_events_url":"https://api.github.com/users/sparkphp/received_events","type":"Organization","site_admin":false},"repo":{"id":36032948,"name":"Spark","full_name":"sparkphp/Spark","owner":{"login":"sparkphp","id":12573848,"avatar_url":"https://avatars.githubusercontent.com/u/12573848?v=3","gravatar_id":"","url":"https://api.github.com/users/sparkphp","html_url":"https://github.com/sparkphp","followers_url":"https://api.github.com/users/sparkphp/followers","following_url":"https://api.github.com/users/sparkphp/following{/other_user}","gists_url":"https://api.github.com/users/sparkphp/gists{/gist_id}","starred_url":"https://api.github.com/users/sparkphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sparkphp/subscriptions","organizations_url":"https://api.github.com/users/sparkphp/orgs","repos_url":"https://api.github.com/users/sparkphp/repos","events_url":"https://api.github.com/users/sparkphp/events{/privacy}","received_events_url":"https://api.github.com/users/sparkphp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sparkphp/Spark","description":"A tiny, yet powerful, PHP micro-framework.","fork":false,"url":"https://api.github.com/repos/sparkphp/Spark","forks_url":"https://api.github.com/repos/sparkphp/Spark/forks","keys_url":"https://api.github.com/repos/sparkphp/Spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sparkphp/Spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sparkphp/Spark/teams","hooks_url":"https://api.github.com/repos/sparkphp/Spark/hooks","issue_events_url":"https://api.github.com/repos/sparkphp/Spark/issues/events{/number}","events_url":"https://api.github.com/repos/sparkphp/Spark/events","assignees_url":"https://api.github.com/repos/sparkphp/Spark/assignees{/user}","branches_url":"https://api.github.com/repos/sparkphp/Spark/branches{/branch}","tags_url":"https://api.github.com/repos/sparkphp/Spark/tags","blobs_url":"https://api.github.com/repos/sparkphp/Spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sparkphp/Spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sparkphp/Spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/sparkphp/Spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sparkphp/Spark/statuses/{sha}","languages_url":"https://api.github.com/repos/sparkphp/Spark/languages","stargazers_url":"https://api.github.com/repos/sparkphp/Spark/stargazers","contributors_url":"https://api.github.com/repos/sparkphp/Spark/contributors","subscribers_url":"https://api.github.com/repos/sparkphp/Spark/subscribers","subscription_url":"https://api.github.com/repos/sparkphp/Spark/subscription","commits_url":"https://api.github.com/repos/sparkphp/Spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/sparkphp/Spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/sparkphp/Spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/sparkphp/Spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/sparkphp/Spark/contents/{+path}","compare_url":"https://api.github.com/repos/sparkphp/Spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sparkphp/Spark/merges","archive_url":"https://api.github.com/repos/sparkphp/Spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sparkphp/Spark/downloads","issues_url":"https://api.github.com/repos/sparkphp/Spark/issues{/number}","pulls_url":"https://api.github.com/repos/sparkphp/Spark/pulls{/number}","milestones_url":"https://api.github.com/repos/sparkphp/Spark/milestones{/number}","notifications_url":"https://api.github.com/repos/sparkphp/Spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sparkphp/Spark/labels{/name}","releases_url":"https://api.github.com/repos/sparkphp/Spark/releases{/id}","created_at":"2015-05-21T19:24:54Z","updated_at":"2015-08-05T18:20:37Z","pushed_at":"2015-08-11T12:26:38Z","git_url":"git://github.com/sparkphp/Spark.git","ssh_url":"git@github.com:sparkphp/Spark.git","clone_url":"https://github.com/sparkphp/Spark.git","svn_url":"https://github.com/sparkphp/Spark","homepage":"http://sparkphp.github.io","size":516,"stargazers_count":24,"watchers_count":24,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":7,"forks":3,"open_issues":7,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sparkphp/Spark/pulls/19"},"html":{"href":"https://github.com/sparkphp/Spark/pull/19"},"issue":{"href":"https://api.github.com/repos/sparkphp/Spark/issues/19"},"comments":{"href":"https://api.github.com/repos/sparkphp/Spark/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/sparkphp/Spark/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/sparkphp/Spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sparkphp/Spark/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/sparkphp/Spark/statuses/7cd69161f8f81403afcc25c21ef6c2822fee11f1"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":6,"review_comments":3,"commits":1,"additions":1,"deletions":1,"changed_files":1}}