{"action":"created","issue":{"url":"https://api.github.com/repos/gliderlabs/registrator/issues/203","labels_url":"https://api.github.com/repos/gliderlabs/registrator/issues/203/labels{/name}","comments_url":"https://api.github.com/repos/gliderlabs/registrator/issues/203/comments","events_url":"https://api.github.com/repos/gliderlabs/registrator/issues/203/events","html_url":"https://github.com/gliderlabs/registrator/pull/203","id":94419532,"number":203,"title":"Adds TLS support - For SmartDataCenter","user":{"login":"jgrowl","id":90719,"avatar_url":"https://avatars.githubusercontent.com/u/90719?v=3","gravatar_id":"","url":"https://api.github.com/users/jgrowl","html_url":"https://github.com/jgrowl","followers_url":"https://api.github.com/users/jgrowl/followers","following_url":"https://api.github.com/users/jgrowl/following{/other_user}","gists_url":"https://api.github.com/users/jgrowl/gists{/gist_id}","starred_url":"https://api.github.com/users/jgrowl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgrowl/subscriptions","organizations_url":"https://api.github.com/users/jgrowl/orgs","repos_url":"https://api.github.com/users/jgrowl/repos","events_url":"https://api.github.com/users/jgrowl/events{/privacy}","received_events_url":"https://api.github.com/users/jgrowl/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/gliderlabs/registrator/labels/rebase","name":"rebase","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/gliderlabs/registrator/milestones/1","html_url":"https://github.com/gliderlabs/registrator/milestones/v7","labels_url":"https://api.github.com/repos/gliderlabs/registrator/milestones/1/labels","id":1260869,"number":1,"title":"v7","description":"","creator":{"login":"TheNathanBlack","id":1856320,"avatar_url":"https://avatars.githubusercontent.com/u/1856320?v=3","gravatar_id":"","url":"https://api.github.com/users/TheNathanBlack","html_url":"https://github.com/TheNathanBlack","followers_url":"https://api.github.com/users/TheNathanBlack/followers","following_url":"https://api.github.com/users/TheNathanBlack/following{/other_user}","gists_url":"https://api.github.com/users/TheNathanBlack/gists{/gist_id}","starred_url":"https://api.github.com/users/TheNathanBlack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheNathanBlack/subscriptions","organizations_url":"https://api.github.com/users/TheNathanBlack/orgs","repos_url":"https://api.github.com/users/TheNathanBlack/repos","events_url":"https://api.github.com/users/TheNathanBlack/events{/privacy}","received_events_url":"https://api.github.com/users/TheNathanBlack/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":3,"state":"open","created_at":"2015-08-18T15:46:46Z","updated_at":"2015-09-08T18:35:36Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2015-07-11T00:40:51Z","updated_at":"2015-12-01T01:49:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gliderlabs/registrator/pulls/203","html_url":"https://github.com/gliderlabs/registrator/pull/203","diff_url":"https://github.com/gliderlabs/registrator/pull/203.diff","patch_url":"https://github.com/gliderlabs/registrator/pull/203.patch"},"body":"I made a branch before noticing #162 #163. I see why you would want to discourage people from running registrator on a different host than the docker instance under normal circumstances. That being said, I would still really like the option to do it.\r\n\r\nSpecifically the reason why is that I think it would be awesome to be able to use registrator with Joyent's SmartDataCenter (https://github.com/joyent/sdc). Basically what it does is create a virtual docker host. You can interact with it using a normal docker client, but on the back end it is really a node server that provisions containers on potentially different machines in the cloud. SDC makes it really easy to create private networks and every container has a unique IP address. The one thing that it needs is a way to do service discovery. Registrator seems like it would work really well.\r\n\r\nThe first step for this to work is getting TLS support added.\r\n\r\nThe other big issue is that currently SDC does not implement docker events (https://github.com/joyent/sdc-docker/blob/bf47a3004013fdce342618f044567e8d595ba035/lib/endpoints/events.js)\r\n\r\nIf the Joyent guys aren't currently working on implementing it, then I will. Then registrator would theoretically just work with SDC by enabling TLS support.\r\n\r\nI may implement a stop gap solution in registrator to get around not having events until that work can get done, but that is another PR. \r\n\r\nWould you reconsider adding TLS support?  :)"},"comment":{"url":"https://api.github.com/repos/gliderlabs/registrator/issues/comments/160821116","html_url":"https://github.com/gliderlabs/registrator/pull/203#issuecomment-160821116","issue_url":"https://api.github.com/repos/gliderlabs/registrator/issues/203","id":160821116,"user":{"login":"mgood","id":29016,"avatar_url":"https://avatars.githubusercontent.com/u/29016?v=3","gravatar_id":"","url":"https://api.github.com/users/mgood","html_url":"https://github.com/mgood","followers_url":"https://api.github.com/users/mgood/followers","following_url":"https://api.github.com/users/mgood/following{/other_user}","gists_url":"https://api.github.com/users/mgood/gists{/gist_id}","starred_url":"https://api.github.com/users/mgood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgood/subscriptions","organizations_url":"https://api.github.com/users/mgood/orgs","repos_url":"https://api.github.com/users/mgood/repos","events_url":"https://api.github.com/users/mgood/events{/privacy}","received_events_url":"https://api.github.com/users/mgood/received_events","type":"User","site_admin":false},"created_at":"2015-12-01T01:49:30Z","updated_at":"2015-12-01T01:49:30Z","body":"Thanks, sorry for the delay, but can you rebase these changes again to clean up the history? It looks like when you merged your branches you ended up with duplicate commits in the history, probably due to merging with a different rebased branch. "}}