{"action":"created","comment":{"url":"https://api.github.com/repos/paralleljs/pjs/pulls/comments/43241584","id":43241584,"diff_hunk":"@@ -0,0 +1,31 @@\n+/**\n+ * @fileoverview Describes a single WorkUnit.\n+ */\n+\n+\n+// A work unit is a function that works on the worker thread, and posts a light\n+// weight callback to be run on the parent thread.\n+WorkUnit = function(fn, on_done, worker) {\n+  this.work_fn_ = fn;","path":"src/work_unit.js","position":9,"original_position":9,"commit_id":"06345474bc70cd9873367c17c55c10790907f4c2","original_commit_id":"06345474bc70cd9873367c17c55c10790907f4c2","user":{"login":"ashubham","id":6115911,"avatar_url":"https://avatars.githubusercontent.com/u/6115911?v=3","gravatar_id":"","url":"https://api.github.com/users/ashubham","html_url":"https://github.com/ashubham","followers_url":"https://api.github.com/users/ashubham/followers","following_url":"https://api.github.com/users/ashubham/following{/other_user}","gists_url":"https://api.github.com/users/ashubham/gists{/gist_id}","starred_url":"https://api.github.com/users/ashubham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashubham/subscriptions","organizations_url":"https://api.github.com/users/ashubham/orgs","repos_url":"https://api.github.com/users/ashubham/repos","events_url":"https://api.github.com/users/ashubham/events{/privacy}","received_events_url":"https://api.github.com/users/ashubham/received_events","type":"User","site_admin":false},"body":"I assume, `work_fn_` is intended to be a private variable. The convention generally is `_workFn` (camel case variablename with a leading _ to denote private) ","created_at":"2015-10-28T11:05:09Z","updated_at":"2015-10-28T11:05:09Z","html_url":"https://github.com/paralleljs/pjs/pull/2#discussion_r43241584","pull_request_url":"https://api.github.com/repos/paralleljs/pjs/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/paralleljs/pjs/pulls/comments/43241584"},"html":{"href":"https://github.com/paralleljs/pjs/pull/2#discussion_r43241584"},"pull_request":{"href":"https://api.github.com/repos/paralleljs/pjs/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/paralleljs/pjs/pulls/2","id":48962934,"html_url":"https://github.com/paralleljs/pjs/pull/2","diff_url":"https://github.com/paralleljs/pjs/pull/2.diff","patch_url":"https://github.com/paralleljs/pjs/pull/2.patch","issue_url":"https://api.github.com/repos/paralleljs/pjs/issues/2","number":2,"state":"open","locked":false,"title":"Adding basic worker pool implementation","user":{"login":"ar1nd4m","id":510116,"avatar_url":"https://avatars.githubusercontent.com/u/510116?v=3","gravatar_id":"","url":"https://api.github.com/users/ar1nd4m","html_url":"https://github.com/ar1nd4m","followers_url":"https://api.github.com/users/ar1nd4m/followers","following_url":"https://api.github.com/users/ar1nd4m/following{/other_user}","gists_url":"https://api.github.com/users/ar1nd4m/gists{/gist_id}","starred_url":"https://api.github.com/users/ar1nd4m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ar1nd4m/subscriptions","organizations_url":"https://api.github.com/users/ar1nd4m/orgs","repos_url":"https://api.github.com/users/ar1nd4m/repos","events_url":"https://api.github.com/users/ar1nd4m/events{/privacy}","received_events_url":"https://api.github.com/users/ar1nd4m/received_events","type":"User","site_admin":false},"body":"PTAL. My js style might be completely off, so please bear with me and do a comprehensive review.","created_at":"2015-10-28T04:09:53Z","updated_at":"2015-10-28T11:05:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ddefa412aa02c5b95b811b7831a237f91ea6e6ec","assignee":{"login":"ashubham","id":6115911,"avatar_url":"https://avatars.githubusercontent.com/u/6115911?v=3","gravatar_id":"","url":"https://api.github.com/users/ashubham","html_url":"https://github.com/ashubham","followers_url":"https://api.github.com/users/ashubham/followers","following_url":"https://api.github.com/users/ashubham/following{/other_user}","gists_url":"https://api.github.com/users/ashubham/gists{/gist_id}","starred_url":"https://api.github.com/users/ashubham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashubham/subscriptions","organizations_url":"https://api.github.com/users/ashubham/orgs","repos_url":"https://api.github.com/users/ashubham/repos","events_url":"https://api.github.com/users/ashubham/events{/privacy}","received_events_url":"https://api.github.com/users/ashubham/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/paralleljs/pjs/pulls/2/commits","review_comments_url":"https://api.github.com/repos/paralleljs/pjs/pulls/2/comments","review_comment_url":"https://api.github.com/repos/paralleljs/pjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paralleljs/pjs/issues/2/comments","statuses_url":"https://api.github.com/repos/paralleljs/pjs/statuses/06345474bc70cd9873367c17c55c10790907f4c2","head":{"label":"ar1nd4m:master","ref":"master","sha":"06345474bc70cd9873367c17c55c10790907f4c2","user":{"login":"ar1nd4m","id":510116,"avatar_url":"https://avatars.githubusercontent.com/u/510116?v=3","gravatar_id":"","url":"https://api.github.com/users/ar1nd4m","html_url":"https://github.com/ar1nd4m","followers_url":"https://api.github.com/users/ar1nd4m/followers","following_url":"https://api.github.com/users/ar1nd4m/following{/other_user}","gists_url":"https://api.github.com/users/ar1nd4m/gists{/gist_id}","starred_url":"https://api.github.com/users/ar1nd4m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ar1nd4m/subscriptions","organizations_url":"https://api.github.com/users/ar1nd4m/orgs","repos_url":"https://api.github.com/users/ar1nd4m/repos","events_url":"https://api.github.com/users/ar1nd4m/events{/privacy}","received_events_url":"https://api.github.com/users/ar1nd4m/received_events","type":"User","site_admin":false},"repo":{"id":45088027,"name":"pjs","full_name":"ar1nd4m/pjs","owner":{"login":"ar1nd4m","id":510116,"avatar_url":"https://avatars.githubusercontent.com/u/510116?v=3","gravatar_id":"","url":"https://api.github.com/users/ar1nd4m","html_url":"https://github.com/ar1nd4m","followers_url":"https://api.github.com/users/ar1nd4m/followers","following_url":"https://api.github.com/users/ar1nd4m/following{/other_user}","gists_url":"https://api.github.com/users/ar1nd4m/gists{/gist_id}","starred_url":"https://api.github.com/users/ar1nd4m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ar1nd4m/subscriptions","organizations_url":"https://api.github.com/users/ar1nd4m/orgs","repos_url":"https://api.github.com/users/ar1nd4m/repos","events_url":"https://api.github.com/users/ar1nd4m/events{/privacy}","received_events_url":"https://api.github.com/users/ar1nd4m/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ar1nd4m/pjs","description":"Making web faster.","fork":true,"url":"https://api.github.com/repos/ar1nd4m/pjs","forks_url":"https://api.github.com/repos/ar1nd4m/pjs/forks","keys_url":"https://api.github.com/repos/ar1nd4m/pjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ar1nd4m/pjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ar1nd4m/pjs/teams","hooks_url":"https://api.github.com/repos/ar1nd4m/pjs/hooks","issue_events_url":"https://api.github.com/repos/ar1nd4m/pjs/issues/events{/number}","events_url":"https://api.github.com/repos/ar1nd4m/pjs/events","assignees_url":"https://api.github.com/repos/ar1nd4m/pjs/assignees{/user}","branches_url":"https://api.github.com/repos/ar1nd4m/pjs/branches{/branch}","tags_url":"https://api.github.com/repos/ar1nd4m/pjs/tags","blobs_url":"https://api.github.com/repos/ar1nd4m/pjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ar1nd4m/pjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ar1nd4m/pjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ar1nd4m/pjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ar1nd4m/pjs/statuses/{sha}","languages_url":"https://api.github.com/repos/ar1nd4m/pjs/languages","stargazers_url":"https://api.github.com/repos/ar1nd4m/pjs/stargazers","contributors_url":"https://api.github.com/repos/ar1nd4m/pjs/contributors","subscribers_url":"https://api.github.com/repos/ar1nd4m/pjs/subscribers","subscription_url":"https://api.github.com/repos/ar1nd4m/pjs/subscription","commits_url":"https://api.github.com/repos/ar1nd4m/pjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ar1nd4m/pjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ar1nd4m/pjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ar1nd4m/pjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ar1nd4m/pjs/contents/{+path}","compare_url":"https://api.github.com/repos/ar1nd4m/pjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ar1nd4m/pjs/merges","archive_url":"https://api.github.com/repos/ar1nd4m/pjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ar1nd4m/pjs/downloads","issues_url":"https://api.github.com/repos/ar1nd4m/pjs/issues{/number}","pulls_url":"https://api.github.com/repos/ar1nd4m/pjs/pulls{/number}","milestones_url":"https://api.github.com/repos/ar1nd4m/pjs/milestones{/number}","notifications_url":"https://api.github.com/repos/ar1nd4m/pjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ar1nd4m/pjs/labels{/name}","releases_url":"https://api.github.com/repos/ar1nd4m/pjs/releases{/id}","created_at":"2015-10-28T04:05:40Z","updated_at":"2015-10-28T04:05:41Z","pushed_at":"2015-10-28T04:08:15Z","git_url":"git://github.com/ar1nd4m/pjs.git","ssh_url":"git@github.com:ar1nd4m/pjs.git","clone_url":"https://github.com/ar1nd4m/pjs.git","svn_url":"https://github.com/ar1nd4m/pjs","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"paralleljs:master","ref":"master","sha":"cac23fa1705626acc911816fcdbc789246724467","user":{"login":"paralleljs","id":15244043,"avatar_url":"https://avatars.githubusercontent.com/u/15244043?v=3","gravatar_id":"","url":"https://api.github.com/users/paralleljs","html_url":"https://github.com/paralleljs","followers_url":"https://api.github.com/users/paralleljs/followers","following_url":"https://api.github.com/users/paralleljs/following{/other_user}","gists_url":"https://api.github.com/users/paralleljs/gists{/gist_id}","starred_url":"https://api.github.com/users/paralleljs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paralleljs/subscriptions","organizations_url":"https://api.github.com/users/paralleljs/orgs","repos_url":"https://api.github.com/users/paralleljs/repos","events_url":"https://api.github.com/users/paralleljs/events{/privacy}","received_events_url":"https://api.github.com/users/paralleljs/received_events","type":"Organization","site_admin":false},"repo":{"id":44728570,"name":"pjs","full_name":"paralleljs/pjs","owner":{"login":"paralleljs","id":15244043,"avatar_url":"https://avatars.githubusercontent.com/u/15244043?v=3","gravatar_id":"","url":"https://api.github.com/users/paralleljs","html_url":"https://github.com/paralleljs","followers_url":"https://api.github.com/users/paralleljs/followers","following_url":"https://api.github.com/users/paralleljs/following{/other_user}","gists_url":"https://api.github.com/users/paralleljs/gists{/gist_id}","starred_url":"https://api.github.com/users/paralleljs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paralleljs/subscriptions","organizations_url":"https://api.github.com/users/paralleljs/orgs","repos_url":"https://api.github.com/users/paralleljs/repos","events_url":"https://api.github.com/users/paralleljs/events{/privacy}","received_events_url":"https://api.github.com/users/paralleljs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paralleljs/pjs","description":"Making web faster.","fork":false,"url":"https://api.github.com/repos/paralleljs/pjs","forks_url":"https://api.github.com/repos/paralleljs/pjs/forks","keys_url":"https://api.github.com/repos/paralleljs/pjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paralleljs/pjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paralleljs/pjs/teams","hooks_url":"https://api.github.com/repos/paralleljs/pjs/hooks","issue_events_url":"https://api.github.com/repos/paralleljs/pjs/issues/events{/number}","events_url":"https://api.github.com/repos/paralleljs/pjs/events","assignees_url":"https://api.github.com/repos/paralleljs/pjs/assignees{/user}","branches_url":"https://api.github.com/repos/paralleljs/pjs/branches{/branch}","tags_url":"https://api.github.com/repos/paralleljs/pjs/tags","blobs_url":"https://api.github.com/repos/paralleljs/pjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paralleljs/pjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paralleljs/pjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/paralleljs/pjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paralleljs/pjs/statuses/{sha}","languages_url":"https://api.github.com/repos/paralleljs/pjs/languages","stargazers_url":"https://api.github.com/repos/paralleljs/pjs/stargazers","contributors_url":"https://api.github.com/repos/paralleljs/pjs/contributors","subscribers_url":"https://api.github.com/repos/paralleljs/pjs/subscribers","subscription_url":"https://api.github.com/repos/paralleljs/pjs/subscription","commits_url":"https://api.github.com/repos/paralleljs/pjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/paralleljs/pjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/paralleljs/pjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/paralleljs/pjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/paralleljs/pjs/contents/{+path}","compare_url":"https://api.github.com/repos/paralleljs/pjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paralleljs/pjs/merges","archive_url":"https://api.github.com/repos/paralleljs/pjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paralleljs/pjs/downloads","issues_url":"https://api.github.com/repos/paralleljs/pjs/issues{/number}","pulls_url":"https://api.github.com/repos/paralleljs/pjs/pulls{/number}","milestones_url":"https://api.github.com/repos/paralleljs/pjs/milestones{/number}","notifications_url":"https://api.github.com/repos/paralleljs/pjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paralleljs/pjs/labels{/name}","releases_url":"https://api.github.com/repos/paralleljs/pjs/releases{/id}","created_at":"2015-10-22T07:15:36Z","updated_at":"2015-10-22T08:21:32Z","pushed_at":"2015-10-28T04:09:53Z","git_url":"git://github.com/paralleljs/pjs.git","ssh_url":"git@github.com:paralleljs/pjs.git","clone_url":"https://github.com/paralleljs/pjs.git","svn_url":"https://github.com/paralleljs/pjs","homepage":null,"size":0,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paralleljs/pjs/pulls/2"},"html":{"href":"https://github.com/paralleljs/pjs/pull/2"},"issue":{"href":"https://api.github.com/repos/paralleljs/pjs/issues/2"},"comments":{"href":"https://api.github.com/repos/paralleljs/pjs/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/paralleljs/pjs/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/paralleljs/pjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paralleljs/pjs/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/paralleljs/pjs/statuses/06345474bc70cd9873367c17c55c10790907f4c2"}}}}