{"action":"created","issue":{"url":"https://api.github.com/repos/allenai/sbt-plugins/issues/185","labels_url":"https://api.github.com/repos/allenai/sbt-plugins/issues/185/labels{/name}","comments_url":"https://api.github.com/repos/allenai/sbt-plugins/issues/185/comments","events_url":"https://api.github.com/repos/allenai/sbt-plugins/issues/185/events","html_url":"https://github.com/allenai/sbt-plugins/pull/185","id":109214180,"number":185,"title":"Scaladoc generation plugin, with support for publishing to github pages.","user":{"login":"jkinkead","id":1548392,"avatar_url":"https://avatars.githubusercontent.com/u/1548392?v=3","gravatar_id":"","url":"https://api.github.com/users/jkinkead","html_url":"https://github.com/jkinkead","followers_url":"https://api.github.com/users/jkinkead/followers","following_url":"https://api.github.com/users/jkinkead/following{/other_user}","gists_url":"https://api.github.com/users/jkinkead/gists{/gist_id}","starred_url":"https://api.github.com/users/jkinkead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkinkead/subscriptions","organizations_url":"https://api.github.com/users/jkinkead/orgs","repos_url":"https://api.github.com/users/jkinkead/repos","events_url":"https://api.github.com/users/jkinkead/events{/privacy}","received_events_url":"https://api.github.com/users/jkinkead/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"markschaake","id":181607,"avatar_url":"https://avatars.githubusercontent.com/u/181607?v=3","gravatar_id":"","url":"https://api.github.com/users/markschaake","html_url":"https://github.com/markschaake","followers_url":"https://api.github.com/users/markschaake/followers","following_url":"https://api.github.com/users/markschaake/following{/other_user}","gists_url":"https://api.github.com/users/markschaake/gists{/gist_id}","starred_url":"https://api.github.com/users/markschaake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markschaake/subscriptions","organizations_url":"https://api.github.com/users/markschaake/orgs","repos_url":"https://api.github.com/users/markschaake/repos","events_url":"https://api.github.com/users/markschaake/events{/privacy}","received_events_url":"https://api.github.com/users/markschaake/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-10-01T01:54:35Z","updated_at":"2015-10-01T17:30:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/allenai/sbt-plugins/pulls/185","html_url":"https://github.com/allenai/sbt-plugins/pull/185","diff_url":"https://github.com/allenai/sbt-plugins/pull/185.diff","patch_url":"https://github.com/allenai/sbt-plugins/pull/185.patch"},"body":"This is much simpler than it looks; the vast majority of this code is merely to support linking out from our Scaladoc to that of other projects we depend on.\r\n\r\n**Important Note**: This introduces a bug if our plugins are loaded from a build that's not rooted at the base of a git repository. Aristo doesn't do this at all, except in the tester projects in `sbt-plugins`. I don't believe S2 (or any other team) does this, but if they do, there's a workaround in the plugin."},"comment":{"url":"https://api.github.com/repos/allenai/sbt-plugins/issues/comments/144794475","html_url":"https://github.com/allenai/sbt-plugins/pull/185#issuecomment-144794475","issue_url":"https://api.github.com/repos/allenai/sbt-plugins/issues/185","id":144794475,"user":{"login":"markschaake","id":181607,"avatar_url":"https://avatars.githubusercontent.com/u/181607?v=3","gravatar_id":"","url":"https://api.github.com/users/markschaake","html_url":"https://github.com/markschaake","followers_url":"https://api.github.com/users/markschaake/followers","following_url":"https://api.github.com/users/markschaake/following{/other_user}","gists_url":"https://api.github.com/users/markschaake/gists{/gist_id}","starred_url":"https://api.github.com/users/markschaake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markschaake/subscriptions","organizations_url":"https://api.github.com/users/markschaake/orgs","repos_url":"https://api.github.com/users/markschaake/repos","events_url":"https://api.github.com/users/markschaake/events{/privacy}","received_events_url":"https://api.github.com/users/markschaake/received_events","type":"User","site_admin":false},"created_at":"2015-10-01T17:30:43Z","updated_at":"2015-10-01T17:30:43Z","body":"The amount of code and additional sbt plugin dependencies is a bit scary, and hardcoded URL versions (java / akka / etc.) seem brittle. It is also surprising that this much ceremony is required to get scaladocs generated for multi-project build. Oh well, SBT is SBT.\r\n\r\nThe fact this doesn't have an impact on runtime and that it is an opt-in plugin mitigates my concerns... so LGTM and merge when ready!"}}