{"comment":{"url":"https://api.github.com/repos/msricher/romin/comments/14939660","html_url":"https://github.com/msricher/romin/commit/dbaec8ba12a8f8f08428a04a00c609ed4415b15d#commitcomment-14939660","id":14939660,"user":{"login":"tovrstra","id":99431,"avatar_url":"https://avatars.githubusercontent.com/u/99431?v=3","gravatar_id":"","url":"https://api.github.com/users/tovrstra","html_url":"https://github.com/tovrstra","followers_url":"https://api.github.com/users/tovrstra/followers","following_url":"https://api.github.com/users/tovrstra/following{/other_user}","gists_url":"https://api.github.com/users/tovrstra/gists{/gist_id}","starred_url":"https://api.github.com/users/tovrstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tovrstra/subscriptions","organizations_url":"https://api.github.com/users/tovrstra/orgs","repos_url":"https://api.github.com/users/tovrstra/repos","events_url":"https://api.github.com/users/tovrstra/events{/privacy}","received_events_url":"https://api.github.com/users/tovrstra/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"dbaec8ba12a8f8f08428a04a00c609ed4415b15d","created_at":"2015-12-12T05:46:50Z","updated_at":"2015-12-12T05:46:50Z","body":"Looks good. \r\n\r\nCould you add a test that validates this? For example, implement a function and its gradient, where the gradient has a bug in one of the two coordinates. The test should still pass when you use the weights to scan only the correct coordinate. The test has to fail with the default weights. This Q&A explains how to check if an error is raised as expected: http://stackoverflow.com/questions/11767938/how-to-use-noses-assert-raises"}}