{"action":"created","comment":{"url":"https://api.github.com/repos/TWCable/grabbit/pulls/comments/36034741","id":36034741,"diff_hunk":"@@ -32,16 +32,35 @@\n     -->\n \n     <import resource=\"client-batch-job-context.xml\"/>\n+\n+    <import resource=\"client-namespace-step.xml\" />\n     <import resource=\"client-jcrNodes-step.xml\" />\n-    <import resource=\"client-preprocessor-step.xml\" />\n+    <import resource=\"client-deleteBeforeWrite-steps.xml\" />\n \n     <batch:job id=\"clientJob\" xmlns=\"http://www.springframework.org/schema/batch\" job-repository=\"clientJobRepository\">\n-        <batch:step id=\"clientPreprocessor\" next=\"clientWorkflowOff\">\n-            <batch:tasklet ref=\"clientPreprocessTasklet\" transaction-manager=\"clientTransactionManager\"/>\n-        </batch:step>\n-        <batch:step id=\"clientWorkflowOff\" next=\"clientJcrNodes\">\n-            <batch:tasklet ref=\"clientWorkflowOffTasklet\" transaction-manager=\"clientTransactionManager\"/>\n+        <!--  Do any presync tasks concurrently that we can, e.g turning off workflows -->\n+        <batch:split id=\"preSyncFlow\" task-executor=\"asyncTaskExecutor\" next=\"clientNamespaceSync\">\n+            <batch:flow>\n+                <batch:step id=\"clientWorkflowOff\">","path":"grabbit/src/main/resources/META-INF/spring/client-batch-job.xml","position":19,"original_position":19,"commit_id":"e1e8674945fa9375600bd13fad1f986a1da27184","original_commit_id":"e1e8674945fa9375600bd13fad1f986a1da27184","user":{"login":"jbornemann","id":4540994,"avatar_url":"https://avatars.githubusercontent.com/u/4540994?v=3","gravatar_id":"","url":"https://api.github.com/users/jbornemann","html_url":"https://github.com/jbornemann","followers_url":"https://api.github.com/users/jbornemann/followers","following_url":"https://api.github.com/users/jbornemann/following{/other_user}","gists_url":"https://api.github.com/users/jbornemann/gists{/gist_id}","starred_url":"https://api.github.com/users/jbornemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbornemann/subscriptions","organizations_url":"https://api.github.com/users/jbornemann/orgs","repos_url":"https://api.github.com/users/jbornemann/repos","events_url":"https://api.github.com/users/jbornemann/events{/privacy}","received_events_url":"https://api.github.com/users/jbornemann/received_events","type":"User","site_admin":false},"body":"Performance benefits are marginal at this point; but any small wins are great, especially since the complexity is managed by Spring Batch.  That said it's more to establish the pattern, that we should be doing independent tasks concurrently.\r\n\r\nI hope to move namespaceSync into preFlowSync eventually, but for the sake of keeping the PR small...This will make this change a bit more significant.\r\n\r\n\r\n\r\n","created_at":"2015-08-01T16:08:43Z","updated_at":"2015-08-01T16:08:43Z","html_url":"https://github.com/TWCable/grabbit/pull/48#discussion_r36034741","pull_request_url":"https://api.github.com/repos/TWCable/grabbit/pulls/48","_links":{"self":{"href":"https://api.github.com/repos/TWCable/grabbit/pulls/comments/36034741"},"html":{"href":"https://github.com/TWCable/grabbit/pull/48#discussion_r36034741"},"pull_request":{"href":"https://api.github.com/repos/TWCable/grabbit/pulls/48"}}},"pull_request":{"url":"https://api.github.com/repos/TWCable/grabbit/pulls/48","id":40405017,"html_url":"https://github.com/TWCable/grabbit/pull/48","diff_url":"https://github.com/TWCable/grabbit/pull/48.diff","patch_url":"https://github.com/TWCable/grabbit/pull/48.patch","issue_url":"https://api.github.com/repos/TWCable/grabbit/issues/48","number":48,"state":"open","locked":false,"title":"Delete before write","user":{"login":"jbornemann","id":4540994,"avatar_url":"https://avatars.githubusercontent.com/u/4540994?v=3","gravatar_id":"","url":"https://api.github.com/users/jbornemann","html_url":"https://github.com/jbornemann","followers_url":"https://api.github.com/users/jbornemann/followers","following_url":"https://api.github.com/users/jbornemann/following{/other_user}","gists_url":"https://api.github.com/users/jbornemann/gists{/gist_id}","starred_url":"https://api.github.com/users/jbornemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbornemann/subscriptions","organizations_url":"https://api.github.com/users/jbornemann/orgs","repos_url":"https://api.github.com/users/jbornemann/repos","events_url":"https://api.github.com/users/jbornemann/events{/privacy}","received_events_url":"https://api.github.com/users/jbornemann/received_events","type":"User","site_admin":false},"body":"Changes Made (Separate commits) : \r\n\r\n- Delete before write functionality\r\n- Workflow_OFF/deleteBeforeWrite steps are executed concurrently (as no dependency on thread shared inputstream) \r\n- Updated README to reflect delete before write functionality \r\n- Renamed \"PreprocessTasklet, Preprocess*, etc\" to \"NamespaceSyncTasklet, Namespace*, etc\" as there are more than one preprocessors now, so the semantics became confusing.  \r\n \r\nFor https://github.com/TWCable/grabbit/issues/20\r\n\r\nPlease review @jdigger @sikarwarvimal @sagarsane \r\n","created_at":"2015-07-20T22:35:14Z","updated_at":"2015-08-01T16:08:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2dce2a9e47a9e0aefcb1d33ad437b9169defc71c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TWCable/grabbit/pulls/48/commits","review_comments_url":"https://api.github.com/repos/TWCable/grabbit/pulls/48/comments","review_comment_url":"https://api.github.com/repos/TWCable/grabbit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TWCable/grabbit/issues/48/comments","statuses_url":"https://api.github.com/repos/TWCable/grabbit/statuses/e1e8674945fa9375600bd13fad1f986a1da27184","head":{"label":"TWCable:delete-before-write","ref":"delete-before-write","sha":"e1e8674945fa9375600bd13fad1f986a1da27184","user":{"login":"TWCable","id":10778149,"avatar_url":"https://avatars.githubusercontent.com/u/10778149?v=3","gravatar_id":"","url":"https://api.github.com/users/TWCable","html_url":"https://github.com/TWCable","followers_url":"https://api.github.com/users/TWCable/followers","following_url":"https://api.github.com/users/TWCable/following{/other_user}","gists_url":"https://api.github.com/users/TWCable/gists{/gist_id}","starred_url":"https://api.github.com/users/TWCable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TWCable/subscriptions","organizations_url":"https://api.github.com/users/TWCable/orgs","repos_url":"https://api.github.com/users/TWCable/repos","events_url":"https://api.github.com/users/TWCable/events{/privacy}","received_events_url":"https://api.github.com/users/TWCable/received_events","type":"Organization","site_admin":false},"repo":{"id":31395930,"name":"grabbit","full_name":"TWCable/grabbit","owner":{"login":"TWCable","id":10778149,"avatar_url":"https://avatars.githubusercontent.com/u/10778149?v=3","gravatar_id":"","url":"https://api.github.com/users/TWCable","html_url":"https://github.com/TWCable","followers_url":"https://api.github.com/users/TWCable/followers","following_url":"https://api.github.com/users/TWCable/following{/other_user}","gists_url":"https://api.github.com/users/TWCable/gists{/gist_id}","starred_url":"https://api.github.com/users/TWCable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TWCable/subscriptions","organizations_url":"https://api.github.com/users/TWCable/orgs","repos_url":"https://api.github.com/users/TWCable/repos","events_url":"https://api.github.com/users/TWCable/events{/privacy}","received_events_url":"https://api.github.com/users/TWCable/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TWCable/grabbit","description":"Grabbit - Fast Content Sync tool for AEM/CQ","fork":false,"url":"https://api.github.com/repos/TWCable/grabbit","forks_url":"https://api.github.com/repos/TWCable/grabbit/forks","keys_url":"https://api.github.com/repos/TWCable/grabbit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TWCable/grabbit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TWCable/grabbit/teams","hooks_url":"https://api.github.com/repos/TWCable/grabbit/hooks","issue_events_url":"https://api.github.com/repos/TWCable/grabbit/issues/events{/number}","events_url":"https://api.github.com/repos/TWCable/grabbit/events","assignees_url":"https://api.github.com/repos/TWCable/grabbit/assignees{/user}","branches_url":"https://api.github.com/repos/TWCable/grabbit/branches{/branch}","tags_url":"https://api.github.com/repos/TWCable/grabbit/tags","blobs_url":"https://api.github.com/repos/TWCable/grabbit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TWCable/grabbit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TWCable/grabbit/git/refs{/sha}","trees_url":"https://api.github.com/repos/TWCable/grabbit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TWCable/grabbit/statuses/{sha}","languages_url":"https://api.github.com/repos/TWCable/grabbit/languages","stargazers_url":"https://api.github.com/repos/TWCable/grabbit/stargazers","contributors_url":"https://api.github.com/repos/TWCable/grabbit/contributors","subscribers_url":"https://api.github.com/repos/TWCable/grabbit/subscribers","subscription_url":"https://api.github.com/repos/TWCable/grabbit/subscription","commits_url":"https://api.github.com/repos/TWCable/grabbit/commits{/sha}","git_commits_url":"https://api.github.com/repos/TWCable/grabbit/git/commits{/sha}","comments_url":"https://api.github.com/repos/TWCable/grabbit/comments{/number}","issue_comment_url":"https://api.github.com/repos/TWCable/grabbit/issues/comments{/number}","contents_url":"https://api.github.com/repos/TWCable/grabbit/contents/{+path}","compare_url":"https://api.github.com/repos/TWCable/grabbit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TWCable/grabbit/merges","archive_url":"https://api.github.com/repos/TWCable/grabbit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TWCable/grabbit/downloads","issues_url":"https://api.github.com/repos/TWCable/grabbit/issues{/number}","pulls_url":"https://api.github.com/repos/TWCable/grabbit/pulls{/number}","milestones_url":"https://api.github.com/repos/TWCable/grabbit/milestones{/number}","notifications_url":"https://api.github.com/repos/TWCable/grabbit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TWCable/grabbit/labels{/name}","releases_url":"https://api.github.com/repos/TWCable/grabbit/releases{/id}","created_at":"2015-02-27T00:24:35Z","updated_at":"2015-07-21T19:07:00Z","pushed_at":"2015-07-31T20:08:54Z","git_url":"git://github.com/TWCable/grabbit.git","ssh_url":"git@github.com:TWCable/grabbit.git","clone_url":"https://github.com/TWCable/grabbit.git","svn_url":"https://github.com/TWCable/grabbit","homepage":"","size":1199,"stargazers_count":25,"watchers_count":25,"language":"Groovy","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":33,"forks":7,"open_issues":33,"watchers":25,"default_branch":"master"}},"base":{"label":"TWCable:master","ref":"master","sha":"4844d3d0b41b567540039a4aa0ff972d1d32da42","user":{"login":"TWCable","id":10778149,"avatar_url":"https://avatars.githubusercontent.com/u/10778149?v=3","gravatar_id":"","url":"https://api.github.com/users/TWCable","html_url":"https://github.com/TWCable","followers_url":"https://api.github.com/users/TWCable/followers","following_url":"https://api.github.com/users/TWCable/following{/other_user}","gists_url":"https://api.github.com/users/TWCable/gists{/gist_id}","starred_url":"https://api.github.com/users/TWCable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TWCable/subscriptions","organizations_url":"https://api.github.com/users/TWCable/orgs","repos_url":"https://api.github.com/users/TWCable/repos","events_url":"https://api.github.com/users/TWCable/events{/privacy}","received_events_url":"https://api.github.com/users/TWCable/received_events","type":"Organization","site_admin":false},"repo":{"id":31395930,"name":"grabbit","full_name":"TWCable/grabbit","owner":{"login":"TWCable","id":10778149,"avatar_url":"https://avatars.githubusercontent.com/u/10778149?v=3","gravatar_id":"","url":"https://api.github.com/users/TWCable","html_url":"https://github.com/TWCable","followers_url":"https://api.github.com/users/TWCable/followers","following_url":"https://api.github.com/users/TWCable/following{/other_user}","gists_url":"https://api.github.com/users/TWCable/gists{/gist_id}","starred_url":"https://api.github.com/users/TWCable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TWCable/subscriptions","organizations_url":"https://api.github.com/users/TWCable/orgs","repos_url":"https://api.github.com/users/TWCable/repos","events_url":"https://api.github.com/users/TWCable/events{/privacy}","received_events_url":"https://api.github.com/users/TWCable/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TWCable/grabbit","description":"Grabbit - Fast Content Sync tool for AEM/CQ","fork":false,"url":"https://api.github.com/repos/TWCable/grabbit","forks_url":"https://api.github.com/repos/TWCable/grabbit/forks","keys_url":"https://api.github.com/repos/TWCable/grabbit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TWCable/grabbit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TWCable/grabbit/teams","hooks_url":"https://api.github.com/repos/TWCable/grabbit/hooks","issue_events_url":"https://api.github.com/repos/TWCable/grabbit/issues/events{/number}","events_url":"https://api.github.com/repos/TWCable/grabbit/events","assignees_url":"https://api.github.com/repos/TWCable/grabbit/assignees{/user}","branches_url":"https://api.github.com/repos/TWCable/grabbit/branches{/branch}","tags_url":"https://api.github.com/repos/TWCable/grabbit/tags","blobs_url":"https://api.github.com/repos/TWCable/grabbit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TWCable/grabbit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TWCable/grabbit/git/refs{/sha}","trees_url":"https://api.github.com/repos/TWCable/grabbit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TWCable/grabbit/statuses/{sha}","languages_url":"https://api.github.com/repos/TWCable/grabbit/languages","stargazers_url":"https://api.github.com/repos/TWCable/grabbit/stargazers","contributors_url":"https://api.github.com/repos/TWCable/grabbit/contributors","subscribers_url":"https://api.github.com/repos/TWCable/grabbit/subscribers","subscription_url":"https://api.github.com/repos/TWCable/grabbit/subscription","commits_url":"https://api.github.com/repos/TWCable/grabbit/commits{/sha}","git_commits_url":"https://api.github.com/repos/TWCable/grabbit/git/commits{/sha}","comments_url":"https://api.github.com/repos/TWCable/grabbit/comments{/number}","issue_comment_url":"https://api.github.com/repos/TWCable/grabbit/issues/comments{/number}","contents_url":"https://api.github.com/repos/TWCable/grabbit/contents/{+path}","compare_url":"https://api.github.com/repos/TWCable/grabbit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TWCable/grabbit/merges","archive_url":"https://api.github.com/repos/TWCable/grabbit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TWCable/grabbit/downloads","issues_url":"https://api.github.com/repos/TWCable/grabbit/issues{/number}","pulls_url":"https://api.github.com/repos/TWCable/grabbit/pulls{/number}","milestones_url":"https://api.github.com/repos/TWCable/grabbit/milestones{/number}","notifications_url":"https://api.github.com/repos/TWCable/grabbit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TWCable/grabbit/labels{/name}","releases_url":"https://api.github.com/repos/TWCable/grabbit/releases{/id}","created_at":"2015-02-27T00:24:35Z","updated_at":"2015-07-21T19:07:00Z","pushed_at":"2015-07-31T20:08:54Z","git_url":"git://github.com/TWCable/grabbit.git","ssh_url":"git@github.com:TWCable/grabbit.git","clone_url":"https://github.com/TWCable/grabbit.git","svn_url":"https://github.com/TWCable/grabbit","homepage":"","size":1199,"stargazers_count":25,"watchers_count":25,"language":"Groovy","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":33,"forks":7,"open_issues":33,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TWCable/grabbit/pulls/48"},"html":{"href":"https://github.com/TWCable/grabbit/pull/48"},"issue":{"href":"https://api.github.com/repos/TWCable/grabbit/issues/48"},"comments":{"href":"https://api.github.com/repos/TWCable/grabbit/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/TWCable/grabbit/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/TWCable/grabbit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TWCable/grabbit/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/TWCable/grabbit/statuses/e1e8674945fa9375600bd13fad1f986a1da27184"}}}}