{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3218","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3218/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3218/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3218/events","html_url":"https://github.com/cockroachdb/cockroach/pull/3218","id":118672187,"number":3218,"title":"WIP: implement postgres wire protocol","user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-11-24T18:18:33Z","updated_at":"2015-11-24T22:36:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/3218","html_url":"https://github.com/cockroachdb/cockroach/pull/3218","diff_url":"https://github.com/cockroachdb/cockroach/pull/3218.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/3218.patch"},"body":"Out for early review per @petermattis.\r\n\r\nTransactions are not yet implemented, and authentication is incomplete.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/3218)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/159428136","html_url":"https://github.com/cockroachdb/cockroach/pull/3218#issuecomment-159428136","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3218","id":159428136,"user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"created_at":"2015-11-24T22:36:19Z","updated_at":"2015-11-24T22:36:19Z","body":"\n\n\n\nReview status: 0 of 28 files reviewed at latest revision, 9 unresolved discussions.\n\n---\n\n*[sql/driver/wire.proto, line 99 \\[r3\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/3218#-K3vXVJgGQZsKVgCwfLv:-K3vanEZAQmwfNbNrZOq:529426274) ([raw file](https://github.com/cockroachdb/cockroach/blob/66ca88ba4b8dc001ed841ce1da8230854453ab60/sql/driver/wire.proto#L99)):*\nDone goofed. Reverted.\n\n---\n\n*[sql/logic_test.go, line 466 \\[r3\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/3218#-K3vYCWoYuYw_D9mwJTu:-K3vas-CE7qo6toffzan:53268199) ([raw file](https://github.com/cockroachdb/cockroach/blob/66ca88ba4b8dc001ed841ce1da8230854453ab60/sql/logic_test.go#L466)):*\nactually, I'm not sure.\n\n---\n\n*[sql/logic_test.go, line 480 \\[r3\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/3218#-K3vYQZGM2LqXzxeeCzh:-K3vblk_iKZgP3p9F5Pj:-499146009) ([raw file](https://github.com/cockroachdb/cockroach/blob/66ca88ba4b8dc001ed841ce1da8230854453ab60/sql/logic_test.go#L480)):*\nDone.\n\n---\n\n*[sql/parser/values.go, line 36 \\[r3\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/3218#-K3vYhDf3SD53zIUnTbF:-K3vbmj4TinxfIDwz-pi:700048134) ([raw file](https://github.com/cockroachdb/cockroach/blob/66ca88ba4b8dc001ed841ce1da8230854453ab60/sql/parser/values.go#L36)):*\nNah, just seemed simpler. It's in a separate commit.\n\n---\n\n*[sql/scan.go, line 530 \\[r3\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/3218#-K3vZWDyE0h83-EUaaEC:-K3vce5sBYtiQaoNR2lR:1256157153) ([raw file](https://github.com/cockroachdb/cockroach/blob/66ca88ba4b8dc001ed841ce1da8230854453ab60/sql/scan.go#L530)):*\nTurns out it's possible to type check just once. Changed.\n\n---\n\n*[sql/testdata/datetime, line 20 \\[r3\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/3218#-K3vZvGtKwBKVQmn_9Fg:-K3vch5x2jccZlGtKc0H:428150391) ([raw file](https://github.com/cockroachdb/cockroach/blob/66ca88ba4b8dc001ed841ce1da8230854453ab60/sql/testdata/datetime#L20)):*\nThey were previously arriving as `driver.Date`, not `time.Time`\n\n---\n\n*[sql/testdata/txn, line 77 \\[r3\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/3218#-K3v_862btq4MMTCq30g:-K3vcoqzSaU5dxYKwMeS:1806070135) ([raw file](https://github.com/cockroachdb/cockroach/blob/66ca88ba4b8dc001ed841ce1da8230854453ab60/sql/testdata/txn#L77)):*\nThat's the behaviour change (see one of the commit messages). pgwire is outputting them all.\n\n---\n\n*[rpc/codec/conn.go, line 36 \\[r3\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/3218#-K3vWGN5UOK-8sYnOSAx:-K3va_6zAhhgCi0B60xr:-499146009) ([raw file](https://github.com/cockroachdb/cockroach/blob/66ca88ba4b8dc001ed841ce1da8230854453ab60/rpc/codec/conn.go#L36)):*\nDone.\n\n---\n\n\n*Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/cockroachdb/cockroach/3218)*\n<!-- Sent from Reviewable.io -->\n"}}