{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/26190227","id":26190227,"diff_hunk":"@@ -13,7 +13,7 @@ fn main() {\n     pub struct A; //~ ERROR: visibility has no effect\n     pub enum B {} //~ ERROR: visibility has no effect\n     pub trait C { //~ ERROR: visibility has no effect\n-        pub fn foo(&self) {} //~ ERROR: visibility has no effect\n+        fn foo(&self) {}","path":"src/test/compile-fail/unnecessary-private.rs","position":5,"original_position":5,"commit_id":"def8023c54e9d103d4ecf6cdb3035ee5763d3917","original_commit_id":"ad05505059994e58b81f2e6edf1245d87b105346","user":{"login":"eddyb","id":77424,"avatar_url":"https://avatars.githubusercontent.com/u/77424?v=3","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false},"body":"I've added two parse-fail tests. I hope that's enough.","created_at":"2015-03-11T05:46:47Z","updated_at":"2015-03-11T05:46:47Z","html_url":"https://github.com/rust-lang/rust/pull/23265#discussion_r26190227","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/23265","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/26190227"},"html":{"href":"https://github.com/rust-lang/rust/pull/23265#discussion_r26190227"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/23265"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/23265","id":30899439,"html_url":"https://github.com/rust-lang/rust/pull/23265","diff_url":"https://github.com/rust-lang/rust/pull/23265.diff","patch_url":"https://github.com/rust-lang/rust/pull/23265.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/23265","number":23265,"state":"open","locked":false,"title":"Refactor the way methods are stored in ast::ImplItem/TraitItem.","user":{"login":"eddyb","id":77424,"avatar_url":"https://avatars.githubusercontent.com/u/77424?v=3","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false},"body":"The end result is that common fields (id, name, attributes, etc.) are stored in now-structures `ImplItem` and `TraitItem`.\r\nThe signature of a method is no longer duplicated between methods with a body (default/impl) and those without, they now share `MethodSig`.\r\n\r\nThis is also a [breaking-change] because of minor bugfixes and changes to syntax extensions:\r\n* `pub fn` methods in a trait no longer parse - remove the `pub`, it has no meaning anymore\r\n* `MacResult::make_methods` is now `make_impl_items` and the return type has changed accordingly\r\n* `quote_method` is gone, because `P<ast::Method>` doesn't exist and it couldn't represent a full method anyways - could be replaced by `quote_impl_item`/`quote_trait_item` in the future, but I do hope we realize how silly that combinatorial macro expansion is and settle on a single `quote` macro + some type hints - or just no types at all (only token-trees)\r\n\r\nr? @nikomatsakis This is necessary (hopefully also sufficient) for associated constants.","created_at":"2015-03-10T22:32:01Z","updated_at":"2015-03-11T05:46:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39ee3389d82833acb9bb0090f83d207848b44d75","assignee":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars.githubusercontent.com/u/155238?v=3","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/23265/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/23265/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/23265/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/def8023c54e9d103d4ecf6cdb3035ee5763d3917","head":{"label":"eddyb:meth-ast-refactor","ref":"meth-ast-refactor","sha":"def8023c54e9d103d4ecf6cdb3035ee5763d3917","user":{"login":"eddyb","id":77424,"avatar_url":"https://avatars.githubusercontent.com/u/77424?v=3","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false},"repo":{"id":13473977,"name":"rust","full_name":"eddyb/rust","owner":{"login":"eddyb","id":77424,"avatar_url":"https://avatars.githubusercontent.com/u/77424?v=3","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eddyb/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/eddyb/rust","forks_url":"https://api.github.com/repos/eddyb/rust/forks","keys_url":"https://api.github.com/repos/eddyb/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eddyb/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eddyb/rust/teams","hooks_url":"https://api.github.com/repos/eddyb/rust/hooks","issue_events_url":"https://api.github.com/repos/eddyb/rust/issues/events{/number}","events_url":"https://api.github.com/repos/eddyb/rust/events","assignees_url":"https://api.github.com/repos/eddyb/rust/assignees{/user}","branches_url":"https://api.github.com/repos/eddyb/rust/branches{/branch}","tags_url":"https://api.github.com/repos/eddyb/rust/tags","blobs_url":"https://api.github.com/repos/eddyb/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eddyb/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eddyb/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/eddyb/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eddyb/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/eddyb/rust/languages","stargazers_url":"https://api.github.com/repos/eddyb/rust/stargazers","contributors_url":"https://api.github.com/repos/eddyb/rust/contributors","subscribers_url":"https://api.github.com/repos/eddyb/rust/subscribers","subscription_url":"https://api.github.com/repos/eddyb/rust/subscription","commits_url":"https://api.github.com/repos/eddyb/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/eddyb/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/eddyb/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/eddyb/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/eddyb/rust/contents/{+path}","compare_url":"https://api.github.com/repos/eddyb/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eddyb/rust/merges","archive_url":"https://api.github.com/repos/eddyb/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eddyb/rust/downloads","issues_url":"https://api.github.com/repos/eddyb/rust/issues{/number}","pulls_url":"https://api.github.com/repos/eddyb/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/eddyb/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/eddyb/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eddyb/rust/labels{/name}","releases_url":"https://api.github.com/repos/eddyb/rust/releases{/id}","created_at":"2013-10-10T14:40:52Z","updated_at":"2014-10-30T16:59:11Z","pushed_at":"2015-03-11T05:45:49Z","git_url":"git://github.com/eddyb/rust.git","ssh_url":"git@github.com:eddyb/rust.git","clone_url":"https://github.com/eddyb/rust.git","svn_url":"https://github.com/eddyb/rust","homepage":"http://www.rust-lang.org","size":252585,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"f899513a30165946a75ff7f515ab37a226e72172","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"a safe, concurrent, practical language","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2015-03-11T05:42:34Z","pushed_at":"2015-03-11T04:07:17Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":502517,"stargazers_count":9692,"watchers_count":9692,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1876,"mirror_url":null,"open_issues_count":2009,"forks":1876,"open_issues":2009,"watchers":9692,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/23265"},"html":{"href":"https://github.com/rust-lang/rust/pull/23265"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/23265"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/23265/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/23265/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/23265/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/def8023c54e9d103d4ecf6cdb3035ee5763d3917"}}}}