{"action":"closed","number":4,"pull_request":{"url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/pulls/4","id":51552968,"html_url":"https://github.com/CloudCredo/graphite-statsd-boshrelease/pull/4","diff_url":"https://github.com/CloudCredo/graphite-statsd-boshrelease/pull/4.diff","patch_url":"https://github.com/CloudCredo/graphite-statsd-boshrelease/pull/4.patch","issue_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/issues/4","number":4,"state":"closed","locked":false,"title":"Metrics whitelist and blacklist","user":{"login":"saliceti","id":8416694,"avatar_url":"https://avatars.githubusercontent.com/u/8416694?v=3","gravatar_id":"","url":"https://api.github.com/users/saliceti","html_url":"https://github.com/saliceti","followers_url":"https://api.github.com/users/saliceti/followers","following_url":"https://api.github.com/users/saliceti/following{/other_user}","gists_url":"https://api.github.com/users/saliceti/gists{/gist_id}","starred_url":"https://api.github.com/users/saliceti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saliceti/subscriptions","organizations_url":"https://api.github.com/users/saliceti/orgs","repos_url":"https://api.github.com/users/saliceti/repos","events_url":"https://api.github.com/users/saliceti/events{/privacy}","received_events_url":"https://api.github.com/users/saliceti/received_events","type":"User","site_admin":false},"body":"# What\r\nWe want to avoid storing certain metrics because too many useless metrics make graphite really slow. Our use case here is the CF smoke tests that create a new application name everytime they run and fill the metrics directories with thousands of files.\r\n\r\nWe created a new release of graphite-statsd with customised templates to be able to change the whitelist/blacklist configuration via CF manifest properties.\r\n\r\n# How to review\r\nTo test independently:\r\n* Clone this repository/branch\r\n* Inside the repository, run: `bosh create release --force`\r\n* Run: `bosh upload release`\r\n* Run: `bosh releases` and take note of the version number (ex: 0+dev.1)\r\n* Edit cf-manifest.yml:\r\n\r\n```\r\n- default_networks:\r\n...\r\n  name: graphite\r\n  properties:\r\n    carbon:\r\n      filter:\r\n        enable: true\r\n        blacklist:\r\n        - stats\\.counters\\.cfstats\\.router_.+\\.[0-9]+\\.http\\.requests\\.[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}_trial_cf_paas_alphagov_co_uk.count.*\r\n...\r\nreleases:\r\n...\r\n- name: graphite\r\n  version: 0+dev.1\r\n```\r\nThis would filter the smoke test apps because they are created with name starting as UUID.\r\n* Run: `bosh deploy`\r\n\r\nThis can be tested by sending fake metrics to statsd on the graphite server:\r\n\r\n```\r\necho \"stats.counters.cfstats.router_z1.0.http.requests.031427f0-9ec4-47b6-4544-22c2b05cfbb0_trial_cf_paas_alphagov_co_uk.count 42 `date +%s`\" | nc localhost 2003\r\n```\r\nCheck the carbon creates log to see wether is creates new metrics or not.\r\n","created_at":"2015-11-23T17:21:41Z","updated_at":"2015-12-01T08:43:19Z","closed_at":"2015-12-01T08:43:19Z","merged_at":"2015-12-01T08:43:19Z","merge_commit_sha":"d1d89b0e0562deeff23dda1e5177fb0990562134","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/pulls/4/commits","review_comments_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/pulls/4/comments","review_comment_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/issues/4/comments","statuses_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/statuses/859bb9abc88aba5b45172a409b7dda4ec7b8a68c","head":{"label":"alphagov:108616770_metrics_blacklist","ref":"108616770_metrics_blacklist","sha":"859bb9abc88aba5b45172a409b7dda4ec7b8a68c","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":46716295,"name":"graphite-statsd-boshrelease","full_name":"alphagov/graphite-statsd-boshrelease","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/graphite-statsd-boshrelease","description":"A Graphite BOSH Release","fork":true,"url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease","forks_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/forks","keys_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/teams","hooks_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/hooks","issue_events_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/events","assignees_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/tags","blobs_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/languages","stargazers_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/stargazers","contributors_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/contributors","subscribers_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/subscribers","subscription_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/subscription","commits_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/merges","archive_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/downloads","issues_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/graphite-statsd-boshrelease/releases{/id}","created_at":"2015-11-23T11:35:55Z","updated_at":"2015-11-23T11:35:56Z","pushed_at":"2015-11-30T10:41:23Z","git_url":"git://github.com/alphagov/graphite-statsd-boshrelease.git","ssh_url":"git@github.com:alphagov/graphite-statsd-boshrelease.git","clone_url":"https://github.com/alphagov/graphite-statsd-boshrelease.git","svn_url":"https://github.com/alphagov/graphite-statsd-boshrelease","homepage":null,"size":80,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CloudCredo:master","ref":"master","sha":"0d79bf5aa5f2cf29195bff725d7dee55dea1aedc","user":{"login":"CloudCredo","id":3024259,"avatar_url":"https://avatars.githubusercontent.com/u/3024259?v=3","gravatar_id":"","url":"https://api.github.com/users/CloudCredo","html_url":"https://github.com/CloudCredo","followers_url":"https://api.github.com/users/CloudCredo/followers","following_url":"https://api.github.com/users/CloudCredo/following{/other_user}","gists_url":"https://api.github.com/users/CloudCredo/gists{/gist_id}","starred_url":"https://api.github.com/users/CloudCredo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CloudCredo/subscriptions","organizations_url":"https://api.github.com/users/CloudCredo/orgs","repos_url":"https://api.github.com/users/CloudCredo/repos","events_url":"https://api.github.com/users/CloudCredo/events{/privacy}","received_events_url":"https://api.github.com/users/CloudCredo/received_events","type":"Organization","site_admin":false},"repo":{"id":32825565,"name":"graphite-statsd-boshrelease","full_name":"CloudCredo/graphite-statsd-boshrelease","owner":{"login":"CloudCredo","id":3024259,"avatar_url":"https://avatars.githubusercontent.com/u/3024259?v=3","gravatar_id":"","url":"https://api.github.com/users/CloudCredo","html_url":"https://github.com/CloudCredo","followers_url":"https://api.github.com/users/CloudCredo/followers","following_url":"https://api.github.com/users/CloudCredo/following{/other_user}","gists_url":"https://api.github.com/users/CloudCredo/gists{/gist_id}","starred_url":"https://api.github.com/users/CloudCredo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CloudCredo/subscriptions","organizations_url":"https://api.github.com/users/CloudCredo/orgs","repos_url":"https://api.github.com/users/CloudCredo/repos","events_url":"https://api.github.com/users/CloudCredo/events{/privacy}","received_events_url":"https://api.github.com/users/CloudCredo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CloudCredo/graphite-statsd-boshrelease","description":"A Graphite BOSH Release","fork":false,"url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease","forks_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/forks","keys_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/teams","hooks_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/hooks","issue_events_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/issues/events{/number}","events_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/events","assignees_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/assignees{/user}","branches_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/branches{/branch}","tags_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/tags","blobs_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/git/refs{/sha}","trees_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/statuses/{sha}","languages_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/languages","stargazers_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/stargazers","contributors_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/contributors","subscribers_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/subscribers","subscription_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/subscription","commits_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/commits{/sha}","git_commits_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/git/commits{/sha}","comments_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/comments{/number}","issue_comment_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/issues/comments{/number}","contents_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/contents/{+path}","compare_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/merges","archive_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/downloads","issues_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/issues{/number}","pulls_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/pulls{/number}","milestones_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/milestones{/number}","notifications_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/labels{/name}","releases_url":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/releases{/id}","created_at":"2015-03-24T21:14:26Z","updated_at":"2015-11-29T23:19:32Z","pushed_at":"2015-12-01T08:43:19Z","git_url":"git://github.com/CloudCredo/graphite-statsd-boshrelease.git","ssh_url":"git@github.com:CloudCredo/graphite-statsd-boshrelease.git","clone_url":"https://github.com/CloudCredo/graphite-statsd-boshrelease.git","svn_url":"https://github.com/CloudCredo/graphite-statsd-boshrelease","homepage":null,"size":77,"stargazers_count":6,"watchers_count":6,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/pulls/4"},"html":{"href":"https://github.com/CloudCredo/graphite-statsd-boshrelease/pull/4"},"issue":{"href":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/issues/4"},"comments":{"href":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/CloudCredo/graphite-statsd-boshrelease/statuses/859bb9abc88aba5b45172a409b7dda4ec7b8a68c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"teddyking","id":6475144,"avatar_url":"https://avatars.githubusercontent.com/u/6475144?v=3","gravatar_id":"","url":"https://api.github.com/users/teddyking","html_url":"https://github.com/teddyking","followers_url":"https://api.github.com/users/teddyking/followers","following_url":"https://api.github.com/users/teddyking/following{/other_user}","gists_url":"https://api.github.com/users/teddyking/gists{/gist_id}","starred_url":"https://api.github.com/users/teddyking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teddyking/subscriptions","organizations_url":"https://api.github.com/users/teddyking/orgs","repos_url":"https://api.github.com/users/teddyking/repos","events_url":"https://api.github.com/users/teddyking/events{/privacy}","received_events_url":"https://api.github.com/users/teddyking/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":3,"additions":23,"deletions":3,"changed_files":4}}