{"action":"created","issue":{"url":"https://api.github.com/repos/trakt/script.trakt/issues/183","labels_url":"https://api.github.com/repos/trakt/script.trakt/issues/183/labels{/name}","comments_url":"https://api.github.com/repos/trakt/script.trakt/issues/183/comments","events_url":"https://api.github.com/repos/trakt/script.trakt/issues/183/events","html_url":"https://github.com/trakt/script.trakt/issues/183","id":43354498,"number":183,"title":"Question on rating only working w/ library items","user":{"login":"tknorris","id":1934551,"avatar_url":"https://avatars.githubusercontent.com/u/1934551?v=3","gravatar_id":"","url":"https://api.github.com/users/tknorris","html_url":"https://github.com/tknorris","followers_url":"https://api.github.com/users/tknorris/followers","following_url":"https://api.github.com/users/tknorris/following{/other_user}","gists_url":"https://api.github.com/users/tknorris/gists{/gist_id}","starred_url":"https://api.github.com/users/tknorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tknorris/subscriptions","organizations_url":"https://api.github.com/users/tknorris/orgs","repos_url":"https://api.github.com/users/tknorris/repos","events_url":"https://api.github.com/users/tknorris/events{/privacy}","received_events_url":"https://api.github.com/users/tknorris/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/trakt/script.trakt/labels/feature","name":"feature","color":"467505"},{"url":"https://api.github.com/repos/trakt/script.trakt/labels/ratings","name":"ratings","color":"8C2318"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":30,"created_at":"2014-09-22T02:19:34Z","updated_at":"2015-03-08T23:22:47Z","closed_at":null,"body":"There is a comment in the wiki that says manual rating only works with library items. I was looking through this code to see if I could at least reuse the ratings dialog in my addon and I started to notice that there seemed to be quite a bit of code already in the rating code dedicated to working with non-library items. There were only a very few minor issues preventing it from working. In particular:\r\n\r\nIf line 217 of service.py is changed to:\r\n```\r\nif 'dbid' in data and (utilities.isMovie(media_type) or utilities.isShow(media_type)):\r\n```\r\nand Line 203 of service.py a minor typo is corrected to:\r\n```\r\nelif 'remoteid' in data:\r\n```\r\nand lastly if line 164 of rating.py is changed to:\r\n```\r\nif 'xbmc_id' in media and tagging.isTaggingEnabled() and tagging.isRatingsEnabled():\r\n```\r\n then everything seems to work just fine for rating non-library items. I tested movies, tvshows and episodes and they all rated no problem. I would much prefer to re-use the script's ratings dialog than write my own that is essentially the same. Any chance of getting these changes made?"},"comment":{"url":"https://api.github.com/repos/trakt/script.trakt/issues/comments/77781610","html_url":"https://github.com/trakt/script.trakt/issues/183#issuecomment-77781610","issue_url":"https://api.github.com/repos/trakt/script.trakt/issues/183","id":77781610,"user":{"login":"Razzeee","id":5943908,"avatar_url":"https://avatars.githubusercontent.com/u/5943908?v=3","gravatar_id":"","url":"https://api.github.com/users/Razzeee","html_url":"https://github.com/Razzeee","followers_url":"https://api.github.com/users/Razzeee/followers","following_url":"https://api.github.com/users/Razzeee/following{/other_user}","gists_url":"https://api.github.com/users/Razzeee/gists{/gist_id}","starred_url":"https://api.github.com/users/Razzeee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Razzeee/subscriptions","organizations_url":"https://api.github.com/users/Razzeee/orgs","repos_url":"https://api.github.com/users/Razzeee/repos","events_url":"https://api.github.com/users/Razzeee/events{/privacy}","received_events_url":"https://api.github.com/users/Razzeee/received_events","type":"User","site_admin":false},"created_at":"2015-03-08T23:22:47Z","updated_at":"2015-03-08T23:22:47Z","body":"Forgot about that. Any chance we can add this to the call? It seems pretty wasteful to me, doing a whole api call for this information."}}