{"action":"created","issue":{"url":"https://api.github.com/repos/void256/nifty-gui/issues/303","labels_url":"https://api.github.com/repos/void256/nifty-gui/issues/303/labels{/name}","comments_url":"https://api.github.com/repos/void256/nifty-gui/issues/303/comments","events_url":"https://api.github.com/repos/void256/nifty-gui/issues/303/events","html_url":"https://github.com/void256/nifty-gui/issues/303","id":53037535,"number":303,"title":"Manual setting for localization bundle encoding","user":{"login":"jedi-philosopher","id":5557192,"avatar_url":"https://avatars.githubusercontent.com/u/5557192?v=3","gravatar_id":"","url":"https://api.github.com/users/jedi-philosopher","html_url":"https://github.com/jedi-philosopher","followers_url":"https://api.github.com/users/jedi-philosopher/followers","following_url":"https://api.github.com/users/jedi-philosopher/following{/other_user}","gists_url":"https://api.github.com/users/jedi-philosopher/gists{/gist_id}","starred_url":"https://api.github.com/users/jedi-philosopher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedi-philosopher/subscriptions","organizations_url":"https://api.github.com/users/jedi-philosopher/orgs","repos_url":"https://api.github.com/users/jedi-philosopher/repos","events_url":"https://api.github.com/users/jedi-philosopher/events{/privacy}","received_events_url":"https://api.github.com/users/jedi-philosopher/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2014-12-29T12:17:54Z","updated_at":"2015-01-06T19:03:27Z","closed_at":null,"body":"In 1.4.0 the signature of method used for adding localization bundles has changed. It now accepts only bundle file name, and there is no way to affect how it is loaded.\r\n\r\nBy default, java properties are loaded in ISO 8859-1 encoding. However, it is quite restricted and, for example, does not contain cyrillic letters, that are needed for localizing game in russian and some other ex-USSR languages.\r\n\r\nIn 1.3.2 I could use the UTF-8 property files by loading them myself and manually setting the right encoding. In 1.4.0 it is no longer possible, so it is now quite difficult to localize GUI to a language that uses non-latin alphabet (you should make your text in UTF-8, then use some converter to make them 8859-encoded with utf escaping and use them in game, one extra step in a build process)\r\n\r\nThere should be some method that accepts pre-loaded ResourceBundle, like it was before, or it should accept the Reader class instead of a file name, just like ResourceBundle does"},"comment":{"url":"https://api.github.com/repos/void256/nifty-gui/issues/comments/68914471","html_url":"https://github.com/void256/nifty-gui/issues/303#issuecomment-68914471","issue_url":"https://api.github.com/repos/void256/nifty-gui/issues/303","id":68914471,"user":{"login":"bgroenks96","id":841306,"avatar_url":"https://avatars.githubusercontent.com/u/841306?v=3","gravatar_id":"","url":"https://api.github.com/users/bgroenks96","html_url":"https://github.com/bgroenks96","followers_url":"https://api.github.com/users/bgroenks96/followers","following_url":"https://api.github.com/users/bgroenks96/following{/other_user}","gists_url":"https://api.github.com/users/bgroenks96/gists{/gist_id}","starred_url":"https://api.github.com/users/bgroenks96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgroenks96/subscriptions","organizations_url":"https://api.github.com/users/bgroenks96/orgs","repos_url":"https://api.github.com/users/bgroenks96/repos","events_url":"https://api.github.com/users/bgroenks96/events{/privacy}","received_events_url":"https://api.github.com/users/bgroenks96/received_events","type":"User","site_admin":false},"created_at":"2015-01-06T19:03:26Z","updated_at":"2015-01-06T19:03:26Z","body":"This appears to be a side effect of commit 9547ad16a838a992927333303157c78a988f81b0 which addresses issue #100 (still open).\r\n\r\n@void256 I will need your input on this for why exactly the `resourceBundles` HashMap had to be changed to `<String,String>` as opposed to `<String,ResourceBundle>`.\r\n\r\nIt seems to me like it might be possible to go back to the previous HashMap type and simply retain the implementation of `getResourceBundles` to return a String version... with the addition of another method possibly to allow direct access to `ResourceBundle`"}}