{"action":"created","issue":{"url":"https://api.github.com/repos/ArxOne/FTP/issues/7","labels_url":"https://api.github.com/repos/ArxOne/FTP/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/ArxOne/FTP/issues/7/comments","events_url":"https://api.github.com/repos/ArxOne/FTP/issues/7/events","html_url":"https://github.com/ArxOne/FTP/issues/7","id":93492337,"number":7,"title":"Make methods virtual/implement strategy pattern","user":{"login":"Eleasar","id":2845750,"avatar_url":"https://avatars.githubusercontent.com/u/2845750?v=3","gravatar_id":"","url":"https://api.github.com/users/Eleasar","html_url":"https://github.com/Eleasar","followers_url":"https://api.github.com/users/Eleasar/followers","following_url":"https://api.github.com/users/Eleasar/following{/other_user}","gists_url":"https://api.github.com/users/Eleasar/gists{/gist_id}","starred_url":"https://api.github.com/users/Eleasar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eleasar/subscriptions","organizations_url":"https://api.github.com/users/Eleasar/orgs","repos_url":"https://api.github.com/users/Eleasar/repos","events_url":"https://api.github.com/users/Eleasar/events{/privacy}","received_events_url":"https://api.github.com/users/Eleasar/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ArxOne/FTP/labels/enhancement","name":"enhancement","color":"fbca04"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-07-07T10:02:05Z","updated_at":"2015-07-07T15:09:40Z","closed_at":"2015-07-07T15:09:40Z","body":"We have a (filezilla) server that emulates unix - directory names would not need to be escaped in this case (though it is marked as unix emulated). In the current form the code is very nicely encapsulated - but it is very hard to extend.\r\n\r\nMaybe you could change the methods to virtual ones and private ones to protected. And/or include some strategy pattern to handle unix/windows specific logic (which could then be overridden or implemented as a new strategy for custom servers)."},"comment":{"url":"https://api.github.com/repos/ArxOne/FTP/issues/comments/119233797","html_url":"https://github.com/ArxOne/FTP/issues/7#issuecomment-119233797","issue_url":"https://api.github.com/repos/ArxOne/FTP/issues/7","id":119233797,"user":{"login":"picrap","id":251429,"avatar_url":"https://avatars.githubusercontent.com/u/251429?v=3","gravatar_id":"","url":"https://api.github.com/users/picrap","html_url":"https://github.com/picrap","followers_url":"https://api.github.com/users/picrap/followers","following_url":"https://api.github.com/users/picrap/following{/other_user}","gists_url":"https://api.github.com/users/picrap/gists{/gist_id}","starred_url":"https://api.github.com/users/picrap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/picrap/subscriptions","organizations_url":"https://api.github.com/users/picrap/orgs","repos_url":"https://api.github.com/users/picrap/repos","events_url":"https://api.github.com/users/picrap/events{/privacy}","received_events_url":"https://api.github.com/users/picrap/received_events","type":"User","site_admin":false},"created_at":"2015-07-07T15:09:40Z","updated_at":"2015-07-07T15:09:40Z","body":"`FtpClient` is actually a high-level wrapper for low-level commands (I found no other ftp client for doing both high-level and low-level commands, this is why I wrote this one), so you can easily implement your own commands as new methods (and inherited from `FtpClient` or `FtpClientCore`).\r\nI close this issue, but the MLST/MLSD stays open, of course.\r\nIf you want, you can also fork the project, make your changes and submit them as a pull request."}}