{"action":"closed","number":1665,"pull_request":{"url":"https://api.github.com/repos/spf13/hugo/pulls/1665","id":52468664,"html_url":"https://github.com/spf13/hugo/pull/1665","diff_url":"https://github.com/spf13/hugo/pull/1665.diff","patch_url":"https://github.com/spf13/hugo/pull/1665.patch","issue_url":"https://api.github.com/repos/spf13/hugo/issues/1665","number":1665,"state":"closed","locked":false,"title":"Remove transformation of menu URLs","user":{"login":"gunnaraasen","id":628831,"avatar_url":"https://avatars.githubusercontent.com/u/628831?v=3","gravatar_id":"","url":"https://api.github.com/users/gunnaraasen","html_url":"https://github.com/gunnaraasen","followers_url":"https://api.github.com/users/gunnaraasen/followers","following_url":"https://api.github.com/users/gunnaraasen/following{/other_user}","gists_url":"https://api.github.com/users/gunnaraasen/gists{/gist_id}","starred_url":"https://api.github.com/users/gunnaraasen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunnaraasen/subscriptions","organizations_url":"https://api.github.com/users/gunnaraasen/orgs","repos_url":"https://api.github.com/users/gunnaraasen/repos","events_url":"https://api.github.com/users/gunnaraasen/events{/privacy}","received_events_url":"https://api.github.com/users/gunnaraasen/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/spf13/hugo/issues/1239. With this change, menu URLS will only be urlized and sanitized. It removes the URL prep step, which incorrectly transformed links in some cases. \r\n\r\nWould appreciate some feedback on `TestSectionPagesMenu` since I'm not quite sure if the changes preserve the intent of that test.\r\n\r\nAlso, I signed the CLA.","created_at":"2015-12-02T23:09:37Z","updated_at":"2015-12-06T14:26:45Z","closed_at":"2015-12-06T14:26:45Z","merged_at":null,"merge_commit_sha":"5fee96b9000416ca7521faf5cbc007c3d0728a2a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spf13/hugo/pulls/1665/commits","review_comments_url":"https://api.github.com/repos/spf13/hugo/pulls/1665/comments","review_comment_url":"https://api.github.com/repos/spf13/hugo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spf13/hugo/issues/1665/comments","statuses_url":"https://api.github.com/repos/spf13/hugo/statuses/0d51d6a555b555e883e130bb6f6fc74375e73443","head":{"label":"gunnaraasen:menu-link-fix","ref":"menu-link-fix","sha":"0d51d6a555b555e883e130bb6f6fc74375e73443","user":{"login":"gunnaraasen","id":628831,"avatar_url":"https://avatars.githubusercontent.com/u/628831?v=3","gravatar_id":"","url":"https://api.github.com/users/gunnaraasen","html_url":"https://github.com/gunnaraasen","followers_url":"https://api.github.com/users/gunnaraasen/followers","following_url":"https://api.github.com/users/gunnaraasen/following{/other_user}","gists_url":"https://api.github.com/users/gunnaraasen/gists{/gist_id}","starred_url":"https://api.github.com/users/gunnaraasen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunnaraasen/subscriptions","organizations_url":"https://api.github.com/users/gunnaraasen/orgs","repos_url":"https://api.github.com/users/gunnaraasen/repos","events_url":"https://api.github.com/users/gunnaraasen/events{/privacy}","received_events_url":"https://api.github.com/users/gunnaraasen/received_events","type":"User","site_admin":false},"repo":{"id":12600876,"name":"hugo","full_name":"gunnaraasen/hugo","owner":{"login":"gunnaraasen","id":628831,"avatar_url":"https://avatars.githubusercontent.com/u/628831?v=3","gravatar_id":"","url":"https://api.github.com/users/gunnaraasen","html_url":"https://github.com/gunnaraasen","followers_url":"https://api.github.com/users/gunnaraasen/followers","following_url":"https://api.github.com/users/gunnaraasen/following{/other_user}","gists_url":"https://api.github.com/users/gunnaraasen/gists{/gist_id}","starred_url":"https://api.github.com/users/gunnaraasen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunnaraasen/subscriptions","organizations_url":"https://api.github.com/users/gunnaraasen/orgs","repos_url":"https://api.github.com/users/gunnaraasen/repos","events_url":"https://api.github.com/users/gunnaraasen/events{/privacy}","received_events_url":"https://api.github.com/users/gunnaraasen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gunnaraasen/hugo","description":"A Fast and Flexible Static Site Generator built with love by spf13 in GoLang","fork":true,"url":"https://api.github.com/repos/gunnaraasen/hugo","forks_url":"https://api.github.com/repos/gunnaraasen/hugo/forks","keys_url":"https://api.github.com/repos/gunnaraasen/hugo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gunnaraasen/hugo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gunnaraasen/hugo/teams","hooks_url":"https://api.github.com/repos/gunnaraasen/hugo/hooks","issue_events_url":"https://api.github.com/repos/gunnaraasen/hugo/issues/events{/number}","events_url":"https://api.github.com/repos/gunnaraasen/hugo/events","assignees_url":"https://api.github.com/repos/gunnaraasen/hugo/assignees{/user}","branches_url":"https://api.github.com/repos/gunnaraasen/hugo/branches{/branch}","tags_url":"https://api.github.com/repos/gunnaraasen/hugo/tags","blobs_url":"https://api.github.com/repos/gunnaraasen/hugo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gunnaraasen/hugo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gunnaraasen/hugo/git/refs{/sha}","trees_url":"https://api.github.com/repos/gunnaraasen/hugo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gunnaraasen/hugo/statuses/{sha}","languages_url":"https://api.github.com/repos/gunnaraasen/hugo/languages","stargazers_url":"https://api.github.com/repos/gunnaraasen/hugo/stargazers","contributors_url":"https://api.github.com/repos/gunnaraasen/hugo/contributors","subscribers_url":"https://api.github.com/repos/gunnaraasen/hugo/subscribers","subscription_url":"https://api.github.com/repos/gunnaraasen/hugo/subscription","commits_url":"https://api.github.com/repos/gunnaraasen/hugo/commits{/sha}","git_commits_url":"https://api.github.com/repos/gunnaraasen/hugo/git/commits{/sha}","comments_url":"https://api.github.com/repos/gunnaraasen/hugo/comments{/number}","issue_comment_url":"https://api.github.com/repos/gunnaraasen/hugo/issues/comments{/number}","contents_url":"https://api.github.com/repos/gunnaraasen/hugo/contents/{+path}","compare_url":"https://api.github.com/repos/gunnaraasen/hugo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gunnaraasen/hugo/merges","archive_url":"https://api.github.com/repos/gunnaraasen/hugo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gunnaraasen/hugo/downloads","issues_url":"https://api.github.com/repos/gunnaraasen/hugo/issues{/number}","pulls_url":"https://api.github.com/repos/gunnaraasen/hugo/pulls{/number}","milestones_url":"https://api.github.com/repos/gunnaraasen/hugo/milestones{/number}","notifications_url":"https://api.github.com/repos/gunnaraasen/hugo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gunnaraasen/hugo/labels{/name}","releases_url":"https://api.github.com/repos/gunnaraasen/hugo/releases{/id}","created_at":"2013-09-04T20:05:51Z","updated_at":"2015-02-11T02:24:42Z","pushed_at":"2015-12-02T23:00:37Z","git_url":"git://github.com/gunnaraasen/hugo.git","ssh_url":"git@github.com:gunnaraasen/hugo.git","clone_url":"https://github.com/gunnaraasen/hugo.git","svn_url":"https://github.com/gunnaraasen/hugo","homepage":"http://hugo.spf13.com","size":22778,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spf13:master","ref":"master","sha":"df85e5a0aa03053f7ddfe6ebf8605e52024b1f15","user":{"login":"spf13","id":173412,"avatar_url":"https://avatars.githubusercontent.com/u/173412?v=3","gravatar_id":"","url":"https://api.github.com/users/spf13","html_url":"https://github.com/spf13","followers_url":"https://api.github.com/users/spf13/followers","following_url":"https://api.github.com/users/spf13/following{/other_user}","gists_url":"https://api.github.com/users/spf13/gists{/gist_id}","starred_url":"https://api.github.com/users/spf13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spf13/subscriptions","organizations_url":"https://api.github.com/users/spf13/orgs","repos_url":"https://api.github.com/users/spf13/repos","events_url":"https://api.github.com/users/spf13/events{/privacy}","received_events_url":"https://api.github.com/users/spf13/received_events","type":"User","site_admin":false},"repo":{"id":11180687,"name":"hugo","full_name":"spf13/hugo","owner":{"login":"spf13","id":173412,"avatar_url":"https://avatars.githubusercontent.com/u/173412?v=3","gravatar_id":"","url":"https://api.github.com/users/spf13","html_url":"https://github.com/spf13","followers_url":"https://api.github.com/users/spf13/followers","following_url":"https://api.github.com/users/spf13/following{/other_user}","gists_url":"https://api.github.com/users/spf13/gists{/gist_id}","starred_url":"https://api.github.com/users/spf13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spf13/subscriptions","organizations_url":"https://api.github.com/users/spf13/orgs","repos_url":"https://api.github.com/users/spf13/repos","events_url":"https://api.github.com/users/spf13/events{/privacy}","received_events_url":"https://api.github.com/users/spf13/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spf13/hugo","description":"A Fast and Flexible Static Site Generator built with love by spf13 in GoLang","fork":false,"url":"https://api.github.com/repos/spf13/hugo","forks_url":"https://api.github.com/repos/spf13/hugo/forks","keys_url":"https://api.github.com/repos/spf13/hugo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spf13/hugo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spf13/hugo/teams","hooks_url":"https://api.github.com/repos/spf13/hugo/hooks","issue_events_url":"https://api.github.com/repos/spf13/hugo/issues/events{/number}","events_url":"https://api.github.com/repos/spf13/hugo/events","assignees_url":"https://api.github.com/repos/spf13/hugo/assignees{/user}","branches_url":"https://api.github.com/repos/spf13/hugo/branches{/branch}","tags_url":"https://api.github.com/repos/spf13/hugo/tags","blobs_url":"https://api.github.com/repos/spf13/hugo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spf13/hugo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spf13/hugo/git/refs{/sha}","trees_url":"https://api.github.com/repos/spf13/hugo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spf13/hugo/statuses/{sha}","languages_url":"https://api.github.com/repos/spf13/hugo/languages","stargazers_url":"https://api.github.com/repos/spf13/hugo/stargazers","contributors_url":"https://api.github.com/repos/spf13/hugo/contributors","subscribers_url":"https://api.github.com/repos/spf13/hugo/subscribers","subscription_url":"https://api.github.com/repos/spf13/hugo/subscription","commits_url":"https://api.github.com/repos/spf13/hugo/commits{/sha}","git_commits_url":"https://api.github.com/repos/spf13/hugo/git/commits{/sha}","comments_url":"https://api.github.com/repos/spf13/hugo/comments{/number}","issue_comment_url":"https://api.github.com/repos/spf13/hugo/issues/comments{/number}","contents_url":"https://api.github.com/repos/spf13/hugo/contents/{+path}","compare_url":"https://api.github.com/repos/spf13/hugo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spf13/hugo/merges","archive_url":"https://api.github.com/repos/spf13/hugo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spf13/hugo/downloads","issues_url":"https://api.github.com/repos/spf13/hugo/issues{/number}","pulls_url":"https://api.github.com/repos/spf13/hugo/pulls{/number}","milestones_url":"https://api.github.com/repos/spf13/hugo/milestones{/number}","notifications_url":"https://api.github.com/repos/spf13/hugo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spf13/hugo/labels{/name}","releases_url":"https://api.github.com/repos/spf13/hugo/releases{/id}","created_at":"2013-07-04T15:26:26Z","updated_at":"2015-12-06T14:13:10Z","pushed_at":"2015-12-06T14:25:47Z","git_url":"git://github.com/spf13/hugo.git","ssh_url":"git@github.com:spf13/hugo.git","clone_url":"https://github.com/spf13/hugo.git","svn_url":"https://github.com/spf13/hugo","homepage":"http://gohugo.io","size":29543,"stargazers_count":7337,"watchers_count":7337,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1136,"mirror_url":null,"open_issues_count":243,"forks":1136,"open_issues":243,"watchers":7337,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spf13/hugo/pulls/1665"},"html":{"href":"https://github.com/spf13/hugo/pull/1665"},"issue":{"href":"https://api.github.com/repos/spf13/hugo/issues/1665"},"comments":{"href":"https://api.github.com/repos/spf13/hugo/issues/1665/comments"},"review_comments":{"href":"https://api.github.com/repos/spf13/hugo/pulls/1665/comments"},"review_comment":{"href":"https://api.github.com/repos/spf13/hugo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spf13/hugo/pulls/1665/commits"},"statuses":{"href":"https://api.github.com/repos/spf13/hugo/statuses/0d51d6a555b555e883e130bb6f6fc74375e73443"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":5,"review_comments":0,"commits":1,"additions":12,"deletions":19,"changed_files":2}}