{"action":"closed","number":1632,"pull_request":{"url":"https://api.github.com/repos/coreos/rkt/pulls/1632","id":48093570,"html_url":"https://github.com/coreos/rkt/pull/1632","diff_url":"https://github.com/coreos/rkt/pull/1632.diff","patch_url":"https://github.com/coreos/rkt/pull/1632.patch","issue_url":"https://api.github.com/repos/coreos/rkt/issues/1632","number":1632,"state":"closed","locked":false,"title":"build: Rename variables used in usr_from_*, rework ACI manifest generation","user":{"login":"krnowak","id":96081,"avatar_url":"https://avatars.githubusercontent.com/u/96081?v=3","gravatar_id":"","url":"https://api.github.com/users/krnowak","html_url":"https://github.com/krnowak","followers_url":"https://api.github.com/users/krnowak/followers","following_url":"https://api.github.com/users/krnowak/following{/other_user}","gists_url":"https://api.github.com/users/krnowak/gists{/gist_id}","starred_url":"https://api.github.com/users/krnowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krnowak/subscriptions","organizations_url":"https://api.github.com/users/krnowak/orgs","repos_url":"https://api.github.com/users/krnowak/repos","events_url":"https://api.github.com/users/krnowak/events{/privacy}","received_events_url":"https://api.github.com/users/krnowak/received_events","type":"User","site_admin":false},"body":"Instead of using global variables (like ACIROOTFSDIR or STAGE1_USR_STAMPS) we start using local ones (S1_RF_ACIROOTFSDIR or S1_RF_USR_STAMPS). This now makes no difference, but later each flavor will have its own set of variables which will be accessible under these convenience names.\r\n\r\nAlso, move ACI manifest generation from configure to make. configure was convenient when we had only one manifest to generate, but later we will have to have it generated for each flavor we build.\r\n\r\nOn top of that, use manifest to point rkt to proper binary for kvm flavor instead of using some pointer gimmicks.","created_at":"2015-10-19T16:19:33Z","updated_at":"2015-10-20T08:49:14Z","closed_at":"2015-10-20T08:49:14Z","merged_at":"2015-10-20T08:49:14Z","merge_commit_sha":"988b7d172ca40beddeae4d5b5679e3ede87bce59","assignee":null,"milestone":{"url":"https://api.github.com/repos/coreos/rkt/milestones/21","html_url":"https://github.com/coreos/rkt/milestones/v0.10.0","labels_url":"https://api.github.com/repos/coreos/rkt/milestones/21/labels","id":1335294,"number":21,"title":"v0.10.0","description":"","creator":{"login":"jonboulle","id":2601015,"avatar_url":"https://avatars.githubusercontent.com/u/2601015?v=3","gravatar_id":"","url":"https://api.github.com/users/jonboulle","html_url":"https://github.com/jonboulle","followers_url":"https://api.github.com/users/jonboulle/followers","following_url":"https://api.github.com/users/jonboulle/following{/other_user}","gists_url":"https://api.github.com/users/jonboulle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboulle/subscriptions","organizations_url":"https://api.github.com/users/jonboulle/orgs","repos_url":"https://api.github.com/users/jonboulle/repos","events_url":"https://api.github.com/users/jonboulle/events{/privacy}","received_events_url":"https://api.github.com/users/jonboulle/received_events","type":"User","site_admin":false},"open_issues":68,"closed_issues":42,"state":"open","created_at":"2015-10-02T17:41:16Z","updated_at":"2015-10-20T08:49:14Z","due_on":"2015-10-21T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/coreos/rkt/pulls/1632/commits","review_comments_url":"https://api.github.com/repos/coreos/rkt/pulls/1632/comments","review_comment_url":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/rkt/issues/1632/comments","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/58a101c3f2be360ba4734d407c944ba5bd86c534","head":{"label":"krnowak:ms-2nd-batch","ref":"ms-2nd-batch","sha":"58a101c3f2be360ba4734d407c944ba5bd86c534","user":{"login":"krnowak","id":96081,"avatar_url":"https://avatars.githubusercontent.com/u/96081?v=3","gravatar_id":"","url":"https://api.github.com/users/krnowak","html_url":"https://github.com/krnowak","followers_url":"https://api.github.com/users/krnowak/followers","following_url":"https://api.github.com/users/krnowak/following{/other_user}","gists_url":"https://api.github.com/users/krnowak/gists{/gist_id}","starred_url":"https://api.github.com/users/krnowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krnowak/subscriptions","organizations_url":"https://api.github.com/users/krnowak/orgs","repos_url":"https://api.github.com/users/krnowak/repos","events_url":"https://api.github.com/users/krnowak/events{/privacy}","received_events_url":"https://api.github.com/users/krnowak/received_events","type":"User","site_admin":false},"repo":{"id":42509725,"name":"rkt","full_name":"krnowak/rkt","owner":{"login":"krnowak","id":96081,"avatar_url":"https://avatars.githubusercontent.com/u/96081?v=3","gravatar_id":"","url":"https://api.github.com/users/krnowak","html_url":"https://github.com/krnowak","followers_url":"https://api.github.com/users/krnowak/followers","following_url":"https://api.github.com/users/krnowak/following{/other_user}","gists_url":"https://api.github.com/users/krnowak/gists{/gist_id}","starred_url":"https://api.github.com/users/krnowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krnowak/subscriptions","organizations_url":"https://api.github.com/users/krnowak/orgs","repos_url":"https://api.github.com/users/krnowak/repos","events_url":"https://api.github.com/users/krnowak/events{/privacy}","received_events_url":"https://api.github.com/users/krnowak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krnowak/rkt","description":"rkt is an App Container runtime for Linux","fork":true,"url":"https://api.github.com/repos/krnowak/rkt","forks_url":"https://api.github.com/repos/krnowak/rkt/forks","keys_url":"https://api.github.com/repos/krnowak/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krnowak/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krnowak/rkt/teams","hooks_url":"https://api.github.com/repos/krnowak/rkt/hooks","issue_events_url":"https://api.github.com/repos/krnowak/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/krnowak/rkt/events","assignees_url":"https://api.github.com/repos/krnowak/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/krnowak/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/krnowak/rkt/tags","blobs_url":"https://api.github.com/repos/krnowak/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krnowak/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krnowak/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/krnowak/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krnowak/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/krnowak/rkt/languages","stargazers_url":"https://api.github.com/repos/krnowak/rkt/stargazers","contributors_url":"https://api.github.com/repos/krnowak/rkt/contributors","subscribers_url":"https://api.github.com/repos/krnowak/rkt/subscribers","subscription_url":"https://api.github.com/repos/krnowak/rkt/subscription","commits_url":"https://api.github.com/repos/krnowak/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/krnowak/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/krnowak/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/krnowak/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/krnowak/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/krnowak/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krnowak/rkt/merges","archive_url":"https://api.github.com/repos/krnowak/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krnowak/rkt/downloads","issues_url":"https://api.github.com/repos/krnowak/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/krnowak/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/krnowak/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/krnowak/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krnowak/rkt/labels{/name}","releases_url":"https://api.github.com/repos/krnowak/rkt/releases{/id}","created_at":"2015-09-15T09:54:51Z","updated_at":"2015-09-15T09:54:52Z","pushed_at":"2015-10-19T18:12:38Z","git_url":"git://github.com/krnowak/rkt.git","ssh_url":"git@github.com:krnowak/rkt.git","clone_url":"https://github.com/krnowak/rkt.git","svn_url":"https://github.com/krnowak/rkt","homepage":"","size":17082,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"542859f52e30af77a2dfb7706db62248616d3f3e","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":26509369,"name":"rkt","full_name":"coreos/rkt","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/rkt","description":"rkt is an App Container runtime for Linux","fork":false,"url":"https://api.github.com/repos/coreos/rkt","forks_url":"https://api.github.com/repos/coreos/rkt/forks","keys_url":"https://api.github.com/repos/coreos/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/rkt/teams","hooks_url":"https://api.github.com/repos/coreos/rkt/hooks","issue_events_url":"https://api.github.com/repos/coreos/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/rkt/events","assignees_url":"https://api.github.com/repos/coreos/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/rkt/tags","blobs_url":"https://api.github.com/repos/coreos/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/rkt/languages","stargazers_url":"https://api.github.com/repos/coreos/rkt/stargazers","contributors_url":"https://api.github.com/repos/coreos/rkt/contributors","subscribers_url":"https://api.github.com/repos/coreos/rkt/subscribers","subscription_url":"https://api.github.com/repos/coreos/rkt/subscription","commits_url":"https://api.github.com/repos/coreos/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/rkt/merges","archive_url":"https://api.github.com/repos/coreos/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/rkt/downloads","issues_url":"https://api.github.com/repos/coreos/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/rkt/labels{/name}","releases_url":"https://api.github.com/repos/coreos/rkt/releases{/id}","created_at":"2014-11-11T23:13:18Z","updated_at":"2015-10-20T08:06:39Z","pushed_at":"2015-10-20T08:49:14Z","git_url":"git://github.com/coreos/rkt.git","ssh_url":"git@github.com:coreos/rkt.git","clone_url":"https://github.com/coreos/rkt.git","svn_url":"https://github.com/coreos/rkt","homepage":"","size":27720,"stargazers_count":4764,"watchers_count":4764,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":400,"mirror_url":null,"open_issues_count":190,"forks":400,"open_issues":190,"watchers":4764,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/1632"},"html":{"href":"https://github.com/coreos/rkt/pull/1632"},"issue":{"href":"https://api.github.com/repos/coreos/rkt/issues/1632"},"comments":{"href":"https://api.github.com/repos/coreos/rkt/issues/1632/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/rkt/pulls/1632/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/rkt/pulls/1632/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/rkt/statuses/58a101c3f2be360ba4734d407c944ba5bd86c534"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"iaguis","id":507354,"avatar_url":"https://avatars.githubusercontent.com/u/507354?v=3","gravatar_id":"","url":"https://api.github.com/users/iaguis","html_url":"https://github.com/iaguis","followers_url":"https://api.github.com/users/iaguis/followers","following_url":"https://api.github.com/users/iaguis/following{/other_user}","gists_url":"https://api.github.com/users/iaguis/gists{/gist_id}","starred_url":"https://api.github.com/users/iaguis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iaguis/subscriptions","organizations_url":"https://api.github.com/users/iaguis/orgs","repos_url":"https://api.github.com/users/iaguis/repos","events_url":"https://api.github.com/users/iaguis/events{/privacy}","received_events_url":"https://api.github.com/users/iaguis/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":7,"additions":129,"deletions":77,"changed_files":17}}