{"action":"created","comment":{"url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/comments/40633064","id":40633064,"diff_hunk":"@@ -636,7 +636,7 @@ def sources\n       def verify_platforms_specified!\n         unless config.integrate_targets?\n           podfile.target_definition_list.each do |target_definition|\n-            unless target_definition.platform\n+            if target_definition.dependencies.size > 0 && target_definition.platform.nil?","path":"lib/cocoapods/installer/analyzer.rb","position":14,"original_position":14,"commit_id":"3819d532c0f06990e1c56634f17fb00c204d1502","original_commit_id":"3819d532c0f06990e1c56634f17fb00c204d1502","user":{"login":"sguillope","id":2593278,"avatar_url":"https://avatars.githubusercontent.com/u/2593278?v=3","gravatar_id":"","url":"https://api.github.com/users/sguillope","html_url":"https://github.com/sguillope","followers_url":"https://api.github.com/users/sguillope/followers","following_url":"https://api.github.com/users/sguillope/following{/other_user}","gists_url":"https://api.github.com/users/sguillope/gists{/gist_id}","starred_url":"https://api.github.com/users/sguillope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sguillope/subscriptions","organizations_url":"https://api.github.com/users/sguillope/orgs","repos_url":"https://api.github.com/users/sguillope/repos","events_url":"https://api.github.com/users/sguillope/events{/privacy}","received_events_url":"https://api.github.com/users/sguillope/received_events","type":"User","site_admin":false},"body":"@segiddins is it correct to exclude inherited dependencies in the check?\r\nIf have a `Podfile` like:\r\n```ruby\r\nplatform :ios\r\npod 'InheritedPod'\r\ntarget 'osx' do\r\n  # empty\r\nend\r\n```\r\nshould the `osx` target fail the platform validation?","created_at":"2015-09-29T04:08:20Z","updated_at":"2015-09-29T04:08:20Z","html_url":"https://github.com/CocoaPods/CocoaPods/pull/4281#discussion_r40633064","pull_request_url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/4281","_links":{"self":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/comments/40633064"},"html":{"href":"https://github.com/CocoaPods/CocoaPods/pull/4281#discussion_r40633064"},"pull_request":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/4281"}}},"pull_request":{"url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/4281","id":46229277,"html_url":"https://github.com/CocoaPods/CocoaPods/pull/4281","diff_url":"https://github.com/CocoaPods/CocoaPods/pull/4281.diff","patch_url":"https://github.com/CocoaPods/CocoaPods/pull/4281.patch","issue_url":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/4281","number":4281,"state":"open","locked":false,"title":"[Analyzer] Don't require platform for podless targets when not integrating","user":{"login":"sguillope","id":2593278,"avatar_url":"https://avatars.githubusercontent.com/u/2593278?v=3","gravatar_id":"","url":"https://api.github.com/users/sguillope","html_url":"https://github.com/sguillope","followers_url":"https://api.github.com/users/sguillope/followers","following_url":"https://api.github.com/users/sguillope/following{/other_user}","gists_url":"https://api.github.com/users/sguillope/gists{/gist_id}","starred_url":"https://api.github.com/users/sguillope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sguillope/subscriptions","organizations_url":"https://api.github.com/users/sguillope/orgs","repos_url":"https://api.github.com/users/sguillope/repos","events_url":"https://api.github.com/users/sguillope/events{/privacy}","received_events_url":"https://api.github.com/users/sguillope/received_events","type":"User","site_admin":false},"body":"When running `pod install --no-integrate`, it's not required to validate that the `platform` attribute is specified for targets that don't declare any dependencies.","created_at":"2015-09-29T02:01:11Z","updated_at":"2015-09-29T04:08:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd7de0b4df90e922ff23722b0ac66658bf57ab4f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/4281/commits","review_comments_url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/4281/comments","review_comment_url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/4281/comments","statuses_url":"https://api.github.com/repos/CocoaPods/CocoaPods/statuses/3819d532c0f06990e1c56634f17fb00c204d1502","head":{"label":"sguillope:bugfix/no-integrate-skip-platform-check-for-podless-target","ref":"bugfix/no-integrate-skip-platform-check-for-podless-target","sha":"3819d532c0f06990e1c56634f17fb00c204d1502","user":{"login":"sguillope","id":2593278,"avatar_url":"https://avatars.githubusercontent.com/u/2593278?v=3","gravatar_id":"","url":"https://api.github.com/users/sguillope","html_url":"https://github.com/sguillope","followers_url":"https://api.github.com/users/sguillope/followers","following_url":"https://api.github.com/users/sguillope/following{/other_user}","gists_url":"https://api.github.com/users/sguillope/gists{/gist_id}","starred_url":"https://api.github.com/users/sguillope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sguillope/subscriptions","organizations_url":"https://api.github.com/users/sguillope/orgs","repos_url":"https://api.github.com/users/sguillope/repos","events_url":"https://api.github.com/users/sguillope/events{/privacy}","received_events_url":"https://api.github.com/users/sguillope/received_events","type":"User","site_admin":false},"repo":{"id":43261137,"name":"CocoaPods","full_name":"sguillope/CocoaPods","owner":{"login":"sguillope","id":2593278,"avatar_url":"https://avatars.githubusercontent.com/u/2593278?v=3","gravatar_id":"","url":"https://api.github.com/users/sguillope","html_url":"https://github.com/sguillope","followers_url":"https://api.github.com/users/sguillope/followers","following_url":"https://api.github.com/users/sguillope/following{/other_user}","gists_url":"https://api.github.com/users/sguillope/gists{/gist_id}","starred_url":"https://api.github.com/users/sguillope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sguillope/subscriptions","organizations_url":"https://api.github.com/users/sguillope/orgs","repos_url":"https://api.github.com/users/sguillope/repos","events_url":"https://api.github.com/users/sguillope/events{/privacy}","received_events_url":"https://api.github.com/users/sguillope/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sguillope/CocoaPods","description":"The Cocoa Dependency Manager.","fork":true,"url":"https://api.github.com/repos/sguillope/CocoaPods","forks_url":"https://api.github.com/repos/sguillope/CocoaPods/forks","keys_url":"https://api.github.com/repos/sguillope/CocoaPods/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sguillope/CocoaPods/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sguillope/CocoaPods/teams","hooks_url":"https://api.github.com/repos/sguillope/CocoaPods/hooks","issue_events_url":"https://api.github.com/repos/sguillope/CocoaPods/issues/events{/number}","events_url":"https://api.github.com/repos/sguillope/CocoaPods/events","assignees_url":"https://api.github.com/repos/sguillope/CocoaPods/assignees{/user}","branches_url":"https://api.github.com/repos/sguillope/CocoaPods/branches{/branch}","tags_url":"https://api.github.com/repos/sguillope/CocoaPods/tags","blobs_url":"https://api.github.com/repos/sguillope/CocoaPods/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sguillope/CocoaPods/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sguillope/CocoaPods/git/refs{/sha}","trees_url":"https://api.github.com/repos/sguillope/CocoaPods/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sguillope/CocoaPods/statuses/{sha}","languages_url":"https://api.github.com/repos/sguillope/CocoaPods/languages","stargazers_url":"https://api.github.com/repos/sguillope/CocoaPods/stargazers","contributors_url":"https://api.github.com/repos/sguillope/CocoaPods/contributors","subscribers_url":"https://api.github.com/repos/sguillope/CocoaPods/subscribers","subscription_url":"https://api.github.com/repos/sguillope/CocoaPods/subscription","commits_url":"https://api.github.com/repos/sguillope/CocoaPods/commits{/sha}","git_commits_url":"https://api.github.com/repos/sguillope/CocoaPods/git/commits{/sha}","comments_url":"https://api.github.com/repos/sguillope/CocoaPods/comments{/number}","issue_comment_url":"https://api.github.com/repos/sguillope/CocoaPods/issues/comments{/number}","contents_url":"https://api.github.com/repos/sguillope/CocoaPods/contents/{+path}","compare_url":"https://api.github.com/repos/sguillope/CocoaPods/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sguillope/CocoaPods/merges","archive_url":"https://api.github.com/repos/sguillope/CocoaPods/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sguillope/CocoaPods/downloads","issues_url":"https://api.github.com/repos/sguillope/CocoaPods/issues{/number}","pulls_url":"https://api.github.com/repos/sguillope/CocoaPods/pulls{/number}","milestones_url":"https://api.github.com/repos/sguillope/CocoaPods/milestones{/number}","notifications_url":"https://api.github.com/repos/sguillope/CocoaPods/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sguillope/CocoaPods/labels{/name}","releases_url":"https://api.github.com/repos/sguillope/CocoaPods/releases{/id}","created_at":"2015-09-27T19:23:27Z","updated_at":"2015-09-27T19:23:31Z","pushed_at":"2015-09-29T02:11:57Z","git_url":"git://github.com/sguillope/CocoaPods.git","ssh_url":"git@github.com:sguillope/CocoaPods.git","clone_url":"https://github.com/sguillope/CocoaPods.git","svn_url":"https://github.com/sguillope/CocoaPods","homepage":"cocoapods.org","size":73247,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CocoaPods:master","ref":"master","sha":"691e3de4405a0b7174ccd9ca85912a045d286aa2","user":{"login":"CocoaPods","id":1189714,"avatar_url":"https://avatars.githubusercontent.com/u/1189714?v=3","gravatar_id":"","url":"https://api.github.com/users/CocoaPods","html_url":"https://github.com/CocoaPods","followers_url":"https://api.github.com/users/CocoaPods/followers","following_url":"https://api.github.com/users/CocoaPods/following{/other_user}","gists_url":"https://api.github.com/users/CocoaPods/gists{/gist_id}","starred_url":"https://api.github.com/users/CocoaPods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CocoaPods/subscriptions","organizations_url":"https://api.github.com/users/CocoaPods/orgs","repos_url":"https://api.github.com/users/CocoaPods/repos","events_url":"https://api.github.com/users/CocoaPods/events{/privacy}","received_events_url":"https://api.github.com/users/CocoaPods/received_events","type":"Organization","site_admin":false},"repo":{"id":2203645,"name":"CocoaPods","full_name":"CocoaPods/CocoaPods","owner":{"login":"CocoaPods","id":1189714,"avatar_url":"https://avatars.githubusercontent.com/u/1189714?v=3","gravatar_id":"","url":"https://api.github.com/users/CocoaPods","html_url":"https://github.com/CocoaPods","followers_url":"https://api.github.com/users/CocoaPods/followers","following_url":"https://api.github.com/users/CocoaPods/following{/other_user}","gists_url":"https://api.github.com/users/CocoaPods/gists{/gist_id}","starred_url":"https://api.github.com/users/CocoaPods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CocoaPods/subscriptions","organizations_url":"https://api.github.com/users/CocoaPods/orgs","repos_url":"https://api.github.com/users/CocoaPods/repos","events_url":"https://api.github.com/users/CocoaPods/events{/privacy}","received_events_url":"https://api.github.com/users/CocoaPods/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CocoaPods/CocoaPods","description":"The Cocoa Dependency Manager.","fork":false,"url":"https://api.github.com/repos/CocoaPods/CocoaPods","forks_url":"https://api.github.com/repos/CocoaPods/CocoaPods/forks","keys_url":"https://api.github.com/repos/CocoaPods/CocoaPods/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CocoaPods/CocoaPods/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CocoaPods/CocoaPods/teams","hooks_url":"https://api.github.com/repos/CocoaPods/CocoaPods/hooks","issue_events_url":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/events{/number}","events_url":"https://api.github.com/repos/CocoaPods/CocoaPods/events","assignees_url":"https://api.github.com/repos/CocoaPods/CocoaPods/assignees{/user}","branches_url":"https://api.github.com/repos/CocoaPods/CocoaPods/branches{/branch}","tags_url":"https://api.github.com/repos/CocoaPods/CocoaPods/tags","blobs_url":"https://api.github.com/repos/CocoaPods/CocoaPods/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CocoaPods/CocoaPods/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CocoaPods/CocoaPods/git/refs{/sha}","trees_url":"https://api.github.com/repos/CocoaPods/CocoaPods/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CocoaPods/CocoaPods/statuses/{sha}","languages_url":"https://api.github.com/repos/CocoaPods/CocoaPods/languages","stargazers_url":"https://api.github.com/repos/CocoaPods/CocoaPods/stargazers","contributors_url":"https://api.github.com/repos/CocoaPods/CocoaPods/contributors","subscribers_url":"https://api.github.com/repos/CocoaPods/CocoaPods/subscribers","subscription_url":"https://api.github.com/repos/CocoaPods/CocoaPods/subscription","commits_url":"https://api.github.com/repos/CocoaPods/CocoaPods/commits{/sha}","git_commits_url":"https://api.github.com/repos/CocoaPods/CocoaPods/git/commits{/sha}","comments_url":"https://api.github.com/repos/CocoaPods/CocoaPods/comments{/number}","issue_comment_url":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/comments{/number}","contents_url":"https://api.github.com/repos/CocoaPods/CocoaPods/contents/{+path}","compare_url":"https://api.github.com/repos/CocoaPods/CocoaPods/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CocoaPods/CocoaPods/merges","archive_url":"https://api.github.com/repos/CocoaPods/CocoaPods/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CocoaPods/CocoaPods/downloads","issues_url":"https://api.github.com/repos/CocoaPods/CocoaPods/issues{/number}","pulls_url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls{/number}","milestones_url":"https://api.github.com/repos/CocoaPods/CocoaPods/milestones{/number}","notifications_url":"https://api.github.com/repos/CocoaPods/CocoaPods/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CocoaPods/CocoaPods/labels{/name}","releases_url":"https://api.github.com/repos/CocoaPods/CocoaPods/releases{/id}","created_at":"2011-08-14T00:10:53Z","updated_at":"2015-09-29T02:36:21Z","pushed_at":"2015-09-29T02:11:58Z","git_url":"git://github.com/CocoaPods/CocoaPods.git","ssh_url":"git@github.com:CocoaPods/CocoaPods.git","clone_url":"https://github.com/CocoaPods/CocoaPods.git","svn_url":"https://github.com/CocoaPods/CocoaPods","homepage":"https://cocoapods.org","size":73247,"stargazers_count":6418,"watchers_count":6418,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1198,"mirror_url":null,"open_issues_count":199,"forks":1198,"open_issues":199,"watchers":6418,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/4281"},"html":{"href":"https://github.com/CocoaPods/CocoaPods/pull/4281"},"issue":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/4281"},"comments":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/4281/comments"},"review_comments":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/4281/comments"},"review_comment":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/4281/commits"},"statuses":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/statuses/3819d532c0f06990e1c56634f17fb00c204d1502"}}}}