{"action":"created","issue":{"url":"https://api.github.com/repos/hmrc/url-builder/issues/5","labels_url":"https://api.github.com/repos/hmrc/url-builder/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/hmrc/url-builder/issues/5/comments","events_url":"https://api.github.com/repos/hmrc/url-builder/issues/5/events","html_url":"https://github.com/hmrc/url-builder/issues/5","id":63984002,"number":5,"title":"alternate class for hiddenInfo","user":{"login":"benaveryee","id":11385498,"avatar_url":"https://avatars.githubusercontent.com/u/11385498?v=3","gravatar_id":"","url":"https://api.github.com/users/benaveryee","html_url":"https://github.com/benaveryee","followers_url":"https://api.github.com/users/benaveryee/followers","following_url":"https://api.github.com/users/benaveryee/following{/other_user}","gists_url":"https://api.github.com/users/benaveryee/gists{/gist_id}","starred_url":"https://api.github.com/users/benaveryee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benaveryee/subscriptions","organizations_url":"https://api.github.com/users/benaveryee/orgs","repos_url":"https://api.github.com/users/benaveryee/repos","events_url":"https://api.github.com/users/benaveryee/events{/privacy}","received_events_url":"https://api.github.com/users/benaveryee/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-24T12:27:03Z","updated_at":"2015-03-24T12:40:58Z","closed_at":null,"body":"hiddenInfo uses a hard-coded class, 'hidden', to put additional content in the link text. In assets-frontend, this class hides text from both browsers and screen readers. But there is also a 'visuallyhidden' class, which allows screen readers to read the text. This is a common use case, for example to warn that links will open in a new browser tab (which might be shown by an external link icon, not shown in screen readers).\r\nso an optional parameter to hiddenInfo, of the class name, would solve this, and mean we could use url-builder for these links in YTA."},"comment":{"url":"https://api.github.com/repos/hmrc/url-builder/issues/comments/85481847","html_url":"https://github.com/hmrc/url-builder/issues/5#issuecomment-85481847","issue_url":"https://api.github.com/repos/hmrc/url-builder/issues/5","id":85481847,"user":{"login":"howyp","id":4593903,"avatar_url":"https://avatars.githubusercontent.com/u/4593903?v=3","gravatar_id":"","url":"https://api.github.com/users/howyp","html_url":"https://github.com/howyp","followers_url":"https://api.github.com/users/howyp/followers","following_url":"https://api.github.com/users/howyp/following{/other_user}","gists_url":"https://api.github.com/users/howyp/gists{/gist_id}","starred_url":"https://api.github.com/users/howyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howyp/subscriptions","organizations_url":"https://api.github.com/users/howyp/orgs","repos_url":"https://api.github.com/users/howyp/repos","events_url":"https://api.github.com/users/howyp/events{/privacy}","received_events_url":"https://api.github.com/users/howyp/received_events","type":"User","site_admin":false},"created_at":"2015-03-24T12:40:58Z","updated_at":"2015-03-24T12:40:58Z","body":"In any event, I think passing class names around in the code is probably not a great abstraction."}}