{"action":"created","comment":{"url":"https://api.github.com/repos/mobile-shell/mosh/pulls/comments/47862163","id":47862163,"diff_hunk":"@@ -502,6 +517,14 @@ static int run_server( const char *desired_ip, const char *desired_port,\n       exit( 1 );\n     }\n \n+    /* set SSH_AUTH_SOCK */\n+    if ( agent.active() ) {\n+      if ( setenv( \"SSH_AUTH_SOCK\", agent.listener_path().c_str(), true ) < 0 ) {\n+\tperror( \"setenv\" );","path":"src/frontend/mosh-server.cc","position":86,"original_position":86,"commit_id":"dfa183d63dd58a1b0cb2c58264c046963159f356","original_commit_id":"dfa183d63dd58a1b0cb2c58264c046963159f356","user":{"login":"daniel-pittman","id":306753,"avatar_url":"https://avatars.githubusercontent.com/u/306753?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-pittman","html_url":"https://github.com/daniel-pittman","followers_url":"https://api.github.com/users/daniel-pittman/followers","following_url":"https://api.github.com/users/daniel-pittman/following{/other_user}","gists_url":"https://api.github.com/users/daniel-pittman/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-pittman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-pittman/subscriptions","organizations_url":"https://api.github.com/users/daniel-pittman/orgs","repos_url":"https://api.github.com/users/daniel-pittman/repos","events_url":"https://api.github.com/users/daniel-pittman/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-pittman/received_events","type":"User","site_admin":false},"body":"given multiple setenv calls, it would be nice to upgrade to `setenv(SSH_AUTH_SOCK)` here, I think, and the corresponding change in, eg, the following perror.","created_at":"2015-12-17T02:15:04Z","updated_at":"2015-12-17T02:15:04Z","html_url":"https://github.com/mobile-shell/mosh/pull/696#discussion_r47862163","pull_request_url":"https://api.github.com/repos/mobile-shell/mosh/pulls/696","_links":{"self":{"href":"https://api.github.com/repos/mobile-shell/mosh/pulls/comments/47862163"},"html":{"href":"https://github.com/mobile-shell/mosh/pull/696#discussion_r47862163"},"pull_request":{"href":"https://api.github.com/repos/mobile-shell/mosh/pulls/696"}}},"pull_request":{"url":"https://api.github.com/repos/mobile-shell/mosh/pulls/696","id":52042755,"html_url":"https://github.com/mobile-shell/mosh/pull/696","diff_url":"https://github.com/mobile-shell/mosh/pull/696.diff","patch_url":"https://github.com/mobile-shell/mosh/pull/696.patch","issue_url":"https://api.github.com/repos/mobile-shell/mosh/issues/696","number":696,"state":"open","locked":false,"title":"SSH agent forwarding patches re-merged as one patch.","user":{"login":"rinne","id":1642944,"avatar_url":"https://avatars.githubusercontent.com/u/1642944?v=3","gravatar_id":"","url":"https://api.github.com/users/rinne","html_url":"https://github.com/rinne","followers_url":"https://api.github.com/users/rinne/followers","following_url":"https://api.github.com/users/rinne/following{/other_user}","gists_url":"https://api.github.com/users/rinne/gists{/gist_id}","starred_url":"https://api.github.com/users/rinne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rinne/subscriptions","organizations_url":"https://api.github.com/users/rinne/orgs","repos_url":"https://api.github.com/users/rinne/repos","events_url":"https://api.github.com/users/rinne/events{/privacy}","received_events_url":"https://api.github.com/users/rinne/received_events","type":"User","site_admin":false},"body":"Hi\r\n\r\nSSH agent forwarding patches re-merged as one patch.\r\n\r\nA couple of superficial conflicts resolved. Tested and working.\r\n\r\nMerged as requested in #583 but since #583 was made by someone else, I decided just to make another PR.\r\n\r\nSigned-off-by: Timo J. Rinne <tri@iki.fi>","created_at":"2015-11-28T15:43:29Z","updated_at":"2015-12-17T02:15:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f27927fa01b96aa38a971baf3c67c19a891469f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mobile-shell/mosh/pulls/696/commits","review_comments_url":"https://api.github.com/repos/mobile-shell/mosh/pulls/696/comments","review_comment_url":"https://api.github.com/repos/mobile-shell/mosh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mobile-shell/mosh/issues/696/comments","statuses_url":"https://api.github.com/repos/mobile-shell/mosh/statuses/dfa183d63dd58a1b0cb2c58264c046963159f356","head":{"label":"rinne:agent-forwarding-merge-20151128","ref":"agent-forwarding-merge-20151128","sha":"dfa183d63dd58a1b0cb2c58264c046963159f356","user":{"login":"rinne","id":1642944,"avatar_url":"https://avatars.githubusercontent.com/u/1642944?v=3","gravatar_id":"","url":"https://api.github.com/users/rinne","html_url":"https://github.com/rinne","followers_url":"https://api.github.com/users/rinne/followers","following_url":"https://api.github.com/users/rinne/following{/other_user}","gists_url":"https://api.github.com/users/rinne/gists{/gist_id}","starred_url":"https://api.github.com/users/rinne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rinne/subscriptions","organizations_url":"https://api.github.com/users/rinne/orgs","repos_url":"https://api.github.com/users/rinne/repos","events_url":"https://api.github.com/users/rinne/events{/privacy}","received_events_url":"https://api.github.com/users/rinne/received_events","type":"User","site_admin":false},"repo":{"id":10029259,"name":"mosh","full_name":"rinne/mosh","owner":{"login":"rinne","id":1642944,"avatar_url":"https://avatars.githubusercontent.com/u/1642944?v=3","gravatar_id":"","url":"https://api.github.com/users/rinne","html_url":"https://github.com/rinne","followers_url":"https://api.github.com/users/rinne/followers","following_url":"https://api.github.com/users/rinne/following{/other_user}","gists_url":"https://api.github.com/users/rinne/gists{/gist_id}","starred_url":"https://api.github.com/users/rinne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rinne/subscriptions","organizations_url":"https://api.github.com/users/rinne/orgs","repos_url":"https://api.github.com/users/rinne/repos","events_url":"https://api.github.com/users/rinne/events{/privacy}","received_events_url":"https://api.github.com/users/rinne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rinne/mosh","description":"Mobile Shell","fork":true,"url":"https://api.github.com/repos/rinne/mosh","forks_url":"https://api.github.com/repos/rinne/mosh/forks","keys_url":"https://api.github.com/repos/rinne/mosh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rinne/mosh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rinne/mosh/teams","hooks_url":"https://api.github.com/repos/rinne/mosh/hooks","issue_events_url":"https://api.github.com/repos/rinne/mosh/issues/events{/number}","events_url":"https://api.github.com/repos/rinne/mosh/events","assignees_url":"https://api.github.com/repos/rinne/mosh/assignees{/user}","branches_url":"https://api.github.com/repos/rinne/mosh/branches{/branch}","tags_url":"https://api.github.com/repos/rinne/mosh/tags","blobs_url":"https://api.github.com/repos/rinne/mosh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rinne/mosh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rinne/mosh/git/refs{/sha}","trees_url":"https://api.github.com/repos/rinne/mosh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rinne/mosh/statuses/{sha}","languages_url":"https://api.github.com/repos/rinne/mosh/languages","stargazers_url":"https://api.github.com/repos/rinne/mosh/stargazers","contributors_url":"https://api.github.com/repos/rinne/mosh/contributors","subscribers_url":"https://api.github.com/repos/rinne/mosh/subscribers","subscription_url":"https://api.github.com/repos/rinne/mosh/subscription","commits_url":"https://api.github.com/repos/rinne/mosh/commits{/sha}","git_commits_url":"https://api.github.com/repos/rinne/mosh/git/commits{/sha}","comments_url":"https://api.github.com/repos/rinne/mosh/comments{/number}","issue_comment_url":"https://api.github.com/repos/rinne/mosh/issues/comments{/number}","contents_url":"https://api.github.com/repos/rinne/mosh/contents/{+path}","compare_url":"https://api.github.com/repos/rinne/mosh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rinne/mosh/merges","archive_url":"https://api.github.com/repos/rinne/mosh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rinne/mosh/downloads","issues_url":"https://api.github.com/repos/rinne/mosh/issues{/number}","pulls_url":"https://api.github.com/repos/rinne/mosh/pulls{/number}","milestones_url":"https://api.github.com/repos/rinne/mosh/milestones{/number}","notifications_url":"https://api.github.com/repos/rinne/mosh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rinne/mosh/labels{/name}","releases_url":"https://api.github.com/repos/rinne/mosh/releases{/id}","created_at":"2013-05-13T10:20:41Z","updated_at":"2015-09-21T16:31:12Z","pushed_at":"2015-11-28T19:10:38Z","git_url":"git://github.com/rinne/mosh.git","ssh_url":"git@github.com:rinne/mosh.git","clone_url":"https://github.com/rinne/mosh.git","svn_url":"https://github.com/rinne/mosh","homepage":"http://mosh.mit.edu","size":2795,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":6,"default_branch":"master"}},"base":{"label":"mobile-shell:master","ref":"master","sha":"b742e958b6ae7185f557263e4b81db0e1038b882","user":{"login":"mobile-shell","id":13547101,"avatar_url":"https://avatars.githubusercontent.com/u/13547101?v=3","gravatar_id":"","url":"https://api.github.com/users/mobile-shell","html_url":"https://github.com/mobile-shell","followers_url":"https://api.github.com/users/mobile-shell/followers","following_url":"https://api.github.com/users/mobile-shell/following{/other_user}","gists_url":"https://api.github.com/users/mobile-shell/gists{/gist_id}","starred_url":"https://api.github.com/users/mobile-shell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobile-shell/subscriptions","organizations_url":"https://api.github.com/users/mobile-shell/orgs","repos_url":"https://api.github.com/users/mobile-shell/repos","events_url":"https://api.github.com/users/mobile-shell/events{/privacy}","received_events_url":"https://api.github.com/users/mobile-shell/received_events","type":"Organization","site_admin":false},"repo":{"id":1234783,"name":"mosh","full_name":"mobile-shell/mosh","owner":{"login":"mobile-shell","id":13547101,"avatar_url":"https://avatars.githubusercontent.com/u/13547101?v=3","gravatar_id":"","url":"https://api.github.com/users/mobile-shell","html_url":"https://github.com/mobile-shell","followers_url":"https://api.github.com/users/mobile-shell/followers","following_url":"https://api.github.com/users/mobile-shell/following{/other_user}","gists_url":"https://api.github.com/users/mobile-shell/gists{/gist_id}","starred_url":"https://api.github.com/users/mobile-shell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobile-shell/subscriptions","organizations_url":"https://api.github.com/users/mobile-shell/orgs","repos_url":"https://api.github.com/users/mobile-shell/repos","events_url":"https://api.github.com/users/mobile-shell/events{/privacy}","received_events_url":"https://api.github.com/users/mobile-shell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mobile-shell/mosh","description":"Mobile Shell","fork":false,"url":"https://api.github.com/repos/mobile-shell/mosh","forks_url":"https://api.github.com/repos/mobile-shell/mosh/forks","keys_url":"https://api.github.com/repos/mobile-shell/mosh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mobile-shell/mosh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mobile-shell/mosh/teams","hooks_url":"https://api.github.com/repos/mobile-shell/mosh/hooks","issue_events_url":"https://api.github.com/repos/mobile-shell/mosh/issues/events{/number}","events_url":"https://api.github.com/repos/mobile-shell/mosh/events","assignees_url":"https://api.github.com/repos/mobile-shell/mosh/assignees{/user}","branches_url":"https://api.github.com/repos/mobile-shell/mosh/branches{/branch}","tags_url":"https://api.github.com/repos/mobile-shell/mosh/tags","blobs_url":"https://api.github.com/repos/mobile-shell/mosh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mobile-shell/mosh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mobile-shell/mosh/git/refs{/sha}","trees_url":"https://api.github.com/repos/mobile-shell/mosh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mobile-shell/mosh/statuses/{sha}","languages_url":"https://api.github.com/repos/mobile-shell/mosh/languages","stargazers_url":"https://api.github.com/repos/mobile-shell/mosh/stargazers","contributors_url":"https://api.github.com/repos/mobile-shell/mosh/contributors","subscribers_url":"https://api.github.com/repos/mobile-shell/mosh/subscribers","subscription_url":"https://api.github.com/repos/mobile-shell/mosh/subscription","commits_url":"https://api.github.com/repos/mobile-shell/mosh/commits{/sha}","git_commits_url":"https://api.github.com/repos/mobile-shell/mosh/git/commits{/sha}","comments_url":"https://api.github.com/repos/mobile-shell/mosh/comments{/number}","issue_comment_url":"https://api.github.com/repos/mobile-shell/mosh/issues/comments{/number}","contents_url":"https://api.github.com/repos/mobile-shell/mosh/contents/{+path}","compare_url":"https://api.github.com/repos/mobile-shell/mosh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mobile-shell/mosh/merges","archive_url":"https://api.github.com/repos/mobile-shell/mosh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mobile-shell/mosh/downloads","issues_url":"https://api.github.com/repos/mobile-shell/mosh/issues{/number}","pulls_url":"https://api.github.com/repos/mobile-shell/mosh/pulls{/number}","milestones_url":"https://api.github.com/repos/mobile-shell/mosh/milestones{/number}","notifications_url":"https://api.github.com/repos/mobile-shell/mosh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mobile-shell/mosh/labels{/name}","releases_url":"https://api.github.com/repos/mobile-shell/mosh/releases{/id}","created_at":"2011-01-09T09:41:02Z","updated_at":"2015-12-16T21:15:45Z","pushed_at":"2015-12-07T05:29:03Z","git_url":"git://github.com/mobile-shell/mosh.git","ssh_url":"git@github.com:mobile-shell/mosh.git","clone_url":"https://github.com/mobile-shell/mosh.git","svn_url":"https://github.com/mobile-shell/mosh","homepage":"http://mosh.mit.edu","size":3499,"stargazers_count":4728,"watchers_count":4728,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":333,"mirror_url":null,"open_issues_count":143,"forks":333,"open_issues":143,"watchers":4728,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mobile-shell/mosh/pulls/696"},"html":{"href":"https://github.com/mobile-shell/mosh/pull/696"},"issue":{"href":"https://api.github.com/repos/mobile-shell/mosh/issues/696"},"comments":{"href":"https://api.github.com/repos/mobile-shell/mosh/issues/696/comments"},"review_comments":{"href":"https://api.github.com/repos/mobile-shell/mosh/pulls/696/comments"},"review_comment":{"href":"https://api.github.com/repos/mobile-shell/mosh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mobile-shell/mosh/pulls/696/commits"},"statuses":{"href":"https://api.github.com/repos/mobile-shell/mosh/statuses/dfa183d63dd58a1b0cb2c58264c046963159f356"}}}}