{"action":"opened","number":447,"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/447","id":48648740,"html_url":"https://github.com/pingcap/tidb/pull/447","diff_url":"https://github.com/pingcap/tidb/pull/447.diff","patch_url":"https://github.com/pingcap/tidb/pull/447.patch","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/447","number":447,"state":"open","locked":false,"title":"Store: add test cases for testing seek between existing keys","user":{"login":"xwb1989","id":1270701,"avatar_url":"https://avatars.githubusercontent.com/u/1270701?v=3","gravatar_id":"","url":"https://api.github.com/users/xwb1989","html_url":"https://github.com/xwb1989","followers_url":"https://api.github.com/users/xwb1989/followers","following_url":"https://api.github.com/users/xwb1989/following{/other_user}","gists_url":"https://api.github.com/users/xwb1989/gists{/gist_id}","starred_url":"https://api.github.com/users/xwb1989/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwb1989/subscriptions","organizations_url":"https://api.github.com/users/xwb1989/orgs","repos_url":"https://api.github.com/users/xwb1989/repos","events_url":"https://api.github.com/users/xwb1989/events{/privacy}","received_events_url":"https://api.github.com/users/xwb1989/received_events","type":"User","site_admin":false},"body":"Current kv_test `checkSeek` is not complete. For non-existing key seeking, it only covers the case that seeking key is larger the max key and the expected behavior is to have an invalid iterator returned; but the case that the non-existing seeking key is between existing keys is not covered and their current behaviors are just inverse:\r\n\r\n* seek beyond maximum: an invalid iterator is returned, this has already been tested.\r\n* seek between existing keys: a valid iterator is returned which has been positioned at the key that is the smallest one larger than the seeking key. This the the test case added by this PR.\r\n\r\nThis PR has not changed any kv implementation but just added test cases to reveal this behavior.","created_at":"2015-10-24T04:39:35Z","updated_at":"2015-10-24T04:39:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tidb/pulls/447/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb/pulls/447/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/447/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/d52b35e94ec13ed4dce268a01f81b462d189e579","head":{"label":"xwb1989:seekbetween","ref":"seekbetween","sha":"d52b35e94ec13ed4dce268a01f81b462d189e579","user":{"login":"xwb1989","id":1270701,"avatar_url":"https://avatars.githubusercontent.com/u/1270701?v=3","gravatar_id":"","url":"https://api.github.com/users/xwb1989","html_url":"https://github.com/xwb1989","followers_url":"https://api.github.com/users/xwb1989/followers","following_url":"https://api.github.com/users/xwb1989/following{/other_user}","gists_url":"https://api.github.com/users/xwb1989/gists{/gist_id}","starred_url":"https://api.github.com/users/xwb1989/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwb1989/subscriptions","organizations_url":"https://api.github.com/users/xwb1989/orgs","repos_url":"https://api.github.com/users/xwb1989/repos","events_url":"https://api.github.com/users/xwb1989/events{/privacy}","received_events_url":"https://api.github.com/users/xwb1989/received_events","type":"User","site_admin":false},"repo":{"id":44630053,"name":"tidb","full_name":"xwb1989/tidb","owner":{"login":"xwb1989","id":1270701,"avatar_url":"https://avatars.githubusercontent.com/u/1270701?v=3","gravatar_id":"","url":"https://api.github.com/users/xwb1989","html_url":"https://github.com/xwb1989","followers_url":"https://api.github.com/users/xwb1989/followers","following_url":"https://api.github.com/users/xwb1989/following{/other_user}","gists_url":"https://api.github.com/users/xwb1989/gists{/gist_id}","starred_url":"https://api.github.com/users/xwb1989/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwb1989/subscriptions","organizations_url":"https://api.github.com/users/xwb1989/orgs","repos_url":"https://api.github.com/users/xwb1989/repos","events_url":"https://api.github.com/users/xwb1989/events{/privacy}","received_events_url":"https://api.github.com/users/xwb1989/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xwb1989/tidb","description":"TiDB is a distributed SQL database compatible with MySQL protocol.","fork":true,"url":"https://api.github.com/repos/xwb1989/tidb","forks_url":"https://api.github.com/repos/xwb1989/tidb/forks","keys_url":"https://api.github.com/repos/xwb1989/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xwb1989/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xwb1989/tidb/teams","hooks_url":"https://api.github.com/repos/xwb1989/tidb/hooks","issue_events_url":"https://api.github.com/repos/xwb1989/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/xwb1989/tidb/events","assignees_url":"https://api.github.com/repos/xwb1989/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/xwb1989/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/xwb1989/tidb/tags","blobs_url":"https://api.github.com/repos/xwb1989/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xwb1989/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xwb1989/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/xwb1989/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xwb1989/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/xwb1989/tidb/languages","stargazers_url":"https://api.github.com/repos/xwb1989/tidb/stargazers","contributors_url":"https://api.github.com/repos/xwb1989/tidb/contributors","subscribers_url":"https://api.github.com/repos/xwb1989/tidb/subscribers","subscription_url":"https://api.github.com/repos/xwb1989/tidb/subscription","commits_url":"https://api.github.com/repos/xwb1989/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/xwb1989/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/xwb1989/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/xwb1989/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/xwb1989/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/xwb1989/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xwb1989/tidb/merges","archive_url":"https://api.github.com/repos/xwb1989/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xwb1989/tidb/downloads","issues_url":"https://api.github.com/repos/xwb1989/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/xwb1989/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/xwb1989/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/xwb1989/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xwb1989/tidb/labels{/name}","releases_url":"https://api.github.com/repos/xwb1989/tidb/releases{/id}","created_at":"2015-10-20T19:29:43Z","updated_at":"2015-10-20T19:29:45Z","pushed_at":"2015-10-24T04:30:48Z","git_url":"git://github.com/xwb1989/tidb.git","ssh_url":"git@github.com:xwb1989/tidb.git","clone_url":"https://github.com/xwb1989/tidb.git","svn_url":"https://github.com/xwb1989/tidb","homepage":"","size":6827,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"220285ca66411b6960467995d174a0f69a08876f","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":41986369,"name":"tidb","full_name":"pingcap/tidb","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tidb","description":"TiDB is a distributed SQL database compatible with MySQL protocol.","fork":false,"url":"https://api.github.com/repos/pingcap/tidb","forks_url":"https://api.github.com/repos/pingcap/tidb/forks","keys_url":"https://api.github.com/repos/pingcap/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb/events","assignees_url":"https://api.github.com/repos/pingcap/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb/merges","archive_url":"https://api.github.com/repos/pingcap/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb/releases{/id}","created_at":"2015-09-06T04:01:52Z","updated_at":"2015-10-24T04:15:32Z","pushed_at":"2015-10-24T04:04:52Z","git_url":"git://github.com/pingcap/tidb.git","ssh_url":"git@github.com:pingcap/tidb.git","clone_url":"https://github.com/pingcap/tidb.git","svn_url":"https://github.com/pingcap/tidb","homepage":"","size":11741,"stargazers_count":2695,"watchers_count":2695,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":258,"mirror_url":null,"open_issues_count":57,"forks":258,"open_issues":57,"watchers":2695,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/447"},"html":{"href":"https://github.com/pingcap/tidb/pull/447"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb/issues/447"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb/issues/447/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/447/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/447/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb/statuses/d52b35e94ec13ed4dce268a01f81b462d189e579"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":21,"deletions":10,"changed_files":1}}