{"action":"created","issue":{"url":"https://api.github.com/repos/randombit/botan/issues/117","labels_url":"https://api.github.com/repos/randombit/botan/issues/117/labels{/name}","comments_url":"https://api.github.com/repos/randombit/botan/issues/117/comments","events_url":"https://api.github.com/repos/randombit/botan/issues/117/events","html_url":"https://github.com/randombit/botan/pull/117","id":89425111,"number":117,"title":"Missing overrides for some class's.","user":{"login":"jthomo","id":12953521,"avatar_url":"https://avatars.githubusercontent.com/u/12953521?v=3","gravatar_id":"","url":"https://api.github.com/users/jthomo","html_url":"https://github.com/jthomo","followers_url":"https://api.github.com/users/jthomo/followers","following_url":"https://api.github.com/users/jthomo/following{/other_user}","gists_url":"https://api.github.com/users/jthomo/gists{/gist_id}","starred_url":"https://api.github.com/users/jthomo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jthomo/subscriptions","organizations_url":"https://api.github.com/users/jthomo/orgs","repos_url":"https://api.github.com/users/jthomo/repos","events_url":"https://api.github.com/users/jthomo/events{/privacy}","received_events_url":"https://api.github.com/users/jthomo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-06-18T23:42:38Z","updated_at":"2015-06-24T07:47:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/randombit/botan/pulls/117","html_url":"https://github.com/randombit/botan/pull/117","diff_url":"https://github.com/randombit/botan/pull/117.diff","patch_url":"https://github.com/randombit/botan/pull/117.patch"},"body":"When building with clang++ -std=c++14 and you try to link against botan\r\nthat has been compiled with gcc, the linker complains about some symbols\r\nbeing undefined. This is due to the missing override specifier."},"comment":{"url":"https://api.github.com/repos/randombit/botan/issues/comments/114769068","html_url":"https://github.com/randombit/botan/pull/117#issuecomment-114769068","issue_url":"https://api.github.com/repos/randombit/botan/issues/117","id":114769068,"user":{"login":"jthomo","id":12953521,"avatar_url":"https://avatars.githubusercontent.com/u/12953521?v=3","gravatar_id":"","url":"https://api.github.com/users/jthomo","html_url":"https://github.com/jthomo","followers_url":"https://api.github.com/users/jthomo/followers","following_url":"https://api.github.com/users/jthomo/following{/other_user}","gists_url":"https://api.github.com/users/jthomo/gists{/gist_id}","starred_url":"https://api.github.com/users/jthomo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jthomo/subscriptions","organizations_url":"https://api.github.com/users/jthomo/orgs","repos_url":"https://api.github.com/users/jthomo/repos","events_url":"https://api.github.com/users/jthomo/events{/privacy}","received_events_url":"https://api.github.com/users/jthomo/received_events","type":"User","site_admin":false},"created_at":"2015-06-24T07:47:34Z","updated_at":"2015-06-24T07:47:34Z","body":"The linker error I was having was a separate issue that appeared with llvm/clang. The c++11 methods for strings are compiled as\r\nBotan::OctetString::as_string in gcc _ZNK5Botan11OctetString9as_stringB5cxx11Ev or Botan::OctetString::as_string[abi:cxx11]() const\r\nwhereas with with clang Botan::OctetString::as_string() const becomes _ZNK5Botan11OctetString9as_stringEv or _ZNK5Botan11OctetString9as_stringEv\r\n"}}