{"action":"created","issue":{"url":"https://api.github.com/repos/chadaustin/sajson/issues/7","labels_url":"https://api.github.com/repos/chadaustin/sajson/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/chadaustin/sajson/issues/7/comments","events_url":"https://api.github.com/repos/chadaustin/sajson/issues/7/events","html_url":"https://github.com/chadaustin/sajson/issues/7","id":69134669,"number":7,"title":"Parsing failure","user":{"login":"miloyip","id":1195774,"avatar_url":"https://avatars.githubusercontent.com/u/1195774?v=3","gravatar_id":"","url":"https://api.github.com/users/miloyip","html_url":"https://github.com/miloyip","followers_url":"https://api.github.com/users/miloyip/followers","following_url":"https://api.github.com/users/miloyip/following{/other_user}","gists_url":"https://api.github.com/users/miloyip/gists{/gist_id}","starred_url":"https://api.github.com/users/miloyip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miloyip/subscriptions","organizations_url":"https://api.github.com/users/miloyip/orgs","repos_url":"https://api.github.com/users/miloyip/repos","events_url":"https://api.github.com/users/miloyip/events{/privacy}","received_events_url":"https://api.github.com/users/miloyip/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-04-17T13:02:46Z","updated_at":"2015-04-18T07:07:37Z","closed_at":"2015-04-18T06:15:32Z","body":"I recently try to add sajson to nativejson-benchmark in [this branch](https://github.com/miloyip/nativejson-benchmark/tree/sajson). \r\n\r\nIt was able to parse two test json data, but failed for [twitter.json](https://github.com/miloyip/nativejson-benchmark/blob/sajson/data/twitter.json). The error message generated is \r\n\r\n~~~\r\nVerifying sajson (C++) ... Error (1:1): illegal unprintable codepoint in string\r\n~~~\r\n\r\nwith this [code](https://github.com/miloyip/nativejson-benchmark/blob/sajson/src/tests/sajsontest.cpp):\r\n~~~cpp\r\nclass SajsonParseResult : public ParseResultBase {\r\npublic:\r\n    SajsonParseResult(document&& d_) : d(std::move(d_)) {}\r\n    document d;\r\n};\r\n\r\n// ...\r\n    virtual ParseResultBase* Parse(const char* json, size_t length) const {\r\n        (void)length;\r\n        SajsonParseResult* pr = new SajsonParseResult(parse(literal(json)));\r\n        if (!pr->d.is_valid()) {\r\n            std::cout << \"Error (\" << pr->d.get_error_line() << \":\" << pr->d.get_error_column() << \"): \" << pr->d.get_error_message() << std::endl;\r\n        }\r\n    \treturn pr;\r\n    }\r\n~~~\r\n\r\nI am pretty sure the json is valid, as it is obtained from twitter's API, and also passed more than a dozens of parsers.\r\n\r\nBTW, I am the author of RapidJSON :)"},"comment":{"url":"https://api.github.com/repos/chadaustin/sajson/issues/comments/94136037","html_url":"https://github.com/chadaustin/sajson/issues/7#issuecomment-94136037","issue_url":"https://api.github.com/repos/chadaustin/sajson/issues/7","id":94136037,"user":{"login":"miloyip","id":1195774,"avatar_url":"https://avatars.githubusercontent.com/u/1195774?v=3","gravatar_id":"","url":"https://api.github.com/users/miloyip","html_url":"https://github.com/miloyip","followers_url":"https://api.github.com/users/miloyip/followers","following_url":"https://api.github.com/users/miloyip/following{/other_user}","gists_url":"https://api.github.com/users/miloyip/gists{/gist_id}","starred_url":"https://api.github.com/users/miloyip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miloyip/subscriptions","organizations_url":"https://api.github.com/users/miloyip/orgs","repos_url":"https://api.github.com/users/miloyip/repos","events_url":"https://api.github.com/users/miloyip/events{/privacy}","received_events_url":"https://api.github.com/users/miloyip/received_events","type":"User","site_admin":false},"created_at":"2015-04-18T07:07:37Z","updated_at":"2015-04-18T07:07:37Z","body":"One of my intention for making the benchmark is to learn from others and make improvements together.\r\nI just learn about `__builtin_expect` from your code. Is it really beneficial?"}}