{"action":"created","comment":{"url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/pulls/comments/35584830","id":35584830,"diff_hunk":"@@ -93,7 +93,9 @@ def _get_default_dped(dped_facts):\n     if len(keys) == 0:\n         return None\n     elif len(keys) == 1:\n-        return [f for f in dped_facts.values()]\n+        # Only one Document Period End Date, so that is our default\n+        (_, value), = dped_facts.items()","path":"src/dqc_us_0033_0036.py","position":6,"original_position":6,"commit_id":"baf5b9f2ad3b9d69f72d6d7acd3e116f339808ad","original_commit_id":"baf5b9f2ad3b9d69f72d6d7acd3e116f339808ad","user":{"login":"andrewperkins-wf","id":1467205,"avatar_url":"https://avatars.githubusercontent.com/u/1467205?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewperkins-wf","html_url":"https://github.com/andrewperkins-wf","followers_url":"https://api.github.com/users/andrewperkins-wf/followers","following_url":"https://api.github.com/users/andrewperkins-wf/following{/other_user}","gists_url":"https://api.github.com/users/andrewperkins-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewperkins-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewperkins-wf/subscriptions","organizations_url":"https://api.github.com/users/andrewperkins-wf/orgs","repos_url":"https://api.github.com/users/andrewperkins-wf/repos","events_url":"https://api.github.com/users/andrewperkins-wf/events{/privacy}","received_events_url":"https://api.github.com/users/andrewperkins-wf/received_events","type":"User","site_admin":false},"body":"This is a standard Python construct around getting an item out of an iterator.\r\n\r\n```dped_facts``` is a ```dict``` object.  The ```values()``` function returns an iterator (I believe a generated iterator) of type ```dict_items```.  This cannot be indexed into, but we know it must have one item (because of our ```len``` check leading into the ```if``` block).  Because of this, we can use the comma construct to only give us the first item (and in this case, only item) of the ```items()``` generator.","created_at":"2015-07-27T20:48:45Z","updated_at":"2015-07-27T20:48:45Z","html_url":"https://github.com/DataQualityCommittee/dqc_us_rules/pull/3#discussion_r35584830","pull_request_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/pulls/comments/35584830"},"html":{"href":"https://github.com/DataQualityCommittee/dqc_us_rules/pull/3#discussion_r35584830"},"pull_request":{"href":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/pulls/3","id":40946508,"html_url":"https://github.com/DataQualityCommittee/dqc_us_rules/pull/3","diff_url":"https://github.com/DataQualityCommittee/dqc_us_rules/pull/3.diff","patch_url":"https://github.com/DataQualityCommittee/dqc_us_rules/pull/3.patch","issue_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/issues/3","number":3,"state":"open","locked":false,"title":"DQC US Rule 33 Single DPED","user":{"login":"andrewperkins-wf","id":1467205,"avatar_url":"https://avatars.githubusercontent.com/u/1467205?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewperkins-wf","html_url":"https://github.com/andrewperkins-wf","followers_url":"https://api.github.com/users/andrewperkins-wf/followers","following_url":"https://api.github.com/users/andrewperkins-wf/following{/other_user}","gists_url":"https://api.github.com/users/andrewperkins-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewperkins-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewperkins-wf/subscriptions","organizations_url":"https://api.github.com/users/andrewperkins-wf/orgs","repos_url":"https://api.github.com/users/andrewperkins-wf/repos","events_url":"https://api.github.com/users/andrewperkins-wf/events{/privacy}","received_events_url":"https://api.github.com/users/andrewperkins-wf/received_events","type":"User","site_admin":false},"body":"# Problem\r\nWhen a filing had only a singled Document Period End Date defined, we were generating an exception if rule #33 was being run.\r\n\r\n# Solution\r\nWe were returning an embedded list of lists that caused this issue.  Fixed the mechanism that was getting the single element out of the dictionary of Document Period End Dates and added some unit tests to verify this functionality consistently.\r\n\r\nAlso did a minor update to the __init__.py plugin declaration to make it work properly with the Arelle UI.","created_at":"2015-07-27T20:39:02Z","updated_at":"2015-07-27T20:48:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fffbe45b58a250cd9459e43c080354194726fb06","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/pulls/3/commits","review_comments_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/pulls/3/comments","review_comment_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/issues/3/comments","statuses_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/statuses/baf5b9f2ad3b9d69f72d6d7acd3e116f339808ad","head":{"label":"andrewperkins-wf:us_33_single_dped","ref":"us_33_single_dped","sha":"baf5b9f2ad3b9d69f72d6d7acd3e116f339808ad","user":{"login":"andrewperkins-wf","id":1467205,"avatar_url":"https://avatars.githubusercontent.com/u/1467205?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewperkins-wf","html_url":"https://github.com/andrewperkins-wf","followers_url":"https://api.github.com/users/andrewperkins-wf/followers","following_url":"https://api.github.com/users/andrewperkins-wf/following{/other_user}","gists_url":"https://api.github.com/users/andrewperkins-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewperkins-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewperkins-wf/subscriptions","organizations_url":"https://api.github.com/users/andrewperkins-wf/orgs","repos_url":"https://api.github.com/users/andrewperkins-wf/repos","events_url":"https://api.github.com/users/andrewperkins-wf/events{/privacy}","received_events_url":"https://api.github.com/users/andrewperkins-wf/received_events","type":"User","site_admin":false},"repo":{"id":38648800,"name":"dqc_us_rules","full_name":"andrewperkins-wf/dqc_us_rules","owner":{"login":"andrewperkins-wf","id":1467205,"avatar_url":"https://avatars.githubusercontent.com/u/1467205?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewperkins-wf","html_url":"https://github.com/andrewperkins-wf","followers_url":"https://api.github.com/users/andrewperkins-wf/followers","following_url":"https://api.github.com/users/andrewperkins-wf/following{/other_user}","gists_url":"https://api.github.com/users/andrewperkins-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewperkins-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewperkins-wf/subscriptions","organizations_url":"https://api.github.com/users/andrewperkins-wf/orgs","repos_url":"https://api.github.com/users/andrewperkins-wf/repos","events_url":"https://api.github.com/users/andrewperkins-wf/events{/privacy}","received_events_url":"https://api.github.com/users/andrewperkins-wf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewperkins-wf/dqc_us_rules","description":"Implementation of DQC US Rules as an open source plugin for Arelle.","fork":true,"url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules","forks_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/forks","keys_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/teams","hooks_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/hooks","issue_events_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/issues/events{/number}","events_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/events","assignees_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/assignees{/user}","branches_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/branches{/branch}","tags_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/tags","blobs_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/languages","stargazers_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/stargazers","contributors_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/contributors","subscribers_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/subscribers","subscription_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/subscription","commits_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/contents/{+path}","compare_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/merges","archive_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/downloads","issues_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/issues{/number}","pulls_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/labels{/name}","releases_url":"https://api.github.com/repos/andrewperkins-wf/dqc_us_rules/releases{/id}","created_at":"2015-07-06T22:02:59Z","updated_at":"2015-07-27T20:04:54Z","pushed_at":"2015-07-27T20:36:56Z","git_url":"git://github.com/andrewperkins-wf/dqc_us_rules.git","ssh_url":"git@github.com:andrewperkins-wf/dqc_us_rules.git","clone_url":"https://github.com/andrewperkins-wf/dqc_us_rules.git","svn_url":"https://github.com/andrewperkins-wf/dqc_us_rules","homepage":null,"size":6860,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DataQualityCommittee:master","ref":"master","sha":"95e5e2dbc8ef56fdf9e928df017647d35effde88","user":{"login":"DataQualityCommittee","id":12073756,"avatar_url":"https://avatars.githubusercontent.com/u/12073756?v=3","gravatar_id":"","url":"https://api.github.com/users/DataQualityCommittee","html_url":"https://github.com/DataQualityCommittee","followers_url":"https://api.github.com/users/DataQualityCommittee/followers","following_url":"https://api.github.com/users/DataQualityCommittee/following{/other_user}","gists_url":"https://api.github.com/users/DataQualityCommittee/gists{/gist_id}","starred_url":"https://api.github.com/users/DataQualityCommittee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataQualityCommittee/subscriptions","organizations_url":"https://api.github.com/users/DataQualityCommittee/orgs","repos_url":"https://api.github.com/users/DataQualityCommittee/repos","events_url":"https://api.github.com/users/DataQualityCommittee/events{/privacy}","received_events_url":"https://api.github.com/users/DataQualityCommittee/received_events","type":"Organization","site_admin":false},"repo":{"id":38648767,"name":"dqc_us_rules","full_name":"DataQualityCommittee/dqc_us_rules","owner":{"login":"DataQualityCommittee","id":12073756,"avatar_url":"https://avatars.githubusercontent.com/u/12073756?v=3","gravatar_id":"","url":"https://api.github.com/users/DataQualityCommittee","html_url":"https://github.com/DataQualityCommittee","followers_url":"https://api.github.com/users/DataQualityCommittee/followers","following_url":"https://api.github.com/users/DataQualityCommittee/following{/other_user}","gists_url":"https://api.github.com/users/DataQualityCommittee/gists{/gist_id}","starred_url":"https://api.github.com/users/DataQualityCommittee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataQualityCommittee/subscriptions","organizations_url":"https://api.github.com/users/DataQualityCommittee/orgs","repos_url":"https://api.github.com/users/DataQualityCommittee/repos","events_url":"https://api.github.com/users/DataQualityCommittee/events{/privacy}","received_events_url":"https://api.github.com/users/DataQualityCommittee/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataQualityCommittee/dqc_us_rules","description":"XBRL US Data Quality Committee Rules","fork":false,"url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules","forks_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/forks","keys_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/teams","hooks_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/hooks","issue_events_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/issues/events{/number}","events_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/events","assignees_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/assignees{/user}","branches_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/branches{/branch}","tags_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/tags","blobs_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/statuses/{sha}","languages_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/languages","stargazers_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/stargazers","contributors_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/contributors","subscribers_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/subscribers","subscription_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/subscription","commits_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/contents/{+path}","compare_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/merges","archive_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/downloads","issues_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/issues{/number}","pulls_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/pulls{/number}","milestones_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/milestones{/number}","notifications_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/labels{/name}","releases_url":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/releases{/id}","created_at":"2015-07-06T22:02:26Z","updated_at":"2015-07-15T17:58:57Z","pushed_at":"2015-07-27T20:39:02Z","git_url":"git://github.com/DataQualityCommittee/dqc_us_rules.git","ssh_url":"git@github.com:DataQualityCommittee/dqc_us_rules.git","clone_url":"https://github.com/DataQualityCommittee/dqc_us_rules.git","svn_url":"https://github.com/DataQualityCommittee/dqc_us_rules","homepage":"http://publicreview.xbrl.us","size":6859,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/pulls/3"},"html":{"href":"https://github.com/DataQualityCommittee/dqc_us_rules/pull/3"},"issue":{"href":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/issues/3"},"comments":{"href":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/DataQualityCommittee/dqc_us_rules/statuses/baf5b9f2ad3b9d69f72d6d7acd3e116f339808ad"}}}}