{"action":"created","issue":{"url":"https://api.github.com/repos/peterh/liner/issues/43","labels_url":"https://api.github.com/repos/peterh/liner/issues/43/labels{/name}","comments_url":"https://api.github.com/repos/peterh/liner/issues/43/comments","events_url":"https://api.github.com/repos/peterh/liner/issues/43/events","html_url":"https://github.com/peterh/liner/pull/43","id":65833972,"number":43,"title":"Add support for double-width (CJK) characters","user":{"login":"jnjackins","id":449232,"avatar_url":"https://avatars.githubusercontent.com/u/449232?v=3","gravatar_id":"","url":"https://api.github.com/users/jnjackins","html_url":"https://github.com/jnjackins","followers_url":"https://api.github.com/users/jnjackins/followers","following_url":"https://api.github.com/users/jnjackins/following{/other_user}","gists_url":"https://api.github.com/users/jnjackins/gists{/gist_id}","starred_url":"https://api.github.com/users/jnjackins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnjackins/subscriptions","organizations_url":"https://api.github.com/users/jnjackins/orgs","repos_url":"https://api.github.com/users/jnjackins/repos","events_url":"https://api.github.com/users/jnjackins/events{/privacy}","received_events_url":"https://api.github.com/users/jnjackins/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-02T04:28:12Z","updated_at":"2015-04-02T13:21:38Z","closed_at":"2015-04-02T13:15:57Z","pull_request":{"url":"https://api.github.com/repos/peterh/liner/pulls/43","html_url":"https://github.com/peterh/liner/pull/43","diff_url":"https://github.com/peterh/liner/pull/43.diff","patch_url":"https://github.com/peterh/liner/pull/43.patch"},"body":"Tested on OS X and the latest Ubuntu, using the default terminal application for each, and from a tty on Ubuntu. \r\n\r\nSorry for all the diff noise in width_test.go. The actual test semantics only change in TestCountGlyphs, which compares against the pre-computed testCase.glyphs rather than the length of a slice of runes.\r\n\r\nFixes #42"},"comment":{"url":"https://api.github.com/repos/peterh/liner/issues/comments/88894076","html_url":"https://github.com/peterh/liner/pull/43#issuecomment-88894076","issue_url":"https://api.github.com/repos/peterh/liner/issues/43","id":88894076,"user":{"login":"peterh","id":79339,"avatar_url":"https://avatars.githubusercontent.com/u/79339?v=3","gravatar_id":"","url":"https://api.github.com/users/peterh","html_url":"https://github.com/peterh","followers_url":"https://api.github.com/users/peterh/followers","following_url":"https://api.github.com/users/peterh/following{/other_user}","gists_url":"https://api.github.com/users/peterh/gists{/gist_id}","starred_url":"https://api.github.com/users/peterh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterh/subscriptions","organizations_url":"https://api.github.com/users/peterh/orgs","repos_url":"https://api.github.com/users/peterh/repos","events_url":"https://api.github.com/users/peterh/events{/privacy}","received_events_url":"https://api.github.com/users/peterh/received_events","type":"User","site_admin":false},"created_at":"2015-04-02T13:21:38Z","updated_at":"2015-04-02T13:21:38Z","body":"Thanks for the pull request.\r\n\r\nPulled, on the basis that it's clean, it doesn't affect what I'm doing, and it should be an improvement on the status quo even though it doesn't catch every fullwidth character.\r\n\r\nI'm just going to point out that unicode.Katakana includes some halfwidth Katakana characters (eg. \\uFF66 through \\uFF9D http://en.wikipedia.org/wiki/Halfwidth_and_fullwidth_forms#In_Unicode ), so those glyphs regress with this patch."}}