{"action":"created","comment":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/comments/32880092","id":32880092,"diff_hunk":"@@ -14,19 +21,28 @@ angular.module(PKG.name + '.feature.admin')\n           description: $scope.model.description\n         }\n       })\n-        .then(function() {\n-          $modalInstance.close();\n-          $alert({\n-            title: 'Success!',\n-            content: 'Namespace Created!',\n-            type: 'success'\n-          });\n+        .then(\n+          function success() {\n+            $scope.isSaving = false;\n+            $modalInstance.close();\n+            $alert({\n+              title: 'Success!',\n+              content: 'Namespace Created!',\n+              type: 'success'\n+            });\n \n-          myNamespace.getList(true).then(function() {\n-            EventPipe.emit('namespace.update');\n-          });\n-        });\n-    });\n+            myNamespace.getList(true).then(function() {\n+              EventPipe.emit('namespace.update');\n+            });\n+            queryInProgress = false;\n+          },\n+          function error(err) {\n+            $scope.isSaving = false;\n+            queryInProgress = false;","path":"cdap-ui/app/features/admin/controllers/NamespaceCreateController.js","position":50,"original_position":50,"commit_id":"001d8959a94d2fa315dce14f874210d7cdd8eeba","original_commit_id":"001d8959a94d2fa315dce14f874210d7cdd8eeba","user":{"login":"elfenheart","id":4398643,"avatar_url":"https://avatars.githubusercontent.com/u/4398643?v=3","gravatar_id":"","url":"https://api.github.com/users/elfenheart","html_url":"https://github.com/elfenheart","followers_url":"https://api.github.com/users/elfenheart/followers","following_url":"https://api.github.com/users/elfenheart/following{/other_user}","gists_url":"https://api.github.com/users/elfenheart/gists{/gist_id}","starred_url":"https://api.github.com/users/elfenheart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elfenheart/subscriptions","organizations_url":"https://api.github.com/users/elfenheart/orgs","repos_url":"https://api.github.com/users/elfenheart/repos","events_url":"https://api.github.com/users/elfenheart/events{/privacy}","received_events_url":"https://api.github.com/users/elfenheart/received_events","type":"User","site_admin":false},"body":"consolidate queryInProgress with $scope.isSaving?","created_at":"2015-06-20T00:53:03Z","updated_at":"2015-06-20T00:53:03Z","html_url":"https://github.com/caskdata/cdap/pull/3008#discussion_r32880092","pull_request_url":"https://api.github.com/repos/caskdata/cdap/pulls/3008","_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments/32880092"},"html":{"href":"https://github.com/caskdata/cdap/pull/3008#discussion_r32880092"},"pull_request":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/3008"}}},"pull_request":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/3008","id":38158260,"html_url":"https://github.com/caskdata/cdap/pull/3008","diff_url":"https://github.com/caskdata/cdap/pull/3008.diff","patch_url":"https://github.com/caskdata/cdap/pull/3008.patch","issue_url":"https://api.github.com/repos/caskdata/cdap/issues/3008","number":3008,"state":"open","locked":false,"title":"Fix/ui streams creation ux","user":{"login":"ajainarayanan","id":1452845,"avatar_url":"https://avatars.githubusercontent.com/u/1452845?v=3","gravatar_id":"","url":"https://api.github.com/users/ajainarayanan","html_url":"https://github.com/ajainarayanan","followers_url":"https://api.github.com/users/ajainarayanan/followers","following_url":"https://api.github.com/users/ajainarayanan/following{/other_user}","gists_url":"https://api.github.com/users/ajainarayanan/gists{/gist_id}","starred_url":"https://api.github.com/users/ajainarayanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajainarayanan/subscriptions","organizations_url":"https://api.github.com/users/ajainarayanan/orgs","repos_url":"https://api.github.com/users/ajainarayanan/repos","events_url":"https://api.github.com/users/ajainarayanan/events{/privacy}","received_events_url":"https://api.github.com/users/ajainarayanan/received_events","type":"User","site_admin":false},"body":"Fixes creating streams in UI.\r\n- Shows loading when creating a stream.\r\n- Shows error message in context.\r\n- Show success page.\r\n- Fixes pagination in datasets, apps & runs history view\r\n- Fixes search in pagination","created_at":"2015-06-20T00:06:23Z","updated_at":"2015-06-20T00:53:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a772b743c7aa9a6f5ac86a643c7eeb257a3758c","assignee":null,"milestone":{"url":"https://api.github.com/repos/caskdata/cdap/milestones/7","html_url":"https://github.com/caskdata/cdap/milestones/3.0.1","labels_url":"https://api.github.com/repos/caskdata/cdap/milestones/7/labels","id":1124241,"number":7,"title":"3.0.1","description":null,"creator":{"login":"jwang47","id":1084704,"avatar_url":"https://avatars.githubusercontent.com/u/1084704?v=3","gravatar_id":"","url":"https://api.github.com/users/jwang47","html_url":"https://github.com/jwang47","followers_url":"https://api.github.com/users/jwang47/followers","following_url":"https://api.github.com/users/jwang47/following{/other_user}","gists_url":"https://api.github.com/users/jwang47/gists{/gist_id}","starred_url":"https://api.github.com/users/jwang47/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwang47/subscriptions","organizations_url":"https://api.github.com/users/jwang47/orgs","repos_url":"https://api.github.com/users/jwang47/repos","events_url":"https://api.github.com/users/jwang47/events{/privacy}","received_events_url":"https://api.github.com/users/jwang47/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":28,"state":"open","created_at":"2015-05-21T22:01:15Z","updated_at":"2015-06-20T00:06:23Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/caskdata/cdap/pulls/3008/commits","review_comments_url":"https://api.github.com/repos/caskdata/cdap/pulls/3008/comments","review_comment_url":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caskdata/cdap/issues/3008/comments","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/001d8959a94d2fa315dce14f874210d7cdd8eeba","head":{"label":"caskdata:fix/ui-streams-creation-ux","ref":"fix/ui-streams-creation-ux","sha":"001d8959a94d2fa315dce14f874210d7cdd8eeba","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","created_at":"2014-08-02T09:00:10Z","updated_at":"2015-06-15T22:57:56Z","pushed_at":"2015-06-20T00:41:21Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":828005,"stargazers_count":52,"watchers_count":52,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":17,"mirror_url":null,"open_issues_count":23,"forks":17,"open_issues":23,"watchers":52,"default_branch":"develop"}},"base":{"label":"caskdata:release/3.0","ref":"release/3.0","sha":"abfd26947679c75a1d758d098d9beeac8ce1fabd","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","created_at":"2014-08-02T09:00:10Z","updated_at":"2015-06-15T22:57:56Z","pushed_at":"2015-06-20T00:41:21Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":828005,"stargazers_count":52,"watchers_count":52,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":17,"mirror_url":null,"open_issues_count":23,"forks":17,"open_issues":23,"watchers":52,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/3008"},"html":{"href":"https://github.com/caskdata/cdap/pull/3008"},"issue":{"href":"https://api.github.com/repos/caskdata/cdap/issues/3008"},"comments":{"href":"https://api.github.com/repos/caskdata/cdap/issues/3008/comments"},"review_comments":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/3008/comments"},"review_comment":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/3008/commits"},"statuses":{"href":"https://api.github.com/repos/caskdata/cdap/statuses/001d8959a94d2fa315dce14f874210d7cdd8eeba"}}}}