{"action":"closed","number":9,"pull_request":{"url":"https://api.github.com/repos/fisshy/react-scroll/pulls/9","id":32469734,"html_url":"https://github.com/fisshy/react-scroll/pull/9","diff_url":"https://github.com/fisshy/react-scroll/pull/9.diff","patch_url":"https://github.com/fisshy/react-scroll/pull/9.patch","issue_url":"https://api.github.com/repos/fisshy/react-scroll/issues/9","number":9,"state":"closed","locked":false,"title":"Fix scroll-spy events leaking after component unmount","user":{"login":"joemcbride","id":255007,"avatar_url":"https://avatars.githubusercontent.com/u/255007?v=3","gravatar_id":"","url":"https://api.github.com/users/joemcbride","html_url":"https://github.com/joemcbride","followers_url":"https://api.github.com/users/joemcbride/followers","following_url":"https://api.github.com/users/joemcbride/following{/other_user}","gists_url":"https://api.github.com/users/joemcbride/gists{/gist_id}","starred_url":"https://api.github.com/users/joemcbride/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joemcbride/subscriptions","organizations_url":"https://api.github.com/users/joemcbride/orgs","repos_url":"https://api.github.com/users/joemcbride/repos","events_url":"https://api.github.com/users/joemcbride/events{/privacy}","received_events_url":"https://api.github.com/users/joemcbride/received_events","type":"User","site_admin":false},"body":"* If scroll-spy is enabled and the component is unmounted the scroll\r\n  events will still hang around and attempt to set state.\r\n* The design should probably be changed to not use globals (a service\r\n  instead perhaps?), though this is a quick fix.","created_at":"2015-04-01T23:06:52Z","updated_at":"2015-04-03T12:51:06Z","closed_at":"2015-04-03T12:51:06Z","merged_at":"2015-04-03T12:51:06Z","merge_commit_sha":"9ab7dacd53e95bcf196d3f8e4231bb43b91a2adb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fisshy/react-scroll/pulls/9/commits","review_comments_url":"https://api.github.com/repos/fisshy/react-scroll/pulls/9/comments","review_comment_url":"https://api.github.com/repos/fisshy/react-scroll/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fisshy/react-scroll/issues/9/comments","statuses_url":"https://api.github.com/repos/fisshy/react-scroll/statuses/716a88f821fb44f48e978517e8663fd36c183c72","head":{"label":"joemcbride:master","ref":"master","sha":"716a88f821fb44f48e978517e8663fd36c183c72","user":{"login":"joemcbride","id":255007,"avatar_url":"https://avatars.githubusercontent.com/u/255007?v=3","gravatar_id":"","url":"https://api.github.com/users/joemcbride","html_url":"https://github.com/joemcbride","followers_url":"https://api.github.com/users/joemcbride/followers","following_url":"https://api.github.com/users/joemcbride/following{/other_user}","gists_url":"https://api.github.com/users/joemcbride/gists{/gist_id}","starred_url":"https://api.github.com/users/joemcbride/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joemcbride/subscriptions","organizations_url":"https://api.github.com/users/joemcbride/orgs","repos_url":"https://api.github.com/users/joemcbride/repos","events_url":"https://api.github.com/users/joemcbride/events{/privacy}","received_events_url":"https://api.github.com/users/joemcbride/received_events","type":"User","site_admin":false},"repo":{"id":33020760,"name":"react-scroll","full_name":"joemcbride/react-scroll","owner":{"login":"joemcbride","id":255007,"avatar_url":"https://avatars.githubusercontent.com/u/255007?v=3","gravatar_id":"","url":"https://api.github.com/users/joemcbride","html_url":"https://github.com/joemcbride","followers_url":"https://api.github.com/users/joemcbride/followers","following_url":"https://api.github.com/users/joemcbride/following{/other_user}","gists_url":"https://api.github.com/users/joemcbride/gists{/gist_id}","starred_url":"https://api.github.com/users/joemcbride/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joemcbride/subscriptions","organizations_url":"https://api.github.com/users/joemcbride/orgs","repos_url":"https://api.github.com/users/joemcbride/repos","events_url":"https://api.github.com/users/joemcbride/events{/privacy}","received_events_url":"https://api.github.com/users/joemcbride/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joemcbride/react-scroll","description":"React scroll component","fork":true,"url":"https://api.github.com/repos/joemcbride/react-scroll","forks_url":"https://api.github.com/repos/joemcbride/react-scroll/forks","keys_url":"https://api.github.com/repos/joemcbride/react-scroll/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joemcbride/react-scroll/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joemcbride/react-scroll/teams","hooks_url":"https://api.github.com/repos/joemcbride/react-scroll/hooks","issue_events_url":"https://api.github.com/repos/joemcbride/react-scroll/issues/events{/number}","events_url":"https://api.github.com/repos/joemcbride/react-scroll/events","assignees_url":"https://api.github.com/repos/joemcbride/react-scroll/assignees{/user}","branches_url":"https://api.github.com/repos/joemcbride/react-scroll/branches{/branch}","tags_url":"https://api.github.com/repos/joemcbride/react-scroll/tags","blobs_url":"https://api.github.com/repos/joemcbride/react-scroll/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joemcbride/react-scroll/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joemcbride/react-scroll/git/refs{/sha}","trees_url":"https://api.github.com/repos/joemcbride/react-scroll/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joemcbride/react-scroll/statuses/{sha}","languages_url":"https://api.github.com/repos/joemcbride/react-scroll/languages","stargazers_url":"https://api.github.com/repos/joemcbride/react-scroll/stargazers","contributors_url":"https://api.github.com/repos/joemcbride/react-scroll/contributors","subscribers_url":"https://api.github.com/repos/joemcbride/react-scroll/subscribers","subscription_url":"https://api.github.com/repos/joemcbride/react-scroll/subscription","commits_url":"https://api.github.com/repos/joemcbride/react-scroll/commits{/sha}","git_commits_url":"https://api.github.com/repos/joemcbride/react-scroll/git/commits{/sha}","comments_url":"https://api.github.com/repos/joemcbride/react-scroll/comments{/number}","issue_comment_url":"https://api.github.com/repos/joemcbride/react-scroll/issues/comments{/number}","contents_url":"https://api.github.com/repos/joemcbride/react-scroll/contents/{+path}","compare_url":"https://api.github.com/repos/joemcbride/react-scroll/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joemcbride/react-scroll/merges","archive_url":"https://api.github.com/repos/joemcbride/react-scroll/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joemcbride/react-scroll/downloads","issues_url":"https://api.github.com/repos/joemcbride/react-scroll/issues{/number}","pulls_url":"https://api.github.com/repos/joemcbride/react-scroll/pulls{/number}","milestones_url":"https://api.github.com/repos/joemcbride/react-scroll/milestones{/number}","notifications_url":"https://api.github.com/repos/joemcbride/react-scroll/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joemcbride/react-scroll/labels{/name}","releases_url":"https://api.github.com/repos/joemcbride/react-scroll/releases{/id}","created_at":"2015-03-28T04:20:45Z","updated_at":"2015-04-03T03:56:16Z","pushed_at":"2015-04-03T03:56:15Z","git_url":"git://github.com/joemcbride/react-scroll.git","ssh_url":"git@github.com:joemcbride/react-scroll.git","clone_url":"https://github.com/joemcbride/react-scroll.git","svn_url":"https://github.com/joemcbride/react-scroll","homepage":"https://github.com/fisshy/react-scroll/blob/master/README.md","size":256,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fisshy:master","ref":"master","sha":"2d9b47d6cc8bd2f0e37346641c280fc3a1446319","user":{"login":"fisshy","id":3023875,"avatar_url":"https://avatars.githubusercontent.com/u/3023875?v=3","gravatar_id":"","url":"https://api.github.com/users/fisshy","html_url":"https://github.com/fisshy","followers_url":"https://api.github.com/users/fisshy/followers","following_url":"https://api.github.com/users/fisshy/following{/other_user}","gists_url":"https://api.github.com/users/fisshy/gists{/gist_id}","starred_url":"https://api.github.com/users/fisshy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fisshy/subscriptions","organizations_url":"https://api.github.com/users/fisshy/orgs","repos_url":"https://api.github.com/users/fisshy/repos","events_url":"https://api.github.com/users/fisshy/events{/privacy}","received_events_url":"https://api.github.com/users/fisshy/received_events","type":"User","site_admin":false},"repo":{"id":31434220,"name":"react-scroll","full_name":"fisshy/react-scroll","owner":{"login":"fisshy","id":3023875,"avatar_url":"https://avatars.githubusercontent.com/u/3023875?v=3","gravatar_id":"","url":"https://api.github.com/users/fisshy","html_url":"https://github.com/fisshy","followers_url":"https://api.github.com/users/fisshy/followers","following_url":"https://api.github.com/users/fisshy/following{/other_user}","gists_url":"https://api.github.com/users/fisshy/gists{/gist_id}","starred_url":"https://api.github.com/users/fisshy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fisshy/subscriptions","organizations_url":"https://api.github.com/users/fisshy/orgs","repos_url":"https://api.github.com/users/fisshy/repos","events_url":"https://api.github.com/users/fisshy/events{/privacy}","received_events_url":"https://api.github.com/users/fisshy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fisshy/react-scroll","description":"React scroll component","fork":false,"url":"https://api.github.com/repos/fisshy/react-scroll","forks_url":"https://api.github.com/repos/fisshy/react-scroll/forks","keys_url":"https://api.github.com/repos/fisshy/react-scroll/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fisshy/react-scroll/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fisshy/react-scroll/teams","hooks_url":"https://api.github.com/repos/fisshy/react-scroll/hooks","issue_events_url":"https://api.github.com/repos/fisshy/react-scroll/issues/events{/number}","events_url":"https://api.github.com/repos/fisshy/react-scroll/events","assignees_url":"https://api.github.com/repos/fisshy/react-scroll/assignees{/user}","branches_url":"https://api.github.com/repos/fisshy/react-scroll/branches{/branch}","tags_url":"https://api.github.com/repos/fisshy/react-scroll/tags","blobs_url":"https://api.github.com/repos/fisshy/react-scroll/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fisshy/react-scroll/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fisshy/react-scroll/git/refs{/sha}","trees_url":"https://api.github.com/repos/fisshy/react-scroll/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fisshy/react-scroll/statuses/{sha}","languages_url":"https://api.github.com/repos/fisshy/react-scroll/languages","stargazers_url":"https://api.github.com/repos/fisshy/react-scroll/stargazers","contributors_url":"https://api.github.com/repos/fisshy/react-scroll/contributors","subscribers_url":"https://api.github.com/repos/fisshy/react-scroll/subscribers","subscription_url":"https://api.github.com/repos/fisshy/react-scroll/subscription","commits_url":"https://api.github.com/repos/fisshy/react-scroll/commits{/sha}","git_commits_url":"https://api.github.com/repos/fisshy/react-scroll/git/commits{/sha}","comments_url":"https://api.github.com/repos/fisshy/react-scroll/comments{/number}","issue_comment_url":"https://api.github.com/repos/fisshy/react-scroll/issues/comments{/number}","contents_url":"https://api.github.com/repos/fisshy/react-scroll/contents/{+path}","compare_url":"https://api.github.com/repos/fisshy/react-scroll/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fisshy/react-scroll/merges","archive_url":"https://api.github.com/repos/fisshy/react-scroll/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fisshy/react-scroll/downloads","issues_url":"https://api.github.com/repos/fisshy/react-scroll/issues{/number}","pulls_url":"https://api.github.com/repos/fisshy/react-scroll/pulls{/number}","milestones_url":"https://api.github.com/repos/fisshy/react-scroll/milestones{/number}","notifications_url":"https://api.github.com/repos/fisshy/react-scroll/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fisshy/react-scroll/labels{/name}","releases_url":"https://api.github.com/repos/fisshy/react-scroll/releases{/id}","created_at":"2015-02-27T18:56:28Z","updated_at":"2015-03-31T20:02:16Z","pushed_at":"2015-04-03T12:51:06Z","git_url":"git://github.com/fisshy/react-scroll.git","ssh_url":"git@github.com:fisshy/react-scroll.git","clone_url":"https://github.com/fisshy/react-scroll.git","svn_url":"https://github.com/fisshy/react-scroll","homepage":"https://github.com/fisshy/react-scroll/blob/master/README.md","size":256,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fisshy/react-scroll/pulls/9"},"html":{"href":"https://github.com/fisshy/react-scroll/pull/9"},"issue":{"href":"https://api.github.com/repos/fisshy/react-scroll/issues/9"},"comments":{"href":"https://api.github.com/repos/fisshy/react-scroll/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/fisshy/react-scroll/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/fisshy/react-scroll/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fisshy/react-scroll/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/fisshy/react-scroll/statuses/716a88f821fb44f48e978517e8663fd36c183c72"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"fisshy","id":3023875,"avatar_url":"https://avatars.githubusercontent.com/u/3023875?v=3","gravatar_id":"","url":"https://api.github.com/users/fisshy","html_url":"https://github.com/fisshy","followers_url":"https://api.github.com/users/fisshy/followers","following_url":"https://api.github.com/users/fisshy/following{/other_user}","gists_url":"https://api.github.com/users/fisshy/gists{/gist_id}","starred_url":"https://api.github.com/users/fisshy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fisshy/subscriptions","organizations_url":"https://api.github.com/users/fisshy/orgs","repos_url":"https://api.github.com/users/fisshy/repos","events_url":"https://api.github.com/users/fisshy/events{/privacy}","received_events_url":"https://api.github.com/users/fisshy/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":3,"additions":219,"deletions":146,"changed_files":6}}