{"action":"created","comment":{"url":"https://api.github.com/repos/opf/openproject/pulls/comments/36190737","id":36190737,"diff_hunk":"@@ -233,13 +233,13 @@ def association_key(association)\n     it { expect(associated_instance.journals.first.user).to eq(user2) }\n     it 'should update first journal changes' do\n       associations.each do |association|\n-        expect(associated_instance.journals.first.changed_data[association_key association].last).to eq(user2.id)\n+        expect(associated_instance.journals.first.details[association_key association].last).to eq(user2.id)","path":"spec/models/user_deletion_spec.rb","position":39,"original_position":39,"commit_id":"a60951384aa53123f9751d9a490e24a40b4ccc03","original_commit_id":"a60951384aa53123f9751d9a490e24a40b4ccc03","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Line is too long. [108/100]","created_at":"2015-08-04T14:02:47Z","updated_at":"2015-08-04T14:02:47Z","html_url":"https://github.com/opf/openproject/pull/3301#discussion_r36190737","pull_request_url":"https://api.github.com/repos/opf/openproject/pulls/3301","_links":{"self":{"href":"https://api.github.com/repos/opf/openproject/pulls/comments/36190737"},"html":{"href":"https://github.com/opf/openproject/pull/3301#discussion_r36190737"},"pull_request":{"href":"https://api.github.com/repos/opf/openproject/pulls/3301"}}},"pull_request":{"url":"https://api.github.com/repos/opf/openproject/pulls/3301","id":41572791,"html_url":"https://github.com/opf/openproject/pull/3301","diff_url":"https://github.com/opf/openproject/pull/3301.diff","patch_url":"https://github.com/opf/openproject/pull/3301.patch","issue_url":"https://api.github.com/repos/opf/openproject/issues/3301","number":3301,"state":"open","locked":false,"title":"Aggregate diffs","user":{"login":"NobodysNightmare","id":453584,"avatar_url":"https://avatars.githubusercontent.com/u/453584?v=3","gravatar_id":"","url":"https://api.github.com/users/NobodysNightmare","html_url":"https://github.com/NobodysNightmare","followers_url":"https://api.github.com/users/NobodysNightmare/followers","following_url":"https://api.github.com/users/NobodysNightmare/following{/other_user}","gists_url":"https://api.github.com/users/NobodysNightmare/gists{/gist_id}","starred_url":"https://api.github.com/users/NobodysNightmare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NobodysNightmare/subscriptions","organizations_url":"https://api.github.com/users/NobodysNightmare/orgs","repos_url":"https://api.github.com/users/NobodysNightmare/repos","events_url":"https://api.github.com/users/NobodysNightmare/events{/privacy}","received_events_url":"https://api.github.com/users/NobodysNightmare/received_events","type":"User","site_admin":false},"body":"## OpenProject work package\r\n\r\nhttps://community.openproject.org/work_packages/21035\r\n\r\n## Description\r\n\r\nChanges diff view for descriptions etc. to show the diff of the corresponding aggregated journal.\r\nThereby clicking on a diff link in the activity tab (e.g. of the details pane) leads to a correct diff for the displayed activity (in case the description was changed twice).\r\n\r\nThis PR also unifies the methods `details`, `get_changes` and `changed_data` of the `Journal` (which are all aliases of eachother). That means that occurences of `changed_data` have been replaced by `details`. In the long term the goal is to remove one or two methods of this alias chain.\r\n\r\n## Note\r\n\r\nSince the legacy WP view does not aggregate journals, it will now link to unmatching diffs. This is deliberate, since the legacy WP view is going to vanish in OP 5.0.","created_at":"2015-08-04T14:02:25Z","updated_at":"2015-08-04T14:02:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ad41f6870c4cb9ba9b995353ecbf1fe1844e496","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opf/openproject/pulls/3301/commits","review_comments_url":"https://api.github.com/repos/opf/openproject/pulls/3301/comments","review_comment_url":"https://api.github.com/repos/opf/openproject/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opf/openproject/issues/3301/comments","statuses_url":"https://api.github.com/repos/opf/openproject/statuses/a60951384aa53123f9751d9a490e24a40b4ccc03","head":{"label":"NobodysNightmare:feature/aggregated_diffs","ref":"feature/aggregated_diffs","sha":"a60951384aa53123f9751d9a490e24a40b4ccc03","user":{"login":"NobodysNightmare","id":453584,"avatar_url":"https://avatars.githubusercontent.com/u/453584?v=3","gravatar_id":"","url":"https://api.github.com/users/NobodysNightmare","html_url":"https://github.com/NobodysNightmare","followers_url":"https://api.github.com/users/NobodysNightmare/followers","following_url":"https://api.github.com/users/NobodysNightmare/following{/other_user}","gists_url":"https://api.github.com/users/NobodysNightmare/gists{/gist_id}","starred_url":"https://api.github.com/users/NobodysNightmare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NobodysNightmare/subscriptions","organizations_url":"https://api.github.com/users/NobodysNightmare/orgs","repos_url":"https://api.github.com/users/NobodysNightmare/repos","events_url":"https://api.github.com/users/NobodysNightmare/events{/privacy}","received_events_url":"https://api.github.com/users/NobodysNightmare/received_events","type":"User","site_admin":false},"repo":{"id":31598524,"name":"openproject","full_name":"NobodysNightmare/openproject","owner":{"login":"NobodysNightmare","id":453584,"avatar_url":"https://avatars.githubusercontent.com/u/453584?v=3","gravatar_id":"","url":"https://api.github.com/users/NobodysNightmare","html_url":"https://github.com/NobodysNightmare","followers_url":"https://api.github.com/users/NobodysNightmare/followers","following_url":"https://api.github.com/users/NobodysNightmare/following{/other_user}","gists_url":"https://api.github.com/users/NobodysNightmare/gists{/gist_id}","starred_url":"https://api.github.com/users/NobodysNightmare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NobodysNightmare/subscriptions","organizations_url":"https://api.github.com/users/NobodysNightmare/orgs","repos_url":"https://api.github.com/users/NobodysNightmare/repos","events_url":"https://api.github.com/users/NobodysNightmare/events{/privacy}","received_events_url":"https://api.github.com/users/NobodysNightmare/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NobodysNightmare/openproject","description":"OpenProject is a web-based project management system built on Ruby on Rails","fork":true,"url":"https://api.github.com/repos/NobodysNightmare/openproject","forks_url":"https://api.github.com/repos/NobodysNightmare/openproject/forks","keys_url":"https://api.github.com/repos/NobodysNightmare/openproject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NobodysNightmare/openproject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NobodysNightmare/openproject/teams","hooks_url":"https://api.github.com/repos/NobodysNightmare/openproject/hooks","issue_events_url":"https://api.github.com/repos/NobodysNightmare/openproject/issues/events{/number}","events_url":"https://api.github.com/repos/NobodysNightmare/openproject/events","assignees_url":"https://api.github.com/repos/NobodysNightmare/openproject/assignees{/user}","branches_url":"https://api.github.com/repos/NobodysNightmare/openproject/branches{/branch}","tags_url":"https://api.github.com/repos/NobodysNightmare/openproject/tags","blobs_url":"https://api.github.com/repos/NobodysNightmare/openproject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NobodysNightmare/openproject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NobodysNightmare/openproject/git/refs{/sha}","trees_url":"https://api.github.com/repos/NobodysNightmare/openproject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NobodysNightmare/openproject/statuses/{sha}","languages_url":"https://api.github.com/repos/NobodysNightmare/openproject/languages","stargazers_url":"https://api.github.com/repos/NobodysNightmare/openproject/stargazers","contributors_url":"https://api.github.com/repos/NobodysNightmare/openproject/contributors","subscribers_url":"https://api.github.com/repos/NobodysNightmare/openproject/subscribers","subscription_url":"https://api.github.com/repos/NobodysNightmare/openproject/subscription","commits_url":"https://api.github.com/repos/NobodysNightmare/openproject/commits{/sha}","git_commits_url":"https://api.github.com/repos/NobodysNightmare/openproject/git/commits{/sha}","comments_url":"https://api.github.com/repos/NobodysNightmare/openproject/comments{/number}","issue_comment_url":"https://api.github.com/repos/NobodysNightmare/openproject/issues/comments{/number}","contents_url":"https://api.github.com/repos/NobodysNightmare/openproject/contents/{+path}","compare_url":"https://api.github.com/repos/NobodysNightmare/openproject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NobodysNightmare/openproject/merges","archive_url":"https://api.github.com/repos/NobodysNightmare/openproject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NobodysNightmare/openproject/downloads","issues_url":"https://api.github.com/repos/NobodysNightmare/openproject/issues{/number}","pulls_url":"https://api.github.com/repos/NobodysNightmare/openproject/pulls{/number}","milestones_url":"https://api.github.com/repos/NobodysNightmare/openproject/milestones{/number}","notifications_url":"https://api.github.com/repos/NobodysNightmare/openproject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NobodysNightmare/openproject/labels{/name}","releases_url":"https://api.github.com/repos/NobodysNightmare/openproject/releases{/id}","created_at":"2015-03-03T13:00:18Z","updated_at":"2015-04-01T12:02:52Z","pushed_at":"2015-08-04T13:53:55Z","git_url":"git://github.com/NobodysNightmare/openproject.git","ssh_url":"git@github.com:NobodysNightmare/openproject.git","clone_url":"https://github.com/NobodysNightmare/openproject.git","svn_url":"https://github.com/NobodysNightmare/openproject","homepage":"https://www.openproject.org","size":66075,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"opf:dev","ref":"dev","sha":"108160ed88dc1d8e97e21d141f1d0a668c68a5d8","user":{"login":"opf","id":1756674,"avatar_url":"https://avatars.githubusercontent.com/u/1756674?v=3","gravatar_id":"","url":"https://api.github.com/users/opf","html_url":"https://github.com/opf","followers_url":"https://api.github.com/users/opf/followers","following_url":"https://api.github.com/users/opf/following{/other_user}","gists_url":"https://api.github.com/users/opf/gists{/gist_id}","starred_url":"https://api.github.com/users/opf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opf/subscriptions","organizations_url":"https://api.github.com/users/opf/orgs","repos_url":"https://api.github.com/users/opf/repos","events_url":"https://api.github.com/users/opf/events{/privacy}","received_events_url":"https://api.github.com/users/opf/received_events","type":"Organization","site_admin":false},"repo":{"id":6899875,"name":"openproject","full_name":"opf/openproject","owner":{"login":"opf","id":1756674,"avatar_url":"https://avatars.githubusercontent.com/u/1756674?v=3","gravatar_id":"","url":"https://api.github.com/users/opf","html_url":"https://github.com/opf","followers_url":"https://api.github.com/users/opf/followers","following_url":"https://api.github.com/users/opf/following{/other_user}","gists_url":"https://api.github.com/users/opf/gists{/gist_id}","starred_url":"https://api.github.com/users/opf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opf/subscriptions","organizations_url":"https://api.github.com/users/opf/orgs","repos_url":"https://api.github.com/users/opf/repos","events_url":"https://api.github.com/users/opf/events{/privacy}","received_events_url":"https://api.github.com/users/opf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opf/openproject","description":"OpenProject is a web-based project management system built on Ruby on Rails","fork":false,"url":"https://api.github.com/repos/opf/openproject","forks_url":"https://api.github.com/repos/opf/openproject/forks","keys_url":"https://api.github.com/repos/opf/openproject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opf/openproject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opf/openproject/teams","hooks_url":"https://api.github.com/repos/opf/openproject/hooks","issue_events_url":"https://api.github.com/repos/opf/openproject/issues/events{/number}","events_url":"https://api.github.com/repos/opf/openproject/events","assignees_url":"https://api.github.com/repos/opf/openproject/assignees{/user}","branches_url":"https://api.github.com/repos/opf/openproject/branches{/branch}","tags_url":"https://api.github.com/repos/opf/openproject/tags","blobs_url":"https://api.github.com/repos/opf/openproject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opf/openproject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opf/openproject/git/refs{/sha}","trees_url":"https://api.github.com/repos/opf/openproject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opf/openproject/statuses/{sha}","languages_url":"https://api.github.com/repos/opf/openproject/languages","stargazers_url":"https://api.github.com/repos/opf/openproject/stargazers","contributors_url":"https://api.github.com/repos/opf/openproject/contributors","subscribers_url":"https://api.github.com/repos/opf/openproject/subscribers","subscription_url":"https://api.github.com/repos/opf/openproject/subscription","commits_url":"https://api.github.com/repos/opf/openproject/commits{/sha}","git_commits_url":"https://api.github.com/repos/opf/openproject/git/commits{/sha}","comments_url":"https://api.github.com/repos/opf/openproject/comments{/number}","issue_comment_url":"https://api.github.com/repos/opf/openproject/issues/comments{/number}","contents_url":"https://api.github.com/repos/opf/openproject/contents/{+path}","compare_url":"https://api.github.com/repos/opf/openproject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opf/openproject/merges","archive_url":"https://api.github.com/repos/opf/openproject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opf/openproject/downloads","issues_url":"https://api.github.com/repos/opf/openproject/issues{/number}","pulls_url":"https://api.github.com/repos/opf/openproject/pulls{/number}","milestones_url":"https://api.github.com/repos/opf/openproject/milestones{/number}","notifications_url":"https://api.github.com/repos/opf/openproject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opf/openproject/labels{/name}","releases_url":"https://api.github.com/repos/opf/openproject/releases{/id}","created_at":"2012-11-28T09:59:11Z","updated_at":"2015-08-03T14:57:12Z","pushed_at":"2015-08-04T14:02:25Z","git_url":"git://github.com/opf/openproject.git","ssh_url":"git@github.com:opf/openproject.git","clone_url":"https://github.com/opf/openproject.git","svn_url":"https://github.com/opf/openproject","homepage":"https://www.openproject.org","size":205953,"stargazers_count":695,"watchers_count":695,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":293,"mirror_url":null,"open_issues_count":26,"forks":293,"open_issues":26,"watchers":695,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/opf/openproject/pulls/3301"},"html":{"href":"https://github.com/opf/openproject/pull/3301"},"issue":{"href":"https://api.github.com/repos/opf/openproject/issues/3301"},"comments":{"href":"https://api.github.com/repos/opf/openproject/issues/3301/comments"},"review_comments":{"href":"https://api.github.com/repos/opf/openproject/pulls/3301/comments"},"review_comment":{"href":"https://api.github.com/repos/opf/openproject/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opf/openproject/pulls/3301/commits"},"statuses":{"href":"https://api.github.com/repos/opf/openproject/statuses/a60951384aa53123f9751d9a490e24a40b4ccc03"}}}}