{"action":"created","comment":{"url":"https://api.github.com/repos/CanalTP/navitia/pulls/comments/25876803","id":25876803,"diff_hunk":"@@ -281,11 +263,10 @@ RAPTOR::compute_nm_all(const std::vector<std::pair<type::EntryPoint, vec_stop_po\n         for (const auto& n_stop_point : n_point.second)\n             calc_dep.push_back(n_stop_point);\n \n-    auto calc_dep_solutions = init_departures(calc_dep, departure_datetime, clockwise, disruption_active);\n     clear(clockwise, bound);\n-    init(calc_dep_solutions, {}, bound, clockwise); // no exit condition (should be improved)\n+    init(calc_dep, departure_datetime, clockwise, accessibilite_params.properties);","path":"source/routing/raptor.cpp","position":152,"original_position":152,"commit_id":"936e04577bf3923267dd6bc477ddd920916482fd","original_commit_id":"936e04577bf3923267dd6bc477ddd920916482fd","user":{"login":"antoine-de","id":3987698,"avatar_url":"https://avatars.githubusercontent.com/u/3987698?v=3","gravatar_id":"","url":"https://api.github.com/users/antoine-de","html_url":"https://github.com/antoine-de","followers_url":"https://api.github.com/users/antoine-de/followers","following_url":"https://api.github.com/users/antoine-de/following{/other_user}","gists_url":"https://api.github.com/users/antoine-de/gists{/gist_id}","starred_url":"https://api.github.com/users/antoine-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoine-de/subscriptions","organizations_url":"https://api.github.com/users/antoine-de/orgs","repos_url":"https://api.github.com/users/antoine-de/repos","events_url":"https://api.github.com/users/antoine-de/events{/privacy}","received_events_url":"https://api.github.com/users/antoine-de/received_events","type":"User","site_admin":false},"body":"don't you want to call first_raptor_loop there ?","created_at":"2015-03-05T16:26:02Z","updated_at":"2015-03-05T16:26:02Z","html_url":"https://github.com/CanalTP/navitia/pull/934#discussion_r25876803","pull_request_url":"https://api.github.com/repos/CanalTP/navitia/pulls/934","_links":{"self":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/comments/25876803"},"html":{"href":"https://github.com/CanalTP/navitia/pull/934#discussion_r25876803"},"pull_request":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/934"}}},"pull_request":{"url":"https://api.github.com/repos/CanalTP/navitia/pulls/934","id":30548706,"html_url":"https://github.com/CanalTP/navitia/pull/934","diff_url":"https://github.com/CanalTP/navitia/pull/934.diff","patch_url":"https://github.com/CanalTP/navitia/pull/934.patch","issue_url":"https://api.github.com/repos/CanalTP/navitia/issues/934","number":934,"state":"open","locked":false,"title":"raptor: remove weakly dominated solutions and (now useless) b_dest","user":{"login":"TeXitoi","id":5787066,"avatar_url":"https://avatars.githubusercontent.com/u/5787066?v=3","gravatar_id":"","url":"https://api.github.com/users/TeXitoi","html_url":"https://github.com/TeXitoi","followers_url":"https://api.github.com/users/TeXitoi/followers","following_url":"https://api.github.com/users/TeXitoi/following{/other_user}","gists_url":"https://api.github.com/users/TeXitoi/gists{/gist_id}","starred_url":"https://api.github.com/users/TeXitoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeXitoi/subscriptions","organizations_url":"https://api.github.com/users/TeXitoi/orgs","repos_url":"https://api.github.com/users/TeXitoi/repos","events_url":"https://api.github.com/users/TeXitoi/events{/privacy}","received_events_url":"https://api.github.com/users/TeXitoi/received_events","type":"User","site_admin":false},"body":"Solutions that end at the same time, but begin later and with more transfer will not be found with this version. Performances are better than before (but this performance improvement must not be assumed acquired). See the commented test for an example.","created_at":"2015-03-05T11:19:12Z","updated_at":"2015-03-05T16:26:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81a69c86e441804bff2e2dc9cf2f2fe31e69739a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CanalTP/navitia/pulls/934/commits","review_comments_url":"https://api.github.com/repos/CanalTP/navitia/pulls/934/comments","review_comment_url":"https://api.github.com/repos/CanalTP/navitia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CanalTP/navitia/issues/934/comments","statuses_url":"https://api.github.com/repos/CanalTP/navitia/statuses/936e04577bf3923267dd6bc477ddd920916482fd","head":{"label":"TeXitoi:reader-cleanup","ref":"reader-cleanup","sha":"936e04577bf3923267dd6bc477ddd920916482fd","user":{"login":"TeXitoi","id":5787066,"avatar_url":"https://avatars.githubusercontent.com/u/5787066?v=3","gravatar_id":"","url":"https://api.github.com/users/TeXitoi","html_url":"https://github.com/TeXitoi","followers_url":"https://api.github.com/users/TeXitoi/followers","following_url":"https://api.github.com/users/TeXitoi/following{/other_user}","gists_url":"https://api.github.com/users/TeXitoi/gists{/gist_id}","starred_url":"https://api.github.com/users/TeXitoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeXitoi/subscriptions","organizations_url":"https://api.github.com/users/TeXitoi/orgs","repos_url":"https://api.github.com/users/TeXitoi/repos","events_url":"https://api.github.com/users/TeXitoi/events{/privacy}","received_events_url":"https://api.github.com/users/TeXitoi/received_events","type":"User","site_admin":false},"repo":{"id":23435249,"name":"navitia","full_name":"TeXitoi/navitia","owner":{"login":"TeXitoi","id":5787066,"avatar_url":"https://avatars.githubusercontent.com/u/5787066?v=3","gravatar_id":"","url":"https://api.github.com/users/TeXitoi","html_url":"https://github.com/TeXitoi","followers_url":"https://api.github.com/users/TeXitoi/followers","following_url":"https://api.github.com/users/TeXitoi/following{/other_user}","gists_url":"https://api.github.com/users/TeXitoi/gists{/gist_id}","starred_url":"https://api.github.com/users/TeXitoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeXitoi/subscriptions","organizations_url":"https://api.github.com/users/TeXitoi/orgs","repos_url":"https://api.github.com/users/TeXitoi/repos","events_url":"https://api.github.com/users/TeXitoi/events{/privacy}","received_events_url":"https://api.github.com/users/TeXitoi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TeXitoi/navitia","description":"The REST API to build cool stuff with public transport","fork":true,"url":"https://api.github.com/repos/TeXitoi/navitia","forks_url":"https://api.github.com/repos/TeXitoi/navitia/forks","keys_url":"https://api.github.com/repos/TeXitoi/navitia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TeXitoi/navitia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TeXitoi/navitia/teams","hooks_url":"https://api.github.com/repos/TeXitoi/navitia/hooks","issue_events_url":"https://api.github.com/repos/TeXitoi/navitia/issues/events{/number}","events_url":"https://api.github.com/repos/TeXitoi/navitia/events","assignees_url":"https://api.github.com/repos/TeXitoi/navitia/assignees{/user}","branches_url":"https://api.github.com/repos/TeXitoi/navitia/branches{/branch}","tags_url":"https://api.github.com/repos/TeXitoi/navitia/tags","blobs_url":"https://api.github.com/repos/TeXitoi/navitia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TeXitoi/navitia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TeXitoi/navitia/git/refs{/sha}","trees_url":"https://api.github.com/repos/TeXitoi/navitia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TeXitoi/navitia/statuses/{sha}","languages_url":"https://api.github.com/repos/TeXitoi/navitia/languages","stargazers_url":"https://api.github.com/repos/TeXitoi/navitia/stargazers","contributors_url":"https://api.github.com/repos/TeXitoi/navitia/contributors","subscribers_url":"https://api.github.com/repos/TeXitoi/navitia/subscribers","subscription_url":"https://api.github.com/repos/TeXitoi/navitia/subscription","commits_url":"https://api.github.com/repos/TeXitoi/navitia/commits{/sha}","git_commits_url":"https://api.github.com/repos/TeXitoi/navitia/git/commits{/sha}","comments_url":"https://api.github.com/repos/TeXitoi/navitia/comments{/number}","issue_comment_url":"https://api.github.com/repos/TeXitoi/navitia/issues/comments{/number}","contents_url":"https://api.github.com/repos/TeXitoi/navitia/contents/{+path}","compare_url":"https://api.github.com/repos/TeXitoi/navitia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TeXitoi/navitia/merges","archive_url":"https://api.github.com/repos/TeXitoi/navitia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TeXitoi/navitia/downloads","issues_url":"https://api.github.com/repos/TeXitoi/navitia/issues{/number}","pulls_url":"https://api.github.com/repos/TeXitoi/navitia/pulls{/number}","milestones_url":"https://api.github.com/repos/TeXitoi/navitia/milestones{/number}","notifications_url":"https://api.github.com/repos/TeXitoi/navitia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TeXitoi/navitia/labels{/name}","releases_url":"https://api.github.com/repos/TeXitoi/navitia/releases{/id}","created_at":"2014-08-28T16:35:05Z","updated_at":"2014-09-09T14:32:07Z","pushed_at":"2015-03-05T15:55:02Z","git_url":"git://github.com/TeXitoi/navitia.git","ssh_url":"git@github.com:TeXitoi/navitia.git","clone_url":"https://github.com/TeXitoi/navitia.git","svn_url":"https://github.com/TeXitoi/navitia","homepage":"http://www.navitia.io","size":23376,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"CanalTP:raptor-solution-reader","ref":"raptor-solution-reader","sha":"9ec720670fbccd88490da246b94ee46508ffac4b","user":{"login":"CanalTP","id":2743985,"avatar_url":"https://avatars.githubusercontent.com/u/2743985?v=3","gravatar_id":"","url":"https://api.github.com/users/CanalTP","html_url":"https://github.com/CanalTP","followers_url":"https://api.github.com/users/CanalTP/followers","following_url":"https://api.github.com/users/CanalTP/following{/other_user}","gists_url":"https://api.github.com/users/CanalTP/gists{/gist_id}","starred_url":"https://api.github.com/users/CanalTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanalTP/subscriptions","organizations_url":"https://api.github.com/users/CanalTP/orgs","repos_url":"https://api.github.com/users/CanalTP/repos","events_url":"https://api.github.com/users/CanalTP/events{/privacy}","received_events_url":"https://api.github.com/users/CanalTP/received_events","type":"Organization","site_admin":false},"repo":{"id":10797333,"name":"navitia","full_name":"CanalTP/navitia","owner":{"login":"CanalTP","id":2743985,"avatar_url":"https://avatars.githubusercontent.com/u/2743985?v=3","gravatar_id":"","url":"https://api.github.com/users/CanalTP","html_url":"https://github.com/CanalTP","followers_url":"https://api.github.com/users/CanalTP/followers","following_url":"https://api.github.com/users/CanalTP/following{/other_user}","gists_url":"https://api.github.com/users/CanalTP/gists{/gist_id}","starred_url":"https://api.github.com/users/CanalTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanalTP/subscriptions","organizations_url":"https://api.github.com/users/CanalTP/orgs","repos_url":"https://api.github.com/users/CanalTP/repos","events_url":"https://api.github.com/users/CanalTP/events{/privacy}","received_events_url":"https://api.github.com/users/CanalTP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CanalTP/navitia","description":"The REST API to build cool stuff with public transport","fork":false,"url":"https://api.github.com/repos/CanalTP/navitia","forks_url":"https://api.github.com/repos/CanalTP/navitia/forks","keys_url":"https://api.github.com/repos/CanalTP/navitia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CanalTP/navitia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CanalTP/navitia/teams","hooks_url":"https://api.github.com/repos/CanalTP/navitia/hooks","issue_events_url":"https://api.github.com/repos/CanalTP/navitia/issues/events{/number}","events_url":"https://api.github.com/repos/CanalTP/navitia/events","assignees_url":"https://api.github.com/repos/CanalTP/navitia/assignees{/user}","branches_url":"https://api.github.com/repos/CanalTP/navitia/branches{/branch}","tags_url":"https://api.github.com/repos/CanalTP/navitia/tags","blobs_url":"https://api.github.com/repos/CanalTP/navitia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CanalTP/navitia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CanalTP/navitia/git/refs{/sha}","trees_url":"https://api.github.com/repos/CanalTP/navitia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CanalTP/navitia/statuses/{sha}","languages_url":"https://api.github.com/repos/CanalTP/navitia/languages","stargazers_url":"https://api.github.com/repos/CanalTP/navitia/stargazers","contributors_url":"https://api.github.com/repos/CanalTP/navitia/contributors","subscribers_url":"https://api.github.com/repos/CanalTP/navitia/subscribers","subscription_url":"https://api.github.com/repos/CanalTP/navitia/subscription","commits_url":"https://api.github.com/repos/CanalTP/navitia/commits{/sha}","git_commits_url":"https://api.github.com/repos/CanalTP/navitia/git/commits{/sha}","comments_url":"https://api.github.com/repos/CanalTP/navitia/comments{/number}","issue_comment_url":"https://api.github.com/repos/CanalTP/navitia/issues/comments{/number}","contents_url":"https://api.github.com/repos/CanalTP/navitia/contents/{+path}","compare_url":"https://api.github.com/repos/CanalTP/navitia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CanalTP/navitia/merges","archive_url":"https://api.github.com/repos/CanalTP/navitia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CanalTP/navitia/downloads","issues_url":"https://api.github.com/repos/CanalTP/navitia/issues{/number}","pulls_url":"https://api.github.com/repos/CanalTP/navitia/pulls{/number}","milestones_url":"https://api.github.com/repos/CanalTP/navitia/milestones{/number}","notifications_url":"https://api.github.com/repos/CanalTP/navitia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CanalTP/navitia/labels{/name}","releases_url":"https://api.github.com/repos/CanalTP/navitia/releases{/id}","created_at":"2013-06-19T15:34:30Z","updated_at":"2015-03-04T22:45:31Z","pushed_at":"2015-03-04T16:48:59Z","git_url":"git://github.com/CanalTP/navitia.git","ssh_url":"git@github.com:CanalTP/navitia.git","clone_url":"https://github.com/CanalTP/navitia.git","svn_url":"https://github.com/CanalTP/navitia","homepage":"http://www.navitia.io","size":32468,"stargazers_count":90,"watchers_count":90,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":19,"forks":26,"open_issues":19,"watchers":90,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/934"},"html":{"href":"https://github.com/CanalTP/navitia/pull/934"},"issue":{"href":"https://api.github.com/repos/CanalTP/navitia/issues/934"},"comments":{"href":"https://api.github.com/repos/CanalTP/navitia/issues/934/comments"},"review_comments":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/934/comments"},"review_comment":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/934/commits"},"statuses":{"href":"https://api.github.com/repos/CanalTP/navitia/statuses/936e04577bf3923267dd6bc477ddd920916482fd"}}}}