{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/35635490","id":35635490,"diff_hunk":"@@ -181,7 +181,7 @@ trait TestingJobManager extends FlinkActor {\n           currentJobs.get(jobID) match {\n             case Some((graph, jobInfo)) =>\n               val flinkAccumulators = graph.getFlinkAccumulators\n-              val userAccumulators = graph.aggregateUserAccumulators\n+              val userAccumulators = graph.aggregateSmallUserAccumulators","path":"flink-runtime/src/test/scala/org/apache/flink/runtime/testingUtils/TestingJobManager.scala","position":5,"original_position":5,"commit_id":"13acab525cb733b8ad064153b5a8b0da3cc7f56c","original_commit_id":"13acab525cb733b8ad064153b5a8b0da3cc7f56c","user":{"login":"mxm","id":837221,"avatar_url":"https://avatars.githubusercontent.com/u/837221?v=3","gravatar_id":"","url":"https://api.github.com/users/mxm","html_url":"https://github.com/mxm","followers_url":"https://api.github.com/users/mxm/followers","following_url":"https://api.github.com/users/mxm/following{/other_user}","gists_url":"https://api.github.com/users/mxm/gists{/gist_id}","starred_url":"https://api.github.com/users/mxm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxm/subscriptions","organizations_url":"https://api.github.com/users/mxm/orgs","repos_url":"https://api.github.com/users/mxm/repos","events_url":"https://api.github.com/users/mxm/events{/privacy}","received_events_url":"https://api.github.com/users/mxm/received_events","type":"User","site_admin":false},"body":"This should also incorporate the blob cached accumulator results.","created_at":"2015-07-28T11:01:02Z","updated_at":"2015-07-28T11:01:02Z","html_url":"https://github.com/apache/flink/pull/934#discussion_r35635490","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/934","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/35635490"},"html":{"href":"https://github.com/apache/flink/pull/934#discussion_r35635490"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/934"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/934","id":40768417,"html_url":"https://github.com/apache/flink/pull/934","diff_url":"https://github.com/apache/flink/pull/934.diff","patch_url":"https://github.com/apache/flink/pull/934.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/934","number":934,"state":"open","locked":false,"title":"Framesize fix","user":{"login":"kl0u","id":2405800,"avatar_url":"https://avatars.githubusercontent.com/u/2405800?v=3","gravatar_id":"","url":"https://api.github.com/users/kl0u","html_url":"https://github.com/kl0u","followers_url":"https://api.github.com/users/kl0u/followers","following_url":"https://api.github.com/users/kl0u/following{/other_user}","gists_url":"https://api.github.com/users/kl0u/gists{/gist_id}","starred_url":"https://api.github.com/users/kl0u/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kl0u/subscriptions","organizations_url":"https://api.github.com/users/kl0u/orgs","repos_url":"https://api.github.com/users/kl0u/repos","events_url":"https://api.github.com/users/kl0u/events{/privacy}","received_events_url":"https://api.github.com/users/kl0u/received_events","type":"User","site_admin":false},"body":"In Apache Flink the results of the collect() call were returned through akka to the client. This led to an inherent limitation to the size of the output of a job, as this could not exceed the akka.framesize size. In other case, akka would drop the message.\r\n\r\nTo alleviate this, without dropping the benefits brought by akka and its out-of-the-box efficiency for small-sized results, we decided to keep forwarding the non-oversized (i.e. smaller than the akka.framesize) results through akka, and use the BlobCache module for the forwarding the oversized (large) ones.\r\n\r\nNow the JobManager receives end merges the small accumulators (as before), and simply forwards to the Client the keys to the blobs storing the oversized ones. Now it is the responsibility of the Client to do the final merging between oversized and non-oversized accumulators.","created_at":"2015-07-24T12:06:01Z","updated_at":"2015-07-28T11:01:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27af080b8ccbe28058560629b7e59f92643370e3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/934/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/934/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/934/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/13acab525cb733b8ad064153b5a8b0da3cc7f56c","head":{"label":"kl0u:framesize_fix","ref":"framesize_fix","sha":"13acab525cb733b8ad064153b5a8b0da3cc7f56c","user":{"login":"kl0u","id":2405800,"avatar_url":"https://avatars.githubusercontent.com/u/2405800?v=3","gravatar_id":"","url":"https://api.github.com/users/kl0u","html_url":"https://github.com/kl0u","followers_url":"https://api.github.com/users/kl0u/followers","following_url":"https://api.github.com/users/kl0u/following{/other_user}","gists_url":"https://api.github.com/users/kl0u/gists{/gist_id}","starred_url":"https://api.github.com/users/kl0u/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kl0u/subscriptions","organizations_url":"https://api.github.com/users/kl0u/orgs","repos_url":"https://api.github.com/users/kl0u/repos","events_url":"https://api.github.com/users/kl0u/events{/privacy}","received_events_url":"https://api.github.com/users/kl0u/received_events","type":"User","site_admin":false},"repo":{"id":38500934,"name":"flink","full_name":"kl0u/flink","owner":{"login":"kl0u","id":2405800,"avatar_url":"https://avatars.githubusercontent.com/u/2405800?v=3","gravatar_id":"","url":"https://api.github.com/users/kl0u","html_url":"https://github.com/kl0u","followers_url":"https://api.github.com/users/kl0u/followers","following_url":"https://api.github.com/users/kl0u/following{/other_user}","gists_url":"https://api.github.com/users/kl0u/gists{/gist_id}","starred_url":"https://api.github.com/users/kl0u/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kl0u/subscriptions","organizations_url":"https://api.github.com/users/kl0u/orgs","repos_url":"https://api.github.com/users/kl0u/repos","events_url":"https://api.github.com/users/kl0u/events{/privacy}","received_events_url":"https://api.github.com/users/kl0u/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kl0u/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/kl0u/flink","forks_url":"https://api.github.com/repos/kl0u/flink/forks","keys_url":"https://api.github.com/repos/kl0u/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kl0u/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kl0u/flink/teams","hooks_url":"https://api.github.com/repos/kl0u/flink/hooks","issue_events_url":"https://api.github.com/repos/kl0u/flink/issues/events{/number}","events_url":"https://api.github.com/repos/kl0u/flink/events","assignees_url":"https://api.github.com/repos/kl0u/flink/assignees{/user}","branches_url":"https://api.github.com/repos/kl0u/flink/branches{/branch}","tags_url":"https://api.github.com/repos/kl0u/flink/tags","blobs_url":"https://api.github.com/repos/kl0u/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kl0u/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kl0u/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/kl0u/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kl0u/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/kl0u/flink/languages","stargazers_url":"https://api.github.com/repos/kl0u/flink/stargazers","contributors_url":"https://api.github.com/repos/kl0u/flink/contributors","subscribers_url":"https://api.github.com/repos/kl0u/flink/subscribers","subscription_url":"https://api.github.com/repos/kl0u/flink/subscription","commits_url":"https://api.github.com/repos/kl0u/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/kl0u/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/kl0u/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/kl0u/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/kl0u/flink/contents/{+path}","compare_url":"https://api.github.com/repos/kl0u/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kl0u/flink/merges","archive_url":"https://api.github.com/repos/kl0u/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kl0u/flink/downloads","issues_url":"https://api.github.com/repos/kl0u/flink/issues{/number}","pulls_url":"https://api.github.com/repos/kl0u/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/kl0u/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/kl0u/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kl0u/flink/labels{/name}","releases_url":"https://api.github.com/repos/kl0u/flink/releases{/id}","created_at":"2015-07-03T16:09:57Z","updated_at":"2015-07-03T16:10:08Z","pushed_at":"2015-07-27T10:56:01Z","git_url":"git://github.com/kl0u/flink.git","ssh_url":"git@github.com:kl0u/flink.git","clone_url":"https://github.com/kl0u/flink.git","svn_url":"https://github.com/kl0u/flink","homepage":null,"size":55545,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"efca79cfb7b496b4bec70561cc94af069c644ef2","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","created_at":"2014-06-07T07:00:10Z","updated_at":"2015-07-28T06:31:48Z","pushed_at":"2015-07-28T10:02:27Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":2506602,"stargazers_count":522,"watchers_count":522,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":345,"mirror_url":"git://git.apache.org/incubator-flink.git","open_issues_count":66,"forks":345,"open_issues":66,"watchers":522,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/934"},"html":{"href":"https://github.com/apache/flink/pull/934"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/934"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/934/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/934/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/934/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/13acab525cb733b8ad064153b5a8b0da3cc7f56c"}}}}