{"action":"closed","number":48,"pull_request":{"url":"https://api.github.com/repos/aptible/docker-nginx/pulls/48","id":41050112,"html_url":"https://github.com/aptible/docker-nginx/pull/48","diff_url":"https://github.com/aptible/docker-nginx/pull/48.diff","patch_url":"https://github.com/aptible/docker-nginx/pull/48.patch","issue_url":"https://api.github.com/repos/aptible/docker-nginx/issues/48","number":48,"state":"closed","locked":false,"title":"Allow underscores in header names","user":{"login":"aaw","id":274931,"avatar_url":"https://avatars.githubusercontent.com/u/274931?v=3","gravatar_id":"","url":"https://api.github.com/users/aaw","html_url":"https://github.com/aaw","followers_url":"https://api.github.com/users/aaw/followers","following_url":"https://api.github.com/users/aaw/following{/other_user}","gists_url":"https://api.github.com/users/aaw/gists{/gist_id}","starred_url":"https://api.github.com/users/aaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaw/subscriptions","organizations_url":"https://api.github.com/users/aaw/orgs","repos_url":"https://api.github.com/users/aaw/repos","events_url":"https://api.github.com/users/aaw/events{/privacy}","received_events_url":"https://api.github.com/users/aaw/received_events","type":"User","site_admin":false},"body":"Headers with underscores in their names are perfectly valid, but NGiNX strips them by default to prevent ambiguities when mapping headers to CGI variables (http://wiki.nginx.org/Pitfalls#Missing_.28disappearing.29_HTTP_headers).\r\n\r\nHeaders with underscores are valid and many apps use them so we should keep them from being stripped. This patch turns the `underscores_in_headers` option on at the http level in the config.\r\n\r\nBig thanks to @fancyremarker for identifying this as the underlying cause of some headers not getting through!","created_at":"2015-07-28T19:25:48Z","updated_at":"2015-07-28T19:31:30Z","closed_at":"2015-07-28T19:31:30Z","merged_at":"2015-07-28T19:31:30Z","merge_commit_sha":"3c2e7d4553e665d2133618f8136818d8ecdfd3c8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aptible/docker-nginx/pulls/48/commits","review_comments_url":"https://api.github.com/repos/aptible/docker-nginx/pulls/48/comments","review_comment_url":"https://api.github.com/repos/aptible/docker-nginx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aptible/docker-nginx/issues/48/comments","statuses_url":"https://api.github.com/repos/aptible/docker-nginx/statuses/1bd4dffa2fd21b186d043f8490d6a93ced86eb51","head":{"label":"aaw:allow-underscores-in-headers","ref":"allow-underscores-in-headers","sha":"1bd4dffa2fd21b186d043f8490d6a93ced86eb51","user":{"login":"aaw","id":274931,"avatar_url":"https://avatars.githubusercontent.com/u/274931?v=3","gravatar_id":"","url":"https://api.github.com/users/aaw","html_url":"https://github.com/aaw","followers_url":"https://api.github.com/users/aaw/followers","following_url":"https://api.github.com/users/aaw/following{/other_user}","gists_url":"https://api.github.com/users/aaw/gists{/gist_id}","starred_url":"https://api.github.com/users/aaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaw/subscriptions","organizations_url":"https://api.github.com/users/aaw/orgs","repos_url":"https://api.github.com/users/aaw/repos","events_url":"https://api.github.com/users/aaw/events{/privacy}","received_events_url":"https://api.github.com/users/aaw/received_events","type":"User","site_admin":false},"repo":{"id":25404646,"name":"docker-nginx","full_name":"aaw/docker-nginx","owner":{"login":"aaw","id":274931,"avatar_url":"https://avatars.githubusercontent.com/u/274931?v=3","gravatar_id":"","url":"https://api.github.com/users/aaw","html_url":"https://github.com/aaw","followers_url":"https://api.github.com/users/aaw/followers","following_url":"https://api.github.com/users/aaw/following{/other_user}","gists_url":"https://api.github.com/users/aaw/gists{/gist_id}","starred_url":"https://api.github.com/users/aaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaw/subscriptions","organizations_url":"https://api.github.com/users/aaw/orgs","repos_url":"https://api.github.com/users/aaw/repos","events_url":"https://api.github.com/users/aaw/events{/privacy}","received_events_url":"https://api.github.com/users/aaw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aaw/docker-nginx","description":"NGiNX HTTP server","fork":true,"url":"https://api.github.com/repos/aaw/docker-nginx","forks_url":"https://api.github.com/repos/aaw/docker-nginx/forks","keys_url":"https://api.github.com/repos/aaw/docker-nginx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aaw/docker-nginx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aaw/docker-nginx/teams","hooks_url":"https://api.github.com/repos/aaw/docker-nginx/hooks","issue_events_url":"https://api.github.com/repos/aaw/docker-nginx/issues/events{/number}","events_url":"https://api.github.com/repos/aaw/docker-nginx/events","assignees_url":"https://api.github.com/repos/aaw/docker-nginx/assignees{/user}","branches_url":"https://api.github.com/repos/aaw/docker-nginx/branches{/branch}","tags_url":"https://api.github.com/repos/aaw/docker-nginx/tags","blobs_url":"https://api.github.com/repos/aaw/docker-nginx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aaw/docker-nginx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aaw/docker-nginx/git/refs{/sha}","trees_url":"https://api.github.com/repos/aaw/docker-nginx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aaw/docker-nginx/statuses/{sha}","languages_url":"https://api.github.com/repos/aaw/docker-nginx/languages","stargazers_url":"https://api.github.com/repos/aaw/docker-nginx/stargazers","contributors_url":"https://api.github.com/repos/aaw/docker-nginx/contributors","subscribers_url":"https://api.github.com/repos/aaw/docker-nginx/subscribers","subscription_url":"https://api.github.com/repos/aaw/docker-nginx/subscription","commits_url":"https://api.github.com/repos/aaw/docker-nginx/commits{/sha}","git_commits_url":"https://api.github.com/repos/aaw/docker-nginx/git/commits{/sha}","comments_url":"https://api.github.com/repos/aaw/docker-nginx/comments{/number}","issue_comment_url":"https://api.github.com/repos/aaw/docker-nginx/issues/comments{/number}","contents_url":"https://api.github.com/repos/aaw/docker-nginx/contents/{+path}","compare_url":"https://api.github.com/repos/aaw/docker-nginx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aaw/docker-nginx/merges","archive_url":"https://api.github.com/repos/aaw/docker-nginx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aaw/docker-nginx/downloads","issues_url":"https://api.github.com/repos/aaw/docker-nginx/issues{/number}","pulls_url":"https://api.github.com/repos/aaw/docker-nginx/pulls{/number}","milestones_url":"https://api.github.com/repos/aaw/docker-nginx/milestones{/number}","notifications_url":"https://api.github.com/repos/aaw/docker-nginx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aaw/docker-nginx/labels{/name}","releases_url":"https://api.github.com/repos/aaw/docker-nginx/releases{/id}","created_at":"2014-10-18T17:36:00Z","updated_at":"2015-05-22T20:19:59Z","pushed_at":"2015-07-28T19:24:44Z","git_url":"git://github.com/aaw/docker-nginx.git","ssh_url":"git@github.com:aaw/docker-nginx.git","clone_url":"https://github.com/aaw/docker-nginx.git","svn_url":"https://github.com/aaw/docker-nginx","homepage":"","size":157,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aptible:master","ref":"master","sha":"61427bbc8d5323cad36ab06c6ac2847feed998f6","user":{"login":"aptible","id":4594193,"avatar_url":"https://avatars.githubusercontent.com/u/4594193?v=3","gravatar_id":"","url":"https://api.github.com/users/aptible","html_url":"https://github.com/aptible","followers_url":"https://api.github.com/users/aptible/followers","following_url":"https://api.github.com/users/aptible/following{/other_user}","gists_url":"https://api.github.com/users/aptible/gists{/gist_id}","starred_url":"https://api.github.com/users/aptible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aptible/subscriptions","organizations_url":"https://api.github.com/users/aptible/orgs","repos_url":"https://api.github.com/users/aptible/repos","events_url":"https://api.github.com/users/aptible/events{/privacy}","received_events_url":"https://api.github.com/users/aptible/received_events","type":"Organization","site_admin":false},"repo":{"id":17886962,"name":"docker-nginx","full_name":"aptible/docker-nginx","owner":{"login":"aptible","id":4594193,"avatar_url":"https://avatars.githubusercontent.com/u/4594193?v=3","gravatar_id":"","url":"https://api.github.com/users/aptible","html_url":"https://github.com/aptible","followers_url":"https://api.github.com/users/aptible/followers","following_url":"https://api.github.com/users/aptible/following{/other_user}","gists_url":"https://api.github.com/users/aptible/gists{/gist_id}","starred_url":"https://api.github.com/users/aptible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aptible/subscriptions","organizations_url":"https://api.github.com/users/aptible/orgs","repos_url":"https://api.github.com/users/aptible/repos","events_url":"https://api.github.com/users/aptible/events{/privacy}","received_events_url":"https://api.github.com/users/aptible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aptible/docker-nginx","description":"NGiNX HTTP server","fork":false,"url":"https://api.github.com/repos/aptible/docker-nginx","forks_url":"https://api.github.com/repos/aptible/docker-nginx/forks","keys_url":"https://api.github.com/repos/aptible/docker-nginx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aptible/docker-nginx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aptible/docker-nginx/teams","hooks_url":"https://api.github.com/repos/aptible/docker-nginx/hooks","issue_events_url":"https://api.github.com/repos/aptible/docker-nginx/issues/events{/number}","events_url":"https://api.github.com/repos/aptible/docker-nginx/events","assignees_url":"https://api.github.com/repos/aptible/docker-nginx/assignees{/user}","branches_url":"https://api.github.com/repos/aptible/docker-nginx/branches{/branch}","tags_url":"https://api.github.com/repos/aptible/docker-nginx/tags","blobs_url":"https://api.github.com/repos/aptible/docker-nginx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aptible/docker-nginx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aptible/docker-nginx/git/refs{/sha}","trees_url":"https://api.github.com/repos/aptible/docker-nginx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aptible/docker-nginx/statuses/{sha}","languages_url":"https://api.github.com/repos/aptible/docker-nginx/languages","stargazers_url":"https://api.github.com/repos/aptible/docker-nginx/stargazers","contributors_url":"https://api.github.com/repos/aptible/docker-nginx/contributors","subscribers_url":"https://api.github.com/repos/aptible/docker-nginx/subscribers","subscription_url":"https://api.github.com/repos/aptible/docker-nginx/subscription","commits_url":"https://api.github.com/repos/aptible/docker-nginx/commits{/sha}","git_commits_url":"https://api.github.com/repos/aptible/docker-nginx/git/commits{/sha}","comments_url":"https://api.github.com/repos/aptible/docker-nginx/comments{/number}","issue_comment_url":"https://api.github.com/repos/aptible/docker-nginx/issues/comments{/number}","contents_url":"https://api.github.com/repos/aptible/docker-nginx/contents/{+path}","compare_url":"https://api.github.com/repos/aptible/docker-nginx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aptible/docker-nginx/merges","archive_url":"https://api.github.com/repos/aptible/docker-nginx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aptible/docker-nginx/downloads","issues_url":"https://api.github.com/repos/aptible/docker-nginx/issues{/number}","pulls_url":"https://api.github.com/repos/aptible/docker-nginx/pulls{/number}","milestones_url":"https://api.github.com/repos/aptible/docker-nginx/milestones{/number}","notifications_url":"https://api.github.com/repos/aptible/docker-nginx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aptible/docker-nginx/labels{/name}","releases_url":"https://api.github.com/repos/aptible/docker-nginx/releases{/id}","created_at":"2014-03-19T00:22:55Z","updated_at":"2015-07-20T10:15:17Z","pushed_at":"2015-07-28T19:31:30Z","git_url":"git://github.com/aptible/docker-nginx.git","ssh_url":"git@github.com:aptible/docker-nginx.git","clone_url":"https://github.com/aptible/docker-nginx.git","svn_url":"https://github.com/aptible/docker-nginx","homepage":"","size":380,"stargazers_count":4,"watchers_count":4,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":10,"forks":6,"open_issues":10,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aptible/docker-nginx/pulls/48"},"html":{"href":"https://github.com/aptible/docker-nginx/pull/48"},"issue":{"href":"https://api.github.com/repos/aptible/docker-nginx/issues/48"},"comments":{"href":"https://api.github.com/repos/aptible/docker-nginx/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/aptible/docker-nginx/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/aptible/docker-nginx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aptible/docker-nginx/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/aptible/docker-nginx/statuses/1bd4dffa2fd21b186d043f8490d6a93ced86eb51"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"fancyremarker","id":156030,"avatar_url":"https://avatars.githubusercontent.com/u/156030?v=3","gravatar_id":"","url":"https://api.github.com/users/fancyremarker","html_url":"https://github.com/fancyremarker","followers_url":"https://api.github.com/users/fancyremarker/followers","following_url":"https://api.github.com/users/fancyremarker/following{/other_user}","gists_url":"https://api.github.com/users/fancyremarker/gists{/gist_id}","starred_url":"https://api.github.com/users/fancyremarker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fancyremarker/subscriptions","organizations_url":"https://api.github.com/users/fancyremarker/orgs","repos_url":"https://api.github.com/users/fancyremarker/repos","events_url":"https://api.github.com/users/fancyremarker/events{/privacy}","received_events_url":"https://api.github.com/users/fancyremarker/received_events","type":"User","site_admin":false},"comments":0,"review_comments":1,"commits":1,"additions":11,"deletions":0,"changed_files":2}}