{"action":"created","comment":{"url":"https://api.github.com/repos/enyojs/moonstone/pulls/comments/37482560","id":37482560,"diff_hunk":"@@ -579,6 +586,10 @@ module.exports = kind(\n \t\t\tthis.updatePopup(this.elasticFrom);\n \t\t\tthis.set('value',this.elasticFrom);\n \n+\t\t\tif (this.enableJumpIncrement) {\n+\t\t\t\tthis.updateButtonStatus(v);","path":"lib/Slider/Slider.js","position":30,"original_position":30,"commit_id":"fa3be7741278e15a92e7241160fc71749adaab80","original_commit_id":"fa3be7741278e15a92e7241160fc71749adaab80","user":{"login":"kyo504","id":3175096,"avatar_url":"https://avatars.githubusercontent.com/u/3175096?v=3","gravatar_id":"","url":"https://api.github.com/users/kyo504","html_url":"https://github.com/kyo504","followers_url":"https://api.github.com/users/kyo504/followers","following_url":"https://api.github.com/users/kyo504/following{/other_user}","gists_url":"https://api.github.com/users/kyo504/gists{/gist_id}","starred_url":"https://api.github.com/users/kyo504/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyo504/subscriptions","organizations_url":"https://api.github.com/users/kyo504/orgs","repos_url":"https://api.github.com/users/kyo504/repos","events_url":"https://api.github.com/users/kyo504/events{/privacy}","received_events_url":"https://api.github.com/users/kyo504/received_events","type":"User","site_admin":false},"body":"I also thought of performance issue about updating status while dragging. But I didn't know which is better way. If updating the status when drag is finished, we can get better performance but the status is not changed while dragging. I think we can go with your suggestion because Robert doesn't have objection about this. Right?","created_at":"2015-08-19T23:49:55Z","updated_at":"2015-08-19T23:49:55Z","html_url":"https://github.com/enyojs/moonstone/pull/2423#discussion_r37482560","pull_request_url":"https://api.github.com/repos/enyojs/moonstone/pulls/2423","_links":{"self":{"href":"https://api.github.com/repos/enyojs/moonstone/pulls/comments/37482560"},"html":{"href":"https://github.com/enyojs/moonstone/pull/2423#discussion_r37482560"},"pull_request":{"href":"https://api.github.com/repos/enyojs/moonstone/pulls/2423"}}},"pull_request":{"url":"https://api.github.com/repos/enyojs/moonstone/pulls/2423","id":42768239,"html_url":"https://github.com/enyojs/moonstone/pull/2423","diff_url":"https://github.com/enyojs/moonstone/pull/2423.diff","patch_url":"https://github.com/enyojs/moonstone/pull/2423.patch","issue_url":"https://api.github.com/repos/enyojs/moonstone/issues/2423","number":2423,"state":"open","locked":false,"title":"ENYO-2315: JumpIncrement button status in slider is not updated","user":{"login":"kyo504","id":3175096,"avatar_url":"https://avatars.githubusercontent.com/u/3175096?v=3","gravatar_id":"","url":"https://api.github.com/users/kyo504","html_url":"https://github.com/kyo504","followers_url":"https://api.github.com/users/kyo504/followers","following_url":"https://api.github.com/users/kyo504/following{/other_user}","gists_url":"https://api.github.com/users/kyo504/gists{/gist_id}","starred_url":"https://api.github.com/users/kyo504/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyo504/subscriptions","organizations_url":"https://api.github.com/users/kyo504/orgs","repos_url":"https://api.github.com/users/kyo504/repos","events_url":"https://api.github.com/users/kyo504/events{/privacy}","received_events_url":"https://api.github.com/users/kyo504/received_events","type":"User","site_admin":false},"body":"### Issue\r\n\r\nWhen enableJumpIncrement is set to true, slider has left and right buttons to move towards left or right based on jumpIncrementAmount. However if we use MRCU, the status of the two buttons are not updated.\r\n\r\n### Fix\r\n\r\nWhile dragging the knob, we check the status of jumpIncrement buttons based on the current value.\r\n\r\nEnyo-DCO-1.1-Signed-Off-By: Hunkyo Jung (hunkyo.jung@lge.com)","created_at":"2015-08-19T01:32:09Z","updated_at":"2015-08-19T23:49:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce893f7b8fa46a71690d0bc6d2db5c191b44cbe9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/enyojs/moonstone/pulls/2423/commits","review_comments_url":"https://api.github.com/repos/enyojs/moonstone/pulls/2423/comments","review_comment_url":"https://api.github.com/repos/enyojs/moonstone/pulls/comments{/number}","comments_url":"https://api.github.com/repos/enyojs/moonstone/issues/2423/comments","statuses_url":"https://api.github.com/repos/enyojs/moonstone/statuses/fa3be7741278e15a92e7241160fc71749adaab80","head":{"label":"enyojs:ENYO-2315-hunkyojung","ref":"ENYO-2315-hunkyojung","sha":"fa3be7741278e15a92e7241160fc71749adaab80","user":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=3","gravatar_id":"","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"repo":{"id":7251076,"name":"moonstone","full_name":"enyojs/moonstone","owner":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=3","gravatar_id":"","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enyojs/moonstone","description":"Moonstone UI library for TV user interfaces.","fork":false,"url":"https://api.github.com/repos/enyojs/moonstone","forks_url":"https://api.github.com/repos/enyojs/moonstone/forks","keys_url":"https://api.github.com/repos/enyojs/moonstone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enyojs/moonstone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enyojs/moonstone/teams","hooks_url":"https://api.github.com/repos/enyojs/moonstone/hooks","issue_events_url":"https://api.github.com/repos/enyojs/moonstone/issues/events{/number}","events_url":"https://api.github.com/repos/enyojs/moonstone/events","assignees_url":"https://api.github.com/repos/enyojs/moonstone/assignees{/user}","branches_url":"https://api.github.com/repos/enyojs/moonstone/branches{/branch}","tags_url":"https://api.github.com/repos/enyojs/moonstone/tags","blobs_url":"https://api.github.com/repos/enyojs/moonstone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enyojs/moonstone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enyojs/moonstone/git/refs{/sha}","trees_url":"https://api.github.com/repos/enyojs/moonstone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enyojs/moonstone/statuses/{sha}","languages_url":"https://api.github.com/repos/enyojs/moonstone/languages","stargazers_url":"https://api.github.com/repos/enyojs/moonstone/stargazers","contributors_url":"https://api.github.com/repos/enyojs/moonstone/contributors","subscribers_url":"https://api.github.com/repos/enyojs/moonstone/subscribers","subscription_url":"https://api.github.com/repos/enyojs/moonstone/subscription","commits_url":"https://api.github.com/repos/enyojs/moonstone/commits{/sha}","git_commits_url":"https://api.github.com/repos/enyojs/moonstone/git/commits{/sha}","comments_url":"https://api.github.com/repos/enyojs/moonstone/comments{/number}","issue_comment_url":"https://api.github.com/repos/enyojs/moonstone/issues/comments{/number}","contents_url":"https://api.github.com/repos/enyojs/moonstone/contents/{+path}","compare_url":"https://api.github.com/repos/enyojs/moonstone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enyojs/moonstone/merges","archive_url":"https://api.github.com/repos/enyojs/moonstone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enyojs/moonstone/downloads","issues_url":"https://api.github.com/repos/enyojs/moonstone/issues{/number}","pulls_url":"https://api.github.com/repos/enyojs/moonstone/pulls{/number}","milestones_url":"https://api.github.com/repos/enyojs/moonstone/milestones{/number}","notifications_url":"https://api.github.com/repos/enyojs/moonstone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enyojs/moonstone/labels{/name}","releases_url":"https://api.github.com/repos/enyojs/moonstone/releases{/id}","created_at":"2012-12-20T02:41:05Z","updated_at":"2015-08-11T13:24:58Z","pushed_at":"2015-08-19T23:49:07Z","git_url":"git://github.com/enyojs/moonstone.git","ssh_url":"git@github.com:enyojs/moonstone.git","clone_url":"https://github.com/enyojs/moonstone.git","svn_url":"https://github.com/enyojs/moonstone","homepage":"","size":94739,"stargazers_count":38,"watchers_count":38,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":87,"forks":12,"open_issues":87,"watchers":38,"default_branch":"master"}},"base":{"label":"enyojs:2.6.0-dev","ref":"2.6.0-dev","sha":"ee335fc2fed25688802c128e38e51b5e91a06603","user":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=3","gravatar_id":"","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"repo":{"id":7251076,"name":"moonstone","full_name":"enyojs/moonstone","owner":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=3","gravatar_id":"","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enyojs/moonstone","description":"Moonstone UI library for TV user interfaces.","fork":false,"url":"https://api.github.com/repos/enyojs/moonstone","forks_url":"https://api.github.com/repos/enyojs/moonstone/forks","keys_url":"https://api.github.com/repos/enyojs/moonstone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enyojs/moonstone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enyojs/moonstone/teams","hooks_url":"https://api.github.com/repos/enyojs/moonstone/hooks","issue_events_url":"https://api.github.com/repos/enyojs/moonstone/issues/events{/number}","events_url":"https://api.github.com/repos/enyojs/moonstone/events","assignees_url":"https://api.github.com/repos/enyojs/moonstone/assignees{/user}","branches_url":"https://api.github.com/repos/enyojs/moonstone/branches{/branch}","tags_url":"https://api.github.com/repos/enyojs/moonstone/tags","blobs_url":"https://api.github.com/repos/enyojs/moonstone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enyojs/moonstone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enyojs/moonstone/git/refs{/sha}","trees_url":"https://api.github.com/repos/enyojs/moonstone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enyojs/moonstone/statuses/{sha}","languages_url":"https://api.github.com/repos/enyojs/moonstone/languages","stargazers_url":"https://api.github.com/repos/enyojs/moonstone/stargazers","contributors_url":"https://api.github.com/repos/enyojs/moonstone/contributors","subscribers_url":"https://api.github.com/repos/enyojs/moonstone/subscribers","subscription_url":"https://api.github.com/repos/enyojs/moonstone/subscription","commits_url":"https://api.github.com/repos/enyojs/moonstone/commits{/sha}","git_commits_url":"https://api.github.com/repos/enyojs/moonstone/git/commits{/sha}","comments_url":"https://api.github.com/repos/enyojs/moonstone/comments{/number}","issue_comment_url":"https://api.github.com/repos/enyojs/moonstone/issues/comments{/number}","contents_url":"https://api.github.com/repos/enyojs/moonstone/contents/{+path}","compare_url":"https://api.github.com/repos/enyojs/moonstone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enyojs/moonstone/merges","archive_url":"https://api.github.com/repos/enyojs/moonstone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enyojs/moonstone/downloads","issues_url":"https://api.github.com/repos/enyojs/moonstone/issues{/number}","pulls_url":"https://api.github.com/repos/enyojs/moonstone/pulls{/number}","milestones_url":"https://api.github.com/repos/enyojs/moonstone/milestones{/number}","notifications_url":"https://api.github.com/repos/enyojs/moonstone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enyojs/moonstone/labels{/name}","releases_url":"https://api.github.com/repos/enyojs/moonstone/releases{/id}","created_at":"2012-12-20T02:41:05Z","updated_at":"2015-08-11T13:24:58Z","pushed_at":"2015-08-19T23:49:07Z","git_url":"git://github.com/enyojs/moonstone.git","ssh_url":"git@github.com:enyojs/moonstone.git","clone_url":"https://github.com/enyojs/moonstone.git","svn_url":"https://github.com/enyojs/moonstone","homepage":"","size":94739,"stargazers_count":38,"watchers_count":38,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":87,"forks":12,"open_issues":87,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/enyojs/moonstone/pulls/2423"},"html":{"href":"https://github.com/enyojs/moonstone/pull/2423"},"issue":{"href":"https://api.github.com/repos/enyojs/moonstone/issues/2423"},"comments":{"href":"https://api.github.com/repos/enyojs/moonstone/issues/2423/comments"},"review_comments":{"href":"https://api.github.com/repos/enyojs/moonstone/pulls/2423/comments"},"review_comment":{"href":"https://api.github.com/repos/enyojs/moonstone/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/enyojs/moonstone/pulls/2423/commits"},"statuses":{"href":"https://api.github.com/repos/enyojs/moonstone/statuses/fa3be7741278e15a92e7241160fc71749adaab80"}}}}