{"action":"opened","number":93,"pull_request":{"url":"https://api.github.com/repos/dgryski/carbonapi/pulls/93","id":49351616,"html_url":"https://github.com/dgryski/carbonapi/pull/93","diff_url":"https://github.com/dgryski/carbonapi/pull/93.diff","patch_url":"https://github.com/dgryski/carbonapi/pull/93.patch","issue_url":"https://api.github.com/repos/dgryski/carbonapi/issues/93","number":93,"state":"open","locked":false,"title":"Reorganize the code to be easier to comprehend and navigate","user":{"login":"Dieterbe","id":20774,"avatar_url":"https://avatars.githubusercontent.com/u/20774?v=3","gravatar_id":"","url":"https://api.github.com/users/Dieterbe","html_url":"https://github.com/Dieterbe","followers_url":"https://api.github.com/users/Dieterbe/followers","following_url":"https://api.github.com/users/Dieterbe/following{/other_user}","gists_url":"https://api.github.com/users/Dieterbe/gists{/gist_id}","starred_url":"https://api.github.com/users/Dieterbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dieterbe/subscriptions","organizations_url":"https://api.github.com/users/Dieterbe/orgs","repos_url":"https://api.github.com/users/Dieterbe/repos","events_url":"https://api.github.com/users/Dieterbe/events{/privacy}","received_events_url":"https://api.github.com/users/Dieterbe/received_events","type":"User","site_admin":false},"body":"with the exception of the \"fix comments\" commit, all commits just move stuff around, no functional/logical changes.\r\ni haven't tested it cause i don't have a zipper stack (see also below), though it compiles which should be enough of a test given the nature of the changes.\r\n\r\nnext up i would like to:\r\n* abstract out the zipper, and just use a backend interface, so that we can easily plug in other backends.  i'm creating a new graphite backend and maybe i should just use the same protobuf encoding, practically almost mimicing a zipper. but i have to look more into the code to see if that makes sense. either way there's a ton of graphite backends and it would be nice if we could plug them in here.\r\n* reorganize expr.go: separate out some of the helper functions and organize all the function implementations better, maybe a file for each, or something.\r\n* further reorganizing of expr.go, i want to make it more obvious just how compatible it is with graphite. maybe mark functions that are identical, list missing functions, list differences (todo's) more explicitly in a centralized place.  i also think we can more explicitly separate the \"graphite compatible\" stuff from \"here's extra functions that we came up with that don't exist in graphite\", at least in documentation/code organisation form, and perhaps also under a different url (`/render` vs `/renderv2` though maybe that would be overkill)\r\n\r\nI guess i should also ask @dgryski would you agree that this code base could support your needs and goals (by which i mean support the zipper/booking.com stack) , as well as the graphite-ng goals (next gen graphite-api replacement, drop in compatible wrt json/jsonp (not png) but deliberately provide some different functions with different logic as well, perhaps under a different endpoint) because i'ld like to combine efforts if possible.\r\ni deprecated my old graphite-ng graphite-api server (which was my first go program ever, and has a weird design) under graphite-ng and have been wanting to start over.  your code looks pretty solid and i'd much rather join forces than having 2 separate projects.  I think we could also get a lot more users/contributors for this project if we moved it under graphite-ng and addressed those 3 points i listed above.","created_at":"2015-10-31T15:25:54Z","updated_at":"2015-10-31T15:25:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dgryski/carbonapi/pulls/93/commits","review_comments_url":"https://api.github.com/repos/dgryski/carbonapi/pulls/93/comments","review_comment_url":"https://api.github.com/repos/dgryski/carbonapi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dgryski/carbonapi/issues/93/comments","statuses_url":"https://api.github.com/repos/dgryski/carbonapi/statuses/96b87d65b82a1b0eb5b0e9aecdba26539812d436","head":{"label":"Dieterbe:reorg","ref":"reorg","sha":"96b87d65b82a1b0eb5b0e9aecdba26539812d436","user":{"login":"Dieterbe","id":20774,"avatar_url":"https://avatars.githubusercontent.com/u/20774?v=3","gravatar_id":"","url":"https://api.github.com/users/Dieterbe","html_url":"https://github.com/Dieterbe","followers_url":"https://api.github.com/users/Dieterbe/followers","following_url":"https://api.github.com/users/Dieterbe/following{/other_user}","gists_url":"https://api.github.com/users/Dieterbe/gists{/gist_id}","starred_url":"https://api.github.com/users/Dieterbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dieterbe/subscriptions","organizations_url":"https://api.github.com/users/Dieterbe/orgs","repos_url":"https://api.github.com/users/Dieterbe/repos","events_url":"https://api.github.com/users/Dieterbe/events{/privacy}","received_events_url":"https://api.github.com/users/Dieterbe/received_events","type":"User","site_admin":false},"repo":{"id":45305424,"name":"carbonapi","full_name":"Dieterbe/carbonapi","owner":{"login":"Dieterbe","id":20774,"avatar_url":"https://avatars.githubusercontent.com/u/20774?v=3","gravatar_id":"","url":"https://api.github.com/users/Dieterbe","html_url":"https://github.com/Dieterbe","followers_url":"https://api.github.com/users/Dieterbe/followers","following_url":"https://api.github.com/users/Dieterbe/following{/other_user}","gists_url":"https://api.github.com/users/Dieterbe/gists{/gist_id}","starred_url":"https://api.github.com/users/Dieterbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dieterbe/subscriptions","organizations_url":"https://api.github.com/users/Dieterbe/orgs","repos_url":"https://api.github.com/users/Dieterbe/repos","events_url":"https://api.github.com/users/Dieterbe/events{/privacy}","received_events_url":"https://api.github.com/users/Dieterbe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Dieterbe/carbonapi","description":"API server for github.com/dgryski/carbonzipper","fork":true,"url":"https://api.github.com/repos/Dieterbe/carbonapi","forks_url":"https://api.github.com/repos/Dieterbe/carbonapi/forks","keys_url":"https://api.github.com/repos/Dieterbe/carbonapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dieterbe/carbonapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dieterbe/carbonapi/teams","hooks_url":"https://api.github.com/repos/Dieterbe/carbonapi/hooks","issue_events_url":"https://api.github.com/repos/Dieterbe/carbonapi/issues/events{/number}","events_url":"https://api.github.com/repos/Dieterbe/carbonapi/events","assignees_url":"https://api.github.com/repos/Dieterbe/carbonapi/assignees{/user}","branches_url":"https://api.github.com/repos/Dieterbe/carbonapi/branches{/branch}","tags_url":"https://api.github.com/repos/Dieterbe/carbonapi/tags","blobs_url":"https://api.github.com/repos/Dieterbe/carbonapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dieterbe/carbonapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dieterbe/carbonapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dieterbe/carbonapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dieterbe/carbonapi/statuses/{sha}","languages_url":"https://api.github.com/repos/Dieterbe/carbonapi/languages","stargazers_url":"https://api.github.com/repos/Dieterbe/carbonapi/stargazers","contributors_url":"https://api.github.com/repos/Dieterbe/carbonapi/contributors","subscribers_url":"https://api.github.com/repos/Dieterbe/carbonapi/subscribers","subscription_url":"https://api.github.com/repos/Dieterbe/carbonapi/subscription","commits_url":"https://api.github.com/repos/Dieterbe/carbonapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dieterbe/carbonapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dieterbe/carbonapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dieterbe/carbonapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dieterbe/carbonapi/contents/{+path}","compare_url":"https://api.github.com/repos/Dieterbe/carbonapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dieterbe/carbonapi/merges","archive_url":"https://api.github.com/repos/Dieterbe/carbonapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dieterbe/carbonapi/downloads","issues_url":"https://api.github.com/repos/Dieterbe/carbonapi/issues{/number}","pulls_url":"https://api.github.com/repos/Dieterbe/carbonapi/pulls{/number}","milestones_url":"https://api.github.com/repos/Dieterbe/carbonapi/milestones{/number}","notifications_url":"https://api.github.com/repos/Dieterbe/carbonapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dieterbe/carbonapi/labels{/name}","releases_url":"https://api.github.com/repos/Dieterbe/carbonapi/releases{/id}","created_at":"2015-10-31T14:48:54Z","updated_at":"2015-10-31T14:48:54Z","pushed_at":"2015-10-31T14:49:15Z","git_url":"git://github.com/Dieterbe/carbonapi.git","ssh_url":"git@github.com:Dieterbe/carbonapi.git","clone_url":"https://github.com/Dieterbe/carbonapi.git","svn_url":"https://github.com/Dieterbe/carbonapi","homepage":"","size":1846,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dgryski:master","ref":"master","sha":"bf75d37bc519bc66e17bd5113e6644493b81f1b9","user":{"login":"dgryski","id":970862,"avatar_url":"https://avatars.githubusercontent.com/u/970862?v=3","gravatar_id":"","url":"https://api.github.com/users/dgryski","html_url":"https://github.com/dgryski","followers_url":"https://api.github.com/users/dgryski/followers","following_url":"https://api.github.com/users/dgryski/following{/other_user}","gists_url":"https://api.github.com/users/dgryski/gists{/gist_id}","starred_url":"https://api.github.com/users/dgryski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgryski/subscriptions","organizations_url":"https://api.github.com/users/dgryski/orgs","repos_url":"https://api.github.com/users/dgryski/repos","events_url":"https://api.github.com/users/dgryski/events{/privacy}","received_events_url":"https://api.github.com/users/dgryski/received_events","type":"User","site_admin":false},"repo":{"id":22234992,"name":"carbonapi","full_name":"dgryski/carbonapi","owner":{"login":"dgryski","id":970862,"avatar_url":"https://avatars.githubusercontent.com/u/970862?v=3","gravatar_id":"","url":"https://api.github.com/users/dgryski","html_url":"https://github.com/dgryski","followers_url":"https://api.github.com/users/dgryski/followers","following_url":"https://api.github.com/users/dgryski/following{/other_user}","gists_url":"https://api.github.com/users/dgryski/gists{/gist_id}","starred_url":"https://api.github.com/users/dgryski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgryski/subscriptions","organizations_url":"https://api.github.com/users/dgryski/orgs","repos_url":"https://api.github.com/users/dgryski/repos","events_url":"https://api.github.com/users/dgryski/events{/privacy}","received_events_url":"https://api.github.com/users/dgryski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dgryski/carbonapi","description":"API server for github.com/dgryski/carbonzipper","fork":false,"url":"https://api.github.com/repos/dgryski/carbonapi","forks_url":"https://api.github.com/repos/dgryski/carbonapi/forks","keys_url":"https://api.github.com/repos/dgryski/carbonapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dgryski/carbonapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dgryski/carbonapi/teams","hooks_url":"https://api.github.com/repos/dgryski/carbonapi/hooks","issue_events_url":"https://api.github.com/repos/dgryski/carbonapi/issues/events{/number}","events_url":"https://api.github.com/repos/dgryski/carbonapi/events","assignees_url":"https://api.github.com/repos/dgryski/carbonapi/assignees{/user}","branches_url":"https://api.github.com/repos/dgryski/carbonapi/branches{/branch}","tags_url":"https://api.github.com/repos/dgryski/carbonapi/tags","blobs_url":"https://api.github.com/repos/dgryski/carbonapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dgryski/carbonapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dgryski/carbonapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/dgryski/carbonapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dgryski/carbonapi/statuses/{sha}","languages_url":"https://api.github.com/repos/dgryski/carbonapi/languages","stargazers_url":"https://api.github.com/repos/dgryski/carbonapi/stargazers","contributors_url":"https://api.github.com/repos/dgryski/carbonapi/contributors","subscribers_url":"https://api.github.com/repos/dgryski/carbonapi/subscribers","subscription_url":"https://api.github.com/repos/dgryski/carbonapi/subscription","commits_url":"https://api.github.com/repos/dgryski/carbonapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/dgryski/carbonapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/dgryski/carbonapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/dgryski/carbonapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/dgryski/carbonapi/contents/{+path}","compare_url":"https://api.github.com/repos/dgryski/carbonapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dgryski/carbonapi/merges","archive_url":"https://api.github.com/repos/dgryski/carbonapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dgryski/carbonapi/downloads","issues_url":"https://api.github.com/repos/dgryski/carbonapi/issues{/number}","pulls_url":"https://api.github.com/repos/dgryski/carbonapi/pulls{/number}","milestones_url":"https://api.github.com/repos/dgryski/carbonapi/milestones{/number}","notifications_url":"https://api.github.com/repos/dgryski/carbonapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dgryski/carbonapi/labels{/name}","releases_url":"https://api.github.com/repos/dgryski/carbonapi/releases{/id}","created_at":"2014-07-24T22:46:07Z","updated_at":"2015-10-28T17:08:57Z","pushed_at":"2015-10-29T18:29:34Z","git_url":"git://github.com/dgryski/carbonapi.git","ssh_url":"git@github.com:dgryski/carbonapi.git","clone_url":"https://github.com/dgryski/carbonapi.git","svn_url":"https://github.com/dgryski/carbonapi","homepage":"","size":1846,"stargazers_count":43,"watchers_count":43,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":19,"forks":24,"open_issues":19,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dgryski/carbonapi/pulls/93"},"html":{"href":"https://github.com/dgryski/carbonapi/pull/93"},"issue":{"href":"https://api.github.com/repos/dgryski/carbonapi/issues/93"},"comments":{"href":"https://api.github.com/repos/dgryski/carbonapi/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/dgryski/carbonapi/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/dgryski/carbonapi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dgryski/carbonapi/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/dgryski/carbonapi/statuses/96b87d65b82a1b0eb5b0e9aecdba26539812d436"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":5,"additions":411,"deletions":381,"changed_files":5}}