{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/43513884","id":43513884,"diff_hunk":"@@ -239,27 +239,72 @@ def url\n     end\n \n     def active?\n-      active_repos = Chef::DataBag.load(\"crowbar/repositories\") rescue {}\n-      active_repos.fetch(@platform, {}).fetch(@arch, {}).key? @id\n+      db = data_bag\n+      !db.nil? && db.include?(data_bag_item_name)\n     end\n \n     def stale?\n-      active_repos = Chef::DataBag.load(\"crowbar/repositories\") rescue {}\n-      if active_repos.fetch(@platform, {}).fetch(@arch, {}).key? @id\n-        active_repos[@platform][@arch][@id] != to_databag_hash\n-      else\n+      db_item = data_bag_item\n+\n+      if db_item.nil?\n         false\n+      else\n+        Repository.data_bag_item_to_hash(db_item) != to_databag.to_hash\n       end\n     end\n \n-    def to_databag_hash\n-      item = Hash.new\n+    #\n+    # Helpers for data bag storage\n+    #\n+\n+    def to_databag\n+      item = Chef::DataBagItem.new\n+      item.data_bag data_bag_name\n+      item[\"id\"] = data_bag_item_name\n       item[\"name\"] = name\n       item[\"url\"] = url\n       item[\"ask_on_error\"] = @config[\"ask_on_error\"] || false\n       item\n     end\n \n+    def data_bag_name\n+      \"repos-#{platform}-#{arch}\".gsub(\".\", \"_\")","path":"crowbar_framework/lib/crowbar/repository.rb","position":41,"original_position":41,"commit_id":"8541913010dbe7b8dae5c34e20fa80c0e36af467","original_commit_id":"8541913010dbe7b8dae5c34e20fa80c0e36af467","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Performance/StringReplacement: Use `tr` instead of `gsub`. (https://github.com/JuanitoFatas/fast-ruby#stringgsub-vs-stringtr-code)","created_at":"2015-10-30T15:21:02Z","updated_at":"2015-10-30T15:21:02Z","html_url":"https://github.com/crowbar/crowbar-core/pull/109#discussion_r43513884","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/109","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/43513884"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/109#discussion_r43513884"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/109"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/109","id":49282379,"html_url":"https://github.com/crowbar/crowbar-core/pull/109","diff_url":"https://github.com/crowbar/crowbar-core/pull/109.diff","patch_url":"https://github.com/crowbar/crowbar-core/pull/109.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/109","number":109,"state":"open","locked":false,"title":"Go back to one data bag item per repository","user":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"body":"cc @tboerger @MaximilianMeister ","created_at":"2015-10-30T15:20:57Z","updated_at":"2015-10-30T15:21:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d8a0186d1922405f721bf508ac8911add4818a5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/109/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/109/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/109/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/8541913010dbe7b8dae5c34e20fa80c0e36af467","head":{"label":"vuntz:repo-databag","ref":"repo-databag","sha":"8541913010dbe7b8dae5c34e20fa80c0e36af467","user":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"repo":{"id":41142179,"name":"crowbar-core","full_name":"vuntz/crowbar-core","owner":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vuntz/crowbar-core","description":"Core deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/vuntz/crowbar-core","forks_url":"https://api.github.com/repos/vuntz/crowbar-core/forks","keys_url":"https://api.github.com/repos/vuntz/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vuntz/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vuntz/crowbar-core/teams","hooks_url":"https://api.github.com/repos/vuntz/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/vuntz/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/vuntz/crowbar-core/events","assignees_url":"https://api.github.com/repos/vuntz/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/vuntz/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/vuntz/crowbar-core/tags","blobs_url":"https://api.github.com/repos/vuntz/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vuntz/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vuntz/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/vuntz/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vuntz/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/vuntz/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/vuntz/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/vuntz/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/vuntz/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/vuntz/crowbar-core/subscription","commits_url":"https://api.github.com/repos/vuntz/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/vuntz/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/vuntz/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/vuntz/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/vuntz/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/vuntz/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vuntz/crowbar-core/merges","archive_url":"https://api.github.com/repos/vuntz/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vuntz/crowbar-core/downloads","issues_url":"https://api.github.com/repos/vuntz/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/vuntz/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/vuntz/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/vuntz/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vuntz/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/vuntz/crowbar-core/releases{/id}","created_at":"2015-08-21T07:34:19Z","updated_at":"2015-08-21T07:34:21Z","pushed_at":"2015-10-30T15:20:36Z","git_url":"git://github.com/vuntz/crowbar-core.git","ssh_url":"git@github.com:vuntz/crowbar-core.git","clone_url":"https://github.com/vuntz/crowbar-core.git","svn_url":"https://github.com/vuntz/crowbar-core","homepage":null,"size":104149,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"70a0ba267587085642fef4466973f18b0e273eac","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39003227,"name":"crowbar-core","full_name":"crowbar/crowbar-core","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-core","description":"Core deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-core","forks_url":"https://api.github.com/repos/crowbar/crowbar-core/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-core/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-core/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-core/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-core/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-core/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-core/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-core/releases{/id}","created_at":"2015-07-13T09:31:28Z","updated_at":"2015-10-25T22:11:24Z","pushed_at":"2015-10-30T15:20:58Z","git_url":"git://github.com/crowbar/crowbar-core.git","ssh_url":"git@github.com:crowbar/crowbar-core.git","clone_url":"https://github.com/crowbar/crowbar-core.git","svn_url":"https://github.com/crowbar/crowbar-core","homepage":null,"size":120002,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":19,"forks":21,"open_issues":19,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/109"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/109"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/109"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-core/statuses/8541913010dbe7b8dae5c34e20fa80c0e36af467"}}}}