{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/40451481","id":40451481,"diff_hunk":"@@ -37,7 +40,7 @@ ellismg@linux:~$ sudo apt-get update\n \n Then install the packages you need:\n \n-`ellismg@linux:~$ sudo apt-get install cmake llvm-3.5 clang-3.5 lldb-3.6 lldb-3.6-dev libunwind8 libunwind8-dev gettext libicu-dev`\n+`ellismg@linux:~$ sudo apt-get install cmake llvm-3.5 clang-3.5 lldb-3.6 lldb-3.6-dev libunwind8 libunwind8-dev gettext libicu-dev curl libcurl4-openssl-dev libssl-dev`","path":"Documentation/building/linux-instructions.md","position":15,"original_position":15,"commit_id":"ca13a5da4d4a9e3dec89914128a07f8009248d26","original_commit_id":"ca13a5da4d4a9e3dec89914128a07f8009248d26","user":{"login":"jasonwilliams200OK","id":2031765,"avatar_url":"https://avatars.githubusercontent.com/u/2031765?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonwilliams200OK","html_url":"https://github.com/jasonwilliams200OK","followers_url":"https://api.github.com/users/jasonwilliams200OK/followers","following_url":"https://api.github.com/users/jasonwilliams200OK/following{/other_user}","gists_url":"https://api.github.com/users/jasonwilliams200OK/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonwilliams200OK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonwilliams200OK/subscriptions","organizations_url":"https://api.github.com/users/jasonwilliams200OK/orgs","repos_url":"https://api.github.com/users/jasonwilliams200OK/repos","events_url":"https://api.github.com/users/jasonwilliams200OK/events{/privacy}","received_events_url":"https://api.github.com/users/jasonwilliams200OK/received_events","type":"User","site_admin":false},"body":"I don't think `curl` should be considered as dependency. The script checks for both `wget` (for Debian-like OSes) and `curl` (rest of the POSIX world) and then selects the command which is available. I assume XUbuntu must have either wget or curl command pre-installed? it would be very weird if neither of the commands are available .. \r\n\r\nAlternatively, if we are making `curl` as a \"hard\" / set-in-stone dependency in build instructions, then this part of script should be simplified: https://github.com/dotnet/coreclr/blob/5aedb627a91/build.sh#L109-L120 to:\r\n\r\n```bash\r\necho \"Restoring NuGet.exe...\"\r\ncurl -sSL --create-dirs -o $__NuGetPath https://api.nuget.org/downloads/nuget.exe\r\n```\r\nwithout defensive error handling, in order to encourage users [RTFM](https://en.wikipedia.org/wiki/RTFM).","created_at":"2015-09-25T17:01:39Z","updated_at":"2015-09-25T17:01:39Z","html_url":"https://github.com/dotnet/coreclr/pull/1625#discussion_r40451481","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/1625","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/40451481"},"html":{"href":"https://github.com/dotnet/coreclr/pull/1625#discussion_r40451481"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/1625"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/1625","id":46012951,"html_url":"https://github.com/dotnet/coreclr/pull/1625","diff_url":"https://github.com/dotnet/coreclr/pull/1625.diff","patch_url":"https://github.com/dotnet/coreclr/pull/1625.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/1625","number":1625,"state":"open","locked":false,"title":"Problems I ran into while following instructions","user":{"login":"perfectphase","id":2489508,"avatar_url":"https://avatars.githubusercontent.com/u/2489508?v=3","gravatar_id":"","url":"https://api.github.com/users/perfectphase","html_url":"https://github.com/perfectphase","followers_url":"https://api.github.com/users/perfectphase/followers","following_url":"https://api.github.com/users/perfectphase/following{/other_user}","gists_url":"https://api.github.com/users/perfectphase/gists{/gist_id}","starred_url":"https://api.github.com/users/perfectphase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perfectphase/subscriptions","organizations_url":"https://api.github.com/users/perfectphase/orgs","repos_url":"https://api.github.com/users/perfectphase/repos","events_url":"https://api.github.com/users/perfectphase/events{/privacy}","received_events_url":"https://api.github.com/users/perfectphase/received_events","type":"User","site_admin":false},"body":"Added in extra components needed to build on linux, also updated for new native build scrips ref #3175","created_at":"2015-09-25T13:43:06Z","updated_at":"2015-09-25T17:01:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cbb0b29bb29e5575e9b930c0d9bc22d23b234dd4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/1625/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/1625/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/1625/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/ca13a5da4d4a9e3dec89914128a07f8009248d26","head":{"label":"perfectphase:patch-1","ref":"patch-1","sha":"ca13a5da4d4a9e3dec89914128a07f8009248d26","user":{"login":"perfectphase","id":2489508,"avatar_url":"https://avatars.githubusercontent.com/u/2489508?v=3","gravatar_id":"","url":"https://api.github.com/users/perfectphase","html_url":"https://github.com/perfectphase","followers_url":"https://api.github.com/users/perfectphase/followers","following_url":"https://api.github.com/users/perfectphase/following{/other_user}","gists_url":"https://api.github.com/users/perfectphase/gists{/gist_id}","starred_url":"https://api.github.com/users/perfectphase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perfectphase/subscriptions","organizations_url":"https://api.github.com/users/perfectphase/orgs","repos_url":"https://api.github.com/users/perfectphase/repos","events_url":"https://api.github.com/users/perfectphase/events{/privacy}","received_events_url":"https://api.github.com/users/perfectphase/received_events","type":"User","site_admin":false},"repo":{"id":43141230,"name":"coreclr","full_name":"perfectphase/coreclr","owner":{"login":"perfectphase","id":2489508,"avatar_url":"https://avatars.githubusercontent.com/u/2489508?v=3","gravatar_id":"","url":"https://api.github.com/users/perfectphase","html_url":"https://github.com/perfectphase","followers_url":"https://api.github.com/users/perfectphase/followers","following_url":"https://api.github.com/users/perfectphase/following{/other_user}","gists_url":"https://api.github.com/users/perfectphase/gists{/gist_id}","starred_url":"https://api.github.com/users/perfectphase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perfectphase/subscriptions","organizations_url":"https://api.github.com/users/perfectphase/orgs","repos_url":"https://api.github.com/users/perfectphase/repos","events_url":"https://api.github.com/users/perfectphase/events{/privacy}","received_events_url":"https://api.github.com/users/perfectphase/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/perfectphase/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/perfectphase/coreclr","forks_url":"https://api.github.com/repos/perfectphase/coreclr/forks","keys_url":"https://api.github.com/repos/perfectphase/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/perfectphase/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/perfectphase/coreclr/teams","hooks_url":"https://api.github.com/repos/perfectphase/coreclr/hooks","issue_events_url":"https://api.github.com/repos/perfectphase/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/perfectphase/coreclr/events","assignees_url":"https://api.github.com/repos/perfectphase/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/perfectphase/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/perfectphase/coreclr/tags","blobs_url":"https://api.github.com/repos/perfectphase/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/perfectphase/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/perfectphase/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/perfectphase/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/perfectphase/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/perfectphase/coreclr/languages","stargazers_url":"https://api.github.com/repos/perfectphase/coreclr/stargazers","contributors_url":"https://api.github.com/repos/perfectphase/coreclr/contributors","subscribers_url":"https://api.github.com/repos/perfectphase/coreclr/subscribers","subscription_url":"https://api.github.com/repos/perfectphase/coreclr/subscription","commits_url":"https://api.github.com/repos/perfectphase/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/perfectphase/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/perfectphase/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/perfectphase/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/perfectphase/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/perfectphase/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/perfectphase/coreclr/merges","archive_url":"https://api.github.com/repos/perfectphase/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/perfectphase/coreclr/downloads","issues_url":"https://api.github.com/repos/perfectphase/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/perfectphase/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/perfectphase/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/perfectphase/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/perfectphase/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/perfectphase/coreclr/releases{/id}","created_at":"2015-09-25T12:54:53Z","updated_at":"2015-09-25T12:55:37Z","pushed_at":"2015-09-25T13:03:03Z","git_url":"git://github.com/perfectphase/coreclr.git","ssh_url":"git@github.com:perfectphase/coreclr.git","clone_url":"https://github.com/perfectphase/coreclr.git","svn_url":"https://github.com/perfectphase/coreclr","homepage":"http://dotnet.github.io/core/","size":56225,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"f4560c6e113741d2296f2ebbc4cd6e6427b57a88","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","created_at":"2015-01-30T22:10:02Z","updated_at":"2015-09-25T06:35:47Z","pushed_at":"2015-09-25T13:43:06Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"http://dotnet.github.io/core/","size":56225,"stargazers_count":5205,"watchers_count":5205,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1051,"mirror_url":null,"open_issues_count":286,"forks":1051,"open_issues":286,"watchers":5205,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/1625"},"html":{"href":"https://github.com/dotnet/coreclr/pull/1625"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/1625"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/1625/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/1625/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/1625/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/ca13a5da4d4a9e3dec89914128a07f8009248d26"}}}}