{"push_id":642827027,"size":16,"distinct_size":16,"ref":"refs/heads/master","head":"f377cccc2bce59fb2d1e2229ca58692b88e6e659","before":"f24e496d5e5c4e2cd43d06aae70ba68ee802dcfa","commits":[{"sha":"311b1e18b2130c8d4baa00c2e186caa569beca15","author":{"email":"a82ad16292c9f3b890b7b13c336ff95f6bd02623@webkit.org","name":"commit-queue@webkit.org"},"message":"Make FunctionRareData allocation thread-safe\nhttps://bugs.webkit.org/show_bug.cgi?id=144001\n\nPatch by Basile Clement <basile_clement@apple.com> on 2015-04-23\nReviewed by Mark Lam.\n\nThe two things we want to prevent are:\n\n 1. A thread seeing a pointer to a not-yet-fully-created rare data from\n    a JSFunction\n 2. A thread seeing a pointer to a not-yet-fully-created Structure from\n    an ObjectAllocationProfile\n\nFor 1., only the JS thread can be creating the rare data (in\nruntime/CommonSlowPaths.cpp or in dfg/DFGOperations.cpp), so we don't need to\nworry about concurrent writes, and we don't need any fences when *reading* the\nrare data from the JS thread. Thus we only need a storeStoreFence between the\nrare data creation and assignment to m_rareData in\nJSFunction::createAndInitializeRareData() to ensure that when the store to\nm_rareData is issued, the rare data has been properly created.\n\nFor the DFG compilation threads, the only place they can access the\nrare data is through JSFunction::rareData(), and so we only need a\nloadLoadFence there to ensure that when we see a non-null pointer in\nm_rareData, the pointed object will be seen as a fully created\nFunctionRareData.\n\nFor 2., the structure is created in\nObjectAllocationProfile::initialize() (which appears to be called only by the\nJS thread as well, in bytecode/CodeBlock.cpp and on rare data initialization,\nwhich always happen in the JS thread), and read through\nObjectAllocationProfile::structure() and\nObjectAllocationProfile::inlineCapacity(), so following the same reasoning we\nput a storeStoreFence in ObjectAllocationProfile::initialize() and a\nloadLoadFence in ObjectAllocationProfile::structure() (and change\nObjectAllocationProfile::inlineCapacity() to go through\nObjectAllocationProfile::structure()).\n\nWe don't need a fence in ObjectAllocationProfile::clear() because\nclearing the structure is already as atomic as it gets.\n\nFinally, notice that we don't care about the ObjectAllocationProfile's\nm_allocator as that is only used by ObjectAllocationProfile::initialize() and\nObjectAllocationProfile::clear() that are always run in the JS thread.\nObjectAllocationProfile::isNull() could cause some trouble, but it is\ncurrently only used in the ObjectAllocationProfile::clear()'s ASSERT in the JS\nthread.  Doing isNull()-style pre-checks would be wrong in any other concurrent\nthread anyway.\n\n* bytecode/ObjectAllocationProfile.h:\n(JSC::ObjectAllocationProfile::initialize):\n(JSC::ObjectAllocationProfile::structure):\n(JSC::ObjectAllocationProfile::inlineCapacity):\n* runtime/JSFunction.cpp:\n(JSC::JSFunction::allocateAndInitializeRareData):\n* runtime/JSFunction.h:\n(JSC::JSFunction::rareData):\n(JSC::JSFunction::allocationStructure): Deleted.\nThis is no longer used, as all the accesses to the ObjectAllocationProfile go through the rare data.\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@183212 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/WebKit/webkit/commits/311b1e18b2130c8d4baa00c2e186caa569beca15"},{"sha":"f319af0f9d21a6386a6f4717e906b8aaf373cfe6","author":{"email":"a82ad16292c9f3b890b7b13c336ff95f6bd02623@webkit.org","name":"commit-queue@webkit.org"},"message":"Unreviewed, rolling out r183194.\nhttps://bugs.webkit.org/show_bug.cgi?id=144121\n\nMade multiple tests flaky (Requested by ap_ on #webkit).\n\nReverted changeset:\n\n\"Memory cache live resources repeatedly purged during\npainting\"\nhttps://bugs.webkit.org/show_bug.cgi?id=144104\nhttp://trac.webkit.org/changeset/183194\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@183213 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/WebKit/webkit/commits/f319af0f9d21a6386a6f4717e906b8aaf373cfe6"},{"sha":"1e78c1837de8e08196e1708f7875f4e6ece23e78","author":{"email":"0c14cefec9476562948d928ef34b7e5bc72c4a13@apple.com","name":"timothy@apple.com"},"message":"Web Inspector: Fix layering issues with ApplicationCacheFrameTreeElement\nhttps://bugs.webkit.org/show_bug.cgi?id=144113\n\nReviewed by Joseph Pecoraro.\n\n* UserInterface/Views/ApplicationCacheFrameTreeElement.js:\n(WebInspector.ApplicationCacheFrameTreeElement.prototype.updateTitles):\n(WebInspector.ApplicationCacheFrameTreeElement):\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@183214 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/WebKit/webkit/commits/1e78c1837de8e08196e1708f7875f4e6ece23e78"},{"sha":"f5d730fac81dd6b94774d877b5d2aecd18ac7ceb","author":{"email":"0c14cefec9476562948d928ef34b7e5bc72c4a13@apple.com","name":"timothy@apple.com"},"message":"Web Inspector: DebuggerSidebarPanel's _callStackContentTreeOutline should suppress filtering\nhttps://bugs.webkit.org/show_bug.cgi?id=144114\n\nReviewed by Joseph Pecoraro.\n\n* UserInterface/Views/DebuggerSidebarPanel.js:\n(WebInspector.DebuggerSidebarPanel):\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@183215 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/WebKit/webkit/commits/f5d730fac81dd6b94774d877b5d2aecd18ac7ceb"},{"sha":"ecef8808fe1108133aef481f0296417bde751608","author":{"email":"80ba7d307f87947d398714412ac0b1f517125a6c@apple.com","name":"enrica@apple.com"},"message":"iOS build fix after r183208.\n\nUnreviewed.\n\n* UIProcess/ios/WKContentViewInteraction.mm:\n\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@183216 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/WebKit/webkit/commits/ecef8808fe1108133aef481f0296417bde751608"},{"sha":"781d7478f0effe117208238950381a2809619570","author":{"email":"f6a40302e70d3875826ddafd7e450bcee2d7be56@apple.com","name":"timothy_horton@apple.com"},"message":"Make the linter stop complaining by fixing the order of fields in TestExpectations\n\n* platform/mac/TestExpectations:\nBug number comes first.\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@183217 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/WebKit/webkit/commits/781d7478f0effe117208238950381a2809619570"},{"sha":"dd7b04227bfae5c44db4994cac6457ef2add21e3","author":{"email":"b4ec39de7a032f72cb5bb9b534bb9152488f03c2@webkit.org","name":"dbates@webkit.org"},"message":"Clean up: Use references instead of pointers in more SVG files\nhttps://bugs.webkit.org/show_bug.cgi?id=144045\n\nReviewed by Darin Adler.\n\n* rendering/svg/SVGRootInlineBox.cpp:\n(WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes): Pass reference instead of pointer.\n\n* rendering/svg/SVGTextLayoutEngine.cpp:\n(WebCore::SVGTextLayoutEngine::recordTextFragment): Changed parameter textBox from pointer to reference.\n(WebCore::SVGTextLayoutEngine::layoutInlineTextBox): Ditto.\n(WebCore::SVGTextLayoutEngine::currentVisualCharacterMetrics): Changed parameter textBox from pointer to\nreference and made it const since this function does not modify textBox.\n(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath): Changed parameters from pointers to references.\nAlso, removed comma from comment so that it reads well.\n* rendering/svg/SVGTextLayoutEngine.h: Updated declarations for the above functions.\n\n* rendering/svg/SVGTextLayoutEngineBaseline.cpp:\n(WebCore::SVGTextLayoutEngineBaseline::calculateBaselineShift): Changed parameter style from pointer to reference.\nAdded case BS_LENGTH to switch block and removed default case so that the compiler checks that we handle all cases.\nRenamed parameter contextElement to context since the name of its data type conveys that it is an element.\n(WebCore::SVGTextLayoutEngineBaseline::calculateAlignmentBaselineShift): Changed parameter textRenderer from\npointer to reference and removed runtime assertion that textRenderer is non-null (since it well-formed reference\ncannot point to a non-existent object).\n(WebCore::SVGTextLayoutEngineBaseline::calculateGlyphOrientationAngle): Changed parameter style from pointer to reference\nremoved runtime assertion that style is non-null.\n* rendering/svg/SVGTextLayoutEngineBaseline.h: Updated declarations for the above functions.\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@183219 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/WebKit/webkit/commits/dd7b04227bfae5c44db4994cac6457ef2add21e3"},{"sha":"69bc8ae73a3577b49335c074efce20e68fa4e03e","author":{"email":"81dea2becd6014d7f2a527acd521cad73bee7d2a@apple.com","name":"jer.noble@apple.com"},"message":"[WK2][Mac] Tweak the timing curve of the WebKit Fullscreen animation\nhttps://bugs.webkit.org/show_bug.cgi?id=144120\n\nReviewed by Eric Carlson.\n\nTweak the curve to ease-in faster when the fullscreen animation duration is short.\n\n* UIProcess/mac/WKFullScreenWindowController.mm:\n(timingFunctionForDuration):\n(zoomAnimation):\n(maskAnimation):\n(fadeAnimation):\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@183220 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/WebKit/webkit/commits/69bc8ae73a3577b49335c074efce20e68fa4e03e"},{"sha":"bc93e4d07c3e5db0ea598ae6c9bcff54363f3b63","author":{"email":"81dea2becd6014d7f2a527acd521cad73bee7d2a@apple.com","name":"jer.noble@apple.com"},"message":"[Mac] Disable QTKit by default on future OS X.\nhttps://bugs.webkit.org/show_bug.cgi?id=144082\n\nReviewed by Darin Adler.\n\nSource/WebCore:\n\nSettings::gQTKitEnabled defaults to false.\n\n* page/Settings.cpp:\n\nSource/WebKit/mac:\n\nDefault WebKitQTKitEnabledPreferenceKey to NO.\n\n* WebView/WebPreferences.mm:\n(+[WebPreferences initialize]):\n\nSource/WebKit2:\n\nQTKitEnabled defaults to false.\n\n* Shared/WebPreferencesDefinitions.h:\n\nLayoutTests:\n\nAdd a required BANDWIDTH field to the alternate playlist.\n\n* http/tests/media/resources/hls/playlist-with-cookie.m3u8:\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@183221 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/WebKit/webkit/commits/bc93e4d07c3e5db0ea598ae6c9bcff54363f3b63"},{"sha":"caa4107e37dfb56de774a01043db4e6b5da5baec","author":{"email":"757f5bb409f1c48343a595d2e53cbd9d9fe6f508@igalia.com","name":"mcatanzaro@igalia.com"},"message":"[GTK] Add more public options\nhttps://bugs.webkit.org/show_bug.cgi?id=144116\n\nReviewed by Martin Robinson.\n\nAdd ENABLE_ICONDATABASE, ENABLE_JIT, and USE_SYSTEM_MALLOC as public options.\n\n* Source/cmake/OptionsGTK.cmake:\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@183222 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/WebKit/webkit/commits/caa4107e37dfb56de774a01043db4e6b5da5baec"},{"sha":"f4350ef58f17c9193943ea5a658e370df0f917a4","author":{"email":"d9e11e6a250b4baa1b0522b6c262c89590c7eab6@apple.com","name":"msaboff@apple.com"},"message":"lldb macro btjs sometimes can't get a frame description\nhttps://bugs.webkit.org/show_bug.cgi?id=144130\n\nReviewed by Filip Pizlo.\n\nWe look to execute ExecState::describeFrame().  It appears that in some contexts the\ndebugger can't find ExecState.  In those cases, CallFrame works as it is a typedef of\nExecState.  Therefore we can fallback to using CallFrame::describeFrame().\n\n* lldb/lldb_webkit.py:\n(btjs):\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@183223 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/WebKit/webkit/commits/f4350ef58f17c9193943ea5a658e370df0f917a4"},{"sha":"d3fc8b7c18785cc8003fa84129f25100c12ab4d5","author":{"email":"da9ae7a44550fc178f41fcc48acfff2b8c028cf4@apple.com","name":"simon.fraser@apple.com"},"message":"Changing TiledBacking velocity should schedule a tile revalidation\nhttps://bugs.webkit.org/show_bug.cgi?id=144123\n\nReviewed by Tim Horton.\nSource/WebCore:\n\nChanging the velocity parameters on the TileController affect the computed\ncoverage rect, so whenever we make a change to velocity data that could\naffect the outcome (basically any non-zero old or new velocities),\nschedule a layer flush.\n\n* platform/graphics/TiledBacking.h:\n(WebCore::VelocityData::velocityOrScaleIsChanging):\n* platform/graphics/ca/TileController.cpp:\n(WebCore::TileController::setVelocity):\n\nSource/WebKit2:\n\nDrive-by fix: use the FrameView& that we have already.\n\n* WebProcess/WebPage/ios/WebPageIOS.mm:\n(WebKit::WebPage::updateVisibleContentRects):\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@183224 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/WebKit/webkit/commits/d3fc8b7c18785cc8003fa84129f25100c12ab4d5"},{"sha":"37a918a4da420e01afad42d002ac2d31b72394a8","author":{"email":"75627661c6524c42f6b15cccebd09e42ccf63aa6@apple.com","name":"roger_fong@apple.com"},"message":"Update media timeline controls when video is paused..\nhttps://bugs.webkit.org/show_bug.cgi?id=144122.\n<rdar://problem/20422927>\n\nReviewed by Dean Jackson.\n\n* Modules/mediacontrols/mediaControlsApple.js:\n(Controller.prototype.drawTimelineBackground): Use timelineWidth because offsetWidth is 0 when display: none.\n(Controller.prototype.setPlaying): Show controls when pausing.\n(Controller.prototype.showControls): Update time and timeline when unhiding controls.\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@183225 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/WebKit/webkit/commits/37a918a4da420e01afad42d002ac2d31b72394a8"},{"sha":"7f7de63a6d3d66b6bcbc5dc0fe65860fd9efca83","author":{"email":"ac78b022715c5b8357b4dca8045e8463b4de2124@apple.com","name":"ap@apple.com"},"message":"Test compositing/scrolling/touch-scroll-to-clip.html fails in WK1\nhttps://bugs.webkit.org/show_bug.cgi?id=144127\n\n* platform/mac-wk1/TestExpectations: Marked it as such.\n\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@183226 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/WebKit/webkit/commits/7f7de63a6d3d66b6bcbc5dc0fe65860fd9efca83"},{"sha":"d2013356b1f2d0b6600bebc103c2db6ce508859f","author":{"email":"f6a40302e70d3875826ddafd7e450bcee2d7be56@apple.com","name":"timothy_horton@apple.com"},"message":"Yellow highlight has gray background color when invoking Lookup on an address in a Google Maps drop down\nhttps://bugs.webkit.org/show_bug.cgi?id=138737\n<rdar://problem/18904429>\n\nReviewed by Simon Fraser.\n\n* rendering/RenderReplaced.cpp:\n(WebCore::RenderReplaced::paint):\nOther RenderObjects don't paint box decorations in the selection painting phase,\nso RenderReplaced probably shouldn't either. This fixes the case where, when doing\nselection-only painting of a bit of text over top of a RenderReplaced, the RenderReplaced\nwould paint its background, filling the previously transparent bitmap with an unwanted color.\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@183227 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/WebKit/webkit/commits/d2013356b1f2d0b6600bebc103c2db6ce508859f"},{"sha":"f377cccc2bce59fb2d1e2229ca58692b88e6e659","author":{"email":"f6a40302e70d3875826ddafd7e450bcee2d7be56@apple.com","name":"timothy_horton@apple.com"},"message":"Quick Look preview popover is not dismissed on scroll in Mail\nhttps://bugs.webkit.org/show_bug.cgi?id=144119\n<rdar://problem/19752045>\n\nReviewed by Anders Carlsson.\n\n* UIProcess/API/mac/WKView.mm:\n(-[WKView renewGState]):\nIf we have a TextIndicator, dismiss all content relative child windows\non renewGState, not just the TextIndicator itself.\n\nThis will fix cases like Mail, where WebKit isn't driving the scrolling,\nand we have no way (except renewGState) to know that scrolling is happening.\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@183228 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/WebKit/webkit/commits/f377cccc2bce59fb2d1e2229ca58692b88e6e659"}]}