{"action":"created","comment":{"url":"https://api.github.com/repos/getlantern/lantern_aws/pulls/comments/27328226","id":27328226,"diff_hunk":"@@ -0,0 +1,32 @@\n+#!/usr/bin/env python","path":"salt/cloudmaster/access_data.py","position":1,"original_position":1,"commit_id":"9ec721935c344e5657456ff4c58916e5cfa97adb","original_commit_id":"9ec721935c344e5657456ff4c58916e5cfa97adb","user":{"login":"myleshorton","id":1143966,"avatar_url":"https://avatars.githubusercontent.com/u/1143966?v=3","gravatar_id":"","url":"https://api.github.com/users/myleshorton","html_url":"https://github.com/myleshorton","followers_url":"https://api.github.com/users/myleshorton/followers","following_url":"https://api.github.com/users/myleshorton/following{/other_user}","gists_url":"https://api.github.com/users/myleshorton/gists{/gist_id}","starred_url":"https://api.github.com/users/myleshorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myleshorton/subscriptions","organizations_url":"https://api.github.com/users/myleshorton/orgs","repos_url":"https://api.github.com/users/myleshorton/repos","events_url":"https://api.github.com/users/myleshorton/events{/privacy}","received_events_url":"https://api.github.com/users/myleshorton/received_events","type":"User","site_admin":false},"body":"Can you maybe add a high level comment to this script? Looks like it's handy for getting the access logs is that right? Maybe also add it to the readme? Seems handy =).","created_at":"2015-03-27T20:25:02Z","updated_at":"2015-03-27T20:25:02Z","html_url":"https://github.com/getlantern/lantern_aws/pull/39#discussion_r27328226","pull_request_url":"https://api.github.com/repos/getlantern/lantern_aws/pulls/39","_links":{"self":{"href":"https://api.github.com/repos/getlantern/lantern_aws/pulls/comments/27328226"},"html":{"href":"https://github.com/getlantern/lantern_aws/pull/39#discussion_r27328226"},"pull_request":{"href":"https://api.github.com/repos/getlantern/lantern_aws/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/getlantern/lantern_aws/pulls/39","id":32081949,"html_url":"https://github.com/getlantern/lantern_aws/pull/39","diff_url":"https://github.com/getlantern/lantern_aws/pull/39.diff","patch_url":"https://github.com/getlantern/lantern_aws/pull/39.patch","issue_url":"https://api.github.com/repos/getlantern/lantern_aws/issues/39","number":39,"state":"closed","locked":false,"title":"Save access data","user":{"login":"aranhoide","id":2204867,"avatar_url":"https://avatars.githubusercontent.com/u/2204867?v=3","gravatar_id":"","url":"https://api.github.com/users/aranhoide","html_url":"https://github.com/aranhoide","followers_url":"https://api.github.com/users/aranhoide/followers","following_url":"https://api.github.com/users/aranhoide/following{/other_user}","gists_url":"https://api.github.com/users/aranhoide/gists{/gist_id}","starred_url":"https://api.github.com/users/aranhoide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aranhoide/subscriptions","organizations_url":"https://api.github.com/users/aranhoide/orgs","repos_url":"https://api.github.com/users/aranhoide/repos","events_url":"https://api.github.com/users/aranhoide/events{/privacy}","received_events_url":"https://api.github.com/users/aranhoide/received_events","type":"User","site_admin":false},"body":"- Allow us to launch old-style fallback proxies with arbitrary names.\r\n- Make fallback proxies not report to the controller, but save access data locally.\r\n- Add script to the controller that collects access data in all proxies.\r\n\r\nI have tested this and I think these are safe changes, so I'll merge it.  I'm submitting this PR just in case anyone wants to give it a look.","created_at":"2015-03-27T04:04:49Z","updated_at":"2015-03-27T20:25:02Z","closed_at":"2015-03-27T04:08:20Z","merged_at":"2015-03-27T04:08:20Z","merge_commit_sha":"2681f1b548af1c506e3ad229b973035e13e3240e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/getlantern/lantern_aws/pulls/39/commits","review_comments_url":"https://api.github.com/repos/getlantern/lantern_aws/pulls/39/comments","review_comment_url":"https://api.github.com/repos/getlantern/lantern_aws/pulls/comments{/number}","comments_url":"https://api.github.com/repos/getlantern/lantern_aws/issues/39/comments","statuses_url":"https://api.github.com/repos/getlantern/lantern_aws/statuses/9ec721935c344e5657456ff4c58916e5cfa97adb","head":{"label":"getlantern:save-access-data","ref":"save-access-data","sha":"9ec721935c344e5657456ff4c58916e5cfa97adb","user":{"login":"getlantern","id":624178,"avatar_url":"https://avatars.githubusercontent.com/u/624178?v=3","gravatar_id":"","url":"https://api.github.com/users/getlantern","html_url":"https://github.com/getlantern","followers_url":"https://api.github.com/users/getlantern/followers","following_url":"https://api.github.com/users/getlantern/following{/other_user}","gists_url":"https://api.github.com/users/getlantern/gists{/gist_id}","starred_url":"https://api.github.com/users/getlantern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getlantern/subscriptions","organizations_url":"https://api.github.com/users/getlantern/orgs","repos_url":"https://api.github.com/users/getlantern/repos","events_url":"https://api.github.com/users/getlantern/events{/privacy}","received_events_url":"https://api.github.com/users/getlantern/received_events","type":"Organization","site_admin":false},"repo":{"id":5247106,"name":"lantern_aws","full_name":"getlantern/lantern_aws","owner":{"login":"getlantern","id":624178,"avatar_url":"https://avatars.githubusercontent.com/u/624178?v=3","gravatar_id":"","url":"https://api.github.com/users/getlantern","html_url":"https://github.com/getlantern","followers_url":"https://api.github.com/users/getlantern/followers","following_url":"https://api.github.com/users/getlantern/following{/other_user}","gists_url":"https://api.github.com/users/getlantern/gists{/gist_id}","starred_url":"https://api.github.com/users/getlantern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getlantern/subscriptions","organizations_url":"https://api.github.com/users/getlantern/orgs","repos_url":"https://api.github.com/users/getlantern/repos","events_url":"https://api.github.com/users/getlantern/events{/privacy}","received_events_url":"https://api.github.com/users/getlantern/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getlantern/lantern_aws","description":"AWS utilities and Salt configuration","fork":false,"url":"https://api.github.com/repos/getlantern/lantern_aws","forks_url":"https://api.github.com/repos/getlantern/lantern_aws/forks","keys_url":"https://api.github.com/repos/getlantern/lantern_aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getlantern/lantern_aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getlantern/lantern_aws/teams","hooks_url":"https://api.github.com/repos/getlantern/lantern_aws/hooks","issue_events_url":"https://api.github.com/repos/getlantern/lantern_aws/issues/events{/number}","events_url":"https://api.github.com/repos/getlantern/lantern_aws/events","assignees_url":"https://api.github.com/repos/getlantern/lantern_aws/assignees{/user}","branches_url":"https://api.github.com/repos/getlantern/lantern_aws/branches{/branch}","tags_url":"https://api.github.com/repos/getlantern/lantern_aws/tags","blobs_url":"https://api.github.com/repos/getlantern/lantern_aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getlantern/lantern_aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getlantern/lantern_aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/getlantern/lantern_aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getlantern/lantern_aws/statuses/{sha}","languages_url":"https://api.github.com/repos/getlantern/lantern_aws/languages","stargazers_url":"https://api.github.com/repos/getlantern/lantern_aws/stargazers","contributors_url":"https://api.github.com/repos/getlantern/lantern_aws/contributors","subscribers_url":"https://api.github.com/repos/getlantern/lantern_aws/subscribers","subscription_url":"https://api.github.com/repos/getlantern/lantern_aws/subscription","commits_url":"https://api.github.com/repos/getlantern/lantern_aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/getlantern/lantern_aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/getlantern/lantern_aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/getlantern/lantern_aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/getlantern/lantern_aws/contents/{+path}","compare_url":"https://api.github.com/repos/getlantern/lantern_aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getlantern/lantern_aws/merges","archive_url":"https://api.github.com/repos/getlantern/lantern_aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getlantern/lantern_aws/downloads","issues_url":"https://api.github.com/repos/getlantern/lantern_aws/issues{/number}","pulls_url":"https://api.github.com/repos/getlantern/lantern_aws/pulls{/number}","milestones_url":"https://api.github.com/repos/getlantern/lantern_aws/milestones{/number}","notifications_url":"https://api.github.com/repos/getlantern/lantern_aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getlantern/lantern_aws/labels{/name}","releases_url":"https://api.github.com/repos/getlantern/lantern_aws/releases{/id}","created_at":"2012-07-31T14:43:10Z","updated_at":"2015-03-27T09:26:50Z","pushed_at":"2015-03-27T09:26:50Z","git_url":"git://github.com/getlantern/lantern_aws.git","ssh_url":"git@github.com:getlantern/lantern_aws.git","clone_url":"https://github.com/getlantern/lantern_aws.git","svn_url":"https://github.com/getlantern/lantern_aws","homepage":"","size":2174,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":10,"forks":2,"open_issues":10,"watchers":3,"default_branch":"master"}},"base":{"label":"getlantern:master","ref":"master","sha":"0c375efea480f319bbaa86ce4345bd55c6a2006a","user":{"login":"getlantern","id":624178,"avatar_url":"https://avatars.githubusercontent.com/u/624178?v=3","gravatar_id":"","url":"https://api.github.com/users/getlantern","html_url":"https://github.com/getlantern","followers_url":"https://api.github.com/users/getlantern/followers","following_url":"https://api.github.com/users/getlantern/following{/other_user}","gists_url":"https://api.github.com/users/getlantern/gists{/gist_id}","starred_url":"https://api.github.com/users/getlantern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getlantern/subscriptions","organizations_url":"https://api.github.com/users/getlantern/orgs","repos_url":"https://api.github.com/users/getlantern/repos","events_url":"https://api.github.com/users/getlantern/events{/privacy}","received_events_url":"https://api.github.com/users/getlantern/received_events","type":"Organization","site_admin":false},"repo":{"id":5247106,"name":"lantern_aws","full_name":"getlantern/lantern_aws","owner":{"login":"getlantern","id":624178,"avatar_url":"https://avatars.githubusercontent.com/u/624178?v=3","gravatar_id":"","url":"https://api.github.com/users/getlantern","html_url":"https://github.com/getlantern","followers_url":"https://api.github.com/users/getlantern/followers","following_url":"https://api.github.com/users/getlantern/following{/other_user}","gists_url":"https://api.github.com/users/getlantern/gists{/gist_id}","starred_url":"https://api.github.com/users/getlantern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getlantern/subscriptions","organizations_url":"https://api.github.com/users/getlantern/orgs","repos_url":"https://api.github.com/users/getlantern/repos","events_url":"https://api.github.com/users/getlantern/events{/privacy}","received_events_url":"https://api.github.com/users/getlantern/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getlantern/lantern_aws","description":"AWS utilities and Salt configuration","fork":false,"url":"https://api.github.com/repos/getlantern/lantern_aws","forks_url":"https://api.github.com/repos/getlantern/lantern_aws/forks","keys_url":"https://api.github.com/repos/getlantern/lantern_aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getlantern/lantern_aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getlantern/lantern_aws/teams","hooks_url":"https://api.github.com/repos/getlantern/lantern_aws/hooks","issue_events_url":"https://api.github.com/repos/getlantern/lantern_aws/issues/events{/number}","events_url":"https://api.github.com/repos/getlantern/lantern_aws/events","assignees_url":"https://api.github.com/repos/getlantern/lantern_aws/assignees{/user}","branches_url":"https://api.github.com/repos/getlantern/lantern_aws/branches{/branch}","tags_url":"https://api.github.com/repos/getlantern/lantern_aws/tags","blobs_url":"https://api.github.com/repos/getlantern/lantern_aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getlantern/lantern_aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getlantern/lantern_aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/getlantern/lantern_aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getlantern/lantern_aws/statuses/{sha}","languages_url":"https://api.github.com/repos/getlantern/lantern_aws/languages","stargazers_url":"https://api.github.com/repos/getlantern/lantern_aws/stargazers","contributors_url":"https://api.github.com/repos/getlantern/lantern_aws/contributors","subscribers_url":"https://api.github.com/repos/getlantern/lantern_aws/subscribers","subscription_url":"https://api.github.com/repos/getlantern/lantern_aws/subscription","commits_url":"https://api.github.com/repos/getlantern/lantern_aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/getlantern/lantern_aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/getlantern/lantern_aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/getlantern/lantern_aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/getlantern/lantern_aws/contents/{+path}","compare_url":"https://api.github.com/repos/getlantern/lantern_aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getlantern/lantern_aws/merges","archive_url":"https://api.github.com/repos/getlantern/lantern_aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getlantern/lantern_aws/downloads","issues_url":"https://api.github.com/repos/getlantern/lantern_aws/issues{/number}","pulls_url":"https://api.github.com/repos/getlantern/lantern_aws/pulls{/number}","milestones_url":"https://api.github.com/repos/getlantern/lantern_aws/milestones{/number}","notifications_url":"https://api.github.com/repos/getlantern/lantern_aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getlantern/lantern_aws/labels{/name}","releases_url":"https://api.github.com/repos/getlantern/lantern_aws/releases{/id}","created_at":"2012-07-31T14:43:10Z","updated_at":"2015-03-27T09:26:50Z","pushed_at":"2015-03-27T09:26:50Z","git_url":"git://github.com/getlantern/lantern_aws.git","ssh_url":"git@github.com:getlantern/lantern_aws.git","clone_url":"https://github.com/getlantern/lantern_aws.git","svn_url":"https://github.com/getlantern/lantern_aws","homepage":"","size":2174,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":10,"forks":2,"open_issues":10,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/getlantern/lantern_aws/pulls/39"},"html":{"href":"https://github.com/getlantern/lantern_aws/pull/39"},"issue":{"href":"https://api.github.com/repos/getlantern/lantern_aws/issues/39"},"comments":{"href":"https://api.github.com/repos/getlantern/lantern_aws/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/getlantern/lantern_aws/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/getlantern/lantern_aws/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/getlantern/lantern_aws/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/getlantern/lantern_aws/statuses/9ec721935c344e5657456ff4c58916e5cfa97adb"}}}}