{"action":"created","issue":{"url":"https://api.github.com/repos/inviqa/chef-varnish/issues/19","labels_url":"https://api.github.com/repos/inviqa/chef-varnish/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/inviqa/chef-varnish/issues/19/comments","events_url":"https://api.github.com/repos/inviqa/chef-varnish/issues/19/events","html_url":"https://github.com/inviqa/chef-varnish/pull/19","id":55743334,"number":19,"title":"Add support for DAEMON_OPTS custom parameters","user":{"login":"ubick","id":904477,"avatar_url":"https://avatars.githubusercontent.com/u/904477?v=3","gravatar_id":"","url":"https://api.github.com/users/ubick","html_url":"https://github.com/ubick","followers_url":"https://api.github.com/users/ubick/followers","following_url":"https://api.github.com/users/ubick/following{/other_user}","gists_url":"https://api.github.com/users/ubick/gists{/gist_id}","starred_url":"https://api.github.com/users/ubick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubick/subscriptions","organizations_url":"https://api.github.com/users/ubick/orgs","repos_url":"https://api.github.com/users/ubick/repos","events_url":"https://api.github.com/users/ubick/events{/privacy}","received_events_url":"https://api.github.com/users/ubick/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-01-28T11:15:42Z","updated_at":"2015-01-28T14:18:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/inviqa/chef-varnish/pulls/19","html_url":"https://github.com/inviqa/chef-varnish/pull/19","diff_url":"https://github.com/inviqa/chef-varnish/pull/19.diff","patch_url":"https://github.com/inviqa/chef-varnish/pull/19.patch"},"body":"Added support for DAEMON_OPTS custom parameters.\r\n\r\nReasoning for this is adding Magento Turpentine varnish module support, as part of their configuration process requires varnish to be started with multiple custom parameters:\r\nhttps://github.com/nexcess/magento-turpentine/wiki/Installation\r\nThe Turpentine documentation suggests the following params: `-p esi_syntax=0x2` and `-p cli_buffer=16384`.\r\n\r\nExample usage (`tools/chef/environments/development.json`):\r\n\r\n```json\r\n{\r\n  \"name\": \"development\",\r\n  \"description\": \"\",\r\n  \"json_class\": \"Chef::Environment\",\r\n  \"chef_type\": \"environment\",\r\n  \"default_attributes\": {\r\n      \"varnish\": {\r\n          \"custom_parameters\": {\r\n              \"esi_syntax\": \"0x2\",\r\n              \"cli_buffer\": \"16384\"\r\n          }\r\n      }\r\n  },\r\n  \"override_attributes\": {}\r\n}\r\n```\r\n\r\nGenerated `/etc/sysconfig/varnish` (CentOS):\r\n\r\n```sh\r\nDAEMON_OPTS=\"-a ${VARNISH_LISTEN_ADDRESS}:${VARNISH_LISTEN_PORT} \\\r\n             -f ${VARNISH_VCL_CONF} \\\r\n             -T ${VARNISH_ADMIN_LISTEN_ADDRESS}:${VARNISH_ADMIN_LISTEN_PORT} \\\r\n             -t ${VARNISH_TTL} \\\r\n             -w ${VARNISH_MIN_THREADS},${VARNISH_MAX_THREADS},${VARNISH_THREAD_TIMEOUT} \\\r\n             -u varnish -g varnish \\\r\n             -S ${VARNISH_SECRET_FILE} \\\r\n             -p esi_syntax=0x2\r\n-p cli_buffer=16384\r\n             -s ${VARNISH_STORAGE}\"\r\n```"},"comment":{"url":"https://api.github.com/repos/inviqa/chef-varnish/issues/comments/71841107","html_url":"https://github.com/inviqa/chef-varnish/pull/19#issuecomment-71841107","issue_url":"https://api.github.com/repos/inviqa/chef-varnish/issues/19","id":71841107,"user":{"login":"svalaskevicius","id":893660,"avatar_url":"https://avatars.githubusercontent.com/u/893660?v=3","gravatar_id":"","url":"https://api.github.com/users/svalaskevicius","html_url":"https://github.com/svalaskevicius","followers_url":"https://api.github.com/users/svalaskevicius/followers","following_url":"https://api.github.com/users/svalaskevicius/following{/other_user}","gists_url":"https://api.github.com/users/svalaskevicius/gists{/gist_id}","starred_url":"https://api.github.com/users/svalaskevicius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svalaskevicius/subscriptions","organizations_url":"https://api.github.com/users/svalaskevicius/orgs","repos_url":"https://api.github.com/users/svalaskevicius/repos","events_url":"https://api.github.com/users/svalaskevicius/events{/privacy}","received_events_url":"https://api.github.com/users/svalaskevicius/received_events","type":"User","site_admin":false},"created_at":"2015-01-28T14:18:35Z","updated_at":"2015-01-28T14:18:35Z","body":"looks even better than before! :) \r\n![image](https://cloud.githubusercontent.com/assets/893660/5939072/8657e2a0-a6f8-11e4-8373-632acf9c0e59.png)\r\n\r\n\r\n"}}