{"action":"created","issue":{"url":"https://api.github.com/repos/cinemast/libjson-rpc-cpp/issues/87","labels_url":"https://api.github.com/repos/cinemast/libjson-rpc-cpp/issues/87/labels{/name}","comments_url":"https://api.github.com/repos/cinemast/libjson-rpc-cpp/issues/87/comments","events_url":"https://api.github.com/repos/cinemast/libjson-rpc-cpp/issues/87/events","html_url":"https://github.com/cinemast/libjson-rpc-cpp/pull/87","id":57044632,"number":87,"title":"jsonrpc for msvc","user":{"login":"debris","id":2613714,"avatar_url":"https://avatars.githubusercontent.com/u/2613714?v=3","gravatar_id":"","url":"https://api.github.com/users/debris","html_url":"https://github.com/debris","followers_url":"https://api.github.com/users/debris/followers","following_url":"https://api.github.com/users/debris/following{/other_user}","gists_url":"https://api.github.com/users/debris/gists{/gist_id}","starred_url":"https://api.github.com/users/debris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/debris/subscriptions","organizations_url":"https://api.github.com/users/debris/orgs","repos_url":"https://api.github.com/users/debris/repos","events_url":"https://api.github.com/users/debris/events{/privacy}","received_events_url":"https://api.github.com/users/debris/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-02-09T15:25:16Z","updated_at":"2015-02-11T10:13:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cinemast/libjson-rpc-cpp/pulls/87","html_url":"https://github.com/cinemast/libjson-rpc-cpp/pull/87","diff_url":"https://github.com/cinemast/libjson-rpc-cpp/pull/87.diff","patch_url":"https://github.com/cinemast/libjson-rpc-cpp/pull/87.patch"},"body":"common, client && server compiling in msvc (release mode)\r\n\r\ni've tested compiling with\r\n\r\ncmake 3.0.2\r\nMSVC 2013 Community\r\n\r\n```bash\r\ncmake -DCMAKE_PREFIX_PATH=path_to_dependencies -DCOMPILE_STUBGEN=NO -DCOMPILE_TESTS=NO ..\r\n```\r\n\r\n##### fixed:\r\n\r\n* [fixed recognition of JSONCPP_INCLUDE_PREFIX](https://github.com/debris/libjson-rpc-cpp/blob/jsonrpc4msvc/cmake/FindJSONCPP.cmake#L28)\r\n  * I was still using 'old' jsoncpp and I had `version.h` file. This caused configuration fail.\r\n* added [include_directories from custom CMAKE_PREFIX_PATH](https://github.com/debris/libjson-rpc-cpp/blob/jsonrpc4msvc/CMakeLists.txt#L27)\r\n  * this should solve some of the issues with custom dependencies path. Ideally, ```include_directories(XXX_INCLUDE_DIRS)``` should be used\r\n* findCURL now supports `libcurl` library name\r\n* findMHD now supports `libmicrohttpd` and `libmicrohttpd-dll`\r\n  * these are the names of libraries created from [libmicrohttpd repo](https://github.com/svn2github/libmicrohttpd)\r\n* removed dependency on `unistd.h`\r\n  * I replaced `usleep(timeout*1000);` with `std::this_thread::sleep_for(std::chrono::microseconds(timeout*1000))`\r\n* fixed compilation order in msvc [here](https://github.com/debris/libjson-rpc-cpp/blob/jsonrpc4msvc/src/jsonrpccpp/CMakeLists.txt#L71) and [here](https://github.com/debris/libjson-rpc-cpp/blob/jsonrpc4msvc/src/jsonrpccpp/CMakeLists.txt#L80)\r\n\r\n\r\n##### still todo: \r\n* compiling in debug mode (probably in next pr)\r\n* compiling stubgen, tests\r\n* fixing style issues (cmake style is inconsistent between files, 2 spaces, 4 spaces, tabs...)\r\n\r\n\r\n\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/cinemast/libjson-rpc-cpp/issues/comments/73858809","html_url":"https://github.com/cinemast/libjson-rpc-cpp/pull/87#issuecomment-73858809","issue_url":"https://api.github.com/repos/cinemast/libjson-rpc-cpp/issues/87","id":73858809,"user":{"login":"debris","id":2613714,"avatar_url":"https://avatars.githubusercontent.com/u/2613714?v=3","gravatar_id":"","url":"https://api.github.com/users/debris","html_url":"https://github.com/debris","followers_url":"https://api.github.com/users/debris/followers","following_url":"https://api.github.com/users/debris/following{/other_user}","gists_url":"https://api.github.com/users/debris/gists{/gist_id}","starred_url":"https://api.github.com/users/debris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/debris/subscriptions","organizations_url":"https://api.github.com/users/debris/orgs","repos_url":"https://api.github.com/users/debris/repos","events_url":"https://api.github.com/users/debris/events{/privacy}","received_events_url":"https://api.github.com/users/debris/received_events","type":"User","site_admin":false},"created_at":"2015-02-11T10:13:50Z","updated_at":"2015-02-11T10:13:50Z","body":"I've replaced c++11 with `#if`s. "}}