{"action":"created","comment":{"url":"https://api.github.com/repos/brikis98/docker-osx-dev/pulls/comments/44234209","id":44234209,"diff_hunk":"@@ -389,7 +389,8 @@ function init_boot2docker {\n # Inspect especific configuration about the docker-machine\n #\n function inspect_docker_machine {\n-  docker-machine inspect --format=\"$*\" \"$DOCKER_MACHINE_NAME\" 2>&1\n+  local result=$(docker-machine inspect --format=\"$*\" \"$DOCKER_MACHINE_NAME\" 2>&1)\n+  echo ${result/<no value>/}","path":"src/docker-osx-dev","position":6,"original_position":6,"commit_id":"e347d54f763a6a43257d43c25de3528abfc9035a","original_commit_id":"e347d54f763a6a43257d43c25de3528abfc9035a","user":{"login":"brikis98","id":711908,"avatar_url":"https://avatars.githubusercontent.com/u/711908?v=3","gravatar_id":"","url":"https://api.github.com/users/brikis98","html_url":"https://github.com/brikis98","followers_url":"https://api.github.com/users/brikis98/followers","following_url":"https://api.github.com/users/brikis98/following{/other_user}","gists_url":"https://api.github.com/users/brikis98/gists{/gist_id}","starred_url":"https://api.github.com/users/brikis98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brikis98/subscriptions","organizations_url":"https://api.github.com/users/brikis98/orgs","repos_url":"https://api.github.com/users/brikis98/repos","events_url":"https://api.github.com/users/brikis98/events{/privacy}","received_events_url":"https://api.github.com/users/brikis98/received_events","type":"User","site_admin":false},"body":"I asked a question about how this line works on the previous PR, but haven't seen a response. Here is the question again:\r\n\r\nI just want to make sure I'm understanding this correctly. Is the idea here that docker-machine (or rather, the go template engine) will return <no value> when a value isn't found, so when you look up the two keys, .StorePath and .HostOptions.AuthOptions.StorePath, one will return a value, one will return <no value>, and this line here will remove the ?\r\n\r\nIf so, is it possible for both values to be present? Or neither?","created_at":"2015-11-09T00:45:18Z","updated_at":"2015-11-09T00:45:18Z","html_url":"https://github.com/brikis98/docker-osx-dev/pull/134#discussion_r44234209","pull_request_url":"https://api.github.com/repos/brikis98/docker-osx-dev/pulls/134","_links":{"self":{"href":"https://api.github.com/repos/brikis98/docker-osx-dev/pulls/comments/44234209"},"html":{"href":"https://github.com/brikis98/docker-osx-dev/pull/134#discussion_r44234209"},"pull_request":{"href":"https://api.github.com/repos/brikis98/docker-osx-dev/pulls/134"}}},"pull_request":{"url":"https://api.github.com/repos/brikis98/docker-osx-dev/pulls/134","id":49933901,"html_url":"https://github.com/brikis98/docker-osx-dev/pull/134","diff_url":"https://github.com/brikis98/docker-osx-dev/pull/134.diff","patch_url":"https://github.com/brikis98/docker-osx-dev/pull/134.patch","issue_url":"https://api.github.com/repos/brikis98/docker-osx-dev/issues/134","number":134,"state":"open","locked":false,"title":"Fixes against docker-machine 0.5.0","user":{"login":"lukaso","id":5034,"avatar_url":"https://avatars.githubusercontent.com/u/5034?v=3","gravatar_id":"","url":"https://api.github.com/users/lukaso","html_url":"https://github.com/lukaso","followers_url":"https://api.github.com/users/lukaso/followers","following_url":"https://api.github.com/users/lukaso/following{/other_user}","gists_url":"https://api.github.com/users/lukaso/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaso/subscriptions","organizations_url":"https://api.github.com/users/lukaso/orgs","repos_url":"https://api.github.com/users/lukaso/repos","events_url":"https://api.github.com/users/lukaso/events{/privacy}","received_events_url":"https://api.github.com/users/lukaso/received_events","type":"User","site_admin":false},"body":"I have not tested against older docker-machine versions, so should probably\r\nbe checked before merging.\r\n\r\nIt is working for my use case.\r\n\r\nIntegration test worked through everything I tried, however there is an error:\r\n\r\n```\r\n$ test/integration-test.sh\r\n[TEST_INFO] Cleaning up old test environment\r\n[TEST_INFO] No old machine found\r\n[TEST_INFO] Creating machine\r\nRunning pre-create checks...\r\nCreating machine...\r\nWaiting for machine to be running, this may take a few minutes...\r\nMachine is running, waiting for SSH to be available...\r\nDetecting operating system of created instance...\r\nProvisioning created instance...\r\nCopying certs to the local machine directory...\r\nCopying certs to the remote machine...\r\nSetting Docker configuration on the remote daemon...\r\nTo see how to connect Docker to this machine, run: docker-machine env docker-osx-dev-test\r\n[TEST_INFO] Starting machine\r\nMachine \"docker-osx-dev-test\" is already running.\r\n[TEST_INFO] Testing the install command\r\n2015-11-06 09:40:45 [INFO] Starting install of docker-osx-dev\r\n2015-11-06 09:40:45 [INFO] Updating HomeBrew\r\nAlready up-to-date.\r\n2015-11-06 09:40:53 [WARN] Cask is already installed by HomeBrew, skipping\r\n2015-11-06 09:40:53 [WARN] Boot2Docker is already installed by HomeBrew, skipping\r\n2015-11-06 09:40:53 [WARN] Found command docker-compose, assuming Docker Compose is already installed and skipping\r\n2015-11-06 09:40:53 [WARN] Docker Machine is already installed by HomeBrew, skipping\r\n2015-11-06 09:40:54 [WARN] fswatch is already installed by HomeBrew, skipping\r\n2015-11-06 09:40:54 [WARN] GNU core utilities is already installed by HomeBrew, skipping\r\n2015-11-06 09:40:54 [INFO] testing if docker machine is running\r\n2015-11-06 09:40:54 [ERROR] Found VirtualBox shared folders on your Boot2Docker VM. These may void any performance benefits from using docker-osx-dev:\r\n/Users\r\n2015-11-06 09:40:54 [INSTRUCTIONS] Would you like this script to remove them?\r\n1) yes\r\n2) no\r\n#? yes\r\n2015-11-06 09:41:01 [INFO] Removing shared folder: /Users\r\n2015-11-06 09:41:01 [INFO] Installing rsync in the Docker Host image\r\nrsync.tcz.dep OK\r\nacl.tcz.dep OK\r\nDownloading: attr.tcz\r\nConnecting to repo.tinycorelinux.net (89.22.99.37:80)\r\nattr.tcz             100% |*******************************| 24576   0:00:00 ETA\r\nattr.tcz: OK\r\nDownloading: acl.tcz\r\nConnecting to repo.tinycorelinux.net (89.22.99.37:80)\r\nacl.tcz              100% |*******************************| 40960   0:00:00 ETA\r\nacl.tcz: OK\r\nDownloading: rsync.tcz\r\nConnecting to repo.tinycorelinux.net (89.22.99.37:80)\r\nrsync.tcz            100% |*******************************|   312k  0:00:00 ETA\r\nrsync.tcz: OK\r\n2015-11-06 09:41:48 [INFO] Adding docker-osx-dev-test entry to /etc/hosts so you can use http://docker-osx-dev-test URLs for testing\r\n2015-11-06 09:41:48 [INSTRUCTIONS] Modifying /etc/hosts requires sudo privileges, please enter your password.\r\nPassword:\r\n2015-11-06 09:41:58 [INFO] docker-osx-dev setup has completed successfully.\r\n2015-11-06 09:41:58 [INSTRUCTIONS] You can now start file syncing using the docker-osx-dev script and run Docker containers using docker run. Example:\r\n\t > docker-osx-dev\r\n\t > docker run -v $(pwd):/src some-docker-container\r\n[TEST_INFO] Creating test project in test-project\r\n[TEST_INFO] Running docker-osx-dev\r\n[TEST_INFO] Testing docker run with Alpine Linux image\r\n2015-11-06 09:41:58 [INFO] Using default sync paths: .\r\n2015-11-06 09:41:58 [INFO] Complete list of paths to sync: /Users/loberhub/projects/docker-osx-dev/test-project\r\n2015-11-06 09:41:59 [INFO] Using default exclude paths: .git\r\n2015-11-06 09:41:59 [INFO] Complete list of paths to exclude: .git\r\n2015-11-06 09:41:59 [INFO] Complete list of paths to include:\r\n2015-11-06 09:41:59 [INFO] Starting docker-osx-dev file syncing\r\n2015-11-06 09:41:59 [INFO] Initializing docker machine docker-osx-dev-test\r\nUnable to find image 'gliderlabs/alpine:3.2' locally\r\nMachine \"docker-osx-dev-test\" is already running.\r\n3.2: Pulling from gliderlabs/alpine\r\n87f9f1ccfaf3: Pulling fs layer\r\n87f9f1ccfaf3: Verifying Checksum\r\n87f9f1ccfaf3: Download complete\r\n87f9f1ccfaf3: Pull complete\r\nDigest: sha256:76a868e9e121abff7c2351fb1da83a956408215964a786a78c67aafe0ed4397e\r\nStatus: Downloaded newer image for gliderlabs/alpine:3.2\r\n[TEST_INFO] Testing mounting a folder with Alpine Linux image\r\ncat: can't open '/src/test-project/test-file': No such file or directory\r\ntest/integration-test.sh: line 44: [[: test file contents: syntax error in expression (error token is \"file contents\")\r\n```","created_at":"2015-11-06T09:49:59Z","updated_at":"2015-11-09T00:45:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41aebe2c61d2b12c985351e85ea99b8912e13c49","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/brikis98/docker-osx-dev/pulls/134/commits","review_comments_url":"https://api.github.com/repos/brikis98/docker-osx-dev/pulls/134/comments","review_comment_url":"https://api.github.com/repos/brikis98/docker-osx-dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brikis98/docker-osx-dev/issues/134/comments","statuses_url":"https://api.github.com/repos/brikis98/docker-osx-dev/statuses/e347d54f763a6a43257d43c25de3528abfc9035a","head":{"label":"simplybusiness:docker-machine-0-5-0","ref":"docker-machine-0-5-0","sha":"e347d54f763a6a43257d43c25de3528abfc9035a","user":{"login":"simplybusiness","id":465825,"avatar_url":"https://avatars.githubusercontent.com/u/465825?v=3","gravatar_id":"","url":"https://api.github.com/users/simplybusiness","html_url":"https://github.com/simplybusiness","followers_url":"https://api.github.com/users/simplybusiness/followers","following_url":"https://api.github.com/users/simplybusiness/following{/other_user}","gists_url":"https://api.github.com/users/simplybusiness/gists{/gist_id}","starred_url":"https://api.github.com/users/simplybusiness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simplybusiness/subscriptions","organizations_url":"https://api.github.com/users/simplybusiness/orgs","repos_url":"https://api.github.com/users/simplybusiness/repos","events_url":"https://api.github.com/users/simplybusiness/events{/privacy}","received_events_url":"https://api.github.com/users/simplybusiness/received_events","type":"Organization","site_admin":false},"repo":{"id":45672324,"name":"docker-osx-dev","full_name":"simplybusiness/docker-osx-dev","owner":{"login":"simplybusiness","id":465825,"avatar_url":"https://avatars.githubusercontent.com/u/465825?v=3","gravatar_id":"","url":"https://api.github.com/users/simplybusiness","html_url":"https://github.com/simplybusiness","followers_url":"https://api.github.com/users/simplybusiness/followers","following_url":"https://api.github.com/users/simplybusiness/following{/other_user}","gists_url":"https://api.github.com/users/simplybusiness/gists{/gist_id}","starred_url":"https://api.github.com/users/simplybusiness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simplybusiness/subscriptions","organizations_url":"https://api.github.com/users/simplybusiness/orgs","repos_url":"https://api.github.com/users/simplybusiness/repos","events_url":"https://api.github.com/users/simplybusiness/events{/privacy}","received_events_url":"https://api.github.com/users/simplybusiness/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/simplybusiness/docker-osx-dev","description":"A productive development environment with Docker on OS X","fork":true,"url":"https://api.github.com/repos/simplybusiness/docker-osx-dev","forks_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/forks","keys_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/teams","hooks_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/hooks","issue_events_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/issues/events{/number}","events_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/events","assignees_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/assignees{/user}","branches_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/branches{/branch}","tags_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/tags","blobs_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/languages","stargazers_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/stargazers","contributors_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/contributors","subscribers_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/subscribers","subscription_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/subscription","commits_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/contents/{+path}","compare_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/merges","archive_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/downloads","issues_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/issues{/number}","pulls_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/labels{/name}","releases_url":"https://api.github.com/repos/simplybusiness/docker-osx-dev/releases{/id}","created_at":"2015-11-06T09:26:40Z","updated_at":"2015-11-06T09:26:41Z","pushed_at":"2015-11-08T22:12:43Z","git_url":"git://github.com/simplybusiness/docker-osx-dev.git","ssh_url":"git@github.com:simplybusiness/docker-osx-dev.git","clone_url":"https://github.com/simplybusiness/docker-osx-dev.git","svn_url":"https://github.com/simplybusiness/docker-osx-dev","homepage":null,"size":853,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brikis98:master","ref":"master","sha":"4573bf4a53b525d9dad4eacfc670f184c94d391b","user":{"login":"brikis98","id":711908,"avatar_url":"https://avatars.githubusercontent.com/u/711908?v=3","gravatar_id":"","url":"https://api.github.com/users/brikis98","html_url":"https://github.com/brikis98","followers_url":"https://api.github.com/users/brikis98/followers","following_url":"https://api.github.com/users/brikis98/following{/other_user}","gists_url":"https://api.github.com/users/brikis98/gists{/gist_id}","starred_url":"https://api.github.com/users/brikis98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brikis98/subscriptions","organizations_url":"https://api.github.com/users/brikis98/orgs","repos_url":"https://api.github.com/users/brikis98/repos","events_url":"https://api.github.com/users/brikis98/events{/privacy}","received_events_url":"https://api.github.com/users/brikis98/received_events","type":"User","site_admin":false},"repo":{"id":35737822,"name":"docker-osx-dev","full_name":"brikis98/docker-osx-dev","owner":{"login":"brikis98","id":711908,"avatar_url":"https://avatars.githubusercontent.com/u/711908?v=3","gravatar_id":"","url":"https://api.github.com/users/brikis98","html_url":"https://github.com/brikis98","followers_url":"https://api.github.com/users/brikis98/followers","following_url":"https://api.github.com/users/brikis98/following{/other_user}","gists_url":"https://api.github.com/users/brikis98/gists{/gist_id}","starred_url":"https://api.github.com/users/brikis98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brikis98/subscriptions","organizations_url":"https://api.github.com/users/brikis98/orgs","repos_url":"https://api.github.com/users/brikis98/repos","events_url":"https://api.github.com/users/brikis98/events{/privacy}","received_events_url":"https://api.github.com/users/brikis98/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brikis98/docker-osx-dev","description":"A productive development environment with Docker on OS X","fork":false,"url":"https://api.github.com/repos/brikis98/docker-osx-dev","forks_url":"https://api.github.com/repos/brikis98/docker-osx-dev/forks","keys_url":"https://api.github.com/repos/brikis98/docker-osx-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brikis98/docker-osx-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brikis98/docker-osx-dev/teams","hooks_url":"https://api.github.com/repos/brikis98/docker-osx-dev/hooks","issue_events_url":"https://api.github.com/repos/brikis98/docker-osx-dev/issues/events{/number}","events_url":"https://api.github.com/repos/brikis98/docker-osx-dev/events","assignees_url":"https://api.github.com/repos/brikis98/docker-osx-dev/assignees{/user}","branches_url":"https://api.github.com/repos/brikis98/docker-osx-dev/branches{/branch}","tags_url":"https://api.github.com/repos/brikis98/docker-osx-dev/tags","blobs_url":"https://api.github.com/repos/brikis98/docker-osx-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brikis98/docker-osx-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brikis98/docker-osx-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/brikis98/docker-osx-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brikis98/docker-osx-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/brikis98/docker-osx-dev/languages","stargazers_url":"https://api.github.com/repos/brikis98/docker-osx-dev/stargazers","contributors_url":"https://api.github.com/repos/brikis98/docker-osx-dev/contributors","subscribers_url":"https://api.github.com/repos/brikis98/docker-osx-dev/subscribers","subscription_url":"https://api.github.com/repos/brikis98/docker-osx-dev/subscription","commits_url":"https://api.github.com/repos/brikis98/docker-osx-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/brikis98/docker-osx-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/brikis98/docker-osx-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/brikis98/docker-osx-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/brikis98/docker-osx-dev/contents/{+path}","compare_url":"https://api.github.com/repos/brikis98/docker-osx-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brikis98/docker-osx-dev/merges","archive_url":"https://api.github.com/repos/brikis98/docker-osx-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brikis98/docker-osx-dev/downloads","issues_url":"https://api.github.com/repos/brikis98/docker-osx-dev/issues{/number}","pulls_url":"https://api.github.com/repos/brikis98/docker-osx-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/brikis98/docker-osx-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/brikis98/docker-osx-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brikis98/docker-osx-dev/labels{/name}","releases_url":"https://api.github.com/repos/brikis98/docker-osx-dev/releases{/id}","created_at":"2015-05-16T19:47:53Z","updated_at":"2015-11-06T22:14:02Z","pushed_at":"2015-11-08T22:12:43Z","git_url":"git://github.com/brikis98/docker-osx-dev.git","ssh_url":"git@github.com:brikis98/docker-osx-dev.git","clone_url":"https://github.com/brikis98/docker-osx-dev.git","svn_url":"https://github.com/brikis98/docker-osx-dev","homepage":null,"size":1223,"stargazers_count":537,"watchers_count":537,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":30,"forks":45,"open_issues":30,"watchers":537,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brikis98/docker-osx-dev/pulls/134"},"html":{"href":"https://github.com/brikis98/docker-osx-dev/pull/134"},"issue":{"href":"https://api.github.com/repos/brikis98/docker-osx-dev/issues/134"},"comments":{"href":"https://api.github.com/repos/brikis98/docker-osx-dev/issues/134/comments"},"review_comments":{"href":"https://api.github.com/repos/brikis98/docker-osx-dev/pulls/134/comments"},"review_comment":{"href":"https://api.github.com/repos/brikis98/docker-osx-dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brikis98/docker-osx-dev/pulls/134/commits"},"statuses":{"href":"https://api.github.com/repos/brikis98/docker-osx-dev/statuses/e347d54f763a6a43257d43c25de3528abfc9035a"}}}}