{"action":"created","comment":{"url":"https://api.github.com/repos/Matroska-Org/ebml-specification/pulls/comments/34961840","id":34961840,"diff_hunk":"@@ -228,6 +210,95 @@ VINT\\_WIDTH | VINT\\_MARKER | VINT\\_DATA     | Element Data Size Status\n         For example -2 can be coded as 0xFFFFFFFFFFFFFE or 0xFFFE or\n         0xFE and 5 can be coded 0x000000000005 or 0x0005 or 0x05.\n \n+## EBML Element Types\n+\n+Each defined EBML Element MUST have a declared Element Type. The Element Type defines a concept for storing data that may be constrained by length, endianness, and purpose.\n+\n+Element Data Type:   Signed Integer\n+\n+    Endianness:     Big-endian\n+    Length:         A Signed Integer Element MUST at least 1 octet in","path":"specification.markdown","position":36,"original_position":36,"commit_id":"f2c617bdfbd59687ad34e156c6b8a8cebb8697ae","original_commit_id":"f2c617bdfbd59687ad34e156c6b8a8cebb8697ae","user":{"login":"wm4","id":1387750,"avatar_url":"https://avatars.githubusercontent.com/u/1387750?v=3","gravatar_id":"","url":"https://api.github.com/users/wm4","html_url":"https://github.com/wm4","followers_url":"https://api.github.com/users/wm4/followers","following_url":"https://api.github.com/users/wm4/following{/other_user}","gists_url":"https://api.github.com/users/wm4/gists{/gist_id}","starred_url":"https://api.github.com/users/wm4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wm4/subscriptions","organizations_url":"https://api.github.com/users/wm4/orgs","repos_url":"https://api.github.com/users/wm4/repos","events_url":"https://api.github.com/users/wm4/events{/privacy}","received_events_url":"https://api.github.com/users/wm4/received_events","type":"User","site_admin":false},"body":">Less exceptions = less code to test, less things to misunderstand.\r\n\r\nTo be fair, 0-sized elements that are integers/floats/dates are extremely rare (rare enough that your code will handle at least 99.9% of all mkv files without breaking), so allowing this actually adds more need to test obscure corner cases.","created_at":"2015-07-19T20:37:03Z","updated_at":"2015-07-19T20:37:03Z","html_url":"https://github.com/Matroska-Org/ebml-specification/pull/17#discussion_r34961840","pull_request_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/Matroska-Org/ebml-specification/pulls/comments/34961840"},"html":{"href":"https://github.com/Matroska-Org/ebml-specification/pull/17#discussion_r34961840"},"pull_request":{"href":"https://api.github.com/repos/Matroska-Org/ebml-specification/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/Matroska-Org/ebml-specification/pulls/17","id":38716703,"html_url":"https://github.com/Matroska-Org/ebml-specification/pull/17","diff_url":"https://github.com/Matroska-Org/ebml-specification/pull/17.diff","patch_url":"https://github.com/Matroska-Org/ebml-specification/pull/17.patch","issue_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/issues/17","number":17,"state":"open","locked":false,"title":"extend definition of EBML Data Types","user":{"login":"dericed","id":762604,"avatar_url":"https://avatars.githubusercontent.com/u/762604?v=3","gravatar_id":"","url":"https://api.github.com/users/dericed","html_url":"https://github.com/dericed","followers_url":"https://api.github.com/users/dericed/followers","following_url":"https://api.github.com/users/dericed/following{/other_user}","gists_url":"https://api.github.com/users/dericed/gists{/gist_id}","starred_url":"https://api.github.com/users/dericed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dericed/subscriptions","organizations_url":"https://api.github.com/users/dericed/orgs","repos_url":"https://api.github.com/users/dericed/repos","events_url":"https://api.github.com/users/dericed/events{/privacy}","received_events_url":"https://api.github.com/users/dericed/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-27T22:37:14Z","updated_at":"2015-07-19T20:37:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16d48f319bda72f46809a79bb737b9f2ffb2a81f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/pulls/17/commits","review_comments_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/pulls/17/comments","review_comment_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/issues/17/comments","statuses_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/statuses/f2c617bdfbd59687ad34e156c6b8a8cebb8697ae","head":{"label":"MediaArea:data-types","ref":"data-types","sha":"f2c617bdfbd59687ad34e156c6b8a8cebb8697ae","user":{"login":"MediaArea","id":7846736,"avatar_url":"https://avatars.githubusercontent.com/u/7846736?v=3","gravatar_id":"","url":"https://api.github.com/users/MediaArea","html_url":"https://github.com/MediaArea","followers_url":"https://api.github.com/users/MediaArea/followers","following_url":"https://api.github.com/users/MediaArea/following{/other_user}","gists_url":"https://api.github.com/users/MediaArea/gists{/gist_id}","starred_url":"https://api.github.com/users/MediaArea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MediaArea/subscriptions","organizations_url":"https://api.github.com/users/MediaArea/orgs","repos_url":"https://api.github.com/users/MediaArea/repos","events_url":"https://api.github.com/users/MediaArea/events{/privacy}","received_events_url":"https://api.github.com/users/MediaArea/received_events","type":"Organization","site_admin":false},"repo":{"id":34998353,"name":"ebml-specification","full_name":"MediaArea/ebml-specification","owner":{"login":"MediaArea","id":7846736,"avatar_url":"https://avatars.githubusercontent.com/u/7846736?v=3","gravatar_id":"","url":"https://api.github.com/users/MediaArea","html_url":"https://github.com/MediaArea","followers_url":"https://api.github.com/users/MediaArea/followers","following_url":"https://api.github.com/users/MediaArea/following{/other_user}","gists_url":"https://api.github.com/users/MediaArea/gists{/gist_id}","starred_url":"https://api.github.com/users/MediaArea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MediaArea/subscriptions","organizations_url":"https://api.github.com/users/MediaArea/orgs","repos_url":"https://api.github.com/users/MediaArea/repos","events_url":"https://api.github.com/users/MediaArea/events{/privacy}","received_events_url":"https://api.github.com/users/MediaArea/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MediaArea/ebml-specification","description":"the specification for the EBML format","fork":true,"url":"https://api.github.com/repos/MediaArea/ebml-specification","forks_url":"https://api.github.com/repos/MediaArea/ebml-specification/forks","keys_url":"https://api.github.com/repos/MediaArea/ebml-specification/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MediaArea/ebml-specification/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MediaArea/ebml-specification/teams","hooks_url":"https://api.github.com/repos/MediaArea/ebml-specification/hooks","issue_events_url":"https://api.github.com/repos/MediaArea/ebml-specification/issues/events{/number}","events_url":"https://api.github.com/repos/MediaArea/ebml-specification/events","assignees_url":"https://api.github.com/repos/MediaArea/ebml-specification/assignees{/user}","branches_url":"https://api.github.com/repos/MediaArea/ebml-specification/branches{/branch}","tags_url":"https://api.github.com/repos/MediaArea/ebml-specification/tags","blobs_url":"https://api.github.com/repos/MediaArea/ebml-specification/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MediaArea/ebml-specification/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MediaArea/ebml-specification/git/refs{/sha}","trees_url":"https://api.github.com/repos/MediaArea/ebml-specification/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MediaArea/ebml-specification/statuses/{sha}","languages_url":"https://api.github.com/repos/MediaArea/ebml-specification/languages","stargazers_url":"https://api.github.com/repos/MediaArea/ebml-specification/stargazers","contributors_url":"https://api.github.com/repos/MediaArea/ebml-specification/contributors","subscribers_url":"https://api.github.com/repos/MediaArea/ebml-specification/subscribers","subscription_url":"https://api.github.com/repos/MediaArea/ebml-specification/subscription","commits_url":"https://api.github.com/repos/MediaArea/ebml-specification/commits{/sha}","git_commits_url":"https://api.github.com/repos/MediaArea/ebml-specification/git/commits{/sha}","comments_url":"https://api.github.com/repos/MediaArea/ebml-specification/comments{/number}","issue_comment_url":"https://api.github.com/repos/MediaArea/ebml-specification/issues/comments{/number}","contents_url":"https://api.github.com/repos/MediaArea/ebml-specification/contents/{+path}","compare_url":"https://api.github.com/repos/MediaArea/ebml-specification/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MediaArea/ebml-specification/merges","archive_url":"https://api.github.com/repos/MediaArea/ebml-specification/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MediaArea/ebml-specification/downloads","issues_url":"https://api.github.com/repos/MediaArea/ebml-specification/issues{/number}","pulls_url":"https://api.github.com/repos/MediaArea/ebml-specification/pulls{/number}","milestones_url":"https://api.github.com/repos/MediaArea/ebml-specification/milestones{/number}","notifications_url":"https://api.github.com/repos/MediaArea/ebml-specification/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MediaArea/ebml-specification/labels{/name}","releases_url":"https://api.github.com/repos/MediaArea/ebml-specification/releases{/id}","created_at":"2015-05-03T19:43:13Z","updated_at":"2015-05-03T17:48:36Z","pushed_at":"2015-06-27T22:36:53Z","git_url":"git://github.com/MediaArea/ebml-specification.git","ssh_url":"git@github.com:MediaArea/ebml-specification.git","clone_url":"https://github.com/MediaArea/ebml-specification.git","svn_url":"https://github.com/MediaArea/ebml-specification","homepage":null,"size":319,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Matroska-Org:master","ref":"master","sha":"4aad7f50ef553a857a62788a6f4d59f89dd1d3e8","user":{"login":"Matroska-Org","id":3148284,"avatar_url":"https://avatars.githubusercontent.com/u/3148284?v=3","gravatar_id":"","url":"https://api.github.com/users/Matroska-Org","html_url":"https://github.com/Matroska-Org","followers_url":"https://api.github.com/users/Matroska-Org/followers","following_url":"https://api.github.com/users/Matroska-Org/following{/other_user}","gists_url":"https://api.github.com/users/Matroska-Org/gists{/gist_id}","starred_url":"https://api.github.com/users/Matroska-Org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Matroska-Org/subscriptions","organizations_url":"https://api.github.com/users/Matroska-Org/orgs","repos_url":"https://api.github.com/users/Matroska-Org/repos","events_url":"https://api.github.com/users/Matroska-Org/events{/privacy}","received_events_url":"https://api.github.com/users/Matroska-Org/received_events","type":"Organization","site_admin":false},"repo":{"id":34994967,"name":"ebml-specification","full_name":"Matroska-Org/ebml-specification","owner":{"login":"Matroska-Org","id":3148284,"avatar_url":"https://avatars.githubusercontent.com/u/3148284?v=3","gravatar_id":"","url":"https://api.github.com/users/Matroska-Org","html_url":"https://github.com/Matroska-Org","followers_url":"https://api.github.com/users/Matroska-Org/followers","following_url":"https://api.github.com/users/Matroska-Org/following{/other_user}","gists_url":"https://api.github.com/users/Matroska-Org/gists{/gist_id}","starred_url":"https://api.github.com/users/Matroska-Org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Matroska-Org/subscriptions","organizations_url":"https://api.github.com/users/Matroska-Org/orgs","repos_url":"https://api.github.com/users/Matroska-Org/repos","events_url":"https://api.github.com/users/Matroska-Org/events{/privacy}","received_events_url":"https://api.github.com/users/Matroska-Org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Matroska-Org/ebml-specification","description":"the specification for the EBML format","fork":false,"url":"https://api.github.com/repos/Matroska-Org/ebml-specification","forks_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/forks","keys_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/teams","hooks_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/hooks","issue_events_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/issues/events{/number}","events_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/events","assignees_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/assignees{/user}","branches_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/branches{/branch}","tags_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/tags","blobs_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/git/refs{/sha}","trees_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/statuses/{sha}","languages_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/languages","stargazers_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/stargazers","contributors_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/contributors","subscribers_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/subscribers","subscription_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/subscription","commits_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/commits{/sha}","git_commits_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/git/commits{/sha}","comments_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/comments{/number}","issue_comment_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/issues/comments{/number}","contents_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/contents/{+path}","compare_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/merges","archive_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/downloads","issues_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/issues{/number}","pulls_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/pulls{/number}","milestones_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/milestones{/number}","notifications_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/labels{/name}","releases_url":"https://api.github.com/repos/Matroska-Org/ebml-specification/releases{/id}","created_at":"2015-05-03T17:48:36Z","updated_at":"2015-06-28T10:09:47Z","pushed_at":"2015-07-01T20:16:04Z","git_url":"git://github.com/Matroska-Org/ebml-specification.git","ssh_url":"git@github.com:Matroska-Org/ebml-specification.git","clone_url":"https://github.com/Matroska-Org/ebml-specification.git","svn_url":"https://github.com/Matroska-Org/ebml-specification","homepage":null,"size":358,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":5,"forks":3,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Matroska-Org/ebml-specification/pulls/17"},"html":{"href":"https://github.com/Matroska-Org/ebml-specification/pull/17"},"issue":{"href":"https://api.github.com/repos/Matroska-Org/ebml-specification/issues/17"},"comments":{"href":"https://api.github.com/repos/Matroska-Org/ebml-specification/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/Matroska-Org/ebml-specification/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/Matroska-Org/ebml-specification/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Matroska-Org/ebml-specification/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/Matroska-Org/ebml-specification/statuses/f2c617bdfbd59687ad34e156c6b8a8cebb8697ae"}}}}