{"action":"created","comment":{"url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/pulls/comments/42417030","id":42417030,"diff_hunk":"@@ -40,7 +40,7 @@ def pcdm_collection?\n     end\n \n     def in_objects\n-      aggregated_by.select(&:pcdm_object?)\n+      ordered_by.select(&:pcdm_object?).to_a","path":"lib/hydra/pcdm/models/concerns/object_behavior.rb","position":5,"original_position":5,"commit_id":"13645027ecda5751699950de9b5742feedb05d6d","original_commit_id":"13645027ecda5751699950de9b5742feedb05d6d","user":{"login":"jcoyne","id":92044,"avatar_url":"https://avatars.githubusercontent.com/u/92044?v=3","gravatar_id":"","url":"https://api.github.com/users/jcoyne","html_url":"https://github.com/jcoyne","followers_url":"https://api.github.com/users/jcoyne/followers","following_url":"https://api.github.com/users/jcoyne/following{/other_user}","gists_url":"https://api.github.com/users/jcoyne/gists{/gist_id}","starred_url":"https://api.github.com/users/jcoyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcoyne/subscriptions","organizations_url":"https://api.github.com/users/jcoyne/orgs","repos_url":"https://api.github.com/users/jcoyne/repos","events_url":"https://api.github.com/users/jcoyne/events{/privacy}","received_events_url":"https://api.github.com/users/jcoyne/received_events","type":"User","site_admin":false},"body":"Is the to_a necessary?","created_at":"2015-10-19T19:50:00Z","updated_at":"2015-10-19T19:50:00Z","html_url":"https://github.com/projecthydra-labs/hydra-pcdm/pull/187#discussion_r42417030","pull_request_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/pulls/187","_links":{"self":{"href":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/pulls/comments/42417030"},"html":{"href":"https://github.com/projecthydra-labs/hydra-pcdm/pull/187#discussion_r42417030"},"pull_request":{"href":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/pulls/187"}}},"pull_request":{"url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/pulls/187","id":48113114,"html_url":"https://github.com/projecthydra-labs/hydra-pcdm/pull/187","diff_url":"https://github.com/projecthydra-labs/hydra-pcdm/pull/187.diff","patch_url":"https://github.com/projecthydra-labs/hydra-pcdm/pull/187.patch","issue_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/issues/187","number":187,"state":"open","locked":false,"title":"New ordering","user":{"login":"tpendragon","id":2806645,"avatar_url":"https://avatars.githubusercontent.com/u/2806645?v=3","gravatar_id":"","url":"https://api.github.com/users/tpendragon","html_url":"https://github.com/tpendragon","followers_url":"https://api.github.com/users/tpendragon/followers","following_url":"https://api.github.com/users/tpendragon/following{/other_user}","gists_url":"https://api.github.com/users/tpendragon/gists{/gist_id}","starred_url":"https://api.github.com/users/tpendragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpendragon/subscriptions","organizations_url":"https://api.github.com/users/tpendragon/orgs","repos_url":"https://api.github.com/users/tpendragon/repos","events_url":"https://api.github.com/users/tpendragon/events{/privacy}","received_events_url":"https://api.github.com/users/tpendragon/received_events","type":"User","site_admin":false},"body":"There are a few questions here for me:\r\n\r\n1. This assumes #objects/#collections returns those objects and collections which are ORDERED underneath. Is that a bad assumption? Should there be #objects AND #ordered_objects? (Not looking forward to that, but whatcha gonna do)\r\n\r\n2. Deleting is different here - you can't just do ordered_members.delete(member), because that member can appear in the ordering multiple times. So I'm using delete_at in the specs - should there be something different?","created_at":"2015-10-19T19:12:37Z","updated_at":"2015-10-19T19:50:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ab8bac03e8902171bcbdf43d5820ce0a2c35a84","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/pulls/187/commits","review_comments_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/pulls/187/comments","review_comment_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/issues/187/comments","statuses_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/statuses/13645027ecda5751699950de9b5742feedb05d6d","head":{"label":"projecthydra-labs:new_ordering","ref":"new_ordering","sha":"13645027ecda5751699950de9b5742feedb05d6d","user":{"login":"projecthydra-labs","id":7377013,"avatar_url":"https://avatars.githubusercontent.com/u/7377013?v=3","gravatar_id":"","url":"https://api.github.com/users/projecthydra-labs","html_url":"https://github.com/projecthydra-labs","followers_url":"https://api.github.com/users/projecthydra-labs/followers","following_url":"https://api.github.com/users/projecthydra-labs/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra-labs/subscriptions","organizations_url":"https://api.github.com/users/projecthydra-labs/orgs","repos_url":"https://api.github.com/users/projecthydra-labs/repos","events_url":"https://api.github.com/users/projecthydra-labs/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":32940722,"name":"hydra-pcdm","full_name":"projecthydra-labs/hydra-pcdm","owner":{"login":"projecthydra-labs","id":7377013,"avatar_url":"https://avatars.githubusercontent.com/u/7377013?v=3","gravatar_id":"","url":"https://api.github.com/users/projecthydra-labs","html_url":"https://github.com/projecthydra-labs","followers_url":"https://api.github.com/users/projecthydra-labs/followers","following_url":"https://api.github.com/users/projecthydra-labs/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra-labs/subscriptions","organizations_url":"https://api.github.com/users/projecthydra-labs/orgs","repos_url":"https://api.github.com/users/projecthydra-labs/repos","events_url":"https://api.github.com/users/projecthydra-labs/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projecthydra-labs/hydra-pcdm","description":"Hydra implementation of the PCDM model","fork":false,"url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm","forks_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/forks","keys_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/teams","hooks_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/hooks","issue_events_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/issues/events{/number}","events_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/events","assignees_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/assignees{/user}","branches_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/branches{/branch}","tags_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/tags","blobs_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/git/refs{/sha}","trees_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/statuses/{sha}","languages_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/languages","stargazers_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/stargazers","contributors_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/contributors","subscribers_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/subscribers","subscription_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/subscription","commits_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/commits{/sha}","git_commits_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/git/commits{/sha}","comments_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/comments{/number}","issue_comment_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/issues/comments{/number}","contents_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/contents/{+path}","compare_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/merges","archive_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/downloads","issues_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/issues{/number}","pulls_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/pulls{/number}","milestones_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/milestones{/number}","notifications_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/labels{/name}","releases_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/releases{/id}","created_at":"2015-03-26T17:01:49Z","updated_at":"2015-10-07T14:25:09Z","pushed_at":"2015-10-19T19:16:41Z","git_url":"git://github.com/projecthydra-labs/hydra-pcdm.git","ssh_url":"git@github.com:projecthydra-labs/hydra-pcdm.git","clone_url":"https://github.com/projecthydra-labs/hydra-pcdm.git","svn_url":"https://github.com/projecthydra-labs/hydra-pcdm","homepage":null,"size":21528,"stargazers_count":8,"watchers_count":8,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":23,"forks":6,"open_issues":23,"watchers":8,"default_branch":"master"}},"base":{"label":"projecthydra-labs:master","ref":"master","sha":"463d73a2fd4ba26c1741fecf9c7265fb8770ac3c","user":{"login":"projecthydra-labs","id":7377013,"avatar_url":"https://avatars.githubusercontent.com/u/7377013?v=3","gravatar_id":"","url":"https://api.github.com/users/projecthydra-labs","html_url":"https://github.com/projecthydra-labs","followers_url":"https://api.github.com/users/projecthydra-labs/followers","following_url":"https://api.github.com/users/projecthydra-labs/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra-labs/subscriptions","organizations_url":"https://api.github.com/users/projecthydra-labs/orgs","repos_url":"https://api.github.com/users/projecthydra-labs/repos","events_url":"https://api.github.com/users/projecthydra-labs/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":32940722,"name":"hydra-pcdm","full_name":"projecthydra-labs/hydra-pcdm","owner":{"login":"projecthydra-labs","id":7377013,"avatar_url":"https://avatars.githubusercontent.com/u/7377013?v=3","gravatar_id":"","url":"https://api.github.com/users/projecthydra-labs","html_url":"https://github.com/projecthydra-labs","followers_url":"https://api.github.com/users/projecthydra-labs/followers","following_url":"https://api.github.com/users/projecthydra-labs/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra-labs/subscriptions","organizations_url":"https://api.github.com/users/projecthydra-labs/orgs","repos_url":"https://api.github.com/users/projecthydra-labs/repos","events_url":"https://api.github.com/users/projecthydra-labs/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projecthydra-labs/hydra-pcdm","description":"Hydra implementation of the PCDM model","fork":false,"url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm","forks_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/forks","keys_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/teams","hooks_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/hooks","issue_events_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/issues/events{/number}","events_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/events","assignees_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/assignees{/user}","branches_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/branches{/branch}","tags_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/tags","blobs_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/git/refs{/sha}","trees_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/statuses/{sha}","languages_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/languages","stargazers_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/stargazers","contributors_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/contributors","subscribers_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/subscribers","subscription_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/subscription","commits_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/commits{/sha}","git_commits_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/git/commits{/sha}","comments_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/comments{/number}","issue_comment_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/issues/comments{/number}","contents_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/contents/{+path}","compare_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/merges","archive_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/downloads","issues_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/issues{/number}","pulls_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/pulls{/number}","milestones_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/milestones{/number}","notifications_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/labels{/name}","releases_url":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/releases{/id}","created_at":"2015-03-26T17:01:49Z","updated_at":"2015-10-07T14:25:09Z","pushed_at":"2015-10-19T19:16:41Z","git_url":"git://github.com/projecthydra-labs/hydra-pcdm.git","ssh_url":"git@github.com:projecthydra-labs/hydra-pcdm.git","clone_url":"https://github.com/projecthydra-labs/hydra-pcdm.git","svn_url":"https://github.com/projecthydra-labs/hydra-pcdm","homepage":null,"size":21528,"stargazers_count":8,"watchers_count":8,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":23,"forks":6,"open_issues":23,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/pulls/187"},"html":{"href":"https://github.com/projecthydra-labs/hydra-pcdm/pull/187"},"issue":{"href":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/issues/187"},"comments":{"href":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/issues/187/comments"},"review_comments":{"href":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/pulls/187/comments"},"review_comment":{"href":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/pulls/187/commits"},"statuses":{"href":"https://api.github.com/repos/projecthydra-labs/hydra-pcdm/statuses/13645027ecda5751699950de9b5742feedb05d6d"}}}}