{"action":"created","issue":{"url":"https://api.github.com/repos/matplotlib/matplotlib/issues/5057","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/5057/labels{/name}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/5057/comments","events_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/5057/events","html_url":"https://github.com/matplotlib/matplotlib/pull/5057","id":106237985,"number":5057,"title":"Use HiDPI icons for PyQt5","user":{"login":"astrofrog","id":314716,"avatar_url":"https://avatars.githubusercontent.com/u/314716?v=3","gravatar_id":"","url":"https://api.github.com/users/astrofrog","html_url":"https://github.com/astrofrog","followers_url":"https://api.github.com/users/astrofrog/followers","following_url":"https://api.github.com/users/astrofrog/following{/other_user}","gists_url":"https://api.github.com/users/astrofrog/gists{/gist_id}","starred_url":"https://api.github.com/users/astrofrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astrofrog/subscriptions","organizations_url":"https://api.github.com/users/astrofrog/orgs","repos_url":"https://api.github.com/users/astrofrog/repos","events_url":"https://api.github.com/users/astrofrog/events{/privacy}","received_events_url":"https://api.github.com/users/astrofrog/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/matplotlib/matplotlib/labels/GUI/Qt","name":"GUI/Qt","color":"d4c5f9"},{"url":"https://api.github.com/repos/matplotlib/matplotlib/labels/needs_review","name":"needs_review","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/12","html_url":"https://github.com/matplotlib/matplotlib/milestones/proposed%20next%20point%20release","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/12/labels","id":534144,"number":12,"title":"proposed next point release","description":"","creator":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars.githubusercontent.com/u/199813?v=3","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"open_issues":402,"closed_issues":236,"state":"open","created_at":"2014-01-13T03:21:09Z","updated_at":"2015-09-13T21:09:36Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2015-09-13T20:30:00Z","updated_at":"2015-09-14T15:19:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/5057","html_url":"https://github.com/matplotlib/matplotlib/pull/5057","diff_url":"https://github.com/matplotlib/matplotlib/pull/5057.diff","patch_url":"https://github.com/matplotlib/matplotlib/pull/5057.patch"},"body":"This partially addresses https://github.com/matplotlib/matplotlib/issues/4978, by adding and using HiDPI PNG icons for the PyQt5 framework.\r\n\r\n**Before:**\r\n\r\n![mb_before](https://cloud.githubusercontent.com/assets/314716/9838813/bd49a3da-5a66-11e5-9bc9-2b09761c55b4.png)\r\n\r\n**After:**\r\n\r\n![mb_after](https://cloud.githubusercontent.com/assets/314716/9838816/cb134a70-5a66-11e5-92ec-3008a2d4e076.png)\r\n\r\nNote that I had to adjust the toolbar height and spacing because otherwise it ended up more condensed than before for some reason.\r\n\r\n**Note:** I'm not aware of a reliable way to determine the DPI of a display so at the moment this always uses the HiDPI icons when using PyQt5. It would be great if someone could check that this still looks fine (and no worse than before)"},"comment":{"url":"https://api.github.com/repos/matplotlib/matplotlib/issues/comments/140113743","html_url":"https://github.com/matplotlib/matplotlib/pull/5057#issuecomment-140113743","issue_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/5057","id":140113743,"user":{"login":"astrofrog","id":314716,"avatar_url":"https://avatars.githubusercontent.com/u/314716?v=3","gravatar_id":"","url":"https://api.github.com/users/astrofrog","html_url":"https://github.com/astrofrog","followers_url":"https://api.github.com/users/astrofrog/followers","following_url":"https://api.github.com/users/astrofrog/following{/other_user}","gists_url":"https://api.github.com/users/astrofrog/gists{/gist_id}","starred_url":"https://api.github.com/users/astrofrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astrofrog/subscriptions","organizations_url":"https://api.github.com/users/astrofrog/orgs","repos_url":"https://api.github.com/users/astrofrog/repos","events_url":"https://api.github.com/users/astrofrog/events{/privacy}","received_events_url":"https://api.github.com/users/astrofrog/received_events","type":"User","site_admin":false},"created_at":"2015-09-14T15:19:15Z","updated_at":"2015-09-14T15:19:15Z","body":"@tacaswell - although it looks like this was actually changed *to* PNG in the past for Qt4:\r\n\r\nhttps://github.com/matplotlib/matplotlib/commit/c61df400d96d3e7b86fd6855e265f1ef25286001\r\n\r\nhttps://github.com/matplotlib/matplotlib/pull/143\r\n\r\nhttp://sourceforge.net/p/matplotlib/mailman/matplotlib-users/thread/4D4EA423.5090802@vanderHoeven.biz/\r\n\r\nSounds like this caused some issues on Windows? This was 4 years ago though, so maybe things have changed?"}}