{"action":"closed","number":291,"pull_request":{"url":"https://api.github.com/repos/deeplearning4j/nd4j/pulls/291","id":42382932,"html_url":"https://github.com/deeplearning4j/nd4j/pull/291","diff_url":"https://github.com/deeplearning4j/nd4j/pull/291.diff","patch_url":"https://github.com/deeplearning4j/nd4j/pull/291.patch","issue_url":"https://api.github.com/repos/deeplearning4j/nd4j/issues/291","number":291,"state":"closed","locked":false,"title":"Should not allow out of index","user":{"login":"bmsantos","id":4486595,"avatar_url":"https://avatars.githubusercontent.com/u/4486595?v=3","gravatar_id":"","url":"https://api.github.com/users/bmsantos","html_url":"https://github.com/bmsantos","followers_url":"https://api.github.com/users/bmsantos/followers","following_url":"https://api.github.com/users/bmsantos/following{/other_user}","gists_url":"https://api.github.com/users/bmsantos/gists{/gist_id}","starred_url":"https://api.github.com/users/bmsantos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmsantos/subscriptions","organizations_url":"https://api.github.com/users/bmsantos/orgs","repos_url":"https://api.github.com/users/bmsantos/repos","events_url":"https://api.github.com/users/bmsantos/events{/privacy}","received_events_url":"https://api.github.com/users/bmsantos/received_events","type":"User","site_admin":false},"body":"Problem: This issue was raised while trying to execute the DBNIrisExample in current state of [DL4J examples](https://github.com/deeplearning4j/dl4j-0.0.3.3-examples).\r\n\r\nImplemented solution: Moved if condition up in order to guard the intendedIndexes array so that it does not go out of its boundary. \r\n\r\nNote: I'm not really sure if this is even the correct solution. I'm having a hard time understanding what is actually supposed to happen in the method but it seems that there's a smell in the actual implementation since a new \"all\" array is created to include the allIndexes + new ones in intendedIndexes and then the iteration only happens for the allIndexes. The new ones will never be inserted at the end of the \"all\" list.","created_at":"2015-08-13T18:30:11Z","updated_at":"2015-08-13T22:00:50Z","closed_at":"2015-08-13T22:00:50Z","merged_at":"2015-08-13T22:00:50Z","merge_commit_sha":"885b9ea33dad540db40de5016a730724aa958103","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/deeplearning4j/nd4j/pulls/291/commits","review_comments_url":"https://api.github.com/repos/deeplearning4j/nd4j/pulls/291/comments","review_comment_url":"https://api.github.com/repos/deeplearning4j/nd4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deeplearning4j/nd4j/issues/291/comments","statuses_url":"https://api.github.com/repos/deeplearning4j/nd4j/statuses/0b7bff15bcd2cdb258e4713bafcf0dbc3311d5bd","head":{"label":"bmsantos:master","ref":"master","sha":"0b7bff15bcd2cdb258e4713bafcf0dbc3311d5bd","user":{"login":"bmsantos","id":4486595,"avatar_url":"https://avatars.githubusercontent.com/u/4486595?v=3","gravatar_id":"","url":"https://api.github.com/users/bmsantos","html_url":"https://github.com/bmsantos","followers_url":"https://api.github.com/users/bmsantos/followers","following_url":"https://api.github.com/users/bmsantos/following{/other_user}","gists_url":"https://api.github.com/users/bmsantos/gists{/gist_id}","starred_url":"https://api.github.com/users/bmsantos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmsantos/subscriptions","organizations_url":"https://api.github.com/users/bmsantos/orgs","repos_url":"https://api.github.com/users/bmsantos/repos","events_url":"https://api.github.com/users/bmsantos/events{/privacy}","received_events_url":"https://api.github.com/users/bmsantos/received_events","type":"User","site_admin":false},"repo":{"id":40668749,"name":"nd4j","full_name":"bmsantos/nd4j","owner":{"login":"bmsantos","id":4486595,"avatar_url":"https://avatars.githubusercontent.com/u/4486595?v=3","gravatar_id":"","url":"https://api.github.com/users/bmsantos","html_url":"https://github.com/bmsantos","followers_url":"https://api.github.com/users/bmsantos/followers","following_url":"https://api.github.com/users/bmsantos/following{/other_user}","gists_url":"https://api.github.com/users/bmsantos/gists{/gist_id}","starred_url":"https://api.github.com/users/bmsantos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmsantos/subscriptions","organizations_url":"https://api.github.com/users/bmsantos/orgs","repos_url":"https://api.github.com/users/bmsantos/repos","events_url":"https://api.github.com/users/bmsantos/events{/privacy}","received_events_url":"https://api.github.com/users/bmsantos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bmsantos/nd4j","description":"Scientific Computing for the JVM (NDArrays)","fork":true,"url":"https://api.github.com/repos/bmsantos/nd4j","forks_url":"https://api.github.com/repos/bmsantos/nd4j/forks","keys_url":"https://api.github.com/repos/bmsantos/nd4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bmsantos/nd4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bmsantos/nd4j/teams","hooks_url":"https://api.github.com/repos/bmsantos/nd4j/hooks","issue_events_url":"https://api.github.com/repos/bmsantos/nd4j/issues/events{/number}","events_url":"https://api.github.com/repos/bmsantos/nd4j/events","assignees_url":"https://api.github.com/repos/bmsantos/nd4j/assignees{/user}","branches_url":"https://api.github.com/repos/bmsantos/nd4j/branches{/branch}","tags_url":"https://api.github.com/repos/bmsantos/nd4j/tags","blobs_url":"https://api.github.com/repos/bmsantos/nd4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bmsantos/nd4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bmsantos/nd4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/bmsantos/nd4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bmsantos/nd4j/statuses/{sha}","languages_url":"https://api.github.com/repos/bmsantos/nd4j/languages","stargazers_url":"https://api.github.com/repos/bmsantos/nd4j/stargazers","contributors_url":"https://api.github.com/repos/bmsantos/nd4j/contributors","subscribers_url":"https://api.github.com/repos/bmsantos/nd4j/subscribers","subscription_url":"https://api.github.com/repos/bmsantos/nd4j/subscription","commits_url":"https://api.github.com/repos/bmsantos/nd4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/bmsantos/nd4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/bmsantos/nd4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/bmsantos/nd4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/bmsantos/nd4j/contents/{+path}","compare_url":"https://api.github.com/repos/bmsantos/nd4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bmsantos/nd4j/merges","archive_url":"https://api.github.com/repos/bmsantos/nd4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bmsantos/nd4j/downloads","issues_url":"https://api.github.com/repos/bmsantos/nd4j/issues{/number}","pulls_url":"https://api.github.com/repos/bmsantos/nd4j/pulls{/number}","milestones_url":"https://api.github.com/repos/bmsantos/nd4j/milestones{/number}","notifications_url":"https://api.github.com/repos/bmsantos/nd4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bmsantos/nd4j/labels{/name}","releases_url":"https://api.github.com/repos/bmsantos/nd4j/releases{/id}","created_at":"2015-08-13T16:14:31Z","updated_at":"2015-08-13T16:14:34Z","pushed_at":"2015-08-13T18:17:26Z","git_url":"git://github.com/bmsantos/nd4j.git","ssh_url":"git@github.com:bmsantos/nd4j.git","clone_url":"https://github.com/bmsantos/nd4j.git","svn_url":"https://github.com/bmsantos/nd4j","homepage":"http://nd4j.org","size":105137,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deeplearning4j:master","ref":"master","sha":"fd87e62c138a63c1d838b3cccc30c973185c384c","user":{"login":"deeplearning4j","id":10988606,"avatar_url":"https://avatars.githubusercontent.com/u/10988606?v=3","gravatar_id":"","url":"https://api.github.com/users/deeplearning4j","html_url":"https://github.com/deeplearning4j","followers_url":"https://api.github.com/users/deeplearning4j/followers","following_url":"https://api.github.com/users/deeplearning4j/following{/other_user}","gists_url":"https://api.github.com/users/deeplearning4j/gists{/gist_id}","starred_url":"https://api.github.com/users/deeplearning4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deeplearning4j/subscriptions","organizations_url":"https://api.github.com/users/deeplearning4j/orgs","repos_url":"https://api.github.com/users/deeplearning4j/repos","events_url":"https://api.github.com/users/deeplearning4j/events{/privacy}","received_events_url":"https://api.github.com/users/deeplearning4j/received_events","type":"Organization","site_admin":false},"repo":{"id":23505879,"name":"nd4j","full_name":"deeplearning4j/nd4j","owner":{"login":"deeplearning4j","id":10988606,"avatar_url":"https://avatars.githubusercontent.com/u/10988606?v=3","gravatar_id":"","url":"https://api.github.com/users/deeplearning4j","html_url":"https://github.com/deeplearning4j","followers_url":"https://api.github.com/users/deeplearning4j/followers","following_url":"https://api.github.com/users/deeplearning4j/following{/other_user}","gists_url":"https://api.github.com/users/deeplearning4j/gists{/gist_id}","starred_url":"https://api.github.com/users/deeplearning4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deeplearning4j/subscriptions","organizations_url":"https://api.github.com/users/deeplearning4j/orgs","repos_url":"https://api.github.com/users/deeplearning4j/repos","events_url":"https://api.github.com/users/deeplearning4j/events{/privacy}","received_events_url":"https://api.github.com/users/deeplearning4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deeplearning4j/nd4j","description":"Scientific Computing for the JVM (NDArrays)","fork":false,"url":"https://api.github.com/repos/deeplearning4j/nd4j","forks_url":"https://api.github.com/repos/deeplearning4j/nd4j/forks","keys_url":"https://api.github.com/repos/deeplearning4j/nd4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deeplearning4j/nd4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deeplearning4j/nd4j/teams","hooks_url":"https://api.github.com/repos/deeplearning4j/nd4j/hooks","issue_events_url":"https://api.github.com/repos/deeplearning4j/nd4j/issues/events{/number}","events_url":"https://api.github.com/repos/deeplearning4j/nd4j/events","assignees_url":"https://api.github.com/repos/deeplearning4j/nd4j/assignees{/user}","branches_url":"https://api.github.com/repos/deeplearning4j/nd4j/branches{/branch}","tags_url":"https://api.github.com/repos/deeplearning4j/nd4j/tags","blobs_url":"https://api.github.com/repos/deeplearning4j/nd4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deeplearning4j/nd4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deeplearning4j/nd4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/deeplearning4j/nd4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deeplearning4j/nd4j/statuses/{sha}","languages_url":"https://api.github.com/repos/deeplearning4j/nd4j/languages","stargazers_url":"https://api.github.com/repos/deeplearning4j/nd4j/stargazers","contributors_url":"https://api.github.com/repos/deeplearning4j/nd4j/contributors","subscribers_url":"https://api.github.com/repos/deeplearning4j/nd4j/subscribers","subscription_url":"https://api.github.com/repos/deeplearning4j/nd4j/subscription","commits_url":"https://api.github.com/repos/deeplearning4j/nd4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/deeplearning4j/nd4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/deeplearning4j/nd4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/deeplearning4j/nd4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/deeplearning4j/nd4j/contents/{+path}","compare_url":"https://api.github.com/repos/deeplearning4j/nd4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deeplearning4j/nd4j/merges","archive_url":"https://api.github.com/repos/deeplearning4j/nd4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deeplearning4j/nd4j/downloads","issues_url":"https://api.github.com/repos/deeplearning4j/nd4j/issues{/number}","pulls_url":"https://api.github.com/repos/deeplearning4j/nd4j/pulls{/number}","milestones_url":"https://api.github.com/repos/deeplearning4j/nd4j/milestones{/number}","notifications_url":"https://api.github.com/repos/deeplearning4j/nd4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deeplearning4j/nd4j/labels{/name}","releases_url":"https://api.github.com/repos/deeplearning4j/nd4j/releases{/id}","created_at":"2014-08-31T03:47:00Z","updated_at":"2015-08-13T18:28:54Z","pushed_at":"2015-08-13T22:00:50Z","git_url":"git://github.com/deeplearning4j/nd4j.git","ssh_url":"git@github.com:deeplearning4j/nd4j.git","clone_url":"https://github.com/deeplearning4j/nd4j.git","svn_url":"https://github.com/deeplearning4j/nd4j","homepage":"http://nd4j.org","size":113353,"stargazers_count":184,"watchers_count":184,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":101,"mirror_url":null,"open_issues_count":16,"forks":101,"open_issues":16,"watchers":184,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deeplearning4j/nd4j/pulls/291"},"html":{"href":"https://github.com/deeplearning4j/nd4j/pull/291"},"issue":{"href":"https://api.github.com/repos/deeplearning4j/nd4j/issues/291"},"comments":{"href":"https://api.github.com/repos/deeplearning4j/nd4j/issues/291/comments"},"review_comments":{"href":"https://api.github.com/repos/deeplearning4j/nd4j/pulls/291/comments"},"review_comment":{"href":"https://api.github.com/repos/deeplearning4j/nd4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deeplearning4j/nd4j/pulls/291/commits"},"statuses":{"href":"https://api.github.com/repos/deeplearning4j/nd4j/statuses/0b7bff15bcd2cdb258e4713bafcf0dbc3311d5bd"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"agibsonccc","id":1144306,"avatar_url":"https://avatars.githubusercontent.com/u/1144306?v=3","gravatar_id":"","url":"https://api.github.com/users/agibsonccc","html_url":"https://github.com/agibsonccc","followers_url":"https://api.github.com/users/agibsonccc/followers","following_url":"https://api.github.com/users/agibsonccc/following{/other_user}","gists_url":"https://api.github.com/users/agibsonccc/gists{/gist_id}","starred_url":"https://api.github.com/users/agibsonccc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agibsonccc/subscriptions","organizations_url":"https://api.github.com/users/agibsonccc/orgs","repos_url":"https://api.github.com/users/agibsonccc/repos","events_url":"https://api.github.com/users/agibsonccc/events{/privacy}","received_events_url":"https://api.github.com/users/agibsonccc/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":6,"deletions":6,"changed_files":1}}