{"action":"closed","number":1898,"pull_request":{"url":"https://api.github.com/repos/mpv-player/mpv/pulls/1898","id":34540047,"html_url":"https://github.com/mpv-player/mpv/pull/1898","diff_url":"https://github.com/mpv-player/mpv/pull/1898.diff","patch_url":"https://github.com/mpv-player/mpv/pull/1898.patch","issue_url":"https://api.github.com/repos/mpv-player/mpv/issues/1898","number":1898,"state":"closed","locked":false,"title":"vo: restore normal frame drops logic on high playback rate","user":{"login":"avih","id":2164962,"avatar_url":"https://avatars.githubusercontent.com/u/2164962?v=3","gravatar_id":"","url":"https://api.github.com/users/avih","html_url":"https://github.com/avih","followers_url":"https://api.github.com/users/avih/followers","following_url":"https://api.github.com/users/avih/following{/other_user}","gists_url":"https://api.github.com/users/avih/gists{/gist_id}","starred_url":"https://api.github.com/users/avih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avih/subscriptions","organizations_url":"https://api.github.com/users/avih/orgs","repos_url":"https://api.github.com/users/avih/repos","events_url":"https://api.github.com/users/avih/events{/privacy}","received_events_url":"https://api.github.com/users/avih/received_events","type":"User","site_admin":false},"body":"commit f1746741dee6000b7fd139e7a10f72aba0674b3b changed the drop\r\nlogic to have more slack (drop more frames but less frequent) to prevent\r\ndrops due to timing jitter when the clip and screen have similar rates.\r\n\r\nhowever, if the clip has higher rate than the screen (or just high\r\nplayback speed), then that policy hurts smoothness since these \"chunked\r\ndrops\" look worse than one frame drop at a time.\r\n\r\nthis patch restores the old drop logic when the playback frame rate is\r\nhigher than ~5% above the screen refresh rate, and solves this issue.\r\n\r\nFixes #1897","created_at":"2015-05-01T14:29:00Z","updated_at":"2015-05-01T16:16:08Z","closed_at":"2015-05-01T16:16:07Z","merged_at":"2015-05-01T16:16:07Z","merge_commit_sha":"a0f439496283f3b9337e7cc6b031a3e947a19017","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mpv-player/mpv/pulls/1898/commits","review_comments_url":"https://api.github.com/repos/mpv-player/mpv/pulls/1898/comments","review_comment_url":"https://api.github.com/repos/mpv-player/mpv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mpv-player/mpv/issues/1898/comments","statuses_url":"https://api.github.com/repos/mpv-player/mpv/statuses/ffcad1a72b9a3bf5a7ac5ddcbfa71ec19b6faf9b","head":{"label":"avih:PR-frame-drop","ref":"PR-frame-drop","sha":"ffcad1a72b9a3bf5a7ac5ddcbfa71ec19b6faf9b","user":{"login":"avih","id":2164962,"avatar_url":"https://avatars.githubusercontent.com/u/2164962?v=3","gravatar_id":"","url":"https://api.github.com/users/avih","html_url":"https://github.com/avih","followers_url":"https://api.github.com/users/avih/followers","following_url":"https://api.github.com/users/avih/following{/other_user}","gists_url":"https://api.github.com/users/avih/gists{/gist_id}","starred_url":"https://api.github.com/users/avih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avih/subscriptions","organizations_url":"https://api.github.com/users/avih/orgs","repos_url":"https://api.github.com/users/avih/repos","events_url":"https://api.github.com/users/avih/events{/privacy}","received_events_url":"https://api.github.com/users/avih/received_events","type":"User","site_admin":false},"repo":{"id":17341571,"name":"mpv","full_name":"avih/mpv","owner":{"login":"avih","id":2164962,"avatar_url":"https://avatars.githubusercontent.com/u/2164962?v=3","gravatar_id":"","url":"https://api.github.com/users/avih","html_url":"https://github.com/avih","followers_url":"https://api.github.com/users/avih/followers","following_url":"https://api.github.com/users/avih/following{/other_user}","gists_url":"https://api.github.com/users/avih/gists{/gist_id}","starred_url":"https://api.github.com/users/avih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avih/subscriptions","organizations_url":"https://api.github.com/users/avih/orgs","repos_url":"https://api.github.com/users/avih/repos","events_url":"https://api.github.com/users/avih/events{/privacy}","received_events_url":"https://api.github.com/users/avih/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/avih/mpv","description":"Video player based on MPlayer/mplayer2","fork":true,"url":"https://api.github.com/repos/avih/mpv","forks_url":"https://api.github.com/repos/avih/mpv/forks","keys_url":"https://api.github.com/repos/avih/mpv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/avih/mpv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/avih/mpv/teams","hooks_url":"https://api.github.com/repos/avih/mpv/hooks","issue_events_url":"https://api.github.com/repos/avih/mpv/issues/events{/number}","events_url":"https://api.github.com/repos/avih/mpv/events","assignees_url":"https://api.github.com/repos/avih/mpv/assignees{/user}","branches_url":"https://api.github.com/repos/avih/mpv/branches{/branch}","tags_url":"https://api.github.com/repos/avih/mpv/tags","blobs_url":"https://api.github.com/repos/avih/mpv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/avih/mpv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/avih/mpv/git/refs{/sha}","trees_url":"https://api.github.com/repos/avih/mpv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/avih/mpv/statuses/{sha}","languages_url":"https://api.github.com/repos/avih/mpv/languages","stargazers_url":"https://api.github.com/repos/avih/mpv/stargazers","contributors_url":"https://api.github.com/repos/avih/mpv/contributors","subscribers_url":"https://api.github.com/repos/avih/mpv/subscribers","subscription_url":"https://api.github.com/repos/avih/mpv/subscription","commits_url":"https://api.github.com/repos/avih/mpv/commits{/sha}","git_commits_url":"https://api.github.com/repos/avih/mpv/git/commits{/sha}","comments_url":"https://api.github.com/repos/avih/mpv/comments{/number}","issue_comment_url":"https://api.github.com/repos/avih/mpv/issues/comments{/number}","contents_url":"https://api.github.com/repos/avih/mpv/contents/{+path}","compare_url":"https://api.github.com/repos/avih/mpv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/avih/mpv/merges","archive_url":"https://api.github.com/repos/avih/mpv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/avih/mpv/downloads","issues_url":"https://api.github.com/repos/avih/mpv/issues{/number}","pulls_url":"https://api.github.com/repos/avih/mpv/pulls{/number}","milestones_url":"https://api.github.com/repos/avih/mpv/milestones{/number}","notifications_url":"https://api.github.com/repos/avih/mpv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/avih/mpv/labels{/name}","releases_url":"https://api.github.com/repos/avih/mpv/releases{/id}","created_at":"2014-03-02T16:37:09Z","updated_at":"2015-04-30T22:01:41Z","pushed_at":"2015-05-01T16:12:44Z","git_url":"git://github.com/avih/mpv.git","ssh_url":"git@github.com:avih/mpv.git","clone_url":"https://github.com/avih/mpv.git","svn_url":"https://github.com/avih/mpv","homepage":"http://mpv.io","size":69644,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mpv-player:master","ref":"master","sha":"d01228058b03df33a3c6be3acbf2757019a9cd83","user":{"login":"mpv-player","id":2550273,"avatar_url":"https://avatars.githubusercontent.com/u/2550273?v=3","gravatar_id":"","url":"https://api.github.com/users/mpv-player","html_url":"https://github.com/mpv-player","followers_url":"https://api.github.com/users/mpv-player/followers","following_url":"https://api.github.com/users/mpv-player/following{/other_user}","gists_url":"https://api.github.com/users/mpv-player/gists{/gist_id}","starred_url":"https://api.github.com/users/mpv-player/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpv-player/subscriptions","organizations_url":"https://api.github.com/users/mpv-player/orgs","repos_url":"https://api.github.com/users/mpv-player/repos","events_url":"https://api.github.com/users/mpv-player/events{/privacy}","received_events_url":"https://api.github.com/users/mpv-player/received_events","type":"Organization","site_admin":false},"repo":{"id":6201092,"name":"mpv","full_name":"mpv-player/mpv","owner":{"login":"mpv-player","id":2550273,"avatar_url":"https://avatars.githubusercontent.com/u/2550273?v=3","gravatar_id":"","url":"https://api.github.com/users/mpv-player","html_url":"https://github.com/mpv-player","followers_url":"https://api.github.com/users/mpv-player/followers","following_url":"https://api.github.com/users/mpv-player/following{/other_user}","gists_url":"https://api.github.com/users/mpv-player/gists{/gist_id}","starred_url":"https://api.github.com/users/mpv-player/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpv-player/subscriptions","organizations_url":"https://api.github.com/users/mpv-player/orgs","repos_url":"https://api.github.com/users/mpv-player/repos","events_url":"https://api.github.com/users/mpv-player/events{/privacy}","received_events_url":"https://api.github.com/users/mpv-player/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mpv-player/mpv","description":"Video player based on MPlayer/mplayer2","fork":false,"url":"https://api.github.com/repos/mpv-player/mpv","forks_url":"https://api.github.com/repos/mpv-player/mpv/forks","keys_url":"https://api.github.com/repos/mpv-player/mpv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mpv-player/mpv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mpv-player/mpv/teams","hooks_url":"https://api.github.com/repos/mpv-player/mpv/hooks","issue_events_url":"https://api.github.com/repos/mpv-player/mpv/issues/events{/number}","events_url":"https://api.github.com/repos/mpv-player/mpv/events","assignees_url":"https://api.github.com/repos/mpv-player/mpv/assignees{/user}","branches_url":"https://api.github.com/repos/mpv-player/mpv/branches{/branch}","tags_url":"https://api.github.com/repos/mpv-player/mpv/tags","blobs_url":"https://api.github.com/repos/mpv-player/mpv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mpv-player/mpv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mpv-player/mpv/git/refs{/sha}","trees_url":"https://api.github.com/repos/mpv-player/mpv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mpv-player/mpv/statuses/{sha}","languages_url":"https://api.github.com/repos/mpv-player/mpv/languages","stargazers_url":"https://api.github.com/repos/mpv-player/mpv/stargazers","contributors_url":"https://api.github.com/repos/mpv-player/mpv/contributors","subscribers_url":"https://api.github.com/repos/mpv-player/mpv/subscribers","subscription_url":"https://api.github.com/repos/mpv-player/mpv/subscription","commits_url":"https://api.github.com/repos/mpv-player/mpv/commits{/sha}","git_commits_url":"https://api.github.com/repos/mpv-player/mpv/git/commits{/sha}","comments_url":"https://api.github.com/repos/mpv-player/mpv/comments{/number}","issue_comment_url":"https://api.github.com/repos/mpv-player/mpv/issues/comments{/number}","contents_url":"https://api.github.com/repos/mpv-player/mpv/contents/{+path}","compare_url":"https://api.github.com/repos/mpv-player/mpv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mpv-player/mpv/merges","archive_url":"https://api.github.com/repos/mpv-player/mpv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mpv-player/mpv/downloads","issues_url":"https://api.github.com/repos/mpv-player/mpv/issues{/number}","pulls_url":"https://api.github.com/repos/mpv-player/mpv/pulls{/number}","milestones_url":"https://api.github.com/repos/mpv-player/mpv/milestones{/number}","notifications_url":"https://api.github.com/repos/mpv-player/mpv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mpv-player/mpv/labels{/name}","releases_url":"https://api.github.com/repos/mpv-player/mpv/releases{/id}","created_at":"2012-10-13T08:08:44Z","updated_at":"2015-05-01T16:16:06Z","pushed_at":"2015-05-01T16:16:06Z","git_url":"git://github.com/mpv-player/mpv.git","ssh_url":"git@github.com:mpv-player/mpv.git","clone_url":"https://github.com/mpv-player/mpv.git","svn_url":"https://github.com/mpv-player/mpv","homepage":"http://mpv.io","size":99417,"stargazers_count":1787,"watchers_count":1787,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":244,"mirror_url":null,"open_issues_count":206,"forks":244,"open_issues":206,"watchers":1787,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mpv-player/mpv/pulls/1898"},"html":{"href":"https://github.com/mpv-player/mpv/pull/1898"},"issue":{"href":"https://api.github.com/repos/mpv-player/mpv/issues/1898"},"comments":{"href":"https://api.github.com/repos/mpv-player/mpv/issues/1898/comments"},"review_comments":{"href":"https://api.github.com/repos/mpv-player/mpv/pulls/1898/comments"},"review_comment":{"href":"https://api.github.com/repos/mpv-player/mpv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mpv-player/mpv/pulls/1898/commits"},"statuses":{"href":"https://api.github.com/repos/mpv-player/mpv/statuses/ffcad1a72b9a3bf5a7ac5ddcbfa71ec19b6faf9b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"wm4","id":1387750,"avatar_url":"https://avatars.githubusercontent.com/u/1387750?v=3","gravatar_id":"","url":"https://api.github.com/users/wm4","html_url":"https://github.com/wm4","followers_url":"https://api.github.com/users/wm4/followers","following_url":"https://api.github.com/users/wm4/following{/other_user}","gists_url":"https://api.github.com/users/wm4/gists{/gist_id}","starred_url":"https://api.github.com/users/wm4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wm4/subscriptions","organizations_url":"https://api.github.com/users/wm4/orgs","repos_url":"https://api.github.com/users/wm4/repos","events_url":"https://api.github.com/users/wm4/events{/privacy}","received_events_url":"https://api.github.com/users/wm4/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":11,"deletions":3,"changed_files":1}}