{"action":"created","comment":{"url":"https://api.github.com/repos/d-ronin/dRonin/pulls/comments/47115669","id":47115669,"diff_hunk":"@@ -23,8 +23,8 @@\n             <description>When enabled, the motors will spin at the ChannelNeutral command when armed with zero throttle.</description>\n         </field>\n \n-        <field name=\"MotorInputOutputCurveFit\" units=\"-\" type=\"float\" elementnames=\"A,B\" defaultvalue=\"1,1\">\n-            <description>Actuator mapping of input in [-1,1] to output on [-1,1], using power equation of type a*x^b.</description>\n+        <field name=\"MotorInputOutputCurveFit\" units=\"-\" type=\"float\" elements=\"1\" defaultvalue=\"1\">","path":"shared/uavobjectdefinition/actuatorsettings.xml","position":6,"original_position":6,"commit_id":"5af5c17596f7d764374dcc60c94c8755981d21c6","original_commit_id":"5af5c17596f7d764374dcc60c94c8755981d21c6","user":{"login":"mlyle","id":90903,"avatar_url":"https://avatars.githubusercontent.com/u/90903?v=3","gravatar_id":"","url":"https://api.github.com/users/mlyle","html_url":"https://github.com/mlyle","followers_url":"https://api.github.com/users/mlyle/followers","following_url":"https://api.github.com/users/mlyle/following{/other_user}","gists_url":"https://api.github.com/users/mlyle/gists{/gist_id}","starred_url":"https://api.github.com/users/mlyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlyle/subscriptions","organizations_url":"https://api.github.com/users/mlyle/orgs","repos_url":"https://api.github.com/users/mlyle/repos","events_url":"https://api.github.com/users/mlyle/events{/privacy}","received_events_url":"https://api.github.com/users/mlyle/received_events","type":"User","site_admin":false},"body":"> The data seems to show that the \"meat\" of the curve, i.e. the center point where the propeller spends most of its time, is a better fit with two parameters.\r\n\r\nWhatever output setting results in a hover does not change by multiplication.\r\n\r\nMultiplying a function by something does not make the corresponding \"output\" part of the function more linear.\r\n\r\nThe shape of the curve where hover occurs (or a given speed of forward flight) does not change by virtue of multiplication.","created_at":"2015-12-09T16:39:47Z","updated_at":"2015-12-09T16:39:47Z","html_url":"https://github.com/d-ronin/dRonin/pull/151#discussion_r47115669","pull_request_url":"https://api.github.com/repos/d-ronin/dRonin/pulls/151","_links":{"self":{"href":"https://api.github.com/repos/d-ronin/dRonin/pulls/comments/47115669"},"html":{"href":"https://github.com/d-ronin/dRonin/pull/151#discussion_r47115669"},"pull_request":{"href":"https://api.github.com/repos/d-ronin/dRonin/pulls/151"}}},"pull_request":{"url":"https://api.github.com/repos/d-ronin/dRonin/pulls/151","id":52749957,"html_url":"https://github.com/d-ronin/dRonin/pull/151","diff_url":"https://github.com/d-ronin/dRonin/pull/151.diff","patch_url":"https://github.com/d-ronin/dRonin/pull/151.patch","issue_url":"https://api.github.com/repos/d-ronin/dRonin/issues/151","number":151,"state":"open","locked":false,"title":"flight: f1: use expf/powf approximations to hopefully drop fewer points","user":{"login":"mlyle","id":90903,"avatar_url":"https://avatars.githubusercontent.com/u/90903?v=3","gravatar_id":"","url":"https://api.github.com/users/mlyle","html_url":"https://github.com/mlyle","followers_url":"https://api.github.com/users/mlyle/followers","following_url":"https://api.github.com/users/mlyle/following{/other_user}","gists_url":"https://api.github.com/users/mlyle/gists{/gist_id}","starred_url":"https://api.github.com/users/mlyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlyle/subscriptions","organizations_url":"https://api.github.com/users/mlyle/orgs","repos_url":"https://api.github.com/users/mlyle/repos","events_url":"https://api.github.com/users/mlyle/events{/privacy}","received_events_url":"https://api.github.com/users/mlyle/received_events","type":"User","site_admin":false},"body":"issue #112\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/d-ronin/dronin/151)\n<!-- Reviewable:end -->\n","created_at":"2015-12-05T08:01:39Z","updated_at":"2015-12-09T16:39:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c00f099c0fb6c01db9bb0e9e98a148e3a0dd853","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/d-ronin/dRonin/pulls/151/commits","review_comments_url":"https://api.github.com/repos/d-ronin/dRonin/pulls/151/comments","review_comment_url":"https://api.github.com/repos/d-ronin/dRonin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/d-ronin/dRonin/issues/151/comments","statuses_url":"https://api.github.com/repos/d-ronin/dRonin/statuses/5af5c17596f7d764374dcc60c94c8755981d21c6","head":{"label":"mlyle:mpl-helpforf1","ref":"mpl-helpforf1","sha":"5af5c17596f7d764374dcc60c94c8755981d21c6","user":{"login":"mlyle","id":90903,"avatar_url":"https://avatars.githubusercontent.com/u/90903?v=3","gravatar_id":"","url":"https://api.github.com/users/mlyle","html_url":"https://github.com/mlyle","followers_url":"https://api.github.com/users/mlyle/followers","following_url":"https://api.github.com/users/mlyle/following{/other_user}","gists_url":"https://api.github.com/users/mlyle/gists{/gist_id}","starred_url":"https://api.github.com/users/mlyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlyle/subscriptions","organizations_url":"https://api.github.com/users/mlyle/orgs","repos_url":"https://api.github.com/users/mlyle/repos","events_url":"https://api.github.com/users/mlyle/events{/privacy}","received_events_url":"https://api.github.com/users/mlyle/received_events","type":"User","site_admin":false},"repo":{"id":43623642,"name":"dronin","full_name":"mlyle/dronin","owner":{"login":"mlyle","id":90903,"avatar_url":"https://avatars.githubusercontent.com/u/90903?v=3","gravatar_id":"","url":"https://api.github.com/users/mlyle","html_url":"https://github.com/mlyle","followers_url":"https://api.github.com/users/mlyle/followers","following_url":"https://api.github.com/users/mlyle/following{/other_user}","gists_url":"https://api.github.com/users/mlyle/gists{/gist_id}","starred_url":"https://api.github.com/users/mlyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlyle/subscriptions","organizations_url":"https://api.github.com/users/mlyle/orgs","repos_url":"https://api.github.com/users/mlyle/repos","events_url":"https://api.github.com/users/mlyle/events{/privacy}","received_events_url":"https://api.github.com/users/mlyle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mlyle/dronin","description":"The dRonin' flight controller software.","fork":true,"url":"https://api.github.com/repos/mlyle/dronin","forks_url":"https://api.github.com/repos/mlyle/dronin/forks","keys_url":"https://api.github.com/repos/mlyle/dronin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlyle/dronin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlyle/dronin/teams","hooks_url":"https://api.github.com/repos/mlyle/dronin/hooks","issue_events_url":"https://api.github.com/repos/mlyle/dronin/issues/events{/number}","events_url":"https://api.github.com/repos/mlyle/dronin/events","assignees_url":"https://api.github.com/repos/mlyle/dronin/assignees{/user}","branches_url":"https://api.github.com/repos/mlyle/dronin/branches{/branch}","tags_url":"https://api.github.com/repos/mlyle/dronin/tags","blobs_url":"https://api.github.com/repos/mlyle/dronin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlyle/dronin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlyle/dronin/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlyle/dronin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlyle/dronin/statuses/{sha}","languages_url":"https://api.github.com/repos/mlyle/dronin/languages","stargazers_url":"https://api.github.com/repos/mlyle/dronin/stargazers","contributors_url":"https://api.github.com/repos/mlyle/dronin/contributors","subscribers_url":"https://api.github.com/repos/mlyle/dronin/subscribers","subscription_url":"https://api.github.com/repos/mlyle/dronin/subscription","commits_url":"https://api.github.com/repos/mlyle/dronin/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlyle/dronin/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlyle/dronin/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlyle/dronin/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlyle/dronin/contents/{+path}","compare_url":"https://api.github.com/repos/mlyle/dronin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlyle/dronin/merges","archive_url":"https://api.github.com/repos/mlyle/dronin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlyle/dronin/downloads","issues_url":"https://api.github.com/repos/mlyle/dronin/issues{/number}","pulls_url":"https://api.github.com/repos/mlyle/dronin/pulls{/number}","milestones_url":"https://api.github.com/repos/mlyle/dronin/milestones{/number}","notifications_url":"https://api.github.com/repos/mlyle/dronin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlyle/dronin/labels{/name}","releases_url":"https://api.github.com/repos/mlyle/dronin/releases{/id}","created_at":"2015-10-04T03:25:31Z","updated_at":"2015-10-04T03:46:16Z","pushed_at":"2015-12-09T07:54:20Z","git_url":"git://github.com/mlyle/dronin.git","ssh_url":"git@github.com:mlyle/dronin.git","clone_url":"https://github.com/mlyle/dronin.git","svn_url":"https://github.com/mlyle/dronin","homepage":null,"size":214621,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"next"}},"base":{"label":"d-ronin:next","ref":"next","sha":"e325314e52e44f9bb552d346a0b5f72a8472506e","user":{"login":"d-ronin","id":14959302,"avatar_url":"https://avatars.githubusercontent.com/u/14959302?v=3","gravatar_id":"","url":"https://api.github.com/users/d-ronin","html_url":"https://github.com/d-ronin","followers_url":"https://api.github.com/users/d-ronin/followers","following_url":"https://api.github.com/users/d-ronin/following{/other_user}","gists_url":"https://api.github.com/users/d-ronin/gists{/gist_id}","starred_url":"https://api.github.com/users/d-ronin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-ronin/subscriptions","organizations_url":"https://api.github.com/users/d-ronin/orgs","repos_url":"https://api.github.com/users/d-ronin/repos","events_url":"https://api.github.com/users/d-ronin/events{/privacy}","received_events_url":"https://api.github.com/users/d-ronin/received_events","type":"Organization","site_admin":false},"repo":{"id":43620723,"name":"dRonin","full_name":"d-ronin/dRonin","owner":{"login":"d-ronin","id":14959302,"avatar_url":"https://avatars.githubusercontent.com/u/14959302?v=3","gravatar_id":"","url":"https://api.github.com/users/d-ronin","html_url":"https://github.com/d-ronin","followers_url":"https://api.github.com/users/d-ronin/followers","following_url":"https://api.github.com/users/d-ronin/following{/other_user}","gists_url":"https://api.github.com/users/d-ronin/gists{/gist_id}","starred_url":"https://api.github.com/users/d-ronin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-ronin/subscriptions","organizations_url":"https://api.github.com/users/d-ronin/orgs","repos_url":"https://api.github.com/users/d-ronin/repos","events_url":"https://api.github.com/users/d-ronin/events{/privacy}","received_events_url":"https://api.github.com/users/d-ronin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/d-ronin/dRonin","description":"The dRonin' flight controller software.","fork":false,"url":"https://api.github.com/repos/d-ronin/dRonin","forks_url":"https://api.github.com/repos/d-ronin/dRonin/forks","keys_url":"https://api.github.com/repos/d-ronin/dRonin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d-ronin/dRonin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d-ronin/dRonin/teams","hooks_url":"https://api.github.com/repos/d-ronin/dRonin/hooks","issue_events_url":"https://api.github.com/repos/d-ronin/dRonin/issues/events{/number}","events_url":"https://api.github.com/repos/d-ronin/dRonin/events","assignees_url":"https://api.github.com/repos/d-ronin/dRonin/assignees{/user}","branches_url":"https://api.github.com/repos/d-ronin/dRonin/branches{/branch}","tags_url":"https://api.github.com/repos/d-ronin/dRonin/tags","blobs_url":"https://api.github.com/repos/d-ronin/dRonin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d-ronin/dRonin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d-ronin/dRonin/git/refs{/sha}","trees_url":"https://api.github.com/repos/d-ronin/dRonin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d-ronin/dRonin/statuses/{sha}","languages_url":"https://api.github.com/repos/d-ronin/dRonin/languages","stargazers_url":"https://api.github.com/repos/d-ronin/dRonin/stargazers","contributors_url":"https://api.github.com/repos/d-ronin/dRonin/contributors","subscribers_url":"https://api.github.com/repos/d-ronin/dRonin/subscribers","subscription_url":"https://api.github.com/repos/d-ronin/dRonin/subscription","commits_url":"https://api.github.com/repos/d-ronin/dRonin/commits{/sha}","git_commits_url":"https://api.github.com/repos/d-ronin/dRonin/git/commits{/sha}","comments_url":"https://api.github.com/repos/d-ronin/dRonin/comments{/number}","issue_comment_url":"https://api.github.com/repos/d-ronin/dRonin/issues/comments{/number}","contents_url":"https://api.github.com/repos/d-ronin/dRonin/contents/{+path}","compare_url":"https://api.github.com/repos/d-ronin/dRonin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d-ronin/dRonin/merges","archive_url":"https://api.github.com/repos/d-ronin/dRonin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d-ronin/dRonin/downloads","issues_url":"https://api.github.com/repos/d-ronin/dRonin/issues{/number}","pulls_url":"https://api.github.com/repos/d-ronin/dRonin/pulls{/number}","milestones_url":"https://api.github.com/repos/d-ronin/dRonin/milestones{/number}","notifications_url":"https://api.github.com/repos/d-ronin/dRonin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d-ronin/dRonin/labels{/name}","releases_url":"https://api.github.com/repos/d-ronin/dRonin/releases{/id}","created_at":"2015-10-04T01:13:04Z","updated_at":"2015-12-08T20:37:16Z","pushed_at":"2015-12-09T13:43:18Z","git_url":"git://github.com/d-ronin/dRonin.git","ssh_url":"git@github.com:d-ronin/dRonin.git","clone_url":"https://github.com/d-ronin/dRonin.git","svn_url":"https://github.com/d-ronin/dRonin","homepage":null,"size":215471,"stargazers_count":21,"watchers_count":21,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":87,"forks":19,"open_issues":87,"watchers":21,"default_branch":"next"}},"_links":{"self":{"href":"https://api.github.com/repos/d-ronin/dRonin/pulls/151"},"html":{"href":"https://github.com/d-ronin/dRonin/pull/151"},"issue":{"href":"https://api.github.com/repos/d-ronin/dRonin/issues/151"},"comments":{"href":"https://api.github.com/repos/d-ronin/dRonin/issues/151/comments"},"review_comments":{"href":"https://api.github.com/repos/d-ronin/dRonin/pulls/151/comments"},"review_comment":{"href":"https://api.github.com/repos/d-ronin/dRonin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/d-ronin/dRonin/pulls/151/commits"},"statuses":{"href":"https://api.github.com/repos/d-ronin/dRonin/statuses/5af5c17596f7d764374dcc60c94c8755981d21c6"}}}}