{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/22455917","id":22455917,"diff_hunk":"@@ -38,7 +38,12 @@ void ToggleFullscreen(Display *dpy, Window win)\n \t// Send the event\n \tif (!XSendEvent(dpy, DefaultRootWindow(dpy), False,\n \t                SubstructureRedirectMask | SubstructureNotifyMask, &event))\n+\t{\n \t\tERROR_LOG(VIDEO, \"Failed to switch fullscreen/windowed mode.\");","path":"Source/Core/DolphinWX/X11Utils.cpp","position":14,"original_position":14,"commit_id":"399b6248d1042eedc545630b8b2752c148377b88","original_commit_id":"399b6248d1042eedc545630b8b2752c148377b88","user":{"login":"degasus","id":2787141,"avatar_url":"https://avatars.githubusercontent.com/u/2787141?v=3","gravatar_id":"","url":"https://api.github.com/users/degasus","html_url":"https://github.com/degasus","followers_url":"https://api.github.com/users/degasus/followers","following_url":"https://api.github.com/users/degasus/following{/other_user}","gists_url":"https://api.github.com/users/degasus/gists{/gist_id}","starred_url":"https://api.github.com/users/degasus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/degasus/subscriptions","organizations_url":"https://api.github.com/users/degasus/orgs","repos_url":"https://api.github.com/users/degasus/repos","events_url":"https://api.github.com/users/degasus/events{/privacy}","received_events_url":"https://api.github.com/users/degasus/received_events","type":"User","site_admin":false},"body":"I guess this error here is a generic x11 issue. This doesn't say if fullscreen is now enabled or not. To determ if it's enabled, you would have to spend a round-trip to the x server.","created_at":"2015-01-05T11:09:04Z","updated_at":"2015-01-05T11:09:04Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/1764#discussion_r22455917","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1764","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/22455917"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/1764#discussion_r22455917"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1764"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1764","id":26539201,"html_url":"https://github.com/dolphin-emu/dolphin/pull/1764","diff_url":"https://github.com/dolphin-emu/dolphin/pull/1764.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/1764.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1764","number":1764,"state":"open","locked":false,"title":"D3D: Only try to apply exclusive mode when the renderer is in focus.","user":{"login":"Armada651","id":2028870,"avatar_url":"https://avatars.githubusercontent.com/u/2028870?v=3","gravatar_id":"","url":"https://api.github.com/users/Armada651","html_url":"https://github.com/Armada651","followers_url":"https://api.github.com/users/Armada651/followers","following_url":"https://api.github.com/users/Armada651/following{/other_user}","gists_url":"https://api.github.com/users/Armada651/gists{/gist_id}","starred_url":"https://api.github.com/users/Armada651/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Armada651/subscriptions","organizations_url":"https://api.github.com/users/Armada651/orgs","repos_url":"https://api.github.com/users/Armada651/repos","events_url":"https://api.github.com/users/Armada651/events{/privacy}","received_events_url":"https://api.github.com/users/Armada651/received_events","type":"User","site_admin":false},"body":"This should prevent users from ending up in an exclusive mode loop. The previous code would try to immediately re-apply exclusive mode after losing it.\r\n\r\nThis PR is a rewrite of the exclusive fullscreen handling in the Direct3D backend.","created_at":"2014-12-24T00:16:21Z","updated_at":"2015-01-05T11:09:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1005544630762d59754d3bbe263bcaba095f2302","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1764/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1764/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1764/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/399b6248d1042eedc545630b8b2752c148377b88","head":{"label":"Armada651:safe-exclusive","ref":"safe-exclusive","sha":"399b6248d1042eedc545630b8b2752c148377b88","user":{"login":"Armada651","id":2028870,"avatar_url":"https://avatars.githubusercontent.com/u/2028870?v=3","gravatar_id":"","url":"https://api.github.com/users/Armada651","html_url":"https://github.com/Armada651","followers_url":"https://api.github.com/users/Armada651/followers","following_url":"https://api.github.com/users/Armada651/following{/other_user}","gists_url":"https://api.github.com/users/Armada651/gists{/gist_id}","starred_url":"https://api.github.com/users/Armada651/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Armada651/subscriptions","organizations_url":"https://api.github.com/users/Armada651/orgs","repos_url":"https://api.github.com/users/Armada651/repos","events_url":"https://api.github.com/users/Armada651/events{/privacy}","received_events_url":"https://api.github.com/users/Armada651/received_events","type":"User","site_admin":false},"repo":{"id":16296067,"name":"dolphin","full_name":"Armada651/dolphin","owner":{"login":"Armada651","id":2028870,"avatar_url":"https://avatars.githubusercontent.com/u/2028870?v=3","gravatar_id":"","url":"https://api.github.com/users/Armada651","html_url":"https://github.com/Armada651","followers_url":"https://api.github.com/users/Armada651/followers","following_url":"https://api.github.com/users/Armada651/following{/other_user}","gists_url":"https://api.github.com/users/Armada651/gists{/gist_id}","starred_url":"https://api.github.com/users/Armada651/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Armada651/subscriptions","organizations_url":"https://api.github.com/users/Armada651/orgs","repos_url":"https://api.github.com/users/Armada651/repos","events_url":"https://api.github.com/users/Armada651/events{/privacy}","received_events_url":"https://api.github.com/users/Armada651/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Armada651/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":true,"url":"https://api.github.com/repos/Armada651/dolphin","forks_url":"https://api.github.com/repos/Armada651/dolphin/forks","keys_url":"https://api.github.com/repos/Armada651/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Armada651/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Armada651/dolphin/teams","hooks_url":"https://api.github.com/repos/Armada651/dolphin/hooks","issue_events_url":"https://api.github.com/repos/Armada651/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/Armada651/dolphin/events","assignees_url":"https://api.github.com/repos/Armada651/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/Armada651/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/Armada651/dolphin/tags","blobs_url":"https://api.github.com/repos/Armada651/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Armada651/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Armada651/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/Armada651/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Armada651/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/Armada651/dolphin/languages","stargazers_url":"https://api.github.com/repos/Armada651/dolphin/stargazers","contributors_url":"https://api.github.com/repos/Armada651/dolphin/contributors","subscribers_url":"https://api.github.com/repos/Armada651/dolphin/subscribers","subscription_url":"https://api.github.com/repos/Armada651/dolphin/subscription","commits_url":"https://api.github.com/repos/Armada651/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/Armada651/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/Armada651/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/Armada651/dolphin/issues/comments/{number}","contents_url":"https://api.github.com/repos/Armada651/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/Armada651/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Armada651/dolphin/merges","archive_url":"https://api.github.com/repos/Armada651/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Armada651/dolphin/downloads","issues_url":"https://api.github.com/repos/Armada651/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/Armada651/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/Armada651/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/Armada651/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Armada651/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/Armada651/dolphin/releases{/id}","created_at":"2014-01-27T23:04:02Z","updated_at":"2015-01-03T00:37:25Z","pushed_at":"2015-01-04T23:01:32Z","git_url":"git://github.com/Armada651/dolphin.git","ssh_url":"git@github.com:Armada651/dolphin.git","clone_url":"https://github.com/Armada651/dolphin.git","svn_url":"https://github.com/Armada651/dolphin","homepage":null,"size":193491,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"1b4b8367312aed04505a15e44cc66f784bed71da","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/{number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","created_at":"2013-07-22T09:07:57Z","updated_at":"2015-01-05T10:50:35Z","pushed_at":"2015-01-05T10:50:33Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":null,"size":249863,"stargazers_count":904,"watchers_count":904,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":289,"mirror_url":null,"open_issues_count":71,"forks":289,"open_issues":71,"watchers":904,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1764"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/1764"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1764"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1764/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1764/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1764/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/399b6248d1042eedc545630b8b2752c148377b88"}}}}