{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/Socorro-Tests/pulls/comments/41653592","id":41653592,"diff_hunk":"@@ -26,15 +22,15 @@ def test_that_server_status_page_loads(self, mozwebqa):\n         csp = CrashStatsHomePage(mozwebqa)\n         csstat = csp.click_server_status()\n \n-        Assert.true(csstat.is_at_a_glance_present, 'Server summary not found')\n-        Assert.true(csstat.are_graphs_present, '4 graphs not found')\n-        Assert.true(csstat.is_latest_raw_stats_present, 'Raw stats not found')\n+        assert csstat.is_at_a_glance_present, 'Server summary not found'\n+        assert csstat.are_graphs_present, '4 graphs not found'\n+        assert csstat.is_latest_raw_stats_present, 'Raw stats not found'\n \n     @pytest.mark.nondestructive\n     def test_that_simple_querystring_doesnt_return_500(self, mozwebqa):\n         response = urllib.urlopen(mozwebqa.base_url + '/query/simple')\n \n-        Assert.equal(404, response.getcode())\n+        assert 404 assert response.getcode()","path":"tests/test_smoke_tests.py","position":31,"original_position":31,"commit_id":"3b5c7974424f7cb773db7dc1414e64c3e8164d15","original_commit_id":"3b5c7974424f7cb773db7dc1414e64c3e8164d15","user":{"login":"davehunt","id":122800,"avatar_url":"https://avatars.githubusercontent.com/u/122800?v=3","gravatar_id":"","url":"https://api.github.com/users/davehunt","html_url":"https://github.com/davehunt","followers_url":"https://api.github.com/users/davehunt/followers","following_url":"https://api.github.com/users/davehunt/following{/other_user}","gists_url":"https://api.github.com/users/davehunt/gists{/gist_id}","starred_url":"https://api.github.com/users/davehunt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davehunt/subscriptions","organizations_url":"https://api.github.com/users/davehunt/orgs","repos_url":"https://api.github.com/users/davehunt/repos","events_url":"https://api.github.com/users/davehunt/events{/privacy}","received_events_url":"https://api.github.com/users/davehunt/received_events","type":"User","site_admin":false},"body":"Typo?","created_at":"2015-10-09T17:06:44Z","updated_at":"2015-10-09T17:06:44Z","html_url":"https://github.com/mozilla/Socorro-Tests/pull/330#discussion_r41653592","pull_request_url":"https://api.github.com/repos/mozilla/Socorro-Tests/pulls/330","_links":{"self":{"href":"https://api.github.com/repos/mozilla/Socorro-Tests/pulls/comments/41653592"},"html":{"href":"https://github.com/mozilla/Socorro-Tests/pull/330#discussion_r41653592"},"pull_request":{"href":"https://api.github.com/repos/mozilla/Socorro-Tests/pulls/330"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/Socorro-Tests/pulls/330","id":47293819,"html_url":"https://github.com/mozilla/Socorro-Tests/pull/330","diff_url":"https://github.com/mozilla/Socorro-Tests/pull/330.diff","patch_url":"https://github.com/mozilla/Socorro-Tests/pull/330.patch","issue_url":"https://api.github.com/repos/mozilla/Socorro-Tests/issues/330","number":330,"state":"open","locked":false,"title":"remove Unittestzero","user":{"login":"m8ttyB","id":63193,"avatar_url":"https://avatars.githubusercontent.com/u/63193?v=3","gravatar_id":"","url":"https://api.github.com/users/m8ttyB","html_url":"https://github.com/m8ttyB","followers_url":"https://api.github.com/users/m8ttyB/followers","following_url":"https://api.github.com/users/m8ttyB/following{/other_user}","gists_url":"https://api.github.com/users/m8ttyB/gists{/gist_id}","starred_url":"https://api.github.com/users/m8ttyB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m8ttyB/subscriptions","organizations_url":"https://api.github.com/users/m8ttyB/orgs","repos_url":"https://api.github.com/users/m8ttyB/repos","events_url":"https://api.github.com/users/m8ttyB/events{/privacy}","received_events_url":"https://api.github.com/users/m8ttyB/received_events","type":"User","site_admin":false},"body":"There is much additional work to be done to clean up the test suite, I'll file additional issues for these. This pr seeks to resolve issue #327.\r\n* Removes Unittestzero from `requirements.txt`.\r\n* Replaces unittestzero for Python asserts in the tests and `page.py`.\r\n* Slight refactoring on several of the assertion error messages.\r\n\r\nNote: Convention in an assert follows `assert <expected result> Expession <actual result>`. In several instances for readability I took liberty and chose to not follow convention, for example `assert results_count > 0`. If people disagree I'm happy to change it back.","created_at":"2015-10-09T16:43:30Z","updated_at":"2015-10-09T17:06:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a15958999ff324a432d1526a53841028ce45c8ea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/Socorro-Tests/pulls/330/commits","review_comments_url":"https://api.github.com/repos/mozilla/Socorro-Tests/pulls/330/comments","review_comment_url":"https://api.github.com/repos/mozilla/Socorro-Tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/Socorro-Tests/issues/330/comments","statuses_url":"https://api.github.com/repos/mozilla/Socorro-Tests/statuses/3b5c7974424f7cb773db7dc1414e64c3e8164d15","head":{"label":"m8ttyB:native_asserts","ref":"native_asserts","sha":"3b5c7974424f7cb773db7dc1414e64c3e8164d15","user":{"login":"m8ttyB","id":63193,"avatar_url":"https://avatars.githubusercontent.com/u/63193?v=3","gravatar_id":"","url":"https://api.github.com/users/m8ttyB","html_url":"https://github.com/m8ttyB","followers_url":"https://api.github.com/users/m8ttyB/followers","following_url":"https://api.github.com/users/m8ttyB/following{/other_user}","gists_url":"https://api.github.com/users/m8ttyB/gists{/gist_id}","starred_url":"https://api.github.com/users/m8ttyB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m8ttyB/subscriptions","organizations_url":"https://api.github.com/users/m8ttyB/orgs","repos_url":"https://api.github.com/users/m8ttyB/repos","events_url":"https://api.github.com/users/m8ttyB/events{/privacy}","received_events_url":"https://api.github.com/users/m8ttyB/received_events","type":"User","site_admin":false},"repo":{"id":4502278,"name":"Socorro-Tests","full_name":"m8ttyB/Socorro-Tests","owner":{"login":"m8ttyB","id":63193,"avatar_url":"https://avatars.githubusercontent.com/u/63193?v=3","gravatar_id":"","url":"https://api.github.com/users/m8ttyB","html_url":"https://github.com/m8ttyB","followers_url":"https://api.github.com/users/m8ttyB/followers","following_url":"https://api.github.com/users/m8ttyB/following{/other_user}","gists_url":"https://api.github.com/users/m8ttyB/gists{/gist_id}","starred_url":"https://api.github.com/users/m8ttyB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m8ttyB/subscriptions","organizations_url":"https://api.github.com/users/m8ttyB/orgs","repos_url":"https://api.github.com/users/m8ttyB/repos","events_url":"https://api.github.com/users/m8ttyB/events{/privacy}","received_events_url":"https://api.github.com/users/m8ttyB/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/m8ttyB/Socorro-Tests","description":"Selenium Tests for the Socorro ","fork":true,"url":"https://api.github.com/repos/m8ttyB/Socorro-Tests","forks_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/forks","keys_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/teams","hooks_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/hooks","issue_events_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/issues/events{/number}","events_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/events","assignees_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/assignees{/user}","branches_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/branches{/branch}","tags_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/tags","blobs_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/statuses/{sha}","languages_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/languages","stargazers_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/stargazers","contributors_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/contributors","subscribers_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/subscribers","subscription_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/subscription","commits_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/contents/{+path}","compare_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/merges","archive_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/downloads","issues_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/issues{/number}","pulls_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/pulls{/number}","milestones_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/milestones{/number}","notifications_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/labels{/name}","releases_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/releases{/id}","created_at":"2012-05-31T00:43:48Z","updated_at":"2015-04-30T22:16:52Z","pushed_at":"2015-10-09T16:28:08Z","git_url":"git://github.com/m8ttyB/Socorro-Tests.git","ssh_url":"git@github.com:m8ttyB/Socorro-Tests.git","clone_url":"https://github.com/m8ttyB/Socorro-Tests.git","svn_url":"https://github.com/m8ttyB/Socorro-Tests","homepage":"","size":1077,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"f290efd57664c8f5eccf8a467fea47f93e2ea62d","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1711997,"name":"Socorro-Tests","full_name":"mozilla/Socorro-Tests","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/Socorro-Tests","description":"Selenium Tests for the Socorro ","fork":false,"url":"https://api.github.com/repos/mozilla/Socorro-Tests","forks_url":"https://api.github.com/repos/mozilla/Socorro-Tests/forks","keys_url":"https://api.github.com/repos/mozilla/Socorro-Tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/Socorro-Tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/Socorro-Tests/teams","hooks_url":"https://api.github.com/repos/mozilla/Socorro-Tests/hooks","issue_events_url":"https://api.github.com/repos/mozilla/Socorro-Tests/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/Socorro-Tests/events","assignees_url":"https://api.github.com/repos/mozilla/Socorro-Tests/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/Socorro-Tests/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/Socorro-Tests/tags","blobs_url":"https://api.github.com/repos/mozilla/Socorro-Tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/Socorro-Tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/Socorro-Tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/Socorro-Tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/Socorro-Tests/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/Socorro-Tests/languages","stargazers_url":"https://api.github.com/repos/mozilla/Socorro-Tests/stargazers","contributors_url":"https://api.github.com/repos/mozilla/Socorro-Tests/contributors","subscribers_url":"https://api.github.com/repos/mozilla/Socorro-Tests/subscribers","subscription_url":"https://api.github.com/repos/mozilla/Socorro-Tests/subscription","commits_url":"https://api.github.com/repos/mozilla/Socorro-Tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/Socorro-Tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/Socorro-Tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/Socorro-Tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/Socorro-Tests/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/Socorro-Tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/Socorro-Tests/merges","archive_url":"https://api.github.com/repos/mozilla/Socorro-Tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/Socorro-Tests/downloads","issues_url":"https://api.github.com/repos/mozilla/Socorro-Tests/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/Socorro-Tests/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/Socorro-Tests/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/Socorro-Tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/Socorro-Tests/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/Socorro-Tests/releases{/id}","created_at":"2011-05-06T15:56:47Z","updated_at":"2015-09-28T17:32:11Z","pushed_at":"2015-10-09T16:43:31Z","git_url":"git://github.com/mozilla/Socorro-Tests.git","ssh_url":"git@github.com:mozilla/Socorro-Tests.git","clone_url":"https://github.com/mozilla/Socorro-Tests.git","svn_url":"https://github.com/mozilla/Socorro-Tests","homepage":"","size":1274,"stargazers_count":25,"watchers_count":25,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":4,"forks":39,"open_issues":4,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/Socorro-Tests/pulls/330"},"html":{"href":"https://github.com/mozilla/Socorro-Tests/pull/330"},"issue":{"href":"https://api.github.com/repos/mozilla/Socorro-Tests/issues/330"},"comments":{"href":"https://api.github.com/repos/mozilla/Socorro-Tests/issues/330/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/Socorro-Tests/pulls/330/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/Socorro-Tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/Socorro-Tests/pulls/330/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/Socorro-Tests/statuses/3b5c7974424f7cb773db7dc1414e64c3e8164d15"}}}}