{"action":"created","comment":{"url":"https://api.github.com/repos/biocore/scikit-bio/pulls/comments/47014304","id":47014304,"diff_hunk":"@@ -2320,22 +2320,26 @@ def _set_max_distance(self):\n         nodes on large trees efficiently. The code has been modified to track\n         the specific tips the distance is between\n         \"\"\"\n+        maxkey = itemgetter(0)\n+\n         for n in self.postorder():\n             if n.is_tip():\n-                n.MaxDistTips = [[0.0, n], [0.0, n]]\n+                n.MaxDistTips = ((0.0, n), (0.0, n))\n             else:\n                 if len(n.children) == 1:\n                     raise TreeError(\"No support for single descedent nodes\")\n                 else:\n-                    tip_info = [(max(c.MaxDistTips), c) for c in n.children]\n+                    tip_info = []","path":"skbio/tree/_tree.py","position":24,"original_position":24,"commit_id":"a723ade7092ece18abedef0c4c7594e59c571073","original_commit_id":"a723ade7092ece18abedef0c4c7594e59c571073","user":{"login":"jairideout","id":1847232,"avatar_url":"https://avatars.githubusercontent.com/u/1847232?v=3","gravatar_id":"","url":"https://api.github.com/users/jairideout","html_url":"https://github.com/jairideout","followers_url":"https://api.github.com/users/jairideout/followers","following_url":"https://api.github.com/users/jairideout/following{/other_user}","gists_url":"https://api.github.com/users/jairideout/gists{/gist_id}","starred_url":"https://api.github.com/users/jairideout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jairideout/subscriptions","organizations_url":"https://api.github.com/users/jairideout/orgs","repos_url":"https://api.github.com/users/jairideout/repos","events_url":"https://api.github.com/users/jairideout/events{/privacy}","received_events_url":"https://api.github.com/users/jairideout/received_events","type":"User","site_admin":false},"body":"remove this line","created_at":"2015-12-08T21:13:23Z","updated_at":"2015-12-08T21:13:23Z","html_url":"https://github.com/biocore/scikit-bio/pull/1208#discussion_r47014304","pull_request_url":"https://api.github.com/repos/biocore/scikit-bio/pulls/1208","_links":{"self":{"href":"https://api.github.com/repos/biocore/scikit-bio/pulls/comments/47014304"},"html":{"href":"https://github.com/biocore/scikit-bio/pull/1208#discussion_r47014304"},"pull_request":{"href":"https://api.github.com/repos/biocore/scikit-bio/pulls/1208"}}},"pull_request":{"url":"https://api.github.com/repos/biocore/scikit-bio/pulls/1208","id":52171832,"html_url":"https://github.com/biocore/scikit-bio/pull/1208","diff_url":"https://github.com/biocore/scikit-bio/pull/1208.diff","patch_url":"https://github.com/biocore/scikit-bio/pull/1208.patch","issue_url":"https://api.github.com/repos/biocore/scikit-bio/issues/1208","number":1208,"state":"open","locked":false,"title":"fixes #1077","user":{"login":"wasade","id":474290,"avatar_url":"https://avatars.githubusercontent.com/u/474290?v=3","gravatar_id":"","url":"https://api.github.com/users/wasade","html_url":"https://github.com/wasade","followers_url":"https://api.github.com/users/wasade/followers","following_url":"https://api.github.com/users/wasade/following{/other_user}","gists_url":"https://api.github.com/users/wasade/gists{/gist_id}","starred_url":"https://api.github.com/users/wasade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wasade/subscriptions","organizations_url":"https://api.github.com/users/wasade/orgs","repos_url":"https://api.github.com/users/wasade/repos","events_url":"https://api.github.com/users/wasade/events{/privacy}","received_events_url":"https://api.github.com/users/wasade/received_events","type":"User","site_admin":false},"body":"Resolves #1077. The issue was not in `root_at_midpoint` but actually in `_set_max_distance`. This solution fixes the bug albeit at a computational expense as the inner loop logic has been expanded. \r\n\r\nA unit test was added to with the tree described in #1077 that produced the bug.","created_at":"2015-11-30T20:04:54Z","updated_at":"2015-12-08T21:13:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b90b1b9eea87901645dd229f374adde4dc046bd3","assignee":null,"milestone":{"url":"https://api.github.com/repos/biocore/scikit-bio/milestones/14","html_url":"https://github.com/biocore/scikit-bio/milestones/0.4.1","labels_url":"https://api.github.com/repos/biocore/scikit-bio/milestones/14/labels","id":1389454,"number":14,"title":"0.4.1","description":"This release will have Python 2 and Python 3 support. ","creator":{"login":"gregcaporaso","id":192372,"avatar_url":"https://avatars.githubusercontent.com/u/192372?v=3","gravatar_id":"","url":"https://api.github.com/users/gregcaporaso","html_url":"https://github.com/gregcaporaso","followers_url":"https://api.github.com/users/gregcaporaso/followers","following_url":"https://api.github.com/users/gregcaporaso/following{/other_user}","gists_url":"https://api.github.com/users/gregcaporaso/gists{/gist_id}","starred_url":"https://api.github.com/users/gregcaporaso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregcaporaso/subscriptions","organizations_url":"https://api.github.com/users/gregcaporaso/orgs","repos_url":"https://api.github.com/users/gregcaporaso/repos","events_url":"https://api.github.com/users/gregcaporaso/events{/privacy}","received_events_url":"https://api.github.com/users/gregcaporaso/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":16,"state":"open","created_at":"2015-11-02T17:11:28Z","updated_at":"2015-12-08T20:45:40Z","due_on":"2015-12-09T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/biocore/scikit-bio/pulls/1208/commits","review_comments_url":"https://api.github.com/repos/biocore/scikit-bio/pulls/1208/comments","review_comment_url":"https://api.github.com/repos/biocore/scikit-bio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/biocore/scikit-bio/issues/1208/comments","statuses_url":"https://api.github.com/repos/biocore/scikit-bio/statuses/a723ade7092ece18abedef0c4c7594e59c571073","head":{"label":"wasade:issue1077","ref":"issue1077","sha":"a723ade7092ece18abedef0c4c7594e59c571073","user":{"login":"wasade","id":474290,"avatar_url":"https://avatars.githubusercontent.com/u/474290?v=3","gravatar_id":"","url":"https://api.github.com/users/wasade","html_url":"https://github.com/wasade","followers_url":"https://api.github.com/users/wasade/followers","following_url":"https://api.github.com/users/wasade/following{/other_user}","gists_url":"https://api.github.com/users/wasade/gists{/gist_id}","starred_url":"https://api.github.com/users/wasade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wasade/subscriptions","organizations_url":"https://api.github.com/users/wasade/orgs","repos_url":"https://api.github.com/users/wasade/repos","events_url":"https://api.github.com/users/wasade/events{/privacy}","received_events_url":"https://api.github.com/users/wasade/received_events","type":"User","site_admin":false},"repo":{"id":17808144,"name":"scikit-bio","full_name":"wasade/scikit-bio","owner":{"login":"wasade","id":474290,"avatar_url":"https://avatars.githubusercontent.com/u/474290?v=3","gravatar_id":"","url":"https://api.github.com/users/wasade","html_url":"https://github.com/wasade","followers_url":"https://api.github.com/users/wasade/followers","following_url":"https://api.github.com/users/wasade/following{/other_user}","gists_url":"https://api.github.com/users/wasade/gists{/gist_id}","starred_url":"https://api.github.com/users/wasade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wasade/subscriptions","organizations_url":"https://api.github.com/users/wasade/orgs","repos_url":"https://api.github.com/users/wasade/repos","events_url":"https://api.github.com/users/wasade/events{/privacy}","received_events_url":"https://api.github.com/users/wasade/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wasade/scikit-bio","description":"Core objects, functions and statistics for working with biological data in Python.","fork":true,"url":"https://api.github.com/repos/wasade/scikit-bio","forks_url":"https://api.github.com/repos/wasade/scikit-bio/forks","keys_url":"https://api.github.com/repos/wasade/scikit-bio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wasade/scikit-bio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wasade/scikit-bio/teams","hooks_url":"https://api.github.com/repos/wasade/scikit-bio/hooks","issue_events_url":"https://api.github.com/repos/wasade/scikit-bio/issues/events{/number}","events_url":"https://api.github.com/repos/wasade/scikit-bio/events","assignees_url":"https://api.github.com/repos/wasade/scikit-bio/assignees{/user}","branches_url":"https://api.github.com/repos/wasade/scikit-bio/branches{/branch}","tags_url":"https://api.github.com/repos/wasade/scikit-bio/tags","blobs_url":"https://api.github.com/repos/wasade/scikit-bio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wasade/scikit-bio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wasade/scikit-bio/git/refs{/sha}","trees_url":"https://api.github.com/repos/wasade/scikit-bio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wasade/scikit-bio/statuses/{sha}","languages_url":"https://api.github.com/repos/wasade/scikit-bio/languages","stargazers_url":"https://api.github.com/repos/wasade/scikit-bio/stargazers","contributors_url":"https://api.github.com/repos/wasade/scikit-bio/contributors","subscribers_url":"https://api.github.com/repos/wasade/scikit-bio/subscribers","subscription_url":"https://api.github.com/repos/wasade/scikit-bio/subscription","commits_url":"https://api.github.com/repos/wasade/scikit-bio/commits{/sha}","git_commits_url":"https://api.github.com/repos/wasade/scikit-bio/git/commits{/sha}","comments_url":"https://api.github.com/repos/wasade/scikit-bio/comments{/number}","issue_comment_url":"https://api.github.com/repos/wasade/scikit-bio/issues/comments{/number}","contents_url":"https://api.github.com/repos/wasade/scikit-bio/contents/{+path}","compare_url":"https://api.github.com/repos/wasade/scikit-bio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wasade/scikit-bio/merges","archive_url":"https://api.github.com/repos/wasade/scikit-bio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wasade/scikit-bio/downloads","issues_url":"https://api.github.com/repos/wasade/scikit-bio/issues{/number}","pulls_url":"https://api.github.com/repos/wasade/scikit-bio/pulls{/number}","milestones_url":"https://api.github.com/repos/wasade/scikit-bio/milestones{/number}","notifications_url":"https://api.github.com/repos/wasade/scikit-bio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wasade/scikit-bio/labels{/name}","releases_url":"https://api.github.com/repos/wasade/scikit-bio/releases{/id}","created_at":"2014-03-16T20:13:28Z","updated_at":"2014-06-25T14:53:19Z","pushed_at":"2015-12-08T21:07:10Z","git_url":"git://github.com/wasade/scikit-bio.git","ssh_url":"git@github.com:wasade/scikit-bio.git","clone_url":"https://github.com/wasade/scikit-bio.git","svn_url":"https://github.com/wasade/scikit-bio","homepage":"https://github.com/biocore/scikit-bio","size":20722,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"biocore:master","ref":"master","sha":"76be25d7b41e4a04b94e0f9523351179f4c170ba","user":{"login":"biocore","id":6241857,"avatar_url":"https://avatars.githubusercontent.com/u/6241857?v=3","gravatar_id":"","url":"https://api.github.com/users/biocore","html_url":"https://github.com/biocore","followers_url":"https://api.github.com/users/biocore/followers","following_url":"https://api.github.com/users/biocore/following{/other_user}","gists_url":"https://api.github.com/users/biocore/gists{/gist_id}","starred_url":"https://api.github.com/users/biocore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biocore/subscriptions","organizations_url":"https://api.github.com/users/biocore/orgs","repos_url":"https://api.github.com/users/biocore/repos","events_url":"https://api.github.com/users/biocore/events{/privacy}","received_events_url":"https://api.github.com/users/biocore/received_events","type":"Organization","site_admin":false},"repo":{"id":15168264,"name":"scikit-bio","full_name":"biocore/scikit-bio","owner":{"login":"biocore","id":6241857,"avatar_url":"https://avatars.githubusercontent.com/u/6241857?v=3","gravatar_id":"","url":"https://api.github.com/users/biocore","html_url":"https://github.com/biocore","followers_url":"https://api.github.com/users/biocore/followers","following_url":"https://api.github.com/users/biocore/following{/other_user}","gists_url":"https://api.github.com/users/biocore/gists{/gist_id}","starred_url":"https://api.github.com/users/biocore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biocore/subscriptions","organizations_url":"https://api.github.com/users/biocore/orgs","repos_url":"https://api.github.com/users/biocore/repos","events_url":"https://api.github.com/users/biocore/events{/privacy}","received_events_url":"https://api.github.com/users/biocore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/biocore/scikit-bio","description":"scikit-bio is an open-source, BSD-licensed, Python package providing data structures, algorithms, and educational resources for bioinformatics.","fork":false,"url":"https://api.github.com/repos/biocore/scikit-bio","forks_url":"https://api.github.com/repos/biocore/scikit-bio/forks","keys_url":"https://api.github.com/repos/biocore/scikit-bio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biocore/scikit-bio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biocore/scikit-bio/teams","hooks_url":"https://api.github.com/repos/biocore/scikit-bio/hooks","issue_events_url":"https://api.github.com/repos/biocore/scikit-bio/issues/events{/number}","events_url":"https://api.github.com/repos/biocore/scikit-bio/events","assignees_url":"https://api.github.com/repos/biocore/scikit-bio/assignees{/user}","branches_url":"https://api.github.com/repos/biocore/scikit-bio/branches{/branch}","tags_url":"https://api.github.com/repos/biocore/scikit-bio/tags","blobs_url":"https://api.github.com/repos/biocore/scikit-bio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biocore/scikit-bio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biocore/scikit-bio/git/refs{/sha}","trees_url":"https://api.github.com/repos/biocore/scikit-bio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biocore/scikit-bio/statuses/{sha}","languages_url":"https://api.github.com/repos/biocore/scikit-bio/languages","stargazers_url":"https://api.github.com/repos/biocore/scikit-bio/stargazers","contributors_url":"https://api.github.com/repos/biocore/scikit-bio/contributors","subscribers_url":"https://api.github.com/repos/biocore/scikit-bio/subscribers","subscription_url":"https://api.github.com/repos/biocore/scikit-bio/subscription","commits_url":"https://api.github.com/repos/biocore/scikit-bio/commits{/sha}","git_commits_url":"https://api.github.com/repos/biocore/scikit-bio/git/commits{/sha}","comments_url":"https://api.github.com/repos/biocore/scikit-bio/comments{/number}","issue_comment_url":"https://api.github.com/repos/biocore/scikit-bio/issues/comments{/number}","contents_url":"https://api.github.com/repos/biocore/scikit-bio/contents/{+path}","compare_url":"https://api.github.com/repos/biocore/scikit-bio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biocore/scikit-bio/merges","archive_url":"https://api.github.com/repos/biocore/scikit-bio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biocore/scikit-bio/downloads","issues_url":"https://api.github.com/repos/biocore/scikit-bio/issues{/number}","pulls_url":"https://api.github.com/repos/biocore/scikit-bio/pulls{/number}","milestones_url":"https://api.github.com/repos/biocore/scikit-bio/milestones{/number}","notifications_url":"https://api.github.com/repos/biocore/scikit-bio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biocore/scikit-bio/labels{/name}","releases_url":"https://api.github.com/repos/biocore/scikit-bio/releases{/id}","created_at":"2013-12-13T16:24:41Z","updated_at":"2015-12-07T20:41:21Z","pushed_at":"2015-12-08T21:07:10Z","git_url":"git://github.com/biocore/scikit-bio.git","ssh_url":"git@github.com:biocore/scikit-bio.git","clone_url":"https://github.com/biocore/scikit-bio.git","svn_url":"https://github.com/biocore/scikit-bio","homepage":"http://scikit-bio.org","size":38771,"stargazers_count":174,"watchers_count":174,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":91,"mirror_url":null,"open_issues_count":157,"forks":91,"open_issues":157,"watchers":174,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/biocore/scikit-bio/pulls/1208"},"html":{"href":"https://github.com/biocore/scikit-bio/pull/1208"},"issue":{"href":"https://api.github.com/repos/biocore/scikit-bio/issues/1208"},"comments":{"href":"https://api.github.com/repos/biocore/scikit-bio/issues/1208/comments"},"review_comments":{"href":"https://api.github.com/repos/biocore/scikit-bio/pulls/1208/comments"},"review_comment":{"href":"https://api.github.com/repos/biocore/scikit-bio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/biocore/scikit-bio/pulls/1208/commits"},"statuses":{"href":"https://api.github.com/repos/biocore/scikit-bio/statuses/a723ade7092ece18abedef0c4c7594e59c571073"}}}}