{"push_id":764689712,"size":1,"distinct_size":1,"ref":"refs/heads/production","head":"f67401665b157135e067ebc6b0ea538beda603b1","before":"6d9321daf6ae031ffec7bb81b4fa57382480d055","commits":[{"sha":"f67401665b157135e067ebc6b0ea538beda603b1","author":{"email":"0585903ea02668b815a67ba0858fe23637082b7e@wikimedia.org","name":"Brandon Black"},"message":"vcl_cookies: switch mobile to text-common code, mostly\n\nThe important net changes from the mobile behavior POV are:\n\n1. It now restores stashed cookies in vcl_(miss|pass) when no\ncookie matched the special regexes for non-suppression.  Before\nthis was suppressing (to MW) cookies like GeoIP and\nWMF-Last-Access for anonymous hits.\n\n2. It now does cookie-handling in the backend using the same code\nas the frontend, which is the pattern text uses as well.  Before\nthe above, this wasn't necessary because they were all either\ncache-affecting or suppressed and never restored at the frontend.\n\n3. The regex for \"special\" cookies was expanded from matching just\n\"[Ss]ession\" to the standard regex \"[Ss]ession|Token)=\" from the\ntext cluster.\n\n4. The awful global hash_ignore_busy in mobile frontend (which\nkills all coalescing on cacheable objects at the FE layer :/) was\nremoved, as this is done for only the matching special cookies in\nthe common evaluate_cookie stuff.  I think this was a workaround\nfor various related bugs which should now be addressed as of this\ncommit.\n\nThe primary distinctions left (re: cookies and such) between text\nand mobile after this commit are:\n\n1. Mobile marks cookies matching \"optin\" and \"disable\" as special\nfor cache purposes, in addition to the standard session/token\nregex.  I don't know whether that's necessary or valid, but it\npreserves existing behavior until we can look deeper at that\nissue.\n\n2. Mobile doesn't exclude static or load.php from the\nhash_ignore_busy for non-coalesce.  We can probably add this back\nafter confirming these do not Vary on Cookie in the mobile case\nand do not need to.\n\n3. Mobile still has a generic pass on Cookie headers at the bottom\nof recv, which probably isn't necessary anymore, again assuming\nVary is sane.\n\nBug: T109286\nChange-Id: I34deb9e617086a4d10a155ecfa81929444d9f329","distinct":true,"url":"https://api.github.com/repos/wikimedia/operations-puppet/commits/f67401665b157135e067ebc6b0ea538beda603b1"}]}