{"action":"created","issue":{"url":"https://api.github.com/repos/geomoose/geomoose-services/issues/6","labels_url":"https://api.github.com/repos/geomoose/geomoose-services/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/geomoose/geomoose-services/issues/6/comments","events_url":"https://api.github.com/repos/geomoose/geomoose-services/issues/6/events","html_url":"https://github.com/geomoose/geomoose-services/pull/6","id":107025727,"number":6,"title":"Fix broken GetFeatureInfo URLs","user":{"login":"tchaddad","id":1042618,"avatar_url":"https://avatars.githubusercontent.com/u/1042618?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaddad","html_url":"https://github.com/tchaddad","followers_url":"https://api.github.com/users/tchaddad/followers","following_url":"https://api.github.com/users/tchaddad/following{/other_user}","gists_url":"https://api.github.com/users/tchaddad/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaddad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaddad/subscriptions","organizations_url":"https://api.github.com/users/tchaddad/orgs","repos_url":"https://api.github.com/users/tchaddad/repos","events_url":"https://api.github.com/users/tchaddad/events{/privacy}","received_events_url":"https://api.github.com/users/tchaddad/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-17T16:45:59Z","updated_at":"2015-09-17T19:06:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/geomoose/geomoose-services/pulls/6","html_url":"https://github.com/geomoose/geomoose-services/pull/6","diff_url":"https://github.com/geomoose/geomoose-services/pull/6.diff","patch_url":"https://github.com/geomoose/geomoose-services/pull/6.patch"},"body":"The WMS GetFeatureInfo urls assembled in Identify.php have been broken due to lack of encoding/decoding."},"comment":{"url":"https://api.github.com/repos/geomoose/geomoose-services/issues/comments/141191272","html_url":"https://github.com/geomoose/geomoose-services/pull/6#issuecomment-141191272","issue_url":"https://api.github.com/repos/geomoose/geomoose-services/issues/6","id":141191272,"user":{"login":"tchaddad","id":1042618,"avatar_url":"https://avatars.githubusercontent.com/u/1042618?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaddad","html_url":"https://github.com/tchaddad","followers_url":"https://api.github.com/users/tchaddad/followers","following_url":"https://api.github.com/users/tchaddad/following{/other_user}","gists_url":"https://api.github.com/users/tchaddad/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaddad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaddad/subscriptions","organizations_url":"https://api.github.com/users/tchaddad/orgs","repos_url":"https://api.github.com/users/tchaddad/repos","events_url":"https://api.github.com/users/tchaddad/events{/privacy}","received_events_url":"https://api.github.com/users/tchaddad/received_events","type":"User","site_admin":false},"created_at":"2015-09-17T19:06:15Z","updated_at":"2015-09-17T19:06:15Z","body":"I definitely get the word of caution, but I think this case is maybe a fairly simple one.\r\n\r\nWhen you try to push a full root URL that starts with 'http://', into an array that uses ':' in the separation syntax, it will incorrectly break the string at the colon. Later on down the page when you try to use the stored URL root in assembling the full outgoing URL, you will not get the root you expect back out of the array. Instead you just get the 'http' portion that occurs before the colon. So as far as I can tell, no full WMS GetFeatureInfo url could ever have been assembled without fixing this break.\r\n\r\nI think use of this temporary array is all just happening within this one PHP page. I've mainly tested this against the demo and in a local test install of 2.8. It seems to solve the problem for WMS, and does not seem to negatively impact Identify urls on layers of type=mapserver. \r\n\r\nBut it's probably something others should test - I'd be interested if it solves the problems that Geoserver user was reporting with GetFeatureInfo mentioned here:\r\n\r\nhttps://lists.osgeo.org/pipermail/geomoose-users/2014-September/005439.html\r\n\r\nThis fix addresses exactly the symptom described by that user. Unfortunately he fixed his own issue locally, but never filed a GitHub issue or said what he fixed."}}