{"action":"closed","issue":{"url":"https://api.github.com/repos/overviewer/Minecraft-Overviewer/issues/1042","labels_url":"https://api.github.com/repos/overviewer/Minecraft-Overviewer/issues/1042/labels{/name}","comments_url":"https://api.github.com/repos/overviewer/Minecraft-Overviewer/issues/1042/comments","events_url":"https://api.github.com/repos/overviewer/Minecraft-Overviewer/issues/1042/events","html_url":"https://github.com/overviewer/Minecraft-Overviewer/issues/1042","id":24725931,"number":1042,"title":"Manual POIs are not generated unless specified for each renderer in a given RegionSet","user":{"login":"cogsmos","id":6249561,"avatar_url":"https://avatars.githubusercontent.com/u/6249561?v=3","gravatar_id":"","url":"https://api.github.com/users/cogsmos","html_url":"https://github.com/cogsmos","followers_url":"https://api.github.com/users/cogsmos/followers","following_url":"https://api.github.com/users/cogsmos/following{/other_user}","gists_url":"https://api.github.com/users/cogsmos/gists{/gist_id}","starred_url":"https://api.github.com/users/cogsmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cogsmos/subscriptions","organizations_url":"https://api.github.com/users/cogsmos/orgs","repos_url":"https://api.github.com/users/cogsmos/repos","events_url":"https://api.github.com/users/cogsmos/events{/privacy}","received_events_url":"https://api.github.com/users/cogsmos/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2013-12-23T21:55:56Z","updated_at":"2015-05-10T15:51:57Z","closed_at":"2015-05-10T15:51:57Z","body":"Hello,\r\n\r\nIt took me a long time to debug this strange issue. Consider the following ...\r\n\r\n```\r\n...\r\ndef strongholdFilter(poi):\r\n    if poi['id'] == 'SH':\r\n        poi[\"icon\"] = \"http://minecraft.3decibels.net/map/icons/marker_factory.png\"\r\n        return \"Location of \" + poi['name']\r\n...\r\noverworld_markers =  [{\"name\": \"All players\", \"filterFunction\": playerFilter, \"checked\": True}, {\"name\": \"Strongholds\", \"filterFunction\": strongholdFilter}, {\"name\": \"Points of Interest\", \"filterFunction\": signFilter}]\r\n...\r\nmanualpois = [\r\n  {\"id\": \"SH\",\r\n   \"x\": 51*16,\r\n   \"y\": 64,\r\n   \"z\": -45*16,\r\n   \"name\": \"Stronghold A\"},\r\n  {\"id\": \"SH\",\r\n   \"x\": -59*16,\r\n   \"y\": 64,\r\n   \"z\": -17*16,\r\n   \"name\": \"Stronghold B\"},\r\n  {\"id\": \"SH\",\r\n   \"x\": 19*16,\r\n   \"y\": 64,\r\n   \"z\": 76*16,\r\n   \"name\": \"Stronghold C\"}]\r\n...\r\nrenders[\"normalrender\"] = {\r\n    \"world\": \"SMP\",\r\n    \"title\": \"Overworld\",\r\n    \"rendermode\": [Base(), Lighting(), EdgeLines()],\r\n    \"manualpois\": manualpois,\r\n    \"markers\": overworld_markers\r\n}\r\n\r\nrenders[\"slimefinder\"] = {\r\n    \"world\": \"SMP\",\r\n    \"title\": \"Slime Chunks\",\r\n    \"rendermode\": [ClearBase(), SlimeOverlay()],\r\n    \"overlay\": [\"normalrender\"]\r\n}\r\n...\r\n```\r\nThe above does not generate the markers for the manualpois unless the maualpois are also added to the \"slimefinder\" render. This is because they are using the same regionset and the slimefinder's lack of manualpois overwrites/clobbers the manualpois already in the rset.\r\n\r\nWorking around the issue is simple. The manualpois must be set foreach renderer that shares the same RegionSet regardless of whether markers are specified.\r\n\r\nPlease let me know if you need more info.\r\n\r\n~Mike"}}