{"action":"created","issue":{"url":"https://api.github.com/repos/cowboyd/therubyracer/issues/352","labels_url":"https://api.github.com/repos/cowboyd/therubyracer/issues/352/labels{/name}","comments_url":"https://api.github.com/repos/cowboyd/therubyracer/issues/352/comments","events_url":"https://api.github.com/repos/cowboyd/therubyracer/issues/352/events","html_url":"https://github.com/cowboyd/therubyracer/pull/352","id":94523418,"number":352,"title":"Implement numbers","user":{"login":"cowboyd","id":4205,"avatar_url":"https://avatars.githubusercontent.com/u/4205?v=3","gravatar_id":"","url":"https://api.github.com/users/cowboyd","html_url":"https://github.com/cowboyd","followers_url":"https://api.github.com/users/cowboyd/followers","following_url":"https://api.github.com/users/cowboyd/following{/other_user}","gists_url":"https://api.github.com/users/cowboyd/gists{/gist_id}","starred_url":"https://api.github.com/users/cowboyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cowboyd/subscriptions","organizations_url":"https://api.github.com/users/cowboyd/orgs","repos_url":"https://api.github.com/users/cowboyd/repos","events_url":"https://api.github.com/users/cowboyd/events{/privacy}","received_events_url":"https://api.github.com/users/cowboyd/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-12T01:40:57Z","updated_at":"2015-07-12T01:41:10Z","closed_at":"2015-07-12T01:41:04Z","pull_request":{"url":"https://api.github.com/repos/cowboyd/therubyracer/pulls/352","html_url":"https://github.com/cowboyd/therubyracer/pull/352","diff_url":"https://github.com/cowboyd/therubyracer/pull/352.diff","patch_url":"https://github.com/cowboyd/therubyracer/pull/352.patch"},"body":"> This was originally submitted as https://github.com/stormbreakerbg/therubyracer/pull/4\r\n\r\nThis implements the JavaScript types Number, Int32, and Uint32. Previously, I had been cheating and always using low-level ruby types everywhere and then converting them to their v8 equivalents at the last minute in the C code. Now that this properly wraps numeric types, If a method returns an Int32, then ruby will see it as a V8::C::Int32 and not a Fixnum etc..\r\n\r\nNot only does this represent the v8 API as faithfully in Ruby as possible, it also prevents the actual number values from being copied every single time they are passed from V8 to Ruby. Instead, there is just one copy in the V8 heap until it is deallocated.\r\n\r\nAlso, in this PR, I've experimented with using c++11 lambda pointers to implement the Ruby methods. I think that it makes the code a lot more readable, and it eliminates something like %25 of the boiler-plate. If this pans out, then it may be worth converting the whole codebase to this style."},"comment":{"url":"https://api.github.com/repos/cowboyd/therubyracer/issues/comments/120677429","html_url":"https://github.com/cowboyd/therubyracer/pull/352#issuecomment-120677429","issue_url":"https://api.github.com/repos/cowboyd/therubyracer/issues/352","id":120677429,"user":{"login":"cowboyd","id":4205,"avatar_url":"https://avatars.githubusercontent.com/u/4205?v=3","gravatar_id":"","url":"https://api.github.com/users/cowboyd","html_url":"https://github.com/cowboyd","followers_url":"https://api.github.com/users/cowboyd/followers","following_url":"https://api.github.com/users/cowboyd/following{/other_user}","gists_url":"https://api.github.com/users/cowboyd/gists{/gist_id}","starred_url":"https://api.github.com/users/cowboyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cowboyd/subscriptions","organizations_url":"https://api.github.com/users/cowboyd/orgs","repos_url":"https://api.github.com/users/cowboyd/repos","events_url":"https://api.github.com/users/cowboyd/events{/privacy}","received_events_url":"https://api.github.com/users/cowboyd/received_events","type":"User","site_admin":false},"created_at":"2015-07-12T01:41:10Z","updated_at":"2015-07-12T01:41:10Z","body":"wrong branch\r\n"}}