{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/10605","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/10605/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/10605/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/10605/events","html_url":"https://github.com/cms-sw/cmssw/pull/10605","id":99466005,"number":10605,"title":"Dynamic strip reco v3","user":{"login":"andrewj314","id":6199470,"avatar_url":"https://avatars.githubusercontent.com/u/6199470?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewj314","html_url":"https://github.com/andrewj314","followers_url":"https://api.github.com/users/andrewj314/followers","following_url":"https://api.github.com/users/andrewj314/following{/other_user}","gists_url":"https://api.github.com/users/andrewj314/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewj314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewj314/subscriptions","organizations_url":"https://api.github.com/users/andrewj314/orgs","repos_url":"https://api.github.com/users/andrewj314/repos","events_url":"https://api.github.com/users/andrewj314/events{/privacy}","received_events_url":"https://api.github.com/users/andrewj314/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/analysis-pending","name":"analysis-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fef2c0"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-rejected","name":"tests-rejected","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/55","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_7_6_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/55/labels","id":1176788,"number":55,"title":"Next CMSSW_7_6_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":92,"closed_issues":365,"state":"open","created_at":"2015-06-23T07:27:04Z","updated_at":"2015-08-12T22:01:18Z","due_on":null,"closed_at":null},"comments":20,"created_at":"2015-08-06T15:46:47Z","updated_at":"2015-08-12T22:16:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/10605","html_url":"https://github.com/cms-sw/cmssw/pull/10605","diff_url":"https://github.com/cms-sw/cmssw/pull/10605.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/10605.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/130463279","html_url":"https://github.com/cms-sw/cmssw/pull/10605#issuecomment-130463279","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/10605","id":130463279,"user":{"login":"slava77","id":4676718,"avatar_url":"https://avatars.githubusercontent.com/u/4676718?v=3","gravatar_id":"","url":"https://api.github.com/users/slava77","html_url":"https://github.com/slava77","followers_url":"https://api.github.com/users/slava77/followers","following_url":"https://api.github.com/users/slava77/following{/other_user}","gists_url":"https://api.github.com/users/slava77/gists{/gist_id}","starred_url":"https://api.github.com/users/slava77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slava77/subscriptions","organizations_url":"https://api.github.com/users/slava77/orgs","repos_url":"https://api.github.com/users/slava77/repos","events_url":"https://api.github.com/users/slava77/events{/privacy}","received_events_url":"https://api.github.com/users/slava77/received_events","type":"User","site_admin":false},"created_at":"2015-08-12T22:16:49Z","updated_at":"2015-08-12T22:16:49Z","body":"HI AJ,\n\nI think problems with the 135.4 workflow are coming from the update in\nRecoTauTag/Configuration/python/updateHPSPFTaus_cff.py, where\nessentially the full tau reco sequence is loaded through a bunch of\n\"import *\".\nThe crash is in step3_PAT and this import * plays badly in this case\nwith the unscheduled mode configuration.\n\nThe updateHPSPFTaus is supposed to be used only to re-reconstruct\nsomething differently in PAT/miniAOD.\n\nFor the standard matrix workflow which is supposed to make a RECO/AOD\nfile and then read it to make miniAOD this updateHPSPFTaus should not be\nhappening.\nIn fact, the same error will happen in re-miniAOD workflow (only we\ndon't have one in the matrix; but there are some unit tests in the PAT\nthat do effectively that).\nSo, if you go back to updateHPSPFTaus = cms.Sequence(), the matrix\nshould work.\n\nthe non-empty updateHPSPFTaus has to be introduced only for re-miniAOD\nsetup  (corresponding customise functions will be necessary)\n\nWhatever you \"import *\" will run in the unscheduled mode if it happens\nto be needed (consumed with getByLabel/Token)\nby a module that was requested to run (keep statements in the output\nmodule or a path.\nSince we want to have some control over what runs,\neverything that's loaded in the PAT tools has to be loaded explicitly.\nFor the tau part, this means that in\nhttps://github.com/cms-sw/cmssw/pull/10605/files#diff-b0e372e00535cd2e098be96988f85d8bR27\nyou need to import every module from updateHPSPFTaus explicitly\n(not with \"import *\" : use \" from fileName import hpsPFTauPUcorrPtSum\" )\n\n@gpetruc\nThere appears to be already a problem in the miniAOD/PAT configuration\nbuild by the cmsDriver without this PR:\nlooking at the list of executed modules I see ak4PFJets, pfMet, full\nb-tag discriminator sequence, lots of (isolations)PFBRECO and such,\nwhich should not be called.\n\nThe pfMet and ak4PFJets go away with:\nhttps://github.com/cms-sw/cmssw/commit/3f6ee39f62efe2fb4feac44fa1490031d48147a3\nI think all of the process.load should be inspected and cleaned up\naccordingly\n\nThings like PFBRECO modules that get dragged in in the definition of *PAT\nshould be loaded in PAT without sequences, one by one (no import *),\nor all of the *PFBRECO should be \"import aPFBRECO as _aPFBRECO\" to hide\nit from import *\n\n\nOn 8/11/15 1:13 PM, AJ Johnson wrote:\n> @slava77 <https://github.com/slava77> I'm still unable to track down the\n> source of this error in step3 of\n> 135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS:\n> \n> ----- Begin Fatal Exception 11-Aug-2015 19:30:58 CEST-----------------------\n> An exception of category 'ProductNotFound' occurred while\n> [0] Processing run: 1 lumi: 1 event: 1\n> [1] Running path 'MINIAODSIMoutput_step'\n> [2] Calling event method for module PoolOutputModule/'MINIAODSIMoutput'\n> [3] Calling produce method for unscheduled module\n> PATMETSlimmer/'slimmedMETs'\n> [4] Calling produce method for unscheduled module\n> CorrectedPATMETProducer/'patPFMetT1TauEnUp'\n> [5] Calling produce method for unscheduled module\n> ShiftedParticleMETcorrInputProducer/'shiftedPatMETCorrTauEnUp'\n> [6] Calling produce method for unscheduled module\n> PATTauSelector/'selectedPatTaus'\n> [7] Calling produce method for unscheduled module PATTauProducer/'patTaus'\n> [8] Calling produce method for unscheduled module\n> RecoTauPiZeroUnembedder/'hpsPFTauProducer'\n> [9] Calling produce method for unscheduled module\n> RecoTauCleaner/'hpsPFTauProducerSansRefs'\n> [10] Calling produce method for unscheduled module\n> PFRecoTauDiscriminationByHPSSelection/'hpsSelectionDiscriminator'\n> Exception Message:\n> Principal::getByToken: Found zero products matching all criteria\n> Looking for type: std::vectorreco::PFTau\n> Looking for module label: combinatoricRecoTaus\n> Looking for productInstanceName:\n> \n> hpsSelectionDiscriminator in PFRecoTauDiscriminationByIsolation_cfi.py\n> uses combinatoricRecoTaus as an input tag for a PFTauProducer. I tried\n> importing RecoTauCombinatoricProducer_cfi.py and\n> PFRecoTauProducer_cfi.py but this didn't help. Any suggestions?\n> \n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/cms-sw/cmssw/pull/10605#issuecomment-130000421>.\n> \n"}}