{"action":"closed","number":363,"pull_request":{"url":"https://api.github.com/repos/bloomberg/chef-bach/pulls/363","id":54742058,"html_url":"https://github.com/bloomberg/chef-bach/pull/363","diff_url":"https://github.com/bloomberg/chef-bach/pull/363.diff","patch_url":"https://github.com/bloomberg/chef-bach/pull/363.patch","issue_url":"https://api.github.com/repos/bloomberg/chef-bach/issues/363","number":363,"state":"closed","locked":false,"title":"Improve graphite-to-zabbix flow","user":{"login":"kiiranh","id":4454094,"avatar_url":"https://avatars.githubusercontent.com/u/4454094?v=3","gravatar_id":"","url":"https://api.github.com/users/kiiranh","html_url":"https://github.com/kiiranh","followers_url":"https://api.github.com/users/kiiranh/followers","following_url":"https://api.github.com/users/kiiranh/following{/other_user}","gists_url":"https://api.github.com/users/kiiranh/gists{/gist_id}","starred_url":"https://api.github.com/users/kiiranh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiiranh/subscriptions","organizations_url":"https://api.github.com/users/kiiranh/orgs","repos_url":"https://api.github.com/users/kiiranh/repos","events_url":"https://api.github.com/users/kiiranh/events{/privacy}","received_events_url":"https://api.github.com/users/kiiranh/received_events","type":"User","site_admin":false},"body":"This PR provides the following:\r\n\r\n- Changes the default data type for a Zabbix item from numeric float to numeric unsigned. This was done because numeric float cannot hold values greater than [double(16,4)](https://www.zabbix.com/documentation/2.2/manual/config/items/item) and the size(in bytes) for disks could be in Tera Bytes which is incompatible for this data type. Metric values from graphite are of the form `[0-9]+.0` and so we don't loose anything while converting the value to an int (in python) and it should be compatible for the type and range of values we expect to see in the metrics we use.\r\n- Add a trigger dependency between `\"#{host}_#{disk}_SpaceUsed\"` and `\"#{host}_NodeAvailability\"`\r\n- Add logging to `query_graphite.py` so one has visibility into when the script ran, for how long and if there were any errors.","created_at":"2015-12-29T17:11:10Z","updated_at":"2015-12-30T16:21:59Z","closed_at":"2015-12-30T16:21:59Z","merged_at":"2015-12-30T16:21:59Z","merge_commit_sha":"e6fbb09f21fdb968e212c1e3dd8090cf698bfaf5","assignee":{"login":"kiiranh","id":4454094,"avatar_url":"https://avatars.githubusercontent.com/u/4454094?v=3","gravatar_id":"","url":"https://api.github.com/users/kiiranh","html_url":"https://github.com/kiiranh","followers_url":"https://api.github.com/users/kiiranh/followers","following_url":"https://api.github.com/users/kiiranh/following{/other_user}","gists_url":"https://api.github.com/users/kiiranh/gists{/gist_id}","starred_url":"https://api.github.com/users/kiiranh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiiranh/subscriptions","organizations_url":"https://api.github.com/users/kiiranh/orgs","repos_url":"https://api.github.com/users/kiiranh/repos","events_url":"https://api.github.com/users/kiiranh/events{/privacy}","received_events_url":"https://api.github.com/users/kiiranh/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/bloomberg/chef-bach/pulls/363/commits","review_comments_url":"https://api.github.com/repos/bloomberg/chef-bach/pulls/363/comments","review_comment_url":"https://api.github.com/repos/bloomberg/chef-bach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bloomberg/chef-bach/issues/363/comments","statuses_url":"https://api.github.com/repos/bloomberg/chef-bach/statuses/151f7b063192d8e345cce1ff5d21317b2bda5577","head":{"label":"kiiranh:zabbix_item_data_type_overflow","ref":"zabbix_item_data_type_overflow","sha":"151f7b063192d8e345cce1ff5d21317b2bda5577","user":{"login":"kiiranh","id":4454094,"avatar_url":"https://avatars.githubusercontent.com/u/4454094?v=3","gravatar_id":"","url":"https://api.github.com/users/kiiranh","html_url":"https://github.com/kiiranh","followers_url":"https://api.github.com/users/kiiranh/followers","following_url":"https://api.github.com/users/kiiranh/following{/other_user}","gists_url":"https://api.github.com/users/kiiranh/gists{/gist_id}","starred_url":"https://api.github.com/users/kiiranh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiiranh/subscriptions","organizations_url":"https://api.github.com/users/kiiranh/orgs","repos_url":"https://api.github.com/users/kiiranh/repos","events_url":"https://api.github.com/users/kiiranh/events{/privacy}","received_events_url":"https://api.github.com/users/kiiranh/received_events","type":"User","site_admin":false},"repo":{"id":25661154,"name":"chef-bach","full_name":"kiiranh/chef-bach","owner":{"login":"kiiranh","id":4454094,"avatar_url":"https://avatars.githubusercontent.com/u/4454094?v=3","gravatar_id":"","url":"https://api.github.com/users/kiiranh","html_url":"https://github.com/kiiranh","followers_url":"https://api.github.com/users/kiiranh/followers","following_url":"https://api.github.com/users/kiiranh/following{/other_user}","gists_url":"https://api.github.com/users/kiiranh/gists{/gist_id}","starred_url":"https://api.github.com/users/kiiranh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiiranh/subscriptions","organizations_url":"https://api.github.com/users/kiiranh/orgs","repos_url":"https://api.github.com/users/kiiranh/repos","events_url":"https://api.github.com/users/kiiranh/events{/privacy}","received_events_url":"https://api.github.com/users/kiiranh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kiiranh/chef-bach","description":"Chef recipes for Bloomberg's deployment of Hadoop and related components","fork":true,"url":"https://api.github.com/repos/kiiranh/chef-bach","forks_url":"https://api.github.com/repos/kiiranh/chef-bach/forks","keys_url":"https://api.github.com/repos/kiiranh/chef-bach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiiranh/chef-bach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiiranh/chef-bach/teams","hooks_url":"https://api.github.com/repos/kiiranh/chef-bach/hooks","issue_events_url":"https://api.github.com/repos/kiiranh/chef-bach/issues/events{/number}","events_url":"https://api.github.com/repos/kiiranh/chef-bach/events","assignees_url":"https://api.github.com/repos/kiiranh/chef-bach/assignees{/user}","branches_url":"https://api.github.com/repos/kiiranh/chef-bach/branches{/branch}","tags_url":"https://api.github.com/repos/kiiranh/chef-bach/tags","blobs_url":"https://api.github.com/repos/kiiranh/chef-bach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiiranh/chef-bach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiiranh/chef-bach/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiiranh/chef-bach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiiranh/chef-bach/statuses/{sha}","languages_url":"https://api.github.com/repos/kiiranh/chef-bach/languages","stargazers_url":"https://api.github.com/repos/kiiranh/chef-bach/stargazers","contributors_url":"https://api.github.com/repos/kiiranh/chef-bach/contributors","subscribers_url":"https://api.github.com/repos/kiiranh/chef-bach/subscribers","subscription_url":"https://api.github.com/repos/kiiranh/chef-bach/subscription","commits_url":"https://api.github.com/repos/kiiranh/chef-bach/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiiranh/chef-bach/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiiranh/chef-bach/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiiranh/chef-bach/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiiranh/chef-bach/contents/{+path}","compare_url":"https://api.github.com/repos/kiiranh/chef-bach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiiranh/chef-bach/merges","archive_url":"https://api.github.com/repos/kiiranh/chef-bach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiiranh/chef-bach/downloads","issues_url":"https://api.github.com/repos/kiiranh/chef-bach/issues{/number}","pulls_url":"https://api.github.com/repos/kiiranh/chef-bach/pulls{/number}","milestones_url":"https://api.github.com/repos/kiiranh/chef-bach/milestones{/number}","notifications_url":"https://api.github.com/repos/kiiranh/chef-bach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiiranh/chef-bach/labels{/name}","releases_url":"https://api.github.com/repos/kiiranh/chef-bach/releases{/id}","created_at":"2014-10-23T22:44:35Z","updated_at":"2015-04-24T21:33:00Z","pushed_at":"2015-12-29T23:30:13Z","git_url":"git://github.com/kiiranh/chef-bach.git","ssh_url":"git@github.com:kiiranh/chef-bach.git","clone_url":"https://github.com/kiiranh/chef-bach.git","svn_url":"https://github.com/kiiranh/chef-bach","homepage":null,"size":2273,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bloomberg:master","ref":"master","sha":"2c43d4d20c4c5ed58d880683551746d0b599821f","user":{"login":"bloomberg","id":1416818,"avatar_url":"https://avatars.githubusercontent.com/u/1416818?v=3","gravatar_id":"","url":"https://api.github.com/users/bloomberg","html_url":"https://github.com/bloomberg","followers_url":"https://api.github.com/users/bloomberg/followers","following_url":"https://api.github.com/users/bloomberg/following{/other_user}","gists_url":"https://api.github.com/users/bloomberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bloomberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloomberg/subscriptions","organizations_url":"https://api.github.com/users/bloomberg/orgs","repos_url":"https://api.github.com/users/bloomberg/repos","events_url":"https://api.github.com/users/bloomberg/events{/privacy}","received_events_url":"https://api.github.com/users/bloomberg/received_events","type":"Organization","site_admin":false},"repo":{"id":24933148,"name":"chef-bach","full_name":"bloomberg/chef-bach","owner":{"login":"bloomberg","id":1416818,"avatar_url":"https://avatars.githubusercontent.com/u/1416818?v=3","gravatar_id":"","url":"https://api.github.com/users/bloomberg","html_url":"https://github.com/bloomberg","followers_url":"https://api.github.com/users/bloomberg/followers","following_url":"https://api.github.com/users/bloomberg/following{/other_user}","gists_url":"https://api.github.com/users/bloomberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bloomberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloomberg/subscriptions","organizations_url":"https://api.github.com/users/bloomberg/orgs","repos_url":"https://api.github.com/users/bloomberg/repos","events_url":"https://api.github.com/users/bloomberg/events{/privacy}","received_events_url":"https://api.github.com/users/bloomberg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bloomberg/chef-bach","description":"Chef recipes for Bloomberg's deployment of Hadoop and related components","fork":false,"url":"https://api.github.com/repos/bloomberg/chef-bach","forks_url":"https://api.github.com/repos/bloomberg/chef-bach/forks","keys_url":"https://api.github.com/repos/bloomberg/chef-bach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bloomberg/chef-bach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bloomberg/chef-bach/teams","hooks_url":"https://api.github.com/repos/bloomberg/chef-bach/hooks","issue_events_url":"https://api.github.com/repos/bloomberg/chef-bach/issues/events{/number}","events_url":"https://api.github.com/repos/bloomberg/chef-bach/events","assignees_url":"https://api.github.com/repos/bloomberg/chef-bach/assignees{/user}","branches_url":"https://api.github.com/repos/bloomberg/chef-bach/branches{/branch}","tags_url":"https://api.github.com/repos/bloomberg/chef-bach/tags","blobs_url":"https://api.github.com/repos/bloomberg/chef-bach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bloomberg/chef-bach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bloomberg/chef-bach/git/refs{/sha}","trees_url":"https://api.github.com/repos/bloomberg/chef-bach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bloomberg/chef-bach/statuses/{sha}","languages_url":"https://api.github.com/repos/bloomberg/chef-bach/languages","stargazers_url":"https://api.github.com/repos/bloomberg/chef-bach/stargazers","contributors_url":"https://api.github.com/repos/bloomberg/chef-bach/contributors","subscribers_url":"https://api.github.com/repos/bloomberg/chef-bach/subscribers","subscription_url":"https://api.github.com/repos/bloomberg/chef-bach/subscription","commits_url":"https://api.github.com/repos/bloomberg/chef-bach/commits{/sha}","git_commits_url":"https://api.github.com/repos/bloomberg/chef-bach/git/commits{/sha}","comments_url":"https://api.github.com/repos/bloomberg/chef-bach/comments{/number}","issue_comment_url":"https://api.github.com/repos/bloomberg/chef-bach/issues/comments{/number}","contents_url":"https://api.github.com/repos/bloomberg/chef-bach/contents/{+path}","compare_url":"https://api.github.com/repos/bloomberg/chef-bach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bloomberg/chef-bach/merges","archive_url":"https://api.github.com/repos/bloomberg/chef-bach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bloomberg/chef-bach/downloads","issues_url":"https://api.github.com/repos/bloomberg/chef-bach/issues{/number}","pulls_url":"https://api.github.com/repos/bloomberg/chef-bach/pulls{/number}","milestones_url":"https://api.github.com/repos/bloomberg/chef-bach/milestones{/number}","notifications_url":"https://api.github.com/repos/bloomberg/chef-bach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bloomberg/chef-bach/labels{/name}","releases_url":"https://api.github.com/repos/bloomberg/chef-bach/releases{/id}","created_at":"2014-10-08T09:16:26Z","updated_at":"2015-12-23T14:24:39Z","pushed_at":"2015-12-30T16:21:59Z","git_url":"git://github.com/bloomberg/chef-bach.git","ssh_url":"git@github.com:bloomberg/chef-bach.git","clone_url":"https://github.com/bloomberg/chef-bach.git","svn_url":"https://github.com/bloomberg/chef-bach","homepage":null,"size":3011,"stargazers_count":22,"watchers_count":22,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":91,"forks":17,"open_issues":91,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bloomberg/chef-bach/pulls/363"},"html":{"href":"https://github.com/bloomberg/chef-bach/pull/363"},"issue":{"href":"https://api.github.com/repos/bloomberg/chef-bach/issues/363"},"comments":{"href":"https://api.github.com/repos/bloomberg/chef-bach/issues/363/comments"},"review_comments":{"href":"https://api.github.com/repos/bloomberg/chef-bach/pulls/363/comments"},"review_comment":{"href":"https://api.github.com/repos/bloomberg/chef-bach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bloomberg/chef-bach/pulls/363/commits"},"statuses":{"href":"https://api.github.com/repos/bloomberg/chef-bach/statuses/151f7b063192d8e345cce1ff5d21317b2bda5577"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"http-418","id":1435487,"avatar_url":"https://avatars.githubusercontent.com/u/1435487?v=3","gravatar_id":"","url":"https://api.github.com/users/http-418","html_url":"https://github.com/http-418","followers_url":"https://api.github.com/users/http-418/followers","following_url":"https://api.github.com/users/http-418/following{/other_user}","gists_url":"https://api.github.com/users/http-418/gists{/gist_id}","starred_url":"https://api.github.com/users/http-418/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/http-418/subscriptions","organizations_url":"https://api.github.com/users/http-418/orgs","repos_url":"https://api.github.com/users/http-418/repos","events_url":"https://api.github.com/users/http-418/events{/privacy}","received_events_url":"https://api.github.com/users/http-418/received_events","type":"User","site_admin":false},"comments":2,"review_comments":1,"commits":2,"additions":60,"deletions":18,"changed_files":4}}