{"action":"created","comment":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/37689290","id":37689290,"diff_hunk":"@@ -1,32 +1,55 @@\n class NameCollisionError < RuntimeError; end\n \n class Robot\n+  \n   attr_accessor :name\n \n   @@registry\n \n   def initialize(args = {})\n     @@registry ||= []\n-    @name_generator = args[:name_generator]\n+    @name = (args[:name_generator] && args[:name_generator].call) || generate_robot_name\n+    add_robot_to_registry\n+  end\n+\n+  def self.get_registered\n+    @@registry\n+  end\n \n-    if @name_generator\n-      @name = @name_generator.call\n-    else\n-      generate_char = -> { ('A'..'Z').to_a.sample }\n-      generate_num = -> { rand(10) }\n+  private\n \n-      @name = \"#{generate_char.call}#{generate_char.call}#{generate_num.call}#{generate_num.call}#{generate_num.call}\"\n-    end\n+  def add_robot_to_registry\n+    raise NameCollisionError, \"Improper robot name!\" unless proper_name?\n+    @@registry << @name unless robot_registered?\n+  end\n \n-    raise NameCollisionError, 'There was a problem generating the robot name!' if !(name =~ /[[:alpha:]]{2}[[:digit:]]{3}/) || @@registry.include?(name)\n-    @@registry << @name\n+  def proper_name?\n+    @name =~ /[[:alpha:]]{2}[[:digit:]]{3}/\n+  end\n+\n+  def robot_registered?\n+    @@registry.include?(@name)\n+  end\n+\n+  def generate_robot_name\n+    \"#{generate_char(2)}#{generate_num(3)}\"\n+  end\n+\n+  def generate_char(length=1)\n+    length.times.map { ('A'..'Z').to_a.sample }.join(\"\")\n+  end\n+\n+  def generate_num(length=1)\n+    length.times.map { rand(10) }.join(\"\")","path":"robot_name/robot_name.rb","position":53,"original_position":53,"commit_id":"dc1e441cc3f5403734d09d29dd308f04aca56bfe","original_commit_id":"dc1e441cc3f5403734d09d29dd308f04aca56bfe","user":{"login":"paulghaddad","id":1412714,"avatar_url":"https://avatars.githubusercontent.com/u/1412714?v=3","gravatar_id":"","url":"https://api.github.com/users/paulghaddad","html_url":"https://github.com/paulghaddad","followers_url":"https://api.github.com/users/paulghaddad/followers","following_url":"https://api.github.com/users/paulghaddad/following{/other_user}","gists_url":"https://api.github.com/users/paulghaddad/gists{/gist_id}","starred_url":"https://api.github.com/users/paulghaddad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulghaddad/subscriptions","organizations_url":"https://api.github.com/users/paulghaddad/orgs","repos_url":"https://api.github.com/users/paulghaddad/repos","events_url":"https://api.github.com/users/paulghaddad/events{/privacy}","received_events_url":"https://api.github.com/users/paulghaddad/received_events","type":"User","site_admin":false},"body":"See if there is a simpler, more expressive way. Perhaps using `#concat`.","created_at":"2015-08-22T00:28:42Z","updated_at":"2015-08-22T00:28:42Z","html_url":"https://github.com/jmmastey/level_up_exercises/pull/930#discussion_r37689290","pull_request_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/930","_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/37689290"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/930#discussion_r37689290"},"pull_request":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/930"}}},"pull_request":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/930","id":42855464,"html_url":"https://github.com/jmmastey/level_up_exercises/pull/930","diff_url":"https://github.com/jmmastey/level_up_exercises/pull/930.diff","patch_url":"https://github.com/jmmastey/level_up_exercises/pull/930.patch","issue_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/930","number":930,"state":"open","locked":false,"title":"Refactored Robot Code to slim down methods","user":{"login":"Manbearpixel","id":6686750,"avatar_url":"https://avatars.githubusercontent.com/u/6686750?v=3","gravatar_id":"","url":"https://api.github.com/users/Manbearpixel","html_url":"https://github.com/Manbearpixel","followers_url":"https://api.github.com/users/Manbearpixel/followers","following_url":"https://api.github.com/users/Manbearpixel/following{/other_user}","gists_url":"https://api.github.com/users/Manbearpixel/gists{/gist_id}","starred_url":"https://api.github.com/users/Manbearpixel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manbearpixel/subscriptions","organizations_url":"https://api.github.com/users/Manbearpixel/orgs","repos_url":"https://api.github.com/users/Manbearpixel/repos","events_url":"https://api.github.com/users/Manbearpixel/events{/privacy}","received_events_url":"https://api.github.com/users/Manbearpixel/received_events","type":"User","site_admin":false},"body":"Also incorporated name registry checking to ensure multiple names don't exist.","created_at":"2015-08-19T19:42:48Z","updated_at":"2015-08-22T00:28:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1073d18f40fa74e95c93b1acc73ff57e75679ba9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/930/commits","review_comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/930/comments","review_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/930/comments","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/dc1e441cc3f5403734d09d29dd308f04aca56bfe","head":{"label":"Manbearpixel:vbull/robot_name","ref":"vbull/robot_name","sha":"dc1e441cc3f5403734d09d29dd308f04aca56bfe","user":{"login":"Manbearpixel","id":6686750,"avatar_url":"https://avatars.githubusercontent.com/u/6686750?v=3","gravatar_id":"","url":"https://api.github.com/users/Manbearpixel","html_url":"https://github.com/Manbearpixel","followers_url":"https://api.github.com/users/Manbearpixel/followers","following_url":"https://api.github.com/users/Manbearpixel/following{/other_user}","gists_url":"https://api.github.com/users/Manbearpixel/gists{/gist_id}","starred_url":"https://api.github.com/users/Manbearpixel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manbearpixel/subscriptions","organizations_url":"https://api.github.com/users/Manbearpixel/orgs","repos_url":"https://api.github.com/users/Manbearpixel/repos","events_url":"https://api.github.com/users/Manbearpixel/events{/privacy}","received_events_url":"https://api.github.com/users/Manbearpixel/received_events","type":"User","site_admin":false},"repo":{"id":40564070,"name":"level_up_exercises","full_name":"Manbearpixel/level_up_exercises","owner":{"login":"Manbearpixel","id":6686750,"avatar_url":"https://avatars.githubusercontent.com/u/6686750?v=3","gravatar_id":"","url":"https://api.github.com/users/Manbearpixel","html_url":"https://github.com/Manbearpixel","followers_url":"https://api.github.com/users/Manbearpixel/followers","following_url":"https://api.github.com/users/Manbearpixel/following{/other_user}","gists_url":"https://api.github.com/users/Manbearpixel/gists{/gist_id}","starred_url":"https://api.github.com/users/Manbearpixel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manbearpixel/subscriptions","organizations_url":"https://api.github.com/users/Manbearpixel/orgs","repos_url":"https://api.github.com/users/Manbearpixel/repos","events_url":"https://api.github.com/users/Manbearpixel/events{/privacy}","received_events_url":"https://api.github.com/users/Manbearpixel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Manbearpixel/level_up_exercises","description":"A series of code-related assignments to challenge starting engineers","fork":true,"url":"https://api.github.com/repos/Manbearpixel/level_up_exercises","forks_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/forks","keys_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/events","assignees_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/issues/comments{/number}","contents_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/merges","archive_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/Manbearpixel/level_up_exercises/releases{/id}","created_at":"2015-08-11T20:38:33Z","updated_at":"2015-08-11T20:38:34Z","pushed_at":"2015-08-21T16:17:18Z","git_url":"git://github.com/Manbearpixel/level_up_exercises.git","ssh_url":"git@github.com:Manbearpixel/level_up_exercises.git","clone_url":"https://github.com/Manbearpixel/level_up_exercises.git","svn_url":"https://github.com/Manbearpixel/level_up_exercises","homepage":"http://leveluprails.herokuapp.com","size":344,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jmmastey:master","ref":"master","sha":"c90bb546a8e2398360f28a0923f4c295b9979d77","user":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"repo":{"id":20705648,"name":"level_up_exercises","full_name":"jmmastey/level_up_exercises","owner":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmmastey/level_up_exercises","description":"A series of code-related assignments to challenge starting engineers","fork":false,"url":"https://api.github.com/repos/jmmastey/level_up_exercises","forks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/forks","keys_url":"https://api.github.com/repos/jmmastey/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmmastey/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmmastey/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/events","assignees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/jmmastey/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/jmmastey/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/jmmastey/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmmastey/level_up_exercises/merges","archive_url":"https://api.github.com/repos/jmmastey/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmmastey/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/jmmastey/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/jmmastey/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmmastey/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/jmmastey/level_up_exercises/releases{/id}","created_at":"2014-06-10T23:42:24Z","updated_at":"2015-07-09T21:47:15Z","pushed_at":"2015-08-21T16:17:18Z","git_url":"git://github.com/jmmastey/level_up_exercises.git","ssh_url":"git@github.com:jmmastey/level_up_exercises.git","clone_url":"https://github.com/jmmastey/level_up_exercises.git","svn_url":"https://github.com/jmmastey/level_up_exercises","homepage":"http://leveluprails.herokuapp.com","size":180881,"stargazers_count":27,"watchers_count":27,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":132,"mirror_url":null,"open_issues_count":24,"forks":132,"open_issues":24,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/930"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/930"},"issue":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/930"},"comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/930/comments"},"review_comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/930/comments"},"review_comment":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/930/commits"},"statuses":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/dc1e441cc3f5403734d09d29dd308f04aca56bfe"}}}}