{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla-services/cliquet/issues/231","labels_url":"https://api.github.com/repos/mozilla-services/cliquet/issues/231/labels{/name}","comments_url":"https://api.github.com/repos/mozilla-services/cliquet/issues/231/comments","events_url":"https://api.github.com/repos/mozilla-services/cliquet/issues/231/events","html_url":"https://github.com/mozilla-services/cliquet/pull/231","id":68955393,"number":231,"title":"[WIP] Use SQLAlchemy pooling objects","user":{"login":"leplatrem","id":546692,"avatar_url":"https://avatars.githubusercontent.com/u/546692?v=3","gravatar_id":"","url":"https://api.github.com/users/leplatrem","html_url":"https://github.com/leplatrem","followers_url":"https://api.github.com/users/leplatrem/followers","following_url":"https://api.github.com/users/leplatrem/following{/other_user}","gists_url":"https://api.github.com/users/leplatrem/gists{/gist_id}","starred_url":"https://api.github.com/users/leplatrem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leplatrem/subscriptions","organizations_url":"https://api.github.com/users/leplatrem/orgs","repos_url":"https://api.github.com/users/leplatrem/repos","events_url":"https://api.github.com/users/leplatrem/events{/privacy}","received_events_url":"https://api.github.com/users/leplatrem/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mozilla-services/cliquet/labels/to%20review","name":"to review","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-04-16T16:01:10Z","updated_at":"2015-07-03T11:40:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla-services/cliquet/pulls/231","html_url":"https://github.com/mozilla-services/cliquet/pull/231","diff_url":"https://github.com/mozilla-services/cliquet/pull/231.diff","patch_url":"https://github.com/mozilla-services/cliquet/pull/231.patch"},"body":"Fixes #186 and #215 (and #171)\r\n* [x] Add sqlalchemy in deps\r\n* [x] Wire-up slqa in existing code base\r\n* [x] Add more pooling parameters\r\n* [ ] Add a note to make sure \"postgresql\" scheme now has a meaning\r\n* [ ] Check that changing pool class does not fail\r\n* [ ] Fix behaviour when error occurs (change mocks ?)\r\n* [ ] Replace low-level usage of cursor with sqla high-level objects ?\r\n* [x] Import sync code\r\n* [ ] Add some minimalistic pooling tests\r\n* [ ] Share engine instance among storage instances ?\r\n* [ ] Share pool instance between cache/storage ?\r\n* [ ] Mention in docs among \"giants\"\r\n* [ ] Document pooling parameters\r\n* [ ] Restore fsync=off fix"},"comment":{"url":"https://api.github.com/repos/mozilla-services/cliquet/issues/comments/118325225","html_url":"https://github.com/mozilla-services/cliquet/pull/231#issuecomment-118325225","issue_url":"https://api.github.com/repos/mozilla-services/cliquet/issues/231","id":118325225,"user":{"login":"leplatrem","id":546692,"avatar_url":"https://avatars.githubusercontent.com/u/546692?v=3","gravatar_id":"","url":"https://api.github.com/users/leplatrem","html_url":"https://github.com/leplatrem","followers_url":"https://api.github.com/users/leplatrem/followers","following_url":"https://api.github.com/users/leplatrem/following{/other_user}","gists_url":"https://api.github.com/users/leplatrem/gists{/gist_id}","starred_url":"https://api.github.com/users/leplatrem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leplatrem/subscriptions","organizations_url":"https://api.github.com/users/leplatrem/orgs","repos_url":"https://api.github.com/users/leplatrem/repos","events_url":"https://api.github.com/users/leplatrem/events{/privacy}","received_events_url":"https://api.github.com/users/leplatrem/received_events","type":"User","site_admin":false},"created_at":"2015-07-03T11:40:56Z","updated_at":"2015-07-03T11:40:56Z","body":"Yes, the intention is to benefit from the pooling objects of SQLA.\r\nEspecially to cover the issues mentionned in the description.\r\n\r\nThis PR is stalled, but the work should go on in the next weeks when we'll put *Kinto* in production :)\r\n\r\n> SQL Expression Language for queries [...] as the issue description seems to suggest\r\n\r\nNo I only had the ``engine`` objects in mind (necessary to recover database IP change for instance)\r\n\r\nTo be honest, I am not a fan of SQL abstractions when raw SQL is mixed-up (like for pgpsql functions).\r\n"}}