{"action":"created","comment":{"url":"https://api.github.com/repos/Ocramius/StorageLessSession/pulls/comments/43420129","id":43420129,"diff_hunk":"@@ -197,9 +194,34 @@ public function testSkipsInjectingSessionCookieOnEmptyContainer(SessionMiddlewar\n         self::assertNull(FigResponseCookies::get($response, SessionMiddleware::DEFAULT_COOKIE)->getValue());\n     }\n \n-    public function testRemovesSessionCookieOnEmptySessionContainer()\n+    /**\n+     * @dataProvider validMiddlewaresProvider\n+     */\n+    public function testRemovesSessionCookieOnEmptySessionContainer(SessionMiddleware $middleware)\n     {\n-        self::markTestIncomplete('This feature is yet to be implemented, and we may do so in a different middleware');\n+        $validTokenRequest = (new ServerRequest())","path":"test/StoragelessSessionTest/Http/SessionMiddlewareTest.php","position":28,"original_position":28,"commit_id":"38d1852eb16efa5375ea7351d238bc37252af67c","original_commit_id":"38d1852eb16efa5375ea7351d238bc37252af67c","user":{"login":"Ocramius","id":154256,"avatar_url":"https://avatars.githubusercontent.com/u/154256?v=3","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false},"body":" > The \"no cookie is set upfront and no cookie removal is forced\" is what I called \"empty container and no valid token\", isn't it?\r\n\r\n@lcobucci \"non-empty container being emptied\"","created_at":"2015-10-29T17:51:01Z","updated_at":"2015-10-29T17:51:01Z","html_url":"https://github.com/Ocramius/StorageLessSession/pull/9#discussion_r43420129","pull_request_url":"https://api.github.com/repos/Ocramius/StorageLessSession/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/Ocramius/StorageLessSession/pulls/comments/43420129"},"html":{"href":"https://github.com/Ocramius/StorageLessSession/pull/9#discussion_r43420129"},"pull_request":{"href":"https://api.github.com/repos/Ocramius/StorageLessSession/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/Ocramius/StorageLessSession/pulls/9","id":48950264,"html_url":"https://github.com/Ocramius/StorageLessSession/pull/9","diff_url":"https://github.com/Ocramius/StorageLessSession/pull/9.diff","patch_url":"https://github.com/Ocramius/StorageLessSession/pull/9.patch","issue_url":"https://api.github.com/repos/Ocramius/StorageLessSession/issues/9","number":9,"state":"open","locked":false,"title":"Sending an expired cookie when the container is empty (closes #6).","user":{"login":"lcobucci","id":201963,"avatar_url":"https://avatars.githubusercontent.com/u/201963?v=3","gravatar_id":"","url":"https://api.github.com/users/lcobucci","html_url":"https://github.com/lcobucci","followers_url":"https://api.github.com/users/lcobucci/followers","following_url":"https://api.github.com/users/lcobucci/following{/other_user}","gists_url":"https://api.github.com/users/lcobucci/gists{/gist_id}","starred_url":"https://api.github.com/users/lcobucci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcobucci/subscriptions","organizations_url":"https://api.github.com/users/lcobucci/orgs","repos_url":"https://api.github.com/users/lcobucci/repos","events_url":"https://api.github.com/users/lcobucci/events{/privacy}","received_events_url":"https://api.github.com/users/lcobucci/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-28T00:13:58Z","updated_at":"2015-10-29T17:51:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5d097c4086810459a0f0c448a139e8f9d406fd1","assignee":{"login":"Ocramius","id":154256,"avatar_url":"https://avatars.githubusercontent.com/u/154256?v=3","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Ocramius/StorageLessSession/pulls/9/commits","review_comments_url":"https://api.github.com/repos/Ocramius/StorageLessSession/pulls/9/comments","review_comment_url":"https://api.github.com/repos/Ocramius/StorageLessSession/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ocramius/StorageLessSession/issues/9/comments","statuses_url":"https://api.github.com/repos/Ocramius/StorageLessSession/statuses/38d1852eb16efa5375ea7351d238bc37252af67c","head":{"label":"Ocramius:expire-cookie","ref":"expire-cookie","sha":"38d1852eb16efa5375ea7351d238bc37252af67c","user":{"login":"Ocramius","id":154256,"avatar_url":"https://avatars.githubusercontent.com/u/154256?v=3","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false},"repo":{"id":42022232,"name":"StorageLessSession","full_name":"Ocramius/StorageLessSession","owner":{"login":"Ocramius","id":154256,"avatar_url":"https://avatars.githubusercontent.com/u/154256?v=3","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ocramius/StorageLessSession","description":"This project tries to implement storage-less sessions and to mitigate common PHP ext/session issues","fork":false,"url":"https://api.github.com/repos/Ocramius/StorageLessSession","forks_url":"https://api.github.com/repos/Ocramius/StorageLessSession/forks","keys_url":"https://api.github.com/repos/Ocramius/StorageLessSession/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ocramius/StorageLessSession/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ocramius/StorageLessSession/teams","hooks_url":"https://api.github.com/repos/Ocramius/StorageLessSession/hooks","issue_events_url":"https://api.github.com/repos/Ocramius/StorageLessSession/issues/events{/number}","events_url":"https://api.github.com/repos/Ocramius/StorageLessSession/events","assignees_url":"https://api.github.com/repos/Ocramius/StorageLessSession/assignees{/user}","branches_url":"https://api.github.com/repos/Ocramius/StorageLessSession/branches{/branch}","tags_url":"https://api.github.com/repos/Ocramius/StorageLessSession/tags","blobs_url":"https://api.github.com/repos/Ocramius/StorageLessSession/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ocramius/StorageLessSession/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ocramius/StorageLessSession/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ocramius/StorageLessSession/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ocramius/StorageLessSession/statuses/{sha}","languages_url":"https://api.github.com/repos/Ocramius/StorageLessSession/languages","stargazers_url":"https://api.github.com/repos/Ocramius/StorageLessSession/stargazers","contributors_url":"https://api.github.com/repos/Ocramius/StorageLessSession/contributors","subscribers_url":"https://api.github.com/repos/Ocramius/StorageLessSession/subscribers","subscription_url":"https://api.github.com/repos/Ocramius/StorageLessSession/subscription","commits_url":"https://api.github.com/repos/Ocramius/StorageLessSession/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ocramius/StorageLessSession/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ocramius/StorageLessSession/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ocramius/StorageLessSession/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ocramius/StorageLessSession/contents/{+path}","compare_url":"https://api.github.com/repos/Ocramius/StorageLessSession/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ocramius/StorageLessSession/merges","archive_url":"https://api.github.com/repos/Ocramius/StorageLessSession/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ocramius/StorageLessSession/downloads","issues_url":"https://api.github.com/repos/Ocramius/StorageLessSession/issues{/number}","pulls_url":"https://api.github.com/repos/Ocramius/StorageLessSession/pulls{/number}","milestones_url":"https://api.github.com/repos/Ocramius/StorageLessSession/milestones{/number}","notifications_url":"https://api.github.com/repos/Ocramius/StorageLessSession/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ocramius/StorageLessSession/labels{/name}","releases_url":"https://api.github.com/repos/Ocramius/StorageLessSession/releases{/id}","created_at":"2015-09-06T23:26:16Z","updated_at":"2015-10-27T12:33:11Z","pushed_at":"2015-10-28T19:53:54Z","git_url":"git://github.com/Ocramius/StorageLessSession.git","ssh_url":"git@github.com:Ocramius/StorageLessSession.git","clone_url":"https://github.com/Ocramius/StorageLessSession.git","svn_url":"https://github.com/Ocramius/StorageLessSession","homepage":null,"size":255,"stargazers_count":25,"watchers_count":25,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":25,"default_branch":"master"}},"base":{"label":"Ocramius:master","ref":"master","sha":"b691342e646f9bdfa46e8fa4c403edf87fa8e634","user":{"login":"Ocramius","id":154256,"avatar_url":"https://avatars.githubusercontent.com/u/154256?v=3","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false},"repo":{"id":42022232,"name":"StorageLessSession","full_name":"Ocramius/StorageLessSession","owner":{"login":"Ocramius","id":154256,"avatar_url":"https://avatars.githubusercontent.com/u/154256?v=3","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ocramius/StorageLessSession","description":"This project tries to implement storage-less sessions and to mitigate common PHP ext/session issues","fork":false,"url":"https://api.github.com/repos/Ocramius/StorageLessSession","forks_url":"https://api.github.com/repos/Ocramius/StorageLessSession/forks","keys_url":"https://api.github.com/repos/Ocramius/StorageLessSession/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ocramius/StorageLessSession/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ocramius/StorageLessSession/teams","hooks_url":"https://api.github.com/repos/Ocramius/StorageLessSession/hooks","issue_events_url":"https://api.github.com/repos/Ocramius/StorageLessSession/issues/events{/number}","events_url":"https://api.github.com/repos/Ocramius/StorageLessSession/events","assignees_url":"https://api.github.com/repos/Ocramius/StorageLessSession/assignees{/user}","branches_url":"https://api.github.com/repos/Ocramius/StorageLessSession/branches{/branch}","tags_url":"https://api.github.com/repos/Ocramius/StorageLessSession/tags","blobs_url":"https://api.github.com/repos/Ocramius/StorageLessSession/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ocramius/StorageLessSession/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ocramius/StorageLessSession/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ocramius/StorageLessSession/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ocramius/StorageLessSession/statuses/{sha}","languages_url":"https://api.github.com/repos/Ocramius/StorageLessSession/languages","stargazers_url":"https://api.github.com/repos/Ocramius/StorageLessSession/stargazers","contributors_url":"https://api.github.com/repos/Ocramius/StorageLessSession/contributors","subscribers_url":"https://api.github.com/repos/Ocramius/StorageLessSession/subscribers","subscription_url":"https://api.github.com/repos/Ocramius/StorageLessSession/subscription","commits_url":"https://api.github.com/repos/Ocramius/StorageLessSession/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ocramius/StorageLessSession/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ocramius/StorageLessSession/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ocramius/StorageLessSession/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ocramius/StorageLessSession/contents/{+path}","compare_url":"https://api.github.com/repos/Ocramius/StorageLessSession/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ocramius/StorageLessSession/merges","archive_url":"https://api.github.com/repos/Ocramius/StorageLessSession/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ocramius/StorageLessSession/downloads","issues_url":"https://api.github.com/repos/Ocramius/StorageLessSession/issues{/number}","pulls_url":"https://api.github.com/repos/Ocramius/StorageLessSession/pulls{/number}","milestones_url":"https://api.github.com/repos/Ocramius/StorageLessSession/milestones{/number}","notifications_url":"https://api.github.com/repos/Ocramius/StorageLessSession/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ocramius/StorageLessSession/labels{/name}","releases_url":"https://api.github.com/repos/Ocramius/StorageLessSession/releases{/id}","created_at":"2015-09-06T23:26:16Z","updated_at":"2015-10-27T12:33:11Z","pushed_at":"2015-10-28T19:53:54Z","git_url":"git://github.com/Ocramius/StorageLessSession.git","ssh_url":"git@github.com:Ocramius/StorageLessSession.git","clone_url":"https://github.com/Ocramius/StorageLessSession.git","svn_url":"https://github.com/Ocramius/StorageLessSession","homepage":null,"size":255,"stargazers_count":25,"watchers_count":25,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ocramius/StorageLessSession/pulls/9"},"html":{"href":"https://github.com/Ocramius/StorageLessSession/pull/9"},"issue":{"href":"https://api.github.com/repos/Ocramius/StorageLessSession/issues/9"},"comments":{"href":"https://api.github.com/repos/Ocramius/StorageLessSession/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/Ocramius/StorageLessSession/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/Ocramius/StorageLessSession/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ocramius/StorageLessSession/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/Ocramius/StorageLessSession/statuses/38d1852eb16efa5375ea7351d238bc37252af67c"}}}}