{"action":"created","comment":{"url":"https://api.github.com/repos/invenia/DateTimeParser.jl/pulls/comments/41913787","id":41913787,"diff_hunk":"@@ -154,23 +150,24 @@ function _parsedate(datetimestring::AbstractString; fuzzy::Bool=false,\n             if length(ymd) == 3 && tokenlength in (2,4) &&\n                 (i>=len || (tokens[i] != \":\" && !haskey(HMS, lowercase(tokens[i]))))\n                 # 19990101T23[59]\n-                res[\"hour\"] = parse(Int, token[1:2])\n+                res[\"hour\"] = Hour(token[1:2])\n                 if tokenlength == 4\n-                    res[\"minute\"] = parse(Int, token[3:4])\n+                    res[\"minute\"] = Minute(token[3:4])\n                 end\n             elseif tokenlength == 6\n                 # YYMMDD or HHMMSS[.ss]\n                 if length(ymd) != 0 || (i+1 <= len && tokens[i] == \".\" && isdigit(tokens[i+1]))\n                     # 19990101T235959[.59]\n-                    res[\"hour\"] = parse(Int, token[1:2])\n-                    res[\"minute\"] = parse(Int, token[3:4])\n-                    res[\"second\"] = parse(Int, token[5:6])\n+                    res[\"hour\"] = Hour(token[1:2])\n+                    res[\"minute\"] = Minute(token[3:4])\n+                    res[\"second\"] = Second(token[5:6])\n                     if i+1 <= len && tokens[i] == \".\" && isdigit(tokens[i+1])\n-                        res[\"millisecond\"] = round(Int, 1000 * parse(Float64, string(tokens[i], tokens[i+1])))\n+                        temp = round(Int, 1000 * parse(Float64, string(tokens[i], tokens[i+1])))\n+                        res[\"millisecond\"] = Millisecond(temp)\n                         i += 2\n                     end\n                 else\n-                    push!(ymd, convertyear(parse(Int, token[1:2])))\n+                    push!(ymd, convertyear(Year(token[1:2])).value)","path":"src/DateTimeParser.jl","position":208,"original_position":208,"commit_id":"61f450655209abbcf1aac59ceb7c2e60b91ad63f","original_commit_id":"61f450655209abbcf1aac59ceb7c2e60b91ad63f","user":{"login":"Michael-Klassen","id":7886517,"avatar_url":"https://avatars.githubusercontent.com/u/7886517?v=3","gravatar_id":"","url":"https://api.github.com/users/Michael-Klassen","html_url":"https://github.com/Michael-Klassen","followers_url":"https://api.github.com/users/Michael-Klassen/followers","following_url":"https://api.github.com/users/Michael-Klassen/following{/other_user}","gists_url":"https://api.github.com/users/Michael-Klassen/gists{/gist_id}","starred_url":"https://api.github.com/users/Michael-Klassen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Michael-Klassen/subscriptions","organizations_url":"https://api.github.com/users/Michael-Klassen/orgs","repos_url":"https://api.github.com/users/Michael-Klassen/repos","events_url":"https://api.github.com/users/Michael-Klassen/events{/privacy}","received_events_url":"https://api.github.com/users/Michael-Klassen/received_events","type":"User","site_admin":false},"body":"I can change it to not assume the first 2 digits is a year.","created_at":"2015-10-13T19:38:53Z","updated_at":"2015-10-13T19:38:53Z","html_url":"https://github.com/invenia/DateTimeParser.jl/pull/2#discussion_r41913787","pull_request_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/invenia/DateTimeParser.jl/pulls/comments/41913787"},"html":{"href":"https://github.com/invenia/DateTimeParser.jl/pull/2#discussion_r41913787"},"pull_request":{"href":"https://api.github.com/repos/invenia/DateTimeParser.jl/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/invenia/DateTimeParser.jl/pulls/2","id":47301578,"html_url":"https://github.com/invenia/DateTimeParser.jl/pull/2","diff_url":"https://github.com/invenia/DateTimeParser.jl/pull/2.diff","patch_url":"https://github.com/invenia/DateTimeParser.jl/pull/2.patch","issue_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/issues/2","number":2,"state":"open","locked":false,"title":"Refactor","user":{"login":"Michael-Klassen","id":7886517,"avatar_url":"https://avatars.githubusercontent.com/u/7886517?v=3","gravatar_id":"","url":"https://api.github.com/users/Michael-Klassen","html_url":"https://github.com/Michael-Klassen","followers_url":"https://api.github.com/users/Michael-Klassen/followers","following_url":"https://api.github.com/users/Michael-Klassen/following{/other_user}","gists_url":"https://api.github.com/users/Michael-Klassen/gists{/gist_id}","starred_url":"https://api.github.com/users/Michael-Klassen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Michael-Klassen/subscriptions","organizations_url":"https://api.github.com/users/Michael-Klassen/orgs","repos_url":"https://api.github.com/users/Michael-Klassen/repos","events_url":"https://api.github.com/users/Michael-Klassen/events{/privacy}","received_events_url":"https://api.github.com/users/Michael-Klassen/received_events","type":"User","site_admin":false},"body":"Refactor DateTimeParser","created_at":"2015-10-09T18:01:55Z","updated_at":"2015-10-13T19:38:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67d3b5618b21f9756b171f808c53052396d190a1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/pulls/2/commits","review_comments_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/pulls/2/comments","review_comment_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/issues/2/comments","statuses_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/statuses/61f450655209abbcf1aac59ceb7c2e60b91ad63f","head":{"label":"invenia:refactor","ref":"refactor","sha":"61f450655209abbcf1aac59ceb7c2e60b91ad63f","user":{"login":"invenia","id":5262440,"avatar_url":"https://avatars.githubusercontent.com/u/5262440?v=3","gravatar_id":"","url":"https://api.github.com/users/invenia","html_url":"https://github.com/invenia","followers_url":"https://api.github.com/users/invenia/followers","following_url":"https://api.github.com/users/invenia/following{/other_user}","gists_url":"https://api.github.com/users/invenia/gists{/gist_id}","starred_url":"https://api.github.com/users/invenia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/invenia/subscriptions","organizations_url":"https://api.github.com/users/invenia/orgs","repos_url":"https://api.github.com/users/invenia/repos","events_url":"https://api.github.com/users/invenia/events{/privacy}","received_events_url":"https://api.github.com/users/invenia/received_events","type":"Organization","site_admin":false},"repo":{"id":43379390,"name":"DateTimeParser.jl","full_name":"invenia/DateTimeParser.jl","owner":{"login":"invenia","id":5262440,"avatar_url":"https://avatars.githubusercontent.com/u/5262440?v=3","gravatar_id":"","url":"https://api.github.com/users/invenia","html_url":"https://github.com/invenia","followers_url":"https://api.github.com/users/invenia/followers","following_url":"https://api.github.com/users/invenia/following{/other_user}","gists_url":"https://api.github.com/users/invenia/gists{/gist_id}","starred_url":"https://api.github.com/users/invenia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/invenia/subscriptions","organizations_url":"https://api.github.com/users/invenia/orgs","repos_url":"https://api.github.com/users/invenia/repos","events_url":"https://api.github.com/users/invenia/events{/privacy}","received_events_url":"https://api.github.com/users/invenia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/invenia/DateTimeParser.jl","description":"Handle automatic parsing of DateTime strings","fork":false,"url":"https://api.github.com/repos/invenia/DateTimeParser.jl","forks_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/forks","keys_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/teams","hooks_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/hooks","issue_events_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/issues/events{/number}","events_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/events","assignees_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/assignees{/user}","branches_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/branches{/branch}","tags_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/tags","blobs_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/languages","stargazers_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/stargazers","contributors_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/contributors","subscribers_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/subscribers","subscription_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/subscription","commits_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/contents/{+path}","compare_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/merges","archive_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/downloads","issues_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/issues{/number}","pulls_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/labels{/name}","releases_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/releases{/id}","created_at":"2015-09-29T16:22:53Z","updated_at":"2015-09-29T16:25:20Z","pushed_at":"2015-10-13T18:32:37Z","git_url":"git://github.com/invenia/DateTimeParser.jl.git","ssh_url":"git@github.com:invenia/DateTimeParser.jl.git","clone_url":"https://github.com/invenia/DateTimeParser.jl.git","svn_url":"https://github.com/invenia/DateTimeParser.jl","homepage":null,"size":220,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"invenia:master","ref":"master","sha":"f33e88a46a025c1e44fd6fdf0d99a7215f24b9fa","user":{"login":"invenia","id":5262440,"avatar_url":"https://avatars.githubusercontent.com/u/5262440?v=3","gravatar_id":"","url":"https://api.github.com/users/invenia","html_url":"https://github.com/invenia","followers_url":"https://api.github.com/users/invenia/followers","following_url":"https://api.github.com/users/invenia/following{/other_user}","gists_url":"https://api.github.com/users/invenia/gists{/gist_id}","starred_url":"https://api.github.com/users/invenia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/invenia/subscriptions","organizations_url":"https://api.github.com/users/invenia/orgs","repos_url":"https://api.github.com/users/invenia/repos","events_url":"https://api.github.com/users/invenia/events{/privacy}","received_events_url":"https://api.github.com/users/invenia/received_events","type":"Organization","site_admin":false},"repo":{"id":43379390,"name":"DateTimeParser.jl","full_name":"invenia/DateTimeParser.jl","owner":{"login":"invenia","id":5262440,"avatar_url":"https://avatars.githubusercontent.com/u/5262440?v=3","gravatar_id":"","url":"https://api.github.com/users/invenia","html_url":"https://github.com/invenia","followers_url":"https://api.github.com/users/invenia/followers","following_url":"https://api.github.com/users/invenia/following{/other_user}","gists_url":"https://api.github.com/users/invenia/gists{/gist_id}","starred_url":"https://api.github.com/users/invenia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/invenia/subscriptions","organizations_url":"https://api.github.com/users/invenia/orgs","repos_url":"https://api.github.com/users/invenia/repos","events_url":"https://api.github.com/users/invenia/events{/privacy}","received_events_url":"https://api.github.com/users/invenia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/invenia/DateTimeParser.jl","description":"Handle automatic parsing of DateTime strings","fork":false,"url":"https://api.github.com/repos/invenia/DateTimeParser.jl","forks_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/forks","keys_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/teams","hooks_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/hooks","issue_events_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/issues/events{/number}","events_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/events","assignees_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/assignees{/user}","branches_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/branches{/branch}","tags_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/tags","blobs_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/languages","stargazers_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/stargazers","contributors_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/contributors","subscribers_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/subscribers","subscription_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/subscription","commits_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/contents/{+path}","compare_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/merges","archive_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/downloads","issues_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/issues{/number}","pulls_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/labels{/name}","releases_url":"https://api.github.com/repos/invenia/DateTimeParser.jl/releases{/id}","created_at":"2015-09-29T16:22:53Z","updated_at":"2015-09-29T16:25:20Z","pushed_at":"2015-10-13T18:32:37Z","git_url":"git://github.com/invenia/DateTimeParser.jl.git","ssh_url":"git@github.com:invenia/DateTimeParser.jl.git","clone_url":"https://github.com/invenia/DateTimeParser.jl.git","svn_url":"https://github.com/invenia/DateTimeParser.jl","homepage":null,"size":220,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/invenia/DateTimeParser.jl/pulls/2"},"html":{"href":"https://github.com/invenia/DateTimeParser.jl/pull/2"},"issue":{"href":"https://api.github.com/repos/invenia/DateTimeParser.jl/issues/2"},"comments":{"href":"https://api.github.com/repos/invenia/DateTimeParser.jl/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/invenia/DateTimeParser.jl/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/invenia/DateTimeParser.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/invenia/DateTimeParser.jl/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/invenia/DateTimeParser.jl/statuses/61f450655209abbcf1aac59ceb7c2e60b91ad63f"}}}}