{"action":"created","issue":{"url":"https://api.github.com/repos/nurkiewicz/spring-data-jdbc-repository/issues/19","labels_url":"https://api.github.com/repos/nurkiewicz/spring-data-jdbc-repository/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/nurkiewicz/spring-data-jdbc-repository/issues/19/comments","events_url":"https://api.github.com/repos/nurkiewicz/spring-data-jdbc-repository/issues/19/events","html_url":"https://github.com/nurkiewicz/spring-data-jdbc-repository/issues/19","id":53526260,"number":19,"title":"Use SQL standard OFFSET .. FETCH instead of ROW_NUMBER() pagination for Derby","user":{"login":"lukaseder","id":734593,"avatar_url":"https://avatars.githubusercontent.com/u/734593?v=3","gravatar_id":"","url":"https://api.github.com/users/lukaseder","html_url":"https://github.com/lukaseder","followers_url":"https://api.github.com/users/lukaseder/followers","following_url":"https://api.github.com/users/lukaseder/following{/other_user}","gists_url":"https://api.github.com/users/lukaseder/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaseder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaseder/subscriptions","organizations_url":"https://api.github.com/users/lukaseder/orgs","repos_url":"https://api.github.com/users/lukaseder/repos","events_url":"https://api.github.com/users/lukaseder/events{/privacy}","received_events_url":"https://api.github.com/users/lukaseder/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"nurkiewicz","id":164045,"avatar_url":"https://avatars.githubusercontent.com/u/164045?v=3","gravatar_id":"","url":"https://api.github.com/users/nurkiewicz","html_url":"https://github.com/nurkiewicz","followers_url":"https://api.github.com/users/nurkiewicz/followers","following_url":"https://api.github.com/users/nurkiewicz/following{/other_user}","gists_url":"https://api.github.com/users/nurkiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/nurkiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nurkiewicz/subscriptions","organizations_url":"https://api.github.com/users/nurkiewicz/orgs","repos_url":"https://api.github.com/users/nurkiewicz/repos","events_url":"https://api.github.com/users/nurkiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/nurkiewicz/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/nurkiewicz/spring-data-jdbc-repository/milestones/1","labels_url":"https://api.github.com/repos/nurkiewicz/spring-data-jdbc-repository/milestones/1/labels","id":907424,"number":1,"title":"0.4.2","description":null,"creator":{"login":"nurkiewicz","id":164045,"avatar_url":"https://avatars.githubusercontent.com/u/164045?v=3","gravatar_id":"","url":"https://api.github.com/users/nurkiewicz","html_url":"https://github.com/nurkiewicz","followers_url":"https://api.github.com/users/nurkiewicz/followers","following_url":"https://api.github.com/users/nurkiewicz/following{/other_user}","gists_url":"https://api.github.com/users/nurkiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/nurkiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nurkiewicz/subscriptions","organizations_url":"https://api.github.com/users/nurkiewicz/orgs","repos_url":"https://api.github.com/users/nurkiewicz/repos","events_url":"https://api.github.com/users/nurkiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/nurkiewicz/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":2,"state":"open","created_at":"2014-12-17T20:03:59Z","updated_at":"2015-01-06T17:54:33Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2015-01-06T15:33:32Z","updated_at":"2015-01-06T18:00:15Z","closed_at":"2015-01-06T17:54:33Z","body":"I've had a brief review of your solution and found that you're using `ROW_NUMBER() OVER()` window functions for pagination in Derby:\r\nhttps://github.com/nurkiewicz/spring-data-jdbc-repository/blob/master/src/main/java/com/nurkiewicz/jdbcrepository/sql/DerbySqlGenerator.java#L13\r\n\r\nBut Derby supports the SQL standard `OFFSET .. FETCH` clause:\r\nhttp://db.apache.org/derby/docs/10.6/ref/rrefsqljoffsetfetch.html\r\n\r\nWhy aren't you using that instead?"},"comment":{"url":"https://api.github.com/repos/nurkiewicz/spring-data-jdbc-repository/issues/comments/68904183","html_url":"https://github.com/nurkiewicz/spring-data-jdbc-repository/issues/19#issuecomment-68904183","issue_url":"https://api.github.com/repos/nurkiewicz/spring-data-jdbc-repository/issues/19","id":68904183,"user":{"login":"nurkiewicz","id":164045,"avatar_url":"https://avatars.githubusercontent.com/u/164045?v=3","gravatar_id":"","url":"https://api.github.com/users/nurkiewicz","html_url":"https://github.com/nurkiewicz","followers_url":"https://api.github.com/users/nurkiewicz/followers","following_url":"https://api.github.com/users/nurkiewicz/following{/other_user}","gists_url":"https://api.github.com/users/nurkiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/nurkiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nurkiewicz/subscriptions","organizations_url":"https://api.github.com/users/nurkiewicz/orgs","repos_url":"https://api.github.com/users/nurkiewicz/repos","events_url":"https://api.github.com/users/nurkiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/nurkiewicz/received_events","type":"User","site_admin":false},"created_at":"2015-01-06T18:00:15Z","updated_at":"2015-01-06T18:00:15Z","body":"Thank you very much, indeed you are right. I guess I was misguided by [official FAQ (point 5.2)](http://db.apache.org/derby/faq.html) suggesting `OFFSET ... FETCH` was introduced in 10.7 - but apprently it's already available in [10.5](http://db.apache.org/derby/docs/10.5/ref/rrefsqljoffsetfetch.html). Once again thanks for reporting this."}}