{"action":"closed","number":1946,"pull_request":{"url":"https://api.github.com/repos/bbatsov/rubocop/pulls/1946","id":36964226,"html_url":"https://github.com/bbatsov/rubocop/pull/1946","diff_url":"https://github.com/bbatsov/rubocop/pull/1946.diff","patch_url":"https://github.com/bbatsov/rubocop/pull/1946.patch","issue_url":"https://api.github.com/repos/bbatsov/rubocop/issues/1946","number":1946,"state":"closed","locked":false,"title":"Fix bad test in StructInheritance","user":{"login":"lumeet","id":7588782,"avatar_url":"https://avatars.githubusercontent.com/u/7588782?v=3","gravatar_id":"","url":"https://api.github.com/users/lumeet","html_url":"https://github.com/lumeet","followers_url":"https://api.github.com/users/lumeet/followers","following_url":"https://api.github.com/users/lumeet/following{/other_user}","gists_url":"https://api.github.com/users/lumeet/gists{/gist_id}","starred_url":"https://api.github.com/users/lumeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumeet/subscriptions","organizations_url":"https://api.github.com/users/lumeet/orgs","repos_url":"https://api.github.com/users/lumeet/repos","events_url":"https://api.github.com/users/lumeet/events{/privacy}","received_events_url":"https://api.github.com/users/lumeet/received_events","type":"User","site_admin":false},"body":"The following cases are now handled similarly.\r\n\r\n```ruby\r\nclass Person < Struct.new(:first_name, :last_name) do end\r\nend\r\n\r\nclass Person < Struct.new(:first_name, :last_name)\r\nend\r\n```\r\n\r\nI think this is what the cop is supposed to do. In other words, the spec description was right but the test itself was incorrect.","created_at":"2015-06-04T18:34:52Z","updated_at":"2015-06-04T22:31:23Z","closed_at":"2015-06-04T22:31:23Z","merged_at":"2015-06-04T22:31:23Z","merge_commit_sha":"c9e454ca509cb1a5fc73a564bb4883c6e0e5883f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/1946/commits","review_comments_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/1946/comments","review_comment_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bbatsov/rubocop/issues/1946/comments","statuses_url":"https://api.github.com/repos/bbatsov/rubocop/statuses/07aff8514f108bd45c5b1542107ed534cb087250","head":{"label":"lumeet:fix_struct_inheritance","ref":"fix_struct_inheritance","sha":"07aff8514f108bd45c5b1542107ed534cb087250","user":{"login":"lumeet","id":7588782,"avatar_url":"https://avatars.githubusercontent.com/u/7588782?v=3","gravatar_id":"","url":"https://api.github.com/users/lumeet","html_url":"https://github.com/lumeet","followers_url":"https://api.github.com/users/lumeet/followers","following_url":"https://api.github.com/users/lumeet/following{/other_user}","gists_url":"https://api.github.com/users/lumeet/gists{/gist_id}","starred_url":"https://api.github.com/users/lumeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumeet/subscriptions","organizations_url":"https://api.github.com/users/lumeet/orgs","repos_url":"https://api.github.com/users/lumeet/repos","events_url":"https://api.github.com/users/lumeet/events{/privacy}","received_events_url":"https://api.github.com/users/lumeet/received_events","type":"User","site_admin":false},"repo":{"id":28781397,"name":"rubocop","full_name":"lumeet/rubocop","owner":{"login":"lumeet","id":7588782,"avatar_url":"https://avatars.githubusercontent.com/u/7588782?v=3","gravatar_id":"","url":"https://api.github.com/users/lumeet","html_url":"https://github.com/lumeet","followers_url":"https://api.github.com/users/lumeet/followers","following_url":"https://api.github.com/users/lumeet/following{/other_user}","gists_url":"https://api.github.com/users/lumeet/gists{/gist_id}","starred_url":"https://api.github.com/users/lumeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumeet/subscriptions","organizations_url":"https://api.github.com/users/lumeet/orgs","repos_url":"https://api.github.com/users/lumeet/repos","events_url":"https://api.github.com/users/lumeet/events{/privacy}","received_events_url":"https://api.github.com/users/lumeet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lumeet/rubocop","description":"A Ruby static code analyzer, based on the community Ruby style guide.","fork":true,"url":"https://api.github.com/repos/lumeet/rubocop","forks_url":"https://api.github.com/repos/lumeet/rubocop/forks","keys_url":"https://api.github.com/repos/lumeet/rubocop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lumeet/rubocop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lumeet/rubocop/teams","hooks_url":"https://api.github.com/repos/lumeet/rubocop/hooks","issue_events_url":"https://api.github.com/repos/lumeet/rubocop/issues/events{/number}","events_url":"https://api.github.com/repos/lumeet/rubocop/events","assignees_url":"https://api.github.com/repos/lumeet/rubocop/assignees{/user}","branches_url":"https://api.github.com/repos/lumeet/rubocop/branches{/branch}","tags_url":"https://api.github.com/repos/lumeet/rubocop/tags","blobs_url":"https://api.github.com/repos/lumeet/rubocop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lumeet/rubocop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lumeet/rubocop/git/refs{/sha}","trees_url":"https://api.github.com/repos/lumeet/rubocop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lumeet/rubocop/statuses/{sha}","languages_url":"https://api.github.com/repos/lumeet/rubocop/languages","stargazers_url":"https://api.github.com/repos/lumeet/rubocop/stargazers","contributors_url":"https://api.github.com/repos/lumeet/rubocop/contributors","subscribers_url":"https://api.github.com/repos/lumeet/rubocop/subscribers","subscription_url":"https://api.github.com/repos/lumeet/rubocop/subscription","commits_url":"https://api.github.com/repos/lumeet/rubocop/commits{/sha}","git_commits_url":"https://api.github.com/repos/lumeet/rubocop/git/commits{/sha}","comments_url":"https://api.github.com/repos/lumeet/rubocop/comments{/number}","issue_comment_url":"https://api.github.com/repos/lumeet/rubocop/issues/comments{/number}","contents_url":"https://api.github.com/repos/lumeet/rubocop/contents/{+path}","compare_url":"https://api.github.com/repos/lumeet/rubocop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lumeet/rubocop/merges","archive_url":"https://api.github.com/repos/lumeet/rubocop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lumeet/rubocop/downloads","issues_url":"https://api.github.com/repos/lumeet/rubocop/issues{/number}","pulls_url":"https://api.github.com/repos/lumeet/rubocop/pulls{/number}","milestones_url":"https://api.github.com/repos/lumeet/rubocop/milestones{/number}","notifications_url":"https://api.github.com/repos/lumeet/rubocop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lumeet/rubocop/labels{/name}","releases_url":"https://api.github.com/repos/lumeet/rubocop/releases{/id}","created_at":"2015-01-04T17:53:39Z","updated_at":"2015-05-07T17:36:57Z","pushed_at":"2015-06-04T18:27:58Z","git_url":"git://github.com/lumeet/rubocop.git","ssh_url":"git@github.com:lumeet/rubocop.git","clone_url":"https://github.com/lumeet/rubocop.git","svn_url":"https://github.com/lumeet/rubocop","homepage":"","size":9370,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bbatsov:master","ref":"master","sha":"656284eddcf6938ad6f926d57eae6044c9589be6","user":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars.githubusercontent.com/u/103882?v=3","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"repo":{"id":4095287,"name":"rubocop","full_name":"bbatsov/rubocop","owner":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars.githubusercontent.com/u/103882?v=3","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bbatsov/rubocop","description":"A Ruby static code analyzer, based on the community Ruby style guide.","fork":false,"url":"https://api.github.com/repos/bbatsov/rubocop","forks_url":"https://api.github.com/repos/bbatsov/rubocop/forks","keys_url":"https://api.github.com/repos/bbatsov/rubocop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbatsov/rubocop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbatsov/rubocop/teams","hooks_url":"https://api.github.com/repos/bbatsov/rubocop/hooks","issue_events_url":"https://api.github.com/repos/bbatsov/rubocop/issues/events{/number}","events_url":"https://api.github.com/repos/bbatsov/rubocop/events","assignees_url":"https://api.github.com/repos/bbatsov/rubocop/assignees{/user}","branches_url":"https://api.github.com/repos/bbatsov/rubocop/branches{/branch}","tags_url":"https://api.github.com/repos/bbatsov/rubocop/tags","blobs_url":"https://api.github.com/repos/bbatsov/rubocop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbatsov/rubocop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbatsov/rubocop/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbatsov/rubocop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbatsov/rubocop/statuses/{sha}","languages_url":"https://api.github.com/repos/bbatsov/rubocop/languages","stargazers_url":"https://api.github.com/repos/bbatsov/rubocop/stargazers","contributors_url":"https://api.github.com/repos/bbatsov/rubocop/contributors","subscribers_url":"https://api.github.com/repos/bbatsov/rubocop/subscribers","subscription_url":"https://api.github.com/repos/bbatsov/rubocop/subscription","commits_url":"https://api.github.com/repos/bbatsov/rubocop/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbatsov/rubocop/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbatsov/rubocop/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbatsov/rubocop/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbatsov/rubocop/contents/{+path}","compare_url":"https://api.github.com/repos/bbatsov/rubocop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbatsov/rubocop/merges","archive_url":"https://api.github.com/repos/bbatsov/rubocop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbatsov/rubocop/downloads","issues_url":"https://api.github.com/repos/bbatsov/rubocop/issues{/number}","pulls_url":"https://api.github.com/repos/bbatsov/rubocop/pulls{/number}","milestones_url":"https://api.github.com/repos/bbatsov/rubocop/milestones{/number}","notifications_url":"https://api.github.com/repos/bbatsov/rubocop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbatsov/rubocop/labels{/name}","releases_url":"https://api.github.com/repos/bbatsov/rubocop/releases{/id}","created_at":"2012-04-21T10:09:58Z","updated_at":"2015-06-04T18:56:19Z","pushed_at":"2015-06-04T22:31:23Z","git_url":"git://github.com/bbatsov/rubocop.git","ssh_url":"git@github.com:bbatsov/rubocop.git","clone_url":"https://github.com/bbatsov/rubocop.git","svn_url":"https://github.com/bbatsov/rubocop","homepage":"","size":22078,"stargazers_count":4610,"watchers_count":4610,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":489,"mirror_url":null,"open_issues_count":94,"forks":489,"open_issues":94,"watchers":4610,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/1946"},"html":{"href":"https://github.com/bbatsov/rubocop/pull/1946"},"issue":{"href":"https://api.github.com/repos/bbatsov/rubocop/issues/1946"},"comments":{"href":"https://api.github.com/repos/bbatsov/rubocop/issues/1946/comments"},"review_comments":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/1946/comments"},"review_comment":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/1946/commits"},"statuses":{"href":"https://api.github.com/repos/bbatsov/rubocop/statuses/07aff8514f108bd45c5b1542107ed534cb087250"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars.githubusercontent.com/u/103882?v=3","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":12,"deletions":11,"changed_files":2}}