{"action":"created","issue":{"url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/20","labels_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/20/comments","events_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/20/events","html_url":"https://github.com/ligo-cbc/pycbc/pull/20","id":81098978,"number":20,"title":"add option to keep loudest X triggers every Y seconds","user":{"login":"ahnitz","id":2206534,"avatar_url":"https://avatars.githubusercontent.com/u/2206534?v=3","gravatar_id":"","url":"https://api.github.com/users/ahnitz","html_url":"https://github.com/ahnitz","followers_url":"https://api.github.com/users/ahnitz/followers","following_url":"https://api.github.com/users/ahnitz/following{/other_user}","gists_url":"https://api.github.com/users/ahnitz/gists{/gist_id}","starred_url":"https://api.github.com/users/ahnitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahnitz/subscriptions","organizations_url":"https://api.github.com/users/ahnitz/orgs","repos_url":"https://api.github.com/users/ahnitz/repos","events_url":"https://api.github.com/users/ahnitz/events{/privacy}","received_events_url":"https://api.github.com/users/ahnitz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"spxiwh","id":11438929,"avatar_url":"https://avatars.githubusercontent.com/u/11438929?v=3","gravatar_id":"","url":"https://api.github.com/users/spxiwh","html_url":"https://github.com/spxiwh","followers_url":"https://api.github.com/users/spxiwh/followers","following_url":"https://api.github.com/users/spxiwh/following{/other_user}","gists_url":"https://api.github.com/users/spxiwh/gists{/gist_id}","starred_url":"https://api.github.com/users/spxiwh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spxiwh/subscriptions","organizations_url":"https://api.github.com/users/spxiwh/orgs","repos_url":"https://api.github.com/users/spxiwh/repos","events_url":"https://api.github.com/users/spxiwh/events{/privacy}","received_events_url":"https://api.github.com/users/spxiwh/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-05-26T19:20:32Z","updated_at":"2015-05-27T10:37:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/20","html_url":"https://github.com/ligo-cbc/pycbc/pull/20","diff_url":"https://github.com/ligo-cbc/pycbc/pull/20.diff","patch_url":"https://github.com/ligo-cbc/pycbc/pull/20.patch"},"body":"This adds options in pycbc_inspiral to keep the loudest X number of triggers every Y seconds. This reduces the storage requirements of PyCBC when used in conjunction with #19. Initially, this is simply a storage improvement. If it turns out to work generally then it implies some further performance optimizations that could be used in conjunction with the heirarchical inspiral search. \r\n\r\nBNS run with 4 injection sets (injection every 130 s)\r\nOriginal: 16 GB \r\nKeep Loudest 100 triggers every 2 seconds -> 1.5 GB for single inspiral triggers \r\n\r\nSensitivity for the BNS search under these settings was unchanged. Although, I expected that as I found 100 by plotting the number of nearby triggers louder than the trigger found in coincidence for each significant injection. I think conservative settings should be safe, and may be improved by also including  scaling to the peak SNR (fewer triggers are needed the louder the peak signal). "},"comment":{"url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/comments/105861340","html_url":"https://github.com/ligo-cbc/pycbc/pull/20#issuecomment-105861340","issue_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/20","id":105861340,"user":{"login":"ahnitz","id":2206534,"avatar_url":"https://avatars.githubusercontent.com/u/2206534?v=3","gravatar_id":"","url":"https://api.github.com/users/ahnitz","html_url":"https://github.com/ahnitz","followers_url":"https://api.github.com/users/ahnitz/followers","following_url":"https://api.github.com/users/ahnitz/following{/other_user}","gists_url":"https://api.github.com/users/ahnitz/gists{/gist_id}","starred_url":"https://api.github.com/users/ahnitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahnitz/subscriptions","organizations_url":"https://api.github.com/users/ahnitz/orgs","repos_url":"https://api.github.com/users/ahnitz/repos","events_url":"https://api.github.com/users/ahnitz/events{/privacy}","received_events_url":"https://api.github.com/users/ahnitz/received_events","type":"User","site_admin":false},"created_at":"2015-05-27T10:37:31Z","updated_at":"2015-05-27T10:37:31Z","body":"Ian, \r\n\r\nGithub uses the \"fork & pull\" model. You don't so much as submit patches, but propose a branch to merge. I've posted some instructions (mostly links to github's own) to help explain this process. I think it is a lot easier than maintaining patches. \r\n\r\nhttps://www.lsc-group.phys.uwm.edu/ligovirgo/cbcnote/PyCBC/github\r\n\r\nThe gist is that you fork PyCBC on github to your own account, create a branch for your features/patches, and then push that branch to your account. You will then get an option on the web page to create a pull request. It's convenient because if you have to make modifications, you can simply push more commits to the branch. \r\n\r\nIf you question was how to modify my branch, then you can also do a pull request directly against that, just as this is a pull request against ligo-cbc/pycbc/master.\r\n\r\nAny thoughts on how well the methods you've tried have worked? I've haven't tried to be particularly smart about this, just enough trigger removal to reduce the injection set sizes greatly, which were the bulk of the data. The full data run is only reduced by ~50% as far as I can tell. "}}