{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/buildtools/pulls/comments/27342177","id":27342177,"diff_hunk":"@@ -69,13 +69,15 @@\n     <DebugSymbols Condition=\"'$(DebugSymbols)' == ''\">true</DebugSymbols>\n     <Optimize Condition=\"'$(Optimize)' == ''\">false</Optimize>\n     <DebugType Condition=\"'$(DebugType)' == ''\">full</DebugType>\n-    <DefineConstants>$(DefineConstants);DEBUG;TRACE</DefineConstants>\n+    <DefineConstants Condition=\"'$(MSBuildProjectExtension)' != '.vbproj'\">$(DefineConstants);DEBUG;TRACE</DefineConstants>","path":"dir.props","position":5,"original_position":5,"commit_id":"d391d1c5725c7474dc4e83894c0b97541ec0ed0d","original_commit_id":"d391d1c5725c7474dc4e83894c0b97541ec0ed0d","user":{"login":"weshaggard","id":9010698,"avatar_url":"https://avatars.githubusercontent.com/u/9010698?v=3","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"body":"I was hoping that we could keep the general defines non-duplicated by just having one set that is semi-colon delimited and we could split that and then comma delimited it in a single location. Any VB projects should choose to be semi-colon or comma delimited as I think either would still work.","created_at":"2015-03-28T04:05:18Z","updated_at":"2015-03-28T04:05:18Z","html_url":"https://github.com/dotnet/buildtools/pull/128#discussion_r27342177","pull_request_url":"https://api.github.com/repos/dotnet/buildtools/pulls/128","_links":{"self":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/comments/27342177"},"html":{"href":"https://github.com/dotnet/buildtools/pull/128#discussion_r27342177"},"pull_request":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/128"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/buildtools/pulls/128","id":32153700,"html_url":"https://github.com/dotnet/buildtools/pull/128","diff_url":"https://github.com/dotnet/buildtools/pull/128.diff","patch_url":"https://github.com/dotnet/buildtools/pull/128.patch","issue_url":"https://api.github.com/repos/dotnet/buildtools/issues/128","number":128,"state":"open","locked":false,"title":"Add support for building VB projects.","user":{"login":"AlekseyTs","id":10522107,"avatar_url":"https://avatars.githubusercontent.com/u/10522107?v=3","gravatar_id":"","url":"https://api.github.com/users/AlekseyTs","html_url":"https://github.com/AlekseyTs","followers_url":"https://api.github.com/users/AlekseyTs/followers","following_url":"https://api.github.com/users/AlekseyTs/following{/other_user}","gists_url":"https://api.github.com/users/AlekseyTs/gists{/gist_id}","starred_url":"https://api.github.com/users/AlekseyTs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlekseyTs/subscriptions","organizations_url":"https://api.github.com/users/AlekseyTs/orgs","repos_url":"https://api.github.com/users/AlekseyTs/repos","events_url":"https://api.github.com/users/AlekseyTs/events{/privacy}","received_events_url":"https://api.github.com/users/AlekseyTs/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-03-27T23:37:17Z","updated_at":"2015-03-28T04:05:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"864ed5ee2b0685209c9aee03204043218668ecba","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/buildtools/pulls/128/commits","review_comments_url":"https://api.github.com/repos/dotnet/buildtools/pulls/128/comments","review_comment_url":"https://api.github.com/repos/dotnet/buildtools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/buildtools/issues/128/comments","statuses_url":"https://api.github.com/repos/dotnet/buildtools/statuses/d391d1c5725c7474dc4e83894c0b97541ec0ed0d","head":{"label":"AlekseyTs:SupportVB","ref":"SupportVB","sha":"d391d1c5725c7474dc4e83894c0b97541ec0ed0d","user":{"login":"AlekseyTs","id":10522107,"avatar_url":"https://avatars.githubusercontent.com/u/10522107?v=3","gravatar_id":"","url":"https://api.github.com/users/AlekseyTs","html_url":"https://github.com/AlekseyTs","followers_url":"https://api.github.com/users/AlekseyTs/followers","following_url":"https://api.github.com/users/AlekseyTs/following{/other_user}","gists_url":"https://api.github.com/users/AlekseyTs/gists{/gist_id}","starred_url":"https://api.github.com/users/AlekseyTs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlekseyTs/subscriptions","organizations_url":"https://api.github.com/users/AlekseyTs/orgs","repos_url":"https://api.github.com/users/AlekseyTs/repos","events_url":"https://api.github.com/users/AlekseyTs/events{/privacy}","received_events_url":"https://api.github.com/users/AlekseyTs/received_events","type":"User","site_admin":false},"repo":{"id":32955071,"name":"buildtools","full_name":"AlekseyTs/buildtools","owner":{"login":"AlekseyTs","id":10522107,"avatar_url":"https://avatars.githubusercontent.com/u/10522107?v=3","gravatar_id":"","url":"https://api.github.com/users/AlekseyTs","html_url":"https://github.com/AlekseyTs","followers_url":"https://api.github.com/users/AlekseyTs/followers","following_url":"https://api.github.com/users/AlekseyTs/following{/other_user}","gists_url":"https://api.github.com/users/AlekseyTs/gists{/gist_id}","starred_url":"https://api.github.com/users/AlekseyTs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlekseyTs/subscriptions","organizations_url":"https://api.github.com/users/AlekseyTs/orgs","repos_url":"https://api.github.com/users/AlekseyTs/repos","events_url":"https://api.github.com/users/AlekseyTs/events{/privacy}","received_events_url":"https://api.github.com/users/AlekseyTs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AlekseyTs/buildtools","description":"Build tools that are necessary for building the .NET Core projects","fork":true,"url":"https://api.github.com/repos/AlekseyTs/buildtools","forks_url":"https://api.github.com/repos/AlekseyTs/buildtools/forks","keys_url":"https://api.github.com/repos/AlekseyTs/buildtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlekseyTs/buildtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlekseyTs/buildtools/teams","hooks_url":"https://api.github.com/repos/AlekseyTs/buildtools/hooks","issue_events_url":"https://api.github.com/repos/AlekseyTs/buildtools/issues/events{/number}","events_url":"https://api.github.com/repos/AlekseyTs/buildtools/events","assignees_url":"https://api.github.com/repos/AlekseyTs/buildtools/assignees{/user}","branches_url":"https://api.github.com/repos/AlekseyTs/buildtools/branches{/branch}","tags_url":"https://api.github.com/repos/AlekseyTs/buildtools/tags","blobs_url":"https://api.github.com/repos/AlekseyTs/buildtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlekseyTs/buildtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlekseyTs/buildtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlekseyTs/buildtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlekseyTs/buildtools/statuses/{sha}","languages_url":"https://api.github.com/repos/AlekseyTs/buildtools/languages","stargazers_url":"https://api.github.com/repos/AlekseyTs/buildtools/stargazers","contributors_url":"https://api.github.com/repos/AlekseyTs/buildtools/contributors","subscribers_url":"https://api.github.com/repos/AlekseyTs/buildtools/subscribers","subscription_url":"https://api.github.com/repos/AlekseyTs/buildtools/subscription","commits_url":"https://api.github.com/repos/AlekseyTs/buildtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlekseyTs/buildtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlekseyTs/buildtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlekseyTs/buildtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlekseyTs/buildtools/contents/{+path}","compare_url":"https://api.github.com/repos/AlekseyTs/buildtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlekseyTs/buildtools/merges","archive_url":"https://api.github.com/repos/AlekseyTs/buildtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlekseyTs/buildtools/downloads","issues_url":"https://api.github.com/repos/AlekseyTs/buildtools/issues{/number}","pulls_url":"https://api.github.com/repos/AlekseyTs/buildtools/pulls{/number}","milestones_url":"https://api.github.com/repos/AlekseyTs/buildtools/milestones{/number}","notifications_url":"https://api.github.com/repos/AlekseyTs/buildtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlekseyTs/buildtools/labels{/name}","releases_url":"https://api.github.com/repos/AlekseyTs/buildtools/releases{/id}","created_at":"2015-03-26T22:24:05Z","updated_at":"2015-03-26T22:24:05Z","pushed_at":"2015-03-27T23:32:11Z","git_url":"git://github.com/AlekseyTs/buildtools.git","ssh_url":"git@github.com:AlekseyTs/buildtools.git","clone_url":"https://github.com/AlekseyTs/buildtools.git","svn_url":"https://github.com/AlekseyTs/buildtools","homepage":"","size":2009,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"dfb46d74281b86293fd930aa66ac6fd420cf9601","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295349,"name":"buildtools","full_name":"dotnet/buildtools","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/buildtools","description":"Build tools that are necessary for building the .NET Core projects","fork":false,"url":"https://api.github.com/repos/dotnet/buildtools","forks_url":"https://api.github.com/repos/dotnet/buildtools/forks","keys_url":"https://api.github.com/repos/dotnet/buildtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/buildtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/buildtools/teams","hooks_url":"https://api.github.com/repos/dotnet/buildtools/hooks","issue_events_url":"https://api.github.com/repos/dotnet/buildtools/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/buildtools/events","assignees_url":"https://api.github.com/repos/dotnet/buildtools/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/buildtools/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/buildtools/tags","blobs_url":"https://api.github.com/repos/dotnet/buildtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/buildtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/buildtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/buildtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/buildtools/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/buildtools/languages","stargazers_url":"https://api.github.com/repos/dotnet/buildtools/stargazers","contributors_url":"https://api.github.com/repos/dotnet/buildtools/contributors","subscribers_url":"https://api.github.com/repos/dotnet/buildtools/subscribers","subscription_url":"https://api.github.com/repos/dotnet/buildtools/subscription","commits_url":"https://api.github.com/repos/dotnet/buildtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/buildtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/buildtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/buildtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/buildtools/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/buildtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/buildtools/merges","archive_url":"https://api.github.com/repos/dotnet/buildtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/buildtools/downloads","issues_url":"https://api.github.com/repos/dotnet/buildtools/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/buildtools/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/buildtools/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/buildtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/buildtools/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/buildtools/releases{/id}","created_at":"2014-11-06T23:43:05Z","updated_at":"2015-03-27T23:04:24Z","pushed_at":"2015-03-27T23:41:30Z","git_url":"git://github.com/dotnet/buildtools.git","ssh_url":"git@github.com:dotnet/buildtools.git","clone_url":"https://github.com/dotnet/buildtools.git","svn_url":"https://github.com/dotnet/buildtools","homepage":"","size":2009,"stargazers_count":330,"watchers_count":330,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":122,"mirror_url":null,"open_issues_count":5,"forks":122,"open_issues":5,"watchers":330,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/128"},"html":{"href":"https://github.com/dotnet/buildtools/pull/128"},"issue":{"href":"https://api.github.com/repos/dotnet/buildtools/issues/128"},"comments":{"href":"https://api.github.com/repos/dotnet/buildtools/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/buildtools/statuses/d391d1c5725c7474dc4e83894c0b97541ec0ed0d"}}}}