{"action":"created","comment":{"url":"https://api.github.com/repos/scala-js/scala-js/pulls/comments/30141672","id":30141672,"diff_hunk":"@@ -0,0 +1,92 @@\n+package java.util\n+\n+import scala.annotation.tailrec\n+import scala.collection.JavaConversions._\n+import scala.collection.immutable.{List => SList}\n+\n+abstract class AbstractCollection[E] extends java.util.Collection[E] {\n+  def iterator(): Iterator[E]\n+  def size(): Int\n+\n+  @tailrec\n+  private def iterateApplyAndDo[X](i: Iterator[E], f: (Iterator[E], E) => X, \n+      part: SList[X] = SList()): SList[X] = {\n+    if (i.hasNext) iterateApplyAndDo(i, f, f(i, i.next()) :: part)\n+    else part\n+  }\n+\n+  @tailrec\n+  private def iterateAndApply(i: Iterator[E], f: Iterator[E] => Unit): Unit = {\n+    if (i.hasNext) {\n+      f(i)\n+      iterateAndApply(i, f)\n+    } else return\n+  }\n+\n+  @tailrec\n+  private def iterateCheckAndApply(i: Iterator[E], f: (Iterator[E], E) => Boolean): Boolean = {\n+    if (i.hasNext) {\n+      if (f(i, i.next())) true\n+      else iterateCheckAndApply(i, f)\n+    } else false\n+  }\n+\n+  def isEmpty(): Boolean = size == 0\n+\n+  def contains(o: Any): Boolean =\n+    asScalaIterator(iterator).contains(o)\n+  def containsAll(c: java.util.Collection[_]): Boolean =\n+    asScalaIterator(c.iterator).foldLeft(true)((prev, item) => contains(item: Any) && prev)\n+\n+  def add(e: E): Boolean =\n+    throw new UnsupportedOperationException()\n+  def addAll[E1 <: E](c: java.util.Collection[E1]): Boolean =\n+    throw new UnsupportedOperationException()\n+\n+  def clear(): Unit =\n+    iterateAndApply(iterator, _.remove())\n+\n+  def remove(o: Any): Boolean = {\n+    iterateCheckAndApply(iterator, {\n+      case (i, e) if e.equals(o) =>\n+        i.remove()\n+        true\n+      case _ => false\n+    })\n+  }\n+\n+  def removeAll(c: java.util.Collection[E]): Boolean = {\n+    iterateApplyAndDo(iterator, {\n+      case (i, e) if (c.contains(e)) => { i.remove(); true }\n+      case _ => false\n+    }).exists(_ == true)\n+  }\n+\n+  def retainAll(c: java.util.Collection[E]): Boolean = {\n+    iterateApplyAndDo(iterator, {\n+      case (i, e) if (!c.contains(e)) => { i.remove(); true }\n+      case _ => false\n+    }).exists(_ == true)\n+  }\n+\n+  override def toString(): String =\n+    asScalaIterator(iterator).map(java.lang.String.valueOf(_)).mkString(\"[\", \",\", \"]\")","path":"javalib/src/main/scala/java/util/AbstractCollection.scala","position":73,"original_position":73,"commit_id":"4c24b991cde78bfda8ba56fd5b7bfe6fb84c7678","original_commit_id":"4c24b991cde78bfda8ba56fd5b7bfe6fb84c7678","user":{"login":"sjrd","id":535934,"avatar_url":"https://avatars.githubusercontent.com/u/535934?v=3","gravatar_id":"","url":"https://api.github.com/users/sjrd","html_url":"https://github.com/sjrd","followers_url":"https://api.github.com/users/sjrd/followers","following_url":"https://api.github.com/users/sjrd/following{/other_user}","gists_url":"https://api.github.com/users/sjrd/gists{/gist_id}","starred_url":"https://api.github.com/users/sjrd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjrd/subscriptions","organizations_url":"https://api.github.com/users/sjrd/orgs","repos_url":"https://api.github.com/users/sjrd/repos","events_url":"https://api.github.com/users/sjrd/events{/privacy}","received_events_url":"https://api.github.com/users/sjrd/received_events","type":"User","site_admin":false},"body":"`.map(java.lang.String.valueOf(_))` is not needed. `mkString` converts all elements to strings on its own (and `null`s to the string `\"null\"`)","created_at":"2015-05-12T14:51:38Z","updated_at":"2015-05-12T14:51:38Z","html_url":"https://github.com/scala-js/scala-js/pull/1636#discussion_r30141672","pull_request_url":"https://api.github.com/repos/scala-js/scala-js/pulls/1636","_links":{"self":{"href":"https://api.github.com/repos/scala-js/scala-js/pulls/comments/30141672"},"html":{"href":"https://github.com/scala-js/scala-js/pull/1636#discussion_r30141672"},"pull_request":{"href":"https://api.github.com/repos/scala-js/scala-js/pulls/1636"}}},"pull_request":{"url":"https://api.github.com/repos/scala-js/scala-js/pulls/1636","id":34717020,"html_url":"https://github.com/scala-js/scala-js/pull/1636","diff_url":"https://github.com/scala-js/scala-js/pull/1636.diff","patch_url":"https://github.com/scala-js/scala-js/pull/1636.patch","issue_url":"https://api.github.com/repos/scala-js/scala-js/issues/1636","number":1636,"state":"open","locked":false,"title":"Issue: #1487 Added ConcurrentHashMap implementation","user":{"login":"andreaTP","id":5792097,"avatar_url":"https://avatars.githubusercontent.com/u/5792097?v=3","gravatar_id":"","url":"https://api.github.com/users/andreaTP","html_url":"https://github.com/andreaTP","followers_url":"https://api.github.com/users/andreaTP/followers","following_url":"https://api.github.com/users/andreaTP/following{/other_user}","gists_url":"https://api.github.com/users/andreaTP/gists{/gist_id}","starred_url":"https://api.github.com/users/andreaTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreaTP/subscriptions","organizations_url":"https://api.github.com/users/andreaTP/orgs","repos_url":"https://api.github.com/users/andreaTP/repos","events_url":"https://api.github.com/users/andreaTP/events{/privacy}","received_events_url":"https://api.github.com/users/andreaTP/received_events","type":"User","site_admin":false},"body":"This is an implementation of ConcurrentHashMap in java.util.concurrent.\r\nTo keep it working nicely I had to stub a bit of the java.util.Collection related interfaces, please consider them just a stub to let scala.collection.JavaConversions works, I will ask for some discussion and/or review about the actual implementation.\r\n\r\nAnother issue is about the keySet method, unfortunately, the signature of this method changed in Java 8, I wait for suggestions on how to manage that.","created_at":"2015-05-05T11:55:06Z","updated_at":"2015-05-12T14:51:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5631a750cafe1a3fbf0ea1b928247191a712e8ae","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scala-js/scala-js/pulls/1636/commits","review_comments_url":"https://api.github.com/repos/scala-js/scala-js/pulls/1636/comments","review_comment_url":"https://api.github.com/repos/scala-js/scala-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scala-js/scala-js/issues/1636/comments","statuses_url":"https://api.github.com/repos/scala-js/scala-js/statuses/4c24b991cde78bfda8ba56fd5b7bfe6fb84c7678","head":{"label":"andreaTP:master","ref":"master","sha":"4c24b991cde78bfda8ba56fd5b7bfe6fb84c7678","user":{"login":"andreaTP","id":5792097,"avatar_url":"https://avatars.githubusercontent.com/u/5792097?v=3","gravatar_id":"","url":"https://api.github.com/users/andreaTP","html_url":"https://github.com/andreaTP","followers_url":"https://api.github.com/users/andreaTP/followers","following_url":"https://api.github.com/users/andreaTP/following{/other_user}","gists_url":"https://api.github.com/users/andreaTP/gists{/gist_id}","starred_url":"https://api.github.com/users/andreaTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreaTP/subscriptions","organizations_url":"https://api.github.com/users/andreaTP/orgs","repos_url":"https://api.github.com/users/andreaTP/repos","events_url":"https://api.github.com/users/andreaTP/events{/privacy}","received_events_url":"https://api.github.com/users/andreaTP/received_events","type":"User","site_admin":false},"repo":{"id":34802802,"name":"scala-js","full_name":"andreaTP/scala-js","owner":{"login":"andreaTP","id":5792097,"avatar_url":"https://avatars.githubusercontent.com/u/5792097?v=3","gravatar_id":"","url":"https://api.github.com/users/andreaTP","html_url":"https://github.com/andreaTP","followers_url":"https://api.github.com/users/andreaTP/followers","following_url":"https://api.github.com/users/andreaTP/following{/other_user}","gists_url":"https://api.github.com/users/andreaTP/gists{/gist_id}","starred_url":"https://api.github.com/users/andreaTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreaTP/subscriptions","organizations_url":"https://api.github.com/users/andreaTP/orgs","repos_url":"https://api.github.com/users/andreaTP/repos","events_url":"https://api.github.com/users/andreaTP/events{/privacy}","received_events_url":"https://api.github.com/users/andreaTP/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andreaTP/scala-js","description":"Scala.js, the Scala to JavaScript compiler","fork":true,"url":"https://api.github.com/repos/andreaTP/scala-js","forks_url":"https://api.github.com/repos/andreaTP/scala-js/forks","keys_url":"https://api.github.com/repos/andreaTP/scala-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andreaTP/scala-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andreaTP/scala-js/teams","hooks_url":"https://api.github.com/repos/andreaTP/scala-js/hooks","issue_events_url":"https://api.github.com/repos/andreaTP/scala-js/issues/events{/number}","events_url":"https://api.github.com/repos/andreaTP/scala-js/events","assignees_url":"https://api.github.com/repos/andreaTP/scala-js/assignees{/user}","branches_url":"https://api.github.com/repos/andreaTP/scala-js/branches{/branch}","tags_url":"https://api.github.com/repos/andreaTP/scala-js/tags","blobs_url":"https://api.github.com/repos/andreaTP/scala-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andreaTP/scala-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andreaTP/scala-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/andreaTP/scala-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andreaTP/scala-js/statuses/{sha}","languages_url":"https://api.github.com/repos/andreaTP/scala-js/languages","stargazers_url":"https://api.github.com/repos/andreaTP/scala-js/stargazers","contributors_url":"https://api.github.com/repos/andreaTP/scala-js/contributors","subscribers_url":"https://api.github.com/repos/andreaTP/scala-js/subscribers","subscription_url":"https://api.github.com/repos/andreaTP/scala-js/subscription","commits_url":"https://api.github.com/repos/andreaTP/scala-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/andreaTP/scala-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/andreaTP/scala-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/andreaTP/scala-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/andreaTP/scala-js/contents/{+path}","compare_url":"https://api.github.com/repos/andreaTP/scala-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andreaTP/scala-js/merges","archive_url":"https://api.github.com/repos/andreaTP/scala-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andreaTP/scala-js/downloads","issues_url":"https://api.github.com/repos/andreaTP/scala-js/issues{/number}","pulls_url":"https://api.github.com/repos/andreaTP/scala-js/pulls{/number}","milestones_url":"https://api.github.com/repos/andreaTP/scala-js/milestones{/number}","notifications_url":"https://api.github.com/repos/andreaTP/scala-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andreaTP/scala-js/labels{/name}","releases_url":"https://api.github.com/repos/andreaTP/scala-js/releases{/id}","created_at":"2015-04-29T15:44:28Z","updated_at":"2015-05-08T05:56:23Z","pushed_at":"2015-05-11T16:46:41Z","git_url":"git://github.com/andreaTP/scala-js.git","ssh_url":"git@github.com:andreaTP/scala-js.git","clone_url":"https://github.com/andreaTP/scala-js.git","svn_url":"https://github.com/andreaTP/scala-js","homepage":"http://www.scala-js.org/","size":7955,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scala-js:master","ref":"master","sha":"6dbab2c3ebb665efe0c1eee2af33202d6edc42e2","user":{"login":"scala-js","id":6039724,"avatar_url":"https://avatars.githubusercontent.com/u/6039724?v=3","gravatar_id":"","url":"https://api.github.com/users/scala-js","html_url":"https://github.com/scala-js","followers_url":"https://api.github.com/users/scala-js/followers","following_url":"https://api.github.com/users/scala-js/following{/other_user}","gists_url":"https://api.github.com/users/scala-js/gists{/gist_id}","starred_url":"https://api.github.com/users/scala-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala-js/subscriptions","organizations_url":"https://api.github.com/users/scala-js/orgs","repos_url":"https://api.github.com/users/scala-js/repos","events_url":"https://api.github.com/users/scala-js/events{/privacy}","received_events_url":"https://api.github.com/users/scala-js/received_events","type":"Organization","site_admin":false},"repo":{"id":8272315,"name":"scala-js","full_name":"scala-js/scala-js","owner":{"login":"scala-js","id":6039724,"avatar_url":"https://avatars.githubusercontent.com/u/6039724?v=3","gravatar_id":"","url":"https://api.github.com/users/scala-js","html_url":"https://github.com/scala-js","followers_url":"https://api.github.com/users/scala-js/followers","following_url":"https://api.github.com/users/scala-js/following{/other_user}","gists_url":"https://api.github.com/users/scala-js/gists{/gist_id}","starred_url":"https://api.github.com/users/scala-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala-js/subscriptions","organizations_url":"https://api.github.com/users/scala-js/orgs","repos_url":"https://api.github.com/users/scala-js/repos","events_url":"https://api.github.com/users/scala-js/events{/privacy}","received_events_url":"https://api.github.com/users/scala-js/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scala-js/scala-js","description":"Scala.js, the Scala to JavaScript compiler","fork":false,"url":"https://api.github.com/repos/scala-js/scala-js","forks_url":"https://api.github.com/repos/scala-js/scala-js/forks","keys_url":"https://api.github.com/repos/scala-js/scala-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scala-js/scala-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scala-js/scala-js/teams","hooks_url":"https://api.github.com/repos/scala-js/scala-js/hooks","issue_events_url":"https://api.github.com/repos/scala-js/scala-js/issues/events{/number}","events_url":"https://api.github.com/repos/scala-js/scala-js/events","assignees_url":"https://api.github.com/repos/scala-js/scala-js/assignees{/user}","branches_url":"https://api.github.com/repos/scala-js/scala-js/branches{/branch}","tags_url":"https://api.github.com/repos/scala-js/scala-js/tags","blobs_url":"https://api.github.com/repos/scala-js/scala-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scala-js/scala-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scala-js/scala-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/scala-js/scala-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scala-js/scala-js/statuses/{sha}","languages_url":"https://api.github.com/repos/scala-js/scala-js/languages","stargazers_url":"https://api.github.com/repos/scala-js/scala-js/stargazers","contributors_url":"https://api.github.com/repos/scala-js/scala-js/contributors","subscribers_url":"https://api.github.com/repos/scala-js/scala-js/subscribers","subscription_url":"https://api.github.com/repos/scala-js/scala-js/subscription","commits_url":"https://api.github.com/repos/scala-js/scala-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/scala-js/scala-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/scala-js/scala-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/scala-js/scala-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/scala-js/scala-js/contents/{+path}","compare_url":"https://api.github.com/repos/scala-js/scala-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scala-js/scala-js/merges","archive_url":"https://api.github.com/repos/scala-js/scala-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scala-js/scala-js/downloads","issues_url":"https://api.github.com/repos/scala-js/scala-js/issues{/number}","pulls_url":"https://api.github.com/repos/scala-js/scala-js/pulls{/number}","milestones_url":"https://api.github.com/repos/scala-js/scala-js/milestones{/number}","notifications_url":"https://api.github.com/repos/scala-js/scala-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scala-js/scala-js/labels{/name}","releases_url":"https://api.github.com/repos/scala-js/scala-js/releases{/id}","created_at":"2013-02-18T16:33:55Z","updated_at":"2015-05-12T13:57:08Z","pushed_at":"2015-05-12T11:05:06Z","git_url":"git://github.com/scala-js/scala-js.git","ssh_url":"git@github.com:scala-js/scala-js.git","clone_url":"https://github.com/scala-js/scala-js.git","svn_url":"https://github.com/scala-js/scala-js","homepage":"http://www.scala-js.org/","size":16670,"stargazers_count":1662,"watchers_count":1662,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":137,"mirror_url":null,"open_issues_count":48,"forks":137,"open_issues":48,"watchers":1662,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scala-js/scala-js/pulls/1636"},"html":{"href":"https://github.com/scala-js/scala-js/pull/1636"},"issue":{"href":"https://api.github.com/repos/scala-js/scala-js/issues/1636"},"comments":{"href":"https://api.github.com/repos/scala-js/scala-js/issues/1636/comments"},"review_comments":{"href":"https://api.github.com/repos/scala-js/scala-js/pulls/1636/comments"},"review_comment":{"href":"https://api.github.com/repos/scala-js/scala-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scala-js/scala-js/pulls/1636/commits"},"statuses":{"href":"https://api.github.com/repos/scala-js/scala-js/statuses/4c24b991cde78bfda8ba56fd5b7bfe6fb84c7678"}}}}