{"action":"created","issue":{"url":"https://api.github.com/repos/musescore/MuseScore/issues/2174","labels_url":"https://api.github.com/repos/musescore/MuseScore/issues/2174/labels{/name}","comments_url":"https://api.github.com/repos/musescore/MuseScore/issues/2174/comments","events_url":"https://api.github.com/repos/musescore/MuseScore/issues/2174/events","html_url":"https://github.com/musescore/MuseScore/pull/2174","id":101552906,"number":2174,"title":"Note input nagivation in gaps","user":{"login":"MarcSabatella","id":1799936,"avatar_url":"https://avatars.githubusercontent.com/u/1799936?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcSabatella","html_url":"https://github.com/MarcSabatella","followers_url":"https://api.github.com/users/MarcSabatella/followers","following_url":"https://api.github.com/users/MarcSabatella/following{/other_user}","gists_url":"https://api.github.com/users/MarcSabatella/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcSabatella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcSabatella/subscriptions","organizations_url":"https://api.github.com/users/MarcSabatella/orgs","repos_url":"https://api.github.com/users/MarcSabatella/repos","events_url":"https://api.github.com/users/MarcSabatella/events{/privacy}","received_events_url":"https://api.github.com/users/MarcSabatella/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-18T02:16:15Z","updated_at":"2015-08-18T11:54:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/musescore/MuseScore/pulls/2174","html_url":"https://github.com/musescore/MuseScore/pull/2174","diff_url":"https://github.com/musescore/MuseScore/pull/2174.diff","patch_url":"https://github.com/musescore/MuseScore/pull/2174.patch"},"body":"This primarily fixes https://musescore.org/en/node/69866, which was introduced with an earlier fix for https://musescore.org/en/node/63176.  The behavior introduced with that fix is logical and works well enough, but one aspect of it is seen as a regression: it is currently impossible to navigate into a gap at all.  Previously, one could at least navigate into a measure that contained no notes for a given voice, if one pressed the cursor right key while on the last note of the previous measure.\r\n\r\nThe original fix made sure a valid element was selected if you tried to navigate into a gap, but by then explicitly selecting that element even though it was already selected, this broke the navigation into the gap.  The input cursor follows the selection, so the cursor never actually enters the gap.\r\n\r\nMy fix here simply disables the re-selecting of the already-selected element in cases where you have navigated itno a gap.  So the original bug is still fixed (we keep the current selection even though there is no chordrest at the input cursor position), but it is now possible to navigate into a gap if you start from a valid selection.\r\n\r\nThere was discussion in the threads for the original bug & my proposed PR that we should select the rest that remains behind after deleting a note.  That was part of the original bug report.  My second commit here goes ahead and explicitly selects the rest (or top note of chord if there are still notes left) after deleting a note, thus completing the fix for the original bug."},"comment":{"url":"https://api.github.com/repos/musescore/MuseScore/issues/comments/132185871","html_url":"https://github.com/musescore/MuseScore/pull/2174#issuecomment-132185871","issue_url":"https://api.github.com/repos/musescore/MuseScore/issues/2174","id":132185871,"user":{"login":"lasconic","id":234271,"avatar_url":"https://avatars.githubusercontent.com/u/234271?v=3","gravatar_id":"","url":"https://api.github.com/users/lasconic","html_url":"https://github.com/lasconic","followers_url":"https://api.github.com/users/lasconic/followers","following_url":"https://api.github.com/users/lasconic/following{/other_user}","gists_url":"https://api.github.com/users/lasconic/gists{/gist_id}","starred_url":"https://api.github.com/users/lasconic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasconic/subscriptions","organizations_url":"https://api.github.com/users/lasconic/orgs","repos_url":"https://api.github.com/users/lasconic/repos","events_url":"https://api.github.com/users/lasconic/events{/privacy}","received_events_url":"https://api.github.com/users/lasconic/received_events","type":"User","site_admin":false},"created_at":"2015-08-18T11:54:39Z","updated_at":"2015-08-18T11:54:39Z","body":"I guess it would make sense to select something sensible even when not in note entry mode but that's a good start."}}