{"action":"created","issue":{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/1535","labels_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/1535/labels{/name}","comments_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/1535/comments","events_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/1535/events","html_url":"https://github.com/magnumripper/JohnTheRipper/issues/1535","id":94403096,"number":1535,"title":"Some dynamic formats report an incorrect salt size of 0","user":{"login":"magnumripper","id":1268598,"avatar_url":"https://avatars.githubusercontent.com/u/1268598?v=3","gravatar_id":"","url":"https://api.github.com/users/magnumripper","html_url":"https://github.com/magnumripper","followers_url":"https://api.github.com/users/magnumripper/followers","following_url":"https://api.github.com/users/magnumripper/following{/other_user}","gists_url":"https://api.github.com/users/magnumripper/gists{/gist_id}","starred_url":"https://api.github.com/users/magnumripper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnumripper/subscriptions","organizations_url":"https://api.github.com/users/magnumripper/orgs","repos_url":"https://api.github.com/users/magnumripper/repos","events_url":"https://api.github.com/users/magnumripper/events{/privacy}","received_events_url":"https://api.github.com/users/magnumripper/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/labels/bug","name":"bug","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"jfoug","id":1270024,"avatar_url":"https://avatars.githubusercontent.com/u/1270024?v=3","gravatar_id":"","url":"https://api.github.com/users/jfoug","html_url":"https://github.com/jfoug","followers_url":"https://api.github.com/users/jfoug/followers","following_url":"https://api.github.com/users/jfoug/following{/other_user}","gists_url":"https://api.github.com/users/jfoug/gists{/gist_id}","starred_url":"https://api.github.com/users/jfoug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfoug/subscriptions","organizations_url":"https://api.github.com/users/jfoug/orgs","repos_url":"https://api.github.com/users/jfoug/repos","events_url":"https://api.github.com/users/jfoug/events{/privacy}","received_events_url":"https://api.github.com/users/jfoug/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2015-07-10T22:08:00Z","updated_at":"2015-07-11T00:03:26Z","closed_at":null,"body":"Noted by Aleksey in http://www.openwall.com/lists/john-users/2015/06/30/1\r\n\r\nField 12 is \"salt size\" and the quoted whitespace in the command-line below are escaped tabs:\r\n```\r\n$ ../run/john --list=format-details -form=dynamic | cut -d\" \" -f1,7,12 | grep -F '$s' | grep \"   0\"\r\ndynamic_1011\tmd5($p.md5($s)) (WebEdition CMS) 128/128 AVX 4x3\t0\r\ndynamic_1012\tmd5($p.md5($s)) (WebEdition CMS) 128/128 AVX 4x3\t0\r\ndynamic_1014\tmd5($p.$s) (long salt) 128/128 AVX 4x3\t0\r\ndynamic_1016\tmd5($p.$s) (long salt) 128/128 AVX 4x3\t0\r\ndynamic_1017\tmd5($s.$p) (long salt) 128/128 AVX 4x3\t0\r\ndynamic_1502\tsha1(sha1($p).$s) (XenForo SHA-1) 128/128 AVX 4x1\t0\r\ndynamic_1503\tsha256(sha256($p).$s) (XenForo SHA-256) 128/128 AVX 4x\t0\r\ndynamic_1504\tsha1($s.$p.$s) 128/128 AVX 4x1\t0\r\n```\r\nI suppose these formats don't actually report a salt size of 0 when cracking, but it should be fixed for --list=format-[all-]details anyway. For example, they would be missed if we search for #saltfail formats like this:\r\n```\r\n$ ../run/john --list=format-details -form=dynamic | cut -d\" \" -f1,7,12 | grep -E '       (sha|md[45])\\(\\$s' | grep \"     64$\" \r\ndynamic_2004\tmd5($s.$p) (OSC) (PW > 31 bytes) 128/128 AVX 4x3\t64\r\ndynamic_2009\tmd5($s.md5($p)) (PW > 55 or salt > 23 bytes) 128/128 AVX 4x3\t64\r\ndynamic_2010\tmd5($s.md5($s.$p)) (PW > 32 or salt > 23 bytes) 128/128 AVX 4x3\t64\r\ndynamic_2011\tmd5($s.md5($p.$s)) (PW > 32 or salt > 23 bytes) 128/128 AVX 4x3\t64\r\nmd5ns\tmd5($s.$p) (OSC) (PW > 31 bytes) 128/128 AVX 4x3\t64\r\n```"},"comment":{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/comments/120553602","html_url":"https://github.com/magnumripper/JohnTheRipper/issues/1535#issuecomment-120553602","issue_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/1535","id":120553602,"user":{"login":"jfoug","id":1270024,"avatar_url":"https://avatars.githubusercontent.com/u/1270024?v=3","gravatar_id":"","url":"https://api.github.com/users/jfoug","html_url":"https://github.com/jfoug","followers_url":"https://api.github.com/users/jfoug/followers","following_url":"https://api.github.com/users/jfoug/following{/other_user}","gists_url":"https://api.github.com/users/jfoug/gists{/gist_id}","starred_url":"https://api.github.com/users/jfoug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfoug/subscriptions","organizations_url":"https://api.github.com/users/jfoug/orgs","repos_url":"https://api.github.com/users/jfoug/repos","events_url":"https://api.github.com/users/jfoug/events{/privacy}","received_events_url":"https://api.github.com/users/jfoug/received_events","type":"User","site_admin":false},"created_at":"2015-07-11T00:03:26Z","updated_at":"2015-07-11T00:03:26Z","body":"I was able to optimize 1011 a lot.\r\n\r\n\r\n$ ../run/john -test=3 -form=dynamic_1011\r\nBenchmarking: dynamic_1011 [md5($p.md5($s)) (WebEdition CMS) 128/128 XOP 4x2]... DONE\r\nMany salts:     5372K c/s real, 5370K c/s virtual\r\nOnly one salt:  4451K c/s real, 4492K c/s virtual\r\n\r\n$ ../run/john -test=3 -form=dynamic_1011\r\nBenchmarking: dynamic_1011 [md5($p.md5($s)) (WebEdition CMS) 128/128 XOP 4x2]... DONE\r\nMany salts:     10228K c/s real, 10241K c/s virtual\r\nOnly one salt:  7440K c/s real, 7432K c/s virtual\r\n\r\nAs I fix the salts on the rest, I will see about optimizations. I swore I searched recently and could not find any where this trick was not being used (MGF_SALT_AS_HEX flag)."}}