{"action":"created","comment":{"url":"https://api.github.com/repos/cpuguy83/docker/pulls/comments/26840122","id":26840122,"diff_hunk":"@@ -0,0 +1,87 @@\n+Brian Goff and Luke Marsden paired on an MVP of the plugin handshake interface.\n+\n+# pre-MVP design\n+\n+We ended up with the following design:\n+\n+```\n+$ docker run --plugin \\\n+    -v /var/run/docker.sock:/var/run/docker.sock \\\n+    clusterhq/flocker-plugin\n+```\n+\n+Note the new `--plugin` argument.\n+\n+Internally this translates into:\n+\n+```\n+$ docker run -d \\\n+\t-v /var/lib/docker/containers/<container_id>/plugin/:/var/run/docker/ \\\n+\t-v /var/run/docker.sock:/var/run/docker.sock \\\n+\tclusterhq/flocker-plugin\n+```\n+\n+Docker blocks on waiting for a successful handshake with the plugin on `/var/run/docker/plugin.sock` with an HTTP `POST /v1/handshake` with an empty body.\n+\n+# Plugin API\n+\n+## `POST /v1/handshake`\n+\n+**Request:** POST with empty body\n+\n+**Response:** `application/json` as follows:\n+\n+```\n+{\n+ InterestedIn: [\"volume\"],\n+ Name: \"flocker\",\n+ Author: \"Luke Marsden <luke@clusterhq.com>\",\n+ Org: \"ClusterHQ, Inc.\",\n+ Website: \"https://clusterhq.com/\",\n+}\n+```\n+\n+`PluginName` is a human readable short string identifying the plugin.\n+\n+`InterestedIn` is a list of extension points.","path":"docs/sources/reference/plugin-mvp.md","position":46,"original_position":46,"commit_id":"5b57ec7d2bb2d01f536de30e8ed126811c95de40","original_commit_id":"5b57ec7d2bb2d01f536de30e8ed126811c95de40","user":{"login":"lukemarsden","id":264658,"avatar_url":"https://avatars.githubusercontent.com/u/264658?v=3","gravatar_id":"","url":"https://api.github.com/users/lukemarsden","html_url":"https://github.com/lukemarsden","followers_url":"https://api.github.com/users/lukemarsden/followers","following_url":"https://api.github.com/users/lukemarsden/following{/other_user}","gists_url":"https://api.github.com/users/lukemarsden/gists{/gist_id}","starred_url":"https://api.github.com/users/lukemarsden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukemarsden/subscriptions","organizations_url":"https://api.github.com/users/lukemarsden/orgs","repos_url":"https://api.github.com/users/lukemarsden/repos","events_url":"https://api.github.com/users/lukemarsden/events{/privacy}","received_events_url":"https://api.github.com/users/lukemarsden/received_events","type":"User","site_admin":false},"body":"+1","created_at":"2015-03-20T13:50:22Z","updated_at":"2015-03-20T13:50:22Z","html_url":"https://github.com/cpuguy83/docker/pull/3#discussion_r26840122","pull_request_url":"https://api.github.com/repos/cpuguy83/docker/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/cpuguy83/docker/pulls/comments/26840122"},"html":{"href":"https://github.com/cpuguy83/docker/pull/3#discussion_r26840122"},"pull_request":{"href":"https://api.github.com/repos/cpuguy83/docker/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/cpuguy83/docker/pulls/3","id":30513649,"html_url":"https://github.com/cpuguy83/docker/pull/3","diff_url":"https://github.com/cpuguy83/docker/pull/3.diff","patch_url":"https://github.com/cpuguy83/docker/pull/3.patch","issue_url":"https://api.github.com/repos/cpuguy83/docker/issues/3","number":3,"state":"open","locked":false,"title":"Proposal: Docker plugins MVP","user":{"login":"lukemarsden","id":264658,"avatar_url":"https://avatars.githubusercontent.com/u/264658?v=3","gravatar_id":"","url":"https://api.github.com/users/lukemarsden","html_url":"https://github.com/lukemarsden","followers_url":"https://api.github.com/users/lukemarsden/followers","following_url":"https://api.github.com/users/lukemarsden/following{/other_user}","gists_url":"https://api.github.com/users/lukemarsden/gists{/gist_id}","starred_url":"https://api.github.com/users/lukemarsden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukemarsden/subscriptions","organizations_url":"https://api.github.com/users/lukemarsden/orgs","repos_url":"https://api.github.com/users/lukemarsden/repos","events_url":"https://api.github.com/users/lukemarsden/events{/privacy}","received_events_url":"https://api.github.com/users/lukemarsden/received_events","type":"User","site_admin":false},"body":"Here is a proposal for an MVP for docker plugins that unifies all the efforts in this direction.\r\n\r\nNote that there are now - as of Monday :) three types of prototypical docker plugins:\r\n\r\n* Volume plugins - using HTTP as extension mechanism\r\n* Networking plugins - using an undefined extension mechanism\r\n* API plugins - aka \"powerstrip\" - using HTTP as extension mechanism\r\n\r\nThis proposal suggests that we standardize on HTTP for an initial pass on the plugins framework.\r\nFor purely local plugins using a UNIX domain socket, this is sufficiently secure.\r\n\r\nPowerstrip has demonstrated that HTTP makes it very easy for plugin authors to get started.\r\n\r\nI suggest we could then iterate on this choice of transport once we've got some experience prototyping these plugins.\r\n\r\nMore important is getting rough consensus and running code after agreeing the message formats that need to be sent and received between docker and plugins for volumes, networking & API extensions.","created_at":"2015-03-04T22:57:03Z","updated_at":"2015-03-20T13:50:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d7879674eb9cd5d0f8545006013b990f9761aee","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cpuguy83/docker/pulls/3/commits","review_comments_url":"https://api.github.com/repos/cpuguy83/docker/pulls/3/comments","review_comment_url":"https://api.github.com/repos/cpuguy83/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cpuguy83/docker/issues/3/comments","statuses_url":"https://api.github.com/repos/cpuguy83/docker/statuses/5b57ec7d2bb2d01f536de30e8ed126811c95de40","head":{"label":"lukemarsden:docker-extensions-proposal","ref":"docker-extensions-proposal","sha":"5b57ec7d2bb2d01f536de30e8ed126811c95de40","user":{"login":"lukemarsden","id":264658,"avatar_url":"https://avatars.githubusercontent.com/u/264658?v=3","gravatar_id":"","url":"https://api.github.com/users/lukemarsden","html_url":"https://github.com/lukemarsden","followers_url":"https://api.github.com/users/lukemarsden/followers","following_url":"https://api.github.com/users/lukemarsden/following{/other_user}","gists_url":"https://api.github.com/users/lukemarsden/gists{/gist_id}","starred_url":"https://api.github.com/users/lukemarsden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukemarsden/subscriptions","organizations_url":"https://api.github.com/users/lukemarsden/orgs","repos_url":"https://api.github.com/users/lukemarsden/repos","events_url":"https://api.github.com/users/lukemarsden/events{/privacy}","received_events_url":"https://api.github.com/users/lukemarsden/received_events","type":"User","site_admin":false},"repo":{"id":19431032,"name":"docker","full_name":"lukemarsden/docker","owner":{"login":"lukemarsden","id":264658,"avatar_url":"https://avatars.githubusercontent.com/u/264658?v=3","gravatar_id":"","url":"https://api.github.com/users/lukemarsden","html_url":"https://github.com/lukemarsden","followers_url":"https://api.github.com/users/lukemarsden/followers","following_url":"https://api.github.com/users/lukemarsden/following{/other_user}","gists_url":"https://api.github.com/users/lukemarsden/gists{/gist_id}","starred_url":"https://api.github.com/users/lukemarsden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukemarsden/subscriptions","organizations_url":"https://api.github.com/users/lukemarsden/orgs","repos_url":"https://api.github.com/users/lukemarsden/repos","events_url":"https://api.github.com/users/lukemarsden/events{/privacy}","received_events_url":"https://api.github.com/users/lukemarsden/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lukemarsden/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/lukemarsden/docker","forks_url":"https://api.github.com/repos/lukemarsden/docker/forks","keys_url":"https://api.github.com/repos/lukemarsden/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lukemarsden/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lukemarsden/docker/teams","hooks_url":"https://api.github.com/repos/lukemarsden/docker/hooks","issue_events_url":"https://api.github.com/repos/lukemarsden/docker/issues/events{/number}","events_url":"https://api.github.com/repos/lukemarsden/docker/events","assignees_url":"https://api.github.com/repos/lukemarsden/docker/assignees{/user}","branches_url":"https://api.github.com/repos/lukemarsden/docker/branches{/branch}","tags_url":"https://api.github.com/repos/lukemarsden/docker/tags","blobs_url":"https://api.github.com/repos/lukemarsden/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lukemarsden/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lukemarsden/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/lukemarsden/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lukemarsden/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/lukemarsden/docker/languages","stargazers_url":"https://api.github.com/repos/lukemarsden/docker/stargazers","contributors_url":"https://api.github.com/repos/lukemarsden/docker/contributors","subscribers_url":"https://api.github.com/repos/lukemarsden/docker/subscribers","subscription_url":"https://api.github.com/repos/lukemarsden/docker/subscription","commits_url":"https://api.github.com/repos/lukemarsden/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/lukemarsden/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/lukemarsden/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/lukemarsden/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/lukemarsden/docker/contents/{+path}","compare_url":"https://api.github.com/repos/lukemarsden/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lukemarsden/docker/merges","archive_url":"https://api.github.com/repos/lukemarsden/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lukemarsden/docker/downloads","issues_url":"https://api.github.com/repos/lukemarsden/docker/issues{/number}","pulls_url":"https://api.github.com/repos/lukemarsden/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/lukemarsden/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/lukemarsden/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lukemarsden/docker/labels{/name}","releases_url":"https://api.github.com/repos/lukemarsden/docker/releases{/id}","created_at":"2014-05-04T16:52:24Z","updated_at":"2015-03-04T19:51:58Z","pushed_at":"2015-03-16T14:49:59Z","git_url":"git://github.com/lukemarsden/docker.git","ssh_url":"git@github.com:lukemarsden/docker.git","clone_url":"https://github.com/lukemarsden/docker.git","svn_url":"https://github.com/lukemarsden/docker","homepage":"http://www.docker.io","size":42695,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cpuguy83:extensions_spec","ref":"extensions_spec","sha":"8711263b3e564a7fea729f11e2cd5d39599bb92d","user":{"login":"cpuguy83","id":799078,"avatar_url":"https://avatars.githubusercontent.com/u/799078?v=3","gravatar_id":"","url":"https://api.github.com/users/cpuguy83","html_url":"https://github.com/cpuguy83","followers_url":"https://api.github.com/users/cpuguy83/followers","following_url":"https://api.github.com/users/cpuguy83/following{/other_user}","gists_url":"https://api.github.com/users/cpuguy83/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuguy83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuguy83/subscriptions","organizations_url":"https://api.github.com/users/cpuguy83/orgs","repos_url":"https://api.github.com/users/cpuguy83/repos","events_url":"https://api.github.com/users/cpuguy83/events{/privacy}","received_events_url":"https://api.github.com/users/cpuguy83/received_events","type":"User","site_admin":false},"repo":{"id":15300899,"name":"docker","full_name":"cpuguy83/docker","owner":{"login":"cpuguy83","id":799078,"avatar_url":"https://avatars.githubusercontent.com/u/799078?v=3","gravatar_id":"","url":"https://api.github.com/users/cpuguy83","html_url":"https://github.com/cpuguy83","followers_url":"https://api.github.com/users/cpuguy83/followers","following_url":"https://api.github.com/users/cpuguy83/following{/other_user}","gists_url":"https://api.github.com/users/cpuguy83/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuguy83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuguy83/subscriptions","organizations_url":"https://api.github.com/users/cpuguy83/orgs","repos_url":"https://api.github.com/users/cpuguy83/repos","events_url":"https://api.github.com/users/cpuguy83/events{/privacy}","received_events_url":"https://api.github.com/users/cpuguy83/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cpuguy83/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/cpuguy83/docker","forks_url":"https://api.github.com/repos/cpuguy83/docker/forks","keys_url":"https://api.github.com/repos/cpuguy83/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cpuguy83/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cpuguy83/docker/teams","hooks_url":"https://api.github.com/repos/cpuguy83/docker/hooks","issue_events_url":"https://api.github.com/repos/cpuguy83/docker/issues/events{/number}","events_url":"https://api.github.com/repos/cpuguy83/docker/events","assignees_url":"https://api.github.com/repos/cpuguy83/docker/assignees{/user}","branches_url":"https://api.github.com/repos/cpuguy83/docker/branches{/branch}","tags_url":"https://api.github.com/repos/cpuguy83/docker/tags","blobs_url":"https://api.github.com/repos/cpuguy83/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cpuguy83/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cpuguy83/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/cpuguy83/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cpuguy83/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/cpuguy83/docker/languages","stargazers_url":"https://api.github.com/repos/cpuguy83/docker/stargazers","contributors_url":"https://api.github.com/repos/cpuguy83/docker/contributors","subscribers_url":"https://api.github.com/repos/cpuguy83/docker/subscribers","subscription_url":"https://api.github.com/repos/cpuguy83/docker/subscription","commits_url":"https://api.github.com/repos/cpuguy83/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/cpuguy83/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/cpuguy83/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/cpuguy83/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/cpuguy83/docker/contents/{+path}","compare_url":"https://api.github.com/repos/cpuguy83/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cpuguy83/docker/merges","archive_url":"https://api.github.com/repos/cpuguy83/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cpuguy83/docker/downloads","issues_url":"https://api.github.com/repos/cpuguy83/docker/issues{/number}","pulls_url":"https://api.github.com/repos/cpuguy83/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/cpuguy83/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/cpuguy83/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cpuguy83/docker/labels{/name}","releases_url":"https://api.github.com/repos/cpuguy83/docker/releases{/id}","created_at":"2013-12-19T02:58:40Z","updated_at":"2015-03-17T18:23:46Z","pushed_at":"2015-03-19T00:57:29Z","git_url":"git://github.com/cpuguy83/docker.git","ssh_url":"git@github.com:cpuguy83/docker.git","clone_url":"https://github.com/cpuguy83/docker.git","svn_url":"https://github.com/cpuguy83/docker","homepage":"http://www.docker.io","size":49333,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cpuguy83/docker/pulls/3"},"html":{"href":"https://github.com/cpuguy83/docker/pull/3"},"issue":{"href":"https://api.github.com/repos/cpuguy83/docker/issues/3"},"comments":{"href":"https://api.github.com/repos/cpuguy83/docker/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/cpuguy83/docker/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/cpuguy83/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cpuguy83/docker/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/cpuguy83/docker/statuses/5b57ec7d2bb2d01f536de30e8ed126811c95de40"}}}}