{"action":"created","comment":{"url":"https://api.github.com/repos/glyptodon/guacamole-client/pulls/comments/22429242","id":22429242,"diff_hunk":"@@ -333,10 +315,10 @@ angular.module('client').controller('clientController', ['$scope', '$routeParams\n \n     });\n \n-    $scope.$watch('menuShown', function setKeyboardEnabled(menuShown, menuShownPreviousState) {\n+    $scope.$watch('menuShown', function menuVisibilityChanged(menuShown, menuShownPreviousState) {\n         \n         // Send clipboard data if menu is hidden\n-        if (!menuShown && menuShownPreviousState)\n+        if (!menuShown && menuShownPreviousState && angular.isString($scope.client.clipboardData))","path":"guacamole/src/main/webapp/app/client/controllers/clientController.js","position":34,"original_position":34,"commit_id":"a899a1a02f8f29eb5ee810409b3fd249d60d91a7","original_commit_id":"a899a1a02f8f29eb5ee810409b3fd249d60d91a7","user":{"login":"jmuehlner","id":4633119,"avatar_url":"https://avatars.githubusercontent.com/u/4633119?v=3","gravatar_id":"","url":"https://api.github.com/users/jmuehlner","html_url":"https://github.com/jmuehlner","followers_url":"https://api.github.com/users/jmuehlner/followers","following_url":"https://api.github.com/users/jmuehlner/following{/other_user}","gists_url":"https://api.github.com/users/jmuehlner/gists{/gist_id}","starred_url":"https://api.github.com/users/jmuehlner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmuehlner/subscriptions","organizations_url":"https://api.github.com/users/jmuehlner/orgs","repos_url":"https://api.github.com/users/jmuehlner/repos","events_url":"https://api.github.com/users/jmuehlner/events{/privacy}","received_events_url":"https://api.github.com/users/jmuehlner/received_events","type":"User","site_admin":false},"body":"Is it sometimes not a string?","created_at":"2015-01-03T03:39:23Z","updated_at":"2015-01-03T03:39:23Z","html_url":"https://github.com/glyptodon/guacamole-client/pull/41#discussion_r22429242","pull_request_url":"https://api.github.com/repos/glyptodon/guacamole-client/pulls/41","_links":{"self":{"href":"https://api.github.com/repos/glyptodon/guacamole-client/pulls/comments/22429242"},"html":{"href":"https://github.com/glyptodon/guacamole-client/pull/41#discussion_r22429242"},"pull_request":{"href":"https://api.github.com/repos/glyptodon/guacamole-client/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/glyptodon/guacamole-client/pulls/41","id":26754090,"html_url":"https://github.com/glyptodon/guacamole-client/pull/41","diff_url":"https://github.com/glyptodon/guacamole-client/pull/41.diff","patch_url":"https://github.com/glyptodon/guacamole-client/pull/41.patch","issue_url":"https://api.github.com/repos/glyptodon/guacamole-client/issues/41","number":41,"state":"open","locked":false,"title":"GUAC-963: Restore file transfer support (again)","user":{"login":"mike-jumper","id":4632905,"avatar_url":"https://avatars.githubusercontent.com/u/4632905?v=3","gravatar_id":"","url":"https://api.github.com/users/mike-jumper","html_url":"https://github.com/mike-jumper","followers_url":"https://api.github.com/users/mike-jumper/followers","following_url":"https://api.github.com/users/mike-jumper/following{/other_user}","gists_url":"https://api.github.com/users/mike-jumper/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-jumper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-jumper/subscriptions","organizations_url":"https://api.github.com/users/mike-jumper/orgs","repos_url":"https://api.github.com/users/mike-jumper/repos","events_url":"https://api.github.com/users/mike-jumper/events{/privacy}","received_events_url":"https://api.github.com/users/mike-jumper/received_events","type":"User","site_admin":false},"body":"I temporarily removed file transfer support for the sake of developing GUAC-963, but this change puts that all back.\r\n\r\nThe UI for file transfer is significantly different now:\r\n* The list of files being uploaded/downloaded is shown in the menu, not via notifications.\r\n* A new \"upload\" button has been added, allowing file uploads on platforms which lack drag/drop.\r\n* The menu will automatically show when file transfers are initiated, and the file transfer section will automatically scroll into view.","created_at":"2015-01-02T10:42:10Z","updated_at":"2015-01-03T03:39:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09ee235ad94b7a12d9b0a36766e276af3a95bf14","assignee":{"login":"jmuehlner","id":4633119,"avatar_url":"https://avatars.githubusercontent.com/u/4633119?v=3","gravatar_id":"","url":"https://api.github.com/users/jmuehlner","html_url":"https://github.com/jmuehlner","followers_url":"https://api.github.com/users/jmuehlner/followers","following_url":"https://api.github.com/users/jmuehlner/following{/other_user}","gists_url":"https://api.github.com/users/jmuehlner/gists{/gist_id}","starred_url":"https://api.github.com/users/jmuehlner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmuehlner/subscriptions","organizations_url":"https://api.github.com/users/jmuehlner/orgs","repos_url":"https://api.github.com/users/jmuehlner/repos","events_url":"https://api.github.com/users/jmuehlner/events{/privacy}","received_events_url":"https://api.github.com/users/jmuehlner/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/glyptodon/guacamole-client/pulls/41/commits","review_comments_url":"https://api.github.com/repos/glyptodon/guacamole-client/pulls/41/comments","review_comment_url":"https://api.github.com/repos/glyptodon/guacamole-client/pulls/comments/{number}","comments_url":"https://api.github.com/repos/glyptodon/guacamole-client/issues/41/comments","statuses_url":"https://api.github.com/repos/glyptodon/guacamole-client/statuses/a899a1a02f8f29eb5ee810409b3fd249d60d91a7","head":{"label":"glyptodon:managed-client","ref":"managed-client","sha":"a899a1a02f8f29eb5ee810409b3fd249d60d91a7","user":{"login":"glyptodon","id":4632960,"avatar_url":"https://avatars.githubusercontent.com/u/4632960?v=3","gravatar_id":"","url":"https://api.github.com/users/glyptodon","html_url":"https://github.com/glyptodon","followers_url":"https://api.github.com/users/glyptodon/followers","following_url":"https://api.github.com/users/glyptodon/following{/other_user}","gists_url":"https://api.github.com/users/glyptodon/gists{/gist_id}","starred_url":"https://api.github.com/users/glyptodon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glyptodon/subscriptions","organizations_url":"https://api.github.com/users/glyptodon/orgs","repos_url":"https://api.github.com/users/glyptodon/repos","events_url":"https://api.github.com/users/glyptodon/events{/privacy}","received_events_url":"https://api.github.com/users/glyptodon/received_events","type":"Organization","site_admin":false},"repo":{"id":10532531,"name":"guacamole-client","full_name":"glyptodon/guacamole-client","owner":{"login":"glyptodon","id":4632960,"avatar_url":"https://avatars.githubusercontent.com/u/4632960?v=3","gravatar_id":"","url":"https://api.github.com/users/glyptodon","html_url":"https://github.com/glyptodon","followers_url":"https://api.github.com/users/glyptodon/followers","following_url":"https://api.github.com/users/glyptodon/following{/other_user}","gists_url":"https://api.github.com/users/glyptodon/gists{/gist_id}","starred_url":"https://api.github.com/users/glyptodon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glyptodon/subscriptions","organizations_url":"https://api.github.com/users/glyptodon/orgs","repos_url":"https://api.github.com/users/glyptodon/repos","events_url":"https://api.github.com/users/glyptodon/events{/privacy}","received_events_url":"https://api.github.com/users/glyptodon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/glyptodon/guacamole-client","description":"The HTML5/JavaScript Guacamole client, its containing web application, and related components.","fork":false,"url":"https://api.github.com/repos/glyptodon/guacamole-client","forks_url":"https://api.github.com/repos/glyptodon/guacamole-client/forks","keys_url":"https://api.github.com/repos/glyptodon/guacamole-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glyptodon/guacamole-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glyptodon/guacamole-client/teams","hooks_url":"https://api.github.com/repos/glyptodon/guacamole-client/hooks","issue_events_url":"https://api.github.com/repos/glyptodon/guacamole-client/issues/events{/number}","events_url":"https://api.github.com/repos/glyptodon/guacamole-client/events","assignees_url":"https://api.github.com/repos/glyptodon/guacamole-client/assignees{/user}","branches_url":"https://api.github.com/repos/glyptodon/guacamole-client/branches{/branch}","tags_url":"https://api.github.com/repos/glyptodon/guacamole-client/tags","blobs_url":"https://api.github.com/repos/glyptodon/guacamole-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glyptodon/guacamole-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glyptodon/guacamole-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/glyptodon/guacamole-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glyptodon/guacamole-client/statuses/{sha}","languages_url":"https://api.github.com/repos/glyptodon/guacamole-client/languages","stargazers_url":"https://api.github.com/repos/glyptodon/guacamole-client/stargazers","contributors_url":"https://api.github.com/repos/glyptodon/guacamole-client/contributors","subscribers_url":"https://api.github.com/repos/glyptodon/guacamole-client/subscribers","subscription_url":"https://api.github.com/repos/glyptodon/guacamole-client/subscription","commits_url":"https://api.github.com/repos/glyptodon/guacamole-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/glyptodon/guacamole-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/glyptodon/guacamole-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/glyptodon/guacamole-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/glyptodon/guacamole-client/contents/{+path}","compare_url":"https://api.github.com/repos/glyptodon/guacamole-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glyptodon/guacamole-client/merges","archive_url":"https://api.github.com/repos/glyptodon/guacamole-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glyptodon/guacamole-client/downloads","issues_url":"https://api.github.com/repos/glyptodon/guacamole-client/issues{/number}","pulls_url":"https://api.github.com/repos/glyptodon/guacamole-client/pulls{/number}","milestones_url":"https://api.github.com/repos/glyptodon/guacamole-client/milestones{/number}","notifications_url":"https://api.github.com/repos/glyptodon/guacamole-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glyptodon/guacamole-client/labels{/name}","releases_url":"https://api.github.com/repos/glyptodon/guacamole-client/releases{/id}","created_at":"2013-06-06T17:45:24Z","updated_at":"2014-12-31T18:51:42Z","pushed_at":"2015-01-02T22:18:54Z","git_url":"git://github.com/glyptodon/guacamole-client.git","ssh_url":"git@github.com:glyptodon/guacamole-client.git","clone_url":"https://github.com/glyptodon/guacamole-client.git","svn_url":"https://github.com/glyptodon/guacamole-client","homepage":"http://guac-dev.org/","size":9613,"stargazers_count":431,"watchers_count":431,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":2,"forks":70,"open_issues":2,"watchers":431,"default_branch":"master"}},"base":{"label":"glyptodon:master","ref":"master","sha":"19db4523f61e5cce564ac4b8e242a961f139bb7e","user":{"login":"glyptodon","id":4632960,"avatar_url":"https://avatars.githubusercontent.com/u/4632960?v=3","gravatar_id":"","url":"https://api.github.com/users/glyptodon","html_url":"https://github.com/glyptodon","followers_url":"https://api.github.com/users/glyptodon/followers","following_url":"https://api.github.com/users/glyptodon/following{/other_user}","gists_url":"https://api.github.com/users/glyptodon/gists{/gist_id}","starred_url":"https://api.github.com/users/glyptodon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glyptodon/subscriptions","organizations_url":"https://api.github.com/users/glyptodon/orgs","repos_url":"https://api.github.com/users/glyptodon/repos","events_url":"https://api.github.com/users/glyptodon/events{/privacy}","received_events_url":"https://api.github.com/users/glyptodon/received_events","type":"Organization","site_admin":false},"repo":{"id":10532531,"name":"guacamole-client","full_name":"glyptodon/guacamole-client","owner":{"login":"glyptodon","id":4632960,"avatar_url":"https://avatars.githubusercontent.com/u/4632960?v=3","gravatar_id":"","url":"https://api.github.com/users/glyptodon","html_url":"https://github.com/glyptodon","followers_url":"https://api.github.com/users/glyptodon/followers","following_url":"https://api.github.com/users/glyptodon/following{/other_user}","gists_url":"https://api.github.com/users/glyptodon/gists{/gist_id}","starred_url":"https://api.github.com/users/glyptodon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glyptodon/subscriptions","organizations_url":"https://api.github.com/users/glyptodon/orgs","repos_url":"https://api.github.com/users/glyptodon/repos","events_url":"https://api.github.com/users/glyptodon/events{/privacy}","received_events_url":"https://api.github.com/users/glyptodon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/glyptodon/guacamole-client","description":"The HTML5/JavaScript Guacamole client, its containing web application, and related components.","fork":false,"url":"https://api.github.com/repos/glyptodon/guacamole-client","forks_url":"https://api.github.com/repos/glyptodon/guacamole-client/forks","keys_url":"https://api.github.com/repos/glyptodon/guacamole-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glyptodon/guacamole-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glyptodon/guacamole-client/teams","hooks_url":"https://api.github.com/repos/glyptodon/guacamole-client/hooks","issue_events_url":"https://api.github.com/repos/glyptodon/guacamole-client/issues/events{/number}","events_url":"https://api.github.com/repos/glyptodon/guacamole-client/events","assignees_url":"https://api.github.com/repos/glyptodon/guacamole-client/assignees{/user}","branches_url":"https://api.github.com/repos/glyptodon/guacamole-client/branches{/branch}","tags_url":"https://api.github.com/repos/glyptodon/guacamole-client/tags","blobs_url":"https://api.github.com/repos/glyptodon/guacamole-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glyptodon/guacamole-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glyptodon/guacamole-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/glyptodon/guacamole-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glyptodon/guacamole-client/statuses/{sha}","languages_url":"https://api.github.com/repos/glyptodon/guacamole-client/languages","stargazers_url":"https://api.github.com/repos/glyptodon/guacamole-client/stargazers","contributors_url":"https://api.github.com/repos/glyptodon/guacamole-client/contributors","subscribers_url":"https://api.github.com/repos/glyptodon/guacamole-client/subscribers","subscription_url":"https://api.github.com/repos/glyptodon/guacamole-client/subscription","commits_url":"https://api.github.com/repos/glyptodon/guacamole-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/glyptodon/guacamole-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/glyptodon/guacamole-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/glyptodon/guacamole-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/glyptodon/guacamole-client/contents/{+path}","compare_url":"https://api.github.com/repos/glyptodon/guacamole-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glyptodon/guacamole-client/merges","archive_url":"https://api.github.com/repos/glyptodon/guacamole-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glyptodon/guacamole-client/downloads","issues_url":"https://api.github.com/repos/glyptodon/guacamole-client/issues{/number}","pulls_url":"https://api.github.com/repos/glyptodon/guacamole-client/pulls{/number}","milestones_url":"https://api.github.com/repos/glyptodon/guacamole-client/milestones{/number}","notifications_url":"https://api.github.com/repos/glyptodon/guacamole-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glyptodon/guacamole-client/labels{/name}","releases_url":"https://api.github.com/repos/glyptodon/guacamole-client/releases{/id}","created_at":"2013-06-06T17:45:24Z","updated_at":"2014-12-31T18:51:42Z","pushed_at":"2015-01-02T22:18:54Z","git_url":"git://github.com/glyptodon/guacamole-client.git","ssh_url":"git@github.com:glyptodon/guacamole-client.git","clone_url":"https://github.com/glyptodon/guacamole-client.git","svn_url":"https://github.com/glyptodon/guacamole-client","homepage":"http://guac-dev.org/","size":9613,"stargazers_count":431,"watchers_count":431,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":2,"forks":70,"open_issues":2,"watchers":431,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/glyptodon/guacamole-client/pulls/41"},"html":{"href":"https://github.com/glyptodon/guacamole-client/pull/41"},"issue":{"href":"https://api.github.com/repos/glyptodon/guacamole-client/issues/41"},"comments":{"href":"https://api.github.com/repos/glyptodon/guacamole-client/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/glyptodon/guacamole-client/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/glyptodon/guacamole-client/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/glyptodon/guacamole-client/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/glyptodon/guacamole-client/statuses/a899a1a02f8f29eb5ee810409b3fd249d60d91a7"}}}}