{"action":"created","comment":{"url":"https://api.github.com/repos/wdas/ptex/pulls/comments/40632516","id":40632516,"diff_hunk":"@@ -21,3 +21,25 @@ add_library(Ptex_dynamic SHARED ${SRCS})\n set_target_properties(Ptex_dynamic PROPERTIES OUTPUT_NAME Ptex)\n \n target_link_libraries(Ptex_dynamic ${CMAKE_THREAD_LIBS_INIT} ${ZLIB_LIBRARIES})\n+\n+if ( PTEX_LIB_DIR )\n+  SET ( INSTALL_LIBRARY_DIR ${PTEX_LIB_DIR} )\n+else ()\n+  SET ( INSTALL_LIBRARY_DIR lib )\n+endif ()\n+\n+# installation\n+install ( TARGETS\n+  Ptex_static\n+  Ptex_dynamic\n+  DESTINATION\n+  ${INSTALL_LIBRARY_DIR}\n+  )\n+install ( FILES\n+  PtexHalf.h\n+  PtexInt.h\n+  Ptexture.h\n+  PtexUtils.h\n+  DESTINATION\n+  include\n+  )","path":"src/ptex/CMakeLists.txt","position":25,"original_position":25,"commit_id":"b58cefb155ecefaac8f037ce1ca32af173c0787d","original_commit_id":"b58cefb155ecefaac8f037ce1ca32af173c0787d","user":{"login":"davvid","id":13196,"avatar_url":"https://avatars.githubusercontent.com/u/13196?v=3","gravatar_id":"","url":"https://api.github.com/users/davvid","html_url":"https://github.com/davvid","followers_url":"https://api.github.com/users/davvid/followers","following_url":"https://api.github.com/users/davvid/following{/other_user}","gists_url":"https://api.github.com/users/davvid/gists{/gist_id}","starred_url":"https://api.github.com/users/davvid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davvid/subscriptions","organizations_url":"https://api.github.com/users/davvid/orgs","repos_url":"https://api.github.com/users/davvid/repos","events_url":"https://api.github.com/users/davvid/events{/privacy}","received_events_url":"https://api.github.com/users/davvid/received_events","type":"User","site_admin":false},"body":"Let's standardize on 4-space indents and no whitespace around parens for functions (e.g. only leading space before `if (expr)` but no whitespace when saying `install(FILES foo bar baz)`.\r\n\r\nDESTINATION part can all go on one line, e.g. \r\n\r\n```\r\ninstall(FILES\r\n    PtexHalf.h\r\n    PtexInt.h\r\n    Ptexture.h\r\n    PtexUtils.h\r\n    DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})\r\n```","created_at":"2015-09-29T03:49:56Z","updated_at":"2015-09-29T03:49:56Z","html_url":"https://github.com/wdas/ptex/pull/11#discussion_r40632516","pull_request_url":"https://api.github.com/repos/wdas/ptex/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/wdas/ptex/pulls/comments/40632516"},"html":{"href":"https://github.com/wdas/ptex/pull/11#discussion_r40632516"},"pull_request":{"href":"https://api.github.com/repos/wdas/ptex/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/wdas/ptex/pulls/11","id":27987681,"html_url":"https://github.com/wdas/ptex/pull/11","diff_url":"https://github.com/wdas/ptex/pull/11.diff","patch_url":"https://github.com/wdas/ptex/pull/11.patch","issue_url":"https://api.github.com/repos/wdas/ptex/issues/11","number":11,"state":"open","locked":false,"title":"Add installation target for CMake configuration","user":{"login":"nyue","id":486172,"avatar_url":"https://avatars.githubusercontent.com/u/486172?v=3","gravatar_id":"","url":"https://api.github.com/users/nyue","html_url":"https://github.com/nyue","followers_url":"https://api.github.com/users/nyue/followers","following_url":"https://api.github.com/users/nyue/following{/other_user}","gists_url":"https://api.github.com/users/nyue/gists{/gist_id}","starred_url":"https://api.github.com/users/nyue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyue/subscriptions","organizations_url":"https://api.github.com/users/nyue/orgs","repos_url":"https://api.github.com/users/nyue/repos","events_url":"https://api.github.com/users/nyue/events{/privacy}","received_events_url":"https://api.github.com/users/nyue/received_events","type":"User","site_admin":false},"body":"Add install target for the following\r\n(1) Libraries\r\n(2) Headers\r\n(3) Binary application\r\n(4) Doxygen generated html directory content\r\n","created_at":"2015-01-25T05:04:20Z","updated_at":"2015-09-29T03:49:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab3dc2f9dd8e9cb2c097579043a289480496ae51","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wdas/ptex/pulls/11/commits","review_comments_url":"https://api.github.com/repos/wdas/ptex/pulls/11/comments","review_comment_url":"https://api.github.com/repos/wdas/ptex/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wdas/ptex/issues/11/comments","statuses_url":"https://api.github.com/repos/wdas/ptex/statuses/b58cefb155ecefaac8f037ce1ca32af173c0787d","head":{"label":"nyue:master","ref":"master","sha":"b58cefb155ecefaac8f037ce1ca32af173c0787d","user":{"login":"nyue","id":486172,"avatar_url":"https://avatars.githubusercontent.com/u/486172?v=3","gravatar_id":"","url":"https://api.github.com/users/nyue","html_url":"https://github.com/nyue","followers_url":"https://api.github.com/users/nyue/followers","following_url":"https://api.github.com/users/nyue/following{/other_user}","gists_url":"https://api.github.com/users/nyue/gists{/gist_id}","starred_url":"https://api.github.com/users/nyue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyue/subscriptions","organizations_url":"https://api.github.com/users/nyue/orgs","repos_url":"https://api.github.com/users/nyue/repos","events_url":"https://api.github.com/users/nyue/events{/privacy}","received_events_url":"https://api.github.com/users/nyue/received_events","type":"User","site_admin":false},"repo":{"id":3684358,"name":"ptex","full_name":"nyue/ptex","owner":{"login":"nyue","id":486172,"avatar_url":"https://avatars.githubusercontent.com/u/486172?v=3","gravatar_id":"","url":"https://api.github.com/users/nyue","html_url":"https://github.com/nyue","followers_url":"https://api.github.com/users/nyue/followers","following_url":"https://api.github.com/users/nyue/following{/other_user}","gists_url":"https://api.github.com/users/nyue/gists{/gist_id}","starred_url":"https://api.github.com/users/nyue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyue/subscriptions","organizations_url":"https://api.github.com/users/nyue/orgs","repos_url":"https://api.github.com/users/nyue/repos","events_url":"https://api.github.com/users/nyue/events{/privacy}","received_events_url":"https://api.github.com/users/nyue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nyue/ptex","description":"Per-Face Texture Mapping for Production Rendering","fork":true,"url":"https://api.github.com/repos/nyue/ptex","forks_url":"https://api.github.com/repos/nyue/ptex/forks","keys_url":"https://api.github.com/repos/nyue/ptex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nyue/ptex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nyue/ptex/teams","hooks_url":"https://api.github.com/repos/nyue/ptex/hooks","issue_events_url":"https://api.github.com/repos/nyue/ptex/issues/events{/number}","events_url":"https://api.github.com/repos/nyue/ptex/events","assignees_url":"https://api.github.com/repos/nyue/ptex/assignees{/user}","branches_url":"https://api.github.com/repos/nyue/ptex/branches{/branch}","tags_url":"https://api.github.com/repos/nyue/ptex/tags","blobs_url":"https://api.github.com/repos/nyue/ptex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nyue/ptex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nyue/ptex/git/refs{/sha}","trees_url":"https://api.github.com/repos/nyue/ptex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nyue/ptex/statuses/{sha}","languages_url":"https://api.github.com/repos/nyue/ptex/languages","stargazers_url":"https://api.github.com/repos/nyue/ptex/stargazers","contributors_url":"https://api.github.com/repos/nyue/ptex/contributors","subscribers_url":"https://api.github.com/repos/nyue/ptex/subscribers","subscription_url":"https://api.github.com/repos/nyue/ptex/subscription","commits_url":"https://api.github.com/repos/nyue/ptex/commits{/sha}","git_commits_url":"https://api.github.com/repos/nyue/ptex/git/commits{/sha}","comments_url":"https://api.github.com/repos/nyue/ptex/comments{/number}","issue_comment_url":"https://api.github.com/repos/nyue/ptex/issues/comments{/number}","contents_url":"https://api.github.com/repos/nyue/ptex/contents/{+path}","compare_url":"https://api.github.com/repos/nyue/ptex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nyue/ptex/merges","archive_url":"https://api.github.com/repos/nyue/ptex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nyue/ptex/downloads","issues_url":"https://api.github.com/repos/nyue/ptex/issues{/number}","pulls_url":"https://api.github.com/repos/nyue/ptex/pulls{/number}","milestones_url":"https://api.github.com/repos/nyue/ptex/milestones{/number}","notifications_url":"https://api.github.com/repos/nyue/ptex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nyue/ptex/labels{/name}","releases_url":"https://api.github.com/repos/nyue/ptex/releases{/id}","created_at":"2012-03-11T03:16:44Z","updated_at":"2015-01-26T01:33:05Z","pushed_at":"2015-01-26T01:33:05Z","git_url":"git://github.com/nyue/ptex.git","ssh_url":"git@github.com:nyue/ptex.git","clone_url":"https://github.com/nyue/ptex.git","svn_url":"https://github.com/nyue/ptex","homepage":"ptex.us/","size":28914,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"wdas:master","ref":"master","sha":"fce55ac061ef9c7974897fc2736a1ba12d35bc68","user":{"login":"wdas","id":125487,"avatar_url":"https://avatars.githubusercontent.com/u/125487?v=3","gravatar_id":"","url":"https://api.github.com/users/wdas","html_url":"https://github.com/wdas","followers_url":"https://api.github.com/users/wdas/followers","following_url":"https://api.github.com/users/wdas/following{/other_user}","gists_url":"https://api.github.com/users/wdas/gists{/gist_id}","starred_url":"https://api.github.com/users/wdas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wdas/subscriptions","organizations_url":"https://api.github.com/users/wdas/orgs","repos_url":"https://api.github.com/users/wdas/repos","events_url":"https://api.github.com/users/wdas/events{/privacy}","received_events_url":"https://api.github.com/users/wdas/received_events","type":"Organization","site_admin":false},"repo":{"id":331488,"name":"ptex","full_name":"wdas/ptex","owner":{"login":"wdas","id":125487,"avatar_url":"https://avatars.githubusercontent.com/u/125487?v=3","gravatar_id":"","url":"https://api.github.com/users/wdas","html_url":"https://github.com/wdas","followers_url":"https://api.github.com/users/wdas/followers","following_url":"https://api.github.com/users/wdas/following{/other_user}","gists_url":"https://api.github.com/users/wdas/gists{/gist_id}","starred_url":"https://api.github.com/users/wdas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wdas/subscriptions","organizations_url":"https://api.github.com/users/wdas/orgs","repos_url":"https://api.github.com/users/wdas/repos","events_url":"https://api.github.com/users/wdas/events{/privacy}","received_events_url":"https://api.github.com/users/wdas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wdas/ptex","description":"Per-Face Texture Mapping for Production Rendering","fork":false,"url":"https://api.github.com/repos/wdas/ptex","forks_url":"https://api.github.com/repos/wdas/ptex/forks","keys_url":"https://api.github.com/repos/wdas/ptex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wdas/ptex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wdas/ptex/teams","hooks_url":"https://api.github.com/repos/wdas/ptex/hooks","issue_events_url":"https://api.github.com/repos/wdas/ptex/issues/events{/number}","events_url":"https://api.github.com/repos/wdas/ptex/events","assignees_url":"https://api.github.com/repos/wdas/ptex/assignees{/user}","branches_url":"https://api.github.com/repos/wdas/ptex/branches{/branch}","tags_url":"https://api.github.com/repos/wdas/ptex/tags","blobs_url":"https://api.github.com/repos/wdas/ptex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wdas/ptex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wdas/ptex/git/refs{/sha}","trees_url":"https://api.github.com/repos/wdas/ptex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wdas/ptex/statuses/{sha}","languages_url":"https://api.github.com/repos/wdas/ptex/languages","stargazers_url":"https://api.github.com/repos/wdas/ptex/stargazers","contributors_url":"https://api.github.com/repos/wdas/ptex/contributors","subscribers_url":"https://api.github.com/repos/wdas/ptex/subscribers","subscription_url":"https://api.github.com/repos/wdas/ptex/subscription","commits_url":"https://api.github.com/repos/wdas/ptex/commits{/sha}","git_commits_url":"https://api.github.com/repos/wdas/ptex/git/commits{/sha}","comments_url":"https://api.github.com/repos/wdas/ptex/comments{/number}","issue_comment_url":"https://api.github.com/repos/wdas/ptex/issues/comments{/number}","contents_url":"https://api.github.com/repos/wdas/ptex/contents/{+path}","compare_url":"https://api.github.com/repos/wdas/ptex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wdas/ptex/merges","archive_url":"https://api.github.com/repos/wdas/ptex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wdas/ptex/downloads","issues_url":"https://api.github.com/repos/wdas/ptex/issues{/number}","pulls_url":"https://api.github.com/repos/wdas/ptex/pulls{/number}","milestones_url":"https://api.github.com/repos/wdas/ptex/milestones{/number}","notifications_url":"https://api.github.com/repos/wdas/ptex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wdas/ptex/labels{/name}","releases_url":"https://api.github.com/repos/wdas/ptex/releases{/id}","created_at":"2009-10-08T22:25:35Z","updated_at":"2015-09-25T15:32:35Z","pushed_at":"2015-05-14T19:11:41Z","git_url":"git://github.com/wdas/ptex.git","ssh_url":"git@github.com:wdas/ptex.git","clone_url":"https://github.com/wdas/ptex.git","svn_url":"https://github.com/wdas/ptex","homepage":"ptex.us/","size":62931,"stargazers_count":223,"watchers_count":223,"language":"C","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":50,"mirror_url":null,"open_issues_count":3,"forks":50,"open_issues":3,"watchers":223,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wdas/ptex/pulls/11"},"html":{"href":"https://github.com/wdas/ptex/pull/11"},"issue":{"href":"https://api.github.com/repos/wdas/ptex/issues/11"},"comments":{"href":"https://api.github.com/repos/wdas/ptex/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/wdas/ptex/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/wdas/ptex/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wdas/ptex/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/wdas/ptex/statuses/b58cefb155ecefaac8f037ce1ca32af173c0787d"}}}}