{"action":"closed","number":5305,"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5305","id":45801008,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/5305","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/5305.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/5305.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5305","number":5305,"state":"closed","locked":false,"title":"[MRG] Hotfix for _criterion.pyx","user":{"login":"jmschrei","id":3916816,"avatar_url":"https://avatars.githubusercontent.com/u/3916816?v=3","gravatar_id":"","url":"https://api.github.com/users/jmschrei","html_url":"https://github.com/jmschrei","followers_url":"https://api.github.com/users/jmschrei/followers","following_url":"https://api.github.com/users/jmschrei/following{/other_user}","gists_url":"https://api.github.com/users/jmschrei/gists{/gist_id}","starred_url":"https://api.github.com/users/jmschrei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmschrei/subscriptions","organizations_url":"https://api.github.com/users/jmschrei/orgs","repos_url":"https://api.github.com/users/jmschrei/repos","events_url":"https://api.github.com/users/jmschrei/events{/privacy}","received_events_url":"https://api.github.com/users/jmschrei/received_events","type":"User","site_admin":false},"body":"I accidentally included a few variable name errors in the last round of review for #5278 because I did not recompile it before running unit tests. This is a patch to fix solely those issues, as noticed also in #5304.\r\n\r\n@agramfort @GaelVaroquaux @glouppe @arjoly ","created_at":"2015-09-23T16:29:55Z","updated_at":"2015-09-23T18:36:17Z","closed_at":"2015-09-23T18:36:17Z","merged_at":"2015-09-23T18:36:17Z","merge_commit_sha":"d3b5bb7700c54a400a1559195ba4be79e8713a6d","assignee":null,"milestone":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones/15","html_url":"https://github.com/scikit-learn/scikit-learn/milestones/0.17","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones/15/labels","id":995666,"number":15,"title":"0.17","description":"","creator":{"login":"amueller","id":449558,"avatar_url":"https://avatars.githubusercontent.com/u/449558?v=3","gravatar_id":"","url":"https://api.github.com/users/amueller","html_url":"https://github.com/amueller","followers_url":"https://api.github.com/users/amueller/followers","following_url":"https://api.github.com/users/amueller/following{/other_user}","gists_url":"https://api.github.com/users/amueller/gists{/gist_id}","starred_url":"https://api.github.com/users/amueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amueller/subscriptions","organizations_url":"https://api.github.com/users/amueller/orgs","repos_url":"https://api.github.com/users/amueller/repos","events_url":"https://api.github.com/users/amueller/events{/privacy}","received_events_url":"https://api.github.com/users/amueller/received_events","type":"User","site_admin":false},"open_issues":34,"closed_issues":39,"state":"open","created_at":"2015-02-25T18:59:07Z","updated_at":"2015-09-23T18:36:17Z","due_on":"2015-09-20T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5305/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5305/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5305/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/798aeaf10bc9a3e84c747dd2db241ca28b7c8c2a","head":{"label":"jmschrei:criterion_patch","ref":"criterion_patch","sha":"798aeaf10bc9a3e84c747dd2db241ca28b7c8c2a","user":{"login":"jmschrei","id":3916816,"avatar_url":"https://avatars.githubusercontent.com/u/3916816?v=3","gravatar_id":"","url":"https://api.github.com/users/jmschrei","html_url":"https://github.com/jmschrei","followers_url":"https://api.github.com/users/jmschrei/followers","following_url":"https://api.github.com/users/jmschrei/following{/other_user}","gists_url":"https://api.github.com/users/jmschrei/gists{/gist_id}","starred_url":"https://api.github.com/users/jmschrei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmschrei/subscriptions","organizations_url":"https://api.github.com/users/jmschrei/orgs","repos_url":"https://api.github.com/users/jmschrei/repos","events_url":"https://api.github.com/users/jmschrei/events{/privacy}","received_events_url":"https://api.github.com/users/jmschrei/received_events","type":"User","site_admin":false},"repo":{"id":37904379,"name":"scikit-learn","full_name":"jmschrei/scikit-learn","owner":{"login":"jmschrei","id":3916816,"avatar_url":"https://avatars.githubusercontent.com/u/3916816?v=3","gravatar_id":"","url":"https://api.github.com/users/jmschrei","html_url":"https://github.com/jmschrei","followers_url":"https://api.github.com/users/jmschrei/followers","following_url":"https://api.github.com/users/jmschrei/following{/other_user}","gists_url":"https://api.github.com/users/jmschrei/gists{/gist_id}","starred_url":"https://api.github.com/users/jmschrei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmschrei/subscriptions","organizations_url":"https://api.github.com/users/jmschrei/orgs","repos_url":"https://api.github.com/users/jmschrei/repos","events_url":"https://api.github.com/users/jmschrei/events{/privacy}","received_events_url":"https://api.github.com/users/jmschrei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmschrei/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/jmschrei/scikit-learn","forks_url":"https://api.github.com/repos/jmschrei/scikit-learn/forks","keys_url":"https://api.github.com/repos/jmschrei/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmschrei/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmschrei/scikit-learn/teams","hooks_url":"https://api.github.com/repos/jmschrei/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/jmschrei/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/jmschrei/scikit-learn/events","assignees_url":"https://api.github.com/repos/jmschrei/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/jmschrei/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/jmschrei/scikit-learn/tags","blobs_url":"https://api.github.com/repos/jmschrei/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmschrei/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmschrei/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmschrei/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmschrei/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/jmschrei/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/jmschrei/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/jmschrei/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/jmschrei/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/jmschrei/scikit-learn/subscription","commits_url":"https://api.github.com/repos/jmschrei/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmschrei/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmschrei/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmschrei/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmschrei/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/jmschrei/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmschrei/scikit-learn/merges","archive_url":"https://api.github.com/repos/jmschrei/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmschrei/scikit-learn/downloads","issues_url":"https://api.github.com/repos/jmschrei/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/jmschrei/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/jmschrei/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/jmschrei/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmschrei/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/jmschrei/scikit-learn/releases{/id}","created_at":"2015-06-23T07:38:19Z","updated_at":"2015-06-23T07:38:27Z","pushed_at":"2015-09-23T18:20:42Z","git_url":"git://github.com/jmschrei/scikit-learn.git","ssh_url":"git@github.com:jmschrei/scikit-learn.git","clone_url":"https://github.com/jmschrei/scikit-learn.git","svn_url":"https://github.com/jmschrei/scikit-learn","homepage":"http://scikit-learn.org","size":71937,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"218e255a87a62053396cb8e848bcb60832f1cce9","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","created_at":"2010-08-17T09:43:38Z","updated_at":"2015-09-23T18:17:07Z","pushed_at":"2015-09-23T18:36:17Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":133866,"stargazers_count":7608,"watchers_count":7608,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4496,"mirror_url":null,"open_issues_count":752,"forks":4496,"open_issues":752,"watchers":7608,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5305"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/5305"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5305"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5305/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5305/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5305/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/798aeaf10bc9a3e84c747dd2db241ca28b7c8c2a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"glouppe","id":477771,"avatar_url":"https://avatars.githubusercontent.com/u/477771?v=3","gravatar_id":"","url":"https://api.github.com/users/glouppe","html_url":"https://github.com/glouppe","followers_url":"https://api.github.com/users/glouppe/followers","following_url":"https://api.github.com/users/glouppe/following{/other_user}","gists_url":"https://api.github.com/users/glouppe/gists{/gist_id}","starred_url":"https://api.github.com/users/glouppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glouppe/subscriptions","organizations_url":"https://api.github.com/users/glouppe/orgs","repos_url":"https://api.github.com/users/glouppe/repos","events_url":"https://api.github.com/users/glouppe/events{/privacy}","received_events_url":"https://api.github.com/users/glouppe/received_events","type":"User","site_admin":false},"comments":7,"review_comments":4,"commits":1,"additions":2084,"deletions":1969,"changed_files":5}}