{"action":"closed","number":8522,"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/8522","id":33871615,"html_url":"https://github.com/laravel/framework/pull/8522","diff_url":"https://github.com/laravel/framework/pull/8522.diff","patch_url":"https://github.com/laravel/framework/pull/8522.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/8522","number":8522,"state":"closed","locked":false,"title":"fix thrown exception if file is not existing","user":{"login":"xarem","id":647483,"avatar_url":"https://avatars.githubusercontent.com/u/647483?v=3","gravatar_id":"","url":"https://api.github.com/users/xarem","html_url":"https://github.com/xarem","followers_url":"https://api.github.com/users/xarem/followers","following_url":"https://api.github.com/users/xarem/following{/other_user}","gists_url":"https://api.github.com/users/xarem/gists{/gist_id}","starred_url":"https://api.github.com/users/xarem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xarem/subscriptions","organizations_url":"https://api.github.com/users/xarem/orgs","repos_url":"https://api.github.com/users/xarem/repos","events_url":"https://api.github.com/users/xarem/events{/privacy}","received_events_url":"https://api.github.com/users/xarem/received_events","type":"User","site_admin":false},"body":"`unlink` throws an `\\ErrorException` if the file, we want to delete, is not existing. This patch catches the exception and sets `$success` to `false`.\r\n\r\nIf the file is a session file (f.ex. `storage/framework/session/HASH`), this ends in an thrown exception in the login process.","created_at":"2015-04-22T15:44:29Z","updated_at":"2015-04-23T13:52:55Z","closed_at":"2015-04-23T13:52:55Z","merged_at":"2015-04-23T13:52:55Z","merge_commit_sha":"9c0a23182c91302d0264bea0c910e4b4930b762f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/8522/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/8522/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/8522/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/d4a3c3cb1be70bc36f80bd1d6262e308af78ee46","head":{"label":"xarem:fix-filesystem","ref":"fix-filesystem","sha":"d4a3c3cb1be70bc36f80bd1d6262e308af78ee46","user":{"login":"xarem","id":647483,"avatar_url":"https://avatars.githubusercontent.com/u/647483?v=3","gravatar_id":"","url":"https://api.github.com/users/xarem","html_url":"https://github.com/xarem","followers_url":"https://api.github.com/users/xarem/followers","following_url":"https://api.github.com/users/xarem/following{/other_user}","gists_url":"https://api.github.com/users/xarem/gists{/gist_id}","starred_url":"https://api.github.com/users/xarem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xarem/subscriptions","organizations_url":"https://api.github.com/users/xarem/orgs","repos_url":"https://api.github.com/users/xarem/repos","events_url":"https://api.github.com/users/xarem/events{/privacy}","received_events_url":"https://api.github.com/users/xarem/received_events","type":"User","site_admin":false},"repo":{"id":34387802,"name":"framework","full_name":"xarem/framework","owner":{"login":"xarem","id":647483,"avatar_url":"https://avatars.githubusercontent.com/u/647483?v=3","gravatar_id":"","url":"https://api.github.com/users/xarem","html_url":"https://github.com/xarem","followers_url":"https://api.github.com/users/xarem/followers","following_url":"https://api.github.com/users/xarem/following{/other_user}","gists_url":"https://api.github.com/users/xarem/gists{/gist_id}","starred_url":"https://api.github.com/users/xarem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xarem/subscriptions","organizations_url":"https://api.github.com/users/xarem/orgs","repos_url":"https://api.github.com/users/xarem/repos","events_url":"https://api.github.com/users/xarem/events{/privacy}","received_events_url":"https://api.github.com/users/xarem/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xarem/framework","description":"","fork":true,"url":"https://api.github.com/repos/xarem/framework","forks_url":"https://api.github.com/repos/xarem/framework/forks","keys_url":"https://api.github.com/repos/xarem/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xarem/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xarem/framework/teams","hooks_url":"https://api.github.com/repos/xarem/framework/hooks","issue_events_url":"https://api.github.com/repos/xarem/framework/issues/events{/number}","events_url":"https://api.github.com/repos/xarem/framework/events","assignees_url":"https://api.github.com/repos/xarem/framework/assignees{/user}","branches_url":"https://api.github.com/repos/xarem/framework/branches{/branch}","tags_url":"https://api.github.com/repos/xarem/framework/tags","blobs_url":"https://api.github.com/repos/xarem/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xarem/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xarem/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/xarem/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xarem/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/xarem/framework/languages","stargazers_url":"https://api.github.com/repos/xarem/framework/stargazers","contributors_url":"https://api.github.com/repos/xarem/framework/contributors","subscribers_url":"https://api.github.com/repos/xarem/framework/subscribers","subscription_url":"https://api.github.com/repos/xarem/framework/subscription","commits_url":"https://api.github.com/repos/xarem/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/xarem/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/xarem/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/xarem/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/xarem/framework/contents/{+path}","compare_url":"https://api.github.com/repos/xarem/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xarem/framework/merges","archive_url":"https://api.github.com/repos/xarem/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xarem/framework/downloads","issues_url":"https://api.github.com/repos/xarem/framework/issues{/number}","pulls_url":"https://api.github.com/repos/xarem/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/xarem/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/xarem/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xarem/framework/labels{/name}","releases_url":"https://api.github.com/repos/xarem/framework/releases{/id}","created_at":"2015-04-22T12:00:08Z","updated_at":"2015-04-22T12:03:13Z","pushed_at":"2015-04-22T15:40:55Z","git_url":"git://github.com/xarem/framework.git","ssh_url":"git@github.com:xarem/framework.git","clone_url":"https://github.com/xarem/framework.git","svn_url":"https://github.com/xarem/framework","homepage":"http://laravel.com","size":64398,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.0"}},"base":{"label":"laravel:5.0","ref":"5.0","sha":"06a09429322cf53e5bd4587db1060f02a291562e","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"name":"framework","full_name":"laravel/framework","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/framework","description":"","fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","created_at":"2013-01-10T21:27:28Z","updated_at":"2015-04-23T13:52:54Z","pushed_at":"2015-04-23T13:52:54Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"http://laravel.com","size":64398,"stargazers_count":3477,"watchers_count":3477,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1906,"mirror_url":null,"open_issues_count":98,"forks":1906,"open_issues":98,"watchers":3477,"default_branch":"5.0"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/8522"},"html":{"href":"https://github.com/laravel/framework/pull/8522"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/8522"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/8522/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/8522/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/8522/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/d4a3c3cb1be70bc36f80bd1d6262e308af78ee46"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"taylorotwell","id":463230,"avatar_url":"https://avatars.githubusercontent.com/u/463230?v=3","gravatar_id":"","url":"https://api.github.com/users/taylorotwell","html_url":"https://github.com/taylorotwell","followers_url":"https://api.github.com/users/taylorotwell/followers","following_url":"https://api.github.com/users/taylorotwell/following{/other_user}","gists_url":"https://api.github.com/users/taylorotwell/gists{/gist_id}","starred_url":"https://api.github.com/users/taylorotwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taylorotwell/subscriptions","organizations_url":"https://api.github.com/users/taylorotwell/orgs","repos_url":"https://api.github.com/users/taylorotwell/repos","events_url":"https://api.github.com/users/taylorotwell/events{/privacy}","received_events_url":"https://api.github.com/users/taylorotwell/received_events","type":"User","site_admin":false},"comments":3,"review_comments":3,"commits":2,"additions":8,"deletions":1,"changed_files":1}}