{"action":"created","issue":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/72","labels_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/72/comments","events_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/72/events","html_url":"https://github.com/aws/amazon-ecs-agent/pull/72","id":75798994,"number":72,"title":"UDP support","user":{"login":"samuelkarp","id":737750,"avatar_url":"https://avatars.githubusercontent.com/u/737750?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelkarp","html_url":"https://github.com/samuelkarp","followers_url":"https://api.github.com/users/samuelkarp/followers","following_url":"https://api.github.com/users/samuelkarp/following{/other_user}","gists_url":"https://api.github.com/users/samuelkarp/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelkarp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelkarp/subscriptions","organizations_url":"https://api.github.com/users/samuelkarp/orgs","repos_url":"https://api.github.com/users/samuelkarp/repos","events_url":"https://api.github.com/users/samuelkarp/events{/privacy}","received_events_url":"https://api.github.com/users/samuelkarp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-05-13T01:08:46Z","updated_at":"2015-05-23T02:57:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/72","html_url":"https://github.com/aws/amazon-ecs-agent/pull/72","diff_url":"https://github.com/aws/amazon-ecs-agent/pull/72.diff","patch_url":"https://github.com/aws/amazon-ecs-agent/pull/72.patch"},"body":"Here's a first draft of UDP support.  Note that it is not yet actually supported by the service, so testing has been manual (with some limited testing in our dev environment).  Once the service supports sending protocol, this will address #2.\r\n\r\nThe following concerns should be addressed by this PR:\r\n* register with UDP resources available\r\n* receive protocol from ACS\r\n* start containers with the correct indicated protocol\r\n* serialize in our saved state file and update the `Version` as UDP ports are backwards-incompatible\r\n\r\nThere is a minor change in one of the ACS shapes used for establishing the websocket (`agentVersion` field is renamed to `versionInfo`).  The previous name is actually an error, but fortunately neither the error or the change here is impacting as the shape is flattened while establishing the websocket and that name is ignored.\r\n\r\nr? @euank @aaithal "},"comment":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/comments/104822949","html_url":"https://github.com/aws/amazon-ecs-agent/pull/72#issuecomment-104822949","issue_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/72","id":104822949,"user":{"login":"euank","id":2147649,"avatar_url":"https://avatars.githubusercontent.com/u/2147649?v=3","gravatar_id":"","url":"https://api.github.com/users/euank","html_url":"https://github.com/euank","followers_url":"https://api.github.com/users/euank/followers","following_url":"https://api.github.com/users/euank/following{/other_user}","gists_url":"https://api.github.com/users/euank/gists{/gist_id}","starred_url":"https://api.github.com/users/euank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euank/subscriptions","organizations_url":"https://api.github.com/users/euank/orgs","repos_url":"https://api.github.com/users/euank/repos","events_url":"https://api.github.com/users/euank/events{/privacy}","received_events_url":"https://api.github.com/users/euank/received_events","type":"User","site_admin":false},"created_at":"2015-05-23T02:57:43Z","updated_at":"2015-05-23T02:57:43Z","body":"I gave it another good look and found another missing detail. There's a conversion function for docker port map->portbindings which didn't get updated. See the most recent commit on [my branch](https://github.com/euank/amazon-ecs-agent/commits/UdpProtocol) for what I mean.\r\n\r\nI'm not sure if you'd like to pull my commit into this PR or if you'd rather me open one in its stead. Either is fine by me.\r\n\r\nWith the addition of my above-referenced commit, everything looks good to me."}}