{"action":"created","issue":{"url":"https://api.github.com/repos/DataDog/dd-agent/issues/2018","labels_url":"https://api.github.com/repos/DataDog/dd-agent/issues/2018/labels{/name}","comments_url":"https://api.github.com/repos/DataDog/dd-agent/issues/2018/comments","events_url":"https://api.github.com/repos/DataDog/dd-agent/issues/2018/events","html_url":"https://github.com/DataDog/dd-agent/pull/2018","id":114329521,"number":2018,"title":"The consul.catalog.nodes_up should reflect the # of nodes actually up","user":{"login":"mtougeron","id":37266,"avatar_url":"https://avatars.githubusercontent.com/u/37266?v=3","gravatar_id":"","url":"https://api.github.com/users/mtougeron","html_url":"https://github.com/mtougeron","followers_url":"https://api.github.com/users/mtougeron/followers","following_url":"https://api.github.com/users/mtougeron/following{/other_user}","gists_url":"https://api.github.com/users/mtougeron/gists{/gist_id}","starred_url":"https://api.github.com/users/mtougeron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtougeron/subscriptions","organizations_url":"https://api.github.com/users/mtougeron/orgs","repos_url":"https://api.github.com/users/mtougeron/repos","events_url":"https://api.github.com/users/mtougeron/events{/privacy}","received_events_url":"https://api.github.com/users/mtougeron/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-30T18:37:03Z","updated_at":"2015-11-02T16:01:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DataDog/dd-agent/pulls/2018","html_url":"https://github.com/DataDog/dd-agent/pull/2018","diff_url":"https://github.com/DataDog/dd-agent/pull/2018.diff","patch_url":"https://github.com/DataDog/dd-agent/pull/2018.patch"},"body":"The `consul.catalog.nodes_up` should reflect the # of nodes actually up so it is now checking the serfHealth for each service node. Technically, I think the `consul.catalog.nodes_up` should reflect the # of nodes passing the health checks but for backwards compatibility I left it with just the nodes that are running that are part of the service.\r\n\r\nI also added 3 new stats: `consul.catalog.nodes_passing`, `consul.catalog.nodes_warning`, & `consul.catalog.nodes_critical` so that you can trend the actual # of nodes in each state for the service.\r\n\r\nFuture enhancement planned: Adjust the service checks to use the `/v1/health/service/<service>` endpoint instead of `/v1/health/state/<state>` since `/v1/health/state/<state>` only returns results for services with a `Check` defined. This means that services that are based on if the node is up/down won't have proper checks from the agent."},"comment":{"url":"https://api.github.com/repos/DataDog/dd-agent/issues/comments/153062397","html_url":"https://github.com/DataDog/dd-agent/pull/2018#issuecomment-153062397","issue_url":"https://api.github.com/repos/DataDog/dd-agent/issues/2018","id":153062397,"user":{"login":"mtougeron","id":37266,"avatar_url":"https://avatars.githubusercontent.com/u/37266?v=3","gravatar_id":"","url":"https://api.github.com/users/mtougeron","html_url":"https://github.com/mtougeron","followers_url":"https://api.github.com/users/mtougeron/followers","following_url":"https://api.github.com/users/mtougeron/following{/other_user}","gists_url":"https://api.github.com/users/mtougeron/gists{/gist_id}","starred_url":"https://api.github.com/users/mtougeron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtougeron/subscriptions","organizations_url":"https://api.github.com/users/mtougeron/orgs","repos_url":"https://api.github.com/users/mtougeron/repos","events_url":"https://api.github.com/users/mtougeron/events{/privacy}","received_events_url":"https://api.github.com/users/mtougeron/received_events","type":"User","site_admin":false},"created_at":"2015-11-02T16:01:54Z","updated_at":"2015-11-02T16:01:54Z","body":"Actually, I think the problem with this one is that I didn't update the mock. Fixing that now."}}