{"action":"created","issue":{"url":"https://api.github.com/repos/ztellman/collection-check/issues/13","labels_url":"https://api.github.com/repos/ztellman/collection-check/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/ztellman/collection-check/issues/13/comments","events_url":"https://api.github.com/repos/ztellman/collection-check/issues/13/events","html_url":"https://github.com/ztellman/collection-check/pull/13","id":116534557,"number":13,"title":"CLJS support","user":{"login":"martinklepsch","id":97496,"avatar_url":"https://avatars.githubusercontent.com/u/97496?v=3","gravatar_id":"","url":"https://api.github.com/users/martinklepsch","html_url":"https://github.com/martinklepsch","followers_url":"https://api.github.com/users/martinklepsch/followers","following_url":"https://api.github.com/users/martinklepsch/following{/other_user}","gists_url":"https://api.github.com/users/martinklepsch/gists{/gist_id}","starred_url":"https://api.github.com/users/martinklepsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinklepsch/subscriptions","organizations_url":"https://api.github.com/users/martinklepsch/orgs","repos_url":"https://api.github.com/users/martinklepsch/repos","events_url":"https://api.github.com/users/martinklepsch/events{/privacy}","received_events_url":"https://api.github.com/users/martinklepsch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-11-12T11:50:09Z","updated_at":"2015-11-12T23:28:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ztellman/collection-check/pulls/13","html_url":"https://github.com/ztellman/collection-check/pull/13","diff_url":"https://github.com/ztellman/collection-check/pull/13.diff","patch_url":"https://github.com/ztellman/collection-check/pull/13.patch"},"body":"This is a bit messy, I apologize in advance. \r\n\r\nI took a stab at making this library support testing of ClojureScript types as well but I'm a little stuck and so this is mostly a request for help.\r\n\r\nBecause of the different macro handling in CLJS I moved all reporting related functions into a `collection-check.util` namespace that can be required in the different ways necessary for clj/s.\r\n\r\nNow Clojure tests work fine but when testing the ClojureScript side I get tons of warnings about undeclared vars. Most of them are within `test.chuck` but some also concern `report-failing-actions` from the `collection-check.util` namespace. \r\n\r\nI assume the two macros at the end of the util namespace are somehow not right but I don't really understand whats broken with them so any pointers would be appreciated. More specifically this warning is caused: \r\n```\r\nWARNING: Use of undeclared Var collection-check.util/report-failing-actions at line 244 /Users/martin/etc/boot/cache/tmp/Users/martin/code/collection-check/at\r\n8/rcesf6/collection_check/core.cljc\r\n```\r\nand the tests fail with\r\n```\r\nERROR in (test-identities) (at cljs$core$IFn$_invoke$arity$4 (file:757:15)\r\nUncaught exception, not in assertion.\r\nexpected: nil\r\n  actual: #object[ReferenceError ReferenceError: Can't find variable: com]\r\n```\r\n(I assume `com` in that reference error refers to `com.gfredericks.test.chuck.*`)\r\n\r\n@gfredericks is this amount of `undeclared Var` warnings from `test.chuck` expected for some reason? \r\nhttps://gist.github.com/martinklepsch/24fa97a4551b0c2ff86f\r\n\r\nBesides all this:\r\n\r\n- I used `boot` to setup testing for Clojure and ClojureScript usage. This is a departure from using lein — I'm sure a similar setup could be achieved with Leiningen and `cljsbuild` however I couldn't bother setting that up. If this is a definitive blocker I can probably also make it work with lein. \r\n- I moved the `collection-check` namespace to `collection-check.core`. ClojureScript does not support single segment namespaces perfectly well and will generate warnings during compilation. This is a breaking change. Alternatively we could just accept the warnings and stay keep the namespace location as is."},"comment":{"url":"https://api.github.com/repos/ztellman/collection-check/issues/comments/156269793","html_url":"https://github.com/ztellman/collection-check/pull/13#issuecomment-156269793","issue_url":"https://api.github.com/repos/ztellman/collection-check/issues/13","id":156269793,"user":{"login":"martinklepsch","id":97496,"avatar_url":"https://avatars.githubusercontent.com/u/97496?v=3","gravatar_id":"","url":"https://api.github.com/users/martinklepsch","html_url":"https://github.com/martinklepsch","followers_url":"https://api.github.com/users/martinklepsch/followers","following_url":"https://api.github.com/users/martinklepsch/following{/other_user}","gists_url":"https://api.github.com/users/martinklepsch/gists{/gist_id}","starred_url":"https://api.github.com/users/martinklepsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinklepsch/subscriptions","organizations_url":"https://api.github.com/users/martinklepsch/orgs","repos_url":"https://api.github.com/users/martinklepsch/repos","events_url":"https://api.github.com/users/martinklepsch/events{/privacy}","received_events_url":"https://api.github.com/users/martinklepsch/received_events","type":"User","site_admin":false},"created_at":"2015-11-12T23:28:20Z","updated_at":"2015-11-12T23:28:20Z","body":"Another thing that should be investigated: when running Clojure tests there are 83 assertions compared to 63 when running ClojureScript tests. Not entirely sure yet why that is."}}