{"action":"created","comment":{"url":"https://api.github.com/repos/videojs/videojs-contrib-ads/pulls/comments/26341527","id":26341527,"diff_hunk":"@@ -1,3 +1,13 @@\n+(function(factory){\n+    \"use strict\";\n+    if (typeof define === 'function' && define.amd) {\n+        define(['videojs'], function(vjs){factory(window, document, vjs);});","path":"src/videojs.ads.js","position":4,"original_position":4,"commit_id":"c75aff9d52d476fe5e10fd9b671ae27f55232f9c","original_commit_id":"517b493f4ba8ec8c074fa04d2774f7a7417118f1","user":{"login":"dmlap","id":56667,"avatar_url":"https://avatars.githubusercontent.com/u/56667?v=3","gravatar_id":"","url":"https://api.github.com/users/dmlap","html_url":"https://github.com/dmlap","followers_url":"https://api.github.com/users/dmlap/followers","following_url":"https://api.github.com/users/dmlap/following{/other_user}","gists_url":"https://api.github.com/users/dmlap/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlap/subscriptions","organizations_url":"https://api.github.com/users/dmlap/orgs","repos_url":"https://api.github.com/users/dmlap/repos","events_url":"https://api.github.com/users/dmlap/events{/privacy}","received_events_url":"https://api.github.com/users/dmlap/received_events","type":"User","site_admin":false},"body":"Oops. Yeah, it makes sense as a dependency. I'm inclined to go with a named module so we don't run into the concatenation problem in downstream dependencies again.","created_at":"2015-03-12T20:33:23Z","updated_at":"2015-03-12T20:33:23Z","html_url":"https://github.com/videojs/videojs-contrib-ads/pull/72#discussion_r26341527","pull_request_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/pulls/72","_links":{"self":{"href":"https://api.github.com/repos/videojs/videojs-contrib-ads/pulls/comments/26341527"},"html":{"href":"https://github.com/videojs/videojs-contrib-ads/pull/72#discussion_r26341527"},"pull_request":{"href":"https://api.github.com/repos/videojs/videojs-contrib-ads/pulls/72"}}},"pull_request":{"url":"https://api.github.com/repos/videojs/videojs-contrib-ads/pulls/72","id":31069480,"html_url":"https://github.com/videojs/videojs-contrib-ads/pull/72","diff_url":"https://github.com/videojs/videojs-contrib-ads/pull/72.diff","patch_url":"https://github.com/videojs/videojs-contrib-ads/pull/72.patch","issue_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/issues/72","number":72,"state":"open","locked":false,"title":"Umd","user":{"login":"gkatsev","id":535884,"avatar_url":"https://avatars.githubusercontent.com/u/535884?v=3","gravatar_id":"","url":"https://api.github.com/users/gkatsev","html_url":"https://github.com/gkatsev","followers_url":"https://api.github.com/users/gkatsev/followers","following_url":"https://api.github.com/users/gkatsev/following{/other_user}","gists_url":"https://api.github.com/users/gkatsev/gists{/gist_id}","starred_url":"https://api.github.com/users/gkatsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkatsev/subscriptions","organizations_url":"https://api.github.com/users/gkatsev/orgs","repos_url":"https://api.github.com/users/gkatsev/repos","events_url":"https://api.github.com/users/gkatsev/events{/privacy}","received_events_url":"https://api.github.com/users/gkatsev/received_events","type":"User","site_admin":false},"body":"Fixes #45","created_at":"2015-03-12T19:29:29Z","updated_at":"2015-03-12T20:33:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"adf0baeea327ee41f4dad1390f55ad966d1bc724","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/pulls/72/commits","review_comments_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/pulls/72/comments","review_comment_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/pulls/comments{/number}","comments_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/issues/72/comments","statuses_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/statuses/c75aff9d52d476fe5e10fd9b671ae27f55232f9c","head":{"label":"videojs:umd","ref":"umd","sha":"c75aff9d52d476fe5e10fd9b671ae27f55232f9c","user":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"repo":{"id":13100632,"name":"videojs-contrib-ads","full_name":"videojs/videojs-contrib-ads","owner":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videojs/videojs-contrib-ads","description":"A video.js plugin that provides common functionality needed by video ad integrations.","fork":false,"url":"https://api.github.com/repos/videojs/videojs-contrib-ads","forks_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/forks","keys_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/teams","hooks_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/hooks","issue_events_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/issues/events{/number}","events_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/events","assignees_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/assignees{/user}","branches_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/branches{/branch}","tags_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/tags","blobs_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/git/refs{/sha}","trees_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/statuses/{sha}","languages_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/languages","stargazers_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/stargazers","contributors_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/contributors","subscribers_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/subscribers","subscription_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/subscription","commits_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/commits{/sha}","git_commits_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/git/commits{/sha}","comments_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/comments{/number}","issue_comment_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/issues/comments{/number}","contents_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/contents/{+path}","compare_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/merges","archive_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/downloads","issues_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/issues{/number}","pulls_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/pulls{/number}","milestones_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/milestones{/number}","notifications_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/labels{/name}","releases_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/releases{/id}","created_at":"2013-09-25T17:35:47Z","updated_at":"2015-03-11T09:27:31Z","pushed_at":"2015-03-12T20:22:48Z","git_url":"git://github.com/videojs/videojs-contrib-ads.git","ssh_url":"git@github.com:videojs/videojs-contrib-ads.git","clone_url":"https://github.com/videojs/videojs-contrib-ads.git","svn_url":"https://github.com/videojs/videojs-contrib-ads","homepage":null,"size":4180,"stargazers_count":51,"watchers_count":51,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":8,"forks":52,"open_issues":8,"watchers":51,"default_branch":"master"}},"base":{"label":"videojs:master","ref":"master","sha":"99ccc11bc85377a143a1804bfdb128adf63d1ab8","user":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"repo":{"id":13100632,"name":"videojs-contrib-ads","full_name":"videojs/videojs-contrib-ads","owner":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videojs/videojs-contrib-ads","description":"A video.js plugin that provides common functionality needed by video ad integrations.","fork":false,"url":"https://api.github.com/repos/videojs/videojs-contrib-ads","forks_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/forks","keys_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/teams","hooks_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/hooks","issue_events_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/issues/events{/number}","events_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/events","assignees_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/assignees{/user}","branches_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/branches{/branch}","tags_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/tags","blobs_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/git/refs{/sha}","trees_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/statuses/{sha}","languages_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/languages","stargazers_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/stargazers","contributors_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/contributors","subscribers_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/subscribers","subscription_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/subscription","commits_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/commits{/sha}","git_commits_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/git/commits{/sha}","comments_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/comments{/number}","issue_comment_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/issues/comments{/number}","contents_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/contents/{+path}","compare_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/merges","archive_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/downloads","issues_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/issues{/number}","pulls_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/pulls{/number}","milestones_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/milestones{/number}","notifications_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/labels{/name}","releases_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/releases{/id}","created_at":"2013-09-25T17:35:47Z","updated_at":"2015-03-11T09:27:31Z","pushed_at":"2015-03-12T20:22:48Z","git_url":"git://github.com/videojs/videojs-contrib-ads.git","ssh_url":"git@github.com:videojs/videojs-contrib-ads.git","clone_url":"https://github.com/videojs/videojs-contrib-ads.git","svn_url":"https://github.com/videojs/videojs-contrib-ads","homepage":null,"size":4180,"stargazers_count":51,"watchers_count":51,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":8,"forks":52,"open_issues":8,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/videojs/videojs-contrib-ads/pulls/72"},"html":{"href":"https://github.com/videojs/videojs-contrib-ads/pull/72"},"issue":{"href":"https://api.github.com/repos/videojs/videojs-contrib-ads/issues/72"},"comments":{"href":"https://api.github.com/repos/videojs/videojs-contrib-ads/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/videojs/videojs-contrib-ads/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/videojs/videojs-contrib-ads/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/videojs/videojs-contrib-ads/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/videojs/videojs-contrib-ads/statuses/c75aff9d52d476fe5e10fd9b671ae27f55232f9c"}}}}