{"action":"created","comment":{"url":"https://api.github.com/repos/bonobos/spree/pulls/comments/31455490","id":31455490,"diff_hunk":"@@ -31,6 +32,13 @@ def ensure_stock_transfer_not_finalized\n       end\n     end\n \n+    def prevent_expected_quantity_update_stock_transfer_finalized\n+      if changed.include?(\"expected_quantity\") && !stock_transfer.finalizable?","path":"core/app/models/spree/transfer_item.rb","position":13,"original_position":13,"commit_id":"70d889f6ef7366e77d172b89448ce1982db510ea","original_commit_id":"70d889f6ef7366e77d172b89448ce1982db510ea","user":{"login":"richardnuno","id":2223534,"avatar_url":"https://avatars.githubusercontent.com/u/2223534?v=3","gravatar_id":"","url":"https://api.github.com/users/richardnuno","html_url":"https://github.com/richardnuno","followers_url":"https://api.github.com/users/richardnuno/followers","following_url":"https://api.github.com/users/richardnuno/following{/other_user}","gists_url":"https://api.github.com/users/richardnuno/gists{/gist_id}","starred_url":"https://api.github.com/users/richardnuno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardnuno/subscriptions","organizations_url":"https://api.github.com/users/richardnuno/orgs","repos_url":"https://api.github.com/users/richardnuno/repos","events_url":"https://api.github.com/users/richardnuno/events{/privacy}","received_events_url":"https://api.github.com/users/richardnuno/received_events","type":"User","site_admin":false},"body":"It is, good catch.","created_at":"2015-06-01T18:34:14Z","updated_at":"2015-06-01T18:34:14Z","html_url":"https://github.com/bonobos/spree/pull/389#discussion_r31455490","pull_request_url":"https://api.github.com/repos/bonobos/spree/pulls/389","_links":{"self":{"href":"https://api.github.com/repos/bonobos/spree/pulls/comments/31455490"},"html":{"href":"https://github.com/bonobos/spree/pull/389#discussion_r31455490"},"pull_request":{"href":"https://api.github.com/repos/bonobos/spree/pulls/389"}}},"pull_request":{"url":"https://api.github.com/repos/bonobos/spree/pulls/389","id":36532304,"html_url":"https://github.com/bonobos/spree/pull/389","diff_url":"https://github.com/bonobos/spree/pull/389.diff","patch_url":"https://github.com/bonobos/spree/pull/389.patch","issue_url":"https://api.github.com/repos/bonobos/spree/issues/389","number":389,"state":"open","locked":false,"title":"Prevent a transfer item’s expected quantity from being updated when its stock transfer is finalized","user":{"login":"richardnuno","id":2223534,"avatar_url":"https://avatars.githubusercontent.com/u/2223534?v=3","gravatar_id":"","url":"https://api.github.com/users/richardnuno","html_url":"https://github.com/richardnuno","followers_url":"https://api.github.com/users/richardnuno/followers","following_url":"https://api.github.com/users/richardnuno/following{/other_user}","gists_url":"https://api.github.com/users/richardnuno/gists{/gist_id}","starred_url":"https://api.github.com/users/richardnuno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardnuno/subscriptions","organizations_url":"https://api.github.com/users/richardnuno/orgs","repos_url":"https://api.github.com/users/richardnuno/repos","events_url":"https://api.github.com/users/richardnuno/events{/privacy}","received_events_url":"https://api.github.com/users/richardnuno/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-05-29T18:28:32Z","updated_at":"2015-06-01T18:34:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a7b5c75259f5193105ed2f0d0a6d5b9e0ffc0b1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bonobos/spree/pulls/389/commits","review_comments_url":"https://api.github.com/repos/bonobos/spree/pulls/389/comments","review_comment_url":"https://api.github.com/repos/bonobos/spree/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bonobos/spree/issues/389/comments","statuses_url":"https://api.github.com/repos/bonobos/spree/statuses/70d889f6ef7366e77d172b89448ce1982db510ea","head":{"label":"bonobos:prevent-finalized-item-update","ref":"prevent-finalized-item-update","sha":"70d889f6ef7366e77d172b89448ce1982db510ea","user":{"login":"bonobos","id":78914,"avatar_url":"https://avatars.githubusercontent.com/u/78914?v=3","gravatar_id":"","url":"https://api.github.com/users/bonobos","html_url":"https://github.com/bonobos","followers_url":"https://api.github.com/users/bonobos/followers","following_url":"https://api.github.com/users/bonobos/following{/other_user}","gists_url":"https://api.github.com/users/bonobos/gists{/gist_id}","starred_url":"https://api.github.com/users/bonobos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bonobos/subscriptions","organizations_url":"https://api.github.com/users/bonobos/orgs","repos_url":"https://api.github.com/users/bonobos/repos","events_url":"https://api.github.com/users/bonobos/events{/privacy}","received_events_url":"https://api.github.com/users/bonobos/received_events","type":"Organization","site_admin":false},"repo":{"id":12625383,"name":"spree","full_name":"bonobos/spree","owner":{"login":"bonobos","id":78914,"avatar_url":"https://avatars.githubusercontent.com/u/78914?v=3","gravatar_id":"","url":"https://api.github.com/users/bonobos","html_url":"https://github.com/bonobos","followers_url":"https://api.github.com/users/bonobos/followers","following_url":"https://api.github.com/users/bonobos/following{/other_user}","gists_url":"https://api.github.com/users/bonobos/gists{/gist_id}","starred_url":"https://api.github.com/users/bonobos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bonobos/subscriptions","organizations_url":"https://api.github.com/users/bonobos/orgs","repos_url":"https://api.github.com/users/bonobos/repos","events_url":"https://api.github.com/users/bonobos/events{/privacy}","received_events_url":"https://api.github.com/users/bonobos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bonobos/spree","description":"Spree is a complete open source e-commerce solution for Ruby on Rails.","fork":true,"url":"https://api.github.com/repos/bonobos/spree","forks_url":"https://api.github.com/repos/bonobos/spree/forks","keys_url":"https://api.github.com/repos/bonobos/spree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bonobos/spree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bonobos/spree/teams","hooks_url":"https://api.github.com/repos/bonobos/spree/hooks","issue_events_url":"https://api.github.com/repos/bonobos/spree/issues/events{/number}","events_url":"https://api.github.com/repos/bonobos/spree/events","assignees_url":"https://api.github.com/repos/bonobos/spree/assignees{/user}","branches_url":"https://api.github.com/repos/bonobos/spree/branches{/branch}","tags_url":"https://api.github.com/repos/bonobos/spree/tags","blobs_url":"https://api.github.com/repos/bonobos/spree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bonobos/spree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bonobos/spree/git/refs{/sha}","trees_url":"https://api.github.com/repos/bonobos/spree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bonobos/spree/statuses/{sha}","languages_url":"https://api.github.com/repos/bonobos/spree/languages","stargazers_url":"https://api.github.com/repos/bonobos/spree/stargazers","contributors_url":"https://api.github.com/repos/bonobos/spree/contributors","subscribers_url":"https://api.github.com/repos/bonobos/spree/subscribers","subscription_url":"https://api.github.com/repos/bonobos/spree/subscription","commits_url":"https://api.github.com/repos/bonobos/spree/commits{/sha}","git_commits_url":"https://api.github.com/repos/bonobos/spree/git/commits{/sha}","comments_url":"https://api.github.com/repos/bonobos/spree/comments{/number}","issue_comment_url":"https://api.github.com/repos/bonobos/spree/issues/comments{/number}","contents_url":"https://api.github.com/repos/bonobos/spree/contents/{+path}","compare_url":"https://api.github.com/repos/bonobos/spree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bonobos/spree/merges","archive_url":"https://api.github.com/repos/bonobos/spree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bonobos/spree/downloads","issues_url":"https://api.github.com/repos/bonobos/spree/issues{/number}","pulls_url":"https://api.github.com/repos/bonobos/spree/pulls{/number}","milestones_url":"https://api.github.com/repos/bonobos/spree/milestones{/number}","notifications_url":"https://api.github.com/repos/bonobos/spree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bonobos/spree/labels{/name}","releases_url":"https://api.github.com/repos/bonobos/spree/releases{/id}","created_at":"2013-09-05T18:28:25Z","updated_at":"2015-05-07T18:58:45Z","pushed_at":"2015-06-01T17:48:32Z","git_url":"git://github.com/bonobos/spree.git","ssh_url":"git@github.com:bonobos/spree.git","clone_url":"https://github.com/bonobos/spree.git","svn_url":"https://github.com/bonobos/spree","homepage":"http://spreecommerce.com","size":82791,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":13,"forks":2,"open_issues":13,"watchers":1,"default_branch":"2-2-dev"}},"base":{"label":"bonobos:2-2-dev","ref":"2-2-dev","sha":"1ee0488186d1c232d872016d98f7665f93db9eb4","user":{"login":"bonobos","id":78914,"avatar_url":"https://avatars.githubusercontent.com/u/78914?v=3","gravatar_id":"","url":"https://api.github.com/users/bonobos","html_url":"https://github.com/bonobos","followers_url":"https://api.github.com/users/bonobos/followers","following_url":"https://api.github.com/users/bonobos/following{/other_user}","gists_url":"https://api.github.com/users/bonobos/gists{/gist_id}","starred_url":"https://api.github.com/users/bonobos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bonobos/subscriptions","organizations_url":"https://api.github.com/users/bonobos/orgs","repos_url":"https://api.github.com/users/bonobos/repos","events_url":"https://api.github.com/users/bonobos/events{/privacy}","received_events_url":"https://api.github.com/users/bonobos/received_events","type":"Organization","site_admin":false},"repo":{"id":12625383,"name":"spree","full_name":"bonobos/spree","owner":{"login":"bonobos","id":78914,"avatar_url":"https://avatars.githubusercontent.com/u/78914?v=3","gravatar_id":"","url":"https://api.github.com/users/bonobos","html_url":"https://github.com/bonobos","followers_url":"https://api.github.com/users/bonobos/followers","following_url":"https://api.github.com/users/bonobos/following{/other_user}","gists_url":"https://api.github.com/users/bonobos/gists{/gist_id}","starred_url":"https://api.github.com/users/bonobos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bonobos/subscriptions","organizations_url":"https://api.github.com/users/bonobos/orgs","repos_url":"https://api.github.com/users/bonobos/repos","events_url":"https://api.github.com/users/bonobos/events{/privacy}","received_events_url":"https://api.github.com/users/bonobos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bonobos/spree","description":"Spree is a complete open source e-commerce solution for Ruby on Rails.","fork":true,"url":"https://api.github.com/repos/bonobos/spree","forks_url":"https://api.github.com/repos/bonobos/spree/forks","keys_url":"https://api.github.com/repos/bonobos/spree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bonobos/spree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bonobos/spree/teams","hooks_url":"https://api.github.com/repos/bonobos/spree/hooks","issue_events_url":"https://api.github.com/repos/bonobos/spree/issues/events{/number}","events_url":"https://api.github.com/repos/bonobos/spree/events","assignees_url":"https://api.github.com/repos/bonobos/spree/assignees{/user}","branches_url":"https://api.github.com/repos/bonobos/spree/branches{/branch}","tags_url":"https://api.github.com/repos/bonobos/spree/tags","blobs_url":"https://api.github.com/repos/bonobos/spree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bonobos/spree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bonobos/spree/git/refs{/sha}","trees_url":"https://api.github.com/repos/bonobos/spree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bonobos/spree/statuses/{sha}","languages_url":"https://api.github.com/repos/bonobos/spree/languages","stargazers_url":"https://api.github.com/repos/bonobos/spree/stargazers","contributors_url":"https://api.github.com/repos/bonobos/spree/contributors","subscribers_url":"https://api.github.com/repos/bonobos/spree/subscribers","subscription_url":"https://api.github.com/repos/bonobos/spree/subscription","commits_url":"https://api.github.com/repos/bonobos/spree/commits{/sha}","git_commits_url":"https://api.github.com/repos/bonobos/spree/git/commits{/sha}","comments_url":"https://api.github.com/repos/bonobos/spree/comments{/number}","issue_comment_url":"https://api.github.com/repos/bonobos/spree/issues/comments{/number}","contents_url":"https://api.github.com/repos/bonobos/spree/contents/{+path}","compare_url":"https://api.github.com/repos/bonobos/spree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bonobos/spree/merges","archive_url":"https://api.github.com/repos/bonobos/spree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bonobos/spree/downloads","issues_url":"https://api.github.com/repos/bonobos/spree/issues{/number}","pulls_url":"https://api.github.com/repos/bonobos/spree/pulls{/number}","milestones_url":"https://api.github.com/repos/bonobos/spree/milestones{/number}","notifications_url":"https://api.github.com/repos/bonobos/spree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bonobos/spree/labels{/name}","releases_url":"https://api.github.com/repos/bonobos/spree/releases{/id}","created_at":"2013-09-05T18:28:25Z","updated_at":"2015-05-07T18:58:45Z","pushed_at":"2015-06-01T17:48:32Z","git_url":"git://github.com/bonobos/spree.git","ssh_url":"git@github.com:bonobos/spree.git","clone_url":"https://github.com/bonobos/spree.git","svn_url":"https://github.com/bonobos/spree","homepage":"http://spreecommerce.com","size":82791,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":13,"forks":2,"open_issues":13,"watchers":1,"default_branch":"2-2-dev"}},"_links":{"self":{"href":"https://api.github.com/repos/bonobos/spree/pulls/389"},"html":{"href":"https://github.com/bonobos/spree/pull/389"},"issue":{"href":"https://api.github.com/repos/bonobos/spree/issues/389"},"comments":{"href":"https://api.github.com/repos/bonobos/spree/issues/389/comments"},"review_comments":{"href":"https://api.github.com/repos/bonobos/spree/pulls/389/comments"},"review_comment":{"href":"https://api.github.com/repos/bonobos/spree/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bonobos/spree/pulls/389/commits"},"statuses":{"href":"https://api.github.com/repos/bonobos/spree/statuses/70d889f6ef7366e77d172b89448ce1982db510ea"}}}}