{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/34083975","id":34083975,"diff_hunk":"@@ -3,14 +3,13 @@\n \n using System;\n using Microsoft.AspNet.JsonPatch.Operations;\n-using Microsoft.Framework.Internal;\n \n namespace Microsoft.AspNet.JsonPatch.Exceptions\n {\n-    public class JsonPatchException<TModel> : JsonPatchException where TModel : class\n+    public class JsonPatchException : JsonPatchExceptionBase //where TModel : class","path":"src/Microsoft.AspNet.JsonPatch/Exceptions/JsonPatchException.cs","position":9,"original_position":9,"commit_id":"926dca1145d0922fb1b127a3d66f1fa94dfae2b6","original_commit_id":"926dca1145d0922fb1b127a3d66f1fa94dfae2b6","user":{"login":"rynowak","id":1430011,"avatar_url":"https://avatars.githubusercontent.com/u/1430011?v=3","gravatar_id":"","url":"https://api.github.com/users/rynowak","html_url":"https://github.com/rynowak","followers_url":"https://api.github.com/users/rynowak/followers","following_url":"https://api.github.com/users/rynowak/following{/other_user}","gists_url":"https://api.github.com/users/rynowak/gists{/gist_id}","starred_url":"https://api.github.com/users/rynowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rynowak/subscriptions","organizations_url":"https://api.github.com/users/rynowak/orgs","repos_url":"https://api.github.com/users/rynowak/repos","events_url":"https://api.github.com/users/rynowak/events{/privacy}","received_events_url":"https://api.github.com/users/rynowak/received_events","type":"User","site_admin":false},"body":"Delete instead of commenting out.\r\n\r\nDo we really need the base-class at all here?","created_at":"2015-07-07T20:07:48Z","updated_at":"2015-07-07T20:07:48Z","html_url":"https://github.com/aspnet/Mvc/pull/2789#discussion_r34083975","pull_request_url":"https://api.github.com/repos/aspnet/Mvc/pulls/2789","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/34083975"},"html":{"href":"https://github.com/aspnet/Mvc/pull/2789#discussion_r34083975"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/2789"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/2789","id":39371675,"html_url":"https://github.com/aspnet/Mvc/pull/2789","diff_url":"https://github.com/aspnet/Mvc/pull/2789.diff","patch_url":"https://github.com/aspnet/Mvc/pull/2789.patch","issue_url":"https://api.github.com/repos/aspnet/Mvc/issues/2789","number":2789,"state":"open","locked":false,"title":"Refactoring to get ready for JsonPatch (for dynamics) support.  Relay…","user":{"login":"KevinDockx","id":2431035,"avatar_url":"https://avatars.githubusercontent.com/u/2431035?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinDockx","html_url":"https://github.com/KevinDockx","followers_url":"https://api.github.com/users/KevinDockx/followers","following_url":"https://api.github.com/users/KevinDockx/following{/other_user}","gists_url":"https://api.github.com/users/KevinDockx/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinDockx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinDockx/subscriptions","organizations_url":"https://api.github.com/users/KevinDockx/orgs","repos_url":"https://api.github.com/users/KevinDockx/repos","events_url":"https://api.github.com/users/KevinDockx/events{/privacy}","received_events_url":"https://api.github.com/users/KevinDockx/received_events","type":"User","site_admin":false},"body":"This is the first in a series of PR's to allow supporting dynamics in JsonPatch.  It's a split-up of the commits I initially added to a PR (https://github.com/aspnet/Mvc/pull/2736#issuecomment-118213531), as discussed with Eilon, Daniel and Kirthi on Skype.  \r\n\r\nThis may look like it contains a lot of changes, but it's always just a few lines per file :)\r\n\r\nThe reason for this refactoring is that we need to allow users to create a JsonPatchDocument without having to know the type the patchdoc will be executed on, and later on: executing that patchdoc on a dynamically typed object - a very typical case that will be possible when the full implementation of dynamics support is done.","created_at":"2015-07-07T13:49:14Z","updated_at":"2015-07-07T20:07:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e92d6c8a815d49b12a2a0278d4394fd3796ec8ff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Mvc/pulls/2789/commits","review_comments_url":"https://api.github.com/repos/aspnet/Mvc/pulls/2789/comments","review_comment_url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Mvc/issues/2789/comments","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/926dca1145d0922fb1b127a3d66f1fa94dfae2b6","head":{"label":"KevinDockx:dev","ref":"dev","sha":"926dca1145d0922fb1b127a3d66f1fa94dfae2b6","user":{"login":"KevinDockx","id":2431035,"avatar_url":"https://avatars.githubusercontent.com/u/2431035?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinDockx","html_url":"https://github.com/KevinDockx","followers_url":"https://api.github.com/users/KevinDockx/followers","following_url":"https://api.github.com/users/KevinDockx/following{/other_user}","gists_url":"https://api.github.com/users/KevinDockx/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinDockx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinDockx/subscriptions","organizations_url":"https://api.github.com/users/KevinDockx/orgs","repos_url":"https://api.github.com/users/KevinDockx/repos","events_url":"https://api.github.com/users/KevinDockx/events{/privacy}","received_events_url":"https://api.github.com/users/KevinDockx/received_events","type":"User","site_admin":false},"repo":{"id":30874785,"name":"Mvc","full_name":"KevinDockx/Mvc","owner":{"login":"KevinDockx","id":2431035,"avatar_url":"https://avatars.githubusercontent.com/u/2431035?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinDockx","html_url":"https://github.com/KevinDockx","followers_url":"https://api.github.com/users/KevinDockx/followers","following_url":"https://api.github.com/users/KevinDockx/following{/other_user}","gists_url":"https://api.github.com/users/KevinDockx/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinDockx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinDockx/subscriptions","organizations_url":"https://api.github.com/users/KevinDockx/orgs","repos_url":"https://api.github.com/users/KevinDockx/repos","events_url":"https://api.github.com/users/KevinDockx/events{/privacy}","received_events_url":"https://api.github.com/users/KevinDockx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KevinDockx/Mvc","description":"Model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":true,"url":"https://api.github.com/repos/KevinDockx/Mvc","forks_url":"https://api.github.com/repos/KevinDockx/Mvc/forks","keys_url":"https://api.github.com/repos/KevinDockx/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KevinDockx/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KevinDockx/Mvc/teams","hooks_url":"https://api.github.com/repos/KevinDockx/Mvc/hooks","issue_events_url":"https://api.github.com/repos/KevinDockx/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/KevinDockx/Mvc/events","assignees_url":"https://api.github.com/repos/KevinDockx/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/KevinDockx/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/KevinDockx/Mvc/tags","blobs_url":"https://api.github.com/repos/KevinDockx/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KevinDockx/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KevinDockx/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/KevinDockx/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KevinDockx/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/KevinDockx/Mvc/languages","stargazers_url":"https://api.github.com/repos/KevinDockx/Mvc/stargazers","contributors_url":"https://api.github.com/repos/KevinDockx/Mvc/contributors","subscribers_url":"https://api.github.com/repos/KevinDockx/Mvc/subscribers","subscription_url":"https://api.github.com/repos/KevinDockx/Mvc/subscription","commits_url":"https://api.github.com/repos/KevinDockx/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/KevinDockx/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/KevinDockx/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/KevinDockx/Mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/KevinDockx/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/KevinDockx/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KevinDockx/Mvc/merges","archive_url":"https://api.github.com/repos/KevinDockx/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KevinDockx/Mvc/downloads","issues_url":"https://api.github.com/repos/KevinDockx/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/KevinDockx/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/KevinDockx/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/KevinDockx/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KevinDockx/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/KevinDockx/Mvc/releases{/id}","created_at":"2015-02-16T15:40:10Z","updated_at":"2015-03-24T13:10:25Z","pushed_at":"2015-07-07T13:39:20Z","git_url":"git://github.com/KevinDockx/Mvc.git","ssh_url":"git@github.com:KevinDockx/Mvc.git","clone_url":"https://github.com/KevinDockx/Mvc.git","svn_url":"https://github.com/KevinDockx/Mvc","homepage":"","size":13556,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"e985fa5d423968f36a651a354d9c953192c52532","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15126429,"name":"Mvc","full_name":"aspnet/Mvc","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Mvc","description":"Model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":false,"url":"https://api.github.com/repos/aspnet/Mvc","forks_url":"https://api.github.com/repos/aspnet/Mvc/forks","keys_url":"https://api.github.com/repos/aspnet/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Mvc/teams","hooks_url":"https://api.github.com/repos/aspnet/Mvc/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Mvc/events","assignees_url":"https://api.github.com/repos/aspnet/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Mvc/tags","blobs_url":"https://api.github.com/repos/aspnet/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Mvc/languages","stargazers_url":"https://api.github.com/repos/aspnet/Mvc/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Mvc/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Mvc/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Mvc/subscription","commits_url":"https://api.github.com/repos/aspnet/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Mvc/merges","archive_url":"https://api.github.com/repos/aspnet/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Mvc/downloads","issues_url":"https://api.github.com/repos/aspnet/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Mvc/releases{/id}","created_at":"2013-12-12T03:54:00Z","updated_at":"2015-07-07T05:59:34Z","pushed_at":"2015-07-07T15:26:16Z","git_url":"git://github.com/aspnet/Mvc.git","ssh_url":"git@github.com:aspnet/Mvc.git","clone_url":"https://github.com/aspnet/Mvc.git","svn_url":"https://github.com/aspnet/Mvc","homepage":"","size":123630,"stargazers_count":1928,"watchers_count":1928,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":665,"mirror_url":null,"open_issues_count":208,"forks":665,"open_issues":208,"watchers":1928,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/2789"},"html":{"href":"https://github.com/aspnet/Mvc/pull/2789"},"issue":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/2789"},"comments":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/2789/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/2789/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/2789/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Mvc/statuses/926dca1145d0922fb1b127a3d66f1fa94dfae2b6"}}}}