{"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/maps/pulls/comments/36759161","id":36759161,"diff_hunk":"@@ -40,7 +40,18 @@ public function __construct($appName, IRequest $request, $userId, $cacheManager,\n \t */\n \tpublic function index() {\n \t\t$params = array('user' => $this -> userId,'devices'=>$this->locationManager->loadAll($this->userId));\n-\t\treturn new TemplateResponse('maps', 'main', $params);\n+\t\t$response = new TemplateResponse('maps', 'main', $params);\n+\t\tif (class_exists('OCP\\AppFramework\\Http\\ContentSecurityPolicy')) {\n+\t\t\t$csp = new \\OCP\\AppFramework\\Http\\ContentSecurityPolicy();\n+\t\t\t// map tiles\n+\t\t\t$csp->addAllowedImageDomain('http://*.mqcdn.com');\n+\t\t\t// marker icons\n+\t\t\t$csp->addAllowedImageDomain('https://api.tiles.mapbox.com');","path":"controller/pagecontroller.php","position":11,"original_position":11,"commit_id":"8ed5fe024bfd496c090dac244ea87aa6716ab139","original_commit_id":"8ed5fe024bfd496c090dac244ea87aa6716ab139","user":{"login":"LukasReschke","id":878997,"avatar_url":"https://avatars.githubusercontent.com/u/878997?v=3","gravatar_id":"","url":"https://api.github.com/users/LukasReschke","html_url":"https://github.com/LukasReschke","followers_url":"https://api.github.com/users/LukasReschke/followers","following_url":"https://api.github.com/users/LukasReschke/following{/other_user}","gists_url":"https://api.github.com/users/LukasReschke/gists{/gist_id}","starred_url":"https://api.github.com/users/LukasReschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukasReschke/subscriptions","organizations_url":"https://api.github.com/users/LukasReschke/orgs","repos_url":"https://api.github.com/users/LukasReschke/repos","events_url":"https://api.github.com/users/LukasReschke/events{/privacy}","received_events_url":"https://api.github.com/users/LukasReschke/received_events","type":"User","site_admin":false},"body":"If you are sure that it are only these: You can keep them as-is. However, a lot of the protection offered by CSP is anyways gone due through https://github.com/owncloud/maps/pull/49#discussion_r36758549. – Shouldn't make things weaker.","created_at":"2015-08-11T15:32:43Z","updated_at":"2015-08-11T15:32:43Z","html_url":"https://github.com/owncloud/maps/pull/49#discussion_r36759161","pull_request_url":"https://api.github.com/repos/owncloud/maps/pulls/49","_links":{"self":{"href":"https://api.github.com/repos/owncloud/maps/pulls/comments/36759161"},"html":{"href":"https://github.com/owncloud/maps/pull/49#discussion_r36759161"},"pull_request":{"href":"https://api.github.com/repos/owncloud/maps/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/owncloud/maps/pulls/49","id":42011875,"html_url":"https://github.com/owncloud/maps/pull/49","diff_url":"https://github.com/owncloud/maps/pull/49.diff","patch_url":"https://github.com/owncloud/maps/pull/49.patch","issue_url":"https://api.github.com/repos/owncloud/maps/issues/49","number":49,"state":"open","locked":false,"title":"Modify content security policy","user":{"login":"Henni","id":1267827,"avatar_url":"https://avatars.githubusercontent.com/u/1267827?v=3","gravatar_id":"","url":"https://api.github.com/users/Henni","html_url":"https://github.com/Henni","followers_url":"https://api.github.com/users/Henni/followers","following_url":"https://api.github.com/users/Henni/following{/other_user}","gists_url":"https://api.github.com/users/Henni/gists{/gist_id}","starred_url":"https://api.github.com/users/Henni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Henni/subscriptions","organizations_url":"https://api.github.com/users/Henni/orgs","repos_url":"https://api.github.com/users/Henni/repos","events_url":"https://api.github.com/users/Henni/events{/privacy}","received_events_url":"https://api.github.com/users/Henni/received_events","type":"User","site_admin":false},"body":"fixes #47 \r\n\r\n~~probably breaks compatibility for owncloud < 8.1~~","created_at":"2015-08-10T11:51:35Z","updated_at":"2015-08-11T15:32:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74dcf6784978519bd6d887a557a0febb9e24b24a","assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/maps/milestones/1","html_url":"https://github.com/owncloud/maps/milestones/0.1%20%E2%80%93%20the%20basics","labels_url":"https://api.github.com/repos/owncloud/maps/milestones/1/labels","id":763018,"number":1,"title":"0.1 – the basics","description":"","creator":{"login":"jancborchardt","id":925062,"avatar_url":"https://avatars.githubusercontent.com/u/925062?v=3","gravatar_id":"","url":"https://api.github.com/users/jancborchardt","html_url":"https://github.com/jancborchardt","followers_url":"https://api.github.com/users/jancborchardt/followers","following_url":"https://api.github.com/users/jancborchardt/following{/other_user}","gists_url":"https://api.github.com/users/jancborchardt/gists{/gist_id}","starred_url":"https://api.github.com/users/jancborchardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jancborchardt/subscriptions","organizations_url":"https://api.github.com/users/jancborchardt/orgs","repos_url":"https://api.github.com/users/jancborchardt/repos","events_url":"https://api.github.com/users/jancborchardt/events{/privacy}","received_events_url":"https://api.github.com/users/jancborchardt/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":8,"state":"open","created_at":"2014-08-22T21:09:49Z","updated_at":"2015-08-11T15:05:23Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/owncloud/maps/pulls/49/commits","review_comments_url":"https://api.github.com/repos/owncloud/maps/pulls/49/comments","review_comment_url":"https://api.github.com/repos/owncloud/maps/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/maps/issues/49/comments","statuses_url":"https://api.github.com/repos/owncloud/maps/statuses/8ed5fe024bfd496c090dac244ea87aa6716ab139","head":{"label":"owncloud:fix-csp","ref":"fix-csp","sha":"8ed5fe024bfd496c090dac244ea87aa6716ab139","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":11844943,"name":"maps","full_name":"owncloud/maps","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/maps","description":"","fork":false,"url":"https://api.github.com/repos/owncloud/maps","forks_url":"https://api.github.com/repos/owncloud/maps/forks","keys_url":"https://api.github.com/repos/owncloud/maps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/maps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/maps/teams","hooks_url":"https://api.github.com/repos/owncloud/maps/hooks","issue_events_url":"https://api.github.com/repos/owncloud/maps/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/maps/events","assignees_url":"https://api.github.com/repos/owncloud/maps/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/maps/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/maps/tags","blobs_url":"https://api.github.com/repos/owncloud/maps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/maps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/maps/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/maps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/maps/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/maps/languages","stargazers_url":"https://api.github.com/repos/owncloud/maps/stargazers","contributors_url":"https://api.github.com/repos/owncloud/maps/contributors","subscribers_url":"https://api.github.com/repos/owncloud/maps/subscribers","subscription_url":"https://api.github.com/repos/owncloud/maps/subscription","commits_url":"https://api.github.com/repos/owncloud/maps/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/maps/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/maps/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/maps/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/maps/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/maps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/maps/merges","archive_url":"https://api.github.com/repos/owncloud/maps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/maps/downloads","issues_url":"https://api.github.com/repos/owncloud/maps/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/maps/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/maps/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/maps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/maps/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/maps/releases{/id}","created_at":"2013-08-02T14:19:48Z","updated_at":"2015-08-01T06:26:13Z","pushed_at":"2015-08-11T15:05:24Z","git_url":"git://github.com/owncloud/maps.git","ssh_url":"git@github.com:owncloud/maps.git","clone_url":"https://github.com/owncloud/maps.git","svn_url":"https://github.com/owncloud/maps","homepage":null,"size":2556,"stargazers_count":24,"watchers_count":24,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":27,"forks":8,"open_issues":27,"watchers":24,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"d57464e0cfefab6bcfd293512fc3ddc25fa15cc2","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":11844943,"name":"maps","full_name":"owncloud/maps","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/maps","description":"","fork":false,"url":"https://api.github.com/repos/owncloud/maps","forks_url":"https://api.github.com/repos/owncloud/maps/forks","keys_url":"https://api.github.com/repos/owncloud/maps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/maps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/maps/teams","hooks_url":"https://api.github.com/repos/owncloud/maps/hooks","issue_events_url":"https://api.github.com/repos/owncloud/maps/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/maps/events","assignees_url":"https://api.github.com/repos/owncloud/maps/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/maps/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/maps/tags","blobs_url":"https://api.github.com/repos/owncloud/maps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/maps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/maps/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/maps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/maps/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/maps/languages","stargazers_url":"https://api.github.com/repos/owncloud/maps/stargazers","contributors_url":"https://api.github.com/repos/owncloud/maps/contributors","subscribers_url":"https://api.github.com/repos/owncloud/maps/subscribers","subscription_url":"https://api.github.com/repos/owncloud/maps/subscription","commits_url":"https://api.github.com/repos/owncloud/maps/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/maps/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/maps/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/maps/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/maps/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/maps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/maps/merges","archive_url":"https://api.github.com/repos/owncloud/maps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/maps/downloads","issues_url":"https://api.github.com/repos/owncloud/maps/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/maps/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/maps/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/maps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/maps/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/maps/releases{/id}","created_at":"2013-08-02T14:19:48Z","updated_at":"2015-08-01T06:26:13Z","pushed_at":"2015-08-11T15:05:24Z","git_url":"git://github.com/owncloud/maps.git","ssh_url":"git@github.com:owncloud/maps.git","clone_url":"https://github.com/owncloud/maps.git","svn_url":"https://github.com/owncloud/maps","homepage":null,"size":2556,"stargazers_count":24,"watchers_count":24,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":27,"forks":8,"open_issues":27,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/maps/pulls/49"},"html":{"href":"https://github.com/owncloud/maps/pull/49"},"issue":{"href":"https://api.github.com/repos/owncloud/maps/issues/49"},"comments":{"href":"https://api.github.com/repos/owncloud/maps/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/maps/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/maps/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/maps/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/maps/statuses/8ed5fe024bfd496c090dac244ea87aa6716ab139"}}}}