{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5501","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5501/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5501/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5501/events","html_url":"https://github.com/ManageIQ/manageiq/pull/5501","id":117660348,"number":5501,"title":"Add network security group and firewall parsing support.","user":{"login":"djberg96","id":78529,"avatar_url":"https://avatars.githubusercontent.com/u/78529?v=3","gravatar_id":"","url":"https://api.github.com/users/djberg96","html_url":"https://github.com/djberg96","followers_url":"https://api.github.com/users/djberg96/followers","following_url":"https://api.github.com/users/djberg96/following{/other_user}","gists_url":"https://api.github.com/users/djberg96/gists{/gist_id}","starred_url":"https://api.github.com/users/djberg96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djberg96/subscriptions","organizations_url":"https://api.github.com/users/djberg96/orgs","repos_url":"https://api.github.com/users/djberg96/repos","events_url":"https://api.github.com/users/djberg96/events{/privacy}","received_events_url":"https://api.github.com/users/djberg96/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-18T19:21:31Z","updated_at":"2015-11-18T21:28:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5501","html_url":"https://github.com/ManageIQ/manageiq/pull/5501","diff_url":"https://github.com/ManageIQ/manageiq/pull/5501.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/5501.patch"},"body":"This PR adds support to the Azure refresh parser for network security groups and firewall rules, including the relationship between security groups and virtual machines.\r\n\r\nI've also included some specs."},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/157870104","html_url":"https://github.com/ManageIQ/manageiq/pull/5501#issuecomment-157870104","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5501","id":157870104,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2015-11-18T21:28:26Z","updated_at":"2015-11-18T21:28:26Z","body":"<rubocop />Checked commit https://github.com/djberg96/manageiq/commit/6c601b0ee41fd6b79c5f2efd05c3b13749bb3dbb with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0\n3 files checked, 4 offenses detected\n\n**app/models/manageiq/providers/azure/cloud_manager/refresh_parser.rb**\n- [ ] :large_orange_diamond: - [Line 138](https://github.com/djberg96/manageiq/blob/6c601b0ee41fd6b79c5f2efd05c3b13749bb3dbb/app/models/manageiq/providers/azure/cloud_manager/refresh_parser.rb#L138), Col 11 - [Style/AccessorMethodName](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Style/AccessorMethodName) - Do not prefix reader method names with `get_`.\n- [ ] :large_orange_diamond: - [Line 174](https://github.com/djberg96/manageiq/blob/6c601b0ee41fd6b79c5f2efd05c3b13749bb3dbb/app/models/manageiq/providers/azure/cloud_manager/refresh_parser.rb#L174), Col 11 - [Style/AccessorMethodName](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Style/AccessorMethodName) - Do not prefix reader method names with `get_`.\n- [ ] :small_blue_diamond: - [Line 152](https://github.com/djberg96/manageiq/blob/6c601b0ee41fd6b79c5f2efd05c3b13749bb3dbb/app/models/manageiq/providers/azure/cloud_manager/refresh_parser.rb#L152), Col 7 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for get_security_groups_for_vm is too high. [18.41/15]\n- [ ] :small_blue_diamond: - [Line 220](https://github.com/djberg96/manageiq/blob/6c601b0ee41fd6b79c5f2efd05c3b13749bb3dbb/app/models/manageiq/providers/azure/cloud_manager/refresh_parser.rb#L220), Col 7 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for parse_firewall_rules is too high. [20.1/15]\n"}}