{"action":"created","comment":{"url":"https://api.github.com/repos/softlayer/sl-ember-components/pulls/comments/34699371","id":34699371,"diff_hunk":"@@ -87,18 +110,62 @@ export default Ember.Component.extend({\n         function() {\n             let chartDiv = this.$( 'div.chart' );\n \n+            chartDiv.highcharts( this.get( 'highchartsOptions' ) );\n+            this.set( 'chart', chartDiv.highcharts() );\n+            this.updateData();\n+        }\n+    ),\n+\n+    /**\n+     * Updates the chart's series data\n+     *\n+     * @function\n+     * @returns {undefined}\n+     */\n+    updateData: Ember.observer(\n+        'series',\n+        function() {\n+            let chart = this.get( 'chart' );\n+            let series = this.get( 'series' );\n+\n+            if ( !chart.hasOwnProperty( 'series' ) ) {\n+                chart.series = [];\n+            }\n+\n+            for ( let i = 0; i < series.length; i++ ) {\n+                if ( chart.series.length <= i ) {\n+                    chart.addSeries( series[ i ] );\n+                } else {\n+                    chart.series[ i ].setData( series[ i ].data );\n+                }\n+            }\n+        }\n+    ),\n+\n+    // -------------------------------------------------------------------------\n+    // Methods\n+\n+    /**\n+     * Options for Highcharts\n+     *\n+     * @function\n+     * @returns {Object}\n+     */\n+     highchartsOptions: Ember.computed(\n+        'options',\n+        function() {\n             let chartStyle = {\n                 fontFamily: '\"Benton Sans\", \"Helvetica Neue\", Helvetica, Arial, sans-serif',\n                 fontSize: '13px'\n             };\n \n-            let options = Ember.$.extend( true, {\n-                title: '',\n+            return Ember.$.extend( true, {\n                 chart: {\n                     animation: false,\n                     backgroundColor: 'rgba(255, 255, 255, 0)',\n                     style: chartStyle\n                 },\n+                title: null,","path":"addon/components/sl-chart.js","position":91,"original_position":91,"commit_id":"a933ed36fd0e036be5d440525c21141b86c247f7","original_commit_id":"a933ed36fd0e036be5d440525c21141b86c247f7","user":{"login":"notmessenger","id":435544,"avatar_url":"https://avatars.githubusercontent.com/u/435544?v=3","gravatar_id":"","url":"https://api.github.com/users/notmessenger","html_url":"https://github.com/notmessenger","followers_url":"https://api.github.com/users/notmessenger/followers","following_url":"https://api.github.com/users/notmessenger/following{/other_user}","gists_url":"https://api.github.com/users/notmessenger/gists{/gist_id}","starred_url":"https://api.github.com/users/notmessenger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notmessenger/subscriptions","organizations_url":"https://api.github.com/users/notmessenger/orgs","repos_url":"https://api.github.com/users/notmessenger/repos","events_url":"https://api.github.com/users/notmessenger/events{/privacy}","received_events_url":"https://api.github.com/users/notmessenger/received_events","type":"User","site_admin":false},"body":"We talked about adding a comment to this property (which is missing) that indicates why this needs to be set.  Maybe we should consider writing a test against it as well to make sure it doesn't accidentally get removed.","created_at":"2015-07-15T16:40:05Z","updated_at":"2015-07-15T16:40:05Z","html_url":"https://github.com/softlayer/sl-ember-components/pull/406#discussion_r34699371","pull_request_url":"https://api.github.com/repos/softlayer/sl-ember-components/pulls/406","_links":{"self":{"href":"https://api.github.com/repos/softlayer/sl-ember-components/pulls/comments/34699371"},"html":{"href":"https://github.com/softlayer/sl-ember-components/pull/406#discussion_r34699371"},"pull_request":{"href":"https://api.github.com/repos/softlayer/sl-ember-components/pulls/406"}}},"pull_request":{"url":"https://api.github.com/repos/softlayer/sl-ember-components/pulls/406","id":39631928,"html_url":"https://github.com/softlayer/sl-ember-components/pull/406","diff_url":"https://github.com/softlayer/sl-ember-components/pull/406.diff","patch_url":"https://github.com/softlayer/sl-ember-components/pull/406.patch","issue_url":"https://api.github.com/repos/softlayer/sl-ember-components/issues/406","number":406,"state":"open","locked":false,"title":" Add tests for sl-chart component #207","user":{"login":"erangeles","id":13124163,"avatar_url":"https://avatars.githubusercontent.com/u/13124163?v=3","gravatar_id":"","url":"https://api.github.com/users/erangeles","html_url":"https://github.com/erangeles","followers_url":"https://api.github.com/users/erangeles/followers","following_url":"https://api.github.com/users/erangeles/following{/other_user}","gists_url":"https://api.github.com/users/erangeles/gists{/gist_id}","starred_url":"https://api.github.com/users/erangeles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erangeles/subscriptions","organizations_url":"https://api.github.com/users/erangeles/orgs","repos_url":"https://api.github.com/users/erangeles/repos","events_url":"https://api.github.com/users/erangeles/events{/privacy}","received_events_url":"https://api.github.com/users/erangeles/received_events","type":"User","site_admin":false},"body":"Hey @notmessenger had to nuke my other PR. I was accidentally pushing my develop branch instead of branching off the develop branch to issue branches. Sorry about this. ","created_at":"2015-07-09T21:45:46Z","updated_at":"2015-07-15T16:40:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4e47caac90bac72dec45e5b24c1cf7eff455333","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/softlayer/sl-ember-components/pulls/406/commits","review_comments_url":"https://api.github.com/repos/softlayer/sl-ember-components/pulls/406/comments","review_comment_url":"https://api.github.com/repos/softlayer/sl-ember-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/softlayer/sl-ember-components/issues/406/comments","statuses_url":"https://api.github.com/repos/softlayer/sl-ember-components/statuses/a933ed36fd0e036be5d440525c21141b86c247f7","head":{"label":"erangeles:issue207","ref":"issue207","sha":"a933ed36fd0e036be5d440525c21141b86c247f7","user":{"login":"erangeles","id":13124163,"avatar_url":"https://avatars.githubusercontent.com/u/13124163?v=3","gravatar_id":"","url":"https://api.github.com/users/erangeles","html_url":"https://github.com/erangeles","followers_url":"https://api.github.com/users/erangeles/followers","following_url":"https://api.github.com/users/erangeles/following{/other_user}","gists_url":"https://api.github.com/users/erangeles/gists{/gist_id}","starred_url":"https://api.github.com/users/erangeles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erangeles/subscriptions","organizations_url":"https://api.github.com/users/erangeles/orgs","repos_url":"https://api.github.com/users/erangeles/repos","events_url":"https://api.github.com/users/erangeles/events{/privacy}","received_events_url":"https://api.github.com/users/erangeles/received_events","type":"User","site_admin":false},"repo":{"id":38387528,"name":"sl-ember-components","full_name":"erangeles/sl-ember-components","owner":{"login":"erangeles","id":13124163,"avatar_url":"https://avatars.githubusercontent.com/u/13124163?v=3","gravatar_id":"","url":"https://api.github.com/users/erangeles","html_url":"https://github.com/erangeles","followers_url":"https://api.github.com/users/erangeles/followers","following_url":"https://api.github.com/users/erangeles/following{/other_user}","gists_url":"https://api.github.com/users/erangeles/gists{/gist_id}","starred_url":"https://api.github.com/users/erangeles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erangeles/subscriptions","organizations_url":"https://api.github.com/users/erangeles/orgs","repos_url":"https://api.github.com/users/erangeles/repos","events_url":"https://api.github.com/users/erangeles/events{/privacy}","received_events_url":"https://api.github.com/users/erangeles/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erangeles/sl-ember-components","description":"An Ember CLI Addon that provides a variety of UI components.","fork":true,"url":"https://api.github.com/repos/erangeles/sl-ember-components","forks_url":"https://api.github.com/repos/erangeles/sl-ember-components/forks","keys_url":"https://api.github.com/repos/erangeles/sl-ember-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erangeles/sl-ember-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erangeles/sl-ember-components/teams","hooks_url":"https://api.github.com/repos/erangeles/sl-ember-components/hooks","issue_events_url":"https://api.github.com/repos/erangeles/sl-ember-components/issues/events{/number}","events_url":"https://api.github.com/repos/erangeles/sl-ember-components/events","assignees_url":"https://api.github.com/repos/erangeles/sl-ember-components/assignees{/user}","branches_url":"https://api.github.com/repos/erangeles/sl-ember-components/branches{/branch}","tags_url":"https://api.github.com/repos/erangeles/sl-ember-components/tags","blobs_url":"https://api.github.com/repos/erangeles/sl-ember-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erangeles/sl-ember-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erangeles/sl-ember-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/erangeles/sl-ember-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erangeles/sl-ember-components/statuses/{sha}","languages_url":"https://api.github.com/repos/erangeles/sl-ember-components/languages","stargazers_url":"https://api.github.com/repos/erangeles/sl-ember-components/stargazers","contributors_url":"https://api.github.com/repos/erangeles/sl-ember-components/contributors","subscribers_url":"https://api.github.com/repos/erangeles/sl-ember-components/subscribers","subscription_url":"https://api.github.com/repos/erangeles/sl-ember-components/subscription","commits_url":"https://api.github.com/repos/erangeles/sl-ember-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/erangeles/sl-ember-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/erangeles/sl-ember-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/erangeles/sl-ember-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/erangeles/sl-ember-components/contents/{+path}","compare_url":"https://api.github.com/repos/erangeles/sl-ember-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erangeles/sl-ember-components/merges","archive_url":"https://api.github.com/repos/erangeles/sl-ember-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erangeles/sl-ember-components/downloads","issues_url":"https://api.github.com/repos/erangeles/sl-ember-components/issues{/number}","pulls_url":"https://api.github.com/repos/erangeles/sl-ember-components/pulls{/number}","milestones_url":"https://api.github.com/repos/erangeles/sl-ember-components/milestones{/number}","notifications_url":"https://api.github.com/repos/erangeles/sl-ember-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erangeles/sl-ember-components/labels{/name}","releases_url":"https://api.github.com/repos/erangeles/sl-ember-components/releases{/id}","created_at":"2015-07-01T18:22:28Z","updated_at":"2015-07-01T18:22:29Z","pushed_at":"2015-07-15T16:10:18Z","git_url":"git://github.com/erangeles/sl-ember-components.git","ssh_url":"git@github.com:erangeles/sl-ember-components.git","clone_url":"https://github.com/erangeles/sl-ember-components.git","svn_url":"https://github.com/erangeles/sl-ember-components","homepage":"http://softlayer.github.io/sl-ember-components","size":7057,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"softlayer:develop","ref":"develop","sha":"ce0812305beb8e8d7f2749ffcfa2b43c8435607d","user":{"login":"softlayer","id":49550,"avatar_url":"https://avatars.githubusercontent.com/u/49550?v=3","gravatar_id":"","url":"https://api.github.com/users/softlayer","html_url":"https://github.com/softlayer","followers_url":"https://api.github.com/users/softlayer/followers","following_url":"https://api.github.com/users/softlayer/following{/other_user}","gists_url":"https://api.github.com/users/softlayer/gists{/gist_id}","starred_url":"https://api.github.com/users/softlayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softlayer/subscriptions","organizations_url":"https://api.github.com/users/softlayer/orgs","repos_url":"https://api.github.com/users/softlayer/repos","events_url":"https://api.github.com/users/softlayer/events{/privacy}","received_events_url":"https://api.github.com/users/softlayer/received_events","type":"Organization","site_admin":false},"repo":{"id":26869437,"name":"sl-ember-components","full_name":"softlayer/sl-ember-components","owner":{"login":"softlayer","id":49550,"avatar_url":"https://avatars.githubusercontent.com/u/49550?v=3","gravatar_id":"","url":"https://api.github.com/users/softlayer","html_url":"https://github.com/softlayer","followers_url":"https://api.github.com/users/softlayer/followers","following_url":"https://api.github.com/users/softlayer/following{/other_user}","gists_url":"https://api.github.com/users/softlayer/gists{/gist_id}","starred_url":"https://api.github.com/users/softlayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softlayer/subscriptions","organizations_url":"https://api.github.com/users/softlayer/orgs","repos_url":"https://api.github.com/users/softlayer/repos","events_url":"https://api.github.com/users/softlayer/events{/privacy}","received_events_url":"https://api.github.com/users/softlayer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/softlayer/sl-ember-components","description":"An Ember CLI Addon that provides a variety of UI components.","fork":false,"url":"https://api.github.com/repos/softlayer/sl-ember-components","forks_url":"https://api.github.com/repos/softlayer/sl-ember-components/forks","keys_url":"https://api.github.com/repos/softlayer/sl-ember-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/softlayer/sl-ember-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/softlayer/sl-ember-components/teams","hooks_url":"https://api.github.com/repos/softlayer/sl-ember-components/hooks","issue_events_url":"https://api.github.com/repos/softlayer/sl-ember-components/issues/events{/number}","events_url":"https://api.github.com/repos/softlayer/sl-ember-components/events","assignees_url":"https://api.github.com/repos/softlayer/sl-ember-components/assignees{/user}","branches_url":"https://api.github.com/repos/softlayer/sl-ember-components/branches{/branch}","tags_url":"https://api.github.com/repos/softlayer/sl-ember-components/tags","blobs_url":"https://api.github.com/repos/softlayer/sl-ember-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/softlayer/sl-ember-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/softlayer/sl-ember-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/softlayer/sl-ember-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/softlayer/sl-ember-components/statuses/{sha}","languages_url":"https://api.github.com/repos/softlayer/sl-ember-components/languages","stargazers_url":"https://api.github.com/repos/softlayer/sl-ember-components/stargazers","contributors_url":"https://api.github.com/repos/softlayer/sl-ember-components/contributors","subscribers_url":"https://api.github.com/repos/softlayer/sl-ember-components/subscribers","subscription_url":"https://api.github.com/repos/softlayer/sl-ember-components/subscription","commits_url":"https://api.github.com/repos/softlayer/sl-ember-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/softlayer/sl-ember-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/softlayer/sl-ember-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/softlayer/sl-ember-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/softlayer/sl-ember-components/contents/{+path}","compare_url":"https://api.github.com/repos/softlayer/sl-ember-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/softlayer/sl-ember-components/merges","archive_url":"https://api.github.com/repos/softlayer/sl-ember-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/softlayer/sl-ember-components/downloads","issues_url":"https://api.github.com/repos/softlayer/sl-ember-components/issues{/number}","pulls_url":"https://api.github.com/repos/softlayer/sl-ember-components/pulls{/number}","milestones_url":"https://api.github.com/repos/softlayer/sl-ember-components/milestones{/number}","notifications_url":"https://api.github.com/repos/softlayer/sl-ember-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/softlayer/sl-ember-components/labels{/name}","releases_url":"https://api.github.com/repos/softlayer/sl-ember-components/releases{/id}","created_at":"2014-11-19T16:07:47Z","updated_at":"2015-07-09T04:09:17Z","pushed_at":"2015-07-15T16:13:37Z","git_url":"git://github.com/softlayer/sl-ember-components.git","ssh_url":"git@github.com:softlayer/sl-ember-components.git","clone_url":"https://github.com/softlayer/sl-ember-components.git","svn_url":"https://github.com/softlayer/sl-ember-components","homepage":"http://softlayer.github.io/sl-ember-components","size":9501,"stargazers_count":82,"watchers_count":82,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":93,"forks":19,"open_issues":93,"watchers":82,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/softlayer/sl-ember-components/pulls/406"},"html":{"href":"https://github.com/softlayer/sl-ember-components/pull/406"},"issue":{"href":"https://api.github.com/repos/softlayer/sl-ember-components/issues/406"},"comments":{"href":"https://api.github.com/repos/softlayer/sl-ember-components/issues/406/comments"},"review_comments":{"href":"https://api.github.com/repos/softlayer/sl-ember-components/pulls/406/comments"},"review_comment":{"href":"https://api.github.com/repos/softlayer/sl-ember-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/softlayer/sl-ember-components/pulls/406/commits"},"statuses":{"href":"https://api.github.com/repos/softlayer/sl-ember-components/statuses/a933ed36fd0e036be5d440525c21141b86c247f7"}}}}