{"action":"created","comment":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/comments/36349285","id":36349285,"diff_hunk":"@@ -485,3 +488,20 @@ CAMLprim value caml_sys_read_directory(value path)\n   caml_ext_table_free(&tbl, 1);\n   CAMLreturn(result);\n }\n+\n+/* Return true if the value is a filedescriptor (int) that is\n+ * (presumably) open on an interactive terminal */\n+CAMLprim value caml_sys_is_interactive(value chan)","path":"byterun/sys.c","position":26,"original_position":26,"commit_id":"53239e6e8c86d79c84939fd76cb1102ba11722d9","original_commit_id":"53239e6e8c86d79c84939fd76cb1102ba11722d9","user":{"login":"gasche","id":426238,"avatar_url":"https://avatars.githubusercontent.com/u/426238?v=3","gravatar_id":"","url":"https://api.github.com/users/gasche","html_url":"https://github.com/gasche","followers_url":"https://api.github.com/users/gasche/followers","following_url":"https://api.github.com/users/gasche/following{/other_user}","gists_url":"https://api.github.com/users/gasche/gists{/gist_id}","starred_url":"https://api.github.com/users/gasche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gasche/subscriptions","organizations_url":"https://api.github.com/users/gasche/orgs","repos_url":"https://api.github.com/users/gasche/repos","events_url":"https://api.github.com/users/gasche/events{/privacy}","received_events_url":"https://api.github.com/users/gasche/received_events","type":"User","site_admin":false},"body":"I think `caml_sys_isatty` would be a better name, but that is nitpicking.","created_at":"2015-08-05T20:22:24Z","updated_at":"2015-08-05T20:22:24Z","html_url":"https://github.com/ocaml/ocaml/pull/207#discussion_r36349285","pull_request_url":"https://api.github.com/repos/ocaml/ocaml/pulls/207","_links":{"self":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/comments/36349285"},"html":{"href":"https://github.com/ocaml/ocaml/pull/207#discussion_r36349285"},"pull_request":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/207"}}},"pull_request":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/207","id":38531466,"html_url":"https://github.com/ocaml/ocaml/pull/207","diff_url":"https://github.com/ocaml/ocaml/pull/207.diff","patch_url":"https://github.com/ocaml/ocaml/pull/207.patch","issue_url":"https://api.github.com/repos/ocaml/ocaml/issues/207","number":207,"state":"open","locked":false,"title":"very minimalistic support for colors (warnings and errors)","user":{"login":"c-cube","id":1274291,"avatar_url":"https://avatars.githubusercontent.com/u/1274291?v=3","gravatar_id":"","url":"https://api.github.com/users/c-cube","html_url":"https://github.com/c-cube","followers_url":"https://api.github.com/users/c-cube/followers","following_url":"https://api.github.com/users/c-cube/following{/other_user}","gists_url":"https://api.github.com/users/c-cube/gists{/gist_id}","starred_url":"https://api.github.com/users/c-cube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c-cube/subscriptions","organizations_url":"https://api.github.com/users/c-cube/orgs","repos_url":"https://api.github.com/users/c-cube/repos","events_url":"https://api.github.com/users/c-cube/events{/privacy}","received_events_url":"https://api.github.com/users/c-cube/received_events","type":"User","site_admin":false},"body":"The point of this PR is to poll maintainers and users, do NOT merge (yet) :-)\r\n\r\nThe idea is simple: print warnings in yellow and errors in red, as other compilers (gcc, clang for instance) do. I didn't spend a lot of time on this (no tests, a problem with `Format` which indents weirdly because of escape codes). I could use `ANSITerminal` but I'm not sure about adding dependencies to the compiler.","created_at":"2015-06-25T10:11:01Z","updated_at":"2015-08-05T20:22:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb81d110a7ba5422bd1194f7cbe059aad42626d9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ocaml/ocaml/pulls/207/commits","review_comments_url":"https://api.github.com/repos/ocaml/ocaml/pulls/207/comments","review_comment_url":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocaml/ocaml/issues/207/comments","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/53239e6e8c86d79c84939fd76cb1102ba11722d9","head":{"label":"c-cube:colors","ref":"colors","sha":"53239e6e8c86d79c84939fd76cb1102ba11722d9","user":{"login":"c-cube","id":1274291,"avatar_url":"https://avatars.githubusercontent.com/u/1274291?v=3","gravatar_id":"","url":"https://api.github.com/users/c-cube","html_url":"https://github.com/c-cube","followers_url":"https://api.github.com/users/c-cube/followers","following_url":"https://api.github.com/users/c-cube/following{/other_user}","gists_url":"https://api.github.com/users/c-cube/gists{/gist_id}","starred_url":"https://api.github.com/users/c-cube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c-cube/subscriptions","organizations_url":"https://api.github.com/users/c-cube/orgs","repos_url":"https://api.github.com/users/c-cube/repos","events_url":"https://api.github.com/users/c-cube/events{/privacy}","received_events_url":"https://api.github.com/users/c-cube/received_events","type":"User","site_admin":false},"repo":{"id":10560325,"name":"ocaml","full_name":"c-cube/ocaml","owner":{"login":"c-cube","id":1274291,"avatar_url":"https://avatars.githubusercontent.com/u/1274291?v=3","gravatar_id":"","url":"https://api.github.com/users/c-cube","html_url":"https://github.com/c-cube","followers_url":"https://api.github.com/users/c-cube/followers","following_url":"https://api.github.com/users/c-cube/following{/other_user}","gists_url":"https://api.github.com/users/c-cube/gists{/gist_id}","starred_url":"https://api.github.com/users/c-cube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c-cube/subscriptions","organizations_url":"https://api.github.com/users/c-cube/orgs","repos_url":"https://api.github.com/users/c-cube/repos","events_url":"https://api.github.com/users/c-cube/events{/privacy}","received_events_url":"https://api.github.com/users/c-cube/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/c-cube/ocaml","description":"Read-only mirror of INRIA SVN","fork":true,"url":"https://api.github.com/repos/c-cube/ocaml","forks_url":"https://api.github.com/repos/c-cube/ocaml/forks","keys_url":"https://api.github.com/repos/c-cube/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/c-cube/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/c-cube/ocaml/teams","hooks_url":"https://api.github.com/repos/c-cube/ocaml/hooks","issue_events_url":"https://api.github.com/repos/c-cube/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/c-cube/ocaml/events","assignees_url":"https://api.github.com/repos/c-cube/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/c-cube/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/c-cube/ocaml/tags","blobs_url":"https://api.github.com/repos/c-cube/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/c-cube/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/c-cube/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/c-cube/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/c-cube/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/c-cube/ocaml/languages","stargazers_url":"https://api.github.com/repos/c-cube/ocaml/stargazers","contributors_url":"https://api.github.com/repos/c-cube/ocaml/contributors","subscribers_url":"https://api.github.com/repos/c-cube/ocaml/subscribers","subscription_url":"https://api.github.com/repos/c-cube/ocaml/subscription","commits_url":"https://api.github.com/repos/c-cube/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/c-cube/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/c-cube/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/c-cube/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/c-cube/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/c-cube/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/c-cube/ocaml/merges","archive_url":"https://api.github.com/repos/c-cube/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/c-cube/ocaml/downloads","issues_url":"https://api.github.com/repos/c-cube/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/c-cube/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/c-cube/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/c-cube/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/c-cube/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/c-cube/ocaml/releases{/id}","created_at":"2013-06-07T22:55:22Z","updated_at":"2015-01-13T21:32:00Z","pushed_at":"2015-08-05T19:53:49Z","git_url":"git://github.com/c-cube/ocaml.git","ssh_url":"git@github.com:c-cube/ocaml.git","clone_url":"https://github.com/c-cube/ocaml.git","svn_url":"https://github.com/c-cube/ocaml","homepage":null,"size":101289,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"ocaml:trunk","ref":"trunk","sha":"162cbc8d1ebe3e5e59d9e121f133653f5c7a51d2","user":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars.githubusercontent.com/u/1841483?v=3","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"repo":{"id":6786166,"name":"ocaml","full_name":"ocaml/ocaml","owner":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars.githubusercontent.com/u/1841483?v=3","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocaml/ocaml","description":"Read-only mirror of INRIA SVN","fork":false,"url":"https://api.github.com/repos/ocaml/ocaml","forks_url":"https://api.github.com/repos/ocaml/ocaml/forks","keys_url":"https://api.github.com/repos/ocaml/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocaml/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocaml/ocaml/teams","hooks_url":"https://api.github.com/repos/ocaml/ocaml/hooks","issue_events_url":"https://api.github.com/repos/ocaml/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/ocaml/ocaml/events","assignees_url":"https://api.github.com/repos/ocaml/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/ocaml/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/ocaml/ocaml/tags","blobs_url":"https://api.github.com/repos/ocaml/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocaml/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocaml/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocaml/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/ocaml/ocaml/languages","stargazers_url":"https://api.github.com/repos/ocaml/ocaml/stargazers","contributors_url":"https://api.github.com/repos/ocaml/ocaml/contributors","subscribers_url":"https://api.github.com/repos/ocaml/ocaml/subscribers","subscription_url":"https://api.github.com/repos/ocaml/ocaml/subscription","commits_url":"https://api.github.com/repos/ocaml/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocaml/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocaml/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocaml/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocaml/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/ocaml/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocaml/ocaml/merges","archive_url":"https://api.github.com/repos/ocaml/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocaml/ocaml/downloads","issues_url":"https://api.github.com/repos/ocaml/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/ocaml/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/ocaml/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/ocaml/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocaml/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/ocaml/ocaml/releases{/id}","created_at":"2012-11-20T22:18:22Z","updated_at":"2015-08-04T14:14:57Z","pushed_at":"2015-08-05T19:53:50Z","git_url":"git://github.com/ocaml/ocaml.git","ssh_url":"git@github.com:ocaml/ocaml.git","clone_url":"https://github.com/ocaml/ocaml.git","svn_url":"https://github.com/ocaml/ocaml","homepage":null,"size":163877,"stargazers_count":413,"watchers_count":413,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":166,"mirror_url":null,"open_issues_count":65,"forks":166,"open_issues":65,"watchers":413,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/207"},"html":{"href":"https://github.com/ocaml/ocaml/pull/207"},"issue":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/207"},"comments":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/207/comments"},"review_comments":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/207/comments"},"review_comment":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/207/commits"},"statuses":{"href":"https://api.github.com/repos/ocaml/ocaml/statuses/53239e6e8c86d79c84939fd76cb1102ba11722d9"}}}}