{"action":"created","comment":{"url":"https://api.github.com/repos/webrtc/apprtc/pulls/comments/46954815","id":46954815,"diff_hunk":"@@ -215,18 +216,20 @@ def get_room_parameters(request, room_id, client_id, is_initiator):\n   hd = request.get('hd').lower()\n   if hd and video:\n     message = 'The \"hd\" parameter has overridden video=' + video\n-    logging.error(message)\n-    error_messages.append(message)\n+    logging.warning(message)\n+    # HTML template is UTF-8 while python defaults to unicode.","path":"src/app_engine/apprtc.py","position":15,"original_position":15,"commit_id":"28b2334f3edd422f49efb5699b9cca57b41448ee","original_commit_id":"28b2334f3edd422f49efb5699b9cca57b41448ee","user":{"login":"andresusanopinto","id":580896,"avatar_url":"https://avatars.githubusercontent.com/u/580896?v=3","gravatar_id":"","url":"https://api.github.com/users/andresusanopinto","html_url":"https://github.com/andresusanopinto","followers_url":"https://api.github.com/users/andresusanopinto/followers","following_url":"https://api.github.com/users/andresusanopinto/following{/other_user}","gists_url":"https://api.github.com/users/andresusanopinto/gists{/gist_id}","starred_url":"https://api.github.com/users/andresusanopinto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresusanopinto/subscriptions","organizations_url":"https://api.github.com/users/andresusanopinto/orgs","repos_url":"https://api.github.com/users/andresusanopinto/repos","events_url":"https://api.github.com/users/andresusanopinto/events{/privacy}","received_events_url":"https://api.github.com/users/andresusanopinto/received_events","type":"User","site_admin":false},"body":"This comment makes no sense. UTF-8 is an encoding of all the chars in unicode standard.","created_at":"2015-12-08T13:55:45Z","updated_at":"2015-12-08T13:55:45Z","html_url":"https://github.com/webrtc/apprtc/pull/228#discussion_r46954815","pull_request_url":"https://api.github.com/repos/webrtc/apprtc/pulls/228","_links":{"self":{"href":"https://api.github.com/repos/webrtc/apprtc/pulls/comments/46954815"},"html":{"href":"https://github.com/webrtc/apprtc/pull/228#discussion_r46954815"},"pull_request":{"href":"https://api.github.com/repos/webrtc/apprtc/pulls/228"}}},"pull_request":{"url":"https://api.github.com/repos/webrtc/apprtc/pulls/228","id":52844475,"html_url":"https://github.com/webrtc/apprtc/pull/228","diff_url":"https://github.com/webrtc/apprtc/pull/228.diff","patch_url":"https://github.com/webrtc/apprtc/pull/228.patch","issue_url":"https://api.github.com/repos/webrtc/apprtc/issues/228","number":228,"state":"open","locked":false,"title":"Add warningMessages function for non fatal warnings, fix encode issue","user":{"login":"KaptenJansson","id":5872605,"avatar_url":"https://avatars.githubusercontent.com/u/5872605?v=3","gravatar_id":"","url":"https://api.github.com/users/KaptenJansson","html_url":"https://github.com/KaptenJansson","followers_url":"https://api.github.com/users/KaptenJansson/followers","following_url":"https://api.github.com/users/KaptenJansson/following{/other_user}","gists_url":"https://api.github.com/users/KaptenJansson/gists{/gist_id}","starred_url":"https://api.github.com/users/KaptenJansson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KaptenJansson/subscriptions","organizations_url":"https://api.github.com/users/KaptenJansson/orgs","repos_url":"https://api.github.com/users/KaptenJansson/repos","events_url":"https://api.github.com/users/KaptenJansson/events{/privacy}","received_events_url":"https://api.github.com/users/KaptenJansson/received_events","type":"User","site_admin":false},"body":"Fixes #211 \r\n\r\n* Add warning_messages reporting functionality, both the HD + video and minre params do not have to be fatal hence making a separate message functionality for those type of messages.\r\n* The issue in #211 is that the [HTML template](https://github.com/webrtc/apprtc/blob/master/src/web_app/html/index_template.html) is UTF-8 while python uses unicode by default. This results in python appending a `u` for unicode before the string in the array `[u'string']` which does not make Javascript happy ;), it does not affect all messages though, possible due to including the URL parameter in the string.\r\n\r\nA more permanent solution would to create a wrapper that converts all incoming strings saving the use of string.encode('utf-8') on all messages to be pushed to a template. But since there were only two warning_messages to be printed and no error_messages I do not want to spend the time on it, also we might use a different templating framework in the future.\r\n\r\n ","created_at":"2015-12-07T13:31:11Z","updated_at":"2015-12-08T13:55:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3181f577e33bddc94f542186b65f59656f21f6bc","assignee":{"login":"andresusanopinto","id":580896,"avatar_url":"https://avatars.githubusercontent.com/u/580896?v=3","gravatar_id":"","url":"https://api.github.com/users/andresusanopinto","html_url":"https://github.com/andresusanopinto","followers_url":"https://api.github.com/users/andresusanopinto/followers","following_url":"https://api.github.com/users/andresusanopinto/following{/other_user}","gists_url":"https://api.github.com/users/andresusanopinto/gists{/gist_id}","starred_url":"https://api.github.com/users/andresusanopinto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresusanopinto/subscriptions","organizations_url":"https://api.github.com/users/andresusanopinto/orgs","repos_url":"https://api.github.com/users/andresusanopinto/repos","events_url":"https://api.github.com/users/andresusanopinto/events{/privacy}","received_events_url":"https://api.github.com/users/andresusanopinto/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/webrtc/apprtc/pulls/228/commits","review_comments_url":"https://api.github.com/repos/webrtc/apprtc/pulls/228/comments","review_comment_url":"https://api.github.com/repos/webrtc/apprtc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webrtc/apprtc/issues/228/comments","statuses_url":"https://api.github.com/repos/webrtc/apprtc/statuses/28b2334f3edd422f49efb5699b9cca57b41448ee","head":{"label":"webrtc:fixHDAndVideo","ref":"fixHDAndVideo","sha":"28b2334f3edd422f49efb5699b9cca57b41448ee","user":{"login":"webrtc","id":10526312,"avatar_url":"https://avatars.githubusercontent.com/u/10526312?v=3","gravatar_id":"","url":"https://api.github.com/users/webrtc","html_url":"https://github.com/webrtc","followers_url":"https://api.github.com/users/webrtc/followers","following_url":"https://api.github.com/users/webrtc/following{/other_user}","gists_url":"https://api.github.com/users/webrtc/gists{/gist_id}","starred_url":"https://api.github.com/users/webrtc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webrtc/subscriptions","organizations_url":"https://api.github.com/users/webrtc/orgs","repos_url":"https://api.github.com/users/webrtc/repos","events_url":"https://api.github.com/users/webrtc/events{/privacy}","received_events_url":"https://api.github.com/users/webrtc/received_events","type":"Organization","site_admin":false},"repo":{"id":30257092,"name":"apprtc","full_name":"webrtc/apprtc","owner":{"login":"webrtc","id":10526312,"avatar_url":"https://avatars.githubusercontent.com/u/10526312?v=3","gravatar_id":"","url":"https://api.github.com/users/webrtc","html_url":"https://github.com/webrtc","followers_url":"https://api.github.com/users/webrtc/followers","following_url":"https://api.github.com/users/webrtc/following{/other_user}","gists_url":"https://api.github.com/users/webrtc/gists{/gist_id}","starred_url":"https://api.github.com/users/webrtc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webrtc/subscriptions","organizations_url":"https://api.github.com/users/webrtc/orgs","repos_url":"https://api.github.com/users/webrtc/repos","events_url":"https://api.github.com/users/webrtc/events{/privacy}","received_events_url":"https://api.github.com/users/webrtc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webrtc/apprtc","description":"The video chat demo app based on WebRTC","fork":false,"url":"https://api.github.com/repos/webrtc/apprtc","forks_url":"https://api.github.com/repos/webrtc/apprtc/forks","keys_url":"https://api.github.com/repos/webrtc/apprtc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webrtc/apprtc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webrtc/apprtc/teams","hooks_url":"https://api.github.com/repos/webrtc/apprtc/hooks","issue_events_url":"https://api.github.com/repos/webrtc/apprtc/issues/events{/number}","events_url":"https://api.github.com/repos/webrtc/apprtc/events","assignees_url":"https://api.github.com/repos/webrtc/apprtc/assignees{/user}","branches_url":"https://api.github.com/repos/webrtc/apprtc/branches{/branch}","tags_url":"https://api.github.com/repos/webrtc/apprtc/tags","blobs_url":"https://api.github.com/repos/webrtc/apprtc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webrtc/apprtc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webrtc/apprtc/git/refs{/sha}","trees_url":"https://api.github.com/repos/webrtc/apprtc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webrtc/apprtc/statuses/{sha}","languages_url":"https://api.github.com/repos/webrtc/apprtc/languages","stargazers_url":"https://api.github.com/repos/webrtc/apprtc/stargazers","contributors_url":"https://api.github.com/repos/webrtc/apprtc/contributors","subscribers_url":"https://api.github.com/repos/webrtc/apprtc/subscribers","subscription_url":"https://api.github.com/repos/webrtc/apprtc/subscription","commits_url":"https://api.github.com/repos/webrtc/apprtc/commits{/sha}","git_commits_url":"https://api.github.com/repos/webrtc/apprtc/git/commits{/sha}","comments_url":"https://api.github.com/repos/webrtc/apprtc/comments{/number}","issue_comment_url":"https://api.github.com/repos/webrtc/apprtc/issues/comments{/number}","contents_url":"https://api.github.com/repos/webrtc/apprtc/contents/{+path}","compare_url":"https://api.github.com/repos/webrtc/apprtc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webrtc/apprtc/merges","archive_url":"https://api.github.com/repos/webrtc/apprtc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webrtc/apprtc/downloads","issues_url":"https://api.github.com/repos/webrtc/apprtc/issues{/number}","pulls_url":"https://api.github.com/repos/webrtc/apprtc/pulls{/number}","milestones_url":"https://api.github.com/repos/webrtc/apprtc/milestones{/number}","notifications_url":"https://api.github.com/repos/webrtc/apprtc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webrtc/apprtc/labels{/name}","releases_url":"https://api.github.com/repos/webrtc/apprtc/releases{/id}","created_at":"2015-02-03T18:10:41Z","updated_at":"2015-12-07T22:25:54Z","pushed_at":"2015-12-08T10:11:10Z","git_url":"git://github.com/webrtc/apprtc.git","ssh_url":"git@github.com:webrtc/apprtc.git","clone_url":"https://github.com/webrtc/apprtc.git","svn_url":"https://github.com/webrtc/apprtc","homepage":"https://appr.tc","size":4552,"stargazers_count":257,"watchers_count":257,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":145,"mirror_url":null,"open_issues_count":39,"forks":145,"open_issues":39,"watchers":257,"default_branch":"master"}},"base":{"label":"webrtc:master","ref":"master","sha":"3657ee2d244b7f0689b2ff1582841123a95e6124","user":{"login":"webrtc","id":10526312,"avatar_url":"https://avatars.githubusercontent.com/u/10526312?v=3","gravatar_id":"","url":"https://api.github.com/users/webrtc","html_url":"https://github.com/webrtc","followers_url":"https://api.github.com/users/webrtc/followers","following_url":"https://api.github.com/users/webrtc/following{/other_user}","gists_url":"https://api.github.com/users/webrtc/gists{/gist_id}","starred_url":"https://api.github.com/users/webrtc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webrtc/subscriptions","organizations_url":"https://api.github.com/users/webrtc/orgs","repos_url":"https://api.github.com/users/webrtc/repos","events_url":"https://api.github.com/users/webrtc/events{/privacy}","received_events_url":"https://api.github.com/users/webrtc/received_events","type":"Organization","site_admin":false},"repo":{"id":30257092,"name":"apprtc","full_name":"webrtc/apprtc","owner":{"login":"webrtc","id":10526312,"avatar_url":"https://avatars.githubusercontent.com/u/10526312?v=3","gravatar_id":"","url":"https://api.github.com/users/webrtc","html_url":"https://github.com/webrtc","followers_url":"https://api.github.com/users/webrtc/followers","following_url":"https://api.github.com/users/webrtc/following{/other_user}","gists_url":"https://api.github.com/users/webrtc/gists{/gist_id}","starred_url":"https://api.github.com/users/webrtc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webrtc/subscriptions","organizations_url":"https://api.github.com/users/webrtc/orgs","repos_url":"https://api.github.com/users/webrtc/repos","events_url":"https://api.github.com/users/webrtc/events{/privacy}","received_events_url":"https://api.github.com/users/webrtc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webrtc/apprtc","description":"The video chat demo app based on WebRTC","fork":false,"url":"https://api.github.com/repos/webrtc/apprtc","forks_url":"https://api.github.com/repos/webrtc/apprtc/forks","keys_url":"https://api.github.com/repos/webrtc/apprtc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webrtc/apprtc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webrtc/apprtc/teams","hooks_url":"https://api.github.com/repos/webrtc/apprtc/hooks","issue_events_url":"https://api.github.com/repos/webrtc/apprtc/issues/events{/number}","events_url":"https://api.github.com/repos/webrtc/apprtc/events","assignees_url":"https://api.github.com/repos/webrtc/apprtc/assignees{/user}","branches_url":"https://api.github.com/repos/webrtc/apprtc/branches{/branch}","tags_url":"https://api.github.com/repos/webrtc/apprtc/tags","blobs_url":"https://api.github.com/repos/webrtc/apprtc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webrtc/apprtc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webrtc/apprtc/git/refs{/sha}","trees_url":"https://api.github.com/repos/webrtc/apprtc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webrtc/apprtc/statuses/{sha}","languages_url":"https://api.github.com/repos/webrtc/apprtc/languages","stargazers_url":"https://api.github.com/repos/webrtc/apprtc/stargazers","contributors_url":"https://api.github.com/repos/webrtc/apprtc/contributors","subscribers_url":"https://api.github.com/repos/webrtc/apprtc/subscribers","subscription_url":"https://api.github.com/repos/webrtc/apprtc/subscription","commits_url":"https://api.github.com/repos/webrtc/apprtc/commits{/sha}","git_commits_url":"https://api.github.com/repos/webrtc/apprtc/git/commits{/sha}","comments_url":"https://api.github.com/repos/webrtc/apprtc/comments{/number}","issue_comment_url":"https://api.github.com/repos/webrtc/apprtc/issues/comments{/number}","contents_url":"https://api.github.com/repos/webrtc/apprtc/contents/{+path}","compare_url":"https://api.github.com/repos/webrtc/apprtc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webrtc/apprtc/merges","archive_url":"https://api.github.com/repos/webrtc/apprtc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webrtc/apprtc/downloads","issues_url":"https://api.github.com/repos/webrtc/apprtc/issues{/number}","pulls_url":"https://api.github.com/repos/webrtc/apprtc/pulls{/number}","milestones_url":"https://api.github.com/repos/webrtc/apprtc/milestones{/number}","notifications_url":"https://api.github.com/repos/webrtc/apprtc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webrtc/apprtc/labels{/name}","releases_url":"https://api.github.com/repos/webrtc/apprtc/releases{/id}","created_at":"2015-02-03T18:10:41Z","updated_at":"2015-12-07T22:25:54Z","pushed_at":"2015-12-08T10:11:10Z","git_url":"git://github.com/webrtc/apprtc.git","ssh_url":"git@github.com:webrtc/apprtc.git","clone_url":"https://github.com/webrtc/apprtc.git","svn_url":"https://github.com/webrtc/apprtc","homepage":"https://appr.tc","size":4552,"stargazers_count":257,"watchers_count":257,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":145,"mirror_url":null,"open_issues_count":39,"forks":145,"open_issues":39,"watchers":257,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webrtc/apprtc/pulls/228"},"html":{"href":"https://github.com/webrtc/apprtc/pull/228"},"issue":{"href":"https://api.github.com/repos/webrtc/apprtc/issues/228"},"comments":{"href":"https://api.github.com/repos/webrtc/apprtc/issues/228/comments"},"review_comments":{"href":"https://api.github.com/repos/webrtc/apprtc/pulls/228/comments"},"review_comment":{"href":"https://api.github.com/repos/webrtc/apprtc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webrtc/apprtc/pulls/228/commits"},"statuses":{"href":"https://api.github.com/repos/webrtc/apprtc/statuses/28b2334f3edd422f49efb5699b9cca57b41448ee"}}}}