{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5246","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5246/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5246/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5246/events","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5246","id":60515443,"number":5246,"title":"Make nodecontroller configure nodes' pod IP ranges","user":{"login":"tkulczynski","id":10222338,"avatar_url":"https://avatars.githubusercontent.com/u/10222338?v=3","gravatar_id":"","url":"https://api.github.com/users/tkulczynski","html_url":"https://github.com/tkulczynski","followers_url":"https://api.github.com/users/tkulczynski/followers","following_url":"https://api.github.com/users/tkulczynski/following{/other_user}","gists_url":"https://api.github.com/users/tkulczynski/gists{/gist_id}","starred_url":"https://api.github.com/users/tkulczynski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkulczynski/subscriptions","organizations_url":"https://api.github.com/users/tkulczynski/orgs","repos_url":"https://api.github.com/users/tkulczynski/repos","events_url":"https://api.github.com/users/tkulczynski/events{/privacy}","received_events_url":"https://api.github.com/users/tkulczynski/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"ECF7EC"}],"state":"open","locked":false,"assignee":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2015-03-10T15:15:17Z","updated_at":"2015-03-11T00:31:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5246","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5246","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5246.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5246.patch"},"body":"Moves podCIDRs assignment and routes creation in GCE from bash scripts to node controller. This is mainly to allow dynamic node set changes without complicated logic.\r\n\r\nTested: e2e tests pass, also if you manually resize up the MIG with nodes after initial cluster validation. I only tested resizing up because K8s won't handle nodes going away properly. Cluster validation verifies the number of nodes is as specified in the config (it's generally a good thing to have I believe, so didn't change it): I also made sure that validate-cluster passes after resizing the node group if you just manually set NUM_NODES to what you used for resize."},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments/78178383","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5246#issuecomment-78178383","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5246","id":78178383,"user":{"login":"tkulczynski","id":10222338,"avatar_url":"https://avatars.githubusercontent.com/u/10222338?v=3","gravatar_id":"","url":"https://api.github.com/users/tkulczynski","html_url":"https://github.com/tkulczynski","followers_url":"https://api.github.com/users/tkulczynski/followers","following_url":"https://api.github.com/users/tkulczynski/following{/other_user}","gists_url":"https://api.github.com/users/tkulczynski/gists{/gist_id}","starred_url":"https://api.github.com/users/tkulczynski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkulczynski/subscriptions","organizations_url":"https://api.github.com/users/tkulczynski/orgs","repos_url":"https://api.github.com/users/tkulczynski/repos","events_url":"https://api.github.com/users/tkulczynski/events{/privacy}","received_events_url":"https://api.github.com/users/tkulczynski/received_events","type":"User","site_admin":false},"created_at":"2015-03-11T00:31:43Z","updated_at":"2015-03-11T00:31:43Z","body":"Brian, I'll go through those docs more thoroughly tomorrow and will try to look for other places that might be impacted, but at first glance there's not much to change - networking model stays mostly the same, just the implementation changes - some other component is responsible for assigning the same IP ranges to nodes. I agree it might be worth to add a word here and there, but I haven't yet seen a sentence in the docs that is made incorrect by my change."}}