{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/pulls/comments/22416370","id":22416370,"diff_hunk":"@@ -91,34 +91,32 @@ public Object readResolve() {\n     }\n \n     /**\n+     * Delete build and its child builds.\n+     *\n+     * Child builds can be skipped if they have to be kept.\n+     *\n+     * @since TODO\n+     */\n+    @Override\n+    public void delete() throws IOException {\n+        super.delete();\n+\n+        for(MatrixRun run : getExactRuns()) {\n+            if (run.getWhyKeepLog() != null) continue;","path":"src/main/java/hudson/matrix/MatrixBuild.java","position":15,"original_position":15,"commit_id":"4e22a02287c358260fde84f6b3c5d33f480601e0","original_commit_id":"4e22a02287c358260fde84f6b3c5d33f480601e0","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"body":"I would expect that `MatrixBuild.getWhyKeepLog` would return non-null in this case, so that the whole thing is kept as a unit.","created_at":"2015-01-02T17:44:21Z","updated_at":"2015-01-02T17:44:21Z","html_url":"https://github.com/jenkinsci/matrix-project-plugin/pull/13#discussion_r22416370","pull_request_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/pulls/comments/22416370"},"html":{"href":"https://github.com/jenkinsci/matrix-project-plugin/pull/13#discussion_r22416370"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/pulls/13","id":26756070,"html_url":"https://github.com/jenkinsci/matrix-project-plugin/pull/13","diff_url":"https://github.com/jenkinsci/matrix-project-plugin/pull/13.diff","patch_url":"https://github.com/jenkinsci/matrix-project-plugin/pull/13.patch","issue_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/issues/13","number":13,"state":"open","locked":false,"title":"[FIXED JENKINS-13554] Delete configurations from MatrixBuild#delete","user":{"login":"olivergondza","id":206841,"avatar_url":"https://avatars.githubusercontent.com/u/206841?v=3","gravatar_id":"","url":"https://api.github.com/users/olivergondza","html_url":"https://github.com/olivergondza","followers_url":"https://api.github.com/users/olivergondza/followers","following_url":"https://api.github.com/users/olivergondza/following{/other_user}","gists_url":"https://api.github.com/users/olivergondza/gists{/gist_id}","starred_url":"https://api.github.com/users/olivergondza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivergondza/subscriptions","organizations_url":"https://api.github.com/users/olivergondza/orgs","repos_url":"https://api.github.com/users/olivergondza/repos","events_url":"https://api.github.com/users/olivergondza/events{/privacy}","received_events_url":"https://api.github.com/users/olivergondza/received_events","type":"User","site_admin":false},"body":"[JENKINS-13554](https://issues.jenkins-ci.org/browse/JENKINS-13554)\r\n\r\nThis removes 'Delete this Build and all configuration in this build' link and makes its behaviour the default.","created_at":"2015-01-02T12:31:33Z","updated_at":"2015-01-02T17:44:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6494410ba9c7bceb4b1591aaf686e0af3e07a5a8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/pulls/13/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/pulls/13/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/issues/13/comments","statuses_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/statuses/4e22a02287c358260fde84f6b3c5d33f480601e0","head":{"label":"olivergondza:JENKINS-13554","ref":"JENKINS-13554","sha":"4e22a02287c358260fde84f6b3c5d33f480601e0","user":{"login":"olivergondza","id":206841,"avatar_url":"https://avatars.githubusercontent.com/u/206841?v=3","gravatar_id":"","url":"https://api.github.com/users/olivergondza","html_url":"https://github.com/olivergondza","followers_url":"https://api.github.com/users/olivergondza/followers","following_url":"https://api.github.com/users/olivergondza/following{/other_user}","gists_url":"https://api.github.com/users/olivergondza/gists{/gist_id}","starred_url":"https://api.github.com/users/olivergondza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivergondza/subscriptions","organizations_url":"https://api.github.com/users/olivergondza/orgs","repos_url":"https://api.github.com/users/olivergondza/repos","events_url":"https://api.github.com/users/olivergondza/events{/privacy}","received_events_url":"https://api.github.com/users/olivergondza/received_events","type":"User","site_admin":false},"repo":{"id":26222640,"name":"matrix-project-plugin","full_name":"olivergondza/matrix-project-plugin","owner":{"login":"olivergondza","id":206841,"avatar_url":"https://avatars.githubusercontent.com/u/206841?v=3","gravatar_id":"","url":"https://api.github.com/users/olivergondza","html_url":"https://github.com/olivergondza","followers_url":"https://api.github.com/users/olivergondza/followers","following_url":"https://api.github.com/users/olivergondza/following{/other_user}","gists_url":"https://api.github.com/users/olivergondza/gists{/gist_id}","starred_url":"https://api.github.com/users/olivergondza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivergondza/subscriptions","organizations_url":"https://api.github.com/users/olivergondza/orgs","repos_url":"https://api.github.com/users/olivergondza/repos","events_url":"https://api.github.com/users/olivergondza/events{/privacy}","received_events_url":"https://api.github.com/users/olivergondza/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/olivergondza/matrix-project-plugin","description":"","fork":true,"url":"https://api.github.com/repos/olivergondza/matrix-project-plugin","forks_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/forks","keys_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/teams","hooks_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/hooks","issue_events_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/events","assignees_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/tags","blobs_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/languages","stargazers_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/stargazers","contributors_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/contributors","subscribers_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/subscribers","subscription_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/subscription","commits_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/issues/comments/{number}","contents_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/merges","archive_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/downloads","issues_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/labels{/name}","releases_url":"https://api.github.com/repos/olivergondza/matrix-project-plugin/releases{/id}","created_at":"2014-11-05T14:16:58Z","updated_at":"2014-10-14T08:47:42Z","pushed_at":"2015-01-02T12:30:13Z","git_url":"git://github.com/olivergondza/matrix-project-plugin.git","ssh_url":"git@github.com:olivergondza/matrix-project-plugin.git","clone_url":"https://github.com/olivergondza/matrix-project-plugin.git","svn_url":"https://github.com/olivergondza/matrix-project-plugin","homepage":"","size":731,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"5b4dedbc7ff05c176277c7ee09e13f1f7d397b7d","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":4489790,"name":"matrix-project-plugin","full_name":"jenkinsci/matrix-project-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/matrix-project-plugin","description":"","fork":false,"url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin","forks_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/issues/comments/{number}","contents_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/releases{/id}","created_at":"2012-05-30T01:38:16Z","updated_at":"2015-01-02T08:45:16Z","pushed_at":"2015-01-02T08:45:15Z","git_url":"git://github.com/jenkinsci/matrix-project-plugin.git","ssh_url":"git@github.com:jenkinsci/matrix-project-plugin.git","clone_url":"https://github.com/jenkinsci/matrix-project-plugin.git","svn_url":"https://github.com/jenkinsci/matrix-project-plugin","homepage":"","size":1018,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":3,"forks":11,"open_issues":3,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/pulls/13"},"html":{"href":"https://github.com/jenkinsci/matrix-project-plugin/pull/13"},"issue":{"href":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/issues/13"},"comments":{"href":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/statuses/4e22a02287c358260fde84f6b3c5d33f480601e0"}}}}