{"action":"closed","number":1859,"pull_request":{"url":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/1859","id":38997871,"html_url":"https://github.com/openmicroscopy/bioformats/pull/1859","diff_url":"https://github.com/openmicroscopy/bioformats/pull/1859.diff","patch_url":"https://github.com/openmicroscopy/bioformats/pull/1859.patch","issue_url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/1859","number":1859,"state":"closed","locked":false,"title":"C++: Fix external zlib, bzip2 and tiff to build on Windows","user":{"login":"rleigh-dundee","id":1528953,"avatar_url":"https://avatars.githubusercontent.com/u/1528953?v=3","gravatar_id":"","url":"https://api.github.com/users/rleigh-dundee","html_url":"https://github.com/rleigh-dundee","followers_url":"https://api.github.com/users/rleigh-dundee/followers","following_url":"https://api.github.com/users/rleigh-dundee/following{/other_user}","gists_url":"https://api.github.com/users/rleigh-dundee/gists{/gist_id}","starred_url":"https://api.github.com/users/rleigh-dundee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rleigh-dundee/subscriptions","organizations_url":"https://api.github.com/users/rleigh-dundee/orgs","repos_url":"https://api.github.com/users/rleigh-dundee/repos","events_url":"https://api.github.com/users/rleigh-dundee/events{/privacy}","received_events_url":"https://api.github.com/users/rleigh-dundee/received_events","type":"User","site_admin":false},"body":"- Add option to disable Qt GUI widgets and viewer; not strictly superbuild-related, but it's breaking the superbuild job due to an incompatibility between Boost and Qt versions on cod, so this will allow it to be disabled\r\n- Add helper script to drive installation for all cmake projects with both make and other build systems such as msbuild\r\n- Adapt the zlib, bzip2 and tiff external projects to use this script, and so build on Windows\r\n- Additional minor fixes to make this all work\r\n\r\n--------\r\n\r\nTesting:\r\n\r\nOn Linux, the superbuild will continue to work as in previous PRs.  The `qtgui` option can be tested by running:\r\n\r\n`cmake -Dqtgui:BOOL=OFF`\r\n\r\nand (assuming it would otherwise have built with Qt if it's available) it will now *not* build libome-qtwidgets or showinf/bf view.\r\n\r\nOn Windows, run in a temporary build dir:\r\n\r\n```\r\ncmake -G \"Visual Studio 12 2013 Win64\" -Dbioformats-superbuild:BOOL=ON -DBIOFORMATS_EP_SOURCE_CACHE:PATH=../sources /path/to/bioformats\r\n\r\ncmake --build . --target zlib --config Debug\r\ncmake --build . --target bzip2 --config Debug\r\ncmake --build . --target tiff --config Debug\r\n\r\ncmake --build . --target zlib --config Release\r\ncmake --build . --target bzip2 --config Release\r\ncmake --build . --target tiff --config Release\r\n```\r\n\r\nThe rest of the build isn't yet functional, so these targets alone are to be tested here.  Look in `superbuild-install/bin` and make sure the zlib/bzip2/tiff DLLs are present; you should have a `d` suffix for the debug versions.  Look in `superbuild-install/bin` and make sure the zlib/bzip2/tiff LIBs are present; again with a `d` suffix for the debug versions.","created_at":"2015-07-01T16:03:22Z","updated_at":"2015-07-06T13:23:55Z","closed_at":"2015-07-06T13:23:55Z","merged_at":"2015-07-06T13:23:55Z","merge_commit_sha":"fe9069a1364cf29fcdc6b9a8ca50b8f99d40831b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/1859/commits","review_comments_url":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/1859/comments","review_comment_url":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/1859/comments","statuses_url":"https://api.github.com/repos/openmicroscopy/bioformats/statuses/1da3402750dc4ee66259f264b92e9024e7ba97df","head":{"label":"rleigh-dundee:cmake-sb4","ref":"cmake-sb4","sha":"1da3402750dc4ee66259f264b92e9024e7ba97df","user":{"login":"rleigh-dundee","id":1528953,"avatar_url":"https://avatars.githubusercontent.com/u/1528953?v=3","gravatar_id":"","url":"https://api.github.com/users/rleigh-dundee","html_url":"https://github.com/rleigh-dundee","followers_url":"https://api.github.com/users/rleigh-dundee/followers","following_url":"https://api.github.com/users/rleigh-dundee/following{/other_user}","gists_url":"https://api.github.com/users/rleigh-dundee/gists{/gist_id}","starred_url":"https://api.github.com/users/rleigh-dundee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rleigh-dundee/subscriptions","organizations_url":"https://api.github.com/users/rleigh-dundee/orgs","repos_url":"https://api.github.com/users/rleigh-dundee/repos","events_url":"https://api.github.com/users/rleigh-dundee/events{/privacy}","received_events_url":"https://api.github.com/users/rleigh-dundee/received_events","type":"User","site_admin":false},"repo":{"id":3696872,"name":"bioformats","full_name":"rleigh-dundee/bioformats","owner":{"login":"rleigh-dundee","id":1528953,"avatar_url":"https://avatars.githubusercontent.com/u/1528953?v=3","gravatar_id":"","url":"https://api.github.com/users/rleigh-dundee","html_url":"https://github.com/rleigh-dundee","followers_url":"https://api.github.com/users/rleigh-dundee/followers","following_url":"https://api.github.com/users/rleigh-dundee/following{/other_user}","gists_url":"https://api.github.com/users/rleigh-dundee/gists{/gist_id}","starred_url":"https://api.github.com/users/rleigh-dundee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rleigh-dundee/subscriptions","organizations_url":"https://api.github.com/users/rleigh-dundee/orgs","repos_url":"https://api.github.com/users/rleigh-dundee/repos","events_url":"https://api.github.com/users/rleigh-dundee/events{/privacy}","received_events_url":"https://api.github.com/users/rleigh-dundee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rleigh-dundee/bioformats","description":"Bio-Formats is a Java library for reading and writing data in life sciences image file formats. It is developed by the  Open Microscopy Environment (particularly  UW-Madison LOCI and  Glencoe Software). Bio-Formats is released under the  GNU General Public License (GPL); commercial licenses are available from  Glencoe Software. ","fork":true,"url":"https://api.github.com/repos/rleigh-dundee/bioformats","forks_url":"https://api.github.com/repos/rleigh-dundee/bioformats/forks","keys_url":"https://api.github.com/repos/rleigh-dundee/bioformats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rleigh-dundee/bioformats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rleigh-dundee/bioformats/teams","hooks_url":"https://api.github.com/repos/rleigh-dundee/bioformats/hooks","issue_events_url":"https://api.github.com/repos/rleigh-dundee/bioformats/issues/events{/number}","events_url":"https://api.github.com/repos/rleigh-dundee/bioformats/events","assignees_url":"https://api.github.com/repos/rleigh-dundee/bioformats/assignees{/user}","branches_url":"https://api.github.com/repos/rleigh-dundee/bioformats/branches{/branch}","tags_url":"https://api.github.com/repos/rleigh-dundee/bioformats/tags","blobs_url":"https://api.github.com/repos/rleigh-dundee/bioformats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rleigh-dundee/bioformats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rleigh-dundee/bioformats/git/refs{/sha}","trees_url":"https://api.github.com/repos/rleigh-dundee/bioformats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rleigh-dundee/bioformats/statuses/{sha}","languages_url":"https://api.github.com/repos/rleigh-dundee/bioformats/languages","stargazers_url":"https://api.github.com/repos/rleigh-dundee/bioformats/stargazers","contributors_url":"https://api.github.com/repos/rleigh-dundee/bioformats/contributors","subscribers_url":"https://api.github.com/repos/rleigh-dundee/bioformats/subscribers","subscription_url":"https://api.github.com/repos/rleigh-dundee/bioformats/subscription","commits_url":"https://api.github.com/repos/rleigh-dundee/bioformats/commits{/sha}","git_commits_url":"https://api.github.com/repos/rleigh-dundee/bioformats/git/commits{/sha}","comments_url":"https://api.github.com/repos/rleigh-dundee/bioformats/comments{/number}","issue_comment_url":"https://api.github.com/repos/rleigh-dundee/bioformats/issues/comments{/number}","contents_url":"https://api.github.com/repos/rleigh-dundee/bioformats/contents/{+path}","compare_url":"https://api.github.com/repos/rleigh-dundee/bioformats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rleigh-dundee/bioformats/merges","archive_url":"https://api.github.com/repos/rleigh-dundee/bioformats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rleigh-dundee/bioformats/downloads","issues_url":"https://api.github.com/repos/rleigh-dundee/bioformats/issues{/number}","pulls_url":"https://api.github.com/repos/rleigh-dundee/bioformats/pulls{/number}","milestones_url":"https://api.github.com/repos/rleigh-dundee/bioformats/milestones{/number}","notifications_url":"https://api.github.com/repos/rleigh-dundee/bioformats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rleigh-dundee/bioformats/labels{/name}","releases_url":"https://api.github.com/repos/rleigh-dundee/bioformats/releases{/id}","created_at":"2012-03-12T16:05:29Z","updated_at":"2015-06-09T11:39:24Z","pushed_at":"2015-07-06T08:29:11Z","git_url":"git://github.com/rleigh-dundee/bioformats.git","ssh_url":"git@github.com:rleigh-dundee/bioformats.git","clone_url":"https://github.com/rleigh-dundee/bioformats.git","svn_url":"https://github.com/rleigh-dundee/bioformats","homepage":"http://trac.openmicroscopy.org.uk/ome/wiki/BioFormats","size":260178,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"develop"}},"base":{"label":"openmicroscopy:develop","ref":"develop","sha":"71a9eeb9bdfa1d0a0d1197eeb7f4919c6f497f1c","user":{"login":"openmicroscopy","id":975861,"avatar_url":"https://avatars.githubusercontent.com/u/975861?v=3","gravatar_id":"","url":"https://api.github.com/users/openmicroscopy","html_url":"https://github.com/openmicroscopy","followers_url":"https://api.github.com/users/openmicroscopy/followers","following_url":"https://api.github.com/users/openmicroscopy/following{/other_user}","gists_url":"https://api.github.com/users/openmicroscopy/gists{/gist_id}","starred_url":"https://api.github.com/users/openmicroscopy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmicroscopy/subscriptions","organizations_url":"https://api.github.com/users/openmicroscopy/orgs","repos_url":"https://api.github.com/users/openmicroscopy/repos","events_url":"https://api.github.com/users/openmicroscopy/events{/privacy}","received_events_url":"https://api.github.com/users/openmicroscopy/received_events","type":"Organization","site_admin":false},"repo":{"id":2510503,"name":"bioformats","full_name":"openmicroscopy/bioformats","owner":{"login":"openmicroscopy","id":975861,"avatar_url":"https://avatars.githubusercontent.com/u/975861?v=3","gravatar_id":"","url":"https://api.github.com/users/openmicroscopy","html_url":"https://github.com/openmicroscopy","followers_url":"https://api.github.com/users/openmicroscopy/followers","following_url":"https://api.github.com/users/openmicroscopy/following{/other_user}","gists_url":"https://api.github.com/users/openmicroscopy/gists{/gist_id}","starred_url":"https://api.github.com/users/openmicroscopy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmicroscopy/subscriptions","organizations_url":"https://api.github.com/users/openmicroscopy/orgs","repos_url":"https://api.github.com/users/openmicroscopy/repos","events_url":"https://api.github.com/users/openmicroscopy/events{/privacy}","received_events_url":"https://api.github.com/users/openmicroscopy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openmicroscopy/bioformats","description":"Bio-Formats is a Java library for reading and writing data in life sciences image file formats. It is developed by the  Open Microscopy Environment (particularly  UW-Madison LOCI and  Glencoe Software). Bio-Formats is released under the  GNU General Public License (GPL); commercial licenses are available from  Glencoe Software. ","fork":false,"url":"https://api.github.com/repos/openmicroscopy/bioformats","forks_url":"https://api.github.com/repos/openmicroscopy/bioformats/forks","keys_url":"https://api.github.com/repos/openmicroscopy/bioformats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openmicroscopy/bioformats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openmicroscopy/bioformats/teams","hooks_url":"https://api.github.com/repos/openmicroscopy/bioformats/hooks","issue_events_url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/events{/number}","events_url":"https://api.github.com/repos/openmicroscopy/bioformats/events","assignees_url":"https://api.github.com/repos/openmicroscopy/bioformats/assignees{/user}","branches_url":"https://api.github.com/repos/openmicroscopy/bioformats/branches{/branch}","tags_url":"https://api.github.com/repos/openmicroscopy/bioformats/tags","blobs_url":"https://api.github.com/repos/openmicroscopy/bioformats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openmicroscopy/bioformats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openmicroscopy/bioformats/git/refs{/sha}","trees_url":"https://api.github.com/repos/openmicroscopy/bioformats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openmicroscopy/bioformats/statuses/{sha}","languages_url":"https://api.github.com/repos/openmicroscopy/bioformats/languages","stargazers_url":"https://api.github.com/repos/openmicroscopy/bioformats/stargazers","contributors_url":"https://api.github.com/repos/openmicroscopy/bioformats/contributors","subscribers_url":"https://api.github.com/repos/openmicroscopy/bioformats/subscribers","subscription_url":"https://api.github.com/repos/openmicroscopy/bioformats/subscription","commits_url":"https://api.github.com/repos/openmicroscopy/bioformats/commits{/sha}","git_commits_url":"https://api.github.com/repos/openmicroscopy/bioformats/git/commits{/sha}","comments_url":"https://api.github.com/repos/openmicroscopy/bioformats/comments{/number}","issue_comment_url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/comments{/number}","contents_url":"https://api.github.com/repos/openmicroscopy/bioformats/contents/{+path}","compare_url":"https://api.github.com/repos/openmicroscopy/bioformats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openmicroscopy/bioformats/merges","archive_url":"https://api.github.com/repos/openmicroscopy/bioformats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openmicroscopy/bioformats/downloads","issues_url":"https://api.github.com/repos/openmicroscopy/bioformats/issues{/number}","pulls_url":"https://api.github.com/repos/openmicroscopy/bioformats/pulls{/number}","milestones_url":"https://api.github.com/repos/openmicroscopy/bioformats/milestones{/number}","notifications_url":"https://api.github.com/repos/openmicroscopy/bioformats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openmicroscopy/bioformats/labels{/name}","releases_url":"https://api.github.com/repos/openmicroscopy/bioformats/releases{/id}","created_at":"2011-10-04T08:06:14Z","updated_at":"2015-06-06T05:01:06Z","pushed_at":"2015-07-06T13:23:55Z","git_url":"git://github.com/openmicroscopy/bioformats.git","ssh_url":"git@github.com:openmicroscopy/bioformats.git","clone_url":"https://github.com/openmicroscopy/bioformats.git","svn_url":"https://github.com/openmicroscopy/bioformats","homepage":"http://www.openmicroscopy.org/site/products/bio-formats","size":282912,"stargazers_count":85,"watchers_count":85,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":107,"mirror_url":null,"open_issues_count":18,"forks":107,"open_issues":18,"watchers":85,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/1859"},"html":{"href":"https://github.com/openmicroscopy/bioformats/pull/1859"},"issue":{"href":"https://api.github.com/repos/openmicroscopy/bioformats/issues/1859"},"comments":{"href":"https://api.github.com/repos/openmicroscopy/bioformats/issues/1859/comments"},"review_comments":{"href":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/1859/comments"},"review_comment":{"href":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/1859/commits"},"statuses":{"href":"https://api.github.com/repos/openmicroscopy/bioformats/statuses/1da3402750dc4ee66259f264b92e9024e7ba97df"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"joshmoore","id":88113,"avatar_url":"https://avatars.githubusercontent.com/u/88113?v=3","gravatar_id":"","url":"https://api.github.com/users/joshmoore","html_url":"https://github.com/joshmoore","followers_url":"https://api.github.com/users/joshmoore/followers","following_url":"https://api.github.com/users/joshmoore/following{/other_user}","gists_url":"https://api.github.com/users/joshmoore/gists{/gist_id}","starred_url":"https://api.github.com/users/joshmoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshmoore/subscriptions","organizations_url":"https://api.github.com/users/joshmoore/orgs","repos_url":"https://api.github.com/users/joshmoore/repos","events_url":"https://api.github.com/users/joshmoore/events{/privacy}","received_events_url":"https://api.github.com/users/joshmoore/received_events","type":"User","site_admin":false},"comments":17,"review_comments":0,"commits":8,"additions":147,"deletions":16,"changed_files":11}}