{"action":"created","issue":{"url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/issues/93","labels_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/issues/93/labels{/name}","comments_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/issues/93/comments","events_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/issues/93/events","html_url":"https://github.com/Metaswitch/clearwater-snmp-handlers/pull/93","id":110207565,"number":93,"title":"[Reviewer: Andy] Fix up smilint warnings","user":{"login":"rkd-msw","id":4363492,"avatar_url":"https://avatars.githubusercontent.com/u/4363492?v=3","gravatar_id":"","url":"https://api.github.com/users/rkd-msw","html_url":"https://github.com/rkd-msw","followers_url":"https://api.github.com/users/rkd-msw/followers","following_url":"https://api.github.com/users/rkd-msw/following{/other_user}","gists_url":"https://api.github.com/users/rkd-msw/gists{/gist_id}","starred_url":"https://api.github.com/users/rkd-msw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkd-msw/subscriptions","organizations_url":"https://api.github.com/users/rkd-msw/orgs","repos_url":"https://api.github.com/users/rkd-msw/repos","events_url":"https://api.github.com/users/rkd-msw/events{/privacy}","received_events_url":"https://api.github.com/users/rkd-msw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"bossmc","id":1073983,"avatar_url":"https://avatars.githubusercontent.com/u/1073983?v=3","gravatar_id":"","url":"https://api.github.com/users/bossmc","html_url":"https://github.com/bossmc","followers_url":"https://api.github.com/users/bossmc/followers","following_url":"https://api.github.com/users/bossmc/following{/other_user}","gists_url":"https://api.github.com/users/bossmc/gists{/gist_id}","starred_url":"https://api.github.com/users/bossmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bossmc/subscriptions","organizations_url":"https://api.github.com/users/bossmc/orgs","repos_url":"https://api.github.com/users/bossmc/repos","events_url":"https://api.github.com/users/bossmc/events{/privacy}","received_events_url":"https://api.github.com/users/bossmc/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-10-07T11:45:49Z","updated_at":"2015-10-07T11:53:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/pulls/93","html_url":"https://github.com/Metaswitch/clearwater-snmp-handlers/pull/93","diff_url":"https://github.com/Metaswitch/clearwater-snmp-handlers/pull/93.diff","patch_url":"https://github.com/Metaswitch/clearwater-snmp-handlers/pull/93.patch"},"body":"Can you review this fix, to make `smilint ./PROJECT-CLEARWATER-MIB -l 5` run cleanly?\r\n\r\nIt:\r\n* fixes up some rogue commas\r\n* doesn't list inaccessible objects in astaireGroup\r\n* reworks the AstaireConnectionBucketBandwidthTable, following the guidance in http://stackoverflow.com/questions/2510211/snmp-asn-1-mib-definitions-referencing-a-table-within-a-table that nested tables should just be indexed by the parent table's index as well as their own\r\n\r\nI'll also change Jenkins to run that smilint command and fail the build if it fails."},"comment":{"url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/issues/comments/146169565","html_url":"https://github.com/Metaswitch/clearwater-snmp-handlers/pull/93#issuecomment-146169565","issue_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/issues/93","id":146169565,"user":{"login":"rkd-msw","id":4363492,"avatar_url":"https://avatars.githubusercontent.com/u/4363492?v=3","gravatar_id":"","url":"https://api.github.com/users/rkd-msw","html_url":"https://github.com/rkd-msw","followers_url":"https://api.github.com/users/rkd-msw/followers","following_url":"https://api.github.com/users/rkd-msw/following{/other_user}","gists_url":"https://api.github.com/users/rkd-msw/gists{/gist_id}","starred_url":"https://api.github.com/users/rkd-msw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkd-msw/subscriptions","organizations_url":"https://api.github.com/users/rkd-msw/orgs","repos_url":"https://api.github.com/users/rkd-msw/repos","events_url":"https://api.github.com/users/rkd-msw/events{/privacy}","received_events_url":"https://api.github.com/users/rkd-msw/received_events","type":"User","site_admin":false},"created_at":"2015-10-07T11:53:00Z","updated_at":"2015-10-07T11:53:00Z","body":"Plus a few more fixes - changing TableEntry to Entry, fixing the other warnings in #92."}}