{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/22958927","id":22958927,"diff_hunk":"@@ -225,8 +226,7 @@ func makePodSourceConfig(kc *KubeletConfig) *config.PodConfig {\n \t\tglog.Infof(\"Adding manifest url: %v\", kc.ManifestURL)\n \t\tconfig.NewSourceURL(kc.ManifestURL, kc.HttpCheckFrequency, cfg.Channel(kubelet.HTTPSource))\n \t}\n-\n-\tif kc.EtcdClient != nil {\n+\tif !reflect.ValueOf(kc.EtcdClient).IsNil() {","path":"pkg/standalone/standalone.go","position":14,"original_position":14,"commit_id":"6e6f465a3699ffc080628310694810ad04c7d498","original_commit_id":"6e6f465a3699ffc080628310694810ad04c7d498","user":{"login":"filbranden","id":106037,"avatar_url":"https://avatars.githubusercontent.com/u/106037?v=3","gravatar_id":"","url":"https://api.github.com/users/filbranden","html_url":"https://github.com/filbranden","followers_url":"https://api.github.com/users/filbranden/followers","following_url":"https://api.github.com/users/filbranden/following{/other_user}","gists_url":"https://api.github.com/users/filbranden/gists{/gist_id}","starred_url":"https://api.github.com/users/filbranden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filbranden/subscriptions","organizations_url":"https://api.github.com/users/filbranden/orgs","repos_url":"https://api.github.com/users/filbranden/repos","events_url":"https://api.github.com/users/filbranden/events{/privacy}","received_events_url":"https://api.github.com/users/filbranden/received_events","type":"User","site_admin":false},"body":"Sure that makes sense.\r\n\r\nThough, if you ask me, it doesn't make sense to have an interface `(*<anytype>, nil) != nil` since the bug of returning a type and assigning it to an interface making nil become non-nil is also subtle.\r\n\r\nI'll send a PR to undo this use of `reflect` and return the interface from `kubelet.EtcdClientOrDie()`.\r\n\r\nCheers,\r\nFilipe\r\n","created_at":"2015-01-14T18:44:27Z","updated_at":"2015-01-14T18:44:27Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/3356#discussion_r22958927","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/3356","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/22958927"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/3356#discussion_r22958927"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/3356"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/3356","id":27091199,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/3356","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/3356.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/3356.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/3356","number":3356,"state":"closed","locked":false,"title":"Fix a crash for kubelet when without EtcdClient.","user":{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false},"body":"The crash is found when we build containervm-image in both release-7.3 and release-8.0. The root cause is trying to comparing the interface EtcdClient which contains a nil value to nil. @brendandburns @filbranden \r\n\r\nI0109 00:01:24.542892    2377 util.go:65] Connecting to docker on\r\nunix:///var/run/docker.sock\r\nI0109 00:01:24.542951    2377 util.go:178] No api servers specified.\r\npanic: runtime error: invalid memory address or nil pointer dereference\r\n[signal 0xb code=0x1 addr=0x50 pc=0x59b415]\r\n\r\ngoroutine 16 [running]:\r\nruntime.panic(0x9bbd40, 0xdd5d73)\r\n        /usr/local/go/src/pkg/runtime/panic.c:279 +0xf5\r\ngithub.com/coreos/go-etcd/etcd.(*Client).GetCluster(0x0, 0x65,\r\n0x4a817c800, 0xc208004600)\r\n        /tmp/builderOIYgM8/bootstrap-vz/assets/vendor/src/github.com/GoogleCloudPlatform/kubernetes/Godeps/_workspace/src/github.com/coreos/go-etcd/etcd/client.go:284\r\n+0x5\r\ngithub.com/GoogleCloudPlatform/kubernetes/pkg/standalone.makePodSourceConfig(0xc2080857a0,\r\n0x10)\r\n        /tmp/builderOIYgM8/bootstrap-vz/assets/vendor/src/github.com/GoogleCloudPlatform/kubernetes/_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/pkg/standalone/standalone.go:217\r\n+0x15a\r\ngithub.com/GoogleCloudPlatform/kubernetes/pkg/standalone.RunKubelet(0xc2080857a0)\r\n        /tmp/builderOIYgM8/bootstrap-vz/assets/vendor/src/github.com/GoogleCloudPlatform/kubernetes/_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/pkg/standalone/standalone.go:178\r\n+0xf3\r\nmain.main()\r\n        /tmp/builderOIYgM8/bootstrap-vz/assets/vendor/src/github.com/GoogleCloudPlatform/kubernetes/_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/cmd/kubelet/kubelet.go:121\r\n+0x41c\r\n","created_at":"2015-01-09T10:27:16Z","updated_at":"2015-01-14T18:44:27Z","closed_at":"2015-01-09T17:16:00Z","merged_at":"2015-01-09T17:16:00Z","merge_commit_sha":"8826b1ace5d91652c61157fd3c2964ca56db3eef","assignee":{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/3356/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/3356/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/{number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/3356/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/6e6f465a3699ffc080628310694810ad04c7d498","head":{"label":"dchen1107:image","ref":"image","sha":"6e6f465a3699ffc080628310694810ad04c7d498","user":{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false},"repo":{"id":21153738,"name":"kubernetes-1","full_name":"dchen1107/kubernetes-1","owner":{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dchen1107/kubernetes-1","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/dchen1107/kubernetes-1","forks_url":"https://api.github.com/repos/dchen1107/kubernetes-1/forks","keys_url":"https://api.github.com/repos/dchen1107/kubernetes-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dchen1107/kubernetes-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dchen1107/kubernetes-1/teams","hooks_url":"https://api.github.com/repos/dchen1107/kubernetes-1/hooks","issue_events_url":"https://api.github.com/repos/dchen1107/kubernetes-1/issues/events{/number}","events_url":"https://api.github.com/repos/dchen1107/kubernetes-1/events","assignees_url":"https://api.github.com/repos/dchen1107/kubernetes-1/assignees{/user}","branches_url":"https://api.github.com/repos/dchen1107/kubernetes-1/branches{/branch}","tags_url":"https://api.github.com/repos/dchen1107/kubernetes-1/tags","blobs_url":"https://api.github.com/repos/dchen1107/kubernetes-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dchen1107/kubernetes-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dchen1107/kubernetes-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/dchen1107/kubernetes-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dchen1107/kubernetes-1/statuses/{sha}","languages_url":"https://api.github.com/repos/dchen1107/kubernetes-1/languages","stargazers_url":"https://api.github.com/repos/dchen1107/kubernetes-1/stargazers","contributors_url":"https://api.github.com/repos/dchen1107/kubernetes-1/contributors","subscribers_url":"https://api.github.com/repos/dchen1107/kubernetes-1/subscribers","subscription_url":"https://api.github.com/repos/dchen1107/kubernetes-1/subscription","commits_url":"https://api.github.com/repos/dchen1107/kubernetes-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/dchen1107/kubernetes-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/dchen1107/kubernetes-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/dchen1107/kubernetes-1/issues/comments/{number}","contents_url":"https://api.github.com/repos/dchen1107/kubernetes-1/contents/{+path}","compare_url":"https://api.github.com/repos/dchen1107/kubernetes-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dchen1107/kubernetes-1/merges","archive_url":"https://api.github.com/repos/dchen1107/kubernetes-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dchen1107/kubernetes-1/downloads","issues_url":"https://api.github.com/repos/dchen1107/kubernetes-1/issues{/number}","pulls_url":"https://api.github.com/repos/dchen1107/kubernetes-1/pulls{/number}","milestones_url":"https://api.github.com/repos/dchen1107/kubernetes-1/milestones{/number}","notifications_url":"https://api.github.com/repos/dchen1107/kubernetes-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dchen1107/kubernetes-1/labels{/name}","releases_url":"https://api.github.com/repos/dchen1107/kubernetes-1/releases{/id}","created_at":"2014-06-24T05:53:16Z","updated_at":"2014-12-20T01:19:32Z","pushed_at":"2015-01-14T17:43:28Z","git_url":"git://github.com/dchen1107/kubernetes-1.git","ssh_url":"git@github.com:dchen1107/kubernetes-1.git","clone_url":"https://github.com/dchen1107/kubernetes-1.git","svn_url":"https://github.com/dchen1107/kubernetes-1","homepage":null,"size":23870,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"da8dc5360e5f9901a70d38e9cee8164338bbb314","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments/{number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-01-14T18:30:46Z","pushed_at":"2015-01-14T18:41:37Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":null,"size":55333,"stargazers_count":5756,"watchers_count":5756,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":923,"mirror_url":null,"open_issues_count":558,"forks":923,"open_issues":558,"watchers":5756,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/3356"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/3356"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/3356"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/3356/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/3356/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/3356/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/6e6f465a3699ffc080628310694810ad04c7d498"}}}}