{"action":"created","issue":{"url":"https://api.github.com/repos/mailvelope/mailvelope/issues/310","labels_url":"https://api.github.com/repos/mailvelope/mailvelope/issues/310/labels{/name}","comments_url":"https://api.github.com/repos/mailvelope/mailvelope/issues/310/comments","events_url":"https://api.github.com/repos/mailvelope/mailvelope/issues/310/events","html_url":"https://github.com/mailvelope/mailvelope/issues/310","id":70062198,"number":310,"title":"[VULNERABILITY] Encryption Disables Signing","user":{"login":"nixiepixel","id":10353016,"avatar_url":"https://avatars.githubusercontent.com/u/10353016?v=3","gravatar_id":"","url":"https://api.github.com/users/nixiepixel","html_url":"https://github.com/nixiepixel","followers_url":"https://api.github.com/users/nixiepixel/followers","following_url":"https://api.github.com/users/nixiepixel/following{/other_user}","gists_url":"https://api.github.com/users/nixiepixel/gists{/gist_id}","starred_url":"https://api.github.com/users/nixiepixel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nixiepixel/subscriptions","organizations_url":"https://api.github.com/users/nixiepixel/orgs","repos_url":"https://api.github.com/users/nixiepixel/repos","events_url":"https://api.github.com/users/nixiepixel/events{/privacy}","received_events_url":"https://api.github.com/users/nixiepixel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-04-22T08:45:35Z","updated_at":"2015-04-23T04:27:43Z","closed_at":null,"body":"#### Exploit Scenario\r\nThe UI will cause user to unknowingly send an unsigned message, allowing an attacker to modify the message in transit.\r\n\r\n#### Details\r\nWhen clicking the \"Encrypt\" button the \"Sign\" button disappears. This causes a user to believe the message is protected when it is not. There's no way for the user to know what cryptographic operations have taken place. This form of vulnerability is described in [CWE-655: Insufficient Psychological Acceptability](https://cwe.mitre.org/data/definitions/655.html).\r\n\r\n**This is a serious security issue**, with multiple unresolved feature requests (#183 and #184) and a branch ([sign_and_encrypt](https://github.com/mailvelope/mailvelope/tree/sign_and_encrypt)) with this feature which is now over a year old.\r\n\r\nConfidentiality without integrity is like cookies without milk.  ;-)\r\n\r\n\r\n#### Reproduction\r\nFirefox Plugin 0.12.1 - Latest available as of Apr. 9, 2015\r\n\r\nBefore clicking Encrypt\r\n![screen shot 2015-04-22 at 1 02 31 am](https://cloud.githubusercontent.com/assets/10353016/7269767/8bc6e6bc-e88b-11e4-84dc-196c342ed45d.png)\r\n\r\nAfter encrypting, no option to sign - only transfer\r\n![screen shot 2015-04-22 at 1 03 12 am](https://cloud.githubusercontent.com/assets/10353016/7269769/90ef8d7e-e88b-11e4-8b16-8691bebd0589.png)\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/mailvelope/mailvelope/issues/comments/95426981","html_url":"https://github.com/mailvelope/mailvelope/issues/310#issuecomment-95426981","issue_url":"https://api.github.com/repos/mailvelope/mailvelope/issues/310","id":95426981,"user":{"login":"safaci2000","id":62894,"avatar_url":"https://avatars.githubusercontent.com/u/62894?v=3","gravatar_id":"","url":"https://api.github.com/users/safaci2000","html_url":"https://github.com/safaci2000","followers_url":"https://api.github.com/users/safaci2000/followers","following_url":"https://api.github.com/users/safaci2000/following{/other_user}","gists_url":"https://api.github.com/users/safaci2000/gists{/gist_id}","starred_url":"https://api.github.com/users/safaci2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/safaci2000/subscriptions","organizations_url":"https://api.github.com/users/safaci2000/orgs","repos_url":"https://api.github.com/users/safaci2000/repos","events_url":"https://api.github.com/users/safaci2000/events{/privacy}","received_events_url":"https://api.github.com/users/safaci2000/received_events","type":"User","site_admin":false},"created_at":"2015-04-23T04:27:43Z","updated_at":"2015-04-23T04:27:43Z","body":"I was trying to read over the RFC, I think I understand why the UI behaves the way it does, but it would be nice if we can make it obvious that encryption + signature which is essentially what is needed for full trust to be established.   signature ensures integrity of the payload, and encryption ensures the privacy from prying eyes.\r\n\r\nIt would be nice to properly convey that full security is not yet implemented.  Maybe something as simple as adding a grayed out UI button for sign & encrypt. \r\n\r\nThough if the issue is coming soon (issue #184 ) then this might be a moot point.  \r\n\r\nJust my 2 cents. \r\n"}}