{"action":"created","comment":{"url":"https://api.github.com/repos/atom/notifications/pulls/comments/44094131","id":44094131,"diff_hunk":"@@ -190,6 +190,8 @@ class NotificationIssue\n           return packName unless /^\\.\\./.test(relativePath)\n       @getPackageNameFromFilePath(filePath)\n \n+    return options.packageName if options.packageName?","path":"lib/notification-issue.coffee","position":18,"original_position":18,"commit_id":"7db06a611acbbe02df2c284bec7f9fb6cdb54dae","original_commit_id":"7db06a611acbbe02df2c284bec7f9fb6cdb54dae","user":{"login":"benogle","id":69169,"avatar_url":"https://avatars.githubusercontent.com/u/69169?v=3","gravatar_id":"","url":"https://api.github.com/users/benogle","html_url":"https://github.com/benogle","followers_url":"https://api.github.com/users/benogle/followers","following_url":"https://api.github.com/users/benogle/following{/other_user}","gists_url":"https://api.github.com/users/benogle/gists{/gist_id}","starred_url":"https://api.github.com/users/benogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benogle/subscriptions","organizations_url":"https://api.github.com/users/benogle/orgs","repos_url":"https://api.github.com/users/benogle/repos","events_url":"https://api.github.com/users/benogle/events{/privacy}","received_events_url":"https://api.github.com/users/benogle/received_events","type":"User","site_admin":true},"body":"Seems like this could be returned at the top of this method? Like line 178?","created_at":"2015-11-06T01:26:14Z","updated_at":"2015-11-06T01:26:14Z","html_url":"https://github.com/atom/notifications/pull/100#discussion_r44094131","pull_request_url":"https://api.github.com/repos/atom/notifications/pulls/100","_links":{"self":{"href":"https://api.github.com/repos/atom/notifications/pulls/comments/44094131"},"html":{"href":"https://github.com/atom/notifications/pull/100#discussion_r44094131"},"pull_request":{"href":"https://api.github.com/repos/atom/notifications/pulls/100"}}},"pull_request":{"url":"https://api.github.com/repos/atom/notifications/pulls/100","id":49610192,"html_url":"https://github.com/atom/notifications/pull/100","diff_url":"https://github.com/atom/notifications/pull/100.diff","patch_url":"https://github.com/atom/notifications/pull/100.patch","issue_url":"https://api.github.com/repos/atom/notifications/issues/100","number":100,"state":"open","locked":false,"title":"Fix some package detections","user":{"login":"50Wliu","id":2766036,"avatar_url":"https://avatars.githubusercontent.com/u/2766036?v=3","gravatar_id":"","url":"https://api.github.com/users/50Wliu","html_url":"https://github.com/50Wliu","followers_url":"https://api.github.com/users/50Wliu/followers","following_url":"https://api.github.com/users/50Wliu/following{/other_user}","gists_url":"https://api.github.com/users/50Wliu/gists{/gist_id}","starred_url":"https://api.github.com/users/50Wliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/50Wliu/subscriptions","organizations_url":"https://api.github.com/users/50Wliu/orgs","repos_url":"https://api.github.com/users/50Wliu/repos","events_url":"https://api.github.com/users/50Wliu/events{/privacy}","received_events_url":"https://api.github.com/users/50Wliu/received_events","type":"User","site_admin":false},"body":":warning: Sorta-kinda depends on atom/atom#9440, which has not been released yet :warning:\r\n\r\nThis fixes the following scenarios:\r\n* A package fails to load and throws a \"Failed to load the \\<package\\> package\" error\r\n* A package fails to activate and throws a \"Failed to activate the \\<package\\> package\" error\r\n* A grammar fails to load and throws a \"Failed to load a \\<package\\> package grammar\" error\r\n* A package that has been `apm link`ed on a Windows machine throws an error\r\n\r\nAll of those would previously fail to find the correct package to report the issue to and so they were all dumped to atom/atom.\r\n\r\nRefs #66\r\nFixes #98","created_at":"2015-11-03T20:52:46Z","updated_at":"2015-11-06T01:26:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47cde87b2dd50c0528aa03603181e919eb1afd22","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/atom/notifications/pulls/100/commits","review_comments_url":"https://api.github.com/repos/atom/notifications/pulls/100/comments","review_comment_url":"https://api.github.com/repos/atom/notifications/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atom/notifications/issues/100/comments","statuses_url":"https://api.github.com/repos/atom/notifications/statuses/7db06a611acbbe02df2c284bec7f9fb6cdb54dae","head":{"label":"atom:wl-fix-package-detections","ref":"wl-fix-package-detections","sha":"7db06a611acbbe02df2c284bec7f9fb6cdb54dae","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":26663491,"name":"notifications","full_name":"atom/notifications","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/notifications","description":"User notifications","fork":false,"url":"https://api.github.com/repos/atom/notifications","forks_url":"https://api.github.com/repos/atom/notifications/forks","keys_url":"https://api.github.com/repos/atom/notifications/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/notifications/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/notifications/teams","hooks_url":"https://api.github.com/repos/atom/notifications/hooks","issue_events_url":"https://api.github.com/repos/atom/notifications/issues/events{/number}","events_url":"https://api.github.com/repos/atom/notifications/events","assignees_url":"https://api.github.com/repos/atom/notifications/assignees{/user}","branches_url":"https://api.github.com/repos/atom/notifications/branches{/branch}","tags_url":"https://api.github.com/repos/atom/notifications/tags","blobs_url":"https://api.github.com/repos/atom/notifications/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/notifications/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/notifications/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/notifications/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/notifications/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/notifications/languages","stargazers_url":"https://api.github.com/repos/atom/notifications/stargazers","contributors_url":"https://api.github.com/repos/atom/notifications/contributors","subscribers_url":"https://api.github.com/repos/atom/notifications/subscribers","subscription_url":"https://api.github.com/repos/atom/notifications/subscription","commits_url":"https://api.github.com/repos/atom/notifications/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/notifications/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/notifications/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/notifications/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/notifications/contents/{+path}","compare_url":"https://api.github.com/repos/atom/notifications/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/notifications/merges","archive_url":"https://api.github.com/repos/atom/notifications/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/notifications/downloads","issues_url":"https://api.github.com/repos/atom/notifications/issues{/number}","pulls_url":"https://api.github.com/repos/atom/notifications/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/notifications/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/notifications/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/notifications/labels{/name}","releases_url":"https://api.github.com/repos/atom/notifications/releases{/id}","created_at":"2014-11-15T00:18:37Z","updated_at":"2015-11-05T20:26:23Z","pushed_at":"2015-11-04T21:41:06Z","git_url":"git://github.com/atom/notifications.git","ssh_url":"git@github.com:atom/notifications.git","clone_url":"https://github.com/atom/notifications.git","svn_url":"https://github.com/atom/notifications","homepage":"","size":1195,"stargazers_count":41,"watchers_count":41,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":24,"forks":11,"open_issues":24,"watchers":41,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"973b4977674d44a5f552f9bdee10f80fba8609d5","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":26663491,"name":"notifications","full_name":"atom/notifications","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/notifications","description":"User notifications","fork":false,"url":"https://api.github.com/repos/atom/notifications","forks_url":"https://api.github.com/repos/atom/notifications/forks","keys_url":"https://api.github.com/repos/atom/notifications/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/notifications/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/notifications/teams","hooks_url":"https://api.github.com/repos/atom/notifications/hooks","issue_events_url":"https://api.github.com/repos/atom/notifications/issues/events{/number}","events_url":"https://api.github.com/repos/atom/notifications/events","assignees_url":"https://api.github.com/repos/atom/notifications/assignees{/user}","branches_url":"https://api.github.com/repos/atom/notifications/branches{/branch}","tags_url":"https://api.github.com/repos/atom/notifications/tags","blobs_url":"https://api.github.com/repos/atom/notifications/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/notifications/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/notifications/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/notifications/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/notifications/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/notifications/languages","stargazers_url":"https://api.github.com/repos/atom/notifications/stargazers","contributors_url":"https://api.github.com/repos/atom/notifications/contributors","subscribers_url":"https://api.github.com/repos/atom/notifications/subscribers","subscription_url":"https://api.github.com/repos/atom/notifications/subscription","commits_url":"https://api.github.com/repos/atom/notifications/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/notifications/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/notifications/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/notifications/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/notifications/contents/{+path}","compare_url":"https://api.github.com/repos/atom/notifications/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/notifications/merges","archive_url":"https://api.github.com/repos/atom/notifications/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/notifications/downloads","issues_url":"https://api.github.com/repos/atom/notifications/issues{/number}","pulls_url":"https://api.github.com/repos/atom/notifications/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/notifications/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/notifications/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/notifications/labels{/name}","releases_url":"https://api.github.com/repos/atom/notifications/releases{/id}","created_at":"2014-11-15T00:18:37Z","updated_at":"2015-11-05T20:26:23Z","pushed_at":"2015-11-04T21:41:06Z","git_url":"git://github.com/atom/notifications.git","ssh_url":"git@github.com:atom/notifications.git","clone_url":"https://github.com/atom/notifications.git","svn_url":"https://github.com/atom/notifications","homepage":"","size":1195,"stargazers_count":41,"watchers_count":41,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":24,"forks":11,"open_issues":24,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/notifications/pulls/100"},"html":{"href":"https://github.com/atom/notifications/pull/100"},"issue":{"href":"https://api.github.com/repos/atom/notifications/issues/100"},"comments":{"href":"https://api.github.com/repos/atom/notifications/issues/100/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/notifications/pulls/100/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/notifications/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atom/notifications/pulls/100/commits"},"statuses":{"href":"https://api.github.com/repos/atom/notifications/statuses/7db06a611acbbe02df2c284bec7f9fb6cdb54dae"}}}}