{"action":"created","comment":{"url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/pulls/comments/41574927","id":41574927,"diff_hunk":"@@ -69,14 +69,21 @@ def generate_actions(self, sg_publish_data, actions, ui_area):\n                       \"Actions: %s. Publish Data: %s\" % (ui_area, actions, sg_publish_data))\n         \n         action_instances = []\n+\n+        simple_framework = self.load_framework(self._FRAMEWORK_SIMPLE_NAME)\n+        utils = simple_framework.import_module(\"utils\")\n+\n+        are_deprecated_actions_disabled = app.get_setting(\"disable_deprecated_files_actions\", False)\n+        are_actions_disabled = (are_deprecated_actions_disabled and","path":"hooks/maya/loader_actions_abc.py","position":9,"original_position":9,"commit_id":"0e3c7c6cfb3d4f5cdc9be398dbb5c8ba05e06723","original_commit_id":"0e3c7c6cfb3d4f5cdc9be398dbb5c8ba05e06723","user":{"login":"josh-t","id":2604646,"avatar_url":"https://avatars.githubusercontent.com/u/2604646?v=3","gravatar_id":"","url":"https://api.github.com/users/josh-t","html_url":"https://github.com/josh-t","followers_url":"https://api.github.com/users/josh-t/followers","following_url":"https://api.github.com/users/josh-t/following{/other_user}","gists_url":"https://api.github.com/users/josh-t/gists{/gist_id}","starred_url":"https://api.github.com/users/josh-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josh-t/subscriptions","organizations_url":"https://api.github.com/users/josh-t/orgs","repos_url":"https://api.github.com/users/josh-t/repos","events_url":"https://api.github.com/users/josh-t/events{/privacy}","received_events_url":"https://api.github.com/users/josh-t/received_events","type":"User","site_admin":false},"body":"The `are_` prefix seems unnecessary here. It also reads strangely in the code IMO.","created_at":"2015-10-08T22:00:44Z","updated_at":"2015-10-08T22:00:44Z","html_url":"https://github.com/shotgunsoftware/tk-framework-simple/pull/3#discussion_r41574927","pull_request_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/pulls/comments/41574927"},"html":{"href":"https://github.com/shotgunsoftware/tk-framework-simple/pull/3#discussion_r41574927"},"pull_request":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/pulls/3","id":46322367,"html_url":"https://github.com/shotgunsoftware/tk-framework-simple/pull/3","diff_url":"https://github.com/shotgunsoftware/tk-framework-simple/pull/3.diff","patch_url":"https://github.com/shotgunsoftware/tk-framework-simple/pull/3.patch","issue_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/issues/3","number":3,"state":"open","locked":false,"title":"#14 Setting to Disable Actions on Deprecated Files","user":{"login":"jesseemond-adsk","id":14185921,"avatar_url":"https://avatars.githubusercontent.com/u/14185921?v=3","gravatar_id":"","url":"https://api.github.com/users/jesseemond-adsk","html_url":"https://github.com/jesseemond-adsk","followers_url":"https://api.github.com/users/jesseemond-adsk/followers","following_url":"https://api.github.com/users/jesseemond-adsk/following{/other_user}","gists_url":"https://api.github.com/users/jesseemond-adsk/gists{/gist_id}","starred_url":"https://api.github.com/users/jesseemond-adsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesseemond-adsk/subscriptions","organizations_url":"https://api.github.com/users/jesseemond-adsk/orgs","repos_url":"https://api.github.com/users/jesseemond-adsk/repos","events_url":"https://api.github.com/users/jesseemond-adsk/events{/privacy}","received_events_url":"https://api.github.com/users/jesseemond-adsk/received_events","type":"User","site_admin":false},"body":"Checks the `disable_deprecated_files_actions` boolean setting to see if we should hide import/reference actions on deprecated assets. This setting will be accordingly added to the loader's `info.yml` (on a future PR on jesseemond-adsk/tk-multi-loader2).\r\n\r\nMinor:\r\n- modifications to `filter_out_deprecated.py` are minor (making it *PEP8* compliant).\r\n\r\nQuestions:\r\n- I wonder if there is a cleaner way to import the framework `utils` module.. Duplicating that code doesn't feel right. Ideas?","created_at":"2015-09-29T19:42:53Z","updated_at":"2015-10-08T22:00:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46eca6f9b409b976fe2f5e8a6b6bd3755b8a5c5c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/pulls/3/commits","review_comments_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/pulls/3/comments","review_comment_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/issues/3/comments","statuses_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/statuses/0e3c7c6cfb3d4f5cdc9be398dbb5c8ba05e06723","head":{"label":"shotgunsoftware:disable_actions_on_deprecated","ref":"disable_actions_on_deprecated","sha":"0e3c7c6cfb3d4f5cdc9be398dbb5c8ba05e06723","user":{"login":"shotgunsoftware","id":317894,"avatar_url":"https://avatars.githubusercontent.com/u/317894?v=3","gravatar_id":"","url":"https://api.github.com/users/shotgunsoftware","html_url":"https://github.com/shotgunsoftware","followers_url":"https://api.github.com/users/shotgunsoftware/followers","following_url":"https://api.github.com/users/shotgunsoftware/following{/other_user}","gists_url":"https://api.github.com/users/shotgunsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/shotgunsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shotgunsoftware/subscriptions","organizations_url":"https://api.github.com/users/shotgunsoftware/orgs","repos_url":"https://api.github.com/users/shotgunsoftware/repos","events_url":"https://api.github.com/users/shotgunsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/shotgunsoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":42958533,"name":"tk-framework-simple","full_name":"shotgunsoftware/tk-framework-simple","owner":{"login":"shotgunsoftware","id":317894,"avatar_url":"https://avatars.githubusercontent.com/u/317894?v=3","gravatar_id":"","url":"https://api.github.com/users/shotgunsoftware","html_url":"https://github.com/shotgunsoftware","followers_url":"https://api.github.com/users/shotgunsoftware/followers","following_url":"https://api.github.com/users/shotgunsoftware/following{/other_user}","gists_url":"https://api.github.com/users/shotgunsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/shotgunsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shotgunsoftware/subscriptions","organizations_url":"https://api.github.com/users/shotgunsoftware/orgs","repos_url":"https://api.github.com/users/shotgunsoftware/repos","events_url":"https://api.github.com/users/shotgunsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/shotgunsoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shotgunsoftware/tk-framework-simple","description":"","fork":false,"url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple","forks_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/forks","keys_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/teams","hooks_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/hooks","issue_events_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/issues/events{/number}","events_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/events","assignees_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/assignees{/user}","branches_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/branches{/branch}","tags_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/tags","blobs_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/git/refs{/sha}","trees_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/statuses/{sha}","languages_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/languages","stargazers_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/stargazers","contributors_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/contributors","subscribers_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/subscribers","subscription_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/subscription","commits_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/commits{/sha}","git_commits_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/git/commits{/sha}","comments_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/comments{/number}","issue_comment_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/issues/comments{/number}","contents_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/contents/{+path}","compare_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/merges","archive_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/downloads","issues_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/issues{/number}","pulls_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/pulls{/number}","milestones_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/milestones{/number}","notifications_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/labels{/name}","releases_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/releases{/id}","created_at":"2015-09-22T20:18:29Z","updated_at":"2015-09-22T20:21:09Z","pushed_at":"2015-10-08T14:32:18Z","git_url":"git://github.com/shotgunsoftware/tk-framework-simple.git","ssh_url":"git@github.com:shotgunsoftware/tk-framework-simple.git","clone_url":"https://github.com/shotgunsoftware/tk-framework-simple.git","svn_url":"https://github.com/shotgunsoftware/tk-framework-simple","homepage":null,"size":288,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"shotgunsoftware:master","ref":"master","sha":"5a50cbb1bce0b129f9080c5d827e6a0869f94fc1","user":{"login":"shotgunsoftware","id":317894,"avatar_url":"https://avatars.githubusercontent.com/u/317894?v=3","gravatar_id":"","url":"https://api.github.com/users/shotgunsoftware","html_url":"https://github.com/shotgunsoftware","followers_url":"https://api.github.com/users/shotgunsoftware/followers","following_url":"https://api.github.com/users/shotgunsoftware/following{/other_user}","gists_url":"https://api.github.com/users/shotgunsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/shotgunsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shotgunsoftware/subscriptions","organizations_url":"https://api.github.com/users/shotgunsoftware/orgs","repos_url":"https://api.github.com/users/shotgunsoftware/repos","events_url":"https://api.github.com/users/shotgunsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/shotgunsoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":42958533,"name":"tk-framework-simple","full_name":"shotgunsoftware/tk-framework-simple","owner":{"login":"shotgunsoftware","id":317894,"avatar_url":"https://avatars.githubusercontent.com/u/317894?v=3","gravatar_id":"","url":"https://api.github.com/users/shotgunsoftware","html_url":"https://github.com/shotgunsoftware","followers_url":"https://api.github.com/users/shotgunsoftware/followers","following_url":"https://api.github.com/users/shotgunsoftware/following{/other_user}","gists_url":"https://api.github.com/users/shotgunsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/shotgunsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shotgunsoftware/subscriptions","organizations_url":"https://api.github.com/users/shotgunsoftware/orgs","repos_url":"https://api.github.com/users/shotgunsoftware/repos","events_url":"https://api.github.com/users/shotgunsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/shotgunsoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shotgunsoftware/tk-framework-simple","description":"","fork":false,"url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple","forks_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/forks","keys_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/teams","hooks_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/hooks","issue_events_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/issues/events{/number}","events_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/events","assignees_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/assignees{/user}","branches_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/branches{/branch}","tags_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/tags","blobs_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/git/refs{/sha}","trees_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/statuses/{sha}","languages_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/languages","stargazers_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/stargazers","contributors_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/contributors","subscribers_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/subscribers","subscription_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/subscription","commits_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/commits{/sha}","git_commits_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/git/commits{/sha}","comments_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/comments{/number}","issue_comment_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/issues/comments{/number}","contents_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/contents/{+path}","compare_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/merges","archive_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/downloads","issues_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/issues{/number}","pulls_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/pulls{/number}","milestones_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/milestones{/number}","notifications_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/labels{/name}","releases_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/releases{/id}","created_at":"2015-09-22T20:18:29Z","updated_at":"2015-09-22T20:21:09Z","pushed_at":"2015-10-08T14:32:18Z","git_url":"git://github.com/shotgunsoftware/tk-framework-simple.git","ssh_url":"git@github.com:shotgunsoftware/tk-framework-simple.git","clone_url":"https://github.com/shotgunsoftware/tk-framework-simple.git","svn_url":"https://github.com/shotgunsoftware/tk-framework-simple","homepage":null,"size":288,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/pulls/3"},"html":{"href":"https://github.com/shotgunsoftware/tk-framework-simple/pull/3"},"issue":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/issues/3"},"comments":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-simple/statuses/0e3c7c6cfb3d4f5cdc9be398dbb5c8ba05e06723"}}}}