{"action":"opened","number":38,"pull_request":{"url":"https://api.github.com/repos/alphagov/search-admin/pulls/38","id":41578470,"html_url":"https://github.com/alphagov/search-admin/pull/38","diff_url":"https://github.com/alphagov/search-admin/pull/38.diff","patch_url":"https://github.com/alphagov/search-admin/pull/38.patch","issue_url":"https://api.github.com/repos/alphagov/search-admin/issues/38","number":38,"state":"open","locked":false,"title":"Remove indirection in notifying rummager","user":{"login":"tijmenb","id":233676,"avatar_url":"https://avatars.githubusercontent.com/u/233676?v=3","gravatar_id":"","url":"https://api.github.com/users/tijmenb","html_url":"https://github.com/tijmenb","followers_url":"https://api.github.com/users/tijmenb/followers","following_url":"https://api.github.com/users/tijmenb/following{/other_user}","gists_url":"https://api.github.com/users/tijmenb/gists{/gist_id}","starred_url":"https://api.github.com/users/tijmenb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tijmenb/subscriptions","organizations_url":"https://api.github.com/users/tijmenb/orgs","repos_url":"https://api.github.com/users/tijmenb/repos","events_url":"https://api.github.com/users/tijmenb/events{/privacy}","received_events_url":"https://api.github.com/users/tijmenb/received_events","type":"User","site_admin":false},"body":"When a bet/query is updated we need to send the changes to rummager. Currently this is done via a `MessageBus` class that calls listeners with the attributes of the query.\r\n\r\nThis commit removes the `MessageBus` system in favour of calling the RummagerNotifier directly. This reduces the complexity and size of the code significantly without losing functionality.\r\n\r\nThis PR was started after researching an issue with a best bet in the search index (trello: https://trello.com/c/dvzAnQ80) which was slowed down due to having to understand the current process. This refactor will hopefully make things easier for other developers. ","created_at":"2015-08-04T14:51:53Z","updated_at":"2015-08-04T14:51:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/search-admin/pulls/38/commits","review_comments_url":"https://api.github.com/repos/alphagov/search-admin/pulls/38/comments","review_comment_url":"https://api.github.com/repos/alphagov/search-admin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/search-admin/issues/38/comments","statuses_url":"https://api.github.com/repos/alphagov/search-admin/statuses/ccd5488a91391f37ffd15146baf509e8d247993c","head":{"label":"alphagov:easier-rummager","ref":"easier-rummager","sha":"ccd5488a91391f37ffd15146baf509e8d247993c","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":19340234,"name":"search-admin","full_name":"alphagov/search-admin","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/search-admin","description":"Admin for Search","fork":false,"url":"https://api.github.com/repos/alphagov/search-admin","forks_url":"https://api.github.com/repos/alphagov/search-admin/forks","keys_url":"https://api.github.com/repos/alphagov/search-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/search-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/search-admin/teams","hooks_url":"https://api.github.com/repos/alphagov/search-admin/hooks","issue_events_url":"https://api.github.com/repos/alphagov/search-admin/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/search-admin/events","assignees_url":"https://api.github.com/repos/alphagov/search-admin/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/search-admin/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/search-admin/tags","blobs_url":"https://api.github.com/repos/alphagov/search-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/search-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/search-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/search-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/search-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/search-admin/languages","stargazers_url":"https://api.github.com/repos/alphagov/search-admin/stargazers","contributors_url":"https://api.github.com/repos/alphagov/search-admin/contributors","subscribers_url":"https://api.github.com/repos/alphagov/search-admin/subscribers","subscription_url":"https://api.github.com/repos/alphagov/search-admin/subscription","commits_url":"https://api.github.com/repos/alphagov/search-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/search-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/search-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/search-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/search-admin/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/search-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/search-admin/merges","archive_url":"https://api.github.com/repos/alphagov/search-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/search-admin/downloads","issues_url":"https://api.github.com/repos/alphagov/search-admin/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/search-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/search-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/search-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/search-admin/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/search-admin/releases{/id}","created_at":"2014-05-01T09:06:07Z","updated_at":"2015-05-08T12:51:21Z","pushed_at":"2015-08-04T14:46:15Z","git_url":"git://github.com/alphagov/search-admin.git","ssh_url":"git@github.com:alphagov/search-admin.git","clone_url":"https://github.com/alphagov/search-admin.git","svn_url":"https://github.com/alphagov/search-admin","homepage":null,"size":942,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"57fb110ca37c8d402578ad3db8345fd67ab18afb","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":19340234,"name":"search-admin","full_name":"alphagov/search-admin","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/search-admin","description":"Admin for Search","fork":false,"url":"https://api.github.com/repos/alphagov/search-admin","forks_url":"https://api.github.com/repos/alphagov/search-admin/forks","keys_url":"https://api.github.com/repos/alphagov/search-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/search-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/search-admin/teams","hooks_url":"https://api.github.com/repos/alphagov/search-admin/hooks","issue_events_url":"https://api.github.com/repos/alphagov/search-admin/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/search-admin/events","assignees_url":"https://api.github.com/repos/alphagov/search-admin/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/search-admin/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/search-admin/tags","blobs_url":"https://api.github.com/repos/alphagov/search-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/search-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/search-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/search-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/search-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/search-admin/languages","stargazers_url":"https://api.github.com/repos/alphagov/search-admin/stargazers","contributors_url":"https://api.github.com/repos/alphagov/search-admin/contributors","subscribers_url":"https://api.github.com/repos/alphagov/search-admin/subscribers","subscription_url":"https://api.github.com/repos/alphagov/search-admin/subscription","commits_url":"https://api.github.com/repos/alphagov/search-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/search-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/search-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/search-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/search-admin/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/search-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/search-admin/merges","archive_url":"https://api.github.com/repos/alphagov/search-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/search-admin/downloads","issues_url":"https://api.github.com/repos/alphagov/search-admin/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/search-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/search-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/search-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/search-admin/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/search-admin/releases{/id}","created_at":"2014-05-01T09:06:07Z","updated_at":"2015-05-08T12:51:21Z","pushed_at":"2015-08-04T14:46:15Z","git_url":"git://github.com/alphagov/search-admin.git","ssh_url":"git@github.com:alphagov/search-admin.git","clone_url":"https://github.com/alphagov/search-admin.git","svn_url":"https://github.com/alphagov/search-admin","homepage":null,"size":942,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/search-admin/pulls/38"},"html":{"href":"https://github.com/alphagov/search-admin/pull/38"},"issue":{"href":"https://api.github.com/repos/alphagov/search-admin/issues/38"},"comments":{"href":"https://api.github.com/repos/alphagov/search-admin/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/search-admin/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/search-admin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/search-admin/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/search-admin/statuses/ccd5488a91391f37ffd15146baf509e8d247993c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":39,"deletions":212,"changed_files":15}}