{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/olympia/pulls/comments/40576410","id":40576410,"diff_hunk":"@@ -67,8 +67,14 @@ def limit_validation_results(validation):\n     if lim and len(messages) > lim:\n         # Sort messages by severity first so that the most important messages\n         # are the one we keep.\n-        TYPES = {'error': 0, 'warning': 1, 'notice': 2}\n-        messages.sort(key=lambda msg: TYPES.get(msg.get('type')))\n+        TYPES = {'error': 0, 'warning': 2, 'notice': 3}\n+\n+        def message_key(message):\n+            if message.get('signing_severity'):","path":"apps/devhub/utils.py","position":9,"original_position":9,"commit_id":"6c6bcce04798a33baa3c2982176d8a9077f9ff20","original_commit_id":"6c6bcce04798a33baa3c2982176d8a9077f9ff20","user":{"login":"magopian","id":167767,"avatar_url":"https://avatars.githubusercontent.com/u/167767?v=3","gravatar_id":"","url":"https://api.github.com/users/magopian","html_url":"https://github.com/magopian","followers_url":"https://api.github.com/users/magopian/followers","following_url":"https://api.github.com/users/magopian/following{/other_user}","gists_url":"https://api.github.com/users/magopian/gists{/gist_id}","starred_url":"https://api.github.com/users/magopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magopian/subscriptions","organizations_url":"https://api.github.com/users/magopian/orgs","repos_url":"https://api.github.com/users/magopian/repos","events_url":"https://api.github.com/users/magopian/events{/privacy}","received_events_url":"https://api.github.com/users/magopian/received_events","type":"User","site_admin":false},"body":"Are you testing for the presence of the `signing_severity` key here? If so, using `'signing_severity' in message` might be clearer?","created_at":"2015-09-28T16:58:55Z","updated_at":"2015-09-28T16:58:55Z","html_url":"https://github.com/mozilla/olympia/pull/780#discussion_r40576410","pull_request_url":"https://api.github.com/repos/mozilla/olympia/pulls/780","_links":{"self":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/comments/40576410"},"html":{"href":"https://github.com/mozilla/olympia/pull/780#discussion_r40576410"},"pull_request":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/780"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/olympia/pulls/780","id":46054016,"html_url":"https://github.com/mozilla/olympia/pull/780","diff_url":"https://github.com/mozilla/olympia/pull/780.diff","patch_url":"https://github.com/mozilla/olympia/pull/780.patch","issue_url":"https://api.github.com/repos/mozilla/olympia/issues/780","number":780,"state":"open","locked":false,"title":"Prioritize signing warnings over other warnings (bug 1208588)","user":{"login":"mstriemer","id":211578,"avatar_url":"https://avatars.githubusercontent.com/u/211578?v=3","gravatar_id":"","url":"https://api.github.com/users/mstriemer","html_url":"https://github.com/mstriemer","followers_url":"https://api.github.com/users/mstriemer/followers","following_url":"https://api.github.com/users/mstriemer/following{/other_user}","gists_url":"https://api.github.com/users/mstriemer/gists{/gist_id}","starred_url":"https://api.github.com/users/mstriemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstriemer/subscriptions","organizations_url":"https://api.github.com/users/mstriemer/orgs","repos_url":"https://api.github.com/users/mstriemer/repos","events_url":"https://api.github.com/users/mstriemer/events{/privacy}","received_events_url":"https://api.github.com/users/mstriemer/received_events","type":"User","site_admin":false},"body":"https://bugzilla.mozilla.org/show_bug.cgi?id=1208588","created_at":"2015-09-25T20:22:43Z","updated_at":"2015-09-28T16:58:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de071554b286c6b9b0a18e0df2d63da590884edb","assignee":{"login":"kumar303","id":55398,"avatar_url":"https://avatars.githubusercontent.com/u/55398?v=3","gravatar_id":"","url":"https://api.github.com/users/kumar303","html_url":"https://github.com/kumar303","followers_url":"https://api.github.com/users/kumar303/followers","following_url":"https://api.github.com/users/kumar303/following{/other_user}","gists_url":"https://api.github.com/users/kumar303/gists{/gist_id}","starred_url":"https://api.github.com/users/kumar303/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumar303/subscriptions","organizations_url":"https://api.github.com/users/kumar303/orgs","repos_url":"https://api.github.com/users/kumar303/repos","events_url":"https://api.github.com/users/kumar303/events{/privacy}","received_events_url":"https://api.github.com/users/kumar303/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/olympia/pulls/780/commits","review_comments_url":"https://api.github.com/repos/mozilla/olympia/pulls/780/comments","review_comment_url":"https://api.github.com/repos/mozilla/olympia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/olympia/issues/780/comments","statuses_url":"https://api.github.com/repos/mozilla/olympia/statuses/6c6bcce04798a33baa3c2982176d8a9077f9ff20","head":{"label":"mstriemer:dont-truncate-signing-warnings-1208588","ref":"dont-truncate-signing-warnings-1208588","sha":"6c6bcce04798a33baa3c2982176d8a9077f9ff20","user":{"login":"mstriemer","id":211578,"avatar_url":"https://avatars.githubusercontent.com/u/211578?v=3","gravatar_id":"","url":"https://api.github.com/users/mstriemer","html_url":"https://github.com/mstriemer","followers_url":"https://api.github.com/users/mstriemer/followers","following_url":"https://api.github.com/users/mstriemer/following{/other_user}","gists_url":"https://api.github.com/users/mstriemer/gists{/gist_id}","starred_url":"https://api.github.com/users/mstriemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstriemer/subscriptions","organizations_url":"https://api.github.com/users/mstriemer/orgs","repos_url":"https://api.github.com/users/mstriemer/repos","events_url":"https://api.github.com/users/mstriemer/events{/privacy}","received_events_url":"https://api.github.com/users/mstriemer/received_events","type":"User","site_admin":false},"repo":{"id":18221347,"name":"olympia","full_name":"mstriemer/olympia","owner":{"login":"mstriemer","id":211578,"avatar_url":"https://avatars.githubusercontent.com/u/211578?v=3","gravatar_id":"","url":"https://api.github.com/users/mstriemer","html_url":"https://github.com/mstriemer","followers_url":"https://api.github.com/users/mstriemer/followers","following_url":"https://api.github.com/users/mstriemer/following{/other_user}","gists_url":"https://api.github.com/users/mstriemer/gists{/gist_id}","starred_url":"https://api.github.com/users/mstriemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstriemer/subscriptions","organizations_url":"https://api.github.com/users/mstriemer/orgs","repos_url":"https://api.github.com/users/mstriemer/repos","events_url":"https://api.github.com/users/mstriemer/events{/privacy}","received_events_url":"https://api.github.com/users/mstriemer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mstriemer/olympia","description":"AMO, reloaded.","fork":true,"url":"https://api.github.com/repos/mstriemer/olympia","forks_url":"https://api.github.com/repos/mstriemer/olympia/forks","keys_url":"https://api.github.com/repos/mstriemer/olympia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mstriemer/olympia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mstriemer/olympia/teams","hooks_url":"https://api.github.com/repos/mstriemer/olympia/hooks","issue_events_url":"https://api.github.com/repos/mstriemer/olympia/issues/events{/number}","events_url":"https://api.github.com/repos/mstriemer/olympia/events","assignees_url":"https://api.github.com/repos/mstriemer/olympia/assignees{/user}","branches_url":"https://api.github.com/repos/mstriemer/olympia/branches{/branch}","tags_url":"https://api.github.com/repos/mstriemer/olympia/tags","blobs_url":"https://api.github.com/repos/mstriemer/olympia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mstriemer/olympia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mstriemer/olympia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mstriemer/olympia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mstriemer/olympia/statuses/{sha}","languages_url":"https://api.github.com/repos/mstriemer/olympia/languages","stargazers_url":"https://api.github.com/repos/mstriemer/olympia/stargazers","contributors_url":"https://api.github.com/repos/mstriemer/olympia/contributors","subscribers_url":"https://api.github.com/repos/mstriemer/olympia/subscribers","subscription_url":"https://api.github.com/repos/mstriemer/olympia/subscription","commits_url":"https://api.github.com/repos/mstriemer/olympia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mstriemer/olympia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mstriemer/olympia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mstriemer/olympia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mstriemer/olympia/contents/{+path}","compare_url":"https://api.github.com/repos/mstriemer/olympia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mstriemer/olympia/merges","archive_url":"https://api.github.com/repos/mstriemer/olympia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mstriemer/olympia/downloads","issues_url":"https://api.github.com/repos/mstriemer/olympia/issues{/number}","pulls_url":"https://api.github.com/repos/mstriemer/olympia/pulls{/number}","milestones_url":"https://api.github.com/repos/mstriemer/olympia/milestones{/number}","notifications_url":"https://api.github.com/repos/mstriemer/olympia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mstriemer/olympia/labels{/name}","releases_url":"https://api.github.com/repos/mstriemer/olympia/releases{/id}","created_at":"2014-03-28T17:58:28Z","updated_at":"2015-08-04T16:05:57Z","pushed_at":"2015-09-25T20:21:27Z","git_url":"git://github.com/mstriemer/olympia.git","ssh_url":"git@github.com:mstriemer/olympia.git","clone_url":"https://github.com/mstriemer/olympia.git","svn_url":"https://github.com/mstriemer/olympia","homepage":"","size":423848,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"49258e6f703425d480609b35a89fce05abb048e2","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":16416867,"name":"olympia","full_name":"mozilla/olympia","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/olympia","description":"addons.mozilla.org, reloaded.","fork":false,"url":"https://api.github.com/repos/mozilla/olympia","forks_url":"https://api.github.com/repos/mozilla/olympia/forks","keys_url":"https://api.github.com/repos/mozilla/olympia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/olympia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/olympia/teams","hooks_url":"https://api.github.com/repos/mozilla/olympia/hooks","issue_events_url":"https://api.github.com/repos/mozilla/olympia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/olympia/events","assignees_url":"https://api.github.com/repos/mozilla/olympia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/olympia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/olympia/tags","blobs_url":"https://api.github.com/repos/mozilla/olympia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/olympia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/olympia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/olympia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/olympia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/olympia/languages","stargazers_url":"https://api.github.com/repos/mozilla/olympia/stargazers","contributors_url":"https://api.github.com/repos/mozilla/olympia/contributors","subscribers_url":"https://api.github.com/repos/mozilla/olympia/subscribers","subscription_url":"https://api.github.com/repos/mozilla/olympia/subscription","commits_url":"https://api.github.com/repos/mozilla/olympia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/olympia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/olympia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/olympia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/olympia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/olympia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/olympia/merges","archive_url":"https://api.github.com/repos/mozilla/olympia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/olympia/downloads","issues_url":"https://api.github.com/repos/mozilla/olympia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/olympia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/olympia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/olympia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/olympia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/olympia/releases{/id}","created_at":"2014-01-31T18:44:15Z","updated_at":"2015-09-18T08:59:39Z","pushed_at":"2015-09-28T16:48:39Z","git_url":"git://github.com/mozilla/olympia.git","ssh_url":"git@github.com:mozilla/olympia.git","clone_url":"https://github.com/mozilla/olympia.git","svn_url":"https://github.com/mozilla/olympia","homepage":"https://addons.mozilla.org/","size":476146,"stargazers_count":54,"watchers_count":54,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":111,"mirror_url":null,"open_issues_count":19,"forks":111,"open_issues":19,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/780"},"html":{"href":"https://github.com/mozilla/olympia/pull/780"},"issue":{"href":"https://api.github.com/repos/mozilla/olympia/issues/780"},"comments":{"href":"https://api.github.com/repos/mozilla/olympia/issues/780/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/780/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/olympia/pulls/780/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/olympia/statuses/6c6bcce04798a33baa3c2982176d8a9077f9ff20"}}}}