{"action":"created","issue":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3013","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3013/labels{/name}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3013/comments","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3013/events","html_url":"https://github.com/RIOT-OS/RIOT/pull/3013","id":77488692,"number":3013,"title":"sys/net/routing/rpl: Increase version when initiating global repair","user":{"login":"gebart","id":317506,"avatar_url":"https://avatars.githubusercontent.com/u/317506?v=3","gravatar_id":"","url":"https://api.github.com/users/gebart","html_url":"https://github.com/gebart","followers_url":"https://api.github.com/users/gebart/followers","following_url":"https://api.github.com/users/gebart/following{/other_user}","gists_url":"https://api.github.com/users/gebart/gists{/gist_id}","starred_url":"https://api.github.com/users/gebart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gebart/subscriptions","organizations_url":"https://api.github.com/users/gebart/orgs","repos_url":"https://api.github.com/users/gebart/repos","events_url":"https://api.github.com/users/gebart/events{/privacy}","received_events_url":"https://api.github.com/users/gebart/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/minor","name":"minor","color":"f7c6c7"},{"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/network","name":"network","color":"bfdadc"}],"state":"open","locked":false,"assignee":{"login":"cgundogan","id":739129,"avatar_url":"https://avatars.githubusercontent.com/u/739129?v=3","gravatar_id":"","url":"https://api.github.com/users/cgundogan","html_url":"https://github.com/cgundogan","followers_url":"https://api.github.com/users/cgundogan/followers","following_url":"https://api.github.com/users/cgundogan/following{/other_user}","gists_url":"https://api.github.com/users/cgundogan/gists{/gist_id}","starred_url":"https://api.github.com/users/cgundogan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgundogan/subscriptions","organizations_url":"https://api.github.com/users/cgundogan/orgs","repos_url":"https://api.github.com/users/cgundogan/repos","events_url":"https://api.github.com/users/cgundogan/events{/privacy}","received_events_url":"https://api.github.com/users/cgundogan/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-05-18T04:04:13Z","updated_at":"2015-05-18T06:28:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3013","html_url":"https://github.com/RIOT-OS/RIOT/pull/3013","diff_url":"https://github.com/RIOT-OS/RIOT/pull/3013.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/3013.patch"},"body":"cppcheck said:\r\n`sys/net/routing/rpl/rpl_dodag.c:400: warning (selfAssignment): Redundant assignment of 'my_dodag.version' to itself.`\r\n\r\nRFC6550 says:\r\n>A DODAG root institutes a global repair operation by incrementing the DODAGVersionNumber.  This initiates a new DODAG Version.\r\n\r\nI am not sure if the global repair is actually supported in this implementation since I can only find one reference to this function in the code, but the implementation should at least not assign a variable to itself."},"comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments/102936612","html_url":"https://github.com/RIOT-OS/RIOT/pull/3013#issuecomment-102936612","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3013","id":102936612,"user":{"login":"BytesGalore","id":3903215,"avatar_url":"https://avatars.githubusercontent.com/u/3903215?v=3","gravatar_id":"","url":"https://api.github.com/users/BytesGalore","html_url":"https://github.com/BytesGalore","followers_url":"https://api.github.com/users/BytesGalore/followers","following_url":"https://api.github.com/users/BytesGalore/following{/other_user}","gists_url":"https://api.github.com/users/BytesGalore/gists{/gist_id}","starred_url":"https://api.github.com/users/BytesGalore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BytesGalore/subscriptions","organizations_url":"https://api.github.com/users/BytesGalore/orgs","repos_url":"https://api.github.com/users/BytesGalore/repos","events_url":"https://api.github.com/users/BytesGalore/events{/privacy}","received_events_url":"https://api.github.com/users/BytesGalore/received_events","type":"User","site_admin":false},"created_at":"2015-05-18T06:28:41Z","updated_at":"2015-05-18T06:28:41Z","body":"The new DODAG version is already set when receiving a DIO [1]. \r\nSo I think the self assignment of the variable can just be completely removed.\r\n\r\n[1] https://github.com/gebart/RIOT/blob/pr/rpl-global-repair-version/sys/net/routing/rpl/rpl_control_messages.c#L699"}}