{"action":"created","comment":{"url":"https://api.github.com/repos/ansible/tower-cli/pulls/comments/41444712","id":41444712,"diff_hunk":"@@ -12,9 +12,13 @@\n # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n # See the License for the specific language governing permissions and\n # limitations under the License.\n+#\n+# flake8: noqa","path":"lib/tower_cli/models/__init__.py","position":5,"original_position":5,"commit_id":"9a4058e3af85ab75850b63cd6f29aff610cfc552","original_commit_id":"9a4058e3af85ab75850b63cd6f29aff610cfc552","user":{"login":"jlaska","id":1051173,"avatar_url":"https://avatars.githubusercontent.com/u/1051173?v=3","gravatar_id":"","url":"https://api.github.com/users/jlaska","html_url":"https://github.com/jlaska","followers_url":"https://api.github.com/users/jlaska/followers","following_url":"https://api.github.com/users/jlaska/following{/other_user}","gists_url":"https://api.github.com/users/jlaska/gists{/gist_id}","starred_url":"https://api.github.com/users/jlaska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlaska/subscriptions","organizations_url":"https://api.github.com/users/jlaska/orgs","repos_url":"https://api.github.com/users/jlaska/repos","events_url":"https://api.github.com/users/jlaska/events{/privacy}","received_events_url":"https://api.github.com/users/jlaska/received_events","type":"User","site_admin":false},"body":"I tend to avoid module-level exclusions, but it seems to make sense for this case.","created_at":"2015-10-07T20:46:09Z","updated_at":"2015-10-07T20:46:09Z","html_url":"https://github.com/ansible/tower-cli/pull/75#discussion_r41444712","pull_request_url":"https://api.github.com/repos/ansible/tower-cli/pulls/75","_links":{"self":{"href":"https://api.github.com/repos/ansible/tower-cli/pulls/comments/41444712"},"html":{"href":"https://github.com/ansible/tower-cli/pull/75#discussion_r41444712"},"pull_request":{"href":"https://api.github.com/repos/ansible/tower-cli/pulls/75"}}},"pull_request":{"url":"https://api.github.com/repos/ansible/tower-cli/pulls/75","id":47077622,"html_url":"https://github.com/ansible/tower-cli/pull/75","diff_url":"https://github.com/ansible/tower-cli/pull/75.diff","patch_url":"https://github.com/ansible/tower-cli/pull/75.patch","issue_url":"https://api.github.com/repos/ansible/tower-cli/issues/75","number":75,"state":"open","locked":false,"title":"Added more \"inventory source\" variables on group create / modify","user":{"login":"AlanCoding","id":1385596,"avatar_url":"https://avatars.githubusercontent.com/u/1385596?v=3","gravatar_id":"","url":"https://api.github.com/users/AlanCoding","html_url":"https://github.com/AlanCoding","followers_url":"https://api.github.com/users/AlanCoding/followers","following_url":"https://api.github.com/users/AlanCoding/following{/other_user}","gists_url":"https://api.github.com/users/AlanCoding/gists{/gist_id}","starred_url":"https://api.github.com/users/AlanCoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlanCoding/subscriptions","organizations_url":"https://api.github.com/users/AlanCoding/orgs","repos_url":"https://api.github.com/users/AlanCoding/repos","events_url":"https://api.github.com/users/AlanCoding/events{/privacy}","received_events_url":"https://api.github.com/users/AlanCoding/received_events","type":"User","site_admin":false},"body":"Added fields to the (hidden) resource inventory_source and options to the resource group. You can use the group create or group modify command to set these options. Those options include:\r\n- source_regions\r\n- source_vars\r\n- overwrite\r\n- overwrite_vars\r\n- update_on_launch\r\n- update_cache_timeout\r\n\r\nEven with these added, not all possibilities are covered. For instance, for EC2 specifically we are not covering:\r\n- instance fileters\r\n- only group by\r\n\r\nThere are even more if you want to dig in the API, but unless someone specifically articulates a need for these, I'm not going to assume that they should be included at this point.\r\n\r\nThis survives manual testing. Since there is no logic added, there are no unit tests to add.\r\n\r\nNote that if you create a group with the CLI and specify the region, it will not show up in the UI. However, if I specify a region in the UI and save it, it doesn't show in that case either. That might be my own server version, or it might be a UI bug.\r\n\r\nI first set this PR to compare the ad_hoc branch as a base. That did not work, so I'm changing it to master in the main repo, and we will go from there.","created_at":"2015-10-07T20:28:25Z","updated_at":"2015-10-07T20:46:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2457a584b20454b283b9cc619015beac4bda8c32","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ansible/tower-cli/pulls/75/commits","review_comments_url":"https://api.github.com/repos/ansible/tower-cli/pulls/75/comments","review_comment_url":"https://api.github.com/repos/ansible/tower-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/tower-cli/issues/75/comments","statuses_url":"https://api.github.com/repos/ansible/tower-cli/statuses/9a4058e3af85ab75850b63cd6f29aff610cfc552","head":{"label":"AlanCoding:group_source","ref":"group_source","sha":"9a4058e3af85ab75850b63cd6f29aff610cfc552","user":{"login":"AlanCoding","id":1385596,"avatar_url":"https://avatars.githubusercontent.com/u/1385596?v=3","gravatar_id":"","url":"https://api.github.com/users/AlanCoding","html_url":"https://github.com/AlanCoding","followers_url":"https://api.github.com/users/AlanCoding/followers","following_url":"https://api.github.com/users/AlanCoding/following{/other_user}","gists_url":"https://api.github.com/users/AlanCoding/gists{/gist_id}","starred_url":"https://api.github.com/users/AlanCoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlanCoding/subscriptions","organizations_url":"https://api.github.com/users/AlanCoding/orgs","repos_url":"https://api.github.com/users/AlanCoding/repos","events_url":"https://api.github.com/users/AlanCoding/events{/privacy}","received_events_url":"https://api.github.com/users/AlanCoding/received_events","type":"User","site_admin":false},"repo":{"id":40971041,"name":"tower-cli","full_name":"AlanCoding/tower-cli","owner":{"login":"AlanCoding","id":1385596,"avatar_url":"https://avatars.githubusercontent.com/u/1385596?v=3","gravatar_id":"","url":"https://api.github.com/users/AlanCoding","html_url":"https://github.com/AlanCoding","followers_url":"https://api.github.com/users/AlanCoding/followers","following_url":"https://api.github.com/users/AlanCoding/following{/other_user}","gists_url":"https://api.github.com/users/AlanCoding/gists{/gist_id}","starred_url":"https://api.github.com/users/AlanCoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlanCoding/subscriptions","organizations_url":"https://api.github.com/users/AlanCoding/orgs","repos_url":"https://api.github.com/users/AlanCoding/repos","events_url":"https://api.github.com/users/AlanCoding/events{/privacy}","received_events_url":"https://api.github.com/users/AlanCoding/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AlanCoding/tower-cli","description":"Command line tool and client library for Ansible Tower's REST API","fork":true,"url":"https://api.github.com/repos/AlanCoding/tower-cli","forks_url":"https://api.github.com/repos/AlanCoding/tower-cli/forks","keys_url":"https://api.github.com/repos/AlanCoding/tower-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlanCoding/tower-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlanCoding/tower-cli/teams","hooks_url":"https://api.github.com/repos/AlanCoding/tower-cli/hooks","issue_events_url":"https://api.github.com/repos/AlanCoding/tower-cli/issues/events{/number}","events_url":"https://api.github.com/repos/AlanCoding/tower-cli/events","assignees_url":"https://api.github.com/repos/AlanCoding/tower-cli/assignees{/user}","branches_url":"https://api.github.com/repos/AlanCoding/tower-cli/branches{/branch}","tags_url":"https://api.github.com/repos/AlanCoding/tower-cli/tags","blobs_url":"https://api.github.com/repos/AlanCoding/tower-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlanCoding/tower-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlanCoding/tower-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlanCoding/tower-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlanCoding/tower-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/AlanCoding/tower-cli/languages","stargazers_url":"https://api.github.com/repos/AlanCoding/tower-cli/stargazers","contributors_url":"https://api.github.com/repos/AlanCoding/tower-cli/contributors","subscribers_url":"https://api.github.com/repos/AlanCoding/tower-cli/subscribers","subscription_url":"https://api.github.com/repos/AlanCoding/tower-cli/subscription","commits_url":"https://api.github.com/repos/AlanCoding/tower-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlanCoding/tower-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlanCoding/tower-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlanCoding/tower-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlanCoding/tower-cli/contents/{+path}","compare_url":"https://api.github.com/repos/AlanCoding/tower-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlanCoding/tower-cli/merges","archive_url":"https://api.github.com/repos/AlanCoding/tower-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlanCoding/tower-cli/downloads","issues_url":"https://api.github.com/repos/AlanCoding/tower-cli/issues{/number}","pulls_url":"https://api.github.com/repos/AlanCoding/tower-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/AlanCoding/tower-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/AlanCoding/tower-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlanCoding/tower-cli/labels{/name}","releases_url":"https://api.github.com/repos/AlanCoding/tower-cli/releases{/id}","created_at":"2015-08-18T12:37:27Z","updated_at":"2015-08-18T12:37:28Z","pushed_at":"2015-10-07T20:24:45Z","git_url":"git://github.com/AlanCoding/tower-cli.git","ssh_url":"git@github.com:AlanCoding/tower-cli.git","clone_url":"https://github.com/AlanCoding/tower-cli.git","svn_url":"https://github.com/AlanCoding/tower-cli","homepage":"ansible.com/tower","size":419,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ansible:master","ref":"master","sha":"402e919b67ceeadc725e45874b4ed8b525738fc1","user":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":12345160,"name":"tower-cli","full_name":"ansible/tower-cli","owner":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/tower-cli","description":"Command line tool and client library for Ansible Tower's REST API","fork":false,"url":"https://api.github.com/repos/ansible/tower-cli","forks_url":"https://api.github.com/repos/ansible/tower-cli/forks","keys_url":"https://api.github.com/repos/ansible/tower-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/tower-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/tower-cli/teams","hooks_url":"https://api.github.com/repos/ansible/tower-cli/hooks","issue_events_url":"https://api.github.com/repos/ansible/tower-cli/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/tower-cli/events","assignees_url":"https://api.github.com/repos/ansible/tower-cli/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/tower-cli/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/tower-cli/tags","blobs_url":"https://api.github.com/repos/ansible/tower-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/tower-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/tower-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/tower-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/tower-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/tower-cli/languages","stargazers_url":"https://api.github.com/repos/ansible/tower-cli/stargazers","contributors_url":"https://api.github.com/repos/ansible/tower-cli/contributors","subscribers_url":"https://api.github.com/repos/ansible/tower-cli/subscribers","subscription_url":"https://api.github.com/repos/ansible/tower-cli/subscription","commits_url":"https://api.github.com/repos/ansible/tower-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/tower-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/tower-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/tower-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/tower-cli/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/tower-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/tower-cli/merges","archive_url":"https://api.github.com/repos/ansible/tower-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/tower-cli/downloads","issues_url":"https://api.github.com/repos/ansible/tower-cli/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/tower-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/tower-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/tower-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/tower-cli/labels{/name}","releases_url":"https://api.github.com/repos/ansible/tower-cli/releases{/id}","created_at":"2013-08-24T15:19:04Z","updated_at":"2015-09-30T02:52:33Z","pushed_at":"2015-10-07T20:28:25Z","git_url":"git://github.com/ansible/tower-cli.git","ssh_url":"git@github.com:ansible/tower-cli.git","clone_url":"https://github.com/ansible/tower-cli.git","svn_url":"https://github.com/ansible/tower-cli","homepage":"ansible.com/tower","size":1070,"stargazers_count":87,"watchers_count":87,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":14,"forks":35,"open_issues":14,"watchers":87,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/tower-cli/pulls/75"},"html":{"href":"https://github.com/ansible/tower-cli/pull/75"},"issue":{"href":"https://api.github.com/repos/ansible/tower-cli/issues/75"},"comments":{"href":"https://api.github.com/repos/ansible/tower-cli/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/tower-cli/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/tower-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/tower-cli/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/tower-cli/statuses/9a4058e3af85ab75850b63cd6f29aff610cfc552"}}}}