{"action":"created","issue":{"url":"https://api.github.com/repos/gothfox/Tiny-Tiny-RSS/issues/427","labels_url":"https://api.github.com/repos/gothfox/Tiny-Tiny-RSS/issues/427/labels{/name}","comments_url":"https://api.github.com/repos/gothfox/Tiny-Tiny-RSS/issues/427/comments","events_url":"https://api.github.com/repos/gothfox/Tiny-Tiny-RSS/issues/427/events","html_url":"https://github.com/gothfox/Tiny-Tiny-RSS/pull/427","id":52334677,"number":427,"title":"Drop duplicate database indexes","user":{"login":"andersk","id":26471,"avatar_url":"https://avatars.githubusercontent.com/u/26471?v=3","gravatar_id":"","url":"https://api.github.com/users/andersk","html_url":"https://github.com/andersk","followers_url":"https://api.github.com/users/andersk/followers","following_url":"https://api.github.com/users/andersk/following{/other_user}","gists_url":"https://api.github.com/users/andersk/gists{/gist_id}","starred_url":"https://api.github.com/users/andersk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andersk/subscriptions","organizations_url":"https://api.github.com/users/andersk/orgs","repos_url":"https://api.github.com/users/andersk/repos","events_url":"https://api.github.com/users/andersk/events{/privacy}","received_events_url":"https://api.github.com/users/andersk/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":18,"created_at":"2014-12-18T07:51:42Z","updated_at":"2015-02-20T10:02:00Z","closed_at":"2014-12-18T08:55:36Z","pull_request":{"url":"https://api.github.com/repos/gothfox/Tiny-Tiny-RSS/pulls/427","html_url":"https://github.com/gothfox/Tiny-Tiny-RSS/pull/427","diff_url":"https://github.com/gothfox/Tiny-Tiny-RSS/pull/427.diff","patch_url":"https://github.com/gothfox/Tiny-Tiny-RSS/pull/427.patch"},"body":"These duplicate indexes were found by the pt-duplicate-key-checker tool in percona-toolkit. Duplicate indexes waste space and slow down the query planner. Closes #835."},"comment":{"url":"https://api.github.com/repos/gothfox/Tiny-Tiny-RSS/issues/comments/75214498","html_url":"https://github.com/gothfox/Tiny-Tiny-RSS/pull/427#issuecomment-75214498","issue_url":"https://api.github.com/repos/gothfox/Tiny-Tiny-RSS/issues/427","id":75214498,"user":{"login":"gothfox","id":171316,"avatar_url":"https://avatars.githubusercontent.com/u/171316?v=3","gravatar_id":"","url":"https://api.github.com/users/gothfox","html_url":"https://github.com/gothfox","followers_url":"https://api.github.com/users/gothfox/followers","following_url":"https://api.github.com/users/gothfox/following{/other_user}","gists_url":"https://api.github.com/users/gothfox/gists{/gist_id}","starred_url":"https://api.github.com/users/gothfox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gothfox/subscriptions","organizations_url":"https://api.github.com/users/gothfox/orgs","repos_url":"https://api.github.com/users/gothfox/repos","events_url":"https://api.github.com/users/gothfox/events{/privacy}","received_events_url":"https://api.github.com/users/gothfox/received_events","type":"User","site_admin":false},"created_at":"2015-02-20T10:02:00Z","updated_at":"2015-02-20T10:02:00Z","body":"our main fields should be indexed anyway i.e. they are mostly primary keys like owner_uid and stuff. my concern was with the fields in the secondary tables. previously iirc specifying index before foreign key constraint was mandatory so that schema would import but it seems to work fine anyway.\r\n\r\nwhat im trying to say is that by removing the index from the create table definition and adding it later, i have a suspicion there's gonna be two indexes, so we're running back into the same problem your changeset was supposed to fix.\r\n\r\nso im thinking that removing named indexes from the schema and allowing mysql to make automatic ones seems to be an acceptable compromise."}}