{"action":"created","issue":{"url":"https://api.github.com/repos/google/guava/issues/2139","labels_url":"https://api.github.com/repos/google/guava/issues/2139/labels{/name}","comments_url":"https://api.github.com/repos/google/guava/issues/2139/comments","events_url":"https://api.github.com/repos/google/guava/issues/2139/events","html_url":"https://github.com/google/guava/issues/2139","id":102518989,"number":2139,"title":"WeakOuter annotations can cause crashes in j2objc code","user":{"login":"advayDev1","id":11729521,"avatar_url":"https://avatars.githubusercontent.com/u/11729521?v=3","gravatar_id":"","url":"https://api.github.com/users/advayDev1","html_url":"https://github.com/advayDev1","followers_url":"https://api.github.com/users/advayDev1/followers","following_url":"https://api.github.com/users/advayDev1/following{/other_user}","gists_url":"https://api.github.com/users/advayDev1/gists{/gist_id}","starred_url":"https://api.github.com/users/advayDev1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/advayDev1/subscriptions","organizations_url":"https://api.github.com/users/advayDev1/orgs","repos_url":"https://api.github.com/users/advayDev1/repos","events_url":"https://api.github.com/users/advayDev1/events{/privacy}","received_events_url":"https://api.github.com/users/advayDev1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-08-22T09:03:03Z","updated_at":"2015-08-24T19:09:01Z","closed_at":null,"body":"Per https://github.com/google/j2objc/issues/521, the @WeakOuter annotations added in https://github.com/google/guava/commit/c62b07df3a68126e1cf549c85c35f4e55178990b can cause crashes in Objective-C translations of Guava (when the client possess a strong reference only to a view of a collection, and retains no strong references to collection itself).\r\n\r\nSince this hasn't made it to official v19 and is still in RC, should this be rolled back until it can be guaranteed correct?\r\n\r\ncc: @kstanger "},"comment":{"url":"https://api.github.com/repos/google/guava/issues/comments/134343483","html_url":"https://github.com/google/guava/issues/2139#issuecomment-134343483","issue_url":"https://api.github.com/repos/google/guava/issues/2139","id":134343483,"user":{"login":"lowasser","id":544569,"avatar_url":"https://avatars.githubusercontent.com/u/544569?v=3","gravatar_id":"","url":"https://api.github.com/users/lowasser","html_url":"https://github.com/lowasser","followers_url":"https://api.github.com/users/lowasser/followers","following_url":"https://api.github.com/users/lowasser/following{/other_user}","gists_url":"https://api.github.com/users/lowasser/gists{/gist_id}","starred_url":"https://api.github.com/users/lowasser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lowasser/subscriptions","organizations_url":"https://api.github.com/users/lowasser/orgs","repos_url":"https://api.github.com/users/lowasser/repos","events_url":"https://api.github.com/users/lowasser/events{/privacy}","received_events_url":"https://api.github.com/users/lowasser/received_events","type":"User","site_admin":false},"created_at":"2015-08-24T19:09:01Z","updated_at":"2015-08-24T19:09:01Z","body":"> That scenario would result in the collection's reference to the view\nbeing a dead pointer at some point in the future.\n\nIn most cases I believe we'd be okay with that -- it's supposed to be a\ncache; it's okay if the view gets deleted.\n\nOn Mon, Aug 24, 2015 at 12:06 PM Keith Stanger <notifications@github.com>\nwrote:\n\n> That scenario would result in the collection's reference to the view being\n> a dead pointer at some point in the future. Keep in mind we don't\n> necessarily have ARC's automatically nil'ed __weak reference semantics, and\n> if we did we'd still need to make the necessary modifications to check for\n> nil.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/google/guava/issues/2139#issuecomment-134342830>.\n>\n"}}