{"push_id":663143265,"size":43,"distinct_size":42,"ref":"refs/heads/PUP-4420/external_facts_permissions","head":"c0fd9f45fdbfe607c35eec6923aa6459388f15f6","before":"655f1beb6dd118fa593a29e8d383b97a521c5cc8","commits":[{"sha":"0feecfdc3250b50d707205a6d974ca4b74f41cdb","author":{"email":"5f50a84c1fa3bcff146405017f36aec1a10a9e38@tada.se","name":"Thomas Hallgren"},"message":"(PUP-4483) Add NotUndef type to the Puppet type system\n\nThis commit adds a new NotUndef type. The purpose of this type is\nto constrain its contained type so that it is not assignable from\nthe Undef type. The contained type is optional and defaults to\nAny.","distinct":true,"url":"https://api.github.com/repos/whopper/puppet/commits/0feecfdc3250b50d707205a6d974ca4b74f41cdb"},{"sha":"c5676240e79d1b902469345199a510fcf4540bbb","author":{"email":"c9b95f68e70c94c25d52b81728f3cf400a673cf9@puppetlabs.com","name":"Hailee Kenney"},"message":"(PUP-2630) Add $server_facts and setting\n\nPrior to this commit, there was no way for module authors to ensure\nthat they were getting trusted server facts due to the fact that\nserver side global variables can be overwritten by client side\nfacts.\n\nAdd the $server_facts global variable which will contain a hash\nof server side facts which cannot be overwritten. Add the\ncorresponding trusted_server_facts setting. The setting is false\nby default, but if set to true by the user then the $server_facts\nvariable will be populated.","distinct":true,"url":"https://api.github.com/repos/whopper/puppet/commits/c5676240e79d1b902469345199a510fcf4540bbb"},{"sha":"f94ed1aa4584bed0680e626688349df6d8e5e552","author":{"email":"c9b95f68e70c94c25d52b81728f3cf400a673cf9@puppetlabs.com","name":"Hailee Kenney"},"message":"(PUP-2630) Warn when node parameter is not updated\n\nPrior to this commit, if merge attempted to set a node parameter\nthat already existed, it would quietly fail to update the value.\nThis meant that if a client fact value was being used for one of\nthe server side facts, it would not be overwritten with the correct\nvalue and the user would never know.\n\nSince we cannot change the behavior without breaking API, simply\nadd a warning so that the user will be aware if merge failed to\nchange the value of a node parameter.","distinct":true,"url":"https://api.github.com/repos/whopper/puppet/commits/f94ed1aa4584bed0680e626688349df6d8e5e552"},{"sha":"a7817b7c37340664af0fb592fc6f93a0e56fb3d4","author":{"email":"95e828102f92afbaa4d3ed92646a950670566628@cloudsmith.com","name":"Henrik Lindberg"},"message":"(PUP-4520) Fix regression with case default option not being done last\n\nBefore this, and after 3.7.5, a case option being a literal default\nwas selected when encountered instead of being selected last if no other\noption was selected.\n\nThis was introduced when adding either support for deep merge, or for\nmigration checking. There was no test finding this regression.\n(A similar problem was found earlier with selector).\n\nThe fix was to remove the call to is_match? for the default option and\ninstead return false (to continue with other case option values in the\nsame option.\n\nAs a consequence, one migration test needed to be changed as it reported\na \"type diff\" for default vs. Resource type (which was actually wrong,\nsince a comparisson against default is not considered a type match diff)","distinct":true,"url":"https://api.github.com/repos/whopper/puppet/commits/a7817b7c37340664af0fb592fc6f93a0e56fb3d4"},{"sha":"79ffde79608580d30272e80787ad97c4dd12bfce","author":{"email":"5f50a84c1fa3bcff146405017f36aec1a10a9e38@tada.se","name":"Thomas Hallgren"},"message":"(PUP-4483) Enable Struct keys to be NotUndef or Optional\n\nPrior to this commit, a Struct key was a non empty string literal\nand it's type was assumed to always be optional. A consequence of\nthis was that there was no way to describe a type that required\nan entry where the key was required but the value was optional. In\nshort, there was no way to differntiate a \"missing entry\" from\n\"entry with undef value\".\n\nThis commit changes this so that the key of a struct member is a\nproper type. The type is restricted in that it must be possible to\ninfer a non-empty string from it (this becomes the former name of the\nkey).\n\nThe old behavior is preserved so that if a string literal is used as\na key, it will be converted to its corresponding String type. The\nString will then be wrapped in an Optional type if the type of the\nvalue is assignable from Undef.","distinct":true,"url":"https://api.github.com/repos/whopper/puppet/commits/79ffde79608580d30272e80787ad97c4dd12bfce"},{"sha":"fc425cc75c4d2c58e2bdd252565ef26a14f1c508","author":{"email":"c9b95f68e70c94c25d52b81728f3cf400a673cf9@puppetlabs.com","name":"Hailee Kenney"},"message":"(PUP-2630) Address PR comments and fix bugs\n\nClean up the code based off the comments on the PR and fix a few\nbugs found around setting the $server_facts variable.","distinct":true,"url":"https://api.github.com/repos/whopper/puppet/commits/fc425cc75c4d2c58e2bdd252565ef26a14f1c508"},{"sha":"0ed87c29e468fd1ae223f4bde5c4ecd77b38e6cb","author":{"email":"c9b95f68e70c94c25d52b81728f3cf400a673cf9@puppetlabs.com","name":"Hailee Kenney"},"message":"(PUP-2630) Add spec tests and fix minor bugs\n\nAdd spec tests to ensure that the $server_facts variable and that\nnode's merge method work as expected. Additionally, fix a few minor\nbugs and typos found when writing tests.","distinct":true,"url":"https://api.github.com/repos/whopper/puppet/commits/0ed87c29e468fd1ae223f4bde5c4ecd77b38e6cb"},{"sha":"1678a9d3c1f8967ff55a40d49c997fd6c3b73d03","author":{"email":"95e828102f92afbaa4d3ed92646a950670566628@puppetlabs.com","name":"Henrik Lindberg"},"message":"Merge pull request #3889 from thallgren/issue/pup-4483/add-notundef-type\n\n(PUP-4483) Add NotUndef type to the Puppet type system","distinct":true,"url":"https://api.github.com/repos/whopper/puppet/commits/1678a9d3c1f8967ff55a40d49c997fd6c3b73d03"},{"sha":"d2c2441b53e04b4249a73b100e289e9eff03afc2","author":{"email":"5f50a84c1fa3bcff146405017f36aec1a10a9e38@tada.se","name":"Thomas Hallgren"},"message":"Merge pull request #3893 from hlindberg/pup-4520_default-in-case-should-eval-last\n\n(PUP-4520) Fix regression with case default option not being done last","distinct":true,"url":"https://api.github.com/repos/whopper/puppet/commits/d2c2441b53e04b4249a73b100e289e9eff03afc2"},{"sha":"14c39ed8b818324711f6ed76129b12387fdf3681","author":{"email":"5f50a84c1fa3bcff146405017f36aec1a10a9e38@tada.se","name":"Thomas Hallgren"},"message":"Merge branch '3.x' into stable\n\nConflicts:\n\tlib/puppet/pops/types/type_factory.rb\n\tspec/unit/pops/migration_spec.rb\n\tspec/unit/pops/types/type_calculator_spec.rb","distinct":true,"url":"https://api.github.com/repos/whopper/puppet/commits/14c39ed8b818324711f6ed76129b12387fdf3681"},{"sha":"9cbf1292b7f2657e5f5e2045582438bc2358e708","author":{"email":"95e828102f92afbaa4d3ed92646a950670566628@cloudsmith.com","name":"Henrik Lindberg"},"message":"(PUP-4527) Add MigrationChecker method to provide available migrations\n\nBefoe this, reflection had to be used to see what a version of a\nMigrationChecker implements.\n\nThis is now changed so all versions of puppet after 3.8.0 has a method\nthat returns the migration checks that are implemented. This makes it\npossible to have newer versions of the migration checker support older\nversions of puppet (>= 3.8.0).","distinct":true,"url":"https://api.github.com/repos/whopper/puppet/commits/9cbf1292b7f2657e5f5e2045582438bc2358e708"},{"sha":"48424f7dd8e7d78000313b2ead89fae0b3b0a25f","author":{"email":"95e828102f92afbaa4d3ed92646a950670566628@cloudsmith.com","name":"Henrik Lindberg"},"message":"Merge branch 'PUP-4527_add-migration-checker-capability-info-to-checker' into stable","distinct":true,"url":"https://api.github.com/repos/whopper/puppet/commits/48424f7dd8e7d78000313b2ead89fae0b3b0a25f"},{"sha":"0196452e29d312f83c3371d84bfd41929de430e0","author":{"email":"c9b95f68e70c94c25d52b81728f3cf400a673cf9@puppetlabs.com","name":"Hailee Kenney"},"message":"(PUP-2630) Use correct node name in warning\n\nPrior to this commit, the wrong variable was being used to\nretrieve the name of the node in the overridden parameter warning\nmessage. Update the warning message to use @name and fix the test\naccordingly.","distinct":true,"url":"https://api.github.com/repos/whopper/puppet/commits/0196452e29d312f83c3371d84bfd41929de430e0"},{"sha":"d690a4b6cca46923e4cd0ff37b7d8b6fcc9e270d","author":{"email":"95e828102f92afbaa4d3ed92646a950670566628@cloudsmith.com","name":"Henrik Lindberg"},"message":"(PUP-4527) Remove migration strategies and make it an error to call them\n\nBefore this, if missing to remove calls to no longer supported migration\nchecking methods it would silently just waste cycles. This can happen\nwhen changes on an older branch is merged and calls to the\nmigration_checker for unsupported migration strategies are brought\nforward (they should be removed).\n\nAfter this, such calls will raise errors in the null/base implementation\nof the migration checker.","distinct":true,"url":"https://api.github.com/repos/whopper/puppet/commits/d690a4b6cca46923e4cd0ff37b7d8b6fcc9e270d"},{"sha":"3d9c16738814a44a64ad6c799ca8f8e9c3671ee2","author":{"email":"95e828102f92afbaa4d3ed92646a950670566628@cloudsmith.com","name":"Henrik Lindberg"},"message":"(PUP-4127) Remove calls to migration checker that were merged\n\nBefore this, cycles were wasted calling no longer supported migration\nmethods that were brought forward from merging PUP-4127 from 3.x branch\nto stable.\n\nThis removes those calls (2 in total) that should have been removed when\nmerging the 3.x branch.","distinct":true,"url":"https://api.github.com/repos/whopper/puppet/commits/3d9c16738814a44a64ad6c799ca8f8e9c3671ee2"},{"sha":"e1a72085c71199fbf37e02052a3550f488d960ce","author":{"email":"c9b95f68e70c94c25d52b81728f3cf400a673cf9@puppetlabs.com","name":"Hailee Kenney"},"message":"Merge pull request #3902 from hlindberg/PUP-4527_add-migration-checker-capability-info-to-checker\n\n(PUP-4527) Add MigrationChecker method to provide available migrations","distinct":true,"url":"https://api.github.com/repos/whopper/puppet/commits/e1a72085c71199fbf37e02052a3550f488d960ce"},{"sha":"1588ad81014f7df84f20232d61db71a1c11ae0be","author":{"email":"c9b95f68e70c94c25d52b81728f3cf400a673cf9@puppetlabs.com","name":"Hailee Kenney"},"message":"Merge pull request #3903 from hlindberg/PUP-4527_stable-remove-3x-to-4x-migration-support\n\n(PUP-4527) merge 4527 from 3.x and fix up earlier merge mistakes","distinct":true,"url":"https://api.github.com/repos/whopper/puppet/commits/1588ad81014f7df84f20232d61db71a1c11ae0be"},{"sha":"2c805c21e7afcbbe5f2f1755c75221a85640e792","author":{"email":"649be5633b41b01f5559464327d4ef7fc24c4307@puppetlabs.com","name":"Branan Riley"},"message":"(PUP-735) Ensure reports are finalized when catalog.apply fails\n\nAfter the initial work on PUP-735, we were left with a situation where\ncertain catalog apply errors (including resource cycles) could casue a\nreport to not be finalized. An easy symptom of this to see is that the\nmetrics section of the report is empty.\n\nThis fixes the configurer to always finalize the report, and adds a\ntest.","distinct":true,"url":"https://api.github.com/repos/whopper/puppet/commits/2c805c21e7afcbbe5f2f1755c75221a85640e792"},{"sha":"43585568a45b9aea669508122468bc9fab7830cc","author":{"email":"aab4da3e71c2ca1ec0b8dbe613e4e9afa2218fcf@puppetlabs.com","name":"Peter Huene"},"message":"(PUP-4524) Stub command execution in base service provider spec.\n\nRather than rely on executing ruby to manipulate a file to \"emulate\" a\nservice start/status/stop command, stub command execution itself to\nensure the base service provider is executing the commands as expected.","distinct":true,"url":"https://api.github.com/repos/whopper/puppet/commits/43585568a45b9aea669508122468bc9fab7830cc"},{"sha":"81684bdcdb31d5962e01de55f59dd13fbc85fbdf","author":{"email":"95e828102f92afbaa4d3ed92646a950670566628@puppetlabs.com","name":"Henrik Lindberg"},"message":"Merge pull request #3879 from hkenney/issue/master/PUP-2630_global_variables_overwritten_by_facts\n\n(PUP-2630) Ensure it is possible to get trusted server facts that cannot be overwritten","distinct":true,"url":"https://api.github.com/repos/whopper/puppet/commits/81684bdcdb31d5962e01de55f59dd13fbc85fbdf"}]}