{"action":"created","issue":{"url":"https://api.github.com/repos/DaveDavenport/rofi/issues/172","labels_url":"https://api.github.com/repos/DaveDavenport/rofi/issues/172/labels{/name}","comments_url":"https://api.github.com/repos/DaveDavenport/rofi/issues/172/comments","events_url":"https://api.github.com/repos/DaveDavenport/rofi/issues/172/events","html_url":"https://github.com/DaveDavenport/rofi/pull/172","id":81124798,"number":172,"title":"Fix font bug, use pango_layout_get_size to determine height","user":{"login":"gbitzes","id":3705326,"avatar_url":"https://avatars.githubusercontent.com/u/3705326?v=3","gravatar_id":"","url":"https://api.github.com/users/gbitzes","html_url":"https://github.com/gbitzes","followers_url":"https://api.github.com/users/gbitzes/followers","following_url":"https://api.github.com/users/gbitzes/following{/other_user}","gists_url":"https://api.github.com/users/gbitzes/gists{/gist_id}","starred_url":"https://api.github.com/users/gbitzes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbitzes/subscriptions","organizations_url":"https://api.github.com/users/gbitzes/orgs","repos_url":"https://api.github.com/users/gbitzes/repos","events_url":"https://api.github.com/users/gbitzes/events{/privacy}","received_events_url":"https://api.github.com/users/gbitzes/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/DaveDavenport/rofi/labels/bug","name":"bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":{"login":"DaveDavenport","id":406245,"avatar_url":"https://avatars.githubusercontent.com/u/406245?v=3","gravatar_id":"","url":"https://api.github.com/users/DaveDavenport","html_url":"https://github.com/DaveDavenport","followers_url":"https://api.github.com/users/DaveDavenport/followers","following_url":"https://api.github.com/users/DaveDavenport/following{/other_user}","gists_url":"https://api.github.com/users/DaveDavenport/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveDavenport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveDavenport/subscriptions","organizations_url":"https://api.github.com/users/DaveDavenport/orgs","repos_url":"https://api.github.com/users/DaveDavenport/repos","events_url":"https://api.github.com/users/DaveDavenport/events{/privacy}","received_events_url":"https://api.github.com/users/DaveDavenport/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/DaveDavenport/rofi/milestones/3","html_url":"https://github.com/DaveDavenport/rofi/milestones/0.15.5","labels_url":"https://api.github.com/repos/DaveDavenport/rofi/milestones/3/labels","id":1083849,"number":3,"title":"0.15.5","description":"","creator":{"login":"DaveDavenport","id":406245,"avatar_url":"https://avatars.githubusercontent.com/u/406245?v=3","gravatar_id":"","url":"https://api.github.com/users/DaveDavenport","html_url":"https://github.com/DaveDavenport","followers_url":"https://api.github.com/users/DaveDavenport/followers","following_url":"https://api.github.com/users/DaveDavenport/following{/other_user}","gists_url":"https://api.github.com/users/DaveDavenport/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveDavenport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveDavenport/subscriptions","organizations_url":"https://api.github.com/users/DaveDavenport/orgs","repos_url":"https://api.github.com/users/DaveDavenport/repos","events_url":"https://api.github.com/users/DaveDavenport/events{/privacy}","received_events_url":"https://api.github.com/users/DaveDavenport/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":15,"state":"open","created_at":"2015-04-26T09:50:33Z","updated_at":"2015-05-26T22:03:02Z","due_on":"2015-05-29T22:00:00Z","closed_at":null},"comments":4,"created_at":"2015-05-26T20:33:48Z","updated_at":"2015-05-26T22:03:02Z","closed_at":"2015-05-26T22:03:02Z","pull_request":{"url":"https://api.github.com/repos/DaveDavenport/rofi/pulls/172","html_url":"https://github.com/DaveDavenport/rofi/pull/172","diff_url":"https://github.com/DaveDavenport/rofi/pull/172.diff","patch_url":"https://github.com/DaveDavenport/rofi/pull/172.patch"},"body":"This commit fixes a bug introduced in 9530f195d1055da8dffbd40d6f3c2f7c73749598, it appears that the information provided by `textbox_get_estimated_char_height` is not correct. Using `Source Code Pro` for example, no matter how small or big I set the font size to be, it always returns the same value: `19456`\r\n\r\nThe end result is that a large font size produces text that is vertically chopped off, try using ``Mono 20`` to see an example.\r\n\r\nI am not a pango expert, but it looks like ``pango_layout_get_size`` is what we want here to get the font height, which is what this commit changes.\r\n\r\nCheers"},"comment":{"url":"https://api.github.com/repos/DaveDavenport/rofi/issues/comments/105680193","html_url":"https://github.com/DaveDavenport/rofi/pull/172#issuecomment-105680193","issue_url":"https://api.github.com/repos/DaveDavenport/rofi/issues/172","id":105680193,"user":{"login":"gbitzes","id":3705326,"avatar_url":"https://avatars.githubusercontent.com/u/3705326?v=3","gravatar_id":"","url":"https://api.github.com/users/gbitzes","html_url":"https://github.com/gbitzes","followers_url":"https://api.github.com/users/gbitzes/followers","following_url":"https://api.github.com/users/gbitzes/following{/other_user}","gists_url":"https://api.github.com/users/gbitzes/gists{/gist_id}","starred_url":"https://api.github.com/users/gbitzes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbitzes/subscriptions","organizations_url":"https://api.github.com/users/gbitzes/orgs","repos_url":"https://api.github.com/users/gbitzes/repos","events_url":"https://api.github.com/users/gbitzes/events{/privacy}","received_events_url":"https://api.github.com/users/gbitzes/received_events","type":"User","site_admin":false},"created_at":"2015-05-26T22:03:02Z","updated_at":"2015-05-26T22:03:02Z","body":"Yes, it fixes the issue. Thanks!"}}