{"action":"created","comment":{"url":"https://api.github.com/repos/alacarte-maps/alacarte/pulls/comments/42307557","id":42307557,"diff_hunk":"@@ -36,7 +36,7 @@ UnaryOperationNode::UnaryOperationNode(op::UnaryOperationEnum operation, const n\n string UnaryOperationNode::eval(GeoObject* obj) const\n {\n \t// This is needed beacase of MSVC\n-\tassert(false);","path":"src/server/eval/unary_operation_node.cpp","position":4,"original_position":4,"commit_id":"57c92df38a658b60d3ab6af67fbea92a242819c9","original_commit_id":"57c92df38a658b60d3ab6af67fbea92a242819c9","user":{"login":"alex85k","id":4124648,"avatar_url":"https://avatars.githubusercontent.com/u/4124648?v=3","gravatar_id":"","url":"https://api.github.com/users/alex85k","html_url":"https://github.com/alex85k","followers_url":"https://api.github.com/users/alex85k/followers","following_url":"https://api.github.com/users/alex85k/following{/other_user}","gists_url":"https://api.github.com/users/alex85k/gists{/gist_id}","starred_url":"https://api.github.com/users/alex85k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex85k/subscriptions","organizations_url":"https://api.github.com/users/alex85k/orgs","repos_url":"https://api.github.com/users/alex85k/repos","events_url":"https://api.github.com/users/alex85k/events{/privacy}","received_events_url":"https://api.github.com/users/alex85k/received_events","type":"User","site_admin":false},"body":"assert if OK, but VS2015 compiler says \"no return in function eval()\" and gives an error.","created_at":"2015-10-17T09:14:47Z","updated_at":"2015-10-17T09:14:47Z","html_url":"https://github.com/alacarte-maps/alacarte/pull/50#discussion_r42307557","pull_request_url":"https://api.github.com/repos/alacarte-maps/alacarte/pulls/50","_links":{"self":{"href":"https://api.github.com/repos/alacarte-maps/alacarte/pulls/comments/42307557"},"html":{"href":"https://github.com/alacarte-maps/alacarte/pull/50#discussion_r42307557"},"pull_request":{"href":"https://api.github.com/repos/alacarte-maps/alacarte/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/alacarte-maps/alacarte/pulls/50","id":47636325,"html_url":"https://github.com/alacarte-maps/alacarte/pull/50","diff_url":"https://github.com/alacarte-maps/alacarte/pull/50.diff","patch_url":"https://github.com/alacarte-maps/alacarte/pull/50.patch","issue_url":"https://api.github.com/repos/alacarte-maps/alacarte/issues/50","number":50,"state":"open","locked":false,"title":"Restore MSVC compatibility","user":{"login":"alex85k","id":4124648,"avatar_url":"https://avatars.githubusercontent.com/u/4124648?v=3","gravatar_id":"","url":"https://api.github.com/users/alex85k","html_url":"https://github.com/alex85k","followers_url":"https://api.github.com/users/alex85k/followers","following_url":"https://api.github.com/users/alex85k/following{/other_user}","gists_url":"https://api.github.com/users/alex85k/gists{/gist_id}","starred_url":"https://api.github.com/users/alex85k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex85k/subscriptions","organizations_url":"https://api.github.com/users/alex85k/orgs","repos_url":"https://api.github.com/users/alex85k/repos","events_url":"https://api.github.com/users/alex85k/events{/privacy}","received_events_url":"https://api.github.com/users/alex85k/received_events","type":"User","site_admin":false},"body":"Here are the minimal changes to restore Windows compatibility (tested on Visual Studio 2015, eliminated compile errors).\r\nTo compile and run tests, more changes are needed.","created_at":"2015-10-14T09:32:12Z","updated_at":"2015-10-17T09:14:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9a1984d99ad3751832113270f7ab19f991ac3d4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alacarte-maps/alacarte/pulls/50/commits","review_comments_url":"https://api.github.com/repos/alacarte-maps/alacarte/pulls/50/comments","review_comment_url":"https://api.github.com/repos/alacarte-maps/alacarte/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alacarte-maps/alacarte/issues/50/comments","statuses_url":"https://api.github.com/repos/alacarte-maps/alacarte/statuses/57c92df38a658b60d3ab6af67fbea92a242819c9","head":{"label":"alex85k:min-windows-compat","ref":"min-windows-compat","sha":"57c92df38a658b60d3ab6af67fbea92a242819c9","user":{"login":"alex85k","id":4124648,"avatar_url":"https://avatars.githubusercontent.com/u/4124648?v=3","gravatar_id":"","url":"https://api.github.com/users/alex85k","html_url":"https://github.com/alex85k","followers_url":"https://api.github.com/users/alex85k/followers","following_url":"https://api.github.com/users/alex85k/following{/other_user}","gists_url":"https://api.github.com/users/alex85k/gists{/gist_id}","starred_url":"https://api.github.com/users/alex85k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex85k/subscriptions","organizations_url":"https://api.github.com/users/alex85k/orgs","repos_url":"https://api.github.com/users/alex85k/repos","events_url":"https://api.github.com/users/alex85k/events{/privacy}","received_events_url":"https://api.github.com/users/alex85k/received_events","type":"User","site_admin":false},"repo":{"id":44130195,"name":"alacarte","full_name":"alex85k/alacarte","owner":{"login":"alex85k","id":4124648,"avatar_url":"https://avatars.githubusercontent.com/u/4124648?v=3","gravatar_id":"","url":"https://api.github.com/users/alex85k","html_url":"https://github.com/alex85k","followers_url":"https://api.github.com/users/alex85k/followers","following_url":"https://api.github.com/users/alex85k/following{/other_user}","gists_url":"https://api.github.com/users/alex85k/gists{/gist_id}","starred_url":"https://api.github.com/users/alex85k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex85k/subscriptions","organizations_url":"https://api.github.com/users/alex85k/orgs","repos_url":"https://api.github.com/users/alex85k/repos","events_url":"https://api.github.com/users/alex85k/events{/privacy}","received_events_url":"https://api.github.com/users/alex85k/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alex85k/alacarte","description":"Renderer for OpenStreetMap tiles.","fork":true,"url":"https://api.github.com/repos/alex85k/alacarte","forks_url":"https://api.github.com/repos/alex85k/alacarte/forks","keys_url":"https://api.github.com/repos/alex85k/alacarte/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alex85k/alacarte/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alex85k/alacarte/teams","hooks_url":"https://api.github.com/repos/alex85k/alacarte/hooks","issue_events_url":"https://api.github.com/repos/alex85k/alacarte/issues/events{/number}","events_url":"https://api.github.com/repos/alex85k/alacarte/events","assignees_url":"https://api.github.com/repos/alex85k/alacarte/assignees{/user}","branches_url":"https://api.github.com/repos/alex85k/alacarte/branches{/branch}","tags_url":"https://api.github.com/repos/alex85k/alacarte/tags","blobs_url":"https://api.github.com/repos/alex85k/alacarte/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alex85k/alacarte/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alex85k/alacarte/git/refs{/sha}","trees_url":"https://api.github.com/repos/alex85k/alacarte/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alex85k/alacarte/statuses/{sha}","languages_url":"https://api.github.com/repos/alex85k/alacarte/languages","stargazers_url":"https://api.github.com/repos/alex85k/alacarte/stargazers","contributors_url":"https://api.github.com/repos/alex85k/alacarte/contributors","subscribers_url":"https://api.github.com/repos/alex85k/alacarte/subscribers","subscription_url":"https://api.github.com/repos/alex85k/alacarte/subscription","commits_url":"https://api.github.com/repos/alex85k/alacarte/commits{/sha}","git_commits_url":"https://api.github.com/repos/alex85k/alacarte/git/commits{/sha}","comments_url":"https://api.github.com/repos/alex85k/alacarte/comments{/number}","issue_comment_url":"https://api.github.com/repos/alex85k/alacarte/issues/comments{/number}","contents_url":"https://api.github.com/repos/alex85k/alacarte/contents/{+path}","compare_url":"https://api.github.com/repos/alex85k/alacarte/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alex85k/alacarte/merges","archive_url":"https://api.github.com/repos/alex85k/alacarte/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alex85k/alacarte/downloads","issues_url":"https://api.github.com/repos/alex85k/alacarte/issues{/number}","pulls_url":"https://api.github.com/repos/alex85k/alacarte/pulls{/number}","milestones_url":"https://api.github.com/repos/alex85k/alacarte/milestones{/number}","notifications_url":"https://api.github.com/repos/alex85k/alacarte/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alex85k/alacarte/labels{/name}","releases_url":"https://api.github.com/repos/alex85k/alacarte/releases{/id}","created_at":"2015-10-12T19:45:35Z","updated_at":"2015-10-12T19:45:37Z","pushed_at":"2015-10-15T10:10:43Z","git_url":"git://github.com/alex85k/alacarte.git","ssh_url":"git@github.com:alex85k/alacarte.git","clone_url":"https://github.com/alex85k/alacarte.git","svn_url":"https://github.com/alex85k/alacarte","homepage":"","size":3463,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alacarte-maps:master","ref":"master","sha":"58caa9d33ff8de26434b25261303d501fdac9dd3","user":{"login":"alacarte-maps","id":4125728,"avatar_url":"https://avatars.githubusercontent.com/u/4125728?v=3","gravatar_id":"","url":"https://api.github.com/users/alacarte-maps","html_url":"https://github.com/alacarte-maps","followers_url":"https://api.github.com/users/alacarte-maps/followers","following_url":"https://api.github.com/users/alacarte-maps/following{/other_user}","gists_url":"https://api.github.com/users/alacarte-maps/gists{/gist_id}","starred_url":"https://api.github.com/users/alacarte-maps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alacarte-maps/subscriptions","organizations_url":"https://api.github.com/users/alacarte-maps/orgs","repos_url":"https://api.github.com/users/alacarte-maps/repos","events_url":"https://api.github.com/users/alacarte-maps/events{/privacy}","received_events_url":"https://api.github.com/users/alacarte-maps/received_events","type":"Organization","site_admin":false},"repo":{"id":9081036,"name":"alacarte","full_name":"alacarte-maps/alacarte","owner":{"login":"alacarte-maps","id":4125728,"avatar_url":"https://avatars.githubusercontent.com/u/4125728?v=3","gravatar_id":"","url":"https://api.github.com/users/alacarte-maps","html_url":"https://github.com/alacarte-maps","followers_url":"https://api.github.com/users/alacarte-maps/followers","following_url":"https://api.github.com/users/alacarte-maps/following{/other_user}","gists_url":"https://api.github.com/users/alacarte-maps/gists{/gist_id}","starred_url":"https://api.github.com/users/alacarte-maps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alacarte-maps/subscriptions","organizations_url":"https://api.github.com/users/alacarte-maps/orgs","repos_url":"https://api.github.com/users/alacarte-maps/repos","events_url":"https://api.github.com/users/alacarte-maps/events{/privacy}","received_events_url":"https://api.github.com/users/alacarte-maps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alacarte-maps/alacarte","description":"Renderer for OpenStreetMap tiles.","fork":false,"url":"https://api.github.com/repos/alacarte-maps/alacarte","forks_url":"https://api.github.com/repos/alacarte-maps/alacarte/forks","keys_url":"https://api.github.com/repos/alacarte-maps/alacarte/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alacarte-maps/alacarte/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alacarte-maps/alacarte/teams","hooks_url":"https://api.github.com/repos/alacarte-maps/alacarte/hooks","issue_events_url":"https://api.github.com/repos/alacarte-maps/alacarte/issues/events{/number}","events_url":"https://api.github.com/repos/alacarte-maps/alacarte/events","assignees_url":"https://api.github.com/repos/alacarte-maps/alacarte/assignees{/user}","branches_url":"https://api.github.com/repos/alacarte-maps/alacarte/branches{/branch}","tags_url":"https://api.github.com/repos/alacarte-maps/alacarte/tags","blobs_url":"https://api.github.com/repos/alacarte-maps/alacarte/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alacarte-maps/alacarte/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alacarte-maps/alacarte/git/refs{/sha}","trees_url":"https://api.github.com/repos/alacarte-maps/alacarte/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alacarte-maps/alacarte/statuses/{sha}","languages_url":"https://api.github.com/repos/alacarte-maps/alacarte/languages","stargazers_url":"https://api.github.com/repos/alacarte-maps/alacarte/stargazers","contributors_url":"https://api.github.com/repos/alacarte-maps/alacarte/contributors","subscribers_url":"https://api.github.com/repos/alacarte-maps/alacarte/subscribers","subscription_url":"https://api.github.com/repos/alacarte-maps/alacarte/subscription","commits_url":"https://api.github.com/repos/alacarte-maps/alacarte/commits{/sha}","git_commits_url":"https://api.github.com/repos/alacarte-maps/alacarte/git/commits{/sha}","comments_url":"https://api.github.com/repos/alacarte-maps/alacarte/comments{/number}","issue_comment_url":"https://api.github.com/repos/alacarte-maps/alacarte/issues/comments{/number}","contents_url":"https://api.github.com/repos/alacarte-maps/alacarte/contents/{+path}","compare_url":"https://api.github.com/repos/alacarte-maps/alacarte/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alacarte-maps/alacarte/merges","archive_url":"https://api.github.com/repos/alacarte-maps/alacarte/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alacarte-maps/alacarte/downloads","issues_url":"https://api.github.com/repos/alacarte-maps/alacarte/issues{/number}","pulls_url":"https://api.github.com/repos/alacarte-maps/alacarte/pulls{/number}","milestones_url":"https://api.github.com/repos/alacarte-maps/alacarte/milestones{/number}","notifications_url":"https://api.github.com/repos/alacarte-maps/alacarte/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alacarte-maps/alacarte/labels{/name}","releases_url":"https://api.github.com/repos/alacarte-maps/alacarte/releases{/id}","created_at":"2013-03-28T16:18:32Z","updated_at":"2015-10-14T18:02:26Z","pushed_at":"2015-10-15T14:01:27Z","git_url":"git://github.com/alacarte-maps/alacarte.git","ssh_url":"git@github.com:alacarte-maps/alacarte.git","clone_url":"https://github.com/alacarte-maps/alacarte.git","svn_url":"https://github.com/alacarte-maps/alacarte","homepage":"","size":4205,"stargazers_count":38,"watchers_count":38,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":17,"forks":13,"open_issues":17,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alacarte-maps/alacarte/pulls/50"},"html":{"href":"https://github.com/alacarte-maps/alacarte/pull/50"},"issue":{"href":"https://api.github.com/repos/alacarte-maps/alacarte/issues/50"},"comments":{"href":"https://api.github.com/repos/alacarte-maps/alacarte/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/alacarte-maps/alacarte/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/alacarte-maps/alacarte/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alacarte-maps/alacarte/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/alacarte-maps/alacarte/statuses/57c92df38a658b60d3ab6af67fbea92a242819c9"}}}}