{"action":"closed","issue":{"url":"https://api.github.com/repos/serilog/serilog/issues/513","labels_url":"https://api.github.com/repos/serilog/serilog/issues/513/labels{/name}","comments_url":"https://api.github.com/repos/serilog/serilog/issues/513/comments","events_url":"https://api.github.com/repos/serilog/serilog/issues/513/events","html_url":"https://github.com/serilog/serilog/issues/513","id":101874595,"number":513,"title":"Clean up tests for DNX","user":{"login":"khellang","id":582487,"avatar_url":"https://avatars.githubusercontent.com/u/582487?v=3","gravatar_id":"","url":"https://api.github.com/users/khellang","html_url":"https://github.com/khellang","followers_url":"https://api.github.com/users/khellang/followers","following_url":"https://api.github.com/users/khellang/following{/other_user}","gists_url":"https://api.github.com/users/khellang/gists{/gist_id}","starred_url":"https://api.github.com/users/khellang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khellang/subscriptions","organizations_url":"https://api.github.com/users/khellang/orgs","repos_url":"https://api.github.com/users/khellang/repos","events_url":"https://api.github.com/users/khellang/events{/privacy}","received_events_url":"https://api.github.com/users/khellang/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/serilog/serilog/milestones/11","html_url":"https://github.com/serilog/serilog/milestones/2.0.0-beta1","labels_url":"https://api.github.com/repos/serilog/serilog/milestones/11/labels","id":1263535,"number":11,"title":"2.0.0-beta1","description":"","creator":{"login":"nblumhardt","id":342712,"avatar_url":"https://avatars.githubusercontent.com/u/342712?v=3","gravatar_id":"","url":"https://api.github.com/users/nblumhardt","html_url":"https://github.com/nblumhardt","followers_url":"https://api.github.com/users/nblumhardt/followers","following_url":"https://api.github.com/users/nblumhardt/following{/other_user}","gists_url":"https://api.github.com/users/nblumhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/nblumhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nblumhardt/subscriptions","organizations_url":"https://api.github.com/users/nblumhardt/orgs","repos_url":"https://api.github.com/users/nblumhardt/repos","events_url":"https://api.github.com/users/nblumhardt/events{/privacy}","received_events_url":"https://api.github.com/users/nblumhardt/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":2,"state":"open","created_at":"2015-08-19T21:46:13Z","updated_at":"2015-11-20T21:31:56Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2015-08-19T11:56:36Z","updated_at":"2015-11-20T21:31:56Z","closed_at":"2015-11-20T21:31:56Z","body":"#512 migrated the tests over to xUnit to run them on DNX. In the process, a few issues came up:\r\n\r\n- [ ] 4 tests started failing for some reason. They were just skipped for now, but should be looked into and fixed:\r\n  - `Serilog.Extras.AppSettings.Tests.AppSettingsTests.EnvironmentVariableExpansionIsApplied`\r\n  - `Serilog.Extras.AppSettings.Tests.KeyValuePairSettingsTests.FindsConfigurationAssemblies`\r\n  - `Serilog.Tests.Context.LogContextTests.DoesNotPreventCrossDomainCalls`\r\n  - `Serilog.Tests.Sinks.PeriodicBatching.PeriodicBatchingSinkTests.WhenAnEventIsEnqueuedItIsWrittenToABatch_OnTimer`\r\n- [ ] xUnit does not have a concept of \"inconclusive tests\", either they pass, or they don't. There are a few tests in `Serilog.Tests.Context.LogContextTests` which used `Assert.Inconclusive`. These needs to be addressed.\r\n\r\nWe should also look into porting the rest of the test projects:\r\n\r\n - [ ] Serilog.MsTests\r\n - [ ] Serilog.PerformanceTests\r\n - [ ] Serilog.SmokeTest\r\n\r\nThe last 2 are not really test projects, but reside in the test folder. Maybe they should be (re)moved?"}}