{"action":"created","issue":{"url":"https://api.github.com/repos/rackt/react-router/issues/2166","labels_url":"https://api.github.com/repos/rackt/react-router/issues/2166/labels{/name}","comments_url":"https://api.github.com/repos/rackt/react-router/issues/2166/comments","events_url":"https://api.github.com/repos/rackt/react-router/issues/2166/events","html_url":"https://github.com/rackt/react-router/issues/2166","id":109796545,"number":2166,"title":"Typo (or misleading) in 1.0 upgrade guide","user":{"login":"elverskog","id":7500216,"avatar_url":"https://avatars.githubusercontent.com/u/7500216?v=3","gravatar_id":"","url":"https://api.github.com/users/elverskog","html_url":"https://github.com/elverskog","followers_url":"https://api.github.com/users/elverskog/followers","following_url":"https://api.github.com/users/elverskog/following{/other_user}","gists_url":"https://api.github.com/users/elverskog/gists{/gist_id}","starred_url":"https://api.github.com/users/elverskog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elverskog/subscriptions","organizations_url":"https://api.github.com/users/elverskog/orgs","repos_url":"https://api.github.com/users/elverskog/repos","events_url":"https://api.github.com/users/elverskog/events{/privacy}","received_events_url":"https://api.github.com/users/elverskog/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rackt/react-router/labels/needs-docs","name":"needs-docs","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-05T13:31:14Z","updated_at":"2015-10-05T13:50:39Z","closed_at":null,"body":"Looking at the latest examples in the repo it seems it is still \"activeStyle=...\" not \"activeStyles=...\". Right? I haven't upgraded yet.\r\n\r\nSee this line:\r\n\"In 0.13.x links added the \"active\" class by default which you could override with activeClassName, or provide activeStyles. Most links don't need this and the check is (currently) expensive.\"\r\n\r\nOn another note, it took me a good while to find any docs on how to set the active styling using inline styles (for the older version). With many people moving to the inline styles based solution, maybe this could be given more visibility in the docs?\r\n\r\nThanks for all the great work.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/rackt/react-router/issues/comments/145532950","html_url":"https://github.com/rackt/react-router/issues/2166#issuecomment-145532950","issue_url":"https://api.github.com/repos/rackt/react-router/issues/2166","id":145532950,"user":{"login":"elverskog","id":7500216,"avatar_url":"https://avatars.githubusercontent.com/u/7500216?v=3","gravatar_id":"","url":"https://api.github.com/users/elverskog","html_url":"https://github.com/elverskog","followers_url":"https://api.github.com/users/elverskog/followers","following_url":"https://api.github.com/users/elverskog/following{/other_user}","gists_url":"https://api.github.com/users/elverskog/gists{/gist_id}","starred_url":"https://api.github.com/users/elverskog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elverskog/subscriptions","organizations_url":"https://api.github.com/users/elverskog/orgs","repos_url":"https://api.github.com/users/elverskog/repos","events_url":"https://api.github.com/users/elverskog/events{/privacy}","received_events_url":"https://api.github.com/users/elverskog/received_events","type":"User","site_admin":false},"created_at":"2015-10-05T13:50:39Z","updated_at":"2015-10-05T13:50:39Z","body":"I would love to contribute to the docs but I won't much have time till after the 20th (stiff deadline). That said, I'll take another look through the current docs and maybe just write up a piece for the activeClass/activeStyle feature. Does that make sense?"}}