{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/comments/22551975","id":22551975,"diff_hunk":"@@ -106,7 +106,15 @@ puppet-admin: {\n \n ### `master.conf`\n \n-This file contains settings for the Puppet master functionality of Puppet Server. If `allow-header-cert-info` is set to 'true', this allows the `ssl_client_header` and `ssl_client_verify_header` options in puppet.conf to work. By default, this is set to 'false'.\n+This file contains settings for Puppet master features, such as node identification and authorization.\n+\n+In a default installation, this file doesn't exist. You'll need to create it if you want to set non-default values for these settings.\n+\n+* `allow-header-cert-info` determines whether Puppet Server should use authorization info from the `X-Client_Verify`, `X-Client-CN`, and `X-Client-Cert` HTTP headers. Defaults to `false`.\n+\n+    This setting is used to enable [external SSL termination.](./external_ssl_termination.markdown) If enabled, Puppet Server will ignore the actual certificate presented to the Jetty webserver, and will rely completely on header data to authorize requests. This is very dangerous unless you've secured your network to prevent any untrusted access to Puppet Server.","path":"documentation/configuration.markdown","position":11,"original_position":11,"commit_id":"c4442a5b020a05fc5f22c6a5979958df6f412651","original_commit_id":"c4442a5b020a05fc5f22c6a5979958df6f412651","user":{"login":"nfagerlund","id":484309,"avatar_url":"https://avatars.githubusercontent.com/u/484309?v=3","gravatar_id":"","url":"https://api.github.com/users/nfagerlund","html_url":"https://github.com/nfagerlund","followers_url":"https://api.github.com/users/nfagerlund/followers","following_url":"https://api.github.com/users/nfagerlund/following{/other_user}","gists_url":"https://api.github.com/users/nfagerlund/gists{/gist_id}","starred_url":"https://api.github.com/users/nfagerlund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfagerlund/subscriptions","organizations_url":"https://api.github.com/users/nfagerlund/orgs","repos_url":"https://api.github.com/users/nfagerlund/repos","events_url":"https://api.github.com/users/nfagerlund/events{/privacy}","received_events_url":"https://api.github.com/users/nfagerlund/received_events","type":"User","site_admin":false},"body":"Eh... nah. I think it's implicit here, and we go into enough extra detail on the guide to setting up external SSL.","created_at":"2015-01-06T21:05:52Z","updated_at":"2015-01-06T21:05:52Z","html_url":"https://github.com/puppetlabs/puppet-server/pull/349#discussion_r22551975","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/349","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/comments/22551975"},"html":{"href":"https://github.com/puppetlabs/puppet-server/pull/349#discussion_r22551975"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/349"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/349","id":26739687,"html_url":"https://github.com/puppetlabs/puppet-server/pull/349","diff_url":"https://github.com/puppetlabs/puppet-server/pull/349.diff","patch_url":"https://github.com/puppetlabs/puppet-server/pull/349.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/349","number":349,"state":"open","locked":false,"title":"(docs) Edit external SSL termination page for easier skimming","user":{"login":"nfagerlund","id":484309,"avatar_url":"https://avatars.githubusercontent.com/u/484309?v=3","gravatar_id":"","url":"https://api.github.com/users/nfagerlund","html_url":"https://github.com/nfagerlund","followers_url":"https://api.github.com/users/nfagerlund/followers","following_url":"https://api.github.com/users/nfagerlund/following{/other_user}","gists_url":"https://api.github.com/users/nfagerlund/gists{/gist_id}","starred_url":"https://api.github.com/users/nfagerlund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfagerlund/subscriptions","organizations_url":"https://api.github.com/users/nfagerlund/orgs","repos_url":"https://api.github.com/users/nfagerlund/repos","events_url":"https://api.github.com/users/nfagerlund/events{/privacy}","received_events_url":"https://api.github.com/users/nfagerlund/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-01-01T01:34:20Z","updated_at":"2015-01-06T21:05:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0dd862a067a1926ce2b9eaed51cd399f6701977f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/349/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/349/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/349/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet-server/statuses/c4442a5b020a05fc5f22c6a5979958df6f412651","head":{"label":"nfagerlund:docs_dec2014_external_ssl","ref":"docs_dec2014_external_ssl","sha":"c4442a5b020a05fc5f22c6a5979958df6f412651","user":{"login":"nfagerlund","id":484309,"avatar_url":"https://avatars.githubusercontent.com/u/484309?v=3","gravatar_id":"","url":"https://api.github.com/users/nfagerlund","html_url":"https://github.com/nfagerlund","followers_url":"https://api.github.com/users/nfagerlund/followers","following_url":"https://api.github.com/users/nfagerlund/following{/other_user}","gists_url":"https://api.github.com/users/nfagerlund/gists{/gist_id}","starred_url":"https://api.github.com/users/nfagerlund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfagerlund/subscriptions","organizations_url":"https://api.github.com/users/nfagerlund/orgs","repos_url":"https://api.github.com/users/nfagerlund/repos","events_url":"https://api.github.com/users/nfagerlund/events{/privacy}","received_events_url":"https://api.github.com/users/nfagerlund/received_events","type":"User","site_admin":false},"repo":{"id":27738479,"name":"puppet-server","full_name":"nfagerlund/puppet-server","owner":{"login":"nfagerlund","id":484309,"avatar_url":"https://avatars.githubusercontent.com/u/484309?v=3","gravatar_id":"","url":"https://api.github.com/users/nfagerlund","html_url":"https://github.com/nfagerlund","followers_url":"https://api.github.com/users/nfagerlund/followers","following_url":"https://api.github.com/users/nfagerlund/following{/other_user}","gists_url":"https://api.github.com/users/nfagerlund/gists{/gist_id}","starred_url":"https://api.github.com/users/nfagerlund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfagerlund/subscriptions","organizations_url":"https://api.github.com/users/nfagerlund/orgs","repos_url":"https://api.github.com/users/nfagerlund/repos","events_url":"https://api.github.com/users/nfagerlund/events{/privacy}","received_events_url":"https://api.github.com/users/nfagerlund/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nfagerlund/puppet-server","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/nfagerlund/puppet-server","forks_url":"https://api.github.com/repos/nfagerlund/puppet-server/forks","keys_url":"https://api.github.com/repos/nfagerlund/puppet-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nfagerlund/puppet-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nfagerlund/puppet-server/teams","hooks_url":"https://api.github.com/repos/nfagerlund/puppet-server/hooks","issue_events_url":"https://api.github.com/repos/nfagerlund/puppet-server/issues/events{/number}","events_url":"https://api.github.com/repos/nfagerlund/puppet-server/events","assignees_url":"https://api.github.com/repos/nfagerlund/puppet-server/assignees{/user}","branches_url":"https://api.github.com/repos/nfagerlund/puppet-server/branches{/branch}","tags_url":"https://api.github.com/repos/nfagerlund/puppet-server/tags","blobs_url":"https://api.github.com/repos/nfagerlund/puppet-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nfagerlund/puppet-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nfagerlund/puppet-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/nfagerlund/puppet-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nfagerlund/puppet-server/statuses/{sha}","languages_url":"https://api.github.com/repos/nfagerlund/puppet-server/languages","stargazers_url":"https://api.github.com/repos/nfagerlund/puppet-server/stargazers","contributors_url":"https://api.github.com/repos/nfagerlund/puppet-server/contributors","subscribers_url":"https://api.github.com/repos/nfagerlund/puppet-server/subscribers","subscription_url":"https://api.github.com/repos/nfagerlund/puppet-server/subscription","commits_url":"https://api.github.com/repos/nfagerlund/puppet-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/nfagerlund/puppet-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/nfagerlund/puppet-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/nfagerlund/puppet-server/issues/comments/{number}","contents_url":"https://api.github.com/repos/nfagerlund/puppet-server/contents/{+path}","compare_url":"https://api.github.com/repos/nfagerlund/puppet-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nfagerlund/puppet-server/merges","archive_url":"https://api.github.com/repos/nfagerlund/puppet-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nfagerlund/puppet-server/downloads","issues_url":"https://api.github.com/repos/nfagerlund/puppet-server/issues{/number}","pulls_url":"https://api.github.com/repos/nfagerlund/puppet-server/pulls{/number}","milestones_url":"https://api.github.com/repos/nfagerlund/puppet-server/milestones{/number}","notifications_url":"https://api.github.com/repos/nfagerlund/puppet-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nfagerlund/puppet-server/labels{/name}","releases_url":"https://api.github.com/repos/nfagerlund/puppet-server/releases{/id}","created_at":"2014-12-08T22:31:58Z","updated_at":"2014-12-08T22:31:59Z","pushed_at":"2015-01-06T00:12:28Z","git_url":"git://github.com/nfagerlund/puppet-server.git","ssh_url":"git@github.com:nfagerlund/puppet-server.git","clone_url":"https://github.com/nfagerlund/puppet-server.git","svn_url":"https://github.com/nfagerlund/puppet-server","homepage":"https://tickets.puppetlabs.com/browse/SERVER","size":1483,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:stable","ref":"stable","sha":"2dd0138b379389fa3ca4987b5197243e88a1c12a","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":19546488,"name":"puppet-server","full_name":"puppetlabs/puppet-server","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet-server","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet-server","forks_url":"https://api.github.com/repos/puppetlabs/puppet-server/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet-server/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet-server/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet-server/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet-server/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet-server/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet-server/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet-server/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet-server/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet-server/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet-server/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet-server/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet-server/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet-server/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet-server/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet-server/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet-server/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet-server/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet-server/releases{/id}","created_at":"2014-05-07T19:00:24Z","updated_at":"2015-01-06T01:39:22Z","pushed_at":"2015-01-06T01:39:22Z","git_url":"git://github.com/puppetlabs/puppet-server.git","ssh_url":"git@github.com:puppetlabs/puppet-server.git","clone_url":"https://github.com/puppetlabs/puppet-server.git","svn_url":"https://github.com/puppetlabs/puppet-server","homepage":"https://tickets.puppetlabs.com/browse/SERVER","size":3955,"stargazers_count":75,"watchers_count":75,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":7,"forks":38,"open_issues":7,"watchers":75,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/349"},"html":{"href":"https://github.com/puppetlabs/puppet-server/pull/349"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/issues/349"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/issues/349/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/349/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/349/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/statuses/c4442a5b020a05fc5f22c6a5979958df6f412651"}}}}