{"action":"created","comment":{"url":"https://api.github.com/repos/saschazelzer/CppMicroServices/pulls/comments/34329743","id":34329743,"diff_hunk":"@@ -31,6 +31,8 @@\n ","path":"core/include/usModuleSettings.h","position":1,"original_position":1,"commit_id":"60a7780d6e1fc39cfec6eadf97be2572fda7dca1","original_commit_id":"60a7780d6e1fc39cfec6eadf97be2572fda7dca1","user":{"login":"saschazelzer","id":219045,"avatar_url":"https://avatars.githubusercontent.com/u/219045?v=3","gravatar_id":"","url":"https://api.github.com/users/saschazelzer","html_url":"https://github.com/saschazelzer","followers_url":"https://api.github.com/users/saschazelzer/followers","following_url":"https://api.github.com/users/saschazelzer/following{/other_user}","gists_url":"https://api.github.com/users/saschazelzer/gists{/gist_id}","starred_url":"https://api.github.com/users/saschazelzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saschazelzer/subscriptions","organizations_url":"https://api.github.com/users/saschazelzer/orgs","repos_url":"https://api.github.com/users/saschazelzer/repos","events_url":"https://api.github.com/users/saschazelzer/events{/privacy}","received_events_url":"https://api.github.com/users/saschazelzer/received_events","type":"User","site_admin":false},"body":"We should use framework properties instead (can be done at some point later in time). Don't worry about the autoload stuff.","created_at":"2015-07-10T06:08:53Z","updated_at":"2015-07-10T06:08:53Z","html_url":"https://github.com/saschazelzer/CppMicroServices/pull/28#discussion_r34329743","pull_request_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/saschazelzer/CppMicroServices/pulls/comments/34329743"},"html":{"href":"https://github.com/saschazelzer/CppMicroServices/pull/28#discussion_r34329743"},"pull_request":{"href":"https://api.github.com/repos/saschazelzer/CppMicroServices/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/saschazelzer/CppMicroServices/pulls/28","id":39263380,"html_url":"https://github.com/saschazelzer/CppMicroServices/pull/28","diff_url":"https://github.com/saschazelzer/CppMicroServices/pull/28.diff","patch_url":"https://github.com/saschazelzer/CppMicroServices/pull/28.patch","issue_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/issues/28","number":28,"state":"open","locked":false,"title":"Design Review: Remove static globals prototype","user":{"login":"jeffdiclemente","id":12084496,"avatar_url":"https://avatars.githubusercontent.com/u/12084496?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffdiclemente","html_url":"https://github.com/jeffdiclemente","followers_url":"https://api.github.com/users/jeffdiclemente/followers","following_url":"https://api.github.com/users/jeffdiclemente/following{/other_user}","gists_url":"https://api.github.com/users/jeffdiclemente/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffdiclemente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffdiclemente/subscriptions","organizations_url":"https://api.github.com/users/jeffdiclemente/orgs","repos_url":"https://api.github.com/users/jeffdiclemente/repos","events_url":"https://api.github.com/users/jeffdiclemente/events{/privacy}","received_events_url":"https://api.github.com/users/jeffdiclemente/received_events","type":"User","site_admin":false},"body":"Static globals have been removed from CppMicroServices in this pull request.\r\n\r\nNOTE: This is a pull request for the purposes of a design review.\r\nPlease refer to the email I sent regarding caveats and specific areas of importance for this code.\r\n\r\n","created_at":"2015-07-06T12:40:45Z","updated_at":"2015-07-10T06:08:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78bed287888a1627e1d8f7a94d56065066730817","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/pulls/28/commits","review_comments_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/pulls/28/comments","review_comment_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/issues/28/comments","statuses_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/statuses/60a7780d6e1fc39cfec6eadf97be2572fda7dca1","head":{"label":"jeffdiclemente:remove-static-globals-prototype","ref":"remove-static-globals-prototype","sha":"60a7780d6e1fc39cfec6eadf97be2572fda7dca1","user":{"login":"jeffdiclemente","id":12084496,"avatar_url":"https://avatars.githubusercontent.com/u/12084496?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffdiclemente","html_url":"https://github.com/jeffdiclemente","followers_url":"https://api.github.com/users/jeffdiclemente/followers","following_url":"https://api.github.com/users/jeffdiclemente/following{/other_user}","gists_url":"https://api.github.com/users/jeffdiclemente/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffdiclemente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffdiclemente/subscriptions","organizations_url":"https://api.github.com/users/jeffdiclemente/orgs","repos_url":"https://api.github.com/users/jeffdiclemente/repos","events_url":"https://api.github.com/users/jeffdiclemente/events{/privacy}","received_events_url":"https://api.github.com/users/jeffdiclemente/received_events","type":"User","site_admin":false},"repo":{"id":35886093,"name":"CppMicroServices","full_name":"jeffdiclemente/CppMicroServices","owner":{"login":"jeffdiclemente","id":12084496,"avatar_url":"https://avatars.githubusercontent.com/u/12084496?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffdiclemente","html_url":"https://github.com/jeffdiclemente","followers_url":"https://api.github.com/users/jeffdiclemente/followers","following_url":"https://api.github.com/users/jeffdiclemente/following{/other_user}","gists_url":"https://api.github.com/users/jeffdiclemente/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffdiclemente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffdiclemente/subscriptions","organizations_url":"https://api.github.com/users/jeffdiclemente/orgs","repos_url":"https://api.github.com/users/jeffdiclemente/repos","events_url":"https://api.github.com/users/jeffdiclemente/events{/privacy}","received_events_url":"https://api.github.com/users/jeffdiclemente/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeffdiclemente/CppMicroServices","description":"An OSGi-like C++ dynamic module system and service registry","fork":true,"url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices","forks_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/forks","keys_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/teams","hooks_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/hooks","issue_events_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/issues/events{/number}","events_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/events","assignees_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/assignees{/user}","branches_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/branches{/branch}","tags_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/tags","blobs_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/statuses/{sha}","languages_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/languages","stargazers_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/stargazers","contributors_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/contributors","subscribers_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/subscribers","subscription_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/subscription","commits_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/contents/{+path}","compare_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/merges","archive_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/downloads","issues_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/issues{/number}","pulls_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/pulls{/number}","milestones_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/milestones{/number}","notifications_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/labels{/name}","releases_url":"https://api.github.com/repos/jeffdiclemente/CppMicroServices/releases{/id}","created_at":"2015-05-19T14:08:47Z","updated_at":"2015-05-27T12:43:47Z","pushed_at":"2015-07-06T12:34:43Z","git_url":"git://github.com/jeffdiclemente/CppMicroServices.git","ssh_url":"git@github.com:jeffdiclemente/CppMicroServices.git","clone_url":"https://github.com/jeffdiclemente/CppMicroServices.git","svn_url":"https://github.com/jeffdiclemente/CppMicroServices","homepage":"http://cppmicroservices.org","size":5095,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"saschazelzer:development","ref":"development","sha":"9741b4a8584f1f99037887c179e1a4911607711b","user":{"login":"saschazelzer","id":219045,"avatar_url":"https://avatars.githubusercontent.com/u/219045?v=3","gravatar_id":"","url":"https://api.github.com/users/saschazelzer","html_url":"https://github.com/saschazelzer","followers_url":"https://api.github.com/users/saschazelzer/followers","following_url":"https://api.github.com/users/saschazelzer/following{/other_user}","gists_url":"https://api.github.com/users/saschazelzer/gists{/gist_id}","starred_url":"https://api.github.com/users/saschazelzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saschazelzer/subscriptions","organizations_url":"https://api.github.com/users/saschazelzer/orgs","repos_url":"https://api.github.com/users/saschazelzer/repos","events_url":"https://api.github.com/users/saschazelzer/events{/privacy}","received_events_url":"https://api.github.com/users/saschazelzer/received_events","type":"User","site_admin":false},"repo":{"id":3569726,"name":"CppMicroServices","full_name":"saschazelzer/CppMicroServices","owner":{"login":"saschazelzer","id":219045,"avatar_url":"https://avatars.githubusercontent.com/u/219045?v=3","gravatar_id":"","url":"https://api.github.com/users/saschazelzer","html_url":"https://github.com/saschazelzer","followers_url":"https://api.github.com/users/saschazelzer/followers","following_url":"https://api.github.com/users/saschazelzer/following{/other_user}","gists_url":"https://api.github.com/users/saschazelzer/gists{/gist_id}","starred_url":"https://api.github.com/users/saschazelzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saschazelzer/subscriptions","organizations_url":"https://api.github.com/users/saschazelzer/orgs","repos_url":"https://api.github.com/users/saschazelzer/repos","events_url":"https://api.github.com/users/saschazelzer/events{/privacy}","received_events_url":"https://api.github.com/users/saschazelzer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saschazelzer/CppMicroServices","description":"An OSGi-like C++ dynamic module system and service registry","fork":false,"url":"https://api.github.com/repos/saschazelzer/CppMicroServices","forks_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/forks","keys_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/teams","hooks_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/hooks","issue_events_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/issues/events{/number}","events_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/events","assignees_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/assignees{/user}","branches_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/branches{/branch}","tags_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/tags","blobs_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/git/refs{/sha}","trees_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/statuses/{sha}","languages_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/languages","stargazers_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/stargazers","contributors_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/contributors","subscribers_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/subscribers","subscription_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/subscription","commits_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/commits{/sha}","git_commits_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/git/commits{/sha}","comments_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/comments{/number}","issue_comment_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/issues/comments{/number}","contents_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/contents/{+path}","compare_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/merges","archive_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/downloads","issues_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/issues{/number}","pulls_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/pulls{/number}","milestones_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/milestones{/number}","notifications_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/labels{/name}","releases_url":"https://api.github.com/repos/saschazelzer/CppMicroServices/releases{/id}","created_at":"2012-02-28T09:32:28Z","updated_at":"2015-05-31T14:32:40Z","pushed_at":"2015-07-07T22:39:36Z","git_url":"git://github.com/saschazelzer/CppMicroServices.git","ssh_url":"git@github.com:saschazelzer/CppMicroServices.git","clone_url":"https://github.com/saschazelzer/CppMicroServices.git","svn_url":"https://github.com/saschazelzer/CppMicroServices","homepage":"http://cppmicroservices.org","size":6115,"stargazers_count":57,"watchers_count":57,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"open_issues_count":4,"forks":18,"open_issues":4,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/saschazelzer/CppMicroServices/pulls/28"},"html":{"href":"https://github.com/saschazelzer/CppMicroServices/pull/28"},"issue":{"href":"https://api.github.com/repos/saschazelzer/CppMicroServices/issues/28"},"comments":{"href":"https://api.github.com/repos/saschazelzer/CppMicroServices/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/saschazelzer/CppMicroServices/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/saschazelzer/CppMicroServices/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saschazelzer/CppMicroServices/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/saschazelzer/CppMicroServices/statuses/60a7780d6e1fc39cfec6eadf97be2572fda7dca1"}}}}