{"action":"created","comment":{"url":"https://api.github.com/repos/baris/fullerite/pulls/comments/39798786","id":39798786,"diff_hunk":"@@ -11,12 +12,13 @@ import (\n \n func TestFulleriteConfigureEmptyConfig(t *testing.T) {\n \tconfig := make(map[string]interface{})\n-\tf := collector.NewFullerite()\n+\n+\tf := NewFullerite(nil, 123, nil)\n \tf.Configure(config)\n \n \tassert.Equal(t,\n \t\tf.Interval(),","path":"src/fullerite/collector/fullerite_test.go","position":21,"original_position":21,"commit_id":"a32357cec28091501e82ccc49cf30e1363652e91","original_commit_id":"ebdc4aedfa74158b5767bee9b0acc25b83717d1e","user":{"login":"ericchu94","id":7073910,"avatar_url":"https://avatars.githubusercontent.com/u/7073910?v=3","gravatar_id":"","url":"https://api.github.com/users/ericchu94","html_url":"https://github.com/ericchu94","followers_url":"https://api.github.com/users/ericchu94/followers","following_url":"https://api.github.com/users/ericchu94/following{/other_user}","gists_url":"https://api.github.com/users/ericchu94/gists{/gist_id}","starred_url":"https://api.github.com/users/ericchu94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericchu94/subscriptions","organizations_url":"https://api.github.com/users/ericchu94/orgs","repos_url":"https://api.github.com/users/ericchu94/repos","events_url":"https://api.github.com/users/ericchu94/events{/privacy}","received_events_url":"https://api.github.com/users/ericchu94/received_events","type":"User","site_admin":false},"body":"[assert.Equal](http://godoc.org/github.com/stretchr/testify/assert#Assertions.Equal) receives expected value first\r\n ","created_at":"2015-09-17T21:04:17Z","updated_at":"2015-09-17T21:04:17Z","html_url":"https://github.com/baris/fullerite/pull/40#discussion_r39798786","pull_request_url":"https://api.github.com/repos/baris/fullerite/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/baris/fullerite/pulls/comments/39798786"},"html":{"href":"https://github.com/baris/fullerite/pull/40#discussion_r39798786"},"pull_request":{"href":"https://api.github.com/repos/baris/fullerite/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/baris/fullerite/pulls/40","id":45336233,"html_url":"https://github.com/baris/fullerite/pull/40","diff_url":"https://github.com/baris/fullerite/pull/40.diff","patch_url":"https://github.com/baris/fullerite/pull/40.patch","issue_url":"https://api.github.com/repos/baris/fullerite/issues/40","number":40,"state":"open","locked":false,"title":"Refactor collectors","user":{"login":"squirrely","id":406376,"avatar_url":"https://avatars.githubusercontent.com/u/406376?v=3","gravatar_id":"","url":"https://api.github.com/users/squirrely","html_url":"https://github.com/squirrely","followers_url":"https://api.github.com/users/squirrely/followers","following_url":"https://api.github.com/users/squirrely/following{/other_user}","gists_url":"https://api.github.com/users/squirrely/gists{/gist_id}","starred_url":"https://api.github.com/users/squirrely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squirrely/subscriptions","organizations_url":"https://api.github.com/users/squirrely/orgs","repos_url":"https://api.github.com/users/squirrely/repos","events_url":"https://api.github.com/users/squirrely/events{/privacy}","received_events_url":"https://api.github.com/users/squirrely/received_events","type":"User","site_admin":false},"body":"This is part one of three to get the internal server working. It mainly is a refactor of the collectors to (1) inject values (2) build the fullerite http collector. There are linting issues but they are fixed later. ","created_at":"2015-09-17T20:14:11Z","updated_at":"2015-09-17T21:04:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b182f1f7fcb88c73e5add58044aba3b00e3cb595","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/baris/fullerite/pulls/40/commits","review_comments_url":"https://api.github.com/repos/baris/fullerite/pulls/40/comments","review_comment_url":"https://api.github.com/repos/baris/fullerite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/baris/fullerite/issues/40/comments","statuses_url":"https://api.github.com/repos/baris/fullerite/statuses/a32357cec28091501e82ccc49cf30e1363652e91","head":{"label":"baris:refactor_collectors","ref":"refactor_collectors","sha":"a32357cec28091501e82ccc49cf30e1363652e91","user":{"login":"baris","id":17591,"avatar_url":"https://avatars.githubusercontent.com/u/17591?v=3","gravatar_id":"","url":"https://api.github.com/users/baris","html_url":"https://github.com/baris","followers_url":"https://api.github.com/users/baris/followers","following_url":"https://api.github.com/users/baris/following{/other_user}","gists_url":"https://api.github.com/users/baris/gists{/gist_id}","starred_url":"https://api.github.com/users/baris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baris/subscriptions","organizations_url":"https://api.github.com/users/baris/orgs","repos_url":"https://api.github.com/users/baris/repos","events_url":"https://api.github.com/users/baris/events{/privacy}","received_events_url":"https://api.github.com/users/baris/received_events","type":"User","site_admin":false},"repo":{"id":39368384,"name":"fullerite","full_name":"baris/fullerite","owner":{"login":"baris","id":17591,"avatar_url":"https://avatars.githubusercontent.com/u/17591?v=3","gravatar_id":"","url":"https://api.github.com/users/baris","html_url":"https://github.com/baris","followers_url":"https://api.github.com/users/baris/followers","following_url":"https://api.github.com/users/baris/following{/other_user}","gists_url":"https://api.github.com/users/baris/gists{/gist_id}","starred_url":"https://api.github.com/users/baris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baris/subscriptions","organizations_url":"https://api.github.com/users/baris/orgs","repos_url":"https://api.github.com/users/baris/repos","events_url":"https://api.github.com/users/baris/events{/privacy}","received_events_url":"https://api.github.com/users/baris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/baris/fullerite","description":"Fullerite is a daemon which collect metrics periodically from various sources and sends them to different metric stores. Fullerite's pluggable architecture allows the users to implement collectors and handlers as they wish.","fork":false,"url":"https://api.github.com/repos/baris/fullerite","forks_url":"https://api.github.com/repos/baris/fullerite/forks","keys_url":"https://api.github.com/repos/baris/fullerite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/baris/fullerite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/baris/fullerite/teams","hooks_url":"https://api.github.com/repos/baris/fullerite/hooks","issue_events_url":"https://api.github.com/repos/baris/fullerite/issues/events{/number}","events_url":"https://api.github.com/repos/baris/fullerite/events","assignees_url":"https://api.github.com/repos/baris/fullerite/assignees{/user}","branches_url":"https://api.github.com/repos/baris/fullerite/branches{/branch}","tags_url":"https://api.github.com/repos/baris/fullerite/tags","blobs_url":"https://api.github.com/repos/baris/fullerite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/baris/fullerite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/baris/fullerite/git/refs{/sha}","trees_url":"https://api.github.com/repos/baris/fullerite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/baris/fullerite/statuses/{sha}","languages_url":"https://api.github.com/repos/baris/fullerite/languages","stargazers_url":"https://api.github.com/repos/baris/fullerite/stargazers","contributors_url":"https://api.github.com/repos/baris/fullerite/contributors","subscribers_url":"https://api.github.com/repos/baris/fullerite/subscribers","subscription_url":"https://api.github.com/repos/baris/fullerite/subscription","commits_url":"https://api.github.com/repos/baris/fullerite/commits{/sha}","git_commits_url":"https://api.github.com/repos/baris/fullerite/git/commits{/sha}","comments_url":"https://api.github.com/repos/baris/fullerite/comments{/number}","issue_comment_url":"https://api.github.com/repos/baris/fullerite/issues/comments{/number}","contents_url":"https://api.github.com/repos/baris/fullerite/contents/{+path}","compare_url":"https://api.github.com/repos/baris/fullerite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/baris/fullerite/merges","archive_url":"https://api.github.com/repos/baris/fullerite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/baris/fullerite/downloads","issues_url":"https://api.github.com/repos/baris/fullerite/issues{/number}","pulls_url":"https://api.github.com/repos/baris/fullerite/pulls{/number}","milestones_url":"https://api.github.com/repos/baris/fullerite/milestones{/number}","notifications_url":"https://api.github.com/repos/baris/fullerite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/baris/fullerite/labels{/name}","releases_url":"https://api.github.com/repos/baris/fullerite/releases{/id}","created_at":"2015-07-20T07:01:49Z","updated_at":"2015-09-16T18:43:39Z","pushed_at":"2015-09-17T20:49:25Z","git_url":"git://github.com/baris/fullerite.git","ssh_url":"git@github.com:baris/fullerite.git","clone_url":"https://github.com/baris/fullerite.git","svn_url":"https://github.com/baris/fullerite","homepage":"","size":1145,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":11,"forks":10,"open_issues":11,"watchers":10,"default_branch":"master"}},"base":{"label":"baris:master","ref":"master","sha":"2cd69638aca80c92e917dc22325266ee3273c79d","user":{"login":"baris","id":17591,"avatar_url":"https://avatars.githubusercontent.com/u/17591?v=3","gravatar_id":"","url":"https://api.github.com/users/baris","html_url":"https://github.com/baris","followers_url":"https://api.github.com/users/baris/followers","following_url":"https://api.github.com/users/baris/following{/other_user}","gists_url":"https://api.github.com/users/baris/gists{/gist_id}","starred_url":"https://api.github.com/users/baris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baris/subscriptions","organizations_url":"https://api.github.com/users/baris/orgs","repos_url":"https://api.github.com/users/baris/repos","events_url":"https://api.github.com/users/baris/events{/privacy}","received_events_url":"https://api.github.com/users/baris/received_events","type":"User","site_admin":false},"repo":{"id":39368384,"name":"fullerite","full_name":"baris/fullerite","owner":{"login":"baris","id":17591,"avatar_url":"https://avatars.githubusercontent.com/u/17591?v=3","gravatar_id":"","url":"https://api.github.com/users/baris","html_url":"https://github.com/baris","followers_url":"https://api.github.com/users/baris/followers","following_url":"https://api.github.com/users/baris/following{/other_user}","gists_url":"https://api.github.com/users/baris/gists{/gist_id}","starred_url":"https://api.github.com/users/baris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baris/subscriptions","organizations_url":"https://api.github.com/users/baris/orgs","repos_url":"https://api.github.com/users/baris/repos","events_url":"https://api.github.com/users/baris/events{/privacy}","received_events_url":"https://api.github.com/users/baris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/baris/fullerite","description":"Fullerite is a daemon which collect metrics periodically from various sources and sends them to different metric stores. Fullerite's pluggable architecture allows the users to implement collectors and handlers as they wish.","fork":false,"url":"https://api.github.com/repos/baris/fullerite","forks_url":"https://api.github.com/repos/baris/fullerite/forks","keys_url":"https://api.github.com/repos/baris/fullerite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/baris/fullerite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/baris/fullerite/teams","hooks_url":"https://api.github.com/repos/baris/fullerite/hooks","issue_events_url":"https://api.github.com/repos/baris/fullerite/issues/events{/number}","events_url":"https://api.github.com/repos/baris/fullerite/events","assignees_url":"https://api.github.com/repos/baris/fullerite/assignees{/user}","branches_url":"https://api.github.com/repos/baris/fullerite/branches{/branch}","tags_url":"https://api.github.com/repos/baris/fullerite/tags","blobs_url":"https://api.github.com/repos/baris/fullerite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/baris/fullerite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/baris/fullerite/git/refs{/sha}","trees_url":"https://api.github.com/repos/baris/fullerite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/baris/fullerite/statuses/{sha}","languages_url":"https://api.github.com/repos/baris/fullerite/languages","stargazers_url":"https://api.github.com/repos/baris/fullerite/stargazers","contributors_url":"https://api.github.com/repos/baris/fullerite/contributors","subscribers_url":"https://api.github.com/repos/baris/fullerite/subscribers","subscription_url":"https://api.github.com/repos/baris/fullerite/subscription","commits_url":"https://api.github.com/repos/baris/fullerite/commits{/sha}","git_commits_url":"https://api.github.com/repos/baris/fullerite/git/commits{/sha}","comments_url":"https://api.github.com/repos/baris/fullerite/comments{/number}","issue_comment_url":"https://api.github.com/repos/baris/fullerite/issues/comments{/number}","contents_url":"https://api.github.com/repos/baris/fullerite/contents/{+path}","compare_url":"https://api.github.com/repos/baris/fullerite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/baris/fullerite/merges","archive_url":"https://api.github.com/repos/baris/fullerite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/baris/fullerite/downloads","issues_url":"https://api.github.com/repos/baris/fullerite/issues{/number}","pulls_url":"https://api.github.com/repos/baris/fullerite/pulls{/number}","milestones_url":"https://api.github.com/repos/baris/fullerite/milestones{/number}","notifications_url":"https://api.github.com/repos/baris/fullerite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/baris/fullerite/labels{/name}","releases_url":"https://api.github.com/repos/baris/fullerite/releases{/id}","created_at":"2015-07-20T07:01:49Z","updated_at":"2015-09-16T18:43:39Z","pushed_at":"2015-09-17T20:49:25Z","git_url":"git://github.com/baris/fullerite.git","ssh_url":"git@github.com:baris/fullerite.git","clone_url":"https://github.com/baris/fullerite.git","svn_url":"https://github.com/baris/fullerite","homepage":"","size":1145,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":11,"forks":10,"open_issues":11,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/baris/fullerite/pulls/40"},"html":{"href":"https://github.com/baris/fullerite/pull/40"},"issue":{"href":"https://api.github.com/repos/baris/fullerite/issues/40"},"comments":{"href":"https://api.github.com/repos/baris/fullerite/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/baris/fullerite/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/baris/fullerite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/baris/fullerite/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/baris/fullerite/statuses/a32357cec28091501e82ccc49cf30e1363652e91"}}}}