{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/35372274","id":35372274,"diff_hunk":"@@ -335,15 +327,7 @@ def dismiss(self):\n         self.marionette.execute_script(\"\"\"\n var keyboard = navigator.mozKeyboard || navigator.mozInputMethod;\n keyboard.removeFocus();\"\"\")\n-        input_window = self.marionette.find_element(*self._input_window_locator)\n-\n-        # if we have software buttons, keyboar's y will not be 0 but the minus height of the button container.\n-        expected_y = int(input_window.size['height']) - System(self.marionette).software_buttons_height\n-\n-        Wait(self.marionette).until(\n-            lambda m: 'inactive' in input_window.get_attribute('class') and\n-            not input_window.is_displayed() and\n-            (int(input_window.location['y']) == expected_y))\n+        Wait(self.marionette).until(lambda m: self.is_keyboard_displayed is False)","path":"tests/python/gaia-ui-tests/gaiatest/apps/keyboard/app.py","position":34,"original_position":34,"commit_id":"702a9bd9c0b5248f653ccf7fe1643dadee2fa74d","original_commit_id":"702a9bd9c0b5248f653ccf7fe1643dadee2fa74d","user":{"login":"mwargers","id":2105568,"avatar_url":"https://avatars.githubusercontent.com/u/2105568?v=3","gravatar_id":"","url":"https://api.github.com/users/mwargers","html_url":"https://github.com/mwargers","followers_url":"https://api.github.com/users/mwargers/followers","following_url":"https://api.github.com/users/mwargers/following{/other_user}","gists_url":"https://api.github.com/users/mwargers/gists{/gist_id}","starred_url":"https://api.github.com/users/mwargers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwargers/subscriptions","organizations_url":"https://api.github.com/users/mwargers/orgs","repos_url":"https://api.github.com/users/mwargers/repos","events_url":"https://api.github.com/users/mwargers/events{/privacy}","received_events_url":"https://api.github.com/users/mwargers/received_events","type":"User","site_admin":false},"body":"In my opition input_window.is_displayed() should be enough in is_keyboard_displayed to consider the keyboard not visible from the screen.\r\nI don't really why that other condition is necessary.","created_at":"2015-07-23T21:14:11Z","updated_at":"2015-07-23T21:14:11Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/31082#discussion_r35372274","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/31082","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/35372274"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/31082#discussion_r35372274"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/31082"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/31082","id":40691570,"html_url":"https://github.com/mozilla-b2g/gaia/pull/31082","diff_url":"https://github.com/mozilla-b2g/gaia/pull/31082.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/31082.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/31082","number":31082,"state":"open","locked":false,"title":"Bug 1186893 - keyboard.is_keyboard_displayed is always returning true in current builds","user":{"login":"mwargers","id":2105568,"avatar_url":"https://avatars.githubusercontent.com/u/2105568?v=3","gravatar_id":"","url":"https://api.github.com/users/mwargers","html_url":"https://github.com/mwargers","followers_url":"https://api.github.com/users/mwargers/followers","following_url":"https://api.github.com/users/mwargers/following{/other_user}","gists_url":"https://api.github.com/users/mwargers/gists{/gist_id}","starred_url":"https://api.github.com/users/mwargers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwargers/subscriptions","organizations_url":"https://api.github.com/users/mwargers/orgs","repos_url":"https://api.github.com/users/mwargers/repos","events_url":"https://api.github.com/users/mwargers/events{/privacy}","received_events_url":"https://api.github.com/users/mwargers/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-07-23T16:32:25Z","updated_at":"2015-07-23T21:14:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be11ee5fd85bfb0baaad604b33452579428267ca","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/31082/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/31082/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/31082/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/702a9bd9c0b5248f653ccf7fe1643dadee2fa74d","head":{"label":"mwargers:1186893","ref":"1186893","sha":"702a9bd9c0b5248f653ccf7fe1643dadee2fa74d","user":{"login":"mwargers","id":2105568,"avatar_url":"https://avatars.githubusercontent.com/u/2105568?v=3","gravatar_id":"","url":"https://api.github.com/users/mwargers","html_url":"https://github.com/mwargers","followers_url":"https://api.github.com/users/mwargers/followers","following_url":"https://api.github.com/users/mwargers/following{/other_user}","gists_url":"https://api.github.com/users/mwargers/gists{/gist_id}","starred_url":"https://api.github.com/users/mwargers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwargers/subscriptions","organizations_url":"https://api.github.com/users/mwargers/orgs","repos_url":"https://api.github.com/users/mwargers/repos","events_url":"https://api.github.com/users/mwargers/events{/privacy}","received_events_url":"https://api.github.com/users/mwargers/received_events","type":"User","site_admin":false},"repo":{"id":24760261,"name":"gaia","full_name":"mwargers/gaia","owner":{"login":"mwargers","id":2105568,"avatar_url":"https://avatars.githubusercontent.com/u/2105568?v=3","gravatar_id":"","url":"https://api.github.com/users/mwargers","html_url":"https://github.com/mwargers","followers_url":"https://api.github.com/users/mwargers/followers","following_url":"https://api.github.com/users/mwargers/following{/other_user}","gists_url":"https://api.github.com/users/mwargers/gists{/gist_id}","starred_url":"https://api.github.com/users/mwargers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwargers/subscriptions","organizations_url":"https://api.github.com/users/mwargers/orgs","repos_url":"https://api.github.com/users/mwargers/repos","events_url":"https://api.github.com/users/mwargers/events{/privacy}","received_events_url":"https://api.github.com/users/mwargers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mwargers/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":true,"url":"https://api.github.com/repos/mwargers/gaia","forks_url":"https://api.github.com/repos/mwargers/gaia/forks","keys_url":"https://api.github.com/repos/mwargers/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mwargers/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mwargers/gaia/teams","hooks_url":"https://api.github.com/repos/mwargers/gaia/hooks","issue_events_url":"https://api.github.com/repos/mwargers/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mwargers/gaia/events","assignees_url":"https://api.github.com/repos/mwargers/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mwargers/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mwargers/gaia/tags","blobs_url":"https://api.github.com/repos/mwargers/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mwargers/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mwargers/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mwargers/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mwargers/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mwargers/gaia/languages","stargazers_url":"https://api.github.com/repos/mwargers/gaia/stargazers","contributors_url":"https://api.github.com/repos/mwargers/gaia/contributors","subscribers_url":"https://api.github.com/repos/mwargers/gaia/subscribers","subscription_url":"https://api.github.com/repos/mwargers/gaia/subscription","commits_url":"https://api.github.com/repos/mwargers/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mwargers/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mwargers/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mwargers/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mwargers/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mwargers/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mwargers/gaia/merges","archive_url":"https://api.github.com/repos/mwargers/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mwargers/gaia/downloads","issues_url":"https://api.github.com/repos/mwargers/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mwargers/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mwargers/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mwargers/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mwargers/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mwargers/gaia/releases{/id}","created_at":"2014-10-03T13:54:50Z","updated_at":"2014-10-09T15:24:59Z","pushed_at":"2015-07-23T16:31:56Z","git_url":"git://github.com/mwargers/gaia.git","ssh_url":"git@github.com:mwargers/gaia.git","clone_url":"https://github.com/mwargers/gaia.git","svn_url":"https://github.com/mwargers/gaia","homepage":"https://wiki.mozilla.org/B2G","size":940373,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"8d4d0bb88f61e72554ab68e51282f08e1be536b6","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2015-07-21T15:21:43Z","pushed_at":"2015-07-23T21:10:05Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1657207,"stargazers_count":1957,"watchers_count":1957,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2374,"mirror_url":null,"open_issues_count":1093,"forks":2374,"open_issues":1093,"watchers":1957,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/31082"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/31082"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/31082"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/31082/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/31082/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/31082/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/702a9bd9c0b5248f653ccf7fe1643dadee2fa74d"}}}}