{"action":"closed","number":1953,"pull_request":{"url":"https://api.github.com/repos/cisco/openh264/pulls/1953","id":35497849,"html_url":"https://github.com/cisco/openh264/pull/1953","diff_url":"https://github.com/cisco/openh264/pull/1953.diff","patch_url":"https://github.com/cisco/openh264/pull/1953.patch","issue_url":"https://api.github.com/repos/cisco/openh264/issues/1953","number":1953,"state":"closed","locked":false,"title":"Remove tabs from multiline comments, public headers, enums and lists of defines","user":{"login":"mstorsjo","id":69727,"avatar_url":"https://avatars.githubusercontent.com/u/69727?v=3","gravatar_id":"","url":"https://api.github.com/users/mstorsjo","html_url":"https://github.com/mstorsjo","followers_url":"https://api.github.com/users/mstorsjo/followers","following_url":"https://api.github.com/users/mstorsjo/following{/other_user}","gists_url":"https://api.github.com/users/mstorsjo/gists{/gist_id}","starred_url":"https://api.github.com/users/mstorsjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstorsjo/subscriptions","organizations_url":"https://api.github.com/users/mstorsjo/orgs","repos_url":"https://api.github.com/users/mstorsjo/repos","events_url":"https://api.github.com/users/mstorsjo/events{/privacy}","received_events_url":"https://api.github.com/users/mstorsjo/received_events","type":"User","site_admin":false},"body":"The astyle configuration makes sure normal code is indented consistently\r\nwith 2 spaces, but astyle doesn't seem to touch the indentation in\r\nthese multi-line macros and within lines (such as in tables).\r\n\r\nThere's plenty more cases of stray tabs in the codebase that ruin the code\r\nreadability, but I'm sending the cleanup in small pieces to ease review\r\nand readability of the cleanup.\r\n\r\nReview at https://rbcommons.com/s/OpenH264/r/1216/.","created_at":"2015-05-15T09:33:25Z","updated_at":"2015-05-15T10:09:03Z","closed_at":"2015-05-15T10:09:02Z","merged_at":"2015-05-15T10:09:02Z","merge_commit_sha":"1616ffd724da348148403bd1606b8cd8235da292","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cisco/openh264/pulls/1953/commits","review_comments_url":"https://api.github.com/repos/cisco/openh264/pulls/1953/comments","review_comment_url":"https://api.github.com/repos/cisco/openh264/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cisco/openh264/issues/1953/comments","statuses_url":"https://api.github.com/repos/cisco/openh264/statuses/df994fa3f5840a48b8b651573c2394b671655ce8","head":{"label":"mstorsjo:remove-tabs","ref":"remove-tabs","sha":"df994fa3f5840a48b8b651573c2394b671655ce8","user":{"login":"mstorsjo","id":69727,"avatar_url":"https://avatars.githubusercontent.com/u/69727?v=3","gravatar_id":"","url":"https://api.github.com/users/mstorsjo","html_url":"https://github.com/mstorsjo","followers_url":"https://api.github.com/users/mstorsjo/followers","following_url":"https://api.github.com/users/mstorsjo/following{/other_user}","gists_url":"https://api.github.com/users/mstorsjo/gists{/gist_id}","starred_url":"https://api.github.com/users/mstorsjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstorsjo/subscriptions","organizations_url":"https://api.github.com/users/mstorsjo/orgs","repos_url":"https://api.github.com/users/mstorsjo/repos","events_url":"https://api.github.com/users/mstorsjo/events{/privacy}","received_events_url":"https://api.github.com/users/mstorsjo/received_events","type":"User","site_admin":false},"repo":{"id":15137671,"name":"openh264","full_name":"mstorsjo/openh264","owner":{"login":"mstorsjo","id":69727,"avatar_url":"https://avatars.githubusercontent.com/u/69727?v=3","gravatar_id":"","url":"https://api.github.com/users/mstorsjo","html_url":"https://github.com/mstorsjo","followers_url":"https://api.github.com/users/mstorsjo/followers","following_url":"https://api.github.com/users/mstorsjo/following{/other_user}","gists_url":"https://api.github.com/users/mstorsjo/gists{/gist_id}","starred_url":"https://api.github.com/users/mstorsjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstorsjo/subscriptions","organizations_url":"https://api.github.com/users/mstorsjo/orgs","repos_url":"https://api.github.com/users/mstorsjo/repos","events_url":"https://api.github.com/users/mstorsjo/events{/privacy}","received_events_url":"https://api.github.com/users/mstorsjo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mstorsjo/openh264","description":"Open Source H.264 Codec ","fork":true,"url":"https://api.github.com/repos/mstorsjo/openh264","forks_url":"https://api.github.com/repos/mstorsjo/openh264/forks","keys_url":"https://api.github.com/repos/mstorsjo/openh264/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mstorsjo/openh264/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mstorsjo/openh264/teams","hooks_url":"https://api.github.com/repos/mstorsjo/openh264/hooks","issue_events_url":"https://api.github.com/repos/mstorsjo/openh264/issues/events{/number}","events_url":"https://api.github.com/repos/mstorsjo/openh264/events","assignees_url":"https://api.github.com/repos/mstorsjo/openh264/assignees{/user}","branches_url":"https://api.github.com/repos/mstorsjo/openh264/branches{/branch}","tags_url":"https://api.github.com/repos/mstorsjo/openh264/tags","blobs_url":"https://api.github.com/repos/mstorsjo/openh264/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mstorsjo/openh264/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mstorsjo/openh264/git/refs{/sha}","trees_url":"https://api.github.com/repos/mstorsjo/openh264/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mstorsjo/openh264/statuses/{sha}","languages_url":"https://api.github.com/repos/mstorsjo/openh264/languages","stargazers_url":"https://api.github.com/repos/mstorsjo/openh264/stargazers","contributors_url":"https://api.github.com/repos/mstorsjo/openh264/contributors","subscribers_url":"https://api.github.com/repos/mstorsjo/openh264/subscribers","subscription_url":"https://api.github.com/repos/mstorsjo/openh264/subscription","commits_url":"https://api.github.com/repos/mstorsjo/openh264/commits{/sha}","git_commits_url":"https://api.github.com/repos/mstorsjo/openh264/git/commits{/sha}","comments_url":"https://api.github.com/repos/mstorsjo/openh264/comments{/number}","issue_comment_url":"https://api.github.com/repos/mstorsjo/openh264/issues/comments{/number}","contents_url":"https://api.github.com/repos/mstorsjo/openh264/contents/{+path}","compare_url":"https://api.github.com/repos/mstorsjo/openh264/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mstorsjo/openh264/merges","archive_url":"https://api.github.com/repos/mstorsjo/openh264/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mstorsjo/openh264/downloads","issues_url":"https://api.github.com/repos/mstorsjo/openh264/issues{/number}","pulls_url":"https://api.github.com/repos/mstorsjo/openh264/pulls{/number}","milestones_url":"https://api.github.com/repos/mstorsjo/openh264/milestones{/number}","notifications_url":"https://api.github.com/repos/mstorsjo/openh264/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mstorsjo/openh264/labels{/name}","releases_url":"https://api.github.com/repos/mstorsjo/openh264/releases{/id}","created_at":"2013-12-12T14:12:50Z","updated_at":"2015-05-05T06:21:41Z","pushed_at":"2015-05-15T10:07:26Z","git_url":"git://github.com/mstorsjo/openh264.git","ssh_url":"git@github.com:mstorsjo/openh264.git","clone_url":"https://github.com/mstorsjo/openh264.git","svn_url":"https://github.com/mstorsjo/openh264","homepage":null,"size":55976,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"cisco:master","ref":"master","sha":"853423b5ada4f731ee5159a08ae4c44f0e1f68e7","user":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"repo":{"id":13909573,"name":"openh264","full_name":"cisco/openh264","owner":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cisco/openh264","description":"Open Source H.264 Codec ","fork":false,"url":"https://api.github.com/repos/cisco/openh264","forks_url":"https://api.github.com/repos/cisco/openh264/forks","keys_url":"https://api.github.com/repos/cisco/openh264/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cisco/openh264/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cisco/openh264/teams","hooks_url":"https://api.github.com/repos/cisco/openh264/hooks","issue_events_url":"https://api.github.com/repos/cisco/openh264/issues/events{/number}","events_url":"https://api.github.com/repos/cisco/openh264/events","assignees_url":"https://api.github.com/repos/cisco/openh264/assignees{/user}","branches_url":"https://api.github.com/repos/cisco/openh264/branches{/branch}","tags_url":"https://api.github.com/repos/cisco/openh264/tags","blobs_url":"https://api.github.com/repos/cisco/openh264/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cisco/openh264/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cisco/openh264/git/refs{/sha}","trees_url":"https://api.github.com/repos/cisco/openh264/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cisco/openh264/statuses/{sha}","languages_url":"https://api.github.com/repos/cisco/openh264/languages","stargazers_url":"https://api.github.com/repos/cisco/openh264/stargazers","contributors_url":"https://api.github.com/repos/cisco/openh264/contributors","subscribers_url":"https://api.github.com/repos/cisco/openh264/subscribers","subscription_url":"https://api.github.com/repos/cisco/openh264/subscription","commits_url":"https://api.github.com/repos/cisco/openh264/commits{/sha}","git_commits_url":"https://api.github.com/repos/cisco/openh264/git/commits{/sha}","comments_url":"https://api.github.com/repos/cisco/openh264/comments{/number}","issue_comment_url":"https://api.github.com/repos/cisco/openh264/issues/comments{/number}","contents_url":"https://api.github.com/repos/cisco/openh264/contents/{+path}","compare_url":"https://api.github.com/repos/cisco/openh264/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cisco/openh264/merges","archive_url":"https://api.github.com/repos/cisco/openh264/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cisco/openh264/downloads","issues_url":"https://api.github.com/repos/cisco/openh264/issues{/number}","pulls_url":"https://api.github.com/repos/cisco/openh264/pulls{/number}","milestones_url":"https://api.github.com/repos/cisco/openh264/milestones{/number}","notifications_url":"https://api.github.com/repos/cisco/openh264/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cisco/openh264/labels{/name}","releases_url":"https://api.github.com/repos/cisco/openh264/releases{/id}","created_at":"2013-10-27T20:20:31Z","updated_at":"2015-05-15T01:27:01Z","pushed_at":"2015-05-15T10:09:02Z","git_url":"git://github.com/cisco/openh264.git","ssh_url":"git@github.com:cisco/openh264.git","clone_url":"https://github.com/cisco/openh264.git","svn_url":"https://github.com/cisco/openh264","homepage":null,"size":64706,"stargazers_count":1610,"watchers_count":1610,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":375,"mirror_url":null,"open_issues_count":27,"forks":375,"open_issues":27,"watchers":1610,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cisco/openh264/pulls/1953"},"html":{"href":"https://github.com/cisco/openh264/pull/1953"},"issue":{"href":"https://api.github.com/repos/cisco/openh264/issues/1953"},"comments":{"href":"https://api.github.com/repos/cisco/openh264/issues/1953/comments"},"review_comments":{"href":"https://api.github.com/repos/cisco/openh264/pulls/1953/comments"},"review_comment":{"href":"https://api.github.com/repos/cisco/openh264/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cisco/openh264/pulls/1953/commits"},"statuses":{"href":"https://api.github.com/repos/cisco/openh264/statuses/df994fa3f5840a48b8b651573c2394b671655ce8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"sijchen","id":6100918,"avatar_url":"https://avatars.githubusercontent.com/u/6100918?v=3","gravatar_id":"","url":"https://api.github.com/users/sijchen","html_url":"https://github.com/sijchen","followers_url":"https://api.github.com/users/sijchen/followers","following_url":"https://api.github.com/users/sijchen/following{/other_user}","gists_url":"https://api.github.com/users/sijchen/gists{/gist_id}","starred_url":"https://api.github.com/users/sijchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijchen/subscriptions","organizations_url":"https://api.github.com/users/sijchen/orgs","repos_url":"https://api.github.com/users/sijchen/repos","events_url":"https://api.github.com/users/sijchen/events{/privacy}","received_events_url":"https://api.github.com/users/sijchen/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":3,"additions":1126,"deletions":1127,"changed_files":81}}