{"action":"created","comment":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/40894022","id":40894022,"diff_hunk":"@@ -56,21 +56,6 @@ public final void setClassLoader(final ClassLoader classLoader) {\n    }\n \n    @Override\n-   public boolean replaceValue(final Object key, final InternalCacheEntry cacheEntry) {\n-      CacheEntry ce = lookupEntry(key);\n-      if (ce == null || ce.isNull() || ce.getValue() == null) {\n-         if (ce != null) {\n-            ce.setValue(cacheEntry.getValue());\n-            ce.setMetadata(cacheEntry.getMetadata());\n-            onEntryValueReplaced(key, cacheEntry);","path":"core/src/main/java/org/infinispan/context/impl/AbstractInvocationContext.java","position":10,"original_position":10,"commit_id":"24e79fe885af5470f6120cd8137993810bdbd3a3","original_commit_id":"24e79fe885af5470f6120cd8137993810bdbd3a3","user":{"login":"pruivo","id":1492066,"avatar_url":"https://avatars.githubusercontent.com/u/1492066?v=3","gravatar_id":"","url":"https://api.github.com/users/pruivo","html_url":"https://github.com/pruivo","followers_url":"https://api.github.com/users/pruivo/followers","following_url":"https://api.github.com/users/pruivo/following{/other_user}","gists_url":"https://api.github.com/users/pruivo/gists{/gist_id}","starred_url":"https://api.github.com/users/pruivo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pruivo/subscriptions","organizations_url":"https://api.github.com/users/pruivo/orgs","repos_url":"https://api.github.com/users/pruivo/repos","events_url":"https://api.github.com/users/pruivo/events{/privacy}","received_events_url":"https://api.github.com/users/pruivo/received_events","type":"User","site_admin":false},"body":"```onEntryValueReplaced``` method can be removed.","created_at":"2015-10-01T09:24:07Z","updated_at":"2015-10-01T09:24:07Z","html_url":"https://github.com/infinispan/infinispan/pull/3705#discussion_r40894022","pull_request_url":"https://api.github.com/repos/infinispan/infinispan/pulls/3705","_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/40894022"},"html":{"href":"https://github.com/infinispan/infinispan/pull/3705#discussion_r40894022"},"pull_request":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/3705"}}},"pull_request":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/3705","id":45015661,"html_url":"https://github.com/infinispan/infinispan/pull/3705","diff_url":"https://github.com/infinispan/infinispan/pull/3705.diff","patch_url":"https://github.com/infinispan/infinispan/pull/3705.patch","issue_url":"https://api.github.com/repos/infinispan/infinispan/issues/3705","number":3705,"state":"open","locked":false,"title":"ISPN-5699 Simplify entry wrapping","user":{"login":"danberindei","id":504907,"avatar_url":"https://avatars.githubusercontent.com/u/504907?v=3","gravatar_id":"","url":"https://api.github.com/users/danberindei","html_url":"https://github.com/danberindei","followers_url":"https://api.github.com/users/danberindei/followers","following_url":"https://api.github.com/users/danberindei/following{/other_user}","gists_url":"https://api.github.com/users/danberindei/gists{/gist_id}","starred_url":"https://api.github.com/users/danberindei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danberindei/subscriptions","organizations_url":"https://api.github.com/users/danberindei/orgs","repos_url":"https://api.github.com/users/danberindei/repos","events_url":"https://api.github.com/users/danberindei/events{/privacy}","received_events_url":"https://api.github.com/users/danberindei/received_events","type":"User","site_admin":false},"body":"https://issues.jboss.org/browse/ISPN-5699\r\n\r\n * Unify the wrapping for write commands in a single method,\r\n   EntryFactory.wrapEntryForWriting\r\n * Add a separate method to update the value from loaders\r\n   or remote nodes, EntryFactory.wrapExternalEntry\r\n * Remove entry creation notification from EntryFactoryImpl\r\n * Remove provided metadata handling from EntryFactoryImpl\r\n * Deprecate CacheEntry.isLoaded\r\n * Deprecate EntryFactory.wrapEntryForClear\r\n * Deprecate InvocationContext.replaceValue\r\n * Always wrap for putForExternalRead, not just when the\r\n   entry does not exist in the data container","created_at":"2015-09-15T07:10:32Z","updated_at":"2015-10-01T09:24:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eeecfeaf01619ad708918b9d062d742c5cfe061c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/infinispan/infinispan/pulls/3705/commits","review_comments_url":"https://api.github.com/repos/infinispan/infinispan/pulls/3705/comments","review_comment_url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/infinispan/infinispan/issues/3705/comments","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/24e79fe885af5470f6120cd8137993810bdbd3a3","head":{"label":"danberindei:ISPN-5699_entry_wrapping","ref":"ISPN-5699_entry_wrapping","sha":"24e79fe885af5470f6120cd8137993810bdbd3a3","user":{"login":"danberindei","id":504907,"avatar_url":"https://avatars.githubusercontent.com/u/504907?v=3","gravatar_id":"","url":"https://api.github.com/users/danberindei","html_url":"https://github.com/danberindei","followers_url":"https://api.github.com/users/danberindei/followers","following_url":"https://api.github.com/users/danberindei/following{/other_user}","gists_url":"https://api.github.com/users/danberindei/gists{/gist_id}","starred_url":"https://api.github.com/users/danberindei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danberindei/subscriptions","organizations_url":"https://api.github.com/users/danberindei/orgs","repos_url":"https://api.github.com/users/danberindei/repos","events_url":"https://api.github.com/users/danberindei/events{/privacy}","received_events_url":"https://api.github.com/users/danberindei/received_events","type":"User","site_admin":false},"repo":{"id":1128600,"name":"infinispan","full_name":"danberindei/infinispan","owner":{"login":"danberindei","id":504907,"avatar_url":"https://avatars.githubusercontent.com/u/504907?v=3","gravatar_id":"","url":"https://api.github.com/users/danberindei","html_url":"https://github.com/danberindei","followers_url":"https://api.github.com/users/danberindei/followers","following_url":"https://api.github.com/users/danberindei/following{/other_user}","gists_url":"https://api.github.com/users/danberindei/gists{/gist_id}","starred_url":"https://api.github.com/users/danberindei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danberindei/subscriptions","organizations_url":"https://api.github.com/users/danberindei/orgs","repos_url":"https://api.github.com/users/danberindei/repos","events_url":"https://api.github.com/users/danberindei/events{/privacy}","received_events_url":"https://api.github.com/users/danberindei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danberindei/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":true,"url":"https://api.github.com/repos/danberindei/infinispan","forks_url":"https://api.github.com/repos/danberindei/infinispan/forks","keys_url":"https://api.github.com/repos/danberindei/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danberindei/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danberindei/infinispan/teams","hooks_url":"https://api.github.com/repos/danberindei/infinispan/hooks","issue_events_url":"https://api.github.com/repos/danberindei/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/danberindei/infinispan/events","assignees_url":"https://api.github.com/repos/danberindei/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/danberindei/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/danberindei/infinispan/tags","blobs_url":"https://api.github.com/repos/danberindei/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danberindei/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danberindei/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/danberindei/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danberindei/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/danberindei/infinispan/languages","stargazers_url":"https://api.github.com/repos/danberindei/infinispan/stargazers","contributors_url":"https://api.github.com/repos/danberindei/infinispan/contributors","subscribers_url":"https://api.github.com/repos/danberindei/infinispan/subscribers","subscription_url":"https://api.github.com/repos/danberindei/infinispan/subscription","commits_url":"https://api.github.com/repos/danberindei/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/danberindei/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/danberindei/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/danberindei/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/danberindei/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/danberindei/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danberindei/infinispan/merges","archive_url":"https://api.github.com/repos/danberindei/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danberindei/infinispan/downloads","issues_url":"https://api.github.com/repos/danberindei/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/danberindei/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/danberindei/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/danberindei/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danberindei/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/danberindei/infinispan/releases{/id}","created_at":"2010-12-01T12:42:11Z","updated_at":"2015-05-05T12:41:53Z","pushed_at":"2015-09-29T10:17:58Z","git_url":"git://github.com/danberindei/infinispan.git","ssh_url":"git@github.com:danberindei/infinispan.git","clone_url":"https://github.com/danberindei/infinispan.git","svn_url":"https://github.com/danberindei/infinispan","homepage":"http://www.infinispan.org","size":102025,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"infinispan:master","ref":"master","sha":"3cbc384e4ce6578baf8cb638bcd0abd4d354173d","user":{"login":"infinispan","id":458093,"avatar_url":"https://avatars.githubusercontent.com/u/458093?v=3","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"repo":{"id":1050944,"name":"infinispan","full_name":"infinispan/infinispan","owner":{"login":"infinispan","id":458093,"avatar_url":"https://avatars.githubusercontent.com/u/458093?v=3","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/infinispan/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":false,"url":"https://api.github.com/repos/infinispan/infinispan","forks_url":"https://api.github.com/repos/infinispan/infinispan/forks","keys_url":"https://api.github.com/repos/infinispan/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infinispan/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infinispan/infinispan/teams","hooks_url":"https://api.github.com/repos/infinispan/infinispan/hooks","issue_events_url":"https://api.github.com/repos/infinispan/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/infinispan/infinispan/events","assignees_url":"https://api.github.com/repos/infinispan/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/infinispan/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/infinispan/infinispan/tags","blobs_url":"https://api.github.com/repos/infinispan/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infinispan/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infinispan/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/infinispan/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/infinispan/infinispan/languages","stargazers_url":"https://api.github.com/repos/infinispan/infinispan/stargazers","contributors_url":"https://api.github.com/repos/infinispan/infinispan/contributors","subscribers_url":"https://api.github.com/repos/infinispan/infinispan/subscribers","subscription_url":"https://api.github.com/repos/infinispan/infinispan/subscription","commits_url":"https://api.github.com/repos/infinispan/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/infinispan/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/infinispan/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/infinispan/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/infinispan/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/infinispan/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infinispan/infinispan/merges","archive_url":"https://api.github.com/repos/infinispan/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infinispan/infinispan/downloads","issues_url":"https://api.github.com/repos/infinispan/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/infinispan/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/infinispan/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/infinispan/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infinispan/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/infinispan/infinispan/releases{/id}","created_at":"2010-11-04T12:33:19Z","updated_at":"2015-09-23T15:56:17Z","pushed_at":"2015-10-01T09:23:15Z","git_url":"git://github.com/infinispan/infinispan.git","ssh_url":"git@github.com:infinispan/infinispan.git","clone_url":"https://github.com/infinispan/infinispan.git","svn_url":"https://github.com/infinispan/infinispan","homepage":"http://www.infinispan.org","size":157606,"stargazers_count":412,"watchers_count":412,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":300,"mirror_url":null,"open_issues_count":10,"forks":300,"open_issues":10,"watchers":412,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/3705"},"html":{"href":"https://github.com/infinispan/infinispan/pull/3705"},"issue":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/3705"},"comments":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/3705/comments"},"review_comments":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/3705/comments"},"review_comment":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/3705/commits"},"statuses":{"href":"https://api.github.com/repos/infinispan/infinispan/statuses/24e79fe885af5470f6120cd8137993810bdbd3a3"}}}}