{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/smart-answers/issues/1613","labels_url":"https://api.github.com/repos/alphagov/smart-answers/issues/1613/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/smart-answers/issues/1613/comments","events_url":"https://api.github.com/repos/alphagov/smart-answers/issues/1613/events","html_url":"https://github.com/alphagov/smart-answers/pull/1613","id":74327722,"number":1613,"title":"Do not set HTTP Cache-Control expiry time header by default in test environment","user":{"login":"floehopper","id":3169,"avatar_url":"https://avatars.githubusercontent.com/u/3169?v=3","gravatar_id":"","url":"https://api.github.com/users/floehopper","html_url":"https://github.com/floehopper","followers_url":"https://api.github.com/users/floehopper/followers","following_url":"https://api.github.com/users/floehopper/following{/other_user}","gists_url":"https://api.github.com/users/floehopper/gists{/gist_id}","starred_url":"https://api.github.com/users/floehopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floehopper/subscriptions","organizations_url":"https://api.github.com/users/floehopper/orgs","repos_url":"https://api.github.com/users/floehopper/repos","events_url":"https://api.github.com/users/floehopper/events{/privacy}","received_events_url":"https://api.github.com/users/floehopper/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-08T11:17:09Z","updated_at":"2015-05-08T14:43:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/alphagov/smart-answers/pulls/1613","html_url":"https://github.com/alphagov/smart-answers/pull/1613","diff_url":"https://github.com/alphagov/smart-answers/pull/1613.diff","patch_url":"https://github.com/alphagov/smart-answers/pull/1613.patch"},"body":"It feels safer/less surprising to disable any caching mechanisms by default\r\nin the `test` environment and just enable them for the tests that need them.\r\n\r\nI've checked and the tests now pass with the seed mentioned in #1612 for\r\nboth `phantomjs` v1.9.8 and v2.0.0. Fixes #1612\r\n"},"comment":{"url":"https://api.github.com/repos/alphagov/smart-answers/issues/comments/100255299","html_url":"https://github.com/alphagov/smart-answers/pull/1613#issuecomment-100255299","issue_url":"https://api.github.com/repos/alphagov/smart-answers/issues/1613","id":100255299,"user":{"login":"tadast","id":218239,"avatar_url":"https://avatars.githubusercontent.com/u/218239?v=3","gravatar_id":"","url":"https://api.github.com/users/tadast","html_url":"https://github.com/tadast","followers_url":"https://api.github.com/users/tadast/followers","following_url":"https://api.github.com/users/tadast/following{/other_user}","gists_url":"https://api.github.com/users/tadast/gists{/gist_id}","starred_url":"https://api.github.com/users/tadast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tadast/subscriptions","organizations_url":"https://api.github.com/users/tadast/orgs","repos_url":"https://api.github.com/users/tadast/repos","events_url":"https://api.github.com/users/tadast/events{/privacy}","received_events_url":"https://api.github.com/users/tadast/received_events","type":"User","site_admin":false},"created_at":"2015-05-08T14:43:41Z","updated_at":"2015-05-08T14:43:41Z","body":"I've seen benchmarks that yield is twice as fast as block.call, but in this case it's irrelevant.\r\n\r\nLGTM :shipit: "}}