{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-lvm/issues/135","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-lvm/issues/135/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-lvm/issues/135/comments","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-lvm/issues/135/events","html_url":"https://github.com/puppetlabs/puppetlabs-lvm/pull/135","id":119567522,"number":135,"title":"Fix issue with using force method as pvcreate argument","user":{"login":"walkamongus","id":1642000,"avatar_url":"https://avatars.githubusercontent.com/u/1642000?v=3","gravatar_id":"","url":"https://api.github.com/users/walkamongus","html_url":"https://github.com/walkamongus","followers_url":"https://api.github.com/users/walkamongus/followers","following_url":"https://api.github.com/users/walkamongus/following{/other_user}","gists_url":"https://api.github.com/users/walkamongus/gists{/gist_id}","starred_url":"https://api.github.com/users/walkamongus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walkamongus/subscriptions","organizations_url":"https://api.github.com/users/walkamongus/orgs","repos_url":"https://api.github.com/users/walkamongus/repos","events_url":"https://api.github.com/users/walkamongus/events{/privacy}","received_events_url":"https://api.github.com/users/walkamongus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-11-30T19:56:24Z","updated_at":"2015-12-01T21:20:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-lvm/pulls/135","html_url":"https://github.com/puppetlabs/puppetlabs-lvm/pull/135","diff_url":"https://github.com/puppetlabs/puppetlabs-lvm/pull/135.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-lvm/pull/135.patch"},"body":"passing a blank argument (when force => false) to the pvcreate method causes errors:\r\n\r\n    ~]# puppet resource --debug --trace physical_volume /dev/sdc ensure=present\r\n    Debug: Executing: '/sbin/pvs /dev/sdc'\r\n    Debug: Executing: '/sbin/pvcreate  /dev/sdc'\r\n    Error: Execution of '/sbin/pvcreate  /dev/sdc' returned 5: Device  not found (or ignored by filtering).\r\n      Physical volume \"/dev/sdc\" successfully created\r\n\r\nWhich appear to be related to the insertion of the extra \"nil\" argument. Note the extra space in `/sbin/pvcreate  /dev/sdc`. This shouldn't matter if the command is executed 'as-is' on the commandline but there appears to possibly be some sort of quoting or grouping going on such that the command is literally `/sbin/pvcreate ' /dev/sdc'`, which causes an error. I'm not sure why the PV is still created successfully despite the error, however.\r\n\r\nThis PR should fix the issue."},"comment":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-lvm/issues/comments/161099076","html_url":"https://github.com/puppetlabs/puppetlabs-lvm/pull/135#issuecomment-161099076","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-lvm/issues/135","id":161099076,"user":{"login":"walkamongus","id":1642000,"avatar_url":"https://avatars.githubusercontent.com/u/1642000?v=3","gravatar_id":"","url":"https://api.github.com/users/walkamongus","html_url":"https://github.com/walkamongus","followers_url":"https://api.github.com/users/walkamongus/followers","following_url":"https://api.github.com/users/walkamongus/following{/other_user}","gists_url":"https://api.github.com/users/walkamongus/gists{/gist_id}","starred_url":"https://api.github.com/users/walkamongus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walkamongus/subscriptions","organizations_url":"https://api.github.com/users/walkamongus/orgs","repos_url":"https://api.github.com/users/walkamongus/repos","events_url":"https://api.github.com/users/walkamongus/events{/privacy}","received_events_url":"https://api.github.com/users/walkamongus/received_events","type":"User","site_admin":false},"created_at":"2015-12-01T21:20:15Z","updated_at":"2015-12-01T21:20:15Z","body":"does your vagrant box have a /dev/sdc disk available?"}}