{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/30792320","id":30792320,"diff_hunk":"@@ -41,17 +70,19 @@ in {\n   config = mkIf cfg.enable {\n     systemd.services.marathon = {\n       description = \"Marathon Service\";\n+      environment = cfg.environment;\n       wantedBy = [ \"multi-user.target\" ];\n       after = [ \"network-interfaces.target\" \"zookeeper.service\" \"mesos-master.service\" \"mesos-slave.service\" ];\n \n       serviceConfig = {\n-        ExecStart = \"${pkgs.marathon}/bin/marathon --master ${cfg.master} --zk zk://${head cfg.zookeeperHosts}/marathon\";\n+        ExecStart = \"${pkgs.marathon}/bin/marathon --master ${cfg.master} --zk zk://${concatStringsSep \",\" cfg.zookeeperHosts}/marathon --http_port ${toString cfg.httpPort} ${concatStringsSep \" \" cfg.extraCmdLineOptions}\";\n         User = \"marathon\";\n+\tRestart = \"always\";","path":"nixos/modules/services/scheduling/marathon.nix","position":76,"original_position":76,"commit_id":"229342f243de2461aa64e7284fe125a47d0f5740","original_commit_id":"229342f243de2461aa64e7284fe125a47d0f5740","user":{"login":"jagajaga","id":2179419,"avatar_url":"https://avatars.githubusercontent.com/u/2179419?v=3","gravatar_id":"","url":"https://api.github.com/users/jagajaga","html_url":"https://github.com/jagajaga","followers_url":"https://api.github.com/users/jagajaga/followers","following_url":"https://api.github.com/users/jagajaga/following{/other_user}","gists_url":"https://api.github.com/users/jagajaga/gists{/gist_id}","starred_url":"https://api.github.com/users/jagajaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagajaga/subscriptions","organizations_url":"https://api.github.com/users/jagajaga/orgs","repos_url":"https://api.github.com/users/jagajaga/repos","events_url":"https://api.github.com/users/jagajaga/events{/privacy}","received_events_url":"https://api.github.com/users/jagajaga/received_events","type":"User","site_admin":false},"body":"You've lost 2 spaces... ","created_at":"2015-05-21T11:11:14Z","updated_at":"2015-05-21T11:11:14Z","html_url":"https://github.com/NixOS/nixpkgs/pull/7857#discussion_r30792320","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7857","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/30792320"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/7857#discussion_r30792320"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7857"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7857","id":35575572,"html_url":"https://github.com/NixOS/nixpkgs/pull/7857","diff_url":"https://github.com/NixOS/nixpkgs/pull/7857.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/7857.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/7857","number":7857,"state":"open","locked":false,"title":"Update Marathon module","user":{"login":"rushmorem","id":4958190,"avatar_url":"https://avatars.githubusercontent.com/u/4958190?v=3","gravatar_id":"","url":"https://api.github.com/users/rushmorem","html_url":"https://github.com/rushmorem","followers_url":"https://api.github.com/users/rushmorem/followers","following_url":"https://api.github.com/users/rushmorem/following{/other_user}","gists_url":"https://api.github.com/users/rushmorem/gists{/gist_id}","starred_url":"https://api.github.com/users/rushmorem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rushmorem/subscriptions","organizations_url":"https://api.github.com/users/rushmorem/orgs","repos_url":"https://api.github.com/users/rushmorem/repos","events_url":"https://api.github.com/users/rushmorem/events{/privacy}","received_events_url":"https://api.github.com/users/rushmorem/received_events","type":"User","site_admin":false},"body":"The new module also makes it possible to pass extra commandline \r\narguments to Marathon as well as environment variables.","created_at":"2015-05-16T19:00:30Z","updated_at":"2015-05-21T11:11:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72ad72a4071410141745d39a9d602d5fd3eb6334","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7857/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7857/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/7857/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/229342f243de2461aa64e7284fe125a47d0f5740","head":{"label":"rushmorem:marathon-module-update","ref":"marathon-module-update","sha":"229342f243de2461aa64e7284fe125a47d0f5740","user":{"login":"rushmorem","id":4958190,"avatar_url":"https://avatars.githubusercontent.com/u/4958190?v=3","gravatar_id":"","url":"https://api.github.com/users/rushmorem","html_url":"https://github.com/rushmorem","followers_url":"https://api.github.com/users/rushmorem/followers","following_url":"https://api.github.com/users/rushmorem/following{/other_user}","gists_url":"https://api.github.com/users/rushmorem/gists{/gist_id}","starred_url":"https://api.github.com/users/rushmorem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rushmorem/subscriptions","organizations_url":"https://api.github.com/users/rushmorem/orgs","repos_url":"https://api.github.com/users/rushmorem/repos","events_url":"https://api.github.com/users/rushmorem/events{/privacy}","received_events_url":"https://api.github.com/users/rushmorem/received_events","type":"User","site_admin":false},"repo":{"id":30492597,"name":"nixpkgs","full_name":"rushmorem/nixpkgs","owner":{"login":"rushmorem","id":4958190,"avatar_url":"https://avatars.githubusercontent.com/u/4958190?v=3","gravatar_id":"","url":"https://api.github.com/users/rushmorem","html_url":"https://github.com/rushmorem","followers_url":"https://api.github.com/users/rushmorem/followers","following_url":"https://api.github.com/users/rushmorem/following{/other_user}","gists_url":"https://api.github.com/users/rushmorem/gists{/gist_id}","starred_url":"https://api.github.com/users/rushmorem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rushmorem/subscriptions","organizations_url":"https://api.github.com/users/rushmorem/orgs","repos_url":"https://api.github.com/users/rushmorem/repos","events_url":"https://api.github.com/users/rushmorem/events{/privacy}","received_events_url":"https://api.github.com/users/rushmorem/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rushmorem/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/rushmorem/nixpkgs","forks_url":"https://api.github.com/repos/rushmorem/nixpkgs/forks","keys_url":"https://api.github.com/repos/rushmorem/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rushmorem/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rushmorem/nixpkgs/teams","hooks_url":"https://api.github.com/repos/rushmorem/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/rushmorem/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/rushmorem/nixpkgs/events","assignees_url":"https://api.github.com/repos/rushmorem/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/rushmorem/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/rushmorem/nixpkgs/tags","blobs_url":"https://api.github.com/repos/rushmorem/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rushmorem/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rushmorem/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/rushmorem/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rushmorem/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/rushmorem/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/rushmorem/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/rushmorem/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/rushmorem/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/rushmorem/nixpkgs/subscription","commits_url":"https://api.github.com/repos/rushmorem/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/rushmorem/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/rushmorem/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/rushmorem/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/rushmorem/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/rushmorem/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rushmorem/nixpkgs/merges","archive_url":"https://api.github.com/repos/rushmorem/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rushmorem/nixpkgs/downloads","issues_url":"https://api.github.com/repos/rushmorem/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/rushmorem/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/rushmorem/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/rushmorem/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rushmorem/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/rushmorem/nixpkgs/releases{/id}","created_at":"2015-02-08T13:58:11Z","updated_at":"2015-03-06T10:24:52Z","pushed_at":"2015-05-21T10:52:06Z","git_url":"git://github.com/rushmorem/nixpkgs.git","ssh_url":"git@github.com:rushmorem/nixpkgs.git","clone_url":"https://github.com/rushmorem/nixpkgs.git","svn_url":"https://github.com/rushmorem/nixpkgs","homepage":null,"size":181297,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"15faa43f1309e9d19eeb92b4051c3c979399d483","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","created_at":"2012-06-04T02:49:46Z","updated_at":"2015-05-21T06:50:35Z","pushed_at":"2015-05-21T10:59:08Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":385192,"stargazers_count":646,"watchers_count":646,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":804,"mirror_url":null,"open_issues_count":737,"forks":804,"open_issues":737,"watchers":646,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7857"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/7857"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/7857"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/7857/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7857/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7857/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/229342f243de2461aa64e7284fe125a47d0f5740"}}}}