{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/notifications-admin/pulls/comments/46696112","id":46696112,"diff_hunk":"@@ -11,6 +13,14 @@ class Config(object):\n     MAX_FAILED_LOGIN_COUNT = 10\n     PASS_SECRET_KEY = 'secret-key-unique-changeme'\n \n+    SESSION_COOKIE_NAME = 'notify_admin_session'\n+    SESSION_COOKIE_PATH = '/admin'\n+    SESSION_COOKIE_HTTPONLY = True\n+    SESSION_COOKIE_SECURE = True\n+\n+    NOTIFY_DATA_API_URL = os.getenv('NOTIFY_API_URL', \"http://localhost:6001\")\n+    NOTIFY_DATA_API_AUTH_TOKEN = os.getenv('NOTIFY_API_TOKEN', \"pLuj5kat5auC9Ve\")","path":"config.py","position":16,"original_position":16,"commit_id":"538bbd923a5c9ecd56cadb1c28d764e6782851ca","original_commit_id":"538bbd923a5c9ecd56cadb1c28d764e6782851ca","user":{"login":"minglis","id":369454,"avatar_url":"https://avatars.githubusercontent.com/u/369454?v=3","gravatar_id":"","url":"https://api.github.com/users/minglis","html_url":"https://github.com/minglis","followers_url":"https://api.github.com/users/minglis/followers","following_url":"https://api.github.com/users/minglis/following{/other_user}","gists_url":"https://api.github.com/users/minglis/gists{/gist_id}","starred_url":"https://api.github.com/users/minglis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minglis/subscriptions","organizations_url":"https://api.github.com/users/minglis/orgs","repos_url":"https://api.github.com/users/minglis/repos","events_url":"https://api.github.com/users/minglis/events{/privacy}","received_events_url":"https://api.github.com/users/minglis/received_events","type":"User","site_admin":false},"body":"Do we still want this in here?\r\n","created_at":"2015-12-04T15:54:29Z","updated_at":"2015-12-04T15:54:29Z","html_url":"https://github.com/alphagov/notifications-admin/pull/15#discussion_r46696112","pull_request_url":"https://api.github.com/repos/alphagov/notifications-admin/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/alphagov/notifications-admin/pulls/comments/46696112"},"html":{"href":"https://github.com/alphagov/notifications-admin/pull/15#discussion_r46696112"},"pull_request":{"href":"https://api.github.com/repos/alphagov/notifications-admin/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/notifications-admin/pulls/15","id":52676860,"html_url":"https://github.com/alphagov/notifications-admin/pull/15","diff_url":"https://github.com/alphagov/notifications-admin/pull/15.diff","patch_url":"https://github.com/alphagov/notifications-admin/pull/15.patch","issue_url":"https://api.github.com/repos/alphagov/notifications-admin/issues/15","number":15,"state":"open","locked":false,"title":"3 Factor authentication","user":{"login":"servingUpAces","id":4282990,"avatar_url":"https://avatars.githubusercontent.com/u/4282990?v=3","gravatar_id":"","url":"https://api.github.com/users/servingUpAces","html_url":"https://github.com/servingUpAces","followers_url":"https://api.github.com/users/servingUpAces/followers","following_url":"https://api.github.com/users/servingUpAces/following{/other_user}","gists_url":"https://api.github.com/users/servingUpAces/gists{/gist_id}","starred_url":"https://api.github.com/users/servingUpAces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servingUpAces/subscriptions","organizations_url":"https://api.github.com/users/servingUpAces/orgs","repos_url":"https://api.github.com/users/servingUpAces/repos","events_url":"https://api.github.com/users/servingUpAces/events{/privacy}","received_events_url":"https://api.github.com/users/servingUpAces/received_events","type":"User","site_admin":false},"body":"The post register endpoint will send a random 5 digit code via sms and another via email.\r\n If either code fails to send, the user will not be created and the person can register again.\r\n The codes are saved to the session cookie, and expire in 1 hour.\r\n    \r\n Another iteration of this story will save the codes to a database. \r\n","created_at":"2015-12-04T14:44:38Z","updated_at":"2015-12-04T15:54:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"701c89f7b7d94a69b7326aa1992c3aab8f952ff9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/notifications-admin/pulls/15/commits","review_comments_url":"https://api.github.com/repos/alphagov/notifications-admin/pulls/15/comments","review_comment_url":"https://api.github.com/repos/alphagov/notifications-admin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/notifications-admin/issues/15/comments","statuses_url":"https://api.github.com/repos/alphagov/notifications-admin/statuses/538bbd923a5c9ecd56cadb1c28d764e6782851ca","head":{"label":"alphagov:3fa","ref":"3fa","sha":"538bbd923a5c9ecd56cadb1c28d764e6782851ca","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":46421986,"name":"notifications-admin","full_name":"alphagov/notifications-admin","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/notifications-admin","description":"Frontend application for notify admin","fork":false,"url":"https://api.github.com/repos/alphagov/notifications-admin","forks_url":"https://api.github.com/repos/alphagov/notifications-admin/forks","keys_url":"https://api.github.com/repos/alphagov/notifications-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/notifications-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/notifications-admin/teams","hooks_url":"https://api.github.com/repos/alphagov/notifications-admin/hooks","issue_events_url":"https://api.github.com/repos/alphagov/notifications-admin/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/notifications-admin/events","assignees_url":"https://api.github.com/repos/alphagov/notifications-admin/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/notifications-admin/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/notifications-admin/tags","blobs_url":"https://api.github.com/repos/alphagov/notifications-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/notifications-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/notifications-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/notifications-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/notifications-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/notifications-admin/languages","stargazers_url":"https://api.github.com/repos/alphagov/notifications-admin/stargazers","contributors_url":"https://api.github.com/repos/alphagov/notifications-admin/contributors","subscribers_url":"https://api.github.com/repos/alphagov/notifications-admin/subscribers","subscription_url":"https://api.github.com/repos/alphagov/notifications-admin/subscription","commits_url":"https://api.github.com/repos/alphagov/notifications-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/notifications-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/notifications-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/notifications-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/notifications-admin/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/notifications-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/notifications-admin/merges","archive_url":"https://api.github.com/repos/alphagov/notifications-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/notifications-admin/downloads","issues_url":"https://api.github.com/repos/alphagov/notifications-admin/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/notifications-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/notifications-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/notifications-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/notifications-admin/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/notifications-admin/releases{/id}","created_at":"2015-11-18T13:55:17Z","updated_at":"2015-11-23T13:33:48Z","pushed_at":"2015-12-04T15:53:14Z","git_url":"git://github.com/alphagov/notifications-admin.git","ssh_url":"git@github.com:alphagov/notifications-admin.git","clone_url":"https://github.com/alphagov/notifications-admin.git","svn_url":"https://github.com/alphagov/notifications-admin","homepage":null,"size":637,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"94124b2aa79f542dc97fc151fd5c8f42f7d0d44a","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":46421986,"name":"notifications-admin","full_name":"alphagov/notifications-admin","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/notifications-admin","description":"Frontend application for notify admin","fork":false,"url":"https://api.github.com/repos/alphagov/notifications-admin","forks_url":"https://api.github.com/repos/alphagov/notifications-admin/forks","keys_url":"https://api.github.com/repos/alphagov/notifications-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/notifications-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/notifications-admin/teams","hooks_url":"https://api.github.com/repos/alphagov/notifications-admin/hooks","issue_events_url":"https://api.github.com/repos/alphagov/notifications-admin/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/notifications-admin/events","assignees_url":"https://api.github.com/repos/alphagov/notifications-admin/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/notifications-admin/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/notifications-admin/tags","blobs_url":"https://api.github.com/repos/alphagov/notifications-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/notifications-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/notifications-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/notifications-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/notifications-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/notifications-admin/languages","stargazers_url":"https://api.github.com/repos/alphagov/notifications-admin/stargazers","contributors_url":"https://api.github.com/repos/alphagov/notifications-admin/contributors","subscribers_url":"https://api.github.com/repos/alphagov/notifications-admin/subscribers","subscription_url":"https://api.github.com/repos/alphagov/notifications-admin/subscription","commits_url":"https://api.github.com/repos/alphagov/notifications-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/notifications-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/notifications-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/notifications-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/notifications-admin/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/notifications-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/notifications-admin/merges","archive_url":"https://api.github.com/repos/alphagov/notifications-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/notifications-admin/downloads","issues_url":"https://api.github.com/repos/alphagov/notifications-admin/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/notifications-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/notifications-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/notifications-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/notifications-admin/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/notifications-admin/releases{/id}","created_at":"2015-11-18T13:55:17Z","updated_at":"2015-11-23T13:33:48Z","pushed_at":"2015-12-04T15:53:14Z","git_url":"git://github.com/alphagov/notifications-admin.git","ssh_url":"git@github.com:alphagov/notifications-admin.git","clone_url":"https://github.com/alphagov/notifications-admin.git","svn_url":"https://github.com/alphagov/notifications-admin","homepage":null,"size":637,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/notifications-admin/pulls/15"},"html":{"href":"https://github.com/alphagov/notifications-admin/pull/15"},"issue":{"href":"https://api.github.com/repos/alphagov/notifications-admin/issues/15"},"comments":{"href":"https://api.github.com/repos/alphagov/notifications-admin/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/notifications-admin/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/notifications-admin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/notifications-admin/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/notifications-admin/statuses/538bbd923a5c9ecd56cadb1c28d764e6782851ca"}}}}