{"action":"created","comment":{"url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/pulls/comments/34633536","id":34633536,"diff_hunk":"@@ -878,16 +882,16 @@ dbu.buildPutQuery = function(req, noConvert) {\n /**\n  * CQL building for GET queries\n  * @param {InternalRequest} req\n+ * @param {Boolean} withTTL if true, return TTLs of non-index attributes\n  * @return {object} queryInfo object with cql and params attributes\n  */\n-dbu.buildGetQuery = function(req) {\n-    var proj = '*';\n-\n+dbu.buildGetQuery = function(req, withTTL) {","path":"lib/dbutils.js","position":21,"original_position":21,"commit_id":"7598082f7f48747e339359f4cff12b50eb767e0a","original_commit_id":"7598082f7f48747e339359f4cff12b50eb767e0a","user":{"login":"gwicke","id":1225898,"avatar_url":"https://avatars.githubusercontent.com/u/1225898?v=3","gravatar_id":"","url":"https://api.github.com/users/gwicke","html_url":"https://github.com/gwicke","followers_url":"https://api.github.com/users/gwicke/followers","following_url":"https://api.github.com/users/gwicke/following{/other_user}","gists_url":"https://api.github.com/users/gwicke/gists{/gist_id}","starred_url":"https://api.github.com/users/gwicke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwicke/subscriptions","organizations_url":"https://api.github.com/users/gwicke/orgs","repos_url":"https://api.github.com/users/gwicke/repos","events_url":"https://api.github.com/users/gwicke/events{/privacy}","received_events_url":"https://api.github.com/users/gwicke/received_events","type":"User","site_admin":false},"body":"I'm wondering if an options object would be clearer, especially when calling buildGetQuery.","created_at":"2015-07-14T23:53:11Z","updated_at":"2015-07-14T23:53:11Z","html_url":"https://github.com/wikimedia/restbase-mod-table-cassandra/pull/122#discussion_r34633536","pull_request_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/pulls/122","_links":{"self":{"href":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/pulls/comments/34633536"},"html":{"href":"https://github.com/wikimedia/restbase-mod-table-cassandra/pull/122#discussion_r34633536"},"pull_request":{"href":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/pulls/122"}}},"pull_request":{"url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/pulls/122","id":39965979,"html_url":"https://github.com/wikimedia/restbase-mod-table-cassandra/pull/122","diff_url":"https://github.com/wikimedia/restbase-mod-table-cassandra/pull/122.diff","patch_url":"https://github.com/wikimedia/restbase-mod-table-cassandra/pull/122.patch","issue_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/issues/122","number":122,"state":"open","locked":false,"title":"avoid unnecessary TTL rewrites","user":{"login":"eevans","id":64348,"avatar_url":"https://avatars.githubusercontent.com/u/64348?v=3","gravatar_id":"","url":"https://api.github.com/users/eevans","html_url":"https://github.com/eevans","followers_url":"https://api.github.com/users/eevans/followers","following_url":"https://api.github.com/users/eevans/following{/other_user}","gists_url":"https://api.github.com/users/eevans/gists{/gist_id}","starred_url":"https://api.github.com/users/eevans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eevans/subscriptions","organizations_url":"https://api.github.com/users/eevans/orgs","repos_url":"https://api.github.com/users/eevans/repos","events_url":"https://api.github.com/users/eevans/events{/privacy}","received_events_url":"https://api.github.com/users/eevans/received_events","type":"User","site_admin":false},"body":"Refactored dbu#buildGetQuery to treat the default projection (*), as an\r\nexplicit set of attributes.  This avoids the special-casing for 2.0.x versions,\r\nand makes appending TTL attributes more straightforward.\r\n\r\nIntroduced a boolean parameter to db#_getRaw and dbu#buildGetQuery to specify\r\nresults that include a TTL attribute for all candidates (candidates being any\r\nnon-index, non-collection attribute).\r\n\r\nAdded TTL results to the queries performed in db#_backgroundUpdates, and\r\nutilized them to avoid rewriting rows that have already had a TTL set.\r\n\r\nBug: T105509","created_at":"2015-07-14T21:38:44Z","updated_at":"2015-07-14T23:53:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae956c684bccb2cdccc677eb413af1a91381349b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/pulls/122/commits","review_comments_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/pulls/122/comments","review_comment_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/issues/122/comments","statuses_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/statuses/7598082f7f48747e339359f4cff12b50eb767e0a","head":{"label":"eevans:overwrites","ref":"overwrites","sha":"7598082f7f48747e339359f4cff12b50eb767e0a","user":{"login":"eevans","id":64348,"avatar_url":"https://avatars.githubusercontent.com/u/64348?v=3","gravatar_id":"","url":"https://api.github.com/users/eevans","html_url":"https://github.com/eevans","followers_url":"https://api.github.com/users/eevans/followers","following_url":"https://api.github.com/users/eevans/following{/other_user}","gists_url":"https://api.github.com/users/eevans/gists{/gist_id}","starred_url":"https://api.github.com/users/eevans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eevans/subscriptions","organizations_url":"https://api.github.com/users/eevans/orgs","repos_url":"https://api.github.com/users/eevans/repos","events_url":"https://api.github.com/users/eevans/events{/privacy}","received_events_url":"https://api.github.com/users/eevans/received_events","type":"User","site_admin":false},"repo":{"id":31746867,"name":"restbase-mod-table-cassandra","full_name":"eevans/restbase-mod-table-cassandra","owner":{"login":"eevans","id":64348,"avatar_url":"https://avatars.githubusercontent.com/u/64348?v=3","gravatar_id":"","url":"https://api.github.com/users/eevans","html_url":"https://github.com/eevans","followers_url":"https://api.github.com/users/eevans/followers","following_url":"https://api.github.com/users/eevans/following{/other_user}","gists_url":"https://api.github.com/users/eevans/gists{/gist_id}","starred_url":"https://api.github.com/users/eevans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eevans/subscriptions","organizations_url":"https://api.github.com/users/eevans/orgs","repos_url":"https://api.github.com/users/eevans/repos","events_url":"https://api.github.com/users/eevans/events{/privacy}","received_events_url":"https://api.github.com/users/eevans/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eevans/restbase-mod-table-cassandra","description":"Cassandra table storage backend for RESTBase","fork":true,"url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra","forks_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/forks","keys_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/teams","hooks_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/hooks","issue_events_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/issues/events{/number}","events_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/events","assignees_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/assignees{/user}","branches_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/branches{/branch}","tags_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/tags","blobs_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/git/refs{/sha}","trees_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/statuses/{sha}","languages_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/languages","stargazers_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/stargazers","contributors_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/contributors","subscribers_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/subscribers","subscription_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/subscription","commits_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/commits{/sha}","git_commits_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/git/commits{/sha}","comments_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/comments{/number}","issue_comment_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/issues/comments{/number}","contents_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/contents/{+path}","compare_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/merges","archive_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/downloads","issues_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/issues{/number}","pulls_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/pulls{/number}","milestones_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/milestones{/number}","notifications_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/labels{/name}","releases_url":"https://api.github.com/repos/eevans/restbase-mod-table-cassandra/releases{/id}","created_at":"2015-03-06T01:44:58Z","updated_at":"2015-03-06T01:44:58Z","pushed_at":"2015-07-14T21:38:06Z","git_url":"git://github.com/eevans/restbase-mod-table-cassandra.git","ssh_url":"git@github.com:eevans/restbase-mod-table-cassandra.git","clone_url":"https://github.com/eevans/restbase-mod-table-cassandra.git","svn_url":"https://github.com/eevans/restbase-mod-table-cassandra","homepage":"","size":815,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wikimedia:master","ref":"master","sha":"09caaec2865495c3820b1792e9a2cae5aa45689e","user":{"login":"wikimedia","id":56668,"avatar_url":"https://avatars.githubusercontent.com/u/56668?v=3","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"repo":{"id":13256940,"name":"restbase-mod-table-cassandra","full_name":"wikimedia/restbase-mod-table-cassandra","owner":{"login":"wikimedia","id":56668,"avatar_url":"https://avatars.githubusercontent.com/u/56668?v=3","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wikimedia/restbase-mod-table-cassandra","description":"Cassandra table storage backend for RESTBase","fork":false,"url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra","forks_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/forks","keys_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/teams","hooks_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/hooks","issue_events_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/issues/events{/number}","events_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/events","assignees_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/assignees{/user}","branches_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/branches{/branch}","tags_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/tags","blobs_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/git/refs{/sha}","trees_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/statuses/{sha}","languages_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/languages","stargazers_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/stargazers","contributors_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/contributors","subscribers_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/subscribers","subscription_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/subscription","commits_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/commits{/sha}","git_commits_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/git/commits{/sha}","comments_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/comments{/number}","issue_comment_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/issues/comments{/number}","contents_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/contents/{+path}","compare_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/merges","archive_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/downloads","issues_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/issues{/number}","pulls_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/pulls{/number}","milestones_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/milestones{/number}","notifications_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/labels{/name}","releases_url":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/releases{/id}","created_at":"2013-10-01T22:03:02Z","updated_at":"2015-05-08T17:21:43Z","pushed_at":"2015-07-14T21:38:45Z","git_url":"git://github.com/wikimedia/restbase-mod-table-cassandra.git","ssh_url":"git@github.com:wikimedia/restbase-mod-table-cassandra.git","clone_url":"https://github.com/wikimedia/restbase-mod-table-cassandra.git","svn_url":"https://github.com/wikimedia/restbase-mod-table-cassandra","homepage":"","size":2163,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":5,"forks":8,"open_issues":5,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/pulls/122"},"html":{"href":"https://github.com/wikimedia/restbase-mod-table-cassandra/pull/122"},"issue":{"href":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/issues/122"},"comments":{"href":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/issues/122/comments"},"review_comments":{"href":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/pulls/122/comments"},"review_comment":{"href":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/pulls/122/commits"},"statuses":{"href":"https://api.github.com/repos/wikimedia/restbase-mod-table-cassandra/statuses/7598082f7f48747e339359f4cff12b50eb767e0a"}}}}