{"action":"created","comment":{"url":"https://api.github.com/repos/joyent/node/pulls/comments/29992444","id":29992444,"diff_hunk":"@@ -0,0 +1,83 @@\n+// Copyright Joyent, Inc. and other Node contributors.\n+//\n+// Permission is hereby granted, free of charge, to any person obtaining a\n+// copy of this software and associated documentation files (the\n+// \"Software\"), to deal in the Software without restriction, including\n+// without limitation the rights to use, copy, modify, merge, publish,\n+// distribute, sublicense, and/or sell copies of the Software, and to permit\n+// persons to whom the Software is furnished to do so, subject to the\n+// following conditions:\n+//\n+// The above copyright notice and this permission notice shall be included\n+// in all copies or substantial portions of the Software.\n+//\n+// THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS\n+// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF\n+// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN\n+// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,\n+// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR\n+// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE\n+// USE OR OTHER DEALINGS IN THE SOFTWARE.\n+var common = require('../common');\n+var assert = require('assert');\n+var path = require('path');\n+var fs = require('fs');\n+\n+\n+var file = path.join(common.tmpDir, 'write-autoclose-opt1.txt');\n+var stream = fs.createWriteStream(file,{flags: 'w+',autoClose:false});\n+stream.write('Test1');\n+stream.end();\n+stream.on('finish', function(){\n+  process.nextTick(function() {\n+    if(stream.hasOwnProperty('closed'))","path":"test/simple/test-fs-write-stream-autoclose-option.js","position":33,"original_position":33,"commit_id":"f813c6e5edb8cfedee753a52dc581e741aea70c8","original_commit_id":"f813c6e5edb8cfedee753a52dc581e741aea70c8","user":{"login":"saquibkhan","id":5888249,"avatar_url":"https://avatars.githubusercontent.com/u/5888249?v=3","gravatar_id":"","url":"https://api.github.com/users/saquibkhan","html_url":"https://github.com/saquibkhan","followers_url":"https://api.github.com/users/saquibkhan/followers","following_url":"https://api.github.com/users/saquibkhan/following{/other_user}","gists_url":"https://api.github.com/users/saquibkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/saquibkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saquibkhan/subscriptions","organizations_url":"https://api.github.com/users/saquibkhan/orgs","repos_url":"https://api.github.com/users/saquibkhan/repos","events_url":"https://api.github.com/users/saquibkhan/events{/privacy}","received_events_url":"https://api.github.com/users/saquibkhan/received_events","type":"User","site_admin":false},"body":"yes it would be undefined. Its a safety check if by chance it is defined in future then store.closed should be false here.","created_at":"2015-05-09T13:06:13Z","updated_at":"2015-05-09T13:06:13Z","html_url":"https://github.com/joyent/node/pull/25275#discussion_r29992444","pull_request_url":"https://api.github.com/repos/joyent/node/pulls/25275","_links":{"self":{"href":"https://api.github.com/repos/joyent/node/pulls/comments/29992444"},"html":{"href":"https://github.com/joyent/node/pull/25275#discussion_r29992444"},"pull_request":{"href":"https://api.github.com/repos/joyent/node/pulls/25275"}}},"pull_request":{"url":"https://api.github.com/repos/joyent/node/pulls/25275","id":35063413,"html_url":"https://github.com/joyent/node/pull/25275","diff_url":"https://github.com/joyent/node/pull/25275.diff","patch_url":"https://github.com/joyent/node/pull/25275.patch","issue_url":"https://api.github.com/repos/joyent/node/issues/25275","number":25275,"state":"open","locked":false,"title":"Add autoClose=true option to fs.createWrireStream #20880","user":{"login":"saquibkhan","id":5888249,"avatar_url":"https://avatars.githubusercontent.com/u/5888249?v=3","gravatar_id":"","url":"https://api.github.com/users/saquibkhan","html_url":"https://github.com/saquibkhan","followers_url":"https://api.github.com/users/saquibkhan/followers","following_url":"https://api.github.com/users/saquibkhan/following{/other_user}","gists_url":"https://api.github.com/users/saquibkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/saquibkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saquibkhan/subscriptions","organizations_url":"https://api.github.com/users/saquibkhan/orgs","repos_url":"https://api.github.com/users/saquibkhan/repos","events_url":"https://api.github.com/users/saquibkhan/events{/privacy}","received_events_url":"https://api.github.com/users/saquibkhan/received_events","type":"User","site_admin":false},"body":"Adding autoClose=true/false option to fs.createWrireStream.","created_at":"2015-05-09T08:11:57Z","updated_at":"2015-05-09T13:06:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b6c712457984569a3ca26ba5cc1a6b0e9d0502d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/joyent/node/pulls/25275/commits","review_comments_url":"https://api.github.com/repos/joyent/node/pulls/25275/comments","review_comment_url":"https://api.github.com/repos/joyent/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joyent/node/issues/25275/comments","statuses_url":"https://api.github.com/repos/joyent/node/statuses/f813c6e5edb8cfedee753a52dc581e741aea70c8","head":{"label":"saquibkhan:v0.12","ref":"v0.12","sha":"f813c6e5edb8cfedee753a52dc581e741aea70c8","user":{"login":"saquibkhan","id":5888249,"avatar_url":"https://avatars.githubusercontent.com/u/5888249?v=3","gravatar_id":"","url":"https://api.github.com/users/saquibkhan","html_url":"https://github.com/saquibkhan","followers_url":"https://api.github.com/users/saquibkhan/followers","following_url":"https://api.github.com/users/saquibkhan/following{/other_user}","gists_url":"https://api.github.com/users/saquibkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/saquibkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saquibkhan/subscriptions","organizations_url":"https://api.github.com/users/saquibkhan/orgs","repos_url":"https://api.github.com/users/saquibkhan/repos","events_url":"https://api.github.com/users/saquibkhan/events{/privacy}","received_events_url":"https://api.github.com/users/saquibkhan/received_events","type":"User","site_admin":false},"repo":{"id":34751328,"name":"node","full_name":"saquibkhan/node","owner":{"login":"saquibkhan","id":5888249,"avatar_url":"https://avatars.githubusercontent.com/u/5888249?v=3","gravatar_id":"","url":"https://api.github.com/users/saquibkhan","html_url":"https://github.com/saquibkhan","followers_url":"https://api.github.com/users/saquibkhan/followers","following_url":"https://api.github.com/users/saquibkhan/following{/other_user}","gists_url":"https://api.github.com/users/saquibkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/saquibkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saquibkhan/subscriptions","organizations_url":"https://api.github.com/users/saquibkhan/orgs","repos_url":"https://api.github.com/users/saquibkhan/repos","events_url":"https://api.github.com/users/saquibkhan/events{/privacy}","received_events_url":"https://api.github.com/users/saquibkhan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saquibkhan/node","description":"evented I/O for v8 javascript","fork":true,"url":"https://api.github.com/repos/saquibkhan/node","forks_url":"https://api.github.com/repos/saquibkhan/node/forks","keys_url":"https://api.github.com/repos/saquibkhan/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saquibkhan/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saquibkhan/node/teams","hooks_url":"https://api.github.com/repos/saquibkhan/node/hooks","issue_events_url":"https://api.github.com/repos/saquibkhan/node/issues/events{/number}","events_url":"https://api.github.com/repos/saquibkhan/node/events","assignees_url":"https://api.github.com/repos/saquibkhan/node/assignees{/user}","branches_url":"https://api.github.com/repos/saquibkhan/node/branches{/branch}","tags_url":"https://api.github.com/repos/saquibkhan/node/tags","blobs_url":"https://api.github.com/repos/saquibkhan/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saquibkhan/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saquibkhan/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/saquibkhan/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saquibkhan/node/statuses/{sha}","languages_url":"https://api.github.com/repos/saquibkhan/node/languages","stargazers_url":"https://api.github.com/repos/saquibkhan/node/stargazers","contributors_url":"https://api.github.com/repos/saquibkhan/node/contributors","subscribers_url":"https://api.github.com/repos/saquibkhan/node/subscribers","subscription_url":"https://api.github.com/repos/saquibkhan/node/subscription","commits_url":"https://api.github.com/repos/saquibkhan/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/saquibkhan/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/saquibkhan/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/saquibkhan/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/saquibkhan/node/contents/{+path}","compare_url":"https://api.github.com/repos/saquibkhan/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saquibkhan/node/merges","archive_url":"https://api.github.com/repos/saquibkhan/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saquibkhan/node/downloads","issues_url":"https://api.github.com/repos/saquibkhan/node/issues{/number}","pulls_url":"https://api.github.com/repos/saquibkhan/node/pulls{/number}","milestones_url":"https://api.github.com/repos/saquibkhan/node/milestones{/number}","notifications_url":"https://api.github.com/repos/saquibkhan/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saquibkhan/node/labels{/name}","releases_url":"https://api.github.com/repos/saquibkhan/node/releases{/id}","created_at":"2015-04-28T19:30:40Z","updated_at":"2015-04-28T19:31:02Z","pushed_at":"2015-05-09T08:09:59Z","git_url":"git://github.com/saquibkhan/node.git","ssh_url":"git@github.com:saquibkhan/node.git","clone_url":"https://github.com/saquibkhan/node.git","svn_url":"https://github.com/saquibkhan/node","homepage":"http://nodejs.org/","size":122660,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"joyent:v0.12","ref":"v0.12","sha":"fcbf226a944ab89400bfbc336b4ee4d28852189b","user":{"login":"joyent","id":10161,"avatar_url":"https://avatars.githubusercontent.com/u/10161?v=3","gravatar_id":"","url":"https://api.github.com/users/joyent","html_url":"https://github.com/joyent","followers_url":"https://api.github.com/users/joyent/followers","following_url":"https://api.github.com/users/joyent/following{/other_user}","gists_url":"https://api.github.com/users/joyent/gists{/gist_id}","starred_url":"https://api.github.com/users/joyent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyent/subscriptions","organizations_url":"https://api.github.com/users/joyent/orgs","repos_url":"https://api.github.com/users/joyent/repos","events_url":"https://api.github.com/users/joyent/events{/privacy}","received_events_url":"https://api.github.com/users/joyent/received_events","type":"Organization","site_admin":false},"repo":{"id":211666,"name":"node","full_name":"joyent/node","owner":{"login":"joyent","id":10161,"avatar_url":"https://avatars.githubusercontent.com/u/10161?v=3","gravatar_id":"","url":"https://api.github.com/users/joyent","html_url":"https://github.com/joyent","followers_url":"https://api.github.com/users/joyent/followers","following_url":"https://api.github.com/users/joyent/following{/other_user}","gists_url":"https://api.github.com/users/joyent/gists{/gist_id}","starred_url":"https://api.github.com/users/joyent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyent/subscriptions","organizations_url":"https://api.github.com/users/joyent/orgs","repos_url":"https://api.github.com/users/joyent/repos","events_url":"https://api.github.com/users/joyent/events{/privacy}","received_events_url":"https://api.github.com/users/joyent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joyent/node","description":"evented I/O for v8 javascript","fork":false,"url":"https://api.github.com/repos/joyent/node","forks_url":"https://api.github.com/repos/joyent/node/forks","keys_url":"https://api.github.com/repos/joyent/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joyent/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joyent/node/teams","hooks_url":"https://api.github.com/repos/joyent/node/hooks","issue_events_url":"https://api.github.com/repos/joyent/node/issues/events{/number}","events_url":"https://api.github.com/repos/joyent/node/events","assignees_url":"https://api.github.com/repos/joyent/node/assignees{/user}","branches_url":"https://api.github.com/repos/joyent/node/branches{/branch}","tags_url":"https://api.github.com/repos/joyent/node/tags","blobs_url":"https://api.github.com/repos/joyent/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joyent/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joyent/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/joyent/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joyent/node/statuses/{sha}","languages_url":"https://api.github.com/repos/joyent/node/languages","stargazers_url":"https://api.github.com/repos/joyent/node/stargazers","contributors_url":"https://api.github.com/repos/joyent/node/contributors","subscribers_url":"https://api.github.com/repos/joyent/node/subscribers","subscription_url":"https://api.github.com/repos/joyent/node/subscription","commits_url":"https://api.github.com/repos/joyent/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/joyent/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/joyent/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/joyent/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/joyent/node/contents/{+path}","compare_url":"https://api.github.com/repos/joyent/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joyent/node/merges","archive_url":"https://api.github.com/repos/joyent/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joyent/node/downloads","issues_url":"https://api.github.com/repos/joyent/node/issues{/number}","pulls_url":"https://api.github.com/repos/joyent/node/pulls{/number}","milestones_url":"https://api.github.com/repos/joyent/node/milestones{/number}","notifications_url":"https://api.github.com/repos/joyent/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joyent/node/labels{/name}","releases_url":"https://api.github.com/repos/joyent/node/releases{/id}","created_at":"2009-05-27T16:29:46Z","updated_at":"2015-05-09T08:46:26Z","pushed_at":"2015-05-09T08:11:57Z","git_url":"git://github.com/joyent/node.git","ssh_url":"git@github.com:joyent/node.git","clone_url":"https://github.com/joyent/node.git","svn_url":"https://github.com/joyent/node","homepage":"http://nodejs.org/","size":346334,"stargazers_count":36093,"watchers_count":36093,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":8049,"mirror_url":null,"open_issues_count":1251,"forks":8049,"open_issues":1251,"watchers":36093,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joyent/node/pulls/25275"},"html":{"href":"https://github.com/joyent/node/pull/25275"},"issue":{"href":"https://api.github.com/repos/joyent/node/issues/25275"},"comments":{"href":"https://api.github.com/repos/joyent/node/issues/25275/comments"},"review_comments":{"href":"https://api.github.com/repos/joyent/node/pulls/25275/comments"},"review_comment":{"href":"https://api.github.com/repos/joyent/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joyent/node/pulls/25275/commits"},"statuses":{"href":"https://api.github.com/repos/joyent/node/statuses/f813c6e5edb8cfedee753a52dc581e741aea70c8"}}}}