{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/pulls/comments/44996506","id":44996506,"diff_hunk":"@@ -668,7 +790,7 @@ public AbstractActiveDirectoryAuthenticationProvider getAuthenticationProvider()\n     @Override\n     public UserDetails loadUserByUsername(String username) throws UsernameNotFoundException, DataAccessException {\n         // delegate to one of our ActiveDirectory(Unix)?AuthenticationProvider\n-        return getAuthenticationProvider().loadUserByUsername(username);\n+      return getAuthenticationProvider().loadUserByUsername(username);","path":"src/main/java/hudson/plugins/active_directory/ActiveDirectorySecurityRealm.java","position":226,"original_position":226,"commit_id":"ceb299b0bca2b5d9c240cf4d7839666642edc8b6","original_commit_id":"ceb299b0bca2b5d9c240cf4d7839666642edc8b6","user":{"login":"batmat","id":223853,"avatar_url":"https://avatars.githubusercontent.com/u/223853?v=3","gravatar_id":"","url":"https://api.github.com/users/batmat","html_url":"https://github.com/batmat","followers_url":"https://api.github.com/users/batmat/followers","following_url":"https://api.github.com/users/batmat/following{/other_user}","gists_url":"https://api.github.com/users/batmat/gists{/gist_id}","starred_url":"https://api.github.com/users/batmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batmat/subscriptions","organizations_url":"https://api.github.com/users/batmat/orgs","repos_url":"https://api.github.com/users/batmat/repos","events_url":"https://api.github.com/users/batmat/events{/privacy}","received_events_url":"https://api.github.com/users/batmat/received_events","type":"User","site_admin":false},"body":"unnecessary change IIUC","created_at":"2015-11-16T22:46:49Z","updated_at":"2015-11-16T22:46:49Z","html_url":"https://github.com/jenkinsci/active-directory-plugin/pull/16#discussion_r44996506","pull_request_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/active-directory-plugin/pulls/comments/44996506"},"html":{"href":"https://github.com/jenkinsci/active-directory-plugin/pull/16#discussion_r44996506"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/active-directory-plugin/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/pulls/16","id":50196055,"html_url":"https://github.com/jenkinsci/active-directory-plugin/pull/16","diff_url":"https://github.com/jenkinsci/active-directory-plugin/pull/16.diff","patch_url":"https://github.com/jenkinsci/active-directory-plugin/pull/16.patch","issue_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/issues/16","number":16,"state":"open","locked":false,"title":"[JENKINS-31575] Adding SSO/Client certificate authentication against Active Directory","user":{"login":"llecaroz","id":550493,"avatar_url":"https://avatars.githubusercontent.com/u/550493?v=3","gravatar_id":"","url":"https://api.github.com/users/llecaroz","html_url":"https://github.com/llecaroz","followers_url":"https://api.github.com/users/llecaroz/followers","following_url":"https://api.github.com/users/llecaroz/following{/other_user}","gists_url":"https://api.github.com/users/llecaroz/gists{/gist_id}","starred_url":"https://api.github.com/users/llecaroz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llecaroz/subscriptions","organizations_url":"https://api.github.com/users/llecaroz/orgs","repos_url":"https://api.github.com/users/llecaroz/repos","events_url":"https://api.github.com/users/llecaroz/events{/privacy}","received_events_url":"https://api.github.com/users/llecaroz/received_events","type":"User","site_admin":false},"body":"bind dn username/password are mandatory when working with sso except in\r\nno_check mode. In the case of no_check mode:\r\n-A suffix will be added on username not to check against LDAP & mix them with LDAP real users authentications. \r\n-Users logged in SSO will be part of the default group defined in the configuration.\r\nFor all other modes, user groups will be those downloaded from LDAP. Because depending on companies, SSO DN username can differ from LDAP username (lower/upper case issues), a strategy can be applied.\r\n\r\nFor more information, see new options in the Jenkins Global security configuration ","created_at":"2015-11-09T23:54:50Z","updated_at":"2015-11-16T22:46:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e7ce24df1ddeb99e91cf7bdf7fd6834b9cf747e0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/pulls/16/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/pulls/16/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/issues/16/comments","statuses_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/statuses/ceb299b0bca2b5d9c240cf4d7839666642edc8b6","head":{"label":"llecaroz:master","ref":"master","sha":"ceb299b0bca2b5d9c240cf4d7839666642edc8b6","user":{"login":"llecaroz","id":550493,"avatar_url":"https://avatars.githubusercontent.com/u/550493?v=3","gravatar_id":"","url":"https://api.github.com/users/llecaroz","html_url":"https://github.com/llecaroz","followers_url":"https://api.github.com/users/llecaroz/followers","following_url":"https://api.github.com/users/llecaroz/following{/other_user}","gists_url":"https://api.github.com/users/llecaroz/gists{/gist_id}","starred_url":"https://api.github.com/users/llecaroz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llecaroz/subscriptions","organizations_url":"https://api.github.com/users/llecaroz/orgs","repos_url":"https://api.github.com/users/llecaroz/repos","events_url":"https://api.github.com/users/llecaroz/events{/privacy}","received_events_url":"https://api.github.com/users/llecaroz/received_events","type":"User","site_admin":false},"repo":{"id":45805198,"name":"active-directory-plugin","full_name":"llecaroz/active-directory-plugin","owner":{"login":"llecaroz","id":550493,"avatar_url":"https://avatars.githubusercontent.com/u/550493?v=3","gravatar_id":"","url":"https://api.github.com/users/llecaroz","html_url":"https://github.com/llecaroz","followers_url":"https://api.github.com/users/llecaroz/followers","following_url":"https://api.github.com/users/llecaroz/following{/other_user}","gists_url":"https://api.github.com/users/llecaroz/gists{/gist_id}","starred_url":"https://api.github.com/users/llecaroz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llecaroz/subscriptions","organizations_url":"https://api.github.com/users/llecaroz/orgs","repos_url":"https://api.github.com/users/llecaroz/repos","events_url":"https://api.github.com/users/llecaroz/events{/privacy}","received_events_url":"https://api.github.com/users/llecaroz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/llecaroz/active-directory-plugin","description":"Jenkins active-directory plugin","fork":true,"url":"https://api.github.com/repos/llecaroz/active-directory-plugin","forks_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/forks","keys_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/teams","hooks_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/hooks","issue_events_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/events","assignees_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/tags","blobs_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/languages","stargazers_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/stargazers","contributors_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/contributors","subscribers_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/subscribers","subscription_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/subscription","commits_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/merges","archive_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/downloads","issues_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/labels{/name}","releases_url":"https://api.github.com/repos/llecaroz/active-directory-plugin/releases{/id}","created_at":"2015-11-09T00:06:01Z","updated_at":"2015-11-10T18:50:05Z","pushed_at":"2015-11-16T18:02:23Z","git_url":"git://github.com/llecaroz/active-directory-plugin.git","ssh_url":"git@github.com:llecaroz/active-directory-plugin.git","clone_url":"https://github.com/llecaroz/active-directory-plugin.git","svn_url":"https://github.com/llecaroz/active-directory-plugin","homepage":"http://jenkins-ci.org/","size":421,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"8ed46fc74b3fb6347b966b6bec3bcf2a6a3d30e2","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1163445,"name":"active-directory-plugin","full_name":"jenkinsci/active-directory-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/active-directory-plugin","description":"Jenkins active-directory plugin","fork":false,"url":"https://api.github.com/repos/jenkinsci/active-directory-plugin","forks_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/active-directory-plugin/releases{/id}","created_at":"2010-12-13T05:26:01Z","updated_at":"2015-11-10T18:49:02Z","pushed_at":"2015-11-16T18:02:24Z","git_url":"git://github.com/jenkinsci/active-directory-plugin.git","ssh_url":"git@github.com:jenkinsci/active-directory-plugin.git","clone_url":"https://github.com/jenkinsci/active-directory-plugin.git","svn_url":"https://github.com/jenkinsci/active-directory-plugin","homepage":"http://jenkins-ci.org/","size":1062,"stargazers_count":26,"watchers_count":26,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":4,"forks":40,"open_issues":4,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/active-directory-plugin/pulls/16"},"html":{"href":"https://github.com/jenkinsci/active-directory-plugin/pull/16"},"issue":{"href":"https://api.github.com/repos/jenkinsci/active-directory-plugin/issues/16"},"comments":{"href":"https://api.github.com/repos/jenkinsci/active-directory-plugin/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/active-directory-plugin/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/active-directory-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/active-directory-plugin/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/active-directory-plugin/statuses/ceb299b0bca2b5d9c240cf4d7839666642edc8b6"}}}}