{"action":"created","comment":{"url":"https://api.github.com/repos/ripple/rippled/pulls/comments/27306715","id":27306715,"diff_hunk":"@@ -586,25 +611,127 @@ def list_sources(base, suffixes):\n                     yield os.path.normpath(path)\n     return list(_iter(base))\n \n-def add_soci_sources(env, object_builder, is_unity):\n+def append_sources (result, *filenames, **kwds):\n+    result.append([filenames, kwds])\n+\n+def get_soci_sources(style):\n+    result = []\n     cpp_path = [\n         'src/soci/src/core',\n         'src/sqlite',]\n-    object_builder.add_source_files(\n+    append_sources(result,\n         'src/ripple/unity/soci.cpp',\n         CPPPATH = cpp_path)\n-    if is_unity:\n-        object_builder.add_source_files(\n+    if style == 'unity':\n+        append_sources(result,\n             'src/ripple/unity/soci_ripple.cpp',\n             CPPPATH = cpp_path)\n+    return result\n+\n+def get_classic_sources():\n+    result = []\n+    append_sources(result,\n+        *list_sources('src/ripple/app', '.cpp'),\n+        CPPPATH=[\n+             'src/soci/src/core',\n+             'src/sqlite',]\n+    )\n+    append_sources(result, *list_sources('src/ripple/basics', '.cpp'))\n+    append_sources(result, *list_sources('src/ripple/core', '.cpp'))\n+    append_sources(result, *list_sources('src/ripple/crypto', '.cpp'))\n+    append_sources(result, *list_sources('src/ripple/json', '.cpp'))\n+    append_sources(result, *list_sources('src/ripple/legacy', '.cpp'))\n+    append_sources(result, *list_sources('src/ripple/net', '.cpp'))\n+    append_sources(result, *list_sources('src/ripple/overlay', '.cpp'))\n+    append_sources(result, *list_sources('src/ripple/peerfinder', '.cpp'))\n+    append_sources(result, *list_sources('src/ripple/protocol', '.cpp'))\n+    append_sources(result, *list_sources('src/ripple/shamap', '.cpp'))\n+    append_sources(result, *list_sources('src/ripple/nodestore', '.cpp'),\n+        CPPPATH=[\n+            'src/rocksdb2/include',\n+            'src/snappy/snappy',\n+            'src/snappy/config',\n+        ])\n+\n+    result += get_soci_sources('classic')\n+    return result\n+\n+def get_unity_sources():\n+    result = []\n+    append_sources(\n+        result,","path":"SConstruct","position":102,"original_position":102,"commit_id":"07fe4dfade91b57145c67b93c51014e74c9159f8","original_commit_id":"07fe4dfade91b57145c67b93c51014e74c9159f8","user":{"login":"rec","id":253362,"avatar_url":"https://avatars.githubusercontent.com/u/253362?v=3","gravatar_id":"","url":"https://api.github.com/users/rec","html_url":"https://github.com/rec","followers_url":"https://api.github.com/users/rec/followers","following_url":"https://api.github.com/users/rec/following{/other_user}","gists_url":"https://api.github.com/users/rec/gists{/gist_id}","starred_url":"https://api.github.com/users/rec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rec/subscriptions","organizations_url":"https://api.github.com/users/rec/orgs","repos_url":"https://api.github.com/users/rec/repos","events_url":"https://api.github.com/users/rec/events{/privacy}","received_events_url":"https://api.github.com/users/rec/received_events","type":"User","site_admin":false},"body":"This one is good!","created_at":"2015-03-27T16:05:51Z","updated_at":"2015-03-27T16:05:51Z","html_url":"https://github.com/ripple/rippled/pull/951#discussion_r27306715","pull_request_url":"https://api.github.com/repos/ripple/rippled/pulls/951","_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments/27306715"},"html":{"href":"https://github.com/ripple/rippled/pull/951#discussion_r27306715"},"pull_request":{"href":"https://api.github.com/repos/ripple/rippled/pulls/951"}}},"pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/951","id":31937505,"html_url":"https://github.com/ripple/rippled/pull/951","diff_url":"https://github.com/ripple/rippled/pull/951.diff","patch_url":"https://github.com/ripple/rippled/pull/951.patch","issue_url":"https://api.github.com/repos/ripple/rippled/issues/951","number":951,"state":"open","locked":false,"title":"Improve build times:","user":{"login":"seelabs","id":5853458,"avatar_url":"https://avatars.githubusercontent.com/u/5853458?v=3","gravatar_id":"","url":"https://api.github.com/users/seelabs","html_url":"https://github.com/seelabs","followers_url":"https://api.github.com/users/seelabs/followers","following_url":"https://api.github.com/users/seelabs/following{/other_user}","gists_url":"https://api.github.com/users/seelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/seelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seelabs/subscriptions","organizations_url":"https://api.github.com/users/seelabs/orgs","repos_url":"https://api.github.com/users/seelabs/repos","events_url":"https://api.github.com/users/seelabs/events{/privacy}","received_events_url":"https://api.github.com/users/seelabs/received_events","type":"User","site_admin":false},"body":"* Get classic & unity sources once only\r\n* Use MD5-Timestamp\r\n* Use implicit cache for specific debug builds\r\n* Skip prep work for targets that will not be built\r\n\r\n@rec ","created_at":"2015-03-25T16:08:17Z","updated_at":"2015-03-27T16:05:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c66dfe082d689b33de0a3401081eba4f7beaa20","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ripple/rippled/pulls/951/commits","review_comments_url":"https://api.github.com/repos/ripple/rippled/pulls/951/comments","review_comment_url":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/951/comments","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/07fe4dfade91b57145c67b93c51014e74c9159f8","head":{"label":"seelabs:cleanupScons","ref":"cleanupScons","sha":"07fe4dfade91b57145c67b93c51014e74c9159f8","user":{"login":"seelabs","id":5853458,"avatar_url":"https://avatars.githubusercontent.com/u/5853458?v=3","gravatar_id":"","url":"https://api.github.com/users/seelabs","html_url":"https://github.com/seelabs","followers_url":"https://api.github.com/users/seelabs/followers","following_url":"https://api.github.com/users/seelabs/following{/other_user}","gists_url":"https://api.github.com/users/seelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/seelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seelabs/subscriptions","organizations_url":"https://api.github.com/users/seelabs/orgs","repos_url":"https://api.github.com/users/seelabs/repos","events_url":"https://api.github.com/users/seelabs/events{/privacy}","received_events_url":"https://api.github.com/users/seelabs/received_events","type":"User","site_admin":false},"repo":{"id":28865026,"name":"rippled","full_name":"seelabs/rippled","owner":{"login":"seelabs","id":5853458,"avatar_url":"https://avatars.githubusercontent.com/u/5853458?v=3","gravatar_id":"","url":"https://api.github.com/users/seelabs","html_url":"https://github.com/seelabs","followers_url":"https://api.github.com/users/seelabs/followers","following_url":"https://api.github.com/users/seelabs/following{/other_user}","gists_url":"https://api.github.com/users/seelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/seelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seelabs/subscriptions","organizations_url":"https://api.github.com/users/seelabs/orgs","repos_url":"https://api.github.com/users/seelabs/repos","events_url":"https://api.github.com/users/seelabs/events{/privacy}","received_events_url":"https://api.github.com/users/seelabs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/seelabs/rippled","description":"Ripple peer-to-peer network daemon","fork":true,"url":"https://api.github.com/repos/seelabs/rippled","forks_url":"https://api.github.com/repos/seelabs/rippled/forks","keys_url":"https://api.github.com/repos/seelabs/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seelabs/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seelabs/rippled/teams","hooks_url":"https://api.github.com/repos/seelabs/rippled/hooks","issue_events_url":"https://api.github.com/repos/seelabs/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/seelabs/rippled/events","assignees_url":"https://api.github.com/repos/seelabs/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/seelabs/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/seelabs/rippled/tags","blobs_url":"https://api.github.com/repos/seelabs/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seelabs/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seelabs/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/seelabs/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seelabs/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/seelabs/rippled/languages","stargazers_url":"https://api.github.com/repos/seelabs/rippled/stargazers","contributors_url":"https://api.github.com/repos/seelabs/rippled/contributors","subscribers_url":"https://api.github.com/repos/seelabs/rippled/subscribers","subscription_url":"https://api.github.com/repos/seelabs/rippled/subscription","commits_url":"https://api.github.com/repos/seelabs/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/seelabs/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/seelabs/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/seelabs/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/seelabs/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/seelabs/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seelabs/rippled/merges","archive_url":"https://api.github.com/repos/seelabs/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seelabs/rippled/downloads","issues_url":"https://api.github.com/repos/seelabs/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/seelabs/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/seelabs/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/seelabs/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seelabs/rippled/labels{/name}","releases_url":"https://api.github.com/repos/seelabs/rippled/releases{/id}","created_at":"2015-01-06T13:36:16Z","updated_at":"2015-03-20T19:42:53Z","pushed_at":"2015-03-27T14:24:02Z","git_url":"git://github.com/seelabs/rippled.git","ssh_url":"git@github.com:seelabs/rippled.git","clone_url":"https://github.com/seelabs/rippled.git","svn_url":"https://github.com/seelabs/rippled","homepage":"https://ripple.com","size":51624,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ripple:develop","ref":"develop","sha":"f313caaa73b0ac89e793195dcc2a5001786f916f","user":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"repo":{"id":2724167,"name":"rippled","full_name":"ripple/rippled","owner":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ripple/rippled","description":"Ripple peer-to-peer network daemon","fork":false,"url":"https://api.github.com/repos/ripple/rippled","forks_url":"https://api.github.com/repos/ripple/rippled/forks","keys_url":"https://api.github.com/repos/ripple/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ripple/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ripple/rippled/teams","hooks_url":"https://api.github.com/repos/ripple/rippled/hooks","issue_events_url":"https://api.github.com/repos/ripple/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/ripple/rippled/events","assignees_url":"https://api.github.com/repos/ripple/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/ripple/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/ripple/rippled/tags","blobs_url":"https://api.github.com/repos/ripple/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ripple/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ripple/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/ripple/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/ripple/rippled/languages","stargazers_url":"https://api.github.com/repos/ripple/rippled/stargazers","contributors_url":"https://api.github.com/repos/ripple/rippled/contributors","subscribers_url":"https://api.github.com/repos/ripple/rippled/subscribers","subscription_url":"https://api.github.com/repos/ripple/rippled/subscription","commits_url":"https://api.github.com/repos/ripple/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/ripple/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/ripple/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/ripple/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/ripple/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/ripple/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ripple/rippled/merges","archive_url":"https://api.github.com/repos/ripple/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ripple/rippled/downloads","issues_url":"https://api.github.com/repos/ripple/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/ripple/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/ripple/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/ripple/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ripple/rippled/labels{/name}","releases_url":"https://api.github.com/repos/ripple/rippled/releases{/id}","created_at":"2011-11-07T04:40:15Z","updated_at":"2015-03-27T06:04:28Z","pushed_at":"2015-03-27T14:24:51Z","git_url":"git://github.com/ripple/rippled.git","ssh_url":"git@github.com:ripple/rippled.git","clone_url":"https://github.com/ripple/rippled.git","svn_url":"https://github.com/ripple/rippled","homepage":"https://ripple.com","size":110344,"stargazers_count":924,"watchers_count":924,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":260,"mirror_url":null,"open_issues_count":137,"forks":260,"open_issues":137,"watchers":924,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/951"},"html":{"href":"https://github.com/ripple/rippled/pull/951"},"issue":{"href":"https://api.github.com/repos/ripple/rippled/issues/951"},"comments":{"href":"https://api.github.com/repos/ripple/rippled/issues/951/comments"},"review_comments":{"href":"https://api.github.com/repos/ripple/rippled/pulls/951/comments"},"review_comment":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ripple/rippled/pulls/951/commits"},"statuses":{"href":"https://api.github.com/repos/ripple/rippled/statuses/07fe4dfade91b57145c67b93c51014e74c9159f8"}}}}