{"action":"created","comment":{"url":"https://api.github.com/repos/mesosphere/hdfs/pulls/comments/33985961","id":33985961,"diff_hunk":"@@ -0,0 +1,18 @@\n+package org.apache.mesos.hdfs.scheduler;\n+","path":"hdfs-scheduler/src/main/java/org/apache/mesos/hdfs/scheduler/SchedulerExceptionHandler.java","position":2,"original_position":2,"commit_id":"9e3ac6323749dce556d1e1db050e8cde397208f3","original_commit_id":"9e3ac6323749dce556d1e1db050e8cde397208f3","user":{"login":"elingg","id":8423887,"avatar_url":"https://avatars.githubusercontent.com/u/8423887?v=3","gravatar_id":"","url":"https://api.github.com/users/elingg","html_url":"https://github.com/elingg","followers_url":"https://api.github.com/users/elingg/followers","following_url":"https://api.github.com/users/elingg/following{/other_user}","gists_url":"https://api.github.com/users/elingg/gists{/gist_id}","starred_url":"https://api.github.com/users/elingg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elingg/subscriptions","organizations_url":"https://api.github.com/users/elingg/orgs","repos_url":"https://api.github.com/users/elingg/repos","events_url":"https://api.github.com/users/elingg/events{/privacy}","received_events_url":"https://api.github.com/users/elingg/received_events","type":"User","site_admin":false},"body":"I see that we don't have a choice here if we are to add a handler to properly log runtime exceptions. This makes sense in that case. Yes, I do suggest creating it as an inner class since its only a few lines of code.  Also, I noticed something else the Log is referencing ConfigServer.class which is not correct.","created_at":"2015-07-06T21:41:37Z","updated_at":"2015-07-06T21:41:37Z","html_url":"https://github.com/mesosphere/hdfs/pull/150#discussion_r33985961","pull_request_url":"https://api.github.com/repos/mesosphere/hdfs/pulls/150","_links":{"self":{"href":"https://api.github.com/repos/mesosphere/hdfs/pulls/comments/33985961"},"html":{"href":"https://github.com/mesosphere/hdfs/pull/150#discussion_r33985961"},"pull_request":{"href":"https://api.github.com/repos/mesosphere/hdfs/pulls/150"}}},"pull_request":{"url":"https://api.github.com/repos/mesosphere/hdfs/pulls/150","id":39026284,"html_url":"https://github.com/mesosphere/hdfs/pull/150","diff_url":"https://github.com/mesosphere/hdfs/pull/150.diff","patch_url":"https://github.com/mesosphere/hdfs/pull/150.patch","issue_url":"https://api.github.com/repos/mesosphere/hdfs/issues/150","number":150,"state":"open","locked":false,"title":"Pmd findbug fixes","user":{"login":"kensipe","id":27497,"avatar_url":"https://avatars.githubusercontent.com/u/27497?v=3","gravatar_id":"","url":"https://api.github.com/users/kensipe","html_url":"https://github.com/kensipe","followers_url":"https://api.github.com/users/kensipe/followers","following_url":"https://api.github.com/users/kensipe/following{/other_user}","gists_url":"https://api.github.com/users/kensipe/gists{/gist_id}","starred_url":"https://api.github.com/users/kensipe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kensipe/subscriptions","organizations_url":"https://api.github.com/users/kensipe/orgs","repos_url":"https://api.github.com/users/kensipe/repos","events_url":"https://api.github.com/users/kensipe/events{/privacy}","received_events_url":"https://api.github.com/users/kensipe/received_events","type":"User","site_admin":false},"body":"Ran PMD and Findbugs on source.  These were the mods and cleanup from that.","created_at":"2015-07-01T21:18:13Z","updated_at":"2015-07-06T21:41:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d7f1be23ea472e5f246ed0ceb1db6521b8a4360","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mesosphere/hdfs/pulls/150/commits","review_comments_url":"https://api.github.com/repos/mesosphere/hdfs/pulls/150/comments","review_comment_url":"https://api.github.com/repos/mesosphere/hdfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesosphere/hdfs/issues/150/comments","statuses_url":"https://api.github.com/repos/mesosphere/hdfs/statuses/9e3ac6323749dce556d1e1db050e8cde397208f3","head":{"label":"mesosphere:pmd-findbug-fixes","ref":"pmd-findbug-fixes","sha":"9e3ac6323749dce556d1e1db050e8cde397208f3","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":25594400,"name":"hdfs","full_name":"mesosphere/hdfs","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/hdfs","description":"HA HDFS on Apache Mesos  ~~~  aka 'Super Available' HDFS","fork":true,"url":"https://api.github.com/repos/mesosphere/hdfs","forks_url":"https://api.github.com/repos/mesosphere/hdfs/forks","keys_url":"https://api.github.com/repos/mesosphere/hdfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/hdfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/hdfs/teams","hooks_url":"https://api.github.com/repos/mesosphere/hdfs/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/hdfs/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/hdfs/events","assignees_url":"https://api.github.com/repos/mesosphere/hdfs/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/hdfs/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/hdfs/tags","blobs_url":"https://api.github.com/repos/mesosphere/hdfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/hdfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/hdfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/hdfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/hdfs/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/hdfs/languages","stargazers_url":"https://api.github.com/repos/mesosphere/hdfs/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/hdfs/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/hdfs/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/hdfs/subscription","commits_url":"https://api.github.com/repos/mesosphere/hdfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/hdfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/hdfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/hdfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/hdfs/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/hdfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/hdfs/merges","archive_url":"https://api.github.com/repos/mesosphere/hdfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/hdfs/downloads","issues_url":"https://api.github.com/repos/mesosphere/hdfs/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/hdfs/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/hdfs/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/hdfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/hdfs/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/hdfs/releases{/id}","created_at":"2014-10-22T17:21:52Z","updated_at":"2015-07-02T15:35:58Z","pushed_at":"2015-07-02T19:33:19Z","git_url":"git://github.com/mesosphere/hdfs.git","ssh_url":"git@github.com:mesosphere/hdfs.git","clone_url":"https://github.com/mesosphere/hdfs.git","svn_url":"https://github.com/mesosphere/hdfs","homepage":"","size":2011,"stargazers_count":76,"watchers_count":76,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":38,"forks":16,"open_issues":38,"watchers":76,"default_branch":"master"}},"base":{"label":"mesosphere:master","ref":"master","sha":"09e2320c65e66ffd54d0d726e7e4a08b61196c6a","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":25594400,"name":"hdfs","full_name":"mesosphere/hdfs","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/hdfs","description":"HA HDFS on Apache Mesos  ~~~  aka 'Super Available' HDFS","fork":true,"url":"https://api.github.com/repos/mesosphere/hdfs","forks_url":"https://api.github.com/repos/mesosphere/hdfs/forks","keys_url":"https://api.github.com/repos/mesosphere/hdfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/hdfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/hdfs/teams","hooks_url":"https://api.github.com/repos/mesosphere/hdfs/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/hdfs/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/hdfs/events","assignees_url":"https://api.github.com/repos/mesosphere/hdfs/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/hdfs/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/hdfs/tags","blobs_url":"https://api.github.com/repos/mesosphere/hdfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/hdfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/hdfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/hdfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/hdfs/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/hdfs/languages","stargazers_url":"https://api.github.com/repos/mesosphere/hdfs/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/hdfs/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/hdfs/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/hdfs/subscription","commits_url":"https://api.github.com/repos/mesosphere/hdfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/hdfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/hdfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/hdfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/hdfs/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/hdfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/hdfs/merges","archive_url":"https://api.github.com/repos/mesosphere/hdfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/hdfs/downloads","issues_url":"https://api.github.com/repos/mesosphere/hdfs/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/hdfs/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/hdfs/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/hdfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/hdfs/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/hdfs/releases{/id}","created_at":"2014-10-22T17:21:52Z","updated_at":"2015-07-02T15:35:58Z","pushed_at":"2015-07-02T19:33:19Z","git_url":"git://github.com/mesosphere/hdfs.git","ssh_url":"git@github.com:mesosphere/hdfs.git","clone_url":"https://github.com/mesosphere/hdfs.git","svn_url":"https://github.com/mesosphere/hdfs","homepage":"","size":2011,"stargazers_count":76,"watchers_count":76,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":38,"forks":16,"open_issues":38,"watchers":76,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesosphere/hdfs/pulls/150"},"html":{"href":"https://github.com/mesosphere/hdfs/pull/150"},"issue":{"href":"https://api.github.com/repos/mesosphere/hdfs/issues/150"},"comments":{"href":"https://api.github.com/repos/mesosphere/hdfs/issues/150/comments"},"review_comments":{"href":"https://api.github.com/repos/mesosphere/hdfs/pulls/150/comments"},"review_comment":{"href":"https://api.github.com/repos/mesosphere/hdfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesosphere/hdfs/pulls/150/commits"},"statuses":{"href":"https://api.github.com/repos/mesosphere/hdfs/statuses/9e3ac6323749dce556d1e1db050e8cde397208f3"}}}}