{"action":"created","comment":{"url":"https://api.github.com/repos/lsst/sims_photUtils/pulls/comments/40829933","id":40829933,"diff_hunk":"@@ -9,7 +9,8 @@ class LSSTdefaults(object):\n     \"\"\"\n \n     def __init__(self):\n-        self._seeing = {'u': 0.77, 'g':0.73, 'r':0.70, 'i':0.67, 'z':0.65, 'y':0.63}\n+        #self._seeing = {'u': 0.77, 'g':0.73, 'r':0.70, 'i':0.67, 'z':0.65, 'y':0.63}","path":"python/lsst/sims/photUtils/LSSTdefaults.py","position":5,"original_position":5,"commit_id":"042e6252c2fb6c34120f32cb46ea7a9aa5426bd3","original_commit_id":"042e6252c2fb6c34120f32cb46ea7a9aa5426bd3","user":{"login":"danielsf","id":1682854,"avatar_url":"https://avatars.githubusercontent.com/u/1682854?v=3","gravatar_id":"","url":"https://api.github.com/users/danielsf","html_url":"https://github.com/danielsf","followers_url":"https://api.github.com/users/danielsf/followers","following_url":"https://api.github.com/users/danielsf/following{/other_user}","gists_url":"https://api.github.com/users/danielsf/gists{/gist_id}","starred_url":"https://api.github.com/users/danielsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielsf/subscriptions","organizations_url":"https://api.github.com/users/danielsf/orgs","repos_url":"https://api.github.com/users/danielsf/repos","events_url":"https://api.github.com/users/danielsf/events{/privacy}","received_events_url":"https://api.github.com/users/danielsf/received_events","type":"User","site_admin":false},"body":"You should update the docstring on the seeing attribute of LSSTdefaults to reflect the new meaning of \"seeing\" (also the fact that these values are no longer consistent with arXiv:0805.2366)","created_at":"2015-09-30T18:15:34Z","updated_at":"2015-09-30T18:15:34Z","html_url":"https://github.com/lsst/sims_photUtils/pull/20#discussion_r40829933","pull_request_url":"https://api.github.com/repos/lsst/sims_photUtils/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/lsst/sims_photUtils/pulls/comments/40829933"},"html":{"href":"https://github.com/lsst/sims_photUtils/pull/20#discussion_r40829933"},"pull_request":{"href":"https://api.github.com/repos/lsst/sims_photUtils/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/lsst/sims_photUtils/pulls/20","id":46059908,"html_url":"https://github.com/lsst/sims_photUtils/pull/20","diff_url":"https://github.com/lsst/sims_photUtils/pull/20.diff","patch_url":"https://github.com/lsst/sims_photUtils/pull/20.patch","issue_url":"https://api.github.com/repos/lsst/sims_photUtils/issues/20","number":20,"state":"open","locked":false,"title":"Feature/sim 1496 new neff","user":{"login":"rhiannonlynne","id":1855711,"avatar_url":"https://avatars.githubusercontent.com/u/1855711?v=3","gravatar_id":"","url":"https://api.github.com/users/rhiannonlynne","html_url":"https://github.com/rhiannonlynne","followers_url":"https://api.github.com/users/rhiannonlynne/followers","following_url":"https://api.github.com/users/rhiannonlynne/following{/other_user}","gists_url":"https://api.github.com/users/rhiannonlynne/gists{/gist_id}","starred_url":"https://api.github.com/users/rhiannonlynne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhiannonlynne/subscriptions","organizations_url":"https://api.github.com/users/rhiannonlynne/orgs","repos_url":"https://api.github.com/users/rhiannonlynne/repos","events_url":"https://api.github.com/users/rhiannonlynne/events{/privacy}","received_events_url":"https://api.github.com/users/rhiannonlynne/received_events","type":"User","site_admin":false},"body":"These are the changes for Neff and the seeing default values. \r\nI also made an update for the bandpass interpolation, mostly to try to better match what Chuck was doing in his ipython notebooks. If the interpolation update is not desireable, I'm happy to remove that change. It doesn't seem to make a great deal of difference. ","created_at":"2015-09-25T21:24:41Z","updated_at":"2015-09-30T18:15:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73ae818c8eaca4055a556ced7cb687247280ef34","assignee":{"login":"danielsf","id":1682854,"avatar_url":"https://avatars.githubusercontent.com/u/1682854?v=3","gravatar_id":"","url":"https://api.github.com/users/danielsf","html_url":"https://github.com/danielsf","followers_url":"https://api.github.com/users/danielsf/followers","following_url":"https://api.github.com/users/danielsf/following{/other_user}","gists_url":"https://api.github.com/users/danielsf/gists{/gist_id}","starred_url":"https://api.github.com/users/danielsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielsf/subscriptions","organizations_url":"https://api.github.com/users/danielsf/orgs","repos_url":"https://api.github.com/users/danielsf/repos","events_url":"https://api.github.com/users/danielsf/events{/privacy}","received_events_url":"https://api.github.com/users/danielsf/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/lsst/sims_photUtils/pulls/20/commits","review_comments_url":"https://api.github.com/repos/lsst/sims_photUtils/pulls/20/comments","review_comment_url":"https://api.github.com/repos/lsst/sims_photUtils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lsst/sims_photUtils/issues/20/comments","statuses_url":"https://api.github.com/repos/lsst/sims_photUtils/statuses/042e6252c2fb6c34120f32cb46ea7a9aa5426bd3","head":{"label":"lsst:feature/SIM-1496-newNeff","ref":"feature/SIM-1496-newNeff","sha":"042e6252c2fb6c34120f32cb46ea7a9aa5426bd3","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":34668465,"name":"sims_photUtils","full_name":"lsst/sims_photUtils","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/sims_photUtils","description":"LSST Simulations package for photometric utility functions","fork":false,"url":"https://api.github.com/repos/lsst/sims_photUtils","forks_url":"https://api.github.com/repos/lsst/sims_photUtils/forks","keys_url":"https://api.github.com/repos/lsst/sims_photUtils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/sims_photUtils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/sims_photUtils/teams","hooks_url":"https://api.github.com/repos/lsst/sims_photUtils/hooks","issue_events_url":"https://api.github.com/repos/lsst/sims_photUtils/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/sims_photUtils/events","assignees_url":"https://api.github.com/repos/lsst/sims_photUtils/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/sims_photUtils/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/sims_photUtils/tags","blobs_url":"https://api.github.com/repos/lsst/sims_photUtils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/sims_photUtils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/sims_photUtils/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/sims_photUtils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/sims_photUtils/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/sims_photUtils/languages","stargazers_url":"https://api.github.com/repos/lsst/sims_photUtils/stargazers","contributors_url":"https://api.github.com/repos/lsst/sims_photUtils/contributors","subscribers_url":"https://api.github.com/repos/lsst/sims_photUtils/subscribers","subscription_url":"https://api.github.com/repos/lsst/sims_photUtils/subscription","commits_url":"https://api.github.com/repos/lsst/sims_photUtils/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/sims_photUtils/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/sims_photUtils/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/sims_photUtils/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/sims_photUtils/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/sims_photUtils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/sims_photUtils/merges","archive_url":"https://api.github.com/repos/lsst/sims_photUtils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/sims_photUtils/downloads","issues_url":"https://api.github.com/repos/lsst/sims_photUtils/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/sims_photUtils/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/sims_photUtils/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/sims_photUtils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/sims_photUtils/labels{/name}","releases_url":"https://api.github.com/repos/lsst/sims_photUtils/releases{/id}","created_at":"2015-04-27T13:31:12Z","updated_at":"2015-05-08T20:31:48Z","pushed_at":"2015-09-30T01:15:57Z","git_url":"git://github.com/lsst/sims_photUtils.git","ssh_url":"git@github.com:lsst/sims_photUtils.git","clone_url":"https://github.com/lsst/sims_photUtils.git","svn_url":"https://github.com/lsst/sims_photUtils","homepage":null,"size":4250,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"lsst:master","ref":"master","sha":"9259b29a65286f60e391da64acf1e78bd90811ac","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":34668465,"name":"sims_photUtils","full_name":"lsst/sims_photUtils","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/sims_photUtils","description":"LSST Simulations package for photometric utility functions","fork":false,"url":"https://api.github.com/repos/lsst/sims_photUtils","forks_url":"https://api.github.com/repos/lsst/sims_photUtils/forks","keys_url":"https://api.github.com/repos/lsst/sims_photUtils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/sims_photUtils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/sims_photUtils/teams","hooks_url":"https://api.github.com/repos/lsst/sims_photUtils/hooks","issue_events_url":"https://api.github.com/repos/lsst/sims_photUtils/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/sims_photUtils/events","assignees_url":"https://api.github.com/repos/lsst/sims_photUtils/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/sims_photUtils/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/sims_photUtils/tags","blobs_url":"https://api.github.com/repos/lsst/sims_photUtils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/sims_photUtils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/sims_photUtils/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/sims_photUtils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/sims_photUtils/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/sims_photUtils/languages","stargazers_url":"https://api.github.com/repos/lsst/sims_photUtils/stargazers","contributors_url":"https://api.github.com/repos/lsst/sims_photUtils/contributors","subscribers_url":"https://api.github.com/repos/lsst/sims_photUtils/subscribers","subscription_url":"https://api.github.com/repos/lsst/sims_photUtils/subscription","commits_url":"https://api.github.com/repos/lsst/sims_photUtils/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/sims_photUtils/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/sims_photUtils/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/sims_photUtils/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/sims_photUtils/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/sims_photUtils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/sims_photUtils/merges","archive_url":"https://api.github.com/repos/lsst/sims_photUtils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/sims_photUtils/downloads","issues_url":"https://api.github.com/repos/lsst/sims_photUtils/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/sims_photUtils/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/sims_photUtils/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/sims_photUtils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/sims_photUtils/labels{/name}","releases_url":"https://api.github.com/repos/lsst/sims_photUtils/releases{/id}","created_at":"2015-04-27T13:31:12Z","updated_at":"2015-05-08T20:31:48Z","pushed_at":"2015-09-30T01:15:57Z","git_url":"git://github.com/lsst/sims_photUtils.git","ssh_url":"git@github.com:lsst/sims_photUtils.git","clone_url":"https://github.com/lsst/sims_photUtils.git","svn_url":"https://github.com/lsst/sims_photUtils","homepage":null,"size":4250,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lsst/sims_photUtils/pulls/20"},"html":{"href":"https://github.com/lsst/sims_photUtils/pull/20"},"issue":{"href":"https://api.github.com/repos/lsst/sims_photUtils/issues/20"},"comments":{"href":"https://api.github.com/repos/lsst/sims_photUtils/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/lsst/sims_photUtils/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/lsst/sims_photUtils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lsst/sims_photUtils/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/lsst/sims_photUtils/statuses/042e6252c2fb6c34120f32cb46ea7a9aa5426bd3"}}}}