{"action":"closed","number":9462,"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/9462","id":38810826,"html_url":"https://github.com/laravel/framework/pull/9462","diff_url":"https://github.com/laravel/framework/pull/9462.diff","patch_url":"https://github.com/laravel/framework/pull/9462.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/9462","number":9462,"state":"closed","locked":false,"title":"[5.1] Fix failing unit test for BladeCompiler","user":{"login":"ArjanSchouten","id":5930718,"avatar_url":"https://avatars.githubusercontent.com/u/5930718?v=3","gravatar_id":"","url":"https://api.github.com/users/ArjanSchouten","html_url":"https://github.com/ArjanSchouten","followers_url":"https://api.github.com/users/ArjanSchouten/followers","following_url":"https://api.github.com/users/ArjanSchouten/following{/other_user}","gists_url":"https://api.github.com/users/ArjanSchouten/gists{/gist_id}","starred_url":"https://api.github.com/users/ArjanSchouten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArjanSchouten/subscriptions","organizations_url":"https://api.github.com/users/ArjanSchouten/orgs","repos_url":"https://api.github.com/users/ArjanSchouten/repos","events_url":"https://api.github.com/users/ArjanSchouten/events{/privacy}","received_events_url":"https://api.github.com/users/ArjanSchouten/received_events","type":"User","site_admin":false},"body":"The unit tests are failing for me on php 5.6.10:\r\n```\r\nThere were 2 failures:\r\n\r\n1) ViewBladeCompilerTest::testExtendsAreCompiled\r\nFailed asserting that two strings are equal.\r\n--- Expected\r\n+++ Actual\r\n@@ @@\r\n-'test\r\n+'\r\n+test\r\n <?php echo $__env->make('foo', array_except(get_defined_vars(), array('__data', '__path')))->render(); ?>'\r\n\r\n/home/vagrant/laravel-framework/tests/View/ViewBladeCompilerTest.php:191\r\n/home/vagrant/.composer/vendor/phpunit/phpunit/src/TextUI/Command.php:147\r\n/home/vagrant/.composer/vendor/phpunit/phpunit/src/TextUI/Command.php:99\r\n\r\n2) ViewBladeCompilerTest::testSequentialCompileStringCalls\r\nFailed asserting that two strings are equal.\r\n--- Expected\r\n+++ Actual\r\n@@ @@\r\n-'test\r\n+'\r\n+test\r\n <?php echo $__env->make('foo', array_except(get_defined_vars(), array('__data', '__path')))->render(); ?>'\r\n\r\n/home/vagrant/laravel-framework/tests/View/ViewBladeCompilerTest.php:600\r\n/home/vagrant/.composer/vendor/phpunit/phpunit/src/TextUI/Command.php:147\r\n/home/vagrant/.composer/vendor/phpunit/phpunit/src/TextUI/Command.php:99\r\n\r\nFAILURES!\r\nTests: 1527, Assertions: 3388, Failures: 2.\r\n```\r\n\r\nIt's an issue in the BladeCompiler. The problem is a new line which is introduced on this line: \r\n```\r\n$result = ltrim($result, PHP_EOL)\r\n                    .PHP_EOL.implode(PHP_EOL, array_reverse($this->footer));\r\n```\r\nThe ```ltrim()``` isn't doing it's job. The easiest way is to skip the ```PHP_EOL```. It doesn't matter because ```ltrim``` without  params will trim blank lines. Furthermore removing tabs etc is welcome in this situation.","created_at":"2015-06-29T19:55:46Z","updated_at":"2015-06-29T20:55:30Z","closed_at":"2015-06-29T20:55:30Z","merged_at":null,"merge_commit_sha":"7512befa2be07239da1147d9ca87147a4d5dd018","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/9462/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/9462/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/9462/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/92b1c7ff97bdd651c0bc6371c2544dcd85e1fdff","head":{"label":"ArjanSchouten:5.1","ref":"5.1","sha":"92b1c7ff97bdd651c0bc6371c2544dcd85e1fdff","user":{"login":"ArjanSchouten","id":5930718,"avatar_url":"https://avatars.githubusercontent.com/u/5930718?v=3","gravatar_id":"","url":"https://api.github.com/users/ArjanSchouten","html_url":"https://github.com/ArjanSchouten","followers_url":"https://api.github.com/users/ArjanSchouten/followers","following_url":"https://api.github.com/users/ArjanSchouten/following{/other_user}","gists_url":"https://api.github.com/users/ArjanSchouten/gists{/gist_id}","starred_url":"https://api.github.com/users/ArjanSchouten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArjanSchouten/subscriptions","organizations_url":"https://api.github.com/users/ArjanSchouten/orgs","repos_url":"https://api.github.com/users/ArjanSchouten/repos","events_url":"https://api.github.com/users/ArjanSchouten/events{/privacy}","received_events_url":"https://api.github.com/users/ArjanSchouten/received_events","type":"User","site_admin":false},"repo":{"id":38266412,"name":"framework","full_name":"ArjanSchouten/framework","owner":{"login":"ArjanSchouten","id":5930718,"avatar_url":"https://avatars.githubusercontent.com/u/5930718?v=3","gravatar_id":"","url":"https://api.github.com/users/ArjanSchouten","html_url":"https://github.com/ArjanSchouten","followers_url":"https://api.github.com/users/ArjanSchouten/followers","following_url":"https://api.github.com/users/ArjanSchouten/following{/other_user}","gists_url":"https://api.github.com/users/ArjanSchouten/gists{/gist_id}","starred_url":"https://api.github.com/users/ArjanSchouten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArjanSchouten/subscriptions","organizations_url":"https://api.github.com/users/ArjanSchouten/orgs","repos_url":"https://api.github.com/users/ArjanSchouten/repos","events_url":"https://api.github.com/users/ArjanSchouten/events{/privacy}","received_events_url":"https://api.github.com/users/ArjanSchouten/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ArjanSchouten/framework","description":"","fork":true,"url":"https://api.github.com/repos/ArjanSchouten/framework","forks_url":"https://api.github.com/repos/ArjanSchouten/framework/forks","keys_url":"https://api.github.com/repos/ArjanSchouten/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArjanSchouten/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArjanSchouten/framework/teams","hooks_url":"https://api.github.com/repos/ArjanSchouten/framework/hooks","issue_events_url":"https://api.github.com/repos/ArjanSchouten/framework/issues/events{/number}","events_url":"https://api.github.com/repos/ArjanSchouten/framework/events","assignees_url":"https://api.github.com/repos/ArjanSchouten/framework/assignees{/user}","branches_url":"https://api.github.com/repos/ArjanSchouten/framework/branches{/branch}","tags_url":"https://api.github.com/repos/ArjanSchouten/framework/tags","blobs_url":"https://api.github.com/repos/ArjanSchouten/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArjanSchouten/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArjanSchouten/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArjanSchouten/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArjanSchouten/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/ArjanSchouten/framework/languages","stargazers_url":"https://api.github.com/repos/ArjanSchouten/framework/stargazers","contributors_url":"https://api.github.com/repos/ArjanSchouten/framework/contributors","subscribers_url":"https://api.github.com/repos/ArjanSchouten/framework/subscribers","subscription_url":"https://api.github.com/repos/ArjanSchouten/framework/subscription","commits_url":"https://api.github.com/repos/ArjanSchouten/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArjanSchouten/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArjanSchouten/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArjanSchouten/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArjanSchouten/framework/contents/{+path}","compare_url":"https://api.github.com/repos/ArjanSchouten/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArjanSchouten/framework/merges","archive_url":"https://api.github.com/repos/ArjanSchouten/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArjanSchouten/framework/downloads","issues_url":"https://api.github.com/repos/ArjanSchouten/framework/issues{/number}","pulls_url":"https://api.github.com/repos/ArjanSchouten/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/ArjanSchouten/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/ArjanSchouten/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArjanSchouten/framework/labels{/name}","releases_url":"https://api.github.com/repos/ArjanSchouten/framework/releases{/id}","created_at":"2015-06-29T19:19:34Z","updated_at":"2015-06-29T19:19:37Z","pushed_at":"2015-06-29T19:54:10Z","git_url":"git://github.com/ArjanSchouten/framework.git","ssh_url":"git@github.com:ArjanSchouten/framework.git","clone_url":"https://github.com/ArjanSchouten/framework.git","svn_url":"https://github.com/ArjanSchouten/framework","homepage":"http://laravel.com","size":64179,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.1"}},"base":{"label":"laravel:5.1","ref":"5.1","sha":"1afb3d164dedc305d7ecead87262bef6d9218885","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"name":"framework","full_name":"laravel/framework","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/framework","description":"","fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","created_at":"2013-01-10T21:27:28Z","updated_at":"2015-06-29T20:03:44Z","pushed_at":"2015-06-29T19:55:47Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"http://laravel.com","size":64179,"stargazers_count":3772,"watchers_count":3772,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2108,"mirror_url":null,"open_issues_count":71,"forks":2108,"open_issues":71,"watchers":3772,"default_branch":"5.1"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/9462"},"html":{"href":"https://github.com/laravel/framework/pull/9462"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/9462"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/9462/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/9462/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/9462/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/92b1c7ff97bdd651c0bc6371c2544dcd85e1fdff"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":5,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}