{"action":"closed","number":130,"pull_request":{"url":"https://api.github.com/repos/yahoo/ember-intl/pulls/130","id":38311197,"html_url":"https://github.com/yahoo/ember-intl/pull/130","diff_url":"https://github.com/yahoo/ember-intl/pull/130.diff","patch_url":"https://github.com/yahoo/ember-intl/pull/130.patch","issue_url":"https://api.github.com/repos/yahoo/ember-intl/issues/130","number":130,"state":"closed","locked":false,"title":"first pass at icu helper","user":{"login":"jasonmit","id":3108309,"avatar_url":"https://avatars.githubusercontent.com/u/3108309?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonmit","html_url":"https://github.com/jasonmit","followers_url":"https://api.github.com/users/jasonmit/followers","following_url":"https://api.github.com/users/jasonmit/following{/other_user}","gists_url":"https://api.github.com/users/jasonmit/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonmit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonmit/subscriptions","organizations_url":"https://api.github.com/users/jasonmit/orgs","repos_url":"https://api.github.com/users/jasonmit/repos","events_url":"https://api.github.com/users/jasonmit/events{/privacy}","received_events_url":"https://api.github.com/users/jasonmit/received_events","type":"User","site_admin":false},"body":"This PR removes the need for the intl-get helper and instead any arguments passed into format-message are assumed to be a path to a translation.  If you want to pass a literal string you now must use the `icu` helper.\r\n\r\n```hbs\r\n{{format-message (icu '{price, number, EUR}') price=1000}}\r\n{{format-message 'product.info' price=1000 name='Macbook'}}\r\n```\r\n\r\nThe reason for this is passing a string literal is not as popular of a use-case as passing the translation path.\r\n\r\n* [ ] document\r\n* [ ] support < 1.13\r\n* [ ] fix failing tests","created_at":"2015-06-23T08:16:55Z","updated_at":"2015-07-06T05:28:52Z","closed_at":"2015-07-06T05:28:52Z","merged_at":null,"merge_commit_sha":"425eef2cee5203d4ebf43eecb64c78663758d972","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yahoo/ember-intl/pulls/130/commits","review_comments_url":"https://api.github.com/repos/yahoo/ember-intl/pulls/130/comments","review_comment_url":"https://api.github.com/repos/yahoo/ember-intl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yahoo/ember-intl/issues/130/comments","statuses_url":"https://api.github.com/repos/yahoo/ember-intl/statuses/4d0f40dcab1a6fd1b3fe58db48a6324d2018971b","head":{"label":"yahoo:icu-helper","ref":"icu-helper","sha":"4d0f40dcab1a6fd1b3fe58db48a6324d2018971b","user":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":29941808,"name":"ember-intl","full_name":"yahoo/ember-intl","owner":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/ember-intl","description":"FormatJS integration for EmberJS","fork":false,"url":"https://api.github.com/repos/yahoo/ember-intl","forks_url":"https://api.github.com/repos/yahoo/ember-intl/forks","keys_url":"https://api.github.com/repos/yahoo/ember-intl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/ember-intl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/ember-intl/teams","hooks_url":"https://api.github.com/repos/yahoo/ember-intl/hooks","issue_events_url":"https://api.github.com/repos/yahoo/ember-intl/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/ember-intl/events","assignees_url":"https://api.github.com/repos/yahoo/ember-intl/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/ember-intl/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/ember-intl/tags","blobs_url":"https://api.github.com/repos/yahoo/ember-intl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/ember-intl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/ember-intl/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/ember-intl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/ember-intl/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/ember-intl/languages","stargazers_url":"https://api.github.com/repos/yahoo/ember-intl/stargazers","contributors_url":"https://api.github.com/repos/yahoo/ember-intl/contributors","subscribers_url":"https://api.github.com/repos/yahoo/ember-intl/subscribers","subscription_url":"https://api.github.com/repos/yahoo/ember-intl/subscription","commits_url":"https://api.github.com/repos/yahoo/ember-intl/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/ember-intl/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/ember-intl/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/ember-intl/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/ember-intl/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/ember-intl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/ember-intl/merges","archive_url":"https://api.github.com/repos/yahoo/ember-intl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/ember-intl/downloads","issues_url":"https://api.github.com/repos/yahoo/ember-intl/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/ember-intl/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/ember-intl/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/ember-intl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/ember-intl/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/ember-intl/releases{/id}","created_at":"2015-01-28T00:07:14Z","updated_at":"2015-07-05T19:27:50Z","pushed_at":"2015-07-06T00:55:11Z","git_url":"git://github.com/yahoo/ember-intl.git","ssh_url":"git@github.com:yahoo/ember-intl.git","clone_url":"https://github.com/yahoo/ember-intl.git","svn_url":"https://github.com/yahoo/ember-intl","homepage":null,"size":2272,"stargazers_count":93,"watchers_count":93,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":11,"forks":12,"open_issues":11,"watchers":93,"default_branch":"master"}},"base":{"label":"yahoo:2.0","ref":"2.0","sha":"c87be29f9a83e6d927e90ce845645e7cf94c7d0b","user":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":29941808,"name":"ember-intl","full_name":"yahoo/ember-intl","owner":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/ember-intl","description":"FormatJS integration for EmberJS","fork":false,"url":"https://api.github.com/repos/yahoo/ember-intl","forks_url":"https://api.github.com/repos/yahoo/ember-intl/forks","keys_url":"https://api.github.com/repos/yahoo/ember-intl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/ember-intl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/ember-intl/teams","hooks_url":"https://api.github.com/repos/yahoo/ember-intl/hooks","issue_events_url":"https://api.github.com/repos/yahoo/ember-intl/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/ember-intl/events","assignees_url":"https://api.github.com/repos/yahoo/ember-intl/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/ember-intl/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/ember-intl/tags","blobs_url":"https://api.github.com/repos/yahoo/ember-intl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/ember-intl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/ember-intl/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/ember-intl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/ember-intl/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/ember-intl/languages","stargazers_url":"https://api.github.com/repos/yahoo/ember-intl/stargazers","contributors_url":"https://api.github.com/repos/yahoo/ember-intl/contributors","subscribers_url":"https://api.github.com/repos/yahoo/ember-intl/subscribers","subscription_url":"https://api.github.com/repos/yahoo/ember-intl/subscription","commits_url":"https://api.github.com/repos/yahoo/ember-intl/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/ember-intl/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/ember-intl/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/ember-intl/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/ember-intl/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/ember-intl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/ember-intl/merges","archive_url":"https://api.github.com/repos/yahoo/ember-intl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/ember-intl/downloads","issues_url":"https://api.github.com/repos/yahoo/ember-intl/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/ember-intl/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/ember-intl/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/ember-intl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/ember-intl/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/ember-intl/releases{/id}","created_at":"2015-01-28T00:07:14Z","updated_at":"2015-07-05T19:27:50Z","pushed_at":"2015-07-06T00:55:11Z","git_url":"git://github.com/yahoo/ember-intl.git","ssh_url":"git@github.com:yahoo/ember-intl.git","clone_url":"https://github.com/yahoo/ember-intl.git","svn_url":"https://github.com/yahoo/ember-intl","homepage":null,"size":2272,"stargazers_count":93,"watchers_count":93,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":11,"forks":12,"open_issues":11,"watchers":93,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yahoo/ember-intl/pulls/130"},"html":{"href":"https://github.com/yahoo/ember-intl/pull/130"},"issue":{"href":"https://api.github.com/repos/yahoo/ember-intl/issues/130"},"comments":{"href":"https://api.github.com/repos/yahoo/ember-intl/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/yahoo/ember-intl/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/yahoo/ember-intl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yahoo/ember-intl/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/yahoo/ember-intl/statuses/4d0f40dcab1a6fd1b3fe58db48a6324d2018971b"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":11,"review_comments":0,"commits":26,"additions":1435,"deletions":1029,"changed_files":89}}