{"action":"created","issue":{"url":"https://api.github.com/repos/discourse/discourse/issues/3705","labels_url":"https://api.github.com/repos/discourse/discourse/issues/3705/labels{/name}","comments_url":"https://api.github.com/repos/discourse/discourse/issues/3705/comments","events_url":"https://api.github.com/repos/discourse/discourse/issues/3705/events","html_url":"https://github.com/discourse/discourse/pull/3705","id":103818705,"number":3705,"title":"Simplified positioning for the menu-panel - works for LTR and RTL layouts","user":{"login":"scossar","id":2975917,"avatar_url":"https://avatars.githubusercontent.com/u/2975917?v=3","gravatar_id":"","url":"https://api.github.com/users/scossar","html_url":"https://github.com/scossar","followers_url":"https://api.github.com/users/scossar/followers","following_url":"https://api.github.com/users/scossar/following{/other_user}","gists_url":"https://api.github.com/users/scossar/gists{/gist_id}","starred_url":"https://api.github.com/users/scossar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scossar/subscriptions","organizations_url":"https://api.github.com/users/scossar/orgs","repos_url":"https://api.github.com/users/scossar/repos","events_url":"https://api.github.com/users/scossar/events{/privacy}","received_events_url":"https://api.github.com/users/scossar/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-08-29T01:02:52Z","updated_at":"2015-09-05T19:30:09Z","closed_at":"2015-09-05T19:30:09Z","pull_request":{"url":"https://api.github.com/repos/discourse/discourse/pulls/3705","html_url":"https://github.com/discourse/discourse/pull/3705","diff_url":"https://github.com/discourse/discourse/pull/3705.diff","patch_url":"https://github.com/discourse/discourse/pull/3705.patch"},"body":"@eviltrout this seems straightforward. Maybe there's something I'm missing.\r\n\r\n- adds `position: relative` to `.wrap`\r\n- moves menu components in `header.hbs` into the wrap div\r\n- sets the horizontal position of `.menu-panel` absolutely in relation to its containing wrap div\r\n- removes horizontal positioning from `menu-panel.js.es6`\r\n\r\nThis works without any further adjustments for RTL layouts. With the way the menu-panel is currently being positioned, to position it correctly for RTL layouts will require checking if we are in a RTL layout and then adjusting the horizontal positioning values in `menu-panel.js.es6`. \r\n\r\nFrom my point of view, as someone who wants to be able to heavily customize the Discourse css, it would be preferable if the menu components could be moved so that where they appear in the document relates to where they are positioned on the screen. This is immediately after the header `<ul class='icons clearfix' role='navigation'></ul>`. If you can do this, all of the changes in this PR will still work. There will no longer be a need to add `position: relative` to `.wrap` as it is already set on the `.contents` div.\r\n\r\nAs an added bonus, moving the components to their correct position in the document will allow you to set most of the vertical positioning of the menu without using javascript. (There is some difficulty in setting the slide-out menu vertical positioning and height without javascript as its position aligns with the main-outlet, not the header.)"},"comment":{"url":"https://api.github.com/repos/discourse/discourse/issues/comments/137988324","html_url":"https://github.com/discourse/discourse/pull/3705#issuecomment-137988324","issue_url":"https://api.github.com/repos/discourse/discourse/issues/3705","id":137988324,"user":{"login":"scossar","id":2975917,"avatar_url":"https://avatars.githubusercontent.com/u/2975917?v=3","gravatar_id":"","url":"https://api.github.com/users/scossar","html_url":"https://github.com/scossar","followers_url":"https://api.github.com/users/scossar/followers","following_url":"https://api.github.com/users/scossar/following{/other_user}","gists_url":"https://api.github.com/users/scossar/gists{/gist_id}","starred_url":"https://api.github.com/users/scossar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scossar/subscriptions","organizations_url":"https://api.github.com/users/scossar/orgs","repos_url":"https://api.github.com/users/scossar/repos","events_url":"https://api.github.com/users/scossar/events{/privacy}","received_events_url":"https://api.github.com/users/scossar/received_events","type":"User","site_admin":false},"created_at":"2015-09-05T19:30:09Z","updated_at":"2015-09-05T19:30:09Z","body":"I have improved on this quite a bit. I'll send it as a new PR."}}