{"action":"created","issue":{"url":"https://api.github.com/repos/Parsely/pykafka/issues/298","labels_url":"https://api.github.com/repos/Parsely/pykafka/issues/298/labels{/name}","comments_url":"https://api.github.com/repos/Parsely/pykafka/issues/298/comments","events_url":"https://api.github.com/repos/Parsely/pykafka/issues/298/events","html_url":"https://github.com/Parsely/pykafka/pull/298","id":111024429,"number":298,"title":"consumer off-by-one","user":{"login":"emmett9001","id":723615,"avatar_url":"https://avatars.githubusercontent.com/u/723615?v=3","gravatar_id":"","url":"https://api.github.com/users/emmett9001","html_url":"https://github.com/emmett9001","followers_url":"https://api.github.com/users/emmett9001/followers","following_url":"https://api.github.com/users/emmett9001/following{/other_user}","gists_url":"https://api.github.com/users/emmett9001/gists{/gist_id}","starred_url":"https://api.github.com/users/emmett9001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmett9001/subscriptions","organizations_url":"https://api.github.com/users/emmett9001/orgs","repos_url":"https://api.github.com/users/emmett9001/repos","events_url":"https://api.github.com/users/emmett9001/events{/privacy}","received_events_url":"https://api.github.com/users/emmett9001/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Parsely/pykafka/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-10-12T17:57:50Z","updated_at":"2015-10-13T15:04:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Parsely/pykafka/pulls/298","html_url":"https://github.com/Parsely/pykafka/pull/298","diff_url":"https://github.com/Parsely/pykafka/pull/298.diff","patch_url":"https://github.com/Parsely/pykafka/pull/298.patch"},"body":"This pull request changes the way `SimpleConsumer` maintains its internal offset counters. In `OffsetCommitRequest`s, the consumer now sends the *next* offset to consume rather than the last one consumed, fixing the issue raised in #289.\r\n\r\nBased on the test cases in #289, this seems to be what Kafka expects. I can't find anywhere in the documentation whether this is technically correct or not, but I suppose hoping for that is a bit of a long shot given the state of their docs. This pull request also adjusts some existing consumer tests based on the assumption that Kafka expects this.\r\n\r\nThis pull request also pushes as much of the `-1`/`+1` offset logic as possible out of the consumer."},"comment":{"url":"https://api.github.com/repos/Parsely/pykafka/issues/comments/147742967","html_url":"https://github.com/Parsely/pykafka/pull/298#issuecomment-147742967","issue_url":"https://api.github.com/repos/Parsely/pykafka/issues/298","id":147742967,"user":{"login":"emmett9001","id":723615,"avatar_url":"https://avatars.githubusercontent.com/u/723615?v=3","gravatar_id":"","url":"https://api.github.com/users/emmett9001","html_url":"https://github.com/emmett9001","followers_url":"https://api.github.com/users/emmett9001/followers","following_url":"https://api.github.com/users/emmett9001/following{/other_user}","gists_url":"https://api.github.com/users/emmett9001/gists{/gist_id}","starred_url":"https://api.github.com/users/emmett9001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmett9001/subscriptions","organizations_url":"https://api.github.com/users/emmett9001/orgs","repos_url":"https://api.github.com/users/emmett9001/repos","events_url":"https://api.github.com/users/emmett9001/events{/privacy}","received_events_url":"https://api.github.com/users/emmett9001/received_events","type":"User","site_admin":false},"created_at":"2015-10-13T15:04:03Z","updated_at":"2015-10-13T15:04:03Z","body":"@yungchin the current state of this branch uses logic that's consistent with master but requires less `-1`/`+1` offset logic. Let me know if you see anything that you think should be changed."}}