{"action":"created","comment":{"url":"https://api.github.com/repos/windup/windup-rulesets/pulls/comments/38572191","id":38572191,"diff_hunk":"@@ -0,0 +1,150 @@\n+<?xml version=\"1.0\"?>\n+<ruleset id=\"jboss-eap5-java\"\n+         xmlns=\"http://windup.jboss.org/schema/jboss-ruleset\"\n+         xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\"\n+         xsi:schemaLocation=\"http://windup.jboss.org/schema/jboss-ruleset http://windup.jboss.org/schema/jboss-ruleset/windup-jboss-ruleset.xsd\">\n+\n+    <!-- Rules converted from Tubame JBossRules.windup.xml -->\n+\n+    <metadata>\n+        <description>\n+            This ruleset provides analysis of JBoss EAP 5 .java files that may require individual attention\n+            when migrating to JBoss EAP 6+.\n+        </description>\n+        <dependencies>\n+            <addon id=\"org.jboss.windup.rules,windup-rules-javaee,2.3.0.Final\"/>\n+            <addon id=\"org.jboss.windup.rules,windup-rules-java,2.3.0.Final\"/>\n+        </dependencies>\n+        <sourceTechnology id=\"eap\" versionRange=\"[5,6)\"/>\n+        <targetTechnology id=\"eap\" versionRange=\"[6,)\"/>\n+        <tag>jboss-eap5</tag>\n+        <tag>jms</tag>\n+        <tag>ejb</tag>\n+        <tag>reviewed-2015-08-28</tag>\n+    </metadata>\n+\n+    <rules>\n+        <rule id=\"jboss-eap5-java-01000\">\n+            <when>\n+                <javaclass references=\"org.jboss.ejb3.annotation.Management\">\n+                    <location>ANNOTATION</location>\n+                </javaclass>\n+            </when>\n+            <perform>\n+                <classification title=\"JBoss EAP 5 JMX ManagementBean\" effort=\"3\">\n+                    <tag>jmx</tag>\n+                </classification>\n+            </perform>\n+        </rule>\n+        <rule id=\"jboss-eap5-java-02000\">\n+            <when>\n+                <javaclass references=\"javax.jms.QueueConnectionFactory\">\n+                    <location>FIELD_DECLARATION</location>\n+                    <location>VARIABLE_DECLARATION</location>\n+                </javaclass>\n+            </when>\n+            <perform>\n+                <hint effort=\"1\" severity=\"MANDATORY\">\n+                    <message>`QueueConnectionFactory` was used to obtain connection to JMS queues.\n+                        Replace the lookup string `QueueConnectionFactory` with `ConnectionFactory`.\n+                    </message>\n+                    <tag>jms</tag>\n+                </hint>\n+            </perform>\n+        </rule>\n+        <rule id=\"jboss-eap5-java-03000\">\n+            <when>\n+                <javaclass references=\"javax.persistence.JoinColumn\">\n+                    <location>ANNOTATION</location>\n+                </javaclass>\n+            </when>\n+            <perform>\n+                <hint effort=\"3\" severity=\"MANDATORY\">\n+                    <message>\n+                        The `@JoinColumn` annotation specifies the column used by JPA provider for foreign keys.\n+                        Ensure `@JoinColumn` is replaced with `@JoinColumns(@JoinColumn)`\n+                        or `@JoinFormula`.\n+                    </message>\n+                    <link title=\"JBoss EAP 6 Development Guide: Hibernate Annotations\" href=\"https://access.redhat.com/documentation/en-US/JBoss_Enterprise_Application_Platform/6.4/html-single/Development_Guide/index.html#sect-Hibernate_Annotations\"/>\n+                    <tag>jpa</tag>\n+                </hint>\n+            </perform>\n+        </rule>\n+        <rule id=\"jboss-eap5-java-04000\">\n+            <when>\n+                <javaclass references=\"org.jboss.annotation.ejb.Service\">\n+                    <location>IMPORT</location>\n+                </javaclass>\n+            </when>\n+            <perform>\n+                <hint effort=\"3\" severity=\"MANDATORY\">\n+                    <message>\n+                        The `@Service` annotation is one of JBoss EJB 3.0 extensions which creates a singleton EJB.\n+                        Use the new `org.jboss.ejb3.annotation.Service` instead.\n+                    </message>\n+                    <link title=\"JBoss EJB 3.0 extensions\" href=\"https://docs.jboss.org/ejb3/docs/reference/build/reference/en/html/jboss_extensions.html\"/>\n+                    <link title=\"JBoss EJB 3.0 Javadoc\" href=\"https://docs.jboss.org/ejb3/embedded/api/org/jboss/annotation/ejb/package-summary.html\"/>\n+                    <tag>ejb</tag>\n+                </hint>\n+            </perform>\n+        </rule>\n+        <rule id=\"jboss-eap5-java-05000\">\n+            <when>\n+                <javaclass references=\"org.jboss.annotation.ejb.Management\">\n+                    <location>IMPORT</location>\n+                </javaclass>\n+            </when>\n+            <perform>\n+                <hint effort=\"3\" severity=\"MANDATORY\">\n+                    <message>\n+                        The `@Management` annotation is one of JBoss EJB 3.0 extensions which wraps the the bean\n+                        as an MBean and install it in the JBoss MBean Server.\n+                        Use the new `org.jboss.ejb3.annotation.Management` instead.\n+                    </message>\n+                    <link title=\"JBoss EJB 3.0 extensions\" href=\"https://docs.jboss.org/ejb3/docs/reference/build/reference/en/html/jboss_extensions.html\"/>\n+                    <link title=\"JBoss EJB 3.0 Javadoc\" href=\"https://docs.jboss.org/ejb3/embedded/api/org/jboss/annotation/ejb/package-summary.html\"/>\n+                    <tag>ejb</tag>\n+                    <tag>jmx</tag>\n+                </hint>\n+            </perform>\n+        </rule>\n+        <rule id=\"jboss-eap5-java-06000\">\n+            <when>\n+                <javaclass references=\"org.jboss.annotation.ejb.LocalBinding\">\n+                    <location>ANNOTATION</location>\n+                </javaclass>\n+            </when>\n+            <perform>\n+                <hint effort=\"3\" severity=\"MANDATORY\">","path":"rules-reviewed/jboss-eap/jboss-eap5/jboss-eap5-java.windup.xml","position":118,"original_position":118,"commit_id":"cdf9e5c97caa9d10e61cc9e6bb4bb4f01c808591","original_commit_id":"cdf9e5c97caa9d10e61cc9e6bb4bb4f01c808591","user":{"login":"lincolnthree","id":362329,"avatar_url":"https://avatars.githubusercontent.com/u/362329?v=3","gravatar_id":"","url":"https://api.github.com/users/lincolnthree","html_url":"https://github.com/lincolnthree","followers_url":"https://api.github.com/users/lincolnthree/followers","following_url":"https://api.github.com/users/lincolnthree/following{/other_user}","gists_url":"https://api.github.com/users/lincolnthree/gists{/gist_id}","starred_url":"https://api.github.com/users/lincolnthree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lincolnthree/subscriptions","organizations_url":"https://api.github.com/users/lincolnthree/orgs","repos_url":"https://api.github.com/users/lincolnthree/repos","events_url":"https://api.github.com/users/lincolnthree/events{/privacy}","received_events_url":"https://api.github.com/users/lincolnthree/received_events","type":"User","site_admin":false},"body":"Hints need titles.","created_at":"2015-09-02T19:14:31Z","updated_at":"2015-09-02T19:14:31Z","html_url":"https://github.com/windup/windup-rulesets/pull/63#discussion_r38572191","pull_request_url":"https://api.github.com/repos/windup/windup-rulesets/pulls/63","_links":{"self":{"href":"https://api.github.com/repos/windup/windup-rulesets/pulls/comments/38572191"},"html":{"href":"https://github.com/windup/windup-rulesets/pull/63#discussion_r38572191"},"pull_request":{"href":"https://api.github.com/repos/windup/windup-rulesets/pulls/63"}}},"pull_request":{"url":"https://api.github.com/repos/windup/windup-rulesets/pulls/63","id":41812128,"html_url":"https://github.com/windup/windup-rulesets/pull/63","diff_url":"https://github.com/windup/windup-rulesets/pull/63.diff","patch_url":"https://github.com/windup/windup-rulesets/pull/63.patch","issue_url":"https://api.github.com/repos/windup/windup-rulesets/issues/63","number":63,"state":"open","locked":false,"title":"Rules review task103","user":{"login":"OndraZizka","id":644904,"avatar_url":"https://avatars.githubusercontent.com/u/644904?v=3","gravatar_id":"","url":"https://api.github.com/users/OndraZizka","html_url":"https://github.com/OndraZizka","followers_url":"https://api.github.com/users/OndraZizka/followers","following_url":"https://api.github.com/users/OndraZizka/following{/other_user}","gists_url":"https://api.github.com/users/OndraZizka/gists{/gist_id}","starred_url":"https://api.github.com/users/OndraZizka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OndraZizka/subscriptions","organizations_url":"https://api.github.com/users/OndraZizka/orgs","repos_url":"https://api.github.com/users/OndraZizka/repos","events_url":"https://api.github.com/users/OndraZizka/events{/privacy}","received_events_url":"https://api.github.com/users/OndraZizka/received_events","type":"User","site_admin":false},"body":"Just a preview. Not yet finished.","created_at":"2015-08-06T17:19:11Z","updated_at":"2015-09-02T19:14:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9899f7e66b55ca98869e18d3036eadd6f779dce1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/windup/windup-rulesets/pulls/63/commits","review_comments_url":"https://api.github.com/repos/windup/windup-rulesets/pulls/63/comments","review_comment_url":"https://api.github.com/repos/windup/windup-rulesets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/windup/windup-rulesets/issues/63/comments","statuses_url":"https://api.github.com/repos/windup/windup-rulesets/statuses/cdf9e5c97caa9d10e61cc9e6bb4bb4f01c808591","head":{"label":"OndraZizka:rulesReview-task103","ref":"rulesReview-task103","sha":"cdf9e5c97caa9d10e61cc9e6bb4bb4f01c808591","user":{"login":"OndraZizka","id":644904,"avatar_url":"https://avatars.githubusercontent.com/u/644904?v=3","gravatar_id":"","url":"https://api.github.com/users/OndraZizka","html_url":"https://github.com/OndraZizka","followers_url":"https://api.github.com/users/OndraZizka/followers","following_url":"https://api.github.com/users/OndraZizka/following{/other_user}","gists_url":"https://api.github.com/users/OndraZizka/gists{/gist_id}","starred_url":"https://api.github.com/users/OndraZizka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OndraZizka/subscriptions","organizations_url":"https://api.github.com/users/OndraZizka/orgs","repos_url":"https://api.github.com/users/OndraZizka/repos","events_url":"https://api.github.com/users/OndraZizka/events{/privacy}","received_events_url":"https://api.github.com/users/OndraZizka/received_events","type":"User","site_admin":false},"repo":{"id":36249911,"name":"windup-rulesets","full_name":"OndraZizka/windup-rulesets","owner":{"login":"OndraZizka","id":644904,"avatar_url":"https://avatars.githubusercontent.com/u/644904?v=3","gravatar_id":"","url":"https://api.github.com/users/OndraZizka","html_url":"https://github.com/OndraZizka","followers_url":"https://api.github.com/users/OndraZizka/followers","following_url":"https://api.github.com/users/OndraZizka/following{/other_user}","gists_url":"https://api.github.com/users/OndraZizka/gists{/gist_id}","starred_url":"https://api.github.com/users/OndraZizka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OndraZizka/subscriptions","organizations_url":"https://api.github.com/users/OndraZizka/orgs","repos_url":"https://api.github.com/users/OndraZizka/repos","events_url":"https://api.github.com/users/OndraZizka/events{/privacy}","received_events_url":"https://api.github.com/users/OndraZizka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/OndraZizka/windup-rulesets","description":"Rules and rulesets contributed by community.","fork":true,"url":"https://api.github.com/repos/OndraZizka/windup-rulesets","forks_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/forks","keys_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/teams","hooks_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/hooks","issue_events_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/issues/events{/number}","events_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/events","assignees_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/assignees{/user}","branches_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/branches{/branch}","tags_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/tags","blobs_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/git/refs{/sha}","trees_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/statuses/{sha}","languages_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/languages","stargazers_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/stargazers","contributors_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/contributors","subscribers_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/subscribers","subscription_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/subscription","commits_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/commits{/sha}","git_commits_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/git/commits{/sha}","comments_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/comments{/number}","issue_comment_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/issues/comments{/number}","contents_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/contents/{+path}","compare_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/merges","archive_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/downloads","issues_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/issues{/number}","pulls_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/pulls{/number}","milestones_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/milestones{/number}","notifications_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/labels{/name}","releases_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/releases{/id}","created_at":"2015-05-25T19:19:57Z","updated_at":"2015-06-15T22:30:27Z","pushed_at":"2015-09-01T22:40:46Z","git_url":"git://github.com/OndraZizka/windup-rulesets.git","ssh_url":"git@github.com:OndraZizka/windup-rulesets.git","clone_url":"https://github.com/OndraZizka/windup-rulesets.git","svn_url":"https://github.com/OndraZizka/windup-rulesets","homepage":null,"size":18203,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"windup:master","ref":"master","sha":"396251d1208772d38495283f53e0f5c6a00b6800","user":{"login":"windup","id":4266383,"avatar_url":"https://avatars.githubusercontent.com/u/4266383?v=3","gravatar_id":"","url":"https://api.github.com/users/windup","html_url":"https://github.com/windup","followers_url":"https://api.github.com/users/windup/followers","following_url":"https://api.github.com/users/windup/following{/other_user}","gists_url":"https://api.github.com/users/windup/gists{/gist_id}","starred_url":"https://api.github.com/users/windup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windup/subscriptions","organizations_url":"https://api.github.com/users/windup/orgs","repos_url":"https://api.github.com/users/windup/repos","events_url":"https://api.github.com/users/windup/events{/privacy}","received_events_url":"https://api.github.com/users/windup/received_events","type":"Organization","site_admin":false},"repo":{"id":23937058,"name":"windup-rulesets","full_name":"windup/windup-rulesets","owner":{"login":"windup","id":4266383,"avatar_url":"https://avatars.githubusercontent.com/u/4266383?v=3","gravatar_id":"","url":"https://api.github.com/users/windup","html_url":"https://github.com/windup","followers_url":"https://api.github.com/users/windup/followers","following_url":"https://api.github.com/users/windup/following{/other_user}","gists_url":"https://api.github.com/users/windup/gists{/gist_id}","starred_url":"https://api.github.com/users/windup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windup/subscriptions","organizations_url":"https://api.github.com/users/windup/orgs","repos_url":"https://api.github.com/users/windup/repos","events_url":"https://api.github.com/users/windup/events{/privacy}","received_events_url":"https://api.github.com/users/windup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/windup/windup-rulesets","description":"Windup rules and rulesets contributed by community.","fork":false,"url":"https://api.github.com/repos/windup/windup-rulesets","forks_url":"https://api.github.com/repos/windup/windup-rulesets/forks","keys_url":"https://api.github.com/repos/windup/windup-rulesets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/windup/windup-rulesets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/windup/windup-rulesets/teams","hooks_url":"https://api.github.com/repos/windup/windup-rulesets/hooks","issue_events_url":"https://api.github.com/repos/windup/windup-rulesets/issues/events{/number}","events_url":"https://api.github.com/repos/windup/windup-rulesets/events","assignees_url":"https://api.github.com/repos/windup/windup-rulesets/assignees{/user}","branches_url":"https://api.github.com/repos/windup/windup-rulesets/branches{/branch}","tags_url":"https://api.github.com/repos/windup/windup-rulesets/tags","blobs_url":"https://api.github.com/repos/windup/windup-rulesets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/windup/windup-rulesets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/windup/windup-rulesets/git/refs{/sha}","trees_url":"https://api.github.com/repos/windup/windup-rulesets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/windup/windup-rulesets/statuses/{sha}","languages_url":"https://api.github.com/repos/windup/windup-rulesets/languages","stargazers_url":"https://api.github.com/repos/windup/windup-rulesets/stargazers","contributors_url":"https://api.github.com/repos/windup/windup-rulesets/contributors","subscribers_url":"https://api.github.com/repos/windup/windup-rulesets/subscribers","subscription_url":"https://api.github.com/repos/windup/windup-rulesets/subscription","commits_url":"https://api.github.com/repos/windup/windup-rulesets/commits{/sha}","git_commits_url":"https://api.github.com/repos/windup/windup-rulesets/git/commits{/sha}","comments_url":"https://api.github.com/repos/windup/windup-rulesets/comments{/number}","issue_comment_url":"https://api.github.com/repos/windup/windup-rulesets/issues/comments{/number}","contents_url":"https://api.github.com/repos/windup/windup-rulesets/contents/{+path}","compare_url":"https://api.github.com/repos/windup/windup-rulesets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/windup/windup-rulesets/merges","archive_url":"https://api.github.com/repos/windup/windup-rulesets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/windup/windup-rulesets/downloads","issues_url":"https://api.github.com/repos/windup/windup-rulesets/issues{/number}","pulls_url":"https://api.github.com/repos/windup/windup-rulesets/pulls{/number}","milestones_url":"https://api.github.com/repos/windup/windup-rulesets/milestones{/number}","notifications_url":"https://api.github.com/repos/windup/windup-rulesets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/windup/windup-rulesets/labels{/name}","releases_url":"https://api.github.com/repos/windup/windup-rulesets/releases{/id}","created_at":"2014-09-11T21:51:19Z","updated_at":"2015-06-05T17:30:53Z","pushed_at":"2015-09-02T16:56:58Z","git_url":"git://github.com/windup/windup-rulesets.git","ssh_url":"git@github.com:windup/windup-rulesets.git","clone_url":"https://github.com/windup/windup-rulesets.git","svn_url":"https://github.com/windup/windup-rulesets","homepage":"http://windup.jboss.org","size":18971,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":4,"forks":10,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/windup/windup-rulesets/pulls/63"},"html":{"href":"https://github.com/windup/windup-rulesets/pull/63"},"issue":{"href":"https://api.github.com/repos/windup/windup-rulesets/issues/63"},"comments":{"href":"https://api.github.com/repos/windup/windup-rulesets/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/windup/windup-rulesets/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/windup/windup-rulesets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/windup/windup-rulesets/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/windup/windup-rulesets/statuses/cdf9e5c97caa9d10e61cc9e6bb4bb4f01c808591"}}}}