{"action":"closed","number":441,"pull_request":{"url":"https://api.github.com/repos/Alfresco/Aikau/pulls/441","id":41878628,"html_url":"https://github.com/Alfresco/Aikau/pull/441","diff_url":"https://github.com/Alfresco/Aikau/pull/441.diff","patch_url":"https://github.com/Alfresco/Aikau/pull/441.patch","issue_url":"https://api.github.com/repos/Alfresco/Aikau/issues/441","number":441,"state":"closed","locked":false,"title":"AKU-500: Update response scope behaviour to handle empty string falsy logic","user":{"login":"draperd","id":1084047,"avatar_url":"https://avatars.githubusercontent.com/u/1084047?v=3","gravatar_id":"","url":"https://api.github.com/users/draperd","html_url":"https://github.com/draperd","followers_url":"https://api.github.com/users/draperd/followers","following_url":"https://api.github.com/users/draperd/following{/other_user}","gists_url":"https://api.github.com/users/draperd/gists{/gist_id}","starred_url":"https://api.github.com/users/draperd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/draperd/subscriptions","organizations_url":"https://api.github.com/users/draperd/orgs","repos_url":"https://api.github.com/users/draperd/repos","events_url":"https://api.github.com/users/draperd/events{/privacy}","received_events_url":"https://api.github.com/users/draperd/received_events","type":"User","site_admin":false},"body":"This PR addresses https://issues.alfresco.com/jira/browse/AKU-500 and re-works the logic for figuring out the correct alfResponseScope to apply to a payload to ensure that global scope (or empty string) is accepted as a valid scope. I've added some specific unit tests to verify the expected behaviour and checked that the issue no longer occurs on Share with the Document Library.","created_at":"2015-08-07T10:27:48Z","updated_at":"2015-08-07T12:28:02Z","closed_at":"2015-08-07T12:28:02Z","merged_at":"2015-08-07T12:28:02Z","merge_commit_sha":"038d2ac511cb76328a9e03b7bfd5169a7006bc3a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Alfresco/Aikau/pulls/441/commits","review_comments_url":"https://api.github.com/repos/Alfresco/Aikau/pulls/441/comments","review_comment_url":"https://api.github.com/repos/Alfresco/Aikau/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alfresco/Aikau/issues/441/comments","statuses_url":"https://api.github.com/repos/Alfresco/Aikau/statuses/a38cd5662d230f7e282e1cbb22513bdc915a2b82","head":{"label":"Alfresco:feature/AKU-500_UnscopedDocLib","ref":"feature/AKU-500_UnscopedDocLib","sha":"a38cd5662d230f7e282e1cbb22513bdc915a2b82","user":{"login":"Alfresco","id":391127,"avatar_url":"https://avatars.githubusercontent.com/u/391127?v=3","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"repo":{"id":29740360,"name":"Aikau","full_name":"Alfresco/Aikau","owner":{"login":"Alfresco","id":391127,"avatar_url":"https://avatars.githubusercontent.com/u/391127?v=3","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alfresco/Aikau","description":"Aikau UI framework","fork":false,"url":"https://api.github.com/repos/Alfresco/Aikau","forks_url":"https://api.github.com/repos/Alfresco/Aikau/forks","keys_url":"https://api.github.com/repos/Alfresco/Aikau/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alfresco/Aikau/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alfresco/Aikau/teams","hooks_url":"https://api.github.com/repos/Alfresco/Aikau/hooks","issue_events_url":"https://api.github.com/repos/Alfresco/Aikau/issues/events{/number}","events_url":"https://api.github.com/repos/Alfresco/Aikau/events","assignees_url":"https://api.github.com/repos/Alfresco/Aikau/assignees{/user}","branches_url":"https://api.github.com/repos/Alfresco/Aikau/branches{/branch}","tags_url":"https://api.github.com/repos/Alfresco/Aikau/tags","blobs_url":"https://api.github.com/repos/Alfresco/Aikau/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alfresco/Aikau/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alfresco/Aikau/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alfresco/Aikau/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alfresco/Aikau/statuses/{sha}","languages_url":"https://api.github.com/repos/Alfresco/Aikau/languages","stargazers_url":"https://api.github.com/repos/Alfresco/Aikau/stargazers","contributors_url":"https://api.github.com/repos/Alfresco/Aikau/contributors","subscribers_url":"https://api.github.com/repos/Alfresco/Aikau/subscribers","subscription_url":"https://api.github.com/repos/Alfresco/Aikau/subscription","commits_url":"https://api.github.com/repos/Alfresco/Aikau/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alfresco/Aikau/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alfresco/Aikau/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alfresco/Aikau/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alfresco/Aikau/contents/{+path}","compare_url":"https://api.github.com/repos/Alfresco/Aikau/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alfresco/Aikau/merges","archive_url":"https://api.github.com/repos/Alfresco/Aikau/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alfresco/Aikau/downloads","issues_url":"https://api.github.com/repos/Alfresco/Aikau/issues{/number}","pulls_url":"https://api.github.com/repos/Alfresco/Aikau/pulls{/number}","milestones_url":"https://api.github.com/repos/Alfresco/Aikau/milestones{/number}","notifications_url":"https://api.github.com/repos/Alfresco/Aikau/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alfresco/Aikau/labels{/name}","releases_url":"https://api.github.com/repos/Alfresco/Aikau/releases{/id}","created_at":"2015-01-23T16:04:14Z","updated_at":"2015-07-27T07:19:43Z","pushed_at":"2015-08-07T12:28:02Z","git_url":"git://github.com/Alfresco/Aikau.git","ssh_url":"git@github.com:Alfresco/Aikau.git","clone_url":"https://github.com/Alfresco/Aikau.git","svn_url":"https://github.com/Alfresco/Aikau","homepage":null,"size":76087,"stargazers_count":20,"watchers_count":20,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":3,"forks":20,"open_issues":3,"watchers":20,"default_branch":"master"}},"base":{"label":"Alfresco:develop","ref":"develop","sha":"1da356d61cceaa2690f39c2ee85d00cf9c182cd6","user":{"login":"Alfresco","id":391127,"avatar_url":"https://avatars.githubusercontent.com/u/391127?v=3","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"repo":{"id":29740360,"name":"Aikau","full_name":"Alfresco/Aikau","owner":{"login":"Alfresco","id":391127,"avatar_url":"https://avatars.githubusercontent.com/u/391127?v=3","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alfresco/Aikau","description":"Aikau UI framework","fork":false,"url":"https://api.github.com/repos/Alfresco/Aikau","forks_url":"https://api.github.com/repos/Alfresco/Aikau/forks","keys_url":"https://api.github.com/repos/Alfresco/Aikau/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alfresco/Aikau/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alfresco/Aikau/teams","hooks_url":"https://api.github.com/repos/Alfresco/Aikau/hooks","issue_events_url":"https://api.github.com/repos/Alfresco/Aikau/issues/events{/number}","events_url":"https://api.github.com/repos/Alfresco/Aikau/events","assignees_url":"https://api.github.com/repos/Alfresco/Aikau/assignees{/user}","branches_url":"https://api.github.com/repos/Alfresco/Aikau/branches{/branch}","tags_url":"https://api.github.com/repos/Alfresco/Aikau/tags","blobs_url":"https://api.github.com/repos/Alfresco/Aikau/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alfresco/Aikau/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alfresco/Aikau/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alfresco/Aikau/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alfresco/Aikau/statuses/{sha}","languages_url":"https://api.github.com/repos/Alfresco/Aikau/languages","stargazers_url":"https://api.github.com/repos/Alfresco/Aikau/stargazers","contributors_url":"https://api.github.com/repos/Alfresco/Aikau/contributors","subscribers_url":"https://api.github.com/repos/Alfresco/Aikau/subscribers","subscription_url":"https://api.github.com/repos/Alfresco/Aikau/subscription","commits_url":"https://api.github.com/repos/Alfresco/Aikau/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alfresco/Aikau/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alfresco/Aikau/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alfresco/Aikau/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alfresco/Aikau/contents/{+path}","compare_url":"https://api.github.com/repos/Alfresco/Aikau/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alfresco/Aikau/merges","archive_url":"https://api.github.com/repos/Alfresco/Aikau/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alfresco/Aikau/downloads","issues_url":"https://api.github.com/repos/Alfresco/Aikau/issues{/number}","pulls_url":"https://api.github.com/repos/Alfresco/Aikau/pulls{/number}","milestones_url":"https://api.github.com/repos/Alfresco/Aikau/milestones{/number}","notifications_url":"https://api.github.com/repos/Alfresco/Aikau/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alfresco/Aikau/labels{/name}","releases_url":"https://api.github.com/repos/Alfresco/Aikau/releases{/id}","created_at":"2015-01-23T16:04:14Z","updated_at":"2015-07-27T07:19:43Z","pushed_at":"2015-08-07T12:28:02Z","git_url":"git://github.com/Alfresco/Aikau.git","ssh_url":"git@github.com:Alfresco/Aikau.git","clone_url":"https://github.com/Alfresco/Aikau.git","svn_url":"https://github.com/Alfresco/Aikau","homepage":null,"size":76087,"stargazers_count":20,"watchers_count":20,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":3,"forks":20,"open_issues":3,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Alfresco/Aikau/pulls/441"},"html":{"href":"https://github.com/Alfresco/Aikau/pull/441"},"issue":{"href":"https://api.github.com/repos/Alfresco/Aikau/issues/441"},"comments":{"href":"https://api.github.com/repos/Alfresco/Aikau/issues/441/comments"},"review_comments":{"href":"https://api.github.com/repos/Alfresco/Aikau/pulls/441/comments"},"review_comment":{"href":"https://api.github.com/repos/Alfresco/Aikau/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alfresco/Aikau/pulls/441/commits"},"statuses":{"href":"https://api.github.com/repos/Alfresco/Aikau/statuses/a38cd5662d230f7e282e1cbb22513bdc915a2b82"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"MartinDoyleUK","id":2427267,"avatar_url":"https://avatars.githubusercontent.com/u/2427267?v=3","gravatar_id":"","url":"https://api.github.com/users/MartinDoyleUK","html_url":"https://github.com/MartinDoyleUK","followers_url":"https://api.github.com/users/MartinDoyleUK/followers","following_url":"https://api.github.com/users/MartinDoyleUK/following{/other_user}","gists_url":"https://api.github.com/users/MartinDoyleUK/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinDoyleUK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinDoyleUK/subscriptions","organizations_url":"https://api.github.com/users/MartinDoyleUK/orgs","repos_url":"https://api.github.com/users/MartinDoyleUK/repos","events_url":"https://api.github.com/users/MartinDoyleUK/events{/privacy}","received_events_url":"https://api.github.com/users/MartinDoyleUK/received_events","type":"User","site_admin":false},"comments":0,"review_comments":1,"commits":2,"additions":369,"deletions":14,"changed_files":9}}