{"action":"created","comment":{"url":"https://api.github.com/repos/Alfresco/Aikau/pulls/comments/42349162","id":42349162,"diff_hunk":"@@ -188,6 +263,40 @@ define([\"dojo/_base/declare\",\n       lastThumbnailModificationProperty: \"jsNode.properties.cm:lastThumbnailModification\",\n \n       /**\n+       * This indicates whether or not the aspect ratio of the thumbnail will be retained. This means that\n+       * for non-square images there will be white-space between the image and its frame. If this is configured\n+       * to be false then portrait thumbnails will be clipped at the bottom and landscape thumbnails will be \n+       * vertically stretched. However, if no [dimensions]{@link module:alfresco/renderers/Thumbnail#dimensions}\n+       * are provided then the aspect ration will always be maintained.\n+       *\n+       * @instance\n+       * @type {boolean}\n+       * @default\n+       * @since 1.0.40\n+       */\n+      maintainAspectRatio: true,","path":"aikau/src/main/resources/alfresco/renderers/Thumbnail.js","position":134,"original_position":134,"commit_id":"312525010722630c97ba0a3376d61bc72d75bf95","original_commit_id":"312525010722630c97ba0a3376d61bc72d75bf95","user":{"login":"MartinDoyleUK","id":2427267,"avatar_url":"https://avatars.githubusercontent.com/u/2427267?v=3","gravatar_id":"","url":"https://api.github.com/users/MartinDoyleUK","html_url":"https://github.com/MartinDoyleUK","followers_url":"https://api.github.com/users/MartinDoyleUK/followers","following_url":"https://api.github.com/users/MartinDoyleUK/following{/other_user}","gists_url":"https://api.github.com/users/MartinDoyleUK/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinDoyleUK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinDoyleUK/subscriptions","organizations_url":"https://api.github.com/users/MartinDoyleUK/orgs","repos_url":"https://api.github.com/users/MartinDoyleUK/repos","events_url":"https://api.github.com/users/MartinDoyleUK/events{/privacy}","received_events_url":"https://api.github.com/users/MartinDoyleUK/received_events","type":"User","site_admin":false},"body":"Got some problems with the use of \"aspect ratio\" in general. Changing the aspect ratio of an image certainly could be applied to cropping it, but it more normally refers to stretching it. I'd prefer to see terms such as fill/crop and fit/letterbox, which more clearly describe what's happening with the image, which is not actually changing, only the window through which it's being viewed. Realise this is subjective, but don't want to say nothing when it makes me feel so uncomfortable as-is.","created_at":"2015-10-19T09:01:14Z","updated_at":"2015-10-19T09:01:14Z","html_url":"https://github.com/Alfresco/Aikau/pull/616#discussion_r42349162","pull_request_url":"https://api.github.com/repos/Alfresco/Aikau/pulls/616","_links":{"self":{"href":"https://api.github.com/repos/Alfresco/Aikau/pulls/comments/42349162"},"html":{"href":"https://github.com/Alfresco/Aikau/pull/616#discussion_r42349162"},"pull_request":{"href":"https://api.github.com/repos/Alfresco/Aikau/pulls/616"}}},"pull_request":{"url":"https://api.github.com/repos/Alfresco/Aikau/pulls/616","id":47931845,"html_url":"https://github.com/Alfresco/Aikau/pull/616","diff_url":"https://github.com/Alfresco/Aikau/pull/616.diff","patch_url":"https://github.com/Alfresco/Aikau/pull/616.patch","issue_url":"https://api.github.com/repos/Alfresco/Aikau/issues/616","number":616,"state":"open","locked":false,"title":"AKU-631: Update Thumbnails for aspect ratio, sizing and cropping","user":{"login":"draperd","id":1084047,"avatar_url":"https://avatars.githubusercontent.com/u/1084047?v=3","gravatar_id":"","url":"https://api.github.com/users/draperd","html_url":"https://github.com/draperd","followers_url":"https://api.github.com/users/draperd/followers","following_url":"https://api.github.com/users/draperd/following{/other_user}","gists_url":"https://api.github.com/users/draperd/gists{/gist_id}","starred_url":"https://api.github.com/users/draperd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/draperd/subscriptions","organizations_url":"https://api.github.com/users/draperd/orgs","repos_url":"https://api.github.com/users/draperd/repos","events_url":"https://api.github.com/users/draperd/events{/privacy}","received_events_url":"https://api.github.com/users/draperd/received_events","type":"User","site_admin":false},"body":"This PR addresses https://issues.alfresco.com/jira/browse/AKU-631 to work through the various thumbnail widgets and generally improve their handling of sizing, cropping and aspect ratio. I've also added in configurable support for styling and pushed default styling in LESS variables. \r\n\r\nI've intentionally removed the DND highlighting and link overlays (because these are not used in production yet and we know that there are backlog items on the horizon to address these). ","created_at":"2015-10-16T16:30:39Z","updated_at":"2015-10-19T09:01:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6827ff153c49bb15b6fb0e52ae4f02bbb2a05a83","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Alfresco/Aikau/pulls/616/commits","review_comments_url":"https://api.github.com/repos/Alfresco/Aikau/pulls/616/comments","review_comment_url":"https://api.github.com/repos/Alfresco/Aikau/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alfresco/Aikau/issues/616/comments","statuses_url":"https://api.github.com/repos/Alfresco/Aikau/statuses/312525010722630c97ba0a3376d61bc72d75bf95","head":{"label":"Alfresco:feature/AKU-631_ThumbnailAspectRatio","ref":"feature/AKU-631_ThumbnailAspectRatio","sha":"312525010722630c97ba0a3376d61bc72d75bf95","user":{"login":"Alfresco","id":391127,"avatar_url":"https://avatars.githubusercontent.com/u/391127?v=3","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"repo":{"id":29740360,"name":"Aikau","full_name":"Alfresco/Aikau","owner":{"login":"Alfresco","id":391127,"avatar_url":"https://avatars.githubusercontent.com/u/391127?v=3","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alfresco/Aikau","description":"Aikau UI framework","fork":false,"url":"https://api.github.com/repos/Alfresco/Aikau","forks_url":"https://api.github.com/repos/Alfresco/Aikau/forks","keys_url":"https://api.github.com/repos/Alfresco/Aikau/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alfresco/Aikau/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alfresco/Aikau/teams","hooks_url":"https://api.github.com/repos/Alfresco/Aikau/hooks","issue_events_url":"https://api.github.com/repos/Alfresco/Aikau/issues/events{/number}","events_url":"https://api.github.com/repos/Alfresco/Aikau/events","assignees_url":"https://api.github.com/repos/Alfresco/Aikau/assignees{/user}","branches_url":"https://api.github.com/repos/Alfresco/Aikau/branches{/branch}","tags_url":"https://api.github.com/repos/Alfresco/Aikau/tags","blobs_url":"https://api.github.com/repos/Alfresco/Aikau/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alfresco/Aikau/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alfresco/Aikau/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alfresco/Aikau/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alfresco/Aikau/statuses/{sha}","languages_url":"https://api.github.com/repos/Alfresco/Aikau/languages","stargazers_url":"https://api.github.com/repos/Alfresco/Aikau/stargazers","contributors_url":"https://api.github.com/repos/Alfresco/Aikau/contributors","subscribers_url":"https://api.github.com/repos/Alfresco/Aikau/subscribers","subscription_url":"https://api.github.com/repos/Alfresco/Aikau/subscription","commits_url":"https://api.github.com/repos/Alfresco/Aikau/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alfresco/Aikau/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alfresco/Aikau/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alfresco/Aikau/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alfresco/Aikau/contents/{+path}","compare_url":"https://api.github.com/repos/Alfresco/Aikau/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alfresco/Aikau/merges","archive_url":"https://api.github.com/repos/Alfresco/Aikau/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alfresco/Aikau/downloads","issues_url":"https://api.github.com/repos/Alfresco/Aikau/issues{/number}","pulls_url":"https://api.github.com/repos/Alfresco/Aikau/pulls{/number}","milestones_url":"https://api.github.com/repos/Alfresco/Aikau/milestones{/number}","notifications_url":"https://api.github.com/repos/Alfresco/Aikau/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alfresco/Aikau/labels{/name}","releases_url":"https://api.github.com/repos/Alfresco/Aikau/releases{/id}","created_at":"2015-01-23T16:04:14Z","updated_at":"2015-10-13T13:52:50Z","pushed_at":"2015-10-17T18:28:25Z","git_url":"git://github.com/Alfresco/Aikau.git","ssh_url":"git@github.com:Alfresco/Aikau.git","clone_url":"https://github.com/Alfresco/Aikau.git","svn_url":"https://github.com/Alfresco/Aikau","homepage":null,"size":90099,"stargazers_count":25,"watchers_count":25,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":5,"forks":25,"open_issues":5,"watchers":25,"default_branch":"master"}},"base":{"label":"Alfresco:develop","ref":"develop","sha":"dfda6deba0024ab90568735775bc8e071afd6f1d","user":{"login":"Alfresco","id":391127,"avatar_url":"https://avatars.githubusercontent.com/u/391127?v=3","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"repo":{"id":29740360,"name":"Aikau","full_name":"Alfresco/Aikau","owner":{"login":"Alfresco","id":391127,"avatar_url":"https://avatars.githubusercontent.com/u/391127?v=3","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alfresco/Aikau","description":"Aikau UI framework","fork":false,"url":"https://api.github.com/repos/Alfresco/Aikau","forks_url":"https://api.github.com/repos/Alfresco/Aikau/forks","keys_url":"https://api.github.com/repos/Alfresco/Aikau/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alfresco/Aikau/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alfresco/Aikau/teams","hooks_url":"https://api.github.com/repos/Alfresco/Aikau/hooks","issue_events_url":"https://api.github.com/repos/Alfresco/Aikau/issues/events{/number}","events_url":"https://api.github.com/repos/Alfresco/Aikau/events","assignees_url":"https://api.github.com/repos/Alfresco/Aikau/assignees{/user}","branches_url":"https://api.github.com/repos/Alfresco/Aikau/branches{/branch}","tags_url":"https://api.github.com/repos/Alfresco/Aikau/tags","blobs_url":"https://api.github.com/repos/Alfresco/Aikau/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alfresco/Aikau/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alfresco/Aikau/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alfresco/Aikau/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alfresco/Aikau/statuses/{sha}","languages_url":"https://api.github.com/repos/Alfresco/Aikau/languages","stargazers_url":"https://api.github.com/repos/Alfresco/Aikau/stargazers","contributors_url":"https://api.github.com/repos/Alfresco/Aikau/contributors","subscribers_url":"https://api.github.com/repos/Alfresco/Aikau/subscribers","subscription_url":"https://api.github.com/repos/Alfresco/Aikau/subscription","commits_url":"https://api.github.com/repos/Alfresco/Aikau/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alfresco/Aikau/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alfresco/Aikau/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alfresco/Aikau/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alfresco/Aikau/contents/{+path}","compare_url":"https://api.github.com/repos/Alfresco/Aikau/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alfresco/Aikau/merges","archive_url":"https://api.github.com/repos/Alfresco/Aikau/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alfresco/Aikau/downloads","issues_url":"https://api.github.com/repos/Alfresco/Aikau/issues{/number}","pulls_url":"https://api.github.com/repos/Alfresco/Aikau/pulls{/number}","milestones_url":"https://api.github.com/repos/Alfresco/Aikau/milestones{/number}","notifications_url":"https://api.github.com/repos/Alfresco/Aikau/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alfresco/Aikau/labels{/name}","releases_url":"https://api.github.com/repos/Alfresco/Aikau/releases{/id}","created_at":"2015-01-23T16:04:14Z","updated_at":"2015-10-13T13:52:50Z","pushed_at":"2015-10-17T18:28:25Z","git_url":"git://github.com/Alfresco/Aikau.git","ssh_url":"git@github.com:Alfresco/Aikau.git","clone_url":"https://github.com/Alfresco/Aikau.git","svn_url":"https://github.com/Alfresco/Aikau","homepage":null,"size":90099,"stargazers_count":25,"watchers_count":25,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":5,"forks":25,"open_issues":5,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Alfresco/Aikau/pulls/616"},"html":{"href":"https://github.com/Alfresco/Aikau/pull/616"},"issue":{"href":"https://api.github.com/repos/Alfresco/Aikau/issues/616"},"comments":{"href":"https://api.github.com/repos/Alfresco/Aikau/issues/616/comments"},"review_comments":{"href":"https://api.github.com/repos/Alfresco/Aikau/pulls/616/comments"},"review_comment":{"href":"https://api.github.com/repos/Alfresco/Aikau/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alfresco/Aikau/pulls/616/commits"},"statuses":{"href":"https://api.github.com/repos/Alfresco/Aikau/statuses/312525010722630c97ba0a3376d61bc72d75bf95"}}}}