{"action":"created","issue":{"url":"https://api.github.com/repos/n3-charts/line-chart/issues/286","labels_url":"https://api.github.com/repos/n3-charts/line-chart/issues/286/labels{/name}","comments_url":"https://api.github.com/repos/n3-charts/line-chart/issues/286/comments","events_url":"https://api.github.com/repos/n3-charts/line-chart/issues/286/events","html_url":"https://github.com/n3-charts/line-chart/pull/286","id":98123275,"number":286,"title":"Support date extrema","user":{"login":"MattiSG","id":222463,"avatar_url":"https://avatars.githubusercontent.com/u/222463?v=3","gravatar_id":"","url":"https://api.github.com/users/MattiSG","html_url":"https://github.com/MattiSG","followers_url":"https://api.github.com/users/MattiSG/followers","following_url":"https://api.github.com/users/MattiSG/following{/other_user}","gists_url":"https://api.github.com/users/MattiSG/gists{/gist_id}","starred_url":"https://api.github.com/users/MattiSG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattiSG/subscriptions","organizations_url":"https://api.github.com/users/MattiSG/orgs","repos_url":"https://api.github.com/users/MattiSG/repos","events_url":"https://api.github.com/users/MattiSG/events{/privacy}","received_events_url":"https://api.github.com/users/MattiSG/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-07-30T09:31:10Z","updated_at":"2015-07-30T10:00:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/n3-charts/line-chart/pulls/286","html_url":"https://github.com/n3-charts/line-chart/pull/286","diff_url":"https://github.com/n3-charts/line-chart/pull/286.diff","patch_url":"https://github.com/n3-charts/line-chart/pull/286.patch"},"body":"The current extrema validity checking code allows only numbers in, preventing a time series chart to provide extrema.\r\n\r\nThis pull request brings support for date extrema, with the same level of validity check as for numbers."},"comment":{"url":"https://api.github.com/repos/n3-charts/line-chart/issues/comments/126257338","html_url":"https://github.com/n3-charts/line-chart/pull/286#issuecomment-126257338","issue_url":"https://api.github.com/repos/n3-charts/line-chart/issues/286","id":126257338,"user":{"login":"MattiSG","id":222463,"avatar_url":"https://avatars.githubusercontent.com/u/222463?v=3","gravatar_id":"","url":"https://api.github.com/users/MattiSG","html_url":"https://github.com/MattiSG","followers_url":"https://api.github.com/users/MattiSG/followers","following_url":"https://api.github.com/users/MattiSG/following{/other_user}","gists_url":"https://api.github.com/users/MattiSG/gists{/gist_id}","starred_url":"https://api.github.com/users/MattiSG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattiSG/subscriptions","organizations_url":"https://api.github.com/users/MattiSG/orgs","repos_url":"https://api.github.com/users/MattiSG/repos","events_url":"https://api.github.com/users/MattiSG/events{/privacy}","received_events_url":"https://api.github.com/users/MattiSG/received_events","type":"User","site_admin":false},"created_at":"2015-07-30T10:00:21Z","updated_at":"2015-07-30T10:00:21Z","body":"> Could you maybe sqash your commits into a single one?\r\n\r\nSure, if you really want me to :wink: But losing history is [against](http://www.conifersystems.com/2008/11/05/the-benefits-of-small-commits/) [SCM](http://svn.apache.org/repos/asf/subversion/trunk/doc/user/svn-best-practices.html) [best practices](http://www.barneyb.com/barneyblog/2006/01/27/atomic-commits-to-version-control/).\r\n\r\nAs the reference you sent mentions:\r\n\r\n> This step is not always necessary, but is required when your commit history is full of small, unimportant commits (such as \"Fix pep8\", \"Add tests\", or \"ARUURUGHSFDFSDFSDGLJKLJ:GK\").\r\n\r\n…which is not the case here, where you have atomic, revertible, bisectable commits  :)\r\n\r\nLet me know if this is still unacceptable for you."}}