{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4864","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4864/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4864/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4864/events","html_url":"https://github.com/scikit-learn/scikit-learn/issues/4864","id":88493233,"number":4864,"title":"Document and adapt isclose() usage","user":{"login":"Gerenuk","id":3168512,"avatar_url":"https://avatars.githubusercontent.com/u/3168512?v=3","gravatar_id":"","url":"https://api.github.com/users/Gerenuk","html_url":"https://github.com/Gerenuk","followers_url":"https://api.github.com/users/Gerenuk/followers","following_url":"https://api.github.com/users/Gerenuk/following{/other_user}","gists_url":"https://api.github.com/users/Gerenuk/gists{/gist_id}","starred_url":"https://api.github.com/users/Gerenuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gerenuk/subscriptions","organizations_url":"https://api.github.com/users/Gerenuk/orgs","repos_url":"https://api.github.com/users/Gerenuk/repos","events_url":"https://api.github.com/users/Gerenuk/events{/privacy}","received_events_url":"https://api.github.com/users/Gerenuk/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels/Documentation","name":"Documentation","color":"0b02e1"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-06-15T17:43:29Z","updated_at":"2015-09-14T13:47:09Z","closed_at":null,"body":"`sklearn.metrics` introduces `isclose()` in https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/metrics/ranking.py which can leave the unaware data practitioner with hours of debugging.\r\n\r\nIn very unbalanced classification, probabilities/scores can be very small and yet meaningful. This however will cause unexpected missing precision_recall points due to `isclose` treating values within 10e-6 as equal.\r\n\r\nI'd suggest to place a warning about `isclose` in the documentation and also replace the absolute epsilon by a relative closeness comparison in order to avoid the problems with small probabilities in unbalanced classification."},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/140080573","html_url":"https://github.com/scikit-learn/scikit-learn/issues/4864#issuecomment-140080573","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4864","id":140080573,"user":{"login":"arjoly","id":1274722,"avatar_url":"https://avatars.githubusercontent.com/u/1274722?v=3","gravatar_id":"","url":"https://api.github.com/users/arjoly","html_url":"https://github.com/arjoly","followers_url":"https://api.github.com/users/arjoly/followers","following_url":"https://api.github.com/users/arjoly/following{/other_user}","gists_url":"https://api.github.com/users/arjoly/gists{/gist_id}","starred_url":"https://api.github.com/users/arjoly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arjoly/subscriptions","organizations_url":"https://api.github.com/users/arjoly/orgs","repos_url":"https://api.github.com/users/arjoly/repos","events_url":"https://api.github.com/users/arjoly/events{/privacy}","received_events_url":"https://api.github.com/users/arjoly/received_events","type":"User","site_admin":false},"created_at":"2015-09-14T13:47:09Z","updated_at":"2015-09-14T13:47:09Z","body":"I would be in favour of removing the isclose. Other opinion ? (@jnothman)"}}