{"action":"created","comment":{"url":"https://api.github.com/repos/jimon/premake-ninja/pulls/comments/41708348","id":41708348,"diff_hunk":"@@ -51,21 +51,35 @@ function ninja.generateSolution(sln)\n \n \tp.w(\"# build projects\")\n \tlocal cfgs = {} -- key is configuration name, value is string of outputs names\n+\tlocal key = \"\"\n \tlocal cfg_first = nil\n+\tlocal cfg_first_lib = nil\n+\n \tfor prj in solution.eachproject(sln) do\n \t\tfor cfg in project.eachconfig(prj) do\n \n+\t\t\tkey = prj.name .. \"_\" .. cfg.buildcfg .. \"_\" .. cfg.platform\n+\t\t\t\n \t\t\t-- fill list of output files\n-\t\t\tif not cfgs[cfg.name] then cfgs[cfg.name] = \"\" end\n-\t\t\tcfgs[cfg.name] = cfgs[cfg.name] .. p.esc(ninja.outputFilename(cfg)) .. \" \"\n+\t\t\tif not cfgs[key] then cfgs[key] = \"\" end\n+\t\t\tcfgs[key] = p.esc(ninja.outputFilename(cfg)) .. \" \"\n \n \t\t\t-- set first configuration name\n-\t\t\tif cfg_first == nil then cfg_first = cfg.name end\n+\t\t\tif cfg_first == nil then\n+\t\t\t\tif cfg.kind == p.CONSOLEAPP or cfg.kind == p.WINDOWEDAPP then\n+\t\t\t\t\tcfg_first = key\n+\t\t\t\telse\n+\t\t\t\t\tcfg_first_lib = key","path":"ninja.lua","position":25,"original_position":25,"commit_id":"cf382eeda7fac412abacc6c3b9eab87b2f7c9525","original_commit_id":"cf382eeda7fac412abacc6c3b9eab87b2f7c9525","user":{"login":"rvc86","id":1227767,"avatar_url":"https://avatars.githubusercontent.com/u/1227767?v=3","gravatar_id":"","url":"https://api.github.com/users/rvc86","html_url":"https://github.com/rvc86","followers_url":"https://api.github.com/users/rvc86/followers","following_url":"https://api.github.com/users/rvc86/following{/other_user}","gists_url":"https://api.github.com/users/rvc86/gists{/gist_id}","starred_url":"https://api.github.com/users/rvc86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvc86/subscriptions","organizations_url":"https://api.github.com/users/rvc86/orgs","repos_url":"https://api.github.com/users/rvc86/repos","events_url":"https://api.github.com/users/rvc86/events{/privacy}","received_events_url":"https://api.github.com/users/rvc86/received_events","type":"User","site_admin":false},"body":"Thanks","created_at":"2015-10-11T10:11:32Z","updated_at":"2015-10-11T10:11:32Z","html_url":"https://github.com/jimon/premake-ninja/pull/6#discussion_r41708348","pull_request_url":"https://api.github.com/repos/jimon/premake-ninja/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/jimon/premake-ninja/pulls/comments/41708348"},"html":{"href":"https://github.com/jimon/premake-ninja/pull/6#discussion_r41708348"},"pull_request":{"href":"https://api.github.com/repos/jimon/premake-ninja/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/jimon/premake-ninja/pulls/6","id":47301906,"html_url":"https://github.com/jimon/premake-ninja/pull/6","diff_url":"https://github.com/jimon/premake-ninja/pull/6.diff","patch_url":"https://github.com/jimon/premake-ninja/pull/6.patch","issue_url":"https://api.github.com/repos/jimon/premake-ninja/issues/6","number":6,"state":"open","locked":false,"title":"fixes in linux and prefer ConsoleApp or WindowedApp as default project to build.","user":{"login":"rvc86","id":1227767,"avatar_url":"https://avatars.githubusercontent.com/u/1227767?v=3","gravatar_id":"","url":"https://api.github.com/users/rvc86","html_url":"https://github.com/rvc86","followers_url":"https://api.github.com/users/rvc86/followers","following_url":"https://api.github.com/users/rvc86/following{/other_user}","gists_url":"https://api.github.com/users/rvc86/gists{/gist_id}","starred_url":"https://api.github.com/users/rvc86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvc86/subscriptions","organizations_url":"https://api.github.com/users/rvc86/orgs","repos_url":"https://api.github.com/users/rvc86/repos","events_url":"https://api.github.com/users/rvc86/events{/privacy}","received_events_url":"https://api.github.com/users/rvc86/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-09T18:04:57Z","updated_at":"2015-10-11T10:11:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0da8574cf67c48c048dbc71798525208415b969","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jimon/premake-ninja/pulls/6/commits","review_comments_url":"https://api.github.com/repos/jimon/premake-ninja/pulls/6/comments","review_comment_url":"https://api.github.com/repos/jimon/premake-ninja/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jimon/premake-ninja/issues/6/comments","statuses_url":"https://api.github.com/repos/jimon/premake-ninja/statuses/cf382eeda7fac412abacc6c3b9eab87b2f7c9525","head":{"label":"rvc86:master","ref":"master","sha":"cf382eeda7fac412abacc6c3b9eab87b2f7c9525","user":{"login":"rvc86","id":1227767,"avatar_url":"https://avatars.githubusercontent.com/u/1227767?v=3","gravatar_id":"","url":"https://api.github.com/users/rvc86","html_url":"https://github.com/rvc86","followers_url":"https://api.github.com/users/rvc86/followers","following_url":"https://api.github.com/users/rvc86/following{/other_user}","gists_url":"https://api.github.com/users/rvc86/gists{/gist_id}","starred_url":"https://api.github.com/users/rvc86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvc86/subscriptions","organizations_url":"https://api.github.com/users/rvc86/orgs","repos_url":"https://api.github.com/users/rvc86/repos","events_url":"https://api.github.com/users/rvc86/events{/privacy}","received_events_url":"https://api.github.com/users/rvc86/received_events","type":"User","site_admin":false},"repo":{"id":43896992,"name":"premake-ninja","full_name":"rvc86/premake-ninja","owner":{"login":"rvc86","id":1227767,"avatar_url":"https://avatars.githubusercontent.com/u/1227767?v=3","gravatar_id":"","url":"https://api.github.com/users/rvc86","html_url":"https://github.com/rvc86","followers_url":"https://api.github.com/users/rvc86/followers","following_url":"https://api.github.com/users/rvc86/following{/other_user}","gists_url":"https://api.github.com/users/rvc86/gists{/gist_id}","starred_url":"https://api.github.com/users/rvc86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvc86/subscriptions","organizations_url":"https://api.github.com/users/rvc86/orgs","repos_url":"https://api.github.com/users/rvc86/repos","events_url":"https://api.github.com/users/rvc86/events{/privacy}","received_events_url":"https://api.github.com/users/rvc86/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rvc86/premake-ninja","description":"Premake extension to support Ninja","fork":true,"url":"https://api.github.com/repos/rvc86/premake-ninja","forks_url":"https://api.github.com/repos/rvc86/premake-ninja/forks","keys_url":"https://api.github.com/repos/rvc86/premake-ninja/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rvc86/premake-ninja/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rvc86/premake-ninja/teams","hooks_url":"https://api.github.com/repos/rvc86/premake-ninja/hooks","issue_events_url":"https://api.github.com/repos/rvc86/premake-ninja/issues/events{/number}","events_url":"https://api.github.com/repos/rvc86/premake-ninja/events","assignees_url":"https://api.github.com/repos/rvc86/premake-ninja/assignees{/user}","branches_url":"https://api.github.com/repos/rvc86/premake-ninja/branches{/branch}","tags_url":"https://api.github.com/repos/rvc86/premake-ninja/tags","blobs_url":"https://api.github.com/repos/rvc86/premake-ninja/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rvc86/premake-ninja/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rvc86/premake-ninja/git/refs{/sha}","trees_url":"https://api.github.com/repos/rvc86/premake-ninja/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rvc86/premake-ninja/statuses/{sha}","languages_url":"https://api.github.com/repos/rvc86/premake-ninja/languages","stargazers_url":"https://api.github.com/repos/rvc86/premake-ninja/stargazers","contributors_url":"https://api.github.com/repos/rvc86/premake-ninja/contributors","subscribers_url":"https://api.github.com/repos/rvc86/premake-ninja/subscribers","subscription_url":"https://api.github.com/repos/rvc86/premake-ninja/subscription","commits_url":"https://api.github.com/repos/rvc86/premake-ninja/commits{/sha}","git_commits_url":"https://api.github.com/repos/rvc86/premake-ninja/git/commits{/sha}","comments_url":"https://api.github.com/repos/rvc86/premake-ninja/comments{/number}","issue_comment_url":"https://api.github.com/repos/rvc86/premake-ninja/issues/comments{/number}","contents_url":"https://api.github.com/repos/rvc86/premake-ninja/contents/{+path}","compare_url":"https://api.github.com/repos/rvc86/premake-ninja/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rvc86/premake-ninja/merges","archive_url":"https://api.github.com/repos/rvc86/premake-ninja/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rvc86/premake-ninja/downloads","issues_url":"https://api.github.com/repos/rvc86/premake-ninja/issues{/number}","pulls_url":"https://api.github.com/repos/rvc86/premake-ninja/pulls{/number}","milestones_url":"https://api.github.com/repos/rvc86/premake-ninja/milestones{/number}","notifications_url":"https://api.github.com/repos/rvc86/premake-ninja/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rvc86/premake-ninja/labels{/name}","releases_url":"https://api.github.com/repos/rvc86/premake-ninja/releases{/id}","created_at":"2015-10-08T15:06:53Z","updated_at":"2015-10-08T15:06:54Z","pushed_at":"2015-10-09T17:56:27Z","git_url":"git://github.com/rvc86/premake-ninja.git","ssh_url":"git@github.com:rvc86/premake-ninja.git","clone_url":"https://github.com/rvc86/premake-ninja.git","svn_url":"https://github.com/rvc86/premake-ninja","homepage":null,"size":125,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jimon:master","ref":"master","sha":"d455939eb732ce42aa20dcc93290852e3fe6ad3a","user":{"login":"jimon","id":1333661,"avatar_url":"https://avatars.githubusercontent.com/u/1333661?v=3","gravatar_id":"","url":"https://api.github.com/users/jimon","html_url":"https://github.com/jimon","followers_url":"https://api.github.com/users/jimon/followers","following_url":"https://api.github.com/users/jimon/following{/other_user}","gists_url":"https://api.github.com/users/jimon/gists{/gist_id}","starred_url":"https://api.github.com/users/jimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimon/subscriptions","organizations_url":"https://api.github.com/users/jimon/orgs","repos_url":"https://api.github.com/users/jimon/repos","events_url":"https://api.github.com/users/jimon/events{/privacy}","received_events_url":"https://api.github.com/users/jimon/received_events","type":"User","site_admin":false},"repo":{"id":38569092,"name":"premake-ninja","full_name":"jimon/premake-ninja","owner":{"login":"jimon","id":1333661,"avatar_url":"https://avatars.githubusercontent.com/u/1333661?v=3","gravatar_id":"","url":"https://api.github.com/users/jimon","html_url":"https://github.com/jimon","followers_url":"https://api.github.com/users/jimon/followers","following_url":"https://api.github.com/users/jimon/following{/other_user}","gists_url":"https://api.github.com/users/jimon/gists{/gist_id}","starred_url":"https://api.github.com/users/jimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimon/subscriptions","organizations_url":"https://api.github.com/users/jimon/orgs","repos_url":"https://api.github.com/users/jimon/repos","events_url":"https://api.github.com/users/jimon/events{/privacy}","received_events_url":"https://api.github.com/users/jimon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jimon/premake-ninja","description":"Premake extension to support Ninja","fork":false,"url":"https://api.github.com/repos/jimon/premake-ninja","forks_url":"https://api.github.com/repos/jimon/premake-ninja/forks","keys_url":"https://api.github.com/repos/jimon/premake-ninja/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimon/premake-ninja/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimon/premake-ninja/teams","hooks_url":"https://api.github.com/repos/jimon/premake-ninja/hooks","issue_events_url":"https://api.github.com/repos/jimon/premake-ninja/issues/events{/number}","events_url":"https://api.github.com/repos/jimon/premake-ninja/events","assignees_url":"https://api.github.com/repos/jimon/premake-ninja/assignees{/user}","branches_url":"https://api.github.com/repos/jimon/premake-ninja/branches{/branch}","tags_url":"https://api.github.com/repos/jimon/premake-ninja/tags","blobs_url":"https://api.github.com/repos/jimon/premake-ninja/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimon/premake-ninja/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimon/premake-ninja/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimon/premake-ninja/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimon/premake-ninja/statuses/{sha}","languages_url":"https://api.github.com/repos/jimon/premake-ninja/languages","stargazers_url":"https://api.github.com/repos/jimon/premake-ninja/stargazers","contributors_url":"https://api.github.com/repos/jimon/premake-ninja/contributors","subscribers_url":"https://api.github.com/repos/jimon/premake-ninja/subscribers","subscription_url":"https://api.github.com/repos/jimon/premake-ninja/subscription","commits_url":"https://api.github.com/repos/jimon/premake-ninja/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimon/premake-ninja/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimon/premake-ninja/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimon/premake-ninja/issues/comments{/number}","contents_url":"https://api.github.com/repos/jimon/premake-ninja/contents/{+path}","compare_url":"https://api.github.com/repos/jimon/premake-ninja/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimon/premake-ninja/merges","archive_url":"https://api.github.com/repos/jimon/premake-ninja/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimon/premake-ninja/downloads","issues_url":"https://api.github.com/repos/jimon/premake-ninja/issues{/number}","pulls_url":"https://api.github.com/repos/jimon/premake-ninja/pulls{/number}","milestones_url":"https://api.github.com/repos/jimon/premake-ninja/milestones{/number}","notifications_url":"https://api.github.com/repos/jimon/premake-ninja/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimon/premake-ninja/labels{/name}","releases_url":"https://api.github.com/repos/jimon/premake-ninja/releases{/id}","created_at":"2015-07-05T12:56:31Z","updated_at":"2015-09-30T20:07:34Z","pushed_at":"2015-10-09T18:04:58Z","git_url":"git://github.com/jimon/premake-ninja.git","ssh_url":"git@github.com:jimon/premake-ninja.git","clone_url":"https://github.com/jimon/premake-ninja.git","svn_url":"https://github.com/jimon/premake-ninja","homepage":null,"size":249,"stargazers_count":12,"watchers_count":12,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jimon/premake-ninja/pulls/6"},"html":{"href":"https://github.com/jimon/premake-ninja/pull/6"},"issue":{"href":"https://api.github.com/repos/jimon/premake-ninja/issues/6"},"comments":{"href":"https://api.github.com/repos/jimon/premake-ninja/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/jimon/premake-ninja/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/jimon/premake-ninja/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jimon/premake-ninja/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/jimon/premake-ninja/statuses/cf382eeda7fac412abacc6c3b9eab87b2f7c9525"}}}}