{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/struktured/oml/pulls/1","id":32656852,"html_url":"https://github.com/struktured/oml/pull/1","diff_url":"https://github.com/struktured/oml/pull/1.diff","patch_url":"https://github.com/struktured/oml/pull/1.patch","issue_url":"https://api.github.com/repos/struktured/oml/issues/1","number":1,"state":"open","locked":false,"title":"polymorphic sampling module","user":{"login":"struktured","id":5060002,"avatar_url":"https://avatars.githubusercontent.com/u/5060002?v=3","gravatar_id":"","url":"https://api.github.com/users/struktured","html_url":"https://github.com/struktured","followers_url":"https://api.github.com/users/struktured/followers","following_url":"https://api.github.com/users/struktured/following{/other_user}","gists_url":"https://api.github.com/users/struktured/gists{/gist_id}","starred_url":"https://api.github.com/users/struktured/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/struktured/subscriptions","organizations_url":"https://api.github.com/users/struktured/orgs","repos_url":"https://api.github.com/users/struktured/repos","events_url":"https://api.github.com/users/struktured/events{/privacy}","received_events_url":"https://api.github.com/users/struktured/received_events","type":"User","site_admin":false},"body":"I didn't see value in a functor for this solution, at least not yet.\r\n\r\nHow do you think the inputs should be passed to these functions? I went with two arrays that are validated to be the same length, but perhaps one array of ```'a * float``` would be safer. \r\n\r\nAnother possibility is to take in a function like ```'a -> float``` but since it would have to be normalized for most algorithms you lose the ability to validate the domain before returning a sampler. \r\n\r\nAlso, I'd like to write tests for these functions if the harness is ready. \r\n","created_at":"2015-04-06T00:16:00Z","updated_at":"2015-04-06T00:16:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/struktured/oml/pulls/1/commits","review_comments_url":"https://api.github.com/repos/struktured/oml/pulls/1/comments","review_comment_url":"https://api.github.com/repos/struktured/oml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/struktured/oml/issues/1/comments","statuses_url":"https://api.github.com/repos/struktured/oml/statuses/3d971dc114573991cc0d34f7d100d61f95f1663a","head":{"label":"struktured:poly-sampling","ref":"poly-sampling","sha":"3d971dc114573991cc0d34f7d100d61f95f1663a","user":{"login":"struktured","id":5060002,"avatar_url":"https://avatars.githubusercontent.com/u/5060002?v=3","gravatar_id":"","url":"https://api.github.com/users/struktured","html_url":"https://github.com/struktured","followers_url":"https://api.github.com/users/struktured/followers","following_url":"https://api.github.com/users/struktured/following{/other_user}","gists_url":"https://api.github.com/users/struktured/gists{/gist_id}","starred_url":"https://api.github.com/users/struktured/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/struktured/subscriptions","organizations_url":"https://api.github.com/users/struktured/orgs","repos_url":"https://api.github.com/users/struktured/repos","events_url":"https://api.github.com/users/struktured/events{/privacy}","received_events_url":"https://api.github.com/users/struktured/received_events","type":"User","site_admin":false},"repo":{"id":32682549,"name":"oml","full_name":"struktured/oml","owner":{"login":"struktured","id":5060002,"avatar_url":"https://avatars.githubusercontent.com/u/5060002?v=3","gravatar_id":"","url":"https://api.github.com/users/struktured","html_url":"https://github.com/struktured","followers_url":"https://api.github.com/users/struktured/followers","following_url":"https://api.github.com/users/struktured/following{/other_user}","gists_url":"https://api.github.com/users/struktured/gists{/gist_id}","starred_url":"https://api.github.com/users/struktured/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/struktured/subscriptions","organizations_url":"https://api.github.com/users/struktured/orgs","repos_url":"https://api.github.com/users/struktured/repos","events_url":"https://api.github.com/users/struktured/events{/privacy}","received_events_url":"https://api.github.com/users/struktured/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/struktured/oml","description":"OCaml Math Library","fork":true,"url":"https://api.github.com/repos/struktured/oml","forks_url":"https://api.github.com/repos/struktured/oml/forks","keys_url":"https://api.github.com/repos/struktured/oml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/struktured/oml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/struktured/oml/teams","hooks_url":"https://api.github.com/repos/struktured/oml/hooks","issue_events_url":"https://api.github.com/repos/struktured/oml/issues/events{/number}","events_url":"https://api.github.com/repos/struktured/oml/events","assignees_url":"https://api.github.com/repos/struktured/oml/assignees{/user}","branches_url":"https://api.github.com/repos/struktured/oml/branches{/branch}","tags_url":"https://api.github.com/repos/struktured/oml/tags","blobs_url":"https://api.github.com/repos/struktured/oml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/struktured/oml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/struktured/oml/git/refs{/sha}","trees_url":"https://api.github.com/repos/struktured/oml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/struktured/oml/statuses/{sha}","languages_url":"https://api.github.com/repos/struktured/oml/languages","stargazers_url":"https://api.github.com/repos/struktured/oml/stargazers","contributors_url":"https://api.github.com/repos/struktured/oml/contributors","subscribers_url":"https://api.github.com/repos/struktured/oml/subscribers","subscription_url":"https://api.github.com/repos/struktured/oml/subscription","commits_url":"https://api.github.com/repos/struktured/oml/commits{/sha}","git_commits_url":"https://api.github.com/repos/struktured/oml/git/commits{/sha}","comments_url":"https://api.github.com/repos/struktured/oml/comments{/number}","issue_comment_url":"https://api.github.com/repos/struktured/oml/issues/comments{/number}","contents_url":"https://api.github.com/repos/struktured/oml/contents/{+path}","compare_url":"https://api.github.com/repos/struktured/oml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/struktured/oml/merges","archive_url":"https://api.github.com/repos/struktured/oml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/struktured/oml/downloads","issues_url":"https://api.github.com/repos/struktured/oml/issues{/number}","pulls_url":"https://api.github.com/repos/struktured/oml/pulls{/number}","milestones_url":"https://api.github.com/repos/struktured/oml/milestones{/number}","notifications_url":"https://api.github.com/repos/struktured/oml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/struktured/oml/labels{/name}","releases_url":"https://api.github.com/repos/struktured/oml/releases{/id}","created_at":"2015-03-22T15:53:07Z","updated_at":"2015-04-06T00:08:33Z","pushed_at":"2015-04-06T00:09:23Z","git_url":"git://github.com/struktured/oml.git","ssh_url":"git@github.com:struktured/oml.git","clone_url":"https://github.com/struktured/oml.git","svn_url":"https://github.com/struktured/oml","homepage":null,"size":150,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"struktured:master","ref":"master","sha":"a25b5fbf677c3e4ba015c571a8ddc91f8e7dc02b","user":{"login":"struktured","id":5060002,"avatar_url":"https://avatars.githubusercontent.com/u/5060002?v=3","gravatar_id":"","url":"https://api.github.com/users/struktured","html_url":"https://github.com/struktured","followers_url":"https://api.github.com/users/struktured/followers","following_url":"https://api.github.com/users/struktured/following{/other_user}","gists_url":"https://api.github.com/users/struktured/gists{/gist_id}","starred_url":"https://api.github.com/users/struktured/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/struktured/subscriptions","organizations_url":"https://api.github.com/users/struktured/orgs","repos_url":"https://api.github.com/users/struktured/repos","events_url":"https://api.github.com/users/struktured/events{/privacy}","received_events_url":"https://api.github.com/users/struktured/received_events","type":"User","site_admin":false},"repo":{"id":32682549,"name":"oml","full_name":"struktured/oml","owner":{"login":"struktured","id":5060002,"avatar_url":"https://avatars.githubusercontent.com/u/5060002?v=3","gravatar_id":"","url":"https://api.github.com/users/struktured","html_url":"https://github.com/struktured","followers_url":"https://api.github.com/users/struktured/followers","following_url":"https://api.github.com/users/struktured/following{/other_user}","gists_url":"https://api.github.com/users/struktured/gists{/gist_id}","starred_url":"https://api.github.com/users/struktured/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/struktured/subscriptions","organizations_url":"https://api.github.com/users/struktured/orgs","repos_url":"https://api.github.com/users/struktured/repos","events_url":"https://api.github.com/users/struktured/events{/privacy}","received_events_url":"https://api.github.com/users/struktured/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/struktured/oml","description":"OCaml Math Library","fork":true,"url":"https://api.github.com/repos/struktured/oml","forks_url":"https://api.github.com/repos/struktured/oml/forks","keys_url":"https://api.github.com/repos/struktured/oml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/struktured/oml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/struktured/oml/teams","hooks_url":"https://api.github.com/repos/struktured/oml/hooks","issue_events_url":"https://api.github.com/repos/struktured/oml/issues/events{/number}","events_url":"https://api.github.com/repos/struktured/oml/events","assignees_url":"https://api.github.com/repos/struktured/oml/assignees{/user}","branches_url":"https://api.github.com/repos/struktured/oml/branches{/branch}","tags_url":"https://api.github.com/repos/struktured/oml/tags","blobs_url":"https://api.github.com/repos/struktured/oml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/struktured/oml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/struktured/oml/git/refs{/sha}","trees_url":"https://api.github.com/repos/struktured/oml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/struktured/oml/statuses/{sha}","languages_url":"https://api.github.com/repos/struktured/oml/languages","stargazers_url":"https://api.github.com/repos/struktured/oml/stargazers","contributors_url":"https://api.github.com/repos/struktured/oml/contributors","subscribers_url":"https://api.github.com/repos/struktured/oml/subscribers","subscription_url":"https://api.github.com/repos/struktured/oml/subscription","commits_url":"https://api.github.com/repos/struktured/oml/commits{/sha}","git_commits_url":"https://api.github.com/repos/struktured/oml/git/commits{/sha}","comments_url":"https://api.github.com/repos/struktured/oml/comments{/number}","issue_comment_url":"https://api.github.com/repos/struktured/oml/issues/comments{/number}","contents_url":"https://api.github.com/repos/struktured/oml/contents/{+path}","compare_url":"https://api.github.com/repos/struktured/oml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/struktured/oml/merges","archive_url":"https://api.github.com/repos/struktured/oml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/struktured/oml/downloads","issues_url":"https://api.github.com/repos/struktured/oml/issues{/number}","pulls_url":"https://api.github.com/repos/struktured/oml/pulls{/number}","milestones_url":"https://api.github.com/repos/struktured/oml/milestones{/number}","notifications_url":"https://api.github.com/repos/struktured/oml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/struktured/oml/labels{/name}","releases_url":"https://api.github.com/repos/struktured/oml/releases{/id}","created_at":"2015-03-22T15:53:07Z","updated_at":"2015-04-06T00:08:33Z","pushed_at":"2015-04-06T00:09:23Z","git_url":"git://github.com/struktured/oml.git","ssh_url":"git@github.com:struktured/oml.git","clone_url":"https://github.com/struktured/oml.git","svn_url":"https://github.com/struktured/oml","homepage":null,"size":150,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/struktured/oml/pulls/1"},"html":{"href":"https://github.com/struktured/oml/pull/1"},"issue":{"href":"https://api.github.com/repos/struktured/oml/issues/1"},"comments":{"href":"https://api.github.com/repos/struktured/oml/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/struktured/oml/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/struktured/oml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/struktured/oml/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/struktured/oml/statuses/3d971dc114573991cc0d34f7d100d61f95f1663a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":46,"deletions":0,"changed_files":2}}