{"action":"created","comment":{"url":"https://api.github.com/repos/google/personfinder/pulls/comments/36610155","id":36610155,"diff_hunk":"@@ -138,559 +167,616 @@\n     var title_col = row.insertCell(cur_col++);\n     var title = document.createElement('input');\n     title.type = 'text';\n-    title.id = 'language_title_' + iteration;\n+    title.id = table_id + '_language_value_' + iteration;\n     title_col.appendChild(title);\n-\n     return iteration;\n   }\n \n+  function add_language_span(table_id, language) {\n+    var table = $(table_id + '_table');\n+    iteration = table.rows.length;\n+    var row = table.insertRow(iteration);\n+    var cur_col = 0;\n+  \n+    var selected_language_col = row.insertCell(cur_col++);\n+    var selected_language = document.createElement('span');\n+    var selected_language_text = document.createTextNode(language);\n+    selected_language.className = 'language_selected_' + iteration;\n+    selected_language.appendChild(selected_language_text);\n+    selected_language_col.style.verticalAlign = 'top';\n+    selected_language_col.appendChild(selected_language);\n+\n+    var title_col = row.insertCell(cur_col++);\n+    var title = document.createElement('textarea');\n+    title.cols = 72;\n+    title.id = table_id + '_language_value_' + iteration;\n+    title_col.appendChild(title);\n+    return iteration; \n+  }\n+\n+  function add_another_language() {","path":"app/resources/admin.html.template","position":138,"original_position":138,"commit_id":"efefd93105d4e9a0f6f429aba51c0e7e7caead9e","original_commit_id":"750a4cfac3fb88369cec98a0507a045e08ddd607","user":{"login":"skywhale","id":872395,"avatar_url":"https://avatars.githubusercontent.com/u/872395?v=3","gravatar_id":"","url":"https://api.github.com/users/skywhale","html_url":"https://github.com/skywhale","followers_url":"https://api.github.com/users/skywhale/followers","following_url":"https://api.github.com/users/skywhale/following{/other_user}","gists_url":"https://api.github.com/users/skywhale/gists{/gist_id}","starred_url":"https://api.github.com/users/skywhale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skywhale/subscriptions","organizations_url":"https://api.github.com/users/skywhale/orgs","repos_url":"https://api.github.com/users/skywhale/repos","events_url":"https://api.github.com/users/skywhale/events{/privacy}","received_events_url":"https://api.github.com/users/skywhale/received_events","type":"User","site_admin":false},"body":"Doesn't have to be in this changeset, but I think it's a good timing to move to object-oriented Javascript programming as we are trying to do relatively complex stuff. It will help readability and maintainability.\r\n\r\nvar custom_message_tables = [];\r\n\r\nfunction init_custum_message_tables() {\r\n  custom_message_tables.push(new CustomMessageWidget($('repo_title'));\r\n  custom_message_tables.push(new CustomLanguageMessageWidget($('start_page_custom_htmls'));\r\n  ...\r\n}\r\n\r\nfunction add_language_to_custom_message_tables(language_code, language_name) {\r\n  for (var i = 0; i < custom_message_tables.length; i++) {\r\n    custom_message_tables[i].add_language(language_code, language_name);\r\n  }\r\n}\r\n\r\nfunction remove_language_from_custom_message_tables(language_code) {\r\n  for (var i = 0; i < custom_message_tables.length; i++) {\r\n    custom_message_tables[i].remove_language(language_code);\r\n  }\r\n}\r\n\r\nfunction validate_settings() {\r\n  for (var i = 0; i < custom_message_tables.length; i++) {\r\n    var table = custom_message_tables[i];\r\n    $(table.id() + \"_value\").value = JSON.stringify(table.compile_value());\r\n  }\r\n}","created_at":"2015-08-10T08:22:00Z","updated_at":"2015-08-10T08:22:00Z","html_url":"https://github.com/google/personfinder/pull/116#discussion_r36610155","pull_request_url":"https://api.github.com/repos/google/personfinder/pulls/116","_links":{"self":{"href":"https://api.github.com/repos/google/personfinder/pulls/comments/36610155"},"html":{"href":"https://github.com/google/personfinder/pull/116#discussion_r36610155"},"pull_request":{"href":"https://api.github.com/repos/google/personfinder/pulls/116"}}},"pull_request":{"url":"https://api.github.com/repos/google/personfinder/pulls/116","id":41988025,"html_url":"https://github.com/google/personfinder/pull/116","diff_url":"https://github.com/google/personfinder/pull/116.diff","patch_url":"https://github.com/google/personfinder/pull/116.patch","issue_url":"https://api.github.com/repos/google/personfinder/issues/116","number":116,"state":"open","locked":false,"title":"change json fields in admin page #105","user":{"login":"prazuma","id":7258066,"avatar_url":"https://avatars.githubusercontent.com/u/7258066?v=3","gravatar_id":"","url":"https://api.github.com/users/prazuma","html_url":"https://github.com/prazuma","followers_url":"https://api.github.com/users/prazuma/followers","following_url":"https://api.github.com/users/prazuma/following{/other_user}","gists_url":"https://api.github.com/users/prazuma/gists{/gist_id}","starred_url":"https://api.github.com/users/prazuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prazuma/subscriptions","organizations_url":"https://api.github.com/users/prazuma/orgs","repos_url":"https://api.github.com/users/prazuma/repos","events_url":"https://api.github.com/users/prazuma/events{/privacy}","received_events_url":"https://api.github.com/users/prazuma/received_events","type":"User","site_admin":false},"body":"#105 \r\nchange json fields(before, we have to write json directly) to guest fields as below\r\nbefore: https://screenshot.googleplex.com/ai3wP0CGEm5\r\nafter: https://screenshot.googleplex.com/BKw6QSaOEfX\r\n","created_at":"2015-08-10T05:15:28Z","updated_at":"2015-08-10T08:22:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"865cd4184e192c57a7516d9c5e8ac5c2a207168f","assignee":{"login":"skywhale","id":872395,"avatar_url":"https://avatars.githubusercontent.com/u/872395?v=3","gravatar_id":"","url":"https://api.github.com/users/skywhale","html_url":"https://github.com/skywhale","followers_url":"https://api.github.com/users/skywhale/followers","following_url":"https://api.github.com/users/skywhale/following{/other_user}","gists_url":"https://api.github.com/users/skywhale/gists{/gist_id}","starred_url":"https://api.github.com/users/skywhale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skywhale/subscriptions","organizations_url":"https://api.github.com/users/skywhale/orgs","repos_url":"https://api.github.com/users/skywhale/repos","events_url":"https://api.github.com/users/skywhale/events{/privacy}","received_events_url":"https://api.github.com/users/skywhale/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/google/personfinder/pulls/116/commits","review_comments_url":"https://api.github.com/repos/google/personfinder/pulls/116/comments","review_comment_url":"https://api.github.com/repos/google/personfinder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/personfinder/issues/116/comments","statuses_url":"https://api.github.com/repos/google/personfinder/statuses/efefd93105d4e9a0f6f429aba51c0e7e7caead9e","head":{"label":"google:mikahashimoto-better-adminPageUIforJson","ref":"mikahashimoto-better-adminPageUIforJson","sha":"efefd93105d4e9a0f6f429aba51c0e7e7caead9e","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":25369506,"name":"personfinder","full_name":"google/personfinder","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/personfinder","description":"Person Finder is a searchable missing person database written in Python and hosted on App Engine.","fork":false,"url":"https://api.github.com/repos/google/personfinder","forks_url":"https://api.github.com/repos/google/personfinder/forks","keys_url":"https://api.github.com/repos/google/personfinder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/personfinder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/personfinder/teams","hooks_url":"https://api.github.com/repos/google/personfinder/hooks","issue_events_url":"https://api.github.com/repos/google/personfinder/issues/events{/number}","events_url":"https://api.github.com/repos/google/personfinder/events","assignees_url":"https://api.github.com/repos/google/personfinder/assignees{/user}","branches_url":"https://api.github.com/repos/google/personfinder/branches{/branch}","tags_url":"https://api.github.com/repos/google/personfinder/tags","blobs_url":"https://api.github.com/repos/google/personfinder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/personfinder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/personfinder/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/personfinder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/personfinder/statuses/{sha}","languages_url":"https://api.github.com/repos/google/personfinder/languages","stargazers_url":"https://api.github.com/repos/google/personfinder/stargazers","contributors_url":"https://api.github.com/repos/google/personfinder/contributors","subscribers_url":"https://api.github.com/repos/google/personfinder/subscribers","subscription_url":"https://api.github.com/repos/google/personfinder/subscription","commits_url":"https://api.github.com/repos/google/personfinder/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/personfinder/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/personfinder/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/personfinder/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/personfinder/contents/{+path}","compare_url":"https://api.github.com/repos/google/personfinder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/personfinder/merges","archive_url":"https://api.github.com/repos/google/personfinder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/personfinder/downloads","issues_url":"https://api.github.com/repos/google/personfinder/issues{/number}","pulls_url":"https://api.github.com/repos/google/personfinder/pulls{/number}","milestones_url":"https://api.github.com/repos/google/personfinder/milestones{/number}","notifications_url":"https://api.github.com/repos/google/personfinder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/personfinder/labels{/name}","releases_url":"https://api.github.com/repos/google/personfinder/releases{/id}","created_at":"2014-10-17T17:36:25Z","updated_at":"2015-08-05T02:18:37Z","pushed_at":"2015-08-10T07:49:49Z","git_url":"git://github.com/google/personfinder.git","ssh_url":"git@github.com:google/personfinder.git","clone_url":"https://github.com/google/personfinder.git","svn_url":"https://github.com/google/personfinder","homepage":"https://google.org/personfinder","size":235823,"stargazers_count":81,"watchers_count":81,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":58,"forks":37,"open_issues":58,"watchers":81,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"819ac3f67b0c8dbe7a1fe7abf55567a9957cc071","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":25369506,"name":"personfinder","full_name":"google/personfinder","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/personfinder","description":"Person Finder is a searchable missing person database written in Python and hosted on App Engine.","fork":false,"url":"https://api.github.com/repos/google/personfinder","forks_url":"https://api.github.com/repos/google/personfinder/forks","keys_url":"https://api.github.com/repos/google/personfinder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/personfinder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/personfinder/teams","hooks_url":"https://api.github.com/repos/google/personfinder/hooks","issue_events_url":"https://api.github.com/repos/google/personfinder/issues/events{/number}","events_url":"https://api.github.com/repos/google/personfinder/events","assignees_url":"https://api.github.com/repos/google/personfinder/assignees{/user}","branches_url":"https://api.github.com/repos/google/personfinder/branches{/branch}","tags_url":"https://api.github.com/repos/google/personfinder/tags","blobs_url":"https://api.github.com/repos/google/personfinder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/personfinder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/personfinder/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/personfinder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/personfinder/statuses/{sha}","languages_url":"https://api.github.com/repos/google/personfinder/languages","stargazers_url":"https://api.github.com/repos/google/personfinder/stargazers","contributors_url":"https://api.github.com/repos/google/personfinder/contributors","subscribers_url":"https://api.github.com/repos/google/personfinder/subscribers","subscription_url":"https://api.github.com/repos/google/personfinder/subscription","commits_url":"https://api.github.com/repos/google/personfinder/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/personfinder/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/personfinder/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/personfinder/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/personfinder/contents/{+path}","compare_url":"https://api.github.com/repos/google/personfinder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/personfinder/merges","archive_url":"https://api.github.com/repos/google/personfinder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/personfinder/downloads","issues_url":"https://api.github.com/repos/google/personfinder/issues{/number}","pulls_url":"https://api.github.com/repos/google/personfinder/pulls{/number}","milestones_url":"https://api.github.com/repos/google/personfinder/milestones{/number}","notifications_url":"https://api.github.com/repos/google/personfinder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/personfinder/labels{/name}","releases_url":"https://api.github.com/repos/google/personfinder/releases{/id}","created_at":"2014-10-17T17:36:25Z","updated_at":"2015-08-05T02:18:37Z","pushed_at":"2015-08-10T07:49:49Z","git_url":"git://github.com/google/personfinder.git","ssh_url":"git@github.com:google/personfinder.git","clone_url":"https://github.com/google/personfinder.git","svn_url":"https://github.com/google/personfinder","homepage":"https://google.org/personfinder","size":235823,"stargazers_count":81,"watchers_count":81,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":58,"forks":37,"open_issues":58,"watchers":81,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/personfinder/pulls/116"},"html":{"href":"https://github.com/google/personfinder/pull/116"},"issue":{"href":"https://api.github.com/repos/google/personfinder/issues/116"},"comments":{"href":"https://api.github.com/repos/google/personfinder/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/google/personfinder/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/google/personfinder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/personfinder/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/google/personfinder/statuses/efefd93105d4e9a0f6f429aba51c0e7e7caead9e"}}}}