{"action":"closed","number":446,"pull_request":{"url":"https://api.github.com/repos/twitter/finagle/pulls/446","id":52694089,"html_url":"https://github.com/twitter/finagle/pull/446","diff_url":"https://github.com/twitter/finagle/pull/446.diff","patch_url":"https://github.com/twitter/finagle/pull/446.patch","issue_url":"https://api.github.com/repos/twitter/finagle/issues/446","number":446,"state":"closed","locked":false,"title":"finagle-core: implementing RequestMeterFilter based on new AsyncMeter…","user":{"login":"amartinsn","id":13151,"avatar_url":"https://avatars.githubusercontent.com/u/13151?v=3","gravatar_id":"","url":"https://api.github.com/users/amartinsn","html_url":"https://github.com/amartinsn","followers_url":"https://api.github.com/users/amartinsn/followers","following_url":"https://api.github.com/users/amartinsn/following{/other_user}","gists_url":"https://api.github.com/users/amartinsn/gists{/gist_id}","starred_url":"https://api.github.com/users/amartinsn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amartinsn/subscriptions","organizations_url":"https://api.github.com/users/amartinsn/orgs","repos_url":"https://api.github.com/users/amartinsn/repos","events_url":"https://api.github.com/users/amartinsn/events{/privacy}","received_events_url":"https://api.github.com/users/amartinsn/received_events","type":"User","site_admin":false},"body":"Problem\r\n\r\nWe wanted to be able to control access to rate limited resources, by slowing down requests to fit on the request rate accepted by these resources.\r\n\r\nSolution\r\n\r\nWe ended up implementing a filter named `RequestMeterFilter` using Twitter util's `AsyncMeter` to achieve that. Feedback on naming are really welcomed.\r\n\r\nResult\r\n\r\nAs a result, I've added this `Filter` so other users with the same needs can use this solution.","created_at":"2015-12-04T16:59:33Z","updated_at":"2015-12-10T21:15:53Z","closed_at":"2015-12-10T21:15:53Z","merged_at":null,"merge_commit_sha":"070be9bf0527a667dc7c07e08374ef2c4467aaa7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twitter/finagle/pulls/446/commits","review_comments_url":"https://api.github.com/repos/twitter/finagle/pulls/446/comments","review_comment_url":"https://api.github.com/repos/twitter/finagle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twitter/finagle/issues/446/comments","statuses_url":"https://api.github.com/repos/twitter/finagle/statuses/5704f062454b86013ee06abde575fd6773f438fc","head":{"label":"amartinsn:timer-based-throttler","ref":"timer-based-throttler","sha":"5704f062454b86013ee06abde575fd6773f438fc","user":{"login":"amartinsn","id":13151,"avatar_url":"https://avatars.githubusercontent.com/u/13151?v=3","gravatar_id":"","url":"https://api.github.com/users/amartinsn","html_url":"https://github.com/amartinsn","followers_url":"https://api.github.com/users/amartinsn/followers","following_url":"https://api.github.com/users/amartinsn/following{/other_user}","gists_url":"https://api.github.com/users/amartinsn/gists{/gist_id}","starred_url":"https://api.github.com/users/amartinsn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amartinsn/subscriptions","organizations_url":"https://api.github.com/users/amartinsn/orgs","repos_url":"https://api.github.com/users/amartinsn/repos","events_url":"https://api.github.com/users/amartinsn/events{/privacy}","received_events_url":"https://api.github.com/users/amartinsn/received_events","type":"User","site_admin":false},"repo":{"id":47416874,"name":"finagle","full_name":"amartinsn/finagle","owner":{"login":"amartinsn","id":13151,"avatar_url":"https://avatars.githubusercontent.com/u/13151?v=3","gravatar_id":"","url":"https://api.github.com/users/amartinsn","html_url":"https://github.com/amartinsn","followers_url":"https://api.github.com/users/amartinsn/followers","following_url":"https://api.github.com/users/amartinsn/following{/other_user}","gists_url":"https://api.github.com/users/amartinsn/gists{/gist_id}","starred_url":"https://api.github.com/users/amartinsn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amartinsn/subscriptions","organizations_url":"https://api.github.com/users/amartinsn/orgs","repos_url":"https://api.github.com/users/amartinsn/repos","events_url":"https://api.github.com/users/amartinsn/events{/privacy}","received_events_url":"https://api.github.com/users/amartinsn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amartinsn/finagle","description":"A fault tolerant, protocol-agnostic RPC system","fork":true,"url":"https://api.github.com/repos/amartinsn/finagle","forks_url":"https://api.github.com/repos/amartinsn/finagle/forks","keys_url":"https://api.github.com/repos/amartinsn/finagle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amartinsn/finagle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amartinsn/finagle/teams","hooks_url":"https://api.github.com/repos/amartinsn/finagle/hooks","issue_events_url":"https://api.github.com/repos/amartinsn/finagle/issues/events{/number}","events_url":"https://api.github.com/repos/amartinsn/finagle/events","assignees_url":"https://api.github.com/repos/amartinsn/finagle/assignees{/user}","branches_url":"https://api.github.com/repos/amartinsn/finagle/branches{/branch}","tags_url":"https://api.github.com/repos/amartinsn/finagle/tags","blobs_url":"https://api.github.com/repos/amartinsn/finagle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amartinsn/finagle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amartinsn/finagle/git/refs{/sha}","trees_url":"https://api.github.com/repos/amartinsn/finagle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amartinsn/finagle/statuses/{sha}","languages_url":"https://api.github.com/repos/amartinsn/finagle/languages","stargazers_url":"https://api.github.com/repos/amartinsn/finagle/stargazers","contributors_url":"https://api.github.com/repos/amartinsn/finagle/contributors","subscribers_url":"https://api.github.com/repos/amartinsn/finagle/subscribers","subscription_url":"https://api.github.com/repos/amartinsn/finagle/subscription","commits_url":"https://api.github.com/repos/amartinsn/finagle/commits{/sha}","git_commits_url":"https://api.github.com/repos/amartinsn/finagle/git/commits{/sha}","comments_url":"https://api.github.com/repos/amartinsn/finagle/comments{/number}","issue_comment_url":"https://api.github.com/repos/amartinsn/finagle/issues/comments{/number}","contents_url":"https://api.github.com/repos/amartinsn/finagle/contents/{+path}","compare_url":"https://api.github.com/repos/amartinsn/finagle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amartinsn/finagle/merges","archive_url":"https://api.github.com/repos/amartinsn/finagle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amartinsn/finagle/downloads","issues_url":"https://api.github.com/repos/amartinsn/finagle/issues{/number}","pulls_url":"https://api.github.com/repos/amartinsn/finagle/pulls{/number}","milestones_url":"https://api.github.com/repos/amartinsn/finagle/milestones{/number}","notifications_url":"https://api.github.com/repos/amartinsn/finagle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amartinsn/finagle/labels{/name}","releases_url":"https://api.github.com/repos/amartinsn/finagle/releases{/id}","created_at":"2015-12-04T16:49:48Z","updated_at":"2015-12-04T16:49:52Z","pushed_at":"2015-12-08T12:27:17Z","git_url":"git://github.com/amartinsn/finagle.git","ssh_url":"git@github.com:amartinsn/finagle.git","clone_url":"https://github.com/amartinsn/finagle.git","svn_url":"https://github.com/amartinsn/finagle","homepage":"http://twitter.github.io/finagle","size":34389,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"twitter:develop","ref":"develop","sha":"50d3bb0eea5ad3ed332111d707184c80fed6a506","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":1007362,"name":"finagle","full_name":"twitter/finagle","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/finagle","description":"A fault tolerant, protocol-agnostic RPC system","fork":false,"url":"https://api.github.com/repos/twitter/finagle","forks_url":"https://api.github.com/repos/twitter/finagle/forks","keys_url":"https://api.github.com/repos/twitter/finagle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/finagle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/finagle/teams","hooks_url":"https://api.github.com/repos/twitter/finagle/hooks","issue_events_url":"https://api.github.com/repos/twitter/finagle/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/finagle/events","assignees_url":"https://api.github.com/repos/twitter/finagle/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/finagle/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/finagle/tags","blobs_url":"https://api.github.com/repos/twitter/finagle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/finagle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/finagle/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/finagle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/finagle/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/finagle/languages","stargazers_url":"https://api.github.com/repos/twitter/finagle/stargazers","contributors_url":"https://api.github.com/repos/twitter/finagle/contributors","subscribers_url":"https://api.github.com/repos/twitter/finagle/subscribers","subscription_url":"https://api.github.com/repos/twitter/finagle/subscription","commits_url":"https://api.github.com/repos/twitter/finagle/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/finagle/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/finagle/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/finagle/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter/finagle/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/finagle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/finagle/merges","archive_url":"https://api.github.com/repos/twitter/finagle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/finagle/downloads","issues_url":"https://api.github.com/repos/twitter/finagle/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/finagle/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/finagle/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/finagle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/finagle/labels{/name}","releases_url":"https://api.github.com/repos/twitter/finagle/releases{/id}","created_at":"2010-10-19T22:10:09Z","updated_at":"2015-12-10T18:45:26Z","pushed_at":"2015-12-10T02:22:02Z","git_url":"git://github.com/twitter/finagle.git","ssh_url":"git@github.com:twitter/finagle.git","clone_url":"https://github.com/twitter/finagle.git","svn_url":"https://github.com/twitter/finagle","homepage":"http://twitter.github.io/finagle","size":36524,"stargazers_count":4062,"watchers_count":4062,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":791,"mirror_url":null,"open_issues_count":40,"forks":791,"open_issues":40,"watchers":4062,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/finagle/pulls/446"},"html":{"href":"https://github.com/twitter/finagle/pull/446"},"issue":{"href":"https://api.github.com/repos/twitter/finagle/issues/446"},"comments":{"href":"https://api.github.com/repos/twitter/finagle/issues/446/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/finagle/pulls/446/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/finagle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twitter/finagle/pulls/446/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/finagle/statuses/5704f062454b86013ee06abde575fd6773f438fc"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":6,"review_comments":29,"commits":3,"additions":118,"deletions":0,"changed_files":2}}