{"action":"created","comment":{"url":"https://api.github.com/repos/l-smash/l-smash/pulls/comments/44218879","id":44218879,"diff_hunk":"@@ -4086,6 +4103,82 @@ int lsmash_create_object_descriptor\n     lsmash_root_t *root\n );\n \n+/* Set a session description protocol (SDP) to a track.\n+* track_ID == 0 means SDP applies to the entire presentation, not an entire track.\n+* Recommendation: Record session level section of SDP to movie and media-level sections to track\n+*\n+* Return 0 if successful.\n+* Return a negative value otherwise. */\n+int lsmash_set_sdp\n+(\n+    lsmash_root_t *root,\n+    uint32_t       track_ID,\n+    char          *sdptext\n+);\n+\n+/* Hint tracks sample specific stuff */\n+\n+/* RTP packet structure. One of these is required for each sample in RTP hint tracks \n+and RTP Reception hint tracks for each RTP packet. */\n+typedef struct\n+{\n+    int32_t relative_time;\n+\n+    uint16_t VPXCMP;         /* RTP_version(2), P-bit(1), X-bit(1), CSRC_count(4), M_bit(1), payload_type(7) */\n+    uint16_t seq_number;\n+    uint16_t reserved_flags; /* reserved(13), extra_flag(1), bframe_flag(1), repeat_flag(1) */\n+    uint16_t entrycount;\n+","path":"lsmash.h","position":92,"original_position":92,"commit_id":"db734d329518ec02f9762d78608ce721c334bdaf","original_commit_id":"db734d329518ec02f9762d78608ce721c334bdaf","user":{"login":"VFR-maniac","id":372049,"avatar_url":"https://avatars.githubusercontent.com/u/372049?v=3","gravatar_id":"","url":"https://api.github.com/users/VFR-maniac","html_url":"https://github.com/VFR-maniac","followers_url":"https://api.github.com/users/VFR-maniac/followers","following_url":"https://api.github.com/users/VFR-maniac/following{/other_user}","gists_url":"https://api.github.com/users/VFR-maniac/gists{/gist_id}","starred_url":"https://api.github.com/users/VFR-maniac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VFR-maniac/subscriptions","organizations_url":"https://api.github.com/users/VFR-maniac/orgs","repos_url":"https://api.github.com/users/VFR-maniac/repos","events_url":"https://api.github.com/users/VFR-maniac/events{/privacy}","received_events_url":"https://api.github.com/users/VFR-maniac/received_events","type":"User","site_admin":false},"body":"An extra line :P","created_at":"2015-11-08T00:02:54Z","updated_at":"2015-11-08T00:02:54Z","html_url":"https://github.com/l-smash/l-smash/pull/55#discussion_r44218879","pull_request_url":"https://api.github.com/repos/l-smash/l-smash/pulls/55","_links":{"self":{"href":"https://api.github.com/repos/l-smash/l-smash/pulls/comments/44218879"},"html":{"href":"https://github.com/l-smash/l-smash/pull/55#discussion_r44218879"},"pull_request":{"href":"https://api.github.com/repos/l-smash/l-smash/pulls/55"}}},"pull_request":{"url":"https://api.github.com/repos/l-smash/l-smash/pulls/55","id":49254495,"html_url":"https://github.com/l-smash/l-smash/pull/55","diff_url":"https://github.com/l-smash/l-smash/pull/55.diff","patch_url":"https://github.com/l-smash/l-smash/pull/55.patch","issue_url":"https://api.github.com/repos/l-smash/l-smash/issues/55","number":55,"state":"open","locked":false,"title":"RTP/RTCP Reception hint tracks","user":{"login":"polusto","id":6498638,"avatar_url":"https://avatars.githubusercontent.com/u/6498638?v=3","gravatar_id":"","url":"https://api.github.com/users/polusto","html_url":"https://github.com/polusto","followers_url":"https://api.github.com/users/polusto/followers","following_url":"https://api.github.com/users/polusto/following{/other_user}","gists_url":"https://api.github.com/users/polusto/gists{/gist_id}","starred_url":"https://api.github.com/users/polusto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polusto/subscriptions","organizations_url":"https://api.github.com/users/polusto/orgs","repos_url":"https://api.github.com/users/polusto/repos","events_url":"https://api.github.com/users/polusto/events{/privacy}","received_events_url":"https://api.github.com/users/polusto/received_events","type":"User","site_admin":false},"body":"I've implemented RTP and RTCP Reception Hint track support. Adding support for RTP server hint tracks and other hint tracks should be easier after these changes. \r\n\r\nIn hmhd box avgPDUsize and maxPDUsize could probably be implemented better, now they are calculated in append sample. I tried implementing them at the finish movie, but didn't figure out how to access sample data at that point.\r\n\r\nAdded one new fourcc 'gsm ', because VLC media player seemed to recognize that one better than 'agsm'.","created_at":"2015-10-30T10:46:21Z","updated_at":"2015-11-08T00:02:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6606601e383026d1cf5728f8ecaf1e4f3a703e5b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/l-smash/l-smash/pulls/55/commits","review_comments_url":"https://api.github.com/repos/l-smash/l-smash/pulls/55/comments","review_comment_url":"https://api.github.com/repos/l-smash/l-smash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/l-smash/l-smash/issues/55/comments","statuses_url":"https://api.github.com/repos/l-smash/l-smash/statuses/db734d329518ec02f9762d78608ce721c334bdaf","head":{"label":"polusto:reception_hint_tracks","ref":"reception_hint_tracks","sha":"db734d329518ec02f9762d78608ce721c334bdaf","user":{"login":"polusto","id":6498638,"avatar_url":"https://avatars.githubusercontent.com/u/6498638?v=3","gravatar_id":"","url":"https://api.github.com/users/polusto","html_url":"https://github.com/polusto","followers_url":"https://api.github.com/users/polusto/followers","following_url":"https://api.github.com/users/polusto/following{/other_user}","gists_url":"https://api.github.com/users/polusto/gists{/gist_id}","starred_url":"https://api.github.com/users/polusto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polusto/subscriptions","organizations_url":"https://api.github.com/users/polusto/orgs","repos_url":"https://api.github.com/users/polusto/repos","events_url":"https://api.github.com/users/polusto/events{/privacy}","received_events_url":"https://api.github.com/users/polusto/received_events","type":"User","site_admin":false},"repo":{"id":45237095,"name":"l-smash","full_name":"polusto/l-smash","owner":{"login":"polusto","id":6498638,"avatar_url":"https://avatars.githubusercontent.com/u/6498638?v=3","gravatar_id":"","url":"https://api.github.com/users/polusto","html_url":"https://github.com/polusto","followers_url":"https://api.github.com/users/polusto/followers","following_url":"https://api.github.com/users/polusto/following{/other_user}","gists_url":"https://api.github.com/users/polusto/gists{/gist_id}","starred_url":"https://api.github.com/users/polusto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polusto/subscriptions","organizations_url":"https://api.github.com/users/polusto/orgs","repos_url":"https://api.github.com/users/polusto/repos","events_url":"https://api.github.com/users/polusto/events{/privacy}","received_events_url":"https://api.github.com/users/polusto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/polusto/l-smash","description":"RTP and RTCP Reception Hint Tracks for L-SMASH","fork":true,"url":"https://api.github.com/repos/polusto/l-smash","forks_url":"https://api.github.com/repos/polusto/l-smash/forks","keys_url":"https://api.github.com/repos/polusto/l-smash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/polusto/l-smash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/polusto/l-smash/teams","hooks_url":"https://api.github.com/repos/polusto/l-smash/hooks","issue_events_url":"https://api.github.com/repos/polusto/l-smash/issues/events{/number}","events_url":"https://api.github.com/repos/polusto/l-smash/events","assignees_url":"https://api.github.com/repos/polusto/l-smash/assignees{/user}","branches_url":"https://api.github.com/repos/polusto/l-smash/branches{/branch}","tags_url":"https://api.github.com/repos/polusto/l-smash/tags","blobs_url":"https://api.github.com/repos/polusto/l-smash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/polusto/l-smash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/polusto/l-smash/git/refs{/sha}","trees_url":"https://api.github.com/repos/polusto/l-smash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/polusto/l-smash/statuses/{sha}","languages_url":"https://api.github.com/repos/polusto/l-smash/languages","stargazers_url":"https://api.github.com/repos/polusto/l-smash/stargazers","contributors_url":"https://api.github.com/repos/polusto/l-smash/contributors","subscribers_url":"https://api.github.com/repos/polusto/l-smash/subscribers","subscription_url":"https://api.github.com/repos/polusto/l-smash/subscription","commits_url":"https://api.github.com/repos/polusto/l-smash/commits{/sha}","git_commits_url":"https://api.github.com/repos/polusto/l-smash/git/commits{/sha}","comments_url":"https://api.github.com/repos/polusto/l-smash/comments{/number}","issue_comment_url":"https://api.github.com/repos/polusto/l-smash/issues/comments{/number}","contents_url":"https://api.github.com/repos/polusto/l-smash/contents/{+path}","compare_url":"https://api.github.com/repos/polusto/l-smash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/polusto/l-smash/merges","archive_url":"https://api.github.com/repos/polusto/l-smash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/polusto/l-smash/downloads","issues_url":"https://api.github.com/repos/polusto/l-smash/issues{/number}","pulls_url":"https://api.github.com/repos/polusto/l-smash/pulls{/number}","milestones_url":"https://api.github.com/repos/polusto/l-smash/milestones{/number}","notifications_url":"https://api.github.com/repos/polusto/l-smash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/polusto/l-smash/labels{/name}","releases_url":"https://api.github.com/repos/polusto/l-smash/releases{/id}","created_at":"2015-10-30T08:01:26Z","updated_at":"2015-10-30T08:07:04Z","pushed_at":"2015-11-06T14:04:15Z","git_url":"git://github.com/polusto/l-smash.git","ssh_url":"git@github.com:polusto/l-smash.git","clone_url":"https://github.com/polusto/l-smash.git","svn_url":"https://github.com/polusto/l-smash","homepage":"","size":7948,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"l-smash:master","ref":"master","sha":"340894701ced37f07e919d63c4d9ce86f2d9de7a","user":{"login":"l-smash","id":5137288,"avatar_url":"https://avatars.githubusercontent.com/u/5137288?v=3","gravatar_id":"","url":"https://api.github.com/users/l-smash","html_url":"https://github.com/l-smash","followers_url":"https://api.github.com/users/l-smash/followers","following_url":"https://api.github.com/users/l-smash/following{/other_user}","gists_url":"https://api.github.com/users/l-smash/gists{/gist_id}","starred_url":"https://api.github.com/users/l-smash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l-smash/subscriptions","organizations_url":"https://api.github.com/users/l-smash/orgs","repos_url":"https://api.github.com/users/l-smash/repos","events_url":"https://api.github.com/users/l-smash/events{/privacy}","received_events_url":"https://api.github.com/users/l-smash/received_events","type":"Organization","site_admin":false},"repo":{"id":11813843,"name":"l-smash","full_name":"l-smash/l-smash","owner":{"login":"l-smash","id":5137288,"avatar_url":"https://avatars.githubusercontent.com/u/5137288?v=3","gravatar_id":"","url":"https://api.github.com/users/l-smash","html_url":"https://github.com/l-smash","followers_url":"https://api.github.com/users/l-smash/followers","following_url":"https://api.github.com/users/l-smash/following{/other_user}","gists_url":"https://api.github.com/users/l-smash/gists{/gist_id}","starred_url":"https://api.github.com/users/l-smash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l-smash/subscriptions","organizations_url":"https://api.github.com/users/l-smash/orgs","repos_url":"https://api.github.com/users/l-smash/repos","events_url":"https://api.github.com/users/l-smash/events{/privacy}","received_events_url":"https://api.github.com/users/l-smash/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/l-smash/l-smash","description":"L-SMASH's official repo","fork":false,"url":"https://api.github.com/repos/l-smash/l-smash","forks_url":"https://api.github.com/repos/l-smash/l-smash/forks","keys_url":"https://api.github.com/repos/l-smash/l-smash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/l-smash/l-smash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/l-smash/l-smash/teams","hooks_url":"https://api.github.com/repos/l-smash/l-smash/hooks","issue_events_url":"https://api.github.com/repos/l-smash/l-smash/issues/events{/number}","events_url":"https://api.github.com/repos/l-smash/l-smash/events","assignees_url":"https://api.github.com/repos/l-smash/l-smash/assignees{/user}","branches_url":"https://api.github.com/repos/l-smash/l-smash/branches{/branch}","tags_url":"https://api.github.com/repos/l-smash/l-smash/tags","blobs_url":"https://api.github.com/repos/l-smash/l-smash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/l-smash/l-smash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/l-smash/l-smash/git/refs{/sha}","trees_url":"https://api.github.com/repos/l-smash/l-smash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/l-smash/l-smash/statuses/{sha}","languages_url":"https://api.github.com/repos/l-smash/l-smash/languages","stargazers_url":"https://api.github.com/repos/l-smash/l-smash/stargazers","contributors_url":"https://api.github.com/repos/l-smash/l-smash/contributors","subscribers_url":"https://api.github.com/repos/l-smash/l-smash/subscribers","subscription_url":"https://api.github.com/repos/l-smash/l-smash/subscription","commits_url":"https://api.github.com/repos/l-smash/l-smash/commits{/sha}","git_commits_url":"https://api.github.com/repos/l-smash/l-smash/git/commits{/sha}","comments_url":"https://api.github.com/repos/l-smash/l-smash/comments{/number}","issue_comment_url":"https://api.github.com/repos/l-smash/l-smash/issues/comments{/number}","contents_url":"https://api.github.com/repos/l-smash/l-smash/contents/{+path}","compare_url":"https://api.github.com/repos/l-smash/l-smash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/l-smash/l-smash/merges","archive_url":"https://api.github.com/repos/l-smash/l-smash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/l-smash/l-smash/downloads","issues_url":"https://api.github.com/repos/l-smash/l-smash/issues{/number}","pulls_url":"https://api.github.com/repos/l-smash/l-smash/pulls{/number}","milestones_url":"https://api.github.com/repos/l-smash/l-smash/milestones{/number}","notifications_url":"https://api.github.com/repos/l-smash/l-smash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/l-smash/l-smash/labels{/name}","releases_url":"https://api.github.com/repos/l-smash/l-smash/releases{/id}","created_at":"2013-08-01T10:11:20Z","updated_at":"2015-11-06T19:49:07Z","pushed_at":"2015-11-06T14:04:15Z","git_url":"git://github.com/l-smash/l-smash.git","ssh_url":"git@github.com:l-smash/l-smash.git","clone_url":"https://github.com/l-smash/l-smash.git","svn_url":"https://github.com/l-smash/l-smash","homepage":"http://l-smash.github.io/l-smash/","size":10252,"stargazers_count":45,"watchers_count":45,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":16,"mirror_url":null,"open_issues_count":16,"forks":16,"open_issues":16,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/l-smash/l-smash/pulls/55"},"html":{"href":"https://github.com/l-smash/l-smash/pull/55"},"issue":{"href":"https://api.github.com/repos/l-smash/l-smash/issues/55"},"comments":{"href":"https://api.github.com/repos/l-smash/l-smash/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/l-smash/l-smash/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/l-smash/l-smash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/l-smash/l-smash/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/l-smash/l-smash/statuses/db734d329518ec02f9762d78608ce721c334bdaf"}}}}