{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/35961423","id":35961423,"diff_hunk":"@@ -86,7 +80,7 @@\n         </tr>\n     </table>\n \n-    {% if collector.logs %}\n+{% if collector.logs %}","path":"src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/logger.html.twig","position":62,"original_position":62,"commit_id":"22f6bc5003e4536c8114731c576cb54ebd8250b2","original_commit_id":"22f6bc5003e4536c8114731c576cb54ebd8250b2","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=3","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"this change should be reverted","created_at":"2015-07-31T10:07:50Z","updated_at":"2015-07-31T10:07:50Z","html_url":"https://github.com/symfony/symfony/pull/15160#discussion_r35961423","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/15160","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/35961423"},"html":{"href":"https://github.com/symfony/symfony/pull/15160#discussion_r35961423"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/15160"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/15160","id":38955657,"html_url":"https://github.com/symfony/symfony/pull/15160","diff_url":"https://github.com/symfony/symfony/pull/15160.diff","patch_url":"https://github.com/symfony/symfony/pull/15160.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/15160","number":15160,"state":"open","locked":false,"title":"Redesigned the web debug toolbar","user":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars.githubusercontent.com/u/73419?v=3","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | -\r\n| License       | MIT\r\n| Doc PR        | -\r\n\r\nIn my opinion, the design of the current Web Debug Toolbar suffers from two problems: it looks outdated and it lacks polishing on some parts. Symfony has always introduced a big update in this toolbar for each big release, so I propose to do the same for Symfony 3.\r\n\r\nLet's see the new proposed toolbar in action:\r\n\r\n-----\r\n\r\n**This is the default toolbar** (click on the image to enlarge it)\r\n\r\n![default](https://cloud.githubusercontent.com/assets/73419/8449444/cb4be4ea-1fd1-11e5-9358-332449375531.png)\r\n\r\nAs you can see, if some panel doesn't provide any information, we don't show it (e.g. 0 queries, 0 forms, 0 logs, 0 ajax requests).\r\n\r\n-----\r\n\r\nLet's compare some panels in detail:\r\n\r\n**Symfony Panel**\r\n\r\n![symfony-old-panel](https://cloud.githubusercontent.com/assets/73419/8449504/407302b2-1fd2-11e5-80da-a49dc99e68f5.png) ![symfony-new-panel](https://cloud.githubusercontent.com/assets/73419/8449505/41698e20-1fd2-11e5-8ced-e2717716c2d3.png)\r\n\r\n**Request Panel**\r\n\r\n![request-old-panel](https://cloud.githubusercontent.com/assets/73419/8449531/7d6888ea-1fd2-11e5-829e-93c9e50b7b64.png) ![request-new-panel](https://cloud.githubusercontent.com/assets/73419/8449532/7e359da8-1fd2-11e5-87e6-f194d824254c.png)\r\n\r\n-----\r\n\r\nWhen needed, more panels are displayed, such as the SQL information:  (click on the image to enlarge it)\r\n\r\n![sql_panel](https://cloud.githubusercontent.com/assets/73419/8449554/b6abc1d0-1fd2-11e5-8450-13eae5bc3c50.png)\r\n\r\nAs you can see, the new toolbar provides more information than the old one and it takes less space.\r\n\r\nSome of the new panels include more information in the extended info, such as the Doctrine one showing that the second level cache is disabled:\r\n\r\n![sql_old_panel](https://cloud.githubusercontent.com/assets/73419/8449573/fc288aae-1fd2-11e5-9823-46b33fa9d998.png) ![sql_new_panel](https://cloud.githubusercontent.com/assets/73419/8449572/fab6244c-1fd2-11e5-9e14-28045de0b143.png)\r\n\r\n-----\r\n\r\n**Errors and warnings** now stand out more clearly because all the panel background is changed.\r\n\r\nFor example, if there are i18n errors: (click on the image to enlarge it)\r\n\r\n![i18n_panel_error](https://cloud.githubusercontent.com/assets/73419/8449590/20708786-1fd3-11e5-8ad7-6bd3b3f4b933.png)\r\n\r\nIf the page is loading too slowly: (click on the image to enlarge it)\r\n\r\n![slow_page](https://cloud.githubusercontent.com/assets/73419/8449597/2bc0c6e6-1fd3-11e5-9a9e-55bfe07ac170.png)\r\n\r\nIf Symfony version is deprecated: (click on the image to enlarge it)\r\n\r\n![deprecated_symfony](https://cloud.githubusercontent.com/assets/73419/8449605/3cfa9860-1fd3-11e5-8dbd-9915597970f4.png)\r\n\r\n-----\r\n\r\nHTTP Errors also stand out more clearly: (click on the image to enlarge it)\r\n\r\n![error_404](https://cloud.githubusercontent.com/assets/73419/8449617/56a4ccb8-1fd3-11e5-9638-322f1840937c.png)\r\n\r\n![error_500](https://cloud.githubusercontent.com/assets/73419/8449618/57a79294-1fd3-11e5-8383-2598dee73fc6.png)\r\n\r\n-----\r\n\r\nSome questions that you may be wondering:\r\n\r\n  * **Why use a dark toolbar instead of maintaining the light toolbar?** Because a dark toolbar stands out more from most of the web designs. It's more probable that your applications display a light background than a dark background, so the Symfony Toolbar stands out more if it's designed in dark.\r\n  * **What about the profiler?** If this proposal is approved I'll also update the design of the profiler to match this new dark and modern look-and-feel.\r\n  * **What about smaller screens?** This is a proposal, so I haven't finished it. Tweaking the design for smaller screens will be the next step. Anyway, as you can see the new toolbar already takes much less space than the current one, so it won't be hard to adapt it.","created_at":"2015-07-01T07:38:38Z","updated_at":"2015-07-31T10:07:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d7b45d367ea82cc7b909fb096bf9f7703b73b57","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/15160/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/15160/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/15160/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/22f6bc5003e4536c8114731c576cb54ebd8250b2","head":{"label":"javiereguiluz:new_toolbar","ref":"new_toolbar","sha":"22f6bc5003e4536c8114731c576cb54ebd8250b2","user":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars.githubusercontent.com/u/73419?v=3","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"repo":{"id":15188086,"name":"symfony","full_name":"javiereguiluz/symfony","owner":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars.githubusercontent.com/u/73419?v=3","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/javiereguiluz/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/javiereguiluz/symfony","forks_url":"https://api.github.com/repos/javiereguiluz/symfony/forks","keys_url":"https://api.github.com/repos/javiereguiluz/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/javiereguiluz/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/javiereguiluz/symfony/teams","hooks_url":"https://api.github.com/repos/javiereguiluz/symfony/hooks","issue_events_url":"https://api.github.com/repos/javiereguiluz/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/javiereguiluz/symfony/events","assignees_url":"https://api.github.com/repos/javiereguiluz/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/javiereguiluz/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/javiereguiluz/symfony/tags","blobs_url":"https://api.github.com/repos/javiereguiluz/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/javiereguiluz/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/javiereguiluz/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/javiereguiluz/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/javiereguiluz/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/javiereguiluz/symfony/languages","stargazers_url":"https://api.github.com/repos/javiereguiluz/symfony/stargazers","contributors_url":"https://api.github.com/repos/javiereguiluz/symfony/contributors","subscribers_url":"https://api.github.com/repos/javiereguiluz/symfony/subscribers","subscription_url":"https://api.github.com/repos/javiereguiluz/symfony/subscription","commits_url":"https://api.github.com/repos/javiereguiluz/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/javiereguiluz/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/javiereguiluz/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/javiereguiluz/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/javiereguiluz/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/javiereguiluz/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/javiereguiluz/symfony/merges","archive_url":"https://api.github.com/repos/javiereguiluz/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/javiereguiluz/symfony/downloads","issues_url":"https://api.github.com/repos/javiereguiluz/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/javiereguiluz/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/javiereguiluz/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/javiereguiluz/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/javiereguiluz/symfony/labels{/name}","releases_url":"https://api.github.com/repos/javiereguiluz/symfony/releases{/id}","created_at":"2013-12-14T15:54:02Z","updated_at":"2015-07-31T05:53:32Z","pushed_at":"2015-07-30T13:16:20Z","git_url":"git://github.com/javiereguiluz/symfony.git","ssh_url":"git@github.com:javiereguiluz/symfony.git","clone_url":"https://github.com/javiereguiluz/symfony.git","svn_url":"https://github.com/javiereguiluz/symfony","homepage":"symfony.com","size":58617,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"symfony:2.8","ref":"2.8","sha":"2655072bfdf5bef44c34495a01ec2470a82bcacb","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2015-07-31T08:06:44Z","pushed_at":"2015-07-31T09:38:26Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":1201223,"stargazers_count":10560,"watchers_count":10560,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4190,"mirror_url":null,"open_issues_count":910,"forks":4190,"open_issues":910,"watchers":10560,"default_branch":"2.8"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/15160"},"html":{"href":"https://github.com/symfony/symfony/pull/15160"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/15160"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/15160/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/15160/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/15160/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/22f6bc5003e4536c8114731c576cb54ebd8250b2"}}}}