{"action":"created","comment":{"url":"https://api.github.com/repos/TWCable/grabbit/pulls/comments/35253678","id":35253678,"diff_hunk":"@@ -88,10 +90,51 @@ class JcrNodesProcessor implements ItemProcessor<JcrNode, Node> {\n             }\n         }\n \n-        final List<JcrProperty> properties = jcrNode.properties.toList()\n-        Node.Builder nodeBuilder = Node.newBuilder()\n+        // It checks if the node parent has required primary type as \"nt:hierarchyNode\"\n+        // and then skip it as the node has already been processed by parent node\n+        if(isRequiredHierarchyChildNode(jcrNode)) {","path":"grabbit/src/main/groovy/com/twcable/grabbit/server/batch/steps/jcrnodes/JcrNodesProcessor.groovy","position":32,"original_position":32,"commit_id":"c3a4bc668d0f8f45ec3e395d378eae5bfa5e1b1c","original_commit_id":"c3a4bc668d0f8f45ec3e395d378eae5bfa5e1b1c","user":{"login":"sikarwarvimal","id":11965519,"avatar_url":"https://avatars.githubusercontent.com/u/11965519?v=3","gravatar_id":"","url":"https://api.github.com/users/sikarwarvimal","html_url":"https://github.com/sikarwarvimal","followers_url":"https://api.github.com/users/sikarwarvimal/followers","following_url":"https://api.github.com/users/sikarwarvimal/following{/other_user}","gists_url":"https://api.github.com/users/sikarwarvimal/gists{/gist_id}","starred_url":"https://api.github.com/users/sikarwarvimal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sikarwarvimal/subscriptions","organizations_url":"https://api.github.com/users/sikarwarvimal/orgs","repos_url":"https://api.github.com/users/sikarwarvimal/repos","events_url":"https://api.github.com/users/sikarwarvimal/events{/privacy}","received_events_url":"https://api.github.com/users/sikarwarvimal/received_events","type":"User","site_admin":false},"body":"You are mixing two things together `what it is, and does`. What `it is` refers to `Structural design patterns` and what `it does` is a `Behavioral design patterns`. Decorator pattern is a `Structural design pattern` which `Add responsibilities to objects dynamically`.","created_at":"2015-07-22T19:33:50Z","updated_at":"2015-07-22T19:33:50Z","html_url":"https://github.com/TWCable/grabbit/pull/49#discussion_r35253678","pull_request_url":"https://api.github.com/repos/TWCable/grabbit/pulls/49","_links":{"self":{"href":"https://api.github.com/repos/TWCable/grabbit/pulls/comments/35253678"},"html":{"href":"https://github.com/TWCable/grabbit/pull/49#discussion_r35253678"},"pull_request":{"href":"https://api.github.com/repos/TWCable/grabbit/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/TWCable/grabbit/pulls/49","id":40509249,"html_url":"https://github.com/TWCable/grabbit/pull/49","diff_url":"https://github.com/TWCable/grabbit/pull/49.diff","patch_url":"https://github.com/TWCable/grabbit/pull/49.patch","issue_url":"https://api.github.com/repos/TWCable/grabbit/issues/49","number":49,"state":"open","locked":false,"title":"NT Hierarchy node logic including required nodes with new Node structure","user":{"login":"sikarwarvimal","id":11965519,"avatar_url":"https://avatars.githubusercontent.com/u/11965519?v=3","gravatar_id":"","url":"https://api.github.com/users/sikarwarvimal","html_url":"https://github.com/sikarwarvimal","followers_url":"https://api.github.com/users/sikarwarvimal/followers","following_url":"https://api.github.com/users/sikarwarvimal/following{/other_user}","gists_url":"https://api.github.com/users/sikarwarvimal/gists{/gist_id}","starred_url":"https://api.github.com/users/sikarwarvimal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sikarwarvimal/subscriptions","organizations_url":"https://api.github.com/users/sikarwarvimal/orgs","repos_url":"https://api.github.com/users/sikarwarvimal/repos","events_url":"https://api.github.com/users/sikarwarvimal/events{/privacy}","received_events_url":"https://api.github.com/users/sikarwarvimal/received_events","type":"User","site_admin":false},"body":"Logic to process nt:hierarchy nodes with required child node has beed added. To process the given scenario `Node` proto structure has been modified.\r\n\r\nThis PR is ready for review and testing.\r\n\r\nTest Scenario:\r\nIdentify any hierarchal node type like `nt:file` and try to sync that node and the sync will process the `nt:file` node and the required child node `jcr:content` as one transaction.\r\n\r\n@jdigger @jbornemann @sagarsane @masroormohammed","created_at":"2015-07-21T21:53:19Z","updated_at":"2015-07-22T19:33:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7601ec34d320ce371c65efa5fe8988a3c8a5d739","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TWCable/grabbit/pulls/49/commits","review_comments_url":"https://api.github.com/repos/TWCable/grabbit/pulls/49/comments","review_comment_url":"https://api.github.com/repos/TWCable/grabbit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TWCable/grabbit/issues/49/comments","statuses_url":"https://api.github.com/repos/TWCable/grabbit/statuses/c3a4bc668d0f8f45ec3e395d378eae5bfa5e1b1c","head":{"label":"TWCable:grabit_17331_nt_hierarchy_fix","ref":"grabit_17331_nt_hierarchy_fix","sha":"c3a4bc668d0f8f45ec3e395d378eae5bfa5e1b1c","user":{"login":"TWCable","id":10778149,"avatar_url":"https://avatars.githubusercontent.com/u/10778149?v=3","gravatar_id":"","url":"https://api.github.com/users/TWCable","html_url":"https://github.com/TWCable","followers_url":"https://api.github.com/users/TWCable/followers","following_url":"https://api.github.com/users/TWCable/following{/other_user}","gists_url":"https://api.github.com/users/TWCable/gists{/gist_id}","starred_url":"https://api.github.com/users/TWCable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TWCable/subscriptions","organizations_url":"https://api.github.com/users/TWCable/orgs","repos_url":"https://api.github.com/users/TWCable/repos","events_url":"https://api.github.com/users/TWCable/events{/privacy}","received_events_url":"https://api.github.com/users/TWCable/received_events","type":"Organization","site_admin":false},"repo":{"id":31395930,"name":"grabbit","full_name":"TWCable/grabbit","owner":{"login":"TWCable","id":10778149,"avatar_url":"https://avatars.githubusercontent.com/u/10778149?v=3","gravatar_id":"","url":"https://api.github.com/users/TWCable","html_url":"https://github.com/TWCable","followers_url":"https://api.github.com/users/TWCable/followers","following_url":"https://api.github.com/users/TWCable/following{/other_user}","gists_url":"https://api.github.com/users/TWCable/gists{/gist_id}","starred_url":"https://api.github.com/users/TWCable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TWCable/subscriptions","organizations_url":"https://api.github.com/users/TWCable/orgs","repos_url":"https://api.github.com/users/TWCable/repos","events_url":"https://api.github.com/users/TWCable/events{/privacy}","received_events_url":"https://api.github.com/users/TWCable/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TWCable/grabbit","description":"Grabbit - Fast Content Sync tool for AEM/CQ","fork":false,"url":"https://api.github.com/repos/TWCable/grabbit","forks_url":"https://api.github.com/repos/TWCable/grabbit/forks","keys_url":"https://api.github.com/repos/TWCable/grabbit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TWCable/grabbit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TWCable/grabbit/teams","hooks_url":"https://api.github.com/repos/TWCable/grabbit/hooks","issue_events_url":"https://api.github.com/repos/TWCable/grabbit/issues/events{/number}","events_url":"https://api.github.com/repos/TWCable/grabbit/events","assignees_url":"https://api.github.com/repos/TWCable/grabbit/assignees{/user}","branches_url":"https://api.github.com/repos/TWCable/grabbit/branches{/branch}","tags_url":"https://api.github.com/repos/TWCable/grabbit/tags","blobs_url":"https://api.github.com/repos/TWCable/grabbit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TWCable/grabbit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TWCable/grabbit/git/refs{/sha}","trees_url":"https://api.github.com/repos/TWCable/grabbit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TWCable/grabbit/statuses/{sha}","languages_url":"https://api.github.com/repos/TWCable/grabbit/languages","stargazers_url":"https://api.github.com/repos/TWCable/grabbit/stargazers","contributors_url":"https://api.github.com/repos/TWCable/grabbit/contributors","subscribers_url":"https://api.github.com/repos/TWCable/grabbit/subscribers","subscription_url":"https://api.github.com/repos/TWCable/grabbit/subscription","commits_url":"https://api.github.com/repos/TWCable/grabbit/commits{/sha}","git_commits_url":"https://api.github.com/repos/TWCable/grabbit/git/commits{/sha}","comments_url":"https://api.github.com/repos/TWCable/grabbit/comments{/number}","issue_comment_url":"https://api.github.com/repos/TWCable/grabbit/issues/comments{/number}","contents_url":"https://api.github.com/repos/TWCable/grabbit/contents/{+path}","compare_url":"https://api.github.com/repos/TWCable/grabbit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TWCable/grabbit/merges","archive_url":"https://api.github.com/repos/TWCable/grabbit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TWCable/grabbit/downloads","issues_url":"https://api.github.com/repos/TWCable/grabbit/issues{/number}","pulls_url":"https://api.github.com/repos/TWCable/grabbit/pulls{/number}","milestones_url":"https://api.github.com/repos/TWCable/grabbit/milestones{/number}","notifications_url":"https://api.github.com/repos/TWCable/grabbit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TWCable/grabbit/labels{/name}","releases_url":"https://api.github.com/repos/TWCable/grabbit/releases{/id}","created_at":"2015-02-27T00:24:35Z","updated_at":"2015-07-21T19:07:00Z","pushed_at":"2015-07-22T15:15:42Z","git_url":"git://github.com/TWCable/grabbit.git","ssh_url":"git@github.com:TWCable/grabbit.git","clone_url":"https://github.com/TWCable/grabbit.git","svn_url":"https://github.com/TWCable/grabbit","homepage":"","size":1131,"stargazers_count":25,"watchers_count":25,"language":"Groovy","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":32,"forks":7,"open_issues":32,"watchers":25,"default_branch":"master"}},"base":{"label":"TWCable:master","ref":"master","sha":"4ea25348f79c1ba16b750765adbe7d385601920a","user":{"login":"TWCable","id":10778149,"avatar_url":"https://avatars.githubusercontent.com/u/10778149?v=3","gravatar_id":"","url":"https://api.github.com/users/TWCable","html_url":"https://github.com/TWCable","followers_url":"https://api.github.com/users/TWCable/followers","following_url":"https://api.github.com/users/TWCable/following{/other_user}","gists_url":"https://api.github.com/users/TWCable/gists{/gist_id}","starred_url":"https://api.github.com/users/TWCable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TWCable/subscriptions","organizations_url":"https://api.github.com/users/TWCable/orgs","repos_url":"https://api.github.com/users/TWCable/repos","events_url":"https://api.github.com/users/TWCable/events{/privacy}","received_events_url":"https://api.github.com/users/TWCable/received_events","type":"Organization","site_admin":false},"repo":{"id":31395930,"name":"grabbit","full_name":"TWCable/grabbit","owner":{"login":"TWCable","id":10778149,"avatar_url":"https://avatars.githubusercontent.com/u/10778149?v=3","gravatar_id":"","url":"https://api.github.com/users/TWCable","html_url":"https://github.com/TWCable","followers_url":"https://api.github.com/users/TWCable/followers","following_url":"https://api.github.com/users/TWCable/following{/other_user}","gists_url":"https://api.github.com/users/TWCable/gists{/gist_id}","starred_url":"https://api.github.com/users/TWCable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TWCable/subscriptions","organizations_url":"https://api.github.com/users/TWCable/orgs","repos_url":"https://api.github.com/users/TWCable/repos","events_url":"https://api.github.com/users/TWCable/events{/privacy}","received_events_url":"https://api.github.com/users/TWCable/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TWCable/grabbit","description":"Grabbit - Fast Content Sync tool for AEM/CQ","fork":false,"url":"https://api.github.com/repos/TWCable/grabbit","forks_url":"https://api.github.com/repos/TWCable/grabbit/forks","keys_url":"https://api.github.com/repos/TWCable/grabbit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TWCable/grabbit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TWCable/grabbit/teams","hooks_url":"https://api.github.com/repos/TWCable/grabbit/hooks","issue_events_url":"https://api.github.com/repos/TWCable/grabbit/issues/events{/number}","events_url":"https://api.github.com/repos/TWCable/grabbit/events","assignees_url":"https://api.github.com/repos/TWCable/grabbit/assignees{/user}","branches_url":"https://api.github.com/repos/TWCable/grabbit/branches{/branch}","tags_url":"https://api.github.com/repos/TWCable/grabbit/tags","blobs_url":"https://api.github.com/repos/TWCable/grabbit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TWCable/grabbit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TWCable/grabbit/git/refs{/sha}","trees_url":"https://api.github.com/repos/TWCable/grabbit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TWCable/grabbit/statuses/{sha}","languages_url":"https://api.github.com/repos/TWCable/grabbit/languages","stargazers_url":"https://api.github.com/repos/TWCable/grabbit/stargazers","contributors_url":"https://api.github.com/repos/TWCable/grabbit/contributors","subscribers_url":"https://api.github.com/repos/TWCable/grabbit/subscribers","subscription_url":"https://api.github.com/repos/TWCable/grabbit/subscription","commits_url":"https://api.github.com/repos/TWCable/grabbit/commits{/sha}","git_commits_url":"https://api.github.com/repos/TWCable/grabbit/git/commits{/sha}","comments_url":"https://api.github.com/repos/TWCable/grabbit/comments{/number}","issue_comment_url":"https://api.github.com/repos/TWCable/grabbit/issues/comments{/number}","contents_url":"https://api.github.com/repos/TWCable/grabbit/contents/{+path}","compare_url":"https://api.github.com/repos/TWCable/grabbit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TWCable/grabbit/merges","archive_url":"https://api.github.com/repos/TWCable/grabbit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TWCable/grabbit/downloads","issues_url":"https://api.github.com/repos/TWCable/grabbit/issues{/number}","pulls_url":"https://api.github.com/repos/TWCable/grabbit/pulls{/number}","milestones_url":"https://api.github.com/repos/TWCable/grabbit/milestones{/number}","notifications_url":"https://api.github.com/repos/TWCable/grabbit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TWCable/grabbit/labels{/name}","releases_url":"https://api.github.com/repos/TWCable/grabbit/releases{/id}","created_at":"2015-02-27T00:24:35Z","updated_at":"2015-07-21T19:07:00Z","pushed_at":"2015-07-22T15:15:42Z","git_url":"git://github.com/TWCable/grabbit.git","ssh_url":"git@github.com:TWCable/grabbit.git","clone_url":"https://github.com/TWCable/grabbit.git","svn_url":"https://github.com/TWCable/grabbit","homepage":"","size":1131,"stargazers_count":25,"watchers_count":25,"language":"Groovy","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":32,"forks":7,"open_issues":32,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TWCable/grabbit/pulls/49"},"html":{"href":"https://github.com/TWCable/grabbit/pull/49"},"issue":{"href":"https://api.github.com/repos/TWCable/grabbit/issues/49"},"comments":{"href":"https://api.github.com/repos/TWCable/grabbit/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/TWCable/grabbit/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/TWCable/grabbit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TWCable/grabbit/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/TWCable/grabbit/statuses/c3a4bc668d0f8f45ec3e395d378eae5bfa5e1b1c"}}}}