{"action":"created","comment":{"url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/pulls/comments/28919374","id":28919374,"diff_hunk":"@@ -0,0 +1,85 @@\n+# encoding: UTF-8\n+#\n+# Copyright 2014, Christoph Hartmann\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+#     http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+\n+require 'spec_helper'\n+\n+describe 'jenkins-hardening::proxy' do\n+\n+  # converge\n+  cached(:chef_run) do\n+    ChefSpec::SoloRunner.new do |node|\n+      node.automatic['root_group'] = 'root'\n+    end.converge(described_recipe)\n+  end\n+\n+  before do\n+    stub_command('which nginx').and_return(true)","path":"spec/recipes/proxy_spec.rb","position":29,"original_position":29,"commit_id":"8a48f59f70bcf42ae3119debb730927621e8e9de","original_commit_id":"8a48f59f70bcf42ae3119debb730927621e8e9de","user":{"login":"chris-rock","id":1178413,"avatar_url":"https://avatars.githubusercontent.com/u/1178413?v=3","gravatar_id":"","url":"https://api.github.com/users/chris-rock","html_url":"https://github.com/chris-rock","followers_url":"https://api.github.com/users/chris-rock/followers","following_url":"https://api.github.com/users/chris-rock/following{/other_user}","gists_url":"https://api.github.com/users/chris-rock/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-rock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-rock/subscriptions","organizations_url":"https://api.github.com/users/chris-rock/orgs","repos_url":"https://api.github.com/users/chris-rock/repos","events_url":"https://api.github.com/users/chris-rock/events{/privacy}","received_events_url":"https://api.github.com/users/chris-rock/received_events","type":"User","site_admin":false},"body":"does this work as a standalone test? the cached chef-spec run does not include the required ssl databag.","created_at":"2015-04-22T22:02:59Z","updated_at":"2015-04-22T22:02:59Z","html_url":"https://github.com/hardening-io/chef-jenkins-hardening/pull/6#discussion_r28919374","pull_request_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/pulls/comments/28919374"},"html":{"href":"https://github.com/hardening-io/chef-jenkins-hardening/pull/6#discussion_r28919374"},"pull_request":{"href":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/pulls/6","id":33873100,"html_url":"https://github.com/hardening-io/chef-jenkins-hardening/pull/6","diff_url":"https://github.com/hardening-io/chef-jenkins-hardening/pull/6.diff","patch_url":"https://github.com/hardening-io/chef-jenkins-hardening/pull/6.patch","issue_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/issues/6","number":6,"state":"open","locked":false,"title":"First draft at testing","user":{"login":"Rockstar04","id":641721,"avatar_url":"https://avatars.githubusercontent.com/u/641721?v=3","gravatar_id":"","url":"https://api.github.com/users/Rockstar04","html_url":"https://github.com/Rockstar04","followers_url":"https://api.github.com/users/Rockstar04/followers","following_url":"https://api.github.com/users/Rockstar04/following{/other_user}","gists_url":"https://api.github.com/users/Rockstar04/gists{/gist_id}","starred_url":"https://api.github.com/users/Rockstar04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rockstar04/subscriptions","organizations_url":"https://api.github.com/users/Rockstar04/orgs","repos_url":"https://api.github.com/users/Rockstar04/repos","events_url":"https://api.github.com/users/Rockstar04/events{/privacy}","received_events_url":"https://api.github.com/users/Rockstar04/received_events","type":"User","site_admin":false},"body":"This is a first pass, and i'm sure not a very solid one, I spent a ton of time looking into stubbing to even get these tests to pass.\r\n\r\nI am unsure how to go about testing the [jenkins plugin loop](https://github.com/hardening-io/chef-jenkins-hardening/blob/master/recipes/jenkins.rb#L23-L26) so the current test coverage comes out as very low.\r\n\r\nWhile striving for consistency in test specs I also addressed issue #3 ","created_at":"2015-04-22T15:58:47Z","updated_at":"2015-04-22T22:02:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a412dcc7f6dd05e35ec30af9d79321e4a791a18","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/pulls/6/commits","review_comments_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/pulls/6/comments","review_comment_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/issues/6/comments","statuses_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/statuses/8a48f59f70bcf42ae3119debb730927621e8e9de","head":{"label":"Rockstar04:fork/testing","ref":"fork/testing","sha":"8a48f59f70bcf42ae3119debb730927621e8e9de","user":{"login":"Rockstar04","id":641721,"avatar_url":"https://avatars.githubusercontent.com/u/641721?v=3","gravatar_id":"","url":"https://api.github.com/users/Rockstar04","html_url":"https://github.com/Rockstar04","followers_url":"https://api.github.com/users/Rockstar04/followers","following_url":"https://api.github.com/users/Rockstar04/following{/other_user}","gists_url":"https://api.github.com/users/Rockstar04/gists{/gist_id}","starred_url":"https://api.github.com/users/Rockstar04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rockstar04/subscriptions","organizations_url":"https://api.github.com/users/Rockstar04/orgs","repos_url":"https://api.github.com/users/Rockstar04/repos","events_url":"https://api.github.com/users/Rockstar04/events{/privacy}","received_events_url":"https://api.github.com/users/Rockstar04/received_events","type":"User","site_admin":false},"repo":{"id":33730461,"name":"chef-jenkins-hardening","full_name":"Rockstar04/chef-jenkins-hardening","owner":{"login":"Rockstar04","id":641721,"avatar_url":"https://avatars.githubusercontent.com/u/641721?v=3","gravatar_id":"","url":"https://api.github.com/users/Rockstar04","html_url":"https://github.com/Rockstar04","followers_url":"https://api.github.com/users/Rockstar04/followers","following_url":"https://api.github.com/users/Rockstar04/following{/other_user}","gists_url":"https://api.github.com/users/Rockstar04/gists{/gist_id}","starred_url":"https://api.github.com/users/Rockstar04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rockstar04/subscriptions","organizations_url":"https://api.github.com/users/Rockstar04/orgs","repos_url":"https://api.github.com/users/Rockstar04/repos","events_url":"https://api.github.com/users/Rockstar04/events{/privacy}","received_events_url":"https://api.github.com/users/Rockstar04/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Rockstar04/chef-jenkins-hardening","description":"A secure jenkins installation","fork":true,"url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening","forks_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/forks","keys_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/teams","hooks_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/hooks","issue_events_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/issues/events{/number}","events_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/events","assignees_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/assignees{/user}","branches_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/branches{/branch}","tags_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/tags","blobs_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/statuses/{sha}","languages_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/languages","stargazers_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/stargazers","contributors_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/contributors","subscribers_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/subscribers","subscription_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/subscription","commits_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/contents/{+path}","compare_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/merges","archive_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/downloads","issues_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/issues{/number}","pulls_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/pulls{/number}","milestones_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/milestones{/number}","notifications_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/labels{/name}","releases_url":"https://api.github.com/repos/Rockstar04/chef-jenkins-hardening/releases{/id}","created_at":"2015-04-10T13:40:50Z","updated_at":"2015-04-10T13:40:51Z","pushed_at":"2015-04-22T15:55:23Z","git_url":"git://github.com/Rockstar04/chef-jenkins-hardening.git","ssh_url":"git@github.com:Rockstar04/chef-jenkins-hardening.git","clone_url":"https://github.com/Rockstar04/chef-jenkins-hardening.git","svn_url":"https://github.com/Rockstar04/chef-jenkins-hardening","homepage":"http://telekomlabs.github.io/","size":156,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hardening-io:master","ref":"master","sha":"b66664b187807985167a3f92a5d8c3aa82dd09d3","user":{"login":"hardening-io","id":11883542,"avatar_url":"https://avatars.githubusercontent.com/u/11883542?v=3","gravatar_id":"","url":"https://api.github.com/users/hardening-io","html_url":"https://github.com/hardening-io","followers_url":"https://api.github.com/users/hardening-io/followers","following_url":"https://api.github.com/users/hardening-io/following{/other_user}","gists_url":"https://api.github.com/users/hardening-io/gists{/gist_id}","starred_url":"https://api.github.com/users/hardening-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hardening-io/subscriptions","organizations_url":"https://api.github.com/users/hardening-io/orgs","repos_url":"https://api.github.com/users/hardening-io/repos","events_url":"https://api.github.com/users/hardening-io/events{/privacy}","received_events_url":"https://api.github.com/users/hardening-io/received_events","type":"Organization","site_admin":false},"repo":{"id":20880279,"name":"chef-jenkins-hardening","full_name":"hardening-io/chef-jenkins-hardening","owner":{"login":"hardening-io","id":11883542,"avatar_url":"https://avatars.githubusercontent.com/u/11883542?v=3","gravatar_id":"","url":"https://api.github.com/users/hardening-io","html_url":"https://github.com/hardening-io","followers_url":"https://api.github.com/users/hardening-io/followers","following_url":"https://api.github.com/users/hardening-io/following{/other_user}","gists_url":"https://api.github.com/users/hardening-io/gists{/gist_id}","starred_url":"https://api.github.com/users/hardening-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hardening-io/subscriptions","organizations_url":"https://api.github.com/users/hardening-io/orgs","repos_url":"https://api.github.com/users/hardening-io/repos","events_url":"https://api.github.com/users/hardening-io/events{/privacy}","received_events_url":"https://api.github.com/users/hardening-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hardening-io/chef-jenkins-hardening","description":"A secure jenkins installation","fork":false,"url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening","forks_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/forks","keys_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/teams","hooks_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/hooks","issue_events_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/issues/events{/number}","events_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/events","assignees_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/assignees{/user}","branches_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/branches{/branch}","tags_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/tags","blobs_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/git/refs{/sha}","trees_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/statuses/{sha}","languages_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/languages","stargazers_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/stargazers","contributors_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/contributors","subscribers_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/subscribers","subscription_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/subscription","commits_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/commits{/sha}","git_commits_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/git/commits{/sha}","comments_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/comments{/number}","issue_comment_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/issues/comments{/number}","contents_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/contents/{+path}","compare_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/merges","archive_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/downloads","issues_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/issues{/number}","pulls_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/pulls{/number}","milestones_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/milestones{/number}","notifications_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/labels{/name}","releases_url":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/releases{/id}","created_at":"2014-06-16T09:57:12Z","updated_at":"2015-04-21T14:07:31Z","pushed_at":"2015-04-22T15:58:48Z","git_url":"git://github.com/hardening-io/chef-jenkins-hardening.git","ssh_url":"git@github.com:hardening-io/chef-jenkins-hardening.git","clone_url":"https://github.com/hardening-io/chef-jenkins-hardening.git","svn_url":"https://github.com/hardening-io/chef-jenkins-hardening","homepage":"http://telekomlabs.github.io/","size":205,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/pulls/6"},"html":{"href":"https://github.com/hardening-io/chef-jenkins-hardening/pull/6"},"issue":{"href":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/issues/6"},"comments":{"href":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/hardening-io/chef-jenkins-hardening/statuses/8a48f59f70bcf42ae3119debb730927621e8e9de"}}}}