{"action":"opened","number":662,"pull_request":{"url":"https://api.github.com/repos/non/cats/pulls/662","id":50813788,"html_url":"https://github.com/non/cats/pull/662","diff_url":"https://github.com/non/cats/pull/662.diff","patch_url":"https://github.com/non/cats/pull/662.patch","issue_url":"https://api.github.com/repos/non/cats/issues/662","number":662,"state":"open","locked":false,"title":"DO NOT MERGE: repeat evaluation with Streaming.memoize","user":{"login":"ceedubs","id":977929,"avatar_url":"https://avatars.githubusercontent.com/u/977929?v=3","gravatar_id":"","url":"https://api.github.com/users/ceedubs","html_url":"https://github.com/ceedubs","followers_url":"https://api.github.com/users/ceedubs/followers","following_url":"https://api.github.com/users/ceedubs/following{/other_user}","gists_url":"https://api.github.com/users/ceedubs/gists{/gist_id}","starred_url":"https://api.github.com/users/ceedubs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceedubs/subscriptions","organizations_url":"https://api.github.com/users/ceedubs/orgs","repos_url":"https://api.github.com/users/ceedubs/repos","events_url":"https://api.github.com/users/ceedubs/events{/privacy}","received_events_url":"https://api.github.com/users/ceedubs/received_events","type":"User","site_admin":false},"body":"This is a potential bug report and is not meant to be merged in its\r\ncurrent form.\r\n\r\nThis test fails. It attempts to check that if a `Streaming` instance is\r\ncreated via `.memoize`, then its elements won't be evaluated multiple\r\ntimes (such as when `.toList` is called).\r\n\r\nOne could argue that this is a bogus test case, since side effects\r\nshould be tracked in a type other than `Unit`. However, I believe that\r\nthis means that we might be evaluating arguments overly-eagerly, which\r\nis a problem in itself.\r\n\r\nI made a naive attempt at fixing this by making `Streaming.map` a little\r\nlazier in the `Cons` case, but that didn't seem to do the trick.\r\n\r\n@non do you have any thoughts?","created_at":"2015-11-16T14:07:49Z","updated_at":"2015-11-16T14:07:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/non/cats/pulls/662/commits","review_comments_url":"https://api.github.com/repos/non/cats/pulls/662/comments","review_comment_url":"https://api.github.com/repos/non/cats/pulls/comments{/number}","comments_url":"https://api.github.com/repos/non/cats/issues/662/comments","statuses_url":"https://api.github.com/repos/non/cats/statuses/378d52c98022b78b067ccc85e886e2bc1cd4ac71","head":{"label":"ceedubs:streaming-memoize","ref":"streaming-memoize","sha":"378d52c98022b78b067ccc85e886e2bc1cd4ac71","user":{"login":"ceedubs","id":977929,"avatar_url":"https://avatars.githubusercontent.com/u/977929?v=3","gravatar_id":"","url":"https://api.github.com/users/ceedubs","html_url":"https://github.com/ceedubs","followers_url":"https://api.github.com/users/ceedubs/followers","following_url":"https://api.github.com/users/ceedubs/following{/other_user}","gists_url":"https://api.github.com/users/ceedubs/gists{/gist_id}","starred_url":"https://api.github.com/users/ceedubs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceedubs/subscriptions","organizations_url":"https://api.github.com/users/ceedubs/orgs","repos_url":"https://api.github.com/users/ceedubs/repos","events_url":"https://api.github.com/users/ceedubs/events{/privacy}","received_events_url":"https://api.github.com/users/ceedubs/received_events","type":"User","site_admin":false},"repo":{"id":30243911,"name":"cats","full_name":"ceedubs/cats","owner":{"login":"ceedubs","id":977929,"avatar_url":"https://avatars.githubusercontent.com/u/977929?v=3","gravatar_id":"","url":"https://api.github.com/users/ceedubs","html_url":"https://github.com/ceedubs","followers_url":"https://api.github.com/users/ceedubs/followers","following_url":"https://api.github.com/users/ceedubs/following{/other_user}","gists_url":"https://api.github.com/users/ceedubs/gists{/gist_id}","starred_url":"https://api.github.com/users/ceedubs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceedubs/subscriptions","organizations_url":"https://api.github.com/users/ceedubs/orgs","repos_url":"https://api.github.com/users/ceedubs/repos","events_url":"https://api.github.com/users/ceedubs/events{/privacy}","received_events_url":"https://api.github.com/users/ceedubs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ceedubs/cats","description":"","fork":true,"url":"https://api.github.com/repos/ceedubs/cats","forks_url":"https://api.github.com/repos/ceedubs/cats/forks","keys_url":"https://api.github.com/repos/ceedubs/cats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceedubs/cats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceedubs/cats/teams","hooks_url":"https://api.github.com/repos/ceedubs/cats/hooks","issue_events_url":"https://api.github.com/repos/ceedubs/cats/issues/events{/number}","events_url":"https://api.github.com/repos/ceedubs/cats/events","assignees_url":"https://api.github.com/repos/ceedubs/cats/assignees{/user}","branches_url":"https://api.github.com/repos/ceedubs/cats/branches{/branch}","tags_url":"https://api.github.com/repos/ceedubs/cats/tags","blobs_url":"https://api.github.com/repos/ceedubs/cats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceedubs/cats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceedubs/cats/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceedubs/cats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceedubs/cats/statuses/{sha}","languages_url":"https://api.github.com/repos/ceedubs/cats/languages","stargazers_url":"https://api.github.com/repos/ceedubs/cats/stargazers","contributors_url":"https://api.github.com/repos/ceedubs/cats/contributors","subscribers_url":"https://api.github.com/repos/ceedubs/cats/subscribers","subscription_url":"https://api.github.com/repos/ceedubs/cats/subscription","commits_url":"https://api.github.com/repos/ceedubs/cats/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceedubs/cats/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceedubs/cats/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceedubs/cats/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceedubs/cats/contents/{+path}","compare_url":"https://api.github.com/repos/ceedubs/cats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceedubs/cats/merges","archive_url":"https://api.github.com/repos/ceedubs/cats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceedubs/cats/downloads","issues_url":"https://api.github.com/repos/ceedubs/cats/issues{/number}","pulls_url":"https://api.github.com/repos/ceedubs/cats/pulls{/number}","milestones_url":"https://api.github.com/repos/ceedubs/cats/milestones{/number}","notifications_url":"https://api.github.com/repos/ceedubs/cats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceedubs/cats/labels{/name}","releases_url":"https://api.github.com/repos/ceedubs/cats/releases{/id}","created_at":"2015-02-03T13:27:21Z","updated_at":"2015-05-03T19:40:44Z","pushed_at":"2015-11-16T14:06:44Z","git_url":"git://github.com/ceedubs/cats.git","ssh_url":"git@github.com:ceedubs/cats.git","clone_url":"https://github.com/ceedubs/cats.git","svn_url":"https://github.com/ceedubs/cats","homepage":null,"size":2015,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"non:master","ref":"master","sha":"f4db3c4588e8bca7a9316fdb02ed809b40fc3aac","user":{"login":"non","id":218045,"avatar_url":"https://avatars.githubusercontent.com/u/218045?v=3","gravatar_id":"","url":"https://api.github.com/users/non","html_url":"https://github.com/non","followers_url":"https://api.github.com/users/non/followers","following_url":"https://api.github.com/users/non/following{/other_user}","gists_url":"https://api.github.com/users/non/gists{/gist_id}","starred_url":"https://api.github.com/users/non/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/non/subscriptions","organizations_url":"https://api.github.com/users/non/orgs","repos_url":"https://api.github.com/users/non/repos","events_url":"https://api.github.com/users/non/events{/privacy}","received_events_url":"https://api.github.com/users/non/received_events","type":"User","site_admin":false},"repo":{"id":29986727,"name":"cats","full_name":"non/cats","owner":{"login":"non","id":218045,"avatar_url":"https://avatars.githubusercontent.com/u/218045?v=3","gravatar_id":"","url":"https://api.github.com/users/non","html_url":"https://github.com/non","followers_url":"https://api.github.com/users/non/followers","following_url":"https://api.github.com/users/non/following{/other_user}","gists_url":"https://api.github.com/users/non/gists{/gist_id}","starred_url":"https://api.github.com/users/non/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/non/subscriptions","organizations_url":"https://api.github.com/users/non/orgs","repos_url":"https://api.github.com/users/non/repos","events_url":"https://api.github.com/users/non/events{/privacy}","received_events_url":"https://api.github.com/users/non/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/non/cats","description":"Lightweight, modular, and extensible library for functional programming.","fork":false,"url":"https://api.github.com/repos/non/cats","forks_url":"https://api.github.com/repos/non/cats/forks","keys_url":"https://api.github.com/repos/non/cats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/non/cats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/non/cats/teams","hooks_url":"https://api.github.com/repos/non/cats/hooks","issue_events_url":"https://api.github.com/repos/non/cats/issues/events{/number}","events_url":"https://api.github.com/repos/non/cats/events","assignees_url":"https://api.github.com/repos/non/cats/assignees{/user}","branches_url":"https://api.github.com/repos/non/cats/branches{/branch}","tags_url":"https://api.github.com/repos/non/cats/tags","blobs_url":"https://api.github.com/repos/non/cats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/non/cats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/non/cats/git/refs{/sha}","trees_url":"https://api.github.com/repos/non/cats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/non/cats/statuses/{sha}","languages_url":"https://api.github.com/repos/non/cats/languages","stargazers_url":"https://api.github.com/repos/non/cats/stargazers","contributors_url":"https://api.github.com/repos/non/cats/contributors","subscribers_url":"https://api.github.com/repos/non/cats/subscribers","subscription_url":"https://api.github.com/repos/non/cats/subscription","commits_url":"https://api.github.com/repos/non/cats/commits{/sha}","git_commits_url":"https://api.github.com/repos/non/cats/git/commits{/sha}","comments_url":"https://api.github.com/repos/non/cats/comments{/number}","issue_comment_url":"https://api.github.com/repos/non/cats/issues/comments{/number}","contents_url":"https://api.github.com/repos/non/cats/contents/{+path}","compare_url":"https://api.github.com/repos/non/cats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/non/cats/merges","archive_url":"https://api.github.com/repos/non/cats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/non/cats/downloads","issues_url":"https://api.github.com/repos/non/cats/issues{/number}","pulls_url":"https://api.github.com/repos/non/cats/pulls{/number}","milestones_url":"https://api.github.com/repos/non/cats/milestones{/number}","notifications_url":"https://api.github.com/repos/non/cats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/non/cats/labels{/name}","releases_url":"https://api.github.com/repos/non/cats/releases{/id}","created_at":"2015-01-28T20:26:48Z","updated_at":"2015-11-16T11:23:37Z","pushed_at":"2015-11-16T13:37:16Z","git_url":"git://github.com/non/cats.git","ssh_url":"git@github.com:non/cats.git","clone_url":"https://github.com/non/cats.git","svn_url":"https://github.com/non/cats","homepage":"http://non.github.io/cats/","size":10051,"stargazers_count":703,"watchers_count":703,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":136,"mirror_url":null,"open_issues_count":88,"forks":136,"open_issues":88,"watchers":703,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/non/cats/pulls/662"},"html":{"href":"https://github.com/non/cats/pull/662"},"issue":{"href":"https://api.github.com/repos/non/cats/issues/662"},"comments":{"href":"https://api.github.com/repos/non/cats/issues/662/comments"},"review_comments":{"href":"https://api.github.com/repos/non/cats/pulls/662/comments"},"review_comment":{"href":"https://api.github.com/repos/non/cats/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/non/cats/pulls/662/commits"},"statuses":{"href":"https://api.github.com/repos/non/cats/statuses/378d52c98022b78b067ccc85e886e2bc1cd4ac71"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":12,"deletions":0,"changed_files":1}}