{"action":"created","issue":{"url":"https://api.github.com/repos/jupyter/notebook/issues/540","labels_url":"https://api.github.com/repos/jupyter/notebook/issues/540/labels{/name}","comments_url":"https://api.github.com/repos/jupyter/notebook/issues/540/comments","events_url":"https://api.github.com/repos/jupyter/notebook/issues/540/events","html_url":"https://github.com/jupyter/notebook/issues/540","id":110269806,"number":540,"title":"Build command broken on Windows","user":{"login":"sccolbert","id":137289,"avatar_url":"https://avatars.githubusercontent.com/u/137289?v=3","gravatar_id":"","url":"https://api.github.com/users/sccolbert","html_url":"https://github.com/sccolbert","followers_url":"https://api.github.com/users/sccolbert/followers","following_url":"https://api.github.com/users/sccolbert/following{/other_user}","gists_url":"https://api.github.com/users/sccolbert/gists{/gist_id}","starred_url":"https://api.github.com/users/sccolbert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sccolbert/subscriptions","organizations_url":"https://api.github.com/users/sccolbert/orgs","repos_url":"https://api.github.com/users/sccolbert/repos","events_url":"https://api.github.com/users/sccolbert/events{/privacy}","received_events_url":"https://api.github.com/users/sccolbert/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jupyter/notebook/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/jupyter/notebook/milestones/4","html_url":"https://github.com/jupyter/notebook/milestones/4.1","labels_url":"https://api.github.com/repos/jupyter/notebook/milestones/4/labels","id":1204376,"number":4,"title":"4.1","description":null,"creator":{"login":"minrk","id":151929,"avatar_url":"https://avatars.githubusercontent.com/u/151929?v=3","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":133,"state":"open","created_at":"2015-07-13T02:35:55Z","updated_at":"2015-10-08T09:48:41Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2015-10-07T16:51:41Z","updated_at":"2015-10-08T09:50:06Z","closed_at":null,"body":"Running `setup.py build` on Windows breaks on the CSS command. This is due to excessive quoting of the command by the `run` function.\r\n\r\n[This change](https://github.com/jupyter/notebook/commit/f175b2391ae468de39831e65674012c9543b0ccb) introduced an extra level of quoting to all commands. \r\n\r\nOn Windows, the `lessc` command list looks like the following:\r\n\r\n```\r\n['lessc', '--source-map', \"--include-path='E:\\\\Development\\\\sccolbert\\\\notebook\\\\notebook\\\\static'\", 'E:\\\\Development\\\\sccolbert\\\\notebook\\\\notebook\\\\static\\\\style\\\\ipython.less', 'E:\\\\Development\\\\sccolbert\\\\notebook\\\\notebook\\\\static\\\\style\\\\ipython.min.css']\r\n```\r\n\r\nWhich would be valid if joined with spaces. But with the extra quoting, the command is invalid on Windows:\r\n\r\n```\r\nlessc --source-map '--include-path='\"'\"'E:\\Development\\sccolbert\\notebook\\notebook\\static'\"'\"'' 'E:\\Development\\sccolbert\\notebook\\notebook\\static\\style\\ipython.less' 'E:\\Development\\sccolbert\\notebook\\notebook\\static\\style\\ipython.min.css'\r\n```\r\n\r\nThe [docs](https://docs.python.org/2/library/pipes.html#pipes.quote) for `pipes.quote` indicate that the quoting is only compatible with Unix shells.\r\n\r\nOn my machine, doing a simple space-join is sufficient to fix the breakage. But, I'm not sure if this will cause breakage on other platforms.\r\n\r\npinging @jdfreder @minrk "},"comment":{"url":"https://api.github.com/repos/jupyter/notebook/issues/comments/146477019","html_url":"https://github.com/jupyter/notebook/issues/540#issuecomment-146477019","issue_url":"https://api.github.com/repos/jupyter/notebook/issues/540","id":146477019,"user":{"login":"minrk","id":151929,"avatar_url":"https://avatars.githubusercontent.com/u/151929?v=3","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"created_at":"2015-10-08T09:50:06Z","updated_at":"2015-10-08T09:50:06Z","body":"Fixed by #550"}}