{"action":"created","issue":{"url":"https://api.github.com/repos/ReactiveX/RxJava/issues/3157","labels_url":"https://api.github.com/repos/ReactiveX/RxJava/issues/3157/labels{/name}","comments_url":"https://api.github.com/repos/ReactiveX/RxJava/issues/3157/comments","events_url":"https://api.github.com/repos/ReactiveX/RxJava/issues/3157/events","html_url":"https://github.com/ReactiveX/RxJava/issues/3157","id":101087961,"number":3157,"title":"Committer Merge Policy","user":{"login":"benjchristensen","id":813492,"avatar_url":"https://avatars.githubusercontent.com/u/813492?v=3","gravatar_id":"","url":"https://api.github.com/users/benjchristensen","html_url":"https://github.com/benjchristensen","followers_url":"https://api.github.com/users/benjchristensen/followers","following_url":"https://api.github.com/users/benjchristensen/following{/other_user}","gists_url":"https://api.github.com/users/benjchristensen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjchristensen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjchristensen/subscriptions","organizations_url":"https://api.github.com/users/benjchristensen/orgs","repos_url":"https://api.github.com/users/benjchristensen/repos","events_url":"https://api.github.com/users/benjchristensen/events{/privacy}","received_events_url":"https://api.github.com/users/benjchristensen/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ReactiveX/RxJava/labels/Discussion","name":"Discussion","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2015-08-14T19:34:02Z","updated_at":"2015-09-04T01:40:31Z","closed_at":null,"body":"Thus far there have been so few committers that we haven't had a formal policy, mostly just an arrangement between @akarnokd and myself. As per https://github.com/ReactiveX/RxJava/issues/3145 we are seeking to increase the number of people involved in reviewing pull requests and thus will end up with more people merging changes.\r\n\r\nI don't want to over police this, but I do think we should formalize to having at least a :+1: from another committer before any pull request is merged that affects code in /src/main. \r\n\r\nExceptions that do not require a :+1: would be:\r\n\r\n- javadoc changes\r\n- unit test additions or refactoring\r\n- perf test additions, fixes or refactoring\r\n- grammatical and presentation fixes to README, CONTRIBUTING, and other such metadata files\r\n\r\nThings that do require a :+1: would be:\r\n\r\n- any code changes to /src/main that would affect running applications\r\n- unit test changes that affect behavior being tested\r\n- changes to README, CONTRIBUTING, LICENSE, etc that affect meaning of the document\r\n- changes to build or release\r\n\r\nThoughts? Agreement? Disagreement?\r\n\r\n/cc @ReactiveX/rxjava-committers "},"comment":{"url":"https://api.github.com/repos/ReactiveX/RxJava/issues/comments/137621173","html_url":"https://github.com/ReactiveX/RxJava/issues/3157#issuecomment-137621173","issue_url":"https://api.github.com/repos/ReactiveX/RxJava/issues/3157","id":137621173,"user":{"login":"davidmoten","id":318187,"avatar_url":"https://avatars.githubusercontent.com/u/318187?v=3","gravatar_id":"","url":"https://api.github.com/users/davidmoten","html_url":"https://github.com/davidmoten","followers_url":"https://api.github.com/users/davidmoten/followers","following_url":"https://api.github.com/users/davidmoten/following{/other_user}","gists_url":"https://api.github.com/users/davidmoten/gists{/gist_id}","starred_url":"https://api.github.com/users/davidmoten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidmoten/subscriptions","organizations_url":"https://api.github.com/users/davidmoten/orgs","repos_url":"https://api.github.com/users/davidmoten/repos","events_url":"https://api.github.com/users/davidmoten/events{/privacy}","received_events_url":"https://api.github.com/users/davidmoten/received_events","type":"User","site_admin":false},"created_at":"2015-09-04T01:40:31Z","updated_at":"2015-09-04T01:40:31Z","body":"No point in reviewing till unit tests in and passing and all of this action is on the 2.x branch. Might have to wait till a big chunk goes in then review?\r\n\r\nCan I suggest that all PRs associated with v2 have a title prefixed with v2? That way I can filter them mentally when I look at email notifications from github or the abbreviated github combination issues/pr view. I realize that these PRs have been assigned as Milestone 2.0 but that is only useful when using the github PRs ui."}}