{"action":"created","comment":{"url":"https://api.github.com/repos/Astron/Astron/pulls/comments/25961695","id":25961695,"diff_hunk":"@@ -3028,5 +3038,29 @@ def test_get_network_address(self):\n \n         self.server.send(Datagram.create_remove_channel(10052))\n \n+    def test_heartbeat_timeout(self):\n+        # Test the interest timeout\n+        self.server.flush()\n+        client = self.connect(port = 51201)\n+        id = self.identify(client)\n+\n+        # Bring client out of the sandbox\n+        self.set_state(client, CLIENT_STATE_ESTABLISHED)\n+\n+        # Send a heartbeat\n+        dg = Datagram()\n+        dg.add_uint16(CLIENT_HEARTBEAT)\n+        client.send(dg)\n+\n+        # The client shouldn't hear anything back.\n+        self.expectNone(client)\n+\n+        time.sleep(0.75)","path":"test/test_clientagent.py","position":38,"original_position":38,"commit_id":"9e72baac1c32bbcc2cfbba965a3bca4ce91fbbaa","original_commit_id":"9e72baac1c32bbcc2cfbba965a3bca4ce91fbbaa","user":{"login":"CFSworks","id":700768,"avatar_url":"https://avatars.githubusercontent.com/u/700768?v=3","gravatar_id":"","url":"https://api.github.com/users/CFSworks","html_url":"https://github.com/CFSworks","followers_url":"https://api.github.com/users/CFSworks/followers","following_url":"https://api.github.com/users/CFSworks/following{/other_user}","gists_url":"https://api.github.com/users/CFSworks/gists{/gist_id}","starred_url":"https://api.github.com/users/CFSworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CFSworks/subscriptions","organizations_url":"https://api.github.com/users/CFSworks/orgs","repos_url":"https://api.github.com/users/CFSworks/repos","events_url":"https://api.github.com/users/CFSworks/events{/privacy}","received_events_url":"https://api.github.com/users/CFSworks/received_events","type":"User","site_admin":false},"body":"How does this test pass? heartbeat_timeout is 1000. We should *not* be disconnected after only 0.75s (= 750 ms) of waiting.","created_at":"2015-03-06T17:38:23Z","updated_at":"2015-03-06T17:38:23Z","html_url":"https://github.com/Astron/Astron/pull/328#discussion_r25961695","pull_request_url":"https://api.github.com/repos/Astron/Astron/pulls/328","_links":{"self":{"href":"https://api.github.com/repos/Astron/Astron/pulls/comments/25961695"},"html":{"href":"https://github.com/Astron/Astron/pull/328#discussion_r25961695"},"pull_request":{"href":"https://api.github.com/repos/Astron/Astron/pulls/328"}}},"pull_request":{"url":"https://api.github.com/repos/Astron/Astron/pulls/328","id":30620293,"html_url":"https://github.com/Astron/Astron/pull/328","diff_url":"https://github.com/Astron/Astron/pull/328.diff","patch_url":"https://github.com/Astron/Astron/pull/328.patch","issue_url":"https://api.github.com/repos/Astron/Astron/issues/328","number":328,"state":"open","locked":false,"title":"Add Heartbeat Timeout Capabilities in Client Agent","user":{"login":"AlJaMa","id":171453,"avatar_url":"https://avatars.githubusercontent.com/u/171453?v=3","gravatar_id":"","url":"https://api.github.com/users/AlJaMa","html_url":"https://github.com/AlJaMa","followers_url":"https://api.github.com/users/AlJaMa/followers","following_url":"https://api.github.com/users/AlJaMa/following{/other_user}","gists_url":"https://api.github.com/users/AlJaMa/gists{/gist_id}","starred_url":"https://api.github.com/users/AlJaMa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlJaMa/subscriptions","organizations_url":"https://api.github.com/users/AlJaMa/orgs","repos_url":"https://api.github.com/users/AlJaMa/repos","events_url":"https://api.github.com/users/AlJaMa/events{/privacy}","received_events_url":"https://api.github.com/users/AlJaMa/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-03-06T04:28:05Z","updated_at":"2015-03-06T17:38:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ba9a54b7e3edc85d53a94e848e6f7dfd519569c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Astron/Astron/pulls/328/commits","review_comments_url":"https://api.github.com/repos/Astron/Astron/pulls/328/comments","review_comment_url":"https://api.github.com/repos/Astron/Astron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Astron/Astron/issues/328/comments","statuses_url":"https://api.github.com/repos/Astron/Astron/statuses/9e72baac1c32bbcc2cfbba965a3bca4ce91fbbaa","head":{"label":"Astron:feature/client-heartbeat","ref":"feature/client-heartbeat","sha":"9e72baac1c32bbcc2cfbba965a3bca4ce91fbbaa","user":{"login":"Astron","id":5342720,"avatar_url":"https://avatars.githubusercontent.com/u/5342720?v=3","gravatar_id":"","url":"https://api.github.com/users/Astron","html_url":"https://github.com/Astron","followers_url":"https://api.github.com/users/Astron/followers","following_url":"https://api.github.com/users/Astron/following{/other_user}","gists_url":"https://api.github.com/users/Astron/gists{/gist_id}","starred_url":"https://api.github.com/users/Astron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Astron/subscriptions","organizations_url":"https://api.github.com/users/Astron/orgs","repos_url":"https://api.github.com/users/Astron/repos","events_url":"https://api.github.com/users/Astron/events{/privacy}","received_events_url":"https://api.github.com/users/Astron/received_events","type":"Organization","site_admin":false},"repo":{"id":12473497,"name":"Astron","full_name":"Astron/Astron","owner":{"login":"Astron","id":5342720,"avatar_url":"https://avatars.githubusercontent.com/u/5342720?v=3","gravatar_id":"","url":"https://api.github.com/users/Astron","html_url":"https://github.com/Astron","followers_url":"https://api.github.com/users/Astron/followers","following_url":"https://api.github.com/users/Astron/following{/other_user}","gists_url":"https://api.github.com/users/Astron/gists{/gist_id}","starred_url":"https://api.github.com/users/Astron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Astron/subscriptions","organizations_url":"https://api.github.com/users/Astron/orgs","repos_url":"https://api.github.com/users/Astron/repos","events_url":"https://api.github.com/users/Astron/events{/privacy}","received_events_url":"https://api.github.com/users/Astron/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Astron/Astron","description":"A Server Technology for Realtime Object Networking","fork":false,"url":"https://api.github.com/repos/Astron/Astron","forks_url":"https://api.github.com/repos/Astron/Astron/forks","keys_url":"https://api.github.com/repos/Astron/Astron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Astron/Astron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Astron/Astron/teams","hooks_url":"https://api.github.com/repos/Astron/Astron/hooks","issue_events_url":"https://api.github.com/repos/Astron/Astron/issues/events{/number}","events_url":"https://api.github.com/repos/Astron/Astron/events","assignees_url":"https://api.github.com/repos/Astron/Astron/assignees{/user}","branches_url":"https://api.github.com/repos/Astron/Astron/branches{/branch}","tags_url":"https://api.github.com/repos/Astron/Astron/tags","blobs_url":"https://api.github.com/repos/Astron/Astron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Astron/Astron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Astron/Astron/git/refs{/sha}","trees_url":"https://api.github.com/repos/Astron/Astron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Astron/Astron/statuses/{sha}","languages_url":"https://api.github.com/repos/Astron/Astron/languages","stargazers_url":"https://api.github.com/repos/Astron/Astron/stargazers","contributors_url":"https://api.github.com/repos/Astron/Astron/contributors","subscribers_url":"https://api.github.com/repos/Astron/Astron/subscribers","subscription_url":"https://api.github.com/repos/Astron/Astron/subscription","commits_url":"https://api.github.com/repos/Astron/Astron/commits{/sha}","git_commits_url":"https://api.github.com/repos/Astron/Astron/git/commits{/sha}","comments_url":"https://api.github.com/repos/Astron/Astron/comments{/number}","issue_comment_url":"https://api.github.com/repos/Astron/Astron/issues/comments{/number}","contents_url":"https://api.github.com/repos/Astron/Astron/contents/{+path}","compare_url":"https://api.github.com/repos/Astron/Astron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Astron/Astron/merges","archive_url":"https://api.github.com/repos/Astron/Astron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Astron/Astron/downloads","issues_url":"https://api.github.com/repos/Astron/Astron/issues{/number}","pulls_url":"https://api.github.com/repos/Astron/Astron/pulls{/number}","milestones_url":"https://api.github.com/repos/Astron/Astron/milestones{/number}","notifications_url":"https://api.github.com/repos/Astron/Astron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Astron/Astron/labels{/name}","releases_url":"https://api.github.com/repos/Astron/Astron/releases{/id}","created_at":"2013-08-29T23:32:58Z","updated_at":"2015-02-23T04:28:50Z","pushed_at":"2015-03-06T05:17:06Z","git_url":"git://github.com/Astron/Astron.git","ssh_url":"git@github.com:Astron/Astron.git","clone_url":"https://github.com/Astron/Astron.git","svn_url":"https://github.com/Astron/Astron","homepage":"https://astron.github.io/astron","size":9060,"stargazers_count":60,"watchers_count":60,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":32,"forks":27,"open_issues":32,"watchers":60,"default_branch":"master"}},"base":{"label":"Astron:develop","ref":"develop","sha":"1b577588ae9ec601809b722e50e05034c44634dd","user":{"login":"Astron","id":5342720,"avatar_url":"https://avatars.githubusercontent.com/u/5342720?v=3","gravatar_id":"","url":"https://api.github.com/users/Astron","html_url":"https://github.com/Astron","followers_url":"https://api.github.com/users/Astron/followers","following_url":"https://api.github.com/users/Astron/following{/other_user}","gists_url":"https://api.github.com/users/Astron/gists{/gist_id}","starred_url":"https://api.github.com/users/Astron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Astron/subscriptions","organizations_url":"https://api.github.com/users/Astron/orgs","repos_url":"https://api.github.com/users/Astron/repos","events_url":"https://api.github.com/users/Astron/events{/privacy}","received_events_url":"https://api.github.com/users/Astron/received_events","type":"Organization","site_admin":false},"repo":{"id":12473497,"name":"Astron","full_name":"Astron/Astron","owner":{"login":"Astron","id":5342720,"avatar_url":"https://avatars.githubusercontent.com/u/5342720?v=3","gravatar_id":"","url":"https://api.github.com/users/Astron","html_url":"https://github.com/Astron","followers_url":"https://api.github.com/users/Astron/followers","following_url":"https://api.github.com/users/Astron/following{/other_user}","gists_url":"https://api.github.com/users/Astron/gists{/gist_id}","starred_url":"https://api.github.com/users/Astron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Astron/subscriptions","organizations_url":"https://api.github.com/users/Astron/orgs","repos_url":"https://api.github.com/users/Astron/repos","events_url":"https://api.github.com/users/Astron/events{/privacy}","received_events_url":"https://api.github.com/users/Astron/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Astron/Astron","description":"A Server Technology for Realtime Object Networking","fork":false,"url":"https://api.github.com/repos/Astron/Astron","forks_url":"https://api.github.com/repos/Astron/Astron/forks","keys_url":"https://api.github.com/repos/Astron/Astron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Astron/Astron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Astron/Astron/teams","hooks_url":"https://api.github.com/repos/Astron/Astron/hooks","issue_events_url":"https://api.github.com/repos/Astron/Astron/issues/events{/number}","events_url":"https://api.github.com/repos/Astron/Astron/events","assignees_url":"https://api.github.com/repos/Astron/Astron/assignees{/user}","branches_url":"https://api.github.com/repos/Astron/Astron/branches{/branch}","tags_url":"https://api.github.com/repos/Astron/Astron/tags","blobs_url":"https://api.github.com/repos/Astron/Astron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Astron/Astron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Astron/Astron/git/refs{/sha}","trees_url":"https://api.github.com/repos/Astron/Astron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Astron/Astron/statuses/{sha}","languages_url":"https://api.github.com/repos/Astron/Astron/languages","stargazers_url":"https://api.github.com/repos/Astron/Astron/stargazers","contributors_url":"https://api.github.com/repos/Astron/Astron/contributors","subscribers_url":"https://api.github.com/repos/Astron/Astron/subscribers","subscription_url":"https://api.github.com/repos/Astron/Astron/subscription","commits_url":"https://api.github.com/repos/Astron/Astron/commits{/sha}","git_commits_url":"https://api.github.com/repos/Astron/Astron/git/commits{/sha}","comments_url":"https://api.github.com/repos/Astron/Astron/comments{/number}","issue_comment_url":"https://api.github.com/repos/Astron/Astron/issues/comments{/number}","contents_url":"https://api.github.com/repos/Astron/Astron/contents/{+path}","compare_url":"https://api.github.com/repos/Astron/Astron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Astron/Astron/merges","archive_url":"https://api.github.com/repos/Astron/Astron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Astron/Astron/downloads","issues_url":"https://api.github.com/repos/Astron/Astron/issues{/number}","pulls_url":"https://api.github.com/repos/Astron/Astron/pulls{/number}","milestones_url":"https://api.github.com/repos/Astron/Astron/milestones{/number}","notifications_url":"https://api.github.com/repos/Astron/Astron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Astron/Astron/labels{/name}","releases_url":"https://api.github.com/repos/Astron/Astron/releases{/id}","created_at":"2013-08-29T23:32:58Z","updated_at":"2015-02-23T04:28:50Z","pushed_at":"2015-03-06T05:17:06Z","git_url":"git://github.com/Astron/Astron.git","ssh_url":"git@github.com:Astron/Astron.git","clone_url":"https://github.com/Astron/Astron.git","svn_url":"https://github.com/Astron/Astron","homepage":"https://astron.github.io/astron","size":9060,"stargazers_count":60,"watchers_count":60,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":32,"forks":27,"open_issues":32,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Astron/Astron/pulls/328"},"html":{"href":"https://github.com/Astron/Astron/pull/328"},"issue":{"href":"https://api.github.com/repos/Astron/Astron/issues/328"},"comments":{"href":"https://api.github.com/repos/Astron/Astron/issues/328/comments"},"review_comments":{"href":"https://api.github.com/repos/Astron/Astron/pulls/328/comments"},"review_comment":{"href":"https://api.github.com/repos/Astron/Astron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Astron/Astron/pulls/328/commits"},"statuses":{"href":"https://api.github.com/repos/Astron/Astron/statuses/9e72baac1c32bbcc2cfbba965a3bca4ce91fbbaa"}}}}