{"action":"created","issue":{"url":"https://api.github.com/repos/fxos-components/fxos-switch/issues/13","labels_url":"https://api.github.com/repos/fxos-components/fxos-switch/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/fxos-components/fxos-switch/issues/13/comments","events_url":"https://api.github.com/repos/fxos-components/fxos-switch/issues/13/events","html_url":"https://github.com/fxos-components/fxos-switch/issues/13","id":90876333,"number":13,"title":"Change gaia-switch to accept a label as a slot","user":{"login":"KevinGrandon","id":122602,"avatar_url":"https://avatars.githubusercontent.com/u/122602?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinGrandon","html_url":"https://github.com/KevinGrandon","followers_url":"https://api.github.com/users/KevinGrandon/followers","following_url":"https://api.github.com/users/KevinGrandon/following{/other_user}","gists_url":"https://api.github.com/users/KevinGrandon/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinGrandon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinGrandon/subscriptions","organizations_url":"https://api.github.com/users/KevinGrandon/orgs","repos_url":"https://api.github.com/users/KevinGrandon/repos","events_url":"https://api.github.com/users/KevinGrandon/events{/privacy}","received_events_url":"https://api.github.com/users/KevinGrandon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-06-25T07:01:32Z","updated_at":"2015-12-09T15:23:14Z","closed_at":null,"body":"Currently you can't click on labels to toggle the switch, and you should be able to do so.\r\n\r\nThe current gaia-switch component in gaia shared/ passes in the label to the component, and is a nicer way of going about things I think: https://github.com/mozilla-b2g/gaia/blob/540701791684cc527dccc9b7f1d4b694c7ce296f/apps/ftu/index.html#L262\r\n\r\nThis also works in pretty much every use case that we have for switches in gaia."},"comment":{"url":"https://api.github.com/repos/fxos-components/fxos-switch/issues/comments/163289245","html_url":"https://github.com/fxos-components/fxos-switch/issues/13#issuecomment-163289245","issue_url":"https://api.github.com/repos/fxos-components/fxos-switch/issues/13","id":163289245,"user":{"login":"KevinGrandon","id":122602,"avatar_url":"https://avatars.githubusercontent.com/u/122602?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinGrandon","html_url":"https://github.com/KevinGrandon","followers_url":"https://api.github.com/users/KevinGrandon/followers","following_url":"https://api.github.com/users/KevinGrandon/following{/other_user}","gists_url":"https://api.github.com/users/KevinGrandon/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinGrandon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinGrandon/subscriptions","organizations_url":"https://api.github.com/users/KevinGrandon/orgs","repos_url":"https://api.github.com/users/KevinGrandon/repos","events_url":"https://api.github.com/users/KevinGrandon/events{/privacy}","received_events_url":"https://api.github.com/users/KevinGrandon/received_events","type":"User","site_admin":false},"created_at":"2015-12-09T15:23:14Z","updated_at":"2015-12-09T15:23:14Z","body":"@wilsonpage - In order to easily port gaia-components I think we need a drop-in replacement for the existing gaia-switch (and other components), being used. It could either be this component, or potentially a new component. Here's a few ideas:\r\n\r\nOption 1: Make fxos-switch accept a label, like:\r\n```\r\n<fxos-switch>\r\n  <label>My Label</label>\r\n</fxos-switch>\r\n```\r\n\r\nOption 2: Create a new \"fxos-switch-row\". This could be an external component.\r\n```\r\n<fxos-switch-row>\r\n  <label>My Label</label>\r\n  <details>Some details here</details>\r\n</fxos-switch-row>\r\n```\r\n\r\nOption 3: Continue to use <gaia-switch> inside of gaia, and update it to extend or include the <fxos-switch>.  This could work, but I do think that we should only have one switch implementation inside of gaia, and currently almost every switch spans across the entire row.\r\n\r\nRe-opening this to get ideas, but maybe the work will happen in a different repo. Thoughts?"}}