{"action":"created","issue":{"url":"https://api.github.com/repos/jvilk/BrowserFS/issues/109","labels_url":"https://api.github.com/repos/jvilk/BrowserFS/issues/109/labels{/name}","comments_url":"https://api.github.com/repos/jvilk/BrowserFS/issues/109/comments","events_url":"https://api.github.com/repos/jvilk/BrowserFS/issues/109/events","html_url":"https://github.com/jvilk/BrowserFS/pull/109","id":82370891,"number":109,"title":"Build browserfs.js with Browserify.","user":{"login":"timdream","id":93093,"avatar_url":"https://avatars.githubusercontent.com/u/93093?v=3","gravatar_id":"","url":"https://api.github.com/users/timdream","html_url":"https://github.com/timdream","followers_url":"https://api.github.com/users/timdream/followers","following_url":"https://api.github.com/users/timdream/following{/other_user}","gists_url":"https://api.github.com/users/timdream/gists{/gist_id}","starred_url":"https://api.github.com/users/timdream/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timdream/subscriptions","organizations_url":"https://api.github.com/users/timdream/orgs","repos_url":"https://api.github.com/users/timdream/repos","events_url":"https://api.github.com/users/timdream/events{/privacy}","received_events_url":"https://api.github.com/users/timdream/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-05-29T10:30:17Z","updated_at":"2015-05-30T09:43:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jvilk/BrowserFS/pulls/109","html_url":"https://github.com/jvilk/BrowserFS/pull/109","diff_url":"https://github.com/jvilk/BrowserFS/pull/109.diff","patch_url":"https://github.com/jvilk/BrowserFS/pull/109.patch"},"body":"This is currently broken because of lack of mikefrey/grunt-exorcise#12. I've also found that running `grunt` alone will no longer get bower package installed.\n\nI've verified this patch works by executing the following commands\n\n```\nnpm i\n./node_modules/.bin/bower install\ncd ./node_modules/grunt-exorcise/ && npm i -D exorcist@0.4 && cd -\ngrunt\n```\n\nThe generated file is slightly smaller unminified but a bit larger minified.\n\n```\n$ ls -l dist/\n-rw-r--r--  1 timdream  staff  450334 May 24 00:55 browserfs.js\n-rw-r--r--  1 timdream  staff  512053 May 24 00:55 browserfs.js.map\n-rw-r--r--  1 timdream  staff  138016 May 24 00:55 browserfs.min.js\n-rw-r--r--  1 timdream  staff  587035 May 24 00:55 browserfs.min.js.map\n\n$ ls -l build/release/\n-rw-r--r--  1 timdream  staff  448613 May 29 18:14 browserfs.js\n-rw-r--r--  1 timdream  staff  519373 May 29 18:14 browserfs.js.map\n-rw-r--r--  1 timdream  staff  150666 May 29 18:14 browserfs.min.js\n-rw-r--r--  1 timdream  staff  719307 May 29 18:14 browserfs.min.js.map\n```\n\nBut hey, they are UMD'd so this solves #107.\n\nAs of the source maps, they still points to the JavaScript files generated from TypeScript just like the current sourece map. There are set-ups out there claiming we should be able to map directly into `.ts` file, but I haven't try it. Probably can be done in another follow-up pull request.\n\nThe remaining issue to work on this pull request is to ensure karma still runs. I am so far unable to make it work on my machine (w/ or w/o the patch) so I can't verify that, yet."},"comment":{"url":"https://api.github.com/repos/jvilk/BrowserFS/issues/comments/107017103","html_url":"https://github.com/jvilk/BrowserFS/pull/109#issuecomment-107017103","issue_url":"https://api.github.com/repos/jvilk/BrowserFS/issues/109","id":107017103,"user":{"login":"timdream","id":93093,"avatar_url":"https://avatars.githubusercontent.com/u/93093?v=3","gravatar_id":"","url":"https://api.github.com/users/timdream","html_url":"https://github.com/timdream","followers_url":"https://api.github.com/users/timdream/followers","following_url":"https://api.github.com/users/timdream/following{/other_user}","gists_url":"https://api.github.com/users/timdream/gists{/gist_id}","starred_url":"https://api.github.com/users/timdream/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timdream/subscriptions","organizations_url":"https://api.github.com/users/timdream/orgs","repos_url":"https://api.github.com/users/timdream/repos","events_url":"https://api.github.com/users/timdream/events{/privacy}","received_events_url":"https://api.github.com/users/timdream/received_events","type":"User","site_admin":false},"created_at":"2015-05-30T09:43:27Z","updated_at":"2015-05-30T09:43:27Z","body":"A new commit attached and verified `grunt test` works.\r\n\r\nI realized all the tests are written in AMD and are being loaded by karma without any transform. I am reluctant to invest more time figuring out how to convert these tests from AMD nor do manual conversion of all tests, so I am restoring how require.js is used in tests.\r\n\r\nThis pull request now introduce browserify, remove r.js (the require.js propressor) but did not remove require.js. I wonder if we are complicating things too much..."}}