{"action":"created","issue":{"url":"https://api.github.com/repos/influxdb/influxdb/issues/3384","labels_url":"https://api.github.com/repos/influxdb/influxdb/issues/3384/labels{/name}","comments_url":"https://api.github.com/repos/influxdb/influxdb/issues/3384/comments","events_url":"https://api.github.com/repos/influxdb/influxdb/issues/3384/events","html_url":"https://github.com/influxdb/influxdb/pull/3384","id":95846755,"number":3384,"title":"One Query Executor to rule them all","user":{"login":"otoolep","id":536312,"avatar_url":"https://avatars.githubusercontent.com/u/536312?v=3","gravatar_id":"","url":"https://api.github.com/users/otoolep","html_url":"https://github.com/otoolep","followers_url":"https://api.github.com/users/otoolep/followers","following_url":"https://api.github.com/users/otoolep/following{/other_user}","gists_url":"https://api.github.com/users/otoolep/gists{/gist_id}","starred_url":"https://api.github.com/users/otoolep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otoolep/subscriptions","organizations_url":"https://api.github.com/users/otoolep/orgs","repos_url":"https://api.github.com/users/otoolep/repos","events_url":"https://api.github.com/users/otoolep/events{/privacy}","received_events_url":"https://api.github.com/users/otoolep/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-07-18T18:17:58Z","updated_at":"2015-07-18T20:23:12Z","closed_at":"2015-07-18T19:48:38Z","pull_request":{"url":"https://api.github.com/repos/influxdb/influxdb/pulls/3384","html_url":"https://github.com/influxdb/influxdb/pull/3384","diff_url":"https://github.com/influxdb/influxdb/pull/3384.diff","patch_url":"https://github.com/influxdb/influxdb/pull/3384.patch"},"body":"This change significantly simplifies query executor code. Before this change there were two types of executors -- `RawExecutor` and `AggregateExecutor`. These two types only differed in *one function* `Execute()`. Otherwise all other methods on the Executors were common and duplicated between executors.\r\n\r\nThis change merges the two executors into a single type called, wait for it, `Executor` and simply switches `execute()` functions depending on the statement type. The core query engine code has not changed, this simply merges and deletes a bunch of duplicated code."},"comment":{"url":"https://api.github.com/repos/influxdb/influxdb/issues/comments/122591505","html_url":"https://github.com/influxdb/influxdb/pull/3384#issuecomment-122591505","issue_url":"https://api.github.com/repos/influxdb/influxdb/issues/3384","id":122591505,"user":{"login":"dgnorton","id":209347,"avatar_url":"https://avatars.githubusercontent.com/u/209347?v=3","gravatar_id":"","url":"https://api.github.com/users/dgnorton","html_url":"https://github.com/dgnorton","followers_url":"https://api.github.com/users/dgnorton/followers","following_url":"https://api.github.com/users/dgnorton/following{/other_user}","gists_url":"https://api.github.com/users/dgnorton/gists{/gist_id}","starred_url":"https://api.github.com/users/dgnorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgnorton/subscriptions","organizations_url":"https://api.github.com/users/dgnorton/orgs","repos_url":"https://api.github.com/users/dgnorton/repos","events_url":"https://api.github.com/users/dgnorton/events{/privacy}","received_events_url":"https://api.github.com/users/dgnorton/received_events","type":"User","site_admin":false},"created_at":"2015-07-18T20:23:12Z","updated_at":"2015-07-18T20:23:12Z","body":"+1"}}