{"action":"created","comment":{"url":"https://api.github.com/repos/OSVR/OSVR-Core/pulls/comments/43386862","id":43386862,"diff_hunk":"@@ -78,6 +75,18 @@ namespace vbtracker {\n     typedef std::vector<LedGroup> LedGroupList;\n     typedef std::vector<EstimatorPtr> EstimatorList;\n     /// @}\n+\n+    /// Container for the information needed to define a sensor,\n+    /// both the patterns of its beacons and their 3D spatial coordinates.\n+    typedef struct {\n+      PatternStringList patterns;\n+      Point3Vector positions;\n+      size_t requiredInliers;\n+      size_t permittedOutliers;\n+    } SensorDescription;","path":"plugins/videobasedtracker/Types.h","position":26,"original_position":26,"commit_id":"e659a3f2ec3ba895fba9b5ca4c59e2c4ccedebf3","original_commit_id":"e659a3f2ec3ba895fba9b5ca4c59e2c4ccedebf3","user":{"login":"russell-taylor","id":762320,"avatar_url":"https://avatars.githubusercontent.com/u/762320?v=3","gravatar_id":"","url":"https://api.github.com/users/russell-taylor","html_url":"https://github.com/russell-taylor","followers_url":"https://api.github.com/users/russell-taylor/followers","following_url":"https://api.github.com/users/russell-taylor/following{/other_user}","gists_url":"https://api.github.com/users/russell-taylor/gists{/gist_id}","starred_url":"https://api.github.com/users/russell-taylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russell-taylor/subscriptions","organizations_url":"https://api.github.com/users/russell-taylor/orgs","repos_url":"https://api.github.com/users/russell-taylor/repos","events_url":"https://api.github.com/users/russell-taylor/events{/privacy}","received_events_url":"https://api.github.com/users/russell-taylor/received_events","type":"User","site_admin":false},"body":"That also compiled fine, so I changed it.","created_at":"2015-10-29T13:57:10Z","updated_at":"2015-10-29T13:57:10Z","html_url":"https://github.com/OSVR/OSVR-Core/pull/251#discussion_r43386862","pull_request_url":"https://api.github.com/repos/OSVR/OSVR-Core/pulls/251","_links":{"self":{"href":"https://api.github.com/repos/OSVR/OSVR-Core/pulls/comments/43386862"},"html":{"href":"https://github.com/OSVR/OSVR-Core/pull/251#discussion_r43386862"},"pull_request":{"href":"https://api.github.com/repos/OSVR/OSVR-Core/pulls/251"}}},"pull_request":{"url":"https://api.github.com/repos/OSVR/OSVR-Core/pulls/251","id":49064149,"html_url":"https://github.com/OSVR/OSVR-Core/pull/251","diff_url":"https://github.com/OSVR/OSVR-Core/pull/251.diff","patch_url":"https://github.com/OSVR/OSVR-Core/pull/251.patch","issue_url":"https://api.github.com/repos/OSVR/OSVR-Core/issues/251","number":251,"state":"open","locked":false,"title":"Video developer info","user":{"login":"russell-taylor","id":762320,"avatar_url":"https://avatars.githubusercontent.com/u/762320?v=3","gravatar_id":"","url":"https://api.github.com/users/russell-taylor","html_url":"https://github.com/russell-taylor","followers_url":"https://api.github.com/users/russell-taylor/followers","following_url":"https://api.github.com/users/russell-taylor/following{/other_user}","gists_url":"https://api.github.com/users/russell-taylor/gists{/gist_id}","starred_url":"https://api.github.com/users/russell-taylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russell-taylor/subscriptions","organizations_url":"https://api.github.com/users/russell-taylor/orgs","repos_url":"https://api.github.com/users/russell-taylor/repos","events_url":"https://api.github.com/users/russell-taylor/events{/privacy}","received_events_url":"https://api.github.com/users/russell-taylor/received_events","type":"User","site_admin":false},"body":"This allows a config file to specify many more parameters to the algorithm.  The most significant for developers will be the ability to specify the patterns and positions of beacons for one or more sensors.  Modified the default config file to do this for the OSVR HDK.  Made a second config file that has all of the beacons (front and back) on one rigid sensor.  Wrote the developer documentation for how to add new sensors.","created_at":"2015-10-28T20:44:00Z","updated_at":"2015-10-29T13:57:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f62c12e75d9ebd83d1b5a0afc4b92476a0cf9c1b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OSVR/OSVR-Core/pulls/251/commits","review_comments_url":"https://api.github.com/repos/OSVR/OSVR-Core/pulls/251/comments","review_comment_url":"https://api.github.com/repos/OSVR/OSVR-Core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OSVR/OSVR-Core/issues/251/comments","statuses_url":"https://api.github.com/repos/OSVR/OSVR-Core/statuses/e659a3f2ec3ba895fba9b5ca4c59e2c4ccedebf3","head":{"label":"OSVR:video-developer-info","ref":"video-developer-info","sha":"e659a3f2ec3ba895fba9b5ca4c59e2c4ccedebf3","user":{"login":"OSVR","id":10343613,"avatar_url":"https://avatars.githubusercontent.com/u/10343613?v=3","gravatar_id":"","url":"https://api.github.com/users/OSVR","html_url":"https://github.com/OSVR","followers_url":"https://api.github.com/users/OSVR/followers","following_url":"https://api.github.com/users/OSVR/following{/other_user}","gists_url":"https://api.github.com/users/OSVR/gists{/gist_id}","starred_url":"https://api.github.com/users/OSVR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSVR/subscriptions","organizations_url":"https://api.github.com/users/OSVR/orgs","repos_url":"https://api.github.com/users/OSVR/repos","events_url":"https://api.github.com/users/OSVR/events{/privacy}","received_events_url":"https://api.github.com/users/OSVR/received_events","type":"Organization","site_admin":false},"repo":{"id":25528375,"name":"OSVR-Core","full_name":"OSVR/OSVR-Core","owner":{"login":"OSVR","id":10343613,"avatar_url":"https://avatars.githubusercontent.com/u/10343613?v=3","gravatar_id":"","url":"https://api.github.com/users/OSVR","html_url":"https://github.com/OSVR","followers_url":"https://api.github.com/users/OSVR/followers","following_url":"https://api.github.com/users/OSVR/following{/other_user}","gists_url":"https://api.github.com/users/OSVR/gists{/gist_id}","starred_url":"https://api.github.com/users/OSVR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSVR/subscriptions","organizations_url":"https://api.github.com/users/OSVR/orgs","repos_url":"https://api.github.com/users/OSVR/repos","events_url":"https://api.github.com/users/OSVR/events{/privacy}","received_events_url":"https://api.github.com/users/OSVR/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OSVR/OSVR-Core","description":"The core libraries, applications, and plugins of the OSVR software platform.","fork":false,"url":"https://api.github.com/repos/OSVR/OSVR-Core","forks_url":"https://api.github.com/repos/OSVR/OSVR-Core/forks","keys_url":"https://api.github.com/repos/OSVR/OSVR-Core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OSVR/OSVR-Core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OSVR/OSVR-Core/teams","hooks_url":"https://api.github.com/repos/OSVR/OSVR-Core/hooks","issue_events_url":"https://api.github.com/repos/OSVR/OSVR-Core/issues/events{/number}","events_url":"https://api.github.com/repos/OSVR/OSVR-Core/events","assignees_url":"https://api.github.com/repos/OSVR/OSVR-Core/assignees{/user}","branches_url":"https://api.github.com/repos/OSVR/OSVR-Core/branches{/branch}","tags_url":"https://api.github.com/repos/OSVR/OSVR-Core/tags","blobs_url":"https://api.github.com/repos/OSVR/OSVR-Core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OSVR/OSVR-Core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OSVR/OSVR-Core/git/refs{/sha}","trees_url":"https://api.github.com/repos/OSVR/OSVR-Core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OSVR/OSVR-Core/statuses/{sha}","languages_url":"https://api.github.com/repos/OSVR/OSVR-Core/languages","stargazers_url":"https://api.github.com/repos/OSVR/OSVR-Core/stargazers","contributors_url":"https://api.github.com/repos/OSVR/OSVR-Core/contributors","subscribers_url":"https://api.github.com/repos/OSVR/OSVR-Core/subscribers","subscription_url":"https://api.github.com/repos/OSVR/OSVR-Core/subscription","commits_url":"https://api.github.com/repos/OSVR/OSVR-Core/commits{/sha}","git_commits_url":"https://api.github.com/repos/OSVR/OSVR-Core/git/commits{/sha}","comments_url":"https://api.github.com/repos/OSVR/OSVR-Core/comments{/number}","issue_comment_url":"https://api.github.com/repos/OSVR/OSVR-Core/issues/comments{/number}","contents_url":"https://api.github.com/repos/OSVR/OSVR-Core/contents/{+path}","compare_url":"https://api.github.com/repos/OSVR/OSVR-Core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OSVR/OSVR-Core/merges","archive_url":"https://api.github.com/repos/OSVR/OSVR-Core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OSVR/OSVR-Core/downloads","issues_url":"https://api.github.com/repos/OSVR/OSVR-Core/issues{/number}","pulls_url":"https://api.github.com/repos/OSVR/OSVR-Core/pulls{/number}","milestones_url":"https://api.github.com/repos/OSVR/OSVR-Core/milestones{/number}","notifications_url":"https://api.github.com/repos/OSVR/OSVR-Core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OSVR/OSVR-Core/labels{/name}","releases_url":"https://api.github.com/repos/OSVR/OSVR-Core/releases{/id}","created_at":"2014-10-21T14:56:46Z","updated_at":"2015-10-28T01:14:57Z","pushed_at":"2015-10-28T23:31:04Z","git_url":"git://github.com/OSVR/OSVR-Core.git","ssh_url":"git@github.com:OSVR/OSVR-Core.git","clone_url":"https://github.com/OSVR/OSVR-Core.git","svn_url":"https://github.com/OSVR/OSVR-Core","homepage":"","size":18841,"stargazers_count":59,"watchers_count":59,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":114,"forks":20,"open_issues":114,"watchers":59,"default_branch":"master"}},"base":{"label":"OSVR:master","ref":"master","sha":"616d9bbea4102af5b6e4aaff2478147b863748d4","user":{"login":"OSVR","id":10343613,"avatar_url":"https://avatars.githubusercontent.com/u/10343613?v=3","gravatar_id":"","url":"https://api.github.com/users/OSVR","html_url":"https://github.com/OSVR","followers_url":"https://api.github.com/users/OSVR/followers","following_url":"https://api.github.com/users/OSVR/following{/other_user}","gists_url":"https://api.github.com/users/OSVR/gists{/gist_id}","starred_url":"https://api.github.com/users/OSVR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSVR/subscriptions","organizations_url":"https://api.github.com/users/OSVR/orgs","repos_url":"https://api.github.com/users/OSVR/repos","events_url":"https://api.github.com/users/OSVR/events{/privacy}","received_events_url":"https://api.github.com/users/OSVR/received_events","type":"Organization","site_admin":false},"repo":{"id":25528375,"name":"OSVR-Core","full_name":"OSVR/OSVR-Core","owner":{"login":"OSVR","id":10343613,"avatar_url":"https://avatars.githubusercontent.com/u/10343613?v=3","gravatar_id":"","url":"https://api.github.com/users/OSVR","html_url":"https://github.com/OSVR","followers_url":"https://api.github.com/users/OSVR/followers","following_url":"https://api.github.com/users/OSVR/following{/other_user}","gists_url":"https://api.github.com/users/OSVR/gists{/gist_id}","starred_url":"https://api.github.com/users/OSVR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSVR/subscriptions","organizations_url":"https://api.github.com/users/OSVR/orgs","repos_url":"https://api.github.com/users/OSVR/repos","events_url":"https://api.github.com/users/OSVR/events{/privacy}","received_events_url":"https://api.github.com/users/OSVR/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OSVR/OSVR-Core","description":"The core libraries, applications, and plugins of the OSVR software platform.","fork":false,"url":"https://api.github.com/repos/OSVR/OSVR-Core","forks_url":"https://api.github.com/repos/OSVR/OSVR-Core/forks","keys_url":"https://api.github.com/repos/OSVR/OSVR-Core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OSVR/OSVR-Core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OSVR/OSVR-Core/teams","hooks_url":"https://api.github.com/repos/OSVR/OSVR-Core/hooks","issue_events_url":"https://api.github.com/repos/OSVR/OSVR-Core/issues/events{/number}","events_url":"https://api.github.com/repos/OSVR/OSVR-Core/events","assignees_url":"https://api.github.com/repos/OSVR/OSVR-Core/assignees{/user}","branches_url":"https://api.github.com/repos/OSVR/OSVR-Core/branches{/branch}","tags_url":"https://api.github.com/repos/OSVR/OSVR-Core/tags","blobs_url":"https://api.github.com/repos/OSVR/OSVR-Core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OSVR/OSVR-Core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OSVR/OSVR-Core/git/refs{/sha}","trees_url":"https://api.github.com/repos/OSVR/OSVR-Core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OSVR/OSVR-Core/statuses/{sha}","languages_url":"https://api.github.com/repos/OSVR/OSVR-Core/languages","stargazers_url":"https://api.github.com/repos/OSVR/OSVR-Core/stargazers","contributors_url":"https://api.github.com/repos/OSVR/OSVR-Core/contributors","subscribers_url":"https://api.github.com/repos/OSVR/OSVR-Core/subscribers","subscription_url":"https://api.github.com/repos/OSVR/OSVR-Core/subscription","commits_url":"https://api.github.com/repos/OSVR/OSVR-Core/commits{/sha}","git_commits_url":"https://api.github.com/repos/OSVR/OSVR-Core/git/commits{/sha}","comments_url":"https://api.github.com/repos/OSVR/OSVR-Core/comments{/number}","issue_comment_url":"https://api.github.com/repos/OSVR/OSVR-Core/issues/comments{/number}","contents_url":"https://api.github.com/repos/OSVR/OSVR-Core/contents/{+path}","compare_url":"https://api.github.com/repos/OSVR/OSVR-Core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OSVR/OSVR-Core/merges","archive_url":"https://api.github.com/repos/OSVR/OSVR-Core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OSVR/OSVR-Core/downloads","issues_url":"https://api.github.com/repos/OSVR/OSVR-Core/issues{/number}","pulls_url":"https://api.github.com/repos/OSVR/OSVR-Core/pulls{/number}","milestones_url":"https://api.github.com/repos/OSVR/OSVR-Core/milestones{/number}","notifications_url":"https://api.github.com/repos/OSVR/OSVR-Core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OSVR/OSVR-Core/labels{/name}","releases_url":"https://api.github.com/repos/OSVR/OSVR-Core/releases{/id}","created_at":"2014-10-21T14:56:46Z","updated_at":"2015-10-28T01:14:57Z","pushed_at":"2015-10-28T23:31:04Z","git_url":"git://github.com/OSVR/OSVR-Core.git","ssh_url":"git@github.com:OSVR/OSVR-Core.git","clone_url":"https://github.com/OSVR/OSVR-Core.git","svn_url":"https://github.com/OSVR/OSVR-Core","homepage":"","size":18841,"stargazers_count":59,"watchers_count":59,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":114,"forks":20,"open_issues":114,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OSVR/OSVR-Core/pulls/251"},"html":{"href":"https://github.com/OSVR/OSVR-Core/pull/251"},"issue":{"href":"https://api.github.com/repos/OSVR/OSVR-Core/issues/251"},"comments":{"href":"https://api.github.com/repos/OSVR/OSVR-Core/issues/251/comments"},"review_comments":{"href":"https://api.github.com/repos/OSVR/OSVR-Core/pulls/251/comments"},"review_comment":{"href":"https://api.github.com/repos/OSVR/OSVR-Core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OSVR/OSVR-Core/pulls/251/commits"},"statuses":{"href":"https://api.github.com/repos/OSVR/OSVR-Core/statuses/e659a3f2ec3ba895fba9b5ca4c59e2c4ccedebf3"}}}}