{"action":"created","comment":{"url":"https://api.github.com/repos/mesosphere/hdfs/pulls/comments/25745569","id":25745569,"diff_hunk":"@@ -191,197 +328,93 @@ private ExecutorInfo createExecutor(String taskIdName, String nodeName, String e\n             .build());\n   }\n \n-  private void launchDataNode(SchedulerDriver driver, Offer offer) {\n-    launchNode(\n-        driver,\n-        offer,\n-        HDFSConstants.DATA_NODE_ID,\n-        Arrays.asList(HDFSConstants.DATA_NODE_ID),\n-        HDFSConstants.NODE_EXECUTOR_ID);\n-  }\n-\n-  private void launchInitialJournalNodes(SchedulerDriver driver, Collection<Offer> offers) {\n-    for (int i = 0; i < conf.getJournalNodeCount(); i++) {\n-      if (offers.size() > 0) {\n-        Offer offer = offers.iterator().next();\n-        pendingOffers.remove(offer.getId());\n-        launchNode(\n-            driver,\n-            offer,\n-            HDFSConstants.JOURNAL_NODE_ID,\n-            Arrays.asList(HDFSConstants.JOURNAL_NODE_ID),\n-            HDFSConstants.NODE_EXECUTOR_ID);\n-      }\n+  private boolean maybeLaunchJournalNode(SchedulerDriver driver, Offer offer) {","path":"src/main/java/org/apache/mesos/hdfs/Scheduler.java","position":237,"original_position":236,"commit_id":"bf5ae43908696e70e431de8ba4fad3a67e56f214","original_commit_id":"958a0d643a6659c225561c72571670249ffa7d1d","user":{"login":"nicgrayson","id":793886,"avatar_url":"https://avatars.githubusercontent.com/u/793886?v=3","gravatar_id":"","url":"https://api.github.com/users/nicgrayson","html_url":"https://github.com/nicgrayson","followers_url":"https://api.github.com/users/nicgrayson/followers","following_url":"https://api.github.com/users/nicgrayson/following{/other_user}","gists_url":"https://api.github.com/users/nicgrayson/gists{/gist_id}","starred_url":"https://api.github.com/users/nicgrayson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicgrayson/subscriptions","organizations_url":"https://api.github.com/users/nicgrayson/orgs","repos_url":"https://api.github.com/users/nicgrayson/repos","events_url":"https://api.github.com/users/nicgrayson/events{/privacy}","received_events_url":"https://api.github.com/users/nicgrayson/received_events","type":"User","site_admin":false},"body":"https://github.com/Banno/hdfs/commit/3021ba0a3beb66d52ee8ba905f1cbacf4f61094c","created_at":"2015-03-04T01:28:44Z","updated_at":"2015-03-04T01:28:44Z","html_url":"https://github.com/mesosphere/hdfs/pull/59#discussion_r25745569","pull_request_url":"https://api.github.com/repos/mesosphere/hdfs/pulls/59","_links":{"self":{"href":"https://api.github.com/repos/mesosphere/hdfs/pulls/comments/25745569"},"html":{"href":"https://github.com/mesosphere/hdfs/pull/59#discussion_r25745569"},"pull_request":{"href":"https://api.github.com/repos/mesosphere/hdfs/pulls/59"}}},"pull_request":{"url":"https://api.github.com/repos/mesosphere/hdfs/pulls/59","id":28819188,"html_url":"https://github.com/mesosphere/hdfs/pull/59","diff_url":"https://github.com/mesosphere/hdfs/pull/59.diff","patch_url":"https://github.com/mesosphere/hdfs/pull/59.patch","issue_url":"https://api.github.com/repos/mesosphere/hdfs/issues/59","number":59,"state":"closed","locked":false,"title":"Refactor status update","user":{"login":"rubbish","id":1580,"avatar_url":"https://avatars.githubusercontent.com/u/1580?v=3","gravatar_id":"","url":"https://api.github.com/users/rubbish","html_url":"https://github.com/rubbish","followers_url":"https://api.github.com/users/rubbish/followers","following_url":"https://api.github.com/users/rubbish/following{/other_user}","gists_url":"https://api.github.com/users/rubbish/gists{/gist_id}","starred_url":"https://api.github.com/users/rubbish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubbish/subscriptions","organizations_url":"https://api.github.com/users/rubbish/orgs","repos_url":"https://api.github.com/users/rubbish/repos","events_url":"https://api.github.com/users/rubbish/events{/privacy}","received_events_url":"https://api.github.com/users/rubbish/received_events","type":"User","site_admin":false},"body":"We reordered some of the scheduler as well so the public methods are up top.","created_at":"2015-02-06T16:01:47Z","updated_at":"2015-03-04T01:28:44Z","closed_at":"2015-03-04T00:08:38Z","merged_at":null,"merge_commit_sha":"94a2ef68bd23d4ca710c5073ca36f58b3fff3249","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mesosphere/hdfs/pulls/59/commits","review_comments_url":"https://api.github.com/repos/mesosphere/hdfs/pulls/59/comments","review_comment_url":"https://api.github.com/repos/mesosphere/hdfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesosphere/hdfs/issues/59/comments","statuses_url":"https://api.github.com/repos/mesosphere/hdfs/statuses/bf5ae43908696e70e431de8ba4fad3a67e56f214","head":{"label":"Banno:refactorStatusUpdate","ref":"refactorStatusUpdate","sha":"bf5ae43908696e70e431de8ba4fad3a67e56f214","user":{"login":"Banno","id":371161,"avatar_url":"https://avatars.githubusercontent.com/u/371161?v=3","gravatar_id":"","url":"https://api.github.com/users/Banno","html_url":"https://github.com/Banno","followers_url":"https://api.github.com/users/Banno/followers","following_url":"https://api.github.com/users/Banno/following{/other_user}","gists_url":"https://api.github.com/users/Banno/gists{/gist_id}","starred_url":"https://api.github.com/users/Banno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Banno/subscriptions","organizations_url":"https://api.github.com/users/Banno/orgs","repos_url":"https://api.github.com/users/Banno/repos","events_url":"https://api.github.com/users/Banno/events{/privacy}","received_events_url":"https://api.github.com/users/Banno/received_events","type":"Organization","site_admin":false},"repo":{"id":29147330,"name":"hdfs","full_name":"Banno/hdfs","owner":{"login":"Banno","id":371161,"avatar_url":"https://avatars.githubusercontent.com/u/371161?v=3","gravatar_id":"","url":"https://api.github.com/users/Banno","html_url":"https://github.com/Banno","followers_url":"https://api.github.com/users/Banno/followers","following_url":"https://api.github.com/users/Banno/following{/other_user}","gists_url":"https://api.github.com/users/Banno/gists{/gist_id}","starred_url":"https://api.github.com/users/Banno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Banno/subscriptions","organizations_url":"https://api.github.com/users/Banno/orgs","repos_url":"https://api.github.com/users/Banno/repos","events_url":"https://api.github.com/users/Banno/events{/privacy}","received_events_url":"https://api.github.com/users/Banno/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Banno/hdfs","description":"HA HDFS on Apache Mesos  ~~~  aka 'Super Available' HDFS","fork":true,"url":"https://api.github.com/repos/Banno/hdfs","forks_url":"https://api.github.com/repos/Banno/hdfs/forks","keys_url":"https://api.github.com/repos/Banno/hdfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Banno/hdfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Banno/hdfs/teams","hooks_url":"https://api.github.com/repos/Banno/hdfs/hooks","issue_events_url":"https://api.github.com/repos/Banno/hdfs/issues/events{/number}","events_url":"https://api.github.com/repos/Banno/hdfs/events","assignees_url":"https://api.github.com/repos/Banno/hdfs/assignees{/user}","branches_url":"https://api.github.com/repos/Banno/hdfs/branches{/branch}","tags_url":"https://api.github.com/repos/Banno/hdfs/tags","blobs_url":"https://api.github.com/repos/Banno/hdfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Banno/hdfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Banno/hdfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Banno/hdfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Banno/hdfs/statuses/{sha}","languages_url":"https://api.github.com/repos/Banno/hdfs/languages","stargazers_url":"https://api.github.com/repos/Banno/hdfs/stargazers","contributors_url":"https://api.github.com/repos/Banno/hdfs/contributors","subscribers_url":"https://api.github.com/repos/Banno/hdfs/subscribers","subscription_url":"https://api.github.com/repos/Banno/hdfs/subscription","commits_url":"https://api.github.com/repos/Banno/hdfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Banno/hdfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Banno/hdfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Banno/hdfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Banno/hdfs/contents/{+path}","compare_url":"https://api.github.com/repos/Banno/hdfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Banno/hdfs/merges","archive_url":"https://api.github.com/repos/Banno/hdfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Banno/hdfs/downloads","issues_url":"https://api.github.com/repos/Banno/hdfs/issues{/number}","pulls_url":"https://api.github.com/repos/Banno/hdfs/pulls{/number}","milestones_url":"https://api.github.com/repos/Banno/hdfs/milestones{/number}","notifications_url":"https://api.github.com/repos/Banno/hdfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Banno/hdfs/labels{/name}","releases_url":"https://api.github.com/repos/Banno/hdfs/releases{/id}","created_at":"2015-01-12T17:26:37Z","updated_at":"2015-02-02T21:41:17Z","pushed_at":"2015-03-04T01:28:06Z","git_url":"git://github.com/Banno/hdfs.git","ssh_url":"git@github.com:Banno/hdfs.git","clone_url":"https://github.com/Banno/hdfs.git","svn_url":"https://github.com/Banno/hdfs","homepage":"","size":591,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mesosphere:master","ref":"master","sha":"6aef8fc709a9532dd9f46304ba062e979f3c9670","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":25594400,"name":"hdfs","full_name":"mesosphere/hdfs","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/hdfs","description":"HA HDFS on Apache Mesos  ~~~  aka 'Super Available' HDFS","fork":true,"url":"https://api.github.com/repos/mesosphere/hdfs","forks_url":"https://api.github.com/repos/mesosphere/hdfs/forks","keys_url":"https://api.github.com/repos/mesosphere/hdfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/hdfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/hdfs/teams","hooks_url":"https://api.github.com/repos/mesosphere/hdfs/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/hdfs/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/hdfs/events","assignees_url":"https://api.github.com/repos/mesosphere/hdfs/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/hdfs/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/hdfs/tags","blobs_url":"https://api.github.com/repos/mesosphere/hdfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/hdfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/hdfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/hdfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/hdfs/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/hdfs/languages","stargazers_url":"https://api.github.com/repos/mesosphere/hdfs/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/hdfs/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/hdfs/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/hdfs/subscription","commits_url":"https://api.github.com/repos/mesosphere/hdfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/hdfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/hdfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/hdfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/hdfs/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/hdfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/hdfs/merges","archive_url":"https://api.github.com/repos/mesosphere/hdfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/hdfs/downloads","issues_url":"https://api.github.com/repos/mesosphere/hdfs/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/hdfs/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/hdfs/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/hdfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/hdfs/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/hdfs/releases{/id}","created_at":"2014-10-22T17:21:52Z","updated_at":"2015-03-03T03:52:35Z","pushed_at":"2015-03-03T19:22:40Z","git_url":"git://github.com/mesosphere/hdfs.git","ssh_url":"git@github.com:mesosphere/hdfs.git","clone_url":"https://github.com/mesosphere/hdfs.git","svn_url":"https://github.com/mesosphere/hdfs","homepage":"","size":1377,"stargazers_count":29,"watchers_count":29,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":23,"forks":5,"open_issues":23,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesosphere/hdfs/pulls/59"},"html":{"href":"https://github.com/mesosphere/hdfs/pull/59"},"issue":{"href":"https://api.github.com/repos/mesosphere/hdfs/issues/59"},"comments":{"href":"https://api.github.com/repos/mesosphere/hdfs/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/mesosphere/hdfs/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/mesosphere/hdfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesosphere/hdfs/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/mesosphere/hdfs/statuses/bf5ae43908696e70e431de8ba4fad3a67e56f214"}}}}