{"action":"created","comment":{"url":"https://api.github.com/repos/neovim/neovim/pulls/comments/29465409","id":29465409,"diff_hunk":"@@ -4333,108 +4333,110 @@ void shorten_fnames(int force)\n   redraw_tabline = TRUE;\n }\n \n-/*\n- * add extension to file name - change path/fo.o.h to path/fo.o.h.ext\n- *\n- * Assumed that fname is a valid name found in the filesystem we assure that\n- * the return value is a different name and ends in 'ext'.\n- * \"ext\" MUST be at most 4 characters long if it starts with a dot, 3\n- * characters otherwise.\n- * Space for the returned name is allocated, must be freed later.\n- * Returns NULL when out of memory.\n- */\n-char_u *\n-modname (\n-    char_u *fname,\n-    char_u *ext,\n-    int prepend_dot                /* may prepend a '.' to file name */\n-)\n+/// Get new filename ended by given extension.","path":"src/nvim/fileio.c","position":56,"original_position":56,"commit_id":"4ec9161d4bfacda2d0c04059429801310b7ed578","original_commit_id":"4ec9161d4bfacda2d0c04059429801310b7ed578","user":{"login":"Pyrohh","id":4174345,"avatar_url":"https://avatars.githubusercontent.com/u/4174345?v=3","gravatar_id":"","url":"https://api.github.com/users/Pyrohh","html_url":"https://github.com/Pyrohh","followers_url":"https://api.github.com/users/Pyrohh/followers","following_url":"https://api.github.com/users/Pyrohh/following{/other_user}","gists_url":"https://api.github.com/users/Pyrohh/gists{/gist_id}","starred_url":"https://api.github.com/users/Pyrohh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pyrohh/subscriptions","organizations_url":"https://api.github.com/users/Pyrohh/orgs","repos_url":"https://api.github.com/users/Pyrohh/repos","events_url":"https://api.github.com/users/Pyrohh/events{/privacy}","received_events_url":"https://api.github.com/users/Pyrohh/received_events","type":"User","site_admin":false},"body":"I hate to be that guy... but should be `Gets`.","created_at":"2015-04-30T20:12:16Z","updated_at":"2015-04-30T20:12:16Z","html_url":"https://github.com/neovim/neovim/pull/2470#discussion_r29465409","pull_request_url":"https://api.github.com/repos/neovim/neovim/pulls/2470","_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments/29465409"},"html":{"href":"https://github.com/neovim/neovim/pull/2470#discussion_r29465409"},"pull_request":{"href":"https://api.github.com/repos/neovim/neovim/pulls/2470"}}},"pull_request":{"url":"https://api.github.com/repos/neovim/neovim/pulls/2470","id":33680802,"html_url":"https://github.com/neovim/neovim/pull/2470","diff_url":"https://github.com/neovim/neovim/pull/2470.diff","patch_url":"https://github.com/neovim/neovim/pull/2470.patch","issue_url":"https://api.github.com/repos/neovim/neovim/issues/2470","number":2470,"state":"open","locked":false,"title":"[RFC] Remove char_u (5)","user":{"login":"mbainter","id":123376,"avatar_url":"https://avatars.githubusercontent.com/u/123376?v=3","gravatar_id":"","url":"https://api.github.com/users/mbainter","html_url":"https://github.com/mbainter","followers_url":"https://api.github.com/users/mbainter/followers","following_url":"https://api.github.com/users/mbainter/following{/other_user}","gists_url":"https://api.github.com/users/mbainter/gists{/gist_id}","starred_url":"https://api.github.com/users/mbainter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbainter/subscriptions","organizations_url":"https://api.github.com/users/mbainter/orgs","repos_url":"https://api.github.com/users/mbainter/repos","events_url":"https://api.github.com/users/mbainter/events{/privacy}","received_events_url":"https://api.github.com/users/mbainter/received_events","type":"User","site_admin":false},"body":"I have some concerns/questions again on this one, namely around the multi-byte string handling.  I'm not entirely sure what the right approach is for working around that without breaking it.  What I have \"works\" in that it builds and passes tests, but I don't think it's a very good idea. ","created_at":"2015-04-20T16:12:43Z","updated_at":"2015-04-30T20:12:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80656b9fcd0f481ce653c93572fd814a5f2ad183","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neovim/neovim/pulls/2470/commits","review_comments_url":"https://api.github.com/repos/neovim/neovim/pulls/2470/comments","review_comment_url":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neovim/neovim/issues/2470/comments","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/4ec9161d4bfacda2d0c04059429801310b7ed578","head":{"label":"mbainter:char_u_5","ref":"char_u_5","sha":"4ec9161d4bfacda2d0c04059429801310b7ed578","user":{"login":"mbainter","id":123376,"avatar_url":"https://avatars.githubusercontent.com/u/123376?v=3","gravatar_id":"","url":"https://api.github.com/users/mbainter","html_url":"https://github.com/mbainter","followers_url":"https://api.github.com/users/mbainter/followers","following_url":"https://api.github.com/users/mbainter/following{/other_user}","gists_url":"https://api.github.com/users/mbainter/gists{/gist_id}","starred_url":"https://api.github.com/users/mbainter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbainter/subscriptions","organizations_url":"https://api.github.com/users/mbainter/orgs","repos_url":"https://api.github.com/users/mbainter/repos","events_url":"https://api.github.com/users/mbainter/events{/privacy}","received_events_url":"https://api.github.com/users/mbainter/received_events","type":"User","site_admin":false},"repo":{"id":32944899,"name":"neovim","full_name":"mbainter/neovim","owner":{"login":"mbainter","id":123376,"avatar_url":"https://avatars.githubusercontent.com/u/123376?v=3","gravatar_id":"","url":"https://api.github.com/users/mbainter","html_url":"https://github.com/mbainter","followers_url":"https://api.github.com/users/mbainter/followers","following_url":"https://api.github.com/users/mbainter/following{/other_user}","gists_url":"https://api.github.com/users/mbainter/gists{/gist_id}","starred_url":"https://api.github.com/users/mbainter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbainter/subscriptions","organizations_url":"https://api.github.com/users/mbainter/orgs","repos_url":"https://api.github.com/users/mbainter/repos","events_url":"https://api.github.com/users/mbainter/events{/privacy}","received_events_url":"https://api.github.com/users/mbainter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbainter/neovim","description":"vim out of the box","fork":true,"url":"https://api.github.com/repos/mbainter/neovim","forks_url":"https://api.github.com/repos/mbainter/neovim/forks","keys_url":"https://api.github.com/repos/mbainter/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbainter/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbainter/neovim/teams","hooks_url":"https://api.github.com/repos/mbainter/neovim/hooks","issue_events_url":"https://api.github.com/repos/mbainter/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/mbainter/neovim/events","assignees_url":"https://api.github.com/repos/mbainter/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/mbainter/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/mbainter/neovim/tags","blobs_url":"https://api.github.com/repos/mbainter/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbainter/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbainter/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbainter/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbainter/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/mbainter/neovim/languages","stargazers_url":"https://api.github.com/repos/mbainter/neovim/stargazers","contributors_url":"https://api.github.com/repos/mbainter/neovim/contributors","subscribers_url":"https://api.github.com/repos/mbainter/neovim/subscribers","subscription_url":"https://api.github.com/repos/mbainter/neovim/subscription","commits_url":"https://api.github.com/repos/mbainter/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbainter/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbainter/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbainter/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbainter/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/mbainter/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbainter/neovim/merges","archive_url":"https://api.github.com/repos/mbainter/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbainter/neovim/downloads","issues_url":"https://api.github.com/repos/mbainter/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/mbainter/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/mbainter/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/mbainter/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbainter/neovim/labels{/name}","releases_url":"https://api.github.com/repos/mbainter/neovim/releases{/id}","created_at":"2015-03-26T18:29:07Z","updated_at":"2015-04-19T22:29:12Z","pushed_at":"2015-04-28T15:46:04Z","git_url":"git://github.com/mbainter/neovim.git","ssh_url":"git@github.com:mbainter/neovim.git","clone_url":"https://github.com/mbainter/neovim.git","svn_url":"https://github.com/mbainter/neovim","homepage":"http://neovim.org","size":30313,"stargazers_count":0,"watchers_count":0,"language":"VimL","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neovim:master","ref":"master","sha":"a903407471d8b480737d43db1d271c6650580f1c","user":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"repo":{"id":16408992,"name":"neovim","full_name":"neovim/neovim","owner":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neovim/neovim","description":"ambitious Vim-fork focused on extensibility and agility. Please consider helping sustain Neovim development! https://salt.bountysource.com/teams/neovim","fork":false,"url":"https://api.github.com/repos/neovim/neovim","forks_url":"https://api.github.com/repos/neovim/neovim/forks","keys_url":"https://api.github.com/repos/neovim/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neovim/neovim/teams","hooks_url":"https://api.github.com/repos/neovim/neovim/hooks","issue_events_url":"https://api.github.com/repos/neovim/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/neovim/neovim/events","assignees_url":"https://api.github.com/repos/neovim/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/neovim/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/neovim/neovim/tags","blobs_url":"https://api.github.com/repos/neovim/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neovim/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neovim/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/neovim/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/neovim/neovim/languages","stargazers_url":"https://api.github.com/repos/neovim/neovim/stargazers","contributors_url":"https://api.github.com/repos/neovim/neovim/contributors","subscribers_url":"https://api.github.com/repos/neovim/neovim/subscribers","subscription_url":"https://api.github.com/repos/neovim/neovim/subscription","commits_url":"https://api.github.com/repos/neovim/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/neovim/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/neovim/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/neovim/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/neovim/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/neovim/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neovim/neovim/merges","archive_url":"https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neovim/neovim/downloads","issues_url":"https://api.github.com/repos/neovim/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/neovim/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/neovim/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neovim/neovim/labels{/name}","releases_url":"https://api.github.com/repos/neovim/neovim/releases{/id}","created_at":"2014-01-31T13:39:22Z","updated_at":"2015-04-30T19:20:26Z","pushed_at":"2015-04-30T20:02:09Z","git_url":"git://github.com/neovim/neovim.git","ssh_url":"git@github.com:neovim/neovim.git","clone_url":"https://github.com/neovim/neovim.git","svn_url":"https://github.com/neovim/neovim","homepage":"http://neovim.io","size":72600,"stargazers_count":13171,"watchers_count":13171,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":887,"mirror_url":null,"open_issues_count":447,"forks":887,"open_issues":447,"watchers":13171,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/2470"},"html":{"href":"https://github.com/neovim/neovim/pull/2470"},"issue":{"href":"https://api.github.com/repos/neovim/neovim/issues/2470"},"comments":{"href":"https://api.github.com/repos/neovim/neovim/issues/2470/comments"},"review_comments":{"href":"https://api.github.com/repos/neovim/neovim/pulls/2470/comments"},"review_comment":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neovim/neovim/pulls/2470/commits"},"statuses":{"href":"https://api.github.com/repos/neovim/neovim/statuses/4ec9161d4bfacda2d0c04059429801310b7ed578"}}}}