{"action":"created","comment":{"url":"https://api.github.com/repos/BohemianCoding/BCFoundation/pulls/comments/38233768","id":38233768,"diff_hunk":"@@ -56,4 +56,11 @@ CGFloat BCRectValueForKey(CGRect rect, NSString *key);\n CGRect BCRectNormalise(CGRect rect);\n CGRect BCRectWithSizeOnAxisAspectRatio(CGRect rect, CGFloat size, BCAxis axis, CGFloat aspectRatio);\n CGRect BCRectMoveCornerToPoint(CGRect rect, BCCorner corner, CGPoint point);\n-CGRect BCRectByEnsuringMidIsContainedInRect(NSRect rect, NSRect outerRect);\n\\ No newline at end of file\n+CGRect BCRectByEnsuringMidIsContainedInRect(NSRect rect, NSRect outerRect);\n+\n+/**\n+ Returns a rect by basically moving innerRect into the outerRect if necessary.","path":"Source/BCRectGeometry.h","position":9,"original_position":9,"commit_id":"31c4a30c14ab473ed16f177d4b3249e24ea0f6df","original_commit_id":"31c4a30c14ab473ed16f177d4b3249e24ea0f6df","user":{"login":"pieteromvlee","id":160783,"avatar_url":"https://avatars.githubusercontent.com/u/160783?v=3","gravatar_id":"","url":"https://api.github.com/users/pieteromvlee","html_url":"https://github.com/pieteromvlee","followers_url":"https://api.github.com/users/pieteromvlee/followers","following_url":"https://api.github.com/users/pieteromvlee/following{/other_user}","gists_url":"https://api.github.com/users/pieteromvlee/gists{/gist_id}","starred_url":"https://api.github.com/users/pieteromvlee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pieteromvlee/subscriptions","organizations_url":"https://api.github.com/users/pieteromvlee/orgs","repos_url":"https://api.github.com/users/pieteromvlee/repos","events_url":"https://api.github.com/users/pieteromvlee/events{/privacy}","received_events_url":"https://api.github.com/users/pieteromvlee/received_events","type":"User","site_admin":false},"body":"I can completely see what you mean and I'm happy to either assert or make a note in the docs. My preference would be the latter I think maybe. Which one would you pick?","created_at":"2015-08-28T19:12:32Z","updated_at":"2015-08-28T19:12:32Z","html_url":"https://github.com/BohemianCoding/BCFoundation/pull/18#discussion_r38233768","pull_request_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/BohemianCoding/BCFoundation/pulls/comments/38233768"},"html":{"href":"https://github.com/BohemianCoding/BCFoundation/pull/18#discussion_r38233768"},"pull_request":{"href":"https://api.github.com/repos/BohemianCoding/BCFoundation/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/BohemianCoding/BCFoundation/pulls/18","id":43505012,"html_url":"https://github.com/BohemianCoding/BCFoundation/pull/18","diff_url":"https://github.com/BohemianCoding/BCFoundation/pull/18.diff","patch_url":"https://github.com/BohemianCoding/BCFoundation/pull/18.patch","issue_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/issues/18","number":18,"state":"open","locked":false,"title":"Review 5806","user":{"login":"pieteromvlee","id":160783,"avatar_url":"https://avatars.githubusercontent.com/u/160783?v=3","gravatar_id":"","url":"https://api.github.com/users/pieteromvlee","html_url":"https://github.com/pieteromvlee","followers_url":"https://api.github.com/users/pieteromvlee/followers","following_url":"https://api.github.com/users/pieteromvlee/following{/other_user}","gists_url":"https://api.github.com/users/pieteromvlee/gists{/gist_id}","starred_url":"https://api.github.com/users/pieteromvlee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pieteromvlee/subscriptions","organizations_url":"https://api.github.com/users/pieteromvlee/orgs","repos_url":"https://api.github.com/users/pieteromvlee/repos","events_url":"https://api.github.com/users/pieteromvlee/events{/privacy}","received_events_url":"https://api.github.com/users/pieteromvlee/received_events","type":"User","site_admin":false},"body":"Fixes for 5806\n\nConnect to BohemianCoding/Sketch#5806.","created_at":"2015-08-27T11:12:25Z","updated_at":"2015-08-28T19:12:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27f45040ae971434048d868c7ad4ec0a668fa3a3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/pulls/18/commits","review_comments_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/pulls/18/comments","review_comment_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/issues/18/comments","statuses_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/statuses/31c4a30c14ab473ed16f177d4b3249e24ea0f6df","head":{"label":"BohemianCoding:feature/5806","ref":"feature/5806","sha":"31c4a30c14ab473ed16f177d4b3249e24ea0f6df","user":{"login":"BohemianCoding","id":4498264,"avatar_url":"https://avatars.githubusercontent.com/u/4498264?v=3","gravatar_id":"","url":"https://api.github.com/users/BohemianCoding","html_url":"https://github.com/BohemianCoding","followers_url":"https://api.github.com/users/BohemianCoding/followers","following_url":"https://api.github.com/users/BohemianCoding/following{/other_user}","gists_url":"https://api.github.com/users/BohemianCoding/gists{/gist_id}","starred_url":"https://api.github.com/users/BohemianCoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BohemianCoding/subscriptions","organizations_url":"https://api.github.com/users/BohemianCoding/orgs","repos_url":"https://api.github.com/users/BohemianCoding/repos","events_url":"https://api.github.com/users/BohemianCoding/events{/privacy}","received_events_url":"https://api.github.com/users/BohemianCoding/received_events","type":"Organization","site_admin":false},"repo":{"id":13962123,"name":"BCFoundation","full_name":"BohemianCoding/BCFoundation","owner":{"login":"BohemianCoding","id":4498264,"avatar_url":"https://avatars.githubusercontent.com/u/4498264?v=3","gravatar_id":"","url":"https://api.github.com/users/BohemianCoding","html_url":"https://github.com/BohemianCoding","followers_url":"https://api.github.com/users/BohemianCoding/followers","following_url":"https://api.github.com/users/BohemianCoding/following{/other_user}","gists_url":"https://api.github.com/users/BohemianCoding/gists{/gist_id}","starred_url":"https://api.github.com/users/BohemianCoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BohemianCoding/subscriptions","organizations_url":"https://api.github.com/users/BohemianCoding/orgs","repos_url":"https://api.github.com/users/BohemianCoding/repos","events_url":"https://api.github.com/users/BohemianCoding/events{/privacy}","received_events_url":"https://api.github.com/users/BohemianCoding/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BohemianCoding/BCFoundation","description":"Shared prefixes, configurations etc for a number of other projects","fork":false,"url":"https://api.github.com/repos/BohemianCoding/BCFoundation","forks_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/forks","keys_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/teams","hooks_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/hooks","issue_events_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/issues/events{/number}","events_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/events","assignees_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/assignees{/user}","branches_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/branches{/branch}","tags_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/tags","blobs_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/git/refs{/sha}","trees_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/statuses/{sha}","languages_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/languages","stargazers_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/stargazers","contributors_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/contributors","subscribers_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/subscribers","subscription_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/subscription","commits_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/commits{/sha}","git_commits_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/git/commits{/sha}","comments_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/comments{/number}","issue_comment_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/issues/comments{/number}","contents_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/contents/{+path}","compare_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/merges","archive_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/downloads","issues_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/issues{/number}","pulls_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/pulls{/number}","milestones_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/milestones{/number}","notifications_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/labels{/name}","releases_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/releases{/id}","created_at":"2013-10-29T16:48:27Z","updated_at":"2015-04-23T15:25:14Z","pushed_at":"2015-08-27T13:58:12Z","git_url":"git://github.com/BohemianCoding/BCFoundation.git","ssh_url":"git@github.com:BohemianCoding/BCFoundation.git","clone_url":"https://github.com/BohemianCoding/BCFoundation.git","svn_url":"https://github.com/BohemianCoding/BCFoundation","homepage":"","size":653,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":0,"default_branch":"develop"}},"base":{"label":"BohemianCoding:release/3.4","ref":"release/3.4","sha":"aad12136fb25abe747c884359c212f698e2c31e3","user":{"login":"BohemianCoding","id":4498264,"avatar_url":"https://avatars.githubusercontent.com/u/4498264?v=3","gravatar_id":"","url":"https://api.github.com/users/BohemianCoding","html_url":"https://github.com/BohemianCoding","followers_url":"https://api.github.com/users/BohemianCoding/followers","following_url":"https://api.github.com/users/BohemianCoding/following{/other_user}","gists_url":"https://api.github.com/users/BohemianCoding/gists{/gist_id}","starred_url":"https://api.github.com/users/BohemianCoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BohemianCoding/subscriptions","organizations_url":"https://api.github.com/users/BohemianCoding/orgs","repos_url":"https://api.github.com/users/BohemianCoding/repos","events_url":"https://api.github.com/users/BohemianCoding/events{/privacy}","received_events_url":"https://api.github.com/users/BohemianCoding/received_events","type":"Organization","site_admin":false},"repo":{"id":13962123,"name":"BCFoundation","full_name":"BohemianCoding/BCFoundation","owner":{"login":"BohemianCoding","id":4498264,"avatar_url":"https://avatars.githubusercontent.com/u/4498264?v=3","gravatar_id":"","url":"https://api.github.com/users/BohemianCoding","html_url":"https://github.com/BohemianCoding","followers_url":"https://api.github.com/users/BohemianCoding/followers","following_url":"https://api.github.com/users/BohemianCoding/following{/other_user}","gists_url":"https://api.github.com/users/BohemianCoding/gists{/gist_id}","starred_url":"https://api.github.com/users/BohemianCoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BohemianCoding/subscriptions","organizations_url":"https://api.github.com/users/BohemianCoding/orgs","repos_url":"https://api.github.com/users/BohemianCoding/repos","events_url":"https://api.github.com/users/BohemianCoding/events{/privacy}","received_events_url":"https://api.github.com/users/BohemianCoding/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BohemianCoding/BCFoundation","description":"Shared prefixes, configurations etc for a number of other projects","fork":false,"url":"https://api.github.com/repos/BohemianCoding/BCFoundation","forks_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/forks","keys_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/teams","hooks_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/hooks","issue_events_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/issues/events{/number}","events_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/events","assignees_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/assignees{/user}","branches_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/branches{/branch}","tags_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/tags","blobs_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/git/refs{/sha}","trees_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/statuses/{sha}","languages_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/languages","stargazers_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/stargazers","contributors_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/contributors","subscribers_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/subscribers","subscription_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/subscription","commits_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/commits{/sha}","git_commits_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/git/commits{/sha}","comments_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/comments{/number}","issue_comment_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/issues/comments{/number}","contents_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/contents/{+path}","compare_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/merges","archive_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/downloads","issues_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/issues{/number}","pulls_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/pulls{/number}","milestones_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/milestones{/number}","notifications_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/labels{/name}","releases_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/releases{/id}","created_at":"2013-10-29T16:48:27Z","updated_at":"2015-04-23T15:25:14Z","pushed_at":"2015-08-27T13:58:12Z","git_url":"git://github.com/BohemianCoding/BCFoundation.git","ssh_url":"git@github.com:BohemianCoding/BCFoundation.git","clone_url":"https://github.com/BohemianCoding/BCFoundation.git","svn_url":"https://github.com/BohemianCoding/BCFoundation","homepage":"","size":653,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/BohemianCoding/BCFoundation/pulls/18"},"html":{"href":"https://github.com/BohemianCoding/BCFoundation/pull/18"},"issue":{"href":"https://api.github.com/repos/BohemianCoding/BCFoundation/issues/18"},"comments":{"href":"https://api.github.com/repos/BohemianCoding/BCFoundation/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/BohemianCoding/BCFoundation/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/BohemianCoding/BCFoundation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BohemianCoding/BCFoundation/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/BohemianCoding/BCFoundation/statuses/31c4a30c14ab473ed16f177d4b3249e24ea0f6df"}}}}