{"action":"created","comment":{"url":"https://api.github.com/repos/mesosphere/mesos-dns/pulls/comments/39697200","id":39697200,"diff_hunk":"@@ -46,9 +46,22 @@ type Label struct {\n \n // Status holds a task status as defined in the /state.json Mesos HTTP endpoint.\n type Status struct {\n-\tTimestamp float64 `json:\"timestamp\"`\n-\tState     string  `json:\"state\"`\n-\tLabels    []Label `json:\"labels,omitempty\"`\n+\tTimestamp       float64         `json:\"timestamp\"`\n+\tState           string          `json:\"state\"`\n+\tLabels          []Label         `json:\"labels,omitempty\"`\n+\tContainerStatus ContainerStatus `json:\"container_status\"`\n+}\n+\n+// ContainerStatus holds container metadata as defined in the /state.json\n+// Mesos HTTP endpoint.\n+type ContainerStatus struct {\n+\tNetworkInfos []NetworkInfo `json:\"network_infos\"`","path":"records/state/state.go","position":16,"original_position":16,"commit_id":"813abb9dcc6be65e4c4bb6f166e7909f3c1ee6c3","original_commit_id":"813abb9dcc6be65e4c4bb6f166e7909f3c1ee6c3","user":{"login":"jdef","id":2348332,"avatar_url":"https://avatars.githubusercontent.com/u/2348332?v=3","gravatar_id":"","url":"https://api.github.com/users/jdef","html_url":"https://github.com/jdef","followers_url":"https://api.github.com/users/jdef/followers","following_url":"https://api.github.com/users/jdef/following{/other_user}","gists_url":"https://api.github.com/users/jdef/gists{/gist_id}","starred_url":"https://api.github.com/users/jdef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdef/subscriptions","organizations_url":"https://api.github.com/users/jdef/orgs","repos_url":"https://api.github.com/users/jdef/repos","events_url":"https://api.github.com/users/jdef/events{/privacy}","received_events_url":"https://api.github.com/users/jdef/received_events","type":"User","site_admin":false},"body":"omitempty?","created_at":"2015-09-16T23:19:25Z","updated_at":"2015-09-16T23:19:25Z","html_url":"https://github.com/mesosphere/mesos-dns/pull/266#discussion_r39697200","pull_request_url":"https://api.github.com/repos/mesosphere/mesos-dns/pulls/266","_links":{"self":{"href":"https://api.github.com/repos/mesosphere/mesos-dns/pulls/comments/39697200"},"html":{"href":"https://github.com/mesosphere/mesos-dns/pull/266#discussion_r39697200"},"pull_request":{"href":"https://api.github.com/repos/mesosphere/mesos-dns/pulls/266"}}},"pull_request":{"url":"https://api.github.com/repos/mesosphere/mesos-dns/pulls/266","id":45228964,"html_url":"https://github.com/mesosphere/mesos-dns/pull/266","diff_url":"https://github.com/mesosphere/mesos-dns/pull/266.diff","patch_url":"https://github.com/mesosphere/mesos-dns/pull/266.patch","issue_url":"https://api.github.com/repos/mesosphere/mesos-dns/issues/266","number":266,"state":"open","locked":false,"title":"Added logic to read NetworkInfo from /state.json.","user":{"login":"ConnorDoyle","id":379372,"avatar_url":"https://avatars.githubusercontent.com/u/379372?v=3","gravatar_id":"","url":"https://api.github.com/users/ConnorDoyle","html_url":"https://github.com/ConnorDoyle","followers_url":"https://api.github.com/users/ConnorDoyle/followers","following_url":"https://api.github.com/users/ConnorDoyle/following{/other_user}","gists_url":"https://api.github.com/users/ConnorDoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/ConnorDoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConnorDoyle/subscriptions","organizations_url":"https://api.github.com/users/ConnorDoyle/orgs","repos_url":"https://api.github.com/users/ConnorDoyle/repos","events_url":"https://api.github.com/users/ConnorDoyle/events{/privacy}","received_events_url":"https://api.github.com/users/ConnorDoyle/received_events","type":"User","site_admin":false},"body":"## Overview\r\n\r\nMesos 0.25.0 will include a new way for network isolation modules to communicate assigned IP addresses assigned to containers at executor launch time.  Where previously Mesos-DNS picked up the values of some special labels appended to a task status, Mesos 0.25.0 introduces a new structure called `NetworkInfo`.\r\n\r\n## Change summary\r\n\r\nThis change preserves the previous behavior of reading special labels to ease transition to users who relied on that method of IP address discovery.  However, the information in the new `NetworkInfo` structure should take precedence if present.\r\n\r\n## Additional references\r\n\r\n- For general information on the `NetworkInfo` message and its intended use, see the public [networking design document](https://docs.google.com/document/d/17mXtAmdAXcNBwp_JfrxmZcQrs7EO6ancSbejrqjLQ0g).\r\n- For a different angle on how Framework developers will interact with new network isolation strategies in Mesos, see the public [Framework writer’s guide to IP-per-container](https://docs.google.com/document/d/13mXNziHQPkmHdH6g2srtE2k0PaJSIWuBvRgmJ7Jvqh4).\r\n- For implementation details around `NetworkInfo` and its representation in the Mesos master state endpoint, see [Review Request 38367: Added NetworkInfo message to ContainerInfo and TaskStatus](https://reviews.apache.org/r/38367) by @karya0 .","created_at":"2015-09-16T21:52:03Z","updated_at":"2015-09-16T23:19:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac3c43b7fb73884a19b6ed3a22cebb66bac42c1e","assignee":{"login":"jdef","id":2348332,"avatar_url":"https://avatars.githubusercontent.com/u/2348332?v=3","gravatar_id":"","url":"https://api.github.com/users/jdef","html_url":"https://github.com/jdef","followers_url":"https://api.github.com/users/jdef/followers","following_url":"https://api.github.com/users/jdef/following{/other_user}","gists_url":"https://api.github.com/users/jdef/gists{/gist_id}","starred_url":"https://api.github.com/users/jdef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdef/subscriptions","organizations_url":"https://api.github.com/users/jdef/orgs","repos_url":"https://api.github.com/users/jdef/repos","events_url":"https://api.github.com/users/jdef/events{/privacy}","received_events_url":"https://api.github.com/users/jdef/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/mesosphere/mesos-dns/pulls/266/commits","review_comments_url":"https://api.github.com/repos/mesosphere/mesos-dns/pulls/266/comments","review_comment_url":"https://api.github.com/repos/mesosphere/mesos-dns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesosphere/mesos-dns/issues/266/comments","statuses_url":"https://api.github.com/repos/mesosphere/mesos-dns/statuses/813abb9dcc6be65e4c4bb6f166e7909f3c1ee6c3","head":{"label":"mesosphere:read-networkinfo","ref":"read-networkinfo","sha":"813abb9dcc6be65e4c4bb6f166e7909f3c1ee6c3","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":26509179,"name":"mesos-dns","full_name":"mesosphere/mesos-dns","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/mesos-dns","description":" DNS-based service discovery for Mesos.","fork":false,"url":"https://api.github.com/repos/mesosphere/mesos-dns","forks_url":"https://api.github.com/repos/mesosphere/mesos-dns/forks","keys_url":"https://api.github.com/repos/mesosphere/mesos-dns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/mesos-dns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/mesos-dns/teams","hooks_url":"https://api.github.com/repos/mesosphere/mesos-dns/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/mesos-dns/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/mesos-dns/events","assignees_url":"https://api.github.com/repos/mesosphere/mesos-dns/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/mesos-dns/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/mesos-dns/tags","blobs_url":"https://api.github.com/repos/mesosphere/mesos-dns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/mesos-dns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/mesos-dns/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/mesos-dns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/mesos-dns/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/mesos-dns/languages","stargazers_url":"https://api.github.com/repos/mesosphere/mesos-dns/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/mesos-dns/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/mesos-dns/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/mesos-dns/subscription","commits_url":"https://api.github.com/repos/mesosphere/mesos-dns/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/mesos-dns/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/mesos-dns/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/mesos-dns/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/mesos-dns/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/mesos-dns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/mesos-dns/merges","archive_url":"https://api.github.com/repos/mesosphere/mesos-dns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/mesos-dns/downloads","issues_url":"https://api.github.com/repos/mesosphere/mesos-dns/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/mesos-dns/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/mesos-dns/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/mesos-dns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/mesos-dns/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/mesos-dns/releases{/id}","created_at":"2014-11-11T23:06:33Z","updated_at":"2015-09-16T07:23:02Z","pushed_at":"2015-09-16T21:54:00Z","git_url":"git://github.com/mesosphere/mesos-dns.git","ssh_url":"git@github.com:mesosphere/mesos-dns.git","clone_url":"https://github.com/mesosphere/mesos-dns.git","svn_url":"https://github.com/mesosphere/mesos-dns","homepage":"https://mesosphere.github.com/mesos-dns","size":3273,"stargazers_count":249,"watchers_count":249,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":42,"mirror_url":null,"open_issues_count":46,"forks":42,"open_issues":46,"watchers":249,"default_branch":"master"}},"base":{"label":"mesosphere:master","ref":"master","sha":"3003c57a802fffd36cbd97c9ab3aec9fa863c252","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":26509179,"name":"mesos-dns","full_name":"mesosphere/mesos-dns","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/mesos-dns","description":" DNS-based service discovery for Mesos.","fork":false,"url":"https://api.github.com/repos/mesosphere/mesos-dns","forks_url":"https://api.github.com/repos/mesosphere/mesos-dns/forks","keys_url":"https://api.github.com/repos/mesosphere/mesos-dns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/mesos-dns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/mesos-dns/teams","hooks_url":"https://api.github.com/repos/mesosphere/mesos-dns/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/mesos-dns/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/mesos-dns/events","assignees_url":"https://api.github.com/repos/mesosphere/mesos-dns/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/mesos-dns/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/mesos-dns/tags","blobs_url":"https://api.github.com/repos/mesosphere/mesos-dns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/mesos-dns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/mesos-dns/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/mesos-dns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/mesos-dns/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/mesos-dns/languages","stargazers_url":"https://api.github.com/repos/mesosphere/mesos-dns/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/mesos-dns/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/mesos-dns/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/mesos-dns/subscription","commits_url":"https://api.github.com/repos/mesosphere/mesos-dns/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/mesos-dns/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/mesos-dns/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/mesos-dns/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/mesos-dns/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/mesos-dns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/mesos-dns/merges","archive_url":"https://api.github.com/repos/mesosphere/mesos-dns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/mesos-dns/downloads","issues_url":"https://api.github.com/repos/mesosphere/mesos-dns/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/mesos-dns/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/mesos-dns/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/mesos-dns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/mesos-dns/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/mesos-dns/releases{/id}","created_at":"2014-11-11T23:06:33Z","updated_at":"2015-09-16T07:23:02Z","pushed_at":"2015-09-16T21:54:00Z","git_url":"git://github.com/mesosphere/mesos-dns.git","ssh_url":"git@github.com:mesosphere/mesos-dns.git","clone_url":"https://github.com/mesosphere/mesos-dns.git","svn_url":"https://github.com/mesosphere/mesos-dns","homepage":"https://mesosphere.github.com/mesos-dns","size":3273,"stargazers_count":249,"watchers_count":249,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":42,"mirror_url":null,"open_issues_count":46,"forks":42,"open_issues":46,"watchers":249,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesosphere/mesos-dns/pulls/266"},"html":{"href":"https://github.com/mesosphere/mesos-dns/pull/266"},"issue":{"href":"https://api.github.com/repos/mesosphere/mesos-dns/issues/266"},"comments":{"href":"https://api.github.com/repos/mesosphere/mesos-dns/issues/266/comments"},"review_comments":{"href":"https://api.github.com/repos/mesosphere/mesos-dns/pulls/266/comments"},"review_comment":{"href":"https://api.github.com/repos/mesosphere/mesos-dns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesosphere/mesos-dns/pulls/266/commits"},"statuses":{"href":"https://api.github.com/repos/mesosphere/mesos-dns/statuses/813abb9dcc6be65e4c4bb6f166e7909f3c1ee6c3"}}}}