{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/9796","labels_url":"https://api.github.com/repos/apache/spark/issues/9796/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/9796/comments","events_url":"https://api.github.com/repos/apache/spark/issues/9796/events","html_url":"https://github.com/apache/spark/pull/9796","id":117528474,"number":9796,"title":"[SPARK-9552] Return \"false\" while nothing to kill in killExecutors","user":{"login":"GraceH","id":1960093,"avatar_url":"https://avatars.githubusercontent.com/u/1960093?v=3","gravatar_id":"","url":"https://api.github.com/users/GraceH","html_url":"https://github.com/GraceH","followers_url":"https://api.github.com/users/GraceH/followers","following_url":"https://api.github.com/users/GraceH/following{/other_user}","gists_url":"https://api.github.com/users/GraceH/gists{/gist_id}","starred_url":"https://api.github.com/users/GraceH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GraceH/subscriptions","organizations_url":"https://api.github.com/users/GraceH/orgs","repos_url":"https://api.github.com/users/GraceH/repos","events_url":"https://api.github.com/users/GraceH/events{/privacy}","received_events_url":"https://api.github.com/users/GraceH/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":23,"created_at":"2015-11-18T07:08:14Z","updated_at":"2015-12-16T02:44:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/9796","html_url":"https://github.com/apache/spark/pull/9796","diff_url":"https://github.com/apache/spark/pull/9796.diff","patch_url":"https://github.com/apache/spark/pull/9796.patch"},"body":"In discussion (SPARK-9552), we proposed a force kill in `killExecutors`. But if there is nothing to kill, it will return back with true (acknowledgement). And then, it causes the certain executor(s) (which is not eligible to kill) adding to pendingToRemove list for further actions. \r\n\r\nIn this patch, we'd like to change the return semantics. If there is nothing to kill, we will return \"false\". and therefore  all those non-eligible executors won't be added to the pendingToRemove list. \r\n\r\n@vanzin @andrewor14 As the follow up of PR#7888, please let me know your comments."},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/164968673","html_url":"https://github.com/apache/spark/pull/9796#issuecomment-164968673","issue_url":"https://api.github.com/repos/apache/spark/issues/9796","id":164968673,"user":{"login":"andrewor14","id":2133137,"avatar_url":"https://avatars.githubusercontent.com/u/2133137?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewor14","html_url":"https://github.com/andrewor14","followers_url":"https://api.github.com/users/andrewor14/followers","following_url":"https://api.github.com/users/andrewor14/following{/other_user}","gists_url":"https://api.github.com/users/andrewor14/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewor14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewor14/subscriptions","organizations_url":"https://api.github.com/users/andrewor14/orgs","repos_url":"https://api.github.com/users/andrewor14/repos","events_url":"https://api.github.com/users/andrewor14/events{/privacy}","received_events_url":"https://api.github.com/users/andrewor14/received_events","type":"User","site_admin":false},"created_at":"2015-12-16T02:44:45Z","updated_at":"2015-12-16T02:44:45Z","body":"This is not ready for merge yet, please see the unresolved comments thread."}}