{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/git-client-plugin/issues/185","labels_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/issues/185/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/issues/185/comments","events_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/issues/185/events","html_url":"https://github.com/jenkinsci/git-client-plugin/pull/185","id":107456104,"number":185,"title":"[JENKINS-30486] Added --no-commit option to MergeCommand","user":{"login":"praqma-thi","id":12794699,"avatar_url":"https://avatars.githubusercontent.com/u/12794699?v=3","gravatar_id":"","url":"https://api.github.com/users/praqma-thi","html_url":"https://github.com/praqma-thi","followers_url":"https://api.github.com/users/praqma-thi/followers","following_url":"https://api.github.com/users/praqma-thi/following{/other_user}","gists_url":"https://api.github.com/users/praqma-thi/gists{/gist_id}","starred_url":"https://api.github.com/users/praqma-thi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praqma-thi/subscriptions","organizations_url":"https://api.github.com/users/praqma-thi/orgs","repos_url":"https://api.github.com/users/praqma-thi/repos","events_url":"https://api.github.com/users/praqma-thi/events{/privacy}","received_events_url":"https://api.github.com/users/praqma-thi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-21T07:06:32Z","updated_at":"2015-09-21T12:01:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/git-client-plugin/pulls/185","html_url":"https://github.com/jenkinsci/git-client-plugin/pull/185","diff_url":"https://github.com/jenkinsci/git-client-plugin/pull/185.diff","patch_url":"https://github.com/jenkinsci/git-client-plugin/pull/185.patch"},"body":"### Background\r\nWe are planning to use the Credentials API in our Pretested Integration plugin, but we're lacking certain features in the Git Client plugin. The ability to merge without committing being one of them.\r\nRelated issue: [JENKINS-30486](https://issues.jenkins-ci.org/browse/JENKINS-30486)\r\n\r\n### Implementation\r\nThe MergeCommand interface now requires a setCommit(boolean commit) implementation which both JGitAPIImpl and CliGitAPIImpl received. Commit defaults to true as to not change the plugin's default behaviour.\r\n\r\n### Testing\r\nTwo test cases were added to GitAPITestCase to test both a committed and non-commited merge. We also tested our own plugin, using the no-commit option, and all our tests pass as well.\r\n"},"comment":{"url":"https://api.github.com/repos/jenkinsci/git-client-plugin/issues/comments/141952006","html_url":"https://github.com/jenkinsci/git-client-plugin/pull/185#issuecomment-141952006","issue_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/issues/185","id":141952006,"user":{"login":"jenkinsadmin","id":874715,"avatar_url":"https://avatars.githubusercontent.com/u/874715?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsadmin","html_url":"https://github.com/jenkinsadmin","followers_url":"https://api.github.com/users/jenkinsadmin/followers","following_url":"https://api.github.com/users/jenkinsadmin/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsadmin/subscriptions","organizations_url":"https://api.github.com/users/jenkinsadmin/orgs","repos_url":"https://api.github.com/users/jenkinsadmin/repos","events_url":"https://api.github.com/users/jenkinsadmin/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsadmin/received_events","type":"User","site_admin":false},"created_at":"2015-09-21T12:01:55Z","updated_at":"2015-09-21T12:01:55Z","body":"Thank you for a pull request! Please check [this document](http://jenkins-ci.org/pull-request-greeting) for how the Jenkins project handles pull requests"}}