{"push_id":824083712,"size":2,"distinct_size":1,"ref":"refs/heads/master","head":"c6bd9ab4dde9d7e838b6b430a01ba4991bc3f5f1","before":"82afbd4088a0bc58b3a4f10c08ca4400ceba90cc","commits":[{"sha":"d870bf5cd88723ff625888fd54581fe76effcd5c","author":{"email":"a1e42c28a61d4bf0ebab79fa65b351ac4012b8e7@humaninference.com","name":"Dennis Du Krøger"},"message":"Avoid potentially losing lines\n\nThis is more of a workaround than a proper fix, but a proper fix is a bit limited by our interface. The main issue is that the property widgets all have their own listeners directly connected to the builders, making it hard to control listeners without yanking the entire dialog window (which is actually still not bullet-proof). A proper fix would probably only allow (or strongly encourage) listeners to listen to their dialog, which would then have a general component listener (also not currently supported) on the component and/or analysisJobListener.\n\nLuckily, only MultipleInputColumnsPropertyWidget seems to have been directly looking at the input from the listener, instead of just updatingfrom the general state, which should make the other TransformerChangeListener-implementing PropertyWidgets immune. Heavy testing is still recommended, though.\n\nFixes #667\nAlso contains a fix for re-adding listeners, as well as a wrong addTransformerChangeListener on panel close (none of them actually .","distinct":false,"url":"https://api.github.com/repos/datacleaner/DataCleaner/commits/d870bf5cd88723ff625888fd54581fe76effcd5c"},{"sha":"c6bd9ab4dde9d7e838b6b430a01ba4991bc3f5f1","author":{"email":"19218da7fdd83051553ec35265f8700a58d0e903@gmail.com","name":"Kasper Sørensen"},"message":"Merge pull request #783 from datacleaner/bug/667-dont-lose-lines\n\nAvoid potentially losing lines","distinct":true,"url":"https://api.github.com/repos/datacleaner/DataCleaner/commits/c6bd9ab4dde9d7e838b6b430a01ba4991bc3f5f1"}]}