{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/47421993","id":47421993,"diff_hunk":"@@ -270,3 +274,131 @@ func testRollingUpdateDeploymentEvents(f *Framework) {\n \tExpect(events.Items[0].Message).Should(Equal(fmt.Sprintf(\"Scaled up rc %s to 1\", newRC.Name)))\n \tExpect(events.Items[1].Message).Should(Equal(fmt.Sprintf(\"Scaled down rc %s to 0\", rcName)))\n }\n+\n+func testRolloverDeployment(f *Framework) {\n+\tns := f.Namespace.Name\n+\tc := f.Client\n+\tdeploymentPodLabels := map[string]string{\"name\": \"sample-pod\"}\n+\trcPodLabels := map[string]string{\n+\t\t\"name\": \"sample-pod\",\n+\t\t\"pod\":  \"nginx\",\n+\t}\n+\n+\trcName := \"nginx-controller\"\n+\trcReplicas := 4\n+\t_, err := c.ReplicationControllers(ns).Create(&api.ReplicationController{","path":"test/e2e/deployment.go","position":34,"original_position":34,"commit_id":"dc0d1ebfd0fb9c2d979cb3795270b3ec3c1e849d","original_commit_id":"dc0d1ebfd0fb9c2d979cb3795270b3ec3c1e849d","user":{"login":"nikhiljindal","id":10199099,"avatar_url":"https://avatars.githubusercontent.com/u/10199099?v=3","gravatar_id":"","url":"https://api.github.com/users/nikhiljindal","html_url":"https://github.com/nikhiljindal","followers_url":"https://api.github.com/users/nikhiljindal/followers","following_url":"https://api.github.com/users/nikhiljindal/following{/other_user}","gists_url":"https://api.github.com/users/nikhiljindal/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhiljindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhiljindal/subscriptions","organizations_url":"https://api.github.com/users/nikhiljindal/orgs","repos_url":"https://api.github.com/users/nikhiljindal/repos","events_url":"https://api.github.com/users/nikhiljindal/events{/privacy}","received_events_url":"https://api.github.com/users/nikhiljindal/received_events","type":"User","site_admin":false},"body":"This is almost same as ReplicationController in testRollingUpdateDeployment. Extract it out into a function rather than duplicating.","created_at":"2015-12-12T00:37:07Z","updated_at":"2015-12-12T00:37:07Z","html_url":"https://github.com/kubernetes/kubernetes/pull/18125#discussion_r47421993","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18125","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/47421993"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/18125#discussion_r47421993"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18125"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18125","id":52479975,"html_url":"https://github.com/kubernetes/kubernetes/pull/18125","diff_url":"https://github.com/kubernetes/kubernetes/pull/18125.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/18125.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/18125","number":18125,"state":"open","locked":false,"title":"Add test for deployment rollover","user":{"login":"janetkuo","id":4876867,"avatar_url":"https://avatars.githubusercontent.com/u/4876867?v=3","gravatar_id":"","url":"https://api.github.com/users/janetkuo","html_url":"https://github.com/janetkuo","followers_url":"https://api.github.com/users/janetkuo/followers","following_url":"https://api.github.com/users/janetkuo/following{/other_user}","gists_url":"https://api.github.com/users/janetkuo/gists{/gist_id}","starred_url":"https://api.github.com/users/janetkuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janetkuo/subscriptions","organizations_url":"https://api.github.com/users/janetkuo/orgs","repos_url":"https://api.github.com/users/janetkuo/repos","events_url":"https://api.github.com/users/janetkuo/events{/privacy}","received_events_url":"https://api.github.com/users/janetkuo/received_events","type":"User","site_admin":false},"body":"Fixes #11874 \r\n\r\ncc @kubernetes/sig-config @nikhiljindal ","created_at":"2015-12-03T01:23:23Z","updated_at":"2015-12-12T00:37:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57c8cba50e4d5fba9ea287902411ccca8d00e1e2","assignee":{"login":"nikhiljindal","id":10199099,"avatar_url":"https://avatars.githubusercontent.com/u/10199099?v=3","gravatar_id":"","url":"https://api.github.com/users/nikhiljindal","html_url":"https://github.com/nikhiljindal","followers_url":"https://api.github.com/users/nikhiljindal/followers","following_url":"https://api.github.com/users/nikhiljindal/following{/other_user}","gists_url":"https://api.github.com/users/nikhiljindal/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhiljindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhiljindal/subscriptions","organizations_url":"https://api.github.com/users/nikhiljindal/orgs","repos_url":"https://api.github.com/users/nikhiljindal/repos","events_url":"https://api.github.com/users/nikhiljindal/events{/privacy}","received_events_url":"https://api.github.com/users/nikhiljindal/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/15","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.2","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/15/labels","id":1278499,"number":15,"title":"v1.2","description":"https://github.com/kubernetes/kubernetes/wiki/Release-1.2","creator":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"open_issues":57,"closed_issues":23,"state":"open","created_at":"2015-08-29T03:54:16Z","updated_at":"2015-12-11T00:58:49Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18125/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18125/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/18125/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/dc0d1ebfd0fb9c2d979cb3795270b3ec3c1e849d","head":{"label":"janetkuo:rollover-test","ref":"rollover-test","sha":"dc0d1ebfd0fb9c2d979cb3795270b3ec3c1e849d","user":{"login":"janetkuo","id":4876867,"avatar_url":"https://avatars.githubusercontent.com/u/4876867?v=3","gravatar_id":"","url":"https://api.github.com/users/janetkuo","html_url":"https://github.com/janetkuo","followers_url":"https://api.github.com/users/janetkuo/followers","following_url":"https://api.github.com/users/janetkuo/following{/other_user}","gists_url":"https://api.github.com/users/janetkuo/gists{/gist_id}","starred_url":"https://api.github.com/users/janetkuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janetkuo/subscriptions","organizations_url":"https://api.github.com/users/janetkuo/orgs","repos_url":"https://api.github.com/users/janetkuo/repos","events_url":"https://api.github.com/users/janetkuo/events{/privacy}","received_events_url":"https://api.github.com/users/janetkuo/received_events","type":"User","site_admin":false},"repo":{"id":37748937,"name":"kubernetes","full_name":"janetkuo/kubernetes","owner":{"login":"janetkuo","id":4876867,"avatar_url":"https://avatars.githubusercontent.com/u/4876867?v=3","gravatar_id":"","url":"https://api.github.com/users/janetkuo","html_url":"https://github.com/janetkuo","followers_url":"https://api.github.com/users/janetkuo/followers","following_url":"https://api.github.com/users/janetkuo/following{/other_user}","gists_url":"https://api.github.com/users/janetkuo/gists{/gist_id}","starred_url":"https://api.github.com/users/janetkuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janetkuo/subscriptions","organizations_url":"https://api.github.com/users/janetkuo/orgs","repos_url":"https://api.github.com/users/janetkuo/repos","events_url":"https://api.github.com/users/janetkuo/events{/privacy}","received_events_url":"https://api.github.com/users/janetkuo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/janetkuo/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/janetkuo/kubernetes","forks_url":"https://api.github.com/repos/janetkuo/kubernetes/forks","keys_url":"https://api.github.com/repos/janetkuo/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/janetkuo/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/janetkuo/kubernetes/teams","hooks_url":"https://api.github.com/repos/janetkuo/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/janetkuo/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/janetkuo/kubernetes/events","assignees_url":"https://api.github.com/repos/janetkuo/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/janetkuo/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/janetkuo/kubernetes/tags","blobs_url":"https://api.github.com/repos/janetkuo/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/janetkuo/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/janetkuo/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/janetkuo/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/janetkuo/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/janetkuo/kubernetes/languages","stargazers_url":"https://api.github.com/repos/janetkuo/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/janetkuo/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/janetkuo/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/janetkuo/kubernetes/subscription","commits_url":"https://api.github.com/repos/janetkuo/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/janetkuo/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/janetkuo/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/janetkuo/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/janetkuo/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/janetkuo/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/janetkuo/kubernetes/merges","archive_url":"https://api.github.com/repos/janetkuo/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/janetkuo/kubernetes/downloads","issues_url":"https://api.github.com/repos/janetkuo/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/janetkuo/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/janetkuo/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/janetkuo/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/janetkuo/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/janetkuo/kubernetes/releases{/id}","created_at":"2015-06-19T22:29:18Z","updated_at":"2015-06-19T22:29:25Z","pushed_at":"2015-12-11T00:58:03Z","git_url":"git://github.com/janetkuo/kubernetes.git","ssh_url":"git@github.com:janetkuo/kubernetes.git","clone_url":"https://github.com/janetkuo/kubernetes.git","svn_url":"https://github.com/janetkuo/kubernetes","homepage":"http://kubernetes.io","size":138573,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"929ab328656947dc2c7b9fb13933cb9626a5b643","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-12-11T23:56:57Z","pushed_at":"2015-12-11T23:49:52Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":291905,"stargazers_count":11727,"watchers_count":11727,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3193,"mirror_url":null,"open_issues_count":2578,"forks":3193,"open_issues":2578,"watchers":11727,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18125"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/18125"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/18125"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/18125/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18125/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18125/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/dc0d1ebfd0fb9c2d979cb3795270b3ec3c1e849d"}}}}