{"action":"created","comment":{"url":"https://api.github.com/repos/ros2/rmw/pulls/comments/36257664","id":36257664,"diff_hunk":"@@ -0,0 +1,64 @@\n+// Copyright 2015 Open Source Robotics Foundation, Inc.\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+//     http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+#ifndef ROS_MIDDLEWARE_INTERFACE_ROS_MIDDLEWARE_INTERFACE_QOS_PROFILES_H_\n+#define ROS_MIDDLEWARE_INTERFACE_ROS_MIDDLEWARE_INTERFACE_QOS_PROFILES_H_\n+\n+#if __cplusplus\n+extern \"C\"\n+{\n+#endif\n+\n+#include \"types.h\"\n+\n+const static rmw_qos_policy_t rmw_qos_profile_sensor_data =","path":"rmw/include/rmw/qos_profiles.h","position":25,"original_position":25,"commit_id":"17fc10388df0d2b5ce7a2526f7160a5d787c2cdc","original_commit_id":"17fc10388df0d2b5ce7a2526f7160a5d787c2cdc","user":{"login":"esteve","id":33620,"avatar_url":"https://avatars.githubusercontent.com/u/33620?v=3","gravatar_id":"","url":"https://api.github.com/users/esteve","html_url":"https://github.com/esteve","followers_url":"https://api.github.com/users/esteve/followers","following_url":"https://api.github.com/users/esteve/following{/other_user}","gists_url":"https://api.github.com/users/esteve/gists{/gist_id}","starred_url":"https://api.github.com/users/esteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esteve/subscriptions","organizations_url":"https://api.github.com/users/esteve/orgs","repos_url":"https://api.github.com/users/esteve/repos","events_url":"https://api.github.com/users/esteve/events{/privacy}","received_events_url":"https://api.github.com/users/esteve/received_events","type":"User","site_admin":false},"body":"This PR fails on Windows because of the struct initialization syntax, I'll fix it and check if it needs the visibility macros:\r\n\r\nhttp://ci.ros2.org/job/ros2_batch_ci_windows/101/console\r\n\r\n","created_at":"2015-08-05T00:10:25Z","updated_at":"2015-08-05T00:10:25Z","html_url":"https://github.com/ros2/rmw/pull/15#discussion_r36257664","pull_request_url":"https://api.github.com/repos/ros2/rmw/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/ros2/rmw/pulls/comments/36257664"},"html":{"href":"https://github.com/ros2/rmw/pull/15#discussion_r36257664"},"pull_request":{"href":"https://api.github.com/repos/ros2/rmw/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/ros2/rmw/pulls/15","id":38068085,"html_url":"https://github.com/ros2/rmw/pull/15","diff_url":"https://github.com/ros2/rmw/pull/15.diff","patch_url":"https://github.com/ros2/rmw/pull/15.patch","issue_url":"https://api.github.com/repos/ros2/rmw/issues/15","number":15,"state":"open","locked":false,"title":"Added basic qos for readers and writers","user":{"login":"esteve","id":33620,"avatar_url":"https://avatars.githubusercontent.com/u/33620?v=3","gravatar_id":"","url":"https://api.github.com/users/esteve","html_url":"https://github.com/esteve","followers_url":"https://api.github.com/users/esteve/followers","following_url":"https://api.github.com/users/esteve/following{/other_user}","gists_url":"https://api.github.com/users/esteve/gists{/gist_id}","starred_url":"https://api.github.com/users/esteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esteve/subscriptions","organizations_url":"https://api.github.com/users/esteve/orgs","repos_url":"https://api.github.com/users/esteve/repos","events_url":"https://api.github.com/users/esteve/events{/privacy}","received_events_url":"https://api.github.com/users/esteve/received_events","type":"User","site_admin":false},"body":"Connects to ros2/ros2#66","created_at":"2015-06-19T00:45:27Z","updated_at":"2015-08-05T00:10:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ad98572c07de0a9a2b3b8d34d9a7c2d499f4ab3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ros2/rmw/pulls/15/commits","review_comments_url":"https://api.github.com/repos/ros2/rmw/pulls/15/comments","review_comment_url":"https://api.github.com/repos/ros2/rmw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros2/rmw/issues/15/comments","statuses_url":"https://api.github.com/repos/ros2/rmw/statuses/17fc10388df0d2b5ce7a2526f7160a5d787c2cdc","head":{"label":"ros2:qos","ref":"qos","sha":"17fc10388df0d2b5ce7a2526f7160a5d787c2cdc","user":{"login":"ros2","id":3979232,"avatar_url":"https://avatars.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":22737319,"name":"rmw","full_name":"ros2/rmw","owner":{"login":"ros2","id":3979232,"avatar_url":"https://avatars.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros2/rmw","description":"The ROS Middleware (rmw) Interface.","fork":false,"url":"https://api.github.com/repos/ros2/rmw","forks_url":"https://api.github.com/repos/ros2/rmw/forks","keys_url":"https://api.github.com/repos/ros2/rmw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/rmw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/rmw/teams","hooks_url":"https://api.github.com/repos/ros2/rmw/hooks","issue_events_url":"https://api.github.com/repos/ros2/rmw/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/rmw/events","assignees_url":"https://api.github.com/repos/ros2/rmw/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/rmw/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/rmw/tags","blobs_url":"https://api.github.com/repos/ros2/rmw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/rmw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/rmw/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/rmw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/rmw/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/rmw/languages","stargazers_url":"https://api.github.com/repos/ros2/rmw/stargazers","contributors_url":"https://api.github.com/repos/ros2/rmw/contributors","subscribers_url":"https://api.github.com/repos/ros2/rmw/subscribers","subscription_url":"https://api.github.com/repos/ros2/rmw/subscription","commits_url":"https://api.github.com/repos/ros2/rmw/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/rmw/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/rmw/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/rmw/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/rmw/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/rmw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/rmw/merges","archive_url":"https://api.github.com/repos/ros2/rmw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/rmw/downloads","issues_url":"https://api.github.com/repos/ros2/rmw/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/rmw/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/rmw/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/rmw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/rmw/labels{/name}","releases_url":"https://api.github.com/repos/ros2/rmw/releases{/id}","created_at":"2014-08-07T21:35:58Z","updated_at":"2015-04-30T00:26:40Z","pushed_at":"2015-08-04T22:32:45Z","git_url":"git://github.com/ros2/rmw.git","ssh_url":"git@github.com:ros2/rmw.git","clone_url":"https://github.com/ros2/rmw.git","svn_url":"https://github.com/ros2/rmw","homepage":"","size":843,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":6,"forks":2,"open_issues":6,"watchers":1,"default_branch":"master"}},"base":{"label":"ros2:master","ref":"master","sha":"8faaa2e44bc989ed04946b0dfa15ed75874ae41f","user":{"login":"ros2","id":3979232,"avatar_url":"https://avatars.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":22737319,"name":"rmw","full_name":"ros2/rmw","owner":{"login":"ros2","id":3979232,"avatar_url":"https://avatars.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros2/rmw","description":"The ROS Middleware (rmw) Interface.","fork":false,"url":"https://api.github.com/repos/ros2/rmw","forks_url":"https://api.github.com/repos/ros2/rmw/forks","keys_url":"https://api.github.com/repos/ros2/rmw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/rmw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/rmw/teams","hooks_url":"https://api.github.com/repos/ros2/rmw/hooks","issue_events_url":"https://api.github.com/repos/ros2/rmw/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/rmw/events","assignees_url":"https://api.github.com/repos/ros2/rmw/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/rmw/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/rmw/tags","blobs_url":"https://api.github.com/repos/ros2/rmw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/rmw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/rmw/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/rmw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/rmw/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/rmw/languages","stargazers_url":"https://api.github.com/repos/ros2/rmw/stargazers","contributors_url":"https://api.github.com/repos/ros2/rmw/contributors","subscribers_url":"https://api.github.com/repos/ros2/rmw/subscribers","subscription_url":"https://api.github.com/repos/ros2/rmw/subscription","commits_url":"https://api.github.com/repos/ros2/rmw/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/rmw/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/rmw/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/rmw/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/rmw/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/rmw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/rmw/merges","archive_url":"https://api.github.com/repos/ros2/rmw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/rmw/downloads","issues_url":"https://api.github.com/repos/ros2/rmw/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/rmw/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/rmw/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/rmw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/rmw/labels{/name}","releases_url":"https://api.github.com/repos/ros2/rmw/releases{/id}","created_at":"2014-08-07T21:35:58Z","updated_at":"2015-04-30T00:26:40Z","pushed_at":"2015-08-04T22:32:45Z","git_url":"git://github.com/ros2/rmw.git","ssh_url":"git@github.com:ros2/rmw.git","clone_url":"https://github.com/ros2/rmw.git","svn_url":"https://github.com/ros2/rmw","homepage":"","size":843,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":6,"forks":2,"open_issues":6,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ros2/rmw/pulls/15"},"html":{"href":"https://github.com/ros2/rmw/pull/15"},"issue":{"href":"https://api.github.com/repos/ros2/rmw/issues/15"},"comments":{"href":"https://api.github.com/repos/ros2/rmw/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/ros2/rmw/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/ros2/rmw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros2/rmw/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/ros2/rmw/statuses/17fc10388df0d2b5ce7a2526f7160a5d787c2cdc"}}}}