{"action":"created","comment":{"url":"https://api.github.com/repos/chef/chef/pulls/comments/25629404","id":25629404,"diff_hunk":"@@ -593,6 +593,20 @@ def certificates\n         knife.run\n       end\n     end\n+\n+    context \"when the validation_key is nil\" do\n+      before do\n+        # this tests runs the old code path where we have a validation key, so we need to pass that check for some plugins\n+        Chef::Config[:validation_key] = nil\n+      end\n+\n+      it \"creates the client (and possibly adds chef-vault items)\" do\n+        expect(knife_ssh).to receive(:run)\n+        expect(knife.client_builder).not_to receive(:run)\n+        expect(knife.chef_vault_handler).not_to receive(:run).with(node_name: knife.config[:chef_node_name])","path":"spec/unit/knife/bootstrap_spec.rb","position":14,"original_position":14,"commit_id":"7949a6ee09dac336aea0665b76dcfa8b4cb37f32","original_commit_id":"7949a6ee09dac336aea0665b76dcfa8b4cb37f32","user":{"login":"lamont-granquist","id":454857,"avatar_url":"https://avatars.githubusercontent.com/u/454857?v=3","gravatar_id":"","url":"https://api.github.com/users/lamont-granquist","html_url":"https://github.com/lamont-granquist","followers_url":"https://api.github.com/users/lamont-granquist/followers","following_url":"https://api.github.com/users/lamont-granquist/following{/other_user}","gists_url":"https://api.github.com/users/lamont-granquist/gists{/gist_id}","starred_url":"https://api.github.com/users/lamont-granquist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamont-granquist/subscriptions","organizations_url":"https://api.github.com/users/lamont-granquist/orgs","repos_url":"https://api.github.com/users/lamont-granquist/repos","events_url":"https://api.github.com/users/lamont-granquist/events{/privacy}","received_events_url":"https://api.github.com/users/lamont-granquist/received_events","type":"User","site_admin":false},"body":"No, it shouldn't receive either of those with any args.","created_at":"2015-03-02T19:29:55Z","updated_at":"2015-03-02T19:29:55Z","html_url":"https://github.com/chef/chef/pull/2988#discussion_r25629404","pull_request_url":"https://api.github.com/repos/chef/chef/pulls/2988","_links":{"self":{"href":"https://api.github.com/repos/chef/chef/pulls/comments/25629404"},"html":{"href":"https://github.com/chef/chef/pull/2988#discussion_r25629404"},"pull_request":{"href":"https://api.github.com/repos/chef/chef/pulls/2988"}}},"pull_request":{"url":"https://api.github.com/repos/chef/chef/pulls/2988","id":30150472,"html_url":"https://github.com/chef/chef/pull/2988","diff_url":"https://github.com/chef/chef/pull/2988.diff","patch_url":"https://github.com/chef/chef/pull/2988.patch","issue_url":"https://api.github.com/repos/chef/chef/issues/2988","number":2988,"state":"open","locked":false,"title":"The knife bootstrap raises `ERROR: TypeError: no implicit conversion of nil into String`  when Chef::Config[:validation_key] is nil.","user":{"login":"sawanoboly","id":272388,"avatar_url":"https://avatars.githubusercontent.com/u/272388?v=3","gravatar_id":"","url":"https://api.github.com/users/sawanoboly","html_url":"https://github.com/sawanoboly","followers_url":"https://api.github.com/users/sawanoboly/followers","following_url":"https://api.github.com/users/sawanoboly/following{/other_user}","gists_url":"https://api.github.com/users/sawanoboly/gists{/gist_id}","starred_url":"https://api.github.com/users/sawanoboly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sawanoboly/subscriptions","organizations_url":"https://api.github.com/users/sawanoboly/orgs","repos_url":"https://api.github.com/users/sawanoboly/repos","events_url":"https://api.github.com/users/sawanoboly/events{/privacy}","received_events_url":"https://api.github.com/users/sawanoboly/received_events","type":"User","site_admin":false},"body":"It will break compatibility of my plugin.\r\n\r\nPlease check that it is not nil before file existence check.","created_at":"2015-02-27T09:01:21Z","updated_at":"2015-03-02T19:29:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7859a841bf3c38c070b73061e61d00c1d16140f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/chef/chef/pulls/2988/commits","review_comments_url":"https://api.github.com/repos/chef/chef/pulls/2988/comments","review_comment_url":"https://api.github.com/repos/chef/chef/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef/chef/issues/2988/comments","statuses_url":"https://api.github.com/repos/chef/chef/statuses/7949a6ee09dac336aea0665b76dcfa8b4cb37f32","head":{"label":"higanworks:case_validation_key_is_nil_on_bootstrap","ref":"case_validation_key_is_nil_on_bootstrap","sha":"7949a6ee09dac336aea0665b76dcfa8b4cb37f32","user":{"login":"higanworks","id":1356239,"avatar_url":"https://avatars.githubusercontent.com/u/1356239?v=3","gravatar_id":"","url":"https://api.github.com/users/higanworks","html_url":"https://github.com/higanworks","followers_url":"https://api.github.com/users/higanworks/followers","following_url":"https://api.github.com/users/higanworks/following{/other_user}","gists_url":"https://api.github.com/users/higanworks/gists{/gist_id}","starred_url":"https://api.github.com/users/higanworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/higanworks/subscriptions","organizations_url":"https://api.github.com/users/higanworks/orgs","repos_url":"https://api.github.com/users/higanworks/repos","events_url":"https://api.github.com/users/higanworks/events{/privacy}","received_events_url":"https://api.github.com/users/higanworks/received_events","type":"Organization","site_admin":false},"repo":{"id":7494349,"name":"chef","full_name":"higanworks/chef","owner":{"login":"higanworks","id":1356239,"avatar_url":"https://avatars.githubusercontent.com/u/1356239?v=3","gravatar_id":"","url":"https://api.github.com/users/higanworks","html_url":"https://github.com/higanworks","followers_url":"https://api.github.com/users/higanworks/followers","following_url":"https://api.github.com/users/higanworks/following{/other_user}","gists_url":"https://api.github.com/users/higanworks/gists{/gist_id}","starred_url":"https://api.github.com/users/higanworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/higanworks/subscriptions","organizations_url":"https://api.github.com/users/higanworks/orgs","repos_url":"https://api.github.com/users/higanworks/repos","events_url":"https://api.github.com/users/higanworks/events{/privacy}","received_events_url":"https://api.github.com/users/higanworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/higanworks/chef","description":"A systems integration framework, built to bring the benefits of configuration management to your entire infrastructure.","fork":true,"url":"https://api.github.com/repos/higanworks/chef","forks_url":"https://api.github.com/repos/higanworks/chef/forks","keys_url":"https://api.github.com/repos/higanworks/chef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/higanworks/chef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/higanworks/chef/teams","hooks_url":"https://api.github.com/repos/higanworks/chef/hooks","issue_events_url":"https://api.github.com/repos/higanworks/chef/issues/events{/number}","events_url":"https://api.github.com/repos/higanworks/chef/events","assignees_url":"https://api.github.com/repos/higanworks/chef/assignees{/user}","branches_url":"https://api.github.com/repos/higanworks/chef/branches{/branch}","tags_url":"https://api.github.com/repos/higanworks/chef/tags","blobs_url":"https://api.github.com/repos/higanworks/chef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/higanworks/chef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/higanworks/chef/git/refs{/sha}","trees_url":"https://api.github.com/repos/higanworks/chef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/higanworks/chef/statuses/{sha}","languages_url":"https://api.github.com/repos/higanworks/chef/languages","stargazers_url":"https://api.github.com/repos/higanworks/chef/stargazers","contributors_url":"https://api.github.com/repos/higanworks/chef/contributors","subscribers_url":"https://api.github.com/repos/higanworks/chef/subscribers","subscription_url":"https://api.github.com/repos/higanworks/chef/subscription","commits_url":"https://api.github.com/repos/higanworks/chef/commits{/sha}","git_commits_url":"https://api.github.com/repos/higanworks/chef/git/commits{/sha}","comments_url":"https://api.github.com/repos/higanworks/chef/comments{/number}","issue_comment_url":"https://api.github.com/repos/higanworks/chef/issues/comments{/number}","contents_url":"https://api.github.com/repos/higanworks/chef/contents/{+path}","compare_url":"https://api.github.com/repos/higanworks/chef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/higanworks/chef/merges","archive_url":"https://api.github.com/repos/higanworks/chef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/higanworks/chef/downloads","issues_url":"https://api.github.com/repos/higanworks/chef/issues{/number}","pulls_url":"https://api.github.com/repos/higanworks/chef/pulls{/number}","milestones_url":"https://api.github.com/repos/higanworks/chef/milestones{/number}","notifications_url":"https://api.github.com/repos/higanworks/chef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/higanworks/chef/labels{/name}","releases_url":"https://api.github.com/repos/higanworks/chef/releases{/id}","created_at":"2013-01-08T02:45:00Z","updated_at":"2015-02-27T07:02:27Z","pushed_at":"2015-02-27T08:53:48Z","git_url":"git://github.com/higanworks/chef.git","ssh_url":"git@github.com:higanworks/chef.git","clone_url":"https://github.com/higanworks/chef.git","svn_url":"https://github.com/higanworks/chef","homepage":"http://www.opscode.com/chef/","size":77914,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chef:master","ref":"master","sha":"c2dfb56e730214266ae07a57a56e5889b1e6b85b","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":108278,"name":"chef","full_name":"chef/chef","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/chef","description":"A systems integration framework, built to bring the benefits of configuration management to your entire infrastructure.","fork":false,"url":"https://api.github.com/repos/chef/chef","forks_url":"https://api.github.com/repos/chef/chef/forks","keys_url":"https://api.github.com/repos/chef/chef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/chef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/chef/teams","hooks_url":"https://api.github.com/repos/chef/chef/hooks","issue_events_url":"https://api.github.com/repos/chef/chef/issues/events{/number}","events_url":"https://api.github.com/repos/chef/chef/events","assignees_url":"https://api.github.com/repos/chef/chef/assignees{/user}","branches_url":"https://api.github.com/repos/chef/chef/branches{/branch}","tags_url":"https://api.github.com/repos/chef/chef/tags","blobs_url":"https://api.github.com/repos/chef/chef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/chef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/chef/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/chef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/chef/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/chef/languages","stargazers_url":"https://api.github.com/repos/chef/chef/stargazers","contributors_url":"https://api.github.com/repos/chef/chef/contributors","subscribers_url":"https://api.github.com/repos/chef/chef/subscribers","subscription_url":"https://api.github.com/repos/chef/chef/subscription","commits_url":"https://api.github.com/repos/chef/chef/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/chef/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/chef/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/chef/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/chef/contents/{+path}","compare_url":"https://api.github.com/repos/chef/chef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/chef/merges","archive_url":"https://api.github.com/repos/chef/chef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/chef/downloads","issues_url":"https://api.github.com/repos/chef/chef/issues{/number}","pulls_url":"https://api.github.com/repos/chef/chef/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/chef/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/chef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/chef/labels{/name}","releases_url":"https://api.github.com/repos/chef/chef/releases{/id}","created_at":"2009-01-15T20:40:48Z","updated_at":"2015-03-02T18:58:43Z","pushed_at":"2015-03-02T18:58:51Z","git_url":"git://github.com/chef/chef.git","ssh_url":"git@github.com:chef/chef.git","clone_url":"https://github.com/chef/chef.git","svn_url":"https://github.com/chef/chef","homepage":"http://www.chef.io/chef/","size":161539,"stargazers_count":3395,"watchers_count":3395,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1371,"mirror_url":null,"open_issues_count":374,"forks":1371,"open_issues":374,"watchers":3395,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef/chef/pulls/2988"},"html":{"href":"https://github.com/chef/chef/pull/2988"},"issue":{"href":"https://api.github.com/repos/chef/chef/issues/2988"},"comments":{"href":"https://api.github.com/repos/chef/chef/issues/2988/comments"},"review_comments":{"href":"https://api.github.com/repos/chef/chef/pulls/2988/comments"},"review_comment":{"href":"https://api.github.com/repos/chef/chef/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef/chef/pulls/2988/commits"},"statuses":{"href":"https://api.github.com/repos/chef/chef/statuses/7949a6ee09dac336aea0665b76dcfa8b4cb37f32"}}}}