{"action":"created","issue":{"url":"https://api.github.com/repos/autotest/tp-libvirt/issues/630","labels_url":"https://api.github.com/repos/autotest/tp-libvirt/issues/630/labels{/name}","comments_url":"https://api.github.com/repos/autotest/tp-libvirt/issues/630/comments","events_url":"https://api.github.com/repos/autotest/tp-libvirt/issues/630/events","html_url":"https://github.com/autotest/tp-libvirt/pull/630","id":102297719,"number":630,"title":"macvtap: fix ping failure for passthrough case","user":{"login":"PandaWei","id":5038445,"avatar_url":"https://avatars.githubusercontent.com/u/5038445?v=3","gravatar_id":"","url":"https://api.github.com/users/PandaWei","html_url":"https://github.com/PandaWei","followers_url":"https://api.github.com/users/PandaWei/followers","following_url":"https://api.github.com/users/PandaWei/following{/other_user}","gists_url":"https://api.github.com/users/PandaWei/gists{/gist_id}","starred_url":"https://api.github.com/users/PandaWei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PandaWei/subscriptions","organizations_url":"https://api.github.com/users/PandaWei/orgs","repos_url":"https://api.github.com/users/PandaWei/repos","events_url":"https://api.github.com/users/PandaWei/events{/privacy}","received_events_url":"https://api.github.com/users/PandaWei/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-08-21T04:43:32Z","updated_at":"2015-09-25T01:36:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/autotest/tp-libvirt/pulls/630","html_url":"https://github.com/autotest/tp-libvirt/pull/630","diff_url":"https://github.com/autotest/tp-libvirt/pull/630.diff","patch_url":"https://github.com/autotest/tp-libvirt/pull/630.patch"},"body":"1) The macvtap NIC ifcfg-file that created by RemoteFile.add()\r\ndoesn't includes newline char '\\n', which leads to ifup fails,\r\nat the end, ping the remote server also fails. As following,\r\n\r\n[root@atest-guest ~]# cat /etc/redhat-release\r\nRed Hat Enterprise Linux Server release 7.2 Beta (Maipo)\r\n[root@atest-guest ~]# cat /etc/sysconfig/network-scripts/ifcfg-eth1\r\nDEVICE=eth1\r\nHWADDR=52:54:00:5b:96:02\r\nONBOOT=yes\r\nBOOTPROTO=static\r\nIPADDR=193.168.236.112[root@atest-guest ~]#\r\n[root@atest-guest ~]# ifup eth1\r\nCould not load file '/etc/sysconfig/network-scripts/ifcfg-eth1'\r\nCould not load file '/etc/sysconfig/network-scripts/ifcfg-eth1'\r\n\r\n*Fix it by adding newline char to the end of ifcfg-eth1.\r\n\r\n[root@atest-guest ~]# cat /etc/sysconfig/network-scripts/ifcfg-eth1\r\nDEVICE=eth1\r\nHWADDR=52:54:00:5b:96:02\r\nONBOOT=yes\r\nBOOTPROTO=static\r\nIPADDR=193.168.236.112\r\n[root@atest-guest ~]# ifup eth1\r\n[root@atest-guest ~]# ifconfig -a\r\neth1: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 1500\r\n  inet 193.168.236.112  netmask 255.255.255.0 broadcast 193.168.236.255\r\n  inet6 fe80::5054:ff:fe51:fca3  prefixlen 64 scopeid  0x20<link>\r\n  ... skip ...\r\n\r\n2) checking the result of ifdown and ifup.\r\n\r\nSigned-off-by: Wei,Jiangang <weijg.fnst@cn.fujitsu.com>"},"comment":{"url":"https://api.github.com/repos/autotest/tp-libvirt/issues/comments/143098733","html_url":"https://github.com/autotest/tp-libvirt/pull/630#issuecomment-143098733","issue_url":"https://api.github.com/repos/autotest/tp-libvirt/issues/630","id":143098733,"user":{"login":"PandaWei","id":5038445,"avatar_url":"https://avatars.githubusercontent.com/u/5038445?v=3","gravatar_id":"","url":"https://api.github.com/users/PandaWei","html_url":"https://github.com/PandaWei","followers_url":"https://api.github.com/users/PandaWei/followers","following_url":"https://api.github.com/users/PandaWei/following{/other_user}","gists_url":"https://api.github.com/users/PandaWei/gists{/gist_id}","starred_url":"https://api.github.com/users/PandaWei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PandaWei/subscriptions","organizations_url":"https://api.github.com/users/PandaWei/orgs","repos_url":"https://api.github.com/users/PandaWei/repos","events_url":"https://api.github.com/users/PandaWei/events{/privacy}","received_events_url":"https://api.github.com/users/PandaWei/received_events","type":"User","site_admin":false},"created_at":"2015-09-25T01:36:41Z","updated_at":"2015-09-25T01:36:41Z","body":"avocado-framework/avocado-vt#121 has been merged,\r\nNow pass this PR"}}