{"action":"closed","number":93,"pull_request":{"url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/pulls/93","id":47016873,"html_url":"https://github.com/Metaswitch/clearwater-snmp-handlers/pull/93","diff_url":"https://github.com/Metaswitch/clearwater-snmp-handlers/pull/93.diff","patch_url":"https://github.com/Metaswitch/clearwater-snmp-handlers/pull/93.patch","issue_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/issues/93","number":93,"state":"closed","locked":false,"title":"[Reviewer: Andy] Fix up smilint warnings","user":{"login":"rkd-msw","id":4363492,"avatar_url":"https://avatars.githubusercontent.com/u/4363492?v=3","gravatar_id":"","url":"https://api.github.com/users/rkd-msw","html_url":"https://github.com/rkd-msw","followers_url":"https://api.github.com/users/rkd-msw/followers","following_url":"https://api.github.com/users/rkd-msw/following{/other_user}","gists_url":"https://api.github.com/users/rkd-msw/gists{/gist_id}","starred_url":"https://api.github.com/users/rkd-msw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkd-msw/subscriptions","organizations_url":"https://api.github.com/users/rkd-msw/orgs","repos_url":"https://api.github.com/users/rkd-msw/repos","events_url":"https://api.github.com/users/rkd-msw/events{/privacy}","received_events_url":"https://api.github.com/users/rkd-msw/received_events","type":"User","site_admin":false},"body":"Can you review this fix, to make `smilint ./PROJECT-CLEARWATER-MIB -l 5` run cleanly?\r\n\r\nIt:\r\n* fixes up some rogue commas\r\n* doesn't list inaccessible objects in astaireGroup\r\n* reworks the AstaireConnectionBucketBandwidthTable, following the guidance in http://stackoverflow.com/questions/2510211/snmp-asn-1-mib-definitions-referencing-a-table-within-a-table that nested tables should just be indexed by the parent table's index as well as their own\r\n\r\nI'll also change Jenkins to run that smilint command and fail the build if it fails.","created_at":"2015-10-07T11:45:49Z","updated_at":"2015-10-07T11:57:26Z","closed_at":"2015-10-07T11:57:26Z","merged_at":"2015-10-07T11:57:26Z","merge_commit_sha":"59e8b3aa733524cbf3e6dbd3f3e8ac2a68f3b271","assignee":{"login":"rkd-msw","id":4363492,"avatar_url":"https://avatars.githubusercontent.com/u/4363492?v=3","gravatar_id":"","url":"https://api.github.com/users/rkd-msw","html_url":"https://github.com/rkd-msw","followers_url":"https://api.github.com/users/rkd-msw/followers","following_url":"https://api.github.com/users/rkd-msw/following{/other_user}","gists_url":"https://api.github.com/users/rkd-msw/gists{/gist_id}","starred_url":"https://api.github.com/users/rkd-msw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkd-msw/subscriptions","organizations_url":"https://api.github.com/users/rkd-msw/orgs","repos_url":"https://api.github.com/users/rkd-msw/repos","events_url":"https://api.github.com/users/rkd-msw/events{/privacy}","received_events_url":"https://api.github.com/users/rkd-msw/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/pulls/93/commits","review_comments_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/pulls/93/comments","review_comment_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/issues/93/comments","statuses_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/statuses/7e61c8a6f026e770e2b2a08d051e29ed7d6bc8d2","head":{"label":"Metaswitch:smilint_fixes","ref":"smilint_fixes","sha":"7e61c8a6f026e770e2b2a08d051e29ed7d6bc8d2","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":13772926,"name":"clearwater-snmp-handlers","full_name":"Metaswitch/clearwater-snmp-handlers","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/clearwater-snmp-handlers","description":"SNMP extension modules to provide stats for Clearwater nodes","fork":false,"url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers","forks_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/forks","keys_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/teams","hooks_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/events","assignees_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/tags","blobs_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/subscription","commits_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/merges","archive_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/downloads","issues_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/releases{/id}","created_at":"2013-10-22T12:45:34Z","updated_at":"2015-05-07T12:01:43Z","pushed_at":"2015-10-07T11:57:26Z","git_url":"git://github.com/Metaswitch/clearwater-snmp-handlers.git","ssh_url":"git@github.com:Metaswitch/clearwater-snmp-handlers.git","clone_url":"https://github.com/Metaswitch/clearwater-snmp-handlers.git","svn_url":"https://github.com/Metaswitch/clearwater-snmp-handlers","homepage":null,"size":1356,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"Metaswitch:master","ref":"master","sha":"9477d06302a6b7c73a8b3b448447e2a8b72ce77e","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":13772926,"name":"clearwater-snmp-handlers","full_name":"Metaswitch/clearwater-snmp-handlers","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/clearwater-snmp-handlers","description":"SNMP extension modules to provide stats for Clearwater nodes","fork":false,"url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers","forks_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/forks","keys_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/teams","hooks_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/events","assignees_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/tags","blobs_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/subscription","commits_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/merges","archive_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/downloads","issues_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/releases{/id}","created_at":"2013-10-22T12:45:34Z","updated_at":"2015-05-07T12:01:43Z","pushed_at":"2015-10-07T11:57:26Z","git_url":"git://github.com/Metaswitch/clearwater-snmp-handlers.git","ssh_url":"git@github.com:Metaswitch/clearwater-snmp-handlers.git","clone_url":"https://github.com/Metaswitch/clearwater-snmp-handlers.git","svn_url":"https://github.com/Metaswitch/clearwater-snmp-handlers","homepage":null,"size":1356,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/pulls/93"},"html":{"href":"https://github.com/Metaswitch/clearwater-snmp-handlers/pull/93"},"issue":{"href":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/issues/93"},"comments":{"href":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/Metaswitch/clearwater-snmp-handlers/statuses/7e61c8a6f026e770e2b2a08d051e29ed7d6bc8d2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rkd-msw","id":4363492,"avatar_url":"https://avatars.githubusercontent.com/u/4363492?v=3","gravatar_id":"","url":"https://api.github.com/users/rkd-msw","html_url":"https://github.com/rkd-msw","followers_url":"https://api.github.com/users/rkd-msw/followers","following_url":"https://api.github.com/users/rkd-msw/following{/other_user}","gists_url":"https://api.github.com/users/rkd-msw/gists{/gist_id}","starred_url":"https://api.github.com/users/rkd-msw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkd-msw/subscriptions","organizations_url":"https://api.github.com/users/rkd-msw/orgs","repos_url":"https://api.github.com/users/rkd-msw/repos","events_url":"https://api.github.com/users/rkd-msw/events{/privacy}","received_events_url":"https://api.github.com/users/rkd-msw/received_events","type":"User","site_admin":false},"comments":2,"review_comments":1,"commits":3,"additions":80,"deletions":116,"changed_files":1}}