{"action":"created","issue":{"url":"https://api.github.com/repos/fmtvp/tal/issues/267","labels_url":"https://api.github.com/repos/fmtvp/tal/issues/267/labels{/name}","comments_url":"https://api.github.com/repos/fmtvp/tal/issues/267/comments","events_url":"https://api.github.com/repos/fmtvp/tal/issues/267/events","html_url":"https://github.com/fmtvp/tal/issues/267","id":93504198,"number":267,"title":"ECMAScript 5 Support","user":{"login":"joeyjojo","id":1236062,"avatar_url":"https://avatars.githubusercontent.com/u/1236062?v=3","gravatar_id":"","url":"https://api.github.com/users/joeyjojo","html_url":"https://github.com/joeyjojo","followers_url":"https://api.github.com/users/joeyjojo/followers","following_url":"https://api.github.com/users/joeyjojo/following{/other_user}","gists_url":"https://api.github.com/users/joeyjojo/gists{/gist_id}","starred_url":"https://api.github.com/users/joeyjojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeyjojo/subscriptions","organizations_url":"https://api.github.com/users/joeyjojo/orgs","repos_url":"https://api.github.com/users/joeyjojo/repos","events_url":"https://api.github.com/users/joeyjojo/events{/privacy}","received_events_url":"https://api.github.com/users/joeyjojo/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-07T10:58:41Z","updated_at":"2015-07-08T15:47:16Z","closed_at":"2015-07-08T15:47:16Z","body":"I think its worth considering shimming out support for ECMAScript 5 (using es5-shim and sham) rather than doing things weirdly ourselves.\r\n\r\nFor instance Array.indexOf, this is ES5, so we have to provide a solution for using it.\r\n\r\nCurrently we have an implementation in browserdevice.js, as an outsider, this is a bit weird. Most JS developers would expect this to be on the Array prototype.\r\n\r\nWhat this means is that we have also introduced duplication because intervalformat.js also has an implementation.\r\n\r\nFurther to that, the implementation we have doesn't match the spec as given (https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Array/indexOf) and so is a bit different."},"comment":{"url":"https://api.github.com/repos/fmtvp/tal/issues/comments/119631293","html_url":"https://github.com/fmtvp/tal/issues/267#issuecomment-119631293","issue_url":"https://api.github.com/repos/fmtvp/tal/issues/267","id":119631293,"user":{"login":"tsadlerBBC","id":5602024,"avatar_url":"https://avatars.githubusercontent.com/u/5602024?v=3","gravatar_id":"","url":"https://api.github.com/users/tsadlerBBC","html_url":"https://github.com/tsadlerBBC","followers_url":"https://api.github.com/users/tsadlerBBC/followers","following_url":"https://api.github.com/users/tsadlerBBC/following{/other_user}","gists_url":"https://api.github.com/users/tsadlerBBC/gists{/gist_id}","starred_url":"https://api.github.com/users/tsadlerBBC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsadlerBBC/subscriptions","organizations_url":"https://api.github.com/users/tsadlerBBC/orgs","repos_url":"https://api.github.com/users/tsadlerBBC/repos","events_url":"https://api.github.com/users/tsadlerBBC/events{/privacy}","received_events_url":"https://api.github.com/users/tsadlerBBC/received_events","type":"User","site_admin":false},"created_at":"2015-07-08T15:47:16Z","updated_at":"2015-07-08T15:47:16Z","body":"Following discussions, this is not something we would want to introduce in TAL. es5-shim and sham can be used by TAL applications without it being a part of TAL, and we do not intend to replace the uses of browserDevice.arrayIndexOf within TAL."}}