{"action":"created","comment":{"url":"https://api.github.com/repos/iojs/io.js/pulls/comments/24441563","id":24441563,"diff_hunk":"@@ -388,6 +396,53 @@\n       nextTickQueue.push(obj);\n       tickInfo[kLength]++;\n     }\n+\n+    // Internal callbacks that must be run when there is no more micro-tasks\n+    // scheduled for this turn.","path":"src/node.js","position":45,"original_position":45,"commit_id":"f65c36df6df13d2b9ca6f0944f0e4b02572ac592","original_commit_id":"f65c36df6df13d2b9ca6f0944f0e4b02572ac592","user":{"login":"vkurchatkin","id":2993861,"avatar_url":"https://avatars.githubusercontent.com/u/2993861?v=3","gravatar_id":"","url":"https://api.github.com/users/vkurchatkin","html_url":"https://github.com/vkurchatkin","followers_url":"https://api.github.com/users/vkurchatkin/followers","following_url":"https://api.github.com/users/vkurchatkin/following{/other_user}","gists_url":"https://api.github.com/users/vkurchatkin/gists{/gist_id}","starred_url":"https://api.github.com/users/vkurchatkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkurchatkin/subscriptions","organizations_url":"https://api.github.com/users/vkurchatkin/orgs","repos_url":"https://api.github.com/users/vkurchatkin/repos","events_url":"https://api.github.com/users/vkurchatkin/events{/privacy}","received_events_url":"https://api.github.com/users/vkurchatkin/received_events","type":"User","site_admin":false},"body":"we don't need a queue of callbacks for this. what we want is a queue of promises","created_at":"2015-02-10T19:20:33Z","updated_at":"2015-02-10T19:20:33Z","html_url":"https://github.com/iojs/io.js/pull/758#discussion_r24441563","pull_request_url":"https://api.github.com/repos/iojs/io.js/pulls/758","_links":{"self":{"href":"https://api.github.com/repos/iojs/io.js/pulls/comments/24441563"},"html":{"href":"https://github.com/iojs/io.js/pull/758#discussion_r24441563"},"pull_request":{"href":"https://api.github.com/repos/iojs/io.js/pulls/758"}}},"pull_request":{"url":"https://api.github.com/repos/iojs/io.js/pulls/758","id":28883503,"html_url":"https://github.com/iojs/io.js/pull/758","diff_url":"https://github.com/iojs/io.js/pull/758.diff","patch_url":"https://github.com/iojs/io.js/pull/758.patch","issue_url":"https://api.github.com/repos/iojs/io.js/issues/758","number":758,"state":"open","locked":false,"title":"Implement unhandled rejection tracking","user":{"login":"petkaantonov","id":829734,"avatar_url":"https://avatars.githubusercontent.com/u/829734?v=3","gravatar_id":"","url":"https://api.github.com/users/petkaantonov","html_url":"https://github.com/petkaantonov","followers_url":"https://api.github.com/users/petkaantonov/followers","following_url":"https://api.github.com/users/petkaantonov/following{/other_user}","gists_url":"https://api.github.com/users/petkaantonov/gists{/gist_id}","starred_url":"https://api.github.com/users/petkaantonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petkaantonov/subscriptions","organizations_url":"https://api.github.com/users/petkaantonov/orgs","repos_url":"https://api.github.com/users/petkaantonov/repos","events_url":"https://api.github.com/users/petkaantonov/events{/privacy}","received_events_url":"https://api.github.com/users/petkaantonov/received_events","type":"User","site_admin":false},"body":"Implement unhandled rejection tracking for promises as\r\nspecified in https://gist.github.com/benjamingr/0237932cee84712951a2\r\n\r\nFixes #256\r\n\r\nNote that I did not implement any default action - so errors are still\r\nswallowed by default and many developers are therefore not going\r\nto discover the hooks. My recommendation would be by default\r\nto log the error as `\"Potentially unhandled: \" + error.stack` (and\r\nfor example `\"no stack trace\"` for non-errors).\r\n\r\nThese hooks are enough to implement any kind of error handling scheme, including\r\nlog-on-gc (needs native module I think).\r\n\r\n@Domenic , @rvagg , @vkurchatkin , @benjamingr ,@bnoordhuis\r\n\r\n","created_at":"2015-02-08T17:38:00Z","updated_at":"2015-02-10T19:20:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8814fa9a12909e6bde8b12f3e1b7caef10a305f3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/iojs/io.js/pulls/758/commits","review_comments_url":"https://api.github.com/repos/iojs/io.js/pulls/758/comments","review_comment_url":"https://api.github.com/repos/iojs/io.js/pulls/comments/{number}","comments_url":"https://api.github.com/repos/iojs/io.js/issues/758/comments","statuses_url":"https://api.github.com/repos/iojs/io.js/statuses/f65c36df6df13d2b9ca6f0944f0e4b02572ac592","head":{"label":"petkaantonov:unhandled-rejection-tracking","ref":"unhandled-rejection-tracking","sha":"f65c36df6df13d2b9ca6f0944f0e4b02572ac592","user":{"login":"petkaantonov","id":829734,"avatar_url":"https://avatars.githubusercontent.com/u/829734?v=3","gravatar_id":"","url":"https://api.github.com/users/petkaantonov","html_url":"https://github.com/petkaantonov","followers_url":"https://api.github.com/users/petkaantonov/followers","following_url":"https://api.github.com/users/petkaantonov/following{/other_user}","gists_url":"https://api.github.com/users/petkaantonov/gists{/gist_id}","starred_url":"https://api.github.com/users/petkaantonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petkaantonov/subscriptions","organizations_url":"https://api.github.com/users/petkaantonov/orgs","repos_url":"https://api.github.com/users/petkaantonov/repos","events_url":"https://api.github.com/users/petkaantonov/events{/privacy}","received_events_url":"https://api.github.com/users/petkaantonov/received_events","type":"User","site_admin":false},"repo":{"id":30495325,"name":"io.js","full_name":"petkaantonov/io.js","owner":{"login":"petkaantonov","id":829734,"avatar_url":"https://avatars.githubusercontent.com/u/829734?v=3","gravatar_id":"","url":"https://api.github.com/users/petkaantonov","html_url":"https://github.com/petkaantonov","followers_url":"https://api.github.com/users/petkaantonov/followers","following_url":"https://api.github.com/users/petkaantonov/following{/other_user}","gists_url":"https://api.github.com/users/petkaantonov/gists{/gist_id}","starred_url":"https://api.github.com/users/petkaantonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petkaantonov/subscriptions","organizations_url":"https://api.github.com/users/petkaantonov/orgs","repos_url":"https://api.github.com/users/petkaantonov/repos","events_url":"https://api.github.com/users/petkaantonov/events{/privacy}","received_events_url":"https://api.github.com/users/petkaantonov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/petkaantonov/io.js","description":"A friendly fork of Node.js with an open governance model","fork":true,"url":"https://api.github.com/repos/petkaantonov/io.js","forks_url":"https://api.github.com/repos/petkaantonov/io.js/forks","keys_url":"https://api.github.com/repos/petkaantonov/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/petkaantonov/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/petkaantonov/io.js/teams","hooks_url":"https://api.github.com/repos/petkaantonov/io.js/hooks","issue_events_url":"https://api.github.com/repos/petkaantonov/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/petkaantonov/io.js/events","assignees_url":"https://api.github.com/repos/petkaantonov/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/petkaantonov/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/petkaantonov/io.js/tags","blobs_url":"https://api.github.com/repos/petkaantonov/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/petkaantonov/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/petkaantonov/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/petkaantonov/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/petkaantonov/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/petkaantonov/io.js/languages","stargazers_url":"https://api.github.com/repos/petkaantonov/io.js/stargazers","contributors_url":"https://api.github.com/repos/petkaantonov/io.js/contributors","subscribers_url":"https://api.github.com/repos/petkaantonov/io.js/subscribers","subscription_url":"https://api.github.com/repos/petkaantonov/io.js/subscription","commits_url":"https://api.github.com/repos/petkaantonov/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/petkaantonov/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/petkaantonov/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/petkaantonov/io.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/petkaantonov/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/petkaantonov/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/petkaantonov/io.js/merges","archive_url":"https://api.github.com/repos/petkaantonov/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/petkaantonov/io.js/downloads","issues_url":"https://api.github.com/repos/petkaantonov/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/petkaantonov/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/petkaantonov/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/petkaantonov/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/petkaantonov/io.js/labels{/name}","releases_url":"https://api.github.com/repos/petkaantonov/io.js/releases{/id}","created_at":"2015-02-08T15:30:16Z","updated_at":"2015-02-08T15:30:19Z","pushed_at":"2015-02-09T20:47:42Z","git_url":"git://github.com/petkaantonov/io.js.git","ssh_url":"git@github.com:petkaantonov/io.js.git","clone_url":"https://github.com/petkaantonov/io.js.git","svn_url":"https://github.com/petkaantonov/io.js","homepage":"https://iojs.org","size":119509,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v1.x"}},"base":{"label":"iojs:v1.x","ref":"v1.x","sha":"5e825d1073b57a87fc9a77751ed3e21c86970082","user":{"login":"iojs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/iojs","html_url":"https://github.com/iojs","followers_url":"https://api.github.com/users/iojs/followers","following_url":"https://api.github.com/users/iojs/following{/other_user}","gists_url":"https://api.github.com/users/iojs/gists{/gist_id}","starred_url":"https://api.github.com/users/iojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iojs/subscriptions","organizations_url":"https://api.github.com/users/iojs/orgs","repos_url":"https://api.github.com/users/iojs/repos","events_url":"https://api.github.com/users/iojs/events{/privacy}","received_events_url":"https://api.github.com/users/iojs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"io.js","full_name":"iojs/io.js","owner":{"login":"iojs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/iojs","html_url":"https://github.com/iojs","followers_url":"https://api.github.com/users/iojs/followers","following_url":"https://api.github.com/users/iojs/following{/other_user}","gists_url":"https://api.github.com/users/iojs/gists{/gist_id}","starred_url":"https://api.github.com/users/iojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iojs/subscriptions","organizations_url":"https://api.github.com/users/iojs/orgs","repos_url":"https://api.github.com/users/iojs/repos","events_url":"https://api.github.com/users/iojs/events{/privacy}","received_events_url":"https://api.github.com/users/iojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iojs/io.js","description":"A friendly fork of Node.js with an open governance model","fork":false,"url":"https://api.github.com/repos/iojs/io.js","forks_url":"https://api.github.com/repos/iojs/io.js/forks","keys_url":"https://api.github.com/repos/iojs/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iojs/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iojs/io.js/teams","hooks_url":"https://api.github.com/repos/iojs/io.js/hooks","issue_events_url":"https://api.github.com/repos/iojs/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/iojs/io.js/events","assignees_url":"https://api.github.com/repos/iojs/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/iojs/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/iojs/io.js/tags","blobs_url":"https://api.github.com/repos/iojs/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iojs/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iojs/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/iojs/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iojs/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/iojs/io.js/languages","stargazers_url":"https://api.github.com/repos/iojs/io.js/stargazers","contributors_url":"https://api.github.com/repos/iojs/io.js/contributors","subscribers_url":"https://api.github.com/repos/iojs/io.js/subscribers","subscription_url":"https://api.github.com/repos/iojs/io.js/subscription","commits_url":"https://api.github.com/repos/iojs/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/iojs/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/iojs/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/iojs/io.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/iojs/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/iojs/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iojs/io.js/merges","archive_url":"https://api.github.com/repos/iojs/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iojs/io.js/downloads","issues_url":"https://api.github.com/repos/iojs/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/iojs/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/iojs/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/iojs/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iojs/io.js/labels{/name}","releases_url":"https://api.github.com/repos/iojs/io.js/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2015-02-10T19:16:51Z","pushed_at":"2015-02-10T15:41:45Z","git_url":"git://github.com/iojs/io.js.git","ssh_url":"git@github.com:iojs/io.js.git","clone_url":"https://github.com/iojs/io.js.git","svn_url":"https://github.com/iojs/io.js","homepage":"https://iojs.org","size":143733,"stargazers_count":9844,"watchers_count":9844,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":594,"mirror_url":null,"open_issues_count":143,"forks":594,"open_issues":143,"watchers":9844,"default_branch":"v1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/iojs/io.js/pulls/758"},"html":{"href":"https://github.com/iojs/io.js/pull/758"},"issue":{"href":"https://api.github.com/repos/iojs/io.js/issues/758"},"comments":{"href":"https://api.github.com/repos/iojs/io.js/issues/758/comments"},"review_comments":{"href":"https://api.github.com/repos/iojs/io.js/pulls/758/comments"},"review_comment":{"href":"https://api.github.com/repos/iojs/io.js/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/iojs/io.js/pulls/758/commits"},"statuses":{"href":"https://api.github.com/repos/iojs/io.js/statuses/f65c36df6df13d2b9ca6f0944f0e4b02572ac592"}}}}