{"action":"closed","number":18234,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18234","id":52729333,"html_url":"https://github.com/kubernetes/kubernetes/pull/18234","diff_url":"https://github.com/kubernetes/kubernetes/pull/18234.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/18234.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/18234","number":18234,"state":"closed","locked":false,"title":"Cleaning up test organization for impending move","user":{"login":"krousey","id":157083,"avatar_url":"https://avatars.githubusercontent.com/u/157083?v=3","gravatar_id":"","url":"https://api.github.com/users/krousey","html_url":"https://github.com/krousey","followers_url":"https://api.github.com/users/krousey/followers","following_url":"https://api.github.com/users/krousey/following{/other_user}","gists_url":"https://api.github.com/users/krousey/gists{/gist_id}","starred_url":"https://api.github.com/users/krousey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krousey/subscriptions","organizations_url":"https://api.github.com/users/krousey/orgs","repos_url":"https://api.github.com/users/krousey/repos","events_url":"https://api.github.com/users/krousey/events{/privacy}","received_events_url":"https://api.github.com/users/krousey/received_events","type":"User","site_admin":false},"body":"I'm moving/deleting some tests to make an upcoming RESTClient refactor\r\nPR cleaner.\r\n\r\n - TestDoRequestBearer is redundant to\r\n   pkg/client/transport.TestBearerAuthRoundTripper\r\n - Added a case to pkg/client/transport.TestBasicAuthRoundTripper to\r\n   cover what TestDoRequestWithoutPassword was testing\r\n - Moved TestSetsCodec, TestRESTClientRequires,\r\n   TestValidateHostParameter to helper_test.go since they were really\r\n   testing helper functions and not the RESTClient directly.\r\n - Modified TestValidateHostParameter during the moved to just use\r\n   DefaultServerURL instead of creating a client.","created_at":"2015-12-04T22:23:03Z","updated_at":"2015-12-05T15:36:35Z","closed_at":"2015-12-05T15:36:35Z","merged_at":"2015-12-05T15:36:35Z","merge_commit_sha":"8388cca65053bd50bd10bc74c77c26877fee2ca5","assignee":{"login":"caesarxuchao","id":2823529,"avatar_url":"https://avatars.githubusercontent.com/u/2823529?v=3","gravatar_id":"","url":"https://api.github.com/users/caesarxuchao","html_url":"https://github.com/caesarxuchao","followers_url":"https://api.github.com/users/caesarxuchao/followers","following_url":"https://api.github.com/users/caesarxuchao/following{/other_user}","gists_url":"https://api.github.com/users/caesarxuchao/gists{/gist_id}","starred_url":"https://api.github.com/users/caesarxuchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caesarxuchao/subscriptions","organizations_url":"https://api.github.com/users/caesarxuchao/orgs","repos_url":"https://api.github.com/users/caesarxuchao/repos","events_url":"https://api.github.com/users/caesarxuchao/events{/privacy}","received_events_url":"https://api.github.com/users/caesarxuchao/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18234/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18234/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/18234/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/e2583e294dfa7f30ff1e1652e1ae9bd2373a5bf3","head":{"label":"krousey:clienttest","ref":"clienttest","sha":"e2583e294dfa7f30ff1e1652e1ae9bd2373a5bf3","user":{"login":"krousey","id":157083,"avatar_url":"https://avatars.githubusercontent.com/u/157083?v=3","gravatar_id":"","url":"https://api.github.com/users/krousey","html_url":"https://github.com/krousey","followers_url":"https://api.github.com/users/krousey/followers","following_url":"https://api.github.com/users/krousey/following{/other_user}","gists_url":"https://api.github.com/users/krousey/gists{/gist_id}","starred_url":"https://api.github.com/users/krousey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krousey/subscriptions","organizations_url":"https://api.github.com/users/krousey/orgs","repos_url":"https://api.github.com/users/krousey/repos","events_url":"https://api.github.com/users/krousey/events{/privacy}","received_events_url":"https://api.github.com/users/krousey/received_events","type":"User","site_admin":false},"repo":{"id":33140890,"name":"kubernetes","full_name":"krousey/kubernetes","owner":{"login":"krousey","id":157083,"avatar_url":"https://avatars.githubusercontent.com/u/157083?v=3","gravatar_id":"","url":"https://api.github.com/users/krousey","html_url":"https://github.com/krousey","followers_url":"https://api.github.com/users/krousey/followers","following_url":"https://api.github.com/users/krousey/following{/other_user}","gists_url":"https://api.github.com/users/krousey/gists{/gist_id}","starred_url":"https://api.github.com/users/krousey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krousey/subscriptions","organizations_url":"https://api.github.com/users/krousey/orgs","repos_url":"https://api.github.com/users/krousey/repos","events_url":"https://api.github.com/users/krousey/events{/privacy}","received_events_url":"https://api.github.com/users/krousey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krousey/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/krousey/kubernetes","forks_url":"https://api.github.com/repos/krousey/kubernetes/forks","keys_url":"https://api.github.com/repos/krousey/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krousey/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krousey/kubernetes/teams","hooks_url":"https://api.github.com/repos/krousey/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/krousey/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/krousey/kubernetes/events","assignees_url":"https://api.github.com/repos/krousey/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/krousey/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/krousey/kubernetes/tags","blobs_url":"https://api.github.com/repos/krousey/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krousey/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krousey/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/krousey/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krousey/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/krousey/kubernetes/languages","stargazers_url":"https://api.github.com/repos/krousey/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/krousey/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/krousey/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/krousey/kubernetes/subscription","commits_url":"https://api.github.com/repos/krousey/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/krousey/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/krousey/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/krousey/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/krousey/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/krousey/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krousey/kubernetes/merges","archive_url":"https://api.github.com/repos/krousey/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krousey/kubernetes/downloads","issues_url":"https://api.github.com/repos/krousey/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/krousey/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/krousey/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/krousey/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krousey/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/krousey/kubernetes/releases{/id}","created_at":"2015-03-30T18:38:40Z","updated_at":"2015-04-20T21:05:26Z","pushed_at":"2015-12-04T22:21:48Z","git_url":"git://github.com/krousey/kubernetes.git","ssh_url":"git@github.com:krousey/kubernetes.git","clone_url":"https://github.com/krousey/kubernetes.git","svn_url":"https://github.com/krousey/kubernetes","homepage":"http://kubernetes.io","size":137525,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"b6f68df3c80585313d1f8be6450e9c99139e9ed0","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-12-05T14:51:52Z","pushed_at":"2015-12-05T15:36:35Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":294356,"stargazers_count":11619,"watchers_count":11619,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3132,"mirror_url":null,"open_issues_count":2472,"forks":3132,"open_issues":2472,"watchers":11619,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18234"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/18234"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/18234"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/18234/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18234/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18234/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/e2583e294dfa7f30ff1e1652e1ae9bd2373a5bf3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"k8s-merge-robot","id":13653959,"avatar_url":"https://avatars.githubusercontent.com/u/13653959?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-merge-robot","html_url":"https://github.com/k8s-merge-robot","followers_url":"https://api.github.com/users/k8s-merge-robot/followers","following_url":"https://api.github.com/users/k8s-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-merge-robot/orgs","repos_url":"https://api.github.com/users/k8s-merge-robot/repos","events_url":"https://api.github.com/users/k8s-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-merge-robot/received_events","type":"User","site_admin":false},"comments":4,"review_comments":6,"commits":1,"additions":98,"deletions":158,"changed_files":3}}