{"action":"closed","number":16784,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/16784","id":46848883,"html_url":"https://github.com/docker/docker/pull/16784","diff_url":"https://github.com/docker/docker/pull/16784.diff","patch_url":"https://github.com/docker/docker/pull/16784.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/16784","number":16784,"state":"closed","locked":false,"title":"use gocheck asserts instead of fatal","user":{"login":"MHBauer","id":13337345,"avatar_url":"https://avatars.githubusercontent.com/u/13337345?v=3","gravatar_id":"","url":"https://api.github.com/users/MHBauer","html_url":"https://github.com/MHBauer","followers_url":"https://api.github.com/users/MHBauer/followers","following_url":"https://api.github.com/users/MHBauer/following{/other_user}","gists_url":"https://api.github.com/users/MHBauer/gists{/gist_id}","starred_url":"https://api.github.com/users/MHBauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MHBauer/subscriptions","organizations_url":"https://api.github.com/users/MHBauer/orgs","repos_url":"https://api.github.com/users/MHBauer/repos","events_url":"https://api.github.com/users/MHBauer/events{/privacy}","received_events_url":"https://api.github.com/users/MHBauer/received_events","type":"User","site_admin":false},"body":"some of these are finicky, and I'm not sure how good the tests are. I've marked a couple of places.\r\n\r\nI feel not doing a dot import for gocheck is both annoying and cluttery. Is there an actual policy against doing dot imports in any case? Tests would seem like the one place it might be appropriate.\r\n\r\nI rearranged some of the checks, but I don't think I materially changed the results of the tests.","created_at":"2015-10-05T23:57:31Z","updated_at":"2015-10-22T06:34:50Z","closed_at":"2015-10-22T06:34:50Z","merged_at":"2015-10-22T06:34:50Z","merge_commit_sha":"f279dcf6109b80ff57d8b304dafb802063fc57d0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/16784/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/16784/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/16784/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/eedeeaf49c49cc75ab30a01676736637224ddd8a","head":{"label":"MHBauer:test-refactor","ref":"test-refactor","sha":"eedeeaf49c49cc75ab30a01676736637224ddd8a","user":{"login":"MHBauer","id":13337345,"avatar_url":"https://avatars.githubusercontent.com/u/13337345?v=3","gravatar_id":"","url":"https://api.github.com/users/MHBauer","html_url":"https://github.com/MHBauer","followers_url":"https://api.github.com/users/MHBauer/followers","following_url":"https://api.github.com/users/MHBauer/following{/other_user}","gists_url":"https://api.github.com/users/MHBauer/gists{/gist_id}","starred_url":"https://api.github.com/users/MHBauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MHBauer/subscriptions","organizations_url":"https://api.github.com/users/MHBauer/orgs","repos_url":"https://api.github.com/users/MHBauer/repos","events_url":"https://api.github.com/users/MHBauer/events{/privacy}","received_events_url":"https://api.github.com/users/MHBauer/received_events","type":"User","site_admin":false},"repo":{"id":39091680,"name":"docker","full_name":"MHBauer/docker","owner":{"login":"MHBauer","id":13337345,"avatar_url":"https://avatars.githubusercontent.com/u/13337345?v=3","gravatar_id":"","url":"https://api.github.com/users/MHBauer","html_url":"https://github.com/MHBauer","followers_url":"https://api.github.com/users/MHBauer/followers","following_url":"https://api.github.com/users/MHBauer/following{/other_user}","gists_url":"https://api.github.com/users/MHBauer/gists{/gist_id}","starred_url":"https://api.github.com/users/MHBauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MHBauer/subscriptions","organizations_url":"https://api.github.com/users/MHBauer/orgs","repos_url":"https://api.github.com/users/MHBauer/repos","events_url":"https://api.github.com/users/MHBauer/events{/privacy}","received_events_url":"https://api.github.com/users/MHBauer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MHBauer/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/MHBauer/docker","forks_url":"https://api.github.com/repos/MHBauer/docker/forks","keys_url":"https://api.github.com/repos/MHBauer/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MHBauer/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MHBauer/docker/teams","hooks_url":"https://api.github.com/repos/MHBauer/docker/hooks","issue_events_url":"https://api.github.com/repos/MHBauer/docker/issues/events{/number}","events_url":"https://api.github.com/repos/MHBauer/docker/events","assignees_url":"https://api.github.com/repos/MHBauer/docker/assignees{/user}","branches_url":"https://api.github.com/repos/MHBauer/docker/branches{/branch}","tags_url":"https://api.github.com/repos/MHBauer/docker/tags","blobs_url":"https://api.github.com/repos/MHBauer/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MHBauer/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MHBauer/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/MHBauer/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MHBauer/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/MHBauer/docker/languages","stargazers_url":"https://api.github.com/repos/MHBauer/docker/stargazers","contributors_url":"https://api.github.com/repos/MHBauer/docker/contributors","subscribers_url":"https://api.github.com/repos/MHBauer/docker/subscribers","subscription_url":"https://api.github.com/repos/MHBauer/docker/subscription","commits_url":"https://api.github.com/repos/MHBauer/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/MHBauer/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/MHBauer/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/MHBauer/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/MHBauer/docker/contents/{+path}","compare_url":"https://api.github.com/repos/MHBauer/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MHBauer/docker/merges","archive_url":"https://api.github.com/repos/MHBauer/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MHBauer/docker/downloads","issues_url":"https://api.github.com/repos/MHBauer/docker/issues{/number}","pulls_url":"https://api.github.com/repos/MHBauer/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/MHBauer/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/MHBauer/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MHBauer/docker/labels{/name}","releases_url":"https://api.github.com/repos/MHBauer/docker/releases{/id}","created_at":"2015-07-14T18:02:26Z","updated_at":"2015-07-14T18:02:34Z","pushed_at":"2015-10-19T21:07:01Z","git_url":"git://github.com/MHBauer/docker.git","ssh_url":"git@github.com:MHBauer/docker.git","clone_url":"https://github.com/MHBauer/docker.git","svn_url":"https://github.com/MHBauer/docker","homepage":"http://www.docker.com","size":71679,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"b27fa6c58e020b35d725b89badb82dbbc5cb84bc","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-10-22T03:11:52Z","pushed_at":"2015-10-22T06:34:51Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":273494,"stargazers_count":25593,"watchers_count":25593,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6781,"mirror_url":null,"open_issues_count":1133,"forks":6781,"open_issues":1133,"watchers":25593,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/16784"},"html":{"href":"https://github.com/docker/docker/pull/16784"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/16784"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/16784/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/16784/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/16784/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/eedeeaf49c49cc75ab30a01676736637224ddd8a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars.githubusercontent.com/u/6508?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"comments":5,"review_comments":27,"commits":1,"additions":76,"deletions":135,"changed_files":1}}