{"action":"created","issue":{"url":"https://api.github.com/repos/johannesjo/ng-fab-form/issues/58","labels_url":"https://api.github.com/repos/johannesjo/ng-fab-form/issues/58/labels{/name}","comments_url":"https://api.github.com/repos/johannesjo/ng-fab-form/issues/58/comments","events_url":"https://api.github.com/repos/johannesjo/ng-fab-form/issues/58/events","html_url":"https://github.com/johannesjo/ng-fab-form/pull/58","id":68165944,"number":58,"title":"ngFabEnsureExpression with test cases added","user":{"login":"tushariscoolster","id":5046353,"avatar_url":"https://avatars.githubusercontent.com/u/5046353?v=3","gravatar_id":"","url":"https://api.github.com/users/tushariscoolster","html_url":"https://github.com/tushariscoolster","followers_url":"https://api.github.com/users/tushariscoolster/followers","following_url":"https://api.github.com/users/tushariscoolster/following{/other_user}","gists_url":"https://api.github.com/users/tushariscoolster/gists{/gist_id}","starred_url":"https://api.github.com/users/tushariscoolster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tushariscoolster/subscriptions","organizations_url":"https://api.github.com/users/tushariscoolster/orgs","repos_url":"https://api.github.com/users/tushariscoolster/repos","events_url":"https://api.github.com/users/tushariscoolster/events{/privacy}","received_events_url":"https://api.github.com/users/tushariscoolster/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-04-13T18:46:31Z","updated_at":"2015-04-13T19:28:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/johannesjo/ng-fab-form/pulls/58","html_url":"https://github.com/johannesjo/ng-fab-form/pull/58","diff_url":"https://github.com/johannesjo/ng-fab-form/pull/58.diff","patch_url":"https://github.com/johannesjo/ng-fab-form/pull/58.patch"},"body":"ngFabEnsureExpression with test cases added"},"comment":{"url":"https://api.github.com/repos/johannesjo/ng-fab-form/issues/comments/92470468","html_url":"https://github.com/johannesjo/ng-fab-form/pull/58#issuecomment-92470468","issue_url":"https://api.github.com/repos/johannesjo/ng-fab-form/issues/58","id":92470468,"user":{"login":"johannesjo","id":1456265,"avatar_url":"https://avatars.githubusercontent.com/u/1456265?v=3","gravatar_id":"","url":"https://api.github.com/users/johannesjo","html_url":"https://github.com/johannesjo","followers_url":"https://api.github.com/users/johannesjo/followers","following_url":"https://api.github.com/users/johannesjo/following{/other_user}","gists_url":"https://api.github.com/users/johannesjo/gists{/gist_id}","starred_url":"https://api.github.com/users/johannesjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johannesjo/subscriptions","organizations_url":"https://api.github.com/users/johannesjo/orgs","repos_url":"https://api.github.com/users/johannesjo/repos","events_url":"https://api.github.com/users/johannesjo/events{/privacy}","received_events_url":"https://api.github.com/users/johannesjo/received_events","type":"User","site_admin":false},"created_at":"2015-04-13T19:28:42Z","updated_at":"2015-04-13T19:28:42Z","body":"You probably want to develop using the grunt tasks. I suppose the test fails, because the default validation-messages-file (https://github.com/johannesjo/ng-fab-form/blob/master/src/default-validation-msgs.js) is not created properly, which is used for tests and for the bower version.\r\n\r\nThere also two minor things: The formation of the default-validation-msgs.html shouldn't change and for further development it would be also very helpful to have more helpful commit messages :)\r\n\r\nYo can do the latter by doing a rebase, e.g.:\r\n```\r\ngit rebase -i HEAD~3\r\n```\r\nPut something descriptive in it like `added ngFabEnsureExpression validation directive #58`\r\n\r\nI would do that myself, but I'm not sure if you would still be listed under the contributors section then. \r\n\r\nThank you very much again. I know that this might seam tiresome, but for future development it is vital to have tests and a useful git history."}}