{"push_id":636778103,"size":11,"distinct_size":2,"ref":"refs/heads/reverse_order_of_files_being_diffed","head":"4ff73ba50609d90760648fe735383af234ce1689","before":"36edeef0912f98c501a2f9a8e8230d4da451bbbe","commits":[{"sha":"174414380ce3bad19c727775eefb614e5085ac9b","author":{"email":"c3377018fa83ac9bae934793cb0f4c15cb354992@gmail.com","name":"Randy Coulman"},"message":"Show diff even with missing approved file\n\n* Use `diff -N` by default, which will treat missing files as having\n  no content.  This makes it easier to see the new golden master before\n  approving it.","distinct":false,"url":"https://api.github.com/repos/randycoulman/approvals/commits/174414380ce3bad19c727775eefb614e5085ac9b"},{"sha":"0f363174523fe8e03e7b8261bd3e94ba3ea87f9b","author":{"email":"c3377018fa83ac9bae934793cb0f4c15cb354992@gmail.com","name":"Randy Coulman"},"message":"When verifying, print the names of the files being compared\n\nThis is very useful when you have multiple approvals to re-verify.\nOtherwise, it's hard to know what you're looking at.","distinct":false,"url":"https://api.github.com/repos/randycoulman/approvals/commits/0f363174523fe8e03e7b8261bd3e94ba3ea87f9b"},{"sha":"ff109ad790beb3834b00f1e291799b8c919961cb","author":{"email":"c3377018fa83ac9bae934793cb0f4c15cb354992@gmail.com","name":"Randy Coulman"},"message":"Don't show file not found message when .approvals is missing\n\nWhen first running approvals tests, there is no `.approvals` file and\nthe message `cat: /path/to/.approvals: No such file or directory` is\ndisplayed.\n\nThis commit hides that message by redirecting the output of `cat` to\n`/dev/null`.","distinct":false,"url":"https://api.github.com/repos/randycoulman/approvals/commits/ff109ad790beb3834b00f1e291799b8c919961cb"},{"sha":"8c0e1a2655ffb00449075b9303c7774962dca595","author":{"email":"c3377018fa83ac9bae934793cb0f4c15cb354992@gmail.com","name":"Randy Coulman"},"message":"Show the entire diff command-line\n\nA bit better version; rather than just showing the filenames, show the\nentire command-line that will be run.","distinct":false,"url":"https://api.github.com/repos/randycoulman/approvals/commits/8c0e1a2655ffb00449075b9303c7774962dca595"},{"sha":"ac527e1d86e9d526cb6f123f51c25b7c54850a0e","author":{"email":"d322029bd4100ac9f2cfee3a363c04361456ec97@gmail.com","name":"Katrina Owen"},"message":"Merge pull request #60 from randycoulman/hide_missing_approvals_file_message\n\nDon't show file not found message when .approvals is missing","distinct":false,"url":"https://api.github.com/repos/randycoulman/approvals/commits/ac527e1d86e9d526cb6f123f51c25b7c54850a0e"},{"sha":"9297b319322efb3c4ba8c37b78d3c2bbacaf2697","author":{"email":"d322029bd4100ac9f2cfee3a363c04361456ec97@gmail.com","name":"Katrina Owen"},"message":"Merge pull request #59 from randycoulman/show_filenames_before_diffing\n\nWhen verifying, print the names of the files being compared","distinct":false,"url":"https://api.github.com/repos/randycoulman/approvals/commits/9297b319322efb3c4ba8c37b78d3c2bbacaf2697"},{"sha":"c550f86617e7c79ffc3232f5aad54a060e6cb9f2","author":{"email":"d322029bd4100ac9f2cfee3a363c04361456ec97@gmail.com","name":"Katrina Owen"},"message":"Merge pull request #58 from randycoulman/show_diffs_of_missing_files\n\nShow diff even with missing approved file","distinct":false,"url":"https://api.github.com/repos/randycoulman/approvals/commits/c550f86617e7c79ffc3232f5aad54a060e6cb9f2"},{"sha":"eab1c71d753434a5905310693a09eaa59b8b6e55","author":{"email":"c3377018fa83ac9bae934793cb0f4c15cb354992@gmail.com","name":"Randy Coulman"},"message":"Reverse the order of diffed files when verifying\n\nWhen diffing the received and approved files during verification, put\nthe `approved` file first so that the diff shows what would change if\nthe `received` file was approved as the new golden master.  This seems\nclearer and easier to understand.\n\n* This change will also need to be made to https://github.com/kytrinyx/approvals/pull/59\n\n* This code would not handle filenames with embedded spaces.  However,\n  the existing code also suffers from the same problems.  The `diff` and\n  `mv` commands would fail with such filenames.\n\n* A better implementation might be to change the order of the filenames\n  in the `.approvals` file itself.  I'd be happy to re-submit this PR\n  with that implementation instead.","distinct":false,"url":"https://api.github.com/repos/randycoulman/approvals/commits/eab1c71d753434a5905310693a09eaa59b8b6e55"},{"sha":"11b1ef1eae43d4f14b85bbafe296ded72a1618fe","author":{"email":"d322029bd4100ac9f2cfee3a363c04361456ec97@gmail.com","name":"Katrina Owen"},"message":"Merge pull request #61 from randycoulman/reverse_order_of_files_being_diffed","distinct":false,"url":"https://api.github.com/repos/randycoulman/approvals/commits/11b1ef1eae43d4f14b85bbafe296ded72a1618fe"},{"sha":"fab1746a832624fd8604b7d54b3d9ae9d06d7517","author":{"email":"c3377018fa83ac9bae934793cb0f4c15cb354992@gmail.com","name":"Randy Coulman"},"message":"Merge branch 'master' into reverse_order_of_files_being_diffed\n\nConflicts:\n\tlib/approvals/cli.rb","distinct":true,"url":"https://api.github.com/repos/randycoulman/approvals/commits/fab1746a832624fd8604b7d54b3d9ae9d06d7517"},{"sha":"4ff73ba50609d90760648fe735383af234ce1689","author":{"email":"c3377018fa83ac9bae934793cb0f4c15cb354992@gmail.com","name":"Randy Coulman"},"message":"Reverse order of approved and received files in .approvals\n\nAdjust CLI `diff` and `mv` commands accordingly","distinct":true,"url":"https://api.github.com/repos/randycoulman/approvals/commits/4ff73ba50609d90760648fe735383af234ce1689"}]}