{"action":"created","issue":{"url":"https://api.github.com/repos/ContinuumIO/datashape/issues/78","labels_url":"https://api.github.com/repos/ContinuumIO/datashape/issues/78/labels{/name}","comments_url":"https://api.github.com/repos/ContinuumIO/datashape/issues/78/comments","events_url":"https://api.github.com/repos/ContinuumIO/datashape/issues/78/events","html_url":"https://github.com/ContinuumIO/datashape/issues/78","id":39880945,"number":78,"title":"test failures in latest release, all pythons","user":{"login":"idella","id":1655078,"avatar_url":"https://avatars.githubusercontent.com/u/1655078?v=3","gravatar_id":"","url":"https://api.github.com/users/idella","html_url":"https://github.com/idella","followers_url":"https://api.github.com/users/idella/followers","following_url":"https://api.github.com/users/idella/following{/other_user}","gists_url":"https://api.github.com/users/idella/gists{/gist_id}","starred_url":"https://api.github.com/users/idella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idella/subscriptions","organizations_url":"https://api.github.com/users/idella/orgs","repos_url":"https://api.github.com/users/idella/repos","events_url":"https://api.github.com/users/idella/events{/privacy}","received_events_url":"https://api.github.com/users/idella/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ContinuumIO/datashape/labels/bug","name":"bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/ContinuumIO/datashape/milestones/1","html_url":"https://github.com/ContinuumIO/datashape/milestones/0.4.5","labels_url":"https://api.github.com/repos/ContinuumIO/datashape/milestones/1/labels","id":1072419,"number":1,"title":"0.4.5","description":"","creator":{"login":"cpcloud","id":417981,"avatar_url":"https://avatars.githubusercontent.com/u/417981?v=3","gravatar_id":"","url":"https://api.github.com/users/cpcloud","html_url":"https://github.com/cpcloud","followers_url":"https://api.github.com/users/cpcloud/followers","following_url":"https://api.github.com/users/cpcloud/following{/other_user}","gists_url":"https://api.github.com/users/cpcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/cpcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpcloud/subscriptions","organizations_url":"https://api.github.com/users/cpcloud/orgs","repos_url":"https://api.github.com/users/cpcloud/repos","events_url":"https://api.github.com/users/cpcloud/events{/privacy}","received_events_url":"https://api.github.com/users/cpcloud/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":4,"state":"open","created_at":"2015-04-17T15:53:47Z","updated_at":"2015-04-17T18:18:13Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2014-08-09T08:12:24Z","updated_at":"2015-04-17T18:18:13Z","closed_at":"2015-04-17T18:18:13Z","body":"```python\r\ndatashape.tests.test_user.test_tuples_can_be_records_too ... ok\r\ndatashape.tests.test_user.test_datetimes ... ok\r\ndatashape.tests.test_user.test_numpy ... ok\r\ndatashape.tests.test_user.test_issubschema ... ok\r\ndatashape.tests.test_user.test_integration ... ok\r\ntest_cat_dshapes (datashape.tests.test_util.TestDataShapeUtil) ... ok\r\ntest_cat_dshapes_errors (datashape.tests.test_util.TestDataShapeUtil) ... ok\r\ntest_has_ellipsis (datashape.tests.test_util.TestDataShapeUtil) ... ok\r\ntest_has_var_dim (datashape.tests.test_util.TestDataShapeUtil) ... ok\r\n\r\n======================================================================\r\nERROR: test_coerce_traits (datashape.tests.test_coercion.TestCoercion)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/mnt/gen2/TmpDir/portage/dev-python/datashape-0.3.0/work/datashape-0.3.0-python3_4/lib/datashape/tests/test_coercion.py\", line 75, in test_coerce_traits\r\n    '10 * X * float32')\r\n  File \"/mnt/gen2/TmpDir/portage/dev-python/datashape-0.3.0/work/datashape-0.3.0-python3_4/lib/datashape/util.py\", line 34, in dshapes\r\n    return [dshape(arg) for arg in args]\r\n  File \"/mnt/gen2/TmpDir/portage/dev-python/datashape-0.3.0/work/datashape-0.3.0-python3_4/lib/datashape/util.py\", line 34, in <listcomp>\r\n    return [dshape(arg) for arg in args]\r\n  File \"/mnt/gen2/TmpDir/portage/dev-python/datashape-0.3.0/work/datashape-0.3.0-python3_4/lib/datashape/util.py\", line 49, in dshape\r\n    ds = parser.parse(o, type_symbol_table.sym)\r\n  File \"/mnt/gen2/TmpDir/portage/dev-python/datashape-0.3.0/work/datashape-0.3.0-python3_4/lib/datashape/parser.py\", line 582, in parse\r\n    dsp.raise_error('Unexpected token in datashape')\r\n  File \"/mnt/gen2/TmpDir/portage/dev-python/datashape-0.3.0/work/datashape-0.3.0-python3_4/lib/datashape/parser.py\", line 57, in raise_error\r\n    self.ds_str, errmsg)\r\nnose.proxy.DataShapeSyntaxError: \r\n\r\n  File <nofile>, line 1\r\n    10 * X * A : floating\r\n               ^\r\n\r\nDataShapeSyntaxError: Unexpected token in datashape\r\n\r\n-------------------- >> begin captured stdout << ---------------------\r\n\r\n\r\n  File <nofile>, line 1\r\n    10 * X * A : floating\r\n               ^\r\n\r\nDataShapeSyntaxError: Unexpected token in datashape\r\n\r\n\r\n--------------------- >> end captured stdout << ----------------------\r\n\r\n======================================================================\r\nERROR: test_constraints_error (datashape.tests.test_creation.TestDataShapeCreation)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/mnt/gen2/TmpDir/portage/dev-python/datashape-0.3.0/work/datashape-0.3.0-python3_4/lib/datashape/tests/test_creation.py\", line 62, in test_constraints_error\r\n    'A : integral * B : numeric')\r\n  File \"/usr/lib64/python3.4/unittest/case.py\", line 701, in assertRaises\r\n    return context.handle('assertRaises', callableObj, args, kwargs)\r\n  File \"/usr/lib64/python3.4/unittest/case.py\", line 161, in handle\r\n    callable_obj(*args, **kwargs)\r\n  File \"/mnt/gen2/TmpDir/portage/dev-python/datashape-0.3.0/work/datashape-0.3.0-python3_4/lib/datashape/util.py\", line 49, in dshape\r\n    ds = parser.parse(o, type_symbol_table.sym)\r\n  File \"/mnt/gen2/TmpDir/portage/dev-python/datashape-0.3.0/work/datashape-0.3.0-python3_4/lib/datashape/parser.py\", line 582, in parse\r\n    dsp.raise_error('Unexpected token in datashape')\r\n  File \"/mnt/gen2/TmpDir/portage/dev-python/datashape-0.3.0/work/datashape-0.3.0-python3_4/lib/datashape/parser.py\", line 57, in raise_error\r\n    self.ds_str, errmsg)\r\nnose.proxy.DataShapeSyntaxError: \r\n\r\n  File <nofile>, line 1\r\n    A : integral * B : numeric\r\n      ^\r\n\r\nDataShapeSyntaxError: Unexpected token in datashape\r\n\r\n-------------------- >> begin captured stdout << ---------------------\r\n\r\n\r\n  File <nofile>, line 1\r\n    A : integral * B : numeric\r\n      ^\r\n\r\nDataShapeSyntaxError: Unexpected token in datashape\r\n\r\n\r\n--------------------- >> end captured stdout << ----------------------\r\n\r\n======================================================================\r\nERROR: test_type_decl (datashape.tests.test_creation.TestDataShapeCreation)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/mnt/gen2/TmpDir/portage/dev-python/datashape-0.3.0/work/datashape-0.3.0-python3_4/lib/datashape/tests/test_creation.py\", line 70, in test_type_decl\r\n    self.assertRaises(error.DataShapeTypeError, dshape, 'type X T = 3, T')\r\n  File \"/usr/lib64/python3.4/unittest/case.py\", line 701, in assertRaises\r\n    return context.handle('assertRaises', callableObj, args, kwargs)\r\n  File \"/usr/lib64/python3.4/unittest/case.py\", line 161, in handle\r\n    callable_obj(*args, **kwargs)\r\n  File \"/mnt/gen2/TmpDir/portage/dev-python/datashape-0.3.0/work/datashape-0.3.0-python3_4/lib/datashape/util.py\", line 49, in dshape\r\n    ds = parser.parse(o, type_symbol_table.sym)\r\n  File \"/mnt/gen2/TmpDir/portage/dev-python/datashape-0.3.0/work/datashape-0.3.0-python3_4/lib/datashape/parser.py\", line 578, in parse\r\n    dsp.raise_error('Invalid datashape')\r\n  File \"/mnt/gen2/TmpDir/portage/dev-python/datashape-0.3.0/work/datashape-0.3.0-python3_4/lib/datashape/parser.py\", line 57, in raise_error\r\n    self.ds_str, errmsg)\r\nnose.proxy.DataShapeSyntaxError: \r\n\r\n  File <nofile>, line 1\r\n    type X T = 3, T\r\n    ^\r\n\r\nDataShapeSyntaxError: Invalid datashape\r\n\r\n-------------------- >> begin captured stdout << ---------------------\r\n\r\n\r\n  File <nofile>, line 1\r\n    type X T = 3, T\r\n    ^\r\n\r\nDataShapeSyntaxError: Invalid datashape\r\n\r\n\r\n--------------------- >> end captured stdout << ----------------------\r\n\r\n======================================================================\r\nERROR: test_best_match (datashape.tests.test_overloading.TestOverloading)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/mnt/gen2/TmpDir/portage/dev-python/datashape-0.3.0/work/datashape-0.3.0-python3_4/lib/datashape/tests/test_overloading.py\", line 18, in test_best_match\r\n    match = best_match(f, coretypes.Tuple([d1, d2]))\r\nNameError: name 'best_match' is not defined\r\n\r\n======================================================================\r\nFAIL: test_coerce_constrained_typevars (datashape.tests.test_coercion.TestCoercion)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/mnt/gen2/TmpDir/portage/dev-python/datashape-0.3.0/work/datashape-0.3.0-python3_4/lib/datashape/tests/test_coercion.py\", line 55, in test_coerce_constrained_typevars\r\n    self.assertGreater(coercion_cost(a, b), coercion_cost(a, c))\r\n  File \"/mnt/gen2/TmpDir/portage/dev-python/datashape-0.3.0/work/datashape-0.3.0-python3_4/lib/datashape/tests/common.py\", line 15, in assertGreater\r\n    self.assertTrue(a > b, msg or \"%s is not greater than %s\" % (a, b))\r\nAssertionError: False is not true : 1 is not greater than 1\r\n\r\n======================================================================\r\nFAIL: test_coerce_src_ellipsis (datashape.tests.test_coercion.TestCoercion)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/mnt/gen2/TmpDir/portage/dev-python/datashape-0.3.0/work/datashape-0.3.0-python3_4/lib/datashape/tests/test_coercion.py\", line 87, in test_coerce_src_ellipsis\r\n    self.assertGreater(coercion_cost(a, b), coercion_cost(a, c))\r\n  File \"/mnt/gen2/TmpDir/portage/dev-python/datashape-0.3.0/work/datashape-0.3.0-python3_4/lib/datashape/tests/common.py\", line 15, in assertGreater\r\n    self.assertTrue(a > b, msg or \"%s is not greater than %s\" % (a, b))\r\nAssertionError: False is not true : 1 is not greater than inf\r\n\r\n======================================================================\r\nFAIL: test_coerce_typevars (datashape.tests.test_coercion.TestCoercion)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/mnt/gen2/TmpDir/portage/dev-python/datashape-0.3.0/work/datashape-0.3.0-python3_4/lib/datashape/tests/test_coercion.py\", line 49, in test_coerce_typevars\r\n    self.assertGreater(coercion_cost(a, b), coercion_cost(a, c))\r\n  File \"/mnt/gen2/TmpDir/portage/dev-python/datashape-0.3.0/work/datashape-0.3.0-python3_4/lib/datashape/tests/common.py\", line 15, in assertGreater\r\n    self.assertTrue(a > b, msg or \"%s is not greater than %s\" % (a, b))\r\nAssertionError: False is not true : 1 is not greater than 1\r\n\r\n======================================================================\r\nFAIL: datashape.tests.test_discovery.test_time_string\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/usr/lib64/python3.4/site-packages/nose/case.py\", line 198, in runTest\r\n    self.test(*self.arg)\r\n  File \"/mnt/gen2/TmpDir/portage/dev-python/datashape-0.3.0/work/datashape-0.3.0-python3_4/lib/datashape/tests/test_discovery.py\", line 81, in test_time_string\r\n    assert discover('12:00:01') == time_\r\nAssertionError\r\n\r\n----------------------------------------------------------------------\r\nRan 133 tests in 0.506s\r\n\r\nFAILED (errors=4, failures=4)\r\n```\r\n\r\nply; Installed versions:  3.4\r\nnumpy; Installed versions:  0.4\r\nmultipledispatch; Installed versions:  0.4.4\r\n\r\nuder pythons 2.7 3.3 3.4. Can you replicate? Do you require anything further?"},"comment":{"url":"https://api.github.com/repos/ContinuumIO/datashape/issues/comments/94043717","html_url":"https://github.com/ContinuumIO/datashape/issues/78#issuecomment-94043717","issue_url":"https://api.github.com/repos/ContinuumIO/datashape/issues/78","id":94043717,"user":{"login":"cpcloud","id":417981,"avatar_url":"https://avatars.githubusercontent.com/u/417981?v=3","gravatar_id":"","url":"https://api.github.com/users/cpcloud","html_url":"https://github.com/cpcloud","followers_url":"https://api.github.com/users/cpcloud/followers","following_url":"https://api.github.com/users/cpcloud/following{/other_user}","gists_url":"https://api.github.com/users/cpcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/cpcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpcloud/subscriptions","organizations_url":"https://api.github.com/users/cpcloud/orgs","repos_url":"https://api.github.com/users/cpcloud/repos","events_url":"https://api.github.com/users/cpcloud/events{/privacy}","received_events_url":"https://api.github.com/users/cpcloud/received_events","type":"User","site_admin":false},"created_at":"2015-04-17T18:18:12Z","updated_at":"2015-04-17T18:18:12Z","body":"There's a distinction between skipping a test and `xfail`ing a test. We skip on things such as platform dependent code. An obvious example is something like shelling out on linux using `bash`. This isn't something that can ever be depended on existing in a Windows environment and we acknowledge this by skipping the test on Windows. When a test probably should pass, but the code that the test exercises isn't implemented, `xfail` is a nice choice. `pytest` will even let you know when tests that are `xfail`ing start to pass. Unittest doesn't currently have this capability out of the box AFAIK."}}