{"action":"created","issue":{"url":"https://api.github.com/repos/droe/sslsplit/issues/87","labels_url":"https://api.github.com/repos/droe/sslsplit/issues/87/labels{/name}","comments_url":"https://api.github.com/repos/droe/sslsplit/issues/87/comments","events_url":"https://api.github.com/repos/droe/sslsplit/issues/87/events","html_url":"https://github.com/droe/sslsplit/pull/87","id":69306241,"number":87,"title":"Feature/starttls","user":{"login":"RichardPoole42","id":7967170,"avatar_url":"https://avatars.githubusercontent.com/u/7967170?v=3","gravatar_id":"","url":"https://api.github.com/users/RichardPoole42","html_url":"https://github.com/RichardPoole42","followers_url":"https://api.github.com/users/RichardPoole42/followers","following_url":"https://api.github.com/users/RichardPoole42/following{/other_user}","gists_url":"https://api.github.com/users/RichardPoole42/gists{/gist_id}","starred_url":"https://api.github.com/users/RichardPoole42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RichardPoole42/subscriptions","organizations_url":"https://api.github.com/users/RichardPoole42/orgs","repos_url":"https://api.github.com/users/RichardPoole42/repos","events_url":"https://api.github.com/users/RichardPoole42/events{/privacy}","received_events_url":"https://api.github.com/users/RichardPoole42/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-18T12:41:07Z","updated_at":"2015-04-18T12:51:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/droe/sslsplit/pulls/87","html_url":"https://github.com/droe/sslsplit/pull/87","diff_url":"https://github.com/droe/sslsplit/pull/87.diff","patch_url":"https://github.com/droe/sslsplit/pull/87.patch"},"body":"\"genericstarttls\" feature as suggested in https://github.com/droe/sslsplit/issues/40 . Working and documented but certainly needs review before merge."},"comment":{"url":"https://api.github.com/repos/droe/sslsplit/issues/comments/94163334","html_url":"https://github.com/droe/sslsplit/pull/87#issuecomment-94163334","issue_url":"https://api.github.com/repos/droe/sslsplit/issues/87","id":94163334,"user":{"login":"RichardPoole42","id":7967170,"avatar_url":"https://avatars.githubusercontent.com/u/7967170?v=3","gravatar_id":"","url":"https://api.github.com/users/RichardPoole42","html_url":"https://github.com/RichardPoole42","followers_url":"https://api.github.com/users/RichardPoole42/followers","following_url":"https://api.github.com/users/RichardPoole42/following{/other_user}","gists_url":"https://api.github.com/users/RichardPoole42/gists{/gist_id}","starred_url":"https://api.github.com/users/RichardPoole42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RichardPoole42/subscriptions","organizations_url":"https://api.github.com/users/RichardPoole42/orgs","repos_url":"https://api.github.com/users/RichardPoole42/repos","events_url":"https://api.github.com/users/RichardPoole42/events{/privacy}","received_events_url":"https://api.github.com/users/RichardPoole42/received_events","type":"User","site_admin":false},"created_at":"2015-04-18T12:51:49Z","updated_at":"2015-04-18T12:51:49Z","body":"Three major things to be resolved before merge:\r\n\r\n- I've cut-and-pasted quite a bit of code in ssl.c to do clienthello identification separately from looking for the SNI extension - perhaps this should be refactored now that there are essentially two different reasons to want to peek into a client hello message.\r\n\r\n- I've used the name \"genericstarttls\" in the proxyspec but I'm not happy with it - the protocol I'm interested in (xmpp) calls this feature \"starttls\" but it is misleading to give the impression that the code looks at the higher-level protocol, as it just looks for the beginning of the SSL connection. Similarly, my new function and new variables and structure fields may be badly named.\r\n\r\n- I've not added any unit tests - I think that at a minimum I should add one for the new proxyspec type."}}