{"action":"created","issue":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/11122","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/11122/labels{/name}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/11122/comments","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/11122/events","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/11122","id":56534803,"number":11122,"title":"Warning fix, and iexamine::atm tidy-up","user":{"login":"bkentel","id":780369,"avatar_url":"https://avatars.githubusercontent.com/u/780369?v=3","gravatar_id":"","url":"https://api.github.com/users/bkentel","html_url":"https://github.com/bkentel","followers_url":"https://api.github.com/users/bkentel/followers","following_url":"https://api.github.com/users/bkentel/following{/other_user}","gists_url":"https://api.github.com/users/bkentel/gists{/gist_id}","starred_url":"https://api.github.com/users/bkentel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkentel/subscriptions","organizations_url":"https://api.github.com/users/bkentel/orgs","repos_url":"https://api.github.com/users/bkentel/repos","events_url":"https://api.github.com/users/bkentel/events{/privacy}","received_events_url":"https://api.github.com/users/bkentel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-02-04T14:43:37Z","updated_at":"2015-02-08T21:23:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/11122","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/11122","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/11122.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/11122.patch"},"body":"Fixed a shadowed variable warning and while in the neighborhood:\r\n+ fixed up some function signatures.\r\n+ made the atm item selection filter by cash cards only.\r\n+ factored out some common code into two helpers.\r\n+ moved magic numbers to named constexprs.\r\n+ moved repeated calculations to named const variables."},"comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/73432689","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/11122#issuecomment-73432689","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/11122","id":73432689,"user":{"login":"kevingranade","id":860276,"avatar_url":"https://avatars.githubusercontent.com/u/860276?v=3","gravatar_id":"","url":"https://api.github.com/users/kevingranade","html_url":"https://github.com/kevingranade","followers_url":"https://api.github.com/users/kevingranade/followers","following_url":"https://api.github.com/users/kevingranade/following{/other_user}","gists_url":"https://api.github.com/users/kevingranade/gists{/gist_id}","starred_url":"https://api.github.com/users/kevingranade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevingranade/subscriptions","organizations_url":"https://api.github.com/users/kevingranade/orgs","repos_url":"https://api.github.com/users/kevingranade/repos","events_url":"https://api.github.com/users/kevingranade/events{/privacy}","received_events_url":"https://api.github.com/users/kevingranade/received_events","type":"User","site_admin":false},"created_at":"2015-02-08T21:23:04Z","updated_at":"2015-02-08T21:23:04Z","body":"Was there anything unclear about \"It's unnecessary to move literals that are used once to a const.\"?\r\nconstexpr is just a stronger version of a const (it's precisely a const plus an assertion that it can be evaluated at compile-time)."}}