{"action":"closed","number":199,"pull_request":{"url":"https://api.github.com/repos/jupyter/tmpnb/pulls/199","id":54698353,"html_url":"https://github.com/jupyter/tmpnb/pull/199","diff_url":"https://github.com/jupyter/tmpnb/pull/199.diff","patch_url":"https://github.com/jupyter/tmpnb/pull/199.patch","issue_url":"https://api.github.com/repos/jupyter/tmpnb/issues/199","number":199,"state":"closed","locked":false,"title":"Don't replace containers immediately when draining","user":{"login":"parente","id":153745,"avatar_url":"https://avatars.githubusercontent.com/u/153745?v=3","gravatar_id":"","url":"https://api.github.com/users/parente","html_url":"https://github.com/parente","followers_url":"https://api.github.com/users/parente/followers","following_url":"https://api.github.com/users/parente/following{/other_user}","gists_url":"https://api.github.com/users/parente/gists{/gist_id}","starred_url":"https://api.github.com/users/parente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parente/subscriptions","organizations_url":"https://api.github.com/users/parente/orgs","repos_url":"https://api.github.com/users/parente/repos","events_url":"https://api.github.com/users/parente/events{/privacy}","received_events_url":"https://api.github.com/users/parente/received_events","type":"User","site_admin":false},"body":"Let the next heartbeat task detect that containers are missing and handle their replacement. Replacing immediately leads to chaos when the heartbeat goes off in the middle of the asynchronous drains. For example:\r\n\r\n<img width=\"818\" alt=\"screen shot 2015-12-28 at 9 28 03 pm\" src=\"https://cloud.githubusercontent.com/assets/153745/12028724/3623a062-adaa-11e5-95dd-f9ca5ec31403.png\">\r\n\r\nNotice the number of containers doubles after a drain on the left side of the graph (before this fix). There's no overshoot after the drain on the right side of the graph (after this fix).","created_at":"2015-12-29T02:32:15Z","updated_at":"2015-12-29T02:35:12Z","closed_at":"2015-12-29T02:35:12Z","merged_at":"2015-12-29T02:35:12Z","merge_commit_sha":"64851935bb2e973c79067abe50a6b1dadc4c0c7c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jupyter/tmpnb/pulls/199/commits","review_comments_url":"https://api.github.com/repos/jupyter/tmpnb/pulls/199/comments","review_comment_url":"https://api.github.com/repos/jupyter/tmpnb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jupyter/tmpnb/issues/199/comments","statuses_url":"https://api.github.com/repos/jupyter/tmpnb/statuses/de9168e21199fa64ffd789528d21cd551ef73598","head":{"label":"parente:no-replace-on-drain","ref":"no-replace-on-drain","sha":"de9168e21199fa64ffd789528d21cd551ef73598","user":{"login":"parente","id":153745,"avatar_url":"https://avatars.githubusercontent.com/u/153745?v=3","gravatar_id":"","url":"https://api.github.com/users/parente","html_url":"https://github.com/parente","followers_url":"https://api.github.com/users/parente/followers","following_url":"https://api.github.com/users/parente/following{/other_user}","gists_url":"https://api.github.com/users/parente/gists{/gist_id}","starred_url":"https://api.github.com/users/parente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parente/subscriptions","organizations_url":"https://api.github.com/users/parente/orgs","repos_url":"https://api.github.com/users/parente/repos","events_url":"https://api.github.com/users/parente/events{/privacy}","received_events_url":"https://api.github.com/users/parente/received_events","type":"User","site_admin":false},"repo":{"id":42597790,"name":"tmpnb","full_name":"parente/tmpnb","owner":{"login":"parente","id":153745,"avatar_url":"https://avatars.githubusercontent.com/u/153745?v=3","gravatar_id":"","url":"https://api.github.com/users/parente","html_url":"https://github.com/parente","followers_url":"https://api.github.com/users/parente/followers","following_url":"https://api.github.com/users/parente/following{/other_user}","gists_url":"https://api.github.com/users/parente/gists{/gist_id}","starred_url":"https://api.github.com/users/parente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parente/subscriptions","organizations_url":"https://api.github.com/users/parente/orgs","repos_url":"https://api.github.com/users/parente/repos","events_url":"https://api.github.com/users/parente/events{/privacy}","received_events_url":"https://api.github.com/users/parente/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/parente/tmpnb","description":"Creates temporary Jupyter Notebook servers using Docker containers.","fork":true,"url":"https://api.github.com/repos/parente/tmpnb","forks_url":"https://api.github.com/repos/parente/tmpnb/forks","keys_url":"https://api.github.com/repos/parente/tmpnb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/parente/tmpnb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/parente/tmpnb/teams","hooks_url":"https://api.github.com/repos/parente/tmpnb/hooks","issue_events_url":"https://api.github.com/repos/parente/tmpnb/issues/events{/number}","events_url":"https://api.github.com/repos/parente/tmpnb/events","assignees_url":"https://api.github.com/repos/parente/tmpnb/assignees{/user}","branches_url":"https://api.github.com/repos/parente/tmpnb/branches{/branch}","tags_url":"https://api.github.com/repos/parente/tmpnb/tags","blobs_url":"https://api.github.com/repos/parente/tmpnb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/parente/tmpnb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/parente/tmpnb/git/refs{/sha}","trees_url":"https://api.github.com/repos/parente/tmpnb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/parente/tmpnb/statuses/{sha}","languages_url":"https://api.github.com/repos/parente/tmpnb/languages","stargazers_url":"https://api.github.com/repos/parente/tmpnb/stargazers","contributors_url":"https://api.github.com/repos/parente/tmpnb/contributors","subscribers_url":"https://api.github.com/repos/parente/tmpnb/subscribers","subscription_url":"https://api.github.com/repos/parente/tmpnb/subscription","commits_url":"https://api.github.com/repos/parente/tmpnb/commits{/sha}","git_commits_url":"https://api.github.com/repos/parente/tmpnb/git/commits{/sha}","comments_url":"https://api.github.com/repos/parente/tmpnb/comments{/number}","issue_comment_url":"https://api.github.com/repos/parente/tmpnb/issues/comments{/number}","contents_url":"https://api.github.com/repos/parente/tmpnb/contents/{+path}","compare_url":"https://api.github.com/repos/parente/tmpnb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/parente/tmpnb/merges","archive_url":"https://api.github.com/repos/parente/tmpnb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/parente/tmpnb/downloads","issues_url":"https://api.github.com/repos/parente/tmpnb/issues{/number}","pulls_url":"https://api.github.com/repos/parente/tmpnb/pulls{/number}","milestones_url":"https://api.github.com/repos/parente/tmpnb/milestones{/number}","notifications_url":"https://api.github.com/repos/parente/tmpnb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/parente/tmpnb/labels{/name}","releases_url":"https://api.github.com/repos/parente/tmpnb/releases{/id}","created_at":"2015-09-16T16:01:04Z","updated_at":"2015-09-16T16:01:05Z","pushed_at":"2015-12-29T02:30:06Z","git_url":"git://github.com/parente/tmpnb.git","ssh_url":"git@github.com:parente/tmpnb.git","clone_url":"https://github.com/parente/tmpnb.git","svn_url":"https://github.com/parente/tmpnb","homepage":null,"size":706,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jupyter:master","ref":"master","sha":"8a35b355147afd76d52ba601d22cb4245a7d07cb","user":{"login":"jupyter","id":7388996,"avatar_url":"https://avatars.githubusercontent.com/u/7388996?v=3","gravatar_id":"","url":"https://api.github.com/users/jupyter","html_url":"https://github.com/jupyter","followers_url":"https://api.github.com/users/jupyter/followers","following_url":"https://api.github.com/users/jupyter/following{/other_user}","gists_url":"https://api.github.com/users/jupyter/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyter/subscriptions","organizations_url":"https://api.github.com/users/jupyter/orgs","repos_url":"https://api.github.com/users/jupyter/repos","events_url":"https://api.github.com/users/jupyter/events{/privacy}","received_events_url":"https://api.github.com/users/jupyter/received_events","type":"Organization","site_admin":false},"repo":{"id":24117219,"name":"tmpnb","full_name":"jupyter/tmpnb","owner":{"login":"jupyter","id":7388996,"avatar_url":"https://avatars.githubusercontent.com/u/7388996?v=3","gravatar_id":"","url":"https://api.github.com/users/jupyter","html_url":"https://github.com/jupyter","followers_url":"https://api.github.com/users/jupyter/followers","following_url":"https://api.github.com/users/jupyter/following{/other_user}","gists_url":"https://api.github.com/users/jupyter/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyter/subscriptions","organizations_url":"https://api.github.com/users/jupyter/orgs","repos_url":"https://api.github.com/users/jupyter/repos","events_url":"https://api.github.com/users/jupyter/events{/privacy}","received_events_url":"https://api.github.com/users/jupyter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jupyter/tmpnb","description":"Creates temporary Jupyter Notebook servers using Docker containers.","fork":false,"url":"https://api.github.com/repos/jupyter/tmpnb","forks_url":"https://api.github.com/repos/jupyter/tmpnb/forks","keys_url":"https://api.github.com/repos/jupyter/tmpnb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jupyter/tmpnb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jupyter/tmpnb/teams","hooks_url":"https://api.github.com/repos/jupyter/tmpnb/hooks","issue_events_url":"https://api.github.com/repos/jupyter/tmpnb/issues/events{/number}","events_url":"https://api.github.com/repos/jupyter/tmpnb/events","assignees_url":"https://api.github.com/repos/jupyter/tmpnb/assignees{/user}","branches_url":"https://api.github.com/repos/jupyter/tmpnb/branches{/branch}","tags_url":"https://api.github.com/repos/jupyter/tmpnb/tags","blobs_url":"https://api.github.com/repos/jupyter/tmpnb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jupyter/tmpnb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jupyter/tmpnb/git/refs{/sha}","trees_url":"https://api.github.com/repos/jupyter/tmpnb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jupyter/tmpnb/statuses/{sha}","languages_url":"https://api.github.com/repos/jupyter/tmpnb/languages","stargazers_url":"https://api.github.com/repos/jupyter/tmpnb/stargazers","contributors_url":"https://api.github.com/repos/jupyter/tmpnb/contributors","subscribers_url":"https://api.github.com/repos/jupyter/tmpnb/subscribers","subscription_url":"https://api.github.com/repos/jupyter/tmpnb/subscription","commits_url":"https://api.github.com/repos/jupyter/tmpnb/commits{/sha}","git_commits_url":"https://api.github.com/repos/jupyter/tmpnb/git/commits{/sha}","comments_url":"https://api.github.com/repos/jupyter/tmpnb/comments{/number}","issue_comment_url":"https://api.github.com/repos/jupyter/tmpnb/issues/comments{/number}","contents_url":"https://api.github.com/repos/jupyter/tmpnb/contents/{+path}","compare_url":"https://api.github.com/repos/jupyter/tmpnb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jupyter/tmpnb/merges","archive_url":"https://api.github.com/repos/jupyter/tmpnb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jupyter/tmpnb/downloads","issues_url":"https://api.github.com/repos/jupyter/tmpnb/issues{/number}","pulls_url":"https://api.github.com/repos/jupyter/tmpnb/pulls{/number}","milestones_url":"https://api.github.com/repos/jupyter/tmpnb/milestones{/number}","notifications_url":"https://api.github.com/repos/jupyter/tmpnb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jupyter/tmpnb/labels{/name}","releases_url":"https://api.github.com/repos/jupyter/tmpnb/releases{/id}","created_at":"2014-09-16T20:49:42Z","updated_at":"2015-12-28T12:45:51Z","pushed_at":"2015-12-29T02:35:12Z","git_url":"git://github.com/jupyter/tmpnb.git","ssh_url":"git@github.com:jupyter/tmpnb.git","clone_url":"https://github.com/jupyter/tmpnb.git","svn_url":"https://github.com/jupyter/tmpnb","homepage":null,"size":732,"stargazers_count":314,"watchers_count":314,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":22,"forks":56,"open_issues":22,"watchers":314,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jupyter/tmpnb/pulls/199"},"html":{"href":"https://github.com/jupyter/tmpnb/pull/199"},"issue":{"href":"https://api.github.com/repos/jupyter/tmpnb/issues/199"},"comments":{"href":"https://api.github.com/repos/jupyter/tmpnb/issues/199/comments"},"review_comments":{"href":"https://api.github.com/repos/jupyter/tmpnb/pulls/199/comments"},"review_comment":{"href":"https://api.github.com/repos/jupyter/tmpnb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jupyter/tmpnb/pulls/199/commits"},"statuses":{"href":"https://api.github.com/repos/jupyter/tmpnb/statuses/de9168e21199fa64ffd789528d21cd551ef73598"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"parente","id":153745,"avatar_url":"https://avatars.githubusercontent.com/u/153745?v=3","gravatar_id":"","url":"https://api.github.com/users/parente","html_url":"https://github.com/parente","followers_url":"https://api.github.com/users/parente/followers","following_url":"https://api.github.com/users/parente/following{/other_user}","gists_url":"https://api.github.com/users/parente/gists{/gist_id}","starred_url":"https://api.github.com/users/parente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parente/subscriptions","organizations_url":"https://api.github.com/users/parente/orgs","repos_url":"https://api.github.com/users/parente/repos","events_url":"https://api.github.com/users/parente/events{/privacy}","received_events_url":"https://api.github.com/users/parente/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}