{"action":"created","comment":{"url":"https://api.github.com/repos/cuberite/cuberite/pulls/comments/35418816","id":35418816,"diff_hunk":"@@ -646,10 +646,10 @@ void cProtocol180::SendLogin(const cPlayer & a_Player, const cWorld & a_World)\n \t\tcServer * Server = cRoot::Get()->GetServer();\n \t\tcPacketizer Pkt(*this, 0x01);  // Join Game packet\n \t\tPkt.WriteBEUInt32(a_Player.GetUniqueID());\n-\t\tPkt.WriteBEUInt8((Byte)a_Player.GetEffectiveGameMode() | (Server->IsHardcore() ? 0x08 : 0));  // Hardcore flag bit 4\n-\t\tPkt.WriteBEInt8((char)a_World.GetDimension());\n+\t\tPkt.WriteBEUInt8(static_cast<Byte>(a_Player.GetEffectiveGameMode()) | (Server->IsHardcore() ? 0x08 : 0));  // Hardcore flag bit 4\n+\t\tPkt.WriteBEInt8(static_cast<char>(a_World.GetDimension()));\n \t\tPkt.WriteBEUInt8(2);  // TODO: Difficulty (set to Normal)\n-\t\tPkt.WriteBEUInt8(Server->GetMaxPlayers());\n+\t\tPkt.WriteBEUInt8(static_cast<UInt8>(Server->GetMaxPlayers()));","path":"src/Protocol/Protocol18x.cpp","position":85,"original_position":85,"commit_id":"e9b6cb7409fc90a71514008f4aadaba8e12df6f9","original_commit_id":"e9b6cb7409fc90a71514008f4aadaba8e12df6f9","user":{"login":"madmaxoft","id":4388386,"avatar_url":"https://avatars.githubusercontent.com/u/4388386?v=3","gravatar_id":"","url":"https://api.github.com/users/madmaxoft","html_url":"https://github.com/madmaxoft","followers_url":"https://api.github.com/users/madmaxoft/followers","following_url":"https://api.github.com/users/madmaxoft/following{/other_user}","gists_url":"https://api.github.com/users/madmaxoft/gists{/gist_id}","starred_url":"https://api.github.com/users/madmaxoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madmaxoft/subscriptions","organizations_url":"https://api.github.com/users/madmaxoft/orgs","repos_url":"https://api.github.com/users/madmaxoft/repos","events_url":"https://api.github.com/users/madmaxoft/events{/privacy}","received_events_url":"https://api.github.com/users/madmaxoft/received_events","type":"User","site_admin":false},"body":"Add a `Clamp` for the datatype","created_at":"2015-07-24T12:50:08Z","updated_at":"2015-07-24T12:50:08Z","html_url":"https://github.com/cuberite/cuberite/pull/2371#discussion_r35418816","pull_request_url":"https://api.github.com/repos/cuberite/cuberite/pulls/2371","_links":{"self":{"href":"https://api.github.com/repos/cuberite/cuberite/pulls/comments/35418816"},"html":{"href":"https://github.com/cuberite/cuberite/pull/2371#discussion_r35418816"},"pull_request":{"href":"https://api.github.com/repos/cuberite/cuberite/pulls/2371"}}},"pull_request":{"url":"https://api.github.com/repos/cuberite/cuberite/pulls/2371","id":40297812,"html_url":"https://github.com/cuberite/cuberite/pull/2371","diff_url":"https://github.com/cuberite/cuberite/pull/2371.diff","patch_url":"https://github.com/cuberite/cuberite/pull/2371.patch","issue_url":"https://api.github.com/repos/cuberite/cuberite/issues/2371","number":2371,"state":"open","locked":false,"title":"Warning fixes","user":{"login":"SamJBarney","id":1827860,"avatar_url":"https://avatars.githubusercontent.com/u/1827860?v=3","gravatar_id":"","url":"https://api.github.com/users/SamJBarney","html_url":"https://github.com/SamJBarney","followers_url":"https://api.github.com/users/SamJBarney/followers","following_url":"https://api.github.com/users/SamJBarney/following{/other_user}","gists_url":"https://api.github.com/users/SamJBarney/gists{/gist_id}","starred_url":"https://api.github.com/users/SamJBarney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamJBarney/subscriptions","organizations_url":"https://api.github.com/users/SamJBarney/orgs","repos_url":"https://api.github.com/users/SamJBarney/repos","events_url":"https://api.github.com/users/SamJBarney/events{/privacy}","received_events_url":"https://api.github.com/users/SamJBarney/received_events","type":"User","site_admin":false},"body":"I got tired of the long list of warnings that kept popping up throughout the build process, so I went through and fixed most of them. Please mark things that you would like changed.","created_at":"2015-07-18T20:16:54Z","updated_at":"2015-07-24T12:50:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"542955297991390574e2ee7c7632b3004e560d89","assignee":{"login":"madmaxoft","id":4388386,"avatar_url":"https://avatars.githubusercontent.com/u/4388386?v=3","gravatar_id":"","url":"https://api.github.com/users/madmaxoft","html_url":"https://github.com/madmaxoft","followers_url":"https://api.github.com/users/madmaxoft/followers","following_url":"https://api.github.com/users/madmaxoft/following{/other_user}","gists_url":"https://api.github.com/users/madmaxoft/gists{/gist_id}","starred_url":"https://api.github.com/users/madmaxoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madmaxoft/subscriptions","organizations_url":"https://api.github.com/users/madmaxoft/orgs","repos_url":"https://api.github.com/users/madmaxoft/repos","events_url":"https://api.github.com/users/madmaxoft/events{/privacy}","received_events_url":"https://api.github.com/users/madmaxoft/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/cuberite/cuberite/pulls/2371/commits","review_comments_url":"https://api.github.com/repos/cuberite/cuberite/pulls/2371/comments","review_comment_url":"https://api.github.com/repos/cuberite/cuberite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cuberite/cuberite/issues/2371/comments","statuses_url":"https://api.github.com/repos/cuberite/cuberite/statuses/e9b6cb7409fc90a71514008f4aadaba8e12df6f9","head":{"label":"SamJBarney:WarningFix","ref":"WarningFix","sha":"e9b6cb7409fc90a71514008f4aadaba8e12df6f9","user":{"login":"SamJBarney","id":1827860,"avatar_url":"https://avatars.githubusercontent.com/u/1827860?v=3","gravatar_id":"","url":"https://api.github.com/users/SamJBarney","html_url":"https://github.com/SamJBarney","followers_url":"https://api.github.com/users/SamJBarney/followers","following_url":"https://api.github.com/users/SamJBarney/following{/other_user}","gists_url":"https://api.github.com/users/SamJBarney/gists{/gist_id}","starred_url":"https://api.github.com/users/SamJBarney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamJBarney/subscriptions","organizations_url":"https://api.github.com/users/SamJBarney/orgs","repos_url":"https://api.github.com/users/SamJBarney/repos","events_url":"https://api.github.com/users/SamJBarney/events{/privacy}","received_events_url":"https://api.github.com/users/SamJBarney/received_events","type":"User","site_admin":false},"repo":{"id":38647641,"name":"cuberite","full_name":"SamJBarney/cuberite","owner":{"login":"SamJBarney","id":1827860,"avatar_url":"https://avatars.githubusercontent.com/u/1827860?v=3","gravatar_id":"","url":"https://api.github.com/users/SamJBarney","html_url":"https://github.com/SamJBarney","followers_url":"https://api.github.com/users/SamJBarney/followers","following_url":"https://api.github.com/users/SamJBarney/following{/other_user}","gists_url":"https://api.github.com/users/SamJBarney/gists{/gist_id}","starred_url":"https://api.github.com/users/SamJBarney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamJBarney/subscriptions","organizations_url":"https://api.github.com/users/SamJBarney/orgs","repos_url":"https://api.github.com/users/SamJBarney/repos","events_url":"https://api.github.com/users/SamJBarney/events{/privacy}","received_events_url":"https://api.github.com/users/SamJBarney/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SamJBarney/cuberite","description":"A performant C++ Minecraft compatible game server","fork":true,"url":"https://api.github.com/repos/SamJBarney/cuberite","forks_url":"https://api.github.com/repos/SamJBarney/cuberite/forks","keys_url":"https://api.github.com/repos/SamJBarney/cuberite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SamJBarney/cuberite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SamJBarney/cuberite/teams","hooks_url":"https://api.github.com/repos/SamJBarney/cuberite/hooks","issue_events_url":"https://api.github.com/repos/SamJBarney/cuberite/issues/events{/number}","events_url":"https://api.github.com/repos/SamJBarney/cuberite/events","assignees_url":"https://api.github.com/repos/SamJBarney/cuberite/assignees{/user}","branches_url":"https://api.github.com/repos/SamJBarney/cuberite/branches{/branch}","tags_url":"https://api.github.com/repos/SamJBarney/cuberite/tags","blobs_url":"https://api.github.com/repos/SamJBarney/cuberite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SamJBarney/cuberite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SamJBarney/cuberite/git/refs{/sha}","trees_url":"https://api.github.com/repos/SamJBarney/cuberite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SamJBarney/cuberite/statuses/{sha}","languages_url":"https://api.github.com/repos/SamJBarney/cuberite/languages","stargazers_url":"https://api.github.com/repos/SamJBarney/cuberite/stargazers","contributors_url":"https://api.github.com/repos/SamJBarney/cuberite/contributors","subscribers_url":"https://api.github.com/repos/SamJBarney/cuberite/subscribers","subscription_url":"https://api.github.com/repos/SamJBarney/cuberite/subscription","commits_url":"https://api.github.com/repos/SamJBarney/cuberite/commits{/sha}","git_commits_url":"https://api.github.com/repos/SamJBarney/cuberite/git/commits{/sha}","comments_url":"https://api.github.com/repos/SamJBarney/cuberite/comments{/number}","issue_comment_url":"https://api.github.com/repos/SamJBarney/cuberite/issues/comments{/number}","contents_url":"https://api.github.com/repos/SamJBarney/cuberite/contents/{+path}","compare_url":"https://api.github.com/repos/SamJBarney/cuberite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SamJBarney/cuberite/merges","archive_url":"https://api.github.com/repos/SamJBarney/cuberite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SamJBarney/cuberite/downloads","issues_url":"https://api.github.com/repos/SamJBarney/cuberite/issues{/number}","pulls_url":"https://api.github.com/repos/SamJBarney/cuberite/pulls{/number}","milestones_url":"https://api.github.com/repos/SamJBarney/cuberite/milestones{/number}","notifications_url":"https://api.github.com/repos/SamJBarney/cuberite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SamJBarney/cuberite/labels{/name}","releases_url":"https://api.github.com/repos/SamJBarney/cuberite/releases{/id}","created_at":"2015-07-06T21:35:23Z","updated_at":"2015-07-06T21:35:28Z","pushed_at":"2015-07-23T21:59:31Z","git_url":"git://github.com/SamJBarney/cuberite.git","ssh_url":"git@github.com:SamJBarney/cuberite.git","clone_url":"https://github.com/SamJBarney/cuberite.git","svn_url":"https://github.com/SamJBarney/cuberite","homepage":"http://cuberite.org","size":77396,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cuberite:master","ref":"master","sha":"84e31ba670c05d38e83cba0bcdfba32d52c01ad9","user":{"login":"cuberite","id":8973961,"avatar_url":"https://avatars.githubusercontent.com/u/8973961?v=3","gravatar_id":"","url":"https://api.github.com/users/cuberite","html_url":"https://github.com/cuberite","followers_url":"https://api.github.com/users/cuberite/followers","following_url":"https://api.github.com/users/cuberite/following{/other_user}","gists_url":"https://api.github.com/users/cuberite/gists{/gist_id}","starred_url":"https://api.github.com/users/cuberite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuberite/subscriptions","organizations_url":"https://api.github.com/users/cuberite/orgs","repos_url":"https://api.github.com/users/cuberite/repos","events_url":"https://api.github.com/users/cuberite/events{/privacy}","received_events_url":"https://api.github.com/users/cuberite/received_events","type":"Organization","site_admin":false},"repo":{"id":11693709,"name":"cuberite","full_name":"cuberite/cuberite","owner":{"login":"cuberite","id":8973961,"avatar_url":"https://avatars.githubusercontent.com/u/8973961?v=3","gravatar_id":"","url":"https://api.github.com/users/cuberite","html_url":"https://github.com/cuberite","followers_url":"https://api.github.com/users/cuberite/followers","following_url":"https://api.github.com/users/cuberite/following{/other_user}","gists_url":"https://api.github.com/users/cuberite/gists{/gist_id}","starred_url":"https://api.github.com/users/cuberite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuberite/subscriptions","organizations_url":"https://api.github.com/users/cuberite/orgs","repos_url":"https://api.github.com/users/cuberite/repos","events_url":"https://api.github.com/users/cuberite/events{/privacy}","received_events_url":"https://api.github.com/users/cuberite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cuberite/cuberite","description":"A performant C++ Minecraft compatible game server","fork":false,"url":"https://api.github.com/repos/cuberite/cuberite","forks_url":"https://api.github.com/repos/cuberite/cuberite/forks","keys_url":"https://api.github.com/repos/cuberite/cuberite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cuberite/cuberite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cuberite/cuberite/teams","hooks_url":"https://api.github.com/repos/cuberite/cuberite/hooks","issue_events_url":"https://api.github.com/repos/cuberite/cuberite/issues/events{/number}","events_url":"https://api.github.com/repos/cuberite/cuberite/events","assignees_url":"https://api.github.com/repos/cuberite/cuberite/assignees{/user}","branches_url":"https://api.github.com/repos/cuberite/cuberite/branches{/branch}","tags_url":"https://api.github.com/repos/cuberite/cuberite/tags","blobs_url":"https://api.github.com/repos/cuberite/cuberite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cuberite/cuberite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cuberite/cuberite/git/refs{/sha}","trees_url":"https://api.github.com/repos/cuberite/cuberite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cuberite/cuberite/statuses/{sha}","languages_url":"https://api.github.com/repos/cuberite/cuberite/languages","stargazers_url":"https://api.github.com/repos/cuberite/cuberite/stargazers","contributors_url":"https://api.github.com/repos/cuberite/cuberite/contributors","subscribers_url":"https://api.github.com/repos/cuberite/cuberite/subscribers","subscription_url":"https://api.github.com/repos/cuberite/cuberite/subscription","commits_url":"https://api.github.com/repos/cuberite/cuberite/commits{/sha}","git_commits_url":"https://api.github.com/repos/cuberite/cuberite/git/commits{/sha}","comments_url":"https://api.github.com/repos/cuberite/cuberite/comments{/number}","issue_comment_url":"https://api.github.com/repos/cuberite/cuberite/issues/comments{/number}","contents_url":"https://api.github.com/repos/cuberite/cuberite/contents/{+path}","compare_url":"https://api.github.com/repos/cuberite/cuberite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cuberite/cuberite/merges","archive_url":"https://api.github.com/repos/cuberite/cuberite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cuberite/cuberite/downloads","issues_url":"https://api.github.com/repos/cuberite/cuberite/issues{/number}","pulls_url":"https://api.github.com/repos/cuberite/cuberite/pulls{/number}","milestones_url":"https://api.github.com/repos/cuberite/cuberite/milestones{/number}","notifications_url":"https://api.github.com/repos/cuberite/cuberite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cuberite/cuberite/labels{/name}","releases_url":"https://api.github.com/repos/cuberite/cuberite/releases{/id}","created_at":"2013-07-26T19:56:59Z","updated_at":"2015-07-23T16:47:35Z","pushed_at":"2015-07-24T02:34:14Z","git_url":"git://github.com/cuberite/cuberite.git","ssh_url":"git@github.com:cuberite/cuberite.git","clone_url":"https://github.com/cuberite/cuberite.git","svn_url":"https://github.com/cuberite/cuberite","homepage":"http://cuberite.org","size":166255,"stargazers_count":703,"watchers_count":703,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":215,"mirror_url":null,"open_issues_count":367,"forks":215,"open_issues":367,"watchers":703,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cuberite/cuberite/pulls/2371"},"html":{"href":"https://github.com/cuberite/cuberite/pull/2371"},"issue":{"href":"https://api.github.com/repos/cuberite/cuberite/issues/2371"},"comments":{"href":"https://api.github.com/repos/cuberite/cuberite/issues/2371/comments"},"review_comments":{"href":"https://api.github.com/repos/cuberite/cuberite/pulls/2371/comments"},"review_comment":{"href":"https://api.github.com/repos/cuberite/cuberite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cuberite/cuberite/pulls/2371/commits"},"statuses":{"href":"https://api.github.com/repos/cuberite/cuberite/statuses/e9b6cb7409fc90a71514008f4aadaba8e12df6f9"}}}}