{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/pulls/comments/22577862","id":22577862,"diff_hunk":"@@ -165,6 +159,37 @@ define([\n \n                 window.applyNativeFunctionCall(\"getMpuPosCallback\");\n \n+            },\n+            // iOS Timer\n+            iosTimer : function(time, yPos) {\n+                setTimeout(function() {\n+                    modules.runIosPoller(time, yPos);\n+                }, 1000);\n+            },\n+            // iOS Count\n+            runIosPoller : function(start, yPos) {\n+                var thisNumber = parseInt(start, 10) + 1;\n+                var yPolled;\n+                if (thisNumber <= 1000) { ","path":"ArticleTemplates/assets/js/modules/ads.js","position":80,"original_position":80,"commit_id":"1b2314f319fe7cc79080f595824ddedac3f94fad","original_commit_id":"1b2314f319fe7cc79080f595824ddedac3f94fad","user":{"login":"sandropaganotti","id":1101,"avatar_url":"https://avatars.githubusercontent.com/u/1101?v=3","gravatar_id":"","url":"https://api.github.com/users/sandropaganotti","html_url":"https://github.com/sandropaganotti","followers_url":"https://api.github.com/users/sandropaganotti/followers","following_url":"https://api.github.com/users/sandropaganotti/following{/other_user}","gists_url":"https://api.github.com/users/sandropaganotti/gists{/gist_id}","starred_url":"https://api.github.com/users/sandropaganotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandropaganotti/subscriptions","organizations_url":"https://api.github.com/users/sandropaganotti/orgs","repos_url":"https://api.github.com/users/sandropaganotti/repos","events_url":"https://api.github.com/users/sandropaganotti/events{/privacy}","received_events_url":"https://api.github.com/users/sandropaganotti/received_events","type":"User","site_admin":false},"body":"By doing this you're keeping the time running almost forever (1000 seconds) compared to the 20 seconds of the Android version.","created_at":"2015-01-07T09:44:09Z","updated_at":"2015-01-07T09:44:09Z","html_url":"https://github.com/guardian/mobile-apps-article-templates/pull/313#discussion_r22577862","pull_request_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/pulls/313","_links":{"self":{"href":"https://api.github.com/repos/guardian/mobile-apps-article-templates/pulls/comments/22577862"},"html":{"href":"https://github.com/guardian/mobile-apps-article-templates/pull/313#discussion_r22577862"},"pull_request":{"href":"https://api.github.com/repos/guardian/mobile-apps-article-templates/pulls/313"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/pulls/313","id":26884847,"html_url":"https://github.com/guardian/mobile-apps-article-templates/pull/313","diff_url":"https://github.com/guardian/mobile-apps-article-templates/pull/313.diff","patch_url":"https://github.com/guardian/mobile-apps-article-templates/pull/313.patch","issue_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/issues/313","number":313,"state":"open","locked":false,"title":"GIA 3321","user":{"login":"jglueck","id":8415554,"avatar_url":"https://avatars.githubusercontent.com/u/8415554?v=3","gravatar_id":"","url":"https://api.github.com/users/jglueck","html_url":"https://github.com/jglueck","followers_url":"https://api.github.com/users/jglueck/followers","following_url":"https://api.github.com/users/jglueck/following{/other_user}","gists_url":"https://api.github.com/users/jglueck/gists{/gist_id}","starred_url":"https://api.github.com/users/jglueck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglueck/subscriptions","organizations_url":"https://api.github.com/users/jglueck/orgs","repos_url":"https://api.github.com/users/jglueck/repos","events_url":"https://api.github.com/users/jglueck/events{/privacy}","received_events_url":"https://api.github.com/users/jglueck/received_events","type":"User","site_admin":false},"body":"GIA-3321 - Ads obscuring articles iOS 8,  similar functionality to Android solution AND-3194. Assets such as images that aren't cached, on a very slow network connection can move the advert placeholder after the coordinates are sent to the native code which actually positions the ad.\r\n\r\nThe solution runs a timer that checks for any position changes of the placeholder and if it does change triggers an x-gu://ad_moved call which iOS native code then runs updateAdPosition to change the ad's position.","created_at":"2015-01-06T11:59:51Z","updated_at":"2015-01-07T09:44:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad782d782a8bf2d007b635c00dfb12dfde4b3cec","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/pulls/313/commits","review_comments_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/pulls/313/comments","review_comment_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/pulls/comments/{number}","comments_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/issues/313/comments","statuses_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/statuses/1b2314f319fe7cc79080f595824ddedac3f94fad","head":{"label":"guardian:GIA-3321","ref":"GIA-3321","sha":"1b2314f319fe7cc79080f595824ddedac3f94fad","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":16987877,"name":"mobile-apps-article-templates","full_name":"guardian/mobile-apps-article-templates","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/mobile-apps-article-templates","description":"Templates for articles on both iOS and Android next-gen apps","fork":false,"url":"https://api.github.com/repos/guardian/mobile-apps-article-templates","forks_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/forks","keys_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/teams","hooks_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/hooks","issue_events_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/events","assignees_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/tags","blobs_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/languages","stargazers_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/stargazers","contributors_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/contributors","subscribers_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/subscribers","subscription_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/subscription","commits_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/issues/comments/{number}","contents_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/merges","archive_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/downloads","issues_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/labels{/name}","releases_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/releases{/id}","created_at":"2014-02-19T15:03:05Z","updated_at":"2015-01-06T10:57:11Z","pushed_at":"2015-01-06T17:57:59Z","git_url":"git://github.com/guardian/mobile-apps-article-templates.git","ssh_url":"git@github.com:guardian/mobile-apps-article-templates.git","clone_url":"https://github.com/guardian/mobile-apps-article-templates.git","svn_url":"https://github.com/guardian/mobile-apps-article-templates","homepage":null,"size":11112,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":7,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"4188c233d607c25ba78259fd38a2c9bb7846e578","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":16987877,"name":"mobile-apps-article-templates","full_name":"guardian/mobile-apps-article-templates","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/mobile-apps-article-templates","description":"Templates for articles on both iOS and Android next-gen apps","fork":false,"url":"https://api.github.com/repos/guardian/mobile-apps-article-templates","forks_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/forks","keys_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/teams","hooks_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/hooks","issue_events_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/events","assignees_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/tags","blobs_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/languages","stargazers_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/stargazers","contributors_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/contributors","subscribers_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/subscribers","subscription_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/subscription","commits_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/issues/comments/{number}","contents_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/merges","archive_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/downloads","issues_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/labels{/name}","releases_url":"https://api.github.com/repos/guardian/mobile-apps-article-templates/releases{/id}","created_at":"2014-02-19T15:03:05Z","updated_at":"2015-01-06T10:57:11Z","pushed_at":"2015-01-06T17:57:59Z","git_url":"git://github.com/guardian/mobile-apps-article-templates.git","ssh_url":"git@github.com:guardian/mobile-apps-article-templates.git","clone_url":"https://github.com/guardian/mobile-apps-article-templates.git","svn_url":"https://github.com/guardian/mobile-apps-article-templates","homepage":null,"size":11112,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/mobile-apps-article-templates/pulls/313"},"html":{"href":"https://github.com/guardian/mobile-apps-article-templates/pull/313"},"issue":{"href":"https://api.github.com/repos/guardian/mobile-apps-article-templates/issues/313"},"comments":{"href":"https://api.github.com/repos/guardian/mobile-apps-article-templates/issues/313/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/mobile-apps-article-templates/pulls/313/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/mobile-apps-article-templates/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/guardian/mobile-apps-article-templates/pulls/313/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/mobile-apps-article-templates/statuses/1b2314f319fe7cc79080f595824ddedac3f94fad"}}}}