{"action":"created","comment":{"url":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments/46855636","id":46855636,"diff_hunk":"@@ -54,7 +54,12 @@ record_warn(Meta, Ref, Opts, Added, E) ->\n calculate(Meta, Key, Opts, Old, File, Existing) ->\n   New = case keyfind(only, Opts) of\n     {only, Only} when is_list(Only) ->\n-      ensure_keyword_list(Meta, File, Only, only),\n+      ok = ensure_keyword_list(Meta, File, Only, only),\n+      case keyfind(except, Opts) of\n+        false -> ok;\n+        _ ->\n+          elixir_errors:compile_error(Meta, File, \":only and :except cannot be supplied together\")","path":"lib/elixir/src/elixir_import.erl","position":9,"original_position":9,"commit_id":"92b03000fe7eb738c365614ee99c81895aacb55f","original_commit_id":"92b03000fe7eb738c365614ee99c81895aacb55f","user":{"login":"josevalim","id":9582,"avatar_url":"https://avatars.githubusercontent.com/u/9582?v=3","gravatar_id":"","url":"https://api.github.com/users/josevalim","html_url":"https://github.com/josevalim","followers_url":"https://api.github.com/users/josevalim/followers","following_url":"https://api.github.com/users/josevalim/following{/other_user}","gists_url":"https://api.github.com/users/josevalim/gists{/gist_id}","starred_url":"https://api.github.com/users/josevalim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josevalim/subscriptions","organizations_url":"https://api.github.com/users/josevalim/orgs","repos_url":"https://api.github.com/users/josevalim/repos","events_url":"https://api.github.com/users/josevalim/events{/privacy}","received_events_url":"https://api.github.com/users/josevalim/received_events","type":"User","site_admin":false},"body":"should we say \":only and :except can only be supplied together when :only is :functions or :macros\"?","created_at":"2015-12-07T18:20:50Z","updated_at":"2015-12-07T18:20:50Z","html_url":"https://github.com/elixir-lang/elixir/pull/4049#discussion_r46855636","pull_request_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/4049","_links":{"self":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments/46855636"},"html":{"href":"https://github.com/elixir-lang/elixir/pull/4049#discussion_r46855636"},"pull_request":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/4049"}}},"pull_request":{"url":"https://api.github.com/repos/elixir-lang/elixir/pulls/4049","id":52762898,"html_url":"https://github.com/elixir-lang/elixir/pull/4049","diff_url":"https://github.com/elixir-lang/elixir/pull/4049.diff","patch_url":"https://github.com/elixir-lang/elixir/pull/4049.patch","issue_url":"https://api.github.com/repos/elixir-lang/elixir/issues/4049","number":4049,"state":"open","locked":false,"title":"Make import with conflicting options to raise","user":{"login":"lexmag","id":248290,"avatar_url":"https://avatars.githubusercontent.com/u/248290?v=3","gravatar_id":"","url":"https://api.github.com/users/lexmag","html_url":"https://github.com/lexmag","followers_url":"https://api.github.com/users/lexmag/followers","following_url":"https://api.github.com/users/lexmag/following{/other_user}","gists_url":"https://api.github.com/users/lexmag/gists{/gist_id}","starred_url":"https://api.github.com/users/lexmag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lexmag/subscriptions","organizations_url":"https://api.github.com/users/lexmag/orgs","repos_url":"https://api.github.com/users/lexmag/repos","events_url":"https://api.github.com/users/lexmag/events{/privacy}","received_events_url":"https://api.github.com/users/lexmag/received_events","type":"User","site_admin":false},"body":"Currently, `import` silently ignores `:except` option if `:only` as a keyword list is given:\r\n```elixir\r\niex> import String, only: [starts_with?: 2], except: [starts_with?: 2]\r\nnil\r\niex> starts_with?(\"a\", \"a\")\r\ntrue\r\n```\r\nThough `only: :functions` and `only: :macros` with `:except` are still valid.","created_at":"2015-12-05T19:53:27Z","updated_at":"2015-12-07T18:20:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"087524c8f385aff83152183738aae3d197c0d12a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/4049/commits","review_comments_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/4049/comments","review_comment_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elixir-lang/elixir/issues/4049/comments","statuses_url":"https://api.github.com/repos/elixir-lang/elixir/statuses/92b03000fe7eb738c365614ee99c81895aacb55f","head":{"label":"lexmag:conflicting-import","ref":"conflicting-import","sha":"92b03000fe7eb738c365614ee99c81895aacb55f","user":{"login":"lexmag","id":248290,"avatar_url":"https://avatars.githubusercontent.com/u/248290?v=3","gravatar_id":"","url":"https://api.github.com/users/lexmag","html_url":"https://github.com/lexmag","followers_url":"https://api.github.com/users/lexmag/followers","following_url":"https://api.github.com/users/lexmag/following{/other_user}","gists_url":"https://api.github.com/users/lexmag/gists{/gist_id}","starred_url":"https://api.github.com/users/lexmag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lexmag/subscriptions","organizations_url":"https://api.github.com/users/lexmag/orgs","repos_url":"https://api.github.com/users/lexmag/repos","events_url":"https://api.github.com/users/lexmag/events{/privacy}","received_events_url":"https://api.github.com/users/lexmag/received_events","type":"User","site_admin":false},"repo":{"id":19643959,"name":"elixir","full_name":"lexmag/elixir","owner":{"login":"lexmag","id":248290,"avatar_url":"https://avatars.githubusercontent.com/u/248290?v=3","gravatar_id":"","url":"https://api.github.com/users/lexmag","html_url":"https://github.com/lexmag","followers_url":"https://api.github.com/users/lexmag/followers","following_url":"https://api.github.com/users/lexmag/following{/other_user}","gists_url":"https://api.github.com/users/lexmag/gists{/gist_id}","starred_url":"https://api.github.com/users/lexmag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lexmag/subscriptions","organizations_url":"https://api.github.com/users/lexmag/orgs","repos_url":"https://api.github.com/users/lexmag/repos","events_url":"https://api.github.com/users/lexmag/events{/privacy}","received_events_url":"https://api.github.com/users/lexmag/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lexmag/elixir","description":"Elixir is a functional, meta-programming aware language built on top of the Erlang VM. It is a dynamic language that focuses on tooling to leverage Erlang's abilities to build concurrent, distributed and fault-tolerant applications with hot code upgrades","fork":true,"url":"https://api.github.com/repos/lexmag/elixir","forks_url":"https://api.github.com/repos/lexmag/elixir/forks","keys_url":"https://api.github.com/repos/lexmag/elixir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lexmag/elixir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lexmag/elixir/teams","hooks_url":"https://api.github.com/repos/lexmag/elixir/hooks","issue_events_url":"https://api.github.com/repos/lexmag/elixir/issues/events{/number}","events_url":"https://api.github.com/repos/lexmag/elixir/events","assignees_url":"https://api.github.com/repos/lexmag/elixir/assignees{/user}","branches_url":"https://api.github.com/repos/lexmag/elixir/branches{/branch}","tags_url":"https://api.github.com/repos/lexmag/elixir/tags","blobs_url":"https://api.github.com/repos/lexmag/elixir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lexmag/elixir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lexmag/elixir/git/refs{/sha}","trees_url":"https://api.github.com/repos/lexmag/elixir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lexmag/elixir/statuses/{sha}","languages_url":"https://api.github.com/repos/lexmag/elixir/languages","stargazers_url":"https://api.github.com/repos/lexmag/elixir/stargazers","contributors_url":"https://api.github.com/repos/lexmag/elixir/contributors","subscribers_url":"https://api.github.com/repos/lexmag/elixir/subscribers","subscription_url":"https://api.github.com/repos/lexmag/elixir/subscription","commits_url":"https://api.github.com/repos/lexmag/elixir/commits{/sha}","git_commits_url":"https://api.github.com/repos/lexmag/elixir/git/commits{/sha}","comments_url":"https://api.github.com/repos/lexmag/elixir/comments{/number}","issue_comment_url":"https://api.github.com/repos/lexmag/elixir/issues/comments{/number}","contents_url":"https://api.github.com/repos/lexmag/elixir/contents/{+path}","compare_url":"https://api.github.com/repos/lexmag/elixir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lexmag/elixir/merges","archive_url":"https://api.github.com/repos/lexmag/elixir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lexmag/elixir/downloads","issues_url":"https://api.github.com/repos/lexmag/elixir/issues{/number}","pulls_url":"https://api.github.com/repos/lexmag/elixir/pulls{/number}","milestones_url":"https://api.github.com/repos/lexmag/elixir/milestones{/number}","notifications_url":"https://api.github.com/repos/lexmag/elixir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lexmag/elixir/labels{/name}","releases_url":"https://api.github.com/repos/lexmag/elixir/releases{/id}","created_at":"2014-05-10T14:57:40Z","updated_at":"2015-02-18T22:20:49Z","pushed_at":"2015-12-05T19:36:56Z","git_url":"git://github.com/lexmag/elixir.git","ssh_url":"git@github.com:lexmag/elixir.git","clone_url":"https://github.com/lexmag/elixir.git","svn_url":"https://github.com/lexmag/elixir","homepage":"http://elixir-lang.org/","size":32276,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elixir-lang:master","ref":"master","sha":"ecd86761da45bec47c0b2db7b7054fd2e0f603c3","user":{"login":"elixir-lang","id":1481354,"avatar_url":"https://avatars.githubusercontent.com/u/1481354?v=3","gravatar_id":"","url":"https://api.github.com/users/elixir-lang","html_url":"https://github.com/elixir-lang","followers_url":"https://api.github.com/users/elixir-lang/followers","following_url":"https://api.github.com/users/elixir-lang/following{/other_user}","gists_url":"https://api.github.com/users/elixir-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-lang/subscriptions","organizations_url":"https://api.github.com/users/elixir-lang/orgs","repos_url":"https://api.github.com/users/elixir-lang/repos","events_url":"https://api.github.com/users/elixir-lang/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":1234714,"name":"elixir","full_name":"elixir-lang/elixir","owner":{"login":"elixir-lang","id":1481354,"avatar_url":"https://avatars.githubusercontent.com/u/1481354?v=3","gravatar_id":"","url":"https://api.github.com/users/elixir-lang","html_url":"https://github.com/elixir-lang","followers_url":"https://api.github.com/users/elixir-lang/followers","following_url":"https://api.github.com/users/elixir-lang/following{/other_user}","gists_url":"https://api.github.com/users/elixir-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-lang/subscriptions","organizations_url":"https://api.github.com/users/elixir-lang/orgs","repos_url":"https://api.github.com/users/elixir-lang/repos","events_url":"https://api.github.com/users/elixir-lang/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elixir-lang/elixir","description":"Elixir is a dynamic, functional language designed for building scalable and maintainable applications","fork":false,"url":"https://api.github.com/repos/elixir-lang/elixir","forks_url":"https://api.github.com/repos/elixir-lang/elixir/forks","keys_url":"https://api.github.com/repos/elixir-lang/elixir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elixir-lang/elixir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elixir-lang/elixir/teams","hooks_url":"https://api.github.com/repos/elixir-lang/elixir/hooks","issue_events_url":"https://api.github.com/repos/elixir-lang/elixir/issues/events{/number}","events_url":"https://api.github.com/repos/elixir-lang/elixir/events","assignees_url":"https://api.github.com/repos/elixir-lang/elixir/assignees{/user}","branches_url":"https://api.github.com/repos/elixir-lang/elixir/branches{/branch}","tags_url":"https://api.github.com/repos/elixir-lang/elixir/tags","blobs_url":"https://api.github.com/repos/elixir-lang/elixir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elixir-lang/elixir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elixir-lang/elixir/git/refs{/sha}","trees_url":"https://api.github.com/repos/elixir-lang/elixir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elixir-lang/elixir/statuses/{sha}","languages_url":"https://api.github.com/repos/elixir-lang/elixir/languages","stargazers_url":"https://api.github.com/repos/elixir-lang/elixir/stargazers","contributors_url":"https://api.github.com/repos/elixir-lang/elixir/contributors","subscribers_url":"https://api.github.com/repos/elixir-lang/elixir/subscribers","subscription_url":"https://api.github.com/repos/elixir-lang/elixir/subscription","commits_url":"https://api.github.com/repos/elixir-lang/elixir/commits{/sha}","git_commits_url":"https://api.github.com/repos/elixir-lang/elixir/git/commits{/sha}","comments_url":"https://api.github.com/repos/elixir-lang/elixir/comments{/number}","issue_comment_url":"https://api.github.com/repos/elixir-lang/elixir/issues/comments{/number}","contents_url":"https://api.github.com/repos/elixir-lang/elixir/contents/{+path}","compare_url":"https://api.github.com/repos/elixir-lang/elixir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elixir-lang/elixir/merges","archive_url":"https://api.github.com/repos/elixir-lang/elixir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elixir-lang/elixir/downloads","issues_url":"https://api.github.com/repos/elixir-lang/elixir/issues{/number}","pulls_url":"https://api.github.com/repos/elixir-lang/elixir/pulls{/number}","milestones_url":"https://api.github.com/repos/elixir-lang/elixir/milestones{/number}","notifications_url":"https://api.github.com/repos/elixir-lang/elixir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elixir-lang/elixir/labels{/name}","releases_url":"https://api.github.com/repos/elixir-lang/elixir/releases{/id}","created_at":"2011-01-09T08:43:57Z","updated_at":"2015-12-07T13:48:47Z","pushed_at":"2015-12-07T15:41:55Z","git_url":"git://github.com/elixir-lang/elixir.git","ssh_url":"git@github.com:elixir-lang/elixir.git","clone_url":"https://github.com/elixir-lang/elixir.git","svn_url":"https://github.com/elixir-lang/elixir","homepage":"http://elixir-lang.org/","size":40656,"stargazers_count":5540,"watchers_count":5540,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":767,"mirror_url":null,"open_issues_count":38,"forks":767,"open_issues":38,"watchers":5540,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/4049"},"html":{"href":"https://github.com/elixir-lang/elixir/pull/4049"},"issue":{"href":"https://api.github.com/repos/elixir-lang/elixir/issues/4049"},"comments":{"href":"https://api.github.com/repos/elixir-lang/elixir/issues/4049/comments"},"review_comments":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/4049/comments"},"review_comment":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/4049/commits"},"statuses":{"href":"https://api.github.com/repos/elixir-lang/elixir/statuses/92b03000fe7eb738c365614ee99c81895aacb55f"}}}}