{"action":"created","comment":{"url":"https://api.github.com/repos/hueniverse/hueniversity/pulls/comments/27343789","id":27343789,"diff_hunk":"@@ -10,19 +10,25 @@ var Version = require('./version');\n var internals = {};\n \n \n-internals.init = function () {\n+exports.init = function (port, callback) {","path":"lib/index.js","position":5,"original_position":5,"commit_id":"90f7f99a0f1da3e745007633a183142b29f4131e","original_commit_id":"90f7f99a0f1da3e745007633a183142b29f4131e","user":{"login":"roelof1967","id":7189323,"avatar_url":"https://avatars.githubusercontent.com/u/7189323?v=3","gravatar_id":"","url":"https://api.github.com/users/roelof1967","html_url":"https://github.com/roelof1967","followers_url":"https://api.github.com/users/roelof1967/followers","following_url":"https://api.github.com/users/roelof1967/following{/other_user}","gists_url":"https://api.github.com/users/roelof1967/gists{/gist_id}","starred_url":"https://api.github.com/users/roelof1967/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roelof1967/subscriptions","organizations_url":"https://api.github.com/users/roelof1967/orgs","repos_url":"https://api.github.com/users/roelof1967/repos","events_url":"https://api.github.com/users/roelof1967/events{/privacy}","received_events_url":"https://api.github.com/users/roelof1967/received_events","type":"User","site_admin":false},"body":"Thanks, but as soon as I added this : \r\n\r\n~~~\r\n\r\nif (typeof port === 'function') {\r\n        callback = port;\r\n        port = internals.port;\r\n    }\r\n\r\n~~~  \r\n\r\nThen all the test of index are failing. I have then a coverage of 93%. ","created_at":"2015-03-28T09:52:46Z","updated_at":"2015-03-28T09:52:46Z","html_url":"https://github.com/hueniverse/hueniversity/pull/88#discussion_r27343789","pull_request_url":"https://api.github.com/repos/hueniverse/hueniversity/pulls/88","_links":{"self":{"href":"https://api.github.com/repos/hueniverse/hueniversity/pulls/comments/27343789"},"html":{"href":"https://github.com/hueniverse/hueniversity/pull/88#discussion_r27343789"},"pull_request":{"href":"https://api.github.com/repos/hueniverse/hueniversity/pulls/88"}}},"pull_request":{"url":"https://api.github.com/repos/hueniverse/hueniversity/pulls/88","id":32091311,"html_url":"https://github.com/hueniverse/hueniversity/pull/88","diff_url":"https://github.com/hueniverse/hueniversity/pull/88.diff","patch_url":"https://github.com/hueniverse/hueniversity/pull/88.patch","issue_url":"https://api.github.com/repos/hueniverse/hueniversity/issues/88","number":88,"state":"open","locked":false,"title":"Final submission : 100 % coverage ","user":{"login":"roelof1967","id":7189323,"avatar_url":"https://avatars.githubusercontent.com/u/7189323?v=3","gravatar_id":"","url":"https://api.github.com/users/roelof1967","html_url":"https://github.com/roelof1967","followers_url":"https://api.github.com/users/roelof1967/followers","following_url":"https://api.github.com/users/roelof1967/following{/other_user}","gists_url":"https://api.github.com/users/roelof1967/gists{/gist_id}","starred_url":"https://api.github.com/users/roelof1967/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roelof1967/subscriptions","organizations_url":"https://api.github.com/users/roelof1967/orgs","repos_url":"https://api.github.com/users/roelof1967/repos","events_url":"https://api.github.com/users/roelof1967/events{/privacy}","received_events_url":"https://api.github.com/users/roelof1967/received_events","type":"User","site_admin":false},"body":"Hello, \r\n\r\nLab says there is still no coverage on line 16 of index.js. \r\nI do not agree with it because I wrote two test which test if a server starts up on port 8000 (standard) and on port 5000. And the test are passed.\r\n\r\nAnyone a tip how to solve this ?","created_at":"2015-03-27T08:53:25Z","updated_at":"2015-03-28T09:52:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e75afa5718a1b1315f27a5a89fddd71d3466a0b6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hueniverse/hueniversity/pulls/88/commits","review_comments_url":"https://api.github.com/repos/hueniverse/hueniversity/pulls/88/comments","review_comment_url":"https://api.github.com/repos/hueniverse/hueniversity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hueniverse/hueniversity/issues/88/comments","statuses_url":"https://api.github.com/repos/hueniverse/hueniversity/statuses/90f7f99a0f1da3e745007633a183142b29f4131e","head":{"label":"roelof1967:master","ref":"master","sha":"90f7f99a0f1da3e745007633a183142b29f4131e","user":{"login":"roelof1967","id":7189323,"avatar_url":"https://avatars.githubusercontent.com/u/7189323?v=3","gravatar_id":"","url":"https://api.github.com/users/roelof1967","html_url":"https://github.com/roelof1967","followers_url":"https://api.github.com/users/roelof1967/followers","following_url":"https://api.github.com/users/roelof1967/following{/other_user}","gists_url":"https://api.github.com/users/roelof1967/gists{/gist_id}","starred_url":"https://api.github.com/users/roelof1967/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roelof1967/subscriptions","organizations_url":"https://api.github.com/users/roelof1967/orgs","repos_url":"https://api.github.com/users/roelof1967/repos","events_url":"https://api.github.com/users/roelof1967/events{/privacy}","received_events_url":"https://api.github.com/users/roelof1967/received_events","type":"User","site_admin":false},"repo":{"id":32847745,"name":"hueniversity","full_name":"roelof1967/hueniversity","owner":{"login":"roelof1967","id":7189323,"avatar_url":"https://avatars.githubusercontent.com/u/7189323?v=3","gravatar_id":"","url":"https://api.github.com/users/roelof1967","html_url":"https://github.com/roelof1967","followers_url":"https://api.github.com/users/roelof1967/followers","following_url":"https://api.github.com/users/roelof1967/following{/other_user}","gists_url":"https://api.github.com/users/roelof1967/gists{/gist_id}","starred_url":"https://api.github.com/users/roelof1967/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roelof1967/subscriptions","organizations_url":"https://api.github.com/users/roelof1967/orgs","repos_url":"https://api.github.com/users/roelof1967/repos","events_url":"https://api.github.com/users/roelof1967/events{/privacy}","received_events_url":"https://api.github.com/users/roelof1967/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/roelof1967/hueniversity","description":"Community learning experiment","fork":true,"url":"https://api.github.com/repos/roelof1967/hueniversity","forks_url":"https://api.github.com/repos/roelof1967/hueniversity/forks","keys_url":"https://api.github.com/repos/roelof1967/hueniversity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roelof1967/hueniversity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roelof1967/hueniversity/teams","hooks_url":"https://api.github.com/repos/roelof1967/hueniversity/hooks","issue_events_url":"https://api.github.com/repos/roelof1967/hueniversity/issues/events{/number}","events_url":"https://api.github.com/repos/roelof1967/hueniversity/events","assignees_url":"https://api.github.com/repos/roelof1967/hueniversity/assignees{/user}","branches_url":"https://api.github.com/repos/roelof1967/hueniversity/branches{/branch}","tags_url":"https://api.github.com/repos/roelof1967/hueniversity/tags","blobs_url":"https://api.github.com/repos/roelof1967/hueniversity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roelof1967/hueniversity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roelof1967/hueniversity/git/refs{/sha}","trees_url":"https://api.github.com/repos/roelof1967/hueniversity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roelof1967/hueniversity/statuses/{sha}","languages_url":"https://api.github.com/repos/roelof1967/hueniversity/languages","stargazers_url":"https://api.github.com/repos/roelof1967/hueniversity/stargazers","contributors_url":"https://api.github.com/repos/roelof1967/hueniversity/contributors","subscribers_url":"https://api.github.com/repos/roelof1967/hueniversity/subscribers","subscription_url":"https://api.github.com/repos/roelof1967/hueniversity/subscription","commits_url":"https://api.github.com/repos/roelof1967/hueniversity/commits{/sha}","git_commits_url":"https://api.github.com/repos/roelof1967/hueniversity/git/commits{/sha}","comments_url":"https://api.github.com/repos/roelof1967/hueniversity/comments{/number}","issue_comment_url":"https://api.github.com/repos/roelof1967/hueniversity/issues/comments{/number}","contents_url":"https://api.github.com/repos/roelof1967/hueniversity/contents/{+path}","compare_url":"https://api.github.com/repos/roelof1967/hueniversity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roelof1967/hueniversity/merges","archive_url":"https://api.github.com/repos/roelof1967/hueniversity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roelof1967/hueniversity/downloads","issues_url":"https://api.github.com/repos/roelof1967/hueniversity/issues{/number}","pulls_url":"https://api.github.com/repos/roelof1967/hueniversity/pulls{/number}","milestones_url":"https://api.github.com/repos/roelof1967/hueniversity/milestones{/number}","notifications_url":"https://api.github.com/repos/roelof1967/hueniversity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roelof1967/hueniversity/labels{/name}","releases_url":"https://api.github.com/repos/roelof1967/hueniversity/releases{/id}","created_at":"2015-03-25T06:49:47Z","updated_at":"2015-03-27T17:37:39Z","pushed_at":"2015-03-27T17:37:38Z","git_url":"git://github.com/roelof1967/hueniversity.git","ssh_url":"git@github.com:roelof1967/hueniversity.git","clone_url":"https://github.com/roelof1967/hueniversity.git","svn_url":"https://github.com/roelof1967/hueniversity","homepage":null,"size":150,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hueniverse:master","ref":"master","sha":"3c0bc6975169f7159a8cf7387aca9c811fa165ec","user":{"login":"hueniverse","id":56631,"avatar_url":"https://avatars.githubusercontent.com/u/56631?v=3","gravatar_id":"","url":"https://api.github.com/users/hueniverse","html_url":"https://github.com/hueniverse","followers_url":"https://api.github.com/users/hueniverse/followers","following_url":"https://api.github.com/users/hueniverse/following{/other_user}","gists_url":"https://api.github.com/users/hueniverse/gists{/gist_id}","starred_url":"https://api.github.com/users/hueniverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hueniverse/subscriptions","organizations_url":"https://api.github.com/users/hueniverse/orgs","repos_url":"https://api.github.com/users/hueniverse/repos","events_url":"https://api.github.com/users/hueniverse/events{/privacy}","received_events_url":"https://api.github.com/users/hueniverse/received_events","type":"User","site_admin":false},"repo":{"id":31759095,"name":"hueniversity","full_name":"hueniverse/hueniversity","owner":{"login":"hueniverse","id":56631,"avatar_url":"https://avatars.githubusercontent.com/u/56631?v=3","gravatar_id":"","url":"https://api.github.com/users/hueniverse","html_url":"https://github.com/hueniverse","followers_url":"https://api.github.com/users/hueniverse/followers","following_url":"https://api.github.com/users/hueniverse/following{/other_user}","gists_url":"https://api.github.com/users/hueniverse/gists{/gist_id}","starred_url":"https://api.github.com/users/hueniverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hueniverse/subscriptions","organizations_url":"https://api.github.com/users/hueniverse/orgs","repos_url":"https://api.github.com/users/hueniverse/repos","events_url":"https://api.github.com/users/hueniverse/events{/privacy}","received_events_url":"https://api.github.com/users/hueniverse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hueniverse/hueniversity","description":"Community learning experiment","fork":false,"url":"https://api.github.com/repos/hueniverse/hueniversity","forks_url":"https://api.github.com/repos/hueniverse/hueniversity/forks","keys_url":"https://api.github.com/repos/hueniverse/hueniversity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hueniverse/hueniversity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hueniverse/hueniversity/teams","hooks_url":"https://api.github.com/repos/hueniverse/hueniversity/hooks","issue_events_url":"https://api.github.com/repos/hueniverse/hueniversity/issues/events{/number}","events_url":"https://api.github.com/repos/hueniverse/hueniversity/events","assignees_url":"https://api.github.com/repos/hueniverse/hueniversity/assignees{/user}","branches_url":"https://api.github.com/repos/hueniverse/hueniversity/branches{/branch}","tags_url":"https://api.github.com/repos/hueniverse/hueniversity/tags","blobs_url":"https://api.github.com/repos/hueniverse/hueniversity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hueniverse/hueniversity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hueniverse/hueniversity/git/refs{/sha}","trees_url":"https://api.github.com/repos/hueniverse/hueniversity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hueniverse/hueniversity/statuses/{sha}","languages_url":"https://api.github.com/repos/hueniverse/hueniversity/languages","stargazers_url":"https://api.github.com/repos/hueniverse/hueniversity/stargazers","contributors_url":"https://api.github.com/repos/hueniverse/hueniversity/contributors","subscribers_url":"https://api.github.com/repos/hueniverse/hueniversity/subscribers","subscription_url":"https://api.github.com/repos/hueniverse/hueniversity/subscription","commits_url":"https://api.github.com/repos/hueniverse/hueniversity/commits{/sha}","git_commits_url":"https://api.github.com/repos/hueniverse/hueniversity/git/commits{/sha}","comments_url":"https://api.github.com/repos/hueniverse/hueniversity/comments{/number}","issue_comment_url":"https://api.github.com/repos/hueniverse/hueniversity/issues/comments{/number}","contents_url":"https://api.github.com/repos/hueniverse/hueniversity/contents/{+path}","compare_url":"https://api.github.com/repos/hueniverse/hueniversity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hueniverse/hueniversity/merges","archive_url":"https://api.github.com/repos/hueniverse/hueniversity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hueniverse/hueniversity/downloads","issues_url":"https://api.github.com/repos/hueniverse/hueniversity/issues{/number}","pulls_url":"https://api.github.com/repos/hueniverse/hueniversity/pulls{/number}","milestones_url":"https://api.github.com/repos/hueniverse/hueniversity/milestones{/number}","notifications_url":"https://api.github.com/repos/hueniverse/hueniversity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hueniverse/hueniversity/labels{/name}","releases_url":"https://api.github.com/repos/hueniverse/hueniversity/releases{/id}","created_at":"2015-03-06T08:09:03Z","updated_at":"2015-03-27T23:06:46Z","pushed_at":"2015-03-28T08:06:55Z","git_url":"git://github.com/hueniverse/hueniversity.git","ssh_url":"git@github.com:hueniverse/hueniversity.git","clone_url":"https://github.com/hueniverse/hueniversity.git","svn_url":"https://github.com/hueniverse/hueniversity","homepage":null,"size":3083,"stargazers_count":129,"watchers_count":129,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":96,"mirror_url":null,"open_issues_count":10,"forks":96,"open_issues":10,"watchers":129,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hueniverse/hueniversity/pulls/88"},"html":{"href":"https://github.com/hueniverse/hueniversity/pull/88"},"issue":{"href":"https://api.github.com/repos/hueniverse/hueniversity/issues/88"},"comments":{"href":"https://api.github.com/repos/hueniverse/hueniversity/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/hueniverse/hueniversity/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/hueniverse/hueniversity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hueniverse/hueniversity/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/hueniverse/hueniversity/statuses/90f7f99a0f1da3e745007633a183142b29f4131e"}}}}