{"push_id":769689165,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"1742b33156b0ac5501e2f349a80c57dffb1513a8","before":"baee6dbe4b961ac38f00f4ed25126ccc29850623","commits":[{"sha":"2fbf93e49bd860bcca71ff739994a4265546e7d1","author":{"email":"d4d5da4143815a8d9a95e01de54d9fa4b1015f55@gmail.com","name":"renan-ranelli"},"message":"Fix bug in tgt caching\n\nThis commit fixes a bug in the caching mechanism at\n`Cassette::Client#st_with_retry` introduced at 183e1e5a33e7.\n\nAs you can see, in our testing suite we have no tests for caching:\n\n```\nPending: (Failures listed here are expected and do not affect your suite's status)\n\n  1) Cassette::Authentication::Cache\n     # Not yet implemented\n     # ./spec/cassette/authentication/cache_spec.rb:7\n\n  2) Cassette::Client::Cache\n     # Not yet implemented\n     # ./spec/cassette/client/cache_spec.rb:6\n```\n\nThat's probably why the bug slipped through our refactoring.\n\nBefore this fix:\n\n    irb(main):001:0> Cassette::Client.st_for('hodor')\n    fetching from tgt source\n    fetching from st source\n    => \"ST-25146147-Ethe5cFv2vSdZQBI0j3u-moe\"\n    irb(main):002:0> Cassette::Client.st_for('hodor')\n    fetching from tgt source\n    fetching from st source\n    => \"ST-25146147-Ethe5cFv2vSdZQBI0j3u-moe\"\n    irb(main):003:0> Cassette::Client.st_for('hodor')\n    fetching from tgt source\n    fetching from st source\n    => \"ST-25146147-Ethe5cFv2vSdZQBI0j3u-moe\"\n\nWhich reads: \"every time we call #st_for we are fetching a new tgt and\nst tickets.\"\n\nAfter this fix:\n\n    irb(main):001:0> Cassette::Client.st_for('hodor')\n    fetching from tgt source\n    fetching from st source\n    => \"ST-25146147-Ethe5cFv2vSdZQBI0j3u-moe\"\n    irb(main):002:0> Cassette::Client.st_for('hodor')\n    => \"ST-25146147-Ethe5cFv2vSdZQBI0j3u-moe\"\n    irb(main):003:0> Cassette::Client.st_for('hodor')\n\nWhich reads: we are not messing everything up with lame refactorings.","distinct":true,"url":"https://api.github.com/repos/locaweb/cassette/commits/2fbf93e49bd860bcca71ff739994a4265546e7d1"},{"sha":"1742b33156b0ac5501e2f349a80c57dffb1513a8","author":{"email":"84b30b1f3b1c517c3a01238c1a5e87218e9ef7fb@gmail.com","name":"Ricardo Hermida Ruiz"},"message":"Merge pull request #11 from rranelli/fix-caching-bug\n\nFixes a bug in tgt caching","distinct":true,"url":"https://api.github.com/repos/locaweb/cassette/commits/1742b33156b0ac5501e2f349a80c57dffb1513a8"}]}