{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/34413226","id":34413226,"diff_hunk":"@@ -211,7 +212,16 @@ private[spark] class ExecutorAllocationManager(\n     listenerBus.addListener(listener)\n \n     val scheduleTask = new Runnable() {\n-      override def run(): Unit = Utils.logUncaughtExceptions(schedule())\n+      override def run(): Unit = {","path":"core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala","position":13,"original_position":13,"commit_id":"efc4f24df54e280bc7e93de1932b0d1a5e7aded6","original_commit_id":"efc4f24df54e280bc7e93de1932b0d1a5e7aded6","user":{"login":"srowen","id":822522,"avatar_url":"https://avatars.githubusercontent.com/u/822522?v=3","gravatar_id":"","url":"https://api.github.com/users/srowen","html_url":"https://github.com/srowen","followers_url":"https://api.github.com/users/srowen/followers","following_url":"https://api.github.com/users/srowen/following{/other_user}","gists_url":"https://api.github.com/users/srowen/gists{/gist_id}","starred_url":"https://api.github.com/users/srowen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srowen/subscriptions","organizations_url":"https://api.github.com/users/srowen/orgs","repos_url":"https://api.github.com/users/srowen/repos","events_url":"https://api.github.com/users/srowen/events{/privacy}","received_events_url":"https://api.github.com/users/srowen/received_events","type":"User","site_admin":false},"body":"Right, but, according to the JIRA you are dealing with an exception case. How does this stop the thread from stopping?","created_at":"2015-07-11T14:44:24Z","updated_at":"2015-07-11T14:44:24Z","html_url":"https://github.com/apache/spark/pull/7352#discussion_r34413226","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/7352","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/34413226"},"html":{"href":"https://github.com/apache/spark/pull/7352#discussion_r34413226"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/7352"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/7352","id":39738082,"html_url":"https://github.com/apache/spark/pull/7352","diff_url":"https://github.com/apache/spark/pull/7352.diff","patch_url":"https://github.com/apache/spark/pull/7352.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/7352","number":7352,"state":"open","locked":false,"title":"[SPARK-8974] The thread of spark-dynamic-executor-allocation not need throw exception ","user":{"login":"KaiXinXiaoLei","id":9440626,"avatar_url":"https://avatars.githubusercontent.com/u/9440626?v=3","gravatar_id":"","url":"https://api.github.com/users/KaiXinXiaoLei","html_url":"https://github.com/KaiXinXiaoLei","followers_url":"https://api.github.com/users/KaiXinXiaoLei/followers","following_url":"https://api.github.com/users/KaiXinXiaoLei/following{/other_user}","gists_url":"https://api.github.com/users/KaiXinXiaoLei/gists{/gist_id}","starred_url":"https://api.github.com/users/KaiXinXiaoLei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KaiXinXiaoLei/subscriptions","organizations_url":"https://api.github.com/users/KaiXinXiaoLei/orgs","repos_url":"https://api.github.com/users/KaiXinXiaoLei/repos","events_url":"https://api.github.com/users/KaiXinXiaoLei/events{/privacy}","received_events_url":"https://api.github.com/users/KaiXinXiaoLei/received_events","type":"User","site_admin":false},"body":"If this thread throanw exception, and the ApplictionMaster and driver is running normally, executor allocation will fail in this case.","created_at":"2015-07-11T02:10:30Z","updated_at":"2015-07-11T14:44:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3a4cb53be2925084f5a4171cd3298372e456c53","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/7352/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/7352/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/7352/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/efc4f24df54e280bc7e93de1932b0d1a5e7aded6","head":{"label":"KaiXinXiaoLei:dym","ref":"dym","sha":"efc4f24df54e280bc7e93de1932b0d1a5e7aded6","user":{"login":"KaiXinXiaoLei","id":9440626,"avatar_url":"https://avatars.githubusercontent.com/u/9440626?v=3","gravatar_id":"","url":"https://api.github.com/users/KaiXinXiaoLei","html_url":"https://github.com/KaiXinXiaoLei","followers_url":"https://api.github.com/users/KaiXinXiaoLei/followers","following_url":"https://api.github.com/users/KaiXinXiaoLei/following{/other_user}","gists_url":"https://api.github.com/users/KaiXinXiaoLei/gists{/gist_id}","starred_url":"https://api.github.com/users/KaiXinXiaoLei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KaiXinXiaoLei/subscriptions","organizations_url":"https://api.github.com/users/KaiXinXiaoLei/orgs","repos_url":"https://api.github.com/users/KaiXinXiaoLei/repos","events_url":"https://api.github.com/users/KaiXinXiaoLei/events{/privacy}","received_events_url":"https://api.github.com/users/KaiXinXiaoLei/received_events","type":"User","site_admin":false},"repo":{"id":25898697,"name":"spark","full_name":"KaiXinXiaoLei/spark","owner":{"login":"KaiXinXiaoLei","id":9440626,"avatar_url":"https://avatars.githubusercontent.com/u/9440626?v=3","gravatar_id":"","url":"https://api.github.com/users/KaiXinXiaoLei","html_url":"https://github.com/KaiXinXiaoLei","followers_url":"https://api.github.com/users/KaiXinXiaoLei/followers","following_url":"https://api.github.com/users/KaiXinXiaoLei/following{/other_user}","gists_url":"https://api.github.com/users/KaiXinXiaoLei/gists{/gist_id}","starred_url":"https://api.github.com/users/KaiXinXiaoLei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KaiXinXiaoLei/subscriptions","organizations_url":"https://api.github.com/users/KaiXinXiaoLei/orgs","repos_url":"https://api.github.com/users/KaiXinXiaoLei/repos","events_url":"https://api.github.com/users/KaiXinXiaoLei/events{/privacy}","received_events_url":"https://api.github.com/users/KaiXinXiaoLei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KaiXinXiaoLei/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/KaiXinXiaoLei/spark","forks_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/forks","keys_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/teams","hooks_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/hooks","issue_events_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/issues/events{/number}","events_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/events","assignees_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/assignees{/user}","branches_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/branches{/branch}","tags_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/tags","blobs_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/languages","stargazers_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/stargazers","contributors_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/contributors","subscribers_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/subscribers","subscription_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/subscription","commits_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/contents/{+path}","compare_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/merges","archive_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/downloads","issues_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/issues{/number}","pulls_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/labels{/name}","releases_url":"https://api.github.com/repos/KaiXinXiaoLei/spark/releases{/id}","created_at":"2014-10-29T01:33:27Z","updated_at":"2015-04-17T08:31:11Z","pushed_at":"2015-07-11T02:04:00Z","git_url":"git://github.com/KaiXinXiaoLei/spark.git","ssh_url":"git@github.com:KaiXinXiaoLei/spark.git","clone_url":"https://github.com/KaiXinXiaoLei/spark.git","svn_url":"https://github.com/KaiXinXiaoLei/spark","homepage":null,"size":107611,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"05ac023dc8d9004a27c2f06ee875b0ff3743ccdd","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-07-11T07:54:25Z","pushed_at":"2015-07-11T14:02:56Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1503325,"stargazers_count":4713,"watchers_count":4713,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4186,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":339,"forks":4186,"open_issues":339,"watchers":4713,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/7352"},"html":{"href":"https://github.com/apache/spark/pull/7352"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/7352"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/7352/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/7352/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/7352/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/efc4f24df54e280bc7e93de1932b0d1a5e7aded6"}}}}