{"action":"created","comment":{"url":"https://api.github.com/repos/davetayls/jquery.kinetic/pulls/comments/36584995","id":36584995,"diff_hunk":"@@ -226,6 +224,12 @@\n         if (self._useTarget(e.target, e) && self.elementFocused){\n           return false;\n         }\n+      },\n+      // prevent selection when dragging\n+      selectStart: function (e){\n+        if (self._useTarget(e.target, e)){","path":"jquery.kinetic.js","position":25,"original_position":25,"commit_id":"f0bc35605c6e1ce8a226a5c9bba3c4a2f7824a79","original_commit_id":"f0bc35605c6e1ce8a226a5c9bba3c4a2f7824a79","user":{"login":"davetayls","id":151695,"avatar_url":"https://avatars.githubusercontent.com/u/151695?v=3","gravatar_id":"","url":"https://api.github.com/users/davetayls","html_url":"https://github.com/davetayls","followers_url":"https://api.github.com/users/davetayls/followers","following_url":"https://api.github.com/users/davetayls/following{/other_user}","gists_url":"https://api.github.com/users/davetayls/gists{/gist_id}","starred_url":"https://api.github.com/users/davetayls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davetayls/subscriptions","organizations_url":"https://api.github.com/users/davetayls/orgs","repos_url":"https://api.github.com/users/davetayls/repos","events_url":"https://api.github.com/users/davetayls/events{/privacy}","received_events_url":"https://api.github.com/users/davetayls/received_events","type":"User","site_admin":false},"body":"It's fine moving the selectStart handler but it doesn't make sense to have this conditional. The point of this function is to stop text selection while dragging so even if it's ok to use the target for dragging the window it's probably not ok to start selecting or highlighting text","created_at":"2015-08-09T06:36:51Z","updated_at":"2015-08-09T06:36:51Z","html_url":"https://github.com/davetayls/jquery.kinetic/pull/88#discussion_r36584995","pull_request_url":"https://api.github.com/repos/davetayls/jquery.kinetic/pulls/88","_links":{"self":{"href":"https://api.github.com/repos/davetayls/jquery.kinetic/pulls/comments/36584995"},"html":{"href":"https://github.com/davetayls/jquery.kinetic/pull/88#discussion_r36584995"},"pull_request":{"href":"https://api.github.com/repos/davetayls/jquery.kinetic/pulls/88"}}},"pull_request":{"url":"https://api.github.com/repos/davetayls/jquery.kinetic/pulls/88","id":41951640,"html_url":"https://github.com/davetayls/jquery.kinetic/pull/88","diff_url":"https://github.com/davetayls/jquery.kinetic/pull/88.diff","patch_url":"https://github.com/davetayls/jquery.kinetic/pull/88.patch","issue_url":"https://api.github.com/repos/davetayls/jquery.kinetic/issues/88","number":88,"state":"open","locked":false,"title":"add invert option, and move selectStart","user":{"login":"tsaikd","id":2329535,"avatar_url":"https://avatars.githubusercontent.com/u/2329535?v=3","gravatar_id":"","url":"https://api.github.com/users/tsaikd","html_url":"https://github.com/tsaikd","followers_url":"https://api.github.com/users/tsaikd/followers","following_url":"https://api.github.com/users/tsaikd/following{/other_user}","gists_url":"https://api.github.com/users/tsaikd/gists{/gist_id}","starred_url":"https://api.github.com/users/tsaikd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsaikd/subscriptions","organizations_url":"https://api.github.com/users/tsaikd/orgs","repos_url":"https://api.github.com/users/tsaikd/repos","events_url":"https://api.github.com/users/tsaikd/events{/privacy}","received_events_url":"https://api.github.com/users/tsaikd/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-08-08T09:43:45Z","updated_at":"2015-08-09T06:36:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4fbd88b5c79dd20ea940e6a746b5795230f185e9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/davetayls/jquery.kinetic/pulls/88/commits","review_comments_url":"https://api.github.com/repos/davetayls/jquery.kinetic/pulls/88/comments","review_comment_url":"https://api.github.com/repos/davetayls/jquery.kinetic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/davetayls/jquery.kinetic/issues/88/comments","statuses_url":"https://api.github.com/repos/davetayls/jquery.kinetic/statuses/f0bc35605c6e1ce8a226a5c9bba3c4a2f7824a79","head":{"label":"tsaikd:master","ref":"master","sha":"f0bc35605c6e1ce8a226a5c9bba3c4a2f7824a79","user":{"login":"tsaikd","id":2329535,"avatar_url":"https://avatars.githubusercontent.com/u/2329535?v=3","gravatar_id":"","url":"https://api.github.com/users/tsaikd","html_url":"https://github.com/tsaikd","followers_url":"https://api.github.com/users/tsaikd/followers","following_url":"https://api.github.com/users/tsaikd/following{/other_user}","gists_url":"https://api.github.com/users/tsaikd/gists{/gist_id}","starred_url":"https://api.github.com/users/tsaikd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsaikd/subscriptions","organizations_url":"https://api.github.com/users/tsaikd/orgs","repos_url":"https://api.github.com/users/tsaikd/repos","events_url":"https://api.github.com/users/tsaikd/events{/privacy}","received_events_url":"https://api.github.com/users/tsaikd/received_events","type":"User","site_admin":false},"repo":{"id":40395759,"name":"jquery.kinetic","full_name":"tsaikd/jquery.kinetic","owner":{"login":"tsaikd","id":2329535,"avatar_url":"https://avatars.githubusercontent.com/u/2329535?v=3","gravatar_id":"","url":"https://api.github.com/users/tsaikd","html_url":"https://github.com/tsaikd","followers_url":"https://api.github.com/users/tsaikd/followers","following_url":"https://api.github.com/users/tsaikd/following{/other_user}","gists_url":"https://api.github.com/users/tsaikd/gists{/gist_id}","starred_url":"https://api.github.com/users/tsaikd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsaikd/subscriptions","organizations_url":"https://api.github.com/users/tsaikd/orgs","repos_url":"https://api.github.com/users/tsaikd/repos","events_url":"https://api.github.com/users/tsaikd/events{/privacy}","received_events_url":"https://api.github.com/users/tsaikd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tsaikd/jquery.kinetic","description":"Add kinetic scrolling functionality to a container using mouse or touch devices","fork":true,"url":"https://api.github.com/repos/tsaikd/jquery.kinetic","forks_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/forks","keys_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/teams","hooks_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/hooks","issue_events_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/issues/events{/number}","events_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/events","assignees_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/assignees{/user}","branches_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/branches{/branch}","tags_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/tags","blobs_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/git/refs{/sha}","trees_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/statuses/{sha}","languages_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/languages","stargazers_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/stargazers","contributors_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/contributors","subscribers_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/subscribers","subscription_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/subscription","commits_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/commits{/sha}","git_commits_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/git/commits{/sha}","comments_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/comments{/number}","issue_comment_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/issues/comments{/number}","contents_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/contents/{+path}","compare_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/merges","archive_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/downloads","issues_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/issues{/number}","pulls_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/pulls{/number}","milestones_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/milestones{/number}","notifications_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/labels{/name}","releases_url":"https://api.github.com/repos/tsaikd/jquery.kinetic/releases{/id}","created_at":"2015-08-08T07:51:21Z","updated_at":"2015-08-08T07:51:23Z","pushed_at":"2015-08-08T09:20:46Z","git_url":"git://github.com/tsaikd/jquery.kinetic.git","ssh_url":"git@github.com:tsaikd/jquery.kinetic.git","clone_url":"https://github.com/tsaikd/jquery.kinetic.git","svn_url":"https://github.com/tsaikd/jquery.kinetic","homepage":"http://davetayls.me/jquery.kinetic","size":1864,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"davetayls:master","ref":"master","sha":"a01bc474dffeee4624653e7c89fe8cd0906498d4","user":{"login":"davetayls","id":151695,"avatar_url":"https://avatars.githubusercontent.com/u/151695?v=3","gravatar_id":"","url":"https://api.github.com/users/davetayls","html_url":"https://github.com/davetayls","followers_url":"https://api.github.com/users/davetayls/followers","following_url":"https://api.github.com/users/davetayls/following{/other_user}","gists_url":"https://api.github.com/users/davetayls/gists{/gist_id}","starred_url":"https://api.github.com/users/davetayls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davetayls/subscriptions","organizations_url":"https://api.github.com/users/davetayls/orgs","repos_url":"https://api.github.com/users/davetayls/repos","events_url":"https://api.github.com/users/davetayls/events{/privacy}","received_events_url":"https://api.github.com/users/davetayls/received_events","type":"User","site_admin":false},"repo":{"id":1873328,"name":"jquery.kinetic","full_name":"davetayls/jquery.kinetic","owner":{"login":"davetayls","id":151695,"avatar_url":"https://avatars.githubusercontent.com/u/151695?v=3","gravatar_id":"","url":"https://api.github.com/users/davetayls","html_url":"https://github.com/davetayls","followers_url":"https://api.github.com/users/davetayls/followers","following_url":"https://api.github.com/users/davetayls/following{/other_user}","gists_url":"https://api.github.com/users/davetayls/gists{/gist_id}","starred_url":"https://api.github.com/users/davetayls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davetayls/subscriptions","organizations_url":"https://api.github.com/users/davetayls/orgs","repos_url":"https://api.github.com/users/davetayls/repos","events_url":"https://api.github.com/users/davetayls/events{/privacy}","received_events_url":"https://api.github.com/users/davetayls/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davetayls/jquery.kinetic","description":"Add kinetic scrolling functionality to a container using mouse or touch devices","fork":false,"url":"https://api.github.com/repos/davetayls/jquery.kinetic","forks_url":"https://api.github.com/repos/davetayls/jquery.kinetic/forks","keys_url":"https://api.github.com/repos/davetayls/jquery.kinetic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davetayls/jquery.kinetic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davetayls/jquery.kinetic/teams","hooks_url":"https://api.github.com/repos/davetayls/jquery.kinetic/hooks","issue_events_url":"https://api.github.com/repos/davetayls/jquery.kinetic/issues/events{/number}","events_url":"https://api.github.com/repos/davetayls/jquery.kinetic/events","assignees_url":"https://api.github.com/repos/davetayls/jquery.kinetic/assignees{/user}","branches_url":"https://api.github.com/repos/davetayls/jquery.kinetic/branches{/branch}","tags_url":"https://api.github.com/repos/davetayls/jquery.kinetic/tags","blobs_url":"https://api.github.com/repos/davetayls/jquery.kinetic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davetayls/jquery.kinetic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davetayls/jquery.kinetic/git/refs{/sha}","trees_url":"https://api.github.com/repos/davetayls/jquery.kinetic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davetayls/jquery.kinetic/statuses/{sha}","languages_url":"https://api.github.com/repos/davetayls/jquery.kinetic/languages","stargazers_url":"https://api.github.com/repos/davetayls/jquery.kinetic/stargazers","contributors_url":"https://api.github.com/repos/davetayls/jquery.kinetic/contributors","subscribers_url":"https://api.github.com/repos/davetayls/jquery.kinetic/subscribers","subscription_url":"https://api.github.com/repos/davetayls/jquery.kinetic/subscription","commits_url":"https://api.github.com/repos/davetayls/jquery.kinetic/commits{/sha}","git_commits_url":"https://api.github.com/repos/davetayls/jquery.kinetic/git/commits{/sha}","comments_url":"https://api.github.com/repos/davetayls/jquery.kinetic/comments{/number}","issue_comment_url":"https://api.github.com/repos/davetayls/jquery.kinetic/issues/comments{/number}","contents_url":"https://api.github.com/repos/davetayls/jquery.kinetic/contents/{+path}","compare_url":"https://api.github.com/repos/davetayls/jquery.kinetic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davetayls/jquery.kinetic/merges","archive_url":"https://api.github.com/repos/davetayls/jquery.kinetic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davetayls/jquery.kinetic/downloads","issues_url":"https://api.github.com/repos/davetayls/jquery.kinetic/issues{/number}","pulls_url":"https://api.github.com/repos/davetayls/jquery.kinetic/pulls{/number}","milestones_url":"https://api.github.com/repos/davetayls/jquery.kinetic/milestones{/number}","notifications_url":"https://api.github.com/repos/davetayls/jquery.kinetic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davetayls/jquery.kinetic/labels{/name}","releases_url":"https://api.github.com/repos/davetayls/jquery.kinetic/releases{/id}","created_at":"2011-06-09T22:19:16Z","updated_at":"2015-08-06T10:41:48Z","pushed_at":"2015-08-08T09:43:45Z","git_url":"git://github.com/davetayls/jquery.kinetic.git","ssh_url":"git@github.com:davetayls/jquery.kinetic.git","clone_url":"https://github.com/davetayls/jquery.kinetic.git","svn_url":"https://github.com/davetayls/jquery.kinetic","homepage":"http://davetayls.me/jquery.kinetic","size":2177,"stargazers_count":353,"watchers_count":353,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":76,"mirror_url":null,"open_issues_count":14,"forks":76,"open_issues":14,"watchers":353,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/davetayls/jquery.kinetic/pulls/88"},"html":{"href":"https://github.com/davetayls/jquery.kinetic/pull/88"},"issue":{"href":"https://api.github.com/repos/davetayls/jquery.kinetic/issues/88"},"comments":{"href":"https://api.github.com/repos/davetayls/jquery.kinetic/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/davetayls/jquery.kinetic/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/davetayls/jquery.kinetic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/davetayls/jquery.kinetic/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/davetayls/jquery.kinetic/statuses/f0bc35605c6e1ce8a226a5c9bba3c4a2f7824a79"}}}}