{"action":"created","comment":{"url":"https://api.github.com/repos/CanalTP/navitia/pulls/comments/30118652","id":30118652,"diff_hunk":"@@ -614,12 +614,14 @@ struct Line : public Header, Nameable, HasMessages, Codes{\n     MultiLineString shape;\n     boost::optional<boost::posix_time::time_duration> opening_time, closing_time;\n \n+    std::map<std::string,std::string> properties;","path":"source/type/type.h","position":4,"original_position":4,"commit_id":"f20c7e2d8c91ce74e89176f65664baa84c9290ec","original_commit_id":"f20c7e2d8c91ce74e89176f65664baa84c9290ec","user":{"login":"antoine-de","id":3987698,"avatar_url":"https://avatars.githubusercontent.com/u/3987698?v=3","gravatar_id":"","url":"https://api.github.com/users/antoine-de","html_url":"https://github.com/antoine-de","followers_url":"https://api.github.com/users/antoine-de/followers","following_url":"https://api.github.com/users/antoine-de/following{/other_user}","gists_url":"https://api.github.com/users/antoine-de/gists{/gist_id}","starred_url":"https://api.github.com/users/antoine-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoine-de/subscriptions","organizations_url":"https://api.github.com/users/antoine-de/orgs","repos_url":"https://api.github.com/users/antoine-de/repos","events_url":"https://api.github.com/users/antoine-de/events{/privacy}","received_events_url":"https://api.github.com/users/antoine-de/received_events","type":"User","site_admin":false},"body":"No I agree with you, since it is needed only for lines for the moment, it's ok to implement it only for that.","created_at":"2015-05-12T09:44:36Z","updated_at":"2015-05-12T09:44:36Z","html_url":"https://github.com/CanalTP/navitia/pull/1032#discussion_r30118652","pull_request_url":"https://api.github.com/repos/CanalTP/navitia/pulls/1032","_links":{"self":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/comments/30118652"},"html":{"href":"https://github.com/CanalTP/navitia/pull/1032#discussion_r30118652"},"pull_request":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/1032"}}},"pull_request":{"url":"https://api.github.com/repos/CanalTP/navitia/pulls/1032","id":34920381,"html_url":"https://github.com/CanalTP/navitia/pull/1032","diff_url":"https://github.com/CanalTP/navitia/pull/1032.diff","patch_url":"https://github.com/CanalTP/navitia/pull/1032.patch","issue_url":"https://api.github.com/repos/CanalTP/navitia/issues/1032","number":1032,"state":"open","locked":false,"title":"Read NTFS file object_properties.txt and output it on lines API request","user":{"login":"xavierraffin","id":1170030,"avatar_url":"https://avatars.githubusercontent.com/u/1170030?v=3","gravatar_id":"","url":"https://api.github.com/users/xavierraffin","html_url":"https://github.com/xavierraffin","followers_url":"https://api.github.com/users/xavierraffin/followers","following_url":"https://api.github.com/users/xavierraffin/following{/other_user}","gists_url":"https://api.github.com/users/xavierraffin/gists{/gist_id}","starred_url":"https://api.github.com/users/xavierraffin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavierraffin/subscriptions","organizations_url":"https://api.github.com/users/xavierraffin/orgs","repos_url":"https://api.github.com/users/xavierraffin/repos","events_url":"https://api.github.com/users/xavierraffin/events{/privacy}","received_events_url":"https://api.github.com/users/xavierraffin/received_events","type":"User","site_admin":false},"body":"In the v0.4 NTFS spec version there is a new file : \"object_properties.txt\"\r\n\r\nThis file contain key / value fields applicable on \"line, route, trip, stop_area, stop_point\"\r\n\r\nSo my commit contains :\r\n- alembic version to add a object_properties table on ed\r\n- fusio2ed cleanup and fill object_properties table from file (and can output some warn)\r\n- object nt::Line get a new field \"properties\" (accordingly to email exchange with Stephan Simart) in order to store all properties applicable for a line\r\n- so ed2nav store it on the lz4\r\n- update types.proto to add properties \"repeated\" field\r\n- update kraken and jormungandr to display properties on lines request\r\n\r\nExample:\r\nIf object_properties.txt is : \r\n\r\n    object_type,object_id,object_property_name,object_property_value\r\n    line,01,Schematic_url,http://tisseo.fr/01/schematic.png\r\n\r\nThen the request /v1/coverage/tisseo/lines/01 will show : \r\n\r\n```\r\n\"lines\": [{\r\n\"comment\": \"offre initiale\",\r\n\"code\": \"1\",\r\n\"name\": \"Aéroconstellation / Palais de Justice\",\r\n\"links\": [ ],\r\n\"color\": \"0040c4\", \"properties\": {“Schematic_url”:”http://tisseo.fr/01/schematic.png”},\r\n\"geojson\":\r\n{\"type\": \"MultiLineString\",\r\n…\r\n```\r\nFor the moment we only need this feature on Lines so I don't code the feature for route, trip, stop_area, and stop_point.\r\nBut feel free to do it :-)\r\n\r\nHope my code is OK for you","created_at":"2015-05-07T14:22:58Z","updated_at":"2015-05-12T09:44:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08f4dfc134716328d18e31b9adcfe55b9c2a90d3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CanalTP/navitia/pulls/1032/commits","review_comments_url":"https://api.github.com/repos/CanalTP/navitia/pulls/1032/comments","review_comment_url":"https://api.github.com/repos/CanalTP/navitia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CanalTP/navitia/issues/1032/comments","statuses_url":"https://api.github.com/repos/CanalTP/navitia/statuses/f20c7e2d8c91ce74e89176f65664baa84c9290ec","head":{"label":"Tisseo:pullrequest_object_properties3","ref":"pullrequest_object_properties3","sha":"f20c7e2d8c91ce74e89176f65664baa84c9290ec","user":{"login":"Tisseo","id":5136514,"avatar_url":"https://avatars.githubusercontent.com/u/5136514?v=3","gravatar_id":"","url":"https://api.github.com/users/Tisseo","html_url":"https://github.com/Tisseo","followers_url":"https://api.github.com/users/Tisseo/followers","following_url":"https://api.github.com/users/Tisseo/following{/other_user}","gists_url":"https://api.github.com/users/Tisseo/gists{/gist_id}","starred_url":"https://api.github.com/users/Tisseo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tisseo/subscriptions","organizations_url":"https://api.github.com/users/Tisseo/orgs","repos_url":"https://api.github.com/users/Tisseo/repos","events_url":"https://api.github.com/users/Tisseo/events{/privacy}","received_events_url":"https://api.github.com/users/Tisseo/received_events","type":"Organization","site_admin":false},"repo":{"id":26804325,"name":"navitia","full_name":"Tisseo/navitia","owner":{"login":"Tisseo","id":5136514,"avatar_url":"https://avatars.githubusercontent.com/u/5136514?v=3","gravatar_id":"","url":"https://api.github.com/users/Tisseo","html_url":"https://github.com/Tisseo","followers_url":"https://api.github.com/users/Tisseo/followers","following_url":"https://api.github.com/users/Tisseo/following{/other_user}","gists_url":"https://api.github.com/users/Tisseo/gists{/gist_id}","starred_url":"https://api.github.com/users/Tisseo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tisseo/subscriptions","organizations_url":"https://api.github.com/users/Tisseo/orgs","repos_url":"https://api.github.com/users/Tisseo/repos","events_url":"https://api.github.com/users/Tisseo/events{/privacy}","received_events_url":"https://api.github.com/users/Tisseo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Tisseo/navitia","description":"The REST API to build cool stuff with public transport","fork":true,"url":"https://api.github.com/repos/Tisseo/navitia","forks_url":"https://api.github.com/repos/Tisseo/navitia/forks","keys_url":"https://api.github.com/repos/Tisseo/navitia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tisseo/navitia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tisseo/navitia/teams","hooks_url":"https://api.github.com/repos/Tisseo/navitia/hooks","issue_events_url":"https://api.github.com/repos/Tisseo/navitia/issues/events{/number}","events_url":"https://api.github.com/repos/Tisseo/navitia/events","assignees_url":"https://api.github.com/repos/Tisseo/navitia/assignees{/user}","branches_url":"https://api.github.com/repos/Tisseo/navitia/branches{/branch}","tags_url":"https://api.github.com/repos/Tisseo/navitia/tags","blobs_url":"https://api.github.com/repos/Tisseo/navitia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tisseo/navitia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tisseo/navitia/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tisseo/navitia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tisseo/navitia/statuses/{sha}","languages_url":"https://api.github.com/repos/Tisseo/navitia/languages","stargazers_url":"https://api.github.com/repos/Tisseo/navitia/stargazers","contributors_url":"https://api.github.com/repos/Tisseo/navitia/contributors","subscribers_url":"https://api.github.com/repos/Tisseo/navitia/subscribers","subscription_url":"https://api.github.com/repos/Tisseo/navitia/subscription","commits_url":"https://api.github.com/repos/Tisseo/navitia/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tisseo/navitia/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tisseo/navitia/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tisseo/navitia/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tisseo/navitia/contents/{+path}","compare_url":"https://api.github.com/repos/Tisseo/navitia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tisseo/navitia/merges","archive_url":"https://api.github.com/repos/Tisseo/navitia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tisseo/navitia/downloads","issues_url":"https://api.github.com/repos/Tisseo/navitia/issues{/number}","pulls_url":"https://api.github.com/repos/Tisseo/navitia/pulls{/number}","milestones_url":"https://api.github.com/repos/Tisseo/navitia/milestones{/number}","notifications_url":"https://api.github.com/repos/Tisseo/navitia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tisseo/navitia/labels{/name}","releases_url":"https://api.github.com/repos/Tisseo/navitia/releases{/id}","created_at":"2014-11-18T10:37:15Z","updated_at":"2015-03-06T12:25:08Z","pushed_at":"2015-05-12T08:37:45Z","git_url":"git://github.com/Tisseo/navitia.git","ssh_url":"git@github.com:Tisseo/navitia.git","clone_url":"https://github.com/Tisseo/navitia.git","svn_url":"https://github.com/Tisseo/navitia","homepage":"http://www.navitia.io","size":24084,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"CanalTP:dev","ref":"dev","sha":"d366d2ac026b5cd90e5b16f2d750eebb974d6194","user":{"login":"CanalTP","id":2743985,"avatar_url":"https://avatars.githubusercontent.com/u/2743985?v=3","gravatar_id":"","url":"https://api.github.com/users/CanalTP","html_url":"https://github.com/CanalTP","followers_url":"https://api.github.com/users/CanalTP/followers","following_url":"https://api.github.com/users/CanalTP/following{/other_user}","gists_url":"https://api.github.com/users/CanalTP/gists{/gist_id}","starred_url":"https://api.github.com/users/CanalTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanalTP/subscriptions","organizations_url":"https://api.github.com/users/CanalTP/orgs","repos_url":"https://api.github.com/users/CanalTP/repos","events_url":"https://api.github.com/users/CanalTP/events{/privacy}","received_events_url":"https://api.github.com/users/CanalTP/received_events","type":"Organization","site_admin":false},"repo":{"id":10797333,"name":"navitia","full_name":"CanalTP/navitia","owner":{"login":"CanalTP","id":2743985,"avatar_url":"https://avatars.githubusercontent.com/u/2743985?v=3","gravatar_id":"","url":"https://api.github.com/users/CanalTP","html_url":"https://github.com/CanalTP","followers_url":"https://api.github.com/users/CanalTP/followers","following_url":"https://api.github.com/users/CanalTP/following{/other_user}","gists_url":"https://api.github.com/users/CanalTP/gists{/gist_id}","starred_url":"https://api.github.com/users/CanalTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanalTP/subscriptions","organizations_url":"https://api.github.com/users/CanalTP/orgs","repos_url":"https://api.github.com/users/CanalTP/repos","events_url":"https://api.github.com/users/CanalTP/events{/privacy}","received_events_url":"https://api.github.com/users/CanalTP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CanalTP/navitia","description":"The REST API to build cool stuff with public transport","fork":false,"url":"https://api.github.com/repos/CanalTP/navitia","forks_url":"https://api.github.com/repos/CanalTP/navitia/forks","keys_url":"https://api.github.com/repos/CanalTP/navitia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CanalTP/navitia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CanalTP/navitia/teams","hooks_url":"https://api.github.com/repos/CanalTP/navitia/hooks","issue_events_url":"https://api.github.com/repos/CanalTP/navitia/issues/events{/number}","events_url":"https://api.github.com/repos/CanalTP/navitia/events","assignees_url":"https://api.github.com/repos/CanalTP/navitia/assignees{/user}","branches_url":"https://api.github.com/repos/CanalTP/navitia/branches{/branch}","tags_url":"https://api.github.com/repos/CanalTP/navitia/tags","blobs_url":"https://api.github.com/repos/CanalTP/navitia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CanalTP/navitia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CanalTP/navitia/git/refs{/sha}","trees_url":"https://api.github.com/repos/CanalTP/navitia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CanalTP/navitia/statuses/{sha}","languages_url":"https://api.github.com/repos/CanalTP/navitia/languages","stargazers_url":"https://api.github.com/repos/CanalTP/navitia/stargazers","contributors_url":"https://api.github.com/repos/CanalTP/navitia/contributors","subscribers_url":"https://api.github.com/repos/CanalTP/navitia/subscribers","subscription_url":"https://api.github.com/repos/CanalTP/navitia/subscription","commits_url":"https://api.github.com/repos/CanalTP/navitia/commits{/sha}","git_commits_url":"https://api.github.com/repos/CanalTP/navitia/git/commits{/sha}","comments_url":"https://api.github.com/repos/CanalTP/navitia/comments{/number}","issue_comment_url":"https://api.github.com/repos/CanalTP/navitia/issues/comments{/number}","contents_url":"https://api.github.com/repos/CanalTP/navitia/contents/{+path}","compare_url":"https://api.github.com/repos/CanalTP/navitia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CanalTP/navitia/merges","archive_url":"https://api.github.com/repos/CanalTP/navitia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CanalTP/navitia/downloads","issues_url":"https://api.github.com/repos/CanalTP/navitia/issues{/number}","pulls_url":"https://api.github.com/repos/CanalTP/navitia/pulls{/number}","milestones_url":"https://api.github.com/repos/CanalTP/navitia/milestones{/number}","notifications_url":"https://api.github.com/repos/CanalTP/navitia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CanalTP/navitia/labels{/name}","releases_url":"https://api.github.com/repos/CanalTP/navitia/releases{/id}","created_at":"2013-06-19T15:34:30Z","updated_at":"2015-05-11T11:56:32Z","pushed_at":"2015-05-12T09:33:32Z","git_url":"git://github.com/CanalTP/navitia.git","ssh_url":"git@github.com:CanalTP/navitia.git","clone_url":"https://github.com/CanalTP/navitia.git","svn_url":"https://github.com/CanalTP/navitia","homepage":"http://www.navitia.io","size":34422,"stargazers_count":97,"watchers_count":97,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":16,"forks":28,"open_issues":16,"watchers":97,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/1032"},"html":{"href":"https://github.com/CanalTP/navitia/pull/1032"},"issue":{"href":"https://api.github.com/repos/CanalTP/navitia/issues/1032"},"comments":{"href":"https://api.github.com/repos/CanalTP/navitia/issues/1032/comments"},"review_comments":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/1032/comments"},"review_comment":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/1032/commits"},"statuses":{"href":"https://api.github.com/repos/CanalTP/navitia/statuses/f20c7e2d8c91ce74e89176f65664baa84c9290ec"}}}}