{"action":"created","comment":{"url":"https://api.github.com/repos/Metaswitch/homestead/pulls/comments/24072596","id":24072596,"diff_hunk":"@@ -107,5 +107,5 @@ Response:\n \n `{ \"result-code\": \"2001\", \"mandatory-capabilties\": [], \"optional-capabilities\": [] }`\n \n-* 404 if the user cannot be found.\n+* 404 if the user cannot be found (either a 5001 error from the HSS, or having no HSS configured and no record of the user).","path":"docs/homestead_api.md","position":23,"original_position":23,"commit_id":"0c9d2df1996237ea61ee8419d320ffc9c2b6a151","original_commit_id":"0c9d2df1996237ea61ee8419d320ffc9c2b6a151","user":{"login":"graemerobertson","id":5907876,"avatar_url":"https://avatars.githubusercontent.com/u/5907876?v=3","gravatar_id":"","url":"https://api.github.com/users/graemerobertson","html_url":"https://github.com/graemerobertson","followers_url":"https://api.github.com/users/graemerobertson/followers","following_url":"https://api.github.com/users/graemerobertson/following{/other_user}","gists_url":"https://api.github.com/users/graemerobertson/gists{/gist_id}","starred_url":"https://api.github.com/users/graemerobertson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graemerobertson/subscriptions","organizations_url":"https://api.github.com/users/graemerobertson/orgs","repos_url":"https://api.github.com/users/graemerobertson/repos","events_url":"https://api.github.com/users/graemerobertson/events{/privacy}","received_events_url":"https://api.github.com/users/graemerobertson/received_events","type":"User","site_admin":false},"body":"Capabilities is missing an i, not a t, right? Anyway, literally the hardest word to spell whilst typing.","created_at":"2015-02-04T09:55:27Z","updated_at":"2015-02-04T09:55:27Z","html_url":"https://github.com/Metaswitch/homestead/pull/179#discussion_r24072596","pull_request_url":"https://api.github.com/repos/Metaswitch/homestead/pulls/179","_links":{"self":{"href":"https://api.github.com/repos/Metaswitch/homestead/pulls/comments/24072596"},"html":{"href":"https://github.com/Metaswitch/homestead/pull/179#discussion_r24072596"},"pull_request":{"href":"https://api.github.com/repos/Metaswitch/homestead/pulls/179"}}},"pull_request":{"url":"https://api.github.com/repos/Metaswitch/homestead/pulls/179","id":28571697,"html_url":"https://github.com/Metaswitch/homestead/pull/179","diff_url":"https://github.com/Metaswitch/homestead/pull/179.diff","patch_url":"https://github.com/Metaswitch/homestead/pull/179.patch","issue_url":"https://api.github.com/repos/Metaswitch/homestead/issues/179","number":179,"state":"open","locked":false,"title":"[Reviewer: Ellie] If no HSS, /location should only return 200 OK if subscriber actually exists","user":{"login":"mirw","id":2963879,"avatar_url":"https://avatars.githubusercontent.com/u/2963879?v=3","gravatar_id":"","url":"https://api.github.com/users/mirw","html_url":"https://github.com/mirw","followers_url":"https://api.github.com/users/mirw/followers","following_url":"https://api.github.com/users/mirw/following{/other_user}","gists_url":"https://api.github.com/users/mirw/gists{/gist_id}","starred_url":"https://api.github.com/users/mirw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirw/subscriptions","organizations_url":"https://api.github.com/users/mirw/orgs","repos_url":"https://api.github.com/users/mirw/repos","events_url":"https://api.github.com/users/mirw/events{/privacy}","received_events_url":"https://api.github.com/users/mirw/received_events","type":"User","site_admin":false},"body":"Ellie,\r\n\r\nPlease can you review my change which fixes #178?  This is a prerequisite for fixing https://github.com/Metaswitch/sprout/issues/927 and together they fix tandem function.\r\n\r\nI've live-tested, and UT-ed this.  (I've not yet UT-ed the fix to https://github.com/Metaswitch/sprout/issues/927 but I will do shortly.)\r\n\r\nAs you'll have seen, I've updated docs.\r\n\r\nMatt","created_at":"2015-02-03T17:30:21Z","updated_at":"2015-02-04T09:55:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"184de22b9acb350c7bddcc5fecaa4563e85dcef9","assignee":{"login":"mirw","id":2963879,"avatar_url":"https://avatars.githubusercontent.com/u/2963879?v=3","gravatar_id":"","url":"https://api.github.com/users/mirw","html_url":"https://github.com/mirw","followers_url":"https://api.github.com/users/mirw/followers","following_url":"https://api.github.com/users/mirw/following{/other_user}","gists_url":"https://api.github.com/users/mirw/gists{/gist_id}","starred_url":"https://api.github.com/users/mirw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirw/subscriptions","organizations_url":"https://api.github.com/users/mirw/orgs","repos_url":"https://api.github.com/users/mirw/repos","events_url":"https://api.github.com/users/mirw/events{/privacy}","received_events_url":"https://api.github.com/users/mirw/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Metaswitch/homestead/pulls/179/commits","review_comments_url":"https://api.github.com/repos/Metaswitch/homestead/pulls/179/comments","review_comment_url":"https://api.github.com/repos/Metaswitch/homestead/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Metaswitch/homestead/issues/179/comments","statuses_url":"https://api.github.com/repos/Metaswitch/homestead/statuses/0c9d2df1996237ea61ee8419d320ffc9c2b6a151","head":{"label":"Metaswitch:iss178","ref":"iss178","sha":"0c9d2df1996237ea61ee8419d320ffc9c2b6a151","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":15995923,"name":"homestead","full_name":"Metaswitch/homestead","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/homestead","description":" Clearwater Homestead HSS Cache/Gateway","fork":false,"url":"https://api.github.com/repos/Metaswitch/homestead","forks_url":"https://api.github.com/repos/Metaswitch/homestead/forks","keys_url":"https://api.github.com/repos/Metaswitch/homestead/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/homestead/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/homestead/teams","hooks_url":"https://api.github.com/repos/Metaswitch/homestead/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/homestead/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/homestead/events","assignees_url":"https://api.github.com/repos/Metaswitch/homestead/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/homestead/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/homestead/tags","blobs_url":"https://api.github.com/repos/Metaswitch/homestead/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/homestead/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/homestead/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/homestead/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/homestead/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/homestead/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/homestead/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/homestead/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/homestead/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/homestead/subscription","commits_url":"https://api.github.com/repos/Metaswitch/homestead/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/homestead/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/homestead/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/homestead/issues/comments/{number}","contents_url":"https://api.github.com/repos/Metaswitch/homestead/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/homestead/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/homestead/merges","archive_url":"https://api.github.com/repos/Metaswitch/homestead/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/homestead/downloads","issues_url":"https://api.github.com/repos/Metaswitch/homestead/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/homestead/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/homestead/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/homestead/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/homestead/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/homestead/releases{/id}","created_at":"2014-01-17T09:50:45Z","updated_at":"2015-01-29T17:10:30Z","pushed_at":"2015-02-03T17:28:25Z","git_url":"git://github.com/Metaswitch/homestead.git","ssh_url":"git@github.com:Metaswitch/homestead.git","clone_url":"https://github.com/Metaswitch/homestead.git","svn_url":"https://github.com/Metaswitch/homestead","homepage":null,"size":6162,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":16,"forks":3,"open_issues":16,"watchers":1,"default_branch":"dev"}},"base":{"label":"Metaswitch:dev","ref":"dev","sha":"7629c65efe703524900a05b79377add07a011bc3","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":15995923,"name":"homestead","full_name":"Metaswitch/homestead","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/homestead","description":" Clearwater Homestead HSS Cache/Gateway","fork":false,"url":"https://api.github.com/repos/Metaswitch/homestead","forks_url":"https://api.github.com/repos/Metaswitch/homestead/forks","keys_url":"https://api.github.com/repos/Metaswitch/homestead/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/homestead/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/homestead/teams","hooks_url":"https://api.github.com/repos/Metaswitch/homestead/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/homestead/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/homestead/events","assignees_url":"https://api.github.com/repos/Metaswitch/homestead/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/homestead/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/homestead/tags","blobs_url":"https://api.github.com/repos/Metaswitch/homestead/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/homestead/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/homestead/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/homestead/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/homestead/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/homestead/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/homestead/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/homestead/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/homestead/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/homestead/subscription","commits_url":"https://api.github.com/repos/Metaswitch/homestead/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/homestead/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/homestead/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/homestead/issues/comments/{number}","contents_url":"https://api.github.com/repos/Metaswitch/homestead/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/homestead/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/homestead/merges","archive_url":"https://api.github.com/repos/Metaswitch/homestead/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/homestead/downloads","issues_url":"https://api.github.com/repos/Metaswitch/homestead/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/homestead/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/homestead/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/homestead/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/homestead/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/homestead/releases{/id}","created_at":"2014-01-17T09:50:45Z","updated_at":"2015-01-29T17:10:30Z","pushed_at":"2015-02-03T17:28:25Z","git_url":"git://github.com/Metaswitch/homestead.git","ssh_url":"git@github.com:Metaswitch/homestead.git","clone_url":"https://github.com/Metaswitch/homestead.git","svn_url":"https://github.com/Metaswitch/homestead","homepage":null,"size":6162,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":16,"forks":3,"open_issues":16,"watchers":1,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Metaswitch/homestead/pulls/179"},"html":{"href":"https://github.com/Metaswitch/homestead/pull/179"},"issue":{"href":"https://api.github.com/repos/Metaswitch/homestead/issues/179"},"comments":{"href":"https://api.github.com/repos/Metaswitch/homestead/issues/179/comments"},"review_comments":{"href":"https://api.github.com/repos/Metaswitch/homestead/pulls/179/comments"},"review_comment":{"href":"https://api.github.com/repos/Metaswitch/homestead/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Metaswitch/homestead/pulls/179/commits"},"statuses":{"href":"https://api.github.com/repos/Metaswitch/homestead/statuses/0c9d2df1996237ea61ee8419d320ffc9c2b6a151"}}}}