{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/38147736","id":38147736,"diff_hunk":"@@ -154,7 +156,18 @@ commit and re-push.  Your reviewer can then look at that commit on its own - so\n much faster to review than starting over.\n \n We might still ask you to clean up your commits at the very end, for the sake\n-of a more readable history.\n+of a more readable history, but don't do this until asked, typically at the point\n+where the PR would otherwise be tagged LGTM.\n+\n+General squashing guidelines:\n+\n+* Sausage => squash","path":"docs/devel/faster_reviews.md","position":27,"original_position":27,"commit_id":"419c6511d23138a52db42d46fd04e6247e5d36ec","original_commit_id":"419c6511d23138a52db42d46fd04e6247e5d36ec","user":{"login":"pmorie","id":366488,"avatar_url":"https://avatars.githubusercontent.com/u/366488?v=3","gravatar_id":"","url":"https://api.github.com/users/pmorie","html_url":"https://github.com/pmorie","followers_url":"https://api.github.com/users/pmorie/followers","following_url":"https://api.github.com/users/pmorie/following{/other_user}","gists_url":"https://api.github.com/users/pmorie/gists{/gist_id}","starred_url":"https://api.github.com/users/pmorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmorie/subscriptions","organizations_url":"https://api.github.com/users/pmorie/orgs","repos_url":"https://api.github.com/users/pmorie/repos","events_url":"https://api.github.com/users/pmorie/events{/privacy}","received_events_url":"https://api.github.com/users/pmorie/received_events","type":"User","site_admin":false},"body":"lol @ sausage","created_at":"2015-08-27T21:22:28Z","updated_at":"2015-08-27T21:22:28Z","html_url":"https://github.com/kubernetes/kubernetes/pull/13278#discussion_r38147736","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13278","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/38147736"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/13278#discussion_r38147736"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13278"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13278","id":43567857,"html_url":"https://github.com/kubernetes/kubernetes/pull/13278","diff_url":"https://github.com/kubernetes/kubernetes/pull/13278.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/13278.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13278","number":13278,"state":"open","locked":false,"title":"Start on expanding code expectations (aka \"The bar\")","user":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"body":"There's a lot more we should add. This is mainly intended as a way to ask for help, though I'll add more things as I think of them. Please add comments with suggestions.\r\n\r\n@lavalamp @thockin @smarterclayton @quinton-hoole @davidopp @pmorie ","created_at":"2015-08-27T21:15:55Z","updated_at":"2015-08-27T21:22:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50874a7745e2fafa31442f2344ed9dce54090b38","assignee":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13278/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13278/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13278/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/419c6511d23138a52db42d46fd04e6247e5d36ec","head":{"label":"bgrant0607:docfix2","ref":"docfix2","sha":"419c6511d23138a52db42d46fd04e6247e5d36ec","user":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"repo":{"id":23933470,"name":"kubernetes","full_name":"bgrant0607/kubernetes","owner":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bgrant0607/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/bgrant0607/kubernetes","forks_url":"https://api.github.com/repos/bgrant0607/kubernetes/forks","keys_url":"https://api.github.com/repos/bgrant0607/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bgrant0607/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bgrant0607/kubernetes/teams","hooks_url":"https://api.github.com/repos/bgrant0607/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/bgrant0607/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/bgrant0607/kubernetes/events","assignees_url":"https://api.github.com/repos/bgrant0607/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/bgrant0607/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/bgrant0607/kubernetes/tags","blobs_url":"https://api.github.com/repos/bgrant0607/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bgrant0607/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bgrant0607/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/bgrant0607/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bgrant0607/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/bgrant0607/kubernetes/languages","stargazers_url":"https://api.github.com/repos/bgrant0607/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/bgrant0607/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/bgrant0607/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/bgrant0607/kubernetes/subscription","commits_url":"https://api.github.com/repos/bgrant0607/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/bgrant0607/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/bgrant0607/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/bgrant0607/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/bgrant0607/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/bgrant0607/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bgrant0607/kubernetes/merges","archive_url":"https://api.github.com/repos/bgrant0607/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bgrant0607/kubernetes/downloads","issues_url":"https://api.github.com/repos/bgrant0607/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/bgrant0607/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/bgrant0607/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/bgrant0607/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bgrant0607/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/bgrant0607/kubernetes/releases{/id}","created_at":"2014-09-11T19:55:59Z","updated_at":"2015-01-20T22:09:04Z","pushed_at":"2015-08-27T21:13:05Z","git_url":"git://github.com/bgrant0607/kubernetes.git","ssh_url":"git@github.com:bgrant0607/kubernetes.git","clone_url":"https://github.com/bgrant0607/kubernetes.git","svn_url":"https://github.com/bgrant0607/kubernetes","homepage":null,"size":102873,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"986d37d145462a0e41a9d2afc1c169612b21d9ea","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-08-27T18:35:17Z","pushed_at":"2015-08-27T21:15:55Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":367380,"stargazers_count":9917,"watchers_count":9917,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2415,"mirror_url":null,"open_issues_count":1662,"forks":2415,"open_issues":1662,"watchers":9917,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13278"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/13278"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/13278"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/13278/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13278/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13278/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/419c6511d23138a52db42d46fd04e6247e5d36ec"}}}}