{"action":"created","comment":{"url":"https://api.github.com/repos/odoo/odoo/pulls/comments/46430187","id":46430187,"diff_hunk":"@@ -426,6 +426,11 @@ def write(self, cr, uid, ids, vals, context=None):\n         # remove computed field depending of datas\n         for field in ['file_size', 'checksum']:\n             vals.pop(field, False)\n+        if 'url' in vals and 'datas_fname' not in vals:\n+            vals['datas_fname'] = os.path.basename(vals['url']) or ''","path":"openerp/addons/base/ir/ir_attachment.py","position":5,"original_position":5,"commit_id":"2d4340299cfbc39e9b663cdd7472767e987ee386","original_commit_id":"2d4340299cfbc39e9b663cdd7472767e987ee386","user":{"login":"KangOl","id":38731,"avatar_url":"https://avatars.githubusercontent.com/u/38731?v=3","gravatar_id":"","url":"https://api.github.com/users/KangOl","html_url":"https://github.com/KangOl","followers_url":"https://api.github.com/users/KangOl/followers","following_url":"https://api.github.com/users/KangOl/following{/other_user}","gists_url":"https://api.github.com/users/KangOl/gists{/gist_id}","starred_url":"https://api.github.com/users/KangOl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KangOl/subscriptions","organizations_url":"https://api.github.com/users/KangOl/orgs","repos_url":"https://api.github.com/users/KangOl/repos","events_url":"https://api.github.com/users/KangOl/events{/privacy}","received_events_url":"https://api.github.com/users/KangOl/received_events","type":"User","site_admin":false},"body":"wrong","created_at":"2015-12-02T15:45:35Z","updated_at":"2015-12-02T15:45:35Z","html_url":"https://github.com/odoo/odoo/pull/9817#discussion_r46430187","pull_request_url":"https://api.github.com/repos/odoo/odoo/pulls/9817","_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments/46430187"},"html":{"href":"https://github.com/odoo/odoo/pull/9817#discussion_r46430187"},"pull_request":{"href":"https://api.github.com/repos/odoo/odoo/pulls/9817"}}},"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/9817","id":52130310,"html_url":"https://github.com/odoo/odoo/pull/9817","diff_url":"https://github.com/odoo/odoo/pull/9817.diff","patch_url":"https://github.com/odoo/odoo/pull/9817.patch","issue_url":"https://api.github.com/repos/odoo/odoo/issues/9817","number":9817,"state":"open","locked":false,"title":"9.0 binary content url chm","user":{"login":"Gorash","id":2284563,"avatar_url":"https://avatars.githubusercontent.com/u/2284563?v=3","gravatar_id":"","url":"https://api.github.com/users/Gorash","html_url":"https://github.com/Gorash","followers_url":"https://api.github.com/users/Gorash/followers","following_url":"https://api.github.com/users/Gorash/following{/other_user}","gists_url":"https://api.github.com/users/Gorash/gists{/gist_id}","starred_url":"https://api.github.com/users/Gorash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gorash/subscriptions","organizations_url":"https://api.github.com/users/Gorash/orgs","repos_url":"https://api.github.com/users/Gorash/repos","events_url":"https://api.github.com/users/Gorash/events{/privacy}","received_events_url":"https://api.github.com/users/Gorash/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-11-30T14:29:50Z","updated_at":"2015-12-02T15:45:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61c3abcded6b868fad27be88fba0010b84c3e528","assignee":{"login":"KangOl","id":38731,"avatar_url":"https://avatars.githubusercontent.com/u/38731?v=3","gravatar_id":"","url":"https://api.github.com/users/KangOl","html_url":"https://github.com/KangOl","followers_url":"https://api.github.com/users/KangOl/followers","following_url":"https://api.github.com/users/KangOl/following{/other_user}","gists_url":"https://api.github.com/users/KangOl/gists{/gist_id}","starred_url":"https://api.github.com/users/KangOl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KangOl/subscriptions","organizations_url":"https://api.github.com/users/KangOl/orgs","repos_url":"https://api.github.com/users/KangOl/repos","events_url":"https://api.github.com/users/KangOl/events{/privacy}","received_events_url":"https://api.github.com/users/KangOl/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/odoo/odoo/pulls/9817/commits","review_comments_url":"https://api.github.com/repos/odoo/odoo/pulls/9817/comments","review_comment_url":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/9817/comments","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/2d4340299cfbc39e9b663cdd7472767e987ee386","head":{"label":"odoo-dev:9.0-binary_content-url-chm","ref":"9.0-binary_content-url-chm","sha":"2d4340299cfbc39e9b663cdd7472767e987ee386","user":{"login":"odoo-dev","id":7466976,"avatar_url":"https://avatars.githubusercontent.com/u/7466976?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":19853934,"name":"odoo","full_name":"odoo-dev/odoo","owner":{"login":"odoo-dev","id":7466976,"avatar_url":"https://avatars.githubusercontent.com/u/7466976?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo-dev/odoo","description":"RD Dev Repository","fork":true,"url":"https://api.github.com/repos/odoo-dev/odoo","forks_url":"https://api.github.com/repos/odoo-dev/odoo/forks","keys_url":"https://api.github.com/repos/odoo-dev/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo-dev/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo-dev/odoo/teams","hooks_url":"https://api.github.com/repos/odoo-dev/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo-dev/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo-dev/odoo/events","assignees_url":"https://api.github.com/repos/odoo-dev/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo-dev/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo-dev/odoo/tags","blobs_url":"https://api.github.com/repos/odoo-dev/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo-dev/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo-dev/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo-dev/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo-dev/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo-dev/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo-dev/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo-dev/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo-dev/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo-dev/odoo/subscription","commits_url":"https://api.github.com/repos/odoo-dev/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo-dev/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo-dev/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo-dev/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo-dev/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo-dev/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo-dev/odoo/merges","archive_url":"https://api.github.com/repos/odoo-dev/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo-dev/odoo/downloads","issues_url":"https://api.github.com/repos/odoo-dev/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo-dev/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo-dev/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo-dev/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo-dev/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo-dev/odoo/releases{/id}","created_at":"2014-05-16T11:16:19Z","updated_at":"2015-12-01T14:48:24Z","pushed_at":"2015-12-02T15:42:24Z","git_url":"git://github.com/odoo-dev/odoo.git","ssh_url":"git@github.com:odoo-dev/odoo.git","clone_url":"https://github.com/odoo-dev/odoo.git","svn_url":"https://github.com/odoo-dev/odoo","homepage":"https://www.odoo.com","size":1140230,"stargazers_count":64,"watchers_count":64,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":0,"forks":27,"open_issues":0,"watchers":64,"default_branch":"master"}},"base":{"label":"odoo:9.0","ref":"9.0","sha":"7909a4409afb0b2dc4ac8b4db402f8e5dd5970c8","user":{"login":"odoo","id":6368483,"avatar_url":"https://avatars.githubusercontent.com/u/6368483?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"repo":{"id":19745004,"name":"odoo","full_name":"odoo/odoo","owner":{"login":"odoo","id":6368483,"avatar_url":"https://avatars.githubusercontent.com/u/6368483?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo/odoo","description":"Odoo (formerly OpenERP). Open Source Apps To Grow Your Business.","fork":false,"url":"https://api.github.com/repos/odoo/odoo","forks_url":"https://api.github.com/repos/odoo/odoo/forks","keys_url":"https://api.github.com/repos/odoo/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo/odoo/teams","hooks_url":"https://api.github.com/repos/odoo/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo/odoo/events","assignees_url":"https://api.github.com/repos/odoo/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo/odoo/tags","blobs_url":"https://api.github.com/repos/odoo/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo/odoo/subscription","commits_url":"https://api.github.com/repos/odoo/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo/odoo/merges","archive_url":"https://api.github.com/repos/odoo/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo/odoo/downloads","issues_url":"https://api.github.com/repos/odoo/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo/odoo/releases{/id}","created_at":"2014-05-13T15:38:58Z","updated_at":"2015-12-02T12:07:06Z","pushed_at":"2015-12-02T15:42:25Z","git_url":"git://github.com/odoo/odoo.git","ssh_url":"git@github.com:odoo/odoo.git","clone_url":"https://github.com/odoo/odoo.git","svn_url":"https://github.com/odoo/odoo","homepage":"https://www.odoo.com","size":1218152,"stargazers_count":3456,"watchers_count":3456,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3154,"mirror_url":null,"open_issues_count":2897,"forks":3154,"open_issues":2897,"watchers":3456,"default_branch":"9.0"}},"_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/9817"},"html":{"href":"https://github.com/odoo/odoo/pull/9817"},"issue":{"href":"https://api.github.com/repos/odoo/odoo/issues/9817"},"comments":{"href":"https://api.github.com/repos/odoo/odoo/issues/9817/comments"},"review_comments":{"href":"https://api.github.com/repos/odoo/odoo/pulls/9817/comments"},"review_comment":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/odoo/odoo/pulls/9817/commits"},"statuses":{"href":"https://api.github.com/repos/odoo/odoo/statuses/2d4340299cfbc39e9b663cdd7472767e987ee386"}}}}