{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/28138489","id":28138489,"diff_hunk":"@@ -2531,10 +2531,10 @@ var ThreadUI = {\n       // eg. type \"a\", then delete it.\n       // Always remove the the existing results.\n       this.toggleRecipientSuggestions();\n-      return;\n+      return Promise.resolve(null);","path":"apps/sms/js/thread_ui.js","position":197,"original_position":197,"commit_id":"2790a6e448ceacc0b775846548c9c11640b94005","original_commit_id":"2790a6e448ceacc0b775846548c9c11640b94005","user":{"login":"azasypkin","id":1713708,"avatar_url":"https://avatars.githubusercontent.com/u/1713708?v=3","gravatar_id":"","url":"https://api.github.com/users/azasypkin","html_url":"https://github.com/azasypkin","followers_url":"https://api.github.com/users/azasypkin/followers","following_url":"https://api.github.com/users/azasypkin/following{/other_user}","gists_url":"https://api.github.com/users/azasypkin/gists{/gist_id}","starred_url":"https://api.github.com/users/azasypkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azasypkin/subscriptions","organizations_url":"https://api.github.com/users/azasypkin/orgs","repos_url":"https://api.github.com/users/azasypkin/repos","events_url":"https://api.github.com/users/azasypkin/events{/privacy}","received_events_url":"https://api.github.com/users/azasypkin/received_events","type":"User","site_admin":false},"body":"Looks like here you actually changed program flow a bit for the case when everything was deleted from recipients input, earlier it was like this: ```toFieldInput -> searchContact -> toggleRecipientSuggestions```, now it's like this: ```toFieldInput -> searchContact -> toggleRecipientSuggestions -> listContacts```. Probably it doesn't have any consequences yet, but why don't you want use ```Promise.reject()``` here - sounds like a reasonable use case for reject here?","created_at":"2015-04-10T11:44:39Z","updated_at":"2015-04-10T11:44:39Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/29217#discussion_r28138489","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/29217","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/28138489"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/29217#discussion_r28138489"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/29217"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/29217","id":32205391,"html_url":"https://github.com/mozilla-b2g/gaia/pull/29217","diff_url":"https://github.com/mozilla-b2g/gaia/pull/29217.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/29217.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/29217","number":29217,"state":"open","locked":false,"title":"Bug 1142540 - move contacts.js to promises.","user":{"login":"julienw","id":454175,"avatar_url":"https://avatars.githubusercontent.com/u/454175?v=3","gravatar_id":"","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-03-30T08:10:34Z","updated_at":"2015-04-10T11:44:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"481732f3734b701ada3fe0cdc959647d92844c62","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/29217/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/29217/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/29217/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/2790a6e448ceacc0b775846548c9c11640b94005","head":{"label":"julienw:1142540-contact-promises","ref":"1142540-contact-promises","sha":"2790a6e448ceacc0b775846548c9c11640b94005","user":{"login":"julienw","id":454175,"avatar_url":"https://avatars.githubusercontent.com/u/454175?v=3","gravatar_id":"","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"repo":{"id":6565987,"name":"gaia","full_name":"julienw/gaia","owner":{"login":"julienw","id":454175,"avatar_url":"https://avatars.githubusercontent.com/u/454175?v=3","gravatar_id":"","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/julienw/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project","fork":true,"url":"https://api.github.com/repos/julienw/gaia","forks_url":"https://api.github.com/repos/julienw/gaia/forks","keys_url":"https://api.github.com/repos/julienw/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/julienw/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/julienw/gaia/teams","hooks_url":"https://api.github.com/repos/julienw/gaia/hooks","issue_events_url":"https://api.github.com/repos/julienw/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/julienw/gaia/events","assignees_url":"https://api.github.com/repos/julienw/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/julienw/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/julienw/gaia/tags","blobs_url":"https://api.github.com/repos/julienw/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/julienw/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/julienw/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/julienw/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/julienw/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/julienw/gaia/languages","stargazers_url":"https://api.github.com/repos/julienw/gaia/stargazers","contributors_url":"https://api.github.com/repos/julienw/gaia/contributors","subscribers_url":"https://api.github.com/repos/julienw/gaia/subscribers","subscription_url":"https://api.github.com/repos/julienw/gaia/subscription","commits_url":"https://api.github.com/repos/julienw/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/julienw/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/julienw/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/julienw/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/julienw/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/julienw/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/julienw/gaia/merges","archive_url":"https://api.github.com/repos/julienw/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/julienw/gaia/downloads","issues_url":"https://api.github.com/repos/julienw/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/julienw/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/julienw/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/julienw/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/julienw/gaia/labels{/name}","releases_url":"https://api.github.com/repos/julienw/gaia/releases{/id}","created_at":"2012-11-06T17:18:15Z","updated_at":"2014-06-25T07:25:16Z","pushed_at":"2015-04-10T06:34:54Z","git_url":"git://github.com/julienw/gaia.git","ssh_url":"git@github.com:julienw/gaia.git","clone_url":"https://github.com/julienw/gaia.git","svn_url":"https://github.com/julienw/gaia","homepage":"https://wiki.mozilla.org/B2G","size":912257,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"eaf69e651e19b98c096f8e63b9829fb31df50927","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2015-04-10T11:34:07Z","pushed_at":"2015-04-10T11:41:10Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1506631,"stargazers_count":1904,"watchers_count":1904,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2268,"mirror_url":null,"open_issues_count":952,"forks":2268,"open_issues":952,"watchers":1904,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/29217"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/29217"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/29217"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/29217/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/29217/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/29217/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/2790a6e448ceacc0b775846548c9c11640b94005"}}}}