{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/37925641","id":37925641,"diff_hunk":"@@ -240,15 +602,20 @@ func mergeSlice(original, patch []interface{}, elemType reflect.Type, mergeKey s\n \treturn original, nil\n }\n \n-// This panics if any element of the slice is not a map.\n+// This method no longer panics if any element of the slice is not a map.","path":"pkg/util/strategicpatch/patch.go","position":490,"original_position":490,"commit_id":"d9568b7bd5c5c3c2ab0d6616fff8767961ec8308","original_commit_id":"d9568b7bd5c5c3c2ab0d6616fff8767961ec8308","user":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"body":"I don't know what the impact of panics is.\r\n\r\nI agree that if we don't panic, this needs to return an error.","created_at":"2015-08-25T22:06:45Z","updated_at":"2015-08-25T22:06:45Z","html_url":"https://github.com/kubernetes/kubernetes/pull/13007#discussion_r37925641","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13007","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/37925641"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/13007#discussion_r37925641"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13007"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13007","id":42996501,"html_url":"https://github.com/kubernetes/kubernetes/pull/13007","diff_url":"https://github.com/kubernetes/kubernetes/pull/13007.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/13007.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13007","number":13007,"state":"open","locked":false,"title":"Add a method to generate a strategic merge patch","user":{"login":"jackgr","id":5607565,"avatar_url":"https://avatars.githubusercontent.com/u/5607565?v=3","gravatar_id":"","url":"https://api.github.com/users/jackgr","html_url":"https://github.com/jackgr","followers_url":"https://api.github.com/users/jackgr/followers","following_url":"https://api.github.com/users/jackgr/following{/other_user}","gists_url":"https://api.github.com/users/jackgr/gists{/gist_id}","starred_url":"https://api.github.com/users/jackgr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackgr/subscriptions","organizations_url":"https://api.github.com/users/jackgr/orgs","repos_url":"https://api.github.com/users/jackgr/repos","events_url":"https://api.github.com/users/jackgr/events{/privacy}","received_events_url":"https://api.github.com/users/jackgr/received_events","type":"User","site_admin":false},"body":"This is the first step in implementing #1702. It adds a method named CreateStrategicMergePatch to pkg/util/strategicmergepatch/patch.go that generates a strategic merge patch by taking the difference between before and after YAML or JSON strings. It will be used by apply (aka reconcile) to generate patches that can be used to update live configuration based on the difference between the current and previous configurations of a resource.\r\n\r\ncc @bgrant0607, @ghodss","created_at":"2015-08-21T01:37:59Z","updated_at":"2015-08-25T22:06:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1cf74e9e59f97723aa824c2da48ef6f2132f636","assignee":{"login":"jlowdermilk","id":2101035,"avatar_url":"https://avatars.githubusercontent.com/u/2101035?v=3","gravatar_id":"","url":"https://api.github.com/users/jlowdermilk","html_url":"https://github.com/jlowdermilk","followers_url":"https://api.github.com/users/jlowdermilk/followers","following_url":"https://api.github.com/users/jlowdermilk/following{/other_user}","gists_url":"https://api.github.com/users/jlowdermilk/gists{/gist_id}","starred_url":"https://api.github.com/users/jlowdermilk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlowdermilk/subscriptions","organizations_url":"https://api.github.com/users/jlowdermilk/orgs","repos_url":"https://api.github.com/users/jlowdermilk/repos","events_url":"https://api.github.com/users/jlowdermilk/events{/privacy}","received_events_url":"https://api.github.com/users/jlowdermilk/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13007/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13007/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13007/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/d9568b7bd5c5c3c2ab0d6616fff8767961ec8308","head":{"label":"jackgr:diff_and_patch","ref":"diff_and_patch","sha":"d9568b7bd5c5c3c2ab0d6616fff8767961ec8308","user":{"login":"jackgr","id":5607565,"avatar_url":"https://avatars.githubusercontent.com/u/5607565?v=3","gravatar_id":"","url":"https://api.github.com/users/jackgr","html_url":"https://github.com/jackgr","followers_url":"https://api.github.com/users/jackgr/followers","following_url":"https://api.github.com/users/jackgr/following{/other_user}","gists_url":"https://api.github.com/users/jackgr/gists{/gist_id}","starred_url":"https://api.github.com/users/jackgr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackgr/subscriptions","organizations_url":"https://api.github.com/users/jackgr/orgs","repos_url":"https://api.github.com/users/jackgr/repos","events_url":"https://api.github.com/users/jackgr/events{/privacy}","received_events_url":"https://api.github.com/users/jackgr/received_events","type":"User","site_admin":false},"repo":{"id":28700637,"name":"kubernetes","full_name":"jackgr/kubernetes","owner":{"login":"jackgr","id":5607565,"avatar_url":"https://avatars.githubusercontent.com/u/5607565?v=3","gravatar_id":"","url":"https://api.github.com/users/jackgr","html_url":"https://github.com/jackgr","followers_url":"https://api.github.com/users/jackgr/followers","following_url":"https://api.github.com/users/jackgr/following{/other_user}","gists_url":"https://api.github.com/users/jackgr/gists{/gist_id}","starred_url":"https://api.github.com/users/jackgr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackgr/subscriptions","organizations_url":"https://api.github.com/users/jackgr/orgs","repos_url":"https://api.github.com/users/jackgr/repos","events_url":"https://api.github.com/users/jackgr/events{/privacy}","received_events_url":"https://api.github.com/users/jackgr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jackgr/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/jackgr/kubernetes","forks_url":"https://api.github.com/repos/jackgr/kubernetes/forks","keys_url":"https://api.github.com/repos/jackgr/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jackgr/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jackgr/kubernetes/teams","hooks_url":"https://api.github.com/repos/jackgr/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/jackgr/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/jackgr/kubernetes/events","assignees_url":"https://api.github.com/repos/jackgr/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/jackgr/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/jackgr/kubernetes/tags","blobs_url":"https://api.github.com/repos/jackgr/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jackgr/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jackgr/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/jackgr/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jackgr/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/jackgr/kubernetes/languages","stargazers_url":"https://api.github.com/repos/jackgr/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/jackgr/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/jackgr/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/jackgr/kubernetes/subscription","commits_url":"https://api.github.com/repos/jackgr/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/jackgr/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/jackgr/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/jackgr/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/jackgr/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/jackgr/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jackgr/kubernetes/merges","archive_url":"https://api.github.com/repos/jackgr/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jackgr/kubernetes/downloads","issues_url":"https://api.github.com/repos/jackgr/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/jackgr/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/jackgr/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/jackgr/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jackgr/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/jackgr/kubernetes/releases{/id}","created_at":"2015-01-02T01:47:28Z","updated_at":"2015-02-07T19:40:44Z","pushed_at":"2015-08-21T01:32:44Z","git_url":"git://github.com/jackgr/kubernetes.git","ssh_url":"git@github.com:jackgr/kubernetes.git","clone_url":"https://github.com/jackgr/kubernetes.git","svn_url":"https://github.com/jackgr/kubernetes","homepage":null,"size":102704,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"ebe50ea6925ea0257e5d3f695f5798639a083aee","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-08-25T20:43:57Z","pushed_at":"2015-08-25T21:48:36Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":360890,"stargazers_count":9886,"watchers_count":9886,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2391,"mirror_url":null,"open_issues_count":1738,"forks":2391,"open_issues":1738,"watchers":9886,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13007"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/13007"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/13007"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/13007/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13007/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13007/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/d9568b7bd5c5c3c2ab0d6616fff8767961ec8308"}}}}