{"action":"created","issue":{"url":"https://api.github.com/repos/tdhock/animint/issues/74","labels_url":"https://api.github.com/repos/tdhock/animint/issues/74/labels{/name}","comments_url":"https://api.github.com/repos/tdhock/animint/issues/74/comments","events_url":"https://api.github.com/repos/tdhock/animint/issues/74/events","html_url":"https://github.com/tdhock/animint/pull/74","id":79163215,"number":74,"title":"Getting started with interactive legends","user":{"login":"kferris10","id":6612411,"avatar_url":"https://avatars.githubusercontent.com/u/6612411?v=3","gravatar_id":"","url":"https://api.github.com/users/kferris10","html_url":"https://github.com/kferris10","followers_url":"https://api.github.com/users/kferris10/followers","following_url":"https://api.github.com/users/kferris10/following{/other_user}","gists_url":"https://api.github.com/users/kferris10/gists{/gist_id}","starred_url":"https://api.github.com/users/kferris10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kferris10/subscriptions","organizations_url":"https://api.github.com/users/kferris10/orgs","repos_url":"https://api.github.com/users/kferris10/repos","events_url":"https://api.github.com/users/kferris10/events{/privacy}","received_events_url":"https://api.github.com/users/kferris10/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":39,"created_at":"2015-05-21T21:13:12Z","updated_at":"2015-06-26T17:03:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tdhock/animint/pulls/74","html_url":"https://github.com/tdhock/animint/pull/74","diff_url":"https://github.com/tdhock/animint/pull/74.diff","patch_url":"https://github.com/tdhock/animint/pull/74.patch"},"body":"This is just a rough start to implementing interactive legends.  @cpsievert thought it would be good to discuss where exactly we want this to go.  He has a couple ideas which are slightly over my head so I'll let him explain.\r\n\r\nI've [put together a working example](http://kferris10.github.io/animint_dev/) so you can see the general idea.  I also explain the changes I've made there.  I'm pretty sure that this is the only example for which this will work. \r\n\r\nI'd also love any suggestions for tests that might be useful here.  Thanks!"},"comment":{"url":"https://api.github.com/repos/tdhock/animint/issues/comments/115764604","html_url":"https://github.com/tdhock/animint/pull/74#issuecomment-115764604","issue_url":"https://api.github.com/repos/tdhock/animint/issues/74","id":115764604,"user":{"login":"tdhock","id":932850,"avatar_url":"https://avatars.githubusercontent.com/u/932850?v=3","gravatar_id":"","url":"https://api.github.com/users/tdhock","html_url":"https://github.com/tdhock","followers_url":"https://api.github.com/users/tdhock/followers","following_url":"https://api.github.com/users/tdhock/following{/other_user}","gists_url":"https://api.github.com/users/tdhock/gists{/gist_id}","starred_url":"https://api.github.com/users/tdhock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdhock/subscriptions","organizations_url":"https://api.github.com/users/tdhock/orgs","repos_url":"https://api.github.com/users/tdhock/repos","events_url":"https://api.github.com/users/tdhock/events{/privacy}","received_events_url":"https://api.github.com/users/tdhock/received_events","type":"User","site_admin":false},"created_at":"2015-06-26T17:03:55Z","updated_at":"2015-06-26T17:03:55Z","body":"Actually I think the correct behavior is indeed to show/hide the\nwide/tallrects after clicking the status legend, since they have\naes(linetype=status). However the geom_text does not have\naes(linetype=status) so it should not show/hide after clicking the status\nlegend.\n\nAnd yes it would be fine to make selector.types a list if you like.\n\nOn Fri, Jun 26, 2015 at 9:54 AM, Kevin Ferris <notifications@github.com>\nwrote:\n\n> You're right about the bug being caused by accidentally adding a\n> showSelected aesthetic to the text. It's also happening to the widerects\n> and tallrects as well. The easy solution would be to simply tell the\n> compiler not to add the showSelected aesthetic for geom_widerect(),\n> geom_tallrect(), or make_text().\n>\n> Would this be an okay solution? I can't think of a time when we'd want to\n> use the legend to hide these.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/tdhock/animint/pull/74#issuecomment-115697977>.\n>\n"}}