{"action":"closed","number":1001,"pull_request":{"url":"https://api.github.com/repos/caelum/vraptor4/pulls/1001","id":42508004,"html_url":"https://github.com/caelum/vraptor4/pull/1001","diff_url":"https://github.com/caelum/vraptor4/pull/1001.diff","patch_url":"https://github.com/caelum/vraptor4/pull/1001.patch","issue_url":"https://api.github.com/repos/caelum/vraptor4/issues/1001","number":1001,"state":"closed","locked":false,"title":"Refactoring null check at MethodInfo","user":{"login":"garcia-jj","id":140387,"avatar_url":"https://avatars.githubusercontent.com/u/140387?v=3","gravatar_id":"","url":"https://api.github.com/users/garcia-jj","html_url":"https://github.com/garcia-jj","followers_url":"https://api.github.com/users/garcia-jj/followers","following_url":"https://api.github.com/users/garcia-jj/following{/other_user}","gists_url":"https://api.github.com/users/garcia-jj/gists{/gist_id}","starred_url":"https://api.github.com/users/garcia-jj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garcia-jj/subscriptions","organizations_url":"https://api.github.com/users/garcia-jj/orgs","repos_url":"https://api.github.com/users/garcia-jj/repos","events_url":"https://api.github.com/users/garcia-jj/events{/privacy}","received_events_url":"https://api.github.com/users/garcia-jj/received_events","type":"User","site_admin":false},"body":"Because at this time if `controllerMethod` is null, a NPE will throws because line 98 don't check null. The null check was done in the line 99.","created_at":"2015-08-14T23:45:51Z","updated_at":"2015-08-15T21:01:52Z","closed_at":"2015-08-15T21:01:52Z","merged_at":null,"merge_commit_sha":"273efc83c387ce4a6aa2124444bfd52e4ee1f8e2","assignee":null,"milestone":{"url":"https://api.github.com/repos/caelum/vraptor4/milestones/8","html_url":"https://github.com/caelum/vraptor4/milestones/4.2.0.Final","labels_url":"https://api.github.com/repos/caelum/vraptor4/milestones/8/labels","id":835924,"number":8,"title":"4.2.0.Final","description":null,"creator":{"login":"Turini","id":1529021,"avatar_url":"https://avatars.githubusercontent.com/u/1529021?v=3","gravatar_id":"","url":"https://api.github.com/users/Turini","html_url":"https://github.com/Turini","followers_url":"https://api.github.com/users/Turini/followers","following_url":"https://api.github.com/users/Turini/following{/other_user}","gists_url":"https://api.github.com/users/Turini/gists{/gist_id}","starred_url":"https://api.github.com/users/Turini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Turini/subscriptions","organizations_url":"https://api.github.com/users/Turini/orgs","repos_url":"https://api.github.com/users/Turini/repos","events_url":"https://api.github.com/users/Turini/events{/privacy}","received_events_url":"https://api.github.com/users/Turini/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":29,"state":"open","created_at":"2014-10-22T13:31:34Z","updated_at":"2015-08-15T21:01:52Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/caelum/vraptor4/pulls/1001/commits","review_comments_url":"https://api.github.com/repos/caelum/vraptor4/pulls/1001/comments","review_comment_url":"https://api.github.com/repos/caelum/vraptor4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caelum/vraptor4/issues/1001/comments","statuses_url":"https://api.github.com/repos/caelum/vraptor4/statuses/6ddd6e31dce63839ebb80e9272ab9a6d153965f2","head":{"label":"garcia-jj:ot-ag-nullcheck","ref":"ot-ag-nullcheck","sha":"6ddd6e31dce63839ebb80e9272ab9a6d153965f2","user":{"login":"garcia-jj","id":140387,"avatar_url":"https://avatars.githubusercontent.com/u/140387?v=3","gravatar_id":"","url":"https://api.github.com/users/garcia-jj","html_url":"https://github.com/garcia-jj","followers_url":"https://api.github.com/users/garcia-jj/followers","following_url":"https://api.github.com/users/garcia-jj/following{/other_user}","gists_url":"https://api.github.com/users/garcia-jj/gists{/gist_id}","starred_url":"https://api.github.com/users/garcia-jj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garcia-jj/subscriptions","organizations_url":"https://api.github.com/users/garcia-jj/orgs","repos_url":"https://api.github.com/users/garcia-jj/repos","events_url":"https://api.github.com/users/garcia-jj/events{/privacy}","received_events_url":"https://api.github.com/users/garcia-jj/received_events","type":"User","site_admin":false},"repo":{"id":15870943,"name":"vraptor4","full_name":"garcia-jj/vraptor4","owner":{"login":"garcia-jj","id":140387,"avatar_url":"https://avatars.githubusercontent.com/u/140387?v=3","gravatar_id":"","url":"https://api.github.com/users/garcia-jj","html_url":"https://github.com/garcia-jj","followers_url":"https://api.github.com/users/garcia-jj/followers","following_url":"https://api.github.com/users/garcia-jj/following{/other_user}","gists_url":"https://api.github.com/users/garcia-jj/gists{/gist_id}","starred_url":"https://api.github.com/users/garcia-jj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garcia-jj/subscriptions","organizations_url":"https://api.github.com/users/garcia-jj/orgs","repos_url":"https://api.github.com/users/garcia-jj/repos","events_url":"https://api.github.com/users/garcia-jj/events{/privacy}","received_events_url":"https://api.github.com/users/garcia-jj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/garcia-jj/vraptor4","description":"","fork":true,"url":"https://api.github.com/repos/garcia-jj/vraptor4","forks_url":"https://api.github.com/repos/garcia-jj/vraptor4/forks","keys_url":"https://api.github.com/repos/garcia-jj/vraptor4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garcia-jj/vraptor4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garcia-jj/vraptor4/teams","hooks_url":"https://api.github.com/repos/garcia-jj/vraptor4/hooks","issue_events_url":"https://api.github.com/repos/garcia-jj/vraptor4/issues/events{/number}","events_url":"https://api.github.com/repos/garcia-jj/vraptor4/events","assignees_url":"https://api.github.com/repos/garcia-jj/vraptor4/assignees{/user}","branches_url":"https://api.github.com/repos/garcia-jj/vraptor4/branches{/branch}","tags_url":"https://api.github.com/repos/garcia-jj/vraptor4/tags","blobs_url":"https://api.github.com/repos/garcia-jj/vraptor4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garcia-jj/vraptor4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garcia-jj/vraptor4/git/refs{/sha}","trees_url":"https://api.github.com/repos/garcia-jj/vraptor4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garcia-jj/vraptor4/statuses/{sha}","languages_url":"https://api.github.com/repos/garcia-jj/vraptor4/languages","stargazers_url":"https://api.github.com/repos/garcia-jj/vraptor4/stargazers","contributors_url":"https://api.github.com/repos/garcia-jj/vraptor4/contributors","subscribers_url":"https://api.github.com/repos/garcia-jj/vraptor4/subscribers","subscription_url":"https://api.github.com/repos/garcia-jj/vraptor4/subscription","commits_url":"https://api.github.com/repos/garcia-jj/vraptor4/commits{/sha}","git_commits_url":"https://api.github.com/repos/garcia-jj/vraptor4/git/commits{/sha}","comments_url":"https://api.github.com/repos/garcia-jj/vraptor4/comments{/number}","issue_comment_url":"https://api.github.com/repos/garcia-jj/vraptor4/issues/comments{/number}","contents_url":"https://api.github.com/repos/garcia-jj/vraptor4/contents/{+path}","compare_url":"https://api.github.com/repos/garcia-jj/vraptor4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garcia-jj/vraptor4/merges","archive_url":"https://api.github.com/repos/garcia-jj/vraptor4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garcia-jj/vraptor4/downloads","issues_url":"https://api.github.com/repos/garcia-jj/vraptor4/issues{/number}","pulls_url":"https://api.github.com/repos/garcia-jj/vraptor4/pulls{/number}","milestones_url":"https://api.github.com/repos/garcia-jj/vraptor4/milestones{/number}","notifications_url":"https://api.github.com/repos/garcia-jj/vraptor4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garcia-jj/vraptor4/labels{/name}","releases_url":"https://api.github.com/repos/garcia-jj/vraptor4/releases{/id}","created_at":"2014-01-13T14:47:00Z","updated_at":"2014-12-16T23:04:04Z","pushed_at":"2015-08-15T19:42:01Z","git_url":"git://github.com/garcia-jj/vraptor4.git","ssh_url":"git@github.com:garcia-jj/vraptor4.git","clone_url":"https://github.com/garcia-jj/vraptor4.git","svn_url":"https://github.com/garcia-jj/vraptor4","homepage":"","size":11142,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"caelum:master","ref":"master","sha":"d61a977f8684655349c6bab290f0aedd701fde9d","user":{"login":"caelum","id":65012,"avatar_url":"https://avatars.githubusercontent.com/u/65012?v=3","gravatar_id":"","url":"https://api.github.com/users/caelum","html_url":"https://github.com/caelum","followers_url":"https://api.github.com/users/caelum/followers","following_url":"https://api.github.com/users/caelum/following{/other_user}","gists_url":"https://api.github.com/users/caelum/gists{/gist_id}","starred_url":"https://api.github.com/users/caelum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caelum/subscriptions","organizations_url":"https://api.github.com/users/caelum/orgs","repos_url":"https://api.github.com/users/caelum/repos","events_url":"https://api.github.com/users/caelum/events{/privacy}","received_events_url":"https://api.github.com/users/caelum/received_events","type":"Organization","site_admin":false},"repo":{"id":9821876,"name":"vraptor4","full_name":"caelum/vraptor4","owner":{"login":"caelum","id":65012,"avatar_url":"https://avatars.githubusercontent.com/u/65012?v=3","gravatar_id":"","url":"https://api.github.com/users/caelum","html_url":"https://github.com/caelum","followers_url":"https://api.github.com/users/caelum/followers","following_url":"https://api.github.com/users/caelum/following{/other_user}","gists_url":"https://api.github.com/users/caelum/gists{/gist_id}","starred_url":"https://api.github.com/users/caelum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caelum/subscriptions","organizations_url":"https://api.github.com/users/caelum/orgs","repos_url":"https://api.github.com/users/caelum/repos","events_url":"https://api.github.com/users/caelum/events{/privacy}","received_events_url":"https://api.github.com/users/caelum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caelum/vraptor4","description":"A Java web MVC action-based framework","fork":false,"url":"https://api.github.com/repos/caelum/vraptor4","forks_url":"https://api.github.com/repos/caelum/vraptor4/forks","keys_url":"https://api.github.com/repos/caelum/vraptor4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caelum/vraptor4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caelum/vraptor4/teams","hooks_url":"https://api.github.com/repos/caelum/vraptor4/hooks","issue_events_url":"https://api.github.com/repos/caelum/vraptor4/issues/events{/number}","events_url":"https://api.github.com/repos/caelum/vraptor4/events","assignees_url":"https://api.github.com/repos/caelum/vraptor4/assignees{/user}","branches_url":"https://api.github.com/repos/caelum/vraptor4/branches{/branch}","tags_url":"https://api.github.com/repos/caelum/vraptor4/tags","blobs_url":"https://api.github.com/repos/caelum/vraptor4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caelum/vraptor4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caelum/vraptor4/git/refs{/sha}","trees_url":"https://api.github.com/repos/caelum/vraptor4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caelum/vraptor4/statuses/{sha}","languages_url":"https://api.github.com/repos/caelum/vraptor4/languages","stargazers_url":"https://api.github.com/repos/caelum/vraptor4/stargazers","contributors_url":"https://api.github.com/repos/caelum/vraptor4/contributors","subscribers_url":"https://api.github.com/repos/caelum/vraptor4/subscribers","subscription_url":"https://api.github.com/repos/caelum/vraptor4/subscription","commits_url":"https://api.github.com/repos/caelum/vraptor4/commits{/sha}","git_commits_url":"https://api.github.com/repos/caelum/vraptor4/git/commits{/sha}","comments_url":"https://api.github.com/repos/caelum/vraptor4/comments{/number}","issue_comment_url":"https://api.github.com/repos/caelum/vraptor4/issues/comments{/number}","contents_url":"https://api.github.com/repos/caelum/vraptor4/contents/{+path}","compare_url":"https://api.github.com/repos/caelum/vraptor4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caelum/vraptor4/merges","archive_url":"https://api.github.com/repos/caelum/vraptor4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caelum/vraptor4/downloads","issues_url":"https://api.github.com/repos/caelum/vraptor4/issues{/number}","pulls_url":"https://api.github.com/repos/caelum/vraptor4/pulls{/number}","milestones_url":"https://api.github.com/repos/caelum/vraptor4/milestones{/number}","notifications_url":"https://api.github.com/repos/caelum/vraptor4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caelum/vraptor4/labels{/name}","releases_url":"https://api.github.com/repos/caelum/vraptor4/releases{/id}","created_at":"2013-05-02T20:22:14Z","updated_at":"2015-08-13T03:54:57Z","pushed_at":"2015-08-15T02:58:32Z","git_url":"git://github.com/caelum/vraptor4.git","ssh_url":"git@github.com:caelum/vraptor4.git","clone_url":"https://github.com/caelum/vraptor4.git","svn_url":"https://github.com/caelum/vraptor4","homepage":"vraptor.org","size":25349,"stargazers_count":222,"watchers_count":222,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":222,"mirror_url":null,"open_issues_count":29,"forks":222,"open_issues":29,"watchers":222,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/caelum/vraptor4/pulls/1001"},"html":{"href":"https://github.com/caelum/vraptor4/pull/1001"},"issue":{"href":"https://api.github.com/repos/caelum/vraptor4/issues/1001"},"comments":{"href":"https://api.github.com/repos/caelum/vraptor4/issues/1001/comments"},"review_comments":{"href":"https://api.github.com/repos/caelum/vraptor4/pulls/1001/comments"},"review_comment":{"href":"https://api.github.com/repos/caelum/vraptor4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caelum/vraptor4/pulls/1001/commits"},"statuses":{"href":"https://api.github.com/repos/caelum/vraptor4/statuses/6ddd6e31dce63839ebb80e9272ab9a6d153965f2"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":2,"commits":3,"additions":12,"deletions":8,"changed_files":2}}