{"action":"created","comment":{"url":"https://api.github.com/repos/openregister/presentation/pulls/comments/42133221","id":42133221,"diff_hunk":"@@ -21,7 +22,7 @@ public boolean isList() {\n     @Override\n     @JsonIgnore\n     public String getValue() {\n-        throw new UnsupportedOperationException();\n+        return \"[ \" + String.join(\", \", Lists.transform(elements, FieldValue::getValue)) + \" ]\";","path":"src/main/java/uk/gov/register/presentation/ListValue.java","position":13,"original_position":13,"commit_id":"33d80bb87f98d1d87a0b6009e96c9261d9752f50","original_commit_id":"33d80bb87f98d1d87a0b6009e96c9261d9752f50","user":{"login":"om-sharma","id":8011952,"avatar_url":"https://avatars.githubusercontent.com/u/8011952?v=3","gravatar_id":"","url":"https://api.github.com/users/om-sharma","html_url":"https://github.com/om-sharma","followers_url":"https://api.github.com/users/om-sharma/followers","following_url":"https://api.github.com/users/om-sharma/following{/other_user}","gists_url":"https://api.github.com/users/om-sharma/gists{/gist_id}","starred_url":"https://api.github.com/users/om-sharma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/om-sharma/subscriptions","organizations_url":"https://api.github.com/users/om-sharma/orgs","repos_url":"https://api.github.com/users/om-sharma/repos","events_url":"https://api.github.com/users/om-sharma/events{/privacy}","received_events_url":"https://api.github.com/users/om-sharma/received_events","type":"User","site_admin":false},"body":"I agree, this object should not render the html. I see getValue() method kind of toString() method for this object. \r\nIt does not renders linkValues as links and we need more work to do that (stated in commit message). This is quick solution to resolve 500 response from register register.\r\n","created_at":"2015-10-15T14:46:37Z","updated_at":"2015-10-15T14:46:37Z","html_url":"https://github.com/openregister/presentation/pull/95#discussion_r42133221","pull_request_url":"https://api.github.com/repos/openregister/presentation/pulls/95","_links":{"self":{"href":"https://api.github.com/repos/openregister/presentation/pulls/comments/42133221"},"html":{"href":"https://github.com/openregister/presentation/pull/95#discussion_r42133221"},"pull_request":{"href":"https://api.github.com/repos/openregister/presentation/pulls/95"}}},"pull_request":{"url":"https://api.github.com/repos/openregister/presentation/pulls/95","id":47790648,"html_url":"https://github.com/openregister/presentation/pull/95","diff_url":"https://github.com/openregister/presentation/pull/95.diff","patch_url":"https://github.com/openregister/presentation/pull/95.patch","issue_url":"https://api.github.com/repos/openregister/presentation/issues/95","number":95,"state":"open","locked":false,"title":"bug: html view for register register was broken","user":{"login":"om-sharma","id":8011952,"avatar_url":"https://avatars.githubusercontent.com/u/8011952?v=3","gravatar_id":"","url":"https://api.github.com/users/om-sharma","html_url":"https://github.com/om-sharma","followers_url":"https://api.github.com/users/om-sharma/followers","following_url":"https://api.github.com/users/om-sharma/following{/other_user}","gists_url":"https://api.github.com/users/om-sharma/gists{/gist_id}","starred_url":"https://api.github.com/users/om-sharma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/om-sharma/subscriptions","organizations_url":"https://api.github.com/users/om-sharma/orgs","repos_url":"https://api.github.com/users/om-sharma/repos","events_url":"https://api.github.com/users/om-sharma/events{/privacy}","received_events_url":"https://api.github.com/users/om-sharma/received_events","type":"User","site_admin":false},"body":" After introducing the ListValue class html view of register register was broken because it is only register which has fields whose value is a list. getValue() method of ListValue was not implemented so html was unable to render.\r\n   Changes in this commit renders fields as plain text list of fields, these are not linked to field register. There is more work needed to achieve this.","created_at":"2015-10-15T14:06:47Z","updated_at":"2015-10-15T14:46:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e580000a943d846f1a9109edefd5826bc49e615c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openregister/presentation/pulls/95/commits","review_comments_url":"https://api.github.com/repos/openregister/presentation/pulls/95/comments","review_comment_url":"https://api.github.com/repos/openregister/presentation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openregister/presentation/issues/95/comments","statuses_url":"https://api.github.com/repos/openregister/presentation/statuses/33d80bb87f98d1d87a0b6009e96c9261d9752f50","head":{"label":"openregister:register-register-html-representation-bug","ref":"register-register-html-representation-bug","sha":"33d80bb87f98d1d87a0b6009e96c9261d9752f50","user":{"login":"openregister","id":10206003,"avatar_url":"https://avatars.githubusercontent.com/u/10206003?v=3","gravatar_id":"","url":"https://api.github.com/users/openregister","html_url":"https://github.com/openregister","followers_url":"https://api.github.com/users/openregister/followers","following_url":"https://api.github.com/users/openregister/following{/other_user}","gists_url":"https://api.github.com/users/openregister/gists{/gist_id}","starred_url":"https://api.github.com/users/openregister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openregister/subscriptions","organizations_url":"https://api.github.com/users/openregister/orgs","repos_url":"https://api.github.com/users/openregister/repos","events_url":"https://api.github.com/users/openregister/events{/privacy}","received_events_url":"https://api.github.com/users/openregister/received_events","type":"Organization","site_admin":false},"repo":{"id":38381661,"name":"presentation","full_name":"openregister/presentation","owner":{"login":"openregister","id":10206003,"avatar_url":"https://avatars.githubusercontent.com/u/10206003?v=3","gravatar_id":"","url":"https://api.github.com/users/openregister","html_url":"https://github.com/openregister","followers_url":"https://api.github.com/users/openregister/followers","following_url":"https://api.github.com/users/openregister/following{/other_user}","gists_url":"https://api.github.com/users/openregister/gists{/gist_id}","starred_url":"https://api.github.com/users/openregister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openregister/subscriptions","organizations_url":"https://api.github.com/users/openregister/orgs","repos_url":"https://api.github.com/users/openregister/repos","events_url":"https://api.github.com/users/openregister/events{/privacy}","received_events_url":"https://api.github.com/users/openregister/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openregister/presentation","description":"Read-only register application","fork":false,"url":"https://api.github.com/repos/openregister/presentation","forks_url":"https://api.github.com/repos/openregister/presentation/forks","keys_url":"https://api.github.com/repos/openregister/presentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openregister/presentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openregister/presentation/teams","hooks_url":"https://api.github.com/repos/openregister/presentation/hooks","issue_events_url":"https://api.github.com/repos/openregister/presentation/issues/events{/number}","events_url":"https://api.github.com/repos/openregister/presentation/events","assignees_url":"https://api.github.com/repos/openregister/presentation/assignees{/user}","branches_url":"https://api.github.com/repos/openregister/presentation/branches{/branch}","tags_url":"https://api.github.com/repos/openregister/presentation/tags","blobs_url":"https://api.github.com/repos/openregister/presentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openregister/presentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openregister/presentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/openregister/presentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openregister/presentation/statuses/{sha}","languages_url":"https://api.github.com/repos/openregister/presentation/languages","stargazers_url":"https://api.github.com/repos/openregister/presentation/stargazers","contributors_url":"https://api.github.com/repos/openregister/presentation/contributors","subscribers_url":"https://api.github.com/repos/openregister/presentation/subscribers","subscription_url":"https://api.github.com/repos/openregister/presentation/subscription","commits_url":"https://api.github.com/repos/openregister/presentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/openregister/presentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/openregister/presentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/openregister/presentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/openregister/presentation/contents/{+path}","compare_url":"https://api.github.com/repos/openregister/presentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openregister/presentation/merges","archive_url":"https://api.github.com/repos/openregister/presentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openregister/presentation/downloads","issues_url":"https://api.github.com/repos/openregister/presentation/issues{/number}","pulls_url":"https://api.github.com/repos/openregister/presentation/pulls{/number}","milestones_url":"https://api.github.com/repos/openregister/presentation/milestones{/number}","notifications_url":"https://api.github.com/repos/openregister/presentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openregister/presentation/labels{/name}","releases_url":"https://api.github.com/repos/openregister/presentation/releases{/id}","created_at":"2015-07-01T16:17:58Z","updated_at":"2015-09-24T14:30:47Z","pushed_at":"2015-10-15T14:06:47Z","git_url":"git://github.com/openregister/presentation.git","ssh_url":"git@github.com:openregister/presentation.git","clone_url":"https://github.com/openregister/presentation.git","svn_url":"https://github.com/openregister/presentation","homepage":"","size":3320,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"openregister:master","ref":"master","sha":"dc69b71d21c530f5de0b73c0399a1d441fb1047e","user":{"login":"openregister","id":10206003,"avatar_url":"https://avatars.githubusercontent.com/u/10206003?v=3","gravatar_id":"","url":"https://api.github.com/users/openregister","html_url":"https://github.com/openregister","followers_url":"https://api.github.com/users/openregister/followers","following_url":"https://api.github.com/users/openregister/following{/other_user}","gists_url":"https://api.github.com/users/openregister/gists{/gist_id}","starred_url":"https://api.github.com/users/openregister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openregister/subscriptions","organizations_url":"https://api.github.com/users/openregister/orgs","repos_url":"https://api.github.com/users/openregister/repos","events_url":"https://api.github.com/users/openregister/events{/privacy}","received_events_url":"https://api.github.com/users/openregister/received_events","type":"Organization","site_admin":false},"repo":{"id":38381661,"name":"presentation","full_name":"openregister/presentation","owner":{"login":"openregister","id":10206003,"avatar_url":"https://avatars.githubusercontent.com/u/10206003?v=3","gravatar_id":"","url":"https://api.github.com/users/openregister","html_url":"https://github.com/openregister","followers_url":"https://api.github.com/users/openregister/followers","following_url":"https://api.github.com/users/openregister/following{/other_user}","gists_url":"https://api.github.com/users/openregister/gists{/gist_id}","starred_url":"https://api.github.com/users/openregister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openregister/subscriptions","organizations_url":"https://api.github.com/users/openregister/orgs","repos_url":"https://api.github.com/users/openregister/repos","events_url":"https://api.github.com/users/openregister/events{/privacy}","received_events_url":"https://api.github.com/users/openregister/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openregister/presentation","description":"Read-only register application","fork":false,"url":"https://api.github.com/repos/openregister/presentation","forks_url":"https://api.github.com/repos/openregister/presentation/forks","keys_url":"https://api.github.com/repos/openregister/presentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openregister/presentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openregister/presentation/teams","hooks_url":"https://api.github.com/repos/openregister/presentation/hooks","issue_events_url":"https://api.github.com/repos/openregister/presentation/issues/events{/number}","events_url":"https://api.github.com/repos/openregister/presentation/events","assignees_url":"https://api.github.com/repos/openregister/presentation/assignees{/user}","branches_url":"https://api.github.com/repos/openregister/presentation/branches{/branch}","tags_url":"https://api.github.com/repos/openregister/presentation/tags","blobs_url":"https://api.github.com/repos/openregister/presentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openregister/presentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openregister/presentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/openregister/presentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openregister/presentation/statuses/{sha}","languages_url":"https://api.github.com/repos/openregister/presentation/languages","stargazers_url":"https://api.github.com/repos/openregister/presentation/stargazers","contributors_url":"https://api.github.com/repos/openregister/presentation/contributors","subscribers_url":"https://api.github.com/repos/openregister/presentation/subscribers","subscription_url":"https://api.github.com/repos/openregister/presentation/subscription","commits_url":"https://api.github.com/repos/openregister/presentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/openregister/presentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/openregister/presentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/openregister/presentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/openregister/presentation/contents/{+path}","compare_url":"https://api.github.com/repos/openregister/presentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openregister/presentation/merges","archive_url":"https://api.github.com/repos/openregister/presentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openregister/presentation/downloads","issues_url":"https://api.github.com/repos/openregister/presentation/issues{/number}","pulls_url":"https://api.github.com/repos/openregister/presentation/pulls{/number}","milestones_url":"https://api.github.com/repos/openregister/presentation/milestones{/number}","notifications_url":"https://api.github.com/repos/openregister/presentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openregister/presentation/labels{/name}","releases_url":"https://api.github.com/repos/openregister/presentation/releases{/id}","created_at":"2015-07-01T16:17:58Z","updated_at":"2015-09-24T14:30:47Z","pushed_at":"2015-10-15T14:06:47Z","git_url":"git://github.com/openregister/presentation.git","ssh_url":"git@github.com:openregister/presentation.git","clone_url":"https://github.com/openregister/presentation.git","svn_url":"https://github.com/openregister/presentation","homepage":"","size":3320,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openregister/presentation/pulls/95"},"html":{"href":"https://github.com/openregister/presentation/pull/95"},"issue":{"href":"https://api.github.com/repos/openregister/presentation/issues/95"},"comments":{"href":"https://api.github.com/repos/openregister/presentation/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/openregister/presentation/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/openregister/presentation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openregister/presentation/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/openregister/presentation/statuses/33d80bb87f98d1d87a0b6009e96c9261d9752f50"}}}}