{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew-x11/pulls/comments/32799691","id":32799691,"diff_hunk":"@@ -1,57 +1,68 @@\n-require \"formula\"\n-\n class Yarp < Formula\n+  desc \"Yet Another Robot Platform\"\n   homepage \"http://yarp.it\"\n+  url \"https://github.com/robotology/yarp/archive/v2.3.64.tar.gz\"\n+  sha256 \"3882b38c39ec9c5fdd06c68f3a4ad21da718bd2733ed7d6a5fb78d9f36dad6b2\"\n   head \"https://github.com/robotology/yarp.git\"\n-  url \"https://github.com/robotology/yarp/archive/v2.3.63.tar.gz\"\n-  sha1 \"bef87cf5e53c1dc5b9fe4de90022cb8285405fa2\"\n \n-  option \"without-shared\", \"Build only static version of YARP libraries\"\n+  option \"with-qt5\", \"Build the Qt5 GUI applications\"\n+  option \"with-yarprun-log\", \"Build with yarprun_log support\"\n+  option \"with-opencv\", \"Build the opencv_grabber device\"\n+  option \"with-lua\", \"Build with Lua bindings\"\n+  option \"with-serial\", \"Build the serial/serialport devices\"\n \n   depends_on \"pkg-config\" => :build\n   depends_on \"cmake\" => :build\n   depends_on \"ace\"\n   depends_on \"gsl\"\n-  depends_on \"gtk+\"\n-  depends_on \"gtkmm\"\n-  depends_on \"libglademm\"\n   depends_on \"sqlite\"\n   depends_on \"readline\"\n   depends_on \"jpeg\"\n-  depends_on :x11\n+  depends_on \"homebrew/science/opencv\" => :optional\n+  depends_on \"qt5\" => :optional\n+  depends_on \"lua\" => :optional\n+  depends_on \"swig\" if build.with? \"lua\"\n \n   def install\n     args = std_cmake_args + %W[\n       -DCREATE_LIB_MATH=TRUE\n-      -DCREATE_GUIS=TRUE\n-      -DCREATE_YMANAGER=TRUE\n-      -DYARP_USE_SYSTEM_SQLITE=TRUE\n+      -DCREATE_DEVICE_LIBRARY_MODULES=TRUE\n       -DCREATE_OPTIONAL_CARRIERS=TRUE\n       -DENABLE_yarpcar_mjpeg_carrier=TRUE\n       -DENABLE_yarpcar_rossrv_carrier=TRUE\n       -DENABLE_yarpcar_tcpros_carrier=TRUE\n       -DENABLE_yarpcar_xmlrpc_carrier=TRUE\n       -DENABLE_yarpcar_bayer_carrier=TRUE\n-      -DUSE_LIBDC1394=FALSE\n       -DENABLE_yarpcar_priority_carrier=TRUE\n       -DCREATE_IDLS=TRUE\n-      -DENABLE_yarpidl_thrift=TRUE\n-      -DCREATE_YARPVIEW=TRUE\n-      -DCREATE_YARPSCOPE=TRUE\n-      -DCREATE_GYARPMANAGER=TRUE\n-      ]\n-\n-      if build.without? \"shared\"\n-        args << \"-DCREATE_SHARED_LIBRARY:BOOL=FALSE\"\n-      else\n-        args << \"-DCREATE_SHARED_LIBRARY:BOOL=TRUE\"\n-      end\n-      args << \".\"\n+    ]\n+\n+    args << \"-DCREATE_GUIS=TRUE\" if build.with? \"qt5\"\n+    args << \"-DENABLE_YARPRUN_LOG=ON\" if build.with? \"yarprun-log\"\n+    args << \"-DENABLE_yarpmod_opencv_grabber=ON\" if build.with? \"opencv\"\n+\n+    if build.with? \"lua\"\n+      args << \"-DYARP_COMPILE_BINDINGS=ON\"\n+      args << \"-DCREATE_LUA=ON\"\n+    end\n+\n+    if build.with? \"serial\"\n+      args << \"-DENABLE_yarpmod_serial=ON\"\n+      args << \"-DENABLE_yarpmod_serialport=ON\"\n+    end\n \n     system \"cmake\", *args\n     system \"make\", \"install\"\n   end\n \n+  def caveats\n+    <<-EOS.undent\n+    You need to add in your ~/.bash_profile or similar:\n+\n+      export $YARP_DATA_DIRS=#{HOMEBREW_PREFIX}/share/yarp","path":"yarp.rb","position":87,"original_position":87,"commit_id":"42f03bf33f062561c7e31303aed9d6cb50f7b844","original_commit_id":"42f03bf33f062561c7e31303aed9d6cb50f7b844","user":{"login":"dunn","id":985416,"avatar_url":"https://avatars.githubusercontent.com/u/985416?v=3","gravatar_id":"","url":"https://api.github.com/users/dunn","html_url":"https://github.com/dunn","followers_url":"https://api.github.com/users/dunn/followers","following_url":"https://api.github.com/users/dunn/following{/other_user}","gists_url":"https://api.github.com/users/dunn/gists{/gist_id}","starred_url":"https://api.github.com/users/dunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dunn/subscriptions","organizations_url":"https://api.github.com/users/dunn/orgs","repos_url":"https://api.github.com/users/dunn/repos","events_url":"https://api.github.com/users/dunn/events{/privacy}","received_events_url":"https://api.github.com/users/dunn/received_events","type":"User","site_admin":false},"body":"Should the `$` be removed here?","created_at":"2015-06-19T03:45:04Z","updated_at":"2015-06-19T03:45:04Z","html_url":"https://github.com/Homebrew/homebrew-x11/pull/85#discussion_r32799691","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew-x11/pulls/85","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-x11/pulls/comments/32799691"},"html":{"href":"https://github.com/Homebrew/homebrew-x11/pull/85#discussion_r32799691"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew-x11/pulls/85"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew-x11/pulls/85","id":37879998,"html_url":"https://github.com/Homebrew/homebrew-x11/pull/85","diff_url":"https://github.com/Homebrew/homebrew-x11/pull/85.diff","patch_url":"https://github.com/Homebrew/homebrew-x11/pull/85.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew-x11/issues/85","number":85,"state":"open","locked":false,"title":"yarp: major cleaning up of dependencies and options. No X11 dependency anymore","user":{"login":"kt10aan","id":1415279,"avatar_url":"https://avatars.githubusercontent.com/u/1415279?v=3","gravatar_id":"","url":"https://api.github.com/users/kt10aan","html_url":"https://github.com/kt10aan","followers_url":"https://api.github.com/users/kt10aan/followers","following_url":"https://api.github.com/users/kt10aan/following{/other_user}","gists_url":"https://api.github.com/users/kt10aan/gists{/gist_id}","starred_url":"https://api.github.com/users/kt10aan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kt10aan/subscriptions","organizations_url":"https://api.github.com/users/kt10aan/orgs","repos_url":"https://api.github.com/users/kt10aan/repos","events_url":"https://api.github.com/users/kt10aan/events{/privacy}","received_events_url":"https://api.github.com/users/kt10aan/received_events","type":"User","site_admin":false},"body":"Hi,\r\nI have updated the yarp formula to the next version 2.3.64.\r\nThis version brought some major changes, the most important of it being the switch from GTK to Qt5.\r\nAs a result, X11 is not a dependency anymore and the formula should not be in homebrew-x11.\r\n\r\nI would like to ask, after the PR is merged, if the formula can be moved to homebrew-science (yarp is a robotics middleware that is used mainly in research robots in academia).\r\n\r\nFor upstream details, see https://github.com/robotology/yarp/issues/510\r\n\r\nMany thanks :)","created_at":"2015-06-17T09:13:14Z","updated_at":"2015-06-19T03:45:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8e6bb3e278d2bc3f2f20ffd24cbe4d499f5d281","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew-x11/pulls/85/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew-x11/pulls/85/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew-x11/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-x11/issues/85/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-x11/statuses/42f03bf33f062561c7e31303aed9d6cb50f7b844","head":{"label":"kt10aan:master","ref":"master","sha":"42f03bf33f062561c7e31303aed9d6cb50f7b844","user":{"login":"kt10aan","id":1415279,"avatar_url":"https://avatars.githubusercontent.com/u/1415279?v=3","gravatar_id":"","url":"https://api.github.com/users/kt10aan","html_url":"https://github.com/kt10aan","followers_url":"https://api.github.com/users/kt10aan/followers","following_url":"https://api.github.com/users/kt10aan/following{/other_user}","gists_url":"https://api.github.com/users/kt10aan/gists{/gist_id}","starred_url":"https://api.github.com/users/kt10aan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kt10aan/subscriptions","organizations_url":"https://api.github.com/users/kt10aan/orgs","repos_url":"https://api.github.com/users/kt10aan/repos","events_url":"https://api.github.com/users/kt10aan/events{/privacy}","received_events_url":"https://api.github.com/users/kt10aan/received_events","type":"User","site_admin":false},"repo":{"id":37573184,"name":"homebrew-x11","full_name":"kt10aan/homebrew-x11","owner":{"login":"kt10aan","id":1415279,"avatar_url":"https://avatars.githubusercontent.com/u/1415279?v=3","gravatar_id":"","url":"https://api.github.com/users/kt10aan","html_url":"https://github.com/kt10aan","followers_url":"https://api.github.com/users/kt10aan/followers","following_url":"https://api.github.com/users/kt10aan/following{/other_user}","gists_url":"https://api.github.com/users/kt10aan/gists{/gist_id}","starred_url":"https://api.github.com/users/kt10aan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kt10aan/subscriptions","organizations_url":"https://api.github.com/users/kt10aan/orgs","repos_url":"https://api.github.com/users/kt10aan/repos","events_url":"https://api.github.com/users/kt10aan/events{/privacy}","received_events_url":"https://api.github.com/users/kt10aan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kt10aan/homebrew-x11","description":":x: Applications with hard X11 dependencies","fork":true,"url":"https://api.github.com/repos/kt10aan/homebrew-x11","forks_url":"https://api.github.com/repos/kt10aan/homebrew-x11/forks","keys_url":"https://api.github.com/repos/kt10aan/homebrew-x11/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kt10aan/homebrew-x11/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kt10aan/homebrew-x11/teams","hooks_url":"https://api.github.com/repos/kt10aan/homebrew-x11/hooks","issue_events_url":"https://api.github.com/repos/kt10aan/homebrew-x11/issues/events{/number}","events_url":"https://api.github.com/repos/kt10aan/homebrew-x11/events","assignees_url":"https://api.github.com/repos/kt10aan/homebrew-x11/assignees{/user}","branches_url":"https://api.github.com/repos/kt10aan/homebrew-x11/branches{/branch}","tags_url":"https://api.github.com/repos/kt10aan/homebrew-x11/tags","blobs_url":"https://api.github.com/repos/kt10aan/homebrew-x11/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kt10aan/homebrew-x11/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kt10aan/homebrew-x11/git/refs{/sha}","trees_url":"https://api.github.com/repos/kt10aan/homebrew-x11/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kt10aan/homebrew-x11/statuses/{sha}","languages_url":"https://api.github.com/repos/kt10aan/homebrew-x11/languages","stargazers_url":"https://api.github.com/repos/kt10aan/homebrew-x11/stargazers","contributors_url":"https://api.github.com/repos/kt10aan/homebrew-x11/contributors","subscribers_url":"https://api.github.com/repos/kt10aan/homebrew-x11/subscribers","subscription_url":"https://api.github.com/repos/kt10aan/homebrew-x11/subscription","commits_url":"https://api.github.com/repos/kt10aan/homebrew-x11/commits{/sha}","git_commits_url":"https://api.github.com/repos/kt10aan/homebrew-x11/git/commits{/sha}","comments_url":"https://api.github.com/repos/kt10aan/homebrew-x11/comments{/number}","issue_comment_url":"https://api.github.com/repos/kt10aan/homebrew-x11/issues/comments{/number}","contents_url":"https://api.github.com/repos/kt10aan/homebrew-x11/contents/{+path}","compare_url":"https://api.github.com/repos/kt10aan/homebrew-x11/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kt10aan/homebrew-x11/merges","archive_url":"https://api.github.com/repos/kt10aan/homebrew-x11/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kt10aan/homebrew-x11/downloads","issues_url":"https://api.github.com/repos/kt10aan/homebrew-x11/issues{/number}","pulls_url":"https://api.github.com/repos/kt10aan/homebrew-x11/pulls{/number}","milestones_url":"https://api.github.com/repos/kt10aan/homebrew-x11/milestones{/number}","notifications_url":"https://api.github.com/repos/kt10aan/homebrew-x11/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kt10aan/homebrew-x11/labels{/name}","releases_url":"https://api.github.com/repos/kt10aan/homebrew-x11/releases{/id}","created_at":"2015-06-17T04:50:10Z","updated_at":"2015-06-17T04:50:11Z","pushed_at":"2015-06-19T03:05:57Z","git_url":"git://github.com/kt10aan/homebrew-x11.git","ssh_url":"git@github.com:kt10aan/homebrew-x11.git","clone_url":"https://github.com/kt10aan/homebrew-x11.git","svn_url":"https://github.com/kt10aan/homebrew-x11","homepage":"","size":211,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"7c282b48fbf3a9f71afd4aecf1317fcd58823b89","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":18168935,"name":"homebrew-x11","full_name":"Homebrew/homebrew-x11","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew-x11","description":":x: Applications with hard X11 dependencies","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew-x11","forks_url":"https://api.github.com/repos/Homebrew/homebrew-x11/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew-x11/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew-x11/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew-x11/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew-x11/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew-x11/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew-x11/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew-x11/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew-x11/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew-x11/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew-x11/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew-x11/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew-x11/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew-x11/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-x11/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew-x11/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew-x11/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew-x11/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew-x11/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew-x11/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew-x11/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew-x11/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-x11/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew-x11/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew-x11/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew-x11/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew-x11/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew-x11/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew-x11/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew-x11/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew-x11/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew-x11/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew-x11/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew-x11/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew-x11/releases{/id}","created_at":"2014-03-27T08:20:43Z","updated_at":"2015-06-13T14:25:43Z","pushed_at":"2015-06-19T03:05:57Z","git_url":"git://github.com/Homebrew/homebrew-x11.git","ssh_url":"git@github.com:Homebrew/homebrew-x11.git","clone_url":"https://github.com/Homebrew/homebrew-x11.git","svn_url":"https://github.com/Homebrew/homebrew-x11","homepage":"","size":1037,"stargazers_count":18,"watchers_count":18,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":15,"forks":42,"open_issues":15,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-x11/pulls/85"},"html":{"href":"https://github.com/Homebrew/homebrew-x11/pull/85"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew-x11/issues/85"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-x11/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-x11/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew-x11/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew-x11/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew-x11/statuses/42f03bf33f062561c7e31303aed9d6cb50f7b844"}}}}