{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/5350","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/5350/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/5350/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/5350/events","html_url":"https://github.com/xbmc/xbmc/pull/5350","id":42415519,"number":5350,"title":"[confluence] texture updates.","user":{"login":"uNiversaI","id":3521959,"avatar_url":"https://avatars.githubusercontent.com/u/3521959?v=3","gravatar_id":"","url":"https://api.github.com/users/uNiversaI","html_url":"https://github.com/uNiversaI","followers_url":"https://api.github.com/users/uNiversaI/followers","following_url":"https://api.github.com/users/uNiversaI/following{/other_user}","gists_url":"https://api.github.com/users/uNiversaI/gists{/gist_id}","starred_url":"https://api.github.com/users/uNiversaI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uNiversaI/subscriptions","organizations_url":"https://api.github.com/users/uNiversaI/orgs","repos_url":"https://api.github.com/users/uNiversaI/repos","events_url":"https://api.github.com/users/uNiversaI/events{/privacy}","received_events_url":"https://api.github.com/users/uNiversaI/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/xbmc/xbmc/labels/Isengard","name":"Isengard","color":"207de5"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/xbmc/xbmc/milestones/29","html_url":"https://github.com/xbmc/xbmc/milestones/Abandoned,%20obsolete%20or%20superseeded","labels_url":"https://api.github.com/repos/xbmc/xbmc/milestones/29/labels","id":420368,"number":29,"title":"Abandoned, obsolete or superseeded","description":"This milestone contains all PRs that never where merged because they where rejected, superseeded or just not finished","creator":{"login":"MartijnKaijser","id":907436,"avatar_url":"https://avatars.githubusercontent.com/u/907436?v=3","gravatar_id":"","url":"https://api.github.com/users/MartijnKaijser","html_url":"https://github.com/MartijnKaijser","followers_url":"https://api.github.com/users/MartijnKaijser/followers","following_url":"https://api.github.com/users/MartijnKaijser/following{/other_user}","gists_url":"https://api.github.com/users/MartijnKaijser/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnKaijser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnKaijser/subscriptions","organizations_url":"https://api.github.com/users/MartijnKaijser/orgs","repos_url":"https://api.github.com/users/MartijnKaijser/repos","events_url":"https://api.github.com/users/MartijnKaijser/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnKaijser/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":667,"state":"open","created_at":"2013-09-05T17:16:24Z","updated_at":"2015-04-09T08:46:01Z","due_on":null,"closed_at":null},"comments":50,"created_at":"2014-09-10T13:59:56Z","updated_at":"2015-04-09T14:38:52Z","closed_at":"2015-03-07T18:00:18Z","pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/5350","html_url":"https://github.com/xbmc/xbmc/pull/5350","diff_url":"https://github.com/xbmc/xbmc/pull/5350.diff","patch_url":"https://github.com/xbmc/xbmc/pull/5350.patch"},"body":"I decided to retry re-submitting these improvements for two reasons,\r\n***1)*** Much has evolved since original PR and since you cannot easily make a theme installer for default skin as it resides in system paths and not userdata that also requires some coding beyond my skills\r\n \r\n***2)*** Since ***1)*** is more time consuming and unlikely to happen as easily. Confluence can <b>alternatively</b> by default ship with a ***second theme*** if so, This could easily be re-submitted as a secondary theme to be included by default. That probably require a different PR though.\r\n\r\n### Testing\r\nhttps://github.com/uNiversaI/revamped.themes/archive/2.3.5.zip by following instructions and selecting Revamp-osf theme (note the background used in theme not included in this PR)\r\n\r\n**dropped 6cd3169**\r\n```The only addition new graphics currently unused is commit  6cd3169 [confluence] Add NEW Default HDD icons  …  which probably requires xml or maybe sourcecode changes which are atm beyond my ability.\r\nThat adds 3 new types DefaultBDFull/Empty.png and DefaultUSB textures. which I thought would be nice to include. But will require assistance from a skinner to make them usable.```\r\n\r\nI tried to separate each change into separate commits to maybe make this reviewing simpler (if that's at all possible)\r\n\r\nI will be happy try to accommodate any requests improvements\r\n\r\n@ronie or whoever is responsible for deciding, please decide, if not wanted just close the PR.\r\n\r\nNote all current psd sources can be found at https://github.com/uNiversaI/revamp-confluence-psds"},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/91250611","html_url":"https://github.com/xbmc/xbmc/pull/5350#issuecomment-91250611","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/5350","id":91250611,"user":{"login":"uNiversaI","id":3521959,"avatar_url":"https://avatars.githubusercontent.com/u/3521959?v=3","gravatar_id":"","url":"https://api.github.com/users/uNiversaI","html_url":"https://github.com/uNiversaI","followers_url":"https://api.github.com/users/uNiversaI/followers","following_url":"https://api.github.com/users/uNiversaI/following{/other_user}","gists_url":"https://api.github.com/users/uNiversaI/gists{/gist_id}","starred_url":"https://api.github.com/users/uNiversaI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uNiversaI/subscriptions","organizations_url":"https://api.github.com/users/uNiversaI/orgs","repos_url":"https://api.github.com/users/uNiversaI/repos","events_url":"https://api.github.com/users/uNiversaI/events{/privacy}","received_events_url":"https://api.github.com/users/uNiversaI/received_events","type":"User","site_admin":false},"created_at":"2015-04-09T14:38:52Z","updated_at":"2015-04-09T14:38:52Z","body":"@da-anda \r\n\r\nI think I know what you meant by the some of the comments above\r\n\r\n>I also noticed that the list item hover texture doesn't fade out nicely on the edges - so one is able to see a edge in the area that's supposed to be 100% transparent already.\r\n\r\nthat above fixed\r\n\r\nI dimmed down the submenu focus textures a bit wasnt sure what other textures need dimming\r\n\r\nUntil I see your screenshot cant really address things Im not sure which ones you mean or what exactly.\r\n\r\nsee https://github.com/uNiversaI/revamped.themes/archive/4.02.zip\r\n\r\nIdle like to get this ready for isengard beta if you guys want it at all."}}