{"action":"created","issue":{"url":"https://api.github.com/repos/thias/puppet-vsftpd/issues/17","labels_url":"https://api.github.com/repos/thias/puppet-vsftpd/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/thias/puppet-vsftpd/issues/17/comments","events_url":"https://api.github.com/repos/thias/puppet-vsftpd/issues/17/events","html_url":"https://github.com/thias/puppet-vsftpd/pull/17","id":107780771,"number":17,"title":"All vsftpd.conf parameters created and put in template file.","user":{"login":"bschonec","id":9570174,"avatar_url":"https://avatars.githubusercontent.com/u/9570174?v=3","gravatar_id":"","url":"https://api.github.com/users/bschonec","html_url":"https://github.com/bschonec","followers_url":"https://api.github.com/users/bschonec/followers","following_url":"https://api.github.com/users/bschonec/following{/other_user}","gists_url":"https://api.github.com/users/bschonec/gists{/gist_id}","starred_url":"https://api.github.com/users/bschonec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bschonec/subscriptions","organizations_url":"https://api.github.com/users/bschonec/orgs","repos_url":"https://api.github.com/users/bschonec/repos","events_url":"https://api.github.com/users/bschonec/events{/privacy}","received_events_url":"https://api.github.com/users/bschonec/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-09-22T19:08:46Z","updated_at":"2015-11-20T21:31:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/thias/puppet-vsftpd/pulls/17","html_url":"https://github.com/thias/puppet-vsftpd/pull/17","diff_url":"https://github.com/thias/puppet-vsftpd/pull/17.diff","patch_url":"https://github.com/thias/puppet-vsftpd/pull/17.patch"},"body":"I went through 'man vsftpd.conf' and added any parameters that were missing from the module.  Added those new parameters to the template file.\r\n\r\nIn addition, I changed the params.pp file so that any argument that isn't specified manually gets its default value set to whatever 'man vsftpd.conf' says it should be.  Note that some of those values don't jive with what puppet-vsftpd module had so I made the default values according to the man page.\r\n\r\nThe arguments that *I* added will only be populated to vsftpd.conf file if they're not the default values (again according to man page).\r\n"},"comment":{"url":"https://api.github.com/repos/thias/puppet-vsftpd/issues/comments/158530201","html_url":"https://github.com/thias/puppet-vsftpd/pull/17#issuecomment-158530201","issue_url":"https://api.github.com/repos/thias/puppet-vsftpd/issues/17","id":158530201,"user":{"login":"propyless","id":6172961,"avatar_url":"https://avatars.githubusercontent.com/u/6172961?v=3","gravatar_id":"","url":"https://api.github.com/users/propyless","html_url":"https://github.com/propyless","followers_url":"https://api.github.com/users/propyless/followers","following_url":"https://api.github.com/users/propyless/following{/other_user}","gists_url":"https://api.github.com/users/propyless/gists{/gist_id}","starred_url":"https://api.github.com/users/propyless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/propyless/subscriptions","organizations_url":"https://api.github.com/users/propyless/orgs","repos_url":"https://api.github.com/users/propyless/repos","events_url":"https://api.github.com/users/propyless/events{/privacy}","received_events_url":"https://api.github.com/users/propyless/received_events","type":"User","site_admin":false},"created_at":"2015-11-20T21:31:41Z","updated_at":"2015-11-20T21:31:41Z","body":"you can find your pr and my changes to fix some of the duplicate parameters + spec tests here:\r\nhttps://github.com/propyless/puppet-vsftpd"}}