{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/pulls/comments/47487002","id":47487002,"diff_hunk":"@@ -39,7 +39,7 @@\n #include <string.h>\r\n #include \"nordic_common.h\"\r\n #include \"app_error.h\"\r\n-\r\n+#include \"ble.h\"\r","path":"source/nordic_sdk/components/ble/common/ble_srv_common.c","position":16,"original_position":16,"commit_id":"9da4af9c11bd2138b9566f61d6c30ace2302e155","original_commit_id":"9da4af9c11bd2138b9566f61d6c30ace2302e155","user":{"login":"LiyouZhou","id":2660805,"avatar_url":"https://avatars.githubusercontent.com/u/2660805?v=3","gravatar_id":"","url":"https://api.github.com/users/LiyouZhou","html_url":"https://github.com/LiyouZhou","followers_url":"https://api.github.com/users/LiyouZhou/followers","following_url":"https://api.github.com/users/LiyouZhou/following{/other_user}","gists_url":"https://api.github.com/users/LiyouZhou/gists{/gist_id}","starred_url":"https://api.github.com/users/LiyouZhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiyouZhou/subscriptions","organizations_url":"https://api.github.com/users/LiyouZhou/orgs","repos_url":"https://api.github.com/users/LiyouZhou/repos","events_url":"https://api.github.com/users/LiyouZhou/events{/privacy}","received_events_url":"https://api.github.com/users/LiyouZhou/received_events","type":"User","site_admin":false},"body":"@rgrover In theory, all files including ble.h should only find ble.h as BLE.h is not exposed with extraIncludes. All files intending to use BLE.h would use ble/BLE.h. The problem only comes if a file, intending to use BLE.h, uses `#include BLE.h`, on mac os, this can find ble.h instead. ","created_at":"2015-12-14T11:30:29Z","updated_at":"2015-12-14T11:30:29Z","html_url":"https://github.com/ARMmbed/nrf51-sdk/pull/8#discussion_r47487002","pull_request_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/nrf51-sdk/pulls/comments/47487002"},"html":{"href":"https://github.com/ARMmbed/nrf51-sdk/pull/8#discussion_r47487002"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/nrf51-sdk/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/pulls/8","id":53426164,"html_url":"https://github.com/ARMmbed/nrf51-sdk/pull/8","diff_url":"https://github.com/ARMmbed/nrf51-sdk/pull/8.diff","patch_url":"https://github.com/ARMmbed/nrf51-sdk/pull/8.patch","issue_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/issues/8","number":8,"state":"open","locked":false,"title":"Update files to Nordic sdk 9.0.0","user":{"login":"LiyouZhou","id":2660805,"avatar_url":"https://avatars.githubusercontent.com/u/2660805?v=3","gravatar_id":"","url":"https://api.github.com/users/LiyouZhou","html_url":"https://github.com/LiyouZhou","followers_url":"https://api.github.com/users/LiyouZhou/followers","following_url":"https://api.github.com/users/LiyouZhou/following{/other_user}","gists_url":"https://api.github.com/users/LiyouZhou/gists{/gist_id}","starred_url":"https://api.github.com/users/LiyouZhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiyouZhou/subscriptions","organizations_url":"https://api.github.com/users/LiyouZhou/orgs","repos_url":"https://api.github.com/users/LiyouZhou/repos","events_url":"https://api.github.com/users/LiyouZhou/events{/privacy}","received_events_url":"https://api.github.com/users/LiyouZhou/received_events","type":"User","site_admin":false},"body":"Tests:\r\n\r\nclitest - all expected passes pass, all expected fails fail.\r\nbuild - all ble-examples build successfully\r\npstorage - tested against https://github.com/andresag01/ble-examples-1/tree/eddystone_pstorage and works\r\ndfu - tested to work\r\n\r\n@ARMmbed/ble-owners  Please review.","created_at":"2015-12-11T18:21:20Z","updated_at":"2015-12-14T11:30:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2177d0a934256edb23cc1115fee136671b0e3586","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/pulls/8/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/pulls/8/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/issues/8/comments","statuses_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/statuses/9da4af9c11bd2138b9566f61d6c30ace2302e155","head":{"label":"ARMmbed:nordic_sdk_9.0.0","ref":"nordic_sdk_9.0.0","sha":"9da4af9c11bd2138b9566f61d6c30ace2302e155","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":45975419,"name":"nrf51-sdk","full_name":"ARMmbed/nrf51-sdk","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/nrf51-sdk","description":"Module to contain files provided by the nordic nRF51 SDK","fork":false,"url":"https://api.github.com/repos/ARMmbed/nrf51-sdk","forks_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/forks","keys_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/teams","hooks_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/events","assignees_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/tags","blobs_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/subscription","commits_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/merges","archive_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/downloads","issues_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/releases{/id}","created_at":"2015-11-11T10:36:01Z","updated_at":"2015-11-23T21:15:13Z","pushed_at":"2015-12-11T18:21:21Z","git_url":"git://github.com/ARMmbed/nrf51-sdk.git","ssh_url":"git@github.com:ARMmbed/nrf51-sdk.git","clone_url":"https://github.com/ARMmbed/nrf51-sdk.git","svn_url":"https://github.com/ARMmbed/nrf51-sdk","homepage":null,"size":781,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"21d0f023a2b072cdbc138deb3b4d25ae1a54e145","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":45975419,"name":"nrf51-sdk","full_name":"ARMmbed/nrf51-sdk","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/nrf51-sdk","description":"Module to contain files provided by the nordic nRF51 SDK","fork":false,"url":"https://api.github.com/repos/ARMmbed/nrf51-sdk","forks_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/forks","keys_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/teams","hooks_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/events","assignees_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/tags","blobs_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/subscription","commits_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/merges","archive_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/downloads","issues_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/releases{/id}","created_at":"2015-11-11T10:36:01Z","updated_at":"2015-11-23T21:15:13Z","pushed_at":"2015-12-11T18:21:21Z","git_url":"git://github.com/ARMmbed/nrf51-sdk.git","ssh_url":"git@github.com:ARMmbed/nrf51-sdk.git","clone_url":"https://github.com/ARMmbed/nrf51-sdk.git","svn_url":"https://github.com/ARMmbed/nrf51-sdk","homepage":null,"size":781,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/nrf51-sdk/pulls/8"},"html":{"href":"https://github.com/ARMmbed/nrf51-sdk/pull/8"},"issue":{"href":"https://api.github.com/repos/ARMmbed/nrf51-sdk/issues/8"},"comments":{"href":"https://api.github.com/repos/ARMmbed/nrf51-sdk/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/nrf51-sdk/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/nrf51-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/nrf51-sdk/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/nrf51-sdk/statuses/9da4af9c11bd2138b9566f61d6c30ace2302e155"}}}}