{"action":"created","comment":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/comments/34767845","id":34767845,"diff_hunk":"@@ -172,7 +175,11 @@ public DataObject create(DataObject obj, DataStore dataStore) {\n                     if (snapshotDataStoreVO != null) {\n                         ss.setParentSnapshotId(snapshotDataStoreVO.getSnapshotId());\n                     }\n-                    ss.setInstallPath(TemplateConstants.DEFAULT_SNAPSHOT_ROOT_DIR + \"/\" + snapshotDao.findById(obj.getId()).getAccountId() + \"/\" + snapshot.getVolumeId());\n+                    String snapshotInstallPath = TemplateConstants.DEFAULT_SNAPSHOT_ROOT_DIR + \"/\" + snapshotDao.findById(obj.getId()).getAccountId() + \"/\" + snapshot.getVolumeId();\n+                    if (snapshot.getHypervisorType().equals(HypervisorType.VMware)) {\n+                        snapshotInstallPath = snapshotInstallPath.concat(\"/\" + UUID.randomUUID().toString());","path":"engine/storage/src/org/apache/cloudstack/storage/datastore/ObjectInDataStoreManagerImpl.java","position":24,"original_position":24,"commit_id":"da8f25e33ca41057aac26910fe6b667a41adcaa5","original_commit_id":"da8f25e33ca41057aac26910fe6b667a41adcaa5","user":{"login":"wilderrodrigues","id":5129209,"avatar_url":"https://avatars.githubusercontent.com/u/5129209?v=3","gravatar_id":"","url":"https://api.github.com/users/wilderrodrigues","html_url":"https://github.com/wilderrodrigues","followers_url":"https://api.github.com/users/wilderrodrigues/followers","following_url":"https://api.github.com/users/wilderrodrigues/following{/other_user}","gists_url":"https://api.github.com/users/wilderrodrigues/gists{/gist_id}","starred_url":"https://api.github.com/users/wilderrodrigues/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilderrodrigues/subscriptions","organizations_url":"https://api.github.com/users/wilderrodrigues/orgs","repos_url":"https://api.github.com/users/wilderrodrigues/repos","events_url":"https://api.github.com/users/wilderrodrigues/events{/privacy}","received_events_url":"https://api.github.com/users/wilderrodrigues/received_events","type":"User","site_admin":false},"body":"I would also call contact twice: 1 for the \"/\"; and the 2nd time for the UUID.randomUUID().toString().","created_at":"2015-07-16T08:59:39Z","updated_at":"2015-07-16T08:59:39Z","html_url":"https://github.com/apache/cloudstack/pull/540#discussion_r34767845","pull_request_url":"https://api.github.com/repos/apache/cloudstack/pulls/540","_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments/34767845"},"html":{"href":"https://github.com/apache/cloudstack/pull/540#discussion_r34767845"},"pull_request":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/540"}}},"pull_request":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/540","id":38846752,"html_url":"https://github.com/apache/cloudstack/pull/540","diff_url":"https://github.com/apache/cloudstack/pull/540.diff","patch_url":"https://github.com/apache/cloudstack/pull/540.patch","issue_url":"https://api.github.com/repos/apache/cloudstack/issues/540","number":540,"state":"open","locked":false,"title":"CLOUDSTACK-8415. SSVM shutdown during snapshot operation leaves behin…","user":{"login":"likitha","id":1097805,"avatar_url":"https://avatars.githubusercontent.com/u/1097805?v=3","gravatar_id":"","url":"https://api.github.com/users/likitha","html_url":"https://github.com/likitha","followers_url":"https://api.github.com/users/likitha/followers","following_url":"https://api.github.com/users/likitha/following{/other_user}","gists_url":"https://api.github.com/users/likitha/gists{/gist_id}","starred_url":"https://api.github.com/users/likitha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/likitha/subscriptions","organizations_url":"https://api.github.com/users/likitha/orgs","repos_url":"https://api.github.com/users/likitha/repos","events_url":"https://api.github.com/users/likitha/events{/privacy}","received_events_url":"https://api.github.com/users/likitha/received_events","type":"User","site_admin":false},"body":"…d partial unusable disks and VM snapshots in secondary storage.\r\n\r\nEnhance storage garbage collector to delete corresponding partial disks created in secondary storage and VM snapshots while expunging 'ERROR' snapshot.","created_at":"2015-06-30T06:40:24Z","updated_at":"2015-07-16T08:59:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9d506c20b3b9283a218c52d2c1c310c76761a3e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/cloudstack/pulls/540/commits","review_comments_url":"https://api.github.com/repos/apache/cloudstack/pulls/540/comments","review_comment_url":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/cloudstack/issues/540/comments","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/da8f25e33ca41057aac26910fe6b667a41adcaa5","head":{"label":"likitha:CLOUDSTACK-8415","ref":"CLOUDSTACK-8415","sha":"da8f25e33ca41057aac26910fe6b667a41adcaa5","user":{"login":"likitha","id":1097805,"avatar_url":"https://avatars.githubusercontent.com/u/1097805?v=3","gravatar_id":"","url":"https://api.github.com/users/likitha","html_url":"https://github.com/likitha","followers_url":"https://api.github.com/users/likitha/followers","following_url":"https://api.github.com/users/likitha/following{/other_user}","gists_url":"https://api.github.com/users/likitha/gists{/gist_id}","starred_url":"https://api.github.com/users/likitha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/likitha/subscriptions","organizations_url":"https://api.github.com/users/likitha/orgs","repos_url":"https://api.github.com/users/likitha/repos","events_url":"https://api.github.com/users/likitha/events{/privacy}","received_events_url":"https://api.github.com/users/likitha/received_events","type":"User","site_admin":false},"repo":{"id":22669343,"name":"cloudstack","full_name":"likitha/cloudstack","owner":{"login":"likitha","id":1097805,"avatar_url":"https://avatars.githubusercontent.com/u/1097805?v=3","gravatar_id":"","url":"https://api.github.com/users/likitha","html_url":"https://github.com/likitha","followers_url":"https://api.github.com/users/likitha/followers","following_url":"https://api.github.com/users/likitha/following{/other_user}","gists_url":"https://api.github.com/users/likitha/gists{/gist_id}","starred_url":"https://api.github.com/users/likitha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/likitha/subscriptions","organizations_url":"https://api.github.com/users/likitha/orgs","repos_url":"https://api.github.com/users/likitha/repos","events_url":"https://api.github.com/users/likitha/events{/privacy}","received_events_url":"https://api.github.com/users/likitha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/likitha/cloudstack","description":"Mirror of Apache Cloudstack","fork":true,"url":"https://api.github.com/repos/likitha/cloudstack","forks_url":"https://api.github.com/repos/likitha/cloudstack/forks","keys_url":"https://api.github.com/repos/likitha/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/likitha/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/likitha/cloudstack/teams","hooks_url":"https://api.github.com/repos/likitha/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/likitha/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/likitha/cloudstack/events","assignees_url":"https://api.github.com/repos/likitha/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/likitha/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/likitha/cloudstack/tags","blobs_url":"https://api.github.com/repos/likitha/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/likitha/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/likitha/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/likitha/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/likitha/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/likitha/cloudstack/languages","stargazers_url":"https://api.github.com/repos/likitha/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/likitha/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/likitha/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/likitha/cloudstack/subscription","commits_url":"https://api.github.com/repos/likitha/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/likitha/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/likitha/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/likitha/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/likitha/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/likitha/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/likitha/cloudstack/merges","archive_url":"https://api.github.com/repos/likitha/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/likitha/cloudstack/downloads","issues_url":"https://api.github.com/repos/likitha/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/likitha/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/likitha/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/likitha/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/likitha/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/likitha/cloudstack/releases{/id}","created_at":"2014-08-06T04:11:44Z","updated_at":"2015-06-30T09:06:53Z","pushed_at":"2015-07-06T06:26:48Z","git_url":"git://github.com/likitha/cloudstack.git","ssh_url":"git@github.com:likitha/cloudstack.git","clone_url":"https://github.com/likitha/cloudstack.git","svn_url":"https://github.com/likitha/cloudstack","homepage":null,"size":481696,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"02c3d14f6ebef56c21a56297c82eda4deb0c7855","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":9759448,"name":"cloudstack","full_name":"apache/cloudstack","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/cloudstack","description":"Mirror of Apache Cloudstack","fork":false,"url":"https://api.github.com/repos/apache/cloudstack","forks_url":"https://api.github.com/repos/apache/cloudstack/forks","keys_url":"https://api.github.com/repos/apache/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/cloudstack/teams","hooks_url":"https://api.github.com/repos/apache/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/apache/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/apache/cloudstack/events","assignees_url":"https://api.github.com/repos/apache/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/apache/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/apache/cloudstack/tags","blobs_url":"https://api.github.com/repos/apache/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/cloudstack/languages","stargazers_url":"https://api.github.com/repos/apache/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/apache/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/apache/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/apache/cloudstack/subscription","commits_url":"https://api.github.com/repos/apache/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/apache/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/cloudstack/merges","archive_url":"https://api.github.com/repos/apache/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/cloudstack/downloads","issues_url":"https://api.github.com/repos/apache/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/apache/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/apache/cloudstack/releases{/id}","created_at":"2013-04-29T22:27:12Z","updated_at":"2015-07-15T23:40:48Z","pushed_at":"2015-07-16T08:45:32Z","git_url":"git://github.com/apache/cloudstack.git","ssh_url":"git@github.com:apache/cloudstack.git","clone_url":"https://github.com/apache/cloudstack.git","svn_url":"https://github.com/apache/cloudstack","homepage":null,"size":743042,"stargazers_count":261,"watchers_count":261,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":324,"mirror_url":"git://git.apache.org/cloudstack.git","open_issues_count":28,"forks":324,"open_issues":28,"watchers":261,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/540"},"html":{"href":"https://github.com/apache/cloudstack/pull/540"},"issue":{"href":"https://api.github.com/repos/apache/cloudstack/issues/540"},"comments":{"href":"https://api.github.com/repos/apache/cloudstack/issues/540/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/540/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/540/commits"},"statuses":{"href":"https://api.github.com/repos/apache/cloudstack/statuses/da8f25e33ca41057aac26910fe6b667a41adcaa5"}}}}