{"action":"created","issue":{"url":"https://api.github.com/repos/HubSpot/shepherd/issues/62","labels_url":"https://api.github.com/repos/HubSpot/shepherd/issues/62/labels{/name}","comments_url":"https://api.github.com/repos/HubSpot/shepherd/issues/62/comments","events_url":"https://api.github.com/repos/HubSpot/shepherd/issues/62/events","html_url":"https://github.com/HubSpot/shepherd/issues/62","id":78016842,"number":62,"title":"Leftover event handlers when tour has ended","user":{"login":"afoda","id":1595170,"avatar_url":"https://avatars.githubusercontent.com/u/1595170?v=3","gravatar_id":"","url":"https://api.github.com/users/afoda","html_url":"https://github.com/afoda","followers_url":"https://api.github.com/users/afoda/followers","following_url":"https://api.github.com/users/afoda/following{/other_user}","gists_url":"https://api.github.com/users/afoda/gists{/gist_id}","starred_url":"https://api.github.com/users/afoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afoda/subscriptions","organizations_url":"https://api.github.com/users/afoda/orgs","repos_url":"https://api.github.com/users/afoda/repos","events_url":"https://api.github.com/users/afoda/events{/privacy}","received_events_url":"https://api.github.com/users/afoda/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-05-19T09:45:28Z","updated_at":"2015-06-17T16:55:36Z","closed_at":"2015-06-17T15:35:06Z","body":"In `Step.prototype._show`, when `this.el == null` a call is made to `render` which calls `setupTether`. Then, `_show` calls `setupTether` again.\r\n\r\nBoth calls to `setupTether` add event handlers to the scrollParent, but only the second copies are removed when the step is destroyed. Therefore there are leftover event handlers when the tour has ended.\r\n\r\nI think modifying `_show` so that `setupTether` is only called when `render` is not would solve the issue. Happy to create a pull request to that effect."},"comment":{"url":"https://api.github.com/repos/HubSpot/shepherd/issues/comments/112875745","html_url":"https://github.com/HubSpot/shepherd/issues/62#issuecomment-112875745","issue_url":"https://api.github.com/repos/HubSpot/shepherd/issues/62","id":112875745,"user":{"login":"opusonline","id":484618,"avatar_url":"https://avatars.githubusercontent.com/u/484618?v=3","gravatar_id":"","url":"https://api.github.com/users/opusonline","html_url":"https://github.com/opusonline","followers_url":"https://api.github.com/users/opusonline/followers","following_url":"https://api.github.com/users/opusonline/following{/other_user}","gists_url":"https://api.github.com/users/opusonline/gists{/gist_id}","starred_url":"https://api.github.com/users/opusonline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opusonline/subscriptions","organizations_url":"https://api.github.com/users/opusonline/orgs","repos_url":"https://api.github.com/users/opusonline/repos","events_url":"https://api.github.com/users/opusonline/events{/privacy}","received_events_url":"https://api.github.com/users/opusonline/received_events","type":"User","site_admin":false},"created_at":"2015-06-17T16:55:36Z","updated_at":"2015-06-17T16:55:36Z","body":"@geekjuice \r\nHere's the fiddle:\r\nhttps://jsfiddle.net/u28bv7uy/1/\r\n\r\n(Sorry, I had to add the complete js and css source, because I had no appropriate server for loading thos needed libraries - written code is at the end)"}}