{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/stetho/issues/219","labels_url":"https://api.github.com/repos/facebook/stetho/issues/219/labels{/name}","comments_url":"https://api.github.com/repos/facebook/stetho/issues/219/comments","events_url":"https://api.github.com/repos/facebook/stetho/issues/219/events","html_url":"https://github.com/facebook/stetho/pull/219","id":93924321,"number":219,"title":"add interfaces and registry for async pretty print","user":{"login":"mengdilin","id":2306593,"avatar_url":"https://avatars.githubusercontent.com/u/2306593?v=3","gravatar_id":"","url":"https://api.github.com/users/mengdilin","html_url":"https://github.com/mengdilin","followers_url":"https://api.github.com/users/mengdilin/followers","following_url":"https://api.github.com/users/mengdilin/following{/other_user}","gists_url":"https://api.github.com/users/mengdilin/gists{/gist_id}","starred_url":"https://api.github.com/users/mengdilin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mengdilin/subscriptions","organizations_url":"https://api.github.com/users/mengdilin/orgs","repos_url":"https://api.github.com/users/mengdilin/repos","events_url":"https://api.github.com/users/mengdilin/events{/privacy}","received_events_url":"https://api.github.com/users/mengdilin/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/stetho/labels/CLA%20Signed","name":"CLA Signed","color":"009900"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-07-09T00:58:52Z","updated_at":"2015-07-24T17:01:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/stetho/pulls/219","html_url":"https://github.com/facebook/stetho/pull/219","diff_url":"https://github.com/facebook/stetho/pull/219.diff","patch_url":"https://github.com/facebook/stetho/pull/219.patch"},"body":"This commit adds two interfaces to be used for AsyncPrettyPrinter. It also adds DefaultAsyncPrettyPrinterRegistry which will be used to register header name to their respective async pretty printers. Right now, in responseHeadersReceived method from NetworkEventReporterImpl, the registry will look up the response header and return a factory which creates an instance of async pretty printer. This pretty printer is added to a map in responseBodyFileManager class with the response request id as the key. Once readFile is called by Network, readFile will use the pretty printer if there exists such a printer in the map. "},"comment":{"url":"https://api.github.com/repos/facebook/stetho/issues/comments/124579434","html_url":"https://github.com/facebook/stetho/pull/219#issuecomment-124579434","issue_url":"https://api.github.com/repos/facebook/stetho/issues/219","id":124579434,"user":{"login":"mengdilin","id":2306593,"avatar_url":"https://avatars.githubusercontent.com/u/2306593?v=3","gravatar_id":"","url":"https://api.github.com/users/mengdilin","html_url":"https://github.com/mengdilin","followers_url":"https://api.github.com/users/mengdilin/followers","following_url":"https://api.github.com/users/mengdilin/following{/other_user}","gists_url":"https://api.github.com/users/mengdilin/gists{/gist_id}","starred_url":"https://api.github.com/users/mengdilin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mengdilin/subscriptions","organizations_url":"https://api.github.com/users/mengdilin/orgs","repos_url":"https://api.github.com/users/mengdilin/repos","events_url":"https://api.github.com/users/mengdilin/events{/privacy}","received_events_url":"https://api.github.com/users/mengdilin/received_events","type":"User","site_admin":false},"created_at":"2015-07-24T17:01:09Z","updated_at":"2015-07-24T17:01:09Z","body":"Hi Yamateh, the pull request is actually incomplete as of now (was looking for code reviews for what I already had from Rick and Josh). Asynchronous download of schema from the AbstractPrettyPrinterFactory class still needs to be implemented. "}}