{"action":"created","comment":{"url":"https://api.github.com/repos/hadley/lazyeval/pulls/comments/29556374","id":29556374,"diff_hunk":"@@ -28,12 +30,32 @@\n #' l[\"z\"] <- list(~g)\n #'\n #' c(lazy_dots(x = 1), lazy_dots(f))\n-lazy_dots <- function(..., .follow_symbols = FALSE) {\n-  if (nargs() == 0 || (nargs() == 1 &&  ! missing(.follow_symbols))) {\n+#'\n+#' # The last argument will be dropped by default if it is missing,\n+#' # this makes the terminal semicolon optional:\n+#' lazy_dots(1, )\n+#' lazy_dots(1)\n+#' lazy_dots(.drop_last_if_empty = FALSE, 1, )\n+lazy_dots <- function(..., .follow_symbols = FALSE,\n+                      .drop_last_if_empty = TRUE) {\n+  # Count number of arguments in ...\n+  n_args <- nargs() - !missing(.follow_symbols) - !missing(.drop_last_if_empty)\n+  if (n_args == 0) {\n     return(structure(list(), class = \"lazy_dots\"))","path":"R/lazy-dots.R","position":26,"original_position":26,"commit_id":"c79645b7f7fecb568da418ad73c4c4cb31fc9c98","original_commit_id":"c79645b7f7fecb568da418ad73c4c4cb31fc9c98","user":{"login":"krlmlr","id":1741643,"avatar_url":"https://avatars.githubusercontent.com/u/1741643?v=3","gravatar_id":"","url":"https://api.github.com/users/krlmlr","html_url":"https://github.com/krlmlr","followers_url":"https://api.github.com/users/krlmlr/followers","following_url":"https://api.github.com/users/krlmlr/following{/other_user}","gists_url":"https://api.github.com/users/krlmlr/gists{/gist_id}","starred_url":"https://api.github.com/users/krlmlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krlmlr/subscriptions","organizations_url":"https://api.github.com/users/krlmlr/orgs","repos_url":"https://api.github.com/users/krlmlr/repos","events_url":"https://api.github.com/users/krlmlr/events{/privacy}","received_events_url":"https://api.github.com/users/krlmlr/received_events","type":"User","site_admin":false},"body":"If I remove this shortcut, the test runs indefinitely on my machine. Still, the code would look cleaner without the special treatment of an empty argument list.","created_at":"2015-05-03T14:04:25Z","updated_at":"2015-05-03T14:04:25Z","html_url":"https://github.com/hadley/lazyeval/pull/32#discussion_r29556374","pull_request_url":"https://api.github.com/repos/hadley/lazyeval/pulls/32","_links":{"self":{"href":"https://api.github.com/repos/hadley/lazyeval/pulls/comments/29556374"},"html":{"href":"https://github.com/hadley/lazyeval/pull/32#discussion_r29556374"},"pull_request":{"href":"https://api.github.com/repos/hadley/lazyeval/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/hadley/lazyeval/pulls/32","id":34080920,"html_url":"https://github.com/hadley/lazyeval/pull/32","diff_url":"https://github.com/hadley/lazyeval/pull/32.diff","patch_url":"https://github.com/hadley/lazyeval/pull/32.patch","issue_url":"https://api.github.com/repos/hadley/lazyeval/issues/32","number":32,"state":"open","locked":false,"title":"WIP: Gobble last argument if it is empty","user":{"login":"krlmlr","id":1741643,"avatar_url":"https://avatars.githubusercontent.com/u/1741643?v=3","gravatar_id":"","url":"https://api.github.com/users/krlmlr","html_url":"https://github.com/krlmlr","followers_url":"https://api.github.com/users/krlmlr/followers","following_url":"https://api.github.com/users/krlmlr/following{/other_user}","gists_url":"https://api.github.com/users/krlmlr/gists{/gist_id}","starred_url":"https://api.github.com/users/krlmlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krlmlr/subscriptions","organizations_url":"https://api.github.com/users/krlmlr/orgs","repos_url":"https://api.github.com/users/krlmlr/repos","events_url":"https://api.github.com/users/krlmlr/events{/privacy}","received_events_url":"https://api.github.com/users/krlmlr/received_events","type":"User","site_admin":false},"body":"See discussion in https://github.com/hadley/dplyr/issues/1039\n\nThis still needs some polishing -- probably most functions that accept `...` should be updated. Feedback welcome.","created_at":"2015-04-24T19:57:55Z","updated_at":"2015-05-03T14:04:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81f2e4e47cf05c32f1b6e93c4d06c9f52eb7eaf2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hadley/lazyeval/pulls/32/commits","review_comments_url":"https://api.github.com/repos/hadley/lazyeval/pulls/32/comments","review_comment_url":"https://api.github.com/repos/hadley/lazyeval/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hadley/lazyeval/issues/32/comments","statuses_url":"https://api.github.com/repos/hadley/lazyeval/statuses/c79645b7f7fecb568da418ad73c4c4cb31fc9c98","head":{"label":"krlmlr:gobble-last","ref":"gobble-last","sha":"c79645b7f7fecb568da418ad73c4c4cb31fc9c98","user":{"login":"krlmlr","id":1741643,"avatar_url":"https://avatars.githubusercontent.com/u/1741643?v=3","gravatar_id":"","url":"https://api.github.com/users/krlmlr","html_url":"https://github.com/krlmlr","followers_url":"https://api.github.com/users/krlmlr/followers","following_url":"https://api.github.com/users/krlmlr/following{/other_user}","gists_url":"https://api.github.com/users/krlmlr/gists{/gist_id}","starred_url":"https://api.github.com/users/krlmlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krlmlr/subscriptions","organizations_url":"https://api.github.com/users/krlmlr/orgs","repos_url":"https://api.github.com/users/krlmlr/repos","events_url":"https://api.github.com/users/krlmlr/events{/privacy}","received_events_url":"https://api.github.com/users/krlmlr/received_events","type":"User","site_admin":false},"repo":{"id":34538188,"name":"lazyeval","full_name":"krlmlr/lazyeval","owner":{"login":"krlmlr","id":1741643,"avatar_url":"https://avatars.githubusercontent.com/u/1741643?v=3","gravatar_id":"","url":"https://api.github.com/users/krlmlr","html_url":"https://github.com/krlmlr","followers_url":"https://api.github.com/users/krlmlr/followers","following_url":"https://api.github.com/users/krlmlr/following{/other_user}","gists_url":"https://api.github.com/users/krlmlr/gists{/gist_id}","starred_url":"https://api.github.com/users/krlmlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krlmlr/subscriptions","organizations_url":"https://api.github.com/users/krlmlr/orgs","repos_url":"https://api.github.com/users/krlmlr/repos","events_url":"https://api.github.com/users/krlmlr/events{/privacy}","received_events_url":"https://api.github.com/users/krlmlr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krlmlr/lazyeval","description":"A strategy for doing non-standard evaluation (NSE) in R","fork":true,"url":"https://api.github.com/repos/krlmlr/lazyeval","forks_url":"https://api.github.com/repos/krlmlr/lazyeval/forks","keys_url":"https://api.github.com/repos/krlmlr/lazyeval/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krlmlr/lazyeval/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krlmlr/lazyeval/teams","hooks_url":"https://api.github.com/repos/krlmlr/lazyeval/hooks","issue_events_url":"https://api.github.com/repos/krlmlr/lazyeval/issues/events{/number}","events_url":"https://api.github.com/repos/krlmlr/lazyeval/events","assignees_url":"https://api.github.com/repos/krlmlr/lazyeval/assignees{/user}","branches_url":"https://api.github.com/repos/krlmlr/lazyeval/branches{/branch}","tags_url":"https://api.github.com/repos/krlmlr/lazyeval/tags","blobs_url":"https://api.github.com/repos/krlmlr/lazyeval/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krlmlr/lazyeval/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krlmlr/lazyeval/git/refs{/sha}","trees_url":"https://api.github.com/repos/krlmlr/lazyeval/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krlmlr/lazyeval/statuses/{sha}","languages_url":"https://api.github.com/repos/krlmlr/lazyeval/languages","stargazers_url":"https://api.github.com/repos/krlmlr/lazyeval/stargazers","contributors_url":"https://api.github.com/repos/krlmlr/lazyeval/contributors","subscribers_url":"https://api.github.com/repos/krlmlr/lazyeval/subscribers","subscription_url":"https://api.github.com/repos/krlmlr/lazyeval/subscription","commits_url":"https://api.github.com/repos/krlmlr/lazyeval/commits{/sha}","git_commits_url":"https://api.github.com/repos/krlmlr/lazyeval/git/commits{/sha}","comments_url":"https://api.github.com/repos/krlmlr/lazyeval/comments{/number}","issue_comment_url":"https://api.github.com/repos/krlmlr/lazyeval/issues/comments{/number}","contents_url":"https://api.github.com/repos/krlmlr/lazyeval/contents/{+path}","compare_url":"https://api.github.com/repos/krlmlr/lazyeval/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krlmlr/lazyeval/merges","archive_url":"https://api.github.com/repos/krlmlr/lazyeval/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krlmlr/lazyeval/downloads","issues_url":"https://api.github.com/repos/krlmlr/lazyeval/issues{/number}","pulls_url":"https://api.github.com/repos/krlmlr/lazyeval/pulls{/number}","milestones_url":"https://api.github.com/repos/krlmlr/lazyeval/milestones{/number}","notifications_url":"https://api.github.com/repos/krlmlr/lazyeval/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krlmlr/lazyeval/labels{/name}","releases_url":"https://api.github.com/repos/krlmlr/lazyeval/releases{/id}","created_at":"2015-04-24T19:42:36Z","updated_at":"2015-04-24T19:42:36Z","pushed_at":"2015-05-03T13:58:00Z","git_url":"git://github.com/krlmlr/lazyeval.git","ssh_url":"git@github.com:krlmlr/lazyeval.git","clone_url":"https://github.com/krlmlr/lazyeval.git","svn_url":"https://github.com/krlmlr/lazyeval","homepage":null,"size":172,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hadley:master","ref":"master","sha":"ecb8dc015250b2a8c8e5952f8d0d0243c947d2f6","user":{"login":"hadley","id":4196,"avatar_url":"https://avatars.githubusercontent.com/u/4196?v=3","gravatar_id":"","url":"https://api.github.com/users/hadley","html_url":"https://github.com/hadley","followers_url":"https://api.github.com/users/hadley/followers","following_url":"https://api.github.com/users/hadley/following{/other_user}","gists_url":"https://api.github.com/users/hadley/gists{/gist_id}","starred_url":"https://api.github.com/users/hadley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hadley/subscriptions","organizations_url":"https://api.github.com/users/hadley/orgs","repos_url":"https://api.github.com/users/hadley/repos","events_url":"https://api.github.com/users/hadley/events{/privacy}","received_events_url":"https://api.github.com/users/hadley/received_events","type":"User","site_admin":false},"repo":{"id":22881786,"name":"lazyeval","full_name":"hadley/lazyeval","owner":{"login":"hadley","id":4196,"avatar_url":"https://avatars.githubusercontent.com/u/4196?v=3","gravatar_id":"","url":"https://api.github.com/users/hadley","html_url":"https://github.com/hadley","followers_url":"https://api.github.com/users/hadley/followers","following_url":"https://api.github.com/users/hadley/following{/other_user}","gists_url":"https://api.github.com/users/hadley/gists{/gist_id}","starred_url":"https://api.github.com/users/hadley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hadley/subscriptions","organizations_url":"https://api.github.com/users/hadley/orgs","repos_url":"https://api.github.com/users/hadley/repos","events_url":"https://api.github.com/users/hadley/events{/privacy}","received_events_url":"https://api.github.com/users/hadley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hadley/lazyeval","description":"A strategy for doing non-standard evaluation (NSE) in R","fork":false,"url":"https://api.github.com/repos/hadley/lazyeval","forks_url":"https://api.github.com/repos/hadley/lazyeval/forks","keys_url":"https://api.github.com/repos/hadley/lazyeval/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hadley/lazyeval/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hadley/lazyeval/teams","hooks_url":"https://api.github.com/repos/hadley/lazyeval/hooks","issue_events_url":"https://api.github.com/repos/hadley/lazyeval/issues/events{/number}","events_url":"https://api.github.com/repos/hadley/lazyeval/events","assignees_url":"https://api.github.com/repos/hadley/lazyeval/assignees{/user}","branches_url":"https://api.github.com/repos/hadley/lazyeval/branches{/branch}","tags_url":"https://api.github.com/repos/hadley/lazyeval/tags","blobs_url":"https://api.github.com/repos/hadley/lazyeval/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hadley/lazyeval/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hadley/lazyeval/git/refs{/sha}","trees_url":"https://api.github.com/repos/hadley/lazyeval/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hadley/lazyeval/statuses/{sha}","languages_url":"https://api.github.com/repos/hadley/lazyeval/languages","stargazers_url":"https://api.github.com/repos/hadley/lazyeval/stargazers","contributors_url":"https://api.github.com/repos/hadley/lazyeval/contributors","subscribers_url":"https://api.github.com/repos/hadley/lazyeval/subscribers","subscription_url":"https://api.github.com/repos/hadley/lazyeval/subscription","commits_url":"https://api.github.com/repos/hadley/lazyeval/commits{/sha}","git_commits_url":"https://api.github.com/repos/hadley/lazyeval/git/commits{/sha}","comments_url":"https://api.github.com/repos/hadley/lazyeval/comments{/number}","issue_comment_url":"https://api.github.com/repos/hadley/lazyeval/issues/comments{/number}","contents_url":"https://api.github.com/repos/hadley/lazyeval/contents/{+path}","compare_url":"https://api.github.com/repos/hadley/lazyeval/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hadley/lazyeval/merges","archive_url":"https://api.github.com/repos/hadley/lazyeval/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hadley/lazyeval/downloads","issues_url":"https://api.github.com/repos/hadley/lazyeval/issues{/number}","pulls_url":"https://api.github.com/repos/hadley/lazyeval/pulls{/number}","milestones_url":"https://api.github.com/repos/hadley/lazyeval/milestones{/number}","notifications_url":"https://api.github.com/repos/hadley/lazyeval/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hadley/lazyeval/labels{/name}","releases_url":"https://api.github.com/repos/hadley/lazyeval/releases{/id}","created_at":"2014-08-12T15:06:43Z","updated_at":"2015-04-11T22:28:52Z","pushed_at":"2015-05-03T13:58:01Z","git_url":"git://github.com/hadley/lazyeval.git","ssh_url":"git@github.com:hadley/lazyeval.git","clone_url":"https://github.com/hadley/lazyeval.git","svn_url":"https://github.com/hadley/lazyeval","homepage":null,"size":584,"stargazers_count":35,"watchers_count":35,"language":"R","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":9,"forks":12,"open_issues":9,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hadley/lazyeval/pulls/32"},"html":{"href":"https://github.com/hadley/lazyeval/pull/32"},"issue":{"href":"https://api.github.com/repos/hadley/lazyeval/issues/32"},"comments":{"href":"https://api.github.com/repos/hadley/lazyeval/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/hadley/lazyeval/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/hadley/lazyeval/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hadley/lazyeval/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/hadley/lazyeval/statuses/c79645b7f7fecb568da418ad73c4c4cb31fc9c98"}}}}