{"action":"created","issue":{"url":"https://api.github.com/repos/garethr/garethr-docker/issues/354","labels_url":"https://api.github.com/repos/garethr/garethr-docker/issues/354/labels{/name}","comments_url":"https://api.github.com/repos/garethr/garethr-docker/issues/354/comments","events_url":"https://api.github.com/repos/garethr/garethr-docker/issues/354/events","html_url":"https://github.com/garethr/garethr-docker/pull/354","id":108978104,"number":354,"title":"added bridge_ip option","user":{"login":"ptinsley","id":432616,"avatar_url":"https://avatars.githubusercontent.com/u/432616?v=3","gravatar_id":"","url":"https://api.github.com/users/ptinsley","html_url":"https://github.com/ptinsley","followers_url":"https://api.github.com/users/ptinsley/followers","following_url":"https://api.github.com/users/ptinsley/following{/other_user}","gists_url":"https://api.github.com/users/ptinsley/gists{/gist_id}","starred_url":"https://api.github.com/users/ptinsley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptinsley/subscriptions","organizations_url":"https://api.github.com/users/ptinsley/orgs","repos_url":"https://api.github.com/users/ptinsley/repos","events_url":"https://api.github.com/users/ptinsley/events{/privacy}","received_events_url":"https://api.github.com/users/ptinsley/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-29T23:06:47Z","updated_at":"2015-10-07T17:14:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/garethr/garethr-docker/pulls/354","html_url":"https://github.com/garethr/garethr-docker/pull/354","diff_url":"https://github.com/garethr/garethr-docker/pull/354.diff","patch_url":"https://github.com/garethr/garethr-docker/pull/354.patch"},"body":"the default docker subnet was a conflict in our environment. Added a bridge_ip option to make it easy to change that setting."},"comment":{"url":"https://api.github.com/repos/garethr/garethr-docker/issues/comments/146265768","html_url":"https://github.com/garethr/garethr-docker/pull/354#issuecomment-146265768","issue_url":"https://api.github.com/repos/garethr/garethr-docker/issues/354","id":146265768,"user":{"login":"garethr","id":2029,"avatar_url":"https://avatars.githubusercontent.com/u/2029?v=3","gravatar_id":"","url":"https://api.github.com/users/garethr","html_url":"https://github.com/garethr","followers_url":"https://api.github.com/users/garethr/followers","following_url":"https://api.github.com/users/garethr/following{/other_user}","gists_url":"https://api.github.com/users/garethr/gists{/gist_id}","starred_url":"https://api.github.com/users/garethr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethr/subscriptions","organizations_url":"https://api.github.com/users/garethr/orgs","repos_url":"https://api.github.com/users/garethr/repos","events_url":"https://api.github.com/users/garethr/events{/privacy}","received_events_url":"https://api.github.com/users/garethr/received_events","type":"User","site_admin":false},"created_at":"2015-10-07T17:14:31Z","updated_at":"2015-10-07T17:14:31Z","body":"Hi @ptinsley. This looks good, thanks for the addition. Just a couple of points:\r\n\r\n* Could you swuash the commits into one commit? It's really just a single logical change.\r\n* Would you be able to add a simple rspec-puppet test? The existing test suite and the details in the CONTRIBUTING doc should help but do feel free to ask questions\r\n "}}