{"action":"created","issue":{"url":"https://api.github.com/repos/aickin/react-dom-stream/issues/2","labels_url":"https://api.github.com/repos/aickin/react-dom-stream/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/aickin/react-dom-stream/issues/2/comments","events_url":"https://api.github.com/repos/aickin/react-dom-stream/issues/2/events","html_url":"https://github.com/aickin/react-dom-stream/issues/2","id":112539592,"number":2,"title":"Change API to return a stream with a hash Promise property.","user":{"login":"pgte","id":47910,"avatar_url":"https://avatars.githubusercontent.com/u/47910?v=3","gravatar_id":"","url":"https://api.github.com/users/pgte","html_url":"https://github.com/pgte","followers_url":"https://api.github.com/users/pgte/followers","following_url":"https://api.github.com/users/pgte/following{/other_user}","gists_url":"https://api.github.com/users/pgte/gists{/gist_id}","starred_url":"https://api.github.com/users/pgte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgte/subscriptions","organizations_url":"https://api.github.com/users/pgte/orgs","repos_url":"https://api.github.com/users/pgte/repos","events_url":"https://api.github.com/users/pgte/events{/privacy}","received_events_url":"https://api.github.com/users/pgte/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":20,"created_at":"2015-10-21T08:47:45Z","updated_at":"2015-10-26T23:09:50Z","closed_at":null,"body":"Instead of passing the destination stream into the function call, why not returning a readable stream that you can pipe?"},"comment":{"url":"https://api.github.com/repos/aickin/react-dom-stream/issues/comments/151310301","html_url":"https://github.com/aickin/react-dom-stream/issues/2#issuecomment-151310301","issue_url":"https://api.github.com/repos/aickin/react-dom-stream/issues/2","id":151310301,"user":{"login":"aickin","id":44199,"avatar_url":"https://avatars.githubusercontent.com/u/44199?v=3","gravatar_id":"","url":"https://api.github.com/users/aickin","html_url":"https://github.com/aickin","followers_url":"https://api.github.com/users/aickin/followers","following_url":"https://api.github.com/users/aickin/following{/other_user}","gists_url":"https://api.github.com/users/aickin/gists{/gist_id}","starred_url":"https://api.github.com/users/aickin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aickin/subscriptions","organizations_url":"https://api.github.com/users/aickin/orgs","repos_url":"https://api.github.com/users/aickin/repos","events_url":"https://api.github.com/users/aickin/events{/privacy}","received_events_url":"https://api.github.com/users/aickin/received_events","type":"User","site_admin":false},"created_at":"2015-10-26T23:09:50Z","updated_at":"2015-10-26T23:09:50Z","body":"Update: Inspired by this issue, I rewrote the react fork from the ground up with streams behaving as they are supposed to, and I was hoping to release it today, but I ran into a really sticky problem. It seems that piping a Readable to the `res` output stream in Express is several times slower than the strategy I was using for v0.1.x: batching writes and passing through to `res.write`. \r\n\r\nI've written a simple test case that doesn't use any of my react-dom-stream code, and batched writes to `res` beat a piped Readable stream by 614% in a server siege. I'm a bit stuck and would appreciate any help from folks on this thread who are more knowledgeable than I am. I'm also packaging my test case so that I can send it around and hopefully get some feedback on it."}}