{"action":"created","comment":{"url":"https://api.github.com/repos/fsprojects/Paket/pulls/comments/28137423","id":28137423,"diff_hunk":"@@ -184,7 +184,8 @@ module NugetEnv =\n                   Packages = [for node in doc.SelectNodes(\"//package\") ->\n                                     { Id = node.Attributes.[\"id\"].Value\n                                       Version = node.Attributes.[\"version\"].Value |> SemVer.Parse\n-                                      TargetFramework = node |> getAttribute \"targetFramework\" } ]}\n+                                      TargetFramework = \n+                                        node |> getAttribute \"targetFramework\" |> Option.map (fun t -> \">= \" + t) } ]}","path":"src/Paket.Core/NugetConvert.fs","position":6,"original_position":6,"commit_id":"34371b0cfdd4072921a7d06866da9934b3d46ae2","original_commit_id":"34371b0cfdd4072921a7d06866da9934b3d46ae2","user":{"login":"theimowski","id":5909015,"avatar_url":"https://avatars.githubusercontent.com/u/5909015?v=3","gravatar_id":"","url":"https://api.github.com/users/theimowski","html_url":"https://github.com/theimowski","followers_url":"https://api.github.com/users/theimowski/followers","following_url":"https://api.github.com/users/theimowski/following{/other_user}","gists_url":"https://api.github.com/users/theimowski/gists{/gist_id}","starred_url":"https://api.github.com/users/theimowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theimowski/subscriptions","organizations_url":"https://api.github.com/users/theimowski/orgs","repos_url":"https://api.github.com/users/theimowski/repos","events_url":"https://api.github.com/users/theimowski/events{/privacy}","received_events_url":"https://api.github.com/users/theimowski/received_events","type":"User","site_admin":false},"body":"so this is actually the only change necessary? i.e. we don't need to call the `optimizeRestrictions` function?","created_at":"2015-04-10T11:17:38Z","updated_at":"2015-04-10T11:17:38Z","html_url":"https://github.com/fsprojects/Paket/pull/768#discussion_r28137423","pull_request_url":"https://api.github.com/repos/fsprojects/Paket/pulls/768","_links":{"self":{"href":"https://api.github.com/repos/fsprojects/Paket/pulls/comments/28137423"},"html":{"href":"https://github.com/fsprojects/Paket/pull/768#discussion_r28137423"},"pull_request":{"href":"https://api.github.com/repos/fsprojects/Paket/pulls/768"}}},"pull_request":{"url":"https://api.github.com/repos/fsprojects/Paket/pulls/768","id":33037124,"html_url":"https://github.com/fsprojects/Paket/pull/768","diff_url":"https://github.com/fsprojects/Paket/pull/768.diff","patch_url":"https://github.com/fsprojects/Paket/pull/768.patch","issue_url":"https://api.github.com/repos/fsprojects/Paket/issues/768","number":768,"state":"open","locked":false,"title":"Target framework: Added >= and made warnings more clear","user":{"login":"Thorium","id":229355,"avatar_url":"https://avatars.githubusercontent.com/u/229355?v=3","gravatar_id":"","url":"https://api.github.com/users/Thorium","html_url":"https://github.com/Thorium","followers_url":"https://api.github.com/users/Thorium/followers","following_url":"https://api.github.com/users/Thorium/following{/other_user}","gists_url":"https://api.github.com/users/Thorium/gists{/gist_id}","starred_url":"https://api.github.com/users/Thorium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thorium/subscriptions","organizations_url":"https://api.github.com/users/Thorium/orgs","repos_url":"https://api.github.com/users/Thorium/repos","events_url":"https://api.github.com/users/Thorium/events{/privacy}","received_events_url":"https://api.github.com/users/Thorium/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-04-10T11:01:22Z","updated_at":"2015-04-10T11:17:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9b9072dca873cfac24c36c78d3c89f19bebfe24","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fsprojects/Paket/pulls/768/commits","review_comments_url":"https://api.github.com/repos/fsprojects/Paket/pulls/768/comments","review_comment_url":"https://api.github.com/repos/fsprojects/Paket/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fsprojects/Paket/issues/768/comments","statuses_url":"https://api.github.com/repos/fsprojects/Paket/statuses/34371b0cfdd4072921a7d06866da9934b3d46ae2","head":{"label":"Thorium:master","ref":"master","sha":"34371b0cfdd4072921a7d06866da9934b3d46ae2","user":{"login":"Thorium","id":229355,"avatar_url":"https://avatars.githubusercontent.com/u/229355?v=3","gravatar_id":"","url":"https://api.github.com/users/Thorium","html_url":"https://github.com/Thorium","followers_url":"https://api.github.com/users/Thorium/followers","following_url":"https://api.github.com/users/Thorium/following{/other_user}","gists_url":"https://api.github.com/users/Thorium/gists{/gist_id}","starred_url":"https://api.github.com/users/Thorium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thorium/subscriptions","organizations_url":"https://api.github.com/users/Thorium/orgs","repos_url":"https://api.github.com/users/Thorium/repos","events_url":"https://api.github.com/users/Thorium/events{/privacy}","received_events_url":"https://api.github.com/users/Thorium/received_events","type":"User","site_admin":false},"repo":{"id":26357966,"name":"Paket","full_name":"Thorium/Paket","owner":{"login":"Thorium","id":229355,"avatar_url":"https://avatars.githubusercontent.com/u/229355?v=3","gravatar_id":"","url":"https://api.github.com/users/Thorium","html_url":"https://github.com/Thorium","followers_url":"https://api.github.com/users/Thorium/followers","following_url":"https://api.github.com/users/Thorium/following{/other_user}","gists_url":"https://api.github.com/users/Thorium/gists{/gist_id}","starred_url":"https://api.github.com/users/Thorium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thorium/subscriptions","organizations_url":"https://api.github.com/users/Thorium/orgs","repos_url":"https://api.github.com/users/Thorium/repos","events_url":"https://api.github.com/users/Thorium/events{/privacy}","received_events_url":"https://api.github.com/users/Thorium/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Thorium/Paket","description":"A package dependency manager for .NET with support for NuGet packages and GitHub repositories.","fork":true,"url":"https://api.github.com/repos/Thorium/Paket","forks_url":"https://api.github.com/repos/Thorium/Paket/forks","keys_url":"https://api.github.com/repos/Thorium/Paket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Thorium/Paket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Thorium/Paket/teams","hooks_url":"https://api.github.com/repos/Thorium/Paket/hooks","issue_events_url":"https://api.github.com/repos/Thorium/Paket/issues/events{/number}","events_url":"https://api.github.com/repos/Thorium/Paket/events","assignees_url":"https://api.github.com/repos/Thorium/Paket/assignees{/user}","branches_url":"https://api.github.com/repos/Thorium/Paket/branches{/branch}","tags_url":"https://api.github.com/repos/Thorium/Paket/tags","blobs_url":"https://api.github.com/repos/Thorium/Paket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Thorium/Paket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Thorium/Paket/git/refs{/sha}","trees_url":"https://api.github.com/repos/Thorium/Paket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Thorium/Paket/statuses/{sha}","languages_url":"https://api.github.com/repos/Thorium/Paket/languages","stargazers_url":"https://api.github.com/repos/Thorium/Paket/stargazers","contributors_url":"https://api.github.com/repos/Thorium/Paket/contributors","subscribers_url":"https://api.github.com/repos/Thorium/Paket/subscribers","subscription_url":"https://api.github.com/repos/Thorium/Paket/subscription","commits_url":"https://api.github.com/repos/Thorium/Paket/commits{/sha}","git_commits_url":"https://api.github.com/repos/Thorium/Paket/git/commits{/sha}","comments_url":"https://api.github.com/repos/Thorium/Paket/comments{/number}","issue_comment_url":"https://api.github.com/repos/Thorium/Paket/issues/comments{/number}","contents_url":"https://api.github.com/repos/Thorium/Paket/contents/{+path}","compare_url":"https://api.github.com/repos/Thorium/Paket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Thorium/Paket/merges","archive_url":"https://api.github.com/repos/Thorium/Paket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Thorium/Paket/downloads","issues_url":"https://api.github.com/repos/Thorium/Paket/issues{/number}","pulls_url":"https://api.github.com/repos/Thorium/Paket/pulls{/number}","milestones_url":"https://api.github.com/repos/Thorium/Paket/milestones{/number}","notifications_url":"https://api.github.com/repos/Thorium/Paket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Thorium/Paket/labels{/name}","releases_url":"https://api.github.com/repos/Thorium/Paket/releases{/id}","created_at":"2014-11-08T11:06:15Z","updated_at":"2015-04-10T11:00:02Z","pushed_at":"2015-04-10T11:00:02Z","git_url":"git://github.com/Thorium/Paket.git","ssh_url":"git@github.com:Thorium/Paket.git","clone_url":"https://github.com/Thorium/Paket.git","svn_url":"https://github.com/Thorium/Paket","homepage":"http://fsprojects.github.io/Paket/","size":9729,"stargazers_count":0,"watchers_count":0,"language":"F#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fsprojects:master","ref":"master","sha":"776e23648e346a336803143c7d1dec08e1348942","user":{"login":"fsprojects","id":6001315,"avatar_url":"https://avatars.githubusercontent.com/u/6001315?v=3","gravatar_id":"","url":"https://api.github.com/users/fsprojects","html_url":"https://github.com/fsprojects","followers_url":"https://api.github.com/users/fsprojects/followers","following_url":"https://api.github.com/users/fsprojects/following{/other_user}","gists_url":"https://api.github.com/users/fsprojects/gists{/gist_id}","starred_url":"https://api.github.com/users/fsprojects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsprojects/subscriptions","organizations_url":"https://api.github.com/users/fsprojects/orgs","repos_url":"https://api.github.com/users/fsprojects/repos","events_url":"https://api.github.com/users/fsprojects/events{/privacy}","received_events_url":"https://api.github.com/users/fsprojects/received_events","type":"Organization","site_admin":false},"repo":{"id":22755810,"name":"Paket","full_name":"fsprojects/Paket","owner":{"login":"fsprojects","id":6001315,"avatar_url":"https://avatars.githubusercontent.com/u/6001315?v=3","gravatar_id":"","url":"https://api.github.com/users/fsprojects","html_url":"https://github.com/fsprojects","followers_url":"https://api.github.com/users/fsprojects/followers","following_url":"https://api.github.com/users/fsprojects/following{/other_user}","gists_url":"https://api.github.com/users/fsprojects/gists{/gist_id}","starred_url":"https://api.github.com/users/fsprojects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsprojects/subscriptions","organizations_url":"https://api.github.com/users/fsprojects/orgs","repos_url":"https://api.github.com/users/fsprojects/repos","events_url":"https://api.github.com/users/fsprojects/events{/privacy}","received_events_url":"https://api.github.com/users/fsprojects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fsprojects/Paket","description":"A package dependency manager for .NET with support for NuGet packages and GitHub repositories.","fork":false,"url":"https://api.github.com/repos/fsprojects/Paket","forks_url":"https://api.github.com/repos/fsprojects/Paket/forks","keys_url":"https://api.github.com/repos/fsprojects/Paket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fsprojects/Paket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fsprojects/Paket/teams","hooks_url":"https://api.github.com/repos/fsprojects/Paket/hooks","issue_events_url":"https://api.github.com/repos/fsprojects/Paket/issues/events{/number}","events_url":"https://api.github.com/repos/fsprojects/Paket/events","assignees_url":"https://api.github.com/repos/fsprojects/Paket/assignees{/user}","branches_url":"https://api.github.com/repos/fsprojects/Paket/branches{/branch}","tags_url":"https://api.github.com/repos/fsprojects/Paket/tags","blobs_url":"https://api.github.com/repos/fsprojects/Paket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fsprojects/Paket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fsprojects/Paket/git/refs{/sha}","trees_url":"https://api.github.com/repos/fsprojects/Paket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fsprojects/Paket/statuses/{sha}","languages_url":"https://api.github.com/repos/fsprojects/Paket/languages","stargazers_url":"https://api.github.com/repos/fsprojects/Paket/stargazers","contributors_url":"https://api.github.com/repos/fsprojects/Paket/contributors","subscribers_url":"https://api.github.com/repos/fsprojects/Paket/subscribers","subscription_url":"https://api.github.com/repos/fsprojects/Paket/subscription","commits_url":"https://api.github.com/repos/fsprojects/Paket/commits{/sha}","git_commits_url":"https://api.github.com/repos/fsprojects/Paket/git/commits{/sha}","comments_url":"https://api.github.com/repos/fsprojects/Paket/comments{/number}","issue_comment_url":"https://api.github.com/repos/fsprojects/Paket/issues/comments{/number}","contents_url":"https://api.github.com/repos/fsprojects/Paket/contents/{+path}","compare_url":"https://api.github.com/repos/fsprojects/Paket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fsprojects/Paket/merges","archive_url":"https://api.github.com/repos/fsprojects/Paket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fsprojects/Paket/downloads","issues_url":"https://api.github.com/repos/fsprojects/Paket/issues{/number}","pulls_url":"https://api.github.com/repos/fsprojects/Paket/pulls{/number}","milestones_url":"https://api.github.com/repos/fsprojects/Paket/milestones{/number}","notifications_url":"https://api.github.com/repos/fsprojects/Paket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fsprojects/Paket/labels{/name}","releases_url":"https://api.github.com/repos/fsprojects/Paket/releases{/id}","created_at":"2014-08-08T11:36:13Z","updated_at":"2015-04-10T07:34:02Z","pushed_at":"2015-04-10T11:01:23Z","git_url":"git://github.com/fsprojects/Paket.git","ssh_url":"git@github.com:fsprojects/Paket.git","clone_url":"https://github.com/fsprojects/Paket.git","svn_url":"https://github.com/fsprojects/Paket","homepage":"http://fsprojects.github.io/Paket/","size":29627,"stargazers_count":246,"watchers_count":246,"language":"F#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":77,"mirror_url":null,"open_issues_count":62,"forks":77,"open_issues":62,"watchers":246,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fsprojects/Paket/pulls/768"},"html":{"href":"https://github.com/fsprojects/Paket/pull/768"},"issue":{"href":"https://api.github.com/repos/fsprojects/Paket/issues/768"},"comments":{"href":"https://api.github.com/repos/fsprojects/Paket/issues/768/comments"},"review_comments":{"href":"https://api.github.com/repos/fsprojects/Paket/pulls/768/comments"},"review_comment":{"href":"https://api.github.com/repos/fsprojects/Paket/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fsprojects/Paket/pulls/768/commits"},"statuses":{"href":"https://api.github.com/repos/fsprojects/Paket/statuses/34371b0cfdd4072921a7d06866da9934b3d46ae2"}}}}