{"action":"created","comment":{"url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/comments/42436306","id":42436306,"diff_hunk":"@@ -17,6 +17,11 @@ local SIG_WALK = 1\n local SIG_DEPLOY = 2\n local SIG_BEACON = 2\n \n+SIG_WADE = 4","path":"scripts/amphtele.lua","position":4,"original_position":4,"commit_id":"d23075d62f3b92b0b0c66027115c210ed1c29888","original_commit_id":"d23075d62f3b92b0b0c66027115c210ed1c29888","user":{"login":"sprunk","id":2573076,"avatar_url":"https://avatars.githubusercontent.com/u/2573076?v=3","gravatar_id":"","url":"https://api.github.com/users/sprunk","html_url":"https://github.com/sprunk","followers_url":"https://api.github.com/users/sprunk/followers","following_url":"https://api.github.com/users/sprunk/following{/other_user}","gists_url":"https://api.github.com/users/sprunk/gists{/gist_id}","starred_url":"https://api.github.com/users/sprunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sprunk/subscriptions","organizations_url":"https://api.github.com/users/sprunk/orgs","repos_url":"https://api.github.com/users/sprunk/repos","events_url":"https://api.github.com/users/sprunk/events{/privacy}","received_events_url":"https://api.github.com/users/sprunk/received_events","type":"User","site_admin":false},"body":"Djinn doesn't stop because this is 4 instead of 64.","created_at":"2015-10-19T22:51:28Z","updated_at":"2015-10-19T22:51:28Z","html_url":"https://github.com/ZeroK-RTS/Zero-K/pull/1103#discussion_r42436306","pull_request_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/1103","_links":{"self":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/comments/42436306"},"html":{"href":"https://github.com/ZeroK-RTS/Zero-K/pull/1103#discussion_r42436306"},"pull_request":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/1103"}}},"pull_request":{"url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/1103","id":48130905,"html_url":"https://github.com/ZeroK-RTS/Zero-K/pull/1103","diff_url":"https://github.com/ZeroK-RTS/Zero-K/pull/1103.diff","patch_url":"https://github.com/ZeroK-RTS/Zero-K/pull/1103.patch","issue_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/issues/1103","number":1103,"state":"open","locked":false,"title":"An implementation of wading wakes.","user":{"login":"Anarchid","id":3822768,"avatar_url":"https://avatars.githubusercontent.com/u/3822768?v=3","gravatar_id":"","url":"https://api.github.com/users/Anarchid","html_url":"https://github.com/Anarchid","followers_url":"https://api.github.com/users/Anarchid/followers","following_url":"https://api.github.com/users/Anarchid/following{/other_user}","gists_url":"https://api.github.com/users/Anarchid/gists{/gist_id}","starred_url":"https://api.github.com/users/Anarchid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anarchid/subscriptions","organizations_url":"https://api.github.com/users/Anarchid/orgs","repos_url":"https://api.github.com/users/Anarchid/repos","events_url":"https://api.github.com/users/Anarchid/events{/privacy}","received_events_url":"https://api.github.com/users/Anarchid/received_events","type":"User","site_admin":false},"body":"This provides an include function with some ugly globals, which should be easily applicable to most LUS in ZK. \r\n\r\nIt uses a poll to determine when unit is between `0` and `-unitHeight` altitude to spawn wake sfx of required kind. The poll is deactivated when unit is above `0` by use of `SetSfxOccupy`. Seeing how no unit currently uses `SetSfxOccupy`, the include takes full control of that callin.\r\n\r\nIt is applied to Grizzly, Angler, and Djinn here. For some reason, Djinn does not terminate the wake spamming on StopMoving while others do.\r\n\r\nThe end goal would be to apply this to every non-ship non-hover non-flying mobile unit in ZK.\r\n\r\nThe questions:\r\n- is the ugliness really worth the performance savings of not running the poll above zero?\r\n- is there a way to reduce ugliness without massive copypasta?\r\n- why does Djinn refuse to terminate wake spam? I've checked the signals, and they match; there's no cross-contamination between individual unitscripts and Djinn script doesn't seem to use any globals that the include relies on.","created_at":"2015-10-19T21:46:06Z","updated_at":"2015-10-19T22:51:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8cac013269599c75fb4a8d29ffd3bfabcf34bcd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/1103/commits","review_comments_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/1103/comments","review_comment_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/issues/1103/comments","statuses_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/statuses/d23075d62f3b92b0b0c66027115c210ed1c29888","head":{"label":"Anarchid:wade-wake","ref":"wade-wake","sha":"d23075d62f3b92b0b0c66027115c210ed1c29888","user":{"login":"Anarchid","id":3822768,"avatar_url":"https://avatars.githubusercontent.com/u/3822768?v=3","gravatar_id":"","url":"https://api.github.com/users/Anarchid","html_url":"https://github.com/Anarchid","followers_url":"https://api.github.com/users/Anarchid/followers","following_url":"https://api.github.com/users/Anarchid/following{/other_user}","gists_url":"https://api.github.com/users/Anarchid/gists{/gist_id}","starred_url":"https://api.github.com/users/Anarchid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anarchid/subscriptions","organizations_url":"https://api.github.com/users/Anarchid/orgs","repos_url":"https://api.github.com/users/Anarchid/repos","events_url":"https://api.github.com/users/Anarchid/events{/privacy}","received_events_url":"https://api.github.com/users/Anarchid/received_events","type":"User","site_admin":false},"repo":{"id":20897510,"name":"Zero-K","full_name":"Anarchid/Zero-K","owner":{"login":"Anarchid","id":3822768,"avatar_url":"https://avatars.githubusercontent.com/u/3822768?v=3","gravatar_id":"","url":"https://api.github.com/users/Anarchid","html_url":"https://github.com/Anarchid","followers_url":"https://api.github.com/users/Anarchid/followers","following_url":"https://api.github.com/users/Anarchid/following{/other_user}","gists_url":"https://api.github.com/users/Anarchid/gists{/gist_id}","starred_url":"https://api.github.com/users/Anarchid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anarchid/subscriptions","organizations_url":"https://api.github.com/users/Anarchid/orgs","repos_url":"https://api.github.com/users/Anarchid/repos","events_url":"https://api.github.com/users/Anarchid/events{/privacy}","received_events_url":"https://api.github.com/users/Anarchid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Anarchid/Zero-K","description":"Open source RTS game running on the Spring engine","fork":true,"url":"https://api.github.com/repos/Anarchid/Zero-K","forks_url":"https://api.github.com/repos/Anarchid/Zero-K/forks","keys_url":"https://api.github.com/repos/Anarchid/Zero-K/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Anarchid/Zero-K/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Anarchid/Zero-K/teams","hooks_url":"https://api.github.com/repos/Anarchid/Zero-K/hooks","issue_events_url":"https://api.github.com/repos/Anarchid/Zero-K/issues/events{/number}","events_url":"https://api.github.com/repos/Anarchid/Zero-K/events","assignees_url":"https://api.github.com/repos/Anarchid/Zero-K/assignees{/user}","branches_url":"https://api.github.com/repos/Anarchid/Zero-K/branches{/branch}","tags_url":"https://api.github.com/repos/Anarchid/Zero-K/tags","blobs_url":"https://api.github.com/repos/Anarchid/Zero-K/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Anarchid/Zero-K/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Anarchid/Zero-K/git/refs{/sha}","trees_url":"https://api.github.com/repos/Anarchid/Zero-K/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Anarchid/Zero-K/statuses/{sha}","languages_url":"https://api.github.com/repos/Anarchid/Zero-K/languages","stargazers_url":"https://api.github.com/repos/Anarchid/Zero-K/stargazers","contributors_url":"https://api.github.com/repos/Anarchid/Zero-K/contributors","subscribers_url":"https://api.github.com/repos/Anarchid/Zero-K/subscribers","subscription_url":"https://api.github.com/repos/Anarchid/Zero-K/subscription","commits_url":"https://api.github.com/repos/Anarchid/Zero-K/commits{/sha}","git_commits_url":"https://api.github.com/repos/Anarchid/Zero-K/git/commits{/sha}","comments_url":"https://api.github.com/repos/Anarchid/Zero-K/comments{/number}","issue_comment_url":"https://api.github.com/repos/Anarchid/Zero-K/issues/comments{/number}","contents_url":"https://api.github.com/repos/Anarchid/Zero-K/contents/{+path}","compare_url":"https://api.github.com/repos/Anarchid/Zero-K/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Anarchid/Zero-K/merges","archive_url":"https://api.github.com/repos/Anarchid/Zero-K/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Anarchid/Zero-K/downloads","issues_url":"https://api.github.com/repos/Anarchid/Zero-K/issues{/number}","pulls_url":"https://api.github.com/repos/Anarchid/Zero-K/pulls{/number}","milestones_url":"https://api.github.com/repos/Anarchid/Zero-K/milestones{/number}","notifications_url":"https://api.github.com/repos/Anarchid/Zero-K/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Anarchid/Zero-K/labels{/name}","releases_url":"https://api.github.com/repos/Anarchid/Zero-K/releases{/id}","created_at":"2014-06-16T19:21:36Z","updated_at":"2015-01-23T18:00:16Z","pushed_at":"2015-10-19T21:39:11Z","git_url":"git://github.com/Anarchid/Zero-K.git","ssh_url":"git@github.com:Anarchid/Zero-K.git","clone_url":"https://github.com/Anarchid/Zero-K.git","svn_url":"https://github.com/Anarchid/Zero-K","homepage":null,"size":418025,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ZeroK-RTS:master","ref":"master","sha":"d208f5be51194b4271ecf7040f8852fd99223ea0","user":{"login":"ZeroK-RTS","id":5145185,"avatar_url":"https://avatars.githubusercontent.com/u/5145185?v=3","gravatar_id":"","url":"https://api.github.com/users/ZeroK-RTS","html_url":"https://github.com/ZeroK-RTS","followers_url":"https://api.github.com/users/ZeroK-RTS/followers","following_url":"https://api.github.com/users/ZeroK-RTS/following{/other_user}","gists_url":"https://api.github.com/users/ZeroK-RTS/gists{/gist_id}","starred_url":"https://api.github.com/users/ZeroK-RTS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZeroK-RTS/subscriptions","organizations_url":"https://api.github.com/users/ZeroK-RTS/orgs","repos_url":"https://api.github.com/users/ZeroK-RTS/repos","events_url":"https://api.github.com/users/ZeroK-RTS/events{/privacy}","received_events_url":"https://api.github.com/users/ZeroK-RTS/received_events","type":"Organization","site_admin":false},"repo":{"id":11837082,"name":"Zero-K","full_name":"ZeroK-RTS/Zero-K","owner":{"login":"ZeroK-RTS","id":5145185,"avatar_url":"https://avatars.githubusercontent.com/u/5145185?v=3","gravatar_id":"","url":"https://api.github.com/users/ZeroK-RTS","html_url":"https://github.com/ZeroK-RTS","followers_url":"https://api.github.com/users/ZeroK-RTS/followers","following_url":"https://api.github.com/users/ZeroK-RTS/following{/other_user}","gists_url":"https://api.github.com/users/ZeroK-RTS/gists{/gist_id}","starred_url":"https://api.github.com/users/ZeroK-RTS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZeroK-RTS/subscriptions","organizations_url":"https://api.github.com/users/ZeroK-RTS/orgs","repos_url":"https://api.github.com/users/ZeroK-RTS/repos","events_url":"https://api.github.com/users/ZeroK-RTS/events{/privacy}","received_events_url":"https://api.github.com/users/ZeroK-RTS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ZeroK-RTS/Zero-K","description":"Open source RTS game running on the Spring engine","fork":false,"url":"https://api.github.com/repos/ZeroK-RTS/Zero-K","forks_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/forks","keys_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/teams","hooks_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/hooks","issue_events_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/issues/events{/number}","events_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/events","assignees_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/assignees{/user}","branches_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/branches{/branch}","tags_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/tags","blobs_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/statuses/{sha}","languages_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/languages","stargazers_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/stargazers","contributors_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/contributors","subscribers_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/subscribers","subscription_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/subscription","commits_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/contents/{+path}","compare_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/merges","archive_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/downloads","issues_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/issues{/number}","pulls_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls{/number}","milestones_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/milestones{/number}","notifications_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/labels{/name}","releases_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/releases{/id}","created_at":"2013-08-02T06:57:00Z","updated_at":"2015-10-03T14:14:20Z","pushed_at":"2015-10-19T21:46:07Z","git_url":"git://github.com/ZeroK-RTS/Zero-K.git","ssh_url":"git@github.com:ZeroK-RTS/Zero-K.git","clone_url":"https://github.com/ZeroK-RTS/Zero-K.git","svn_url":"https://github.com/ZeroK-RTS/Zero-K","homepage":null,"size":430328,"stargazers_count":52,"watchers_count":52,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":84,"forks":41,"open_issues":84,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/1103"},"html":{"href":"https://github.com/ZeroK-RTS/Zero-K/pull/1103"},"issue":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/issues/1103"},"comments":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/issues/1103/comments"},"review_comments":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/1103/comments"},"review_comment":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/1103/commits"},"statuses":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/statuses/d23075d62f3b92b0b0c66027115c210ed1c29888"}}}}