{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/36926343","id":36926343,"diff_hunk":"@@ -142,5 +142,6 @@ const PacketVersion VERSION_ENTITIES_HAVE_SIMULATION_OWNER_AND_ACTIONS_OVER_WIRE\n const PacketVersion VERSION_ENTITIES_NEW_PROTOCOL_LAYER = 35;\n const PacketVersion VERSION_POLYVOX_TEXTURES = 36;\n const PacketVersion VERSION_ENTITIES_POLYLINE = 37;\n+const PacketVersion VERSION_AVATAR_NO_LEAN = 38;","path":"libraries/networking/src/udt/PacketHeaders.h","position":4,"original_position":4,"commit_id":"a5d8125aa784c5e690565ec56a8ba415cbc6cabb","original_commit_id":"a5d8125aa784c5e690565ec56a8ba415cbc6cabb","user":{"login":"howard-stearns","id":7015115,"avatar_url":"https://avatars.githubusercontent.com/u/7015115?v=3","gravatar_id":"","url":"https://api.github.com/users/howard-stearns","html_url":"https://github.com/howard-stearns","followers_url":"https://api.github.com/users/howard-stearns/followers","following_url":"https://api.github.com/users/howard-stearns/following{/other_user}","gists_url":"https://api.github.com/users/howard-stearns/gists{/gist_id}","starred_url":"https://api.github.com/users/howard-stearns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howard-stearns/subscriptions","organizations_url":"https://api.github.com/users/howard-stearns/orgs","repos_url":"https://api.github.com/users/howard-stearns/repos","events_url":"https://api.github.com/users/howard-stearns/events{/privacy}","received_events_url":"https://api.github.com/users/howard-stearns/received_events","type":"User","site_admin":false},"body":"Yeah, it's not apparent from the code. (I think you're right, but as you say, \"afaik\".) Presumably VERSION_OCTREE_HAS_FILE_BREAKS, VERSION_ROOT_ELEMENT_HAS_DATA, VERSION_POLYVOX_TEXTURES are for \"entity packets\", but you'd have to trace their use to know. (Of course, there are no \"entity packets\", but rather EntityAdd, EntityEdit, and EntityData.) And what namespace is 11 in? (See PacketVersion::versionForPacketType).  Anyway, from the simultaneous conversation in slack, I gather you agree that it doesn't break either way, but that going forward you'd like to see something more systematic?","created_at":"2015-08-12T23:19:27Z","updated_at":"2015-08-12T23:19:27Z","html_url":"https://github.com/highfidelity/hifi/pull/5553#discussion_r36926343","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/5553","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/36926343"},"html":{"href":"https://github.com/highfidelity/hifi/pull/5553#discussion_r36926343"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5553"}}},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/5553","id":42195036,"html_url":"https://github.com/highfidelity/hifi/pull/5553","diff_url":"https://github.com/highfidelity/hifi/pull/5553.diff","patch_url":"https://github.com/highfidelity/hifi/pull/5553.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/5553","number":5553,"state":"closed","locked":false,"title":"Warning: protocol change - Remove obsolete AvatarMixer wire data","user":{"login":"howard-stearns","id":7015115,"avatar_url":"https://avatars.githubusercontent.com/u/7015115?v=3","gravatar_id":"","url":"https://api.github.com/users/howard-stearns","html_url":"https://github.com/howard-stearns","followers_url":"https://api.github.com/users/howard-stearns/followers","following_url":"https://api.github.com/users/howard-stearns/following{/other_user}","gists_url":"https://api.github.com/users/howard-stearns/gists{/gist_id}","starred_url":"https://api.github.com/users/howard-stearns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howard-stearns/subscriptions","organizations_url":"https://api.github.com/users/howard-stearns/orgs","repos_url":"https://api.github.com/users/howard-stearns/repos","events_url":"https://api.github.com/users/howard-stearns/events{/privacy}","received_events_url":"https://api.github.com/users/howard-stearns/received_events","type":"User","site_admin":false},"body":"Changes avatar mixer data.\r\nWas duplicated in JointStates that are also sent.","created_at":"2015-08-12T00:58:01Z","updated_at":"2015-08-12T23:19:27Z","closed_at":"2015-08-12T23:01:42Z","merged_at":"2015-08-12T23:01:42Z","merge_commit_sha":"399e0eed372e4e839f284b44fcfdedac3010e2bd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/5553/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/5553/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/5553/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/a5d8125aa784c5e690565ec56a8ba415cbc6cabb","head":{"label":"howard-stearns:remove-obsolete-avatar-mixer-data","ref":"remove-obsolete-avatar-mixer-data","sha":"a5d8125aa784c5e690565ec56a8ba415cbc6cabb","user":{"login":"howard-stearns","id":7015115,"avatar_url":"https://avatars.githubusercontent.com/u/7015115?v=3","gravatar_id":"","url":"https://api.github.com/users/howard-stearns","html_url":"https://github.com/howard-stearns","followers_url":"https://api.github.com/users/howard-stearns/followers","following_url":"https://api.github.com/users/howard-stearns/following{/other_user}","gists_url":"https://api.github.com/users/howard-stearns/gists{/gist_id}","starred_url":"https://api.github.com/users/howard-stearns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howard-stearns/subscriptions","organizations_url":"https://api.github.com/users/howard-stearns/orgs","repos_url":"https://api.github.com/users/howard-stearns/repos","events_url":"https://api.github.com/users/howard-stearns/events{/privacy}","received_events_url":"https://api.github.com/users/howard-stearns/received_events","type":"User","site_admin":false},"repo":{"id":34746667,"name":"hifi","full_name":"howard-stearns/hifi","owner":{"login":"howard-stearns","id":7015115,"avatar_url":"https://avatars.githubusercontent.com/u/7015115?v=3","gravatar_id":"","url":"https://api.github.com/users/howard-stearns","html_url":"https://github.com/howard-stearns","followers_url":"https://api.github.com/users/howard-stearns/followers","following_url":"https://api.github.com/users/howard-stearns/following{/other_user}","gists_url":"https://api.github.com/users/howard-stearns/gists{/gist_id}","starred_url":"https://api.github.com/users/howard-stearns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howard-stearns/subscriptions","organizations_url":"https://api.github.com/users/howard-stearns/orgs","repos_url":"https://api.github.com/users/howard-stearns/repos","events_url":"https://api.github.com/users/howard-stearns/events{/privacy}","received_events_url":"https://api.github.com/users/howard-stearns/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/howard-stearns/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":true,"url":"https://api.github.com/repos/howard-stearns/hifi","forks_url":"https://api.github.com/repos/howard-stearns/hifi/forks","keys_url":"https://api.github.com/repos/howard-stearns/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/howard-stearns/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/howard-stearns/hifi/teams","hooks_url":"https://api.github.com/repos/howard-stearns/hifi/hooks","issue_events_url":"https://api.github.com/repos/howard-stearns/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/howard-stearns/hifi/events","assignees_url":"https://api.github.com/repos/howard-stearns/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/howard-stearns/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/howard-stearns/hifi/tags","blobs_url":"https://api.github.com/repos/howard-stearns/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/howard-stearns/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/howard-stearns/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/howard-stearns/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/howard-stearns/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/howard-stearns/hifi/languages","stargazers_url":"https://api.github.com/repos/howard-stearns/hifi/stargazers","contributors_url":"https://api.github.com/repos/howard-stearns/hifi/contributors","subscribers_url":"https://api.github.com/repos/howard-stearns/hifi/subscribers","subscription_url":"https://api.github.com/repos/howard-stearns/hifi/subscription","commits_url":"https://api.github.com/repos/howard-stearns/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/howard-stearns/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/howard-stearns/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/howard-stearns/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/howard-stearns/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/howard-stearns/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/howard-stearns/hifi/merges","archive_url":"https://api.github.com/repos/howard-stearns/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/howard-stearns/hifi/downloads","issues_url":"https://api.github.com/repos/howard-stearns/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/howard-stearns/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/howard-stearns/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/howard-stearns/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/howard-stearns/hifi/labels{/name}","releases_url":"https://api.github.com/repos/howard-stearns/hifi/releases{/id}","created_at":"2015-04-28T17:54:06Z","updated_at":"2015-04-29T18:26:52Z","pushed_at":"2015-08-12T20:26:04Z","git_url":"git://github.com/howard-stearns/hifi.git","ssh_url":"git@github.com:howard-stearns/hifi.git","clone_url":"https://github.com/howard-stearns/hifi.git","svn_url":"https://github.com/howard-stearns/hifi","homepage":"","size":167143,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"6ce4820b9fc5782f0b5e37f92b7ef75a4815969d","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","created_at":"2012-08-10T18:26:22Z","updated_at":"2015-08-11T16:42:34Z","pushed_at":"2015-08-12T23:01:43Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":227546,"stargazers_count":291,"watchers_count":291,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":169,"mirror_url":null,"open_issues_count":57,"forks":169,"open_issues":57,"watchers":291,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5553"},"html":{"href":"https://github.com/highfidelity/hifi/pull/5553"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/5553"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/5553/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5553/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5553/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/a5d8125aa784c5e690565ec56a8ba415cbc6cabb"}}}}