{"action":"created","issue":{"url":"https://api.github.com/repos/amitaibu/og/issues/2","labels_url":"https://api.github.com/repos/amitaibu/og/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/amitaibu/og/issues/2/comments","events_url":"https://api.github.com/repos/amitaibu/og/issues/2/events","html_url":"https://github.com/amitaibu/og/pull/2","id":106143829,"number":2,"title":"Replace isGroup logic with bundle entity based storage, Add a new Og static class","user":{"login":"damiankloip","id":1053891,"avatar_url":"https://avatars.githubusercontent.com/u/1053891?v=3","gravatar_id":"","url":"https://api.github.com/users/damiankloip","html_url":"https://github.com/damiankloip","followers_url":"https://api.github.com/users/damiankloip/followers","following_url":"https://api.github.com/users/damiankloip/following{/other_user}","gists_url":"https://api.github.com/users/damiankloip/gists{/gist_id}","starred_url":"https://api.github.com/users/damiankloip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damiankloip/subscriptions","organizations_url":"https://api.github.com/users/damiankloip/orgs","repos_url":"https://api.github.com/users/damiankloip/repos","events_url":"https://api.github.com/users/damiankloip/events{/privacy}","received_events_url":"https://api.github.com/users/damiankloip/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-09-12T09:42:49Z","updated_at":"2015-10-08T08:27:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/amitaibu/og/pulls/2","html_url":"https://github.com/amitaibu/og/pull/2","diff_url":"https://github.com/amitaibu/og/pull/2.diff","patch_url":"https://github.com/amitaibu/og/pull/2.patch"},"body":"Creating this here instead of https://github.com/Gizra/og/pull/63\r\n\r\nThe idea behind this is that we store whether or not a content entity of a specific bundle is a group or not by using the third party settings API we get on config entities. See `ThridPartySettingsInterface`. I think this makes more sense than adding the field instances that we check. That adds a lot of additional data, amongst other things.\r\n\r\nIn D7 this was done to make adding a field formatter easier. We should be able to add a field formatter where we need it quite easily without the field with the new field/entity API.\r\n\r\nThis then ties the implementation to entity types being config entities, which core does anyway for all content entities, except users.\r\n\r\nThis doesn't add a method (yet) to get all group types by entity type > bundle. Do we need that too? We could maybe do the calculation for that and cache it."},"comment":{"url":"https://api.github.com/repos/amitaibu/og/issues/comments/146455067","html_url":"https://github.com/amitaibu/og/pull/2#issuecomment-146455067","issue_url":"https://api.github.com/repos/amitaibu/og/issues/2","id":146455067,"user":{"login":"damiankloip","id":1053891,"avatar_url":"https://avatars.githubusercontent.com/u/1053891?v=3","gravatar_id":"","url":"https://api.github.com/users/damiankloip","html_url":"https://github.com/damiankloip","followers_url":"https://api.github.com/users/damiankloip/followers","following_url":"https://api.github.com/users/damiankloip/following{/other_user}","gists_url":"https://api.github.com/users/damiankloip/gists{/gist_id}","starred_url":"https://api.github.com/users/damiankloip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damiankloip/subscriptions","organizations_url":"https://api.github.com/users/damiankloip/orgs","repos_url":"https://api.github.com/users/damiankloip/repos","events_url":"https://api.github.com/users/damiankloip/events{/privacy}","received_events_url":"https://api.github.com/users/damiankloip/received_events","type":"User","site_admin":false},"created_at":"2015-10-08T08:27:09Z","updated_at":"2015-10-08T08:27:09Z","body":"ok, sounds good, I can remove the entity* methods. They are just small wrappers. The group manager is essentially a key value store. I will write some tests today for that service, then we should be looking good! Cheers guys"}}