{"action":"created","comment":{"url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/pulls/comments/46699739","id":46699739,"diff_hunk":"@@ -111,26 +111,43 @@ def pluralize(number, noun):\n         return \"{0} {1}s\".format(number, noun)\n \n     ### Ansible callbacks ###\n+\n+    # format helper for event_text\n+    @staticmethod\n+    def format_result(res):","path":"datadog_callback.py","position":7,"original_position":7,"commit_id":"6cb2f088f567f02498a0c7ed2a1576f16b0d6575","original_commit_id":"6cb2f088f567f02498a0c7ed2a1576f16b0d6575","user":{"login":"olivielpeau","id":4912500,"avatar_url":"https://avatars.githubusercontent.com/u/4912500?v=3","gravatar_id":"","url":"https://api.github.com/users/olivielpeau","html_url":"https://github.com/olivielpeau","followers_url":"https://api.github.com/users/olivielpeau/followers","following_url":"https://api.github.com/users/olivielpeau/following{/other_user}","gists_url":"https://api.github.com/users/olivielpeau/gists{/gist_id}","starred_url":"https://api.github.com/users/olivielpeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivielpeau/subscriptions","organizations_url":"https://api.github.com/users/olivielpeau/orgs","repos_url":"https://api.github.com/users/olivielpeau/repos","events_url":"https://api.github.com/users/olivielpeau/events{/privacy}","received_events_url":"https://api.github.com/users/olivielpeau/received_events","type":"User","site_admin":false},"body":"Kind of a nitpick, but could you move this method so that the section under `### Ansible callbacks ###` only contains the callbacks that Ansible can call?\r\n\r\nI just want to make the distinction very obvious between what Ansible calls and what's only used internally by the module.","created_at":"2015-12-04T16:23:21Z","updated_at":"2015-12-04T16:23:21Z","html_url":"https://github.com/DataDog/ansible-datadog-callback/pull/7#discussion_r46699739","pull_request_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/DataDog/ansible-datadog-callback/pulls/comments/46699739"},"html":{"href":"https://github.com/DataDog/ansible-datadog-callback/pull/7#discussion_r46699739"},"pull_request":{"href":"https://api.github.com/repos/DataDog/ansible-datadog-callback/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/pulls/7","id":52463920,"html_url":"https://github.com/DataDog/ansible-datadog-callback/pull/7","diff_url":"https://github.com/DataDog/ansible-datadog-callback/pull/7.diff","patch_url":"https://github.com/DataDog/ansible-datadog-callback/pull/7.patch","issue_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/issues/7","number":7,"state":"open","locked":false,"title":"Handle no_log: True and missing invocation key gracefully","user":{"login":"dkerwin","id":168948,"avatar_url":"https://avatars.githubusercontent.com/u/168948?v=3","gravatar_id":"","url":"https://api.github.com/users/dkerwin","html_url":"https://github.com/dkerwin","followers_url":"https://api.github.com/users/dkerwin/followers","following_url":"https://api.github.com/users/dkerwin/following{/other_user}","gists_url":"https://api.github.com/users/dkerwin/gists{/gist_id}","starred_url":"https://api.github.com/users/dkerwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkerwin/subscriptions","organizations_url":"https://api.github.com/users/dkerwin/orgs","repos_url":"https://api.github.com/users/dkerwin/repos","events_url":"https://api.github.com/users/dkerwin/events{/privacy}","received_events_url":"https://api.github.com/users/dkerwin/received_events","type":"User","site_admin":false},"body":"Task example for no_log: True. Leads to missing invocation key as well.\r\n\r\n```\r\n- name: create new secret\r\n  shell: openssl rand -base64 32\r\n  register: my_secret\r\n  no_log: true\r\n```\r\n\r\nValue of result:\r\n\r\n```\r\n{'censored': 'results hidden due to no_log parameter', 'changed': True, 'rc': 0}\r\n```\r\n\r\nCheers :beers: \r\n\r\nDaniel\r\n","created_at":"2015-12-02T22:27:35Z","updated_at":"2015-12-04T16:23:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"64da660af717c9f67c42331a453114bb43c9c950","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/pulls/7/commits","review_comments_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/pulls/7/comments","review_comment_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/issues/7/comments","statuses_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/statuses/6cb2f088f567f02498a0c7ed2a1576f16b0d6575","head":{"label":"gini:fix_no_log_and_invocation_key","ref":"fix_no_log_and_invocation_key","sha":"6cb2f088f567f02498a0c7ed2a1576f16b0d6575","user":{"login":"gini","id":701646,"avatar_url":"https://avatars.githubusercontent.com/u/701646?v=3","gravatar_id":"","url":"https://api.github.com/users/gini","html_url":"https://github.com/gini","followers_url":"https://api.github.com/users/gini/followers","following_url":"https://api.github.com/users/gini/following{/other_user}","gists_url":"https://api.github.com/users/gini/gists{/gist_id}","starred_url":"https://api.github.com/users/gini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gini/subscriptions","organizations_url":"https://api.github.com/users/gini/orgs","repos_url":"https://api.github.com/users/gini/repos","events_url":"https://api.github.com/users/gini/events{/privacy}","received_events_url":"https://api.github.com/users/gini/received_events","type":"Organization","site_admin":false},"repo":{"id":47286598,"name":"ansible-datadog-callback","full_name":"gini/ansible-datadog-callback","owner":{"login":"gini","id":701646,"avatar_url":"https://avatars.githubusercontent.com/u/701646?v=3","gravatar_id":"","url":"https://api.github.com/users/gini","html_url":"https://github.com/gini","followers_url":"https://api.github.com/users/gini/followers","following_url":"https://api.github.com/users/gini/following{/other_user}","gists_url":"https://api.github.com/users/gini/gists{/gist_id}","starred_url":"https://api.github.com/users/gini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gini/subscriptions","organizations_url":"https://api.github.com/users/gini/orgs","repos_url":"https://api.github.com/users/gini/repos","events_url":"https://api.github.com/users/gini/events{/privacy}","received_events_url":"https://api.github.com/users/gini/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gini/ansible-datadog-callback","description":"Ansible callback to get stats & events directly into Datadog http://datadoghq.com","fork":true,"url":"https://api.github.com/repos/gini/ansible-datadog-callback","forks_url":"https://api.github.com/repos/gini/ansible-datadog-callback/forks","keys_url":"https://api.github.com/repos/gini/ansible-datadog-callback/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gini/ansible-datadog-callback/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gini/ansible-datadog-callback/teams","hooks_url":"https://api.github.com/repos/gini/ansible-datadog-callback/hooks","issue_events_url":"https://api.github.com/repos/gini/ansible-datadog-callback/issues/events{/number}","events_url":"https://api.github.com/repos/gini/ansible-datadog-callback/events","assignees_url":"https://api.github.com/repos/gini/ansible-datadog-callback/assignees{/user}","branches_url":"https://api.github.com/repos/gini/ansible-datadog-callback/branches{/branch}","tags_url":"https://api.github.com/repos/gini/ansible-datadog-callback/tags","blobs_url":"https://api.github.com/repos/gini/ansible-datadog-callback/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gini/ansible-datadog-callback/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gini/ansible-datadog-callback/git/refs{/sha}","trees_url":"https://api.github.com/repos/gini/ansible-datadog-callback/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gini/ansible-datadog-callback/statuses/{sha}","languages_url":"https://api.github.com/repos/gini/ansible-datadog-callback/languages","stargazers_url":"https://api.github.com/repos/gini/ansible-datadog-callback/stargazers","contributors_url":"https://api.github.com/repos/gini/ansible-datadog-callback/contributors","subscribers_url":"https://api.github.com/repos/gini/ansible-datadog-callback/subscribers","subscription_url":"https://api.github.com/repos/gini/ansible-datadog-callback/subscription","commits_url":"https://api.github.com/repos/gini/ansible-datadog-callback/commits{/sha}","git_commits_url":"https://api.github.com/repos/gini/ansible-datadog-callback/git/commits{/sha}","comments_url":"https://api.github.com/repos/gini/ansible-datadog-callback/comments{/number}","issue_comment_url":"https://api.github.com/repos/gini/ansible-datadog-callback/issues/comments{/number}","contents_url":"https://api.github.com/repos/gini/ansible-datadog-callback/contents/{+path}","compare_url":"https://api.github.com/repos/gini/ansible-datadog-callback/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gini/ansible-datadog-callback/merges","archive_url":"https://api.github.com/repos/gini/ansible-datadog-callback/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gini/ansible-datadog-callback/downloads","issues_url":"https://api.github.com/repos/gini/ansible-datadog-callback/issues{/number}","pulls_url":"https://api.github.com/repos/gini/ansible-datadog-callback/pulls{/number}","milestones_url":"https://api.github.com/repos/gini/ansible-datadog-callback/milestones{/number}","notifications_url":"https://api.github.com/repos/gini/ansible-datadog-callback/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gini/ansible-datadog-callback/labels{/name}","releases_url":"https://api.github.com/repos/gini/ansible-datadog-callback/releases{/id}","created_at":"2015-12-02T20:27:53Z","updated_at":"2015-12-02T20:27:54Z","pushed_at":"2015-12-04T13:49:12Z","git_url":"git://github.com/gini/ansible-datadog-callback.git","ssh_url":"git@github.com:gini/ansible-datadog-callback.git","clone_url":"https://github.com/gini/ansible-datadog-callback.git","svn_url":"https://github.com/gini/ansible-datadog-callback","homepage":null,"size":8,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DataDog:master","ref":"master","sha":"941c70bcf011bacc19c721aba3b2f7e4af2ad21d","user":{"login":"DataDog","id":365230,"avatar_url":"https://avatars.githubusercontent.com/u/365230?v=3","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":40559956,"name":"ansible-datadog-callback","full_name":"DataDog/ansible-datadog-callback","owner":{"login":"DataDog","id":365230,"avatar_url":"https://avatars.githubusercontent.com/u/365230?v=3","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/ansible-datadog-callback","description":"Ansible callback to get stats & events directly into Datadog http://datadoghq.com","fork":false,"url":"https://api.github.com/repos/DataDog/ansible-datadog-callback","forks_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/forks","keys_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/teams","hooks_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/hooks","issue_events_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/events","assignees_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/tags","blobs_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/languages","stargazers_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/stargazers","contributors_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/contributors","subscribers_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/subscribers","subscription_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/subscription","commits_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/merges","archive_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/downloads","issues_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/ansible-datadog-callback/releases{/id}","created_at":"2015-08-11T19:04:53Z","updated_at":"2015-11-21T07:02:23Z","pushed_at":"2015-12-04T13:49:12Z","git_url":"git://github.com/DataDog/ansible-datadog-callback.git","ssh_url":"git@github.com:DataDog/ansible-datadog-callback.git","clone_url":"https://github.com/DataDog/ansible-datadog-callback.git","svn_url":"https://github.com/DataDog/ansible-datadog-callback","homepage":null,"size":241,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataDog/ansible-datadog-callback/pulls/7"},"html":{"href":"https://github.com/DataDog/ansible-datadog-callback/pull/7"},"issue":{"href":"https://api.github.com/repos/DataDog/ansible-datadog-callback/issues/7"},"comments":{"href":"https://api.github.com/repos/DataDog/ansible-datadog-callback/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/DataDog/ansible-datadog-callback/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/DataDog/ansible-datadog-callback/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataDog/ansible-datadog-callback/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/DataDog/ansible-datadog-callback/statuses/6cb2f088f567f02498a0c7ed2a1576f16b0d6575"}}}}