{"action":"created","comment":{"url":"https://api.github.com/repos/gogo/protobuf/pulls/comments/36588469","id":36588469,"diff_hunk":"@@ -94,7 +94,8 @@ tests:\n \tgo test ./...\n \n vet:\n-\tgo vet ./...\n+\tgo tool vet --all .\n+\t! go tool vet --shadow . 2>&1 | grep -vE 'declaration of err shadows declaration at (proto/text.go:535|proto/text.go:570|protoc-gen-gogo/main.go:84)'","path":"Makefile","position":15,"original_position":15,"commit_id":"504a8a385641f6297d6a3bad176545d6716c13ce","original_commit_id":"a3a725c0d36dd386cb1591afa4ff241f14e7849e","user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"body":"heh, if it's not in the automated build it may as well be left out entirely. it will not provide any help in preventing these bugs (unless you're planning on running `make vetshadow` yourself on every PR?)","created_at":"2015-08-09T14:11:36Z","updated_at":"2015-08-09T14:11:36Z","html_url":"https://github.com/gogo/protobuf/pull/89#discussion_r36588469","pull_request_url":"https://api.github.com/repos/gogo/protobuf/pulls/89","_links":{"self":{"href":"https://api.github.com/repos/gogo/protobuf/pulls/comments/36588469"},"html":{"href":"https://github.com/gogo/protobuf/pull/89#discussion_r36588469"},"pull_request":{"href":"https://api.github.com/repos/gogo/protobuf/pulls/89"}}},"pull_request":{"url":"https://api.github.com/repos/gogo/protobuf/pulls/89","id":41953325,"html_url":"https://github.com/gogo/protobuf/pull/89","diff_url":"https://github.com/gogo/protobuf/pull/89.diff","patch_url":"https://github.com/gogo/protobuf/pull/89.patch","issue_url":"https://api.github.com/repos/gogo/protobuf/issues/89","number":89,"state":"open","locked":false,"title":"Add vet --shadow","user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"body":"Just another thing I fixed a few times; wanted to make sure it's in CI :)","created_at":"2015-08-08T12:18:05Z","updated_at":"2015-08-09T14:11:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ed9faea353ced1842b9b5b4cb7eedd35cb038e3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gogo/protobuf/pulls/89/commits","review_comments_url":"https://api.github.com/repos/gogo/protobuf/pulls/89/comments","review_comment_url":"https://api.github.com/repos/gogo/protobuf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gogo/protobuf/issues/89/comments","statuses_url":"https://api.github.com/repos/gogo/protobuf/statuses/504a8a385641f6297d6a3bad176545d6716c13ce","head":{"label":"tamird:vet-shadow","ref":"vet-shadow","sha":"504a8a385641f6297d6a3bad176545d6716c13ce","user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"repo":{"id":35434449,"name":"protobuf-1","full_name":"tamird/protobuf-1","owner":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tamird/protobuf-1","description":"Protocol Buffers for Go with Gadgets","fork":true,"url":"https://api.github.com/repos/tamird/protobuf-1","forks_url":"https://api.github.com/repos/tamird/protobuf-1/forks","keys_url":"https://api.github.com/repos/tamird/protobuf-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tamird/protobuf-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tamird/protobuf-1/teams","hooks_url":"https://api.github.com/repos/tamird/protobuf-1/hooks","issue_events_url":"https://api.github.com/repos/tamird/protobuf-1/issues/events{/number}","events_url":"https://api.github.com/repos/tamird/protobuf-1/events","assignees_url":"https://api.github.com/repos/tamird/protobuf-1/assignees{/user}","branches_url":"https://api.github.com/repos/tamird/protobuf-1/branches{/branch}","tags_url":"https://api.github.com/repos/tamird/protobuf-1/tags","blobs_url":"https://api.github.com/repos/tamird/protobuf-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tamird/protobuf-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tamird/protobuf-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/tamird/protobuf-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tamird/protobuf-1/statuses/{sha}","languages_url":"https://api.github.com/repos/tamird/protobuf-1/languages","stargazers_url":"https://api.github.com/repos/tamird/protobuf-1/stargazers","contributors_url":"https://api.github.com/repos/tamird/protobuf-1/contributors","subscribers_url":"https://api.github.com/repos/tamird/protobuf-1/subscribers","subscription_url":"https://api.github.com/repos/tamird/protobuf-1/subscription","commits_url":"https://api.github.com/repos/tamird/protobuf-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/tamird/protobuf-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/tamird/protobuf-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/tamird/protobuf-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/tamird/protobuf-1/contents/{+path}","compare_url":"https://api.github.com/repos/tamird/protobuf-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tamird/protobuf-1/merges","archive_url":"https://api.github.com/repos/tamird/protobuf-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tamird/protobuf-1/downloads","issues_url":"https://api.github.com/repos/tamird/protobuf-1/issues{/number}","pulls_url":"https://api.github.com/repos/tamird/protobuf-1/pulls{/number}","milestones_url":"https://api.github.com/repos/tamird/protobuf-1/milestones{/number}","notifications_url":"https://api.github.com/repos/tamird/protobuf-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tamird/protobuf-1/labels{/name}","releases_url":"https://api.github.com/repos/tamird/protobuf-1/releases{/id}","created_at":"2015-05-11T16:03:39Z","updated_at":"2015-05-11T16:03:40Z","pushed_at":"2015-08-08T23:10:36Z","git_url":"git://github.com/tamird/protobuf-1.git","ssh_url":"git@github.com:tamird/protobuf-1.git","clone_url":"https://github.com/tamird/protobuf-1.git","svn_url":"https://github.com/tamird/protobuf-1","homepage":"gogo.github.io","size":4627,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gogo:master","ref":"master","sha":"98e73e511a62a9c232152f94999112c80142a813","user":{"login":"gogo","id":9958490,"avatar_url":"https://avatars.githubusercontent.com/u/9958490?v=3","gravatar_id":"","url":"https://api.github.com/users/gogo","html_url":"https://github.com/gogo","followers_url":"https://api.github.com/users/gogo/followers","following_url":"https://api.github.com/users/gogo/following{/other_user}","gists_url":"https://api.github.com/users/gogo/gists{/gist_id}","starred_url":"https://api.github.com/users/gogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gogo/subscriptions","organizations_url":"https://api.github.com/users/gogo/orgs","repos_url":"https://api.github.com/users/gogo/repos","events_url":"https://api.github.com/users/gogo/events{/privacy}","received_events_url":"https://api.github.com/users/gogo/received_events","type":"Organization","site_admin":false},"repo":{"id":27483832,"name":"protobuf","full_name":"gogo/protobuf","owner":{"login":"gogo","id":9958490,"avatar_url":"https://avatars.githubusercontent.com/u/9958490?v=3","gravatar_id":"","url":"https://api.github.com/users/gogo","html_url":"https://github.com/gogo","followers_url":"https://api.github.com/users/gogo/followers","following_url":"https://api.github.com/users/gogo/following{/other_user}","gists_url":"https://api.github.com/users/gogo/gists{/gist_id}","starred_url":"https://api.github.com/users/gogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gogo/subscriptions","organizations_url":"https://api.github.com/users/gogo/orgs","repos_url":"https://api.github.com/users/gogo/repos","events_url":"https://api.github.com/users/gogo/events{/privacy}","received_events_url":"https://api.github.com/users/gogo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gogo/protobuf","description":"Protocol Buffers for Go with Gadgets","fork":false,"url":"https://api.github.com/repos/gogo/protobuf","forks_url":"https://api.github.com/repos/gogo/protobuf/forks","keys_url":"https://api.github.com/repos/gogo/protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gogo/protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gogo/protobuf/teams","hooks_url":"https://api.github.com/repos/gogo/protobuf/hooks","issue_events_url":"https://api.github.com/repos/gogo/protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/gogo/protobuf/events","assignees_url":"https://api.github.com/repos/gogo/protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/gogo/protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/gogo/protobuf/tags","blobs_url":"https://api.github.com/repos/gogo/protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gogo/protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gogo/protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/gogo/protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gogo/protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/gogo/protobuf/languages","stargazers_url":"https://api.github.com/repos/gogo/protobuf/stargazers","contributors_url":"https://api.github.com/repos/gogo/protobuf/contributors","subscribers_url":"https://api.github.com/repos/gogo/protobuf/subscribers","subscription_url":"https://api.github.com/repos/gogo/protobuf/subscription","commits_url":"https://api.github.com/repos/gogo/protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/gogo/protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/gogo/protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/gogo/protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/gogo/protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/gogo/protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gogo/protobuf/merges","archive_url":"https://api.github.com/repos/gogo/protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gogo/protobuf/downloads","issues_url":"https://api.github.com/repos/gogo/protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/gogo/protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/gogo/protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/gogo/protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gogo/protobuf/labels{/name}","releases_url":"https://api.github.com/repos/gogo/protobuf/releases{/id}","created_at":"2014-12-03T11:27:10Z","updated_at":"2015-08-09T04:07:45Z","pushed_at":"2015-08-08T23:10:36Z","git_url":"git://github.com/gogo/protobuf.git","ssh_url":"git@github.com:gogo/protobuf.git","clone_url":"https://github.com/gogo/protobuf.git","svn_url":"https://github.com/gogo/protobuf","homepage":"gogo.github.io","size":5632,"stargazers_count":172,"watchers_count":172,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":15,"forks":20,"open_issues":15,"watchers":172,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gogo/protobuf/pulls/89"},"html":{"href":"https://github.com/gogo/protobuf/pull/89"},"issue":{"href":"https://api.github.com/repos/gogo/protobuf/issues/89"},"comments":{"href":"https://api.github.com/repos/gogo/protobuf/issues/89/comments"},"review_comments":{"href":"https://api.github.com/repos/gogo/protobuf/pulls/89/comments"},"review_comment":{"href":"https://api.github.com/repos/gogo/protobuf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gogo/protobuf/pulls/89/commits"},"statuses":{"href":"https://api.github.com/repos/gogo/protobuf/statuses/504a8a385641f6297d6a3bad176545d6716c13ce"}}}}