{"action":"opened","number":7641,"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/7641","id":40938402,"html_url":"https://github.com/xbmc/xbmc/pull/7641","diff_url":"https://github.com/xbmc/xbmc/pull/7641.diff","patch_url":"https://github.com/xbmc/xbmc/pull/7641.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/7641","number":7641,"state":"open","locked":false,"title":"[binary addons] fix/support ZIP packaging","user":{"login":"Montellese","id":75864,"avatar_url":"https://avatars.githubusercontent.com/u/75864?v=3","gravatar_id":"","url":"https://api.github.com/users/Montellese","html_url":"https://github.com/Montellese","followers_url":"https://api.github.com/users/Montellese/followers","following_url":"https://api.github.com/users/Montellese/following{/other_user}","gists_url":"https://api.github.com/users/Montellese/gists{/gist_id}","starred_url":"https://api.github.com/users/Montellese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Montellese/subscriptions","organizations_url":"https://api.github.com/users/Montellese/orgs","repos_url":"https://api.github.com/users/Montellese/repos","events_url":"https://api.github.com/users/Montellese/events{/privacy}","received_events_url":"https://api.github.com/users/Montellese/received_events","type":"User","site_admin":false},"body":"These commits add/fix support for packaging built binary addons into a ZIP archive. Most of the functionality has already been provided by @notspiff and the rest I \"stole\" from his other cmake scripts after some kind pointers from him.\r\nWith these changes it is possible to extecute the `package-addons` or any of the `package-<addon-id>` targets on the generated build files to package all or a specific addon that has previously been built.\r\n\r\nThere are two things that need attention:\r\n* The fixed path in https://github.com/xbmc/xbmc/compare/xbmc:master...Montellese:cmake_addons_packaging?expand=1#diff-b100f554dc9c53a628bcf373a545eda9R289 looks very ugly but I couldn't find a variable that would provide this path.\r\n* Where should the generated ZIP files be copied/installed to? I used CMAKE_INSTALL_PREFIX for now (see https://github.com/xbmc/xbmc/compare/xbmc:master...Montellese:cmake_addons_packaging?expand=1#diff-88c873338ed1cc64c771fdefc1f40754R15) but I'm pretty sure that that's the wrong location for linux/depends. It's also not the proper location for win32 but it was the easiest for now. This will most likely only be something used by jenkins to upload the ZIP archives to our mirrors.\r\n\r\nI had to bump the audioencoder addons because they were missing `include(CPack)`. @notspiff: Is there a reason why this include is not in `addon-helpers.cmake`?","created_at":"2015-07-27T19:13:19Z","updated_at":"2015-07-27T19:13:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/7641/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/7641/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/7641/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/92f8c7fda35cc5c195c3c5e096dfdb179bb37445","head":{"label":"Montellese:cmake_addons_packaging","ref":"cmake_addons_packaging","sha":"92f8c7fda35cc5c195c3c5e096dfdb179bb37445","user":{"login":"Montellese","id":75864,"avatar_url":"https://avatars.githubusercontent.com/u/75864?v=3","gravatar_id":"","url":"https://api.github.com/users/Montellese","html_url":"https://github.com/Montellese","followers_url":"https://api.github.com/users/Montellese/followers","following_url":"https://api.github.com/users/Montellese/following{/other_user}","gists_url":"https://api.github.com/users/Montellese/gists{/gist_id}","starred_url":"https://api.github.com/users/Montellese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Montellese/subscriptions","organizations_url":"https://api.github.com/users/Montellese/orgs","repos_url":"https://api.github.com/users/Montellese/repos","events_url":"https://api.github.com/users/Montellese/events{/privacy}","received_events_url":"https://api.github.com/users/Montellese/received_events","type":"User","site_admin":false},"repo":{"id":1287028,"name":"xbmc","full_name":"Montellese/xbmc","owner":{"login":"Montellese","id":75864,"avatar_url":"https://avatars.githubusercontent.com/u/75864?v=3","gravatar_id":"","url":"https://api.github.com/users/Montellese","html_url":"https://github.com/Montellese","followers_url":"https://api.github.com/users/Montellese/followers","following_url":"https://api.github.com/users/Montellese/following{/other_user}","gists_url":"https://api.github.com/users/Montellese/gists{/gist_id}","starred_url":"https://api.github.com/users/Montellese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Montellese/subscriptions","organizations_url":"https://api.github.com/users/Montellese/orgs","repos_url":"https://api.github.com/users/Montellese/repos","events_url":"https://api.github.com/users/Montellese/events{/privacy}","received_events_url":"https://api.github.com/users/Montellese/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Montellese/xbmc","description":"Montellese's fork of XBMC ","fork":true,"url":"https://api.github.com/repos/Montellese/xbmc","forks_url":"https://api.github.com/repos/Montellese/xbmc/forks","keys_url":"https://api.github.com/repos/Montellese/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Montellese/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Montellese/xbmc/teams","hooks_url":"https://api.github.com/repos/Montellese/xbmc/hooks","issue_events_url":"https://api.github.com/repos/Montellese/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/Montellese/xbmc/events","assignees_url":"https://api.github.com/repos/Montellese/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/Montellese/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/Montellese/xbmc/tags","blobs_url":"https://api.github.com/repos/Montellese/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Montellese/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Montellese/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Montellese/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Montellese/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/Montellese/xbmc/languages","stargazers_url":"https://api.github.com/repos/Montellese/xbmc/stargazers","contributors_url":"https://api.github.com/repos/Montellese/xbmc/contributors","subscribers_url":"https://api.github.com/repos/Montellese/xbmc/subscribers","subscription_url":"https://api.github.com/repos/Montellese/xbmc/subscription","commits_url":"https://api.github.com/repos/Montellese/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Montellese/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Montellese/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Montellese/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/Montellese/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/Montellese/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Montellese/xbmc/merges","archive_url":"https://api.github.com/repos/Montellese/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Montellese/xbmc/downloads","issues_url":"https://api.github.com/repos/Montellese/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/Montellese/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/Montellese/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/Montellese/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Montellese/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/Montellese/xbmc/releases{/id}","created_at":"2011-01-24T08:36:12Z","updated_at":"2015-05-14T15:50:32Z","pushed_at":"2015-07-27T19:07:07Z","git_url":"git://github.com/Montellese/xbmc.git","ssh_url":"git@github.com:Montellese/xbmc.git","clone_url":"https://github.com/Montellese/xbmc.git","svn_url":"https://github.com/Montellese/xbmc","homepage":"http://xbmc.org","size":526620,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":5,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"60bfc58e17e037d1eac28ce057fd0943973932c9","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","created_at":"2011-01-03T21:18:51Z","updated_at":"2015-07-27T17:21:51Z","pushed_at":"2015-07-27T18:24:21Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1867039,"stargazers_count":4026,"watchers_count":4026,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2942,"mirror_url":null,"open_issues_count":206,"forks":2942,"open_issues":206,"watchers":4026,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7641"},"html":{"href":"https://github.com/xbmc/xbmc/pull/7641"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/7641"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/7641/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7641/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7641/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/92f8c7fda35cc5c195c3c5e096dfdb179bb37445"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":29,"deletions":6,"changed_files":6}}