{"action":"opened","issue":{"url":"https://api.github.com/repos/meetecho/janus-gateway/issues/331","labels_url":"https://api.github.com/repos/meetecho/janus-gateway/issues/331/labels{/name}","comments_url":"https://api.github.com/repos/meetecho/janus-gateway/issues/331/comments","events_url":"https://api.github.com/repos/meetecho/janus-gateway/issues/331/events","html_url":"https://github.com/meetecho/janus-gateway/issues/331","id":107163878,"number":331,"title":"Incorrect check for private IP range","user":{"login":"saghul","id":317464,"avatar_url":"https://avatars.githubusercontent.com/u/317464?v=3","gravatar_id":"","url":"https://api.github.com/users/saghul","html_url":"https://github.com/saghul","followers_url":"https://api.github.com/users/saghul/followers","following_url":"https://api.github.com/users/saghul/following{/other_user}","gists_url":"https://api.github.com/users/saghul/gists{/gist_id}","starred_url":"https://api.github.com/users/saghul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saghul/subscriptions","organizations_url":"https://api.github.com/users/saghul/orgs","repos_url":"https://api.github.com/users/saghul/repos","events_url":"https://api.github.com/users/saghul/events{/privacy}","received_events_url":"https://api.github.com/users/saghul/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-09-18T09:18:48Z","updated_at":"2015-09-18T09:18:48Z","closed_at":null,"body":"~~~~\r\nSep 18 10:15:59 node03 janus[31983]: [WARN] Janus is deployed on a private address (81.23.228.146) but you didn't specify any STUN server! Expect trouble if this is supposed to work over the internet and not just in a LAN...\r\n~~~~\r\n\r\nBy looking at the code, local_ip is checked as is, whcih I don't think it's correct, those macros seem to expect host order longs. Also those macros only work with IPv4 netmasks, AFAIS.\r\n\r\nI tried to fix this [here](https://github.com/saghul/janus-gateway/tree/fix-local-ip-check) but kung-fu seems to be weak today, as it doesn't seem to work."}}