{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4373","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4373/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4373/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4373/events","html_url":"https://github.com/scikit-learn/scikit-learn/issues/4373","id":60437824,"number":4373,"title":"Remove mutable default arguments","user":{"login":"amueller","id":449558,"avatar_url":"https://avatars.githubusercontent.com/u/449558?v=3","gravatar_id":"","url":"https://api.github.com/users/amueller","html_url":"https://github.com/amueller","followers_url":"https://api.github.com/users/amueller/followers","following_url":"https://api.github.com/users/amueller/following{/other_user}","gists_url":"https://api.github.com/users/amueller/gists{/gist_id}","starred_url":"https://api.github.com/users/amueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amueller/subscriptions","organizations_url":"https://api.github.com/users/amueller/orgs","repos_url":"https://api.github.com/users/amueller/repos","events_url":"https://api.github.com/users/amueller/events{/privacy}","received_events_url":"https://api.github.com/users/amueller/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels/Easy","name":"Easy","color":"02d7e1"},{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels/Enhancement","name":"Enhancement","color":"d7e102"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-03-10T01:34:01Z","updated_at":"2015-03-10T15:09:39Z","closed_at":null,"body":"We should remove mutable default arguments as much as sensibly possible.\r\nYou can find some using the landscape.io bot: https://landscape.io/github/scikit-learn/scikit-learn/51/messages/error?page=3#errors\r\nThe default value should be replace by ``None`` and then replaced by the actual value in ``fit``.\r\nThis is a good fit for GSoC / first time contributors."},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/78073836","html_url":"https://github.com/scikit-learn/scikit-learn/issues/4373#issuecomment-78073836","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4373","id":78073836,"user":{"login":"amueller","id":449558,"avatar_url":"https://avatars.githubusercontent.com/u/449558?v=3","gravatar_id":"","url":"https://api.github.com/users/amueller","html_url":"https://github.com/amueller","followers_url":"https://api.github.com/users/amueller/followers","following_url":"https://api.github.com/users/amueller/following{/other_user}","gists_url":"https://api.github.com/users/amueller/gists{/gist_id}","starred_url":"https://api.github.com/users/amueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amueller/subscriptions","organizations_url":"https://api.github.com/users/amueller/orgs","repos_url":"https://api.github.com/users/amueller/repos","events_url":"https://api.github.com/users/amueller/events{/privacy}","received_events_url":"https://api.github.com/users/amueller/received_events","type":"User","site_admin":false},"created_at":"2015-03-10T15:09:39Z","updated_at":"2015-03-10T15:09:39Z","body":"the default values should be documented in the docstring anyhow. But I somewhat agree that seeing the default value in the signature is also nice. So +1 on using tuples where possible.\r\nBtw, I just pushed a thing to better configure landscape.io, so the report should now mostly list things that are useful to fix."}}