{"action":"created","comment":{"url":"https://api.github.com/repos/ehcache/ehcache3/pulls/comments/40834896","id":40834896,"diff_hunk":"@@ -26,7 +26,20 @@\n \n /**\n  * Interface defining the contract used to transform types in a serial form.\n- * Implementations must be thread-safe and must define a constructor accepting a single ClassLoader parameter.\n+ * \n+ * When used within the DefaultSerializationProvider which is the default implementation of {@link SerializationProvider} \n+ * service provided by ehcache, there are a few additional requirements:\n+ * The implementations must be thread-safe and must define either or both of the two constructors:","path":"api/src/main/java/org/ehcache/spi/serialization/Serializer.java","position":8,"original_position":8,"commit_id":"d23588cd5eec7b8250a9afb3a12714385737bfc8","original_commit_id":"d23588cd5eec7b8250a9afb3a12714385737bfc8","user":{"login":"ljacomet","id":135308,"avatar_url":"https://avatars.githubusercontent.com/u/135308?v=3","gravatar_id":"","url":"https://api.github.com/users/ljacomet","html_url":"https://github.com/ljacomet","followers_url":"https://api.github.com/users/ljacomet/followers","following_url":"https://api.github.com/users/ljacomet/following{/other_user}","gists_url":"https://api.github.com/users/ljacomet/gists{/gist_id}","starred_url":"https://api.github.com/users/ljacomet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljacomet/subscriptions","organizations_url":"https://api.github.com/users/ljacomet/orgs","repos_url":"https://api.github.com/users/ljacomet/repos","events_url":"https://api.github.com/users/ljacomet/events{/privacy}","received_events_url":"https://api.github.com/users/ljacomet/received_events","type":"User","site_admin":false},"body":"The thread-safe bit remains true always, so that should be indicated before the special integration with default serialization provider - which I would reference like in my sentence and not a class name given the module differences.","created_at":"2015-09-30T18:50:22Z","updated_at":"2015-09-30T18:50:22Z","html_url":"https://github.com/ehcache/ehcache3/pull/618#discussion_r40834896","pull_request_url":"https://api.github.com/repos/ehcache/ehcache3/pulls/618","_links":{"self":{"href":"https://api.github.com/repos/ehcache/ehcache3/pulls/comments/40834896"},"html":{"href":"https://github.com/ehcache/ehcache3/pull/618#discussion_r40834896"},"pull_request":{"href":"https://api.github.com/repos/ehcache/ehcache3/pulls/618"}}},"pull_request":{"url":"https://api.github.com/repos/ehcache/ehcache3/pulls/618","id":46398898,"html_url":"https://github.com/ehcache/ehcache3/pull/618","diff_url":"https://github.com/ehcache/ehcache3/pull/618.diff","patch_url":"https://github.com/ehcache/ehcache3/pull/618.patch","issue_url":"https://api.github.com/repos/ehcache/ehcache3/issues/618","number":618,"state":"open","locked":false,"title":"Issue #617 Removing serializer annotations and instead enforcing the …","user":{"login":"albinsuresh","id":1647963,"avatar_url":"https://avatars.githubusercontent.com/u/1647963?v=3","gravatar_id":"","url":"https://api.github.com/users/albinsuresh","html_url":"https://github.com/albinsuresh","followers_url":"https://api.github.com/users/albinsuresh/followers","following_url":"https://api.github.com/users/albinsuresh/following{/other_user}","gists_url":"https://api.github.com/users/albinsuresh/gists{/gist_id}","starred_url":"https://api.github.com/users/albinsuresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albinsuresh/subscriptions","organizations_url":"https://api.github.com/users/albinsuresh/orgs","repos_url":"https://api.github.com/users/albinsuresh/repos","events_url":"https://api.github.com/users/albinsuresh/events{/privacy}","received_events_url":"https://api.github.com/users/albinsuresh/received_events","type":"User","site_admin":false},"body":"…constructor requirements","created_at":"2015-09-30T13:08:12Z","updated_at":"2015-09-30T18:50:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29a3005f192ab260b886ecdca22e06ea9daa93e2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ehcache/ehcache3/pulls/618/commits","review_comments_url":"https://api.github.com/repos/ehcache/ehcache3/pulls/618/comments","review_comment_url":"https://api.github.com/repos/ehcache/ehcache3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ehcache/ehcache3/issues/618/comments","statuses_url":"https://api.github.com/repos/ehcache/ehcache3/statuses/d23588cd5eec7b8250a9afb3a12714385737bfc8","head":{"label":"albinsuresh:issue-617","ref":"issue-617","sha":"d23588cd5eec7b8250a9afb3a12714385737bfc8","user":{"login":"albinsuresh","id":1647963,"avatar_url":"https://avatars.githubusercontent.com/u/1647963?v=3","gravatar_id":"","url":"https://api.github.com/users/albinsuresh","html_url":"https://github.com/albinsuresh","followers_url":"https://api.github.com/users/albinsuresh/followers","following_url":"https://api.github.com/users/albinsuresh/following{/other_user}","gists_url":"https://api.github.com/users/albinsuresh/gists{/gist_id}","starred_url":"https://api.github.com/users/albinsuresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albinsuresh/subscriptions","organizations_url":"https://api.github.com/users/albinsuresh/orgs","repos_url":"https://api.github.com/users/albinsuresh/repos","events_url":"https://api.github.com/users/albinsuresh/events{/privacy}","received_events_url":"https://api.github.com/users/albinsuresh/received_events","type":"User","site_admin":false},"repo":{"id":39440089,"name":"ehcache3","full_name":"albinsuresh/ehcache3","owner":{"login":"albinsuresh","id":1647963,"avatar_url":"https://avatars.githubusercontent.com/u/1647963?v=3","gravatar_id":"","url":"https://api.github.com/users/albinsuresh","html_url":"https://github.com/albinsuresh","followers_url":"https://api.github.com/users/albinsuresh/followers","following_url":"https://api.github.com/users/albinsuresh/following{/other_user}","gists_url":"https://api.github.com/users/albinsuresh/gists{/gist_id}","starred_url":"https://api.github.com/users/albinsuresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albinsuresh/subscriptions","organizations_url":"https://api.github.com/users/albinsuresh/orgs","repos_url":"https://api.github.com/users/albinsuresh/repos","events_url":"https://api.github.com/users/albinsuresh/events{/privacy}","received_events_url":"https://api.github.com/users/albinsuresh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/albinsuresh/ehcache3","description":"Ehcache 3.x line ","fork":true,"url":"https://api.github.com/repos/albinsuresh/ehcache3","forks_url":"https://api.github.com/repos/albinsuresh/ehcache3/forks","keys_url":"https://api.github.com/repos/albinsuresh/ehcache3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/albinsuresh/ehcache3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/albinsuresh/ehcache3/teams","hooks_url":"https://api.github.com/repos/albinsuresh/ehcache3/hooks","issue_events_url":"https://api.github.com/repos/albinsuresh/ehcache3/issues/events{/number}","events_url":"https://api.github.com/repos/albinsuresh/ehcache3/events","assignees_url":"https://api.github.com/repos/albinsuresh/ehcache3/assignees{/user}","branches_url":"https://api.github.com/repos/albinsuresh/ehcache3/branches{/branch}","tags_url":"https://api.github.com/repos/albinsuresh/ehcache3/tags","blobs_url":"https://api.github.com/repos/albinsuresh/ehcache3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/albinsuresh/ehcache3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/albinsuresh/ehcache3/git/refs{/sha}","trees_url":"https://api.github.com/repos/albinsuresh/ehcache3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/albinsuresh/ehcache3/statuses/{sha}","languages_url":"https://api.github.com/repos/albinsuresh/ehcache3/languages","stargazers_url":"https://api.github.com/repos/albinsuresh/ehcache3/stargazers","contributors_url":"https://api.github.com/repos/albinsuresh/ehcache3/contributors","subscribers_url":"https://api.github.com/repos/albinsuresh/ehcache3/subscribers","subscription_url":"https://api.github.com/repos/albinsuresh/ehcache3/subscription","commits_url":"https://api.github.com/repos/albinsuresh/ehcache3/commits{/sha}","git_commits_url":"https://api.github.com/repos/albinsuresh/ehcache3/git/commits{/sha}","comments_url":"https://api.github.com/repos/albinsuresh/ehcache3/comments{/number}","issue_comment_url":"https://api.github.com/repos/albinsuresh/ehcache3/issues/comments{/number}","contents_url":"https://api.github.com/repos/albinsuresh/ehcache3/contents/{+path}","compare_url":"https://api.github.com/repos/albinsuresh/ehcache3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/albinsuresh/ehcache3/merges","archive_url":"https://api.github.com/repos/albinsuresh/ehcache3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/albinsuresh/ehcache3/downloads","issues_url":"https://api.github.com/repos/albinsuresh/ehcache3/issues{/number}","pulls_url":"https://api.github.com/repos/albinsuresh/ehcache3/pulls{/number}","milestones_url":"https://api.github.com/repos/albinsuresh/ehcache3/milestones{/number}","notifications_url":"https://api.github.com/repos/albinsuresh/ehcache3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/albinsuresh/ehcache3/labels{/name}","releases_url":"https://api.github.com/repos/albinsuresh/ehcache3/releases{/id}","created_at":"2015-07-21T10:51:41Z","updated_at":"2015-07-21T10:51:43Z","pushed_at":"2015-09-30T18:30:40Z","git_url":"git://github.com/albinsuresh/ehcache3.git","ssh_url":"git@github.com:albinsuresh/ehcache3.git","clone_url":"https://github.com/albinsuresh/ehcache3.git","svn_url":"https://github.com/albinsuresh/ehcache3","homepage":"ehcache.org","size":4731,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ehcache:master","ref":"master","sha":"f86b7dcb423b3e7a53e4b708ed925b94fb20e892","user":{"login":"ehcache","id":5504982,"avatar_url":"https://avatars.githubusercontent.com/u/5504982?v=3","gravatar_id":"","url":"https://api.github.com/users/ehcache","html_url":"https://github.com/ehcache","followers_url":"https://api.github.com/users/ehcache/followers","following_url":"https://api.github.com/users/ehcache/following{/other_user}","gists_url":"https://api.github.com/users/ehcache/gists{/gist_id}","starred_url":"https://api.github.com/users/ehcache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehcache/subscriptions","organizations_url":"https://api.github.com/users/ehcache/orgs","repos_url":"https://api.github.com/users/ehcache/repos","events_url":"https://api.github.com/users/ehcache/events{/privacy}","received_events_url":"https://api.github.com/users/ehcache/received_events","type":"Organization","site_admin":false},"repo":{"id":17224514,"name":"ehcache3","full_name":"ehcache/ehcache3","owner":{"login":"ehcache","id":5504982,"avatar_url":"https://avatars.githubusercontent.com/u/5504982?v=3","gravatar_id":"","url":"https://api.github.com/users/ehcache","html_url":"https://github.com/ehcache","followers_url":"https://api.github.com/users/ehcache/followers","following_url":"https://api.github.com/users/ehcache/following{/other_user}","gists_url":"https://api.github.com/users/ehcache/gists{/gist_id}","starred_url":"https://api.github.com/users/ehcache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehcache/subscriptions","organizations_url":"https://api.github.com/users/ehcache/orgs","repos_url":"https://api.github.com/users/ehcache/repos","events_url":"https://api.github.com/users/ehcache/events{/privacy}","received_events_url":"https://api.github.com/users/ehcache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ehcache/ehcache3","description":"Ehcache 3.x line ","fork":false,"url":"https://api.github.com/repos/ehcache/ehcache3","forks_url":"https://api.github.com/repos/ehcache/ehcache3/forks","keys_url":"https://api.github.com/repos/ehcache/ehcache3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ehcache/ehcache3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ehcache/ehcache3/teams","hooks_url":"https://api.github.com/repos/ehcache/ehcache3/hooks","issue_events_url":"https://api.github.com/repos/ehcache/ehcache3/issues/events{/number}","events_url":"https://api.github.com/repos/ehcache/ehcache3/events","assignees_url":"https://api.github.com/repos/ehcache/ehcache3/assignees{/user}","branches_url":"https://api.github.com/repos/ehcache/ehcache3/branches{/branch}","tags_url":"https://api.github.com/repos/ehcache/ehcache3/tags","blobs_url":"https://api.github.com/repos/ehcache/ehcache3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ehcache/ehcache3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ehcache/ehcache3/git/refs{/sha}","trees_url":"https://api.github.com/repos/ehcache/ehcache3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ehcache/ehcache3/statuses/{sha}","languages_url":"https://api.github.com/repos/ehcache/ehcache3/languages","stargazers_url":"https://api.github.com/repos/ehcache/ehcache3/stargazers","contributors_url":"https://api.github.com/repos/ehcache/ehcache3/contributors","subscribers_url":"https://api.github.com/repos/ehcache/ehcache3/subscribers","subscription_url":"https://api.github.com/repos/ehcache/ehcache3/subscription","commits_url":"https://api.github.com/repos/ehcache/ehcache3/commits{/sha}","git_commits_url":"https://api.github.com/repos/ehcache/ehcache3/git/commits{/sha}","comments_url":"https://api.github.com/repos/ehcache/ehcache3/comments{/number}","issue_comment_url":"https://api.github.com/repos/ehcache/ehcache3/issues/comments{/number}","contents_url":"https://api.github.com/repos/ehcache/ehcache3/contents/{+path}","compare_url":"https://api.github.com/repos/ehcache/ehcache3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ehcache/ehcache3/merges","archive_url":"https://api.github.com/repos/ehcache/ehcache3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ehcache/ehcache3/downloads","issues_url":"https://api.github.com/repos/ehcache/ehcache3/issues{/number}","pulls_url":"https://api.github.com/repos/ehcache/ehcache3/pulls{/number}","milestones_url":"https://api.github.com/repos/ehcache/ehcache3/milestones{/number}","notifications_url":"https://api.github.com/repos/ehcache/ehcache3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ehcache/ehcache3/labels{/name}","releases_url":"https://api.github.com/repos/ehcache/ehcache3/releases{/id}","created_at":"2014-02-26T20:39:16Z","updated_at":"2015-09-30T07:10:48Z","pushed_at":"2015-09-30T18:30:40Z","git_url":"git://github.com/ehcache/ehcache3.git","ssh_url":"git@github.com:ehcache/ehcache3.git","clone_url":"https://github.com/ehcache/ehcache3.git","svn_url":"https://github.com/ehcache/ehcache3","homepage":"http://ehcache.github.io","size":8826,"stargazers_count":166,"watchers_count":166,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":115,"mirror_url":null,"open_issues_count":45,"forks":115,"open_issues":45,"watchers":166,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ehcache/ehcache3/pulls/618"},"html":{"href":"https://github.com/ehcache/ehcache3/pull/618"},"issue":{"href":"https://api.github.com/repos/ehcache/ehcache3/issues/618"},"comments":{"href":"https://api.github.com/repos/ehcache/ehcache3/issues/618/comments"},"review_comments":{"href":"https://api.github.com/repos/ehcache/ehcache3/pulls/618/comments"},"review_comment":{"href":"https://api.github.com/repos/ehcache/ehcache3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ehcache/ehcache3/pulls/618/commits"},"statuses":{"href":"https://api.github.com/repos/ehcache/ehcache3/statuses/d23588cd5eec7b8250a9afb3a12714385737bfc8"}}}}