{"action":"created","issue":{"url":"https://api.github.com/repos/strongloop/strong-mesh-models/issues/45","labels_url":"https://api.github.com/repos/strongloop/strong-mesh-models/issues/45/labels{/name}","comments_url":"https://api.github.com/repos/strongloop/strong-mesh-models/issues/45/comments","events_url":"https://api.github.com/repos/strongloop/strong-mesh-models/issues/45/events","html_url":"https://github.com/strongloop/strong-mesh-models/pull/45","id":72545946,"number":45,"title":"server: persist instance.cpus to trigger resize","user":{"login":"sam-github","id":17607,"avatar_url":"https://avatars.githubusercontent.com/u/17607?v=3","gravatar_id":"","url":"https://api.github.com/users/sam-github","html_url":"https://github.com/sam-github","followers_url":"https://api.github.com/users/sam-github/followers","following_url":"https://api.github.com/users/sam-github/following{/other_user}","gists_url":"https://api.github.com/users/sam-github/gists{/gist_id}","starred_url":"https://api.github.com/users/sam-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sam-github/subscriptions","organizations_url":"https://api.github.com/users/sam-github/orgs","repos_url":"https://api.github.com/users/sam-github/repos","events_url":"https://api.github.com/users/sam-github/events{/privacy}","received_events_url":"https://api.github.com/users/sam-github/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/strongloop/strong-mesh-models/labels/%23review","name":"#review","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"rmg","id":17978,"avatar_url":"https://avatars.githubusercontent.com/u/17978?v=3","gravatar_id":"","url":"https://api.github.com/users/rmg","html_url":"https://github.com/rmg","followers_url":"https://api.github.com/users/rmg/followers","following_url":"https://api.github.com/users/rmg/following{/other_user}","gists_url":"https://api.github.com/users/rmg/gists{/gist_id}","starred_url":"https://api.github.com/users/rmg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmg/subscriptions","organizations_url":"https://api.github.com/users/rmg/orgs","repos_url":"https://api.github.com/users/rmg/repos","events_url":"https://api.github.com/users/rmg/events{/privacy}","received_events_url":"https://api.github.com/users/rmg/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-05-01T23:22:16Z","updated_at":"2015-05-01T23:32:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/strongloop/strong-mesh-models/pulls/45","html_url":"https://github.com/strongloop/strong-mesh-models/pull/45","diff_url":"https://github.com/strongloop/strong-mesh-models/pull/45.diff","patch_url":"https://github.com/strongloop/strong-mesh-models/pull/45.patch"},"body":"Only the set-size command was actually changing a running instance's\r\nsize. Updates to the size were being notified as onInstanceUpdate to pm,\r\nbut it wouldn't apply them to the running instance (doing so requires\r\nsending a set-size command).\r\n\r\nNow, if you don't want persistence, a set-size command is sent, which is\r\nnon-persistent.\r\n\r\nIf you do want persistence, the model is updated, that update goes to\r\npm, which then updates both the instance sl-run CLI options AND sends a\r\nset-size command to a running instance (if size has changed). Because of\r\nthis, the persistent branch that sends set-size is no longer necessary.\r\n\r\nAlso, some effort was being made to capture non-numeric values for cpus,\r\nand turn them into some default value. This code is confusing and\r\nunused, its now gone. The size can be set to whatever is wanted (whether\r\nthat size has any effect on strong-cluster-control is a different\r\nmatter).\r\n\r\nProbably, validation should occur, but that doesn't happen right now.\r\n\r\nconnected to strongloop-internal/scrum-nodeops#537"},"comment":{"url":"https://api.github.com/repos/strongloop/strong-mesh-models/issues/comments/98261028","html_url":"https://github.com/strongloop/strong-mesh-models/pull/45#issuecomment-98261028","issue_url":"https://api.github.com/repos/strongloop/strong-mesh-models/issues/45","id":98261028,"user":{"login":"rmg","id":17978,"avatar_url":"https://avatars.githubusercontent.com/u/17978?v=3","gravatar_id":"","url":"https://api.github.com/users/rmg","html_url":"https://github.com/rmg","followers_url":"https://api.github.com/users/rmg/followers","following_url":"https://api.github.com/users/rmg/following{/other_user}","gists_url":"https://api.github.com/users/rmg/gists{/gist_id}","starred_url":"https://api.github.com/users/rmg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmg/subscriptions","organizations_url":"https://api.github.com/users/rmg/orgs","repos_url":"https://api.github.com/users/rmg/repos","events_url":"https://api.github.com/users/rmg/events{/privacy}","received_events_url":"https://api.github.com/users/rmg/received_events","type":"User","site_admin":false},"created_at":"2015-05-01T23:32:26Z","updated_at":"2015-05-01T23:32:26Z","body":"The change looks pretty straight forward. LGTM."}}