{"action":"created","comment":{"url":"https://api.github.com/repos/jupyter/phosphor-notebook/pulls/comments/34727894","id":34727894,"diff_hunk":"@@ -434,7 +477,14 @@ class Kernel {\n   }\n \n   /**\n-   * Create a Kernel Message given input attributes.\n+   * Get the current kernel url.\n+   */\n+  private get _kernelUrl(): string {\n+    return utils.urlJoinEncode(this._baseUrl, KERNEL_SERVICE_URL, this._id);","path":"src/kernel.ts","position":210,"original_position":210,"commit_id":"b41ee17a9ab12a0ff19b27eb0deee8d8aca72f5b","original_commit_id":"b41ee17a9ab12a0ff19b27eb0deee8d8aca72f5b","user":{"login":"sccolbert","id":137289,"avatar_url":"https://avatars.githubusercontent.com/u/137289?v=3","gravatar_id":"","url":"https://api.github.com/users/sccolbert","html_url":"https://github.com/sccolbert","followers_url":"https://api.github.com/users/sccolbert/followers","following_url":"https://api.github.com/users/sccolbert/following{/other_user}","gists_url":"https://api.github.com/users/sccolbert/gists{/gist_id}","starred_url":"https://api.github.com/users/sccolbert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sccolbert/subscriptions","organizations_url":"https://api.github.com/users/sccolbert/orgs","repos_url":"https://api.github.com/users/sccolbert/repos","events_url":"https://api.github.com/users/sccolbert/events{/privacy}","received_events_url":"https://api.github.com/users/sccolbert/received_events","type":"User","site_admin":false},"body":"Should this be computed once in the constructor as a normal private member? Do `_baseUrl` and `_id` ever change?","created_at":"2015-07-15T20:54:28Z","updated_at":"2015-07-15T20:54:28Z","html_url":"https://github.com/jupyter/phosphor-notebook/pull/4#discussion_r34727894","pull_request_url":"https://api.github.com/repos/jupyter/phosphor-notebook/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/jupyter/phosphor-notebook/pulls/comments/34727894"},"html":{"href":"https://github.com/jupyter/phosphor-notebook/pull/4#discussion_r34727894"},"pull_request":{"href":"https://api.github.com/repos/jupyter/phosphor-notebook/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/jupyter/phosphor-notebook/pulls/4","id":39828248,"html_url":"https://github.com/jupyter/phosphor-notebook/pull/4","diff_url":"https://github.com/jupyter/phosphor-notebook/pull/4.diff","patch_url":"https://github.com/jupyter/phosphor-notebook/pull/4.patch","issue_url":"https://api.github.com/repos/jupyter/phosphor-notebook/issues/4","number":4,"state":"open","locked":false,"title":"Add Session","user":{"login":"blink1073","id":2096628,"avatar_url":"https://avatars.githubusercontent.com/u/2096628?v=3","gravatar_id":"","url":"https://api.github.com/users/blink1073","html_url":"https://github.com/blink1073","followers_url":"https://api.github.com/users/blink1073/followers","following_url":"https://api.github.com/users/blink1073/following{/other_user}","gists_url":"https://api.github.com/users/blink1073/gists{/gist_id}","starred_url":"https://api.github.com/users/blink1073/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blink1073/subscriptions","organizations_url":"https://api.github.com/users/blink1073/orgs","repos_url":"https://api.github.com/users/blink1073/repos","events_url":"https://api.github.com/users/blink1073/events{/privacy}","received_events_url":"https://api.github.com/users/blink1073/received_events","type":"User","site_admin":false},"body":"To view the REST API:\r\n\r\n- Go to http://petstore.swagger.io/#/\r\n- Put this in the url box at the top:\r\nhttps://raw.githubusercontent.com/jasongrout/notebook/swagger/notebook/services/api/api.yaml\r\n\r\n","created_at":"2015-07-13T16:08:15Z","updated_at":"2015-07-15T20:54:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89eb0acdcfeded5185bedd72d49060939e65ef67","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jupyter/phosphor-notebook/pulls/4/commits","review_comments_url":"https://api.github.com/repos/jupyter/phosphor-notebook/pulls/4/comments","review_comment_url":"https://api.github.com/repos/jupyter/phosphor-notebook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jupyter/phosphor-notebook/issues/4/comments","statuses_url":"https://api.github.com/repos/jupyter/phosphor-notebook/statuses/b41ee17a9ab12a0ff19b27eb0deee8d8aca72f5b","head":{"label":"blink1073:session-ts","ref":"session-ts","sha":"b41ee17a9ab12a0ff19b27eb0deee8d8aca72f5b","user":{"login":"blink1073","id":2096628,"avatar_url":"https://avatars.githubusercontent.com/u/2096628?v=3","gravatar_id":"","url":"https://api.github.com/users/blink1073","html_url":"https://github.com/blink1073","followers_url":"https://api.github.com/users/blink1073/followers","following_url":"https://api.github.com/users/blink1073/following{/other_user}","gists_url":"https://api.github.com/users/blink1073/gists{/gist_id}","starred_url":"https://api.github.com/users/blink1073/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blink1073/subscriptions","organizations_url":"https://api.github.com/users/blink1073/orgs","repos_url":"https://api.github.com/users/blink1073/repos","events_url":"https://api.github.com/users/blink1073/events{/privacy}","received_events_url":"https://api.github.com/users/blink1073/received_events","type":"User","site_admin":false},"repo":{"id":38313630,"name":"phosphor-notebook-1","full_name":"blink1073/phosphor-notebook-1","owner":{"login":"blink1073","id":2096628,"avatar_url":"https://avatars.githubusercontent.com/u/2096628?v=3","gravatar_id":"","url":"https://api.github.com/users/blink1073","html_url":"https://github.com/blink1073","followers_url":"https://api.github.com/users/blink1073/followers","following_url":"https://api.github.com/users/blink1073/following{/other_user}","gists_url":"https://api.github.com/users/blink1073/gists{/gist_id}","starred_url":"https://api.github.com/users/blink1073/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blink1073/subscriptions","organizations_url":"https://api.github.com/users/blink1073/orgs","repos_url":"https://api.github.com/users/blink1073/repos","events_url":"https://api.github.com/users/blink1073/events{/privacy}","received_events_url":"https://api.github.com/users/blink1073/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/blink1073/phosphor-notebook-1","description":"","fork":true,"url":"https://api.github.com/repos/blink1073/phosphor-notebook-1","forks_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/forks","keys_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/teams","hooks_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/hooks","issue_events_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/issues/events{/number}","events_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/events","assignees_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/assignees{/user}","branches_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/branches{/branch}","tags_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/tags","blobs_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/statuses/{sha}","languages_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/languages","stargazers_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/stargazers","contributors_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/contributors","subscribers_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/subscribers","subscription_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/subscription","commits_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/contents/{+path}","compare_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/merges","archive_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/downloads","issues_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/issues{/number}","pulls_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/pulls{/number}","milestones_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/milestones{/number}","notifications_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/labels{/name}","releases_url":"https://api.github.com/repos/blink1073/phosphor-notebook-1/releases{/id}","created_at":"2015-06-30T14:23:36Z","updated_at":"2015-06-30T14:23:36Z","pushed_at":"2015-07-15T20:47:34Z","git_url":"git://github.com/blink1073/phosphor-notebook-1.git","ssh_url":"git@github.com:blink1073/phosphor-notebook-1.git","clone_url":"https://github.com/blink1073/phosphor-notebook-1.git","svn_url":"https://github.com/blink1073/phosphor-notebook-1","homepage":null,"size":490,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jupyter:master","ref":"master","sha":"2f7ca4b14a04238810db9a4ddcd91dfb1c61bd00","user":{"login":"jupyter","id":7388996,"avatar_url":"https://avatars.githubusercontent.com/u/7388996?v=3","gravatar_id":"","url":"https://api.github.com/users/jupyter","html_url":"https://github.com/jupyter","followers_url":"https://api.github.com/users/jupyter/followers","following_url":"https://api.github.com/users/jupyter/following{/other_user}","gists_url":"https://api.github.com/users/jupyter/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyter/subscriptions","organizations_url":"https://api.github.com/users/jupyter/orgs","repos_url":"https://api.github.com/users/jupyter/repos","events_url":"https://api.github.com/users/jupyter/events{/privacy}","received_events_url":"https://api.github.com/users/jupyter/received_events","type":"Organization","site_admin":false},"repo":{"id":38249514,"name":"phosphor-notebook","full_name":"jupyter/phosphor-notebook","owner":{"login":"jupyter","id":7388996,"avatar_url":"https://avatars.githubusercontent.com/u/7388996?v=3","gravatar_id":"","url":"https://api.github.com/users/jupyter","html_url":"https://github.com/jupyter","followers_url":"https://api.github.com/users/jupyter/followers","following_url":"https://api.github.com/users/jupyter/following{/other_user}","gists_url":"https://api.github.com/users/jupyter/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyter/subscriptions","organizations_url":"https://api.github.com/users/jupyter/orgs","repos_url":"https://api.github.com/users/jupyter/repos","events_url":"https://api.github.com/users/jupyter/events{/privacy}","received_events_url":"https://api.github.com/users/jupyter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jupyter/phosphor-notebook","description":"","fork":false,"url":"https://api.github.com/repos/jupyter/phosphor-notebook","forks_url":"https://api.github.com/repos/jupyter/phosphor-notebook/forks","keys_url":"https://api.github.com/repos/jupyter/phosphor-notebook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jupyter/phosphor-notebook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jupyter/phosphor-notebook/teams","hooks_url":"https://api.github.com/repos/jupyter/phosphor-notebook/hooks","issue_events_url":"https://api.github.com/repos/jupyter/phosphor-notebook/issues/events{/number}","events_url":"https://api.github.com/repos/jupyter/phosphor-notebook/events","assignees_url":"https://api.github.com/repos/jupyter/phosphor-notebook/assignees{/user}","branches_url":"https://api.github.com/repos/jupyter/phosphor-notebook/branches{/branch}","tags_url":"https://api.github.com/repos/jupyter/phosphor-notebook/tags","blobs_url":"https://api.github.com/repos/jupyter/phosphor-notebook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jupyter/phosphor-notebook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jupyter/phosphor-notebook/git/refs{/sha}","trees_url":"https://api.github.com/repos/jupyter/phosphor-notebook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jupyter/phosphor-notebook/statuses/{sha}","languages_url":"https://api.github.com/repos/jupyter/phosphor-notebook/languages","stargazers_url":"https://api.github.com/repos/jupyter/phosphor-notebook/stargazers","contributors_url":"https://api.github.com/repos/jupyter/phosphor-notebook/contributors","subscribers_url":"https://api.github.com/repos/jupyter/phosphor-notebook/subscribers","subscription_url":"https://api.github.com/repos/jupyter/phosphor-notebook/subscription","commits_url":"https://api.github.com/repos/jupyter/phosphor-notebook/commits{/sha}","git_commits_url":"https://api.github.com/repos/jupyter/phosphor-notebook/git/commits{/sha}","comments_url":"https://api.github.com/repos/jupyter/phosphor-notebook/comments{/number}","issue_comment_url":"https://api.github.com/repos/jupyter/phosphor-notebook/issues/comments{/number}","contents_url":"https://api.github.com/repos/jupyter/phosphor-notebook/contents/{+path}","compare_url":"https://api.github.com/repos/jupyter/phosphor-notebook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jupyter/phosphor-notebook/merges","archive_url":"https://api.github.com/repos/jupyter/phosphor-notebook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jupyter/phosphor-notebook/downloads","issues_url":"https://api.github.com/repos/jupyter/phosphor-notebook/issues{/number}","pulls_url":"https://api.github.com/repos/jupyter/phosphor-notebook/pulls{/number}","milestones_url":"https://api.github.com/repos/jupyter/phosphor-notebook/milestones{/number}","notifications_url":"https://api.github.com/repos/jupyter/phosphor-notebook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jupyter/phosphor-notebook/labels{/name}","releases_url":"https://api.github.com/repos/jupyter/phosphor-notebook/releases{/id}","created_at":"2015-06-29T13:37:35Z","updated_at":"2015-07-11T18:28:24Z","pushed_at":"2015-07-15T20:47:35Z","git_url":"git://github.com/jupyter/phosphor-notebook.git","ssh_url":"git@github.com:jupyter/phosphor-notebook.git","clone_url":"https://github.com/jupyter/phosphor-notebook.git","svn_url":"https://github.com/jupyter/phosphor-notebook","homepage":null,"size":790,"stargazers_count":4,"watchers_count":4,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jupyter/phosphor-notebook/pulls/4"},"html":{"href":"https://github.com/jupyter/phosphor-notebook/pull/4"},"issue":{"href":"https://api.github.com/repos/jupyter/phosphor-notebook/issues/4"},"comments":{"href":"https://api.github.com/repos/jupyter/phosphor-notebook/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/jupyter/phosphor-notebook/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/jupyter/phosphor-notebook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jupyter/phosphor-notebook/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/jupyter/phosphor-notebook/statuses/b41ee17a9ab12a0ff19b27eb0deee8d8aca72f5b"}}}}