{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/24207220","id":24207220,"diff_hunk":"@@ -472,12 +512,12 @@ private[ui] class StagePage(parent: StagesTab) extends WebUIPage(\"stage\") {\n         }}\n         {if (hasInput) {\n           <td sorttable_customkey={inputSortable}>\n-            {inputReadable}\n+            {s\"$inputReadable / $inputRecords\"}","path":"core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala","position":185,"original_position":185,"commit_id":"9ecf912adddb9a4fb49c8fa9907eba6d3a947d00","original_commit_id":"fe3f715819e19eba122e5973d5172fa190a80210","user":{"login":"ksakellis","id":6590087,"avatar_url":"https://avatars.githubusercontent.com/u/6590087?v=3","gravatar_id":"","url":"https://api.github.com/users/ksakellis","html_url":"https://github.com/ksakellis","followers_url":"https://api.github.com/users/ksakellis/followers","following_url":"https://api.github.com/users/ksakellis/following{/other_user}","gists_url":"https://api.github.com/users/ksakellis/gists{/gist_id}","starred_url":"https://api.github.com/users/ksakellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksakellis/subscriptions","organizations_url":"https://api.github.com/users/ksakellis/orgs","repos_url":"https://api.github.com/users/ksakellis/repos","events_url":"https://api.github.com/users/ksakellis/events{/privacy}","received_events_url":"https://api.github.com/users/ksakellis/received_events","type":"User","site_admin":false},"body":"I worry that it would be confusing to a user if they see 0 because that is valid number of num records read/written. but maybe that is better than seeing -45.","created_at":"2015-02-05T22:42:47Z","updated_at":"2015-02-05T22:42:47Z","html_url":"https://github.com/apache/spark/pull/4067#discussion_r24207220","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/4067","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/24207220"},"html":{"href":"https://github.com/apache/spark/pull/4067#discussion_r24207220"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/4067"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/4067","id":27479929,"html_url":"https://github.com/apache/spark/pull/4067","diff_url":"https://github.com/apache/spark/pull/4067.diff","patch_url":"https://github.com/apache/spark/pull/4067.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/4067","number":4067,"state":"open","locked":false,"title":"[SPARK-4874] [CORE] Collect record count metrics","user":{"login":"ksakellis","id":6590087,"avatar_url":"https://avatars.githubusercontent.com/u/6590087?v=3","gravatar_id":"","url":"https://api.github.com/users/ksakellis","html_url":"https://github.com/ksakellis","followers_url":"https://api.github.com/users/ksakellis/followers","following_url":"https://api.github.com/users/ksakellis/following{/other_user}","gists_url":"https://api.github.com/users/ksakellis/gists{/gist_id}","starred_url":"https://api.github.com/users/ksakellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksakellis/subscriptions","organizations_url":"https://api.github.com/users/ksakellis/orgs","repos_url":"https://api.github.com/users/ksakellis/repos","events_url":"https://api.github.com/users/ksakellis/events{/privacy}","received_events_url":"https://api.github.com/users/ksakellis/received_events","type":"User","site_admin":false},"body":"Collects record counts for both Input/Output and Shuffle Metrics. For the input/output metrics, it just appends the counter every time the iterators get accessed.\r\n    \r\nFor shuffle on the write side, we count the metrics post aggregation (after a map side combine) and on the read side we count the metrics pre aggregation. This allows both the bytes read/written metrics and the records read/written to line up.\r\n\r\nFor backwards compatibility, if we deserialize an older event that doesn't have record metrics, we set the metric to -1.","created_at":"2015-01-16T02:18:58Z","updated_at":"2015-02-05T22:42:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7fcd202b21e47019c5551082270c44ca30f4cfd6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/4067/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/4067/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/spark/issues/4067/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/9ecf912adddb9a4fb49c8fa9907eba6d3a947d00","head":{"label":"ksakellis:kostas-spark-4874","ref":"kostas-spark-4874","sha":"9ecf912adddb9a4fb49c8fa9907eba6d3a947d00","user":{"login":"ksakellis","id":6590087,"avatar_url":"https://avatars.githubusercontent.com/u/6590087?v=3","gravatar_id":"","url":"https://api.github.com/users/ksakellis","html_url":"https://github.com/ksakellis","followers_url":"https://api.github.com/users/ksakellis/followers","following_url":"https://api.github.com/users/ksakellis/following{/other_user}","gists_url":"https://api.github.com/users/ksakellis/gists{/gist_id}","starred_url":"https://api.github.com/users/ksakellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksakellis/subscriptions","organizations_url":"https://api.github.com/users/ksakellis/orgs","repos_url":"https://api.github.com/users/ksakellis/repos","events_url":"https://api.github.com/users/ksakellis/events{/privacy}","received_events_url":"https://api.github.com/users/ksakellis/received_events","type":"User","site_admin":false},"repo":{"id":23167909,"name":"spark","full_name":"ksakellis/spark","owner":{"login":"ksakellis","id":6590087,"avatar_url":"https://avatars.githubusercontent.com/u/6590087?v=3","gravatar_id":"","url":"https://api.github.com/users/ksakellis","html_url":"https://github.com/ksakellis","followers_url":"https://api.github.com/users/ksakellis/followers","following_url":"https://api.github.com/users/ksakellis/following{/other_user}","gists_url":"https://api.github.com/users/ksakellis/gists{/gist_id}","starred_url":"https://api.github.com/users/ksakellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksakellis/subscriptions","organizations_url":"https://api.github.com/users/ksakellis/orgs","repos_url":"https://api.github.com/users/ksakellis/repos","events_url":"https://api.github.com/users/ksakellis/events{/privacy}","received_events_url":"https://api.github.com/users/ksakellis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ksakellis/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/ksakellis/spark","forks_url":"https://api.github.com/repos/ksakellis/spark/forks","keys_url":"https://api.github.com/repos/ksakellis/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ksakellis/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ksakellis/spark/teams","hooks_url":"https://api.github.com/repos/ksakellis/spark/hooks","issue_events_url":"https://api.github.com/repos/ksakellis/spark/issues/events{/number}","events_url":"https://api.github.com/repos/ksakellis/spark/events","assignees_url":"https://api.github.com/repos/ksakellis/spark/assignees{/user}","branches_url":"https://api.github.com/repos/ksakellis/spark/branches{/branch}","tags_url":"https://api.github.com/repos/ksakellis/spark/tags","blobs_url":"https://api.github.com/repos/ksakellis/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ksakellis/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ksakellis/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/ksakellis/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ksakellis/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/ksakellis/spark/languages","stargazers_url":"https://api.github.com/repos/ksakellis/spark/stargazers","contributors_url":"https://api.github.com/repos/ksakellis/spark/contributors","subscribers_url":"https://api.github.com/repos/ksakellis/spark/subscribers","subscription_url":"https://api.github.com/repos/ksakellis/spark/subscription","commits_url":"https://api.github.com/repos/ksakellis/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/ksakellis/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/ksakellis/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/ksakellis/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/ksakellis/spark/contents/{+path}","compare_url":"https://api.github.com/repos/ksakellis/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ksakellis/spark/merges","archive_url":"https://api.github.com/repos/ksakellis/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ksakellis/spark/downloads","issues_url":"https://api.github.com/repos/ksakellis/spark/issues{/number}","pulls_url":"https://api.github.com/repos/ksakellis/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/ksakellis/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/ksakellis/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ksakellis/spark/labels{/name}","releases_url":"https://api.github.com/repos/ksakellis/spark/releases{/id}","created_at":"2014-08-20T23:45:14Z","updated_at":"2015-02-05T21:10:47Z","pushed_at":"2015-02-05T21:10:47Z","git_url":"git://github.com/ksakellis/spark.git","ssh_url":"git@github.com:ksakellis/spark.git","clone_url":"https://github.com/ksakellis/spark.git","svn_url":"https://github.com/ksakellis/spark","homepage":null,"size":88333,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"681f9df47ff40f7b0d9175d835e9758d33a13a06","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-02-05T22:33:23Z","pushed_at":"2015-02-05T21:08:24Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1226842,"stargazers_count":2792,"watchers_count":2792,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2443,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":302,"forks":2443,"open_issues":302,"watchers":2792,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/4067"},"html":{"href":"https://github.com/apache/spark/pull/4067"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/4067"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/4067/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/4067/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/4067/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/9ecf912adddb9a4fb49c8fa9907eba6d3a947d00"}}}}