{"action":"created","comment":{"url":"https://api.github.com/repos/Particular/NServiceBus/pulls/comments/41987686","id":41987686,"diff_hunk":"@@ -6,264 +6,100 @@\n     using System.IO;\n     using System.Linq;\n     using System.Reflection;\n-    using System.Text;\n     using System.Xml;\n     using System.Xml.Linq;\n     using NServiceBus.Utils.Reflection;\n \n+    class RawXmlTextWriter : XmlTextWriter","path":"src/NServiceBus.Core/Serializers/XML/Serializer.cs","position":9,"original_position":9,"commit_id":"89eb026814a48f9bafa5daac051e19e62a2bf118","original_commit_id":"89eb026814a48f9bafa5daac051e19e62a2bf118","user":{"login":"hmemcpy","id":601206,"avatar_url":"https://avatars.githubusercontent.com/u/601206?v=3","gravatar_id":"","url":"https://api.github.com/users/hmemcpy","html_url":"https://github.com/hmemcpy","followers_url":"https://api.github.com/users/hmemcpy/followers","following_url":"https://api.github.com/users/hmemcpy/following{/other_user}","gists_url":"https://api.github.com/users/hmemcpy/gists{/gist_id}","starred_url":"https://api.github.com/users/hmemcpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmemcpy/subscriptions","organizations_url":"https://api.github.com/users/hmemcpy/orgs","repos_url":"https://api.github.com/users/hmemcpy/repos","events_url":"https://api.github.com/users/hmemcpy/events{/privacy}","received_events_url":"https://api.github.com/users/hmemcpy/received_events","type":"User","site_admin":false},"body":"@adamralph nope, a private class is fine. I'll change it!","created_at":"2015-10-14T12:40:54Z","updated_at":"2015-10-14T12:40:54Z","html_url":"https://github.com/Particular/NServiceBus/pull/2821#discussion_r41987686","pull_request_url":"https://api.github.com/repos/Particular/NServiceBus/pulls/2821","_links":{"self":{"href":"https://api.github.com/repos/Particular/NServiceBus/pulls/comments/41987686"},"html":{"href":"https://github.com/Particular/NServiceBus/pull/2821#discussion_r41987686"},"pull_request":{"href":"https://api.github.com/repos/Particular/NServiceBus/pulls/2821"}}},"pull_request":{"url":"https://api.github.com/repos/Particular/NServiceBus/pulls/2821","id":43173698,"html_url":"https://github.com/Particular/NServiceBus/pull/2821","diff_url":"https://github.com/Particular/NServiceBus/pull/2821.diff","patch_url":"https://github.com/Particular/NServiceBus/pull/2821.patch","issue_url":"https://api.github.com/repos/Particular/NServiceBus/issues/2821","number":2821,"state":"open","locked":false,"title":"Merge hotfix 5.2.5 to develop","user":{"login":"hmemcpy","id":601206,"avatar_url":"https://avatars.githubusercontent.com/u/601206?v=3","gravatar_id":"","url":"https://api.github.com/users/hmemcpy","html_url":"https://github.com/hmemcpy","followers_url":"https://api.github.com/users/hmemcpy/followers","following_url":"https://api.github.com/users/hmemcpy/following{/other_user}","gists_url":"https://api.github.com/users/hmemcpy/gists{/gist_id}","starred_url":"https://api.github.com/users/hmemcpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmemcpy/subscriptions","organizations_url":"https://api.github.com/users/hmemcpy/orgs","repos_url":"https://api.github.com/users/hmemcpy/repos","events_url":"https://api.github.com/users/hmemcpy/events{/privacy}","received_events_url":"https://api.github.com/users/hmemcpy/received_events","type":"User","site_admin":false},"body":"Taskforce: @hmemcpy @adamralph \n\nThis relates to #2796, porting this to the 6.0 branch proved somewhat more difficult. The XML document needs to be updated with the missing namespaces AFTER the object had been serialized. This is not quite possible with writing to a stream directly.\n\nRefactoring to use `XDocument` to write out the XML, in addition to a custom xml stream writer to avoid \"well-formed\" encoding issues by XDocument (to preserve current behavior)\n\nConnects to #2796","created_at":"2015-08-24T13:23:34Z","updated_at":"2015-10-14T12:40:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb60de94792e2fc30db4ce86a2470355df2c08bb","assignee":{"login":"hmemcpy","id":601206,"avatar_url":"https://avatars.githubusercontent.com/u/601206?v=3","gravatar_id":"","url":"https://api.github.com/users/hmemcpy","html_url":"https://github.com/hmemcpy","followers_url":"https://api.github.com/users/hmemcpy/followers","following_url":"https://api.github.com/users/hmemcpy/following{/other_user}","gists_url":"https://api.github.com/users/hmemcpy/gists{/gist_id}","starred_url":"https://api.github.com/users/hmemcpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmemcpy/subscriptions","organizations_url":"https://api.github.com/users/hmemcpy/orgs","repos_url":"https://api.github.com/users/hmemcpy/repos","events_url":"https://api.github.com/users/hmemcpy/events{/privacy}","received_events_url":"https://api.github.com/users/hmemcpy/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Particular/NServiceBus/pulls/2821/commits","review_comments_url":"https://api.github.com/repos/Particular/NServiceBus/pulls/2821/comments","review_comment_url":"https://api.github.com/repos/Particular/NServiceBus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Particular/NServiceBus/issues/2821/comments","statuses_url":"https://api.github.com/repos/Particular/NServiceBus/statuses/89eb026814a48f9bafa5daac051e19e62a2bf118","head":{"label":"Particular:XmlSerializer-refactoring","ref":"XmlSerializer-refactoring","sha":"89eb026814a48f9bafa5daac051e19e62a2bf118","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":1056713,"name":"NServiceBus","full_name":"Particular/NServiceBus","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/NServiceBus","description":"The most popular service bus for .NET","fork":false,"url":"https://api.github.com/repos/Particular/NServiceBus","forks_url":"https://api.github.com/repos/Particular/NServiceBus/forks","keys_url":"https://api.github.com/repos/Particular/NServiceBus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/NServiceBus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/NServiceBus/teams","hooks_url":"https://api.github.com/repos/Particular/NServiceBus/hooks","issue_events_url":"https://api.github.com/repos/Particular/NServiceBus/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/NServiceBus/events","assignees_url":"https://api.github.com/repos/Particular/NServiceBus/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/NServiceBus/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/NServiceBus/tags","blobs_url":"https://api.github.com/repos/Particular/NServiceBus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/NServiceBus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/NServiceBus/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/NServiceBus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/NServiceBus/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/NServiceBus/languages","stargazers_url":"https://api.github.com/repos/Particular/NServiceBus/stargazers","contributors_url":"https://api.github.com/repos/Particular/NServiceBus/contributors","subscribers_url":"https://api.github.com/repos/Particular/NServiceBus/subscribers","subscription_url":"https://api.github.com/repos/Particular/NServiceBus/subscription","commits_url":"https://api.github.com/repos/Particular/NServiceBus/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/NServiceBus/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/NServiceBus/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/NServiceBus/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/NServiceBus/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/NServiceBus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/NServiceBus/merges","archive_url":"https://api.github.com/repos/Particular/NServiceBus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/NServiceBus/downloads","issues_url":"https://api.github.com/repos/Particular/NServiceBus/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/NServiceBus/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/NServiceBus/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/NServiceBus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/NServiceBus/labels{/name}","releases_url":"https://api.github.com/repos/Particular/NServiceBus/releases{/id}","created_at":"2010-11-06T12:54:52Z","updated_at":"2015-10-13T07:06:42Z","pushed_at":"2015-10-14T12:09:31Z","git_url":"git://github.com/Particular/NServiceBus.git","ssh_url":"git@github.com:Particular/NServiceBus.git","clone_url":"https://github.com/Particular/NServiceBus.git","svn_url":"https://github.com/Particular/NServiceBus","homepage":"http://particular.net/nservicebus","size":231080,"stargazers_count":787,"watchers_count":787,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":444,"mirror_url":null,"open_issues_count":169,"forks":444,"open_issues":169,"watchers":787,"default_branch":"develop"}},"base":{"label":"Particular:develop","ref":"develop","sha":"9b79b6224a17e480b20e86530ec0db9bf9b9213b","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":1056713,"name":"NServiceBus","full_name":"Particular/NServiceBus","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/NServiceBus","description":"The most popular service bus for .NET","fork":false,"url":"https://api.github.com/repos/Particular/NServiceBus","forks_url":"https://api.github.com/repos/Particular/NServiceBus/forks","keys_url":"https://api.github.com/repos/Particular/NServiceBus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/NServiceBus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/NServiceBus/teams","hooks_url":"https://api.github.com/repos/Particular/NServiceBus/hooks","issue_events_url":"https://api.github.com/repos/Particular/NServiceBus/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/NServiceBus/events","assignees_url":"https://api.github.com/repos/Particular/NServiceBus/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/NServiceBus/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/NServiceBus/tags","blobs_url":"https://api.github.com/repos/Particular/NServiceBus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/NServiceBus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/NServiceBus/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/NServiceBus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/NServiceBus/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/NServiceBus/languages","stargazers_url":"https://api.github.com/repos/Particular/NServiceBus/stargazers","contributors_url":"https://api.github.com/repos/Particular/NServiceBus/contributors","subscribers_url":"https://api.github.com/repos/Particular/NServiceBus/subscribers","subscription_url":"https://api.github.com/repos/Particular/NServiceBus/subscription","commits_url":"https://api.github.com/repos/Particular/NServiceBus/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/NServiceBus/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/NServiceBus/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/NServiceBus/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/NServiceBus/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/NServiceBus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/NServiceBus/merges","archive_url":"https://api.github.com/repos/Particular/NServiceBus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/NServiceBus/downloads","issues_url":"https://api.github.com/repos/Particular/NServiceBus/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/NServiceBus/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/NServiceBus/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/NServiceBus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/NServiceBus/labels{/name}","releases_url":"https://api.github.com/repos/Particular/NServiceBus/releases{/id}","created_at":"2010-11-06T12:54:52Z","updated_at":"2015-10-13T07:06:42Z","pushed_at":"2015-10-14T12:09:31Z","git_url":"git://github.com/Particular/NServiceBus.git","ssh_url":"git@github.com:Particular/NServiceBus.git","clone_url":"https://github.com/Particular/NServiceBus.git","svn_url":"https://github.com/Particular/NServiceBus","homepage":"http://particular.net/nservicebus","size":231080,"stargazers_count":787,"watchers_count":787,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":444,"mirror_url":null,"open_issues_count":169,"forks":444,"open_issues":169,"watchers":787,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Particular/NServiceBus/pulls/2821"},"html":{"href":"https://github.com/Particular/NServiceBus/pull/2821"},"issue":{"href":"https://api.github.com/repos/Particular/NServiceBus/issues/2821"},"comments":{"href":"https://api.github.com/repos/Particular/NServiceBus/issues/2821/comments"},"review_comments":{"href":"https://api.github.com/repos/Particular/NServiceBus/pulls/2821/comments"},"review_comment":{"href":"https://api.github.com/repos/Particular/NServiceBus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Particular/NServiceBus/pulls/2821/commits"},"statuses":{"href":"https://api.github.com/repos/Particular/NServiceBus/statuses/89eb026814a48f9bafa5daac051e19e62a2bf118"}}}}