{"action":"created","comment":{"url":"https://api.github.com/repos/fluid-project/first-discovery/pulls/comments/30734256","id":30734256,"diff_hunk":"@@ -106,8 +106,9 @@ https://github.com/fluid-project/infusion/raw/master/Infusion-LICENSE.txt\n     };\n \n     gpii.firstDiscovery.panel.ranged.updateButtonState = function (that) {\n-        var isMax = that.model.value >= that.options.range.max;\n-        var isMin = that.model.value <= that.options.range.min;\n+        // assumes that values can't go out of range (based on range limit modelRelay)\n+        var isMax = fluid.model.isSameValue(that.model.value, that.options.range.max);\n+        var isMin = fluid.model.isSameValue(that.model.value, that.options.range.min);","path":"src/js/panels.js","position":8,"original_position":8,"commit_id":"672a825b3abf469ca53255aae54c8fec29e25a45","original_commit_id":"672a825b3abf469ca53255aae54c8fec29e25a45","user":{"login":"cindyli","id":572877,"avatar_url":"https://avatars.githubusercontent.com/u/572877?v=3","gravatar_id":"","url":"https://api.github.com/users/cindyli","html_url":"https://github.com/cindyli","followers_url":"https://api.github.com/users/cindyli/followers","following_url":"https://api.github.com/users/cindyli/following{/other_user}","gists_url":"https://api.github.com/users/cindyli/gists{/gist_id}","starred_url":"https://api.github.com/users/cindyli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cindyli/subscriptions","organizations_url":"https://api.github.com/users/cindyli/orgs","repos_url":"https://api.github.com/users/cindyli/repos","events_url":"https://api.github.com/users/cindyli/events{/privacy}","received_events_url":"https://api.github.com/users/cindyli/received_events","type":"User","site_admin":false},"body":"we probably should add isMax and isMin into model and use model relay with \"fluid.transforms.binaryOp\" transform to calculate them. Then the enabling/disabling of buttons can be done via model listeners.","created_at":"2015-05-20T18:35:33Z","updated_at":"2015-05-20T18:35:33Z","html_url":"https://github.com/fluid-project/first-discovery/pull/53#discussion_r30734256","pull_request_url":"https://api.github.com/repos/fluid-project/first-discovery/pulls/53","_links":{"self":{"href":"https://api.github.com/repos/fluid-project/first-discovery/pulls/comments/30734256"},"html":{"href":"https://github.com/fluid-project/first-discovery/pull/53#discussion_r30734256"},"pull_request":{"href":"https://api.github.com/repos/fluid-project/first-discovery/pulls/53"}}},"pull_request":{"url":"https://api.github.com/repos/fluid-project/first-discovery/pulls/53","id":35859093,"html_url":"https://github.com/fluid-project/first-discovery/pull/53","diff_url":"https://github.com/fluid-project/first-discovery/pull/53.diff","patch_url":"https://github.com/fluid-project/first-discovery/pull/53.patch","issue_url":"https://api.github.com/repos/fluid-project/first-discovery/issues/53","number":53,"state":"open","locked":false,"title":"FLOE-346: Disabling at min","user":{"login":"jobara","id":556024,"avatar_url":"https://avatars.githubusercontent.com/u/556024?v=3","gravatar_id":"","url":"https://api.github.com/users/jobara","html_url":"https://github.com/jobara","followers_url":"https://api.github.com/users/jobara/followers","following_url":"https://api.github.com/users/jobara/following{/other_user}","gists_url":"https://api.github.com/users/jobara/gists{/gist_id}","starred_url":"https://api.github.com/users/jobara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jobara/subscriptions","organizations_url":"https://api.github.com/users/jobara/orgs","repos_url":"https://api.github.com/users/jobara/repos","events_url":"https://api.github.com/users/jobara/events{/privacy}","received_events_url":"https://api.github.com/users/jobara/received_events","type":"User","site_admin":false},"body":"The min value wasn't disabling the button due to floating point inaccuracies. This has been taken care of by using fluid.model.isSameValue.\r\n\r\nAlso modified the text for the textSize panel.\r\n\r\nhttp://issues.fluidproject.org/browse/FLOE-346","created_at":"2015-05-20T18:01:49Z","updated_at":"2015-05-20T18:35:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49e5f65c7e3ec394366cbe708c90786638a56ce1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fluid-project/first-discovery/pulls/53/commits","review_comments_url":"https://api.github.com/repos/fluid-project/first-discovery/pulls/53/comments","review_comment_url":"https://api.github.com/repos/fluid-project/first-discovery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fluid-project/first-discovery/issues/53/comments","statuses_url":"https://api.github.com/repos/fluid-project/first-discovery/statuses/672a825b3abf469ca53255aae54c8fec29e25a45","head":{"label":"jobara:FLOE-346","ref":"FLOE-346","sha":"672a825b3abf469ca53255aae54c8fec29e25a45","user":{"login":"jobara","id":556024,"avatar_url":"https://avatars.githubusercontent.com/u/556024?v=3","gravatar_id":"","url":"https://api.github.com/users/jobara","html_url":"https://github.com/jobara","followers_url":"https://api.github.com/users/jobara/followers","following_url":"https://api.github.com/users/jobara/following{/other_user}","gists_url":"https://api.github.com/users/jobara/gists{/gist_id}","starred_url":"https://api.github.com/users/jobara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jobara/subscriptions","organizations_url":"https://api.github.com/users/jobara/orgs","repos_url":"https://api.github.com/users/jobara/repos","events_url":"https://api.github.com/users/jobara/events{/privacy}","received_events_url":"https://api.github.com/users/jobara/received_events","type":"User","site_admin":false},"repo":{"id":30076316,"name":"first-discovery","full_name":"jobara/first-discovery","owner":{"login":"jobara","id":556024,"avatar_url":"https://avatars.githubusercontent.com/u/556024?v=3","gravatar_id":"","url":"https://api.github.com/users/jobara","html_url":"https://github.com/jobara","followers_url":"https://api.github.com/users/jobara/followers","following_url":"https://api.github.com/users/jobara/following{/other_user}","gists_url":"https://api.github.com/users/jobara/gists{/gist_id}","starred_url":"https://api.github.com/users/jobara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jobara/subscriptions","organizations_url":"https://api.github.com/users/jobara/orgs","repos_url":"https://api.github.com/users/jobara/repos","events_url":"https://api.github.com/users/jobara/events{/privacy}","received_events_url":"https://api.github.com/users/jobara/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jobara/first-discovery","description":"A preferences editor tool that helps users discovery their initial preferences.","fork":true,"url":"https://api.github.com/repos/jobara/first-discovery","forks_url":"https://api.github.com/repos/jobara/first-discovery/forks","keys_url":"https://api.github.com/repos/jobara/first-discovery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jobara/first-discovery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jobara/first-discovery/teams","hooks_url":"https://api.github.com/repos/jobara/first-discovery/hooks","issue_events_url":"https://api.github.com/repos/jobara/first-discovery/issues/events{/number}","events_url":"https://api.github.com/repos/jobara/first-discovery/events","assignees_url":"https://api.github.com/repos/jobara/first-discovery/assignees{/user}","branches_url":"https://api.github.com/repos/jobara/first-discovery/branches{/branch}","tags_url":"https://api.github.com/repos/jobara/first-discovery/tags","blobs_url":"https://api.github.com/repos/jobara/first-discovery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jobara/first-discovery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jobara/first-discovery/git/refs{/sha}","trees_url":"https://api.github.com/repos/jobara/first-discovery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jobara/first-discovery/statuses/{sha}","languages_url":"https://api.github.com/repos/jobara/first-discovery/languages","stargazers_url":"https://api.github.com/repos/jobara/first-discovery/stargazers","contributors_url":"https://api.github.com/repos/jobara/first-discovery/contributors","subscribers_url":"https://api.github.com/repos/jobara/first-discovery/subscribers","subscription_url":"https://api.github.com/repos/jobara/first-discovery/subscription","commits_url":"https://api.github.com/repos/jobara/first-discovery/commits{/sha}","git_commits_url":"https://api.github.com/repos/jobara/first-discovery/git/commits{/sha}","comments_url":"https://api.github.com/repos/jobara/first-discovery/comments{/number}","issue_comment_url":"https://api.github.com/repos/jobara/first-discovery/issues/comments{/number}","contents_url":"https://api.github.com/repos/jobara/first-discovery/contents/{+path}","compare_url":"https://api.github.com/repos/jobara/first-discovery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jobara/first-discovery/merges","archive_url":"https://api.github.com/repos/jobara/first-discovery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jobara/first-discovery/downloads","issues_url":"https://api.github.com/repos/jobara/first-discovery/issues{/number}","pulls_url":"https://api.github.com/repos/jobara/first-discovery/pulls{/number}","milestones_url":"https://api.github.com/repos/jobara/first-discovery/milestones{/number}","notifications_url":"https://api.github.com/repos/jobara/first-discovery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jobara/first-discovery/labels{/name}","releases_url":"https://api.github.com/repos/jobara/first-discovery/releases{/id}","created_at":"2015-01-30T14:53:05Z","updated_at":"2015-05-04T19:41:54Z","pushed_at":"2015-05-20T18:01:25Z","git_url":"git://github.com/jobara/first-discovery.git","ssh_url":"git@github.com:jobara/first-discovery.git","clone_url":"https://github.com/jobara/first-discovery.git","svn_url":"https://github.com/jobara/first-discovery","homepage":null,"size":2060,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fluid-project:master","ref":"master","sha":"4e9ea40684df5ccb59d9d173569bb5d0acd5ac3e","user":{"login":"fluid-project","id":560119,"avatar_url":"https://avatars.githubusercontent.com/u/560119?v=3","gravatar_id":"","url":"https://api.github.com/users/fluid-project","html_url":"https://github.com/fluid-project","followers_url":"https://api.github.com/users/fluid-project/followers","following_url":"https://api.github.com/users/fluid-project/following{/other_user}","gists_url":"https://api.github.com/users/fluid-project/gists{/gist_id}","starred_url":"https://api.github.com/users/fluid-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluid-project/subscriptions","organizations_url":"https://api.github.com/users/fluid-project/orgs","repos_url":"https://api.github.com/users/fluid-project/repos","events_url":"https://api.github.com/users/fluid-project/events{/privacy}","received_events_url":"https://api.github.com/users/fluid-project/received_events","type":"Organization","site_admin":false},"repo":{"id":29699220,"name":"first-discovery","full_name":"fluid-project/first-discovery","owner":{"login":"fluid-project","id":560119,"avatar_url":"https://avatars.githubusercontent.com/u/560119?v=3","gravatar_id":"","url":"https://api.github.com/users/fluid-project","html_url":"https://github.com/fluid-project","followers_url":"https://api.github.com/users/fluid-project/followers","following_url":"https://api.github.com/users/fluid-project/following{/other_user}","gists_url":"https://api.github.com/users/fluid-project/gists{/gist_id}","starred_url":"https://api.github.com/users/fluid-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluid-project/subscriptions","organizations_url":"https://api.github.com/users/fluid-project/orgs","repos_url":"https://api.github.com/users/fluid-project/repos","events_url":"https://api.github.com/users/fluid-project/events{/privacy}","received_events_url":"https://api.github.com/users/fluid-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fluid-project/first-discovery","description":"A preferences editor tool that helps users discovery their initial preferences.","fork":false,"url":"https://api.github.com/repos/fluid-project/first-discovery","forks_url":"https://api.github.com/repos/fluid-project/first-discovery/forks","keys_url":"https://api.github.com/repos/fluid-project/first-discovery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fluid-project/first-discovery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fluid-project/first-discovery/teams","hooks_url":"https://api.github.com/repos/fluid-project/first-discovery/hooks","issue_events_url":"https://api.github.com/repos/fluid-project/first-discovery/issues/events{/number}","events_url":"https://api.github.com/repos/fluid-project/first-discovery/events","assignees_url":"https://api.github.com/repos/fluid-project/first-discovery/assignees{/user}","branches_url":"https://api.github.com/repos/fluid-project/first-discovery/branches{/branch}","tags_url":"https://api.github.com/repos/fluid-project/first-discovery/tags","blobs_url":"https://api.github.com/repos/fluid-project/first-discovery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fluid-project/first-discovery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fluid-project/first-discovery/git/refs{/sha}","trees_url":"https://api.github.com/repos/fluid-project/first-discovery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fluid-project/first-discovery/statuses/{sha}","languages_url":"https://api.github.com/repos/fluid-project/first-discovery/languages","stargazers_url":"https://api.github.com/repos/fluid-project/first-discovery/stargazers","contributors_url":"https://api.github.com/repos/fluid-project/first-discovery/contributors","subscribers_url":"https://api.github.com/repos/fluid-project/first-discovery/subscribers","subscription_url":"https://api.github.com/repos/fluid-project/first-discovery/subscription","commits_url":"https://api.github.com/repos/fluid-project/first-discovery/commits{/sha}","git_commits_url":"https://api.github.com/repos/fluid-project/first-discovery/git/commits{/sha}","comments_url":"https://api.github.com/repos/fluid-project/first-discovery/comments{/number}","issue_comment_url":"https://api.github.com/repos/fluid-project/first-discovery/issues/comments{/number}","contents_url":"https://api.github.com/repos/fluid-project/first-discovery/contents/{+path}","compare_url":"https://api.github.com/repos/fluid-project/first-discovery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fluid-project/first-discovery/merges","archive_url":"https://api.github.com/repos/fluid-project/first-discovery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fluid-project/first-discovery/downloads","issues_url":"https://api.github.com/repos/fluid-project/first-discovery/issues{/number}","pulls_url":"https://api.github.com/repos/fluid-project/first-discovery/pulls{/number}","milestones_url":"https://api.github.com/repos/fluid-project/first-discovery/milestones{/number}","notifications_url":"https://api.github.com/repos/fluid-project/first-discovery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fluid-project/first-discovery/labels{/name}","releases_url":"https://api.github.com/repos/fluid-project/first-discovery/releases{/id}","created_at":"2015-01-22T20:43:21Z","updated_at":"2015-05-04T19:42:24Z","pushed_at":"2015-05-20T18:01:49Z","git_url":"git://github.com/fluid-project/first-discovery.git","ssh_url":"git@github.com:fluid-project/first-discovery.git","clone_url":"https://github.com/fluid-project/first-discovery.git","svn_url":"https://github.com/fluid-project/first-discovery","homepage":null,"size":2373,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":2,"forks":7,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fluid-project/first-discovery/pulls/53"},"html":{"href":"https://github.com/fluid-project/first-discovery/pull/53"},"issue":{"href":"https://api.github.com/repos/fluid-project/first-discovery/issues/53"},"comments":{"href":"https://api.github.com/repos/fluid-project/first-discovery/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/fluid-project/first-discovery/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/fluid-project/first-discovery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fluid-project/first-discovery/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/fluid-project/first-discovery/statuses/672a825b3abf469ca53255aae54c8fec29e25a45"}}}}