{"action":"created","comment":{"url":"https://api.github.com/repos/canjs/can-ssr/pulls/comments/46207891","id":46207891,"diff_hunk":"@@ -76,7 +75,8 @@ can.view.callbacks._tags[\"can-import\"] = function(el, tagData){\n \t\tif(isAPage) {\n \t\t\tparentMap[name] = false;\n \t\t}\n-\t\troot.attr(\"__renderingAssets\").push(name);\n+\n+\t\tcanWait.data({ page: name });","path":"lib/plugins/canjs.js","position":14,"original_position":14,"commit_id":"3260ade063ecc1ae3265c0d23cfd6e3d88a093b6","original_commit_id":"3260ade063ecc1ae3265c0d23cfd6e3d88a093b6","user":{"login":"matthewp","id":361671,"avatar_url":"https://avatars.githubusercontent.com/u/361671?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewp","html_url":"https://github.com/matthewp","followers_url":"https://api.github.com/users/matthewp/followers","following_url":"https://api.github.com/users/matthewp/following{/other_user}","gists_url":"https://api.github.com/users/matthewp/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewp/subscriptions","organizations_url":"https://api.github.com/users/matthewp/orgs","repos_url":"https://api.github.com/users/matthewp/repos","events_url":"https://api.github.com/users/matthewp/events{/privacy}","received_events_url":"https://api.github.com/users/matthewp/received_events","type":"User","site_admin":false},"body":"I think this should be inside the `if(isAPage)` condition, we only need to know about the can-imports that are dynamically importing stuff.","created_at":"2015-11-30T21:41:59Z","updated_at":"2015-11-30T21:41:59Z","html_url":"https://github.com/canjs/can-ssr/pull/97#discussion_r46207891","pull_request_url":"https://api.github.com/repos/canjs/can-ssr/pulls/97","_links":{"self":{"href":"https://api.github.com/repos/canjs/can-ssr/pulls/comments/46207891"},"html":{"href":"https://github.com/canjs/can-ssr/pull/97#discussion_r46207891"},"pull_request":{"href":"https://api.github.com/repos/canjs/can-ssr/pulls/97"}}},"pull_request":{"url":"https://api.github.com/repos/canjs/can-ssr/pulls/97","id":52182831,"html_url":"https://github.com/canjs/can-ssr/pull/97","diff_url":"https://github.com/canjs/can-ssr/pull/97.diff","patch_url":"https://github.com/canjs/can-ssr/pull/97.patch","issue_url":"https://api.github.com/repos/canjs/can-ssr/issues/97","number":97,"state":"open","locked":false,"title":"can-ssr should work when leakScope set to false.","user":{"login":"m-mujica","id":724877,"avatar_url":"https://avatars.githubusercontent.com/u/724877?v=3","gravatar_id":"","url":"https://api.github.com/users/m-mujica","html_url":"https://github.com/m-mujica","followers_url":"https://api.github.com/users/m-mujica/followers","following_url":"https://api.github.com/users/m-mujica/following{/other_user}","gists_url":"https://api.github.com/users/m-mujica/gists{/gist_id}","starred_url":"https://api.github.com/users/m-mujica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-mujica/subscriptions","organizations_url":"https://api.github.com/users/m-mujica/orgs","repos_url":"https://api.github.com/users/m-mujica/repos","events_url":"https://api.github.com/users/m-mujica/events{/privacy}","received_events_url":"https://api.github.com/users/m-mujica/received_events","type":"User","site_admin":false},"body":"Closes #95.","created_at":"2015-11-30T21:38:14Z","updated_at":"2015-11-30T21:41:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b4fc523ccb0189768a1c42ec2689bb1997bede3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/canjs/can-ssr/pulls/97/commits","review_comments_url":"https://api.github.com/repos/canjs/can-ssr/pulls/97/comments","review_comment_url":"https://api.github.com/repos/canjs/can-ssr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/canjs/can-ssr/issues/97/comments","statuses_url":"https://api.github.com/repos/canjs/can-ssr/statuses/3260ade063ecc1ae3265c0d23cfd6e3d88a093b6","head":{"label":"canjs:leakscope","ref":"leakscope","sha":"3260ade063ecc1ae3265c0d23cfd6e3d88a093b6","user":{"login":"canjs","id":11798761,"avatar_url":"https://avatars.githubusercontent.com/u/11798761?v=3","gravatar_id":"","url":"https://api.github.com/users/canjs","html_url":"https://github.com/canjs","followers_url":"https://api.github.com/users/canjs/followers","following_url":"https://api.github.com/users/canjs/following{/other_user}","gists_url":"https://api.github.com/users/canjs/gists{/gist_id}","starred_url":"https://api.github.com/users/canjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canjs/subscriptions","organizations_url":"https://api.github.com/users/canjs/orgs","repos_url":"https://api.github.com/users/canjs/repos","events_url":"https://api.github.com/users/canjs/events{/privacy}","received_events_url":"https://api.github.com/users/canjs/received_events","type":"Organization","site_admin":false},"repo":{"id":35575694,"name":"can-ssr","full_name":"canjs/can-ssr","owner":{"login":"canjs","id":11798761,"avatar_url":"https://avatars.githubusercontent.com/u/11798761?v=3","gravatar_id":"","url":"https://api.github.com/users/canjs","html_url":"https://github.com/canjs","followers_url":"https://api.github.com/users/canjs/followers","following_url":"https://api.github.com/users/canjs/following{/other_user}","gists_url":"https://api.github.com/users/canjs/gists{/gist_id}","starred_url":"https://api.github.com/users/canjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canjs/subscriptions","organizations_url":"https://api.github.com/users/canjs/orgs","repos_url":"https://api.github.com/users/canjs/repos","events_url":"https://api.github.com/users/canjs/events{/privacy}","received_events_url":"https://api.github.com/users/canjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/canjs/can-ssr","description":"Server Side Rendering for CanJS","fork":false,"url":"https://api.github.com/repos/canjs/can-ssr","forks_url":"https://api.github.com/repos/canjs/can-ssr/forks","keys_url":"https://api.github.com/repos/canjs/can-ssr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canjs/can-ssr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canjs/can-ssr/teams","hooks_url":"https://api.github.com/repos/canjs/can-ssr/hooks","issue_events_url":"https://api.github.com/repos/canjs/can-ssr/issues/events{/number}","events_url":"https://api.github.com/repos/canjs/can-ssr/events","assignees_url":"https://api.github.com/repos/canjs/can-ssr/assignees{/user}","branches_url":"https://api.github.com/repos/canjs/can-ssr/branches{/branch}","tags_url":"https://api.github.com/repos/canjs/can-ssr/tags","blobs_url":"https://api.github.com/repos/canjs/can-ssr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canjs/can-ssr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canjs/can-ssr/git/refs{/sha}","trees_url":"https://api.github.com/repos/canjs/can-ssr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canjs/can-ssr/statuses/{sha}","languages_url":"https://api.github.com/repos/canjs/can-ssr/languages","stargazers_url":"https://api.github.com/repos/canjs/can-ssr/stargazers","contributors_url":"https://api.github.com/repos/canjs/can-ssr/contributors","subscribers_url":"https://api.github.com/repos/canjs/can-ssr/subscribers","subscription_url":"https://api.github.com/repos/canjs/can-ssr/subscription","commits_url":"https://api.github.com/repos/canjs/can-ssr/commits{/sha}","git_commits_url":"https://api.github.com/repos/canjs/can-ssr/git/commits{/sha}","comments_url":"https://api.github.com/repos/canjs/can-ssr/comments{/number}","issue_comment_url":"https://api.github.com/repos/canjs/can-ssr/issues/comments{/number}","contents_url":"https://api.github.com/repos/canjs/can-ssr/contents/{+path}","compare_url":"https://api.github.com/repos/canjs/can-ssr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canjs/can-ssr/merges","archive_url":"https://api.github.com/repos/canjs/can-ssr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canjs/can-ssr/downloads","issues_url":"https://api.github.com/repos/canjs/can-ssr/issues{/number}","pulls_url":"https://api.github.com/repos/canjs/can-ssr/pulls{/number}","milestones_url":"https://api.github.com/repos/canjs/can-ssr/milestones{/number}","notifications_url":"https://api.github.com/repos/canjs/can-ssr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canjs/can-ssr/labels{/name}","releases_url":"https://api.github.com/repos/canjs/can-ssr/releases{/id}","created_at":"2015-05-13T21:43:35Z","updated_at":"2015-08-24T17:24:34Z","pushed_at":"2015-11-30T21:38:14Z","git_url":"git://github.com/canjs/can-ssr.git","ssh_url":"git@github.com:canjs/can-ssr.git","clone_url":"https://github.com/canjs/can-ssr.git","svn_url":"https://github.com/canjs/can-ssr","homepage":"http://canjs.github.io/can-ssr","size":452,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":17,"forks":1,"open_issues":17,"watchers":2,"default_branch":"master"}},"base":{"label":"canjs:minor","ref":"minor","sha":"ebcee830c223e3747fc8d86b13746016caf242cf","user":{"login":"canjs","id":11798761,"avatar_url":"https://avatars.githubusercontent.com/u/11798761?v=3","gravatar_id":"","url":"https://api.github.com/users/canjs","html_url":"https://github.com/canjs","followers_url":"https://api.github.com/users/canjs/followers","following_url":"https://api.github.com/users/canjs/following{/other_user}","gists_url":"https://api.github.com/users/canjs/gists{/gist_id}","starred_url":"https://api.github.com/users/canjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canjs/subscriptions","organizations_url":"https://api.github.com/users/canjs/orgs","repos_url":"https://api.github.com/users/canjs/repos","events_url":"https://api.github.com/users/canjs/events{/privacy}","received_events_url":"https://api.github.com/users/canjs/received_events","type":"Organization","site_admin":false},"repo":{"id":35575694,"name":"can-ssr","full_name":"canjs/can-ssr","owner":{"login":"canjs","id":11798761,"avatar_url":"https://avatars.githubusercontent.com/u/11798761?v=3","gravatar_id":"","url":"https://api.github.com/users/canjs","html_url":"https://github.com/canjs","followers_url":"https://api.github.com/users/canjs/followers","following_url":"https://api.github.com/users/canjs/following{/other_user}","gists_url":"https://api.github.com/users/canjs/gists{/gist_id}","starred_url":"https://api.github.com/users/canjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canjs/subscriptions","organizations_url":"https://api.github.com/users/canjs/orgs","repos_url":"https://api.github.com/users/canjs/repos","events_url":"https://api.github.com/users/canjs/events{/privacy}","received_events_url":"https://api.github.com/users/canjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/canjs/can-ssr","description":"Server Side Rendering for CanJS","fork":false,"url":"https://api.github.com/repos/canjs/can-ssr","forks_url":"https://api.github.com/repos/canjs/can-ssr/forks","keys_url":"https://api.github.com/repos/canjs/can-ssr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canjs/can-ssr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canjs/can-ssr/teams","hooks_url":"https://api.github.com/repos/canjs/can-ssr/hooks","issue_events_url":"https://api.github.com/repos/canjs/can-ssr/issues/events{/number}","events_url":"https://api.github.com/repos/canjs/can-ssr/events","assignees_url":"https://api.github.com/repos/canjs/can-ssr/assignees{/user}","branches_url":"https://api.github.com/repos/canjs/can-ssr/branches{/branch}","tags_url":"https://api.github.com/repos/canjs/can-ssr/tags","blobs_url":"https://api.github.com/repos/canjs/can-ssr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canjs/can-ssr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canjs/can-ssr/git/refs{/sha}","trees_url":"https://api.github.com/repos/canjs/can-ssr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canjs/can-ssr/statuses/{sha}","languages_url":"https://api.github.com/repos/canjs/can-ssr/languages","stargazers_url":"https://api.github.com/repos/canjs/can-ssr/stargazers","contributors_url":"https://api.github.com/repos/canjs/can-ssr/contributors","subscribers_url":"https://api.github.com/repos/canjs/can-ssr/subscribers","subscription_url":"https://api.github.com/repos/canjs/can-ssr/subscription","commits_url":"https://api.github.com/repos/canjs/can-ssr/commits{/sha}","git_commits_url":"https://api.github.com/repos/canjs/can-ssr/git/commits{/sha}","comments_url":"https://api.github.com/repos/canjs/can-ssr/comments{/number}","issue_comment_url":"https://api.github.com/repos/canjs/can-ssr/issues/comments{/number}","contents_url":"https://api.github.com/repos/canjs/can-ssr/contents/{+path}","compare_url":"https://api.github.com/repos/canjs/can-ssr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canjs/can-ssr/merges","archive_url":"https://api.github.com/repos/canjs/can-ssr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canjs/can-ssr/downloads","issues_url":"https://api.github.com/repos/canjs/can-ssr/issues{/number}","pulls_url":"https://api.github.com/repos/canjs/can-ssr/pulls{/number}","milestones_url":"https://api.github.com/repos/canjs/can-ssr/milestones{/number}","notifications_url":"https://api.github.com/repos/canjs/can-ssr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canjs/can-ssr/labels{/name}","releases_url":"https://api.github.com/repos/canjs/can-ssr/releases{/id}","created_at":"2015-05-13T21:43:35Z","updated_at":"2015-08-24T17:24:34Z","pushed_at":"2015-11-30T21:38:14Z","git_url":"git://github.com/canjs/can-ssr.git","ssh_url":"git@github.com:canjs/can-ssr.git","clone_url":"https://github.com/canjs/can-ssr.git","svn_url":"https://github.com/canjs/can-ssr","homepage":"http://canjs.github.io/can-ssr","size":452,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":17,"forks":1,"open_issues":17,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/canjs/can-ssr/pulls/97"},"html":{"href":"https://github.com/canjs/can-ssr/pull/97"},"issue":{"href":"https://api.github.com/repos/canjs/can-ssr/issues/97"},"comments":{"href":"https://api.github.com/repos/canjs/can-ssr/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/canjs/can-ssr/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/canjs/can-ssr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/canjs/can-ssr/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/canjs/can-ssr/statuses/3260ade063ecc1ae3265c0d23cfd6e3d88a093b6"}}}}