{"action":"created","comment":{"url":"https://api.github.com/repos/openchange/openchange/pulls/comments/28734173","id":28734173,"diff_hunk":"@@ -286,8 +287,6 @@ static void mapiproxy_op_unbind(struct dcesrv_connection_context *context, const\n \t\ttalloc_free(private);\n \t}\n \n-\ttalloc_free(context);\n-","path":"mapiproxy/dcesrv_mapiproxy.c","position":13,"original_position":13,"commit_id":"d958156e9092bb604d4245b0a6e1c173cb890e78","original_commit_id":"d958156e9092bb604d4245b0a6e1c173cb890e78","user":{"login":"jkerihuel","id":3603061,"avatar_url":"https://avatars.githubusercontent.com/u/3603061?v=3","gravatar_id":"","url":"https://api.github.com/users/jkerihuel","html_url":"https://github.com/jkerihuel","followers_url":"https://api.github.com/users/jkerihuel/followers","following_url":"https://api.github.com/users/jkerihuel/following{/other_user}","gists_url":"https://api.github.com/users/jkerihuel/gists{/gist_id}","starred_url":"https://api.github.com/users/jkerihuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkerihuel/subscriptions","organizations_url":"https://api.github.com/users/jkerihuel/orgs","repos_url":"https://api.github.com/users/jkerihuel/repos","events_url":"https://api.github.com/users/jkerihuel/events{/privacy}","received_events_url":"https://api.github.com/users/jkerihuel/received_events","type":"User","site_admin":false},"body":"That is fairly understandable at it also require some context from samba4 rpc server. In a nutshell, samba rpc_server is responsible for freeing the dcesrv_connection_context, not the endpoint. \r\n\r\nWith the patch for samba4 that addresses the termination of connection in asynchronous emsmdb, it exposes this problem more radically and causes the process to crash with an attempt to double free talloc_free data.","created_at":"2015-04-20T22:03:54Z","updated_at":"2015-04-20T22:03:54Z","html_url":"https://github.com/openchange/openchange/pull/282#discussion_r28734173","pull_request_url":"https://api.github.com/repos/openchange/openchange/pulls/282","_links":{"self":{"href":"https://api.github.com/repos/openchange/openchange/pulls/comments/28734173"},"html":{"href":"https://github.com/openchange/openchange/pull/282#discussion_r28734173"},"pull_request":{"href":"https://api.github.com/repos/openchange/openchange/pulls/282"}}},"pull_request":{"url":"https://api.github.com/repos/openchange/openchange/pulls/282","id":33437546,"html_url":"https://github.com/openchange/openchange/pull/282","diff_url":"https://github.com/openchange/openchange/pull/282.diff","patch_url":"https://github.com/openchange/openchange/pull/282.patch","issue_url":"https://api.github.com/repos/openchange/openchange/issues/282","number":282,"state":"open","locked":false,"title":"[oxcnotif] Add asynchronous notification framework","user":{"login":"jkerihuel","id":3603061,"avatar_url":"https://avatars.githubusercontent.com/u/3603061?v=3","gravatar_id":"","url":"https://api.github.com/users/jkerihuel","html_url":"https://github.com/jkerihuel","followers_url":"https://api.github.com/users/jkerihuel/followers","following_url":"https://api.github.com/users/jkerihuel/following{/other_user}","gists_url":"https://api.github.com/users/jkerihuel/gists{/gist_id}","starred_url":"https://api.github.com/users/jkerihuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkerihuel/subscriptions","organizations_url":"https://api.github.com/users/jkerihuel/orgs","repos_url":"https://api.github.com/users/jkerihuel/repos","events_url":"https://api.github.com/users/jkerihuel/events{/privacy}","received_events_url":"https://api.github.com/users/jkerihuel/received_events","type":"User","site_admin":false},"body":"This pull request provides the full asynchronous notification framework and removes references to all the existing and deprecated notification code. All new additions to mapistore API (session, resolver, subscription, deliver) are unit tested. The PR also includes an updated dovecot plugin for 2.2 series.","created_at":"2015-04-16T10:30:01Z","updated_at":"2015-04-20T22:03:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6f5e16f537491d97e482fca8cf85666993fe072","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openchange/openchange/pulls/282/commits","review_comments_url":"https://api.github.com/repos/openchange/openchange/pulls/282/comments","review_comment_url":"https://api.github.com/repos/openchange/openchange/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openchange/openchange/issues/282/comments","statuses_url":"https://api.github.com/repos/openchange/openchange/statuses/d958156e9092bb604d4245b0a6e1c173cb890e78","head":{"label":"openchange:jkerihuel/asynchronous-notifications","ref":"jkerihuel/asynchronous-notifications","sha":"d958156e9092bb604d4245b0a6e1c173cb890e78","user":{"login":"openchange","id":5413705,"avatar_url":"https://avatars.githubusercontent.com/u/5413705?v=3","gravatar_id":"","url":"https://api.github.com/users/openchange","html_url":"https://github.com/openchange","followers_url":"https://api.github.com/users/openchange/followers","following_url":"https://api.github.com/users/openchange/following{/other_user}","gists_url":"https://api.github.com/users/openchange/gists{/gist_id}","starred_url":"https://api.github.com/users/openchange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openchange/subscriptions","organizations_url":"https://api.github.com/users/openchange/orgs","repos_url":"https://api.github.com/users/openchange/repos","events_url":"https://api.github.com/users/openchange/events{/privacy}","received_events_url":"https://api.github.com/users/openchange/received_events","type":"Organization","site_admin":false},"repo":{"id":12688822,"name":"openchange","full_name":"openchange/openchange","owner":{"login":"openchange","id":5413705,"avatar_url":"https://avatars.githubusercontent.com/u/5413705?v=3","gravatar_id":"","url":"https://api.github.com/users/openchange","html_url":"https://github.com/openchange","followers_url":"https://api.github.com/users/openchange/followers","following_url":"https://api.github.com/users/openchange/following{/other_user}","gists_url":"https://api.github.com/users/openchange/gists{/gist_id}","starred_url":"https://api.github.com/users/openchange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openchange/subscriptions","organizations_url":"https://api.github.com/users/openchange/orgs","repos_url":"https://api.github.com/users/openchange/repos","events_url":"https://api.github.com/users/openchange/events{/privacy}","received_events_url":"https://api.github.com/users/openchange/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openchange/openchange","description":"OpenChange Project","fork":false,"url":"https://api.github.com/repos/openchange/openchange","forks_url":"https://api.github.com/repos/openchange/openchange/forks","keys_url":"https://api.github.com/repos/openchange/openchange/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openchange/openchange/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openchange/openchange/teams","hooks_url":"https://api.github.com/repos/openchange/openchange/hooks","issue_events_url":"https://api.github.com/repos/openchange/openchange/issues/events{/number}","events_url":"https://api.github.com/repos/openchange/openchange/events","assignees_url":"https://api.github.com/repos/openchange/openchange/assignees{/user}","branches_url":"https://api.github.com/repos/openchange/openchange/branches{/branch}","tags_url":"https://api.github.com/repos/openchange/openchange/tags","blobs_url":"https://api.github.com/repos/openchange/openchange/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openchange/openchange/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openchange/openchange/git/refs{/sha}","trees_url":"https://api.github.com/repos/openchange/openchange/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openchange/openchange/statuses/{sha}","languages_url":"https://api.github.com/repos/openchange/openchange/languages","stargazers_url":"https://api.github.com/repos/openchange/openchange/stargazers","contributors_url":"https://api.github.com/repos/openchange/openchange/contributors","subscribers_url":"https://api.github.com/repos/openchange/openchange/subscribers","subscription_url":"https://api.github.com/repos/openchange/openchange/subscription","commits_url":"https://api.github.com/repos/openchange/openchange/commits{/sha}","git_commits_url":"https://api.github.com/repos/openchange/openchange/git/commits{/sha}","comments_url":"https://api.github.com/repos/openchange/openchange/comments{/number}","issue_comment_url":"https://api.github.com/repos/openchange/openchange/issues/comments{/number}","contents_url":"https://api.github.com/repos/openchange/openchange/contents/{+path}","compare_url":"https://api.github.com/repos/openchange/openchange/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openchange/openchange/merges","archive_url":"https://api.github.com/repos/openchange/openchange/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openchange/openchange/downloads","issues_url":"https://api.github.com/repos/openchange/openchange/issues{/number}","pulls_url":"https://api.github.com/repos/openchange/openchange/pulls{/number}","milestones_url":"https://api.github.com/repos/openchange/openchange/milestones{/number}","notifications_url":"https://api.github.com/repos/openchange/openchange/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openchange/openchange/labels{/name}","releases_url":"https://api.github.com/repos/openchange/openchange/releases{/id}","created_at":"2013-09-08T22:39:00Z","updated_at":"2015-04-20T10:37:21Z","pushed_at":"2015-04-20T21:03:26Z","git_url":"git://github.com/openchange/openchange.git","ssh_url":"git@github.com:openchange/openchange.git","clone_url":"https://github.com/openchange/openchange.git","svn_url":"https://github.com/openchange/openchange","homepage":null,"size":26583,"stargazers_count":52,"watchers_count":52,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":25,"forks":28,"open_issues":25,"watchers":52,"default_branch":"master"}},"base":{"label":"openchange:master","ref":"master","sha":"2bf1c87c25f8ff0ad78bdf571d7ee406d59e6391","user":{"login":"openchange","id":5413705,"avatar_url":"https://avatars.githubusercontent.com/u/5413705?v=3","gravatar_id":"","url":"https://api.github.com/users/openchange","html_url":"https://github.com/openchange","followers_url":"https://api.github.com/users/openchange/followers","following_url":"https://api.github.com/users/openchange/following{/other_user}","gists_url":"https://api.github.com/users/openchange/gists{/gist_id}","starred_url":"https://api.github.com/users/openchange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openchange/subscriptions","organizations_url":"https://api.github.com/users/openchange/orgs","repos_url":"https://api.github.com/users/openchange/repos","events_url":"https://api.github.com/users/openchange/events{/privacy}","received_events_url":"https://api.github.com/users/openchange/received_events","type":"Organization","site_admin":false},"repo":{"id":12688822,"name":"openchange","full_name":"openchange/openchange","owner":{"login":"openchange","id":5413705,"avatar_url":"https://avatars.githubusercontent.com/u/5413705?v=3","gravatar_id":"","url":"https://api.github.com/users/openchange","html_url":"https://github.com/openchange","followers_url":"https://api.github.com/users/openchange/followers","following_url":"https://api.github.com/users/openchange/following{/other_user}","gists_url":"https://api.github.com/users/openchange/gists{/gist_id}","starred_url":"https://api.github.com/users/openchange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openchange/subscriptions","organizations_url":"https://api.github.com/users/openchange/orgs","repos_url":"https://api.github.com/users/openchange/repos","events_url":"https://api.github.com/users/openchange/events{/privacy}","received_events_url":"https://api.github.com/users/openchange/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openchange/openchange","description":"OpenChange Project","fork":false,"url":"https://api.github.com/repos/openchange/openchange","forks_url":"https://api.github.com/repos/openchange/openchange/forks","keys_url":"https://api.github.com/repos/openchange/openchange/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openchange/openchange/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openchange/openchange/teams","hooks_url":"https://api.github.com/repos/openchange/openchange/hooks","issue_events_url":"https://api.github.com/repos/openchange/openchange/issues/events{/number}","events_url":"https://api.github.com/repos/openchange/openchange/events","assignees_url":"https://api.github.com/repos/openchange/openchange/assignees{/user}","branches_url":"https://api.github.com/repos/openchange/openchange/branches{/branch}","tags_url":"https://api.github.com/repos/openchange/openchange/tags","blobs_url":"https://api.github.com/repos/openchange/openchange/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openchange/openchange/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openchange/openchange/git/refs{/sha}","trees_url":"https://api.github.com/repos/openchange/openchange/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openchange/openchange/statuses/{sha}","languages_url":"https://api.github.com/repos/openchange/openchange/languages","stargazers_url":"https://api.github.com/repos/openchange/openchange/stargazers","contributors_url":"https://api.github.com/repos/openchange/openchange/contributors","subscribers_url":"https://api.github.com/repos/openchange/openchange/subscribers","subscription_url":"https://api.github.com/repos/openchange/openchange/subscription","commits_url":"https://api.github.com/repos/openchange/openchange/commits{/sha}","git_commits_url":"https://api.github.com/repos/openchange/openchange/git/commits{/sha}","comments_url":"https://api.github.com/repos/openchange/openchange/comments{/number}","issue_comment_url":"https://api.github.com/repos/openchange/openchange/issues/comments{/number}","contents_url":"https://api.github.com/repos/openchange/openchange/contents/{+path}","compare_url":"https://api.github.com/repos/openchange/openchange/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openchange/openchange/merges","archive_url":"https://api.github.com/repos/openchange/openchange/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openchange/openchange/downloads","issues_url":"https://api.github.com/repos/openchange/openchange/issues{/number}","pulls_url":"https://api.github.com/repos/openchange/openchange/pulls{/number}","milestones_url":"https://api.github.com/repos/openchange/openchange/milestones{/number}","notifications_url":"https://api.github.com/repos/openchange/openchange/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openchange/openchange/labels{/name}","releases_url":"https://api.github.com/repos/openchange/openchange/releases{/id}","created_at":"2013-09-08T22:39:00Z","updated_at":"2015-04-20T10:37:21Z","pushed_at":"2015-04-20T21:03:26Z","git_url":"git://github.com/openchange/openchange.git","ssh_url":"git@github.com:openchange/openchange.git","clone_url":"https://github.com/openchange/openchange.git","svn_url":"https://github.com/openchange/openchange","homepage":null,"size":26583,"stargazers_count":52,"watchers_count":52,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":25,"forks":28,"open_issues":25,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openchange/openchange/pulls/282"},"html":{"href":"https://github.com/openchange/openchange/pull/282"},"issue":{"href":"https://api.github.com/repos/openchange/openchange/issues/282"},"comments":{"href":"https://api.github.com/repos/openchange/openchange/issues/282/comments"},"review_comments":{"href":"https://api.github.com/repos/openchange/openchange/pulls/282/comments"},"review_comment":{"href":"https://api.github.com/repos/openchange/openchange/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openchange/openchange/pulls/282/commits"},"statuses":{"href":"https://api.github.com/repos/openchange/openchange/statuses/d958156e9092bb604d4245b0a6e1c173cb890e78"}}}}