{"action":"created","comment":{"url":"https://api.github.com/repos/01org/parameter-framework/pulls/comments/40185627","id":40185627,"diff_hunk":"@@ -28,113 +28,59 @@\n  * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n  */\n #include \"MappingContext.h\"\n-#include <assert.h>\n-#include <string.h>\n+#include <cassert>\n+#include <algorithm>\n #include <stdlib.h>\n \n-using std::string;\n-\n-CMappingContext::CMappingContext(size_t uiNbItemTypes) : _pstItemArray(new CMappingContext::SItem[uiNbItemTypes]), _uiNbItemTypes(uiNbItemTypes)\n-{\n-    // Clear items\n-    memset(_pstItemArray, 0, sizeof(*_pstItemArray) * uiNbItemTypes);\n-}\n-\n-CMappingContext::~CMappingContext()\n-{\n-    delete [] _pstItemArray;\n-}\n-\n-// Copy constructor\n-CMappingContext::CMappingContext(const CMappingContext& from) : _pstItemArray(new CMappingContext::SItem[from._uiNbItemTypes]), _uiNbItemTypes(from._uiNbItemTypes)\n-{\n-    // FIXME: delegate constructor\n-    // Copy content items\n-    memcpy(_pstItemArray, from._pstItemArray, sizeof(*_pstItemArray) * _uiNbItemTypes);\n-}\n-\n-// Affectation\n-CMappingContext& CMappingContext::operator=(const CMappingContext& right)\n-{\n-    // FIXME: use a vector of CMappingContext::SItem\n-    if (&right != this) {\n-\n-        // Size\n-        _uiNbItemTypes = right._uiNbItemTypes;\n-\n-        // Content\n-        // Delete previous array\n-        delete [] _pstItemArray;\n-\n-        // Reallocate it\n-        _pstItemArray = new CMappingContext::SItem[_uiNbItemTypes];\n-\n-        // Copy content items\n-        memcpy(_pstItemArray, right._pstItemArray, sizeof(*_pstItemArray) * _uiNbItemTypes);\n-    }\n-    return *this;\n-}\n+using namespace std;","path":"parameter/MappingContext.cpp","position":52,"original_position":52,"commit_id":"2369ef8a48b1a00ee713c4aa3690965b1576b8df","original_commit_id":"2369ef8a48b1a00ee713c4aa3690965b1576b8df","user":{"login":"dawagner","id":6430928,"avatar_url":"https://avatars.githubusercontent.com/u/6430928?v=3","gravatar_id":"","url":"https://api.github.com/users/dawagner","html_url":"https://github.com/dawagner","followers_url":"https://api.github.com/users/dawagner/followers","following_url":"https://api.github.com/users/dawagner/following{/other_user}","gists_url":"https://api.github.com/users/dawagner/gists{/gist_id}","starred_url":"https://api.github.com/users/dawagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dawagner/subscriptions","organizations_url":"https://api.github.com/users/dawagner/orgs","repos_url":"https://api.github.com/users/dawagner/repos","events_url":"https://api.github.com/users/dawagner/events{/privacy}","received_events_url":"https://api.github.com/users/dawagner/received_events","type":"User","site_admin":false},"body":"We try and avoid to do this. You only seem to need `string`, `find_if` (only once - no need for a `using`), `end` and `begin`.","created_at":"2015-09-23T09:40:30Z","updated_at":"2015-09-23T09:40:30Z","html_url":"https://github.com/01org/parameter-framework/pull/238#discussion_r40185627","pull_request_url":"https://api.github.com/repos/01org/parameter-framework/pulls/238","_links":{"self":{"href":"https://api.github.com/repos/01org/parameter-framework/pulls/comments/40185627"},"html":{"href":"https://github.com/01org/parameter-framework/pull/238#discussion_r40185627"},"pull_request":{"href":"https://api.github.com/repos/01org/parameter-framework/pulls/238"}}},"pull_request":{"url":"https://api.github.com/repos/01org/parameter-framework/pulls/238","id":45303509,"html_url":"https://github.com/01org/parameter-framework/pull/238","diff_url":"https://github.com/01org/parameter-framework/pull/238.diff","patch_url":"https://github.com/01org/parameter-framework/pull/238.patch","issue_url":"https://api.github.com/repos/01org/parameter-framework/issues/238","number":238,"state":"open","locked":false,"title":"Refactor message, BinaryStream and Mapping context","user":{"login":"cc6565","id":9692938,"avatar_url":"https://avatars.githubusercontent.com/u/9692938?v=3","gravatar_id":"","url":"https://api.github.com/users/cc6565","html_url":"https://github.com/cc6565","followers_url":"https://api.github.com/users/cc6565/followers","following_url":"https://api.github.com/users/cc6565/following{/other_user}","gists_url":"https://api.github.com/users/cc6565/gists{/gist_id}","starred_url":"https://api.github.com/users/cc6565/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cc6565/subscriptions","organizations_url":"https://api.github.com/users/cc6565/orgs","repos_url":"https://api.github.com/users/cc6565/repos","events_url":"https://api.github.com/users/cc6565/events{/privacy}","received_events_url":"https://api.github.com/users/cc6565/received_events","type":"User","site_admin":false},"body":"Refactor message, binarystream and mappingcontext class by\r\n-using std::vector instead of a manual\r\n-using std::copy instead of memcopy\r\n-asserting when invalid access.\n<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/01org/parameter-framework/pull/238%23issuecomment-141122039%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/238%23issuecomment-141979786%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/238%23issuecomment-141989133%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/238%23discussion_r39763599%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/238%23discussion_r39763603%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/238%23discussion_r39764008%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/238%23discussion_r39952263%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/238%23discussion_r39952680%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/238%23discussion_r39952754%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/238%23discussion_r39953109%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/238%23discussion_r39953325%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/238%23discussion_r39953401%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/238%23discussion_r39953942%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/238%23discussion_r39954056%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/238%23discussion_r39972917%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/238%23discussion_r39972918%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/238%23discussion_r39972921%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/238%23discussion_r39972922%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/238%23discussion_r39972924%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/238%23discussion_r39972925%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/238%23discussion_r39972927%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/238%23issuecomment-142003224%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/238%23issuecomment-142007685%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/238%23issuecomment-142031645%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/238%23issuecomment-142202208%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/238%23discussion_r40185569%22%5D%2C%20%22comments%22%3A%20%7B%22General%20Comment%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/pull/238%23issuecomment-141122039%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%40OznOg%20%40krocard%20%40dawagner%20%40miguelgaio%20please%20review%22%2C%20%22created_at%22%3A%20%222015-09-17T15%3A27%3A08Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/9692938%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/cc6565%22%7D%7D%2C%20%7B%22body%22%3A%20%22Please%20add%20signed-off%20and%20fix%20git%20config%20for%20author%20currently%20set%20to%5Cr%5CnAuthor%3A%20unknown%20%3Cfgaffie%40fgaffie-MOBL1.ger.corp.intel.com%3E%5Cr%5Cn%5Cr%5CnAlso%20there%20are%20many%20trailing%20space%20on%20sources.%20%22%2C%20%22created_at%22%3A%20%222015-09-21T13%3A35%3A57Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/12096004%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/miguelgaio%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-09-21T13%3A59%3A09Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/9692938%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/cc6565%22%7D%7D%2C%20%7B%22body%22%3A%20%22I%27m%20removing%20binary%20settings%20in%20%23244%20%22%2C%20%22created_at%22%3A%20%222015-09-21T14%3A43%3A22Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6430928%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dawagner%22%7D%7D%2C%20%7B%22body%22%3A%20%22Undo%20changes%20on%20BinaryStream%20to%20avoid%20conflict%20with%20%23244%22%2C%20%22created_at%22%3A%20%222015-09-21T15%3A00%3A53Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/9692938%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/cc6565%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%22%2C%20%22created_at%22%3A%20%222015-09-21T16%3A16%3A17Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/9692938%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/cc6565%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%20%22%2C%20%22created_at%22%3A%20%222015-09-22T07%3A32%3A08Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/12096004%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/miguelgaio%22%7D%7D%5D%2C%20%22title%22%3A%20%22General%20Comment%22%7D%2C%20%22Pull%20e543765a934ef3d678d11292e5a4d69b1c224d99%20parameter/BinaryStream.cpp%2088%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/pull/238%23discussion_r39763599%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22trust%20std%3A%3Acopy%28%29%22%2C%20%22created_at%22%3A%20%222015-09-17T15%3A58%3A31Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/12096004%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/miguelgaio%22%7D%7D%2C%20%7B%22body%22%3A%20%22Idem%20here%2C%20%60std%3A%3Acopy%60%20will%20not%20throw%20because%20vector%20iterator%20do%20not%20throw.%22%2C%20%22created_at%22%3A%20%222015-09-21T09%3A20%3A58Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6862950%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/krocard%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20parameter/BinaryStream.cpp%3AL149-189%22%7D%2C%20%22Pull%20e543765a934ef3d678d11292e5a4d69b1c224d99%20remote-processor/Message.cpp%2010%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/pull/238%23discussion_r39953942%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Pretty%20sure%20this%20change%20is%20not%20needed.%20All%20std%20algorithm%20will%20be%20found%20be%20%5Bald%5D%28http%3A//en.cppreference.com/w/cpp/language/adl%29.%5Cr%5Cn%5Cr%5CnIts%20a%20matter%20of%20style%20though.%20Feel%20free%20to%20ignore.%22%2C%20%22created_at%22%3A%20%222015-09-21T09%3A37%3A32Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6862950%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/krocard%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-09-21T13%3A59%3A10Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/9692938%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/cc6565%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20remote-processor/Message.cpp%3AL28-86%22%7D%2C%20%22Pull%20e543765a934ef3d678d11292e5a4d69b1c224d99%20remote-processor/Message.h%2022%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/pull/238%23discussion_r39954056%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%60%60%60%20cpp%5Cr%5Cnvirtual%20%7ECMessage%28%29%20%3D%20default%3B%5Cr%5Cn%60%60%60%22%2C%20%22created_at%22%3A%20%222015-09-21T09%3A39%3A20Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6862950%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/krocard%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-09-21T13%3A59%3A10Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/9692938%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/cc6565%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20remote-processor/Message.h%3AL49-56%22%7D%2C%20%22Pull%20e543765a934ef3d678d11292e5a4d69b1c224d99%20parameter/BinaryStream.cpp%2073%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/pull/238%23discussion_r39763603%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22std%3A%3Acopy%20will%20throw%20an%20exception%20in%20case%20of%20invalid%20access.%5Cr%5CnassertValidAcess%20looks%20duplicate%20here%5Cr%5Cn%5Cr%5CnThrows%20if%20either%20an%20element%20assignment%20or%20an%20operation%20on%20iterators%20throws.%5Cr%5CnNote%20that%20invalid%20arguments%20cause%20undefined%20behavior.%22%2C%20%22created_at%22%3A%20%222015-09-17T15%3A58%3A32Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/12096004%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/miguelgaio%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3E%20std%3A%3Acopy%20will%20throw%20an%20exception%20in%20case%20of%20invalid%20access.%5Cr%5Cn%5Cr%5CnAre%20you%20sure%20%3F%20I%20have%20never%20eared%20of%20such%20thing.%20I%20do%20not%20know%20any%20iterator%20that%20is%20required%20to%20throw%20on%20invalid%20access.%22%2C%20%22created_at%22%3A%20%222015-09-21T09%3A15%3A10Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6862950%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/krocard%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20parameter/BinaryStream.cpp%3AL149-189%22%7D%2C%20%22Pull%202369ef8a48b1a00ee713c4aa3690965b1576b8df%20parameter/MappingContext.cpp%20103%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/pull/238%23discussion_r40185569%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Use%20convertTo%20instead%20%3F%22%2C%20%22created_at%22%3A%20%222015-09-23T09%3A39%3A44Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6430928%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dawagner%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20parameter/MappingContext.cpp%3AL28-87%22%7D%2C%20%22Pull%20e543765a934ef3d678d11292e5a4d69b1c224d99%20parameter/MappingContext.cpp%2036%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/pull/238%23discussion_r39953401%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%60%60%60%20cpp%5Cr%5CnCMappingContext%3A%3Aoperator%3D%28const%20CMappingContext%26%20right%29%20%3D%20default%3B%5Cr%5Cn%60%60%60%5Cr%5CnMove%20to%20header%20%3F%22%2C%20%22created_at%22%3A%20%222015-09-21T09%3A30%3A12Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6862950%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/krocard%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-09-21T13%3A59%3A10Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/9692938%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/cc6565%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20parameter/MappingContext.cpp%3AL28-56%22%7D%2C%20%22Pull%20e543765a934ef3d678d11292e5a4d69b1c224d99%20parameter/MappingContext.cpp%2022%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/pull/238%23discussion_r39953109%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%60%60%60%20cpp%5Cr%5CnCMappingContext%3A%3ACMappingContext%28size_t%20uiNbItemTypes%29%20%3A%20mItems%28uiNbItemTypes%29%20%7B%7D%5Cr%5Cn%60%60%60%22%2C%20%22created_at%22%3A%20%222015-09-21T09%3A26%3A40Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6862950%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/krocard%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-09-21T13%3A59%3A11Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/9692938%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/cc6565%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20parameter/MappingContext.cpp%3AL28-56%22%7D%2C%20%22Pull%20e543765a934ef3d678d11292e5a4d69b1c224d99%20parameter/MappingContext.cpp%2033%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/pull/238%23discussion_r39953325%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%60%60%60%20cpp%5Cr%5CnCMappingContext%3A%3ACMappingContext%28const%20CMappingContext%26%20from%29%20%3D%20default%3B%5Cr%5Cn%60%60%60%5Cr%5CnMove%20to%20header%20%3F%22%2C%20%22created_at%22%3A%20%222015-09-21T09%3A29%3A13Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6862950%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/krocard%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-09-21T13%3A59%3A11Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/9692938%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/cc6565%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20parameter/MappingContext.cpp%3AL28-56%22%7D%2C%20%22Pull%20e543765a934ef3d678d11292e5a4d69b1c224d99%20parameter/BinaryStream.cpp%20109%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/pull/238%23discussion_r39952754%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%60return%3Cspace%3E%3Cspace%3Eaccumulate%60%20double%20space%22%2C%20%22created_at%22%3A%20%222015-09-21T09%3A22%3A04Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6862950%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/krocard%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-09-21T13%3A59%3A11Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/9692938%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/cc6565%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20parameter/BinaryStream.cpp%3AL149-189%22%7D%2C%20%22Pull%20e543765a934ef3d678d11292e5a4d69b1c224d99%20parameter/MappingContext.cpp%20120%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/pull/238%23discussion_r39764008%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Convertible%20to%20std%3A%3Afind_if%22%2C%20%22created_at%22%3A%20%222015-09-17T16%3A01%3A42Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/12096004%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/miguelgaio%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-complete%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-09-21T13%3A59%3A11Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/9692938%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/cc6565%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20parameter/MappingContext.cpp%3AL57-109%22%7D%7D%7D'></a>\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\n- [ ] <a href='#crh-comment-Pull e543765a934ef3d678d11292e5a4d69b1c224d99 parameter/BinaryStream.cpp 88'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/pull/238#discussion_r39763599'>File: parameter/BinaryStream.cpp:L149-189</a></b>\n- <a href='https://github.com/miguelgaio'><img border=0 src='https://avatars.githubusercontent.com/u/12096004?v=3' height=16 width=16'></a> trust std::copy()\n- <a href='https://github.com/krocard'><img border=0 src='https://avatars.githubusercontent.com/u/6862950?v=3' height=16 width=16'></a> Idem here, `std::copy` will not throw because vector iterator do not throw.\n- [ ] <a href='#crh-comment-Pull e543765a934ef3d678d11292e5a4d69b1c224d99 parameter/BinaryStream.cpp 73'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/pull/238#discussion_r39763603'>File: parameter/BinaryStream.cpp:L149-189</a></b>\n- <a href='https://github.com/miguelgaio'><img border=0 src='https://avatars.githubusercontent.com/u/12096004?v=3' height=16 width=16'></a> std::copy will throw an exception in case of invalid access.\nassertValidAcess looks duplicate here\nThrows if either an element assignment or an operation on iterators throws.\nNote that invalid arguments cause undefined behavior.\n- <a href='https://github.com/krocard'><img border=0 src='https://avatars.githubusercontent.com/u/6862950?v=3' height=16 width=16'></a> > std::copy will throw an exception in case of invalid access.\nAre you sure ? I have never eared of such thing. I do not know any iterator that is required to throw on invalid access.\n- [ ] <a href='#crh-comment-Pull 2369ef8a48b1a00ee713c4aa3690965b1576b8df parameter/MappingContext.cpp 103'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/pull/238#discussion_r40185569'>File: parameter/MappingContext.cpp:L28-87</a></b>\n- <a href='https://github.com/dawagner'><img border=0 src='https://avatars.githubusercontent.com/u/6430928?v=3' height=16 width=16'></a> Use convertTo instead ?\n- [x] <a href='#crh-comment-General Comment'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/pull/238#issuecomment-141122039'>General Comment</a></b>\n- <a href='https://github.com/cc6565'><img border=0 src='https://avatars.githubusercontent.com/u/9692938?v=3' height=16 width=16'></a> @OznOg @krocard @dawagner @miguelgaio please review\n- <a href='https://github.com/miguelgaio'><img border=0 src='https://avatars.githubusercontent.com/u/12096004?v=3' height=16 width=16'></a> Please add signed-off and fix git config for author currently set to\nAuthor: unknown <fgaffie@fgaffie-MOBL1.ger.corp.intel.com>\nAlso there are many trailing space on sources.\n- <a href='https://github.com/cc6565'><img border=0 src='https://avatars.githubusercontent.com/u/9692938?v=3' height=16 width=16'></a> :+1:<a href='#crh-update-none'></a>\n- <a href='https://github.com/dawagner'><img border=0 src='https://avatars.githubusercontent.com/u/6430928?v=3' height=16 width=16'></a> I'm removing binary settings in #244\n- <a href='https://github.com/cc6565'><img border=0 src='https://avatars.githubusercontent.com/u/9692938?v=3' height=16 width=16'></a> Undo changes on BinaryStream to avoid conflict with #244\n- [x] <a href='#crh-comment-Pull e543765a934ef3d678d11292e5a4d69b1c224d99 parameter/MappingContext.cpp 120'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/pull/238#discussion_r39764008'>File: parameter/MappingContext.cpp:L57-109</a></b>\n- <a href='https://github.com/miguelgaio'><img border=0 src='https://avatars.githubusercontent.com/u/12096004?v=3' height=16 width=16'></a> Convertible to std::find_if\n- [x] <a href='#crh-comment-Pull e543765a934ef3d678d11292e5a4d69b1c224d99 parameter/BinaryStream.cpp 109'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/pull/238#discussion_r39952754'>File: parameter/BinaryStream.cpp:L149-189</a></b>\n- <a href='https://github.com/krocard'><img border=0 src='https://avatars.githubusercontent.com/u/6862950?v=3' height=16 width=16'></a> `return<space><space>accumulate` double space\n- [x] <a href='#crh-comment-Pull e543765a934ef3d678d11292e5a4d69b1c224d99 parameter/MappingContext.cpp 22'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/pull/238#discussion_r39953109'>File: parameter/MappingContext.cpp:L28-56</a></b>\n- <a href='https://github.com/krocard'><img border=0 src='https://avatars.githubusercontent.com/u/6862950?v=3' height=16 width=16'></a> \n``` cpp\nCMappingContext::CMappingContext(size_t uiNbItemTypes) : mItems(uiNbItemTypes) {}\n```\n- [x] <a href='#crh-comment-Pull e543765a934ef3d678d11292e5a4d69b1c224d99 parameter/MappingContext.cpp 33'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/pull/238#discussion_r39953325'>File: parameter/MappingContext.cpp:L28-56</a></b>\n- <a href='https://github.com/krocard'><img border=0 src='https://avatars.githubusercontent.com/u/6862950?v=3' height=16 width=16'></a> \n``` cpp\nCMappingContext::CMappingContext(const CMappingContext& from) = default;\n```\nMove to header ?\n- [x] <a href='#crh-comment-Pull e543765a934ef3d678d11292e5a4d69b1c224d99 parameter/MappingContext.cpp 36'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/pull/238#discussion_r39953401'>File: parameter/MappingContext.cpp:L28-56</a></b>\n- <a href='https://github.com/krocard'><img border=0 src='https://avatars.githubusercontent.com/u/6862950?v=3' height=16 width=16'></a> \n``` cpp\nCMappingContext::operator=(const CMappingContext& right) = default;\n```\nMove to header ?\n- [x] <a href='#crh-comment-Pull e543765a934ef3d678d11292e5a4d69b1c224d99 remote-processor/Message.cpp 10'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/pull/238#discussion_r39953942'>File: remote-processor/Message.cpp:L28-86</a></b>\n- <a href='https://github.com/krocard'><img border=0 src='https://avatars.githubusercontent.com/u/6862950?v=3' height=16 width=16'></a> Pretty sure this change is not needed. All std algorithm will be found be [ald](http://en.cppreference.com/w/cpp/language/adl).\nIts a matter of style though. Feel free to ignore.\n- [x] <a href='#crh-comment-Pull e543765a934ef3d678d11292e5a4d69b1c224d99 remote-processor/Message.h 22'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/pull/238#discussion_r39954056'>File: remote-processor/Message.h:L49-56</a></b>\n- <a href='https://github.com/krocard'><img border=0 src='https://avatars.githubusercontent.com/u/6862950?v=3' height=16 width=16'></a> \n``` cpp\nvirtual ~CMessage() = default;\n```\n\n\n<a href='https://www.codereviewhub.com/01org/parameter-framework/pull/238?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/01org/parameter-framework/pull/238?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/01org/parameter-framework/pull/238'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\n<a href='#crh-end'></a>","created_at":"2015-09-17T15:20:25Z","updated_at":"2015-09-23T09:40:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6b8cb1662e016fa3b3dc9ff31f7560acfc29c68","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/01org/parameter-framework/pulls/238/commits","review_comments_url":"https://api.github.com/repos/01org/parameter-framework/pulls/238/comments","review_comment_url":"https://api.github.com/repos/01org/parameter-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/01org/parameter-framework/issues/238/comments","statuses_url":"https://api.github.com/repos/01org/parameter-framework/statuses/2369ef8a48b1a00ee713c4aa3690965b1576b8df","head":{"label":"cc6565:remotes/githubfgaffie/windows_port","ref":"remotes/githubfgaffie/windows_port","sha":"2369ef8a48b1a00ee713c4aa3690965b1576b8df","user":{"login":"cc6565","id":9692938,"avatar_url":"https://avatars.githubusercontent.com/u/9692938?v=3","gravatar_id":"","url":"https://api.github.com/users/cc6565","html_url":"https://github.com/cc6565","followers_url":"https://api.github.com/users/cc6565/followers","following_url":"https://api.github.com/users/cc6565/following{/other_user}","gists_url":"https://api.github.com/users/cc6565/gists{/gist_id}","starred_url":"https://api.github.com/users/cc6565/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cc6565/subscriptions","organizations_url":"https://api.github.com/users/cc6565/orgs","repos_url":"https://api.github.com/users/cc6565/repos","events_url":"https://api.github.com/users/cc6565/events{/privacy}","received_events_url":"https://api.github.com/users/cc6565/received_events","type":"User","site_admin":false},"repo":{"id":31022788,"name":"parameter-framework","full_name":"cc6565/parameter-framework","owner":{"login":"cc6565","id":9692938,"avatar_url":"https://avatars.githubusercontent.com/u/9692938?v=3","gravatar_id":"","url":"https://api.github.com/users/cc6565","html_url":"https://github.com/cc6565","followers_url":"https://api.github.com/users/cc6565/followers","following_url":"https://api.github.com/users/cc6565/following{/other_user}","gists_url":"https://api.github.com/users/cc6565/gists{/gist_id}","starred_url":"https://api.github.com/users/cc6565/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cc6565/subscriptions","organizations_url":"https://api.github.com/users/cc6565/orgs","repos_url":"https://api.github.com/users/cc6565/repos","events_url":"https://api.github.com/users/cc6565/events{/privacy}","received_events_url":"https://api.github.com/users/cc6565/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cc6565/parameter-framework","description":"Plugin-based and rule-based framework for describing and controlling parameters","fork":true,"url":"https://api.github.com/repos/cc6565/parameter-framework","forks_url":"https://api.github.com/repos/cc6565/parameter-framework/forks","keys_url":"https://api.github.com/repos/cc6565/parameter-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cc6565/parameter-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cc6565/parameter-framework/teams","hooks_url":"https://api.github.com/repos/cc6565/parameter-framework/hooks","issue_events_url":"https://api.github.com/repos/cc6565/parameter-framework/issues/events{/number}","events_url":"https://api.github.com/repos/cc6565/parameter-framework/events","assignees_url":"https://api.github.com/repos/cc6565/parameter-framework/assignees{/user}","branches_url":"https://api.github.com/repos/cc6565/parameter-framework/branches{/branch}","tags_url":"https://api.github.com/repos/cc6565/parameter-framework/tags","blobs_url":"https://api.github.com/repos/cc6565/parameter-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cc6565/parameter-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cc6565/parameter-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/cc6565/parameter-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cc6565/parameter-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/cc6565/parameter-framework/languages","stargazers_url":"https://api.github.com/repos/cc6565/parameter-framework/stargazers","contributors_url":"https://api.github.com/repos/cc6565/parameter-framework/contributors","subscribers_url":"https://api.github.com/repos/cc6565/parameter-framework/subscribers","subscription_url":"https://api.github.com/repos/cc6565/parameter-framework/subscription","commits_url":"https://api.github.com/repos/cc6565/parameter-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/cc6565/parameter-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/cc6565/parameter-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/cc6565/parameter-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/cc6565/parameter-framework/contents/{+path}","compare_url":"https://api.github.com/repos/cc6565/parameter-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cc6565/parameter-framework/merges","archive_url":"https://api.github.com/repos/cc6565/parameter-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cc6565/parameter-framework/downloads","issues_url":"https://api.github.com/repos/cc6565/parameter-framework/issues{/number}","pulls_url":"https://api.github.com/repos/cc6565/parameter-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/cc6565/parameter-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/cc6565/parameter-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cc6565/parameter-framework/labels{/name}","releases_url":"https://api.github.com/repos/cc6565/parameter-framework/releases{/id}","created_at":"2015-02-19T15:53:39Z","updated_at":"2015-04-01T16:25:30Z","pushed_at":"2015-09-21T16:14:13Z","git_url":"git://github.com/cc6565/parameter-framework.git","ssh_url":"git@github.com:cc6565/parameter-framework.git","clone_url":"https://github.com/cc6565/parameter-framework.git","svn_url":"https://github.com/cc6565/parameter-framework","homepage":"","size":36099,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"01org:windows_port","ref":"windows_port","sha":"74a9d5c02cd8b336ab8bd7d0d758498f87add61c","user":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"repo":{"id":16009363,"name":"parameter-framework","full_name":"01org/parameter-framework","owner":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/01org/parameter-framework","description":"Plugin-based and rule-based framework for describing and controlling parameters","fork":false,"url":"https://api.github.com/repos/01org/parameter-framework","forks_url":"https://api.github.com/repos/01org/parameter-framework/forks","keys_url":"https://api.github.com/repos/01org/parameter-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/01org/parameter-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/01org/parameter-framework/teams","hooks_url":"https://api.github.com/repos/01org/parameter-framework/hooks","issue_events_url":"https://api.github.com/repos/01org/parameter-framework/issues/events{/number}","events_url":"https://api.github.com/repos/01org/parameter-framework/events","assignees_url":"https://api.github.com/repos/01org/parameter-framework/assignees{/user}","branches_url":"https://api.github.com/repos/01org/parameter-framework/branches{/branch}","tags_url":"https://api.github.com/repos/01org/parameter-framework/tags","blobs_url":"https://api.github.com/repos/01org/parameter-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/01org/parameter-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/01org/parameter-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/01org/parameter-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/01org/parameter-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/01org/parameter-framework/languages","stargazers_url":"https://api.github.com/repos/01org/parameter-framework/stargazers","contributors_url":"https://api.github.com/repos/01org/parameter-framework/contributors","subscribers_url":"https://api.github.com/repos/01org/parameter-framework/subscribers","subscription_url":"https://api.github.com/repos/01org/parameter-framework/subscription","commits_url":"https://api.github.com/repos/01org/parameter-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/01org/parameter-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/01org/parameter-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/01org/parameter-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/01org/parameter-framework/contents/{+path}","compare_url":"https://api.github.com/repos/01org/parameter-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/01org/parameter-framework/merges","archive_url":"https://api.github.com/repos/01org/parameter-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/01org/parameter-framework/downloads","issues_url":"https://api.github.com/repos/01org/parameter-framework/issues{/number}","pulls_url":"https://api.github.com/repos/01org/parameter-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/01org/parameter-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/01org/parameter-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/01org/parameter-framework/labels{/name}","releases_url":"https://api.github.com/repos/01org/parameter-framework/releases{/id}","created_at":"2014-01-17T19:24:01Z","updated_at":"2015-09-22T17:02:45Z","pushed_at":"2015-09-23T08:52:39Z","git_url":"git://github.com/01org/parameter-framework.git","ssh_url":"git@github.com:01org/parameter-framework.git","clone_url":"https://github.com/01org/parameter-framework.git","svn_url":"https://github.com/01org/parameter-framework","homepage":"","size":49600,"stargazers_count":11,"watchers_count":11,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"open_issues_count":34,"forks":23,"open_issues":34,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/01org/parameter-framework/pulls/238"},"html":{"href":"https://github.com/01org/parameter-framework/pull/238"},"issue":{"href":"https://api.github.com/repos/01org/parameter-framework/issues/238"},"comments":{"href":"https://api.github.com/repos/01org/parameter-framework/issues/238/comments"},"review_comments":{"href":"https://api.github.com/repos/01org/parameter-framework/pulls/238/comments"},"review_comment":{"href":"https://api.github.com/repos/01org/parameter-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/01org/parameter-framework/pulls/238/commits"},"statuses":{"href":"https://api.github.com/repos/01org/parameter-framework/statuses/2369ef8a48b1a00ee713c4aa3690965b1576b8df"}}}}