{"action":"opened","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/22989","labels_url":"https://api.github.com/repos/saltstack/salt/issues/22989/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/22989/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/22989/events","html_url":"https://github.com/saltstack/salt/issues/22989","id":70449358,"number":22989,"title":"Salt service states returning inaccurate \"changes\" field","user":{"login":"cameronsparr","id":7155926,"avatar_url":"https://avatars.githubusercontent.com/u/7155926?v=3","gravatar_id":"","url":"https://api.github.com/users/cameronsparr","html_url":"https://github.com/cameronsparr","followers_url":"https://api.github.com/users/cameronsparr/followers","following_url":"https://api.github.com/users/cameronsparr/following{/other_user}","gists_url":"https://api.github.com/users/cameronsparr/gists{/gist_id}","starred_url":"https://api.github.com/users/cameronsparr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cameronsparr/subscriptions","organizations_url":"https://api.github.com/users/cameronsparr/orgs","repos_url":"https://api.github.com/users/cameronsparr/repos","events_url":"https://api.github.com/users/cameronsparr/events{/privacy}","received_events_url":"https://api.github.com/users/cameronsparr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-04-23T16:07:18Z","updated_at":"2015-04-23T16:07:18Z","closed_at":null,"body":"This is for salt service states that are running on CentOS 6.6,\r\n\r\nThe output is consistently returning service changes fields even when the service doesn't change, see the ip6tables state output below.\r\n\r\ntldr, ip6tables (and some other services) are already disabled and not running, but when executing the state it will return a comment like \"Service iptables is already disabled, and is dead\", which indicates no changes, but then the \"changes\" field is populated like 'changes': {'ip6tables': True}\r\n\r\nThis is reproducible and I can provide full debug/tracing output if needed.\r\n\r\nSalt Version Info:\r\n```\r\n[root@vwc-es87 ~]# salt --versions-report\r\n           Salt: 2014.7.4\r\n         Python: 2.6.6 (r266:84292, Jan 22 2014, 09:42:36)\r\n         Jinja2: 2.7.3\r\n       M2Crypto: 0.20.2\r\n msgpack-python: 0.4.4\r\n   msgpack-pure: Not Installed\r\n       pycrypto: 2.0.1\r\n        libnacl: Not Installed\r\n         PyYAML: 3.10\r\n          ioflo: Not Installed\r\n          PyZMQ: 14.3.1\r\n           RAET: Not Installed\r\n            ZMQ: 3.2.5\r\n           Mako: Not Installed\r\n```\r\n\r\nOperating System Info:\r\n```\r\n    os:\r\n        CentOS\r\n    os_family:\r\n        RedHat\r\n    osarch:\r\n        x86_64\r\n    oscodename:\r\n        Final\r\n    osfinger:\r\n        CentOS-6\r\n    osfullname:\r\n        CentOS\r\n    osmajorrelease:\r\n        6\r\n    osrelease:\r\n        6.6\r\n    osrelease_info:\r\n        - 6\r\n        - 6\r\n```\r\n\r\nSalt State:\r\n```\r\nmultipath-service:\r\n    service.running:\r\n        - name: multipathd\r\n        - require:\r\n            - sls: sf_client.packages\r\n            - file: /etc/multipath.conf\r\n        - watch:\r\n            - file: /etc/multipath.conf\r\n        - enable: True\r\n\r\napiserver-service:\r\n    service.running:\r\n        - name: apiserver\r\n        - enable: True\r\n        - require:\r\n            - file: apiserver-service-file\r\n\r\niptables:\r\n    service.dead:\r\n        - enable: False\r\n\r\nip6tables:\r\n    service.dead:\r\n        - enable: False\r\n```\r\n\r\nState Output:\r\n```\r\n 'service_|-apiserver-service_|-apiserver_|-running': {'__run_num__': 30,\r\n  'changes': {'apiserver': True},\r\n  'comment': 'Service apiserver is already enabled, and is running',\r\n  'duration': 27.232,\r\n  'name': 'apiserver',\r\n  'result': True,\r\n  'start_time': '15:32:43.664127'},\r\n 'service_|-ip6tables_|-ip6tables_|-dead': {'__run_num__': 34,\r\n  'changes': {'ip6tables': True},\r\n  'comment': 'Service ip6tables is already disabled, and is dead',\r\n  'duration': 141.265,\r\n  'name': 'ip6tables',\r\n  'result': True,\r\n  'start_time': '15:32:44.251660'},\r\n 'service_|-iptables_|-iptables_|-dead': {'__run_num__': 33,\r\n  'changes': {'iptables': True},\r\n  'comment': 'Service iptables is already disabled, and is dead',\r\n  'duration': 474.938,\r\n  'name': 'iptables',\r\n  'result': True,\r\n  'start_time': '15:32:43.776549'},\r\n 'service_|-multipath-service_|-multipathd_|-running': {'__run_num__': 29,\r\n  'changes': {},\r\n  'comment': 'Service multipathd is already enabled, and is in the desired state',\r\n  'duration': 111.791,\r\n  'name': 'multipathd',\r\n  'result': True,\r\n  'start_time': '15:32:43.551560'},\r\n```"}}