{"action":"opened","number":4550,"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/4550","id":54605379,"html_url":"https://github.com/RIOT-OS/RIOT/pull/4550","diff_url":"https://github.com/RIOT-OS/RIOT/pull/4550.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/4550.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/4550","number":4550,"state":"open","locked":false,"title":"drivers/dht: added support to use external pull-up","user":{"login":"avmelnikoff","id":11994248,"avatar_url":"https://avatars.githubusercontent.com/u/11994248?v=3","gravatar_id":"","url":"https://api.github.com/users/avmelnikoff","html_url":"https://github.com/avmelnikoff","followers_url":"https://api.github.com/users/avmelnikoff/followers","following_url":"https://api.github.com/users/avmelnikoff/following{/other_user}","gists_url":"https://api.github.com/users/avmelnikoff/gists{/gist_id}","starred_url":"https://api.github.com/users/avmelnikoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avmelnikoff/subscriptions","organizations_url":"https://api.github.com/users/avmelnikoff/orgs","repos_url":"https://api.github.com/users/avmelnikoff/repos","events_url":"https://api.github.com/users/avmelnikoff/events{/privacy}","received_events_url":"https://api.github.com/users/avmelnikoff/received_events","type":"User","site_admin":false},"body":"In DHT driver GPIO pin configured to use internal MCU's pullup only. Accordingly to GPIO driver implementation for STM32F1xx (see gpio_init function in cpu/stm32f1/periph/gpio.c) and MCU's reference manual (RM0008 rev.15 page 160), we can't use pullups when GPIO configured for output direction.\r\nI decided to add DHT_EXT_PULLUP precompiler definition. If it defined, DHT driver will pass GPIO_NOPULL as the third (pullup) argument into the gpio_init function. And otherwise, if DHT_EXT_PULLUP is not defined, it will pass GPIO_PULLUP as it was implemented early.\r\nAnd of couse, it is useful for cases when schematic developer decid to use external pullups instead of MCU's internal.","created_at":"2015-12-26T18:00:28Z","updated_at":"2015-12-26T18:00:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/4550/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/4550/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/4550/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/599801f50310d209123e9c43e17129cfbbf76d59","head":{"label":"avmelnikoff:master","ref":"master","sha":"599801f50310d209123e9c43e17129cfbbf76d59","user":{"login":"avmelnikoff","id":11994248,"avatar_url":"https://avatars.githubusercontent.com/u/11994248?v=3","gravatar_id":"","url":"https://api.github.com/users/avmelnikoff","html_url":"https://github.com/avmelnikoff","followers_url":"https://api.github.com/users/avmelnikoff/followers","following_url":"https://api.github.com/users/avmelnikoff/following{/other_user}","gists_url":"https://api.github.com/users/avmelnikoff/gists{/gist_id}","starred_url":"https://api.github.com/users/avmelnikoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avmelnikoff/subscriptions","organizations_url":"https://api.github.com/users/avmelnikoff/orgs","repos_url":"https://api.github.com/users/avmelnikoff/repos","events_url":"https://api.github.com/users/avmelnikoff/events{/privacy}","received_events_url":"https://api.github.com/users/avmelnikoff/received_events","type":"User","site_admin":false},"repo":{"id":41475890,"name":"RIOT","full_name":"avmelnikoff/RIOT","owner":{"login":"avmelnikoff","id":11994248,"avatar_url":"https://avatars.githubusercontent.com/u/11994248?v=3","gravatar_id":"","url":"https://api.github.com/users/avmelnikoff","html_url":"https://github.com/avmelnikoff","followers_url":"https://api.github.com/users/avmelnikoff/followers","following_url":"https://api.github.com/users/avmelnikoff/following{/other_user}","gists_url":"https://api.github.com/users/avmelnikoff/gists{/gist_id}","starred_url":"https://api.github.com/users/avmelnikoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avmelnikoff/subscriptions","organizations_url":"https://api.github.com/users/avmelnikoff/orgs","repos_url":"https://api.github.com/users/avmelnikoff/repos","events_url":"https://api.github.com/users/avmelnikoff/events{/privacy}","received_events_url":"https://api.github.com/users/avmelnikoff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/avmelnikoff/RIOT","description":"RIOT -  The friendly OS for IoT","fork":true,"url":"https://api.github.com/repos/avmelnikoff/RIOT","forks_url":"https://api.github.com/repos/avmelnikoff/RIOT/forks","keys_url":"https://api.github.com/repos/avmelnikoff/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/avmelnikoff/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/avmelnikoff/RIOT/teams","hooks_url":"https://api.github.com/repos/avmelnikoff/RIOT/hooks","issue_events_url":"https://api.github.com/repos/avmelnikoff/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/avmelnikoff/RIOT/events","assignees_url":"https://api.github.com/repos/avmelnikoff/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/avmelnikoff/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/avmelnikoff/RIOT/tags","blobs_url":"https://api.github.com/repos/avmelnikoff/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/avmelnikoff/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/avmelnikoff/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/avmelnikoff/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/avmelnikoff/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/avmelnikoff/RIOT/languages","stargazers_url":"https://api.github.com/repos/avmelnikoff/RIOT/stargazers","contributors_url":"https://api.github.com/repos/avmelnikoff/RIOT/contributors","subscribers_url":"https://api.github.com/repos/avmelnikoff/RIOT/subscribers","subscription_url":"https://api.github.com/repos/avmelnikoff/RIOT/subscription","commits_url":"https://api.github.com/repos/avmelnikoff/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/avmelnikoff/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/avmelnikoff/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/avmelnikoff/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/avmelnikoff/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/avmelnikoff/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/avmelnikoff/RIOT/merges","archive_url":"https://api.github.com/repos/avmelnikoff/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/avmelnikoff/RIOT/downloads","issues_url":"https://api.github.com/repos/avmelnikoff/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/avmelnikoff/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/avmelnikoff/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/avmelnikoff/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/avmelnikoff/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/avmelnikoff/RIOT/releases{/id}","created_at":"2015-08-27T08:49:46Z","updated_at":"2015-08-27T08:49:57Z","pushed_at":"2015-12-26T17:58:06Z","git_url":"git://github.com/avmelnikoff/RIOT.git","ssh_url":"git@github.com:avmelnikoff/RIOT.git","clone_url":"https://github.com/avmelnikoff/RIOT.git","svn_url":"https://github.com/avmelnikoff/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":22646,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"36923341f03dda81e1ff88c3262884b1fdc53780","user":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars.githubusercontent.com/u/3079480?v=3","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"name":"RIOT","full_name":"RIOT-OS/RIOT","owner":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars.githubusercontent.com/u/3079480?v=3","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT -  The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","created_at":"2012-12-29T20:38:40Z","updated_at":"2015-12-26T07:44:52Z","pushed_at":"2015-12-26T15:35:15Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":78695,"stargazers_count":593,"watchers_count":593,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":459,"mirror_url":null,"open_issues_count":432,"forks":459,"open_issues":432,"watchers":593,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/4550"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/4550"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/4550"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/4550/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/4550/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/4550/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/599801f50310d209123e9c43e17129cfbbf76d59"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":9,"deletions":3,"changed_files":2}}