{"action":"created","issue":{"url":"https://api.github.com/repos/ceph/ceph/issues/6304","labels_url":"https://api.github.com/repos/ceph/ceph/issues/6304/labels{/name}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/6304/comments","events_url":"https://api.github.com/repos/ceph/ceph/issues/6304/events","html_url":"https://github.com/ceph/ceph/pull/6304","id":112081365,"number":6304,"title":"os/KeyValueDB: don't call self.valid() from next()","user":{"login":"branch-predictor","id":12440680,"avatar_url":"https://avatars.githubusercontent.com/u/12440680?v=3","gravatar_id":"","url":"https://api.github.com/users/branch-predictor","html_url":"https://github.com/branch-predictor","followers_url":"https://api.github.com/users/branch-predictor/followers","following_url":"https://api.github.com/users/branch-predictor/following{/other_user}","gists_url":"https://api.github.com/users/branch-predictor/gists{/gist_id}","starred_url":"https://api.github.com/users/branch-predictor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/branch-predictor/subscriptions","organizations_url":"https://api.github.com/users/branch-predictor/orgs","repos_url":"https://api.github.com/users/branch-predictor/repos","events_url":"https://api.github.com/users/branch-predictor/events{/privacy}","received_events_url":"https://api.github.com/users/branch-predictor/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ceph/ceph/labels/performance","name":"performance","color":"bfdadc"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-10-19T06:33:18Z","updated_at":"2015-11-05T15:53:10Z","closed_at":"2015-11-05T14:23:27Z","pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/6304","html_url":"https://github.com/ceph/ceph/pull/6304","diff_url":"https://github.com/ceph/ceph/pull/6304.diff","patch_url":"https://github.com/ceph/ceph/pull/6304.patch"},"body":"In most loops using ObjectMapIteratorImpl, there is a call to valid()\r\nfollowed by a call to next(), which calls valid() again. Calling\r\nvalid() alone is particularly expensive, so don't do it twice if\r\npossible.\r\n\r\nSigned-off-by: Piotr Dałek <piotr.dalek@ts.fujitsu.com>"},"comment":{"url":"https://api.github.com/repos/ceph/ceph/issues/comments/154100549","html_url":"https://github.com/ceph/ceph/pull/6304#issuecomment-154100549","issue_url":"https://api.github.com/repos/ceph/ceph/issues/6304","id":154100549,"user":{"login":"loic-bot","id":9638672,"avatar_url":"https://avatars.githubusercontent.com/u/9638672?v=3","gravatar_id":"","url":"https://api.github.com/users/loic-bot","html_url":"https://github.com/loic-bot","followers_url":"https://api.github.com/users/loic-bot/followers","following_url":"https://api.github.com/users/loic-bot/following{/other_user}","gists_url":"https://api.github.com/users/loic-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/loic-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loic-bot/subscriptions","organizations_url":"https://api.github.com/users/loic-bot/orgs","repos_url":"https://api.github.com/users/loic-bot/repos","events_url":"https://api.github.com/users/loic-bot/events{/privacy}","received_events_url":"https://api.github.com/users/loic-bot/received_events","type":"User","site_admin":false},"created_at":"2015-11-05T15:53:10Z","updated_at":"2015-11-05T15:53:10Z","body":"FAILURE: http://jenkins.ceph.dachary.org/job/ceph/8874/\n* FAILURE http://jenkins.ceph.dachary.org/job/ceph/LABELS=centos-7&&x86_64/8874/\n"}}