{"action":"created","issue":{"url":"https://api.github.com/repos/plataformatec/devise/issues/3250","labels_url":"https://api.github.com/repos/plataformatec/devise/issues/3250/labels{/name}","comments_url":"https://api.github.com/repos/plataformatec/devise/issues/3250/comments","events_url":"https://api.github.com/repos/plataformatec/devise/issues/3250/events","html_url":"https://github.com/plataformatec/devise/pull/3250","id":45391392,"number":3250,"title":"Fix no confirmation is allowed.","user":{"login":"JuanitoFatas","id":1000669,"avatar_url":"https://avatars.githubusercontent.com/u/1000669?v=3","gravatar_id":"","url":"https://api.github.com/users/JuanitoFatas","html_url":"https://github.com/JuanitoFatas","followers_url":"https://api.github.com/users/JuanitoFatas/followers","following_url":"https://api.github.com/users/JuanitoFatas/following{/other_user}","gists_url":"https://api.github.com/users/JuanitoFatas/gists{/gist_id}","starred_url":"https://api.github.com/users/JuanitoFatas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuanitoFatas/subscriptions","organizations_url":"https://api.github.com/users/JuanitoFatas/orgs","repos_url":"https://api.github.com/users/JuanitoFatas/repos","events_url":"https://api.github.com/users/JuanitoFatas/events{/privacy}","received_events_url":"https://api.github.com/users/JuanitoFatas/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2014-10-09T17:05:23Z","updated_at":"2015-02-16T16:01:31Z","closed_at":"2015-02-16T16:01:31Z","pull_request":{"url":"https://api.github.com/repos/plataformatec/devise/pulls/3250","html_url":"https://github.com/plataformatec/devise/pull/3250","diff_url":"https://github.com/plataformatec/devise/pull/3250.diff","patch_url":"https://github.com/plataformatec/devise/pull/3250.patch"},"body":"when `allow_unconfirmed_access_for` is set to `0.days`\r\nand `confirmation_sent_at` is any day after today (include today)\r\nthe `confirmation_sent_at && confirmation_sent_at.utc >=\r\nself.class.allow_unconfirmed_access_for.ago`\r\nwill always return true.\r\n\r\nThis patch check for 0.days case and return false immediately.\r\n\r\nfixes #3244"},"comment":{"url":"https://api.github.com/repos/plataformatec/devise/issues/comments/74530342","html_url":"https://github.com/plataformatec/devise/pull/3250#issuecomment-74530342","issue_url":"https://api.github.com/repos/plataformatec/devise/issues/3250","id":74530342,"user":{"login":"JuanitoFatas","id":1000669,"avatar_url":"https://avatars.githubusercontent.com/u/1000669?v=3","gravatar_id":"","url":"https://api.github.com/users/JuanitoFatas","html_url":"https://github.com/JuanitoFatas","followers_url":"https://api.github.com/users/JuanitoFatas/followers","following_url":"https://api.github.com/users/JuanitoFatas/following{/other_user}","gists_url":"https://api.github.com/users/JuanitoFatas/gists{/gist_id}","starred_url":"https://api.github.com/users/JuanitoFatas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuanitoFatas/subscriptions","organizations_url":"https://api.github.com/users/JuanitoFatas/orgs","repos_url":"https://api.github.com/users/JuanitoFatas/repos","events_url":"https://api.github.com/users/JuanitoFatas/events{/privacy}","received_events_url":"https://api.github.com/users/JuanitoFatas/received_events","type":"User","site_admin":false},"created_at":"2015-02-16T16:01:31Z","updated_at":"2015-02-16T16:01:31Z","body":"Hmmm. Sorry I must be wrong. Also as per https://github.com/plataformatec/devise/issues/3244#issuecomment-74223085, the correct fix of this should be the solution of this pull request. Thanks for checking again."}}