{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/7646","labels_url":"https://api.github.com/repos/servo/servo/issues/7646/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/7646/comments","events_url":"https://api.github.com/repos/servo/servo/issues/7646/events","html_url":"https://github.com/servo/servo/pull/7646","id":106806191,"number":7646,"title":"Write unit tests for cookie isolation","user":{"login":"jxs","id":1204690,"avatar_url":"https://avatars.githubusercontent.com/u/1204690?v=3","gravatar_id":"","url":"https://api.github.com/users/jxs","html_url":"https://github.com/jxs","followers_url":"https://api.github.com/users/jxs/followers","following_url":"https://api.github.com/users/jxs/following{/other_user}","gists_url":"https://api.github.com/users/jxs/gists{/gist_id}","starred_url":"https://api.github.com/users/jxs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jxs/subscriptions","organizations_url":"https://api.github.com/users/jxs/orgs","repos_url":"https://api.github.com/users/jxs/repos","events_url":"https://api.github.com/users/jxs/events{/privacy}","received_events_url":"https://api.github.com/users/jxs/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/S-needs-code-changes","name":"S-needs-code-changes","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"jdm","id":27658,"avatar_url":"https://avatars.githubusercontent.com/u/27658?v=3","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false},"milestone":null,"comments":13,"created_at":"2015-09-16T16:05:18Z","updated_at":"2015-09-21T16:41:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/7646","html_url":"https://github.com/servo/servo/pull/7646","diff_url":"https://github.com/servo/servo/pull/7646.diff","patch_url":"https://github.com/servo/servo/pull/7646.patch"},"body":"closes #7624\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/servo/servo/7646)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/142037907","html_url":"https://github.com/servo/servo/pull/7646#issuecomment-142037907","issue_url":"https://api.github.com/repos/servo/servo/issues/7646","id":142037907,"user":{"login":"jdm","id":27658,"avatar_url":"https://avatars.githubusercontent.com/u/27658?v=3","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false},"created_at":"2015-09-21T16:41:34Z","updated_at":"2015-09-21T16:41:34Z","body":"-S-awaiting-review +S-needs-code-changes \n\n---\n\nReviewed 1 of 1 files at r3.\nReview status: all files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.\n\n---\n\n<sup>**[tests/unit/net/http_loader.rs, line 585 \\[r3\\]](https://reviewable.io:443/reviews/servo/servo/7646#-JzkknZiKKQWlO4RuVBb)** ([raw file](https://github.com/servo/servo/blob/c1215b8086c4378535867d6c21ef78d726cc053c/tests/unit/net/http_loader.rs#L585)):</sup>\nThe `Secure` here means this cookie will not actually be set (since it's an insecure URL). we should remove it so we're actually testing what we want :)\n\n---\n\n<sup>**[tests/unit/net/http_loader.rs, line 614 \\[r3\\]](https://reviewable.io:443/reviews/servo/servo/7646#-JzklGLYLDLZiUatI_zR)** ([raw file](https://github.com/servo/servo/blob/c1215b8086c4378535867d6c21ef78d726cc053c/tests/unit/net/http_loader.rs#L614)):</sup>\nLet's remove the HttpOnly here.\n\n---\n\n<sup>**[tests/unit/net/http_loader.rs, line 631 \\[r3\\]](https://reviewable.io:443/reviews/servo/servo/7646#-JzklXcT2bvUPGIcwS32)** ([raw file](https://github.com/servo/servo/blob/c1215b8086c4378535867d6c21ef78d726cc053c/tests/unit/net/http_loader.rs#L631)):</sup>\nLet's remove the HttpOnly here, too.\n\n---\n\n\nComments from the [review on Reviewable.io](https://reviewable.io:443/reviews/servo/servo/7646)\n<!-- Sent from Reviewable.io -->\n"}}