{"action":"closed","number":32,"pull_request":{"url":"https://api.github.com/repos/ianmurrays/ngDfp/pulls/32","id":43456042,"html_url":"https://github.com/ianmurrays/ngDfp/pull/32","diff_url":"https://github.com/ianmurrays/ngDfp/pull/32.diff","patch_url":"https://github.com/ianmurrays/ngDfp/pull/32.patch","issue_url":"https://api.github.com/repos/ianmurrays/ngDfp/issues/32","number":32,"state":"closed","locked":false,"title":"Name Controller and Config parameters in README","user":{"login":"paislee","id":831742,"avatar_url":"https://avatars.githubusercontent.com/u/831742?v=3","gravatar_id":"","url":"https://api.github.com/users/paislee","html_url":"https://github.com/paislee","followers_url":"https://api.github.com/users/paislee/followers","following_url":"https://api.github.com/users/paislee/following{/other_user}","gists_url":"https://api.github.com/users/paislee/gists{/gist_id}","starred_url":"https://api.github.com/users/paislee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paislee/subscriptions","organizations_url":"https://api.github.com/users/paislee/orgs","repos_url":"https://api.github.com/users/paislee/repos","events_url":"https://api.github.com/users/paislee/events{/privacy}","received_events_url":"https://api.github.com/users/paislee/received_events","type":"User","site_admin":false},"body":"If this JavaScript gets compressed and variable names are mangled, the app will not compile because of dependency injection conventions in Angular, with error 'unknown provider'. Pull out the parameter names as strings to avoid this.","created_at":"2015-08-26T21:46:01Z","updated_at":"2015-09-15T08:32:05Z","closed_at":"2015-09-15T08:32:05Z","merged_at":null,"merge_commit_sha":"c61e6539cdc9367cff8ebdb3b0dce47ec517eac1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ianmurrays/ngDfp/pulls/32/commits","review_comments_url":"https://api.github.com/repos/ianmurrays/ngDfp/pulls/32/comments","review_comment_url":"https://api.github.com/repos/ianmurrays/ngDfp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ianmurrays/ngDfp/issues/32/comments","statuses_url":"https://api.github.com/repos/ianmurrays/ngDfp/statuses/160099dbe727a8d7f7553d27101a6a657cd4de8e","head":{"label":"paislee:master","ref":"master","sha":"160099dbe727a8d7f7553d27101a6a657cd4de8e","user":{"login":"paislee","id":831742,"avatar_url":"https://avatars.githubusercontent.com/u/831742?v=3","gravatar_id":"","url":"https://api.github.com/users/paislee","html_url":"https://github.com/paislee","followers_url":"https://api.github.com/users/paislee/followers","following_url":"https://api.github.com/users/paislee/following{/other_user}","gists_url":"https://api.github.com/users/paislee/gists{/gist_id}","starred_url":"https://api.github.com/users/paislee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paislee/subscriptions","organizations_url":"https://api.github.com/users/paislee/orgs","repos_url":"https://api.github.com/users/paislee/repos","events_url":"https://api.github.com/users/paislee/events{/privacy}","received_events_url":"https://api.github.com/users/paislee/received_events","type":"User","site_admin":false},"repo":{"id":41451283,"name":"ngDfp","full_name":"paislee/ngDfp","owner":{"login":"paislee","id":831742,"avatar_url":"https://avatars.githubusercontent.com/u/831742?v=3","gravatar_id":"","url":"https://api.github.com/users/paislee","html_url":"https://github.com/paislee","followers_url":"https://api.github.com/users/paislee/followers","following_url":"https://api.github.com/users/paislee/following{/other_user}","gists_url":"https://api.github.com/users/paislee/gists{/gist_id}","starred_url":"https://api.github.com/users/paislee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paislee/subscriptions","organizations_url":"https://api.github.com/users/paislee/orgs","repos_url":"https://api.github.com/users/paislee/repos","events_url":"https://api.github.com/users/paislee/events{/privacy}","received_events_url":"https://api.github.com/users/paislee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paislee/ngDfp","description":"DoubleClick For Publishers for Angular JS","fork":true,"url":"https://api.github.com/repos/paislee/ngDfp","forks_url":"https://api.github.com/repos/paislee/ngDfp/forks","keys_url":"https://api.github.com/repos/paislee/ngDfp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paislee/ngDfp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paislee/ngDfp/teams","hooks_url":"https://api.github.com/repos/paislee/ngDfp/hooks","issue_events_url":"https://api.github.com/repos/paislee/ngDfp/issues/events{/number}","events_url":"https://api.github.com/repos/paislee/ngDfp/events","assignees_url":"https://api.github.com/repos/paislee/ngDfp/assignees{/user}","branches_url":"https://api.github.com/repos/paislee/ngDfp/branches{/branch}","tags_url":"https://api.github.com/repos/paislee/ngDfp/tags","blobs_url":"https://api.github.com/repos/paislee/ngDfp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paislee/ngDfp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paislee/ngDfp/git/refs{/sha}","trees_url":"https://api.github.com/repos/paislee/ngDfp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paislee/ngDfp/statuses/{sha}","languages_url":"https://api.github.com/repos/paislee/ngDfp/languages","stargazers_url":"https://api.github.com/repos/paislee/ngDfp/stargazers","contributors_url":"https://api.github.com/repos/paislee/ngDfp/contributors","subscribers_url":"https://api.github.com/repos/paislee/ngDfp/subscribers","subscription_url":"https://api.github.com/repos/paislee/ngDfp/subscription","commits_url":"https://api.github.com/repos/paislee/ngDfp/commits{/sha}","git_commits_url":"https://api.github.com/repos/paislee/ngDfp/git/commits{/sha}","comments_url":"https://api.github.com/repos/paislee/ngDfp/comments{/number}","issue_comment_url":"https://api.github.com/repos/paislee/ngDfp/issues/comments{/number}","contents_url":"https://api.github.com/repos/paislee/ngDfp/contents/{+path}","compare_url":"https://api.github.com/repos/paislee/ngDfp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paislee/ngDfp/merges","archive_url":"https://api.github.com/repos/paislee/ngDfp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paislee/ngDfp/downloads","issues_url":"https://api.github.com/repos/paislee/ngDfp/issues{/number}","pulls_url":"https://api.github.com/repos/paislee/ngDfp/pulls{/number}","milestones_url":"https://api.github.com/repos/paislee/ngDfp/milestones{/number}","notifications_url":"https://api.github.com/repos/paislee/ngDfp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paislee/ngDfp/labels{/name}","releases_url":"https://api.github.com/repos/paislee/ngDfp/releases{/id}","created_at":"2015-08-26T21:41:01Z","updated_at":"2015-08-26T21:40:35Z","pushed_at":"2015-08-26T21:44:47Z","git_url":"git://github.com/paislee/ngDfp.git","ssh_url":"git@github.com:paislee/ngDfp.git","clone_url":"https://github.com/paislee/ngDfp.git","svn_url":"https://github.com/paislee/ngDfp","homepage":"","size":134,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ianmurrays:master","ref":"master","sha":"caa07480f0433163de96be28f50f15c606a404c6","user":{"login":"ianmurrays","id":422480,"avatar_url":"https://avatars.githubusercontent.com/u/422480?v=3","gravatar_id":"","url":"https://api.github.com/users/ianmurrays","html_url":"https://github.com/ianmurrays","followers_url":"https://api.github.com/users/ianmurrays/followers","following_url":"https://api.github.com/users/ianmurrays/following{/other_user}","gists_url":"https://api.github.com/users/ianmurrays/gists{/gist_id}","starred_url":"https://api.github.com/users/ianmurrays/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianmurrays/subscriptions","organizations_url":"https://api.github.com/users/ianmurrays/orgs","repos_url":"https://api.github.com/users/ianmurrays/repos","events_url":"https://api.github.com/users/ianmurrays/events{/privacy}","received_events_url":"https://api.github.com/users/ianmurrays/received_events","type":"User","site_admin":false},"repo":{"id":20447984,"name":"ngDfp","full_name":"ianmurrays/ngDfp","owner":{"login":"ianmurrays","id":422480,"avatar_url":"https://avatars.githubusercontent.com/u/422480?v=3","gravatar_id":"","url":"https://api.github.com/users/ianmurrays","html_url":"https://github.com/ianmurrays","followers_url":"https://api.github.com/users/ianmurrays/followers","following_url":"https://api.github.com/users/ianmurrays/following{/other_user}","gists_url":"https://api.github.com/users/ianmurrays/gists{/gist_id}","starred_url":"https://api.github.com/users/ianmurrays/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianmurrays/subscriptions","organizations_url":"https://api.github.com/users/ianmurrays/orgs","repos_url":"https://api.github.com/users/ianmurrays/repos","events_url":"https://api.github.com/users/ianmurrays/events{/privacy}","received_events_url":"https://api.github.com/users/ianmurrays/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ianmurrays/ngDfp","description":"DoubleClick For Publishers for Angular JS","fork":false,"url":"https://api.github.com/repos/ianmurrays/ngDfp","forks_url":"https://api.github.com/repos/ianmurrays/ngDfp/forks","keys_url":"https://api.github.com/repos/ianmurrays/ngDfp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ianmurrays/ngDfp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ianmurrays/ngDfp/teams","hooks_url":"https://api.github.com/repos/ianmurrays/ngDfp/hooks","issue_events_url":"https://api.github.com/repos/ianmurrays/ngDfp/issues/events{/number}","events_url":"https://api.github.com/repos/ianmurrays/ngDfp/events","assignees_url":"https://api.github.com/repos/ianmurrays/ngDfp/assignees{/user}","branches_url":"https://api.github.com/repos/ianmurrays/ngDfp/branches{/branch}","tags_url":"https://api.github.com/repos/ianmurrays/ngDfp/tags","blobs_url":"https://api.github.com/repos/ianmurrays/ngDfp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ianmurrays/ngDfp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ianmurrays/ngDfp/git/refs{/sha}","trees_url":"https://api.github.com/repos/ianmurrays/ngDfp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ianmurrays/ngDfp/statuses/{sha}","languages_url":"https://api.github.com/repos/ianmurrays/ngDfp/languages","stargazers_url":"https://api.github.com/repos/ianmurrays/ngDfp/stargazers","contributors_url":"https://api.github.com/repos/ianmurrays/ngDfp/contributors","subscribers_url":"https://api.github.com/repos/ianmurrays/ngDfp/subscribers","subscription_url":"https://api.github.com/repos/ianmurrays/ngDfp/subscription","commits_url":"https://api.github.com/repos/ianmurrays/ngDfp/commits{/sha}","git_commits_url":"https://api.github.com/repos/ianmurrays/ngDfp/git/commits{/sha}","comments_url":"https://api.github.com/repos/ianmurrays/ngDfp/comments{/number}","issue_comment_url":"https://api.github.com/repos/ianmurrays/ngDfp/issues/comments{/number}","contents_url":"https://api.github.com/repos/ianmurrays/ngDfp/contents/{+path}","compare_url":"https://api.github.com/repos/ianmurrays/ngDfp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ianmurrays/ngDfp/merges","archive_url":"https://api.github.com/repos/ianmurrays/ngDfp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ianmurrays/ngDfp/downloads","issues_url":"https://api.github.com/repos/ianmurrays/ngDfp/issues{/number}","pulls_url":"https://api.github.com/repos/ianmurrays/ngDfp/pulls{/number}","milestones_url":"https://api.github.com/repos/ianmurrays/ngDfp/milestones{/number}","notifications_url":"https://api.github.com/repos/ianmurrays/ngDfp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ianmurrays/ngDfp/labels{/name}","releases_url":"https://api.github.com/repos/ianmurrays/ngDfp/releases{/id}","created_at":"2014-06-03T15:21:14Z","updated_at":"2015-08-26T21:40:35Z","pushed_at":"2015-09-15T08:30:42Z","git_url":"git://github.com/ianmurrays/ngDfp.git","ssh_url":"git@github.com:ianmurrays/ngDfp.git","clone_url":"https://github.com/ianmurrays/ngDfp.git","svn_url":"https://github.com/ianmurrays/ngDfp","homepage":"","size":388,"stargazers_count":33,"watchers_count":33,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":13,"forks":16,"open_issues":13,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ianmurrays/ngDfp/pulls/32"},"html":{"href":"https://github.com/ianmurrays/ngDfp/pull/32"},"issue":{"href":"https://api.github.com/repos/ianmurrays/ngDfp/issues/32"},"comments":{"href":"https://api.github.com/repos/ianmurrays/ngDfp/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/ianmurrays/ngDfp/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/ianmurrays/ngDfp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ianmurrays/ngDfp/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/ianmurrays/ngDfp/statuses/160099dbe727a8d7f7553d27101a6a657cd4de8e"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":4,"deletions":4,"changed_files":1}}