{"action":"created","comment":{"url":"https://api.github.com/repos/jsperf/jsperf.com/pulls/comments/41700471","id":41700471,"diff_hunk":"@@ -1,27 +1,3 @@\n {\n-  \"settings\": {\n-    \"ecmascript\": 6\n-  },\n-  \"env\": {\n-    \"node\": true\n-  },\n-  \"rules\": {\n-    \"eol-last\": 2,\n-    \"no-space-before-semi\": 2,\n-    \"no-spaced-func\": 2,\n-    \"no-trailing-spaces\": 2,\n-    \"no-use-before-define\": 2,\n-    \"one-var\": 2,\n-    \"space-after-keywords\": 2,\n-    \"space-before-blocks\": [2, \"always\"],\n-    \"space-before-function-paren\": [2, \"never\"],\n-    \"space-in-parens\": [2, \"never\"],\n-    \"space-infix-ops\": 2,\n-    \"spaced-line-comment\": [2, \"always\"],\n-    \"space-return-throw-case\": 2\n-  },\n-  \"ecmaFeatures\": {\n-    \"blockBindings\": true,\n-    \"templateStrings\": false\n-  }\n+  \"extends\": \"standard\"","path":".eslintrc","position":27,"original_position":27,"commit_id":"0fd7116308a906366ef8b76d12ce6128af276724","original_commit_id":"0fd7116308a906366ef8b76d12ce6128af276724","user":{"login":"maxbeatty","id":93179,"avatar_url":"https://avatars.githubusercontent.com/u/93179?v=3","gravatar_id":"","url":"https://api.github.com/users/maxbeatty","html_url":"https://github.com/maxbeatty","followers_url":"https://api.github.com/users/maxbeatty/followers","following_url":"https://api.github.com/users/maxbeatty/following{/other_user}","gists_url":"https://api.github.com/users/maxbeatty/gists{/gist_id}","starred_url":"https://api.github.com/users/maxbeatty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxbeatty/subscriptions","organizations_url":"https://api.github.com/users/maxbeatty/orgs","repos_url":"https://api.github.com/users/maxbeatty/repos","events_url":"https://api.github.com/users/maxbeatty/events{/privacy}","received_events_url":"https://api.github.com/users/maxbeatty/received_events","type":"User","site_admin":false},"body":"use standard style instead of maintaining our own `.eslintrc`","created_at":"2015-10-10T19:17:07Z","updated_at":"2015-10-10T19:17:07Z","html_url":"https://github.com/jsperf/jsperf.com/pull/49#discussion_r41700471","pull_request_url":"https://api.github.com/repos/jsperf/jsperf.com/pulls/49","_links":{"self":{"href":"https://api.github.com/repos/jsperf/jsperf.com/pulls/comments/41700471"},"html":{"href":"https://github.com/jsperf/jsperf.com/pull/49#discussion_r41700471"},"pull_request":{"href":"https://api.github.com/repos/jsperf/jsperf.com/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/jsperf/jsperf.com/pulls/49","id":47351895,"html_url":"https://github.com/jsperf/jsperf.com/pull/49","diff_url":"https://github.com/jsperf/jsperf.com/pull/49.diff","patch_url":"https://github.com/jsperf/jsperf.com/pull/49.patch","issue_url":"https://api.github.com/repos/jsperf/jsperf.com/issues/49","number":49,"state":"open","locked":false,"title":"Use Standard Style","user":{"login":"maxbeatty","id":93179,"avatar_url":"https://avatars.githubusercontent.com/u/93179?v=3","gravatar_id":"","url":"https://api.github.com/users/maxbeatty","html_url":"https://github.com/maxbeatty","followers_url":"https://api.github.com/users/maxbeatty/followers","following_url":"https://api.github.com/users/maxbeatty/following{/other_user}","gists_url":"https://api.github.com/users/maxbeatty/gists{/gist_id}","starred_url":"https://api.github.com/users/maxbeatty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxbeatty/subscriptions","organizations_url":"https://api.github.com/users/maxbeatty/orgs","repos_url":"https://api.github.com/users/maxbeatty/repos","events_url":"https://api.github.com/users/maxbeatty/events{/privacy}","received_events_url":"https://api.github.com/users/maxbeatty/received_events","type":"User","site_admin":false},"body":"When I saw #48, I looked to [the travis job](https://travis-ci.org/jsperf/jsperf.com/builds/84592207) to see what didn't pass only to find:\r\n\r\n```\r\n$ npm test\r\n> jsperf.com@2.0.0 test /home/travis/build/jsperf/jsperf.com\r\n> lab -t 100 -c -L -r lcov -o lcov.info\r\nnpm ERR! Test failed.  See above for more details.\r\n```\r\n\r\nNot very helpful so I ran the tests locally adding a second reporter of \"console\" to `stdout`. Sure enough the test was broken, but there were also a lot of linting errors. Some mentioned outdated rules and at that point, I decided to pick a more widely used style that others maintain.\r\n\r\n_I don't have any strong feelings towards [Standard](http://standardjs.com/). We could use another rule set. I mostly just want to easily extend a config with eslint._\r\n\r\nAnd with that... I edited every file in the project... but now the tests pass and you can easily see what's wrong when you run the _standard_ `npm test`\r\n\r\n```\r\n$ npm test\r\n\r\n> jsperf.com@2.0.0 test /Users/max/Sites/jsperf.com\r\n> lab -t 100 -c -L -r lcov -o lcov.info -r console -o stdout\r\n\r\n\r\n  \r\n  ..................................................\r\n  ..................................................\r\n  ..................................................\r\n  .................\r\n\r\n167 tests complete\r\nTest duration: 2824 ms\r\nNo global variable leaks detected\r\nCoverage: 100.00%\r\nLinting results: No issues\r\n```\r\n\r\nI'll add some comments on specific parts that changed beyond style","created_at":"2015-10-10T19:16:01Z","updated_at":"2015-10-10T19:17:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4bf9e50e79916a267854e0b5dda2fa6aa5240e8c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jsperf/jsperf.com/pulls/49/commits","review_comments_url":"https://api.github.com/repos/jsperf/jsperf.com/pulls/49/comments","review_comment_url":"https://api.github.com/repos/jsperf/jsperf.com/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jsperf/jsperf.com/issues/49/comments","statuses_url":"https://api.github.com/repos/jsperf/jsperf.com/statuses/0fd7116308a906366ef8b76d12ce6128af276724","head":{"label":"jsperf:standard","ref":"standard","sha":"0fd7116308a906366ef8b76d12ce6128af276724","user":{"login":"jsperf","id":11043997,"avatar_url":"https://avatars.githubusercontent.com/u/11043997?v=3","gravatar_id":"","url":"https://api.github.com/users/jsperf","html_url":"https://github.com/jsperf","followers_url":"https://api.github.com/users/jsperf/followers","following_url":"https://api.github.com/users/jsperf/following{/other_user}","gists_url":"https://api.github.com/users/jsperf/gists{/gist_id}","starred_url":"https://api.github.com/users/jsperf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsperf/subscriptions","organizations_url":"https://api.github.com/users/jsperf/orgs","repos_url":"https://api.github.com/users/jsperf/repos","events_url":"https://api.github.com/users/jsperf/events{/privacy}","received_events_url":"https://api.github.com/users/jsperf/received_events","type":"Organization","site_admin":false},"repo":{"id":30963708,"name":"jsperf.com","full_name":"jsperf/jsperf.com","owner":{"login":"jsperf","id":11043997,"avatar_url":"https://avatars.githubusercontent.com/u/11043997?v=3","gravatar_id":"","url":"https://api.github.com/users/jsperf","html_url":"https://github.com/jsperf","followers_url":"https://api.github.com/users/jsperf/followers","following_url":"https://api.github.com/users/jsperf/following{/other_user}","gists_url":"https://api.github.com/users/jsperf/gists{/gist_id}","starred_url":"https://api.github.com/users/jsperf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsperf/subscriptions","organizations_url":"https://api.github.com/users/jsperf/orgs","repos_url":"https://api.github.com/users/jsperf/repos","events_url":"https://api.github.com/users/jsperf/events{/privacy}","received_events_url":"https://api.github.com/users/jsperf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jsperf/jsperf.com","description":"jsperf.com v2. https://github.com/h5bp/lazyweb-requests/issues/174","fork":false,"url":"https://api.github.com/repos/jsperf/jsperf.com","forks_url":"https://api.github.com/repos/jsperf/jsperf.com/forks","keys_url":"https://api.github.com/repos/jsperf/jsperf.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsperf/jsperf.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsperf/jsperf.com/teams","hooks_url":"https://api.github.com/repos/jsperf/jsperf.com/hooks","issue_events_url":"https://api.github.com/repos/jsperf/jsperf.com/issues/events{/number}","events_url":"https://api.github.com/repos/jsperf/jsperf.com/events","assignees_url":"https://api.github.com/repos/jsperf/jsperf.com/assignees{/user}","branches_url":"https://api.github.com/repos/jsperf/jsperf.com/branches{/branch}","tags_url":"https://api.github.com/repos/jsperf/jsperf.com/tags","blobs_url":"https://api.github.com/repos/jsperf/jsperf.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsperf/jsperf.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsperf/jsperf.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsperf/jsperf.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsperf/jsperf.com/statuses/{sha}","languages_url":"https://api.github.com/repos/jsperf/jsperf.com/languages","stargazers_url":"https://api.github.com/repos/jsperf/jsperf.com/stargazers","contributors_url":"https://api.github.com/repos/jsperf/jsperf.com/contributors","subscribers_url":"https://api.github.com/repos/jsperf/jsperf.com/subscribers","subscription_url":"https://api.github.com/repos/jsperf/jsperf.com/subscription","commits_url":"https://api.github.com/repos/jsperf/jsperf.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsperf/jsperf.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsperf/jsperf.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsperf/jsperf.com/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsperf/jsperf.com/contents/{+path}","compare_url":"https://api.github.com/repos/jsperf/jsperf.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsperf/jsperf.com/merges","archive_url":"https://api.github.com/repos/jsperf/jsperf.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsperf/jsperf.com/downloads","issues_url":"https://api.github.com/repos/jsperf/jsperf.com/issues{/number}","pulls_url":"https://api.github.com/repos/jsperf/jsperf.com/pulls{/number}","milestones_url":"https://api.github.com/repos/jsperf/jsperf.com/milestones{/number}","notifications_url":"https://api.github.com/repos/jsperf/jsperf.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsperf/jsperf.com/labels{/name}","releases_url":"https://api.github.com/repos/jsperf/jsperf.com/releases{/id}","created_at":"2015-02-18T11:56:31Z","updated_at":"2015-10-10T18:25:49Z","pushed_at":"2015-10-10T19:16:01Z","git_url":"git://github.com/jsperf/jsperf.com.git","ssh_url":"git@github.com:jsperf/jsperf.com.git","clone_url":"https://github.com/jsperf/jsperf.com.git","svn_url":"https://github.com/jsperf/jsperf.com","homepage":"","size":725,"stargazers_count":195,"watchers_count":195,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":21,"forks":28,"open_issues":21,"watchers":195,"default_branch":"master"}},"base":{"label":"jsperf:master","ref":"master","sha":"751b6e22645d6fb51e121d8cd2fd918c7e6aeb58","user":{"login":"jsperf","id":11043997,"avatar_url":"https://avatars.githubusercontent.com/u/11043997?v=3","gravatar_id":"","url":"https://api.github.com/users/jsperf","html_url":"https://github.com/jsperf","followers_url":"https://api.github.com/users/jsperf/followers","following_url":"https://api.github.com/users/jsperf/following{/other_user}","gists_url":"https://api.github.com/users/jsperf/gists{/gist_id}","starred_url":"https://api.github.com/users/jsperf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsperf/subscriptions","organizations_url":"https://api.github.com/users/jsperf/orgs","repos_url":"https://api.github.com/users/jsperf/repos","events_url":"https://api.github.com/users/jsperf/events{/privacy}","received_events_url":"https://api.github.com/users/jsperf/received_events","type":"Organization","site_admin":false},"repo":{"id":30963708,"name":"jsperf.com","full_name":"jsperf/jsperf.com","owner":{"login":"jsperf","id":11043997,"avatar_url":"https://avatars.githubusercontent.com/u/11043997?v=3","gravatar_id":"","url":"https://api.github.com/users/jsperf","html_url":"https://github.com/jsperf","followers_url":"https://api.github.com/users/jsperf/followers","following_url":"https://api.github.com/users/jsperf/following{/other_user}","gists_url":"https://api.github.com/users/jsperf/gists{/gist_id}","starred_url":"https://api.github.com/users/jsperf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsperf/subscriptions","organizations_url":"https://api.github.com/users/jsperf/orgs","repos_url":"https://api.github.com/users/jsperf/repos","events_url":"https://api.github.com/users/jsperf/events{/privacy}","received_events_url":"https://api.github.com/users/jsperf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jsperf/jsperf.com","description":"jsperf.com v2. https://github.com/h5bp/lazyweb-requests/issues/174","fork":false,"url":"https://api.github.com/repos/jsperf/jsperf.com","forks_url":"https://api.github.com/repos/jsperf/jsperf.com/forks","keys_url":"https://api.github.com/repos/jsperf/jsperf.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsperf/jsperf.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsperf/jsperf.com/teams","hooks_url":"https://api.github.com/repos/jsperf/jsperf.com/hooks","issue_events_url":"https://api.github.com/repos/jsperf/jsperf.com/issues/events{/number}","events_url":"https://api.github.com/repos/jsperf/jsperf.com/events","assignees_url":"https://api.github.com/repos/jsperf/jsperf.com/assignees{/user}","branches_url":"https://api.github.com/repos/jsperf/jsperf.com/branches{/branch}","tags_url":"https://api.github.com/repos/jsperf/jsperf.com/tags","blobs_url":"https://api.github.com/repos/jsperf/jsperf.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsperf/jsperf.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsperf/jsperf.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsperf/jsperf.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsperf/jsperf.com/statuses/{sha}","languages_url":"https://api.github.com/repos/jsperf/jsperf.com/languages","stargazers_url":"https://api.github.com/repos/jsperf/jsperf.com/stargazers","contributors_url":"https://api.github.com/repos/jsperf/jsperf.com/contributors","subscribers_url":"https://api.github.com/repos/jsperf/jsperf.com/subscribers","subscription_url":"https://api.github.com/repos/jsperf/jsperf.com/subscription","commits_url":"https://api.github.com/repos/jsperf/jsperf.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsperf/jsperf.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsperf/jsperf.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsperf/jsperf.com/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsperf/jsperf.com/contents/{+path}","compare_url":"https://api.github.com/repos/jsperf/jsperf.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsperf/jsperf.com/merges","archive_url":"https://api.github.com/repos/jsperf/jsperf.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsperf/jsperf.com/downloads","issues_url":"https://api.github.com/repos/jsperf/jsperf.com/issues{/number}","pulls_url":"https://api.github.com/repos/jsperf/jsperf.com/pulls{/number}","milestones_url":"https://api.github.com/repos/jsperf/jsperf.com/milestones{/number}","notifications_url":"https://api.github.com/repos/jsperf/jsperf.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsperf/jsperf.com/labels{/name}","releases_url":"https://api.github.com/repos/jsperf/jsperf.com/releases{/id}","created_at":"2015-02-18T11:56:31Z","updated_at":"2015-10-10T18:25:49Z","pushed_at":"2015-10-10T19:16:01Z","git_url":"git://github.com/jsperf/jsperf.com.git","ssh_url":"git@github.com:jsperf/jsperf.com.git","clone_url":"https://github.com/jsperf/jsperf.com.git","svn_url":"https://github.com/jsperf/jsperf.com","homepage":"","size":725,"stargazers_count":195,"watchers_count":195,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":21,"forks":28,"open_issues":21,"watchers":195,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jsperf/jsperf.com/pulls/49"},"html":{"href":"https://github.com/jsperf/jsperf.com/pull/49"},"issue":{"href":"https://api.github.com/repos/jsperf/jsperf.com/issues/49"},"comments":{"href":"https://api.github.com/repos/jsperf/jsperf.com/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/jsperf/jsperf.com/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/jsperf/jsperf.com/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jsperf/jsperf.com/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/jsperf/jsperf.com/statuses/0fd7116308a906366ef8b76d12ce6128af276724"}}}}