{"action":"created","comment":{"url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/comments/42707613","id":42707613,"diff_hunk":"@@ -28,8 +27,8 @@ class << base\n       end\n \n       module ClassMethods\n-        def inherited(base)\n-          base._reflections = self._reflections.try(:dup) || []\n+        def inherit_associations(base)","path":"lib/active_model/serializer/associations.rb","position":18,"original_position":18,"commit_id":"c7d0c599876ef6e9c2bf3e05a3563d3cca0c33ff","original_commit_id":"c7d0c599876ef6e9c2bf3e05a3563d3cca0c33ff","user":{"login":"bf4","id":142914,"avatar_url":"https://avatars.githubusercontent.com/u/142914?v=3","gravatar_id":"","url":"https://api.github.com/users/bf4","html_url":"https://github.com/bf4","followers_url":"https://api.github.com/users/bf4/followers","following_url":"https://api.github.com/users/bf4/following{/other_user}","gists_url":"https://api.github.com/users/bf4/gists{/gist_id}","starred_url":"https://api.github.com/users/bf4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bf4/subscriptions","organizations_url":"https://api.github.com/users/bf4/orgs","repos_url":"https://api.github.com/users/bf4/repos","events_url":"https://api.github.com/users/bf4/events{/privacy}","received_events_url":"https://api.github.com/users/bf4/received_events","type":"User","site_admin":false},"body":"sounds like this should be a bug fix, not part of a feature","created_at":"2015-10-22T03:11:14Z","updated_at":"2015-10-22T03:11:14Z","html_url":"https://github.com/rails-api/active_model_serializers/pull/1262#discussion_r42707613","pull_request_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1262","_links":{"self":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/comments/42707613"},"html":{"href":"https://github.com/rails-api/active_model_serializers/pull/1262#discussion_r42707613"},"pull_request":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1262"}}},"pull_request":{"url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1262","id":47302122,"html_url":"https://github.com/rails-api/active_model_serializers/pull/1262","diff_url":"https://github.com/rails-api/active_model_serializers/pull/1262.diff","patch_url":"https://github.com/rails-api/active_model_serializers/pull/1262.patch","issue_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1262","number":1262,"state":"open","locked":false,"title":"Add inline syntax to override attributes/associations.","user":{"login":"beauby","id":2215778,"avatar_url":"https://avatars.githubusercontent.com/u/2215778?v=3","gravatar_id":"","url":"https://api.github.com/users/beauby","html_url":"https://github.com/beauby","followers_url":"https://api.github.com/users/beauby/followers","following_url":"https://api.github.com/users/beauby/following{/other_user}","gists_url":"https://api.github.com/users/beauby/gists{/gist_id}","starred_url":"https://api.github.com/users/beauby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beauby/subscriptions","organizations_url":"https://api.github.com/users/beauby/orgs","repos_url":"https://api.github.com/users/beauby/repos","events_url":"https://api.github.com/users/beauby/events{/privacy}","received_events_url":"https://api.github.com/users/beauby/received_events","type":"User","site_admin":false},"body":"This PR brings the following syntax for overriding attributes/associations and declaring virtual attributes/associations in a serializer:\r\n```ruby\r\nclass PostSerializer < ActiveModel::Serializer\r\n  attribute :name do\r\n    \"#{object.first_name} #{object.last_name}\"\r\n  end\r\n\r\n  has_many :comments do\r\n    object.comments.limit(10)\r\n  end\r\nend\r\n```\r\nthat is currently equivalent to the usual\r\n```ruby\r\nclass PostSerializer < ActiveModel::Serializer\r\n  attribute :name\r\n  def name\r\n    \"#{object.first_name} #{object.last_name}\"\r\n  end\r\n\r\n  has_many :comments\r\n  def comments\r\n    object.comments.limit(10)\r\n  end\r\nend\r\n```\r\nNote that this change is not only cosmetic, as it is a prerequisite to move away from the old way (defining methods on the serializer, which caused many issues when the attribute name was that of a reserved method name (ref #1261)), and refactor the way attributes are handled in a safer way.\r\n\r\nUpdate: added overriding of associations as well + factoring out of the attributes logic.","created_at":"2015-10-09T18:06:56Z","updated_at":"2015-10-22T03:11:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dfe8fb39bfee7382b68fa5dca9a8a1ea24089338","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1262/commits","review_comments_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1262/comments","review_comment_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1262/comments","statuses_url":"https://api.github.com/repos/rails-api/active_model_serializers/statuses/c7d0c599876ef6e9c2bf3e05a3563d3cca0c33ff","head":{"label":"beauby:attribute-dsl","ref":"attribute-dsl","sha":"c7d0c599876ef6e9c2bf3e05a3563d3cca0c33ff","user":{"login":"beauby","id":2215778,"avatar_url":"https://avatars.githubusercontent.com/u/2215778?v=3","gravatar_id":"","url":"https://api.github.com/users/beauby","html_url":"https://github.com/beauby","followers_url":"https://api.github.com/users/beauby/followers","following_url":"https://api.github.com/users/beauby/following{/other_user}","gists_url":"https://api.github.com/users/beauby/gists{/gist_id}","starred_url":"https://api.github.com/users/beauby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beauby/subscriptions","organizations_url":"https://api.github.com/users/beauby/orgs","repos_url":"https://api.github.com/users/beauby/repos","events_url":"https://api.github.com/users/beauby/events{/privacy}","received_events_url":"https://api.github.com/users/beauby/received_events","type":"User","site_admin":false},"repo":{"id":30326986,"name":"active_model_serializers","full_name":"beauby/active_model_serializers","owner":{"login":"beauby","id":2215778,"avatar_url":"https://avatars.githubusercontent.com/u/2215778?v=3","gravatar_id":"","url":"https://api.github.com/users/beauby","html_url":"https://github.com/beauby","followers_url":"https://api.github.com/users/beauby/followers","following_url":"https://api.github.com/users/beauby/following{/other_user}","gists_url":"https://api.github.com/users/beauby/gists{/gist_id}","starred_url":"https://api.github.com/users/beauby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beauby/subscriptions","organizations_url":"https://api.github.com/users/beauby/orgs","repos_url":"https://api.github.com/users/beauby/repos","events_url":"https://api.github.com/users/beauby/events{/privacy}","received_events_url":"https://api.github.com/users/beauby/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/beauby/active_model_serializers","description":"ActiveModel::Serializer implementation and Rails hooks","fork":true,"url":"https://api.github.com/repos/beauby/active_model_serializers","forks_url":"https://api.github.com/repos/beauby/active_model_serializers/forks","keys_url":"https://api.github.com/repos/beauby/active_model_serializers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beauby/active_model_serializers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beauby/active_model_serializers/teams","hooks_url":"https://api.github.com/repos/beauby/active_model_serializers/hooks","issue_events_url":"https://api.github.com/repos/beauby/active_model_serializers/issues/events{/number}","events_url":"https://api.github.com/repos/beauby/active_model_serializers/events","assignees_url":"https://api.github.com/repos/beauby/active_model_serializers/assignees{/user}","branches_url":"https://api.github.com/repos/beauby/active_model_serializers/branches{/branch}","tags_url":"https://api.github.com/repos/beauby/active_model_serializers/tags","blobs_url":"https://api.github.com/repos/beauby/active_model_serializers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beauby/active_model_serializers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beauby/active_model_serializers/git/refs{/sha}","trees_url":"https://api.github.com/repos/beauby/active_model_serializers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beauby/active_model_serializers/statuses/{sha}","languages_url":"https://api.github.com/repos/beauby/active_model_serializers/languages","stargazers_url":"https://api.github.com/repos/beauby/active_model_serializers/stargazers","contributors_url":"https://api.github.com/repos/beauby/active_model_serializers/contributors","subscribers_url":"https://api.github.com/repos/beauby/active_model_serializers/subscribers","subscription_url":"https://api.github.com/repos/beauby/active_model_serializers/subscription","commits_url":"https://api.github.com/repos/beauby/active_model_serializers/commits{/sha}","git_commits_url":"https://api.github.com/repos/beauby/active_model_serializers/git/commits{/sha}","comments_url":"https://api.github.com/repos/beauby/active_model_serializers/comments{/number}","issue_comment_url":"https://api.github.com/repos/beauby/active_model_serializers/issues/comments{/number}","contents_url":"https://api.github.com/repos/beauby/active_model_serializers/contents/{+path}","compare_url":"https://api.github.com/repos/beauby/active_model_serializers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beauby/active_model_serializers/merges","archive_url":"https://api.github.com/repos/beauby/active_model_serializers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beauby/active_model_serializers/downloads","issues_url":"https://api.github.com/repos/beauby/active_model_serializers/issues{/number}","pulls_url":"https://api.github.com/repos/beauby/active_model_serializers/pulls{/number}","milestones_url":"https://api.github.com/repos/beauby/active_model_serializers/milestones{/number}","notifications_url":"https://api.github.com/repos/beauby/active_model_serializers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beauby/active_model_serializers/labels{/name}","releases_url":"https://api.github.com/repos/beauby/active_model_serializers/releases{/id}","created_at":"2015-02-04T23:25:42Z","updated_at":"2015-02-04T23:25:43Z","pushed_at":"2015-10-22T02:30:48Z","git_url":"git://github.com/beauby/active_model_serializers.git","ssh_url":"git@github.com:beauby/active_model_serializers.git","clone_url":"https://github.com/beauby/active_model_serializers.git","svn_url":"https://github.com/beauby/active_model_serializers","homepage":"","size":2452,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails-api:master","ref":"master","sha":"b2cd7bb51ab6f481972b196a9c2915a50aa52826","user":{"login":"rails-api","id":2820360,"avatar_url":"https://avatars.githubusercontent.com/u/2820360?v=3","gravatar_id":"","url":"https://api.github.com/users/rails-api","html_url":"https://github.com/rails-api","followers_url":"https://api.github.com/users/rails-api/followers","following_url":"https://api.github.com/users/rails-api/following{/other_user}","gists_url":"https://api.github.com/users/rails-api/gists{/gist_id}","starred_url":"https://api.github.com/users/rails-api/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails-api/subscriptions","organizations_url":"https://api.github.com/users/rails-api/orgs","repos_url":"https://api.github.com/users/rails-api/repos","events_url":"https://api.github.com/users/rails-api/events{/privacy}","received_events_url":"https://api.github.com/users/rails-api/received_events","type":"Organization","site_admin":false},"repo":{"id":2889230,"name":"active_model_serializers","full_name":"rails-api/active_model_serializers","owner":{"login":"rails-api","id":2820360,"avatar_url":"https://avatars.githubusercontent.com/u/2820360?v=3","gravatar_id":"","url":"https://api.github.com/users/rails-api","html_url":"https://github.com/rails-api","followers_url":"https://api.github.com/users/rails-api/followers","following_url":"https://api.github.com/users/rails-api/following{/other_user}","gists_url":"https://api.github.com/users/rails-api/gists{/gist_id}","starred_url":"https://api.github.com/users/rails-api/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails-api/subscriptions","organizations_url":"https://api.github.com/users/rails-api/orgs","repos_url":"https://api.github.com/users/rails-api/repos","events_url":"https://api.github.com/users/rails-api/events{/privacy}","received_events_url":"https://api.github.com/users/rails-api/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails-api/active_model_serializers","description":"ActiveModel::Serializer implementation and Rails hooks","fork":false,"url":"https://api.github.com/repos/rails-api/active_model_serializers","forks_url":"https://api.github.com/repos/rails-api/active_model_serializers/forks","keys_url":"https://api.github.com/repos/rails-api/active_model_serializers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails-api/active_model_serializers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails-api/active_model_serializers/teams","hooks_url":"https://api.github.com/repos/rails-api/active_model_serializers/hooks","issue_events_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/events{/number}","events_url":"https://api.github.com/repos/rails-api/active_model_serializers/events","assignees_url":"https://api.github.com/repos/rails-api/active_model_serializers/assignees{/user}","branches_url":"https://api.github.com/repos/rails-api/active_model_serializers/branches{/branch}","tags_url":"https://api.github.com/repos/rails-api/active_model_serializers/tags","blobs_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails-api/active_model_serializers/statuses/{sha}","languages_url":"https://api.github.com/repos/rails-api/active_model_serializers/languages","stargazers_url":"https://api.github.com/repos/rails-api/active_model_serializers/stargazers","contributors_url":"https://api.github.com/repos/rails-api/active_model_serializers/contributors","subscribers_url":"https://api.github.com/repos/rails-api/active_model_serializers/subscribers","subscription_url":"https://api.github.com/repos/rails-api/active_model_serializers/subscription","commits_url":"https://api.github.com/repos/rails-api/active_model_serializers/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails-api/active_model_serializers/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails-api/active_model_serializers/contents/{+path}","compare_url":"https://api.github.com/repos/rails-api/active_model_serializers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails-api/active_model_serializers/merges","archive_url":"https://api.github.com/repos/rails-api/active_model_serializers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails-api/active_model_serializers/downloads","issues_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues{/number}","pulls_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls{/number}","milestones_url":"https://api.github.com/repos/rails-api/active_model_serializers/milestones{/number}","notifications_url":"https://api.github.com/repos/rails-api/active_model_serializers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails-api/active_model_serializers/labels{/name}","releases_url":"https://api.github.com/repos/rails-api/active_model_serializers/releases{/id}","created_at":"2011-12-01T06:39:26Z","updated_at":"2015-10-21T20:27:25Z","pushed_at":"2015-10-22T02:30:49Z","git_url":"git://github.com/rails-api/active_model_serializers.git","ssh_url":"git@github.com:rails-api/active_model_serializers.git","clone_url":"https://github.com/rails-api/active_model_serializers.git","svn_url":"https://github.com/rails-api/active_model_serializers","homepage":"","size":7283,"stargazers_count":3071,"watchers_count":3071,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":709,"mirror_url":null,"open_issues_count":173,"forks":709,"open_issues":173,"watchers":3071,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1262"},"html":{"href":"https://github.com/rails-api/active_model_serializers/pull/1262"},"issue":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1262"},"comments":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1262/comments"},"review_comments":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1262/comments"},"review_comment":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1262/commits"},"statuses":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/statuses/c7d0c599876ef6e9c2bf3e05a3563d3cca0c33ff"}}}}