{"action":"opened","issue":{"url":"https://api.github.com/repos/andrewrk/mineflayer/issues/224","labels_url":"https://api.github.com/repos/andrewrk/mineflayer/issues/224/labels{/name}","comments_url":"https://api.github.com/repos/andrewrk/mineflayer/issues/224/comments","events_url":"https://api.github.com/repos/andrewrk/mineflayer/issues/224/events","html_url":"https://github.com/andrewrk/mineflayer/issues/224","id":62830015,"number":224,"title":"Fixing dying","user":{"login":"rom1504","id":2346494,"avatar_url":"https://avatars.githubusercontent.com/u/2346494?v=3","gravatar_id":"","url":"https://api.github.com/users/rom1504","html_url":"https://github.com/rom1504","followers_url":"https://api.github.com/users/rom1504/followers","following_url":"https://api.github.com/users/rom1504/following{/other_user}","gists_url":"https://api.github.com/users/rom1504/gists{/gist_id}","starred_url":"https://api.github.com/users/rom1504/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rom1504/subscriptions","organizations_url":"https://api.github.com/users/rom1504/orgs","repos_url":"https://api.github.com/users/rom1504/repos","events_url":"https://api.github.com/users/rom1504/events{/privacy}","received_events_url":"https://api.github.com/users/rom1504/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-03-18T23:55:50Z","updated_at":"2015-03-18T23:55:50Z","closed_at":null,"body":"Dying is currently broken because we forget the player on entity_destroy (https://github.com/andrewrk/mineflayer/blob/master/lib/plugins/entities.js#L222), then when the bot spawn, player_info is not sent again but named_entity_spawn is sent (https://github.com/andrewrk/mineflayer/blob/master/lib/plugins/entities.js#L142).\r\n\r\n\r\nRemoving the line 222 and 223 of entities.js (https://github.com/andrewrk/mineflayer/blob/master/lib/plugins/entities.js#L222) fixes the issue but is it acceptable ? Is it ok to keep in memory the dead players ? Does that include the disconnected players ?\r\n\r\nAn other way to handle this issue would be to accept having unnamed player, but that break a lot of things and I'm not sure it can work ? Is https://github.com/andrewrk/mineflayer/blob/master/lib/plugins/entities.js#L348 sent at some point to give the username anyway ?"}}