{"action":"created","issue":{"url":"https://api.github.com/repos/spotify/luigi/issues/1027","labels_url":"https://api.github.com/repos/spotify/luigi/issues/1027/labels{/name}","comments_url":"https://api.github.com/repos/spotify/luigi/issues/1027/comments","events_url":"https://api.github.com/repos/spotify/luigi/issues/1027/events","html_url":"https://github.com/spotify/luigi/pull/1027","id":91755801,"number":1027,"title":"Fix get_work() slowdown introduced in #986","user":{"login":"Tarrasch","id":294349,"avatar_url":"https://avatars.githubusercontent.com/u/294349?v=3","gravatar_id":"","url":"https://api.github.com/users/Tarrasch","html_url":"https://github.com/Tarrasch","followers_url":"https://api.github.com/users/Tarrasch/followers","following_url":"https://api.github.com/users/Tarrasch/following{/other_user}","gists_url":"https://api.github.com/users/Tarrasch/gists{/gist_id}","starred_url":"https://api.github.com/users/Tarrasch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tarrasch/subscriptions","organizations_url":"https://api.github.com/users/Tarrasch/orgs","repos_url":"https://api.github.com/users/Tarrasch/repos","events_url":"https://api.github.com/users/Tarrasch/events{/privacy}","received_events_url":"https://api.github.com/users/Tarrasch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-06-29T09:38:16Z","updated_at":"2015-06-29T11:43:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/spotify/luigi/pulls/1027","html_url":"https://github.com/spotify/luigi/pull/1027","diff_url":"https://github.com/spotify/luigi/pull/1027.diff","patch_url":"https://github.com/spotify/luigi/pull/1027.patch"},"body":"As daveFNbuck said in that PR. The patch in #986 slowed down his\r\nget_work() calls. My theory is that I actually worsened the worst case\r\ncomplexity in that patch because I assumed that tasks-per-worker is less\r\nthan total-pending-tasks. While that's definetly is the case at Spotify.\r\nThat is not the case at Houzz.\r\n\r\nThis patch tries to get the fastest speed in both settings. The setting\r\nthat will get a speed-up from this patch is when you have a very few\r\nworkers and most of your tasks are in the DONE state.\r\n\r\nping @daveFNbuck "},"comment":{"url":"https://api.github.com/repos/spotify/luigi/issues/comments/116624487","html_url":"https://github.com/spotify/luigi/pull/1027#issuecomment-116624487","issue_url":"https://api.github.com/repos/spotify/luigi/issues/1027","id":116624487,"user":{"login":"Tarrasch","id":294349,"avatar_url":"https://avatars.githubusercontent.com/u/294349?v=3","gravatar_id":"","url":"https://api.github.com/users/Tarrasch","html_url":"https://github.com/Tarrasch","followers_url":"https://api.github.com/users/Tarrasch/followers","following_url":"https://api.github.com/users/Tarrasch/following{/other_user}","gists_url":"https://api.github.com/users/Tarrasch/gists{/gist_id}","starred_url":"https://api.github.com/users/Tarrasch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tarrasch/subscriptions","organizations_url":"https://api.github.com/users/Tarrasch/orgs","repos_url":"https://api.github.com/users/Tarrasch/repos","events_url":"https://api.github.com/users/Tarrasch/events{/privacy}","received_events_url":"https://api.github.com/users/Tarrasch/received_events","type":"User","site_admin":false},"created_at":"2015-06-29T11:43:13Z","updated_at":"2015-06-29T11:43:13Z","body":"We could just do reasonable asserts in the tests I've added who are of a benchmarking nature. How do you imagine benchmark tests to look like?"}}