{"action":"created","issue":{"url":"https://api.github.com/repos/vgaltes/IoCTesting/issues/1","labels_url":"https://api.github.com/repos/vgaltes/IoCTesting/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/vgaltes/IoCTesting/issues/1/comments","events_url":"https://api.github.com/repos/vgaltes/IoCTesting/issues/1/events","html_url":"https://github.com/vgaltes/IoCTesting/issues/1","id":57102422,"number":1,"title":"Redundant check for interface type parameters","user":{"login":"luisxkimo","id":6990299,"avatar_url":"https://avatars.githubusercontent.com/u/6990299?v=3","gravatar_id":"","url":"https://api.github.com/users/luisxkimo","html_url":"https://github.com/luisxkimo","followers_url":"https://api.github.com/users/luisxkimo/followers","following_url":"https://api.github.com/users/luisxkimo/following{/other_user}","gists_url":"https://api.github.com/users/luisxkimo/gists{/gist_id}","starred_url":"https://api.github.com/users/luisxkimo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luisxkimo/subscriptions","organizations_url":"https://api.github.com/users/luisxkimo/orgs","repos_url":"https://api.github.com/users/luisxkimo/repos","events_url":"https://api.github.com/users/luisxkimo/events{/privacy}","received_events_url":"https://api.github.com/users/luisxkimo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-02-09T22:47:56Z","updated_at":"2015-02-09T22:52:20Z","closed_at":null,"body":"Hi Vicenç,\r\n\r\nFirst of all, congratulations for your project. I find it very useful and necessary for us that use IoC containers daily.\r\n\r\nI have a small doubt about your testing class. In IoCTesting.cs class on line 71 within the method \"CheckTypes\", is necessary to check that the type of the parameters \"isAbstract\" and \"isInterface\"? If what you need is to know which one is an interface, both methods return true for this data type as the MSDN documentation.\r\n\r\nhttps://msdn.microsoft.com/en-us/library/system.type.isabstract(v=vs.110).aspx\r\n\r\nI know my question is silly, but a few days ago in my work I can check that a test that we thought worked, because of this confusion in our case were not working properly.\r\n\r\nA greeting!"},"comment":{"url":"https://api.github.com/repos/vgaltes/IoCTesting/issues/comments/73608362","html_url":"https://github.com/vgaltes/IoCTesting/issues/1#issuecomment-73608362","issue_url":"https://api.github.com/repos/vgaltes/IoCTesting/issues/1","id":73608362,"user":{"login":"vgaltes","id":862679,"avatar_url":"https://avatars.githubusercontent.com/u/862679?v=3","gravatar_id":"","url":"https://api.github.com/users/vgaltes","html_url":"https://github.com/vgaltes","followers_url":"https://api.github.com/users/vgaltes/followers","following_url":"https://api.github.com/users/vgaltes/following{/other_user}","gists_url":"https://api.github.com/users/vgaltes/gists{/gist_id}","starred_url":"https://api.github.com/users/vgaltes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vgaltes/subscriptions","organizations_url":"https://api.github.com/users/vgaltes/orgs","repos_url":"https://api.github.com/users/vgaltes/repos","events_url":"https://api.github.com/users/vgaltes/events{/privacy}","received_events_url":"https://api.github.com/users/vgaltes/received_events","type":"User","site_admin":false},"created_at":"2015-02-09T22:52:20Z","updated_at":"2015-02-09T22:52:20Z","body":"Hi,\r\n\r\nthanks for your comment. Yes, it seems you are right. Let me test it and I'll push a new version.\r\n\r\nThank you!"}}