{"action":"created","issue":{"url":"https://api.github.com/repos/solettaproject/soletta/issues/1017","labels_url":"https://api.github.com/repos/solettaproject/soletta/issues/1017/labels{/name}","comments_url":"https://api.github.com/repos/solettaproject/soletta/issues/1017/comments","events_url":"https://api.github.com/repos/solettaproject/soletta/issues/1017/events","html_url":"https://github.com/solettaproject/soletta/pull/1017","id":115053409,"number":1017,"title":"sol-oic-gen: add SCAN port on clients","user":{"login":"bdilly","id":22437,"avatar_url":"https://avatars.githubusercontent.com/u/22437?v=3","gravatar_id":"","url":"https://api.github.com/users/bdilly","html_url":"https://github.com/bdilly","followers_url":"https://api.github.com/users/bdilly/followers","following_url":"https://api.github.com/users/bdilly/following{/other_user}","gists_url":"https://api.github.com/users/bdilly/gists{/gist_id}","starred_url":"https://api.github.com/users/bdilly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdilly/subscriptions","organizations_url":"https://api.github.com/users/bdilly/orgs","repos_url":"https://api.github.com/users/bdilly/repos","events_url":"https://api.github.com/users/bdilly/events{/privacy}","received_events_url":"https://api.github.com/users/bdilly/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-04T13:39:37Z","updated_at":"2015-11-04T18:25:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/solettaproject/soletta/pulls/1017","html_url":"https://github.com/solettaproject/soletta/pull/1017","diff_url":"https://github.com/solettaproject/soletta/pull/1017.diff","patch_url":"https://github.com/solettaproject/soletta/pull/1017.patch"},"body":"With that it's possible to request a scan for all servers\nthat matches the same interface of clients.\n\nIDs will be dispatched on DEVICE_ID port, so later\nthey can be used to select the device which the client\nwill talk.\n\nIdeally a human-friendly name should be sent on packet\nas well, not only the ID string, but I didn't found\nanything like that in our implementation so far.\n\nsol_oic_client_get_server_info return some information,\nbut only stuff related to a model, so users wouldn't\nbe able to use it to differentiate devices.\n\nMaybe manufacturer_name + model_number could be used.\n\nTODO: ID must be converted back from binary to\nhex ascii.\n\n@otaviobp please take a look on this. I'm pushing\nit this way because I'm not sure I'll be able\nto work more on that today.\n\nIt requires the conversion, and accepting IDs\nby port instead of only option to conclude this\ntask."},"comment":{"url":"https://api.github.com/repos/solettaproject/soletta/issues/comments/153819941","html_url":"https://github.com/solettaproject/soletta/pull/1017#issuecomment-153819941","issue_url":"https://api.github.com/repos/solettaproject/soletta/issues/1017","id":153819941,"user":{"login":"barbieri","id":1838,"avatar_url":"https://avatars.githubusercontent.com/u/1838?v=3","gravatar_id":"","url":"https://api.github.com/users/barbieri","html_url":"https://github.com/barbieri","followers_url":"https://api.github.com/users/barbieri/followers","following_url":"https://api.github.com/users/barbieri/following{/other_user}","gists_url":"https://api.github.com/users/barbieri/gists{/gist_id}","starred_url":"https://api.github.com/users/barbieri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barbieri/subscriptions","organizations_url":"https://api.github.com/users/barbieri/orgs","repos_url":"https://api.github.com/users/barbieri/repos","events_url":"https://api.github.com/users/barbieri/events{/privacy}","received_events_url":"https://api.github.com/users/barbieri/received_events","type":"User","site_admin":false},"created_at":"2015-11-04T18:25:50Z","updated_at":"2015-11-04T18:25:50Z","body":"Why did you choose to have the scan per-device, as opposed to have a scan type that takes an interface (or something like that) as parameter/inport?\r\n\r\nMy feeling is that it will be smaller code/binary-wise since this is not replicated in every generated node, also not adding 2 new ports of the node.\r\n\r\nAs for the pretty-name, @lpereira can tell you how to get. Until you get it done, use a composed packet with 2-3 strings and define which one is the ID, which one is the pretty name, etc. Use empty strings in those we don't support yet.\r\n"}}