{"action":"created","issue":{"url":"https://api.github.com/repos/benjamine/jsondiffpatch/issues/76","labels_url":"https://api.github.com/repos/benjamine/jsondiffpatch/issues/76/labels{/name}","comments_url":"https://api.github.com/repos/benjamine/jsondiffpatch/issues/76/comments","events_url":"https://api.github.com/repos/benjamine/jsondiffpatch/issues/76/events","html_url":"https://github.com/benjamine/jsondiffpatch/issues/76","id":62119431,"number":76,"title":"\"Critical dependencies\" in Webpack","user":{"login":"jiyinyiyong","id":449224,"avatar_url":"https://avatars.githubusercontent.com/u/449224?v=3","gravatar_id":"","url":"https://api.github.com/users/jiyinyiyong","html_url":"https://github.com/jiyinyiyong","followers_url":"https://api.github.com/users/jiyinyiyong/followers","following_url":"https://api.github.com/users/jiyinyiyong/following{/other_user}","gists_url":"https://api.github.com/users/jiyinyiyong/gists{/gist_id}","starred_url":"https://api.github.com/users/jiyinyiyong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiyinyiyong/subscriptions","organizations_url":"https://api.github.com/users/jiyinyiyong/orgs","repos_url":"https://api.github.com/users/jiyinyiyong/repos","events_url":"https://api.github.com/users/jiyinyiyong/events{/privacy}","received_events_url":"https://api.github.com/users/jiyinyiyong/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-03-16T15:38:53Z","updated_at":"2015-04-25T14:48:12Z","closed_at":null,"body":"I got this warning when in Webpack:\r\nhttps://github.com/webpack/webpack/issues/196\r\n\r\n```\r\n[WDS] Warnings while compiling.\r\nmain.js:576 ./~/jsondiffpatch/src/main.js\r\nCritical dependencies:\r\n48:19-49 the request of a dependency is an expression\r\n53:18-46 the request of a dependency is an expression\r\n @ ./~/jsondiffpatch/src/main.js 48:19-49 53:18-46\r\nmain.js:576 ./~/jsondiffpatch/src/formatters/index.js\r\nCritical dependencies:\r\n8:19-45 the request of a dependency is an expression\r\n @ ./~/jsondiffpatch/src/formatters/index.js 8:19-45\r\n```\r\n\r\nhttps://github.com/benjamine/jsondiffpatch/blob/master/src/main.js#L48\r\n\r\n```js\r\n\tvar packageInfoModuleName = '../package.json';\r\n\tvar packageInfo = require(packageInfoModuleName);\r\n\texports.homepage = packageInfo.homepage;\r\n\texports.version = packageInfo.version;\r\n\r\n\tvar formatterModuleName = './formatters';\r\n\tvar formatters = require(formatterModuleName);\r\n\texports.formatters = formatters;\r\n```\r\n\r\nIt's still working thank god. But is that ok we remove these line to get rid of the warnings?"},"comment":{"url":"https://api.github.com/repos/benjamine/jsondiffpatch/issues/comments/96217151","html_url":"https://github.com/benjamine/jsondiffpatch/issues/76#issuecomment-96217151","issue_url":"https://api.github.com/repos/benjamine/jsondiffpatch/issues/76","id":96217151,"user":{"login":"sokra","id":1365881,"avatar_url":"https://avatars.githubusercontent.com/u/1365881?v=3","gravatar_id":"","url":"https://api.github.com/users/sokra","html_url":"https://github.com/sokra","followers_url":"https://api.github.com/users/sokra/followers","following_url":"https://api.github.com/users/sokra/following{/other_user}","gists_url":"https://api.github.com/users/sokra/gists{/gist_id}","starred_url":"https://api.github.com/users/sokra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokra/subscriptions","organizations_url":"https://api.github.com/users/sokra/orgs","repos_url":"https://api.github.com/users/sokra/repos","events_url":"https://api.github.com/users/sokra/events{/privacy}","received_events_url":"https://api.github.com/users/sokra/received_events","type":"User","site_admin":false},"created_at":"2015-04-25T14:48:12Z","updated_at":"2015-04-25T14:48:12Z","body":"There is a spec for ignoring modules for the browser: https://gist.github.com/defunctzombie/4339901#ignore-a-module\r\n\r\ni. e.\r\n\r\n``` js\r\nbrowser: {\r\n  \"./package.json\": false,\r\n  \"./src/formatters\": false\r\n}\r\n```"}}