{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/17580","labels_url":"https://api.github.com/repos/docker/docker/issues/17580/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/17580/comments","events_url":"https://api.github.com/repos/docker/docker/issues/17580/events","html_url":"https://github.com/docker/docker/pull/17580","id":114444806,"number":17580,"title":"Move validation functions in runconfig","user":{"login":"jhowardmsft","id":10522484,"avatar_url":"https://avatars.githubusercontent.com/u/10522484?v=3","gravatar_id":"","url":"https://api.github.com/users/jhowardmsft","html_url":"https://github.com/jhowardmsft","followers_url":"https://api.github.com/users/jhowardmsft/followers","following_url":"https://api.github.com/users/jhowardmsft/following{/other_user}","gists_url":"https://api.github.com/users/jhowardmsft/gists{/gist_id}","starred_url":"https://api.github.com/users/jhowardmsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhowardmsft/subscriptions","organizations_url":"https://api.github.com/users/jhowardmsft/orgs","repos_url":"https://api.github.com/users/jhowardmsft/repos","events_url":"https://api.github.com/users/jhowardmsft/events{/privacy}","received_events_url":"https://api.github.com/users/jhowardmsft/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-11-01T01:51:16Z","updated_at":"2015-11-06T23:29:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/17580","html_url":"https://github.com/docker/docker/pull/17580","diff_url":"https://github.com/docker/docker/pull/17580.diff","patch_url":"https://github.com/docker/docker/pull/17580.patch"},"body":"Signed-off-by: John Howard <jhoward@microsoft.com>\r\n\r\nRealised that the validation functions `ValidateNetMode` and `ValidateIsolationLevel` are for fields in the hostConfig structure, and only called daemon side. They should not be in parse*.go, which is client-side parsing, which doesn't happen for these two fields.\r\n\r\nJust a re-jigging of code for correctness, no functional change"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/154576138","html_url":"https://github.com/docker/docker/pull/17580#issuecomment-154576138","issue_url":"https://api.github.com/repos/docker/docker/issues/17580","id":154576138,"user":{"login":"jhowardmsft","id":10522484,"avatar_url":"https://avatars.githubusercontent.com/u/10522484?v=3","gravatar_id":"","url":"https://api.github.com/users/jhowardmsft","html_url":"https://github.com/jhowardmsft","followers_url":"https://api.github.com/users/jhowardmsft/followers","following_url":"https://api.github.com/users/jhowardmsft/following{/other_user}","gists_url":"https://api.github.com/users/jhowardmsft/gists{/gist_id}","starred_url":"https://api.github.com/users/jhowardmsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhowardmsft/subscriptions","organizations_url":"https://api.github.com/users/jhowardmsft/orgs","repos_url":"https://api.github.com/users/jhowardmsft/repos","events_url":"https://api.github.com/users/jhowardmsft/events{/privacy}","received_events_url":"https://api.github.com/users/jhowardmsft/received_events","type":"User","site_admin":false},"created_at":"2015-11-06T23:29:27Z","updated_at":"2015-11-06T23:29:27Z","body":"@calavera Conflicted with the LXC removal PR. Rebased."}}