{"action":"created","comment":{"url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/comments/25871677","id":25871677,"diff_hunk":"@@ -81,6 +83,10 @@\n \n \tprivate volatile AbstractMessageChannelMetrics channelMetrics = new DefaultMessageChannelMetrics();\n \n+\tpublic AbstractMessageChannel() {\n+\t\tthis.interceptors = new ChannelInterceptorList(logger);\n+\t}","path":"spring-integration-core/src/main/java/org/springframework/integration/channel/AbstractMessageChannel.java","position":24,"original_position":24,"commit_id":"7985a43ea7fd6f8b2d8de031c1b577b753105132","original_commit_id":"7985a43ea7fd6f8b2d8de031c1b577b753105132","user":{"login":"garyrussell","id":483832,"avatar_url":"https://avatars.githubusercontent.com/u/483832?v=3","gravatar_id":"","url":"https://api.github.com/users/garyrussell","html_url":"https://github.com/garyrussell","followers_url":"https://api.github.com/users/garyrussell/followers","following_url":"https://api.github.com/users/garyrussell/following{/other_user}","gists_url":"https://api.github.com/users/garyrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/garyrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyrussell/subscriptions","organizations_url":"https://api.github.com/users/garyrussell/orgs","repos_url":"https://api.github.com/users/garyrussell/repos","events_url":"https://api.github.com/users/garyrussell/events{/privacy}","received_events_url":"https://api.github.com/users/garyrussell/received_events","type":"User","site_admin":false},"body":"Yes; that's how I had it at first, but I am not sure if it is safe to use the super field in the initialization code whereas in the ctor, we know that super() has completed. If you know for sure it's safe we can revert.","created_at":"2015-03-05T15:31:10Z","updated_at":"2015-03-05T15:31:10Z","html_url":"https://github.com/spring-projects/spring-integration/pull/1401#discussion_r25871677","pull_request_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1401","_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/comments/25871677"},"html":{"href":"https://github.com/spring-projects/spring-integration/pull/1401#discussion_r25871677"},"pull_request":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1401"}}},"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1401","id":30480440,"html_url":"https://github.com/spring-projects/spring-integration/pull/1401","diff_url":"https://github.com/spring-projects/spring-integration/pull/1401.diff","patch_url":"https://github.com/spring-projects/spring-integration/pull/1401.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-integration/issues/1401","number":1401,"state":"open","locked":false,"title":"INT-3656: Restore PreSend Log; Avoid Access Method","user":{"login":"garyrussell","id":483832,"avatar_url":"https://avatars.githubusercontent.com/u/483832?v=3","gravatar_id":"","url":"https://api.github.com/users/garyrussell","html_url":"https://github.com/garyrussell","followers_url":"https://api.github.com/users/garyrussell/followers","following_url":"https://api.github.com/users/garyrussell/following{/other_user}","gists_url":"https://api.github.com/users/garyrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/garyrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyrussell/subscriptions","organizations_url":"https://api.github.com/users/garyrussell/orgs","repos_url":"https://api.github.com/users/garyrussell/repos","events_url":"https://api.github.com/users/garyrussell/events{/privacy}","received_events_url":"https://api.github.com/users/garyrussell/received_events","type":"User","site_admin":false},"body":"JIRA: https://jira.spring.io/browse/INT-3656\r\n\r\nThe optimization (when no interceptors) inadvertently removed\r\nthe `preSend` DEBUG log.\r\n\r\nReinstate the DEBUG log.\r\n\r\nAlso change `ChannelInterceptorList` to a `static` class.\r\n\r\nThis avoids the access method invocation each time the channel's\r\n`logger` is used. The only `AMC` field used was the `logger`; pass\r\nit into the `CIL` via a constructor.\r\n\r\nOld bytecode:\r\n\r\n       104: aload_0\r\n       105: getfield      #14                 // Field this$0:Lorg/springframework/integration/channel/AbstractMessageChannel;\r\n       108: invokestatic  #60                 // Method org/springframework/integration/channel/AbstractMessageChannel.access$1:(Lorg/springframework/integration/channel/AbstractMessageChannel;)Lorg/apache/commons/logging/Log;\r\n       111: invokeinterface #66,  1           // InterfaceMethod org/apache/commons/logging/Log.isDebugEnabled:()Z\r\n       116: ifeq          157\r\n\r\nNew bytecode:\r\n\r\n        98: aload_0\r\n        99: getfield      #22                 // Field logger:Lorg/apache/commons/logging/Log;\r\n       102: invokeinterface #60,  1           // InterfaceMethod org/apache/commons/logging/Log.isDebugEnabled:()Z\r\n\r\n__cherry-pick to 4.1.x__","created_at":"2015-03-04T16:30:01Z","updated_at":"2015-03-05T15:31:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7fbbebe677980e79135ef94cf2d00d7a51ca4261","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1401/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1401/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-projects/spring-integration/issues/1401/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-integration/statuses/7985a43ea7fd6f8b2d8de031c1b577b753105132","head":{"label":"garyrussell:INT-3656","ref":"INT-3656","sha":"7985a43ea7fd6f8b2d8de031c1b577b753105132","user":{"login":"garyrussell","id":483832,"avatar_url":"https://avatars.githubusercontent.com/u/483832?v=3","gravatar_id":"","url":"https://api.github.com/users/garyrussell","html_url":"https://github.com/garyrussell","followers_url":"https://api.github.com/users/garyrussell/followers","following_url":"https://api.github.com/users/garyrussell/following{/other_user}","gists_url":"https://api.github.com/users/garyrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/garyrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyrussell/subscriptions","organizations_url":"https://api.github.com/users/garyrussell/orgs","repos_url":"https://api.github.com/users/garyrussell/repos","events_url":"https://api.github.com/users/garyrussell/events{/privacy}","received_events_url":"https://api.github.com/users/garyrussell/received_events","type":"User","site_admin":false},"repo":{"id":2197787,"name":"spring-integration","full_name":"garyrussell/spring-integration","owner":{"login":"garyrussell","id":483832,"avatar_url":"https://avatars.githubusercontent.com/u/483832?v=3","gravatar_id":"","url":"https://api.github.com/users/garyrussell","html_url":"https://github.com/garyrussell","followers_url":"https://api.github.com/users/garyrussell/followers","following_url":"https://api.github.com/users/garyrussell/following{/other_user}","gists_url":"https://api.github.com/users/garyrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/garyrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyrussell/subscriptions","organizations_url":"https://api.github.com/users/garyrussell/orgs","repos_url":"https://api.github.com/users/garyrussell/repos","events_url":"https://api.github.com/users/garyrussell/events{/privacy}","received_events_url":"https://api.github.com/users/garyrussell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/garyrussell/spring-integration","description":"","fork":true,"url":"https://api.github.com/repos/garyrussell/spring-integration","forks_url":"https://api.github.com/repos/garyrussell/spring-integration/forks","keys_url":"https://api.github.com/repos/garyrussell/spring-integration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garyrussell/spring-integration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garyrussell/spring-integration/teams","hooks_url":"https://api.github.com/repos/garyrussell/spring-integration/hooks","issue_events_url":"https://api.github.com/repos/garyrussell/spring-integration/issues/events{/number}","events_url":"https://api.github.com/repos/garyrussell/spring-integration/events","assignees_url":"https://api.github.com/repos/garyrussell/spring-integration/assignees{/user}","branches_url":"https://api.github.com/repos/garyrussell/spring-integration/branches{/branch}","tags_url":"https://api.github.com/repos/garyrussell/spring-integration/tags","blobs_url":"https://api.github.com/repos/garyrussell/spring-integration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garyrussell/spring-integration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garyrussell/spring-integration/git/refs{/sha}","trees_url":"https://api.github.com/repos/garyrussell/spring-integration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garyrussell/spring-integration/statuses/{sha}","languages_url":"https://api.github.com/repos/garyrussell/spring-integration/languages","stargazers_url":"https://api.github.com/repos/garyrussell/spring-integration/stargazers","contributors_url":"https://api.github.com/repos/garyrussell/spring-integration/contributors","subscribers_url":"https://api.github.com/repos/garyrussell/spring-integration/subscribers","subscription_url":"https://api.github.com/repos/garyrussell/spring-integration/subscription","commits_url":"https://api.github.com/repos/garyrussell/spring-integration/commits{/sha}","git_commits_url":"https://api.github.com/repos/garyrussell/spring-integration/git/commits{/sha}","comments_url":"https://api.github.com/repos/garyrussell/spring-integration/comments{/number}","issue_comment_url":"https://api.github.com/repos/garyrussell/spring-integration/issues/comments{/number}","contents_url":"https://api.github.com/repos/garyrussell/spring-integration/contents/{+path}","compare_url":"https://api.github.com/repos/garyrussell/spring-integration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garyrussell/spring-integration/merges","archive_url":"https://api.github.com/repos/garyrussell/spring-integration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garyrussell/spring-integration/downloads","issues_url":"https://api.github.com/repos/garyrussell/spring-integration/issues{/number}","pulls_url":"https://api.github.com/repos/garyrussell/spring-integration/pulls{/number}","milestones_url":"https://api.github.com/repos/garyrussell/spring-integration/milestones{/number}","notifications_url":"https://api.github.com/repos/garyrussell/spring-integration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garyrussell/spring-integration/labels{/name}","releases_url":"https://api.github.com/repos/garyrussell/spring-integration/releases{/id}","created_at":"2011-08-12T15:45:00Z","updated_at":"2015-03-03T16:17:44Z","pushed_at":"2015-03-05T00:54:24Z","git_url":"git://github.com/garyrussell/spring-integration.git","ssh_url":"git@github.com:garyrussell/spring-integration.git","clone_url":"https://github.com/garyrussell/spring-integration.git","svn_url":"https://github.com/garyrussell/spring-integration","homepage":"","size":35475,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"spring-projects:master","ref":"master","sha":"75ff56962af2ca558cb109a70c64456d5cd70ecc","user":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":2090979,"name":"spring-integration","full_name":"spring-projects/spring-integration","owner":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-projects/spring-integration","description":"Spring Integration provides an extension of the Spring programming model to support the well-known Enterprise Integration Patterns (EIP)","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-integration","forks_url":"https://api.github.com/repos/spring-projects/spring-integration/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-integration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-integration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-integration/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-integration/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-integration/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-integration/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-integration/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-integration/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-integration/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-integration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-integration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-integration/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-integration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-integration/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-integration/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-integration/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-integration/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-integration/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-integration/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-integration/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-integration/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-integration/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-integration/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-projects/spring-integration/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-integration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-integration/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-integration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-integration/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-integration/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-integration/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-integration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-integration/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-integration/releases{/id}","created_at":"2011-07-22T21:47:27Z","updated_at":"2015-03-05T08:50:54Z","pushed_at":"2015-03-05T08:50:54Z","git_url":"git://github.com/spring-projects/spring-integration.git","ssh_url":"git@github.com:spring-projects/spring-integration.git","clone_url":"https://github.com/spring-projects/spring-integration.git","svn_url":"https://github.com/spring-projects/spring-integration","homepage":"http://projects.spring.io/spring-integration/","size":82490,"stargazers_count":320,"watchers_count":320,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":301,"mirror_url":null,"open_issues_count":7,"forks":301,"open_issues":7,"watchers":320,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1401"},"html":{"href":"https://github.com/spring-projects/spring-integration/pull/1401"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-integration/issues/1401"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-integration/issues/1401/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1401/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1401/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-integration/statuses/7985a43ea7fd6f8b2d8de031c1b577b753105132"}}}}