{"action":"created","comment":{"url":"https://api.github.com/repos/miken/cep-developer-assessment/pulls/comments/27360411","id":27360411,"diff_hunk":"@@ -0,0 +1,21 @@\n+Exercise 1 Notes\n+================\n+\n+*Output files are written to the output directory and have a _comp extension.\n+For instance mean.csv is replicated as mean_out.csv and stats.csv is replicated\n+as stats_comp.csv.\n+\n+\n+*The Instructions said to use:  'undrorg'  but the output file example contains 'impsust'\n+\n+In an effort to get an exact diff match to the file I used the same cols as the example\n+output files.  If this is undesired it would be a trivial change to add in the correct\n+field in the __main__ section of the driver code:  john_furr.py\n+\n+*I have also highlighed via comments in the code alternative (simplified) way's of doing things.\n+In some cases I took a more verbose approach to calculating values or saving output, \n+but this was striclty to match the test files. I'd guess that in the real world you \n+wouldn't care about precission to 16 decimal places.\n+","path":"exercise1/submissions/README.md","position":19,"original_position":19,"commit_id":"bf73ca2b2e10f2b77339c8b7a3bfb969548080a4","original_commit_id":"bf73ca2b2e10f2b77339c8b7a3bfb969548080a4","user":{"login":"miken","id":372929,"avatar_url":"https://avatars.githubusercontent.com/u/372929?v=3","gravatar_id":"","url":"https://api.github.com/users/miken","html_url":"https://github.com/miken","followers_url":"https://api.github.com/users/miken/followers","following_url":"https://api.github.com/users/miken/following{/other_user}","gists_url":"https://api.github.com/users/miken/gists{/gist_id}","starred_url":"https://api.github.com/users/miken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miken/subscriptions","organizations_url":"https://api.github.com/users/miken/orgs","repos_url":"https://api.github.com/users/miken/repos","events_url":"https://api.github.com/users/miken/events{/privacy}","received_events_url":"https://api.github.com/users/miken/received_events","type":"User","site_admin":false},"body":"I appreciate you writing the alternatives. Indeed we do use the simplified functions instead of defining a more verbose function.","created_at":"2015-03-29T23:06:36Z","updated_at":"2015-03-29T23:06:36Z","html_url":"https://github.com/miken/cep-developer-assessment/pull/2#discussion_r27360411","pull_request_url":"https://api.github.com/repos/miken/cep-developer-assessment/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/miken/cep-developer-assessment/pulls/comments/27360411"},"html":{"href":"https://github.com/miken/cep-developer-assessment/pull/2#discussion_r27360411"},"pull_request":{"href":"https://api.github.com/repos/miken/cep-developer-assessment/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/miken/cep-developer-assessment/pulls/2","id":32190125,"html_url":"https://github.com/miken/cep-developer-assessment/pull/2","diff_url":"https://github.com/miken/cep-developer-assessment/pull/2.diff","patch_url":"https://github.com/miken/cep-developer-assessment/pull/2.patch","issue_url":"https://api.github.com/repos/miken/cep-developer-assessment/issues/2","number":2,"state":"open","locked":false,"title":"Review John's submission","user":{"login":"miken","id":372929,"avatar_url":"https://avatars.githubusercontent.com/u/372929?v=3","gravatar_id":"","url":"https://api.github.com/users/miken","html_url":"https://github.com/miken","followers_url":"https://api.github.com/users/miken/followers","following_url":"https://api.github.com/users/miken/following{/other_user}","gists_url":"https://api.github.com/users/miken/gists{/gist_id}","starred_url":"https://api.github.com/users/miken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miken/subscriptions","organizations_url":"https://api.github.com/users/miken/orgs","repos_url":"https://api.github.com/users/miken/repos","events_url":"https://api.github.com/users/miken/events{/privacy}","received_events_url":"https://api.github.com/users/miken/received_events","type":"User","site_admin":false},"body":"Thanks for submitting John. Overall, everything looks good! I'll address your comments in the code in this PR.\r\n\r\nPlease acknowledge my comments by replying here. Our recruiting team will be in touch with you shortly to schedule an interview with our leadership team. At that point, I'll delete this PR.","created_at":"2015-03-29T23:04:56Z","updated_at":"2015-03-29T23:06:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e246c8644f181431ec9a9df5b0fa117d03d443a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/miken/cep-developer-assessment/pulls/2/commits","review_comments_url":"https://api.github.com/repos/miken/cep-developer-assessment/pulls/2/comments","review_comment_url":"https://api.github.com/repos/miken/cep-developer-assessment/pulls/comments{/number}","comments_url":"https://api.github.com/repos/miken/cep-developer-assessment/issues/2/comments","statuses_url":"https://api.github.com/repos/miken/cep-developer-assessment/statuses/bf73ca2b2e10f2b77339c8b7a3bfb969548080a4","head":{"label":"gnulnx:master","ref":"master","sha":"bf73ca2b2e10f2b77339c8b7a3bfb969548080a4","user":{"login":"gnulnx","id":904782,"avatar_url":"https://avatars.githubusercontent.com/u/904782?v=3","gravatar_id":"","url":"https://api.github.com/users/gnulnx","html_url":"https://github.com/gnulnx","followers_url":"https://api.github.com/users/gnulnx/followers","following_url":"https://api.github.com/users/gnulnx/following{/other_user}","gists_url":"https://api.github.com/users/gnulnx/gists{/gist_id}","starred_url":"https://api.github.com/users/gnulnx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnulnx/subscriptions","organizations_url":"https://api.github.com/users/gnulnx/orgs","repos_url":"https://api.github.com/users/gnulnx/repos","events_url":"https://api.github.com/users/gnulnx/events{/privacy}","received_events_url":"https://api.github.com/users/gnulnx/received_events","type":"User","site_admin":false},"repo":{"id":33076047,"name":"cep-developer-assessment","full_name":"gnulnx/cep-developer-assessment","owner":{"login":"gnulnx","id":904782,"avatar_url":"https://avatars.githubusercontent.com/u/904782?v=3","gravatar_id":"","url":"https://api.github.com/users/gnulnx","html_url":"https://github.com/gnulnx","followers_url":"https://api.github.com/users/gnulnx/followers","following_url":"https://api.github.com/users/gnulnx/following{/other_user}","gists_url":"https://api.github.com/users/gnulnx/gists{/gist_id}","starred_url":"https://api.github.com/users/gnulnx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnulnx/subscriptions","organizations_url":"https://api.github.com/users/gnulnx/orgs","repos_url":"https://api.github.com/users/gnulnx/repos","events_url":"https://api.github.com/users/gnulnx/events{/privacy}","received_events_url":"https://api.github.com/users/gnulnx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gnulnx/cep-developer-assessment","description":"A hiring assessment for CEP's developer candidates","fork":true,"url":"https://api.github.com/repos/gnulnx/cep-developer-assessment","forks_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/forks","keys_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/teams","hooks_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/hooks","issue_events_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/issues/events{/number}","events_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/events","assignees_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/assignees{/user}","branches_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/branches{/branch}","tags_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/tags","blobs_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/git/refs{/sha}","trees_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/statuses/{sha}","languages_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/languages","stargazers_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/stargazers","contributors_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/contributors","subscribers_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/subscribers","subscription_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/subscription","commits_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/commits{/sha}","git_commits_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/git/commits{/sha}","comments_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/comments{/number}","issue_comment_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/issues/comments{/number}","contents_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/contents/{+path}","compare_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/merges","archive_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/downloads","issues_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/issues{/number}","pulls_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/pulls{/number}","milestones_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/milestones{/number}","notifications_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/labels{/name}","releases_url":"https://api.github.com/repos/gnulnx/cep-developer-assessment/releases{/id}","created_at":"2015-03-29T14:30:14Z","updated_at":"2015-03-29T15:48:04Z","pushed_at":"2015-03-29T15:48:04Z","git_url":"git://github.com/gnulnx/cep-developer-assessment.git","ssh_url":"git@github.com:gnulnx/cep-developer-assessment.git","clone_url":"https://github.com/gnulnx/cep-developer-assessment.git","svn_url":"https://github.com/gnulnx/cep-developer-assessment","homepage":null,"size":180,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"miken:master","ref":"master","sha":"aa870acfa15593de083ddd3ff9f32f6d5430b825","user":{"login":"miken","id":372929,"avatar_url":"https://avatars.githubusercontent.com/u/372929?v=3","gravatar_id":"","url":"https://api.github.com/users/miken","html_url":"https://github.com/miken","followers_url":"https://api.github.com/users/miken/followers","following_url":"https://api.github.com/users/miken/following{/other_user}","gists_url":"https://api.github.com/users/miken/gists{/gist_id}","starred_url":"https://api.github.com/users/miken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miken/subscriptions","organizations_url":"https://api.github.com/users/miken/orgs","repos_url":"https://api.github.com/users/miken/repos","events_url":"https://api.github.com/users/miken/events{/privacy}","received_events_url":"https://api.github.com/users/miken/received_events","type":"User","site_admin":false},"repo":{"id":19455941,"name":"cep-developer-assessment","full_name":"miken/cep-developer-assessment","owner":{"login":"miken","id":372929,"avatar_url":"https://avatars.githubusercontent.com/u/372929?v=3","gravatar_id":"","url":"https://api.github.com/users/miken","html_url":"https://github.com/miken","followers_url":"https://api.github.com/users/miken/followers","following_url":"https://api.github.com/users/miken/following{/other_user}","gists_url":"https://api.github.com/users/miken/gists{/gist_id}","starred_url":"https://api.github.com/users/miken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miken/subscriptions","organizations_url":"https://api.github.com/users/miken/orgs","repos_url":"https://api.github.com/users/miken/repos","events_url":"https://api.github.com/users/miken/events{/privacy}","received_events_url":"https://api.github.com/users/miken/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miken/cep-developer-assessment","description":"A hiring assessment for CEP's developer candidates","fork":false,"url":"https://api.github.com/repos/miken/cep-developer-assessment","forks_url":"https://api.github.com/repos/miken/cep-developer-assessment/forks","keys_url":"https://api.github.com/repos/miken/cep-developer-assessment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miken/cep-developer-assessment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miken/cep-developer-assessment/teams","hooks_url":"https://api.github.com/repos/miken/cep-developer-assessment/hooks","issue_events_url":"https://api.github.com/repos/miken/cep-developer-assessment/issues/events{/number}","events_url":"https://api.github.com/repos/miken/cep-developer-assessment/events","assignees_url":"https://api.github.com/repos/miken/cep-developer-assessment/assignees{/user}","branches_url":"https://api.github.com/repos/miken/cep-developer-assessment/branches{/branch}","tags_url":"https://api.github.com/repos/miken/cep-developer-assessment/tags","blobs_url":"https://api.github.com/repos/miken/cep-developer-assessment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miken/cep-developer-assessment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miken/cep-developer-assessment/git/refs{/sha}","trees_url":"https://api.github.com/repos/miken/cep-developer-assessment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miken/cep-developer-assessment/statuses/{sha}","languages_url":"https://api.github.com/repos/miken/cep-developer-assessment/languages","stargazers_url":"https://api.github.com/repos/miken/cep-developer-assessment/stargazers","contributors_url":"https://api.github.com/repos/miken/cep-developer-assessment/contributors","subscribers_url":"https://api.github.com/repos/miken/cep-developer-assessment/subscribers","subscription_url":"https://api.github.com/repos/miken/cep-developer-assessment/subscription","commits_url":"https://api.github.com/repos/miken/cep-developer-assessment/commits{/sha}","git_commits_url":"https://api.github.com/repos/miken/cep-developer-assessment/git/commits{/sha}","comments_url":"https://api.github.com/repos/miken/cep-developer-assessment/comments{/number}","issue_comment_url":"https://api.github.com/repos/miken/cep-developer-assessment/issues/comments{/number}","contents_url":"https://api.github.com/repos/miken/cep-developer-assessment/contents/{+path}","compare_url":"https://api.github.com/repos/miken/cep-developer-assessment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miken/cep-developer-assessment/merges","archive_url":"https://api.github.com/repos/miken/cep-developer-assessment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miken/cep-developer-assessment/downloads","issues_url":"https://api.github.com/repos/miken/cep-developer-assessment/issues{/number}","pulls_url":"https://api.github.com/repos/miken/cep-developer-assessment/pulls{/number}","milestones_url":"https://api.github.com/repos/miken/cep-developer-assessment/milestones{/number}","notifications_url":"https://api.github.com/repos/miken/cep-developer-assessment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miken/cep-developer-assessment/labels{/name}","releases_url":"https://api.github.com/repos/miken/cep-developer-assessment/releases{/id}","created_at":"2014-05-05T13:05:59Z","updated_at":"2015-02-09T20:35:54Z","pushed_at":"2015-03-29T23:04:56Z","git_url":"git://github.com/miken/cep-developer-assessment.git","ssh_url":"git@github.com:miken/cep-developer-assessment.git","clone_url":"https://github.com/miken/cep-developer-assessment.git","svn_url":"https://github.com/miken/cep-developer-assessment","homepage":null,"size":262,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":1,"forks":13,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/miken/cep-developer-assessment/pulls/2"},"html":{"href":"https://github.com/miken/cep-developer-assessment/pull/2"},"issue":{"href":"https://api.github.com/repos/miken/cep-developer-assessment/issues/2"},"comments":{"href":"https://api.github.com/repos/miken/cep-developer-assessment/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/miken/cep-developer-assessment/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/miken/cep-developer-assessment/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/miken/cep-developer-assessment/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/miken/cep-developer-assessment/statuses/bf73ca2b2e10f2b77339c8b7a3bfb969548080a4"}}}}