{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/14529","labels_url":"https://api.github.com/repos/owncloud/core/issues/14529/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/14529/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/14529/events","html_url":"https://github.com/owncloud/core/pull/14529","id":59052173,"number":14529,"title":"Make version check work on the lowest common version denominator","user":{"login":"Raydiation","id":195053,"avatar_url":"https://avatars.githubusercontent.com/u/195053?v=3","gravatar_id":"","url":"https://api.github.com/users/Raydiation","html_url":"https://github.com/Raydiation","followers_url":"https://api.github.com/users/Raydiation/followers","following_url":"https://api.github.com/users/Raydiation/following{/other_user}","gists_url":"https://api.github.com/users/Raydiation/gists{/gist_id}","starred_url":"https://api.github.com/users/Raydiation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raydiation/subscriptions","organizations_url":"https://api.github.com/users/Raydiation/orgs","repos_url":"https://api.github.com/users/Raydiation/repos","events_url":"https://api.github.com/users/Raydiation/events{/privacy}","received_events_url":"https://api.github.com/users/Raydiation/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/owncloud/core/labels/5%20-%20To%20review","name":"5 - To review","color":"ededed"},{"url":"https://api.github.com/repos/owncloud/core/labels/Enhancement","name":"Enhancement","color":"02e10c"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/31","html_url":"https://github.com/owncloud/core/milestones/8.1-current","labels_url":"https://api.github.com/repos/owncloud/core/milestones/31/labels","id":912160,"number":31,"title":"8.1-current","description":"","creator":{"login":"MorrisJobke","id":245432,"avatar_url":"https://avatars.githubusercontent.com/u/245432?v=3","gravatar_id":"","url":"https://api.github.com/users/MorrisJobke","html_url":"https://github.com/MorrisJobke","followers_url":"https://api.github.com/users/MorrisJobke/followers","following_url":"https://api.github.com/users/MorrisJobke/following{/other_user}","gists_url":"https://api.github.com/users/MorrisJobke/gists{/gist_id}","starred_url":"https://api.github.com/users/MorrisJobke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MorrisJobke/subscriptions","organizations_url":"https://api.github.com/users/MorrisJobke/orgs","repos_url":"https://api.github.com/users/MorrisJobke/repos","events_url":"https://api.github.com/users/MorrisJobke/events{/privacy}","received_events_url":"https://api.github.com/users/MorrisJobke/received_events","type":"User","site_admin":false},"open_issues":370,"closed_issues":204,"state":"open","created_at":"2014-12-22T12:04:01Z","updated_at":"2015-02-27T08:39:29Z","due_on":"2015-04-02T22:00:00Z","closed_at":null},"comments":9,"created_at":"2015-02-26T10:32:11Z","updated_at":"2015-02-27T08:40:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/14529","html_url":"https://github.com/owncloud/core/pull/14529","diff_url":"https://github.com/owncloud/core/pull/14529.diff","patch_url":"https://github.com/owncloud/core/pull/14529.patch"},"body":"See https://github.com/owncloud/core/issues/14392\r\n\r\nThe idea is to ignore patch releases if they are not specifically required as a dependency, e.g. the following app would require PHP 5 (5.0, 5.1, 5.2.3, etc) but not PHP 6\r\n\r\n```xml\r\n<php min-version=\"5\" max-version=\"5\" />\r\n```\r\nThe current implementation would just compare 5.5 with 5 and see that 5.5 is bigger than 5 and fail. This is not really intuitive and helpful.\r\n\r\n\r\nAs for requiring specific path versions, you can specify the version more, e.g. if you want to limit the version to maximum of 5.5 (as in 5.6 is not supported), you can do the following\r\n\r\n```xml\r\n<php max-version=\"5.5\" />\r\n```\r\n\r\nYou still define the patch level accurately, e.g.: if you rely on versions bigger than 5.3.2 (because a fix is in 5.3.3 that you need) you can do the following\r\n\r\n```xml\r\n<php min-version=\"5.3.3\"/>\r\n```\r\n\r\n@DeepDiver1975 @MorrisJobke @jbtbnl @PVince81 \r\n"},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/76356544","html_url":"https://github.com/owncloud/core/pull/14529#issuecomment-76356544","issue_url":"https://api.github.com/repos/owncloud/core/issues/14529","id":76356544,"user":{"login":"DeepDiver1975","id":1005065,"avatar_url":"https://avatars.githubusercontent.com/u/1005065?v=3","gravatar_id":"","url":"https://api.github.com/users/DeepDiver1975","html_url":"https://github.com/DeepDiver1975","followers_url":"https://api.github.com/users/DeepDiver1975/followers","following_url":"https://api.github.com/users/DeepDiver1975/following{/other_user}","gists_url":"https://api.github.com/users/DeepDiver1975/gists{/gist_id}","starred_url":"https://api.github.com/users/DeepDiver1975/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeepDiver1975/subscriptions","organizations_url":"https://api.github.com/users/DeepDiver1975/orgs","repos_url":"https://api.github.com/users/DeepDiver1975/repos","events_url":"https://api.github.com/users/DeepDiver1975/events{/privacy}","received_events_url":"https://api.github.com/users/DeepDiver1975/received_events","type":"User","site_admin":false},"created_at":"2015-02-27T08:40:02Z","updated_at":"2015-02-27T08:40:02Z","body":"@owncloud-bot retest this please"}}