{"action":"closed","issue":{"url":"https://api.github.com/repos/Instabug/Instabug-iOS/issues/15","labels_url":"https://api.github.com/repos/Instabug/Instabug-iOS/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/Instabug/Instabug-iOS/issues/15/comments","events_url":"https://api.github.com/repos/Instabug/Instabug-iOS/issues/15/events","html_url":"https://github.com/Instabug/Instabug-iOS/issues/15","id":59526763,"number":15,"title":"Network check in upload script should be done after the platform check","user":{"login":"dreese","id":310985,"avatar_url":"https://avatars.githubusercontent.com/u/310985?v=3","gravatar_id":"","url":"https://api.github.com/users/dreese","html_url":"https://github.com/dreese","followers_url":"https://api.github.com/users/dreese/followers","following_url":"https://api.github.com/users/dreese/following{/other_user}","gists_url":"https://api.github.com/users/dreese/gists{/gist_id}","starred_url":"https://api.github.com/users/dreese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dreese/subscriptions","organizations_url":"https://api.github.com/users/dreese/orgs","repos_url":"https://api.github.com/users/dreese/repos","events_url":"https://api.github.com/users/dreese/events{/privacy}","received_events_url":"https://api.github.com/users/dreese/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-03-02T18:50:23Z","updated_at":"2015-03-09T16:34:37Z","closed_at":"2015-03-09T16:34:37Z","body":"Checking the internet connection can take up to 10 seconds, and if we are going to skip the upload anyway (because it's a simulator build), then there is no reason to have the delay.\r\n\r\nJust need to move this code:\r\n```\r\n#Check internet connection\r\nif [ ! \"`ping -c 1 instabug.com`\" ]; then\r\n  exit 0\r\nfi\r\n```\r\n\r\nTo be after this code, instead of before it:\r\n```\r\n# Check for simulator builds\r\nif [ \"$EFFECTIVE_PLATFORM_NAME\" == \"-iphonesimulator\" ]; then\r\n  if [ \"${SKIP_SIMULATOR_BUILDS}\" ] && [ \"${SKIP_SIMULATOR_BUILDS}\" -eq 1 ]; then\r\n    echo \"Instabug: Skipping simulator build\"\r\n    exit 0\r\n  fi\r\nfi\r\n```"}}