{"action":"created","comment":{"url":"https://api.github.com/repos/sympy/sympy/pulls/comments/36040020","id":36040020,"diff_hunk":"@@ -809,39 +809,46 @@ def test_solve_lambert():\n \n \n def test_solveset():\n-    x = Symbol('x', real=True)\n+    x = Symbol('x')\n     raises(ValueError, lambda: solveset(x + y))\n \n-    assert solveset(exp(x) - 1) == FiniteSet(0)\n-    assert solveset(exp(x) - 1, x) == FiniteSet(0)\n-    assert solveset(Eq(exp(x), 1), x) == FiniteSet(0)\n+    assert solveset(exp(x) - 1, domain=S.Reals) == FiniteSet(0)\n+    assert solveset(exp(x) - 1, x, S.Reals) == FiniteSet(0)\n+    assert solveset(Eq(exp(x), 1), x, S.Reals) == FiniteSet(0)\n \n-    assert solveset(x - 1 >= 0, x) == Interval(1, oo)\n-    assert solveset(exp(x) - 1 >= 0, x) == Interval(0, oo)\n+    assert solveset(x - 1 >= 0, x, S.Reals) == Interval(1, oo)\n+    assert solveset(exp(x) - 1 >= 0, x, S.Reals) == Interval(0, oo)\n \n-    x = Symbol('x')\n     assert solveset(exp(x) - 1, x) == imageset(Lambda(n, 2*I*pi*n), S.Integers)\n     assert solveset(Eq(exp(x), 1), x) == imageset(Lambda(n, 2*I*pi*n),\n                                                   S.Integers)\n \n \n+def test_solveset_domain():\n+    x = Symbol('x')\n+\n+    assert solveset(exp(x) - 1, x, S.Reals) == FiniteSet(0)","path":"sympy/solvers/tests/test_solveset.py","position":38,"original_position":38,"commit_id":"f986e5950607118cb216488871a4d7a3e49851a3","original_commit_id":"f986e5950607118cb216488871a4d7a3e49851a3","user":{"login":"gxyd","id":7712241,"avatar_url":"https://avatars.githubusercontent.com/u/7712241?v=3","gravatar_id":"","url":"https://api.github.com/users/gxyd","html_url":"https://github.com/gxyd","followers_url":"https://api.github.com/users/gxyd/followers","following_url":"https://api.github.com/users/gxyd/following{/other_user}","gists_url":"https://api.github.com/users/gxyd/gists{/gist_id}","starred_url":"https://api.github.com/users/gxyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gxyd/subscriptions","organizations_url":"https://api.github.com/users/gxyd/orgs","repos_url":"https://api.github.com/users/gxyd/repos","events_url":"https://api.github.com/users/gxyd/events{/privacy}","received_events_url":"https://api.github.com/users/gxyd/received_events","type":"User","site_admin":false},"body":"Repeated test as [this](https://github.com/sympy/sympy/pull/9762/files#diff-85baa04bbf4e1dfd9128782738e45424R815)","created_at":"2015-08-02T06:24:32Z","updated_at":"2015-08-02T06:24:32Z","html_url":"https://github.com/sympy/sympy/pull/9762#discussion_r36040020","pull_request_url":"https://api.github.com/repos/sympy/sympy/pulls/9762","_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/36040020"},"html":{"href":"https://github.com/sympy/sympy/pull/9762#discussion_r36040020"},"pull_request":{"href":"https://api.github.com/repos/sympy/sympy/pulls/9762"}}},"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/9762","id":41397929,"html_url":"https://github.com/sympy/sympy/pull/9762","diff_url":"https://github.com/sympy/sympy/pull/9762.diff","patch_url":"https://github.com/sympy/sympy/pull/9762.patch","issue_url":"https://api.github.com/repos/sympy/sympy/issues/9762","number":9762,"state":"open","locked":false,"title":"Add domain argument in solveset","user":{"login":"shivamvats","id":6918975,"avatar_url":"https://avatars.githubusercontent.com/u/6918975?v=3","gravatar_id":"","url":"https://api.github.com/users/shivamvats","html_url":"https://github.com/shivamvats","followers_url":"https://api.github.com/users/shivamvats/followers","following_url":"https://api.github.com/users/shivamvats/following{/other_user}","gists_url":"https://api.github.com/users/shivamvats/gists{/gist_id}","starred_url":"https://api.github.com/users/shivamvats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivamvats/subscriptions","organizations_url":"https://api.github.com/users/shivamvats/orgs","repos_url":"https://api.github.com/users/shivamvats/repos","events_url":"https://api.github.com/users/shivamvats/events{/privacy}","received_events_url":"https://api.github.com/users/shivamvats/received_events","type":"User","site_admin":false},"body":"Fixes #9727\r\n\r\n@hargup @aktech\r\n\r\nI have removed the import of `Symbol` and `zeros` as they were not being used in the code.\r\n\r\nTODO:\r\n\r\n- [x] Update Docstring\r\n- [ ] Update Release Notes (after the merge)","created_at":"2015-08-01T07:13:09Z","updated_at":"2015-08-02T06:24:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac43ec6fc027f3ab3d8c0fa095e6d26239cbde25","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sympy/sympy/pulls/9762/commits","review_comments_url":"https://api.github.com/repos/sympy/sympy/pulls/9762/comments","review_comment_url":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/9762/comments","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/f986e5950607118cb216488871a4d7a3e49851a3","head":{"label":"shivamvats:solveset_domain","ref":"solveset_domain","sha":"f986e5950607118cb216488871a4d7a3e49851a3","user":{"login":"shivamvats","id":6918975,"avatar_url":"https://avatars.githubusercontent.com/u/6918975?v=3","gravatar_id":"","url":"https://api.github.com/users/shivamvats","html_url":"https://github.com/shivamvats","followers_url":"https://api.github.com/users/shivamvats/followers","following_url":"https://api.github.com/users/shivamvats/following{/other_user}","gists_url":"https://api.github.com/users/shivamvats/gists{/gist_id}","starred_url":"https://api.github.com/users/shivamvats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivamvats/subscriptions","organizations_url":"https://api.github.com/users/shivamvats/orgs","repos_url":"https://api.github.com/users/shivamvats/repos","events_url":"https://api.github.com/users/shivamvats/events{/privacy}","received_events_url":"https://api.github.com/users/shivamvats/received_events","type":"User","site_admin":false},"repo":{"id":25822792,"name":"sympy","full_name":"shivamvats/sympy","owner":{"login":"shivamvats","id":6918975,"avatar_url":"https://avatars.githubusercontent.com/u/6918975?v=3","gravatar_id":"","url":"https://api.github.com/users/shivamvats","html_url":"https://github.com/shivamvats","followers_url":"https://api.github.com/users/shivamvats/followers","following_url":"https://api.github.com/users/shivamvats/following{/other_user}","gists_url":"https://api.github.com/users/shivamvats/gists{/gist_id}","starred_url":"https://api.github.com/users/shivamvats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivamvats/subscriptions","organizations_url":"https://api.github.com/users/shivamvats/orgs","repos_url":"https://api.github.com/users/shivamvats/repos","events_url":"https://api.github.com/users/shivamvats/events{/privacy}","received_events_url":"https://api.github.com/users/shivamvats/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shivamvats/sympy","description":"A computer algebra system written in pure Python","fork":true,"url":"https://api.github.com/repos/shivamvats/sympy","forks_url":"https://api.github.com/repos/shivamvats/sympy/forks","keys_url":"https://api.github.com/repos/shivamvats/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shivamvats/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shivamvats/sympy/teams","hooks_url":"https://api.github.com/repos/shivamvats/sympy/hooks","issue_events_url":"https://api.github.com/repos/shivamvats/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/shivamvats/sympy/events","assignees_url":"https://api.github.com/repos/shivamvats/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/shivamvats/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/shivamvats/sympy/tags","blobs_url":"https://api.github.com/repos/shivamvats/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shivamvats/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shivamvats/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/shivamvats/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shivamvats/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/shivamvats/sympy/languages","stargazers_url":"https://api.github.com/repos/shivamvats/sympy/stargazers","contributors_url":"https://api.github.com/repos/shivamvats/sympy/contributors","subscribers_url":"https://api.github.com/repos/shivamvats/sympy/subscribers","subscription_url":"https://api.github.com/repos/shivamvats/sympy/subscription","commits_url":"https://api.github.com/repos/shivamvats/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/shivamvats/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/shivamvats/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/shivamvats/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/shivamvats/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/shivamvats/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shivamvats/sympy/merges","archive_url":"https://api.github.com/repos/shivamvats/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shivamvats/sympy/downloads","issues_url":"https://api.github.com/repos/shivamvats/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/shivamvats/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/shivamvats/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/shivamvats/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shivamvats/sympy/labels{/name}","releases_url":"https://api.github.com/repos/shivamvats/sympy/releases{/id}","created_at":"2014-10-27T14:24:33Z","updated_at":"2014-11-07T04:25:04Z","pushed_at":"2015-08-02T03:56:59Z","git_url":"git://github.com/shivamvats/sympy.git","ssh_url":"git@github.com:shivamvats/sympy.git","clone_url":"https://github.com/shivamvats/sympy.git","svn_url":"https://github.com/shivamvats/sympy","homepage":"http://sympy.org/","size":79409,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"72eb0e5ab5e11bac2351cead11705c5c27a6672c","user":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":640534,"name":"sympy","full_name":"sympy/sympy","owner":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sympy/sympy","description":"A computer algebra system written in pure Python","fork":false,"url":"https://api.github.com/repos/sympy/sympy","forks_url":"https://api.github.com/repos/sympy/sympy/forks","keys_url":"https://api.github.com/repos/sympy/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/sympy/teams","hooks_url":"https://api.github.com/repos/sympy/sympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/sympy/events","assignees_url":"https://api.github.com/repos/sympy/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/sympy/tags","blobs_url":"https://api.github.com/repos/sympy/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/sympy/languages","stargazers_url":"https://api.github.com/repos/sympy/sympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/sympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/sympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/sympy/subscription","commits_url":"https://api.github.com/repos/sympy/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sympy/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/sympy/merges","archive_url":"https://api.github.com/repos/sympy/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/sympy/downloads","issues_url":"https://api.github.com/repos/sympy/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/sympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/sympy/releases{/id}","created_at":"2010-04-30T20:37:14Z","updated_at":"2015-08-01T15:42:26Z","pushed_at":"2015-08-02T03:57:02Z","git_url":"git://github.com/sympy/sympy.git","ssh_url":"git@github.com:sympy/sympy.git","clone_url":"https://github.com/sympy/sympy.git","svn_url":"https://github.com/sympy/sympy","homepage":"http://sympy.org/","size":152688,"stargazers_count":2255,"watchers_count":2255,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1107,"mirror_url":null,"open_issues_count":1954,"forks":1107,"open_issues":1954,"watchers":2255,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/9762"},"html":{"href":"https://github.com/sympy/sympy/pull/9762"},"issue":{"href":"https://api.github.com/repos/sympy/sympy/issues/9762"},"comments":{"href":"https://api.github.com/repos/sympy/sympy/issues/9762/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/sympy/pulls/9762/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sympy/sympy/pulls/9762/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/sympy/statuses/f986e5950607118cb216488871a4d7a3e49851a3"}}}}