{"action":"created","comment":{"url":"https://api.github.com/repos/OCA/sale-workflow/pulls/comments/38441125","id":38441125,"diff_hunk":"@@ -68,3 +70,9 @@ def test_sale_order_confirm(self):\n         for picking in sale_order.picking_ids:\n             self.assertEqual(self.sale_type.invoice_state,\n                              picking.invoice_state)\n+\n+    def test_stock_picking_create(self):\n+        self.picking_out = self.picking_model.create({","path":"sale_order_type/tests/test_sale_order_type.py","position":15,"original_position":15,"commit_id":"a5633d706b21ace7f2e80cd2c830cfe37c5e96e2","original_commit_id":"a5633d706b21ace7f2e80cd2c830cfe37c5e96e2","user":{"login":"pedrobaeza","id":7165771,"avatar_url":"https://avatars.githubusercontent.com/u/7165771?v=3","gravatar_id":"","url":"https://api.github.com/users/pedrobaeza","html_url":"https://github.com/pedrobaeza","followers_url":"https://api.github.com/users/pedrobaeza/followers","following_url":"https://api.github.com/users/pedrobaeza/following{/other_user}","gists_url":"https://api.github.com/users/pedrobaeza/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrobaeza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrobaeza/subscriptions","organizations_url":"https://api.github.com/users/pedrobaeza/orgs","repos_url":"https://api.github.com/users/pedrobaeza/repos","events_url":"https://api.github.com/users/pedrobaeza/events{/privacy}","received_events_url":"https://api.github.com/users/pedrobaeza/received_events","type":"User","site_admin":false},"body":"There's no assert here to test any condition, so the tests is useless (except possible code errors). You can just simply check that self.picking_out is really created.","created_at":"2015-09-01T16:41:24Z","updated_at":"2015-09-01T16:41:24Z","html_url":"https://github.com/OCA/sale-workflow/pull/199#discussion_r38441125","pull_request_url":"https://api.github.com/repos/OCA/sale-workflow/pulls/199","_links":{"self":{"href":"https://api.github.com/repos/OCA/sale-workflow/pulls/comments/38441125"},"html":{"href":"https://github.com/OCA/sale-workflow/pull/199#discussion_r38441125"},"pull_request":{"href":"https://api.github.com/repos/OCA/sale-workflow/pulls/199"}}},"pull_request":{"url":"https://api.github.com/repos/OCA/sale-workflow/pulls/199","id":43498486,"html_url":"https://github.com/OCA/sale-workflow/pull/199","diff_url":"https://github.com/OCA/sale-workflow/pull/199.diff","patch_url":"https://github.com/OCA/sale-workflow/pull/199.patch","issue_url":"https://api.github.com/repos/OCA/sale-workflow/issues/199","number":199,"state":"open","locked":false,"title":"[FIX] sale_order_type: Fixed bug when picking is created from a purchase order","user":{"login":"Daniel-CA","id":7643575,"avatar_url":"https://avatars.githubusercontent.com/u/7643575?v=3","gravatar_id":"","url":"https://api.github.com/users/Daniel-CA","html_url":"https://github.com/Daniel-CA","followers_url":"https://api.github.com/users/Daniel-CA/followers","following_url":"https://api.github.com/users/Daniel-CA/following{/other_user}","gists_url":"https://api.github.com/users/Daniel-CA/gists{/gist_id}","starred_url":"https://api.github.com/users/Daniel-CA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Daniel-CA/subscriptions","organizations_url":"https://api.github.com/users/Daniel-CA/orgs","repos_url":"https://api.github.com/users/Daniel-CA/repos","events_url":"https://api.github.com/users/Daniel-CA/events{/privacy}","received_events_url":"https://api.github.com/users/Daniel-CA/received_events","type":"User","site_admin":false},"body":"When the stock.picking is created the 'invoice_state' field cannot be null.","created_at":"2015-08-27T09:54:49Z","updated_at":"2015-09-01T16:41:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d641f93416d884fad748091eabfb3a4e9d5096f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OCA/sale-workflow/pulls/199/commits","review_comments_url":"https://api.github.com/repos/OCA/sale-workflow/pulls/199/comments","review_comment_url":"https://api.github.com/repos/OCA/sale-workflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OCA/sale-workflow/issues/199/comments","statuses_url":"https://api.github.com/repos/OCA/sale-workflow/statuses/a5633d706b21ace7f2e80cd2c830cfe37c5e96e2","head":{"label":"Daniel-CA:sale_order_type","ref":"sale_order_type","sha":"a5633d706b21ace7f2e80cd2c830cfe37c5e96e2","user":{"login":"Daniel-CA","id":7643575,"avatar_url":"https://avatars.githubusercontent.com/u/7643575?v=3","gravatar_id":"","url":"https://api.github.com/users/Daniel-CA","html_url":"https://github.com/Daniel-CA","followers_url":"https://api.github.com/users/Daniel-CA/followers","following_url":"https://api.github.com/users/Daniel-CA/following{/other_user}","gists_url":"https://api.github.com/users/Daniel-CA/gists{/gist_id}","starred_url":"https://api.github.com/users/Daniel-CA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Daniel-CA/subscriptions","organizations_url":"https://api.github.com/users/Daniel-CA/orgs","repos_url":"https://api.github.com/users/Daniel-CA/repos","events_url":"https://api.github.com/users/Daniel-CA/events{/privacy}","received_events_url":"https://api.github.com/users/Daniel-CA/received_events","type":"User","site_admin":false},"repo":{"id":35165205,"name":"sale-workflow","full_name":"Daniel-CA/sale-workflow","owner":{"login":"Daniel-CA","id":7643575,"avatar_url":"https://avatars.githubusercontent.com/u/7643575?v=3","gravatar_id":"","url":"https://api.github.com/users/Daniel-CA","html_url":"https://github.com/Daniel-CA","followers_url":"https://api.github.com/users/Daniel-CA/followers","following_url":"https://api.github.com/users/Daniel-CA/following{/other_user}","gists_url":"https://api.github.com/users/Daniel-CA/gists{/gist_id}","starred_url":"https://api.github.com/users/Daniel-CA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Daniel-CA/subscriptions","organizations_url":"https://api.github.com/users/Daniel-CA/orgs","repos_url":"https://api.github.com/users/Daniel-CA/repos","events_url":"https://api.github.com/users/Daniel-CA/events{/privacy}","received_events_url":"https://api.github.com/users/Daniel-CA/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Daniel-CA/sale-workflow","description":"Odoo Sales, Workflow and Organization","fork":true,"url":"https://api.github.com/repos/Daniel-CA/sale-workflow","forks_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/forks","keys_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/teams","hooks_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/hooks","issue_events_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/issues/events{/number}","events_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/events","assignees_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/assignees{/user}","branches_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/branches{/branch}","tags_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/tags","blobs_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/statuses/{sha}","languages_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/languages","stargazers_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/stargazers","contributors_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/contributors","subscribers_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/subscribers","subscription_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/subscription","commits_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/contents/{+path}","compare_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/merges","archive_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/downloads","issues_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/issues{/number}","pulls_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/pulls{/number}","milestones_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/milestones{/number}","notifications_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/labels{/name}","releases_url":"https://api.github.com/repos/Daniel-CA/sale-workflow/releases{/id}","created_at":"2015-05-06T14:57:41Z","updated_at":"2015-05-06T14:57:42Z","pushed_at":"2015-09-01T07:24:04Z","git_url":"git://github.com/Daniel-CA/sale-workflow.git","ssh_url":"git@github.com:Daniel-CA/sale-workflow.git","clone_url":"https://github.com/Daniel-CA/sale-workflow.git","svn_url":"https://github.com/Daniel-CA/sale-workflow","homepage":"","size":1473,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"8.0"}},"base":{"label":"OCA:8.0","ref":"8.0","sha":"4a8563ce676dc79ac365e4b19dc0f55286fd32f3","user":{"login":"OCA","id":7600578,"avatar_url":"https://avatars.githubusercontent.com/u/7600578?v=3","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"repo":{"id":20882412,"name":"sale-workflow","full_name":"OCA/sale-workflow","owner":{"login":"OCA","id":7600578,"avatar_url":"https://avatars.githubusercontent.com/u/7600578?v=3","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OCA/sale-workflow","description":"Odoo Sales, Workflow and Organization","fork":false,"url":"https://api.github.com/repos/OCA/sale-workflow","forks_url":"https://api.github.com/repos/OCA/sale-workflow/forks","keys_url":"https://api.github.com/repos/OCA/sale-workflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OCA/sale-workflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OCA/sale-workflow/teams","hooks_url":"https://api.github.com/repos/OCA/sale-workflow/hooks","issue_events_url":"https://api.github.com/repos/OCA/sale-workflow/issues/events{/number}","events_url":"https://api.github.com/repos/OCA/sale-workflow/events","assignees_url":"https://api.github.com/repos/OCA/sale-workflow/assignees{/user}","branches_url":"https://api.github.com/repos/OCA/sale-workflow/branches{/branch}","tags_url":"https://api.github.com/repos/OCA/sale-workflow/tags","blobs_url":"https://api.github.com/repos/OCA/sale-workflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OCA/sale-workflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OCA/sale-workflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/OCA/sale-workflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OCA/sale-workflow/statuses/{sha}","languages_url":"https://api.github.com/repos/OCA/sale-workflow/languages","stargazers_url":"https://api.github.com/repos/OCA/sale-workflow/stargazers","contributors_url":"https://api.github.com/repos/OCA/sale-workflow/contributors","subscribers_url":"https://api.github.com/repos/OCA/sale-workflow/subscribers","subscription_url":"https://api.github.com/repos/OCA/sale-workflow/subscription","commits_url":"https://api.github.com/repos/OCA/sale-workflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/OCA/sale-workflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/OCA/sale-workflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/OCA/sale-workflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/OCA/sale-workflow/contents/{+path}","compare_url":"https://api.github.com/repos/OCA/sale-workflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OCA/sale-workflow/merges","archive_url":"https://api.github.com/repos/OCA/sale-workflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OCA/sale-workflow/downloads","issues_url":"https://api.github.com/repos/OCA/sale-workflow/issues{/number}","pulls_url":"https://api.github.com/repos/OCA/sale-workflow/pulls{/number}","milestones_url":"https://api.github.com/repos/OCA/sale-workflow/milestones{/number}","notifications_url":"https://api.github.com/repos/OCA/sale-workflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OCA/sale-workflow/labels{/name}","releases_url":"https://api.github.com/repos/OCA/sale-workflow/releases{/id}","created_at":"2014-06-16T11:26:39Z","updated_at":"2015-08-13T14:29:37Z","pushed_at":"2015-09-01T08:47:32Z","git_url":"git://github.com/OCA/sale-workflow.git","ssh_url":"git@github.com:OCA/sale-workflow.git","clone_url":"https://github.com/OCA/sale-workflow.git","svn_url":"https://github.com/OCA/sale-workflow","homepage":"","size":4798,"stargazers_count":18,"watchers_count":18,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":90,"mirror_url":null,"open_issues_count":56,"forks":90,"open_issues":56,"watchers":18,"default_branch":"8.0"}},"_links":{"self":{"href":"https://api.github.com/repos/OCA/sale-workflow/pulls/199"},"html":{"href":"https://github.com/OCA/sale-workflow/pull/199"},"issue":{"href":"https://api.github.com/repos/OCA/sale-workflow/issues/199"},"comments":{"href":"https://api.github.com/repos/OCA/sale-workflow/issues/199/comments"},"review_comments":{"href":"https://api.github.com/repos/OCA/sale-workflow/pulls/199/comments"},"review_comment":{"href":"https://api.github.com/repos/OCA/sale-workflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OCA/sale-workflow/pulls/199/commits"},"statuses":{"href":"https://api.github.com/repos/OCA/sale-workflow/statuses/a5633d706b21ace7f2e80cd2c830cfe37c5e96e2"}}}}