{"action":"created","comment":{"url":"https://api.github.com/repos/artsy/eidolon/pulls/comments/38170067","id":38170067,"diff_hunk":"@@ -17,8 +17,40 @@ public extension String {\n     public func toUIntWithDefault(defaultValue: UInt) -> UInt {\n         return UInt(self) ?? defaultValue\n     }\n+}\n+\n+// Anything that can hold a value (strings, arrays, etc)\n+protocol Occupiable {\n+    var isEmpty: Bool { get }\n+    var isNotEmpty: Bool { get }\n+}\n \n-    public var isNotEmpty: Bool {\n+// Give a default implementation of isNotEmpty, so conformance only requires one implementation\n+extension Occupiable {\n+    var isNotEmpty: Bool {\n         return !isEmpty\n     }\n }\n+\n+extension String: Occupiable { }\n+\n+// I can't think of a way to combine these collection types. Suggestions welcome.\n+extension Array: Occupiable { }\n+extension Dictionary: Occupiable { }\n+extension Set: Occupiable { }","path":"Kiosk/App/SwiftExtensions.swift","position":34,"original_position":34,"commit_id":"6b42761abb6e08ee3ef0227ab89fb4562a2fe021","original_commit_id":"6b42761abb6e08ee3ef0227ab89fb4562a2fe021","user":{"login":"paulyoung","id":84700,"avatar_url":"https://avatars.githubusercontent.com/u/84700?v=3","gravatar_id":"","url":"https://api.github.com/users/paulyoung","html_url":"https://github.com/paulyoung","followers_url":"https://api.github.com/users/paulyoung/followers","following_url":"https://api.github.com/users/paulyoung/following{/other_user}","gists_url":"https://api.github.com/users/paulyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/paulyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulyoung/subscriptions","organizations_url":"https://api.github.com/users/paulyoung/orgs","repos_url":"https://api.github.com/users/paulyoung/repos","events_url":"https://api.github.com/users/paulyoung/events{/privacy}","received_events_url":"https://api.github.com/users/paulyoung/received_events","type":"User","site_admin":false},"body":"Can you extend `CollectionType` instead?","created_at":"2015-08-28T04:17:38Z","updated_at":"2015-08-28T04:17:38Z","html_url":"https://github.com/artsy/eidolon/pull/498#discussion_r38170067","pull_request_url":"https://api.github.com/repos/artsy/eidolon/pulls/498","_links":{"self":{"href":"https://api.github.com/repos/artsy/eidolon/pulls/comments/38170067"},"html":{"href":"https://github.com/artsy/eidolon/pull/498#discussion_r38170067"},"pull_request":{"href":"https://api.github.com/repos/artsy/eidolon/pulls/498"}}},"pull_request":{"url":"https://api.github.com/repos/artsy/eidolon/pulls/498","id":43554494,"html_url":"https://github.com/artsy/eidolon/pull/498","diff_url":"https://github.com/artsy/eidolon/pull/498.diff","patch_url":"https://github.com/artsy/eidolon/pull/498.patch","issue_url":"https://api.github.com/repos/artsy/eidolon/issues/498","number":498,"state":"closed","locked":false,"title":"@orta: Adds Optional isEmpty-ness.","user":{"login":"ashfurrow","id":498212,"avatar_url":"https://avatars.githubusercontent.com/u/498212?v=3","gravatar_id":"","url":"https://api.github.com/users/ashfurrow","html_url":"https://github.com/ashfurrow","followers_url":"https://api.github.com/users/ashfurrow/followers","following_url":"https://api.github.com/users/ashfurrow/following{/other_user}","gists_url":"https://api.github.com/users/ashfurrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ashfurrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashfurrow/subscriptions","organizations_url":"https://api.github.com/users/ashfurrow/orgs","repos_url":"https://api.github.com/users/ashfurrow/repos","events_url":"https://api.github.com/users/ashfurrow/events{/privacy}","received_events_url":"https://api.github.com/users/ashfurrow/received_events","type":"User","site_admin":false},"body":"Also upgraded Kiosk project to Xcode's recommended settings.\r\n\r\nLet me know what you think!","created_at":"2015-08-27T19:07:13Z","updated_at":"2015-08-28T04:17:38Z","closed_at":"2015-08-27T20:32:48Z","merged_at":"2015-08-27T20:32:48Z","merge_commit_sha":"17ef786e4b64511ffbeeb570d301692561b58b06","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/artsy/eidolon/pulls/498/commits","review_comments_url":"https://api.github.com/repos/artsy/eidolon/pulls/498/comments","review_comment_url":"https://api.github.com/repos/artsy/eidolon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/artsy/eidolon/issues/498/comments","statuses_url":"https://api.github.com/repos/artsy/eidolon/statuses/6b42761abb6e08ee3ef0227ab89fb4562a2fe021","head":{"label":"artsy:optionality","ref":"optionality","sha":"6b42761abb6e08ee3ef0227ab89fb4562a2fe021","user":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":22613546,"name":"eidolon","full_name":"artsy/eidolon","owner":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/eidolon","description":"The Artsy Auction Kiosk App","fork":false,"url":"https://api.github.com/repos/artsy/eidolon","forks_url":"https://api.github.com/repos/artsy/eidolon/forks","keys_url":"https://api.github.com/repos/artsy/eidolon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/eidolon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/eidolon/teams","hooks_url":"https://api.github.com/repos/artsy/eidolon/hooks","issue_events_url":"https://api.github.com/repos/artsy/eidolon/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/eidolon/events","assignees_url":"https://api.github.com/repos/artsy/eidolon/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/eidolon/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/eidolon/tags","blobs_url":"https://api.github.com/repos/artsy/eidolon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/eidolon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/eidolon/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/eidolon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/eidolon/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/eidolon/languages","stargazers_url":"https://api.github.com/repos/artsy/eidolon/stargazers","contributors_url":"https://api.github.com/repos/artsy/eidolon/contributors","subscribers_url":"https://api.github.com/repos/artsy/eidolon/subscribers","subscription_url":"https://api.github.com/repos/artsy/eidolon/subscription","commits_url":"https://api.github.com/repos/artsy/eidolon/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/eidolon/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/eidolon/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/eidolon/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/eidolon/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/eidolon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/eidolon/merges","archive_url":"https://api.github.com/repos/artsy/eidolon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/eidolon/downloads","issues_url":"https://api.github.com/repos/artsy/eidolon/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/eidolon/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/eidolon/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/eidolon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/eidolon/labels{/name}","releases_url":"https://api.github.com/repos/artsy/eidolon/releases{/id}","created_at":"2014-08-04T17:38:26Z","updated_at":"2015-08-27T17:28:30Z","pushed_at":"2015-08-27T21:01:44Z","git_url":"git://github.com/artsy/eidolon.git","ssh_url":"git@github.com:artsy/eidolon.git","clone_url":"https://github.com/artsy/eidolon.git","svn_url":"https://github.com/artsy/eidolon","homepage":"http://artsy.github.io/blog/2014/11/13/eidolon-retrospective/","size":65996,"stargazers_count":705,"watchers_count":705,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":38,"forks":52,"open_issues":38,"watchers":705,"default_branch":"master"}},"base":{"label":"artsy:master","ref":"master","sha":"720b6eae23e68d6de7ad6ed7c05d3480c226716f","user":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":22613546,"name":"eidolon","full_name":"artsy/eidolon","owner":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/eidolon","description":"The Artsy Auction Kiosk App","fork":false,"url":"https://api.github.com/repos/artsy/eidolon","forks_url":"https://api.github.com/repos/artsy/eidolon/forks","keys_url":"https://api.github.com/repos/artsy/eidolon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/eidolon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/eidolon/teams","hooks_url":"https://api.github.com/repos/artsy/eidolon/hooks","issue_events_url":"https://api.github.com/repos/artsy/eidolon/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/eidolon/events","assignees_url":"https://api.github.com/repos/artsy/eidolon/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/eidolon/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/eidolon/tags","blobs_url":"https://api.github.com/repos/artsy/eidolon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/eidolon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/eidolon/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/eidolon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/eidolon/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/eidolon/languages","stargazers_url":"https://api.github.com/repos/artsy/eidolon/stargazers","contributors_url":"https://api.github.com/repos/artsy/eidolon/contributors","subscribers_url":"https://api.github.com/repos/artsy/eidolon/subscribers","subscription_url":"https://api.github.com/repos/artsy/eidolon/subscription","commits_url":"https://api.github.com/repos/artsy/eidolon/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/eidolon/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/eidolon/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/eidolon/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/eidolon/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/eidolon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/eidolon/merges","archive_url":"https://api.github.com/repos/artsy/eidolon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/eidolon/downloads","issues_url":"https://api.github.com/repos/artsy/eidolon/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/eidolon/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/eidolon/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/eidolon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/eidolon/labels{/name}","releases_url":"https://api.github.com/repos/artsy/eidolon/releases{/id}","created_at":"2014-08-04T17:38:26Z","updated_at":"2015-08-27T17:28:30Z","pushed_at":"2015-08-27T21:01:44Z","git_url":"git://github.com/artsy/eidolon.git","ssh_url":"git@github.com:artsy/eidolon.git","clone_url":"https://github.com/artsy/eidolon.git","svn_url":"https://github.com/artsy/eidolon","homepage":"http://artsy.github.io/blog/2014/11/13/eidolon-retrospective/","size":65996,"stargazers_count":705,"watchers_count":705,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":38,"forks":52,"open_issues":38,"watchers":705,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/artsy/eidolon/pulls/498"},"html":{"href":"https://github.com/artsy/eidolon/pull/498"},"issue":{"href":"https://api.github.com/repos/artsy/eidolon/issues/498"},"comments":{"href":"https://api.github.com/repos/artsy/eidolon/issues/498/comments"},"review_comments":{"href":"https://api.github.com/repos/artsy/eidolon/pulls/498/comments"},"review_comment":{"href":"https://api.github.com/repos/artsy/eidolon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/artsy/eidolon/pulls/498/commits"},"statuses":{"href":"https://api.github.com/repos/artsy/eidolon/statuses/6b42761abb6e08ee3ef0227ab89fb4562a2fe021"}}}}