{"action":"created","comment":{"url":"https://api.github.com/repos/OmniLayer/omnicore/pulls/comments/38371173","id":38371173,"diff_hunk":"@@ -1085,14 +1085,20 @@ Value omni_sendalert(const Array& params, bool fHelp)\n \n     // obtain parameters & info\n     std::string fromAddress = ParseAddress(params[0]);\n-    int32_t alertType = params[1].get_int();\n-    uint64_t expiryValue = params[2].get_uint64();\n-    uint32_t typeCheck = params[3].get_uint64();\n-    uint32_t verCheck = params[4].get_uint64();\n-    std::string alertMessage = ParseText(params[5]);\n+    int64_t tempAlertType = params[1].get_int64();\n+    if (tempAlertType < 1 || 65535 < tempAlertType) {\n+        throw JSONRPCError(RPC_INVALID_PARAMETER, \"Alert type is out of range\");\n+    }\n+    uint16_t alertType = static_cast<uint16_t>(tempAlertType);\n+    int64_t tempExpiryValue = params[2].get_int64();\n+    if (tempExpiryValue < 1 || 4294967295LL < tempExpiryValue) {","path":"src/omnicore/rpctx.cpp","position":72,"original_position":72,"commit_id":"59db79c2b04fdd5f2ea48a113ff2c67f57429a3a","original_commit_id":"59db79c2b04fdd5f2ea48a113ff2c67f57429a3a","user":{"login":"dexX7","id":5836089,"avatar_url":"https://avatars.githubusercontent.com/u/5836089?v=3","gravatar_id":"","url":"https://api.github.com/users/dexX7","html_url":"https://github.com/dexX7","followers_url":"https://api.github.com/users/dexX7/followers","following_url":"https://api.github.com/users/dexX7/following{/other_user}","gists_url":"https://api.github.com/users/dexX7/gists{/gist_id}","starred_url":"https://api.github.com/users/dexX7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dexX7/subscriptions","organizations_url":"https://api.github.com/users/dexX7/orgs","repos_url":"https://api.github.com/users/dexX7/repos","events_url":"https://api.github.com/users/dexX7/events{/privacy}","received_events_url":"https://api.github.com/users/dexX7/received_events","type":"User","site_admin":false},"body":"With the [current version schema](https://github.com/OmniLayer/omnicore/pull/162/files#diff-da586973b290a2920a045b8ad5ddf4b9R47) we shall never reach 1.0.0.0, hehe. ;)","created_at":"2015-08-31T23:17:48Z","updated_at":"2015-08-31T23:17:48Z","html_url":"https://github.com/OmniLayer/omnicore/pull/176#discussion_r38371173","pull_request_url":"https://api.github.com/repos/OmniLayer/omnicore/pulls/176","_links":{"self":{"href":"https://api.github.com/repos/OmniLayer/omnicore/pulls/comments/38371173"},"html":{"href":"https://github.com/OmniLayer/omnicore/pull/176#discussion_r38371173"},"pull_request":{"href":"https://api.github.com/repos/OmniLayer/omnicore/pulls/176"}}},"pull_request":{"url":"https://api.github.com/repos/OmniLayer/omnicore/pulls/176","id":42431231,"html_url":"https://github.com/OmniLayer/omnicore/pull/176","diff_url":"https://github.com/OmniLayer/omnicore/pull/176.diff","patch_url":"https://github.com/OmniLayer/omnicore/pull/176.patch","issue_url":"https://api.github.com/repos/OmniLayer/omnicore/issues/176","number":176,"state":"open","locked":false,"title":"Implement updated alerting & feature activations","user":{"login":"zathras-crypto","id":5633351,"avatar_url":"https://avatars.githubusercontent.com/u/5633351?v=3","gravatar_id":"","url":"https://api.github.com/users/zathras-crypto","html_url":"https://github.com/zathras-crypto","followers_url":"https://api.github.com/users/zathras-crypto/followers","following_url":"https://api.github.com/users/zathras-crypto/following{/other_user}","gists_url":"https://api.github.com/users/zathras-crypto/gists{/gist_id}","starred_url":"https://api.github.com/users/zathras-crypto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zathras-crypto/subscriptions","organizations_url":"https://api.github.com/users/zathras-crypto/orgs","repos_url":"https://api.github.com/users/zathras-crypto/repos","events_url":"https://api.github.com/users/zathras-crypto/events{/privacy}","received_events_url":"https://api.github.com/users/zathras-crypto/received_events","type":"User","site_admin":false},"body":"This PR serves to add support for multiple alerts with a new structure and integrated feature activations.\r\n\r\nWork from #169 and #175 continues here.  WIP, not ready for merge.","created_at":"2015-08-14T07:42:08Z","updated_at":"2015-08-31T23:17:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a77793489137e61c0d45dc2c6d895dae9f50bad","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OmniLayer/omnicore/pulls/176/commits","review_comments_url":"https://api.github.com/repos/OmniLayer/omnicore/pulls/176/comments","review_comment_url":"https://api.github.com/repos/OmniLayer/omnicore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OmniLayer/omnicore/issues/176/comments","statuses_url":"https://api.github.com/repos/OmniLayer/omnicore/statuses/59db79c2b04fdd5f2ea48a113ff2c67f57429a3a","head":{"label":"zathras-crypto:0.0.10-Z-RevisedAlertsWithFeatureActivation","ref":"0.0.10-Z-RevisedAlertsWithFeatureActivation","sha":"59db79c2b04fdd5f2ea48a113ff2c67f57429a3a","user":{"login":"zathras-crypto","id":5633351,"avatar_url":"https://avatars.githubusercontent.com/u/5633351?v=3","gravatar_id":"","url":"https://api.github.com/users/zathras-crypto","html_url":"https://github.com/zathras-crypto","followers_url":"https://api.github.com/users/zathras-crypto/followers","following_url":"https://api.github.com/users/zathras-crypto/following{/other_user}","gists_url":"https://api.github.com/users/zathras-crypto/gists{/gist_id}","starred_url":"https://api.github.com/users/zathras-crypto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zathras-crypto/subscriptions","organizations_url":"https://api.github.com/users/zathras-crypto/orgs","repos_url":"https://api.github.com/users/zathras-crypto/repos","events_url":"https://api.github.com/users/zathras-crypto/events{/privacy}","received_events_url":"https://api.github.com/users/zathras-crypto/received_events","type":"User","site_admin":false},"repo":{"id":19960841,"name":"omnicore","full_name":"zathras-crypto/omnicore","owner":{"login":"zathras-crypto","id":5633351,"avatar_url":"https://avatars.githubusercontent.com/u/5633351?v=3","gravatar_id":"","url":"https://api.github.com/users/zathras-crypto","html_url":"https://github.com/zathras-crypto","followers_url":"https://api.github.com/users/zathras-crypto/followers","following_url":"https://api.github.com/users/zathras-crypto/following{/other_user}","gists_url":"https://api.github.com/users/zathras-crypto/gists{/gist_id}","starred_url":"https://api.github.com/users/zathras-crypto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zathras-crypto/subscriptions","organizations_url":"https://api.github.com/users/zathras-crypto/orgs","repos_url":"https://api.github.com/users/zathras-crypto/repos","events_url":"https://api.github.com/users/zathras-crypto/events{/privacy}","received_events_url":"https://api.github.com/users/zathras-crypto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zathras-crypto/omnicore","description":"mastercore info","fork":true,"url":"https://api.github.com/repos/zathras-crypto/omnicore","forks_url":"https://api.github.com/repos/zathras-crypto/omnicore/forks","keys_url":"https://api.github.com/repos/zathras-crypto/omnicore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zathras-crypto/omnicore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zathras-crypto/omnicore/teams","hooks_url":"https://api.github.com/repos/zathras-crypto/omnicore/hooks","issue_events_url":"https://api.github.com/repos/zathras-crypto/omnicore/issues/events{/number}","events_url":"https://api.github.com/repos/zathras-crypto/omnicore/events","assignees_url":"https://api.github.com/repos/zathras-crypto/omnicore/assignees{/user}","branches_url":"https://api.github.com/repos/zathras-crypto/omnicore/branches{/branch}","tags_url":"https://api.github.com/repos/zathras-crypto/omnicore/tags","blobs_url":"https://api.github.com/repos/zathras-crypto/omnicore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zathras-crypto/omnicore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zathras-crypto/omnicore/git/refs{/sha}","trees_url":"https://api.github.com/repos/zathras-crypto/omnicore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zathras-crypto/omnicore/statuses/{sha}","languages_url":"https://api.github.com/repos/zathras-crypto/omnicore/languages","stargazers_url":"https://api.github.com/repos/zathras-crypto/omnicore/stargazers","contributors_url":"https://api.github.com/repos/zathras-crypto/omnicore/contributors","subscribers_url":"https://api.github.com/repos/zathras-crypto/omnicore/subscribers","subscription_url":"https://api.github.com/repos/zathras-crypto/omnicore/subscription","commits_url":"https://api.github.com/repos/zathras-crypto/omnicore/commits{/sha}","git_commits_url":"https://api.github.com/repos/zathras-crypto/omnicore/git/commits{/sha}","comments_url":"https://api.github.com/repos/zathras-crypto/omnicore/comments{/number}","issue_comment_url":"https://api.github.com/repos/zathras-crypto/omnicore/issues/comments{/number}","contents_url":"https://api.github.com/repos/zathras-crypto/omnicore/contents/{+path}","compare_url":"https://api.github.com/repos/zathras-crypto/omnicore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zathras-crypto/omnicore/merges","archive_url":"https://api.github.com/repos/zathras-crypto/omnicore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zathras-crypto/omnicore/downloads","issues_url":"https://api.github.com/repos/zathras-crypto/omnicore/issues{/number}","pulls_url":"https://api.github.com/repos/zathras-crypto/omnicore/pulls{/number}","milestones_url":"https://api.github.com/repos/zathras-crypto/omnicore/milestones{/number}","notifications_url":"https://api.github.com/repos/zathras-crypto/omnicore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zathras-crypto/omnicore/labels{/name}","releases_url":"https://api.github.com/repos/zathras-crypto/omnicore/releases{/id}","created_at":"2014-05-19T23:15:09Z","updated_at":"2015-05-18T06:43:01Z","pushed_at":"2015-08-31T22:27:26Z","git_url":"git://github.com/zathras-crypto/omnicore.git","ssh_url":"git@github.com:zathras-crypto/omnicore.git","clone_url":"https://github.com/zathras-crypto/omnicore.git","svn_url":"https://github.com/zathras-crypto/omnicore","homepage":"mastercoin.org","size":55539,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":1,"default_branch":"0.0.8-Z-UIAlpha"}},"base":{"label":"OmniLayer:omnicore-0.0.10","ref":"omnicore-0.0.10","sha":"a952cd62d4649309cd1c429cee64a4acbc3da2dc","user":{"login":"OmniLayer","id":10849356,"avatar_url":"https://avatars.githubusercontent.com/u/10849356?v=3","gravatar_id":"","url":"https://api.github.com/users/OmniLayer","html_url":"https://github.com/OmniLayer","followers_url":"https://api.github.com/users/OmniLayer/followers","following_url":"https://api.github.com/users/OmniLayer/following{/other_user}","gists_url":"https://api.github.com/users/OmniLayer/gists{/gist_id}","starred_url":"https://api.github.com/users/OmniLayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OmniLayer/subscriptions","organizations_url":"https://api.github.com/users/OmniLayer/orgs","repos_url":"https://api.github.com/users/OmniLayer/repos","events_url":"https://api.github.com/users/OmniLayer/events{/privacy}","received_events_url":"https://api.github.com/users/OmniLayer/received_events","type":"Organization","site_admin":false},"repo":{"id":32829630,"name":"omnicore","full_name":"OmniLayer/omnicore","owner":{"login":"OmniLayer","id":10849356,"avatar_url":"https://avatars.githubusercontent.com/u/10849356?v=3","gravatar_id":"","url":"https://api.github.com/users/OmniLayer","html_url":"https://github.com/OmniLayer","followers_url":"https://api.github.com/users/OmniLayer/followers","following_url":"https://api.github.com/users/OmniLayer/following{/other_user}","gists_url":"https://api.github.com/users/OmniLayer/gists{/gist_id}","starred_url":"https://api.github.com/users/OmniLayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OmniLayer/subscriptions","organizations_url":"https://api.github.com/users/OmniLayer/orgs","repos_url":"https://api.github.com/users/OmniLayer/repos","events_url":"https://api.github.com/users/OmniLayer/events{/privacy}","received_events_url":"https://api.github.com/users/OmniLayer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OmniLayer/omnicore","description":"OmniCore staging tree","fork":true,"url":"https://api.github.com/repos/OmniLayer/omnicore","forks_url":"https://api.github.com/repos/OmniLayer/omnicore/forks","keys_url":"https://api.github.com/repos/OmniLayer/omnicore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OmniLayer/omnicore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OmniLayer/omnicore/teams","hooks_url":"https://api.github.com/repos/OmniLayer/omnicore/hooks","issue_events_url":"https://api.github.com/repos/OmniLayer/omnicore/issues/events{/number}","events_url":"https://api.github.com/repos/OmniLayer/omnicore/events","assignees_url":"https://api.github.com/repos/OmniLayer/omnicore/assignees{/user}","branches_url":"https://api.github.com/repos/OmniLayer/omnicore/branches{/branch}","tags_url":"https://api.github.com/repos/OmniLayer/omnicore/tags","blobs_url":"https://api.github.com/repos/OmniLayer/omnicore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OmniLayer/omnicore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OmniLayer/omnicore/git/refs{/sha}","trees_url":"https://api.github.com/repos/OmniLayer/omnicore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OmniLayer/omnicore/statuses/{sha}","languages_url":"https://api.github.com/repos/OmniLayer/omnicore/languages","stargazers_url":"https://api.github.com/repos/OmniLayer/omnicore/stargazers","contributors_url":"https://api.github.com/repos/OmniLayer/omnicore/contributors","subscribers_url":"https://api.github.com/repos/OmniLayer/omnicore/subscribers","subscription_url":"https://api.github.com/repos/OmniLayer/omnicore/subscription","commits_url":"https://api.github.com/repos/OmniLayer/omnicore/commits{/sha}","git_commits_url":"https://api.github.com/repos/OmniLayer/omnicore/git/commits{/sha}","comments_url":"https://api.github.com/repos/OmniLayer/omnicore/comments{/number}","issue_comment_url":"https://api.github.com/repos/OmniLayer/omnicore/issues/comments{/number}","contents_url":"https://api.github.com/repos/OmniLayer/omnicore/contents/{+path}","compare_url":"https://api.github.com/repos/OmniLayer/omnicore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OmniLayer/omnicore/merges","archive_url":"https://api.github.com/repos/OmniLayer/omnicore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OmniLayer/omnicore/downloads","issues_url":"https://api.github.com/repos/OmniLayer/omnicore/issues{/number}","pulls_url":"https://api.github.com/repos/OmniLayer/omnicore/pulls{/number}","milestones_url":"https://api.github.com/repos/OmniLayer/omnicore/milestones{/number}","notifications_url":"https://api.github.com/repos/OmniLayer/omnicore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OmniLayer/omnicore/labels{/name}","releases_url":"https://api.github.com/repos/OmniLayer/omnicore/releases{/id}","created_at":"2015-03-24T22:48:50Z","updated_at":"2015-08-20T00:50:46Z","pushed_at":"2015-08-31T22:49:55Z","git_url":"git://github.com/OmniLayer/omnicore.git","ssh_url":"git@github.com:OmniLayer/omnicore.git","clone_url":"https://github.com/OmniLayer/omnicore.git","svn_url":"https://github.com/OmniLayer/omnicore","homepage":"http://www.omnilayer.org/","size":46182,"stargazers_count":9,"watchers_count":9,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":44,"forks":0,"open_issues":44,"watchers":9,"default_branch":"omnicore-0.0.10"}},"_links":{"self":{"href":"https://api.github.com/repos/OmniLayer/omnicore/pulls/176"},"html":{"href":"https://github.com/OmniLayer/omnicore/pull/176"},"issue":{"href":"https://api.github.com/repos/OmniLayer/omnicore/issues/176"},"comments":{"href":"https://api.github.com/repos/OmniLayer/omnicore/issues/176/comments"},"review_comments":{"href":"https://api.github.com/repos/OmniLayer/omnicore/pulls/176/comments"},"review_comment":{"href":"https://api.github.com/repos/OmniLayer/omnicore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OmniLayer/omnicore/pulls/176/commits"},"statuses":{"href":"https://api.github.com/repos/OmniLayer/omnicore/statuses/59db79c2b04fdd5f2ea48a113ff2c67f57429a3a"}}}}