{"action":"created","comment":{"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments/30788159","id":30788159,"diff_hunk":"@@ -10,6 +10,12 @@ sub run() {\n         return;\n     }\n \n+    # Wait for desktop to load after booting from an installed disk image\n+    if ( check_var( \"BOOT_HDD_IMAGE\", 1 ) ) {\n+        assert_screen \"generic-desktop\", 120;\n+        return;","path":"tests/installation/first_boot.pm","position":7,"original_position":7,"commit_id":"c0cbf7a0c2a7ddc087b0f5e224c14b10aa29fb67","original_commit_id":"c0cbf7a0c2a7ddc087b0f5e224c14b10aa29fb67","user":{"login":"coolo","id":1067203,"avatar_url":"https://avatars.githubusercontent.com/u/1067203?v=3","gravatar_id":"","url":"https://api.github.com/users/coolo","html_url":"https://github.com/coolo","followers_url":"https://api.github.com/users/coolo/followers","following_url":"https://api.github.com/users/coolo/following{/other_user}","gists_url":"https://api.github.com/users/coolo/gists{/gist_id}","starred_url":"https://api.github.com/users/coolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coolo/subscriptions","organizations_url":"https://api.github.com/users/coolo/orgs","repos_url":"https://api.github.com/users/coolo/repos","events_url":"https://api.github.com/users/coolo/events{/privacy}","received_events_url":"https://api.github.com/users/coolo/received_events","type":"User","site_admin":false},"body":"hmm, that's broken. the 2nd argument is the default argument - so we would always go into that assert_screen even if not booting. Just get_var(\"BOOT_HDD_IMAGE\") is what you want...\r\n\r\n*But* I don't think this works this way. Because generic-desktop is not where you want to end your HDD_IMAGE is a text installation. \r\n\r\nI guess we need to come up with a formal way to express in the name of the HDD_IMAGES what to expect. But that sounds ugly too\r\n","created_at":"2015-05-21T10:00:45Z","updated_at":"2015-05-21T10:00:45Z","html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/451#discussion_r30788159","pull_request_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/451","_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments/30788159"},"html":{"href":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/451#discussion_r30788159"},"pull_request":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/451"}}},"pull_request":{"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/451","id":35915700,"html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/451","diff_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/451.diff","patch_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/451.patch","issue_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/451","number":451,"state":"open","locked":false,"title":"Use install-kde-image artefact HDD image to boot into KDE desktop, and switch to console and run sysauth tests","user":{"login":"HouzuoGuo","id":563872,"avatar_url":"https://avatars.githubusercontent.com/u/563872?v=3","gravatar_id":"","url":"https://api.github.com/users/HouzuoGuo","html_url":"https://github.com/HouzuoGuo","followers_url":"https://api.github.com/users/HouzuoGuo/followers","following_url":"https://api.github.com/users/HouzuoGuo/following{/other_user}","gists_url":"https://api.github.com/users/HouzuoGuo/gists{/gist_id}","starred_url":"https://api.github.com/users/HouzuoGuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HouzuoGuo/subscriptions","organizations_url":"https://api.github.com/users/HouzuoGuo/orgs","repos_url":"https://api.github.com/users/HouzuoGuo/repos","events_url":"https://api.github.com/users/HouzuoGuo/events{/privacy}","received_events_url":"https://api.github.com/users/HouzuoGuo/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-05-21T09:35:22Z","updated_at":"2015-05-21T10:00:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b8c0c015b1d7767f3382fff3ec7924482d13fc0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/451/commits","review_comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/451/comments","review_comment_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/451/comments","statuses_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/c0cbf7a0c2a7ddc087b0f5e224c14b10aa29fb67","head":{"label":"HouzuoGuo:master","ref":"master","sha":"c0cbf7a0c2a7ddc087b0f5e224c14b10aa29fb67","user":{"login":"HouzuoGuo","id":563872,"avatar_url":"https://avatars.githubusercontent.com/u/563872?v=3","gravatar_id":"","url":"https://api.github.com/users/HouzuoGuo","html_url":"https://github.com/HouzuoGuo","followers_url":"https://api.github.com/users/HouzuoGuo/followers","following_url":"https://api.github.com/users/HouzuoGuo/following{/other_user}","gists_url":"https://api.github.com/users/HouzuoGuo/gists{/gist_id}","starred_url":"https://api.github.com/users/HouzuoGuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HouzuoGuo/subscriptions","organizations_url":"https://api.github.com/users/HouzuoGuo/orgs","repos_url":"https://api.github.com/users/HouzuoGuo/repos","events_url":"https://api.github.com/users/HouzuoGuo/events{/privacy}","received_events_url":"https://api.github.com/users/HouzuoGuo/received_events","type":"User","site_admin":false},"repo":{"id":35998901,"name":"os-autoinst-distri-opensuse","full_name":"HouzuoGuo/os-autoinst-distri-opensuse","owner":{"login":"HouzuoGuo","id":563872,"avatar_url":"https://avatars.githubusercontent.com/u/563872?v=3","gravatar_id":"","url":"https://api.github.com/users/HouzuoGuo","html_url":"https://github.com/HouzuoGuo","followers_url":"https://api.github.com/users/HouzuoGuo/followers","following_url":"https://api.github.com/users/HouzuoGuo/following{/other_user}","gists_url":"https://api.github.com/users/HouzuoGuo/gists{/gist_id}","starred_url":"https://api.github.com/users/HouzuoGuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HouzuoGuo/subscriptions","organizations_url":"https://api.github.com/users/HouzuoGuo/orgs","repos_url":"https://api.github.com/users/HouzuoGuo/repos","events_url":"https://api.github.com/users/HouzuoGuo/events{/privacy}","received_events_url":"https://api.github.com/users/HouzuoGuo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HouzuoGuo/os-autoinst-distri-opensuse","description":"os-autoinst test cases for openSUSE","fork":true,"url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse","forks_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/forks","keys_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/teams","hooks_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/hooks","issue_events_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/issues/events{/number}","events_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/events","assignees_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/assignees{/user}","branches_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/branches{/branch}","tags_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/tags","blobs_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/git/refs{/sha}","trees_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/statuses/{sha}","languages_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/languages","stargazers_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/stargazers","contributors_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/contributors","subscribers_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/subscribers","subscription_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/subscription","commits_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/commits{/sha}","git_commits_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/git/commits{/sha}","comments_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/comments{/number}","issue_comment_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/issues/comments{/number}","contents_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/contents/{+path}","compare_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/merges","archive_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/downloads","issues_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/issues{/number}","pulls_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/pulls{/number}","milestones_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/milestones{/number}","notifications_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/labels{/name}","releases_url":"https://api.github.com/repos/HouzuoGuo/os-autoinst-distri-opensuse/releases{/id}","created_at":"2015-05-21T07:49:36Z","updated_at":"2015-05-21T07:49:37Z","pushed_at":"2015-05-21T09:16:45Z","git_url":"git://github.com/HouzuoGuo/os-autoinst-distri-opensuse.git","ssh_url":"git@github.com:HouzuoGuo/os-autoinst-distri-opensuse.git","clone_url":"https://github.com/HouzuoGuo/os-autoinst-distri-opensuse.git","svn_url":"https://github.com/HouzuoGuo/os-autoinst-distri-opensuse","homepage":null,"size":6183,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"os-autoinst:master","ref":"master","sha":"1e2c0d4df342e96811828f64a4a5f42b02cfb0f0","user":{"login":"os-autoinst","id":6918706,"avatar_url":"https://avatars.githubusercontent.com/u/6918706?v=3","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"repo":{"id":17630288,"name":"os-autoinst-distri-opensuse","full_name":"os-autoinst/os-autoinst-distri-opensuse","owner":{"login":"os-autoinst","id":6918706,"avatar_url":"https://avatars.githubusercontent.com/u/6918706?v=3","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse","description":"os-autoinst test cases for openSUSE","fork":false,"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse","forks_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/forks","keys_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/teams","hooks_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/hooks","issue_events_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/events{/number}","events_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/events","assignees_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/assignees{/user}","branches_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/branches{/branch}","tags_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/tags","blobs_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/refs{/sha}","trees_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/{sha}","languages_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/languages","stargazers_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/stargazers","contributors_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/contributors","subscribers_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/subscribers","subscription_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/subscription","commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/commits{/sha}","git_commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/commits{/sha}","comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/comments{/number}","issue_comment_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/comments{/number}","contents_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/contents/{+path}","compare_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/merges","archive_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/downloads","issues_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues{/number}","pulls_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls{/number}","milestones_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/milestones{/number}","notifications_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/labels{/name}","releases_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/releases{/id}","created_at":"2014-03-11T12:54:42Z","updated_at":"2015-05-08T14:52:21Z","pushed_at":"2015-05-21T09:35:23Z","git_url":"git://github.com/os-autoinst/os-autoinst-distri-opensuse.git","ssh_url":"git@github.com:os-autoinst/os-autoinst-distri-opensuse.git","clone_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse.git","svn_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse","homepage":null,"size":6183,"stargazers_count":3,"watchers_count":3,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":5,"forks":21,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/451"},"html":{"href":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/451"},"issue":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/451"},"comments":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/451/comments"},"review_comments":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/451/comments"},"review_comment":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/451/commits"},"statuses":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/c0cbf7a0c2a7ddc087b0f5e224c14b10aa29fb67"}}}}