{"action":"created","comment":{"url":"https://api.github.com/repos/boto/botocore/pulls/comments/43028643","id":43028643,"diff_hunk":"@@ -273,7 +273,7 @@ def test_generate_presigned_post(self):\n         self.auth.assert_called_with(\n             credentials=self.credentials, region_name='region_name',\n             service_name='signing_name')\n-        self.add_auth.assert_called_once()\n+        self.add_auth.call_count == 1","path":"tests/unit/test_signers.py","position":5,"original_position":5,"commit_id":"75708a7b042d2bcc63db477eda4cad15c089064c","original_commit_id":"75708a7b042d2bcc63db477eda4cad15c089064c","user":{"login":"mtdowling","id":190930,"avatar_url":"https://avatars.githubusercontent.com/u/190930?v=3","gravatar_id":"","url":"https://api.github.com/users/mtdowling","html_url":"https://github.com/mtdowling","followers_url":"https://api.github.com/users/mtdowling/followers","following_url":"https://api.github.com/users/mtdowling/following{/other_user}","gists_url":"https://api.github.com/users/mtdowling/gists{/gist_id}","starred_url":"https://api.github.com/users/mtdowling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtdowling/subscriptions","organizations_url":"https://api.github.com/users/mtdowling/orgs","repos_url":"https://api.github.com/users/mtdowling/repos","events_url":"https://api.github.com/users/mtdowling/events{/privacy}","received_events_url":"https://api.github.com/users/mtdowling/received_events","type":"User","site_admin":false},"body":"Are these changes necessary for this pull request, or are they accidentally included due to the related PR? Can you please remove these changes if they are not necessary.","created_at":"2015-10-26T17:55:16Z","updated_at":"2015-10-26T17:55:16Z","html_url":"https://github.com/boto/botocore/pull/701#discussion_r43028643","pull_request_url":"https://api.github.com/repos/boto/botocore/pulls/701","_links":{"self":{"href":"https://api.github.com/repos/boto/botocore/pulls/comments/43028643"},"html":{"href":"https://github.com/boto/botocore/pull/701#discussion_r43028643"},"pull_request":{"href":"https://api.github.com/repos/boto/botocore/pulls/701"}}},"pull_request":{"url":"https://api.github.com/repos/boto/botocore/pulls/701","id":48657001,"html_url":"https://github.com/boto/botocore/pull/701","diff_url":"https://github.com/boto/botocore/pull/701.diff","patch_url":"https://github.com/boto/botocore/pull/701.patch","issue_url":"https://api.github.com/repos/boto/botocore/issues/701","number":701,"state":"open","locked":false,"title":"Unify tox/travis tests","user":{"login":"catlee","id":54458,"avatar_url":"https://avatars.githubusercontent.com/u/54458?v=3","gravatar_id":"","url":"https://api.github.com/users/catlee","html_url":"https://github.com/catlee","followers_url":"https://api.github.com/users/catlee/followers","following_url":"https://api.github.com/users/catlee/following{/other_user}","gists_url":"https://api.github.com/users/catlee/gists{/gist_id}","starred_url":"https://api.github.com/users/catlee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catlee/subscriptions","organizations_url":"https://api.github.com/users/catlee/orgs","repos_url":"https://api.github.com/users/catlee/repos","events_url":"https://api.github.com/users/catlee/events{/privacy}","received_events_url":"https://api.github.com/users/catlee/received_events","type":"User","site_admin":false},"body":"I was having some problems running tests locally that weren't evident on travis, e.g.\r\n\r\n```\r\n======================================================================\r\nERROR: test_generate_presigned_post (tests.unit.test_signers.TestS3PostPresigner)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/home/catlee/src/botocore/tests/unit/test_signers.py\", line 276, in test_generate_presi\r\ngned_post\r\n    self.add_auth.assert_called_once()\r\n  File \"/home/catlee/src/botocore/.tox/py27/local/lib/python2.7/site-packages/mock/mock.py\", li\r\nne 721, in __getattr__\r\n    raise AttributeError(name)\r\nAttributeError: assert_called_once\r\n```\r\n\r\nThe problem turned out to be due to travis using code scripts/ci/ to execute tests, while tox.ini was used locally.\r\n\r\nI've updated .travis.yml to use tox to reproduce the same behavior as the old scripts (I hope!)\r\n\r\nI also cleaned up some package requirements,  fixed usage of a non-existent mock assertion.\r\n\r\nFinally, I adjusted the signing tests to stop trying to contact the special AWS metadata url to get credentials. This sped up tests locally from 24s to 13s, since we don't need to wait 1s per test.\r\n\r\nAny feedback on this would be appreciated! I'm not sure if code coverage still works, and I've removed the integration test script which didn't seem to be used. The same tests are still runnable via tox if you pass the explicit environment name.","created_at":"2015-10-24T14:23:51Z","updated_at":"2015-10-26T17:55:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3a49d5fb6c7e8f281e40005e7d827b5c4af8ebc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/boto/botocore/pulls/701/commits","review_comments_url":"https://api.github.com/repos/boto/botocore/pulls/701/comments","review_comment_url":"https://api.github.com/repos/boto/botocore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/boto/botocore/issues/701/comments","statuses_url":"https://api.github.com/repos/boto/botocore/statuses/75708a7b042d2bcc63db477eda4cad15c089064c","head":{"label":"catlee:fix_tests","ref":"fix_tests","sha":"75708a7b042d2bcc63db477eda4cad15c089064c","user":{"login":"catlee","id":54458,"avatar_url":"https://avatars.githubusercontent.com/u/54458?v=3","gravatar_id":"","url":"https://api.github.com/users/catlee","html_url":"https://github.com/catlee","followers_url":"https://api.github.com/users/catlee/followers","following_url":"https://api.github.com/users/catlee/following{/other_user}","gists_url":"https://api.github.com/users/catlee/gists{/gist_id}","starred_url":"https://api.github.com/users/catlee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catlee/subscriptions","organizations_url":"https://api.github.com/users/catlee/orgs","repos_url":"https://api.github.com/users/catlee/repos","events_url":"https://api.github.com/users/catlee/events{/privacy}","received_events_url":"https://api.github.com/users/catlee/received_events","type":"User","site_admin":false},"repo":{"id":44840657,"name":"botocore","full_name":"catlee/botocore","owner":{"login":"catlee","id":54458,"avatar_url":"https://avatars.githubusercontent.com/u/54458?v=3","gravatar_id":"","url":"https://api.github.com/users/catlee","html_url":"https://github.com/catlee","followers_url":"https://api.github.com/users/catlee/followers","following_url":"https://api.github.com/users/catlee/following{/other_user}","gists_url":"https://api.github.com/users/catlee/gists{/gist_id}","starred_url":"https://api.github.com/users/catlee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catlee/subscriptions","organizations_url":"https://api.github.com/users/catlee/orgs","repos_url":"https://api.github.com/users/catlee/repos","events_url":"https://api.github.com/users/catlee/events{/privacy}","received_events_url":"https://api.github.com/users/catlee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/catlee/botocore","description":"The low-level, core functionality of boto 3.","fork":true,"url":"https://api.github.com/repos/catlee/botocore","forks_url":"https://api.github.com/repos/catlee/botocore/forks","keys_url":"https://api.github.com/repos/catlee/botocore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/catlee/botocore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/catlee/botocore/teams","hooks_url":"https://api.github.com/repos/catlee/botocore/hooks","issue_events_url":"https://api.github.com/repos/catlee/botocore/issues/events{/number}","events_url":"https://api.github.com/repos/catlee/botocore/events","assignees_url":"https://api.github.com/repos/catlee/botocore/assignees{/user}","branches_url":"https://api.github.com/repos/catlee/botocore/branches{/branch}","tags_url":"https://api.github.com/repos/catlee/botocore/tags","blobs_url":"https://api.github.com/repos/catlee/botocore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/catlee/botocore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/catlee/botocore/git/refs{/sha}","trees_url":"https://api.github.com/repos/catlee/botocore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/catlee/botocore/statuses/{sha}","languages_url":"https://api.github.com/repos/catlee/botocore/languages","stargazers_url":"https://api.github.com/repos/catlee/botocore/stargazers","contributors_url":"https://api.github.com/repos/catlee/botocore/contributors","subscribers_url":"https://api.github.com/repos/catlee/botocore/subscribers","subscription_url":"https://api.github.com/repos/catlee/botocore/subscription","commits_url":"https://api.github.com/repos/catlee/botocore/commits{/sha}","git_commits_url":"https://api.github.com/repos/catlee/botocore/git/commits{/sha}","comments_url":"https://api.github.com/repos/catlee/botocore/comments{/number}","issue_comment_url":"https://api.github.com/repos/catlee/botocore/issues/comments{/number}","contents_url":"https://api.github.com/repos/catlee/botocore/contents/{+path}","compare_url":"https://api.github.com/repos/catlee/botocore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/catlee/botocore/merges","archive_url":"https://api.github.com/repos/catlee/botocore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/catlee/botocore/downloads","issues_url":"https://api.github.com/repos/catlee/botocore/issues{/number}","pulls_url":"https://api.github.com/repos/catlee/botocore/pulls{/number}","milestones_url":"https://api.github.com/repos/catlee/botocore/milestones{/number}","notifications_url":"https://api.github.com/repos/catlee/botocore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/catlee/botocore/labels{/name}","releases_url":"https://api.github.com/repos/catlee/botocore/releases{/id}","created_at":"2015-10-23T21:56:19Z","updated_at":"2015-10-23T21:56:24Z","pushed_at":"2015-10-24T14:22:13Z","git_url":"git://github.com/catlee/botocore.git","ssh_url":"git@github.com:catlee/botocore.git","clone_url":"https://github.com/catlee/botocore.git","svn_url":"https://github.com/catlee/botocore","homepage":null,"size":25301,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"boto:develop","ref":"develop","sha":"31aa956770646f2db264ba3a9bb2e0aeee31601b","user":{"login":"boto","id":327752,"avatar_url":"https://avatars.githubusercontent.com/u/327752?v=3","gravatar_id":"","url":"https://api.github.com/users/boto","html_url":"https://github.com/boto","followers_url":"https://api.github.com/users/boto/followers","following_url":"https://api.github.com/users/boto/following{/other_user}","gists_url":"https://api.github.com/users/boto/gists{/gist_id}","starred_url":"https://api.github.com/users/boto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boto/subscriptions","organizations_url":"https://api.github.com/users/boto/orgs","repos_url":"https://api.github.com/users/boto/repos","events_url":"https://api.github.com/users/boto/events{/privacy}","received_events_url":"https://api.github.com/users/boto/received_events","type":"Organization","site_admin":false},"repo":{"id":6670942,"name":"botocore","full_name":"boto/botocore","owner":{"login":"boto","id":327752,"avatar_url":"https://avatars.githubusercontent.com/u/327752?v=3","gravatar_id":"","url":"https://api.github.com/users/boto","html_url":"https://github.com/boto","followers_url":"https://api.github.com/users/boto/followers","following_url":"https://api.github.com/users/boto/following{/other_user}","gists_url":"https://api.github.com/users/boto/gists{/gist_id}","starred_url":"https://api.github.com/users/boto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boto/subscriptions","organizations_url":"https://api.github.com/users/boto/orgs","repos_url":"https://api.github.com/users/boto/repos","events_url":"https://api.github.com/users/boto/events{/privacy}","received_events_url":"https://api.github.com/users/boto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/boto/botocore","description":"The low-level, core functionality of boto 3.","fork":false,"url":"https://api.github.com/repos/boto/botocore","forks_url":"https://api.github.com/repos/boto/botocore/forks","keys_url":"https://api.github.com/repos/boto/botocore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boto/botocore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boto/botocore/teams","hooks_url":"https://api.github.com/repos/boto/botocore/hooks","issue_events_url":"https://api.github.com/repos/boto/botocore/issues/events{/number}","events_url":"https://api.github.com/repos/boto/botocore/events","assignees_url":"https://api.github.com/repos/boto/botocore/assignees{/user}","branches_url":"https://api.github.com/repos/boto/botocore/branches{/branch}","tags_url":"https://api.github.com/repos/boto/botocore/tags","blobs_url":"https://api.github.com/repos/boto/botocore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boto/botocore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boto/botocore/git/refs{/sha}","trees_url":"https://api.github.com/repos/boto/botocore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boto/botocore/statuses/{sha}","languages_url":"https://api.github.com/repos/boto/botocore/languages","stargazers_url":"https://api.github.com/repos/boto/botocore/stargazers","contributors_url":"https://api.github.com/repos/boto/botocore/contributors","subscribers_url":"https://api.github.com/repos/boto/botocore/subscribers","subscription_url":"https://api.github.com/repos/boto/botocore/subscription","commits_url":"https://api.github.com/repos/boto/botocore/commits{/sha}","git_commits_url":"https://api.github.com/repos/boto/botocore/git/commits{/sha}","comments_url":"https://api.github.com/repos/boto/botocore/comments{/number}","issue_comment_url":"https://api.github.com/repos/boto/botocore/issues/comments{/number}","contents_url":"https://api.github.com/repos/boto/botocore/contents/{+path}","compare_url":"https://api.github.com/repos/boto/botocore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boto/botocore/merges","archive_url":"https://api.github.com/repos/boto/botocore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boto/botocore/downloads","issues_url":"https://api.github.com/repos/boto/botocore/issues{/number}","pulls_url":"https://api.github.com/repos/boto/botocore/pulls{/number}","milestones_url":"https://api.github.com/repos/boto/botocore/milestones{/number}","notifications_url":"https://api.github.com/repos/boto/botocore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boto/botocore/labels{/name}","releases_url":"https://api.github.com/repos/boto/botocore/releases{/id}","created_at":"2012-11-13T13:25:36Z","updated_at":"2015-10-24T20:22:38Z","pushed_at":"2015-10-26T17:13:59Z","git_url":"git://github.com/boto/botocore.git","ssh_url":"git@github.com:boto/botocore.git","clone_url":"https://github.com/boto/botocore.git","svn_url":"https://github.com/boto/botocore","homepage":null,"size":25301,"stargazers_count":200,"watchers_count":200,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":116,"mirror_url":null,"open_issues_count":24,"forks":116,"open_issues":24,"watchers":200,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/boto/botocore/pulls/701"},"html":{"href":"https://github.com/boto/botocore/pull/701"},"issue":{"href":"https://api.github.com/repos/boto/botocore/issues/701"},"comments":{"href":"https://api.github.com/repos/boto/botocore/issues/701/comments"},"review_comments":{"href":"https://api.github.com/repos/boto/botocore/pulls/701/comments"},"review_comment":{"href":"https://api.github.com/repos/boto/botocore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/boto/botocore/pulls/701/commits"},"statuses":{"href":"https://api.github.com/repos/boto/botocore/statuses/75708a7b042d2bcc63db477eda4cad15c089064c"}}}}