{"action":"closed","number":233,"pull_request":{"url":"https://api.github.com/repos/techfort/LokiJS/pulls/233","id":46726320,"html_url":"https://github.com/techfort/LokiJS/pull/233","diff_url":"https://github.com/techfort/LokiJS/pull/233.diff","patch_url":"https://github.com/techfort/LokiJS/pull/233.patch","issue_url":"https://api.github.com/repos/techfort/LokiJS/issues/233","number":233,"state":"closed","locked":false,"title":"Automatic document updates via Object.observe","user":{"login":"Cortys","id":1737630,"avatar_url":"https://avatars.githubusercontent.com/u/1737630?v=3","gravatar_id":"","url":"https://api.github.com/users/Cortys","html_url":"https://github.com/Cortys","followers_url":"https://api.github.com/users/Cortys/followers","following_url":"https://api.github.com/users/Cortys/following{/other_user}","gists_url":"https://api.github.com/users/Cortys/gists{/gist_id}","starred_url":"https://api.github.com/users/Cortys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cortys/subscriptions","organizations_url":"https://api.github.com/users/Cortys/orgs","repos_url":"https://api.github.com/users/Cortys/repos","events_url":"https://api.github.com/users/Cortys/events{/privacy}","received_events_url":"https://api.github.com/users/Cortys/received_events","type":"User","site_admin":false},"body":"As discussed in #231.\r\n\r\nBecause Object.observe is async, updates that cause a unique key violation fail without throwing and only emit an error event, that cannot be safely associated to the invalid object.\r\n\r\nI'm not sure about how much of an issue this is and if it has to be resolved before merging.","created_at":"2015-10-04T14:56:11Z","updated_at":"2015-10-06T21:26:47Z","closed_at":"2015-10-06T21:26:47Z","merged_at":"2015-10-06T21:26:47Z","merge_commit_sha":"97e963f0843b72ef2c31fae9b89f055cb1894135","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/techfort/LokiJS/pulls/233/commits","review_comments_url":"https://api.github.com/repos/techfort/LokiJS/pulls/233/comments","review_comment_url":"https://api.github.com/repos/techfort/LokiJS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/techfort/LokiJS/issues/233/comments","statuses_url":"https://api.github.com/repos/techfort/LokiJS/statuses/db8b5c49794b2a794638df886163fd4a7f000068","head":{"label":"runnr:master","ref":"master","sha":"db8b5c49794b2a794638df886163fd4a7f000068","user":{"login":"runnr","id":11589061,"avatar_url":"https://avatars.githubusercontent.com/u/11589061?v=3","gravatar_id":"","url":"https://api.github.com/users/runnr","html_url":"https://github.com/runnr","followers_url":"https://api.github.com/users/runnr/followers","following_url":"https://api.github.com/users/runnr/following{/other_user}","gists_url":"https://api.github.com/users/runnr/gists{/gist_id}","starred_url":"https://api.github.com/users/runnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runnr/subscriptions","organizations_url":"https://api.github.com/users/runnr/orgs","repos_url":"https://api.github.com/users/runnr/repos","events_url":"https://api.github.com/users/runnr/events{/privacy}","received_events_url":"https://api.github.com/users/runnr/received_events","type":"Organization","site_admin":false},"repo":{"id":42748541,"name":"LokiJS","full_name":"runnr/LokiJS","owner":{"login":"runnr","id":11589061,"avatar_url":"https://avatars.githubusercontent.com/u/11589061?v=3","gravatar_id":"","url":"https://api.github.com/users/runnr","html_url":"https://github.com/runnr","followers_url":"https://api.github.com/users/runnr/followers","following_url":"https://api.github.com/users/runnr/following{/other_user}","gists_url":"https://api.github.com/users/runnr/gists{/gist_id}","starred_url":"https://api.github.com/users/runnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runnr/subscriptions","organizations_url":"https://api.github.com/users/runnr/orgs","repos_url":"https://api.github.com/users/runnr/repos","events_url":"https://api.github.com/users/runnr/events{/privacy}","received_events_url":"https://api.github.com/users/runnr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/runnr/LokiJS","description":"javascript embeddable / in-memory database","fork":true,"url":"https://api.github.com/repos/runnr/LokiJS","forks_url":"https://api.github.com/repos/runnr/LokiJS/forks","keys_url":"https://api.github.com/repos/runnr/LokiJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/runnr/LokiJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/runnr/LokiJS/teams","hooks_url":"https://api.github.com/repos/runnr/LokiJS/hooks","issue_events_url":"https://api.github.com/repos/runnr/LokiJS/issues/events{/number}","events_url":"https://api.github.com/repos/runnr/LokiJS/events","assignees_url":"https://api.github.com/repos/runnr/LokiJS/assignees{/user}","branches_url":"https://api.github.com/repos/runnr/LokiJS/branches{/branch}","tags_url":"https://api.github.com/repos/runnr/LokiJS/tags","blobs_url":"https://api.github.com/repos/runnr/LokiJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/runnr/LokiJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/runnr/LokiJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/runnr/LokiJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/runnr/LokiJS/statuses/{sha}","languages_url":"https://api.github.com/repos/runnr/LokiJS/languages","stargazers_url":"https://api.github.com/repos/runnr/LokiJS/stargazers","contributors_url":"https://api.github.com/repos/runnr/LokiJS/contributors","subscribers_url":"https://api.github.com/repos/runnr/LokiJS/subscribers","subscription_url":"https://api.github.com/repos/runnr/LokiJS/subscription","commits_url":"https://api.github.com/repos/runnr/LokiJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/runnr/LokiJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/runnr/LokiJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/runnr/LokiJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/runnr/LokiJS/contents/{+path}","compare_url":"https://api.github.com/repos/runnr/LokiJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/runnr/LokiJS/merges","archive_url":"https://api.github.com/repos/runnr/LokiJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/runnr/LokiJS/downloads","issues_url":"https://api.github.com/repos/runnr/LokiJS/issues{/number}","pulls_url":"https://api.github.com/repos/runnr/LokiJS/pulls{/number}","milestones_url":"https://api.github.com/repos/runnr/LokiJS/milestones{/number}","notifications_url":"https://api.github.com/repos/runnr/LokiJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/runnr/LokiJS/labels{/name}","releases_url":"https://api.github.com/repos/runnr/LokiJS/releases{/id}","created_at":"2015-09-18T21:46:58Z","updated_at":"2015-09-18T21:46:58Z","pushed_at":"2015-10-04T15:03:38Z","git_url":"git://github.com/runnr/LokiJS.git","ssh_url":"git@github.com:runnr/LokiJS.git","clone_url":"https://github.com/runnr/LokiJS.git","svn_url":"https://github.com/runnr/LokiJS","homepage":"http://lokijs.org","size":5869,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"techfort:master","ref":"master","sha":"8a575afdda67db628ba21a153f1b0c43e70d7a53","user":{"login":"techfort","id":4130173,"avatar_url":"https://avatars.githubusercontent.com/u/4130173?v=3","gravatar_id":"","url":"https://api.github.com/users/techfort","html_url":"https://github.com/techfort","followers_url":"https://api.github.com/users/techfort/followers","following_url":"https://api.github.com/users/techfort/following{/other_user}","gists_url":"https://api.github.com/users/techfort/gists{/gist_id}","starred_url":"https://api.github.com/users/techfort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techfort/subscriptions","organizations_url":"https://api.github.com/users/techfort/orgs","repos_url":"https://api.github.com/users/techfort/repos","events_url":"https://api.github.com/users/techfort/events{/privacy}","received_events_url":"https://api.github.com/users/techfort/received_events","type":"User","site_admin":false},"repo":{"id":11654790,"name":"LokiJS","full_name":"techfort/LokiJS","owner":{"login":"techfort","id":4130173,"avatar_url":"https://avatars.githubusercontent.com/u/4130173?v=3","gravatar_id":"","url":"https://api.github.com/users/techfort","html_url":"https://github.com/techfort","followers_url":"https://api.github.com/users/techfort/followers","following_url":"https://api.github.com/users/techfort/following{/other_user}","gists_url":"https://api.github.com/users/techfort/gists{/gist_id}","starred_url":"https://api.github.com/users/techfort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techfort/subscriptions","organizations_url":"https://api.github.com/users/techfort/orgs","repos_url":"https://api.github.com/users/techfort/repos","events_url":"https://api.github.com/users/techfort/events{/privacy}","received_events_url":"https://api.github.com/users/techfort/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/techfort/LokiJS","description":"javascript embeddable / in-memory database","fork":false,"url":"https://api.github.com/repos/techfort/LokiJS","forks_url":"https://api.github.com/repos/techfort/LokiJS/forks","keys_url":"https://api.github.com/repos/techfort/LokiJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/techfort/LokiJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/techfort/LokiJS/teams","hooks_url":"https://api.github.com/repos/techfort/LokiJS/hooks","issue_events_url":"https://api.github.com/repos/techfort/LokiJS/issues/events{/number}","events_url":"https://api.github.com/repos/techfort/LokiJS/events","assignees_url":"https://api.github.com/repos/techfort/LokiJS/assignees{/user}","branches_url":"https://api.github.com/repos/techfort/LokiJS/branches{/branch}","tags_url":"https://api.github.com/repos/techfort/LokiJS/tags","blobs_url":"https://api.github.com/repos/techfort/LokiJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/techfort/LokiJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/techfort/LokiJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/techfort/LokiJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/techfort/LokiJS/statuses/{sha}","languages_url":"https://api.github.com/repos/techfort/LokiJS/languages","stargazers_url":"https://api.github.com/repos/techfort/LokiJS/stargazers","contributors_url":"https://api.github.com/repos/techfort/LokiJS/contributors","subscribers_url":"https://api.github.com/repos/techfort/LokiJS/subscribers","subscription_url":"https://api.github.com/repos/techfort/LokiJS/subscription","commits_url":"https://api.github.com/repos/techfort/LokiJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/techfort/LokiJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/techfort/LokiJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/techfort/LokiJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/techfort/LokiJS/contents/{+path}","compare_url":"https://api.github.com/repos/techfort/LokiJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/techfort/LokiJS/merges","archive_url":"https://api.github.com/repos/techfort/LokiJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/techfort/LokiJS/downloads","issues_url":"https://api.github.com/repos/techfort/LokiJS/issues{/number}","pulls_url":"https://api.github.com/repos/techfort/LokiJS/pulls{/number}","milestones_url":"https://api.github.com/repos/techfort/LokiJS/milestones{/number}","notifications_url":"https://api.github.com/repos/techfort/LokiJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/techfort/LokiJS/labels{/name}","releases_url":"https://api.github.com/repos/techfort/LokiJS/releases{/id}","created_at":"2013-07-25T07:39:20Z","updated_at":"2015-10-06T09:05:04Z","pushed_at":"2015-10-06T21:26:47Z","git_url":"git://github.com/techfort/LokiJS.git","ssh_url":"git@github.com:techfort/LokiJS.git","clone_url":"https://github.com/techfort/LokiJS.git","svn_url":"https://github.com/techfort/LokiJS","homepage":"http://lokijs.org","size":7879,"stargazers_count":1525,"watchers_count":1525,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":145,"mirror_url":null,"open_issues_count":32,"forks":145,"open_issues":32,"watchers":1525,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/techfort/LokiJS/pulls/233"},"html":{"href":"https://github.com/techfort/LokiJS/pull/233"},"issue":{"href":"https://api.github.com/repos/techfort/LokiJS/issues/233"},"comments":{"href":"https://api.github.com/repos/techfort/LokiJS/issues/233/comments"},"review_comments":{"href":"https://api.github.com/repos/techfort/LokiJS/pulls/233/comments"},"review_comment":{"href":"https://api.github.com/repos/techfort/LokiJS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/techfort/LokiJS/pulls/233/commits"},"statuses":{"href":"https://api.github.com/repos/techfort/LokiJS/statuses/db8b5c49794b2a794638df886163fd4a7f000068"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"obeliskos","id":7353046,"avatar_url":"https://avatars.githubusercontent.com/u/7353046?v=3","gravatar_id":"","url":"https://api.github.com/users/obeliskos","html_url":"https://github.com/obeliskos","followers_url":"https://api.github.com/users/obeliskos/followers","following_url":"https://api.github.com/users/obeliskos/following{/other_user}","gists_url":"https://api.github.com/users/obeliskos/gists{/gist_id}","starred_url":"https://api.github.com/users/obeliskos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obeliskos/subscriptions","organizations_url":"https://api.github.com/users/obeliskos/orgs","repos_url":"https://api.github.com/users/obeliskos/repos","events_url":"https://api.github.com/users/obeliskos/events{/privacy}","received_events_url":"https://api.github.com/users/obeliskos/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":6,"additions":170,"deletions":35,"changed_files":5}}