{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/2878","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/2878/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/2878/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/2878/events","html_url":"https://github.com/ManageIQ/manageiq/pull/2878","id":74126635,"number":2878,"title":"Fixed unique names for provisioned VMs when ordered through a service","user":{"login":"gmcculloug","id":2591569,"avatar_url":"https://avatars.githubusercontent.com/u/2591569?v=3","gravatar_id":"","url":"https://api.github.com/users/gmcculloug","html_url":"https://github.com/gmcculloug","followers_url":"https://api.github.com/users/gmcculloug/followers","following_url":"https://api.github.com/users/gmcculloug/following{/other_user}","gists_url":"https://api.github.com/users/gmcculloug/gists{/gist_id}","starred_url":"https://api.github.com/users/gmcculloug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmcculloug/subscriptions","organizations_url":"https://api.github.com/users/gmcculloug/orgs","repos_url":"https://api.github.com/users/gmcculloug/repos","events_url":"https://api.github.com/users/gmcculloug/events{/privacy}","received_events_url":"https://api.github.com/users/gmcculloug/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/provisioning","name":"provisioning","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-05-07T21:01:36Z","updated_at":"2015-05-09T12:21:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2878","html_url":"https://github.com/ManageIQ/manageiq/pull/2878","diff_url":"https://github.com/ManageIQ/manageiq/pull/2878.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/2878.patch"},"body":"Service ordering is a repeatable task that requires the creation of unique names for provisioned VMs that are part of the service template.  To ensure that a unique name is applied to the provisioned VMs a flag is set on the provision task to instruct the naming code to append an enumeration sequence to the VM name if one is not already supplied.  PR #2023 fixed an issue with the naming code being run twice for a service provision but exposed the current bug because the naming code was running before the unique_name flag was set.\r\n\r\nThis change allows the caller to provide a block and update the new task object before the naming code is run.\r\n\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1219098"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/100471079","html_url":"https://github.com/ManageIQ/manageiq/pull/2878#issuecomment-100471079","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/2878","id":100471079,"user":{"login":"kbrock","id":1930,"avatar_url":"https://avatars.githubusercontent.com/u/1930?v=3","gravatar_id":"","url":"https://api.github.com/users/kbrock","html_url":"https://github.com/kbrock","followers_url":"https://api.github.com/users/kbrock/followers","following_url":"https://api.github.com/users/kbrock/following{/other_user}","gists_url":"https://api.github.com/users/kbrock/gists{/gist_id}","starred_url":"https://api.github.com/users/kbrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbrock/subscriptions","organizations_url":"https://api.github.com/users/kbrock/orgs","repos_url":"https://api.github.com/users/kbrock/repos","events_url":"https://api.github.com/users/kbrock/events{/privacy}","received_events_url":"https://api.github.com/users/kbrock/received_events","type":"User","site_admin":false},"created_at":"2015-05-09T12:21:22Z","updated_at":"2015-05-09T12:21:22Z","body":"@gmcculloug This looks good to me.\r\nNot sure if anyone else wants to review. Ping me to merge"}}