{"action":"created","comment":{"url":"https://api.github.com/repos/geometalab/osmaxx/pulls/comments/40665633","id":40665633,"diff_hunk":"@@ -7,6 +6,50 @@\n from osmaxx.excerptexport import models\n \n \n+def module_converter_configuration(name, export_formats, export_options):\n+    return {\n+        'name': name,\n+        'formats': export_formats,\n+        'options': export_options\n+    }\n+\n+\n+def run_model_execute(execute_task_method, export_formats,\n+                      extraction_order, execution_configuration, run_as_celery_tasks):","path":"osmaxx-py/excerptconverter/converter_helper.py","position":19,"original_position":19,"commit_id":"324eb176d082f9950e0f23d57bb77f37cc06ac13","original_commit_id":"324eb176d082f9950e0f23d57bb77f37cc06ac13","user":{"login":"das-g","id":97746,"avatar_url":"https://avatars.githubusercontent.com/u/97746?v=3","gravatar_id":"","url":"https://api.github.com/users/das-g","html_url":"https://github.com/das-g","followers_url":"https://api.github.com/users/das-g/followers","following_url":"https://api.github.com/users/das-g/following{/other_user}","gists_url":"https://api.github.com/users/das-g/gists{/gist_id}","starred_url":"https://api.github.com/users/das-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/das-g/subscriptions","organizations_url":"https://api.github.com/users/das-g/orgs","repos_url":"https://api.github.com/users/das-g/repos","events_url":"https://api.github.com/users/das-g/events{/privacy}","received_events_url":"https://api.github.com/users/das-g/received_events","type":"User","site_admin":false},"body":"Avoid positional boolean arguments. (See 'Clean Code', Chapter 17, Section 'Functions', **F3: Flag Arguments** and Section 'General', **G15: Selector Arguments**.) Splitting the function into two separate ones as 'Clean Code' recommends is not practical here, though.\r\n\r\nThus, can we use a keyword argument instead, with `True` as default value? That way, only the invocation in some tests will be cluttered, and the \"clutter\" will help understand the meaning of this flag.","created_at":"2015-09-29T12:42:05Z","updated_at":"2015-09-29T12:42:05Z","html_url":"https://github.com/geometalab/osmaxx/pull/212#discussion_r40665633","pull_request_url":"https://api.github.com/repos/geometalab/osmaxx/pulls/212","_links":{"self":{"href":"https://api.github.com/repos/geometalab/osmaxx/pulls/comments/40665633"},"html":{"href":"https://github.com/geometalab/osmaxx/pull/212#discussion_r40665633"},"pull_request":{"href":"https://api.github.com/repos/geometalab/osmaxx/pulls/212"}}},"pull_request":{"url":"https://api.github.com/repos/geometalab/osmaxx/pulls/212","id":46257904,"html_url":"https://github.com/geometalab/osmaxx/pull/212","diff_url":"https://github.com/geometalab/osmaxx/pull/212.diff","patch_url":"https://github.com/geometalab/osmaxx/pull/212.patch","issue_url":"https://api.github.com/repos/geometalab/osmaxx/issues/212","number":212,"state":"open","locked":false,"title":"Feature/test gis converter#187","user":{"login":"wasabideveloper","id":10944699,"avatar_url":"https://avatars.githubusercontent.com/u/10944699?v=3","gravatar_id":"","url":"https://api.github.com/users/wasabideveloper","html_url":"https://github.com/wasabideveloper","followers_url":"https://api.github.com/users/wasabideveloper/followers","following_url":"https://api.github.com/users/wasabideveloper/following{/other_user}","gists_url":"https://api.github.com/users/wasabideveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/wasabideveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wasabideveloper/subscriptions","organizations_url":"https://api.github.com/users/wasabideveloper/orgs","repos_url":"https://api.github.com/users/wasabideveloper/repos","events_url":"https://api.github.com/users/wasabideveloper/events{/privacy}","received_events_url":"https://api.github.com/users/wasabideveloper/received_events","type":"User","site_admin":false},"body":"Implementation of feature #187 (Merge will close #187 ).\r\n\r\n* locales **NOT** compiled -> do this on release (prevent huge locale diffs in changes)\r\n* ran tests\r\n* tested views by hand:\r\n  * /orders/new [get/post]\r\n  * /orders/{id}\r\n\r\nTo be reviewed by:\r\n- [ ] @njordan-hsr \r\n- [ ] @das-g ","created_at":"2015-09-29T10:05:58Z","updated_at":"2015-09-29T12:42:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/geometalab/osmaxx/pulls/212/commits","review_comments_url":"https://api.github.com/repos/geometalab/osmaxx/pulls/212/comments","review_comment_url":"https://api.github.com/repos/geometalab/osmaxx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geometalab/osmaxx/issues/212/comments","statuses_url":"https://api.github.com/repos/geometalab/osmaxx/statuses/324eb176d082f9950e0f23d57bb77f37cc06ac13","head":{"label":"geometalab:feature/testGisConverter#187","ref":"feature/testGisConverter#187","sha":"324eb176d082f9950e0f23d57bb77f37cc06ac13","user":{"login":"geometalab","id":8266374,"avatar_url":"https://avatars.githubusercontent.com/u/8266374?v=3","gravatar_id":"","url":"https://api.github.com/users/geometalab","html_url":"https://github.com/geometalab","followers_url":"https://api.github.com/users/geometalab/followers","following_url":"https://api.github.com/users/geometalab/following{/other_user}","gists_url":"https://api.github.com/users/geometalab/gists{/gist_id}","starred_url":"https://api.github.com/users/geometalab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geometalab/subscriptions","organizations_url":"https://api.github.com/users/geometalab/orgs","repos_url":"https://api.github.com/users/geometalab/repos","events_url":"https://api.github.com/users/geometalab/events{/privacy}","received_events_url":"https://api.github.com/users/geometalab/received_events","type":"Organization","site_admin":false},"repo":{"id":28986110,"name":"osmaxx","full_name":"geometalab/osmaxx","owner":{"login":"geometalab","id":8266374,"avatar_url":"https://avatars.githubusercontent.com/u/8266374?v=3","gravatar_id":"","url":"https://api.github.com/users/geometalab","html_url":"https://github.com/geometalab","followers_url":"https://api.github.com/users/geometalab/followers","following_url":"https://api.github.com/users/geometalab/following{/other_user}","gists_url":"https://api.github.com/users/geometalab/gists{/gist_id}","starred_url":"https://api.github.com/users/geometalab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geometalab/subscriptions","organizations_url":"https://api.github.com/users/geometalab/orgs","repos_url":"https://api.github.com/users/geometalab/repos","events_url":"https://api.github.com/users/geometalab/events{/privacy}","received_events_url":"https://api.github.com/users/geometalab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geometalab/osmaxx","description":"OpenStreetMap Arbitrary eXcerpt eXport (main repository)","fork":false,"url":"https://api.github.com/repos/geometalab/osmaxx","forks_url":"https://api.github.com/repos/geometalab/osmaxx/forks","keys_url":"https://api.github.com/repos/geometalab/osmaxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geometalab/osmaxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geometalab/osmaxx/teams","hooks_url":"https://api.github.com/repos/geometalab/osmaxx/hooks","issue_events_url":"https://api.github.com/repos/geometalab/osmaxx/issues/events{/number}","events_url":"https://api.github.com/repos/geometalab/osmaxx/events","assignees_url":"https://api.github.com/repos/geometalab/osmaxx/assignees{/user}","branches_url":"https://api.github.com/repos/geometalab/osmaxx/branches{/branch}","tags_url":"https://api.github.com/repos/geometalab/osmaxx/tags","blobs_url":"https://api.github.com/repos/geometalab/osmaxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geometalab/osmaxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geometalab/osmaxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/geometalab/osmaxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geometalab/osmaxx/statuses/{sha}","languages_url":"https://api.github.com/repos/geometalab/osmaxx/languages","stargazers_url":"https://api.github.com/repos/geometalab/osmaxx/stargazers","contributors_url":"https://api.github.com/repos/geometalab/osmaxx/contributors","subscribers_url":"https://api.github.com/repos/geometalab/osmaxx/subscribers","subscription_url":"https://api.github.com/repos/geometalab/osmaxx/subscription","commits_url":"https://api.github.com/repos/geometalab/osmaxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/geometalab/osmaxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/geometalab/osmaxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/geometalab/osmaxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/geometalab/osmaxx/contents/{+path}","compare_url":"https://api.github.com/repos/geometalab/osmaxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geometalab/osmaxx/merges","archive_url":"https://api.github.com/repos/geometalab/osmaxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geometalab/osmaxx/downloads","issues_url":"https://api.github.com/repos/geometalab/osmaxx/issues{/number}","pulls_url":"https://api.github.com/repos/geometalab/osmaxx/pulls{/number}","milestones_url":"https://api.github.com/repos/geometalab/osmaxx/milestones{/number}","notifications_url":"https://api.github.com/repos/geometalab/osmaxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geometalab/osmaxx/labels{/name}","releases_url":"https://api.github.com/repos/geometalab/osmaxx/releases{/id}","created_at":"2015-01-08T21:05:34Z","updated_at":"2015-07-23T00:51:48Z","pushed_at":"2015-09-29T12:14:55Z","git_url":"git://github.com/geometalab/osmaxx.git","ssh_url":"git@github.com:geometalab/osmaxx.git","clone_url":"https://github.com/geometalab/osmaxx.git","svn_url":"https://github.com/geometalab/osmaxx","homepage":"http://osmaxx.hsr.ch/","size":2818,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":43,"forks":0,"open_issues":43,"watchers":2,"default_branch":"develop"}},"base":{"label":"geometalab:develop","ref":"develop","sha":"ed7e98acc53df8f7a7e91357f2cb347941cf20ca","user":{"login":"geometalab","id":8266374,"avatar_url":"https://avatars.githubusercontent.com/u/8266374?v=3","gravatar_id":"","url":"https://api.github.com/users/geometalab","html_url":"https://github.com/geometalab","followers_url":"https://api.github.com/users/geometalab/followers","following_url":"https://api.github.com/users/geometalab/following{/other_user}","gists_url":"https://api.github.com/users/geometalab/gists{/gist_id}","starred_url":"https://api.github.com/users/geometalab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geometalab/subscriptions","organizations_url":"https://api.github.com/users/geometalab/orgs","repos_url":"https://api.github.com/users/geometalab/repos","events_url":"https://api.github.com/users/geometalab/events{/privacy}","received_events_url":"https://api.github.com/users/geometalab/received_events","type":"Organization","site_admin":false},"repo":{"id":28986110,"name":"osmaxx","full_name":"geometalab/osmaxx","owner":{"login":"geometalab","id":8266374,"avatar_url":"https://avatars.githubusercontent.com/u/8266374?v=3","gravatar_id":"","url":"https://api.github.com/users/geometalab","html_url":"https://github.com/geometalab","followers_url":"https://api.github.com/users/geometalab/followers","following_url":"https://api.github.com/users/geometalab/following{/other_user}","gists_url":"https://api.github.com/users/geometalab/gists{/gist_id}","starred_url":"https://api.github.com/users/geometalab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geometalab/subscriptions","organizations_url":"https://api.github.com/users/geometalab/orgs","repos_url":"https://api.github.com/users/geometalab/repos","events_url":"https://api.github.com/users/geometalab/events{/privacy}","received_events_url":"https://api.github.com/users/geometalab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geometalab/osmaxx","description":"OpenStreetMap Arbitrary eXcerpt eXport (main repository)","fork":false,"url":"https://api.github.com/repos/geometalab/osmaxx","forks_url":"https://api.github.com/repos/geometalab/osmaxx/forks","keys_url":"https://api.github.com/repos/geometalab/osmaxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geometalab/osmaxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geometalab/osmaxx/teams","hooks_url":"https://api.github.com/repos/geometalab/osmaxx/hooks","issue_events_url":"https://api.github.com/repos/geometalab/osmaxx/issues/events{/number}","events_url":"https://api.github.com/repos/geometalab/osmaxx/events","assignees_url":"https://api.github.com/repos/geometalab/osmaxx/assignees{/user}","branches_url":"https://api.github.com/repos/geometalab/osmaxx/branches{/branch}","tags_url":"https://api.github.com/repos/geometalab/osmaxx/tags","blobs_url":"https://api.github.com/repos/geometalab/osmaxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geometalab/osmaxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geometalab/osmaxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/geometalab/osmaxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geometalab/osmaxx/statuses/{sha}","languages_url":"https://api.github.com/repos/geometalab/osmaxx/languages","stargazers_url":"https://api.github.com/repos/geometalab/osmaxx/stargazers","contributors_url":"https://api.github.com/repos/geometalab/osmaxx/contributors","subscribers_url":"https://api.github.com/repos/geometalab/osmaxx/subscribers","subscription_url":"https://api.github.com/repos/geometalab/osmaxx/subscription","commits_url":"https://api.github.com/repos/geometalab/osmaxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/geometalab/osmaxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/geometalab/osmaxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/geometalab/osmaxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/geometalab/osmaxx/contents/{+path}","compare_url":"https://api.github.com/repos/geometalab/osmaxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geometalab/osmaxx/merges","archive_url":"https://api.github.com/repos/geometalab/osmaxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geometalab/osmaxx/downloads","issues_url":"https://api.github.com/repos/geometalab/osmaxx/issues{/number}","pulls_url":"https://api.github.com/repos/geometalab/osmaxx/pulls{/number}","milestones_url":"https://api.github.com/repos/geometalab/osmaxx/milestones{/number}","notifications_url":"https://api.github.com/repos/geometalab/osmaxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geometalab/osmaxx/labels{/name}","releases_url":"https://api.github.com/repos/geometalab/osmaxx/releases{/id}","created_at":"2015-01-08T21:05:34Z","updated_at":"2015-07-23T00:51:48Z","pushed_at":"2015-09-29T12:14:55Z","git_url":"git://github.com/geometalab/osmaxx.git","ssh_url":"git@github.com:geometalab/osmaxx.git","clone_url":"https://github.com/geometalab/osmaxx.git","svn_url":"https://github.com/geometalab/osmaxx","homepage":"http://osmaxx.hsr.ch/","size":2818,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":43,"forks":0,"open_issues":43,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/geometalab/osmaxx/pulls/212"},"html":{"href":"https://github.com/geometalab/osmaxx/pull/212"},"issue":{"href":"https://api.github.com/repos/geometalab/osmaxx/issues/212"},"comments":{"href":"https://api.github.com/repos/geometalab/osmaxx/issues/212/comments"},"review_comments":{"href":"https://api.github.com/repos/geometalab/osmaxx/pulls/212/comments"},"review_comment":{"href":"https://api.github.com/repos/geometalab/osmaxx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geometalab/osmaxx/pulls/212/commits"},"statuses":{"href":"https://api.github.com/repos/geometalab/osmaxx/statuses/324eb176d082f9950e0f23d57bb77f37cc06ac13"}}}}