{"action":"closed","number":1585,"pull_request":{"url":"https://api.github.com/repos/mozilla/MozStumbler/pulls/1585","id":31643305,"html_url":"https://github.com/mozilla/MozStumbler/pull/1585","diff_url":"https://github.com/mozilla/MozStumbler/pull/1585.diff","patch_url":"https://github.com/mozilla/MozStumbler/pull/1585.patch","issue_url":"https://api.github.com/repos/mozilla/MozStumbler/issues/1585","number":1585,"state":"closed","locked":false,"title":"Remove conditional location of stumbler files","user":{"login":"crankycoder","id":4829,"avatar_url":"https://avatars.githubusercontent.com/u/4829?v=3","gravatar_id":"","url":"https://api.github.com/users/crankycoder","html_url":"https://github.com/crankycoder","followers_url":"https://api.github.com/users/crankycoder/followers","following_url":"https://api.github.com/users/crankycoder/following{/other_user}","gists_url":"https://api.github.com/users/crankycoder/gists{/gist_id}","starred_url":"https://api.github.com/users/crankycoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crankycoder/subscriptions","organizations_url":"https://api.github.com/users/crankycoder/orgs","repos_url":"https://api.github.com/users/crankycoder/repos","events_url":"https://api.github.com/users/crankycoder/events{/privacy}","received_events_url":"https://api.github.com/users/crankycoder/received_events","type":"User","site_admin":false},"body":"I've removed a block of code which put the stumbler reports into a special directory for debug builds.\r\n\r\nThis was just confusing when diagnosing a problem with the DemoStumbler.  In a nutshell - AppGlobals.isDebug is not final and it had a value which I wasn't expecting, so files were not being written or read from an expected directory.\r\n\r\nI don't think there's really any benefit to multiple directories anyway. If we really want to have an alternate directory, I would opt for an explicit path that is set into the DataStorageManager.","created_at":"2015-03-20T19:13:38Z","updated_at":"2015-03-23T18:41:25Z","closed_at":"2015-03-23T18:41:25Z","merged_at":"2015-03-23T18:41:24Z","merge_commit_sha":"e5693e7ce7d8117d3235379158522c074666803e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/MozStumbler/pulls/1585/commits","review_comments_url":"https://api.github.com/repos/mozilla/MozStumbler/pulls/1585/comments","review_comment_url":"https://api.github.com/repos/mozilla/MozStumbler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/MozStumbler/issues/1585/comments","statuses_url":"https://api.github.com/repos/mozilla/MozStumbler/statuses/adeb286af80ca6806d0484d3e0ec5e9803d5f88e","head":{"label":"crankycoder:features/1428-library-release","ref":"features/1428-library-release","sha":"adeb286af80ca6806d0484d3e0ec5e9803d5f88e","user":{"login":"crankycoder","id":4829,"avatar_url":"https://avatars.githubusercontent.com/u/4829?v=3","gravatar_id":"","url":"https://api.github.com/users/crankycoder","html_url":"https://github.com/crankycoder","followers_url":"https://api.github.com/users/crankycoder/followers","following_url":"https://api.github.com/users/crankycoder/following{/other_user}","gists_url":"https://api.github.com/users/crankycoder/gists{/gist_id}","starred_url":"https://api.github.com/users/crankycoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crankycoder/subscriptions","organizations_url":"https://api.github.com/users/crankycoder/orgs","repos_url":"https://api.github.com/users/crankycoder/repos","events_url":"https://api.github.com/users/crankycoder/events{/privacy}","received_events_url":"https://api.github.com/users/crankycoder/received_events","type":"User","site_admin":false},"repo":{"id":23362570,"name":"MozStumbler","full_name":"crankycoder/MozStumbler","owner":{"login":"crankycoder","id":4829,"avatar_url":"https://avatars.githubusercontent.com/u/4829?v=3","gravatar_id":"","url":"https://api.github.com/users/crankycoder","html_url":"https://github.com/crankycoder","followers_url":"https://api.github.com/users/crankycoder/followers","following_url":"https://api.github.com/users/crankycoder/following{/other_user}","gists_url":"https://api.github.com/users/crankycoder/gists{/gist_id}","starred_url":"https://api.github.com/users/crankycoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crankycoder/subscriptions","organizations_url":"https://api.github.com/users/crankycoder/orgs","repos_url":"https://api.github.com/users/crankycoder/repos","events_url":"https://api.github.com/users/crankycoder/events{/privacy}","received_events_url":"https://api.github.com/users/crankycoder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/crankycoder/MozStumbler","description":"Android Stumbler for Mozilla","fork":true,"url":"https://api.github.com/repos/crankycoder/MozStumbler","forks_url":"https://api.github.com/repos/crankycoder/MozStumbler/forks","keys_url":"https://api.github.com/repos/crankycoder/MozStumbler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crankycoder/MozStumbler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crankycoder/MozStumbler/teams","hooks_url":"https://api.github.com/repos/crankycoder/MozStumbler/hooks","issue_events_url":"https://api.github.com/repos/crankycoder/MozStumbler/issues/events{/number}","events_url":"https://api.github.com/repos/crankycoder/MozStumbler/events","assignees_url":"https://api.github.com/repos/crankycoder/MozStumbler/assignees{/user}","branches_url":"https://api.github.com/repos/crankycoder/MozStumbler/branches{/branch}","tags_url":"https://api.github.com/repos/crankycoder/MozStumbler/tags","blobs_url":"https://api.github.com/repos/crankycoder/MozStumbler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crankycoder/MozStumbler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crankycoder/MozStumbler/git/refs{/sha}","trees_url":"https://api.github.com/repos/crankycoder/MozStumbler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crankycoder/MozStumbler/statuses/{sha}","languages_url":"https://api.github.com/repos/crankycoder/MozStumbler/languages","stargazers_url":"https://api.github.com/repos/crankycoder/MozStumbler/stargazers","contributors_url":"https://api.github.com/repos/crankycoder/MozStumbler/contributors","subscribers_url":"https://api.github.com/repos/crankycoder/MozStumbler/subscribers","subscription_url":"https://api.github.com/repos/crankycoder/MozStumbler/subscription","commits_url":"https://api.github.com/repos/crankycoder/MozStumbler/commits{/sha}","git_commits_url":"https://api.github.com/repos/crankycoder/MozStumbler/git/commits{/sha}","comments_url":"https://api.github.com/repos/crankycoder/MozStumbler/comments{/number}","issue_comment_url":"https://api.github.com/repos/crankycoder/MozStumbler/issues/comments{/number}","contents_url":"https://api.github.com/repos/crankycoder/MozStumbler/contents/{+path}","compare_url":"https://api.github.com/repos/crankycoder/MozStumbler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crankycoder/MozStumbler/merges","archive_url":"https://api.github.com/repos/crankycoder/MozStumbler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crankycoder/MozStumbler/downloads","issues_url":"https://api.github.com/repos/crankycoder/MozStumbler/issues{/number}","pulls_url":"https://api.github.com/repos/crankycoder/MozStumbler/pulls{/number}","milestones_url":"https://api.github.com/repos/crankycoder/MozStumbler/milestones{/number}","notifications_url":"https://api.github.com/repos/crankycoder/MozStumbler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crankycoder/MozStumbler/labels{/name}","releases_url":"https://api.github.com/repos/crankycoder/MozStumbler/releases{/id}","created_at":"2014-08-26T18:35:54Z","updated_at":"2015-03-09T15:33:55Z","pushed_at":"2015-03-23T17:45:55Z","git_url":"git://github.com/crankycoder/MozStumbler.git","ssh_url":"git@github.com:crankycoder/MozStumbler.git","clone_url":"https://github.com/crankycoder/MozStumbler.git","svn_url":"https://github.com/crankycoder/MozStumbler","homepage":"http://location.services.mozilla.com","size":7707,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"mozilla:dev","ref":"dev","sha":"fb38b5b094aea443ae7f7eae86d381127b29d9dd","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":11164718,"name":"MozStumbler","full_name":"mozilla/MozStumbler","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/MozStumbler","description":"Android Stumbler for Mozilla","fork":false,"url":"https://api.github.com/repos/mozilla/MozStumbler","forks_url":"https://api.github.com/repos/mozilla/MozStumbler/forks","keys_url":"https://api.github.com/repos/mozilla/MozStumbler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/MozStumbler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/MozStumbler/teams","hooks_url":"https://api.github.com/repos/mozilla/MozStumbler/hooks","issue_events_url":"https://api.github.com/repos/mozilla/MozStumbler/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/MozStumbler/events","assignees_url":"https://api.github.com/repos/mozilla/MozStumbler/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/MozStumbler/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/MozStumbler/tags","blobs_url":"https://api.github.com/repos/mozilla/MozStumbler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/MozStumbler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/MozStumbler/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/MozStumbler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/MozStumbler/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/MozStumbler/languages","stargazers_url":"https://api.github.com/repos/mozilla/MozStumbler/stargazers","contributors_url":"https://api.github.com/repos/mozilla/MozStumbler/contributors","subscribers_url":"https://api.github.com/repos/mozilla/MozStumbler/subscribers","subscription_url":"https://api.github.com/repos/mozilla/MozStumbler/subscription","commits_url":"https://api.github.com/repos/mozilla/MozStumbler/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/MozStumbler/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/MozStumbler/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/MozStumbler/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/MozStumbler/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/MozStumbler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/MozStumbler/merges","archive_url":"https://api.github.com/repos/mozilla/MozStumbler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/MozStumbler/downloads","issues_url":"https://api.github.com/repos/mozilla/MozStumbler/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/MozStumbler/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/MozStumbler/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/MozStumbler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/MozStumbler/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/MozStumbler/releases{/id}","created_at":"2013-07-04T01:22:30Z","updated_at":"2015-03-23T17:47:56Z","pushed_at":"2015-03-23T18:41:24Z","git_url":"git://github.com/mozilla/MozStumbler.git","ssh_url":"git@github.com:mozilla/MozStumbler.git","clone_url":"https://github.com/mozilla/MozStumbler.git","svn_url":"https://github.com/mozilla/MozStumbler","homepage":"http://location.services.mozilla.com","size":15062,"stargazers_count":430,"watchers_count":430,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":166,"mirror_url":null,"open_issues_count":127,"forks":166,"open_issues":127,"watchers":430,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/MozStumbler/pulls/1585"},"html":{"href":"https://github.com/mozilla/MozStumbler/pull/1585"},"issue":{"href":"https://api.github.com/repos/mozilla/MozStumbler/issues/1585"},"comments":{"href":"https://api.github.com/repos/mozilla/MozStumbler/issues/1585/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/MozStumbler/pulls/1585/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/MozStumbler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/MozStumbler/pulls/1585/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/MozStumbler/statuses/adeb286af80ca6806d0484d3e0ec5e9803d5f88e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"crankycoder","id":4829,"avatar_url":"https://avatars.githubusercontent.com/u/4829?v=3","gravatar_id":"","url":"https://api.github.com/users/crankycoder","html_url":"https://github.com/crankycoder","followers_url":"https://api.github.com/users/crankycoder/followers","following_url":"https://api.github.com/users/crankycoder/following{/other_user}","gists_url":"https://api.github.com/users/crankycoder/gists{/gist_id}","starred_url":"https://api.github.com/users/crankycoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crankycoder/subscriptions","organizations_url":"https://api.github.com/users/crankycoder/orgs","repos_url":"https://api.github.com/users/crankycoder/repos","events_url":"https://api.github.com/users/crankycoder/events{/privacy}","received_events_url":"https://api.github.com/users/crankycoder/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":5,"deletions":0,"changed_files":1}}