{"action":"created","issue":{"url":"https://api.github.com/repos/vtsuperdarn/davitpy/issues/160","labels_url":"https://api.github.com/repos/vtsuperdarn/davitpy/issues/160/labels{/name}","comments_url":"https://api.github.com/repos/vtsuperdarn/davitpy/issues/160/comments","events_url":"https://api.github.com/repos/vtsuperdarn/davitpy/issues/160/events","html_url":"https://github.com/vtsuperdarn/davitpy/pull/160","id":111400889,"number":160,"title":"Tepidfix raytrace / 2 Parameter Method","user":{"login":"w2naf","id":1831182,"avatar_url":"https://avatars.githubusercontent.com/u/1831182?v=3","gravatar_id":"","url":"https://api.github.com/users/w2naf","html_url":"https://github.com/w2naf","followers_url":"https://api.github.com/users/w2naf/followers","following_url":"https://api.github.com/users/w2naf/following{/other_user}","gists_url":"https://api.github.com/users/w2naf/gists{/gist_id}","starred_url":"https://api.github.com/users/w2naf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w2naf/subscriptions","organizations_url":"https://api.github.com/users/w2naf/orgs","repos_url":"https://api.github.com/users/w2naf/repos","events_url":"https://api.github.com/users/w2naf/events{/privacy}","received_events_url":"https://api.github.com/users/w2naf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":14,"created_at":"2015-10-14T13:42:46Z","updated_at":"2015-10-29T20:12:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vtsuperdarn/davitpy/pulls/160","html_url":"https://github.com/vtsuperdarn/davitpy/pull/160","diff_url":"https://github.com/vtsuperdarn/davitpy/pull/160.diff","patch_url":"https://github.com/vtsuperdarn/davitpy/pull/160.patch"},"body":"* Sets Raytrace ranges out to 4000 km by setting an 8 km horizontal step size.\r\n* Adds 2 notebooks illustrating the 2 Parameter Method Geolocation algorithm [Greenwald et al., 2015, Radio Sci., Submitted]"},"comment":{"url":"https://api.github.com/repos/vtsuperdarn/davitpy/issues/comments/152304967","html_url":"https://github.com/vtsuperdarn/davitpy/pull/160#issuecomment-152304967","issue_url":"https://api.github.com/repos/vtsuperdarn/davitpy/issues/160","id":152304967,"user":{"login":"asreimer","id":4604819,"avatar_url":"https://avatars.githubusercontent.com/u/4604819?v=3","gravatar_id":"","url":"https://api.github.com/users/asreimer","html_url":"https://github.com/asreimer","followers_url":"https://api.github.com/users/asreimer/followers","following_url":"https://api.github.com/users/asreimer/following{/other_user}","gists_url":"https://api.github.com/users/asreimer/gists{/gist_id}","starred_url":"https://api.github.com/users/asreimer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asreimer/subscriptions","organizations_url":"https://api.github.com/users/asreimer/orgs","repos_url":"https://api.github.com/users/asreimer/repos","events_url":"https://api.github.com/users/asreimer/events{/privacy}","received_events_url":"https://api.github.com/users/asreimer/received_events","type":"User","site_admin":false},"created_at":"2015-10-29T20:12:16Z","updated_at":"2015-10-29T20:12:16Z","body":"@ksterne said:\r\n>That finishes the analysis notebook. I have to admit, after a lot of those long charts and not much commenting, I was just clicking through and by the time the plots at the end showed up, I'm really not at all sure what I'm looking at or what those mean. I know I've seen them before and that they show meaningful information, but I can't see it here.\r\n\r\nUnfortunately, this sums it up for me too.\r\n\r\nThis pull request doesn't have to go out in the release-0.4 does it? It's currently slated for merging into develop.\r\n\r\nThis seems like a good time to emphasize that in future pull requests we really need to be careful about the commits we add to them. For example, this pull request adds the 2 param method which only uses 2 notebooks and ray tracing, yet there are 8 files that have been modified. This is messy and could cause us problems later in terms of bugs and merge conflicts if we aren't more careful. At the very least, it's confusing while doing testing. \r\n\r\nIf there are bugs and formatting to fix, we should open a new pull request and fix them there. Let's try to keep our pull requests on topic to make it easier to test them and prevent merge conflicts and bugs."}}