{"action":"created","comment":{"url":"https://api.github.com/repos/rob-murray/ferver/pulls/comments/23890056","id":23890056,"diff_hunk":"@@ -58,6 +52,12 @@ def valid_file_request?\n       file_id_request.valid?\n     end\n \n+    def find_file\n+      ferver_list.file_by_id(file_id_request.value)\n+    rescue IndexError\n+      halt 404, 'File requested not found.'","path":"lib/ferver/controller.rb","position":33,"original_position":33,"commit_id":"f537ac09d891e408dfd0dbee6bcbbb17ad0be3b6","original_commit_id":"f537ac09d891e408dfd0dbee6bcbbb17ad0be3b6","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.","created_at":"2015-01-31T16:31:08Z","updated_at":"2015-01-31T16:31:08Z","html_url":"https://github.com/rob-murray/ferver/pull/14#discussion_r23890056","pull_request_url":"https://api.github.com/repos/rob-murray/ferver/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/rob-murray/ferver/pulls/comments/23890056"},"html":{"href":"https://github.com/rob-murray/ferver/pull/14#discussion_r23890056"},"pull_request":{"href":"https://api.github.com/repos/rob-murray/ferver/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/rob-murray/ferver/pulls/14","id":28417039,"html_url":"https://github.com/rob-murray/ferver/pull/14","diff_url":"https://github.com/rob-murray/ferver/pull/14.diff","patch_url":"https://github.com/rob-murray/ferver/pull/14.patch","issue_url":"https://api.github.com/repos/rob-murray/ferver/issues/14","number":14,"state":"open","locked":false,"title":"Refuctorings","user":{"login":"rob-murray","id":1809160,"avatar_url":"https://avatars.githubusercontent.com/u/1809160?v=3","gravatar_id":"","url":"https://api.github.com/users/rob-murray","html_url":"https://github.com/rob-murray","followers_url":"https://api.github.com/users/rob-murray/followers","following_url":"https://api.github.com/users/rob-murray/following{/other_user}","gists_url":"https://api.github.com/users/rob-murray/gists{/gist_id}","starred_url":"https://api.github.com/users/rob-murray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rob-murray/subscriptions","organizations_url":"https://api.github.com/users/rob-murray/orgs","repos_url":"https://api.github.com/users/rob-murray/repos","events_url":"https://api.github.com/users/rob-murray/events{/privacy}","received_events_url":"https://api.github.com/users/rob-murray/received_events","type":"User","site_admin":false},"body":"Refactor some stuff","created_at":"2015-01-31T16:31:04Z","updated_at":"2015-01-31T16:31:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cea41b7154742911f4564cf5db0fb78d451ea020","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rob-murray/ferver/pulls/14/commits","review_comments_url":"https://api.github.com/repos/rob-murray/ferver/pulls/14/comments","review_comment_url":"https://api.github.com/repos/rob-murray/ferver/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rob-murray/ferver/issues/14/comments","statuses_url":"https://api.github.com/repos/rob-murray/ferver/statuses/f537ac09d891e408dfd0dbee6bcbbb17ad0be3b6","head":{"label":"rob-murray:refuctorings","ref":"refuctorings","sha":"f537ac09d891e408dfd0dbee6bcbbb17ad0be3b6","user":{"login":"rob-murray","id":1809160,"avatar_url":"https://avatars.githubusercontent.com/u/1809160?v=3","gravatar_id":"","url":"https://api.github.com/users/rob-murray","html_url":"https://github.com/rob-murray","followers_url":"https://api.github.com/users/rob-murray/followers","following_url":"https://api.github.com/users/rob-murray/following{/other_user}","gists_url":"https://api.github.com/users/rob-murray/gists{/gist_id}","starred_url":"https://api.github.com/users/rob-murray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rob-murray/subscriptions","organizations_url":"https://api.github.com/users/rob-murray/orgs","repos_url":"https://api.github.com/users/rob-murray/repos","events_url":"https://api.github.com/users/rob-murray/events{/privacy}","received_events_url":"https://api.github.com/users/rob-murray/received_events","type":"User","site_admin":false},"repo":{"id":5752593,"name":"ferver","full_name":"rob-murray/ferver","owner":{"login":"rob-murray","id":1809160,"avatar_url":"https://avatars.githubusercontent.com/u/1809160?v=3","gravatar_id":"","url":"https://api.github.com/users/rob-murray","html_url":"https://github.com/rob-murray","followers_url":"https://api.github.com/users/rob-murray/followers","following_url":"https://api.github.com/users/rob-murray/following{/other_user}","gists_url":"https://api.github.com/users/rob-murray/gists{/gist_id}","starred_url":"https://api.github.com/users/rob-murray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rob-murray/subscriptions","organizations_url":"https://api.github.com/users/rob-murray/orgs","repos_url":"https://api.github.com/users/rob-murray/repos","events_url":"https://api.github.com/users/rob-murray/events{/privacy}","received_events_url":"https://api.github.com/users/rob-murray/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rob-murray/ferver","description":"A Ruby gem to serve files over HTTP, packaged as a Ruby gem","fork":false,"url":"https://api.github.com/repos/rob-murray/ferver","forks_url":"https://api.github.com/repos/rob-murray/ferver/forks","keys_url":"https://api.github.com/repos/rob-murray/ferver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rob-murray/ferver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rob-murray/ferver/teams","hooks_url":"https://api.github.com/repos/rob-murray/ferver/hooks","issue_events_url":"https://api.github.com/repos/rob-murray/ferver/issues/events{/number}","events_url":"https://api.github.com/repos/rob-murray/ferver/events","assignees_url":"https://api.github.com/repos/rob-murray/ferver/assignees{/user}","branches_url":"https://api.github.com/repos/rob-murray/ferver/branches{/branch}","tags_url":"https://api.github.com/repos/rob-murray/ferver/tags","blobs_url":"https://api.github.com/repos/rob-murray/ferver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rob-murray/ferver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rob-murray/ferver/git/refs{/sha}","trees_url":"https://api.github.com/repos/rob-murray/ferver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rob-murray/ferver/statuses/{sha}","languages_url":"https://api.github.com/repos/rob-murray/ferver/languages","stargazers_url":"https://api.github.com/repos/rob-murray/ferver/stargazers","contributors_url":"https://api.github.com/repos/rob-murray/ferver/contributors","subscribers_url":"https://api.github.com/repos/rob-murray/ferver/subscribers","subscription_url":"https://api.github.com/repos/rob-murray/ferver/subscription","commits_url":"https://api.github.com/repos/rob-murray/ferver/commits{/sha}","git_commits_url":"https://api.github.com/repos/rob-murray/ferver/git/commits{/sha}","comments_url":"https://api.github.com/repos/rob-murray/ferver/comments{/number}","issue_comment_url":"https://api.github.com/repos/rob-murray/ferver/issues/comments/{number}","contents_url":"https://api.github.com/repos/rob-murray/ferver/contents/{+path}","compare_url":"https://api.github.com/repos/rob-murray/ferver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rob-murray/ferver/merges","archive_url":"https://api.github.com/repos/rob-murray/ferver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rob-murray/ferver/downloads","issues_url":"https://api.github.com/repos/rob-murray/ferver/issues{/number}","pulls_url":"https://api.github.com/repos/rob-murray/ferver/pulls{/number}","milestones_url":"https://api.github.com/repos/rob-murray/ferver/milestones{/number}","notifications_url":"https://api.github.com/repos/rob-murray/ferver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rob-murray/ferver/labels{/name}","releases_url":"https://api.github.com/repos/rob-murray/ferver/releases{/id}","created_at":"2012-09-10T16:52:57Z","updated_at":"2014-12-17T17:37:23Z","pushed_at":"2015-01-31T16:30:31Z","git_url":"git://github.com/rob-murray/ferver.git","ssh_url":"git@github.com:rob-murray/ferver.git","clone_url":"https://github.com/rob-murray/ferver.git","svn_url":"https://github.com/rob-murray/ferver","homepage":"","size":432,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":5,"default_branch":"master"}},"base":{"label":"rob-murray:master","ref":"master","sha":"0ba8ccf70ec5361811604f55bbc78decc9dfdb89","user":{"login":"rob-murray","id":1809160,"avatar_url":"https://avatars.githubusercontent.com/u/1809160?v=3","gravatar_id":"","url":"https://api.github.com/users/rob-murray","html_url":"https://github.com/rob-murray","followers_url":"https://api.github.com/users/rob-murray/followers","following_url":"https://api.github.com/users/rob-murray/following{/other_user}","gists_url":"https://api.github.com/users/rob-murray/gists{/gist_id}","starred_url":"https://api.github.com/users/rob-murray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rob-murray/subscriptions","organizations_url":"https://api.github.com/users/rob-murray/orgs","repos_url":"https://api.github.com/users/rob-murray/repos","events_url":"https://api.github.com/users/rob-murray/events{/privacy}","received_events_url":"https://api.github.com/users/rob-murray/received_events","type":"User","site_admin":false},"repo":{"id":5752593,"name":"ferver","full_name":"rob-murray/ferver","owner":{"login":"rob-murray","id":1809160,"avatar_url":"https://avatars.githubusercontent.com/u/1809160?v=3","gravatar_id":"","url":"https://api.github.com/users/rob-murray","html_url":"https://github.com/rob-murray","followers_url":"https://api.github.com/users/rob-murray/followers","following_url":"https://api.github.com/users/rob-murray/following{/other_user}","gists_url":"https://api.github.com/users/rob-murray/gists{/gist_id}","starred_url":"https://api.github.com/users/rob-murray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rob-murray/subscriptions","organizations_url":"https://api.github.com/users/rob-murray/orgs","repos_url":"https://api.github.com/users/rob-murray/repos","events_url":"https://api.github.com/users/rob-murray/events{/privacy}","received_events_url":"https://api.github.com/users/rob-murray/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rob-murray/ferver","description":"A Ruby gem to serve files over HTTP, packaged as a Ruby gem","fork":false,"url":"https://api.github.com/repos/rob-murray/ferver","forks_url":"https://api.github.com/repos/rob-murray/ferver/forks","keys_url":"https://api.github.com/repos/rob-murray/ferver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rob-murray/ferver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rob-murray/ferver/teams","hooks_url":"https://api.github.com/repos/rob-murray/ferver/hooks","issue_events_url":"https://api.github.com/repos/rob-murray/ferver/issues/events{/number}","events_url":"https://api.github.com/repos/rob-murray/ferver/events","assignees_url":"https://api.github.com/repos/rob-murray/ferver/assignees{/user}","branches_url":"https://api.github.com/repos/rob-murray/ferver/branches{/branch}","tags_url":"https://api.github.com/repos/rob-murray/ferver/tags","blobs_url":"https://api.github.com/repos/rob-murray/ferver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rob-murray/ferver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rob-murray/ferver/git/refs{/sha}","trees_url":"https://api.github.com/repos/rob-murray/ferver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rob-murray/ferver/statuses/{sha}","languages_url":"https://api.github.com/repos/rob-murray/ferver/languages","stargazers_url":"https://api.github.com/repos/rob-murray/ferver/stargazers","contributors_url":"https://api.github.com/repos/rob-murray/ferver/contributors","subscribers_url":"https://api.github.com/repos/rob-murray/ferver/subscribers","subscription_url":"https://api.github.com/repos/rob-murray/ferver/subscription","commits_url":"https://api.github.com/repos/rob-murray/ferver/commits{/sha}","git_commits_url":"https://api.github.com/repos/rob-murray/ferver/git/commits{/sha}","comments_url":"https://api.github.com/repos/rob-murray/ferver/comments{/number}","issue_comment_url":"https://api.github.com/repos/rob-murray/ferver/issues/comments/{number}","contents_url":"https://api.github.com/repos/rob-murray/ferver/contents/{+path}","compare_url":"https://api.github.com/repos/rob-murray/ferver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rob-murray/ferver/merges","archive_url":"https://api.github.com/repos/rob-murray/ferver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rob-murray/ferver/downloads","issues_url":"https://api.github.com/repos/rob-murray/ferver/issues{/number}","pulls_url":"https://api.github.com/repos/rob-murray/ferver/pulls{/number}","milestones_url":"https://api.github.com/repos/rob-murray/ferver/milestones{/number}","notifications_url":"https://api.github.com/repos/rob-murray/ferver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rob-murray/ferver/labels{/name}","releases_url":"https://api.github.com/repos/rob-murray/ferver/releases{/id}","created_at":"2012-09-10T16:52:57Z","updated_at":"2014-12-17T17:37:23Z","pushed_at":"2015-01-31T16:30:31Z","git_url":"git://github.com/rob-murray/ferver.git","ssh_url":"git@github.com:rob-murray/ferver.git","clone_url":"https://github.com/rob-murray/ferver.git","svn_url":"https://github.com/rob-murray/ferver","homepage":"","size":432,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rob-murray/ferver/pulls/14"},"html":{"href":"https://github.com/rob-murray/ferver/pull/14"},"issue":{"href":"https://api.github.com/repos/rob-murray/ferver/issues/14"},"comments":{"href":"https://api.github.com/repos/rob-murray/ferver/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/rob-murray/ferver/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/rob-murray/ferver/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rob-murray/ferver/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/rob-murray/ferver/statuses/f537ac09d891e408dfd0dbee6bcbbb17ad0be3b6"}}}}