{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/42556098","id":42556098,"diff_hunk":"@@ -53,7 +53,7 @@ func (l *lifecycle) Admit(a admission.Attributes) (err error) {\n \n \t// prevent deletion of immortal namespaces\n \tif a.GetOperation() == admission.Delete && a.GetKind() == \"Namespace\" && l.immortalNamespaces.Has(a.GetName()) {\n-\t\treturn errors.NewForbidden(a.GetKind(), a.GetName(), fmt.Errorf(\"namespace can never be deleted\"))\n+\t\treturn errors.NewForbidden(a.GetKind(), a.GetName(), fmt.Errorf(\"an immortal namespace can never be deleted\"))","path":"plugin/pkg/admission/namespace/lifecycle/admission.go","position":5,"original_position":5,"commit_id":"93798d5b4cea34bebdb92af42341db33bdff4f0d","original_commit_id":"93798d5b4cea34bebdb92af42341db33bdff4f0d","user":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"body":"I'm not sure we want to introduce a concept of \"immortal namespaces\" because people will want to make them.  Maybe this should just say \"this namespace may not be deleted\".  Key words \"this\" and \"may not be\" as opposed to \"can never be\".\r\n\r\n@derekwaynecarr ","created_at":"2015-10-20T21:19:55Z","updated_at":"2015-10-20T21:19:55Z","html_url":"https://github.com/kubernetes/kubernetes/pull/15942#discussion_r42556098","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/15942","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/42556098"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/15942#discussion_r42556098"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/15942"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/15942","id":48191204,"html_url":"https://github.com/kubernetes/kubernetes/pull/15942","diff_url":"https://github.com/kubernetes/kubernetes/pull/15942.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/15942.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/15942","number":15942,"state":"open","locked":false,"title":"Return a clear error when deleting an immortal namespace","user":{"login":"feihujiang","id":2322270,"avatar_url":"https://avatars.githubusercontent.com/u/2322270?v=3","gravatar_id":"","url":"https://api.github.com/users/feihujiang","html_url":"https://github.com/feihujiang","followers_url":"https://api.github.com/users/feihujiang/followers","following_url":"https://api.github.com/users/feihujiang/following{/other_user}","gists_url":"https://api.github.com/users/feihujiang/gists{/gist_id}","starred_url":"https://api.github.com/users/feihujiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feihujiang/subscriptions","organizations_url":"https://api.github.com/users/feihujiang/orgs","repos_url":"https://api.github.com/users/feihujiang/repos","events_url":"https://api.github.com/users/feihujiang/events{/privacy}","received_events_url":"https://api.github.com/users/feihujiang/received_events","type":"User","site_admin":false},"body":"The previous message is \"Error from server: Namespace \"default\" is forbidden: namespace can never be deleted\". \"namespace can never be deleted \" is a little confusing.\r\n","created_at":"2015-10-20T12:05:07Z","updated_at":"2015-10-20T21:19:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b745efa453f2f50a154e6fc71015366954f757f","assignee":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/15942/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/15942/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/15942/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/93798d5b4cea34bebdb92af42341db33bdff4f0d","head":{"label":"feihujiang:returnClearMessageWhenDeletingImmortalNamespace","ref":"returnClearMessageWhenDeletingImmortalNamespace","sha":"93798d5b4cea34bebdb92af42341db33bdff4f0d","user":{"login":"feihujiang","id":2322270,"avatar_url":"https://avatars.githubusercontent.com/u/2322270?v=3","gravatar_id":"","url":"https://api.github.com/users/feihujiang","html_url":"https://github.com/feihujiang","followers_url":"https://api.github.com/users/feihujiang/followers","following_url":"https://api.github.com/users/feihujiang/following{/other_user}","gists_url":"https://api.github.com/users/feihujiang/gists{/gist_id}","starred_url":"https://api.github.com/users/feihujiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feihujiang/subscriptions","organizations_url":"https://api.github.com/users/feihujiang/orgs","repos_url":"https://api.github.com/users/feihujiang/repos","events_url":"https://api.github.com/users/feihujiang/events{/privacy}","received_events_url":"https://api.github.com/users/feihujiang/received_events","type":"User","site_admin":false},"repo":{"id":32961171,"name":"kubernetes","full_name":"feihujiang/kubernetes","owner":{"login":"feihujiang","id":2322270,"avatar_url":"https://avatars.githubusercontent.com/u/2322270?v=3","gravatar_id":"","url":"https://api.github.com/users/feihujiang","html_url":"https://github.com/feihujiang","followers_url":"https://api.github.com/users/feihujiang/followers","following_url":"https://api.github.com/users/feihujiang/following{/other_user}","gists_url":"https://api.github.com/users/feihujiang/gists{/gist_id}","starred_url":"https://api.github.com/users/feihujiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feihujiang/subscriptions","organizations_url":"https://api.github.com/users/feihujiang/orgs","repos_url":"https://api.github.com/users/feihujiang/repos","events_url":"https://api.github.com/users/feihujiang/events{/privacy}","received_events_url":"https://api.github.com/users/feihujiang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/feihujiang/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/feihujiang/kubernetes","forks_url":"https://api.github.com/repos/feihujiang/kubernetes/forks","keys_url":"https://api.github.com/repos/feihujiang/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/feihujiang/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/feihujiang/kubernetes/teams","hooks_url":"https://api.github.com/repos/feihujiang/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/feihujiang/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/feihujiang/kubernetes/events","assignees_url":"https://api.github.com/repos/feihujiang/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/feihujiang/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/feihujiang/kubernetes/tags","blobs_url":"https://api.github.com/repos/feihujiang/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/feihujiang/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/feihujiang/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/feihujiang/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/feihujiang/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/feihujiang/kubernetes/languages","stargazers_url":"https://api.github.com/repos/feihujiang/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/feihujiang/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/feihujiang/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/feihujiang/kubernetes/subscription","commits_url":"https://api.github.com/repos/feihujiang/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/feihujiang/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/feihujiang/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/feihujiang/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/feihujiang/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/feihujiang/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/feihujiang/kubernetes/merges","archive_url":"https://api.github.com/repos/feihujiang/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/feihujiang/kubernetes/downloads","issues_url":"https://api.github.com/repos/feihujiang/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/feihujiang/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/feihujiang/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/feihujiang/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/feihujiang/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/feihujiang/kubernetes/releases{/id}","created_at":"2015-03-27T01:23:13Z","updated_at":"2015-06-14T00:12:32Z","pushed_at":"2015-10-20T12:01:48Z","git_url":"git://github.com/feihujiang/kubernetes.git","ssh_url":"git@github.com:feihujiang/kubernetes.git","clone_url":"https://github.com/feihujiang/kubernetes.git","svn_url":"https://github.com/feihujiang/kubernetes","homepage":"http://kubernetes.io","size":116764,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"0888c2ef38982dcd08cdc54a4e62dca23e3c1dfd","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-10-20T19:56:13Z","pushed_at":"2015-10-20T21:14:19Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":489242,"stargazers_count":10793,"watchers_count":10793,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2735,"mirror_url":null,"open_issues_count":2069,"forks":2735,"open_issues":2069,"watchers":10793,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/15942"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/15942"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/15942"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/15942/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/15942/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/15942/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/93798d5b4cea34bebdb92af42341db33bdff4f0d"}}}}