{"action":"created","comment":{"url":"https://api.github.com/repos/economist-components/component-footer/pulls/comments/40802362","id":40802362,"diff_hunk":"@@ -2,9 +2,18 @@ import React from 'react';\n import List from '@economist/component-list';\n import Icon from '@economist/component-icon';\n \n+function targetIfNeeded({ internal }) {","path":"index.es6","position":4,"original_position":4,"commit_id":"23a1f6aa4da50a12f60f886c8a270f2e25970158","original_commit_id":"23a1f6aa4da50a12f60f886c8a270f2e25970158","user":{"login":"keithamus","id":118266,"avatar_url":"https://avatars.githubusercontent.com/u/118266?v=3","gravatar_id":"","url":"https://api.github.com/users/keithamus","html_url":"https://github.com/keithamus","followers_url":"https://api.github.com/users/keithamus/followers","following_url":"https://api.github.com/users/keithamus/following{/other_user}","gists_url":"https://api.github.com/users/keithamus/gists{/gist_id}","starred_url":"https://api.github.com/users/keithamus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keithamus/subscriptions","organizations_url":"https://api.github.com/users/keithamus/orgs","repos_url":"https://api.github.com/users/keithamus/repos","events_url":"https://api.github.com/users/keithamus/events{/privacy}","received_events_url":"https://api.github.com/users/keithamus/received_events","type":"User","site_admin":false},"body":"Can we avoid having a bunch of private methods btw, A) it makes them hard to test if we need to, B) there's no point, especially with React where components dont really expose an API, C) its messier when reading the file.","created_at":"2015-09-30T14:44:29Z","updated_at":"2015-09-30T14:44:29Z","html_url":"https://github.com/economist-components/component-footer/pull/14#discussion_r40802362","pull_request_url":"https://api.github.com/repos/economist-components/component-footer/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/economist-components/component-footer/pulls/comments/40802362"},"html":{"href":"https://github.com/economist-components/component-footer/pull/14#discussion_r40802362"},"pull_request":{"href":"https://api.github.com/repos/economist-components/component-footer/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/economist-components/component-footer/pulls/14","id":46400382,"html_url":"https://github.com/economist-components/component-footer/pull/14","diff_url":"https://github.com/economist-components/component-footer/pull/14.diff","patch_url":"https://github.com/economist-components/component-footer/pull/14.patch","issue_url":"https://api.github.com/repos/economist-components/component-footer/issues/14","number":14,"state":"open","locked":false,"title":"Add target=\"_blank\" to links if they're not internal.","user":{"login":"fabiosantoscode","id":1611595,"avatar_url":"https://avatars.githubusercontent.com/u/1611595?v=3","gravatar_id":"","url":"https://api.github.com/users/fabiosantoscode","html_url":"https://github.com/fabiosantoscode","followers_url":"https://api.github.com/users/fabiosantoscode/followers","following_url":"https://api.github.com/users/fabiosantoscode/following{/other_user}","gists_url":"https://api.github.com/users/fabiosantoscode/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiosantoscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiosantoscode/subscriptions","organizations_url":"https://api.github.com/users/fabiosantoscode/orgs","repos_url":"https://api.github.com/users/fabiosantoscode/repos","events_url":"https://api.github.com/users/fabiosantoscode/events{/privacy}","received_events_url":"https://api.github.com/users/fabiosantoscode/received_events","type":"User","site_admin":false},"body":"Also, did some cleanup","created_at":"2015-09-30T13:21:10Z","updated_at":"2015-09-30T14:44:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5882a687eb13e7c206b56c239a54672c4e3a37e6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/economist-components/component-footer/pulls/14/commits","review_comments_url":"https://api.github.com/repos/economist-components/component-footer/pulls/14/comments","review_comment_url":"https://api.github.com/repos/economist-components/component-footer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/economist-components/component-footer/issues/14/comments","statuses_url":"https://api.github.com/repos/economist-components/component-footer/statuses/23a1f6aa4da50a12f60f886c8a270f2e25970158","head":{"label":"fabiosantoscode:master","ref":"master","sha":"23a1f6aa4da50a12f60f886c8a270f2e25970158","user":{"login":"fabiosantoscode","id":1611595,"avatar_url":"https://avatars.githubusercontent.com/u/1611595?v=3","gravatar_id":"","url":"https://api.github.com/users/fabiosantoscode","html_url":"https://github.com/fabiosantoscode","followers_url":"https://api.github.com/users/fabiosantoscode/followers","following_url":"https://api.github.com/users/fabiosantoscode/following{/other_user}","gists_url":"https://api.github.com/users/fabiosantoscode/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiosantoscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiosantoscode/subscriptions","organizations_url":"https://api.github.com/users/fabiosantoscode/orgs","repos_url":"https://api.github.com/users/fabiosantoscode/repos","events_url":"https://api.github.com/users/fabiosantoscode/events{/privacy}","received_events_url":"https://api.github.com/users/fabiosantoscode/received_events","type":"User","site_admin":false},"repo":{"id":42459946,"name":"component-footer","full_name":"fabiosantoscode/component-footer","owner":{"login":"fabiosantoscode","id":1611595,"avatar_url":"https://avatars.githubusercontent.com/u/1611595?v=3","gravatar_id":"","url":"https://api.github.com/users/fabiosantoscode","html_url":"https://github.com/fabiosantoscode","followers_url":"https://api.github.com/users/fabiosantoscode/followers","following_url":"https://api.github.com/users/fabiosantoscode/following{/other_user}","gists_url":"https://api.github.com/users/fabiosantoscode/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiosantoscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiosantoscode/subscriptions","organizations_url":"https://api.github.com/users/fabiosantoscode/orgs","repos_url":"https://api.github.com/users/fabiosantoscode/repos","events_url":"https://api.github.com/users/fabiosantoscode/events{/privacy}","received_events_url":"https://api.github.com/users/fabiosantoscode/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fabiosantoscode/component-footer","description":"","fork":true,"url":"https://api.github.com/repos/fabiosantoscode/component-footer","forks_url":"https://api.github.com/repos/fabiosantoscode/component-footer/forks","keys_url":"https://api.github.com/repos/fabiosantoscode/component-footer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabiosantoscode/component-footer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabiosantoscode/component-footer/teams","hooks_url":"https://api.github.com/repos/fabiosantoscode/component-footer/hooks","issue_events_url":"https://api.github.com/repos/fabiosantoscode/component-footer/issues/events{/number}","events_url":"https://api.github.com/repos/fabiosantoscode/component-footer/events","assignees_url":"https://api.github.com/repos/fabiosantoscode/component-footer/assignees{/user}","branches_url":"https://api.github.com/repos/fabiosantoscode/component-footer/branches{/branch}","tags_url":"https://api.github.com/repos/fabiosantoscode/component-footer/tags","blobs_url":"https://api.github.com/repos/fabiosantoscode/component-footer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabiosantoscode/component-footer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabiosantoscode/component-footer/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabiosantoscode/component-footer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabiosantoscode/component-footer/statuses/{sha}","languages_url":"https://api.github.com/repos/fabiosantoscode/component-footer/languages","stargazers_url":"https://api.github.com/repos/fabiosantoscode/component-footer/stargazers","contributors_url":"https://api.github.com/repos/fabiosantoscode/component-footer/contributors","subscribers_url":"https://api.github.com/repos/fabiosantoscode/component-footer/subscribers","subscription_url":"https://api.github.com/repos/fabiosantoscode/component-footer/subscription","commits_url":"https://api.github.com/repos/fabiosantoscode/component-footer/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabiosantoscode/component-footer/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabiosantoscode/component-footer/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabiosantoscode/component-footer/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabiosantoscode/component-footer/contents/{+path}","compare_url":"https://api.github.com/repos/fabiosantoscode/component-footer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabiosantoscode/component-footer/merges","archive_url":"https://api.github.com/repos/fabiosantoscode/component-footer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabiosantoscode/component-footer/downloads","issues_url":"https://api.github.com/repos/fabiosantoscode/component-footer/issues{/number}","pulls_url":"https://api.github.com/repos/fabiosantoscode/component-footer/pulls{/number}","milestones_url":"https://api.github.com/repos/fabiosantoscode/component-footer/milestones{/number}","notifications_url":"https://api.github.com/repos/fabiosantoscode/component-footer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabiosantoscode/component-footer/labels{/name}","releases_url":"https://api.github.com/repos/fabiosantoscode/component-footer/releases{/id}","created_at":"2015-09-14T16:03:21Z","updated_at":"2015-09-14T16:03:22Z","pushed_at":"2015-09-30T14:38:42Z","git_url":"git://github.com/fabiosantoscode/component-footer.git","ssh_url":"git@github.com:fabiosantoscode/component-footer.git","clone_url":"https://github.com/fabiosantoscode/component-footer.git","svn_url":"https://github.com/fabiosantoscode/component-footer","homepage":null,"size":302,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"economist-components:master","ref":"master","sha":"05f7d9e759c556aba27b3e2f89bfa4dc6c101d6d","user":{"login":"economist-components","id":14197671,"avatar_url":"https://avatars.githubusercontent.com/u/14197671?v=3","gravatar_id":"","url":"https://api.github.com/users/economist-components","html_url":"https://github.com/economist-components","followers_url":"https://api.github.com/users/economist-components/followers","following_url":"https://api.github.com/users/economist-components/following{/other_user}","gists_url":"https://api.github.com/users/economist-components/gists{/gist_id}","starred_url":"https://api.github.com/users/economist-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/economist-components/subscriptions","organizations_url":"https://api.github.com/users/economist-components/orgs","repos_url":"https://api.github.com/users/economist-components/repos","events_url":"https://api.github.com/users/economist-components/events{/privacy}","received_events_url":"https://api.github.com/users/economist-components/received_events","type":"Organization","site_admin":false},"repo":{"id":42312306,"name":"component-footer","full_name":"economist-components/component-footer","owner":{"login":"economist-components","id":14197671,"avatar_url":"https://avatars.githubusercontent.com/u/14197671?v=3","gravatar_id":"","url":"https://api.github.com/users/economist-components","html_url":"https://github.com/economist-components","followers_url":"https://api.github.com/users/economist-components/followers","following_url":"https://api.github.com/users/economist-components/following{/other_user}","gists_url":"https://api.github.com/users/economist-components/gists{/gist_id}","starred_url":"https://api.github.com/users/economist-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/economist-components/subscriptions","organizations_url":"https://api.github.com/users/economist-components/orgs","repos_url":"https://api.github.com/users/economist-components/repos","events_url":"https://api.github.com/users/economist-components/events{/privacy}","received_events_url":"https://api.github.com/users/economist-components/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/economist-components/component-footer","description":"","fork":false,"url":"https://api.github.com/repos/economist-components/component-footer","forks_url":"https://api.github.com/repos/economist-components/component-footer/forks","keys_url":"https://api.github.com/repos/economist-components/component-footer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/economist-components/component-footer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/economist-components/component-footer/teams","hooks_url":"https://api.github.com/repos/economist-components/component-footer/hooks","issue_events_url":"https://api.github.com/repos/economist-components/component-footer/issues/events{/number}","events_url":"https://api.github.com/repos/economist-components/component-footer/events","assignees_url":"https://api.github.com/repos/economist-components/component-footer/assignees{/user}","branches_url":"https://api.github.com/repos/economist-components/component-footer/branches{/branch}","tags_url":"https://api.github.com/repos/economist-components/component-footer/tags","blobs_url":"https://api.github.com/repos/economist-components/component-footer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/economist-components/component-footer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/economist-components/component-footer/git/refs{/sha}","trees_url":"https://api.github.com/repos/economist-components/component-footer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/economist-components/component-footer/statuses/{sha}","languages_url":"https://api.github.com/repos/economist-components/component-footer/languages","stargazers_url":"https://api.github.com/repos/economist-components/component-footer/stargazers","contributors_url":"https://api.github.com/repos/economist-components/component-footer/contributors","subscribers_url":"https://api.github.com/repos/economist-components/component-footer/subscribers","subscription_url":"https://api.github.com/repos/economist-components/component-footer/subscription","commits_url":"https://api.github.com/repos/economist-components/component-footer/commits{/sha}","git_commits_url":"https://api.github.com/repos/economist-components/component-footer/git/commits{/sha}","comments_url":"https://api.github.com/repos/economist-components/component-footer/comments{/number}","issue_comment_url":"https://api.github.com/repos/economist-components/component-footer/issues/comments{/number}","contents_url":"https://api.github.com/repos/economist-components/component-footer/contents/{+path}","compare_url":"https://api.github.com/repos/economist-components/component-footer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/economist-components/component-footer/merges","archive_url":"https://api.github.com/repos/economist-components/component-footer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/economist-components/component-footer/downloads","issues_url":"https://api.github.com/repos/economist-components/component-footer/issues{/number}","pulls_url":"https://api.github.com/repos/economist-components/component-footer/pulls{/number}","milestones_url":"https://api.github.com/repos/economist-components/component-footer/milestones{/number}","notifications_url":"https://api.github.com/repos/economist-components/component-footer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/economist-components/component-footer/labels{/name}","releases_url":"https://api.github.com/repos/economist-components/component-footer/releases{/id}","created_at":"2015-09-11T14:11:56Z","updated_at":"2015-09-14T14:45:39Z","pushed_at":"2015-09-30T14:38:43Z","git_url":"git://github.com/economist-components/component-footer.git","ssh_url":"git@github.com:economist-components/component-footer.git","clone_url":"https://github.com/economist-components/component-footer.git","svn_url":"https://github.com/economist-components/component-footer","homepage":null,"size":949,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/economist-components/component-footer/pulls/14"},"html":{"href":"https://github.com/economist-components/component-footer/pull/14"},"issue":{"href":"https://api.github.com/repos/economist-components/component-footer/issues/14"},"comments":{"href":"https://api.github.com/repos/economist-components/component-footer/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/economist-components/component-footer/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/economist-components/component-footer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/economist-components/component-footer/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/economist-components/component-footer/statuses/23a1f6aa4da50a12f60f886c8a270f2e25970158"}}}}