{"action":"created","comment":{"url":"https://api.github.com/repos/scaleway/scaleway-cli/pulls/comments/42254289","id":42254289,"diff_hunk":"@@ -179,38 +180,15 @@ func RemoveDuplicates(elements []string) []string {\n \treturn result\n }\n \n-const termjsBin string = \"termjs-cli\"\n-\n-// AttachToSerial tries to connect to server serial using 'term.js-cli' and fallback with a help message\n+// AttachToSerial tries to connect to server serial using 'gotty-client' and fallback with a help message\n func AttachToSerial(serverID string, apiToken string, attachStdin bool) error {\n-\ttermjsURL := fmt.Sprintf(\"https://tty.cloud.online.net?server_id=%s&type=serial&auth_token=%s\", serverID, apiToken)\n+\tURL := fmt.Sprintf(\"https://tty.cloud.online.net/?arg=%s&arg=%s\", apiToken, serverID)","path":"pkg/utils/utils.go","position":18,"original_position":18,"commit_id":"a749255594f5a50b9b85254694403dac16376f95","original_commit_id":"a749255594f5a50b9b85254694403dac16376f95","user":{"login":"moul","id":94029,"avatar_url":"https://avatars.githubusercontent.com/u/94029?v=3","gravatar_id":"","url":"https://api.github.com/users/moul","html_url":"https://github.com/moul","followers_url":"https://api.github.com/users/moul/followers","following_url":"https://api.github.com/users/moul/following{/other_user}","gists_url":"https://api.github.com/users/moul/gists{/gist_id}","starred_url":"https://api.github.com/users/moul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moul/subscriptions","organizations_url":"https://api.github.com/users/moul/orgs","repos_url":"https://api.github.com/users/moul/repos","events_url":"https://api.github.com/users/moul/events{/privacy}","received_events_url":"https://api.github.com/users/moul/received_events","type":"User","site_admin":false},"body":"The URL will be different","created_at":"2015-10-16T15:19:48Z","updated_at":"2015-10-16T15:19:48Z","html_url":"https://github.com/scaleway/scaleway-cli/pull/219#discussion_r42254289","pull_request_url":"https://api.github.com/repos/scaleway/scaleway-cli/pulls/219","_links":{"self":{"href":"https://api.github.com/repos/scaleway/scaleway-cli/pulls/comments/42254289"},"html":{"href":"https://github.com/scaleway/scaleway-cli/pull/219#discussion_r42254289"},"pull_request":{"href":"https://api.github.com/repos/scaleway/scaleway-cli/pulls/219"}}},"pull_request":{"url":"https://api.github.com/repos/scaleway/scaleway-cli/pulls/219","id":47923165,"html_url":"https://github.com/scaleway/scaleway-cli/pull/219","diff_url":"https://github.com/scaleway/scaleway-cli/pull/219.diff","patch_url":"https://github.com/scaleway/scaleway-cli/pull/219.patch","issue_url":"https://api.github.com/repos/scaleway/scaleway-cli/issues/219","number":219,"state":"open","locked":false,"title":"Use gotty-client instead of termjs-cli","user":{"login":"QuentinPerez","id":3081204,"avatar_url":"https://avatars.githubusercontent.com/u/3081204?v=3","gravatar_id":"","url":"https://api.github.com/users/QuentinPerez","html_url":"https://github.com/QuentinPerez","followers_url":"https://api.github.com/users/QuentinPerez/followers","following_url":"https://api.github.com/users/QuentinPerez/following{/other_user}","gists_url":"https://api.github.com/users/QuentinPerez/gists{/gist_id}","starred_url":"https://api.github.com/users/QuentinPerez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuentinPerez/subscriptions","organizations_url":"https://api.github.com/users/QuentinPerez/orgs","repos_url":"https://api.github.com/users/QuentinPerez/repos","events_url":"https://api.github.com/users/QuentinPerez/events{/privacy}","received_events_url":"https://api.github.com/users/QuentinPerez/received_events","type":"User","site_admin":false},"body":"#160\r\n\r\n:warning: Don't merge yet :warning: ","created_at":"2015-10-16T15:15:48Z","updated_at":"2015-10-16T15:19:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c0b33cc40b85448bd6b3d682fc80f803d8e0a17","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scaleway/scaleway-cli/pulls/219/commits","review_comments_url":"https://api.github.com/repos/scaleway/scaleway-cli/pulls/219/comments","review_comment_url":"https://api.github.com/repos/scaleway/scaleway-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scaleway/scaleway-cli/issues/219/comments","statuses_url":"https://api.github.com/repos/scaleway/scaleway-cli/statuses/a749255594f5a50b9b85254694403dac16376f95","head":{"label":"QuentinPerez:gotty-client","ref":"gotty-client","sha":"a749255594f5a50b9b85254694403dac16376f95","user":{"login":"QuentinPerez","id":3081204,"avatar_url":"https://avatars.githubusercontent.com/u/3081204?v=3","gravatar_id":"","url":"https://api.github.com/users/QuentinPerez","html_url":"https://github.com/QuentinPerez","followers_url":"https://api.github.com/users/QuentinPerez/followers","following_url":"https://api.github.com/users/QuentinPerez/following{/other_user}","gists_url":"https://api.github.com/users/QuentinPerez/gists{/gist_id}","starred_url":"https://api.github.com/users/QuentinPerez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuentinPerez/subscriptions","organizations_url":"https://api.github.com/users/QuentinPerez/orgs","repos_url":"https://api.github.com/users/QuentinPerez/repos","events_url":"https://api.github.com/users/QuentinPerez/events{/privacy}","received_events_url":"https://api.github.com/users/QuentinPerez/received_events","type":"User","site_admin":false},"repo":{"id":43368420,"name":"scaleway-cli","full_name":"QuentinPerez/scaleway-cli","owner":{"login":"QuentinPerez","id":3081204,"avatar_url":"https://avatars.githubusercontent.com/u/3081204?v=3","gravatar_id":"","url":"https://api.github.com/users/QuentinPerez","html_url":"https://github.com/QuentinPerez","followers_url":"https://api.github.com/users/QuentinPerez/followers","following_url":"https://api.github.com/users/QuentinPerez/following{/other_user}","gists_url":"https://api.github.com/users/QuentinPerez/gists{/gist_id}","starred_url":"https://api.github.com/users/QuentinPerez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuentinPerez/subscriptions","organizations_url":"https://api.github.com/users/QuentinPerez/orgs","repos_url":"https://api.github.com/users/QuentinPerez/repos","events_url":"https://api.github.com/users/QuentinPerez/events{/privacy}","received_events_url":"https://api.github.com/users/QuentinPerez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/QuentinPerez/scaleway-cli","description":":computer: Manage BareMetal Servers from Command Line (as easily as with Docker)","fork":true,"url":"https://api.github.com/repos/QuentinPerez/scaleway-cli","forks_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/forks","keys_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/teams","hooks_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/hooks","issue_events_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/issues/events{/number}","events_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/events","assignees_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/assignees{/user}","branches_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/branches{/branch}","tags_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/tags","blobs_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/languages","stargazers_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/stargazers","contributors_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/contributors","subscribers_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/subscribers","subscription_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/subscription","commits_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/contents/{+path}","compare_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/merges","archive_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/downloads","issues_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/issues{/number}","pulls_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/labels{/name}","releases_url":"https://api.github.com/repos/QuentinPerez/scaleway-cli/releases{/id}","created_at":"2015-09-29T13:16:52Z","updated_at":"2015-09-29T13:16:53Z","pushed_at":"2015-10-16T15:14:52Z","git_url":"git://github.com/QuentinPerez/scaleway-cli.git","ssh_url":"git@github.com:QuentinPerez/scaleway-cli.git","clone_url":"https://github.com/QuentinPerez/scaleway-cli.git","svn_url":"https://github.com/QuentinPerez/scaleway-cli","homepage":"https://blog.scaleway.com/2015/05/20/manage-baremetal-servers-with-scaleway-cli/","size":2073,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scaleway:master","ref":"master","sha":"7a1add2f91649b0734f4621022293b50faaf6f0b","user":{"login":"scaleway","id":5185491,"avatar_url":"https://avatars.githubusercontent.com/u/5185491?v=3","gravatar_id":"","url":"https://api.github.com/users/scaleway","html_url":"https://github.com/scaleway","followers_url":"https://api.github.com/users/scaleway/followers","following_url":"https://api.github.com/users/scaleway/following{/other_user}","gists_url":"https://api.github.com/users/scaleway/gists{/gist_id}","starred_url":"https://api.github.com/users/scaleway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scaleway/subscriptions","organizations_url":"https://api.github.com/users/scaleway/orgs","repos_url":"https://api.github.com/users/scaleway/repos","events_url":"https://api.github.com/users/scaleway/events{/privacy}","received_events_url":"https://api.github.com/users/scaleway/received_events","type":"Organization","site_admin":false},"repo":{"id":32575663,"name":"scaleway-cli","full_name":"scaleway/scaleway-cli","owner":{"login":"scaleway","id":5185491,"avatar_url":"https://avatars.githubusercontent.com/u/5185491?v=3","gravatar_id":"","url":"https://api.github.com/users/scaleway","html_url":"https://github.com/scaleway","followers_url":"https://api.github.com/users/scaleway/followers","following_url":"https://api.github.com/users/scaleway/following{/other_user}","gists_url":"https://api.github.com/users/scaleway/gists{/gist_id}","starred_url":"https://api.github.com/users/scaleway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scaleway/subscriptions","organizations_url":"https://api.github.com/users/scaleway/orgs","repos_url":"https://api.github.com/users/scaleway/repos","events_url":"https://api.github.com/users/scaleway/events{/privacy}","received_events_url":"https://api.github.com/users/scaleway/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scaleway/scaleway-cli","description":":computer: Manage BareMetal Servers from Command Line (as easily as with Docker)","fork":false,"url":"https://api.github.com/repos/scaleway/scaleway-cli","forks_url":"https://api.github.com/repos/scaleway/scaleway-cli/forks","keys_url":"https://api.github.com/repos/scaleway/scaleway-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scaleway/scaleway-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scaleway/scaleway-cli/teams","hooks_url":"https://api.github.com/repos/scaleway/scaleway-cli/hooks","issue_events_url":"https://api.github.com/repos/scaleway/scaleway-cli/issues/events{/number}","events_url":"https://api.github.com/repos/scaleway/scaleway-cli/events","assignees_url":"https://api.github.com/repos/scaleway/scaleway-cli/assignees{/user}","branches_url":"https://api.github.com/repos/scaleway/scaleway-cli/branches{/branch}","tags_url":"https://api.github.com/repos/scaleway/scaleway-cli/tags","blobs_url":"https://api.github.com/repos/scaleway/scaleway-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scaleway/scaleway-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scaleway/scaleway-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/scaleway/scaleway-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scaleway/scaleway-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/scaleway/scaleway-cli/languages","stargazers_url":"https://api.github.com/repos/scaleway/scaleway-cli/stargazers","contributors_url":"https://api.github.com/repos/scaleway/scaleway-cli/contributors","subscribers_url":"https://api.github.com/repos/scaleway/scaleway-cli/subscribers","subscription_url":"https://api.github.com/repos/scaleway/scaleway-cli/subscription","commits_url":"https://api.github.com/repos/scaleway/scaleway-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/scaleway/scaleway-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/scaleway/scaleway-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/scaleway/scaleway-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/scaleway/scaleway-cli/contents/{+path}","compare_url":"https://api.github.com/repos/scaleway/scaleway-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scaleway/scaleway-cli/merges","archive_url":"https://api.github.com/repos/scaleway/scaleway-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scaleway/scaleway-cli/downloads","issues_url":"https://api.github.com/repos/scaleway/scaleway-cli/issues{/number}","pulls_url":"https://api.github.com/repos/scaleway/scaleway-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/scaleway/scaleway-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/scaleway/scaleway-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scaleway/scaleway-cli/labels{/name}","releases_url":"https://api.github.com/repos/scaleway/scaleway-cli/releases{/id}","created_at":"2015-03-20T09:45:50Z","updated_at":"2015-10-15T18:44:16Z","pushed_at":"2015-10-16T15:15:49Z","git_url":"git://github.com/scaleway/scaleway-cli.git","ssh_url":"git@github.com:scaleway/scaleway-cli.git","clone_url":"https://github.com/scaleway/scaleway-cli.git","svn_url":"https://github.com/scaleway/scaleway-cli","homepage":"https://blog.scaleway.com/2015/05/20/manage-baremetal-servers-with-scaleway-cli/","size":3175,"stargazers_count":70,"watchers_count":70,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":39,"forks":8,"open_issues":39,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scaleway/scaleway-cli/pulls/219"},"html":{"href":"https://github.com/scaleway/scaleway-cli/pull/219"},"issue":{"href":"https://api.github.com/repos/scaleway/scaleway-cli/issues/219"},"comments":{"href":"https://api.github.com/repos/scaleway/scaleway-cli/issues/219/comments"},"review_comments":{"href":"https://api.github.com/repos/scaleway/scaleway-cli/pulls/219/comments"},"review_comment":{"href":"https://api.github.com/repos/scaleway/scaleway-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scaleway/scaleway-cli/pulls/219/commits"},"statuses":{"href":"https://api.github.com/repos/scaleway/scaleway-cli/statuses/a749255594f5a50b9b85254694403dac16376f95"}}}}