{"action":"closed","number":490,"pull_request":{"url":"https://api.github.com/repos/mizzy/specinfra/pulls/490","id":47343347,"html_url":"https://github.com/mizzy/specinfra/pull/490","diff_url":"https://github.com/mizzy/specinfra/pull/490.diff","patch_url":"https://github.com/mizzy/specinfra/pull/490.patch","issue_url":"https://api.github.com/repos/mizzy/specinfra/issues/490","number":490,"state":"closed","locked":false,"title":"mail_alias: Replacing the trailing $ with (,|$) to match single entries","user":{"login":"uroesch","id":12977873,"avatar_url":"https://avatars.githubusercontent.com/u/12977873?v=3","gravatar_id":"","url":"https://api.github.com/users/uroesch","html_url":"https://github.com/uroesch","followers_url":"https://api.github.com/users/uroesch/followers","following_url":"https://api.github.com/users/uroesch/following{/other_user}","gists_url":"https://api.github.com/users/uroesch/gists{/gist_id}","starred_url":"https://api.github.com/users/uroesch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uroesch/subscriptions","organizations_url":"https://api.github.com/users/uroesch/orgs","repos_url":"https://api.github.com/users/uroesch/repos","events_url":"https://api.github.com/users/uroesch/events{/privacy}","received_events_url":"https://api.github.com/users/uroesch/received_events","type":"User","site_admin":false},"body":" Currently entries in the /etc/alias file that look like this\r\n\r\n   myalias:     foo, bar, batz\r\n\r\n can only be parsed in the exact order:\r\n\r\n   describe mail_alias('myalias') do\r\n     it { should be_aliased_to('foo, bar, batz') }\r\n   end\r\n\r\n If the order changes or more white space is added the whole thing falls apart.\r\n\r\n Replacing the $ with (,|$) at the end of the egrep allows for more flexibilty:\r\n\r\n   describe mail_alias('myalias') do\r\n     it { should be_aliased_to('batz')\r\n     it { should be_aliased_to('foo')\r\n     it { should be_aliased_to('bar')\r\n   end\r\n\r\n  The order becomes irrelevant.\r\n\r\n  This scheme has been tested against the following patterns:\r\n    myalias:         foo, bar, batz\r\n    myalias:         foo, bar, batz\r\n    myalias:         foo , bar , batz\r\n    myalias:         foo\r\n    myalias:         /foo/bar, /bar/foo\r\n    myalias:         \"|/foo/bar\", '|/bar/foo'\r\n    myalias:         foo bar, batz, foo, bar","created_at":"2015-10-10T10:59:04Z","updated_at":"2015-10-11T11:49:50Z","closed_at":"2015-10-11T11:49:50Z","merged_at":"2015-10-11T11:49:50Z","merge_commit_sha":"c3d60774a1fba5a294759b4831abc0988a7d528c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mizzy/specinfra/pulls/490/commits","review_comments_url":"https://api.github.com/repos/mizzy/specinfra/pulls/490/comments","review_comment_url":"https://api.github.com/repos/mizzy/specinfra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mizzy/specinfra/issues/490/comments","statuses_url":"https://api.github.com/repos/mizzy/specinfra/statuses/6ce066c6f8398edd480e02c764dd2e35306ee70d","head":{"label":"uroesch:mail_alias","ref":"mail_alias","sha":"6ce066c6f8398edd480e02c764dd2e35306ee70d","user":{"login":"uroesch","id":12977873,"avatar_url":"https://avatars.githubusercontent.com/u/12977873?v=3","gravatar_id":"","url":"https://api.github.com/users/uroesch","html_url":"https://github.com/uroesch","followers_url":"https://api.github.com/users/uroesch/followers","following_url":"https://api.github.com/users/uroesch/following{/other_user}","gists_url":"https://api.github.com/users/uroesch/gists{/gist_id}","starred_url":"https://api.github.com/users/uroesch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uroesch/subscriptions","organizations_url":"https://api.github.com/users/uroesch/orgs","repos_url":"https://api.github.com/users/uroesch/repos","events_url":"https://api.github.com/users/uroesch/events{/privacy}","received_events_url":"https://api.github.com/users/uroesch/received_events","type":"User","site_admin":false},"repo":{"id":37769004,"name":"specinfra","full_name":"uroesch/specinfra","owner":{"login":"uroesch","id":12977873,"avatar_url":"https://avatars.githubusercontent.com/u/12977873?v=3","gravatar_id":"","url":"https://api.github.com/users/uroesch","html_url":"https://github.com/uroesch","followers_url":"https://api.github.com/users/uroesch/followers","following_url":"https://api.github.com/users/uroesch/following{/other_user}","gists_url":"https://api.github.com/users/uroesch/gists{/gist_id}","starred_url":"https://api.github.com/users/uroesch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uroesch/subscriptions","organizations_url":"https://api.github.com/users/uroesch/orgs","repos_url":"https://api.github.com/users/uroesch/repos","events_url":"https://api.github.com/users/uroesch/events{/privacy}","received_events_url":"https://api.github.com/users/uroesch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/uroesch/specinfra","description":"Command Execution Framework for serverspec, itamae and so on","fork":true,"url":"https://api.github.com/repos/uroesch/specinfra","forks_url":"https://api.github.com/repos/uroesch/specinfra/forks","keys_url":"https://api.github.com/repos/uroesch/specinfra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uroesch/specinfra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uroesch/specinfra/teams","hooks_url":"https://api.github.com/repos/uroesch/specinfra/hooks","issue_events_url":"https://api.github.com/repos/uroesch/specinfra/issues/events{/number}","events_url":"https://api.github.com/repos/uroesch/specinfra/events","assignees_url":"https://api.github.com/repos/uroesch/specinfra/assignees{/user}","branches_url":"https://api.github.com/repos/uroesch/specinfra/branches{/branch}","tags_url":"https://api.github.com/repos/uroesch/specinfra/tags","blobs_url":"https://api.github.com/repos/uroesch/specinfra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uroesch/specinfra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uroesch/specinfra/git/refs{/sha}","trees_url":"https://api.github.com/repos/uroesch/specinfra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uroesch/specinfra/statuses/{sha}","languages_url":"https://api.github.com/repos/uroesch/specinfra/languages","stargazers_url":"https://api.github.com/repos/uroesch/specinfra/stargazers","contributors_url":"https://api.github.com/repos/uroesch/specinfra/contributors","subscribers_url":"https://api.github.com/repos/uroesch/specinfra/subscribers","subscription_url":"https://api.github.com/repos/uroesch/specinfra/subscription","commits_url":"https://api.github.com/repos/uroesch/specinfra/commits{/sha}","git_commits_url":"https://api.github.com/repos/uroesch/specinfra/git/commits{/sha}","comments_url":"https://api.github.com/repos/uroesch/specinfra/comments{/number}","issue_comment_url":"https://api.github.com/repos/uroesch/specinfra/issues/comments{/number}","contents_url":"https://api.github.com/repos/uroesch/specinfra/contents/{+path}","compare_url":"https://api.github.com/repos/uroesch/specinfra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uroesch/specinfra/merges","archive_url":"https://api.github.com/repos/uroesch/specinfra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uroesch/specinfra/downloads","issues_url":"https://api.github.com/repos/uroesch/specinfra/issues{/number}","pulls_url":"https://api.github.com/repos/uroesch/specinfra/pulls{/number}","milestones_url":"https://api.github.com/repos/uroesch/specinfra/milestones{/number}","notifications_url":"https://api.github.com/repos/uroesch/specinfra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uroesch/specinfra/labels{/name}","releases_url":"https://api.github.com/repos/uroesch/specinfra/releases{/id}","created_at":"2015-06-20T12:24:04Z","updated_at":"2015-06-20T12:24:05Z","pushed_at":"2015-10-11T00:23:03Z","git_url":"git://github.com/uroesch/specinfra.git","ssh_url":"git@github.com:uroesch/specinfra.git","clone_url":"https://github.com/uroesch/specinfra.git","svn_url":"https://github.com/uroesch/specinfra","homepage":"http://serverspec.org/","size":1499,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mizzy:master","ref":"master","sha":"82260938145ebee400187ce617caebdf65ccec0d","user":{"login":"mizzy","id":3620,"avatar_url":"https://avatars.githubusercontent.com/u/3620?v=3","gravatar_id":"","url":"https://api.github.com/users/mizzy","html_url":"https://github.com/mizzy","followers_url":"https://api.github.com/users/mizzy/followers","following_url":"https://api.github.com/users/mizzy/following{/other_user}","gists_url":"https://api.github.com/users/mizzy/gists{/gist_id}","starred_url":"https://api.github.com/users/mizzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mizzy/subscriptions","organizations_url":"https://api.github.com/users/mizzy/orgs","repos_url":"https://api.github.com/users/mizzy/repos","events_url":"https://api.github.com/users/mizzy/events{/privacy}","received_events_url":"https://api.github.com/users/mizzy/received_events","type":"User","site_admin":false},"repo":{"id":14747279,"name":"specinfra","full_name":"mizzy/specinfra","owner":{"login":"mizzy","id":3620,"avatar_url":"https://avatars.githubusercontent.com/u/3620?v=3","gravatar_id":"","url":"https://api.github.com/users/mizzy","html_url":"https://github.com/mizzy","followers_url":"https://api.github.com/users/mizzy/followers","following_url":"https://api.github.com/users/mizzy/following{/other_user}","gists_url":"https://api.github.com/users/mizzy/gists{/gist_id}","starred_url":"https://api.github.com/users/mizzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mizzy/subscriptions","organizations_url":"https://api.github.com/users/mizzy/orgs","repos_url":"https://api.github.com/users/mizzy/repos","events_url":"https://api.github.com/users/mizzy/events{/privacy}","received_events_url":"https://api.github.com/users/mizzy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mizzy/specinfra","description":"Command Execution Framework for serverspec, itamae and so on","fork":false,"url":"https://api.github.com/repos/mizzy/specinfra","forks_url":"https://api.github.com/repos/mizzy/specinfra/forks","keys_url":"https://api.github.com/repos/mizzy/specinfra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mizzy/specinfra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mizzy/specinfra/teams","hooks_url":"https://api.github.com/repos/mizzy/specinfra/hooks","issue_events_url":"https://api.github.com/repos/mizzy/specinfra/issues/events{/number}","events_url":"https://api.github.com/repos/mizzy/specinfra/events","assignees_url":"https://api.github.com/repos/mizzy/specinfra/assignees{/user}","branches_url":"https://api.github.com/repos/mizzy/specinfra/branches{/branch}","tags_url":"https://api.github.com/repos/mizzy/specinfra/tags","blobs_url":"https://api.github.com/repos/mizzy/specinfra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mizzy/specinfra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mizzy/specinfra/git/refs{/sha}","trees_url":"https://api.github.com/repos/mizzy/specinfra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mizzy/specinfra/statuses/{sha}","languages_url":"https://api.github.com/repos/mizzy/specinfra/languages","stargazers_url":"https://api.github.com/repos/mizzy/specinfra/stargazers","contributors_url":"https://api.github.com/repos/mizzy/specinfra/contributors","subscribers_url":"https://api.github.com/repos/mizzy/specinfra/subscribers","subscription_url":"https://api.github.com/repos/mizzy/specinfra/subscription","commits_url":"https://api.github.com/repos/mizzy/specinfra/commits{/sha}","git_commits_url":"https://api.github.com/repos/mizzy/specinfra/git/commits{/sha}","comments_url":"https://api.github.com/repos/mizzy/specinfra/comments{/number}","issue_comment_url":"https://api.github.com/repos/mizzy/specinfra/issues/comments{/number}","contents_url":"https://api.github.com/repos/mizzy/specinfra/contents/{+path}","compare_url":"https://api.github.com/repos/mizzy/specinfra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mizzy/specinfra/merges","archive_url":"https://api.github.com/repos/mizzy/specinfra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mizzy/specinfra/downloads","issues_url":"https://api.github.com/repos/mizzy/specinfra/issues{/number}","pulls_url":"https://api.github.com/repos/mizzy/specinfra/pulls{/number}","milestones_url":"https://api.github.com/repos/mizzy/specinfra/milestones{/number}","notifications_url":"https://api.github.com/repos/mizzy/specinfra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mizzy/specinfra/labels{/name}","releases_url":"https://api.github.com/repos/mizzy/specinfra/releases{/id}","created_at":"2013-11-27T13:08:43Z","updated_at":"2015-10-10T14:52:27Z","pushed_at":"2015-10-11T11:49:50Z","git_url":"git://github.com/mizzy/specinfra.git","ssh_url":"git@github.com:mizzy/specinfra.git","clone_url":"https://github.com/mizzy/specinfra.git","svn_url":"https://github.com/mizzy/specinfra","homepage":"http://serverspec.org/","size":5105,"stargazers_count":164,"watchers_count":164,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":219,"mirror_url":null,"open_issues_count":7,"forks":219,"open_issues":7,"watchers":164,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mizzy/specinfra/pulls/490"},"html":{"href":"https://github.com/mizzy/specinfra/pull/490"},"issue":{"href":"https://api.github.com/repos/mizzy/specinfra/issues/490"},"comments":{"href":"https://api.github.com/repos/mizzy/specinfra/issues/490/comments"},"review_comments":{"href":"https://api.github.com/repos/mizzy/specinfra/pulls/490/comments"},"review_comment":{"href":"https://api.github.com/repos/mizzy/specinfra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mizzy/specinfra/pulls/490/commits"},"statuses":{"href":"https://api.github.com/repos/mizzy/specinfra/statuses/6ce066c6f8398edd480e02c764dd2e35306ee70d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mizzy","id":3620,"avatar_url":"https://avatars.githubusercontent.com/u/3620?v=3","gravatar_id":"","url":"https://api.github.com/users/mizzy","html_url":"https://github.com/mizzy","followers_url":"https://api.github.com/users/mizzy/followers","following_url":"https://api.github.com/users/mizzy/following{/other_user}","gists_url":"https://api.github.com/users/mizzy/gists{/gist_id}","starred_url":"https://api.github.com/users/mizzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mizzy/subscriptions","organizations_url":"https://api.github.com/users/mizzy/orgs","repos_url":"https://api.github.com/users/mizzy/repos","events_url":"https://api.github.com/users/mizzy/events{/privacy}","received_events_url":"https://api.github.com/users/mizzy/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":22,"deletions":2,"changed_files":2}}