{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/filebeat/pulls/comments/45999554","id":45999554,"diff_hunk":"@@ -310,31 +310,53 @@ func readLine(\n \tpartialLineWaiting time.Duration,\n ) (string, int, bool, error) {\n \tfor {\n-\t\tline, sz, err := reader.next()\n+\t\tline, size, err := reader.next()\n \t\tif err != nil {\n+\n+\t\t\t// EOF reached, can mean partial line or EOF\n \t\t\tif err == io.EOF {\n-\t\t\t\treturn \"\", 0, false, err\n+\t\t\t\t// return all bytes read for current line to be processed.\n+\t\t\t\t// Line might grow with further read attempts\n+\t\t\t\t_, size, lineErr := reader.partial()","path":"harvester/log.go","position":13,"original_position":13,"commit_id":"3396dbe87035c2444897bfe02ee9583f27a39dee","original_commit_id":"3396dbe87035c2444897bfe02ee9583f27a39dee","user":{"login":"ruflin","id":244900,"avatar_url":"https://avatars.githubusercontent.com/u/244900?v=3","gravatar_id":"","url":"https://api.github.com/users/ruflin","html_url":"https://github.com/ruflin","followers_url":"https://api.github.com/users/ruflin/followers","following_url":"https://api.github.com/users/ruflin/following{/other_user}","gists_url":"https://api.github.com/users/ruflin/gists{/gist_id}","starred_url":"https://api.github.com/users/ruflin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruflin/subscriptions","organizations_url":"https://api.github.com/users/ruflin/orgs","repos_url":"https://api.github.com/users/ruflin/repos","events_url":"https://api.github.com/users/ruflin/events{/privacy}","received_events_url":"https://api.github.com/users/ruflin/received_events","type":"User","site_admin":false},"body":"Is the size returned only the bytes read since the last time partial was called or all bytes? same question for line?","created_at":"2015-11-26T17:47:07Z","updated_at":"2015-11-26T17:47:07Z","html_url":"https://github.com/elastic/filebeat/pull/294#discussion_r45999554","pull_request_url":"https://api.github.com/repos/elastic/filebeat/pulls/294","_links":{"self":{"href":"https://api.github.com/repos/elastic/filebeat/pulls/comments/45999554"},"html":{"href":"https://github.com/elastic/filebeat/pull/294#discussion_r45999554"},"pull_request":{"href":"https://api.github.com/repos/elastic/filebeat/pulls/294"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/filebeat/pulls/294","id":51931860,"html_url":"https://github.com/elastic/filebeat/pull/294","diff_url":"https://github.com/elastic/filebeat/pull/294.diff","patch_url":"https://github.com/elastic/filebeat/pull/294.patch","issue_url":"https://api.github.com/repos/elastic/filebeat/issues/294","number":294,"state":"open","locked":false,"title":"Filebeat improvements","user":{"login":"ruflin","id":244900,"avatar_url":"https://avatars.githubusercontent.com/u/244900?v=3","gravatar_id":"","url":"https://api.github.com/users/ruflin","html_url":"https://github.com/ruflin","followers_url":"https://api.github.com/users/ruflin/followers","following_url":"https://api.github.com/users/ruflin/following{/other_user}","gists_url":"https://api.github.com/users/ruflin/gists{/gist_id}","starred_url":"https://api.github.com/users/ruflin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruflin/subscriptions","organizations_url":"https://api.github.com/users/ruflin/orgs","repos_url":"https://api.github.com/users/ruflin/repos","events_url":"https://api.github.com/users/ruflin/events{/privacy}","received_events_url":"https://api.github.com/users/ruflin/received_events","type":"User","site_admin":false},"body":"Fixes current partial line implementation which is broken.\r\n\r\nDO NOT MERGE YET, STILL WIP\r\n\r\nThe current partial_line_waiting behaviour:\r\n* After exceeding partial_line_waiting time the partial line is sent\r\n* No further data is sent until new data is added to the file\r\n* In case additional data is added to the line but no line ending, the FULL line is sent again\r\n* This repeats until the line ending is added\r\n* When line ending is added, FULL line is sent again\r\n\r\n@urso @tsg @monicasarbu Is this as expected?","created_at":"2015-11-26T16:42:15Z","updated_at":"2015-11-26T17:47:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73a443d3855348cede5b75beaaeef06f53dd8cb6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elastic/filebeat/pulls/294/commits","review_comments_url":"https://api.github.com/repos/elastic/filebeat/pulls/294/comments","review_comment_url":"https://api.github.com/repos/elastic/filebeat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/filebeat/issues/294/comments","statuses_url":"https://api.github.com/repos/elastic/filebeat/statuses/3396dbe87035c2444897bfe02ee9583f27a39dee","head":{"label":"ruflin:filebeat-improvements","ref":"filebeat-improvements","sha":"3396dbe87035c2444897bfe02ee9583f27a39dee","user":{"login":"ruflin","id":244900,"avatar_url":"https://avatars.githubusercontent.com/u/244900?v=3","gravatar_id":"","url":"https://api.github.com/users/ruflin","html_url":"https://github.com/ruflin","followers_url":"https://api.github.com/users/ruflin/followers","following_url":"https://api.github.com/users/ruflin/following{/other_user}","gists_url":"https://api.github.com/users/ruflin/gists{/gist_id}","starred_url":"https://api.github.com/users/ruflin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruflin/subscriptions","organizations_url":"https://api.github.com/users/ruflin/orgs","repos_url":"https://api.github.com/users/ruflin/repos","events_url":"https://api.github.com/users/ruflin/events{/privacy}","received_events_url":"https://api.github.com/users/ruflin/received_events","type":"User","site_admin":false},"repo":{"id":42054812,"name":"filebeat","full_name":"ruflin/filebeat","owner":{"login":"ruflin","id":244900,"avatar_url":"https://avatars.githubusercontent.com/u/244900?v=3","gravatar_id":"","url":"https://api.github.com/users/ruflin","html_url":"https://github.com/ruflin","followers_url":"https://api.github.com/users/ruflin/followers","following_url":"https://api.github.com/users/ruflin/following{/other_user}","gists_url":"https://api.github.com/users/ruflin/gists{/gist_id}","starred_url":"https://api.github.com/users/ruflin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruflin/subscriptions","organizations_url":"https://api.github.com/users/ruflin/orgs","repos_url":"https://api.github.com/users/ruflin/repos","events_url":"https://api.github.com/users/ruflin/events{/privacy}","received_events_url":"https://api.github.com/users/ruflin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ruflin/filebeat","description":"Open Source File Harvester","fork":true,"url":"https://api.github.com/repos/ruflin/filebeat","forks_url":"https://api.github.com/repos/ruflin/filebeat/forks","keys_url":"https://api.github.com/repos/ruflin/filebeat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ruflin/filebeat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ruflin/filebeat/teams","hooks_url":"https://api.github.com/repos/ruflin/filebeat/hooks","issue_events_url":"https://api.github.com/repos/ruflin/filebeat/issues/events{/number}","events_url":"https://api.github.com/repos/ruflin/filebeat/events","assignees_url":"https://api.github.com/repos/ruflin/filebeat/assignees{/user}","branches_url":"https://api.github.com/repos/ruflin/filebeat/branches{/branch}","tags_url":"https://api.github.com/repos/ruflin/filebeat/tags","blobs_url":"https://api.github.com/repos/ruflin/filebeat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ruflin/filebeat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ruflin/filebeat/git/refs{/sha}","trees_url":"https://api.github.com/repos/ruflin/filebeat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ruflin/filebeat/statuses/{sha}","languages_url":"https://api.github.com/repos/ruflin/filebeat/languages","stargazers_url":"https://api.github.com/repos/ruflin/filebeat/stargazers","contributors_url":"https://api.github.com/repos/ruflin/filebeat/contributors","subscribers_url":"https://api.github.com/repos/ruflin/filebeat/subscribers","subscription_url":"https://api.github.com/repos/ruflin/filebeat/subscription","commits_url":"https://api.github.com/repos/ruflin/filebeat/commits{/sha}","git_commits_url":"https://api.github.com/repos/ruflin/filebeat/git/commits{/sha}","comments_url":"https://api.github.com/repos/ruflin/filebeat/comments{/number}","issue_comment_url":"https://api.github.com/repos/ruflin/filebeat/issues/comments{/number}","contents_url":"https://api.github.com/repos/ruflin/filebeat/contents/{+path}","compare_url":"https://api.github.com/repos/ruflin/filebeat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ruflin/filebeat/merges","archive_url":"https://api.github.com/repos/ruflin/filebeat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ruflin/filebeat/downloads","issues_url":"https://api.github.com/repos/ruflin/filebeat/issues{/number}","pulls_url":"https://api.github.com/repos/ruflin/filebeat/pulls{/number}","milestones_url":"https://api.github.com/repos/ruflin/filebeat/milestones{/number}","notifications_url":"https://api.github.com/repos/ruflin/filebeat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ruflin/filebeat/labels{/name}","releases_url":"https://api.github.com/repos/ruflin/filebeat/releases{/id}","created_at":"2015-09-07T13:36:26Z","updated_at":"2015-09-11T18:59:43Z","pushed_at":"2015-11-26T16:42:52Z","git_url":"git://github.com/ruflin/filebeat.git","ssh_url":"git@github.com:ruflin/filebeat.git","clone_url":"https://github.com/ruflin/filebeat.git","svn_url":"https://github.com/ruflin/filebeat","homepage":null,"size":2040,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"dd321d164c6b060aee3d2a03e3def77197a32e01","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":42054649,"name":"filebeat","full_name":"elastic/filebeat","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/filebeat","description":"Open Source Shipper for Log Files","fork":false,"url":"https://api.github.com/repos/elastic/filebeat","forks_url":"https://api.github.com/repos/elastic/filebeat/forks","keys_url":"https://api.github.com/repos/elastic/filebeat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/filebeat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/filebeat/teams","hooks_url":"https://api.github.com/repos/elastic/filebeat/hooks","issue_events_url":"https://api.github.com/repos/elastic/filebeat/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/filebeat/events","assignees_url":"https://api.github.com/repos/elastic/filebeat/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/filebeat/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/filebeat/tags","blobs_url":"https://api.github.com/repos/elastic/filebeat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/filebeat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/filebeat/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/filebeat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/filebeat/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/filebeat/languages","stargazers_url":"https://api.github.com/repos/elastic/filebeat/stargazers","contributors_url":"https://api.github.com/repos/elastic/filebeat/contributors","subscribers_url":"https://api.github.com/repos/elastic/filebeat/subscribers","subscription_url":"https://api.github.com/repos/elastic/filebeat/subscription","commits_url":"https://api.github.com/repos/elastic/filebeat/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/filebeat/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/filebeat/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/filebeat/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/filebeat/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/filebeat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/filebeat/merges","archive_url":"https://api.github.com/repos/elastic/filebeat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/filebeat/downloads","issues_url":"https://api.github.com/repos/elastic/filebeat/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/filebeat/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/filebeat/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/filebeat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/filebeat/labels{/name}","releases_url":"https://api.github.com/repos/elastic/filebeat/releases{/id}","created_at":"2015-09-07T13:32:44Z","updated_at":"2015-11-26T13:52:13Z","pushed_at":"2015-11-26T16:42:52Z","git_url":"git://github.com/elastic/filebeat.git","ssh_url":"git@github.com:elastic/filebeat.git","clone_url":"https://github.com/elastic/filebeat.git","svn_url":"https://github.com/elastic/filebeat","homepage":"","size":2113,"stargazers_count":202,"watchers_count":202,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":43,"forks":30,"open_issues":43,"watchers":202,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/filebeat/pulls/294"},"html":{"href":"https://github.com/elastic/filebeat/pull/294"},"issue":{"href":"https://api.github.com/repos/elastic/filebeat/issues/294"},"comments":{"href":"https://api.github.com/repos/elastic/filebeat/issues/294/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/filebeat/pulls/294/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/filebeat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/filebeat/pulls/294/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/filebeat/statuses/3396dbe87035c2444897bfe02ee9583f27a39dee"}}}}