{"action":"created","issue":{"url":"https://api.github.com/repos/opscode/oc_erchef/issues/71","labels_url":"https://api.github.com/repos/opscode/oc_erchef/issues/71/labels{/name}","comments_url":"https://api.github.com/repos/opscode/oc_erchef/issues/71/comments","events_url":"https://api.github.com/repos/opscode/oc_erchef/issues/71/events","html_url":"https://github.com/opscode/oc_erchef/pull/71","id":54451022,"number":71,"title":"Remove list merging from chef_deep_merge","user":{"login":"stevendanna","id":852371,"avatar_url":"https://avatars.githubusercontent.com/u/852371?v=3","gravatar_id":"","url":"https://api.github.com/users/stevendanna","html_url":"https://github.com/stevendanna","followers_url":"https://api.github.com/users/stevendanna/followers","following_url":"https://api.github.com/users/stevendanna/following{/other_user}","gists_url":"https://api.github.com/users/stevendanna/gists{/gist_id}","starred_url":"https://api.github.com/users/stevendanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevendanna/subscriptions","organizations_url":"https://api.github.com/users/stevendanna/orgs","repos_url":"https://api.github.com/users/stevendanna/repos","events_url":"https://api.github.com/users/stevendanna/events{/privacy}","received_events_url":"https://api.github.com/users/stevendanna/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/opscode/oc_erchef/labels/in+progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-01-15T13:51:32Z","updated_at":"2015-01-16T17:41:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/opscode/oc_erchef/pulls/71","html_url":"https://github.com/opscode/oc_erchef/pull/71","diff_url":"https://github.com/opscode/oc_erchef/pull/71.diff","patch_url":"https://github.com/opscode/oc_erchef/pull/71.patch"},"body":"According to our documentation, array node attributes are merged\r\n*within* a precedence level.  Between precedence levesl arrays *do not\r\nmerge*. Since the Chef Server only ever receives the merged\r\nattributes of a given precedence level, the list merging code in\r\nchef_deep_merge is unnecessary and incorrect.\r\n\r\nWARNING: Releasing this change will alter the search results returned\r\nby the API.  The new results will be correct per the documentation,\r\nbut different from those returned by previous version of the Chef\r\nServer.\r\n\r\nNOTE: When reading the test generator code, I found the following\r\nhelpful to understand how data flows through the tests to the actual\r\ncode:\r\n\r\n    print_example(lower_precedence, higher_precedence, expected)\r\n    print_example(mergee, other, expected)\r\n    chef_deep_merge:merge(Mergee, Other)\r\n    chef_deep_merge:merge(LowerPrecedence, HigherPrecedence)"},"comment":{"url":"https://api.github.com/repos/opscode/oc_erchef/issues/comments/70291193","html_url":"https://github.com/opscode/oc_erchef/pull/71#issuecomment-70291193","issue_url":"https://api.github.com/repos/opscode/oc_erchef/issues/71","id":70291193,"user":{"login":"manderson26","id":253389,"avatar_url":"https://avatars.githubusercontent.com/u/253389?v=3","gravatar_id":"","url":"https://api.github.com/users/manderson26","html_url":"https://github.com/manderson26","followers_url":"https://api.github.com/users/manderson26/followers","following_url":"https://api.github.com/users/manderson26/following{/other_user}","gists_url":"https://api.github.com/users/manderson26/gists{/gist_id}","starred_url":"https://api.github.com/users/manderson26/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manderson26/subscriptions","organizations_url":"https://api.github.com/users/manderson26/orgs","repos_url":"https://api.github.com/users/manderson26/repos","events_url":"https://api.github.com/users/manderson26/events{/privacy}","received_events_url":"https://api.github.com/users/manderson26/received_events","type":"User","site_admin":false},"created_at":"2015-01-16T17:41:14Z","updated_at":"2015-01-16T17:41:14Z","body":"Looks good. :+1: "}}