{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/26414988","id":26414988,"diff_hunk":"@@ -440,13 +442,22 @@ class FunctionDefinition: public Declaration, public VariableScope, public Docum\n class VariableDeclaration: public Declaration\n {\n public:\n-\tVariableDeclaration(SourceLocation const& _location, ASTPointer<TypeName> const& _type,\n-\t\t\t\t\t\t\tASTPointer<ASTString> const& _name, ASTPointer<Expression> _value,\n-\t\t\t\t\t\t\tVisibility _visibility,\n-\t\t\t\t\t\t\tbool _isStateVar = false, bool _isIndexed = false):\n-\t\t\tDeclaration(_location, _name, _visibility),\n-\t\t\tm_typeName(_type), m_value(_value),\n-\t\t\tm_isStateVariable(_isStateVar), m_isIndexed(_isIndexed) {}\n+\tVariableDeclaration(\n+\t\t\tSourceLocation const& _location,","path":"libsolidity/AST.h","position":28,"original_position":28,"commit_id":"c1d12f68a7ea6fea7a8632d3cdd996431d6896c8","original_commit_id":"c1d12f68a7ea6fea7a8632d3cdd996431d6896c8","user":{"login":"gavofyork","id":138296,"avatar_url":"https://avatars.githubusercontent.com/u/138296?v=3","gravatar_id":"","url":"https://api.github.com/users/gavofyork","html_url":"https://github.com/gavofyork","followers_url":"https://api.github.com/users/gavofyork/followers","following_url":"https://api.github.com/users/gavofyork/following{/other_user}","gists_url":"https://api.github.com/users/gavofyork/gists{/gist_id}","starred_url":"https://api.github.com/users/gavofyork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gavofyork/subscriptions","organizations_url":"https://api.github.com/users/gavofyork/orgs","repos_url":"https://api.github.com/users/gavofyork/repos","events_url":"https://api.github.com/users/gavofyork/events{/privacy}","received_events_url":"https://api.github.com/users/gavofyork/received_events","type":"User","site_admin":false},"body":"only a single tab.","created_at":"2015-03-13T19:15:39Z","updated_at":"2015-03-13T19:15:39Z","html_url":"https://github.com/ethereum/cpp-ethereum/pull/1274#discussion_r26414988","pull_request_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1274","_links":{"self":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/26414988"},"html":{"href":"https://github.com/ethereum/cpp-ethereum/pull/1274#discussion_r26414988"},"pull_request":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1274"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1274","id":30939126,"html_url":"https://github.com/ethereum/cpp-ethereum/pull/1274","diff_url":"https://github.com/ethereum/cpp-ethereum/pull/1274.diff","patch_url":"https://github.com/ethereum/cpp-ethereum/pull/1274.patch","issue_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/1274","number":1274,"state":"open","locked":false,"title":"constant variables","user":{"login":"LianaHus","id":9685356,"avatar_url":"https://avatars.githubusercontent.com/u/9685356?v=3","gravatar_id":"","url":"https://api.github.com/users/LianaHus","html_url":"https://github.com/LianaHus","followers_url":"https://api.github.com/users/LianaHus/followers","following_url":"https://api.github.com/users/LianaHus/following{/other_user}","gists_url":"https://api.github.com/users/LianaHus/gists{/gist_id}","starred_url":"https://api.github.com/users/LianaHus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LianaHus/subscriptions","organizations_url":"https://api.github.com/users/LianaHus/orgs","repos_url":"https://api.github.com/users/LianaHus/repos","events_url":"https://api.github.com/users/LianaHus/events{/privacy}","received_events_url":"https://api.github.com/users/LianaHus/received_events","type":"User","site_admin":false},"body":"added isConstant to VariableDeclaration\r\n","created_at":"2015-03-11T12:41:18Z","updated_at":"2015-03-13T19:15:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"12a808ba9063d3cfe3153aa765256ae0240fbbf8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1274/commits","review_comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1274/comments","review_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/1274/comments","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/c1d12f68a7ea6fea7a8632d3cdd996431d6896c8","head":{"label":"LianaHus:sol_ConstantFields","ref":"sol_ConstantFields","sha":"c1d12f68a7ea6fea7a8632d3cdd996431d6896c8","user":{"login":"LianaHus","id":9685356,"avatar_url":"https://avatars.githubusercontent.com/u/9685356?v=3","gravatar_id":"","url":"https://api.github.com/users/LianaHus","html_url":"https://github.com/LianaHus","followers_url":"https://api.github.com/users/LianaHus/followers","following_url":"https://api.github.com/users/LianaHus/following{/other_user}","gists_url":"https://api.github.com/users/LianaHus/gists{/gist_id}","starred_url":"https://api.github.com/users/LianaHus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LianaHus/subscriptions","organizations_url":"https://api.github.com/users/LianaHus/orgs","repos_url":"https://api.github.com/users/LianaHus/repos","events_url":"https://api.github.com/users/LianaHus/events{/privacy}","received_events_url":"https://api.github.com/users/LianaHus/received_events","type":"User","site_admin":false},"repo":{"id":29241685,"name":"cpp-ethereum","full_name":"LianaHus/cpp-ethereum","owner":{"login":"LianaHus","id":9685356,"avatar_url":"https://avatars.githubusercontent.com/u/9685356?v=3","gravatar_id":"","url":"https://api.github.com/users/LianaHus","html_url":"https://github.com/LianaHus","followers_url":"https://api.github.com/users/LianaHus/followers","following_url":"https://api.github.com/users/LianaHus/following{/other_user}","gists_url":"https://api.github.com/users/LianaHus/gists{/gist_id}","starred_url":"https://api.github.com/users/LianaHus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LianaHus/subscriptions","organizations_url":"https://api.github.com/users/LianaHus/orgs","repos_url":"https://api.github.com/users/LianaHus/repos","events_url":"https://api.github.com/users/LianaHus/events{/privacy}","received_events_url":"https://api.github.com/users/LianaHus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LianaHus/cpp-ethereum","description":"Gavin Wood's C++ implementation of the Ethereum yellowpaper.","fork":true,"url":"https://api.github.com/repos/LianaHus/cpp-ethereum","forks_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/forks","keys_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/teams","hooks_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/hooks","issue_events_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/events","assignees_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/tags","blobs_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/languages","stargazers_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/stargazers","contributors_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/contributors","subscribers_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/subscribers","subscription_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/subscription","commits_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/merges","archive_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/downloads","issues_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/releases{/id}","created_at":"2015-01-14T11:44:38Z","updated_at":"2015-03-12T13:18:49Z","pushed_at":"2015-03-13T17:44:39Z","git_url":"git://github.com/LianaHus/cpp-ethereum.git","ssh_url":"git@github.com:LianaHus/cpp-ethereum.git","clone_url":"https://github.com/LianaHus/cpp-ethereum.git","svn_url":"https://github.com/LianaHus/cpp-ethereum","homepage":"www.gavwood.com/Paper.pdf","size":16782,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"23b5398ee2c1fc5fb5d01bd06ec6de74fe9421ce","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15460666,"name":"cpp-ethereum","full_name":"ethereum/cpp-ethereum","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/cpp-ethereum","description":"Gavin Wood's C++ implementation of the Ethereum yellowpaper.","fork":false,"url":"https://api.github.com/repos/ethereum/cpp-ethereum","forks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/forks","keys_url":"https://api.github.com/repos/ethereum/cpp-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/cpp-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/cpp-ethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/events","assignees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/cpp-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/cpp-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/cpp-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/cpp-ethereum/merges","archive_url":"https://api.github.com/repos/ethereum/cpp-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/cpp-ethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/cpp-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/cpp-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/cpp-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/cpp-ethereum/releases{/id}","created_at":"2013-12-26T21:26:06Z","updated_at":"2015-03-13T19:13:18Z","pushed_at":"2015-03-13T19:13:18Z","git_url":"git://github.com/ethereum/cpp-ethereum.git","ssh_url":"git@github.com:ethereum/cpp-ethereum.git","clone_url":"https://github.com/ethereum/cpp-ethereum.git","svn_url":"https://github.com/ethereum/cpp-ethereum","homepage":"www.gavwood.com/Paper.pdf","size":86502,"stargazers_count":415,"watchers_count":415,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":149,"mirror_url":null,"open_issues_count":156,"forks":149,"open_issues":156,"watchers":415,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1274"},"html":{"href":"https://github.com/ethereum/cpp-ethereum/pull/1274"},"issue":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/1274"},"comments":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/1274/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1274/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1274/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/c1d12f68a7ea6fea7a8632d3cdd996431d6896c8"}}}}