{"action":"closed","number":18853,"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/18853","id":28881387,"html_url":"https://github.com/rails/rails/pull/18853","diff_url":"https://github.com/rails/rails/pull/18853.diff","patch_url":"https://github.com/rails/rails/pull/18853.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/18853","number":18853,"state":"closed","locked":false,"title":"Fix a range of values for parameters of the Time#change","user":{"login":"nkondratyev","id":1068531,"avatar_url":"https://avatars.githubusercontent.com/u/1068531?v=3","gravatar_id":"","url":"https://api.github.com/users/nkondratyev","html_url":"https://github.com/nkondratyev","followers_url":"https://api.github.com/users/nkondratyev/followers","following_url":"https://api.github.com/users/nkondratyev/following{/other_user}","gists_url":"https://api.github.com/users/nkondratyev/gists{/gist_id}","starred_url":"https://api.github.com/users/nkondratyev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkondratyev/subscriptions","organizations_url":"https://api.github.com/users/nkondratyev/orgs","repos_url":"https://api.github.com/users/nkondratyev/repos","events_url":"https://api.github.com/users/nkondratyev/events{/privacy}","received_events_url":"https://api.github.com/users/nkondratyev/received_events","type":"User","site_admin":false},"body":"Passing 999999000 < `:nsec` < 999999999 and 999999 < `:usec` < 1000000\r\nto change a time with utc_offset doesn't throw an `ArgumentError`.\r\n\r\nThese calls leads to the error:\r\n\r\n```ruby\r\nTime.new(2015, 5, 9, 10, 00, 00, '+03:00').change(nsec: 999999999) # => ArgumentError: argument out of range\r\nTime.new(2015, 5, 9, 10, 00, 00, '+03:00').change(usec: Rational(999999999, 1000)) # => ArgumentError: argument out of range\r\n```","created_at":"2015-02-08T15:02:33Z","updated_at":"2015-06-01T07:44:59Z","closed_at":"2015-06-01T07:44:59Z","merged_at":null,"merge_commit_sha":"e696a5f49a284a126f18814e5e99ea040e618659","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/18853/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/18853/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/rails/issues/18853/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/f891c5c25e4709897e2512b24ee516aafebba3d4","head":{"label":"nkondratyev:fix-time-change-method","ref":"fix-time-change-method","sha":"f891c5c25e4709897e2512b24ee516aafebba3d4","user":{"login":"nkondratyev","id":1068531,"avatar_url":"https://avatars.githubusercontent.com/u/1068531?v=3","gravatar_id":"","url":"https://api.github.com/users/nkondratyev","html_url":"https://github.com/nkondratyev","followers_url":"https://api.github.com/users/nkondratyev/followers","following_url":"https://api.github.com/users/nkondratyev/following{/other_user}","gists_url":"https://api.github.com/users/nkondratyev/gists{/gist_id}","starred_url":"https://api.github.com/users/nkondratyev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkondratyev/subscriptions","organizations_url":"https://api.github.com/users/nkondratyev/orgs","repos_url":"https://api.github.com/users/nkondratyev/repos","events_url":"https://api.github.com/users/nkondratyev/events{/privacy}","received_events_url":"https://api.github.com/users/nkondratyev/received_events","type":"User","site_admin":false},"repo":{"id":12105871,"name":"rails","full_name":"nkondratyev/rails","owner":{"login":"nkondratyev","id":1068531,"avatar_url":"https://avatars.githubusercontent.com/u/1068531?v=3","gravatar_id":"","url":"https://api.github.com/users/nkondratyev","html_url":"https://github.com/nkondratyev","followers_url":"https://api.github.com/users/nkondratyev/followers","following_url":"https://api.github.com/users/nkondratyev/following{/other_user}","gists_url":"https://api.github.com/users/nkondratyev/gists{/gist_id}","starred_url":"https://api.github.com/users/nkondratyev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkondratyev/subscriptions","organizations_url":"https://api.github.com/users/nkondratyev/orgs","repos_url":"https://api.github.com/users/nkondratyev/repos","events_url":"https://api.github.com/users/nkondratyev/events{/privacy}","received_events_url":"https://api.github.com/users/nkondratyev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nkondratyev/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/nkondratyev/rails","forks_url":"https://api.github.com/repos/nkondratyev/rails/forks","keys_url":"https://api.github.com/repos/nkondratyev/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nkondratyev/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nkondratyev/rails/teams","hooks_url":"https://api.github.com/repos/nkondratyev/rails/hooks","issue_events_url":"https://api.github.com/repos/nkondratyev/rails/issues/events{/number}","events_url":"https://api.github.com/repos/nkondratyev/rails/events","assignees_url":"https://api.github.com/repos/nkondratyev/rails/assignees{/user}","branches_url":"https://api.github.com/repos/nkondratyev/rails/branches{/branch}","tags_url":"https://api.github.com/repos/nkondratyev/rails/tags","blobs_url":"https://api.github.com/repos/nkondratyev/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nkondratyev/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nkondratyev/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/nkondratyev/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nkondratyev/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/nkondratyev/rails/languages","stargazers_url":"https://api.github.com/repos/nkondratyev/rails/stargazers","contributors_url":"https://api.github.com/repos/nkondratyev/rails/contributors","subscribers_url":"https://api.github.com/repos/nkondratyev/rails/subscribers","subscription_url":"https://api.github.com/repos/nkondratyev/rails/subscription","commits_url":"https://api.github.com/repos/nkondratyev/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/nkondratyev/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/nkondratyev/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/nkondratyev/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/nkondratyev/rails/contents/{+path}","compare_url":"https://api.github.com/repos/nkondratyev/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nkondratyev/rails/merges","archive_url":"https://api.github.com/repos/nkondratyev/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nkondratyev/rails/downloads","issues_url":"https://api.github.com/repos/nkondratyev/rails/issues{/number}","pulls_url":"https://api.github.com/repos/nkondratyev/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/nkondratyev/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/nkondratyev/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nkondratyev/rails/labels{/name}","releases_url":"https://api.github.com/repos/nkondratyev/rails/releases{/id}","created_at":"2013-08-14T10:04:51Z","updated_at":"2015-02-08T14:51:36Z","pushed_at":"2015-06-01T07:44:58Z","git_url":"git://github.com/nkondratyev/rails.git","ssh_url":"git@github.com:nkondratyev/rails.git","clone_url":"https://github.com/nkondratyev/rails.git","svn_url":"https://github.com/nkondratyev/rails","homepage":"http://rubyonrails.org","size":122925,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:4-2-stable","ref":"4-2-stable","sha":"a0a6e0292f66b546a3aee6893136a89bfd10579c","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","created_at":"2008-04-11T02:19:47Z","updated_at":"2015-06-01T05:01:45Z","pushed_at":"2015-06-01T07:21:42Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":448718,"stargazers_count":26333,"watchers_count":26333,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10471,"mirror_url":null,"open_issues_count":811,"forks":10471,"open_issues":811,"watchers":26333,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/18853"},"html":{"href":"https://github.com/rails/rails/pull/18853"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/18853"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/18853/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/18853/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/18853/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/f891c5c25e4709897e2512b24ee516aafebba3d4"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":2,"commits":1,"additions":9,"deletions":1,"changed_files":3}}