{"action":"created","issue":{"url":"https://api.github.com/repos/trendmicro/aleph/issues/28","labels_url":"https://api.github.com/repos/trendmicro/aleph/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/trendmicro/aleph/issues/28/comments","events_url":"https://api.github.com/repos/trendmicro/aleph/issues/28/events","html_url":"https://github.com/trendmicro/aleph/issues/28","id":66205025,"number":28,"title":"Fix Strings plugin","user":{"login":"jseidl","id":283041,"avatar_url":"https://avatars.githubusercontent.com/u/283041?v=3","gravatar_id":"","url":"https://api.github.com/users/jseidl","html_url":"https://github.com/jseidl","followers_url":"https://api.github.com/users/jseidl/followers","following_url":"https://api.github.com/users/jseidl/following{/other_user}","gists_url":"https://api.github.com/users/jseidl/gists{/gist_id}","starred_url":"https://api.github.com/users/jseidl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jseidl/subscriptions","organizations_url":"https://api.github.com/users/jseidl/orgs","repos_url":"https://api.github.com/users/jseidl/repos","events_url":"https://api.github.com/users/jseidl/events{/privacy}","received_events_url":"https://api.github.com/users/jseidl/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/trendmicro/aleph/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-03T18:34:55Z","updated_at":"2015-05-22T02:36:47Z","closed_at":null,"body":"Better handling of Unicode data, review regexes (URI, FILE etc)"},"comment":{"url":"https://api.github.com/repos/trendmicro/aleph/issues/comments/104479664","html_url":"https://github.com/trendmicro/aleph/issues/28#issuecomment-104479664","issue_url":"https://api.github.com/repos/trendmicro/aleph/issues/28","id":104479664,"user":{"login":"turicas","id":186126,"avatar_url":"https://avatars.githubusercontent.com/u/186126?v=3","gravatar_id":"","url":"https://api.github.com/users/turicas","html_url":"https://github.com/turicas","followers_url":"https://api.github.com/users/turicas/followers","following_url":"https://api.github.com/users/turicas/following{/other_user}","gists_url":"https://api.github.com/users/turicas/gists{/gist_id}","starred_url":"https://api.github.com/users/turicas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turicas/subscriptions","organizations_url":"https://api.github.com/users/turicas/orgs","repos_url":"https://api.github.com/users/turicas/repos","events_url":"https://api.github.com/users/turicas/events{/privacy}","received_events_url":"https://api.github.com/users/turicas/received_events","type":"User","site_admin":false},"created_at":"2015-05-22T02:36:47Z","updated_at":"2015-05-22T02:36:47Z","body":"As the file could be in any encoding (or actually a binary), the plugin should not try to decode the whole file, should it?\r\nThe way it works today (`f.read().decode('latin1').encode('utf8')`) can lead to many `UnicodeDecodeError` or `UnicodeEncodeError`s (unless you receive only `latin1`-encoded files)."}}