{"action":"created","issue":{"url":"https://api.github.com/repos/minetest/minetest/issues/2524","labels_url":"https://api.github.com/repos/minetest/minetest/issues/2524/labels{/name}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/2524/comments","events_url":"https://api.github.com/repos/minetest/minetest/issues/2524/events","html_url":"https://github.com/minetest/minetest/issues/2524","id":63458596,"number":2524,"title":"Issues with new network code","user":{"login":"PilzAdam","id":2159710,"avatar_url":"https://avatars.githubusercontent.com/u/2159710?v=3","gravatar_id":"","url":"https://api.github.com/users/PilzAdam","html_url":"https://github.com/PilzAdam","followers_url":"https://api.github.com/users/PilzAdam/followers","following_url":"https://api.github.com/users/PilzAdam/following{/other_user}","gists_url":"https://api.github.com/users/PilzAdam/gists{/gist_id}","starred_url":"https://api.github.com/users/PilzAdam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PilzAdam/subscriptions","organizations_url":"https://api.github.com/users/PilzAdam/orgs","repos_url":"https://api.github.com/users/PilzAdam/repos","events_url":"https://api.github.com/users/PilzAdam/events{/privacy}","received_events_url":"https://api.github.com/users/PilzAdam/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/minetest/minetest/labels/@%20Network","name":"@ Network","color":"009800"},{"url":"https://api.github.com/repos/minetest/minetest/labels/blocker","name":"blocker","color":"e10d21"},{"url":"https://api.github.com/repos/minetest/minetest/labels/bug","name":"bug","color":"ff5050"},{"url":"https://api.github.com/repos/minetest/minetest/labels/High%20priority","name":"High priority","color":"e11d21"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":16,"created_at":"2015-03-21T21:56:32Z","updated_at":"2015-08-06T06:54:19Z","closed_at":"2015-08-06T06:54:19Z","body":"Here is a list of issues with @nerzhul's recent network related code rewrite:\r\n- [x] HP bug (#2501)\r\n- [ ] Flat player glitch\r\n- [x] Packets intended to be send as unreliable are being sent as reliable instead\r\n- [x] Packets are being copied before\r\n- [x] Players being spawned at (0,0,0) if static spawnpoint is set\r\n- [x] Test whether performance has increased / decreased\r\n\r\nAll core devs are free to edit this post to expand this list. Do not remove points, though.\r\n"},"comment":{"url":"https://api.github.com/repos/minetest/minetest/issues/comments/128270663","html_url":"https://github.com/minetest/minetest/issues/2524#issuecomment-128270663","issue_url":"https://api.github.com/repos/minetest/minetest/issues/2524","id":128270663,"user":{"login":"kwolekr","id":630595,"avatar_url":"https://avatars.githubusercontent.com/u/630595?v=3","gravatar_id":"","url":"https://api.github.com/users/kwolekr","html_url":"https://github.com/kwolekr","followers_url":"https://api.github.com/users/kwolekr/followers","following_url":"https://api.github.com/users/kwolekr/following{/other_user}","gists_url":"https://api.github.com/users/kwolekr/gists{/gist_id}","starred_url":"https://api.github.com/users/kwolekr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwolekr/subscriptions","organizations_url":"https://api.github.com/users/kwolekr/orgs","repos_url":"https://api.github.com/users/kwolekr/repos","events_url":"https://api.github.com/users/kwolekr/events{/privacy}","received_events_url":"https://api.github.com/users/kwolekr/received_events","type":"User","site_admin":false},"created_at":"2015-08-06T06:54:18Z","updated_at":"2015-08-06T06:54:18Z","body":"I'm having a really hard time reproducing the flat player glitch.  As of https://github.com/minetest/minetest/commit/bd0b469d3d212ae1407233bdb743bfcab31b4dc7 I feel confident enough with the new network code to finally close this issue.\r\n\r\nThere is still a performance regression due to all the extra copying overhead involved with NetworkPacket, but this will be addressed with moving to the new interface here https://github.com/minetest/minetest/pull/3013 for building and parsing packets."}}