{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/relay/issues/625","labels_url":"https://api.github.com/repos/facebook/relay/issues/625/labels{/name}","comments_url":"https://api.github.com/repos/facebook/relay/issues/625/comments","events_url":"https://api.github.com/repos/facebook/relay/issues/625/events","html_url":"https://github.com/facebook/relay/pull/625","id":118247947,"number":625,"title":"Make RelayRenderer run queries after mount","user":{"login":"denvned","id":3933789,"avatar_url":"https://avatars.githubusercontent.com/u/3933789?v=3","gravatar_id":"","url":"https://api.github.com/users/denvned","html_url":"https://github.com/denvned","followers_url":"https://api.github.com/users/denvned/followers","following_url":"https://api.github.com/users/denvned/following{/other_user}","gists_url":"https://api.github.com/users/denvned/gists{/gist_id}","starred_url":"https://api.github.com/users/denvned/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denvned/subscriptions","organizations_url":"https://api.github.com/users/denvned/orgs","repos_url":"https://api.github.com/users/denvned/repos","events_url":"https://api.github.com/users/denvned/events{/privacy}","received_events_url":"https://api.github.com/users/denvned/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/relay/labels/CLA%20Signed","name":"CLA Signed","color":"009900"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-22T06:59:07Z","updated_at":"2015-12-01T15:04:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/relay/pulls/625","html_url":"https://github.com/facebook/relay/pull/625","diff_url":"https://github.com/facebook/relay/pull/625.diff","patch_url":"https://github.com/facebook/relay/pull/625.patch"},"body":"...to make sure `RelayRenderer` does not run queries during synchronous server-side rendering.\r\n\r\nIn the `RelayRenderer` tests, I had to replace `ShallowRenderer.render` with the traditional `ReactDOM.render`, because `ShallowRenderer.render` does not invoke some component lifecycle methods including `componentDidMount` that now run queries. But I did not change the logic of the tests, as **visible behaviour of `RelayRenderer` was fully retained.**\r\n\r\nAdded a test to check that `RelayRender` does not run queries on the server.\r\n\r\nThis PR is a forerunner of the PR that will make `RelayRenderer` isomorphic (see #589). That next PR will be pretty small and easily comprehensible, because this PR already did much of the necessary dirty work."},"comment":{"url":"https://api.github.com/repos/facebook/relay/issues/comments/160993933","html_url":"https://github.com/facebook/relay/pull/625#issuecomment-160993933","issue_url":"https://api.github.com/repos/facebook/relay/issues/625","id":160993933,"user":{"login":"denvned","id":3933789,"avatar_url":"https://avatars.githubusercontent.com/u/3933789?v=3","gravatar_id":"","url":"https://api.github.com/users/denvned","html_url":"https://github.com/denvned","followers_url":"https://api.github.com/users/denvned/followers","following_url":"https://api.github.com/users/denvned/following{/other_user}","gists_url":"https://api.github.com/users/denvned/gists{/gist_id}","starred_url":"https://api.github.com/users/denvned/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denvned/subscriptions","organizations_url":"https://api.github.com/users/denvned/orgs","repos_url":"https://api.github.com/users/denvned/repos","events_url":"https://api.github.com/users/denvned/events{/privacy}","received_events_url":"https://api.github.com/users/denvned/received_events","type":"User","site_admin":false},"created_at":"2015-12-01T15:04:49Z","updated_at":"2015-12-01T15:04:49Z","body":"I would very much appreciate any feedback on this PR. My further work on [the server-side rendering PR](https://github.com/facebook/relay/issues/589#issuecomment-158766319) depends on it."}}