{"action":"created","comment":{"url":"https://api.github.com/repos/youtube/vitess/pulls/comments/23430590","id":23430590,"diff_hunk":"@@ -386,6 +392,15 @@ func (stc *ScatterConn) Commit(context context.Context, session *SafeSession) (e\n \n // Rollback rolls back the current transaction. There are no retries on this operation.\n func (stc *ScatterConn) Rollback(context context.Context, session *SafeSession) (err error) {\n+\tif session == nil {","path":"go/vt/vtgate/scatter_conn.go","position":20,"original_position":20,"commit_id":"dc1786818d4d549d8a5d2fff37ece36b42743832","original_commit_id":"dc1786818d4d549d8a5d2fff37ece36b42743832","user":{"login":"sougou","id":589370,"avatar_url":"https://avatars.githubusercontent.com/u/589370?v=3","gravatar_id":"","url":"https://api.github.com/users/sougou","html_url":"https://github.com/sougou","followers_url":"https://api.github.com/users/sougou/followers","following_url":"https://api.github.com/users/sougou/following{/other_user}","gists_url":"https://api.github.com/users/sougou/gists{/gist_id}","starred_url":"https://api.github.com/users/sougou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sougou/subscriptions","organizations_url":"https://api.github.com/users/sougou/orgs","repos_url":"https://api.github.com/users/sougou/repos","events_url":"https://api.github.com/users/sougou/events{/privacy}","received_events_url":"https://api.github.com/users/sougou/received_events","type":"User","site_admin":false},"body":"For rollback, I think it's ok to not be strict at all. So, it's ok not to check anything. This is because clients often do redundant rollbacks 'for good measure'.\r\nErrors here have mostly ended up alarming people unnecessarily.","created_at":"2015-01-23T03:51:41Z","updated_at":"2015-01-23T03:51:41Z","html_url":"https://github.com/youtube/vitess/pull/342#discussion_r23430590","pull_request_url":"https://api.github.com/repos/youtube/vitess/pulls/342","_links":{"self":{"href":"https://api.github.com/repos/youtube/vitess/pulls/comments/23430590"},"html":{"href":"https://github.com/youtube/vitess/pull/342#discussion_r23430590"},"pull_request":{"href":"https://api.github.com/repos/youtube/vitess/pulls/342"}}},"pull_request":{"url":"https://api.github.com/repos/youtube/vitess/pulls/342","id":27888947,"html_url":"https://github.com/youtube/vitess/pull/342","diff_url":"https://github.com/youtube/vitess/pull/342.diff","patch_url":"https://github.com/youtube/vitess/pull/342.patch","issue_url":"https://api.github.com/repos/youtube/vitess/issues/342","number":342,"state":"open","locked":false,"title":"VTGate commit/rollback will fail if session object is not valid","user":{"login":"guoliang100","id":5091016,"avatar_url":"https://avatars.githubusercontent.com/u/5091016?v=3","gravatar_id":"","url":"https://api.github.com/users/guoliang100","html_url":"https://github.com/guoliang100","followers_url":"https://api.github.com/users/guoliang100/followers","following_url":"https://api.github.com/users/guoliang100/following{/other_user}","gists_url":"https://api.github.com/users/guoliang100/gists{/gist_id}","starred_url":"https://api.github.com/users/guoliang100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guoliang100/subscriptions","organizations_url":"https://api.github.com/users/guoliang100/orgs","repos_url":"https://api.github.com/users/guoliang100/repos","events_url":"https://api.github.com/users/guoliang100/events{/privacy}","received_events_url":"https://api.github.com/users/guoliang100/received_events","type":"User","site_admin":false},"body":"@sougou @alainjobart @shrutip ","created_at":"2015-01-22T23:37:23Z","updated_at":"2015-01-23T03:51:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a2c97e58f3b0baa709f6354a6969ccc971430bc8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/youtube/vitess/pulls/342/commits","review_comments_url":"https://api.github.com/repos/youtube/vitess/pulls/342/comments","review_comment_url":"https://api.github.com/repos/youtube/vitess/pulls/comments/{number}","comments_url":"https://api.github.com/repos/youtube/vitess/issues/342/comments","statuses_url":"https://api.github.com/repos/youtube/vitess/statuses/dc1786818d4d549d8a5d2fff37ece36b42743832","head":{"label":"youtube:vtgatecommit","ref":"vtgatecommit","sha":"dc1786818d4d549d8a5d2fff37ece36b42743832","user":{"login":"youtube","id":4052902,"avatar_url":"https://avatars.githubusercontent.com/u/4052902?v=3","gravatar_id":"","url":"https://api.github.com/users/youtube","html_url":"https://github.com/youtube","followers_url":"https://api.github.com/users/youtube/followers","following_url":"https://api.github.com/users/youtube/following{/other_user}","gists_url":"https://api.github.com/users/youtube/gists{/gist_id}","starred_url":"https://api.github.com/users/youtube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youtube/subscriptions","organizations_url":"https://api.github.com/users/youtube/orgs","repos_url":"https://api.github.com/users/youtube/repos","events_url":"https://api.github.com/users/youtube/events{/privacy}","received_events_url":"https://api.github.com/users/youtube/received_events","type":"Organization","site_admin":false},"repo":{"id":11008207,"name":"vitess","full_name":"youtube/vitess","owner":{"login":"youtube","id":4052902,"avatar_url":"https://avatars.githubusercontent.com/u/4052902?v=3","gravatar_id":"","url":"https://api.github.com/users/youtube","html_url":"https://github.com/youtube","followers_url":"https://api.github.com/users/youtube/followers","following_url":"https://api.github.com/users/youtube/following{/other_user}","gists_url":"https://api.github.com/users/youtube/gists{/gist_id}","starred_url":"https://api.github.com/users/youtube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youtube/subscriptions","organizations_url":"https://api.github.com/users/youtube/orgs","repos_url":"https://api.github.com/users/youtube/repos","events_url":"https://api.github.com/users/youtube/events{/privacy}","received_events_url":"https://api.github.com/users/youtube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/youtube/vitess","description":"vitess provides servers and tools which facilitate scaling of MySQL databases for large scale web services.","fork":false,"url":"https://api.github.com/repos/youtube/vitess","forks_url":"https://api.github.com/repos/youtube/vitess/forks","keys_url":"https://api.github.com/repos/youtube/vitess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/youtube/vitess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/youtube/vitess/teams","hooks_url":"https://api.github.com/repos/youtube/vitess/hooks","issue_events_url":"https://api.github.com/repos/youtube/vitess/issues/events{/number}","events_url":"https://api.github.com/repos/youtube/vitess/events","assignees_url":"https://api.github.com/repos/youtube/vitess/assignees{/user}","branches_url":"https://api.github.com/repos/youtube/vitess/branches{/branch}","tags_url":"https://api.github.com/repos/youtube/vitess/tags","blobs_url":"https://api.github.com/repos/youtube/vitess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/youtube/vitess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/youtube/vitess/git/refs{/sha}","trees_url":"https://api.github.com/repos/youtube/vitess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/youtube/vitess/statuses/{sha}","languages_url":"https://api.github.com/repos/youtube/vitess/languages","stargazers_url":"https://api.github.com/repos/youtube/vitess/stargazers","contributors_url":"https://api.github.com/repos/youtube/vitess/contributors","subscribers_url":"https://api.github.com/repos/youtube/vitess/subscribers","subscription_url":"https://api.github.com/repos/youtube/vitess/subscription","commits_url":"https://api.github.com/repos/youtube/vitess/commits{/sha}","git_commits_url":"https://api.github.com/repos/youtube/vitess/git/commits{/sha}","comments_url":"https://api.github.com/repos/youtube/vitess/comments{/number}","issue_comment_url":"https://api.github.com/repos/youtube/vitess/issues/comments/{number}","contents_url":"https://api.github.com/repos/youtube/vitess/contents/{+path}","compare_url":"https://api.github.com/repos/youtube/vitess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/youtube/vitess/merges","archive_url":"https://api.github.com/repos/youtube/vitess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/youtube/vitess/downloads","issues_url":"https://api.github.com/repos/youtube/vitess/issues{/number}","pulls_url":"https://api.github.com/repos/youtube/vitess/pulls{/number}","milestones_url":"https://api.github.com/repos/youtube/vitess/milestones{/number}","notifications_url":"https://api.github.com/repos/youtube/vitess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/youtube/vitess/labels{/name}","releases_url":"https://api.github.com/repos/youtube/vitess/releases{/id}","created_at":"2013-06-27T21:20:28Z","updated_at":"2015-01-23T03:19:03Z","pushed_at":"2015-01-23T03:19:04Z","git_url":"git://github.com/youtube/vitess.git","ssh_url":"git@github.com:youtube/vitess.git","clone_url":"https://github.com/youtube/vitess.git","svn_url":"https://github.com/youtube/vitess","homepage":null,"size":58458,"stargazers_count":2013,"watchers_count":2013,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":239,"mirror_url":null,"open_issues_count":7,"forks":239,"open_issues":7,"watchers":2013,"default_branch":"master"}},"base":{"label":"youtube:master","ref":"master","sha":"2e5f169cdceac884033a9f93df2a09f1168cd3c2","user":{"login":"youtube","id":4052902,"avatar_url":"https://avatars.githubusercontent.com/u/4052902?v=3","gravatar_id":"","url":"https://api.github.com/users/youtube","html_url":"https://github.com/youtube","followers_url":"https://api.github.com/users/youtube/followers","following_url":"https://api.github.com/users/youtube/following{/other_user}","gists_url":"https://api.github.com/users/youtube/gists{/gist_id}","starred_url":"https://api.github.com/users/youtube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youtube/subscriptions","organizations_url":"https://api.github.com/users/youtube/orgs","repos_url":"https://api.github.com/users/youtube/repos","events_url":"https://api.github.com/users/youtube/events{/privacy}","received_events_url":"https://api.github.com/users/youtube/received_events","type":"Organization","site_admin":false},"repo":{"id":11008207,"name":"vitess","full_name":"youtube/vitess","owner":{"login":"youtube","id":4052902,"avatar_url":"https://avatars.githubusercontent.com/u/4052902?v=3","gravatar_id":"","url":"https://api.github.com/users/youtube","html_url":"https://github.com/youtube","followers_url":"https://api.github.com/users/youtube/followers","following_url":"https://api.github.com/users/youtube/following{/other_user}","gists_url":"https://api.github.com/users/youtube/gists{/gist_id}","starred_url":"https://api.github.com/users/youtube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youtube/subscriptions","organizations_url":"https://api.github.com/users/youtube/orgs","repos_url":"https://api.github.com/users/youtube/repos","events_url":"https://api.github.com/users/youtube/events{/privacy}","received_events_url":"https://api.github.com/users/youtube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/youtube/vitess","description":"vitess provides servers and tools which facilitate scaling of MySQL databases for large scale web services.","fork":false,"url":"https://api.github.com/repos/youtube/vitess","forks_url":"https://api.github.com/repos/youtube/vitess/forks","keys_url":"https://api.github.com/repos/youtube/vitess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/youtube/vitess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/youtube/vitess/teams","hooks_url":"https://api.github.com/repos/youtube/vitess/hooks","issue_events_url":"https://api.github.com/repos/youtube/vitess/issues/events{/number}","events_url":"https://api.github.com/repos/youtube/vitess/events","assignees_url":"https://api.github.com/repos/youtube/vitess/assignees{/user}","branches_url":"https://api.github.com/repos/youtube/vitess/branches{/branch}","tags_url":"https://api.github.com/repos/youtube/vitess/tags","blobs_url":"https://api.github.com/repos/youtube/vitess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/youtube/vitess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/youtube/vitess/git/refs{/sha}","trees_url":"https://api.github.com/repos/youtube/vitess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/youtube/vitess/statuses/{sha}","languages_url":"https://api.github.com/repos/youtube/vitess/languages","stargazers_url":"https://api.github.com/repos/youtube/vitess/stargazers","contributors_url":"https://api.github.com/repos/youtube/vitess/contributors","subscribers_url":"https://api.github.com/repos/youtube/vitess/subscribers","subscription_url":"https://api.github.com/repos/youtube/vitess/subscription","commits_url":"https://api.github.com/repos/youtube/vitess/commits{/sha}","git_commits_url":"https://api.github.com/repos/youtube/vitess/git/commits{/sha}","comments_url":"https://api.github.com/repos/youtube/vitess/comments{/number}","issue_comment_url":"https://api.github.com/repos/youtube/vitess/issues/comments/{number}","contents_url":"https://api.github.com/repos/youtube/vitess/contents/{+path}","compare_url":"https://api.github.com/repos/youtube/vitess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/youtube/vitess/merges","archive_url":"https://api.github.com/repos/youtube/vitess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/youtube/vitess/downloads","issues_url":"https://api.github.com/repos/youtube/vitess/issues{/number}","pulls_url":"https://api.github.com/repos/youtube/vitess/pulls{/number}","milestones_url":"https://api.github.com/repos/youtube/vitess/milestones{/number}","notifications_url":"https://api.github.com/repos/youtube/vitess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/youtube/vitess/labels{/name}","releases_url":"https://api.github.com/repos/youtube/vitess/releases{/id}","created_at":"2013-06-27T21:20:28Z","updated_at":"2015-01-23T03:19:03Z","pushed_at":"2015-01-23T03:19:04Z","git_url":"git://github.com/youtube/vitess.git","ssh_url":"git@github.com:youtube/vitess.git","clone_url":"https://github.com/youtube/vitess.git","svn_url":"https://github.com/youtube/vitess","homepage":null,"size":58458,"stargazers_count":2013,"watchers_count":2013,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":239,"mirror_url":null,"open_issues_count":7,"forks":239,"open_issues":7,"watchers":2013,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/youtube/vitess/pulls/342"},"html":{"href":"https://github.com/youtube/vitess/pull/342"},"issue":{"href":"https://api.github.com/repos/youtube/vitess/issues/342"},"comments":{"href":"https://api.github.com/repos/youtube/vitess/issues/342/comments"},"review_comments":{"href":"https://api.github.com/repos/youtube/vitess/pulls/342/comments"},"review_comment":{"href":"https://api.github.com/repos/youtube/vitess/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/youtube/vitess/pulls/342/commits"},"statuses":{"href":"https://api.github.com/repos/youtube/vitess/statuses/dc1786818d4d549d8a5d2fff37ece36b42743832"}}}}