{"action":"created","issue":{"url":"https://api.github.com/repos/iaincollins/tabletojson/issues/2","labels_url":"https://api.github.com/repos/iaincollins/tabletojson/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/iaincollins/tabletojson/issues/2/comments","events_url":"https://api.github.com/repos/iaincollins/tabletojson/issues/2/events","html_url":"https://github.com/iaincollins/tabletojson/issues/2","id":65553240,"number":2,"title":"Maybe switch to `.find` instead of `.children`","user":{"login":"mhkeller","id":498744,"avatar_url":"https://avatars.githubusercontent.com/u/498744?v=3","gravatar_id":"","url":"https://api.github.com/users/mhkeller","html_url":"https://github.com/mhkeller","followers_url":"https://api.github.com/users/mhkeller/followers","following_url":"https://api.github.com/users/mhkeller/following{/other_user}","gists_url":"https://api.github.com/users/mhkeller/gists{/gist_id}","starred_url":"https://api.github.com/users/mhkeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhkeller/subscriptions","organizations_url":"https://api.github.com/users/mhkeller/orgs","repos_url":"https://api.github.com/users/mhkeller/repos","events_url":"https://api.github.com/users/mhkeller/events{/privacy}","received_events_url":"https://api.github.com/users/mhkeller/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-31T21:41:03Z","updated_at":"2015-04-01T08:11:13Z","closed_at":null,"body":"The table I'm trying to convert has a `thead` and `tbody` element so children doesn't go down enough levels. Changing `.children` to find will fix this. Not sure if it has any drawbacks. The only thing I can think of is if you have tables within your table. But you might have other problems if that's the case. \r\n\r\nThere could also be some type of check that looks for `thead` and `tbody` if they exist and then use `.children`. That would save some computing energy in looping over all `tr`s to extract the `th`s.\r\n\r\nI can do a pull request on changing to children if you like."},"comment":{"url":"https://api.github.com/repos/iaincollins/tabletojson/issues/comments/88387867","html_url":"https://github.com/iaincollins/tabletojson/issues/2#issuecomment-88387867","issue_url":"https://api.github.com/repos/iaincollins/tabletojson/issues/2","id":88387867,"user":{"login":"iaincollins","id":595695,"avatar_url":"https://avatars.githubusercontent.com/u/595695?v=3","gravatar_id":"","url":"https://api.github.com/users/iaincollins","html_url":"https://github.com/iaincollins","followers_url":"https://api.github.com/users/iaincollins/followers","following_url":"https://api.github.com/users/iaincollins/following{/other_user}","gists_url":"https://api.github.com/users/iaincollins/gists{/gist_id}","starred_url":"https://api.github.com/users/iaincollins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iaincollins/subscriptions","organizations_url":"https://api.github.com/users/iaincollins/orgs","repos_url":"https://api.github.com/users/iaincollins/repos","events_url":"https://api.github.com/users/iaincollins/events{/privacy}","received_events_url":"https://api.github.com/users/iaincollins/received_events","type":"User","site_admin":false},"created_at":"2015-04-01T08:11:13Z","updated_at":"2015-04-01T08:11:13Z","body":"Good plan! I've been meaning to revisit and improve this.\r\n\r\nPull request would be awesome, otherwise I'll take a look and see if I can improve it (and the docs & maybe write some tests) later in the month!"}}