{"push_id":783753417,"size":23,"distinct_size":23,"ref":"refs/heads/OmnisharpRoslyn","head":"d16f6b4494a9bdd08f7270a7f368839e7dc9a2cb","before":"7c27dad1b07c7c63f0ff0f4031ebdff5cd2feede","commits":[{"sha":"9d2d4d0272ed7ec43bd5e3e067a0e8892df76d35","author":{"email":"de3e21482d297103c92e3a0cd1e3574c8553d0bf@gmail.com","name":"Ben Jackson"},"message":"Use client working directory if supplied for filename completer","distinct":true,"url":"https://api.github.com/repos/mispencer/ycmd/commits/9d2d4d0272ed7ec43bd5e3e067a0e8892df76d35"},{"sha":"4ff21d418d113e37190a09c4b4f2cfb935bc28ee","author":{"email":"3ea746b47d9514139cf1a574eb74d109fce348b0@users.noreply.github.com","name":"Neo"},"message":"Fix flaky regular expression comparison test\n\nThe proposed change is to fix the test `ycmd.completers.completer_utils_test.FiletypeTriggerDictFromSpec_Works_test` which previoulsy used an equality check which relied on the resulting objects being the same instances. However, this is not reliable as demonstrated in spurious test failures in https://github.com/Valloric/ycmd/pull/120.","distinct":true,"url":"https://api.github.com/repos/mispencer/ycmd/commits/4ff21d418d113e37190a09c4b4f2cfb935bc28ee"},{"sha":"51afbb33a5ab701d19620a68c1a3c4cd7f6ef9cc","author":{"email":"1a73af9e7ae00182733b2292511b814be66f065f@micbou.com","name":"micbou"},"message":"Do not depend on implementation specifics\n\nUse a dummy wrapper of std::string to avoid tests depending on\nimplementation specifics.\nFix three RunCompleterCommand_GetType_Clang tests on OS X and\nWindows.","distinct":true,"url":"https://api.github.com/repos/mispencer/ycmd/commits/51afbb33a5ab701d19620a68c1a3c4cd7f6ef9cc"},{"sha":"f4a59cf056f2210639faa5e5fe0cf3fa30e62c07","author":{"email":"5c2bd99229d434a2f7174ea3f8798d821bc7f9ae@barosl.com","name":"Homu"},"message":"Auto merge of #210 - puremourning:cwd-filetype-completer, r=Valloric\n\nUse client working directory if supplied for filename completer\n\nBackground\r\n====\r\n\r\nFixes: https://github.com/Valloric/YouCompleteMe/issues/1655\r\n\r\nThe documentation for YouCompleteMe says:\r\n\r\n>The g:ycm_filepath_completion_use_working_dir option\r\n\r\n> By default, YCM's filepath completion will interpret relative paths like ../ as being relative to the folder of the file of the currently active buffer. Setting this option will force YCM to always interpret relative paths as being relative to Vim's current working directory.\r\n\r\n> Default: 0\r\n\r\n>  let g:ycm_filepath_completion_use_working_dir = 0\r\n\r\nBut previously, only the working directory of `ycmd` was used. This meant that operations like changing the working directory of the client were not reflected in completion suggestions.\r\n\r\nWhat this change does\r\n====\r\n\r\nThe client can now (optionally) pass a `working_dir` property to the '/completions' request which is respected by the filename completer (and potentially any other completer should it be useful). If `working_dir` is not supplied, the previous behaviour remains.\r\n\r\nAPI Changes\r\n====\r\n\r\nThe `/completions` request data now allows an optional `working_dir` parameter containing the _absolute path_ to the working directory of the client.\r\n\r\nTesting\r\n====\r\n\r\nAdded new tests to the `filename_completer_test`. See also trivial manual test cases on the linked issue. The one remaining question is about the performance of the `os.getcwd` call on each request, but it probably pales into insignificance compared to the performance of the vimscript, and in particular the IO operations performed by the filename completer itself.\r\n\r\nThis only addresses the 'standard' case for filename completer, as the 'include' case already has its own logic for relative paths and there are already auto tests for that.\r\n\r\nRelated\r\n====\r\n\r\nThere is a related (trivial) change to YouCompleteMe: https://github.com/Valloric/YouCompleteMe/pull/1659","distinct":true,"url":"https://api.github.com/repos/mispencer/ycmd/commits/f4a59cf056f2210639faa5e5fe0cf3fa30e62c07"},{"sha":"4e3a4abbe2a7bcce69f07249b4665779f8a1488f","author":{"email":"5c2bd99229d434a2f7174ea3f8798d821bc7f9ae@barosl.com","name":"Homu"},"message":"Auto merge of #208 - micbou:windows-basic-string-type, r=puremourning\n\n [OS X support] [Windows support] Do not depend on std::string implementation specifics\n\nSince it was the same issue, I merged the OS X fix from @puremourning and my Windows fix to this PR. Thanks to him.\r\n\r\nFix 3 tests (3 failures) on OS X and Windows.","distinct":true,"url":"https://api.github.com/repos/mispencer/ycmd/commits/4e3a4abbe2a7bcce69f07249b4665779f8a1488f"},{"sha":"1f0e6bb337ec1ca2fd5fe39c8295666b3a85dea2","author":{"email":"1a73af9e7ae00182733b2292511b814be66f065f@micbou.com","name":"micbou"},"message":"Convert paths to short path name on Windows\n\npython2 fails to spawn a process from a command containing unicode\ncharacters on Windows.  See https://bugs.python.org/issue19264 and\nhttp://bugs.python.org/issue1759845.\nSince paths are likely to contains such characters, we convert them\nto short ones to obtain paths with only ascii characters.\nFix GetCompletions_CsCompleter_PathWithSpace test.","distinct":true,"url":"https://api.github.com/repos/mispencer/ycmd/commits/1f0e6bb337ec1ca2fd5fe39c8295666b3a85dea2"},{"sha":"ef97962dee1022f8064ea9b3031fdcf76b19f0d9","author":{"email":"5c2bd99229d434a2f7174ea3f8798d821bc7f9ae@barosl.com","name":"Homu"},"message":"Auto merge of #211 - micbou:windows-short-path-name, r=micbou\n\n[Windows support] Convert paths to short path name on Windows\n\nPython 2 fails to execute a command with unicode characters on Windows. In ycmd case, only paths in command are likely to contain such characters so the trick is to convert them to short path name (also called 8.3 path or DOS path) which only contains ascii characters.\r\n\r\nFix GetCompletions_CsCompleter_PathWithSpace test.","distinct":true,"url":"https://api.github.com/repos/mispencer/ycmd/commits/ef97962dee1022f8064ea9b3031fdcf76b19f0d9"},{"sha":"1c15395985a31fdca2b91ff2a0882ea4c3aa53b8","author":{"email":"3ea746b47d9514139cf1a574eb74d109fce348b0@gmail.com","name":"Neo Mofoka"},"message":"Added doc string to test utility function and made style compliance changes.","distinct":true,"url":"https://api.github.com/repos/mispencer/ycmd/commits/1c15395985a31fdca2b91ff2a0882ea4c3aa53b8"},{"sha":"9b9766b86a2df484fade961600615ff7e4032dea","author":{"email":"1a73af9e7ae00182733b2292511b814be66f065f@micbou.com","name":"micbou"},"message":"Bump Clang version to 3.7.0","distinct":true,"url":"https://api.github.com/repos/mispencer/ycmd/commits/9b9766b86a2df484fade961600615ff7e4032dea"},{"sha":"61ba1985c61a35ad7ba6b05094558781128277df","author":{"email":"1a73af9e7ae00182733b2292511b814be66f065f@micbou.com","name":"micbou"},"message":"Use symlinked Clang library target\n\nIn Clang 3.7, the library target is a symlink of the soversion one.\nSince it will be copied in the project folder, we need the symlinked\nlibrary.","distinct":true,"url":"https://api.github.com/repos/mispencer/ycmd/commits/61ba1985c61a35ad7ba6b05094558781128277df"},{"sha":"2066fe19829a49e49ea4b4dce830c6f9501d18cd","author":{"email":"5c2bd99229d434a2f7174ea3f8798d821bc7f9ae@barosl.com","name":"Homu"},"message":"Auto merge of #212 - jeteon:patch-1, r=Valloric\n\nFix flaky regular expression comparison test\n\nThe proposed change is to fix the test `ycmd.completers.completer_utils_test.FiletypeTriggerDictFromSpec_Works_test` which previoulsy used an equality check which relied on `_sre.SRE_Pattern` objects in the dictionary being the same instances. However, this is not reliable as demonstrated in spurious test failures in https://github.com/Valloric/ycmd/pull/120.\r\n\r\nIn the instances where this test works it is relying on the call to `re.compile()` caching results and returning the same objects for the same patterns. The Python [docs](https://docs.python.org/2/library/re.html#re.compile) state that:\r\n> The compiled versions of the most recent patterns passed to `re.match()`, `re.search()` or `re.compile()` are cached, so programs that use only a few regular expressions at a time needn’t worry about compiling regular expressions. \r\n\r\nNote that there is no guarantee of the cached versions being returned each time. The update to the test instead compares the `sre.SRE_Pattern.pattern` strings which can be used to reasonably say whether two of the objects represent the same pattern without being the same object necessarily.","distinct":true,"url":"https://api.github.com/repos/mispencer/ycmd/commits/2066fe19829a49e49ea4b4dce830c6f9501d18cd"},{"sha":"c11c6a74866f547a335fc93c346d9a6b7e8cb2eb","author":{"email":"1a73af9e7ae00182733b2292511b814be66f065f@micbou.com","name":"micbou"},"message":"Remove system headers from C++ tests\n\nUsing system headers in C++ tests require us to pass include paths to Clang.\nThose paths depend on the platform which make the corresponding tests\ndifficult to maintain.  In addition, testing the system headers is not the\npoint of those tests.  Therefore, we remove those headers.","distinct":true,"url":"https://api.github.com/repos/mispencer/ycmd/commits/c11c6a74866f547a335fc93c346d9a6b7e8cb2eb"},{"sha":"9c0d4bb96c323bbe756fe24eb7a6576e990ea9e7","author":{"email":"5c2bd99229d434a2f7174ea3f8798d821bc7f9ae@barosl.com","name":"Homu"},"message":"Auto merge of #217 - micbou:clang-3.7.0, r=Valloric\n\n[WIP] Bump Clang version to 3.7.0\n\nI encountered two issues with the new Clang version.\r\n\r\nFirst one was that the `libclang.so` library in the Clang binaries for Ubuntu is a symlink of `libclang.so.3.7`. Since `cmake -E copy` resolves symlinks, `cmake` will copy the `libclang.so.3.7` file but with the wrong destination file name `libclang.so`. Thus, `ycmd` will fail to start because it will try to load the `libclang.so.3.7` file instead of `libclang.so`. I fixed this by setting the `LIBCLANG_TARGET` to the path of the symlinked library.\r\n\r\nSecond one is where I am stuck. One test is failing:\r\n```\r\n======================================================================\r\nFAIL: ycmd.tests.subcommands_test.RunCompleterCommand_GetType_Clang_test('GetType_Clang_test.cc', [{'column_num': 16, 'line_num': 27}, 'Std::String => Std::BasicString<char>'], ['GetType'])\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/home/travis/virtualenv/python2.6.9/lib/python2.6/site-packages/nose/case.py\", line 197, in runTest\r\n    self.test(*self.arg)\r\n  File \"/home/travis/build/micbou/ycmd/ycmd/tests/subcommands_test.py\", line 248, in _RunCompleterCommand_Message_Clang\r\n    app.post_json( '/run_completer_command', request_data ).json )\r\nAssertionError: {'message': 'Std::String => Std::BasicString<char>'} != {u'message': u'Unknown type'}\r\n```\r\nWhat is really strange is that it is returning the correct value when directly doing `:YcmCompleter GetType` at the location `(27,16)` in the `GetType_Clang_Test.cc` file.\r\n\r\nI am still investigating the issue but I will certainly need help on this one.","distinct":true,"url":"https://api.github.com/repos/mispencer/ycmd/commits/9c0d4bb96c323bbe756fe24eb7a6576e990ea9e7"},{"sha":"c27cc30d3cdf988aacdf2170cd3633b3bc7c162f","author":{"email":"3bc6f2208b90542717470de5278f48ae0e983c97@egovmt.com","name":"Spencer G. Jones"},"message":"Allow overriding the omnisharp path by instance","distinct":true,"url":"https://api.github.com/repos/mispencer/ycmd/commits/c27cc30d3cdf988aacdf2170cd3633b3bc7c162f"},{"sha":"46130f175e0218018f6a09d360e582de2517242e","author":{"email":"3bc6f2208b90542717470de5278f48ae0e983c97@egovmt.com","name":"Spencer G. Jones"},"message":"Support using omnisharp-roslyn","distinct":true,"url":"https://api.github.com/repos/mispencer/ycmd/commits/46130f175e0218018f6a09d360e582de2517242e"},{"sha":"f7d666202a8bad33b1043f0ff3f7a7617b47eb05","author":{"email":"3bc6f2208b90542717470de5278f48ae0e983c97@egovmt.com","name":"Spencer G. Jones"},"message":"Longer timeout","distinct":true,"url":"https://api.github.com/repos/mispencer/ycmd/commits/f7d666202a8bad33b1043f0ff3f7a7617b47eb05"},{"sha":"962747ba4c419cc886a0cf6d696151354a9153d3","author":{"email":"3bc6f2208b90542717470de5278f48ae0e983c97@egovmt.com","name":"Spencer G. Jones"},"message":"Switch roslyn to stdio","distinct":true,"url":"https://api.github.com/repos/mispencer/ycmd/commits/962747ba4c419cc886a0cf6d696151354a9153d3"},{"sha":"108a0e475b1a6e229bb664ae0fa743c9974b0e26","author":{"email":"3bc6f2208b90542717470de5278f48ae0e983c97@egovmt.com","name":"Spencer G. Jones"},"message":"fixup! Switch roslyn to stdio","distinct":true,"url":"https://api.github.com/repos/mispencer/ycmd/commits/108a0e475b1a6e229bb664ae0fa743c9974b0e26"},{"sha":"1a3c42efd3b61d105319863c714dfba58d5c9e91","author":{"email":"3bc6f2208b90542717470de5278f48ae0e983c97@egovmt.com","name":"Spencer G. Jones"},"message":"fixup! Switch roslyn to stdio","distinct":true,"url":"https://api.github.com/repos/mispencer/ycmd/commits/1a3c42efd3b61d105319863c714dfba58d5c9e91"},{"sha":"4f16e73c7a69170feadae94efabb32990e5f2c80","author":{"email":"3bc6f2208b90542717470de5278f48ae0e983c97@egovmt.com","name":"Spencer G. Jones"},"message":"fixup! Switch roslyn to stdio","distinct":true,"url":"https://api.github.com/repos/mispencer/ycmd/commits/4f16e73c7a69170feadae94efabb32990e5f2c80"}]}