{"action":"created","issue":{"url":"https://api.github.com/repos/ericclemmons/react-resolver/issues/36","labels_url":"https://api.github.com/repos/ericclemmons/react-resolver/issues/36/labels{/name}","comments_url":"https://api.github.com/repos/ericclemmons/react-resolver/issues/36/comments","events_url":"https://api.github.com/repos/ericclemmons/react-resolver/issues/36/events","html_url":"https://github.com/ericclemmons/react-resolver/issues/36","id":70486465,"number":36,"title":"Should props should propagate?","user":{"login":"ericclemmons","id":15182,"avatar_url":"https://avatars.githubusercontent.com/u/15182?v=3","gravatar_id":"","url":"https://api.github.com/users/ericclemmons","html_url":"https://github.com/ericclemmons","followers_url":"https://api.github.com/users/ericclemmons/followers","following_url":"https://api.github.com/users/ericclemmons/following{/other_user}","gists_url":"https://api.github.com/users/ericclemmons/gists{/gist_id}","starred_url":"https://api.github.com/users/ericclemmons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericclemmons/subscriptions","organizations_url":"https://api.github.com/users/ericclemmons/orgs","repos_url":"https://api.github.com/users/ericclemmons/repos","events_url":"https://api.github.com/users/ericclemmons/events{/privacy}","received_events_url":"https://api.github.com/users/ericclemmons/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ericclemmons/react-resolver/labels/question","name":"question","color":"cc317c"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-04-23T18:58:01Z","updated_at":"2015-05-20T18:01:13Z","closed_at":null,"body":"This would technically be a BC break, but I encountered a situation today where \"hiding\" props didn't help.\r\n\r\nTake `Stargazers.js`, for example:\r\n> https://github.com/ericclemmons/react-resolver/blob/ca5a8c9717ec2aaa0165b7b5e5e3696f1e62d477/examples/stargazers/components/Stargazers.js#L68-L80\r\n\r\n`<Stargazers />` requires a `users` prop, but the `<StargazersContainer />` requires `user` and `repo` to fetch the data for `users`.\r\n\r\nAs a result, `<Stargazers />` **does not** have access to `user` or `repo`.\r\n\r\nThis gets slightly annoying when composing multiple containers, as you pass parent props down the chain:\r\n\r\n```javascript\r\nresolve: {\r\n  something: (props) => props.something\r\n}\r\n```\r\n\r\nMy gut says that this mild inconvenience can be solved through another means, and that the base component **shouldn't** expect parent props to be leaked through..."},"comment":{"url":"https://api.github.com/repos/ericclemmons/react-resolver/issues/comments/103975518","html_url":"https://github.com/ericclemmons/react-resolver/issues/36#issuecomment-103975518","issue_url":"https://api.github.com/repos/ericclemmons/react-resolver/issues/36","id":103975518,"user":{"login":"iamdustan","id":227879,"avatar_url":"https://avatars.githubusercontent.com/u/227879?v=3","gravatar_id":"","url":"https://api.github.com/users/iamdustan","html_url":"https://github.com/iamdustan","followers_url":"https://api.github.com/users/iamdustan/followers","following_url":"https://api.github.com/users/iamdustan/following{/other_user}","gists_url":"https://api.github.com/users/iamdustan/gists{/gist_id}","starred_url":"https://api.github.com/users/iamdustan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamdustan/subscriptions","organizations_url":"https://api.github.com/users/iamdustan/orgs","repos_url":"https://api.github.com/users/iamdustan/repos","events_url":"https://api.github.com/users/iamdustan/events{/privacy}","received_events_url":"https://api.github.com/users/iamdustan/received_events","type":"User","site_admin":false},"created_at":"2015-05-20T18:01:13Z","updated_at":"2015-05-20T18:01:13Z","body":"sooooo do you have it implemented yet? :)"}}