{"action":"closed","number":676,"pull_request":{"url":"https://api.github.com/repos/spinnaker/orca/pulls/676","id":52701725,"html_url":"https://github.com/spinnaker/orca/pull/676","diff_url":"https://github.com/spinnaker/orca/pull/676.diff","patch_url":"https://github.com/spinnaker/orca/pull/676.patch","issue_url":"https://api.github.com/repos/spinnaker/orca/issues/676","number":676,"state":"closed","locked":false,"title":"add bakeExists flag if createBake returns COMPLETED","user":{"login":"anotherchrisberry","id":73450,"avatar_url":"https://avatars.githubusercontent.com/u/73450?v=3","gravatar_id":"","url":"https://api.github.com/users/anotherchrisberry","html_url":"https://github.com/anotherchrisberry","followers_url":"https://api.github.com/users/anotherchrisberry/followers","following_url":"https://api.github.com/users/anotherchrisberry/following{/other_user}","gists_url":"https://api.github.com/users/anotherchrisberry/gists{/gist_id}","starred_url":"https://api.github.com/users/anotherchrisberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anotherchrisberry/subscriptions","organizations_url":"https://api.github.com/users/anotherchrisberry/orgs","repos_url":"https://api.github.com/users/anotherchrisberry/repos","events_url":"https://api.github.com/users/anotherchrisberry/events{/privacy}","received_events_url":"https://api.github.com/users/anotherchrisberry/received_events","type":"User","site_admin":false},"body":"The goal is to surface this in the UI, letting users know that an actual bake did not occur and we are instead using a previously baked artifact.\r\n\r\nWhen performing a bake (at least via the internal Netflix bakery), there are two signals that the requested bake already exists:\r\n1. The response status code from the API call is 200 instead of 202\r\n2. The status of the returned bake is `COMPLETED` instead of `RUNNING`\r\n\r\nI do not see a clean way of getting at the status code on a successful bake call via Retrofit+OkClient, so am going with (2), which is probably more straightforward, anyway.\r\n\r\nNot in love with the flag name (`bakeExists`) and am open to suggestions there.\r\n\r\n@robfletcher @duftler please review","created_at":"2015-12-04T18:07:47Z","updated_at":"2015-12-07T15:29:07Z","closed_at":"2015-12-07T15:29:07Z","merged_at":"2015-12-07T15:29:07Z","merge_commit_sha":"d7f38483a1e91246091c4d77cfc9aa9b3a795914","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/orca/pulls/676/commits","review_comments_url":"https://api.github.com/repos/spinnaker/orca/pulls/676/comments","review_comment_url":"https://api.github.com/repos/spinnaker/orca/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/orca/issues/676/comments","statuses_url":"https://api.github.com/repos/spinnaker/orca/statuses/6e14b868ba7ccc45dbd6ccabb5d136e32c8cef06","head":{"label":"anotherchrisberry:bake-exists-flag","ref":"bake-exists-flag","sha":"6e14b868ba7ccc45dbd6ccabb5d136e32c8cef06","user":{"login":"anotherchrisberry","id":73450,"avatar_url":"https://avatars.githubusercontent.com/u/73450?v=3","gravatar_id":"","url":"https://api.github.com/users/anotherchrisberry","html_url":"https://github.com/anotherchrisberry","followers_url":"https://api.github.com/users/anotherchrisberry/followers","following_url":"https://api.github.com/users/anotherchrisberry/following{/other_user}","gists_url":"https://api.github.com/users/anotherchrisberry/gists{/gist_id}","starred_url":"https://api.github.com/users/anotherchrisberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anotherchrisberry/subscriptions","organizations_url":"https://api.github.com/users/anotherchrisberry/orgs","repos_url":"https://api.github.com/users/anotherchrisberry/repos","events_url":"https://api.github.com/users/anotherchrisberry/events{/privacy}","received_events_url":"https://api.github.com/users/anotherchrisberry/received_events","type":"User","site_admin":false},"repo":{"id":47278146,"name":"orca","full_name":"anotherchrisberry/orca","owner":{"login":"anotherchrisberry","id":73450,"avatar_url":"https://avatars.githubusercontent.com/u/73450?v=3","gravatar_id":"","url":"https://api.github.com/users/anotherchrisberry","html_url":"https://github.com/anotherchrisberry","followers_url":"https://api.github.com/users/anotherchrisberry/followers","following_url":"https://api.github.com/users/anotherchrisberry/following{/other_user}","gists_url":"https://api.github.com/users/anotherchrisberry/gists{/gist_id}","starred_url":"https://api.github.com/users/anotherchrisberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anotherchrisberry/subscriptions","organizations_url":"https://api.github.com/users/anotherchrisberry/orgs","repos_url":"https://api.github.com/users/anotherchrisberry/repos","events_url":"https://api.github.com/users/anotherchrisberry/events{/privacy}","received_events_url":"https://api.github.com/users/anotherchrisberry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anotherchrisberry/orca","description":"orchestration engine","fork":true,"url":"https://api.github.com/repos/anotherchrisberry/orca","forks_url":"https://api.github.com/repos/anotherchrisberry/orca/forks","keys_url":"https://api.github.com/repos/anotherchrisberry/orca/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anotherchrisberry/orca/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anotherchrisberry/orca/teams","hooks_url":"https://api.github.com/repos/anotherchrisberry/orca/hooks","issue_events_url":"https://api.github.com/repos/anotherchrisberry/orca/issues/events{/number}","events_url":"https://api.github.com/repos/anotherchrisberry/orca/events","assignees_url":"https://api.github.com/repos/anotherchrisberry/orca/assignees{/user}","branches_url":"https://api.github.com/repos/anotherchrisberry/orca/branches{/branch}","tags_url":"https://api.github.com/repos/anotherchrisberry/orca/tags","blobs_url":"https://api.github.com/repos/anotherchrisberry/orca/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anotherchrisberry/orca/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anotherchrisberry/orca/git/refs{/sha}","trees_url":"https://api.github.com/repos/anotherchrisberry/orca/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anotherchrisberry/orca/statuses/{sha}","languages_url":"https://api.github.com/repos/anotherchrisberry/orca/languages","stargazers_url":"https://api.github.com/repos/anotherchrisberry/orca/stargazers","contributors_url":"https://api.github.com/repos/anotherchrisberry/orca/contributors","subscribers_url":"https://api.github.com/repos/anotherchrisberry/orca/subscribers","subscription_url":"https://api.github.com/repos/anotherchrisberry/orca/subscription","commits_url":"https://api.github.com/repos/anotherchrisberry/orca/commits{/sha}","git_commits_url":"https://api.github.com/repos/anotherchrisberry/orca/git/commits{/sha}","comments_url":"https://api.github.com/repos/anotherchrisberry/orca/comments{/number}","issue_comment_url":"https://api.github.com/repos/anotherchrisberry/orca/issues/comments{/number}","contents_url":"https://api.github.com/repos/anotherchrisberry/orca/contents/{+path}","compare_url":"https://api.github.com/repos/anotherchrisberry/orca/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anotherchrisberry/orca/merges","archive_url":"https://api.github.com/repos/anotherchrisberry/orca/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anotherchrisberry/orca/downloads","issues_url":"https://api.github.com/repos/anotherchrisberry/orca/issues{/number}","pulls_url":"https://api.github.com/repos/anotherchrisberry/orca/pulls{/number}","milestones_url":"https://api.github.com/repos/anotherchrisberry/orca/milestones{/number}","notifications_url":"https://api.github.com/repos/anotherchrisberry/orca/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anotherchrisberry/orca/labels{/name}","releases_url":"https://api.github.com/repos/anotherchrisberry/orca/releases{/id}","created_at":"2015-12-02T17:51:40Z","updated_at":"2015-12-02T17:51:43Z","pushed_at":"2015-12-07T15:15:10Z","git_url":"git://github.com/anotherchrisberry/orca.git","ssh_url":"git@github.com:anotherchrisberry/orca.git","clone_url":"https://github.com/anotherchrisberry/orca.git","svn_url":"https://github.com/anotherchrisberry/orca","homepage":"","size":5409,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"9d81c1586c4d2747a9c0c357626122d87ab2515a","user":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":19834314,"name":"orca","full_name":"spinnaker/orca","owner":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinnaker/orca","description":"orchestration engine","fork":false,"url":"https://api.github.com/repos/spinnaker/orca","forks_url":"https://api.github.com/repos/spinnaker/orca/forks","keys_url":"https://api.github.com/repos/spinnaker/orca/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/orca/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/orca/teams","hooks_url":"https://api.github.com/repos/spinnaker/orca/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/orca/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/orca/events","assignees_url":"https://api.github.com/repos/spinnaker/orca/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/orca/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/orca/tags","blobs_url":"https://api.github.com/repos/spinnaker/orca/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/orca/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/orca/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/orca/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/orca/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/orca/languages","stargazers_url":"https://api.github.com/repos/spinnaker/orca/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/orca/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/orca/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/orca/subscription","commits_url":"https://api.github.com/repos/spinnaker/orca/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/orca/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/orca/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/orca/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/orca/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/orca/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/orca/merges","archive_url":"https://api.github.com/repos/spinnaker/orca/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/orca/downloads","issues_url":"https://api.github.com/repos/spinnaker/orca/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/orca/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/orca/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/orca/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/orca/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/orca/releases{/id}","created_at":"2014-05-15T20:33:00Z","updated_at":"2015-12-07T03:54:48Z","pushed_at":"2015-12-07T15:29:07Z","git_url":"git://github.com/spinnaker/orca.git","ssh_url":"git@github.com:spinnaker/orca.git","clone_url":"https://github.com/spinnaker/orca.git","svn_url":"https://github.com/spinnaker/orca","homepage":"","size":5584,"stargazers_count":12,"watchers_count":12,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":47,"forks":26,"open_issues":47,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/676"},"html":{"href":"https://github.com/spinnaker/orca/pull/676"},"issue":{"href":"https://api.github.com/repos/spinnaker/orca/issues/676"},"comments":{"href":"https://api.github.com/repos/spinnaker/orca/issues/676/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/676/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/676/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/orca/statuses/6e14b868ba7ccc45dbd6ccabb5d136e32c8cef06"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"anotherchrisberry","id":73450,"avatar_url":"https://avatars.githubusercontent.com/u/73450?v=3","gravatar_id":"","url":"https://api.github.com/users/anotherchrisberry","html_url":"https://github.com/anotherchrisberry","followers_url":"https://api.github.com/users/anotherchrisberry/followers","following_url":"https://api.github.com/users/anotherchrisberry/following{/other_user}","gists_url":"https://api.github.com/users/anotherchrisberry/gists{/gist_id}","starred_url":"https://api.github.com/users/anotherchrisberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anotherchrisberry/subscriptions","organizations_url":"https://api.github.com/users/anotherchrisberry/orgs","repos_url":"https://api.github.com/users/anotherchrisberry/repos","events_url":"https://api.github.com/users/anotherchrisberry/events{/privacy}","received_events_url":"https://api.github.com/users/anotherchrisberry/received_events","type":"User","site_admin":false},"comments":5,"review_comments":3,"commits":1,"additions":31,"deletions":3,"changed_files":2}}