{"action":"created","issue":{"url":"https://api.github.com/repos/rschroll/addtodash/issues/9","labels_url":"https://api.github.com/repos/rschroll/addtodash/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/rschroll/addtodash/issues/9/comments","events_url":"https://api.github.com/repos/rschroll/addtodash/issues/9/events","html_url":"https://github.com/rschroll/addtodash/pull/9","id":105924046,"number":9,"title":"Parse HTML data in a webview","user":{"login":"stuartlangridge","id":4356350,"avatar_url":"https://avatars.githubusercontent.com/u/4356350?v=3","gravatar_id":"","url":"https://api.github.com/users/stuartlangridge","html_url":"https://github.com/stuartlangridge","followers_url":"https://api.github.com/users/stuartlangridge/followers","following_url":"https://api.github.com/users/stuartlangridge/following{/other_user}","gists_url":"https://api.github.com/users/stuartlangridge/gists{/gist_id}","starred_url":"https://api.github.com/users/stuartlangridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stuartlangridge/subscriptions","organizations_url":"https://api.github.com/users/stuartlangridge/orgs","repos_url":"https://api.github.com/users/stuartlangridge/repos","events_url":"https://api.github.com/users/stuartlangridge/events{/privacy}","received_events_url":"https://api.github.com/users/stuartlangridge/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-11T00:31:39Z","updated_at":"2015-09-11T06:09:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rschroll/addtodash/pulls/9","html_url":"https://github.com/rschroll/addtodash/pull/9","diff_url":"https://github.com/rschroll/addtodash/pull/9.diff","patch_url":"https://github.com/rschroll/addtodash/pull/9.patch"},"body":"Allow passing a URL on the command line (`qmlscene app/Main.qml http://mikemai.net/demos/ios-web-app.html` is dead handy, and we don't have to parse the arguments properly because we just look for the one which is a URL!).\r\n\r\nLoad the requested URL in an invisible webview and parse data out of it to get title and icon.\r\n\r\nWe need to actually fetch the icon itself, not just display the remote one, and at the moment we just use the first icon we find (and probably blow up if there isn't one) rather than correctly choosing the one we want. But, progress.\r\n\r\n(Work on issue #2)"},"comment":{"url":"https://api.github.com/repos/rschroll/addtodash/issues/comments/139461563","html_url":"https://github.com/rschroll/addtodash/pull/9#issuecomment-139461563","issue_url":"https://api.github.com/repos/rschroll/addtodash/issues/9","id":139461563,"user":{"login":"rschroll","id":367903,"avatar_url":"https://avatars.githubusercontent.com/u/367903?v=3","gravatar_id":"","url":"https://api.github.com/users/rschroll","html_url":"https://github.com/rschroll","followers_url":"https://api.github.com/users/rschroll/followers","following_url":"https://api.github.com/users/rschroll/following{/other_user}","gists_url":"https://api.github.com/users/rschroll/gists{/gist_id}","starred_url":"https://api.github.com/users/rschroll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rschroll/subscriptions","organizations_url":"https://api.github.com/users/rschroll/orgs","repos_url":"https://api.github.com/users/rschroll/repos","events_url":"https://api.github.com/users/rschroll/events{/privacy}","received_events_url":"https://api.github.com/users/rschroll/received_events","type":"User","site_admin":false},"created_at":"2015-09-11T06:09:12Z","updated_at":"2015-09-11T06:09:12Z","body":"Yeah, this breaks if it can't find an icon.  There are several places \nwhere this could be solved; I don't know which is best offhand.  It's \nprobably a good idea to check for favicons and opengraph images as \nwell, but the only think I want right now is for it to not break.\n\nCan we try to keep lines under ~100 characters?  I'm sure I'm breaking \nthis rule some places already, but I like to avoid horizontal scrolling \nin my editor if possible.  Two places jump out at me: line 216 of \nMain.qml and line 11 of manifestParser.js.  This latter has so much \ngoing on that it's nearly impossible to read.  Let's break the \nquerySelector out into its own statement.\n\nSpeaking of pedantry, I like the \"short summary (< 72 chars) followed \nby the longer paragraph (if needed) description\" format for commit \nmessages.  I wouldn't reject a commit over this, but I might edit the \nmessage myself....\n\n"}}