{"action":"created","issue":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/1924","labels_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/1924/labels{/name}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/1924/comments","events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/1924/events","html_url":"https://github.com/MinecraftForge/MinecraftForge/issues/1924","id":86292838,"number":1924,"title":"[1.8] Vanilla client login crash or packet spam on 1.8 forge, versions 1290 and latest 1436","user":{"login":"Corosauce","id":1238621,"avatar_url":"https://avatars.githubusercontent.com/u/1238621?v=3","gravatar_id":"","url":"https://api.github.com/users/Corosauce","html_url":"https://github.com/Corosauce","followers_url":"https://api.github.com/users/Corosauce/followers","following_url":"https://api.github.com/users/Corosauce/following{/other_user}","gists_url":"https://api.github.com/users/Corosauce/gists{/gist_id}","starred_url":"https://api.github.com/users/Corosauce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Corosauce/subscriptions","organizations_url":"https://api.github.com/users/Corosauce/orgs","repos_url":"https://api.github.com/users/Corosauce/repos","events_url":"https://api.github.com/users/Corosauce/events{/privacy}","received_events_url":"https://api.github.com/users/Corosauce/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-08T19:01:08Z","updated_at":"2015-06-08T20:27:03Z","closed_at":null,"body":"When a vanilla client logs in to a server modded forge, there is an intermittent but common server crash that occurs, and if it happens to not crash, \"unexpected packet during modded negotiation\" spam occurs in console until player reconnects (which it could crash upon reconnect).\r\n\r\nWas having the issue with forge 1290 and just confirmed it still happens on 1436.\r\n\r\nLog of crash, took about 5 login attempts: https://gist.githubusercontent.com/Corosauce/f8c6b6476e0dcd5d854c/raw/26741bfcd0535974961338ff1986fa6a88eb0a2c/gistfile1.txt\r\n\r\nLog of packet spam if crash doesn't occur: https://gist.githubusercontent.com/Corosauce/107f770e70d2ae5c7431/raw/c45e11bad5259e4210349ee08b0aa77a8ce28e0c/gistfile1.txt\r\n\r\nI have not been able to reproduce this when testing a server and client that are on the same local machine, only with remote servers that are far away, possibly a packet order issue caused by latency to server.\r\n\r\nEnvironment reproduced on:\r\n- Amazon Linux AMI server (happens frequently on this one, much less frequently on other servers)\r\n- A Fresh install of forge 1436\r\n- A vanilla client using version 1.8\r\n\r\nTo reproduce:\r\n1. Install forge 1436 to the Amazon Linux AMI server\r\n2. run it with: java -jar forge-1.8-11.14.2.1436-universal.jar\r\n3. Start up a Vanilla MC 1.8 Client (not 1.8.4 or anything, just plain 1.8)\r\n4. Connect to server that is in another country or at the very least, not locally connected so there is real latency, reconnect until crash occurs, usually happens in less than 5 reconnects.\r\n\r\nA short sighted way to patch the problem:\r\n- Comment out this line that does \"player.playerNetServerHandler = null;\" https://github.com/MinecraftForge/MinecraftForge/blob/master/fml/src/main/java/net/minecraftforge/fml/common/network/handshake/NetworkDispatcher.java#L188\r\n\r\nOf course my patch is not a very clean idea, but we are launching a service that is going into production in a week and I needed a fix now. As far as I can tell, commenting out that line and the line that logs the packet spam lets the server function as it should. \r\n\r\nBut if you guys could investigate the true cause to this and resolve it that would be much appreciated so we could integrate the proper solution into our production environment.\r\n\r\nThe Amazon Linux AMI server my work has provided me is the only server I have been able to reliably reproduce this issue on, if you require access to it to test, contact me on irc (Corosus), you know where to find me ;)"},"comment":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/comments/110127359","html_url":"https://github.com/MinecraftForge/MinecraftForge/issues/1924#issuecomment-110127359","issue_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/1924","id":110127359,"user":{"login":"LexManos","id":702211,"avatar_url":"https://avatars.githubusercontent.com/u/702211?v=3","gravatar_id":"","url":"https://api.github.com/users/LexManos","html_url":"https://github.com/LexManos","followers_url":"https://api.github.com/users/LexManos/followers","following_url":"https://api.github.com/users/LexManos/following{/other_user}","gists_url":"https://api.github.com/users/LexManos/gists{/gist_id}","starred_url":"https://api.github.com/users/LexManos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LexManos/subscriptions","organizations_url":"https://api.github.com/users/LexManos/orgs","repos_url":"https://api.github.com/users/LexManos/repos","events_url":"https://api.github.com/users/LexManos/events{/privacy}","received_events_url":"https://api.github.com/users/LexManos/received_events","type":"User","site_admin":false},"created_at":"2015-06-08T20:27:03Z","updated_at":"2015-06-08T20:27:03Z","body":"You 'Comment out' those lines and you completely bork the shit out of networking for mods, ID syncing, EVERYTHING.\r\nAnd commenting out the line that logs the protocol errors does not stop the errors -.-\r\nWhat 'service' are you 'launching'?"}}