{"action":"opened","number":153,"pull_request":{"url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/153","id":54507084,"html_url":"https://github.com/cisco/cisco-network-node-utils/pull/153","diff_url":"https://github.com/cisco/cisco-network-node-utils/pull/153.diff","patch_url":"https://github.com/cisco/cisco-network-node-utils/pull/153.patch","issue_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/153","number":153,"state":"open","locked":false,"title":"Error if keyword substitution yields empty result","user":{"login":"jamtaylo","id":16323934,"avatar_url":"https://avatars.githubusercontent.com/u/16323934?v=3","gravatar_id":"","url":"https://api.github.com/users/jamtaylo","html_url":"https://github.com/jamtaylo","followers_url":"https://api.github.com/users/jamtaylo/followers","following_url":"https://api.github.com/users/jamtaylo/following{/other_user}","gists_url":"https://api.github.com/users/jamtaylo/gists{/gist_id}","starred_url":"https://api.github.com/users/jamtaylo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamtaylo/subscriptions","organizations_url":"https://api.github.com/users/jamtaylo/orgs","repos_url":"https://api.github.com/users/jamtaylo/repos","events_url":"https://api.github.com/users/jamtaylo/events{/privacy}","received_events_url":"https://api.github.com/users/jamtaylo/received_events","type":"User","site_admin":false},"body":"When the command_reference config_get_token and config_set methods use\r\nkeyword-based parameter substitution, array elements that contain a\r\nparameter not supplied by the caller will be omitted from the result\r\narray.  This behavior is desired to support, e.g., CLI interaction\r\ninvolving VRFs, where both the presence or absence of a VRF are\r\npermissible and should result in CLI interaction either containing or\r\nnot containing a vrf statement.  However, this behavior makes it easy\r\nfor developer oversight or typo to result in an empty command line\r\n(which is bad).\r\n\r\nThis commit updates command_reference so that if the result of\r\nkeyword-based parameter substitution is an empty array then an\r\nArgumentError will be raised.  It also adds new assertions to test this\r\nbehavior to the existing test_config_get_token_hash_substitution test\r\ncase, and updates the documentation and changelog.","created_at":"2015-12-23T21:11:21Z","updated_at":"2015-12-23T21:11:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/153/commits","review_comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/153/comments","review_comment_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/153/comments","statuses_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/bfcc9c6f8494b4c214fff8ffb69e1edc4ace4ee4","head":{"label":"jamtaylo:US61997","ref":"US61997","sha":"bfcc9c6f8494b4c214fff8ffb69e1edc4ace4ee4","user":{"login":"jamtaylo","id":16323934,"avatar_url":"https://avatars.githubusercontent.com/u/16323934?v=3","gravatar_id":"","url":"https://api.github.com/users/jamtaylo","html_url":"https://github.com/jamtaylo","followers_url":"https://api.github.com/users/jamtaylo/followers","following_url":"https://api.github.com/users/jamtaylo/following{/other_user}","gists_url":"https://api.github.com/users/jamtaylo/gists{/gist_id}","starred_url":"https://api.github.com/users/jamtaylo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamtaylo/subscriptions","organizations_url":"https://api.github.com/users/jamtaylo/orgs","repos_url":"https://api.github.com/users/jamtaylo/repos","events_url":"https://api.github.com/users/jamtaylo/events{/privacy}","received_events_url":"https://api.github.com/users/jamtaylo/received_events","type":"User","site_admin":false},"repo":{"id":48121103,"name":"cisco-network-node-utils","full_name":"jamtaylo/cisco-network-node-utils","owner":{"login":"jamtaylo","id":16323934,"avatar_url":"https://avatars.githubusercontent.com/u/16323934?v=3","gravatar_id":"","url":"https://api.github.com/users/jamtaylo","html_url":"https://github.com/jamtaylo","followers_url":"https://api.github.com/users/jamtaylo/followers","following_url":"https://api.github.com/users/jamtaylo/following{/other_user}","gists_url":"https://api.github.com/users/jamtaylo/gists{/gist_id}","starred_url":"https://api.github.com/users/jamtaylo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamtaylo/subscriptions","organizations_url":"https://api.github.com/users/jamtaylo/orgs","repos_url":"https://api.github.com/users/jamtaylo/repos","events_url":"https://api.github.com/users/jamtaylo/events{/privacy}","received_events_url":"https://api.github.com/users/jamtaylo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jamtaylo/cisco-network-node-utils","description":"","fork":true,"url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils","forks_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/forks","keys_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/teams","hooks_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/hooks","issue_events_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/issues/events{/number}","events_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/events","assignees_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/assignees{/user}","branches_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/branches{/branch}","tags_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/tags","blobs_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/languages","stargazers_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/stargazers","contributors_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/contributors","subscribers_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/subscribers","subscription_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/subscription","commits_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/contents/{+path}","compare_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/merges","archive_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/downloads","issues_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/issues{/number}","pulls_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/labels{/name}","releases_url":"https://api.github.com/repos/jamtaylo/cisco-network-node-utils/releases{/id}","created_at":"2015-12-16T16:13:16Z","updated_at":"2015-12-16T16:13:17Z","pushed_at":"2015-12-23T21:05:53Z","git_url":"git://github.com/jamtaylo/cisco-network-node-utils.git","ssh_url":"git@github.com:jamtaylo/cisco-network-node-utils.git","clone_url":"https://github.com/jamtaylo/cisco-network-node-utils.git","svn_url":"https://github.com/jamtaylo/cisco-network-node-utils","homepage":null,"size":1572,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"feature/grpc"}},"base":{"label":"cisco:feature/grpc","ref":"feature/grpc","sha":"8f6afe2522bc244258bc9569e26effe56dd672dc","user":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"repo":{"id":39565196,"name":"cisco-network-node-utils","full_name":"cisco/cisco-network-node-utils","owner":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cisco/cisco-network-node-utils","description":"","fork":false,"url":"https://api.github.com/repos/cisco/cisco-network-node-utils","forks_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/forks","keys_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/teams","hooks_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/hooks","issue_events_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/events{/number}","events_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/events","assignees_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/assignees{/user}","branches_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/branches{/branch}","tags_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/tags","blobs_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/languages","stargazers_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/stargazers","contributors_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/contributors","subscribers_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/subscribers","subscription_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/subscription","commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/contents/{+path}","compare_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/merges","archive_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/downloads","issues_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues{/number}","pulls_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/labels{/name}","releases_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/releases{/id}","created_at":"2015-07-23T12:07:39Z","updated_at":"2015-12-17T07:37:55Z","pushed_at":"2015-12-23T21:05:40Z","git_url":"git://github.com/cisco/cisco-network-node-utils.git","ssh_url":"git@github.com:cisco/cisco-network-node-utils.git","clone_url":"https://github.com/cisco/cisco-network-node-utils.git","svn_url":"https://github.com/cisco/cisco-network-node-utils","homepage":null,"size":2847,"stargazers_count":7,"watchers_count":7,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":5,"forks":31,"open_issues":5,"watchers":7,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/153"},"html":{"href":"https://github.com/cisco/cisco-network-node-utils/pull/153"},"issue":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/153"},"comments":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/153/comments"},"review_comments":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/153/comments"},"review_comment":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/153/commits"},"statuses":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/bfcc9c6f8494b4c214fff8ffb69e1edc4ace4ee4"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":62,"deletions":24,"changed_files":4}}