{"action":"created","comment":{"url":"https://api.github.com/repos/apache/drill/pulls/comments/45407026","id":45407026,"diff_hunk":"@@ -17,40 +17,25 @@\n  */\n package org.apache.drill.exec.store.sys.zk;\n \n+import java.io.IOException;\n+\n import org.apache.curator.framework.CuratorFramework;\n import org.apache.drill.exec.store.sys.EStore;\n import org.apache.drill.exec.store.sys.PStoreConfig;\n import org.apache.zookeeper.CreateMode;\n \n-import java.io.IOException;\n-\n /**\n  * Implementation of EStore using Zookeeper's EPHEMERAL node.\n  * @param <V>\n  */\n-public class ZkEStore<V> extends ZkAbstractStore<V> implements EStore<V>{\n+public class ZkEStore<V> extends ZkAbstractStore<V> implements EStore<V> {\n \n-  public ZkEStore(CuratorFramework framework, PStoreConfig<V> config) throws IOException{\n+  public ZkEStore(CuratorFramework framework, PStoreConfig<V> config) throws IOException {\n     super(framework,config);\n   }\n \n   @Override\n-  public void delete(String key) {\n-    try {\n-      if (framework.checkExists().forPath(p(key)) != null) {\n-        framework.delete().forPath(p(key));","path":"exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/zk/ZkEStore.java","position":29,"original_position":29,"commit_id":"963c6da63474f7019bb55419b8bc6710e5b67698","original_commit_id":"963c6da63474f7019bb55419b8bc6710e5b67698","user":{"login":"hnfgns","id":3476250,"avatar_url":"https://avatars.githubusercontent.com/u/3476250?v=3","gravatar_id":"","url":"https://api.github.com/users/hnfgns","html_url":"https://github.com/hnfgns","followers_url":"https://api.github.com/users/hnfgns/followers","following_url":"https://api.github.com/users/hnfgns/following{/other_user}","gists_url":"https://api.github.com/users/hnfgns/gists{/gist_id}","starred_url":"https://api.github.com/users/hnfgns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hnfgns/subscriptions","organizations_url":"https://api.github.com/users/hnfgns/orgs","repos_url":"https://api.github.com/users/hnfgns/repos","events_url":"https://api.github.com/users/hnfgns/events{/privacy}","received_events_url":"https://api.github.com/users/hnfgns/received_events","type":"User","site_admin":false},"body":"This ensures that the cache is updated after deletion takes place.","created_at":"2015-11-19T21:59:32Z","updated_at":"2015-11-19T21:59:32Z","html_url":"https://github.com/apache/drill/pull/260#discussion_r45407026","pull_request_url":"https://api.github.com/repos/apache/drill/pulls/260","_links":{"self":{"href":"https://api.github.com/repos/apache/drill/pulls/comments/45407026"},"html":{"href":"https://github.com/apache/drill/pull/260#discussion_r45407026"},"pull_request":{"href":"https://api.github.com/repos/apache/drill/pulls/260"}}},"pull_request":{"url":"https://api.github.com/repos/apache/drill/pulls/260","id":50849719,"html_url":"https://github.com/apache/drill/pull/260","diff_url":"https://github.com/apache/drill/pull/260.diff","patch_url":"https://github.com/apache/drill/pull/260.patch","issue_url":"https://api.github.com/repos/apache/drill/issues/260","number":260,"state":"open","locked":false,"title":"DRILL-3171: handle concurrent Zookeeper node creation gracefully","user":{"login":"hnfgns","id":3476250,"avatar_url":"https://avatars.githubusercontent.com/u/3476250?v=3","gravatar_id":"","url":"https://api.github.com/users/hnfgns","html_url":"https://github.com/hnfgns","followers_url":"https://api.github.com/users/hnfgns/followers","following_url":"https://api.github.com/users/hnfgns/following{/other_user}","gists_url":"https://api.github.com/users/hnfgns/gists{/gist_id}","starred_url":"https://api.github.com/users/hnfgns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hnfgns/subscriptions","organizations_url":"https://api.github.com/users/hnfgns/orgs","repos_url":"https://api.github.com/users/hnfgns/repos","events_url":"https://api.github.com/users/hnfgns/events{/privacy}","received_events_url":"https://api.github.com/users/hnfgns/received_events","type":"User","site_admin":false},"body":"Make ZK node creation/updates logic optimistic.\r\nRefactor ZkAbstractStore to eliminate redundant code around node creation logic.\r\nEnhanced documentation.","created_at":"2015-11-16T18:52:54Z","updated_at":"2015-11-19T21:59:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f9550e058a4259ea747d1d3cb5b8c5bcc617400","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/drill/pulls/260/commits","review_comments_url":"https://api.github.com/repos/apache/drill/pulls/260/comments","review_comment_url":"https://api.github.com/repos/apache/drill/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/drill/issues/260/comments","statuses_url":"https://api.github.com/repos/apache/drill/statuses/963c6da63474f7019bb55419b8bc6710e5b67698","head":{"label":"hnfgns:DRILL-3171","ref":"DRILL-3171","sha":"963c6da63474f7019bb55419b8bc6710e5b67698","user":{"login":"hnfgns","id":3476250,"avatar_url":"https://avatars.githubusercontent.com/u/3476250?v=3","gravatar_id":"","url":"https://api.github.com/users/hnfgns","html_url":"https://github.com/hnfgns","followers_url":"https://api.github.com/users/hnfgns/followers","following_url":"https://api.github.com/users/hnfgns/following{/other_user}","gists_url":"https://api.github.com/users/hnfgns/gists{/gist_id}","starred_url":"https://api.github.com/users/hnfgns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hnfgns/subscriptions","organizations_url":"https://api.github.com/users/hnfgns/orgs","repos_url":"https://api.github.com/users/hnfgns/repos","events_url":"https://api.github.com/users/hnfgns/events{/privacy}","received_events_url":"https://api.github.com/users/hnfgns/received_events","type":"User","site_admin":false},"repo":{"id":22357423,"name":"incubator-drill","full_name":"hnfgns/incubator-drill","owner":{"login":"hnfgns","id":3476250,"avatar_url":"https://avatars.githubusercontent.com/u/3476250?v=3","gravatar_id":"","url":"https://api.github.com/users/hnfgns","html_url":"https://github.com/hnfgns","followers_url":"https://api.github.com/users/hnfgns/followers","following_url":"https://api.github.com/users/hnfgns/following{/other_user}","gists_url":"https://api.github.com/users/hnfgns/gists{/gist_id}","starred_url":"https://api.github.com/users/hnfgns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hnfgns/subscriptions","organizations_url":"https://api.github.com/users/hnfgns/orgs","repos_url":"https://api.github.com/users/hnfgns/repos","events_url":"https://api.github.com/users/hnfgns/events{/privacy}","received_events_url":"https://api.github.com/users/hnfgns/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hnfgns/incubator-drill","description":"Mirror of Apache Drill","fork":true,"url":"https://api.github.com/repos/hnfgns/incubator-drill","forks_url":"https://api.github.com/repos/hnfgns/incubator-drill/forks","keys_url":"https://api.github.com/repos/hnfgns/incubator-drill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hnfgns/incubator-drill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hnfgns/incubator-drill/teams","hooks_url":"https://api.github.com/repos/hnfgns/incubator-drill/hooks","issue_events_url":"https://api.github.com/repos/hnfgns/incubator-drill/issues/events{/number}","events_url":"https://api.github.com/repos/hnfgns/incubator-drill/events","assignees_url":"https://api.github.com/repos/hnfgns/incubator-drill/assignees{/user}","branches_url":"https://api.github.com/repos/hnfgns/incubator-drill/branches{/branch}","tags_url":"https://api.github.com/repos/hnfgns/incubator-drill/tags","blobs_url":"https://api.github.com/repos/hnfgns/incubator-drill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hnfgns/incubator-drill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hnfgns/incubator-drill/git/refs{/sha}","trees_url":"https://api.github.com/repos/hnfgns/incubator-drill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hnfgns/incubator-drill/statuses/{sha}","languages_url":"https://api.github.com/repos/hnfgns/incubator-drill/languages","stargazers_url":"https://api.github.com/repos/hnfgns/incubator-drill/stargazers","contributors_url":"https://api.github.com/repos/hnfgns/incubator-drill/contributors","subscribers_url":"https://api.github.com/repos/hnfgns/incubator-drill/subscribers","subscription_url":"https://api.github.com/repos/hnfgns/incubator-drill/subscription","commits_url":"https://api.github.com/repos/hnfgns/incubator-drill/commits{/sha}","git_commits_url":"https://api.github.com/repos/hnfgns/incubator-drill/git/commits{/sha}","comments_url":"https://api.github.com/repos/hnfgns/incubator-drill/comments{/number}","issue_comment_url":"https://api.github.com/repos/hnfgns/incubator-drill/issues/comments{/number}","contents_url":"https://api.github.com/repos/hnfgns/incubator-drill/contents/{+path}","compare_url":"https://api.github.com/repos/hnfgns/incubator-drill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hnfgns/incubator-drill/merges","archive_url":"https://api.github.com/repos/hnfgns/incubator-drill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hnfgns/incubator-drill/downloads","issues_url":"https://api.github.com/repos/hnfgns/incubator-drill/issues{/number}","pulls_url":"https://api.github.com/repos/hnfgns/incubator-drill/pulls{/number}","milestones_url":"https://api.github.com/repos/hnfgns/incubator-drill/milestones{/number}","notifications_url":"https://api.github.com/repos/hnfgns/incubator-drill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hnfgns/incubator-drill/labels{/name}","releases_url":"https://api.github.com/repos/hnfgns/incubator-drill/releases{/id}","created_at":"2014-07-28T20:50:07Z","updated_at":"2015-04-28T20:48:18Z","pushed_at":"2015-11-19T00:56:23Z","git_url":"git://github.com/hnfgns/incubator-drill.git","ssh_url":"git@github.com:hnfgns/incubator-drill.git","clone_url":"https://github.com/hnfgns/incubator-drill.git","svn_url":"https://github.com/hnfgns/incubator-drill","homepage":"","size":22423,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a6a0fc37779399c936237143572ec57142e0039c","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":5683653,"name":"drill","full_name":"apache/drill","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/drill","description":"Mirror of Apache Drill","fork":false,"url":"https://api.github.com/repos/apache/drill","forks_url":"https://api.github.com/repos/apache/drill/forks","keys_url":"https://api.github.com/repos/apache/drill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/drill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/drill/teams","hooks_url":"https://api.github.com/repos/apache/drill/hooks","issue_events_url":"https://api.github.com/repos/apache/drill/issues/events{/number}","events_url":"https://api.github.com/repos/apache/drill/events","assignees_url":"https://api.github.com/repos/apache/drill/assignees{/user}","branches_url":"https://api.github.com/repos/apache/drill/branches{/branch}","tags_url":"https://api.github.com/repos/apache/drill/tags","blobs_url":"https://api.github.com/repos/apache/drill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/drill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/drill/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/drill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/drill/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/drill/languages","stargazers_url":"https://api.github.com/repos/apache/drill/stargazers","contributors_url":"https://api.github.com/repos/apache/drill/contributors","subscribers_url":"https://api.github.com/repos/apache/drill/subscribers","subscription_url":"https://api.github.com/repos/apache/drill/subscription","commits_url":"https://api.github.com/repos/apache/drill/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/drill/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/drill/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/drill/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/drill/contents/{+path}","compare_url":"https://api.github.com/repos/apache/drill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/drill/merges","archive_url":"https://api.github.com/repos/apache/drill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/drill/downloads","issues_url":"https://api.github.com/repos/apache/drill/issues{/number}","pulls_url":"https://api.github.com/repos/apache/drill/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/drill/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/drill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/drill/labels{/name}","releases_url":"https://api.github.com/repos/apache/drill/releases{/id}","created_at":"2012-09-05T07:00:26Z","updated_at":"2015-11-19T16:15:17Z","pushed_at":"2015-11-19T21:20:47Z","git_url":"git://github.com/apache/drill.git","ssh_url":"git@github.com:apache/drill.git","clone_url":"https://github.com/apache/drill.git","svn_url":"https://github.com/apache/drill","homepage":"","size":42599,"stargazers_count":514,"watchers_count":514,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":334,"mirror_url":"git://git.apache.org/incubator-drill.git","open_issues_count":57,"forks":334,"open_issues":57,"watchers":514,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/drill/pulls/260"},"html":{"href":"https://github.com/apache/drill/pull/260"},"issue":{"href":"https://api.github.com/repos/apache/drill/issues/260"},"comments":{"href":"https://api.github.com/repos/apache/drill/issues/260/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/drill/pulls/260/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/drill/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/drill/pulls/260/commits"},"statuses":{"href":"https://api.github.com/repos/apache/drill/statuses/963c6da63474f7019bb55419b8bc6710e5b67698"}}}}