{"action":"created","issue":{"url":"https://api.github.com/repos/adobe-photoshop/spaces-design/issues/3420","labels_url":"https://api.github.com/repos/adobe-photoshop/spaces-design/issues/3420/labels{/name}","comments_url":"https://api.github.com/repos/adobe-photoshop/spaces-design/issues/3420/comments","events_url":"https://api.github.com/repos/adobe-photoshop/spaces-design/issues/3420/events","html_url":"https://github.com/adobe-photoshop/spaces-design/pull/3420","id":121559138,"number":3420,"title":"Better way to handle empty value in TextInput","user":{"login":"shaoshing","id":118264,"avatar_url":"https://avatars.githubusercontent.com/u/118264?v=3","gravatar_id":"","url":"https://api.github.com/users/shaoshing","html_url":"https://github.com/shaoshing","followers_url":"https://api.github.com/users/shaoshing/followers","following_url":"https://api.github.com/users/shaoshing/following{/other_user}","gists_url":"https://api.github.com/users/shaoshing/gists{/gist_id}","starred_url":"https://api.github.com/users/shaoshing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaoshing/subscriptions","organizations_url":"https://api.github.com/users/shaoshing/orgs","repos_url":"https://api.github.com/users/shaoshing/repos","events_url":"https://api.github.com/users/shaoshing/events{/privacy}","received_events_url":"https://api.github.com/users/shaoshing/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-12-10T19:25:01Z","updated_at":"2015-12-10T19:59:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/adobe-photoshop/spaces-design/pulls/3420","html_url":"https://github.com/adobe-photoshop/spaces-design/pull/3420","diff_url":"https://github.com/adobe-photoshop/spaces-design/pull/3420.diff","patch_url":"https://github.com/adobe-photoshop/spaces-design/pull/3420.patch"},"body":"* Instead of handling empty value in the handler, I added new option `allowEmpty` which will ignore empty value and skip the `onChange` handler.\r\n* `onChange` was not clear before: it could be onChange handler or onCommit handler (when `continuous` prop is true). I reduce its scope by adding a new handle `onInputChange`, which also helps remove the `continuous` prop. Please see doc for difference of two handlers.\r\n* bug fix: disallow empty value in ColorPicker. Otherwise inputting empty value will set color to black.\r\n\r\n@volfied @mcilroyc can you review since you both reviewed #3410 ?"},"comment":{"url":"https://api.github.com/repos/adobe-photoshop/spaces-design/issues/comments/163733808","html_url":"https://github.com/adobe-photoshop/spaces-design/pull/3420#issuecomment-163733808","issue_url":"https://api.github.com/repos/adobe-photoshop/spaces-design/issues/3420","id":163733808,"user":{"login":"designedbyscience","id":22372,"avatar_url":"https://avatars.githubusercontent.com/u/22372?v=3","gravatar_id":"","url":"https://api.github.com/users/designedbyscience","html_url":"https://github.com/designedbyscience","followers_url":"https://api.github.com/users/designedbyscience/followers","following_url":"https://api.github.com/users/designedbyscience/following{/other_user}","gists_url":"https://api.github.com/users/designedbyscience/gists{/gist_id}","starred_url":"https://api.github.com/users/designedbyscience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/designedbyscience/subscriptions","organizations_url":"https://api.github.com/users/designedbyscience/orgs","repos_url":"https://api.github.com/users/designedbyscience/repos","events_url":"https://api.github.com/users/designedbyscience/events{/privacy}","received_events_url":"https://api.github.com/users/designedbyscience/received_events","type":"User","site_admin":false},"created_at":"2015-12-10T19:59:02Z","updated_at":"2015-12-10T19:59:02Z","body":"(Oh, but making these things separate props seems like a good idea, I am only quibbling about naming)"}}