{"action":"created","comment":{"url":"https://api.github.com/repos/heiko-braun/api-gen/pulls/comments/37722062","id":37722062,"diff_hunk":"@@ -0,0 +1,42 @@\n+package org.wildfly.apigen.invocation;\n+\n+import org.jboss.jandex.DotName;\n+import org.jboss.jandex.Index;\n+import org.jboss.jandex.Indexer;\n+\n+import java.io.IOException;\n+import java.io.InputStream;\n+import java.util.HashMap;\n+\n+/**\n+ * @author Lance Ball\n+ */\n+public class IndexFactory {","path":"generator/src/main/java/org/wildfly/apigen/invocation/IndexFactory.java","position":14,"original_position":14,"commit_id":"8ec3483032e08558367d79bb61c52d344d7ec788","original_commit_id":"8ec3483032e08558367d79bb61c52d344d7ec788","user":{"login":"heiko-braun","id":369380,"avatar_url":"https://avatars.githubusercontent.com/u/369380?v=3","gravatar_id":"","url":"https://api.github.com/users/heiko-braun","html_url":"https://github.com/heiko-braun","followers_url":"https://api.github.com/users/heiko-braun/followers","following_url":"https://api.github.com/users/heiko-braun/following{/other_user}","gists_url":"https://api.github.com/users/heiko-braun/gists{/gist_id}","starred_url":"https://api.github.com/users/heiko-braun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heiko-braun/subscriptions","organizations_url":"https://api.github.com/users/heiko-braun/orgs","repos_url":"https://api.github.com/users/heiko-braun/repos","events_url":"https://api.github.com/users/heiko-braun/events{/privacy}","received_events_url":"https://api.github.com/users/heiko-braun/received_events","type":"User","site_admin":false},"body":"It should also be possible to package an index file with the final api jar and load it as a resource. Something we may consider to further improve the marshalling layer.","created_at":"2015-08-24T06:24:07Z","updated_at":"2015-08-24T06:24:07Z","html_url":"https://github.com/heiko-braun/api-gen/pull/5#discussion_r37722062","pull_request_url":"https://api.github.com/repos/heiko-braun/api-gen/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/heiko-braun/api-gen/pulls/comments/37722062"},"html":{"href":"https://github.com/heiko-braun/api-gen/pull/5#discussion_r37722062"},"pull_request":{"href":"https://api.github.com/repos/heiko-braun/api-gen/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/heiko-braun/api-gen/pulls/5","id":42824909,"html_url":"https://github.com/heiko-braun/api-gen/pull/5","diff_url":"https://github.com/heiko-braun/api-gen/pull/5.diff","patch_url":"https://github.com/heiko-braun/api-gen/pull/5.patch","issue_url":"https://api.github.com/repos/heiko-braun/api-gen/issues/5","number":5,"state":"open","locked":false,"title":"Initial implementation of a Marshaling object for Java to DMR.","user":{"login":"lance","id":15952,"avatar_url":"https://avatars.githubusercontent.com/u/15952?v=3","gravatar_id":"","url":"https://api.github.com/users/lance","html_url":"https://github.com/lance","followers_url":"https://api.github.com/users/lance/followers","following_url":"https://api.github.com/users/lance/following{/other_user}","gists_url":"https://api.github.com/users/lance/gists{/gist_id}","starred_url":"https://api.github.com/users/lance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lance/subscriptions","organizations_url":"https://api.github.com/users/lance/orgs","repos_url":"https://api.github.com/users/lance/repos","events_url":"https://api.github.com/users/lance/events{/privacy}","received_events_url":"https://api.github.com/users/lance/received_events","type":"User","site_admin":false},"body":"This pull request contains an initial implementation of a Marshaller, as loosely described in #4. The `Marshaller` takes a single node, presumably a root node, converts it to a `ModelNode` using the `EntityAdapter.fromEntity` method, and then examines all of the node's subresources, creating a `ModelNode` for each. All of these nodes are chained together in a list and returned from `Marshaller.marshal`.\r\n\r\nSome refactoring was done to eliminate code duplication, specifically with the `jandex` indexing. \r\n\r\n- There is now an `IndexFactory` with a static method that can be used by both `EntityAdapter` and `Marshaller`.\r\n- Class names used by the `jandex` indexer are created using `obj.getClass().getName()` instead of `getCanonicalName` since the subresources on an entity are managed with an inner class, and the '$' in the name notation is required (canonical name removes it).\r\n- Test fixtures for the Mail subsystem have been updated to the latest generated form.\r\n- The `Subresource` annotation was removed from the `subresources` method on an entity.\r\n","created_at":"2015-08-19T15:01:43Z","updated_at":"2015-08-24T06:24:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20da2e3bd0ca2b05b1acbbe152a9bca212db90e5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/heiko-braun/api-gen/pulls/5/commits","review_comments_url":"https://api.github.com/repos/heiko-braun/api-gen/pulls/5/comments","review_comment_url":"https://api.github.com/repos/heiko-braun/api-gen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/heiko-braun/api-gen/issues/5/comments","statuses_url":"https://api.github.com/repos/heiko-braun/api-gen/statuses/8ec3483032e08558367d79bb61c52d344d7ec788","head":{"label":"lance:master","ref":"master","sha":"8ec3483032e08558367d79bb61c52d344d7ec788","user":{"login":"lance","id":15952,"avatar_url":"https://avatars.githubusercontent.com/u/15952?v=3","gravatar_id":"","url":"https://api.github.com/users/lance","html_url":"https://github.com/lance","followers_url":"https://api.github.com/users/lance/followers","following_url":"https://api.github.com/users/lance/following{/other_user}","gists_url":"https://api.github.com/users/lance/gists{/gist_id}","starred_url":"https://api.github.com/users/lance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lance/subscriptions","organizations_url":"https://api.github.com/users/lance/orgs","repos_url":"https://api.github.com/users/lance/repos","events_url":"https://api.github.com/users/lance/events{/privacy}","received_events_url":"https://api.github.com/users/lance/received_events","type":"User","site_admin":false},"repo":{"id":40012086,"name":"api-gen","full_name":"lance/api-gen","owner":{"login":"lance","id":15952,"avatar_url":"https://avatars.githubusercontent.com/u/15952?v=3","gravatar_id":"","url":"https://api.github.com/users/lance","html_url":"https://github.com/lance","followers_url":"https://api.github.com/users/lance/followers","following_url":"https://api.github.com/users/lance/following{/other_user}","gists_url":"https://api.github.com/users/lance/gists{/gist_id}","starred_url":"https://api.github.com/users/lance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lance/subscriptions","organizations_url":"https://api.github.com/users/lance/orgs","repos_url":"https://api.github.com/users/lance/repos","events_url":"https://api.github.com/users/lance/events{/privacy}","received_events_url":"https://api.github.com/users/lance/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lance/api-gen","description":"Another Wildfly asset related to swarm","fork":true,"url":"https://api.github.com/repos/lance/api-gen","forks_url":"https://api.github.com/repos/lance/api-gen/forks","keys_url":"https://api.github.com/repos/lance/api-gen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lance/api-gen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lance/api-gen/teams","hooks_url":"https://api.github.com/repos/lance/api-gen/hooks","issue_events_url":"https://api.github.com/repos/lance/api-gen/issues/events{/number}","events_url":"https://api.github.com/repos/lance/api-gen/events","assignees_url":"https://api.github.com/repos/lance/api-gen/assignees{/user}","branches_url":"https://api.github.com/repos/lance/api-gen/branches{/branch}","tags_url":"https://api.github.com/repos/lance/api-gen/tags","blobs_url":"https://api.github.com/repos/lance/api-gen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lance/api-gen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lance/api-gen/git/refs{/sha}","trees_url":"https://api.github.com/repos/lance/api-gen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lance/api-gen/statuses/{sha}","languages_url":"https://api.github.com/repos/lance/api-gen/languages","stargazers_url":"https://api.github.com/repos/lance/api-gen/stargazers","contributors_url":"https://api.github.com/repos/lance/api-gen/contributors","subscribers_url":"https://api.github.com/repos/lance/api-gen/subscribers","subscription_url":"https://api.github.com/repos/lance/api-gen/subscription","commits_url":"https://api.github.com/repos/lance/api-gen/commits{/sha}","git_commits_url":"https://api.github.com/repos/lance/api-gen/git/commits{/sha}","comments_url":"https://api.github.com/repos/lance/api-gen/comments{/number}","issue_comment_url":"https://api.github.com/repos/lance/api-gen/issues/comments{/number}","contents_url":"https://api.github.com/repos/lance/api-gen/contents/{+path}","compare_url":"https://api.github.com/repos/lance/api-gen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lance/api-gen/merges","archive_url":"https://api.github.com/repos/lance/api-gen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lance/api-gen/downloads","issues_url":"https://api.github.com/repos/lance/api-gen/issues{/number}","pulls_url":"https://api.github.com/repos/lance/api-gen/pulls{/number}","milestones_url":"https://api.github.com/repos/lance/api-gen/milestones{/number}","notifications_url":"https://api.github.com/repos/lance/api-gen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lance/api-gen/labels{/name}","releases_url":"https://api.github.com/repos/lance/api-gen/releases{/id}","created_at":"2015-07-31T15:35:08Z","updated_at":"2015-07-31T15:35:09Z","pushed_at":"2015-08-21T19:44:41Z","git_url":"git://github.com/lance/api-gen.git","ssh_url":"git@github.com:lance/api-gen.git","clone_url":"https://github.com/lance/api-gen.git","svn_url":"https://github.com/lance/api-gen","homepage":"","size":205,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"heiko-braun:master","ref":"master","sha":"619a744dec077cd35b1ffa3603add55a87ccce24","user":{"login":"heiko-braun","id":369380,"avatar_url":"https://avatars.githubusercontent.com/u/369380?v=3","gravatar_id":"","url":"https://api.github.com/users/heiko-braun","html_url":"https://github.com/heiko-braun","followers_url":"https://api.github.com/users/heiko-braun/followers","following_url":"https://api.github.com/users/heiko-braun/following{/other_user}","gists_url":"https://api.github.com/users/heiko-braun/gists{/gist_id}","starred_url":"https://api.github.com/users/heiko-braun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heiko-braun/subscriptions","organizations_url":"https://api.github.com/users/heiko-braun/orgs","repos_url":"https://api.github.com/users/heiko-braun/repos","events_url":"https://api.github.com/users/heiko-braun/events{/privacy}","received_events_url":"https://api.github.com/users/heiko-braun/received_events","type":"User","site_admin":false},"repo":{"id":39889729,"name":"api-gen","full_name":"heiko-braun/api-gen","owner":{"login":"heiko-braun","id":369380,"avatar_url":"https://avatars.githubusercontent.com/u/369380?v=3","gravatar_id":"","url":"https://api.github.com/users/heiko-braun","html_url":"https://github.com/heiko-braun","followers_url":"https://api.github.com/users/heiko-braun/followers","following_url":"https://api.github.com/users/heiko-braun/following{/other_user}","gists_url":"https://api.github.com/users/heiko-braun/gists{/gist_id}","starred_url":"https://api.github.com/users/heiko-braun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heiko-braun/subscriptions","organizations_url":"https://api.github.com/users/heiko-braun/orgs","repos_url":"https://api.github.com/users/heiko-braun/repos","events_url":"https://api.github.com/users/heiko-braun/events{/privacy}","received_events_url":"https://api.github.com/users/heiko-braun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/heiko-braun/api-gen","description":"Another Wildfly asset related to swarm","fork":false,"url":"https://api.github.com/repos/heiko-braun/api-gen","forks_url":"https://api.github.com/repos/heiko-braun/api-gen/forks","keys_url":"https://api.github.com/repos/heiko-braun/api-gen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heiko-braun/api-gen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heiko-braun/api-gen/teams","hooks_url":"https://api.github.com/repos/heiko-braun/api-gen/hooks","issue_events_url":"https://api.github.com/repos/heiko-braun/api-gen/issues/events{/number}","events_url":"https://api.github.com/repos/heiko-braun/api-gen/events","assignees_url":"https://api.github.com/repos/heiko-braun/api-gen/assignees{/user}","branches_url":"https://api.github.com/repos/heiko-braun/api-gen/branches{/branch}","tags_url":"https://api.github.com/repos/heiko-braun/api-gen/tags","blobs_url":"https://api.github.com/repos/heiko-braun/api-gen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heiko-braun/api-gen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heiko-braun/api-gen/git/refs{/sha}","trees_url":"https://api.github.com/repos/heiko-braun/api-gen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heiko-braun/api-gen/statuses/{sha}","languages_url":"https://api.github.com/repos/heiko-braun/api-gen/languages","stargazers_url":"https://api.github.com/repos/heiko-braun/api-gen/stargazers","contributors_url":"https://api.github.com/repos/heiko-braun/api-gen/contributors","subscribers_url":"https://api.github.com/repos/heiko-braun/api-gen/subscribers","subscription_url":"https://api.github.com/repos/heiko-braun/api-gen/subscription","commits_url":"https://api.github.com/repos/heiko-braun/api-gen/commits{/sha}","git_commits_url":"https://api.github.com/repos/heiko-braun/api-gen/git/commits{/sha}","comments_url":"https://api.github.com/repos/heiko-braun/api-gen/comments{/number}","issue_comment_url":"https://api.github.com/repos/heiko-braun/api-gen/issues/comments{/number}","contents_url":"https://api.github.com/repos/heiko-braun/api-gen/contents/{+path}","compare_url":"https://api.github.com/repos/heiko-braun/api-gen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heiko-braun/api-gen/merges","archive_url":"https://api.github.com/repos/heiko-braun/api-gen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heiko-braun/api-gen/downloads","issues_url":"https://api.github.com/repos/heiko-braun/api-gen/issues{/number}","pulls_url":"https://api.github.com/repos/heiko-braun/api-gen/pulls{/number}","milestones_url":"https://api.github.com/repos/heiko-braun/api-gen/milestones{/number}","notifications_url":"https://api.github.com/repos/heiko-braun/api-gen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heiko-braun/api-gen/labels{/name}","releases_url":"https://api.github.com/repos/heiko-braun/api-gen/releases{/id}","created_at":"2015-07-29T11:23:32Z","updated_at":"2015-07-31T18:50:05Z","pushed_at":"2015-08-21T19:44:42Z","git_url":"git://github.com/heiko-braun/api-gen.git","ssh_url":"git@github.com:heiko-braun/api-gen.git","clone_url":"https://github.com/heiko-braun/api-gen.git","svn_url":"https://github.com/heiko-braun/api-gen","homepage":"https://github.com/wildfly-swarm/wildfly-swarm/issues/98","size":256,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/heiko-braun/api-gen/pulls/5"},"html":{"href":"https://github.com/heiko-braun/api-gen/pull/5"},"issue":{"href":"https://api.github.com/repos/heiko-braun/api-gen/issues/5"},"comments":{"href":"https://api.github.com/repos/heiko-braun/api-gen/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/heiko-braun/api-gen/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/heiko-braun/api-gen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/heiko-braun/api-gen/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/heiko-braun/api-gen/statuses/8ec3483032e08558367d79bb61c52d344d7ec788"}}}}