{"action":"created","issue":{"url":"https://api.github.com/repos/snipe/snipe-it/issues/1357","labels_url":"https://api.github.com/repos/snipe/snipe-it/issues/1357/labels{/name}","comments_url":"https://api.github.com/repos/snipe/snipe-it/issues/1357/comments","events_url":"https://api.github.com/repos/snipe/snipe-it/issues/1357/events","html_url":"https://github.com/snipe/snipe-it/pull/1357","id":117385699,"number":1357,"title":"Features/ldap settings","user":{"login":"merid14","id":1342320,"avatar_url":"https://avatars.githubusercontent.com/u/1342320?v=3","gravatar_id":"","url":"https://api.github.com/users/merid14","html_url":"https://github.com/merid14","followers_url":"https://api.github.com/users/merid14/followers","following_url":"https://api.github.com/users/merid14/following{/other_user}","gists_url":"https://api.github.com/users/merid14/gists{/gist_id}","starred_url":"https://api.github.com/users/merid14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merid14/subscriptions","organizations_url":"https://api.github.com/users/merid14/orgs","repos_url":"https://api.github.com/users/merid14/repos","events_url":"https://api.github.com/users/merid14/events{/privacy}","received_events_url":"https://api.github.com/users/merid14/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-11-17T15:56:53Z","updated_at":"2015-11-17T18:34:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/snipe/snipe-it/pulls/1357","html_url":"https://github.com/snipe/snipe-it/pull/1357","diff_url":"https://github.com/snipe/snipe-it/pull/1357.diff","patch_url":"https://github.com/snipe/snipe-it/pull/1357.patch"},"body":"I've added everything necessary for the LDAP settings to be configured in the settings page. By default it is setup for AD LDAP(as thats what I have to test with).\r\n\r\nOne thing that doesn't work currently is setting up the validator for required ldap fields. My thought was to use the 'enable ldap' check box to trigger the validation but i'm not sure how to do that before posting the form. other than that it should be good to go of course it needs tested.\r\n\r\n- [ ] Validators for required fields"},"comment":{"url":"https://api.github.com/repos/snipe/snipe-it/issues/comments/157463113","html_url":"https://github.com/snipe/snipe-it/pull/1357#issuecomment-157463113","issue_url":"https://api.github.com/repos/snipe/snipe-it/issues/1357","id":157463113,"user":{"login":"snipe","id":197404,"avatar_url":"https://avatars.githubusercontent.com/u/197404?v=3","gravatar_id":"","url":"https://api.github.com/users/snipe","html_url":"https://github.com/snipe","followers_url":"https://api.github.com/users/snipe/followers","following_url":"https://api.github.com/users/snipe/following{/other_user}","gists_url":"https://api.github.com/users/snipe/gists{/gist_id}","starred_url":"https://api.github.com/users/snipe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snipe/subscriptions","organizations_url":"https://api.github.com/users/snipe/orgs","repos_url":"https://api.github.com/users/snipe/repos","events_url":"https://api.github.com/users/snipe/events{/privacy}","received_events_url":"https://api.github.com/users/snipe/received_events","type":"User","site_admin":false},"created_at":"2015-11-17T18:34:46Z","updated_at":"2015-11-17T18:34:46Z","body":"No, the only place it gets in the way is LDAP settings. "}}