{"action":"created","issue":{"url":"https://api.github.com/repos/BVLC/caffe/issues/3311","labels_url":"https://api.github.com/repos/BVLC/caffe/issues/3311/labels{/name}","comments_url":"https://api.github.com/repos/BVLC/caffe/issues/3311/comments","events_url":"https://api.github.com/repos/BVLC/caffe/issues/3311/events","html_url":"https://github.com/BVLC/caffe/pull/3311","id":115997551,"number":3311,"title":"Mark version 1.0.0","user":{"login":"lukeyeager","id":687269,"avatar_url":"https://avatars.githubusercontent.com/u/687269?v=3","gravatar_id":"","url":"https://api.github.com/users/lukeyeager","html_url":"https://github.com/lukeyeager","followers_url":"https://api.github.com/users/lukeyeager/followers","following_url":"https://api.github.com/users/lukeyeager/following{/other_user}","gists_url":"https://api.github.com/users/lukeyeager/gists{/gist_id}","starred_url":"https://api.github.com/users/lukeyeager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukeyeager/subscriptions","organizations_url":"https://api.github.com/users/lukeyeager/orgs","repos_url":"https://api.github.com/users/lukeyeager/repos","events_url":"https://api.github.com/users/lukeyeager/events{/privacy}","received_events_url":"https://api.github.com/users/lukeyeager/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/BVLC/caffe/labels/build","name":"build","color":"fbca04"},{"url":"https://api.github.com/repos/BVLC/caffe/labels/focus","name":"focus","color":"006b75"},{"url":"https://api.github.com/repos/BVLC/caffe/labels/ready%20for%20review","name":"ready for review","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":17,"created_at":"2015-11-10T00:17:37Z","updated_at":"2015-11-18T18:21:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/BVLC/caffe/pulls/3311","html_url":"https://github.com/BVLC/caffe/pull/3311","diff_url":"https://github.com/BVLC/caffe/pull/3311.diff","patch_url":"https://github.com/BVLC/caffe/pull/3311.patch"},"body":"*Close #486, Close #2969, Close #3015*\r\n\r\n*Originally https://github.com/NVIDIA/caffe/pull/39 and https://github.com/NVIDIA/caffe/pull/46*\r\n\r\n## Included\r\n\r\nAdds versioning to:\r\n* shared library (`libcaffe.so`)\r\n  * both build systems\r\n* caffe binary (`caffe --version`)\r\n* python module (`caffe.__version__`)\r\n\r\n## TODO\r\n\r\n* matlab versioning (help?)\r\n\r\n## For discussion\r\n\r\n* I'm assuming you want to be able to break backwards compatibility with MINOR releases (which means not following semantic versioning to the letter). If you want to go all the way, we should set the SONAME to `libcaffe.MAJOR` instead of `libcaffe.MAJOR.MINOR`.\r\n* Instead of this approach, you could follow the CMake stubs for how to do it with a header file - https://github.com/BVLC/caffe/blob/5a302a2b3b/cmake/Summary.cmake#L79-L84. I went this route due to some extra requirements for NVcaffe."},"comment":{"url":"https://api.github.com/repos/BVLC/caffe/issues/comments/157809759","html_url":"https://github.com/BVLC/caffe/pull/3311#issuecomment-157809759","issue_url":"https://api.github.com/repos/BVLC/caffe/issues/3311","id":157809759,"user":{"login":"lukeyeager","id":687269,"avatar_url":"https://avatars.githubusercontent.com/u/687269?v=3","gravatar_id":"","url":"https://api.github.com/users/lukeyeager","html_url":"https://github.com/lukeyeager","followers_url":"https://api.github.com/users/lukeyeager/followers","following_url":"https://api.github.com/users/lukeyeager/following{/other_user}","gists_url":"https://api.github.com/users/lukeyeager/gists{/gist_id}","starred_url":"https://api.github.com/users/lukeyeager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukeyeager/subscriptions","organizations_url":"https://api.github.com/users/lukeyeager/orgs","repos_url":"https://api.github.com/users/lukeyeager/repos","events_url":"https://api.github.com/users/lukeyeager/events{/privacy}","received_events_url":"https://api.github.com/users/lukeyeager/received_events","type":"User","site_admin":false},"created_at":"2015-11-18T18:21:55Z","updated_at":"2015-11-18T18:21:55Z","body":"@cbalint13 I agree. I've created a new issue at #3351 since it's not necessarily related to this PR."}}