{"action":"created","issue":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/3577","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/3577/labels{/name}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/3577/comments","events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/3577/events","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/3577","id":46694151,"number":3577,"title":"BUG Fix BasicAuth not resetting failed login counts on authentication","user":{"login":"tractorcow","id":936064,"avatar_url":"https://avatars.githubusercontent.com/u/936064?v=3","gravatar_id":"","url":"https://api.github.com/users/tractorcow","html_url":"https://github.com/tractorcow","followers_url":"https://api.github.com/users/tractorcow/followers","following_url":"https://api.github.com/users/tractorcow/following{/other_user}","gists_url":"https://api.github.com/users/tractorcow/gists{/gist_id}","starred_url":"https://api.github.com/users/tractorcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tractorcow/subscriptions","organizations_url":"https://api.github.com/users/tractorcow/orgs","repos_url":"https://api.github.com/users/tractorcow/repos","events_url":"https://api.github.com/users/tractorcow/events{/privacy}","received_events_url":"https://api.github.com/users/tractorcow/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/labels/3.1","name":"3.1","color":"fef2c0"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/milestones/13","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/milestones/13/labels","id":935906,"number":13,"title":"3.1.10","description":"","creator":{"login":"tractorcow","id":936064,"avatar_url":"https://avatars.githubusercontent.com/u/936064?v=3","gravatar_id":"","url":"https://api.github.com/users/tractorcow","html_url":"https://github.com/tractorcow","followers_url":"https://api.github.com/users/tractorcow/followers","following_url":"https://api.github.com/users/tractorcow/following{/other_user}","gists_url":"https://api.github.com/users/tractorcow/gists{/gist_id}","starred_url":"https://api.github.com/users/tractorcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tractorcow/subscriptions","organizations_url":"https://api.github.com/users/tractorcow/orgs","repos_url":"https://api.github.com/users/tractorcow/repos","events_url":"https://api.github.com/users/tractorcow/events{/privacy}","received_events_url":"https://api.github.com/users/tractorcow/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":1,"state":"open","created_at":"2015-01-14T21:56:33Z","updated_at":"2015-01-14T22:03:52Z","due_on":null,"closed_at":null},"comments":10,"created_at":"2014-10-24T00:49:12Z","updated_at":"2015-01-14T22:07:35Z","closed_at":"2015-01-14T22:03:52Z","pull_request":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/3577","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/3577","diff_url":"https://github.com/silverstripe/silverstripe-framework/pull/3577.diff","patch_url":"https://github.com/silverstripe/silverstripe-framework/pull/3577.patch"},"body":"FailedLoginCount would always be incremented whenever an authentication failed, but not reset on success. The actual reset of this counter would normally be done in `Member::logIn`, but this means that if we are merely authenticating the given credentials (i.e. proving these are correct, and not wishing to log them in) then the reset would never occur.\r\n\r\nI've resolved this issue in the MemberAuthenticator by ensuring that the registerFailedLogin method is paired by registerSuccessfulLogin.\r\n\r\n@simonwelsh do you see any risk in this fix from a BC perspective?\r\n\r\nAlso cc @wilr who originally reported this issue. Are you satisfied that this fixes the problem?"},"comment":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/comments/70002003","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/3577#issuecomment-70002003","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/3577","id":70002003,"user":{"login":"tractorcow","id":936064,"avatar_url":"https://avatars.githubusercontent.com/u/936064?v=3","gravatar_id":"","url":"https://api.github.com/users/tractorcow","html_url":"https://github.com/tractorcow","followers_url":"https://api.github.com/users/tractorcow/followers","following_url":"https://api.github.com/users/tractorcow/following{/other_user}","gists_url":"https://api.github.com/users/tractorcow/gists{/gist_id}","starred_url":"https://api.github.com/users/tractorcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tractorcow/subscriptions","organizations_url":"https://api.github.com/users/tractorcow/orgs","repos_url":"https://api.github.com/users/tractorcow/repos","events_url":"https://api.github.com/users/tractorcow/events{/privacy}","received_events_url":"https://api.github.com/users/tractorcow/received_events","type":"User","site_admin":false},"created_at":"2015-01-14T22:07:35Z","updated_at":"2015-01-14T22:07:35Z","body":"Thanks @wilr , I was about to rebase this but I guess it wasn't needed."}}