{"action":"created","issue":{"url":"https://api.github.com/repos/prometheus/prometheus/issues/1217","labels_url":"https://api.github.com/repos/prometheus/prometheus/issues/1217/labels{/name}","comments_url":"https://api.github.com/repos/prometheus/prometheus/issues/1217/comments","events_url":"https://api.github.com/repos/prometheus/prometheus/issues/1217/events","html_url":"https://github.com/prometheus/prometheus/issues/1217","id":116792075,"number":1217,"title":"Automatically include `node` label for every `instance`","user":{"login":"SuperQ","id":1320667,"avatar_url":"https://avatars.githubusercontent.com/u/1320667?v=3","gravatar_id":"","url":"https://api.github.com/users/SuperQ","html_url":"https://github.com/SuperQ","followers_url":"https://api.github.com/users/SuperQ/followers","following_url":"https://api.github.com/users/SuperQ/following{/other_user}","gists_url":"https://api.github.com/users/SuperQ/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperQ/subscriptions","organizations_url":"https://api.github.com/users/SuperQ/orgs","repos_url":"https://api.github.com/users/SuperQ/repos","events_url":"https://api.github.com/users/SuperQ/events{/privacy}","received_events_url":"https://api.github.com/users/SuperQ/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-11-13T15:37:39Z","updated_at":"2015-11-14T08:32:24Z","closed_at":null,"body":"It's highly useful to be able to metrics comparisons between targets on the same node.  For example getting the rate of disk IO from the `node_exporter` and normalizing that with request counters from `mysqld_exporter`.\r\n\r\nCreating a `node` label from `instance` works via metrics relabeling, but it can be very messy.  It would be nice to just have this be a default option."},"comment":{"url":"https://api.github.com/repos/prometheus/prometheus/issues/comments/156669606","html_url":"https://github.com/prometheus/prometheus/issues/1217#issuecomment-156669606","issue_url":"https://api.github.com/repos/prometheus/prometheus/issues/1217","id":156669606,"user":{"login":"brian-brazil","id":7115638,"avatar_url":"https://avatars.githubusercontent.com/u/7115638?v=3","gravatar_id":"","url":"https://api.github.com/users/brian-brazil","html_url":"https://github.com/brian-brazil","followers_url":"https://api.github.com/users/brian-brazil/followers","following_url":"https://api.github.com/users/brian-brazil/following{/other_user}","gists_url":"https://api.github.com/users/brian-brazil/gists{/gist_id}","starred_url":"https://api.github.com/users/brian-brazil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brian-brazil/subscriptions","organizations_url":"https://api.github.com/users/brian-brazil/orgs","repos_url":"https://api.github.com/users/brian-brazil/repos","events_url":"https://api.github.com/users/brian-brazil/events{/privacy}","received_events_url":"https://api.github.com/users/brian-brazil/received_events","type":"User","site_admin":false},"created_at":"2015-11-14T08:32:24Z","updated_at":"2015-11-14T08:32:24Z","body":"I think you're confusing `__address__` and `instance`. While  `__address__` can currently only be a host:port (and it's conceivable we'll have unix domain sockets some day), there's no such restriction on `instance`. It could be an ip:port, a dnsname:port, a dnsname, an IP, one of the various formattings of IPv6 addresses, a URL, a zookeeper path, a consul path, a EC2 instance ID or anything else that makes sense in the context of your deployment and in particular your service discovery.\r\n\r\nThis is something that's only make sense in some deployments, and adding in labels like this will cause problems for users as it'll require additional special handling by users to strip off as we improve label handling in promql.\r\n\r\nThis is not something we can safely do by default due to both safety, and because it's not sane from a maintenance/usability standpoint to offer options, let alone defaults, for the multitude of common scenarios.\r\n"}}