{"action":"closed","number":3,"pull_request":{"url":"https://api.github.com/repos/oharaandrew314/Common/pulls/3","id":34425812,"html_url":"https://github.com/oharaandrew314/Common/pull/3","diff_url":"https://github.com/oharaandrew314/Common/pull/3.diff","patch_url":"https://github.com/oharaandrew314/Common/pull/3.patch","issue_url":"https://api.github.com/repos/oharaandrew314/Common/issues/3","number":3,"state":"closed","locked":false,"title":"Add custom version checker","user":{"login":"iulianov","id":7910317,"avatar_url":"https://avatars.githubusercontent.com/u/7910317?v=3","gravatar_id":"","url":"https://api.github.com/users/iulianov","html_url":"https://github.com/iulianov","followers_url":"https://api.github.com/users/iulianov/followers","following_url":"https://api.github.com/users/iulianov/following{/other_user}","gists_url":"https://api.github.com/users/iulianov/gists{/gist_id}","starred_url":"https://api.github.com/users/iulianov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iulianov/subscriptions","organizations_url":"https://api.github.com/users/iulianov/orgs","repos_url":"https://api.github.com/users/iulianov/repos","events_url":"https://api.github.com/users/iulianov/events{/privacy}","received_events_url":"https://api.github.com/users/iulianov/received_events","type":"User","site_admin":false},"body":"The current version checking code is broken for some mods on curseforge\r\nhttp://www.curse.com/ksp-mods/kerbal/223730-kerbol-positioning-system\r\nhttp://www.curse.com/ksp-mods/kerbal/220289-kerbal-alarm-clock\r\n\r\nSince you are only using it to compare version numbers I have written some custom code that allows mods with versions that do not conform to the semver standard.\r\n\r\nThis is not just a compatibility request though. With the code used in VersionParser TinkerTime would mistakenly use old versions of mods under certain conditions:\r\nold mod version: `<1.0.1.21>`\r\nnew mod version `<1.0.10.1>`\r\nThe code in VersionParser that made sure there are exactly 3 version numbers would create the following version strings:\r\n`<1.0.121>`(old) and `<1.0.101>`(new)\r\nThis would cause the jsemver code to conclude that the old file is actually newer than the new file.\r\n\r\nThere is another pull request for TinkerTime itself so that it uses the custom version checker.","created_at":"2015-04-30T03:29:15Z","updated_at":"2015-04-30T03:50:04Z","closed_at":"2015-04-30T03:50:04Z","merged_at":null,"merge_commit_sha":"12aca624a0ffa5c7ab98ba0da231dab303723e48","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/oharaandrew314/Common/pulls/3/commits","review_comments_url":"https://api.github.com/repos/oharaandrew314/Common/pulls/3/comments","review_comment_url":"https://api.github.com/repos/oharaandrew314/Common/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oharaandrew314/Common/issues/3/comments","statuses_url":"https://api.github.com/repos/oharaandrew314/Common/statuses/e7e8e215156a9a166cf5bcf59a7e117609aaa0cf","head":{"label":"iulianov:master","ref":"master","sha":"e7e8e215156a9a166cf5bcf59a7e117609aaa0cf","user":{"login":"iulianov","id":7910317,"avatar_url":"https://avatars.githubusercontent.com/u/7910317?v=3","gravatar_id":"","url":"https://api.github.com/users/iulianov","html_url":"https://github.com/iulianov","followers_url":"https://api.github.com/users/iulianov/followers","following_url":"https://api.github.com/users/iulianov/following{/other_user}","gists_url":"https://api.github.com/users/iulianov/gists{/gist_id}","starred_url":"https://api.github.com/users/iulianov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iulianov/subscriptions","organizations_url":"https://api.github.com/users/iulianov/orgs","repos_url":"https://api.github.com/users/iulianov/repos","events_url":"https://api.github.com/users/iulianov/events{/privacy}","received_events_url":"https://api.github.com/users/iulianov/received_events","type":"User","site_admin":false},"repo":{"id":34829536,"name":"Common","full_name":"iulianov/Common","owner":{"login":"iulianov","id":7910317,"avatar_url":"https://avatars.githubusercontent.com/u/7910317?v=3","gravatar_id":"","url":"https://api.github.com/users/iulianov","html_url":"https://github.com/iulianov","followers_url":"https://api.github.com/users/iulianov/followers","following_url":"https://api.github.com/users/iulianov/following{/other_user}","gists_url":"https://api.github.com/users/iulianov/gists{/gist_id}","starred_url":"https://api.github.com/users/iulianov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iulianov/subscriptions","organizations_url":"https://api.github.com/users/iulianov/orgs","repos_url":"https://api.github.com/users/iulianov/repos","events_url":"https://api.github.com/users/iulianov/events{/privacy}","received_events_url":"https://api.github.com/users/iulianov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iulianov/Common","description":"Common Java Files","fork":true,"url":"https://api.github.com/repos/iulianov/Common","forks_url":"https://api.github.com/repos/iulianov/Common/forks","keys_url":"https://api.github.com/repos/iulianov/Common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iulianov/Common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iulianov/Common/teams","hooks_url":"https://api.github.com/repos/iulianov/Common/hooks","issue_events_url":"https://api.github.com/repos/iulianov/Common/issues/events{/number}","events_url":"https://api.github.com/repos/iulianov/Common/events","assignees_url":"https://api.github.com/repos/iulianov/Common/assignees{/user}","branches_url":"https://api.github.com/repos/iulianov/Common/branches{/branch}","tags_url":"https://api.github.com/repos/iulianov/Common/tags","blobs_url":"https://api.github.com/repos/iulianov/Common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iulianov/Common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iulianov/Common/git/refs{/sha}","trees_url":"https://api.github.com/repos/iulianov/Common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iulianov/Common/statuses/{sha}","languages_url":"https://api.github.com/repos/iulianov/Common/languages","stargazers_url":"https://api.github.com/repos/iulianov/Common/stargazers","contributors_url":"https://api.github.com/repos/iulianov/Common/contributors","subscribers_url":"https://api.github.com/repos/iulianov/Common/subscribers","subscription_url":"https://api.github.com/repos/iulianov/Common/subscription","commits_url":"https://api.github.com/repos/iulianov/Common/commits{/sha}","git_commits_url":"https://api.github.com/repos/iulianov/Common/git/commits{/sha}","comments_url":"https://api.github.com/repos/iulianov/Common/comments{/number}","issue_comment_url":"https://api.github.com/repos/iulianov/Common/issues/comments{/number}","contents_url":"https://api.github.com/repos/iulianov/Common/contents/{+path}","compare_url":"https://api.github.com/repos/iulianov/Common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iulianov/Common/merges","archive_url":"https://api.github.com/repos/iulianov/Common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iulianov/Common/downloads","issues_url":"https://api.github.com/repos/iulianov/Common/issues{/number}","pulls_url":"https://api.github.com/repos/iulianov/Common/pulls{/number}","milestones_url":"https://api.github.com/repos/iulianov/Common/milestones{/number}","notifications_url":"https://api.github.com/repos/iulianov/Common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iulianov/Common/labels{/name}","releases_url":"https://api.github.com/repos/iulianov/Common/releases{/id}","created_at":"2015-04-30T02:21:59Z","updated_at":"2015-04-30T03:48:50Z","pushed_at":"2015-04-30T03:48:50Z","git_url":"git://github.com/iulianov/Common.git","ssh_url":"git@github.com:iulianov/Common.git","clone_url":"https://github.com/iulianov/Common.git","svn_url":"https://github.com/iulianov/Common","homepage":null,"size":1004,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"oharaandrew314:master","ref":"master","sha":"efbff3793a2ae7f9362a3ef873f6f5811efcab54","user":{"login":"oharaandrew314","id":894152,"avatar_url":"https://avatars.githubusercontent.com/u/894152?v=3","gravatar_id":"","url":"https://api.github.com/users/oharaandrew314","html_url":"https://github.com/oharaandrew314","followers_url":"https://api.github.com/users/oharaandrew314/followers","following_url":"https://api.github.com/users/oharaandrew314/following{/other_user}","gists_url":"https://api.github.com/users/oharaandrew314/gists{/gist_id}","starred_url":"https://api.github.com/users/oharaandrew314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oharaandrew314/subscriptions","organizations_url":"https://api.github.com/users/oharaandrew314/orgs","repos_url":"https://api.github.com/users/oharaandrew314/repos","events_url":"https://api.github.com/users/oharaandrew314/events{/privacy}","received_events_url":"https://api.github.com/users/oharaandrew314/received_events","type":"User","site_admin":false},"repo":{"id":21223372,"name":"Common","full_name":"oharaandrew314/Common","owner":{"login":"oharaandrew314","id":894152,"avatar_url":"https://avatars.githubusercontent.com/u/894152?v=3","gravatar_id":"","url":"https://api.github.com/users/oharaandrew314","html_url":"https://github.com/oharaandrew314","followers_url":"https://api.github.com/users/oharaandrew314/followers","following_url":"https://api.github.com/users/oharaandrew314/following{/other_user}","gists_url":"https://api.github.com/users/oharaandrew314/gists{/gist_id}","starred_url":"https://api.github.com/users/oharaandrew314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oharaandrew314/subscriptions","organizations_url":"https://api.github.com/users/oharaandrew314/orgs","repos_url":"https://api.github.com/users/oharaandrew314/repos","events_url":"https://api.github.com/users/oharaandrew314/events{/privacy}","received_events_url":"https://api.github.com/users/oharaandrew314/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oharaandrew314/Common","description":"Common Java Files","fork":false,"url":"https://api.github.com/repos/oharaandrew314/Common","forks_url":"https://api.github.com/repos/oharaandrew314/Common/forks","keys_url":"https://api.github.com/repos/oharaandrew314/Common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oharaandrew314/Common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oharaandrew314/Common/teams","hooks_url":"https://api.github.com/repos/oharaandrew314/Common/hooks","issue_events_url":"https://api.github.com/repos/oharaandrew314/Common/issues/events{/number}","events_url":"https://api.github.com/repos/oharaandrew314/Common/events","assignees_url":"https://api.github.com/repos/oharaandrew314/Common/assignees{/user}","branches_url":"https://api.github.com/repos/oharaandrew314/Common/branches{/branch}","tags_url":"https://api.github.com/repos/oharaandrew314/Common/tags","blobs_url":"https://api.github.com/repos/oharaandrew314/Common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oharaandrew314/Common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oharaandrew314/Common/git/refs{/sha}","trees_url":"https://api.github.com/repos/oharaandrew314/Common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oharaandrew314/Common/statuses/{sha}","languages_url":"https://api.github.com/repos/oharaandrew314/Common/languages","stargazers_url":"https://api.github.com/repos/oharaandrew314/Common/stargazers","contributors_url":"https://api.github.com/repos/oharaandrew314/Common/contributors","subscribers_url":"https://api.github.com/repos/oharaandrew314/Common/subscribers","subscription_url":"https://api.github.com/repos/oharaandrew314/Common/subscription","commits_url":"https://api.github.com/repos/oharaandrew314/Common/commits{/sha}","git_commits_url":"https://api.github.com/repos/oharaandrew314/Common/git/commits{/sha}","comments_url":"https://api.github.com/repos/oharaandrew314/Common/comments{/number}","issue_comment_url":"https://api.github.com/repos/oharaandrew314/Common/issues/comments{/number}","contents_url":"https://api.github.com/repos/oharaandrew314/Common/contents/{+path}","compare_url":"https://api.github.com/repos/oharaandrew314/Common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oharaandrew314/Common/merges","archive_url":"https://api.github.com/repos/oharaandrew314/Common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oharaandrew314/Common/downloads","issues_url":"https://api.github.com/repos/oharaandrew314/Common/issues{/number}","pulls_url":"https://api.github.com/repos/oharaandrew314/Common/pulls{/number}","milestones_url":"https://api.github.com/repos/oharaandrew314/Common/milestones{/number}","notifications_url":"https://api.github.com/repos/oharaandrew314/Common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oharaandrew314/Common/labels{/name}","releases_url":"https://api.github.com/repos/oharaandrew314/Common/releases{/id}","created_at":"2014-06-26T00:53:06Z","updated_at":"2015-04-26T18:22:43Z","pushed_at":"2015-04-30T03:48:51Z","git_url":"git://github.com/oharaandrew314/Common.git","ssh_url":"git@github.com:oharaandrew314/Common.git","clone_url":"https://github.com/oharaandrew314/Common.git","svn_url":"https://github.com/oharaandrew314/Common","homepage":null,"size":1004,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oharaandrew314/Common/pulls/3"},"html":{"href":"https://github.com/oharaandrew314/Common/pull/3"},"issue":{"href":"https://api.github.com/repos/oharaandrew314/Common/issues/3"},"comments":{"href":"https://api.github.com/repos/oharaandrew314/Common/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/oharaandrew314/Common/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/oharaandrew314/Common/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oharaandrew314/Common/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/oharaandrew314/Common/statuses/e7e8e215156a9a166cf5bcf59a7e117609aaa0cf"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":5,"commits":2,"additions":55,"deletions":20,"changed_files":2}}