{"action":"created","comment":{"url":"https://api.github.com/repos/libgdx/libgdx/pulls/comments/37532053","id":37532053,"diff_hunk":"@@ -0,0 +1,28 @@\n+/*******************************************************************************\n+ * Copyright 2011 See AUTHORS file.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *   http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ ******************************************************************************/\n+\n+package com.badlogic.gdx.graphics.g3d.shadow.filter;\n+\n+import com.badlogic.gdx.graphics.Camera;\n+import com.badlogic.gdx.graphics.g3d.environment.BaseLight;\n+\n+public class NoLightFilter implements LightFilter {\n+\n+\t@Override\n+\tpublic boolean filter (int n, BaseLight light, Camera camera) {\n+\t\treturn true;","path":"gdx/src/com/badlogic/gdx/graphics/g3d/shadow/filter/NoLightFilter.java","position":26,"original_position":26,"commit_id":"5b691e2f3e2d676f790075eaf15a081c85d7d2ac","original_commit_id":"5b691e2f3e2d676f790075eaf15a081c85d7d2ac","user":{"login":"realitix","id":6367936,"avatar_url":"https://avatars.githubusercontent.com/u/6367936?v=3","gravatar_id":"","url":"https://api.github.com/users/realitix","html_url":"https://github.com/realitix","followers_url":"https://api.github.com/users/realitix/followers","following_url":"https://api.github.com/users/realitix/following{/other_user}","gists_url":"https://api.github.com/users/realitix/gists{/gist_id}","starred_url":"https://api.github.com/users/realitix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realitix/subscriptions","organizations_url":"https://api.github.com/users/realitix/orgs","repos_url":"https://api.github.com/users/realitix/repos","events_url":"https://api.github.com/users/realitix/events{/privacy}","received_events_url":"https://api.github.com/users/realitix/received_events","type":"User","site_admin":false},"body":"The name is poorly choosen. It means that the filter lets all pass. Have you got an idea for a better name ?","created_at":"2015-08-20T14:01:38Z","updated_at":"2015-08-20T14:01:38Z","html_url":"https://github.com/libgdx/libgdx/pull/3347#discussion_r37532053","pull_request_url":"https://api.github.com/repos/libgdx/libgdx/pulls/3347","_links":{"self":{"href":"https://api.github.com/repos/libgdx/libgdx/pulls/comments/37532053"},"html":{"href":"https://github.com/libgdx/libgdx/pull/3347#discussion_r37532053"},"pull_request":{"href":"https://api.github.com/repos/libgdx/libgdx/pulls/3347"}}},"pull_request":{"url":"https://api.github.com/repos/libgdx/libgdx/pulls/3347","id":42254151,"html_url":"https://github.com/libgdx/libgdx/pull/3347","diff_url":"https://github.com/libgdx/libgdx/pull/3347.diff","patch_url":"https://github.com/libgdx/libgdx/pull/3347.patch","issue_url":"https://api.github.com/repos/libgdx/libgdx/issues/3347","number":3347,"state":"open","locked":false,"title":"Add Shadow system in LibGDX.","user":{"login":"realitix","id":6367936,"avatar_url":"https://avatars.githubusercontent.com/u/6367936?v=3","gravatar_id":"","url":"https://api.github.com/users/realitix","html_url":"https://github.com/realitix","followers_url":"https://api.github.com/users/realitix/followers","following_url":"https://api.github.com/users/realitix/following{/other_user}","gists_url":"https://api.github.com/users/realitix/gists{/gist_id}","starred_url":"https://api.github.com/users/realitix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realitix/subscriptions","organizations_url":"https://api.github.com/users/realitix/orgs","repos_url":"https://api.github.com/users/realitix/repos","events_url":"https://api.github.com/users/realitix/events{/privacy}","received_events_url":"https://api.github.com/users/realitix/received_events","type":"User","site_admin":false},"body":"The shadow system accept point, spot and directional light.\r\nEverything is done to help the user create his own shadow system if\r\nneeded.\r\nSee http://www.badlogicgames.com/forum/viewtopic.php?f=11&t=18707\r\n\r\nI know this is huge and will no be merged that way but this pull request allows us to speak about shadow system. \r\nI think it's a good start.\r\n\r\nHere the demo on youtube : https://www.youtube.com/watch?v=xb7Q_Kx4SdA\r\nI can connect on IRC to speak. My email is in the commit (git log).\r\n\r\nGood luck reviewing !","created_at":"2015-08-12T15:37:56Z","updated_at":"2015-08-20T14:01:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ce75fbcaaf51f744fe2da88d3f628be4e185391","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/libgdx/libgdx/pulls/3347/commits","review_comments_url":"https://api.github.com/repos/libgdx/libgdx/pulls/3347/comments","review_comment_url":"https://api.github.com/repos/libgdx/libgdx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libgdx/libgdx/issues/3347/comments","statuses_url":"https://api.github.com/repos/libgdx/libgdx/statuses/5b691e2f3e2d676f790075eaf15a081c85d7d2ac","head":{"label":"realitix:shadow_clean","ref":"shadow_clean","sha":"5b691e2f3e2d676f790075eaf15a081c85d7d2ac","user":{"login":"realitix","id":6367936,"avatar_url":"https://avatars.githubusercontent.com/u/6367936?v=3","gravatar_id":"","url":"https://api.github.com/users/realitix","html_url":"https://github.com/realitix","followers_url":"https://api.github.com/users/realitix/followers","following_url":"https://api.github.com/users/realitix/following{/other_user}","gists_url":"https://api.github.com/users/realitix/gists{/gist_id}","starred_url":"https://api.github.com/users/realitix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realitix/subscriptions","organizations_url":"https://api.github.com/users/realitix/orgs","repos_url":"https://api.github.com/users/realitix/repos","events_url":"https://api.github.com/users/realitix/events{/privacy}","received_events_url":"https://api.github.com/users/realitix/received_events","type":"User","site_admin":false},"repo":{"id":31720498,"name":"libgdx","full_name":"realitix/libgdx","owner":{"login":"realitix","id":6367936,"avatar_url":"https://avatars.githubusercontent.com/u/6367936?v=3","gravatar_id":"","url":"https://api.github.com/users/realitix","html_url":"https://github.com/realitix","followers_url":"https://api.github.com/users/realitix/followers","following_url":"https://api.github.com/users/realitix/following{/other_user}","gists_url":"https://api.github.com/users/realitix/gists{/gist_id}","starred_url":"https://api.github.com/users/realitix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realitix/subscriptions","organizations_url":"https://api.github.com/users/realitix/orgs","repos_url":"https://api.github.com/users/realitix/repos","events_url":"https://api.github.com/users/realitix/events{/privacy}","received_events_url":"https://api.github.com/users/realitix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/realitix/libgdx","description":"Desktop/Android/HTML5/iOS Java game development framework","fork":true,"url":"https://api.github.com/repos/realitix/libgdx","forks_url":"https://api.github.com/repos/realitix/libgdx/forks","keys_url":"https://api.github.com/repos/realitix/libgdx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/realitix/libgdx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/realitix/libgdx/teams","hooks_url":"https://api.github.com/repos/realitix/libgdx/hooks","issue_events_url":"https://api.github.com/repos/realitix/libgdx/issues/events{/number}","events_url":"https://api.github.com/repos/realitix/libgdx/events","assignees_url":"https://api.github.com/repos/realitix/libgdx/assignees{/user}","branches_url":"https://api.github.com/repos/realitix/libgdx/branches{/branch}","tags_url":"https://api.github.com/repos/realitix/libgdx/tags","blobs_url":"https://api.github.com/repos/realitix/libgdx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/realitix/libgdx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/realitix/libgdx/git/refs{/sha}","trees_url":"https://api.github.com/repos/realitix/libgdx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/realitix/libgdx/statuses/{sha}","languages_url":"https://api.github.com/repos/realitix/libgdx/languages","stargazers_url":"https://api.github.com/repos/realitix/libgdx/stargazers","contributors_url":"https://api.github.com/repos/realitix/libgdx/contributors","subscribers_url":"https://api.github.com/repos/realitix/libgdx/subscribers","subscription_url":"https://api.github.com/repos/realitix/libgdx/subscription","commits_url":"https://api.github.com/repos/realitix/libgdx/commits{/sha}","git_commits_url":"https://api.github.com/repos/realitix/libgdx/git/commits{/sha}","comments_url":"https://api.github.com/repos/realitix/libgdx/comments{/number}","issue_comment_url":"https://api.github.com/repos/realitix/libgdx/issues/comments{/number}","contents_url":"https://api.github.com/repos/realitix/libgdx/contents/{+path}","compare_url":"https://api.github.com/repos/realitix/libgdx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/realitix/libgdx/merges","archive_url":"https://api.github.com/repos/realitix/libgdx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/realitix/libgdx/downloads","issues_url":"https://api.github.com/repos/realitix/libgdx/issues{/number}","pulls_url":"https://api.github.com/repos/realitix/libgdx/pulls{/number}","milestones_url":"https://api.github.com/repos/realitix/libgdx/milestones{/number}","notifications_url":"https://api.github.com/repos/realitix/libgdx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/realitix/libgdx/labels{/name}","releases_url":"https://api.github.com/repos/realitix/libgdx/releases{/id}","created_at":"2015-03-05T15:25:39Z","updated_at":"2015-08-18T13:23:10Z","pushed_at":"2015-08-20T13:13:31Z","git_url":"git://github.com/realitix/libgdx.git","ssh_url":"git@github.com:realitix/libgdx.git","clone_url":"https://github.com/realitix/libgdx.git","svn_url":"https://github.com/realitix/libgdx","homepage":"http://www.libgdx.com/","size":890157,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"libgdx:master","ref":"master","sha":"994d0afe2f21ff76c36a85fc6c54c170057fbbaa","user":{"login":"libgdx","id":509841,"avatar_url":"https://avatars.githubusercontent.com/u/509841?v=3","gravatar_id":"","url":"https://api.github.com/users/libgdx","html_url":"https://github.com/libgdx","followers_url":"https://api.github.com/users/libgdx/followers","following_url":"https://api.github.com/users/libgdx/following{/other_user}","gists_url":"https://api.github.com/users/libgdx/gists{/gist_id}","starred_url":"https://api.github.com/users/libgdx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgdx/subscriptions","organizations_url":"https://api.github.com/users/libgdx/orgs","repos_url":"https://api.github.com/users/libgdx/repos","events_url":"https://api.github.com/users/libgdx/events{/privacy}","received_events_url":"https://api.github.com/users/libgdx/received_events","type":"Organization","site_admin":false},"repo":{"id":5373551,"name":"libgdx","full_name":"libgdx/libgdx","owner":{"login":"libgdx","id":509841,"avatar_url":"https://avatars.githubusercontent.com/u/509841?v=3","gravatar_id":"","url":"https://api.github.com/users/libgdx","html_url":"https://github.com/libgdx","followers_url":"https://api.github.com/users/libgdx/followers","following_url":"https://api.github.com/users/libgdx/following{/other_user}","gists_url":"https://api.github.com/users/libgdx/gists{/gist_id}","starred_url":"https://api.github.com/users/libgdx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgdx/subscriptions","organizations_url":"https://api.github.com/users/libgdx/orgs","repos_url":"https://api.github.com/users/libgdx/repos","events_url":"https://api.github.com/users/libgdx/events{/privacy}","received_events_url":"https://api.github.com/users/libgdx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libgdx/libgdx","description":"Desktop/Android/HTML5/iOS Java game development framework","fork":false,"url":"https://api.github.com/repos/libgdx/libgdx","forks_url":"https://api.github.com/repos/libgdx/libgdx/forks","keys_url":"https://api.github.com/repos/libgdx/libgdx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libgdx/libgdx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libgdx/libgdx/teams","hooks_url":"https://api.github.com/repos/libgdx/libgdx/hooks","issue_events_url":"https://api.github.com/repos/libgdx/libgdx/issues/events{/number}","events_url":"https://api.github.com/repos/libgdx/libgdx/events","assignees_url":"https://api.github.com/repos/libgdx/libgdx/assignees{/user}","branches_url":"https://api.github.com/repos/libgdx/libgdx/branches{/branch}","tags_url":"https://api.github.com/repos/libgdx/libgdx/tags","blobs_url":"https://api.github.com/repos/libgdx/libgdx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libgdx/libgdx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libgdx/libgdx/git/refs{/sha}","trees_url":"https://api.github.com/repos/libgdx/libgdx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libgdx/libgdx/statuses/{sha}","languages_url":"https://api.github.com/repos/libgdx/libgdx/languages","stargazers_url":"https://api.github.com/repos/libgdx/libgdx/stargazers","contributors_url":"https://api.github.com/repos/libgdx/libgdx/contributors","subscribers_url":"https://api.github.com/repos/libgdx/libgdx/subscribers","subscription_url":"https://api.github.com/repos/libgdx/libgdx/subscription","commits_url":"https://api.github.com/repos/libgdx/libgdx/commits{/sha}","git_commits_url":"https://api.github.com/repos/libgdx/libgdx/git/commits{/sha}","comments_url":"https://api.github.com/repos/libgdx/libgdx/comments{/number}","issue_comment_url":"https://api.github.com/repos/libgdx/libgdx/issues/comments{/number}","contents_url":"https://api.github.com/repos/libgdx/libgdx/contents/{+path}","compare_url":"https://api.github.com/repos/libgdx/libgdx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libgdx/libgdx/merges","archive_url":"https://api.github.com/repos/libgdx/libgdx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libgdx/libgdx/downloads","issues_url":"https://api.github.com/repos/libgdx/libgdx/issues{/number}","pulls_url":"https://api.github.com/repos/libgdx/libgdx/pulls{/number}","milestones_url":"https://api.github.com/repos/libgdx/libgdx/milestones{/number}","notifications_url":"https://api.github.com/repos/libgdx/libgdx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libgdx/libgdx/labels{/name}","releases_url":"https://api.github.com/repos/libgdx/libgdx/releases{/id}","created_at":"2012-08-10T19:34:38Z","updated_at":"2015-08-20T13:46:09Z","pushed_at":"2015-08-20T13:13:35Z","git_url":"git://github.com/libgdx/libgdx.git","ssh_url":"git@github.com:libgdx/libgdx.git","clone_url":"https://github.com/libgdx/libgdx.git","svn_url":"https://github.com/libgdx/libgdx","homepage":"http://www.libgdx.com/","size":1008836,"stargazers_count":6846,"watchers_count":6846,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4057,"mirror_url":null,"open_issues_count":97,"forks":4057,"open_issues":97,"watchers":6846,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libgdx/libgdx/pulls/3347"},"html":{"href":"https://github.com/libgdx/libgdx/pull/3347"},"issue":{"href":"https://api.github.com/repos/libgdx/libgdx/issues/3347"},"comments":{"href":"https://api.github.com/repos/libgdx/libgdx/issues/3347/comments"},"review_comments":{"href":"https://api.github.com/repos/libgdx/libgdx/pulls/3347/comments"},"review_comment":{"href":"https://api.github.com/repos/libgdx/libgdx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libgdx/libgdx/pulls/3347/commits"},"statuses":{"href":"https://api.github.com/repos/libgdx/libgdx/statuses/5b691e2f3e2d676f790075eaf15a081c85d7d2ac"}}}}