{"action":"closed","number":3961,"pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/3961","id":39509044,"html_url":"https://github.com/netty/netty/pull/3961","diff_url":"https://github.com/netty/netty/pull/3961.diff","patch_url":"https://github.com/netty/netty/pull/3961.patch","issue_url":"https://api.github.com/repos/netty/netty/issues/3961","number":3961,"state":"closed","locked":false,"title":"Proper shutdown of HTTP2 encoder when channelInactive","user":{"login":"nmittler","id":6493296,"avatar_url":"https://avatars.githubusercontent.com/u/6493296?v=3","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"body":"Motivation:\r\n\r\nThe problem is described in https://github.com/grpc/grpc-java/issues/605. Basically, when using `StreamBufferingEncoder` there is a chance of creating zombie streams that never get closed.\r\n\r\nModifications:\r\n\r\nChange `Http2ConnectionHandler`'s `channelInactive` handling logic to shutdown the encoder/decoder before shutting down the active streams.\r\n\r\nResult:\r\n\r\nFixes https://github.com/grpc/grpc-java/issues/605","created_at":"2015-07-08T18:39:50Z","updated_at":"2015-07-09T14:37:32Z","closed_at":"2015-07-09T14:37:32Z","merged_at":null,"merge_commit_sha":"4eed571ac207f84d7e0264a558ca4f282527c3aa","assignee":{"login":"nmittler","id":6493296,"avatar_url":"https://avatars.githubusercontent.com/u/6493296?v=3","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/netty/netty/milestones/117","html_url":"https://github.com/netty/netty/milestones/4.1.0.Beta6","labels_url":"https://api.github.com/repos/netty/netty/milestones/117/labels","id":1100817,"number":117,"title":"4.1.0.Beta6","description":"","creator":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"open_issues":69,"closed_issues":41,"state":"open","created_at":"2015-05-07T19:29:09Z","updated_at":"2015-07-09T14:37:32Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/netty/netty/pulls/3961/commits","review_comments_url":"https://api.github.com/repos/netty/netty/pulls/3961/comments","review_comment_url":"https://api.github.com/repos/netty/netty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/netty/netty/issues/3961/comments","statuses_url":"https://api.github.com/repos/netty/netty/statuses/695eccbf65c5b78eca9a3ce5cff594f83059dd8c","head":{"label":"nmittler:inactive_fix","ref":"inactive_fix","sha":"695eccbf65c5b78eca9a3ce5cff594f83059dd8c","user":{"login":"nmittler","id":6493296,"avatar_url":"https://avatars.githubusercontent.com/u/6493296?v=3","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"repo":{"id":18468502,"name":"netty","full_name":"nmittler/netty","owner":{"login":"nmittler","id":6493296,"avatar_url":"https://avatars.githubusercontent.com/u/6493296?v=3","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nmittler/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":true,"url":"https://api.github.com/repos/nmittler/netty","forks_url":"https://api.github.com/repos/nmittler/netty/forks","keys_url":"https://api.github.com/repos/nmittler/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nmittler/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nmittler/netty/teams","hooks_url":"https://api.github.com/repos/nmittler/netty/hooks","issue_events_url":"https://api.github.com/repos/nmittler/netty/issues/events{/number}","events_url":"https://api.github.com/repos/nmittler/netty/events","assignees_url":"https://api.github.com/repos/nmittler/netty/assignees{/user}","branches_url":"https://api.github.com/repos/nmittler/netty/branches{/branch}","tags_url":"https://api.github.com/repos/nmittler/netty/tags","blobs_url":"https://api.github.com/repos/nmittler/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nmittler/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nmittler/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/nmittler/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nmittler/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/nmittler/netty/languages","stargazers_url":"https://api.github.com/repos/nmittler/netty/stargazers","contributors_url":"https://api.github.com/repos/nmittler/netty/contributors","subscribers_url":"https://api.github.com/repos/nmittler/netty/subscribers","subscription_url":"https://api.github.com/repos/nmittler/netty/subscription","commits_url":"https://api.github.com/repos/nmittler/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/nmittler/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/nmittler/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/nmittler/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/nmittler/netty/contents/{+path}","compare_url":"https://api.github.com/repos/nmittler/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nmittler/netty/merges","archive_url":"https://api.github.com/repos/nmittler/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nmittler/netty/downloads","issues_url":"https://api.github.com/repos/nmittler/netty/issues{/number}","pulls_url":"https://api.github.com/repos/nmittler/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/nmittler/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/nmittler/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nmittler/netty/labels{/name}","releases_url":"https://api.github.com/repos/nmittler/netty/releases{/id}","created_at":"2014-04-05T14:33:03Z","updated_at":"2015-02-02T15:50:48Z","pushed_at":"2015-07-08T22:32:21Z","git_url":"git://github.com/nmittler/netty.git","ssh_url":"git@github.com:nmittler/netty.git","clone_url":"https://github.com/nmittler/netty.git","svn_url":"https://github.com/nmittler/netty","homepage":"http://netty.io/","size":42653,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"netty:master","ref":"master","sha":"d43569fce6cb408857c69050142426eb1eac03f1","user":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"repo":{"id":1064563,"name":"netty","full_name":"netty/netty","owner":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netty/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":false,"url":"https://api.github.com/repos/netty/netty","forks_url":"https://api.github.com/repos/netty/netty/forks","keys_url":"https://api.github.com/repos/netty/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netty/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netty/netty/teams","hooks_url":"https://api.github.com/repos/netty/netty/hooks","issue_events_url":"https://api.github.com/repos/netty/netty/issues/events{/number}","events_url":"https://api.github.com/repos/netty/netty/events","assignees_url":"https://api.github.com/repos/netty/netty/assignees{/user}","branches_url":"https://api.github.com/repos/netty/netty/branches{/branch}","tags_url":"https://api.github.com/repos/netty/netty/tags","blobs_url":"https://api.github.com/repos/netty/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netty/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netty/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/netty/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netty/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/netty/netty/languages","stargazers_url":"https://api.github.com/repos/netty/netty/stargazers","contributors_url":"https://api.github.com/repos/netty/netty/contributors","subscribers_url":"https://api.github.com/repos/netty/netty/subscribers","subscription_url":"https://api.github.com/repos/netty/netty/subscription","commits_url":"https://api.github.com/repos/netty/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/netty/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/netty/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/netty/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/netty/netty/contents/{+path}","compare_url":"https://api.github.com/repos/netty/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netty/netty/merges","archive_url":"https://api.github.com/repos/netty/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netty/netty/downloads","issues_url":"https://api.github.com/repos/netty/netty/issues{/number}","pulls_url":"https://api.github.com/repos/netty/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/netty/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/netty/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netty/netty/labels{/name}","releases_url":"https://api.github.com/repos/netty/netty/releases{/id}","created_at":"2010-11-09T09:22:21Z","updated_at":"2015-07-09T08:54:27Z","pushed_at":"2015-07-09T14:36:54Z","git_url":"git://github.com/netty/netty.git","ssh_url":"git@github.com:netty/netty.git","clone_url":"https://github.com/netty/netty.git","svn_url":"https://github.com/netty/netty","homepage":"http://netty.io/","size":129398,"stargazers_count":4880,"watchers_count":4880,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2429,"mirror_url":null,"open_issues_count":298,"forks":2429,"open_issues":298,"watchers":4880,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/3961"},"html":{"href":"https://github.com/netty/netty/pull/3961"},"issue":{"href":"https://api.github.com/repos/netty/netty/issues/3961"},"comments":{"href":"https://api.github.com/repos/netty/netty/issues/3961/comments"},"review_comments":{"href":"https://api.github.com/repos/netty/netty/pulls/3961/comments"},"review_comment":{"href":"https://api.github.com/repos/netty/netty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/netty/netty/pulls/3961/commits"},"statuses":{"href":"https://api.github.com/repos/netty/netty/statuses/695eccbf65c5b78eca9a3ce5cff594f83059dd8c"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":5,"review_comments":11,"commits":2,"additions":79,"deletions":39,"changed_files":3}}