{"action":"created","issue":{"url":"https://api.github.com/repos/droolsjbpm/jbpm-console-ng/issues/190","labels_url":"https://api.github.com/repos/droolsjbpm/jbpm-console-ng/issues/190/labels{/name}","comments_url":"https://api.github.com/repos/droolsjbpm/jbpm-console-ng/issues/190/comments","events_url":"https://api.github.com/repos/droolsjbpm/jbpm-console-ng/issues/190/events","html_url":"https://github.com/droolsjbpm/jbpm-console-ng/pull/190","id":110586925,"number":190,"title":"JBPM-4664:Fix Admin tab can not show in TaskDetailsMulti page","user":{"login":"bxf12315","id":209745,"avatar_url":"https://avatars.githubusercontent.com/u/209745?v=3","gravatar_id":"","url":"https://api.github.com/users/bxf12315","html_url":"https://github.com/bxf12315","followers_url":"https://api.github.com/users/bxf12315/followers","following_url":"https://api.github.com/users/bxf12315/following{/other_user}","gists_url":"https://api.github.com/users/bxf12315/gists{/gist_id}","starred_url":"https://api.github.com/users/bxf12315/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bxf12315/subscriptions","organizations_url":"https://api.github.com/users/bxf12315/orgs","repos_url":"https://api.github.com/users/bxf12315/repos","events_url":"https://api.github.com/users/bxf12315/events{/privacy}","received_events_url":"https://api.github.com/users/bxf12315/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-10-09T04:47:07Z","updated_at":"2015-11-10T06:47:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/droolsjbpm/jbpm-console-ng/pulls/190","html_url":"https://github.com/droolsjbpm/jbpm-console-ng/pull/190","diff_url":"https://github.com/droolsjbpm/jbpm-console-ng/pull/190.diff","patch_url":"https://github.com/droolsjbpm/jbpm-console-ng/pull/190.patch"},"body":"@Salaboy \r\nI fixed Admin tab can not show in TaskDetailsMulti page and remove some never use code.\r\nPlease review it.\r\nThanks   "},"comment":{"url":"https://api.github.com/repos/droolsjbpm/jbpm-console-ng/issues/comments/155322465","html_url":"https://github.com/droolsjbpm/jbpm-console-ng/pull/190#issuecomment-155322465","issue_url":"https://api.github.com/repos/droolsjbpm/jbpm-console-ng/issues/190","id":155322465,"user":{"login":"cristianonicolai","id":570894,"avatar_url":"https://avatars.githubusercontent.com/u/570894?v=3","gravatar_id":"","url":"https://api.github.com/users/cristianonicolai","html_url":"https://github.com/cristianonicolai","followers_url":"https://api.github.com/users/cristianonicolai/followers","following_url":"https://api.github.com/users/cristianonicolai/following{/other_user}","gists_url":"https://api.github.com/users/cristianonicolai/gists{/gist_id}","starred_url":"https://api.github.com/users/cristianonicolai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristianonicolai/subscriptions","organizations_url":"https://api.github.com/users/cristianonicolai/orgs","repos_url":"https://api.github.com/users/cristianonicolai/repos","events_url":"https://api.github.com/users/cristianonicolai/events{/privacy}","received_events_url":"https://api.github.com/users/cristianonicolai/received_events","type":"User","site_admin":false},"created_at":"2015-11-10T06:47:04Z","updated_at":"2015-11-10T06:47:04Z","body":"@bxf12315 a few comments here.\r\n\r\nCould you avoid changing any of the TasksListGrid* classes, I don't think they're exactly related to fixing the main problem here.\r\n\r\nJBPM-4664 is quite generic issue around Maitai, could you open a specific issue with the details about this problem?\r\n\r\nAnother problem I see is that with your fix, only when I select a task from the admin tab, I'll be able to see the admin tab. I think what should happen is that independently from where I open a task, if I'm a task admin, the admin tab should always be visible. \r\n\r\nWould be nice if some tests we included as well :)\r\n\r\n\r\n"}}