{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/data/pulls/comments/47427358","id":47427358,"diff_hunk":"@@ -578,11 +578,13 @@ Store = Service.extend({\n   */\n   findByIds(modelName, ids) {\n     assert('Passing classes to store methods has been removed. Please pass a dasherized string instead of '+ Ember.inspect(modelName), typeof modelName === 'string');\n-    var store = this;\n+    let promises = [];","path":"addon/-private/system/store.js","position":5,"original_position":5,"commit_id":"268c2521e0e8e14bf0fd6dcf350a98249a9ab7df","original_commit_id":"268c2521e0e8e14bf0fd6dcf350a98249a9ab7df","user":{"login":"stefanpenner","id":1377,"avatar_url":"https://avatars.githubusercontent.com/u/1377?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanpenner","html_url":"https://github.com/stefanpenner","followers_url":"https://api.github.com/users/stefanpenner/followers","following_url":"https://api.github.com/users/stefanpenner/following{/other_user}","gists_url":"https://api.github.com/users/stefanpenner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanpenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanpenner/subscriptions","organizations_url":"https://api.github.com/users/stefanpenner/orgs","repos_url":"https://api.github.com/users/stefanpenner/repos","events_url":"https://api.github.com/users/stefanpenner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanpenner/received_events","type":"User","site_admin":false},"body":"pre alloc","created_at":"2015-12-12T05:08:55Z","updated_at":"2015-12-12T05:08:55Z","html_url":"https://github.com/emberjs/data/pull/3988#discussion_r47427358","pull_request_url":"https://api.github.com/repos/emberjs/data/pulls/3988","_links":{"self":{"href":"https://api.github.com/repos/emberjs/data/pulls/comments/47427358"},"html":{"href":"https://github.com/emberjs/data/pull/3988#discussion_r47427358"},"pull_request":{"href":"https://api.github.com/repos/emberjs/data/pulls/3988"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/data/pulls/3988","id":53454976,"html_url":"https://github.com/emberjs/data/pull/3988","diff_url":"https://github.com/emberjs/data/pull/3988.diff","patch_url":"https://github.com/emberjs/data/pull/3988.patch","issue_url":"https://api.github.com/repos/emberjs/data/issues/3988","number":3988,"state":"open","locked":false,"title":"[PERF] Don't use array methods","user":{"login":"chadhietala","id":183799,"avatar_url":"https://avatars.githubusercontent.com/u/183799?v=3","gravatar_id":"","url":"https://api.github.com/users/chadhietala","html_url":"https://github.com/chadhietala","followers_url":"https://api.github.com/users/chadhietala/followers","following_url":"https://api.github.com/users/chadhietala/following{/other_user}","gists_url":"https://api.github.com/users/chadhietala/gists{/gist_id}","starred_url":"https://api.github.com/users/chadhietala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadhietala/subscriptions","organizations_url":"https://api.github.com/users/chadhietala/orgs","repos_url":"https://api.github.com/users/chadhietala/repos","events_url":"https://api.github.com/users/chadhietala/events{/privacy}","received_events_url":"https://api.github.com/users/chadhietala/received_events","type":"User","site_admin":false},"body":"We shouldn't use array methods as they allocate and close over items that need to be GC'd. Memory preasure can be an issue and we should do everything to reduce that preasure.","created_at":"2015-12-11T22:57:54Z","updated_at":"2015-12-12T05:08:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b3560b9a9ce330ff4d430c8afaf3217622e6639","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/data/pulls/3988/commits","review_comments_url":"https://api.github.com/repos/emberjs/data/pulls/3988/comments","review_comment_url":"https://api.github.com/repos/emberjs/data/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/data/issues/3988/comments","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/268c2521e0e8e14bf0fd6dcf350a98249a9ab7df","head":{"label":"chadhietala:allocating-alex","ref":"allocating-alex","sha":"268c2521e0e8e14bf0fd6dcf350a98249a9ab7df","user":{"login":"chadhietala","id":183799,"avatar_url":"https://avatars.githubusercontent.com/u/183799?v=3","gravatar_id":"","url":"https://api.github.com/users/chadhietala","html_url":"https://github.com/chadhietala","followers_url":"https://api.github.com/users/chadhietala/followers","following_url":"https://api.github.com/users/chadhietala/following{/other_user}","gists_url":"https://api.github.com/users/chadhietala/gists{/gist_id}","starred_url":"https://api.github.com/users/chadhietala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadhietala/subscriptions","organizations_url":"https://api.github.com/users/chadhietala/orgs","repos_url":"https://api.github.com/users/chadhietala/repos","events_url":"https://api.github.com/users/chadhietala/events{/privacy}","received_events_url":"https://api.github.com/users/chadhietala/received_events","type":"User","site_admin":false},"repo":{"id":23748740,"name":"data","full_name":"chadhietala/data","owner":{"login":"chadhietala","id":183799,"avatar_url":"https://avatars.githubusercontent.com/u/183799?v=3","gravatar_id":"","url":"https://api.github.com/users/chadhietala","html_url":"https://github.com/chadhietala","followers_url":"https://api.github.com/users/chadhietala/followers","following_url":"https://api.github.com/users/chadhietala/following{/other_user}","gists_url":"https://api.github.com/users/chadhietala/gists{/gist_id}","starred_url":"https://api.github.com/users/chadhietala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadhietala/subscriptions","organizations_url":"https://api.github.com/users/chadhietala/orgs","repos_url":"https://api.github.com/users/chadhietala/repos","events_url":"https://api.github.com/users/chadhietala/events{/privacy}","received_events_url":"https://api.github.com/users/chadhietala/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chadhietala/data","description":"A data persistence library for Ember.js.","fork":true,"url":"https://api.github.com/repos/chadhietala/data","forks_url":"https://api.github.com/repos/chadhietala/data/forks","keys_url":"https://api.github.com/repos/chadhietala/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chadhietala/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chadhietala/data/teams","hooks_url":"https://api.github.com/repos/chadhietala/data/hooks","issue_events_url":"https://api.github.com/repos/chadhietala/data/issues/events{/number}","events_url":"https://api.github.com/repos/chadhietala/data/events","assignees_url":"https://api.github.com/repos/chadhietala/data/assignees{/user}","branches_url":"https://api.github.com/repos/chadhietala/data/branches{/branch}","tags_url":"https://api.github.com/repos/chadhietala/data/tags","blobs_url":"https://api.github.com/repos/chadhietala/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chadhietala/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chadhietala/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/chadhietala/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chadhietala/data/statuses/{sha}","languages_url":"https://api.github.com/repos/chadhietala/data/languages","stargazers_url":"https://api.github.com/repos/chadhietala/data/stargazers","contributors_url":"https://api.github.com/repos/chadhietala/data/contributors","subscribers_url":"https://api.github.com/repos/chadhietala/data/subscribers","subscription_url":"https://api.github.com/repos/chadhietala/data/subscription","commits_url":"https://api.github.com/repos/chadhietala/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/chadhietala/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/chadhietala/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/chadhietala/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/chadhietala/data/contents/{+path}","compare_url":"https://api.github.com/repos/chadhietala/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chadhietala/data/merges","archive_url":"https://api.github.com/repos/chadhietala/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chadhietala/data/downloads","issues_url":"https://api.github.com/repos/chadhietala/data/issues{/number}","pulls_url":"https://api.github.com/repos/chadhietala/data/pulls{/number}","milestones_url":"https://api.github.com/repos/chadhietala/data/milestones{/number}","notifications_url":"https://api.github.com/repos/chadhietala/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chadhietala/data/labels{/name}","releases_url":"https://api.github.com/repos/chadhietala/data/releases{/id}","created_at":"2014-09-07T00:16:33Z","updated_at":"2014-09-05T13:48:20Z","pushed_at":"2015-12-12T04:34:04Z","git_url":"git://github.com/chadhietala/data.git","ssh_url":"git@github.com:chadhietala/data.git","clone_url":"https://github.com/chadhietala/data.git","svn_url":"https://github.com/chadhietala/data","homepage":"","size":10229,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"209326f22324d8e29eee0207908d02725f7cb83e","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":3016562,"name":"data","full_name":"emberjs/data","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/data","description":"A data persistence library for Ember.js.","fork":false,"url":"https://api.github.com/repos/emberjs/data","forks_url":"https://api.github.com/repos/emberjs/data/forks","keys_url":"https://api.github.com/repos/emberjs/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/data/teams","hooks_url":"https://api.github.com/repos/emberjs/data/hooks","issue_events_url":"https://api.github.com/repos/emberjs/data/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/data/events","assignees_url":"https://api.github.com/repos/emberjs/data/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/data/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/data/tags","blobs_url":"https://api.github.com/repos/emberjs/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/data/languages","stargazers_url":"https://api.github.com/repos/emberjs/data/stargazers","contributors_url":"https://api.github.com/repos/emberjs/data/contributors","subscribers_url":"https://api.github.com/repos/emberjs/data/subscribers","subscription_url":"https://api.github.com/repos/emberjs/data/subscription","commits_url":"https://api.github.com/repos/emberjs/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/data/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/data/merges","archive_url":"https://api.github.com/repos/emberjs/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/data/downloads","issues_url":"https://api.github.com/repos/emberjs/data/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/data/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/data/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/data/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/data/releases{/id}","created_at":"2011-12-20T01:50:40Z","updated_at":"2015-12-12T01:12:48Z","pushed_at":"2015-12-12T04:34:05Z","git_url":"git://github.com/emberjs/data.git","ssh_url":"git@github.com:emberjs/data.git","clone_url":"https://github.com/emberjs/data.git","svn_url":"https://github.com/emberjs/data","homepage":"","size":19326,"stargazers_count":2588,"watchers_count":2588,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1001,"mirror_url":null,"open_issues_count":258,"forks":1001,"open_issues":258,"watchers":2588,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/data/pulls/3988"},"html":{"href":"https://github.com/emberjs/data/pull/3988"},"issue":{"href":"https://api.github.com/repos/emberjs/data/issues/3988"},"comments":{"href":"https://api.github.com/repos/emberjs/data/issues/3988/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/data/pulls/3988/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/data/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/data/pulls/3988/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/data/statuses/268c2521e0e8e14bf0fd6dcf350a98249a9ab7df"}}}}