{"action":"created","issue":{"url":"https://api.github.com/repos/Particular/NServiceBus/issues/2726","labels_url":"https://api.github.com/repos/Particular/NServiceBus/issues/2726/labels{/name}","comments_url":"https://api.github.com/repos/Particular/NServiceBus/issues/2726/comments","events_url":"https://api.github.com/repos/Particular/NServiceBus/issues/2726/events","html_url":"https://github.com/Particular/NServiceBus/pull/2726","id":72509829,"number":2726,"title":"Cleaning up and covering the best practices with tests","user":{"login":"andreasohlund","id":125028,"avatar_url":"https://avatars.githubusercontent.com/u/125028?v=3","gravatar_id":"","url":"https://api.github.com/users/andreasohlund","html_url":"https://github.com/andreasohlund","followers_url":"https://api.github.com/users/andreasohlund/followers","following_url":"https://api.github.com/users/andreasohlund/following{/other_user}","gists_url":"https://api.github.com/users/andreasohlund/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasohlund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasohlund/subscriptions","organizations_url":"https://api.github.com/users/andreasohlund/orgs","repos_url":"https://api.github.com/users/andreasohlund/repos","events_url":"https://api.github.com/users/andreasohlund/events{/privacy}","received_events_url":"https://api.github.com/users/andreasohlund/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Particular/NServiceBus/labels/Improvement","name":"Improvement","color":"22BB88"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/Particular/NServiceBus/milestones/62","html_url":"https://github.com/Particular/NServiceBus/milestones/6.0.0","labels_url":"https://api.github.com/repos/Particular/NServiceBus/milestones/62/labels","id":704266,"number":62,"title":"6.0.0","description":"Setting up deployment process","creator":{"login":"SimonCropp","id":122666,"avatar_url":"https://avatars.githubusercontent.com/u/122666?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonCropp","html_url":"https://github.com/SimonCropp","followers_url":"https://api.github.com/users/SimonCropp/followers","following_url":"https://api.github.com/users/SimonCropp/following{/other_user}","gists_url":"https://api.github.com/users/SimonCropp/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonCropp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonCropp/subscriptions","organizations_url":"https://api.github.com/users/SimonCropp/orgs","repos_url":"https://api.github.com/users/SimonCropp/repos","events_url":"https://api.github.com/users/SimonCropp/events{/privacy}","received_events_url":"https://api.github.com/users/SimonCropp/received_events","type":"User","site_admin":false},"open_issues":25,"closed_issues":23,"state":"open","created_at":"2014-06-28T13:41:09Z","updated_at":"2015-05-03T16:49:49Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2015-05-01T19:59:54Z","updated_at":"2015-05-03T21:43:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Particular/NServiceBus/pulls/2726","html_url":"https://github.com/Particular/NServiceBus/pull/2726","diff_url":"https://github.com/Particular/NServiceBus/pull/2726.diff","patch_url":"https://github.com/Particular/NServiceBus/pull/2726.patch"},"body":"The checks for send only was removed:\r\n\r\nhttps://github.com/Particular/NServiceBus/commit/d858cadd319c4f27c019f88be9dfc355143ae5fa#diff-15cf998feca08db309a1930e0f7bbd3aL213\r\n\r\nsince users can't call subscribe/unsubscribe for send only endpoints since the `ISendOnlyBus` doesn't expose those calls\r\n\r\n\r\n### Documentation\r\n\r\nDocument how users can disable the best practices by disabling the feature like shown in the acceptance test"},"comment":{"url":"https://api.github.com/repos/Particular/NServiceBus/issues/comments/98547203","html_url":"https://github.com/Particular/NServiceBus/pull/2726#issuecomment-98547203","issue_url":"https://api.github.com/repos/Particular/NServiceBus/issues/2726","id":98547203,"user":{"login":"johnsimons","id":122651,"avatar_url":"https://avatars.githubusercontent.com/u/122651?v=3","gravatar_id":"","url":"https://api.github.com/users/johnsimons","html_url":"https://github.com/johnsimons","followers_url":"https://api.github.com/users/johnsimons/followers","following_url":"https://api.github.com/users/johnsimons/following{/other_user}","gists_url":"https://api.github.com/users/johnsimons/gists{/gist_id}","starred_url":"https://api.github.com/users/johnsimons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnsimons/subscriptions","organizations_url":"https://api.github.com/users/johnsimons/orgs","repos_url":"https://api.github.com/users/johnsimons/repos","events_url":"https://api.github.com/users/johnsimons/events{/privacy}","received_events_url":"https://api.github.com/users/johnsimons/received_events","type":"User","site_admin":false},"created_at":"2015-05-03T21:43:26Z","updated_at":"2015-05-03T21:43:26Z","body":"If I correctly understand this change, this means that we now have an endpoint instance toggle switch for `EnforceMessagingBestPractices`, so it is not a per message decision, was this the intended result @andreasohlund ?\r\n\r\nShouldn't it be a per message decision, one scenario that comes to mind is interop, or migrating from old to new ?\r\nAlso, I thought we needed this for the gateway `SendToSites` ?\r\n"}}