{"action":"created","comment":{"url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/comments/46764190","id":46764190,"diff_hunk":"@@ -117,6 +117,8 @@ type ssh_daemon_type = {\n     \"options\" ? ssh_daemon_options_type\n     \"comment_options\" ? ssh_daemon_options_type\n     \"sshd_path\" ? string\n+    # if true and sshd doesn't exist, will skip config validation","path":"ncm-ssh/src/main/pan/components/ssh/schema.pan","position":4,"original_position":4,"commit_id":"9981a380bfde76bb1da3b5ff258468d628637d99","original_commit_id":"9981a380bfde76bb1da3b5ff258468d628637d99","user":{"login":"ned21","id":278425,"avatar_url":"https://avatars.githubusercontent.com/u/278425?v=3","gravatar_id":"","url":"https://api.github.com/users/ned21","html_url":"https://github.com/ned21","followers_url":"https://api.github.com/users/ned21/followers","following_url":"https://api.github.com/users/ned21/following{/other_user}","gists_url":"https://api.github.com/users/ned21/gists{/gist_id}","starred_url":"https://api.github.com/users/ned21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ned21/subscriptions","organizations_url":"https://api.github.com/users/ned21/orgs","repos_url":"https://api.github.com/users/ned21/repos","events_url":"https://api.github.com/users/ned21/events{/privacy}","received_events_url":"https://api.github.com/users/ned21/received_events","type":"User","site_admin":false},"body":"The opposite of always is never but \"never != (not always)\".  Or to put it another way: always = false does not imply never.","created_at":"2015-12-05T22:49:50Z","updated_at":"2015-12-05T22:49:50Z","html_url":"https://github.com/quattor/configuration-modules-core/pull/645#discussion_r46764190","pull_request_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/645","_links":{"self":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/comments/46764190"},"html":{"href":"https://github.com/quattor/configuration-modules-core/pull/645#discussion_r46764190"},"pull_request":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/645"}}},"pull_request":{"url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/645","id":52676278,"html_url":"https://github.com/quattor/configuration-modules-core/pull/645","diff_url":"https://github.com/quattor/configuration-modules-core/pull/645.diff","patch_url":"https://github.com/quattor/configuration-modules-core/pull/645.patch","issue_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/645","number":645,"state":"open","locked":false,"title":"ncm-ssh: make config checks configurable.","user":{"login":"ajf8","id":1476635,"avatar_url":"https://avatars.githubusercontent.com/u/1476635?v=3","gravatar_id":"","url":"https://api.github.com/users/ajf8","html_url":"https://github.com/ajf8","followers_url":"https://api.github.com/users/ajf8/followers","following_url":"https://api.github.com/users/ajf8/following{/other_user}","gists_url":"https://api.github.com/users/ajf8/gists{/gist_id}","starred_url":"https://api.github.com/users/ajf8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajf8/subscriptions","organizations_url":"https://api.github.com/users/ajf8/orgs","repos_url":"https://api.github.com/users/ajf8/repos","events_url":"https://api.github.com/users/ajf8/events{/privacy}","received_events_url":"https://api.github.com/users/ajf8/received_events","type":"User","site_admin":false},"body":"small oversight on my part in the previous PR regarding this component during build time for us. sshd is on a network FS which isn't available at build time, so I've added a new param where you can make this check skip if sshd isn't existing.\r\n\r\nexisting behaviour, to always check, is still the default.","created_at":"2015-12-04T14:39:48Z","updated_at":"2015-12-05T22:49:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78f6c7630aaa416fe5e4dfbf14511cb5047444e8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/645/commits","review_comments_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/645/comments","review_comment_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/645/comments","statuses_url":"https://api.github.com/repos/quattor/configuration-modules-core/statuses/9981a380bfde76bb1da3b5ff258468d628637d99","head":{"label":"ajf8:ncm_ssh","ref":"ncm_ssh","sha":"9981a380bfde76bb1da3b5ff258468d628637d99","user":{"login":"ajf8","id":1476635,"avatar_url":"https://avatars.githubusercontent.com/u/1476635?v=3","gravatar_id":"","url":"https://api.github.com/users/ajf8","html_url":"https://github.com/ajf8","followers_url":"https://api.github.com/users/ajf8/followers","following_url":"https://api.github.com/users/ajf8/following{/other_user}","gists_url":"https://api.github.com/users/ajf8/gists{/gist_id}","starred_url":"https://api.github.com/users/ajf8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajf8/subscriptions","organizations_url":"https://api.github.com/users/ajf8/orgs","repos_url":"https://api.github.com/users/ajf8/repos","events_url":"https://api.github.com/users/ajf8/events{/privacy}","received_events_url":"https://api.github.com/users/ajf8/received_events","type":"User","site_admin":false},"repo":{"id":38760435,"name":"configuration-modules-core","full_name":"ajf8/configuration-modules-core","owner":{"login":"ajf8","id":1476635,"avatar_url":"https://avatars.githubusercontent.com/u/1476635?v=3","gravatar_id":"","url":"https://api.github.com/users/ajf8","html_url":"https://github.com/ajf8","followers_url":"https://api.github.com/users/ajf8/followers","following_url":"https://api.github.com/users/ajf8/following{/other_user}","gists_url":"https://api.github.com/users/ajf8/gists{/gist_id}","starred_url":"https://api.github.com/users/ajf8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajf8/subscriptions","organizations_url":"https://api.github.com/users/ajf8/orgs","repos_url":"https://api.github.com/users/ajf8/repos","events_url":"https://api.github.com/users/ajf8/events{/privacy}","received_events_url":"https://api.github.com/users/ajf8/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajf8/configuration-modules-core","description":"Node Configuration Manager Components for Everyone","fork":true,"url":"https://api.github.com/repos/ajf8/configuration-modules-core","forks_url":"https://api.github.com/repos/ajf8/configuration-modules-core/forks","keys_url":"https://api.github.com/repos/ajf8/configuration-modules-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajf8/configuration-modules-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajf8/configuration-modules-core/teams","hooks_url":"https://api.github.com/repos/ajf8/configuration-modules-core/hooks","issue_events_url":"https://api.github.com/repos/ajf8/configuration-modules-core/issues/events{/number}","events_url":"https://api.github.com/repos/ajf8/configuration-modules-core/events","assignees_url":"https://api.github.com/repos/ajf8/configuration-modules-core/assignees{/user}","branches_url":"https://api.github.com/repos/ajf8/configuration-modules-core/branches{/branch}","tags_url":"https://api.github.com/repos/ajf8/configuration-modules-core/tags","blobs_url":"https://api.github.com/repos/ajf8/configuration-modules-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajf8/configuration-modules-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajf8/configuration-modules-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajf8/configuration-modules-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajf8/configuration-modules-core/statuses/{sha}","languages_url":"https://api.github.com/repos/ajf8/configuration-modules-core/languages","stargazers_url":"https://api.github.com/repos/ajf8/configuration-modules-core/stargazers","contributors_url":"https://api.github.com/repos/ajf8/configuration-modules-core/contributors","subscribers_url":"https://api.github.com/repos/ajf8/configuration-modules-core/subscribers","subscription_url":"https://api.github.com/repos/ajf8/configuration-modules-core/subscription","commits_url":"https://api.github.com/repos/ajf8/configuration-modules-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajf8/configuration-modules-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajf8/configuration-modules-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajf8/configuration-modules-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajf8/configuration-modules-core/contents/{+path}","compare_url":"https://api.github.com/repos/ajf8/configuration-modules-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajf8/configuration-modules-core/merges","archive_url":"https://api.github.com/repos/ajf8/configuration-modules-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajf8/configuration-modules-core/downloads","issues_url":"https://api.github.com/repos/ajf8/configuration-modules-core/issues{/number}","pulls_url":"https://api.github.com/repos/ajf8/configuration-modules-core/pulls{/number}","milestones_url":"https://api.github.com/repos/ajf8/configuration-modules-core/milestones{/number}","notifications_url":"https://api.github.com/repos/ajf8/configuration-modules-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajf8/configuration-modules-core/labels{/name}","releases_url":"https://api.github.com/repos/ajf8/configuration-modules-core/releases{/id}","created_at":"2015-07-08T14:48:23Z","updated_at":"2015-07-08T14:48:26Z","pushed_at":"2015-12-04T18:00:31Z","git_url":"git://github.com/ajf8/configuration-modules-core.git","ssh_url":"git@github.com:ajf8/configuration-modules-core.git","clone_url":"https://github.com/ajf8/configuration-modules-core.git","svn_url":"https://github.com/ajf8/configuration-modules-core","homepage":"www.quattor.org","size":9587,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"quattor:master","ref":"master","sha":"06b82ad5b2d25c7fb4ffc3d7b7b5aea6435bf35f","user":{"login":"quattor","id":1557169,"avatar_url":"https://avatars.githubusercontent.com/u/1557169?v=3","gravatar_id":"","url":"https://api.github.com/users/quattor","html_url":"https://github.com/quattor","followers_url":"https://api.github.com/users/quattor/followers","following_url":"https://api.github.com/users/quattor/following{/other_user}","gists_url":"https://api.github.com/users/quattor/gists{/gist_id}","starred_url":"https://api.github.com/users/quattor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quattor/subscriptions","organizations_url":"https://api.github.com/users/quattor/orgs","repos_url":"https://api.github.com/users/quattor/repos","events_url":"https://api.github.com/users/quattor/events{/privacy}","received_events_url":"https://api.github.com/users/quattor/received_events","type":"Organization","site_admin":false},"repo":{"id":6471233,"name":"configuration-modules-core","full_name":"quattor/configuration-modules-core","owner":{"login":"quattor","id":1557169,"avatar_url":"https://avatars.githubusercontent.com/u/1557169?v=3","gravatar_id":"","url":"https://api.github.com/users/quattor","html_url":"https://github.com/quattor","followers_url":"https://api.github.com/users/quattor/followers","following_url":"https://api.github.com/users/quattor/following{/other_user}","gists_url":"https://api.github.com/users/quattor/gists{/gist_id}","starred_url":"https://api.github.com/users/quattor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quattor/subscriptions","organizations_url":"https://api.github.com/users/quattor/orgs","repos_url":"https://api.github.com/users/quattor/repos","events_url":"https://api.github.com/users/quattor/events{/privacy}","received_events_url":"https://api.github.com/users/quattor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quattor/configuration-modules-core","description":"Node Configuration Manager Components for Everyone","fork":false,"url":"https://api.github.com/repos/quattor/configuration-modules-core","forks_url":"https://api.github.com/repos/quattor/configuration-modules-core/forks","keys_url":"https://api.github.com/repos/quattor/configuration-modules-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quattor/configuration-modules-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quattor/configuration-modules-core/teams","hooks_url":"https://api.github.com/repos/quattor/configuration-modules-core/hooks","issue_events_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/events{/number}","events_url":"https://api.github.com/repos/quattor/configuration-modules-core/events","assignees_url":"https://api.github.com/repos/quattor/configuration-modules-core/assignees{/user}","branches_url":"https://api.github.com/repos/quattor/configuration-modules-core/branches{/branch}","tags_url":"https://api.github.com/repos/quattor/configuration-modules-core/tags","blobs_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quattor/configuration-modules-core/statuses/{sha}","languages_url":"https://api.github.com/repos/quattor/configuration-modules-core/languages","stargazers_url":"https://api.github.com/repos/quattor/configuration-modules-core/stargazers","contributors_url":"https://api.github.com/repos/quattor/configuration-modules-core/contributors","subscribers_url":"https://api.github.com/repos/quattor/configuration-modules-core/subscribers","subscription_url":"https://api.github.com/repos/quattor/configuration-modules-core/subscription","commits_url":"https://api.github.com/repos/quattor/configuration-modules-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/quattor/configuration-modules-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/quattor/configuration-modules-core/contents/{+path}","compare_url":"https://api.github.com/repos/quattor/configuration-modules-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quattor/configuration-modules-core/merges","archive_url":"https://api.github.com/repos/quattor/configuration-modules-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quattor/configuration-modules-core/downloads","issues_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues{/number}","pulls_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls{/number}","milestones_url":"https://api.github.com/repos/quattor/configuration-modules-core/milestones{/number}","notifications_url":"https://api.github.com/repos/quattor/configuration-modules-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quattor/configuration-modules-core/labels{/name}","releases_url":"https://api.github.com/repos/quattor/configuration-modules-core/releases{/id}","created_at":"2012-10-31T09:08:07Z","updated_at":"2015-11-03T16:59:18Z","pushed_at":"2015-12-04T18:00:32Z","git_url":"git://github.com/quattor/configuration-modules-core.git","ssh_url":"git@github.com:quattor/configuration-modules-core.git","clone_url":"https://github.com/quattor/configuration-modules-core.git","svn_url":"https://github.com/quattor/configuration-modules-core","homepage":"www.quattor.org","size":10057,"stargazers_count":7,"watchers_count":7,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":86,"forks":31,"open_issues":86,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/645"},"html":{"href":"https://github.com/quattor/configuration-modules-core/pull/645"},"issue":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/issues/645"},"comments":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/issues/645/comments"},"review_comments":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/645/comments"},"review_comment":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/645/commits"},"statuses":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/statuses/9981a380bfde76bb1da3b5ff258468d628637d99"}}}}