{"action":"created","issue":{"url":"https://api.github.com/repos/coreos/flannel/issues/380","labels_url":"https://api.github.com/repos/coreos/flannel/issues/380/labels{/name}","comments_url":"https://api.github.com/repos/coreos/flannel/issues/380/comments","events_url":"https://api.github.com/repos/coreos/flannel/issues/380/events","html_url":"https://github.com/coreos/flannel/pull/380","id":119599107,"number":380,"title":"Add mock etcd and etcd-backed registry testcases","user":{"login":"dcbw","id":10926354,"avatar_url":"https://avatars.githubusercontent.com/u/10926354?v=3","gravatar_id":"","url":"https://api.github.com/users/dcbw","html_url":"https://github.com/dcbw","followers_url":"https://api.github.com/users/dcbw/followers","following_url":"https://api.github.com/users/dcbw/following{/other_user}","gists_url":"https://api.github.com/users/dcbw/gists{/gist_id}","starred_url":"https://api.github.com/users/dcbw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcbw/subscriptions","organizations_url":"https://api.github.com/users/dcbw/orgs","repos_url":"https://api.github.com/users/dcbw/repos","events_url":"https://api.github.com/users/dcbw/events{/privacy}","received_events_url":"https://api.github.com/users/dcbw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-11-30T22:48:27Z","updated_at":"2015-12-01T22:12:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/coreos/flannel/pulls/380","html_url":"https://github.com/coreos/flannel/pull/380","diff_url":"https://github.com/coreos/flannel/pull/380.diff","patch_url":"https://github.com/coreos/flannel/pull/380.patch"},"body":"Main motivation here was making sure that the \"subnet\" and \"network\" don't get switched around in registry.go any more.  I chose to re-implement a mock etcd since I wasn't sure if flannel testing could necessarily spin up its own etcd on all configurations."},"comment":{"url":"https://api.github.com/repos/coreos/flannel/issues/comments/161111740","html_url":"https://github.com/coreos/flannel/pull/380#issuecomment-161111740","issue_url":"https://api.github.com/repos/coreos/flannel/issues/380","id":161111740,"user":{"login":"xiang90","id":4479947,"avatar_url":"https://avatars.githubusercontent.com/u/4479947?v=3","gravatar_id":"","url":"https://api.github.com/users/xiang90","html_url":"https://github.com/xiang90","followers_url":"https://api.github.com/users/xiang90/followers","following_url":"https://api.github.com/users/xiang90/following{/other_user}","gists_url":"https://api.github.com/users/xiang90/gists{/gist_id}","starred_url":"https://api.github.com/users/xiang90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiang90/subscriptions","organizations_url":"https://api.github.com/users/xiang90/orgs","repos_url":"https://api.github.com/users/xiang90/repos","events_url":"https://api.github.com/users/xiang90/events{/privacy}","received_events_url":"https://api.github.com/users/xiang90/received_events","type":"User","site_admin":false},"created_at":"2015-12-01T22:12:00Z","updated_at":"2015-12-01T22:12:00Z","body":"@eyakubovich @dcbw \r\n\r\nCan we simply embed etcd for testing? I do not think we need to mock etcd. \r\n\r\nAnother simpler solution I can see is to mock the registry instead of etcd.\r\n"}}