{"action":"created","comment":{"url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/pulls/comments/28064334","id":28064334,"diff_hunk":"@@ -67,10 +67,13 @@ def build_in_sandbox(platform)\n \n         sandbox = install_pod(platform.name)\n \n-        perform_build(platform, sandbox)","path":"lib/pod/command/package.rb","position":4,"original_position":4,"commit_id":"a28881e62335d4e0b9f27906e3019bcb477e10f4","original_commit_id":"a28881e62335d4e0b9f27906e3019bcb477e10f4","user":{"login":"michaelmelanson","id":1318,"avatar_url":"https://avatars.githubusercontent.com/u/1318?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelmelanson","html_url":"https://github.com/michaelmelanson","followers_url":"https://api.github.com/users/michaelmelanson/followers","following_url":"https://api.github.com/users/michaelmelanson/following{/other_user}","gists_url":"https://api.github.com/users/michaelmelanson/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelmelanson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelmelanson/subscriptions","organizations_url":"https://api.github.com/users/michaelmelanson/orgs","repos_url":"https://api.github.com/users/michaelmelanson/repos","events_url":"https://api.github.com/users/michaelmelanson/events{/privacy}","received_events_url":"https://api.github.com/users/michaelmelanson/received_events","type":"User","site_admin":false},"body":"Correct me if I'm wrong here, but don't we need to wrap lines 74-75 in an `ensure` block so that they're cleaned up even if the build fails?","created_at":"2015-04-09T14:12:00Z","updated_at":"2015-04-09T14:12:00Z","html_url":"https://github.com/CocoaPods/cocoapods-packager/pull/74#discussion_r28064334","pull_request_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/pulls/74","_links":{"self":{"href":"https://api.github.com/repos/CocoaPods/cocoapods-packager/pulls/comments/28064334"},"html":{"href":"https://github.com/CocoaPods/cocoapods-packager/pull/74#discussion_r28064334"},"pull_request":{"href":"https://api.github.com/repos/CocoaPods/cocoapods-packager/pulls/74"}}},"pull_request":{"url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/pulls/74","id":32896587,"html_url":"https://github.com/CocoaPods/cocoapods-packager/pull/74","diff_url":"https://github.com/CocoaPods/cocoapods-packager/pull/74.diff","patch_url":"https://github.com/CocoaPods/cocoapods-packager/pull/74.patch","issue_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/issues/74","number":74,"state":"open","locked":false,"title":"Catch build errors during `pod package`.","user":{"login":"michaelmelanson","id":1318,"avatar_url":"https://avatars.githubusercontent.com/u/1318?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelmelanson","html_url":"https://github.com/michaelmelanson","followers_url":"https://api.github.com/users/michaelmelanson/followers","following_url":"https://api.github.com/users/michaelmelanson/following{/other_user}","gists_url":"https://api.github.com/users/michaelmelanson/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelmelanson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelmelanson/subscriptions","organizations_url":"https://api.github.com/users/michaelmelanson/orgs","repos_url":"https://api.github.com/users/michaelmelanson/repos","events_url":"https://api.github.com/users/michaelmelanson/events{/privacy}","received_events_url":"https://api.github.com/users/michaelmelanson/received_events","type":"User","site_admin":false},"body":"This pull request fixes #47 by throwing an exception when `xcodebuild` commands fail.\r\n\r\nThere's no automated tests accompanying this, but the surrounding code is also untested. I'm open to suggestions about the best way to approach adding tests.","created_at":"2015-04-08T20:05:56Z","updated_at":"2015-04-09T14:12:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06f2eff65b2190c5737af32788f99a55a51d2f56","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/pulls/74/commits","review_comments_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/pulls/74/comments","review_comment_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/issues/74/comments","statuses_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/statuses/a28881e62335d4e0b9f27906e3019bcb477e10f4","head":{"label":"toushay:bugfix/47","ref":"bugfix/47","sha":"a28881e62335d4e0b9f27906e3019bcb477e10f4","user":{"login":"toushay","id":462923,"avatar_url":"https://avatars.githubusercontent.com/u/462923?v=3","gravatar_id":"","url":"https://api.github.com/users/toushay","html_url":"https://github.com/toushay","followers_url":"https://api.github.com/users/toushay/followers","following_url":"https://api.github.com/users/toushay/following{/other_user}","gists_url":"https://api.github.com/users/toushay/gists{/gist_id}","starred_url":"https://api.github.com/users/toushay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toushay/subscriptions","organizations_url":"https://api.github.com/users/toushay/orgs","repos_url":"https://api.github.com/users/toushay/repos","events_url":"https://api.github.com/users/toushay/events{/privacy}","received_events_url":"https://api.github.com/users/toushay/received_events","type":"Organization","site_admin":false},"repo":{"id":33616284,"name":"cocoapods-packager","full_name":"toushay/cocoapods-packager","owner":{"login":"toushay","id":462923,"avatar_url":"https://avatars.githubusercontent.com/u/462923?v=3","gravatar_id":"","url":"https://api.github.com/users/toushay","html_url":"https://github.com/toushay","followers_url":"https://api.github.com/users/toushay/followers","following_url":"https://api.github.com/users/toushay/following{/other_user}","gists_url":"https://api.github.com/users/toushay/gists{/gist_id}","starred_url":"https://api.github.com/users/toushay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toushay/subscriptions","organizations_url":"https://api.github.com/users/toushay/orgs","repos_url":"https://api.github.com/users/toushay/repos","events_url":"https://api.github.com/users/toushay/events{/privacy}","received_events_url":"https://api.github.com/users/toushay/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/toushay/cocoapods-packager","description":"CocoaPods plugin which allows you to generate a static library from a podspec.","fork":true,"url":"https://api.github.com/repos/toushay/cocoapods-packager","forks_url":"https://api.github.com/repos/toushay/cocoapods-packager/forks","keys_url":"https://api.github.com/repos/toushay/cocoapods-packager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toushay/cocoapods-packager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toushay/cocoapods-packager/teams","hooks_url":"https://api.github.com/repos/toushay/cocoapods-packager/hooks","issue_events_url":"https://api.github.com/repos/toushay/cocoapods-packager/issues/events{/number}","events_url":"https://api.github.com/repos/toushay/cocoapods-packager/events","assignees_url":"https://api.github.com/repos/toushay/cocoapods-packager/assignees{/user}","branches_url":"https://api.github.com/repos/toushay/cocoapods-packager/branches{/branch}","tags_url":"https://api.github.com/repos/toushay/cocoapods-packager/tags","blobs_url":"https://api.github.com/repos/toushay/cocoapods-packager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toushay/cocoapods-packager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toushay/cocoapods-packager/git/refs{/sha}","trees_url":"https://api.github.com/repos/toushay/cocoapods-packager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toushay/cocoapods-packager/statuses/{sha}","languages_url":"https://api.github.com/repos/toushay/cocoapods-packager/languages","stargazers_url":"https://api.github.com/repos/toushay/cocoapods-packager/stargazers","contributors_url":"https://api.github.com/repos/toushay/cocoapods-packager/contributors","subscribers_url":"https://api.github.com/repos/toushay/cocoapods-packager/subscribers","subscription_url":"https://api.github.com/repos/toushay/cocoapods-packager/subscription","commits_url":"https://api.github.com/repos/toushay/cocoapods-packager/commits{/sha}","git_commits_url":"https://api.github.com/repos/toushay/cocoapods-packager/git/commits{/sha}","comments_url":"https://api.github.com/repos/toushay/cocoapods-packager/comments{/number}","issue_comment_url":"https://api.github.com/repos/toushay/cocoapods-packager/issues/comments{/number}","contents_url":"https://api.github.com/repos/toushay/cocoapods-packager/contents/{+path}","compare_url":"https://api.github.com/repos/toushay/cocoapods-packager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toushay/cocoapods-packager/merges","archive_url":"https://api.github.com/repos/toushay/cocoapods-packager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toushay/cocoapods-packager/downloads","issues_url":"https://api.github.com/repos/toushay/cocoapods-packager/issues{/number}","pulls_url":"https://api.github.com/repos/toushay/cocoapods-packager/pulls{/number}","milestones_url":"https://api.github.com/repos/toushay/cocoapods-packager/milestones{/number}","notifications_url":"https://api.github.com/repos/toushay/cocoapods-packager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toushay/cocoapods-packager/labels{/name}","releases_url":"https://api.github.com/repos/toushay/cocoapods-packager/releases{/id}","created_at":"2015-04-08T15:43:33Z","updated_at":"2015-04-08T17:51:43Z","pushed_at":"2015-04-09T13:49:00Z","git_url":"git://github.com/toushay/cocoapods-packager.git","ssh_url":"git@github.com:toushay/cocoapods-packager.git","clone_url":"https://github.com/toushay/cocoapods-packager.git","svn_url":"https://github.com/toushay/cocoapods-packager","homepage":null,"size":236,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CocoaPods:master","ref":"master","sha":"85eb7b5ae7b698ab2ccd7a86ebbaf7fe7c26fa0a","user":{"login":"CocoaPods","id":1189714,"avatar_url":"https://avatars.githubusercontent.com/u/1189714?v=3","gravatar_id":"","url":"https://api.github.com/users/CocoaPods","html_url":"https://github.com/CocoaPods","followers_url":"https://api.github.com/users/CocoaPods/followers","following_url":"https://api.github.com/users/CocoaPods/following{/other_user}","gists_url":"https://api.github.com/users/CocoaPods/gists{/gist_id}","starred_url":"https://api.github.com/users/CocoaPods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CocoaPods/subscriptions","organizations_url":"https://api.github.com/users/CocoaPods/orgs","repos_url":"https://api.github.com/users/CocoaPods/repos","events_url":"https://api.github.com/users/CocoaPods/events{/privacy}","received_events_url":"https://api.github.com/users/CocoaPods/received_events","type":"Organization","site_admin":false},"repo":{"id":17838583,"name":"cocoapods-packager","full_name":"CocoaPods/cocoapods-packager","owner":{"login":"CocoaPods","id":1189714,"avatar_url":"https://avatars.githubusercontent.com/u/1189714?v=3","gravatar_id":"","url":"https://api.github.com/users/CocoaPods","html_url":"https://github.com/CocoaPods","followers_url":"https://api.github.com/users/CocoaPods/followers","following_url":"https://api.github.com/users/CocoaPods/following{/other_user}","gists_url":"https://api.github.com/users/CocoaPods/gists{/gist_id}","starred_url":"https://api.github.com/users/CocoaPods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CocoaPods/subscriptions","organizations_url":"https://api.github.com/users/CocoaPods/orgs","repos_url":"https://api.github.com/users/CocoaPods/repos","events_url":"https://api.github.com/users/CocoaPods/events{/privacy}","received_events_url":"https://api.github.com/users/CocoaPods/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CocoaPods/cocoapods-packager","description":"CocoaPods plugin which allows you to generate a static library from a podspec.","fork":false,"url":"https://api.github.com/repos/CocoaPods/cocoapods-packager","forks_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/forks","keys_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/teams","hooks_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/hooks","issue_events_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/issues/events{/number}","events_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/events","assignees_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/assignees{/user}","branches_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/branches{/branch}","tags_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/tags","blobs_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/git/refs{/sha}","trees_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/statuses/{sha}","languages_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/languages","stargazers_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/stargazers","contributors_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/contributors","subscribers_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/subscribers","subscription_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/subscription","commits_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/commits{/sha}","git_commits_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/git/commits{/sha}","comments_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/comments{/number}","issue_comment_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/issues/comments{/number}","contents_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/contents/{+path}","compare_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/merges","archive_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/downloads","issues_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/issues{/number}","pulls_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/pulls{/number}","milestones_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/milestones{/number}","notifications_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/labels{/name}","releases_url":"https://api.github.com/repos/CocoaPods/cocoapods-packager/releases{/id}","created_at":"2014-03-17T18:23:25Z","updated_at":"2015-04-08T17:05:30Z","pushed_at":"2015-04-09T13:49:01Z","git_url":"git://github.com/CocoaPods/cocoapods-packager.git","ssh_url":"git@github.com:CocoaPods/cocoapods-packager.git","clone_url":"https://github.com/CocoaPods/cocoapods-packager.git","svn_url":"https://github.com/CocoaPods/cocoapods-packager","homepage":null,"size":819,"stargazers_count":135,"watchers_count":135,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":20,"forks":17,"open_issues":20,"watchers":135,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CocoaPods/cocoapods-packager/pulls/74"},"html":{"href":"https://github.com/CocoaPods/cocoapods-packager/pull/74"},"issue":{"href":"https://api.github.com/repos/CocoaPods/cocoapods-packager/issues/74"},"comments":{"href":"https://api.github.com/repos/CocoaPods/cocoapods-packager/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/CocoaPods/cocoapods-packager/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/CocoaPods/cocoapods-packager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CocoaPods/cocoapods-packager/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/CocoaPods/cocoapods-packager/statuses/a28881e62335d4e0b9f27906e3019bcb477e10f4"}}}}