{"action":"created","comment":{"url":"https://api.github.com/repos/diaspora/diaspora/pulls/comments/31882636","id":31882636,"diff_hunk":"@@ -9,30 +9,28 @@ def initialize(user, opts={})\n     @user_person = @user.person\n     @salmon_xml = opts[:salmon_xml]\n \n-    @sender = opts[:person] || Webfinger.new(self.salmon.author_id).fetch\n-    @author = @sender\n+    @author = opts[:person] || Webfinger.new(self.salmon.author_id).fetch\n \n     @object = opts[:object]\n   end\n \n   def receive!\n-    if @sender && self.salmon.verified_for_key?(@sender.public_key)\n+    if @author && self.salmon.verified_for_key?(@author.public_key)","path":"lib/postzord/receiver/private.rb","position":13,"original_position":13,"commit_id":"8147a5ada8c12a2b3aaa0be21ec9484be83cc33f","original_commit_id":"8147a5ada8c12a2b3aaa0be21ec9484be83cc33f","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Redundant `self` detected.","created_at":"2015-06-08T00:16:36Z","updated_at":"2015-06-08T00:16:36Z","html_url":"https://github.com/diaspora/diaspora/pull/6082#discussion_r31882636","pull_request_url":"https://api.github.com/repos/diaspora/diaspora/pulls/6082","_links":{"self":{"href":"https://api.github.com/repos/diaspora/diaspora/pulls/comments/31882636"},"html":{"href":"https://github.com/diaspora/diaspora/pull/6082#discussion_r31882636"},"pull_request":{"href":"https://api.github.com/repos/diaspora/diaspora/pulls/6082"}}},"pull_request":{"url":"https://api.github.com/repos/diaspora/diaspora/pulls/6082","id":37116046,"html_url":"https://github.com/diaspora/diaspora/pull/6082","diff_url":"https://github.com/diaspora/diaspora/pull/6082.diff","patch_url":"https://github.com/diaspora/diaspora/pull/6082.patch","issue_url":"https://api.github.com/repos/diaspora/diaspora/issues/6082","number":6082,"state":"open","locked":false,"title":"Fix public photo federation","user":{"login":"SuperTux88","id":458548,"avatar_url":"https://avatars.githubusercontent.com/u/458548?v=3","gravatar_id":"","url":"https://api.github.com/users/SuperTux88","html_url":"https://github.com/SuperTux88","followers_url":"https://api.github.com/users/SuperTux88/followers","following_url":"https://api.github.com/users/SuperTux88/following{/other_user}","gists_url":"https://api.github.com/users/SuperTux88/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperTux88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperTux88/subscriptions","organizations_url":"https://api.github.com/users/SuperTux88/orgs","repos_url":"https://api.github.com/users/SuperTux88/repos","events_url":"https://api.github.com/users/SuperTux88/events{/privacy}","received_events_url":"https://api.github.com/users/SuperTux88/received_events","type":"User","site_admin":false},"body":"photos are mutable -> update when receive existing photo\r\n\r\nalso cleanup the database and set public-flags for existing photos: 20150607143809 FixPhotoPublicFlag: migrated (4.2623s) (nerdpol.ch database)\r\n\r\nrefactoring:\r\n- add XMLLogger to debug federation\r\n- don't dispatch the photos twice, they are dispatched in the after_dispatch of the status message\r\n- rewrite public receiver, to work more like the private receiver","created_at":"2015-06-08T00:16:27Z","updated_at":"2015-06-08T00:16:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca5720c4b9c0eef6ad648b89010b329a1a1de987","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/diaspora/diaspora/pulls/6082/commits","review_comments_url":"https://api.github.com/repos/diaspora/diaspora/pulls/6082/comments","review_comment_url":"https://api.github.com/repos/diaspora/diaspora/pulls/comments{/number}","comments_url":"https://api.github.com/repos/diaspora/diaspora/issues/6082/comments","statuses_url":"https://api.github.com/repos/diaspora/diaspora/statuses/8147a5ada8c12a2b3aaa0be21ec9484be83cc33f","head":{"label":"SuperTux88:fix-public-photo-federation","ref":"fix-public-photo-federation","sha":"8147a5ada8c12a2b3aaa0be21ec9484be83cc33f","user":{"login":"SuperTux88","id":458548,"avatar_url":"https://avatars.githubusercontent.com/u/458548?v=3","gravatar_id":"","url":"https://api.github.com/users/SuperTux88","html_url":"https://github.com/SuperTux88","followers_url":"https://api.github.com/users/SuperTux88/followers","following_url":"https://api.github.com/users/SuperTux88/following{/other_user}","gists_url":"https://api.github.com/users/SuperTux88/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperTux88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperTux88/subscriptions","organizations_url":"https://api.github.com/users/SuperTux88/orgs","repos_url":"https://api.github.com/users/SuperTux88/repos","events_url":"https://api.github.com/users/SuperTux88/events{/privacy}","received_events_url":"https://api.github.com/users/SuperTux88/received_events","type":"User","site_admin":false},"repo":{"id":2855437,"name":"diaspora","full_name":"SuperTux88/diaspora","owner":{"login":"SuperTux88","id":458548,"avatar_url":"https://avatars.githubusercontent.com/u/458548?v=3","gravatar_id":"","url":"https://api.github.com/users/SuperTux88","html_url":"https://github.com/SuperTux88","followers_url":"https://api.github.com/users/SuperTux88/followers","following_url":"https://api.github.com/users/SuperTux88/following{/other_user}","gists_url":"https://api.github.com/users/SuperTux88/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperTux88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperTux88/subscriptions","organizations_url":"https://api.github.com/users/SuperTux88/orgs","repos_url":"https://api.github.com/users/SuperTux88/repos","events_url":"https://api.github.com/users/SuperTux88/events{/privacy}","received_events_url":"https://api.github.com/users/SuperTux88/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SuperTux88/diaspora","description":"Distributed and contextual social networking","fork":true,"url":"https://api.github.com/repos/SuperTux88/diaspora","forks_url":"https://api.github.com/repos/SuperTux88/diaspora/forks","keys_url":"https://api.github.com/repos/SuperTux88/diaspora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SuperTux88/diaspora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SuperTux88/diaspora/teams","hooks_url":"https://api.github.com/repos/SuperTux88/diaspora/hooks","issue_events_url":"https://api.github.com/repos/SuperTux88/diaspora/issues/events{/number}","events_url":"https://api.github.com/repos/SuperTux88/diaspora/events","assignees_url":"https://api.github.com/repos/SuperTux88/diaspora/assignees{/user}","branches_url":"https://api.github.com/repos/SuperTux88/diaspora/branches{/branch}","tags_url":"https://api.github.com/repos/SuperTux88/diaspora/tags","blobs_url":"https://api.github.com/repos/SuperTux88/diaspora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SuperTux88/diaspora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SuperTux88/diaspora/git/refs{/sha}","trees_url":"https://api.github.com/repos/SuperTux88/diaspora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SuperTux88/diaspora/statuses/{sha}","languages_url":"https://api.github.com/repos/SuperTux88/diaspora/languages","stargazers_url":"https://api.github.com/repos/SuperTux88/diaspora/stargazers","contributors_url":"https://api.github.com/repos/SuperTux88/diaspora/contributors","subscribers_url":"https://api.github.com/repos/SuperTux88/diaspora/subscribers","subscription_url":"https://api.github.com/repos/SuperTux88/diaspora/subscription","commits_url":"https://api.github.com/repos/SuperTux88/diaspora/commits{/sha}","git_commits_url":"https://api.github.com/repos/SuperTux88/diaspora/git/commits{/sha}","comments_url":"https://api.github.com/repos/SuperTux88/diaspora/comments{/number}","issue_comment_url":"https://api.github.com/repos/SuperTux88/diaspora/issues/comments{/number}","contents_url":"https://api.github.com/repos/SuperTux88/diaspora/contents/{+path}","compare_url":"https://api.github.com/repos/SuperTux88/diaspora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SuperTux88/diaspora/merges","archive_url":"https://api.github.com/repos/SuperTux88/diaspora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SuperTux88/diaspora/downloads","issues_url":"https://api.github.com/repos/SuperTux88/diaspora/issues{/number}","pulls_url":"https://api.github.com/repos/SuperTux88/diaspora/pulls{/number}","milestones_url":"https://api.github.com/repos/SuperTux88/diaspora/milestones{/number}","notifications_url":"https://api.github.com/repos/SuperTux88/diaspora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SuperTux88/diaspora/labels{/name}","releases_url":"https://api.github.com/repos/SuperTux88/diaspora/releases{/id}","created_at":"2011-11-26T12:26:27Z","updated_at":"2015-06-05T05:31:49Z","pushed_at":"2015-06-07T23:51:53Z","git_url":"git://github.com/SuperTux88/diaspora.git","ssh_url":"git@github.com:SuperTux88/diaspora.git","clone_url":"https://github.com/SuperTux88/diaspora.git","svn_url":"https://github.com/SuperTux88/diaspora","homepage":"diasporafoundation.org/get_involved","size":102804,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":3,"default_branch":"nerdpol_ch"}},"base":{"label":"diaspora:develop","ref":"develop","sha":"67de83f325d7126334f1a1260980ea5e4d140ced","user":{"login":"diaspora","id":293207,"avatar_url":"https://avatars.githubusercontent.com/u/293207?v=3","gravatar_id":"","url":"https://api.github.com/users/diaspora","html_url":"https://github.com/diaspora","followers_url":"https://api.github.com/users/diaspora/followers","following_url":"https://api.github.com/users/diaspora/following{/other_user}","gists_url":"https://api.github.com/users/diaspora/gists{/gist_id}","starred_url":"https://api.github.com/users/diaspora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diaspora/subscriptions","organizations_url":"https://api.github.com/users/diaspora/orgs","repos_url":"https://api.github.com/users/diaspora/repos","events_url":"https://api.github.com/users/diaspora/events{/privacy}","received_events_url":"https://api.github.com/users/diaspora/received_events","type":"Organization","site_admin":false},"repo":{"id":911765,"name":"diaspora","full_name":"diaspora/diaspora","owner":{"login":"diaspora","id":293207,"avatar_url":"https://avatars.githubusercontent.com/u/293207?v=3","gravatar_id":"","url":"https://api.github.com/users/diaspora","html_url":"https://github.com/diaspora","followers_url":"https://api.github.com/users/diaspora/followers","following_url":"https://api.github.com/users/diaspora/following{/other_user}","gists_url":"https://api.github.com/users/diaspora/gists{/gist_id}","starred_url":"https://api.github.com/users/diaspora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diaspora/subscriptions","organizations_url":"https://api.github.com/users/diaspora/orgs","repos_url":"https://api.github.com/users/diaspora/repos","events_url":"https://api.github.com/users/diaspora/events{/privacy}","received_events_url":"https://api.github.com/users/diaspora/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/diaspora/diaspora","description":"Distributed and contextual social networking","fork":false,"url":"https://api.github.com/repos/diaspora/diaspora","forks_url":"https://api.github.com/repos/diaspora/diaspora/forks","keys_url":"https://api.github.com/repos/diaspora/diaspora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diaspora/diaspora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diaspora/diaspora/teams","hooks_url":"https://api.github.com/repos/diaspora/diaspora/hooks","issue_events_url":"https://api.github.com/repos/diaspora/diaspora/issues/events{/number}","events_url":"https://api.github.com/repos/diaspora/diaspora/events","assignees_url":"https://api.github.com/repos/diaspora/diaspora/assignees{/user}","branches_url":"https://api.github.com/repos/diaspora/diaspora/branches{/branch}","tags_url":"https://api.github.com/repos/diaspora/diaspora/tags","blobs_url":"https://api.github.com/repos/diaspora/diaspora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diaspora/diaspora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diaspora/diaspora/git/refs{/sha}","trees_url":"https://api.github.com/repos/diaspora/diaspora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diaspora/diaspora/statuses/{sha}","languages_url":"https://api.github.com/repos/diaspora/diaspora/languages","stargazers_url":"https://api.github.com/repos/diaspora/diaspora/stargazers","contributors_url":"https://api.github.com/repos/diaspora/diaspora/contributors","subscribers_url":"https://api.github.com/repos/diaspora/diaspora/subscribers","subscription_url":"https://api.github.com/repos/diaspora/diaspora/subscription","commits_url":"https://api.github.com/repos/diaspora/diaspora/commits{/sha}","git_commits_url":"https://api.github.com/repos/diaspora/diaspora/git/commits{/sha}","comments_url":"https://api.github.com/repos/diaspora/diaspora/comments{/number}","issue_comment_url":"https://api.github.com/repos/diaspora/diaspora/issues/comments{/number}","contents_url":"https://api.github.com/repos/diaspora/diaspora/contents/{+path}","compare_url":"https://api.github.com/repos/diaspora/diaspora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diaspora/diaspora/merges","archive_url":"https://api.github.com/repos/diaspora/diaspora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diaspora/diaspora/downloads","issues_url":"https://api.github.com/repos/diaspora/diaspora/issues{/number}","pulls_url":"https://api.github.com/repos/diaspora/diaspora/pulls{/number}","milestones_url":"https://api.github.com/repos/diaspora/diaspora/milestones{/number}","notifications_url":"https://api.github.com/repos/diaspora/diaspora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diaspora/diaspora/labels{/name}","releases_url":"https://api.github.com/repos/diaspora/diaspora/releases{/id}","created_at":"2010-09-15T05:20:04Z","updated_at":"2015-06-07T19:35:57Z","pushed_at":"2015-06-08T00:16:27Z","git_url":"git://github.com/diaspora/diaspora.git","ssh_url":"git@github.com:diaspora/diaspora.git","clone_url":"https://github.com/diaspora/diaspora.git","svn_url":"https://github.com/diaspora/diaspora","homepage":"https://diasporafoundation.org/","size":252323,"stargazers_count":10086,"watchers_count":10086,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2594,"mirror_url":null,"open_issues_count":396,"forks":2594,"open_issues":396,"watchers":10086,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/diaspora/diaspora/pulls/6082"},"html":{"href":"https://github.com/diaspora/diaspora/pull/6082"},"issue":{"href":"https://api.github.com/repos/diaspora/diaspora/issues/6082"},"comments":{"href":"https://api.github.com/repos/diaspora/diaspora/issues/6082/comments"},"review_comments":{"href":"https://api.github.com/repos/diaspora/diaspora/pulls/6082/comments"},"review_comment":{"href":"https://api.github.com/repos/diaspora/diaspora/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/diaspora/diaspora/pulls/6082/commits"},"statuses":{"href":"https://api.github.com/repos/diaspora/diaspora/statuses/8147a5ada8c12a2b3aaa0be21ec9484be83cc33f"}}}}