{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/34038843","id":34038843,"diff_hunk":"@@ -0,0 +1,9 @@\n+import os\n+\n+class GlobalVariables(object):","path":"edXRegressionAutomated/Tests/Settings/config.py","position":3,"original_position":3,"commit_id":"7ddf3329e1670c81a55613521a82d5dcf6c94f47","original_commit_id":"7ddf3329e1670c81a55613521a82d5dcf6c94f47","user":{"login":"benpatterson","id":2004678,"avatar_url":"https://avatars.githubusercontent.com/u/2004678?v=3","gravatar_id":"","url":"https://api.github.com/users/benpatterson","html_url":"https://github.com/benpatterson","followers_url":"https://api.github.com/users/benpatterson/followers","following_url":"https://api.github.com/users/benpatterson/following{/other_user}","gists_url":"https://api.github.com/users/benpatterson/gists{/gist_id}","starred_url":"https://api.github.com/users/benpatterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benpatterson/subscriptions","organizations_url":"https://api.github.com/users/benpatterson/orgs","repos_url":"https://api.github.com/users/benpatterson/repos","events_url":"https://api.github.com/users/benpatterson/events{/privacy}","received_events_url":"https://api.github.com/users/benpatterson/received_events","type":"User","site_admin":false},"body":"You should change the name of this class to something else. When I read it as GlobalVariables (in a different file), I was thinking they really are global. However, you're using them as a class (which is better anyway). ","created_at":"2015-07-07T13:31:15Z","updated_at":"2015-07-07T13:31:15Z","html_url":"https://github.com/edx/edx-platform/pull/8549#discussion_r34038843","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/8549","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/34038843"},"html":{"href":"https://github.com/edx/edx-platform/pull/8549#discussion_r34038843"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/8549"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/8549","id":37904502,"html_url":"https://github.com/edx/edx-platform/pull/8549","diff_url":"https://github.com/edx/edx-platform/pull/8549.diff","patch_url":"https://github.com/edx/edx-platform/pull/8549.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/8549","number":8549,"state":"open","locked":false,"title":"DO NOT MERGE","user":{"login":"raeeschachar","id":6028681,"avatar_url":"https://avatars.githubusercontent.com/u/6028681?v=3","gravatar_id":"","url":"https://api.github.com/users/raeeschachar","html_url":"https://github.com/raeeschachar","followers_url":"https://api.github.com/users/raeeschachar/followers","following_url":"https://api.github.com/users/raeeschachar/following{/other_user}","gists_url":"https://api.github.com/users/raeeschachar/gists{/gist_id}","starred_url":"https://api.github.com/users/raeeschachar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raeeschachar/subscriptions","organizations_url":"https://api.github.com/users/raeeschachar/orgs","repos_url":"https://api.github.com/users/raeeschachar/repos","events_url":"https://api.github.com/users/raeeschachar/events{/privacy}","received_events_url":"https://api.github.com/users/raeeschachar/received_events","type":"User","site_admin":false},"body":"@benpatterson \r\nFirst round. Please review. ","created_at":"2015-06-17T14:09:11Z","updated_at":"2015-07-07T13:31:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"788c612ad9b33b0c6e4675bfff4a3426364579c6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/8549/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/8549/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/8549/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/7ddf3329e1670c81a55613521a82d5dcf6c94f47","head":{"label":"edx:raees/bok_choy_test_demo","ref":"raees/bok_choy_test_demo","sha":"7ddf3329e1670c81a55613521a82d5dcf6c94f47","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2015-07-07T08:29:29Z","pushed_at":"2015-07-07T13:25:15Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":2060229,"stargazers_count":2028,"watchers_count":2028,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1169,"mirror_url":null,"open_issues_count":154,"forks":1169,"open_issues":154,"watchers":2028,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"d6aa1578c454b645f92c88f4550d6d0f444062cd","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2015-07-07T08:29:29Z","pushed_at":"2015-07-07T13:25:15Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":2060229,"stargazers_count":2028,"watchers_count":2028,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1169,"mirror_url":null,"open_issues_count":154,"forks":1169,"open_issues":154,"watchers":2028,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/8549"},"html":{"href":"https://github.com/edx/edx-platform/pull/8549"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/8549"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/8549/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/8549/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/8549/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/7ddf3329e1670c81a55613521a82d5dcf6c94f47"}}}}