{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/11583","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11583/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11583/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11583/events","html_url":"https://github.com/cms-sw/cmssw/pull/11583","id":109188184,"number":11583,"title":"Update Run 2 eras to configure FastSim properly","user":{"login":"mark-grimes","id":6480160,"avatar_url":"https://avatars.githubusercontent.com/u/6480160?v=3","gravatar_id":"","url":"https://api.github.com/users/mark-grimes","html_url":"https://github.com/mark-grimes","followers_url":"https://api.github.com/users/mark-grimes/followers","following_url":"https://api.github.com/users/mark-grimes/following{/other_user}","gists_url":"https://api.github.com/users/mark-grimes/gists{/gist_id}","starred_url":"https://api.github.com/users/mark-grimes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mark-grimes/subscriptions","organizations_url":"https://api.github.com/users/mark-grimes/orgs","repos_url":"https://api.github.com/users/mark-grimes/repos","events_url":"https://api.github.com/users/mark-grimes/events{/privacy}","received_events_url":"https://api.github.com/users/mark-grimes/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fef2c0"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/fastsim-pending","name":"fastsim-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-pending","name":"tests-pending","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/55","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_7_6_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/55/labels","id":1176788,"number":55,"title":"Next CMSSW_7_6_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":67,"closed_issues":789,"state":"open","created_at":"2015-06-23T07:27:04Z","updated_at":"2015-09-30T22:06:07Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2015-09-30T22:00:13Z","updated_at":"2015-09-30T22:06:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/11583","html_url":"https://github.com/cms-sw/cmssw/pull/11583","diff_url":"https://github.com/cms-sw/cmssw/pull/11583.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/11583.patch"},"body":"Currently the Run 2 eras do not configure FastSim the same as the postLS1Customs.  This brings them both into line.  I've done this in a functional way so that it works for both \"gctDigis\" -> \"simGctDigis\" (Run 1); and \"caloStage1LegacyFormatDigis\" -> \"simCaloStage1LegacyFormatDigis\" (Run 2).  If preferred I could keep the Run 1 lines the same and add\r\n\r\n    eras.stage1L1Trigger.toModify( l1extraParticles, etTotalSource = cms.InputTag(\"simCaloStage1LegacyFormatDigis\") )\r\n\r\netcetera.\r\n\r\n**Note there is still a difference between the era and the customisation**\r\nIn the customisation, `process.misalignedCSCGeometry.useGangedStripsInME1a` is True whereas in the era it's False.  I'm pretty sure the value for the era is correct, and the customisation wrong.  Could someone from FastSim confirm?\r\n\r\nI've done a comparison of how the config for era differs to customisations in workflows 5.1, 5.2, 135.1 and 135.4 here:\r\n\r\nhttp://grimes.web.cern.ch/grimes/eraProcessDiffs/processDiffs_FastSim-7_6_X_2015-09-30-1100-PR11466-mark-grimes_fixRun2EraInFastSim.html\r\n\r\nThe 5.x tests show nothing there because they're exactly the same.  Don't worry `outputCommands` \"unexpected\" difference, the commands are just in a different order but functionally the same."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/144555983","html_url":"https://github.com/cms-sw/cmssw/pull/11583#issuecomment-144555983","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11583","id":144555983,"user":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars.githubusercontent.com/u/4170616?v=3","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2015-09-30T22:06:10Z","updated_at":"2015-09-30T22:06:10Z","body":"A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_7_6_X.\n\nUpdate Run 2 eras to configure FastSim properly\n\nIt involves the following packages:\n\nFastSimulation/Configuration\n\n\n@cmsbuild, @ssekmen, @civanch, @mdhildreth, @lveldere can you please review it and eventually sign? Thanks.\n@Martin-Grunewald, @matt-komm this is something you requested to watch as well.\nYou can sign-off by replying to this message having '+1' in the first line of your reply.\nYou can reject by replying  to this message having '-1' in the first line of your reply.\nIf you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.\n@degano you are the release manager for this.\nYou can merge this pull request by typing 'merge' in the first line of your comment.\n"}}