{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Identity/pulls/comments/24710731","id":24710731,"diff_hunk":"@@ -64,13 +64,13 @@ public class SignInManager<TUser> where TUser : class\n         {\n             if (Options.SignIn.RequireConfirmedEmail && !(await UserManager.IsEmailConfirmedAsync(user)))\n             {\n-                return await LogResultAsync(false, user);\n+                return await false.WithLoggingAsync(this, user);\n             }\n             if (Options.SignIn.RequireConfirmedPhoneNumber && !(await UserManager.IsPhoneNumberConfirmedAsync(user)))\n             {\n-                return await LogResultAsync(false, user);\n+                return await false.WithLoggingAsync(this, user);","path":"src/Microsoft.AspNet.Identity/SignInManager.cs","position":10,"original_position":10,"commit_id":"5b1ff8c878e0e22f2cd3ca924d72100f278090a7","original_commit_id":"5b1ff8c878e0e22f2cd3ca924d72100f278090a7","user":{"login":"suhasj","id":1919946,"avatar_url":"https://avatars.githubusercontent.com/u/1919946?v=3","gravatar_id":"","url":"https://api.github.com/users/suhasj","html_url":"https://github.com/suhasj","followers_url":"https://api.github.com/users/suhasj/followers","following_url":"https://api.github.com/users/suhasj/following{/other_user}","gists_url":"https://api.github.com/users/suhasj/gists{/gist_id}","starred_url":"https://api.github.com/users/suhasj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suhasj/subscriptions","organizations_url":"https://api.github.com/users/suhasj/orgs","repos_url":"https://api.github.com/users/suhasj/repos","events_url":"https://api.github.com/users/suhasj/events{/privacy}","received_events_url":"https://api.github.com/users/suhasj/received_events","type":"User","site_admin":false},"body":"I agree with that. We can a split where logging after Task<IdentityResult> can be an extension method while for bool results it can be in the Manager class itself.\r\n\r\nHaving an extension method makes it easy to have a fluent call that's all","created_at":"2015-02-14T02:00:41Z","updated_at":"2015-02-14T02:00:41Z","html_url":"https://github.com/aspnet/Identity/pull/354#discussion_r24710731","pull_request_url":"https://api.github.com/repos/aspnet/Identity/pulls/354","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Identity/pulls/comments/24710731"},"html":{"href":"https://github.com/aspnet/Identity/pull/354#discussion_r24710731"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Identity/pulls/354"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Identity/pulls/354","id":28949270,"html_url":"https://github.com/aspnet/Identity/pull/354","diff_url":"https://github.com/aspnet/Identity/pull/354.diff","patch_url":"https://github.com/aspnet/Identity/pull/354.patch","issue_url":"https://api.github.com/repos/aspnet/Identity/issues/354","number":354,"state":"open","locked":false,"title":"Defered logging","user":{"login":"suhasj","id":1919946,"avatar_url":"https://avatars.githubusercontent.com/u/1919946?v=3","gravatar_id":"","url":"https://api.github.com/users/suhasj","html_url":"https://github.com/suhasj","followers_url":"https://api.github.com/users/suhasj/followers","following_url":"https://api.github.com/users/suhasj/following{/other_user}","gists_url":"https://api.github.com/users/suhasj/gists{/gist_id}","starred_url":"https://api.github.com/users/suhasj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suhasj/subscriptions","organizations_url":"https://api.github.com/users/suhasj/orgs","repos_url":"https://api.github.com/users/suhasj/repos","events_url":"https://api.github.com/users/suhasj/events{/privacy}","received_events_url":"https://api.github.com/users/suhasj/received_events","type":"User","site_admin":false},"body":"@HaoK @divega \r\n\r\nChanges\r\n- Fixed logging to pass a func instead of a string. This func is called in the logger only if the loglevel is enabled\r\n- Fixed tests to pass func instead of string values as intended","created_at":"2015-02-09T19:33:21Z","updated_at":"2015-02-14T02:00:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"440d5e2127140fe08cf87da7999a96b66ccff236","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Identity/pulls/354/commits","review_comments_url":"https://api.github.com/repos/aspnet/Identity/pulls/354/comments","review_comment_url":"https://api.github.com/repos/aspnet/Identity/pulls/comments/{number}","comments_url":"https://api.github.com/repos/aspnet/Identity/issues/354/comments","statuses_url":"https://api.github.com/repos/aspnet/Identity/statuses/5b1ff8c878e0e22f2cd3ca924d72100f278090a7","head":{"label":"aspnet:DeferedLogging","ref":"DeferedLogging","sha":"5b1ff8c878e0e22f2cd3ca924d72100f278090a7","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":16491880,"name":"Identity","full_name":"aspnet/Identity","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Identity","description":"Membership system for building ASP.NET web applications, including membership, login, and user data.","fork":false,"url":"https://api.github.com/repos/aspnet/Identity","forks_url":"https://api.github.com/repos/aspnet/Identity/forks","keys_url":"https://api.github.com/repos/aspnet/Identity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Identity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Identity/teams","hooks_url":"https://api.github.com/repos/aspnet/Identity/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Identity/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Identity/events","assignees_url":"https://api.github.com/repos/aspnet/Identity/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Identity/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Identity/tags","blobs_url":"https://api.github.com/repos/aspnet/Identity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Identity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Identity/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Identity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Identity/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Identity/languages","stargazers_url":"https://api.github.com/repos/aspnet/Identity/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Identity/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Identity/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Identity/subscription","commits_url":"https://api.github.com/repos/aspnet/Identity/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Identity/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Identity/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Identity/issues/comments/{number}","contents_url":"https://api.github.com/repos/aspnet/Identity/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Identity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Identity/merges","archive_url":"https://api.github.com/repos/aspnet/Identity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Identity/downloads","issues_url":"https://api.github.com/repos/aspnet/Identity/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Identity/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Identity/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Identity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Identity/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Identity/releases{/id}","created_at":"2014-02-03T20:23:53Z","updated_at":"2015-02-13T02:38:35Z","pushed_at":"2015-02-14T01:34:51Z","git_url":"git://github.com/aspnet/Identity.git","ssh_url":"git@github.com:aspnet/Identity.git","clone_url":"https://github.com/aspnet/Identity.git","svn_url":"https://github.com/aspnet/Identity","homepage":"","size":6815,"stargazers_count":248,"watchers_count":248,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":77,"mirror_url":null,"open_issues_count":48,"forks":77,"open_issues":48,"watchers":248,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"15be6edf6a69335068cadc1711749224fe2753bf","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":16491880,"name":"Identity","full_name":"aspnet/Identity","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Identity","description":"Membership system for building ASP.NET web applications, including membership, login, and user data.","fork":false,"url":"https://api.github.com/repos/aspnet/Identity","forks_url":"https://api.github.com/repos/aspnet/Identity/forks","keys_url":"https://api.github.com/repos/aspnet/Identity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Identity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Identity/teams","hooks_url":"https://api.github.com/repos/aspnet/Identity/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Identity/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Identity/events","assignees_url":"https://api.github.com/repos/aspnet/Identity/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Identity/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Identity/tags","blobs_url":"https://api.github.com/repos/aspnet/Identity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Identity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Identity/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Identity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Identity/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Identity/languages","stargazers_url":"https://api.github.com/repos/aspnet/Identity/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Identity/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Identity/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Identity/subscription","commits_url":"https://api.github.com/repos/aspnet/Identity/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Identity/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Identity/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Identity/issues/comments/{number}","contents_url":"https://api.github.com/repos/aspnet/Identity/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Identity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Identity/merges","archive_url":"https://api.github.com/repos/aspnet/Identity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Identity/downloads","issues_url":"https://api.github.com/repos/aspnet/Identity/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Identity/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Identity/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Identity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Identity/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Identity/releases{/id}","created_at":"2014-02-03T20:23:53Z","updated_at":"2015-02-13T02:38:35Z","pushed_at":"2015-02-14T01:34:51Z","git_url":"git://github.com/aspnet/Identity.git","ssh_url":"git@github.com:aspnet/Identity.git","clone_url":"https://github.com/aspnet/Identity.git","svn_url":"https://github.com/aspnet/Identity","homepage":"","size":6815,"stargazers_count":248,"watchers_count":248,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":77,"mirror_url":null,"open_issues_count":48,"forks":77,"open_issues":48,"watchers":248,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Identity/pulls/354"},"html":{"href":"https://github.com/aspnet/Identity/pull/354"},"issue":{"href":"https://api.github.com/repos/aspnet/Identity/issues/354"},"comments":{"href":"https://api.github.com/repos/aspnet/Identity/issues/354/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Identity/pulls/354/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Identity/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Identity/pulls/354/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Identity/statuses/5b1ff8c878e0e22f2cd3ca924d72100f278090a7"}}}}