{"action":"closed","number":570,"pull_request":{"url":"https://api.github.com/repos/OPM/opm-parser/pulls/570","id":43851224,"html_url":"https://github.com/OPM/opm-parser/pull/570","diff_url":"https://github.com/OPM/opm-parser/pull/570.diff","patch_url":"https://github.com/OPM/opm-parser/pull/570.patch","issue_url":"https://api.github.com/repos/OPM/opm-parser/issues/570","number":570,"state":"closed","locked":false,"title":"Table refactor2","user":{"login":"joakim-hove","id":1321665,"avatar_url":"https://avatars.githubusercontent.com/u/1321665?v=3","gravatar_id":"","url":"https://api.github.com/users/joakim-hove","html_url":"https://github.com/joakim-hove","followers_url":"https://api.github.com/users/joakim-hove/followers","following_url":"https://api.github.com/users/joakim-hove/following{/other_user}","gists_url":"https://api.github.com/users/joakim-hove/gists{/gist_id}","starred_url":"https://api.github.com/users/joakim-hove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joakim-hove/subscriptions","organizations_url":"https://api.github.com/users/joakim-hove/orgs","repos_url":"https://api.github.com/users/joakim-hove/repos","events_url":"https://api.github.com/users/joakim-hove/events{/privacy}","received_events_url":"https://api.github.com/users/joakim-hove/received_events","type":"User","site_admin":false},"body":"In this PR a simple class Tables is created, and all the tables in the EclipseState class are moved to the Tables class. The purpose of this is:\r\n\r\nTo be able to instantiate tables without instantiating a full EclipseState object.\r\nA preparation for some refactoring of the table code.\r\nSimplify the EclipseState <-> Tables <-> GridProperties dependency triangle.\r\nThe current PR only moves the table classes from EclipseState to Tables and does not yet address 2) or 3) above. In addition std::shared_ptr<const Deck> has been replaced with const Deck&.\r\n\r\nFollowup PR's to downstream modules are in the works. @andlaus: please guide me if you want PR's targetting one of your branches in opm-core/opm-material.\r\n\r\nFollowups:\r\n1. https://github.com/OPM/opm-material/pull/49\r\n2. https://github.com/OPM/opm-core/pull/865\r\n3. https://github.com/OPM/opm-polymer/pull/140\r\n4. https://github.com/OPM/opm-autodiff/pull/449","created_at":"2015-09-01T08:49:55Z","updated_at":"2015-09-02T09:57:30Z","closed_at":"2015-09-02T09:57:30Z","merged_at":"2015-09-02T09:57:30Z","merge_commit_sha":"81f8ee40b30962de06de2933e316188cf6503ec8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OPM/opm-parser/pulls/570/commits","review_comments_url":"https://api.github.com/repos/OPM/opm-parser/pulls/570/comments","review_comment_url":"https://api.github.com/repos/OPM/opm-parser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OPM/opm-parser/issues/570/comments","statuses_url":"https://api.github.com/repos/OPM/opm-parser/statuses/9b6916a5ced98449c16107f88b3c138d7b17290a","head":{"label":"joakim-hove:table-refactor2","ref":"table-refactor2","sha":"9b6916a5ced98449c16107f88b3c138d7b17290a","user":{"login":"joakim-hove","id":1321665,"avatar_url":"https://avatars.githubusercontent.com/u/1321665?v=3","gravatar_id":"","url":"https://api.github.com/users/joakim-hove","html_url":"https://github.com/joakim-hove","followers_url":"https://api.github.com/users/joakim-hove/followers","following_url":"https://api.github.com/users/joakim-hove/following{/other_user}","gists_url":"https://api.github.com/users/joakim-hove/gists{/gist_id}","starred_url":"https://api.github.com/users/joakim-hove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joakim-hove/subscriptions","organizations_url":"https://api.github.com/users/joakim-hove/orgs","repos_url":"https://api.github.com/users/joakim-hove/repos","events_url":"https://api.github.com/users/joakim-hove/events{/privacy}","received_events_url":"https://api.github.com/users/joakim-hove/received_events","type":"User","site_admin":false},"repo":{"id":8883572,"name":"opm-parser","full_name":"joakim-hove/opm-parser","owner":{"login":"joakim-hove","id":1321665,"avatar_url":"https://avatars.githubusercontent.com/u/1321665?v=3","gravatar_id":"","url":"https://api.github.com/users/joakim-hove","html_url":"https://github.com/joakim-hove","followers_url":"https://api.github.com/users/joakim-hove/followers","following_url":"https://api.github.com/users/joakim-hove/following{/other_user}","gists_url":"https://api.github.com/users/joakim-hove/gists{/gist_id}","starred_url":"https://api.github.com/users/joakim-hove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joakim-hove/subscriptions","organizations_url":"https://api.github.com/users/joakim-hove/orgs","repos_url":"https://api.github.com/users/joakim-hove/repos","events_url":"https://api.github.com/users/joakim-hove/events{/privacy}","received_events_url":"https://api.github.com/users/joakim-hove/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joakim-hove/opm-parser","description":"","fork":true,"url":"https://api.github.com/repos/joakim-hove/opm-parser","forks_url":"https://api.github.com/repos/joakim-hove/opm-parser/forks","keys_url":"https://api.github.com/repos/joakim-hove/opm-parser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joakim-hove/opm-parser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joakim-hove/opm-parser/teams","hooks_url":"https://api.github.com/repos/joakim-hove/opm-parser/hooks","issue_events_url":"https://api.github.com/repos/joakim-hove/opm-parser/issues/events{/number}","events_url":"https://api.github.com/repos/joakim-hove/opm-parser/events","assignees_url":"https://api.github.com/repos/joakim-hove/opm-parser/assignees{/user}","branches_url":"https://api.github.com/repos/joakim-hove/opm-parser/branches{/branch}","tags_url":"https://api.github.com/repos/joakim-hove/opm-parser/tags","blobs_url":"https://api.github.com/repos/joakim-hove/opm-parser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joakim-hove/opm-parser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joakim-hove/opm-parser/git/refs{/sha}","trees_url":"https://api.github.com/repos/joakim-hove/opm-parser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joakim-hove/opm-parser/statuses/{sha}","languages_url":"https://api.github.com/repos/joakim-hove/opm-parser/languages","stargazers_url":"https://api.github.com/repos/joakim-hove/opm-parser/stargazers","contributors_url":"https://api.github.com/repos/joakim-hove/opm-parser/contributors","subscribers_url":"https://api.github.com/repos/joakim-hove/opm-parser/subscribers","subscription_url":"https://api.github.com/repos/joakim-hove/opm-parser/subscription","commits_url":"https://api.github.com/repos/joakim-hove/opm-parser/commits{/sha}","git_commits_url":"https://api.github.com/repos/joakim-hove/opm-parser/git/commits{/sha}","comments_url":"https://api.github.com/repos/joakim-hove/opm-parser/comments{/number}","issue_comment_url":"https://api.github.com/repos/joakim-hove/opm-parser/issues/comments{/number}","contents_url":"https://api.github.com/repos/joakim-hove/opm-parser/contents/{+path}","compare_url":"https://api.github.com/repos/joakim-hove/opm-parser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joakim-hove/opm-parser/merges","archive_url":"https://api.github.com/repos/joakim-hove/opm-parser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joakim-hove/opm-parser/downloads","issues_url":"https://api.github.com/repos/joakim-hove/opm-parser/issues{/number}","pulls_url":"https://api.github.com/repos/joakim-hove/opm-parser/pulls{/number}","milestones_url":"https://api.github.com/repos/joakim-hove/opm-parser/milestones{/number}","notifications_url":"https://api.github.com/repos/joakim-hove/opm-parser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joakim-hove/opm-parser/labels{/name}","releases_url":"https://api.github.com/repos/joakim-hove/opm-parser/releases{/id}","created_at":"2013-03-19T16:41:12Z","updated_at":"2015-05-08T04:40:51Z","pushed_at":"2015-09-01T16:01:25Z","git_url":"git://github.com/joakim-hove/opm-parser.git","ssh_url":"git@github.com:joakim-hove/opm-parser.git","clone_url":"https://github.com/joakim-hove/opm-parser.git","svn_url":"https://github.com/joakim-hove/opm-parser","homepage":null,"size":6510,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OPM:master","ref":"master","sha":"18322abc2b630e4cc99a0a53ba864f8e1d03e8c6","user":{"login":"OPM","id":1827197,"avatar_url":"https://avatars.githubusercontent.com/u/1827197?v=3","gravatar_id":"","url":"https://api.github.com/users/OPM","html_url":"https://github.com/OPM","followers_url":"https://api.github.com/users/OPM/followers","following_url":"https://api.github.com/users/OPM/following{/other_user}","gists_url":"https://api.github.com/users/OPM/gists{/gist_id}","starred_url":"https://api.github.com/users/OPM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPM/subscriptions","organizations_url":"https://api.github.com/users/OPM/orgs","repos_url":"https://api.github.com/users/OPM/repos","events_url":"https://api.github.com/users/OPM/events{/privacy}","received_events_url":"https://api.github.com/users/OPM/received_events","type":"Organization","site_admin":false},"repo":{"id":8604178,"name":"opm-parser","full_name":"OPM/opm-parser","owner":{"login":"OPM","id":1827197,"avatar_url":"https://avatars.githubusercontent.com/u/1827197?v=3","gravatar_id":"","url":"https://api.github.com/users/OPM","html_url":"https://github.com/OPM","followers_url":"https://api.github.com/users/OPM/followers","following_url":"https://api.github.com/users/OPM/following{/other_user}","gists_url":"https://api.github.com/users/OPM/gists{/gist_id}","starred_url":"https://api.github.com/users/OPM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPM/subscriptions","organizations_url":"https://api.github.com/users/OPM/orgs","repos_url":"https://api.github.com/users/OPM/repos","events_url":"https://api.github.com/users/OPM/events{/privacy}","received_events_url":"https://api.github.com/users/OPM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OPM/opm-parser","description":"","fork":false,"url":"https://api.github.com/repos/OPM/opm-parser","forks_url":"https://api.github.com/repos/OPM/opm-parser/forks","keys_url":"https://api.github.com/repos/OPM/opm-parser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OPM/opm-parser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OPM/opm-parser/teams","hooks_url":"https://api.github.com/repos/OPM/opm-parser/hooks","issue_events_url":"https://api.github.com/repos/OPM/opm-parser/issues/events{/number}","events_url":"https://api.github.com/repos/OPM/opm-parser/events","assignees_url":"https://api.github.com/repos/OPM/opm-parser/assignees{/user}","branches_url":"https://api.github.com/repos/OPM/opm-parser/branches{/branch}","tags_url":"https://api.github.com/repos/OPM/opm-parser/tags","blobs_url":"https://api.github.com/repos/OPM/opm-parser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OPM/opm-parser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OPM/opm-parser/git/refs{/sha}","trees_url":"https://api.github.com/repos/OPM/opm-parser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OPM/opm-parser/statuses/{sha}","languages_url":"https://api.github.com/repos/OPM/opm-parser/languages","stargazers_url":"https://api.github.com/repos/OPM/opm-parser/stargazers","contributors_url":"https://api.github.com/repos/OPM/opm-parser/contributors","subscribers_url":"https://api.github.com/repos/OPM/opm-parser/subscribers","subscription_url":"https://api.github.com/repos/OPM/opm-parser/subscription","commits_url":"https://api.github.com/repos/OPM/opm-parser/commits{/sha}","git_commits_url":"https://api.github.com/repos/OPM/opm-parser/git/commits{/sha}","comments_url":"https://api.github.com/repos/OPM/opm-parser/comments{/number}","issue_comment_url":"https://api.github.com/repos/OPM/opm-parser/issues/comments{/number}","contents_url":"https://api.github.com/repos/OPM/opm-parser/contents/{+path}","compare_url":"https://api.github.com/repos/OPM/opm-parser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OPM/opm-parser/merges","archive_url":"https://api.github.com/repos/OPM/opm-parser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OPM/opm-parser/downloads","issues_url":"https://api.github.com/repos/OPM/opm-parser/issues{/number}","pulls_url":"https://api.github.com/repos/OPM/opm-parser/pulls{/number}","milestones_url":"https://api.github.com/repos/OPM/opm-parser/milestones{/number}","notifications_url":"https://api.github.com/repos/OPM/opm-parser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OPM/opm-parser/labels{/name}","releases_url":"https://api.github.com/repos/OPM/opm-parser/releases{/id}","created_at":"2013-03-06T13:39:46Z","updated_at":"2015-07-05T17:33:03Z","pushed_at":"2015-09-02T09:57:30Z","git_url":"git://github.com/OPM/opm-parser.git","ssh_url":"git@github.com:OPM/opm-parser.git","clone_url":"https://github.com/OPM/opm-parser.git","svn_url":"https://github.com/OPM/opm-parser","homepage":null,"size":7908,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":17,"forks":25,"open_issues":17,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OPM/opm-parser/pulls/570"},"html":{"href":"https://github.com/OPM/opm-parser/pull/570"},"issue":{"href":"https://api.github.com/repos/OPM/opm-parser/issues/570"},"comments":{"href":"https://api.github.com/repos/OPM/opm-parser/issues/570/comments"},"review_comments":{"href":"https://api.github.com/repos/OPM/opm-parser/pulls/570/comments"},"review_comment":{"href":"https://api.github.com/repos/OPM/opm-parser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OPM/opm-parser/pulls/570/commits"},"statuses":{"href":"https://api.github.com/repos/OPM/opm-parser/statuses/9b6916a5ced98449c16107f88b3c138d7b17290a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"joakim-hove","id":1321665,"avatar_url":"https://avatars.githubusercontent.com/u/1321665?v=3","gravatar_id":"","url":"https://api.github.com/users/joakim-hove","html_url":"https://github.com/joakim-hove","followers_url":"https://api.github.com/users/joakim-hove/followers","following_url":"https://api.github.com/users/joakim-hove/following{/other_user}","gists_url":"https://api.github.com/users/joakim-hove/gists{/gist_id}","starred_url":"https://api.github.com/users/joakim-hove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joakim-hove/subscriptions","organizations_url":"https://api.github.com/users/joakim-hove/orgs","repos_url":"https://api.github.com/users/joakim-hove/repos","events_url":"https://api.github.com/users/joakim-hove/events{/privacy}","received_events_url":"https://api.github.com/users/joakim-hove/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":23,"additions":1880,"deletions":674,"changed_files":39}}