{"action":"created","issue":{"url":"https://api.github.com/repos/structured-log/structured-log/issues/15","labels_url":"https://api.github.com/repos/structured-log/structured-log/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/structured-log/structured-log/issues/15/comments","events_url":"https://api.github.com/repos/structured-log/structured-log/issues/15/events","html_url":"https://github.com/structured-log/structured-log/issues/15","id":97825258,"number":15,"title":"Are the end/endWith functions needed? What is purpose of these functions?","user":{"login":"ashleydavis","id":625126,"avatar_url":"https://avatars.githubusercontent.com/u/625126?v=3","gravatar_id":"","url":"https://api.github.com/users/ashleydavis","html_url":"https://github.com/ashleydavis","followers_url":"https://api.github.com/users/ashleydavis/followers","following_url":"https://api.github.com/users/ashleydavis/following{/other_user}","gists_url":"https://api.github.com/users/ashleydavis/gists{/gist_id}","starred_url":"https://api.github.com/users/ashleydavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashleydavis/subscriptions","organizations_url":"https://api.github.com/users/ashleydavis/orgs","repos_url":"https://api.github.com/users/ashleydavis/repos","events_url":"https://api.github.com/users/ashleydavis/events{/privacy}","received_events_url":"https://api.github.com/users/ashleydavis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-28T23:50:01Z","updated_at":"2015-07-29T12:45:40Z","closed_at":null,"body":"I'm looking to simplify the core a little bit so that it is easier to restructure for batching.\r\n\r\nI'm considering removing the log.end and Pipeline.end (and related) functions.\r\n\r\nThey appear to only be used in file-sink.tests.js and look like they might be replaced by the *flush* function.\r\n\r\nAre my assumptions correct?\r\n\r\nCan these functions be stripped out and later replaced with *flush*? (when batching is online)."},"comment":{"url":"https://api.github.com/repos/structured-log/structured-log/issues/comments/125939163","html_url":"https://github.com/structured-log/structured-log/issues/15#issuecomment-125939163","issue_url":"https://api.github.com/repos/structured-log/structured-log/issues/15","id":125939163,"user":{"login":"nblumhardt","id":342712,"avatar_url":"https://avatars.githubusercontent.com/u/342712?v=3","gravatar_id":"","url":"https://api.github.com/users/nblumhardt","html_url":"https://github.com/nblumhardt","followers_url":"https://api.github.com/users/nblumhardt/followers","following_url":"https://api.github.com/users/nblumhardt/following{/other_user}","gists_url":"https://api.github.com/users/nblumhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/nblumhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nblumhardt/subscriptions","organizations_url":"https://api.github.com/users/nblumhardt/orgs","repos_url":"https://api.github.com/users/nblumhardt/repos","events_url":"https://api.github.com/users/nblumhardt/events{/privacy}","received_events_url":"https://api.github.com/users/nblumhardt/received_events","type":"User","site_admin":false},"created_at":"2015-07-29T12:45:40Z","updated_at":"2015-07-29T12:45:40Z","body":"Hi Ashley - `end()` is more akin to `dispose()` than `flush()`, for example allowing files to be closed when a logger is no longer needed. I don't think `flush()` will extend to these cases, but could be wrong :-) Cheers!"}}