{"action":"created","issue":{"url":"https://api.github.com/repos/capistrano/capistrano/issues/1352","labels_url":"https://api.github.com/repos/capistrano/capistrano/issues/1352/labels{/name}","comments_url":"https://api.github.com/repos/capistrano/capistrano/issues/1352/comments","events_url":"https://api.github.com/repos/capistrano/capistrano/issues/1352/events","html_url":"https://github.com/capistrano/capistrano/pull/1352","id":55685321,"number":1352,"title":"Release roles bug - improve property filtering","user":{"login":"townsen","id":2119527,"avatar_url":"https://avatars.githubusercontent.com/u/2119527?v=3","gravatar_id":"","url":"https://api.github.com/users/townsen","html_url":"https://github.com/townsen","followers_url":"https://api.github.com/users/townsen/followers","following_url":"https://api.github.com/users/townsen/following{/other_user}","gists_url":"https://api.github.com/users/townsen/gists{/gist_id}","starred_url":"https://api.github.com/users/townsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/townsen/subscriptions","organizations_url":"https://api.github.com/users/townsen/orgs","repos_url":"https://api.github.com/users/townsen/repos","events_url":"https://api.github.com/users/townsen/events{/privacy}","received_events_url":"https://api.github.com/users/townsen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-27T22:37:26Z","updated_at":"2015-01-28T08:29:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/capistrano/capistrano/pulls/1352","html_url":"https://github.com/capistrano/capistrano/pull/1352","diff_url":"https://github.com/capistrano/capistrano/pull/1352.diff","patch_url":"https://github.com/capistrano/capistrano/pull/1352.patch"},"body":"Property filtering did not honour multiple filter options. Highlighted by changing `dsl_spec.rb:18`. This PR fixes that, cleans up the property filter code and adds a new capability (testing server property equality). I'll PR some documentation to capistrano.github.io to describe this."},"comment":{"url":"https://api.github.com/repos/capistrano/capistrano/issues/comments/71797641","html_url":"https://github.com/capistrano/capistrano/pull/1352#issuecomment-71797641","issue_url":"https://api.github.com/repos/capistrano/capistrano/issues/1352","id":71797641,"user":{"login":"leehambley","id":18952,"avatar_url":"https://avatars.githubusercontent.com/u/18952?v=3","gravatar_id":"","url":"https://api.github.com/users/leehambley","html_url":"https://github.com/leehambley","followers_url":"https://api.github.com/users/leehambley/followers","following_url":"https://api.github.com/users/leehambley/following{/other_user}","gists_url":"https://api.github.com/users/leehambley/gists{/gist_id}","starred_url":"https://api.github.com/users/leehambley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leehambley/subscriptions","organizations_url":"https://api.github.com/users/leehambley/orgs","repos_url":"https://api.github.com/users/leehambley/repos","events_url":"https://api.github.com/users/leehambley/events{/privacy}","received_events_url":"https://api.github.com/users/leehambley/received_events","type":"User","site_admin":false},"created_at":"2015-01-28T08:29:37Z","updated_at":"2015-01-28T08:29:37Z","body":"Thanks Nick\r\n\r\nSent from my Nexus 5.\r\nOn 27 Jan 2015 23:37, \"Nick Townsend\" <notifications@github.com> wrote:\r\n\r\n> Property filtering did not honour multiple filter options. Highlighted by\r\n> changing dsl_spec.rb:18. This PR fixes that, cleans up the property\r\n> filter code and adds a new capability (testing server property equality).\r\n> I'll PR some documentation to capistrano.github.io to describe this.\r\n> ------------------------------\r\n> You can view, comment on, or merge this pull request online at:\r\n>\r\n>   https://github.com/capistrano/capistrano/pull/1352\r\n> Commit Summary\r\n>\r\n>    - Change test to highlight release_roles bug\r\n>    - Improvements to Property Filtering\r\n>\r\n> File Changes\r\n>\r\n>    - *M* CHANGELOG.md\r\n>    <https://github.com/capistrano/capistrano/pull/1352/files#diff-0> (8)\r\n>    - *M* lib/capistrano/configuration/server.rb\r\n>    <https://github.com/capistrano/capistrano/pull/1352/files#diff-1> (64)\r\n>    - *M* lib/capistrano/dsl/env.rb\r\n>    <https://github.com/capistrano/capistrano/pull/1352/files#diff-2> (6)\r\n>    - *M* spec/integration/dsl_spec.rb\r\n>    <https://github.com/capistrano/capistrano/pull/1352/files#diff-3> (2)\r\n>    - *M* spec/lib/capistrano/configuration/server_spec.rb\r\n>    <https://github.com/capistrano/capistrano/pull/1352/files#diff-4> (24)\r\n>\r\n> Patch Links:\r\n>\r\n>    - https://github.com/capistrano/capistrano/pull/1352.patch\r\n>    - https://github.com/capistrano/capistrano/pull/1352.diff\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub\r\n> <https://github.com/capistrano/capistrano/pull/1352>.\r\n>"}}