{"action":"created","issue":{"url":"https://api.github.com/repos/DOMjudge/domjudge/issues/181","labels_url":"https://api.github.com/repos/DOMjudge/domjudge/issues/181/labels{/name}","comments_url":"https://api.github.com/repos/DOMjudge/domjudge/issues/181/comments","events_url":"https://api.github.com/repos/DOMjudge/domjudge/issues/181/events","html_url":"https://github.com/DOMjudge/domjudge/issues/181","id":115633025,"number":181,"title":"ICPC team import fails with duplicate teams","user":{"login":"wmacevoy","id":2680334,"avatar_url":"https://avatars.githubusercontent.com/u/2680334?v=3","gravatar_id":"","url":"https://api.github.com/users/wmacevoy","html_url":"https://github.com/wmacevoy","followers_url":"https://api.github.com/users/wmacevoy/followers","following_url":"https://api.github.com/users/wmacevoy/following{/other_user}","gists_url":"https://api.github.com/users/wmacevoy/gists{/gist_id}","starred_url":"https://api.github.com/users/wmacevoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmacevoy/subscriptions","organizations_url":"https://api.github.com/users/wmacevoy/orgs","repos_url":"https://api.github.com/users/wmacevoy/repos","events_url":"https://api.github.com/users/wmacevoy/events{/privacy}","received_events_url":"https://api.github.com/users/wmacevoy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-11-07T04:38:33Z","updated_at":"2015-11-07T15:24:38Z","closed_at":null,"body":"If a canceled team is re-registered as a new team with the same name, the import fails.  We adjusted the import to skip canceled teams with\r\ndomjudge 5.0.1, file:\r\n    domjudge/domserver/www/jury/impexp_baylor.php\r\nafter line 124:\r\nforeach ( $group['team'] as $team ) {\r\nwe inserted\r\n                if (strcmp($team[\"status\"],\"CANCELED\")==0) { continue; }\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/DOMjudge/domjudge/issues/comments/154714242","html_url":"https://github.com/DOMjudge/domjudge/issues/181#issuecomment-154714242","issue_url":"https://api.github.com/repos/DOMjudge/domjudge/issues/181","id":154714242,"user":{"login":"eldering","id":4692022,"avatar_url":"https://avatars.githubusercontent.com/u/4692022?v=3","gravatar_id":"","url":"https://api.github.com/users/eldering","html_url":"https://github.com/eldering","followers_url":"https://api.github.com/users/eldering/followers","following_url":"https://api.github.com/users/eldering/following{/other_user}","gists_url":"https://api.github.com/users/eldering/gists{/gist_id}","starred_url":"https://api.github.com/users/eldering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eldering/subscriptions","organizations_url":"https://api.github.com/users/eldering/orgs","repos_url":"https://api.github.com/users/eldering/repos","events_url":"https://api.github.com/users/eldering/events{/privacy}","received_events_url":"https://api.github.com/users/eldering/received_events","type":"User","site_admin":false},"created_at":"2015-11-07T15:24:38Z","updated_at":"2015-11-07T15:24:38Z","body":"Hi Tom,\n\nTo clarify: do you mean that when *importing* teams from the ICPC\ninterface into DOMjudge we should indeed ignore teams marked as\n\"canceled\"? (Or are you referring to another stage where team info is\nuploaded into the ICPC system?)\n\nJaap\n\nOn 07-11-15 13:15, Tomas wrote:\n> Hello, the canceled team is understood as removed, but it is needed to keep\n> history. I suggest not to upload canceled teams.\n> \n> Tom\n> \n> On Sat, Nov 7, 2015 at 3:25 PM, Warren MacEvoy <notifications@github.com>\n> wrote:\n> \n>> We did it with the web import, no tsv; but he problem is simple enough;\n>> you are using the team name as a key and, if a team is canceled, that name\n>> can be use again. We just added the code to skip the import on canceled\n>> teams. A more complete solution might include a checkbox but I'm not sure\n>> why you want to include canceled teams.\n>>\n>> Warren MacEvoy\n>> wmacevoy@coloradomesa.edu\n>> http://www.coloradomesa.edu/~wmacevoy\n>> 970-248-1070\n>>\n>>\n>>\n>> > On Nov 7, 2015, at 5:17 AM, Jaap Eldering <notifications@github.com>\n>> wrote:\n>> >\n>> > This issue was indeed also reported by UKIEPC contest staff. Do you\n>> still have the original TSV import files? That would help us to completely\n>> understand and fix this. You can send these to team@domjudge.org.\n>> >\n>> > —\n>> > Reply to this email directly or view it on GitHub.\n>> >\n>>\n>> —\n>> Reply to this email directly or view it on GitHub\n>> <https://github.com/DOMjudge/domjudge/issues/181#issuecomment-154709809>.\n>>\n> \n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/DOMjudge/domjudge/issues/181#issuecomment-154713415>.\n> \n\n"}}