{"action":"created","comment":{"url":"https://api.github.com/repos/borismus/webvr-boilerplate/pulls/comments/46846367","id":46846367,"diff_hunk":"@@ -104,10 +106,12 @@ function WebVRManager(renderer, effect, params) {\n       default:\n         this.setMode_(Modes.NORMAL);\n     }\n-    this.button.on('fs', this.onFSClick_.bind(this));\n-    this.button.on('vr', this.onVRClick_.bind(this));\n-    this.button.on('back', this.onBackClick_.bind(this));\n-    this.button.on('settings', this.onSettingsClick_.bind(this));\n+    if (this.button) {","path":"src/webvr-manager.js","position":34,"original_position":34,"commit_id":"31a550108c7c929f33c6c8209ef68da7f0f4a78d","original_commit_id":"31a550108c7c929f33c6c8209ef68da7f0f4a78d","user":{"login":"borismus","id":277632,"avatar_url":"https://avatars.githubusercontent.com/u/277632?v=3","gravatar_id":"","url":"https://api.github.com/users/borismus","html_url":"https://github.com/borismus","followers_url":"https://api.github.com/users/borismus/followers","following_url":"https://api.github.com/users/borismus/following{/other_user}","gists_url":"https://api.github.com/users/borismus/gists{/gist_id}","starred_url":"https://api.github.com/users/borismus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borismus/subscriptions","organizations_url":"https://api.github.com/users/borismus/orgs","repos_url":"https://api.github.com/users/borismus/repos","events_url":"https://api.github.com/users/borismus/events{/privacy}","received_events_url":"https://api.github.com/users/borismus/received_events","type":"User","site_admin":false},"body":"Conditional just complicates things. ","created_at":"2015-12-07T17:03:45Z","updated_at":"2015-12-07T17:03:45Z","html_url":"https://github.com/borismus/webvr-boilerplate/pull/77#discussion_r46846367","pull_request_url":"https://api.github.com/repos/borismus/webvr-boilerplate/pulls/77","_links":{"self":{"href":"https://api.github.com/repos/borismus/webvr-boilerplate/pulls/comments/46846367"},"html":{"href":"https://github.com/borismus/webvr-boilerplate/pull/77#discussion_r46846367"},"pull_request":{"href":"https://api.github.com/repos/borismus/webvr-boilerplate/pulls/77"}}},"pull_request":{"url":"https://api.github.com/repos/borismus/webvr-boilerplate/pulls/77","id":52623149,"html_url":"https://github.com/borismus/webvr-boilerplate/pull/77","diff_url":"https://github.com/borismus/webvr-boilerplate/pull/77.diff","patch_url":"https://github.com/borismus/webvr-boilerplate/pull/77.patch","issue_url":"https://api.github.com/repos/borismus/webvr-boilerplate/issues/77","number":77,"state":"open","locked":false,"title":"added configurable parentElem and preventButton","user":{"login":"bumblehead","id":747129,"avatar_url":"https://avatars.githubusercontent.com/u/747129?v=3","gravatar_id":"","url":"https://api.github.com/users/bumblehead","html_url":"https://github.com/bumblehead","followers_url":"https://api.github.com/users/bumblehead/followers","following_url":"https://api.github.com/users/bumblehead/following{/other_user}","gists_url":"https://api.github.com/users/bumblehead/gists{/gist_id}","starred_url":"https://api.github.com/users/bumblehead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bumblehead/subscriptions","organizations_url":"https://api.github.com/users/bumblehead/orgs","repos_url":"https://api.github.com/users/bumblehead/repos","events_url":"https://api.github.com/users/bumblehead/events{/privacy}","received_events_url":"https://api.github.com/users/bumblehead/received_events","type":"User","site_admin":false},"body":"added configurable parentElem and preventButton\r\n\r\nhttps://github.com/borismus/webvr-boilerplate/issues/68\r\nhttps://github.com/borismus/webvr-boilerplate/issues/66\r\n\r\nif defined, `parentElem` is used in place of window to obtain width and height. `preventButton` prevents button construction.\r\n\r\n```javascript\r\n    var manager = new WebVRManager(renderer, effect, {\r\n      parentElem : videoElem.parentNode,\r\n      preventButton : true\r\n    });\r\n```","created_at":"2015-12-04T02:37:54Z","updated_at":"2015-12-07T17:03:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0640496c2adfc9791b66582add465d8e3b8c613","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/borismus/webvr-boilerplate/pulls/77/commits","review_comments_url":"https://api.github.com/repos/borismus/webvr-boilerplate/pulls/77/comments","review_comment_url":"https://api.github.com/repos/borismus/webvr-boilerplate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/borismus/webvr-boilerplate/issues/77/comments","statuses_url":"https://api.github.com/repos/borismus/webvr-boilerplate/statuses/31a550108c7c929f33c6c8209ef68da7f0f4a78d","head":{"label":"bumblehead:parentElem-configure","ref":"parentElem-configure","sha":"31a550108c7c929f33c6c8209ef68da7f0f4a78d","user":{"login":"bumblehead","id":747129,"avatar_url":"https://avatars.githubusercontent.com/u/747129?v=3","gravatar_id":"","url":"https://api.github.com/users/bumblehead","html_url":"https://github.com/bumblehead","followers_url":"https://api.github.com/users/bumblehead/followers","following_url":"https://api.github.com/users/bumblehead/following{/other_user}","gists_url":"https://api.github.com/users/bumblehead/gists{/gist_id}","starred_url":"https://api.github.com/users/bumblehead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bumblehead/subscriptions","organizations_url":"https://api.github.com/users/bumblehead/orgs","repos_url":"https://api.github.com/users/bumblehead/repos","events_url":"https://api.github.com/users/bumblehead/events{/privacy}","received_events_url":"https://api.github.com/users/bumblehead/received_events","type":"User","site_admin":false},"repo":{"id":47375460,"name":"webvr-boilerplate","full_name":"bumblehead/webvr-boilerplate","owner":{"login":"bumblehead","id":747129,"avatar_url":"https://avatars.githubusercontent.com/u/747129?v=3","gravatar_id":"","url":"https://api.github.com/users/bumblehead","html_url":"https://github.com/bumblehead","followers_url":"https://api.github.com/users/bumblehead/followers","following_url":"https://api.github.com/users/bumblehead/following{/other_user}","gists_url":"https://api.github.com/users/bumblehead/gists{/gist_id}","starred_url":"https://api.github.com/users/bumblehead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bumblehead/subscriptions","organizations_url":"https://api.github.com/users/bumblehead/orgs","repos_url":"https://api.github.com/users/bumblehead/repos","events_url":"https://api.github.com/users/bumblehead/events{/privacy}","received_events_url":"https://api.github.com/users/bumblehead/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bumblehead/webvr-boilerplate","description":"A starting point for web-based VR experiences that work in both Cardboard and Oculus.","fork":true,"url":"https://api.github.com/repos/bumblehead/webvr-boilerplate","forks_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/forks","keys_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/teams","hooks_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/hooks","issue_events_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/issues/events{/number}","events_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/events","assignees_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/assignees{/user}","branches_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/branches{/branch}","tags_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/tags","blobs_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/git/refs{/sha}","trees_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/statuses/{sha}","languages_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/languages","stargazers_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/stargazers","contributors_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/contributors","subscribers_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/subscribers","subscription_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/subscription","commits_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/commits{/sha}","git_commits_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/git/commits{/sha}","comments_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/comments{/number}","issue_comment_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/issues/comments{/number}","contents_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/contents/{+path}","compare_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/merges","archive_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/downloads","issues_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/issues{/number}","pulls_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/pulls{/number}","milestones_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/milestones{/number}","notifications_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/labels{/name}","releases_url":"https://api.github.com/repos/bumblehead/webvr-boilerplate/releases{/id}","created_at":"2015-12-04T02:23:47Z","updated_at":"2015-12-04T02:23:48Z","pushed_at":"2015-12-04T02:32:08Z","git_url":"git://github.com/bumblehead/webvr-boilerplate.git","ssh_url":"git@github.com:bumblehead/webvr-boilerplate.git","clone_url":"https://github.com/bumblehead/webvr-boilerplate.git","svn_url":"https://github.com/bumblehead/webvr-boilerplate","homepage":"http://smus.com/responsive-vr/","size":5694,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"borismus:master","ref":"master","sha":"350e280e21a92128d722173915301b1dfdf1cf17","user":{"login":"borismus","id":277632,"avatar_url":"https://avatars.githubusercontent.com/u/277632?v=3","gravatar_id":"","url":"https://api.github.com/users/borismus","html_url":"https://github.com/borismus","followers_url":"https://api.github.com/users/borismus/followers","following_url":"https://api.github.com/users/borismus/following{/other_user}","gists_url":"https://api.github.com/users/borismus/gists{/gist_id}","starred_url":"https://api.github.com/users/borismus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borismus/subscriptions","organizations_url":"https://api.github.com/users/borismus/orgs","repos_url":"https://api.github.com/users/borismus/repos","events_url":"https://api.github.com/users/borismus/events{/privacy}","received_events_url":"https://api.github.com/users/borismus/received_events","type":"User","site_admin":false},"repo":{"id":29567351,"name":"webvr-boilerplate","full_name":"borismus/webvr-boilerplate","owner":{"login":"borismus","id":277632,"avatar_url":"https://avatars.githubusercontent.com/u/277632?v=3","gravatar_id":"","url":"https://api.github.com/users/borismus","html_url":"https://github.com/borismus","followers_url":"https://api.github.com/users/borismus/followers","following_url":"https://api.github.com/users/borismus/following{/other_user}","gists_url":"https://api.github.com/users/borismus/gists{/gist_id}","starred_url":"https://api.github.com/users/borismus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borismus/subscriptions","organizations_url":"https://api.github.com/users/borismus/orgs","repos_url":"https://api.github.com/users/borismus/repos","events_url":"https://api.github.com/users/borismus/events{/privacy}","received_events_url":"https://api.github.com/users/borismus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/borismus/webvr-boilerplate","description":"A starting point for web-based VR experiences that work in both Cardboard and Oculus.","fork":false,"url":"https://api.github.com/repos/borismus/webvr-boilerplate","forks_url":"https://api.github.com/repos/borismus/webvr-boilerplate/forks","keys_url":"https://api.github.com/repos/borismus/webvr-boilerplate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/borismus/webvr-boilerplate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/borismus/webvr-boilerplate/teams","hooks_url":"https://api.github.com/repos/borismus/webvr-boilerplate/hooks","issue_events_url":"https://api.github.com/repos/borismus/webvr-boilerplate/issues/events{/number}","events_url":"https://api.github.com/repos/borismus/webvr-boilerplate/events","assignees_url":"https://api.github.com/repos/borismus/webvr-boilerplate/assignees{/user}","branches_url":"https://api.github.com/repos/borismus/webvr-boilerplate/branches{/branch}","tags_url":"https://api.github.com/repos/borismus/webvr-boilerplate/tags","blobs_url":"https://api.github.com/repos/borismus/webvr-boilerplate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/borismus/webvr-boilerplate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/borismus/webvr-boilerplate/git/refs{/sha}","trees_url":"https://api.github.com/repos/borismus/webvr-boilerplate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/borismus/webvr-boilerplate/statuses/{sha}","languages_url":"https://api.github.com/repos/borismus/webvr-boilerplate/languages","stargazers_url":"https://api.github.com/repos/borismus/webvr-boilerplate/stargazers","contributors_url":"https://api.github.com/repos/borismus/webvr-boilerplate/contributors","subscribers_url":"https://api.github.com/repos/borismus/webvr-boilerplate/subscribers","subscription_url":"https://api.github.com/repos/borismus/webvr-boilerplate/subscription","commits_url":"https://api.github.com/repos/borismus/webvr-boilerplate/commits{/sha}","git_commits_url":"https://api.github.com/repos/borismus/webvr-boilerplate/git/commits{/sha}","comments_url":"https://api.github.com/repos/borismus/webvr-boilerplate/comments{/number}","issue_comment_url":"https://api.github.com/repos/borismus/webvr-boilerplate/issues/comments{/number}","contents_url":"https://api.github.com/repos/borismus/webvr-boilerplate/contents/{+path}","compare_url":"https://api.github.com/repos/borismus/webvr-boilerplate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/borismus/webvr-boilerplate/merges","archive_url":"https://api.github.com/repos/borismus/webvr-boilerplate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/borismus/webvr-boilerplate/downloads","issues_url":"https://api.github.com/repos/borismus/webvr-boilerplate/issues{/number}","pulls_url":"https://api.github.com/repos/borismus/webvr-boilerplate/pulls{/number}","milestones_url":"https://api.github.com/repos/borismus/webvr-boilerplate/milestones{/number}","notifications_url":"https://api.github.com/repos/borismus/webvr-boilerplate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/borismus/webvr-boilerplate/labels{/name}","releases_url":"https://api.github.com/repos/borismus/webvr-boilerplate/releases{/id}","created_at":"2015-01-21T02:40:06Z","updated_at":"2015-12-07T16:52:07Z","pushed_at":"2015-12-07T04:42:46Z","git_url":"git://github.com/borismus/webvr-boilerplate.git","ssh_url":"git@github.com:borismus/webvr-boilerplate.git","clone_url":"https://github.com/borismus/webvr-boilerplate.git","svn_url":"https://github.com/borismus/webvr-boilerplate","homepage":"http://smus.com/responsive-vr/","size":5720,"stargazers_count":360,"watchers_count":360,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":87,"mirror_url":null,"open_issues_count":21,"forks":87,"open_issues":21,"watchers":360,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/borismus/webvr-boilerplate/pulls/77"},"html":{"href":"https://github.com/borismus/webvr-boilerplate/pull/77"},"issue":{"href":"https://api.github.com/repos/borismus/webvr-boilerplate/issues/77"},"comments":{"href":"https://api.github.com/repos/borismus/webvr-boilerplate/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/borismus/webvr-boilerplate/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/borismus/webvr-boilerplate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/borismus/webvr-boilerplate/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/borismus/webvr-boilerplate/statuses/31a550108c7c929f33c6c8209ef68da7f0f4a78d"}}}}