{"action":"created","comment":{"url":"https://api.github.com/repos/Samsung/jerryscript/pulls/comments/39830143","id":39830143,"diff_hunk":"@@ -360,6 +361,7 @@ lit_read_code_point_from_hex (const lit_utf8_byte_t *buf_p, /**< buffer with cha\n \n     buf_p++;\n   }\n+  *str_p = buf_p;","path":"jerry-core/lit/lit-char-helpers.cpp","position":20,"original_position":20,"commit_id":"4994ca4ce80793e05d594595b623992c676216c8","original_commit_id":"4994ca4ce80793e05d594595b623992c676216c8","user":{"login":"zherczeg","id":2270193,"avatar_url":"https://avatars.githubusercontent.com/u/2270193?v=3","gravatar_id":"","url":"https://api.github.com/users/zherczeg","html_url":"https://github.com/zherczeg","followers_url":"https://api.github.com/users/zherczeg/followers","following_url":"https://api.github.com/users/zherczeg/following{/other_user}","gists_url":"https://api.github.com/users/zherczeg/gists{/gist_id}","starred_url":"https://api.github.com/users/zherczeg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zherczeg/subscriptions","organizations_url":"https://api.github.com/users/zherczeg/orgs","repos_url":"https://api.github.com/users/zherczeg/repos","events_url":"https://api.github.com/users/zherczeg/events{/privacy}","received_events_url":"https://api.github.com/users/zherczeg/received_events","type":"User","site_admin":false},"body":"Why?","created_at":"2015-09-18T07:27:18Z","updated_at":"2015-09-18T07:27:18Z","html_url":"https://github.com/Samsung/jerryscript/pull/616#discussion_r39830143","pull_request_url":"https://api.github.com/repos/Samsung/jerryscript/pulls/616","_links":{"self":{"href":"https://api.github.com/repos/Samsung/jerryscript/pulls/comments/39830143"},"html":{"href":"https://github.com/Samsung/jerryscript/pull/616#discussion_r39830143"},"pull_request":{"href":"https://api.github.com/repos/Samsung/jerryscript/pulls/616"}}},"pull_request":{"url":"https://api.github.com/repos/Samsung/jerryscript/pulls/616","id":44101219,"html_url":"https://github.com/Samsung/jerryscript/pull/616","diff_url":"https://github.com/Samsung/jerryscript/pull/616.diff","patch_url":"https://github.com/Samsung/jerryscript/pull/616.patch","issue_url":"https://api.github.com/repos/Samsung/jerryscript/issues/616","number":616,"state":"open","locked":false,"title":"Change internal encoding of strings to CESU-8","user":{"login":"dbatyai","id":12066566,"avatar_url":"https://avatars.githubusercontent.com/u/12066566?v=3","gravatar_id":"","url":"https://api.github.com/users/dbatyai","html_url":"https://github.com/dbatyai","followers_url":"https://api.github.com/users/dbatyai/followers","following_url":"https://api.github.com/users/dbatyai/following{/other_user}","gists_url":"https://api.github.com/users/dbatyai/gists{/gist_id}","starred_url":"https://api.github.com/users/dbatyai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbatyai/subscriptions","organizations_url":"https://api.github.com/users/dbatyai/orgs","repos_url":"https://api.github.com/users/dbatyai/repos","events_url":"https://api.github.com/users/dbatyai/events{/privacy}","received_events_url":"https://api.github.com/users/dbatyai/received_events","type":"User","site_admin":false},"body":"Use CESU-8 encoding internally for strings instead of UTF-8. This simplifies handling of strings, since in this case we don't need special handling for surrogate pairs.\r\nThis is still work in progress.\r\n\r\nCurrent status (measured on x86 linux):\r\n\r\n                               Benchmark |         RSS<br>(+ is better) |        Perf<br>(+ is better) |\r\n                               --------- |                          --- |                         ---- |\r\n                              3d-cube.js | 156->152 (2.564) | 0.429->0.417 (2.797) | \r\n                  access-binary-trees.js | 96->92 (4.167) | 0.382->0.369 (3.403) | \r\n                      access-fannkuch.js | 44->48 (-9.091) | 1.111->1.053 (5.221) | \r\n                         access-nbody.js | 68->68 (0.000) | 0.617->0.565 (8.428) | \r\n             bitops-3bit-bits-in-byte.js | 44->44 (0.000) | 0.407->0.39 (4.177) | \r\n                  bitops-bits-in-byte.js | 40->36 (10.000) | 0.519->0.509 (1.927) | \r\n                   bitops-bitwise-and.js | 32->36 (-12.500) | 0.438->0.433 (1.142) | \r\n                controlflow-recursive.js | 292->288 (1.370) | 0.384->0.384 (0.000) | \r\n                    date-format-xparb.js | 108->104 (3.704) | 0.422->0.26 (38.389) | \r\n                          math-cordic.js | 52->48 (7.692) | 0.491->0.463 (5.703) | \r\n                    math-partial-sums.js | 44->40 (9.091) | 0.294->0.285 (3.061) | \r\n                   math-spectral-norm.js | 52->56 (-7.692) | 0.392->0.379 (3.316) | \r\n                         string-fasta.js | 64->60 (6.250) | 3.79->2.172 (42.691) | \r\n                         Geometric mean: |       RSS reduction: 1.4238% |            Speed up: 10.505% |","created_at":"2015-09-03T12:36:23Z","updated_at":"2015-09-18T07:27:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"220e0dd85132aef92a150c94d7c9169f51811098","assignee":null,"milestone":{"url":"https://api.github.com/repos/Samsung/jerryscript/milestones/4","html_url":"https://github.com/Samsung/jerryscript/milestones/Engine%20optimization%20&%20enhancement","labels_url":"https://api.github.com/repos/Samsung/jerryscript/milestones/4/labels","id":1188990,"number":4,"title":"Engine optimization & enhancement","description":"","creator":{"login":"egavrin","id":782710,"avatar_url":"https://avatars.githubusercontent.com/u/782710?v=3","gravatar_id":"","url":"https://api.github.com/users/egavrin","html_url":"https://github.com/egavrin","followers_url":"https://api.github.com/users/egavrin/followers","following_url":"https://api.github.com/users/egavrin/following{/other_user}","gists_url":"https://api.github.com/users/egavrin/gists{/gist_id}","starred_url":"https://api.github.com/users/egavrin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egavrin/subscriptions","organizations_url":"https://api.github.com/users/egavrin/orgs","repos_url":"https://api.github.com/users/egavrin/repos","events_url":"https://api.github.com/users/egavrin/events{/privacy}","received_events_url":"https://api.github.com/users/egavrin/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":41,"state":"open","created_at":"2015-07-01T13:22:04Z","updated_at":"2015-09-08T16:24:23Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Samsung/jerryscript/pulls/616/commits","review_comments_url":"https://api.github.com/repos/Samsung/jerryscript/pulls/616/comments","review_comment_url":"https://api.github.com/repos/Samsung/jerryscript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Samsung/jerryscript/issues/616/comments","statuses_url":"https://api.github.com/repos/Samsung/jerryscript/statuses/4994ca4ce80793e05d594595b623992c676216c8","head":{"label":"dbatyai:utf8_to_cesu8","ref":"utf8_to_cesu8","sha":"4994ca4ce80793e05d594595b623992c676216c8","user":{"login":"dbatyai","id":12066566,"avatar_url":"https://avatars.githubusercontent.com/u/12066566?v=3","gravatar_id":"","url":"https://api.github.com/users/dbatyai","html_url":"https://github.com/dbatyai","followers_url":"https://api.github.com/users/dbatyai/followers","following_url":"https://api.github.com/users/dbatyai/following{/other_user}","gists_url":"https://api.github.com/users/dbatyai/gists{/gist_id}","starred_url":"https://api.github.com/users/dbatyai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbatyai/subscriptions","organizations_url":"https://api.github.com/users/dbatyai/orgs","repos_url":"https://api.github.com/users/dbatyai/repos","events_url":"https://api.github.com/users/dbatyai/events{/privacy}","received_events_url":"https://api.github.com/users/dbatyai/received_events","type":"User","site_admin":false},"repo":{"id":38420571,"name":"jerryscript","full_name":"dbatyai/jerryscript","owner":{"login":"dbatyai","id":12066566,"avatar_url":"https://avatars.githubusercontent.com/u/12066566?v=3","gravatar_id":"","url":"https://api.github.com/users/dbatyai","html_url":"https://github.com/dbatyai","followers_url":"https://api.github.com/users/dbatyai/followers","following_url":"https://api.github.com/users/dbatyai/following{/other_user}","gists_url":"https://api.github.com/users/dbatyai/gists{/gist_id}","starred_url":"https://api.github.com/users/dbatyai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbatyai/subscriptions","organizations_url":"https://api.github.com/users/dbatyai/orgs","repos_url":"https://api.github.com/users/dbatyai/repos","events_url":"https://api.github.com/users/dbatyai/events{/privacy}","received_events_url":"https://api.github.com/users/dbatyai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dbatyai/jerryscript","description":"","fork":true,"url":"https://api.github.com/repos/dbatyai/jerryscript","forks_url":"https://api.github.com/repos/dbatyai/jerryscript/forks","keys_url":"https://api.github.com/repos/dbatyai/jerryscript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dbatyai/jerryscript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dbatyai/jerryscript/teams","hooks_url":"https://api.github.com/repos/dbatyai/jerryscript/hooks","issue_events_url":"https://api.github.com/repos/dbatyai/jerryscript/issues/events{/number}","events_url":"https://api.github.com/repos/dbatyai/jerryscript/events","assignees_url":"https://api.github.com/repos/dbatyai/jerryscript/assignees{/user}","branches_url":"https://api.github.com/repos/dbatyai/jerryscript/branches{/branch}","tags_url":"https://api.github.com/repos/dbatyai/jerryscript/tags","blobs_url":"https://api.github.com/repos/dbatyai/jerryscript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dbatyai/jerryscript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dbatyai/jerryscript/git/refs{/sha}","trees_url":"https://api.github.com/repos/dbatyai/jerryscript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dbatyai/jerryscript/statuses/{sha}","languages_url":"https://api.github.com/repos/dbatyai/jerryscript/languages","stargazers_url":"https://api.github.com/repos/dbatyai/jerryscript/stargazers","contributors_url":"https://api.github.com/repos/dbatyai/jerryscript/contributors","subscribers_url":"https://api.github.com/repos/dbatyai/jerryscript/subscribers","subscription_url":"https://api.github.com/repos/dbatyai/jerryscript/subscription","commits_url":"https://api.github.com/repos/dbatyai/jerryscript/commits{/sha}","git_commits_url":"https://api.github.com/repos/dbatyai/jerryscript/git/commits{/sha}","comments_url":"https://api.github.com/repos/dbatyai/jerryscript/comments{/number}","issue_comment_url":"https://api.github.com/repos/dbatyai/jerryscript/issues/comments{/number}","contents_url":"https://api.github.com/repos/dbatyai/jerryscript/contents/{+path}","compare_url":"https://api.github.com/repos/dbatyai/jerryscript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dbatyai/jerryscript/merges","archive_url":"https://api.github.com/repos/dbatyai/jerryscript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dbatyai/jerryscript/downloads","issues_url":"https://api.github.com/repos/dbatyai/jerryscript/issues{/number}","pulls_url":"https://api.github.com/repos/dbatyai/jerryscript/pulls{/number}","milestones_url":"https://api.github.com/repos/dbatyai/jerryscript/milestones{/number}","notifications_url":"https://api.github.com/repos/dbatyai/jerryscript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dbatyai/jerryscript/labels{/name}","releases_url":"https://api.github.com/repos/dbatyai/jerryscript/releases{/id}","created_at":"2015-07-02T08:27:55Z","updated_at":"2015-07-02T08:27:58Z","pushed_at":"2015-09-17T13:08:19Z","git_url":"git://github.com/dbatyai/jerryscript.git","ssh_url":"git@github.com:dbatyai/jerryscript.git","clone_url":"https://github.com/dbatyai/jerryscript.git","svn_url":"https://github.com/dbatyai/jerryscript","homepage":null,"size":4717,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Samsung:master","ref":"master","sha":"66975236bc42fdfcfcb74b6996601c1401f2b62e","user":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars.githubusercontent.com/u/6210390?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"repo":{"id":33339660,"name":"jerryscript","full_name":"Samsung/jerryscript","owner":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars.githubusercontent.com/u/6210390?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Samsung/jerryscript","description":"Ultra-lightweight JavaScript engine for Internet of Things. http://www.jerryscript.net","fork":false,"url":"https://api.github.com/repos/Samsung/jerryscript","forks_url":"https://api.github.com/repos/Samsung/jerryscript/forks","keys_url":"https://api.github.com/repos/Samsung/jerryscript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Samsung/jerryscript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Samsung/jerryscript/teams","hooks_url":"https://api.github.com/repos/Samsung/jerryscript/hooks","issue_events_url":"https://api.github.com/repos/Samsung/jerryscript/issues/events{/number}","events_url":"https://api.github.com/repos/Samsung/jerryscript/events","assignees_url":"https://api.github.com/repos/Samsung/jerryscript/assignees{/user}","branches_url":"https://api.github.com/repos/Samsung/jerryscript/branches{/branch}","tags_url":"https://api.github.com/repos/Samsung/jerryscript/tags","blobs_url":"https://api.github.com/repos/Samsung/jerryscript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Samsung/jerryscript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Samsung/jerryscript/git/refs{/sha}","trees_url":"https://api.github.com/repos/Samsung/jerryscript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Samsung/jerryscript/statuses/{sha}","languages_url":"https://api.github.com/repos/Samsung/jerryscript/languages","stargazers_url":"https://api.github.com/repos/Samsung/jerryscript/stargazers","contributors_url":"https://api.github.com/repos/Samsung/jerryscript/contributors","subscribers_url":"https://api.github.com/repos/Samsung/jerryscript/subscribers","subscription_url":"https://api.github.com/repos/Samsung/jerryscript/subscription","commits_url":"https://api.github.com/repos/Samsung/jerryscript/commits{/sha}","git_commits_url":"https://api.github.com/repos/Samsung/jerryscript/git/commits{/sha}","comments_url":"https://api.github.com/repos/Samsung/jerryscript/comments{/number}","issue_comment_url":"https://api.github.com/repos/Samsung/jerryscript/issues/comments{/number}","contents_url":"https://api.github.com/repos/Samsung/jerryscript/contents/{+path}","compare_url":"https://api.github.com/repos/Samsung/jerryscript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Samsung/jerryscript/merges","archive_url":"https://api.github.com/repos/Samsung/jerryscript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Samsung/jerryscript/downloads","issues_url":"https://api.github.com/repos/Samsung/jerryscript/issues{/number}","pulls_url":"https://api.github.com/repos/Samsung/jerryscript/pulls{/number}","milestones_url":"https://api.github.com/repos/Samsung/jerryscript/milestones{/number}","notifications_url":"https://api.github.com/repos/Samsung/jerryscript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Samsung/jerryscript/labels{/name}","releases_url":"https://api.github.com/repos/Samsung/jerryscript/releases{/id}","created_at":"2015-04-03T01:10:31Z","updated_at":"2015-09-18T04:12:27Z","pushed_at":"2015-09-18T02:18:08Z","git_url":"git://github.com/Samsung/jerryscript.git","ssh_url":"git@github.com:Samsung/jerryscript.git","clone_url":"https://github.com/Samsung/jerryscript.git","svn_url":"https://github.com/Samsung/jerryscript","homepage":"","size":13117,"stargazers_count":952,"watchers_count":952,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":69,"mirror_url":null,"open_issues_count":98,"forks":69,"open_issues":98,"watchers":952,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Samsung/jerryscript/pulls/616"},"html":{"href":"https://github.com/Samsung/jerryscript/pull/616"},"issue":{"href":"https://api.github.com/repos/Samsung/jerryscript/issues/616"},"comments":{"href":"https://api.github.com/repos/Samsung/jerryscript/issues/616/comments"},"review_comments":{"href":"https://api.github.com/repos/Samsung/jerryscript/pulls/616/comments"},"review_comment":{"href":"https://api.github.com/repos/Samsung/jerryscript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Samsung/jerryscript/pulls/616/commits"},"statuses":{"href":"https://api.github.com/repos/Samsung/jerryscript/statuses/4994ca4ce80793e05d594595b623992c676216c8"}}}}