{"action":"created","issue":{"url":"https://api.github.com/repos/gjb2048/moodle-theme_essential/issues/534","labels_url":"https://api.github.com/repos/gjb2048/moodle-theme_essential/issues/534/labels{/name}","comments_url":"https://api.github.com/repos/gjb2048/moodle-theme_essential/issues/534/comments","events_url":"https://api.github.com/repos/gjb2048/moodle-theme_essential/issues/534/events","html_url":"https://github.com/gjb2048/moodle-theme_essential/issues/534","id":106029098,"number":534,"title":"[[setting:abc]] variables are not processed when they are in customcss settings - fix attached","user":{"login":"relecand","id":5286499,"avatar_url":"https://avatars.githubusercontent.com/u/5286499?v=3","gravatar_id":"","url":"https://api.github.com/users/relecand","html_url":"https://github.com/relecand","followers_url":"https://api.github.com/users/relecand/followers","following_url":"https://api.github.com/users/relecand/following{/other_user}","gists_url":"https://api.github.com/users/relecand/gists{/gist_id}","starred_url":"https://api.github.com/users/relecand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/relecand/subscriptions","organizations_url":"https://api.github.com/users/relecand/orgs","repos_url":"https://api.github.com/users/relecand/repos","events_url":"https://api.github.com/users/relecand/events{/privacy}","received_events_url":"https://api.github.com/users/relecand/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/gjb2048/moodle-theme_essential/labels/Not%20a%20bug","name":"Not a bug","color":"d4c5f9"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-11T15:08:24Z","updated_at":"2015-09-11T16:23:43Z","closed_at":"2015-09-11T15:42:58Z","body":"[[setting:abc]] variables are not processed when they are in customcss settings.\r\n\r\n**Fix**\r\n\r\nIn: lib.php lines 328-330 \r\n```\r\n// Set custom CSS.\r\n$customcss = \\theme_essential\\toolbox::get_setting('customcss');\r\n$css = theme_essential_set_customcss($css, $customcss);\r\n```\r\nmove to: lib.php lines 222-224 \r\n\r\nI don't know the reason for not processing the customcss, but if it is ok I would create a pull request. \r\n"},"comment":{"url":"https://api.github.com/repos/gjb2048/moodle-theme_essential/issues/comments/139590759","html_url":"https://github.com/gjb2048/moodle-theme_essential/issues/534#issuecomment-139590759","issue_url":"https://api.github.com/repos/gjb2048/moodle-theme_essential/issues/534","id":139590759,"user":{"login":"relecand","id":5286499,"avatar_url":"https://avatars.githubusercontent.com/u/5286499?v=3","gravatar_id":"","url":"https://api.github.com/users/relecand","html_url":"https://github.com/relecand","followers_url":"https://api.github.com/users/relecand/followers","following_url":"https://api.github.com/users/relecand/following{/other_user}","gists_url":"https://api.github.com/users/relecand/gists{/gist_id}","starred_url":"https://api.github.com/users/relecand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/relecand/subscriptions","organizations_url":"https://api.github.com/users/relecand/orgs","repos_url":"https://api.github.com/users/relecand/repos","events_url":"https://api.github.com/users/relecand/events{/privacy}","received_events_url":"https://api.github.com/users/relecand/received_events","type":"User","site_admin":false},"created_at":"2015-09-11T16:23:43Z","updated_at":"2015-09-11T16:23:43Z","body":"\"... or any other theme\": BCU Theme ( https://moodle.org/plugins/view/theme_bcu ) does process [[setting:abc]] variables from the 'Custom CSS' box of the user interface. \r\n\r\nThe advantage is: If you are a moodle admin without access to the server then you define your css in the Custom CSS box. \"[[setting:abc]]\" usage in Custom CSS box makes it more dynamic: when you change the setting \"abc\" you don't have to do this in the custom css again. \r\n\r\n"}}