{"action":"closed","number":1228,"pull_request":{"url":"https://api.github.com/repos/sass/libsass/pulls/1228","id":35837927,"html_url":"https://github.com/sass/libsass/pull/1228","diff_url":"https://github.com/sass/libsass/pull/1228.diff","patch_url":"https://github.com/sass/libsass/pull/1228.patch","issue_url":"https://api.github.com/repos/sass/libsass/issues/1228","number":1228,"state":"closed","locked":false,"title":"ctx.add_source parameter order corrected.","user":{"login":"tristanlins","id":343404,"avatar_url":"https://avatars.githubusercontent.com/u/343404?v=3","gravatar_id":"","url":"https://api.github.com/users/tristanlins","html_url":"https://github.com/tristanlins","followers_url":"https://api.github.com/users/tristanlins/followers","following_url":"https://api.github.com/users/tristanlins/following{/other_user}","gists_url":"https://api.github.com/users/tristanlins/gists{/gist_id}","starred_url":"https://api.github.com/users/tristanlins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tristanlins/subscriptions","organizations_url":"https://api.github.com/users/tristanlins/orgs","repos_url":"https://api.github.com/users/tristanlins/repos","events_url":"https://api.github.com/users/tristanlins/events{/privacy}","received_events_url":"https://api.github.com/users/tristanlins/received_events","type":"User","site_admin":false},"body":"In `context.cpp` the method add_source has this signature: `Context::add_source(string load_path, string abs_path, ...)`\r\n\r\nBut the call was `ctx.add_source(file, load_path, source);`.\r\n\r\nI would expect the correct call is `ctx.add_source(load_path, file, source);`. Unfortunally this call run into memory violations... but changing to `ctx.add_source(file, file, source);` fix some source map generation issues with custom imports.\r\n","created_at":"2015-05-20T14:32:55Z","updated_at":"2015-07-16T02:50:46Z","closed_at":"2015-07-16T02:50:46Z","merged_at":null,"merge_commit_sha":"aec960237ca0c7cc491fbfa339d7cea00c1b3b18","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sass/libsass/pulls/1228/commits","review_comments_url":"https://api.github.com/repos/sass/libsass/pulls/1228/comments","review_comment_url":"https://api.github.com/repos/sass/libsass/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sass/libsass/issues/1228/comments","statuses_url":"https://api.github.com/repos/sass/libsass/statuses/79e6995bda97ed11933274816ee03316003ca727","head":{"label":"tristanlins:hotfix/add-source-parameter-order","ref":"hotfix/add-source-parameter-order","sha":"79e6995bda97ed11933274816ee03316003ca727","user":{"login":"tristanlins","id":343404,"avatar_url":"https://avatars.githubusercontent.com/u/343404?v=3","gravatar_id":"","url":"https://api.github.com/users/tristanlins","html_url":"https://github.com/tristanlins","followers_url":"https://api.github.com/users/tristanlins/followers","following_url":"https://api.github.com/users/tristanlins/following{/other_user}","gists_url":"https://api.github.com/users/tristanlins/gists{/gist_id}","starred_url":"https://api.github.com/users/tristanlins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tristanlins/subscriptions","organizations_url":"https://api.github.com/users/tristanlins/orgs","repos_url":"https://api.github.com/users/tristanlins/repos","events_url":"https://api.github.com/users/tristanlins/events{/privacy}","received_events_url":"https://api.github.com/users/tristanlins/received_events","type":"User","site_admin":false},"repo":{"id":35882947,"name":"libsass","full_name":"tristanlins/libsass","owner":{"login":"tristanlins","id":343404,"avatar_url":"https://avatars.githubusercontent.com/u/343404?v=3","gravatar_id":"","url":"https://api.github.com/users/tristanlins","html_url":"https://github.com/tristanlins","followers_url":"https://api.github.com/users/tristanlins/followers","following_url":"https://api.github.com/users/tristanlins/following{/other_user}","gists_url":"https://api.github.com/users/tristanlins/gists{/gist_id}","starred_url":"https://api.github.com/users/tristanlins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tristanlins/subscriptions","organizations_url":"https://api.github.com/users/tristanlins/orgs","repos_url":"https://api.github.com/users/tristanlins/repos","events_url":"https://api.github.com/users/tristanlins/events{/privacy}","received_events_url":"https://api.github.com/users/tristanlins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tristanlins/libsass","description":"A C/C++ implementation of a Sass compiler","fork":true,"url":"https://api.github.com/repos/tristanlins/libsass","forks_url":"https://api.github.com/repos/tristanlins/libsass/forks","keys_url":"https://api.github.com/repos/tristanlins/libsass/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tristanlins/libsass/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tristanlins/libsass/teams","hooks_url":"https://api.github.com/repos/tristanlins/libsass/hooks","issue_events_url":"https://api.github.com/repos/tristanlins/libsass/issues/events{/number}","events_url":"https://api.github.com/repos/tristanlins/libsass/events","assignees_url":"https://api.github.com/repos/tristanlins/libsass/assignees{/user}","branches_url":"https://api.github.com/repos/tristanlins/libsass/branches{/branch}","tags_url":"https://api.github.com/repos/tristanlins/libsass/tags","blobs_url":"https://api.github.com/repos/tristanlins/libsass/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tristanlins/libsass/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tristanlins/libsass/git/refs{/sha}","trees_url":"https://api.github.com/repos/tristanlins/libsass/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tristanlins/libsass/statuses/{sha}","languages_url":"https://api.github.com/repos/tristanlins/libsass/languages","stargazers_url":"https://api.github.com/repos/tristanlins/libsass/stargazers","contributors_url":"https://api.github.com/repos/tristanlins/libsass/contributors","subscribers_url":"https://api.github.com/repos/tristanlins/libsass/subscribers","subscription_url":"https://api.github.com/repos/tristanlins/libsass/subscription","commits_url":"https://api.github.com/repos/tristanlins/libsass/commits{/sha}","git_commits_url":"https://api.github.com/repos/tristanlins/libsass/git/commits{/sha}","comments_url":"https://api.github.com/repos/tristanlins/libsass/comments{/number}","issue_comment_url":"https://api.github.com/repos/tristanlins/libsass/issues/comments{/number}","contents_url":"https://api.github.com/repos/tristanlins/libsass/contents/{+path}","compare_url":"https://api.github.com/repos/tristanlins/libsass/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tristanlins/libsass/merges","archive_url":"https://api.github.com/repos/tristanlins/libsass/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tristanlins/libsass/downloads","issues_url":"https://api.github.com/repos/tristanlins/libsass/issues{/number}","pulls_url":"https://api.github.com/repos/tristanlins/libsass/pulls{/number}","milestones_url":"https://api.github.com/repos/tristanlins/libsass/milestones{/number}","notifications_url":"https://api.github.com/repos/tristanlins/libsass/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tristanlins/libsass/labels{/name}","releases_url":"https://api.github.com/repos/tristanlins/libsass/releases{/id}","created_at":"2015-05-19T13:14:10Z","updated_at":"2015-05-19T13:14:11Z","pushed_at":"2015-06-06T05:42:56Z","git_url":"git://github.com/tristanlins/libsass.git","ssh_url":"git@github.com:tristanlins/libsass.git","clone_url":"https://github.com/tristanlins/libsass.git","svn_url":"https://github.com/tristanlins/libsass","homepage":"http://libsass.org","size":7668,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sass:master","ref":"master","sha":"221d7fb8db51fa85010323c26e08500f1ee180c2","user":{"login":"sass","id":317889,"avatar_url":"https://avatars.githubusercontent.com/u/317889?v=3","gravatar_id":"","url":"https://api.github.com/users/sass","html_url":"https://github.com/sass","followers_url":"https://api.github.com/users/sass/followers","following_url":"https://api.github.com/users/sass/following{/other_user}","gists_url":"https://api.github.com/users/sass/gists{/gist_id}","starred_url":"https://api.github.com/users/sass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sass/subscriptions","organizations_url":"https://api.github.com/users/sass/orgs","repos_url":"https://api.github.com/users/sass/repos","events_url":"https://api.github.com/users/sass/events{/privacy}","received_events_url":"https://api.github.com/users/sass/received_events","type":"Organization","site_admin":false},"repo":{"id":3319769,"name":"libsass","full_name":"sass/libsass","owner":{"login":"sass","id":317889,"avatar_url":"https://avatars.githubusercontent.com/u/317889?v=3","gravatar_id":"","url":"https://api.github.com/users/sass","html_url":"https://github.com/sass","followers_url":"https://api.github.com/users/sass/followers","following_url":"https://api.github.com/users/sass/following{/other_user}","gists_url":"https://api.github.com/users/sass/gists{/gist_id}","starred_url":"https://api.github.com/users/sass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sass/subscriptions","organizations_url":"https://api.github.com/users/sass/orgs","repos_url":"https://api.github.com/users/sass/repos","events_url":"https://api.github.com/users/sass/events{/privacy}","received_events_url":"https://api.github.com/users/sass/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sass/libsass","description":"A C/C++ implementation of a Sass compiler","fork":false,"url":"https://api.github.com/repos/sass/libsass","forks_url":"https://api.github.com/repos/sass/libsass/forks","keys_url":"https://api.github.com/repos/sass/libsass/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sass/libsass/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sass/libsass/teams","hooks_url":"https://api.github.com/repos/sass/libsass/hooks","issue_events_url":"https://api.github.com/repos/sass/libsass/issues/events{/number}","events_url":"https://api.github.com/repos/sass/libsass/events","assignees_url":"https://api.github.com/repos/sass/libsass/assignees{/user}","branches_url":"https://api.github.com/repos/sass/libsass/branches{/branch}","tags_url":"https://api.github.com/repos/sass/libsass/tags","blobs_url":"https://api.github.com/repos/sass/libsass/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sass/libsass/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sass/libsass/git/refs{/sha}","trees_url":"https://api.github.com/repos/sass/libsass/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sass/libsass/statuses/{sha}","languages_url":"https://api.github.com/repos/sass/libsass/languages","stargazers_url":"https://api.github.com/repos/sass/libsass/stargazers","contributors_url":"https://api.github.com/repos/sass/libsass/contributors","subscribers_url":"https://api.github.com/repos/sass/libsass/subscribers","subscription_url":"https://api.github.com/repos/sass/libsass/subscription","commits_url":"https://api.github.com/repos/sass/libsass/commits{/sha}","git_commits_url":"https://api.github.com/repos/sass/libsass/git/commits{/sha}","comments_url":"https://api.github.com/repos/sass/libsass/comments{/number}","issue_comment_url":"https://api.github.com/repos/sass/libsass/issues/comments{/number}","contents_url":"https://api.github.com/repos/sass/libsass/contents/{+path}","compare_url":"https://api.github.com/repos/sass/libsass/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sass/libsass/merges","archive_url":"https://api.github.com/repos/sass/libsass/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sass/libsass/downloads","issues_url":"https://api.github.com/repos/sass/libsass/issues{/number}","pulls_url":"https://api.github.com/repos/sass/libsass/pulls{/number}","milestones_url":"https://api.github.com/repos/sass/libsass/milestones{/number}","notifications_url":"https://api.github.com/repos/sass/libsass/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sass/libsass/labels{/name}","releases_url":"https://api.github.com/repos/sass/libsass/releases{/id}","created_at":"2012-01-31T22:59:07Z","updated_at":"2015-07-15T20:49:17Z","pushed_at":"2015-07-16T01:23:39Z","git_url":"git://github.com/sass/libsass.git","ssh_url":"git@github.com:sass/libsass.git","clone_url":"https://github.com/sass/libsass.git","svn_url":"https://github.com/sass/libsass","homepage":"http://libsass.org","size":19684,"stargazers_count":2503,"watchers_count":2503,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":271,"mirror_url":null,"open_issues_count":58,"forks":271,"open_issues":58,"watchers":2503,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sass/libsass/pulls/1228"},"html":{"href":"https://github.com/sass/libsass/pull/1228"},"issue":{"href":"https://api.github.com/repos/sass/libsass/issues/1228"},"comments":{"href":"https://api.github.com/repos/sass/libsass/issues/1228/comments"},"review_comments":{"href":"https://api.github.com/repos/sass/libsass/pulls/1228/comments"},"review_comment":{"href":"https://api.github.com/repos/sass/libsass/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sass/libsass/pulls/1228/commits"},"statuses":{"href":"https://api.github.com/repos/sass/libsass/statuses/79e6995bda97ed11933274816ee03316003ca727"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":6,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}