{"action":"created","comment":{"url":"https://api.github.com/repos/endaga/openbts-python/pulls/comments/25897373","id":25897373,"diff_hunk":"@@ -359,6 +359,18 @@ def test_update_nonexistent_subscriber_by_imsi(self):\n     self.assertTrue(self.sipauthserve_connection.socket.recv.called)\n     self.assertEqual(response.code, SuccessCode.OK)\n \n+  def test_delete_subscriber_when_sqlite_unavailable(self):\n+    \"\"\"Testing the subscriber deletion case when OpenBTS reports sqlite is unavailble\"\"\"\n+    self.sipauthserve_connection.socket.recv.return_value = json.dumps({\n+      'code': 503,\n+      'data': { 'sip_buddies': 'something bad',","path":"openbts/tests/sipauthserve_component_tests.py","position":8,"original_position":8,"commit_id":"3a23ef4f29c7d41614629cef0dbcc774f9eff48e","original_commit_id":"3a23ef4f29c7d41614629cef0dbcc774f9eff48e","user":{"login":"kkroo","id":1845185,"avatar_url":"https://avatars.githubusercontent.com/u/1845185?v=3","gravatar_id":"","url":"https://api.github.com/users/kkroo","html_url":"https://github.com/kkroo","followers_url":"https://api.github.com/users/kkroo/followers","following_url":"https://api.github.com/users/kkroo/following{/other_user}","gists_url":"https://api.github.com/users/kkroo/gists{/gist_id}","starred_url":"https://api.github.com/users/kkroo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkroo/subscriptions","organizations_url":"https://api.github.com/users/kkroo/orgs","repos_url":"https://api.github.com/users/kkroo/repos","events_url":"https://api.github.com/users/kkroo/events{/privacy}","received_events_url":"https://api.github.com/users/kkroo/received_events","type":"User","site_admin":false},"body":"This goes back to [https://github.com/RangeNetworks/NodeManager/blob/master/JSONDB/JSONDB.cpp#L285}(how NodeManager handles unsubscription). Since it removes the entries from both sip_buddies and  dialdata_table, it gives you the aggregate operation results in the response. Normally if both succeed it just says \"both ok\". In the even that one fails, it gives you the individual results for each of the queries. Point is, it allows you to know which of the individual delete operations failed. ","created_at":"2015-03-05T20:13:08Z","updated_at":"2015-03-05T20:13:08Z","html_url":"https://github.com/endaga/openbts-python/pull/2#discussion_r25897373","pull_request_url":"https://api.github.com/repos/endaga/openbts-python/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/endaga/openbts-python/pulls/comments/25897373"},"html":{"href":"https://github.com/endaga/openbts-python/pull/2#discussion_r25897373"},"pull_request":{"href":"https://api.github.com/repos/endaga/openbts-python/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/endaga/openbts-python/pulls/2","id":30590245,"html_url":"https://github.com/endaga/openbts-python/pull/2","diff_url":"https://github.com/endaga/openbts-python/pull/2.diff","patch_url":"https://github.com/endaga/openbts-python/pull/2.patch","issue_url":"https://api.github.com/repos/endaga/openbts-python/issues/2","number":2,"state":"open","locked":false,"title":"adding tests for delete subscriber","user":{"login":"kkroo","id":1845185,"avatar_url":"https://avatars.githubusercontent.com/u/1845185?v=3","gravatar_id":"","url":"https://api.github.com/users/kkroo","html_url":"https://github.com/kkroo","followers_url":"https://api.github.com/users/kkroo/followers","following_url":"https://api.github.com/users/kkroo/following{/other_user}","gists_url":"https://api.github.com/users/kkroo/gists{/gist_id}","starred_url":"https://api.github.com/users/kkroo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkroo/subscriptions","organizations_url":"https://api.github.com/users/kkroo/orgs","repos_url":"https://api.github.com/users/kkroo/repos","events_url":"https://api.github.com/users/kkroo/events{/privacy}","received_events_url":"https://api.github.com/users/kkroo/received_events","type":"User","site_admin":false},"body":"This puts in a test for deleting subscribers when sqlite is unavailable for some reason","created_at":"2015-03-05T20:01:18Z","updated_at":"2015-03-05T20:13:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cbefb07a302a9fcf2d48abe37f5e12b8935bffda","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/endaga/openbts-python/pulls/2/commits","review_comments_url":"https://api.github.com/repos/endaga/openbts-python/pulls/2/comments","review_comment_url":"https://api.github.com/repos/endaga/openbts-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/endaga/openbts-python/issues/2/comments","statuses_url":"https://api.github.com/repos/endaga/openbts-python/statuses/3a23ef4f29c7d41614629cef0dbcc774f9eff48e","head":{"label":"endaga:test_delete_subscriber","ref":"test_delete_subscriber","sha":"3a23ef4f29c7d41614629cef0dbcc774f9eff48e","user":{"login":"endaga","id":6866146,"avatar_url":"https://avatars.githubusercontent.com/u/6866146?v=3","gravatar_id":"","url":"https://api.github.com/users/endaga","html_url":"https://github.com/endaga","followers_url":"https://api.github.com/users/endaga/followers","following_url":"https://api.github.com/users/endaga/following{/other_user}","gists_url":"https://api.github.com/users/endaga/gists{/gist_id}","starred_url":"https://api.github.com/users/endaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endaga/subscriptions","organizations_url":"https://api.github.com/users/endaga/orgs","repos_url":"https://api.github.com/users/endaga/repos","events_url":"https://api.github.com/users/endaga/events{/privacy}","received_events_url":"https://api.github.com/users/endaga/received_events","type":"Organization","site_admin":false},"repo":{"id":28769806,"name":"openbts-python","full_name":"endaga/openbts-python","owner":{"login":"endaga","id":6866146,"avatar_url":"https://avatars.githubusercontent.com/u/6866146?v=3","gravatar_id":"","url":"https://api.github.com/users/endaga","html_url":"https://github.com/endaga","followers_url":"https://api.github.com/users/endaga/followers","following_url":"https://api.github.com/users/endaga/following{/other_user}","gists_url":"https://api.github.com/users/endaga/gists{/gist_id}","starred_url":"https://api.github.com/users/endaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endaga/subscriptions","organizations_url":"https://api.github.com/users/endaga/orgs","repos_url":"https://api.github.com/users/endaga/repos","events_url":"https://api.github.com/users/endaga/events{/privacy}","received_events_url":"https://api.github.com/users/endaga/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endaga/openbts-python","description":"python client for OpenBTS","fork":true,"url":"https://api.github.com/repos/endaga/openbts-python","forks_url":"https://api.github.com/repos/endaga/openbts-python/forks","keys_url":"https://api.github.com/repos/endaga/openbts-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endaga/openbts-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endaga/openbts-python/teams","hooks_url":"https://api.github.com/repos/endaga/openbts-python/hooks","issue_events_url":"https://api.github.com/repos/endaga/openbts-python/issues/events{/number}","events_url":"https://api.github.com/repos/endaga/openbts-python/events","assignees_url":"https://api.github.com/repos/endaga/openbts-python/assignees{/user}","branches_url":"https://api.github.com/repos/endaga/openbts-python/branches{/branch}","tags_url":"https://api.github.com/repos/endaga/openbts-python/tags","blobs_url":"https://api.github.com/repos/endaga/openbts-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endaga/openbts-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endaga/openbts-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/endaga/openbts-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endaga/openbts-python/statuses/{sha}","languages_url":"https://api.github.com/repos/endaga/openbts-python/languages","stargazers_url":"https://api.github.com/repos/endaga/openbts-python/stargazers","contributors_url":"https://api.github.com/repos/endaga/openbts-python/contributors","subscribers_url":"https://api.github.com/repos/endaga/openbts-python/subscribers","subscription_url":"https://api.github.com/repos/endaga/openbts-python/subscription","commits_url":"https://api.github.com/repos/endaga/openbts-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/endaga/openbts-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/endaga/openbts-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/endaga/openbts-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/endaga/openbts-python/contents/{+path}","compare_url":"https://api.github.com/repos/endaga/openbts-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endaga/openbts-python/merges","archive_url":"https://api.github.com/repos/endaga/openbts-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endaga/openbts-python/downloads","issues_url":"https://api.github.com/repos/endaga/openbts-python/issues{/number}","pulls_url":"https://api.github.com/repos/endaga/openbts-python/pulls{/number}","milestones_url":"https://api.github.com/repos/endaga/openbts-python/milestones{/number}","notifications_url":"https://api.github.com/repos/endaga/openbts-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endaga/openbts-python/labels{/name}","releases_url":"https://api.github.com/repos/endaga/openbts-python/releases{/id}","created_at":"2015-01-04T09:13:47Z","updated_at":"2015-01-29T06:42:27Z","pushed_at":"2015-03-05T19:57:58Z","git_url":"git://github.com/endaga/openbts-python.git","ssh_url":"git@github.com:endaga/openbts-python.git","clone_url":"https://github.com/endaga/openbts-python.git","svn_url":"https://github.com/endaga/openbts-python","homepage":"http://openbts.org/documentation/","size":244,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"endaga:master","ref":"master","sha":"5dae4408ecbacee6d19e5979b1d24d8c89cd393a","user":{"login":"endaga","id":6866146,"avatar_url":"https://avatars.githubusercontent.com/u/6866146?v=3","gravatar_id":"","url":"https://api.github.com/users/endaga","html_url":"https://github.com/endaga","followers_url":"https://api.github.com/users/endaga/followers","following_url":"https://api.github.com/users/endaga/following{/other_user}","gists_url":"https://api.github.com/users/endaga/gists{/gist_id}","starred_url":"https://api.github.com/users/endaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endaga/subscriptions","organizations_url":"https://api.github.com/users/endaga/orgs","repos_url":"https://api.github.com/users/endaga/repos","events_url":"https://api.github.com/users/endaga/events{/privacy}","received_events_url":"https://api.github.com/users/endaga/received_events","type":"Organization","site_admin":false},"repo":{"id":28769806,"name":"openbts-python","full_name":"endaga/openbts-python","owner":{"login":"endaga","id":6866146,"avatar_url":"https://avatars.githubusercontent.com/u/6866146?v=3","gravatar_id":"","url":"https://api.github.com/users/endaga","html_url":"https://github.com/endaga","followers_url":"https://api.github.com/users/endaga/followers","following_url":"https://api.github.com/users/endaga/following{/other_user}","gists_url":"https://api.github.com/users/endaga/gists{/gist_id}","starred_url":"https://api.github.com/users/endaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endaga/subscriptions","organizations_url":"https://api.github.com/users/endaga/orgs","repos_url":"https://api.github.com/users/endaga/repos","events_url":"https://api.github.com/users/endaga/events{/privacy}","received_events_url":"https://api.github.com/users/endaga/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endaga/openbts-python","description":"python client for OpenBTS","fork":true,"url":"https://api.github.com/repos/endaga/openbts-python","forks_url":"https://api.github.com/repos/endaga/openbts-python/forks","keys_url":"https://api.github.com/repos/endaga/openbts-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endaga/openbts-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endaga/openbts-python/teams","hooks_url":"https://api.github.com/repos/endaga/openbts-python/hooks","issue_events_url":"https://api.github.com/repos/endaga/openbts-python/issues/events{/number}","events_url":"https://api.github.com/repos/endaga/openbts-python/events","assignees_url":"https://api.github.com/repos/endaga/openbts-python/assignees{/user}","branches_url":"https://api.github.com/repos/endaga/openbts-python/branches{/branch}","tags_url":"https://api.github.com/repos/endaga/openbts-python/tags","blobs_url":"https://api.github.com/repos/endaga/openbts-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endaga/openbts-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endaga/openbts-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/endaga/openbts-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endaga/openbts-python/statuses/{sha}","languages_url":"https://api.github.com/repos/endaga/openbts-python/languages","stargazers_url":"https://api.github.com/repos/endaga/openbts-python/stargazers","contributors_url":"https://api.github.com/repos/endaga/openbts-python/contributors","subscribers_url":"https://api.github.com/repos/endaga/openbts-python/subscribers","subscription_url":"https://api.github.com/repos/endaga/openbts-python/subscription","commits_url":"https://api.github.com/repos/endaga/openbts-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/endaga/openbts-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/endaga/openbts-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/endaga/openbts-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/endaga/openbts-python/contents/{+path}","compare_url":"https://api.github.com/repos/endaga/openbts-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endaga/openbts-python/merges","archive_url":"https://api.github.com/repos/endaga/openbts-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endaga/openbts-python/downloads","issues_url":"https://api.github.com/repos/endaga/openbts-python/issues{/number}","pulls_url":"https://api.github.com/repos/endaga/openbts-python/pulls{/number}","milestones_url":"https://api.github.com/repos/endaga/openbts-python/milestones{/number}","notifications_url":"https://api.github.com/repos/endaga/openbts-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endaga/openbts-python/labels{/name}","releases_url":"https://api.github.com/repos/endaga/openbts-python/releases{/id}","created_at":"2015-01-04T09:13:47Z","updated_at":"2015-01-29T06:42:27Z","pushed_at":"2015-03-05T19:57:58Z","git_url":"git://github.com/endaga/openbts-python.git","ssh_url":"git@github.com:endaga/openbts-python.git","clone_url":"https://github.com/endaga/openbts-python.git","svn_url":"https://github.com/endaga/openbts-python","homepage":"http://openbts.org/documentation/","size":244,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/endaga/openbts-python/pulls/2"},"html":{"href":"https://github.com/endaga/openbts-python/pull/2"},"issue":{"href":"https://api.github.com/repos/endaga/openbts-python/issues/2"},"comments":{"href":"https://api.github.com/repos/endaga/openbts-python/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/endaga/openbts-python/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/endaga/openbts-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/endaga/openbts-python/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/endaga/openbts-python/statuses/3a23ef4f29c7d41614629cef0dbcc774f9eff48e"}}}}