{"action":"created","comment":{"url":"https://api.github.com/repos/venmo/Static/pulls/comments/42805559","id":42805559,"diff_hunk":"@@ -188,11 +187,11 @@ extension DataSource: UITableViewDataSource {\n     }\n \n     public func tableView(tableView: UITableView, heightForRowAtIndexPath indexPath: NSIndexPath) -> CGFloat {\n-        return rowForIndexPath(indexPath)?.height ?? 44\n+        return rowForIndexPath(indexPath)?.height ?? UITableViewAutomaticDimension\n     }\n     \n     public func tableView(tableView: UITableView, estimatedHeightForRowAtIndexPath indexPath: NSIndexPath) -> CGFloat {\n-        return rowForIndexPath(indexPath)?.height ?? 44\n+        return rowForIndexPath(indexPath)?.height ?? UITableViewAutomaticDimension","path":"Static/DataSource.swift","position":23,"original_position":23,"commit_id":"94f183d5ffbbf5148bedabb90abec867208053c9","original_commit_id":"94f183d5ffbbf5148bedabb90abec867208053c9","user":{"login":"dasmer","id":265892,"avatar_url":"https://avatars.githubusercontent.com/u/265892?v=3","gravatar_id":"","url":"https://api.github.com/users/dasmer","html_url":"https://github.com/dasmer","followers_url":"https://api.github.com/users/dasmer/followers","following_url":"https://api.github.com/users/dasmer/following{/other_user}","gists_url":"https://api.github.com/users/dasmer/gists{/gist_id}","starred_url":"https://api.github.com/users/dasmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dasmer/subscriptions","organizations_url":"https://api.github.com/users/dasmer/orgs","repos_url":"https://api.github.com/users/dasmer/repos","events_url":"https://api.github.com/users/dasmer/events{/privacy}","received_events_url":"https://api.github.com/users/dasmer/received_events","type":"User","site_admin":false},"body":"I stand corrected :smile: \r\n\r\nIt still might be a good idea to allow consumers of `Static` to define an `estimatedRowHeight` no?","created_at":"2015-10-22T21:00:31Z","updated_at":"2015-10-22T21:00:31Z","html_url":"https://github.com/venmo/Static/pull/56#discussion_r42805559","pull_request_url":"https://api.github.com/repos/venmo/Static/pulls/56","_links":{"self":{"href":"https://api.github.com/repos/venmo/Static/pulls/comments/42805559"},"html":{"href":"https://github.com/venmo/Static/pull/56#discussion_r42805559"},"pull_request":{"href":"https://api.github.com/repos/venmo/Static/pulls/56"}}},"pull_request":{"url":"https://api.github.com/repos/venmo/Static/pulls/56","id":48509685,"html_url":"https://github.com/venmo/Static/pull/56","diff_url":"https://github.com/venmo/Static/pull/56.diff","patch_url":"https://github.com/venmo/Static/pull/56.patch","issue_url":"https://api.github.com/repos/venmo/Static/issues/56","number":56,"state":"open","locked":false,"title":"Move cellNib declaration to CellType","user":{"login":"hyperspacemark","id":938746,"avatar_url":"https://avatars.githubusercontent.com/u/938746?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperspacemark","html_url":"https://github.com/hyperspacemark","followers_url":"https://api.github.com/users/hyperspacemark/followers","following_url":"https://api.github.com/users/hyperspacemark/following{/other_user}","gists_url":"https://api.github.com/users/hyperspacemark/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperspacemark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperspacemark/subscriptions","organizations_url":"https://api.github.com/users/hyperspacemark/orgs","repos_url":"https://api.github.com/users/hyperspacemark/repos","events_url":"https://api.github.com/users/hyperspacemark/events{/privacy}","received_events_url":"https://api.github.com/users/hyperspacemark/received_events","type":"User","site_admin":false},"body":"Providing an interface builder for a cell is a view concern and is\r\nprovided by a `UITableViewCell` subclass that conforms to `CellType`\r\nand implements the `nib()` method.\r\n\r\n* Remove `cellNib` from `Row`.\r\n* Make `height` non-optional and default to\r\n`UITableViewAutomaticDimension`.\r\n* Add `nib() -> UINib?` method to `CellType`.","created_at":"2015-10-22T20:39:05Z","updated_at":"2015-10-22T21:00:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"222911992fac43f50f05031ea603ed8d081ef33b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/venmo/Static/pulls/56/commits","review_comments_url":"https://api.github.com/repos/venmo/Static/pulls/56/comments","review_comment_url":"https://api.github.com/repos/venmo/Static/pulls/comments{/number}","comments_url":"https://api.github.com/repos/venmo/Static/issues/56/comments","statuses_url":"https://api.github.com/repos/venmo/Static/statuses/94f183d5ffbbf5148bedabb90abec867208053c9","head":{"label":"venmo:ma/move-nib-to-celltype","ref":"ma/move-nib-to-celltype","sha":"94f183d5ffbbf5148bedabb90abec867208053c9","user":{"login":"venmo","id":256998,"avatar_url":"https://avatars.githubusercontent.com/u/256998?v=3","gravatar_id":"","url":"https://api.github.com/users/venmo","html_url":"https://github.com/venmo","followers_url":"https://api.github.com/users/venmo/followers","following_url":"https://api.github.com/users/venmo/following{/other_user}","gists_url":"https://api.github.com/users/venmo/gists{/gist_id}","starred_url":"https://api.github.com/users/venmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/venmo/subscriptions","organizations_url":"https://api.github.com/users/venmo/orgs","repos_url":"https://api.github.com/users/venmo/repos","events_url":"https://api.github.com/users/venmo/events{/privacy}","received_events_url":"https://api.github.com/users/venmo/received_events","type":"Organization","site_admin":false},"repo":{"id":38176891,"name":"Static","full_name":"venmo/Static","owner":{"login":"venmo","id":256998,"avatar_url":"https://avatars.githubusercontent.com/u/256998?v=3","gravatar_id":"","url":"https://api.github.com/users/venmo","html_url":"https://github.com/venmo","followers_url":"https://api.github.com/users/venmo/followers","following_url":"https://api.github.com/users/venmo/following{/other_user}","gists_url":"https://api.github.com/users/venmo/gists{/gist_id}","starred_url":"https://api.github.com/users/venmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/venmo/subscriptions","organizations_url":"https://api.github.com/users/venmo/orgs","repos_url":"https://api.github.com/users/venmo/repos","events_url":"https://api.github.com/users/venmo/events{/privacy}","received_events_url":"https://api.github.com/users/venmo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/venmo/Static","description":"Simple static table views for iOS in Swift.","fork":false,"url":"https://api.github.com/repos/venmo/Static","forks_url":"https://api.github.com/repos/venmo/Static/forks","keys_url":"https://api.github.com/repos/venmo/Static/keys{/key_id}","collaborators_url":"https://api.github.com/repos/venmo/Static/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/venmo/Static/teams","hooks_url":"https://api.github.com/repos/venmo/Static/hooks","issue_events_url":"https://api.github.com/repos/venmo/Static/issues/events{/number}","events_url":"https://api.github.com/repos/venmo/Static/events","assignees_url":"https://api.github.com/repos/venmo/Static/assignees{/user}","branches_url":"https://api.github.com/repos/venmo/Static/branches{/branch}","tags_url":"https://api.github.com/repos/venmo/Static/tags","blobs_url":"https://api.github.com/repos/venmo/Static/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/venmo/Static/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/venmo/Static/git/refs{/sha}","trees_url":"https://api.github.com/repos/venmo/Static/git/trees{/sha}","statuses_url":"https://api.github.com/repos/venmo/Static/statuses/{sha}","languages_url":"https://api.github.com/repos/venmo/Static/languages","stargazers_url":"https://api.github.com/repos/venmo/Static/stargazers","contributors_url":"https://api.github.com/repos/venmo/Static/contributors","subscribers_url":"https://api.github.com/repos/venmo/Static/subscribers","subscription_url":"https://api.github.com/repos/venmo/Static/subscription","commits_url":"https://api.github.com/repos/venmo/Static/commits{/sha}","git_commits_url":"https://api.github.com/repos/venmo/Static/git/commits{/sha}","comments_url":"https://api.github.com/repos/venmo/Static/comments{/number}","issue_comment_url":"https://api.github.com/repos/venmo/Static/issues/comments{/number}","contents_url":"https://api.github.com/repos/venmo/Static/contents/{+path}","compare_url":"https://api.github.com/repos/venmo/Static/compare/{base}...{head}","merges_url":"https://api.github.com/repos/venmo/Static/merges","archive_url":"https://api.github.com/repos/venmo/Static/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/venmo/Static/downloads","issues_url":"https://api.github.com/repos/venmo/Static/issues{/number}","pulls_url":"https://api.github.com/repos/venmo/Static/pulls{/number}","milestones_url":"https://api.github.com/repos/venmo/Static/milestones{/number}","notifications_url":"https://api.github.com/repos/venmo/Static/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/venmo/Static/labels{/name}","releases_url":"https://api.github.com/repos/venmo/Static/releases{/id}","created_at":"2015-06-27T22:00:38Z","updated_at":"2015-10-22T00:25:25Z","pushed_at":"2015-10-22T20:43:48Z","git_url":"git://github.com/venmo/Static.git","ssh_url":"git@github.com:venmo/Static.git","clone_url":"https://github.com/venmo/Static.git","svn_url":"https://github.com/venmo/Static","homepage":"http://blog.soff.es/static","size":820,"stargazers_count":497,"watchers_count":497,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":7,"forks":21,"open_issues":7,"watchers":497,"default_branch":"master"}},"base":{"label":"venmo:master","ref":"master","sha":"67b64c6c5df58b8816b5c30ac49396a73d4a5ddb","user":{"login":"venmo","id":256998,"avatar_url":"https://avatars.githubusercontent.com/u/256998?v=3","gravatar_id":"","url":"https://api.github.com/users/venmo","html_url":"https://github.com/venmo","followers_url":"https://api.github.com/users/venmo/followers","following_url":"https://api.github.com/users/venmo/following{/other_user}","gists_url":"https://api.github.com/users/venmo/gists{/gist_id}","starred_url":"https://api.github.com/users/venmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/venmo/subscriptions","organizations_url":"https://api.github.com/users/venmo/orgs","repos_url":"https://api.github.com/users/venmo/repos","events_url":"https://api.github.com/users/venmo/events{/privacy}","received_events_url":"https://api.github.com/users/venmo/received_events","type":"Organization","site_admin":false},"repo":{"id":38176891,"name":"Static","full_name":"venmo/Static","owner":{"login":"venmo","id":256998,"avatar_url":"https://avatars.githubusercontent.com/u/256998?v=3","gravatar_id":"","url":"https://api.github.com/users/venmo","html_url":"https://github.com/venmo","followers_url":"https://api.github.com/users/venmo/followers","following_url":"https://api.github.com/users/venmo/following{/other_user}","gists_url":"https://api.github.com/users/venmo/gists{/gist_id}","starred_url":"https://api.github.com/users/venmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/venmo/subscriptions","organizations_url":"https://api.github.com/users/venmo/orgs","repos_url":"https://api.github.com/users/venmo/repos","events_url":"https://api.github.com/users/venmo/events{/privacy}","received_events_url":"https://api.github.com/users/venmo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/venmo/Static","description":"Simple static table views for iOS in Swift.","fork":false,"url":"https://api.github.com/repos/venmo/Static","forks_url":"https://api.github.com/repos/venmo/Static/forks","keys_url":"https://api.github.com/repos/venmo/Static/keys{/key_id}","collaborators_url":"https://api.github.com/repos/venmo/Static/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/venmo/Static/teams","hooks_url":"https://api.github.com/repos/venmo/Static/hooks","issue_events_url":"https://api.github.com/repos/venmo/Static/issues/events{/number}","events_url":"https://api.github.com/repos/venmo/Static/events","assignees_url":"https://api.github.com/repos/venmo/Static/assignees{/user}","branches_url":"https://api.github.com/repos/venmo/Static/branches{/branch}","tags_url":"https://api.github.com/repos/venmo/Static/tags","blobs_url":"https://api.github.com/repos/venmo/Static/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/venmo/Static/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/venmo/Static/git/refs{/sha}","trees_url":"https://api.github.com/repos/venmo/Static/git/trees{/sha}","statuses_url":"https://api.github.com/repos/venmo/Static/statuses/{sha}","languages_url":"https://api.github.com/repos/venmo/Static/languages","stargazers_url":"https://api.github.com/repos/venmo/Static/stargazers","contributors_url":"https://api.github.com/repos/venmo/Static/contributors","subscribers_url":"https://api.github.com/repos/venmo/Static/subscribers","subscription_url":"https://api.github.com/repos/venmo/Static/subscription","commits_url":"https://api.github.com/repos/venmo/Static/commits{/sha}","git_commits_url":"https://api.github.com/repos/venmo/Static/git/commits{/sha}","comments_url":"https://api.github.com/repos/venmo/Static/comments{/number}","issue_comment_url":"https://api.github.com/repos/venmo/Static/issues/comments{/number}","contents_url":"https://api.github.com/repos/venmo/Static/contents/{+path}","compare_url":"https://api.github.com/repos/venmo/Static/compare/{base}...{head}","merges_url":"https://api.github.com/repos/venmo/Static/merges","archive_url":"https://api.github.com/repos/venmo/Static/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/venmo/Static/downloads","issues_url":"https://api.github.com/repos/venmo/Static/issues{/number}","pulls_url":"https://api.github.com/repos/venmo/Static/pulls{/number}","milestones_url":"https://api.github.com/repos/venmo/Static/milestones{/number}","notifications_url":"https://api.github.com/repos/venmo/Static/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/venmo/Static/labels{/name}","releases_url":"https://api.github.com/repos/venmo/Static/releases{/id}","created_at":"2015-06-27T22:00:38Z","updated_at":"2015-10-22T00:25:25Z","pushed_at":"2015-10-22T20:43:48Z","git_url":"git://github.com/venmo/Static.git","ssh_url":"git@github.com:venmo/Static.git","clone_url":"https://github.com/venmo/Static.git","svn_url":"https://github.com/venmo/Static","homepage":"http://blog.soff.es/static","size":820,"stargazers_count":497,"watchers_count":497,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":7,"forks":21,"open_issues":7,"watchers":497,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/venmo/Static/pulls/56"},"html":{"href":"https://github.com/venmo/Static/pull/56"},"issue":{"href":"https://api.github.com/repos/venmo/Static/issues/56"},"comments":{"href":"https://api.github.com/repos/venmo/Static/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/venmo/Static/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/venmo/Static/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/venmo/Static/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/venmo/Static/statuses/94f183d5ffbbf5148bedabb90abec867208053c9"}}}}