{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/35568112","id":35568112,"diff_hunk":"@@ -92,6 +93,74 @@ ParticleEffectEntityItem::ParticleEffectEntityItem(const EntityItemID& entityIte\n ParticleEffectEntityItem::~ParticleEffectEntityItem() {\n }\n \n+void ParticleEffectEntityItem::setDimensions(const glm::vec3& value) {\n+    computeAndUpdateDimensions();\n+}\n+\n+void ParticleEffectEntityItem::setLifespan(float lifespan) {\n+    _lifespan = lifespan;\n+    computeAndUpdateDimensions();\n+}\n+\n+void ParticleEffectEntityItem::setEmitDirection(glm::vec3 emitDirection) {\n+    _emitDirection = glm::normalize(emitDirection);\n+    computeAndUpdateDimensions();\n+}\n+\n+void ParticleEffectEntityItem::setEmitStrength(float emitStrength) {\n+    _emitStrength = emitStrength;\n+    computeAndUpdateDimensions();\n+}\n+\n+void ParticleEffectEntityItem::setLocalGravity(float localGravity) {\n+    _localGravity = localGravity;\n+    computeAndUpdateDimensions();\n+}\n+\n+void ParticleEffectEntityItem::setParticleRadius(float particleRadius) {\n+    _particleRadius = particleRadius;\n+    computeAndUpdateDimensions();\n+}\n+\n+void ParticleEffectEntityItem::computeAndUpdateDimensions() {\n+\n+    const float t = _lifespan * 1.1f;  // add 10% extra time, to account for incremental timer accumulation error.","path":"libraries/entities/src/ParticleEffectEntityItem.cpp","position":43,"original_position":43,"commit_id":"604ef5dc71311982e25a90bb80eba499b46524c9","original_commit_id":"5cc0b45850fa489dc0439a2a1c40c4f5a3089bc8","user":{"login":"ZappoMan","id":2093195,"avatar_url":"https://avatars.githubusercontent.com/u/2093195?v=3","gravatar_id":"","url":"https://api.github.com/users/ZappoMan","html_url":"https://github.com/ZappoMan","followers_url":"https://api.github.com/users/ZappoMan/followers","following_url":"https://api.github.com/users/ZappoMan/following{/other_user}","gists_url":"https://api.github.com/users/ZappoMan/gists{/gist_id}","starred_url":"https://api.github.com/users/ZappoMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZappoMan/subscriptions","organizations_url":"https://api.github.com/users/ZappoMan/orgs","repos_url":"https://api.github.com/users/ZappoMan/repos","events_url":"https://api.github.com/users/ZappoMan/events{/privacy}","received_events_url":"https://api.github.com/users/ZappoMan/received_events","type":"User","site_admin":false},"body":"cool - got it!","created_at":"2015-07-27T18:19:27Z","updated_at":"2015-07-27T18:19:27Z","html_url":"https://github.com/highfidelity/hifi/pull/5433#discussion_r35568112","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/5433","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/35568112"},"html":{"href":"https://github.com/highfidelity/hifi/pull/5433#discussion_r35568112"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5433"}}},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/5433","id":40862930,"html_url":"https://github.com/highfidelity/hifi/pull/5433","diff_url":"https://github.com/highfidelity/hifi/pull/5433.diff","patch_url":"https://github.com/highfidelity/hifi/pull/5433.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/5433","number":5433,"state":"open","locked":false,"title":"Improved ParticleEffectEntityItem rendering and updates","user":{"login":"hyperlogic","id":20499,"avatar_url":"https://avatars.githubusercontent.com/u/20499?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperlogic","html_url":"https://github.com/hyperlogic","followers_url":"https://api.github.com/users/hyperlogic/followers","following_url":"https://api.github.com/users/hyperlogic/following{/other_user}","gists_url":"https://api.github.com/users/hyperlogic/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperlogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperlogic/subscriptions","organizations_url":"https://api.github.com/users/hyperlogic/orgs","repos_url":"https://api.github.com/users/hyperlogic/repos","events_url":"https://api.github.com/users/hyperlogic/events{/privacy}","received_events_url":"https://api.github.com/users/hyperlogic/received_events","type":"User","site_admin":false},"body":"* Created custom pipelines and shaders for untextured and textured\r\n  particle rendering.\r\n* Created custom render payload for particles\r\n* Moved all particle updates into update rather then render.\r\n* Uses pendingChanges.updateItem lambda to update the playload with\r\n  new data for rendering.\r\n* ParticleEffectEntityItem now updates its dimensions properly,\r\n  based on emitter properties.\r\n* Bug fix for dt not accumulating properly, during gaps between updates.\r\n  now we just update all the time.  (super cheap tho, if there are no particles\r\n  animating)","created_at":"2015-07-27T00:28:45Z","updated_at":"2015-07-27T18:19:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0abc0ffac9f54eb62727cf395878cea4ea4e97b","assignee":{"login":"ZappoMan","id":2093195,"avatar_url":"https://avatars.githubusercontent.com/u/2093195?v=3","gravatar_id":"","url":"https://api.github.com/users/ZappoMan","html_url":"https://github.com/ZappoMan","followers_url":"https://api.github.com/users/ZappoMan/followers","following_url":"https://api.github.com/users/ZappoMan/following{/other_user}","gists_url":"https://api.github.com/users/ZappoMan/gists{/gist_id}","starred_url":"https://api.github.com/users/ZappoMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZappoMan/subscriptions","organizations_url":"https://api.github.com/users/ZappoMan/orgs","repos_url":"https://api.github.com/users/ZappoMan/repos","events_url":"https://api.github.com/users/ZappoMan/events{/privacy}","received_events_url":"https://api.github.com/users/ZappoMan/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/5433/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/5433/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/5433/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/604ef5dc71311982e25a90bb80eba499b46524c9","head":{"label":"hyperlogic:ajt/particle-render-fix","ref":"ajt/particle-render-fix","sha":"604ef5dc71311982e25a90bb80eba499b46524c9","user":{"login":"hyperlogic","id":20499,"avatar_url":"https://avatars.githubusercontent.com/u/20499?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperlogic","html_url":"https://github.com/hyperlogic","followers_url":"https://api.github.com/users/hyperlogic/followers","following_url":"https://api.github.com/users/hyperlogic/following{/other_user}","gists_url":"https://api.github.com/users/hyperlogic/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperlogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperlogic/subscriptions","organizations_url":"https://api.github.com/users/hyperlogic/orgs","repos_url":"https://api.github.com/users/hyperlogic/repos","events_url":"https://api.github.com/users/hyperlogic/events{/privacy}","received_events_url":"https://api.github.com/users/hyperlogic/received_events","type":"User","site_admin":false},"repo":{"id":34955357,"name":"hifi","full_name":"hyperlogic/hifi","owner":{"login":"hyperlogic","id":20499,"avatar_url":"https://avatars.githubusercontent.com/u/20499?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperlogic","html_url":"https://github.com/hyperlogic","followers_url":"https://api.github.com/users/hyperlogic/followers","following_url":"https://api.github.com/users/hyperlogic/following{/other_user}","gists_url":"https://api.github.com/users/hyperlogic/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperlogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperlogic/subscriptions","organizations_url":"https://api.github.com/users/hyperlogic/orgs","repos_url":"https://api.github.com/users/hyperlogic/repos","events_url":"https://api.github.com/users/hyperlogic/events{/privacy}","received_events_url":"https://api.github.com/users/hyperlogic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hyperlogic/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":true,"url":"https://api.github.com/repos/hyperlogic/hifi","forks_url":"https://api.github.com/repos/hyperlogic/hifi/forks","keys_url":"https://api.github.com/repos/hyperlogic/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperlogic/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperlogic/hifi/teams","hooks_url":"https://api.github.com/repos/hyperlogic/hifi/hooks","issue_events_url":"https://api.github.com/repos/hyperlogic/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/hyperlogic/hifi/events","assignees_url":"https://api.github.com/repos/hyperlogic/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/hyperlogic/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/hyperlogic/hifi/tags","blobs_url":"https://api.github.com/repos/hyperlogic/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperlogic/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperlogic/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperlogic/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperlogic/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperlogic/hifi/languages","stargazers_url":"https://api.github.com/repos/hyperlogic/hifi/stargazers","contributors_url":"https://api.github.com/repos/hyperlogic/hifi/contributors","subscribers_url":"https://api.github.com/repos/hyperlogic/hifi/subscribers","subscription_url":"https://api.github.com/repos/hyperlogic/hifi/subscription","commits_url":"https://api.github.com/repos/hyperlogic/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperlogic/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperlogic/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperlogic/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperlogic/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/hyperlogic/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperlogic/hifi/merges","archive_url":"https://api.github.com/repos/hyperlogic/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperlogic/hifi/downloads","issues_url":"https://api.github.com/repos/hyperlogic/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/hyperlogic/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperlogic/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperlogic/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperlogic/hifi/labels{/name}","releases_url":"https://api.github.com/repos/hyperlogic/hifi/releases{/id}","created_at":"2015-05-02T16:40:40Z","updated_at":"2015-05-02T16:47:44Z","pushed_at":"2015-07-27T16:29:07Z","git_url":"git://github.com/hyperlogic/hifi.git","ssh_url":"git@github.com:hyperlogic/hifi.git","clone_url":"https://github.com/hyperlogic/hifi.git","svn_url":"https://github.com/hyperlogic/hifi","homepage":"","size":168177,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"8a34df380cac67142dbb30bc20e8e022fdd551e0","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","created_at":"2012-08-10T18:26:22Z","updated_at":"2015-07-14T07:31:45Z","pushed_at":"2015-07-27T18:14:58Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":223851,"stargazers_count":285,"watchers_count":285,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":164,"mirror_url":null,"open_issues_count":61,"forks":164,"open_issues":61,"watchers":285,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5433"},"html":{"href":"https://github.com/highfidelity/hifi/pull/5433"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/5433"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/5433/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5433/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5433/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/604ef5dc71311982e25a90bb80eba499b46524c9"}}}}