{"push_id":573380160,"size":19,"distinct_size":19,"ref":"refs/heads/master","head":"e8190a34ff10bdb55729a8a50669805f833f6a85","before":"30bc0522883890c4bf5e94e621a76b7b7f7063e0","commits":[{"sha":"be18959e6c32b59d4b490a7c7bfead115f150db0","author":{"email":"c946aa019eb2e105c27e9ffc6f0113f198a67a0e@fb.com","name":"Uri Baghin"},"message":"Add GraphQLData build rule.\n\nSummary:\nThis adds a new GraphQLData build rule to generate data model libraries using graphql,\nboth for compiling and linking against.\n\nTest Plan:\nCI.\nNew tests.\nBuild a model with `buck build //:model`, verify sources in `buck-out`.","distinct":true,"url":"https://api.github.com/repos/facebook/buck/commits/be18959e6c32b59d4b490a7c7bfead115f150db0"},{"sha":"f50f41077165f8d15d2d1dc369dcd0e7ebcc4421","author":{"email":"c946aa019eb2e105c27e9ffc6f0113f198a67a0e@fb.com","name":"Uri Baghin"},"message":"Remove unused sourceGroup methods.\n\nTest Plan: CI","distinct":true,"url":"https://api.github.com/repos/facebook/buck/commits/f50f41077165f8d15d2d1dc369dcd0e7ebcc4421"},{"sha":"8c92b05d350d71ed5b7c4115fb039a77305a6b25","author":{"email":"17901b818c97112c2510dae12d1c7c05a02a9491@fb.com","name":"Brian Cheung"},"message":"introduce ability to support android_aar (part IV, classes.jar)\n\nSummary:\nThe original design was, if there is .jar file generated by `android_library`, use it, otherwise, copy all transitive jars into `libs/`.\nHowever, after investigating the code, I found that by doing this way (i.e. generate jar and then copy other jars into `libs`), its very similar to what `java_binary` is doing (i.e. copy all jars into a temp folder and the zip into jar).\nBy using the first approach, it need many code changes in moving the jars over but that logic is actually duplicating the logic in `JavaBinary`. Hence, I am simply using `java_binary` to generate the `classes.jar` here, which looks clearer and no need to duplicating / refactoring the logics.\n\nTest Plan: arc unit","distinct":true,"url":"https://api.github.com/repos/facebook/buck/commits/8c92b05d350d71ed5b7c4115fb039a77305a6b25"},{"sha":"51a40b730717bbd754fcc4e35512bf4edecceba2","author":{"email":"17901b818c97112c2510dae12d1c7c05a02a9491@fb.com","name":"Brian Cheung"},"message":"introduce ability to support android_aar (part V, unit test)\n\nSummary:\nupdate IntegrationTest to do a fully testing.\n1. generate data with `android_library` and `android_resource`, and then use `android_aar` to generate the `.aar` file. Verify the files / fodlers exist.\n2. generate data from existing `data.aar`, and then use `android_aar` to generate the `.aar` file (again). Verify the files / folders exist.\n\nTest Plan: arc unit","distinct":true,"url":"https://api.github.com/repos/facebook/buck/commits/51a40b730717bbd754fcc4e35512bf4edecceba2"},{"sha":"c097a5d04885cfd9f9962b53df33d480ae280b94","author":{"email":"6aa1be71730a75c9811f6a0b6ac5054f69a50c3f@fb.com","name":"Andrew Gallagher"},"message":"Revert \"genrule should use python explicitly for Windows\"","distinct":true,"url":"https://api.github.com/repos/facebook/buck/commits/c097a5d04885cfd9f9962b53df33d480ae280b94"},{"sha":"058825e28eaf713cdd1e0e531470049f97d15882","author":{"email":"c946aa019eb2e105c27e9ffc6f0113f198a67a0e@fb.com","name":"Uri Baghin"},"message":"Rename AbstractAppleNativeTargetBuildRuleDescriptions.\n\nSummary:\nAbstractAppleNativeTargetBuildRuleDescriptions is called this way because the\ndescription implementations for Apple targets used to subclass a class called\nAbstractAppleNativeTargetBuildRuleDescription. That class doesn't exist anymore,\nso we can rename it to a much shorter name.\n\nTest Plan: CI","distinct":true,"url":"https://api.github.com/repos/facebook/buck/commits/058825e28eaf713cdd1e0e531470049f97d15882"},{"sha":"b36c53c3e1c72e971ca047cac520b543ea78ad18","author":{"email":"c946aa019eb2e105c27e9ffc6f0113f198a67a0e@fb.com","name":"Uri Baghin"},"message":"Generate GraphQL models during project generation.\n\nSummary:\nThis changes Xcode project generation to pick up transitive GraphQL model\ndependencies, merge them and build them before generating the project.\nIt does that by creating a new target graph with only the merged models\nand their dependencies, and then executing a build with an action graph\ncreated from that target graph. The merging logic creates for each\ntransitive dependent that needs a different combination of models a new\nmodel with the same args as the component models, but with the union of\nall the queries. This means the models have to have the same values for\nargs except for their queries to be merged successfully. The merged\nmodels are shared between dependents as long as they're equivalent.\n\nTest Plan:\nCI\nNew unit tests.\nGenerate some projects with GraphQL dependencies, verify output in buck-out/gen/buck","distinct":true,"url":"https://api.github.com/repos/facebook/buck/commits/b36c53c3e1c72e971ca047cac520b543ea78ad18"},{"sha":"584581fded8c8e1f24bc2e1e5efd6e7325253679","author":{"email":"c946aa019eb2e105c27e9ffc6f0113f198a67a0e@fb.com","name":"Uri Baghin"},"message":"Disable flaky tests.\n\nTest Plan: Run tests, verify TestCacheIntegrationTest aren't being run.","distinct":true,"url":"https://api.github.com/repos/facebook/buck/commits/584581fded8c8e1f24bc2e1e5efd6e7325253679"},{"sha":"41c47db046f220b71542671c83db610cf0013ac3","author":{"email":"0eacd3f62da61bf475a16286f0a7936f16b95b89@fb.com","name":"Daniel Colascione"},"message":"Make FatJar and FatJarMain compatible with Java 6\n\nTest Plan: CI","distinct":true,"url":"https://api.github.com/repos/facebook/buck/commits/41c47db046f220b71542671c83db610cf0013ac3"},{"sha":"8625edf7695ff987b7ea297f84b5f72d07de56c6","author":{"email":"8bd85d4cedcb15ab90c2f7e7da65adf4fdc067ee@fb.com","name":"Ben Hamilton"},"message":"Easy: Refactor TargetNode -> Test BuildTargets out of TargetGraphAndTargets\n\nSummary: I plan to use this logic elsewhere to improve `buck project` runtime.\n\nTest Plan: ant build","distinct":true,"url":"https://api.github.com/repos/facebook/buck/commits/8625edf7695ff987b7ea297f84b5f72d07de56c6"},{"sha":"1e0e54aaaf32feb4d52d1b173b5b016a45b8e043","author":{"email":"8bd85d4cedcb15ab90c2f7e7da65adf4fdc067ee@fb.com","name":"Ben Hamilton"},"message":"Don't parse entire repo of BUCK files for Xcode project generation\n\nSummary:\nWe don't need to parse the entire repository's BUCK files for\nXcode project generation, now that we don't support `source_under_test`\nfor Apple rules.\n\nPreviously, we would unconditionally walk the entire project filesystem\nlooking for BUCK files and building the full target graph, just in case one rule\nhad a `source_under_test` that referred to a rule elsewhere.\n\nNow, if the user passes one or more targets to `buck project`, we can\ncreate a graph of those targets, their dependency, and the nodes specified\nin those targets' `tests` parameters.\n\nThis greatly speeds up `buck project` time for Xcode projects.\n\nTest Plan: buck test --all","distinct":true,"url":"https://api.github.com/repos/facebook/buck/commits/1e0e54aaaf32feb4d52d1b173b5b016a45b8e043"},{"sha":"6fa03adcec293dffe5ec79e6a3a80d7560183ada","author":{"email":"17901b818c97112c2510dae12d1c7c05a02a9491@fb.com","name":"Brian Cheung"},"message":"fix android_prebuilt_aar fail in buck project\n\nSummary:\nWhen running `buck project` which depends on `android_prebuilt_aar`, it will fail due to\n\n```\ncom.facebook.buck.util.HumanReadableException: Rule for target '//testing#aar_classes_jar' could not be resolved.\n```\n\nThe reason is `unzip_aar#aar_classes_jar` BuildRule is missing in the dependence graph. The fixing will be simply put it back\n\nCloses https://github.com/facebook/buck/issues/219\n\nTest Plan:\n1. run in local, can not repro the failure\n2. unit test to call `buck project`","distinct":true,"url":"https://api.github.com/repos/facebook/buck/commits/6fa03adcec293dffe5ec79e6a3a80d7560183ada"},{"sha":"ea2b585b3c0d6b8f34e24c655166ae625d46ab19","author":{"email":"a1166ad1633243ec0ce1c24d3875f36521f50a72@fb.com","name":"Jakub Zika"},"message":"Add a test for EitherTypeCoercer working with collections\n\nSummary:\nAdd a test that checks that the `Either` object created by `EitherTypeCoercer`\ncorrectly contains either left or right object.\n\nTest Plan:\n  * `buck test --all`","distinct":true,"url":"https://api.github.com/repos/facebook/buck/commits/ea2b585b3c0d6b8f34e24c655166ae625d46ab19"},{"sha":"c39698eb7a3008478764c0250a03a87295799041","author":{"email":"8bd85d4cedcb15ab90c2f7e7da65adf4fdc067ee@fb.com","name":"Ben Hamilton"},"message":"Support DTrace files in Xcode project generation\n\nSummary:\nThe open-source ReactiveCocoa project uses DTrace\nfiles during compilation:\n\nhttps://github.com/ReactiveCocoa/ReactiveCocoa/blob/master/ReactiveCocoa.xcodeproj/project.pbxproj#L505\n\nWhen we generate Xcode projects for `.d` files, we were missing the `explicitFileType`,\nwhich makes Xcode slow and sad.\n\nTest Plan:\nbuck project on a project with a `.d` file, confirmed `explicitFileType`\nwas set to `sourcecode.dtrace`.","distinct":true,"url":"https://api.github.com/repos/facebook/buck/commits/c39698eb7a3008478764c0250a03a87295799041"},{"sha":"51bbb0f01dd0d27b084866de03cece8db805b9a3","author":{"email":"069f3482a520afbcd7b153a86384843e1937be01@fb.com","name":"Simon Stewart"},"message":"Reintroduce the javac version when using an external javac.\n\nSummary:\nSomehow this went missing during the restructurings of the javac\ncode, so it's time to bring it back.\n\nTest Plan: buck test --all","distinct":true,"url":"https://api.github.com/repos/facebook/buck/commits/51bbb0f01dd0d27b084866de03cece8db805b9a3"},{"sha":"f4e65568d7748d001c8b2cdf4393bc6da8ded1d0","author":{"email":"069f3482a520afbcd7b153a86384843e1937be01@fb.com","name":"Simon Stewart"},"message":"Allow rules to reflectively amend the rule key\n\nSummary:\nThere's a class of bugs caused by us forgetting to add fields to the\nRuleKey correctly. If annotate the fields to add then the builder is\nable to set these reflectively, avoiding this class of problem.\n\nTest Plan: buck test --all","distinct":true,"url":"https://api.github.com/repos/facebook/buck/commits/f4e65568d7748d001c8b2cdf4393bc6da8ded1d0"},{"sha":"3149233489699272522e8887a7e3a2dfc9a4395f","author":{"email":"069f3482a520afbcd7b153a86384843e1937be01@fb.com","name":"Simon Stewart"},"message":"Use either the hash of the external javac or its version information.\n\nSummary:\nJava is Java is Java. It is assumed that if two versions of what are meant\nto be the same version of a javac (such as one running on Windows, and one\non Linux) they'll emit the same bytecode. For this reason, if version info\nis given on stderr use that in preference to hashing the compiler. Despite\nthis, we should fall back to hashing the compiler when version information\nis missing.\n\nTest Plan: buck test --all","distinct":true,"url":"https://api.github.com/repos/facebook/buck/commits/3149233489699272522e8887a7e3a2dfc9a4395f"},{"sha":"8a258897d44b1cd94cdfb2f2adb4ccab93f38dca","author":{"email":"b17ffd229257f00e714c4b3a24baf0ebcfeed9b3@quip.com","name":"Patrick Linehan"},"message":"Document the \"dir_max_size\" setting.\n\nCloses https://github.com/facebook/buck/pull/251","distinct":true,"url":"https://api.github.com/repos/facebook/buck/commits/8a258897d44b1cd94cdfb2f2adb4ccab93f38dca"},{"sha":"e8190a34ff10bdb55729a8a50669805f833f6a85","author":{"email":"8e4088c690bfbb5a253b6a4b25271c6390459f72@fb.com","name":"Richard Ratmansky"},"message":"updating the project command output\n\nSummary: The project command was instructing users to restart IntelliJ.  Instead, it's much faster for the user to Synchronize IntelliJ by using the Synchronize command within IntelliJ.  This diff updates the output with instructions\n\nTest Plan: run buck project, follow steps at the end to synchronize, verify new dependencies are loaded in the project and can be referenced.","distinct":true,"url":"https://api.github.com/repos/facebook/buck/commits/e8190a34ff10bdb55729a8a50669805f833f6a85"}]}