{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/4416","labels_url":"https://api.github.com/repos/facebook/react-native/issues/4416/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/4416/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/4416/events","html_url":"https://github.com/facebook/react-native/pull/4416","id":119400568,"number":4416,"title":"Fix asset httpServerLocation on Windows.","user":{"login":"anderdb","id":8662211,"avatar_url":"https://avatars.githubusercontent.com/u/8662211?v=3","gravatar_id":"","url":"https://api.github.com/users/anderdb","html_url":"https://github.com/anderdb","followers_url":"https://api.github.com/users/anderdb/followers","following_url":"https://api.github.com/users/anderdb/following{/other_user}","gists_url":"https://api.github.com/users/anderdb/gists{/gist_id}","starred_url":"https://api.github.com/users/anderdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anderdb/subscriptions","organizations_url":"https://api.github.com/users/anderdb/orgs","repos_url":"https://api.github.com/users/anderdb/repos","events_url":"https://api.github.com/users/anderdb/events{/privacy}","received_events_url":"https://api.github.com/users/anderdb/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/react-native/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-11-30T00:50:27Z","updated_at":"2015-11-30T00:51:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/4416","html_url":"https://github.com/facebook/react-native/pull/4416","diff_url":"https://github.com/facebook/react-native/pull/4416.diff","patch_url":"https://github.com/facebook/react-native/pull/4416.patch"},"body":"Functions from the path module return paths with the native file system path separator. generateAssetModule is using path.join and path.dirname to generate httpServerLocation.  That means that on Windows systems, the generated URL path has backslashes rather than forward slashes which breaks the app's ability to retrieve image assets using require('./image.png').  This change fixes this by checking path.sep and replacing backslashes with slashes on systems that require it."},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/160488096","html_url":"https://github.com/facebook/react-native/pull/4416#issuecomment-160488096","issue_url":"https://api.github.com/repos/facebook/react-native/issues/4416","id":160488096,"user":{"login":"facebook-github-bot","id":6422482,"avatar_url":"https://avatars.githubusercontent.com/u/6422482?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook-github-bot","html_url":"https://github.com/facebook-github-bot","followers_url":"https://api.github.com/users/facebook-github-bot/followers","following_url":"https://api.github.com/users/facebook-github-bot/following{/other_user}","gists_url":"https://api.github.com/users/facebook-github-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook-github-bot/subscriptions","organizations_url":"https://api.github.com/users/facebook-github-bot/orgs","repos_url":"https://api.github.com/users/facebook-github-bot/repos","events_url":"https://api.github.com/users/facebook-github-bot/events{/privacy}","received_events_url":"https://api.github.com/users/facebook-github-bot/received_events","type":"User","site_admin":false},"created_at":"2015-11-30T00:51:24Z","updated_at":"2015-11-30T00:51:24Z","body":"Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!"}}