{"action":"created","issue":{"url":"https://api.github.com/repos/radare/radare2/issues/2775","labels_url":"https://api.github.com/repos/radare/radare2/issues/2775/labels{/name}","comments_url":"https://api.github.com/repos/radare/radare2/issues/2775/comments","events_url":"https://api.github.com/repos/radare/radare2/issues/2775/events","html_url":"https://github.com/radare/radare2/pull/2775","id":88855676,"number":2775,"title":"improve ascii art graph layout","user":{"login":"ret2libc","id":562321,"avatar_url":"https://avatars.githubusercontent.com/u/562321?v=3","gravatar_id":"","url":"https://api.github.com/users/ret2libc","html_url":"https://github.com/ret2libc","followers_url":"https://api.github.com/users/ret2libc/followers","following_url":"https://api.github.com/users/ret2libc/following{/other_user}","gists_url":"https://api.github.com/users/ret2libc/gists{/gist_id}","starred_url":"https://api.github.com/users/ret2libc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ret2libc/subscriptions","organizations_url":"https://api.github.com/users/ret2libc/orgs","repos_url":"https://api.github.com/users/ret2libc/repos","events_url":"https://api.github.com/users/ret2libc/events{/privacy}","received_events_url":"https://api.github.com/users/ret2libc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-16T22:25:41Z","updated_at":"2015-06-16T22:41:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/radare/radare2/pulls/2775","html_url":"https://github.com/radare/radare2/pull/2775","diff_url":"https://github.com/radare/radare2/pull/2775.diff","patch_url":"https://github.com/radare/radare2/pull/2775.patch"},"body":"improvements:\r\n* better layer assignment to each node (nodes on the same layer don't have edges between them)\r\n* reordering of nodes in each layer to reduce the number of edge crossing\r\n\r\nnot done, yet:\r\n* x-coordinate assignment\r\n* better lines (for example the true/false edges can be inverted, etc.)\r\n"},"comment":{"url":"https://api.github.com/repos/radare/radare2/issues/comments/112594643","html_url":"https://github.com/radare/radare2/pull/2775#issuecomment-112594643","issue_url":"https://api.github.com/repos/radare/radare2/issues/2775","id":112594643,"user":{"login":"radare","id":917142,"avatar_url":"https://avatars.githubusercontent.com/u/917142?v=3","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"created_at":"2015-06-16T22:41:13Z","updated_at":"2015-06-16T22:41:13Z","body":"I was not thinking in swaping the edges order for readability at first. But now that it supports colors i guess that it will be good for the layout. Great work!\n\n\n\n> On 17 Jun 2015, at 00:25, Riccardo Schirone <notifications@github.com> wrote:\n> \n> improvements:\n> \n> better layer assignment to each node (nodes on the same layer don't have edges between them)\n> reordering of nodes in each layer to reduce the number of edge crossing\n> not done, yet:\n> \n> x-coordinate assignment\n> better lines (for example the true/false edges can be inverted, etc.)\n> You can view, comment on, or merge this pull request online at:\n> \n>   https://github.com/radare/radare2/pull/2775\n> \n> Commit Summary\n> \n> util/list: add some const to the API and adapt existing code\n> util/graph: add DFS visit implementation and r_graph_del_edge/node\n> core/graph: implement layering and ordering of nodes in each layer\n> File Changes\n> \n> M libr/core/anal.c (4)\n> M libr/core/cmd_anal.c (6)\n> M libr/core/disasm.c (4)\n> M libr/core/graph.c (428)\n> M libr/include/r_list.h (6)\n> M libr/include/r_util.h (32)\n> M libr/util/graph.c (125)\n> M libr/util/list.c (4)\n> M libr/util/t/test_graph.c (61)\n> Patch Links:\n> \n> https://github.com/radare/radare2/pull/2775.patch\n> https://github.com/radare/radare2/pull/2775.diff\n> —\n> Reply to this email directly or view it on GitHub.\n> \n"}}