{"action":"created","comment":{"url":"https://api.github.com/repos/playframework/playframework/pulls/comments/25420937","id":25420937,"diff_hunk":"@@ -38,22 +37,22 @@ abstract class MockJavaAction extends Controller with Action[Http.RequestBody] {\n object MockJavaActionHelper {\n   import Helpers.defaultAwaitTimeout\n \n-  def call(action: Action[Http.RequestBody], request: FakeRequest): Result = {\n-    val result = Helpers.await(action.apply(request.getWrappedRequest))\n+  def call(action: Action[Http.RequestBody], fakeRequest: play.mvc.Http.RequestBuilder): Result = {","path":"documentation/manual/working/javaGuide/code/MockJavaAction.scala","position":null,"original_position":14,"commit_id":"bfb271016f26007e082a6514d2ad007771799782","original_commit_id":"29db025a62fe5a28413cec517d6270cf4cc92d69","user":{"login":"dotta","id":703748,"avatar_url":"https://avatars.githubusercontent.com/u/703748?v=3","gravatar_id":"","url":"https://api.github.com/users/dotta","html_url":"https://github.com/dotta","followers_url":"https://api.github.com/users/dotta/followers","following_url":"https://api.github.com/users/dotta/following{/other_user}","gists_url":"https://api.github.com/users/dotta/gists{/gist_id}","starred_url":"https://api.github.com/users/dotta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotta/subscriptions","organizations_url":"https://api.github.com/users/dotta/orgs","repos_url":"https://api.github.com/users/dotta/repos","events_url":"https://api.github.com/users/dotta/events{/privacy}","received_events_url":"https://api.github.com/users/dotta/received_events","type":"User","site_admin":false},"body":"I see now this was likely done for consistency. I wonder if it would make sense to rename all `fakeRequest` to `requestBuilder`, given we are already breaking source compatibility.","created_at":"2015-02-26T11:40:36Z","updated_at":"2015-02-26T11:40:36Z","html_url":"https://github.com/playframework/playframework/pull/3971#discussion_r25420937","pull_request_url":"https://api.github.com/repos/playframework/playframework/pulls/3971","_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments/25420937"},"html":{"href":"https://github.com/playframework/playframework/pull/3971#discussion_r25420937"},"pull_request":{"href":"https://api.github.com/repos/playframework/playframework/pulls/3971"}}},"pull_request":{"url":"https://api.github.com/repos/playframework/playframework/pulls/3971","id":29964979,"html_url":"https://github.com/playframework/playframework/pull/3971","diff_url":"https://github.com/playframework/playframework/pull/3971.diff","patch_url":"https://github.com/playframework/playframework/pull/3971.patch","issue_url":"https://api.github.com/repos/playframework/playframework/issues/3971","number":3971,"state":"open","locked":false,"title":"Replace FakeRequest with an actual Request and allow constructing a Context from a Request","user":{"login":"benmccann","id":322311,"avatar_url":"https://avatars.githubusercontent.com/u/322311?v=3","gravatar_id":"","url":"https://api.github.com/users/benmccann","html_url":"https://github.com/benmccann","followers_url":"https://api.github.com/users/benmccann/followers","following_url":"https://api.github.com/users/benmccann/following{/other_user}","gists_url":"https://api.github.com/users/benmccann/gists{/gist_id}","starred_url":"https://api.github.com/users/benmccann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benmccann/subscriptions","organizations_url":"https://api.github.com/users/benmccann/orgs","repos_url":"https://api.github.com/users/benmccann/repos","events_url":"https://api.github.com/users/benmccann/events{/privacy}","received_events_url":"https://api.github.com/users/benmccann/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-02-25T06:57:36Z","updated_at":"2015-02-26T11:40:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5859c80dd558b60fec7b16758c938cb1550f0723","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/playframework/playframework/pulls/3971/commits","review_comments_url":"https://api.github.com/repos/playframework/playframework/pulls/3971/comments","review_comment_url":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/playframework/playframework/issues/3971/comments","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/bfb271016f26007e082a6514d2ad007771799782","head":{"label":"benmccann:context-builder","ref":"context-builder","sha":"bfb271016f26007e082a6514d2ad007771799782","user":{"login":"benmccann","id":322311,"avatar_url":"https://avatars.githubusercontent.com/u/322311?v=3","gravatar_id":"","url":"https://api.github.com/users/benmccann","html_url":"https://github.com/benmccann","followers_url":"https://api.github.com/users/benmccann/followers","following_url":"https://api.github.com/users/benmccann/following{/other_user}","gists_url":"https://api.github.com/users/benmccann/gists{/gist_id}","starred_url":"https://api.github.com/users/benmccann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benmccann/subscriptions","organizations_url":"https://api.github.com/users/benmccann/orgs","repos_url":"https://api.github.com/users/benmccann/repos","events_url":"https://api.github.com/users/benmccann/events{/privacy}","received_events_url":"https://api.github.com/users/benmccann/received_events","type":"User","site_admin":false},"repo":{"id":12789867,"name":"playframework","full_name":"benmccann/playframework","owner":{"login":"benmccann","id":322311,"avatar_url":"https://avatars.githubusercontent.com/u/322311?v=3","gravatar_id":"","url":"https://api.github.com/users/benmccann","html_url":"https://github.com/benmccann","followers_url":"https://api.github.com/users/benmccann/followers","following_url":"https://api.github.com/users/benmccann/following{/other_user}","gists_url":"https://api.github.com/users/benmccann/gists{/gist_id}","starred_url":"https://api.github.com/users/benmccann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benmccann/subscriptions","organizations_url":"https://api.github.com/users/benmccann/orgs","repos_url":"https://api.github.com/users/benmccann/repos","events_url":"https://api.github.com/users/benmccann/events{/privacy}","received_events_url":"https://api.github.com/users/benmccann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benmccann/playframework","description":"Play Framework","fork":true,"url":"https://api.github.com/repos/benmccann/playframework","forks_url":"https://api.github.com/repos/benmccann/playframework/forks","keys_url":"https://api.github.com/repos/benmccann/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benmccann/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benmccann/playframework/teams","hooks_url":"https://api.github.com/repos/benmccann/playframework/hooks","issue_events_url":"https://api.github.com/repos/benmccann/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/benmccann/playframework/events","assignees_url":"https://api.github.com/repos/benmccann/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/benmccann/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/benmccann/playframework/tags","blobs_url":"https://api.github.com/repos/benmccann/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benmccann/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benmccann/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/benmccann/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benmccann/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/benmccann/playframework/languages","stargazers_url":"https://api.github.com/repos/benmccann/playframework/stargazers","contributors_url":"https://api.github.com/repos/benmccann/playframework/contributors","subscribers_url":"https://api.github.com/repos/benmccann/playframework/subscribers","subscription_url":"https://api.github.com/repos/benmccann/playframework/subscription","commits_url":"https://api.github.com/repos/benmccann/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/benmccann/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/benmccann/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/benmccann/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/benmccann/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/benmccann/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benmccann/playframework/merges","archive_url":"https://api.github.com/repos/benmccann/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benmccann/playframework/downloads","issues_url":"https://api.github.com/repos/benmccann/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/benmccann/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/benmccann/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/benmccann/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benmccann/playframework/labels{/name}","releases_url":"https://api.github.com/repos/benmccann/playframework/releases{/id}","created_at":"2013-09-12T17:22:56Z","updated_at":"2015-02-12T16:33:26Z","pushed_at":"2015-02-26T11:39:06Z","git_url":"git://github.com/benmccann/playframework.git","ssh_url":"git@github.com:benmccann/playframework.git","clone_url":"https://github.com/benmccann/playframework.git","svn_url":"https://github.com/benmccann/playframework","homepage":"http://www.playframework.com/","size":74195,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"playframework:master","ref":"master","sha":"e15eb1253d5d40ebda631d4b123664c9b0892cc0","user":{"login":"playframework","id":319107,"avatar_url":"https://avatars.githubusercontent.com/u/319107?v=3","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"repo":{"id":2340549,"name":"playframework","full_name":"playframework/playframework","owner":{"login":"playframework","id":319107,"avatar_url":"https://avatars.githubusercontent.com/u/319107?v=3","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/playframework/playframework","description":"Play Framework","fork":false,"url":"https://api.github.com/repos/playframework/playframework","forks_url":"https://api.github.com/repos/playframework/playframework/forks","keys_url":"https://api.github.com/repos/playframework/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/playframework/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/playframework/playframework/teams","hooks_url":"https://api.github.com/repos/playframework/playframework/hooks","issue_events_url":"https://api.github.com/repos/playframework/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/playframework/playframework/events","assignees_url":"https://api.github.com/repos/playframework/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/playframework/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/playframework/playframework/tags","blobs_url":"https://api.github.com/repos/playframework/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/playframework/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/playframework/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/playframework/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/playframework/playframework/languages","stargazers_url":"https://api.github.com/repos/playframework/playframework/stargazers","contributors_url":"https://api.github.com/repos/playframework/playframework/contributors","subscribers_url":"https://api.github.com/repos/playframework/playframework/subscribers","subscription_url":"https://api.github.com/repos/playframework/playframework/subscription","commits_url":"https://api.github.com/repos/playframework/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/playframework/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/playframework/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/playframework/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/playframework/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/playframework/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/playframework/playframework/merges","archive_url":"https://api.github.com/repos/playframework/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/playframework/playframework/downloads","issues_url":"https://api.github.com/repos/playframework/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/playframework/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/playframework/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/playframework/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/playframework/playframework/labels{/name}","releases_url":"https://api.github.com/repos/playframework/playframework/releases{/id}","created_at":"2011-09-07T09:24:08Z","updated_at":"2015-02-26T10:09:48Z","pushed_at":"2015-02-26T01:36:54Z","git_url":"git://github.com/playframework/playframework.git","ssh_url":"git@github.com:playframework/playframework.git","clone_url":"https://github.com/playframework/playframework.git","svn_url":"https://github.com/playframework/playframework","homepage":"http://www.playframework.com/","size":117479,"stargazers_count":5875,"watchers_count":5875,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2092,"mirror_url":null,"open_issues_count":249,"forks":2092,"open_issues":249,"watchers":5875,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/3971"},"html":{"href":"https://github.com/playframework/playframework/pull/3971"},"issue":{"href":"https://api.github.com/repos/playframework/playframework/issues/3971"},"comments":{"href":"https://api.github.com/repos/playframework/playframework/issues/3971/comments"},"review_comments":{"href":"https://api.github.com/repos/playframework/playframework/pulls/3971/comments"},"review_comment":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/playframework/playframework/pulls/3971/commits"},"statuses":{"href":"https://api.github.com/repos/playframework/playframework/statuses/bfb271016f26007e082a6514d2ad007771799782"}}}}