{"action":"created","comment":{"url":"https://api.github.com/repos/drupal-media/d8-guide/pulls/comments/45912923","id":45912923,"diff_hunk":"@@ -0,0 +1,47 @@\n+# Architecture\n+\n+Diagram shows basic architecture of Crop.\n+\n+![Crop architecture](images/architecture.png)\n+\n+## Components\n+\n+### Entity\n+- **Crop** Is a content entity that stores various informations related to the crop area.\n+- **CropType** CropType is bundle for Crop entity.\n+\n+###Plugin\n+- **CropEffect** Crop effect is an image style effect. He apply your crop area into image with information of Crop entity.\n+\n+This diagram shows how specifically Crop Image Effect (Manual crop) get informations of corresponding image ressource and apply different effect.\n+\n+![Manual Crop Effect](images/architecture_of_manual_crop.png)\n+\n+The effect \"Manual Crop Effect\" recover the crop has an image associated with two parameters \"uri\" & \"crop_type\".\n+\n+- **\"uri\"** This is an important property because it is the only contextual information available when you apply the effect (manual crop) to the image.\n+- **\"crop_type\"** As it is possible to link CROP entity with same image, this is the only parameter that can distinguish several crop_type on the same image.\n+\n+Limitation :\n+Due to limitations in Drupal core we're currently not not able to handle the case where one image would have several crops of the same crop type. The oldest crop will always be used in such case.\n+\n+See [Crop API support multiple issue] for more information.\n+\n+[Crop API support multiple issue]: https://www.drupal.org/node/2617818\n+\n+## Focus on properties of crop entity\n+\n+When creating an CROP entity must send a series of properties that will be used for the purposes of the crop area by imageStyle or for the recovery data link to this entity.","path":"modules/crop/architecture.md","position":34,"original_position":34,"commit_id":"baba5e7fa2e2cbf1fd1453c50dfbcb23a34e8f81","original_commit_id":"baba5e7fa2e2cbf1fd1453c50dfbcb23a34e8f81","user":{"login":"woprrr","id":8972139,"avatar_url":"https://avatars.githubusercontent.com/u/8972139?v=3","gravatar_id":"","url":"https://api.github.com/users/woprrr","html_url":"https://github.com/woprrr","followers_url":"https://api.github.com/users/woprrr/followers","following_url":"https://api.github.com/users/woprrr/following{/other_user}","gists_url":"https://api.github.com/users/woprrr/gists{/gist_id}","starred_url":"https://api.github.com/users/woprrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woprrr/subscriptions","organizations_url":"https://api.github.com/users/woprrr/orgs","repos_url":"https://api.github.com/users/woprrr/repos","events_url":"https://api.github.com/users/woprrr/events{/privacy}","received_events_url":"https://api.github.com/users/woprrr/received_events","type":"User","site_admin":false},"body":"I thought it would be necessary to detail a bit like an intro before the explanation","created_at":"2015-11-25T20:00:36Z","updated_at":"2015-11-25T20:00:36Z","html_url":"https://github.com/drupal-media/d8-guide/pull/11#discussion_r45912923","pull_request_url":"https://api.github.com/repos/drupal-media/d8-guide/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/drupal-media/d8-guide/pulls/comments/45912923"},"html":{"href":"https://github.com/drupal-media/d8-guide/pull/11#discussion_r45912923"},"pull_request":{"href":"https://api.github.com/repos/drupal-media/d8-guide/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/drupal-media/d8-guide/pulls/11","id":51673994,"html_url":"https://github.com/drupal-media/d8-guide/pull/11","diff_url":"https://github.com/drupal-media/d8-guide/pull/11.diff","patch_url":"https://github.com/drupal-media/d8-guide/pull/11.patch","issue_url":"https://api.github.com/repos/drupal-media/d8-guide/issues/11","number":11,"state":"open","locked":false,"title":"Write Crop Api documentation.","user":{"login":"woprrr","id":8972139,"avatar_url":"https://avatars.githubusercontent.com/u/8972139?v=3","gravatar_id":"","url":"https://api.github.com/users/woprrr","html_url":"https://github.com/woprrr","followers_url":"https://api.github.com/users/woprrr/followers","following_url":"https://api.github.com/users/woprrr/following{/other_user}","gists_url":"https://api.github.com/users/woprrr/gists{/gist_id}","starred_url":"https://api.github.com/users/woprrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woprrr/subscriptions","organizations_url":"https://api.github.com/users/woprrr/orgs","repos_url":"https://api.github.com/users/woprrr/repos","events_url":"https://api.github.com/users/woprrr/events{/privacy}","received_events_url":"https://api.github.com/users/woprrr/received_events","type":"User","site_admin":false},"body":"This is a start of doccumentation of CropAPI what do you think @slashrsm ?\r\n\r\nExcuse my bad english at time ... if you can correct it, if you found faults.\r\n\r\nOriginal demand : https://www.drupal.org/node/2382637","created_at":"2015-11-24T15:29:23Z","updated_at":"2015-11-25T20:00:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"189b0c30986ebe740ee66f8f62470099b8a97fc4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/drupal-media/d8-guide/pulls/11/commits","review_comments_url":"https://api.github.com/repos/drupal-media/d8-guide/pulls/11/comments","review_comment_url":"https://api.github.com/repos/drupal-media/d8-guide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/drupal-media/d8-guide/issues/11/comments","statuses_url":"https://api.github.com/repos/drupal-media/d8-guide/statuses/baba5e7fa2e2cbf1fd1453c50dfbcb23a34e8f81","head":{"label":"woprrr:master","ref":"master","sha":"baba5e7fa2e2cbf1fd1453c50dfbcb23a34e8f81","user":{"login":"woprrr","id":8972139,"avatar_url":"https://avatars.githubusercontent.com/u/8972139?v=3","gravatar_id":"","url":"https://api.github.com/users/woprrr","html_url":"https://github.com/woprrr","followers_url":"https://api.github.com/users/woprrr/followers","following_url":"https://api.github.com/users/woprrr/following{/other_user}","gists_url":"https://api.github.com/users/woprrr/gists{/gist_id}","starred_url":"https://api.github.com/users/woprrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woprrr/subscriptions","organizations_url":"https://api.github.com/users/woprrr/orgs","repos_url":"https://api.github.com/users/woprrr/repos","events_url":"https://api.github.com/users/woprrr/events{/privacy}","received_events_url":"https://api.github.com/users/woprrr/received_events","type":"User","site_admin":false},"repo":{"id":46785794,"name":"d8-guide","full_name":"woprrr/d8-guide","owner":{"login":"woprrr","id":8972139,"avatar_url":"https://avatars.githubusercontent.com/u/8972139?v=3","gravatar_id":"","url":"https://api.github.com/users/woprrr","html_url":"https://github.com/woprrr","followers_url":"https://api.github.com/users/woprrr/followers","following_url":"https://api.github.com/users/woprrr/following{/other_user}","gists_url":"https://api.github.com/users/woprrr/gists{/gist_id}","starred_url":"https://api.github.com/users/woprrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woprrr/subscriptions","organizations_url":"https://api.github.com/users/woprrr/orgs","repos_url":"https://api.github.com/users/woprrr/repos","events_url":"https://api.github.com/users/woprrr/events{/privacy}","received_events_url":"https://api.github.com/users/woprrr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/woprrr/d8-guide","description":"Definitive guide on how to integrate and develop with Drupal Media.","fork":true,"url":"https://api.github.com/repos/woprrr/d8-guide","forks_url":"https://api.github.com/repos/woprrr/d8-guide/forks","keys_url":"https://api.github.com/repos/woprrr/d8-guide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/woprrr/d8-guide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/woprrr/d8-guide/teams","hooks_url":"https://api.github.com/repos/woprrr/d8-guide/hooks","issue_events_url":"https://api.github.com/repos/woprrr/d8-guide/issues/events{/number}","events_url":"https://api.github.com/repos/woprrr/d8-guide/events","assignees_url":"https://api.github.com/repos/woprrr/d8-guide/assignees{/user}","branches_url":"https://api.github.com/repos/woprrr/d8-guide/branches{/branch}","tags_url":"https://api.github.com/repos/woprrr/d8-guide/tags","blobs_url":"https://api.github.com/repos/woprrr/d8-guide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/woprrr/d8-guide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/woprrr/d8-guide/git/refs{/sha}","trees_url":"https://api.github.com/repos/woprrr/d8-guide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/woprrr/d8-guide/statuses/{sha}","languages_url":"https://api.github.com/repos/woprrr/d8-guide/languages","stargazers_url":"https://api.github.com/repos/woprrr/d8-guide/stargazers","contributors_url":"https://api.github.com/repos/woprrr/d8-guide/contributors","subscribers_url":"https://api.github.com/repos/woprrr/d8-guide/subscribers","subscription_url":"https://api.github.com/repos/woprrr/d8-guide/subscription","commits_url":"https://api.github.com/repos/woprrr/d8-guide/commits{/sha}","git_commits_url":"https://api.github.com/repos/woprrr/d8-guide/git/commits{/sha}","comments_url":"https://api.github.com/repos/woprrr/d8-guide/comments{/number}","issue_comment_url":"https://api.github.com/repos/woprrr/d8-guide/issues/comments{/number}","contents_url":"https://api.github.com/repos/woprrr/d8-guide/contents/{+path}","compare_url":"https://api.github.com/repos/woprrr/d8-guide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/woprrr/d8-guide/merges","archive_url":"https://api.github.com/repos/woprrr/d8-guide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/woprrr/d8-guide/downloads","issues_url":"https://api.github.com/repos/woprrr/d8-guide/issues{/number}","pulls_url":"https://api.github.com/repos/woprrr/d8-guide/pulls{/number}","milestones_url":"https://api.github.com/repos/woprrr/d8-guide/milestones{/number}","notifications_url":"https://api.github.com/repos/woprrr/d8-guide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/woprrr/d8-guide/labels{/name}","releases_url":"https://api.github.com/repos/woprrr/d8-guide/releases{/id}","created_at":"2015-11-24T10:55:43Z","updated_at":"2015-11-24T10:55:06Z","pushed_at":"2015-11-25T19:31:03Z","git_url":"git://github.com/woprrr/d8-guide.git","ssh_url":"git@github.com:woprrr/d8-guide.git","clone_url":"https://github.com/woprrr/d8-guide.git","svn_url":"https://github.com/woprrr/d8-guide","homepage":"http://drupal-media.gitbooks.io/drupal8-guide/","size":2311,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"drupal-media:master","ref":"master","sha":"a35b4654f87981b3dc8dae4bff64cf4ae3ee7533","user":{"login":"drupal-media","id":7276699,"avatar_url":"https://avatars.githubusercontent.com/u/7276699?v=3","gravatar_id":"","url":"https://api.github.com/users/drupal-media","html_url":"https://github.com/drupal-media","followers_url":"https://api.github.com/users/drupal-media/followers","following_url":"https://api.github.com/users/drupal-media/following{/other_user}","gists_url":"https://api.github.com/users/drupal-media/gists{/gist_id}","starred_url":"https://api.github.com/users/drupal-media/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drupal-media/subscriptions","organizations_url":"https://api.github.com/users/drupal-media/orgs","repos_url":"https://api.github.com/users/drupal-media/repos","events_url":"https://api.github.com/users/drupal-media/events{/privacy}","received_events_url":"https://api.github.com/users/drupal-media/received_events","type":"Organization","site_admin":false},"repo":{"id":38075447,"name":"d8-guide","full_name":"drupal-media/d8-guide","owner":{"login":"drupal-media","id":7276699,"avatar_url":"https://avatars.githubusercontent.com/u/7276699?v=3","gravatar_id":"","url":"https://api.github.com/users/drupal-media","html_url":"https://github.com/drupal-media","followers_url":"https://api.github.com/users/drupal-media/followers","following_url":"https://api.github.com/users/drupal-media/following{/other_user}","gists_url":"https://api.github.com/users/drupal-media/gists{/gist_id}","starred_url":"https://api.github.com/users/drupal-media/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drupal-media/subscriptions","organizations_url":"https://api.github.com/users/drupal-media/orgs","repos_url":"https://api.github.com/users/drupal-media/repos","events_url":"https://api.github.com/users/drupal-media/events{/privacy}","received_events_url":"https://api.github.com/users/drupal-media/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/drupal-media/d8-guide","description":"Definitive guide on how to integrate and develop with Drupal Media.","fork":false,"url":"https://api.github.com/repos/drupal-media/d8-guide","forks_url":"https://api.github.com/repos/drupal-media/d8-guide/forks","keys_url":"https://api.github.com/repos/drupal-media/d8-guide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drupal-media/d8-guide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drupal-media/d8-guide/teams","hooks_url":"https://api.github.com/repos/drupal-media/d8-guide/hooks","issue_events_url":"https://api.github.com/repos/drupal-media/d8-guide/issues/events{/number}","events_url":"https://api.github.com/repos/drupal-media/d8-guide/events","assignees_url":"https://api.github.com/repos/drupal-media/d8-guide/assignees{/user}","branches_url":"https://api.github.com/repos/drupal-media/d8-guide/branches{/branch}","tags_url":"https://api.github.com/repos/drupal-media/d8-guide/tags","blobs_url":"https://api.github.com/repos/drupal-media/d8-guide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drupal-media/d8-guide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drupal-media/d8-guide/git/refs{/sha}","trees_url":"https://api.github.com/repos/drupal-media/d8-guide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drupal-media/d8-guide/statuses/{sha}","languages_url":"https://api.github.com/repos/drupal-media/d8-guide/languages","stargazers_url":"https://api.github.com/repos/drupal-media/d8-guide/stargazers","contributors_url":"https://api.github.com/repos/drupal-media/d8-guide/contributors","subscribers_url":"https://api.github.com/repos/drupal-media/d8-guide/subscribers","subscription_url":"https://api.github.com/repos/drupal-media/d8-guide/subscription","commits_url":"https://api.github.com/repos/drupal-media/d8-guide/commits{/sha}","git_commits_url":"https://api.github.com/repos/drupal-media/d8-guide/git/commits{/sha}","comments_url":"https://api.github.com/repos/drupal-media/d8-guide/comments{/number}","issue_comment_url":"https://api.github.com/repos/drupal-media/d8-guide/issues/comments{/number}","contents_url":"https://api.github.com/repos/drupal-media/d8-guide/contents/{+path}","compare_url":"https://api.github.com/repos/drupal-media/d8-guide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drupal-media/d8-guide/merges","archive_url":"https://api.github.com/repos/drupal-media/d8-guide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drupal-media/d8-guide/downloads","issues_url":"https://api.github.com/repos/drupal-media/d8-guide/issues{/number}","pulls_url":"https://api.github.com/repos/drupal-media/d8-guide/pulls{/number}","milestones_url":"https://api.github.com/repos/drupal-media/d8-guide/milestones{/number}","notifications_url":"https://api.github.com/repos/drupal-media/d8-guide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drupal-media/d8-guide/labels{/name}","releases_url":"https://api.github.com/repos/drupal-media/d8-guide/releases{/id}","created_at":"2015-06-25T21:33:49Z","updated_at":"2015-11-24T10:55:06Z","pushed_at":"2015-11-25T19:31:04Z","git_url":"git://github.com/drupal-media/d8-guide.git","ssh_url":"git@github.com:drupal-media/d8-guide.git","clone_url":"https://github.com/drupal-media/d8-guide.git","svn_url":"https://github.com/drupal-media/d8-guide","homepage":"http://drupal-media.gitbooks.io/drupal8-guide/","size":2262,"stargazers_count":4,"watchers_count":4,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":5,"forks":8,"open_issues":5,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/drupal-media/d8-guide/pulls/11"},"html":{"href":"https://github.com/drupal-media/d8-guide/pull/11"},"issue":{"href":"https://api.github.com/repos/drupal-media/d8-guide/issues/11"},"comments":{"href":"https://api.github.com/repos/drupal-media/d8-guide/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/drupal-media/d8-guide/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/drupal-media/d8-guide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/drupal-media/d8-guide/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/drupal-media/d8-guide/statuses/baba5e7fa2e2cbf1fd1453c50dfbcb23a34e8f81"}}}}