{"action":"created","issue":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/1608","labels_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/1608/labels{/name}","comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/1608/comments","events_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/1608/events","html_url":"https://github.com/MarlinFirmware/Marlin/issues/1608","id":61675612,"number":1608,"title":"Shouldn't configuration options be in Configuration.h ?","user":{"login":"Roxy-3DPrintBoard","id":8404322,"avatar_url":"https://avatars.githubusercontent.com/u/8404322?v=3","gravatar_id":"","url":"https://api.github.com/users/Roxy-3DPrintBoard","html_url":"https://github.com/Roxy-3DPrintBoard","followers_url":"https://api.github.com/users/Roxy-3DPrintBoard/followers","following_url":"https://api.github.com/users/Roxy-3DPrintBoard/following{/other_user}","gists_url":"https://api.github.com/users/Roxy-3DPrintBoard/gists{/gist_id}","starred_url":"https://api.github.com/users/Roxy-3DPrintBoard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Roxy-3DPrintBoard/subscriptions","organizations_url":"https://api.github.com/users/Roxy-3DPrintBoard/orgs","repos_url":"https://api.github.com/users/Roxy-3DPrintBoard/repos","events_url":"https://api.github.com/users/Roxy-3DPrintBoard/events{/privacy}","received_events_url":"https://api.github.com/users/Roxy-3DPrintBoard/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-03-14T18:51:08Z","updated_at":"2015-03-14T19:51:09Z","closed_at":null,"body":"I'm trying to move over to the current code base so I can contribute to the testing and help verify things are working right.    \r\n\r\nIn Marlin_Main.CPP this code exists in the G29 Auto Bed Level function:\r\n\r\n  // Use one of these defines to specify the origin\r\n  // for a topographical map to be printed for your bed.\r\n  enum { OriginBackLeft, OriginFrontLeft, OriginBackRight, OriginFrontRight };\r\n  #define TOPO_ORIGIN OriginBackRight\r\n\r\nShouldn't the #define for TOPO_ORIGIN be in Configuration.h ?\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/comments/80691680","html_url":"https://github.com/MarlinFirmware/Marlin/issues/1608#issuecomment-80691680","issue_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/1608","id":80691680,"user":{"login":"Roxy-3DPrintBoard","id":8404322,"avatar_url":"https://avatars.githubusercontent.com/u/8404322?v=3","gravatar_id":"","url":"https://api.github.com/users/Roxy-3DPrintBoard","html_url":"https://github.com/Roxy-3DPrintBoard","followers_url":"https://api.github.com/users/Roxy-3DPrintBoard/followers","following_url":"https://api.github.com/users/Roxy-3DPrintBoard/following{/other_user}","gists_url":"https://api.github.com/users/Roxy-3DPrintBoard/gists{/gist_id}","starred_url":"https://api.github.com/users/Roxy-3DPrintBoard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Roxy-3DPrintBoard/subscriptions","organizations_url":"https://api.github.com/users/Roxy-3DPrintBoard/orgs","repos_url":"https://api.github.com/users/Roxy-3DPrintBoard/repos","events_url":"https://api.github.com/users/Roxy-3DPrintBoard/events{/privacy}","received_events_url":"https://api.github.com/users/Roxy-3DPrintBoard/received_events","type":"User","site_admin":false},"created_at":"2015-03-14T19:51:09Z","updated_at":"2015-03-14T19:51:09Z","body":"> Also in regards to the original topic, if it wouldn't cause any issues or be too much work, it is more intuitive to move the #define to Configuration.h at the end of the section where auto-bed leveling configuration takes place.\r\n\r\nI suspect it is a combination of things caused it to be where it is in the Marlin_main.cpp code.   When I originally did the code, I didn't want people to have to modify two files so I put it with the C code in Marlin_main.cpp.   But that doesn't make sense now.   And who ever moved the code over to the main code base was probably testing the various print outs to make sure they functioned correctly.   So it may be it was just easier (for the time being) to leave it where it was.\r\n\r\n"}}