{"action":"created","comment":{"url":"https://api.github.com/repos/iea-annex60/modelica-annex60/pulls/comments/25759659","id":25759659,"diff_hunk":"@@ -3,11 +3,18 @@ package Characteristics \"Functions for fan or pump characteristics\"\n \n   record flowParameters \"Record for flow parameters\"\n     extends Modelica.Icons.Record;\n+\n     parameter Modelica.SIunits.VolumeFlowRate V_flow[:](each min=0)\n       \"Volume flow rate at user-selected operating points\";\n-    parameter Modelica.SIunits.Pressure dp[size(V_flow,1)](\n+    parameter Modelica.SIunits.Pressure dp[:](\n        each min=0, each displayUnit=\"Pa\")\n       \"Fan or pump total pressure at these flow rates\";\n+\n+    // This is needed for OpenModelica.\n+    // fixme: Check if this can be put into FlowMachineInterface instead of here.","path":"Annex60/Fluid/Movers/BaseClasses/Characteristics.mo","position":13,"original_position":13,"commit_id":"a304e4d654bc7ce431b26fdf44e7e9081f5ce2d5","original_commit_id":"a304e4d654bc7ce431b26fdf44e7e9081f5ce2d5","user":{"login":"damienpicard","id":2987659,"avatar_url":"https://avatars.githubusercontent.com/u/2987659?v=3","gravatar_id":"","url":"https://api.github.com/users/damienpicard","html_url":"https://github.com/damienpicard","followers_url":"https://api.github.com/users/damienpicard/followers","following_url":"https://api.github.com/users/damienpicard/following{/other_user}","gists_url":"https://api.github.com/users/damienpicard/gists{/gist_id}","starred_url":"https://api.github.com/users/damienpicard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damienpicard/subscriptions","organizations_url":"https://api.github.com/users/damienpicard/orgs","repos_url":"https://api.github.com/users/damienpicard/repos","events_url":"https://api.github.com/users/damienpicard/events{/privacy}","received_events_url":"https://api.github.com/users/damienpicard/received_events","type":"User","site_admin":false},"body":"Do you want to keep some *fixme* in the master?","created_at":"2015-03-04T08:55:08Z","updated_at":"2015-03-04T08:55:08Z","html_url":"https://github.com/iea-annex60/modelica-annex60/pull/153#discussion_r25759659","pull_request_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/pulls/153","_links":{"self":{"href":"https://api.github.com/repos/iea-annex60/modelica-annex60/pulls/comments/25759659"},"html":{"href":"https://github.com/iea-annex60/modelica-annex60/pull/153#discussion_r25759659"},"pull_request":{"href":"https://api.github.com/repos/iea-annex60/modelica-annex60/pulls/153"}}},"pull_request":{"url":"https://api.github.com/repos/iea-annex60/modelica-annex60/pulls/153","id":27985015,"html_url":"https://github.com/iea-annex60/modelica-annex60/pull/153","diff_url":"https://github.com/iea-annex60/modelica-annex60/pull/153.diff","patch_url":"https://github.com/iea-annex60/modelica-annex60/pull/153.patch","issue_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues/153","number":153,"state":"open","locked":false,"title":"Issue147 movers record","user":{"login":"mwetter","id":1329080,"avatar_url":"https://avatars.githubusercontent.com/u/1329080?v=3","gravatar_id":"","url":"https://api.github.com/users/mwetter","html_url":"https://github.com/mwetter","followers_url":"https://api.github.com/users/mwetter/followers","following_url":"https://api.github.com/users/mwetter/following{/other_user}","gists_url":"https://api.github.com/users/mwetter/gists{/gist_id}","starred_url":"https://api.github.com/users/mwetter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwetter/subscriptions","organizations_url":"https://api.github.com/users/mwetter/orgs","repos_url":"https://api.github.com/users/mwetter/repos","events_url":"https://api.github.com/users/mwetter/events{/privacy}","received_events_url":"https://api.github.com/users/mwetter/received_events","type":"User","site_admin":false},"body":"Merge new pumps and fans.\r\nThis will close #147 ","created_at":"2015-01-25T00:27:53Z","updated_at":"2015-03-04T08:55:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0511237e73f223a80fb164001be3afe2de1d29e5","assignee":{"login":"damienpicard","id":2987659,"avatar_url":"https://avatars.githubusercontent.com/u/2987659?v=3","gravatar_id":"","url":"https://api.github.com/users/damienpicard","html_url":"https://github.com/damienpicard","followers_url":"https://api.github.com/users/damienpicard/followers","following_url":"https://api.github.com/users/damienpicard/following{/other_user}","gists_url":"https://api.github.com/users/damienpicard/gists{/gist_id}","starred_url":"https://api.github.com/users/damienpicard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damienpicard/subscriptions","organizations_url":"https://api.github.com/users/damienpicard/orgs","repos_url":"https://api.github.com/users/damienpicard/repos","events_url":"https://api.github.com/users/damienpicard/events{/privacy}","received_events_url":"https://api.github.com/users/damienpicard/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/pulls/153/commits","review_comments_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/pulls/153/comments","review_comment_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues/153/comments","statuses_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/statuses/a304e4d654bc7ce431b26fdf44e7e9081f5ce2d5","head":{"label":"iea-annex60:issue147_moversRecord","ref":"issue147_moversRecord","sha":"a304e4d654bc7ce431b26fdf44e7e9081f5ce2d5","user":{"login":"iea-annex60","id":5323273,"avatar_url":"https://avatars.githubusercontent.com/u/5323273?v=3","gravatar_id":"","url":"https://api.github.com/users/iea-annex60","html_url":"https://github.com/iea-annex60","followers_url":"https://api.github.com/users/iea-annex60/followers","following_url":"https://api.github.com/users/iea-annex60/following{/other_user}","gists_url":"https://api.github.com/users/iea-annex60/gists{/gist_id}","starred_url":"https://api.github.com/users/iea-annex60/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iea-annex60/subscriptions","organizations_url":"https://api.github.com/users/iea-annex60/orgs","repos_url":"https://api.github.com/users/iea-annex60/repos","events_url":"https://api.github.com/users/iea-annex60/events{/privacy}","received_events_url":"https://api.github.com/users/iea-annex60/received_events","type":"Organization","site_admin":false},"repo":{"id":12990303,"name":"modelica-annex60","full_name":"iea-annex60/modelica-annex60","owner":{"login":"iea-annex60","id":5323273,"avatar_url":"https://avatars.githubusercontent.com/u/5323273?v=3","gravatar_id":"","url":"https://api.github.com/users/iea-annex60","html_url":"https://github.com/iea-annex60","followers_url":"https://api.github.com/users/iea-annex60/followers","following_url":"https://api.github.com/users/iea-annex60/following{/other_user}","gists_url":"https://api.github.com/users/iea-annex60/gists{/gist_id}","starred_url":"https://api.github.com/users/iea-annex60/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iea-annex60/subscriptions","organizations_url":"https://api.github.com/users/iea-annex60/orgs","repos_url":"https://api.github.com/users/iea-annex60/repos","events_url":"https://api.github.com/users/iea-annex60/events{/privacy}","received_events_url":"https://api.github.com/users/iea-annex60/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iea-annex60/modelica-annex60","description":"Modelica libraries that are used and/or developed within IEA EBC Annex 60","fork":false,"url":"https://api.github.com/repos/iea-annex60/modelica-annex60","forks_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/forks","keys_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/teams","hooks_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/hooks","issue_events_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues/events{/number}","events_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/events","assignees_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/assignees{/user}","branches_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/branches{/branch}","tags_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/tags","blobs_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/git/refs{/sha}","trees_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/statuses/{sha}","languages_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/languages","stargazers_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/stargazers","contributors_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/contributors","subscribers_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/subscribers","subscription_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/subscription","commits_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/commits{/sha}","git_commits_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/git/commits{/sha}","comments_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/comments{/number}","issue_comment_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues/comments{/number}","contents_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/contents/{+path}","compare_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/merges","archive_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/downloads","issues_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues{/number}","pulls_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/pulls{/number}","milestones_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/milestones{/number}","notifications_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/labels{/name}","releases_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/releases{/id}","created_at":"2013-09-21T05:49:03Z","updated_at":"2015-02-27T06:45:26Z","pushed_at":"2015-02-27T06:45:24Z","git_url":"git://github.com/iea-annex60/modelica-annex60.git","ssh_url":"git@github.com:iea-annex60/modelica-annex60.git","clone_url":"https://github.com/iea-annex60/modelica-annex60.git","svn_url":"https://github.com/iea-annex60/modelica-annex60","homepage":null,"size":14976,"stargazers_count":4,"watchers_count":4,"language":"Modelica","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":19,"forks":14,"open_issues":19,"watchers":4,"default_branch":"master"}},"base":{"label":"iea-annex60:master","ref":"master","sha":"20b2b3444af0869fbfcf5a3e96b10cd996a0fec3","user":{"login":"iea-annex60","id":5323273,"avatar_url":"https://avatars.githubusercontent.com/u/5323273?v=3","gravatar_id":"","url":"https://api.github.com/users/iea-annex60","html_url":"https://github.com/iea-annex60","followers_url":"https://api.github.com/users/iea-annex60/followers","following_url":"https://api.github.com/users/iea-annex60/following{/other_user}","gists_url":"https://api.github.com/users/iea-annex60/gists{/gist_id}","starred_url":"https://api.github.com/users/iea-annex60/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iea-annex60/subscriptions","organizations_url":"https://api.github.com/users/iea-annex60/orgs","repos_url":"https://api.github.com/users/iea-annex60/repos","events_url":"https://api.github.com/users/iea-annex60/events{/privacy}","received_events_url":"https://api.github.com/users/iea-annex60/received_events","type":"Organization","site_admin":false},"repo":{"id":12990303,"name":"modelica-annex60","full_name":"iea-annex60/modelica-annex60","owner":{"login":"iea-annex60","id":5323273,"avatar_url":"https://avatars.githubusercontent.com/u/5323273?v=3","gravatar_id":"","url":"https://api.github.com/users/iea-annex60","html_url":"https://github.com/iea-annex60","followers_url":"https://api.github.com/users/iea-annex60/followers","following_url":"https://api.github.com/users/iea-annex60/following{/other_user}","gists_url":"https://api.github.com/users/iea-annex60/gists{/gist_id}","starred_url":"https://api.github.com/users/iea-annex60/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iea-annex60/subscriptions","organizations_url":"https://api.github.com/users/iea-annex60/orgs","repos_url":"https://api.github.com/users/iea-annex60/repos","events_url":"https://api.github.com/users/iea-annex60/events{/privacy}","received_events_url":"https://api.github.com/users/iea-annex60/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iea-annex60/modelica-annex60","description":"Modelica libraries that are used and/or developed within IEA EBC Annex 60","fork":false,"url":"https://api.github.com/repos/iea-annex60/modelica-annex60","forks_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/forks","keys_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/teams","hooks_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/hooks","issue_events_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues/events{/number}","events_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/events","assignees_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/assignees{/user}","branches_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/branches{/branch}","tags_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/tags","blobs_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/git/refs{/sha}","trees_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/statuses/{sha}","languages_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/languages","stargazers_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/stargazers","contributors_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/contributors","subscribers_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/subscribers","subscription_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/subscription","commits_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/commits{/sha}","git_commits_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/git/commits{/sha}","comments_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/comments{/number}","issue_comment_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues/comments{/number}","contents_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/contents/{+path}","compare_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/merges","archive_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/downloads","issues_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues{/number}","pulls_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/pulls{/number}","milestones_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/milestones{/number}","notifications_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/labels{/name}","releases_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/releases{/id}","created_at":"2013-09-21T05:49:03Z","updated_at":"2015-02-27T06:45:26Z","pushed_at":"2015-02-27T06:45:24Z","git_url":"git://github.com/iea-annex60/modelica-annex60.git","ssh_url":"git@github.com:iea-annex60/modelica-annex60.git","clone_url":"https://github.com/iea-annex60/modelica-annex60.git","svn_url":"https://github.com/iea-annex60/modelica-annex60","homepage":null,"size":14976,"stargazers_count":4,"watchers_count":4,"language":"Modelica","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":19,"forks":14,"open_issues":19,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iea-annex60/modelica-annex60/pulls/153"},"html":{"href":"https://github.com/iea-annex60/modelica-annex60/pull/153"},"issue":{"href":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues/153"},"comments":{"href":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues/153/comments"},"review_comments":{"href":"https://api.github.com/repos/iea-annex60/modelica-annex60/pulls/153/comments"},"review_comment":{"href":"https://api.github.com/repos/iea-annex60/modelica-annex60/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iea-annex60/modelica-annex60/pulls/153/commits"},"statuses":{"href":"https://api.github.com/repos/iea-annex60/modelica-annex60/statuses/a304e4d654bc7ce431b26fdf44e7e9081f5ce2d5"}}}}