{"action":"closed","number":47378,"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/47378","id":54594149,"html_url":"https://github.com/Homebrew/homebrew/pull/47378","diff_url":"https://github.com/Homebrew/homebrew/pull/47378.diff","patch_url":"https://github.com/Homebrew/homebrew/pull/47378.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew/issues/47378","number":47378,"state":"closed","locked":false,"title":"Add -DNDEBUG to std_cmake_args","user":{"login":"aw1621107","id":566572,"avatar_url":"https://avatars.githubusercontent.com/u/566572?v=3","gravatar_id":"","url":"https://api.github.com/users/aw1621107","html_url":"https://github.com/aw1621107","followers_url":"https://api.github.com/users/aw1621107/followers","following_url":"https://api.github.com/users/aw1621107/following{/other_user}","gists_url":"https://api.github.com/users/aw1621107/gists{/gist_id}","starred_url":"https://api.github.com/users/aw1621107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aw1621107/subscriptions","organizations_url":"https://api.github.com/users/aw1621107/orgs","repos_url":"https://api.github.com/users/aw1621107/repos","events_url":"https://api.github.com/users/aw1621107/events{/privacy}","received_events_url":"https://api.github.com/users/aw1621107/received_events","type":"User","site_admin":false},"body":"CMake has -DNDEBUG and -O3 as its default flags for Release builds.\r\nHomebrew clears out the default CMake flags, which is fine for\r\noptimization because Homebrew passes its own optimization flag(s).\r\n-DNDEBUG wasn't added back in, though.\r\n\r\nThis ensures -DNDEBUG is passed to CMake release builds by default,\r\ninstead of individual formulas having to add it explicitly.","created_at":"2015-12-25T22:40:02Z","updated_at":"2015-12-26T21:52:12Z","closed_at":"2015-12-26T21:52:12Z","merged_at":null,"merge_commit_sha":"82a53349d376c334742a9a04b8756cf18f325eb4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/47378/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/47378/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/issues/47378/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/2d68af1e0767e6dcedf5580bf13600836436039c","head":{"label":"aw1621107:default_DNDEBUG","ref":"default_DNDEBUG","sha":"2d68af1e0767e6dcedf5580bf13600836436039c","user":{"login":"aw1621107","id":566572,"avatar_url":"https://avatars.githubusercontent.com/u/566572?v=3","gravatar_id":"","url":"https://api.github.com/users/aw1621107","html_url":"https://github.com/aw1621107","followers_url":"https://api.github.com/users/aw1621107/followers","following_url":"https://api.github.com/users/aw1621107/following{/other_user}","gists_url":"https://api.github.com/users/aw1621107/gists{/gist_id}","starred_url":"https://api.github.com/users/aw1621107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aw1621107/subscriptions","organizations_url":"https://api.github.com/users/aw1621107/orgs","repos_url":"https://api.github.com/users/aw1621107/repos","events_url":"https://api.github.com/users/aw1621107/events{/privacy}","received_events_url":"https://api.github.com/users/aw1621107/received_events","type":"User","site_admin":false},"repo":{"id":41757068,"name":"homebrew","full_name":"aw1621107/homebrew","owner":{"login":"aw1621107","id":566572,"avatar_url":"https://avatars.githubusercontent.com/u/566572?v=3","gravatar_id":"","url":"https://api.github.com/users/aw1621107","html_url":"https://github.com/aw1621107","followers_url":"https://api.github.com/users/aw1621107/followers","following_url":"https://api.github.com/users/aw1621107/following{/other_user}","gists_url":"https://api.github.com/users/aw1621107/gists{/gist_id}","starred_url":"https://api.github.com/users/aw1621107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aw1621107/subscriptions","organizations_url":"https://api.github.com/users/aw1621107/orgs","repos_url":"https://api.github.com/users/aw1621107/repos","events_url":"https://api.github.com/users/aw1621107/events{/privacy}","received_events_url":"https://api.github.com/users/aw1621107/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aw1621107/homebrew","description":":beer: The missing package manager for OS X.","fork":true,"url":"https://api.github.com/repos/aw1621107/homebrew","forks_url":"https://api.github.com/repos/aw1621107/homebrew/forks","keys_url":"https://api.github.com/repos/aw1621107/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aw1621107/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aw1621107/homebrew/teams","hooks_url":"https://api.github.com/repos/aw1621107/homebrew/hooks","issue_events_url":"https://api.github.com/repos/aw1621107/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/aw1621107/homebrew/events","assignees_url":"https://api.github.com/repos/aw1621107/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/aw1621107/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/aw1621107/homebrew/tags","blobs_url":"https://api.github.com/repos/aw1621107/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aw1621107/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aw1621107/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/aw1621107/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aw1621107/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/aw1621107/homebrew/languages","stargazers_url":"https://api.github.com/repos/aw1621107/homebrew/stargazers","contributors_url":"https://api.github.com/repos/aw1621107/homebrew/contributors","subscribers_url":"https://api.github.com/repos/aw1621107/homebrew/subscribers","subscription_url":"https://api.github.com/repos/aw1621107/homebrew/subscription","commits_url":"https://api.github.com/repos/aw1621107/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/aw1621107/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/aw1621107/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/aw1621107/homebrew/issues/comments{/number}","contents_url":"https://api.github.com/repos/aw1621107/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/aw1621107/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aw1621107/homebrew/merges","archive_url":"https://api.github.com/repos/aw1621107/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aw1621107/homebrew/downloads","issues_url":"https://api.github.com/repos/aw1621107/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/aw1621107/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/aw1621107/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/aw1621107/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aw1621107/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/aw1621107/homebrew/releases{/id}","created_at":"2015-09-01T18:53:17Z","updated_at":"2015-09-01T18:53:34Z","pushed_at":"2015-12-26T16:21:13Z","git_url":"git://github.com/aw1621107/homebrew.git","ssh_url":"git@github.com:aw1621107/homebrew.git","clone_url":"https://github.com/aw1621107/homebrew.git","svn_url":"https://github.com/aw1621107/homebrew","homepage":"http://brew.sh","size":64868,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"3b546e89bf16a2bf3a2cb113201290be97b3b897","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":206084,"name":"homebrew","full_name":"Homebrew/homebrew","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew","description":":beer: The missing package manager for OS X.","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew","forks_url":"https://api.github.com/repos/Homebrew/homebrew/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew/releases{/id}","created_at":"2009-05-20T19:38:37Z","updated_at":"2015-12-26T21:09:20Z","pushed_at":"2015-12-26T21:51:06Z","git_url":"git://github.com/Homebrew/homebrew.git","ssh_url":"git@github.com:Homebrew/homebrew.git","clone_url":"https://github.com/Homebrew/homebrew.git","svn_url":"https://github.com/Homebrew/homebrew","homepage":"http://brew.sh","size":1405877,"stargazers_count":28105,"watchers_count":28105,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":13910,"mirror_url":null,"open_issues_count":429,"forks":13910,"open_issues":429,"watchers":28105,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/47378"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/47378"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/47378"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/47378/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/47378/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/47378/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew/statuses/2d68af1e0767e6dcedf5580bf13600836436039c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":12,"review_comments":8,"commits":1,"additions":2,"deletions":6,"changed_files":4}}