{"action":"created","comment":{"url":"https://api.github.com/repos/rackerlabs/mimic/pulls/comments/38705849","id":38705849,"diff_hunk":"@@ -229,9 +229,12 @@ def create_node(self, http_create_request):\n         \"\"\"\n         content = loads(http_create_request.content.read())\n         try:\n+            memory_mb = 131072","path":"mimic/model/ironic_objects.py","position":4,"original_position":4,"commit_id":"a33f7286a78a9c3daa746d9f4a32a067cafdb605","original_commit_id":"a33f7286a78a9c3daa746d9f4a32a067cafdb605","user":{"login":"jimrollenhagen","id":565385,"avatar_url":"https://avatars.githubusercontent.com/u/565385?v=3","gravatar_id":"","url":"https://api.github.com/users/jimrollenhagen","html_url":"https://github.com/jimrollenhagen","followers_url":"https://api.github.com/users/jimrollenhagen/followers","following_url":"https://api.github.com/users/jimrollenhagen/following{/other_user}","gists_url":"https://api.github.com/users/jimrollenhagen/gists{/gist_id}","starred_url":"https://api.github.com/users/jimrollenhagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimrollenhagen/subscriptions","organizations_url":"https://api.github.com/users/jimrollenhagen/orgs","repos_url":"https://api.github.com/users/jimrollenhagen/repos","events_url":"https://api.github.com/users/jimrollenhagen/events{/privacy}","received_events_url":"https://api.github.com/users/jimrollenhagen/received_events","type":"User","site_admin":false},"body":"Should there be a default for this or should it be allowed to be empty?","created_at":"2015-09-03T22:51:04Z","updated_at":"2015-09-03T22:51:04Z","html_url":"https://github.com/rackerlabs/mimic/pull/393#discussion_r38705849","pull_request_url":"https://api.github.com/repos/rackerlabs/mimic/pulls/393","_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/mimic/pulls/comments/38705849"},"html":{"href":"https://github.com/rackerlabs/mimic/pull/393#discussion_r38705849"},"pull_request":{"href":"https://api.github.com/repos/rackerlabs/mimic/pulls/393"}}},"pull_request":{"url":"https://api.github.com/repos/rackerlabs/mimic/pulls/393","id":44166403,"html_url":"https://github.com/rackerlabs/mimic/pull/393","diff_url":"https://github.com/rackerlabs/mimic/pull/393.diff","patch_url":"https://github.com/rackerlabs/mimic/pull/393.patch","issue_url":"https://api.github.com/repos/rackerlabs/mimic/issues/393","number":393,"state":"open","locked":false,"title":"Add node has no required attributes","user":{"login":"lekhajee","id":1591551,"avatar_url":"https://avatars.githubusercontent.com/u/1591551?v=3","gravatar_id":"","url":"https://api.github.com/users/lekhajee","html_url":"https://github.com/lekhajee","followers_url":"https://api.github.com/users/lekhajee/followers","following_url":"https://api.github.com/users/lekhajee/following{/other_user}","gists_url":"https://api.github.com/users/lekhajee/gists{/gist_id}","starred_url":"https://api.github.com/users/lekhajee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lekhajee/subscriptions","organizations_url":"https://api.github.com/users/lekhajee/orgs","repos_url":"https://api.github.com/users/lekhajee/repos","events_url":"https://api.github.com/users/lekhajee/events{/privacy}","received_events_url":"https://api.github.com/users/lekhajee/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-03T22:43:40Z","updated_at":"2015-09-03T22:51:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec36df8e56b28ed20852554c1cac8428a07d6aa2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rackerlabs/mimic/pulls/393/commits","review_comments_url":"https://api.github.com/repos/rackerlabs/mimic/pulls/393/comments","review_comment_url":"https://api.github.com/repos/rackerlabs/mimic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rackerlabs/mimic/issues/393/comments","statuses_url":"https://api.github.com/repos/rackerlabs/mimic/statuses/a33f7286a78a9c3daa746d9f4a32a067cafdb605","head":{"label":"rackerlabs:change-ironic-add-node-requests-required-attributes","ref":"change-ironic-add-node-requests-required-attributes","sha":"a33f7286a78a9c3daa746d9f4a32a067cafdb605","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":13158707,"name":"mimic","full_name":"rackerlabs/mimic","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/mimic","description":"An API mock service","fork":false,"url":"https://api.github.com/repos/rackerlabs/mimic","forks_url":"https://api.github.com/repos/rackerlabs/mimic/forks","keys_url":"https://api.github.com/repos/rackerlabs/mimic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/mimic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/mimic/teams","hooks_url":"https://api.github.com/repos/rackerlabs/mimic/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/mimic/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/mimic/events","assignees_url":"https://api.github.com/repos/rackerlabs/mimic/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/mimic/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/mimic/tags","blobs_url":"https://api.github.com/repos/rackerlabs/mimic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/mimic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/mimic/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/mimic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/mimic/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/mimic/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/mimic/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/mimic/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/mimic/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/mimic/subscription","commits_url":"https://api.github.com/repos/rackerlabs/mimic/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/mimic/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/mimic/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/mimic/issues/comments{/number}","contents_url":"https://api.github.com/repos/rackerlabs/mimic/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/mimic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/mimic/merges","archive_url":"https://api.github.com/repos/rackerlabs/mimic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/mimic/downloads","issues_url":"https://api.github.com/repos/rackerlabs/mimic/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/mimic/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/mimic/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/mimic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/mimic/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/mimic/releases{/id}","created_at":"2013-09-27T19:01:16Z","updated_at":"2015-09-03T16:54:16Z","pushed_at":"2015-09-03T22:43:40Z","git_url":"git://github.com/rackerlabs/mimic.git","ssh_url":"git@github.com:rackerlabs/mimic.git","clone_url":"https://github.com/rackerlabs/mimic.git","svn_url":"https://github.com/rackerlabs/mimic","homepage":"","size":5522,"stargazers_count":91,"watchers_count":91,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":45,"mirror_url":null,"open_issues_count":87,"forks":45,"open_issues":87,"watchers":91,"default_branch":"master"}},"base":{"label":"rackerlabs:master","ref":"master","sha":"b6d30bf0add64d3daec77babd9d5d1aec483326a","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":13158707,"name":"mimic","full_name":"rackerlabs/mimic","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/mimic","description":"An API mock service","fork":false,"url":"https://api.github.com/repos/rackerlabs/mimic","forks_url":"https://api.github.com/repos/rackerlabs/mimic/forks","keys_url":"https://api.github.com/repos/rackerlabs/mimic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/mimic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/mimic/teams","hooks_url":"https://api.github.com/repos/rackerlabs/mimic/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/mimic/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/mimic/events","assignees_url":"https://api.github.com/repos/rackerlabs/mimic/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/mimic/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/mimic/tags","blobs_url":"https://api.github.com/repos/rackerlabs/mimic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/mimic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/mimic/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/mimic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/mimic/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/mimic/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/mimic/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/mimic/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/mimic/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/mimic/subscription","commits_url":"https://api.github.com/repos/rackerlabs/mimic/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/mimic/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/mimic/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/mimic/issues/comments{/number}","contents_url":"https://api.github.com/repos/rackerlabs/mimic/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/mimic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/mimic/merges","archive_url":"https://api.github.com/repos/rackerlabs/mimic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/mimic/downloads","issues_url":"https://api.github.com/repos/rackerlabs/mimic/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/mimic/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/mimic/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/mimic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/mimic/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/mimic/releases{/id}","created_at":"2013-09-27T19:01:16Z","updated_at":"2015-09-03T16:54:16Z","pushed_at":"2015-09-03T22:43:40Z","git_url":"git://github.com/rackerlabs/mimic.git","ssh_url":"git@github.com:rackerlabs/mimic.git","clone_url":"https://github.com/rackerlabs/mimic.git","svn_url":"https://github.com/rackerlabs/mimic","homepage":"","size":5522,"stargazers_count":91,"watchers_count":91,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":45,"mirror_url":null,"open_issues_count":87,"forks":45,"open_issues":87,"watchers":91,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/mimic/pulls/393"},"html":{"href":"https://github.com/rackerlabs/mimic/pull/393"},"issue":{"href":"https://api.github.com/repos/rackerlabs/mimic/issues/393"},"comments":{"href":"https://api.github.com/repos/rackerlabs/mimic/issues/393/comments"},"review_comments":{"href":"https://api.github.com/repos/rackerlabs/mimic/pulls/393/comments"},"review_comment":{"href":"https://api.github.com/repos/rackerlabs/mimic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rackerlabs/mimic/pulls/393/commits"},"statuses":{"href":"https://api.github.com/repos/rackerlabs/mimic/statuses/a33f7286a78a9c3daa746d9f4a32a067cafdb605"}}}}