{"action":"created","comment":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/33522926","id":33522926,"diff_hunk":"@@ -1206,6 +1206,136 @@ internal static void UpgradeActorRules(int engineVersion, ref List<MiniYamlNode>\n \t\t\t\t\t}\n \t\t\t\t}\n \n+\t\t\t\t// Removed RenderUnit\n+\t\t\t\tif (engineVersion < 20150630)\n+\t\t\t\t{\n+\t\t\t\t\t// Renamed WithHarvestAnimation to WithHarvestOverlay\n+\t\t\t\t\tif (node.Key == \"WithHarvestAnimation\")\n+\t\t\t\t\t\tnode.Key = \"WithHarvestOverlay\";\n+\n+\t\t\t\t\t// Replaced RenderLandingCraft with With*Body + WithLandingCraftAnimation.\n+\t\t\t\t\t// Note: These rules are set up to do approximately the right thing for maps, but\n+\t\t\t\t\t// mods might need additional manual tweaks. This is the best we can do without having\n+\t\t\t\t\t// much smarter rules parsing, because we currently can't reason about inherited traits.\n+\t\t\t\t\tif (depth == 0)\n+\t\t\t\t\t{\n+\t\t\t\t\t\tvar childKeySequence = new[] { \"Sequence\" };\n+\t\t\t\t\t\tvar childKeysExcludeFromRS = new[] { \"Sequence\", \"OpenTerrainTypes\", \"OpenSequence\", \"UnloadSequence\" };\n+\n+\t\t\t\t\t\tvar rlc = node.Value.Nodes.FirstOrDefault(n => n.Key.StartsWith(\"RenderLandingCraft\"));\n+\t\t\t\t\t\tif (rlc != null)\n+\t\t\t\t\t\t{\n+\t\t\t\t\t\t\trlc.Key = \"WithLandingCraftAnimation\";\n+\n+\t\t\t\t\t\t\tvar rsNodes = rlc.Value.Nodes.Where(n => !childKeysExcludeFromRS.Contains(n.Key)).ToList();\n+\t\t\t\t\t\t\tvar wfsbNodes = rlc.Value.Nodes.Where(n => childKeySequence.Contains(n.Key)).ToList();\n+\n+\t\t\t\t\t\t\tif (rsNodes.Any())\n+\t\t\t\t\t\t\t\tnode.Value.Nodes.Add(new MiniYamlNode(\"RenderSprites\", new MiniYaml(\"\", rsNodes)));\n+\t\t\t\t\t\t\telse\n+\t\t\t\t\t\t\t\tnode.Value.Nodes.Add(new MiniYamlNode(\"RenderSprites\", \"\"));\n+\n+\t\t\t\t\t\t\t// Note: For the RA landing craft WithSpriteBody would be sufficient since it has no facings,\n+\t\t\t\t\t\t\t// but WithFacingSpriteBody works as well and covers the potential case where a third-party mod\n+\t\t\t\t\t\t\t// might have given their landing craft multiple facings.\n+\t\t\t\t\t\t\tif (wfsbNodes.Any())\n+\t\t\t\t\t\t\t\tnode.Value.Nodes.Add(new MiniYamlNode(\"WithFacingSpriteBody\", new MiniYaml(\"\", wfsbNodes)));\n+\t\t\t\t\t\t\telse\n+\t\t\t\t\t\t\t\tnode.Value.Nodes.Add(new MiniYamlNode(\"WithFacingSpriteBody\", \"\"));\n+\n+\t\t\t\t\t\t\tnode.Value.Nodes.Add(new MiniYamlNode(\"AutoSelectionSize\", \"\"));\n+\n+\t\t\t\t\t\t\trlc.Value.Nodes.RemoveAll(n => rsNodes.Contains(n));\n+\t\t\t\t\t\t\trlc.Value.Nodes.RemoveAll(n => wfsbNodes.Contains(n));\n+\t\t\t\t\t\t}\n+\n+\t\t\t\t\t\tvar rrlc = node.Value.Nodes.FirstOrDefault(n => n.Key.StartsWith(\"-RenderLandingCraft\"));\n+\t\t\t\t\t\tif (rrlc != null)\n+\t\t\t\t\t\t\trrlc.Key = \"-WithLandingCraftAnimation\";\n+\t\t\t\t\t}\n+\n+\t\t\t\t\t// Replaced RenderHarvester with WithFacingSpriteBody + WithHarvestAnimation.","path":"OpenRA.Mods.Common/UtilityCommands/UpgradeRules.cs","position":52,"original_position":52,"commit_id":"da97cce4b584621ece7ade1abe20f2d89513ac51","original_commit_id":"da97cce4b584621ece7ade1abe20f2d89513ac51","user":{"login":"penev92","id":7137365,"avatar_url":"https://avatars.githubusercontent.com/u/7137365?v=3","gravatar_id":"","url":"https://api.github.com/users/penev92","html_url":"https://github.com/penev92","followers_url":"https://api.github.com/users/penev92/followers","following_url":"https://api.github.com/users/penev92/following{/other_user}","gists_url":"https://api.github.com/users/penev92/gists{/gist_id}","starred_url":"https://api.github.com/users/penev92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/penev92/subscriptions","organizations_url":"https://api.github.com/users/penev92/orgs","repos_url":"https://api.github.com/users/penev92/repos","events_url":"https://api.github.com/users/penev92/events{/privacy}","received_events_url":"https://api.github.com/users/penev92/received_events","type":"User","site_admin":false},"body":"Nit: + WithDockingAnimation","created_at":"2015-06-29T22:44:08Z","updated_at":"2015-06-29T22:44:08Z","html_url":"https://github.com/OpenRA/OpenRA/pull/8553#discussion_r33522926","pull_request_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/8553","_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/33522926"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/8553#discussion_r33522926"},"pull_request":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/8553"}}},"pull_request":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/8553","id":38390247,"html_url":"https://github.com/OpenRA/OpenRA/pull/8553","diff_url":"https://github.com/OpenRA/OpenRA/pull/8553.diff","patch_url":"https://github.com/OpenRA/OpenRA/pull/8553.patch","issue_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/8553","number":8553,"state":"open","locked":false,"title":"Removed RenderHarvester, RenderLandingCraft and RenderUnit","user":{"login":"reaperrr","id":2857877,"avatar_url":"https://avatars.githubusercontent.com/u/2857877?v=3","gravatar_id":"","url":"https://api.github.com/users/reaperrr","html_url":"https://github.com/reaperrr","followers_url":"https://api.github.com/users/reaperrr/followers","following_url":"https://api.github.com/users/reaperrr/following{/other_user}","gists_url":"https://api.github.com/users/reaperrr/gists{/gist_id}","starred_url":"https://api.github.com/users/reaperrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaperrr/subscriptions","organizations_url":"https://api.github.com/users/reaperrr/orgs","repos_url":"https://api.github.com/users/reaperrr/repos","events_url":"https://api.github.com/users/reaperrr/events{/privacy}","received_events_url":"https://api.github.com/users/reaperrr/received_events","type":"User","site_admin":false},"body":"With this PR, ```RenderUnit``` and its childs are finally removed.\r\n\r\nReplaces ```RenderHarvester``` with ```WithHarvesterAnimation```, and ```RenderLandingCraft``` with ```WithLandingCraftAnimation```, and removes all remaining usages of ```RenderUnit``` as well as the trait itself.\r\n\r\nAdditionally fixes the namespace of ```WithAttackAnimation``` and the name of ```WithHarvestOverlay``` (used by d2k and TS harvesters).","created_at":"2015-06-23T22:30:13Z","updated_at":"2015-06-29T22:44:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d94847c011ce78a49fdccb5094e0b579f251a714","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/8553/commits","review_comments_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/8553/comments","review_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/8553/comments","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/da97cce4b584621ece7ade1abe20f2d89513ac51","head":{"label":"reaperrr:rem-renderunit","ref":"rem-renderunit","sha":"da97cce4b584621ece7ade1abe20f2d89513ac51","user":{"login":"reaperrr","id":2857877,"avatar_url":"https://avatars.githubusercontent.com/u/2857877?v=3","gravatar_id":"","url":"https://api.github.com/users/reaperrr","html_url":"https://github.com/reaperrr","followers_url":"https://api.github.com/users/reaperrr/followers","following_url":"https://api.github.com/users/reaperrr/following{/other_user}","gists_url":"https://api.github.com/users/reaperrr/gists{/gist_id}","starred_url":"https://api.github.com/users/reaperrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaperrr/subscriptions","organizations_url":"https://api.github.com/users/reaperrr/orgs","repos_url":"https://api.github.com/users/reaperrr/repos","events_url":"https://api.github.com/users/reaperrr/events{/privacy}","received_events_url":"https://api.github.com/users/reaperrr/received_events","type":"User","site_admin":false},"repo":{"id":6804707,"name":"OpenRA","full_name":"reaperrr/OpenRA","owner":{"login":"reaperrr","id":2857877,"avatar_url":"https://avatars.githubusercontent.com/u/2857877?v=3","gravatar_id":"","url":"https://api.github.com/users/reaperrr","html_url":"https://github.com/reaperrr","followers_url":"https://api.github.com/users/reaperrr/followers","following_url":"https://api.github.com/users/reaperrr/following{/other_user}","gists_url":"https://api.github.com/users/reaperrr/gists{/gist_id}","starred_url":"https://api.github.com/users/reaperrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaperrr/subscriptions","organizations_url":"https://api.github.com/users/reaperrr/orgs","repos_url":"https://api.github.com/users/reaperrr/repos","events_url":"https://api.github.com/users/reaperrr/events{/privacy}","received_events_url":"https://api.github.com/users/reaperrr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reaperrr/OpenRA","description":"An open-source implementation of the Red Alert engine using .NET/mono and OpenGL. Runs on Windows, Linux and OSX. Bugs at http://bugs.open-ra.org/","fork":true,"url":"https://api.github.com/repos/reaperrr/OpenRA","forks_url":"https://api.github.com/repos/reaperrr/OpenRA/forks","keys_url":"https://api.github.com/repos/reaperrr/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reaperrr/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reaperrr/OpenRA/teams","hooks_url":"https://api.github.com/repos/reaperrr/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/reaperrr/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/reaperrr/OpenRA/events","assignees_url":"https://api.github.com/repos/reaperrr/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/reaperrr/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/reaperrr/OpenRA/tags","blobs_url":"https://api.github.com/repos/reaperrr/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reaperrr/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reaperrr/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/reaperrr/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reaperrr/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/reaperrr/OpenRA/languages","stargazers_url":"https://api.github.com/repos/reaperrr/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/reaperrr/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/reaperrr/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/reaperrr/OpenRA/subscription","commits_url":"https://api.github.com/repos/reaperrr/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/reaperrr/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/reaperrr/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/reaperrr/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/reaperrr/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/reaperrr/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reaperrr/OpenRA/merges","archive_url":"https://api.github.com/repos/reaperrr/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reaperrr/OpenRA/downloads","issues_url":"https://api.github.com/repos/reaperrr/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/reaperrr/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/reaperrr/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/reaperrr/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reaperrr/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/reaperrr/OpenRA/releases{/id}","created_at":"2012-11-21T23:13:26Z","updated_at":"2015-02-23T21:29:06Z","pushed_at":"2015-06-29T22:35:45Z","git_url":"git://github.com/reaperrr/OpenRA.git","ssh_url":"git@github.com:reaperrr/OpenRA.git","clone_url":"https://github.com/reaperrr/OpenRA.git","svn_url":"https://github.com/reaperrr/OpenRA","homepage":"http://open-ra.org","size":99216,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"bleed"}},"base":{"label":"OpenRA:bleed","ref":"bleed","sha":"9ed9d746a1f99628e1d23fb951ed179d857236b3","user":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"repo":{"id":959908,"name":"OpenRA","full_name":"OpenRA/OpenRA","owner":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenRA/OpenRA","description":"Open Source real-time strategy game engine for early Westwood games such as Command & Conquer: Red Alert written in C# using SDL and OpenGL. Runs on Windows, Linux, *BSD and Mac OS X.","fork":false,"url":"https://api.github.com/repos/OpenRA/OpenRA","forks_url":"https://api.github.com/repos/OpenRA/OpenRA/forks","keys_url":"https://api.github.com/repos/OpenRA/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenRA/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenRA/OpenRA/teams","hooks_url":"https://api.github.com/repos/OpenRA/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/OpenRA/OpenRA/events","assignees_url":"https://api.github.com/repos/OpenRA/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/OpenRA/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/OpenRA/OpenRA/tags","blobs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenRA/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenRA/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenRA/OpenRA/languages","stargazers_url":"https://api.github.com/repos/OpenRA/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/OpenRA/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/OpenRA/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/OpenRA/OpenRA/subscription","commits_url":"https://api.github.com/repos/OpenRA/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenRA/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenRA/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/OpenRA/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenRA/OpenRA/merges","archive_url":"https://api.github.com/repos/OpenRA/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenRA/OpenRA/downloads","issues_url":"https://api.github.com/repos/OpenRA/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenRA/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenRA/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenRA/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/OpenRA/OpenRA/releases{/id}","created_at":"2010-10-04T07:38:05Z","updated_at":"2015-06-29T14:07:11Z","pushed_at":"2015-06-29T22:35:46Z","git_url":"git://github.com/OpenRA/OpenRA.git","ssh_url":"git@github.com:OpenRA/OpenRA.git","clone_url":"https://github.com/OpenRA/OpenRA.git","svn_url":"https://github.com/OpenRA/OpenRA","homepage":"http://www.openra.net","size":179253,"stargazers_count":1985,"watchers_count":1985,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":716,"mirror_url":null,"open_issues_count":797,"forks":716,"open_issues":797,"watchers":1985,"default_branch":"bleed"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/8553"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/8553"},"issue":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/8553"},"comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/8553/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/8553/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/8553/commits"},"statuses":{"href":"https://api.github.com/repos/OpenRA/OpenRA/statuses/da97cce4b584621ece7ade1abe20f2d89513ac51"}}}}