{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/14603","labels_url":"https://api.github.com/repos/docker/docker/issues/14603/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/14603/comments","events_url":"https://api.github.com/repos/docker/docker/issues/14603/events","html_url":"https://github.com/docker/docker/issues/14603","id":94785534,"number":14603,"title":"Proposal refactor : Use dockerCmd to run docker commands in integration-cli tests","user":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars.githubusercontent.com/u/6508?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-07-13T18:48:26Z","updated_at":"2015-07-14T01:44:45Z","closed_at":null,"body":"As discussed a little bit on IRC, it would be could if *almost* all cli integration test would use ``dockerCmd``.\r\n\r\nThis issue is there to list the files that need updates so we can share the work :wink:. I'll keep this list up-to-date when PR will be merged. If you wanna work on this, please comment which file(s) you wanna work on, and I'll add your name :sweat_smile:.\r\n\r\nIf the test needs to check out that it errors out (``err != nil``) then do not use ``dockerCmd`` — but you could use something like : ``runCommandWithOutput(exec.Command(dockerBinary, \"diff\", \"\"))`` (like [here](https://github.com/docker/docker/pull/14500#discussion-diff-34479965)).\r\n\r\n- [ ] integration-cli/docker_cli_attach_test.go (vdemeester)\r\n- [ ] integration-cli/docker_cli_attach_unix_test.go (vdemeester)\r\n- [ ] integration-cli/docker_cli_build_test.go (vdemeester)\r\n- [ ] integration-cli/docker_cli_build_unix_test.go (vdemeester)\r\n- [ ] integration-cli/docker_cli_by_digest_test.go (vdemeester)\r\n- [ ] integration-cli/docker_cli_commit_test.go (vdemeester)\r\n- [ ] integration-cli/docker_cli_config_test.go (vdemeester)\r\n- [ ] integration-cli/docker_cli_cp_test.go (vdemeester)\r\n- [ ] integration-cli/docker_cli_create_test.go (vdemeester)\r\n- [ ] integration-cli/docker_cli_daemon_experimental_test.go\r\n- [ ] integration-cli/docker_cli_daemon_test.go\r\n- [ ] integration-cli/docker_cli_diff_test.go\r\n- [ ] integration-cli/docker_cli_events_test.go\r\n- [ ] integration-cli/docker_cli_events_unix_test.go\r\n- [ ] integration-cli/docker_cli_exec_test.go\r\n- [ ] integration-cli/docker_cli_exec_unix_test.go\r\n- [ ] integration-cli/docker_cli_experimental_test.go\r\n- [ ] integration-cli/docker_cli_export_import_test.go\r\n- [ ] integration-cli/docker_cli_help_test.go\r\n- [ ] integration-cli/docker_cli_history_test.go\r\n- [ ] integration-cli/docker_cli_images_test.go\r\n- [ ] integration-cli/docker_cli_import_test.go\r\n- [ ] integration-cli/docker_cli_info_test.go\r\n- [ ] integration-cli/docker_cli_inspect_test.go\r\n- [ ] integration-cli/docker_cli_kill_test.go\r\n- [ ] integration-cli/docker_cli_links_test.go\r\n- [ ] integration-cli/docker_cli_links_unix_test.go\r\n- [ ] integration-cli/docker_cli_login_test.go\r\n- [ ] integration-cli/docker_cli_logs_test.go\r\n- [ ] integration-cli/docker_cli_nat_test.go\r\n- [ ] integration-cli/docker_cli_network_test.go\r\n- [ ] integration-cli/docker_cli_pause_test.go\r\n- [ ] integration-cli/docker_cli_port_test.go\r\n- [ ] integration-cli/docker_cli_port_unix_test.go\r\n- [ ] integration-cli/docker_cli_proxy_test.go\r\n- [ ] integration-cli/docker_cli_ps_test.go\r\n- [ ] integration-cli/docker_cli_pull_test.go\r\n- [ ] integration-cli/docker_cli_push_test.go\r\n- [ ] integration-cli/docker_cli_rename_test.go\r\n- [ ] integration-cli/docker_cli_restart_test.go\r\n- [ ] integration-cli/docker_cli_rmi_test.go\r\n- [ ] integration-cli/docker_cli_rm_test.go\r\n- [ ] integration-cli/docker_cli_run_test.go\r\n- [ ] integration-cli/docker_cli_run_unix_test.go\r\n- [ ] integration-cli/docker_cli_save_load_test.go\r\n- [ ] integration-cli/docker_cli_save_load_unix_test.go\r\n- [ ] integration-cli/docker_cli_search_test.go\r\n- [ ] integration-cli/docker_cli_service_test.go\r\n- [ ] integration-cli/docker_cli_start_test.go\r\n- [ ] integration-cli/docker_cli_start_volume_driver_unix_test.go\r\n- [ ] integration-cli/docker_cli_stats_test.go\r\n- [ ] integration-cli/docker_cli_tag_test.go\r\n- [ ] integration-cli/docker_cli_top_test.go\r\n- [ ] integration-cli/docker_cli_version_test.go\r\n- [ ] integration-cli/docker_cli_wait_test.go\r\n- [ ] integration-cli/docker_test_vars_cli.go\r\n\r\nFeels like a lot :blush:.\r\n\r\n*Notes*: We might want a ``dockerCmdWithStdin`` or some way to customize a bit (in ``docker_cli_build_test.go`` for example)."},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/121108684","html_url":"https://github.com/docker/docker/issues/14603#issuecomment-121108684","issue_url":"https://api.github.com/repos/docker/docker/issues/14603","id":121108684,"user":{"login":"coolljt0725","id":8232360,"avatar_url":"https://avatars.githubusercontent.com/u/8232360?v=3","gravatar_id":"","url":"https://api.github.com/users/coolljt0725","html_url":"https://github.com/coolljt0725","followers_url":"https://api.github.com/users/coolljt0725/followers","following_url":"https://api.github.com/users/coolljt0725/following{/other_user}","gists_url":"https://api.github.com/users/coolljt0725/gists{/gist_id}","starred_url":"https://api.github.com/users/coolljt0725/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coolljt0725/subscriptions","organizations_url":"https://api.github.com/users/coolljt0725/orgs","repos_url":"https://api.github.com/users/coolljt0725/repos","events_url":"https://api.github.com/users/coolljt0725/events{/privacy}","received_events_url":"https://api.github.com/users/coolljt0725/received_events","type":"User","site_admin":false},"created_at":"2015-07-14T01:44:45Z","updated_at":"2015-07-14T01:44:45Z","body":"I'd like to  take the last 6 from `integration-cli/docker_cli_stats_test.go` to `integration-cli/docker_test_vars_cli.go`"}}